Clean out last vestiges of the old HAVE_CONFIG_H stuff.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
cf38a720
PE
12012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2
3 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
4 * Makefile.in (ALL_CFLAGS):
5 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
6 * gmalloc.c, regex.c: Include <config.h> unconditionally.
7
3511c784
DA
82012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
9
0a08eb21 10 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
11 strcasecmp if available.
12 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
13
fb7da12e
AS
142012-06-25 Andreas Schwab <schwab@linux-m68k.org>
15
16 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
17 Avoid comma operator.
18 * menu.c (push_submenu_start, push_submenu_end)
19 (push_left_right_boundary, push_menu_pane): Likewise.
20 * msdos.c (dos_rawgetc): Likewise.
21
afa2ffd8
DA
222012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
23
24 * xfns.c (xic_create_fontsetname): Remove redundant calls
25 to memset.
26
b3b4476b
PE
272012-06-25 Paul Eggert <eggert@cs.ucla.edu>
28
4495ff38
PE
29 * gtkutil.c (get_utf8_string): Remove redundant assignment.
30 sprintf already null-terminates its output.
31
b3b4476b
PE
32 * xfns.c (x_window): Remove redundant cast.
33
b00876c9
DA
342012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
35
36 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
37 `const char *' to `char *' to avoid compiler warning.
38
d188e26b
PE
392012-06-24 Paul Eggert <eggert@cs.ucla.edu>
40
885d1d74
PE
41 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
42 instead of truncating it to 63 (admittedly a generous limit).
43
d188e26b
PE
44 * process.c: Fix spelling and caps in comments.
45
e2f560b1
DN
462012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
47
e86db54b 48 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
49 * sysdep.c (setpgrp): Remove definition, not used in this file.
50
7583a3a1
JB
512012-06-24 Juanma Barranquero <lekktu@gmail.com>
52
53 * makefile.w32-in: Update dependencies.
54
696056c2
EZ
552012-06-24 Eli Zaretskii <eliz@gnu.org>
56
57 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
58 (SYSTIME_H): Add nt/inc/sys/time.h.
59
60 * systime.h [WINDOWSNT]: Include sys/time.h.
61
62 * s/ms-w32.h (struct timespec): Definition moved from
63 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
64
845ca893
PE
652012-06-24 Paul Eggert <eggert@cs.ucla.edu>
66
67 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
68 * buffer.h (buffer_slot_type_mismatch):
69 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
70 * eval.c (unwind_to_catch):
71 * image.c (my_png_error, my_error_exit):
72 * keyboard.c (quit_throw_to_read_char, user_error)
73 (Fexit_recursive_edit, Fabort_recursive_edit):
74 * lisp.h (die, args_out_of_range, args_out_of_range_3)
75 (wrong_type_argument, buffer_overflow, __executable_start)
76 (memory_full, buffer_memory_full, string_overflow, Fthrow)
77 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
78 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
79 (fatal):
80 (child_setup) [!DOS_NT]:
81 * lread.c (end_of_file_error, invalid_syntax):
82 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
83 * puresize.h (pure_write_error):
84 * search.c (matcher_overflow):
85 * sound.c (sound_perror, alsa_sound_perror):
86 * sysdep.c, syssignal.h (croak):
87 * term.c (maybe_fatal, vfatal):
88 * textprop.c (text_read_only):
89 * undo.c (user_error):
90 * unexmacosx.c (unexec_error):
91 * xterm.c (x_ins_del_lines, x_delete_glyphs):
92 Use _Noreturn rather than NO_RETURN.
93 No need for separate decl merely because of _Noreturn.
94 * sound.c (sound_warning, parse_sound):
95 Remove unnecessary forward decls.
96
f1dd8073
PE
972012-06-24 Paul Eggert <eggert@cs.ucla.edu>
98
99 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
100 * lisp.h (WAIT_READING_MAX): New macro.
101 * dispnew.c (Fsleep_for, sit_for):
102 * keyboard.c (kbd_buffer_get_event):
103 * process.c (Faccept_process_output):
104 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
105 This improves on the previous patch, which introduced a bug
106 when time_t is unsigned and as wide as intmax_t.
107 See <http://bugs.gnu.org/9000#51>.
108
b82c1755
EZ
1092012-06-23 Eli Zaretskii <eliz@gnu.org>
110
111 * dispnew.c (sit_for, Fsleep_for):
112 * keyboard.c (kbd_buffer_get_event):
113 * process.c (Faccept_process_output): Avoid compiler warnings when
114 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
115
ca300656
JB
1162012-06-23 Juanma Barranquero <lekktu@gmail.com>
117
049ec95b
JB
118 * makefile.w32-in: Update dependencies.
119
ca300656
JB
120 * w32.c (ltime): Add return type and declare static.
121 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
122
db7b8d06
PE
1232012-06-23 Paul Eggert <eggert@cs.ucla.edu>
124
125 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
126 Privately reported by Herbert J. Skuhra.
127 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
128 All uses changed.
129 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
130 not make_lisp_timeval, when the argument is of type EMACS_TIME.
131
0bd8297f
EZ
1322012-06-23 Eli Zaretskii <eliz@gnu.org>
133
96512555
EZ
134 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
135 last argument of make_unibyte_string.
136
0bd8297f
EZ
137 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
138 language ID in the event parameters.
139
140 * w32term.c (w32_read_socket): Put the new keyboard codepage into
141 event.code, not the obscure "character set ID".
142
63def6b6
CY
1432012-06-23 Chong Yidong <cyd@gnu.org>
144
145 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
146
e8a02204
EZ
1472012-06-23 Eli Zaretskii <eliz@gnu.org>
148
388cdec0
EZ
149 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
150 * w32.c (fdutimens): New function.
151
152 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
153
154 * s/ms-w32.h (pselect): Redirect to sys_select.
155
156 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
157
e8a02204
EZ
158 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
159 in the logic of incrementing and decrementing the value of
160 use_relocatable_buffers.
161
d054f3fb
PE
1622012-06-23 Paul Eggert <eggert@cs.ucla.edu>
163
164 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
165 Privately reported by Herbert J. Skuhra.
166 [__FreeBSD__]: Remove "*/" typo after "#include".
167 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
168 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
169 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
170 Don't assume EMACS_TIME and struct timeval are the same type.
171
d35af63c
PE
1722012-06-22 Paul Eggert <eggert@cs.ucla.edu>
173
174 Support higher-resolution time stamps (Bug#9000).
175 The time stamps are only nanosecond-resolution at the C level,
176 since that's the best that any real-world system supports now.
177 But they are picosecond-resolution at the Lisp level, as that's
178 easy, and leaves room for future OS improvements.
179
180 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
181 (LIBES): Use it.
182
183 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
184 Don't get current time unless it's needed.
185
186 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
187 now provides it if it's absent.
188 (start_atimer): Port to higher-res time stamps.
189 Check for time stamp overflow. Don't get current time more
190 often than is needed.
191
192 * buffer.h (struct buffer): Buffer modtime now has high resolution.
193 Include systime.h, not time.h.
194 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
195
196 * dired.c: Include stat-time.h.
197 (Ffile-attributes): File times now have higher resolution.
198
199 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
200 (struct image): Timestamp now has higher resolution.
201
202 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
203 has at least microseconds now. All uses removed.
204 (update_frame, update_single_window, update_window, update_frame_1)
205 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
206
207 * editfns.c (time_overflow): Now extern.
208 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
209 (float-time, Fformat_time_string, Fcurrent_time_string)
210 (Fcurrent_time_zone): Accept and generate higher-resolution
211 time stamps.
212 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
213 (decode_time_components, lisp_seconds_argument): New functions.
214 (make_time): Now static.
215 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
216 Report an error if the time is invalid, rather than having the caller
217 do that.
218
219 * fileio.c: Include <stat-time.h>
220 (Fcopy_file): Copy higher-resolution time stamps.
221 Prefer to set the time stamp via a file descriptor if that works.
222 (Fset_file_times, Finsert_file_contents, Fwrite_region)
223 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
224 (Fvisited_file_modtime, Fset_visited_file_modtime):
225 Support higher-resolution time stamps.
226
227 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
228
229 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
230
231 * image.c (prepare_image_for_display, clear_image_cache)
232 (lookup_image): Port to higer-resolution time stamps.
233
234 * keyboard.c (start_polling, bind_polling_period):
235 Check for time stamp overflow.
236 (read_char, kbd_buffer_get_event, timer_start_idle)
237 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
238 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
239 Port to higher-resolution time stamps. Do not assume time_t is signed.
240 (decode_timer): New function. Timers are now vectors of length 9,
241 not 8, to accommodate the picosecond component.
242 (timer_check_2): Use it.
243
244 * nsterm.m (select_timeout, timeval_subtract): Remove.
245 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
246 as they're a bit more accurate and handle overflow better.
247 (ns_select): Change prototype to be compatible with pselect.
248 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
249 * nsterm.h (ns_select): Adjust prototype.
250
251 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
252 us-resolution time stamps.
253 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
254
255 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
256
257 * lisp.h (time_overflow): New decl.
258 (wait_reading_process_output): First arg is now intmax_t, not int,
259 to accommodate larger waits.
260
261 * process.h (struct Lisp_Process.read_output_delay):
262 Now counts nanoseconds, not microseconds.
263 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
264 EMACS_HAS_USECS.
265 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
266 (wait_reading_process_output):
267 Port to ns-resolution time stamps.
268 (Faccept_process_output, wait_reading_process_output):
269 Check for time stamp overflow. Do not assume time_t is signed.
270 (select_wrapper): Remove; we now use pselect.
271 (Fprocess_attributes): Now generates ns-resolution time stamps.
272
273 * sysdep.c: Include utimens.h. Don't include utime.h
274 or worry about struct utimbuf; gnulib does that for us now.
275 (gettimeofday): Remove; gnulib provides a substitute.
276 (make_timeval): New function.
277 (set_file_times): Now sets ns-resolution time stamps.
278 New arg FD; all uses changed.
279 (time_from_jiffies, ltime_from_jiffies, get_up_time)
280 (system_process_attributes):
281 Now returns ns-resolution time stamp. All uses changed.
282 Check for time stamp overflow.
283
284 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
285 provides a substitute now.
286
287 * systime.h: Include timespec.h rather than sys/time.h and time.h,
288 since it guarantees struct timespec.
289 (EMACS_TIME): Now struct timespec, so that we can support
290 ns-resolution time stamps.
291 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
292 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
293 (EMACS_USECS): Remove.
294 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
295 so multiply the arg by 1000 before storing it.
296 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
297 New macros.
298 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
299 Port to ns-resolution time stamps.
300 (EMACS_TIME_NEG_P): Remove; replaced by....
301 (EMACS_TIME_SIGN): New macro.
302 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
303 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
304 (set_file_times, make_time, lisp_time_argument): Adjust signature.
305 (make_timeval, make_lisp_time, decode_time_components): New decls.
306 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
307 that it mishandled time_t overflow. You can't compare by subtracting!
308 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
309 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
310
311 * term.c: Include <sys/time.h>.
312 (timeval_to_Time): New function, for proper overflow wraparound.
313 (term_mouse_position, term_mouse_click): Use it.
314
315 * undo.c (record_first_change): Support higher-resolution time stamps
316 in the undo buffer.
317 (Fprimitive_undo): Use them when restoring time stamps.
318
319 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
320 (w32_get_internal_run_time):
321 Port to higher-resolution Emacs time stamps.
322 (ltime): Now accepts single 64-bit integer, as that's more convenient
323 for callers.
324
325 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
326
327 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
328 for compatibility with pselect. Support ns-resolution time stamps.
329
330 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
331
332 * xselect.c (wait_for_property_change, x_get_foreign_selection):
333 Check for time stamp overflow, and support ns-resolution time stamps.
334
335 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
336 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
337 (timeval_subtract): Remove; no longer needed.
338 (XTflash, XTring_bell, x_wait_for_event):
339 Port to ns-resolution time stamps. Don't assume time_t is signed.
340
b6a92dfe
CY
3412012-06-22 Chong Yidong <cyd@gnu.org>
342
343 * xdisp.c (x_consider_frame_title): Revert last change.
344
d251c37c
EZ
3452012-06-22 Eli Zaretskii <eliz@gnu.org>
346
347 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
348 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
349 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
350 staticidx goes up to 1597 out of 1600 = 0x640.)
351
f10deafb
PE
3522012-06-20 Paul Eggert <eggert@cs.ucla.edu>
353
354 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
355 Otherwise, the umask might be mistakenly 0 while handling input signals.
356
ec6de1e2
SM
3572012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
358
359 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
360
28be1ada
DA
3612012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
362
363 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
364 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
365 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
366 access to `contents' member of Lisp_Vector objects with AREF and ASET
367 where appropriate.
368
c6bf3022
CY
3692012-06-19 Chong Yidong <cyd@gnu.org>
370
371 * frame.c (delete_frame): When selecting a frame on a different
372 text terminal, do not alter the terminal's top-frame.
373
374 * xdisp.c (format_mode_line_unwind_data): Record the target
375 frame's selected window and its terminal's top-frame.
376 (unwind_format_mode_line): Restore them.
377 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
378 Callers changed.
379 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
380 since tty frames can be explicitly named.
381 (prepare_menu_bars): Likewise.
382
383 * term.c (Ftty_top_frame): New function.
384
defd4196
PE
3852012-06-18 Paul Eggert <eggert@cs.ucla.edu>
386
387 Port byte-code-meter to modern targets.
388 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
389 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 390 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
391 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
392 (METER_1, METER_2): Simplify.
393
1053a871
SM
3942012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
395
396 * data.c (Fdefalias): Return `symbol' (bug#11686).
397
b7e8d081
MR
3982012-06-18 Martin Rudalics <rudalics@gmx.at>
399
400 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
401 gets killed during executing of this function (Bug#11665).
402 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
403 (Vkill_buffer_query_functions): In doc-string say that functions
404 run by this hook should not change the current buffer.
405
7ea2b339
PE
4062012-06-18 Paul Eggert <eggert@cs.ucla.edu>
407
408 Fix recently-introduced process.c problems found by static checking.
409 * process.c (write_queue_push, write_queue_pop, send_process):
410 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
411 (write_queue_pop): Fix pointer signedness problem.
412 (send_process): Remove unused local.
413
96a313a1
CY
4142012-06-17 Chong Yidong <cyd@gnu.org>
415
416 * xdisp.c (redisplay_internal): No need to redisplay terminal
417 frames that are not on top.
418
20ca2e94
TN
4192012-06-17 Troels Nielsen <bn.troels@gmail.com>
420
421 * process.c (make_process): Initialize write_queue.
422 (write_queue_push, write_queue_pop): New functions.
423 (send_process): Use them to maintain correct ordering of process
424 writes (Bug#10815).
425
9a900ca9
PE
4262012-06-17 Paul Eggert <eggert@cs.ucla.edu>
427
310fbfa8
PE
428 * lisp.h (eassert): Assume C89 or later.
429 This removes the need for CHECK.
430 (CHECK): Remove. Its comments about always evaluating its
431 argument were confusing, as 'eassert' typically does not evaluate
432 its argument.
433
27bb1ca4
PE
434 * coding.c (produce_chars): Use ptrdiff_t, not int.
435
9a900ca9
PE
436 * xterm.c (x_draw_underwave): Check for integer overflow.
437 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
438
41b7f8bc 4392012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
440
441 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
442 referenced (Bug#11583).
443
9b0e3eba
AA
4442012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
445
446 Implement wave-style variant of underlining.
447 * dispextern.h (face_underline_type): New enum.
448 (face): Add field for underline type.
449 * nsterm.m (ns_draw_underwave): New function.
450 (ns_draw_text_decoration): Use it.
451 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
452 New functions.
453 (x_draw_glyph_string): Use them.
454 * xfaces.c (Qline, Qwave): New Lisp objects.
455 (check_lface_attrs, merge_face_ref)
1053a871
SM
456 (Finternal_set_lisp_face_attribute, realize_x_face):
457 Handle wave-style underline face attributes.
9b0e3eba
AA
458 * xterm.c (x_draw_underwave): New function.
459 (x_draw_glyph_string): Use it.
460
0fb52f11
JB
4612012-06-16 Juanma Barranquero <lekktu@gmail.com>
462
463 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
464 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
465 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
466 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
467 ($(BLD)/w32select.$(O)): Update dependencies.
468
e5560ff7
AS
4692012-06-16 Andreas Schwab <schwab@linux-m68k.org>
470
471 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
472 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
473 * character.c (_fetch_multibyte_char_p): Remove.
474 * alloc.c: Include "character.h" before "buffer.h".
475 * bidi.c: Likewise.
476 * buffer.c: Likewise.
477 * bytecode.c: Likewise.
478 * callint.c: Likewise.
479 * callproc.c: Likewise.
480 * casefiddle.c: Likewise.
481 * casetab.c: Likewise.
482 * category.c: Likewise.
483 * cmds.c: Likewise.
484 * coding.c: Likewise.
485 * composite.c: Likewise.
486 * dired.c: Likewise.
487 * dispnew.c: Likewise.
488 * doc.c: Likewise.
489 * dosfns.c: Likewise.
490 * editfns.c: Likewise.
491 * emacs.c: Likewise.
492 * fileio.c: Likewise.
493 * filelock.c: Likewise.
494 * font.c: Likewise.
495 * fontset.c: Likewise.
496 * fringe.c: Likewise.
497 * indent.c: Likewise.
498 * insdel.c: Likewise.
499 * intervals.c: Likewise.
500 * keyboard.c: Likewise.
501 * keymap.c: Likewise.
502 * lread.c: Likewise.
503 * macros.c: Likewise.
504 * marker.c: Likewise.
505 * minibuf.c: Likewise.
506 * nsfns.m: Likewise.
507 * nsmenu.m: Likewise.
508 * print.c: Likewise.
509 * process.c: Likewise.
510 * regex.c: Likewise.
511 * region-cache.c: Likewise.
512 * search.c: Likewise.
513 * syntax.c: Likewise.
514 * term.c: Likewise.
515 * textprop.c: Likewise.
516 * undo.c: Likewise.
517 * unexsol.c: Likewise.
518 * w16select.c: Likewise.
519 * w32fns.c: Likewise.
520 * w32menu.c: Likewise.
521 * window.c: Likewise.
522 * xdisp.c: Likewise.
523 * xfns.c: Likewise.
524 * xmenu.c: Likewise.
525 * xml.c: Likewise.
526 * xselect.c: Likewise.
527
2f07e6af
EZ
5282012-06-16 Eli Zaretskii <eliz@gnu.org>
529
1053a871
SM
530 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
531 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 532 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
533 row.
534 (handle_face_prop): Use chunk-relative overlay string index when
535 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
536 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
537 the rightmost. (Bug#11720)
2f07e6af 538
29b83cec
AS
5392012-06-16 Andreas Schwab <schwab@linux-m68k.org>
540
541 * category.h (CHAR_HAS_CATEGORY): Define as inline.
542 (CATEGORY_MEMBER): Enforce 1/0 value.
543 * category.c (_temp_category_set): Remove.
544
4c5501e9
EZ
5452012-06-16 Eli Zaretskii <eliz@gnu.org>
546
547 * window.c (Fdelete_other_windows_internal)
548 (Fdelete_window_internal): Don't access frame's mouse highlight
549 info of the initial frame. (Bug#11677)
550
2b570124
PE
5512012-06-14 Paul Eggert <eggert@cs.ucla.edu>
552
e93864f9
PE
553 * .gdbinit (xgetint): Fix recently-introduced paren typo.
554 Assume USE_2_TAGS_FOR_INTS.
555 (xreload): Adjust $tagmask width to match recent lisp.h change.
556
2b570124
PE
557 Simplify lisp.h in minor ways that should not affect code.
558 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
559 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
560 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
561 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
562 (INTTYPEBITS): New macro, for clarity.
563 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
564 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
565 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
566 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
567 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
568
81755f69
JB
5692012-06-13 Juanma Barranquero <lekktu@gmail.com>
570
571 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
572
16192a57
GM
5732012-06-13 Glenn Morris <rgm@gnu.org>
574
575 * s/bsd-common.h (BSD4_3):
576 * s/usg5-4-common.h (USG5_4): No longer define; unused.
577
646b5f55
AS
5782012-06-13 Andreas Schwab <schwab@linux-m68k.org>
579
580 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
581 instead of union.
582 (XLI, XIL): Define.
1053a871
SM
583 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
584 Use them.
585 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 586 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 587 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
588 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
589 * frame.c (delete_frame): Remove outdated comment.
590 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
591 USE_LISP_UNION_TYPE.
592 (Fw32_unregister_hot_key): Likewise.
593 (Fw32_toggle_lock_key): Likewise.
594 * w32menu.c (add_menu_item): Likewise.
595 (w32_menu_display_help): Use XIL instead of checking
596 USE_LISP_UNION_TYPE.
597 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
598 (init_heap): Likewise.
599 * w32term.c (w32_read_socket): Update comment.
600
1d3823c9
GM
6012012-06-13 Glenn Morris <rgm@gnu.org>
602
c62ff706
GM
603 * s/usg5-4-common.h, src/s/unixware.h:
604 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
605
1d3823c9
GM
606 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
607
bfe3e0a2
PE
6082012-06-13 Paul Eggert <eggert@cs.ucla.edu>
609
610 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
611 * alloc.c (make_number) [!defined make_number]:
612 Remove, as lisp.h always defines this now.
613 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
614 (roundup_size): Verify that it is a power of 2.
615 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
616 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
617 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
618 -DUSE_LSB_TAG=0, to override the automatically-selected default.
619 USE_LSB_TAG now is always defined to be either 0 or 1.
620 All uses changed.
621 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
622 code works fine either way, and efficiency is not a concern here,
623 as the union type is for debugging, not for production.
624 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
625 Use an inline function on all platforms when using the union type,
626 since this is simpler and 'static inline' can be used portably
627 within Emacs now.
628 (LISP_INITIALLY_ZERO): New macro.
629 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
630 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
631
45fa9c0f
GM
6322012-06-12 Glenn Morris <rgm@gnu.org>
633
b4492cba
GM
634 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
635
636 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 637
45fa9c0f
GM
638 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
639 Move BROKEN_SIGIO to configure.
640
641 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
642 Move NO_TERMIO to configure.
643
0e25d334
CY
6442012-06-12 Chong Yidong <cyd@gnu.org>
645
646 * image.c (imagemagick_load_image): Use MagickFlattenImage if
647 MagickMergeImageLayers is undefined. Use pixel pusher loop if
648 MagickExportImagePixels is undefined.
649
43682bb6
PE
6502012-06-12 Paul Eggert <eggert@cs.ucla.edu>
651
652 * image.c (imagemagick_load_image): Remove unused label.
653
a9be7d2b
GM
6542012-06-11 Glenn Morris <rgm@gnu.org>
655
656 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
657 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
658 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
659 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
660
3017f87f
SM
6612012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
662
663 * alloc.c (make_byte_code): New function.
664 (Fmake_byte_code): Use it. Don't purify here.
665 * lread.c (read1): Use it as well to avoid extra allocation.
666
1b9b4cf4
CY
6672012-06-11 Chong Yidong <cyd@gnu.org>
668
669 * image.c (imagemagick_load_image): Implement transparency.
670
95988fcf
AS
6712012-06-10 Andreas Schwab <schwab@linux-m68k.org>
672
673 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
674 account for preceding backslashes. (Bug#11663)
675
cd4eb164
CY
6762012-06-09 Chong Yidong <cyd@gnu.org>
677
678 * term.c: Support italics in capable terminals (Bug#9652).
679 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
680 (turn_on_face): Output using TS_enter_italic_mode if available.
681 Don't handle unused blinking and alt-charset cases.
682 (turn_off_face): Handle italic case; discard unused tty_blinking_p
683 and tty_alt_charset_p cases.
684 (tty_capable_p, init_tty): Support italics.
685
686 * termchar.h (struct tty_display_info): Add field for italics.
687 Remove unused blink field.
688
689 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
690 Handle slant.
691
692 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
693 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
694 tty_alt_charset_p. Add tty_italic_p.
695
ff88beb8
MA
6962012-06-09 Michael Albinus <michael.albinus@gmx.de>
697
698 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
699 dbus_type_is_basic if available.
700 (xd_extract_signed, xd_extract_unsigned): Rename from
701 extract_signed and extract_unsigned, respectively. Adapt callers.
702
44286096
CY
7032012-06-09 Chong Yidong <cyd@gnu.org>
704
1682701f
CY
705 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
706
44286096
CY
707 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
708 case (Bug#9752).
709
d86feb17
PE
7102012-06-08 Paul Eggert <eggert@cs.ucla.edu>
711
712 * xdisp.c (vmessage): Treat frame message as multibyte.
713 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
714 would generate the diagnostic "Making \302\247 buffer-local while
715 let-bound!".
716
d5c20fe8
EZ
7172012-06-08 Eli Zaretskii <eliz@gnu.org>
718
719 * dispnew.c (showing_window_margins_p): Undo last change, which
720 was done due to an inadvertent commit.
721 (adjust_frame_glyphs_for_frame_redisplay): Do call
722 showing_window_margins_p.
723
513749ee
SM
7242012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
725
726 * eval.c (Fmake_var_non_special): New primitive.
727 (syms_of_eval): Defsubr it.
728 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
729
d4a8f5c1
JB
7302012-06-08 Juanma Barranquero <lekktu@gmail.com>
731
732 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
733 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
734
8bbbc977
EZ
7352012-06-08 Eli Zaretskii <eliz@gnu.org>
736
737 * alloc.c (allocate_vectorlike): Fix last change.
738
f3372c87
DA
7392012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
740
741 Block-based vector allocation of small vectors.
742 * lisp.h (struct vectorlike_header): New field `nbytes',
743 adjust comment accordingly.
744 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
745 to denote vector blocks. Adjust users (live_vector_p,
746 mark_maybe_pointer, valid_lisp_object_p) accordingly.
747 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
748 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
749 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
750 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
751 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
752 (roundup_size): New constant.
753 (struct vector_block): New data type.
754 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 755 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
756 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
757 (sweep_vectors): New functions.
758 (allocate_vectorlike): Return `zero_vector' as the only vector of
759 0 items. Allocate new vector from block if vector size is less than
760 or equal to VBLOCK_BYTES_MAX.
761 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
762 (init_alloc_once): Add call to init_vectors.
763
4f18a4ed
SM
7642012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
765
766 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
767
86f158bc
PE
7682012-06-07 Paul Eggert <eggert@cs.ucla.edu>
769
770 * doprnt.c (doprnt): Truncate multibyte char correctly.
771 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
772 would mishandle a string argument "Xc" if X was a multibyte
773 character of length 2: it would truncate after X's first byte
774 rather than including all of X.
775
c5cfcbe0
CY
7762012-06-06 Chong Yidong <cyd@gnu.org>
777
778 * buffer.c (word_wrap): Doc fix.
779
c05cf390
PE
7802012-06-04 Paul Eggert <eggert@cs.ucla.edu>
781
782 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
783
0c3461de
GM
7842012-06-03 Glenn Morris <rgm@gnu.org>
785
786 * xdisp.c (tool-bar-style): Doc fix.
787
c71232db
UM
7882012-06-03 Ulrich Müller <ulm@gentoo.org>
789
790 * Makefile.in (PAXCTL): Define.
791 (temacs$(EXEEXT)): Disable memory randomization for the temacs
792 binary via PaX flags if the paxctl utility is available.
793 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
794 Restore PaX flags to their default. (Bug#11398)
795
383f7350
CY
7962012-06-03 Chong Yidong <cyd@gnu.org>
797
798 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
799 buffer (Bug#11226).
800
5f2c76c6
CY
8012012-06-03 Chong Yidong <cyd@gnu.org>
802
803 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
804 (note_mode_line_or_margin_highlight): If there is no help echo,
805 use mode-line-default-help-echo. Handle the case where the mouse
806 position is past the end of the mode line string.
807
808 * buffer.c (buffer_local_value_1): New function, split from
809 Fbuffer_local_value; can return Qunbound.
810 (Fbuffer_local_value): Use it.
811 (Vmode_line_format): Docstring tweaks.
812
773d47f6
PE
8132012-06-02 Paul Eggert <eggert@cs.ucla.edu>
814
815 * sysdep.c (system_process_attributes): Improve comment.
816
f2d6a3df
SM
8172012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
818
819 * keyboard.c: Export real-this-command to Elisp.
820 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
821 and DEFVAR it. Update all users.
822
63810350
PE
8232012-06-02 Paul Eggert <eggert@cs.ucla.edu>
824
7bd5c1f4
PE
825 * minibuf.c (Fassoc_string): Remove duplicate declaration.
826
63810350
PE
827 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
828 Convert pctcpu and pctmem to Lisp float properly.
829 Let the compiler fold better, as 100.0/0x8000 is exact.
830
a2821611
AS
8312012-06-02 Andreas Schwab <schwab@linux-m68k.org>
832
833 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
834 cons_block.
835
5fceba1d
PE
8362012-06-01 Paul Eggert <eggert@cs.ucla.edu>
837
838 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
839
c98ff5dd
DA
8402012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
841
842 For a 'struct window', replace some Lisp_Object fields to
843 bitfields where appropriate, remove unused fields.
844 * window.h (struct window): Remove unused 'last_mark_x' and
845 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
846 change it's type from Lisp_Object to bitfield.
847 Change type of 'force_start', 'optional_new_start',
848 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
849 fields from Lisp_Object to bitfield. Adjust users accordingly.
850
ca34e0be
PE
8512012-05-31 Paul Eggert <eggert@cs.ucla.edu>
852
853 Pacify gcc -Wdouble-precision when using Xaw.
854 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
855 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
856 Use 'float' consistently, rather than 'float' in most places
857 and 'double' in a couple of places.
858
efc00ab1 8592012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
860
861 * xdisp.c (handle_stop): Detect whether we have overlay strings
862 loaded by testing it->current.overlay_string_index to be
863 non-negative, instead of checking whether n_overlay_strings is
864 positive. (Bug#11587)
865
efc00ab1 8662012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
867
868 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
869
870 * doc.c (Fsubstitute_command_keys): Doc fix.
871
efc00ab1 8722012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
873
874 * search.c (search_buffer): Remove calls to
875 r_alloc_inhibit_buffer_relocation, as it is now called by
876 maybe_unify_char, which was the cause of relocation of buffer text
877 in bug#11519.
878
efc00ab1 8792012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
880
881 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
882 for the duration of call to load_charset, to avoid problems with
883 callers of maybe_unify_char that access buffer text through C
884 pointers.
885
886 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
887 decrement the inhibition flag, instead of just setting or
888 resetting it.
889
ba93a187
PE
8902012-05-31 Paul Eggert <eggert@cs.ucla.edu>
891
892 Remove obsolete '#define static' cruft.
893 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
894 This #undef was "temporary" in 2000; it is no longer needed
895 now that '#define static' has gone away.
896 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
897 (gray_bitmap_bits): Remove; no longer needed.
898 All uses replaced with definiens.
899 * xterm.c: Include "bitmaps/gray.xbm".
900
9e4bf381
PE
9012012-05-30 Paul Eggert <eggert@cs.ucla.edu>
902
903 Clean up __executable_start, monstartup when --enable-profiling.
904 The following changes affect the code only when profiling.
905 * dispnew.c (__executable_start): Rename from safe_bcopy.
906 Define only on platforms that need it.
907 * emacs.c: Include <sys/gmon.h> when profiling.
908 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
909 (__executable_start): Remove decl, since lisp.h does it now.
910 (safe_bcopy): Remove decl; no longer has that name.
911 (main): Coalesce #if into single bit of code, for simplicity.
912 Cast pointers to uintptr_t, since standard libraries want integers
913 and not pointers.
914 * lisp.h (__executable_start): New decl.
915
32d72c2f
GM
9162012-05-31 Glenn Morris <rgm@gnu.org>
917
918 * image.c (Fimagemagick_types): Doc fix.
919
baac5bc7
JM
9202012-05-30 Jim Meyering <meyering@redhat.com>
921
922 * callproc.c (Fcall_process_region): Include directory component
923 in mkstemp error message (Bug#11586).
924
72cb32cf
PE
9252012-05-30 Paul Eggert <eggert@cs.ucla.edu>
926
927 * alloc.c, lisp.h (make_pure_vector): Now static.
928
61b108cc
SM
9292012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
930
931 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
932 Move to byte-run.el.
933 (Fautoload): Do the hash-doc more carefully.
934 * data.c (Fdefalias): Purify definition, except for keymaps.
935 (Qdefun): Move from eval.c.
936 * lisp.h (Qdefun): Remove.
937 * lread.c (read1): Tiny simplification.
938
471fe23d
TN
9392012-05-29 Troels Nielsen <bn.troels@gmail.com>
940
934f3f58 941 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
942 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
943 Bug#9642, but explicitly check that the buffer the overlay would
944 be moved to is live and rearrange lines to make sure that errors
945 will not put the overlay in an inconsistent state.
946 (Fdelete_overlay): Cosmetics.
947
85d0efd1
EZ
9482012-05-28 Eli Zaretskii <eliz@gnu.org>
949
950 * w32term.c (my_bring_window_to_top): New function.
951 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
952 could be different from the original one.
953 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
954 (Bug#11513)
955
956 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
957 by calling BringWindowToTop.
958
959 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
960 (WM_EMACS_END): Increase by one.
961
da92a98c
PE
9622012-05-28 Paul Eggert <eggert@cs.ucla.edu>
963
964 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
965 This avoids undefined behavior that might cause the eassert
966 to not catch an out-of-range value.
967
74d1f848
JB
9682012-05-28 Juanma Barranquero <lekktu@gmail.com>
969
970 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
971 Update dependencies.
972
9e1a06fc
EZ
9732012-05-27 Eli Zaretskii <eliz@gnu.org>
974
975 * bidi.c (bidi_mirror_char): Fix last change.
976
f3dd7312
AS
9772012-05-27 Andreas Schwab <schwab@linux-m68k.org>
978
979 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
980 when referring to sectname field in printf format.
981
81899c91
PE
9822012-05-27 Paul Eggert <eggert@cs.ucla.edu>
983
57b81a9f
PE
984 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
985 Only r_alloc_inhibit_buffer_relocation needed to be added;
986 the others were already declared.
987
81899c91
PE
988 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
989 before checking whether it's out of range. Put the check inside
990 eassert. See
991 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
992
33017faf 9932012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
994
995 * callproc.c (Fcall_process): Restore a line that was accidentally
996 commented out in the 2011-02-13 change (bug#11547).
997
33017faf 9982012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
999
1000 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1001 defined on ralloc.c.
1002
1003 * buffer.c [REL_ALLOC]: Remove prototypes of
1004 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1005 they are now on lisp.h.
1006
1007 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1008
1009 * search.c (search_buffer): Use it to inhibit relocation of buffer
1010 text while re_search_2 is doing its job, because re_search_2 is
1011 passed C pointers to buffer text. (Bug#11519)
1012
23415acf
EZ
1013 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1014 Update value to 24.
1015
44e27368
EZ
1016 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1017 state after an additional call to move_it_in_display_line_to, keep
1018 the values of it->max_ascent and it->max_descent found for the
1019 entire line.
1020 (pos_visible_p): Revert the comparison against bottom_y to what it
1021 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1022 (Bug#11464)
1023
c1892f11
PE
10242012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 Fix coding-related core dumps with gcc -ftrapv.
1027 The code was computing A - B, where A and B are pointers, and B is
1028 random garbage. This can lead to core dumps on platforms that
1029 have special pointer registers, and it also leads to core dumps on
1030 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1031 A - B only when B is initialized properly.
1032 * coding.c (coding_set_source, coding_set_destination): Return void.
1033 (coding_change_source, coding_change_destinations): New functions,
1034 with the old behaviors of coding_set_source and coding_set_destination.
1035 All callers that need an offset changed to use these new functions.
1036
eb7afdad
GM
10372012-05-26 Glenn Morris <rgm@gnu.org>
1038
1039 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1040
f12fdf02
EZ
10412012-05-26 Eli Zaretskii <eliz@gnu.org>
1042
53a63be6 1043 Extend mouse support on W32 text-mode console.
61b108cc
SM
1044 * xdisp.c (draw_row_with_mouse_face):
1045 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1046
eb3f6f01 1047 * w32console.c: Include window.h.
61b108cc
SM
1048 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1049 New functions.
eb3f6f01
EZ
1050 (initialize_w32_display): Initialize mouse-highlight data.
1051
53a63be6
EZ
1052 * w32inevt.c: Include termchar.h and window.h.
1053 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1054 moves, call note_mouse_highlight. If help_echo changed, call
1055 gen_help_event to produce help-echo message in the echo area.
1056 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1057 highlight info.
1058
4cfd81f6
PE
10592012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1060
1061 * lread.c (read1): Simplify slightly to avoid an overflow warning
1062 with GCC 4.7.0 on x86-64.
1063
4446092a
EZ
10642012-05-26 Eli Zaretskii <eliz@gnu.org>
1065
1066 * bidi.c (bidi_mirror_char): Revert last change: an int is
1067 definitely wide enough here.
1068
42b2a986 10692012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1070
42b2a986 1071 Fix integer width and related bugs (Bug#9874).
eb106a49 1072 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1073 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1074 (string_bytes, check_sblock, allocate_string_data):
1075 (compact_small_strings, Fmake_bool_vector, make_string)
1076 (make_unibyte_string, make_multibyte_string)
1077 (make_string_from_bytes, make_specified_string)
1078 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1079 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1080 (mark_vectorlike):
1081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1082 (allocate_pseudovector):
1083 Use int, not EMACS_INT, where int is wide enough.
1084 (inhibit_garbage_collection, Fgarbage_collect):
1085 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1086 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1087 int might not be wide enough.
1088 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1089 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1090 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1091 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1092 (bidi_level_of_next_char, bidi_move_to_visually_next):
1093 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1094 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1095 (Fkill_buffer, Fset_buffer_major_mode)
1096 (advance_to_char_boundary, Fbuffer_swap_text)
1097 (Fset_buffer_multibyte, overlays_at, overlays_in)
1098 (overlay_touches_p, struct sortvec, record_overlay_string)
1099 (overlay_strings, recenter_overlay_lists)
1100 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1101 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1102 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1103 (Foverlay_recenter, last_overlay_modification_hooks_used)
1104 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1105 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1106 (validate_region): Omit unnecessary test for b <= e,
1107 since that's guaranteed by the previous test.
d311d28c
PE
1108 (adjust_overlays_for_delete): Avoid pos + length overflow.
1109 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1110 (report_overlay_modification):
1111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1112 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1113 Omit pointer cast, which isn't needed anyway, and doesn't work
1114 after the EMACS_INT -> ptrdiff_t change.
02481186 1115 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1116 * buffer.h: Adjust decls to match defn changes elsewhere.
1117 (struct buffer_text, struct buffer):
1118 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1119 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1120 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1121 not int, to avoid needless 32-bit limit on 64-bit hosts.
1122 (exec_byte_code): Use tighter memory-full test, one that checks
1123 for alloca overflow. Don't compute the address of the object just
1124 before an array, as that's not portable. Use EMACS_INT, not
1125 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1126 * callint.c (Fcall_interactively):
1127 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1128 * callproc.c (call_process_kill, Fcall_process):
1129 Don't assume pid_t fits into an Emacs fixnum.
1130 (call_process_cleanup, Fcall_process, child_setup):
1131 Don't assume pid_t fits into int.
1132 (call_process_cleanup, Fcall_process, delete_temp_file)
1133 (Fcall_process_region):
1134 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1135 (Fcall_process): Simplify handling of volatile integers.
1136 Use int, not EMACS_INT, where int will do.
1137 * casefiddle.c (casify_object, casify_region, operate_on_word)
1138 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1140 (casify_object): Avoid integer overflow when overallocating buffer.
1141 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1142 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1143 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1144 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1145 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1146 integers are now checked earlier. All uses replaced with XINT.
1147 (ccl_driver):
1148 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1149 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1150 (ccl_driver, Fregister_code_conversion_map):
1151 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1152 (resolve_symbol_ccl_program): Check that vector header is in range.
1153 Always copy the vector, so that we can check its contents reliably
1154 now rather than having to recheck each instruction as it's being
1155 executed. Check that vector words fit in 'int'.
1156 (ccl_get_compiled_code, Fregister_ccl_program)
1157 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1158 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1159 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1160 contents are in range.
1161 (Fccl_execute_on_string): Check that status is in range.
1162 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1163 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1164 Accept and return EMACS_INT, not int, because callers can pass values
1165 out of 'int' range.
1166 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1167 (multibyte_chars_in_text, parse_str_as_multibyte)
1168 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1169 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1170 (string_escape_byte8, Fget_byte):
1171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1172 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1173 avoid mishandling large integers.
1174 * character.h: Adjust decls to match defn changes elsewhere.
1175 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1176 (Ffind_charset_region):
1177 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1178 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1179 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1180 Don't assume fixnum fits in int.
d311d28c
PE
1181 (load_charset_map_from_vector, Fmap_charset_chars):
1182 Remove now-unnecessary CHECK_NATNUMs.
1183 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1184 Don't rely on undefined behavior with signed left shift overflow.
1185 Don't assume unsigned int fits into fixnum, or that fixnum fits
1186 into unsigned int. Don't require max_code to be a valid fixnum;
1187 that's not true for gb10830 4-byte on a 32-bit host. Allow
1188 invalid_code to be a cons, for the same reason. Require code_offset
1189 to be a character. Avoid int overflow if max_char is close
1190 to INT_MAX.
1191 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1192 this is intended anyway and avoids some undefined behavior.
1193 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1194 INDEX_TO_CODE_POINT, as that's what it expects.
1195 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1196 * charset.h (DECODE_CHAR): Return int, not unsigned;
1197 this is what was intended anyway, and it avoids undefined behavior.
1198 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1199 integer-overflow issues.
1200 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1201 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1202 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1203 * chartab.c (Fmake_char_table, Fset_char_table_range)
1204 (uniprop_get_decoder, uniprop_get_encoder):
1205 Don't assume fixnum fits in int.
1206 * cmds.c (move_point): New function, that does the gist of
1207 Fforward_char and Fbackward_char, but does so while checking
1208 for integer overflow more accurately.
c96e5d6a 1209 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1210 (Fforward_line, Fend_of_line, internal_self_insert)
1211 (internal_self_insert):
1212 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1213 Fix a FIXME, by checking for integer overflow when calculating
1214 target_clm and actual_clm.
1215 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1216 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1217 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1218 (coding_alloc_by_making_gap, alloc_destination)
1219 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1220 (encode_coding_utf_16, detect_coding_emacs_mule)
1221 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1222 (detect_coding_iso_2022, decode_coding_iso_2022)
1223 (encode_invocation_designation, encode_designation_at_bol)
1224 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1225 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1226 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1227 (encode_coding_ccl, encode_coding_raw_text)
1228 (detect_coding_charset, decode_coding_charset)
1229 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1230 (produce_composition, produce_charset, produce_annotation)
1231 (decode_coding, handle_composition_annotation)
1232 (handle_charset_annotation, consume_chars, decode_coding_gap)
1233 (decode_coding_object, encode_coding_object, detect_coding_system)
1234 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1235 (code_convert_region, code_convert_string)
8f50130c
PE
1236 (Fdefine_coding_system_internal)
1237 (coding_set_source, coding_set_destination):
d311d28c
PE
1238 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1239 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1240 (Fdefine_coding_system_internal):
1241 Don't assume fixnums fit in int.
1242 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1243 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1244 (Funencodable_char_position, Fcheck_coding_systems_region)
1245 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1246 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1247 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1248 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1249 Don't access memory outside of the args array.
d311d28c 1250 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1251 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1252 result of ENCODE_CHAR.
d311d28c
PE
1253 * coding.h: Adjust decls to match defn changes elsewhere.
1254 (struct coding_system):
1255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1256 * composite.c (get_composition_id, find_composition)
1257 (run_composition_function, update_compositions)
1258 (compose_text, composition_gstring_put_cache)
1259 (composition_gstring_p, composition_gstring_width)
1260 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1261 (composition_compute_stop_pos, composition_reseat_it)
1262 (composition_update_it, struct position_record)
1263 (find_automatic_composition, composition_adjust_point)
1264 (Fcomposition_get_gstring, Ffind_composition_internal):
1265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1266 (update_compositions):
1267 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1268 * composite.h: Adjust decls to match defn changes elsewhere.
1269 (struct composition):
1270 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1271 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1272 Do not attempt to compute the address of the object just before a
1273 buffer; this is not portable.
1274 (Faref, Faset):
1275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1276 (Faset): Use int, not EMACS_INT, where int is wide enough.
1277 (Fstring_to_number): Don't assume fixnums fit in int.
1278 (Frem): Don't assume arg is nonnegative.
1279 * dbusbind.c (xd_append_arg): Check for integers out of range.
1280 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1281 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1282 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1283 (xd_get_connection_references): Return ptrdiff_t, not int.
1284 All uses changed.
1285 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1286 (xd_read_message_1):
1287 Use int, not unsigned, where the dbus API uses int.
1288 (Fdbus_message_internal): Don't overflow mtype.
1289 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1290 * dired.c (directory_files_internal, file_name_completion, scmp)
1291 (file_name_completion_stat):
1292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1293 (file_name_completion): Don't overflow matchcount.
1294 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1295 * dispextern.h: Adjust decls to match defn changes elsewhere.
1296 (struct text_pos, struct glyph, struct bidi_saved_info)
1297 (struct bidi_string_data, struct bidi_it, struct composition_it)
1298 (struct it):
1299 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1300 (struct display_pos, struct composition_it, struct it):
1301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1302 * dispnew.c (increment_matrix_positions)
1303 (increment_row_positions, mode_line_string)
1304 (marginal_area_string):
1305 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1306 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1307 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1308 (duration_to_sec_usec): New function, to check for overflow better.
1309 (Fsleep_for, sit_for): Use it.
1310 * doc.c (get_doc_string, store_function_docstring):
1311 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1312 (get_doc_string, Fsnarf_documentation):
1313 Use int, not EMACS_INT, where int is wide enough.
1314 (get_doc_string):
1315 Use SAFE_ALLOCA, not alloca.
1316 Check for overflow when converting EMACS_INT to off_t.
1317 * doprnt.c (doprnt):
1318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1319 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1320 Don't assume uid_t fits into fixnum.
1321 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1322 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1323 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1324 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1325 (general_insert_function)
1326 (Finsert_char, make_buffer_string, make_buffer_string_both)
1327 (update_buffer_properties, Fbuffer_substring)
1328 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1329 (Fsubst_char_in_region, check_translation)
1330 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1331 (transpose_markers, Ftranspose_regions):
1332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1333 (clip_to_bounds): Move to lisp.h as an inline function).
1334 (Fconstrain_to_field): Don't assume integers are nonnegative.
1335 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1336 (Fsubst_char_in_region, Fsave_restriction):
1337 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1338 (Femacs_pid): Don't assume pid_t fits into fixnum.
1339 (lo_time): Use int, not EMACS_INT, when int suffices.
1340 (lisp_time_argument): Check for usec out of range.
1341 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1342 (Fuser_login_name, Fuser_full_name): Signal an error
1343 if a uid argument is out of range, rather than relying on
1344 undefined behavior.
c8d5c857
PE
1345 (Fformat_time_string): Remove now-unnecessary check.
1346 lisp_time_argument checks for out-of-range usec now.
243e0530 1347 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1348 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1349 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1350 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1351 (init_cmdargs, Fdump_emacs):
1352 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1353 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1354 the bottom (typically) 32 bits of the fixnum.
1355 * eval.c (specpdl_size, call_debugger):
1356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1357 (when_entered_debugger, Fbacktrace_debug):
1358 Don't assume fixnum can fit in int.
1359 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1360 the object just before a buffer; this is not portable.
1361 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1362 (grow_specpdl, unbind_to):
1363 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1364 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1365 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1366 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1367 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1368 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1369 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1370 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1371 (a_write, e_write):
1372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1373 (Fcopy_file, non_regular_nbytes, read_non_regular)
1374 (Finsert_file_contents):
1375 Use int, not EMACS_INT, where int is wide enough.
1376 (READ_BUF_SIZE): Verify that it fits in int.
1377 (Finsert_file_contents): Check that counts are in proper range,
1378 rather than assuming fixnums fit into ptrdiff_t etc.
1379 Don't assume fixnums fit into int.
125b3835 1380 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1381 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1382 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1383 (string_char_to_byte, string_byte_to_char)
1384 (string_make_multibyte, string_to_multibyte)
1385 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1386 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1387 (substring_both, Fdelete, internal_equal, Ffillarray)
1388 (Fclear_string, mapcar1)
1389 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1390 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1391 (larger_vector, make_hash_table, maybe_resize_hash_table)
1392 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1393 (Fmaphash, secure_hash):
1394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1395 (concat): Check for string index and length overflow.
1396 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1397 (Frequire):
1398 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1399 (larger_vector): New API (vec, incr_min, size_max) replaces old
1400 one (vec, new_size, init). This catches size overflow.
1401 INIT was removed because it was always Qnil.
1402 All callers changed.
1403 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1404 the upper bound on a hash table index size.
1405 (make_hash_table, maybe_resize_hash_table): Use it.
1406 (secure_hash): Computer start_byte and end_byte only after
1407 they're known to be in ptrdiff_t range.
1408 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1409 (Ffont_get_glyphs, Ffont_at):
1410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1411 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1412 (Flist_fonts, Fopen_font):
1413 Don't assume fixnum can fit in int.
1414 (check_gstring): Don't assume index can fit in int.
1415 (font_match_p): Check that fixnum is a character, not a nonnegative
1416 fixnum, since the later code needs to stuff it into an int.
1417 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1418 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1419 conversion overflow issues.
1420 (Fopen_font): Check for integer out of range.
1421 (Ffont_get_glyphs): Don't assume index can fit in int.
1422 * font.h: Adjust decls to match defn changes elsewhere.
1423 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1424 integer overflow.
1425 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1426 printmax_t, where ptrdiff_t is wide enough.
1427 (Finternal_char_font):
1428 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1429 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1430 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1431 (Fset_frame_position, x_set_frame_parameters)
1432 (x_set_line_spacing, x_set_border_width)
1433 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1434 Check that fixnums are in proper range for system types.
1435 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1436 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1437 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1438 Use SAFE_ALLOCA_LISP, not alloca.
1439 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1440 intptr_t is wide enough.
1441 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1442 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1443 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1444 Check for fixnum out of range.
1445 * ftfont.c (ftfont_list): Don't assume index fits in int.
1446 Check that fixnums are in proper range for system types.
1447 (ftfont_shape_by_flt):
1448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1449 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1450 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1451 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1452 Check that fixnums are in proper range for system types.
1453 * gnutls.h: Adjust decls to match defn changes elsewhere.
1454 * gtkutil.c (xg_dialog_run):
1455 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1456 (update_frame_tool_bar):
1457 Check that fixnums are in proper range for system types.
1458 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1459 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1460 * indent.c (last_known_column, last_known_column_point):
1461 (current_column_bol_cache):
1462 (skip_invisible, current_column, check_display_width):
1463 (check_display_width, scan_for_column, current_column_1)
1464 (Findent_to, Fcurrent_indentation, position_indentation)
1465 (indented_beyond_p, Fmove_to_column, compute_motion):
1466 (Fcompute_motion, Fvertical_motion):
1467 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1468 (last_known_column_modified): Use EMACS_INT, not int.
1469 (check_display_width):
1470 (Fcompute_motion):
1471 Check that fixnums and floats are in proper range for system types.
1472 (compute_motion): Don't assume index or fixnum fits in int.
1473 (compute_motion, Fcompute_motion):
1474 Use int, not EMACS_INT, when it is wide enough.
1475 (vmotion): Omit local var start_hpos that is always 0; that way
1476 we don't need to worry about overflow in expressions involving it.
1477 * indent.h: Adjust decls to match defn changes elsewhere.
1478 (struct position):
1479 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1480 Use int, not EMACS_INT, where int is wide enough.
1481 Remove unused members ovstring_chars_done and tab_offset;
1482 all uses removed.
1483 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1484 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1485 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1486 (make_gap, copy_text, insert, insert_and_inherit)
1487 (insert_before_markers, insert_before_markers_and_inherit)
1488 (insert_1, count_combining_before, count_combining_after)
1489 (insert_1_both, insert_from_string)
1490 (insert_from_string_before_markers, insert_from_string_1)
1491 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1492 (adjust_after_replace, adjust_after_insert, replace_range)
1493 (replace_range_2, del_range, del_range_1, del_range_byte)
1494 (del_range_both, del_range_2, modify_region)
1495 (prepare_to_modify_buffer, signal_before_change)
1496 (signal_after_change, Fcombine_after_change_execute):
1497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1498 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1499 (balance_an_interval, split_interval_right, split_interval_left)
1500 (find_interval, next_interval, update_interval)
1501 (adjust_intervals_for_insertion, delete_node, delete_interval)
1502 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1503 (static_offset_intervals, offset_intervals)
1504 (merge_interval_right, merge_interval_left, make_new_interval)
1505 (graft_intervals_into_buffer, temp_set_point_both)
1506 (temp_set_point, set_point, adjust_for_invis_intang)
1507 (set_point_both, move_if_not_intangible, get_property_and_range)
1508 (get_local_map, copy_intervals, copy_intervals_to_string)
1509 (compare_string_intervals, set_intervals_multibyte_1):
1510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1511 * intervals.h: Adjust decls to match defn changes elsewhere.
1512 (struct interval):
1513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1514 * keyboard.c (this_command_key_count, this_single_command_key_start)
1515 (before_command_key_count, before_command_echo_length, echo_now)
1516 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1517 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1518 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1519 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1521 (last_non_minibuf_size, last_point_position, echo_truncate)
1522 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1523 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1524 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1525 (stuff_buffered_input):
1526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1527 (last_auto_save, command_loop_1, read_char):
1528 Use EMACS_INT, not int, to avoid integer overflow.
1529 (record_char): Avoid overflow in total_keys computation.
1530 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1531 * keyboard.h: Adjust decls to match defn changes elsewhere.
1532 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1533 (Fkey_description, Fdescribe_vector, Flookup_key):
1534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1535 (click_position): New function, to check that positions are in range.
1536 (Fcurrent_active_maps):
1537 (describe_command):
1538 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1539 (Faccessible_keymaps, Fkey_description):
1540 (preferred_sequence_p):
1541 Don't assume fixnum can fit into int.
1542 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1543 Check for integer overflow in size calculations.
1544 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1545 avoid mishandling large integers.
1546 * lisp.h: Adjust decls to match defn changes elsewhere.
1547 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1548 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1549 (struct Lisp_Marker):
1550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1551 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1552 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1553 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1554 All callers changed.
1555 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1556 Assume the arg has valid form, since it always does.
1557 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1558 unsigned integer system type.
1559 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1560 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1562 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1563 (duration_to_sec_usec): New decl.
1564 * lread.c (read_from_string_index, read_from_string_index_byte)
1565 (read_from_string_limit, readchar, unreadchar, openp)
1566 (read_internal_start, read1, oblookup):
1567 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1568 (Fload, readevalloop, Feval_buffer, Feval_region):
1569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1570 (openp): Check for out-of-range argument to 'access'.
1571 (read1): Use int, not EMACS_INT, where int is wide enough.
1572 Don't assume fixnum fits into int.
6efdadfd 1573 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1574 (read_filtered_event): Use duration_to_sec_usec
1575 to do proper overflow checking on durations.
d311d28c
PE
1576 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1577 in size calculation.
1578 (Fexecute_kbd_macro):
1579 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1580 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1581 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1582 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1583 (set_marker_both, set_marker_restricted_both, marker_position)
1584 (marker_byte_position, Fbuffer_has_markers_at):
1585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1586 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1587 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1588 It now merely ensures that the menu is large enough, without
1589 necessarily growing it, as this avoids some integer overflow issues.
1590 All callers changed.
1591 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1592 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1593 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1594 Use SAFE_ALLOCA_LISP, not alloca.
1595 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1596 to EMACS_INT. Check that fixnums are in proper range for system types.
1597 * minibuf.c (minibuf_prompt_width, string_to_object)
1598 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1599 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1601 (get_minibuffer, read_minibuf_unwind):
1602 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1603 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1604 this simplifies overflow checking. All callers changed.
1605 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1606 (Ftest_completion):
1607 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1608 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1609 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1610 Check that fixnums are in proper range for system types.
1611 (Fx_create_frame, Fx_show_tip):
1612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1613 * nsfont.m (ns_findfonts, nsfont_list_family):
1614 Don't assume fixnum fits in long.
1615 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1617 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1618 wide enough.
17fdb222 1619 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1620 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1621 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1622 (PRINTDECLARE, PRINTPREPARE):
1623 (strout, print_string):
1624 (print, print_preprocess, print_check_string_charset_prop)
1625 (print_object):
1626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1627 (PRINTDECLARE):
1628 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1629 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1630 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1631 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1632 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1633 (print_error_message): Use SAFE_ALLOCA, not alloca.
1634 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1635 (print_depth, new_backquote_output, print_number_index):
1636 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1637 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1638 (Fset_process_window_size, Fformat_network_address)
1639 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1640 (sigchld_handler):
d311d28c 1641 Check that fixnums are in proper range for system types.
d44287d4 1642 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1643 Check for process-ids out of pid_t range rather than relying on
1644 undefined behavior.
e4d81efc 1645 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1646 (Fformat_network_address, read_process_output, send_process)
1647 (Fprocess_send_region, status_notify):
1648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1649 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1650 (wait_reading_process_output, read_process_output, exec_sentinel):
1651 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1652 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1653 (Faccept_process_output): Use duration_to_sec_usec to do proper
1654 overflow checking on durations.
dde14581
PE
1655 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1656 Don't assume pid_t fits in int.
02481186
PE
1657 * process.h (struct Lisp_Process): Members tick and update_tick
1658 are now of type EMACS_INT, not int.
b62b53e8
PE
1659 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1660 configured --with-wide-int.
d311d28c
PE
1661 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1662 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1663 * search.c (looking_at_1, string_match_1):
1664 (fast_string_match, fast_c_string_match_ignore_case)
1665 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1666 (scan_newline, find_before_next_newline, search_command)
1667 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1668 (set_search_regs, wordify):
1669 (Freplace_match):
1670 (Fmatch_data):
1671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1672 (string_match_1, search_buffer, set_search_regs):
1673 (Fmatch_data):
1674 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1675 (wordify): Check for overflow in size calculation.
1676 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1677 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1678 Check that fixnums are in proper range for system types.
1679 * sound.c (struct sound_device)
1680 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1682 (Fplay_sound_internal):
1683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1684 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1685 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1686 (Fparse_partial_sexp):
1687 Don't assume fixnums can fit in int.
1688 (struct lisp_parse_state, find_start_pos, find_start_value)
1689 (find_start_value_byte, find_start_begv)
1690 (update_syntax_table, char_quoted, dec_bytepos)
1691 (find_defun_start, prev_char_comend_first, back_comment):
1692 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1693 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1695 (Finternal_describe_syntax_value): Check that match_lisp is a
1696 character, not an integer, since the code stuffs it into int.
1697 (scan_words, scan_sexps_forward):
1698 Check that fixnums are in proper range for system types.
1699 (Fforward_word):
1700 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1701 (scan_sexps_forward):
1702 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1703 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1704 * syntax.h: Adjust decls to match defn changes elsewhere.
1705 (struct gl_state_s):
1706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1707 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1708 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1709 * sysdep.c (wait_for_termination_1, wait_for_termination)
1710 (interruptible_wait_for_termination, mkdir):
1711 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1712 (emacs_read, emacs_write):
1713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1714 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1715 and double all fit in int.
d311d28c
PE
1716 * term.c (set_tty_color_mode):
1717 Check that fixnums are in proper range for system types.
1718 * termhooks.h (struct input_event):
1719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1720 * textprop.c (validate_interval_range, interval_of)
1721 (Fadd_text_properties, set_text_properties_1)
1722 (Fremove_text_properties, Fremove_list_of_text_properties)
1723 (Ftext_property_any, Ftext_property_not_all)
1724 (copy_text_properties, text_property_list, extend_property_ranges)
1725 (verify_interval_modification):
1726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1727 (Fnext_single_char_property_change)
1728 (Fprevious_single_char_property_change):
1729 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1730 (copy_text_properties):
1731 Check for integer overflow in index calculation.
d311d28c
PE
1732 * undo.c (last_boundary_position, record_point, record_insert)
1733 (record_delete, record_marker_adjustment, record_change)
1734 (record_property_change):
1735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1736 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1738 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1739 (Fx_hide_tip, Fx_file_dialog):
1740 * w32menu.c (set_frame_menubar):
1741 Use ptrdiff_t, not int, for consistency with rest of code.
1742 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1743 (select_window, Fdelete_other_windows_internal)
1744 (window_scroll_pixel_based, window_scroll_line_based)
1745 (Frecenter, Fset_window_configuration):
1746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1747 (Fset_window_hscroll, run_window_configuration_change_hook)
1748 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1749 (Fscroll_other_window, Frecenter):
d311d28c
PE
1750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1751 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1752 Don't assume fixnum fits in int.
1753 (Fset_window_scroll_bars):
1754 Check that fixnums are in proper range for system types.
1755 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1756 (string_pos, c_string_pos, number_of_chars, init_iterator)
1757 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1758 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1759 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1760 (face_before_or_after_it_pos, handle_invisible_prop)
1761 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1762 (display_prop_intangible_p, string_buffer_position_lim)
1763 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1764 (get_overlay_strings_1, get_overlay_strings)
1765 (iterate_out_of_display_property, forward_to_next_line_start)
1766 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1767 (get_next_display_element, set_iterator_to_next)
1768 (get_visually_first_element, compute_stop_pos_backwards)
1769 (handle_stop_backwards, next_element_from_buffer)
1770 (move_it_in_display_line_to, move_it_in_display_line)
1771 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1772 (add_to_log, message_dolog, message_log_check_duplicate)
1773 (message2, message2_nolog, message3, message3_nolog
1774 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1775 (current_message_1, truncate_echo_area, truncate_message_1)
1776 (set_message, set_message_1, store_mode_line_noprop)
1777 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1778 (text_outside_line_unchanged_p, check_point_in_composition)
1779 (reconsider_clip_changes)
1780 (redisplay_internal, set_cursor_from_row, try_scrolling)
1781 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1782 (redisplay_window, find_last_unchanged_at_beg_row)
1783 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1784 (trailing_whitespace_p, find_row_edges, display_line)
1785 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1786 (display_mode_element, store_mode_line_string)
1787 (pint2str, pint2hrstr, decode_mode_spec)
1788 (display_count_lines, display_string, draw_glyphs)
1789 (x_produce_glyphs, x_insert_glyphs)
1790 (rows_from_pos_range, mouse_face_from_buffer_pos)
1791 (fast_find_string_pos, mouse_face_from_string_pos)
1792 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1793 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1794 (safe_call, init_from_display_pos, handle_fontified_prop)
1795 (handle_single_display_spec, load_overlay_strings)
1796 (with_echo_area_buffer, setup_echo_area_for_printing)
1797 (display_echo_area, echo_area_display)
1798 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1799 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1800 (redisplay_window, dump_glyph_row, display_mode_line)
1801 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1802 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1803 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1804 (handle_single_display_spec, build_desired_tool_bar_string)
1805 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1806 (get_specified_cursor_type):
1807 Check that fixnums are in proper range for system types.
1808 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1809 (Flookup_image_map):
1810 Don't assume fixnums fit in int.
1811 (compare_overlay_entries):
1812 Avoid mishandling comparisons due to subtraction overflow.
1813 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1814 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1815 (handle_tool_bar_click):
1816 Use int, not unsigned, since we prefer signed and the signedness
1817 doesn't matter here.
1818 (get_next_display_element, next_element_from_display_vector):
1819 Use int, not EMACS_INT, when int is wide enough.
1820 (start_hourglass): Use duration_to_sec_usec to do proper
1821 overflow checking on durations.
1822 * xfaces.c (Fbitmap_spec_p):
1823 Check that fixnums are in proper range for system types.
1824 (compare_fonts_by_sort_order):
1825 Avoid mishandling comparisons due to subtraction overflow.
1826 (Fx_family_fonts, realize_basic_faces):
1827 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1828 (Fx_family_fonts):
1829 Don't assume fixnum fits in int.
1830 Use SAFE_ALLOCA_LISP, not alloca.
1831 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1832 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1833 (face_at_buffer_position, face_for_overlay_string)
1834 (face_at_string_position):
1835 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1836 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1837 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1838 (Fx_show_tip):
1839 Check that fixnums are in proper range for system types.
1840 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1841 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1843 (Fx_change_window_property): Don't assume fixnums fit in int.
1844 * xfont.c (xfont_chars_supported):
1845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1846 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1847 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1849 * xml.c (parse_region):
1850 * xrdb.c (magic_file_p):
1851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1852 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1853 (x_get_local_selection, x_reply_selection_request)
1854 (x_handle_selection_request, wait_for_property_change):
1855 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1856 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1857 short is wide enough.
1858 (x_send_client_event): Don't assume fixnum fits in int.
1859 * xterm.c (x_x_to_emacs_modifiers):
1860 Don't assume EMACS_INT overflows nicely into int.
1861 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1862 may come from Lisp.
1863 (handle_one_xevent): NATNUMP can eval its arg twice.
1864 (x_connection_closed):
1865 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1866 * xterm.h: Adjust decls to match defn changes elsewhere.
1867 (struct scroll_bar): Use struct vectorlike_header
1868 rather than rolling our own approximation.
1869 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1870
c6574eb5
GM
18712012-05-25 Glenn Morris <rgm@gnu.org>
1872
1873 * lisp.mk (lisp): Update for more files being compiled now.
1874
e8d32c7e
SM
18752012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1876
48def666
SM
1877 * lread.c: Remove `read_pure' which makes no difference.
1878 (read_pure): Remove var.
1879 (unreadpure): Remove function.
1880 (readevalloop): Don't call read_list with -1 flag.
1881 (read1, read_vector): Don't test read_pure any more.
1882 (read_list): Simplify.
1883
e8d32c7e
SM
1884 * fileio.c, character.h: Minor style tweaks.
1885
4b2addb7
DA
18862012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1887
1888 * window.h (clip_changed): Remove useless declaration.
1889
584461b2
JB
18902012-05-22 Juanma Barranquero <lekktu@gmail.com>
1891
1892 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1893 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1894
34374650
PE
18952012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1896
1897 Remove src/m/*.
1898 This directory predates autoconf and is no longer needed nowadays.
1899 Move its few remaining bits of functionality to where they're needed.
1900 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1901 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1902 * m/template.h: Remove.
1903 * Makefile.in (M_FILE): Remove. All uses removed.
1904 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1905 * lisp.h (USE_LSB_TAG):
1906 * mem-limits.h (EXCEEDS_LISP_PTR):
1907 Use VAL_MAX, not VALBITS, in #if.
1908 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1909 (EMACS_UINT): Define unconditionally now.
1910 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1911 (BITS_PER_EMACS_INT): New constants, replacing
1912 what used to be in config.h, but not useful in #if.
1913 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1914 define them any more.
1915 (VAL_MAX): New macro.
1916 (VALMASK): Use it.
1917 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1918 BITS_PER_EMACS_INT, in #if.
1919 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1920 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1921 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1922 * s/ms-w32.h (DATA_START):
1923 Move here from removed file m/intel386.h.
1924 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1925 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1926
261cb4bb
PE
19272012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1928
1929 Assume C89 or later.
1930 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1931 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1932 (xrealloc):
1933 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1934 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1935 * textprop.c, tparam.c (NULL): Remove.
1936 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1937 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1938 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1939 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1940 * xterm.c (input_signal_count): Assume volatile works.
1941
ff23cd9f
KB
19422012-05-21 Ken Brown <kbrown@cornell.edu>
1943
1944 * xgselect.c (xg_select): Fix first argument in call to 'select'
1945 (bug#11508).
1946
1b170bc6
KB
19472012-05-20 Ken Brown <kbrown@cornell.edu>
1948
1949 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1950 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1951
b2f4d39f
KB
19522012-05-19 Ken Brown <kbrown@cornell.edu>
1953
1954 * xfns.c (x_in_use): Remove `static' qualifier.
1955 * xterm.h (x_in_use): Declare.
1956 * xgselect.c: Include xterm.h.
1957 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1958 and `display_arg' (bug#9754).
1959
003fdae2
PE
19602012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1961
9232a6d9
PE
1962 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1963
003fdae2
PE
1964 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1965 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1966
784b56e2
EZ
19672012-05-18 Eli Zaretskii <eliz@gnu.org>
1968
1969 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1970
1971 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1972 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1973
1974 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1975 reference to image_cache->refcount.
1976 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1977
a0a79cde
JL
19782012-05-17 Juri Linkov <juri@jurta.org>
1979
1980 * search.c (Fword_search_regexp, Fword_search_backward)
1981 (Fword_search_forward, Fword_search_backward_lax)
1982 (Fword_search_forward_lax): Move functions to isearch.el
1983 (bug#10145, bug#11381).
1984
b0572523
PE
19852012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1986
1987 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1988
9660f5fc
SM
19892012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1990
1991 * lread.c (init_obarray): Declare Qt and Qnil as special.
1992
4374de83
GM
19932012-05-14 Glenn Morris <rgm@gnu.org>
1994
1995 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1996 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1997
dc44c39a
PE
19982012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1999
078c97cb
PE
2000 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2001
dc44c39a
PE
2002 * unexaix.c: Port to more-recent AIX compilers.
2003 (report_error, report_error_1, make_hdr, copy_sym)
2004 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2005 Make arguments const char *, not char *, to avoid violations of C
2006 standard and to fix some AIX warnings reported by Gilles Pion.
2007
e18afed7 20082012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2009
2010 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2011 already have overlays loaded.
2012 (handle_single_display_spec): Before returning without displaying
2013 fringe bitmap, synchronize the bidi iterator with the main display
2014 iterator, by calling iterate_out_of_display_property.
2015 (iterate_out_of_display_property): Detect buffer iteration by
2016 testing that it->string is a Lisp string.
2017 (get_next_display_element): When the current object is exhausted,
2018 and there's something on it->stack, call set_iterator_to_next to
2019 proceed with what's on the stack, instead of returning zero.
2020 (set_iterator_to_next): If called at the end of a Lisp string,
2021 proceed to consider_string_end without incrementing string
2022 position. Don't increment display vector index past the end of
2023 the display vector. (Bug#11417)
c8fb9dc6
EZ
2024 (pos_visible_p): Don't report a position visible when move_it_to
2025 stopped at the last line of window, which happens to be scanned
2026 backwards by the bidi iteration. (Bug#11464)
ac268e67 2027
e18afed7 20282012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2029
2030 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2031 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2032 are on a TTY, and thus unable to display on the fringes.
2033 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2034 so we need to signal to the caller that this is a "replacing"
2035 display spec. This fixes display when the spec is invalid or we
2036 are on a TTY.
2037
e18afed7 20382012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2039
2040 * unexaix.c (make_hdr): Fix typo in prototype.
2041 This bug broke the build on AIX. Problem reported by Gilles Pion.
2042
9d0a235a
MA
20432012-05-14 Michael Albinus <michael.albinus@gmx.de>
2044
2045 * keyboard.c (kbd_buffer_get_event): Read special events also in
2046 batch mode. (Bug#11415)
2047
9e6b06ed
GM
20482012-05-12 Glenn Morris <rgm@gnu.org>
2049
2050 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2051
c1a1d7a3
EZ
20522012-05-12 Eli Zaretskii <eliz@gnu.org>
2053
2054 * lisp.mk (lisp): Add newcomment.elc.
2055
3fe7cdc8
GM
20562012-05-12 Glenn Morris <rgm@gnu.org>
2057
2058 * Makefile.in (MKDIR_P): New, set by configure.
2059 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2060
53f7d2c0
PE
20612012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2062
2063 Remove unused function hourglass_started.
2064 * dispextern.h (hourglass_started):
2065 * w32fns.c (hourglass_started):
2066 * xdisp.c (hourglass_started): Remove.
2067
75aafb17
JB
20682012-05-10 Juanma Barranquero <lekktu@gmail.com>
2069
2070 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2071 Update dependencies.
2072
12959e8e
PE
20732012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2074
97107e2e
PE
2075 * xgselect.c (xg_select): Put maxfds+1 into a var.
2076 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2077
12959e8e
PE
2078 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2079
836d29b3
DA
20802012-05-10 Dave Abrahams <dave@boostpro.com>
2081
2082 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2083 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2084
5cb67954
MA
20852012-05-09 Michael Albinus <michael.albinus@gmx.de>
2086
2087 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2088 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2089 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2090 Initialize xd_registered_buses.
2091
3478ec45
PE
20922012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2093
b263a6b0
PE
2094 Untag more efficiently if USE_LSB_TAG.
2095 This is based on a proposal by YAMAMOTO Mitsuharu in
2096 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2097 For an admittedly artificial (nth 8000 longlist) benchmark on
2098 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2099 Emacs's overall text size by 1%.
2100 * lisp.h (XUNTAG): New macro.
2101 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2102 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2103 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2104 * eval.c (Fautoload):
2105 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2106 * frame.h (XFRAME): Use XUNTAG.
2107
3478ec45
PE
2108 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2109 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2110 Remove unportable assumptions about print widths of types like
2111 dbus_uint32_t.
2112 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2113 intptr_t when converting between pointer and integer, to avoid GCC
2114 warnings about wrong width.
2115
666b903b 21162012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2117
2118 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2119 stack for each reader_thread, instead of defaulting to 8MB
2120 determined by the linker. This avoids failures in creating
2121 subprocesses on Windows 7, see the discussion in this thread:
2122 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2123
b120cc17
JC
21242012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2125
2126 Fix up display of the *Minibuf-0* buffer in the mini window.
2127 * keyboard.c (read_char): Don't clear the echo area if there's no
2128 message to clear.
2129 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2130 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2131
9a4b36f8
MA
21322012-05-07 Michael Albinus <michael.albinus@gmx.de>
2133
2134 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2135 batch mode.
2136
e5f9458f
CY
21372012-05-06 Chong Yidong <cyd@gnu.org>
2138
2139 * lisp.mk (lisp): Update.
2140
eceeb5fc 21412012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2142
2143 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2144
71873e2b
SM
21452012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2146
2147 * data.c (PUT_ERROR): New macro.
2148 (syms_of_data): Use it. Add new error type `user-error'.
2149 * undo.c (user_error): New function.
2150 (Fprimitive_undo): Use it.
2151 * print.c (print_error_message): Adjust print style for `user-error'.
2152 * keyboard.c (user_error): New function.
2153 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2154
ab0fa4e4
PE
21552012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2156
2157 Do not limit current-time-string to years 1000..9999.
2158 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2159 (Fcurrent_time_string): Support any year that is supported by the
2160 underlying localtime representation. Don't use asctime, as it
2161 has undefined behavior for years outside the range -999..9999.
2162
7ed806a7
PE
21632012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2164
2165 Fix race conditions involving setenv, gmtime, localtime, asctime.
2166 Without this fix, interrupts could mess up code that uses these
2167 nonreentrant functions, since setting TZ invalidates existing
2168 tm_zone or tzname values, and since most of these functions return
2169 pointers to static storage.
2170 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2171 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2172 Grow the critical sections to include not just invoking
2173 localtime/gmtime, but also accessing these functions' results
2174 including their tm_zone values if any, and any related TZ setting.
2175 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2176 so that the struct tm is saved in the critical section.
2177 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2178 motivated by the fact that memory allocation needs to be outside
2179 the critical section.
2180
0c16dfed
DA
21812012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2182
2183 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2184 with RESET_INTERVAL.
2185
2186 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2187 Remove duplicated buffer name initialization.
2188
3f83ace8
JM
21892012-05-02 Jim Meyering <jim@meyering.net>
2190
2191 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2192
c7b8541e
JM
2193 * xfns.c (x_window): Use xstrdup (Bug#11375).
2194
90207a15 21952012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2196
2197 * xdisp.c (pos_visible_p): If already at a newline from the
2198 display string before the 'while' loop, don't walk back the glyphs
2199 from it3.glyph_row. Solves assertion violation when the display
2200 string begins with a newline (egg.el). (Bug#11367)
2201
b593d6a9
AH
22022012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2203
2204 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2205 Move to simple.el.
2206
4737362e
GM
22072012-05-01 Glenn Morris <rgm@gnu.org>
2208
99cf43f9
GM
2209 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2210 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2211 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2212 All were removed before 23.1.
2213
9311dcff
GM
2214 * dispnew.c: Remove HAVE_LIBNCURSES test;
2215 it is always true on relevant platforms.
2216
4d5c6349
GM
2217 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2218 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2219
4737362e
GM
2220 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2221
74dd3a6b
AS
22222012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2223
2224 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2225 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2226 Remove.
2227
13c379ee
PE
22282012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2229
2230 Do not avoid creating empty evaporating overlays (Bug#9642).
2231 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2232 That is, do not delete an evaporating overlay if it becomes
2233 empty after its bounds are adjusted to fit within its buffer.
2234 This fix caused other problems, and I'm reverting it until we get
2235 to the bottom of them.
2236
a8e7d6d7 22372012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2238
2239 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2240
a8e7d6d7 22412012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2242
2243 * xdisp.c (pos_visible_p): If the window start position is beyond
2244 ZV, start the display from buffer beginning. Prevents assertion
2245 violation in init_iterator when the minibuffer window is scrolled
2246 via the scroll bar.
2247
2248 * window.c (window_scroll_pixel_based): Likewise.
2249
a8e7d6d7 22502012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2251
2252 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2253
a8e7d6d7 22542012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2255
2256 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2257 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2258
a8e7d6d7 22592012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2260
b593d6a9
AH
2261 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2262 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2263
1c6900d9
EZ
22642012-04-26 Eli Zaretskii <eliz@gnu.org>
2265
4c3fa1d9
EZ
2266 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2267 display element, check also the underlying string or buffer
2268 character. (Bug#11341)
2269
1c6900d9
EZ
2270 * w32menu.c: Include w32heap.h.
2271 (add_menu_item): If the call to AppendMenuW (via
2272 unicode_append_menu) fails, disable Unicode menus only if we are
2273 running on Windows 9X/Me.
2274
42bf8205
AS
22752012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2276
2277 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2278 (xgetint): Add missing shift for LSB tags.
2279
b1bac16e
MR
22802012-04-24 Martin Rudalics <rudalics@gmx.at>
2281
2282 * keyboard.c (read_char): Don't wipe echo area for select window
2283 events: These might get delayed via `mouse-autoselect-window'
2284 (Bug#11304).
2285
d69621cc
JB
22862012-04-24 Juanma Barranquero <lekktu@gmail.com>
2287
2288 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2289 manipulation of :loaded-from data.
2290
02fd101b
JB
22912012-04-23 Juanma Barranquero <lekktu@gmail.com>
2292
2293 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2294 now a cons (bug#11311).
2295
888bec30
PE
22962012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2297
89a438bd
PE
2298 Do not create empty overlays with the evaporate property (Bug#9642).
2299 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2300 if it becomes empty after its bounds are adjusted to fit within
2301 its buffer. Without this fix, in a nonempty buffer (let ((o
2302 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2303 yields an empty overlay that has the evaporate property, which is
2304 not supposed to happen.
2305
1068fe4d
PE
2306 Fix minor GTK3 problems found by static checking.
2307 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2308 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2309 (struct _EmacsFixedClass, emacs_fixed_get_type):
2310 Move decls here from emacsgtkfixed.h, since they needn't be public.
2311 (emacs_fixed_get_type): Now static.
2312 (emacs_fixed_class_init): Omit unused local.
2313 (emacs_fixed_child_type): Remove; unused.
2314 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2315 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2316 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2317 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2318 (EMACS_FIXED_GET_CLASS): Remove; unused.
2319 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2320
888bec30
PE
2321 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2322 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2323
de85e130
PE
23242012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2325
d0baac98 2326 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2327 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2328 (__malloc_size_t, __malloc_ptrdiff_t):
2329 Remove. All uses removed, replaced by the definiens if needed,
2330 since we can assume C89 or better now.
2331 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2332 (protect_malloc_state, align, get_contiguous_space)
2333 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2334 (malloc_atfork_handler_child, malloc_enable_thread)
2335 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2336 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2337 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2338 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2339 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2340 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2341 Define using prototypes, not old style.
2342 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2343 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2344 (align): Don't assume that signed integer overflow wraps around.
2345 Omit unused local var.
2346 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2347 (_free_internal_nolock, memalign, mallochook, reallochook):
2348 Omit no-longer-needed casts.
2349 (valloc): Use getpagesize, not __getpagesize.
2350 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2351 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2352
de85e130
PE
2353 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2354
dcbf5805
MA
23552012-04-22 Michael Albinus <michael.albinus@gmx.de>
2356
2357 Move functions from C to Lisp. Make non-blocking method calls
2358 the default. Implement further D-Bus standard interfaces.
2359
2360 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2361 (QCdbus_request_name_allow_replacement)
2362 (QCdbus_request_name_replace_existing)
2363 (QCdbus_request_name_do_not_queue)
2364 (QCdbus_request_name_reply_primary_owner)
2365 (QCdbus_request_name_reply_in_queue)
2366 (QCdbus_request_name_reply_exists)
2367 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2368 (QCdbus_registered_serial, QCdbus_registered_method)
2369 (QCdbus_registered_signal): New Lisp objects.
2370 (XD_DEBUG_MESSAGE): Use sizeof.
2371 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2372 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2373 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2374 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2375 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2376 (xd_signature, xd_append_arg): Allow float for integer types.
2377 (xd_get_connection_references): New function.
b593d6a9
AH
2378 (xd_get_connection_address): Rename from xd_initialize.
2379 Return cached address.
dcbf5805
MA
2380 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2381 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2382 level.
2383 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2384 Return number of refcounts.
dcbf5805
MA
2385 (Fdbus_get_unique_name): Make stronger parameter check.
2386 (Fdbus_message_internal): New defun.
2387 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2388 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2389 (Fdbus_send_signal, Fdbus_register_service)
2390 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2391 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2392 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2393 (Vdbus_compiled_version, Vdbus_runtime_version)
2394 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2395 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2396 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2397 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2398 Adapt docstring.
dcbf5805 2399
52828e02
PE
24002012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2401
da05bc4c
PE
2402 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2403 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2404 Do not assume ptrdiff_t is the same width as 'int'.
2405
52828e02
PE
2406 * alloc.c: Handle unusual debugging option combinations.
2407 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2408 since the two debugging options are incompatible.
2409 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2410 is defined.
2411 (mem_init, mem_insert, mem_insert_fixup):
2412 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2413 (NEED_MEM_INSERT): Remove; no longer needed.
2414
f01769f9
LL
24152012-04-22 Leo Liu <sdl.web@gmail.com>
2416
2417 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2418
5790543d
PE
24192012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2420
2421 * sysdep.c [__FreeBSD__]: Minor cleanups.
2422 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2423 Use Emacs indenting style more consistently. Avoid some casts.
2424 Use 'double' consistently rather than mixing 'float' and 'double'.
2425
b91b7e4d
EW
24262012-04-21 Eduard Wiebe <usenet@pusto.de>
2427
b593d6a9
AH
2428 * sysdep.c (list_system_processes, system_process_attributes):
2429 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2430
6114eb15
AS
24312012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2432
2433 * lisp.mk (lisp): Update.
2434
2f38dff7
PE
24352012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2436
2437 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2438 It is never used otherwise.
2439
4ae29f89
SM
24402012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2441
2442 * print.c (print_preprocess): Only check print_depth if print-circle
2443 is nil.
2444 (print_object): Check for cycles even when print-circle is nil and
2445 print-gensym is t, but only check print_depth if print-circle is nil.
2446
f30d612a
CY
24472012-04-20 Chong Yidong <cyd@gnu.org>
2448
2449 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2450 set the status to "failed" and ensure that sentinel is run.
2451
c07a4c0b 24522012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2453
2454 * process.c (Fset_process_inherit_coding_system_flag)
2455 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2456 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2457
c07a4c0b 24582012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2459
2460 * xdisp.c (string_buffer_position_lim): Limit starting position to
2461 BEGV.
2462 (set_cursor_from_row): If called for a mode-line or header-line
2463 row, return zero immediately.
2464 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2465 farther than the first row after the header line, if any.
2466 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2467 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2468
c07a4c0b 24692012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2470
4ae29f89
SM
2471 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2472 (bug#11238).
ad3a2b41 2473
c07a4c0b 24742012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 24752012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2476
2477 configure: new option --enable-gcc-warnings (Bug#11207)
2478 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2479 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2480 (ALL_CFLAGS): Use new macros rather than old.
2481 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2482 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2483 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2484 -Wunused-result, -Wunused-variable. This should go away once
2485 the Emacs and Gnulib regex code is merged.
2486 (xmalloc, xrealloc): Now static.
2487
aba027e8
PE
24882012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2489
2490 * dired.c (Fsystem_groups): Remove unused local.
2491
e5a36063
GM
24922012-04-17 Glenn Morris <rgm@gnu.org>
2493
2494 * dired.c (Fsystem_users): Doc fix.
2495
316411f0
DA
24962012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2497
2498 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2499 (syms_of_dired): Add them.
2500
9426aba4
PE
25012012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2502
b62a57be
PE
2503 Fix minor alloc.c problems found by static checking.
2504 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2505 New extern decls, to avoid calling undeclared functions.
2506 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2507 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2508 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2509 (NEED_MEM_INSERT): New macro.
2510 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2511 Remove one incorrect comment and fix another.
b62a57be 2512
3539f31f
PE
2513 Fix minor ralloc.c problems found by static checking.
2514 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2515 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2516 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2517 (r_alloc_sbrk): Now static.
2518
a041960a
PE
2519 Improve ralloc.c interface checking.
2520 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2521 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2522 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2523 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2524 [REL_ALLOC]: ... to here, to check interface.
2525 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2526 Remove decls. This fixes an "It stinks!".
2527
9426aba4
PE
2528 * alloc.c (which_symbols): Fix alignment issue / type clash.
2529
d55c12ed
AS
25302012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2531
2532 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2533 (struct Lisp_Misc_Any): Likewise.
2534 (struct Lisp_Free): Likewise.
2535 * alloc.c (union aligned_Lisp_Symbol): Define.
2536 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2537 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2538 (union aligned_Lisp_Misc): Define.
2539 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2540 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2541 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2542
b948ce8b
PE
25432012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2544
2545 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2546 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2547 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2548 * s/netbsd.h, s/sol2-6.h:
2549 Remove definition of GC_MARK_STACK, since the default now works.
2550 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2551 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2552 no longer the default.
2553 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2554
35dc09a1 25552012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2556
35dc09a1
GM
2557 * lread.c (lisp_file_lexically_bound_p):
2558 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2559
35dc09a1
GM
25602012-04-14 Eli Zaretskii <eliz@gnu.org>
2561
2562 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2563 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2564
25652012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2566
2567 * nsterm.m (constrainFrameRect): Always constrain when there is only
2568 one screen (Bug#10962).
2569
bcd86815
KB
25702012-04-13 Ken Brown <kbrown@cornell.edu>
2571
2572 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2573
c25df26e
RT
25742012-04-13 Reuben Thomas <rrt@sc3d.org>
2575
2576 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2577
0fc59f1e
DC
25782012-04-11 Daniel Colascione <dancol@dancol.org>
2579
2580 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2581 against is gone. It's better to use vfork now so that when Cygwin
2582 gains a new, working vfork, we use it automatically (bug#10398).
2583
de8c03dc
SM
25842012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2585
2586 * window.c (save_window_save): Obey window-point-insertion-type.
2587
2f097256
GM
25882012-04-11 Glenn Morris <rgm@gnu.org>
2589
2590 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2591
453b951e
SM
25922012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2593
2594 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2595
75f1671a 25962012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2597
2598 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2599 (force_quit_count): New var.
2600 (handle_interrupt): Use it.
2601
2a8ce227
JB
26022012-04-10 Juanma Barranquero <lekktu@gmail.com>
2603
2604 * w32.c (w32_delayed_load): Record the full path of the library
2605 being loaded (bug#10424).
2606
935396c0
GM
26072012-04-09 Glenn Morris <rgm@gnu.org>
2608
05920a43
GM
2609 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2610 not just in the obarray, before snarfing them. (Bug#11036)
2611
935396c0
GM
2612 * Makefile.in ($(leimdir)/leim-list.el):
2613 Pass EMACS rather than BUILT_EMACS.
2614
a18ecafa
TZ
26152012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2616
2617 * process.c (make_process):
2618 * process.h: Add integer `gnutls_handshakes_tried' member to
2619 process struct.
2620
6bbef4e5
JC
2621 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2622 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2623
2624 * gnutls.c (gnutls_log_function2i): Convenience log function.
2625 (emacs_gnutls_read): Use new log functions,
2626 `gnutls_handshakes_tried' process member, and
2627 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2628 attempts per process (connection).
2629
b4d3bc10
CY
26302012-04-09 Chong Yidong <cyd@gnu.org>
2631
2632 * eval.c (Fuser_variable_p, user_variable_p_eh)
2633 (lisp_indirect_variable): Functions deleted.
2634 (Fdefvar): Caller changed.
2635
2636 * callint.c (Finteractive, Fcall_interactively):
2637 * minibuf.c (Fread_variable): Callers changed.
2638
70f4d973
EZ
26392012-04-09 Eli Zaretskii <eliz@gnu.org>
2640
2641 * xdisp.c (set_cursor_from_row): If the display string appears in
2642 the buffer at position that is closer to point than the position
2643 after the display string, display the cursor on the first glyph of
2644 the display string. Fixes cursor display when a 'display' text
2645 property immediately follows invisible text. (Bug#11094)
2646
cb3c2e3e
PE
26472012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2648
2649 composite.c: use 'double' consistently
2650 * composite.c (get_composition_id): Use 'double' consistently
2651 instead of converting 'float' to 'double' and vice versa; this is
2652 easier to understand and avoids a GCC warning.
2653
fd06db5d
GM
26542012-04-09 Glenn Morris <rgm@gnu.org>
2655
50fe702a
GM
2656 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2657 preparation for dumping it with emacs. (Bug#4789)
2658 (leimdir): New variable.
2659 ($(leimdir)/leim-list.el): New rule.
2660 (emacs$(EXEEXT)): Depend on leim-list.el.
2661
fd06db5d
GM
2662 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2663 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2664 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2665
55c131ee
AS
26662012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2667
2668 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2669 proper alignment.
2670
9209588f
JB
26712012-04-07 Juanma Barranquero <lekktu@gmail.com>
2672
2673 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2674 Remove unused local variable.
2675
e3fb2efb
PE
26762012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2677
2678 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2679 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2680 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2681 objects, as mark_maybe_pointer will catch them otherwise.
2682 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2683 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2684
b5385551
PE
26852012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2686
2687 Fix typo that broke non-Windows builds.
2688 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2689
9078ead6
EZ
26902012-04-07 Eli Zaretskii <eliz@gnu.org>
2691
2692 Support building on MS-Windows with libxml2.
2693
2694 * makefile.w32-in (OBJ2): Add xml.$(O).
2695 (GLOBAL_SOURCES): Add xml.c.
2696 ($(BLD)/xml.$(O)): New dependency list.
2697
2698 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2699 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2700 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2701 [!WINDOWSNT]: New macros.
2702 (init_libxml2_functions, libxml2_loaded_p): New functions.
2703 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2704 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2705 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2706 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2707 linked in).
6bbef4e5
JC
2708 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2709 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2710 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2711
2712 * emacs.c: Don't include libxml/parser.h.
2713 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2714 xmlCleanupParser directly.
2715
2716 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2717
3811fdf3
EZ
27182012-04-07 Eli Zaretskii <eliz@gnu.org>
2719
2720 * indent.c (Fvertical_motion): If there is a display string at
2721 point, use it.vpos to compute how many lines to backtrack after
2722 move_it_to point. (Bug#11133)
2723
2f8e16b2
EZ
27242012-04-06 Eli Zaretskii <eliz@gnu.org>
2725
2726 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2727 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2728 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2729 macros related to unification of CJK characters. For the details,
2730 see the discussion following the message here:
2731 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2732
3d439cd1
CY
27332012-04-04 Chong Yidong <cyd@gnu.org>
2734
2735 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2736
8bc53d00
EZ
27372012-04-01 Eli Zaretskii <eliz@gnu.org>
2738
2739 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2740 instead of alloca. (Bug#11138)
2741
3b0512a3
AS
27422012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2743
2744 * w32menu.c (is_simple_dialog): Properly check lisp types.
2745 (Bug#11141)
2746
8427ddd2
EZ
27472012-03-31 Eli Zaretskii <eliz@gnu.org>
2748
979022ef
EZ
2749 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2750 position we get to after a call to move_it_to fails the
2751 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2752 only if we wind up in a string from display property. (Bug#11063)
2753
a6b1c7cc
EZ
2754 * window.c (Fdelete_other_windows_internal): Invalidate the row
2755 and column information about mouse highlight, so that redisplay
2756 restores it after reallocating the glyph matrices. (Bug#7464)
2757
8427ddd2
EZ
2758 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2759 string comes from a `display' text property, use the buffer
2760 position of that property as if we actually saw that position in
2761 the row's glyphs.
697ba24b
EZ
2762 (move_it_by_lines): Remove the assertion that
2763 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2764 violated when there's a before-string at the beginning of a line.
2765 (Bug#11063)
8427ddd2 2766
65a0a738
EZ
27672012-03-30 Eli Zaretskii <eliz@gnu.org>
2768
2769 * xdisp.c (append_space_for_newline): If the default face was
2770 remapped, use the remapped face for the appended newline.
2771 (extend_face_to_end_of_line): Use the remapped default face for
2772 extending the face to the end of the line.
2773 (display_line): Call extend_face_to_end_of_line when the default
2774 face was remapped. (Bug#11068)
2775
581355cc
EZ
27762012-03-29 Eli Zaretskii <eliz@gnu.org>
2777
2778 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2779
e8fc049f
SM
27802012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2781
2782 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2783
4fb9a543
GM
27842012-03-27 Glenn Morris <rgm@gnu.org>
2785
2786 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2787 Doc fixes.
2788
679910f1
KH
27892012-03-26 Kenichi Handa <handa@m17n.org>
2790
2791 * dispextern.h (struct glyph): Fix previous change. Change the
2792 bit length of glyphless.ch to 25 (Bug#11082).
2793
90d49b7f
CY
27942012-03-26 Chong Yidong <cyd@gnu.org>
2795
2796 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2797 (command_loop_1): Use it; inhibit selection update for
2798 handle-select-window too (Bug#8996).
2799
f514f6f0
FP
28002012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2801
e8fc049f 2802 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2803
bf43fa51
KH
28042012-03-25 Kenichi Handa <handa@m17n.org>
2805
2806 * dispextern.h (struct glyph): Change the bit length of
2807 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2808
8a0c01dd
EZ
28092012-03-24 Eli Zaretskii <eliz@gnu.org>
2810
2811 * s/ms-w32.h (tzname): Include time.h before redirecting to
2812 _tzname. Fixes the MSVC build. (Bug#9960)
2813
7d1c3a76
AS
28142012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2815
8ed79523
AS
2816 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2817 characters.
2818
7d1c3a76
AS
2819 * xterm.c (XTread_socket): Only modify handling_signal if
2820 !SYNC_INPUT. (Bug#11080)
2821
e99a9b8b
EZ
28222012-03-23 Eli Zaretskii <eliz@gnu.org>
2823
2824 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2825 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2826 when fetching a multibyte character consumes more bytes than
2827 CHAR_BYTES returns, due to unification of CJK characters in
2828 string_char. (Bug#11073)
2829
5063c0e1
TN
28302012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2831
2832 * process.c (wait_reading_process_output): Handle pty disconnect
2833 by refraining from sending oneself a SIGCHLD (bug#10933).
2834
9f851fbd
CY
28352012-03-22 Chong Yidong <cyd@gnu.org>
2836
2837 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2838
5063c0e1 2839 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2840 Mark string as coming from a prefix property.
2841 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2842 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2843
fb5b8aca
CY
28442012-03-21 Chong Yidong <cyd@gnu.org>
2845
2846 * xfaces.c (Vface_remapping_alist): Doc fix.
2847
62356a1b
EZ
28482012-03-20 Eli Zaretskii <eliz@gnu.org>
2849
2850 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2851 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2852 Doc fixes.
62356a1b 2853
025de85b
CY
28542012-03-20 Chong Yidong <cyd@gnu.org>
2855
2856 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2857 to reflect default non-nil value of redisplay-dont-pause.
2858
4827f94e
KH
28592012-03-19 Kenichi Handa <handa@m17n.org>
2860
2861 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2862 it fit in a valid range (Bug#11003).
2863
e50a24a2
EZ
28642012-03-18 Eli Zaretskii <eliz@gnu.org>
2865
2866 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2867 that is not from display property, accept the row as a "cursor
2868 row" if one of the string's character has a non-nil `cursor'
2869 property. Fixes cursor positioning when there are newlines in
2870 overlay strings, e.g. in icomplete.el. (Bug#11035)
2871
9af5ed87
PE
28722012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2873
2874 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2875
d1f55f16
CY
28762012-03-12 Chong Yidong <cyd@gnu.org>
2877
2878 * eval.c (inhibit_lisp_code): Rename from
2879 inhibit_window_configuration_change_hook; move from window.c.
2880
2881 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2882 * window.c (run_window_configuration_change_hook)
2883 (syms_of_window): Callers changed.
2884
66c5eebd
CY
28852012-03-11 Chong Yidong <cyd@gnu.org>
2886
413df973
CY
2887 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2888
66c5eebd
CY
2889 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2890
1de11f56
CY
28912012-03-10 Chong Yidong <cyd@gnu.org>
2892
2893 * frame.c (other_visible_frames): Don't assume the selected frame
2894 is visible (Bug#10955).
2895
cae07000
SM
28962012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2897
2898 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2899
89c94350
JD
29002012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2901
2902 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2903 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2904 zero (Bug#10954).
2905
999dd333
GM
29062012-03-03 Glenn Morris <rgm@gnu.org>
2907
01a6dcc8 2908 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2909
de0100f2
EZ
29102012-03-02 Eli Zaretskii <eliz@gnu.org>
2911
2912 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2913 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2914 (redisplay_window, next_element_from_string): Fix typos in
2915 comments.
3e441275
EZ
2916 (redisplay_window): Pass to move_it_vertically the margin in
2917 pixels, not in screen lines.
de0100f2 2918
96a72ee9
GM
29192012-03-02 Glenn Morris <rgm@gnu.org>
2920
2921 * buffer.c (buffer-list-update-hook): Doc fix.
2922
312508d7
EZ
29232012-02-29 Eli Zaretskii <eliz@gnu.org>
2924
2925 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2926 push_it before setting up the iterator for the first overlay
2927 string, even if we have an empty string loaded.
2928 (next_overlay_string): If there's an empty string on the iterator
2929 stack, pop the stack. (Bug#10903)
2930
27f3c637
PE
29312012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2932
2933 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2934 Suggested by Stefan Monnier in
2935 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2936 * alloc.c (widen_to_Lisp_Object): New static function.
2937 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2938 and widening them to Lisp_Objects. This would work even if
2939 USE_LSB_TAG is defined and wide integers are used, which might
2940 happen in a future version of Emacs.
2941
3c9dfce6
CY
29422012-02-25 Chong Yidong <cyd@gnu.org>
2943
fa74b241
CY
2944 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2945 Doc fix.
2946
3c9dfce6
CY
2947 * xselect.c (Fx_selection_exists_p): Doc fix.
2948 (x_clipboard_manager_save_all): Print an informative message
2949 before saving to clipboard manager.
2950
9486df08
CY
29512012-02-24 Chong Yidong <cyd@gnu.org>
2952
2953 * keyboard.c (process_special_events): Handle all X selection
2954 requests in kbd_buffer, not just the next one (Bug#8869).
2955
f01d3321
CY
29562012-02-23 Chong Yidong <cyd@gnu.org>
2957
2958 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2959 call when setting menu-bar-lines and tool-bar-lines parameters.
2960 (unwind_create_frame_1): New helper function.
2961
2962 * window.c (inhibit_window_configuration_change_hook): New var.
2963 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2964 (syms_of_window): Initialize it.
f01d3321 2965
86b847b6
CY
29662012-02-22 Chong Yidong <cyd@gnu.org>
2967
2968 * xterm.c (x_draw_image_relief): Add missing type check for
2969 Vtool_bar_button_margin (Bug#10743).
2970
a59225b1
CY
29712012-02-21 Chong Yidong <cyd@gnu.org>
2972
2973 * fileio.c (Vfile_name_handler_alist): Doc fix.
2974
2975 * buffer.c (Fget_file_buffer): Protect against invalid file
2976 handler return value.
2977
310f5bd4
PE
29782012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2979
cb3a28cc
PE
2980 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2981 when computing $valmask.
2982
310f5bd4
PE
2983 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2984 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2985 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2986 It's useless in that case, and it can cause problems on hosts
2987 that allocate halves of EMACS_INT values separately.
2988 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2989 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2990 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2991 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2992 it avoids undefined behavior on hosts where shifting right by more
2993 than the word width has undefined behavior.
2994
2375c96a
CY
29952012-02-19 Chong Yidong <cyd@gnu.org>
2996
2997 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2998 (Funhandled_file_name_directory, Ffile_name_as_directory)
2999 (Fdirectory_file_name, Fexpand_file_name)
3000 (Fsubstitute_in_file_name): Protect against invalid file handler
3001 return values (Bug#10845).
3002
3eb49e71
EZ
30032012-02-18 Eli Zaretskii <eliz@gnu.org>
3004
3005 * .gdbinit (pitx): Fix incorrect references to fields of the
3006 iterator stack.
3007
7b926f3f
CY
30082012-02-17 Chong Yidong <cyd@gnu.org>
3009
3010 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3011
11273115
PE
30122012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3013
3014 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3015 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3016
c3a70e2b
CY
30172012-02-15 Chong Yidong <cyd@gnu.org>
3018
3019 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3020 marked as special. Also, starting docstrings with * is obsolete.
3021
0ca43699
AS
30222012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3023
3024 * gnutls.c (emacs_gnutls_write): Fix last change.
3025
2e8f3c56
LI
30262012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3027
3028 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3029 send_process.
3030
af70074f
SM
30312012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3032
3033 * keymap.c (Fsingle_key_description): Handle char ranges.
3034
95986d52
CY
30352012-02-12 Chong Yidong <cyd@gnu.org>
3036
afd83bd1
CY
3037 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3038 as that creates a dangerous corner case.
3039
95986d52
CY
3040 * window.c (Fdelete_window_internal): Invalidate the mouse
3041 highlight (Bug#9904).
3042
bd7da63e
GM
30432012-02-12 Glenn Morris <rgm@gnu.org>
3044
3045 * xselect.c (Fx_own_selection_internal)
3046 (Fx_get_selection_internal, Fx_disown_selection_internal)
3047 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3048 * nsselect.m (Fx_own_selection_internal)
3049 (Fx_disown_selection_internal, Fx_selection_exists_p)
3050 (Fx_selection_owner_p, Fx_get_selection_internal):
3051 Sync docs and argument specs with the xselect.c versions.
3052
77abcbc2
LI
30532012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3054
3055 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3056
90b671e2
EZ
30572012-02-11 Eli Zaretskii <eliz@gnu.org>
3058
1c0ca0b7
EZ
3059 * w32select.c (Fx_selection_exists_p): Sync doc string and
3060 argument list with xselect.c. (Bug#10783)
3061
3062 * w16select.c (Fx_selection_exists_p): Sync doc string and
3063 argument list with xselect.c. (Bug#10783)
90b671e2 3064
49241268
GM
30652012-02-10 Glenn Morris <rgm@gnu.org>
3066
3067 * fns.c (Fsecure_hash): Doc fix.
3068
f998bbe7 30692012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3070
3071 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3072
0992bd9c
CY
30732012-02-07 Chong Yidong <cyd@gnu.org>
3074
3075 * buffer.c (Fbuffer_local_variables)
3076 (buffer_lisp_local_variables): Handle unbound vars correctly;
3077 don't let Qunbound leak into Lisp.
3078
af008560
GM
30792012-02-07 Glenn Morris <rgm@gnu.org>
3080
dd605cc4
GM
3081 * image.c (Fimagemagick_types): Doc fix.
3082
af008560
GM
3083 * image.c (imagemagick-render-type): Change it from a lisp object
3084 to an integer. Move the doc here from the lisp manual.
3085 Treat all values not equal to 0 the same.
3086
1449fa1d
CY
30872012-02-06 Chong Yidong <cyd@gnu.org>
3088
3089 * doc.c (store_function_docstring): Avoid applying docstring of
3090 alias to base function (Bug#2603).
3091
3723ec07
AS
30922012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3093
3094 * .gdbinit (pp1, pv1): Remove redundant defines.
3095 (pr): Use pp.
3096
79c1cc1e
CY
30972012-02-04 Chong Yidong <cyd@gnu.org>
3098
3099 * nsterm.m: Declare a global (Bug#10694).
3100
d7f29f8e
EZ
31012012-02-04 Eli Zaretskii <eliz@gnu.org>
3102
cae07000
SM
3103 * w32.c (get_emacs_configuration_options):
3104 Include --enable-checking, if specified, in the return value.
d7f29f8e 3105
3b95a6f9
MR
31062012-02-04 Martin Rudalics <rudalics@gmx.at>
3107
3108 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3109 after rounding frame sizes. (Bug#9723)
3110
d6fa96a6
EZ
31112012-02-04 Eli Zaretskii <eliz@gnu.org>
3112
3113 * keyboard.c (adjust_point_for_property): Don't position point
3114 before BEGV. (Bug#10696)
3115
df0b2940
PE
31162012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3117
3118 Handle overflow when computing char display width (Bug#9496).
3119 * character.c (char_width): Return EMACS_INT, not int.
3120 (char_width, c_string_width): Check for overflow when
3121 computing the width; this is possible now that individual
3122 characters can have unbounded width. Problem introduced
3123 by merge from Emacs 23 on 2012-01-19.
3124
6bee44d6
MA
31252012-02-02 Michael Albinus <michael.albinus@gmx.de>
3126
3127 * dbusbind.c (Fdbus_register_method): Mention the return value
3128 :ignore in the docstring.
3129
44f92739
GM
31302012-02-02 Glenn Morris <rgm@gnu.org>
3131
1b9f60cc
GM
3132 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3133
44f92739
GM
3134 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3135 Unconditionally set to t. (Bug#10673)
3136 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3137 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3138 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3139
c5d3843c
KH
31402012-02-02 Kenichi Handa <handa@m17n.org>
3141
3142 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3143 0, do not call append_composite_glyph.
3144
159462d4 31452012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3146
3147 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3148 NULL (Bug#6988).
3149 (x_produce_glyphs): If the component of a composition is a null
3150 string, set it->pixel_width to 1 to avoid zero-width glyph.
3151
78cef877
EZ
31522012-02-01 Eli Zaretskii <eliz@gnu.org>
3153
3154 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3155 first 2 arguments are identical. This makes inserting large
3156 output from a subprocess an order of magnitude faster on
3157 MS-Windows, where all sbrk'ed memory is always contiguous.
3158
97897668
GM
31592012-01-31 Glenn Morris <rgm@gnu.org>
3160
3161 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3162 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3163 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3164
31fd3586
GM
31652012-01-29 Glenn Morris <rgm@gnu.org>
3166
3167 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3168
0e24a8b2
CY
31692012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3170
3171 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3172
cc0adcb0
CY
31732012-01-28 Chong Yidong <cyd@gnu.org>
3174
3175 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3176
acc28cb9
CY
31772012-01-26 Chong Yidong <cyd@gnu.org>
3178
9c69cfb7
CY
3179 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3180
acc28cb9
CY
3181 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3182 repeat counts (Bug#10507).
3183
48da7392
GM
31842012-01-26 Glenn Morris <rgm@gnu.org>
3185
3186 * lread.c (syms_of_lread): Doc fix.
3187
14af5f7f
CY
31882012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3189
3190 * coding.c (encode_designation_at_bol): Change return value to
3191 EMACS_INT.
3192
0b21c100
CY
31932012-01-25 Chong Yidong <cyd@gnu.org>
3194
3195 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3196
3c2907f7
CY
31972012-01-21 Chong Yidong <cyd@gnu.org>
3198
3199 * floatfns.c (Fcopysign): Make the second argument non-optional,
3200 since nil is not allowed anyway.
3201
959ad23f
AS
32022012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3203
3204 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3205 (send_process): Likewise.
3206
34a02f46
MR
32072012-01-19 Martin Rudalics <rudalics@gmx.at>
3208
3209 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3210 (Vwindow_persistent_parameters): Do not use Qstate.
3211 Rewrite doc-strings.
34a02f46 3212
1259009a 32132012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3214
3215 * character.c (char_width): New function.
70d4fdf6
GM
3216 (Fchar_width, c_string_width, lisp_string_width):
3217 Use char_width (Bug#9496).
25ed9e61 3218
6a6ee00d
MR
32192012-01-16 Martin Rudalics <rudalics@gmx.at>
3220
3221 * window.c (Vwindow_persistent_parameters): New variable.
3222 (Fset_window_configuration, save_window_save): Handle persistent
3223 window parameters.
3224
c85efaf7
EZ
32252012-01-14 Eli Zaretskii <eliz@gnu.org>
3226
3227 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3228 thrashing the stack of the thread. (Bug#9087)
3229
5944709e
PE
32302012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3231
3232 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3233
e71f5d99
EZ
32342012-01-11 Eli Zaretskii <eliz@gnu.org>
3235
3236 * xdisp.c (rows_from_pos_range): Handle the case where the
3237 highlight ends on a newline. (Bug#10464)
3238 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3239 he end column for display of highlight that ends on a newline
3240 before a R2L line.
3241
ce316182
GM
32422012-01-11 Glenn Morris <rgm@gnu.org>
3243
3244 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3245 from load-path also when installation-directory is nil. (Bug#10208)
3246
5b43da69
GM
32472012-01-10 Glenn Morris <rgm@gnu.org>
3248
74cc8ff9
GM
3249 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3250
7d8d6e4e
GM
3251 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3252 Update template values to be closer to their typical values these days.
5b43da69 3253
a0db8d43
EZ
32542012-01-09 Eli Zaretskii <eliz@gnu.org>
3255
3256 * xdisp.c (rows_from_pos_range): Accept additional argument
3257 DISP_STRING, and accept any glyph in a row whose object is that
3258 string as eligible for mouse highlight. Fixes mouse highlight of
3259 display strings from overlays. (Bug#10464)
3260
9a0115ab 32612012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3262
b9110d6a 3263 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3264 * fileio.c (auto_saving_dir_umask): New static var.
3265 (Fmake_directory_internal): Use it.
3266 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3267 creating the directory. The old code temporarily assigns
3268 too-generous permissions to the directory.
3269 (do_auto_save_eh): Clear it.
b9110d6a 3270 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3271 that the var is always cleared.
3272
6c1bd3f3
EZ
32732012-01-07 Eli Zaretskii <eliz@gnu.org>
3274
3275 * search.c (scan_buffer): Pass character positions to
3276 know_region_cache, not byte positions. (Bug#6540)
3277
069d2b50
L
32782012-01-07 LynX <_LynX@bk.ru> (tiny change)
3279
3280 * w32.c (sys_rename): Report EXDEV when rename of a directory
3281 fails because the target is on another logical disk. (Bug#10284)
3282
75bf0d33
DB
32832012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3284
3285 * xterm.c (x_embed_request_focus): New function.
3286
3287 * xterm.h: Add prototype.
3288
3289 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3290
1c6e5a32
GM
32912012-01-05 Glenn Morris <rgm@gnu.org>
3292
3293 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3294
651e947e
EZ
32952012-01-01 Eli Zaretskii <eliz@gnu.org>
3296
3297 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3298 Load gnutls_transport_set_lowat only if GnuTLS version is below
3299 2.11.1.
3300 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3301 GnuTLS versions below 2.11.1.
3302
3778cdd8
AL
33032011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3304
3305 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3306 to the doc string advising against its use for altering the way
3307 windows are scrolled.
3308
0e5317f7
KH
33092011-12-28 Kenichi Handa <handa@m17n.org>
3310
3311 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3312 coding-system ASCII compatible only when it does not produce BOM
3313 on encoding (Bug#10383).
3314
93d5ca1f
JD
33152011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3316
3317 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3318 can scroll.
3319 (create_and_show_popup_menu): Always use menu_position_func for
3320 Gtk3 (Bug#10361).
3321
ca22b785
AS
33222011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3323
3324 * callint.c (Fcall_interactively): Don't truncate prompt string.
3325
d048e1e6
EZ
33262011-12-23 Eli Zaretskii <eliz@gnu.org>
3327
3328 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3329 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3330 resumed from there (after widening). (Bug#10360)
d048e1e6 3331
5ccaba1f
JD
33322011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3333
3334 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3335
204ee57f
JD
33362011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3337
b81d40f0
JB
3338 * nsterm.m (x_free_frame_resources):
3339 Release f->output_data.ns->miniimage.
204ee57f
JD
3340 (ns_index_color): Fix indentation. Do not retain
3341 color_table->colors[i].
3342
3343 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3344 before returning.
3345
3346 * nsfns.m (x_set_background_color): Assign return value from
3347 ns_index_color to face-background instead of NSColor*.
3348 (ns_implicitly_set_icon_type): Fix indentation.
3349 Change assignment in for loop to comparison.
3350
3351 * emacs.c (ns_pool): New variable.
3352 (main): Assign ns_pool.
3353 (Fkill_emacs): Call ns_release_autorelease_pool.
3354
3355 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3356 autorelease fdesc, release fdAttrs and tdict.
3357 (ns_get_covering_families): Release charset.
3358 (ns_findfonts): Release NSFontDescriptor created with new.
3359 (ns_uni_to_glyphs): Fix indentation.
3360 (setString): Release attrStr before assigning new value.
3361
c803b2b7
JD
33622011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3363
678f4426
JD
3364 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3365 and NS_IMPL_COCOA.
3366 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3367 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3368
cd394be1 33692011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3370
5fecd5fc
JD
3371 * nsterm.m (ns_term_init): Subscribe for notifications
3372 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3373 to method trackingNotification in EmacsMenu.
3374
3375 * nsmenu.m (trackingMenu): New variable.
3771cb17 3376 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3377 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3378 from Aquamacs (Bug#7030).
678f4426
JD
3379
33802011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3381
c803b2b7
JD
3382 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3383 (symbol_to_nsstring): Fix indentation.
3384 (ns_symbol_to_pb): New function.
cae07000
SM
3385 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3386 (Fns_rotate_cut_buffers_internal): Remove.
3387 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3388 Fns_store_cut_buffer_internal.
3389 (ns_get_foreign_selection, Fx_own_selection_internal)
3390 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3391 (Fns_get_selection_internal, Fns_store_selection_internal):
3392 Use ns_symbol_to_pb and check if return value is nil.
3393 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3394 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3395 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3396 renamed to Sns_store_selection_internal.
3397 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3398 and remove this function.
3399 (ns_handle_selection_clear): Remove, never used.
3400 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3401 here.
3402
e1b01a3a
KB
34032011-12-17 Ken Brown <kbrown@cornell.edu>
3404
3405 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3406 GID is unknown (Bug#10257).
3407
2adb6e85
PE
34082011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3409
3410 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3411 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3412 which caused a build failure on GNU/Linux IA-64. This problem was
3413 introduced by my 2011-10-07 patch.
3414
d1d7b339
JL
34152011-12-15 Juri Linkov <juri@jurta.org>
3416
3417 * image.c (imagemagick_error): New function. (Bug#10112)
3418 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3419 Use `imagemagick_error' where ImageMagick functions return
3420 `MagickFalse'.
3421 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3422 proper order.
3423
100d5755
KH
34242011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3425
3426 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3427 fill background (Bug#8992).
3428
454592a6
MR
34292011-12-13 Martin Rudalics <rudalics@gmx.at>
3430
3431 * window.c (Vwindow_combination_resize)
3432 (Vwindow_combination_limit): Use t instead of non-nil in
3433 doc-strings.
61d4b438
MR
3434 (Vrecenter_redisplay): Add first sentence of doc-string on
3435 separate line.
53524d93 3436 (Frecenter): Fix doc-string typo.
454592a6 3437
3633e3aa
KH
34382011-12-11 Kenichi Handa <handa@m17n.org>
3439
3440 * coding.c (Funencodable_char_position): Pay attention to the
3441 buffer text relocation (Bug#9389).
3442
7b9d523a 34432011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3444
7b9d523a
JD
3445 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3446 gtk_init (Bug#10100).
3447
b73189c6
EZ
34482011-12-10 Eli Zaretskii <eliz@gnu.org>
3449
3450 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3451 IT->string is nil. (Bug#10263)
3452
f7dfe5d6
JD
34532011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3454
83faebb4
JD
3455 * nsterm.h (x_free_frame_resources): Declare.
3456
f7dfe5d6
JD
3457 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3458 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3459
3460 * nsterm.h (ns_get_defaults_value): Declare.
3461
3462 * nsterm.m (ns_default): Call ns_get_defaults_value.
3463
7cd4e72c
EZ
34642011-12-09 Eli Zaretskii <eliz@gnu.org>
3465
3466 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3467 (Bug#10170)
3468
b34d7317
YM
34692011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3470
3471 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3472 that where the value of an _OBJC_* symbol points to is in the .bss
3473 section (Bug#10240).
3474
76470ad1
KH
34752011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3476
3477 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3478 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3479
745fff94
KH
34802011-12-08 Kenichi Handa <handa@m17n.org>
3481
3482 * ftfont.c (get_adstyle_property): Fix previous change
3483 (Bug#10233).
3484
6e44397c
JB
34852011-12-07 Juanma Barranquero <lekktu@gmail.com>
3486
3487 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3488 dirs from the default value of EMACSLOADPATH (bug#10208).
3489
7efa6272
GM
34902011-12-07 Glenn Morris <rgm@gnu.org>
3491
3492 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3493 installation and source directories as well. (Bug#10208)
3494
f6fc4d87
CY
34952011-12-06 Chong Yidong <cyd@gnu.org>
3496
3497 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3498
2bf26180
GM
34992011-12-06 Glenn Morris <rgm@gnu.org>
3500
3501 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3502 as an error, not just -1. (Bug#10217)
3503
3a6ad4f0
CY
35042011-12-05 Chong Yidong <cyd@gnu.org>
3505
3506 * keyboard.c (process_special_events): New function.
3507 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3508
75a3b399
PE
35092011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3510
3511 * coding.c (encode_designation_at_bol): Don't use uninitialized
3512 local variable (Bug#9318).
3513
c3c9e25e
KH
35142011-12-05 Kenichi Handa <handa@m17n.org>
3515
3516 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3517 return Qnil (Bug#8046, Bug#10193).
3518
5eb05ea3
KH
35192011-12-05 Kenichi Handa <handa@m17n.org>
3520
3521 * coding.c (encode_designation_at_bol): New args charbuf_end and
3522 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3523 (coding_set_source): Return how many bytes coding->source was
3524 relocated.
3525 (coding_set_destination): Return how many bytes
3526 coding->destination was relocated.
3527 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3528 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3529
35302011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3531
3532 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3533 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3534 macro (Bug#9318).
3535
35362011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3537
3538 The following changes are to fix Bug#9318.
3539
a79703f5 3540 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3541 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3542 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3543 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3544
7dbda6df
JB
35452011-12-05 Juanma Barranquero <lekktu@gmail.com>
3546
3547 * lisp.h (process_quit_flag): Fix external declaration.
3548
6d5eb5b0
SM
35492011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3550
3551 Don't macro-inline non-performance-critical code.
3552 * eval.c (process_quit_flag): New function.
3553 * lisp.h (QUIT): Use it.
3554
a0c3fad0
JD
35552011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3556
3557 * nsfns.m (get_geometry_from_preferences): New function.
3558 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3559
6c07aac2
AS
35602011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3561
3562 * emacs.c (Qkill_emacs): Define.
3563 (syms_of_emacs): Initialize it.
3564 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3565 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3566 (quit_throw_to_read_char): Add parameter `from_signal'.
3567 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3568 * lisp.h (QUIT): Call Fkill_emacs if requested.
3569
c052ead4
JD
35702011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3571
3572 * widget.c (update_wm_hints): Return if wmshell is null.
3573 (widget_update_wm_size_hints): New function.
3574
3575 * widget.h (widget_update_wm_size_hints): Declare.
3576
3577 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3578 widget_update_wm_size_hints (Bug#10104).
3579
9e49252b
EZ
35802011-12-03 Eli Zaretskii <eliz@gnu.org>
3581
3582 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3583 before a newline, prepare the bidi iterator for consuming the
3584 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3585 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3586
02b16839
JL
35872011-12-02 Juri Linkov <juri@jurta.org>
3588
3589 * search.c (Fword_search_regexp): New Lisp function created from
3590 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3591 (Fword_search_backward, Fword_search_forward)
3592 (Fword_search_backward_lax, Fword_search_forward_lax):
3593 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3594 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3595
0068070e
SM
35962011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3597
3598 * fileio.c (Finsert_file_contents): Move after-change-function call
3599 to before the "handled:" label, since all "goto handled" appear in
3600 cases where the *-change-functions have already been properly called
3601 (bug#10117).
3602
3360a3fc
AS
36032011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3604
3605 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3606 waiting for input. (Bug#10169)
3607
73d6c093
EZ
36082011-11-30 Eli Zaretskii <eliz@gnu.org>
3609
3610 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3611 verifies glyph row's hash code--we have just reallocated the
3612 glyphs, so their contents can be complete garbage. (Bug#10164)
3613
febe6bea
JB
36142011-11-30 Juanma Barranquero <lekktu@gmail.com>
3615
3616 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3617
801a4313
EZ
36182011-11-30 Eli Zaretskii <eliz@gnu.org>
3619
3620 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3621 attributes are tested _before_ calling verify_row_hash, to protect
3622 against GCC re-ordering of the tests. (Bug#10164)
3623
2b56b87e
JD
36242011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3625
3626 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3627
3628 * xterm.c (handle_one_xevent): Only set async_visible and friends
3629 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3630 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3631 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3632
dbf31225
PE
36332011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3634
3635 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3636 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3637 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3638 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3639 All uses changed to use GCPRO1 etc.
3640 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3641 Revert to old implementation (i.e., before 2011-03-11).
3642
1305621b
YM
36432011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3644
3645 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3646 of scroll runs so as to avoid assigning disabled bogus rows and
3647 unnecessary graphics copy operations.
3648
8c9afb46
EZ
36492011-11-27 Eli Zaretskii <eliz@gnu.org>
3650
3651 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3652 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3653 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3654 (malloc, free, realloc, calloc): Redirect to e_* only when
3655 compiling Emacs.
3656
3657 * lisp.h (GCTYPEBITS): Move before first use.
3658 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3659 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3660 this macro definition.
3661
3662 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3663 _MSC_VER.
3664
54e9e3bf
JD
36652011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3666
6d5eb5b0
SM
3667 * gtkutil.c (xg_create_frame_widgets):
3668 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3669 present with Gtk+ 2.0.
3670
83aca1cb
PE
36712011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3672
3673 * fileio.c (Finsert_file_contents): Undo previous change; see
3674 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3675
5b76caa4
PE
36762011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3677
3678 Rename locals to avoid shadowing.
3679 * fileio.c (Finsert_file_contents):
3680 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3681 * process.c (wait_reading_process_output):
3682 Rename inner 'proc' to 'p' to avoid shadowing.
3683 Indent for consistency with usual Emacs style.
3684
8c535114
EZ
36852011-11-25 Eli Zaretskii <eliz@gnu.org>
3686
3687 * xdisp.c (redisplay_window): If cursor row is not fully visible
3688 after recentering, and scroll-conservatively is set to a large
3689 number, scroll window by a few more lines to make the cursor fully
3690 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3691 (start_display): Don't move to the next line if the display should
3692 start at a newline that is part of a display vector or an overlay
3693 string. (Bug#10119)
8c535114 3694
fa4fdb5c
JL
36952011-11-24 Juri Linkov <juri@jurta.org>
3696
3697 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3698 after the `MagickPingImage' call. (Bug#10112)
3699
90ec88df
CY
37002011-11-23 Chong Yidong <cyd@gnu.org>
3701
3702 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3703
56e2e794
MR
37042011-11-23 Martin Rudalics <rudalics@gmx.at>
3705
3706 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3707 making another buffer current. (Bug#10114)
3708
b6e64c41
GM
37092011-11-23 Glenn Morris <rgm@gnu.org>
3710
3711 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3712
6b21de18
CY
37132011-11-23 Chong Yidong <cyd@gnu.org>
3714
3715 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3716 using it (Bug#5984).
3717
b12cd789
EZ
37182011-11-22 Eli Zaretskii <eliz@gnu.org>
3719
3720 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3721 and header-lines, as they don't have one computed for them.
3722 (Bug#10098)
3723
3724 * .gdbinit (prow): Make displayed values more self-explaining.
3725 Add row's hash code.
3726
261b6fd4
LMI
37272011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3728
3729 * process.c (wait_reading_process_output): Fix asynchrounous
3730 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3731 (wait_reading_process_output): Add comment and URL.
261b6fd4 3732
e7cfd277
JD
37332011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3734
3735 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3736
a9b9b7f5
CY
37372011-11-21 Chong Yidong <cyd@gnu.org>
3738
3739 * window.c (Fnext_window, Fprevious_window): Doc fix.
3740
b0d15b4f
SM
37412011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3742
3743 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3744
fe7a3057
JB
37452011-11-20 Juanma Barranquero <lekktu@gmail.com>
3746
3747 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3748
d2999b1a
MR
37492011-11-20 Martin Rudalics <rudalics@gmx.at>
3750
3751 * window.c (Fset_window_combination_limit): Rename argument
3752 STATUS to LIMIT.
3753 (Vwindow_combination_limit): Remove "status" from doc-string.
3754
d5ff9cd0
AS
37552011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3756
3757 * m/ibms390.h: Remove.
3758 * m/ibms390x.h: Don't include "ibms390.h".
3759
a5bb9bd3
SM
37602011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3761
3762 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3763 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3764
cd1181db
JB
37652011-11-20 Juanma Barranquero <lekktu@gmail.com>
3766
3767 * casetab.c (Fset_case_table):
3768 * charset.c (Fcharset_after): Fix typos.
3769
615a3b8d 37702011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3771
17e845af
PE
3772 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3773 Otherwise, valgrind does not work on some platforms.
3774 Problem reported by Andreas Schwab in
6a0bf43d
PE
3775 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3776 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3777 is set, removing the need for VIRT_ADDRESS_VARIES.
3778 (PURE_P): Use a more-efficient implementation that needs just one
3779 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3780 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3781 to 4 (xorl, subq, cmpq, setbe).
3782 * alloc.c (pure): Always extern now, since that's the
3783 VIRT_ADDR_VARIES behavior.
3784 (PURE_POINTER_P): Use a single comparison, not two, for
3785 consistency with the new puresize.h.
3786 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3787 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3788 Remove VIRT_ADDR_VARIES no longer needed.
3789
f8fe6f96
EZ
37902011-11-19 Eli Zaretskii <eliz@gnu.org>
3791
3792 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3793 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3794 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3795 behave as if the cursor position were at the window margin.
3796
3797 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3798 and the cursor position is out of bounds, behave as if the cursor
3799 position were at the window margin. (Bug#10075)
3800
df05a53c
CY
38012011-11-18 Chong Yidong <cyd@gnu.org>
3802
3803 * window.c (Fwindow_combination_limit): Make first argument
3804 non-optional, since it is meaningless for live windows like the
3805 selected window.
61ccba97 3806
2071918e
DA
38072011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3808
3809 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3810
b50a28de
SM
38112011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3812
3813 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3814 (graft_intervals_into_buffer): Simplify.
3815
015137db
EZ
38162011-11-18 Eli Zaretskii <eliz@gnu.org>
3817
3818 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3819 hash values of the two rows.
3820 (copy_row_except_pointers): Preserve the used[] arrays and the
3821 hash values of the two rows. (Bug#10035)
68c95424 3822 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3823
3824 * xdisp.c (row_hash): New function, body extracted from
3825 compute_line_metrics.
3826 (compute_line_metrics): Call row_hash, instead of computing the
3827 hash code inline.
3828
3829 * dispnew.c (verify_row_hash): Call row_hash for computing the
3830 hash code of a row, instead of duplicating code from xdisp.c.
3831
3832 * dispextern.h (row_hash): Add prototype.
3833
a2addb04
TH
38342011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3835
3836 * frame.c (delete_frame): Don't delete the terminal when the last
3837 X frame is closed if emacs is built with GTK toolkit.
3838
df85d315
JB
38392011-11-17 Juanma Barranquero <lekktu@gmail.com>
3840
3841 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3842
a0c2d0ae
MR
38432011-11-17 Martin Rudalics <rudalics@gmx.at>
3844
3845 * window.c (Vwindow_splits): Rename to
3846 Vwindow_combination_resize. Suggested by Juri Linkov.
3847 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3848 of Vwindow_splits.
3849
58179cce
JB
38502011-11-16 Juanma Barranquero <lekktu@gmail.com>
3851
7877f373
JB
3852 * nsfns.m (Fns_font_name):
3853 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3854
b6f67890
MR
38552011-11-16 Martin Rudalics <rudalics@gmx.at>
3856
3857 * window.h (window): Rename slot "nest" to "combination_limit".
3858 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3859 (Fset_window_nest): Rename to Fset_window_combination_limit.
3860 (Vwindow_nest): Rename to Vwindow_combination_limit.
3861 (recombine_windows, make_parent_window, make_window)
3862 (Fsplit_window_internal, saved_window)
3863 (Fset_window_configuration, save_window_save): Rename all
3864 occurrences of window_nest to window_combination_limit.
3865
c7015153
JB
38662011-11-15 Juanma Barranquero <lekktu@gmail.com>
3867
3868 * image.c (imagemagick_load_image): Fix typo.
3869
322ad6ec
EZ
38702011-11-14 Eli Zaretskii <eliz@gnu.org>
3871
3872 * xdisp.c (display_line): Move the call to
3873 highlight_trailing_whitespace before the call to
3874 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3875 faces of all the glyphs to compute ROW's hash value.
3876 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3877
f067b8ec
JB
38782011-11-14 Juanma Barranquero <lekktu@gmail.com>
3879
3880 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3881 just return (bug#10044).
3882
1e5b2111
EZ
38832011-11-12 Eli Zaretskii <eliz@gnu.org>
3884
7ef3cbd5
EZ
3885 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3886 with user-defined heap size. Bump the default size of the temacs
3887 heap to 27MB, to avoid memory warning when running temacs.
3888 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3889
1e5b2111
EZ
3890 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3891 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3892 (verify_row_hash) [XASSERTS]: New function.
3893 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3894 that the hash value of glyph rows is correct.
1e5b2111 3895
89d61221
MR
38962011-11-12 Martin Rudalics <rudalics@gmx.at>
3897
3898 * window.h (window): Remove splits slot.
3899 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3900 (Fdelete_other_windows_internal, make_parent_window)
3901 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3902 (Fset_window_configuration, save_window_save): Don't deal with
3903 split status of windows.
3904 (saved_window): Remove splits slot.
3905 (Vwindow_splits): Rewrite doc-string.
3906
97f18cc8
JD
39072011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3908
3909 * xfns.c (unwind_create_frame):
3910 * nsfns.m (unwind_create_frame):
3911 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3912 Vframe_list (Bug#9999).
3913
22a648b4
DA
39142011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3915
0b381c7e 3916 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3917
659afede
KH
39182011-11-11 Kenichi Handa <handa@m17n.org>
3919
3920 * callproc.c (Fcall_process): Set the member dst_multibyte of
3921 process_coding.
3922
9ac0394b
KH
39232011-11-11 Johan Bockgård <bojohan@gnu.org>
3924
3925 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3926 avoid a crash (bug#9496).
3927
2fbdc249
CY
39282011-11-09 Chong Yidong <cyd@gnu.org>
3929
3930 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3931 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3932
ac6b1f81
PE
39332011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3934
3935 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3936
09db192c
PE
39372011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3938
3939 Avoid some portability problems by eschewing 'extern inline' functions.
3940 The trivial performance wins aren't worth the portability hassles; see
3941 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3942 et seq.
3943 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3944 (window_box_width, window_box_left, window_box_left_offset)
3945 (window_box_right, window_box_right_offset): Undo previous change,
3946 by removing the "extern"s.
3947 * intervals.c (adjust_intervals_for_insertion)
3948 (adjust_intervals_for_deletion): Undo previous change,
3949 making these static again.
3950 (offset_intervals, temp_set_point_both, temp_set_point)
3951 (copy_intervals_to_string): No longer inline.
3952 * xdisp.c (window_text_bottom_y, window_box_width)
3953 (window_box_height, window_box_left_offset)
3954 (window_box_right_offset, window_box_left, window_box_right)
3955 (window_box): No longer inline.
3956
105216ed
CY
39572011-11-08 Chong Yidong <cyd@gnu.org>
3958
3959 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3960 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3961 Signal an error if not a live window.
105216ed
CY
3962 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3963 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3964
ae9e237f
JB
39652011-11-07 Juanma Barranquero <lekktu@gmail.com>
3966
3967 * lisp.h (syms_of_abbrev): Remove declaration.
3968 Reported by CHENG Gao <chenggao@royau.me>.
3969
c7aa8333
EZ
39702011-11-07 Eli Zaretskii <eliz@gnu.org>
3971
3972 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3973 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3974 of temacs in GUI mode.
3975
be7f5545
MR
39762011-11-07 Martin Rudalics <rudalics@gmx.at>
3977
3978 * window.h: Declare delete_all_child_windows instead of
3979 delete_all_subwindows.
3980 * window.c (Fwindow_nest, Fset_window_nest)
3981 (Fset_window_new_total, Fset_window_new_normal)
3982 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3983 (delete_all_subwindows): Rename to delete_all_child_windows.
3984 (Fdelete_other_windows_internal, Fset_window_configuration):
3985 Call delete_all_child_windows instead of delete_all_subwindows.
3986 * frame.c (delete_frame): Call delete_all_child_windows instead
3987 of delete_all_subwindows.
3988
ca78dc43
PE
39892011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3990
3991 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3992 This is also needed for porting to any host where GC_MARK_STACK is
3993 not GC_MAKE_GCPROS_NOOPS.
3994 (which_symbols): Use it.
3995
a0241d01
KH
39962011-11-07 Kenichi Handa <handa@m17n.org>
3997
3998 * coding.c (coding_set_destination): Check coding->src_pos only
3999 when coding->src_object is a buffer (bug#9910).
4000
4001 * process.c (send_process): Set the member src_multibyte of coding
4002 to 0 (bug#9911) when sending a unibyte text.
4003
4004 * callproc.c (Fcall_process): Set the member src_multibyte of
4005 process_coding to 0 (bug#9912).
4006
a64bfdfa 40072011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4008
4009 * xmenu.c (cleanup_widget_value_tree): New function.
4010 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4011 calling free_menubar_widget_value_tree directly (Bug#9830).
4012
cb41b32a
PE
40132011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4014
4015 Fix some portability problems with 'inline'.
4016 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4017 (window_box_width, window_box_left, window_box_left_offset)
4018 (window_box_right, window_box_right_offset): Declare extern.
4019 Otherwise, these inline functions do not conform to C99 and
4020 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4021 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4022 * intervals.c (adjust_intervals_for_insertion)
4023 (adjust_intervals_for_deletion): Now extern, because otherwise the
4024 extern inline functions 'offset_intervals' couldn't refer to it.
4025 (static_offset_intervals): Remove.
4026 (offset_intervals): Rewrite using the old contents of
4027 static_offset_intervals. The old version didn't conform to C99
4028 because an extern inline function contained a reference to an
4029 identifier with static linkage.
4030
b7041366
AS
40312011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4032
4033 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4034 GC.
4035
88a37c4d
EZ
40362011-11-06 Eli Zaretskii <eliz@gnu.org>
4037
4038 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4039 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4040 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4041 return Qleft_to_right.
4042
49745b39
CY
40432011-11-06 Chong Yidong <cyd@gnu.org>
4044
4045 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4046 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4047 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4048 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4049 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4050 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4051 (Fwindow_vscroll): Doc fix.
4052 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4053 argument, since it makes no sense to pass a live window and for
4054 consistency with window-child.
4055
1f05cd82
CS
40562011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4057
4058 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4059 support MSVC.
4060
22610910
JR
40612011-11-05 Jason Rumney <jasonr@gnu.org>
4062
4063 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4064 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4065 fonts (Bug#6029).
4066 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4067 bitwise arithmetic preventing use of unicode-sip and non-truetype
4068 opentype fonts.
4069
a06776b2
EZ
40702011-11-05 Eli Zaretskii <eliz@gnu.org>
4071
3ad924ba
EZ
4072 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4073 "emacs"-only part.
4074
a06776b2
EZ
4075 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4076 initialization code to keep similarity to xfns.c after changes
4077 from 2011-11-05.
4078
c9e7db78
JD
40792011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4080
a97f8f3f
JD
4081 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4082 (unwind_create_frame): New function (Bug#9943).
4083 (Fx_create_frame): Restructure code to be more similar to the one in
4084 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4085 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4086 Move terminal->reference_count++ just before making the frame official
4087 (Bug#9943).
4088
4089 * nsterm.m (x_free_frame_resources): New function.
4090 (x_destroy_window): Move code to x_free_frame_resources.
4091
c9e7db78 4092 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4093 (Fx_create_frame, x_create_tip_frame):
4094 Move terminal->reference_count++ just before making the frame
75f1671a 4095 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4096 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4097
a6fc3b5c
EZ
40982011-11-05 Eli Zaretskii <eliz@gnu.org>
4099
4100 Support MSVC build with newer versions of Visual Studio.
4101 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4102 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4103 nt/gmake.defs.
4104
4105 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4106 which are not supported by MSVC.
4107 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4108 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4109 bitfields.
4110 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4111 types in bitfields.
4112 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4113
4114 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4115
58179cce 41162011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4117
4118 Support MSVC build with newer versions of Visual Studio.
4119 * w32.c: Don't include w32api.h for MSVC.
4120 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4121
4122 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4123 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4124 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4125 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4126 e_* cousins.
4127 (alloca) [_MSC_VER]: Define to _alloca.
4128
4129 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4130
4131 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4132
a58c13ed
EZ
41332011-11-04 Eli Zaretskii <eliz@gnu.org>
4134
4135 * xdisp.c (note_mouse_highlight): If either of
4136 previous/next-single-property-change returns nil, treat that as
4137 the beginning or the end of the buffer. (Bug#9955)
4138
fe0b6370
JD
41392011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4140
a58c13ed 4141 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4142 label is not null (Bug#9951).
4143 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4144 may be NULL.
4145
89bd5ee1
EZ
41462011-11-04 Eli Zaretskii <eliz@gnu.org>
4147
4148 * window.c (Fwindow_body_size): Mention in the doc string that the
4149 return value is in frame's canonical units. (Bug#9949)
4150
84c3edb9
EZ
41512011-11-03 Eli Zaretskii <eliz@gnu.org>
4152
4e2fb5c7
EZ
4153 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4154
84c3edb9 4155 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4156 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4157 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4158
bc17a887
EZ
41592011-11-01 Eli Zaretskii <eliz@gnu.org>
4160
4161 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4162 Don't stop backward scan on the continuation glyph, even though
4163 its CHARPOS is positive.
6d5eb5b0
SM
4164 (mouse_face_from_buffer_pos, note_mouse_highlight):
4165 Rename cover_string to disp_string.
bc17a887 4166
4ee88440
MR
41672011-11-01 Martin Rudalics <rudalics@gmx.at>
4168
4169 * window.c (temp_output_buffer_show): Don't use
4170 Vtemp_buffer_show_specifiers.
4171 (Vtemp_buffer_show_specifiers): Remove unused variable.
4172
c2ff3c02
EZ
41732011-10-30 Eli Zaretskii <eliz@gnu.org>
4174
4175 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4176 past the beginning of the current glyph matrix.
4177
58179cce 41782011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4179
4180 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4181 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4182 HAVE_GTK3 (Bug#9869).
b77a6a7f 4183
3b574623
JD
4184 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4185 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4186
b77a6a7f
JD
4187 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4188
4189 * xterm.c: Declare x_handle_net_wm_state to return int.
4190 (handle_one_xevent): Check if we are iconified but don't have
4191 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4192 (get_current_wm_state): Return non-zero if not hidden,
4193 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4194 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4195 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4196 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4197
196e41e4
PE
41982011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4199
4200 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4201 so that this new function doesn't get optimized away by a
4202 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4203
021f2e1a
AS
42042011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4205
4206 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4207
8b058d44
EZ
42082011-10-29 Eli Zaretskii <eliz@gnu.org>
4209
4210 Fix the `xbytecode' command.
4211 * .gdbinit (xprintbytestr): New command.
b50a28de 4212 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4213 (xbytecode): Print the byte-code string as well.
4214
4452fb80
EZ
42152011-10-29 Kim Storm <storm@cua.dk>
4216
8b058d44
EZ
4217 * alloc.c (which_symbols): New function.
4218
21b72067
AS
42192011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4220
4221 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4222 line. (Bug#9903)
4223
83ed7b5c
GM
42242011-10-29 Glenn Morris <rgm@gnu.org>
4225
4226 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4227 Not clear what it was for, and it causes various bugs. (Bug#9839)
4228
5a7a728b
EZ
42292011-10-28 Eli Zaretskii <eliz@gnu.org>
4230
4231 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4232 possible random value that matches one of those tested as
4233 condition to clear the mouse face.
4234
d3d0842f
CY
42352011-10-28 Chong Yidong <cyd@gnu.org>
4236
4237 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4238
31b39d13
DN
42392011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4240
4241 * window.c (make_window): Initialize phys_cursor_on_p.
4242
9aba6043
SM
42432011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4244
4245 * lisp.h (struct Lisp_Symbol): Update comments.
4246
c20992f4
JB
42472011-10-28 Juanma Barranquero <lekktu@gmail.com>
4248
4249 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4250
db4f02f2
EZ
42512011-10-28 Eli Zaretskii <eliz@gnu.org>
4252
4253 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4254 <oslsachem@gmail.com> for helping to debug this.
4255
4256 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4257 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4258 (g_b_init_get_glyph_outline_w): New static variables.
4259 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4260 (GetGlyphOutlineW_Proc): New typedefs.
4261 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4262 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4263 New functions.
4264 (w32font_open_internal, compute_metrics):
4265 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4266 instead of calling the "wide" APIs directly.
4267
4268 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4269
4270 * w32.h (syms_of_w32font): Add prototype.
4271
87e68db4
JB
42722011-10-27 Juanma Barranquero <lekktu@gmail.com>
4273
4274 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4275 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4276 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4277 (Fmove_to_window_line): Doc fix.
4278
435c1d67
CY
42792011-10-27 Chong Yidong <cyd@gnu.org>
4280
4281 * process.c (make_process): Set gnutls_state to NULL.
4282
4283 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4284 non-NULL, regardless of GNUTLS_INITSTAGE.
4285 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4286 an error. Set process slots as soon as we allocate them.
4287
4288 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4289
9c6c6f49
CY
42902011-10-27 Chong Yidong <cyd@gnu.org>
4291
9aba6043
SM
4292 * gnutls.c (emacs_gnutls_deinit): New function.
4293 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4294 (Fgnutls_deinit, Fgnutls_boot): Use it.
4295
4296 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4297 (deactivate_process): Call emacs_gnutls_deinit.
4298
657d08d3
JB
42992011-10-27 Juanma Barranquero <lekktu@gmail.com>
4300
4301 * image.c (x_create_x_image_and_pixmap):
4302 * w32.c (sys_rename, w32_delayed_load):
4303 * w32font.c (fill_in_logfont):
4304 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4305
5430d399
JB
43062011-10-26 Juanma Barranquero <lekktu@gmail.com>
4307
4308 * w32fns.c (w32_default_color_map): New function,
4309 extracted from Fw32_default_color_map.
a7ef684b 4310 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4311
fe0055fa
PE
43122011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4313
4314 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4315
e6346438
SM
43162011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4317
4318 * keyboard.c (test_undefined): New function (bug#9751).
4319 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4320
e112cc37
ET
43212011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4322
4323 * sysdep.c (init_sys_modes): Fix the check for the controlling
4324 terminal (Bug#6649).
4325
7b5d6677
EZ
43262011-10-20 Eli Zaretskii <eliz@gnu.org>
4327
4328 * dispextern.h (struct bidi_it): New member next_en_type.
4329
4330 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4331 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4332 current character, check also for next_en_type being WEAK_EN.
4333 (bidi_resolve_weak): Don't enter the expensive loop if the current
4334 position is before next_en_pos. Record the bidi type of the first
4335 non-ET, non-BN character we find, in addition to its position.
4336 (bidi_level_of_next_char): Invalidate next_en_type when
4337 next_en_pos is over-stepped.
4338
7da0b018
PE
43392011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4340
4341 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4342 * editfns.c: Rewrite current-time-zone so that it invokes
4343 the equivalent of (format-time-string "%Z") to get the time zone name.
4344 This fixes a bug when the time zone name contains characters that
4345 need converting from the system time locale to Emacs internal format.
4346 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4347 that patch fixed format-time-string to do the conversion, but
4348 I forgot to fix current-time-zone.
4349 (format_time_string): New function, containing most of
4350 what Fformat_time_string used to contain.
4351 (Fformat_time_string): Rewrite in terms of format_time_string.
4352 This doesn't change this function's behavior.
4353 (current-time-zone): Rewrite to use format_time_string.
4354 This fixes the bug reported by Michael Schierl in
4355 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4356 Jason Rumney's 2007-06-07 change worked around this bug, but
4357 didn't fix it.
4358 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4359
8547b010
EZ
43602011-10-19 Eli Zaretskii <eliz@gnu.org>
4361
4362 * xdisp.c (start_display): If the character at POS is displayed
4363 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4364 (try_window_reusing_current_matrix): If a line ends in a display
4365 vector or the next line starts in a display vector, continue
4366 redrawing the window even though the character position of
4367 start_row was reached.
8547b010
EZ
4368 (Bug#9771, part 2)
4369
4e948d15
CY
43702011-10-18 Chong Yidong <cyd@gnu.org>
4371
4372 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4373 with nobreak-char-display too.
4374
4787455f
EZ
43752011-10-18 Eli Zaretskii <eliz@gnu.org>
4376
4377 Fix part 3 of bug#9771.
4378 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4379 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4380 non-neutral characters if the current character is a paragraph
4381 separator (a.k.a. Newline). This avoids running the same
4382 expensive loop twice, once when we consume the preceding newline
4383 and the other time when the line actually needs to be displayed.
4384 Avoid the loop when we see neutrals on the base embedding level
4385 following a character whose directionality is the same as the
4386 paragraph's. This avoids running the expensive loop when a line
4387 ends in a long sequence of neutrals, like control characters.
4388 Add assertion against STRONG_AL type. Slightly rearrange code
4389 that determines the type of a neutral given the first non-neutral
4390 that follows it.
4391 (bidi_level_of_next_char): Set next_en_pos to zero when
4392 invalidating its info.
4393
2c91f553
EZ
43942011-10-17 Eli Zaretskii <eliz@gnu.org>
4395
4396 * xdisp.c (push_display_prop): Determine whether to record string
4397 or buffer position by IT->string, not by IT->method. Allow
4398 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4399 (move_it_vertically_backward): Don't look for character position
4400 immediately after the newline when in a continuation line.
4401 (Bug#9771, part 1)
2c91f553 4402
c7b08b0d
MR
44032011-10-15 Martin Rudalics <rudalics@gmx.at>
4404
4405 * window.c (coordinates_in_window): Rewrite and delabelize
4406 vertical border check. (Bug#5357) (Bug#9618)
4407
6b02f655
SM
44082011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4409
4410 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4411 errors in XSetWindowBorder (bug#9310).
4412
81d40c92
DA
44132011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4414
4415 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4416 avoid crash when xmalloc overrun checking is enabled.
4417
d4172c3b
EZ
44182011-10-13 Eli Zaretskii <eliz@gnu.org>
4419
4420 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4421 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4422 cursor motion with <left> and <right> arrow keys.
4423
4424 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4425 some callers set that themselves.
4426
b00eea75
EZ
44272011-10-12 Eli Zaretskii <eliz@gnu.org>
4428
4429 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4430 display string and the previous row comes from the same string and
4431 is empty. (Bug#9739) (Bug#9738)
4432
8fe012c4
SM
44332011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4434
4435 * doc.c (get_doc_string): Encode file name (bug#9735).
4436
0074aef2
EZ
44372011-10-12 Eli Zaretskii <eliz@gnu.org>
4438
79beb178
EZ
4439 * bidi.c (bidi_level_of_next_char):
4440 * xdisp.c (get_visually_first_element): Remove old incorrect
4441 comments regarding the Unicode Line Separator character.
4442
0074aef2
EZ
4443 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4444
6e4b3fbe
DA
44452011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4446
4447 * alloc.c (Fgc_status): Do not access beyond zombies array
4448 boundary if nzombies > MAX_ZOMBIES.
4449 * alloc.c (dump_zombies): Add missing format specifier.
4450
0324f3af
PE
44512011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4452
b5525cac
PE
4453 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4454 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4455
0324f3af
PE
4456 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4457 Some packages use them to denote characters with modifiers.
4458
e9b5f888
AS
44592011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4460
4461 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4462 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4463 matching a pp-number. Rename parameter var to var1.
4464
127827c0
SM
44652011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4466
4467 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4468
c8fd3bd0
GM
44692011-10-08 Glenn Morris <rgm@gnu.org>
4470
4471 * callint.c (Fcall_interactively): Give a more explicit error for the
4472 'c' case with a non-character input. (Bug#8479)
4473
352ec8ff
EZ
44742011-10-08 Eli Zaretskii <eliz@gnu.org>
4475
03669ccb
EZ
4476 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4477 lines.
7061c986
EZ
4478 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4479 lines that are hscrolled on the left.
03669ccb 4480
352ec8ff
EZ
4481 * dispnew.c (buffer_posn_from_coords): Account for a possible
4482 presence of header-line. (Bug#4426)
4483
a66cfb1c
SM
44842011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4485
6b02f655
SM
4486 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4487 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4488
7c5ee88e
PE
44892011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4490
4491 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4492 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4493 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4494 this makes Emacs dump core during garbage collection on rare
4495 occasions. sizeof is obviously inferior to offsetof here, so
4496 stick with offsetof.
4497 (GC_POINTER_ALIGNMENT): New macro.
4498 (mark_memory): Omit 3rd (offset) arg; caller changed.
4499 Don't assume EMACS_INT alignment is the same as pointer alignment.
4500
df1bbe5b
SM
45012011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4502
4503 * keyboard.c (read_key_sequence_remapped): New var.
4504 (read_key_sequence): Compute remapping in the right buffer.
4505 (command_loop_1): Use read_key_sequence's remapping directly.
4506
51553db6
SM
45072011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4508
32c1fffd
SM
4509 * dired.c (file_name_completion): Don't expand file name.
4510 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4511 before checking file name handler.
4512
51553db6
SM
4513 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4514 they've been requested explicitly (bug#9591).
4515
b6bd1599 45162011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4517
4518 * keymap.c (Fsingle_key_description): Use make_specified_string
4519 instead of build_string to build string from push_key_description.
4520 (Bug#5193)
4521
f701dc2a
PE
45222011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4523
4222c55d
PE
4524 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4525 This fixes a Y2038 bug on 64-bit hosts.
4526 * buffer.c (reset_buffer):
4527 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4528 (Fclear_buffer_auto_save_failure):
4529 Use 0, not -1, to represent an unset failure time, since time_t
4530 might not be signed.
4531
f701dc2a
PE
4532 Remove dependency on glibc malloc internals.
4533 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4534 Move back here from lisp.h, but with their new implementations.
4535 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4536 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4537 * charset.c (charset_table_init): New static var.
4538 (syms_of_charset): Use it instead of xmalloc. This removes a
4539 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4540 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4541 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4542 Move back to alloc.c.
4543 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4544 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4545
9ceebf39
JD
45462011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4547
4548 * nsterm.m (windowDidResize): Call x_set_window_size only when
4549 ns_in_resize is true. Otherwise set pixelwidth/height and
4550 call change_frame_size (Bug#9628).
4551
cb993c58
PE
45522011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4553
3930c88b
PE
4554 Port --enable-checking=all to Fedora 14 x86-64.
4555 * charset.c (syms_of_charset): Also account for glibc malloc's
4556 internal overhead when calculating the initial malloc maximum.
4557
cb993c58
PE
4558 Port --enable-checking=all to Fedora 14 x86.
4559 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4560 Move to lisp.h.
4561 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4562 (overrun_check_realloc, overrun_check_free):
4563 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4564 That way, xmalloc returns a properly-aligned pointer even if
4565 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4566 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4567 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4568 into account when calculating the initial malloc maximum.
4569 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4570 Move here from alloc.c, so that charset.c can use it too.
4571 Properly align; the old code wasn't right for common 32-bit hosts
4572 when configured with --enable-checking=all.
4573 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4574 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4575
31bed486
EZ
45762011-09-29 Eli Zaretskii <eliz@gnu.org>
4577
04c70788 4578 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4579 use EDOM.
4580
fbcaa2f3
EZ
45812011-09-28 Eli Zaretskii <eliz@gnu.org>
4582
4583 * xdisp.c (compute_display_string_end): If there's no display
4584 string at CHARPOS, return -1.
4585
4586 * bidi.c (bidi_fetch_char): When compute_display_string_end
4587 returns a negative value, treat the character as a normal
4588 character not covered by a display string. (Bug#9624)
4589
a239d4e9
JB
45902011-09-28 Juanma Barranquero <lekktu@gmail.com>
4591
4592 * lread.c (Fread_from_string): Fix typo in docstring.
4593
88652fd5
EZ
45942011-09-27 Eli Zaretskii <eliz@gnu.org>
4595
4596 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4597 newline, reseat the iterator instead of bidi-iterating there one
4598 character at a time. (Bug#9610)
32c1fffd
SM
4599 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4600 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4601
ed497dd4
AS
46022011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4603
4604 * lread.c (readevalloop): Use correct code for NBSP.
4605 (read1): Likewise. (Bug#9608)
4606
b2bf61aa
MA
46072011-09-25 Michael Albinus <michael.albinus@gmx.de>
4608
4609 * dbusbind.c (Fdbus_register_signal): When service is not
4610 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4611
32bbb17c
GM
46122011-09-25 Glenn Morris <rgm@gnu.org>
4613
4614 * buffer.c (truncate-lines): Doc fix.
4615
94e0933e
CY
46162011-09-24 Chong Yidong <cyd@stupidchicken.com>
4617
4618 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4619 (Fset_window_next_buffers): Doc fix.
4620
cddde921
GM
46212011-09-24 Glenn Morris <rgm@gnu.org>
4622
4623 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4624
1260aef1
PE
46252011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4626
25b4bfa0
PE
4627 Fix minor problems found by static checking.
4628 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4629 * indent.c (Fvertical_motion): Fix == vs = typo.
4630
e3cbd34b
EZ
46312011-09-24 Eli Zaretskii <eliz@gnu.org>
4632
a66cfb1c
SM
4633 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4634 Default value is now t. Doc fix.
6bf7006f 4635
e3cbd34b 4636 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4637 logic when moving up, not only when moving down. Fix the
e3cbd34b 4638 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4639 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4640
4641 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4642 CHARPOS is covered by a display string which includes newlines.
4643 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4644 is covered by a display string with embedded newlines.
4645
a3de0cbd
MA
46462011-09-24 Michael Albinus <michael.albinus@gmx.de>
4647
4648 * dbusbind.c (Fdbus_register_signal): Add match rule to
4649 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4650 (Fdbus_register_method, Vdbus_registered_objects_table):
4651 Fix docstring.
a3de0cbd 4652
b260039d
JM
46532011-09-24 Jim Meyering <meyering@redhat.com>
4654
32c1fffd 4655 do not ignore write error for any output size
b260039d
JM
4656 The previous change was incomplete.
4657 While it makes emacs --batch detect the vast majority of stdout
4658 write failures, errors were still ignored whenever the output size is
4659 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4660 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4661 && echo FAIL: ignored write error
4662 FAIL: ignored write error
4663 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4664 && echo FAIL: ignored write error
4665 FAIL: ignored write error
4666 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4667
8eca8a7c
AS
46682011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4669
4670 * emacs.c (Fkill_emacs): In noninteractive mode exit
4671 non-successfully if a write error occurred on stdout. (Bug#9574)
4672
3341db62
EZ
46732011-09-21 Eli Zaretskii <eliz@gnu.org>
4674
4675 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4676 the xassert test.
4677
4678 * dispextern.h (struct it): Update the comment documenting what
4679 can it->OBJECT be.
4680
8c203dbf
EZ
46812011-09-20 Eli Zaretskii <eliz@gnu.org>
4682
4683 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4684 a display string, extend search for cursor position to end of row.
4685 (find_row_edges): If the row ends in a newline from a display
4686 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4687 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4688 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4689 non-empty line. Fixes confusing cursor motion with arrow keys at
4690 the beginning of a line that starts with whitespace.
8c203dbf 4691
a4824228
LMI
46922011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4693
4694 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4695 (bug#9493).
4696
33ed493b
CY
46972011-09-18 Chong Yidong <cyd@stupidchicken.com>
4698
4699 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4700 boolean (Bug#9154).
4701
56cd55c8
EZ
47022011-09-18 Eli Zaretskii <eliz@gnu.org>
4703
4704 * xdisp.c (display_line): Record maximum and minimum buffer
4705 positions even if no glyphs were produced (e.g., by a zero-width
4706 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4707 buffer positions that will be removed from the glyph row because
4708 they don't fit.
c02dcedf
EZ
4709 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4710 column is beyond frame width: don't subtract 1 "pixel" when
4711 computing width of the stretch.
3e62b7e0
EZ
4712 (reseat_at_next_visible_line_start): Undo the change made on
4713 2011-09-17 that saved paragraph information and restored it after
4714 the call to `reseat'. (Bug#9545)
56cd55c8 4715
5ed99d36 47162011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4717
4718 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4719 and turn window cursor on if cleared (Bug#9415).
4720
5ed99d36 47212011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4722
4723 * search.c (boyer_moore): Take unibyte characters from pattern
4724 literally. (Bug#9458)
4725
9bade7b2
EZ
47262011-09-18 Eli Zaretskii <eliz@gnu.org>
4727
4728 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4729
e5e9d610
PE
47302011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4731
87e4427a
PE
4732 Fix minor problem found by static checking.
4733 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4734 initialized, to pacify gcc -Wuninitialized.
4735
e5e9d610
PE
4736 * fileio.c: Report proper errno when syscall falls.
4737 (Finsert_file_contents): Save and restore errno,
4738 so that report_file_error outputs the correct diagnostic.
4739 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4740
a1674f0b
EZ
47412011-09-18 Eli Zaretskii <eliz@gnu.org>
4742
4743 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4744
fbfb6dd4
EZ
47452011-09-17 Eli Zaretskii <eliz@gnu.org>
4746
4747 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4748 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4749
bb187662
EZ
47502011-09-17 Eli Zaretskii <eliz@gnu.org>
4751
1137e8b8 4752 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4753 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4754
4755 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4756 (bidi_find_paragraph_start): Search back for paragraph beginning
4757 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4758 (bidi_move_to_visually_next): Only trigger paragraph-related
4759 computations when the last character is a newline or at EOB, not
4760 just any NEUTRAL_B. (Bug#9470)
4761
bb187662
EZ
4762 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4763 truncated lines if point is covered by a display string. (Bug#9524)
4764
2e621251
PE
47652011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4766
4767 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4768 (cons_to_x_long): New function.
4769 (lisp_data_to_selection_data): Use it. Correct the test for
4770 short-versus-long data; it was negated. Break out of vector
4771 loop, for efficiency, when a long datum is discovered.
4772
91a15bc6
SM
47732011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4774
4775 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4776
b41c3a35
EZ
47772011-09-16 Eli Zaretskii <eliz@gnu.org>
4778
4779 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4780 GCC PR/17406) by declaring this function with external scope.
4781
7812ba2d
PE
47822011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4783
4784 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4785 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4786
cf7edc2a
AS
47872011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4788
4789 * editfns.c (Fformat): Correctly handle text properties on "%%".
4790
bd01620e
EZ
47912011-09-15 Eli Zaretskii <eliz@gnu.org>
4792
4793 * xterm.c (x_draw_composite_glyph_string_foreground):
4794 * w32term.c (x_draw_composite_glyph_string_foreground):
4795 * term.c (encode_terminal_code):
4796 * composite.c (composition_update_it, get_composition_id):
4797 * xdisp.c (get_next_display_element)
4798 (fill_composite_glyph_string): Add comments about special meaning
4799 of TAB characters in a composition.
4800
a02719a3
PE
48012011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4802
4803 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4804 This occurs when processing a multibyte format.
4805 Problem reported by Wolfgang Jenker.
a02719a3 4806
72589a3c
JB
48072011-09-15 Johan Bockgård <bojohan@gnu.org>
4808
4809 * xdisp.c (try_cursor_movement): Only check for exact match if
4810 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4811
1c14176c
PE
48122011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4813
4814 Remove unused external symbols.
4815 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4816 * xdisp.c (calc_pixel_width_or_height): Now static.
4817 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4818 * indent.c (check_display_width):
4819 * w32term.c: Fix comment to match code.
4820 * xterm.c, xterm.h (x_catching_errors): Remove.
4821
d2eea5b5
PE
48222011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4823
4824 * xselect.c: Use signed conversions more consistently (Bug#9498).
4825 (selection_data_to_lisp_data): Assume incoming selection data are
4826 signed integers, not unsigned. This is to be consistent with
4827 outgoing selection data, which was modified to use signed integers
4828 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4829 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4830 expects long, not unsigned long.
4831
46888499
EZ
48322011-09-14 Eli Zaretskii <eliz@gnu.org>
4833
4834 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4835 computation of loop end. Reported by Johan Bockgård
4836 <bojohan@gnu.org>.
4837
ef8ef9fb
CY
48382011-09-13 Chong Yidong <cyd@stupidchicken.com>
4839
4840 * frame.c (Fother_visible_frames_p): Function deleted.
4841
fa819fed
EZ
48422011-09-12 Eli Zaretskii <eliz@gnu.org>
4843
4844 * indent.c (compute_motion): Process display vector front to back
4845 rather than the other way around. (Bug#2496)
4846
2ba8e008
SM
48472011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4848
4849 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4850
20f53c69
CY
48512011-09-11 Chong Yidong <cyd@stupidchicken.com>
4852
4853 * minibuf.c (Fread_from_minibuffer): Doc fix.
4854
d562d7a4
EZ
48552011-09-11 Eli Zaretskii <eliz@gnu.org>
4856
4857 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4858 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4859
1c4d7f3d
LMI
48602011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4861
4862 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4863 value for non-existent files.
4864
b885bf36
EZ
48652011-09-11 Eli Zaretskii <eliz@gnu.org>
4866
4867 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4868 set its "size" to -1. This will set the modtime_size field of
4869 the corresponding buffer to -1, which is what
4870 verify-visited-file-modtime expects for files that do not exist.
4871 (Bug#9139)
4872
6612f0bf
PE
48732011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4874
4875 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4876 here ...
4877 * lisp.h: ... from here. push_key_description is no longer
4878 defined in keyboard.c, so its declaration should not be in
4879 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4880 logically belongs with push_key_description.
4881
dfb3f755
PE
48822011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4883
4884 * buffer.h: Include <sys/types.h> instead of <time.h>.
4885 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4886 Problem reported by Herbert J. Skuhra.
4887
3134906c
LMI
48882011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4889
4890 * xml.c (parse_region): Make the parsing work for
4891 non-comment-starting XML files again (bug#9144).
4892
8d903f4e
AS
48932011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4894
4895 * image.c (gif_load): Fix calculation of bottom and right corner.
4896 (Bug#9468)
4897
80ad64f4
EZ
48982011-09-10 Eli Zaretskii <eliz@gnu.org>
4899
4900 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4901 redisplay in small windows.
4902
208a048d
EZ
49032011-09-09 Eli Zaretskii <eliz@gnu.org>
4904
4905 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4906
9b1c252e
MR
49072011-09-08 Martin Rudalics <rudalics@gmx.at>
4908
4909 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4910 Operate on live windows only.
4911
2949f33b
JB
49122011-09-08 Juanma Barranquero <lekktu@gmail.com>
4913
4914 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4915
e08dcafd
EZ
49162011-09-07 Eli Zaretskii <eliz@gnu.org>
4917
4918 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4919 only under bidi iteration.
4920
115b96bd
JD
49212011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4922
4923 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4924
c8199d0f
PE
49252011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4926
4927 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4928 Without this fix, the command to link temacs failed due to an
4929 undefined symbol __builtin_isnan. This is because
4930 /usr/include/iso/math_c99.h #defines isnan(x) to
4931 __builtin_isnan(x), but the bundled gcc, which identifies itself
4932 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4933 a __builtin_isnan.
4934 * floatfns.c (isnan): #undef, and then #define to a clone of
4935 what's in data.c.
4936 (Fisnan): Always define, since it's always available now.
4937 (syms_of_floatfns): Always define isnan at the Lisp level.
4938
e39b275c 49392011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4940
4941 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4942
b2db44d9 49432011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4944
f4af5137 4945 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4946 The previous code assumed that file offsets (off_t values) fit in
4947 EMACS_INT variables, which is not true on typical 32-bit hosts.
4948 The code messed up by falsely reporting buffer overflow in cases
4949 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4950 when "big" contains more than 2**29 bytes, even though this
4951 inserts just one byte and does not overflow the buffer.
4952 (Finsert_file_contents): Store file offsets as off_t
4953 values, not as EMACS_INT values. Check for overflow when
4954 converting between EMACS_INT and off_t. When checking for
4955 buffer overflow or for overlap, take the offsets into account.
4956 Don't use EMACS_INT for small values where int suffices.
4957 When checking for overlap, fix a typo: ZV was used where
4958 ZV_BYTE was intended.
4959 (Fwrite_region): Don't assume off_t fits into 'long'.
4960 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4961
ecfc0a49
MA
49622011-09-05 Michael Albinus <michael.albinus@gmx.de>
4963
4964 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4965
6511acf2 49662011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4967
0999621a 4968 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4969
4970 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4971 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4972 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4973 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4974 (modify_event_symbol): Do not assume that the length of
4975 name_alist_or_stem is safe to alloca and fits in int.
4976 (Fexecute_extended_command): Likewise for function name and binding.
4977 (Frecursion_depth): Wrap around reliably on integer overflow.
4978 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4979 since some callers pass EMACS_INT values.
4980 (Fsingle_key_description): Don't crash if symbol name contains more
4981 than MAX_ALLOCA bytes.
4982 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4983 (get_minibuffer): Arg is now EMACS_INT, not int.
4984 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4985 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4986 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4987
2be7d702
PE
4988 * dbusbind.c (signature_cat): New function.
4989 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4990 Do not overrun buffer; instead, report string overflow.
4991
9d1df220
PE
4992 * dispnew.c (add_window_display_history): Don't overrun buffer.
4993 Truncate instead; this is OK since it's just a log.
4994
33ef5c64
PE
4995 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4996 even if the time zone offset is outlandishly large.
4997 Don't mishandle offset == INT_MIN.
4998
66c6fdd5
PE
4999 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5000 when creating daemon; the previous buffer-overflow check was incorrect.
5001
d749b01b
PE
5002 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5003 which has the guts of the old verror function.
5004
b5cd1905
PE
5005 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5006 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5007
6e1a67fb
PE
5008 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5009 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5010 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5011 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5012 length of string rather than counting it via multiple sprintfs;
5013 that's simpler and more reliable.
c21721cc
PE
5014 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5015 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5016 sprintf, in case result does not fit in int.
5017
c57b67fc
PE
5018 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5019 (fontset_from_font): Print it.
5020
8a401434
PE
5021 * frame.c (tty_frame_count): Now printmax_t, not int.
5022 (make_terminal_frame, set_term_frame_name): Print it.
5023 (x_report_frame_params): In X, window IDs are unsigned long,
5024 not signed long, so print them as unsigned.
5025 (validate_x_resource_name): Check for implausibly long names,
5026 and don't assume name length fits in 'int'.
5027 (x_get_resource_string): Don't blindly alloca invocation name;
5028 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5029 not fit in int.
5030
6e1a67fb
PE
5031 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5032 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5033 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5034
0df02bf3
PE
5035 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5036 Use esprintf, not sprintf, in case result does not fit in int.
5037
48e30793
PE
5038 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5039 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5040 it as a large positive number.
5041 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5042 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5043
a66ff6d8
PE
5044 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5045 in case result does not fit in int.
5046
aca216ff
PE
5047 * print.c (float_to_string): Detect width overflow more reliably.
5048 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5049 buffer overrun. Don't assume list length fits in 'int'. Treat
5050 print length of 0 as 0, not as infinity; to be consistent with other
5051 uses of print length in this function. Don't overflow print length
5052 index. Don't assume hash table size fits in 'long', or that
5053 vectorlike size fits in 'unsigned long'.
5054
31c286f7
PE
5055 * process.c (make_process): Use printmax_t, not int, to format
5056 process-name gensyms.
5057
55e5faa1
PE
5058 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5059
80f2e268
PE
5060 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5061 to avoid potential buffer overrun.
5062
670741ab
PE
5063 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5064 if X resource line is longer than 512 bytes.
5065
b7163a50
PE
5066 * xfns.c (x_window): Make sprintf buffer a bit bigger
5067 to avoid potential buffer overrun.
5068
ae58ff1f
PE
5069 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5070
c43c8a6a
PE
5071 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5072
3f8236f4
PE
50732011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5074
53e9fe90 5075 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5076 Without these, Emacs silently mishandles large integers sometimes.
5077 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5078 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5079
6511acf2
PE
5080 * xdisp.c (try_window_id): Check Emacs fixnum range before
5081 converting to 'int'.
806add1d 5082
6511acf2 5083 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5084 Check that an Emacs fixnum is in range before assigning it to 'int'.
5085 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5086 values converted from Emacs fixnums.
5087 (Frecenter): Don't wrap around a line count if it is out of 'int'
5088 range; instead, treat it as an extreme value.
5089 (Fset_window_configuration, compare_window_configurations):
5090 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5091
6511acf2
PE
5092 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5093 that can exceed INT_MAX. Check that EMACS_INT value is in range
5094 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5095 (match_limit): Don't assume that a fixnum can fit in 'int'.
5096
6511acf2 5097 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5098 exceed INT_MAX.
5099
6511acf2 5100 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5101 (Fvertical_motion): Don't wrap around LINES values that don't fit
5102 in 'int'. Instead, treat them as extreme values. This is good
5103 enough for windows, which can't have more than INT_MAX lines anyway.
5104
fcb901a7
LMI
51052011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5106
0f2f6b6d
LMI
5107 * Require libxml/parser.h to avoid compilation warning.
5108
fcb901a7
LMI
5109 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5110
5111 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5112 since this reportedly can destroy thread storage.
5113
6e20a0d4
CY
51142011-08-30 Chong Yidong <cyd@stupidchicken.com>
5115
5116 * syntax.c (find_defun_start): Update all cache variables if
5117 exiting early (Bug#9401).
5118
148ae00e
EZ
51192011-08-30 Eli Zaretskii <eliz@gnu.org>
5120
f6cfbd8f
EZ
5121 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5122
148ae00e
EZ
5123 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5124 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5125 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5126
5127 * term.c (tty_append_glyph): New function.
5128 (produce_stretch_glyph): Static function and its prototype deleted.
5129
a66cfb1c
SM
5130 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5131 Add prototypes.
148ae00e 5132
c4a07a4c
PE
51332011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5134
5135 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5136 when checking :margin (Bug#9390).
5137 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5138 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5139 so that the name doesn't mislead. All uses changed.
5140
6bc8cd65
JB
51412011-08-28 Johan Bockgård <bojohan@gnu.org>
5142
5143 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5144 set_tty_hooks.
5145
dca4927e
EZ
51462011-08-27 Eli Zaretskii <eliz@gnu.org>
5147
5148 * xdisp.c (move_it_to): Don't bail out early when reaching
5149 position beyond to_charpos, if we are scanning backwards.
5150 (move_it_vertically_backward): When DY == 0, make sure we get to
5151 the first character in the line after the newline.
5152
f2cad773
PE
51532011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5154
5155 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5156 (ccl_driver): Do not generate an out-of-range pointer.
5157 (Fccl_execute_on_string): Remove unnecessary check for
5158 integer overflow, noted by Stefan Monnier in
5159 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5160 Remove a FIXME that didn't need fixing.
5161 Simplify the newly-introduced buffer reallocation code.
5162
0cae2cdb
JB
51632011-08-27 Juanma Barranquero <lekktu@gmail.com>
5164
5165 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5166
5fc295a4 51672011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5168
70c60eb2 5169 Integer and memory overflow issues (Bug#9196).
726e0ab1 5170
d31850da
PE
5171 * doc.c (get_doc_string): Rework so that
5172 get_doc_string_buffer_size is the actual buffer size, rather than
5173 being 1 less than the actual buffer size; this makes xpalloc more
5174 convenient.
5175
a69fbedb
PE
5176 * image.c (x_allocate_bitmap_record, cache_image):
5177 * xselect.c (Fx_register_dnd_atom):
5178 Simplify previous changes by using xpalloc.
5179
fe5c5d37
PE
5180 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5181 since either will do and ptrdiff_t is convenient with xpalloc.
5182
0065d054
PE
5183 * charset.c (charset_table_size)
5184 (struct charset_sort_data.priority): Now ptrdiff_t.
5185 (charset_compare): Don't overflow if priorities differ greatly.
5186 (Fsort_charsets): Don't assume list length fits in int.
5187 Check for size-calculation overflow when allocating sort data.
5188 (syms_of_charset): Allocate an initial charset table that is
5189 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5190
5191 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5192
5193 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5194 The actual value is always <= INT_MAX, and leaving it unsigned made
5195 overflow checking harder.
5196
5197 * dispextern.h (struct glyph_matrix.rows_allocated)
5198 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5199 with xpalloc. The values are still always <= INT_MAX.
5200
5201 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5202
5203 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5204 (SAFE_NALLOCA): New macro.
5205
5206 * region-cache.c (struct boundary.pos, find_cache_boundary)
5207 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5208 (set_cache_region, invalidate_region_cache)
5209 (revalidate_region_cache, know_region_cache, region_cache_forward)
5210 (region_cache_backward, pp_cache):
5211 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5212 so that ptrdiff_t * can be passed to xpalloc.
5213 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5214 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5215 (pp_cache): Don't assume cache_len fits in int.
5216 * region-cache.h: Adjust extern decls to match.
5217
5218 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5219 EMACS_INT, since either will do, for xpalloc.
5220
5221 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5222 (xnmalloc, xnrealloc, xpalloc): New functions.
5223
726e0ab1
PE
5224 * bidi.c (bidi_shelve_header_size): New constant.
5225 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5226 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5227
51f30bc5 5228 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5229 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5230 (overlay_strings):
5231 Don't update size of array until after memory allocation succeeds,
5232 because xmalloc/xrealloc may not return.
0065d054
PE
5233 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5234 now that we have proper integer overflow checking.
5235 (record_overlay_string, overlay_strings): Catch overflows when
5236 calculating size of overlay_str_buf.
726e0ab1 5237
0065d054
PE
5238 * callproc.c (Fcall_process): Check for size overflow when
5239 calculating size of args2.
5240 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5241 Normally we prefer signed values, but sticking with ptrdiff_t would
5242 require adding more-complicated checks.
726e0ab1
PE
5243
5244 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5245 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5246 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5247 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5248
5249 * character.c (Fstring): Check for size-calculation overflow.
5250
5251 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5252 unnecessary integer overflow. Check for size overflow.
5253 (encode_coding_object): Don't update size until xmalloc succeeds.
5254
5255 * composite.c (get_composition_id): Check for overflow in glyph
5256 length calculations.
5257
5258 Integer and memory overflow fixes for display code.
5259 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5260 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5261 (scrolling_window): Check for overflow in size calculations.
5262 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5263 Don't assume glyph table len fits in int.
5264 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5265 (row_table_size): Now ptrdiff_t, not int.
5266 (scrolling_window): Avoid overflow in size calculations.
5267 Don't update size until allocation succeeds.
5268 * fns.c (concat): Check for overflow in size calculations.
5269 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5270 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5271 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5272
5273 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5274 (get_doc_string): Check for size calculation overflow.
5275 Don't update size until allocation succeeds.
5276 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5277 EMACS_INT, where ptrdiff_t will do.
5278 (Fsubstitute_command_keys): Check for string overflow.
5279
5280 * editfns.c (set_time_zone_rule): Don't assume environment length
5281 fits in int.
5282 (message_length): Now ptrdiff_t, not int.
5283 (Fmessage_box): Don't update size until allocation succeeds.
5284 Don't assume message length fits in int.
5285 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5286
0065d054
PE
5287 * emacs.c (main): Do not reallocate argv, since there is a null at
5288 the end that can be overwritten, and this way there's no need to
5289 worry about size-calculation overflow.
5290 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5291
5292 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5293 alloc succeeds.
5294 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5295
5296 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5297 (x_set_scroll_bar_width, x_figure_window_size):
5298 Check for integer overflow.
5299 (x_set_alpha): Do not assume XINT fits in int.
5300
5301 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5302 This is for the members text_lines, text_cols, total_lines, total_cols,
5303 where the system imposes an 'int' limit.
5304
5305 * fringe.c (Fdefine_fringe_bitmap):
5306 Don't update size until alloc works.
5307
5308 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5309 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5310
5311 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5312 Check for size-calculation overflow.
5313 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5314 do, as we prefer signed integers.
5315 (id_to_widget.max_size, id_to_widget.used)
5316 (xg_store_widget_in_map, xg_remove_widget_from_map)
5317 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5318 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5319 Use and return ptrdiff_t, not int.
5320 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5321 * gtkutil.h: Change prototypes to match the above.
5322
5323 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5324 are duplicate now that they've been promoted to lisp.h.
5325 (x_allocate_bitmap_record, x_alloc_image_color)
5326 (make_image_cache, cache_image, xpm_load):
5327 Don't update size until alloc is done.
5328 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5329 (x_detect_edges):
3256efce 5330 Check for size calculation overflow.
726e0ab1
PE
5331 (ct_colors_allocated_max): New constant.
5332 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5333 overflow.
3256efce 5334
726e0ab1
PE
5335 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5336 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5337 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5338 Use ptrdiff_t, not int, to count maps.
5339 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5340 calculations. Don't update size until allocation succeeds.
5341 Redo calculations to avoid overflow.
726e0ab1
PE
5342 * keyboard.h: Change prototypes to match the above.
5343
5344 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5345 to count maps.
5346 (current_minor_maps): Check for size calculation overflow.
5347 * keymap.h: Change prototypes to match the above.
5348
5349 * lread.c (read1, init_obarray): Don't update size until alloc done.
5350
5351 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5352 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5353
726e0ab1
PE
5354 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5355 Now ptrdiff_t, not int.
5356 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5357 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5358
5359 * process.c (Fnetwork_interface_list): Check for overflow
5360 in size calculation.
5361
5362 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5363
5364 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5365 overflow. Don't bother calling xmalloc when xrealloc will do.
5366
5367 * search.c (Freplace_match): Check for size calculation overflow.
5368 (Fset_match_data): Don't assume list lengths fit in 'int'.
5369
5370 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5371 for command line length. Do not attempt to address one before the
5372 beginning of an array, as that's not portable.
5373
5374 * term.c (max_frame_lines): Remove; unused.
5375 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5376 not int.
5377 (encode_terminal_code, calculate_costs): Check for size
5378 calculation overflow.
5379 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5380 table lengths and related sizes. Don't update size until alloc
5381 done. Redo calculations to avoid overflow.
5382 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5383
5384 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5385 subtracting pointers.
5386 (gobble_line): Check for overflow more carefully. Don't update size
5387 until alloc done.
5388
5389 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5390 Don't update size until alloc done.
5391 Redo size calculations to avoid overflow.
5392 Check for size calculation overflow.
0065d054 5393 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5394
5395 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5396 Use ptrdiff_t, not int, for sizes.
5397 (store_mode_line_noprop_char): Don't update size until alloc done.
5398
0065d054
PE
5399 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5400 Use ptrdiff_t, not int, for sizes.
5401 (Finternal_make_lisp_face, cache_face):
5402 Check for size calculation overflow.
5403 (cache_face): Treat size calculation overflows as if they were
5404 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5405
5406 * xfns.c (x_encode_text, x_set_name_internal)
5407 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5408 sizes, since they can exceed INT_MAX in size. Check for size
5409 calculation overflow.
5410
0065d054
PE
5411 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5412 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5413 Don't update size until alloc done.
5414
0065d054 5415 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5416 as sprintf is limited to int lengths.
1d526e2f 5417
252c5ee1
PE
5418 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5419 (X_LONG_MIN): New macros.
864d7ce7
PE
5420 Use them to make the following changes clearer.
5421 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5422 This change doesn't affect the value now, but it may help remind
5423 future maintainers not to raise the value too much later.
5424 (SELECTION_QUANTUM): Remove, replacing with ...
5425 (selection_quantum): ... new function, which avoids overflow.
5426 All uses changed.
5427 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5428 assumption that selection length fits in 'int'.
5429 (x_reply_selection_request, x_handle_selection_request)
5430 (x_get_window_property, receive_incremental_selection)
5431 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5432 (lisp_data_to_selection_data, clean_local_selection_data):
5433 Use ptrdiff_t, not int, to record length of selection.
5434 (x_reply_selection_request, x_get_window_property)
5435 (receive_incremental_selection, x_property_data_to_lisp):
5436 Redo calculations to avoid overflow.
5437 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5438 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5439 something.
5440 (x_get_window_property, receive_incremental_selection)
5441 (lisp_data_to_selection_data, x_property_data_to_lisp):
5442 Check for size-calculation overflow.
5443 (x_get_window_property, receive_incremental_selection)
5444 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5445 Don't store size until memory allocation succeeds.
5446 (x_get_window_property): Plug memory leak on memory exhaustion.
5447 Don't double-block input; malloc is safe here. Don't assume 2**34
5448 - 4 fits in unsigned long. Add an xassert to check
5449 XGetWindowProperty overflow. Be more careful about overflow
5450 calculations, and distinguish size from memory overflow better.
5451 (receive_incremental_selection): When tracing, don't assume
5452 unsigned int is less than INT_MAX.
5453 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5454 harmful) conversions of unsigned short to int.
5455 (lisp_data_to_selection_data): Don't assume that integers
5456 in the range -65535 through -1 fit in an X unsigned short.
5457 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5458 result parameters unless successful. Rely on cons_to_unsigned
5459 to report problems with elements; the old code wasn't right anyway.
5460 (x_check_property_data): Check for int overflow; we cannot use
5461 a wider type due to X limits.
5462 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5463
726e0ab1 5464 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5465
0065d054
PE
5466 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5467 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5468 (x_color_cells): Don't store size until memory allocation succeeds.
5469 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5470 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5471 (x_term_init): Don't assume length fits in int (sprintf is limited
5472 to int size).
bc18e09d 5473
ebfa62c0
PE
5474 Use ptrdiff_t for composition IDs.
5475 * character.c (lisp_string_width):
5476 * composite.c (composition_table_size, n_compositions)
5477 (get_composition_id, composition_gstring_from_id):
5478 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5479 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5480 * window.c (Frecenter):
5481 Use ptrdiff_t, not int, for composition IDs.
5482 * composite.c (get_composition_id): Check for integer overflow.
5483 * composite.h: Adjust prototypes to match the above changes.
5484
d3411f89
PE
5485 Use ptrdiff_t for hash table indexes.
5486 * category.c (hash_get_category_set):
5487 * ccl.c (ccl_driver):
5488 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5489 * coding.c (coding_system_charset_list, detect_coding_system):
5490 * coding.h (struct coding_system.id):
5491 * composite.c (get_composition_id, gstring_lookup_cache):
5492 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5493 * image.c (xpm_get_color_table_h):
5494 * lisp.h (hash_lookup, hash_put):
5495 * minibuf.c (Ftest_completion):
5496 Use ptrdiff_t for hash table indexes, not int (which is too
5497 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5498 32-bit --with-wide-int hosts).
5499
e097a6fa
PE
5500 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5501 Add a FIXME comment about memory leaks.
5502 (syms_of_charset): Don't assume xmalloc returns.
5503
5637687f
PE
5504 Don't assume that stated character widths fit in int.
5505 * character.c (Fchar_width, c_string_width, lisp_string_width):
5506 * character.h (CHAR_WIDTH):
5507 * indent.c (MULTIBYTE_BYTES_WIDTH):
5508 Use sanitize_char_width to avoid undefined and/or bad behavior
5509 with outlandish widths.
a66cfb1c 5510 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5511 now that we have two such functions. All uses changed.
5512 (sanitize_char_width): New inline function.
5513
a2271ba2
PE
5514 Don't assume that tab-width fits in int.
5515 * character.h (sanitize_width): New inline function.
5516 (SANE_TAB_WIDTH): New macro.
5517 (ASCII_CHAR_WIDTH): Use it.
5518 * indent.c (sane_tab_width): Remove. All uses replaced by
5519 SANE_TAB_WIDTH (current_buffer).
5520 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5521
18c52557
PE
5522 * fileio.c: Integer overflow issues with file modes.
5523 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5524
caeeedc1
PE
5525 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5526 Remove unreachable code.
5527 (read_hex, load_charset_map_from_file): Check for integer overflow.
5528
6df6ae42 5529 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5530 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5531 (x_send_scroll_bar_event): Likewise. Check that the size does not
5532 exceed limits imposed by XClientMessageEvent, as well as the usual
5533 ptrdiff_t and size_t limits.
5534
b13995db
PE
5535 * keyboard.c: Overflow, signedness and related fixes.
5536 (make_lispy_movement): Use same integer type in forward decl
5537 that is used in the definition.
5538 (read_key_sequence, keyremap_step):
5539 Change bufsize argument back to int, undoing my 2011-03-30 change.
5540 We prefer signed types, and int is wide enough here.
5541 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5542 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5543 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5544 length, not size_t. Use ptrdiff_t for index, not int.
5545 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5546 possibility of integer overflow.
5547
13464394
PE
5548 Overflow, signedness and related fixes for images.
5549
5550 * dispextern.h (struct it.stack[0].u.image.image_id)
5551 (struct_it.image_id, struct image.id, struct image_cache.size)
5552 (struct image_cache.used, struct image_cache.ref_count):
5553 * gtkutil.c (update_frame_tool_bar):
5554 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5555 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5556 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5557 * nsmenu.m (update_frame_tool_bar):
5558 * xdisp.c (calc_pixel_width_or_height):
5559 * xfns.c (image_cache_refcount):
5560 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5561 on typical 64-bit hosts.
5562
5563 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5564 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5565 Omit unnecessary casts to int.
5566 (parse_image_spec): Check that integers fall into 'int' range
5567 when the callers expect that.
5568 (image_ascent): Redo ascent calculation to avoid int overflow.
5569 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5570 (lookup_image): Remove unnecessary tests.
5571 (xbm_image_p): Locals are now of int, not EMACS_INT,
5572 since parse_image_check makes sure they fit into int.
5573 (png_load, gif_load, svg_load_image):
5574 Prefer int to unsigned where either will do.
5575 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5576 old tiff_error_handler and tiff_warning_handler.
5577 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5578 stack buffer overflows. It uses only the features of vsnprintf
5579 that are common to both POSIX and native Microsoft.
5580 (tiff_error_handler, tiff_warning_handler): Use it.
5581 (tiff_load, gif_load, imagemagick_load_image):
5582 Don't assume :index value fits in 'int'.
5583 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5584 (imagemagick_load_image): Check that crop parameters fit into
5585 the integer types that MagickCropImage accepts. Don't assume
5586 Vimagemagick_render_type has a nonnegative value. Don't assume
5587 size_t fits in 'long'.
5588 (gs_load): Use printmax_t to print the widest integers possible.
5589 Check for integer overflow when computing image height and width.
5590
c11821d4
EZ
55912011-08-26 Eli Zaretskii <eliz@gnu.org>
5592
5593 * xdisp.c (redisplay_window): Don't force window start if point
5594 will be invisible in the resulting window. (Bug#9324)
5595
0c95fcf7
EZ
55962011-08-25 Eli Zaretskii <eliz@gnu.org>
5597
5598 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5599 the display spec is of the form `(space ...)'.
5600 (handle_display_spec): Return the value returned by
5601 handle_single_display_spec, not just 1 or zero.
5602 (handle_single_display_spec): If the display spec is of the form
5603 `(space ...)', and specifies display in the text area, return 2
5604 rather than 1.
fee65a97 5605 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5606 accurately, and prefer exact match for point under bidi.
5607 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5608
5609 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5610 into disp_prop; all users changed.
5611
5612 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5613 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5614 for the text covered by the display property.
5615
e4ed06f1
CY
56162011-08-25 Chong Yidong <cyd@stupidchicken.com>
5617
5618 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5619 Change return value to nil.
5620 (Frecord_buffer): Delete unused function.
5621
f67cdd7f
EZ
56222011-08-24 Eli Zaretskii <eliz@gnu.org>
5623
5980d4c6
EZ
5624 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5625 buffers, return left-to-right.
8610fe8b
EZ
5626 (set_cursor_from_row): Consider candidate row a win if its glyph
5627 represents a newline and point is on that newline. Fixes cursor
5628 positioning on the newline at EOL of R2L text within L2R
5629 paragraph, and vice versa.
5630 (try_cursor_movement): Check continued rows, in addition to
5631 continuation rows. Fixes unwarranted scroll when point enters a
5632 continued line of R2L text within an L2R paragraph, or vice versa.
5633 (cursor_row_p): Consider the case of point being equal to
5634 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5635 from the end of a short line to the beginning of a continued line
5636 of R2L text within L2R paragraph.
5637 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5638 composed characters.
5980d4c6 5639
f67cdd7f
EZ
5640 * bidi.c (bidi_check_type): Use xassert.
5641 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5642 members.
5643
bca633fb
EZ
56442011-08-23 Eli Zaretskii <eliz@gnu.org>
5645
5646 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5647 a character.
5648
4a5885a7
CY
56492011-08-23 Chong Yidong <cyd@stupidchicken.com>
5650
5651 * nsfont.m (ns_otf_to_script): Fix typo.
5652
0902a04e
KH
56532011-08-22 Kenichi Handa <handa@m17n.org>
5654
5655 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5656 extra slot even if the purpose is char-code-property-table.
5657
1a2e6670
EZ
56582011-08-23 Eli Zaretskii <eliz@gnu.org>
5659
8ddde651
EZ
5660 * xdisp.c (redisplay_window): When computing centering_position,
5661 account for the height of the header line. (Bug#8874)
5662
425cc014
EZ
5663 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5664 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5665 candidate is selected by the mouse, and that candidate has a
5666 composed character under the mouse.
5667
1a2e6670
EZ
5668 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5669 coordinates reported by pos-visible-in-window-p for a composed
5670 character in column zero.
5671
8b76d6f8
SM
56722011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5673
5674 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5675
dac347dd
EZ
56762011-08-22 Eli Zaretskii <eliz@gnu.org>
5677
5678 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5679 consider it a hit if to_charpos is anywhere in the range of the
5680 composed buffer positions.
5681
e013fb34
CY
56822011-08-22 Chong Yidong <cyd@stupidchicken.com>
5683
5684 * image.c (gif_load): Don't assume that each subimage has the same
5685 dimensions as the base image. Handle disposal method that is
5686 "undefined" by the gif spec (Bug#9335).
5687
bd1ba3e8
CY
56882011-08-20 Chong Yidong <cyd@stupidchicken.com>
5689
5690 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5691 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5692
54a1215b
EZ
56932011-08-19 Eli Zaretskii <eliz@gnu.org>
5694
823564e5
EZ
5695 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5696 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5697 from an Org mode buffer to a Speedbar frame.
5698
54a1215b
EZ
5699 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5700 a composition, take its buffer position from IT->cmp_it.charpos.
5701 Fixes cursor positioning at the beginning of a line that begins
5702 with a composed character.
5703
9778ebcc
EZ
57042011-08-18 Eli Zaretskii <eliz@gnu.org>
5705
0be6ee06
EZ
5706 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5707 character bidirectional type, use STRONG_L instead. Fixes crashes
5708 in a buffer produced by `describe-categories'.
5709
9778ebcc
EZ
5710 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5711 members before the level stack, so they would be saved and
5712 restored when copying iterator state. Fixes incorrect reordering
5713 around TABs covered by display properties.
5714
156bffbe
AS
57152011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5716
6b02f655 5717 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5718
72ad093b
CY
57192011-08-17 Chong Yidong <cyd@stupidchicken.com>
5720
5721 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5722 (internal_condition_case_2, internal_condition_case_n):
5723 Remove unnecessary aborts (Bug#9081).
72ad093b 5724
35774242
EZ
57252011-08-17 Eli Zaretskii <eliz@gnu.org>
5726
5727 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5728 has no `load' handler, try opening the file locally. (Bug#9311)
5729
db76dd85
KB
57302011-08-16 Ken Brown <kbrown@cornell.edu>
5731
5732 * gmalloc.c: Expand comment.
5733
b215eee5
EZ
57342011-08-16 Eli Zaretskii <eliz@gnu.org>
5735
5736 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5737 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5738
a4579d33
KB
57392011-08-16 Ken Brown <kbrown@cornell.edu>
5740
5741 Fix memory allocation problems in Cygwin build (Bug#9273).
5742
5743 * unexcw.c ( __malloc_initialized): Declare external variable.
5744 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5745
8b76d6f8
SM
5746 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5747 New variables.
a4579d33
KB
5748 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5749 dumped emacs.
5750 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5751 in the static heap.
5752 [CYGWIN] (special_realloc): New function.
5753 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5754 requests to realloc storage in the static heap.
5755
3ebec551
PE
57562011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5757
5758 * bidi.c (bidi_initialize): Remove unused local.
5759
9fd8be00
EZ
57602011-08-15 Eli Zaretskii <eliz@gnu.org>
5761
6b02f655
SM
5762 * bidimirror.h:
5763 * biditype.h: Remove file.
5764 * makefile.w32-in ($(BLD)/bidi.$(O)):
5765 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5766
5767 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5768
5769 * chartab.c: Improve commentary for the uniprop_table API.
5770
32413314
EZ
5771 * bidi.c (bidi_paragraph_init): Support zero value of
5772 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5773 (bidi_initialize): Use uniprop_table instead of including
5774 biditype.h and bidimirror.h.
32413314 5775
9fd8be00
EZ
5776 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5777 coordinates of the iterator when restoring from ppos_it.
5778 (Bug#9296)
5779
5cf2b69b
KH
57802011-08-14 Kenichi Handa <handa@m17n.org>
5781
5782 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5783 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5784
daf17d00
EZ
57852011-08-14 Eli Zaretskii <eliz@gnu.org>
5786
5787 * xdisp.c (move_it_in_display_line_to): Don't invoke
5788 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5789 ppos_it. Fixes vertical cursor motion when line beginning is
5790 covered by an image. (Bug#9296)
5791
08e3161a
JD
57922011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5793
5794 * nsterm.h (ns_run_ascript): Declare.
5795 (NSAPP_DATA2_RUNASSCRIPT): Define.
5796
5797 * nsfns.m (as_script, as_result, as_status): New static variables.
5798 (ns_run_ascript): New function.
5e617bc2 5799 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5800 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5801 the event loop. Get status from as_status (Bug#7276).
5802
5803 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5804 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5805 the event loop (Bug#7276).
5806
a3720aa2
AS
58072011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5808
5809 * gnutls.c (QCgnutls_bootprop_priority)
5810 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5811 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5812 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5813 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5814 (QCgnutls_bootprop_verify_hostname_error)
5815 (QCgnutls_bootprop_callbacks_verify): Rename from
5816 Qgnutls_bootprop_..., all uses changed.
5817
5818 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5819 uses changed.
5820
0a0d27fb
PE
58212011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5822
19d5c50c
PE
5823 * xfaces.c (Qframe_set_background_mode): Now static.
5824 * dispextern.h (Qframe_set_background_mode): Remove decl.
5825
0a0d27fb
PE
5826 * process.c (Fnetwork_interface_info): Declare local only if needed.
5827
377538cb
JD
58282011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5829
5830 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5831 (Fnetwork_interface_list): Allocate in increments of bytes instead
5832 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5833 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5834 sockaddr.
5835 (struct ifflag_def): notrailers is smart on OSX.
5836 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5837 Get hardware address with getifaddrs if available.
5838
08fff70c
EZ
58392011-08-12 Eli Zaretskii <eliz@gnu.org>
5840
5841 * xdisp.c (iterate_out_of_display_property): xassert that
5842 IT->position is set to within IT->object's boundaries. Break from
5843 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5844 when IT->position is set up wrongly due to some bug.
5845 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5846 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5847 entry. Force push_it to save on the stack the current
5848 buffer/string position, to be restored by pop_it. Fix flags in
5849 the iterator structure wrt the object coming from a display
5850 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5851 properties. (Bug#9284)
5852
7be1c708 58532011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5854
7be1c708
CY
5855 * fontset.c (fontset_get_font_group): Add proper type checks.
5856 (Bug#9172)
aac0c6e3 5857
7be1c708 58582011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5859
7be1c708
CY
5860 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5861 and LC_VERSION_MIN_MACOSX.
5862 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5863 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5864
97bb72a6
EZ
58652011-08-08 Eli Zaretskii <eliz@gnu.org>
5866
5867 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5868 no-display-properties-and-no-overlays under bidi display.
5869 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5870 properties and overlays.
97bb72a6 5871
d5617611
CY
58722011-08-08 Chong Yidong <cyd@stupidchicken.com>
5873
37e11a63
CY
5874 * editfns.c (Fset_time_zone_rule): Document relationship with the
5875 setenv function.
5876
d5617611
CY
5877 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5878 the font entity extracted from the cache (Bug#8109).
5879
58872834
CY
58802011-08-07 Chong Yidong <cyd@stupidchicken.com>
5881
5882 * composite.c (autocmp_chars): Don't reset point. That is done by
5883 restore_point_unwind (Bug#5984).
5884
75bfc667
JL
58852011-08-07 Juri Linkov <juri@jurta.org>
5886
5887 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5888 to show the arg `TIME' instead of `TIMEVAL'.
5889
d1410150
EZ
58902011-08-06 Eli Zaretskii <eliz@gnu.org>
5891
5892 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5893 display property strides EOL and includes a newline, as in
5894 longlines-mode. (Bug#9254)
75b771e4
EZ
5895 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5896 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5897
5898 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5899 is non-zero, even if the data buffer is NULL. Fixes a crash in
5900 vertical-motion with longlines-mode. (Bug#9254)
5901
35928349
EZ
59022011-08-05 Eli Zaretskii <eliz@gnu.org>
5903
ec7cc85b
EZ
5904 * bidi.c <bidi_cache_total_alloc>: Now static.
5905 (bidi_initialize): Initialize bidi_cache_total_alloc.
5906
8b76d6f8 5907 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5908 cache. (Bug#9221)
5909
5910 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5911 amount allocated this far in `bidi_cache_total_alloc'.
5912 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5913 non-zero, only free the data buffer without restoring the cache
5914 contents. All callers changed.
5915
5916 * dispextern.h (bidi_unshelve_cache): Update prototype.
5917
5918 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5919 (move_it_in_display_line, move_it_to)
5920 (move_it_vertically_backward, move_it_by_lines): Replace the call
5921 to xfree to an equivalent call to bidi_unshelve_cache.
5922 (move_it_in_display_line_to): Fix logic of returning
412b6358 5923 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5924
e2e2423b
EZ
59252011-08-05 Eli Zaretskii <eliz@gnu.org>
5926
5927 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5928 came from a string character with a `cursor' property. (Bug#9229)
5929
ae9e757a
JD
59302011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5931
5932 * Makefile.in (LIB_PTHREAD): New variable.
5933 (LIBES): Add LIB_PTHREAD (Bug#9216).
5934
5935 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5936 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5937
213bd7f2
AS
59382011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5939
6b02f655 5940 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5941
99aaf75f
JD
59422011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5943
5944 * xterm.c (x_find_topmost_parent): New function.
5945 (x_set_frame_alpha): Find topmost parent window with
5946 x_find_topmost_parent and set the property there also (bug#9181).
5947 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5948
c74e9d86
PE
59492011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5950
5951 * callproc.c (Fcall_process): Avoid vfork clobbering
5952 the local vars buffer, coding_systems, current_dir.
5953
640c8776
SM
59542011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5955
5956 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5957
f26d0e4c
PE
59582011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5959
8a10d76c
PE
5960 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5961 so that it is not optimized away.
5962
f26d0e4c
PE
5963 * xdisp.c (compute_display_string_pos): Remove unused local.
5964
55439c61
EZ
59652011-08-02 Eli Zaretskii <eliz@gnu.org>
5966
5967 Fix slow cursor motion and scrolling in large buffers with
5968 selective display, like Org Mode buffers. (Bug#9218)
5969
5970 * dispextern.h (struct bidi_it): New member disp_prop_p.
5971
5972 * xdisp.c: Remove one-slot cache of display string positions.
5973 (compute_display_string_pos): Accept an additional argument
5e617bc2 5974 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5975 for a display string or property. If found, set DISP_PROP_P
5976 non-zero.
5977
5978 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5979 DISP_PROP_P, and pass it to compute_display_string_pos.
5980 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5981 non-zero. All callers of bidi_fetch_char changed.
5982
fb33fa43
SM
59832011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5984
5985 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5986
b099e063
DM
59872010-12-03 Don March <don@ohspite.net>
5988
5989 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5990 last character M-[char] is translated to ESC [char] (bug#7541).
5991
5cc7f7af
KH
59922011-08-02 Kenichi Handa <handa@m17n.org>
5993
d0fffa3f 5994 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5995
5996 * chartab.c (uniprop_table): Make it non-static.
5997
525d5e6e
EZ
59982011-08-01 Eli Zaretskii <eliz@gnu.org>
5999
6000 * xdisp.c (forward_to_next_line_start): Accept additional argument
6001 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6002 on the newline.
6003 (reseat_at_next_visible_line_start): Use the bidi iterator state
6004 returned by forward_to_next_line_start to restore the state of
6005 it->bidi_it after backing up to previous newline. (Bug#9212)
6006
31011111
AS
60072011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6008
6009 * regex.c (re_comp): Protoize.
6010 (re_exec): Fix return type.
6011 (regexec): Fix type of `ret'. (Bug#9203)
6012
476371c4
PE
60132011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6014
e5d76069
PE
6015 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6016 This is needed if max-image-size is a floating-point number.
6017
9a79b20c
AS
60182011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6019
6020 * print.c (print_object): Print empty symbol as ##.
6021
6022 * lread.c (read1): Read ## as empty symbol.
6023
d8c2fa78
AA
60242011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6025
6026 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6027 setting frame foreground color (Bug#9175).
6028 (x_set_background_color): Likewise.
6029
ffe57a7a
AA
6030 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6031 contents (Bug#9176).
6032 (EmacsTooltip -init): Remove bezels and add shadows to
6033 tooltip windows.
6034
bf3492a5
AA
6035 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6036 or scroll bar (Bug#8470).
6037
d55e9c53
AA
6038 * nsfont.m (nsfont_open): Remove assignment to voffset and
6039 unnecessary vars hshink, expand, hd, full_height, min_height.
6040 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6041
6042 * nsterm.h (nsfont_info): Remove voffset field.
6043
d8c2fa78 60442011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6045
6046 Implement strike-through and overline on NextStep (Bug#8863).
6047
6048 * nsfont.m (nsfont_open): Use underline position provided by font,
6049 instead of hard-coded value of 2.
6050 (nsfont_draw): Call ns_draw_text_decoration instead.
6051
6052 * nsterm.h: Add declaration for ns_draw_text_decoration.
6053
6054 * nsterm.m (ns_draw_text_decoration): New function for drawing
6055 underline, overline, and strike-through.
6056 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6057 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6058 accommodate underlining, etc.
4843aac3 6059
4cc60b9b
EZ
60602011-07-28 Eli Zaretskii <eliz@gnu.org>
6061
bc7ece87
EZ
6062 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6063 default.
4cc60b9b 6064
476371c4
PE
60652011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6066
66606eea
PE
6067 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6068 Without this fix, if a signal arrives just after memory fills up,
6069 'malloc' might be invoked reentrantly.
6070
476371c4
PE
6071 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6072 In other words, assume that every image size is allowed, on non-X
6073 hosts. This assumption is probably wrong, but it lets Emacs compile.
6074
f3fcc40d
AS
60752011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6076
6077 * regex.c (re_iswctype): Convert return values to boolean.
6078
350c992f
EZ
60792011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6080
6081 * xdisp.c (compute_display_string_pos): Don't use cached display
6082 string position if the buffer had its restriction changed.
6083 (Bug#9184)
6084
5266b4bb
PE
60852011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6086
6087 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6088
2573a837 60892011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6090
41f55ccd 6091 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6092
39e378da
PE
6093 * bidi.c: Integer size and overflow fixes.
6094 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6095 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6096 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6097 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6098 (bidi_find_other_level_edge):
6099 Use ptrdiff_t instead of EMACS_INT where either will do.
6100 This works better on 32-bit hosts configured --with-wide-int.
6101 (bidi_cache_ensure_space): Check for size-calculation overflow.
6102 Use % rather than repeated addition, for better worst-case speed.
6103 Don't set bidi_cache_size until after xrealloc returns, because it
6104 might not return.
6105 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6106 (bidi_cache_ensure_space): Also check that the bidi cache size
6107 does not exceed that of the largest Lisp string or buffer. See Eli
6108 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6109
5e927815
PE
6110 * alloc.c (__malloc_size_t): Remove.
6111 All uses replaced by size_t. See Andreas Schwab's note
6112 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6113
ca4aa935
PE
6114 * image.c: Improve checking for integer overflow.
6115 (check_image_size): Assume that f is nonnull, since
6116 it is always nonnull in practice. This is one less thing to
6117 worry about when checking for integer overflow later.
6118 (x_check_image_size): New function, which checks for integer
6119 overflow issues inside X.
6120 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6121 This removes the need for a memory_full check.
6122 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6123 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6124 (xbm_read_bitmap_data): Change locals back to 'int', since
6125 their values must fit in 'int'.
6126 (xpm_load_image, png_load, tiff_load):
6127 Invoke x_create_x_image_and_pixmap earlier,
6128 to avoid much needless work if the image is too large.
6129 (tiff_load): Treat overly large images as if
6130 x_create_x_image_and_pixmap failed, not as malloc failures.
6131 (gs_load): Use x_check_image_size.
6132
5f8f9cc2
PE
6133 * gtkutil.c: Omit integer casts.
6134 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6135 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6136
5adf60bc
PE
6137 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6138
c8907a93
PE
6139 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6140 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6141 would wrongly return t on a 64-bit host.
6142
e3c25c68
PE
6143 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6144 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6145 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6146 and therefore cause GCC to emit a bogus diagnostic in some cases.
6147
3f791afe
PE
6148 * image.c: Integer signedness and overflow and related fixes.
6149 This is not an exhaustive set of fixes, but it's time to
6150 record what I've got.
6151 (lookup_pixel_color, check_image_size): Remove redundant decls.
6152 (check_image_size): Don't assume that arbitrary EMACS_INT values
6153 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6154 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6155 (tiff_load, imagemagick_load_image):
6156 Check for overflow in size calculations.
6157 (x_create_x_image_and_pixmap): Remove unnecessary test for
6158 xmalloc returning NULL; that can't happen.
6159 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6160 (xpm_color_bucket): Use better integer hashing function.
6161 (xpm_cache_color): Don't possibly over-allocate memory.
6162 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6163 (gif_memory_source):
6164 Use ptrdiff_t, not int or size_t, to record sizes.
6165 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6166 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6167 either works, as we prefer signed integers.
6168 (tiff_read_from_memory, tiff_write_from_memory):
6169 Return tsize_t, not size_t, since that's what the TIFF API wants.
6170 (tiff_read_from_memory): Don't fail simply because the read would
6171 go past EOF; instead, return a short read.
6172 (tiff_load): Omit no-longer-needed casts.
6173 (Fimagemagick_types): Don't assume size fits into 'int'.
6174
3cc5a532
PE
6175 Improve hashing quality when configured --with-wide-int.
6176 * fns.c (hash_string): New function, taken from sxhash_string.
6177 Do not discard information about ASCII character case; this
6178 discarding is no longer needed.
6179 (sxhash-string): Use it. Change sig to match it. Caller changed.
6180 * lisp.h: Declare it.
6181 * lread.c (hash_string): Remove, since we now use fns.c's version.
6182 The fns.c version returns a wider integer if --with-wide-int is
6183 specified, so this should help the quality of the hashing a bit.
6184
b312a492
PE
6185 * emacs.c: Integer overflow minor fix.
6186 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6187 Define only if GNU_LINUX.
6188 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6189
dfd153ae
PE
6190 * dispnew.c: Integer signedness and overflow fixes.
6191 Remove unnecessary forward decls, that were a maintenance hassle.
6192 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6193 All uses changed.
6194 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6195 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6196 (prepare_desired_row, line_draw_cost):
6197 Use int, not unsigned, where either works.
6198 (save_current_matrix, restore_current_matrix):
6199 Use ptrdiff_t, not size_t, where either works.
6200 (init_display): Check for overflow more accurately, and without
6201 relying on undefined behavior.
6202
a81d11a3
PE
6203 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6204 Remove, replacing with the new symbols in lisp.h. All uses changed.
6205 * fileio.c (make_temp_name):
6206 * filelock.c (lock_file_1, lock_file):
6207 * xdisp.c (message_dolog):
6208 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6209 Use pMd etc. instead.
6210 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6211 replacing the pWIDE etc. symbols removed from editfns.c.
6212
3300e6fd
PE
6213 * keyboard.h (num_input_events): Now uintmax_t.
6214 This is (very slightly) less likely to mess up due to wraparound.
6215 All uses changed.
6216
fd05c7e9
PE
6217 * buffer.c: Integer signedness fixes.
6218 (alloc_buffer_text, enlarge_buffer_text):
6219 Use ptrdiff_t rather than size_t when either will do, as we prefer
6220 signed integers.
6221
903fe15d
PE
6222 * alloc.c: Integer signedness and overflow fixes.
6223 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6224 (__malloc_size_t): Default to size_t, not to int.
6225 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6226 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6227 Prefer ptrdiff_t to size_t when either would do, as we prefer
6228 signed integers.
6229 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6230 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6231 Now const. Initialize with values that are in range even if char
6232 is signed.
6233 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6234 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6235 These functions do the right thing with sizes > 2**32.
6236 (check_depth): Now ptrdiff_t, not int.
6237 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6238 Adjust to new way of storing sizes. Check for size overflow bugs
6239 in rest of code.
6240 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6241 slightly wrong anyway, as it missed one instance of
6242 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6243 (refill_memory_reserve): Omit needless cast to size_t.
6244 (mark_object_loop_halt): Mark as externally visible.
6245
ac82cc6a
PE
6246 * xselect.c: Integer signedness and overflow fixes.
6247 (Fx_register_dnd_atom, x_handle_dnd_message):
6248 Use ptrdiff_t, not size_t, since we prefer signed.
6249 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6250 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6251 x_dnd_atoms_size and x_dnd_atoms_length.
6252
c2d1e36d
PE
6253 * doprnt.c: Prefer signed to unsigned when either works.
6254 * eval.c (verror):
6255 * doprnt.c (doprnt):
6256 * lisp.h (doprnt):
6257 * xdisp.c (vmessage):
6258 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6259 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6260 prefer signed arithmetic to avoid comparison confusion.
6261 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6262 but is a bit tricky.
6263
0e926e56
PE
6264 Assume freestanding C89 headers, string.h, stdlib.h.
6265 * data.c, doprnt.c, floatfns.c, print.c:
6266 Include float.h unconditionally.
6267 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6268 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6269 * regex.c: Likewise for stddef.h, string.h.
6270 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6271 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6272 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6273 (STDC_HEADERS): Remove obsolete defines.
6274 * sysdep.c: Include limits.h unconditionally.
6275
9cfdb3ec
PE
6276 Assume support for memcmp, memcpy, memmove, memset.
6277 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6278 * regex.c (memcmp, memcpy):
6279 Remove; we assume C89 now.
6280
6281 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6282 (__malloc_safe_bcopy): Remove; no longer needed.
6283
cf950e6b 6284 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6285 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6286 well either way, and we prefer signed to unsigned.
6287
dbf38e02
LMI
62882011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6289
6290 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6291 closes the connection while we're reading (bug#9182).
6292
d6f0886c 62932011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6294
d6f0886c
JD
6295 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6296 are specified (Bug#9168).
24e0f6b1 6297
2eb1f9e6
PE
62982011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6299
6300 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6301 Found by GCC static checking and --with-wide-int on a 32-bit host.
6302
22381272 63032011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6304
6305 * xdisp.c (compute_display_string_pos): Fix logic of caching
6306 previous display string position. Initialize cached_prev_pos to
6307 -1. Fixes slow-down at the beginning of a buffer.
6308
f25e39b4
EZ
63092011-07-24 Eli Zaretskii <eliz@gnu.org>
6310
6311 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6312 for attrs[LFACE_FONTSET_INDEX].
6313
04c4b52e
PE
63142011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6315
6316 * xml.c (parse_region): Remove unused local
6317 that was recently introduced.
6318
c1734fbd
EZ
63192011-07-23 Eli Zaretskii <eliz@gnu.org>
6320
be18c5a5
EZ
6321 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6322 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6323
c1734fbd
EZ
6324 * xdisp.c (move_it_in_display_line_to): Record the best matching
6325 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6326 exit if none of the characters scanned was an exact match.
6327 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6328 when exact match is impossible due to invisible text, and the
6329 lines are truncated.
6330
a258d627
JD
63312011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6332
6333 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6334 for OSX >= 10.7.
6335
b6d5a689
EZ
63362011-07-22 Eli Zaretskii <eliz@gnu.org>
6337
0f74f785
EZ
6338 Fix a significant slow-down of cursor motion with C-n, C-p,
6339 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6340 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6341 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6342 (next_element_from_buffer): Call compute_stop_pos_backwards to
6343 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6344 base_level_stop.
6345 (reseat): Don't look for prev_stop, as that could mean a very long
6346 run.
6347 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6348 <cached_disp_overlay_modiff>: Cache for last found display string
6349 position.
551918c1 6350 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6351 about the same buffer in the same area of character positions, and
6352 the buffer wasn't changed since the time the display string
6353 position was cached.
551918c1 6354
b2d0c91a
EZ
63552011-07-22 Eli Zaretskii <eliz@gnu.org>
6356
6357 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6358 is an integer, which is important for empty lines. (Bug#9149)
6359
043604ee
CY
63602011-07-22 Chong Yidong <cyd@stupidchicken.com>
6361
6362 * frame.c (Fmodify_frame_parameters): In tty case, update the
6363 default face if necessary (Bug#4238).
6364
da4adb04
CY
63652011-07-21 Chong Yidong <cyd@stupidchicken.com>
6366
6367 * editfns.c (Fstring_to_char): No need to explain what a character
6368 is in the docstring (Bug#6576).
6369
9abd0532
LMI
63702011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6371
6372 * xml.c (parse_region): Make sure we always return a tree.
6373
36881d16
HK
63742011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6375
6376 * xml.c (parse_region): If a document contains only comments,
6377 return that, too.
6378
1e98674d
LMI
63792011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6380
6381 * xml.c (make_dom): Return comments, too.
6382
590bd467
PE
63832011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6384
6385 Port to OpenBSD.
6386 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6387 and the surrounding thread.
6388 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6389 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6390 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6391 timer goes off.
6392 * s/openbsd.h (BROKEN_SIGIO): Define.
6393 * unexelf.c (unexec) [__OpenBSD__]:
6394 Don't update the .mdebug section of the Alpha COFF symbol table.
6395
f41628b2
LMI
63962011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6397
6398 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6399 (bug#8460).
6400
b59b67c5
PE
64012011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6402
15e3a074
PE
6403 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6404 This fixes some race conditions on the permissions of any newly
6405 created file.
6406
41bed37d
PE
6407 * alloc.c (valid_pointer_p): Use pipe, not open.
6408 This fixes some permissions issues when debugging.
6409
b59b67c5
PE
6410 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6411 If fchown fails to set both uid and gid, try to set just gid,
6412 as that is sometimes allowed. Adjust the file's mode to eliminate
6413 setuid or setgid bits that are inappropriate if fchown fails.
6414
925a6be7
SM
64152011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6416
6417 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6418 to compare Lisp_Objects.
6419 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6420 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6421 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6422
52968808
AS
64232011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6424
0a6a104b
AS
6425 * lread.c (read_integer): Unread even EOF character.
6426 (read1): Likewise. Properly record start position of symbol.
6427
52968808
AS
6428 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6429 symbol character follows.
6430
9e381cdd
PE
64312011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6432
6433 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6434 This works around a problem with the previous change to Fcopy_file.
6435 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6436 and without this change, GCC might complain about discarding
6437 fchown's return value.
6438
b5641435
JB
64392011-07-16 Juanma Barranquero <lekktu@gmail.com>
6440
6441 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6442
a8031457
PE
64432011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6444
6445 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6446
dd889327
LMI
64472011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6448
750c33f7
LMI
6449 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6450 it's used from the C level.
6451
dd889327
LMI
6452 * process.c: Use the same condition for POLL_FOR_INPUT in both
6453 keyboard.c and process.c (bug#1858).
6454
87e86684
LM
64552011-07-09 Lawrence Mitchell <wence@gmx.li>
6456
6457 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6458 (Fgnutls_boot): Use it.
6459
64348f40
AS
64602011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6461
6462 * doc.c (Fsubstitute_command_keys): Revert last change.
6463
1d698799
LMI
64642011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6465
f863868c
LMI
6466 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6467 quotes the next character, and doesn't affect other longer
6468 sequences (bug#8935).
6469
1d698799
LMI
6470 * lread.c (syms_of_lread): Clarify that is isn't only
6471 `eval-buffer' and `eval-defun' that's affected by
6472 `lexical-binding' (bug#8460).
6473
aa4b6df6
EZ
64742011-07-15 Eli Zaretskii <eliz@gnu.org>
6475
6476 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6477 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6478
5d856da6
PE
64792011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6480
ad6042bb
PE
6481 Fix minor problems found by static checking.
6482 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6483 (elsz): Now a signed constant, not a size_t var. We prefer signed
6484 types to unsigned, to avoid integer comparison confusion. Without
6485 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6486 "cannot optimize loop, the loop counter may overflow", a symptom
6487 of the confusion.
f00bbb22 6488 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6489 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6490
6468f31c
LMI
64912011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6492
49080b10
LMI
6493 * search.c (Fre_search_backward): Mention `case-fold-search' in
6494 all the re_search_* functions (bug#8138).
6495
6468f31c
LMI
6496 * keyboard.c (Fopen_dribble_file): Document when the file is
6497 closed (bug#8056).
6498
c965adc5
EZ
64992011-07-14 Eli Zaretskii <eliz@gnu.org>
6500
df9733bf
EZ
6501 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6502 bidi_cache_idx.
6503
0bb23927
EZ
6504 Support bidi reordering of display and overlay strings.
6505 * xdisp.c (compute_display_string_pos)
6506 (compute_display_string_end): Accept additional argument STRING.
6507 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6508 (reseat_to_string): Initialize bidi_it->string.s and
6509 bidi_it->string.schars.
6510 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6511 NULL (avoids a crash in bidi_paragraph_init).
6512 Initialize itb.string.lstring.
0bb23927
EZ
6513 (init_iterator): Call bidi_init_it only of a valid
6514 buffer position was specified. Initialize paragraph_embedding to
6515 L2R.
6516 (reseat_to_string): Initialize the bidi iterator.
6517 (display_string): If we need to ignore text properties of
6518 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6519 original value of -1 will not work with bidi.)
6520 (compute_display_string_pos): First arg is now struct
6521 `text_pos *'; all callers changed. Support display properties on
6522 Lisp strings.
6523 (compute_display_string_end): Support display properties on Lisp
6524 strings.
6525 (init_iterator, reseat_1, reseat_to_string): Initialize the
6526 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6527 when iterating on a string not from display properties).
640c8776
SM
6528 (compute_display_string_pos, compute_display_string_end):
6529 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6530 arrow keys.
6531 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6532 base_level_stop; instead, set base_level_stop to BEGV.
6533 Fixes crashes in vertical-motion.
0bb23927
EZ
6534 (next_element_from_buffer): Improve commentary for when
6535 the iterator is before prev_stop.
6536 (init_iterator): Initialize bidi_p from the default value of
6537 bidi-display-reordering, not from buffer-local value. Use the
6538 buffer-local value only if initializing for buffer iteration.
6539 (handle_invisible_prop): Support invisible properties on strings
6540 that are being bidi-reordered.
6541 (set_iterator_to_next): Support bidi reordering of C strings and
6542 Lisp strings.
6543 (next_element_from_string): Support bidi reordering of Lisp
6544 strings.
6545 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6546 (display_string): Support display of R2L glyph rows.
6547 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6548 (init_iterator): Don't initialize it->bidi_p for strings
6549 here.
6550 (reseat_to_string): Initialize it->bidi_p for strings here.
6551 (next_element_from_string, next_element_from_c_string)
6552 (next_element_from_buffer): Add xassert's for correspondence
6553 between IT's object being iterated and it->bidi_it.string
6554 structure.
6555 (face_before_or_after_it_pos): Support bidi iteration.
6556 (next_element_from_c_string): Handle the case of the first string
6557 character that is not the first one in the visual order.
6558 (get_visually_first_element): New function, refactored from common
6559 parts of next_element_from_buffer, next_element_from_string, and
6560 next_element_from_c_string.
6561 (tool_bar_lines_needed, redisplay_tool_bar)
6562 (display_menu_bar): Force left-to-right direction. Add a FIXME
6563 comment for making that be controlled by a user option.
6564 (push_it, pop_it): Save and restore the state of the
6565 bidi iterator. Save and restore the bidi_p flag.
6566 (pop_it): Iterate out of display property for string iteration as
6567 well.
6568 (iterate_out_of_display_property): Support iteration over strings.
6569 (handle_single_display_spec): Set up it->bidi_it for iteration
6570 over a display string, and call bidi_init_it.
6571 (handle_single_display_spec, next_overlay_string)
6572 (get_overlay_strings_1, push_display_prop): Set up the bidi
6573 iterator for displaying display or overlay strings.
6574 (forward_to_next_line_start): Don't use the shortcut if
6575 bidi-iterating.
6576 (back_to_previous_visible_line_start): If handle_display_prop
6577 pushed the iterator stack, restore the internal state of the bidi
6578 iterator by calling bidi_pop_it same number of times.
6579 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6580 and we are bidi-iterating, don't decrement the iterator position;
6581 instead, set the first_elt flag in the bidi iterator, to produce
6582 the same effect.
6583 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6584 (push_display_prop): xassert that we are iterating a buffer.
6585 (push_it, pop_it): Save and restore paragraph_embedding member.
6586 (handle_single_display_spec, next_overlay_string)
6587 (get_overlay_strings_1, reseat_1, reseat_to_string)
6588 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6589 correctly. Don't assume unibyte strings are not bidi-reordered.
6590 (compute_display_string_pos)
6591 (compute_display_string_end): Fix handling the case of C string.
6592 (push_it, pop_it): Save and restore from_disp_prop_p.
6593 (handle_single_display_spec, push_display_prop): Set the
6594 from_disp_prop_p flag.
6595 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6596 (pop_it): Call iterate_out_of_display_property only if we are
6597 popping after iteration over a string that came from a display
6598 property. Fix a typo in popping stretch info. Add an assertion
6599 for verifying that the iterator position is in sync with the bidi
6600 iterator.
6601 (handle_single_display_spec, get_overlay_strings_1)
6602 (push_display_prop): Fix initialization of paragraph direction for
6603 string when that of the parent object is not yet determined.
6604 (reseat_1): Call bidi_init_it to resync the bidi
6605 iterator with IT's position. (Bug#7616)
6606 (find_row_edges): If ROW->start.pos gives position
6607 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6608 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6609 Reset the from_disp_prop_p flag.
6610 (SAVE_IT, RESTORE_IT): New macros.
6611 (pos_visible_p, face_before_or_after_it_pos)
6612 (back_to_previous_visible_line_start)
6613 (move_it_in_display_line_to, move_it_in_display_line)
6614 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6615 (try_scrolling, redisplay_window, display_line): Use them when
6616 saving a temporary copy of the iterator and restoring it back.
6617 (back_to_previous_visible_line_start, reseat_1)
6618 (init_iterator): Empty the bidi cache "stack".
6619 (move_it_in_display_line_to): If iterator ended up at
6620 EOL, but we never saw any buffer positions smaller than
6621 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6622 motion in bidi-reordered lines.
6623 (move_it_in_display_line_to): Record prev_method and prev_pos
6624 immediately before the call to set_iterator_to_next. Fixes cursor
6625 motion in bidi-reordered lines with stretch glyphs and strings
6626 displayed in margins. (Bug#8133) (Bug#8867)
6627 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6628 TO_CHARPOS.
640c8776
SM
6629 (pos_visible_p): Support positions in bidi-reordered lines.
6630 Save and restore bidi cache.
0bb23927
EZ
6631
6632 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6633 (bidi_paragraph_info): Delete unused struct.
6634 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6635 (bidi_cache_start): New variable.
6636 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6637 to zero.
6638 (bidi_cache_fetch_state, bidi_cache_search)
6639 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6640 (bidi_cache_find, bidi_peek_at_next_level)
6641 (bidi_level_of_next_char, bidi_find_other_level_edge)
6642 (bidi_move_to_visually_next): Compare cache index with
6643 bidi_cache_start rather than with zero.
6644 (bidi_fetch_char): Accept new argument STRING; all callers
6645 changed. Support iteration over a string. Support strings with
6646 display properties. Support unibyte strings. Fix the type of
6647 `len' according to what STRING_CHAR_AND_LENGTH expects.
6648 (bidi_paragraph_init, bidi_resolve_explicit_1)
6649 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6650 (bidi_level_of_next_char, bidi_move_to_visually_next):
6651 Support iteration over a string.
0bb23927
EZ
6652 (bidi_set_sor_type, bidi_resolve_explicit_1)
6653 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6654 can now be zero (for strings); special values 0 and -1 were
6655 changed to -1 and -2, respectively.
6656 (bidi_char_at_pos): New function.
6657 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6658 Call it instead of FETCH_MULTIBYTE_CHAR.
6659 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6660 initialized to valid values.
6661 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6662 values.
6663 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6664 the test for valid cached positions. Fix the logic for looking up
6665 the sentinel state in the cache. GCPRO the Lisp string we are
6666 iterating.
6667 (bidi_push_it, bidi_pop_it): New functions.
6668 (bidi_initialize): Initialize the bidi cache start stack pointer.
6669 (bidi_cache_ensure_space): New function, refactored from part of
6670 bidi_cache_iterator_state. Don't assume the required size is just
6671 one BIDI_CACHE_CHUNK away.
6672 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6673 (bidi_count_bytes, bidi_char_at_pos): New functions.
6674 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6675 always valid if bidi_cache_idx is valid.
6676 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6677 is valid if it's going to be used.
6678 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6679 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6680 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6681 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6682 (bidi_find_other_level_edge, bidi_cache_start_stack):
6683 All variables related to cache indices are now EMACS_INT.
c965adc5 6684
0bb23927
EZ
6685 * dispextern.h (struct bidi_string_data): New structure.
6686 (struct bidi_it): New member `string'. Make flag members be 1-bit
6687 fields, and put them last in the struct.
640c8776
SM
6688 (compute_display_string_pos, compute_display_string_end):
6689 Update prototypes.
0bb23927
EZ
6690 (bidi_push_it, bidi_pop_it): Add prototypes.
6691 (struct iterator_stack_entry): New members bidi_p,
6692 paragraph_embedding, and from_disp_prop_p.
6693 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6694 (bidi_shelve_cache, bidi_unshelve_cache):
6695 Declare prototypes.
0bb23927
EZ
6696
6697 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6698 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6699 and vector-like objects.
6700
6701 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6702 cache around display iteration.
6703
6704 * window.c (Fwindow_end, window_scroll_pixel_based)
6705 (displayed_window_lines, Frecenter): Save and restore the bidi
6706 cache around display iteration.
6707
3bbd2265
LMI
67082011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6709
6710 * editfns.c (Fdelete_region): Clarify the use of the named
6711 parameters (bug#6788).
6712
adc47434
MR
67132011-07-14 Martin Rudalics <rudalics@gmx.at>
6714
6715 * indent.c (Fvertical_motion): Set and restore w->pointm when
6716 saving and restoring the window's buffer (Bug#9006).
6717
837c31f8
LMI
67182011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6719
6720 * editfns.c (Fstring_to_char): Clarify just what is returned
6721 (bug#6576). Text by Eli Zaretskii.
6722
ac389d0c
JB
67232011-07-13 Juanma Barranquero <lekktu@gmail.com>
6724
6725 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6726
0be0ce47
EZ
67272011-07-13 Eli Zaretskii <eliz@gnu.org>
6728
6729 * buffer.c (mmap_find): Fix a typo.
6730
cd18e7e3
JB
67312011-07-13 Johan Bockgård <bojohan@gnu.org>
6732
6733 Fix execution of x selection hooks.
6734 * xselect.c (Qx_lost_selection_functions)
6735 (Qx_sent_selection_functions): New vars.
6736 (syms_of_xselect): DEFSYM them.
6737 (x_handle_selection_request): Pass Qx_sent_selection_functions
6738 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6739 (x_handle_selection_clear,x_clear_frame_selections):
6740 Pass Qx_lost_selection_functions rather than
6741 Vx_lost_selection_functions to Frun_hook_with_args.
6742
47ea7f44
PE
67432011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6744
ac389d0c 6745 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6746 The old code sometimes used this field without initializing it.
6747
47ea7f44
PE
6748 * alloc.c (gc_sweep): Don't read past end of array.
6749 In theory, the old code could also have corrupted Emacs internals,
6750 though it'd be very unlikely.
6751
bc985c87
AS
67522011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6753
6754 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6755 argument. (Bug#4026)
bc985c87 6756
0cf34688
LMI
67572011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6758
b3dadd76
LMI
6759 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6760 key" (bug#4257).
6761
0cf34688
LMI
6762 * window.c (Fset_window_start): Doc fix (bug#4199).
6763 (Fset_window_hscroll): Ditto.
6764
270768cd
PE
67652011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6766
077e3dda 6767 Fix minor new problems caught by GCC 4.6.1.
270768cd 6768 * term.c (init_tty): Remove unused local.
490011a6 6769 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6770 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6771 not used otherwise.
270768cd 6772
b1f58454
CY
67732011-07-12 Chong Yidong <cyd@stupidchicken.com>
6774
6775 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6776
22b9578d
LMI
67772011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6778
6e70ab07
LMI
6779 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6780 are the mini-buffer and the echo area (bug#3320).
6781
22b9578d
LMI
6782 * term.c (init_tty): Remove support for supdup, c10 and perq
6783 terminals, which are no longer supported (bug#1482).
6784
8974cc9f
JB
67852011-07-10 Johan Bockgård <bojohan@gnu.org>
6786
6787 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6788
a560d974
JD
67892011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6790
6791 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6792 for non-popups (Bug#3642).
6793
1dae0f0a
AS
67942011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6795
268c2c36 6796 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6797 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6798 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6799 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6800 * data.c (fmod): Likewise.
6801 * dispnew.c (swap_glyphs_in_rows): Likewise.
6802 * emacs.c (memory_warning_signal): Likewise.
6803 * floatfns.c (float_error): Likewise.
6804 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6805 (otf_open, font_otf_capability, generate_otf_features)
6806 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6807 Likewise.
6808 * image.c (pbm_read_file): Likewise.
6809 * indent.c (string_display_width): Likewise.
6810 * intervals.c (check_for_interval, search_for_interval)
6811 (inc_interval_count, count_intervals, root_interval)
6812 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6813 * lread.c (defalias): Likewise.
268c2c36 6814 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6815 * regex.c (set_image_of_range_1, set_image_of_range)
6816 (regex_grow_registers): Likewise.
6817 * sysdep.c (strerror): Likewise.
6818 * termcap.c (valid_filename_p, tprint, main): Likewise.
6819 * tparam.c (main): Likewise.
6820 * unexhp9k800.c (run_time_remap, save_data_space)
6821 (update_file_ptrs, read_header, write_header, calculate_checksum)
6822 (copy_file, copy_rest, display_header): Likewise.
6823 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6824 Likewise.
6825 * xdisp.c (check_it): Likewise.
6826 * xfaces.c (register_color, unregister_color, unregister_colors):
6827 Likewise.
6828 * xfns.c (print_fontset_result): Likewise.
6829 * xrdb.c (member, fatal, main): Likewise.
6830
99033785
PE
68312011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6832
6833 Fix minor problems found by static checking (Bug#9031).
6834 * chartab.c (char_table_set_range, map_sub_char_table):
6835 Remove unused locals.
6836 (uniprop_table): Now static.
6837 * composite.c (_work_char): Remove unused static var.
6838
9cb2ac56
JB
68392011-07-09 Juanma Barranquero <lekktu@gmail.com>
6840
6841 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6842
f25661f0
JD
68432011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6844
6845 * gtkutil.c (qttip_cb): Remove code without function.
6846
8278c4fe
EZ
68472011-07-09 Eli Zaretskii <eliz@gnu.org>
6848
6849 * w32.c (pthread_sigmask): New stub.
6850
1692ae2d 68512011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6852
8a6ebd58 6853 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6854 sigprocmask is portable only for single-threaded applications, and
6855 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6856 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6857 (LIBES): Use it.
6858 * callproc.c (Fcall_process):
6859 * process.c (create_process):
6860 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6861 Use pthread_sigmask, not sigprocmask.
123403e4 6862
1b854618
JD
68632011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6864
6865 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6866 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6867 wrong (Bug#8591).
6868
3fe4b549
JD
68692011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6870
0ce7e563
JD
6871 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6872 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6873 (xg_hide_tooltip): Fix comment.
6874
3fe4b549
JD
6875 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6876 in registerServicesMenuSendTypes.
6877 (validRequestorForSendType): Don't check ns_return_types.
6878
6879 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6880 ns_return_type.
6881
5df75e47
JR
68822011-07-08 Jason Rumney <jasonr@gnu.org>
6883
22610910
JR
6884 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6885 SH_SHOW for hidden windows (Bug#5482).
6886
5df75e47
JR
6887 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6888 frame struct members of non-existent frames (Bug#6284).
6889
699c10bd
JD
68902011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6891
4393663b
JD
6892 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6893 variable firstTime not needed on OSX >= 10.6.
6894 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6895 >= 10.5. Use setKnobProportion, setDoubleValue.
6896
6897 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6898 (MAC_OS_X_VERSION_10_5): Define if not defined.
6899 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6900 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6901 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6902
6903 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6904 cString and lossyCString on OSX >= 10.4
6905
58179cce 6906 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6907 sizeToFit on OSX >= 10.2.
6908
6909 * nsimage.m (allocInitFromFile): Don't use deprecated method
6910 bestRepresentationForDevice on OSX >= 10.6.
6911
6912 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6913 to avoid warning.
6914
6915 * emacs.c: Declare unexec_init_emacs_zone.
6916
a63e0781
JD
6917 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6918
699c10bd
JD
6919 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6920
6921 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6922 on svcsMenu (Bug#8842).
6923
6924 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6925 ns_return_types.
6926 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6927
6928 * nsterm.m (QUTF8_STRING): Declare.
6929 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6930 (validRequestorForSendType): Return type is (id).
6931 Change indexOfObjectIdenticalTo to indexOfObject.
6932 Check if we have local selection before returning self (Bug#8842).
6933 (writeSelectionToPasteboard): Put local selection into paste board
6934 if we have a local selection (Bug#8842).
6935 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6936
6937 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6938 (ns_get_local_selection): Declare.
6939
54e10184
LMI
69402011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6941
9888ff71
LMI
6942 * keymap.c (describe_map_tree): Don't insert a double newline at
6943 the end of the buffer (bug#1169) and return whether we inserted
6944 something.
6945
54e10184
LMI
6946 * callint.c (Fcall_interactively): Change "reading args" to
6947 "providing args" to try to clarify what it does (bug#1010).
6948
15fa4783
KH
69492011-07-07 Kenichi Handa <handa@m17n.org>
6950
6951 * composite.c (composition_compute_stop_pos): Ignore a static
6952 composition starting before CHARPOS (Bug#8915).
6953
6954 * xdisp.c (handle_composition_prop): Likewise.
6955
a8815b00
EZ
69562011-07-07 Eli Zaretskii <eliz@gnu.org>
6957
6958 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6959 (Bug#9015)
6960
ef7b981d 69612011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6962
6963 * character.h (unicode_category_t): New enum type.
6964
6965 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6966 (Qchar_code_property_table): New variable.
6967 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6968 (UNIPROP_COMPRESSED_FORM_P): New macros.
6969 (char_table_ascii): Uncompress the compressed values.
6970 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6971 Uncompress the compressed values.
ac389d0c 6972 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6973 (char_table_ref_and_range): Uncompress the compressed values.
6974 (sub_char_table_set): New arg is_uniprop. Callers changed.
6975 Uncompress the compressed values.
6976 (sub_char_table_set_range): Args changed. Callers changed.
6977 (char_table_set_range): Adjuted for the above change.
6978 (map_sub_char_table): Delete args default_val and parent. Add arg
6979 top. Give decoded values to a Lisp function.
640c8776 6980 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6981 values to a Lisp function. Gcpro more variables.
6982 (uniprop_table_uncompress)
6983 (uniprop_decode_value_run_length): New functions.
6984 (uniprop_decoder, uniprop_decoder_count): New variables.
6985 (uniprop_get_decoder, uniprop_encode_value_character)
6986 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6987 New functions.
6988 (uniprop_encoder, uniprop_encoder_count): New variables.
6989 (uniprop_get_encoder, uniprop_table)
6990 (Funicode_property_table_internal, Fget_unicode_property_internal)
6991 (Fput_unicode_property_internal): New functions.
6992 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6993 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6994 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6995 char-code-property-alist.
6996
640c8776 6997 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6998 Vunicode_category_table.
6999
640c8776 7000 * font.c (font_range): Adjust for the change of
c805dec0
KH
7001 Vunicode_category_table.
7002
76b397fb
DN
70032011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7004
7005 * m/iris4d.h: Remove file, move contents ...
7006 * s/irix6-5.h: ... here.
7007
22b4128e
PE
70082011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7009
7010 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7011 * alloc.c (mark_buffer):
7012 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7013 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7014 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7015 This isn't true in general, and it's particularly not true
7016 if Emacs is configured with --with-wide-int.
7017 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7018 New macros, used in the buffer.c change.
7019
869795d6
JD
70202011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7021
7022 * xsettings.c: Use both GConf and GSettings if both are available.
7023 (store_config_changed_event): Add comment.
7024 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7025 (store_tool_bar_style_changed): New functions.
5e617bc2 7026 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7027 (struct xsettings): Move font inside HAVE_XFT.
7028 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7029 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7030 Move inside HAVE_XFT.
640c8776 7031 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7032 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7033 also.
7034 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7035 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7036 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7037 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7038 (parse_settings): Move check for font inside HAVE_XFT.
7039 (read_settings, apply_xft_settings): Add comment.
7040 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7041 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7042 call store_font_name_changed.
7043 (xft_settings_event): Add comment.
7044 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7045 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7046 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7047 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7048 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7049 (xsettings_get_system_font, xsettings_get_system_normal_font):
7050 Add comment.
869795d6 7051
d8ed26bd
PE
70522011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7053
7054 Random fixes. E.g., (random) never returned negative values.
7055 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7056 subseconds part to the entropy, as that's a bit more random.
7057 Prefer signed to unsigned, since the signedness doesn't matter and
7058 in general we prefer signed. When given a limit, use a
7059 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7060 latter isn't right if USE_2_TAGS_FOR_INTS.
7061 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7062 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7063
cabf1cac
SM
70642011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7065
7066 * textprop.c (text_property_stickiness):
7067 Obey Vtext_property_default_nonsticky.
7068 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7069 * w32fns.c (syms_of_w32fns):
7070 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7071
6e9b2be9
PE
70722011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7073
7074 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7075 This is more efficient than Ffile_directory_p and avoids a minor race.
7076
90186c68
LMI
70772011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7078
7c301272
LMI
7079 * buffer.c (Foverlay_put): Say what the return value is
7080 (bug#7835).
7081
c4f2d8d4
LMI
7082 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7083 is a directory before asking whether to use the file name
7084 (bug#7564).
ad637907
LMI
7085 (barf_or_query_if_file_exists): Make the "File is a directory"
7086 error be more correct.
c4f2d8d4 7087
90186c68
LMI
7088 * fns.c (Frequire): Remove the mention of the .gz files, since
7089 that's installation-specific, but keep the mention of
7090 `get-load-suffixes'.
7091
da64016e
PE
70922011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7093
7094 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7095 Report string overflow if the output is too long.
7096
7d47b580
JB
70972011-07-04 Juanma Barranquero <lekktu@gmail.com>
7098
a555cb87
JB
7099 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7100 (syms_of_gnutls): Remove duplicate DEFSYM for
7101 Qgnutls_bootprop_verify_hostname_error, an error for
7102 Qgnutls_bootprop_verify_error (which is no longer used).
7103
7d47b580
JB
7104 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7105 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7106 Also (re)move comments that are misplaced or no longer relevant.
7107
1e49bfab
LMI
71082011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7109
7110 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7111
1485f4c0
CY
71122011-07-03 Chong Yidong <cyd@stupidchicken.com>
7113
7114 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7115 and background color parameters if they have been changed.
7116
a9ab721e
LMI
71172011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7118
7119 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7120
cf7cff57
PE
71212011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7122
2e13213d
PE
7123 * xsettings.c (SYSTEM_FONT): Define only when used.
7124 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7125
cf7cff57
PE
7126 * keymap.c (access_keymap_1): Now static.
7127
7a8e04f7
CY
71282011-07-02 Chong Yidong <cyd@stupidchicken.com>
7129
7130 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7131 leave any prefix arg for the up event (Bug#1586).
7132
61352f62
LMI
71332011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7134
69bb1ef7
LMI
7135 * lread.c (syms_of_lread): Mention single symbols defined by
7136 `defvar' or `defconst' (bug#7154).
7137
61352f62 7138 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7139 (Frequire): Mention get-load-suffixes.
61352f62 7140
28545e04
MR
71412011-07-02 Martin Rudalics <rudalics@gmx.at>
7142
7143 * window.h (window): Remove clone_number slot.
7144 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7145 Remove.
7146 (make_parent_window, make_window, saved_window)
7147 (Fset_window_configuration, save_window_save): Don't deal with
7148 clone numbers.
7149 * buffer.c (Qclone_number): Remove declaration.
7150 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7151
3349e122
SM
71522011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7153
7154 Add multiple inheritance to keymaps.
7155 * keymap.c (Fmake_composed_keymap): New function.
7156 (Fset_keymap_parent): Simplify.
7157 (fix_submap_inheritance): Remove.
7158 (access_keymap_1): New function extracted from access_keymap to handle
7159 embedded parents and handle lists of maps.
7160 (access_keymap): Use it.
7161 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7162 (Fcopy_keymap): Handle embedded parents.
7163 (Fcommand_remapping, define_as_prefix): Simplify.
7164 (Fkey_binding): Simplify.
7165 (syms_of_keymap): Move minibuffer-local-completion-map,
7166 minibuffer-local-filename-completion-map,
7167 minibuffer-local-must-match-map, and
7168 minibuffer-local-filename-must-match-map to Elisp.
7169 (syms_of_keymap): Defsubr make-composed-keymap.
7170 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7171 (parse_menu_item): Trivial simplification.
7172
3279eb87
GM
71732011-07-01 Glenn Morris <rgm@gnu.org>
7174
7175 * Makefile.in (SETTINGS_LIBS): Fix typo.
7176
4550efdf
KI
71772011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7178
7179 * coding.c (Fencode_coding_string): Record the last coding system
7180 used, as the function doc string says (bug#8738).
7181
0949d2b6
JD
71822011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7183
7184 * xsettings.c (store_monospaced_changed): Take new font as arg and
7185 check for change against current_mono_font.
7186 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7187 (emacs_settings_constructor, emacs_settings_get_property)
7188 (emacs_settings_set_property, emacs_settings_class_init)
7189 (emacs_settings_init, gsettings_obj): Remove.
7190 (something_changedCB): New function for HAVE_GSETTINGS.
7191 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7192 with value as argument.
7193 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7194 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7195 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7196 "changed".
7197
7198 * xgselect.c: Add defined (HAVE_GSETTINGS).
7199 (xgselect_initialize): Ditto.
7200
7201 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7202 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7203 xg_select.
7204
bbc6b304
PE
72052011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7206
7207 * eval.c (struct backtrace): Simplify and port the data structure.
7208 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7209 signed bit field, as this assumption is not portable and it makes
7210 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7211 "char debug_on_exit : 1" as this is not portable either; instead,
7212 use the portable "unsigned int debug_on_exit : 1". Remove unused
7213 member evalargs. Remove obsolete comments about cc bombing out.
7214
9851bfc5
JD
72152011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7216
51bb811f 7217 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7218 Let HAVE_GSETTINGS override HAVE_GCONF.
7219 (store_monospaced_changed): New function.
7220 (EMACS_SETTINGS): A new type derived from GObject to handle
7221 GSettings notifications.
7222 (emacs_settings_constructor, emacs_settings_get_property)
7223 (emacs_settings_set_property, emacs_settings_class_init):
7224 New functions.
7225 (gsettings_client, gsettings_obj): New variables.
7226 (GSETTINGS_SCHEMA): New define.
7227 (something_changedCB): Call store_monospaced_changed.
7228 (init_gsettings): New function.
7229 (xsettings_initialize): Call init_gsettings.
7230 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7231 to NULL.
7232
640c8776 7233 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7234 GCONF_CFLAGS/LIBS.
7235
5386012d
MR
72362011-06-29 Martin Rudalics <rudalics@gmx.at>
7237
7238 * window.c (resize_root_window, grow_mini_window)
7239 (shrink_mini_window): Rename Qresize_root_window to
7240 Qwindow_resize_root_window and Qresize_root_window_vertically to
7241 Qwindow_resize_root_window_vertically.
7242
f13e0b08
PE
72432011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7244
7245 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7246
94515237
JB
72472011-06-27 Juanma Barranquero <lekktu@gmail.com>
7248
7249 * makefile.w32-in: Redesign dependencies so they reflect more
7250 clearly which files are directly included by each source file,
7251 and not through other includes.
7252
e43b6e43
MR
72532011-06-27 Martin Rudalics <rudalics@gmx.at>
7254
7255 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7256 (sort_overlays, overlay_strings): When an overlay's clone number
7257 matches the window's clone number process the overlay even if
7258 the overlay's window property doesn't match the current window.
7259
d68443dc
MR
7260 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7261 (Fwindow_hchild): Rename to Fwindow_left_child.
7262 (Fwindow_next): Rename to Fwindow_next_sibling.
7263 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7264 (resize_window_check): Rename to window_resize_check.
7265 (resize_window_apply): Rename to window_resize_apply.
7266 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7267 (Fdelete_other_windows_internal, resize_frame_windows)
7268 (Fsplit_window_internal, Fdelete_window_internal)
7269 (grow_mini_window, shrink_mini_window)
7270 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7271
c7e73be5
JD
72722011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7273
7274 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7275 (emacs_fixed_set_min_size): Remove.
7276 (emacs_fixed_new): Take frame as argument.
7277
7278 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7279 (_EmacsFixedPrivate): Remove minwidth/height.
7280 Add struct frame *f.
7281 (emacs_fixed_init): Initialize priv->f.
7282 (get_parent_class, emacs_fixed_set_min_size): Remove.
7283 (emacs_fixed_new): Set priv->f to argument.
7284 (emacs_fixed_get_preferred_width)
7285 (emacs_fixed_get_preferred_height): Use min_width/height from
7286 frames size_hint to set minimum and natural (Bug#8919).
7287 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7288 and use min_width/height from frames size_hint to set
7289 min_width/height (Bug#8919).
7290
7291 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7292 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7293 Fix indentation.
c7e73be5 7294
cf99dcf8
EZ
72952011-06-26 Eli Zaretskii <eliz@gnu.org>
7296
7297 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7298 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7299 called at ZV.
7300
029529ac
CY
73012011-06-26 Chong Yidong <cyd@stupidchicken.com>
7302
7303 * process.c (wait_reading_process_output): Bypass select if
7304 waiting for a cell while ignoring keyboard input, and input is
7305 pending. Suggested by Jan Djärv (Bug#8869).
7306
7a7ef429
PE
73072011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7308
7309 Use gnulib's dup2 module instead of rolling our own.
7310 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7311
11fdef7d 73122011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7313
7314 * dispnew.c (scrolling_window): Before scrolling, turn off a
7315 mouse-highlight in the window being scrolled.
7316
cd3520a4
JB
73172011-06-24 Juanma Barranquero <lekktu@gmail.com>
7318
7319 Move DEFSYM to lisp.h and use everywhere.
7320
7321 * character.h (DEFSYM): Move declaration...
7322 * lisp.h (DEFSYM): ...here.
7323
7324 * gnutls.c:
7325 * minibuf.c:
7326 * w32menu.c:
7327 * w32proc.c:
7328 * w32select.c: Don't include character.h.
7329
7330 * alloc.c (syms_of_alloc):
7331 * buffer.c (syms_of_buffer):
7332 * bytecode.c (syms_of_bytecode):
7333 * callint.c (syms_of_callint):
7334 * casefiddle.c (syms_of_casefiddle):
7335 * casetab.c (init_casetab_once):
7336 * category.c (init_category_once, syms_of_category):
7337 * ccl.c (syms_of_ccl):
7338 * cmds.c (syms_of_cmds):
7339 * composite.c (syms_of_composite):
7340 * dbusbind.c (syms_of_dbusbind):
7341 * dired.c (syms_of_dired):
7342 * dispnew.c (syms_of_display):
7343 * doc.c (syms_of_doc):
7344 * editfns.c (syms_of_editfns):
7345 * emacs.c (syms_of_emacs):
7346 * eval.c (syms_of_eval):
7347 * fileio.c (syms_of_fileio):
7348 * fns.c (syms_of_fns):
7349 * frame.c (syms_of_frame):
7350 * fringe.c (syms_of_fringe):
7351 * insdel.c (syms_of_insdel):
7352 * keymap.c (syms_of_keymap):
7353 * lread.c (init_obarray, syms_of_lread):
7354 * macros.c (syms_of_macros):
7355 * msdos.c (syms_of_msdos):
7356 * print.c (syms_of_print):
7357 * process.c (syms_of_process):
7358 * search.c (syms_of_search):
7359 * sound.c (syms_of_sound):
7360 * syntax.c (init_syntax_once, syms_of_syntax):
7361 * terminal.c (syms_of_terminal):
7362 * textprop.c (syms_of_textprop):
7363 * undo.c (syms_of_undo):
7364 * w32.c (globals_of_w32):
7365 * window.c (syms_of_window):
7366 * xdisp.c (syms_of_xdisp):
7367 * xfaces.c (syms_of_xfaces):
7368 * xfns.c (syms_of_xfns):
7369 * xmenu.c (syms_of_xmenu):
7370 * xsettings.c (syms_of_xsettings):
7371 * xterm.c (syms_of_xterm): Use DEFSYM.
7372
4228cf16
TZ
73732011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7374
cd3520a4 7375 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7376
7fcccf1e
PE
73772011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7378
7efb4e0e
PE
7379 Integer and buffer overflow fixes (Bug#8873).
7380
ff5844ad
PE
7381 * print.c (printchar, strout): Check for string overflow.
7382 (PRINTPREPARE, printchar, strout):
7383 Don't set size unless allocation succeeds.
7384
90532f02
PE
7385 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7386 for sizes. Check for string overflow more accurately.
7387 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7388
6d84508d
PE
7389 * macros.c: Integer and buffer overflow fixes.
7390 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7391 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7392 Use ptrdiff_t, not int, for sizes.
7393 Don't increment bufsize until after realloc succeeds.
7394 Check for size-calculation overflow.
7395 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7396
437b2cb4
PE
7397 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7398
8b9ac8b4
PE
7399 * lread.c: Integer overflow fixes.
7400 (read_integer): Radix is now EMACS_INT, not int,
7401 to improve quality of diagnostics for out-of-range radices.
7402 Calculate buffer size correctly for out-of-range radices.
7403 (read1): Check for integer overflow in radices, and in
7404 read-circle numbers.
82cb60d3
PE
7405 (read_escape): Avoid int overflow.
7406 (Fload, openp, read_buffer_size, read1)
7407 (substitute_object_recurse, read_vector, read_list, map_obarray):
7408 Use ptrdiff_t, not int, for sizes.
7409 (read1): Use EMACS_INT, not int, for sizes.
20270765 7410 Check for size overflow.
8b9ac8b4 7411
7fcccf1e
PE
7412 * image.c (cache_image): Check for size arithmetic overflow.
7413
bfbbd7e7
PE
7414 * lread.c: Integer overflow issues.
7415 (saved_doc_string_size, saved_doc_string_length)
7416 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7417 Now ptrdiff_t, not int.
7418 (read1): Don't assume doc string length fits in int. Check for
7419 out-of-range doc string lengths.
7420 (read_list): Don't assume file position fits in int.
39019e54 7421 (read_escape): Check for hex character overflow.
bfbbd7e7 7422
4e323265
LL
74232011-06-22 Leo Liu <sdl.web@gmail.com>
7424
7425 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7426 Move to minibuffer.el.
7427
85fece3e
PE
74282011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7429
20b84ce9 7430 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7431 The following patches are for when GLYPH_DEBUG && !XASSERT.
7432 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7433 * dispnew.c (flush_stdout):
7434 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7435 Mark as externally visible.
7436 * dispnew.c (check_window_matrix_pointers): Now static.
7437 * dispnew.c (window_to_frame_vpos):
7438 * xfns.c (unwind_create_frame):
7439 * xterm.c (x_check_font): Remove unused local.
7440 * scroll.c (CHECK_BOUNDS):
7441 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7442 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7443 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7444 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7445 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7446 Now static.
7447 (debug_method_add): Use va_list and vsprintf rather than relying
7448 on undefined behavior with wrong number of arguments.
7449 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7450 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7451 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7452 since we're not interested in debugging glyphs with old libraries.
7453 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7454 GCC 4.6.0's static checking.
7455
0766b489
PE
74562011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7457
31fd4b32
PE
7458 Integer overflow and signedness fixes (Bug#8873).
7459 A few related buffer overrun fixes, too.
7460
b79e8648
PE
7461 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7462
0766b489
PE
7463 * dispextern.h (struct face.stipple):
7464 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7465 (x_bitmap_mask, x_allocate_bitmap_record)
7466 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7467 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7468 (x_create_bitmap_from_xpm_data):
7469 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7470 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7471 (.bitmaps_last):
7472 * xfaces.c (load_pixmap):
7473 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7474 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7475 (.bitmaps_last, struct x_output.icon_bitmap):
7476 Use ptrdiff_t, not int, for bitmap indexes.
7477 (x_allocate_bitmap_record): Check for size overflow.
7478 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7479
b081724f
PE
7480 Use ptrdiff_t, not int, for overlay counts.
7481 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7482 * editfns.c (overlays_around, get_pos_property):
7483 * textprop.c (get_char_property_and_overlay):
7484 * xdisp.c (next_overlay_change, note_mouse_highlight):
7485 * xfaces.c (face_at_buffer_position):
21514da7
PE
7486 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7487 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7488 (Fnext_overlay_change, Fprevious_overlay_change)
7489 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7490 Use ptrdiff_t, not int, for sizes.
21514da7 7491 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7492
3de73e5e
PE
7493 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7494
2606c57b
PE
7495 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7496 (x_session_initialize): Do not assume string length fits in int.
7497
aaafe47a
PE
7498 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7499 This is unlikely, but can occur if DPI is outlandish.
7500
2674ddc8 7501 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7502 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7503
28154962
PE
7504 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7505 * xrdb.c (magic_file_p, search_magic_path):
7506 Omit last arg SUFFIX; it was always 0. All callers changed.
7507 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7508
7de51af5
PE
7509 * xfont.c (xfont_match): Avoid need for strlen.
7510
25ed6cc3
PE
7511 * xfns.c: Don't assume strlen fits in int.
7512 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7513
4eab31dd
PE
7514 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7515 not unsigned long, as we prefer signed integers. All callers changed.
7516 Detect integer overflow in repeat count.
7517 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7518 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7519
171e2a58
PE
7520 * termcap.c: Don't assume sizes fit in int and never overflow.
7521 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7522 (gobble_line): Check for size-calculation overflow.
7523
ad39faca 7524 * minibuf.c (Fread_buffer):
6e5bb2dc 7525 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7526 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7527 Don't assume string length fits in int.
7528
52c61c22 7529 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7530 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7531
b5b8c9e5
PE
7532 * font.c: Don't assume string length fits in int.
7533 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7534 Use ptrdiff_t, not int.
ccd6111c
PE
7535 (font_intern_prop): Don't assume string length fits in int.
7536 Don't assume integer property fits in fixnum.
7537 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7538
882f0d81 7539 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7540 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7541 Reformulate so as not to need the command string.
7542 Invoke gzip -cd rather than gunzip, as it's more portable.
7543 (lock_info_type, lock_file_1, lock_file):
7544 Don't assume pid_t and time_t fit in unsigned long.
7545 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7546 (current_lock_owner): Prefer signed type for sizes.
7547 Use memcpy, not strncpy, where memcpy is what is really wanted.
7548 Don't assume (via atoi) that time_t and pid_t fit in int.
7549 Check for time_t and/or pid_t out of range, e.g., via a network share.
7550 Don't alloca where an auto var works fine.
7551
93f4cf88
PE
7552 * fileio.c: Fix some integer overflow issues.
7553 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7554 Don't assume string length fits in int.
7555 (directory_file_name): Don't assume string length fits in long.
7556 (make_temp_name): Don't assume pid fits in int, or that its print
7557 length is less than 20.
7558
f3e92b69
PE
7559 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7560
1bfdaf10
PE
7561 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7562
35016e9a
PE
7563 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7564
3d1e65a1
PE
7565 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7566 We prefer signed integers, even for size calculations.
7567
0b963a93
PE
7568 * emacs.c: Don't assume string length fits in 'int'.
7569 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7570 (main): Don't invoke strlen when not needed.
7571
573f4b54
PE
7572 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7573 (XD_DEBUG_MESSAGE): Don't waste a byte.
7574
989f33ba
PE
7575 * callproc.c (getenv_internal_1, getenv_internal)
7576 (Fgetenv_internal):
965d34eb
PE
7577 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7578
e4d29b33
PE
7579 * lread.c (invalid_syntax): Omit length argument.
7580 All uses changed. This doesn't fix a bug, but it simplifies the
7581 code away from its former Hollerith-constant appearance, and it's
7582 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7583 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7584
eb49b136
PE
7585 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7586 This didn't break anything, but it didn't help either.
7587 It's confusing to put a bogus integer in a place where the actual
7588 value does not matter.
9f62aeb1 7589 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7590 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7591
15375a22
PE
7592 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7593 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7594 implementation.
b61cc01c
PE
7595 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7596 We prefer signed types, and the value cannot exceed the EMACS_INT
7597 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7598 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7599 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7600 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7601
53b2623d
PE
7602 * indent.c (sane_tab_width): New function.
7603 (current_column, scan_for_column, Findent_to, position_indentation)
7604 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7605 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7606
51cab52b 7607 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7608
f2ed8a70
PE
7609 * lisp.h (lint_assume): New macro.
7610 * composite.c (composition_gstring_put_cache):
7611 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7612
abe80cc6
PE
7613 * editfns.c, insdel.c:
7614 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7615
b02c740e
PE
7616 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7617
ebc96716
PE
7618 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7619
b4e50fa0 7620 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7621 Use much-faster test for byte-length change.
311d5d7c 7622 Don't assume string byte-length fits in 'int'.
a4cf38e4 7623 Check that character arg fits in 'int'.
85461888 7624 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7625
c0c1ee9f
PE
7626 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7627
a498d7f4
PE
7628 * fns.c (concat): Catch string overflow earlier.
7629 Do not rely on integer wraparound.
7630
51cab52b
PE
7631 * dispextern.h (struct it.overlay_strings_charpos)
7632 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7633 * xdisp.c (forward_to_next_line_start)
7634 (back_to_previous_visible_line_start)
7635 (reseat_at_next_visible_line_start, next_element_from_buffer):
7636 Don't arbitrarily truncate the value of 'selective' to int.
7637
76031fad
PE
7638 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7639
5eb55db9
PE
7640 * composite.c: Don't truncate sizes to 'int'.
7641 (composition_gstring_p, composition_reseat_it)
7642 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7643 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7644 not EMACS_UINT, for indexes.
5eb55db9 7645
0703a717
PE
7646 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7647
d6202519
PE
7648 * buffer.c: Include <verify.h>.
7649 (struct sortvec.priority, struct sortstr.priority):
8961a454 7650 Now EMACS_INT, not int.
c20998a7 7651 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7652 (struct sortstr.size, record_overlay_string)
7653 (struct sortstrlist.size, struct sortlist.used):
7654 Don't truncate size to int.
7655 (record_overlay_string): Check for size-calculation overflow.
d6202519 7656 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7657
d5a19415
JM
76582011-06-22 Jim Meyering <meyering@redhat.com>
7659
029529ac 7660 Don't leak an XBM-image-sized buffer
d5a19415
JM
7661 * image.c (xbm_load): Free the image buffer after using it.
7662
a9041e6c
PE
76632011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7664
7665 Port to Sun C.
7666 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7667 that Sun C diagnosed.
7668 * fns.c (secure_hash): Fix pointer signedness issue.
7669 * intervals.c (static_offset_intervals): New function.
7670 (offset_intervals): Use it.
7671
7f3f739f
LL
76722011-06-21 Leo Liu <sdl.web@gmail.com>
7673
7674 * deps.mk (fns.o):
7675 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7676 sha512.h.
7677
7678 * fns.c (secure_hash): Rename from crypto_hash_function and change
7679 the first arg to accept symbols.
5b66d427 7680 (Fsecure_hash): New primitive.
7f3f739f
LL
7681 (syms_of_fns): New symbols.
7682
76147d94
DD
76832011-06-20 Deniz Dogan <deniz@dogan.se>
7684
7685 * process.c (Fset_process_buffer): Clarify return value in
7686 docstring.
7687
7d7d0045
CY
76882011-06-18 Chong Yidong <cyd@stupidchicken.com>
7689
7690 * dispnew.c (add_window_display_history): Use BVAR.
7691
7692 * xdisp.c (debug_method_add): Use BVAR.
7693 (check_window_end, dump_glyph_matrix, dump_glyph)
7694 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7695
7696 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7697 Likewise.
7698
7699 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7700 check till after the cache is created in init_frame_faces.
7701
ff2bc410
SM
77022011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7703
7704 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7705
28177add
PE
77062011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7707
dd3482fe
PE
7708 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7709 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7710 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7711
393d71f3 7712 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7713 * fileio.c (Finsert_file_contents):
7714 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7715 Remove the old (too-loose) buffer overflow checks.
7716 They weren't needed, since make_gap checks for buffer overflow.
7717 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7718 The old code merely checked for Emacs fixnum overflow, and relied
7719 on undefined (wraparound) behavior. The new code avoids undefined
7720 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7721
2e6813b0 7722 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7723 Tune. Don't use wider integers than needed. Don't use alloca.
7724 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7725
599a9e4f
PE
7726 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7727
99561444
PE
7728 * insdel.c, lisp.h (buffer_overflow): New function.
7729 (insert_from_buffer_1, replace_range, replace_range_2):
7730 * insdel.c (make_gap_larger):
7731 * editfns.c (Finsert_char):
7732 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7733
28177add
PE
7734 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7735
e69dafad
PE
77362011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7737
4baa020d 7738 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7739
b1c46f02
PE
7740 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7741 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7742
e69dafad
PE
7743 * fileio.c: Don't assume EMACS_INT fits in off_t.
7744 (emacs_lseek): New static function.
7745 (Finsert_file_contents, Fwrite_region): Use it.
7746 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7747
566684ea
PE
7748 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7749
e6966cd6
PE
7750 * fns.c: Don't overflow int when computing a list length.
7751 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7752 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7753 truncation on 64-bit hosts. Check for QUIT every
7754 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7755 faster and is responsive enough.
7756 (Flength): Report an error instead of overflowing an integer.
7757 (Fsafe_length): Return a float if the value is not representable
7758 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7759 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7760 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7761
dd0b0efb
PE
7762 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7763 (header_size, word_size): New constants.
7764 (allocate_vectorlike): Don't check size overflow here.
7765 (allocate_vector): Check it here instead, since this is the only
7766 caller of allocate_vectorlike that could cause overflow.
7767 Check that the new vector's length is representable as a fixnum.
7768
86fe5cfe
PE
7769 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7770 The previous code was bogus. For example, next_almost_prime (32)
7771 returned 39, which is undesirable as it is a multiple of 3; and
7772 next_almost_prime (24) returned 25, which is a multiple of 5 so
7773 why was the code bothering to check for multiples of 7?
7774
80e88859
PE
7775 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7776
4a2f0ad6
PE
7777 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7778
f66c7cf8
PE
7779 Variadic C functions now count arguments with ptrdiff_t.
7780 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7781 Back then I didn't know that the Emacs coding style prefers signed int.
7782 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7783 were being counted with int, which may truncate counts on 64-bit
7784 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7785 * lisp.h (struct Lisp_Subr.function.aMANY)
7786 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7787 Arg counts are now ptrdiff_t, not size_t.
7788 All variadic functions and their callers changed accordingly.
7789 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7790 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7791 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7792 * callint.c (Fcall_interactively): Check arg count for overflow,
7793 to avoid potential buffer overrun. Use signed char, not 'int',
7794 for 'varies' array, so that we needn't bother to check its size
7795 calculation for overflow.
7796 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7797 * eval.c (apply_lambda):
7798 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7799 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7800 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7801
a1759b76
PE
7802 * callint.c (Fcall_interactively): Don't use index var as event count.
7803
d96be9fc
PE
7804 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7805 * mem-limits.h (SIZE): Remove; no longer used.
7806
a690a978 7807 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7808
578c21e6
PE
7809 Remove unnecessary casts.
7810 * xterm.c (x_term_init):
7811 * xfns.c (x_set_border_pixel):
7812 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7813 These aren't needed now that we assume ANSI C.
7814
96f53c6c
PE
7815 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7816 It's more likely to cause problems (due to unsigned overflow)
7817 than to cure them.
7818
83c77d31
PE
7819 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7820
ee2079f1
PE
7821 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7822
6da65536
PE
7823 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7824
7147c4a4
PE
7825 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7826
193e32d9
PE
7827 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7828
e5533da6
PE
7829 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7830
9910e595
PE
7831 GLYPH_CODE_FACE returns EMACS_INT, not int.
7832 * dispextern.h (merge_faces):
7833 * xfaces.c (merge_faces):
01103c44
PE
7834 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7835 Don't assume EMACS_INT fits in int.
9910e595 7836
2638320e
PE
7837 * character.h (CHAR_VALID_P): Remove unused parameter.
7838 * fontset.c, lisp.h, xdisp.c: All uses changed.
7839
045eb8d9
PE
7840 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7841
c1f134b5
PE
7842 * fns.c (concat): Minor tuning based on overflow analysis.
7843 This doesn't fix any bugs. Use int to hold character, instead
7844 of constantly refetching from Emacs object. Use XFASTINT, not
7845 XINT, for value known to be a character. Don't bother comparing
7846 a single byte to 0400, as it's always less.
7847
395fcb93 7848 * floatfns.c (Fexpt):
327eeec8
PE
7849 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7850
abbd3d23
PE
7851 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7852 for characters.
7853
684a03ef
PE
7854 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7855
0fed43f3
PE
7856 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7857 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7858 incorrectly succeed when S was a string, because 4294967386 was
7859 truncated before it was used.
7860
8fd02eb7
PE
7861 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7862 Otherwise, an out-of-range integer could cause undefined behavior
7863 on a 64-bit host.
7864
f8c86b69
PE
7865 * composite.c: Use int, not EMACS_INT, for characters.
7866 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7867 EMACS_INT, for values that are known to be in character range.
7868 This doesn't fix any bugs but is the usual style inside Emacs and
7869 may generate better code on 32-bit machines.
7870
34206dd2
PE
7871 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7872 This is for reasons similar to the recent CHAR_STRING fix.
7873 * charset.c (Fencode_char): Check that character arg is actually
7874 a character. Pass an int to ENCODE_CHAR.
7875 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7876 wider than 'int', as a compile-time check to prevent future regressions
7877 in this area.
7878
c5958d4c 7879 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7880
7881 Make sure a 64-bit char is never passed to CHAR_STRING.
7882 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7883 by silently ignoring the top 32 bits, allowing some values
7884 that were far too large to be valid characters.
7885 * character.h: Include <verify.h>.
7886 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7887 arguments are no wider than unsigned, as a compile-time check
7888 to prevent future regressions in this area.
7889 * data.c (Faset):
01103c44 7890 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7891 (Fsubst_char_in_region):
7892 * fns.c (concat):
7893 * xdisp.c (decode_mode_spec_coding):
7894 Adjust to CHAR_STRING's new requirement.
7895 * editfns.c (Finsert_char, Fsubst_char_in_region):
7896 * fns.c (concat): Check that character args are actually
7897 characters. Without this test, these functions did the wrong
7898 thing with wildly out-of-range values on 64-bit hosts.
7899
d37ca623
PE
7900 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7901 These casts should not be needed on 32-bit hosts, either.
7902 * keyboard.c (read_char):
7903 * lread.c (Fload): Remove casts to unsigned.
7904
ea204efb
PE
7905 * lisp.h (UNSIGNED_CMP): New macro.
7906 This fixes comparison bugs on 64-bit hosts.
7907 (ASCII_CHAR_P): Use it.
7908 * casefiddle.c (casify_object):
01103c44 7909 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7910 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7911 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7912 * dispextern.h (FACE_FROM_ID):
7913 * keyboard.c (read_char): Use UNSIGNED_CMP.
7914
41cb286c
PE
7915 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7916 not to EMACS_INT, to avoid GCC warning.
7917
4a1b9832
PE
7918 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7919
55daad71
PE
7920 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7921 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7922 isn't needed on 32-bit machines.
8f95c75c 7923
01103c44
PE
7924 * buffer.c (Fgenerate_new_buffer_name):
7925 Use EMACS_INT for count, not int.
0ceccced 7926 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7927
7928 * data.c (Qcompiled_function): Now static.
7929
c6f072e7
PE
7930 * window.c (window_body_lines): Now static.
7931
20ce5912
PE
7932 * image.c (gif_load): Rename local to avoid shadowing.
7933
9c4c5f81
PE
7934 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7935 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7936 * alloc.c (make_save_value): Integer argument is now of type
7937 ptrdiff_t, not int.
7938 (mark_object): Use ptrdiff_t, not int.
7939 * lisp.h (pD): New macro.
7940 * print.c (print_object): Use it.
7941
c0c5c8ae
PE
7942 * alloc.c: Use EMACS_INT, not int, to count objects.
7943 (total_conses, total_markers, total_symbols, total_vector_size)
7944 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7945 (total_free_floats, total_floats, total_free_intervals)
7946 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7947 Now EMACS_INT, not int. All uses changed.
7948 (Fgarbage_collect): Compute overall total using a double, so that
7949 integer overflow is less likely to be a problem. Check for overflow
7950 when converting back to an integer.
5a25e253
PE
7951 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7952 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7953 These were 'int' variables that could overflow on 64-bit hosts;
7954 they were never used, so remove them instead of repairing them.
211a0b2a 7955 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7956 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7957 Previously, this ceilinged at INT_MAX, but that doesn't work on
7958 64-bit machines.
e46bb31a 7959 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7960
c78baabf 7961 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7962 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7963 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7964 when a (possibly-narrower) signed value would do just as well.
7965 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7966
c9d624c6
PE
7967 * alloc.c: Catch some string size overflows that we were missing.
7968 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7969 for convenience in STRING_BYTES_MAX.
7970 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7971 The definition here is exact; the one in lisp.h was approximate.
7972 (allocate_string_data): Check for string overflow. This catches
7973 some instances we weren't catching before. Also, it catches
7974 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7975 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7976 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7977
c9d624c6
PE
7978 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7979 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7980 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7981
353032ce
PE
7982 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7983
2bccce07
PE
7984 * alloc.c (Fmake_string): Check for out-of-range init.
7985
0ac30604
SM
79862011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7987
7988 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7989
c195f2de
JD
79902011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7991
7992 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7993 xg_get_default_scrollbar_width.
7994
7995 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7996 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7997 (style_changed_cb): Call update_theme_scrollbar_width and call
7998 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7999 all frames (Bug#8505).
8000 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8001 Call gtk_window_set_resizable if HAVE_GTK3.
8002 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8003 and height if HAVE_GTK3 (Bug#8505).
8004 (scroll_bar_width_for_theme): New variable.
8005 (update_theme_scrollbar_width): New function.
8006 (xg_get_default_scrollbar_width): Move code to
8007 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8008 (xg_initialize): Call update_theme_scrollbar_width.
8009
8010 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8011
8012 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8013
e10ac9f1
MR
80142011-06-12 Martin Rudalics <rudalics@gmx.at>
8015
8016 * frame.c (make_frame): Call other_buffer_safely instead of
8017 other_buffer.
8018
8019 * window.c (temp_output_buffer_show): Call display_buffer with
8020 second argument Vtemp_buffer_show_specifiers and reset latter
8021 immediately after the call.
8022 (Vtemp_buffer_show_specifiers): New variable.
8023 (auto_window_vscroll_p, next_screen_context_lines)
8024 (Vscroll_preserve_screen_position): Remove leading asterisks from
8025 doc-strings.
8026
2d3c217e 80272011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8028
7b7f97e8 8029 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8030 * buffer.c (Qclone_number): Remove for now, as it's unused.
8031 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8032 (record_buffer): Remove unused local.
8033 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8034 (set_frame_buffer_list): Remove; unused.
8035 * frame.h (other_visible_frames): Remove decl.
8036 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8037 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8038 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8039 if HAVE_GPM.
8040 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8041 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8042 Define only if HAVE_GPM.
8043 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8044 (update_hints_inhibit): Remove; never set. All uses removed.
8045 * widgetprv.h (emacsFrameClassRec): Remove decl.
8046 * window.c (delete_deletable_window): Now returns void, since it
8047 wasn't returning anything.
8048 (compare_window_configurations): Remove unused locals.
8049 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8050 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8051 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8052 the same widths as pointers. This follows up on the 2011-05-06 patch.
8053 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8054 * xterm.h: Likewise.
8055 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8056
1384b89e
JB
80572011-06-12 Juanma Barranquero <lekktu@gmail.com>
8058
8059 * makefile.w32-in: Update dependencies.
8060 (LISP_H): Add lib/intprops.h.
8061
1100a63c
CY
80622011-06-11 Chong Yidong <cyd@stupidchicken.com>
8063
8064 * image.c (gif_load): Add animation frame delay to the metadata.
8065 (syms_of_image): Use DEFSYM. New symbol `delay'.
8066
6198ccd0
MR
80672011-06-11 Martin Rudalics <rudalics@gmx.at>
8068
8069 * window.c (delete_deletable_window): Re-add.
8070 (Fset_window_configuration): Rewrite to handle dead buffers and
8071 consequently deletable windows.
8072 (window_tree, Fwindow_tree): Remove. Supply functionality in
8073 window.el.
8074 (compare_window_configurations): Simplify code.
8075
b6e3633c
AS
80762011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8077
1ab0dee5
AS
8078 * image.c (imagemagick_load_image): Fix type mismatch.
8079 (Fimagemagick_types): Likewise.
8080
b6e3633c
AS
8081 * window.h (replace_buffer_in_windows): Declare.
8082
9397e56f
MR
80832011-06-11 Martin Rudalics <rudalics@gmx.at>
8084
8085 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8086 Qclone_number. Remove external declaration of Qdelete_window.
8087 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8088 code.
640c8776
SM
8089 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8090 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8091 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8092 buffer list implementation.
8093 (other_buffer_safely): New function.
8094 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8095 calls to replace_buffer_in_windows and
8096 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8097 if allowed.
8098 (record_buffer): Inhibit quitting and rewrite using quittable
8099 functions. Run Qbuffer_list_update_hook if allowed.
8100 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8101 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8102 Move switch-to-buffer to window.el.
9397e56f
MR
8103 (bury-buffer): Move to window.el.
8104 (Vbuffer_list_update_hook): New variable.
8105
8106 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8107 section.
8108
8109 * window.h (resize_frame_windows): Move up in code.
8110 (Fwindow_frame): Remove EXFUN.
8111 (replace_buffer_in_all_windows): Remove prototype.
8112 (replace_buffer_in_windows_safely): Add prototype.
8113
8114 * window.c: Declare Qdelete_window static again. Move down
8115 declaration of select_count.
8116 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8117 (Fother_window): Move to window.el.
8118 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8119 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8120 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8121 window.el.
8122 (replace_buffer_in_windows): Implement by calling
8123 Qreplace_buffer_in_windows.
8124 (replace_buffer_in_all_windows): Remove with some functionality
8125 moved into replace_buffer_in_windows_safely.
8126 (replace_buffer_in_windows_safely): New function.
8127 (select_window_norecord, select_frame_norecord): Move in front
8128 of run_window_configuration_change_hook. Remove now obsolete
8129 declarations.
640c8776
SM
8130 (Fset_window_buffer): Rewrite doc-string.
8131 Call Qrecord_window_buffer.
9397e56f
MR
8132 (keys_of_window): Move binding for other-window to window.el.
8133
b50691aa
CY
81342011-06-11 Chong Yidong <cyd@stupidchicken.com>
8135
8136 * dispextern.h (struct image): Replace data member, whose int_val
8137 and ptr_val fields were not used by anything, with a single
8138 lisp_val object.
8139
8140 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8141 (gif_clear_image, gif_load, imagemagick_load_image)
8142 (gs_clear_image, gs_load): Callers changed.
8143
3f754b86
PE
81442011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8145
cca69397
PE
8146 * buffer.h: Include <time.h>, for time_t.
8147 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8148
109e28d0
PE
8149 Fix minor problems found by static checking.
8150
60737f02
PE
8151 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8152
4b66faf3
PE
8153 Make identifiers static if they are not used in other modules.
8154 * data.c (Qcompiled_function, Qframe, Qvector):
8155 * image.c (QimageMagick, Qsvg):
8156 * minibuf.c (Qmetadata):
8157 * window.c (resize_window_check, resize_root_window): Now static.
8158 * window.h (resize_window_check, resize_root_window): Remove decls.
8159
109e28d0
PE
8160 * window.c (window_deletion_count, delete_deletable_window):
8161 Remove; unused.
46a4ce9e
PE
8162 (window_body_lines): Now static.
8163 (Fdelete_other_windows_internal): Mark vars as initialized.
8164 Make sure 'resize_failed' is initialized.
8165 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8166 (resize_window_apply): Remove unused local.
8167 * window.h (delete_deletable_window): Remove decl.
8168
109e28d0 8169 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8170 (imagemagick_load_image): Fix pointer signedness problem by changing
8171 last arg from unsigned char * to char *. All uses changed.
8172 Also, fix a local for similar reasons.
8173 Remove unused locals. Remove locals to avoid shadowing.
8174 (fn_rsvg_handle_free): Remove; unused.
8175 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8176 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8177
3f754b86
PE
8178 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8179
2547adb1
CY
81802011-06-10 Chong Yidong <cyd@stupidchicken.com>
8181
8182 * image.c (gif_load): Fix omitted cast error introduced by
8183 2011-06-06 change.
8184
2c8e37d4
MR
81852011-06-10 Martin Rudalics <rudalics@gmx.at>
8186
8187 * window.h (resize_proportionally, orig_total_lines)
8188 (orig_top_line): Remove from window structure.
8189 (set_window_height, set_window_width, change_window_heights)
8190 (Fdelete_window): Remove prototypes.
8191 (resize_frame_windows): Remove duplicate declaration.
8192
440a42e3
EZ
81932011-06-10 Eli Zaretskii <eliz@gnu.org>
8194
8195 * window.h (resize_frame_windows, resize_window_check)
8196 (delete_deletable_window, resize_root_window)
8197 (resize_frame_windows): Declare prototypes.
8198
8199 * window.c (resize_window_apply): Make definition be "static" to
8200 match the prototype.
8201
562dd5e9
MR
82022011-06-10 Martin Rudalics <rudalics@gmx.at>
8203
8204 * window.c: Remove declarations of Qwindow_size_fixed,
8205 window_min_size_1, window_min_size_2, window_min_size,
8206 size_window, window_fixed_size_p, enlarge_window, delete_window.
8207 Remove static from declaration of Qdelete_window, it's
8208 temporarily needed by Fbury_buffer.
8209 (replace_window): Don't assign orig_top_line and
8210 orig_total_lines.
8211 (Fdelete_window, delete_window): Remove. Window deletion is
8212 handled by window.el.
640c8776
SM
8213 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8214 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8215 (Fdelete_other_windows): Remove. Deleting other windows is
8216 handled by window.el.
8217 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8218 handled in window.el.
8219 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8220 Window minimum sizes are handled in window.el.
8221 (shrink_windows, size_window, set_window_height)
8222 (set_window_width, change_window_heights, window_height)
8223 (window_width, CURBEG, CURSIZE, enlarge_window)
8224 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8225 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8226 handled in window.el.
8227 (make_dummy_parent): Rename to make_parent_window and give it a
8228 second argument horflag.
8229 (make_window): Don't set resize_proportionally any more.
8230 (Fsplit_window): Remove. Windows are split in window.el.
8231 (save_restore_action, save_restore_orig_size)
8232 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8233 Resize mini windows in window.el.
8234 (grow_mini_window, shrink_mini_window): Implement by calling
8235 Qresize_root_window_vertically, resize_window_check and
8236 resize_window_apply.
640c8776
SM
8237 (saved_window, Fset_window_configuration, save_window_save):
8238 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8239 resize_proportionally.
8240 (window_min_height, window_min_width): Move to window.el.
8241 (keys_of_window): Move bindings for delete-other-windows,
8242 split-window, delete-window and enlarge-window to window.el.
8243
8244 * buffer.c: Temporarily extern Qdelete_window.
8245 (Fbury_buffer): Temporarily call Qdelete_window instead of
8246 Fdelete_window (Fbury_buffer will move to window.el soon).
8247
8248 * frame.c (set_menu_bar_lines_1): Remove code handling
8249 orig_top_line and orig_total_lines.
8250
8251 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8252 set_window_height but set heights directly.
8253 (change_frame_size_1): Use resize_frame_windows.
8254
8255 * xdisp.c (init_xdisp): Don't use set_window_height but set
8256 heights directly.
8257
640c8776
SM
8258 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8259 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8260 run_window_configuration_change_hook.
8261
8262 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8263 instead of change_window_heights and run
8264 run_window_configuration_change_hook.
8265
1a13852e
MR
82662011-06-09 Martin Rudalics <rudalics@gmx.at>
8267
8268 * window.c (replace_window): Rename second argument REPLACEMENT to
8269 NEW. New third argument SETFLAG. Rewrite.
8270 (delete_window, make_dummy_parent): Call replace_window with
8271 third argument 1.
8272 (window_list_1): Move down in code.
8273 (run_window_configuration_change_hook): Move set_buffer part
8274 before select_frame_norecord part in order to unwind correctly.
8275 Rename count1 to count.
8276 (recombine_windows, delete_deletable_window, resize_root_window)
8277 (Fdelete_other_windows_internal)
8278 (Frun_window_configuration_change_hook, make_parent_window)
8279 (resize_window_check, resize_window_apply, Fresize_window_apply)
8280 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8281 (Fdelete_window_internal, Fresize_mini_window_internal):
8282 New functions.
1a13852e
MR
8283 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8284
f3d1777e
MR
82852011-06-08 Martin Rudalics <rudalics@gmx.at>
8286
496e208e
MR
8287 * window.h (window): Add some new members to window structure -
8288 normal_lines, normal_cols, new_total, new_normal, clone_number,
8289 splits, nest, prev_buffers, next_buffers.
8290 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8291 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8292
f3d1777e
MR
8293 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8294 Remove.
496e208e
MR
8295 (make_dummy_parent): Set new members of windows structure.
8296 (make_window): Move down in code. Handle new members of window
8297 structure.
8298 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8299 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8300 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8301 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8302 (Fset_window_next_buffers, Fset_window_clone_number):
8303 New functions.
496e208e
MR
8304 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8305 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8306 Doc-string fixes.
8307 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8308 Argument WINDOW can be now internal window too.
8309 (Fwindow_use_time): Move up in code.
8310 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8311 Rewrite doc-string.
8312 (Fset_window_configuration, saved_window)
8313 (Fcurrent_window_configuration, save_window_save): Handle new
8314 members of window structure.
b9e809c2
MR
8315 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8316 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8317 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8318 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8319 Qget_mru_window, Qresize_root_window,
8320 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8321 Qauto_buffer_name; staticpro them.
f3d1777e 8322
abde8f8c
MR
83232011-06-07 Martin Rudalics <rudalics@gmx.at>
8324
8325 * window.c (Fwindow_total_size, Fwindow_left_column)
8326 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8327 (Fwindow_list_1): New functions.
8328 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8329 (Fwindow_width, Fscroll_left, Fscroll_right):
8330 Use window_body_cols instead of window_box_text_cols.
8331 (delete_window, Fset_window_configuration):
8332 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8333 (delete_all_subwindows): Take a window as argument and not a
8334 structure. Rewrite.
190b47e6
MR
8335 (window_loop): Remove handling of GET_LRU_WINDOW and
8336 GET_LARGEST_WINDOW.
8337 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8338
8339 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8340 window_box_text_cols. delete_all_subwindows now takes a
8341 Lisp_Object as argument.
abde8f8c 8342
640c8776
SM
8343 * indent.c (compute_motion, Fcompute_motion):
8344 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8345
fa8a67e6
MR
8346 * frame.c (delete_frame): Call delete_all_subwindows with root
8347 window as argument.
8348
a54e3482
DC
83492011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8350
8351 * fns.c (Fputhash): Document return value.
8352
60002bf5
CY
83532011-06-06 Chong Yidong <cyd@stupidchicken.com>
8354
8355 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8356
0c671da6 83572011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8358
b862a52a 8359 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8360
be44ca6c
PE
8361 Check for overflow when converting integer to cons and back.
8362 * charset.c (Fdefine_charset_internal, Fdecode_char):
8363 Use cons_to_unsigned to catch overflow.
8364 (Fencode_char): Use INTEGER_TO_CONS.
8365 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8366 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8367 * data.c (long_to_cons, cons_to_long): Remove.
8368 (cons_to_unsigned, cons_to_signed): New functions.
8369 These signal an error for invalid or out-of-range values.
8370 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8371 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8372 * font.c (Ffont_variation_glyphs):
8373 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8374 * lisp.h: Include <intprops.h>.
8375 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8376 (cons_to_signed, cons_to_unsigned): New decls.
8377 (long_to_cons, cons_to_long): Remove decls.
8378 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8379 (Fprimitive_undo): Use CONS_TO_INTEGER.
8380 * xfns.c (Fx_window_property): Likewise.
8381 * xselect.c: Include <limits.h>.
8382 (x_own_selection, selection_data_to_lisp_data):
8383 Use INTEGER_TO_CONS.
8384 (x_handle_selection_request, x_handle_selection_clear)
8385 (x_get_foreign_selection, Fx_disown_selection_internal)
8386 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8387 (lisp_data_to_selection_data): Use cons_to_unsigned.
8388 (x_fill_property_data): Use cons_to_signed.
8389 Report values out of range.
8390
d1f3d2af
PE
8391 Check for buffer and string overflow more precisely.
8392 * buffer.h (BUF_BYTES_MAX): New macro.
8393 * lisp.h (STRING_BYTES_MAX): New macro.
8394 * alloc.c (Fmake_string):
8395 * character.c (string_escape_byte8):
8396 * coding.c (coding_alloc_by_realloc):
8397 * doprnt.c (doprnt):
8398 * editfns.c (Fformat):
8399 * eval.c (verror):
8400 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8401 since they may not be the same number.
8402 * editfns.c (Finsert_char):
8403 * fileio.c (Finsert_file_contents):
8404 Likewise for BUF_BYTES_MAX.
8405
dd52fcea
PE
8406 * image.c: Use ptrdiff_t, not int, for sizes.
8407 (slurp_file): Switch from int to ptrdiff_t.
8408 All uses changed.
8409 (slurp_file): Check that file size fits in both size_t (for
8410 malloc) and ptrdiff_t (for sanity and safety).
8411
7f9bbdbb
PE
8412 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8413 if b->modtime has its maximal value.
8414
dfe18f82
PE
8415 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8416
84acfcf0
PE
8417 Don't assume time_t can fit into int.
8418 * buffer.h (struct buffer.modtime): Now time_t, not int.
8419 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8420 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8421
ccd9a01a
PE
8422 Minor fixes for signed vs unsigned integers.
8423 * character.h (MAYBE_UNIFY_CHAR):
8424 * charset.c (maybe_unify_char):
8425 * keyboard.c (read_char, reorder_modifiers):
8426 XINT -> XFASTINT, since the integer must be nonnegative.
8427 * ftfont.c (ftfont_spec_pattern):
8428 * keymap.c (access_keymap, silly_event_symbol_error):
8429 XUINT -> XFASTINT, since the integer must be nonnegative.
8430 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8431 since it makes no difference and we prefer signed.
8432 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8433 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8434 nonnegative.
8435
d6d100dd
SM
84362011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8437
8438 * window.h (Fwindow_frame): Declare.
8439
2b6148e4
PE
84402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8441
8442 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8443 (SPARE_MEMORY): Always define.
8444 (LARGE_REQUEST): Remove.
8445 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8446
f230ecc9
MR
84472011-06-06 Martin Rudalics <rudalics@gmx.at>
8448
727e958e
MR
8449 * lisp.h: Move EXFUNS for Fframe_root_window,
8450 Fframe_first_window and Fset_frame_selected_window to window.h.
8451
8452 * window.h: Move EXFUNS for Fframe_root_window,
8453 Fframe_first_window and Fset_frame_selected_window here from
8454 lisp.h.
8455
8456 * frame.c (Fwindow_frame, Fframe_first_window)
8457 (Fframe_root_window, Fframe_selected_window)
8458 (Fset_frame_selected_window): Move to window.c.
8459 (Factive_minibuffer_window): Move to minibuf.c.
8460 (Fother_visible_frames_p): New function.
8461
8462 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8463
f230ecc9
MR
8464 * window.c (decode_window, decode_any_window): Move up in code.
8465 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8466 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8467 (Fwindow_buffer): Move up and rewrite doc-string.
8468 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8469 (Fwindow_prev): New functions.
727e958e
MR
8470 (Fwindow_frame): Move here from frame.c. Accept any window as
8471 argument.
8472 (Fframe_root_window, Fframe_first_window)
8473 (Fframe_selected_window): Move here from frame.c. Accept frame
8474 or arbitrary window as argument. Update doc-strings.
8475 (Fminibuffer_window): Move up in code.
8476 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8477 (Fset_frame_selected_window): Move here from frame.c.
8478 Marginal rewrite.
727e958e
MR
8479 (Fselected_window, select_window, Fselect_window): Move up in
8480 code. Minor doc-string fixes.
f230ecc9 8481
4d09bcf6
PE
84822011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8483
8484 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8485 Do not assume that spare memory exists; that assumption is valid
8486 only if SYSTEM_MALLOC.
8487 (LARGE_REQUEST): New macro, so that the issue of large requests
8488 is separated from the issue of spare memory.
8489
810928a2
AS
84902011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8491
172418ad
AS
8492 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8493 format. (Bug#8806)
8494
43f862f7
AS
8495 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8496
810928a2
AS
8497 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8498 before statements.
8499
a059fe24
JD
85002011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8501
8502 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8503
8504 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8505
8506 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8507 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8508
989bf368
JB
85092011-06-05 Juanma Barranquero <lekktu@gmail.com>
8510
8511 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8512
4b80f674
CY
85132011-06-04 Chong Yidong <cyd@stupidchicken.com>
8514
8515 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8516 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8517 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8518 New error handlers.
4b80f674
CY
8519 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8520 Obey Vx_select_enable_clipboard_manager. Catch errors in
8521 x_clipboard_manager_save (Bug#8779).
8522 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8523 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8524
99a33b77 85252011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8526
8527 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8528
99a33b77 85292011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8530
8531 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8532 in the current matrix if keep_current_p is non-zero.
8533
8264569d
EZ
85342011-06-04 Eli Zaretskii <eliz@gnu.org>
8535
8536 * bidi.c (bidi_level_of_next_char): Fix last change.
8537
57f97249
EZ
85382011-06-03 Eli Zaretskii <eliz@gnu.org>
8539
fec2107c 8540 Support bidi reordering of text covered by display properties.
57f97249 8541
fec2107c
EZ
8542 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8543 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8544 (bidi_cache_search, bidi_cache_iterator_state)
8545 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8546 (bidi_level_of_next_char, bidi_move_to_visually_next):
8547 Support character positions inside a run of characters covered by a
fec2107c
EZ
8548 display string.
8549 (bidi_paragraph_init, bidi_resolve_explicit_1)
8550 (bidi_level_of_next_char): Call bidi_fetch_char and
8551 bidi_fetch_char_advance instead of FETCH_CHAR and
8552 FETCH_CHAR_ADVANCE.
8553 (bidi_init_it): Initialize new members.
8554 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8555 definitions.
8556 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8557 instead of using explicit *_CHAR codes.
d6d100dd
SM
8558 (bidi_resolve_explicit, bidi_resolve_weak):
8559 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8560 bidirectional text is supported only in multibyte buffers.
8561 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8562 it to initialize the frame_window_p member of struct bidi_it.
8563 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8564 (bidi_resolve_explicit, bidi_resolve_weak)
8565 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8566 bidi_it->nchars is non-positive.
8567 (bidi_level_of_next_char): Don't try to lookup the cache for the
8568 next/previous character if nothing is cached there yet, or if we
8569 were just reseat()'ed to a new position.
c40e2fb2 8570
0e14fe90
EZ
8571 * xdisp.c (set_cursor_from_row): Set start and stop points
8572 according to the row's direction when priming the loop that looks
8573 for the glyph on which to display cursor.
8574 (single_display_spec_intangible_p): Function deleted.
8575 (display_prop_intangible_p): Reimplement to call
8576 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8577 Accept 3 additional arguments needed by handle_display_spec.
8578 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8579 values: lists, `(when COND...)' forms, etc.
8580 (single_display_spec_string_p): Support property values that are
8581 lists with the argument STRING its top-level element.
8582 (display_prop_string_p): Fix the condition for processing a
8583 property that is a list to be consistent with handle_display_spec.
fec2107c 8584 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8585 last portion of handle_display_prop.
8586 (compute_display_string_pos): Accept additional argument
8587 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8588 value of a `display' property is a "replacing spec".
8589 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8590 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8591 the display property, but just return a value indicating whether
8592 the display property will replace the characters it covers.
8593 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8594 frame_window_p members of struct bidi_it.
d6d100dd
SM
8595 (compute_display_string_pos, compute_display_string_end):
8596 New functions.
fec2107c
EZ
8597 (push_it): Accept second argument POSITION, where pop_it should
8598 jump to continue iteration.
8599 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8600
fec2107c
EZ
8601 * keyboard.c (adjust_point_for_property): Adjust the call to
8602 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8603
8604 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8605 (bidi_init_it): Update prototypes.
8606 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8607 (compute_display_string_pos, compute_display_string_end):
8608 Declare prototypes.
fec2107c
EZ
8609 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8610 EMACS_INT.
fc6f18ce 8611
40087514 86122011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8613
57f53182
PE
8614 Malloc failure behavior now depends on size of allocation.
8615 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8616 * lisp.h: Change signatures accordingly.
8617 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8618 All callers changed. (Bug#8762)
8619
8620 * gnutls.c: Use Emacs's memory allocators.
8621 Without this change, the gnutls library would invoke malloc etc.
8622 directly, which causes problems on non-SYNC_INPUT hosts, and which
8623 runs afoul of improving memory_full behavior. (Bug#8761)
8624 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8625 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8626 xfree instead of the default malloc, realloc, free.
8627 (Fgnutls_boot): No need to check for memory allocation failure,
8628 since xmalloc does that for us.
8629
ac32cd99 8630 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8631 * category.c (hash_get_category_set):
8632 * ccl.c (ccl_driver):
8633 * charset.c (Fdefine_charset_internal):
8634 * charset.h (struct charset.hash_index):
8635 * composite.c (get_composition_id, gstring_lookup_cache)
8636 (composition_gstring_put_cache):
8637 * composite.h (struct composition.hash_index):
8638 * dispextern.h (struct image.hash):
8639 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8640 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8641 (hashfn_equal, hashfn_user_defined, make_hash_table)
8642 (maybe_resize_hash_table, hash_lookup, hash_put)
8643 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8644 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8645 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8646 * image.c (make_image, search_image_cache, lookup_image)
8647 (xpm_put_color_table_h):
8648 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8649 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8650 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8651 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8652 * alloc.c (allocate_vectorlike):
8653 Check for overflow in vector size calculations.
8654 * ccl.c (ccl_driver):
8655 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8656 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8657 need to be updated by these changes.
40087514
PE
8658 * fns.c (make_hash_table, maybe_resize_hash_table):
8659 Check for integer overflow with large hash tables.
0de4bb68
PE
8660 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8661 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8662 (SXHASH_REDUCE): New macro.
8663 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8664 Use it instead of discarding useful hash info with large hash values.
8665 (sxhash_float): New function.
8666 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8667 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8668 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8669 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8670 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8671 Adjust signatures to match updated version of code.
8672 (consing_since_gc): Now EMACS_INT, since a single hash table can
8673 use more than INT_MAX bytes.
8674
698d32e2
DN
86752011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8676
8677 Make it possible to build with GCC-4.6+ -O2 -flto.
8678
8679 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8680
fd6fa53f
SM
86812011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8682
8683 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8684 Call minibuffer-inactive-mode.
8685
864db017
JB
86862011-05-31 Juanma Barranquero <lekktu@gmail.com>
8687
8688 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8689 Update dependencies.
8690
2ad0baf4
DN
86912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8692
8693 * data.c (init_data): Remove code for UTS, this system is not
8694 supported anymore.
8695
4fcc2638
DN
86962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8697
8698 Don't force ./temacs to start in terminal mode.
8699
8700 * frame.c (make_initial_frame): Initialize faces in all cases, not
8701 only when CANNOT_DUMP is defined.
8702 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8703
c56e0fd5
DN
87042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8705
8706 * dispnew.c (add_window_display_history): Use const for the string
8707 pointer. Remove declaration, not needed.
8708
333d54da 87092011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8710
55d4c1b2 8711 Use 'inline', not 'INLINE'.
333d54da 8712 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8713 * alloc.c, fontset.c (INLINE): Remove.
8714 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8715 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8716 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8717 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8718 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8719
738db178
DN
87202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8721
8722 Make it possible to run ./temacs.
8723
8724 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8725 syms_of_callproc does the same thing. Remove test for
8726 "initialized", do it in the caller.
8727 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8728
620c53a6
SM
87292011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8730
8731 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8732 (read_minibuf): Use get_minibuffer.
8733 (syms_of_minibuf): Use DEFSYM.
8734 (Qmetadata): New var.
8735 * data.c (Qbuffer): Don't make it static.
8736 (syms_of_data): Use DEFSYM.
8737
e003a292
PE
87382011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8739
8740 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8741 (CCL_CODE_MIN): New macro.
8742
ed008a6d
PE
87432011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8744
3687c2ef
PE
8745 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8746
ed008a6d
PE
8747 * eval.c (Qdebug): Now static.
8748 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8749 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8750 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8751
d66c4c7c
CY
87522011-05-29 Chong Yidong <cyd@stupidchicken.com>
8753
8754 * image.c: Various fixes to ImageMagick code comments.
8755 (Fimagemagick_types): Doc fix.
8756
5fbc2025
PE
87572011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8758
0196f88a
PE
8759 Minor fixes prompted by GCC 4.6.0 warnings.
8760
8761 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8762
5fbc2025
PE
8763 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8764 (x_clipboard_manager_save_all): Move extern decl to ...
8765 * xterm.h: ... here, so that it can be checked for consistency.
8766
1dd3c2d9
CY
87672011-05-29 Chong Yidong <cyd@stupidchicken.com>
8768
8769 * xselect.c (x_clipboard_manager_save_frame)
8770 (x_clipboard_manager_save_all): New functions.
8771 (Fx_clipboard_manager_save): Lisp function deleted.
8772
8773 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8774 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8775
8776 * xterm.h: Update prototype.
8777
5ba6571d
WX
87782011-05-28 William Xu <william.xwl@gmail.com>
8779
8780 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8781 exiting (Bug#8239).
8782
3eaff834
JM
87832011-05-28 Jim Meyering <meyering@redhat.com>
8784
e1900994 8785 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8786 * fns.c (to_uchar): Define.
8787 (crypto_hash_function): Use it to convert some newly-signed
8788 variables to unsigned, to avoid sign-extension bugs. For example,
8789 without this change, (md5 "truc") would evaluate to
8790 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8791 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8792 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8793
0f6990a7
PE
87942011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8795
8796 Integer overflow fixes.
c8a9ca5a 8797
08686060
PE
8798 * dbusbind.c: Serial number integer overflow fixes.
8799 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8800 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8801 to hold a serial number that is too large for a fixnum.
8802 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8803 Check for serial numbers out of range. Decode any serial number
59568bf0 8804 that was so large that it became a float. (Bug#8722)
08686060 8805
2d1fc3c7
PE
8806 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8807 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8808 Use XFASTINT rather than XUINT when numbers are nonnegative.
8809 (xd_append_arg, Fdbus_method_return_internal):
8810 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8811 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8812 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8813 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8814 (Bug#8722)
2d1fc3c7 8815
c8a9ca5a
PE
8816 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8817
519e1d69
PE
8818 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8819
6df6ae42 8820 ccl: Add integer overflow checks.
30569699
PE
8821 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8822 (IN_INT_RANGE): New macros.
8823 (ccl_driver): Use them to check for integer overflow when
8824 decoding a CCL program. Many of the new checks are whether XINT (x)
8825 fits in int; it doesn't always, on 64-bit hosts. The new version
8826 doesn't catch all possible integer overflows, but it's an
847044ea 8827 improvement. (Bug#8719)
30569699 8828
c11285dc
PE
8829 * alloc.c (make_event_array): Use XINT, not XUINT.
8830 There's no need for unsigned here.
8831
fdccd48e
PE
8832 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8833 This follows up to the 2011-05-06 change that substituted uintptr_t
8834 for EMACS_INT. This case wasn't caught back then.
8835
37910ab2
PE
8836 Rework Fformat to avoid integer overflow issues.
8837 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8838 now (part of C89). Include <verify.h>.
8839 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8840 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8841 (Fformat): Avoid the prepass trying to compute sizes; it was only
8842 approximate and thus did not catch overflow reliably. Instead, walk
8843 through the format just once, formatting and computing sizes as we go,
8844 checking for integer overflow at every step, and allocating a larger
8845 buffer as needed. Keep track separately whether the format is
8846 multibyte. Keep only the most-recently calculated precision, rather
8847 than them all. Record whether each argument has been converted to
8848 string. Use EMACS_INT, not int, for byte and char and arg counts.
8849 Support field widths and precisions larger than INT_MAX. Avoid
8850 sprintf's undefined behavior with conversion specifications such as %#d
8851 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8852 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8853 formatting out-of-range floating point numbers with int
9173deec 8854 formats. (Bug#8668)
37910ab2 8855
2e6578fb
PE
8856 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8857
0ae6bdee
PE
8858 * data.c: Avoid integer truncation in expressions involving floats.
8859 * data.c: Include <intprops.h>.
8860 (arith_driver): When there's an integer overflow in an expression
8861 involving floating point, convert the integers to floating point
8862 so that the resulting value does not suffer from catastrophic
8863 integer truncation. For example, on a 64-bit host (* 4
8864 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8865 Do not rely on undefined behavior after integer overflow.
8866
de883a70
PE
8867 merge count_size_as_multibyte, parse_str_to_multibyte
8868 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8869 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8870 Check for integer overflow.
8871 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8872 since it's now a duplicate of the other. This is more of
8873 a character than a buffer op, so better that it's in character.c.
8874 * fns.c, print.c: Adjust to above changes.
8875
2ff916cb
PE
88762011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8877
8878 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8879
f1b54466
PE
88802011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8881
fb1ac845
PE
8882 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8883 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8884 (x_clipboard_manager_save): Now static.
8885 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8886
f1b54466
PE
8887 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8888 (crypto_hash_function): Now static.
8889 Fix pointer signedness problems. Avoid unnecessary initializations.
8890
a9f737ee
CY
88912011-05-27 Chong Yidong <cyd@stupidchicken.com>
8892
8893 * termhooks.h (Vselection_alist): Make it terminal-local.
8894
8895 * terminal.c (create_terminal): Initialize it.
8896
8897 * xselect.c: Support for clipboard managers.
8898 (Vselection_alist): Move to termhooks.h as terminal-local var.
8899 (LOCAL_SELECTION): New macro.
8900 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8901 (symbol_to_x_atom): Remove gratuitous arg.
8902 (x_handle_selection_request, lisp_data_to_selection_data)
8903 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8904 (x_own_selection, x_get_local_selection, x_convert_selection):
8905 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8906 (some_frame_on_display): Delete unused function.
8907 (Fx_own_selection_internal, Fx_get_selection_internal)
8908 (Fx_disown_selection_internal, Fx_selection_owner_p)
8909 (Fx_selection_exists_p): New optional frame arg.
8910 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8911 (x_handle_selection_clear): Don't treat other terminals with the
8912 same keyboard specially. Use the terminal-local Vselection_alist.
8913 (x_clear_frame_selections): Use Frun_hook_with_args.
8914
8915 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8916
8917 * xterm.h: Add support for those atoms.
8918
e067f0c1
CY
89192011-05-26 Chong Yidong <cyd@stupidchicken.com>
8920
8921 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8922 (converted_selections, conversion_fail_tag): New global variables.
8923 (x_selection_request_lisp_error): Free the above.
8924 (x_get_local_selection): Remove unnecessary code.
8925 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8926 of converted selections stored in converted_selections.
8927 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8928 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8929 (x_convert_selection): New function.
8930 (x_handle_selection_event): Simplify.
8931 (x_get_foreign_selection): Don't ignore incoming requests while
8932 waiting for an answer; this will fail when we implement
8933 SAVE_TARGETS, and seems unnecessary anyway.
8934 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8935 (Vx_sent_selection_functions): Doc fix.
8936
0f4aebc0
LL
89372011-05-26 Leo Liu <sdl.web@gmail.com>
8938
8939 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8940
e61124cd
YM
89412011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8942
8943 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8944
8945 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8946 for fringe update if it has periodic bitmap.
ac389d0c 8947 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8948 and fringe_bitmap_periodic_p.
8949
8950 * fringe.c (get_fringe_bitmap_data): New function.
8951 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8952 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8953 row. Mark glyph row for fringe update if periodicity changed.
8954
8955 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8956 for fringe update unless it has periodic bitmap.
8957
f16d9837
KH
89582011-05-25 Kenichi Handa <handa@m17n.org>
8959
8960 * xdisp.c (get_next_display_element): Set correct it->face_id for
8961 a static composition.
8962
e1b90ef6
LL
89632011-05-24 Leo Liu <sdl.web@gmail.com>
8964
8965 * deps.mk (fns.o):
8966 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8967
8968 * fns.c (crypto_hash_function, Fsha1): New function.
8969 (Fmd5): Use crypto_hash_function.
8970 (syms_of_fns): Add Ssha1.
8971
7400048f
PE
89722011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8973
8974 * gnutls.c: Remove unused macros.
8975 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8976 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8977 Remove macros that are defined and never used.
8978 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8979
abb71cf4
CY
89802011-05-22 Chong Yidong <cyd@stupidchicken.com>
8981
8982 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8983 (Fx_get_selection_internal): Minor cleanup.
8984 (Fx_own_selection_internal): Rename arguments for consistency with
8985 select.el.
8986
6307db39
PE
89872011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8988
8989 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8990
f3d4e0a4
CY
89912011-05-22 Chong Yidong <cyd@stupidchicken.com>
8992
8993 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8994
4d8ade89
YM
89952011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8996
8997 * dispnew.c (scrolling_window): Don't exclude the case that the
8998 last enabled row in the desired matrix touches the bottom boundary.
8999
32078c8d
GM
90002011-05-21 Glenn Morris <rgm@gnu.org>
9001
9002 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9003 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9004 and add some more files.
32078c8d 9005
7285dc67
EZ
90062011-05-20 Eli Zaretskii <eliz@gnu.org>
9007
9008 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9009 report_file_error introduced by the change from 2011-05-07.
9010
89d1bd22
PE
90112011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9012
9013 * systime.h (Time): Define only if emacs is defined.
9014 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9015 where the include path doesn't have X11/X.h by default. See
9016 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9017
cd394be1 90182011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9019
9020 * composite.c (find_automatic_composition): Fix previous change.
9021
b9704ad9
GM
90222011-05-20 Glenn Morris <rgm@gnu.org>
9023
9024 * lisp.mk: New file, split from Makefile.in.
9025 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9026 (shortlisp): Remove.
9027 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9028
4a720484
GM
90292011-05-19 Glenn Morris <rgm@gnu.org>
9030
9031 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9032 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9033 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9034 (lisp): Set the order to that of loadup.el.
9035 (shortlisp): Make it a copy of $lisp.
9036 (SOME_MACHINE_LISP): Remove.
9037 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9038 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9039
a28d4396
KH
90402011-05-18 Kenichi Handa <handa@m17n.org>
9041
9042 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9043 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9044 (find_automatic_composition): Mostly rewrite for efficiency.
9045
a2b1fa8e
JB
90462011-05-18 Juanma Barranquero <lekktu@gmail.com>
9047
9048 * makefile.w32-in: Update dependencies.
9049
8e1f5610
CS
90502011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9051
9052 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9053 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9054
7025ee00 90552011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9056
cdfa6eab
PE
9057 Fix some integer overflow issues, such as string length overflow.
9058
06d6db33
PE
9059 * insdel.c (count_size_as_multibyte): Check for string overflow.
9060
2b4560a8
PE
9061 * character.c (lisp_string_width): Check for string overflow.
9062 Use EMACS_INT, not int, for string indexes and lengths; in
9063 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9064 the resulting string length overflows an EMACS_INT; instead,
9065 report a string overflow if no precision given. When checking for
9066 precision exhaustion, use a check that cannot possibly have
9067 integer overflow. (Bug#8675)
9068 * character.h (lisp_string_width): Adjust to new signature.
9069
cb93f9be
PE
9070 * alloc.c (string_overflow): New function.
9071 (Fmake_string): Use it. This doesn't change behavior, but saves
9072 a few bytes and will simplify future changes.
9073 * character.c (string_escape_byte8): Likewise.
9074 * lisp.h (string_overflow): New decl.
9075
1a1f3366
PE
9076 Fixups, following up to the user-interface timestamp change.
9077 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9078 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9079 * msdos.c (mouse_get_pos): Likewise.
9080 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9081 * w32gui.h (Time): Define by including "systime.h" rather than by
9082 declaring it ourselves. (Bug#8664)
9083
d4e3e4d3
PE
9084 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9085 * image.c (clear_image_cache): Likewise.
9086
f6a24d19
PE
9087 * term.c (term_mouse_position): Don't assume time_t wraparound.
9088
08dc5ae6
PE
9089 Be more systematic about user-interface timestamps.
9090 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9091 and sometimes 'EMACS_UINT', to represent these timestamps.
9092 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9093 This makes the code easier to follow, and makes it easier to catch
9094 integer overflow bugs such as Bug#8664.
9095 * frame.c (Fmouse_position, Fmouse_pixel_position):
9096 Use Time, not unsigned long, for user-interface timestamps.
9097 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9098 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9099 * keyboard.h (last_event_timestamp): Likewise.
9100 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9101 * menu.h (xmenu_show): Likewise.
9102 * term.c (term_mouse_position): Likewise.
9103 * termhooks.h (struct input_event.timestamp): Likewise.
9104 (struct terminal.mouse_position_hook): Likewise.
9105 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9106 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9107 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9108 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9109 what it was before.
9110 * menu.h, termhooks.h: Include "systime.h", for Time.
9111
8e55734a
PE
9112 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9113 Don't assume that the difference between two unsigned long values
9114 can fit into an integer. At this point, we know button_down_time
9115 <= event->timestamp, so the difference must be nonnegative, so
9116 there's no need to cast the result if double-click-time is
9117 nonnegative, as it should be; check that it's nonnegative, just in
9118 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9119 apart (about 25 days). (Bug#8664)
8e55734a 9120
841f1b75 9121 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9122 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9123
3e26f69c
PE
9124 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9125 that always fit in int. Use a sentinel instead of a counter, to
9126 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9127 * frame.h (struct frame): Use int for menu_bar_items_used
9128 instead of EMACS_INT, since it always fits in int.
3e26f69c 9129
5cc152c0
PE
9130 * menu.c (grow_menu_items): Check for int overflow.
9131
d89eb65e
PE
9132 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9133
5235bd3e
PE
9134 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9135 Before, the code was not consistent. These values cannot exceed
9136 2**31 - 1 so there's no need to make them unsigned.
9137 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9138 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9139 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9140 as modifiers.
9141 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9142
bc827e23
PE
9143 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9144 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9145 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9146 presumably because the widths might not match.
9147
78eb494e
PE
9148 * window.c (size_window): Avoid needless test at loop start.
9149
04f2d78b
CB
91502011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9151
9152 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9153
d2fc7e3d 91542011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9155
9156 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9157
d2fc7e3d 91582011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9159
9160 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9161 `width' to `bar_area_x' and `bar_area_width', respectively.
9162 (x_scroll_run): Take account of fringe background extension.
9163
04f2d78b
CB
9164 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9165 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9166 `bar_area_width', respectively.
9167 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9168 background extension.
9169
79b70037
GM
91702011-05-10 Jim Meyering <meyering@redhat.com>
9171
9172 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9173
2f142cc5
JB
91742011-05-10 Juanma Barranquero <lekktu@gmail.com>
9175
9176 * image.c (Finit_image_library): Return t for built-in image types,
9177 like pbm and xbm. (Bug#8640)
9178
57679c86
AS
91792011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9180
9181 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9182
888c9e86
EZ
91832011-05-07 Eli Zaretskii <eliz@gnu.org>
9184
b0512a1d
EZ
9185 * w32console.c (Fset_screen_color): Doc fix.
9186 (Fget_screen_color): New function.
9187 (syms_of_ntterm): Defsubr it.
9188
7285dc67
EZ
9189 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9190 unlink the temporary file if Fcall_process didn't create it in the
9191 first place.
9192 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9193 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9194 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9195 cue to call_process_cleanup not to close that handle.
9196
4d3fcc8e
BK
91972011-05-07 Ben Key <bkey76@gmail.com>
9198
9199 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9200 one of two shell specific rules, either bootstrap-temacs-CMD or
9201 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9202 to the previous implementation of the bootstrap-temacs rule.
9203 The bootstrap-temacs-CMD rule is similar to the previous
9204 implementation of the bootstrap-temacs rule except that it
9205 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9206 variable.
9207
9208 These changes, along with some changes to nt/configure.bat,
9209 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9210 earlier fix to add support for --cflags and --ldflags options
9211 that include quotes so that it works whether make uses cmd or
9212 sh as the shell.
9213
b4289b64
MA
92142011-05-06 Michael Albinus <michael.albinus@gmx.de>
9215
9216 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9217 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9218 is a constant.
9219 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9220 a string. Handle both cases.
9221 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9222 (Fdbus_register_method): Use Qinvalid_function.
9223
af4c0e28
JB
92242011-05-06 Juanma Barranquero <lekktu@gmail.com>
9225
9226 * makefile.w32-in: Update dependencies.
9227 (LISP_H): Add inttypes.h and stdin.h.
9228 (PROCESS_H): Add unistd.h.
9229
c51453d9
EZ
92302011-05-06 Eli Zaretskii <eliz@gnu.org>
9231
9232 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9233 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9234
8ff0ac3c 92352011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9236
4c4b566b
PE
9237 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9238
aab2b9b5
PE
9239 * term.c (vfatal): Remove stray call to va_end.
9240 It's not needed and the C Standard doesn't allow it here anyway.
9241
c378da0b
PE
9242 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9243 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9244
288b08c7
PE
9245 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9246 bytes.
9247
e3601888
PE
9248 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9249
db6c0e74
PE
9250 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9251
dd5963ea
PE
9252 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9253
88c9450f
PE
9254 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9255
2f9442b8
PE
9256 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9257
c032b5f8
PE
9258 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9259 * charset.c (Fdefine_charset_internal): Don't initialize
9260 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9261 32-bit int (Bug#8600).
a108c10b
PE
9262
9263 * lread.c (read_integer): Be more consistent with string-to-number.
9264 Use string_to_number to do the actual conversion; this avoids
9265 rounding errors and fixes some other screwups. Without this fix,
9266 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9267 (digit_to_number): Move earlier, for benefit of read_integer.
9268 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9269 not a digit in any supported base. (Bug#8602)
a108c10b 9270
ad5f9eea
PE
9271 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9272
aec1708a
PE
9273 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9274 to match comment at start of function. This also removes a
9275 GCC warning about overflow in a 32+64-bit port.
9276
47be4ab5
PE
9277 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9278
371cac43
PE
9279 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9280 Reported by Stefan Monnier in
9281 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9282 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9283 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9284
d01a7826
PE
9285 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9286 (EMACS_UINTPTR): Likewise, with uintptr_t.
9287
7fd47d5c
PE
9288 * lisp.h: Prefer 64-bit EMACS_INT if available.
9289 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9290 on 32-bit hosts that have 64-bit int, so that they can access
9291 large files.
122b0c86
PE
9292 However, temporarily disable this change unless the temporary
9293 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9294
8727937b
PE
9295 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9296
8ac068ac
PE
9297 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9298 This removes an assumption that EMACS_INT and long are the same
9299 width as pointers. The assumption is true for Emacs porting targets
9300 now, but we want to make other targets possible.
9301 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9302 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9303 In the rest of the code, change types of integers that hold casted
9304 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9305 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9306 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9307 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9308 No need to cast type when ORing.
9309 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9310 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9311 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9312 assume EMACS_INT is the same width as char *.
9313 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9314 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9315 Remove no-longer-needed casts.
9316 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9317 (xg_tool_bar_help_callback, xg_make_tool_item):
9318 Use EMACS_INTPTR to hold an integer
9319 that will be cast to void *; this can avoid a GCC warning
9320 if EMACS_INT is not the same width as void *.
9321 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9322 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9323 (current_message_1, set_message_1):
9324 Use a local to convert to proper width without a cast.
9325 * xmenu.c (dialog_selection_callback): Likewise.
9326
ede49d71
PE
9327 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9328 Also, don't assume VALBITS / RAND_BITS is less than 5,
9329 and don't rely on undefined behavior when shifting a 1 left into
9330 the sign bit.
9331 * lisp.h (get_random): Change signature to match.
9332
2f30ecd0
PE
9333 * lread.c (hash_string): Use size_t, not int, for hash computation.
9334 Normally we prefer signed values; but hashing is special, because
9335 it's better to use unsigned division on hash table sizes so that
9336 the remainder is nonnegative. Also, size_t is the natural width
9337 for hashing into memory. The previous code used 'int', which doesn't
9338 retain enough info to hash well into very large tables.
9339 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9340
2a866e7b
PE
9341 * dbusbind.c: Don't possibly lose pointer info when converting.
9342 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9343 Use XPNTR rather than XHASH, so that the high-order bits of
9344 the pointer aren't lost when converting through void *.
9345
51639eac
PE
9346 * eval.c (Fautoload): Don't double-shift a pointer.
9347
92394119
PE
9348 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9349
dbdb9a7c
JB
93502011-05-06 Juanma Barranquero <lekktu@gmail.com>
9351
9352 * gnutls.c (DEF_GNUTLS_FN):
9353 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9354
db7a0b4f
AS
93552011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9356
9357 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9358 marker. (Bug#8610)
9359
cd394be1 93602011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9361
9362 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9363 New version that can reserve upto 2GB of heap space.
9364
f7ff1b0f 93652011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9366
9367 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9368
639c109b
TZ
93692011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9370
9371 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9372 `gnutls_certificate_set_x509_key_file'.
9373
d2127135
JB
93742011-05-05 Juanma Barranquero <lekktu@gmail.com>
9375
9376 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9377 Update dependencies.
9378
e968f4f3
JB
93792011-05-04 Juanma Barranquero <lekktu@gmail.com>
9380
9381 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9382 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9383 Remove unused parameter `fildes'.
9384 * process.c (read_process_output, send_process): Don't pass it.
9385
84d358f0
JB
93862011-05-04 Juanma Barranquero <lekktu@gmail.com>
9387
9388 Fix previous change: the library cache is defined in w32.c.
9389 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9390 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9391
0898ca10
JB
93922011-05-04 Juanma Barranquero <lekktu@gmail.com>
9393
9394 Implement dynamic loading of GnuTLS on Windows.
9395
9396 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9397 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9398 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9399 Declare.
9400
9401 * gnutls.c (Qgnutls_dll): Define.
9402 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9403 (gnutls_*): Declare function pointers.
9404 (init_gnutls_functions): New function to initialize function pointers.
9405 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9406 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9407 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9408 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9409 (emacs_gnutls_write, emacs_gnutls_read)
9410 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9411 (Fgnutls_available_p): New function.
9412 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9413 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9414 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9415
9416 * image.c: Include w32.h.
9417 (Vimage_type_cache): Delete.
9418 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9419 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9420 (w32_delayed_load): Move to w32.c.
9421
9422 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9423
9424 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9425 (w32_delayed_load): Move from image.c. When loading a library, record
9426 its filename in the :loaded-from property of the library id.
9427 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9428 Initialize and staticpro them.
9429 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9430
9431 * process.c: Include lisp.h before w32.h, not after.
9432 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9433 instead of gnutls_record_check_pending.
9434
9435 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9436
ff4de4aa
TZ
94372011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9438
9439 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9440 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9441 as passed in.
9442
abe95abb
JD
94432011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9444
9445 * xterm.c (x_set_frame_alpha): Do not set property on anything
9446 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9447
e16e55d4
JB
94482011-05-02 Juanma Barranquero <lekktu@gmail.com>
9449
9450 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9451
bafcf6a5
JB
94522011-05-02 Juanma Barranquero <lekktu@gmail.com>
9453
9454 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9455 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9456 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9457 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9458 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9459 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9460 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9461 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9462 (Qgnutls_bootprop_callbacks_verify): Make static.
9463
e7a6747f
AS
94642011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9465
19ed11ba
AS
9466 * callproc.c: Indentation fixup.
9467
e7a6747f 9468 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9469 (wait_for_termination, interruptible_wait_for_termination):
9470 Move after wait_for_termination_1.
e7a6747f 9471
1ef14cb4
LMI
94722011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9473
9474 * sysdep.c (interruptible_wait_for_termination): New function
9475 which is like wait_for_termination, but allows keyboard
9476 interruptions.
9477
9478 * callproc.c (Fcall_process): Add (:file "file") as an option for
9479 the STDOUT buffer.
9480 (Fcall_process_region): Ditto.
9481
330d880c
EZ
94822011-04-30 Eli Zaretskii <eliz@gnu.org>
9483
8db90b73
EZ
9484 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9485 rather than `XVECTOR (FOO)->size'.
9486
330d880c
EZ
9487 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9488 inttypes.h, as a gnulib replacement is used if it not available in
9489 system headers.
9490
15cbd324
EZ
94912011-04-21 Eli Zaretskii <eliz@gnu.org>
9492
9493 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9494 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9495 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9496
9497 * coding.c (coding_alloc_by_realloc): Error out if destination
9498 will grow beyond MOST_POSITIVE_FIXNUM.
9499 (decode_coding_emacs_mule): Abort if there isn't enough place in
9500 charbuf for the composition carryover bytes. Reserve an extra
9501 space for up to 2 characters produced in a loop.
9502 (decode_coding_iso_2022): Abort if there isn't enough place in
9503 charbuf for the composition carryover bytes.
9504
95052011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9506
ae940cca
EZ
9507 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9508 aborting when %lld or %lll format is passed.
9509 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9510 %llo or %llx format is passed. (Bug#8545)
9511
03ab8921
EZ
9512 * window.c (window_scroll_line_based): Use a marker instead of
9513 simple variables to record original value of point. (Bug#7952)
9514
afda1437
EZ
9515 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9516 produced by %s or %c overflows available buffer space. (Bug#8545)
9517
f76dee0c
PE
95182011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9519
9520 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9521 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9522
fdc5744d
JB
95232011-04-28 Juanma Barranquero <lekktu@gmail.com>
9524
9525 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9526
638f053a
JB
95272011-04-28 Juanma Barranquero <lekktu@gmail.com>
9528
9529 * keyboard.c (Qdelayed_warnings_hook): Define.
9530 (command_loop_1): Run `delayed-warnings-hook'
9531 if Vdelayed_warnings_list is non-nil.
9532 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9533 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9534
d178f871
EZ
95352011-04-28 Eli Zaretskii <eliz@gnu.org>
9536
9537 * doprnt.c (doprnt): Don't return value smaller than the buffer
9538 size if the message was truncated. (Bug#8545).
9539
b124fd93
JB
95402011-04-28 Juanma Barranquero <lekktu@gmail.com>
9541
9542 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9543 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9544
e810457d
PE
95452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9546
9547 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9548
ea51cceb
JB
95492011-04-27 Juanma Barranquero <lekktu@gmail.com>
9550
9551 * makefile.w32-in: Update dependencies.
9552
94dcfacf
EZ
95532011-04-27 Eli Zaretskii <eliz@gnu.org>
9554
9555 Improve `doprnt' and its usage. (Bug#8545)
9556 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9557 `format_end'. Remove support for %l as a conversion specifier.
9558 Don't use xrealloc. Improve diagnostics when the %l size modifier
9559 is used. Update the commentary.
9560
9561 * eval.c (verror): Simplify calculation of size_t.
9562
9563 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9564 messages.
9565
f61f41d7
PE
95662011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9567
9568 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9569 change.
9570
96fb4434
PE
95712011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9572
9573 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9574 This makes this file independent of the recent pseudovector change.
9575
671875da 95762011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9577
69e9b5a3
PE
9578 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9579
b5f869a7 9580 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9581 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9582 Remove unused local.
c8926152 9583 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9584
841a1577 9585 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9586 GCC 4.6.0 optimizes based on type-based alias analysis.
9587 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9588 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9589 != &v->size, and therefore "v->size = 1; b->size = 2; return
9590 v->size;" must therefore return 1. This assumption is incorrect
9591 for Emacs, since it type-puns struct Lisp_Vector * with many other
9592 types. To fix this problem, this patch adds a new type struct
f904488f 9593 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9594 and pseudovectors, and helps optimizing compilers not get fooled
9595 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9596 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9597 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9598 the size member.
eab3844f
PE
9599 (XSETPVECTYPE): Rewrite in terms of new macro.
9600 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9601 This is a bit clearer, and further avoids the possibility of
9602 undesirable aliasing.
9603 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9604 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9605 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9606 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9607 (ASIZE): Now uses header.size rather than size.
9608 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9609 to avoid the hassle of writing XVECTOR (foo)->header.size.
9610 (struct vectorlike_header): New type.
eab3844f
PE
9611 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9612 object, to help avoid aliasing.
9613 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9614 (SUBRP): Likewise, since Lisp_Subr is a special case.
9615 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9616 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9617 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9618 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9619 changed to be "header.size" and "header.next".
9620 * buffer.h (struct buffer): Likewise.
9621 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9622 * frame.h (struct frame): Likewise.
9623 * process.h (struct Lisp_Process): Likewise.
9624 * termhooks.h (struct terminal): Likewise.
9625 * window.c (struct save_window_data, struct saved_window): Likewise.
9626 * window.h (struct window): Likewise.
9627 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9628 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9629 * buffer.c (init_buffer_once): Likewise.
9630 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9631 special case.
9632 * process.c (Fformat_network_address): Use local var for size,
9633 for brevity.
9634
0df1eac5
PE
9635 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9636
847ab9d1 9637 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9638 * data.c (atof): Remove decl; no longer used or needed.
9639 (digit_to_number): Move to lread.c.
9640 (Fstring_to_number): Use new string_to_number function, to be
9641 consistent with how the Lisp reader treats infinities and NaNs.
9642 Do not assume that floating-point numbers represent EMACS_INT
9643 without losing information; this is not true on most 64-bit hosts.
9644 Avoid double-rounding errors, by insisting on integers when
9645 parsing non-base-10 numbers, as the documentation specifies.
9646 * lisp.h (string_to_number): New decl, replacing ...
9647 (isfloat_string): Remove.
bc0a5c13 9648 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9649 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9650 appears to have been a coding error. Similarly, do not accept
9651 strings like +-1e0 as floating point numbers. Do not report
9652 overflow for integer overflows unless the base is not 10 which
9653 means we have no simple and reliable way to continue.
9654 Break out the floating-point parsing into a new
9655 function string_to_number, so that Fstring_to_number parses
9656 floating point numbers consistently with the Lisp reader.
04f2d78b 9657 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9658 (E_CHAR, EXP_INT): Remove, replacing with ...
9659 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9660 (string_to_number): New function, replacing isfloat_string.
9661 This function checks for valid syntax and produces the resulting
9662 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9663 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9664 so that overflow for non-base-10 numbers is reported only when
9665 there's no portable and simple way to convert to floating point.
452f4150 9666
67769ffc
PE
9667 * textprop.c (set_text_properties_1): Rewrite for clarity,
9668 and to avoid GCC warning about integer overflow.
9669
c20db43f
PE
9670 * intervals.h (struct interval): Use EMACS_INT for members
9671 where EMACS_UINT might cause problems. See
9672 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9673 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9674 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9675 All uses changed.
37aa2f85
PE
9676 (offset_intervals): Tell GCC not to worry about length overflow
9677 when negating a negative length.
c20db43f 9678
2538aa2f
PE
9679 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9680 (overrun_check_free): Likewise.
9681
f2d3008d
PE
9682 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9683 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9684 word size.
9685
ec8df744
PE
9686 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9687 (gnutls_make_error): Rename local to avoid shadowing.
9688 (gnutls_emacs_global_deinit): ifdef out; not used.
9689 (Fgnutls_boot): Use const for pointer to readonly storage.
9690 Comment out unused local. Fix pointer signedness problems.
9691
640ee02d
PE
9692 * lread.c (openp): Don't stuff size_t into an 'int'.
9693 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9694 about possible signed overflow.
9695
6048fb2a
PE
9696 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9697 (GDK_KEY_g): Don't define if already defined.
9698 (xg_prepare_tooltip): Avoid pointer signedness problem.
9699 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9700
fa3c87e1
PE
9701 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9702 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9703
2172544b
PE
9704 * xfns.c (Fx_window_property): Simplify a bit,
9705 to make a bit faster and to avoid GCC 4.6.0 warning.
9706 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9707
9b821a21
PE
9708 * fns.c (internal_equal): Don't assume size_t fits in int.
9709
3c616cfa
PE
9710 * alloc.c (compact_small_strings): Tighten assertion a little.
9711
c2982e87
PE
9712 Replace pEd with more-general pI, and fix some printf arg casts.
9713 * lisp.h (pI): New macro, generalizing old pEd macro to other
9714 conversion specifiers. For example, use "...%"pI"d..." rather
9715 than "...%"pEd"...".
9716 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9717 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9718 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9719 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9720 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9721 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9722 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9723 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9724 64-bit hosts.
9725 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9726 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9727 * print.c (safe_debug_print, print_object): Likewise.
9728 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9729 to int.
6f04d126
PE
9730 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9731 avoiding the 0 flag, which is not portable.
c2982e87
PE
9732 * process.c (Fmake_network_process): Use pI to avoid cast.
9733 * region-cache.c (pp_cache): Likewise.
9734 * xdisp.c (decode_mode_spec): Likewise.
9735 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9736 behavior on 64-bit hosts with printf arg.
6f04d126 9737 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9738 (x_stop_queuing_selection_requests): Likewise.
9739 (x_get_window_property): Don't truncate byte count to an 'int'
9740 when tracing.
0b432f21 9741
5e073ec7
PE
9742 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9743 here, since it parses constructs like leading '-' and spaces,
9744 which are not wanted; and it overflows with large numbers.
9745 Instead, simply match F[0-9]+, which is what is wanted anyway.
9746
36372bf9
PE
9747 * alloc.c: Remove unportable assumptions about struct layout.
9748 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9749 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9750 (allocate_vectorlike, make_pure_vector): Use the new macros,
9751 plus offsetof, to remove unportable assumptions about struct layout.
9752 These assumptions hold on all porting targets that I know of, but
9753 they are not guaranteed, they're easy to remove, and removing them
9754 makes further changes easier.
9755
0b432f21
PE
9756 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9757 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9758 (string_overrun_cookie): Now const. Use initializers that
9759 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9760 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9761 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9762 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9763 multiple of sizeof (EMACS_INT); it need not be, if
9764 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9765 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9766
895009e1
JB
97672011-04-26 Juanma Barranquero <lekktu@gmail.com>
9768
9769 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9770
6a7a1b0b
TZ
97712011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9772
9773 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9774 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9775 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9776
841a1577 97772011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9778
9779 * lisp.h (Qdebug): List symbol.
895009e1 9780 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9781 * keyboard.c (debug-on-event): New variable.
9782 (handle_user_signal): Break into debugger when debug-on-event
9783 matches the current signal symbol.
9784
f2d3ba6f
DN
97852011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9786
9787 * alloc.c (check_sblock, check_string_bytes)
9788 (check_string_free_list): Convert to standard C.
9789
42ce4c63
TZ
97902011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9791
9792 * w32.c (emacs_gnutls_push): Fix typo.
9793
825cd63c
EZ
97942011-04-25 Eli Zaretskii <eliz@gnu.org>
9795
fb11d64d
EZ
9796 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9797 "cast to pointer from integer of different size".
9798
825cd63c
EZ
9799 Improve doprnt and its use in verror. (Bug#8545)
9800 * doprnt.c (doprnt): Document the set of format control sequences
9801 supported by the function. Use SAFE_ALLOCA instead of always
9802 using `alloca'.
9803
9804 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9805 is one byte too soon. Don't use xrealloc; instead xfree and
9806 xmalloc anew.
9807
e061a11b
TZ
98082011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9809
9810 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9811 callbacks stage.
9812
9813 * gnutls.c: Renamed global_initialized to
9814 gnutls_global_initialized. Added internals for the
9815 :verify-hostname-error, :verify-error, and :verify-flags
9816 parameters of `gnutls-boot' and documented those parameters in the
9817 docstring. Start callback support.
9173deec
JB
9818 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9819 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9820 on error. Return error code.
e061a11b
TZ
9821 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9822 (emacs_gnutls_read): Likewise.
9823 (Fgnutls_boot): Return handshake error code.
9824 (emacs_gnutls_handle_error): New function.
9825 (wsaerror_to_errno): Likewise.
9826
9827 * w32.h (emacs_gnutls_pull): Add prototype.
9828 (emacs_gnutls_push): Likewise.
9829
9830 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9831 (emacs_gnutls_push): Likewise.
9832
98332011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9834
9835 * process.c (wait_reading_process_output): Check if GnuTLS
9836 buffered some data internally if no FDs are set for TLS
9837 connections.
9838
9839 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9840 (LIBS): Link to USER_LIBS.
9841 ($(BLD)/gnutls.$(0)): New target.
9842
fa6996bc
EZ
98432011-04-24 Eli Zaretskii <eliz@gnu.org>
9844
eb35682e
EZ
9845 * xdisp.c (handle_single_display_spec): Rename the
9846 display_replaced_before_p argument into display_replaced_p, to
9847 make it consistent with the commentary. Fix typos in the
9848 commentary.
9849
e2ad650c
EZ
9850 * textprop.c (syms_of_textprop): Remove dead code.
9851 (copy_text_properties): Delete obsolete commentary about an
9852 interface that was deleted long ago. Fix typos in the description
9853 of arguments.
9854
1b2de274
EZ
9855 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9856 to changes in oldXMenu/XMenu.h from 2011-04-16.
9857 <menu_help_message, prev_menu_help_message>: Constify.
9858 (IT_menu_make_room): menu->help_text is now `const char **';
9859 adjust.
9860
9861 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9862 to changes in oldXMenu/XMenu.h from 2011-04-16.
9863 (struct XMenu): Declare `help_text' `const char **'.
9864
9865 * xfaces.c <Qunspecified>: Make extern again.
9866
9867 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9868 required by POSIX.
1b2de274 9869
762b15be
EZ
9870 * doc.c (get_doc_string): Improve the format passed to `error'.
9871
9872 * doprnt.c (doprnt): Improve commentary.
9873
9874 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9875
9876 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9877 them with etags.
9878
f1052e5d
EZ
9879 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9880 changes in globals.h immediately force recompilation.
762b15be
EZ
9881 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9882 $(CURDIR)/s/ms-w32.h.
9883 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9884
fa6996bc
EZ
9885 * character.c (Fchar_direction): Function deleted.
9886 (syms_of_character): Don't defsubr it.
9887 <char-direction-table>: Deleted.
9888
e6c3da20
EZ
98892011-04-23 Eli Zaretskii <eliz@gnu.org>
9890
9891 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9892 * doprnt.c: Include limits.h.
9893 (SIZE_MAX): New macro.
04f2d78b
CB
9894 (doprnt): Return a size_t value. 2nd arg is now size_t.
9895 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9896 Improve overflow protection. Support `l' modifier for integer
9897 conversions. Support %l conversion. Don't assume an EMACS_INT
9898 argument for integer conversions and for %c.
9899
9900 * lisp.h (doprnt): Restore prototype.
9901
9902 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9903 $(SRC)/character.h.
9904
9905 * Makefile.in (base_obj): Add back doprnt.o.
9906
9907 * deps.mk (doprnt.o): Add back prerequisites.
9908 (callint.o): Depend on character.h.
9909
9910 * eval.c (internal_lisp_condition_case): Include the handler
9911 representation in the error message.
9912 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9913 when breaking from the loop.
9914
9915 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9916
9917 * callint.c (Fcall_interactively): When displaying error message
9918 about invalid control letter, pass the character's codepoint, not
9919 a pointer to its multibyte form. Improve display of the character
9920 in octal and display also its hex code.
9921
9922 * character.c (char_string): Use %x to display the (unsigned)
9923 codepoint of an invalid character, to avoid displaying a bogus
9924 negative value.
9925
9926 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9927 `error', not SYMBOL_NAME itself.
9928
9929 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9930 character arguments to `error'.
9931
9932 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9933 to `error' in error message about FINAL_CHAR argument. Make sure
9934 FINAL_CHAR is a character, and use %c when it is passed as
9935 argument to `error'.
9936
4ffd0d6b 99372011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9938
9939 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9940
9941 * w32.c: Include <time.h>.
9942 (sys_localtime): New function.
9943
4ffd0d6b 99442011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9945
9946 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9947
4ffd0d6b 9948 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9949
4ffd0d6b 99502011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9951
4ffd0d6b
GM
9952 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9953 zombies (Bug#8467).
aac0c6e3 9954
04c56954
EZ
99552011-04-19 Eli Zaretskii <eliz@gnu.org>
9956
9957 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9958 gl_state.e_property when gl_state.object is Qt.
9959
9960 * insdel.c (make_gap_larger): Remove limitation of buffer size
9961 to <= INT_MAX.
9962
16a43933
CY
99632011-04-18 Chong Yidong <cyd@stupidchicken.com>
9964
9965 * xdisp.c (lookup_glyphless_char_display)
9966 (produce_glyphless_glyph): Handle cons cell entry in
9967 glyphless-char-display.
9968 (Vglyphless_char_display): Document it.
9969
9970 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9971 glyphless-char-display.
9972
4581706e
CY
99732011-04-17 Chong Yidong <cyd@stupidchicken.com>
9974
9975 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9976
9977 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9978
9979 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9980 definition for no-X builds.
9981
4887c6e2 99822011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9983
fd35b6f9
PE
9984 Static checks with GCC 4.6.0 and non-default toolkits.
9985
5c1ccb01
PE
9986 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9987
006c5daa
PE
9988 * process.c (keyboard_bit_set): Define only if SIGIO.
9989 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9990 (send_process): Repair possible setjmp clobbering.
9991
efc736d3
PE
9992 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9993
4e2fe2e6
PE
9994 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9995
f97334a2
PE
9996 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9997
4e75f29d
PE
9998 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9999 Define only if needed.
10000
90efadd1
PE
10001 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10002 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10003 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10004
3c647824
PE
10005 * dispextern.h (struct redisplay_interface): Rename param
10006 to avoid shadowing.
e264f262 10007 * termhooks.h (struct terminal): Likewise.
761383f4 10008 * xterm.c (xembed_send_message): Likewise.
3c647824 10009
b58c5c4a
PE
10010 * insdel.c (make_gap_smaller): Define only if
10011 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10012
cad59032
PE
10013 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10014 it.
10015
c339dc2e
PE
10016 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10017 so that we aren't warned about unused symbols.
10018
91a3e27b
PE
10019 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10020
399c71d3 10021 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10022
8ffc96f5
PE
10023 * xfns.c (x_real_positions): Mark locals as initialized.
10024
eef9bc79
PE
10025 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10026
098db9dd
PE
10027 * xterm.c: Fix problems found by static analysis with other toolkits.
10028 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10029 (x_dispatch_event): Declare static if USE_GTK, and
10030 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10031 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10032 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10033 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10034 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10035
eb18f6cc
PE
10036 * xmenu.c (menu_help_callback): Pointer type fixes.
10037 Use const pointers when pointing at readonly data. Avoid pointer
10038 signedness clashes.
10039 (FALSE): Remove unused macro.
10040 (update_frame_menubar): Remove unused decl.
10041
1fe72bf8
PE
10042 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10043
60d9e1db
PE
10044 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10045 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10046 (single_menu_item): Rename local to avoid shadowing.
10047
39261c26
PE
10048 * keyboard.c (make_lispy_event): Remove unused local var.
10049
018c5e19
PE
10050 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10051 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10052
63d2b86e
PE
10053 * bitmaps: Change bitmaps from unsigned char back to the X11
10054 compatible char. Avoid the old compiler warnings about
10055 out-of-range initializers by using, for example, '\xab' rather
10056 than 0xab.
10057
aefd87e1
PE
10058 * xgselect.c (xgselect_initialize): Check vs interface
10059 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10060
bf501fb9
PE
10061 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10062
e9829fdf
PE
10063 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10064 to read-only memory.
10065
1086c095
PE
10066 * fns.c (vector): Remove; this old hack is no longer needed.
10067
2baccd04 10068 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10069 Remove unused var.
dde42981 10070 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10071
72391843 10072 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10073
436c16df 10074 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10075 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10076 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10077
92bb796d 10078 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10079 (x_term_init): Remove local to avoid shadowing.
92bb796d 10080
764430a3 10081 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10082
10083 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10084 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10085
d1dfb56c
EZ
100862011-04-16 Eli Zaretskii <eliz@gnu.org>
10087
c4354cb4
EZ
10088 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10089
d1dfb56c
EZ
10090 Fix regex.c, syntax.c and friends for buffers > 2GB.
10091 * syntax.h (struct gl_state_s): Declare character position members
10092 EMACS_INT.
10093
10094 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10095
04f2d78b
CB
10096 * textprop.c (verify_interval_modification, interval_of):
10097 Declare arguments EMACS_INT.
d1dfb56c
EZ
10098
10099 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10100 EMACS_INT.
10101
10102 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10103
10104 * indent.c (Fvertical_motion): Local variable it_start is now
10105 EMACS_INT.
10106
10107 * regex.c (re_match, re_match_2, re_match_2_internal)
10108 (bcmp_translate, regcomp, regexec, print_double_string)
10109 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10110 (re_compile_pattern, re_exec): Declare arguments and local
10111 variables `size_t' and `ssize_t' and return values `regoff_t', as
10112 appropriate.
10113 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10114 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10115 <compile_stack_type>: `size' and `avail' are now `size_t'.
10116
10117 * regex.h <regoff_t>: Use ssize_t, not int.
10118 (re_search, re_search_2, re_match, re_match_2): Arguments that
10119 specify buffer/string position and length are now ssize_t and
10120 size_t. Return type is regoff_t.
10121
613052cd
BK
101222011-04-16 Ben Key <bkey76@gmail.com>
10123
10124 * nsfont.m: Fixed bugs in ns_get_family and
10125 ns_descriptor_to_entity that were caused by using free to
10126 deallocate memory blocks that were allocated by xmalloc (via
10127 xstrdup). This caused Emacs to crash when compiled with
10128 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10129 --enable-checking=xmallocoverrun). xfree is now used to
10130 deallocate these memory blocks.
10131
4170f62f 101322011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10133
71b41406
PE
10134 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10135
9587a89d
PE
10136 emacs_write: Accept and return EMACS_INT for sizes.
10137 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10138 et seq.
10139 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10140 Accept and return EMACS_INT.
10141 (emacs_gnutls_write): Return the number of bytes written on
10142 partial writes.
10143 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10144 (emacs_read, emacs_write): Remove check for negative size, as the
10145 Emacs source code has been audited now.
9587a89d
PE
10146 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10147 (emacs_read, emacs_write): Use it.
273a5f82
PE
10148 * process.c (send_process): Adjust to the new signatures of
10149 emacs_write and emacs_gnutls_write. Do not attempt to store
10150 a byte offset into an 'int'; it might overflow.
9587a89d 10151 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10152
3e047f51
PE
10153 * sound.c: Don't assume sizes fit in 'int'.
10154 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10155 Return EMACS_INT, not int.
3e047f51 10156 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10157 Accept EMACS_INT, not int.
10158 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10159 record read return values.
10160
cc39a9db
BK
101612011-04-15 Ben Key <bkey76@gmail.com>
10162
c9d0ec6d
JB
10163 * keyboard.c (Qundefined): Don't declare static since it is used
10164 in nsfns.m.
10165 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10166 static since they are used in nsfont.m.
cc39a9db 10167
6c60eb9f
SM
101682011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10169
10170 * process.c (Qprocessp): Don't declare static.
10171 * lisp.h (Qprocessp): Declare again.
10172
7990b61a
JB
101732011-04-15 Juanma Barranquero <lekktu@gmail.com>
10174
10175 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10176
5d4cb038
PE
101772011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10178
8bd7b830 10179 Improve C-level modularity by making more things 'static'.
cd64ea1d 10180
e3b27b31
PE
10181 Don't publish debugger-only interfaces to other modules.
10182 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10183 (verify_bytepos, count_markers): Move decls to the only modules
10184 that need them.
10185 * region-cache.h (pp_cache): Likewise.
10186 * window.h (check_all_windows): Likewise.
10187 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10188
5d4cb038
PE
10189 * sysdep.c (croak): Now static, if
10190 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10191 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10192
10193 * alloc.c (refill_memory_reserve): Now static if
10194 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10195 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10196
e87b6180
PE
10197 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10198 Define only if USE_LUCID.
10199
ac64929e
PE
10200 * xrdb.c (x_customization_string, x_rm_string): Now static.
10201
6f37259d
PE
10202 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10203 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10204
1683e3ab
PE
10205 * xdisp.c (draw_row_with_mouse_face): Now static.
10206 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10207
de9c2632
PE
10208 * window.h (check_all_windows): Mark externally visible.
10209
2b96acb7
PE
10210 * window.c (window_deletion_count): Now static.
10211
10212 * undo.c: Make symbols static if they're not exported.
10213 (last_undo_buffer, last_boundary_position, pending_boundary):
10214 Now static.
10215
50436f33
PE
10216 * textprop.c (interval_insert_behind_hooks): Now static.
10217 (interval_insert_in_front_hooks): Likewise.
10218
64520e5c
PE
10219 * term.c: Make symbols static if they're not exported.
10220 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10221 (max_frame_lines, tty_set_terminal_modes):
10222 (tty_reset_terminal_modes, tty_turn_off_highlight):
10223 (get_tty_terminal): Now static.
10224 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10225 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10226 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10227 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10228 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10229
1fa53021
PE
10230 * sysdep.c: Make symbols static if they're not exported.
10231 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10232 Now static.
10233 (sigprocmask_set, full_mask): Remove; unused.
10234 (wait_debugging): Mark as visible.
10235 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10236 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10237
d4b43b22
PE
10238 * syntax.c (syntax_temp): Define only if !__GNUC__.
10239
b7c513d0
PE
10240 * sound.c (current_sound_device, current_sound): Now static.
10241
989b29ad
PE
10242 * search.c (searchbufs, searchbuf_head): Now static.
10243
13a55a78
PE
10244 * scroll.c (scroll_cost): Remove; unused.
10245 * dispextern.h (scroll_cost): Remove decl.
10246
de68a1fc
PE
10247 * region-cache.h (pp_cache): Mark as externally visible.
10248
40ccffa6
PE
10249 * process.c: Make symbols static if they're not exported.
10250 (process_tick, update_tick, create_process, chan_process):
10251 (Vprocess_alist, proc_buffered_char, datagram_access):
10252 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10253 (deactivate_process): Mark defn as static, as well as decl.
10254 * lisp.h (create_process): Remove decl.
10255 * process.h (chan_process, Vprocess_alist): Remove decls.
10256
ad64fc97
PE
10257 * print.c: Make symbols static if they're not exported.
10258 (print_depth, new_backquote_output, being_printed, print_buffer):
10259 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10260 (print_interval, print_number_index, initial_stderr_stream):
10261 Now static.
10262 * lisp.h (Fprinc): Remove decl.
10263 (debug_output_compilation_hack): Mark as externally visible.
10264
adddb265
PE
10265 * sysdep.c (croak): Move decl from here to syssignal.h.
10266 * syssignal.h (croak): Put it here, so the API can be checked when
10267 'croak' is called from dissociate_if_controlling_tty.
10268
1717ede2
PE
10269 * minibuf.c: Make symbols static if they're not exported.
10270 (minibuf_save_list, choose_minibuf_frame): Now static.
10271 * lisp.h (choose_minibuf_frame): Remove decl.
10272
fa5fb2bc
PE
10273 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10274
1e3890d1
PE
10275 * lread.c: Make symbols static if they're not exported.
10276 (read_objects, initial_obarray, oblookup_last_bucket_number):
10277 Now static.
10278 (make_symbol): Remove; unused.
10279 * lisp.h (initial_obarray, make_symbol): Remove decls.
10280
8a1414fa
PE
10281 * keyboard.c: Make symbols static if they're not exported.
10282 (single_kboard, recent_keys_index, total_keys, recent_keys):
10283 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10284 (this_single_command_key_start, echoing, last_auto_save):
10285 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10286 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10287 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10288 (Vlispy_mouse_stem, double_click_count):
10289 Now static.
10290 (force_auto_save_soon): Define only if SIGDANGER.
10291 (ignore_mouse_drag_p): Now static if
10292 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10293 (print_help): Remove; unused.
10294 (stop_character, last_timer_event): Mark as externally visible.
10295 * keyboard.h (ignore_mouse_drag_p): Declare only if
10296 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10297 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10298 * lisp.h (echoing): Remove decl.
10299 (force_auto_save_soon): Declare only if SIGDANGER.
10300 * xdisp.c (redisplay_window): Simplify code, to make it more
10301 obvious that ignore_mouse_drag_p is not accessed if !defined
10302 USE_GTK && !defined HAVE_NS.
10303
93ea6e8f
PE
10304 * intervals.c: Make symbols static if they're not exported.
10305 (merge_properties_sticky, merge_interval_right, delete_interval):
10306 Now static.
10307 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10308
77382fcc
PE
10309 * insdel.c: Make symbols static if they're not exported.
10310 However, leave prepare_to_modify_buffer alone. It's never
10311 called from outside this function, but that appears to be a bug.
10312 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10313 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10314 (adjust_after_replace_noundo): Remove; unused.
10315 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10316 (signal_before_change): Remove decls.
77382fcc 10317
9306c32e
PE
10318 * indent.c (val_compute_motion, val_vmotion): Now static.
10319
cd44d2eb
PE
10320 * image.c: Make symbols static if they're not exported.
10321 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10322 if USE_GTK.
10323 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10324 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10325
ad9a7a06
PE
10326 * fringe.c (standard_bitmaps): Now static.
10327 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10328
81626931
PE
10329 * frame.c: Make symbols static if they're not exported.
10330 (x_report_frame_params, make_terminal_frame): Now static.
10331 (get_frame_param): Now static, unless HAVE_NS.
10332 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10333 (x_get_resource_string): Remove; not used.
10334 * frame.h (make_terminal_frame, x_report_frame_params):
10335 (x_get_resource_string); Remove decls.
10336 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10337 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10338
239f9db9
PE
10339 * font.c, fontset.c: Make symbols static if they're not exported.
10340 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10341 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10342 * font.c (font_close_object): Now static.
10343 * font.h (font_close_object): Remove.
10344 * fontset.c (FONTSET_OBJLIST): Remove.
10345 (free_realized_fontset) #if-0 the body, which does nothing.
10346 (face_suitable_for_char_p): #if-0, as it's never called.
10347 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10348 * xfaces.c (face_at_string_position):
10349 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10350 since 0 is always ASCII.
10351
dfcf3579
PE
10352 * fns.c (weak_hash_tables): Now static.
10353
5045092b
PE
10354 * fileio.c: Make symbols static if they're not exported.
10355 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10356 (Vwrite_region_annotation_buffers): Now static.
10357
57a96f5c
PE
10358 * eval.c: Make symbols static if they're not exported.
10359 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10360 * lisp.h (backtrace_list): Remove decl.
10361
35f08c38
PE
10362 * emacs.c: Make symbols static if they're not exported.
10363 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10364 (fatal_error_code, fatal_error_signal_hook, standard_args):
10365 Now static.
10366 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10367 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10368 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10369 * lisp.h (fatal_error_signal_hook): Remove decl.
10370 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10371
f44bd759
PE
10372 * editfns.c: Move a (normally-unused) function to its only use.
10373 * editfns.c, lisp.h (get_operating_system_release): Remove.
10374 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10375 worth the hassle of breaking this out.
10376
b532497d
PE
10377 * xterm.c: Make symbols static if they're not exported.
10378 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10379 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10380 (x_destroy_window, x_delete_display):
10381 Now static.
10382 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10383 (x_mouse_leave): Remove; unused.
10384 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10385 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10386 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10387 Remove decls.
10388 (x_mouse_leave): Declare only if WINDOWSNT.
10389 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10390 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10391 USE_X_TOOLKIT.
10392
1675728f
PE
10393 * ftxfont.c: Make symbols static if they're not exported.
10394 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10395 HAVE_FREETYPE.
10396 * font.h (ftxfont_driver): Likewise.
10397
e4cebfca
PE
10398 * xfns.c: Make symbols static if they're not exported.
10399 (x_last_font_name, x_display_info_for_name):
10400 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10401 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10402 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10403 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10404 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10405 (last_show_tip_args): Now static.
10406 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10407 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10408 (x_screen_planes): Remove; unused.
10409 * dispextern.h (x_screen_planes): Remove decl.
10410
5bf46f05
PE
10411 * dispnew.c: Make symbols static if they're not exported.
10412 * dispextern.h (redraw_garbaged_frames, scrolling):
10413 (increment_row_positions): Remove.
10414 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10415 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10416 Now static.
10417 (redraw_garbaged_frames): Remove; unused.
10418
435f4c28
PE
10419 * xfaces.c: Make symbols static if they're not exported.
10420 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10421 Remove decls.
10422 * xterm.h (defined_color): Remove decls.
10423 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10424 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10425 (menu_face_changed_default, defined_color, free_realized_face):
10426 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10427 (ascii_face_of_lisp_face): Remove; unused.
10428
8524aef3
PE
10429 * xdisp.c: Make symbols static if they're not exported.
10430 * dispextern.h (scratch_glyph_row, window_box_edges):
10431 (glyph_to_pixel_coords, set_cursor_from_row):
10432 (get_next_display_element, set_iterator_to_next):
10433 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10434 (show_mouse_face): Remove decls
10435 * frame.h (message_buf_print): Likewise.
10436 * lisp.h (pop_message, set_message, check_point_in_composition):
10437 Likewise.
10438 * xterm.h (set_vertical_scroll_bar): Likewise.
10439 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10440 (message_buf_print, scratch_glyph_row, displayed_buffer):
10441 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10442 (get_next_display_element, show_mouse_face, window_box_edges):
10443 (frame_to_window_pixel_xy, check_point_in_composition):
10444 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10445 (glyph_to_pixel_coords): Remove; unused.
10446
16390cd2
PE
10447 * dired.c (file_name_completion): Now static.
10448
10449 * dbusbind.c (xd_in_read_queued_messages): Now static.
10450
a25f4dfa
PE
10451 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10452 * data.c (circular_list_error): Remove.
10453
14a9c8df
PE
10454 * commands.h (last_point_position, last_point_position_buffer):
10455 (last_point_position_window): Remove decls.
10456 * keyboard.c: Make these variables static.
10457
04f2d78b
CB
10458 * coding.h (coding, code_convert_region, encode_coding_gap):
10459 Remove decls.
74ab6df5
PE
10460 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10461 (iso_code_class, detect_coding, code_convert_region): Now static.
10462 (encode_coding_gap): Remove; unused.
10463
38dfbee1
PE
10464 * chartab.c (chartab_chars, chartab_bits): Now static.
10465
a2cb4e63
PE
10466 * charset.h (charset_iso_8859_1): Remove decl.
10467 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10468 Now static.
10469
127198fd
PE
10470 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10471 * ccl.c (Vccl_program_table): Now static.
10472 (check_ccl_update): Remove; unused.
10473
d85b608f
PE
10474 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10475 * category.h: ... from here.
10476 * category.c (check_category_table, set_category_set): Now static.
10477
31cd66f3
PE
10478 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10479 * lisp.h: Remove these decls.
10480
c358e587
PE
10481 * buffer.c (buffer_count): Remove unused var.
10482
e78aecca
PE
10483 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10484 so that it's not optimized away.
10485 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10486 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10487 exported only to the debugger.
10488
e192d7d3 10489 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10490 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10491
92470028
PE
10492 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10493 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10494 was inaccessible from Lisp.
10495 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10496 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10497
244ed907
PE
10498 alloc.c: Import and export fewer symbols, and remove unused items.
10499 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10500 is defined.
10501 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10502 it's not optimized away by whole-program optimization.
10503 (message_enable_multibyte, free_misc): Remove.
10504 (catchlist, handlerlist, mark_backtrace):
10505 Declare only if BYTE_MARK_STACK.
10506 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10507 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10508 (message_enable_multibyte): Remove decl.
10509 (free_misc, interval_free_list, float_block, float_block_index):
10510 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10511 (cons_free_list, last_marked_index):
10512 Now static.
10513 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10514 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10515 (mark_backtrace): Define only if BYTE_MARK_STACK.
10516 * xdisp.c (message_enable_multibyte): Now static.
10517
61c2b50e 10518 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10519 This makes it easier for human readers (and static analyzers)
10520 to see whether these variables are used from other modules.
10521 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10522 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10523 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10524 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10525 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10526 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10527 * xmenu.c, xselect.c:
10528 Declare Q* vars static if they are not used in other modules.
10529 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10530 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10531 Remove decls of unexported vars.
10532 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10533
95c82688
PE
10534 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10535
16a97296
PE
10536 Make Emacs functions such as Fatom 'static' by default.
10537 This makes it easier for human readers (and static analyzers)
10538 to see whether these functions can be called from other modules.
10539 DEFUN now defines a static function. To make the function external
10540 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10541 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10542 (Finit_image_library):
16a97296
PE
10543 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10544 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10545 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10546 Remove decls, since these functions are now static.
10547 (Funintern, Fget_internal_run_time): New decls, since these functions
10548 were already external.
95c82688 10549
16a97296
PE
10550 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10551 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10552 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10553 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10554 * keyboard.c, keymap.c, lread.c:
10555 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10556 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10557 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10558 Mark functions with DEFUE instead of DEFUN,
10559 if they are used in other modules.
10560 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10561 decls for now-static functions.
10562 * buffer.h (Fdelete_overlay): Remove decl.
10563 * callproc.c (Fgetenv_internal): Mark as internal.
10564 * composite.c (Fremove_list_of_text_properties): Remove decl.
10565 (Fcomposition_get_gstring): New forward static decl.
10566 * composite.h (Fcomposite_get_gstring): Remove decl.
10567 * dired.c (Ffile_attributes): New forward static decl.
10568 * doc.c (Fdocumntation_property): New forward static decl.
10569 * eval.c (Ffetch_bytecode): New forward static decl.
10570 (Funintern): Remove extern decl; now in .h file where it belongs.
10571 * fileio.c (Fmake_symbolic_link): New forward static decl.
10572 * image.c (Finit_image_library): New forward static decl.
10573 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10574 * intervals.h (Fprevious_property_change):
10575 (Fremove_list_of_text_properties): Remove decls.
10576 * keyboard.c (Fthis_command_keys): Remove decl.
10577 (Fcommand_execute): New forward static decl.
10578 * keymap.c (Flookup_key): New forward static decl.
10579 (Fcopy_keymap): Now static.
10580 * keymap.h (Flookup_key): Remove decl.
10581 * process.c (Fget_process): New forward static decl.
10582 (Fprocess_datagram_address): Mark as internal.
10583 * syntax.c (Fsyntax_table_p): New forward static decl.
10584 (skip_chars): Remove duplicate decl.
10585 * textprop.c (Fprevious_property_change): New forward static decl.
10586 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10587 Now internal.
10588 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10589 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10590
785bbd42
PE
10591 * editfns.c (Fformat): Remove unreachable code.
10592
8b913b57
AS
105932011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10594
10595 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10596 change. (Bug#8496)
10597
a6744a35
EZ
105982011-04-13 Eli Zaretskii <eliz@gnu.org>
10599
10600 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10601 when at ZV. (Bug#8487)
10602
e7974947
AS
106032011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10604
baad03f0
AS
10605 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10606 (Bug#8437)
10607 * keyboard.c (parse_tool_bar_item): Likewise.
10608 * sound.c (sound_cleanup, alsa_close): Likewise.
10609 * termcap.c (tgetent): Likewise.
10610 * xfns.c (x_default_font_parameter): Likewise.
10611 * xsettings.c (read_and_apply_settings): Likewise.
10612
e7974947
AS
10613 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10614 (overrun_check_free): Protoize.
10615
28272684
PE
106162011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10617
10618 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10619 since callers should never pass a negative size.
10620 Change the signature to match that of plain 'read' and 'write'; see
10621 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10622 * lisp.h: Update prototypes of emacs_write and emacs_read.
10623
11997c76
EZ
106242011-04-11 Eli Zaretskii <eliz@gnu.org>
10625
10626 * xdisp.c (redisplay_window): Don't try to determine the character
10627 position of the scroll margin if the window start point w->startp
e896f03c 10628 is outside the buffer's accessible region. (Bug#8468)
11997c76 10629
8a2cbd72
EZ
106302011-04-10 Eli Zaretskii <eliz@gnu.org>
10631
10632 Fix write-region and its subroutines for buffers > 2GB.
10633 * fileio.c (a_write, e_write): Modify declaration of arguments and
10634 local variables to support buffers larger than 2GB.
10635 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10636
10637 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10638 argument, local variables, and return value.
10639
10640 * lisp.h: Update prototypes of emacs_write and emacs_read.
10641
10642 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10643
4073e537 106442011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10645
1ebfdcb6
PE
10646 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10647
b2ded58d
PE
10648 Fix more problems found by GCC 4.6.0's static checks.
10649
7d66342c
PE
10650 * xdisp.c (vmessage): Use a better test for character truncation.
10651
bbf47d44
PE
10652 * charset.c (load_charset_map): <, not <=, for optimization,
10653 and to avoid potential problems with integer overflow.
9248994d 10654 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10655 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10656 * editfns.c (Fformat): Likewise.
1e69125e 10657 * syntax.c (skip_chars): Likewise.
3befa583 10658
e3019616
PE
10659 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10660 This also lets GCC 4.6.0 generate slightly better loop code.
10661
becfa255
PE
10662 * callint.c (Fcall_interactively): <, not <=, for optimization.
10663 (Fcall_interactively): Count the number of arguments produced,
10664 not the number of arguments given. This is simpler and lets GCC
10665 4.6.0 generate slightly better code.
10666
dae0cd48
PE
10667 * ftfont.c: Distingish more carefully between FcChar8 and char.
10668 The previous code passed unsigned char * to a functions like
10669 strlen and xstrcasecmp that expect char *, which does not
10670 conform to the C standard.
10671 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10672 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10673 char * when the C standard requires it.
10674
76032d70
PE
10675 * keyboard.c (read_char): Remove unused var.
10676
eb3f1cc8
PE
10677 * eval.c: Port to Windows vsnprintf (Bug#8435).
10678 Include <limits.h>.
10679 (SIZE_MAX): Define if the headers do not.
10680 (verror): Do not give up if vsnprintf returns a negative count.
10681 Instead, grow the buffer. This ports to Windows vsnprintf, which
10682 does not conform to C99. Problem reported by Eli Zaretskii.
10683 Also, simplify the allocation scheme, by avoiding the need for
10684 calling realloc, and removing the ALLOCATED variable.
10685
70476b54
PE
10686 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10687
12020a9e
PE
10688 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10689 But keep the doprint source code for now, as we might revamp it
10690 and use it again (Bug#8435).
ea6c7ae6
PE
10691 * lisp.h (doprnt): Remove.
10692 * Makefile.in (base_obj): Remove doprnt.o.
10693 * deps.mk (doprnt.o): Remove.
10694
5fdb398c
PE
10695 error: Print 32- and 64-bit integers portably (Bug#8435).
10696 Without this change, on typical 64-bit hosts error ("...%d...", N)
10697 was used to print both 32- and 64-bit integers N, which relied on
10698 undefined behavior.
61bdb816 10699 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10700 * lisp.h (error, verror): Mark as printf-like functions.
10701 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10702 Report overflow in size calculations when allocating printf buffer.
10703 Do not truncate output string at its first null byte.
10704 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10705 Truncate the output at a character boundary, since vsnprintf does not
10706 do that.
10707 * charset.c (check_iso_charset_parameter): Convert internal
10708 character to string before calling 'error', since %c now has the
10709 printf meaning.
10710 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10711 overflow when computing char to be passed to 'error'. Do not
10712 pass Lisp_Object to 'error'; pass the integer instead.
10713 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10714 formatted with plain %d.
10715
b189fa66
PE
10716 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10717
bff87ef0
PE
10718 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10719
7e2cac20
PE
10720 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10721
ce4d90b5
PE
10722 * xterm.c (x_catch_errors): Remove duplicate declaration.
10723
266c9547
PE
10724 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10725
79c49ad2
PE
10726 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10727
368f4090
JM
107282011-04-10 Jim Meyering <meyering@redhat.com>
10729
10730 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10731 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10732 return ssize_t not "int", and use size_t as the buffer length.
10733 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10734 * gnutls.h: Update declarations.
10735 * process.c (read_process_output): Use ssize_t, to match.
10736 (send_process): Likewise.
10737
a32d4040
CY
107382011-04-09 Chong Yidong <cyd@stupidchicken.com>
10739
10740 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10741
8546720e 107422011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10743
04f2d78b
CB
10744 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10745 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10746
8546720e
GM
10747 * xterm.c (handle_one_xevent):
10748 * xmenu.c (create_and_show_popup_menu):
10749 * xselect.c (x_decline_selection_request)
10750 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10751
0a2f5c1a 107522011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10753
10754 Fix some uses of `int' instead of EMACS_INT.
10755 * search.c (string_match_1, fast_string_match)
10756 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10757 (scan_buffer, find_next_newline_no_quit)
10758 (find_before_next_newline, search_command, Freplace_match)
10759 (Fmatch_data): Make some `int' variables be EMACS_INT.
10760
10761 * xdisp.c (display_count_lines): 3rd argument and return value now
10762 EMACS_INT. All callers changed.
10763 (pint2hrstr): Last argument is now EMACS_INT.
10764
10765 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10766 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10767 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10768 (decode_coding_utf_16, decode_coding_emacs_mule)
10769 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10770 (decode_coding_ccl, decode_coding_charset)
10771 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10772 (decode_coding_iso_2022, decode_coding_emacs_mule)
10773 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10774 <char_offset, last_offset>: Declare EMACS_INT.
10775 (encode_coding_utf_8, encode_coding_utf_16)
10776 (encode_coding_emacs_mule, encode_invocation_designation)
10777 (encode_designation_at_bol, encode_coding_iso_2022)
10778 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10779 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10780 Declare EMACS_INT.
10781 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10782 (encode_invocation_designation): Last argument P_NCHARS is now
10783 EMACS_INT.
10784 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10785 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10786
10787 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10788 All users changed.
10789
10790 * ccl.c (Fccl_execute_on_string): Declare some variables
10791 EMACS_INT.
10792
8546720e 107932011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10794
10795 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10796
4e19a977
CS
107972011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10798
10799 * process.c (Fformat_network_address): Doc fix.
10800
87302331
R
108012011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10802
ee7683eb 10803 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10804
cbb59342
CY
108052011-04-08 Chong Yidong <cyd@stupidchicken.com>
10806
10807 * keyboard.c (read_char): Call Lisp function help-form-show,
10808 instead of using internal_with_output_to_temp_buffer.
10809 (Qhelp_form_show): New var.
e0d38eeb 10810 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10811
10812 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10813
10814 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10815
e67a13ab
CY
108162011-04-06 Chong Yidong <cyd@stupidchicken.com>
10817
04f2d78b
CB
10818 * process.c (Flist_processes): Remove to Lisp.
10819 (list_processes_1): Delete.
e67a13ab 10820
973f782d
EZ
108212011-04-06 Eli Zaretskii <eliz@gnu.org>
10822
7c106b1e
EZ
10823 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10824
973f782d
EZ
10825 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10826
41cf7d1a 108272011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10828
ca23cc88
PE
10829 Fix more problems found by GCC 4.6.0's static checks.
10830
f390e2d5
PE
10831 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10832
42eea0d0
PE
10833 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10834
b69769da 10835 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10836
f9541e84
PE
10837 * xdisp.c (vmessage): Mark as a printf-like function.
10838
13841b55
PE
10839 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10840
c136c10f
PE
10841 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10842
5e2d4a30
PE
10843 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10844 printf-like functions.
10845 (tiff_load): Add casts to remove these marks before passing them
10846 to system-supplied API.
10847
583f48b9
PE
10848 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10849
b25d760e
PE
10850 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10851 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10852 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10853 directly, rather than having caller test rule sign. This avoids
10854 some unnecessary tests.
10855 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10856 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10857 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10858
bc7b6697 10859 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10860 (xfont_open): Avoid unnecessary tests.
bc7b6697 10861
27ccc379
PE
10862 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10863
dcd5c89a
PE
10864 * composite.h, composite.c (composition_gstring_put_cache):
10865 Use EMACS_INT, not int, for length.
10866
b13a45c6
PE
10867 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10868 breaking out part of COMPOSITION_DECODE_RULE.
10869 (COMPOSITION_DECODE_RULE): Use it.
10870 * composite.c (get_composition_id): Remove unused local vars,
10871 by using the new macro.
10872
1e792e4d
PE
10873 * textprop.c (set_text_properties_1): Change while to do-while,
10874 since the condition is always true at first.
10875
dc6c6455 10876 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10877 (interval_deletion_adjustment): Return unsigned value.
10878 All uses changed.
dc6c6455 10879
aba7731a
PE
10880 * process.c (list_processes_1, create_pty, read_process_output):
10881 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10882 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10883 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10884 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10885 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10886
fdfc4bf3
PE
10887 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10888
fca8fe46 10889 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10890 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10891
06a0259a 10892 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10893 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10894 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10895
e7b9e80f
PE
10896 * print.c (print_error_message): Avoid int overflow.
10897
56201685
PE
10898 * font.c (font_list_entities): Redo for clarity,
10899 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10900
78834453 10901 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10902 (font_score): Avoid potential overflow in diff calculation.
78834453 10903
0bc0b309 10904 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10905 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10906
e610eaca
PE
10907 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10908
b895abce
PE
10909 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10910 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10911 can always succeed if overflow has undefined behavior.
10912
1f1d9321 10913 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10914 (wordify): Omit three unnecessary tests.
1f1d9321 10915
c59478bc
PE
10916 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10917 All callers changed. This avoids the need for an unused var.
10918
79b73827
PE
10919 * casefiddle.c (casify_region): Remove var that is set but not used.
10920
a4db5dfe
PE
10921 * dired.c (file_name_completion): Remove var that is set but not used.
10922
43aae36e
PE
10923 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10924
2a47c44d 10925 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10926 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10927
a37c69bf
PE
10928 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10929 Check for integer overflow on size calculations.
10930
328ab8e7
PE
10931 * buffer.c (Fprevious_overlay_change): Remove var that is set
10932 but not used.
10933
e5a2a5cb
PE
10934 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10935 Remove vars that are set but not used.
8d84a6eb 10936 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10937 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10938
a60e5f68
PE
10939 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10940
f661cb61 10941 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10942 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10943
f0397f5a
PE
10944 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10945 that are set but not used.
10946
8664db06 10947 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10948 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10949
6abdaa4a
PE
10950 * xselect.c (x_get_local_selection, x_handle_property_notify):
10951 Remove vars that are set but not used.
10952
0ce7538d 10953 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10954 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10955
9ae848fc
PE
10956 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10957 Remove var that is set but not used.
0b918413
PE
10958 (scroll_bar_windows_size): Now size_t, not int.
10959 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10960 Check for overflow.
9ae848fc 10961
a5a62657
PE
10962 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10963 (map_tty_color) [!defined MSDOS]: Likewise.
10964
5c5cdd39
PE
10965 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10966
66ebf983
PE
10967 * coding.c: Remove vars that are set but not used.
10968 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10969 All callers changed.
10970 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10971 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10972 (decode_coding_charset): Remove vars that are set but not used.
10973
1be4d761
PE
10974 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10975 that is set but not used.
10976
47553fa8
PE
10977 * print.c (print_object): Remove var that is set but not used.
10978
1f7196bf 10979 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10980 The gnulib version avoids calling malloc in the usual case,
10981 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10982 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10983 * filelock.c (current_lock_owner): Likewise.
10984 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10985 * sysdep.c: Include allocator.h, careadlinkat.h.
10986 (emacs_no_realloc_allocator): New static constant.
10987 (emacs_readlink): New function.
fdb61804
PE
10988 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10989 ../lib/careadlinkat.h.
d1fdcab7 10990
f84c17c7
SM
109912011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10992
10993 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10994 first non-nil return value).
10995
ef3862ad
JD
109962011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10997
10998 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10999 if not defined (Bug#8403).
11000
376a7006
JB
110012011-04-02 Juanma Barranquero <lekktu@gmail.com>
11002
11003 * xdisp.c (display_count_lines): Remove parameter `start',
11004 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11005 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11006 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11007 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11008 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11009 and thereabouts. All callers changed.
11010 (get_per_char_metric): Remove parameter `f', unused since
11011 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11012
6ca3801d
JM
110132011-04-02 Jim Meyering <meyering@redhat.com>
11014
11015 do not dereference NULL upon failed strdup
11016 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11017 (ns_get_family): Likewise.
11018
d8e2b5ba
JB
110192011-04-02 Juanma Barranquero <lekktu@gmail.com>
11020
11021 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11022
8c74fcbd
JD
110232011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11024
11025 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11026 later (Bug#8403).
11027
7200d79c
SM
110282011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11029
03408648 11030 Add lexical binding.
7200d79c 11031
03408648
SM
11032 * window.c (Ftemp_output_buffer_show): New fun.
11033 (Fsave_window_excursion):
11034 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11035
11036 * lread.c (lisp_file_lexically_bound_p): New function.
11037 (Fload): Bind Qlexical_binding.
11038 (readevalloop): Remove `evalfun' arg.
11039 Bind Qinternal_interpreter_environment.
11040 (Feval_buffer): Bind Qlexical_binding.
11041 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11042 Mark as dynamic.
11043 (syms_of_lread): Declare `lexical-binding'.
11044
11045 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11046
11047 * keyboard.c (eval_dyn): New fun.
11048 (menu_item_eval_property): Use it.
ca105506
SM
11049
11050 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11051
03408648
SM
11052 * fns.c (concat, mapcar1): Accept byte-code-functions.
11053
11054 * eval.c (Fsetq): Handle lexical vars.
11055 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11056 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11057 (FletX, Flet): Obey lexical binding.
11058 (Fcommandp): Handle closures.
11059 (Feval): New `lexical' arg.
11060 (eval_sub): New function extracted from Feval. Use it almost
11061 everywhere where Feval was used. Look up vars in lexical env.
11062 Handle closures.
11063 (Ffunctionp): Move from subr.el.
11064 (Ffuncall): Handle closures.
11065 (apply_lambda): Remove `eval_flags'.
11066 (funcall_lambda): Handle closures and new byte-code-functions.
11067 (Fspecial_variable_p): New function.
11068 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11069 but without exporting it to Lisp.
23aba0ea 11070
23aba0ea 11071 * doc.c (Fdocumentation, store_function_docstring):
03408648 11072 * data.c (Finteractive_form): Handle closures.
23aba0ea 11073
03408648
SM
11074 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11075 interactive spec.
ba83908c 11076
04f2d78b
CB
11077 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11078 New byte-codes.
03408648
SM
11079 (exec_byte_code): New function extracted from Fbyte_code to handle new
11080 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11081
03408648 11082 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11083
03408648 11084 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11085
e2abce01
JB
110862011-03-31 Juanma Barranquero <lekktu@gmail.com>
11087
11088 * xdisp.c (redisplay_internal): Fix prototype.
11089
63696a73 110902011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11091
63696a73 11092 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11093 (try_scrolling): Use it when setting scroll_limit.
11094 Limit scrolling to 100 screen lines.
63696a73
EZ
11095 (redisplay_window): Even when falling back on "recentering",
11096 position point in the window according to scroll-conservatively,
11097 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11098
11099 (try_scrolling): When point is above the window, allow searching
11100 as far as scroll_max, or one screenful, to compute vertical
11101 distance from PT to the scroll margin position. This prevents
11102 try_scrolling from unnecessarily failing when
11103 scroll-conservatively is set to a value slightly larger than the
11104 window height. Clean up the case of PT below the margin at bottom
11105 of window: scroll_max can no longer be INT_MAX. When aggressive
11106 scrolling is in use, don't let point enter the opposite scroll
11107 margin as result of the scroll.
11108 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11109 threshold of 100 lines for never-recentering scrolling.
11110
e4cc2dfc
JB
111112011-03-31 Juanma Barranquero <lekktu@gmail.com>
11112
11113 * dispextern.h (move_it_by_lines):
11114 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11115 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11116 (message_log_check_duplicate): Remove parameters `prev_bol' and
11117 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11118 (redisplay_internal): Remove parameter `preserve_echo_area',
11119 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11120
11121 * indent.c (Fvertical_motion):
11122 * window.c (window_scroll_pixel_based, Frecenter):
11123 Don't pass `need_y_p' to `move_it_by_lines'.
11124
1c470562
SM
111252011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11126
44f230aa
SM
11127 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11128 steal a few bits to be more compact.
11129 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11130 Remove unneeded casts.
11131
1c470562
SM
11132 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11133
888adce9
ZK
111342011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11135
11136 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11137 binding" message (bug#7967).
11138
f838ed7b
PE
111392011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11140
77861b95
PE
11141 Fix more problems found by GCC 4.6.0's static checks.
11142
de6dbc14
PE
11143 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11144 Remove unused local var.
11145
f838ed7b
PE
11146 * editfns.c (Fmessage_box): Remove unused local var.
11147
792c7b2b
PE
11148 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11149 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11150 Omit unused local vars.
c499e557 11151 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11152 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11153 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11154 Omit unused local var.
11155
ba0165e1
PE
11156 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11157 Don't assume string length fits in int.
32ad8845 11158 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11159 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11160
3c59b4c9
PE
11161 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11162 instead of alloca (Bug#8344).
11163
a3eed478 11164 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11165 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11166
eb4d412d
PE
11167 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11168
1658b401
PE
11169 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11170 concerns.
11171
11172 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11173
11174 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11175
9a2c6e05
PE
11176 * keyboard.c (syms_of_keyboard): Use the same style as later
11177 in this function when indexing through an array. This also
11178 works around GCC bug 48267.
11179
03d0a109
PE
11180 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11181
44f730c8
PE
11182 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11183
fe75f926
PE
11184 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11185 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11186
ffa8c828
PE
11187 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11188 This avoids undefined behavior on integer overflow, and is a bit
11189 more convenient anyway since it is compared to a size_t variable.
11190
c5101a77
PE
11191 Variadic C functions now count arguments with size_t, not int.
11192 This avoids an unnecessary limitation on 64-bit machines, which
11193 caused (substring ...) to crash on large vectors (Bug#8344).
11194 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11195 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11196 All variadic functions and their callers changed accordingly.
c5101a77
PE
11197 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11198 * data.c (arith_driver, float_arith_driver): Likewise.
11199 * editfns.c (general_insert_function): Likewise.
11200 * eval.c (struct backtrace.nargs, interactive_p)
11201 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11202 (funcall_lambda, mark_backtrace): Likewise.
11203 * fns.c (concat): Likewise.
11204 * frame.c (x_set_frame_parameters): Likewise.
11205 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11206 0 if not found, not -1. All callers changed.
11207
dd3f25f7
PE
11208 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11209 (stack_copy_size): Now size_t, not int.
11210 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11211
461c2ab9
JB
112122011-03-28 Juanma Barranquero <lekktu@gmail.com>
11213
11214 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11215 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11216 All callers changed.
11217
11218 * lisp.h (multibyte_char_to_unibyte):
11219 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11220 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11221 * character.h (CHAR_TO_BYTE8):
11222 * cmds.c (internal_self_insert):
11223 * editfns.c (general_insert_function):
11224 * keymap.c (push_key_description):
11225 * search.c (Freplace_match):
11226 * xdisp.c (message_dolog, set_message_1): All callers changed.
11227
f6d62986
SM
112282011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11229
11230 * keyboard.c (safe_run_hook_funcall): New function.
11231 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11232 don't set the hook to nil, but remove the offending function instead.
11233 (Qcommand_hook_internal): Remove, unused.
11234 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11235 Vcommand_hook_internal.
11236
11237 * eval.c (enum run_hooks_condition): Remove.
11238 (funcall_nil, funcall_not): New functions.
11239 (run_hook_with_args): Call each function through a `funcall' argument.
11240 Remove `cond' argument, now redundant.
11241 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11242 (Frun_hook_with_args_until_failure): Adjust accordingly.
11243 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11244
1db5b1ad
JB
112452011-03-28 Juanma Barranquero <lekktu@gmail.com>
11246
11247 * dispextern.h (string_buffer_position): Remove declaration.
11248
11249 * print.c (strout): Remove parameter `multibyte', unused since
11250 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11251
11252 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11253 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11254 All callers changed.
11255
11256 * w32.c (_wsa_errlist): Use braces for struct initializers.
11257
11258 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11259 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11260 All callers changed.
11261 (string_buffer_position): Likewise. Also, make static (it's never
11262 used outside xdisp.c).
11263 (cursor_row_p): Remove parameter `w', unused since
11264 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11265 (decode_mode_spec): Remove parameter `precision', introduced during
11266 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11267 All callers changed.
11268
5ffb62aa
JD
112692011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11270
11271 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11272
461c2ab9 112732011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11274
11275 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11276 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11277 (ns_update_auto_hide_menu_bar): New functions.
11278 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11279 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11280 ns_constrain_all_frames.
11281 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11282 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11283
5c380ffb
JD
112842011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11285
11286 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11287
9af30bdf
GM
112882011-03-27 Glenn Morris <rgm@gnu.org>
11289
11290 * syssignal.h: Replace RETSIGTYPE with void.
11291 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11292 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11293 Replace SIGTYPE with void everywhere.
11294 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11295 * s/template.h (SIGTYPE): Remove commented out definition.
11296
e2abce01
JB
112972011-03-26 Eli Zaretskii <eliz@gnu.org>
11298
11299 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11300 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11301
f868cd8a
JB
113022011-03-26 Juanma Barranquero <lekktu@gmail.com>
11303
59eb0929
JB
11304 * w32.c (read_unc_volume): Use parameter `henum', instead of
11305 global variable `wget_enum_handle'.
11306
11307 * keymap.c (describe_vector): Remove parameters `indices' and
11308 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11309 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11310
f868cd8a
JB
11311 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11312
11313 * keyboard.c (timer_check): Remove parameter `do_it_now',
11314 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11315 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11316 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11317
11318 * keyboard.c (read_char):
11319 * w32menu.c (w32_menu_display_help):
11320 * xmenu.c (show_help_event, menu_help_callback):
11321 Adjust calls to `show_help_echo'.
11322
11323 * gtkutil.c (xg_maybe_add_timer):
11324 * keyboard.c (readable_events):
11325 * process.c (wait_reading_process_output):
11326 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11327
11328 * insdel.c (adjust_markers_gap_motion):
11329 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11330 (gap_left, gap_right): Don't call it.
11331
2ecf6fdb
CY
113322011-03-25 Chong Yidong <cyd@stupidchicken.com>
11333
11334 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11335 incurred during fontification.
11336
6b1f9ba4
JB
113372011-03-25 Juanma Barranquero <lekktu@gmail.com>
11338
11339 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11340 (DEFVAR_PER_BUFFER): Don't pass it.
11341
11342 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11343 (scrolling_window): Don't pass it.
11344
0f4a96b5
JB
113452011-03-25 Juanma Barranquero <lekktu@gmail.com>
11346
11347 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11348
11349 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11350 and `suffix'.
11351 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11352 of variables specific to SELinux and computation of `encoded_absname'.
11353
11354 * image.c (XPutPixel): Remove unused variable `height'.
11355
11356 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11357
11358 * unexw32.c (get_section_info): Remove unused variable `section'.
11359
11360 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11361 (system_process_attributes): Remove unused variable `sess'.
11362 (sys_read): Remove unused variable `err'.
11363
11364 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11365 (w32_wnd_proc): Remove unused variable `isdead'.
11366 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11367 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11368 (x_create_tip_frame): Remove unused variable `tem'.
11369
11370 * w32inevt.c (w32_console_read_socket):
11371 Remove unused variable `no_events'.
11372
11373 * w32term.c (x_draw_composite_glyph_string_foreground):
11374 Remove unused variable `width'.
11375
1149507c
JB
113762011-03-24 Juanma Barranquero <lekktu@gmail.com>
11377
11378 * w32term.c (x_set_glyph_string_clipping):
11379 Don't pass uninitialized region to CombineRgn.
11380
9c88f339
JB
113812011-03-23 Juanma Barranquero <lekktu@gmail.com>
11382
11383 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11384 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11385 (Fx_close_connection): Remove unused variable `i'.
11386
11387 * w32font.c (w32font_draw): Return number of glyphs.
11388 (w32font_open_internal): Remove unused variable `i'.
11389 (w32font_driver): Add missing initializer.
11390
11391 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11392 (fill_in_menu): Remove unused variable `items_added'.
11393
11394 * w32term.c (last_mouse_press_frame): Remove static global variable.
11395 (w32_clip_to_row): Remove unused variable `f'.
11396 (x_delete_terminal): Remove unused variable `i'.
11397
11398 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11399 (NOTHING): Remove unused static global variable.
11400 (uniscribe_check_otf): Remove unused variable `table'.
11401 (uniscribe_font_driver): Add missing initializers.
11402
dee091a3
JD
114032011-03-23 Julien Danjou <julien@danjou.info>
11404
11405 * term.c (Fsuspend_tty, Fresume_tty):
11406 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11407 * window.c (temp_output_buffer_show):
11408 * insdel.c (signal_before_change):
11409 * frame.c (Fhandle_switch_frame):
11410 * fileio.c (Fdo_auto_save):
11411 * emacs.c (Fkill_emacs):
11412 * editfns.c (save_excursion_restore):
11413 * cmds.c (internal_self_insert):
11414 * callint.c (Fcall_interactively):
11415 * buffer.c (Fkill_all_local_variables):
11416 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11417 Use Frun_hooks.
0f4a96b5 11418 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11419 unconditionally since it does the check itself.
dee091a3 11420
2c520ab5 114212011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11422
c9c49752
PE
11423 Fix more problems found by GCC 4.5.2's static checks.
11424
8abc3f12
PE
11425 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11426 the first time through the loop, since we know p0 < p1 then.
11427 This also avoids a gcc -Wstrict-overflow warning.
11428
a2d26660
PE
11429 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11430 leading to a memory leak, possible in functions like
11431 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11432 of objects (Bug#8318).
a2d26660 11433
916c72e9
PE
11434 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11435 that could (at least in theory) be that large.
11436
19ab8a18
PE
11437 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11438 This is less likely to overflow, and avoids undefined behavior if
11439 overflow does occur. All callers changed. Use strtoul to scan
11440 for the unsigned long integer.
b7cbbd6f
PE
11441 (pint2hrstr): Simplify and tune code slightly.
11442 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11443
f0641eff
PE
11444 * scroll.c (do_scrolling): Work around GCC bug 48228.
11445 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11446
7f650bb9
PE
11447 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11448 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11449 (validate_x_resource_name): Simplify count usage.
11450 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11451
37dd57d1
PE
11452 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11453 fail (Bug#8306).
81e56e61 11454
699979fc 11455 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11456
401bf9b4
PE
11457 * process.c (Fmake_network_process): Use socklen_t, not int,
11458 where POSIX says socklen_t is required in portable programs.
11459 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11460 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11461 (Fmake_network_process, server_accept_connection):
11462 (wait_reading_process_output, read_process_output):
11463 Likewise.
11464
b93aacde
PE
11465 * process.c: Rename or move locals to avoid shadowing.
11466 (list_processes_1, Fmake_network_process):
11467 (read_process_output_error_handler, exec_sentinel_error_handler):
11468 Rename or move locals.
4dc343ee 11469 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11470 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11471 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11472 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11473 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11474
af8a867c 11475 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11476 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11477 Include tparam.h instead, since it declares them.
af8a867c
PE
11478 * cm.h (PC): Remove extern decl; tparam.h now does this.
11479 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11480 * terminfo.c: Include tparam.h, to check interfaces.
11481 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11482 (tparam): Adjust signature to match interface in tparam.h;
11483 this removes some undefined behavior. Check that outstring and len
11484 are zero, which they always are with Emacs.
11485 * tparam.h (PC, BC, UP): New extern decls.
11486
0248044d 11487 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11488 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11489
8ff096c1 11490 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11491 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11492 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11493 (ftfont_list): Remove unused local.
49eaafba
PE
11494 (get_adstyle_property, ftfont_pattern_entity):
11495 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11496 Rename locals to avoid shadowing.
8ff096c1 11497
e2be39f6
PE
11498 * xfont.c (xfont_list_family): Mark var as initialized.
11499
c9735e30
PE
11500 * xml.c (make_dom): Now static.
11501
8f5201ae
PE
11502 * composite.c (composition_compute_stop_pos): Rename local to
11503 avoid shadowing.
b246f932
PE
11504 (composition_reseat_it): Remove unused locals.
11505 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11506 (composition_update_it): Mark var as initialized.
11b61122
PE
11507 (find_automatic_composition): Mark vars as initialized,
11508 with a FIXME (Bug#8290).
8f5201ae 11509
760fbc2c
PE
11510 character.h: Rename locals to avoid shadowing.
11511 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11512 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11513 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11514 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11515 to avoid shadowing.
11516
ff08eb85
PE
11517 * textprop.c (property_change_between_p): Remove; unused.
11518
fc7bf025
PE
11519 * intervals.c (interval_start_pos): Now static.
11520
235d7abc
PE
11521 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11522
44f230aa
SM
11523 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11524 Rename locals to avoid shadowing.
3e7d6594 11525
50060332
PE
11526 * sound.c (wav_play, au_play, Fplay_sound_internal):
11527 Fix pointer signedness.
d01f234b 11528 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11529 (wav_play): Initialize a variable to 0, to prevent undefined
11530 behavior (Bug#8278).
50060332 11531
c4fc4e30
PE
11532 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11533
918436ed
PE
11534 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11535
c939f91b
PE
11536 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11537 clobbering (Bug#8298).
b9c7f648
PE
11538 * sysdep.c (sys_subshell): Likewise.
11539 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11540
6bd8c144
PE
11541 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11542 This should get cleaned up, so that child_setup has the
11543 same signature on all platforms.
11544
7710357c 11545 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11546 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11547
c59da222
CY
115482011-03-22 Chong Yidong <cyd@stupidchicken.com>
11549
11550 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11551 not to be necessary, and produces flickering.
11552
66b87493
GM
115532011-03-20 Glenn Morris <rgm@gnu.org>
11554
11555 * config.in: Remove file.
11556
45b6f6d5
JB
115572011-03-20 Juanma Barranquero <lekktu@gmail.com>
11558
11559 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11560 are now in src/globals.h.
11561 (syms_of_minibuf): Remove spurious & from previous change.
11562
cd394be1 115632011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11564
11565 * minibuf.c (completing-read-function): New variable.
11566 (completing-read-default): Rename from completing-read.
11567 (completing-read): Call completing-read-function.
11568
b14e3e21
CY
115692011-03-19 Juanma Barranquero <lekktu@gmail.com>
11570
11571 * xfaces.c (Fx_load_color_file):
11572 Read color file from absolute filename (bug#8250).
11573
f2b726e6
JB
115742011-03-19 Juanma Barranquero <lekktu@gmail.com>
11575
11576 * makefile.w32-in: Update dependencies.
11577
09f6ff02
EZ
115782011-03-17 Eli Zaretskii <eliz@gnu.org>
11579
11580 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11581
29a6015a
PE
115822011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11583
a3a6c54e
PE
11584 Fix more problems found by GCC 4.5.2's static checks.
11585
b766f867
PE
11586 * process.c (make_serial_process_unwind, send_process_trap):
11587 (sigchld_handler): Now static.
11588
be02381c
PE
11589 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11590 That way, the code declares only the vars that it needs.
11591 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11592 * s/cygwin.h (PTY_ITERATION): Likewise.
11593 * s/darwin.h (PTY_ITERATION): Likewise.
11594 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11595
57048744
PE
11596 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11597 * process.c (allocate_pty): Don't declare stb unless it's needed.
11598
7914961c 11599 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11600 (CONSTANTLIM): Remove; unused.
11601 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11602 Define only if needed.
7914961c 11603
b3967b18
PE
11604 * unexelf.c (unexec): Name an expression,
11605 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11606 Use a different way to cause a compilation error if anyone uses
11607 n rather than nn, a way that does not involve shadowing.
73366a00 11608 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11609
29a6015a
PE
11610 * deps.mk (unexalpha.o): Remove; unused.
11611
43cfc33e 11612 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11613 * unexec.h: New file.
ce701a33
PE
11614 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11615 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11616 Depend on unexec.h.
11617 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11618 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11619 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11620 Change as necessary to match prototype in unexec.h.
ce701a33 11621
01f44d5a
PE
11622 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11623 shadowing.
4f63c6bb 11624 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11625
a6670b0b
PE
11626 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11627 Rename locals to avoid shadowing.
11628
cef2010d 11629 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11630 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11631
d4d7173a
PE
11632 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11633
f08b802a
PE
11634 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11635 warning when compiling print.c.
11636
3ddb0639
PE
11637 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11638 instead of using an uninitialized var.
5ad03b97 11639 (font_sort_entities): Mark var as initialized.
3ddb0639 11640
170a2692
PE
11641 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11642
e663c700
PE
11643 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11644 pointers to constants.
89bc529a 11645 (font_parse_fcname): Remove unused vars.
7b81e2d0 11646 (font_delete_unmatched): Now static.
ea838e10 11647 (font_get_spec): Remove; unused.
13a547c6
PE
11648 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11649 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11650 Rename or move locals to avoid shadowing.
e663c700 11651
2a80c887 11652 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11653 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11654
1384fa33 11655 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11656 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11657
8b2c52e9
PE
11658 * alloc.c (mark_backtrace): Move decl from here ...
11659 * lisp.h: ... to here, so that it can be checked.
11660
475545b5 11661 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11662 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11663 (lisp_indirect_variable): Name an expression,
11664 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11665 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11666
b1349114 11667 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11668 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11669 Use const pointer when appropriate.
b1349114 11670
a2928364
PE
11671 * lisp.h (get_system_name, get_operating_system_release):
11672 Move decls here, to check interfaces.
11673 * process.c (get_operating_system_release): Move decl to lisp.h.
11674 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11675 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11676 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11677 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11678 (Fformat_time_string, Fencode_time, Finsert_char):
11679 (Ftranslate_region_internal, Fformat):
11680 Rename or remove local vars to avoid shadowing.
9710023e 11681 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11682
a415e694
PE
11683 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11684 avoid shadowing.
11685
8ef4622d
PE
11686 * lisp.h (eassert): Check that the argument compiles, even if
11687 ENABLE_CHECKING is not defined.
11688
946f9a5b
PE
11689 * data.c (Findirect_variable): Name an expression, to avoid
11690 gcc -Wbad-function-cast warning.
112396d6 11691 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11692 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11693 (Fmake_variable_buffer_local, Fmake_local_variable):
11694 Mark variables as initialized.
52746918 11695 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11696
e5aab7e7 11697 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11698 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11699 Rename locals to avoid shadowing.
dff45157
PE
11700 (mark_stack): Move local variables into the #ifdef region where
11701 they're used.
7bc26fdb
PE
11702 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11703 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11704 needed otherwise.
11705 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11706 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11707 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11708
e5aab7e7
PE
11709 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11710 avoids undefined behavior in theory.
11711
4da60324
PE
11712 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11713
88043301
PE
11714 Use functions, not macros, for up- and down-casing (Bug#8254).
11715 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11716 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11717 to use the following functions instead of these macros.
11718 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11719 EMACS_INT, since callers assume the returned value fits in int.
11720 (upcase1): Likewise, for UPCASE_TABLE.
11721 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11722 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11723 the race-condition problem in the old DOWNCASE.
88043301 11724
19ed5445
PE
11725 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11726 Rename locals to avoid shadowing.
11727 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11728 (regex_compile, re_search_2, re_match_2_internal):
11729 Remove unused local vars.
952db0d7
PE
11730 (FREE_VAR): Rewrite so as not to use empty "else",
11731 which gcc can warn about.
da053e48 11732 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11733 (RETALLOC_IF): Define only if needed.
11734 (WORDCHAR_P): Likewise. This one is never needed, but is used
11735 only in a comment talking about a compiler bug, so put inside
11736 the #if 0 of that comment.
11737 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11738 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11739 Remove; unused.
19ed5445 11740
1f3561e4 11741 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11742 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11743 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11744
ded6f8f7
PE
11745 * search.c (simple_search): Remove unused var.
11746
dbd37a95
PE
11747 * dired.c (compile_pattern): Move decl from here ...
11748 * lisp.h: ... to here, so that it can be checked.
11749 (struct re_registers): New forward decl.
11750
7e47afad
PE
11751 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11752
85f24f61
PE
11753 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11754 All uses changed.
11755 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11756 Rename locals to avoid shadowing.
5671df8f 11757 (Fvertical_motion): Mark locals as initialized.
85f24f61 11758
181aa2be 11759 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11760 (casify_region): Mark local as initialized.
181aa2be 11761
930d429c
PE
11762 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11763
7082eac6
PE
11764 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11765 New macros, so that the caller can use some names other than
11766 gcpro1, gcpro2, etc.
11767 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11768 of the new macros.
11769 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11770 argument, for consistency with GCPRO2_VAR, etc: it is now the
11771 prefix of the variable, not the variable itself. All uses
11772 changed.
38b2c076
PE
11773 * dired.c (directory_files_internal, file_name_completion):
11774 Rename locals to avoid shadowing.
11775
15206ed9
PE
11776 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11777 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11778 dired.c's scmp function, had undefined behavior.
11779 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11780 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11781 * buffer.h: ... to here, because these macros use current_buffer,
11782 and the new implementation with inline functions needs to have
11783 current_buffer in scope now, rather than later when the macros
11784 are used.
11785 (downcase, upcase1): New static inline functions.
11786 (DOWNCASE, UPCASE1): Reimplement using these functions.
11787 This avoids undefined behavior in expressions like
11788 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11789 from race conditions in accessing the global variables
11790 case_temp1 and case_temp2.
11791 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11792 * lisp.h (case_temp1, case_temp2): Remove their decls.
11793 * character.h (ASCII_CHAR_P): Move from here ...
11794 * lisp.h: ... to here, so that the inline functions mentioned
11795 above can use them.
11796
4a6bea26
PE
11797 * dired.c (directory_files_internal_unwind): Now static.
11798
f14b7e14
PE
11799 * fileio.c (file_name_as_directory, directory_file_name):
11800 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11801 Now static.
2893f146
PE
11802 (file_name_as_directory): Use const pointers when appropriate.
11803 (Fexpand_file_name): Likewise. In particular, newdir might
11804 point at constant storage, so make it a const pointer.
fd4ead52 11805 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11806 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11807 signedness issues.
f839df0c
PE
11808 (Fset_file_times, Finsert_file_contents, auto_save_error):
11809 Rename locals to avoid shadowing.
f14b7e14 11810
5716756e 11811 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11812 (Ftry_completion, Fall_completions): Rename or remove locals
11813 to avoid shadowing.
5716756e 11814
b4c3046a
PE
11815 * marker.c (bytepos_to_charpos): Remove; unused.
11816
b45db522
PE
11817 * lisp.h (verify_bytepos, count_markers): New decls,
11818 so that gcc does not warn that these functions aren't declared.
11819
85876d07
PE
11820 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11821 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11822 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11823 (copy_text): Remove unused local var.
85876d07 11824
03d78a21 11825 * filelock.c (within_one_second): Now static.
b3dd38ab 11826 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11827
5df8f01b
PE
11828 * buffer.c (fix_overlays_before): Mark locals as initialized.
11829 (fix_start_end_in_overlays): Likewise. This function should be
11830 simplified by using pointers-to-pointers, but that's a different
11831 matter.
b1d876f1 11832 (switch_to_buffer_1): Now static.
8f54f30a
PE
11833 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11834 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11835
a70072c9 11836 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11837 Fix pointer signedness issue.
edced198
PE
11838 (sys_subshell): Mark local as volatile if checking for lint,
11839 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11840 (MAXPATHLEN): Define only if needed.
a70072c9 11841
a0977c44
PE
11842 * process.c (serial_open, serial_configure): Move decls from here ...
11843 * systty.h: ... to here, so that they can be checked.
11844
a884fdcc
PE
11845 * fns.c (get_random, seed_random): Move extern decls from here ...
11846 * lisp.h: ... to here, so that they can be checked.
11847
604efe86 11848 * sysdep.c (reset_io): Now static.
b8950c94 11849 (wait_for_termination_signal): Remove; unused.
604efe86 11850
38fc62d9
PE
11851 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11852 (copy_keymap_item, append_key, push_text_char_description):
11853 Now static.
1004a21a 11854 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11855 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11856 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11857 (describe_map_tree):
11858 Rename locals to avoid shadowing.
38fc62d9 11859
2f2650da
PE
11860 * keyboard.c: Declare functions static if they are not used elsewhere.
11861 (echo_char, echo_dash, cmd_error, top_level_2):
11862 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11863 (read_char, kbd_buffer_get_event, make_lispy_position):
11864 (make_lispy_event, make_lispy_movement, apply_modifiers):
11865 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11866 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11867 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11868 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11869 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11870
a053e86c 11871 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11872 (mark_kboards): Move decl here ...
11873 * alloc.c (mark_kboards): ... from here.
a053e86c 11874
4752793e
PE
11875 * lisp.h (force_auto_save_soon): New decl.
11876
74f10ca7 11877 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11878 (DEFINE_DUMMY_FUNCTION): New macro.
11879 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11880 Use it.
c03cd23f
PE
11881 (main): Add casts to avoid warnings
11882 if GCC considers string literals to be constants.
74f10ca7 11883
022e70d4
PE
11884 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11885
59d6fe83
PE
11886 * dbusbind.c: Pointer signedness fixes.
11887 (xd_signature, xd_append_arg, xd_initialize):
11888 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11889 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11890 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11891 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11892
78320123
PE
11893 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11894 if GCC considers string literals to be constants.
49cebcca 11895 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11896
35ac2a97
SM
118972011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11898
fb103ca9
SM
11899 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11900 (print_preprocess, print_object): New macro to fix last change.
11901
35ac2a97
SM
11902 * print.c (print_preprocess): Don't forget font objects.
11903
62973b41
JB
119042011-03-16 Juanma Barranquero <lekktu@gmail.com>
11905
11906 * emacs.c (USAGE3): Doc fixes.
11907
0e48bb22
AS
119082011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11909
11910 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11911 structure.
11912
7684e57b
JB
119132011-03-14 Juanma Barranquero <lekktu@gmail.com>
11914
11915 * lisp.h (VWindow_system, Qfile_name_history):
11916 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11917 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11918 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11919
11920 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11921 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11922
11923 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11924 * w32console.c (detect_input_pending, read_input_pending)
11925 (encode_terminal_code):
11926 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11927 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11928 (w32_system_caret_y, Qfile_name_history):
11929 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11930 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11931 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11932 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11933 * w32proc.c (Qlocal, report_file_error):
11934 * w32term.c (Vwindow_system, updating_frame):
11935 * w32uniscribe.c (initialized, uniscribe_font_driver):
11936 Remove unneeded extern declarations.
11937
2aa46d6c
CY
119382011-03-14 Chong Yidong <cyd@stupidchicken.com>
11939
c96bbc66 11940 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11941
cffc6f3b
CY
119422011-03-13 Chong Yidong <cyd@stupidchicken.com>
11943
11944 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11945 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11946 These macros can no longer be used for assignment.
11947
44f230aa
SM
11948 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11949 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11950 (record_buffer_markers, fetch_buffer_markers): New functions for
11951 recording and fetching special buffer markers.
11952 (set_buffer_internal_1, set_buffer_temp): Use them.
11953
11954 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11955
11956 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11957
11958 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11959 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11960
11961 * xdisp.c (hscroll_window_tree):
11962 (reconsider_clip_changes): Use PT instead of BUF_PT.
11963
d251f04b
EZ
119642011-03-13 Eli Zaretskii <eliz@gnu.org>
11965
11966 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11967 $(EMACS_ROOT)/lib/intprops.h.
11968
f0c77cd1
PE
119692011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11970
3eca4629
PE
11971 Fix more problems found by GCC 4.5.2's static checks.
11972
7c86ee98
PE
11973 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11974 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11975 (xg_free_frame_widgets): Make it clear that a local variable is
11976 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11977 (gdk_window_get_screen): Make it clear that this macro is needed
11978 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11979 (int_gtk_range_get_value): New function, which avoids a diagnostic
11980 from gcc -Wbad-function-cast.
11981 (xg_set_toolkit_scroll_bar_thumb): Use it.
11982 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11983 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11984 (get_utf8_string, xg_get_file_with_chooser):
11985 Rename locals to avoid shadowing.
11986 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11987
41729b81
PE
11988 * xgselect.c (xg_select): Remove unused var.
11989
f0c77cd1
PE
11990 * image.c (four_corners_best): Mark locals as initialized.
11991 (gif_load): Initialize transparent_p to zero (Bug#8238).
11992 Mark another local as initialized.
ec6cf4c6 11993 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11994
ce0ad53d 11995 * image.c (clear_image_cache): Now static.
d5d5a617 11996 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11997 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11998 (x_edge_detection): Remove unnecessary cast that
11999 gcc -Wbad-function-cast diagnoses.
2037898d 12000 (gif_load): Fix pointer signedness.
6ae141d6
PE
12001 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12002 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12003
33383987 120042011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12005
d32df629
PE
12006 Improve quality of tests for time stamp overflow.
12007 For example, without this patch (encode-time 0 0 0 1 1
12008 1152921504606846976) returns the obviously-bogus value (-948597
12009 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12010 reports time overflow. See
12011 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12012 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12013 * editfns.c: Include limits.h and intprops.h.
12014 (TIME_T_MIN, TIME_T_MAX): New macros.
12015 (time_overflow): Move earlier, to before first use.
12016 (hi_time, lo_time): New functions, for an accurate test for
12017 out-of-range times.
12018 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12019 (Fget_internal_run_time): Don't assume time_t fits in int.
12020 (make_time): Use list2 instead of Fcons twice.
12021 (Fdecode_time): More accurate test for out-of-range times.
12022 (check_tm_member): New function.
12023 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12024 (lisp_time_argument): Don't rely on undefined left-shift and
12025 right-shift behavior when checking for time stamp overflow.
8be6f318 12026
fe31d94c
PE
12027 * editfns.c (time_overflow): New function, refactoring common code.
12028 (Fformat_time_string, Fdecode_time, Fencode_time):
12029 (Fcurrent_time_string): Use it.
12030
8be6f318
PE
12031 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12032 * dired.c (make_time): Move to ...
12033 * editfns.c (make_time): ... here.
12034 * systime.h: Note the move.
12035
09d9db2c 120362011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12037
126bc0dc
YM
12038 * fringe.c (update_window_fringes): Remove unused variables.
12039
c47cbdfd
YM
12040 * unexmacosx.c (copy_data_segment): Also copy __got section.
12041 (Bug#8223)
12042
7ac80be9
EZ
120432011-03-12 Eli Zaretskii <eliz@gnu.org>
12044
c96bbc66 12045 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12046 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12047 Constify `char *' arguments and their references according to
12048 prototypes in tparam.h.
12049
ecb0f94d 12050 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12051
7ac80be9
EZ
12052 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12053 Adapt all references accordingly.
12054
12055 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12056
ef1fd07e
TT
120572011-03-11 Tom Tromey <tromey@redhat.com>
12058
12059 * buffer.c (syms_of_buffer): Remove obsolete comment.
12060
7ef4b50c
EZ
120612011-03-11 Eli Zaretskii <eliz@gnu.org>
12062
12063 * termhooks.h (encode_terminal_code): Declare prototype.
12064
12065 * msdos.c (encode_terminal_code): Don't declare prototype.
12066
12067 * term.c (encode_terminal_code): Now external again, used by
12068 w32console.c and msdos.c.
12069
44f230aa
SM
12070 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12071 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12072
4b1ec863 120732011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12074
1714f52b 12075 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12076
4b1ec863
PE
12077 * fringe.c (update_window_fringes): Mark locals as initialized
12078 (Bug#8227).
12079 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12080
524c7aa6
PE
12081 * alloc.c (mark_fringe_data): Move decl from here ...
12082 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12083 to check its interface.
12084 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12085
a5c0af81 12086 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12087 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12088 (fontset_font): Mark local as initialized.
a9a06e0b 12089 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12090
b4716021
PE
12091 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12092
811e9bac 12093 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12094 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12095 (x_own_selection, Fx_disown_selection_internal): Rename locals
12096 to avoid shadowing.
12097 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12098
7e3ab302
PE
12099 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12100 so that the caller can use some name other than gcpro1.
12101 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12102 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12103 (Fx_backspace_delete_keys_p):
12104 Use them to avoid shadowing, and rename vars to avoid shadowing.
12105 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12106 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12107 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12108 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12109 Remove unused locals.
7e3ab302
PE
12110 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12111 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12112 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12113 macros.
f78faa98 12114
e2b13473
PE
12115 * xterm.h (x_mouse_leave): New decl.
12116
77f23912
PE
12117 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12118 Remove unused functions.
cdf4ba58
PE
12119 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12120 (x_calc_absolute_position): Now static.
7411c686 12121 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12122 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12123 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12124 unless they are used.
38d0b34a
PE
12125 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12126 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12127 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12128 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12129 (x_error_catcher, x_connection_closed, x_error_handler):
12130 (x_error_quitter, xembed_send_message, x_iconify_frame):
12131 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12132 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12133 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12134
44f230aa
SM
12135 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12136 Rename or move locals to avoid shadowing.
6b463e58 12137 (tty_defined_color, merge_face_heights): Now static.
5967d051 12138 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12139 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12140 does not deduce is never used uninitialized.
73719eba
PE
12141 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12142 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12143
426994c3 12144 * terminal.c (store_terminal_param): Now static.
5489860b 12145
032f1620 12146 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12147 (set_frame_menubar): Remove unused local.
d4323972 12148 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12149 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12150 since they might point to immutable storage.
281585b0
PE
12151 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12152 since it's unused otherwise.
032f1620 12153
367c19e5 12154 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12155 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12156 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12157 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12158 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12159 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12160 does not deduce are never used uninitialized.
70739cbe 12161
07b48fa9
PE
12162 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12163
8868a238 12164 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12165 * window.c (window_loop, size_window):
12166 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12167
7e5cf297 12168 * window.c (display_buffer): Now static.
d6550a9f
PE
12169 (size_window): Mark variables that gcc -Wuninitialized
12170 does not deduce are never used uninitialized.
a586633d
PE
12171 * window.h (check_all_windows): New decl, to forestall
12172 gcc -Wmissing-prototypes diagnostic.
5b555da1 12173 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12174
f6095868
PE
12175 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12176 shadowing.
12177 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12178 Include <limits.h>.
12179 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12180 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12181 (load_charset_map): Mark variables that gcc -Wuninitialized
12182 does not deduce are never used uninitialized.
53df7c11 12183 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12184
f38b440c
PE
12185 * coding.c (coding_set_source, coding_set_destination):
12186 Use "else { /* comment */ }" rather than "else /* comment */;"
12187 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12188 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12189 a block, when the outer 'i' will do.
12190 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12191 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12192 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12193 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12194 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12195 Rename locals to avoid shadowing.
12196 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12197 * coding.c (emacs_mule_char, encode_invocation_designation):
12198 Now static, since they're not used elsewhere.
413bb2db 12199 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12200 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12201 (decode_coding_emacs_mule): Mark variables that gcc
12202 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12203 (detect_coding_iso_2022): Initialize a local variable that might
12204 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12205 this initialization is needed. (Bug#8211)
5f58e762
PE
12206 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12207 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12208 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12209 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12210 Remove unused macros.
f38b440c 12211
232b38b9 12212 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12213 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12214 * character.c (string_count_byte8): Likewise.
232b38b9 12215
fb90da1b
PE
12216 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12217 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12218
fb93dbc2
PE
12219 * chartab.c (copy_sub_char_table): Now static, since it's not used
12220 elsewhere.
5c156ace
PE
12221 (sub_char_table_ref_and_range, char_table_ref_and_range):
12222 Rename locals to avoid shadowing.
bbcd0949 12223 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12224
7d3b3862 12225 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12226 (BIDI_BOB): Remove unused macro.
7d3b3862 12227
6be7d3da
PE
12228 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12229 deduce are never used uninitialized.
c2ed9c8b 12230 * term.c (encode_terminal_code): Likewise.
6be7d3da 12231
75f8807f 12232 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12233
50938595
PE
12234 * tparam.h: New file.
12235 * term.c, tparam.h: Include it.
12236 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12237 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12238 Move these decls to tparam.h, and make them agree with what
12239 is actually in tparam.c. The previous trick of using incompatible
12240 decls in different modules does not conform to the C standard.
12241 All callers of tparam changed to use tparam's actual API.
12242 * tparam.c (tparam1, tparam, tgoto):
12243 Use const pointers where appropriate.
12244
fbceeba2
PE
12245 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12246 * cm.h (struct cm): Likewise.
12247 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12248 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12249 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12250 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12251 (turn_on_face, init_tty): Likewise.
12252 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12253
7f3f1250
PE
12254 * term.c (term_mouse_position): Rename local to avoid shadowing.
12255
e6ca6543
PE
12256 * alloc.c (mark_ttys): Move decl from here ...
12257 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12258
c40f8d15
AS
122592011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12260
12261 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12262
cfe0661d
JB
122632011-03-09 Juanma Barranquero <lekktu@gmail.com>
12264
12265 * search.c (compile_pattern_1): Remove argument regp, unused since
12266 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12267 (compile_pattern): Don't pass it.
12268
0afb4571
J
122692011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12270
12271 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12272 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12273 for ! HAVE_GTK3.
12274 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12275
12276 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12277
12278 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12279 gdk_window_get_screen, gdk_window_get_geometry,
12280 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12281 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12282 (xg_get_pixbuf_from_pixmap): New function.
12283 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12284 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12285 Call xg_get_pixbuf_from_pixmap instead of
12286 gdk_pixbuf_get_from_drawable.
12287 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12288 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12289 (xg_check_special_colors): Use GtkStyleContext and its functions
12290 for HAVE_GTK3.
12291 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12292 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12293 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12294 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12295 Call gtk_widget_get_preferred_size.
0afb4571
J
12296 (xg_frame_resized): gdk_window_get_geometry only takes 5
12297 parameters.
44f230aa
SM
12298 (xg_win_to_widget, xg_event_is_for_menubar):
12299 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12300 (xg_set_widget_bg): New function.
12301 (delete_cb): New function.
895009e1 12302 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12303 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12304 (xg_set_background_color): Call xg_set_widget_bg.
12305 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12306 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12307 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12308 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12309 if ! HAVE_GTK3.
12310 (update_frame_tool_bar): Call gtk_widget_hide.
12311 (xg_initialize): Use GDK_KEY_g.
12312
12313 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12314 if ! HAVE_GTK3
12315 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12316
12317 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12318 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12319 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12320
1c2cc4ef
JB
123212011-03-08 Juanma Barranquero <lekktu@gmail.com>
12322
12323 * w32xfns.c (select_palette): Check success of RealizePalette against
12324 GDI_ERROR, not zero.
12325
33383987 12326See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12327
12328;; Local Variables:
12329;; coding: utf-8
aac0c6e3
MR
12330;; End:
12331
2f097256 12332 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12333
12334 This file is part of GNU Emacs.
12335
12336 GNU Emacs is free software: you can redistribute it and/or modify
12337 it under the terms of the GNU General Public License as published by
12338 the Free Software Foundation, either version 3 of the License, or
12339 (at your option) any later version.
12340
12341 GNU Emacs is distributed in the hope that it will be useful,
12342 but WITHOUT ANY WARRANTY; without even the implied warranty of
12343 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12344 GNU General Public License for more details.
12345
12346 You should have received a copy of the GNU General Public License
12347 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.