Minor additions for previous emacsclient change.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
cd3520a4
JB
12011-06-24 Juanma Barranquero <lekktu@gmail.com>
2
3 Move DEFSYM to lisp.h and use everywhere.
4
5 * character.h (DEFSYM): Move declaration...
6 * lisp.h (DEFSYM): ...here.
7
8 * gnutls.c:
9 * minibuf.c:
10 * w32menu.c:
11 * w32proc.c:
12 * w32select.c: Don't include character.h.
13
14 * alloc.c (syms_of_alloc):
15 * buffer.c (syms_of_buffer):
16 * bytecode.c (syms_of_bytecode):
17 * callint.c (syms_of_callint):
18 * casefiddle.c (syms_of_casefiddle):
19 * casetab.c (init_casetab_once):
20 * category.c (init_category_once, syms_of_category):
21 * ccl.c (syms_of_ccl):
22 * cmds.c (syms_of_cmds):
23 * composite.c (syms_of_composite):
24 * dbusbind.c (syms_of_dbusbind):
25 * dired.c (syms_of_dired):
26 * dispnew.c (syms_of_display):
27 * doc.c (syms_of_doc):
28 * editfns.c (syms_of_editfns):
29 * emacs.c (syms_of_emacs):
30 * eval.c (syms_of_eval):
31 * fileio.c (syms_of_fileio):
32 * fns.c (syms_of_fns):
33 * frame.c (syms_of_frame):
34 * fringe.c (syms_of_fringe):
35 * insdel.c (syms_of_insdel):
36 * keymap.c (syms_of_keymap):
37 * lread.c (init_obarray, syms_of_lread):
38 * macros.c (syms_of_macros):
39 * msdos.c (syms_of_msdos):
40 * print.c (syms_of_print):
41 * process.c (syms_of_process):
42 * search.c (syms_of_search):
43 * sound.c (syms_of_sound):
44 * syntax.c (init_syntax_once, syms_of_syntax):
45 * terminal.c (syms_of_terminal):
46 * textprop.c (syms_of_textprop):
47 * undo.c (syms_of_undo):
48 * w32.c (globals_of_w32):
49 * window.c (syms_of_window):
50 * xdisp.c (syms_of_xdisp):
51 * xfaces.c (syms_of_xfaces):
52 * xfns.c (syms_of_xfns):
53 * xmenu.c (syms_of_xmenu):
54 * xsettings.c (syms_of_xsettings):
55 * xterm.c (syms_of_xterm): Use DEFSYM.
56
4228cf16
TZ
572011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
58
cd3520a4 59 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 60
7fcccf1e
PE
612011-06-23 Paul Eggert <eggert@cs.ucla.edu>
62
7efb4e0e
PE
63 Integer and buffer overflow fixes (Bug#8873).
64
ff5844ad
PE
65 * print.c (printchar, strout): Check for string overflow.
66 (PRINTPREPARE, printchar, strout):
67 Don't set size unless allocation succeeds.
68
90532f02
PE
69 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
70 for sizes. Check for string overflow more accurately.
71 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
72
6d84508d
PE
73 * macros.c: Integer and buffer overflow fixes.
74 * keyboard.h (struct keyboard.kbd_macro_bufsize):
75 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
76 Use ptrdiff_t, not int, for sizes.
77 Don't increment bufsize until after realloc succeeds.
78 Check for size-calculation overflow.
79 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
80
437b2cb4
PE
81 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
82
8b9ac8b4
PE
83 * lread.c: Integer overflow fixes.
84 (read_integer): Radix is now EMACS_INT, not int,
85 to improve quality of diagnostics for out-of-range radices.
86 Calculate buffer size correctly for out-of-range radices.
87 (read1): Check for integer overflow in radices, and in
88 read-circle numbers.
82cb60d3
PE
89 (read_escape): Avoid int overflow.
90 (Fload, openp, read_buffer_size, read1)
91 (substitute_object_recurse, read_vector, read_list, map_obarray):
92 Use ptrdiff_t, not int, for sizes.
93 (read1): Use EMACS_INT, not int, for sizes.
20270765 94 Check for size overflow.
8b9ac8b4 95
7fcccf1e
PE
96 * image.c (cache_image): Check for size arithmetic overflow.
97
bfbbd7e7
PE
98 * lread.c: Integer overflow issues.
99 (saved_doc_string_size, saved_doc_string_length)
100 (prev_saved_doc_string_size, prev_saved_doc_string_length):
101 Now ptrdiff_t, not int.
102 (read1): Don't assume doc string length fits in int. Check for
103 out-of-range doc string lengths.
104 (read_list): Don't assume file position fits in int.
39019e54 105 (read_escape): Check for hex character overflow.
bfbbd7e7 106
4e323265
LL
1072011-06-22 Leo Liu <sdl.web@gmail.com>
108
109 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
110 Move to minibuffer.el.
111
85fece3e
PE
1122011-06-22 Paul Eggert <eggert@cs.ucla.edu>
113
20b84ce9 114 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
115 The following patches are for when GLYPH_DEBUG && !XASSERT.
116 * dispextern.h (trace_redisplay_p, dump_glyph_string):
117 * dispnew.c (flush_stdout):
118 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
119 Mark as externally visible.
120 * dispnew.c (check_window_matrix_pointers): Now static.
121 * dispnew.c (window_to_frame_vpos):
122 * xfns.c (unwind_create_frame):
123 * xterm.c (x_check_font): Remove unused local.
124 * scroll.c (CHECK_BOUNDS):
125 * xfaces.c (cache_fache): Rename local to avoid shadowing.
126 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
127 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
128 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
129 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
130 Now static.
131 (debug_method_add): Use va_list and vsprintf rather than relying
132 on undefined behavior with wrong number of arguments.
133 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
134 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
135 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
136 since we're not interested in debugging glyphs with old libraries.
137 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
138 GCC 4.6.0's static checking.
139
0766b489
PE
1402011-06-22 Paul Eggert <eggert@cs.ucla.edu>
141
31fd4b32
PE
142 Integer overflow and signedness fixes (Bug#8873).
143 A few related buffer overrun fixes, too.
144
b79e8648
PE
145 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
146
0766b489
PE
147 * dispextern.h (struct face.stipple):
148 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
149 (x_bitmap_mask, x_allocate_bitmap_record)
150 (x_create_bitmap_from_data, x_create_bitmap_from_file)
151 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
152 (x_create_bitmap_from_xpm_data):
153 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
154 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
155 (.bitmaps_last):
156 * xfaces.c (load_pixmap):
157 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
158 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
159 (.bitmaps_last, struct x_output.icon_bitmap):
160 Use ptrdiff_t, not int, for bitmap indexes.
161 (x_allocate_bitmap_record): Check for size overflow.
162 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
163
b081724f
PE
164 Use ptrdiff_t, not int, for overlay counts.
165 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
166 * editfns.c (overlays_around, get_pos_property):
167 * textprop.c (get_char_property_and_overlay):
168 * xdisp.c (next_overlay_change, note_mouse_highlight):
169 * xfaces.c (face_at_buffer_position):
21514da7
PE
170 * buffer.c (OVERLAY_COUNT_MAX): New macro.
171 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
172 (Fnext_overlay_change, Fprevious_overlay_change)
173 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 174 Use ptrdiff_t, not int, for sizes.
21514da7 175 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 176
3de73e5e
PE
177 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
178
2606c57b
PE
179 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
180 (x_session_initialize): Do not assume string length fits in int.
181
aaafe47a
PE
182 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
183 This is unlikely, but can occur if DPI is outlandish.
184
2674ddc8 185 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
186 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
187
28154962
PE
188 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
189 * xrdb.c (magic_file_p, search_magic_path):
190 Omit last arg SUFFIX; it was always 0. All callers changed.
191 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
192
7de51af5
PE
193 * xfont.c (xfont_match): Avoid need for strlen.
194
25ed6cc3
PE
195 * xfns.c: Don't assume strlen fits in int.
196 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
197
4eab31dd
PE
198 * xdisp.c (message_log_check_duplicate): Return intmax_t,
199 not unsigned long, as we prefer signed integers. All callers changed.
200 Detect integer overflow in repeat count.
201 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 202 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 203
171e2a58
PE
204 * termcap.c: Don't assume sizes fit in int and never overflow.
205 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
206 (gobble_line): Check for size-calculation overflow.
207
ad39faca 208 * minibuf.c (Fread_buffer):
6e5bb2dc 209 * lread.c (intern, intern_c_string):
74ca2eb3
PE
210 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
211 Don't assume string length fits in int.
212
52c61c22 213 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
214 * gtkutil.c (style_changed_cb): Avoid need for strlen.
215
b5b8c9e5
PE
216 * font.c: Don't assume string length fits in int.
217 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
218 Use ptrdiff_t, not int.
ccd6111c
PE
219 (font_intern_prop): Don't assume string length fits in int.
220 Don't assume integer property fits in fixnum.
221 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 222
882f0d81 223 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 224 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
225 Reformulate so as not to need the command string.
226 Invoke gzip -cd rather than gunzip, as it's more portable.
227 (lock_info_type, lock_file_1, lock_file):
228 Don't assume pid_t and time_t fit in unsigned long.
229 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
230 (current_lock_owner): Prefer signed type for sizes.
231 Use memcpy, not strncpy, where memcpy is what is really wanted.
232 Don't assume (via atoi) that time_t and pid_t fit in int.
233 Check for time_t and/or pid_t out of range, e.g., via a network share.
234 Don't alloca where an auto var works fine.
235
93f4cf88
PE
236 * fileio.c: Fix some integer overflow issues.
237 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
238 Don't assume string length fits in int.
239 (directory_file_name): Don't assume string length fits in long.
240 (make_temp_name): Don't assume pid fits in int, or that its print
241 length is less than 20.
242
f3e92b69
PE
243 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
244
1bfdaf10
PE
245 * coding.c (make_subsidiaries): Don't assume string length fits in int.
246
35016e9a
PE
247 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
248
3d1e65a1
PE
249 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
250 We prefer signed integers, even for size calculations.
251
0b963a93
PE
252 * emacs.c: Don't assume string length fits in 'int'.
253 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
254 (main): Don't invoke strlen when not needed.
255
573f4b54
PE
256 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
257 (XD_DEBUG_MESSAGE): Don't waste a byte.
258
989f33ba
PE
259 * callproc.c (getenv_internal_1, getenv_internal)
260 (Fgetenv_internal):
965d34eb
PE
261 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
262
e4d29b33
PE
263 * lread.c (invalid_syntax): Omit length argument.
264 All uses changed. This doesn't fix a bug, but it simplifies the
265 code away from its former Hollerith-constant appearance, and it's
266 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 267 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 268
eb49b136
PE
269 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
270 This didn't break anything, but it didn't help either.
271 It's confusing to put a bogus integer in a place where the actual
272 value does not matter.
9f62aeb1 273 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 274 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 275
15375a22
PE
276 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
277 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
278 implementation.
b61cc01c
PE
279 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
280 We prefer signed types, and the value cannot exceed the EMACS_INT
281 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
282 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
283 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
284 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 285
53b2623d
PE
286 * indent.c (sane_tab_width): New function.
287 (current_column, scan_for_column, Findent_to, position_indentation)
288 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 289 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 290
51cab52b 291 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 292
f2ed8a70
PE
293 * lisp.h (lint_assume): New macro.
294 * composite.c (composition_gstring_put_cache):
295 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
296
abe80cc6
PE
297 * editfns.c, insdel.c:
298 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 299
b02c740e
PE
300 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
301
ebc96716
PE
302 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
303
b4e50fa0 304 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 305 Use much-faster test for byte-length change.
311d5d7c 306 Don't assume string byte-length fits in 'int'.
a4cf38e4 307 Check that character arg fits in 'int'.
85461888 308 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 309
c0c1ee9f
PE
310 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
311
a498d7f4
PE
312 * fns.c (concat): Catch string overflow earlier.
313 Do not rely on integer wraparound.
314
51cab52b
PE
315 * dispextern.h (struct it.overlay_strings_charpos)
316 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
317 * xdisp.c (forward_to_next_line_start)
318 (back_to_previous_visible_line_start)
319 (reseat_at_next_visible_line_start, next_element_from_buffer):
320 Don't arbitrarily truncate the value of 'selective' to int.
321
76031fad
PE
322 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
323
5eb55db9
PE
324 * composite.c: Don't truncate sizes to 'int'.
325 (composition_gstring_p, composition_reseat_it)
326 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
327 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
328 not EMACS_UINT, for indexes.
5eb55db9 329
0703a717
PE
330 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
331
d6202519
PE
332 * buffer.c: Include <verify.h>.
333 (struct sortvec.priority, struct sortstr.priority):
8961a454 334 Now EMACS_INT, not int.
c20998a7 335 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
336 (struct sortstr.size, record_overlay_string)
337 (struct sortstrlist.size, struct sortlist.used):
338 Don't truncate size to int.
339 (record_overlay_string): Check for size-calculation overflow.
d6202519 340 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 341
d5a19415
JM
3422011-06-22 Jim Meyering <meyering@redhat.com>
343
344 don't leak an XBM-image-sized buffer
345 * image.c (xbm_load): Free the image buffer after using it.
346
a9041e6c
PE
3472011-06-21 Paul Eggert <eggert@cs.ucla.edu>
348
349 Port to Sun C.
350 * composite.c (find_automatic_composition): Omit needless 'return 0;'
351 that Sun C diagnosed.
352 * fns.c (secure_hash): Fix pointer signedness issue.
353 * intervals.c (static_offset_intervals): New function.
354 (offset_intervals): Use it.
355
7f3f739f
LL
3562011-06-21 Leo Liu <sdl.web@gmail.com>
357
358 * deps.mk (fns.o):
359 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
360 sha512.h.
361
362 * fns.c (secure_hash): Rename from crypto_hash_function and change
363 the first arg to accept symbols.
364 (Fsecure_hash): New primtive.
365 (syms_of_fns): New symbols.
366
76147d94
DD
3672011-06-20 Deniz Dogan <deniz@dogan.se>
368
369 * process.c (Fset_process_buffer): Clarify return value in
370 docstring.
371
7d7d0045
CY
3722011-06-18 Chong Yidong <cyd@stupidchicken.com>
373
374 * dispnew.c (add_window_display_history): Use BVAR.
375
376 * xdisp.c (debug_method_add): Use BVAR.
377 (check_window_end, dump_glyph_matrix, dump_glyph)
378 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
379
380 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
381 Likewise.
382
383 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
384 check till after the cache is created in init_frame_faces.
385
ff2bc410
SM
3862011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
387
388 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
389
28177add
PE
3902011-06-16 Paul Eggert <eggert@cs.ucla.edu>
391
dd3482fe
PE
392 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
393 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
394 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
395
393d71f3 396 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
397 * fileio.c (Finsert_file_contents):
398 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
399 Remove the old (too-loose) buffer overflow checks.
400 They weren't needed, since make_gap checks for buffer overflow.
401 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
402 The old code merely checked for Emacs fixnum overflow, and relied
403 on undefined (wraparound) behavior. The new code avoids undefined
404 behavior, and also checks for ptrdiff_t and/or size_t overflow.
405
2e6813b0 406 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
407 Tune. Don't use wider integers than needed. Don't use alloca.
408 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 409
599a9e4f
PE
410 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
411
99561444
PE
412 * insdel.c, lisp.h (buffer_overflow): New function.
413 (insert_from_buffer_1, replace_range, replace_range_2):
414 * insdel.c (make_gap_larger):
415 * editfns.c (Finsert_char):
416 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
417
28177add
PE
418 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
419
e69dafad
PE
4202011-06-15 Paul Eggert <eggert@cs.ucla.edu>
421
a7af7fde 422 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 423
b1c46f02
PE
424 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
425 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
426
e69dafad
PE
427 * fileio.c: Don't assume EMACS_INT fits in off_t.
428 (emacs_lseek): New static function.
429 (Finsert_file_contents, Fwrite_region): Use it.
430 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
431
566684ea
PE
432 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
433
e6966cd6
PE
434 * fns.c: Don't overflow int when computing a list length.
435 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
436 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
437 truncation on 64-bit hosts. Check for QUIT every
438 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
439 faster and is responsive enough.
440 (Flength): Report an error instead of overflowing an integer.
441 (Fsafe_length): Return a float if the value is not representable
442 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 443 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 444 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 445
dd0b0efb
PE
446 * alloc.c: Check that resized vectors' lengths fit in fixnums.
447 (header_size, word_size): New constants.
448 (allocate_vectorlike): Don't check size overflow here.
449 (allocate_vector): Check it here instead, since this is the only
450 caller of allocate_vectorlike that could cause overflow.
451 Check that the new vector's length is representable as a fixnum.
452
86fe5cfe
PE
453 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
454 The previous code was bogus. For example, next_almost_prime (32)
455 returned 39, which is undesirable as it is a multiple of 3; and
456 next_almost_prime (24) returned 25, which is a multiple of 5 so
457 why was the code bothering to check for multiples of 7?
458
80e88859
PE
459 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
460
4a2f0ad6
PE
461 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
462
f66c7cf8
PE
463 Variadic C functions now count arguments with ptrdiff_t.
464 This partly undoes my 2011-03-30 change, which replaced int with size_t.
465 Back then I didn't know that the Emacs coding style prefers signed int.
466 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
467 were being counted with int, which may truncate counts on 64-bit
468 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
469 * lisp.h (struct Lisp_Subr.function.aMANY)
470 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
471 Arg counts are now ptrdiff_t, not size_t.
472 All variadic functions and their callers changed accordingly.
473 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
474 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
475 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
476 * callint.c (Fcall_interactively): Check arg count for overflow,
477 to avoid potential buffer overrun. Use signed char, not 'int',
478 for 'varies' array, so that we needn't bother to check its size
479 calculation for overflow.
480 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
481 * eval.c (apply_lambda):
482 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
483 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
484 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
485
a1759b76
PE
486 * callint.c (Fcall_interactively): Don't use index var as event count.
487
d96be9fc
PE
488 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
489 * mem-limits.h (SIZE): Remove; no longer used.
490
a690a978 491 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 492
578c21e6
PE
493 Remove unnecessary casts.
494 * xterm.c (x_term_init):
495 * xfns.c (x_set_border_pixel):
496 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
497 These aren't needed now that we assume ANSI C.
498
96f53c6c
PE
499 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
500 It's more likely to cause problems (due to unsigned overflow)
501 than to cure them.
502
83c77d31
PE
503 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
504
ee2079f1
PE
505 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
506
6da65536
PE
507 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
508
7147c4a4
PE
509 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
510
193e32d9
PE
511 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
512
e5533da6
PE
513 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
514
9910e595
PE
515 GLYPH_CODE_FACE returns EMACS_INT, not int.
516 * dispextern.h (merge_faces):
517 * xfaces.c (merge_faces):
01103c44
PE
518 * xdisp.c (get_next_display_element, next_element_from_display_vector):
519 Don't assume EMACS_INT fits in int.
9910e595 520
2638320e
PE
521 * character.h (CHAR_VALID_P): Remove unused parameter.
522 * fontset.c, lisp.h, xdisp.c: All uses changed.
523
045eb8d9
PE
524 * editfns.c (Ftranslate_region_internal): Omit redundant test.
525
c1f134b5
PE
526 * fns.c (concat): Minor tuning based on overflow analysis.
527 This doesn't fix any bugs. Use int to hold character, instead
528 of constantly refetching from Emacs object. Use XFASTINT, not
529 XINT, for value known to be a character. Don't bother comparing
530 a single byte to 0400, as it's always less.
531
395fcb93 532 * floatfns.c (Fexpt):
327eeec8
PE
533 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
534
abbd3d23
PE
535 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
536 for characters.
537
684a03ef
PE
538 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
539
0fed43f3
PE
540 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
541 Without this fix, on a 64-bit host (aset S 0 4294967386) would
542 incorrectly succeed when S was a string, because 4294967386 was
543 truncated before it was used.
544
8fd02eb7
PE
545 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
546 Otherwise, an out-of-range integer could cause undefined behavior
547 on a 64-bit host.
548
f8c86b69
PE
549 * composite.c: Use int, not EMACS_INT, for characters.
550 (fill_gstring_body, composition_compute_stop_pos): Use int, not
551 EMACS_INT, for values that are known to be in character range.
552 This doesn't fix any bugs but is the usual style inside Emacs and
553 may generate better code on 32-bit machines.
554
34206dd2
PE
555 Make sure a 64-bit char is never passed to ENCODE_CHAR.
556 This is for reasons similar to the recent CHAR_STRING fix.
557 * charset.c (Fencode_char): Check that character arg is actually
558 a character. Pass an int to ENCODE_CHAR.
559 * charset.h (ENCODE_CHAR): Verify that the character argument is no
560 wider than 'int', as a compile-time check to prevent future regressions
561 in this area.
562
c5958d4c 563 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
564
565 Make sure a 64-bit char is never passed to CHAR_STRING.
566 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
567 by silently ignoring the top 32 bits, allowing some values
568 that were far too large to be valid characters.
569 * character.h: Include <verify.h>.
570 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
571 arguments are no wider than unsigned, as a compile-time check
572 to prevent future regressions in this area.
573 * data.c (Faset):
01103c44 574 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
575 (Fsubst_char_in_region):
576 * fns.c (concat):
577 * xdisp.c (decode_mode_spec_coding):
578 Adjust to CHAR_STRING's new requirement.
579 * editfns.c (Finsert_char, Fsubst_char_in_region):
580 * fns.c (concat): Check that character args are actually
581 characters. Without this test, these functions did the wrong
582 thing with wildly out-of-range values on 64-bit hosts.
583
d37ca623
PE
584 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
585 These casts should not be needed on 32-bit hosts, either.
586 * keyboard.c (read_char):
587 * lread.c (Fload): Remove casts to unsigned.
588
ea204efb
PE
589 * lisp.h (UNSIGNED_CMP): New macro.
590 This fixes comparison bugs on 64-bit hosts.
591 (ASCII_CHAR_P): Use it.
592 * casefiddle.c (casify_object):
01103c44 593 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
594 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
595 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
596 * dispextern.h (FACE_FROM_ID):
597 * keyboard.c (read_char): Use UNSIGNED_CMP.
598
41cb286c
PE
599 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
600 not to EMACS_INT, to avoid GCC warning.
601
4a1b9832
PE
602 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
603
55daad71
PE
604 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
605 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
606 isn't needed on 32-bit machines.
8f95c75c 607
01103c44
PE
608 * buffer.c (Fgenerate_new_buffer_name):
609 Use EMACS_INT for count, not int.
0ceccced 610 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
611
612 * data.c (Qcompiled_function): Now static.
613
c6f072e7
PE
614 * window.c (window_body_lines): Now static.
615
20ce5912
PE
616 * image.c (gif_load): Rename local to avoid shadowing.
617
9c4c5f81
PE
618 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
619 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
620 * alloc.c (make_save_value): Integer argument is now of type
621 ptrdiff_t, not int.
622 (mark_object): Use ptrdiff_t, not int.
623 * lisp.h (pD): New macro.
624 * print.c (print_object): Use it.
625
c0c5c8ae
PE
626 * alloc.c: Use EMACS_INT, not int, to count objects.
627 (total_conses, total_markers, total_symbols, total_vector_size)
628 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
629 (total_free_floats, total_floats, total_free_intervals)
630 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
631 Now EMACS_INT, not int. All uses changed.
632 (Fgarbage_collect): Compute overall total using a double, so that
633 integer overflow is less likely to be a problem. Check for overflow
634 when converting back to an integer.
5a25e253
PE
635 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
636 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
637 These were 'int' variables that could overflow on 64-bit hosts;
638 they were never used, so remove them instead of repairing them.
211a0b2a 639 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
640 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
641 Previously, this ceilinged at INT_MAX, but that doesn't work on
642 64-bit machines.
e46bb31a 643 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 644
c78baabf 645 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 646 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
647 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
648 when a (possibly-narrower) signed value would do just as well.
649 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 650
c9d624c6
PE
651 * alloc.c: Catch some string size overflows that we were missing.
652 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
653 for convenience in STRING_BYTES_MAX.
654 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
655 The definition here is exact; the one in lisp.h was approximate.
656 (allocate_string_data): Check for string overflow. This catches
657 some instances we weren't catching before. Also, it catches
658 size_t overflow on (unusual) hosts where SIZE_MAX <= min
659 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
660 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 661
c9d624c6
PE
662 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
663 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
664 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
665
353032ce
PE
666 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
667
2bccce07
PE
668 * alloc.c (Fmake_string): Check for out-of-range init.
669
0ac30604
SM
6702011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
671
672 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
673
c195f2de
JD
6742011-06-14 Jan Djärv <jan.h.d@swipnet.se>
675
676 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
677 xg_get_default_scrollbar_width.
678
679 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
680 (int_gtk_range_get_value): Move to the scroll bar part of the file.
681 (style_changed_cb): Call update_theme_scrollbar_width and call
682 x_set_scroll_bar_default_width and xg_frame_set_char_size for
683 all frames (Bug#8505).
684 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
685 Call gtk_window_set_resizable if HAVE_GTK3.
686 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
687 and height if HAVE_GTK3 (Bug#8505).
688 (scroll_bar_width_for_theme): New variable.
689 (update_theme_scrollbar_width): New function.
690 (xg_get_default_scrollbar_width): Move code to
691 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
692 (xg_initialize): Call update_theme_scrollbar_width.
693
694 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
695
696 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
697
e10ac9f1
MR
6982011-06-12 Martin Rudalics <rudalics@gmx.at>
699
700 * frame.c (make_frame): Call other_buffer_safely instead of
701 other_buffer.
702
703 * window.c (temp_output_buffer_show): Call display_buffer with
704 second argument Vtemp_buffer_show_specifiers and reset latter
705 immediately after the call.
706 (Vtemp_buffer_show_specifiers): New variable.
707 (auto_window_vscroll_p, next_screen_context_lines)
708 (Vscroll_preserve_screen_position): Remove leading asterisks from
709 doc-strings.
710
2d3c217e 7112011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 712
7b7f97e8 713 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
714 * buffer.c (Qclone_number): Remove for now, as it's unused.
715 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
716 (record_buffer): Remove unused local.
717 * frame.c (other_visible_frames, frame_buffer_list): Now static.
718 (set_frame_buffer_list): Remove; unused.
719 * frame.h (other_visible_frames): Remove decl.
720 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
721 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
722 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
723 if HAVE_GPM.
724 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
725 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
726 Define only if HAVE_GPM.
727 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
728 (update_hints_inhibit): Remove; never set. All uses removed.
729 * widgetprv.h (emacsFrameClassRec): Remove decl.
730 * window.c (delete_deletable_window): Now returns void, since it
731 wasn't returning anything.
732 (compare_window_configurations): Remove unused locals.
733 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
734 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
735 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
736 the same widths as pointers. This follows up on the 2011-05-06 patch.
737 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
738 * xterm.h: Likewise.
739 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
740
1384b89e
JB
7412011-06-12 Juanma Barranquero <lekktu@gmail.com>
742
743 * makefile.w32-in: Update dependencies.
744 (LISP_H): Add lib/intprops.h.
745
1100a63c
CY
7462011-06-11 Chong Yidong <cyd@stupidchicken.com>
747
748 * image.c (gif_load): Add animation frame delay to the metadata.
749 (syms_of_image): Use DEFSYM. New symbol `delay'.
750
6198ccd0
MR
7512011-06-11 Martin Rudalics <rudalics@gmx.at>
752
753 * window.c (delete_deletable_window): Re-add.
754 (Fset_window_configuration): Rewrite to handle dead buffers and
755 consequently deletable windows.
756 (window_tree, Fwindow_tree): Remove. Supply functionality in
757 window.el.
758 (compare_window_configurations): Simplify code.
759
b6e3633c
AS
7602011-06-11 Andreas Schwab <schwab@linux-m68k.org>
761
1ab0dee5
AS
762 * image.c (imagemagick_load_image): Fix type mismatch.
763 (Fimagemagick_types): Likewise.
764
b6e3633c
AS
765 * window.h (replace_buffer_in_windows): Declare.
766
9397e56f
MR
7672011-06-11 Martin Rudalics <rudalics@gmx.at>
768
769 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
770 Qclone_number. Remove external declaration of Qdelete_window.
771 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
772 code.
773 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
774 Qbuffer_list_update_hook if allowed.
775 (Fother_buffer): Rewrite doc-string. Major rewrite for new
776 buffer list implementation.
777 (other_buffer_safely): New function.
778 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
779 calls to replace_buffer_in_windows and
780 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
781 if allowed.
782 (record_buffer): Inhibit quitting and rewrite using quittable
783 functions. Run Qbuffer_list_update_hook if allowed.
784 (Frecord_buffer, Funrecord_buffer): New functions.
785 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
786 switch-to-buffer to window.el.
787 (bury-buffer): Move to window.el.
788 (Vbuffer_list_update_hook): New variable.
789
790 * lisp.h (other_buffer_safely): Add prototype in buffer.c
791 section.
792
793 * window.h (resize_frame_windows): Move up in code.
794 (Fwindow_frame): Remove EXFUN.
795 (replace_buffer_in_all_windows): Remove prototype.
796 (replace_buffer_in_windows_safely): Add prototype.
797
798 * window.c: Declare Qdelete_window static again. Move down
799 declaration of select_count.
800 (Fnext_window, Fprevious_window): Rewrite doc-strings.
801 (Fother_window): Move to window.el.
802 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
803 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
804 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
805 window.el.
806 (replace_buffer_in_windows): Implement by calling
807 Qreplace_buffer_in_windows.
808 (replace_buffer_in_all_windows): Remove with some functionality
809 moved into replace_buffer_in_windows_safely.
810 (replace_buffer_in_windows_safely): New function.
811 (select_window_norecord, select_frame_norecord): Move in front
812 of run_window_configuration_change_hook. Remove now obsolete
813 declarations.
814 (Fset_window_buffer): Rewrite doc-string. Call
815 Qrecord_window_buffer.
816 (keys_of_window): Move binding for other-window to window.el.
817
b50691aa
CY
8182011-06-11 Chong Yidong <cyd@stupidchicken.com>
819
820 * dispextern.h (struct image): Replace data member, whose int_val
821 and ptr_val fields were not used by anything, with a single
822 lisp_val object.
823
824 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
825 (gif_clear_image, gif_load, imagemagick_load_image)
826 (gs_clear_image, gs_load): Callers changed.
827
3f754b86
PE
8282011-06-10 Paul Eggert <eggert@cs.ucla.edu>
829
cca69397
PE
830 * buffer.h: Include <time.h>, for time_t.
831 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
832
109e28d0
PE
833 Fix minor problems found by static checking.
834
60737f02
PE
835 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
836
4b66faf3
PE
837 Make identifiers static if they are not used in other modules.
838 * data.c (Qcompiled_function, Qframe, Qvector):
839 * image.c (QimageMagick, Qsvg):
840 * minibuf.c (Qmetadata):
841 * window.c (resize_window_check, resize_root_window): Now static.
842 * window.h (resize_window_check, resize_root_window): Remove decls.
843
109e28d0
PE
844 * window.c (window_deletion_count, delete_deletable_window):
845 Remove; unused.
46a4ce9e
PE
846 (window_body_lines): Now static.
847 (Fdelete_other_windows_internal): Mark vars as initialized.
848 Make sure 'resize_failed' is initialized.
849 (run_window_configuration_change_hook): Rename local to avoid shadowing.
850 (resize_window_apply): Remove unused local.
851 * window.h (delete_deletable_window): Remove decl.
852
109e28d0 853 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
854 (imagemagick_load_image): Fix pointer signedness problem by changing
855 last arg from unsigned char * to char *. All uses changed.
856 Also, fix a local for similar reasons.
857 Remove unused locals. Remove locals to avoid shadowing.
858 (fn_rsvg_handle_free): Remove; unused.
859 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 860 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 861
3f754b86
PE
862 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
863
2547adb1
CY
8642011-06-10 Chong Yidong <cyd@stupidchicken.com>
865
866 * image.c (gif_load): Fix omitted cast error introduced by
867 2011-06-06 change.
868
2c8e37d4
MR
8692011-06-10 Martin Rudalics <rudalics@gmx.at>
870
871 * window.h (resize_proportionally, orig_total_lines)
872 (orig_top_line): Remove from window structure.
873 (set_window_height, set_window_width, change_window_heights)
874 (Fdelete_window): Remove prototypes.
875 (resize_frame_windows): Remove duplicate declaration.
876
440a42e3
EZ
8772011-06-10 Eli Zaretskii <eliz@gnu.org>
878
879 * window.h (resize_frame_windows, resize_window_check)
880 (delete_deletable_window, resize_root_window)
881 (resize_frame_windows): Declare prototypes.
882
883 * window.c (resize_window_apply): Make definition be "static" to
884 match the prototype.
885
562dd5e9
MR
8862011-06-10 Martin Rudalics <rudalics@gmx.at>
887
888 * window.c: Remove declarations of Qwindow_size_fixed,
889 window_min_size_1, window_min_size_2, window_min_size,
890 size_window, window_fixed_size_p, enlarge_window, delete_window.
891 Remove static from declaration of Qdelete_window, it's
892 temporarily needed by Fbury_buffer.
893 (replace_window): Don't assign orig_top_line and
894 orig_total_lines.
895 (Fdelete_window, delete_window): Remove. Window deletion is
896 handled by window.el.
897 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
898 Fdelete_window calls with calls to Qdelete_window.
899 (Fdelete_other_windows): Remove. Deleting other windows is
900 handled by window.el.
901 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
902 handled in window.el.
903 (window_min_size_2, window_min_size_1, window_min_size): Remove.
904 Window minimum sizes are handled in window.el.
905 (shrink_windows, size_window, set_window_height)
906 (set_window_width, change_window_heights, window_height)
907 (window_width, CURBEG, CURSIZE, enlarge_window)
908 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
909 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
910 handled in window.el.
911 (make_dummy_parent): Rename to make_parent_window and give it a
912 second argument horflag.
913 (make_window): Don't set resize_proportionally any more.
914 (Fsplit_window): Remove. Windows are split in window.el.
915 (save_restore_action, save_restore_orig_size)
916 (shrink_window_lowest_first, save_restore_orig_size): Remove.
917 Resize mini windows in window.el.
918 (grow_mini_window, shrink_mini_window): Implement by calling
919 Qresize_root_window_vertically, resize_window_check and
920 resize_window_apply.
921 (saved_window, Fset_window_configuration, save_window_save): Do
922 not handle orig_top_line, orig_total_lines, and
923 resize_proportionally.
924 (window_min_height, window_min_width): Move to window.el.
925 (keys_of_window): Move bindings for delete-other-windows,
926 split-window, delete-window and enlarge-window to window.el.
927
928 * buffer.c: Temporarily extern Qdelete_window.
929 (Fbury_buffer): Temporarily call Qdelete_window instead of
930 Fdelete_window (Fbury_buffer will move to window.el soon).
931
932 * frame.c (set_menu_bar_lines_1): Remove code handling
933 orig_top_line and orig_total_lines.
934
935 * dispnew.c (adjust_frame_glyphs_initially): Don't use
936 set_window_height but set heights directly.
937 (change_frame_size_1): Use resize_frame_windows.
938
939 * xdisp.c (init_xdisp): Don't use set_window_height but set
940 heights directly.
941
942 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
943 resize_frame_windows instead of change_window_heights and run
944 run_window_configuration_change_hook.
945
946 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
947 instead of change_window_heights and run
948 run_window_configuration_change_hook.
949
1a13852e
MR
9502011-06-09 Martin Rudalics <rudalics@gmx.at>
951
952 * window.c (replace_window): Rename second argument REPLACEMENT to
953 NEW. New third argument SETFLAG. Rewrite.
954 (delete_window, make_dummy_parent): Call replace_window with
955 third argument 1.
956 (window_list_1): Move down in code.
957 (run_window_configuration_change_hook): Move set_buffer part
958 before select_frame_norecord part in order to unwind correctly.
959 Rename count1 to count.
960 (recombine_windows, delete_deletable_window, resize_root_window)
961 (Fdelete_other_windows_internal)
962 (Frun_window_configuration_change_hook, make_parent_window)
963 (resize_window_check, resize_window_apply, Fresize_window_apply)
964 (resize_frame_windows, Fsplit_window_internal)
965 (Fdelete_window_internal, Fresize_mini_window_internal): New
966 functions.
967 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
968
f3d1777e
MR
9692011-06-08 Martin Rudalics <rudalics@gmx.at>
970
496e208e
MR
971 * window.h (window): Add some new members to window structure -
972 normal_lines, normal_cols, new_total, new_normal, clone_number,
973 splits, nest, prev_buffers, next_buffers.
974 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 975 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 976
f3d1777e
MR
977 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
978 Remove.
496e208e
MR
979 (make_dummy_parent): Set new members of windows structure.
980 (make_window): Move down in code. Handle new members of window
981 structure.
982 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
983 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
984 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
985 (Fset_window_prev_buffers, Fwindow_next_buffers)
986 (Fset_window_next_buffers, Fset_window_clone_number): New
987 functions.
988 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
989 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
990 Doc-string fixes.
991 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
992 Argument WINDOW can be now internal window too.
993 (Fwindow_use_time): Move up in code.
994 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
995 Rewrite doc-string.
996 (Fset_window_configuration, saved_window)
997 (Fcurrent_window_configuration, save_window_save): Handle new
998 members of window structure.
b9e809c2
MR
999 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1000 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1001 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1002 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1003 Qget_mru_window, Qresize_root_window,
1004 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1005 Qauto_buffer_name; staticpro them.
f3d1777e 1006
abde8f8c
MR
10072011-06-07 Martin Rudalics <rudalics@gmx.at>
1008
1009 * window.c (Fwindow_total_size, Fwindow_left_column)
1010 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1011 (Fwindow_list_1): New functions.
1012 (window_box_text_cols): Replace with window_body_cols.
1013 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1014 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1015 (delete_window, Fset_window_configuration): Call
1016 delete_all_subwindows with window as argument.
1017 (delete_all_subwindows): Take a window as argument and not a
1018 structure. Rewrite.
190b47e6
MR
1019 (window_loop): Remove handling of GET_LRU_WINDOW and
1020 GET_LARGEST_WINDOW.
1021 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1022
1023 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1024 window_box_text_cols. delete_all_subwindows now takes a
1025 Lisp_Object as argument.
abde8f8c
MR
1026
1027 * indent.c (compute_motion, Fcompute_motion): Use
1028 window_body_cols instead of window_box_text_cols.
1029
fa8a67e6
MR
1030 * frame.c (delete_frame): Call delete_all_subwindows with root
1031 window as argument.
1032
a54e3482
DC
10332011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1034
1035 * fns.c (Fputhash): Document return value.
1036
60002bf5
CY
10372011-06-06 Chong Yidong <cyd@stupidchicken.com>
1038
1039 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1040
0c671da6 10412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1042
b862a52a 1043 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1044
be44ca6c
PE
1045 Check for overflow when converting integer to cons and back.
1046 * charset.c (Fdefine_charset_internal, Fdecode_char):
1047 Use cons_to_unsigned to catch overflow.
1048 (Fencode_char): Use INTEGER_TO_CONS.
1049 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1050 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1051 * data.c (long_to_cons, cons_to_long): Remove.
1052 (cons_to_unsigned, cons_to_signed): New functions.
1053 These signal an error for invalid or out-of-range values.
1054 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1055 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1056 * font.c (Ffont_variation_glyphs):
1057 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1058 * lisp.h: Include <intprops.h>.
1059 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1060 (cons_to_signed, cons_to_unsigned): New decls.
1061 (long_to_cons, cons_to_long): Remove decls.
1062 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1063 (Fprimitive_undo): Use CONS_TO_INTEGER.
1064 * xfns.c (Fx_window_property): Likewise.
1065 * xselect.c: Include <limits.h>.
1066 (x_own_selection, selection_data_to_lisp_data):
1067 Use INTEGER_TO_CONS.
1068 (x_handle_selection_request, x_handle_selection_clear)
1069 (x_get_foreign_selection, Fx_disown_selection_internal)
1070 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1071 (lisp_data_to_selection_data): Use cons_to_unsigned.
1072 (x_fill_property_data): Use cons_to_signed.
1073 Report values out of range.
1074
d1f3d2af
PE
1075 Check for buffer and string overflow more precisely.
1076 * buffer.h (BUF_BYTES_MAX): New macro.
1077 * lisp.h (STRING_BYTES_MAX): New macro.
1078 * alloc.c (Fmake_string):
1079 * character.c (string_escape_byte8):
1080 * coding.c (coding_alloc_by_realloc):
1081 * doprnt.c (doprnt):
1082 * editfns.c (Fformat):
1083 * eval.c (verror):
1084 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1085 since they may not be the same number.
1086 * editfns.c (Finsert_char):
1087 * fileio.c (Finsert_file_contents):
1088 Likewise for BUF_BYTES_MAX.
1089
dd52fcea
PE
1090 * image.c: Use ptrdiff_t, not int, for sizes.
1091 (slurp_file): Switch from int to ptrdiff_t.
1092 All uses changed.
1093 (slurp_file): Check that file size fits in both size_t (for
1094 malloc) and ptrdiff_t (for sanity and safety).
1095
7f9bbdbb
PE
1096 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1097 if b->modtime has its maximal value.
1098
dfe18f82
PE
1099 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1100
84acfcf0
PE
1101 Don't assume time_t can fit into int.
1102 * buffer.h (struct buffer.modtime): Now time_t, not int.
1103 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1104 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1105
ccd9a01a
PE
1106 Minor fixes for signed vs unsigned integers.
1107 * character.h (MAYBE_UNIFY_CHAR):
1108 * charset.c (maybe_unify_char):
1109 * keyboard.c (read_char, reorder_modifiers):
1110 XINT -> XFASTINT, since the integer must be nonnegative.
1111 * ftfont.c (ftfont_spec_pattern):
1112 * keymap.c (access_keymap, silly_event_symbol_error):
1113 XUINT -> XFASTINT, since the integer must be nonnegative.
1114 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1115 since it makes no difference and we prefer signed.
1116 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1117 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1118 nonnegative.
1119
d6d100dd
SM
11202011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1121
1122 * window.h (Fwindow_frame): Declare.
1123
2b6148e4
PE
11242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1125
1126 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1127 (SPARE_MEMORY): Always define.
1128 (LARGE_REQUEST): Remove.
1129 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1130
f230ecc9
MR
11312011-06-06 Martin Rudalics <rudalics@gmx.at>
1132
727e958e
MR
1133 * lisp.h: Move EXFUNS for Fframe_root_window,
1134 Fframe_first_window and Fset_frame_selected_window to window.h.
1135
1136 * window.h: Move EXFUNS for Fframe_root_window,
1137 Fframe_first_window and Fset_frame_selected_window here from
1138 lisp.h.
1139
1140 * frame.c (Fwindow_frame, Fframe_first_window)
1141 (Fframe_root_window, Fframe_selected_window)
1142 (Fset_frame_selected_window): Move to window.c.
1143 (Factive_minibuffer_window): Move to minibuf.c.
1144 (Fother_visible_frames_p): New function.
1145
1146 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1147
f230ecc9
MR
1148 * window.c (decode_window, decode_any_window): Move up in code.
1149 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1150 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1151 (Fwindow_buffer): Move up and rewrite doc-string.
1152 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1153 (Fwindow_prev): New functions.
727e958e
MR
1154 (Fwindow_frame): Move here from frame.c. Accept any window as
1155 argument.
1156 (Fframe_root_window, Fframe_first_window)
1157 (Fframe_selected_window): Move here from frame.c. Accept frame
1158 or arbitrary window as argument. Update doc-strings.
1159 (Fminibuffer_window): Move up in code.
1160 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1161 (Fset_frame_selected_window): Move here from frame.c.
1162 Marginal rewrite.
727e958e
MR
1163 (Fselected_window, select_window, Fselect_window): Move up in
1164 code. Minor doc-string fixes.
f230ecc9 1165
4d09bcf6
PE
11662011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1167
1168 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1169 Do not assume that spare memory exists; that assumption is valid
1170 only if SYSTEM_MALLOC.
1171 (LARGE_REQUEST): New macro, so that the issue of large requests
1172 is separated from the issue of spare memory.
1173
810928a2
AS
11742011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1175
172418ad
AS
1176 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1177 format. (Bug#8806)
1178
43f862f7
AS
1179 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1180
810928a2
AS
1181 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1182 before statements.
1183
a059fe24
JD
11842011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1185
1186 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1187
1188 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1189
1190 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1191 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1192
989bf368
JB
11932011-06-05 Juanma Barranquero <lekktu@gmail.com>
1194
1195 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1196
4b80f674
CY
11972011-06-04 Chong Yidong <cyd@stupidchicken.com>
1198
1199 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1200 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1201 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1202 New error handlers.
4b80f674
CY
1203 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1204 Obey Vx_select_enable_clipboard_manager. Catch errors in
1205 x_clipboard_manager_save (Bug#8779).
1206 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1207 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1208
99a33b77 12092011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1210
1211 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1212
99a33b77 12132011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1214
1215 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1216 in the current matrix if keep_current_p is non-zero.
1217
8264569d
EZ
12182011-06-04 Eli Zaretskii <eliz@gnu.org>
1219
1220 * bidi.c (bidi_level_of_next_char): Fix last change.
1221
57f97249
EZ
12222011-06-03 Eli Zaretskii <eliz@gnu.org>
1223
fec2107c 1224 Support bidi reordering of text covered by display properties.
57f97249 1225
fec2107c
EZ
1226 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1227 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1228 (bidi_cache_search, bidi_cache_iterator_state)
1229 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1230 (bidi_level_of_next_char, bidi_move_to_visually_next):
1231 Support character positions inside a run of characters covered by a
fec2107c
EZ
1232 display string.
1233 (bidi_paragraph_init, bidi_resolve_explicit_1)
1234 (bidi_level_of_next_char): Call bidi_fetch_char and
1235 bidi_fetch_char_advance instead of FETCH_CHAR and
1236 FETCH_CHAR_ADVANCE.
1237 (bidi_init_it): Initialize new members.
1238 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1239 definitions.
1240 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1241 instead of using explicit *_CHAR codes.
d6d100dd
SM
1242 (bidi_resolve_explicit, bidi_resolve_weak):
1243 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1244 bidirectional text is supported only in multibyte buffers.
1245 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1246 it to initialize the frame_window_p member of struct bidi_it.
1247 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1248 (bidi_resolve_explicit, bidi_resolve_weak)
1249 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1250 bidi_it->nchars is non-positive.
1251 (bidi_level_of_next_char): Don't try to lookup the cache for the
1252 next/previous character if nothing is cached there yet, or if we
1253 were just reseat()'ed to a new position.
c40e2fb2 1254
0e14fe90
EZ
1255 * xdisp.c (set_cursor_from_row): Set start and stop points
1256 according to the row's direction when priming the loop that looks
1257 for the glyph on which to display cursor.
1258 (single_display_spec_intangible_p): Function deleted.
1259 (display_prop_intangible_p): Reimplement to call
1260 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1261 Accept 3 additional arguments needed by handle_display_spec.
1262 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1263 values: lists, `(when COND...)' forms, etc.
1264 (single_display_spec_string_p): Support property values that are
1265 lists with the argument STRING its top-level element.
1266 (display_prop_string_p): Fix the condition for processing a
1267 property that is a list to be consistent with handle_display_spec.
fec2107c 1268 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1269 last portion of handle_display_prop.
1270 (compute_display_string_pos): Accept additional argument
1271 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1272 value of a `display' property is a "replacing spec".
1273 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1274 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1275 the display property, but just return a value indicating whether
1276 the display property will replace the characters it covers.
1277 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1278 frame_window_p members of struct bidi_it.
d6d100dd
SM
1279 (compute_display_string_pos, compute_display_string_end):
1280 New functions.
fec2107c
EZ
1281 (push_it): Accept second argument POSITION, where pop_it should
1282 jump to continue iteration.
1283 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1284
fec2107c
EZ
1285 * keyboard.c (adjust_point_for_property): Adjust the call to
1286 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1287
1288 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1289 (bidi_init_it): Update prototypes.
1290 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1291 (compute_display_string_pos, compute_display_string_end):
1292 Declare prototypes.
fec2107c
EZ
1293 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1294 EMACS_INT.
fc6f18ce 1295
40087514 12962011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1297
57f53182
PE
1298 Malloc failure behavior now depends on size of allocation.
1299 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1300 * lisp.h: Change signatures accordingly.
1301 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1302 All callers changed. (Bug#8762)
1303
1304 * gnutls.c: Use Emacs's memory allocators.
1305 Without this change, the gnutls library would invoke malloc etc.
1306 directly, which causes problems on non-SYNC_INPUT hosts, and which
1307 runs afoul of improving memory_full behavior. (Bug#8761)
1308 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1309 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1310 xfree instead of the default malloc, realloc, free.
1311 (Fgnutls_boot): No need to check for memory allocation failure,
1312 since xmalloc does that for us.
1313
ac32cd99 1314 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1315 * category.c (hash_get_category_set):
1316 * ccl.c (ccl_driver):
1317 * charset.c (Fdefine_charset_internal):
1318 * charset.h (struct charset.hash_index):
1319 * composite.c (get_composition_id, gstring_lookup_cache)
1320 (composition_gstring_put_cache):
1321 * composite.h (struct composition.hash_index):
1322 * dispextern.h (struct image.hash):
1323 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1324 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1325 (hashfn_equal, hashfn_user_defined, make_hash_table)
1326 (maybe_resize_hash_table, hash_lookup, hash_put)
1327 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1328 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1329 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1330 * image.c (make_image, search_image_cache, lookup_image)
1331 (xpm_put_color_table_h):
1332 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1333 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1334 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1335 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1336 * alloc.c (allocate_vectorlike):
1337 Check for overflow in vector size calculations.
1338 * ccl.c (ccl_driver):
1339 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1340 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1341 need to be updated by these changes.
40087514
PE
1342 * fns.c (make_hash_table, maybe_resize_hash_table):
1343 Check for integer overflow with large hash tables.
0de4bb68
PE
1344 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1345 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1346 (SXHASH_REDUCE): New macro.
1347 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1348 Use it instead of discarding useful hash info with large hash values.
1349 (sxhash_float): New function.
1350 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1351 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1352 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1353 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1354 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1355 Adjust signatures to match updated version of code.
1356 (consing_since_gc): Now EMACS_INT, since a single hash table can
1357 use more than INT_MAX bytes.
1358
698d32e2
DN
13592011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1360
1361 Make it possible to build with GCC-4.6+ -O2 -flto.
1362
1363 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1364
fd6fa53f
SM
13652011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1366
1367 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1368 Call minibuffer-inactive-mode.
1369
864db017
JB
13702011-05-31 Juanma Barranquero <lekktu@gmail.com>
1371
1372 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1373 Update dependencies.
1374
2ad0baf4
DN
13752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1376
1377 * data.c (init_data): Remove code for UTS, this system is not
1378 supported anymore.
1379
4fcc2638
DN
13802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1381
1382 Don't force ./temacs to start in terminal mode.
1383
1384 * frame.c (make_initial_frame): Initialize faces in all cases, not
1385 only when CANNOT_DUMP is defined.
1386 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1387
c56e0fd5
DN
13882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1389
1390 * dispnew.c (add_window_display_history): Use const for the string
1391 pointer. Remove declaration, not needed.
1392
333d54da 13932011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1394
55d4c1b2 1395 Use 'inline', not 'INLINE'.
333d54da 1396 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1397 * alloc.c, fontset.c (INLINE): Remove.
1398 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1399 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1400 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1401 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1402 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1403
738db178
DN
14042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1405
1406 Make it possible to run ./temacs.
1407
1408 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1409 syms_of_callproc does the same thing. Remove test for
1410 "initialized", do it in the caller.
1411 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1412
620c53a6
SM
14132011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1414
1415 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1416 (read_minibuf): Use get_minibuffer.
1417 (syms_of_minibuf): Use DEFSYM.
1418 (Qmetadata): New var.
1419 * data.c (Qbuffer): Don't make it static.
1420 (syms_of_data): Use DEFSYM.
1421
e003a292
PE
14222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1423
1424 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1425 (CCL_CODE_MIN): New macro.
1426
ed008a6d
PE
14272011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1428
3687c2ef
PE
1429 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1430
ed008a6d
PE
1431 * eval.c (Qdebug): Now static.
1432 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1433 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1434 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1435
d66c4c7c
CY
14362011-05-29 Chong Yidong <cyd@stupidchicken.com>
1437
1438 * image.c: Various fixes to ImageMagick code comments.
1439 (Fimagemagick_types): Doc fix.
1440
5fbc2025
PE
14412011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1442
0196f88a
PE
1443 Minor fixes prompted by GCC 4.6.0 warnings.
1444
1445 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1446
5fbc2025
PE
1447 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1448 (x_clipboard_manager_save_all): Move extern decl to ...
1449 * xterm.h: ... here, so that it can be checked for consistency.
1450
1dd3c2d9
CY
14512011-05-29 Chong Yidong <cyd@stupidchicken.com>
1452
1453 * xselect.c (x_clipboard_manager_save_frame)
1454 (x_clipboard_manager_save_all): New functions.
1455 (Fx_clipboard_manager_save): Lisp function deleted.
1456
1457 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1458 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1459
1460 * xterm.h: Update prototype.
1461
5ba6571d
WX
14622011-05-28 William Xu <william.xwl@gmail.com>
1463
1464 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1465 exiting (Bug#8239).
1466
3eaff834
JM
14672011-05-28 Jim Meyering <meyering@redhat.com>
1468
e1900994 1469 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1470 * fns.c (to_uchar): Define.
1471 (crypto_hash_function): Use it to convert some newly-signed
1472 variables to unsigned, to avoid sign-extension bugs. For example,
1473 without this change, (md5 "truc") would evaluate to
1474 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1475 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1476 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1477
0f6990a7
PE
14782011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1479
1480 Integer overflow fixes.
c8a9ca5a 1481
08686060
PE
1482 * dbusbind.c: Serial number integer overflow fixes.
1483 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1484 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1485 to hold a serial number that is too large for a fixnum.
1486 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1487 Check for serial numbers out of range. Decode any serial number
59568bf0 1488 that was so large that it became a float. (Bug#8722)
08686060 1489
2d1fc3c7
PE
1490 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1491 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1492 Use XFASTINT rather than XUINT when numbers are nonnegative.
1493 (xd_append_arg, Fdbus_method_return_internal):
1494 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1495 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1496 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1497 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1498 (Bug#8722)
2d1fc3c7 1499
c8a9ca5a
PE
1500 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1501
519e1d69
PE
1502 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1503
30569699
PE
1504 ccl: add integer overflow checks
1505 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1506 (IN_INT_RANGE): New macros.
1507 (ccl_driver): Use them to check for integer overflow when
1508 decoding a CCL program. Many of the new checks are whether XINT (x)
1509 fits in int; it doesn't always, on 64-bit hosts. The new version
1510 doesn't catch all possible integer overflows, but it's an
847044ea 1511 improvement. (Bug#8719)
30569699 1512
c11285dc
PE
1513 * alloc.c (make_event_array): Use XINT, not XUINT.
1514 There's no need for unsigned here.
1515
fdccd48e
PE
1516 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1517 This follows up to the 2011-05-06 change that substituted uintptr_t
1518 for EMACS_INT. This case wasn't caught back then.
1519
37910ab2
PE
1520 Rework Fformat to avoid integer overflow issues.
1521 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1522 now (part of C89). Include <verify.h>.
1523 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1524 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1525 (Fformat): Avoid the prepass trying to compute sizes; it was only
1526 approximate and thus did not catch overflow reliably. Instead, walk
1527 through the format just once, formatting and computing sizes as we go,
1528 checking for integer overflow at every step, and allocating a larger
1529 buffer as needed. Keep track separately whether the format is
1530 multibyte. Keep only the most-recently calculated precision, rather
1531 than them all. Record whether each argument has been converted to
1532 string. Use EMACS_INT, not int, for byte and char and arg counts.
1533 Support field widths and precisions larger than INT_MAX. Avoid
1534 sprintf's undefined behavior with conversion specifications such as %#d
1535 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1536 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1537 formatting out-of-range floating point numbers with int
1538 formats. (Bug#8668)
1539
2e6578fb
PE
1540 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1541
0ae6bdee
PE
1542 * data.c: Avoid integer truncation in expressions involving floats.
1543 * data.c: Include <intprops.h>.
1544 (arith_driver): When there's an integer overflow in an expression
1545 involving floating point, convert the integers to floating point
1546 so that the resulting value does not suffer from catastrophic
1547 integer truncation. For example, on a 64-bit host (* 4
1548 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1549 Do not rely on undefined behavior after integer overflow.
1550
de883a70
PE
1551 merge count_size_as_multibyte, parse_str_to_multibyte
1552 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1553 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1554 Check for integer overflow.
1555 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1556 since it's now a duplicate of the other. This is more of
1557 a character than a buffer op, so better that it's in character.c.
1558 * fns.c, print.c: Adjust to above changes.
1559
2ff916cb
PE
15602011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1561
1562 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1563
f1b54466
PE
15642011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1565
fb1ac845
PE
1566 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1567 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1568 (x_clipboard_manager_save): Now static.
1569 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1570
f1b54466
PE
1571 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1572 (crypto_hash_function): Now static.
1573 Fix pointer signedness problems. Avoid unnecessary initializations.
1574
a9f737ee
CY
15752011-05-27 Chong Yidong <cyd@stupidchicken.com>
1576
1577 * termhooks.h (Vselection_alist): Make it terminal-local.
1578
1579 * terminal.c (create_terminal): Initialize it.
1580
1581 * xselect.c: Support for clipboard managers.
1582 (Vselection_alist): Move to termhooks.h as terminal-local var.
1583 (LOCAL_SELECTION): New macro.
1584 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1585 (symbol_to_x_atom): Remove gratuitous arg.
1586 (x_handle_selection_request, lisp_data_to_selection_data)
1587 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1588 (x_own_selection, x_get_local_selection, x_convert_selection):
1589 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1590 (some_frame_on_display): Delete unused function.
1591 (Fx_own_selection_internal, Fx_get_selection_internal)
1592 (Fx_disown_selection_internal, Fx_selection_owner_p)
1593 (Fx_selection_exists_p): New optional frame arg.
1594 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1595 (x_handle_selection_clear): Don't treat other terminals with the
1596 same keyboard specially. Use the terminal-local Vselection_alist.
1597 (x_clear_frame_selections): Use Frun_hook_with_args.
1598
1599 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1600
1601 * xterm.h: Add support for those atoms.
1602
e067f0c1
CY
16032011-05-26 Chong Yidong <cyd@stupidchicken.com>
1604
1605 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1606 (converted_selections, conversion_fail_tag): New global variables.
1607 (x_selection_request_lisp_error): Free the above.
1608 (x_get_local_selection): Remove unnecessary code.
1609 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1610 of converted selections stored in converted_selections.
1611 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1612 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1613 (x_convert_selection): New function.
1614 (x_handle_selection_event): Simplify.
1615 (x_get_foreign_selection): Don't ignore incoming requests while
1616 waiting for an answer; this will fail when we implement
1617 SAVE_TARGETS, and seems unnecessary anyway.
1618 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1619 (Vx_sent_selection_functions): Doc fix.
1620
0f4aebc0
LL
16212011-05-26 Leo Liu <sdl.web@gmail.com>
1622
1623 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1624
e61124cd
YM
16252011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1626
1627 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1628
1629 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1630 for fringe update if it has periodic bitmap.
1631 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1632 and fringe_bitmap_periodic_p.
1633
1634 * fringe.c (get_fringe_bitmap_data): New function.
1635 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1636 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1637 row. Mark glyph row for fringe update if periodicity changed.
1638
1639 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1640 for fringe update unless it has periodic bitmap.
1641
f16d9837
KH
16422011-05-25 Kenichi Handa <handa@m17n.org>
1643
1644 * xdisp.c (get_next_display_element): Set correct it->face_id for
1645 a static composition.
1646
e1b90ef6
LL
16472011-05-24 Leo Liu <sdl.web@gmail.com>
1648
1649 * deps.mk (fns.o):
1650 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1651
1652 * fns.c (crypto_hash_function, Fsha1): New function.
1653 (Fmd5): Use crypto_hash_function.
1654 (syms_of_fns): Add Ssha1.
1655
7400048f
PE
16562011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1657
1658 * gnutls.c: Remove unused macros.
1659 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1660 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1661 Remove macros that are defined and never used.
1662 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1663
abb71cf4
CY
16642011-05-22 Chong Yidong <cyd@stupidchicken.com>
1665
1666 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1667 (Fx_get_selection_internal): Minor cleanup.
1668 (Fx_own_selection_internal): Rename arguments for consistency with
1669 select.el.
1670
6307db39
PE
16712011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1672
1673 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1674
f3d4e0a4
CY
16752011-05-22 Chong Yidong <cyd@stupidchicken.com>
1676
1677 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1678
4d8ade89
YM
16792011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1680
1681 * dispnew.c (scrolling_window): Don't exclude the case that the
1682 last enabled row in the desired matrix touches the bottom boundary.
1683
32078c8d
GM
16842011-05-21 Glenn Morris <rgm@gnu.org>
1685
1686 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1687 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1688 and add some more files.
32078c8d 1689
7285dc67
EZ
16902011-05-20 Eli Zaretskii <eliz@gnu.org>
1691
1692 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1693 report_file_error introduced by the change from 2011-05-07.
1694
89d1bd22
PE
16952011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1696
1697 * systime.h (Time): Define only if emacs is defined.
1698 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1699 where the include path doesn't have X11/X.h by default. See
1700 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1701
e23640bb 17022011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1703
1704 * composite.c (find_automatic_composition): Fix previous change.
1705
b9704ad9
GM
17062011-05-20 Glenn Morris <rgm@gnu.org>
1707
1708 * lisp.mk: New file, split from Makefile.in.
1709 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1710 (shortlisp): Remove.
1711 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1712
4a720484
GM
17132011-05-19 Glenn Morris <rgm@gnu.org>
1714
1715 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1716 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1717 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1718 (lisp): Set the order to that of loadup.el.
1719 (shortlisp): Make it a copy of $lisp.
1720 (SOME_MACHINE_LISP): Remove.
1721 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1722 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1723
a28d4396
KH
17242011-05-18 Kenichi Handa <handa@m17n.org>
1725
1726 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1727 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1728 (find_automatic_composition): Mostly rewrite for efficiency.
1729
a2b1fa8e
JB
17302011-05-18 Juanma Barranquero <lekktu@gmail.com>
1731
1732 * makefile.w32-in: Update dependencies.
1733
8e1f5610
CS
17342011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1735
1736 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1737 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1738
7025ee00 17392011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1740
cdfa6eab
PE
1741 Fix some integer overflow issues, such as string length overflow.
1742
06d6db33
PE
1743 * insdel.c (count_size_as_multibyte): Check for string overflow.
1744
2b4560a8
PE
1745 * character.c (lisp_string_width): Check for string overflow.
1746 Use EMACS_INT, not int, for string indexes and lengths; in
1747 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1748 the resulting string length overflows an EMACS_INT; instead,
1749 report a string overflow if no precision given. When checking for
1750 precision exhaustion, use a check that cannot possibly have
1751 integer overflow. (Bug#8675)
1752 * character.h (lisp_string_width): Adjust to new signature.
1753
cb93f9be
PE
1754 * alloc.c (string_overflow): New function.
1755 (Fmake_string): Use it. This doesn't change behavior, but saves
1756 a few bytes and will simplify future changes.
1757 * character.c (string_escape_byte8): Likewise.
1758 * lisp.h (string_overflow): New decl.
1759
1a1f3366
PE
1760 Fixups, following up to the user-interface timestamp change.
1761 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1762 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1763 * msdos.c (mouse_get_pos): Likewise.
1764 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1765 * w32gui.h (Time): Define by including "systime.h" rather than by
1766 declaring it ourselves. (Bug#8664)
1767
d4e3e4d3
PE
1768 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1769 * image.c (clear_image_cache): Likewise.
1770
f6a24d19
PE
1771 * term.c (term_mouse_position): Don't assume time_t wraparound.
1772
08dc5ae6
PE
1773 Be more systematic about user-interface timestamps.
1774 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1775 and sometimes 'EMACS_UINT', to represent these timestamps.
1776 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1777 This makes the code easier to follow, and makes it easier to catch
1778 integer overflow bugs such as Bug#8664.
1779 * frame.c (Fmouse_position, Fmouse_pixel_position):
1780 Use Time, not unsigned long, for user-interface timestamps.
1781 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1782 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1783 * keyboard.h (last_event_timestamp): Likewise.
1784 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1785 * menu.h (xmenu_show): Likewise.
1786 * term.c (term_mouse_position): Likewise.
1787 * termhooks.h (struct input_event.timestamp): Likewise.
1788 (struct terminal.mouse_position_hook): Likewise.
1789 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1790 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1791 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1792 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1793 what it was before.
1794 * menu.h, termhooks.h: Include "systime.h", for Time.
1795
8e55734a
PE
1796 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1797 Don't assume that the difference between two unsigned long values
1798 can fit into an integer. At this point, we know button_down_time
1799 <= event->timestamp, so the difference must be nonnegative, so
1800 there's no need to cast the result if double-click-time is
1801 nonnegative, as it should be; check that it's nonnegative, just in
1802 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1803 apart (about 25 days). (Bug#8664)
8e55734a 1804
841f1b75 1805 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1806 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1807
3e26f69c
PE
1808 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1809 that always fit in int. Use a sentinel instead of a counter, to
1810 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1811 * frame.h (struct frame): Use int for menu_bar_items_used
1812 instead of EMACS_INT, since it always fits in int.
3e26f69c 1813
5cc152c0
PE
1814 * menu.c (grow_menu_items): Check for int overflow.
1815
d89eb65e
PE
1816 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1817
5235bd3e
PE
1818 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1819 Before, the code was not consistent. These values cannot exceed
1820 2**31 - 1 so there's no need to make them unsigned.
1821 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1822 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1823 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1824 as modifiers.
1825 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1826
bc827e23
PE
1827 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1828 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1829 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1830 presumably because the widths might not match.
1831
78eb494e
PE
1832 * window.c (size_window): Avoid needless test at loop start.
1833
04f2d78b
CB
18342011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1835
1836 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1837
d2fc7e3d 18382011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1839
1840 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1841
d2fc7e3d 18422011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1843
1844 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1845 `width' to `bar_area_x' and `bar_area_width', respectively.
1846 (x_scroll_run): Take account of fringe background extension.
1847
04f2d78b
CB
1848 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1849 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1850 `bar_area_width', respectively.
1851 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1852 background extension.
1853
79b70037
GM
18542011-05-10 Jim Meyering <meyering@redhat.com>
1855
1856 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1857
2f142cc5
JB
18582011-05-10 Juanma Barranquero <lekktu@gmail.com>
1859
1860 * image.c (Finit_image_library): Return t for built-in image types,
1861 like pbm and xbm. (Bug#8640)
1862
57679c86
AS
18632011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1864
1865 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1866
888c9e86
EZ
18672011-05-07 Eli Zaretskii <eliz@gnu.org>
1868
b0512a1d
EZ
1869 * w32console.c (Fset_screen_color): Doc fix.
1870 (Fget_screen_color): New function.
1871 (syms_of_ntterm): Defsubr it.
1872
7285dc67
EZ
1873 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1874 unlink the temporary file if Fcall_process didn't create it in the
1875 first place.
1876 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1877 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1878 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1879 cue to call_process_cleanup not to close that handle.
1880
4d3fcc8e
BK
18812011-05-07 Ben Key <bkey76@gmail.com>
1882
1883 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1884 one of two shell specific rules, either bootstrap-temacs-CMD or
1885 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1886 to the previous implementation of the bootstrap-temacs rule.
1887 The bootstrap-temacs-CMD rule is similar to the previous
1888 implementation of the bootstrap-temacs rule except that it
1889 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1890 variable.
1891
1892 These changes, along with some changes to nt/configure.bat,
1893 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1894 earlier fix to add support for --cflags and --ldflags options
1895 that include quotes so that it works whether make uses cmd or
1896 sh as the shell.
1897
b4289b64
MA
18982011-05-06 Michael Albinus <michael.albinus@gmx.de>
1899
1900 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1901 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1902 is a constant.
1903 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1904 a string. Handle both cases.
1905 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1906 (Fdbus_register_method): Use Qinvalid_function.
1907
af4c0e28
JB
19082011-05-06 Juanma Barranquero <lekktu@gmail.com>
1909
1910 * makefile.w32-in: Update dependencies.
1911 (LISP_H): Add inttypes.h and stdin.h.
1912 (PROCESS_H): Add unistd.h.
1913
c51453d9
EZ
19142011-05-06 Eli Zaretskii <eliz@gnu.org>
1915
1916 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1917 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1918
8ff0ac3c 19192011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1920
4c4b566b
PE
1921 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1922
aab2b9b5
PE
1923 * term.c (vfatal): Remove stray call to va_end.
1924 It's not needed and the C Standard doesn't allow it here anyway.
1925
c378da0b
PE
1926 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1927 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1928
288b08c7
PE
1929 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1930 bytes.
1931
e3601888
PE
1932 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1933
db6c0e74
PE
1934 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1935
dd5963ea
PE
1936 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1937
88c9450f
PE
1938 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1939
2f9442b8
PE
1940 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1941
c032b5f8
PE
1942 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1943 * charset.c (Fdefine_charset_internal): Don't initialize
1944 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1945 32-bit int (Bug#8600).
a108c10b
PE
1946
1947 * lread.c (read_integer): Be more consistent with string-to-number.
1948 Use string_to_number to do the actual conversion; this avoids
1949 rounding errors and fixes some other screwups. Without this fix,
1950 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1951 (digit_to_number): Move earlier, for benefit of read_integer.
1952 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1953 not a digit in any supported base. (Bug#8602)
a108c10b 1954
ad5f9eea
PE
1955 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1956
aec1708a
PE
1957 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1958 to match comment at start of function. This also removes a
1959 GCC warning about overflow in a 32+64-bit port.
1960
47be4ab5
PE
1961 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1962
371cac43
PE
1963 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1964 Reported by Stefan Monnier in
1965 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1966 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1967 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1968
d01a7826
PE
1969 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1970 (EMACS_UINTPTR): Likewise, with uintptr_t.
1971
7fd47d5c
PE
1972 * lisp.h: Prefer 64-bit EMACS_INT if available.
1973 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1974 on 32-bit hosts that have 64-bit int, so that they can access
1975 large files.
122b0c86
PE
1976 However, temporarily disable this change unless the temporary
1977 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1978
8727937b
PE
1979 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1980
8ac068ac
PE
1981 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1982 This removes an assumption that EMACS_INT and long are the same
1983 width as pointers. The assumption is true for Emacs porting targets
1984 now, but we want to make other targets possible.
1985 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1986 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1987 In the rest of the code, change types of integers that hold casted
1988 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1989 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1990 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1991 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1992 No need to cast type when ORing.
1993 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1994 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1995 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1996 assume EMACS_INT is the same width as char *.
1997 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1998 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1999 Remove no-longer-needed casts.
2000 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2001 (xg_tool_bar_help_callback, xg_make_tool_item):
2002 Use EMACS_INTPTR to hold an integer
2003 that will be cast to void *; this can avoid a GCC warning
2004 if EMACS_INT is not the same width as void *.
2005 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2006 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2007 (current_message_1, set_message_1):
2008 Use a local to convert to proper width without a cast.
2009 * xmenu.c (dialog_selection_callback): Likewise.
2010
ede49d71
PE
2011 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2012 Also, don't assume VALBITS / RAND_BITS is less than 5,
2013 and don't rely on undefined behavior when shifting a 1 left into
2014 the sign bit.
2015 * lisp.h (get_random): Change signature to match.
2016
2f30ecd0
PE
2017 * lread.c (hash_string): Use size_t, not int, for hash computation.
2018 Normally we prefer signed values; but hashing is special, because
2019 it's better to use unsigned division on hash table sizes so that
2020 the remainder is nonnegative. Also, size_t is the natural width
2021 for hashing into memory. The previous code used 'int', which doesn't
2022 retain enough info to hash well into very large tables.
2023 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2024
2a866e7b
PE
2025 * dbusbind.c: Don't possibly lose pointer info when converting.
2026 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2027 Use XPNTR rather than XHASH, so that the high-order bits of
2028 the pointer aren't lost when converting through void *.
2029
51639eac
PE
2030 * eval.c (Fautoload): Don't double-shift a pointer.
2031
92394119
PE
2032 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2033
dbdb9a7c
JB
20342011-05-06 Juanma Barranquero <lekktu@gmail.com>
2035
2036 * gnutls.c (DEF_GNUTLS_FN):
2037 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2038
db7a0b4f
AS
20392011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2040
2041 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2042 marker. (Bug#8610)
2043
f7ff1b0f 20442011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2045
2046 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2047 New version that can reserve upto 2GB of heap space.
2048
f7ff1b0f 20492011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2050
2051 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2052
639c109b
TZ
20532011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2054
2055 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2056 `gnutls_certificate_set_x509_key_file'.
2057
d2127135
JB
20582011-05-05 Juanma Barranquero <lekktu@gmail.com>
2059
2060 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2061 Update dependencies.
2062
e968f4f3
JB
20632011-05-04 Juanma Barranquero <lekktu@gmail.com>
2064
2065 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2066 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2067 Remove unused parameter `fildes'.
2068 * process.c (read_process_output, send_process): Don't pass it.
2069
84d358f0
JB
20702011-05-04 Juanma Barranquero <lekktu@gmail.com>
2071
2072 Fix previous change: the library cache is defined in w32.c.
2073 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2074 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2075
0898ca10
JB
20762011-05-04 Juanma Barranquero <lekktu@gmail.com>
2077
2078 Implement dynamic loading of GnuTLS on Windows.
2079
2080 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2081 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2082 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2083 Declare.
2084
2085 * gnutls.c (Qgnutls_dll): Define.
2086 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2087 (gnutls_*): Declare function pointers.
2088 (init_gnutls_functions): New function to initialize function pointers.
2089 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2090 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2091 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2092 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2093 (emacs_gnutls_write, emacs_gnutls_read)
2094 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2095 (Fgnutls_available_p): New function.
2096 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2097 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2098 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2099
2100 * image.c: Include w32.h.
2101 (Vimage_type_cache): Delete.
2102 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2103 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2104 (w32_delayed_load): Move to w32.c.
2105
2106 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2107
2108 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2109 (w32_delayed_load): Move from image.c. When loading a library, record
2110 its filename in the :loaded-from property of the library id.
2111 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2112 Initialize and staticpro them.
2113 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2114
2115 * process.c: Include lisp.h before w32.h, not after.
2116 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2117 instead of gnutls_record_check_pending.
2118
2119 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2120
ff4de4aa
TZ
21212011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2122
2123 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2124 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2125 as passed in.
2126
abe95abb
JD
21272011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2128
2129 * xterm.c (x_set_frame_alpha): Do not set property on anything
2130 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2131
e16e55d4
JB
21322011-05-02 Juanma Barranquero <lekktu@gmail.com>
2133
2134 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2135
bafcf6a5
JB
21362011-05-02 Juanma Barranquero <lekktu@gmail.com>
2137
2138 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2139 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2140 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2141 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2142 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2143 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2144 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2145 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2146 (Qgnutls_bootprop_callbacks_verify): Make static.
2147
e7a6747f
AS
21482011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2149
19ed11ba
AS
2150 * callproc.c: Indentation fixup.
2151
e7a6747f 2152 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2153 (wait_for_termination, interruptible_wait_for_termination):
2154 Move after wait_for_termination_1.
e7a6747f 2155
1ef14cb4
LMI
21562011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2157
2158 * sysdep.c (interruptible_wait_for_termination): New function
2159 which is like wait_for_termination, but allows keyboard
2160 interruptions.
2161
2162 * callproc.c (Fcall_process): Add (:file "file") as an option for
2163 the STDOUT buffer.
2164 (Fcall_process_region): Ditto.
2165
330d880c
EZ
21662011-04-30 Eli Zaretskii <eliz@gnu.org>
2167
8db90b73
EZ
2168 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2169 rather than `XVECTOR (FOO)->size'.
2170
330d880c
EZ
2171 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2172 inttypes.h, as a gnulib replacement is used if it not available in
2173 system headers.
2174
15cbd324
EZ
21752011-04-21 Eli Zaretskii <eliz@gnu.org>
2176
2177 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2178 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2179 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2180
2181 * coding.c (coding_alloc_by_realloc): Error out if destination
2182 will grow beyond MOST_POSITIVE_FIXNUM.
2183 (decode_coding_emacs_mule): Abort if there isn't enough place in
2184 charbuf for the composition carryover bytes. Reserve an extra
2185 space for up to 2 characters produced in a loop.
2186 (decode_coding_iso_2022): Abort if there isn't enough place in
2187 charbuf for the composition carryover bytes.
2188
21892011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2190
ae940cca
EZ
2191 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2192 aborting when %lld or %lll format is passed.
2193 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2194 %llo or %llx format is passed. (Bug#8545)
2195
03ab8921
EZ
2196 * window.c (window_scroll_line_based): Use a marker instead of
2197 simple variables to record original value of point. (Bug#7952)
2198
afda1437
EZ
2199 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2200 produced by %s or %c overflows available buffer space. (Bug#8545)
2201
f76dee0c
PE
22022011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2203
2204 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2205 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2206
fdc5744d
JB
22072011-04-28 Juanma Barranquero <lekktu@gmail.com>
2208
2209 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2210
638f053a
JB
22112011-04-28 Juanma Barranquero <lekktu@gmail.com>
2212
2213 * keyboard.c (Qdelayed_warnings_hook): Define.
2214 (command_loop_1): Run `delayed-warnings-hook'
2215 if Vdelayed_warnings_list is non-nil.
2216 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2217 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2218
d178f871
EZ
22192011-04-28 Eli Zaretskii <eliz@gnu.org>
2220
2221 * doprnt.c (doprnt): Don't return value smaller than the buffer
2222 size if the message was truncated. (Bug#8545).
2223
b124fd93
JB
22242011-04-28 Juanma Barranquero <lekktu@gmail.com>
2225
2226 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2227 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2228
e810457d
PE
22292011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2230
2231 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2232
ea51cceb
JB
22332011-04-27 Juanma Barranquero <lekktu@gmail.com>
2234
2235 * makefile.w32-in: Update dependencies.
2236
94dcfacf
EZ
22372011-04-27 Eli Zaretskii <eliz@gnu.org>
2238
2239 Improve `doprnt' and its usage. (Bug#8545)
2240 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2241 `format_end'. Remove support for %l as a conversion specifier.
2242 Don't use xrealloc. Improve diagnostics when the %l size modifier
2243 is used. Update the commentary.
2244
2245 * eval.c (verror): Simplify calculation of size_t.
2246
2247 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2248 messages.
2249
f61f41d7
PE
22502011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2251
2252 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2253 change.
2254
96fb4434
PE
22552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2256
2257 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2258 This makes this file independent of the recent pseudovector change.
2259
671875da 22602011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2261
69e9b5a3
PE
2262 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2263
b5f869a7 2264 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2265 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2266 Remove unused local.
c8926152 2267 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2268
841a1577 2269 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2270 GCC 4.6.0 optimizes based on type-based alias analysis.
2271 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2272 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2273 != &v->size, and therefore "v->size = 1; b->size = 2; return
2274 v->size;" must therefore return 1. This assumption is incorrect
2275 for Emacs, since it type-puns struct Lisp_Vector * with many other
2276 types. To fix this problem, this patch adds a new type struct
f904488f 2277 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2278 and pseudovectors, and helps optimizing compilers not get fooled
2279 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2280 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2281 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2282 the size member.
eab3844f
PE
2283 (XSETPVECTYPE): Rewrite in terms of new macro.
2284 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2285 This is a bit clearer, and further avoids the possibility of
2286 undesirable aliasing.
2287 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2288 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2289 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2290 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2291 (ASIZE): Now uses header.size rather than size.
2292 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2293 to avoid the hassle of writing XVECTOR (foo)->header.size.
2294 (struct vectorlike_header): New type.
eab3844f
PE
2295 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2296 object, to help avoid aliasing.
2297 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2298 (SUBRP): Likewise, since Lisp_Subr is a special case.
2299 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2300 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2301 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2302 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2303 changed to be "header.size" and "header.next".
2304 * buffer.h (struct buffer): Likewise.
2305 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2306 * frame.h (struct frame): Likewise.
2307 * process.h (struct Lisp_Process): Likewise.
2308 * termhooks.h (struct terminal): Likewise.
2309 * window.c (struct save_window_data, struct saved_window): Likewise.
2310 * window.h (struct window): Likewise.
2311 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2312 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2313 * buffer.c (init_buffer_once): Likewise.
2314 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2315 special case.
2316 * process.c (Fformat_network_address): Use local var for size,
2317 for brevity.
2318
0df1eac5
PE
2319 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2320
847ab9d1 2321 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2322 * data.c (atof): Remove decl; no longer used or needed.
2323 (digit_to_number): Move to lread.c.
2324 (Fstring_to_number): Use new string_to_number function, to be
2325 consistent with how the Lisp reader treats infinities and NaNs.
2326 Do not assume that floating-point numbers represent EMACS_INT
2327 without losing information; this is not true on most 64-bit hosts.
2328 Avoid double-rounding errors, by insisting on integers when
2329 parsing non-base-10 numbers, as the documentation specifies.
2330 * lisp.h (string_to_number): New decl, replacing ...
2331 (isfloat_string): Remove.
bc0a5c13 2332 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2333 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2334 appears to have been a coding error. Similarly, do not accept
2335 strings like +-1e0 as floating point numbers. Do not report
2336 overflow for integer overflows unless the base is not 10 which
2337 means we have no simple and reliable way to continue.
2338 Break out the floating-point parsing into a new
2339 function string_to_number, so that Fstring_to_number parses
2340 floating point numbers consistently with the Lisp reader.
04f2d78b 2341 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2342 (E_CHAR, EXP_INT): Remove, replacing with ...
2343 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2344 (string_to_number): New function, replacing isfloat_string.
2345 This function checks for valid syntax and produces the resulting
2346 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2347 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2348 so that overflow for non-base-10 numbers is reported only when
2349 there's no portable and simple way to convert to floating point.
452f4150 2350
67769ffc
PE
2351 * textprop.c (set_text_properties_1): Rewrite for clarity,
2352 and to avoid GCC warning about integer overflow.
2353
c20db43f
PE
2354 * intervals.h (struct interval): Use EMACS_INT for members
2355 where EMACS_UINT might cause problems. See
2356 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2357 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2358 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2359 All uses changed.
37aa2f85
PE
2360 (offset_intervals): Tell GCC not to worry about length overflow
2361 when negating a negative length.
c20db43f 2362
2538aa2f
PE
2363 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2364 (overrun_check_free): Likewise.
2365
f2d3008d
PE
2366 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2367 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2368 word size.
2369
ec8df744
PE
2370 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2371 (gnutls_make_error): Rename local to avoid shadowing.
2372 (gnutls_emacs_global_deinit): ifdef out; not used.
2373 (Fgnutls_boot): Use const for pointer to readonly storage.
2374 Comment out unused local. Fix pointer signedness problems.
2375
640ee02d
PE
2376 * lread.c (openp): Don't stuff size_t into an 'int'.
2377 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2378 about possible signed overflow.
2379
6048fb2a
PE
2380 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2381 (GDK_KEY_g): Don't define if already defined.
2382 (xg_prepare_tooltip): Avoid pointer signedness problem.
2383 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2384
fa3c87e1
PE
2385 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2386 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2387
2172544b
PE
2388 * xfns.c (Fx_window_property): Simplify a bit,
2389 to make a bit faster and to avoid GCC 4.6.0 warning.
2390 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2391
9b821a21
PE
2392 * fns.c (internal_equal): Don't assume size_t fits in int.
2393
3c616cfa
PE
2394 * alloc.c (compact_small_strings): Tighten assertion a little.
2395
c2982e87
PE
2396 Replace pEd with more-general pI, and fix some printf arg casts.
2397 * lisp.h (pI): New macro, generalizing old pEd macro to other
2398 conversion specifiers. For example, use "...%"pI"d..." rather
2399 than "...%"pEd"...".
2400 (pEd): Remove. All uses replaced with similar uses of pI.
2401 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2402 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2403 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2404 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2405 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2406 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2407 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2408 64-bit hosts.
2409 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2410 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2411 * print.c (safe_debug_print, print_object): Likewise.
2412 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2413 to int.
6f04d126
PE
2414 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2415 avoiding the 0 flag, which is not portable.
c2982e87
PE
2416 * process.c (Fmake_network_process): Use pI to avoid cast.
2417 * region-cache.c (pp_cache): Likewise.
2418 * xdisp.c (decode_mode_spec): Likewise.
2419 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2420 behavior on 64-bit hosts with printf arg.
6f04d126 2421 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2422 (x_stop_queuing_selection_requests): Likewise.
2423 (x_get_window_property): Don't truncate byte count to an 'int'
2424 when tracing.
0b432f21 2425
5e073ec7
PE
2426 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2427 here, since it parses constructs like leading '-' and spaces,
2428 which are not wanted; and it overflows with large numbers.
2429 Instead, simply match F[0-9]+, which is what is wanted anyway.
2430
36372bf9
PE
2431 * alloc.c: Remove unportable assumptions about struct layout.
2432 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2433 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2434 (allocate_vectorlike, make_pure_vector): Use the new macros,
2435 plus offsetof, to remove unportable assumptions about struct layout.
2436 These assumptions hold on all porting targets that I know of, but
2437 they are not guaranteed, they're easy to remove, and removing them
2438 makes further changes easier.
2439
0b432f21
PE
2440 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2441 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2442 (string_overrun_cookie): Now const. Use initializers that
2443 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2444 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2445 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2446 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2447 multiple of sizeof (EMACS_INT); it need not be, if
2448 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2449 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2450
895009e1
JB
24512011-04-26 Juanma Barranquero <lekktu@gmail.com>
2452
2453 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2454
6a7a1b0b
TZ
24552011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2456
2457 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2458 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2459 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2460
841a1577 24612011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2462
2463 * lisp.h (Qdebug): List symbol.
895009e1 2464 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2465 * keyboard.c (debug-on-event): New variable.
2466 (handle_user_signal): Break into debugger when debug-on-event
2467 matches the current signal symbol.
2468
f2d3ba6f
DN
24692011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2470
2471 * alloc.c (check_sblock, check_string_bytes)
2472 (check_string_free_list): Convert to standard C.
2473
42ce4c63
TZ
24742011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2475
2476 * w32.c (emacs_gnutls_push): Fix typo.
2477
825cd63c
EZ
24782011-04-25 Eli Zaretskii <eliz@gnu.org>
2479
fb11d64d
EZ
2480 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2481 "cast to pointer from integer of different size".
2482
825cd63c
EZ
2483 Improve doprnt and its use in verror. (Bug#8545)
2484 * doprnt.c (doprnt): Document the set of format control sequences
2485 supported by the function. Use SAFE_ALLOCA instead of always
2486 using `alloca'.
2487
2488 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2489 is one byte too soon. Don't use xrealloc; instead xfree and
2490 xmalloc anew.
2491
e061a11b
TZ
24922011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2493
2494 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2495 callbacks stage.
2496
2497 * gnutls.c: Renamed global_initialized to
2498 gnutls_global_initialized. Added internals for the
2499 :verify-hostname-error, :verify-error, and :verify-flags
2500 parameters of `gnutls-boot' and documented those parameters in the
2501 docstring. Start callback support.
2502 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2503 unless a fatal error occured. Call gnutls_alert_send_appropriate
2504 on error. Return error code.
2505 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2506 (emacs_gnutls_read): Likewise.
2507 (Fgnutls_boot): Return handshake error code.
2508 (emacs_gnutls_handle_error): New function.
2509 (wsaerror_to_errno): Likewise.
2510
2511 * w32.h (emacs_gnutls_pull): Add prototype.
2512 (emacs_gnutls_push): Likewise.
2513
2514 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2515 (emacs_gnutls_push): Likewise.
2516
25172011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2518
2519 * process.c (wait_reading_process_output): Check if GnuTLS
2520 buffered some data internally if no FDs are set for TLS
2521 connections.
2522
2523 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2524 (LIBS): Link to USER_LIBS.
2525 ($(BLD)/gnutls.$(0)): New target.
2526
fa6996bc
EZ
25272011-04-24 Eli Zaretskii <eliz@gnu.org>
2528
eb35682e
EZ
2529 * xdisp.c (handle_single_display_spec): Rename the
2530 display_replaced_before_p argument into display_replaced_p, to
2531 make it consistent with the commentary. Fix typos in the
2532 commentary.
2533
e2ad650c
EZ
2534 * textprop.c (syms_of_textprop): Remove dead code.
2535 (copy_text_properties): Delete obsolete commentary about an
2536 interface that was deleted long ago. Fix typos in the description
2537 of arguments.
2538
1b2de274
EZ
2539 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2540 to changes in oldXMenu/XMenu.h from 2011-04-16.
2541 <menu_help_message, prev_menu_help_message>: Constify.
2542 (IT_menu_make_room): menu->help_text is now `const char **';
2543 adjust.
2544
2545 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2546 to changes in oldXMenu/XMenu.h from 2011-04-16.
2547 (struct XMenu): Declare `help_text' `const char **'.
2548
2549 * xfaces.c <Qunspecified>: Make extern again.
2550
2551 * syntax.c: Include sys/types.h before including regex.h, as
2552 required by Posix.
2553
762b15be
EZ
2554 * doc.c (get_doc_string): Improve the format passed to `error'.
2555
2556 * doprnt.c (doprnt): Improve commentary.
2557
2558 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2559
2560 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2561 them with etags.
2562
f1052e5d
EZ
2563 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2564 changes in globals.h immediately force recompilation.
762b15be
EZ
2565 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2566 $(CURDIR)/s/ms-w32.h.
2567 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2568
fa6996bc
EZ
2569 * character.c (Fchar_direction): Function deleted.
2570 (syms_of_character): Don't defsubr it.
2571 <char-direction-table>: Deleted.
2572
e6c3da20
EZ
25732011-04-23 Eli Zaretskii <eliz@gnu.org>
2574
2575 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2576 * doprnt.c: Include limits.h.
2577 (SIZE_MAX): New macro.
04f2d78b
CB
2578 (doprnt): Return a size_t value. 2nd arg is now size_t.
2579 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2580 Improve overflow protection. Support `l' modifier for integer
2581 conversions. Support %l conversion. Don't assume an EMACS_INT
2582 argument for integer conversions and for %c.
2583
2584 * lisp.h (doprnt): Restore prototype.
2585
2586 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2587 $(SRC)/character.h.
2588
2589 * Makefile.in (base_obj): Add back doprnt.o.
2590
2591 * deps.mk (doprnt.o): Add back prerequisites.
2592 (callint.o): Depend on character.h.
2593
2594 * eval.c (internal_lisp_condition_case): Include the handler
2595 representation in the error message.
2596 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2597 when breaking from the loop.
2598
2599 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2600
2601 * callint.c (Fcall_interactively): When displaying error message
2602 about invalid control letter, pass the character's codepoint, not
2603 a pointer to its multibyte form. Improve display of the character
2604 in octal and display also its hex code.
2605
2606 * character.c (char_string): Use %x to display the (unsigned)
2607 codepoint of an invalid character, to avoid displaying a bogus
2608 negative value.
2609
2610 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2611 `error', not SYMBOL_NAME itself.
2612
2613 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2614 character arguments to `error'.
2615
2616 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2617 to `error' in error message about FINAL_CHAR argument. Make sure
2618 FINAL_CHAR is a character, and use %c when it is passed as
2619 argument to `error'.
2620
4ffd0d6b 26212011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2622
2623 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2624
2625 * w32.c: Include <time.h>.
2626 (sys_localtime): New function.
2627
4ffd0d6b 26282011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2629
2630 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2631
4ffd0d6b 2632 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2633
4ffd0d6b 26342011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2635
4ffd0d6b
GM
2636 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2637 zombies (Bug#8467).
aac0c6e3 2638
04c56954
EZ
26392011-04-19 Eli Zaretskii <eliz@gnu.org>
2640
2641 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2642 gl_state.e_property when gl_state.object is Qt.
2643
2644 * insdel.c (make_gap_larger): Remove limitation of buffer size
2645 to <= INT_MAX.
2646
16a43933
CY
26472011-04-18 Chong Yidong <cyd@stupidchicken.com>
2648
2649 * xdisp.c (lookup_glyphless_char_display)
2650 (produce_glyphless_glyph): Handle cons cell entry in
2651 glyphless-char-display.
2652 (Vglyphless_char_display): Document it.
2653
2654 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2655 glyphless-char-display.
2656
4581706e
CY
26572011-04-17 Chong Yidong <cyd@stupidchicken.com>
2658
2659 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2660
2661 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2662
2663 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2664 definition for no-X builds.
2665
4887c6e2 26662011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2667
fd35b6f9
PE
2668 Static checks with GCC 4.6.0 and non-default toolkits.
2669
5c1ccb01
PE
2670 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2671
006c5daa
PE
2672 * process.c (keyboard_bit_set): Define only if SIGIO.
2673 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2674 (send_process): Repair possible setjmp clobbering.
2675
efc736d3
PE
2676 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2677
4e2fe2e6
PE
2678 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2679
f97334a2
PE
2680 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2681
4e75f29d
PE
2682 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2683 Define only if needed.
2684
90efadd1
PE
2685 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2686 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2687 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2688
3c647824
PE
2689 * dispextern.h (struct redisplay_interface): Rename param
2690 to avoid shadowing.
e264f262 2691 * termhooks.h (struct terminal): Likewise.
761383f4 2692 * xterm.c (xembed_send_message): Likewise.
3c647824 2693
b58c5c4a
PE
2694 * insdel.c (make_gap_smaller): Define only if
2695 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2696
cad59032
PE
2697 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2698 it.
2699
c339dc2e
PE
2700 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2701 so that we aren't warned about unused symbols.
2702
91a3e27b
PE
2703 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2704
399c71d3 2705 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2706
8ffc96f5
PE
2707 * xfns.c (x_real_positions): Mark locals as initialized.
2708
eef9bc79
PE
2709 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2710
098db9dd
PE
2711 * xterm.c: Fix problems found by static analysis with other toolkits.
2712 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2713 (x_dispatch_event): Declare static if USE_GTK, and
2714 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2715 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2716 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2717 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2718 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2719
eb18f6cc
PE
2720 * xmenu.c (menu_help_callback): Pointer type fixes.
2721 Use const pointers when pointing at readonly data. Avoid pointer
2722 signedness clashes.
2723 (FALSE): Remove unused macro.
2724 (update_frame_menubar): Remove unused decl.
2725
1fe72bf8
PE
2726 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2727
60d9e1db
PE
2728 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2729 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2730 (single_menu_item): Rename local to avoid shadowing.
2731
39261c26
PE
2732 * keyboard.c (make_lispy_event): Remove unused local var.
2733
018c5e19
PE
2734 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2735 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2736
63d2b86e
PE
2737 * bitmaps: Change bitmaps from unsigned char back to the X11
2738 compatible char. Avoid the old compiler warnings about
2739 out-of-range initializers by using, for example, '\xab' rather
2740 than 0xab.
2741
aefd87e1
PE
2742 * xgselect.c (xgselect_initialize): Check vs interface
2743 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2744
bf501fb9
PE
2745 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2746
e9829fdf
PE
2747 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2748 to read-only memory.
2749
1086c095
PE
2750 * fns.c (vector): Remove; this old hack is no longer needed.
2751
2baccd04 2752 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2753 Remove unused var.
dde42981 2754 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2755
72391843 2756 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2757
436c16df 2758 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2759 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2760 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2761
92bb796d 2762 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2763 (x_term_init): Remove local to avoid shadowing.
92bb796d 2764
764430a3 2765 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2766
2767 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2768 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2769
d1dfb56c
EZ
27702011-04-16 Eli Zaretskii <eliz@gnu.org>
2771
c4354cb4
EZ
2772 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2773
d1dfb56c
EZ
2774 Fix regex.c, syntax.c and friends for buffers > 2GB.
2775 * syntax.h (struct gl_state_s): Declare character position members
2776 EMACS_INT.
2777
2778 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2779
04f2d78b
CB
2780 * textprop.c (verify_interval_modification, interval_of):
2781 Declare arguments EMACS_INT.
d1dfb56c
EZ
2782
2783 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2784 EMACS_INT.
2785
2786 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2787
2788 * indent.c (Fvertical_motion): Local variable it_start is now
2789 EMACS_INT.
2790
2791 * regex.c (re_match, re_match_2, re_match_2_internal)
2792 (bcmp_translate, regcomp, regexec, print_double_string)
2793 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2794 (re_compile_pattern, re_exec): Declare arguments and local
2795 variables `size_t' and `ssize_t' and return values `regoff_t', as
2796 appropriate.
2797 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2798 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2799 <compile_stack_type>: `size' and `avail' are now `size_t'.
2800
2801 * regex.h <regoff_t>: Use ssize_t, not int.
2802 (re_search, re_search_2, re_match, re_match_2): Arguments that
2803 specify buffer/string position and length are now ssize_t and
2804 size_t. Return type is regoff_t.
2805
613052cd
BK
28062011-04-16 Ben Key <bkey76@gmail.com>
2807
2808 * nsfont.m: Fixed bugs in ns_get_family and
2809 ns_descriptor_to_entity that were caused by using free to
2810 deallocate memory blocks that were allocated by xmalloc (via
2811 xstrdup). This caused Emacs to crash when compiled with
2812 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2813 --enable-checking=xmallocoverrun). xfree is now used to
2814 deallocate these memory blocks.
2815
4170f62f 28162011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2817
71b41406
PE
2818 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2819
9587a89d
PE
2820 emacs_write: Accept and return EMACS_INT for sizes.
2821 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2822 et seq.
2823 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2824 Accept and return EMACS_INT.
2825 (emacs_gnutls_write): Return the number of bytes written on
2826 partial writes.
2827 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2828 (emacs_read, emacs_write): Remove check for negative size, as the
2829 Emacs source code has been audited now.
9587a89d
PE
2830 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2831 (emacs_read, emacs_write): Use it.
273a5f82
PE
2832 * process.c (send_process): Adjust to the new signatures of
2833 emacs_write and emacs_gnutls_write. Do not attempt to store
2834 a byte offset into an 'int'; it might overflow.
9587a89d 2835 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2836
3e047f51
PE
2837 * sound.c: Don't assume sizes fit in 'int'.
2838 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2839 Return EMACS_INT, not int.
3e047f51 2840 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2841 Accept EMACS_INT, not int.
2842 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2843 record read return values.
2844
cc39a9db
BK
28452011-04-15 Ben Key <bkey76@gmail.com>
2846
c9d0ec6d
JB
2847 * keyboard.c (Qundefined): Don't declare static since it is used
2848 in nsfns.m.
2849 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2850 static since they are used in nsfont.m.
cc39a9db 2851
6c60eb9f
SM
28522011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2853
2854 * process.c (Qprocessp): Don't declare static.
2855 * lisp.h (Qprocessp): Declare again.
2856
7990b61a
JB
28572011-04-15 Juanma Barranquero <lekktu@gmail.com>
2858
2859 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2860
5d4cb038
PE
28612011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2862
8bd7b830 2863 Improve C-level modularity by making more things 'static'.
cd64ea1d 2864
e3b27b31
PE
2865 Don't publish debugger-only interfaces to other modules.
2866 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2867 (verify_bytepos, count_markers): Move decls to the only modules
2868 that need them.
2869 * region-cache.h (pp_cache): Likewise.
2870 * window.h (check_all_windows): Likewise.
2871 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2872
5d4cb038
PE
2873 * sysdep.c (croak): Now static, if
2874 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2875 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2876
2877 * alloc.c (refill_memory_reserve): Now static if
2878 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2879 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2880
e87b6180
PE
2881 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2882 Define only if USE_LUCID.
2883
ac64929e
PE
2884 * xrdb.c (x_customization_string, x_rm_string): Now static.
2885
6f37259d
PE
2886 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2887 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2888
1683e3ab
PE
2889 * xdisp.c (draw_row_with_mouse_face): Now static.
2890 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2891
de9c2632
PE
2892 * window.h (check_all_windows): Mark externally visible.
2893
2b96acb7
PE
2894 * window.c (window_deletion_count): Now static.
2895
2896 * undo.c: Make symbols static if they're not exported.
2897 (last_undo_buffer, last_boundary_position, pending_boundary):
2898 Now static.
2899
50436f33
PE
2900 * textprop.c (interval_insert_behind_hooks): Now static.
2901 (interval_insert_in_front_hooks): Likewise.
2902
64520e5c
PE
2903 * term.c: Make symbols static if they're not exported.
2904 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2905 (max_frame_lines, tty_set_terminal_modes):
2906 (tty_reset_terminal_modes, tty_turn_off_highlight):
2907 (get_tty_terminal): Now static.
2908 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2909 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2910 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2911 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2912 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2913
1fa53021
PE
2914 * sysdep.c: Make symbols static if they're not exported.
2915 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2916 Now static.
2917 (sigprocmask_set, full_mask): Remove; unused.
2918 (wait_debugging): Mark as visible.
2919 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2920 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2921
d4b43b22
PE
2922 * syntax.c (syntax_temp): Define only if !__GNUC__.
2923
b7c513d0
PE
2924 * sound.c (current_sound_device, current_sound): Now static.
2925
989b29ad
PE
2926 * search.c (searchbufs, searchbuf_head): Now static.
2927
13a55a78
PE
2928 * scroll.c (scroll_cost): Remove; unused.
2929 * dispextern.h (scroll_cost): Remove decl.
2930
de68a1fc
PE
2931 * region-cache.h (pp_cache): Mark as externally visible.
2932
40ccffa6
PE
2933 * process.c: Make symbols static if they're not exported.
2934 (process_tick, update_tick, create_process, chan_process):
2935 (Vprocess_alist, proc_buffered_char, datagram_access):
2936 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2937 (deactivate_process): Mark defn as static, as well as decl.
2938 * lisp.h (create_process): Remove decl.
2939 * process.h (chan_process, Vprocess_alist): Remove decls.
2940
ad64fc97
PE
2941 * print.c: Make symbols static if they're not exported.
2942 (print_depth, new_backquote_output, being_printed, print_buffer):
2943 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2944 (print_interval, print_number_index, initial_stderr_stream):
2945 Now static.
2946 * lisp.h (Fprinc): Remove decl.
2947 (debug_output_compilation_hack): Mark as externally visible.
2948
adddb265
PE
2949 * sysdep.c (croak): Move decl from here to syssignal.h.
2950 * syssignal.h (croak): Put it here, so the API can be checked when
2951 'croak' is called from dissociate_if_controlling_tty.
2952
1717ede2
PE
2953 * minibuf.c: Make symbols static if they're not exported.
2954 (minibuf_save_list, choose_minibuf_frame): Now static.
2955 * lisp.h (choose_minibuf_frame): Remove decl.
2956
fa5fb2bc
PE
2957 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2958
1e3890d1
PE
2959 * lread.c: Make symbols static if they're not exported.
2960 (read_objects, initial_obarray, oblookup_last_bucket_number):
2961 Now static.
2962 (make_symbol): Remove; unused.
2963 * lisp.h (initial_obarray, make_symbol): Remove decls.
2964
8a1414fa
PE
2965 * keyboard.c: Make symbols static if they're not exported.
2966 (single_kboard, recent_keys_index, total_keys, recent_keys):
2967 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2968 (this_single_command_key_start, echoing, last_auto_save):
2969 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2970 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2971 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2972 (Vlispy_mouse_stem, double_click_count):
2973 Now static.
2974 (force_auto_save_soon): Define only if SIGDANGER.
2975 (ignore_mouse_drag_p): Now static if
2976 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2977 (print_help): Remove; unused.
2978 (stop_character, last_timer_event): Mark as externally visible.
2979 * keyboard.h (ignore_mouse_drag_p): Declare only if
2980 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2981 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2982 * lisp.h (echoing): Remove decl.
2983 (force_auto_save_soon): Declare only if SIGDANGER.
2984 * xdisp.c (redisplay_window): Simplify code, to make it more
2985 obvious that ignore_mouse_drag_p is not accessed if !defined
2986 USE_GTK && !defined HAVE_NS.
2987
93ea6e8f
PE
2988 * intervals.c: Make symbols static if they're not exported.
2989 (merge_properties_sticky, merge_interval_right, delete_interval):
2990 Now static.
2991 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2992
77382fcc
PE
2993 * insdel.c: Make symbols static if they're not exported.
2994 However, leave prepare_to_modify_buffer alone. It's never
2995 called from outside this function, but that appears to be a bug.
2996 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2997 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2998 (adjust_after_replace_noundo): Remove; unused.
2999 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3000 (signal_before_change): Remove decls.
77382fcc 3001
9306c32e
PE
3002 * indent.c (val_compute_motion, val_vmotion): Now static.
3003
cd44d2eb
PE
3004 * image.c: Make symbols static if they're not exported.
3005 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3006 if USE_GTK.
3007 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3008 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3009
ad9a7a06
PE
3010 * fringe.c (standard_bitmaps): Now static.
3011 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3012
81626931
PE
3013 * frame.c: Make symbols static if they're not exported.
3014 (x_report_frame_params, make_terminal_frame): Now static.
3015 (get_frame_param): Now static, unless HAVE_NS.
3016 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3017 (x_get_resource_string): Remove; not used.
3018 * frame.h (make_terminal_frame, x_report_frame_params):
3019 (x_get_resource_string); Remove decls.
3020 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3021 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3022
239f9db9
PE
3023 * font.c, fontset.c: Make symbols static if they're not exported.
3024 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3025 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3026 * font.c (font_close_object): Now static.
3027 * font.h (font_close_object): Remove.
3028 * fontset.c (FONTSET_OBJLIST): Remove.
3029 (free_realized_fontset) #if-0 the body, which does nothing.
3030 (face_suitable_for_char_p): #if-0, as it's never called.
3031 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3032 * xfaces.c (face_at_string_position):
3033 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3034 since 0 is always ASCII.
3035
dfcf3579
PE
3036 * fns.c (weak_hash_tables): Now static.
3037
5045092b
PE
3038 * fileio.c: Make symbols static if they're not exported.
3039 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3040 (Vwrite_region_annotation_buffers): Now static.
3041
57a96f5c
PE
3042 * eval.c: Make symbols static if they're not exported.
3043 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3044 * lisp.h (backtrace_list): Remove decl.
3045
35f08c38
PE
3046 * emacs.c: Make symbols static if they're not exported.
3047 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3048 (fatal_error_code, fatal_error_signal_hook, standard_args):
3049 Now static.
3050 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3051 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3052 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3053 * lisp.h (fatal_error_signal_hook): Remove decl.
3054 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3055
f44bd759
PE
3056 * editfns.c: Move a (normally-unused) function to its only use.
3057 * editfns.c, lisp.h (get_operating_system_release): Remove.
3058 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3059 worth the hassle of breaking this out.
3060
b532497d
PE
3061 * xterm.c: Make symbols static if they're not exported.
3062 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3063 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3064 (x_destroy_window, x_delete_display):
3065 Now static.
3066 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3067 (x_mouse_leave): Remove; unused.
3068 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3069 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3070 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3071 Remove decls.
3072 (x_mouse_leave): Declare only if WINDOWSNT.
3073 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3074 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3075 USE_X_TOOLKIT.
3076
1675728f
PE
3077 * ftxfont.c: Make symbols static if they're not exported.
3078 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3079 HAVE_FREETYPE.
3080 * font.h (ftxfont_driver): Likewise.
3081
e4cebfca
PE
3082 * xfns.c: Make symbols static if they're not exported.
3083 (x_last_font_name, x_display_info_for_name):
3084 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3085 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3086 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3087 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3088 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3089 (last_show_tip_args): Now static.
3090 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3091 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3092 (x_screen_planes): Remove; unused.
3093 * dispextern.h (x_screen_planes): Remove decl.
3094
5bf46f05
PE
3095 * dispnew.c: Make symbols static if they're not exported.
3096 * dispextern.h (redraw_garbaged_frames, scrolling):
3097 (increment_row_positions): Remove.
3098 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3099 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3100 Now static.
3101 (redraw_garbaged_frames): Remove; unused.
3102
435f4c28
PE
3103 * xfaces.c: Make symbols static if they're not exported.
3104 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3105 Remove decls.
3106 * xterm.h (defined_color): Remove decls.
3107 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3108 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3109 (menu_face_changed_default, defined_color, free_realized_face):
3110 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3111 (ascii_face_of_lisp_face): Remove; unused.
3112
8524aef3
PE
3113 * xdisp.c: Make symbols static if they're not exported.
3114 * dispextern.h (scratch_glyph_row, window_box_edges):
3115 (glyph_to_pixel_coords, set_cursor_from_row):
3116 (get_next_display_element, set_iterator_to_next):
3117 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3118 (show_mouse_face): Remove decls
3119 * frame.h (message_buf_print): Likewise.
3120 * lisp.h (pop_message, set_message, check_point_in_composition):
3121 Likewise.
3122 * xterm.h (set_vertical_scroll_bar): Likewise.
3123 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3124 (message_buf_print, scratch_glyph_row, displayed_buffer):
3125 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3126 (get_next_display_element, show_mouse_face, window_box_edges):
3127 (frame_to_window_pixel_xy, check_point_in_composition):
3128 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3129 (glyph_to_pixel_coords): Remove; unused.
3130
16390cd2
PE
3131 * dired.c (file_name_completion): Now static.
3132
3133 * dbusbind.c (xd_in_read_queued_messages): Now static.
3134
a25f4dfa
PE
3135 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3136 * data.c (circular_list_error): Remove.
3137
14a9c8df
PE
3138 * commands.h (last_point_position, last_point_position_buffer):
3139 (last_point_position_window): Remove decls.
3140 * keyboard.c: Make these variables static.
3141
04f2d78b
CB
3142 * coding.h (coding, code_convert_region, encode_coding_gap):
3143 Remove decls.
74ab6df5
PE
3144 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3145 (iso_code_class, detect_coding, code_convert_region): Now static.
3146 (encode_coding_gap): Remove; unused.
3147
38dfbee1
PE
3148 * chartab.c (chartab_chars, chartab_bits): Now static.
3149
a2cb4e63
PE
3150 * charset.h (charset_iso_8859_1): Remove decl.
3151 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3152 Now static.
3153
127198fd
PE
3154 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3155 * ccl.c (Vccl_program_table): Now static.
3156 (check_ccl_update): Remove; unused.
3157
d85b608f
PE
3158 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3159 * category.h: ... from here.
3160 * category.c (check_category_table, set_category_set): Now static.
3161
31cd66f3
PE
3162 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3163 * lisp.h: Remove these decls.
3164
c358e587
PE
3165 * buffer.c (buffer_count): Remove unused var.
3166
e78aecca
PE
3167 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3168 so that it's not optimized away.
3169 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3170 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3171 exported only to the debugger.
3172
e192d7d3 3173 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3174 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3175
92470028
PE
3176 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3177 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3178 was inaccessible from Lisp.
3179 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3180 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3181
244ed907
PE
3182 alloc.c: Import and export fewer symbols, and remove unused items.
3183 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3184 is defined.
3185 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3186 it's not optimized away by whole-program optimization.
3187 (message_enable_multibyte, free_misc): Remove.
3188 (catchlist, handlerlist, mark_backtrace):
3189 Declare only if BYTE_MARK_STACK.
3190 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3191 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3192 (message_enable_multibyte): Remove decl.
3193 (free_misc, interval_free_list, float_block, float_block_index):
3194 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3195 (cons_free_list, last_marked_index):
3196 Now static.
3197 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3198 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3199 (mark_backtrace): Define only if BYTE_MARK_STACK.
3200 * xdisp.c (message_enable_multibyte): Now static.
3201
61c2b50e 3202 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3203 This makes it easier for human readers (and static analyzers)
3204 to see whether these variables are used from other modules.
3205 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3206 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3207 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3208 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3209 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3210 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3211 * xmenu.c, xselect.c:
3212 Declare Q* vars static if they are not used in other modules.
3213 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3214 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3215 Remove decls of unexported vars.
3216 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3217
95c82688
PE
3218 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3219
16a97296
PE
3220 Make Emacs functions such as Fatom 'static' by default.
3221 This makes it easier for human readers (and static analyzers)
3222 to see whether these functions can be called from other modules.
3223 DEFUN now defines a static function. To make the function external
3224 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3225 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3226 (Finit_image_library):
16a97296
PE
3227 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3228 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3229 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3230 Remove decls, since these functions are now static.
3231 (Funintern, Fget_internal_run_time): New decls, since these functions
3232 were already external.
95c82688 3233
16a97296
PE
3234 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3235 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3236 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3237 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3238 * keyboard.c, keymap.c, lread.c:
3239 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3240 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3241 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3242 Mark functions with DEFUE instead of DEFUN,
3243 if they are used in other modules.
3244 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3245 decls for now-static functions.
3246 * buffer.h (Fdelete_overlay): Remove decl.
3247 * callproc.c (Fgetenv_internal): Mark as internal.
3248 * composite.c (Fremove_list_of_text_properties): Remove decl.
3249 (Fcomposition_get_gstring): New forward static decl.
3250 * composite.h (Fcomposite_get_gstring): Remove decl.
3251 * dired.c (Ffile_attributes): New forward static decl.
3252 * doc.c (Fdocumntation_property): New forward static decl.
3253 * eval.c (Ffetch_bytecode): New forward static decl.
3254 (Funintern): Remove extern decl; now in .h file where it belongs.
3255 * fileio.c (Fmake_symbolic_link): New forward static decl.
3256 * image.c (Finit_image_library): New forward static decl.
3257 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3258 * intervals.h (Fprevious_property_change):
3259 (Fremove_list_of_text_properties): Remove decls.
3260 * keyboard.c (Fthis_command_keys): Remove decl.
3261 (Fcommand_execute): New forward static decl.
3262 * keymap.c (Flookup_key): New forward static decl.
3263 (Fcopy_keymap): Now static.
3264 * keymap.h (Flookup_key): Remove decl.
3265 * process.c (Fget_process): New forward static decl.
3266 (Fprocess_datagram_address): Mark as internal.
3267 * syntax.c (Fsyntax_table_p): New forward static decl.
3268 (skip_chars): Remove duplicate decl.
3269 * textprop.c (Fprevious_property_change): New forward static decl.
3270 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3271 Now internal.
3272 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3273 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3274
785bbd42
PE
3275 * editfns.c (Fformat): Remove unreachable code.
3276
8b913b57
AS
32772011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3278
3279 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3280 change. (Bug#8496)
3281
a6744a35
EZ
32822011-04-13 Eli Zaretskii <eliz@gnu.org>
3283
3284 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3285 when at ZV. (Bug#8487)
3286
e7974947
AS
32872011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3288
baad03f0
AS
3289 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3290 (Bug#8437)
3291 * keyboard.c (parse_tool_bar_item): Likewise.
3292 * sound.c (sound_cleanup, alsa_close): Likewise.
3293 * termcap.c (tgetent): Likewise.
3294 * xfns.c (x_default_font_parameter): Likewise.
3295 * xsettings.c (read_and_apply_settings): Likewise.
3296
e7974947
AS
3297 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3298 (overrun_check_free): Protoize.
3299
28272684
PE
33002011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3301
3302 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3303 since callers should never pass a negative size.
3304 Change the signature to match that of plain 'read' and 'write'; see
3305 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3306 * lisp.h: Update prototypes of emacs_write and emacs_read.
3307
11997c76
EZ
33082011-04-11 Eli Zaretskii <eliz@gnu.org>
3309
3310 * xdisp.c (redisplay_window): Don't try to determine the character
3311 position of the scroll margin if the window start point w->startp
e896f03c 3312 is outside the buffer's accessible region. (Bug#8468)
11997c76 3313
8a2cbd72
EZ
33142011-04-10 Eli Zaretskii <eliz@gnu.org>
3315
3316 Fix write-region and its subroutines for buffers > 2GB.
3317 * fileio.c (a_write, e_write): Modify declaration of arguments and
3318 local variables to support buffers larger than 2GB.
3319 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3320
3321 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3322 argument, local variables, and return value.
3323
3324 * lisp.h: Update prototypes of emacs_write and emacs_read.
3325
3326 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3327
4073e537 33282011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3329
1ebfdcb6
PE
3330 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3331
b2ded58d
PE
3332 Fix more problems found by GCC 4.6.0's static checks.
3333
7d66342c
PE
3334 * xdisp.c (vmessage): Use a better test for character truncation.
3335
bbf47d44
PE
3336 * charset.c (load_charset_map): <, not <=, for optimization,
3337 and to avoid potential problems with integer overflow.
9248994d 3338 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3339 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3340 * editfns.c (Fformat): Likewise.
1e69125e 3341 * syntax.c (skip_chars): Likewise.
3befa583 3342
e3019616
PE
3343 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3344 This also lets GCC 4.6.0 generate slightly better loop code.
3345
becfa255
PE
3346 * callint.c (Fcall_interactively): <, not <=, for optimization.
3347 (Fcall_interactively): Count the number of arguments produced,
3348 not the number of arguments given. This is simpler and lets GCC
3349 4.6.0 generate slightly better code.
3350
dae0cd48
PE
3351 * ftfont.c: Distingish more carefully between FcChar8 and char.
3352 The previous code passed unsigned char * to a functions like
3353 strlen and xstrcasecmp that expect char *, which does not
3354 conform to the C standard.
3355 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3356 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3357 char * when the C standard requires it.
3358
76032d70
PE
3359 * keyboard.c (read_char): Remove unused var.
3360
eb3f1cc8
PE
3361 * eval.c: Port to Windows vsnprintf (Bug#8435).
3362 Include <limits.h>.
3363 (SIZE_MAX): Define if the headers do not.
3364 (verror): Do not give up if vsnprintf returns a negative count.
3365 Instead, grow the buffer. This ports to Windows vsnprintf, which
3366 does not conform to C99. Problem reported by Eli Zaretskii.
3367 Also, simplify the allocation scheme, by avoiding the need for
3368 calling realloc, and removing the ALLOCATED variable.
3369
70476b54
PE
3370 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3371
12020a9e
PE
3372 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3373 But keep the doprint source code for now, as we might revamp it
3374 and use it again (Bug#8435).
ea6c7ae6
PE
3375 * lisp.h (doprnt): Remove.
3376 * Makefile.in (base_obj): Remove doprnt.o.
3377 * deps.mk (doprnt.o): Remove.
3378
5fdb398c
PE
3379 error: Print 32- and 64-bit integers portably (Bug#8435).
3380 Without this change, on typical 64-bit hosts error ("...%d...", N)
3381 was used to print both 32- and 64-bit integers N, which relied on
3382 undefined behavior.
3383 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3384 New macro.
3385 * lisp.h (error, verror): Mark as printf-like functions.
3386 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3387 Report overflow in size calculations when allocating printf buffer.
3388 Do not truncate output string at its first null byte.
3389 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3390 Truncate the output at a character boundary, since vsnprintf does not
3391 do that.
3392 * charset.c (check_iso_charset_parameter): Convert internal
3393 character to string before calling 'error', since %c now has the
3394 printf meaning.
3395 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3396 overflow when computing char to be passed to 'error'. Do not
3397 pass Lisp_Object to 'error'; pass the integer instead.
3398 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3399 formatted with plain %d.
3400
b189fa66
PE
3401 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3402
bff87ef0
PE
3403 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3404
7e2cac20
PE
3405 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3406
ce4d90b5
PE
3407 * xterm.c (x_catch_errors): Remove duplicate declaration.
3408
266c9547
PE
3409 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3410
79c49ad2
PE
3411 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3412
368f4090
JM
34132011-04-10 Jim Meyering <meyering@redhat.com>
3414
3415 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3416 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3417 return ssize_t not "int", and use size_t as the buffer length.
3418 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3419 * gnutls.h: Update declarations.
3420 * process.c (read_process_output): Use ssize_t, to match.
3421 (send_process): Likewise.
3422
a32d4040
CY
34232011-04-09 Chong Yidong <cyd@stupidchicken.com>
3424
3425 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3426
8546720e 34272011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3428
04f2d78b
CB
3429 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3430 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3431
8546720e
GM
3432 * xterm.c (handle_one_xevent):
3433 * xmenu.c (create_and_show_popup_menu):
3434 * xselect.c (x_decline_selection_request)
3435 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3436
0a2f5c1a 34372011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3438
3439 Fix some uses of `int' instead of EMACS_INT.
3440 * search.c (string_match_1, fast_string_match)
3441 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3442 (scan_buffer, find_next_newline_no_quit)
3443 (find_before_next_newline, search_command, Freplace_match)
3444 (Fmatch_data): Make some `int' variables be EMACS_INT.
3445
3446 * xdisp.c (display_count_lines): 3rd argument and return value now
3447 EMACS_INT. All callers changed.
3448 (pint2hrstr): Last argument is now EMACS_INT.
3449
3450 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3451 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3452 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3453 (decode_coding_utf_16, decode_coding_emacs_mule)
3454 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3455 (decode_coding_ccl, decode_coding_charset)
3456 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3457 (decode_coding_iso_2022, decode_coding_emacs_mule)
3458 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3459 <char_offset, last_offset>: Declare EMACS_INT.
3460 (encode_coding_utf_8, encode_coding_utf_16)
3461 (encode_coding_emacs_mule, encode_invocation_designation)
3462 (encode_designation_at_bol, encode_coding_iso_2022)
3463 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3464 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3465 Declare EMACS_INT.
3466 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3467 (encode_invocation_designation): Last argument P_NCHARS is now
3468 EMACS_INT.
3469 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3470 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3471
3472 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3473 All users changed.
3474
3475 * ccl.c (Fccl_execute_on_string): Declare some variables
3476 EMACS_INT.
3477
8546720e 34782011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3479
3480 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3481
4e19a977
CS
34822011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3483
3484 * process.c (Fformat_network_address): Doc fix.
3485
87302331
R
34862011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3487
3488 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3489
cbb59342
CY
34902011-04-08 Chong Yidong <cyd@stupidchicken.com>
3491
3492 * keyboard.c (read_char): Call Lisp function help-form-show,
3493 instead of using internal_with_output_to_temp_buffer.
3494 (Qhelp_form_show): New var.
e0d38eeb 3495 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3496
3497 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3498
3499 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3500
e67a13ab
CY
35012011-04-06 Chong Yidong <cyd@stupidchicken.com>
3502
04f2d78b
CB
3503 * process.c (Flist_processes): Remove to Lisp.
3504 (list_processes_1): Delete.
e67a13ab 3505
973f782d
EZ
35062011-04-06 Eli Zaretskii <eliz@gnu.org>
3507
7c106b1e
EZ
3508 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3509
973f782d
EZ
3510 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3511
41cf7d1a 35122011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3513
ca23cc88
PE
3514 Fix more problems found by GCC 4.6.0's static checks.
3515
f390e2d5
PE
3516 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3517
42eea0d0
PE
3518 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3519
b69769da 3520 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3521
f9541e84
PE
3522 * xdisp.c (vmessage): Mark as a printf-like function.
3523
13841b55
PE
3524 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3525
c136c10f
PE
3526 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3527
5e2d4a30
PE
3528 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3529 printf-like functions.
3530 (tiff_load): Add casts to remove these marks before passing them
3531 to system-supplied API.
3532
583f48b9
PE
3533 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3534
b25d760e
PE
3535 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3536 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3537 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3538 directly, rather than having caller test rule sign. This avoids
3539 some unnecessary tests.
3540 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3541 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3542 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3543
bc7b6697 3544 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3545 (xfont_open): Avoid unnecessary tests.
bc7b6697 3546
27ccc379
PE
3547 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3548
dcd5c89a
PE
3549 * composite.h, composite.c (composition_gstring_put_cache):
3550 Use EMACS_INT, not int, for length.
3551
b13a45c6
PE
3552 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3553 breaking out part of COMPOSITION_DECODE_RULE.
3554 (COMPOSITION_DECODE_RULE): Use it.
3555 * composite.c (get_composition_id): Remove unused local vars,
3556 by using the new macro.
3557
1e792e4d
PE
3558 * textprop.c (set_text_properties_1): Change while to do-while,
3559 since the condition is always true at first.
3560
dc6c6455 3561 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3562 (interval_deletion_adjustment): Return unsigned value.
3563 All uses changed.
dc6c6455 3564
aba7731a
PE
3565 * process.c (list_processes_1, create_pty, read_process_output):
3566 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3567 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3568 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3569 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3570 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3571
fdfc4bf3
PE
3572 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3573
fca8fe46 3574 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3575 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3576
06a0259a 3577 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3578 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3579 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3580
e7b9e80f
PE
3581 * print.c (print_error_message): Avoid int overflow.
3582
56201685
PE
3583 * font.c (font_list_entities): Redo for clarity,
3584 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3585
78834453 3586 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3587 (font_score): Avoid potential overflow in diff calculation.
78834453 3588
0bc0b309 3589 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3590 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3591
e610eaca
PE
3592 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3593
b895abce
PE
3594 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3595 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3596 can always succeed if overflow has undefined behavior.
3597
1f1d9321 3598 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3599 (wordify): Omit three unnecessary tests.
1f1d9321 3600
c59478bc
PE
3601 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3602 All callers changed. This avoids the need for an unused var.
3603
79b73827
PE
3604 * casefiddle.c (casify_region): Remove var that is set but not used.
3605
a4db5dfe
PE
3606 * dired.c (file_name_completion): Remove var that is set but not used.
3607
43aae36e
PE
3608 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3609
2a47c44d 3610 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3611 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3612
a37c69bf
PE
3613 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3614 Check for integer overflow on size calculations.
3615
328ab8e7
PE
3616 * buffer.c (Fprevious_overlay_change): Remove var that is set
3617 but not used.
3618
e5a2a5cb
PE
3619 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3620 Remove vars that are set but not used.
8d84a6eb 3621 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3622 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3623
a60e5f68
PE
3624 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3625
f661cb61 3626 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3627 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3628
f0397f5a
PE
3629 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3630 that are set but not used.
3631
8664db06 3632 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3633 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3634
6abdaa4a
PE
3635 * xselect.c (x_get_local_selection, x_handle_property_notify):
3636 Remove vars that are set but not used.
3637
0ce7538d 3638 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3639 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3640
9ae848fc
PE
3641 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3642 Remove var that is set but not used.
0b918413
PE
3643 (scroll_bar_windows_size): Now size_t, not int.
3644 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3645 Check for overflow.
9ae848fc 3646
a5a62657
PE
3647 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3648 (map_tty_color) [!defined MSDOS]: Likewise.
3649
5c5cdd39
PE
3650 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3651
66ebf983
PE
3652 * coding.c: Remove vars that are set but not used.
3653 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3654 All callers changed.
3655 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3656 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3657 (decode_coding_charset): Remove vars that are set but not used.
3658
1be4d761
PE
3659 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3660 that is set but not used.
3661
47553fa8
PE
3662 * print.c (print_object): Remove var that is set but not used.
3663
1f7196bf 3664 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3665 The gnulib version avoids calling malloc in the usual case,
3666 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3667 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3668 * filelock.c (current_lock_owner): Likewise.
3669 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3670 * sysdep.c: Include allocator.h, careadlinkat.h.
3671 (emacs_no_realloc_allocator): New static constant.
3672 (emacs_readlink): New function.
fdb61804
PE
3673 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3674 ../lib/careadlinkat.h.
d1fdcab7 3675
f84c17c7
SM
36762011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3677
3678 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3679 first non-nil return value).
3680
ef3862ad
JD
36812011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3682
3683 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3684 if not defined (Bug#8403).
3685
376a7006
JB
36862011-04-02 Juanma Barranquero <lekktu@gmail.com>
3687
3688 * xdisp.c (display_count_lines): Remove parameter `start',
3689 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3690 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3691 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3692 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3693 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3694 and thereabouts. All callers changed.
3695 (get_per_char_metric): Remove parameter `f', unused since
3696 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3697
6ca3801d
JM
36982011-04-02 Jim Meyering <meyering@redhat.com>
3699
3700 do not dereference NULL upon failed strdup
3701 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3702 (ns_get_family): Likewise.
3703
d8e2b5ba
JB
37042011-04-02 Juanma Barranquero <lekktu@gmail.com>
3705
3706 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3707
8c74fcbd
JD
37082011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3709
3710 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3711 later (Bug#8403).
3712
7200d79c
SM
37132011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3714
03408648 3715 Add lexical binding.
7200d79c 3716
03408648
SM
3717 * window.c (Ftemp_output_buffer_show): New fun.
3718 (Fsave_window_excursion):
3719 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3720
3721 * lread.c (lisp_file_lexically_bound_p): New function.
3722 (Fload): Bind Qlexical_binding.
3723 (readevalloop): Remove `evalfun' arg.
3724 Bind Qinternal_interpreter_environment.
3725 (Feval_buffer): Bind Qlexical_binding.
3726 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3727 Mark as dynamic.
3728 (syms_of_lread): Declare `lexical-binding'.
3729
3730 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3731
3732 * keyboard.c (eval_dyn): New fun.
3733 (menu_item_eval_property): Use it.
ca105506
SM
3734
3735 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3736
03408648
SM
3737 * fns.c (concat, mapcar1): Accept byte-code-functions.
3738
3739 * eval.c (Fsetq): Handle lexical vars.
3740 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3741 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3742 (FletX, Flet): Obey lexical binding.
3743 (Fcommandp): Handle closures.
3744 (Feval): New `lexical' arg.
3745 (eval_sub): New function extracted from Feval. Use it almost
3746 everywhere where Feval was used. Look up vars in lexical env.
3747 Handle closures.
3748 (Ffunctionp): Move from subr.el.
3749 (Ffuncall): Handle closures.
3750 (apply_lambda): Remove `eval_flags'.
3751 (funcall_lambda): Handle closures and new byte-code-functions.
3752 (Fspecial_variable_p): New function.
3753 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3754 but without exporting it to Lisp.
23aba0ea 3755
23aba0ea 3756 * doc.c (Fdocumentation, store_function_docstring):
03408648 3757 * data.c (Finteractive_form): Handle closures.
23aba0ea 3758
03408648
SM
3759 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3760 interactive spec.
ba83908c 3761
04f2d78b
CB
3762 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3763 New byte-codes.
03408648
SM
3764 (exec_byte_code): New function extracted from Fbyte_code to handle new
3765 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3766
03408648 3767 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3768
03408648 3769 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3770
e2abce01
JB
37712011-03-31 Juanma Barranquero <lekktu@gmail.com>
3772
3773 * xdisp.c (redisplay_internal): Fix prototype.
3774
63696a73 37752011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3776
63696a73 3777 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3778 (try_scrolling): Use it when setting scroll_limit.
3779 Limit scrolling to 100 screen lines.
63696a73
EZ
3780 (redisplay_window): Even when falling back on "recentering",
3781 position point in the window according to scroll-conservatively,
3782 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3783
3784 (try_scrolling): When point is above the window, allow searching
3785 as far as scroll_max, or one screenful, to compute vertical
3786 distance from PT to the scroll margin position. This prevents
3787 try_scrolling from unnecessarily failing when
3788 scroll-conservatively is set to a value slightly larger than the
3789 window height. Clean up the case of PT below the margin at bottom
3790 of window: scroll_max can no longer be INT_MAX. When aggressive
3791 scrolling is in use, don't let point enter the opposite scroll
3792 margin as result of the scroll.
3793 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3794 threshold of 100 lines for never-recentering scrolling.
3795
e4cc2dfc
JB
37962011-03-31 Juanma Barranquero <lekktu@gmail.com>
3797
3798 * dispextern.h (move_it_by_lines):
3799 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3800 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3801 (message_log_check_duplicate): Remove parameters `prev_bol' and
3802 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3803 (redisplay_internal): Remove parameter `preserve_echo_area',
3804 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3805
3806 * indent.c (Fvertical_motion):
3807 * window.c (window_scroll_pixel_based, Frecenter):
3808 Don't pass `need_y_p' to `move_it_by_lines'.
3809
1c470562
SM
38102011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3811
44f230aa
SM
3812 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3813 steal a few bits to be more compact.
3814 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3815 Remove unneeded casts.
3816
1c470562
SM
3817 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3818
888adce9
ZK
38192011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3820
3821 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3822 binding" message (bug#7967).
3823
f838ed7b
PE
38242011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3825
77861b95
PE
3826 Fix more problems found by GCC 4.6.0's static checks.
3827
de6dbc14
PE
3828 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3829 Remove unused local var.
3830
f838ed7b
PE
3831 * editfns.c (Fmessage_box): Remove unused local var.
3832
792c7b2b
PE
3833 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3834 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3835 Omit unused local vars.
c499e557 3836 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3837 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3838 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3839 Omit unused local var.
3840
ba0165e1
PE
3841 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3842 Don't assume string length fits in int.
32ad8845 3843 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3844 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3845
3c59b4c9
PE
3846 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3847 instead of alloca (Bug#8344).
3848
a3eed478 3849 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3850 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3851
eb4d412d
PE
3852 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3853
1658b401
PE
3854 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3855 concerns.
3856
3857 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3858
3859 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3860
9a2c6e05
PE
3861 * keyboard.c (syms_of_keyboard): Use the same style as later
3862 in this function when indexing through an array. This also
3863 works around GCC bug 48267.
3864
03d0a109
PE
3865 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3866
44f730c8
PE
3867 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3868
fe75f926
PE
3869 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3870 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3871
ffa8c828
PE
3872 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3873 This avoids undefined behavior on integer overflow, and is a bit
3874 more convenient anyway since it is compared to a size_t variable.
3875
c5101a77
PE
3876 Variadic C functions now count arguments with size_t, not int.
3877 This avoids an unnecessary limitation on 64-bit machines, which
3878 caused (substring ...) to crash on large vectors (Bug#8344).
3879 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3880 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3881 All variadic functions and their callers changed accordingly.
c5101a77
PE
3882 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3883 * data.c (arith_driver, float_arith_driver): Likewise.
3884 * editfns.c (general_insert_function): Likewise.
3885 * eval.c (struct backtrace.nargs, interactive_p)
3886 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3887 (funcall_lambda, mark_backtrace): Likewise.
3888 * fns.c (concat): Likewise.
3889 * frame.c (x_set_frame_parameters): Likewise.
3890 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3891 0 if not found, not -1. All callers changed.
3892
dd3f25f7
PE
3893 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3894 (stack_copy_size): Now size_t, not int.
3895 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3896
461c2ab9
JB
38972011-03-28 Juanma Barranquero <lekktu@gmail.com>
3898
3899 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3900 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3901 All callers changed.
3902
3903 * lisp.h (multibyte_char_to_unibyte):
3904 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3905 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3906 * character.h (CHAR_TO_BYTE8):
3907 * cmds.c (internal_self_insert):
3908 * editfns.c (general_insert_function):
3909 * keymap.c (push_key_description):
3910 * search.c (Freplace_match):
3911 * xdisp.c (message_dolog, set_message_1): All callers changed.
3912
f6d62986
SM
39132011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3914
3915 * keyboard.c (safe_run_hook_funcall): New function.
3916 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3917 don't set the hook to nil, but remove the offending function instead.
3918 (Qcommand_hook_internal): Remove, unused.
3919 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3920 Vcommand_hook_internal.
3921
3922 * eval.c (enum run_hooks_condition): Remove.
3923 (funcall_nil, funcall_not): New functions.
3924 (run_hook_with_args): Call each function through a `funcall' argument.
3925 Remove `cond' argument, now redundant.
3926 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3927 (Frun_hook_with_args_until_failure): Adjust accordingly.
3928 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3929
1db5b1ad
JB
39302011-03-28 Juanma Barranquero <lekktu@gmail.com>
3931
3932 * dispextern.h (string_buffer_position): Remove declaration.
3933
3934 * print.c (strout): Remove parameter `multibyte', unused since
3935 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3936
3937 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3938 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3939 All callers changed.
3940
3941 * w32.c (_wsa_errlist): Use braces for struct initializers.
3942
3943 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3944 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3945 All callers changed.
3946 (string_buffer_position): Likewise. Also, make static (it's never
3947 used outside xdisp.c).
3948 (cursor_row_p): Remove parameter `w', unused since
3949 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3950 (decode_mode_spec): Remove parameter `precision', introduced during
3951 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3952 All callers changed.
3953
5ffb62aa
JD
39542011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3955
3956 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3957
461c2ab9 39582011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3959
3960 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3961 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3962 (ns_update_auto_hide_menu_bar): New functions.
3963 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3964 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3965 ns_constrain_all_frames.
3966 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3967 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3968
5c380ffb
JD
39692011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3970
3971 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3972
9af30bdf
GM
39732011-03-27 Glenn Morris <rgm@gnu.org>
3974
3975 * syssignal.h: Replace RETSIGTYPE with void.
3976 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3977 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3978 Replace SIGTYPE with void everywhere.
3979 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3980 * s/template.h (SIGTYPE): Remove commented out definition.
3981
e2abce01
JB
39822011-03-26 Eli Zaretskii <eliz@gnu.org>
3983
3984 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3985 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3986
f868cd8a
JB
39872011-03-26 Juanma Barranquero <lekktu@gmail.com>
3988
59eb0929
JB
3989 * w32.c (read_unc_volume): Use parameter `henum', instead of
3990 global variable `wget_enum_handle'.
3991
3992 * keymap.c (describe_vector): Remove parameters `indices' and
3993 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3994 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3995
f868cd8a
JB
3996 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3997
3998 * keyboard.c (timer_check): Remove parameter `do_it_now',
3999 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4000 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4001 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4002
4003 * keyboard.c (read_char):
4004 * w32menu.c (w32_menu_display_help):
4005 * xmenu.c (show_help_event, menu_help_callback):
4006 Adjust calls to `show_help_echo'.
4007
4008 * gtkutil.c (xg_maybe_add_timer):
4009 * keyboard.c (readable_events):
4010 * process.c (wait_reading_process_output):
4011 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4012
4013 * insdel.c (adjust_markers_gap_motion):
4014 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4015 (gap_left, gap_right): Don't call it.
4016
2ecf6fdb
CY
40172011-03-25 Chong Yidong <cyd@stupidchicken.com>
4018
4019 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4020 incurred during fontification.
4021
6b1f9ba4
JB
40222011-03-25 Juanma Barranquero <lekktu@gmail.com>
4023
4024 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4025 (DEFVAR_PER_BUFFER): Don't pass it.
4026
4027 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4028 (scrolling_window): Don't pass it.
4029
0f4a96b5
JB
40302011-03-25 Juanma Barranquero <lekktu@gmail.com>
4031
4032 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4033
4034 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4035 and `suffix'.
4036 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4037 of variables specific to SELinux and computation of `encoded_absname'.
4038
4039 * image.c (XPutPixel): Remove unused variable `height'.
4040
4041 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4042
4043 * unexw32.c (get_section_info): Remove unused variable `section'.
4044
4045 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4046 (system_process_attributes): Remove unused variable `sess'.
4047 (sys_read): Remove unused variable `err'.
4048
4049 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4050 (w32_wnd_proc): Remove unused variable `isdead'.
4051 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4052 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4053 (x_create_tip_frame): Remove unused variable `tem'.
4054
4055 * w32inevt.c (w32_console_read_socket):
4056 Remove unused variable `no_events'.
4057
4058 * w32term.c (x_draw_composite_glyph_string_foreground):
4059 Remove unused variable `width'.
4060
1149507c
JB
40612011-03-24 Juanma Barranquero <lekktu@gmail.com>
4062
4063 * w32term.c (x_set_glyph_string_clipping):
4064 Don't pass uninitialized region to CombineRgn.
4065
9c88f339
JB
40662011-03-23 Juanma Barranquero <lekktu@gmail.com>
4067
4068 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4069 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4070 (Fx_close_connection): Remove unused variable `i'.
4071
4072 * w32font.c (w32font_draw): Return number of glyphs.
4073 (w32font_open_internal): Remove unused variable `i'.
4074 (w32font_driver): Add missing initializer.
4075
4076 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4077 (fill_in_menu): Remove unused variable `items_added'.
4078
4079 * w32term.c (last_mouse_press_frame): Remove static global variable.
4080 (w32_clip_to_row): Remove unused variable `f'.
4081 (x_delete_terminal): Remove unused variable `i'.
4082
4083 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4084 (NOTHING): Remove unused static global variable.
4085 (uniscribe_check_otf): Remove unused variable `table'.
4086 (uniscribe_font_driver): Add missing initializers.
4087
dee091a3
JD
40882011-03-23 Julien Danjou <julien@danjou.info>
4089
4090 * term.c (Fsuspend_tty, Fresume_tty):
4091 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4092 * window.c (temp_output_buffer_show):
4093 * insdel.c (signal_before_change):
4094 * frame.c (Fhandle_switch_frame):
4095 * fileio.c (Fdo_auto_save):
4096 * emacs.c (Fkill_emacs):
4097 * editfns.c (save_excursion_restore):
4098 * cmds.c (internal_self_insert):
4099 * callint.c (Fcall_interactively):
4100 * buffer.c (Fkill_all_local_variables):
4101 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4102 Use Frun_hooks.
0f4a96b5 4103 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4104 unconditionnaly since it does the check itself.
4105
2c520ab5 41062011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4107
c9c49752
PE
4108 Fix more problems found by GCC 4.5.2's static checks.
4109
8abc3f12
PE
4110 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4111 the first time through the loop, since we know p0 < p1 then.
4112 This also avoids a gcc -Wstrict-overflow warning.
4113
a2d26660
PE
4114 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4115 leading to a memory leak, possible in functions like
4116 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4117 of objects (Bug#8318).
a2d26660 4118
916c72e9
PE
4119 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4120 that could (at least in theory) be that large.
4121
19ab8a18
PE
4122 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4123 This is less likely to overflow, and avoids undefined behavior if
4124 overflow does occur. All callers changed. Use strtoul to scan
4125 for the unsigned long integer.
b7cbbd6f
PE
4126 (pint2hrstr): Simplify and tune code slightly.
4127 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4128
f0641eff
PE
4129 * scroll.c (do_scrolling): Work around GCC bug 48228.
4130 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4131
7f650bb9
PE
4132 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4133 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4134 (validate_x_resource_name): Simplify count usage.
4135 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4136
37dd57d1
PE
4137 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4138 fail (Bug#8306).
81e56e61 4139
699979fc 4140 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4141
401bf9b4
PE
4142 * process.c (Fmake_network_process): Use socklen_t, not int,
4143 where POSIX says socklen_t is required in portable programs.
4144 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4145 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4146 (Fmake_network_process, server_accept_connection):
4147 (wait_reading_process_output, read_process_output):
4148 Likewise.
4149
b93aacde
PE
4150 * process.c: Rename or move locals to avoid shadowing.
4151 (list_processes_1, Fmake_network_process):
4152 (read_process_output_error_handler, exec_sentinel_error_handler):
4153 Rename or move locals.
4dc343ee 4154 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4155 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4156 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4157 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4158 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4159
af8a867c 4160 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4161 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4162 Include tparam.h instead, since it declares them.
af8a867c
PE
4163 * cm.h (PC): Remove extern decl; tparam.h now does this.
4164 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4165 * terminfo.c: Include tparam.h, to check interfaces.
4166 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4167 (tparam): Adjust signature to match interface in tparam.h;
4168 this removes some undefined behavior. Check that outstring and len
4169 are zero, which they always are with Emacs.
4170 * tparam.h (PC, BC, UP): New extern decls.
4171
0248044d 4172 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4173 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4174
8ff096c1 4175 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4176 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4177 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4178 (ftfont_list): Remove unused local.
49eaafba
PE
4179 (get_adstyle_property, ftfont_pattern_entity):
4180 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4181 Rename locals to avoid shadowing.
8ff096c1 4182
e2be39f6
PE
4183 * xfont.c (xfont_list_family): Mark var as initialized.
4184
c9735e30
PE
4185 * xml.c (make_dom): Now static.
4186
8f5201ae
PE
4187 * composite.c (composition_compute_stop_pos): Rename local to
4188 avoid shadowing.
b246f932
PE
4189 (composition_reseat_it): Remove unused locals.
4190 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4191 (composition_update_it): Mark var as initialized.
11b61122
PE
4192 (find_automatic_composition): Mark vars as initialized,
4193 with a FIXME (Bug#8290).
8f5201ae 4194
760fbc2c
PE
4195 character.h: Rename locals to avoid shadowing.
4196 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4197 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4198 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4199 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4200 to avoid shadowing.
4201
ff08eb85
PE
4202 * textprop.c (property_change_between_p): Remove; unused.
4203
fc7bf025
PE
4204 * intervals.c (interval_start_pos): Now static.
4205
235d7abc
PE
4206 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4207
44f230aa
SM
4208 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4209 Rename locals to avoid shadowing.
3e7d6594 4210
50060332
PE
4211 * sound.c (wav_play, au_play, Fplay_sound_internal):
4212 Fix pointer signedness.
d01f234b 4213 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4214 (wav_play): Initialize a variable to 0, to prevent undefined
4215 behavior (Bug#8278).
50060332 4216
c4fc4e30
PE
4217 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4218
918436ed
PE
4219 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4220
c939f91b
PE
4221 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4222 clobbering (Bug#8298).
b9c7f648
PE
4223 * sysdep.c (sys_subshell): Likewise.
4224 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4225
6bd8c144
PE
4226 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4227 This should get cleaned up, so that child_setup has the
4228 same signature on all platforms.
4229
7710357c 4230 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4231 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4232
c59da222
CY
42332011-03-22 Chong Yidong <cyd@stupidchicken.com>
4234
4235 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4236 not to be necessary, and produces flickering.
4237
66b87493
GM
42382011-03-20 Glenn Morris <rgm@gnu.org>
4239
4240 * config.in: Remove file.
4241
45b6f6d5
JB
42422011-03-20 Juanma Barranquero <lekktu@gmail.com>
4243
4244 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4245 are now in src/globals.h.
4246 (syms_of_minibuf): Remove spurious & from previous change.
4247
3ec03f7e
LL
42482011-03-20 Leo <sdl.web@gmail.com>
4249
4250 * minibuf.c (completing-read-function): New variable.
4251 (completing-read-default): Rename from completing-read.
4252 (completing-read): Call completing-read-function.
4253
b14e3e21
CY
42542011-03-19 Juanma Barranquero <lekktu@gmail.com>
4255
4256 * xfaces.c (Fx_load_color_file):
4257 Read color file from absolute filename (bug#8250).
4258
f2b726e6
JB
42592011-03-19 Juanma Barranquero <lekktu@gmail.com>
4260
4261 * makefile.w32-in: Update dependencies.
4262
09f6ff02
EZ
42632011-03-17 Eli Zaretskii <eliz@gnu.org>
4264
4265 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4266
29a6015a
PE
42672011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4268
a3a6c54e
PE
4269 Fix more problems found by GCC 4.5.2's static checks.
4270
b766f867
PE
4271 * process.c (make_serial_process_unwind, send_process_trap):
4272 (sigchld_handler): Now static.
4273
be02381c
PE
4274 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4275 That way, the code declares only the vars that it needs.
4276 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4277 * s/cygwin.h (PTY_ITERATION): Likewise.
4278 * s/darwin.h (PTY_ITERATION): Likewise.
4279 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4280
57048744
PE
4281 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4282 * process.c (allocate_pty): Don't declare stb unless it's needed.
4283
7914961c 4284 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4285 (CONSTANTLIM): Remove; unused.
4286 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4287 Define only if needed.
7914961c 4288
b3967b18
PE
4289 * unexelf.c (unexec): Name an expression,
4290 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4291 Use a different way to cause a compilation error if anyone uses
4292 n rather than nn, a way that does not involve shadowing.
73366a00 4293 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4294
29a6015a
PE
4295 * deps.mk (unexalpha.o): Remove; unused.
4296
43cfc33e 4297 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4298 * unexec.h: New file.
ce701a33
PE
4299 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4300 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4301 Depend on unexec.h.
4302 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4303 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4304 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4305 Change as necessary to match prototype in unexec.h.
ce701a33 4306
01f44d5a
PE
4307 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4308 shadowing.
4f63c6bb 4309 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4310
a6670b0b
PE
4311 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4312 Rename locals to avoid shadowing.
4313
cef2010d 4314 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4315 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4316
d4d7173a
PE
4317 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4318
f08b802a
PE
4319 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4320 warning when compiling print.c.
4321
3ddb0639
PE
4322 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4323 instead of using an uninitialized var.
5ad03b97 4324 (font_sort_entities): Mark var as initialized.
3ddb0639 4325
170a2692
PE
4326 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4327
e663c700
PE
4328 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4329 pointers to constants.
89bc529a 4330 (font_parse_fcname): Remove unused vars.
7b81e2d0 4331 (font_delete_unmatched): Now static.
ea838e10 4332 (font_get_spec): Remove; unused.
13a547c6
PE
4333 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4334 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4335 Rename or move locals to avoid shadowing.
e663c700 4336
2a80c887 4337 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4338 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4339
1384fa33 4340 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4341 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4342
8b2c52e9
PE
4343 * alloc.c (mark_backtrace): Move decl from here ...
4344 * lisp.h: ... to here, so that it can be checked.
4345
475545b5 4346 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4347 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4348 (lisp_indirect_variable): Name an expression,
4349 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4350 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4351
b1349114 4352 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4353 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4354 Use const pointer when appropriate.
b1349114 4355
a2928364
PE
4356 * lisp.h (get_system_name, get_operating_system_release):
4357 Move decls here, to check interfaces.
4358 * process.c (get_operating_system_release): Move decl to lisp.h.
4359 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4360 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4361 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4362 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4363 (Fformat_time_string, Fencode_time, Finsert_char):
4364 (Ftranslate_region_internal, Fformat):
4365 Rename or remove local vars to avoid shadowing.
9710023e 4366 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4367
a415e694
PE
4368 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4369 avoid shadowing.
4370
8ef4622d
PE
4371 * lisp.h (eassert): Check that the argument compiles, even if
4372 ENABLE_CHECKING is not defined.
4373
946f9a5b
PE
4374 * data.c (Findirect_variable): Name an expression, to avoid
4375 gcc -Wbad-function-cast warning.
112396d6 4376 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4377 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4378 (Fmake_variable_buffer_local, Fmake_local_variable):
4379 Mark variables as initialized.
52746918 4380 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4381
e5aab7e7 4382 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4383 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4384 Rename locals to avoid shadowing.
dff45157
PE
4385 (mark_stack): Move local variables into the #ifdef region where
4386 they're used.
7bc26fdb
PE
4387 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4388 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4389 needed otherwise.
4390 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4391 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4392 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4393
e5aab7e7
PE
4394 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4395 avoids undefined behavior in theory.
4396
4da60324
PE
4397 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4398
88043301
PE
4399 Use functions, not macros, for up- and down-casing (Bug#8254).
4400 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4401 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4402 to use the following functions instead of these macros.
4403 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4404 EMACS_INT, since callers assume the returned value fits in int.
4405 (upcase1): Likewise, for UPCASE_TABLE.
4406 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4407 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4408 the race-condition problem in the old DOWNCASE.
88043301 4409
19ed5445
PE
4410 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4411 Rename locals to avoid shadowing.
4412 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4413 (regex_compile, re_search_2, re_match_2_internal):
4414 Remove unused local vars.
952db0d7
PE
4415 (FREE_VAR): Rewrite so as not to use empty "else",
4416 which gcc can warn about.
da053e48 4417 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4418 (RETALLOC_IF): Define only if needed.
4419 (WORDCHAR_P): Likewise. This one is never needed, but is used
4420 only in a comment talking about a compiler bug, so put inside
4421 the #if 0 of that comment.
4422 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4423 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4424 Remove; unused.
19ed5445 4425
1f3561e4 4426 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4427 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4428 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4429
ded6f8f7
PE
4430 * search.c (simple_search): Remove unused var.
4431
dbd37a95
PE
4432 * dired.c (compile_pattern): Move decl from here ...
4433 * lisp.h: ... to here, so that it can be checked.
4434 (struct re_registers): New forward decl.
4435
7e47afad
PE
4436 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4437
85f24f61
PE
4438 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4439 All uses changed.
4440 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4441 Rename locals to avoid shadowing.
5671df8f 4442 (Fvertical_motion): Mark locals as initialized.
85f24f61 4443
181aa2be 4444 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4445 (casify_region): Mark local as initialized.
181aa2be 4446
930d429c
PE
4447 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4448
7082eac6
PE
4449 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4450 New macros, so that the caller can use some names other than
4451 gcpro1, gcpro2, etc.
4452 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4453 of the new macros.
4454 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4455 argument, for consistency with GCPRO2_VAR, etc: it is now the
4456 prefix of the variable, not the variable itself. All uses
4457 changed.
38b2c076
PE
4458 * dired.c (directory_files_internal, file_name_completion):
4459 Rename locals to avoid shadowing.
4460
15206ed9
PE
4461 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4462 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4463 dired.c's scmp function, had undefined behavior.
4464 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4465 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4466 * buffer.h: ... to here, because these macros use current_buffer,
4467 and the new implementation with inline functions needs to have
4468 current_buffer in scope now, rather than later when the macros
4469 are used.
4470 (downcase, upcase1): New static inline functions.
4471 (DOWNCASE, UPCASE1): Reimplement using these functions.
4472 This avoids undefined behavior in expressions like
4473 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4474 from race conditions in accessing the global variables
4475 case_temp1 and case_temp2.
4476 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4477 * lisp.h (case_temp1, case_temp2): Remove their decls.
4478 * character.h (ASCII_CHAR_P): Move from here ...
4479 * lisp.h: ... to here, so that the inline functions mentioned
4480 above can use them.
4481
4a6bea26
PE
4482 * dired.c (directory_files_internal_unwind): Now static.
4483
f14b7e14
PE
4484 * fileio.c (file_name_as_directory, directory_file_name):
4485 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4486 Now static.
2893f146
PE
4487 (file_name_as_directory): Use const pointers when appropriate.
4488 (Fexpand_file_name): Likewise. In particular, newdir might
4489 point at constant storage, so make it a const pointer.
fd4ead52 4490 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4491 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4492 signedness issues.
f839df0c
PE
4493 (Fset_file_times, Finsert_file_contents, auto_save_error):
4494 Rename locals to avoid shadowing.
f14b7e14 4495
5716756e 4496 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4497 (Ftry_completion, Fall_completions): Rename or remove locals
4498 to avoid shadowing.
5716756e 4499
b4c3046a
PE
4500 * marker.c (bytepos_to_charpos): Remove; unused.
4501
b45db522
PE
4502 * lisp.h (verify_bytepos, count_markers): New decls,
4503 so that gcc does not warn that these functions aren't declared.
4504
85876d07
PE
4505 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4506 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4507 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4508 (copy_text): Remove unused local var.
85876d07 4509
03d78a21 4510 * filelock.c (within_one_second): Now static.
b3dd38ab 4511 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4512
5df8f01b
PE
4513 * buffer.c (fix_overlays_before): Mark locals as initialized.
4514 (fix_start_end_in_overlays): Likewise. This function should be
4515 simplified by using pointers-to-pointers, but that's a different
4516 matter.
b1d876f1 4517 (switch_to_buffer_1): Now static.
8f54f30a
PE
4518 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4519 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4520
a70072c9 4521 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4522 Fix pointer signedness issue.
edced198
PE
4523 (sys_subshell): Mark local as volatile if checking for lint,
4524 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4525 (MAXPATHLEN): Define only if needed.
a70072c9 4526
a0977c44
PE
4527 * process.c (serial_open, serial_configure): Move decls from here ...
4528 * systty.h: ... to here, so that they can be checked.
4529
a884fdcc
PE
4530 * fns.c (get_random, seed_random): Move extern decls from here ...
4531 * lisp.h: ... to here, so that they can be checked.
4532
604efe86 4533 * sysdep.c (reset_io): Now static.
b8950c94 4534 (wait_for_termination_signal): Remove; unused.
604efe86 4535
38fc62d9
PE
4536 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4537 (copy_keymap_item, append_key, push_text_char_description):
4538 Now static.
1004a21a 4539 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4540 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4541 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4542 (describe_map_tree):
4543 Rename locals to avoid shadowing.
38fc62d9 4544
2f2650da
PE
4545 * keyboard.c: Declare functions static if they are not used elsewhere.
4546 (echo_char, echo_dash, cmd_error, top_level_2):
4547 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4548 (read_char, kbd_buffer_get_event, make_lispy_position):
4549 (make_lispy_event, make_lispy_movement, apply_modifiers):
4550 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4551 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4552 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4553 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4554 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4555
a053e86c 4556 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4557 (mark_kboards): Move decl here ...
4558 * alloc.c (mark_kboards): ... from here.
a053e86c 4559
4752793e
PE
4560 * lisp.h (force_auto_save_soon): New decl.
4561
74f10ca7 4562 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4563 (DEFINE_DUMMY_FUNCTION): New macro.
4564 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4565 Use it.
c03cd23f
PE
4566 (main): Add casts to avoid warnings
4567 if GCC considers string literals to be constants.
74f10ca7 4568
022e70d4
PE
4569 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4570
59d6fe83
PE
4571 * dbusbind.c: Pointer signedness fixes.
4572 (xd_signature, xd_append_arg, xd_initialize):
4573 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4574 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4575 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4576 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4577
78320123
PE
4578 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4579 if GCC considers string literals to be constants.
49cebcca 4580 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4581
35ac2a97
SM
45822011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4583
fb103ca9
SM
4584 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4585 (print_preprocess, print_object): New macro to fix last change.
4586
35ac2a97
SM
4587 * print.c (print_preprocess): Don't forget font objects.
4588
62973b41
JB
45892011-03-16 Juanma Barranquero <lekktu@gmail.com>
4590
4591 * emacs.c (USAGE3): Doc fixes.
4592
0e48bb22
AS
45932011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4594
4595 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4596 structure.
4597
7684e57b
JB
45982011-03-14 Juanma Barranquero <lekktu@gmail.com>
4599
4600 * lisp.h (VWindow_system, Qfile_name_history):
4601 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4602 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4603 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4604
4605 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4606 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4607
4608 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4609 * w32console.c (detect_input_pending, read_input_pending)
4610 (encode_terminal_code):
4611 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4612 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4613 (w32_system_caret_y, Qfile_name_history):
4614 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4615 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4616 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4617 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4618 * w32proc.c (Qlocal, report_file_error):
4619 * w32term.c (Vwindow_system, updating_frame):
4620 * w32uniscribe.c (initialized, uniscribe_font_driver):
4621 Remove unneeded extern declarations.
4622
2aa46d6c
CY
46232011-03-14 Chong Yidong <cyd@stupidchicken.com>
4624
c96bbc66 4625 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4626
cffc6f3b
CY
46272011-03-13 Chong Yidong <cyd@stupidchicken.com>
4628
4629 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4630 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4631 These macros can no longer be used for assignment.
4632
44f230aa
SM
4633 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4634 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4635 (record_buffer_markers, fetch_buffer_markers): New functions for
4636 recording and fetching special buffer markers.
4637 (set_buffer_internal_1, set_buffer_temp): Use them.
4638
4639 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4640
4641 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4642
4643 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4644 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4645
4646 * xdisp.c (hscroll_window_tree):
4647 (reconsider_clip_changes): Use PT instead of BUF_PT.
4648
d251f04b
EZ
46492011-03-13 Eli Zaretskii <eliz@gnu.org>
4650
4651 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4652 $(EMACS_ROOT)/lib/intprops.h.
4653
f0c77cd1
PE
46542011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4655
3eca4629
PE
4656 Fix more problems found by GCC 4.5.2's static checks.
4657
7c86ee98
PE
4658 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4659 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4660 (xg_free_frame_widgets): Make it clear that a local variable is
4661 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4662 (gdk_window_get_screen): Make it clear that this macro is needed
4663 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4664 (int_gtk_range_get_value): New function, which avoids a diagnostic
4665 from gcc -Wbad-function-cast.
4666 (xg_set_toolkit_scroll_bar_thumb): Use it.
4667 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4668 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4669 (get_utf8_string, xg_get_file_with_chooser):
4670 Rename locals to avoid shadowing.
4671 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4672
41729b81
PE
4673 * xgselect.c (xg_select): Remove unused var.
4674
f0c77cd1
PE
4675 * image.c (four_corners_best): Mark locals as initialized.
4676 (gif_load): Initialize transparent_p to zero (Bug#8238).
4677 Mark another local as initialized.
ec6cf4c6 4678 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4679
ce0ad53d 4680 * image.c (clear_image_cache): Now static.
d5d5a617 4681 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4682 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4683 (x_edge_detection): Remove unnecessary cast that
4684 gcc -Wbad-function-cast diagnoses.
2037898d 4685 (gif_load): Fix pointer signedness.
6ae141d6
PE
4686 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4687 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4688
33383987 46892011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4690
d32df629
PE
4691 Improve quality of tests for time stamp overflow.
4692 For example, without this patch (encode-time 0 0 0 1 1
4693 1152921504606846976) returns the obviously-bogus value (-948597
4694 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4695 reports time overflow. See
4696 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4697 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4698 * editfns.c: Include limits.h and intprops.h.
4699 (TIME_T_MIN, TIME_T_MAX): New macros.
4700 (time_overflow): Move earlier, to before first use.
4701 (hi_time, lo_time): New functions, for an accurate test for
4702 out-of-range times.
4703 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4704 (Fget_internal_run_time): Don't assume time_t fits in int.
4705 (make_time): Use list2 instead of Fcons twice.
4706 (Fdecode_time): More accurate test for out-of-range times.
4707 (check_tm_member): New function.
4708 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4709 (lisp_time_argument): Don't rely on undefined left-shift and
4710 right-shift behavior when checking for time stamp overflow.
8be6f318 4711
fe31d94c
PE
4712 * editfns.c (time_overflow): New function, refactoring common code.
4713 (Fformat_time_string, Fdecode_time, Fencode_time):
4714 (Fcurrent_time_string): Use it.
4715
8be6f318
PE
4716 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4717 * dired.c (make_time): Move to ...
4718 * editfns.c (make_time): ... here.
4719 * systime.h: Note the move.
4720
09d9db2c 47212011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4722
126bc0dc
YM
4723 * fringe.c (update_window_fringes): Remove unused variables.
4724
c47cbdfd
YM
4725 * unexmacosx.c (copy_data_segment): Also copy __got section.
4726 (Bug#8223)
4727
7ac80be9
EZ
47282011-03-12 Eli Zaretskii <eliz@gnu.org>
4729
c96bbc66 4730 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4731 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4732 Constify `char *' arguments and their references according to
4733 prototypes in tparam.h.
4734
ecb0f94d 4735 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4736
7ac80be9
EZ
4737 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4738 Adapt all references accordingly.
4739
4740 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4741
ef1fd07e
TT
47422011-03-11 Tom Tromey <tromey@redhat.com>
4743
4744 * buffer.c (syms_of_buffer): Remove obsolete comment.
4745
7ef4b50c
EZ
47462011-03-11 Eli Zaretskii <eliz@gnu.org>
4747
4748 * termhooks.h (encode_terminal_code): Declare prototype.
4749
4750 * msdos.c (encode_terminal_code): Don't declare prototype.
4751
4752 * term.c (encode_terminal_code): Now external again, used by
4753 w32console.c and msdos.c.
4754
44f230aa
SM
4755 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4756 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4757
4b1ec863 47582011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4759
1714f52b 4760 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4761
4b1ec863
PE
4762 * fringe.c (update_window_fringes): Mark locals as initialized
4763 (Bug#8227).
4764 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4765
524c7aa6
PE
4766 * alloc.c (mark_fringe_data): Move decl from here ...
4767 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4768 to check its interface.
4769 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4770
a5c0af81 4771 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4772 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4773 (fontset_font): Mark local as initialized.
a9a06e0b 4774 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4775
b4716021
PE
4776 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4777
811e9bac 4778 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4779 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4780 (x_own_selection, Fx_disown_selection_internal): Rename locals
4781 to avoid shadowing.
4782 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4783
7e3ab302
PE
4784 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4785 so that the caller can use some name other than gcpro1.
4786 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4787 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4788 (Fx_backspace_delete_keys_p):
4789 Use them to avoid shadowing, and rename vars to avoid shadowing.
4790 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4791 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4792 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4793 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4794 Remove unused locals.
7e3ab302
PE
4795 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4796 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4797 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4798 macros.
f78faa98 4799
e2b13473
PE
4800 * xterm.h (x_mouse_leave): New decl.
4801
77f23912
PE
4802 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4803 Remove unused functions.
cdf4ba58
PE
4804 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4805 (x_calc_absolute_position): Now static.
7411c686 4806 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4807 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4808 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4809 unless they are used.
38d0b34a
PE
4810 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4811 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4812 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4813 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4814 (x_error_catcher, x_connection_closed, x_error_handler):
4815 (x_error_quitter, xembed_send_message, x_iconify_frame):
4816 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4817 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4818 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4819
44f230aa
SM
4820 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4821 Rename or move locals to avoid shadowing.
6b463e58 4822 (tty_defined_color, merge_face_heights): Now static.
5967d051 4823 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4824 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4825 does not deduce is never used uninitialized.
73719eba
PE
4826 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4827 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4828
426994c3 4829 * terminal.c (store_terminal_param): Now static.
5489860b 4830
032f1620 4831 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4832 (set_frame_menubar): Remove unused local.
d4323972 4833 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4834 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4835 since they might point to immutable storage.
281585b0
PE
4836 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4837 since it's unused otherwise.
032f1620 4838
367c19e5 4839 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4840 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4841 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4842 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4843 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4844 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4845 does not deduce are never used uninitialized.
70739cbe 4846
07b48fa9
PE
4847 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4848
8868a238 4849 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4850 * window.c (window_loop, size_window):
4851 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4852
7e5cf297 4853 * window.c (display_buffer): Now static.
d6550a9f
PE
4854 (size_window): Mark variables that gcc -Wuninitialized
4855 does not deduce are never used uninitialized.
a586633d
PE
4856 * window.h (check_all_windows): New decl, to forestall
4857 gcc -Wmissing-prototypes diagnostic.
5b555da1 4858 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4859
f6095868
PE
4860 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4861 shadowing.
4862 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4863 Include <limits.h>.
4864 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4865 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4866 (load_charset_map): Mark variables that gcc -Wuninitialized
4867 does not deduce are never used uninitialized.
53df7c11 4868 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4869
f38b440c
PE
4870 * coding.c (coding_set_source, coding_set_destination):
4871 Use "else { /* comment */ }" rather than "else /* comment */;"
4872 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4873 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4874 a block, when the outer 'i' will do.
4875 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4876 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4877 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4878 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4879 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4880 Rename locals to avoid shadowing.
4881 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4882 * coding.c (emacs_mule_char, encode_invocation_designation):
4883 Now static, since they're not used elsewhere.
413bb2db 4884 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4885 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4886 (decode_coding_emacs_mule): Mark variables that gcc
4887 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4888 (detect_coding_iso_2022): Initialize a local variable that might
4889 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4890 this initialization is needed. (Bug#8211)
5f58e762
PE
4891 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4892 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4893 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4894 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4895 Remove unused macros.
f38b440c 4896
232b38b9 4897 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4898 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4899 * character.c (string_count_byte8): Likewise.
232b38b9 4900
fb90da1b
PE
4901 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4902 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4903
fb93dbc2
PE
4904 * chartab.c (copy_sub_char_table): Now static, since it's not used
4905 elsewhere.
5c156ace
PE
4906 (sub_char_table_ref_and_range, char_table_ref_and_range):
4907 Rename locals to avoid shadowing.
bbcd0949 4908 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4909
7d3b3862 4910 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4911 (BIDI_BOB): Remove unused macro.
7d3b3862 4912
6be7d3da
PE
4913 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4914 deduce are never used uninitialized.
c2ed9c8b 4915 * term.c (encode_terminal_code): Likewise.
6be7d3da 4916
75f8807f 4917 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4918
50938595
PE
4919 * tparam.h: New file.
4920 * term.c, tparam.h: Include it.
4921 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4922 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4923 Move these decls to tparam.h, and make them agree with what
4924 is actually in tparam.c. The previous trick of using incompatible
4925 decls in different modules does not conform to the C standard.
4926 All callers of tparam changed to use tparam's actual API.
4927 * tparam.c (tparam1, tparam, tgoto):
4928 Use const pointers where appropriate.
4929
fbceeba2
PE
4930 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4931 * cm.h (struct cm): Likewise.
4932 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4933 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4934 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4935 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4936 (turn_on_face, init_tty): Likewise.
4937 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4938
7f3f1250
PE
4939 * term.c (term_mouse_position): Rename local to avoid shadowing.
4940
e6ca6543
PE
4941 * alloc.c (mark_ttys): Move decl from here ...
4942 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4943
c40f8d15
AS
49442011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4945
4946 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4947
cfe0661d
JB
49482011-03-09 Juanma Barranquero <lekktu@gmail.com>
4949
4950 * search.c (compile_pattern_1): Remove argument regp, unused since
4951 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4952 (compile_pattern): Don't pass it.
4953
0afb4571
J
49542011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4955
4956 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4957 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4958 for ! HAVE_GTK3.
4959 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4960
4961 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4962
4963 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4964 gdk_window_get_screen, gdk_window_get_geometry,
4965 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4966 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4967 (xg_get_pixbuf_from_pixmap): New function.
4968 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4969 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4970 Call xg_get_pixbuf_from_pixmap instead of
4971 gdk_pixbuf_get_from_drawable.
4972 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4973 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4974 (xg_check_special_colors): Use GtkStyleContext and its functions
4975 for HAVE_GTK3.
4976 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4977 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4978 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4979 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4980 Call gtk_widget_get_preferred_size.
0afb4571
J
4981 (xg_frame_resized): gdk_window_get_geometry only takes 5
4982 parameters.
44f230aa
SM
4983 (xg_win_to_widget, xg_event_is_for_menubar):
4984 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4985 (xg_set_widget_bg): New function.
4986 (delete_cb): New function.
895009e1 4987 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4988 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4989 (xg_set_background_color): Call xg_set_widget_bg.
4990 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4991 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4992 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4993 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4994 if ! HAVE_GTK3.
4995 (update_frame_tool_bar): Call gtk_widget_hide.
4996 (xg_initialize): Use GDK_KEY_g.
4997
4998 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4999 if ! HAVE_GTK3
5000 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5001
5002 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5003 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5004 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5005
1c2cc4ef
JB
50062011-03-08 Juanma Barranquero <lekktu@gmail.com>
5007
5008 * w32xfns.c (select_palette): Check success of RealizePalette against
5009 GDI_ERROR, not zero.
5010
33383987 5011See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5012
5013;; Local Variables:
5014;; coding: utf-8
aac0c6e3
MR
5015;; End:
5016
33383987 5017 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5018
5019 This file is part of GNU Emacs.
5020
5021 GNU Emacs is free software: you can redistribute it and/or modify
5022 it under the terms of the GNU General Public License as published by
5023 the Free Software Foundation, either version 3 of the License, or
5024 (at your option) any later version.
5025
5026 GNU Emacs is distributed in the hope that it will be useful,
5027 but WITHOUT ANY WARRANTY; without even the implied warranty of
5028 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5029 GNU General Public License for more details.
5030
5031 You should have received a copy of the GNU General Public License
5032 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.