shr.el (shr-table-horizontal-line): Use "?\s" instead of "? " to avoid later breakage.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b12cd789
EZ
12011-11-22 Eli Zaretskii <eliz@gnu.org>
2
3 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4 and header-lines, as they don't have one computed for them.
5 (Bug#10098)
6
7 * .gdbinit (prow): Make displayed values more self-explaining.
8 Add row's hash code.
9
261b6fd4
LMI
102011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
11
12 * process.c (wait_reading_process_output): Fix asynchrounous
13 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 14 (wait_reading_process_output): Add comment and URL.
261b6fd4 15
e7cfd277
JD
162011-11-21 Jan Djärv <jan.h.d@swipnet.se>
17
18 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
19
a9b9b7f5
CY
202011-11-21 Chong Yidong <cyd@gnu.org>
21
22 * window.c (Fnext_window, Fprevious_window): Doc fix.
23
b0d15b4f
SM
242011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
25
26 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
27
fe7a3057
JB
282011-11-20 Juanma Barranquero <lekktu@gmail.com>
29
30 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
31
d2999b1a
MR
322011-11-20 Martin Rudalics <rudalics@gmx.at>
33
34 * window.c (Fset_window_combination_limit): Rename argument
35 STATUS to LIMIT.
36 (Vwindow_combination_limit): Remove "status" from doc-string.
37
d5ff9cd0
AS
382011-11-20 Andreas Schwab <schwab@linux-m68k.org>
39
40 * m/ibms390.h: Remove.
41 * m/ibms390x.h: Don't include "ibms390.h".
42
a5bb9bd3
SM
432011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
44
45 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
46 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
47
cd1181db
JB
482011-11-20 Juanma Barranquero <lekktu@gmail.com>
49
50 * casetab.c (Fset_case_table):
51 * charset.c (Fcharset_after): Fix typos.
52
615a3b8d 532011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 54
17e845af
PE
55 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
56 Otherwise, valgrind does not work on some platforms.
57 Problem reported by Andreas Schwab in
6a0bf43d
PE
58 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
59 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
60 is set, removing the need for VIRT_ADDRESS_VARIES.
61 (PURE_P): Use a more-efficient implementation that needs just one
62 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
63 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
64 to 4 (xorl, subq, cmpq, setbe).
65 * alloc.c (pure): Always extern now, since that's the
66 VIRT_ADDR_VARIES behavior.
67 (PURE_POINTER_P): Use a single comparison, not two, for
68 consistency with the new puresize.h.
69 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
70 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
71 Remove VIRT_ADDR_VARIES no longer needed.
72
f8fe6f96
EZ
732011-11-19 Eli Zaretskii <eliz@gnu.org>
74
75 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
76 (erase_phys_cursor, update_window_cursor, show_mouse_face)
77 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
78 behave as if the cursor position were at the window margin.
79
80 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
81 and the cursor position is out of bounds, behave as if the cursor
82 position were at the window margin. (Bug#10075)
83
df05a53c
CY
842011-11-18 Chong Yidong <cyd@gnu.org>
85
86 * window.c (Fwindow_combination_limit): Make first argument
87 non-optional, since it is meaningless for live windows like the
88 selected window.
89
2071918e
DA
902011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
91
92 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
93
b50a28de
SM
942011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
95
96 * intervals.c: Fix grafting over the whole buffer (bug#10071).
97 (graft_intervals_into_buffer): Simplify.
98
015137db
EZ
992011-11-18 Eli Zaretskii <eliz@gnu.org>
100
101 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
102 hash values of the two rows.
103 (copy_row_except_pointers): Preserve the used[] arrays and the
104 hash values of the two rows. (Bug#10035)
68c95424 105 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
106
107 * xdisp.c (row_hash): New function, body extracted from
108 compute_line_metrics.
109 (compute_line_metrics): Call row_hash, instead of computing the
110 hash code inline.
111
112 * dispnew.c (verify_row_hash): Call row_hash for computing the
113 hash code of a row, instead of duplicating code from xdisp.c.
114
115 * dispextern.h (row_hash): Add prototype.
116
a2addb04
TH
1172011-11-18 Tassilo Horn <tassilo@member.fsf.org>
118
119 * frame.c (delete_frame): Don't delete the terminal when the last
120 X frame is closed if emacs is built with GTK toolkit.
121
df85d315
JB
1222011-11-17 Juanma Barranquero <lekktu@gmail.com>
123
124 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
125
a0c2d0ae
MR
1262011-11-17 Martin Rudalics <rudalics@gmx.at>
127
128 * window.c (Vwindow_splits): Rename to
129 Vwindow_combination_resize. Suggested by Juri Linkov.
130 (Fsplit_window_internal): Use Vwindow_combination_resize instead
131 of Vwindow_splits.
132
58179cce
JB
1332011-11-16 Juanma Barranquero <lekktu@gmail.com>
134
7877f373
JB
135 * nsfns.m (Fns_font_name):
136 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 137
b6f67890
MR
1382011-11-16 Martin Rudalics <rudalics@gmx.at>
139
140 * window.h (window): Rename slot "nest" to "combination_limit".
141 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
142 (Fset_window_nest): Rename to Fset_window_combination_limit.
143 (Vwindow_nest): Rename to Vwindow_combination_limit.
144 (recombine_windows, make_parent_window, make_window)
145 (Fsplit_window_internal, saved_window)
146 (Fset_window_configuration, save_window_save): Rename all
147 occurrences of window_nest to window_combination_limit.
148
c7015153
JB
1492011-11-15 Juanma Barranquero <lekktu@gmail.com>
150
151 * image.c (imagemagick_load_image): Fix typo.
152
322ad6ec
EZ
1532011-11-14 Eli Zaretskii <eliz@gnu.org>
154
155 * xdisp.c (display_line): Move the call to
156 highlight_trailing_whitespace before the call to
157 compute_line_metrics, since the latter needs to see the final
158 faces of all the glyphs to compute ROW's hash value. Fixes
159 assertion violations in row_equal_p. (Bug#10035)
160
f067b8ec
JB
1612011-11-14 Juanma Barranquero <lekktu@gmail.com>
162
163 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
164 just return (bug#10044).
165
1e5b2111
EZ
1662011-11-12 Eli Zaretskii <eliz@gnu.org>
167
7ef3cbd5
EZ
168 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
169 with user-defined heap size. Bump the default size of the temacs
170 heap to 27MB, to avoid memory warning when running temacs.
171 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
172
1e5b2111
EZ
173 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
174 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
175 (verify_row_hash) [XASSERTS]: New function.
176 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
177 that the hash value of glyph rows is correct.
1e5b2111 178
89d61221
MR
1792011-11-12 Martin Rudalics <rudalics@gmx.at>
180
181 * window.h (window): Remove splits slot.
182 * window.c (Fwindow_splits, Fset_window_splits): Remove.
183 (Fdelete_other_windows_internal, make_parent_window)
184 (make_window, Fsplit_window_internal, Fdelete_window_internal)
185 (Fset_window_configuration, save_window_save): Don't deal with
186 split status of windows.
187 (saved_window): Remove splits slot.
188 (Vwindow_splits): Rewrite doc-string.
189
97f18cc8
JD
1902011-11-11 Jan Djärv <jan.h.d@swipnet.se>
191
192 * xfns.c (unwind_create_frame):
193 * nsfns.m (unwind_create_frame):
194 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
195 Vframe_list (Bug#9999).
196
22a648b4
DA
1972011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
198
0b381c7e 199 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 200
659afede
KH
2012011-11-11 Kenichi Handa <handa@m17n.org>
202
203 * callproc.c (Fcall_process): Set the member dst_multibyte of
204 process_coding.
205
9ac0394b
KH
2062011-11-11 Johan Bockgård <bojohan@gnu.org>
207
208 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
209 avoid a crash (bug#9496).
210
2fbdc249
CY
2112011-11-09 Chong Yidong <cyd@gnu.org>
212
213 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
214 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
215
ac6b1f81
PE
2162011-11-08 Paul Eggert <eggert@cs.ucla.edu>
217
218 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
219
09db192c
PE
2202011-11-08 Paul Eggert <eggert@cs.ucla.edu>
221
222 Avoid some portability problems by eschewing 'extern inline' functions.
223 The trivial performance wins aren't worth the portability hassles; see
224 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
225 et seq.
226 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
227 (window_box_width, window_box_left, window_box_left_offset)
228 (window_box_right, window_box_right_offset): Undo previous change,
229 by removing the "extern"s.
230 * intervals.c (adjust_intervals_for_insertion)
231 (adjust_intervals_for_deletion): Undo previous change,
232 making these static again.
233 (offset_intervals, temp_set_point_both, temp_set_point)
234 (copy_intervals_to_string): No longer inline.
235 * xdisp.c (window_text_bottom_y, window_box_width)
236 (window_box_height, window_box_left_offset)
237 (window_box_right_offset, window_box_left, window_box_right)
238 (window_box): No longer inline.
239
105216ed
CY
2402011-11-08 Chong Yidong <cyd@gnu.org>
241
242 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
243 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
244 an error if not a live window.
245 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
246 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
247
ae9e237f
JB
2482011-11-07 Juanma Barranquero <lekktu@gmail.com>
249
250 * lisp.h (syms_of_abbrev): Remove declaration.
251 Reported by CHENG Gao <chenggao@royau.me>.
252
c7aa8333
EZ
2532011-11-07 Eli Zaretskii <eliz@gnu.org>
254
255 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
256 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
257 of temacs in GUI mode.
258
be7f5545
MR
2592011-11-07 Martin Rudalics <rudalics@gmx.at>
260
261 * window.h: Declare delete_all_child_windows instead of
262 delete_all_subwindows.
263 * window.c (Fwindow_nest, Fset_window_nest)
264 (Fset_window_new_total, Fset_window_new_normal)
265 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
266 (delete_all_subwindows): Rename to delete_all_child_windows.
267 (Fdelete_other_windows_internal, Fset_window_configuration):
268 Call delete_all_child_windows instead of delete_all_subwindows.
269 * frame.c (delete_frame): Call delete_all_child_windows instead
270 of delete_all_subwindows.
271
ca78dc43
PE
2722011-11-07 Paul Eggert <eggert@cs.ucla.edu>
273
274 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
275 This is also needed for porting to any host where GC_MARK_STACK is
276 not GC_MAKE_GCPROS_NOOPS.
277 (which_symbols): Use it.
278
a0241d01
KH
2792011-11-07 Kenichi Handa <handa@m17n.org>
280
281 * coding.c (coding_set_destination): Check coding->src_pos only
282 when coding->src_object is a buffer (bug#9910).
283
284 * process.c (send_process): Set the member src_multibyte of coding
285 to 0 (bug#9911) when sending a unibyte text.
286
287 * callproc.c (Fcall_process): Set the member src_multibyte of
288 process_coding to 0 (bug#9912).
289
a64bfdfa 2902011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
291
292 * xmenu.c (cleanup_widget_value_tree): New function.
293 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
294 calling free_menubar_widget_value_tree directly (Bug#9830).
295
cb41b32a
PE
2962011-11-06 Paul Eggert <eggert@cs.ucla.edu>
297
298 Fix some portability problems with 'inline'.
299 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
300 (window_box_width, window_box_left, window_box_left_offset)
301 (window_box_right, window_box_right_offset): Declare extern.
302 Otherwise, these inline functions do not conform to C99 and
303 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
304 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
305 * intervals.c (adjust_intervals_for_insertion)
306 (adjust_intervals_for_deletion): Now extern, because otherwise the
307 extern inline functions 'offset_intervals' couldn't refer to it.
308 (static_offset_intervals): Remove.
309 (offset_intervals): Rewrite using the old contents of
310 static_offset_intervals. The old version didn't conform to C99
311 because an extern inline function contained a reference to an
312 identifier with static linkage.
313
b7041366
AS
3142011-11-06 Andreas Schwab <schwab@linux-m68k.org>
315
316 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
317 GC.
318
88a37c4d
EZ
3192011-11-06 Eli Zaretskii <eliz@gnu.org>
320
321 * xdisp.c (init_iterator, reseat_to_string): Don't set the
322 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
323 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
324 return Qleft_to_right.
325
49745b39
CY
3262011-11-06 Chong Yidong <cyd@gnu.org>
327
328 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
329 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
330 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
331 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
332 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
333 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
334 (Fwindow_vscroll): Doc fix.
335 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
336 argument, since it makes no sense to pass a live window and for
337 consistency with window-child.
338
1f05cd82
CS
3392011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
340
341 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
342 support MSVC.
343
22610910
JR
3442011-11-05 Jason Rumney <jasonr@gnu.org>
345
346 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
347 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
348 fonts (Bug#6029).
349 (add_font_entity_to_list): Fix logic errors in mixed boolean and
350 bitwise arithmetic preventing use of unicode-sip and non-truetype
351 opentype fonts.
352
a06776b2
EZ
3532011-11-05 Eli Zaretskii <eliz@gnu.org>
354
3ad924ba
EZ
355 * s/ms-w32.h (fstat, stat, utime): Move redirections to
356 "emacs"-only part.
357
a06776b2
EZ
358 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
359 initialization code to keep similarity to xfns.c after changes
360 from 2011-11-05.
361
c9e7db78
JD
3622011-11-05 Jan Djärv <jan.h.d@swipnet.se>
363
a97f8f3f
JD
364 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
365 (unwind_create_frame): New function (Bug#9943).
366 (Fx_create_frame): Restructure code to be more similar to the one in
367 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
368 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
369 Move terminal->reference_count++ just before making the frame official
370 (Bug#9943).
371
372 * nsterm.m (x_free_frame_resources): New function.
373 (x_destroy_window): Move code to x_free_frame_resources.
374
c9e7db78
JD
375 * xfns.c (unwind_create_frame): Fix comment.
376 (Fx_create_frame, x_create_tip_frame): Move
377 terminal->reference_count++ just before making the frame
378 official. Move initialization of image_cache_refcount and
379 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
380
a6fc3b5c
EZ
3812011-11-05 Eli Zaretskii <eliz@gnu.org>
382
383 Support MSVC build with newer versions of Visual Studio.
384 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
385 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
386 nt/gmake.defs.
387
388 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
389 which are not supported by MSVC.
390 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
391 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
392 bitfields.
393 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
394 types in bitfields.
395 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
396
397 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
398
58179cce 3992011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
400
401 Support MSVC build with newer versions of Visual Studio.
402 * w32.c: Don't include w32api.h for MSVC.
403 (init_environment) [_MSC_VER]: Call sys_access, not _access.
404
405 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
406 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
407 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
408 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
409 e_* cousins.
410 (alloca) [_MSC_VER]: Define to _alloca.
411
412 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
413
414 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
415
a58c13ed
EZ
4162011-11-04 Eli Zaretskii <eliz@gnu.org>
417
418 * xdisp.c (note_mouse_highlight): If either of
419 previous/next-single-property-change returns nil, treat that as
420 the beginning or the end of the buffer. (Bug#9955)
421
fe0b6370
JD
4222011-11-04 Jan Djärv <jan.h.d@swipnet.se>
423
a58c13ed 424 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
425 label is not null (Bug#9951).
426 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
427 may be NULL.
428
89bd5ee1
EZ
4292011-11-04 Eli Zaretskii <eliz@gnu.org>
430
431 * window.c (Fwindow_body_size): Mention in the doc string that the
432 return value is in frame's canonical units. (Bug#9949)
433
84c3edb9
EZ
4342011-11-03 Eli Zaretskii <eliz@gnu.org>
435
4e2fb5c7
EZ
436 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
437
84c3edb9 438 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 439 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 440 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 441
bc17a887
EZ
4422011-11-01 Eli Zaretskii <eliz@gnu.org>
443
444 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
445 Don't stop backward scan on the continuation glyph, even though
446 its CHARPOS is positive.
26b46e51
EZ
447 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
448 cover_string to disp_string.
bc17a887 449
4ee88440
MR
4502011-11-01 Martin Rudalics <rudalics@gmx.at>
451
452 * window.c (temp_output_buffer_show): Don't use
453 Vtemp_buffer_show_specifiers.
454 (Vtemp_buffer_show_specifiers): Remove unused variable.
455
c2ff3c02
EZ
4562011-10-30 Eli Zaretskii <eliz@gnu.org>
457
458 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
459 past the beginning of the current glyph matrix.
460
58179cce 4612011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
462
463 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
464 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
465 HAVE_GTK3 (Bug#9869).
b77a6a7f 466
3b574623
JD
467 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
468 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
469
b77a6a7f
JD
470 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
471
472 * xterm.c: Declare x_handle_net_wm_state to return int.
473 (handle_one_xevent): Check if we are iconified but don't have
474 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
475 (get_current_wm_state): Return non-zero if not hidden,
476 check for _NET_WM_STATE_HIDDEN (Bug#9893).
477 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
478 (x_handle_net_wm_state): Return what get_current_wm_state returns.
479 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
480
196e41e4
PE
4812011-10-29 Paul Eggert <eggert@cs.ucla.edu>
482
483 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
484 so that this new function doesn't get optimized away by a
485 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
486
021f2e1a
AS
4872011-10-29 Andreas Schwab <schwab@linux-m68k.org>
488
489 * frame.h (MOUSE_HL_INFO): Remove excess parens.
490
8b058d44
EZ
4912011-10-29 Eli Zaretskii <eliz@gnu.org>
492
493 Fix the `xbytecode' command.
494 * .gdbinit (xprintbytestr): New command.
b50a28de 495 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
496 (xbytecode): Print the byte-code string as well.
497
4452fb80
EZ
4982011-10-29 Kim Storm <storm@cua.dk>
499
8b058d44
EZ
500 * alloc.c (which_symbols): New function.
501
21b72067
AS
5022011-10-29 Andreas Schwab <schwab@linux-m68k.org>
503
504 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
505 line. (Bug#9903)
506
83ed7b5c
GM
5072011-10-29 Glenn Morris <rgm@gnu.org>
508
509 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
510 Not clear what it was for, and it causes various bugs. (Bug#9839)
511
5a7a728b
EZ
5122011-10-28 Eli Zaretskii <eliz@gnu.org>
513
514 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
515 possible random value that matches one of those tested as
516 condition to clear the mouse face.
517
d3d0842f
CY
5182011-10-28 Chong Yidong <cyd@gnu.org>
519
520 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
521
31b39d13
DN
5222011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
523
524 * window.c (make_window): Initialize phys_cursor_on_p.
525
9aba6043
SM
5262011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
527
528 * lisp.h (struct Lisp_Symbol): Update comments.
529
c20992f4
JB
5302011-10-28 Juanma Barranquero <lekktu@gmail.com>
531
532 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
533
db4f02f2
EZ
5342011-10-28 Eli Zaretskii <eliz@gnu.org>
535
536 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
537 <oslsachem@gmail.com> for helping to debug this.
538
539 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
540 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
541 (g_b_init_get_glyph_outline_w): New static variables.
542 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
543 (GetGlyphOutlineW_Proc): New typedefs.
544 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
545 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
546 New functions.
547 (w32font_open_internal, compute_metrics):
548 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
549 instead of calling the "wide" APIs directly.
550
551 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
552
553 * w32.h (syms_of_w32font): Add prototype.
554
87e68db4
JB
5552011-10-27 Juanma Barranquero <lekktu@gmail.com>
556
557 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
558 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
559 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
560 (Fmove_to_window_line): Doc fix.
561
435c1d67
CY
5622011-10-27 Chong Yidong <cyd@gnu.org>
563
564 * process.c (make_process): Set gnutls_state to NULL.
565
566 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
567 non-NULL, regardless of GNUTLS_INITSTAGE.
568 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
569 an error. Set process slots as soon as we allocate them.
570
571 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
572
9c6c6f49
CY
5732011-10-27 Chong Yidong <cyd@gnu.org>
574
9aba6043
SM
575 * gnutls.c (emacs_gnutls_deinit): New function.
576 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
577 (Fgnutls_deinit, Fgnutls_boot): Use it.
578
579 * process.c (make_process): Initialize GnuTLS credentials to NULL.
580 (deactivate_process): Call emacs_gnutls_deinit.
581
657d08d3
JB
5822011-10-27 Juanma Barranquero <lekktu@gmail.com>
583
584 * image.c (x_create_x_image_and_pixmap):
585 * w32.c (sys_rename, w32_delayed_load):
586 * w32font.c (fill_in_logfont):
587 * w32reg.c (x_get_string_resource): Silence compiler warnings.
588
5430d399
JB
5892011-10-26 Juanma Barranquero <lekktu@gmail.com>
590
591 * w32fns.c (w32_default_color_map): New function,
592 extracted from Fw32_default_color_map.
a7ef684b 593 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 594
fe0055fa
PE
5952011-10-25 Paul Eggert <eggert@cs.ucla.edu>
596
597 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
598
e6346438
SM
5992011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
600
601 * keyboard.c (test_undefined): New function (bug#9751).
602 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
603
e112cc37
ET
6042011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
605
606 * sysdep.c (init_sys_modes): Fix the check for the controlling
607 terminal (Bug#6649).
608
7b5d6677
EZ
6092011-10-20 Eli Zaretskii <eliz@gnu.org>
610
611 * dispextern.h (struct bidi_it): New member next_en_type.
612
613 * bidi.c (bidi_line_init): Initialize the next_en_type member.
614 (bidi_resolve_explicit_1): When next_en_pos is valid for the
615 current character, check also for next_en_type being WEAK_EN.
616 (bidi_resolve_weak): Don't enter the expensive loop if the current
617 position is before next_en_pos. Record the bidi type of the first
618 non-ET, non-BN character we find, in addition to its position.
619 (bidi_level_of_next_char): Invalidate next_en_type when
620 next_en_pos is over-stepped.
621
7da0b018
PE
6222011-10-20 Paul Eggert <eggert@cs.ucla.edu>
623
624 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
625 * editfns.c: Rewrite current-time-zone so that it invokes
626 the equivalent of (format-time-string "%Z") to get the time zone name.
627 This fixes a bug when the time zone name contains characters that
628 need converting from the system time locale to Emacs internal format.
629 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
630 that patch fixed format-time-string to do the conversion, but
631 I forgot to fix current-time-zone.
632 (format_time_string): New function, containing most of
633 what Fformat_time_string used to contain.
634 (Fformat_time_string): Rewrite in terms of format_time_string.
635 This doesn't change this function's behavior.
636 (current-time-zone): Rewrite to use format_time_string.
637 This fixes the bug reported by Michael Schierl in
638 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
639 Jason Rumney's 2007-06-07 change worked around this bug, but
640 didn't fix it.
641 * systime.h (tzname, timezone): Remove no-longer-used declarations.
642
8547b010
EZ
6432011-10-19 Eli Zaretskii <eliz@gnu.org>
644
645 * xdisp.c (start_display): If the character at POS is displayed
646 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
647 (try_window_reusing_current_matrix): If a line ends in a display
648 vector or the next line starts in a display vector, continue
649 redrawing the window even though the character position of
650 start_row was reached.
8547b010
EZ
651 (Bug#9771, part 2)
652
4e948d15
CY
6532011-10-18 Chong Yidong <cyd@gnu.org>
654
655 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
656 with nobreak-char-display too.
657
4787455f
EZ
6582011-10-18 Eli Zaretskii <eliz@gnu.org>
659
660 Fix part 3 of bug#9771.
661 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
662 (bidi_resolve_neutral): Don't enter the expensive loop looking for
663 non-neutral characters if the current character is a paragraph
664 separator (a.k.a. Newline). This avoids running the same
665 expensive loop twice, once when we consume the preceding newline
666 and the other time when the line actually needs to be displayed.
667 Avoid the loop when we see neutrals on the base embedding level
668 following a character whose directionality is the same as the
669 paragraph's. This avoids running the expensive loop when a line
670 ends in a long sequence of neutrals, like control characters.
671 Add assertion against STRONG_AL type. Slightly rearrange code
672 that determines the type of a neutral given the first non-neutral
673 that follows it.
674 (bidi_level_of_next_char): Set next_en_pos to zero when
675 invalidating its info.
676
2c91f553
EZ
6772011-10-17 Eli Zaretskii <eliz@gnu.org>
678
679 * xdisp.c (push_display_prop): Determine whether to record string
680 or buffer position by IT->string, not by IT->method. Allow
681 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
682 (move_it_vertically_backward): Don't look for character position
683 immediately after the newline when in a continuation line.
684 (Bug#9771, part 1)
2c91f553 685
c7b08b0d
MR
6862011-10-15 Martin Rudalics <rudalics@gmx.at>
687
688 * window.c (coordinates_in_window): Rewrite and delabelize
689 vertical border check. (Bug#5357) (Bug#9618)
690
6b02f655
SM
6912011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
692
693 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
694 errors in XSetWindowBorder (bug#9310).
695
81d40c92
DA
6962011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
697
698 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
699 avoid crash when xmalloc overrun checking is enabled.
700
d4172c3b
EZ
7012011-10-13 Eli Zaretskii <eliz@gnu.org>
702
703 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
704 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
705 cursor motion with <left> and <right> arrow keys.
706
707 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
708 some callers set that themselves.
709
b00eea75
EZ
7102011-10-12 Eli Zaretskii <eliz@gnu.org>
711
712 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
713 display string and the previous row comes from the same string and
714 is empty. (Bug#9739) (Bug#9738)
715
8fe012c4
SM
7162011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
717
718 * doc.c (get_doc_string): Encode file name (bug#9735).
719
0074aef2
EZ
7202011-10-12 Eli Zaretskii <eliz@gnu.org>
721
79beb178
EZ
722 * bidi.c (bidi_level_of_next_char):
723 * xdisp.c (get_visually_first_element): Remove old incorrect
724 comments regarding the Unicode Line Separator character.
725
0074aef2
EZ
726 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
727
6e4b3fbe
DA
7282011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
729
730 * alloc.c (Fgc_status): Do not access beyond zombies array
731 boundary if nzombies > MAX_ZOMBIES.
732 * alloc.c (dump_zombies): Add missing format specifier.
733
0324f3af
PE
7342011-10-12 Paul Eggert <eggert@cs.ucla.edu>
735
b5525cac
PE
736 * xdisp.c (set_cursor_from_row): Simplify conditionals,
737 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
738
0324f3af
PE
739 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
740 Some packages use them to denote characters with modifiers.
741
e9b5f888
AS
7422011-10-11 Andreas Schwab <schwab@linux-m68k.org>
743
744 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
745 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
746 matching a pp-number. Rename parameter var to var1.
747
127827c0
SM
7482011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
749
750 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
751
c8fd3bd0
GM
7522011-10-08 Glenn Morris <rgm@gnu.org>
753
754 * callint.c (Fcall_interactively): Give a more explicit error for the
755 'c' case with a non-character input. (Bug#8479)
756
352ec8ff
EZ
7572011-10-08 Eli Zaretskii <eliz@gnu.org>
758
03669ccb
EZ
759 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
760 lines.
7061c986
EZ
761 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
762 lines that are hscrolled on the left.
03669ccb 763
352ec8ff
EZ
764 * dispnew.c (buffer_posn_from_coords): Account for a possible
765 presence of header-line. (Bug#4426)
766
a66cfb1c
SM
7672011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
768
6b02f655
SM
769 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
770 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 771
7c5ee88e
PE
7722011-10-07 Paul Eggert <eggert@cs.ucla.edu>
773
774 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
775 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
776 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
777 this makes Emacs dump core during garbage collection on rare
778 occasions. sizeof is obviously inferior to offsetof here, so
779 stick with offsetof.
780 (GC_POINTER_ALIGNMENT): New macro.
781 (mark_memory): Omit 3rd (offset) arg; caller changed.
782 Don't assume EMACS_INT alignment is the same as pointer alignment.
783
df1bbe5b
SM
7842011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
785
786 * keyboard.c (read_key_sequence_remapped): New var.
787 (read_key_sequence): Compute remapping in the right buffer.
788 (command_loop_1): Use read_key_sequence's remapping directly.
789
51553db6
SM
7902011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
791
32c1fffd
SM
792 * dired.c (file_name_completion): Don't expand file name.
793 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
794 before checking file name handler.
795
51553db6
SM
796 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
797 they've been requested explicitly (bug#9591).
798
b6bd1599 7992011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
800
801 * keymap.c (Fsingle_key_description): Use make_specified_string
802 instead of build_string to build string from push_key_description.
803 (Bug#5193)
804
f701dc2a
PE
8052011-09-30 Paul Eggert <eggert@cs.ucla.edu>
806
4222c55d
PE
807 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
808 This fixes a Y2038 bug on 64-bit hosts.
809 * buffer.c (reset_buffer):
810 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
811 (Fclear_buffer_auto_save_failure):
812 Use 0, not -1, to represent an unset failure time, since time_t
813 might not be signed.
814
f701dc2a
PE
815 Remove dependency on glibc malloc internals.
816 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
817 Move back here from lisp.h, but with their new implementations.
818 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
819 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
820 * charset.c (charset_table_init): New static var.
821 (syms_of_charset): Use it instead of xmalloc. This removes a
822 dependency on glibc malloc internals. See Eli Zaretskii's comment in
823 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
824 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
825 Move back to alloc.c.
826 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
827 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
828
9ceebf39
JD
8292011-09-30 Jan Djärv <jan.h.d@swipnet.se>
830
831 * nsterm.m (windowDidResize): Call x_set_window_size only when
832 ns_in_resize is true. Otherwise set pixelwidth/height and
833 call change_frame_size (Bug#9628).
834
cb993c58
PE
8352011-09-30 Paul Eggert <eggert@cs.ucla.edu>
836
3930c88b
PE
837 Port --enable-checking=all to Fedora 14 x86-64.
838 * charset.c (syms_of_charset): Also account for glibc malloc's
839 internal overhead when calculating the initial malloc maximum.
840
cb993c58
PE
841 Port --enable-checking=all to Fedora 14 x86.
842 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
843 Move to lisp.h.
844 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
845 (overrun_check_realloc, overrun_check_free):
846 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
847 That way, xmalloc returns a properly-aligned pointer even if
848 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
849 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
850 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
851 into account when calculating the initial malloc maximum.
852 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
853 Move here from alloc.c, so that charset.c can use it too.
854 Properly align; the old code wasn't right for common 32-bit hosts
855 when configured with --enable-checking=all.
856 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
857 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
858
31bed486
EZ
8592011-09-29 Eli Zaretskii <eliz@gnu.org>
860
04c70788 861 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
862 use EDOM.
863
fbcaa2f3
EZ
8642011-09-28 Eli Zaretskii <eliz@gnu.org>
865
866 * xdisp.c (compute_display_string_end): If there's no display
867 string at CHARPOS, return -1.
868
869 * bidi.c (bidi_fetch_char): When compute_display_string_end
870 returns a negative value, treat the character as a normal
871 character not covered by a display string. (Bug#9624)
872
a239d4e9
JB
8732011-09-28 Juanma Barranquero <lekktu@gmail.com>
874
875 * lread.c (Fread_from_string): Fix typo in docstring.
876
88652fd5
EZ
8772011-09-27 Eli Zaretskii <eliz@gnu.org>
878
879 * xdisp.c (handle_invisible_prop): If invisible text ends on a
880 newline, reseat the iterator instead of bidi-iterating there one
881 character at a time. (Bug#9610)
32c1fffd
SM
882 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
883 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 884
ed497dd4
AS
8852011-09-27 Andreas Schwab <schwab@linux-m68k.org>
886
887 * lread.c (readevalloop): Use correct code for NBSP.
888 (read1): Likewise. (Bug#9608)
889
b2bf61aa
MA
8902011-09-25 Michael Albinus <michael.albinus@gmx.de>
891
892 * dbusbind.c (Fdbus_register_signal): When service is not
893 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
894
32bbb17c
GM
8952011-09-25 Glenn Morris <rgm@gnu.org>
896
897 * buffer.c (truncate-lines): Doc fix.
898
94e0933e
CY
8992011-09-24 Chong Yidong <cyd@stupidchicken.com>
900
901 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
902 (Fset_window_next_buffers): Doc fix.
903
cddde921
GM
9042011-09-24 Glenn Morris <rgm@gnu.org>
905
906 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
907
1260aef1
PE
9082011-09-24 Paul Eggert <eggert@cs.ucla.edu>
909
25b4bfa0
PE
910 Fix minor problems found by static checking.
911 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
912 * indent.c (Fvertical_motion): Fix == vs = typo.
913
e3cbd34b
EZ
9142011-09-24 Eli Zaretskii <eliz@gnu.org>
915
a66cfb1c
SM
916 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
917 Default value is now t. Doc fix.
6bf7006f 918
e3cbd34b 919 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 920 logic when moving up, not only when moving down. Fix the
e3cbd34b 921 confusing name and values of the it_overshoot_expected variable;
32c1fffd 922 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
923
924 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
925 CHARPOS is covered by a display string which includes newlines.
926 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
927 is covered by a display string with embedded newlines.
928
a3de0cbd
MA
9292011-09-24 Michael Albinus <michael.albinus@gmx.de>
930
931 * dbusbind.c (Fdbus_register_signal): Add match rule to
932 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
933 (Fdbus_register_method, Vdbus_registered_objects_table):
934 Fix docstring.
a3de0cbd 935
b260039d
JM
9362011-09-24 Jim Meyering <meyering@redhat.com>
937
32c1fffd 938 do not ignore write error for any output size
b260039d
JM
939 The previous change was incomplete.
940 While it makes emacs --batch detect the vast majority of stdout
941 write failures, errors were still ignored whenever the output size is
942 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
943 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
944 && echo FAIL: ignored write error
945 FAIL: ignored write error
946 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
947 && echo FAIL: ignored write error
948 FAIL: ignored write error
949 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
950
8eca8a7c
AS
9512011-09-23 Andreas Schwab <schwab@linux-m68k.org>
952
953 * emacs.c (Fkill_emacs): In noninteractive mode exit
954 non-successfully if a write error occurred on stdout. (Bug#9574)
955
3341db62
EZ
9562011-09-21 Eli Zaretskii <eliz@gnu.org>
957
958 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
959 the xassert test.
960
961 * dispextern.h (struct it): Update the comment documenting what
962 can it->OBJECT be.
963
8c203dbf
EZ
9642011-09-20 Eli Zaretskii <eliz@gnu.org>
965
966 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
967 a display string, extend search for cursor position to end of row.
968 (find_row_edges): If the row ends in a newline from a display
969 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
970 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
971 (Fcurrent_bidi_paragraph_direction): Fix search for previous
972 non-empty line. Fixes confusing cursor motion with arrow keys at
973 the beginning of a line that starts with whitespace.
8c203dbf 974
a4824228
LMI
9752011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
976
977 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
978 (bug#9493).
979
33ed493b
CY
9802011-09-18 Chong Yidong <cyd@stupidchicken.com>
981
982 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
983 boolean (Bug#9154).
984
56cd55c8
EZ
9852011-09-18 Eli Zaretskii <eliz@gnu.org>
986
987 * xdisp.c (display_line): Record maximum and minimum buffer
988 positions even if no glyphs were produced (e.g., by a zero-width
989 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
990 buffer positions that will be removed from the glyph row because
991 they don't fit.
c02dcedf
EZ
992 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
993 column is beyond frame width: don't subtract 1 "pixel" when
994 computing width of the stretch.
3e62b7e0
EZ
995 (reseat_at_next_visible_line_start): Undo the change made on
996 2011-09-17 that saved paragraph information and restored it after
997 the call to `reseat'. (Bug#9545)
56cd55c8 998
5ed99d36 9992011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1000
1001 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1002 and turn window cursor on if cleared (Bug#9415).
1003
5ed99d36 10042011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1005
1006 * search.c (boyer_moore): Take unibyte characters from pattern
1007 literally. (Bug#9458)
1008
9bade7b2
EZ
10092011-09-18 Eli Zaretskii <eliz@gnu.org>
1010
1011 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1012
e5e9d610
PE
10132011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1014
87e4427a
PE
1015 Fix minor problem found by static checking.
1016 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1017 initialized, to pacify gcc -Wuninitialized.
1018
e5e9d610
PE
1019 * fileio.c: Report proper errno when syscall falls.
1020 (Finsert_file_contents): Save and restore errno,
1021 so that report_file_error outputs the correct diagnostic.
1022 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1023
a1674f0b
EZ
10242011-09-18 Eli Zaretskii <eliz@gnu.org>
1025
1026 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1027
fbfb6dd4
EZ
10282011-09-17 Eli Zaretskii <eliz@gnu.org>
1029
1030 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1031 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1032
bb187662
EZ
10332011-09-17 Eli Zaretskii <eliz@gnu.org>
1034
1137e8b8 1035 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1036 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1037
1038 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1039 (bidi_find_paragraph_start): Search back for paragraph beginning
1040 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1041 (bidi_move_to_visually_next): Only trigger paragraph-related
1042 computations when the last character is a newline or at EOB, not
1043 just any NEUTRAL_B. (Bug#9470)
1044
bb187662
EZ
1045 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1046 truncated lines if point is covered by a display string. (Bug#9524)
1047
2e621251
PE
10482011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1049
1050 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1051 (cons_to_x_long): New function.
1052 (lisp_data_to_selection_data): Use it. Correct the test for
1053 short-versus-long data; it was negated. Break out of vector
1054 loop, for efficiency, when a long datum is discovered.
1055
91a15bc6
SM
10562011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1057
1058 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1059
b41c3a35
EZ
10602011-09-16 Eli Zaretskii <eliz@gnu.org>
1061
1062 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1063 GCC PR/17406) by declaring this function with external scope.
1064
7812ba2d
PE
10652011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1066
1067 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1068 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1069
cf7edc2a
AS
10702011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1071
1072 * editfns.c (Fformat): Correctly handle text properties on "%%".
1073
bd01620e
EZ
10742011-09-15 Eli Zaretskii <eliz@gnu.org>
1075
1076 * xterm.c (x_draw_composite_glyph_string_foreground):
1077 * w32term.c (x_draw_composite_glyph_string_foreground):
1078 * term.c (encode_terminal_code):
1079 * composite.c (composition_update_it, get_composition_id):
1080 * xdisp.c (get_next_display_element)
1081 (fill_composite_glyph_string): Add comments about special meaning
1082 of TAB characters in a composition.
1083
a02719a3
PE
10842011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1085
1086 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1087 This occurs when processing a multibyte format.
1088 Problem reported by Wolfgang Jenker.
a02719a3 1089
72589a3c
JB
10902011-09-15 Johan Bockgård <bojohan@gnu.org>
1091
1092 * xdisp.c (try_cursor_movement): Only check for exact match if
1093 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1094
1c14176c
PE
10952011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1096
1097 Remove unused external symbols.
1098 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1099 * xdisp.c (calc_pixel_width_or_height): Now static.
1100 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1101 * indent.c (check_display_width):
1102 * w32term.c: Fix comment to match code.
1103 * xterm.c, xterm.h (x_catching_errors): Remove.
1104
d2eea5b5
PE
11052011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1106
1107 * xselect.c: Use signed conversions more consistently (Bug#9498).
1108 (selection_data_to_lisp_data): Assume incoming selection data are
1109 signed integers, not unsigned. This is to be consistent with
1110 outgoing selection data, which was modified to use signed integers
1111 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1112 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1113 expects long, not unsigned long.
1114
46888499
EZ
11152011-09-14 Eli Zaretskii <eliz@gnu.org>
1116
1117 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1118 computation of loop end. Reported by Johan Bockgård
1119 <bojohan@gnu.org>.
1120
ef8ef9fb
CY
11212011-09-13 Chong Yidong <cyd@stupidchicken.com>
1122
1123 * frame.c (Fother_visible_frames_p): Function deleted.
1124
fa819fed
EZ
11252011-09-12 Eli Zaretskii <eliz@gnu.org>
1126
1127 * indent.c (compute_motion): Process display vector front to back
1128 rather than the other way around. (Bug#2496)
1129
2ba8e008
SM
11302011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1131
1132 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1133
20f53c69
CY
11342011-09-11 Chong Yidong <cyd@stupidchicken.com>
1135
1136 * minibuf.c (Fread_from_minibuffer): Doc fix.
1137
d562d7a4
EZ
11382011-09-11 Eli Zaretskii <eliz@gnu.org>
1139
1140 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1141 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1142
1c4d7f3d
LMI
11432011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1144
1145 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1146 value for non-existent files.
1147
b885bf36
EZ
11482011-09-11 Eli Zaretskii <eliz@gnu.org>
1149
1150 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1151 set its "size" to -1. This will set the modtime_size field of
1152 the corresponding buffer to -1, which is what
1153 verify-visited-file-modtime expects for files that do not exist.
1154 (Bug#9139)
1155
6612f0bf
PE
11562011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1157
1158 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1159 here ...
1160 * lisp.h: ... from here. push_key_description is no longer
1161 defined in keyboard.c, so its declaration should not be in
1162 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1163 logically belongs with push_key_description.
1164
dfb3f755
PE
11652011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1166
1167 * buffer.h: Include <sys/types.h> instead of <time.h>.
1168 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1169 Problem reported by Herbert J. Skuhra.
1170
3134906c
LMI
11712011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1172
1173 * xml.c (parse_region): Make the parsing work for
1174 non-comment-starting XML files again (bug#9144).
1175
8d903f4e
AS
11762011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1177
1178 * image.c (gif_load): Fix calculation of bottom and right corner.
1179 (Bug#9468)
1180
80ad64f4
EZ
11812011-09-10 Eli Zaretskii <eliz@gnu.org>
1182
1183 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1184 redisplay in small windows.
1185
208a048d
EZ
11862011-09-09 Eli Zaretskii <eliz@gnu.org>
1187
1188 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1189
9b1c252e
MR
11902011-09-08 Martin Rudalics <rudalics@gmx.at>
1191
1192 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1193 Operate on live windows only.
1194
2949f33b
JB
11952011-09-08 Juanma Barranquero <lekktu@gmail.com>
1196
1197 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1198
e08dcafd
EZ
11992011-09-07 Eli Zaretskii <eliz@gnu.org>
1200
1201 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1202 only under bidi iteration.
1203
115b96bd
JD
12042011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1205
1206 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1207
c8199d0f
PE
12082011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1209
1210 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1211 Without this fix, the command to link temacs failed due to an
1212 undefined symbol __builtin_isnan. This is because
1213 /usr/include/iso/math_c99.h #defines isnan(x) to
1214 __builtin_isnan(x), but the bundled gcc, which identifies itself
1215 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1216 a __builtin_isnan.
1217 * floatfns.c (isnan): #undef, and then #define to a clone of
1218 what's in data.c.
1219 (Fisnan): Always define, since it's always available now.
1220 (syms_of_floatfns): Always define isnan at the Lisp level.
1221
e39b275c 12222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1223
1224 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1225
b2db44d9 12262011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1227
f4af5137 1228 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1229 The previous code assumed that file offsets (off_t values) fit in
1230 EMACS_INT variables, which is not true on typical 32-bit hosts.
1231 The code messed up by falsely reporting buffer overflow in cases
1232 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1233 when "big" contains more than 2**29 bytes, even though this
1234 inserts just one byte and does not overflow the buffer.
1235 (Finsert_file_contents): Store file offsets as off_t
1236 values, not as EMACS_INT values. Check for overflow when
1237 converting between EMACS_INT and off_t. When checking for
1238 buffer overflow or for overlap, take the offsets into account.
1239 Don't use EMACS_INT for small values where int suffices.
1240 When checking for overlap, fix a typo: ZV was used where
1241 ZV_BYTE was intended.
1242 (Fwrite_region): Don't assume off_t fits into 'long'.
1243 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1244
ecfc0a49
MA
12452011-09-05 Michael Albinus <michael.albinus@gmx.de>
1246
1247 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1248
6511acf2 12492011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1250
0999621a 1251 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1252
1253 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1254 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1255 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1256 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1257 (modify_event_symbol): Do not assume that the length of
1258 name_alist_or_stem is safe to alloca and fits in int.
1259 (Fexecute_extended_command): Likewise for function name and binding.
1260 (Frecursion_depth): Wrap around reliably on integer overflow.
1261 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1262 since some callers pass EMACS_INT values.
1263 (Fsingle_key_description): Don't crash if symbol name contains more
1264 than MAX_ALLOCA bytes.
1265 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1266 (get_minibuffer): Arg is now EMACS_INT, not int.
1267 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1268 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1269 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1270
2be7d702
PE
1271 * dbusbind.c (signature_cat): New function.
1272 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1273 Do not overrun buffer; instead, report string overflow.
1274
9d1df220
PE
1275 * dispnew.c (add_window_display_history): Don't overrun buffer.
1276 Truncate instead; this is OK since it's just a log.
1277
33ef5c64
PE
1278 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1279 even if the time zone offset is outlandishly large.
1280 Don't mishandle offset == INT_MIN.
1281
66c6fdd5
PE
1282 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1283 when creating daemon; the previous buffer-overflow check was incorrect.
1284
d749b01b
PE
1285 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1286 which has the guts of the old verror function.
1287
b5cd1905
PE
1288 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1289 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1290
6e1a67fb
PE
1291 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1292 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1293 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1294 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1295 length of string rather than counting it via multiple sprintfs;
1296 that's simpler and more reliable.
c21721cc
PE
1297 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1298 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1299 sprintf, in case result does not fit in int.
1300
c57b67fc
PE
1301 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1302 (fontset_from_font): Print it.
1303
8a401434
PE
1304 * frame.c (tty_frame_count): Now printmax_t, not int.
1305 (make_terminal_frame, set_term_frame_name): Print it.
1306 (x_report_frame_params): In X, window IDs are unsigned long,
1307 not signed long, so print them as unsigned.
1308 (validate_x_resource_name): Check for implausibly long names,
1309 and don't assume name length fits in 'int'.
1310 (x_get_resource_string): Don't blindly alloca invocation name;
1311 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1312 not fit in int.
1313
6e1a67fb
PE
1314 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1315 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1316 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1317
0df02bf3
PE
1318 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1319 Use esprintf, not sprintf, in case result does not fit in int.
1320
48e30793
PE
1321 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1322 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1323 it as a large positive number.
1324 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1325 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1326
a66ff6d8
PE
1327 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1328 in case result does not fit in int.
1329
aca216ff
PE
1330 * print.c (float_to_string): Detect width overflow more reliably.
1331 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1332 buffer overrun. Don't assume list length fits in 'int'. Treat
1333 print length of 0 as 0, not as infinity; to be consistent with other
1334 uses of print length in this function. Don't overflow print length
1335 index. Don't assume hash table size fits in 'long', or that
1336 vectorlike size fits in 'unsigned long'.
1337
31c286f7
PE
1338 * process.c (make_process): Use printmax_t, not int, to format
1339 process-name gensyms.
1340
55e5faa1
PE
1341 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1342
80f2e268
PE
1343 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1344 to avoid potential buffer overrun.
1345
670741ab
PE
1346 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1347 if X resource line is longer than 512 bytes.
1348
b7163a50
PE
1349 * xfns.c (x_window): Make sprintf buffer a bit bigger
1350 to avoid potential buffer overrun.
1351
ae58ff1f
PE
1352 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1353
c43c8a6a
PE
1354 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1355
3f8236f4
PE
13562011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1357
53e9fe90 1358 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1359 Without these, Emacs silently mishandles large integers sometimes.
1360 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1361 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1362
6511acf2
PE
1363 * xdisp.c (try_window_id): Check Emacs fixnum range before
1364 converting to 'int'.
806add1d 1365
6511acf2 1366 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1367 Check that an Emacs fixnum is in range before assigning it to 'int'.
1368 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1369 values converted from Emacs fixnums.
1370 (Frecenter): Don't wrap around a line count if it is out of 'int'
1371 range; instead, treat it as an extreme value.
1372 (Fset_window_configuration, compare_window_configurations):
1373 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1374
6511acf2
PE
1375 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1376 that can exceed INT_MAX. Check that EMACS_INT value is in range
1377 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1378 (match_limit): Don't assume that a fixnum can fit in 'int'.
1379
6511acf2 1380 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1381 exceed INT_MAX.
1382
6511acf2 1383 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1384 (Fvertical_motion): Don't wrap around LINES values that don't fit
1385 in 'int'. Instead, treat them as extreme values. This is good
1386 enough for windows, which can't have more than INT_MAX lines anyway.
1387
fcb901a7
LMI
13882011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1389
0f2f6b6d
LMI
1390 * Require libxml/parser.h to avoid compilation warning.
1391
fcb901a7
LMI
1392 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1393
1394 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1395 since this reportedly can destroy thread storage.
1396
6e20a0d4
CY
13972011-08-30 Chong Yidong <cyd@stupidchicken.com>
1398
1399 * syntax.c (find_defun_start): Update all cache variables if
1400 exiting early (Bug#9401).
1401
148ae00e
EZ
14022011-08-30 Eli Zaretskii <eliz@gnu.org>
1403
f6cfbd8f
EZ
1404 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1405
148ae00e
EZ
1406 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1407 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1408 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1409
1410 * term.c (tty_append_glyph): New function.
1411 (produce_stretch_glyph): Static function and its prototype deleted.
1412
a66cfb1c
SM
1413 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1414 Add prototypes.
148ae00e 1415
c4a07a4c
PE
14162011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1417
1418 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1419 when checking :margin (Bug#9390).
1420 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1421 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1422 so that the name doesn't mislead. All uses changed.
1423
6bc8cd65
JB
14242011-08-28 Johan Bockgård <bojohan@gnu.org>
1425
1426 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1427 set_tty_hooks.
1428
dca4927e
EZ
14292011-08-27 Eli Zaretskii <eliz@gnu.org>
1430
1431 * xdisp.c (move_it_to): Don't bail out early when reaching
1432 position beyond to_charpos, if we are scanning backwards.
1433 (move_it_vertically_backward): When DY == 0, make sure we get to
1434 the first character in the line after the newline.
1435
f2cad773
PE
14362011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1437
1438 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1439 (ccl_driver): Do not generate an out-of-range pointer.
1440 (Fccl_execute_on_string): Remove unnecessary check for
1441 integer overflow, noted by Stefan Monnier in
1442 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1443 Remove a FIXME that didn't need fixing.
1444 Simplify the newly-introduced buffer reallocation code.
1445
0cae2cdb
JB
14462011-08-27 Juanma Barranquero <lekktu@gmail.com>
1447
1448 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1449
5fc295a4 14502011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1451
70c60eb2 1452 Integer and memory overflow issues (Bug#9196).
726e0ab1 1453
d31850da
PE
1454 * doc.c (get_doc_string): Rework so that
1455 get_doc_string_buffer_size is the actual buffer size, rather than
1456 being 1 less than the actual buffer size; this makes xpalloc more
1457 convenient.
1458
a69fbedb
PE
1459 * image.c (x_allocate_bitmap_record, cache_image):
1460 * xselect.c (Fx_register_dnd_atom):
1461 Simplify previous changes by using xpalloc.
1462
fe5c5d37
PE
1463 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1464 since either will do and ptrdiff_t is convenient with xpalloc.
1465
0065d054
PE
1466 * charset.c (charset_table_size)
1467 (struct charset_sort_data.priority): Now ptrdiff_t.
1468 (charset_compare): Don't overflow if priorities differ greatly.
1469 (Fsort_charsets): Don't assume list length fits in int.
1470 Check for size-calculation overflow when allocating sort data.
1471 (syms_of_charset): Allocate an initial charset table that is
1472 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1473
1474 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1475
1476 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1477 The actual value is always <= INT_MAX, and leaving it unsigned made
1478 overflow checking harder.
1479
1480 * dispextern.h (struct glyph_matrix.rows_allocated)
1481 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1482 with xpalloc. The values are still always <= INT_MAX.
1483
1484 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1485
1486 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1487 (SAFE_NALLOCA): New macro.
1488
1489 * region-cache.c (struct boundary.pos, find_cache_boundary)
1490 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1491 (set_cache_region, invalidate_region_cache)
1492 (revalidate_region_cache, know_region_cache, region_cache_forward)
1493 (region_cache_backward, pp_cache):
1494 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1495 so that ptrdiff_t * can be passed to xpalloc.
1496 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1497 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1498 (pp_cache): Don't assume cache_len fits in int.
1499 * region-cache.h: Adjust extern decls to match.
1500
1501 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1502 EMACS_INT, since either will do, for xpalloc.
1503
1504 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1505 (xnmalloc, xnrealloc, xpalloc): New functions.
1506
726e0ab1
PE
1507 * bidi.c (bidi_shelve_header_size): New constant.
1508 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1509 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1510
51f30bc5 1511 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1512 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1513 (overlay_strings):
1514 Don't update size of array until after memory allocation succeeds,
1515 because xmalloc/xrealloc may not return.
0065d054
PE
1516 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1517 now that we have proper integer overflow checking.
1518 (record_overlay_string, overlay_strings): Catch overflows when
1519 calculating size of overlay_str_buf.
726e0ab1 1520
0065d054
PE
1521 * callproc.c (Fcall_process): Check for size overflow when
1522 calculating size of args2.
1523 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1524 Normally we prefer signed values, but sticking with ptrdiff_t would
1525 require adding more-complicated checks.
726e0ab1
PE
1526
1527 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1528 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1529 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1530 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1531
1532 * character.c (Fstring): Check for size-calculation overflow.
1533
1534 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1535 unnecessary integer overflow. Check for size overflow.
1536 (encode_coding_object): Don't update size until xmalloc succeeds.
1537
1538 * composite.c (get_composition_id): Check for overflow in glyph
1539 length calculations.
1540
1541 Integer and memory overflow fixes for display code.
1542 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1543 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1544 (scrolling_window): Check for overflow in size calculations.
1545 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1546 Don't assume glyph table len fits in int.
1547 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1548 (row_table_size): Now ptrdiff_t, not int.
1549 (scrolling_window): Avoid overflow in size calculations.
1550 Don't update size until allocation succeeds.
1551 * fns.c (concat): Check for overflow in size calculations.
1552 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1553 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1554 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1555
1556 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1557 (get_doc_string): Check for size calculation overflow.
1558 Don't update size until allocation succeeds.
1559 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1560 EMACS_INT, where ptrdiff_t will do.
1561 (Fsubstitute_command_keys): Check for string overflow.
1562
1563 * editfns.c (set_time_zone_rule): Don't assume environment length
1564 fits in int.
1565 (message_length): Now ptrdiff_t, not int.
1566 (Fmessage_box): Don't update size until allocation succeeds.
1567 Don't assume message length fits in int.
1568 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1569
0065d054
PE
1570 * emacs.c (main): Do not reallocate argv, since there is a null at
1571 the end that can be overwritten, and this way there's no need to
1572 worry about size-calculation overflow.
1573 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1574
1575 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1576 alloc succeeds.
1577 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1578
1579 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1580 (x_set_scroll_bar_width, x_figure_window_size):
1581 Check for integer overflow.
1582 (x_set_alpha): Do not assume XINT fits in int.
1583
1584 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1585 This is for the members text_lines, text_cols, total_lines, total_cols,
1586 where the system imposes an 'int' limit.
1587
1588 * fringe.c (Fdefine_fringe_bitmap):
1589 Don't update size until alloc works.
1590
1591 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1592 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1593
1594 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1595 Check for size-calculation overflow.
1596 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1597 do, as we prefer signed integers.
1598 (id_to_widget.max_size, id_to_widget.used)
1599 (xg_store_widget_in_map, xg_remove_widget_from_map)
1600 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1601 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1602 Use and return ptrdiff_t, not int.
1603 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1604 * gtkutil.h: Change prototypes to match the above.
1605
1606 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1607 are duplicate now that they've been promoted to lisp.h.
1608 (x_allocate_bitmap_record, x_alloc_image_color)
1609 (make_image_cache, cache_image, xpm_load):
1610 Don't update size until alloc is done.
1611 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1612 (x_detect_edges):
3256efce 1613 Check for size calculation overflow.
726e0ab1
PE
1614 (ct_colors_allocated_max): New constant.
1615 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1616 overflow.
3256efce 1617
726e0ab1
PE
1618 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1619 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1620 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1621 Use ptrdiff_t, not int, to count maps.
1622 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1623 calculations. Don't update size until allocation succeeds.
1624 Redo calculations to avoid overflow.
726e0ab1
PE
1625 * keyboard.h: Change prototypes to match the above.
1626
1627 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1628 to count maps.
1629 (current_minor_maps): Check for size calculation overflow.
1630 * keymap.h: Change prototypes to match the above.
1631
1632 * lread.c (read1, init_obarray): Don't update size until alloc done.
1633
1634 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1635 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1636
726e0ab1
PE
1637 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1638 Now ptrdiff_t, not int.
1639 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1640 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1641
1642 * process.c (Fnetwork_interface_list): Check for overflow
1643 in size calculation.
1644
1645 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1646
1647 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1648 overflow. Don't bother calling xmalloc when xrealloc will do.
1649
1650 * search.c (Freplace_match): Check for size calculation overflow.
1651 (Fset_match_data): Don't assume list lengths fit in 'int'.
1652
1653 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1654 for command line length. Do not attempt to address one before the
1655 beginning of an array, as that's not portable.
1656
1657 * term.c (max_frame_lines): Remove; unused.
1658 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1659 not int.
1660 (encode_terminal_code, calculate_costs): Check for size
1661 calculation overflow.
1662 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1663 table lengths and related sizes. Don't update size until alloc
1664 done. Redo calculations to avoid overflow.
1665 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1666
1667 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1668 subtracting pointers.
1669 (gobble_line): Check for overflow more carefully. Don't update size
1670 until alloc done.
1671
1672 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1673 Don't update size until alloc done.
1674 Redo size calculations to avoid overflow.
1675 Check for size calculation overflow.
0065d054 1676 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1677
1678 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1679 Use ptrdiff_t, not int, for sizes.
1680 (store_mode_line_noprop_char): Don't update size until alloc done.
1681
0065d054
PE
1682 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1683 Use ptrdiff_t, not int, for sizes.
1684 (Finternal_make_lisp_face, cache_face):
1685 Check for size calculation overflow.
1686 (cache_face): Treat size calculation overflows as if they were
1687 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1688
1689 * xfns.c (x_encode_text, x_set_name_internal)
1690 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1691 sizes, since they can exceed INT_MAX in size. Check for size
1692 calculation overflow.
1693
0065d054
PE
1694 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1695 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1696 Don't update size until alloc done.
1697
0065d054 1698 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1699 as sprintf is limited to int lengths.
1d526e2f 1700
252c5ee1
PE
1701 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1702 (X_LONG_MIN): New macros.
864d7ce7
PE
1703 Use them to make the following changes clearer.
1704 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1705 This change doesn't affect the value now, but it may help remind
1706 future maintainers not to raise the value too much later.
1707 (SELECTION_QUANTUM): Remove, replacing with ...
1708 (selection_quantum): ... new function, which avoids overflow.
1709 All uses changed.
1710 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1711 assumption that selection length fits in 'int'.
1712 (x_reply_selection_request, x_handle_selection_request)
1713 (x_get_window_property, receive_incremental_selection)
1714 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1715 (lisp_data_to_selection_data, clean_local_selection_data):
1716 Use ptrdiff_t, not int, to record length of selection.
1717 (x_reply_selection_request, x_get_window_property)
1718 (receive_incremental_selection, x_property_data_to_lisp):
1719 Redo calculations to avoid overflow.
1720 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1721 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1722 something.
1723 (x_get_window_property, receive_incremental_selection)
1724 (lisp_data_to_selection_data, x_property_data_to_lisp):
1725 Check for size-calculation overflow.
1726 (x_get_window_property, receive_incremental_selection)
1727 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1728 Don't store size until memory allocation succeeds.
1729 (x_get_window_property): Plug memory leak on memory exhaustion.
1730 Don't double-block input; malloc is safe here. Don't assume 2**34
1731 - 4 fits in unsigned long. Add an xassert to check
1732 XGetWindowProperty overflow. Be more careful about overflow
1733 calculations, and distinguish size from memory overflow better.
1734 (receive_incremental_selection): When tracing, don't assume
1735 unsigned int is less than INT_MAX.
1736 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1737 harmful) conversions of unsigned short to int.
1738 (lisp_data_to_selection_data): Don't assume that integers
1739 in the range -65535 through -1 fit in an X unsigned short.
1740 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1741 result parameters unless successful. Rely on cons_to_unsigned
1742 to report problems with elements; the old code wasn't right anyway.
1743 (x_check_property_data): Check for int overflow; we cannot use
1744 a wider type due to X limits.
1745 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1746
726e0ab1 1747 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1748
0065d054
PE
1749 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1750 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1751 (x_color_cells): Don't store size until memory allocation succeeds.
1752 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1753 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1754 (x_term_init): Don't assume length fits in int (sprintf is limited
1755 to int size).
bc18e09d 1756
ebfa62c0
PE
1757 Use ptrdiff_t for composition IDs.
1758 * character.c (lisp_string_width):
1759 * composite.c (composition_table_size, n_compositions)
1760 (get_composition_id, composition_gstring_from_id):
1761 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1762 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1763 * window.c (Frecenter):
1764 Use ptrdiff_t, not int, for composition IDs.
1765 * composite.c (get_composition_id): Check for integer overflow.
1766 * composite.h: Adjust prototypes to match the above changes.
1767
d3411f89
PE
1768 Use ptrdiff_t for hash table indexes.
1769 * category.c (hash_get_category_set):
1770 * ccl.c (ccl_driver):
1771 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1772 * coding.c (coding_system_charset_list, detect_coding_system):
1773 * coding.h (struct coding_system.id):
1774 * composite.c (get_composition_id, gstring_lookup_cache):
1775 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1776 * image.c (xpm_get_color_table_h):
1777 * lisp.h (hash_lookup, hash_put):
1778 * minibuf.c (Ftest_completion):
1779 Use ptrdiff_t for hash table indexes, not int (which is too
1780 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1781 32-bit --with-wide-int hosts).
1782
e097a6fa
PE
1783 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1784 Add a FIXME comment about memory leaks.
1785 (syms_of_charset): Don't assume xmalloc returns.
1786
5637687f
PE
1787 Don't assume that stated character widths fit in int.
1788 * character.c (Fchar_width, c_string_width, lisp_string_width):
1789 * character.h (CHAR_WIDTH):
1790 * indent.c (MULTIBYTE_BYTES_WIDTH):
1791 Use sanitize_char_width to avoid undefined and/or bad behavior
1792 with outlandish widths.
a66cfb1c 1793 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1794 now that we have two such functions. All uses changed.
1795 (sanitize_char_width): New inline function.
1796
a2271ba2
PE
1797 Don't assume that tab-width fits in int.
1798 * character.h (sanitize_width): New inline function.
1799 (SANE_TAB_WIDTH): New macro.
1800 (ASCII_CHAR_WIDTH): Use it.
1801 * indent.c (sane_tab_width): Remove. All uses replaced by
1802 SANE_TAB_WIDTH (current_buffer).
1803 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1804
18c52557
PE
1805 * fileio.c: Integer overflow issues with file modes.
1806 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1807
caeeedc1
PE
1808 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1809 Remove unreachable code.
1810 (read_hex, load_charset_map_from_file): Check for integer overflow.
1811
50849c52
PE
1812 * xterm.c: don't go over XClientMessageEvent limit
1813 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1814 (x_send_scroll_bar_event): Likewise. Check that the size does not
1815 exceed limits imposed by XClientMessageEvent, as well as the usual
1816 ptrdiff_t and size_t limits.
1817
b13995db
PE
1818 * keyboard.c: Overflow, signedness and related fixes.
1819 (make_lispy_movement): Use same integer type in forward decl
1820 that is used in the definition.
1821 (read_key_sequence, keyremap_step):
1822 Change bufsize argument back to int, undoing my 2011-03-30 change.
1823 We prefer signed types, and int is wide enough here.
1824 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1825 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1826 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1827 length, not size_t. Use ptrdiff_t for index, not int.
1828 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1829 possibility of integer overflow.
1830
13464394
PE
1831 Overflow, signedness and related fixes for images.
1832
1833 * dispextern.h (struct it.stack[0].u.image.image_id)
1834 (struct_it.image_id, struct image.id, struct image_cache.size)
1835 (struct image_cache.used, struct image_cache.ref_count):
1836 * gtkutil.c (update_frame_tool_bar):
1837 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1838 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1839 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1840 * nsmenu.m (update_frame_tool_bar):
1841 * xdisp.c (calc_pixel_width_or_height):
1842 * xfns.c (image_cache_refcount):
1843 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1844 on typical 64-bit hosts.
1845
1846 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1847 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1848 Omit unnecessary casts to int.
1849 (parse_image_spec): Check that integers fall into 'int' range
1850 when the callers expect that.
1851 (image_ascent): Redo ascent calculation to avoid int overflow.
1852 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1853 (lookup_image): Remove unnecessary tests.
1854 (xbm_image_p): Locals are now of int, not EMACS_INT,
1855 since parse_image_check makes sure they fit into int.
1856 (png_load, gif_load, svg_load_image):
1857 Prefer int to unsigned where either will do.
1858 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1859 old tiff_error_handler and tiff_warning_handler.
1860 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1861 stack buffer overflows. It uses only the features of vsnprintf
1862 that are common to both POSIX and native Microsoft.
1863 (tiff_error_handler, tiff_warning_handler): Use it.
1864 (tiff_load, gif_load, imagemagick_load_image):
1865 Don't assume :index value fits in 'int'.
1866 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1867 (imagemagick_load_image): Check that crop parameters fit into
1868 the integer types that MagickCropImage accepts. Don't assume
1869 Vimagemagick_render_type has a nonnegative value. Don't assume
1870 size_t fits in 'long'.
1871 (gs_load): Use printmax_t to print the widest integers possible.
1872 Check for integer overflow when computing image height and width.
1873
c11821d4
EZ
18742011-08-26 Eli Zaretskii <eliz@gnu.org>
1875
1876 * xdisp.c (redisplay_window): Don't force window start if point
1877 will be invisible in the resulting window. (Bug#9324)
1878
0c95fcf7
EZ
18792011-08-25 Eli Zaretskii <eliz@gnu.org>
1880
1881 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1882 the display spec is of the form `(space ...)'.
1883 (handle_display_spec): Return the value returned by
1884 handle_single_display_spec, not just 1 or zero.
1885 (handle_single_display_spec): If the display spec is of the form
1886 `(space ...)', and specifies display in the text area, return 2
1887 rather than 1.
fee65a97 1888 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1889 accurately, and prefer exact match for point under bidi.
1890 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1891
1892 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1893 into disp_prop; all users changed.
1894
1895 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1896 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1897 for the text covered by the display property.
1898
e4ed06f1
CY
18992011-08-25 Chong Yidong <cyd@stupidchicken.com>
1900
1901 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1902 Change return value to nil.
1903 (Frecord_buffer): Delete unused function.
1904
f67cdd7f
EZ
19052011-08-24 Eli Zaretskii <eliz@gnu.org>
1906
5980d4c6
EZ
1907 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1908 buffers, return left-to-right.
8610fe8b
EZ
1909 (set_cursor_from_row): Consider candidate row a win if its glyph
1910 represents a newline and point is on that newline. Fixes cursor
1911 positioning on the newline at EOL of R2L text within L2R
1912 paragraph, and vice versa.
1913 (try_cursor_movement): Check continued rows, in addition to
1914 continuation rows. Fixes unwarranted scroll when point enters a
1915 continued line of R2L text within an L2R paragraph, or vice versa.
1916 (cursor_row_p): Consider the case of point being equal to
1917 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1918 from the end of a short line to the beginning of a continued line
1919 of R2L text within L2R paragraph.
1920 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1921 composed characters.
5980d4c6 1922
f67cdd7f
EZ
1923 * bidi.c (bidi_check_type): Use xassert.
1924 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1925 members.
1926
bca633fb
EZ
19272011-08-23 Eli Zaretskii <eliz@gnu.org>
1928
1929 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1930 a character.
1931
4a5885a7
CY
19322011-08-23 Chong Yidong <cyd@stupidchicken.com>
1933
1934 * nsfont.m (ns_otf_to_script): Fix typo.
1935
0902a04e
KH
19362011-08-22 Kenichi Handa <handa@m17n.org>
1937
1938 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1939 extra slot even if the purpose is char-code-property-table.
1940
1a2e6670
EZ
19412011-08-23 Eli Zaretskii <eliz@gnu.org>
1942
8ddde651
EZ
1943 * xdisp.c (redisplay_window): When computing centering_position,
1944 account for the height of the header line. (Bug#8874)
1945
425cc014
EZ
1946 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1947 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1948 candidate is selected by the mouse, and that candidate has a
1949 composed character under the mouse.
1950
1a2e6670
EZ
1951 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1952 coordinates reported by pos-visible-in-window-p for a composed
1953 character in column zero.
1954
8b76d6f8
SM
19552011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1956
1957 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1958
dac347dd
EZ
19592011-08-22 Eli Zaretskii <eliz@gnu.org>
1960
1961 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1962 consider it a hit if to_charpos is anywhere in the range of the
1963 composed buffer positions.
1964
e013fb34
CY
19652011-08-22 Chong Yidong <cyd@stupidchicken.com>
1966
1967 * image.c (gif_load): Don't assume that each subimage has the same
1968 dimensions as the base image. Handle disposal method that is
1969 "undefined" by the gif spec (Bug#9335).
1970
bd1ba3e8
CY
19712011-08-20 Chong Yidong <cyd@stupidchicken.com>
1972
1973 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1974 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1975
54a1215b
EZ
19762011-08-19 Eli Zaretskii <eliz@gnu.org>
1977
823564e5
EZ
1978 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1979 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1980 from an Org mode buffer to a Speedbar frame.
1981
54a1215b
EZ
1982 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1983 a composition, take its buffer position from IT->cmp_it.charpos.
1984 Fixes cursor positioning at the beginning of a line that begins
1985 with a composed character.
1986
9778ebcc
EZ
19872011-08-18 Eli Zaretskii <eliz@gnu.org>
1988
0be6ee06
EZ
1989 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1990 character bidirectional type, use STRONG_L instead. Fixes crashes
1991 in a buffer produced by `describe-categories'.
1992
9778ebcc
EZ
1993 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1994 members before the level stack, so they would be saved and
1995 restored when copying iterator state. Fixes incorrect reordering
1996 around TABs covered by display properties.
1997
156bffbe
AS
19982011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1999
6b02f655 2000 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2001
72ad093b
CY
20022011-08-17 Chong Yidong <cyd@stupidchicken.com>
2003
2004 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2005 (internal_condition_case_2, internal_condition_case_n):
2006 Remove unnecessary aborts (Bug#9081).
72ad093b 2007
35774242
EZ
20082011-08-17 Eli Zaretskii <eliz@gnu.org>
2009
2010 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2011 has no `load' handler, try opening the file locally. (Bug#9311)
2012
db76dd85
KB
20132011-08-16 Ken Brown <kbrown@cornell.edu>
2014
2015 * gmalloc.c: Expand comment.
2016
b215eee5
EZ
20172011-08-16 Eli Zaretskii <eliz@gnu.org>
2018
2019 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2020 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2021
a4579d33
KB
20222011-08-16 Ken Brown <kbrown@cornell.edu>
2023
2024 Fix memory allocation problems in Cygwin build (Bug#9273).
2025
2026 * unexcw.c ( __malloc_initialized): Declare external variable.
2027 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2028
8b76d6f8
SM
2029 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2030 New variables.
a4579d33
KB
2031 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2032 dumped emacs.
2033 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2034 in the static heap.
2035 [CYGWIN] (special_realloc): New function.
2036 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2037 requests to realloc storage in the static heap.
2038
3ebec551
PE
20392011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2040
2041 * bidi.c (bidi_initialize): Remove unused local.
2042
9fd8be00
EZ
20432011-08-15 Eli Zaretskii <eliz@gnu.org>
2044
6b02f655
SM
2045 * bidimirror.h:
2046 * biditype.h: Remove file.
2047 * makefile.w32-in ($(BLD)/bidi.$(O)):
2048 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2049
2050 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2051
2052 * chartab.c: Improve commentary for the uniprop_table API.
2053
32413314
EZ
2054 * bidi.c (bidi_paragraph_init): Support zero value of
2055 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2056 (bidi_initialize): Use uniprop_table instead of including
2057 biditype.h and bidimirror.h.
32413314 2058
9fd8be00
EZ
2059 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2060 coordinates of the iterator when restoring from ppos_it.
2061 (Bug#9296)
2062
5cf2b69b
KH
20632011-08-14 Kenichi Handa <handa@m17n.org>
2064
2065 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2066 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2067
daf17d00
EZ
20682011-08-14 Eli Zaretskii <eliz@gnu.org>
2069
2070 * xdisp.c (move_it_in_display_line_to): Don't invoke
2071 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2072 ppos_it. Fixes vertical cursor motion when line beginning is
2073 covered by an image. (Bug#9296)
2074
08e3161a
JD
20752011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2076
2077 * nsterm.h (ns_run_ascript): Declare.
2078 (NSAPP_DATA2_RUNASSCRIPT): Define.
2079
2080 * nsfns.m (as_script, as_result, as_status): New static variables.
2081 (ns_run_ascript): New function.
5e617bc2 2082 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2083 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2084 the event loop. Get status from as_status (Bug#7276).
2085
2086 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2087 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2088 the event loop (Bug#7276).
2089
a3720aa2
AS
20902011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2091
2092 * gnutls.c (QCgnutls_bootprop_priority)
2093 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2094 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2095 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2096 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2097 (QCgnutls_bootprop_verify_hostname_error)
2098 (QCgnutls_bootprop_callbacks_verify): Rename from
2099 Qgnutls_bootprop_..., all uses changed.
2100
2101 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2102 uses changed.
2103
0a0d27fb
PE
21042011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2105
19d5c50c
PE
2106 * xfaces.c (Qframe_set_background_mode): Now static.
2107 * dispextern.h (Qframe_set_background_mode): Remove decl.
2108
0a0d27fb
PE
2109 * process.c (Fnetwork_interface_info): Declare local only if needed.
2110
377538cb
JD
21112011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2112
2113 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2114 (Fnetwork_interface_list): Allocate in increments of bytes instead
2115 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2116 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2117 sockaddr.
2118 (struct ifflag_def): notrailers is smart on OSX.
2119 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2120 Get hardware address with getifaddrs if available.
2121
08fff70c
EZ
21222011-08-12 Eli Zaretskii <eliz@gnu.org>
2123
2124 * xdisp.c (iterate_out_of_display_property): xassert that
2125 IT->position is set to within IT->object's boundaries. Break from
2126 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2127 when IT->position is set up wrongly due to some bug.
2128 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2129 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2130 entry. Force push_it to save on the stack the current
2131 buffer/string position, to be restored by pop_it. Fix flags in
2132 the iterator structure wrt the object coming from a display
2133 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2134 properties. (Bug#9284)
2135
7be1c708 21362011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2137
7be1c708
CY
2138 * fontset.c (fontset_get_font_group): Add proper type checks.
2139 (Bug#9172)
aac0c6e3 2140
7be1c708 21412011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2142
7be1c708
CY
2143 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2144 and LC_VERSION_MIN_MACOSX.
2145 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2146 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2147
97bb72a6
EZ
21482011-08-08 Eli Zaretskii <eliz@gnu.org>
2149
2150 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2151 no-display-properties-and-no-overlays under bidi display.
2152 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2153 properties and overlays.
97bb72a6 2154
d5617611
CY
21552011-08-08 Chong Yidong <cyd@stupidchicken.com>
2156
37e11a63
CY
2157 * editfns.c (Fset_time_zone_rule): Document relationship with the
2158 setenv function.
2159
d5617611
CY
2160 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2161 the font entity extracted from the cache (Bug#8109).
2162
58872834
CY
21632011-08-07 Chong Yidong <cyd@stupidchicken.com>
2164
2165 * composite.c (autocmp_chars): Don't reset point. That is done by
2166 restore_point_unwind (Bug#5984).
2167
75bfc667
JL
21682011-08-07 Juri Linkov <juri@jurta.org>
2169
2170 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2171 to show the arg `TIME' instead of `TIMEVAL'.
2172
d1410150
EZ
21732011-08-06 Eli Zaretskii <eliz@gnu.org>
2174
2175 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2176 display property strides EOL and includes a newline, as in
2177 longlines-mode. (Bug#9254)
75b771e4
EZ
2178 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2179 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2180
2181 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2182 is non-zero, even if the data buffer is NULL. Fixes a crash in
2183 vertical-motion with longlines-mode. (Bug#9254)
2184
35928349
EZ
21852011-08-05 Eli Zaretskii <eliz@gnu.org>
2186
ec7cc85b
EZ
2187 * bidi.c <bidi_cache_total_alloc>: Now static.
2188 (bidi_initialize): Initialize bidi_cache_total_alloc.
2189
8b76d6f8 2190 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2191 cache. (Bug#9221)
2192
2193 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2194 amount allocated this far in `bidi_cache_total_alloc'.
2195 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2196 non-zero, only free the data buffer without restoring the cache
2197 contents. All callers changed.
2198
2199 * dispextern.h (bidi_unshelve_cache): Update prototype.
2200
2201 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2202 (move_it_in_display_line, move_it_to)
2203 (move_it_vertically_backward, move_it_by_lines): Replace the call
2204 to xfree to an equivalent call to bidi_unshelve_cache.
2205 (move_it_in_display_line_to): Fix logic of returning
412b6358 2206 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2207
e2e2423b
EZ
22082011-08-05 Eli Zaretskii <eliz@gnu.org>
2209
2210 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2211 came from a string character with a `cursor' property. (Bug#9229)
2212
ae9e757a
JD
22132011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2214
2215 * Makefile.in (LIB_PTHREAD): New variable.
2216 (LIBES): Add LIB_PTHREAD (Bug#9216).
2217
2218 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2219 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2220
213bd7f2
AS
22212011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2222
6b02f655 2223 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2224
99aaf75f
JD
22252011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2226
2227 * xterm.c (x_find_topmost_parent): New function.
2228 (x_set_frame_alpha): Find topmost parent window with
2229 x_find_topmost_parent and set the property there also (bug#9181).
2230 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2231
c74e9d86
PE
22322011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2233
2234 * callproc.c (Fcall_process): Avoid vfork clobbering
2235 the local vars buffer, coding_systems, current_dir.
2236
640c8776
SM
22372011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2238
2239 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2240
f26d0e4c
PE
22412011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2242
8a10d76c
PE
2243 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2244 so that it is not optimized away.
2245
f26d0e4c
PE
2246 * xdisp.c (compute_display_string_pos): Remove unused local.
2247
55439c61
EZ
22482011-08-02 Eli Zaretskii <eliz@gnu.org>
2249
2250 Fix slow cursor motion and scrolling in large buffers with
2251 selective display, like Org Mode buffers. (Bug#9218)
2252
2253 * dispextern.h (struct bidi_it): New member disp_prop_p.
2254
2255 * xdisp.c: Remove one-slot cache of display string positions.
2256 (compute_display_string_pos): Accept an additional argument
5e617bc2 2257 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2258 for a display string or property. If found, set DISP_PROP_P
2259 non-zero.
2260
2261 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2262 DISP_PROP_P, and pass it to compute_display_string_pos.
2263 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2264 non-zero. All callers of bidi_fetch_char changed.
2265
fb33fa43
SM
22662011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2267
2268 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2269
b099e063
DM
22702010-12-03 Don March <don@ohspite.net>
2271
2272 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2273 last character M-[char] is translated to ESC [char] (bug#7541).
2274
5cc7f7af
KH
22752011-08-02 Kenichi Handa <handa@m17n.org>
2276
d0fffa3f 2277 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2278
2279 * chartab.c (uniprop_table): Make it non-static.
2280
525d5e6e
EZ
22812011-08-01 Eli Zaretskii <eliz@gnu.org>
2282
2283 * xdisp.c (forward_to_next_line_start): Accept additional argument
2284 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2285 on the newline.
2286 (reseat_at_next_visible_line_start): Use the bidi iterator state
2287 returned by forward_to_next_line_start to restore the state of
2288 it->bidi_it after backing up to previous newline. (Bug#9212)
2289
31011111
AS
22902011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2291
2292 * regex.c (re_comp): Protoize.
2293 (re_exec): Fix return type.
2294 (regexec): Fix type of `ret'. (Bug#9203)
2295
476371c4
PE
22962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2297
e5d76069
PE
2298 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2299 This is needed if max-image-size is a floating-point number.
2300
9a79b20c
AS
23012011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2302
2303 * print.c (print_object): Print empty symbol as ##.
2304
2305 * lread.c (read1): Read ## as empty symbol.
2306
d8c2fa78
AA
23072011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2308
2309 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2310 setting frame foreground color (Bug#9175).
2311 (x_set_background_color): Likewise.
2312
ffe57a7a
AA
2313 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2314 contents (Bug#9176).
2315 (EmacsTooltip -init): Remove bezels and add shadows to
2316 tooltip windows.
2317
bf3492a5
AA
2318 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2319 or scroll bar (Bug#8470).
2320
d55e9c53
AA
2321 * nsfont.m (nsfont_open): Remove assignment to voffset and
2322 unnecessary vars hshink, expand, hd, full_height, min_height.
2323 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2324
2325 * nsterm.h (nsfont_info): Remove voffset field.
2326
d8c2fa78 23272011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2328
2329 Implement strike-through and overline on NextStep (Bug#8863).
2330
2331 * nsfont.m (nsfont_open): Use underline position provided by font,
2332 instead of hard-coded value of 2.
2333 (nsfont_draw): Call ns_draw_text_decoration instead.
2334
2335 * nsterm.h: Add declaration for ns_draw_text_decoration.
2336
2337 * nsterm.m (ns_draw_text_decoration): New function for drawing
2338 underline, overline, and strike-through.
2339 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2340 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2341 accommodate underlining, etc.
4843aac3 2342
4cc60b9b
EZ
23432011-07-28 Eli Zaretskii <eliz@gnu.org>
2344
bc7ece87
EZ
2345 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2346 default.
4cc60b9b 2347
476371c4
PE
23482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2349
66606eea
PE
2350 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2351 Without this fix, if a signal arrives just after memory fills up,
2352 'malloc' might be invoked reentrantly.
2353
476371c4
PE
2354 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2355 In other words, assume that every image size is allowed, on non-X
2356 hosts. This assumption is probably wrong, but it lets Emacs compile.
2357
f3fcc40d
AS
23582011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2359
2360 * regex.c (re_iswctype): Convert return values to boolean.
2361
350c992f
EZ
23622011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2363
2364 * xdisp.c (compute_display_string_pos): Don't use cached display
2365 string position if the buffer had its restriction changed.
2366 (Bug#9184)
2367
5266b4bb
PE
23682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2369
2370 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2371
2573a837 23722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2373
41f55ccd 2374 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2375
39e378da
PE
2376 * bidi.c: Integer size and overflow fixes.
2377 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2378 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2379 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2380 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2381 (bidi_find_other_level_edge):
2382 Use ptrdiff_t instead of EMACS_INT where either will do.
2383 This works better on 32-bit hosts configured --with-wide-int.
2384 (bidi_cache_ensure_space): Check for size-calculation overflow.
2385 Use % rather than repeated addition, for better worst-case speed.
2386 Don't set bidi_cache_size until after xrealloc returns, because it
2387 might not return.
2388 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2389 (bidi_cache_ensure_space): Also check that the bidi cache size
2390 does not exceed that of the largest Lisp string or buffer. See Eli
2391 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2392
5e927815
PE
2393 * alloc.c (__malloc_size_t): Remove.
2394 All uses replaced by size_t. See Andreas Schwab's note
2395 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2396
ca4aa935
PE
2397 * image.c: Improve checking for integer overflow.
2398 (check_image_size): Assume that f is nonnull, since
2399 it is always nonnull in practice. This is one less thing to
2400 worry about when checking for integer overflow later.
2401 (x_check_image_size): New function, which checks for integer
2402 overflow issues inside X.
2403 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2404 This removes the need for a memory_full check.
2405 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2406 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2407 (xbm_read_bitmap_data): Change locals back to 'int', since
2408 their values must fit in 'int'.
2409 (xpm_load_image, png_load, tiff_load):
2410 Invoke x_create_x_image_and_pixmap earlier,
2411 to avoid much needless work if the image is too large.
2412 (tiff_load): Treat overly large images as if
2413 x_create_x_image_and_pixmap failed, not as malloc failures.
2414 (gs_load): Use x_check_image_size.
2415
5f8f9cc2
PE
2416 * gtkutil.c: Omit integer casts.
2417 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2418 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2419
5adf60bc
PE
2420 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2421
c8907a93
PE
2422 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2423 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2424 would wrongly return t on a 64-bit host.
2425
e3c25c68
PE
2426 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2427 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2428 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2429 and therefore cause GCC to emit a bogus diagnostic in some cases.
2430
3f791afe
PE
2431 * image.c: Integer signedness and overflow and related fixes.
2432 This is not an exhaustive set of fixes, but it's time to
2433 record what I've got.
2434 (lookup_pixel_color, check_image_size): Remove redundant decls.
2435 (check_image_size): Don't assume that arbitrary EMACS_INT values
2436 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2437 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2438 (tiff_load, imagemagick_load_image):
2439 Check for overflow in size calculations.
2440 (x_create_x_image_and_pixmap): Remove unnecessary test for
2441 xmalloc returning NULL; that can't happen.
2442 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2443 (xpm_color_bucket): Use better integer hashing function.
2444 (xpm_cache_color): Don't possibly over-allocate memory.
2445 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2446 (gif_memory_source):
2447 Use ptrdiff_t, not int or size_t, to record sizes.
2448 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2449 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2450 either works, as we prefer signed integers.
2451 (tiff_read_from_memory, tiff_write_from_memory):
2452 Return tsize_t, not size_t, since that's what the TIFF API wants.
2453 (tiff_read_from_memory): Don't fail simply because the read would
2454 go past EOF; instead, return a short read.
2455 (tiff_load): Omit no-longer-needed casts.
2456 (Fimagemagick_types): Don't assume size fits into 'int'.
2457
3cc5a532
PE
2458 Improve hashing quality when configured --with-wide-int.
2459 * fns.c (hash_string): New function, taken from sxhash_string.
2460 Do not discard information about ASCII character case; this
2461 discarding is no longer needed.
2462 (sxhash-string): Use it. Change sig to match it. Caller changed.
2463 * lisp.h: Declare it.
2464 * lread.c (hash_string): Remove, since we now use fns.c's version.
2465 The fns.c version returns a wider integer if --with-wide-int is
2466 specified, so this should help the quality of the hashing a bit.
2467
b312a492
PE
2468 * emacs.c: Integer overflow minor fix.
2469 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2470 Define only if GNU_LINUX.
2471 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2472
dfd153ae
PE
2473 * dispnew.c: Integer signedness and overflow fixes.
2474 Remove unnecessary forward decls, that were a maintenance hassle.
2475 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2476 All uses changed.
2477 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2478 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2479 (prepare_desired_row, line_draw_cost):
2480 Use int, not unsigned, where either works.
2481 (save_current_matrix, restore_current_matrix):
2482 Use ptrdiff_t, not size_t, where either works.
2483 (init_display): Check for overflow more accurately, and without
2484 relying on undefined behavior.
2485
a81d11a3
PE
2486 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2487 Remove, replacing with the new symbols in lisp.h. All uses changed.
2488 * fileio.c (make_temp_name):
2489 * filelock.c (lock_file_1, lock_file):
2490 * xdisp.c (message_dolog):
2491 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2492 Use pMd etc. instead.
2493 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2494 replacing the pWIDE etc. symbols removed from editfns.c.
2495
3300e6fd
PE
2496 * keyboard.h (num_input_events): Now uintmax_t.
2497 This is (very slightly) less likely to mess up due to wraparound.
2498 All uses changed.
2499
fd05c7e9
PE
2500 * buffer.c: Integer signedness fixes.
2501 (alloc_buffer_text, enlarge_buffer_text):
2502 Use ptrdiff_t rather than size_t when either will do, as we prefer
2503 signed integers.
2504
903fe15d
PE
2505 * alloc.c: Integer signedness and overflow fixes.
2506 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2507 (__malloc_size_t): Default to size_t, not to int.
2508 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2509 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2510 Prefer ptrdiff_t to size_t when either would do, as we prefer
2511 signed integers.
2512 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2513 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2514 Now const. Initialize with values that are in range even if char
2515 is signed.
2516 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2517 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2518 These functions do the right thing with sizes > 2**32.
2519 (check_depth): Now ptrdiff_t, not int.
2520 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2521 Adjust to new way of storing sizes. Check for size overflow bugs
2522 in rest of code.
2523 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2524 slightly wrong anyway, as it missed one instance of
2525 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2526 (refill_memory_reserve): Omit needless cast to size_t.
2527 (mark_object_loop_halt): Mark as externally visible.
2528
ac82cc6a
PE
2529 * xselect.c: Integer signedness and overflow fixes.
2530 (Fx_register_dnd_atom, x_handle_dnd_message):
2531 Use ptrdiff_t, not size_t, since we prefer signed.
2532 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2533 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2534 x_dnd_atoms_size and x_dnd_atoms_length.
2535
c2d1e36d
PE
2536 * doprnt.c: Prefer signed to unsigned when either works.
2537 * eval.c (verror):
2538 * doprnt.c (doprnt):
2539 * lisp.h (doprnt):
2540 * xdisp.c (vmessage):
2541 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2542 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2543 prefer signed arithmetic to avoid comparison confusion.
2544 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2545 but is a bit tricky.
2546
0e926e56
PE
2547 Assume freestanding C89 headers, string.h, stdlib.h.
2548 * data.c, doprnt.c, floatfns.c, print.c:
2549 Include float.h unconditionally.
2550 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2551 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2552 * regex.c: Likewise for stddef.h, string.h.
2553 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2554 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2555 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2556 (STDC_HEADERS): Remove obsolete defines.
2557 * sysdep.c: Include limits.h unconditionally.
2558
9cfdb3ec
PE
2559 Assume support for memcmp, memcpy, memmove, memset.
2560 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2561 * regex.c (memcmp, memcpy):
2562 Remove; we assume C89 now.
2563
2564 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2565 (__malloc_safe_bcopy): Remove; no longer needed.
2566
cf950e6b 2567 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2568 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2569 well either way, and we prefer signed to unsigned.
2570
dbf38e02
LMI
25712011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2572
2573 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2574 closes the connection while we're reading (bug#9182).
2575
d6f0886c 25762011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2577
d6f0886c
JD
2578 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2579 are specified (Bug#9168).
24e0f6b1 2580
2eb1f9e6
PE
25812011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2582
2583 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2584 Found by GCC static checking and --with-wide-int on a 32-bit host.
2585
22381272 25862011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2587
2588 * xdisp.c (compute_display_string_pos): Fix logic of caching
2589 previous display string position. Initialize cached_prev_pos to
2590 -1. Fixes slow-down at the beginning of a buffer.
2591
f25e39b4
EZ
25922011-07-24 Eli Zaretskii <eliz@gnu.org>
2593
2594 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2595 for attrs[LFACE_FONTSET_INDEX].
2596
04c4b52e
PE
25972011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2598
2599 * xml.c (parse_region): Remove unused local
2600 that was recently introduced.
2601
c1734fbd
EZ
26022011-07-23 Eli Zaretskii <eliz@gnu.org>
2603
be18c5a5
EZ
2604 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2605 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2606
c1734fbd
EZ
2607 * xdisp.c (move_it_in_display_line_to): Record the best matching
2608 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2609 exit if none of the characters scanned was an exact match.
2610 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2611 when exact match is impossible due to invisible text, and the
2612 lines are truncated.
2613
a258d627
JD
26142011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2615
2616 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2617 for OSX >= 10.7.
2618
b6d5a689
EZ
26192011-07-22 Eli Zaretskii <eliz@gnu.org>
2620
0f74f785
EZ
2621 Fix a significant slow-down of cursor motion with C-n, C-p,
2622 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2623 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2624 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2625 (next_element_from_buffer): Call compute_stop_pos_backwards to
2626 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2627 base_level_stop.
2628 (reseat): Don't look for prev_stop, as that could mean a very long
2629 run.
2630 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2631 <cached_disp_overlay_modiff>: Cache for last found display string
2632 position.
551918c1 2633 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2634 about the same buffer in the same area of character positions, and
2635 the buffer wasn't changed since the time the display string
2636 position was cached.
551918c1 2637
b2d0c91a
EZ
26382011-07-22 Eli Zaretskii <eliz@gnu.org>
2639
2640 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2641 is an integer, which is important for empty lines. (Bug#9149)
2642
043604ee
CY
26432011-07-22 Chong Yidong <cyd@stupidchicken.com>
2644
2645 * frame.c (Fmodify_frame_parameters): In tty case, update the
2646 default face if necessary (Bug#4238).
2647
da4adb04
CY
26482011-07-21 Chong Yidong <cyd@stupidchicken.com>
2649
2650 * editfns.c (Fstring_to_char): No need to explain what a character
2651 is in the docstring (Bug#6576).
2652
9abd0532
LMI
26532011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2654
2655 * xml.c (parse_region): Make sure we always return a tree.
2656
36881d16
HK
26572011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2658
2659 * xml.c (parse_region): If a document contains only comments,
2660 return that, too.
2661
1e98674d
LMI
26622011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2663
2664 * xml.c (make_dom): Return comments, too.
2665
590bd467
PE
26662011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2667
2668 Port to OpenBSD.
2669 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2670 and the surrounding thread.
2671 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2672 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2673 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2674 timer goes off.
2675 * s/openbsd.h (BROKEN_SIGIO): Define.
2676 * unexelf.c (unexec) [__OpenBSD__]:
2677 Don't update the .mdebug section of the Alpha COFF symbol table.
2678
f41628b2
LMI
26792011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2680
2681 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2682 (bug#8460).
2683
b59b67c5
PE
26842011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2685
15e3a074
PE
2686 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2687 This fixes some race conditions on the permissions of any newly
2688 created file.
2689
41bed37d
PE
2690 * alloc.c (valid_pointer_p): Use pipe, not open.
2691 This fixes some permissions issues when debugging.
2692
b59b67c5
PE
2693 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2694 If fchown fails to set both uid and gid, try to set just gid,
2695 as that is sometimes allowed. Adjust the file's mode to eliminate
2696 setuid or setgid bits that are inappropriate if fchown fails.
2697
925a6be7
SM
26982011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2699
2700 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2701 to compare Lisp_Objects.
2702 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2703 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2704 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2705
52968808
AS
27062011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2707
0a6a104b
AS
2708 * lread.c (read_integer): Unread even EOF character.
2709 (read1): Likewise. Properly record start position of symbol.
2710
52968808
AS
2711 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2712 symbol character follows.
2713
9e381cdd
PE
27142011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2715
2716 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2717 This works around a problem with the previous change to Fcopy_file.
2718 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2719 and without this change, GCC might complain about discarding
2720 fchown's return value.
2721
b5641435
JB
27222011-07-16 Juanma Barranquero <lekktu@gmail.com>
2723
2724 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2725
a8031457
PE
27262011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2727
2728 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2729
dd889327
LMI
27302011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2731
750c33f7
LMI
2732 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2733 it's used from the C level.
2734
dd889327
LMI
2735 * process.c: Use the same condition for POLL_FOR_INPUT in both
2736 keyboard.c and process.c (bug#1858).
2737
87e86684
LM
27382011-07-09 Lawrence Mitchell <wence@gmx.li>
2739
2740 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2741 (Fgnutls_boot): Use it.
2742
64348f40
AS
27432011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2744
2745 * doc.c (Fsubstitute_command_keys): Revert last change.
2746
1d698799
LMI
27472011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2748
f863868c
LMI
2749 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2750 quotes the next character, and doesn't affect other longer
2751 sequences (bug#8935).
2752
1d698799
LMI
2753 * lread.c (syms_of_lread): Clarify that is isn't only
2754 `eval-buffer' and `eval-defun' that's affected by
2755 `lexical-binding' (bug#8460).
2756
aa4b6df6
EZ
27572011-07-15 Eli Zaretskii <eliz@gnu.org>
2758
2759 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2760 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2761
5d856da6
PE
27622011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2763
ad6042bb
PE
2764 Fix minor problems found by static checking.
2765 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2766 (elsz): Now a signed constant, not a size_t var. We prefer signed
2767 types to unsigned, to avoid integer comparison confusion. Without
2768 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2769 "cannot optimize loop, the loop counter may overflow", a symptom
2770 of the confusion.
f00bbb22 2771 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2772 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2773
6468f31c
LMI
27742011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2775
49080b10
LMI
2776 * search.c (Fre_search_backward): Mention `case-fold-search' in
2777 all the re_search_* functions (bug#8138).
2778
6468f31c
LMI
2779 * keyboard.c (Fopen_dribble_file): Document when the file is
2780 closed (bug#8056).
2781
c965adc5
EZ
27822011-07-14 Eli Zaretskii <eliz@gnu.org>
2783
df9733bf
EZ
2784 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2785 bidi_cache_idx.
2786
0bb23927
EZ
2787 Support bidi reordering of display and overlay strings.
2788 * xdisp.c (compute_display_string_pos)
2789 (compute_display_string_end): Accept additional argument STRING.
2790 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2791 (reseat_to_string): Initialize bidi_it->string.s and
2792 bidi_it->string.schars.
2793 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2794 NULL (avoids a crash in bidi_paragraph_init).
2795 Initialize itb.string.lstring.
0bb23927
EZ
2796 (init_iterator): Call bidi_init_it only of a valid
2797 buffer position was specified. Initialize paragraph_embedding to
2798 L2R.
2799 (reseat_to_string): Initialize the bidi iterator.
2800 (display_string): If we need to ignore text properties of
2801 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2802 original value of -1 will not work with bidi.)
2803 (compute_display_string_pos): First arg is now struct
2804 `text_pos *'; all callers changed. Support display properties on
2805 Lisp strings.
2806 (compute_display_string_end): Support display properties on Lisp
2807 strings.
2808 (init_iterator, reseat_1, reseat_to_string): Initialize the
2809 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2810 when iterating on a string not from display properties).
640c8776
SM
2811 (compute_display_string_pos, compute_display_string_end):
2812 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2813 arrow keys.
2814 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2815 base_level_stop; instead, set base_level_stop to BEGV.
2816 Fixes crashes in vertical-motion.
0bb23927
EZ
2817 (next_element_from_buffer): Improve commentary for when
2818 the iterator is before prev_stop.
2819 (init_iterator): Initialize bidi_p from the default value of
2820 bidi-display-reordering, not from buffer-local value. Use the
2821 buffer-local value only if initializing for buffer iteration.
2822 (handle_invisible_prop): Support invisible properties on strings
2823 that are being bidi-reordered.
2824 (set_iterator_to_next): Support bidi reordering of C strings and
2825 Lisp strings.
2826 (next_element_from_string): Support bidi reordering of Lisp
2827 strings.
2828 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2829 (display_string): Support display of R2L glyph rows.
2830 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2831 (init_iterator): Don't initialize it->bidi_p for strings
2832 here.
2833 (reseat_to_string): Initialize it->bidi_p for strings here.
2834 (next_element_from_string, next_element_from_c_string)
2835 (next_element_from_buffer): Add xassert's for correspondence
2836 between IT's object being iterated and it->bidi_it.string
2837 structure.
2838 (face_before_or_after_it_pos): Support bidi iteration.
2839 (next_element_from_c_string): Handle the case of the first string
2840 character that is not the first one in the visual order.
2841 (get_visually_first_element): New function, refactored from common
2842 parts of next_element_from_buffer, next_element_from_string, and
2843 next_element_from_c_string.
2844 (tool_bar_lines_needed, redisplay_tool_bar)
2845 (display_menu_bar): Force left-to-right direction. Add a FIXME
2846 comment for making that be controlled by a user option.
2847 (push_it, pop_it): Save and restore the state of the
2848 bidi iterator. Save and restore the bidi_p flag.
2849 (pop_it): Iterate out of display property for string iteration as
2850 well.
2851 (iterate_out_of_display_property): Support iteration over strings.
2852 (handle_single_display_spec): Set up it->bidi_it for iteration
2853 over a display string, and call bidi_init_it.
2854 (handle_single_display_spec, next_overlay_string)
2855 (get_overlay_strings_1, push_display_prop): Set up the bidi
2856 iterator for displaying display or overlay strings.
2857 (forward_to_next_line_start): Don't use the shortcut if
2858 bidi-iterating.
2859 (back_to_previous_visible_line_start): If handle_display_prop
2860 pushed the iterator stack, restore the internal state of the bidi
2861 iterator by calling bidi_pop_it same number of times.
2862 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2863 and we are bidi-iterating, don't decrement the iterator position;
2864 instead, set the first_elt flag in the bidi iterator, to produce
2865 the same effect.
2866 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2867 (push_display_prop): xassert that we are iterating a buffer.
2868 (push_it, pop_it): Save and restore paragraph_embedding member.
2869 (handle_single_display_spec, next_overlay_string)
2870 (get_overlay_strings_1, reseat_1, reseat_to_string)
2871 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2872 correctly. Don't assume unibyte strings are not bidi-reordered.
2873 (compute_display_string_pos)
2874 (compute_display_string_end): Fix handling the case of C string.
2875 (push_it, pop_it): Save and restore from_disp_prop_p.
2876 (handle_single_display_spec, push_display_prop): Set the
2877 from_disp_prop_p flag.
2878 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2879 (pop_it): Call iterate_out_of_display_property only if we are
2880 popping after iteration over a string that came from a display
2881 property. Fix a typo in popping stretch info. Add an assertion
2882 for verifying that the iterator position is in sync with the bidi
2883 iterator.
2884 (handle_single_display_spec, get_overlay_strings_1)
2885 (push_display_prop): Fix initialization of paragraph direction for
2886 string when that of the parent object is not yet determined.
2887 (reseat_1): Call bidi_init_it to resync the bidi
2888 iterator with IT's position. (Bug#7616)
2889 (find_row_edges): If ROW->start.pos gives position
2890 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2891 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2892 Reset the from_disp_prop_p flag.
2893 (SAVE_IT, RESTORE_IT): New macros.
2894 (pos_visible_p, face_before_or_after_it_pos)
2895 (back_to_previous_visible_line_start)
2896 (move_it_in_display_line_to, move_it_in_display_line)
2897 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2898 (try_scrolling, redisplay_window, display_line): Use them when
2899 saving a temporary copy of the iterator and restoring it back.
2900 (back_to_previous_visible_line_start, reseat_1)
2901 (init_iterator): Empty the bidi cache "stack".
2902 (move_it_in_display_line_to): If iterator ended up at
2903 EOL, but we never saw any buffer positions smaller than
2904 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2905 motion in bidi-reordered lines.
2906 (move_it_in_display_line_to): Record prev_method and prev_pos
2907 immediately before the call to set_iterator_to_next. Fixes cursor
2908 motion in bidi-reordered lines with stretch glyphs and strings
2909 displayed in margins. (Bug#8133) (Bug#8867)
2910 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2911 TO_CHARPOS.
640c8776
SM
2912 (pos_visible_p): Support positions in bidi-reordered lines.
2913 Save and restore bidi cache.
0bb23927
EZ
2914
2915 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2916 (bidi_paragraph_info): Delete unused struct.
2917 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2918 (bidi_cache_start): New variable.
2919 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2920 to zero.
2921 (bidi_cache_fetch_state, bidi_cache_search)
2922 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2923 (bidi_cache_find, bidi_peek_at_next_level)
2924 (bidi_level_of_next_char, bidi_find_other_level_edge)
2925 (bidi_move_to_visually_next): Compare cache index with
2926 bidi_cache_start rather than with zero.
2927 (bidi_fetch_char): Accept new argument STRING; all callers
2928 changed. Support iteration over a string. Support strings with
2929 display properties. Support unibyte strings. Fix the type of
2930 `len' according to what STRING_CHAR_AND_LENGTH expects.
2931 (bidi_paragraph_init, bidi_resolve_explicit_1)
2932 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2933 (bidi_level_of_next_char, bidi_move_to_visually_next):
2934 Support iteration over a string.
0bb23927
EZ
2935 (bidi_set_sor_type, bidi_resolve_explicit_1)
2936 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2937 can now be zero (for strings); special values 0 and -1 were
2938 changed to -1 and -2, respectively.
2939 (bidi_char_at_pos): New function.
2940 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2941 Call it instead of FETCH_MULTIBYTE_CHAR.
2942 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2943 initialized to valid values.
2944 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2945 values.
2946 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2947 the test for valid cached positions. Fix the logic for looking up
2948 the sentinel state in the cache. GCPRO the Lisp string we are
2949 iterating.
2950 (bidi_push_it, bidi_pop_it): New functions.
2951 (bidi_initialize): Initialize the bidi cache start stack pointer.
2952 (bidi_cache_ensure_space): New function, refactored from part of
2953 bidi_cache_iterator_state. Don't assume the required size is just
2954 one BIDI_CACHE_CHUNK away.
2955 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2956 (bidi_count_bytes, bidi_char_at_pos): New functions.
2957 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2958 always valid if bidi_cache_idx is valid.
2959 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2960 is valid if it's going to be used.
2961 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2962 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2963 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2964 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2965 (bidi_find_other_level_edge, bidi_cache_start_stack):
2966 All variables related to cache indices are now EMACS_INT.
c965adc5 2967
0bb23927
EZ
2968 * dispextern.h (struct bidi_string_data): New structure.
2969 (struct bidi_it): New member `string'. Make flag members be 1-bit
2970 fields, and put them last in the struct.
640c8776
SM
2971 (compute_display_string_pos, compute_display_string_end):
2972 Update prototypes.
0bb23927
EZ
2973 (bidi_push_it, bidi_pop_it): Add prototypes.
2974 (struct iterator_stack_entry): New members bidi_p,
2975 paragraph_embedding, and from_disp_prop_p.
2976 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2977 (bidi_shelve_cache, bidi_unshelve_cache):
2978 Declare prototypes.
0bb23927
EZ
2979
2980 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2981 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2982 and vector-like objects.
2983
2984 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2985 cache around display iteration.
2986
2987 * window.c (Fwindow_end, window_scroll_pixel_based)
2988 (displayed_window_lines, Frecenter): Save and restore the bidi
2989 cache around display iteration.
2990
3bbd2265
LMI
29912011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2992
2993 * editfns.c (Fdelete_region): Clarify the use of the named
2994 parameters (bug#6788).
2995
adc47434
MR
29962011-07-14 Martin Rudalics <rudalics@gmx.at>
2997
2998 * indent.c (Fvertical_motion): Set and restore w->pointm when
2999 saving and restoring the window's buffer (Bug#9006).
3000
837c31f8
LMI
30012011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3002
3003 * editfns.c (Fstring_to_char): Clarify just what is returned
3004 (bug#6576). Text by Eli Zaretskii.
3005
ac389d0c
JB
30062011-07-13 Juanma Barranquero <lekktu@gmail.com>
3007
3008 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3009
0be0ce47
EZ
30102011-07-13 Eli Zaretskii <eliz@gnu.org>
3011
3012 * buffer.c (mmap_find): Fix a typo.
3013
cd18e7e3
JB
30142011-07-13 Johan Bockgård <bojohan@gnu.org>
3015
3016 Fix execution of x selection hooks.
3017 * xselect.c (Qx_lost_selection_functions)
3018 (Qx_sent_selection_functions): New vars.
3019 (syms_of_xselect): DEFSYM them.
3020 (x_handle_selection_request): Pass Qx_sent_selection_functions
3021 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3022 (x_handle_selection_clear,x_clear_frame_selections):
3023 Pass Qx_lost_selection_functions rather than
3024 Vx_lost_selection_functions to Frun_hook_with_args.
3025
47ea7f44
PE
30262011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3027
ac389d0c 3028 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3029 The old code sometimes used this field without initializing it.
3030
47ea7f44
PE
3031 * alloc.c (gc_sweep): Don't read past end of array.
3032 In theory, the old code could also have corrupted Emacs internals,
3033 though it'd be very unlikely.
3034
bc985c87
AS
30352011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3036
3037 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3038 argument. (Bug#4026)
bc985c87 3039
0cf34688
LMI
30402011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3041
b3dadd76
LMI
3042 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3043 key" (bug#4257).
3044
0cf34688
LMI
3045 * window.c (Fset_window_start): Doc fix (bug#4199).
3046 (Fset_window_hscroll): Ditto.
3047
270768cd
PE
30482011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3049
077e3dda 3050 Fix minor new problems caught by GCC 4.6.1.
270768cd 3051 * term.c (init_tty): Remove unused local.
490011a6 3052 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3053 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3054 not used otherwise.
270768cd 3055
b1f58454
CY
30562011-07-12 Chong Yidong <cyd@stupidchicken.com>
3057
3058 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3059
22b9578d
LMI
30602011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3061
6e70ab07
LMI
3062 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3063 are the mini-buffer and the echo area (bug#3320).
3064
22b9578d
LMI
3065 * term.c (init_tty): Remove support for supdup, c10 and perq
3066 terminals, which are no longer supported (bug#1482).
3067
8974cc9f
JB
30682011-07-10 Johan Bockgård <bojohan@gnu.org>
3069
3070 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3071
a560d974
JD
30722011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3073
3074 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3075 for non-popups (Bug#3642).
3076
1dae0f0a
AS
30772011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3078
268c2c36 3079 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3080 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3081 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3082 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3083 * data.c (fmod): Likewise.
3084 * dispnew.c (swap_glyphs_in_rows): Likewise.
3085 * emacs.c (memory_warning_signal): Likewise.
3086 * floatfns.c (float_error): Likewise.
3087 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3088 (otf_open, font_otf_capability, generate_otf_features)
3089 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3090 Likewise.
3091 * image.c (pbm_read_file): Likewise.
3092 * indent.c (string_display_width): Likewise.
3093 * intervals.c (check_for_interval, search_for_interval)
3094 (inc_interval_count, count_intervals, root_interval)
3095 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3096 * lread.c (defalias): Likewise.
268c2c36 3097 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3098 * regex.c (set_image_of_range_1, set_image_of_range)
3099 (regex_grow_registers): Likewise.
3100 * sysdep.c (strerror): Likewise.
3101 * termcap.c (valid_filename_p, tprint, main): Likewise.
3102 * tparam.c (main): Likewise.
3103 * unexhp9k800.c (run_time_remap, save_data_space)
3104 (update_file_ptrs, read_header, write_header, calculate_checksum)
3105 (copy_file, copy_rest, display_header): Likewise.
3106 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3107 Likewise.
3108 * xdisp.c (check_it): Likewise.
3109 * xfaces.c (register_color, unregister_color, unregister_colors):
3110 Likewise.
3111 * xfns.c (print_fontset_result): Likewise.
3112 * xrdb.c (member, fatal, main): Likewise.
3113
99033785
PE
31142011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3115
3116 Fix minor problems found by static checking (Bug#9031).
3117 * chartab.c (char_table_set_range, map_sub_char_table):
3118 Remove unused locals.
3119 (uniprop_table): Now static.
3120 * composite.c (_work_char): Remove unused static var.
3121
9cb2ac56
JB
31222011-07-09 Juanma Barranquero <lekktu@gmail.com>
3123
3124 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3125
f25661f0
JD
31262011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3127
3128 * gtkutil.c (qttip_cb): Remove code without function.
3129
8278c4fe
EZ
31302011-07-09 Eli Zaretskii <eliz@gnu.org>
3131
3132 * w32.c (pthread_sigmask): New stub.
3133
1692ae2d 31342011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3135
8a6ebd58 3136 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3137 sigprocmask is portable only for single-threaded applications, and
3138 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3139 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3140 (LIBES): Use it.
3141 * callproc.c (Fcall_process):
3142 * process.c (create_process):
3143 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3144 Use pthread_sigmask, not sigprocmask.
123403e4 3145
1b854618
JD
31462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3147
3148 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3149 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3150 wrong (Bug#8591).
3151
3fe4b549
JD
31522011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3153
0ce7e563
JD
3154 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3155 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3156 (xg_hide_tooltip): Fix comment.
3157
3fe4b549
JD
3158 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3159 in registerServicesMenuSendTypes.
3160 (validRequestorForSendType): Don't check ns_return_types.
3161
3162 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3163 ns_return_type.
3164
5df75e47
JR
31652011-07-08 Jason Rumney <jasonr@gnu.org>
3166
22610910
JR
3167 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3168 SH_SHOW for hidden windows (Bug#5482).
3169
5df75e47
JR
3170 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3171 frame struct members of non-existent frames (Bug#6284).
3172
699c10bd
JD
31732011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3174
4393663b
JD
3175 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3176 variable firstTime not needed on OSX >= 10.6.
3177 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3178 >= 10.5. Use setKnobProportion, setDoubleValue.
3179
3180 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3181 (MAC_OS_X_VERSION_10_5): Define if not defined.
3182 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3183 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3184 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3185
3186 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3187 cString and lossyCString on OSX >= 10.4
3188
58179cce 3189 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3190 sizeToFit on OSX >= 10.2.
3191
3192 * nsimage.m (allocInitFromFile): Don't use deprecated method
3193 bestRepresentationForDevice on OSX >= 10.6.
3194
3195 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3196 to avoid warning.
3197
3198 * emacs.c: Declare unexec_init_emacs_zone.
3199
a63e0781
JD
3200 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3201
699c10bd
JD
3202 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3203
3204 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3205 on svcsMenu (Bug#8842).
3206
3207 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3208 ns_return_types.
3209 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3210
3211 * nsterm.m (QUTF8_STRING): Declare.
3212 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3213 (validRequestorForSendType): Return type is (id).
3214 Change indexOfObjectIdenticalTo to indexOfObject.
3215 Check if we have local selection before returning self (Bug#8842).
3216 (writeSelectionToPasteboard): Put local selection into paste board
3217 if we have a local selection (Bug#8842).
3218 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3219
3220 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3221 (ns_get_local_selection): Declare.
3222
54e10184
LMI
32232011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3224
9888ff71
LMI
3225 * keymap.c (describe_map_tree): Don't insert a double newline at
3226 the end of the buffer (bug#1169) and return whether we inserted
3227 something.
3228
54e10184
LMI
3229 * callint.c (Fcall_interactively): Change "reading args" to
3230 "providing args" to try to clarify what it does (bug#1010).
3231
15fa4783
KH
32322011-07-07 Kenichi Handa <handa@m17n.org>
3233
3234 * composite.c (composition_compute_stop_pos): Ignore a static
3235 composition starting before CHARPOS (Bug#8915).
3236
3237 * xdisp.c (handle_composition_prop): Likewise.
3238
a8815b00
EZ
32392011-07-07 Eli Zaretskii <eliz@gnu.org>
3240
3241 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3242 (Bug#9015)
3243
ef7b981d 32442011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3245
3246 * character.h (unicode_category_t): New enum type.
3247
3248 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3249 (Qchar_code_property_table): New variable.
3250 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3251 (UNIPROP_COMPRESSED_FORM_P): New macros.
3252 (char_table_ascii): Uncompress the compressed values.
3253 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3254 Uncompress the compressed values.
ac389d0c 3255 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3256 (char_table_ref_and_range): Uncompress the compressed values.
3257 (sub_char_table_set): New arg is_uniprop. Callers changed.
3258 Uncompress the compressed values.
3259 (sub_char_table_set_range): Args changed. Callers changed.
3260 (char_table_set_range): Adjuted for the above change.
3261 (map_sub_char_table): Delete args default_val and parent. Add arg
3262 top. Give decoded values to a Lisp function.
640c8776 3263 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3264 values to a Lisp function. Gcpro more variables.
3265 (uniprop_table_uncompress)
3266 (uniprop_decode_value_run_length): New functions.
3267 (uniprop_decoder, uniprop_decoder_count): New variables.
3268 (uniprop_get_decoder, uniprop_encode_value_character)
3269 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3270 New functions.
3271 (uniprop_encoder, uniprop_encoder_count): New variables.
3272 (uniprop_get_encoder, uniprop_table)
3273 (Funicode_property_table_internal, Fget_unicode_property_internal)
3274 (Fput_unicode_property_internal): New functions.
3275 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3276 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3277 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3278 char-code-property-alist.
3279
640c8776 3280 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3281 Vunicode_category_table.
3282
640c8776 3283 * font.c (font_range): Adjust for the change of
c805dec0
KH
3284 Vunicode_category_table.
3285
76b397fb
DN
32862011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3287
3288 * m/iris4d.h: Remove file, move contents ...
3289 * s/irix6-5.h: ... here.
3290
22b4128e
PE
32912011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3292
3293 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3294 * alloc.c (mark_buffer):
3295 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3296 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3297 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3298 This isn't true in general, and it's particularly not true
3299 if Emacs is configured with --with-wide-int.
3300 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3301 New macros, used in the buffer.c change.
3302
869795d6
JD
33032011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3304
3305 * xsettings.c: Use both GConf and GSettings if both are available.
3306 (store_config_changed_event): Add comment.
3307 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3308 (store_tool_bar_style_changed): New functions.
5e617bc2 3309 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3310 (struct xsettings): Move font inside HAVE_XFT.
3311 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3312 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3313 Move inside HAVE_XFT.
640c8776 3314 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3315 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3316 also.
3317 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3318 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3319 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3320 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3321 (parse_settings): Move check for font inside HAVE_XFT.
3322 (read_settings, apply_xft_settings): Add comment.
3323 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3324 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3325 call store_font_name_changed.
3326 (xft_settings_event): Add comment.
3327 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3328 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3329 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3330 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3331 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3332 (xsettings_get_system_font, xsettings_get_system_normal_font):
3333 Add comment.
869795d6 3334
d8ed26bd
PE
33352011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3336
3337 Random fixes. E.g., (random) never returned negative values.
3338 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3339 subseconds part to the entropy, as that's a bit more random.
3340 Prefer signed to unsigned, since the signedness doesn't matter and
3341 in general we prefer signed. When given a limit, use a
3342 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3343 latter isn't right if USE_2_TAGS_FOR_INTS.
3344 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3345 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3346
cabf1cac
SM
33472011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3348
3349 * textprop.c (text_property_stickiness):
3350 Obey Vtext_property_default_nonsticky.
3351 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3352 * w32fns.c (syms_of_w32fns):
3353 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3354
6e9b2be9
PE
33552011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3356
3357 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3358 This is more efficient than Ffile_directory_p and avoids a minor race.
3359
90186c68
LMI
33602011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3361
7c301272
LMI
3362 * buffer.c (Foverlay_put): Say what the return value is
3363 (bug#7835).
3364
c4f2d8d4
LMI
3365 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3366 is a directory before asking whether to use the file name
3367 (bug#7564).
ad637907
LMI
3368 (barf_or_query_if_file_exists): Make the "File is a directory"
3369 error be more correct.
c4f2d8d4 3370
90186c68
LMI
3371 * fns.c (Frequire): Remove the mention of the .gz files, since
3372 that's installation-specific, but keep the mention of
3373 `get-load-suffixes'.
3374
da64016e
PE
33752011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3376
3377 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3378 Report string overflow if the output is too long.
3379
7d47b580
JB
33802011-07-04 Juanma Barranquero <lekktu@gmail.com>
3381
a555cb87
JB
3382 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3383 (syms_of_gnutls): Remove duplicate DEFSYM for
3384 Qgnutls_bootprop_verify_hostname_error, an error for
3385 Qgnutls_bootprop_verify_error (which is no longer used).
3386
7d47b580
JB
3387 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3388 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3389 Also (re)move comments that are misplaced or no longer relevant.
3390
1e49bfab
LMI
33912011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3392
3393 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3394
1485f4c0
CY
33952011-07-03 Chong Yidong <cyd@stupidchicken.com>
3396
3397 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3398 and background color parameters if they have been changed.
3399
a9ab721e
LMI
34002011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3401
3402 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3403
cf7cff57
PE
34042011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3405
2e13213d
PE
3406 * xsettings.c (SYSTEM_FONT): Define only when used.
3407 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3408
cf7cff57
PE
3409 * keymap.c (access_keymap_1): Now static.
3410
7a8e04f7
CY
34112011-07-02 Chong Yidong <cyd@stupidchicken.com>
3412
3413 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3414 leave any prefix arg for the up event (Bug#1586).
3415
61352f62
LMI
34162011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3417
69bb1ef7
LMI
3418 * lread.c (syms_of_lread): Mention single symbols defined by
3419 `defvar' or `defconst' (bug#7154).
3420
61352f62 3421 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3422 (Frequire): Mention get-load-suffixes.
61352f62 3423
28545e04
MR
34242011-07-02 Martin Rudalics <rudalics@gmx.at>
3425
3426 * window.h (window): Remove clone_number slot.
3427 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3428 Remove.
3429 (make_parent_window, make_window, saved_window)
3430 (Fset_window_configuration, save_window_save): Don't deal with
3431 clone numbers.
3432 * buffer.c (Qclone_number): Remove declaration.
3433 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3434
3349e122
SM
34352011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3436
3437 Add multiple inheritance to keymaps.
3438 * keymap.c (Fmake_composed_keymap): New function.
3439 (Fset_keymap_parent): Simplify.
3440 (fix_submap_inheritance): Remove.
3441 (access_keymap_1): New function extracted from access_keymap to handle
3442 embedded parents and handle lists of maps.
3443 (access_keymap): Use it.
3444 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3445 (Fcopy_keymap): Handle embedded parents.
3446 (Fcommand_remapping, define_as_prefix): Simplify.
3447 (Fkey_binding): Simplify.
3448 (syms_of_keymap): Move minibuffer-local-completion-map,
3449 minibuffer-local-filename-completion-map,
3450 minibuffer-local-must-match-map, and
3451 minibuffer-local-filename-must-match-map to Elisp.
3452 (syms_of_keymap): Defsubr make-composed-keymap.
3453 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3454 (parse_menu_item): Trivial simplification.
3455
3279eb87
GM
34562011-07-01 Glenn Morris <rgm@gnu.org>
3457
3458 * Makefile.in (SETTINGS_LIBS): Fix typo.
3459
4550efdf
KI
34602011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3461
3462 * coding.c (Fencode_coding_string): Record the last coding system
3463 used, as the function doc string says (bug#8738).
3464
0949d2b6
JD
34652011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3466
3467 * xsettings.c (store_monospaced_changed): Take new font as arg and
3468 check for change against current_mono_font.
3469 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3470 (emacs_settings_constructor, emacs_settings_get_property)
3471 (emacs_settings_set_property, emacs_settings_class_init)
3472 (emacs_settings_init, gsettings_obj): Remove.
3473 (something_changedCB): New function for HAVE_GSETTINGS.
3474 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3475 with value as argument.
3476 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3477 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3478 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3479 "changed".
3480
3481 * xgselect.c: Add defined (HAVE_GSETTINGS).
3482 (xgselect_initialize): Ditto.
3483
3484 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3485 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3486 xg_select.
3487
bbc6b304
PE
34882011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3489
3490 * eval.c (struct backtrace): Simplify and port the data structure.
3491 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3492 signed bit field, as this assumption is not portable and it makes
3493 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3494 "char debug_on_exit : 1" as this is not portable either; instead,
3495 use the portable "unsigned int debug_on_exit : 1". Remove unused
3496 member evalargs. Remove obsolete comments about cc bombing out.
3497
9851bfc5
JD
34982011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3499
51bb811f 3500 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3501 Let HAVE_GSETTINGS override HAVE_GCONF.
3502 (store_monospaced_changed): New function.
3503 (EMACS_SETTINGS): A new type derived from GObject to handle
3504 GSettings notifications.
3505 (emacs_settings_constructor, emacs_settings_get_property)
3506 (emacs_settings_set_property, emacs_settings_class_init):
3507 New functions.
3508 (gsettings_client, gsettings_obj): New variables.
3509 (GSETTINGS_SCHEMA): New define.
3510 (something_changedCB): Call store_monospaced_changed.
3511 (init_gsettings): New function.
3512 (xsettings_initialize): Call init_gsettings.
3513 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3514 to NULL.
3515
640c8776 3516 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3517 GCONF_CFLAGS/LIBS.
3518
5386012d
MR
35192011-06-29 Martin Rudalics <rudalics@gmx.at>
3520
3521 * window.c (resize_root_window, grow_mini_window)
3522 (shrink_mini_window): Rename Qresize_root_window to
3523 Qwindow_resize_root_window and Qresize_root_window_vertically to
3524 Qwindow_resize_root_window_vertically.
3525
f13e0b08
PE
35262011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3527
3528 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3529
94515237
JB
35302011-06-27 Juanma Barranquero <lekktu@gmail.com>
3531
3532 * makefile.w32-in: Redesign dependencies so they reflect more
3533 clearly which files are directly included by each source file,
3534 and not through other includes.
3535
e43b6e43
MR
35362011-06-27 Martin Rudalics <rudalics@gmx.at>
3537
3538 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3539 (sort_overlays, overlay_strings): When an overlay's clone number
3540 matches the window's clone number process the overlay even if
3541 the overlay's window property doesn't match the current window.
3542
d68443dc
MR
3543 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3544 (Fwindow_hchild): Rename to Fwindow_left_child.
3545 (Fwindow_next): Rename to Fwindow_next_sibling.
3546 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3547 (resize_window_check): Rename to window_resize_check.
3548 (resize_window_apply): Rename to window_resize_apply.
3549 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3550 (Fdelete_other_windows_internal, resize_frame_windows)
3551 (Fsplit_window_internal, Fdelete_window_internal)
3552 (grow_mini_window, shrink_mini_window)
3553 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3554
c7e73be5
JD
35552011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3556
3557 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3558 (emacs_fixed_set_min_size): Remove.
3559 (emacs_fixed_new): Take frame as argument.
3560
3561 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3562 (_EmacsFixedPrivate): Remove minwidth/height.
3563 Add struct frame *f.
3564 (emacs_fixed_init): Initialize priv->f.
3565 (get_parent_class, emacs_fixed_set_min_size): Remove.
3566 (emacs_fixed_new): Set priv->f to argument.
3567 (emacs_fixed_get_preferred_width)
3568 (emacs_fixed_get_preferred_height): Use min_width/height from
3569 frames size_hint to set minimum and natural (Bug#8919).
3570 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3571 and use min_width/height from frames size_hint to set
3572 min_width/height (Bug#8919).
3573
3574 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3575 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3576 Fix indentation.
c7e73be5 3577
cf99dcf8
EZ
35782011-06-26 Eli Zaretskii <eliz@gnu.org>
3579
3580 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3581 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3582 called at ZV.
3583
029529ac
CY
35842011-06-26 Chong Yidong <cyd@stupidchicken.com>
3585
3586 * process.c (wait_reading_process_output): Bypass select if
3587 waiting for a cell while ignoring keyboard input, and input is
3588 pending. Suggested by Jan Djärv (Bug#8869).
3589
7a7ef429
PE
35902011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3591
3592 Use gnulib's dup2 module instead of rolling our own.
3593 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3594
11fdef7d 35952011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3596
3597 * dispnew.c (scrolling_window): Before scrolling, turn off a
3598 mouse-highlight in the window being scrolled.
3599
cd3520a4
JB
36002011-06-24 Juanma Barranquero <lekktu@gmail.com>
3601
3602 Move DEFSYM to lisp.h and use everywhere.
3603
3604 * character.h (DEFSYM): Move declaration...
3605 * lisp.h (DEFSYM): ...here.
3606
3607 * gnutls.c:
3608 * minibuf.c:
3609 * w32menu.c:
3610 * w32proc.c:
3611 * w32select.c: Don't include character.h.
3612
3613 * alloc.c (syms_of_alloc):
3614 * buffer.c (syms_of_buffer):
3615 * bytecode.c (syms_of_bytecode):
3616 * callint.c (syms_of_callint):
3617 * casefiddle.c (syms_of_casefiddle):
3618 * casetab.c (init_casetab_once):
3619 * category.c (init_category_once, syms_of_category):
3620 * ccl.c (syms_of_ccl):
3621 * cmds.c (syms_of_cmds):
3622 * composite.c (syms_of_composite):
3623 * dbusbind.c (syms_of_dbusbind):
3624 * dired.c (syms_of_dired):
3625 * dispnew.c (syms_of_display):
3626 * doc.c (syms_of_doc):
3627 * editfns.c (syms_of_editfns):
3628 * emacs.c (syms_of_emacs):
3629 * eval.c (syms_of_eval):
3630 * fileio.c (syms_of_fileio):
3631 * fns.c (syms_of_fns):
3632 * frame.c (syms_of_frame):
3633 * fringe.c (syms_of_fringe):
3634 * insdel.c (syms_of_insdel):
3635 * keymap.c (syms_of_keymap):
3636 * lread.c (init_obarray, syms_of_lread):
3637 * macros.c (syms_of_macros):
3638 * msdos.c (syms_of_msdos):
3639 * print.c (syms_of_print):
3640 * process.c (syms_of_process):
3641 * search.c (syms_of_search):
3642 * sound.c (syms_of_sound):
3643 * syntax.c (init_syntax_once, syms_of_syntax):
3644 * terminal.c (syms_of_terminal):
3645 * textprop.c (syms_of_textprop):
3646 * undo.c (syms_of_undo):
3647 * w32.c (globals_of_w32):
3648 * window.c (syms_of_window):
3649 * xdisp.c (syms_of_xdisp):
3650 * xfaces.c (syms_of_xfaces):
3651 * xfns.c (syms_of_xfns):
3652 * xmenu.c (syms_of_xmenu):
3653 * xsettings.c (syms_of_xsettings):
3654 * xterm.c (syms_of_xterm): Use DEFSYM.
3655
4228cf16
TZ
36562011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3657
cd3520a4 3658 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3659
7fcccf1e
PE
36602011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3661
7efb4e0e
PE
3662 Integer and buffer overflow fixes (Bug#8873).
3663
ff5844ad
PE
3664 * print.c (printchar, strout): Check for string overflow.
3665 (PRINTPREPARE, printchar, strout):
3666 Don't set size unless allocation succeeds.
3667
90532f02
PE
3668 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3669 for sizes. Check for string overflow more accurately.
3670 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3671
6d84508d
PE
3672 * macros.c: Integer and buffer overflow fixes.
3673 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3674 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3675 Use ptrdiff_t, not int, for sizes.
3676 Don't increment bufsize until after realloc succeeds.
3677 Check for size-calculation overflow.
3678 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3679
437b2cb4
PE
3680 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3681
8b9ac8b4
PE
3682 * lread.c: Integer overflow fixes.
3683 (read_integer): Radix is now EMACS_INT, not int,
3684 to improve quality of diagnostics for out-of-range radices.
3685 Calculate buffer size correctly for out-of-range radices.
3686 (read1): Check for integer overflow in radices, and in
3687 read-circle numbers.
82cb60d3
PE
3688 (read_escape): Avoid int overflow.
3689 (Fload, openp, read_buffer_size, read1)
3690 (substitute_object_recurse, read_vector, read_list, map_obarray):
3691 Use ptrdiff_t, not int, for sizes.
3692 (read1): Use EMACS_INT, not int, for sizes.
20270765 3693 Check for size overflow.
8b9ac8b4 3694
7fcccf1e
PE
3695 * image.c (cache_image): Check for size arithmetic overflow.
3696
bfbbd7e7
PE
3697 * lread.c: Integer overflow issues.
3698 (saved_doc_string_size, saved_doc_string_length)
3699 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3700 Now ptrdiff_t, not int.
3701 (read1): Don't assume doc string length fits in int. Check for
3702 out-of-range doc string lengths.
3703 (read_list): Don't assume file position fits in int.
39019e54 3704 (read_escape): Check for hex character overflow.
bfbbd7e7 3705
4e323265
LL
37062011-06-22 Leo Liu <sdl.web@gmail.com>
3707
3708 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3709 Move to minibuffer.el.
3710
85fece3e
PE
37112011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3712
20b84ce9 3713 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3714 The following patches are for when GLYPH_DEBUG && !XASSERT.
3715 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3716 * dispnew.c (flush_stdout):
3717 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3718 Mark as externally visible.
3719 * dispnew.c (check_window_matrix_pointers): Now static.
3720 * dispnew.c (window_to_frame_vpos):
3721 * xfns.c (unwind_create_frame):
3722 * xterm.c (x_check_font): Remove unused local.
3723 * scroll.c (CHECK_BOUNDS):
3724 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3725 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3726 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3727 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3728 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3729 Now static.
3730 (debug_method_add): Use va_list and vsprintf rather than relying
3731 on undefined behavior with wrong number of arguments.
3732 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3733 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3734 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3735 since we're not interested in debugging glyphs with old libraries.
3736 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3737 GCC 4.6.0's static checking.
3738
0766b489
PE
37392011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3740
31fd4b32
PE
3741 Integer overflow and signedness fixes (Bug#8873).
3742 A few related buffer overrun fixes, too.
3743
b79e8648
PE
3744 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3745
0766b489
PE
3746 * dispextern.h (struct face.stipple):
3747 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3748 (x_bitmap_mask, x_allocate_bitmap_record)
3749 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3750 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3751 (x_create_bitmap_from_xpm_data):
3752 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3753 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3754 (.bitmaps_last):
3755 * xfaces.c (load_pixmap):
3756 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3757 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3758 (.bitmaps_last, struct x_output.icon_bitmap):
3759 Use ptrdiff_t, not int, for bitmap indexes.
3760 (x_allocate_bitmap_record): Check for size overflow.
3761 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3762
b081724f
PE
3763 Use ptrdiff_t, not int, for overlay counts.
3764 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3765 * editfns.c (overlays_around, get_pos_property):
3766 * textprop.c (get_char_property_and_overlay):
3767 * xdisp.c (next_overlay_change, note_mouse_highlight):
3768 * xfaces.c (face_at_buffer_position):
21514da7
PE
3769 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3770 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3771 (Fnext_overlay_change, Fprevious_overlay_change)
3772 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3773 Use ptrdiff_t, not int, for sizes.
21514da7 3774 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3775
3de73e5e
PE
3776 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3777
2606c57b
PE
3778 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3779 (x_session_initialize): Do not assume string length fits in int.
3780
aaafe47a
PE
3781 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3782 This is unlikely, but can occur if DPI is outlandish.
3783
2674ddc8 3784 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3785 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3786
28154962
PE
3787 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3788 * xrdb.c (magic_file_p, search_magic_path):
3789 Omit last arg SUFFIX; it was always 0. All callers changed.
3790 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3791
7de51af5
PE
3792 * xfont.c (xfont_match): Avoid need for strlen.
3793
25ed6cc3
PE
3794 * xfns.c: Don't assume strlen fits in int.
3795 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3796
4eab31dd
PE
3797 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3798 not unsigned long, as we prefer signed integers. All callers changed.
3799 Detect integer overflow in repeat count.
3800 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3801 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3802
171e2a58
PE
3803 * termcap.c: Don't assume sizes fit in int and never overflow.
3804 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3805 (gobble_line): Check for size-calculation overflow.
3806
ad39faca 3807 * minibuf.c (Fread_buffer):
6e5bb2dc 3808 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3809 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3810 Don't assume string length fits in int.
3811
52c61c22 3812 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3813 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3814
b5b8c9e5
PE
3815 * font.c: Don't assume string length fits in int.
3816 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3817 Use ptrdiff_t, not int.
ccd6111c
PE
3818 (font_intern_prop): Don't assume string length fits in int.
3819 Don't assume integer property fits in fixnum.
3820 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3821
882f0d81 3822 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3823 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3824 Reformulate so as not to need the command string.
3825 Invoke gzip -cd rather than gunzip, as it's more portable.
3826 (lock_info_type, lock_file_1, lock_file):
3827 Don't assume pid_t and time_t fit in unsigned long.
3828 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3829 (current_lock_owner): Prefer signed type for sizes.
3830 Use memcpy, not strncpy, where memcpy is what is really wanted.
3831 Don't assume (via atoi) that time_t and pid_t fit in int.
3832 Check for time_t and/or pid_t out of range, e.g., via a network share.
3833 Don't alloca where an auto var works fine.
3834
93f4cf88
PE
3835 * fileio.c: Fix some integer overflow issues.
3836 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3837 Don't assume string length fits in int.
3838 (directory_file_name): Don't assume string length fits in long.
3839 (make_temp_name): Don't assume pid fits in int, or that its print
3840 length is less than 20.
3841
f3e92b69
PE
3842 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3843
1bfdaf10
PE
3844 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3845
35016e9a
PE
3846 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3847
3d1e65a1
PE
3848 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3849 We prefer signed integers, even for size calculations.
3850
0b963a93
PE
3851 * emacs.c: Don't assume string length fits in 'int'.
3852 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3853 (main): Don't invoke strlen when not needed.
3854
573f4b54
PE
3855 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3856 (XD_DEBUG_MESSAGE): Don't waste a byte.
3857
989f33ba
PE
3858 * callproc.c (getenv_internal_1, getenv_internal)
3859 (Fgetenv_internal):
965d34eb
PE
3860 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3861
e4d29b33
PE
3862 * lread.c (invalid_syntax): Omit length argument.
3863 All uses changed. This doesn't fix a bug, but it simplifies the
3864 code away from its former Hollerith-constant appearance, and it's
3865 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3866 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3867
eb49b136
PE
3868 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3869 This didn't break anything, but it didn't help either.
3870 It's confusing to put a bogus integer in a place where the actual
3871 value does not matter.
9f62aeb1 3872 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3873 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3874
15375a22
PE
3875 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3876 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3877 implementation.
b61cc01c
PE
3878 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3879 We prefer signed types, and the value cannot exceed the EMACS_INT
3880 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3881 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3882 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3883 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3884
53b2623d
PE
3885 * indent.c (sane_tab_width): New function.
3886 (current_column, scan_for_column, Findent_to, position_indentation)
3887 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3888 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3889
51cab52b 3890 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3891
f2ed8a70
PE
3892 * lisp.h (lint_assume): New macro.
3893 * composite.c (composition_gstring_put_cache):
3894 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3895
abe80cc6
PE
3896 * editfns.c, insdel.c:
3897 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3898
b02c740e
PE
3899 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3900
ebc96716
PE
3901 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3902
b4e50fa0 3903 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3904 Use much-faster test for byte-length change.
311d5d7c 3905 Don't assume string byte-length fits in 'int'.
a4cf38e4 3906 Check that character arg fits in 'int'.
85461888 3907 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3908
c0c1ee9f
PE
3909 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3910
a498d7f4
PE
3911 * fns.c (concat): Catch string overflow earlier.
3912 Do not rely on integer wraparound.
3913
51cab52b
PE
3914 * dispextern.h (struct it.overlay_strings_charpos)
3915 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3916 * xdisp.c (forward_to_next_line_start)
3917 (back_to_previous_visible_line_start)
3918 (reseat_at_next_visible_line_start, next_element_from_buffer):
3919 Don't arbitrarily truncate the value of 'selective' to int.
3920
76031fad
PE
3921 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3922
5eb55db9
PE
3923 * composite.c: Don't truncate sizes to 'int'.
3924 (composition_gstring_p, composition_reseat_it)
3925 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3926 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3927 not EMACS_UINT, for indexes.
5eb55db9 3928
0703a717
PE
3929 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3930
d6202519
PE
3931 * buffer.c: Include <verify.h>.
3932 (struct sortvec.priority, struct sortstr.priority):
8961a454 3933 Now EMACS_INT, not int.
c20998a7 3934 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3935 (struct sortstr.size, record_overlay_string)
3936 (struct sortstrlist.size, struct sortlist.used):
3937 Don't truncate size to int.
3938 (record_overlay_string): Check for size-calculation overflow.
d6202519 3939 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3940
d5a19415
JM
39412011-06-22 Jim Meyering <meyering@redhat.com>
3942
029529ac 3943 Don't leak an XBM-image-sized buffer
d5a19415
JM
3944 * image.c (xbm_load): Free the image buffer after using it.
3945
a9041e6c
PE
39462011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3947
3948 Port to Sun C.
3949 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3950 that Sun C diagnosed.
3951 * fns.c (secure_hash): Fix pointer signedness issue.
3952 * intervals.c (static_offset_intervals): New function.
3953 (offset_intervals): Use it.
3954
7f3f739f
LL
39552011-06-21 Leo Liu <sdl.web@gmail.com>
3956
3957 * deps.mk (fns.o):
3958 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3959 sha512.h.
3960
3961 * fns.c (secure_hash): Rename from crypto_hash_function and change
3962 the first arg to accept symbols.
5b66d427 3963 (Fsecure_hash): New primitive.
7f3f739f
LL
3964 (syms_of_fns): New symbols.
3965
76147d94
DD
39662011-06-20 Deniz Dogan <deniz@dogan.se>
3967
3968 * process.c (Fset_process_buffer): Clarify return value in
3969 docstring.
3970
7d7d0045
CY
39712011-06-18 Chong Yidong <cyd@stupidchicken.com>
3972
3973 * dispnew.c (add_window_display_history): Use BVAR.
3974
3975 * xdisp.c (debug_method_add): Use BVAR.
3976 (check_window_end, dump_glyph_matrix, dump_glyph)
3977 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3978
3979 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3980 Likewise.
3981
3982 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3983 check till after the cache is created in init_frame_faces.
3984
ff2bc410
SM
39852011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3986
3987 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3988
28177add
PE
39892011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3990
dd3482fe
PE
3991 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3992 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3993 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3994
393d71f3 3995 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3996 * fileio.c (Finsert_file_contents):
3997 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3998 Remove the old (too-loose) buffer overflow checks.
3999 They weren't needed, since make_gap checks for buffer overflow.
4000 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4001 The old code merely checked for Emacs fixnum overflow, and relied
4002 on undefined (wraparound) behavior. The new code avoids undefined
4003 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4004
2e6813b0 4005 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4006 Tune. Don't use wider integers than needed. Don't use alloca.
4007 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4008
599a9e4f
PE
4009 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4010
99561444
PE
4011 * insdel.c, lisp.h (buffer_overflow): New function.
4012 (insert_from_buffer_1, replace_range, replace_range_2):
4013 * insdel.c (make_gap_larger):
4014 * editfns.c (Finsert_char):
4015 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4016
28177add
PE
4017 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4018
e69dafad
PE
40192011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4020
a7af7fde 4021 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4022
b1c46f02
PE
4023 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4024 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4025
e69dafad
PE
4026 * fileio.c: Don't assume EMACS_INT fits in off_t.
4027 (emacs_lseek): New static function.
4028 (Finsert_file_contents, Fwrite_region): Use it.
4029 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4030
566684ea
PE
4031 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4032
e6966cd6
PE
4033 * fns.c: Don't overflow int when computing a list length.
4034 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4035 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4036 truncation on 64-bit hosts. Check for QUIT every
4037 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4038 faster and is responsive enough.
4039 (Flength): Report an error instead of overflowing an integer.
4040 (Fsafe_length): Return a float if the value is not representable
4041 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4042 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4043 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4044
dd0b0efb
PE
4045 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4046 (header_size, word_size): New constants.
4047 (allocate_vectorlike): Don't check size overflow here.
4048 (allocate_vector): Check it here instead, since this is the only
4049 caller of allocate_vectorlike that could cause overflow.
4050 Check that the new vector's length is representable as a fixnum.
4051
86fe5cfe
PE
4052 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4053 The previous code was bogus. For example, next_almost_prime (32)
4054 returned 39, which is undesirable as it is a multiple of 3; and
4055 next_almost_prime (24) returned 25, which is a multiple of 5 so
4056 why was the code bothering to check for multiples of 7?
4057
80e88859
PE
4058 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4059
4a2f0ad6
PE
4060 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4061
f66c7cf8
PE
4062 Variadic C functions now count arguments with ptrdiff_t.
4063 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4064 Back then I didn't know that the Emacs coding style prefers signed int.
4065 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4066 were being counted with int, which may truncate counts on 64-bit
4067 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4068 * lisp.h (struct Lisp_Subr.function.aMANY)
4069 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4070 Arg counts are now ptrdiff_t, not size_t.
4071 All variadic functions and their callers changed accordingly.
4072 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4073 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4074 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4075 * callint.c (Fcall_interactively): Check arg count for overflow,
4076 to avoid potential buffer overrun. Use signed char, not 'int',
4077 for 'varies' array, so that we needn't bother to check its size
4078 calculation for overflow.
4079 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4080 * eval.c (apply_lambda):
4081 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4082 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4083 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4084
a1759b76
PE
4085 * callint.c (Fcall_interactively): Don't use index var as event count.
4086
d96be9fc
PE
4087 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4088 * mem-limits.h (SIZE): Remove; no longer used.
4089
a690a978 4090 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4091
578c21e6
PE
4092 Remove unnecessary casts.
4093 * xterm.c (x_term_init):
4094 * xfns.c (x_set_border_pixel):
4095 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4096 These aren't needed now that we assume ANSI C.
4097
96f53c6c
PE
4098 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4099 It's more likely to cause problems (due to unsigned overflow)
4100 than to cure them.
4101
83c77d31
PE
4102 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4103
ee2079f1
PE
4104 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4105
6da65536
PE
4106 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4107
7147c4a4
PE
4108 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4109
193e32d9
PE
4110 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4111
e5533da6
PE
4112 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4113
9910e595
PE
4114 GLYPH_CODE_FACE returns EMACS_INT, not int.
4115 * dispextern.h (merge_faces):
4116 * xfaces.c (merge_faces):
01103c44
PE
4117 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4118 Don't assume EMACS_INT fits in int.
9910e595 4119
2638320e
PE
4120 * character.h (CHAR_VALID_P): Remove unused parameter.
4121 * fontset.c, lisp.h, xdisp.c: All uses changed.
4122
045eb8d9
PE
4123 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4124
c1f134b5
PE
4125 * fns.c (concat): Minor tuning based on overflow analysis.
4126 This doesn't fix any bugs. Use int to hold character, instead
4127 of constantly refetching from Emacs object. Use XFASTINT, not
4128 XINT, for value known to be a character. Don't bother comparing
4129 a single byte to 0400, as it's always less.
4130
395fcb93 4131 * floatfns.c (Fexpt):
327eeec8
PE
4132 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4133
abbd3d23
PE
4134 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4135 for characters.
4136
684a03ef
PE
4137 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4138
0fed43f3
PE
4139 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4140 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4141 incorrectly succeed when S was a string, because 4294967386 was
4142 truncated before it was used.
4143
8fd02eb7
PE
4144 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4145 Otherwise, an out-of-range integer could cause undefined behavior
4146 on a 64-bit host.
4147
f8c86b69
PE
4148 * composite.c: Use int, not EMACS_INT, for characters.
4149 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4150 EMACS_INT, for values that are known to be in character range.
4151 This doesn't fix any bugs but is the usual style inside Emacs and
4152 may generate better code on 32-bit machines.
4153
34206dd2
PE
4154 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4155 This is for reasons similar to the recent CHAR_STRING fix.
4156 * charset.c (Fencode_char): Check that character arg is actually
4157 a character. Pass an int to ENCODE_CHAR.
4158 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4159 wider than 'int', as a compile-time check to prevent future regressions
4160 in this area.
4161
c5958d4c 4162 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4163
4164 Make sure a 64-bit char is never passed to CHAR_STRING.
4165 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4166 by silently ignoring the top 32 bits, allowing some values
4167 that were far too large to be valid characters.
4168 * character.h: Include <verify.h>.
4169 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4170 arguments are no wider than unsigned, as a compile-time check
4171 to prevent future regressions in this area.
4172 * data.c (Faset):
01103c44 4173 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4174 (Fsubst_char_in_region):
4175 * fns.c (concat):
4176 * xdisp.c (decode_mode_spec_coding):
4177 Adjust to CHAR_STRING's new requirement.
4178 * editfns.c (Finsert_char, Fsubst_char_in_region):
4179 * fns.c (concat): Check that character args are actually
4180 characters. Without this test, these functions did the wrong
4181 thing with wildly out-of-range values on 64-bit hosts.
4182
d37ca623
PE
4183 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4184 These casts should not be needed on 32-bit hosts, either.
4185 * keyboard.c (read_char):
4186 * lread.c (Fload): Remove casts to unsigned.
4187
ea204efb
PE
4188 * lisp.h (UNSIGNED_CMP): New macro.
4189 This fixes comparison bugs on 64-bit hosts.
4190 (ASCII_CHAR_P): Use it.
4191 * casefiddle.c (casify_object):
01103c44 4192 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4193 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4194 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4195 * dispextern.h (FACE_FROM_ID):
4196 * keyboard.c (read_char): Use UNSIGNED_CMP.
4197
41cb286c
PE
4198 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4199 not to EMACS_INT, to avoid GCC warning.
4200
4a1b9832
PE
4201 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4202
55daad71
PE
4203 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4204 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4205 isn't needed on 32-bit machines.
8f95c75c 4206
01103c44
PE
4207 * buffer.c (Fgenerate_new_buffer_name):
4208 Use EMACS_INT for count, not int.
0ceccced 4209 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4210
4211 * data.c (Qcompiled_function): Now static.
4212
c6f072e7
PE
4213 * window.c (window_body_lines): Now static.
4214
20ce5912
PE
4215 * image.c (gif_load): Rename local to avoid shadowing.
4216
9c4c5f81
PE
4217 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4218 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4219 * alloc.c (make_save_value): Integer argument is now of type
4220 ptrdiff_t, not int.
4221 (mark_object): Use ptrdiff_t, not int.
4222 * lisp.h (pD): New macro.
4223 * print.c (print_object): Use it.
4224
c0c5c8ae
PE
4225 * alloc.c: Use EMACS_INT, not int, to count objects.
4226 (total_conses, total_markers, total_symbols, total_vector_size)
4227 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4228 (total_free_floats, total_floats, total_free_intervals)
4229 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4230 Now EMACS_INT, not int. All uses changed.
4231 (Fgarbage_collect): Compute overall total using a double, so that
4232 integer overflow is less likely to be a problem. Check for overflow
4233 when converting back to an integer.
5a25e253
PE
4234 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4235 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4236 These were 'int' variables that could overflow on 64-bit hosts;
4237 they were never used, so remove them instead of repairing them.
211a0b2a 4238 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4239 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4240 Previously, this ceilinged at INT_MAX, but that doesn't work on
4241 64-bit machines.
e46bb31a 4242 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4243
c78baabf 4244 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4245 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4246 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4247 when a (possibly-narrower) signed value would do just as well.
4248 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4249
c9d624c6
PE
4250 * alloc.c: Catch some string size overflows that we were missing.
4251 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4252 for convenience in STRING_BYTES_MAX.
4253 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4254 The definition here is exact; the one in lisp.h was approximate.
4255 (allocate_string_data): Check for string overflow. This catches
4256 some instances we weren't catching before. Also, it catches
4257 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4258 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4259 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4260
c9d624c6
PE
4261 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4262 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4263 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4264
353032ce
PE
4265 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4266
2bccce07
PE
4267 * alloc.c (Fmake_string): Check for out-of-range init.
4268
0ac30604
SM
42692011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4270
4271 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4272
c195f2de
JD
42732011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4274
4275 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4276 xg_get_default_scrollbar_width.
4277
4278 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4279 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4280 (style_changed_cb): Call update_theme_scrollbar_width and call
4281 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4282 all frames (Bug#8505).
4283 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4284 Call gtk_window_set_resizable if HAVE_GTK3.
4285 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4286 and height if HAVE_GTK3 (Bug#8505).
4287 (scroll_bar_width_for_theme): New variable.
4288 (update_theme_scrollbar_width): New function.
4289 (xg_get_default_scrollbar_width): Move code to
4290 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4291 (xg_initialize): Call update_theme_scrollbar_width.
4292
4293 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4294
4295 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4296
e10ac9f1
MR
42972011-06-12 Martin Rudalics <rudalics@gmx.at>
4298
4299 * frame.c (make_frame): Call other_buffer_safely instead of
4300 other_buffer.
4301
4302 * window.c (temp_output_buffer_show): Call display_buffer with
4303 second argument Vtemp_buffer_show_specifiers and reset latter
4304 immediately after the call.
4305 (Vtemp_buffer_show_specifiers): New variable.
4306 (auto_window_vscroll_p, next_screen_context_lines)
4307 (Vscroll_preserve_screen_position): Remove leading asterisks from
4308 doc-strings.
4309
2d3c217e 43102011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4311
7b7f97e8 4312 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4313 * buffer.c (Qclone_number): Remove for now, as it's unused.
4314 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4315 (record_buffer): Remove unused local.
4316 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4317 (set_frame_buffer_list): Remove; unused.
4318 * frame.h (other_visible_frames): Remove decl.
4319 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4320 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4321 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4322 if HAVE_GPM.
4323 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4324 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4325 Define only if HAVE_GPM.
4326 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4327 (update_hints_inhibit): Remove; never set. All uses removed.
4328 * widgetprv.h (emacsFrameClassRec): Remove decl.
4329 * window.c (delete_deletable_window): Now returns void, since it
4330 wasn't returning anything.
4331 (compare_window_configurations): Remove unused locals.
4332 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4333 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4334 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4335 the same widths as pointers. This follows up on the 2011-05-06 patch.
4336 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4337 * xterm.h: Likewise.
4338 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4339
1384b89e
JB
43402011-06-12 Juanma Barranquero <lekktu@gmail.com>
4341
4342 * makefile.w32-in: Update dependencies.
4343 (LISP_H): Add lib/intprops.h.
4344
1100a63c
CY
43452011-06-11 Chong Yidong <cyd@stupidchicken.com>
4346
4347 * image.c (gif_load): Add animation frame delay to the metadata.
4348 (syms_of_image): Use DEFSYM. New symbol `delay'.
4349
6198ccd0
MR
43502011-06-11 Martin Rudalics <rudalics@gmx.at>
4351
4352 * window.c (delete_deletable_window): Re-add.
4353 (Fset_window_configuration): Rewrite to handle dead buffers and
4354 consequently deletable windows.
4355 (window_tree, Fwindow_tree): Remove. Supply functionality in
4356 window.el.
4357 (compare_window_configurations): Simplify code.
4358
b6e3633c
AS
43592011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4360
1ab0dee5
AS
4361 * image.c (imagemagick_load_image): Fix type mismatch.
4362 (Fimagemagick_types): Likewise.
4363
b6e3633c
AS
4364 * window.h (replace_buffer_in_windows): Declare.
4365
9397e56f
MR
43662011-06-11 Martin Rudalics <rudalics@gmx.at>
4367
4368 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4369 Qclone_number. Remove external declaration of Qdelete_window.
4370 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4371 code.
640c8776
SM
4372 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4373 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4374 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4375 buffer list implementation.
4376 (other_buffer_safely): New function.
4377 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4378 calls to replace_buffer_in_windows and
4379 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4380 if allowed.
4381 (record_buffer): Inhibit quitting and rewrite using quittable
4382 functions. Run Qbuffer_list_update_hook if allowed.
4383 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4384 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4385 Move switch-to-buffer to window.el.
9397e56f
MR
4386 (bury-buffer): Move to window.el.
4387 (Vbuffer_list_update_hook): New variable.
4388
4389 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4390 section.
4391
4392 * window.h (resize_frame_windows): Move up in code.
4393 (Fwindow_frame): Remove EXFUN.
4394 (replace_buffer_in_all_windows): Remove prototype.
4395 (replace_buffer_in_windows_safely): Add prototype.
4396
4397 * window.c: Declare Qdelete_window static again. Move down
4398 declaration of select_count.
4399 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4400 (Fother_window): Move to window.el.
4401 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4402 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4403 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4404 window.el.
4405 (replace_buffer_in_windows): Implement by calling
4406 Qreplace_buffer_in_windows.
4407 (replace_buffer_in_all_windows): Remove with some functionality
4408 moved into replace_buffer_in_windows_safely.
4409 (replace_buffer_in_windows_safely): New function.
4410 (select_window_norecord, select_frame_norecord): Move in front
4411 of run_window_configuration_change_hook. Remove now obsolete
4412 declarations.
640c8776
SM
4413 (Fset_window_buffer): Rewrite doc-string.
4414 Call Qrecord_window_buffer.
9397e56f
MR
4415 (keys_of_window): Move binding for other-window to window.el.
4416
b50691aa
CY
44172011-06-11 Chong Yidong <cyd@stupidchicken.com>
4418
4419 * dispextern.h (struct image): Replace data member, whose int_val
4420 and ptr_val fields were not used by anything, with a single
4421 lisp_val object.
4422
4423 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4424 (gif_clear_image, gif_load, imagemagick_load_image)
4425 (gs_clear_image, gs_load): Callers changed.
4426
3f754b86
PE
44272011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4428
cca69397
PE
4429 * buffer.h: Include <time.h>, for time_t.
4430 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4431
109e28d0
PE
4432 Fix minor problems found by static checking.
4433
60737f02
PE
4434 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4435
4b66faf3
PE
4436 Make identifiers static if they are not used in other modules.
4437 * data.c (Qcompiled_function, Qframe, Qvector):
4438 * image.c (QimageMagick, Qsvg):
4439 * minibuf.c (Qmetadata):
4440 * window.c (resize_window_check, resize_root_window): Now static.
4441 * window.h (resize_window_check, resize_root_window): Remove decls.
4442
109e28d0
PE
4443 * window.c (window_deletion_count, delete_deletable_window):
4444 Remove; unused.
46a4ce9e
PE
4445 (window_body_lines): Now static.
4446 (Fdelete_other_windows_internal): Mark vars as initialized.
4447 Make sure 'resize_failed' is initialized.
4448 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4449 (resize_window_apply): Remove unused local.
4450 * window.h (delete_deletable_window): Remove decl.
4451
109e28d0 4452 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4453 (imagemagick_load_image): Fix pointer signedness problem by changing
4454 last arg from unsigned char * to char *. All uses changed.
4455 Also, fix a local for similar reasons.
4456 Remove unused locals. Remove locals to avoid shadowing.
4457 (fn_rsvg_handle_free): Remove; unused.
4458 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4459 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4460
3f754b86
PE
4461 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4462
2547adb1
CY
44632011-06-10 Chong Yidong <cyd@stupidchicken.com>
4464
4465 * image.c (gif_load): Fix omitted cast error introduced by
4466 2011-06-06 change.
4467
2c8e37d4
MR
44682011-06-10 Martin Rudalics <rudalics@gmx.at>
4469
4470 * window.h (resize_proportionally, orig_total_lines)
4471 (orig_top_line): Remove from window structure.
4472 (set_window_height, set_window_width, change_window_heights)
4473 (Fdelete_window): Remove prototypes.
4474 (resize_frame_windows): Remove duplicate declaration.
4475
440a42e3
EZ
44762011-06-10 Eli Zaretskii <eliz@gnu.org>
4477
4478 * window.h (resize_frame_windows, resize_window_check)
4479 (delete_deletable_window, resize_root_window)
4480 (resize_frame_windows): Declare prototypes.
4481
4482 * window.c (resize_window_apply): Make definition be "static" to
4483 match the prototype.
4484
562dd5e9
MR
44852011-06-10 Martin Rudalics <rudalics@gmx.at>
4486
4487 * window.c: Remove declarations of Qwindow_size_fixed,
4488 window_min_size_1, window_min_size_2, window_min_size,
4489 size_window, window_fixed_size_p, enlarge_window, delete_window.
4490 Remove static from declaration of Qdelete_window, it's
4491 temporarily needed by Fbury_buffer.
4492 (replace_window): Don't assign orig_top_line and
4493 orig_total_lines.
4494 (Fdelete_window, delete_window): Remove. Window deletion is
4495 handled by window.el.
640c8776
SM
4496 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4497 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4498 (Fdelete_other_windows): Remove. Deleting other windows is
4499 handled by window.el.
4500 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4501 handled in window.el.
4502 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4503 Window minimum sizes are handled in window.el.
4504 (shrink_windows, size_window, set_window_height)
4505 (set_window_width, change_window_heights, window_height)
4506 (window_width, CURBEG, CURSIZE, enlarge_window)
4507 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4508 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4509 handled in window.el.
4510 (make_dummy_parent): Rename to make_parent_window and give it a
4511 second argument horflag.
4512 (make_window): Don't set resize_proportionally any more.
4513 (Fsplit_window): Remove. Windows are split in window.el.
4514 (save_restore_action, save_restore_orig_size)
4515 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4516 Resize mini windows in window.el.
4517 (grow_mini_window, shrink_mini_window): Implement by calling
4518 Qresize_root_window_vertically, resize_window_check and
4519 resize_window_apply.
640c8776
SM
4520 (saved_window, Fset_window_configuration, save_window_save):
4521 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4522 resize_proportionally.
4523 (window_min_height, window_min_width): Move to window.el.
4524 (keys_of_window): Move bindings for delete-other-windows,
4525 split-window, delete-window and enlarge-window to window.el.
4526
4527 * buffer.c: Temporarily extern Qdelete_window.
4528 (Fbury_buffer): Temporarily call Qdelete_window instead of
4529 Fdelete_window (Fbury_buffer will move to window.el soon).
4530
4531 * frame.c (set_menu_bar_lines_1): Remove code handling
4532 orig_top_line and orig_total_lines.
4533
4534 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4535 set_window_height but set heights directly.
4536 (change_frame_size_1): Use resize_frame_windows.
4537
4538 * xdisp.c (init_xdisp): Don't use set_window_height but set
4539 heights directly.
4540
640c8776
SM
4541 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4542 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4543 run_window_configuration_change_hook.
4544
4545 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4546 instead of change_window_heights and run
4547 run_window_configuration_change_hook.
4548
1a13852e
MR
45492011-06-09 Martin Rudalics <rudalics@gmx.at>
4550
4551 * window.c (replace_window): Rename second argument REPLACEMENT to
4552 NEW. New third argument SETFLAG. Rewrite.
4553 (delete_window, make_dummy_parent): Call replace_window with
4554 third argument 1.
4555 (window_list_1): Move down in code.
4556 (run_window_configuration_change_hook): Move set_buffer part
4557 before select_frame_norecord part in order to unwind correctly.
4558 Rename count1 to count.
4559 (recombine_windows, delete_deletable_window, resize_root_window)
4560 (Fdelete_other_windows_internal)
4561 (Frun_window_configuration_change_hook, make_parent_window)
4562 (resize_window_check, resize_window_apply, Fresize_window_apply)
4563 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4564 (Fdelete_window_internal, Fresize_mini_window_internal):
4565 New functions.
1a13852e
MR
4566 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4567
f3d1777e
MR
45682011-06-08 Martin Rudalics <rudalics@gmx.at>
4569
496e208e
MR
4570 * window.h (window): Add some new members to window structure -
4571 normal_lines, normal_cols, new_total, new_normal, clone_number,
4572 splits, nest, prev_buffers, next_buffers.
4573 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4574 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4575
f3d1777e
MR
4576 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4577 Remove.
496e208e
MR
4578 (make_dummy_parent): Set new members of windows structure.
4579 (make_window): Move down in code. Handle new members of window
4580 structure.
4581 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4582 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4583 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4584 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4585 (Fset_window_next_buffers, Fset_window_clone_number):
4586 New functions.
496e208e
MR
4587 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4588 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4589 Doc-string fixes.
4590 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4591 Argument WINDOW can be now internal window too.
4592 (Fwindow_use_time): Move up in code.
4593 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4594 Rewrite doc-string.
4595 (Fset_window_configuration, saved_window)
4596 (Fcurrent_window_configuration, save_window_save): Handle new
4597 members of window structure.
b9e809c2
MR
4598 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4599 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4600 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4601 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4602 Qget_mru_window, Qresize_root_window,
4603 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4604 Qauto_buffer_name; staticpro them.
f3d1777e 4605
abde8f8c
MR
46062011-06-07 Martin Rudalics <rudalics@gmx.at>
4607
4608 * window.c (Fwindow_total_size, Fwindow_left_column)
4609 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4610 (Fwindow_list_1): New functions.
4611 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4612 (Fwindow_width, Fscroll_left, Fscroll_right):
4613 Use window_body_cols instead of window_box_text_cols.
4614 (delete_window, Fset_window_configuration):
4615 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4616 (delete_all_subwindows): Take a window as argument and not a
4617 structure. Rewrite.
190b47e6
MR
4618 (window_loop): Remove handling of GET_LRU_WINDOW and
4619 GET_LARGEST_WINDOW.
4620 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4621
4622 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4623 window_box_text_cols. delete_all_subwindows now takes a
4624 Lisp_Object as argument.
abde8f8c 4625
640c8776
SM
4626 * indent.c (compute_motion, Fcompute_motion):
4627 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4628
fa8a67e6
MR
4629 * frame.c (delete_frame): Call delete_all_subwindows with root
4630 window as argument.
4631
a54e3482
DC
46322011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4633
4634 * fns.c (Fputhash): Document return value.
4635
60002bf5
CY
46362011-06-06 Chong Yidong <cyd@stupidchicken.com>
4637
4638 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4639
0c671da6 46402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4641
b862a52a 4642 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4643
be44ca6c
PE
4644 Check for overflow when converting integer to cons and back.
4645 * charset.c (Fdefine_charset_internal, Fdecode_char):
4646 Use cons_to_unsigned to catch overflow.
4647 (Fencode_char): Use INTEGER_TO_CONS.
4648 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4649 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4650 * data.c (long_to_cons, cons_to_long): Remove.
4651 (cons_to_unsigned, cons_to_signed): New functions.
4652 These signal an error for invalid or out-of-range values.
4653 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4654 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4655 * font.c (Ffont_variation_glyphs):
4656 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4657 * lisp.h: Include <intprops.h>.
4658 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4659 (cons_to_signed, cons_to_unsigned): New decls.
4660 (long_to_cons, cons_to_long): Remove decls.
4661 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4662 (Fprimitive_undo): Use CONS_TO_INTEGER.
4663 * xfns.c (Fx_window_property): Likewise.
4664 * xselect.c: Include <limits.h>.
4665 (x_own_selection, selection_data_to_lisp_data):
4666 Use INTEGER_TO_CONS.
4667 (x_handle_selection_request, x_handle_selection_clear)
4668 (x_get_foreign_selection, Fx_disown_selection_internal)
4669 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4670 (lisp_data_to_selection_data): Use cons_to_unsigned.
4671 (x_fill_property_data): Use cons_to_signed.
4672 Report values out of range.
4673
d1f3d2af
PE
4674 Check for buffer and string overflow more precisely.
4675 * buffer.h (BUF_BYTES_MAX): New macro.
4676 * lisp.h (STRING_BYTES_MAX): New macro.
4677 * alloc.c (Fmake_string):
4678 * character.c (string_escape_byte8):
4679 * coding.c (coding_alloc_by_realloc):
4680 * doprnt.c (doprnt):
4681 * editfns.c (Fformat):
4682 * eval.c (verror):
4683 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4684 since they may not be the same number.
4685 * editfns.c (Finsert_char):
4686 * fileio.c (Finsert_file_contents):
4687 Likewise for BUF_BYTES_MAX.
4688
dd52fcea
PE
4689 * image.c: Use ptrdiff_t, not int, for sizes.
4690 (slurp_file): Switch from int to ptrdiff_t.
4691 All uses changed.
4692 (slurp_file): Check that file size fits in both size_t (for
4693 malloc) and ptrdiff_t (for sanity and safety).
4694
7f9bbdbb
PE
4695 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4696 if b->modtime has its maximal value.
4697
dfe18f82
PE
4698 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4699
84acfcf0
PE
4700 Don't assume time_t can fit into int.
4701 * buffer.h (struct buffer.modtime): Now time_t, not int.
4702 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4703 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4704
ccd9a01a
PE
4705 Minor fixes for signed vs unsigned integers.
4706 * character.h (MAYBE_UNIFY_CHAR):
4707 * charset.c (maybe_unify_char):
4708 * keyboard.c (read_char, reorder_modifiers):
4709 XINT -> XFASTINT, since the integer must be nonnegative.
4710 * ftfont.c (ftfont_spec_pattern):
4711 * keymap.c (access_keymap, silly_event_symbol_error):
4712 XUINT -> XFASTINT, since the integer must be nonnegative.
4713 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4714 since it makes no difference and we prefer signed.
4715 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4716 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4717 nonnegative.
4718
d6d100dd
SM
47192011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4720
4721 * window.h (Fwindow_frame): Declare.
4722
2b6148e4
PE
47232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4724
4725 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4726 (SPARE_MEMORY): Always define.
4727 (LARGE_REQUEST): Remove.
4728 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4729
f230ecc9
MR
47302011-06-06 Martin Rudalics <rudalics@gmx.at>
4731
727e958e
MR
4732 * lisp.h: Move EXFUNS for Fframe_root_window,
4733 Fframe_first_window and Fset_frame_selected_window to window.h.
4734
4735 * window.h: Move EXFUNS for Fframe_root_window,
4736 Fframe_first_window and Fset_frame_selected_window here from
4737 lisp.h.
4738
4739 * frame.c (Fwindow_frame, Fframe_first_window)
4740 (Fframe_root_window, Fframe_selected_window)
4741 (Fset_frame_selected_window): Move to window.c.
4742 (Factive_minibuffer_window): Move to minibuf.c.
4743 (Fother_visible_frames_p): New function.
4744
4745 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4746
f230ecc9
MR
4747 * window.c (decode_window, decode_any_window): Move up in code.
4748 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4749 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4750 (Fwindow_buffer): Move up and rewrite doc-string.
4751 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4752 (Fwindow_prev): New functions.
727e958e
MR
4753 (Fwindow_frame): Move here from frame.c. Accept any window as
4754 argument.
4755 (Fframe_root_window, Fframe_first_window)
4756 (Fframe_selected_window): Move here from frame.c. Accept frame
4757 or arbitrary window as argument. Update doc-strings.
4758 (Fminibuffer_window): Move up in code.
4759 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4760 (Fset_frame_selected_window): Move here from frame.c.
4761 Marginal rewrite.
727e958e
MR
4762 (Fselected_window, select_window, Fselect_window): Move up in
4763 code. Minor doc-string fixes.
f230ecc9 4764
4d09bcf6
PE
47652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4766
4767 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4768 Do not assume that spare memory exists; that assumption is valid
4769 only if SYSTEM_MALLOC.
4770 (LARGE_REQUEST): New macro, so that the issue of large requests
4771 is separated from the issue of spare memory.
4772
810928a2
AS
47732011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4774
172418ad
AS
4775 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4776 format. (Bug#8806)
4777
43f862f7
AS
4778 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4779
810928a2
AS
4780 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4781 before statements.
4782
a059fe24
JD
47832011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4784
4785 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4786
4787 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4788
4789 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4790 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4791
989bf368
JB
47922011-06-05 Juanma Barranquero <lekktu@gmail.com>
4793
4794 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4795
4b80f674
CY
47962011-06-04 Chong Yidong <cyd@stupidchicken.com>
4797
4798 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4799 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4800 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4801 New error handlers.
4b80f674
CY
4802 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4803 Obey Vx_select_enable_clipboard_manager. Catch errors in
4804 x_clipboard_manager_save (Bug#8779).
4805 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4806 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4807
99a33b77 48082011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4809
4810 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4811
99a33b77 48122011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4813
4814 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4815 in the current matrix if keep_current_p is non-zero.
4816
8264569d
EZ
48172011-06-04 Eli Zaretskii <eliz@gnu.org>
4818
4819 * bidi.c (bidi_level_of_next_char): Fix last change.
4820
57f97249
EZ
48212011-06-03 Eli Zaretskii <eliz@gnu.org>
4822
fec2107c 4823 Support bidi reordering of text covered by display properties.
57f97249 4824
fec2107c
EZ
4825 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4826 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4827 (bidi_cache_search, bidi_cache_iterator_state)
4828 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4829 (bidi_level_of_next_char, bidi_move_to_visually_next):
4830 Support character positions inside a run of characters covered by a
fec2107c
EZ
4831 display string.
4832 (bidi_paragraph_init, bidi_resolve_explicit_1)
4833 (bidi_level_of_next_char): Call bidi_fetch_char and
4834 bidi_fetch_char_advance instead of FETCH_CHAR and
4835 FETCH_CHAR_ADVANCE.
4836 (bidi_init_it): Initialize new members.
4837 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4838 definitions.
4839 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4840 instead of using explicit *_CHAR codes.
d6d100dd
SM
4841 (bidi_resolve_explicit, bidi_resolve_weak):
4842 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4843 bidirectional text is supported only in multibyte buffers.
4844 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4845 it to initialize the frame_window_p member of struct bidi_it.
4846 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4847 (bidi_resolve_explicit, bidi_resolve_weak)
4848 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4849 bidi_it->nchars is non-positive.
4850 (bidi_level_of_next_char): Don't try to lookup the cache for the
4851 next/previous character if nothing is cached there yet, or if we
4852 were just reseat()'ed to a new position.
c40e2fb2 4853
0e14fe90
EZ
4854 * xdisp.c (set_cursor_from_row): Set start and stop points
4855 according to the row's direction when priming the loop that looks
4856 for the glyph on which to display cursor.
4857 (single_display_spec_intangible_p): Function deleted.
4858 (display_prop_intangible_p): Reimplement to call
4859 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4860 Accept 3 additional arguments needed by handle_display_spec.
4861 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4862 values: lists, `(when COND...)' forms, etc.
4863 (single_display_spec_string_p): Support property values that are
4864 lists with the argument STRING its top-level element.
4865 (display_prop_string_p): Fix the condition for processing a
4866 property that is a list to be consistent with handle_display_spec.
fec2107c 4867 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4868 last portion of handle_display_prop.
4869 (compute_display_string_pos): Accept additional argument
4870 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4871 value of a `display' property is a "replacing spec".
4872 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4873 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4874 the display property, but just return a value indicating whether
4875 the display property will replace the characters it covers.
4876 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4877 frame_window_p members of struct bidi_it.
d6d100dd
SM
4878 (compute_display_string_pos, compute_display_string_end):
4879 New functions.
fec2107c
EZ
4880 (push_it): Accept second argument POSITION, where pop_it should
4881 jump to continue iteration.
4882 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4883
fec2107c
EZ
4884 * keyboard.c (adjust_point_for_property): Adjust the call to
4885 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4886
4887 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4888 (bidi_init_it): Update prototypes.
4889 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4890 (compute_display_string_pos, compute_display_string_end):
4891 Declare prototypes.
fec2107c
EZ
4892 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4893 EMACS_INT.
fc6f18ce 4894
40087514 48952011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4896
57f53182
PE
4897 Malloc failure behavior now depends on size of allocation.
4898 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4899 * lisp.h: Change signatures accordingly.
4900 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4901 All callers changed. (Bug#8762)
4902
4903 * gnutls.c: Use Emacs's memory allocators.
4904 Without this change, the gnutls library would invoke malloc etc.
4905 directly, which causes problems on non-SYNC_INPUT hosts, and which
4906 runs afoul of improving memory_full behavior. (Bug#8761)
4907 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4908 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4909 xfree instead of the default malloc, realloc, free.
4910 (Fgnutls_boot): No need to check for memory allocation failure,
4911 since xmalloc does that for us.
4912
ac32cd99 4913 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4914 * category.c (hash_get_category_set):
4915 * ccl.c (ccl_driver):
4916 * charset.c (Fdefine_charset_internal):
4917 * charset.h (struct charset.hash_index):
4918 * composite.c (get_composition_id, gstring_lookup_cache)
4919 (composition_gstring_put_cache):
4920 * composite.h (struct composition.hash_index):
4921 * dispextern.h (struct image.hash):
4922 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4923 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4924 (hashfn_equal, hashfn_user_defined, make_hash_table)
4925 (maybe_resize_hash_table, hash_lookup, hash_put)
4926 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4927 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4928 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4929 * image.c (make_image, search_image_cache, lookup_image)
4930 (xpm_put_color_table_h):
4931 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4932 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4933 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4934 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4935 * alloc.c (allocate_vectorlike):
4936 Check for overflow in vector size calculations.
4937 * ccl.c (ccl_driver):
4938 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4939 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4940 need to be updated by these changes.
40087514
PE
4941 * fns.c (make_hash_table, maybe_resize_hash_table):
4942 Check for integer overflow with large hash tables.
0de4bb68
PE
4943 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4944 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4945 (SXHASH_REDUCE): New macro.
4946 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4947 Use it instead of discarding useful hash info with large hash values.
4948 (sxhash_float): New function.
4949 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4950 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4951 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4952 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4953 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4954 Adjust signatures to match updated version of code.
4955 (consing_since_gc): Now EMACS_INT, since a single hash table can
4956 use more than INT_MAX bytes.
4957
698d32e2
DN
49582011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4959
4960 Make it possible to build with GCC-4.6+ -O2 -flto.
4961
4962 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4963
fd6fa53f
SM
49642011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4965
4966 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4967 Call minibuffer-inactive-mode.
4968
864db017
JB
49692011-05-31 Juanma Barranquero <lekktu@gmail.com>
4970
4971 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4972 Update dependencies.
4973
2ad0baf4
DN
49742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4975
4976 * data.c (init_data): Remove code for UTS, this system is not
4977 supported anymore.
4978
4fcc2638
DN
49792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4980
4981 Don't force ./temacs to start in terminal mode.
4982
4983 * frame.c (make_initial_frame): Initialize faces in all cases, not
4984 only when CANNOT_DUMP is defined.
4985 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4986
c56e0fd5
DN
49872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4988
4989 * dispnew.c (add_window_display_history): Use const for the string
4990 pointer. Remove declaration, not needed.
4991
333d54da 49922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4993
55d4c1b2 4994 Use 'inline', not 'INLINE'.
333d54da 4995 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4996 * alloc.c, fontset.c (INLINE): Remove.
4997 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4998 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4999 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5000 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5001 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5002
738db178
DN
50032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5004
5005 Make it possible to run ./temacs.
5006
5007 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5008 syms_of_callproc does the same thing. Remove test for
5009 "initialized", do it in the caller.
5010 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5011
620c53a6
SM
50122011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5013
5014 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5015 (read_minibuf): Use get_minibuffer.
5016 (syms_of_minibuf): Use DEFSYM.
5017 (Qmetadata): New var.
5018 * data.c (Qbuffer): Don't make it static.
5019 (syms_of_data): Use DEFSYM.
5020
e003a292
PE
50212011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5022
5023 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5024 (CCL_CODE_MIN): New macro.
5025
ed008a6d
PE
50262011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5027
3687c2ef
PE
5028 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5029
ed008a6d
PE
5030 * eval.c (Qdebug): Now static.
5031 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5032 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5033 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5034
d66c4c7c
CY
50352011-05-29 Chong Yidong <cyd@stupidchicken.com>
5036
5037 * image.c: Various fixes to ImageMagick code comments.
5038 (Fimagemagick_types): Doc fix.
5039
5fbc2025
PE
50402011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5041
0196f88a
PE
5042 Minor fixes prompted by GCC 4.6.0 warnings.
5043
5044 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5045
5fbc2025
PE
5046 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5047 (x_clipboard_manager_save_all): Move extern decl to ...
5048 * xterm.h: ... here, so that it can be checked for consistency.
5049
1dd3c2d9
CY
50502011-05-29 Chong Yidong <cyd@stupidchicken.com>
5051
5052 * xselect.c (x_clipboard_manager_save_frame)
5053 (x_clipboard_manager_save_all): New functions.
5054 (Fx_clipboard_manager_save): Lisp function deleted.
5055
5056 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5057 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5058
5059 * xterm.h: Update prototype.
5060
5ba6571d
WX
50612011-05-28 William Xu <william.xwl@gmail.com>
5062
5063 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5064 exiting (Bug#8239).
5065
3eaff834
JM
50662011-05-28 Jim Meyering <meyering@redhat.com>
5067
e1900994 5068 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5069 * fns.c (to_uchar): Define.
5070 (crypto_hash_function): Use it to convert some newly-signed
5071 variables to unsigned, to avoid sign-extension bugs. For example,
5072 without this change, (md5 "truc") would evaluate to
5073 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5074 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5075 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5076
0f6990a7
PE
50772011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5078
5079 Integer overflow fixes.
c8a9ca5a 5080
08686060
PE
5081 * dbusbind.c: Serial number integer overflow fixes.
5082 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5083 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5084 to hold a serial number that is too large for a fixnum.
5085 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5086 Check for serial numbers out of range. Decode any serial number
59568bf0 5087 that was so large that it became a float. (Bug#8722)
08686060 5088
2d1fc3c7
PE
5089 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5090 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5091 Use XFASTINT rather than XUINT when numbers are nonnegative.
5092 (xd_append_arg, Fdbus_method_return_internal):
5093 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5094 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5095 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5096 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5097 (Bug#8722)
2d1fc3c7 5098
c8a9ca5a
PE
5099 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5100
519e1d69
PE
5101 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5102
30569699
PE
5103 ccl: add integer overflow checks
5104 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5105 (IN_INT_RANGE): New macros.
5106 (ccl_driver): Use them to check for integer overflow when
5107 decoding a CCL program. Many of the new checks are whether XINT (x)
5108 fits in int; it doesn't always, on 64-bit hosts. The new version
5109 doesn't catch all possible integer overflows, but it's an
847044ea 5110 improvement. (Bug#8719)
30569699 5111
c11285dc
PE
5112 * alloc.c (make_event_array): Use XINT, not XUINT.
5113 There's no need for unsigned here.
5114
fdccd48e
PE
5115 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5116 This follows up to the 2011-05-06 change that substituted uintptr_t
5117 for EMACS_INT. This case wasn't caught back then.
5118
37910ab2
PE
5119 Rework Fformat to avoid integer overflow issues.
5120 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5121 now (part of C89). Include <verify.h>.
5122 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5123 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5124 (Fformat): Avoid the prepass trying to compute sizes; it was only
5125 approximate and thus did not catch overflow reliably. Instead, walk
5126 through the format just once, formatting and computing sizes as we go,
5127 checking for integer overflow at every step, and allocating a larger
5128 buffer as needed. Keep track separately whether the format is
5129 multibyte. Keep only the most-recently calculated precision, rather
5130 than them all. Record whether each argument has been converted to
5131 string. Use EMACS_INT, not int, for byte and char and arg counts.
5132 Support field widths and precisions larger than INT_MAX. Avoid
5133 sprintf's undefined behavior with conversion specifications such as %#d
5134 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5135 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5136 formatting out-of-range floating point numbers with int
9173deec 5137 formats. (Bug#8668)
37910ab2 5138
2e6578fb
PE
5139 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5140
0ae6bdee
PE
5141 * data.c: Avoid integer truncation in expressions involving floats.
5142 * data.c: Include <intprops.h>.
5143 (arith_driver): When there's an integer overflow in an expression
5144 involving floating point, convert the integers to floating point
5145 so that the resulting value does not suffer from catastrophic
5146 integer truncation. For example, on a 64-bit host (* 4
5147 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5148 Do not rely on undefined behavior after integer overflow.
5149
de883a70
PE
5150 merge count_size_as_multibyte, parse_str_to_multibyte
5151 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5152 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5153 Check for integer overflow.
5154 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5155 since it's now a duplicate of the other. This is more of
5156 a character than a buffer op, so better that it's in character.c.
5157 * fns.c, print.c: Adjust to above changes.
5158
2ff916cb
PE
51592011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5160
5161 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5162
f1b54466
PE
51632011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5164
fb1ac845
PE
5165 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5166 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5167 (x_clipboard_manager_save): Now static.
5168 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5169
f1b54466
PE
5170 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5171 (crypto_hash_function): Now static.
5172 Fix pointer signedness problems. Avoid unnecessary initializations.
5173
a9f737ee
CY
51742011-05-27 Chong Yidong <cyd@stupidchicken.com>
5175
5176 * termhooks.h (Vselection_alist): Make it terminal-local.
5177
5178 * terminal.c (create_terminal): Initialize it.
5179
5180 * xselect.c: Support for clipboard managers.
5181 (Vselection_alist): Move to termhooks.h as terminal-local var.
5182 (LOCAL_SELECTION): New macro.
5183 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5184 (symbol_to_x_atom): Remove gratuitous arg.
5185 (x_handle_selection_request, lisp_data_to_selection_data)
5186 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5187 (x_own_selection, x_get_local_selection, x_convert_selection):
5188 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5189 (some_frame_on_display): Delete unused function.
5190 (Fx_own_selection_internal, Fx_get_selection_internal)
5191 (Fx_disown_selection_internal, Fx_selection_owner_p)
5192 (Fx_selection_exists_p): New optional frame arg.
5193 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5194 (x_handle_selection_clear): Don't treat other terminals with the
5195 same keyboard specially. Use the terminal-local Vselection_alist.
5196 (x_clear_frame_selections): Use Frun_hook_with_args.
5197
5198 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5199
5200 * xterm.h: Add support for those atoms.
5201
e067f0c1
CY
52022011-05-26 Chong Yidong <cyd@stupidchicken.com>
5203
5204 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5205 (converted_selections, conversion_fail_tag): New global variables.
5206 (x_selection_request_lisp_error): Free the above.
5207 (x_get_local_selection): Remove unnecessary code.
5208 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5209 of converted selections stored in converted_selections.
5210 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5211 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5212 (x_convert_selection): New function.
5213 (x_handle_selection_event): Simplify.
5214 (x_get_foreign_selection): Don't ignore incoming requests while
5215 waiting for an answer; this will fail when we implement
5216 SAVE_TARGETS, and seems unnecessary anyway.
5217 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5218 (Vx_sent_selection_functions): Doc fix.
5219
0f4aebc0
LL
52202011-05-26 Leo Liu <sdl.web@gmail.com>
5221
5222 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5223
e61124cd
YM
52242011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5225
5226 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5227
5228 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5229 for fringe update if it has periodic bitmap.
ac389d0c 5230 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5231 and fringe_bitmap_periodic_p.
5232
5233 * fringe.c (get_fringe_bitmap_data): New function.
5234 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5235 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5236 row. Mark glyph row for fringe update if periodicity changed.
5237
5238 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5239 for fringe update unless it has periodic bitmap.
5240
f16d9837
KH
52412011-05-25 Kenichi Handa <handa@m17n.org>
5242
5243 * xdisp.c (get_next_display_element): Set correct it->face_id for
5244 a static composition.
5245
e1b90ef6
LL
52462011-05-24 Leo Liu <sdl.web@gmail.com>
5247
5248 * deps.mk (fns.o):
5249 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5250
5251 * fns.c (crypto_hash_function, Fsha1): New function.
5252 (Fmd5): Use crypto_hash_function.
5253 (syms_of_fns): Add Ssha1.
5254
7400048f
PE
52552011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5256
5257 * gnutls.c: Remove unused macros.
5258 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5259 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5260 Remove macros that are defined and never used.
5261 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5262
abb71cf4
CY
52632011-05-22 Chong Yidong <cyd@stupidchicken.com>
5264
5265 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5266 (Fx_get_selection_internal): Minor cleanup.
5267 (Fx_own_selection_internal): Rename arguments for consistency with
5268 select.el.
5269
6307db39
PE
52702011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5271
5272 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5273
f3d4e0a4
CY
52742011-05-22 Chong Yidong <cyd@stupidchicken.com>
5275
5276 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5277
4d8ade89
YM
52782011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5279
5280 * dispnew.c (scrolling_window): Don't exclude the case that the
5281 last enabled row in the desired matrix touches the bottom boundary.
5282
32078c8d
GM
52832011-05-21 Glenn Morris <rgm@gnu.org>
5284
5285 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5286 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5287 and add some more files.
32078c8d 5288
7285dc67
EZ
52892011-05-20 Eli Zaretskii <eliz@gnu.org>
5290
5291 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5292 report_file_error introduced by the change from 2011-05-07.
5293
89d1bd22
PE
52942011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5295
5296 * systime.h (Time): Define only if emacs is defined.
5297 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5298 where the include path doesn't have X11/X.h by default. See
5299 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5300
e23640bb 53012011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5302
5303 * composite.c (find_automatic_composition): Fix previous change.
5304
b9704ad9
GM
53052011-05-20 Glenn Morris <rgm@gnu.org>
5306
5307 * lisp.mk: New file, split from Makefile.in.
5308 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5309 (shortlisp): Remove.
5310 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5311
4a720484
GM
53122011-05-19 Glenn Morris <rgm@gnu.org>
5313
5314 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5315 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5316 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5317 (lisp): Set the order to that of loadup.el.
5318 (shortlisp): Make it a copy of $lisp.
5319 (SOME_MACHINE_LISP): Remove.
5320 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5321 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5322
a28d4396
KH
53232011-05-18 Kenichi Handa <handa@m17n.org>
5324
5325 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5326 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5327 (find_automatic_composition): Mostly rewrite for efficiency.
5328
a2b1fa8e
JB
53292011-05-18 Juanma Barranquero <lekktu@gmail.com>
5330
5331 * makefile.w32-in: Update dependencies.
5332
8e1f5610
CS
53332011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5334
5335 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5336 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5337
7025ee00 53382011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5339
cdfa6eab
PE
5340 Fix some integer overflow issues, such as string length overflow.
5341
06d6db33
PE
5342 * insdel.c (count_size_as_multibyte): Check for string overflow.
5343
2b4560a8
PE
5344 * character.c (lisp_string_width): Check for string overflow.
5345 Use EMACS_INT, not int, for string indexes and lengths; in
5346 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5347 the resulting string length overflows an EMACS_INT; instead,
5348 report a string overflow if no precision given. When checking for
5349 precision exhaustion, use a check that cannot possibly have
5350 integer overflow. (Bug#8675)
5351 * character.h (lisp_string_width): Adjust to new signature.
5352
cb93f9be
PE
5353 * alloc.c (string_overflow): New function.
5354 (Fmake_string): Use it. This doesn't change behavior, but saves
5355 a few bytes and will simplify future changes.
5356 * character.c (string_escape_byte8): Likewise.
5357 * lisp.h (string_overflow): New decl.
5358
1a1f3366
PE
5359 Fixups, following up to the user-interface timestamp change.
5360 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5361 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5362 * msdos.c (mouse_get_pos): Likewise.
5363 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5364 * w32gui.h (Time): Define by including "systime.h" rather than by
5365 declaring it ourselves. (Bug#8664)
5366
d4e3e4d3
PE
5367 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5368 * image.c (clear_image_cache): Likewise.
5369
f6a24d19
PE
5370 * term.c (term_mouse_position): Don't assume time_t wraparound.
5371
08dc5ae6
PE
5372 Be more systematic about user-interface timestamps.
5373 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5374 and sometimes 'EMACS_UINT', to represent these timestamps.
5375 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5376 This makes the code easier to follow, and makes it easier to catch
5377 integer overflow bugs such as Bug#8664.
5378 * frame.c (Fmouse_position, Fmouse_pixel_position):
5379 Use Time, not unsigned long, for user-interface timestamps.
5380 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5381 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5382 * keyboard.h (last_event_timestamp): Likewise.
5383 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5384 * menu.h (xmenu_show): Likewise.
5385 * term.c (term_mouse_position): Likewise.
5386 * termhooks.h (struct input_event.timestamp): Likewise.
5387 (struct terminal.mouse_position_hook): Likewise.
5388 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5389 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5390 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5391 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5392 what it was before.
5393 * menu.h, termhooks.h: Include "systime.h", for Time.
5394
8e55734a
PE
5395 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5396 Don't assume that the difference between two unsigned long values
5397 can fit into an integer. At this point, we know button_down_time
5398 <= event->timestamp, so the difference must be nonnegative, so
5399 there's no need to cast the result if double-click-time is
5400 nonnegative, as it should be; check that it's nonnegative, just in
5401 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5402 apart (about 25 days). (Bug#8664)
8e55734a 5403
841f1b75 5404 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5405 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5406
3e26f69c
PE
5407 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5408 that always fit in int. Use a sentinel instead of a counter, to
5409 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5410 * frame.h (struct frame): Use int for menu_bar_items_used
5411 instead of EMACS_INT, since it always fits in int.
3e26f69c 5412
5cc152c0
PE
5413 * menu.c (grow_menu_items): Check for int overflow.
5414
d89eb65e
PE
5415 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5416
5235bd3e
PE
5417 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5418 Before, the code was not consistent. These values cannot exceed
5419 2**31 - 1 so there's no need to make them unsigned.
5420 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5421 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5422 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5423 as modifiers.
5424 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5425
bc827e23
PE
5426 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5427 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5428 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5429 presumably because the widths might not match.
5430
78eb494e
PE
5431 * window.c (size_window): Avoid needless test at loop start.
5432
04f2d78b
CB
54332011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5434
5435 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5436
d2fc7e3d 54372011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5438
5439 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5440
d2fc7e3d 54412011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5442
5443 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5444 `width' to `bar_area_x' and `bar_area_width', respectively.
5445 (x_scroll_run): Take account of fringe background extension.
5446
04f2d78b
CB
5447 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5448 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5449 `bar_area_width', respectively.
5450 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5451 background extension.
5452
79b70037
GM
54532011-05-10 Jim Meyering <meyering@redhat.com>
5454
5455 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5456
2f142cc5
JB
54572011-05-10 Juanma Barranquero <lekktu@gmail.com>
5458
5459 * image.c (Finit_image_library): Return t for built-in image types,
5460 like pbm and xbm. (Bug#8640)
5461
57679c86
AS
54622011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5463
5464 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5465
888c9e86
EZ
54662011-05-07 Eli Zaretskii <eliz@gnu.org>
5467
b0512a1d
EZ
5468 * w32console.c (Fset_screen_color): Doc fix.
5469 (Fget_screen_color): New function.
5470 (syms_of_ntterm): Defsubr it.
5471
7285dc67
EZ
5472 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5473 unlink the temporary file if Fcall_process didn't create it in the
5474 first place.
5475 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5476 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5477 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5478 cue to call_process_cleanup not to close that handle.
5479
4d3fcc8e
BK
54802011-05-07 Ben Key <bkey76@gmail.com>
5481
5482 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5483 one of two shell specific rules, either bootstrap-temacs-CMD or
5484 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5485 to the previous implementation of the bootstrap-temacs rule.
5486 The bootstrap-temacs-CMD rule is similar to the previous
5487 implementation of the bootstrap-temacs rule except that it
5488 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5489 variable.
5490
5491 These changes, along with some changes to nt/configure.bat,
5492 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5493 earlier fix to add support for --cflags and --ldflags options
5494 that include quotes so that it works whether make uses cmd or
5495 sh as the shell.
5496
b4289b64
MA
54972011-05-06 Michael Albinus <michael.albinus@gmx.de>
5498
5499 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5500 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5501 is a constant.
5502 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5503 a string. Handle both cases.
5504 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5505 (Fdbus_register_method): Use Qinvalid_function.
5506
af4c0e28
JB
55072011-05-06 Juanma Barranquero <lekktu@gmail.com>
5508
5509 * makefile.w32-in: Update dependencies.
5510 (LISP_H): Add inttypes.h and stdin.h.
5511 (PROCESS_H): Add unistd.h.
5512
c51453d9
EZ
55132011-05-06 Eli Zaretskii <eliz@gnu.org>
5514
5515 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5516 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5517
8ff0ac3c 55182011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5519
4c4b566b
PE
5520 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5521
aab2b9b5
PE
5522 * term.c (vfatal): Remove stray call to va_end.
5523 It's not needed and the C Standard doesn't allow it here anyway.
5524
c378da0b
PE
5525 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5526 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5527
288b08c7
PE
5528 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5529 bytes.
5530
e3601888
PE
5531 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5532
db6c0e74
PE
5533 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5534
dd5963ea
PE
5535 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5536
88c9450f
PE
5537 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5538
2f9442b8
PE
5539 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5540
c032b5f8
PE
5541 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5542 * charset.c (Fdefine_charset_internal): Don't initialize
5543 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5544 32-bit int (Bug#8600).
a108c10b
PE
5545
5546 * lread.c (read_integer): Be more consistent with string-to-number.
5547 Use string_to_number to do the actual conversion; this avoids
5548 rounding errors and fixes some other screwups. Without this fix,
5549 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5550 (digit_to_number): Move earlier, for benefit of read_integer.
5551 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5552 not a digit in any supported base. (Bug#8602)
a108c10b 5553
ad5f9eea
PE
5554 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5555
aec1708a
PE
5556 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5557 to match comment at start of function. This also removes a
5558 GCC warning about overflow in a 32+64-bit port.
5559
47be4ab5
PE
5560 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5561
371cac43
PE
5562 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5563 Reported by Stefan Monnier in
5564 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5565 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5566 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5567
d01a7826
PE
5568 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5569 (EMACS_UINTPTR): Likewise, with uintptr_t.
5570
7fd47d5c
PE
5571 * lisp.h: Prefer 64-bit EMACS_INT if available.
5572 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5573 on 32-bit hosts that have 64-bit int, so that they can access
5574 large files.
122b0c86
PE
5575 However, temporarily disable this change unless the temporary
5576 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5577
8727937b
PE
5578 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5579
8ac068ac
PE
5580 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5581 This removes an assumption that EMACS_INT and long are the same
5582 width as pointers. The assumption is true for Emacs porting targets
5583 now, but we want to make other targets possible.
5584 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5585 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5586 In the rest of the code, change types of integers that hold casted
5587 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5588 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5589 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5590 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5591 No need to cast type when ORing.
5592 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5593 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5594 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5595 assume EMACS_INT is the same width as char *.
5596 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5597 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5598 Remove no-longer-needed casts.
5599 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5600 (xg_tool_bar_help_callback, xg_make_tool_item):
5601 Use EMACS_INTPTR to hold an integer
5602 that will be cast to void *; this can avoid a GCC warning
5603 if EMACS_INT is not the same width as void *.
5604 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5605 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5606 (current_message_1, set_message_1):
5607 Use a local to convert to proper width without a cast.
5608 * xmenu.c (dialog_selection_callback): Likewise.
5609
ede49d71
PE
5610 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5611 Also, don't assume VALBITS / RAND_BITS is less than 5,
5612 and don't rely on undefined behavior when shifting a 1 left into
5613 the sign bit.
5614 * lisp.h (get_random): Change signature to match.
5615
2f30ecd0
PE
5616 * lread.c (hash_string): Use size_t, not int, for hash computation.
5617 Normally we prefer signed values; but hashing is special, because
5618 it's better to use unsigned division on hash table sizes so that
5619 the remainder is nonnegative. Also, size_t is the natural width
5620 for hashing into memory. The previous code used 'int', which doesn't
5621 retain enough info to hash well into very large tables.
5622 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5623
2a866e7b
PE
5624 * dbusbind.c: Don't possibly lose pointer info when converting.
5625 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5626 Use XPNTR rather than XHASH, so that the high-order bits of
5627 the pointer aren't lost when converting through void *.
5628
51639eac
PE
5629 * eval.c (Fautoload): Don't double-shift a pointer.
5630
92394119
PE
5631 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5632
dbdb9a7c
JB
56332011-05-06 Juanma Barranquero <lekktu@gmail.com>
5634
5635 * gnutls.c (DEF_GNUTLS_FN):
5636 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5637
db7a0b4f
AS
56382011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5639
5640 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5641 marker. (Bug#8610)
5642
f7ff1b0f 56432011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5644
5645 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5646 New version that can reserve upto 2GB of heap space.
5647
f7ff1b0f 56482011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5649
5650 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5651
639c109b
TZ
56522011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5653
5654 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5655 `gnutls_certificate_set_x509_key_file'.
5656
d2127135
JB
56572011-05-05 Juanma Barranquero <lekktu@gmail.com>
5658
5659 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5660 Update dependencies.
5661
e968f4f3
JB
56622011-05-04 Juanma Barranquero <lekktu@gmail.com>
5663
5664 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5665 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5666 Remove unused parameter `fildes'.
5667 * process.c (read_process_output, send_process): Don't pass it.
5668
84d358f0
JB
56692011-05-04 Juanma Barranquero <lekktu@gmail.com>
5670
5671 Fix previous change: the library cache is defined in w32.c.
5672 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5673 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5674
0898ca10
JB
56752011-05-04 Juanma Barranquero <lekktu@gmail.com>
5676
5677 Implement dynamic loading of GnuTLS on Windows.
5678
5679 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5680 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5681 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5682 Declare.
5683
5684 * gnutls.c (Qgnutls_dll): Define.
5685 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5686 (gnutls_*): Declare function pointers.
5687 (init_gnutls_functions): New function to initialize function pointers.
5688 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5689 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5690 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5691 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5692 (emacs_gnutls_write, emacs_gnutls_read)
5693 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5694 (Fgnutls_available_p): New function.
5695 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5696 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5697 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5698
5699 * image.c: Include w32.h.
5700 (Vimage_type_cache): Delete.
5701 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5702 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5703 (w32_delayed_load): Move to w32.c.
5704
5705 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5706
5707 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5708 (w32_delayed_load): Move from image.c. When loading a library, record
5709 its filename in the :loaded-from property of the library id.
5710 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5711 Initialize and staticpro them.
5712 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5713
5714 * process.c: Include lisp.h before w32.h, not after.
5715 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5716 instead of gnutls_record_check_pending.
5717
5718 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5719
ff4de4aa
TZ
57202011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5721
5722 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5723 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5724 as passed in.
5725
abe95abb
JD
57262011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5727
5728 * xterm.c (x_set_frame_alpha): Do not set property on anything
5729 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5730
e16e55d4
JB
57312011-05-02 Juanma Barranquero <lekktu@gmail.com>
5732
5733 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5734
bafcf6a5
JB
57352011-05-02 Juanma Barranquero <lekktu@gmail.com>
5736
5737 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5738 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5739 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5740 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5741 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5742 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5743 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5744 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5745 (Qgnutls_bootprop_callbacks_verify): Make static.
5746
e7a6747f
AS
57472011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5748
19ed11ba
AS
5749 * callproc.c: Indentation fixup.
5750
e7a6747f 5751 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5752 (wait_for_termination, interruptible_wait_for_termination):
5753 Move after wait_for_termination_1.
e7a6747f 5754
1ef14cb4
LMI
57552011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5756
5757 * sysdep.c (interruptible_wait_for_termination): New function
5758 which is like wait_for_termination, but allows keyboard
5759 interruptions.
5760
5761 * callproc.c (Fcall_process): Add (:file "file") as an option for
5762 the STDOUT buffer.
5763 (Fcall_process_region): Ditto.
5764
330d880c
EZ
57652011-04-30 Eli Zaretskii <eliz@gnu.org>
5766
8db90b73
EZ
5767 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5768 rather than `XVECTOR (FOO)->size'.
5769
330d880c
EZ
5770 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5771 inttypes.h, as a gnulib replacement is used if it not available in
5772 system headers.
5773
15cbd324
EZ
57742011-04-21 Eli Zaretskii <eliz@gnu.org>
5775
5776 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5777 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5778 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5779
5780 * coding.c (coding_alloc_by_realloc): Error out if destination
5781 will grow beyond MOST_POSITIVE_FIXNUM.
5782 (decode_coding_emacs_mule): Abort if there isn't enough place in
5783 charbuf for the composition carryover bytes. Reserve an extra
5784 space for up to 2 characters produced in a loop.
5785 (decode_coding_iso_2022): Abort if there isn't enough place in
5786 charbuf for the composition carryover bytes.
5787
57882011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5789
ae940cca
EZ
5790 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5791 aborting when %lld or %lll format is passed.
5792 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5793 %llo or %llx format is passed. (Bug#8545)
5794
03ab8921
EZ
5795 * window.c (window_scroll_line_based): Use a marker instead of
5796 simple variables to record original value of point. (Bug#7952)
5797
afda1437
EZ
5798 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5799 produced by %s or %c overflows available buffer space. (Bug#8545)
5800
f76dee0c
PE
58012011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5802
5803 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5804 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5805
fdc5744d
JB
58062011-04-28 Juanma Barranquero <lekktu@gmail.com>
5807
5808 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5809
638f053a
JB
58102011-04-28 Juanma Barranquero <lekktu@gmail.com>
5811
5812 * keyboard.c (Qdelayed_warnings_hook): Define.
5813 (command_loop_1): Run `delayed-warnings-hook'
5814 if Vdelayed_warnings_list is non-nil.
5815 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5816 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5817
d178f871
EZ
58182011-04-28 Eli Zaretskii <eliz@gnu.org>
5819
5820 * doprnt.c (doprnt): Don't return value smaller than the buffer
5821 size if the message was truncated. (Bug#8545).
5822
b124fd93
JB
58232011-04-28 Juanma Barranquero <lekktu@gmail.com>
5824
5825 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5826 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5827
e810457d
PE
58282011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5829
5830 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5831
ea51cceb
JB
58322011-04-27 Juanma Barranquero <lekktu@gmail.com>
5833
5834 * makefile.w32-in: Update dependencies.
5835
94dcfacf
EZ
58362011-04-27 Eli Zaretskii <eliz@gnu.org>
5837
5838 Improve `doprnt' and its usage. (Bug#8545)
5839 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5840 `format_end'. Remove support for %l as a conversion specifier.
5841 Don't use xrealloc. Improve diagnostics when the %l size modifier
5842 is used. Update the commentary.
5843
5844 * eval.c (verror): Simplify calculation of size_t.
5845
5846 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5847 messages.
5848
f61f41d7
PE
58492011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5850
5851 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5852 change.
5853
96fb4434
PE
58542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5855
5856 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5857 This makes this file independent of the recent pseudovector change.
5858
671875da 58592011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5860
69e9b5a3
PE
5861 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5862
b5f869a7 5863 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5864 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5865 Remove unused local.
c8926152 5866 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5867
841a1577 5868 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5869 GCC 4.6.0 optimizes based on type-based alias analysis.
5870 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5871 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5872 != &v->size, and therefore "v->size = 1; b->size = 2; return
5873 v->size;" must therefore return 1. This assumption is incorrect
5874 for Emacs, since it type-puns struct Lisp_Vector * with many other
5875 types. To fix this problem, this patch adds a new type struct
f904488f 5876 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5877 and pseudovectors, and helps optimizing compilers not get fooled
5878 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5879 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5880 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5881 the size member.
eab3844f
PE
5882 (XSETPVECTYPE): Rewrite in terms of new macro.
5883 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5884 This is a bit clearer, and further avoids the possibility of
5885 undesirable aliasing.
5886 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5887 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5888 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5889 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5890 (ASIZE): Now uses header.size rather than size.
5891 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5892 to avoid the hassle of writing XVECTOR (foo)->header.size.
5893 (struct vectorlike_header): New type.
eab3844f
PE
5894 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5895 object, to help avoid aliasing.
5896 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5897 (SUBRP): Likewise, since Lisp_Subr is a special case.
5898 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5899 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5900 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5901 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5902 changed to be "header.size" and "header.next".
5903 * buffer.h (struct buffer): Likewise.
5904 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5905 * frame.h (struct frame): Likewise.
5906 * process.h (struct Lisp_Process): Likewise.
5907 * termhooks.h (struct terminal): Likewise.
5908 * window.c (struct save_window_data, struct saved_window): Likewise.
5909 * window.h (struct window): Likewise.
5910 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5911 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5912 * buffer.c (init_buffer_once): Likewise.
5913 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5914 special case.
5915 * process.c (Fformat_network_address): Use local var for size,
5916 for brevity.
5917
0df1eac5
PE
5918 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5919
847ab9d1 5920 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5921 * data.c (atof): Remove decl; no longer used or needed.
5922 (digit_to_number): Move to lread.c.
5923 (Fstring_to_number): Use new string_to_number function, to be
5924 consistent with how the Lisp reader treats infinities and NaNs.
5925 Do not assume that floating-point numbers represent EMACS_INT
5926 without losing information; this is not true on most 64-bit hosts.
5927 Avoid double-rounding errors, by insisting on integers when
5928 parsing non-base-10 numbers, as the documentation specifies.
5929 * lisp.h (string_to_number): New decl, replacing ...
5930 (isfloat_string): Remove.
bc0a5c13 5931 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5932 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5933 appears to have been a coding error. Similarly, do not accept
5934 strings like +-1e0 as floating point numbers. Do not report
5935 overflow for integer overflows unless the base is not 10 which
5936 means we have no simple and reliable way to continue.
5937 Break out the floating-point parsing into a new
5938 function string_to_number, so that Fstring_to_number parses
5939 floating point numbers consistently with the Lisp reader.
04f2d78b 5940 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5941 (E_CHAR, EXP_INT): Remove, replacing with ...
5942 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5943 (string_to_number): New function, replacing isfloat_string.
5944 This function checks for valid syntax and produces the resulting
5945 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5946 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5947 so that overflow for non-base-10 numbers is reported only when
5948 there's no portable and simple way to convert to floating point.
452f4150 5949
67769ffc
PE
5950 * textprop.c (set_text_properties_1): Rewrite for clarity,
5951 and to avoid GCC warning about integer overflow.
5952
c20db43f
PE
5953 * intervals.h (struct interval): Use EMACS_INT for members
5954 where EMACS_UINT might cause problems. See
5955 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5956 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5957 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5958 All uses changed.
37aa2f85
PE
5959 (offset_intervals): Tell GCC not to worry about length overflow
5960 when negating a negative length.
c20db43f 5961
2538aa2f
PE
5962 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5963 (overrun_check_free): Likewise.
5964
f2d3008d
PE
5965 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5966 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5967 word size.
5968
ec8df744
PE
5969 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5970 (gnutls_make_error): Rename local to avoid shadowing.
5971 (gnutls_emacs_global_deinit): ifdef out; not used.
5972 (Fgnutls_boot): Use const for pointer to readonly storage.
5973 Comment out unused local. Fix pointer signedness problems.
5974
640ee02d
PE
5975 * lread.c (openp): Don't stuff size_t into an 'int'.
5976 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5977 about possible signed overflow.
5978
6048fb2a
PE
5979 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5980 (GDK_KEY_g): Don't define if already defined.
5981 (xg_prepare_tooltip): Avoid pointer signedness problem.
5982 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5983
fa3c87e1
PE
5984 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5985 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5986
2172544b
PE
5987 * xfns.c (Fx_window_property): Simplify a bit,
5988 to make a bit faster and to avoid GCC 4.6.0 warning.
5989 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5990
9b821a21
PE
5991 * fns.c (internal_equal): Don't assume size_t fits in int.
5992
3c616cfa
PE
5993 * alloc.c (compact_small_strings): Tighten assertion a little.
5994
c2982e87
PE
5995 Replace pEd with more-general pI, and fix some printf arg casts.
5996 * lisp.h (pI): New macro, generalizing old pEd macro to other
5997 conversion specifiers. For example, use "...%"pI"d..." rather
5998 than "...%"pEd"...".
5999 (pEd): Remove. All uses replaced with similar uses of pI.
6000 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6001 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6002 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6003 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6004 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6005 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6006 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6007 64-bit hosts.
6008 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6009 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6010 * print.c (safe_debug_print, print_object): Likewise.
6011 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6012 to int.
6f04d126
PE
6013 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6014 avoiding the 0 flag, which is not portable.
c2982e87
PE
6015 * process.c (Fmake_network_process): Use pI to avoid cast.
6016 * region-cache.c (pp_cache): Likewise.
6017 * xdisp.c (decode_mode_spec): Likewise.
6018 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6019 behavior on 64-bit hosts with printf arg.
6f04d126 6020 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6021 (x_stop_queuing_selection_requests): Likewise.
6022 (x_get_window_property): Don't truncate byte count to an 'int'
6023 when tracing.
0b432f21 6024
5e073ec7
PE
6025 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6026 here, since it parses constructs like leading '-' and spaces,
6027 which are not wanted; and it overflows with large numbers.
6028 Instead, simply match F[0-9]+, which is what is wanted anyway.
6029
36372bf9
PE
6030 * alloc.c: Remove unportable assumptions about struct layout.
6031 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6032 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6033 (allocate_vectorlike, make_pure_vector): Use the new macros,
6034 plus offsetof, to remove unportable assumptions about struct layout.
6035 These assumptions hold on all porting targets that I know of, but
6036 they are not guaranteed, they're easy to remove, and removing them
6037 makes further changes easier.
6038
0b432f21
PE
6039 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6040 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6041 (string_overrun_cookie): Now const. Use initializers that
6042 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6043 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6044 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6045 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6046 multiple of sizeof (EMACS_INT); it need not be, if
6047 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6048 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6049
895009e1
JB
60502011-04-26 Juanma Barranquero <lekktu@gmail.com>
6051
6052 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6053
6a7a1b0b
TZ
60542011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6055
6056 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6057 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6058 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6059
841a1577 60602011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6061
6062 * lisp.h (Qdebug): List symbol.
895009e1 6063 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6064 * keyboard.c (debug-on-event): New variable.
6065 (handle_user_signal): Break into debugger when debug-on-event
6066 matches the current signal symbol.
6067
f2d3ba6f
DN
60682011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6069
6070 * alloc.c (check_sblock, check_string_bytes)
6071 (check_string_free_list): Convert to standard C.
6072
42ce4c63
TZ
60732011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6074
6075 * w32.c (emacs_gnutls_push): Fix typo.
6076
825cd63c
EZ
60772011-04-25 Eli Zaretskii <eliz@gnu.org>
6078
fb11d64d
EZ
6079 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6080 "cast to pointer from integer of different size".
6081
825cd63c
EZ
6082 Improve doprnt and its use in verror. (Bug#8545)
6083 * doprnt.c (doprnt): Document the set of format control sequences
6084 supported by the function. Use SAFE_ALLOCA instead of always
6085 using `alloca'.
6086
6087 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6088 is one byte too soon. Don't use xrealloc; instead xfree and
6089 xmalloc anew.
6090
e061a11b
TZ
60912011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6092
6093 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6094 callbacks stage.
6095
6096 * gnutls.c: Renamed global_initialized to
6097 gnutls_global_initialized. Added internals for the
6098 :verify-hostname-error, :verify-error, and :verify-flags
6099 parameters of `gnutls-boot' and documented those parameters in the
6100 docstring. Start callback support.
9173deec
JB
6101 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6102 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6103 on error. Return error code.
e061a11b
TZ
6104 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6105 (emacs_gnutls_read): Likewise.
6106 (Fgnutls_boot): Return handshake error code.
6107 (emacs_gnutls_handle_error): New function.
6108 (wsaerror_to_errno): Likewise.
6109
6110 * w32.h (emacs_gnutls_pull): Add prototype.
6111 (emacs_gnutls_push): Likewise.
6112
6113 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6114 (emacs_gnutls_push): Likewise.
6115
61162011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6117
6118 * process.c (wait_reading_process_output): Check if GnuTLS
6119 buffered some data internally if no FDs are set for TLS
6120 connections.
6121
6122 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6123 (LIBS): Link to USER_LIBS.
6124 ($(BLD)/gnutls.$(0)): New target.
6125
fa6996bc
EZ
61262011-04-24 Eli Zaretskii <eliz@gnu.org>
6127
eb35682e
EZ
6128 * xdisp.c (handle_single_display_spec): Rename the
6129 display_replaced_before_p argument into display_replaced_p, to
6130 make it consistent with the commentary. Fix typos in the
6131 commentary.
6132
e2ad650c
EZ
6133 * textprop.c (syms_of_textprop): Remove dead code.
6134 (copy_text_properties): Delete obsolete commentary about an
6135 interface that was deleted long ago. Fix typos in the description
6136 of arguments.
6137
1b2de274
EZ
6138 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6139 to changes in oldXMenu/XMenu.h from 2011-04-16.
6140 <menu_help_message, prev_menu_help_message>: Constify.
6141 (IT_menu_make_room): menu->help_text is now `const char **';
6142 adjust.
6143
6144 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6145 to changes in oldXMenu/XMenu.h from 2011-04-16.
6146 (struct XMenu): Declare `help_text' `const char **'.
6147
6148 * xfaces.c <Qunspecified>: Make extern again.
6149
6150 * syntax.c: Include sys/types.h before including regex.h, as
6151 required by Posix.
6152
762b15be
EZ
6153 * doc.c (get_doc_string): Improve the format passed to `error'.
6154
6155 * doprnt.c (doprnt): Improve commentary.
6156
6157 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6158
6159 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6160 them with etags.
6161
f1052e5d
EZ
6162 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6163 changes in globals.h immediately force recompilation.
762b15be
EZ
6164 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6165 $(CURDIR)/s/ms-w32.h.
6166 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6167
fa6996bc
EZ
6168 * character.c (Fchar_direction): Function deleted.
6169 (syms_of_character): Don't defsubr it.
6170 <char-direction-table>: Deleted.
6171
e6c3da20
EZ
61722011-04-23 Eli Zaretskii <eliz@gnu.org>
6173
6174 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6175 * doprnt.c: Include limits.h.
6176 (SIZE_MAX): New macro.
04f2d78b
CB
6177 (doprnt): Return a size_t value. 2nd arg is now size_t.
6178 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6179 Improve overflow protection. Support `l' modifier for integer
6180 conversions. Support %l conversion. Don't assume an EMACS_INT
6181 argument for integer conversions and for %c.
6182
6183 * lisp.h (doprnt): Restore prototype.
6184
6185 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6186 $(SRC)/character.h.
6187
6188 * Makefile.in (base_obj): Add back doprnt.o.
6189
6190 * deps.mk (doprnt.o): Add back prerequisites.
6191 (callint.o): Depend on character.h.
6192
6193 * eval.c (internal_lisp_condition_case): Include the handler
6194 representation in the error message.
6195 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6196 when breaking from the loop.
6197
6198 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6199
6200 * callint.c (Fcall_interactively): When displaying error message
6201 about invalid control letter, pass the character's codepoint, not
6202 a pointer to its multibyte form. Improve display of the character
6203 in octal and display also its hex code.
6204
6205 * character.c (char_string): Use %x to display the (unsigned)
6206 codepoint of an invalid character, to avoid displaying a bogus
6207 negative value.
6208
6209 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6210 `error', not SYMBOL_NAME itself.
6211
6212 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6213 character arguments to `error'.
6214
6215 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6216 to `error' in error message about FINAL_CHAR argument. Make sure
6217 FINAL_CHAR is a character, and use %c when it is passed as
6218 argument to `error'.
6219
4ffd0d6b 62202011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6221
6222 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6223
6224 * w32.c: Include <time.h>.
6225 (sys_localtime): New function.
6226
4ffd0d6b 62272011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6228
6229 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6230
4ffd0d6b 6231 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6232
4ffd0d6b 62332011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6234
4ffd0d6b
GM
6235 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6236 zombies (Bug#8467).
aac0c6e3 6237
04c56954
EZ
62382011-04-19 Eli Zaretskii <eliz@gnu.org>
6239
6240 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6241 gl_state.e_property when gl_state.object is Qt.
6242
6243 * insdel.c (make_gap_larger): Remove limitation of buffer size
6244 to <= INT_MAX.
6245
16a43933
CY
62462011-04-18 Chong Yidong <cyd@stupidchicken.com>
6247
6248 * xdisp.c (lookup_glyphless_char_display)
6249 (produce_glyphless_glyph): Handle cons cell entry in
6250 glyphless-char-display.
6251 (Vglyphless_char_display): Document it.
6252
6253 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6254 glyphless-char-display.
6255
4581706e
CY
62562011-04-17 Chong Yidong <cyd@stupidchicken.com>
6257
6258 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6259
6260 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6261
6262 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6263 definition for no-X builds.
6264
4887c6e2 62652011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6266
fd35b6f9
PE
6267 Static checks with GCC 4.6.0 and non-default toolkits.
6268
5c1ccb01
PE
6269 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6270
006c5daa
PE
6271 * process.c (keyboard_bit_set): Define only if SIGIO.
6272 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6273 (send_process): Repair possible setjmp clobbering.
6274
efc736d3
PE
6275 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6276
4e2fe2e6
PE
6277 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6278
f97334a2
PE
6279 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6280
4e75f29d
PE
6281 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6282 Define only if needed.
6283
90efadd1
PE
6284 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6285 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6286 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6287
3c647824
PE
6288 * dispextern.h (struct redisplay_interface): Rename param
6289 to avoid shadowing.
e264f262 6290 * termhooks.h (struct terminal): Likewise.
761383f4 6291 * xterm.c (xembed_send_message): Likewise.
3c647824 6292
b58c5c4a
PE
6293 * insdel.c (make_gap_smaller): Define only if
6294 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6295
cad59032
PE
6296 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6297 it.
6298
c339dc2e
PE
6299 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6300 so that we aren't warned about unused symbols.
6301
91a3e27b
PE
6302 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6303
399c71d3 6304 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6305
8ffc96f5
PE
6306 * xfns.c (x_real_positions): Mark locals as initialized.
6307
eef9bc79
PE
6308 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6309
098db9dd
PE
6310 * xterm.c: Fix problems found by static analysis with other toolkits.
6311 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6312 (x_dispatch_event): Declare static if USE_GTK, and
6313 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6314 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6315 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6316 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6317 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6318
eb18f6cc
PE
6319 * xmenu.c (menu_help_callback): Pointer type fixes.
6320 Use const pointers when pointing at readonly data. Avoid pointer
6321 signedness clashes.
6322 (FALSE): Remove unused macro.
6323 (update_frame_menubar): Remove unused decl.
6324
1fe72bf8
PE
6325 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6326
60d9e1db
PE
6327 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6328 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6329 (single_menu_item): Rename local to avoid shadowing.
6330
39261c26
PE
6331 * keyboard.c (make_lispy_event): Remove unused local var.
6332
018c5e19
PE
6333 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6334 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6335
63d2b86e
PE
6336 * bitmaps: Change bitmaps from unsigned char back to the X11
6337 compatible char. Avoid the old compiler warnings about
6338 out-of-range initializers by using, for example, '\xab' rather
6339 than 0xab.
6340
aefd87e1
PE
6341 * xgselect.c (xgselect_initialize): Check vs interface
6342 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6343
bf501fb9
PE
6344 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6345
e9829fdf
PE
6346 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6347 to read-only memory.
6348
1086c095
PE
6349 * fns.c (vector): Remove; this old hack is no longer needed.
6350
2baccd04 6351 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6352 Remove unused var.
dde42981 6353 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6354
72391843 6355 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6356
436c16df 6357 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6358 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6359 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6360
92bb796d 6361 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6362 (x_term_init): Remove local to avoid shadowing.
92bb796d 6363
764430a3 6364 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6365
6366 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6367 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6368
d1dfb56c
EZ
63692011-04-16 Eli Zaretskii <eliz@gnu.org>
6370
c4354cb4
EZ
6371 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6372
d1dfb56c
EZ
6373 Fix regex.c, syntax.c and friends for buffers > 2GB.
6374 * syntax.h (struct gl_state_s): Declare character position members
6375 EMACS_INT.
6376
6377 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6378
04f2d78b
CB
6379 * textprop.c (verify_interval_modification, interval_of):
6380 Declare arguments EMACS_INT.
d1dfb56c
EZ
6381
6382 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6383 EMACS_INT.
6384
6385 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6386
6387 * indent.c (Fvertical_motion): Local variable it_start is now
6388 EMACS_INT.
6389
6390 * regex.c (re_match, re_match_2, re_match_2_internal)
6391 (bcmp_translate, regcomp, regexec, print_double_string)
6392 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6393 (re_compile_pattern, re_exec): Declare arguments and local
6394 variables `size_t' and `ssize_t' and return values `regoff_t', as
6395 appropriate.
6396 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6397 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6398 <compile_stack_type>: `size' and `avail' are now `size_t'.
6399
6400 * regex.h <regoff_t>: Use ssize_t, not int.
6401 (re_search, re_search_2, re_match, re_match_2): Arguments that
6402 specify buffer/string position and length are now ssize_t and
6403 size_t. Return type is regoff_t.
6404
613052cd
BK
64052011-04-16 Ben Key <bkey76@gmail.com>
6406
6407 * nsfont.m: Fixed bugs in ns_get_family and
6408 ns_descriptor_to_entity that were caused by using free to
6409 deallocate memory blocks that were allocated by xmalloc (via
6410 xstrdup). This caused Emacs to crash when compiled with
6411 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6412 --enable-checking=xmallocoverrun). xfree is now used to
6413 deallocate these memory blocks.
6414
4170f62f 64152011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6416
71b41406
PE
6417 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6418
9587a89d
PE
6419 emacs_write: Accept and return EMACS_INT for sizes.
6420 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6421 et seq.
6422 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6423 Accept and return EMACS_INT.
6424 (emacs_gnutls_write): Return the number of bytes written on
6425 partial writes.
6426 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6427 (emacs_read, emacs_write): Remove check for negative size, as the
6428 Emacs source code has been audited now.
9587a89d
PE
6429 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6430 (emacs_read, emacs_write): Use it.
273a5f82
PE
6431 * process.c (send_process): Adjust to the new signatures of
6432 emacs_write and emacs_gnutls_write. Do not attempt to store
6433 a byte offset into an 'int'; it might overflow.
9587a89d 6434 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6435
3e047f51
PE
6436 * sound.c: Don't assume sizes fit in 'int'.
6437 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6438 Return EMACS_INT, not int.
3e047f51 6439 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6440 Accept EMACS_INT, not int.
6441 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6442 record read return values.
6443
cc39a9db
BK
64442011-04-15 Ben Key <bkey76@gmail.com>
6445
c9d0ec6d
JB
6446 * keyboard.c (Qundefined): Don't declare static since it is used
6447 in nsfns.m.
6448 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6449 static since they are used in nsfont.m.
cc39a9db 6450
6c60eb9f
SM
64512011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6452
6453 * process.c (Qprocessp): Don't declare static.
6454 * lisp.h (Qprocessp): Declare again.
6455
7990b61a
JB
64562011-04-15 Juanma Barranquero <lekktu@gmail.com>
6457
6458 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6459
5d4cb038
PE
64602011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6461
8bd7b830 6462 Improve C-level modularity by making more things 'static'.
cd64ea1d 6463
e3b27b31
PE
6464 Don't publish debugger-only interfaces to other modules.
6465 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6466 (verify_bytepos, count_markers): Move decls to the only modules
6467 that need them.
6468 * region-cache.h (pp_cache): Likewise.
6469 * window.h (check_all_windows): Likewise.
6470 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6471
5d4cb038
PE
6472 * sysdep.c (croak): Now static, if
6473 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6474 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6475
6476 * alloc.c (refill_memory_reserve): Now static if
6477 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6478 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6479
e87b6180
PE
6480 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6481 Define only if USE_LUCID.
6482
ac64929e
PE
6483 * xrdb.c (x_customization_string, x_rm_string): Now static.
6484
6f37259d
PE
6485 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6486 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6487
1683e3ab
PE
6488 * xdisp.c (draw_row_with_mouse_face): Now static.
6489 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6490
de9c2632
PE
6491 * window.h (check_all_windows): Mark externally visible.
6492
2b96acb7
PE
6493 * window.c (window_deletion_count): Now static.
6494
6495 * undo.c: Make symbols static if they're not exported.
6496 (last_undo_buffer, last_boundary_position, pending_boundary):
6497 Now static.
6498
50436f33
PE
6499 * textprop.c (interval_insert_behind_hooks): Now static.
6500 (interval_insert_in_front_hooks): Likewise.
6501
64520e5c
PE
6502 * term.c: Make symbols static if they're not exported.
6503 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6504 (max_frame_lines, tty_set_terminal_modes):
6505 (tty_reset_terminal_modes, tty_turn_off_highlight):
6506 (get_tty_terminal): Now static.
6507 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6508 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6509 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6510 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6511 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6512
1fa53021
PE
6513 * sysdep.c: Make symbols static if they're not exported.
6514 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6515 Now static.
6516 (sigprocmask_set, full_mask): Remove; unused.
6517 (wait_debugging): Mark as visible.
6518 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6519 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6520
d4b43b22
PE
6521 * syntax.c (syntax_temp): Define only if !__GNUC__.
6522
b7c513d0
PE
6523 * sound.c (current_sound_device, current_sound): Now static.
6524
989b29ad
PE
6525 * search.c (searchbufs, searchbuf_head): Now static.
6526
13a55a78
PE
6527 * scroll.c (scroll_cost): Remove; unused.
6528 * dispextern.h (scroll_cost): Remove decl.
6529
de68a1fc
PE
6530 * region-cache.h (pp_cache): Mark as externally visible.
6531
40ccffa6
PE
6532 * process.c: Make symbols static if they're not exported.
6533 (process_tick, update_tick, create_process, chan_process):
6534 (Vprocess_alist, proc_buffered_char, datagram_access):
6535 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6536 (deactivate_process): Mark defn as static, as well as decl.
6537 * lisp.h (create_process): Remove decl.
6538 * process.h (chan_process, Vprocess_alist): Remove decls.
6539
ad64fc97
PE
6540 * print.c: Make symbols static if they're not exported.
6541 (print_depth, new_backquote_output, being_printed, print_buffer):
6542 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6543 (print_interval, print_number_index, initial_stderr_stream):
6544 Now static.
6545 * lisp.h (Fprinc): Remove decl.
6546 (debug_output_compilation_hack): Mark as externally visible.
6547
adddb265
PE
6548 * sysdep.c (croak): Move decl from here to syssignal.h.
6549 * syssignal.h (croak): Put it here, so the API can be checked when
6550 'croak' is called from dissociate_if_controlling_tty.
6551
1717ede2
PE
6552 * minibuf.c: Make symbols static if they're not exported.
6553 (minibuf_save_list, choose_minibuf_frame): Now static.
6554 * lisp.h (choose_minibuf_frame): Remove decl.
6555
fa5fb2bc
PE
6556 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6557
1e3890d1
PE
6558 * lread.c: Make symbols static if they're not exported.
6559 (read_objects, initial_obarray, oblookup_last_bucket_number):
6560 Now static.
6561 (make_symbol): Remove; unused.
6562 * lisp.h (initial_obarray, make_symbol): Remove decls.
6563
8a1414fa
PE
6564 * keyboard.c: Make symbols static if they're not exported.
6565 (single_kboard, recent_keys_index, total_keys, recent_keys):
6566 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6567 (this_single_command_key_start, echoing, last_auto_save):
6568 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6569 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6570 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6571 (Vlispy_mouse_stem, double_click_count):
6572 Now static.
6573 (force_auto_save_soon): Define only if SIGDANGER.
6574 (ignore_mouse_drag_p): Now static if
6575 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6576 (print_help): Remove; unused.
6577 (stop_character, last_timer_event): Mark as externally visible.
6578 * keyboard.h (ignore_mouse_drag_p): Declare only if
6579 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6580 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6581 * lisp.h (echoing): Remove decl.
6582 (force_auto_save_soon): Declare only if SIGDANGER.
6583 * xdisp.c (redisplay_window): Simplify code, to make it more
6584 obvious that ignore_mouse_drag_p is not accessed if !defined
6585 USE_GTK && !defined HAVE_NS.
6586
93ea6e8f
PE
6587 * intervals.c: Make symbols static if they're not exported.
6588 (merge_properties_sticky, merge_interval_right, delete_interval):
6589 Now static.
6590 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6591
77382fcc
PE
6592 * insdel.c: Make symbols static if they're not exported.
6593 However, leave prepare_to_modify_buffer alone. It's never
6594 called from outside this function, but that appears to be a bug.
6595 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6596 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6597 (adjust_after_replace_noundo): Remove; unused.
6598 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6599 (signal_before_change): Remove decls.
77382fcc 6600
9306c32e
PE
6601 * indent.c (val_compute_motion, val_vmotion): Now static.
6602
cd44d2eb
PE
6603 * image.c: Make symbols static if they're not exported.
6604 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6605 if USE_GTK.
6606 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6607 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6608
ad9a7a06
PE
6609 * fringe.c (standard_bitmaps): Now static.
6610 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6611
81626931
PE
6612 * frame.c: Make symbols static if they're not exported.
6613 (x_report_frame_params, make_terminal_frame): Now static.
6614 (get_frame_param): Now static, unless HAVE_NS.
6615 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6616 (x_get_resource_string): Remove; not used.
6617 * frame.h (make_terminal_frame, x_report_frame_params):
6618 (x_get_resource_string); Remove decls.
6619 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6620 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6621
239f9db9
PE
6622 * font.c, fontset.c: Make symbols static if they're not exported.
6623 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6624 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6625 * font.c (font_close_object): Now static.
6626 * font.h (font_close_object): Remove.
6627 * fontset.c (FONTSET_OBJLIST): Remove.
6628 (free_realized_fontset) #if-0 the body, which does nothing.
6629 (face_suitable_for_char_p): #if-0, as it's never called.
6630 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6631 * xfaces.c (face_at_string_position):
6632 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6633 since 0 is always ASCII.
6634
dfcf3579
PE
6635 * fns.c (weak_hash_tables): Now static.
6636
5045092b
PE
6637 * fileio.c: Make symbols static if they're not exported.
6638 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6639 (Vwrite_region_annotation_buffers): Now static.
6640
57a96f5c
PE
6641 * eval.c: Make symbols static if they're not exported.
6642 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6643 * lisp.h (backtrace_list): Remove decl.
6644
35f08c38
PE
6645 * emacs.c: Make symbols static if they're not exported.
6646 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6647 (fatal_error_code, fatal_error_signal_hook, standard_args):
6648 Now static.
6649 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6650 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6651 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6652 * lisp.h (fatal_error_signal_hook): Remove decl.
6653 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6654
f44bd759
PE
6655 * editfns.c: Move a (normally-unused) function to its only use.
6656 * editfns.c, lisp.h (get_operating_system_release): Remove.
6657 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6658 worth the hassle of breaking this out.
6659
b532497d
PE
6660 * xterm.c: Make symbols static if they're not exported.
6661 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6662 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6663 (x_destroy_window, x_delete_display):
6664 Now static.
6665 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6666 (x_mouse_leave): Remove; unused.
6667 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6668 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6669 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6670 Remove decls.
6671 (x_mouse_leave): Declare only if WINDOWSNT.
6672 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6673 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6674 USE_X_TOOLKIT.
6675
1675728f
PE
6676 * ftxfont.c: Make symbols static if they're not exported.
6677 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6678 HAVE_FREETYPE.
6679 * font.h (ftxfont_driver): Likewise.
6680
e4cebfca
PE
6681 * xfns.c: Make symbols static if they're not exported.
6682 (x_last_font_name, x_display_info_for_name):
6683 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6684 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6685 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6686 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6687 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6688 (last_show_tip_args): Now static.
6689 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6690 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6691 (x_screen_planes): Remove; unused.
6692 * dispextern.h (x_screen_planes): Remove decl.
6693
5bf46f05
PE
6694 * dispnew.c: Make symbols static if they're not exported.
6695 * dispextern.h (redraw_garbaged_frames, scrolling):
6696 (increment_row_positions): Remove.
6697 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6698 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6699 Now static.
6700 (redraw_garbaged_frames): Remove; unused.
6701
435f4c28
PE
6702 * xfaces.c: Make symbols static if they're not exported.
6703 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6704 Remove decls.
6705 * xterm.h (defined_color): Remove decls.
6706 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6707 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6708 (menu_face_changed_default, defined_color, free_realized_face):
6709 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6710 (ascii_face_of_lisp_face): Remove; unused.
6711
8524aef3
PE
6712 * xdisp.c: Make symbols static if they're not exported.
6713 * dispextern.h (scratch_glyph_row, window_box_edges):
6714 (glyph_to_pixel_coords, set_cursor_from_row):
6715 (get_next_display_element, set_iterator_to_next):
6716 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6717 (show_mouse_face): Remove decls
6718 * frame.h (message_buf_print): Likewise.
6719 * lisp.h (pop_message, set_message, check_point_in_composition):
6720 Likewise.
6721 * xterm.h (set_vertical_scroll_bar): Likewise.
6722 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6723 (message_buf_print, scratch_glyph_row, displayed_buffer):
6724 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6725 (get_next_display_element, show_mouse_face, window_box_edges):
6726 (frame_to_window_pixel_xy, check_point_in_composition):
6727 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6728 (glyph_to_pixel_coords): Remove; unused.
6729
16390cd2
PE
6730 * dired.c (file_name_completion): Now static.
6731
6732 * dbusbind.c (xd_in_read_queued_messages): Now static.
6733
a25f4dfa
PE
6734 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6735 * data.c (circular_list_error): Remove.
6736
14a9c8df
PE
6737 * commands.h (last_point_position, last_point_position_buffer):
6738 (last_point_position_window): Remove decls.
6739 * keyboard.c: Make these variables static.
6740
04f2d78b
CB
6741 * coding.h (coding, code_convert_region, encode_coding_gap):
6742 Remove decls.
74ab6df5
PE
6743 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6744 (iso_code_class, detect_coding, code_convert_region): Now static.
6745 (encode_coding_gap): Remove; unused.
6746
38dfbee1
PE
6747 * chartab.c (chartab_chars, chartab_bits): Now static.
6748
a2cb4e63
PE
6749 * charset.h (charset_iso_8859_1): Remove decl.
6750 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6751 Now static.
6752
127198fd
PE
6753 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6754 * ccl.c (Vccl_program_table): Now static.
6755 (check_ccl_update): Remove; unused.
6756
d85b608f
PE
6757 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6758 * category.h: ... from here.
6759 * category.c (check_category_table, set_category_set): Now static.
6760
31cd66f3
PE
6761 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6762 * lisp.h: Remove these decls.
6763
c358e587
PE
6764 * buffer.c (buffer_count): Remove unused var.
6765
e78aecca
PE
6766 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6767 so that it's not optimized away.
6768 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6769 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6770 exported only to the debugger.
6771
e192d7d3 6772 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6773 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6774
92470028
PE
6775 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6776 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6777 was inaccessible from Lisp.
6778 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6779 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6780
244ed907
PE
6781 alloc.c: Import and export fewer symbols, and remove unused items.
6782 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6783 is defined.
6784 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6785 it's not optimized away by whole-program optimization.
6786 (message_enable_multibyte, free_misc): Remove.
6787 (catchlist, handlerlist, mark_backtrace):
6788 Declare only if BYTE_MARK_STACK.
6789 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6790 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6791 (message_enable_multibyte): Remove decl.
6792 (free_misc, interval_free_list, float_block, float_block_index):
6793 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6794 (cons_free_list, last_marked_index):
6795 Now static.
6796 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6797 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6798 (mark_backtrace): Define only if BYTE_MARK_STACK.
6799 * xdisp.c (message_enable_multibyte): Now static.
6800
61c2b50e 6801 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6802 This makes it easier for human readers (and static analyzers)
6803 to see whether these variables are used from other modules.
6804 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6805 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6806 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6807 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6808 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6809 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6810 * xmenu.c, xselect.c:
6811 Declare Q* vars static if they are not used in other modules.
6812 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6813 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6814 Remove decls of unexported vars.
6815 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6816
95c82688
PE
6817 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6818
16a97296
PE
6819 Make Emacs functions such as Fatom 'static' by default.
6820 This makes it easier for human readers (and static analyzers)
6821 to see whether these functions can be called from other modules.
6822 DEFUN now defines a static function. To make the function external
6823 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6824 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6825 (Finit_image_library):
16a97296
PE
6826 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6827 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6828 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6829 Remove decls, since these functions are now static.
6830 (Funintern, Fget_internal_run_time): New decls, since these functions
6831 were already external.
95c82688 6832
16a97296
PE
6833 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6834 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6835 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6836 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6837 * keyboard.c, keymap.c, lread.c:
6838 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6839 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6840 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6841 Mark functions with DEFUE instead of DEFUN,
6842 if they are used in other modules.
6843 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6844 decls for now-static functions.
6845 * buffer.h (Fdelete_overlay): Remove decl.
6846 * callproc.c (Fgetenv_internal): Mark as internal.
6847 * composite.c (Fremove_list_of_text_properties): Remove decl.
6848 (Fcomposition_get_gstring): New forward static decl.
6849 * composite.h (Fcomposite_get_gstring): Remove decl.
6850 * dired.c (Ffile_attributes): New forward static decl.
6851 * doc.c (Fdocumntation_property): New forward static decl.
6852 * eval.c (Ffetch_bytecode): New forward static decl.
6853 (Funintern): Remove extern decl; now in .h file where it belongs.
6854 * fileio.c (Fmake_symbolic_link): New forward static decl.
6855 * image.c (Finit_image_library): New forward static decl.
6856 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6857 * intervals.h (Fprevious_property_change):
6858 (Fremove_list_of_text_properties): Remove decls.
6859 * keyboard.c (Fthis_command_keys): Remove decl.
6860 (Fcommand_execute): New forward static decl.
6861 * keymap.c (Flookup_key): New forward static decl.
6862 (Fcopy_keymap): Now static.
6863 * keymap.h (Flookup_key): Remove decl.
6864 * process.c (Fget_process): New forward static decl.
6865 (Fprocess_datagram_address): Mark as internal.
6866 * syntax.c (Fsyntax_table_p): New forward static decl.
6867 (skip_chars): Remove duplicate decl.
6868 * textprop.c (Fprevious_property_change): New forward static decl.
6869 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6870 Now internal.
6871 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6872 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6873
785bbd42
PE
6874 * editfns.c (Fformat): Remove unreachable code.
6875
8b913b57
AS
68762011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6877
6878 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6879 change. (Bug#8496)
6880
a6744a35
EZ
68812011-04-13 Eli Zaretskii <eliz@gnu.org>
6882
6883 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6884 when at ZV. (Bug#8487)
6885
e7974947
AS
68862011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6887
baad03f0
AS
6888 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6889 (Bug#8437)
6890 * keyboard.c (parse_tool_bar_item): Likewise.
6891 * sound.c (sound_cleanup, alsa_close): Likewise.
6892 * termcap.c (tgetent): Likewise.
6893 * xfns.c (x_default_font_parameter): Likewise.
6894 * xsettings.c (read_and_apply_settings): Likewise.
6895
e7974947
AS
6896 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6897 (overrun_check_free): Protoize.
6898
28272684
PE
68992011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6900
6901 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6902 since callers should never pass a negative size.
6903 Change the signature to match that of plain 'read' and 'write'; see
6904 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6905 * lisp.h: Update prototypes of emacs_write and emacs_read.
6906
11997c76
EZ
69072011-04-11 Eli Zaretskii <eliz@gnu.org>
6908
6909 * xdisp.c (redisplay_window): Don't try to determine the character
6910 position of the scroll margin if the window start point w->startp
e896f03c 6911 is outside the buffer's accessible region. (Bug#8468)
11997c76 6912
8a2cbd72
EZ
69132011-04-10 Eli Zaretskii <eliz@gnu.org>
6914
6915 Fix write-region and its subroutines for buffers > 2GB.
6916 * fileio.c (a_write, e_write): Modify declaration of arguments and
6917 local variables to support buffers larger than 2GB.
6918 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6919
6920 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6921 argument, local variables, and return value.
6922
6923 * lisp.h: Update prototypes of emacs_write and emacs_read.
6924
6925 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6926
4073e537 69272011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6928
1ebfdcb6
PE
6929 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6930
b2ded58d
PE
6931 Fix more problems found by GCC 4.6.0's static checks.
6932
7d66342c
PE
6933 * xdisp.c (vmessage): Use a better test for character truncation.
6934
bbf47d44
PE
6935 * charset.c (load_charset_map): <, not <=, for optimization,
6936 and to avoid potential problems with integer overflow.
9248994d 6937 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6938 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6939 * editfns.c (Fformat): Likewise.
1e69125e 6940 * syntax.c (skip_chars): Likewise.
3befa583 6941
e3019616
PE
6942 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6943 This also lets GCC 4.6.0 generate slightly better loop code.
6944
becfa255
PE
6945 * callint.c (Fcall_interactively): <, not <=, for optimization.
6946 (Fcall_interactively): Count the number of arguments produced,
6947 not the number of arguments given. This is simpler and lets GCC
6948 4.6.0 generate slightly better code.
6949
dae0cd48
PE
6950 * ftfont.c: Distingish more carefully between FcChar8 and char.
6951 The previous code passed unsigned char * to a functions like
6952 strlen and xstrcasecmp that expect char *, which does not
6953 conform to the C standard.
6954 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6955 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6956 char * when the C standard requires it.
6957
76032d70
PE
6958 * keyboard.c (read_char): Remove unused var.
6959
eb3f1cc8
PE
6960 * eval.c: Port to Windows vsnprintf (Bug#8435).
6961 Include <limits.h>.
6962 (SIZE_MAX): Define if the headers do not.
6963 (verror): Do not give up if vsnprintf returns a negative count.
6964 Instead, grow the buffer. This ports to Windows vsnprintf, which
6965 does not conform to C99. Problem reported by Eli Zaretskii.
6966 Also, simplify the allocation scheme, by avoiding the need for
6967 calling realloc, and removing the ALLOCATED variable.
6968
70476b54
PE
6969 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6970
12020a9e
PE
6971 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6972 But keep the doprint source code for now, as we might revamp it
6973 and use it again (Bug#8435).
ea6c7ae6
PE
6974 * lisp.h (doprnt): Remove.
6975 * Makefile.in (base_obj): Remove doprnt.o.
6976 * deps.mk (doprnt.o): Remove.
6977
5fdb398c
PE
6978 error: Print 32- and 64-bit integers portably (Bug#8435).
6979 Without this change, on typical 64-bit hosts error ("...%d...", N)
6980 was used to print both 32- and 64-bit integers N, which relied on
6981 undefined behavior.
6982 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6983 New macro.
6984 * lisp.h (error, verror): Mark as printf-like functions.
6985 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6986 Report overflow in size calculations when allocating printf buffer.
6987 Do not truncate output string at its first null byte.
6988 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6989 Truncate the output at a character boundary, since vsnprintf does not
6990 do that.
6991 * charset.c (check_iso_charset_parameter): Convert internal
6992 character to string before calling 'error', since %c now has the
6993 printf meaning.
6994 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6995 overflow when computing char to be passed to 'error'. Do not
6996 pass Lisp_Object to 'error'; pass the integer instead.
6997 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6998 formatted with plain %d.
6999
b189fa66
PE
7000 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7001
bff87ef0
PE
7002 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7003
7e2cac20
PE
7004 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7005
ce4d90b5
PE
7006 * xterm.c (x_catch_errors): Remove duplicate declaration.
7007
266c9547
PE
7008 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7009
79c49ad2
PE
7010 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7011
368f4090
JM
70122011-04-10 Jim Meyering <meyering@redhat.com>
7013
7014 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7015 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7016 return ssize_t not "int", and use size_t as the buffer length.
7017 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7018 * gnutls.h: Update declarations.
7019 * process.c (read_process_output): Use ssize_t, to match.
7020 (send_process): Likewise.
7021
a32d4040
CY
70222011-04-09 Chong Yidong <cyd@stupidchicken.com>
7023
7024 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7025
8546720e 70262011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7027
04f2d78b
CB
7028 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7029 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7030
8546720e
GM
7031 * xterm.c (handle_one_xevent):
7032 * xmenu.c (create_and_show_popup_menu):
7033 * xselect.c (x_decline_selection_request)
7034 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7035
0a2f5c1a 70362011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7037
7038 Fix some uses of `int' instead of EMACS_INT.
7039 * search.c (string_match_1, fast_string_match)
7040 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7041 (scan_buffer, find_next_newline_no_quit)
7042 (find_before_next_newline, search_command, Freplace_match)
7043 (Fmatch_data): Make some `int' variables be EMACS_INT.
7044
7045 * xdisp.c (display_count_lines): 3rd argument and return value now
7046 EMACS_INT. All callers changed.
7047 (pint2hrstr): Last argument is now EMACS_INT.
7048
7049 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7050 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7051 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7052 (decode_coding_utf_16, decode_coding_emacs_mule)
7053 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7054 (decode_coding_ccl, decode_coding_charset)
7055 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7056 (decode_coding_iso_2022, decode_coding_emacs_mule)
7057 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7058 <char_offset, last_offset>: Declare EMACS_INT.
7059 (encode_coding_utf_8, encode_coding_utf_16)
7060 (encode_coding_emacs_mule, encode_invocation_designation)
7061 (encode_designation_at_bol, encode_coding_iso_2022)
7062 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7063 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7064 Declare EMACS_INT.
7065 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7066 (encode_invocation_designation): Last argument P_NCHARS is now
7067 EMACS_INT.
7068 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7069 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7070
7071 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7072 All users changed.
7073
7074 * ccl.c (Fccl_execute_on_string): Declare some variables
7075 EMACS_INT.
7076
8546720e 70772011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7078
7079 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7080
4e19a977
CS
70812011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7082
7083 * process.c (Fformat_network_address): Doc fix.
7084
87302331
R
70852011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7086
7087 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7088
cbb59342
CY
70892011-04-08 Chong Yidong <cyd@stupidchicken.com>
7090
7091 * keyboard.c (read_char): Call Lisp function help-form-show,
7092 instead of using internal_with_output_to_temp_buffer.
7093 (Qhelp_form_show): New var.
e0d38eeb 7094 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7095
7096 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7097
7098 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7099
e67a13ab
CY
71002011-04-06 Chong Yidong <cyd@stupidchicken.com>
7101
04f2d78b
CB
7102 * process.c (Flist_processes): Remove to Lisp.
7103 (list_processes_1): Delete.
e67a13ab 7104
973f782d
EZ
71052011-04-06 Eli Zaretskii <eliz@gnu.org>
7106
7c106b1e
EZ
7107 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7108
973f782d
EZ
7109 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7110
41cf7d1a 71112011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7112
ca23cc88
PE
7113 Fix more problems found by GCC 4.6.0's static checks.
7114
f390e2d5
PE
7115 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7116
42eea0d0
PE
7117 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7118
b69769da 7119 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7120
f9541e84
PE
7121 * xdisp.c (vmessage): Mark as a printf-like function.
7122
13841b55
PE
7123 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7124
c136c10f
PE
7125 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7126
5e2d4a30
PE
7127 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7128 printf-like functions.
7129 (tiff_load): Add casts to remove these marks before passing them
7130 to system-supplied API.
7131
583f48b9
PE
7132 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7133
b25d760e
PE
7134 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7135 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7136 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7137 directly, rather than having caller test rule sign. This avoids
7138 some unnecessary tests.
7139 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7140 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7141 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7142
bc7b6697 7143 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7144 (xfont_open): Avoid unnecessary tests.
bc7b6697 7145
27ccc379
PE
7146 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7147
dcd5c89a
PE
7148 * composite.h, composite.c (composition_gstring_put_cache):
7149 Use EMACS_INT, not int, for length.
7150
b13a45c6
PE
7151 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7152 breaking out part of COMPOSITION_DECODE_RULE.
7153 (COMPOSITION_DECODE_RULE): Use it.
7154 * composite.c (get_composition_id): Remove unused local vars,
7155 by using the new macro.
7156
1e792e4d
PE
7157 * textprop.c (set_text_properties_1): Change while to do-while,
7158 since the condition is always true at first.
7159
dc6c6455 7160 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7161 (interval_deletion_adjustment): Return unsigned value.
7162 All uses changed.
dc6c6455 7163
aba7731a
PE
7164 * process.c (list_processes_1, create_pty, read_process_output):
7165 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7166 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7167 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7168 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7169 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7170
fdfc4bf3
PE
7171 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7172
fca8fe46 7173 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7174 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7175
06a0259a 7176 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7177 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7178 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7179
e7b9e80f
PE
7180 * print.c (print_error_message): Avoid int overflow.
7181
56201685
PE
7182 * font.c (font_list_entities): Redo for clarity,
7183 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7184
78834453 7185 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7186 (font_score): Avoid potential overflow in diff calculation.
78834453 7187
0bc0b309 7188 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7189 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7190
e610eaca
PE
7191 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7192
b895abce
PE
7193 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7194 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7195 can always succeed if overflow has undefined behavior.
7196
1f1d9321 7197 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7198 (wordify): Omit three unnecessary tests.
1f1d9321 7199
c59478bc
PE
7200 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7201 All callers changed. This avoids the need for an unused var.
7202
79b73827
PE
7203 * casefiddle.c (casify_region): Remove var that is set but not used.
7204
a4db5dfe
PE
7205 * dired.c (file_name_completion): Remove var that is set but not used.
7206
43aae36e
PE
7207 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7208
2a47c44d 7209 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7210 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7211
a37c69bf
PE
7212 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7213 Check for integer overflow on size calculations.
7214
328ab8e7
PE
7215 * buffer.c (Fprevious_overlay_change): Remove var that is set
7216 but not used.
7217
e5a2a5cb
PE
7218 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7219 Remove vars that are set but not used.
8d84a6eb 7220 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7221 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7222
a60e5f68
PE
7223 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7224
f661cb61 7225 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7226 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7227
f0397f5a
PE
7228 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7229 that are set but not used.
7230
8664db06 7231 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7232 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7233
6abdaa4a
PE
7234 * xselect.c (x_get_local_selection, x_handle_property_notify):
7235 Remove vars that are set but not used.
7236
0ce7538d 7237 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7238 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7239
9ae848fc
PE
7240 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7241 Remove var that is set but not used.
0b918413
PE
7242 (scroll_bar_windows_size): Now size_t, not int.
7243 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7244 Check for overflow.
9ae848fc 7245
a5a62657
PE
7246 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7247 (map_tty_color) [!defined MSDOS]: Likewise.
7248
5c5cdd39
PE
7249 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7250
66ebf983
PE
7251 * coding.c: Remove vars that are set but not used.
7252 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7253 All callers changed.
7254 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7255 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7256 (decode_coding_charset): Remove vars that are set but not used.
7257
1be4d761
PE
7258 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7259 that is set but not used.
7260
47553fa8
PE
7261 * print.c (print_object): Remove var that is set but not used.
7262
1f7196bf 7263 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7264 The gnulib version avoids calling malloc in the usual case,
7265 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7266 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7267 * filelock.c (current_lock_owner): Likewise.
7268 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7269 * sysdep.c: Include allocator.h, careadlinkat.h.
7270 (emacs_no_realloc_allocator): New static constant.
7271 (emacs_readlink): New function.
fdb61804
PE
7272 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7273 ../lib/careadlinkat.h.
d1fdcab7 7274
f84c17c7
SM
72752011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7276
7277 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7278 first non-nil return value).
7279
ef3862ad
JD
72802011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7281
7282 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7283 if not defined (Bug#8403).
7284
376a7006
JB
72852011-04-02 Juanma Barranquero <lekktu@gmail.com>
7286
7287 * xdisp.c (display_count_lines): Remove parameter `start',
7288 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7289 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7290 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7291 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7292 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7293 and thereabouts. All callers changed.
7294 (get_per_char_metric): Remove parameter `f', unused since
7295 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7296
6ca3801d
JM
72972011-04-02 Jim Meyering <meyering@redhat.com>
7298
7299 do not dereference NULL upon failed strdup
7300 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7301 (ns_get_family): Likewise.
7302
d8e2b5ba
JB
73032011-04-02 Juanma Barranquero <lekktu@gmail.com>
7304
7305 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7306
8c74fcbd
JD
73072011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7308
7309 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7310 later (Bug#8403).
7311
7200d79c
SM
73122011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7313
03408648 7314 Add lexical binding.
7200d79c 7315
03408648
SM
7316 * window.c (Ftemp_output_buffer_show): New fun.
7317 (Fsave_window_excursion):
7318 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7319
7320 * lread.c (lisp_file_lexically_bound_p): New function.
7321 (Fload): Bind Qlexical_binding.
7322 (readevalloop): Remove `evalfun' arg.
7323 Bind Qinternal_interpreter_environment.
7324 (Feval_buffer): Bind Qlexical_binding.
7325 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7326 Mark as dynamic.
7327 (syms_of_lread): Declare `lexical-binding'.
7328
7329 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7330
7331 * keyboard.c (eval_dyn): New fun.
7332 (menu_item_eval_property): Use it.
ca105506
SM
7333
7334 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7335
03408648
SM
7336 * fns.c (concat, mapcar1): Accept byte-code-functions.
7337
7338 * eval.c (Fsetq): Handle lexical vars.
7339 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7340 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7341 (FletX, Flet): Obey lexical binding.
7342 (Fcommandp): Handle closures.
7343 (Feval): New `lexical' arg.
7344 (eval_sub): New function extracted from Feval. Use it almost
7345 everywhere where Feval was used. Look up vars in lexical env.
7346 Handle closures.
7347 (Ffunctionp): Move from subr.el.
7348 (Ffuncall): Handle closures.
7349 (apply_lambda): Remove `eval_flags'.
7350 (funcall_lambda): Handle closures and new byte-code-functions.
7351 (Fspecial_variable_p): New function.
7352 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7353 but without exporting it to Lisp.
23aba0ea 7354
23aba0ea 7355 * doc.c (Fdocumentation, store_function_docstring):
03408648 7356 * data.c (Finteractive_form): Handle closures.
23aba0ea 7357
03408648
SM
7358 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7359 interactive spec.
ba83908c 7360
04f2d78b
CB
7361 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7362 New byte-codes.
03408648
SM
7363 (exec_byte_code): New function extracted from Fbyte_code to handle new
7364 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7365
03408648 7366 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7367
03408648 7368 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7369
e2abce01
JB
73702011-03-31 Juanma Barranquero <lekktu@gmail.com>
7371
7372 * xdisp.c (redisplay_internal): Fix prototype.
7373
63696a73 73742011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7375
63696a73 7376 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7377 (try_scrolling): Use it when setting scroll_limit.
7378 Limit scrolling to 100 screen lines.
63696a73
EZ
7379 (redisplay_window): Even when falling back on "recentering",
7380 position point in the window according to scroll-conservatively,
7381 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7382
7383 (try_scrolling): When point is above the window, allow searching
7384 as far as scroll_max, or one screenful, to compute vertical
7385 distance from PT to the scroll margin position. This prevents
7386 try_scrolling from unnecessarily failing when
7387 scroll-conservatively is set to a value slightly larger than the
7388 window height. Clean up the case of PT below the margin at bottom
7389 of window: scroll_max can no longer be INT_MAX. When aggressive
7390 scrolling is in use, don't let point enter the opposite scroll
7391 margin as result of the scroll.
7392 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7393 threshold of 100 lines for never-recentering scrolling.
7394
e4cc2dfc
JB
73952011-03-31 Juanma Barranquero <lekktu@gmail.com>
7396
7397 * dispextern.h (move_it_by_lines):
7398 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7399 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7400 (message_log_check_duplicate): Remove parameters `prev_bol' and
7401 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7402 (redisplay_internal): Remove parameter `preserve_echo_area',
7403 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7404
7405 * indent.c (Fvertical_motion):
7406 * window.c (window_scroll_pixel_based, Frecenter):
7407 Don't pass `need_y_p' to `move_it_by_lines'.
7408
1c470562
SM
74092011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7410
44f230aa
SM
7411 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7412 steal a few bits to be more compact.
7413 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7414 Remove unneeded casts.
7415
1c470562
SM
7416 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7417
888adce9
ZK
74182011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7419
7420 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7421 binding" message (bug#7967).
7422
f838ed7b
PE
74232011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7424
77861b95
PE
7425 Fix more problems found by GCC 4.6.0's static checks.
7426
de6dbc14
PE
7427 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7428 Remove unused local var.
7429
f838ed7b
PE
7430 * editfns.c (Fmessage_box): Remove unused local var.
7431
792c7b2b
PE
7432 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7433 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7434 Omit unused local vars.
c499e557 7435 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7436 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7437 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7438 Omit unused local var.
7439
ba0165e1
PE
7440 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7441 Don't assume string length fits in int.
32ad8845 7442 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7443 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7444
3c59b4c9
PE
7445 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7446 instead of alloca (Bug#8344).
7447
a3eed478 7448 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7449 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7450
eb4d412d
PE
7451 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7452
1658b401
PE
7453 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7454 concerns.
7455
7456 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7457
7458 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7459
9a2c6e05
PE
7460 * keyboard.c (syms_of_keyboard): Use the same style as later
7461 in this function when indexing through an array. This also
7462 works around GCC bug 48267.
7463
03d0a109
PE
7464 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7465
44f730c8
PE
7466 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7467
fe75f926
PE
7468 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7469 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7470
ffa8c828
PE
7471 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7472 This avoids undefined behavior on integer overflow, and is a bit
7473 more convenient anyway since it is compared to a size_t variable.
7474
c5101a77
PE
7475 Variadic C functions now count arguments with size_t, not int.
7476 This avoids an unnecessary limitation on 64-bit machines, which
7477 caused (substring ...) to crash on large vectors (Bug#8344).
7478 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7479 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7480 All variadic functions and their callers changed accordingly.
c5101a77
PE
7481 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7482 * data.c (arith_driver, float_arith_driver): Likewise.
7483 * editfns.c (general_insert_function): Likewise.
7484 * eval.c (struct backtrace.nargs, interactive_p)
7485 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7486 (funcall_lambda, mark_backtrace): Likewise.
7487 * fns.c (concat): Likewise.
7488 * frame.c (x_set_frame_parameters): Likewise.
7489 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7490 0 if not found, not -1. All callers changed.
7491
dd3f25f7
PE
7492 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7493 (stack_copy_size): Now size_t, not int.
7494 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7495
461c2ab9
JB
74962011-03-28 Juanma Barranquero <lekktu@gmail.com>
7497
7498 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7499 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7500 All callers changed.
7501
7502 * lisp.h (multibyte_char_to_unibyte):
7503 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7504 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7505 * character.h (CHAR_TO_BYTE8):
7506 * cmds.c (internal_self_insert):
7507 * editfns.c (general_insert_function):
7508 * keymap.c (push_key_description):
7509 * search.c (Freplace_match):
7510 * xdisp.c (message_dolog, set_message_1): All callers changed.
7511
f6d62986
SM
75122011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7513
7514 * keyboard.c (safe_run_hook_funcall): New function.
7515 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7516 don't set the hook to nil, but remove the offending function instead.
7517 (Qcommand_hook_internal): Remove, unused.
7518 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7519 Vcommand_hook_internal.
7520
7521 * eval.c (enum run_hooks_condition): Remove.
7522 (funcall_nil, funcall_not): New functions.
7523 (run_hook_with_args): Call each function through a `funcall' argument.
7524 Remove `cond' argument, now redundant.
7525 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7526 (Frun_hook_with_args_until_failure): Adjust accordingly.
7527 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7528
1db5b1ad
JB
75292011-03-28 Juanma Barranquero <lekktu@gmail.com>
7530
7531 * dispextern.h (string_buffer_position): Remove declaration.
7532
7533 * print.c (strout): Remove parameter `multibyte', unused since
7534 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7535
7536 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7537 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7538 All callers changed.
7539
7540 * w32.c (_wsa_errlist): Use braces for struct initializers.
7541
7542 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7543 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7544 All callers changed.
7545 (string_buffer_position): Likewise. Also, make static (it's never
7546 used outside xdisp.c).
7547 (cursor_row_p): Remove parameter `w', unused since
7548 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7549 (decode_mode_spec): Remove parameter `precision', introduced during
7550 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7551 All callers changed.
7552
5ffb62aa
JD
75532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7554
7555 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7556
461c2ab9 75572011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7558
7559 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7560 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7561 (ns_update_auto_hide_menu_bar): New functions.
7562 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7563 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7564 ns_constrain_all_frames.
7565 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7566 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7567
5c380ffb
JD
75682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7569
7570 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7571
9af30bdf
GM
75722011-03-27 Glenn Morris <rgm@gnu.org>
7573
7574 * syssignal.h: Replace RETSIGTYPE with void.
7575 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7576 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7577 Replace SIGTYPE with void everywhere.
7578 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7579 * s/template.h (SIGTYPE): Remove commented out definition.
7580
e2abce01
JB
75812011-03-26 Eli Zaretskii <eliz@gnu.org>
7582
7583 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7584 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7585
f868cd8a
JB
75862011-03-26 Juanma Barranquero <lekktu@gmail.com>
7587
59eb0929
JB
7588 * w32.c (read_unc_volume): Use parameter `henum', instead of
7589 global variable `wget_enum_handle'.
7590
7591 * keymap.c (describe_vector): Remove parameters `indices' and
7592 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7593 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7594
f868cd8a
JB
7595 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7596
7597 * keyboard.c (timer_check): Remove parameter `do_it_now',
7598 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7599 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7600 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7601
7602 * keyboard.c (read_char):
7603 * w32menu.c (w32_menu_display_help):
7604 * xmenu.c (show_help_event, menu_help_callback):
7605 Adjust calls to `show_help_echo'.
7606
7607 * gtkutil.c (xg_maybe_add_timer):
7608 * keyboard.c (readable_events):
7609 * process.c (wait_reading_process_output):
7610 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7611
7612 * insdel.c (adjust_markers_gap_motion):
7613 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7614 (gap_left, gap_right): Don't call it.
7615
2ecf6fdb
CY
76162011-03-25 Chong Yidong <cyd@stupidchicken.com>
7617
7618 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7619 incurred during fontification.
7620
6b1f9ba4
JB
76212011-03-25 Juanma Barranquero <lekktu@gmail.com>
7622
7623 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7624 (DEFVAR_PER_BUFFER): Don't pass it.
7625
7626 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7627 (scrolling_window): Don't pass it.
7628
0f4a96b5
JB
76292011-03-25 Juanma Barranquero <lekktu@gmail.com>
7630
7631 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7632
7633 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7634 and `suffix'.
7635 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7636 of variables specific to SELinux and computation of `encoded_absname'.
7637
7638 * image.c (XPutPixel): Remove unused variable `height'.
7639
7640 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7641
7642 * unexw32.c (get_section_info): Remove unused variable `section'.
7643
7644 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7645 (system_process_attributes): Remove unused variable `sess'.
7646 (sys_read): Remove unused variable `err'.
7647
7648 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7649 (w32_wnd_proc): Remove unused variable `isdead'.
7650 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7651 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7652 (x_create_tip_frame): Remove unused variable `tem'.
7653
7654 * w32inevt.c (w32_console_read_socket):
7655 Remove unused variable `no_events'.
7656
7657 * w32term.c (x_draw_composite_glyph_string_foreground):
7658 Remove unused variable `width'.
7659
1149507c
JB
76602011-03-24 Juanma Barranquero <lekktu@gmail.com>
7661
7662 * w32term.c (x_set_glyph_string_clipping):
7663 Don't pass uninitialized region to CombineRgn.
7664
9c88f339
JB
76652011-03-23 Juanma Barranquero <lekktu@gmail.com>
7666
7667 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7668 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7669 (Fx_close_connection): Remove unused variable `i'.
7670
7671 * w32font.c (w32font_draw): Return number of glyphs.
7672 (w32font_open_internal): Remove unused variable `i'.
7673 (w32font_driver): Add missing initializer.
7674
7675 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7676 (fill_in_menu): Remove unused variable `items_added'.
7677
7678 * w32term.c (last_mouse_press_frame): Remove static global variable.
7679 (w32_clip_to_row): Remove unused variable `f'.
7680 (x_delete_terminal): Remove unused variable `i'.
7681
7682 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7683 (NOTHING): Remove unused static global variable.
7684 (uniscribe_check_otf): Remove unused variable `table'.
7685 (uniscribe_font_driver): Add missing initializers.
7686
dee091a3
JD
76872011-03-23 Julien Danjou <julien@danjou.info>
7688
7689 * term.c (Fsuspend_tty, Fresume_tty):
7690 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7691 * window.c (temp_output_buffer_show):
7692 * insdel.c (signal_before_change):
7693 * frame.c (Fhandle_switch_frame):
7694 * fileio.c (Fdo_auto_save):
7695 * emacs.c (Fkill_emacs):
7696 * editfns.c (save_excursion_restore):
7697 * cmds.c (internal_self_insert):
7698 * callint.c (Fcall_interactively):
7699 * buffer.c (Fkill_all_local_variables):
7700 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7701 Use Frun_hooks.
0f4a96b5 7702 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7703 unconditionnaly since it does the check itself.
7704
2c520ab5 77052011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7706
c9c49752
PE
7707 Fix more problems found by GCC 4.5.2's static checks.
7708
8abc3f12
PE
7709 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7710 the first time through the loop, since we know p0 < p1 then.
7711 This also avoids a gcc -Wstrict-overflow warning.
7712
a2d26660
PE
7713 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7714 leading to a memory leak, possible in functions like
7715 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7716 of objects (Bug#8318).
a2d26660 7717
916c72e9
PE
7718 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7719 that could (at least in theory) be that large.
7720
19ab8a18
PE
7721 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7722 This is less likely to overflow, and avoids undefined behavior if
7723 overflow does occur. All callers changed. Use strtoul to scan
7724 for the unsigned long integer.
b7cbbd6f
PE
7725 (pint2hrstr): Simplify and tune code slightly.
7726 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7727
f0641eff
PE
7728 * scroll.c (do_scrolling): Work around GCC bug 48228.
7729 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7730
7f650bb9
PE
7731 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7732 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7733 (validate_x_resource_name): Simplify count usage.
7734 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7735
37dd57d1
PE
7736 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7737 fail (Bug#8306).
81e56e61 7738
699979fc 7739 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7740
401bf9b4
PE
7741 * process.c (Fmake_network_process): Use socklen_t, not int,
7742 where POSIX says socklen_t is required in portable programs.
7743 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7744 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7745 (Fmake_network_process, server_accept_connection):
7746 (wait_reading_process_output, read_process_output):
7747 Likewise.
7748
b93aacde
PE
7749 * process.c: Rename or move locals to avoid shadowing.
7750 (list_processes_1, Fmake_network_process):
7751 (read_process_output_error_handler, exec_sentinel_error_handler):
7752 Rename or move locals.
4dc343ee 7753 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7754 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7755 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7756 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7757 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7758
af8a867c 7759 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7760 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7761 Include tparam.h instead, since it declares them.
af8a867c
PE
7762 * cm.h (PC): Remove extern decl; tparam.h now does this.
7763 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7764 * terminfo.c: Include tparam.h, to check interfaces.
7765 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7766 (tparam): Adjust signature to match interface in tparam.h;
7767 this removes some undefined behavior. Check that outstring and len
7768 are zero, which they always are with Emacs.
7769 * tparam.h (PC, BC, UP): New extern decls.
7770
0248044d 7771 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7772 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7773
8ff096c1 7774 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7775 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7776 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7777 (ftfont_list): Remove unused local.
49eaafba
PE
7778 (get_adstyle_property, ftfont_pattern_entity):
7779 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7780 Rename locals to avoid shadowing.
8ff096c1 7781
e2be39f6
PE
7782 * xfont.c (xfont_list_family): Mark var as initialized.
7783
c9735e30
PE
7784 * xml.c (make_dom): Now static.
7785
8f5201ae
PE
7786 * composite.c (composition_compute_stop_pos): Rename local to
7787 avoid shadowing.
b246f932
PE
7788 (composition_reseat_it): Remove unused locals.
7789 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7790 (composition_update_it): Mark var as initialized.
11b61122
PE
7791 (find_automatic_composition): Mark vars as initialized,
7792 with a FIXME (Bug#8290).
8f5201ae 7793
760fbc2c
PE
7794 character.h: Rename locals to avoid shadowing.
7795 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7796 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7797 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7798 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7799 to avoid shadowing.
7800
ff08eb85
PE
7801 * textprop.c (property_change_between_p): Remove; unused.
7802
fc7bf025
PE
7803 * intervals.c (interval_start_pos): Now static.
7804
235d7abc
PE
7805 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7806
44f230aa
SM
7807 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7808 Rename locals to avoid shadowing.
3e7d6594 7809
50060332
PE
7810 * sound.c (wav_play, au_play, Fplay_sound_internal):
7811 Fix pointer signedness.
d01f234b 7812 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7813 (wav_play): Initialize a variable to 0, to prevent undefined
7814 behavior (Bug#8278).
50060332 7815
c4fc4e30
PE
7816 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7817
918436ed
PE
7818 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7819
c939f91b
PE
7820 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7821 clobbering (Bug#8298).
b9c7f648
PE
7822 * sysdep.c (sys_subshell): Likewise.
7823 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7824
6bd8c144
PE
7825 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7826 This should get cleaned up, so that child_setup has the
7827 same signature on all platforms.
7828
7710357c 7829 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7830 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7831
c59da222
CY
78322011-03-22 Chong Yidong <cyd@stupidchicken.com>
7833
7834 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7835 not to be necessary, and produces flickering.
7836
66b87493
GM
78372011-03-20 Glenn Morris <rgm@gnu.org>
7838
7839 * config.in: Remove file.
7840
45b6f6d5
JB
78412011-03-20 Juanma Barranquero <lekktu@gmail.com>
7842
7843 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7844 are now in src/globals.h.
7845 (syms_of_minibuf): Remove spurious & from previous change.
7846
3ec03f7e
LL
78472011-03-20 Leo <sdl.web@gmail.com>
7848
7849 * minibuf.c (completing-read-function): New variable.
7850 (completing-read-default): Rename from completing-read.
7851 (completing-read): Call completing-read-function.
7852
b14e3e21
CY
78532011-03-19 Juanma Barranquero <lekktu@gmail.com>
7854
7855 * xfaces.c (Fx_load_color_file):
7856 Read color file from absolute filename (bug#8250).
7857
f2b726e6
JB
78582011-03-19 Juanma Barranquero <lekktu@gmail.com>
7859
7860 * makefile.w32-in: Update dependencies.
7861
09f6ff02
EZ
78622011-03-17 Eli Zaretskii <eliz@gnu.org>
7863
7864 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7865
29a6015a
PE
78662011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7867
a3a6c54e
PE
7868 Fix more problems found by GCC 4.5.2's static checks.
7869
b766f867
PE
7870 * process.c (make_serial_process_unwind, send_process_trap):
7871 (sigchld_handler): Now static.
7872
be02381c
PE
7873 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7874 That way, the code declares only the vars that it needs.
7875 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7876 * s/cygwin.h (PTY_ITERATION): Likewise.
7877 * s/darwin.h (PTY_ITERATION): Likewise.
7878 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7879
57048744
PE
7880 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7881 * process.c (allocate_pty): Don't declare stb unless it's needed.
7882
7914961c 7883 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7884 (CONSTANTLIM): Remove; unused.
7885 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7886 Define only if needed.
7914961c 7887
b3967b18
PE
7888 * unexelf.c (unexec): Name an expression,
7889 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7890 Use a different way to cause a compilation error if anyone uses
7891 n rather than nn, a way that does not involve shadowing.
73366a00 7892 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7893
29a6015a
PE
7894 * deps.mk (unexalpha.o): Remove; unused.
7895
43cfc33e 7896 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7897 * unexec.h: New file.
ce701a33
PE
7898 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7899 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7900 Depend on unexec.h.
7901 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7902 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7903 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7904 Change as necessary to match prototype in unexec.h.
ce701a33 7905
01f44d5a
PE
7906 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7907 shadowing.
4f63c6bb 7908 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7909
a6670b0b
PE
7910 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7911 Rename locals to avoid shadowing.
7912
cef2010d 7913 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7914 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7915
d4d7173a
PE
7916 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7917
f08b802a
PE
7918 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7919 warning when compiling print.c.
7920
3ddb0639
PE
7921 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7922 instead of using an uninitialized var.
5ad03b97 7923 (font_sort_entities): Mark var as initialized.
3ddb0639 7924
170a2692
PE
7925 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7926
e663c700
PE
7927 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7928 pointers to constants.
89bc529a 7929 (font_parse_fcname): Remove unused vars.
7b81e2d0 7930 (font_delete_unmatched): Now static.
ea838e10 7931 (font_get_spec): Remove; unused.
13a547c6
PE
7932 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7933 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7934 Rename or move locals to avoid shadowing.
e663c700 7935
2a80c887 7936 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7937 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7938
1384fa33 7939 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7940 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7941
8b2c52e9
PE
7942 * alloc.c (mark_backtrace): Move decl from here ...
7943 * lisp.h: ... to here, so that it can be checked.
7944
475545b5 7945 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7946 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7947 (lisp_indirect_variable): Name an expression,
7948 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7949 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7950
b1349114 7951 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7952 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7953 Use const pointer when appropriate.
b1349114 7954
a2928364
PE
7955 * lisp.h (get_system_name, get_operating_system_release):
7956 Move decls here, to check interfaces.
7957 * process.c (get_operating_system_release): Move decl to lisp.h.
7958 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7959 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7960 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7961 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7962 (Fformat_time_string, Fencode_time, Finsert_char):
7963 (Ftranslate_region_internal, Fformat):
7964 Rename or remove local vars to avoid shadowing.
9710023e 7965 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7966
a415e694
PE
7967 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7968 avoid shadowing.
7969
8ef4622d
PE
7970 * lisp.h (eassert): Check that the argument compiles, even if
7971 ENABLE_CHECKING is not defined.
7972
946f9a5b
PE
7973 * data.c (Findirect_variable): Name an expression, to avoid
7974 gcc -Wbad-function-cast warning.
112396d6 7975 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7976 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7977 (Fmake_variable_buffer_local, Fmake_local_variable):
7978 Mark variables as initialized.
52746918 7979 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7980
e5aab7e7 7981 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7982 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7983 Rename locals to avoid shadowing.
dff45157
PE
7984 (mark_stack): Move local variables into the #ifdef region where
7985 they're used.
7bc26fdb
PE
7986 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7987 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7988 needed otherwise.
7989 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7990 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7991 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7992
e5aab7e7
PE
7993 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7994 avoids undefined behavior in theory.
7995
4da60324
PE
7996 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7997
88043301
PE
7998 Use functions, not macros, for up- and down-casing (Bug#8254).
7999 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8000 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8001 to use the following functions instead of these macros.
8002 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8003 EMACS_INT, since callers assume the returned value fits in int.
8004 (upcase1): Likewise, for UPCASE_TABLE.
8005 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8006 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8007 the race-condition problem in the old DOWNCASE.
88043301 8008
19ed5445
PE
8009 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8010 Rename locals to avoid shadowing.
8011 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8012 (regex_compile, re_search_2, re_match_2_internal):
8013 Remove unused local vars.
952db0d7
PE
8014 (FREE_VAR): Rewrite so as not to use empty "else",
8015 which gcc can warn about.
da053e48 8016 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8017 (RETALLOC_IF): Define only if needed.
8018 (WORDCHAR_P): Likewise. This one is never needed, but is used
8019 only in a comment talking about a compiler bug, so put inside
8020 the #if 0 of that comment.
8021 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8022 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8023 Remove; unused.
19ed5445 8024
1f3561e4 8025 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8026 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8027 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8028
ded6f8f7
PE
8029 * search.c (simple_search): Remove unused var.
8030
dbd37a95
PE
8031 * dired.c (compile_pattern): Move decl from here ...
8032 * lisp.h: ... to here, so that it can be checked.
8033 (struct re_registers): New forward decl.
8034
7e47afad
PE
8035 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8036
85f24f61
PE
8037 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8038 All uses changed.
8039 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8040 Rename locals to avoid shadowing.
5671df8f 8041 (Fvertical_motion): Mark locals as initialized.
85f24f61 8042
181aa2be 8043 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8044 (casify_region): Mark local as initialized.
181aa2be 8045
930d429c
PE
8046 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8047
7082eac6
PE
8048 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8049 New macros, so that the caller can use some names other than
8050 gcpro1, gcpro2, etc.
8051 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8052 of the new macros.
8053 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8054 argument, for consistency with GCPRO2_VAR, etc: it is now the
8055 prefix of the variable, not the variable itself. All uses
8056 changed.
38b2c076
PE
8057 * dired.c (directory_files_internal, file_name_completion):
8058 Rename locals to avoid shadowing.
8059
15206ed9
PE
8060 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8061 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8062 dired.c's scmp function, had undefined behavior.
8063 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8064 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8065 * buffer.h: ... to here, because these macros use current_buffer,
8066 and the new implementation with inline functions needs to have
8067 current_buffer in scope now, rather than later when the macros
8068 are used.
8069 (downcase, upcase1): New static inline functions.
8070 (DOWNCASE, UPCASE1): Reimplement using these functions.
8071 This avoids undefined behavior in expressions like
8072 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8073 from race conditions in accessing the global variables
8074 case_temp1 and case_temp2.
8075 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8076 * lisp.h (case_temp1, case_temp2): Remove their decls.
8077 * character.h (ASCII_CHAR_P): Move from here ...
8078 * lisp.h: ... to here, so that the inline functions mentioned
8079 above can use them.
8080
4a6bea26
PE
8081 * dired.c (directory_files_internal_unwind): Now static.
8082
f14b7e14
PE
8083 * fileio.c (file_name_as_directory, directory_file_name):
8084 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8085 Now static.
2893f146
PE
8086 (file_name_as_directory): Use const pointers when appropriate.
8087 (Fexpand_file_name): Likewise. In particular, newdir might
8088 point at constant storage, so make it a const pointer.
fd4ead52 8089 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8090 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8091 signedness issues.
f839df0c
PE
8092 (Fset_file_times, Finsert_file_contents, auto_save_error):
8093 Rename locals to avoid shadowing.
f14b7e14 8094
5716756e 8095 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8096 (Ftry_completion, Fall_completions): Rename or remove locals
8097 to avoid shadowing.
5716756e 8098
b4c3046a
PE
8099 * marker.c (bytepos_to_charpos): Remove; unused.
8100
b45db522
PE
8101 * lisp.h (verify_bytepos, count_markers): New decls,
8102 so that gcc does not warn that these functions aren't declared.
8103
85876d07
PE
8104 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8105 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8106 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8107 (copy_text): Remove unused local var.
85876d07 8108
03d78a21 8109 * filelock.c (within_one_second): Now static.
b3dd38ab 8110 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8111
5df8f01b
PE
8112 * buffer.c (fix_overlays_before): Mark locals as initialized.
8113 (fix_start_end_in_overlays): Likewise. This function should be
8114 simplified by using pointers-to-pointers, but that's a different
8115 matter.
b1d876f1 8116 (switch_to_buffer_1): Now static.
8f54f30a
PE
8117 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8118 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8119
a70072c9 8120 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8121 Fix pointer signedness issue.
edced198
PE
8122 (sys_subshell): Mark local as volatile if checking for lint,
8123 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8124 (MAXPATHLEN): Define only if needed.
a70072c9 8125
a0977c44
PE
8126 * process.c (serial_open, serial_configure): Move decls from here ...
8127 * systty.h: ... to here, so that they can be checked.
8128
a884fdcc
PE
8129 * fns.c (get_random, seed_random): Move extern decls from here ...
8130 * lisp.h: ... to here, so that they can be checked.
8131
604efe86 8132 * sysdep.c (reset_io): Now static.
b8950c94 8133 (wait_for_termination_signal): Remove; unused.
604efe86 8134
38fc62d9
PE
8135 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8136 (copy_keymap_item, append_key, push_text_char_description):
8137 Now static.
1004a21a 8138 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8139 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8140 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8141 (describe_map_tree):
8142 Rename locals to avoid shadowing.
38fc62d9 8143
2f2650da
PE
8144 * keyboard.c: Declare functions static if they are not used elsewhere.
8145 (echo_char, echo_dash, cmd_error, top_level_2):
8146 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8147 (read_char, kbd_buffer_get_event, make_lispy_position):
8148 (make_lispy_event, make_lispy_movement, apply_modifiers):
8149 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8150 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8151 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8152 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8153 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8154
a053e86c 8155 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8156 (mark_kboards): Move decl here ...
8157 * alloc.c (mark_kboards): ... from here.
a053e86c 8158
4752793e
PE
8159 * lisp.h (force_auto_save_soon): New decl.
8160
74f10ca7 8161 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8162 (DEFINE_DUMMY_FUNCTION): New macro.
8163 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8164 Use it.
c03cd23f
PE
8165 (main): Add casts to avoid warnings
8166 if GCC considers string literals to be constants.
74f10ca7 8167
022e70d4
PE
8168 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8169
59d6fe83
PE
8170 * dbusbind.c: Pointer signedness fixes.
8171 (xd_signature, xd_append_arg, xd_initialize):
8172 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8173 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8174 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8175 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8176
78320123
PE
8177 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8178 if GCC considers string literals to be constants.
49cebcca 8179 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8180
35ac2a97
SM
81812011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8182
fb103ca9
SM
8183 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8184 (print_preprocess, print_object): New macro to fix last change.
8185
35ac2a97
SM
8186 * print.c (print_preprocess): Don't forget font objects.
8187
62973b41
JB
81882011-03-16 Juanma Barranquero <lekktu@gmail.com>
8189
8190 * emacs.c (USAGE3): Doc fixes.
8191
0e48bb22
AS
81922011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8193
8194 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8195 structure.
8196
7684e57b
JB
81972011-03-14 Juanma Barranquero <lekktu@gmail.com>
8198
8199 * lisp.h (VWindow_system, Qfile_name_history):
8200 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8201 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8202 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8203
8204 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8205 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8206
8207 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8208 * w32console.c (detect_input_pending, read_input_pending)
8209 (encode_terminal_code):
8210 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8211 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8212 (w32_system_caret_y, Qfile_name_history):
8213 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8214 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8215 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8216 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8217 * w32proc.c (Qlocal, report_file_error):
8218 * w32term.c (Vwindow_system, updating_frame):
8219 * w32uniscribe.c (initialized, uniscribe_font_driver):
8220 Remove unneeded extern declarations.
8221
2aa46d6c
CY
82222011-03-14 Chong Yidong <cyd@stupidchicken.com>
8223
c96bbc66 8224 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8225
cffc6f3b
CY
82262011-03-13 Chong Yidong <cyd@stupidchicken.com>
8227
8228 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8229 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8230 These macros can no longer be used for assignment.
8231
44f230aa
SM
8232 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8233 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8234 (record_buffer_markers, fetch_buffer_markers): New functions for
8235 recording and fetching special buffer markers.
8236 (set_buffer_internal_1, set_buffer_temp): Use them.
8237
8238 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8239
8240 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8241
8242 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8243 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8244
8245 * xdisp.c (hscroll_window_tree):
8246 (reconsider_clip_changes): Use PT instead of BUF_PT.
8247
d251f04b
EZ
82482011-03-13 Eli Zaretskii <eliz@gnu.org>
8249
8250 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8251 $(EMACS_ROOT)/lib/intprops.h.
8252
f0c77cd1
PE
82532011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8254
3eca4629
PE
8255 Fix more problems found by GCC 4.5.2's static checks.
8256
7c86ee98
PE
8257 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8258 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8259 (xg_free_frame_widgets): Make it clear that a local variable is
8260 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8261 (gdk_window_get_screen): Make it clear that this macro is needed
8262 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8263 (int_gtk_range_get_value): New function, which avoids a diagnostic
8264 from gcc -Wbad-function-cast.
8265 (xg_set_toolkit_scroll_bar_thumb): Use it.
8266 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8267 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8268 (get_utf8_string, xg_get_file_with_chooser):
8269 Rename locals to avoid shadowing.
8270 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8271
41729b81
PE
8272 * xgselect.c (xg_select): Remove unused var.
8273
f0c77cd1
PE
8274 * image.c (four_corners_best): Mark locals as initialized.
8275 (gif_load): Initialize transparent_p to zero (Bug#8238).
8276 Mark another local as initialized.
ec6cf4c6 8277 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8278
ce0ad53d 8279 * image.c (clear_image_cache): Now static.
d5d5a617 8280 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8281 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8282 (x_edge_detection): Remove unnecessary cast that
8283 gcc -Wbad-function-cast diagnoses.
2037898d 8284 (gif_load): Fix pointer signedness.
6ae141d6
PE
8285 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8286 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8287
33383987 82882011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8289
d32df629
PE
8290 Improve quality of tests for time stamp overflow.
8291 For example, without this patch (encode-time 0 0 0 1 1
8292 1152921504606846976) returns the obviously-bogus value (-948597
8293 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8294 reports time overflow. See
8295 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8296 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8297 * editfns.c: Include limits.h and intprops.h.
8298 (TIME_T_MIN, TIME_T_MAX): New macros.
8299 (time_overflow): Move earlier, to before first use.
8300 (hi_time, lo_time): New functions, for an accurate test for
8301 out-of-range times.
8302 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8303 (Fget_internal_run_time): Don't assume time_t fits in int.
8304 (make_time): Use list2 instead of Fcons twice.
8305 (Fdecode_time): More accurate test for out-of-range times.
8306 (check_tm_member): New function.
8307 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8308 (lisp_time_argument): Don't rely on undefined left-shift and
8309 right-shift behavior when checking for time stamp overflow.
8be6f318 8310
fe31d94c
PE
8311 * editfns.c (time_overflow): New function, refactoring common code.
8312 (Fformat_time_string, Fdecode_time, Fencode_time):
8313 (Fcurrent_time_string): Use it.
8314
8be6f318
PE
8315 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8316 * dired.c (make_time): Move to ...
8317 * editfns.c (make_time): ... here.
8318 * systime.h: Note the move.
8319
09d9db2c 83202011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8321
126bc0dc
YM
8322 * fringe.c (update_window_fringes): Remove unused variables.
8323
c47cbdfd
YM
8324 * unexmacosx.c (copy_data_segment): Also copy __got section.
8325 (Bug#8223)
8326
7ac80be9
EZ
83272011-03-12 Eli Zaretskii <eliz@gnu.org>
8328
c96bbc66 8329 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8330 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8331 Constify `char *' arguments and their references according to
8332 prototypes in tparam.h.
8333
ecb0f94d 8334 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8335
7ac80be9
EZ
8336 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8337 Adapt all references accordingly.
8338
8339 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8340
ef1fd07e
TT
83412011-03-11 Tom Tromey <tromey@redhat.com>
8342
8343 * buffer.c (syms_of_buffer): Remove obsolete comment.
8344
7ef4b50c
EZ
83452011-03-11 Eli Zaretskii <eliz@gnu.org>
8346
8347 * termhooks.h (encode_terminal_code): Declare prototype.
8348
8349 * msdos.c (encode_terminal_code): Don't declare prototype.
8350
8351 * term.c (encode_terminal_code): Now external again, used by
8352 w32console.c and msdos.c.
8353
44f230aa
SM
8354 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8355 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8356
4b1ec863 83572011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8358
1714f52b 8359 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8360
4b1ec863
PE
8361 * fringe.c (update_window_fringes): Mark locals as initialized
8362 (Bug#8227).
8363 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8364
524c7aa6
PE
8365 * alloc.c (mark_fringe_data): Move decl from here ...
8366 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8367 to check its interface.
8368 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8369
a5c0af81 8370 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8371 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8372 (fontset_font): Mark local as initialized.
a9a06e0b 8373 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8374
b4716021
PE
8375 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8376
811e9bac 8377 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8378 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8379 (x_own_selection, Fx_disown_selection_internal): Rename locals
8380 to avoid shadowing.
8381 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8382
7e3ab302
PE
8383 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8384 so that the caller can use some name other than gcpro1.
8385 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8386 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8387 (Fx_backspace_delete_keys_p):
8388 Use them to avoid shadowing, and rename vars to avoid shadowing.
8389 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8390 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8391 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8392 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8393 Remove unused locals.
7e3ab302
PE
8394 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8395 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8396 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8397 macros.
f78faa98 8398
e2b13473
PE
8399 * xterm.h (x_mouse_leave): New decl.
8400
77f23912
PE
8401 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8402 Remove unused functions.
cdf4ba58
PE
8403 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8404 (x_calc_absolute_position): Now static.
7411c686 8405 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8406 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8407 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8408 unless they are used.
38d0b34a
PE
8409 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8410 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8411 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8412 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8413 (x_error_catcher, x_connection_closed, x_error_handler):
8414 (x_error_quitter, xembed_send_message, x_iconify_frame):
8415 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8416 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8417 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8418
44f230aa
SM
8419 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8420 Rename or move locals to avoid shadowing.
6b463e58 8421 (tty_defined_color, merge_face_heights): Now static.
5967d051 8422 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8423 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8424 does not deduce is never used uninitialized.
73719eba
PE
8425 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8426 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8427
426994c3 8428 * terminal.c (store_terminal_param): Now static.
5489860b 8429
032f1620 8430 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8431 (set_frame_menubar): Remove unused local.
d4323972 8432 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8433 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8434 since they might point to immutable storage.
281585b0
PE
8435 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8436 since it's unused otherwise.
032f1620 8437
367c19e5 8438 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8439 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8440 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8441 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8442 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8443 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8444 does not deduce are never used uninitialized.
70739cbe 8445
07b48fa9
PE
8446 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8447
8868a238 8448 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8449 * window.c (window_loop, size_window):
8450 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8451
7e5cf297 8452 * window.c (display_buffer): Now static.
d6550a9f
PE
8453 (size_window): Mark variables that gcc -Wuninitialized
8454 does not deduce are never used uninitialized.
a586633d
PE
8455 * window.h (check_all_windows): New decl, to forestall
8456 gcc -Wmissing-prototypes diagnostic.
5b555da1 8457 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8458
f6095868
PE
8459 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8460 shadowing.
8461 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8462 Include <limits.h>.
8463 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8464 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8465 (load_charset_map): Mark variables that gcc -Wuninitialized
8466 does not deduce are never used uninitialized.
53df7c11 8467 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8468
f38b440c
PE
8469 * coding.c (coding_set_source, coding_set_destination):
8470 Use "else { /* comment */ }" rather than "else /* comment */;"
8471 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8472 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8473 a block, when the outer 'i' will do.
8474 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8475 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8476 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8477 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8478 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8479 Rename locals to avoid shadowing.
8480 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8481 * coding.c (emacs_mule_char, encode_invocation_designation):
8482 Now static, since they're not used elsewhere.
413bb2db 8483 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8484 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8485 (decode_coding_emacs_mule): Mark variables that gcc
8486 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8487 (detect_coding_iso_2022): Initialize a local variable that might
8488 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8489 this initialization is needed. (Bug#8211)
5f58e762
PE
8490 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8491 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8492 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8493 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8494 Remove unused macros.
f38b440c 8495
232b38b9 8496 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8497 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8498 * character.c (string_count_byte8): Likewise.
232b38b9 8499
fb90da1b
PE
8500 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8501 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8502
fb93dbc2
PE
8503 * chartab.c (copy_sub_char_table): Now static, since it's not used
8504 elsewhere.
5c156ace
PE
8505 (sub_char_table_ref_and_range, char_table_ref_and_range):
8506 Rename locals to avoid shadowing.
bbcd0949 8507 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8508
7d3b3862 8509 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8510 (BIDI_BOB): Remove unused macro.
7d3b3862 8511
6be7d3da
PE
8512 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8513 deduce are never used uninitialized.
c2ed9c8b 8514 * term.c (encode_terminal_code): Likewise.
6be7d3da 8515
75f8807f 8516 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8517
50938595
PE
8518 * tparam.h: New file.
8519 * term.c, tparam.h: Include it.
8520 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8521 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8522 Move these decls to tparam.h, and make them agree with what
8523 is actually in tparam.c. The previous trick of using incompatible
8524 decls in different modules does not conform to the C standard.
8525 All callers of tparam changed to use tparam's actual API.
8526 * tparam.c (tparam1, tparam, tgoto):
8527 Use const pointers where appropriate.
8528
fbceeba2
PE
8529 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8530 * cm.h (struct cm): Likewise.
8531 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8532 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8533 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8534 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8535 (turn_on_face, init_tty): Likewise.
8536 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8537
7f3f1250
PE
8538 * term.c (term_mouse_position): Rename local to avoid shadowing.
8539
e6ca6543
PE
8540 * alloc.c (mark_ttys): Move decl from here ...
8541 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8542
c40f8d15
AS
85432011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8544
8545 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8546
cfe0661d
JB
85472011-03-09 Juanma Barranquero <lekktu@gmail.com>
8548
8549 * search.c (compile_pattern_1): Remove argument regp, unused since
8550 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8551 (compile_pattern): Don't pass it.
8552
0afb4571
J
85532011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8554
8555 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8556 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8557 for ! HAVE_GTK3.
8558 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8559
8560 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8561
8562 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8563 gdk_window_get_screen, gdk_window_get_geometry,
8564 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8565 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8566 (xg_get_pixbuf_from_pixmap): New function.
8567 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8568 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8569 Call xg_get_pixbuf_from_pixmap instead of
8570 gdk_pixbuf_get_from_drawable.
8571 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8572 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8573 (xg_check_special_colors): Use GtkStyleContext and its functions
8574 for HAVE_GTK3.
8575 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8576 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8577 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8578 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8579 Call gtk_widget_get_preferred_size.
0afb4571
J
8580 (xg_frame_resized): gdk_window_get_geometry only takes 5
8581 parameters.
44f230aa
SM
8582 (xg_win_to_widget, xg_event_is_for_menubar):
8583 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8584 (xg_set_widget_bg): New function.
8585 (delete_cb): New function.
895009e1 8586 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8587 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8588 (xg_set_background_color): Call xg_set_widget_bg.
8589 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8590 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8591 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8592 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8593 if ! HAVE_GTK3.
8594 (update_frame_tool_bar): Call gtk_widget_hide.
8595 (xg_initialize): Use GDK_KEY_g.
8596
8597 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8598 if ! HAVE_GTK3
8599 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8600
8601 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8602 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8603 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8604
1c2cc4ef
JB
86052011-03-08 Juanma Barranquero <lekktu@gmail.com>
8606
8607 * w32xfns.c (select_palette): Check success of RealizePalette against
8608 GDI_ERROR, not zero.
8609
33383987 8610See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8611
8612;; Local Variables:
8613;; coding: utf-8
aac0c6e3
MR
8614;; End:
8615
33383987 8616 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8617
8618 This file is part of GNU Emacs.
8619
8620 GNU Emacs is free software: you can redistribute it and/or modify
8621 it under the terms of the GNU General Public License as published by
8622 the Free Software Foundation, either version 3 of the License, or
8623 (at your option) any later version.
8624
8625 GNU Emacs is distributed in the hope that it will be useful,
8626 but WITHOUT ANY WARRANTY; without even the implied warranty of
8627 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8628 GNU General Public License for more details.
8629
8630 You should have received a copy of the GNU General Public License
8631 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.