* lisp/files.el (find-file): Always use selected-window.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
be7f5545
MR
12011-11-07 Martin Rudalics <rudalics@gmx.at>
2
3 * window.h: Declare delete_all_child_windows instead of
4 delete_all_subwindows.
5 * window.c (Fwindow_nest, Fset_window_nest)
6 (Fset_window_new_total, Fset_window_new_normal)
7 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
8 (delete_all_subwindows): Rename to delete_all_child_windows.
9 (Fdelete_other_windows_internal, Fset_window_configuration):
10 Call delete_all_child_windows instead of delete_all_subwindows.
11 * frame.c (delete_frame): Call delete_all_child_windows instead
12 of delete_all_subwindows.
13
ca78dc43
PE
142011-11-07 Paul Eggert <eggert@cs.ucla.edu>
15
16 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
17 This is also needed for porting to any host where GC_MARK_STACK is
18 not GC_MAKE_GCPROS_NOOPS.
19 (which_symbols): Use it.
20
a0241d01
KH
212011-11-07 Kenichi Handa <handa@m17n.org>
22
23 * coding.c (coding_set_destination): Check coding->src_pos only
24 when coding->src_object is a buffer (bug#9910).
25
26 * process.c (send_process): Set the member src_multibyte of coding
27 to 0 (bug#9911) when sending a unibyte text.
28
29 * callproc.c (Fcall_process): Set the member src_multibyte of
30 process_coding to 0 (bug#9912).
31
a64bfdfa 322011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
33
34 * xmenu.c (cleanup_widget_value_tree): New function.
35 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
36 calling free_menubar_widget_value_tree directly (Bug#9830).
37
cb41b32a
PE
382011-11-06 Paul Eggert <eggert@cs.ucla.edu>
39
40 Fix some portability problems with 'inline'.
41 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
42 (window_box_width, window_box_left, window_box_left_offset)
43 (window_box_right, window_box_right_offset): Declare extern.
44 Otherwise, these inline functions do not conform to C99 and
45 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
46 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
47 * intervals.c (adjust_intervals_for_insertion)
48 (adjust_intervals_for_deletion): Now extern, because otherwise the
49 extern inline functions 'offset_intervals' couldn't refer to it.
50 (static_offset_intervals): Remove.
51 (offset_intervals): Rewrite using the old contents of
52 static_offset_intervals. The old version didn't conform to C99
53 because an extern inline function contained a reference to an
54 identifier with static linkage.
55
b7041366
AS
562011-11-06 Andreas Schwab <schwab@linux-m68k.org>
57
58 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
59 GC.
60
88a37c4d
EZ
612011-11-06 Eli Zaretskii <eliz@gnu.org>
62
63 * xdisp.c (init_iterator, reseat_to_string): Don't set the
64 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
65 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
66 return Qleft_to_right.
67
49745b39
CY
682011-11-06 Chong Yidong <cyd@gnu.org>
69
70 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
71 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
72 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
73 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
74 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
75 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
76 (Fwindow_vscroll): Doc fix.
77 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
78 argument, since it makes no sense to pass a live window and for
79 consistency with window-child.
80
1f05cd82
CS
812011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
82
83 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
84 support MSVC.
85
22610910
JR
862011-11-05 Jason Rumney <jasonr@gnu.org>
87
88 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
89 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
90 fonts (Bug#6029).
91 (add_font_entity_to_list): Fix logic errors in mixed boolean and
92 bitwise arithmetic preventing use of unicode-sip and non-truetype
93 opentype fonts.
94
a06776b2
EZ
952011-11-05 Eli Zaretskii <eliz@gnu.org>
96
3ad924ba
EZ
97 * s/ms-w32.h (fstat, stat, utime): Move redirections to
98 "emacs"-only part.
99
a06776b2
EZ
100 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
101 initialization code to keep similarity to xfns.c after changes
102 from 2011-11-05.
103
c9e7db78
JD
1042011-11-05 Jan Djärv <jan.h.d@swipnet.se>
105
a97f8f3f
JD
106 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
107 (unwind_create_frame): New function (Bug#9943).
108 (Fx_create_frame): Restructure code to be more similar to the one in
109 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
110 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
111 Move terminal->reference_count++ just before making the frame official
112 (Bug#9943).
113
114 * nsterm.m (x_free_frame_resources): New function.
115 (x_destroy_window): Move code to x_free_frame_resources.
116
c9e7db78
JD
117 * xfns.c (unwind_create_frame): Fix comment.
118 (Fx_create_frame, x_create_tip_frame): Move
119 terminal->reference_count++ just before making the frame
120 official. Move initialization of image_cache_refcount and
121 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
122
a6fc3b5c
EZ
1232011-11-05 Eli Zaretskii <eliz@gnu.org>
124
125 Support MSVC build with newer versions of Visual Studio.
126 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
127 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
128 nt/gmake.defs.
129
130 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
131 which are not supported by MSVC.
132 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
133 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
134 bitfields.
135 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
136 types in bitfields.
137 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
138
139 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
140
1412011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
142
143 Support MSVC build with newer versions of Visual Studio.
144 * w32.c: Don't include w32api.h for MSVC.
145 (init_environment) [_MSC_VER]: Call sys_access, not _access.
146
147 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
148 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
149 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
150 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
151 e_* cousins.
152 (alloca) [_MSC_VER]: Define to _alloca.
153
154 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
155
156 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
157
a58c13ed
EZ
1582011-11-04 Eli Zaretskii <eliz@gnu.org>
159
160 * xdisp.c (note_mouse_highlight): If either of
161 previous/next-single-property-change returns nil, treat that as
162 the beginning or the end of the buffer. (Bug#9955)
163
fe0b6370
JD
1642011-11-04 Jan Djärv <jan.h.d@swipnet.se>
165
a58c13ed 166 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
167 label is not null (Bug#9951).
168 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
169 may be NULL.
170
89bd5ee1
EZ
1712011-11-04 Eli Zaretskii <eliz@gnu.org>
172
173 * window.c (Fwindow_body_size): Mention in the doc string that the
174 return value is in frame's canonical units. (Bug#9949)
175
84c3edb9
EZ
1762011-11-03 Eli Zaretskii <eliz@gnu.org>
177
4e2fb5c7
EZ
178 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
179
84c3edb9 180 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 181 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 182 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 183
bc17a887
EZ
1842011-11-01 Eli Zaretskii <eliz@gnu.org>
185
186 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
187 Don't stop backward scan on the continuation glyph, even though
188 its CHARPOS is positive.
26b46e51
EZ
189 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
190 cover_string to disp_string.
bc17a887 191
4ee88440
MR
1922011-11-01 Martin Rudalics <rudalics@gmx.at>
193
194 * window.c (temp_output_buffer_show): Don't use
195 Vtemp_buffer_show_specifiers.
196 (Vtemp_buffer_show_specifiers): Remove unused variable.
197
c2ff3c02
EZ
1982011-10-30 Eli Zaretskii <eliz@gnu.org>
199
200 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
201 past the beginning of the current glyph matrix.
202
6e56383b
JD
2032011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
204
205 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
206 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
207 HAVE_GTK3 (Bug#9869).
b77a6a7f 208
3b574623
JD
209 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
210 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
211
b77a6a7f
JD
212 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
213
214 * xterm.c: Declare x_handle_net_wm_state to return int.
215 (handle_one_xevent): Check if we are iconified but don't have
216 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
217 (get_current_wm_state): Return non-zero if not hidden,
218 check for _NET_WM_STATE_HIDDEN (Bug#9893).
219 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
220 (x_handle_net_wm_state): Return what get_current_wm_state returns.
221 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
222
196e41e4
PE
2232011-10-29 Paul Eggert <eggert@cs.ucla.edu>
224
225 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
226 so that this new function doesn't get optimized away by a
227 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
228
021f2e1a
AS
2292011-10-29 Andreas Schwab <schwab@linux-m68k.org>
230
231 * frame.h (MOUSE_HL_INFO): Remove excess parens.
232
8b058d44
EZ
2332011-10-29 Eli Zaretskii <eliz@gnu.org>
234
235 Fix the `xbytecode' command.
236 * .gdbinit (xprintbytestr): New command.
237 (xwhichsymbols): Renamed from `which'; all callers changed.
238 (xbytecode): Print the byte-code string as well.
239
4452fb80
EZ
2402011-10-29 Kim Storm <storm@cua.dk>
241
8b058d44
EZ
242 * alloc.c (which_symbols): New function.
243
21b72067
AS
2442011-10-29 Andreas Schwab <schwab@linux-m68k.org>
245
246 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
247 line. (Bug#9903)
248
83ed7b5c
GM
2492011-10-29 Glenn Morris <rgm@gnu.org>
250
251 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
252 Not clear what it was for, and it causes various bugs. (Bug#9839)
253
5a7a728b
EZ
2542011-10-28 Eli Zaretskii <eliz@gnu.org>
255
256 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
257 possible random value that matches one of those tested as
258 condition to clear the mouse face.
259
d3d0842f
CY
2602011-10-28 Chong Yidong <cyd@gnu.org>
261
262 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
263
31b39d13
DN
2642011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
265
266 * window.c (make_window): Initialize phys_cursor_on_p.
267
9aba6043
SM
2682011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
269
270 * lisp.h (struct Lisp_Symbol): Update comments.
271
c20992f4
JB
2722011-10-28 Juanma Barranquero <lekktu@gmail.com>
273
274 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
275
db4f02f2
EZ
2762011-10-28 Eli Zaretskii <eliz@gnu.org>
277
278 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
279 <oslsachem@gmail.com> for helping to debug this.
280
281 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
282 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
283 (g_b_init_get_glyph_outline_w): New static variables.
284 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
285 (GetGlyphOutlineW_Proc): New typedefs.
286 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
287 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
288 New functions.
289 (w32font_open_internal, compute_metrics):
290 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
291 instead of calling the "wide" APIs directly.
292
293 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
294
295 * w32.h (syms_of_w32font): Add prototype.
296
87e68db4
JB
2972011-10-27 Juanma Barranquero <lekktu@gmail.com>
298
299 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
300 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
301 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
302 (Fmove_to_window_line): Doc fix.
303
435c1d67
CY
3042011-10-27 Chong Yidong <cyd@gnu.org>
305
306 * process.c (make_process): Set gnutls_state to NULL.
307
308 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
309 non-NULL, regardless of GNUTLS_INITSTAGE.
310 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
311 an error. Set process slots as soon as we allocate them.
312
313 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
314
9c6c6f49
CY
3152011-10-27 Chong Yidong <cyd@gnu.org>
316
9aba6043
SM
317 * gnutls.c (emacs_gnutls_deinit): New function.
318 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
319 (Fgnutls_deinit, Fgnutls_boot): Use it.
320
321 * process.c (make_process): Initialize GnuTLS credentials to NULL.
322 (deactivate_process): Call emacs_gnutls_deinit.
323
657d08d3
JB
3242011-10-27 Juanma Barranquero <lekktu@gmail.com>
325
326 * image.c (x_create_x_image_and_pixmap):
327 * w32.c (sys_rename, w32_delayed_load):
328 * w32font.c (fill_in_logfont):
329 * w32reg.c (x_get_string_resource): Silence compiler warnings.
330
5430d399
JB
3312011-10-26 Juanma Barranquero <lekktu@gmail.com>
332
333 * w32fns.c (w32_default_color_map): New function,
334 extracted from Fw32_default_color_map.
a7ef684b 335 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 336
fe0055fa
PE
3372011-10-25 Paul Eggert <eggert@cs.ucla.edu>
338
339 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
340
e6346438
SM
3412011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
342
343 * keyboard.c (test_undefined): New function (bug#9751).
344 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
345
e112cc37
ET
3462011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
347
348 * sysdep.c (init_sys_modes): Fix the check for the controlling
349 terminal (Bug#6649).
350
7b5d6677
EZ
3512011-10-20 Eli Zaretskii <eliz@gnu.org>
352
353 * dispextern.h (struct bidi_it): New member next_en_type.
354
355 * bidi.c (bidi_line_init): Initialize the next_en_type member.
356 (bidi_resolve_explicit_1): When next_en_pos is valid for the
357 current character, check also for next_en_type being WEAK_EN.
358 (bidi_resolve_weak): Don't enter the expensive loop if the current
359 position is before next_en_pos. Record the bidi type of the first
360 non-ET, non-BN character we find, in addition to its position.
361 (bidi_level_of_next_char): Invalidate next_en_type when
362 next_en_pos is over-stepped.
363
7da0b018
PE
3642011-10-20 Paul Eggert <eggert@cs.ucla.edu>
365
366 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
367 * editfns.c: Rewrite current-time-zone so that it invokes
368 the equivalent of (format-time-string "%Z") to get the time zone name.
369 This fixes a bug when the time zone name contains characters that
370 need converting from the system time locale to Emacs internal format.
371 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
372 that patch fixed format-time-string to do the conversion, but
373 I forgot to fix current-time-zone.
374 (format_time_string): New function, containing most of
375 what Fformat_time_string used to contain.
376 (Fformat_time_string): Rewrite in terms of format_time_string.
377 This doesn't change this function's behavior.
378 (current-time-zone): Rewrite to use format_time_string.
379 This fixes the bug reported by Michael Schierl in
380 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
381 Jason Rumney's 2007-06-07 change worked around this bug, but
382 didn't fix it.
383 * systime.h (tzname, timezone): Remove no-longer-used declarations.
384
8547b010
EZ
3852011-10-19 Eli Zaretskii <eliz@gnu.org>
386
387 * xdisp.c (start_display): If the character at POS is displayed
388 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
389 (try_window_reusing_current_matrix): If a line ends in a display
390 vector or the next line starts in a display vector, continue
391 redrawing the window even though the character position of
392 start_row was reached.
8547b010
EZ
393 (Bug#9771, part 2)
394
4e948d15
CY
3952011-10-18 Chong Yidong <cyd@gnu.org>
396
397 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
398 with nobreak-char-display too.
399
4787455f
EZ
4002011-10-18 Eli Zaretskii <eliz@gnu.org>
401
402 Fix part 3 of bug#9771.
403 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
404 (bidi_resolve_neutral): Don't enter the expensive loop looking for
405 non-neutral characters if the current character is a paragraph
406 separator (a.k.a. Newline). This avoids running the same
407 expensive loop twice, once when we consume the preceding newline
408 and the other time when the line actually needs to be displayed.
409 Avoid the loop when we see neutrals on the base embedding level
410 following a character whose directionality is the same as the
411 paragraph's. This avoids running the expensive loop when a line
412 ends in a long sequence of neutrals, like control characters.
413 Add assertion against STRONG_AL type. Slightly rearrange code
414 that determines the type of a neutral given the first non-neutral
415 that follows it.
416 (bidi_level_of_next_char): Set next_en_pos to zero when
417 invalidating its info.
418
2c91f553
EZ
4192011-10-17 Eli Zaretskii <eliz@gnu.org>
420
421 * xdisp.c (push_display_prop): Determine whether to record string
422 or buffer position by IT->string, not by IT->method. Allow
423 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
424 (move_it_vertically_backward): Don't look for character position
425 immediately after the newline when in a continuation line.
426 (Bug#9771, part 1)
2c91f553 427
c7b08b0d
MR
4282011-10-15 Martin Rudalics <rudalics@gmx.at>
429
430 * window.c (coordinates_in_window): Rewrite and delabelize
431 vertical border check. (Bug#5357) (Bug#9618)
432
6b02f655
SM
4332011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
434
435 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
436 errors in XSetWindowBorder (bug#9310).
437
81d40c92
DA
4382011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
439
440 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
441 avoid crash when xmalloc overrun checking is enabled.
442
d4172c3b
EZ
4432011-10-13 Eli Zaretskii <eliz@gnu.org>
444
445 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
446 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
447 cursor motion with <left> and <right> arrow keys.
448
449 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
450 some callers set that themselves.
451
b00eea75
EZ
4522011-10-12 Eli Zaretskii <eliz@gnu.org>
453
454 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
455 display string and the previous row comes from the same string and
456 is empty. (Bug#9739) (Bug#9738)
457
8fe012c4
SM
4582011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
459
460 * doc.c (get_doc_string): Encode file name (bug#9735).
461
0074aef2
EZ
4622011-10-12 Eli Zaretskii <eliz@gnu.org>
463
79beb178
EZ
464 * bidi.c (bidi_level_of_next_char):
465 * xdisp.c (get_visually_first_element): Remove old incorrect
466 comments regarding the Unicode Line Separator character.
467
0074aef2
EZ
468 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
469
6e4b3fbe
DA
4702011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
471
472 * alloc.c (Fgc_status): Do not access beyond zombies array
473 boundary if nzombies > MAX_ZOMBIES.
474 * alloc.c (dump_zombies): Add missing format specifier.
475
0324f3af
PE
4762011-10-12 Paul Eggert <eggert@cs.ucla.edu>
477
b5525cac
PE
478 * xdisp.c (set_cursor_from_row): Simplify conditionals,
479 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
480
0324f3af
PE
481 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
482 Some packages use them to denote characters with modifiers.
483
e9b5f888
AS
4842011-10-11 Andreas Schwab <schwab@linux-m68k.org>
485
486 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
487 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
488 matching a pp-number. Rename parameter var to var1.
489
127827c0
SM
4902011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
491
492 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
493
c8fd3bd0
GM
4942011-10-08 Glenn Morris <rgm@gnu.org>
495
496 * callint.c (Fcall_interactively): Give a more explicit error for the
497 'c' case with a non-character input. (Bug#8479)
498
352ec8ff
EZ
4992011-10-08 Eli Zaretskii <eliz@gnu.org>
500
03669ccb
EZ
501 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
502 lines.
7061c986
EZ
503 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
504 lines that are hscrolled on the left.
03669ccb 505
352ec8ff
EZ
506 * dispnew.c (buffer_posn_from_coords): Account for a possible
507 presence of header-line. (Bug#4426)
508
a66cfb1c
SM
5092011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
510
6b02f655
SM
511 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
512 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 513
7c5ee88e
PE
5142011-10-07 Paul Eggert <eggert@cs.ucla.edu>
515
516 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
517 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
518 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
519 this makes Emacs dump core during garbage collection on rare
520 occasions. sizeof is obviously inferior to offsetof here, so
521 stick with offsetof.
522 (GC_POINTER_ALIGNMENT): New macro.
523 (mark_memory): Omit 3rd (offset) arg; caller changed.
524 Don't assume EMACS_INT alignment is the same as pointer alignment.
525
df1bbe5b
SM
5262011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
527
528 * keyboard.c (read_key_sequence_remapped): New var.
529 (read_key_sequence): Compute remapping in the right buffer.
530 (command_loop_1): Use read_key_sequence's remapping directly.
531
51553db6
SM
5322011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
533
32c1fffd
SM
534 * dired.c (file_name_completion): Don't expand file name.
535 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
536 before checking file name handler.
537
51553db6
SM
538 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
539 they've been requested explicitly (bug#9591).
540
b6bd1599 5412011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
542
543 * keymap.c (Fsingle_key_description): Use make_specified_string
544 instead of build_string to build string from push_key_description.
545 (Bug#5193)
546
f701dc2a
PE
5472011-09-30 Paul Eggert <eggert@cs.ucla.edu>
548
4222c55d
PE
549 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
550 This fixes a Y2038 bug on 64-bit hosts.
551 * buffer.c (reset_buffer):
552 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
553 (Fclear_buffer_auto_save_failure):
554 Use 0, not -1, to represent an unset failure time, since time_t
555 might not be signed.
556
f701dc2a
PE
557 Remove dependency on glibc malloc internals.
558 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
559 Move back here from lisp.h, but with their new implementations.
560 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
561 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
562 * charset.c (charset_table_init): New static var.
563 (syms_of_charset): Use it instead of xmalloc. This removes a
564 dependency on glibc malloc internals. See Eli Zaretskii's comment in
565 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
566 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
567 Move back to alloc.c.
568 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
569 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
570
9ceebf39
JD
5712011-09-30 Jan Djärv <jan.h.d@swipnet.se>
572
573 * nsterm.m (windowDidResize): Call x_set_window_size only when
574 ns_in_resize is true. Otherwise set pixelwidth/height and
575 call change_frame_size (Bug#9628).
576
cb993c58
PE
5772011-09-30 Paul Eggert <eggert@cs.ucla.edu>
578
3930c88b
PE
579 Port --enable-checking=all to Fedora 14 x86-64.
580 * charset.c (syms_of_charset): Also account for glibc malloc's
581 internal overhead when calculating the initial malloc maximum.
582
cb993c58
PE
583 Port --enable-checking=all to Fedora 14 x86.
584 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
585 Move to lisp.h.
586 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
587 (overrun_check_realloc, overrun_check_free):
588 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
589 That way, xmalloc returns a properly-aligned pointer even if
590 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
591 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
592 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
593 into account when calculating the initial malloc maximum.
594 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
595 Move here from alloc.c, so that charset.c can use it too.
596 Properly align; the old code wasn't right for common 32-bit hosts
597 when configured with --enable-checking=all.
598 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
599 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
600
31bed486
EZ
6012011-09-29 Eli Zaretskii <eliz@gnu.org>
602
04c70788 603 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
604 use EDOM.
605
fbcaa2f3
EZ
6062011-09-28 Eli Zaretskii <eliz@gnu.org>
607
608 * xdisp.c (compute_display_string_end): If there's no display
609 string at CHARPOS, return -1.
610
611 * bidi.c (bidi_fetch_char): When compute_display_string_end
612 returns a negative value, treat the character as a normal
613 character not covered by a display string. (Bug#9624)
614
a239d4e9
JB
6152011-09-28 Juanma Barranquero <lekktu@gmail.com>
616
617 * lread.c (Fread_from_string): Fix typo in docstring.
618
88652fd5
EZ
6192011-09-27 Eli Zaretskii <eliz@gnu.org>
620
621 * xdisp.c (handle_invisible_prop): If invisible text ends on a
622 newline, reseat the iterator instead of bidi-iterating there one
623 character at a time. (Bug#9610)
32c1fffd
SM
624 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
625 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 626
ed497dd4
AS
6272011-09-27 Andreas Schwab <schwab@linux-m68k.org>
628
629 * lread.c (readevalloop): Use correct code for NBSP.
630 (read1): Likewise. (Bug#9608)
631
b2bf61aa
MA
6322011-09-25 Michael Albinus <michael.albinus@gmx.de>
633
634 * dbusbind.c (Fdbus_register_signal): When service is not
635 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
636
32bbb17c
GM
6372011-09-25 Glenn Morris <rgm@gnu.org>
638
639 * buffer.c (truncate-lines): Doc fix.
640
94e0933e
CY
6412011-09-24 Chong Yidong <cyd@stupidchicken.com>
642
643 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
644 (Fset_window_next_buffers): Doc fix.
645
cddde921
GM
6462011-09-24 Glenn Morris <rgm@gnu.org>
647
648 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
649
1260aef1
PE
6502011-09-24 Paul Eggert <eggert@cs.ucla.edu>
651
25b4bfa0
PE
652 Fix minor problems found by static checking.
653 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
654 * indent.c (Fvertical_motion): Fix == vs = typo.
655
e3cbd34b
EZ
6562011-09-24 Eli Zaretskii <eliz@gnu.org>
657
a66cfb1c
SM
658 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
659 Default value is now t. Doc fix.
6bf7006f 660
e3cbd34b 661 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 662 logic when moving up, not only when moving down. Fix the
e3cbd34b 663 confusing name and values of the it_overshoot_expected variable;
32c1fffd 664 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
665
666 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
667 CHARPOS is covered by a display string which includes newlines.
668 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
669 is covered by a display string with embedded newlines.
670
a3de0cbd
MA
6712011-09-24 Michael Albinus <michael.albinus@gmx.de>
672
673 * dbusbind.c (Fdbus_register_signal): Add match rule to
674 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
675 (Fdbus_register_method, Vdbus_registered_objects_table):
676 Fix docstring.
a3de0cbd 677
b260039d
JM
6782011-09-24 Jim Meyering <meyering@redhat.com>
679
32c1fffd 680 do not ignore write error for any output size
b260039d
JM
681 The previous change was incomplete.
682 While it makes emacs --batch detect the vast majority of stdout
683 write failures, errors were still ignored whenever the output size is
684 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
685 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
686 && echo FAIL: ignored write error
687 FAIL: ignored write error
688 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
689 && echo FAIL: ignored write error
690 FAIL: ignored write error
691 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
692
8eca8a7c
AS
6932011-09-23 Andreas Schwab <schwab@linux-m68k.org>
694
695 * emacs.c (Fkill_emacs): In noninteractive mode exit
696 non-successfully if a write error occurred on stdout. (Bug#9574)
697
3341db62
EZ
6982011-09-21 Eli Zaretskii <eliz@gnu.org>
699
700 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
701 the xassert test.
702
703 * dispextern.h (struct it): Update the comment documenting what
704 can it->OBJECT be.
705
8c203dbf
EZ
7062011-09-20 Eli Zaretskii <eliz@gnu.org>
707
708 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
709 a display string, extend search for cursor position to end of row.
710 (find_row_edges): If the row ends in a newline from a display
711 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
712 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
713 (Fcurrent_bidi_paragraph_direction): Fix search for previous
714 non-empty line. Fixes confusing cursor motion with arrow keys at
715 the beginning of a line that starts with whitespace.
8c203dbf 716
a4824228
LMI
7172011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
718
719 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
720 (bug#9493).
721
33ed493b
CY
7222011-09-18 Chong Yidong <cyd@stupidchicken.com>
723
724 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
725 boolean (Bug#9154).
726
56cd55c8
EZ
7272011-09-18 Eli Zaretskii <eliz@gnu.org>
728
729 * xdisp.c (display_line): Record maximum and minimum buffer
730 positions even if no glyphs were produced (e.g., by a zero-width
731 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
732 buffer positions that will be removed from the glyph row because
733 they don't fit.
c02dcedf
EZ
734 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
735 column is beyond frame width: don't subtract 1 "pixel" when
736 computing width of the stretch.
3e62b7e0
EZ
737 (reseat_at_next_visible_line_start): Undo the change made on
738 2011-09-17 that saved paragraph information and restored it after
739 the call to `reseat'. (Bug#9545)
56cd55c8 740
5ed99d36 7412011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
742
743 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
744 and turn window cursor on if cleared (Bug#9415).
745
5ed99d36 7462011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
747
748 * search.c (boyer_moore): Take unibyte characters from pattern
749 literally. (Bug#9458)
750
9bade7b2
EZ
7512011-09-18 Eli Zaretskii <eliz@gnu.org>
752
753 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
754
e5e9d610
PE
7552011-09-18 Paul Eggert <eggert@cs.ucla.edu>
756
87e4427a
PE
757 Fix minor problem found by static checking.
758 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
759 initialized, to pacify gcc -Wuninitialized.
760
e5e9d610
PE
761 * fileio.c: Report proper errno when syscall falls.
762 (Finsert_file_contents): Save and restore errno,
763 so that report_file_error outputs the correct diagnostic.
764 (Fwrite_region) [CLASH_DETECTION]: Likewise.
765
a1674f0b
EZ
7662011-09-18 Eli Zaretskii <eliz@gnu.org>
767
768 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
769
fbfb6dd4
EZ
7702011-09-17 Eli Zaretskii <eliz@gnu.org>
771
772 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
773 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
774
bb187662
EZ
7752011-09-17 Eli Zaretskii <eliz@gnu.org>
776
1137e8b8 777 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 778 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
779
780 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
781 (bidi_find_paragraph_start): Search back for paragraph beginning
782 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
783 (bidi_move_to_visually_next): Only trigger paragraph-related
784 computations when the last character is a newline or at EOB, not
785 just any NEUTRAL_B. (Bug#9470)
786
bb187662
EZ
787 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
788 truncated lines if point is covered by a display string. (Bug#9524)
789
2e621251
PE
7902011-09-16 Paul Eggert <eggert@cs.ucla.edu>
791
792 * xselect.c: Relax test for outgoing X longs (Bug#9498).
793 (cons_to_x_long): New function.
794 (lisp_data_to_selection_data): Use it. Correct the test for
795 short-versus-long data; it was negated. Break out of vector
796 loop, for efficiency, when a long datum is discovered.
797
91a15bc6
SM
7982011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
799
800 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
801
b41c3a35
EZ
8022011-09-16 Eli Zaretskii <eliz@gnu.org>
803
804 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
805 GCC PR/17406) by declaring this function with external scope.
806
7812ba2d
PE
8072011-09-15 Paul Eggert <eggert@cs.ucla.edu>
808
809 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
810 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
811
cf7edc2a
AS
8122011-09-15 Andreas Schwab <schwab@linux-m68k.org>
813
814 * editfns.c (Fformat): Correctly handle text properties on "%%".
815
bd01620e
EZ
8162011-09-15 Eli Zaretskii <eliz@gnu.org>
817
818 * xterm.c (x_draw_composite_glyph_string_foreground):
819 * w32term.c (x_draw_composite_glyph_string_foreground):
820 * term.c (encode_terminal_code):
821 * composite.c (composition_update_it, get_composition_id):
822 * xdisp.c (get_next_display_element)
823 (fill_composite_glyph_string): Add comments about special meaning
824 of TAB characters in a composition.
825
a02719a3
PE
8262011-09-15 Paul Eggert <eggert@cs.ucla.edu>
827
828 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
829 This occurs when processing a multibyte format.
830 Problem reported by Wolfgang Jenker.
a02719a3 831
72589a3c
JB
8322011-09-15 Johan Bockgård <bojohan@gnu.org>
833
834 * xdisp.c (try_cursor_movement): Only check for exact match if
835 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
836
1c14176c
PE
8372011-09-14 Paul Eggert <eggert@cs.ucla.edu>
838
839 Remove unused external symbols.
840 * dispextern.h (calc_pixel_width_or_height): Remove decl.
841 * xdisp.c (calc_pixel_width_or_height): Now static.
842 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
843 * indent.c (check_display_width):
844 * w32term.c: Fix comment to match code.
845 * xterm.c, xterm.h (x_catching_errors): Remove.
846
d2eea5b5
PE
8472011-09-14 Paul Eggert <eggert@cs.ucla.edu>
848
849 * xselect.c: Use signed conversions more consistently (Bug#9498).
850 (selection_data_to_lisp_data): Assume incoming selection data are
851 signed integers, not unsigned. This is to be consistent with
852 outgoing selection data, which was modified to use signed integers
853 in as part of the fix to Bug#9196 in response to Jan D.'s comment
854 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
855 expects long, not unsigned long.
856
46888499
EZ
8572011-09-14 Eli Zaretskii <eliz@gnu.org>
858
859 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
860 computation of loop end. Reported by Johan Bockgård
861 <bojohan@gnu.org>.
862
ef8ef9fb
CY
8632011-09-13 Chong Yidong <cyd@stupidchicken.com>
864
865 * frame.c (Fother_visible_frames_p): Function deleted.
866
fa819fed
EZ
8672011-09-12 Eli Zaretskii <eliz@gnu.org>
868
869 * indent.c (compute_motion): Process display vector front to back
870 rather than the other way around. (Bug#2496)
871
2ba8e008
SM
8722011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
873
874 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
875
20f53c69
CY
8762011-09-11 Chong Yidong <cyd@stupidchicken.com>
877
878 * minibuf.c (Fread_from_minibuffer): Doc fix.
879
d562d7a4
EZ
8802011-09-11 Eli Zaretskii <eliz@gnu.org>
881
882 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
883 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
884
1c4d7f3d
LMI
8852011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
886
887 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
888 value for non-existent files.
889
b885bf36
EZ
8902011-09-11 Eli Zaretskii <eliz@gnu.org>
891
892 * fileio.c (Finsert_file_contents): If the file cannot be opened,
893 set its "size" to -1. This will set the modtime_size field of
894 the corresponding buffer to -1, which is what
895 verify-visited-file-modtime expects for files that do not exist.
896 (Bug#9139)
897
6612f0bf
PE
8982011-09-11 Paul Eggert <eggert@cs.ucla.edu>
899
900 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
901 here ...
902 * lisp.h: ... from here. push_key_description is no longer
903 defined in keyboard.c, so its declaration should not be in
904 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
905 logically belongs with push_key_description.
906
dfb3f755
PE
9072011-09-10 Paul Eggert <eggert@cs.ucla.edu>
908
909 * buffer.h: Include <sys/types.h> instead of <time.h>.
910 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
911 Problem reported by Herbert J. Skuhra.
912
3134906c
LMI
9132011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
914
915 * xml.c (parse_region): Make the parsing work for
916 non-comment-starting XML files again (bug#9144).
917
8d903f4e
AS
9182011-09-10 Andreas Schwab <schwab@linux-m68k.org>
919
920 * image.c (gif_load): Fix calculation of bottom and right corner.
921 (Bug#9468)
922
80ad64f4
EZ
9232011-09-10 Eli Zaretskii <eliz@gnu.org>
924
925 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
926 redisplay in small windows.
927
208a048d
EZ
9282011-09-09 Eli Zaretskii <eliz@gnu.org>
929
930 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
931
9b1c252e
MR
9322011-09-08 Martin Rudalics <rudalics@gmx.at>
933
934 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
935 Operate on live windows only.
936
2949f33b
JB
9372011-09-08 Juanma Barranquero <lekktu@gmail.com>
938
939 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
940
e08dcafd
EZ
9412011-09-07 Eli Zaretskii <eliz@gnu.org>
942
943 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
944 only under bidi iteration.
945
115b96bd
JD
9462011-09-07 Jan Djärv <jan.h.d@swipnet.se>
947
948 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
949
c8199d0f
PE
9502011-09-06 Paul Eggert <eggert@cs.ucla.edu>
951
952 isnan: Fix porting problem to Solaris 10 with bundled gcc.
953 Without this fix, the command to link temacs failed due to an
954 undefined symbol __builtin_isnan. This is because
955 /usr/include/iso/math_c99.h #defines isnan(x) to
956 __builtin_isnan(x), but the bundled gcc, which identifies itself
957 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
958 a __builtin_isnan.
959 * floatfns.c (isnan): #undef, and then #define to a clone of
960 what's in data.c.
961 (Fisnan): Always define, since it's always available now.
962 (syms_of_floatfns): Always define isnan at the Lisp level.
963
e39b275c 9642011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
965
966 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
967
b2db44d9 9682011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 969
f4af5137 970 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
971 The previous code assumed that file offsets (off_t values) fit in
972 EMACS_INT variables, which is not true on typical 32-bit hosts.
973 The code messed up by falsely reporting buffer overflow in cases
974 such as (insert-file-contents "big" nil 1 2) into an empty buffer
975 when "big" contains more than 2**29 bytes, even though this
976 inserts just one byte and does not overflow the buffer.
977 (Finsert_file_contents): Store file offsets as off_t
978 values, not as EMACS_INT values. Check for overflow when
979 converting between EMACS_INT and off_t. When checking for
980 buffer overflow or for overlap, take the offsets into account.
981 Don't use EMACS_INT for small values where int suffices.
982 When checking for overlap, fix a typo: ZV was used where
983 ZV_BYTE was intended.
984 (Fwrite_region): Don't assume off_t fits into 'long'.
985 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
986
ecfc0a49
MA
9872011-09-05 Michael Albinus <michael.albinus@gmx.de>
988
989 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
990
6511acf2 9912011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 992
0999621a 993 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
994
995 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 996 (esprintf, exprintf, evxprintf): New functions.
62f19c19 997 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 998 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
999 (modify_event_symbol): Do not assume that the length of
1000 name_alist_or_stem is safe to alloca and fits in int.
1001 (Fexecute_extended_command): Likewise for function name and binding.
1002 (Frecursion_depth): Wrap around reliably on integer overflow.
1003 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1004 since some callers pass EMACS_INT values.
1005 (Fsingle_key_description): Don't crash if symbol name contains more
1006 than MAX_ALLOCA bytes.
1007 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1008 (get_minibuffer): Arg is now EMACS_INT, not int.
1009 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1010 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1011 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1012
2be7d702
PE
1013 * dbusbind.c (signature_cat): New function.
1014 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1015 Do not overrun buffer; instead, report string overflow.
1016
9d1df220
PE
1017 * dispnew.c (add_window_display_history): Don't overrun buffer.
1018 Truncate instead; this is OK since it's just a log.
1019
33ef5c64
PE
1020 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1021 even if the time zone offset is outlandishly large.
1022 Don't mishandle offset == INT_MIN.
1023
66c6fdd5
PE
1024 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1025 when creating daemon; the previous buffer-overflow check was incorrect.
1026
d749b01b
PE
1027 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1028 which has the guts of the old verror function.
1029
b5cd1905
PE
1030 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1031 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1032
6e1a67fb
PE
1033 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1034 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1035 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1036 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1037 length of string rather than counting it via multiple sprintfs;
1038 that's simpler and more reliable.
c21721cc
PE
1039 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1040 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1041 sprintf, in case result does not fit in int.
1042
c57b67fc
PE
1043 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1044 (fontset_from_font): Print it.
1045
8a401434
PE
1046 * frame.c (tty_frame_count): Now printmax_t, not int.
1047 (make_terminal_frame, set_term_frame_name): Print it.
1048 (x_report_frame_params): In X, window IDs are unsigned long,
1049 not signed long, so print them as unsigned.
1050 (validate_x_resource_name): Check for implausibly long names,
1051 and don't assume name length fits in 'int'.
1052 (x_get_resource_string): Don't blindly alloca invocation name;
1053 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1054 not fit in int.
1055
6e1a67fb
PE
1056 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1057 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1058 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1059
0df02bf3
PE
1060 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1061 Use esprintf, not sprintf, in case result does not fit in int.
1062
48e30793
PE
1063 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1064 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1065 it as a large positive number.
1066 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1067 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1068
a66ff6d8
PE
1069 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1070 in case result does not fit in int.
1071
aca216ff
PE
1072 * print.c (float_to_string): Detect width overflow more reliably.
1073 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1074 buffer overrun. Don't assume list length fits in 'int'. Treat
1075 print length of 0 as 0, not as infinity; to be consistent with other
1076 uses of print length in this function. Don't overflow print length
1077 index. Don't assume hash table size fits in 'long', or that
1078 vectorlike size fits in 'unsigned long'.
1079
31c286f7
PE
1080 * process.c (make_process): Use printmax_t, not int, to format
1081 process-name gensyms.
1082
55e5faa1
PE
1083 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1084
80f2e268
PE
1085 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1086 to avoid potential buffer overrun.
1087
670741ab
PE
1088 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1089 if X resource line is longer than 512 bytes.
1090
b7163a50
PE
1091 * xfns.c (x_window): Make sprintf buffer a bit bigger
1092 to avoid potential buffer overrun.
1093
ae58ff1f
PE
1094 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1095
c43c8a6a
PE
1096 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1097
3f8236f4
PE
10982011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1099
53e9fe90 1100 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1101 Without these, Emacs silently mishandles large integers sometimes.
1102 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1103 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1104
6511acf2
PE
1105 * xdisp.c (try_window_id): Check Emacs fixnum range before
1106 converting to 'int'.
806add1d 1107
6511acf2 1108 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1109 Check that an Emacs fixnum is in range before assigning it to 'int'.
1110 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1111 values converted from Emacs fixnums.
1112 (Frecenter): Don't wrap around a line count if it is out of 'int'
1113 range; instead, treat it as an extreme value.
1114 (Fset_window_configuration, compare_window_configurations):
1115 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1116
6511acf2
PE
1117 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1118 that can exceed INT_MAX. Check that EMACS_INT value is in range
1119 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1120 (match_limit): Don't assume that a fixnum can fit in 'int'.
1121
6511acf2 1122 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1123 exceed INT_MAX.
1124
6511acf2 1125 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1126 (Fvertical_motion): Don't wrap around LINES values that don't fit
1127 in 'int'. Instead, treat them as extreme values. This is good
1128 enough for windows, which can't have more than INT_MAX lines anyway.
1129
fcb901a7
LMI
11302011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1131
0f2f6b6d
LMI
1132 * Require libxml/parser.h to avoid compilation warning.
1133
fcb901a7
LMI
1134 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1135
1136 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1137 since this reportedly can destroy thread storage.
1138
6e20a0d4
CY
11392011-08-30 Chong Yidong <cyd@stupidchicken.com>
1140
1141 * syntax.c (find_defun_start): Update all cache variables if
1142 exiting early (Bug#9401).
1143
148ae00e
EZ
11442011-08-30 Eli Zaretskii <eliz@gnu.org>
1145
f6cfbd8f
EZ
1146 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1147
148ae00e
EZ
1148 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1149 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1150 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1151
1152 * term.c (tty_append_glyph): New function.
1153 (produce_stretch_glyph): Static function and its prototype deleted.
1154
a66cfb1c
SM
1155 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1156 Add prototypes.
148ae00e 1157
c4a07a4c
PE
11582011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1159
1160 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1161 when checking :margin (Bug#9390).
1162 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1163 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1164 so that the name doesn't mislead. All uses changed.
1165
6bc8cd65
JB
11662011-08-28 Johan Bockgård <bojohan@gnu.org>
1167
1168 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1169 set_tty_hooks.
1170
dca4927e
EZ
11712011-08-27 Eli Zaretskii <eliz@gnu.org>
1172
1173 * xdisp.c (move_it_to): Don't bail out early when reaching
1174 position beyond to_charpos, if we are scanning backwards.
1175 (move_it_vertically_backward): When DY == 0, make sure we get to
1176 the first character in the line after the newline.
1177
f2cad773
PE
11782011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1179
1180 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1181 (ccl_driver): Do not generate an out-of-range pointer.
1182 (Fccl_execute_on_string): Remove unnecessary check for
1183 integer overflow, noted by Stefan Monnier in
1184 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1185 Remove a FIXME that didn't need fixing.
1186 Simplify the newly-introduced buffer reallocation code.
1187
0cae2cdb
JB
11882011-08-27 Juanma Barranquero <lekktu@gmail.com>
1189
1190 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1191
5fc295a4 11922011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1193
70c60eb2 1194 Integer and memory overflow issues (Bug#9196).
726e0ab1 1195
d31850da
PE
1196 * doc.c (get_doc_string): Rework so that
1197 get_doc_string_buffer_size is the actual buffer size, rather than
1198 being 1 less than the actual buffer size; this makes xpalloc more
1199 convenient.
1200
a69fbedb
PE
1201 * image.c (x_allocate_bitmap_record, cache_image):
1202 * xselect.c (Fx_register_dnd_atom):
1203 Simplify previous changes by using xpalloc.
1204
fe5c5d37
PE
1205 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1206 since either will do and ptrdiff_t is convenient with xpalloc.
1207
0065d054
PE
1208 * charset.c (charset_table_size)
1209 (struct charset_sort_data.priority): Now ptrdiff_t.
1210 (charset_compare): Don't overflow if priorities differ greatly.
1211 (Fsort_charsets): Don't assume list length fits in int.
1212 Check for size-calculation overflow when allocating sort data.
1213 (syms_of_charset): Allocate an initial charset table that is
1214 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1215
1216 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1217
1218 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1219 The actual value is always <= INT_MAX, and leaving it unsigned made
1220 overflow checking harder.
1221
1222 * dispextern.h (struct glyph_matrix.rows_allocated)
1223 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1224 with xpalloc. The values are still always <= INT_MAX.
1225
1226 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1227
1228 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1229 (SAFE_NALLOCA): New macro.
1230
1231 * region-cache.c (struct boundary.pos, find_cache_boundary)
1232 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1233 (set_cache_region, invalidate_region_cache)
1234 (revalidate_region_cache, know_region_cache, region_cache_forward)
1235 (region_cache_backward, pp_cache):
1236 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1237 so that ptrdiff_t * can be passed to xpalloc.
1238 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1239 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1240 (pp_cache): Don't assume cache_len fits in int.
1241 * region-cache.h: Adjust extern decls to match.
1242
1243 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1244 EMACS_INT, since either will do, for xpalloc.
1245
1246 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1247 (xnmalloc, xnrealloc, xpalloc): New functions.
1248
726e0ab1
PE
1249 * bidi.c (bidi_shelve_header_size): New constant.
1250 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1251 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1252
51f30bc5 1253 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1254 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1255 (overlay_strings):
1256 Don't update size of array until after memory allocation succeeds,
1257 because xmalloc/xrealloc may not return.
0065d054
PE
1258 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1259 now that we have proper integer overflow checking.
1260 (record_overlay_string, overlay_strings): Catch overflows when
1261 calculating size of overlay_str_buf.
726e0ab1 1262
0065d054
PE
1263 * callproc.c (Fcall_process): Check for size overflow when
1264 calculating size of args2.
1265 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1266 Normally we prefer signed values, but sticking with ptrdiff_t would
1267 require adding more-complicated checks.
726e0ab1
PE
1268
1269 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1270 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1271 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1272 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1273
1274 * character.c (Fstring): Check for size-calculation overflow.
1275
1276 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1277 unnecessary integer overflow. Check for size overflow.
1278 (encode_coding_object): Don't update size until xmalloc succeeds.
1279
1280 * composite.c (get_composition_id): Check for overflow in glyph
1281 length calculations.
1282
1283 Integer and memory overflow fixes for display code.
1284 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1285 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1286 (scrolling_window): Check for overflow in size calculations.
1287 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1288 Don't assume glyph table len fits in int.
1289 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1290 (row_table_size): Now ptrdiff_t, not int.
1291 (scrolling_window): Avoid overflow in size calculations.
1292 Don't update size until allocation succeeds.
1293 * fns.c (concat): Check for overflow in size calculations.
1294 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1295 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1296 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1297
1298 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1299 (get_doc_string): Check for size calculation overflow.
1300 Don't update size until allocation succeeds.
1301 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1302 EMACS_INT, where ptrdiff_t will do.
1303 (Fsubstitute_command_keys): Check for string overflow.
1304
1305 * editfns.c (set_time_zone_rule): Don't assume environment length
1306 fits in int.
1307 (message_length): Now ptrdiff_t, not int.
1308 (Fmessage_box): Don't update size until allocation succeeds.
1309 Don't assume message length fits in int.
1310 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1311
0065d054
PE
1312 * emacs.c (main): Do not reallocate argv, since there is a null at
1313 the end that can be overwritten, and this way there's no need to
1314 worry about size-calculation overflow.
1315 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1316
1317 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1318 alloc succeeds.
1319 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1320
1321 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1322 (x_set_scroll_bar_width, x_figure_window_size):
1323 Check for integer overflow.
1324 (x_set_alpha): Do not assume XINT fits in int.
1325
1326 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1327 This is for the members text_lines, text_cols, total_lines, total_cols,
1328 where the system imposes an 'int' limit.
1329
1330 * fringe.c (Fdefine_fringe_bitmap):
1331 Don't update size until alloc works.
1332
1333 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1334 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1335
1336 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1337 Check for size-calculation overflow.
1338 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1339 do, as we prefer signed integers.
1340 (id_to_widget.max_size, id_to_widget.used)
1341 (xg_store_widget_in_map, xg_remove_widget_from_map)
1342 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1343 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1344 Use and return ptrdiff_t, not int.
1345 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1346 * gtkutil.h: Change prototypes to match the above.
1347
1348 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1349 are duplicate now that they've been promoted to lisp.h.
1350 (x_allocate_bitmap_record, x_alloc_image_color)
1351 (make_image_cache, cache_image, xpm_load):
1352 Don't update size until alloc is done.
1353 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1354 (x_detect_edges):
3256efce 1355 Check for size calculation overflow.
726e0ab1
PE
1356 (ct_colors_allocated_max): New constant.
1357 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1358 overflow.
3256efce 1359
726e0ab1
PE
1360 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1361 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1362 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1363 Use ptrdiff_t, not int, to count maps.
1364 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1365 calculations. Don't update size until allocation succeeds.
1366 Redo calculations to avoid overflow.
726e0ab1
PE
1367 * keyboard.h: Change prototypes to match the above.
1368
1369 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1370 to count maps.
1371 (current_minor_maps): Check for size calculation overflow.
1372 * keymap.h: Change prototypes to match the above.
1373
1374 * lread.c (read1, init_obarray): Don't update size until alloc done.
1375
1376 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1377 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1378
726e0ab1
PE
1379 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1380 Now ptrdiff_t, not int.
1381 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1382 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1383
1384 * process.c (Fnetwork_interface_list): Check for overflow
1385 in size calculation.
1386
1387 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1388
1389 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1390 overflow. Don't bother calling xmalloc when xrealloc will do.
1391
1392 * search.c (Freplace_match): Check for size calculation overflow.
1393 (Fset_match_data): Don't assume list lengths fit in 'int'.
1394
1395 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1396 for command line length. Do not attempt to address one before the
1397 beginning of an array, as that's not portable.
1398
1399 * term.c (max_frame_lines): Remove; unused.
1400 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1401 not int.
1402 (encode_terminal_code, calculate_costs): Check for size
1403 calculation overflow.
1404 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1405 table lengths and related sizes. Don't update size until alloc
1406 done. Redo calculations to avoid overflow.
1407 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1408
1409 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1410 subtracting pointers.
1411 (gobble_line): Check for overflow more carefully. Don't update size
1412 until alloc done.
1413
1414 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1415 Don't update size until alloc done.
1416 Redo size calculations to avoid overflow.
1417 Check for size calculation overflow.
0065d054 1418 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1419
1420 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1421 Use ptrdiff_t, not int, for sizes.
1422 (store_mode_line_noprop_char): Don't update size until alloc done.
1423
0065d054
PE
1424 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1425 Use ptrdiff_t, not int, for sizes.
1426 (Finternal_make_lisp_face, cache_face):
1427 Check for size calculation overflow.
1428 (cache_face): Treat size calculation overflows as if they were
1429 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1430
1431 * xfns.c (x_encode_text, x_set_name_internal)
1432 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1433 sizes, since they can exceed INT_MAX in size. Check for size
1434 calculation overflow.
1435
0065d054
PE
1436 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1437 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1438 Don't update size until alloc done.
1439
0065d054 1440 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1441 as sprintf is limited to int lengths.
1d526e2f 1442
252c5ee1
PE
1443 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1444 (X_LONG_MIN): New macros.
864d7ce7
PE
1445 Use them to make the following changes clearer.
1446 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1447 This change doesn't affect the value now, but it may help remind
1448 future maintainers not to raise the value too much later.
1449 (SELECTION_QUANTUM): Remove, replacing with ...
1450 (selection_quantum): ... new function, which avoids overflow.
1451 All uses changed.
1452 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1453 assumption that selection length fits in 'int'.
1454 (x_reply_selection_request, x_handle_selection_request)
1455 (x_get_window_property, receive_incremental_selection)
1456 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1457 (lisp_data_to_selection_data, clean_local_selection_data):
1458 Use ptrdiff_t, not int, to record length of selection.
1459 (x_reply_selection_request, x_get_window_property)
1460 (receive_incremental_selection, x_property_data_to_lisp):
1461 Redo calculations to avoid overflow.
1462 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1463 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1464 something.
1465 (x_get_window_property, receive_incremental_selection)
1466 (lisp_data_to_selection_data, x_property_data_to_lisp):
1467 Check for size-calculation overflow.
1468 (x_get_window_property, receive_incremental_selection)
1469 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1470 Don't store size until memory allocation succeeds.
1471 (x_get_window_property): Plug memory leak on memory exhaustion.
1472 Don't double-block input; malloc is safe here. Don't assume 2**34
1473 - 4 fits in unsigned long. Add an xassert to check
1474 XGetWindowProperty overflow. Be more careful about overflow
1475 calculations, and distinguish size from memory overflow better.
1476 (receive_incremental_selection): When tracing, don't assume
1477 unsigned int is less than INT_MAX.
1478 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1479 harmful) conversions of unsigned short to int.
1480 (lisp_data_to_selection_data): Don't assume that integers
1481 in the range -65535 through -1 fit in an X unsigned short.
1482 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1483 result parameters unless successful. Rely on cons_to_unsigned
1484 to report problems with elements; the old code wasn't right anyway.
1485 (x_check_property_data): Check for int overflow; we cannot use
1486 a wider type due to X limits.
1487 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1488
726e0ab1 1489 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1490
0065d054
PE
1491 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1492 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1493 (x_color_cells): Don't store size until memory allocation succeeds.
1494 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1495 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1496 (x_term_init): Don't assume length fits in int (sprintf is limited
1497 to int size).
bc18e09d 1498
ebfa62c0
PE
1499 Use ptrdiff_t for composition IDs.
1500 * character.c (lisp_string_width):
1501 * composite.c (composition_table_size, n_compositions)
1502 (get_composition_id, composition_gstring_from_id):
1503 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1504 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1505 * window.c (Frecenter):
1506 Use ptrdiff_t, not int, for composition IDs.
1507 * composite.c (get_composition_id): Check for integer overflow.
1508 * composite.h: Adjust prototypes to match the above changes.
1509
d3411f89
PE
1510 Use ptrdiff_t for hash table indexes.
1511 * category.c (hash_get_category_set):
1512 * ccl.c (ccl_driver):
1513 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1514 * coding.c (coding_system_charset_list, detect_coding_system):
1515 * coding.h (struct coding_system.id):
1516 * composite.c (get_composition_id, gstring_lookup_cache):
1517 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1518 * image.c (xpm_get_color_table_h):
1519 * lisp.h (hash_lookup, hash_put):
1520 * minibuf.c (Ftest_completion):
1521 Use ptrdiff_t for hash table indexes, not int (which is too
1522 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1523 32-bit --with-wide-int hosts).
1524
e097a6fa
PE
1525 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1526 Add a FIXME comment about memory leaks.
1527 (syms_of_charset): Don't assume xmalloc returns.
1528
5637687f
PE
1529 Don't assume that stated character widths fit in int.
1530 * character.c (Fchar_width, c_string_width, lisp_string_width):
1531 * character.h (CHAR_WIDTH):
1532 * indent.c (MULTIBYTE_BYTES_WIDTH):
1533 Use sanitize_char_width to avoid undefined and/or bad behavior
1534 with outlandish widths.
a66cfb1c 1535 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1536 now that we have two such functions. All uses changed.
1537 (sanitize_char_width): New inline function.
1538
a2271ba2
PE
1539 Don't assume that tab-width fits in int.
1540 * character.h (sanitize_width): New inline function.
1541 (SANE_TAB_WIDTH): New macro.
1542 (ASCII_CHAR_WIDTH): Use it.
1543 * indent.c (sane_tab_width): Remove. All uses replaced by
1544 SANE_TAB_WIDTH (current_buffer).
1545 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1546
18c52557
PE
1547 * fileio.c: Integer overflow issues with file modes.
1548 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1549
caeeedc1
PE
1550 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1551 Remove unreachable code.
1552 (read_hex, load_charset_map_from_file): Check for integer overflow.
1553
50849c52
PE
1554 * xterm.c: don't go over XClientMessageEvent limit
1555 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1556 (x_send_scroll_bar_event): Likewise. Check that the size does not
1557 exceed limits imposed by XClientMessageEvent, as well as the usual
1558 ptrdiff_t and size_t limits.
1559
b13995db
PE
1560 * keyboard.c: Overflow, signedness and related fixes.
1561 (make_lispy_movement): Use same integer type in forward decl
1562 that is used in the definition.
1563 (read_key_sequence, keyremap_step):
1564 Change bufsize argument back to int, undoing my 2011-03-30 change.
1565 We prefer signed types, and int is wide enough here.
1566 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1567 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1568 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1569 length, not size_t. Use ptrdiff_t for index, not int.
1570 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1571 possibility of integer overflow.
1572
13464394
PE
1573 Overflow, signedness and related fixes for images.
1574
1575 * dispextern.h (struct it.stack[0].u.image.image_id)
1576 (struct_it.image_id, struct image.id, struct image_cache.size)
1577 (struct image_cache.used, struct image_cache.ref_count):
1578 * gtkutil.c (update_frame_tool_bar):
1579 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1580 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1581 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1582 * nsmenu.m (update_frame_tool_bar):
1583 * xdisp.c (calc_pixel_width_or_height):
1584 * xfns.c (image_cache_refcount):
1585 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1586 on typical 64-bit hosts.
1587
1588 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1589 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1590 Omit unnecessary casts to int.
1591 (parse_image_spec): Check that integers fall into 'int' range
1592 when the callers expect that.
1593 (image_ascent): Redo ascent calculation to avoid int overflow.
1594 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1595 (lookup_image): Remove unnecessary tests.
1596 (xbm_image_p): Locals are now of int, not EMACS_INT,
1597 since parse_image_check makes sure they fit into int.
1598 (png_load, gif_load, svg_load_image):
1599 Prefer int to unsigned where either will do.
1600 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1601 old tiff_error_handler and tiff_warning_handler.
1602 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1603 stack buffer overflows. It uses only the features of vsnprintf
1604 that are common to both POSIX and native Microsoft.
1605 (tiff_error_handler, tiff_warning_handler): Use it.
1606 (tiff_load, gif_load, imagemagick_load_image):
1607 Don't assume :index value fits in 'int'.
1608 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1609 (imagemagick_load_image): Check that crop parameters fit into
1610 the integer types that MagickCropImage accepts. Don't assume
1611 Vimagemagick_render_type has a nonnegative value. Don't assume
1612 size_t fits in 'long'.
1613 (gs_load): Use printmax_t to print the widest integers possible.
1614 Check for integer overflow when computing image height and width.
1615
c11821d4
EZ
16162011-08-26 Eli Zaretskii <eliz@gnu.org>
1617
1618 * xdisp.c (redisplay_window): Don't force window start if point
1619 will be invisible in the resulting window. (Bug#9324)
1620
0c95fcf7
EZ
16212011-08-25 Eli Zaretskii <eliz@gnu.org>
1622
1623 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1624 the display spec is of the form `(space ...)'.
1625 (handle_display_spec): Return the value returned by
1626 handle_single_display_spec, not just 1 or zero.
1627 (handle_single_display_spec): If the display spec is of the form
1628 `(space ...)', and specifies display in the text area, return 2
1629 rather than 1.
fee65a97 1630 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1631 accurately, and prefer exact match for point under bidi.
1632 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1633
1634 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1635 into disp_prop; all users changed.
1636
1637 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1638 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1639 for the text covered by the display property.
1640
e4ed06f1
CY
16412011-08-25 Chong Yidong <cyd@stupidchicken.com>
1642
1643 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1644 Change return value to nil.
1645 (Frecord_buffer): Delete unused function.
1646
f67cdd7f
EZ
16472011-08-24 Eli Zaretskii <eliz@gnu.org>
1648
5980d4c6
EZ
1649 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1650 buffers, return left-to-right.
8610fe8b
EZ
1651 (set_cursor_from_row): Consider candidate row a win if its glyph
1652 represents a newline and point is on that newline. Fixes cursor
1653 positioning on the newline at EOL of R2L text within L2R
1654 paragraph, and vice versa.
1655 (try_cursor_movement): Check continued rows, in addition to
1656 continuation rows. Fixes unwarranted scroll when point enters a
1657 continued line of R2L text within an L2R paragraph, or vice versa.
1658 (cursor_row_p): Consider the case of point being equal to
1659 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1660 from the end of a short line to the beginning of a continued line
1661 of R2L text within L2R paragraph.
1662 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1663 composed characters.
5980d4c6 1664
f67cdd7f
EZ
1665 * bidi.c (bidi_check_type): Use xassert.
1666 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1667 members.
1668
bca633fb
EZ
16692011-08-23 Eli Zaretskii <eliz@gnu.org>
1670
1671 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1672 a character.
1673
4a5885a7
CY
16742011-08-23 Chong Yidong <cyd@stupidchicken.com>
1675
1676 * nsfont.m (ns_otf_to_script): Fix typo.
1677
0902a04e
KH
16782011-08-22 Kenichi Handa <handa@m17n.org>
1679
1680 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1681 extra slot even if the purpose is char-code-property-table.
1682
1a2e6670
EZ
16832011-08-23 Eli Zaretskii <eliz@gnu.org>
1684
8ddde651
EZ
1685 * xdisp.c (redisplay_window): When computing centering_position,
1686 account for the height of the header line. (Bug#8874)
1687
425cc014
EZ
1688 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1689 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1690 candidate is selected by the mouse, and that candidate has a
1691 composed character under the mouse.
1692
1a2e6670
EZ
1693 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1694 coordinates reported by pos-visible-in-window-p for a composed
1695 character in column zero.
1696
8b76d6f8
SM
16972011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1698
1699 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1700
dac347dd
EZ
17012011-08-22 Eli Zaretskii <eliz@gnu.org>
1702
1703 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1704 consider it a hit if to_charpos is anywhere in the range of the
1705 composed buffer positions.
1706
e013fb34
CY
17072011-08-22 Chong Yidong <cyd@stupidchicken.com>
1708
1709 * image.c (gif_load): Don't assume that each subimage has the same
1710 dimensions as the base image. Handle disposal method that is
1711 "undefined" by the gif spec (Bug#9335).
1712
bd1ba3e8
CY
17132011-08-20 Chong Yidong <cyd@stupidchicken.com>
1714
1715 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1716 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1717
54a1215b
EZ
17182011-08-19 Eli Zaretskii <eliz@gnu.org>
1719
823564e5
EZ
1720 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1721 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1722 from an Org mode buffer to a Speedbar frame.
1723
54a1215b
EZ
1724 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1725 a composition, take its buffer position from IT->cmp_it.charpos.
1726 Fixes cursor positioning at the beginning of a line that begins
1727 with a composed character.
1728
9778ebcc
EZ
17292011-08-18 Eli Zaretskii <eliz@gnu.org>
1730
0be6ee06
EZ
1731 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1732 character bidirectional type, use STRONG_L instead. Fixes crashes
1733 in a buffer produced by `describe-categories'.
1734
9778ebcc
EZ
1735 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1736 members before the level stack, so they would be saved and
1737 restored when copying iterator state. Fixes incorrect reordering
1738 around TABs covered by display properties.
1739
156bffbe
AS
17402011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1741
6b02f655 1742 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1743
72ad093b
CY
17442011-08-17 Chong Yidong <cyd@stupidchicken.com>
1745
1746 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1747 (internal_condition_case_2, internal_condition_case_n):
1748 Remove unnecessary aborts (Bug#9081).
72ad093b 1749
35774242
EZ
17502011-08-17 Eli Zaretskii <eliz@gnu.org>
1751
1752 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1753 has no `load' handler, try opening the file locally. (Bug#9311)
1754
db76dd85
KB
17552011-08-16 Ken Brown <kbrown@cornell.edu>
1756
1757 * gmalloc.c: Expand comment.
1758
b215eee5
EZ
17592011-08-16 Eli Zaretskii <eliz@gnu.org>
1760
1761 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1762 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1763
a4579d33
KB
17642011-08-16 Ken Brown <kbrown@cornell.edu>
1765
1766 Fix memory allocation problems in Cygwin build (Bug#9273).
1767
1768 * unexcw.c ( __malloc_initialized): Declare external variable.
1769 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1770
8b76d6f8
SM
1771 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1772 New variables.
a4579d33
KB
1773 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1774 dumped emacs.
1775 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1776 in the static heap.
1777 [CYGWIN] (special_realloc): New function.
1778 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1779 requests to realloc storage in the static heap.
1780
3ebec551
PE
17812011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1782
1783 * bidi.c (bidi_initialize): Remove unused local.
1784
9fd8be00
EZ
17852011-08-15 Eli Zaretskii <eliz@gnu.org>
1786
6b02f655
SM
1787 * bidimirror.h:
1788 * biditype.h: Remove file.
1789 * makefile.w32-in ($(BLD)/bidi.$(O)):
1790 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1791
1792 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1793
1794 * chartab.c: Improve commentary for the uniprop_table API.
1795
32413314
EZ
1796 * bidi.c (bidi_paragraph_init): Support zero value of
1797 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1798 (bidi_initialize): Use uniprop_table instead of including
1799 biditype.h and bidimirror.h.
32413314 1800
9fd8be00
EZ
1801 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1802 coordinates of the iterator when restoring from ppos_it.
1803 (Bug#9296)
1804
5cf2b69b
KH
18052011-08-14 Kenichi Handa <handa@m17n.org>
1806
1807 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1808 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1809
daf17d00
EZ
18102011-08-14 Eli Zaretskii <eliz@gnu.org>
1811
1812 * xdisp.c (move_it_in_display_line_to): Don't invoke
1813 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1814 ppos_it. Fixes vertical cursor motion when line beginning is
1815 covered by an image. (Bug#9296)
1816
08e3161a
JD
18172011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1818
1819 * nsterm.h (ns_run_ascript): Declare.
1820 (NSAPP_DATA2_RUNASSCRIPT): Define.
1821
1822 * nsfns.m (as_script, as_result, as_status): New static variables.
1823 (ns_run_ascript): New function.
5e617bc2 1824 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1825 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1826 the event loop. Get status from as_status (Bug#7276).
1827
1828 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1829 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1830 the event loop (Bug#7276).
1831
a3720aa2
AS
18322011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1833
1834 * gnutls.c (QCgnutls_bootprop_priority)
1835 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1836 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1837 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1838 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1839 (QCgnutls_bootprop_verify_hostname_error)
1840 (QCgnutls_bootprop_callbacks_verify): Rename from
1841 Qgnutls_bootprop_..., all uses changed.
1842
1843 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1844 uses changed.
1845
0a0d27fb
PE
18462011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1847
19d5c50c
PE
1848 * xfaces.c (Qframe_set_background_mode): Now static.
1849 * dispextern.h (Qframe_set_background_mode): Remove decl.
1850
0a0d27fb
PE
1851 * process.c (Fnetwork_interface_info): Declare local only if needed.
1852
377538cb
JD
18532011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1854
1855 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1856 (Fnetwork_interface_list): Allocate in increments of bytes instead
1857 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1858 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1859 sockaddr.
1860 (struct ifflag_def): notrailers is smart on OSX.
1861 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1862 Get hardware address with getifaddrs if available.
1863
08fff70c
EZ
18642011-08-12 Eli Zaretskii <eliz@gnu.org>
1865
1866 * xdisp.c (iterate_out_of_display_property): xassert that
1867 IT->position is set to within IT->object's boundaries. Break from
1868 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1869 when IT->position is set up wrongly due to some bug.
1870 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1871 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1872 entry. Force push_it to save on the stack the current
1873 buffer/string position, to be restored by pop_it. Fix flags in
1874 the iterator structure wrt the object coming from a display
1875 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1876 properties. (Bug#9284)
1877
7be1c708 18782011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1879
7be1c708
CY
1880 * fontset.c (fontset_get_font_group): Add proper type checks.
1881 (Bug#9172)
aac0c6e3 1882
7be1c708 18832011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1884
7be1c708
CY
1885 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1886 and LC_VERSION_MIN_MACOSX.
1887 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1888 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1889
97bb72a6
EZ
18902011-08-08 Eli Zaretskii <eliz@gnu.org>
1891
1892 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1893 no-display-properties-and-no-overlays under bidi display.
1894 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1895 properties and overlays.
97bb72a6 1896
d5617611
CY
18972011-08-08 Chong Yidong <cyd@stupidchicken.com>
1898
37e11a63
CY
1899 * editfns.c (Fset_time_zone_rule): Document relationship with the
1900 setenv function.
1901
d5617611
CY
1902 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1903 the font entity extracted from the cache (Bug#8109).
1904
58872834
CY
19052011-08-07 Chong Yidong <cyd@stupidchicken.com>
1906
1907 * composite.c (autocmp_chars): Don't reset point. That is done by
1908 restore_point_unwind (Bug#5984).
1909
75bfc667
JL
19102011-08-07 Juri Linkov <juri@jurta.org>
1911
1912 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1913 to show the arg `TIME' instead of `TIMEVAL'.
1914
d1410150
EZ
19152011-08-06 Eli Zaretskii <eliz@gnu.org>
1916
1917 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1918 display property strides EOL and includes a newline, as in
1919 longlines-mode. (Bug#9254)
75b771e4
EZ
1920 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1921 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1922
1923 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1924 is non-zero, even if the data buffer is NULL. Fixes a crash in
1925 vertical-motion with longlines-mode. (Bug#9254)
1926
35928349
EZ
19272011-08-05 Eli Zaretskii <eliz@gnu.org>
1928
ec7cc85b
EZ
1929 * bidi.c <bidi_cache_total_alloc>: Now static.
1930 (bidi_initialize): Initialize bidi_cache_total_alloc.
1931
8b76d6f8 1932 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1933 cache. (Bug#9221)
1934
1935 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1936 amount allocated this far in `bidi_cache_total_alloc'.
1937 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1938 non-zero, only free the data buffer without restoring the cache
1939 contents. All callers changed.
1940
1941 * dispextern.h (bidi_unshelve_cache): Update prototype.
1942
1943 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1944 (move_it_in_display_line, move_it_to)
1945 (move_it_vertically_backward, move_it_by_lines): Replace the call
1946 to xfree to an equivalent call to bidi_unshelve_cache.
1947 (move_it_in_display_line_to): Fix logic of returning
412b6358 1948 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1949
e2e2423b
EZ
19502011-08-05 Eli Zaretskii <eliz@gnu.org>
1951
1952 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1953 came from a string character with a `cursor' property. (Bug#9229)
1954
ae9e757a
JD
19552011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1956
1957 * Makefile.in (LIB_PTHREAD): New variable.
1958 (LIBES): Add LIB_PTHREAD (Bug#9216).
1959
1960 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1961 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1962
213bd7f2
AS
19632011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1964
6b02f655 1965 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1966
99aaf75f
JD
19672011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1968
1969 * xterm.c (x_find_topmost_parent): New function.
1970 (x_set_frame_alpha): Find topmost parent window with
1971 x_find_topmost_parent and set the property there also (bug#9181).
1972 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1973
c74e9d86
PE
19742011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1975
1976 * callproc.c (Fcall_process): Avoid vfork clobbering
1977 the local vars buffer, coding_systems, current_dir.
1978
640c8776
SM
19792011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1980
1981 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1982
f26d0e4c
PE
19832011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1984
8a10d76c
PE
1985 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1986 so that it is not optimized away.
1987
f26d0e4c
PE
1988 * xdisp.c (compute_display_string_pos): Remove unused local.
1989
55439c61
EZ
19902011-08-02 Eli Zaretskii <eliz@gnu.org>
1991
1992 Fix slow cursor motion and scrolling in large buffers with
1993 selective display, like Org Mode buffers. (Bug#9218)
1994
1995 * dispextern.h (struct bidi_it): New member disp_prop_p.
1996
1997 * xdisp.c: Remove one-slot cache of display string positions.
1998 (compute_display_string_pos): Accept an additional argument
5e617bc2 1999 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2000 for a display string or property. If found, set DISP_PROP_P
2001 non-zero.
2002
2003 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2004 DISP_PROP_P, and pass it to compute_display_string_pos.
2005 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2006 non-zero. All callers of bidi_fetch_char changed.
2007
fb33fa43
SM
20082011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2009
2010 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2011
b099e063
DM
20122010-12-03 Don March <don@ohspite.net>
2013
2014 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2015 last character M-[char] is translated to ESC [char] (bug#7541).
2016
5cc7f7af
KH
20172011-08-02 Kenichi Handa <handa@m17n.org>
2018
d0fffa3f 2019 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2020
2021 * chartab.c (uniprop_table): Make it non-static.
2022
525d5e6e
EZ
20232011-08-01 Eli Zaretskii <eliz@gnu.org>
2024
2025 * xdisp.c (forward_to_next_line_start): Accept additional argument
2026 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2027 on the newline.
2028 (reseat_at_next_visible_line_start): Use the bidi iterator state
2029 returned by forward_to_next_line_start to restore the state of
2030 it->bidi_it after backing up to previous newline. (Bug#9212)
2031
31011111
AS
20322011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2033
2034 * regex.c (re_comp): Protoize.
2035 (re_exec): Fix return type.
2036 (regexec): Fix type of `ret'. (Bug#9203)
2037
476371c4
PE
20382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2039
e5d76069
PE
2040 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2041 This is needed if max-image-size is a floating-point number.
2042
9a79b20c
AS
20432011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2044
2045 * print.c (print_object): Print empty symbol as ##.
2046
2047 * lread.c (read1): Read ## as empty symbol.
2048
d8c2fa78
AA
20492011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2050
2051 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2052 setting frame foreground color (Bug#9175).
2053 (x_set_background_color): Likewise.
2054
ffe57a7a
AA
2055 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2056 contents (Bug#9176).
2057 (EmacsTooltip -init): Remove bezels and add shadows to
2058 tooltip windows.
2059
bf3492a5
AA
2060 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2061 or scroll bar (Bug#8470).
2062
d55e9c53
AA
2063 * nsfont.m (nsfont_open): Remove assignment to voffset and
2064 unnecessary vars hshink, expand, hd, full_height, min_height.
2065 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2066
2067 * nsterm.h (nsfont_info): Remove voffset field.
2068
d8c2fa78 20692011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2070
2071 Implement strike-through and overline on NextStep (Bug#8863).
2072
2073 * nsfont.m (nsfont_open): Use underline position provided by font,
2074 instead of hard-coded value of 2.
2075 (nsfont_draw): Call ns_draw_text_decoration instead.
2076
2077 * nsterm.h: Add declaration for ns_draw_text_decoration.
2078
2079 * nsterm.m (ns_draw_text_decoration): New function for drawing
2080 underline, overline, and strike-through.
2081 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2082 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2083 accommodate underlining, etc.
4843aac3 2084
4cc60b9b
EZ
20852011-07-28 Eli Zaretskii <eliz@gnu.org>
2086
bc7ece87
EZ
2087 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2088 default.
4cc60b9b 2089
476371c4
PE
20902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2091
66606eea
PE
2092 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2093 Without this fix, if a signal arrives just after memory fills up,
2094 'malloc' might be invoked reentrantly.
2095
476371c4
PE
2096 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2097 In other words, assume that every image size is allowed, on non-X
2098 hosts. This assumption is probably wrong, but it lets Emacs compile.
2099
f3fcc40d
AS
21002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2101
2102 * regex.c (re_iswctype): Convert return values to boolean.
2103
350c992f
EZ
21042011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2105
2106 * xdisp.c (compute_display_string_pos): Don't use cached display
2107 string position if the buffer had its restriction changed.
2108 (Bug#9184)
2109
5266b4bb
PE
21102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2111
2112 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2113
2573a837 21142011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2115
41f55ccd 2116 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2117
39e378da
PE
2118 * bidi.c: Integer size and overflow fixes.
2119 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2120 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2121 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2122 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2123 (bidi_find_other_level_edge):
2124 Use ptrdiff_t instead of EMACS_INT where either will do.
2125 This works better on 32-bit hosts configured --with-wide-int.
2126 (bidi_cache_ensure_space): Check for size-calculation overflow.
2127 Use % rather than repeated addition, for better worst-case speed.
2128 Don't set bidi_cache_size until after xrealloc returns, because it
2129 might not return.
2130 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2131 (bidi_cache_ensure_space): Also check that the bidi cache size
2132 does not exceed that of the largest Lisp string or buffer. See Eli
2133 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2134
5e927815
PE
2135 * alloc.c (__malloc_size_t): Remove.
2136 All uses replaced by size_t. See Andreas Schwab's note
2137 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2138
ca4aa935
PE
2139 * image.c: Improve checking for integer overflow.
2140 (check_image_size): Assume that f is nonnull, since
2141 it is always nonnull in practice. This is one less thing to
2142 worry about when checking for integer overflow later.
2143 (x_check_image_size): New function, which checks for integer
2144 overflow issues inside X.
2145 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2146 This removes the need for a memory_full check.
2147 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2148 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2149 (xbm_read_bitmap_data): Change locals back to 'int', since
2150 their values must fit in 'int'.
2151 (xpm_load_image, png_load, tiff_load):
2152 Invoke x_create_x_image_and_pixmap earlier,
2153 to avoid much needless work if the image is too large.
2154 (tiff_load): Treat overly large images as if
2155 x_create_x_image_and_pixmap failed, not as malloc failures.
2156 (gs_load): Use x_check_image_size.
2157
5f8f9cc2
PE
2158 * gtkutil.c: Omit integer casts.
2159 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2160 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2161
5adf60bc
PE
2162 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2163
c8907a93
PE
2164 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2165 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2166 would wrongly return t on a 64-bit host.
2167
e3c25c68
PE
2168 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2169 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2170 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2171 and therefore cause GCC to emit a bogus diagnostic in some cases.
2172
3f791afe
PE
2173 * image.c: Integer signedness and overflow and related fixes.
2174 This is not an exhaustive set of fixes, but it's time to
2175 record what I've got.
2176 (lookup_pixel_color, check_image_size): Remove redundant decls.
2177 (check_image_size): Don't assume that arbitrary EMACS_INT values
2178 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2179 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2180 (tiff_load, imagemagick_load_image):
2181 Check for overflow in size calculations.
2182 (x_create_x_image_and_pixmap): Remove unnecessary test for
2183 xmalloc returning NULL; that can't happen.
2184 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2185 (xpm_color_bucket): Use better integer hashing function.
2186 (xpm_cache_color): Don't possibly over-allocate memory.
2187 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2188 (gif_memory_source):
2189 Use ptrdiff_t, not int or size_t, to record sizes.
2190 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2191 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2192 either works, as we prefer signed integers.
2193 (tiff_read_from_memory, tiff_write_from_memory):
2194 Return tsize_t, not size_t, since that's what the TIFF API wants.
2195 (tiff_read_from_memory): Don't fail simply because the read would
2196 go past EOF; instead, return a short read.
2197 (tiff_load): Omit no-longer-needed casts.
2198 (Fimagemagick_types): Don't assume size fits into 'int'.
2199
3cc5a532
PE
2200 Improve hashing quality when configured --with-wide-int.
2201 * fns.c (hash_string): New function, taken from sxhash_string.
2202 Do not discard information about ASCII character case; this
2203 discarding is no longer needed.
2204 (sxhash-string): Use it. Change sig to match it. Caller changed.
2205 * lisp.h: Declare it.
2206 * lread.c (hash_string): Remove, since we now use fns.c's version.
2207 The fns.c version returns a wider integer if --with-wide-int is
2208 specified, so this should help the quality of the hashing a bit.
2209
b312a492
PE
2210 * emacs.c: Integer overflow minor fix.
2211 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2212 Define only if GNU_LINUX.
2213 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2214
dfd153ae
PE
2215 * dispnew.c: Integer signedness and overflow fixes.
2216 Remove unnecessary forward decls, that were a maintenance hassle.
2217 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2218 All uses changed.
2219 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2220 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2221 (prepare_desired_row, line_draw_cost):
2222 Use int, not unsigned, where either works.
2223 (save_current_matrix, restore_current_matrix):
2224 Use ptrdiff_t, not size_t, where either works.
2225 (init_display): Check for overflow more accurately, and without
2226 relying on undefined behavior.
2227
a81d11a3
PE
2228 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2229 Remove, replacing with the new symbols in lisp.h. All uses changed.
2230 * fileio.c (make_temp_name):
2231 * filelock.c (lock_file_1, lock_file):
2232 * xdisp.c (message_dolog):
2233 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2234 Use pMd etc. instead.
2235 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2236 replacing the pWIDE etc. symbols removed from editfns.c.
2237
3300e6fd
PE
2238 * keyboard.h (num_input_events): Now uintmax_t.
2239 This is (very slightly) less likely to mess up due to wraparound.
2240 All uses changed.
2241
fd05c7e9
PE
2242 * buffer.c: Integer signedness fixes.
2243 (alloc_buffer_text, enlarge_buffer_text):
2244 Use ptrdiff_t rather than size_t when either will do, as we prefer
2245 signed integers.
2246
903fe15d
PE
2247 * alloc.c: Integer signedness and overflow fixes.
2248 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2249 (__malloc_size_t): Default to size_t, not to int.
2250 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2251 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2252 Prefer ptrdiff_t to size_t when either would do, as we prefer
2253 signed integers.
2254 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2255 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2256 Now const. Initialize with values that are in range even if char
2257 is signed.
2258 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2259 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2260 These functions do the right thing with sizes > 2**32.
2261 (check_depth): Now ptrdiff_t, not int.
2262 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2263 Adjust to new way of storing sizes. Check for size overflow bugs
2264 in rest of code.
2265 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2266 slightly wrong anyway, as it missed one instance of
2267 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2268 (refill_memory_reserve): Omit needless cast to size_t.
2269 (mark_object_loop_halt): Mark as externally visible.
2270
ac82cc6a
PE
2271 * xselect.c: Integer signedness and overflow fixes.
2272 (Fx_register_dnd_atom, x_handle_dnd_message):
2273 Use ptrdiff_t, not size_t, since we prefer signed.
2274 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2275 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2276 x_dnd_atoms_size and x_dnd_atoms_length.
2277
c2d1e36d
PE
2278 * doprnt.c: Prefer signed to unsigned when either works.
2279 * eval.c (verror):
2280 * doprnt.c (doprnt):
2281 * lisp.h (doprnt):
2282 * xdisp.c (vmessage):
2283 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2284 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2285 prefer signed arithmetic to avoid comparison confusion.
2286 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2287 but is a bit tricky.
2288
0e926e56
PE
2289 Assume freestanding C89 headers, string.h, stdlib.h.
2290 * data.c, doprnt.c, floatfns.c, print.c:
2291 Include float.h unconditionally.
2292 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2293 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2294 * regex.c: Likewise for stddef.h, string.h.
2295 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2296 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2297 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2298 (STDC_HEADERS): Remove obsolete defines.
2299 * sysdep.c: Include limits.h unconditionally.
2300
9cfdb3ec
PE
2301 Assume support for memcmp, memcpy, memmove, memset.
2302 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2303 * regex.c (memcmp, memcpy):
2304 Remove; we assume C89 now.
2305
2306 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2307 (__malloc_safe_bcopy): Remove; no longer needed.
2308
cf950e6b 2309 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2310 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2311 well either way, and we prefer signed to unsigned.
2312
dbf38e02
LMI
23132011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2314
2315 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2316 closes the connection while we're reading (bug#9182).
2317
d6f0886c 23182011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2319
d6f0886c
JD
2320 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2321 are specified (Bug#9168).
24e0f6b1 2322
2eb1f9e6
PE
23232011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2324
2325 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2326 Found by GCC static checking and --with-wide-int on a 32-bit host.
2327
22381272 23282011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2329
2330 * xdisp.c (compute_display_string_pos): Fix logic of caching
2331 previous display string position. Initialize cached_prev_pos to
2332 -1. Fixes slow-down at the beginning of a buffer.
2333
f25e39b4
EZ
23342011-07-24 Eli Zaretskii <eliz@gnu.org>
2335
2336 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2337 for attrs[LFACE_FONTSET_INDEX].
2338
04c4b52e
PE
23392011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2340
2341 * xml.c (parse_region): Remove unused local
2342 that was recently introduced.
2343
c1734fbd
EZ
23442011-07-23 Eli Zaretskii <eliz@gnu.org>
2345
be18c5a5
EZ
2346 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2347 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2348
c1734fbd
EZ
2349 * xdisp.c (move_it_in_display_line_to): Record the best matching
2350 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2351 exit if none of the characters scanned was an exact match.
2352 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2353 when exact match is impossible due to invisible text, and the
2354 lines are truncated.
2355
a258d627
JD
23562011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2357
2358 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2359 for OSX >= 10.7.
2360
b6d5a689
EZ
23612011-07-22 Eli Zaretskii <eliz@gnu.org>
2362
0f74f785
EZ
2363 Fix a significant slow-down of cursor motion with C-n, C-p,
2364 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2365 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2366 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2367 (next_element_from_buffer): Call compute_stop_pos_backwards to
2368 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2369 base_level_stop.
2370 (reseat): Don't look for prev_stop, as that could mean a very long
2371 run.
2372 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2373 <cached_disp_overlay_modiff>: Cache for last found display string
2374 position.
551918c1 2375 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2376 about the same buffer in the same area of character positions, and
2377 the buffer wasn't changed since the time the display string
2378 position was cached.
551918c1 2379
b2d0c91a
EZ
23802011-07-22 Eli Zaretskii <eliz@gnu.org>
2381
2382 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2383 is an integer, which is important for empty lines. (Bug#9149)
2384
043604ee
CY
23852011-07-22 Chong Yidong <cyd@stupidchicken.com>
2386
2387 * frame.c (Fmodify_frame_parameters): In tty case, update the
2388 default face if necessary (Bug#4238).
2389
da4adb04
CY
23902011-07-21 Chong Yidong <cyd@stupidchicken.com>
2391
2392 * editfns.c (Fstring_to_char): No need to explain what a character
2393 is in the docstring (Bug#6576).
2394
9abd0532
LMI
23952011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2396
2397 * xml.c (parse_region): Make sure we always return a tree.
2398
36881d16
HK
23992011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2400
2401 * xml.c (parse_region): If a document contains only comments,
2402 return that, too.
2403
1e98674d
LMI
24042011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2405
2406 * xml.c (make_dom): Return comments, too.
2407
590bd467
PE
24082011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2409
2410 Port to OpenBSD.
2411 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2412 and the surrounding thread.
2413 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2414 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2415 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2416 timer goes off.
2417 * s/openbsd.h (BROKEN_SIGIO): Define.
2418 * unexelf.c (unexec) [__OpenBSD__]:
2419 Don't update the .mdebug section of the Alpha COFF symbol table.
2420
f41628b2
LMI
24212011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2422
2423 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2424 (bug#8460).
2425
b59b67c5
PE
24262011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2427
15e3a074
PE
2428 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2429 This fixes some race conditions on the permissions of any newly
2430 created file.
2431
41bed37d
PE
2432 * alloc.c (valid_pointer_p): Use pipe, not open.
2433 This fixes some permissions issues when debugging.
2434
b59b67c5
PE
2435 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2436 If fchown fails to set both uid and gid, try to set just gid,
2437 as that is sometimes allowed. Adjust the file's mode to eliminate
2438 setuid or setgid bits that are inappropriate if fchown fails.
2439
925a6be7
SM
24402011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2441
2442 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2443 to compare Lisp_Objects.
2444 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2445 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2446 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2447
52968808
AS
24482011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2449
0a6a104b
AS
2450 * lread.c (read_integer): Unread even EOF character.
2451 (read1): Likewise. Properly record start position of symbol.
2452
52968808
AS
2453 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2454 symbol character follows.
2455
9e381cdd
PE
24562011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2457
2458 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2459 This works around a problem with the previous change to Fcopy_file.
2460 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2461 and without this change, GCC might complain about discarding
2462 fchown's return value.
2463
b5641435
JB
24642011-07-16 Juanma Barranquero <lekktu@gmail.com>
2465
2466 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2467
a8031457
PE
24682011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2469
2470 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2471
dd889327
LMI
24722011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2473
750c33f7
LMI
2474 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2475 it's used from the C level.
2476
dd889327
LMI
2477 * process.c: Use the same condition for POLL_FOR_INPUT in both
2478 keyboard.c and process.c (bug#1858).
2479
87e86684
LM
24802011-07-09 Lawrence Mitchell <wence@gmx.li>
2481
2482 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2483 (Fgnutls_boot): Use it.
2484
64348f40
AS
24852011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2486
2487 * doc.c (Fsubstitute_command_keys): Revert last change.
2488
1d698799
LMI
24892011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2490
f863868c
LMI
2491 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2492 quotes the next character, and doesn't affect other longer
2493 sequences (bug#8935).
2494
1d698799
LMI
2495 * lread.c (syms_of_lread): Clarify that is isn't only
2496 `eval-buffer' and `eval-defun' that's affected by
2497 `lexical-binding' (bug#8460).
2498
aa4b6df6
EZ
24992011-07-15 Eli Zaretskii <eliz@gnu.org>
2500
2501 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2502 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2503
5d856da6
PE
25042011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2505
ad6042bb
PE
2506 Fix minor problems found by static checking.
2507 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2508 (elsz): Now a signed constant, not a size_t var. We prefer signed
2509 types to unsigned, to avoid integer comparison confusion. Without
2510 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2511 "cannot optimize loop, the loop counter may overflow", a symptom
2512 of the confusion.
f00bbb22 2513 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2514 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2515
6468f31c
LMI
25162011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2517
49080b10
LMI
2518 * search.c (Fre_search_backward): Mention `case-fold-search' in
2519 all the re_search_* functions (bug#8138).
2520
6468f31c
LMI
2521 * keyboard.c (Fopen_dribble_file): Document when the file is
2522 closed (bug#8056).
2523
c965adc5
EZ
25242011-07-14 Eli Zaretskii <eliz@gnu.org>
2525
df9733bf
EZ
2526 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2527 bidi_cache_idx.
2528
0bb23927
EZ
2529 Support bidi reordering of display and overlay strings.
2530 * xdisp.c (compute_display_string_pos)
2531 (compute_display_string_end): Accept additional argument STRING.
2532 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2533 (reseat_to_string): Initialize bidi_it->string.s and
2534 bidi_it->string.schars.
2535 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2536 NULL (avoids a crash in bidi_paragraph_init).
2537 Initialize itb.string.lstring.
0bb23927
EZ
2538 (init_iterator): Call bidi_init_it only of a valid
2539 buffer position was specified. Initialize paragraph_embedding to
2540 L2R.
2541 (reseat_to_string): Initialize the bidi iterator.
2542 (display_string): If we need to ignore text properties of
2543 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2544 original value of -1 will not work with bidi.)
2545 (compute_display_string_pos): First arg is now struct
2546 `text_pos *'; all callers changed. Support display properties on
2547 Lisp strings.
2548 (compute_display_string_end): Support display properties on Lisp
2549 strings.
2550 (init_iterator, reseat_1, reseat_to_string): Initialize the
2551 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2552 when iterating on a string not from display properties).
640c8776
SM
2553 (compute_display_string_pos, compute_display_string_end):
2554 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2555 arrow keys.
2556 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2557 base_level_stop; instead, set base_level_stop to BEGV.
2558 Fixes crashes in vertical-motion.
0bb23927
EZ
2559 (next_element_from_buffer): Improve commentary for when
2560 the iterator is before prev_stop.
2561 (init_iterator): Initialize bidi_p from the default value of
2562 bidi-display-reordering, not from buffer-local value. Use the
2563 buffer-local value only if initializing for buffer iteration.
2564 (handle_invisible_prop): Support invisible properties on strings
2565 that are being bidi-reordered.
2566 (set_iterator_to_next): Support bidi reordering of C strings and
2567 Lisp strings.
2568 (next_element_from_string): Support bidi reordering of Lisp
2569 strings.
2570 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2571 (display_string): Support display of R2L glyph rows.
2572 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2573 (init_iterator): Don't initialize it->bidi_p for strings
2574 here.
2575 (reseat_to_string): Initialize it->bidi_p for strings here.
2576 (next_element_from_string, next_element_from_c_string)
2577 (next_element_from_buffer): Add xassert's for correspondence
2578 between IT's object being iterated and it->bidi_it.string
2579 structure.
2580 (face_before_or_after_it_pos): Support bidi iteration.
2581 (next_element_from_c_string): Handle the case of the first string
2582 character that is not the first one in the visual order.
2583 (get_visually_first_element): New function, refactored from common
2584 parts of next_element_from_buffer, next_element_from_string, and
2585 next_element_from_c_string.
2586 (tool_bar_lines_needed, redisplay_tool_bar)
2587 (display_menu_bar): Force left-to-right direction. Add a FIXME
2588 comment for making that be controlled by a user option.
2589 (push_it, pop_it): Save and restore the state of the
2590 bidi iterator. Save and restore the bidi_p flag.
2591 (pop_it): Iterate out of display property for string iteration as
2592 well.
2593 (iterate_out_of_display_property): Support iteration over strings.
2594 (handle_single_display_spec): Set up it->bidi_it for iteration
2595 over a display string, and call bidi_init_it.
2596 (handle_single_display_spec, next_overlay_string)
2597 (get_overlay_strings_1, push_display_prop): Set up the bidi
2598 iterator for displaying display or overlay strings.
2599 (forward_to_next_line_start): Don't use the shortcut if
2600 bidi-iterating.
2601 (back_to_previous_visible_line_start): If handle_display_prop
2602 pushed the iterator stack, restore the internal state of the bidi
2603 iterator by calling bidi_pop_it same number of times.
2604 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2605 and we are bidi-iterating, don't decrement the iterator position;
2606 instead, set the first_elt flag in the bidi iterator, to produce
2607 the same effect.
2608 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2609 (push_display_prop): xassert that we are iterating a buffer.
2610 (push_it, pop_it): Save and restore paragraph_embedding member.
2611 (handle_single_display_spec, next_overlay_string)
2612 (get_overlay_strings_1, reseat_1, reseat_to_string)
2613 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2614 correctly. Don't assume unibyte strings are not bidi-reordered.
2615 (compute_display_string_pos)
2616 (compute_display_string_end): Fix handling the case of C string.
2617 (push_it, pop_it): Save and restore from_disp_prop_p.
2618 (handle_single_display_spec, push_display_prop): Set the
2619 from_disp_prop_p flag.
2620 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2621 (pop_it): Call iterate_out_of_display_property only if we are
2622 popping after iteration over a string that came from a display
2623 property. Fix a typo in popping stretch info. Add an assertion
2624 for verifying that the iterator position is in sync with the bidi
2625 iterator.
2626 (handle_single_display_spec, get_overlay_strings_1)
2627 (push_display_prop): Fix initialization of paragraph direction for
2628 string when that of the parent object is not yet determined.
2629 (reseat_1): Call bidi_init_it to resync the bidi
2630 iterator with IT's position. (Bug#7616)
2631 (find_row_edges): If ROW->start.pos gives position
2632 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2633 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2634 Reset the from_disp_prop_p flag.
2635 (SAVE_IT, RESTORE_IT): New macros.
2636 (pos_visible_p, face_before_or_after_it_pos)
2637 (back_to_previous_visible_line_start)
2638 (move_it_in_display_line_to, move_it_in_display_line)
2639 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2640 (try_scrolling, redisplay_window, display_line): Use them when
2641 saving a temporary copy of the iterator and restoring it back.
2642 (back_to_previous_visible_line_start, reseat_1)
2643 (init_iterator): Empty the bidi cache "stack".
2644 (move_it_in_display_line_to): If iterator ended up at
2645 EOL, but we never saw any buffer positions smaller than
2646 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2647 motion in bidi-reordered lines.
2648 (move_it_in_display_line_to): Record prev_method and prev_pos
2649 immediately before the call to set_iterator_to_next. Fixes cursor
2650 motion in bidi-reordered lines with stretch glyphs and strings
2651 displayed in margins. (Bug#8133) (Bug#8867)
2652 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2653 TO_CHARPOS.
640c8776
SM
2654 (pos_visible_p): Support positions in bidi-reordered lines.
2655 Save and restore bidi cache.
0bb23927
EZ
2656
2657 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2658 (bidi_paragraph_info): Delete unused struct.
2659 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2660 (bidi_cache_start): New variable.
2661 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2662 to zero.
2663 (bidi_cache_fetch_state, bidi_cache_search)
2664 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2665 (bidi_cache_find, bidi_peek_at_next_level)
2666 (bidi_level_of_next_char, bidi_find_other_level_edge)
2667 (bidi_move_to_visually_next): Compare cache index with
2668 bidi_cache_start rather than with zero.
2669 (bidi_fetch_char): Accept new argument STRING; all callers
2670 changed. Support iteration over a string. Support strings with
2671 display properties. Support unibyte strings. Fix the type of
2672 `len' according to what STRING_CHAR_AND_LENGTH expects.
2673 (bidi_paragraph_init, bidi_resolve_explicit_1)
2674 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2675 (bidi_level_of_next_char, bidi_move_to_visually_next):
2676 Support iteration over a string.
0bb23927
EZ
2677 (bidi_set_sor_type, bidi_resolve_explicit_1)
2678 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2679 can now be zero (for strings); special values 0 and -1 were
2680 changed to -1 and -2, respectively.
2681 (bidi_char_at_pos): New function.
2682 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2683 Call it instead of FETCH_MULTIBYTE_CHAR.
2684 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2685 initialized to valid values.
2686 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2687 values.
2688 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2689 the test for valid cached positions. Fix the logic for looking up
2690 the sentinel state in the cache. GCPRO the Lisp string we are
2691 iterating.
2692 (bidi_push_it, bidi_pop_it): New functions.
2693 (bidi_initialize): Initialize the bidi cache start stack pointer.
2694 (bidi_cache_ensure_space): New function, refactored from part of
2695 bidi_cache_iterator_state. Don't assume the required size is just
2696 one BIDI_CACHE_CHUNK away.
2697 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2698 (bidi_count_bytes, bidi_char_at_pos): New functions.
2699 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2700 always valid if bidi_cache_idx is valid.
2701 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2702 is valid if it's going to be used.
2703 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2704 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2705 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2706 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2707 (bidi_find_other_level_edge, bidi_cache_start_stack):
2708 All variables related to cache indices are now EMACS_INT.
c965adc5 2709
0bb23927
EZ
2710 * dispextern.h (struct bidi_string_data): New structure.
2711 (struct bidi_it): New member `string'. Make flag members be 1-bit
2712 fields, and put them last in the struct.
640c8776
SM
2713 (compute_display_string_pos, compute_display_string_end):
2714 Update prototypes.
0bb23927
EZ
2715 (bidi_push_it, bidi_pop_it): Add prototypes.
2716 (struct iterator_stack_entry): New members bidi_p,
2717 paragraph_embedding, and from_disp_prop_p.
2718 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2719 (bidi_shelve_cache, bidi_unshelve_cache):
2720 Declare prototypes.
0bb23927
EZ
2721
2722 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2723 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2724 and vector-like objects.
2725
2726 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2727 cache around display iteration.
2728
2729 * window.c (Fwindow_end, window_scroll_pixel_based)
2730 (displayed_window_lines, Frecenter): Save and restore the bidi
2731 cache around display iteration.
2732
3bbd2265
LMI
27332011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2734
2735 * editfns.c (Fdelete_region): Clarify the use of the named
2736 parameters (bug#6788).
2737
adc47434
MR
27382011-07-14 Martin Rudalics <rudalics@gmx.at>
2739
2740 * indent.c (Fvertical_motion): Set and restore w->pointm when
2741 saving and restoring the window's buffer (Bug#9006).
2742
837c31f8
LMI
27432011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2744
2745 * editfns.c (Fstring_to_char): Clarify just what is returned
2746 (bug#6576). Text by Eli Zaretskii.
2747
ac389d0c
JB
27482011-07-13 Juanma Barranquero <lekktu@gmail.com>
2749
2750 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2751
0be0ce47
EZ
27522011-07-13 Eli Zaretskii <eliz@gnu.org>
2753
2754 * buffer.c (mmap_find): Fix a typo.
2755
cd18e7e3
JB
27562011-07-13 Johan Bockgård <bojohan@gnu.org>
2757
2758 Fix execution of x selection hooks.
2759 * xselect.c (Qx_lost_selection_functions)
2760 (Qx_sent_selection_functions): New vars.
2761 (syms_of_xselect): DEFSYM them.
2762 (x_handle_selection_request): Pass Qx_sent_selection_functions
2763 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2764 (x_handle_selection_clear,x_clear_frame_selections):
2765 Pass Qx_lost_selection_functions rather than
2766 Vx_lost_selection_functions to Frun_hook_with_args.
2767
47ea7f44
PE
27682011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2769
ac389d0c 2770 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2771 The old code sometimes used this field without initializing it.
2772
47ea7f44
PE
2773 * alloc.c (gc_sweep): Don't read past end of array.
2774 In theory, the old code could also have corrupted Emacs internals,
2775 though it'd be very unlikely.
2776
bc985c87
AS
27772011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2778
2779 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2780 argument. (Bug#4026)
bc985c87 2781
0cf34688
LMI
27822011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2783
b3dadd76
LMI
2784 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2785 key" (bug#4257).
2786
0cf34688
LMI
2787 * window.c (Fset_window_start): Doc fix (bug#4199).
2788 (Fset_window_hscroll): Ditto.
2789
270768cd
PE
27902011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2791
077e3dda 2792 Fix minor new problems caught by GCC 4.6.1.
270768cd 2793 * term.c (init_tty): Remove unused local.
490011a6 2794 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2795 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2796 not used otherwise.
270768cd 2797
b1f58454
CY
27982011-07-12 Chong Yidong <cyd@stupidchicken.com>
2799
2800 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2801
22b9578d
LMI
28022011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2803
6e70ab07
LMI
2804 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2805 are the mini-buffer and the echo area (bug#3320).
2806
22b9578d
LMI
2807 * term.c (init_tty): Remove support for supdup, c10 and perq
2808 terminals, which are no longer supported (bug#1482).
2809
8974cc9f
JB
28102011-07-10 Johan Bockgård <bojohan@gnu.org>
2811
2812 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2813
a560d974
JD
28142011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2815
2816 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2817 for non-popups (Bug#3642).
2818
1dae0f0a
AS
28192011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2820
268c2c36 2821 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2822 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2823 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2824 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2825 * data.c (fmod): Likewise.
2826 * dispnew.c (swap_glyphs_in_rows): Likewise.
2827 * emacs.c (memory_warning_signal): Likewise.
2828 * floatfns.c (float_error): Likewise.
2829 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2830 (otf_open, font_otf_capability, generate_otf_features)
2831 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2832 Likewise.
2833 * image.c (pbm_read_file): Likewise.
2834 * indent.c (string_display_width): Likewise.
2835 * intervals.c (check_for_interval, search_for_interval)
2836 (inc_interval_count, count_intervals, root_interval)
2837 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2838 * lread.c (defalias): Likewise.
268c2c36 2839 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2840 * regex.c (set_image_of_range_1, set_image_of_range)
2841 (regex_grow_registers): Likewise.
2842 * sysdep.c (strerror): Likewise.
2843 * termcap.c (valid_filename_p, tprint, main): Likewise.
2844 * tparam.c (main): Likewise.
2845 * unexhp9k800.c (run_time_remap, save_data_space)
2846 (update_file_ptrs, read_header, write_header, calculate_checksum)
2847 (copy_file, copy_rest, display_header): Likewise.
2848 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2849 Likewise.
2850 * xdisp.c (check_it): Likewise.
2851 * xfaces.c (register_color, unregister_color, unregister_colors):
2852 Likewise.
2853 * xfns.c (print_fontset_result): Likewise.
2854 * xrdb.c (member, fatal, main): Likewise.
2855
99033785
PE
28562011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2857
2858 Fix minor problems found by static checking (Bug#9031).
2859 * chartab.c (char_table_set_range, map_sub_char_table):
2860 Remove unused locals.
2861 (uniprop_table): Now static.
2862 * composite.c (_work_char): Remove unused static var.
2863
9cb2ac56
JB
28642011-07-09 Juanma Barranquero <lekktu@gmail.com>
2865
2866 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2867
f25661f0
JD
28682011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2869
2870 * gtkutil.c (qttip_cb): Remove code without function.
2871
8278c4fe
EZ
28722011-07-09 Eli Zaretskii <eliz@gnu.org>
2873
2874 * w32.c (pthread_sigmask): New stub.
2875
1692ae2d 28762011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2877
8a6ebd58 2878 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2879 sigprocmask is portable only for single-threaded applications, and
2880 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2881 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2882 (LIBES): Use it.
2883 * callproc.c (Fcall_process):
2884 * process.c (create_process):
2885 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2886 Use pthread_sigmask, not sigprocmask.
123403e4 2887
1b854618
JD
28882011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2889
2890 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2891 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2892 wrong (Bug#8591).
2893
3fe4b549
JD
28942011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2895
0ce7e563
JD
2896 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2897 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2898 (xg_hide_tooltip): Fix comment.
2899
3fe4b549
JD
2900 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2901 in registerServicesMenuSendTypes.
2902 (validRequestorForSendType): Don't check ns_return_types.
2903
2904 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2905 ns_return_type.
2906
5df75e47
JR
29072011-07-08 Jason Rumney <jasonr@gnu.org>
2908
22610910
JR
2909 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
2910 SH_SHOW for hidden windows (Bug#5482).
2911
5df75e47
JR
2912 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2913 frame struct members of non-existent frames (Bug#6284).
2914
699c10bd
JD
29152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2916
4393663b
JD
2917 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2918 variable firstTime not needed on OSX >= 10.6.
2919 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2920 >= 10.5. Use setKnobProportion, setDoubleValue.
2921
2922 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2923 (MAC_OS_X_VERSION_10_5): Define if not defined.
2924 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2925 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2926 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2927
2928 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2929 cString and lossyCString on OSX >= 10.4
2930
2931 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2932 sizeToFit on OSX >= 10.2.
2933
2934 * nsimage.m (allocInitFromFile): Don't use deprecated method
2935 bestRepresentationForDevice on OSX >= 10.6.
2936
2937 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2938 to avoid warning.
2939
2940 * emacs.c: Declare unexec_init_emacs_zone.
2941
a63e0781
JD
2942 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2943
699c10bd
JD
2944 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2945
2946 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2947 on svcsMenu (Bug#8842).
2948
2949 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2950 ns_return_types.
2951 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2952
2953 * nsterm.m (QUTF8_STRING): Declare.
2954 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2955 (validRequestorForSendType): Return type is (id).
2956 Change indexOfObjectIdenticalTo to indexOfObject.
2957 Check if we have local selection before returning self (Bug#8842).
2958 (writeSelectionToPasteboard): Put local selection into paste board
2959 if we have a local selection (Bug#8842).
2960 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2961
2962 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2963 (ns_get_local_selection): Declare.
2964
54e10184
LMI
29652011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2966
9888ff71
LMI
2967 * keymap.c (describe_map_tree): Don't insert a double newline at
2968 the end of the buffer (bug#1169) and return whether we inserted
2969 something.
2970
54e10184
LMI
2971 * callint.c (Fcall_interactively): Change "reading args" to
2972 "providing args" to try to clarify what it does (bug#1010).
2973
15fa4783
KH
29742011-07-07 Kenichi Handa <handa@m17n.org>
2975
2976 * composite.c (composition_compute_stop_pos): Ignore a static
2977 composition starting before CHARPOS (Bug#8915).
2978
2979 * xdisp.c (handle_composition_prop): Likewise.
2980
a8815b00
EZ
29812011-07-07 Eli Zaretskii <eliz@gnu.org>
2982
2983 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2984 (Bug#9015)
2985
ef7b981d 29862011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2987
2988 * character.h (unicode_category_t): New enum type.
2989
2990 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2991 (Qchar_code_property_table): New variable.
2992 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2993 (UNIPROP_COMPRESSED_FORM_P): New macros.
2994 (char_table_ascii): Uncompress the compressed values.
2995 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2996 Uncompress the compressed values.
ac389d0c 2997 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2998 (char_table_ref_and_range): Uncompress the compressed values.
2999 (sub_char_table_set): New arg is_uniprop. Callers changed.
3000 Uncompress the compressed values.
3001 (sub_char_table_set_range): Args changed. Callers changed.
3002 (char_table_set_range): Adjuted for the above change.
3003 (map_sub_char_table): Delete args default_val and parent. Add arg
3004 top. Give decoded values to a Lisp function.
640c8776 3005 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3006 values to a Lisp function. Gcpro more variables.
3007 (uniprop_table_uncompress)
3008 (uniprop_decode_value_run_length): New functions.
3009 (uniprop_decoder, uniprop_decoder_count): New variables.
3010 (uniprop_get_decoder, uniprop_encode_value_character)
3011 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3012 New functions.
3013 (uniprop_encoder, uniprop_encoder_count): New variables.
3014 (uniprop_get_encoder, uniprop_table)
3015 (Funicode_property_table_internal, Fget_unicode_property_internal)
3016 (Fput_unicode_property_internal): New functions.
3017 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3018 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3019 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3020 char-code-property-alist.
3021
640c8776 3022 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3023 Vunicode_category_table.
3024
640c8776 3025 * font.c (font_range): Adjust for the change of
c805dec0
KH
3026 Vunicode_category_table.
3027
76b397fb
DN
30282011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3029
3030 * m/iris4d.h: Remove file, move contents ...
3031 * s/irix6-5.h: ... here.
3032
22b4128e
PE
30332011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3034
3035 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3036 * alloc.c (mark_buffer):
3037 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3038 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3039 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3040 This isn't true in general, and it's particularly not true
3041 if Emacs is configured with --with-wide-int.
3042 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3043 New macros, used in the buffer.c change.
3044
869795d6
JD
30452011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3046
3047 * xsettings.c: Use both GConf and GSettings if both are available.
3048 (store_config_changed_event): Add comment.
3049 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3050 (store_tool_bar_style_changed): New functions.
5e617bc2 3051 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3052 (struct xsettings): Move font inside HAVE_XFT.
3053 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3054 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3055 Move inside HAVE_XFT.
640c8776 3056 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3057 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3058 also.
3059 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3060 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3061 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3062 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3063 (parse_settings): Move check for font inside HAVE_XFT.
3064 (read_settings, apply_xft_settings): Add comment.
3065 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3066 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3067 call store_font_name_changed.
3068 (xft_settings_event): Add comment.
3069 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3070 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3071 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3072 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3073 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3074 (xsettings_get_system_font, xsettings_get_system_normal_font):
3075 Add comment.
869795d6 3076
d8ed26bd
PE
30772011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3078
3079 Random fixes. E.g., (random) never returned negative values.
3080 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3081 subseconds part to the entropy, as that's a bit more random.
3082 Prefer signed to unsigned, since the signedness doesn't matter and
3083 in general we prefer signed. When given a limit, use a
3084 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3085 latter isn't right if USE_2_TAGS_FOR_INTS.
3086 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3087 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3088
cabf1cac
SM
30892011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3090
3091 * textprop.c (text_property_stickiness):
3092 Obey Vtext_property_default_nonsticky.
3093 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3094 * w32fns.c (syms_of_w32fns):
3095 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3096
6e9b2be9
PE
30972011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3098
3099 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3100 This is more efficient than Ffile_directory_p and avoids a minor race.
3101
90186c68
LMI
31022011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3103
7c301272
LMI
3104 * buffer.c (Foverlay_put): Say what the return value is
3105 (bug#7835).
3106
c4f2d8d4
LMI
3107 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3108 is a directory before asking whether to use the file name
3109 (bug#7564).
ad637907
LMI
3110 (barf_or_query_if_file_exists): Make the "File is a directory"
3111 error be more correct.
c4f2d8d4 3112
90186c68
LMI
3113 * fns.c (Frequire): Remove the mention of the .gz files, since
3114 that's installation-specific, but keep the mention of
3115 `get-load-suffixes'.
3116
da64016e
PE
31172011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3118
3119 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3120 Report string overflow if the output is too long.
3121
7d47b580
JB
31222011-07-04 Juanma Barranquero <lekktu@gmail.com>
3123
a555cb87
JB
3124 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3125 (syms_of_gnutls): Remove duplicate DEFSYM for
3126 Qgnutls_bootprop_verify_hostname_error, an error for
3127 Qgnutls_bootprop_verify_error (which is no longer used).
3128
7d47b580
JB
3129 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3130 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3131 Also (re)move comments that are misplaced or no longer relevant.
3132
1e49bfab
LMI
31332011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3134
3135 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3136
1485f4c0
CY
31372011-07-03 Chong Yidong <cyd@stupidchicken.com>
3138
3139 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3140 and background color parameters if they have been changed.
3141
a9ab721e
LMI
31422011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3143
3144 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3145
cf7cff57
PE
31462011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3147
2e13213d
PE
3148 * xsettings.c (SYSTEM_FONT): Define only when used.
3149 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3150
cf7cff57
PE
3151 * keymap.c (access_keymap_1): Now static.
3152
7a8e04f7
CY
31532011-07-02 Chong Yidong <cyd@stupidchicken.com>
3154
3155 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3156 leave any prefix arg for the up event (Bug#1586).
3157
61352f62
LMI
31582011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3159
69bb1ef7
LMI
3160 * lread.c (syms_of_lread): Mention single symbols defined by
3161 `defvar' or `defconst' (bug#7154).
3162
61352f62 3163 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3164 (Frequire): Mention get-load-suffixes.
61352f62 3165
28545e04
MR
31662011-07-02 Martin Rudalics <rudalics@gmx.at>
3167
3168 * window.h (window): Remove clone_number slot.
3169 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3170 Remove.
3171 (make_parent_window, make_window, saved_window)
3172 (Fset_window_configuration, save_window_save): Don't deal with
3173 clone numbers.
3174 * buffer.c (Qclone_number): Remove declaration.
3175 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3176
3349e122
SM
31772011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3178
3179 Add multiple inheritance to keymaps.
3180 * keymap.c (Fmake_composed_keymap): New function.
3181 (Fset_keymap_parent): Simplify.
3182 (fix_submap_inheritance): Remove.
3183 (access_keymap_1): New function extracted from access_keymap to handle
3184 embedded parents and handle lists of maps.
3185 (access_keymap): Use it.
3186 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3187 (Fcopy_keymap): Handle embedded parents.
3188 (Fcommand_remapping, define_as_prefix): Simplify.
3189 (Fkey_binding): Simplify.
3190 (syms_of_keymap): Move minibuffer-local-completion-map,
3191 minibuffer-local-filename-completion-map,
3192 minibuffer-local-must-match-map, and
3193 minibuffer-local-filename-must-match-map to Elisp.
3194 (syms_of_keymap): Defsubr make-composed-keymap.
3195 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3196 (parse_menu_item): Trivial simplification.
3197
3279eb87
GM
31982011-07-01 Glenn Morris <rgm@gnu.org>
3199
3200 * Makefile.in (SETTINGS_LIBS): Fix typo.
3201
4550efdf
KI
32022011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3203
3204 * coding.c (Fencode_coding_string): Record the last coding system
3205 used, as the function doc string says (bug#8738).
3206
0949d2b6
JD
32072011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3208
3209 * xsettings.c (store_monospaced_changed): Take new font as arg and
3210 check for change against current_mono_font.
3211 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3212 (emacs_settings_constructor, emacs_settings_get_property)
3213 (emacs_settings_set_property, emacs_settings_class_init)
3214 (emacs_settings_init, gsettings_obj): Remove.
3215 (something_changedCB): New function for HAVE_GSETTINGS.
3216 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3217 with value as argument.
3218 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3219 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3220 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3221 "changed".
3222
3223 * xgselect.c: Add defined (HAVE_GSETTINGS).
3224 (xgselect_initialize): Ditto.
3225
3226 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3227 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3228 xg_select.
3229
bbc6b304
PE
32302011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3231
3232 * eval.c (struct backtrace): Simplify and port the data structure.
3233 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3234 signed bit field, as this assumption is not portable and it makes
3235 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3236 "char debug_on_exit : 1" as this is not portable either; instead,
3237 use the portable "unsigned int debug_on_exit : 1". Remove unused
3238 member evalargs. Remove obsolete comments about cc bombing out.
3239
9851bfc5
JD
32402011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3241
51bb811f 3242 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3243 Let HAVE_GSETTINGS override HAVE_GCONF.
3244 (store_monospaced_changed): New function.
3245 (EMACS_SETTINGS): A new type derived from GObject to handle
3246 GSettings notifications.
3247 (emacs_settings_constructor, emacs_settings_get_property)
3248 (emacs_settings_set_property, emacs_settings_class_init):
3249 New functions.
3250 (gsettings_client, gsettings_obj): New variables.
3251 (GSETTINGS_SCHEMA): New define.
3252 (something_changedCB): Call store_monospaced_changed.
3253 (init_gsettings): New function.
3254 (xsettings_initialize): Call init_gsettings.
3255 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3256 to NULL.
3257
640c8776 3258 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3259 GCONF_CFLAGS/LIBS.
3260
5386012d
MR
32612011-06-29 Martin Rudalics <rudalics@gmx.at>
3262
3263 * window.c (resize_root_window, grow_mini_window)
3264 (shrink_mini_window): Rename Qresize_root_window to
3265 Qwindow_resize_root_window and Qresize_root_window_vertically to
3266 Qwindow_resize_root_window_vertically.
3267
f13e0b08
PE
32682011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3269
3270 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3271
94515237
JB
32722011-06-27 Juanma Barranquero <lekktu@gmail.com>
3273
3274 * makefile.w32-in: Redesign dependencies so they reflect more
3275 clearly which files are directly included by each source file,
3276 and not through other includes.
3277
e43b6e43
MR
32782011-06-27 Martin Rudalics <rudalics@gmx.at>
3279
3280 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3281 (sort_overlays, overlay_strings): When an overlay's clone number
3282 matches the window's clone number process the overlay even if
3283 the overlay's window property doesn't match the current window.
3284
d68443dc
MR
3285 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3286 (Fwindow_hchild): Rename to Fwindow_left_child.
3287 (Fwindow_next): Rename to Fwindow_next_sibling.
3288 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3289 (resize_window_check): Rename to window_resize_check.
3290 (resize_window_apply): Rename to window_resize_apply.
3291 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3292 (Fdelete_other_windows_internal, resize_frame_windows)
3293 (Fsplit_window_internal, Fdelete_window_internal)
3294 (grow_mini_window, shrink_mini_window)
3295 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3296
c7e73be5
JD
32972011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3298
3299 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3300 (emacs_fixed_set_min_size): Remove.
3301 (emacs_fixed_new): Take frame as argument.
3302
3303 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3304 (_EmacsFixedPrivate): Remove minwidth/height.
3305 Add struct frame *f.
3306 (emacs_fixed_init): Initialize priv->f.
3307 (get_parent_class, emacs_fixed_set_min_size): Remove.
3308 (emacs_fixed_new): Set priv->f to argument.
3309 (emacs_fixed_get_preferred_width)
3310 (emacs_fixed_get_preferred_height): Use min_width/height from
3311 frames size_hint to set minimum and natural (Bug#8919).
3312 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3313 and use min_width/height from frames size_hint to set
3314 min_width/height (Bug#8919).
3315
3316 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3317 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3318 Fix indentation.
c7e73be5 3319
cf99dcf8
EZ
33202011-06-26 Eli Zaretskii <eliz@gnu.org>
3321
3322 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3323 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3324 called at ZV.
3325
029529ac
CY
33262011-06-26 Chong Yidong <cyd@stupidchicken.com>
3327
3328 * process.c (wait_reading_process_output): Bypass select if
3329 waiting for a cell while ignoring keyboard input, and input is
3330 pending. Suggested by Jan Djärv (Bug#8869).
3331
7a7ef429
PE
33322011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3333
3334 Use gnulib's dup2 module instead of rolling our own.
3335 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3336
11fdef7d 33372011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3338
3339 * dispnew.c (scrolling_window): Before scrolling, turn off a
3340 mouse-highlight in the window being scrolled.
3341
cd3520a4
JB
33422011-06-24 Juanma Barranquero <lekktu@gmail.com>
3343
3344 Move DEFSYM to lisp.h and use everywhere.
3345
3346 * character.h (DEFSYM): Move declaration...
3347 * lisp.h (DEFSYM): ...here.
3348
3349 * gnutls.c:
3350 * minibuf.c:
3351 * w32menu.c:
3352 * w32proc.c:
3353 * w32select.c: Don't include character.h.
3354
3355 * alloc.c (syms_of_alloc):
3356 * buffer.c (syms_of_buffer):
3357 * bytecode.c (syms_of_bytecode):
3358 * callint.c (syms_of_callint):
3359 * casefiddle.c (syms_of_casefiddle):
3360 * casetab.c (init_casetab_once):
3361 * category.c (init_category_once, syms_of_category):
3362 * ccl.c (syms_of_ccl):
3363 * cmds.c (syms_of_cmds):
3364 * composite.c (syms_of_composite):
3365 * dbusbind.c (syms_of_dbusbind):
3366 * dired.c (syms_of_dired):
3367 * dispnew.c (syms_of_display):
3368 * doc.c (syms_of_doc):
3369 * editfns.c (syms_of_editfns):
3370 * emacs.c (syms_of_emacs):
3371 * eval.c (syms_of_eval):
3372 * fileio.c (syms_of_fileio):
3373 * fns.c (syms_of_fns):
3374 * frame.c (syms_of_frame):
3375 * fringe.c (syms_of_fringe):
3376 * insdel.c (syms_of_insdel):
3377 * keymap.c (syms_of_keymap):
3378 * lread.c (init_obarray, syms_of_lread):
3379 * macros.c (syms_of_macros):
3380 * msdos.c (syms_of_msdos):
3381 * print.c (syms_of_print):
3382 * process.c (syms_of_process):
3383 * search.c (syms_of_search):
3384 * sound.c (syms_of_sound):
3385 * syntax.c (init_syntax_once, syms_of_syntax):
3386 * terminal.c (syms_of_terminal):
3387 * textprop.c (syms_of_textprop):
3388 * undo.c (syms_of_undo):
3389 * w32.c (globals_of_w32):
3390 * window.c (syms_of_window):
3391 * xdisp.c (syms_of_xdisp):
3392 * xfaces.c (syms_of_xfaces):
3393 * xfns.c (syms_of_xfns):
3394 * xmenu.c (syms_of_xmenu):
3395 * xsettings.c (syms_of_xsettings):
3396 * xterm.c (syms_of_xterm): Use DEFSYM.
3397
4228cf16
TZ
33982011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3399
cd3520a4 3400 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3401
7fcccf1e
PE
34022011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3403
7efb4e0e
PE
3404 Integer and buffer overflow fixes (Bug#8873).
3405
ff5844ad
PE
3406 * print.c (printchar, strout): Check for string overflow.
3407 (PRINTPREPARE, printchar, strout):
3408 Don't set size unless allocation succeeds.
3409
90532f02
PE
3410 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3411 for sizes. Check for string overflow more accurately.
3412 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3413
6d84508d
PE
3414 * macros.c: Integer and buffer overflow fixes.
3415 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3416 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3417 Use ptrdiff_t, not int, for sizes.
3418 Don't increment bufsize until after realloc succeeds.
3419 Check for size-calculation overflow.
3420 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3421
437b2cb4
PE
3422 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3423
8b9ac8b4
PE
3424 * lread.c: Integer overflow fixes.
3425 (read_integer): Radix is now EMACS_INT, not int,
3426 to improve quality of diagnostics for out-of-range radices.
3427 Calculate buffer size correctly for out-of-range radices.
3428 (read1): Check for integer overflow in radices, and in
3429 read-circle numbers.
82cb60d3
PE
3430 (read_escape): Avoid int overflow.
3431 (Fload, openp, read_buffer_size, read1)
3432 (substitute_object_recurse, read_vector, read_list, map_obarray):
3433 Use ptrdiff_t, not int, for sizes.
3434 (read1): Use EMACS_INT, not int, for sizes.
20270765 3435 Check for size overflow.
8b9ac8b4 3436
7fcccf1e
PE
3437 * image.c (cache_image): Check for size arithmetic overflow.
3438
bfbbd7e7
PE
3439 * lread.c: Integer overflow issues.
3440 (saved_doc_string_size, saved_doc_string_length)
3441 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3442 Now ptrdiff_t, not int.
3443 (read1): Don't assume doc string length fits in int. Check for
3444 out-of-range doc string lengths.
3445 (read_list): Don't assume file position fits in int.
39019e54 3446 (read_escape): Check for hex character overflow.
bfbbd7e7 3447
4e323265
LL
34482011-06-22 Leo Liu <sdl.web@gmail.com>
3449
3450 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3451 Move to minibuffer.el.
3452
85fece3e
PE
34532011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3454
20b84ce9 3455 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3456 The following patches are for when GLYPH_DEBUG && !XASSERT.
3457 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3458 * dispnew.c (flush_stdout):
3459 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3460 Mark as externally visible.
3461 * dispnew.c (check_window_matrix_pointers): Now static.
3462 * dispnew.c (window_to_frame_vpos):
3463 * xfns.c (unwind_create_frame):
3464 * xterm.c (x_check_font): Remove unused local.
3465 * scroll.c (CHECK_BOUNDS):
3466 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3467 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3468 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3469 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3470 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3471 Now static.
3472 (debug_method_add): Use va_list and vsprintf rather than relying
3473 on undefined behavior with wrong number of arguments.
3474 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3475 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3476 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3477 since we're not interested in debugging glyphs with old libraries.
3478 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3479 GCC 4.6.0's static checking.
3480
0766b489
PE
34812011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3482
31fd4b32
PE
3483 Integer overflow and signedness fixes (Bug#8873).
3484 A few related buffer overrun fixes, too.
3485
b79e8648
PE
3486 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3487
0766b489
PE
3488 * dispextern.h (struct face.stipple):
3489 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3490 (x_bitmap_mask, x_allocate_bitmap_record)
3491 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3492 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3493 (x_create_bitmap_from_xpm_data):
3494 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3495 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3496 (.bitmaps_last):
3497 * xfaces.c (load_pixmap):
3498 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3499 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3500 (.bitmaps_last, struct x_output.icon_bitmap):
3501 Use ptrdiff_t, not int, for bitmap indexes.
3502 (x_allocate_bitmap_record): Check for size overflow.
3503 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3504
b081724f
PE
3505 Use ptrdiff_t, not int, for overlay counts.
3506 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3507 * editfns.c (overlays_around, get_pos_property):
3508 * textprop.c (get_char_property_and_overlay):
3509 * xdisp.c (next_overlay_change, note_mouse_highlight):
3510 * xfaces.c (face_at_buffer_position):
21514da7
PE
3511 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3512 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3513 (Fnext_overlay_change, Fprevious_overlay_change)
3514 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3515 Use ptrdiff_t, not int, for sizes.
21514da7 3516 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3517
3de73e5e
PE
3518 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3519
2606c57b
PE
3520 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3521 (x_session_initialize): Do not assume string length fits in int.
3522
aaafe47a
PE
3523 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3524 This is unlikely, but can occur if DPI is outlandish.
3525
2674ddc8 3526 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3527 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3528
28154962
PE
3529 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3530 * xrdb.c (magic_file_p, search_magic_path):
3531 Omit last arg SUFFIX; it was always 0. All callers changed.
3532 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3533
7de51af5
PE
3534 * xfont.c (xfont_match): Avoid need for strlen.
3535
25ed6cc3
PE
3536 * xfns.c: Don't assume strlen fits in int.
3537 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3538
4eab31dd
PE
3539 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3540 not unsigned long, as we prefer signed integers. All callers changed.
3541 Detect integer overflow in repeat count.
3542 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3543 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3544
171e2a58
PE
3545 * termcap.c: Don't assume sizes fit in int and never overflow.
3546 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3547 (gobble_line): Check for size-calculation overflow.
3548
ad39faca 3549 * minibuf.c (Fread_buffer):
6e5bb2dc 3550 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3551 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3552 Don't assume string length fits in int.
3553
52c61c22 3554 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3555 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3556
b5b8c9e5
PE
3557 * font.c: Don't assume string length fits in int.
3558 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3559 Use ptrdiff_t, not int.
ccd6111c
PE
3560 (font_intern_prop): Don't assume string length fits in int.
3561 Don't assume integer property fits in fixnum.
3562 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3563
882f0d81 3564 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3565 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3566 Reformulate so as not to need the command string.
3567 Invoke gzip -cd rather than gunzip, as it's more portable.
3568 (lock_info_type, lock_file_1, lock_file):
3569 Don't assume pid_t and time_t fit in unsigned long.
3570 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3571 (current_lock_owner): Prefer signed type for sizes.
3572 Use memcpy, not strncpy, where memcpy is what is really wanted.
3573 Don't assume (via atoi) that time_t and pid_t fit in int.
3574 Check for time_t and/or pid_t out of range, e.g., via a network share.
3575 Don't alloca where an auto var works fine.
3576
93f4cf88
PE
3577 * fileio.c: Fix some integer overflow issues.
3578 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3579 Don't assume string length fits in int.
3580 (directory_file_name): Don't assume string length fits in long.
3581 (make_temp_name): Don't assume pid fits in int, or that its print
3582 length is less than 20.
3583
f3e92b69
PE
3584 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3585
1bfdaf10
PE
3586 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3587
35016e9a
PE
3588 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3589
3d1e65a1
PE
3590 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3591 We prefer signed integers, even for size calculations.
3592
0b963a93
PE
3593 * emacs.c: Don't assume string length fits in 'int'.
3594 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3595 (main): Don't invoke strlen when not needed.
3596
573f4b54
PE
3597 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3598 (XD_DEBUG_MESSAGE): Don't waste a byte.
3599
989f33ba
PE
3600 * callproc.c (getenv_internal_1, getenv_internal)
3601 (Fgetenv_internal):
965d34eb
PE
3602 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3603
e4d29b33
PE
3604 * lread.c (invalid_syntax): Omit length argument.
3605 All uses changed. This doesn't fix a bug, but it simplifies the
3606 code away from its former Hollerith-constant appearance, and it's
3607 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3608 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3609
eb49b136
PE
3610 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3611 This didn't break anything, but it didn't help either.
3612 It's confusing to put a bogus integer in a place where the actual
3613 value does not matter.
9f62aeb1 3614 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3615 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3616
15375a22
PE
3617 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3618 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3619 implementation.
b61cc01c
PE
3620 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3621 We prefer signed types, and the value cannot exceed the EMACS_INT
3622 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3623 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3624 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3625 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3626
53b2623d
PE
3627 * indent.c (sane_tab_width): New function.
3628 (current_column, scan_for_column, Findent_to, position_indentation)
3629 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3630 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3631
51cab52b 3632 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3633
f2ed8a70
PE
3634 * lisp.h (lint_assume): New macro.
3635 * composite.c (composition_gstring_put_cache):
3636 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3637
abe80cc6
PE
3638 * editfns.c, insdel.c:
3639 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3640
b02c740e
PE
3641 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3642
ebc96716
PE
3643 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3644
b4e50fa0 3645 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3646 Use much-faster test for byte-length change.
311d5d7c 3647 Don't assume string byte-length fits in 'int'.
a4cf38e4 3648 Check that character arg fits in 'int'.
85461888 3649 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3650
c0c1ee9f
PE
3651 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3652
a498d7f4
PE
3653 * fns.c (concat): Catch string overflow earlier.
3654 Do not rely on integer wraparound.
3655
51cab52b
PE
3656 * dispextern.h (struct it.overlay_strings_charpos)
3657 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3658 * xdisp.c (forward_to_next_line_start)
3659 (back_to_previous_visible_line_start)
3660 (reseat_at_next_visible_line_start, next_element_from_buffer):
3661 Don't arbitrarily truncate the value of 'selective' to int.
3662
76031fad
PE
3663 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3664
5eb55db9
PE
3665 * composite.c: Don't truncate sizes to 'int'.
3666 (composition_gstring_p, composition_reseat_it)
3667 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3668 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3669 not EMACS_UINT, for indexes.
5eb55db9 3670
0703a717
PE
3671 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3672
d6202519
PE
3673 * buffer.c: Include <verify.h>.
3674 (struct sortvec.priority, struct sortstr.priority):
8961a454 3675 Now EMACS_INT, not int.
c20998a7 3676 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3677 (struct sortstr.size, record_overlay_string)
3678 (struct sortstrlist.size, struct sortlist.used):
3679 Don't truncate size to int.
3680 (record_overlay_string): Check for size-calculation overflow.
d6202519 3681 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3682
d5a19415
JM
36832011-06-22 Jim Meyering <meyering@redhat.com>
3684
029529ac 3685 Don't leak an XBM-image-sized buffer
d5a19415
JM
3686 * image.c (xbm_load): Free the image buffer after using it.
3687
a9041e6c
PE
36882011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3689
3690 Port to Sun C.
3691 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3692 that Sun C diagnosed.
3693 * fns.c (secure_hash): Fix pointer signedness issue.
3694 * intervals.c (static_offset_intervals): New function.
3695 (offset_intervals): Use it.
3696
7f3f739f
LL
36972011-06-21 Leo Liu <sdl.web@gmail.com>
3698
3699 * deps.mk (fns.o):
3700 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3701 sha512.h.
3702
3703 * fns.c (secure_hash): Rename from crypto_hash_function and change
3704 the first arg to accept symbols.
5b66d427 3705 (Fsecure_hash): New primitive.
7f3f739f
LL
3706 (syms_of_fns): New symbols.
3707
76147d94
DD
37082011-06-20 Deniz Dogan <deniz@dogan.se>
3709
3710 * process.c (Fset_process_buffer): Clarify return value in
3711 docstring.
3712
7d7d0045
CY
37132011-06-18 Chong Yidong <cyd@stupidchicken.com>
3714
3715 * dispnew.c (add_window_display_history): Use BVAR.
3716
3717 * xdisp.c (debug_method_add): Use BVAR.
3718 (check_window_end, dump_glyph_matrix, dump_glyph)
3719 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3720
3721 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3722 Likewise.
3723
3724 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3725 check till after the cache is created in init_frame_faces.
3726
ff2bc410
SM
37272011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3728
3729 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3730
28177add
PE
37312011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3732
dd3482fe
PE
3733 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3734 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3735 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3736
393d71f3 3737 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3738 * fileio.c (Finsert_file_contents):
3739 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3740 Remove the old (too-loose) buffer overflow checks.
3741 They weren't needed, since make_gap checks for buffer overflow.
3742 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3743 The old code merely checked for Emacs fixnum overflow, and relied
3744 on undefined (wraparound) behavior. The new code avoids undefined
3745 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3746
2e6813b0 3747 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3748 Tune. Don't use wider integers than needed. Don't use alloca.
3749 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3750
599a9e4f
PE
3751 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3752
99561444
PE
3753 * insdel.c, lisp.h (buffer_overflow): New function.
3754 (insert_from_buffer_1, replace_range, replace_range_2):
3755 * insdel.c (make_gap_larger):
3756 * editfns.c (Finsert_char):
3757 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3758
28177add
PE
3759 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3760
e69dafad
PE
37612011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3762
a7af7fde 3763 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3764
b1c46f02
PE
3765 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3766 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3767
e69dafad
PE
3768 * fileio.c: Don't assume EMACS_INT fits in off_t.
3769 (emacs_lseek): New static function.
3770 (Finsert_file_contents, Fwrite_region): Use it.
3771 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3772
566684ea
PE
3773 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3774
e6966cd6
PE
3775 * fns.c: Don't overflow int when computing a list length.
3776 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3777 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3778 truncation on 64-bit hosts. Check for QUIT every
3779 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3780 faster and is responsive enough.
3781 (Flength): Report an error instead of overflowing an integer.
3782 (Fsafe_length): Return a float if the value is not representable
3783 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3784 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3785 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3786
dd0b0efb
PE
3787 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3788 (header_size, word_size): New constants.
3789 (allocate_vectorlike): Don't check size overflow here.
3790 (allocate_vector): Check it here instead, since this is the only
3791 caller of allocate_vectorlike that could cause overflow.
3792 Check that the new vector's length is representable as a fixnum.
3793
86fe5cfe
PE
3794 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3795 The previous code was bogus. For example, next_almost_prime (32)
3796 returned 39, which is undesirable as it is a multiple of 3; and
3797 next_almost_prime (24) returned 25, which is a multiple of 5 so
3798 why was the code bothering to check for multiples of 7?
3799
80e88859
PE
3800 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3801
4a2f0ad6
PE
3802 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3803
f66c7cf8
PE
3804 Variadic C functions now count arguments with ptrdiff_t.
3805 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3806 Back then I didn't know that the Emacs coding style prefers signed int.
3807 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3808 were being counted with int, which may truncate counts on 64-bit
3809 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3810 * lisp.h (struct Lisp_Subr.function.aMANY)
3811 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3812 Arg counts are now ptrdiff_t, not size_t.
3813 All variadic functions and their callers changed accordingly.
3814 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3815 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3816 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3817 * callint.c (Fcall_interactively): Check arg count for overflow,
3818 to avoid potential buffer overrun. Use signed char, not 'int',
3819 for 'varies' array, so that we needn't bother to check its size
3820 calculation for overflow.
3821 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3822 * eval.c (apply_lambda):
3823 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3824 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3825 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3826
a1759b76
PE
3827 * callint.c (Fcall_interactively): Don't use index var as event count.
3828
d96be9fc
PE
3829 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3830 * mem-limits.h (SIZE): Remove; no longer used.
3831
a690a978 3832 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3833
578c21e6
PE
3834 Remove unnecessary casts.
3835 * xterm.c (x_term_init):
3836 * xfns.c (x_set_border_pixel):
3837 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3838 These aren't needed now that we assume ANSI C.
3839
96f53c6c
PE
3840 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3841 It's more likely to cause problems (due to unsigned overflow)
3842 than to cure them.
3843
83c77d31
PE
3844 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3845
ee2079f1
PE
3846 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3847
6da65536
PE
3848 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3849
7147c4a4
PE
3850 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3851
193e32d9
PE
3852 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3853
e5533da6
PE
3854 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3855
9910e595
PE
3856 GLYPH_CODE_FACE returns EMACS_INT, not int.
3857 * dispextern.h (merge_faces):
3858 * xfaces.c (merge_faces):
01103c44
PE
3859 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3860 Don't assume EMACS_INT fits in int.
9910e595 3861
2638320e
PE
3862 * character.h (CHAR_VALID_P): Remove unused parameter.
3863 * fontset.c, lisp.h, xdisp.c: All uses changed.
3864
045eb8d9
PE
3865 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3866
c1f134b5
PE
3867 * fns.c (concat): Minor tuning based on overflow analysis.
3868 This doesn't fix any bugs. Use int to hold character, instead
3869 of constantly refetching from Emacs object. Use XFASTINT, not
3870 XINT, for value known to be a character. Don't bother comparing
3871 a single byte to 0400, as it's always less.
3872
395fcb93 3873 * floatfns.c (Fexpt):
327eeec8
PE
3874 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3875
abbd3d23
PE
3876 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3877 for characters.
3878
684a03ef
PE
3879 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3880
0fed43f3
PE
3881 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3882 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3883 incorrectly succeed when S was a string, because 4294967386 was
3884 truncated before it was used.
3885
8fd02eb7
PE
3886 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3887 Otherwise, an out-of-range integer could cause undefined behavior
3888 on a 64-bit host.
3889
f8c86b69
PE
3890 * composite.c: Use int, not EMACS_INT, for characters.
3891 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3892 EMACS_INT, for values that are known to be in character range.
3893 This doesn't fix any bugs but is the usual style inside Emacs and
3894 may generate better code on 32-bit machines.
3895
34206dd2
PE
3896 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3897 This is for reasons similar to the recent CHAR_STRING fix.
3898 * charset.c (Fencode_char): Check that character arg is actually
3899 a character. Pass an int to ENCODE_CHAR.
3900 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3901 wider than 'int', as a compile-time check to prevent future regressions
3902 in this area.
3903
c5958d4c 3904 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3905
3906 Make sure a 64-bit char is never passed to CHAR_STRING.
3907 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3908 by silently ignoring the top 32 bits, allowing some values
3909 that were far too large to be valid characters.
3910 * character.h: Include <verify.h>.
3911 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3912 arguments are no wider than unsigned, as a compile-time check
3913 to prevent future regressions in this area.
3914 * data.c (Faset):
01103c44 3915 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3916 (Fsubst_char_in_region):
3917 * fns.c (concat):
3918 * xdisp.c (decode_mode_spec_coding):
3919 Adjust to CHAR_STRING's new requirement.
3920 * editfns.c (Finsert_char, Fsubst_char_in_region):
3921 * fns.c (concat): Check that character args are actually
3922 characters. Without this test, these functions did the wrong
3923 thing with wildly out-of-range values on 64-bit hosts.
3924
d37ca623
PE
3925 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3926 These casts should not be needed on 32-bit hosts, either.
3927 * keyboard.c (read_char):
3928 * lread.c (Fload): Remove casts to unsigned.
3929
ea204efb
PE
3930 * lisp.h (UNSIGNED_CMP): New macro.
3931 This fixes comparison bugs on 64-bit hosts.
3932 (ASCII_CHAR_P): Use it.
3933 * casefiddle.c (casify_object):
01103c44 3934 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3935 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3936 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3937 * dispextern.h (FACE_FROM_ID):
3938 * keyboard.c (read_char): Use UNSIGNED_CMP.
3939
41cb286c
PE
3940 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3941 not to EMACS_INT, to avoid GCC warning.
3942
4a1b9832
PE
3943 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3944
55daad71
PE
3945 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3946 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3947 isn't needed on 32-bit machines.
8f95c75c 3948
01103c44
PE
3949 * buffer.c (Fgenerate_new_buffer_name):
3950 Use EMACS_INT for count, not int.
0ceccced 3951 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3952
3953 * data.c (Qcompiled_function): Now static.
3954
c6f072e7
PE
3955 * window.c (window_body_lines): Now static.
3956
20ce5912
PE
3957 * image.c (gif_load): Rename local to avoid shadowing.
3958
9c4c5f81
PE
3959 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3960 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3961 * alloc.c (make_save_value): Integer argument is now of type
3962 ptrdiff_t, not int.
3963 (mark_object): Use ptrdiff_t, not int.
3964 * lisp.h (pD): New macro.
3965 * print.c (print_object): Use it.
3966
c0c5c8ae
PE
3967 * alloc.c: Use EMACS_INT, not int, to count objects.
3968 (total_conses, total_markers, total_symbols, total_vector_size)
3969 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3970 (total_free_floats, total_floats, total_free_intervals)
3971 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3972 Now EMACS_INT, not int. All uses changed.
3973 (Fgarbage_collect): Compute overall total using a double, so that
3974 integer overflow is less likely to be a problem. Check for overflow
3975 when converting back to an integer.
5a25e253
PE
3976 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3977 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3978 These were 'int' variables that could overflow on 64-bit hosts;
3979 they were never used, so remove them instead of repairing them.
211a0b2a 3980 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3981 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3982 Previously, this ceilinged at INT_MAX, but that doesn't work on
3983 64-bit machines.
e46bb31a 3984 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3985
c78baabf 3986 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3987 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3988 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3989 when a (possibly-narrower) signed value would do just as well.
3990 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3991
c9d624c6
PE
3992 * alloc.c: Catch some string size overflows that we were missing.
3993 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3994 for convenience in STRING_BYTES_MAX.
3995 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3996 The definition here is exact; the one in lisp.h was approximate.
3997 (allocate_string_data): Check for string overflow. This catches
3998 some instances we weren't catching before. Also, it catches
3999 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4000 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4001 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4002
c9d624c6
PE
4003 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4004 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4005 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4006
353032ce
PE
4007 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4008
2bccce07
PE
4009 * alloc.c (Fmake_string): Check for out-of-range init.
4010
0ac30604
SM
40112011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4012
4013 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4014
c195f2de
JD
40152011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4016
4017 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4018 xg_get_default_scrollbar_width.
4019
4020 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4021 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4022 (style_changed_cb): Call update_theme_scrollbar_width and call
4023 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4024 all frames (Bug#8505).
4025 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4026 Call gtk_window_set_resizable if HAVE_GTK3.
4027 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4028 and height if HAVE_GTK3 (Bug#8505).
4029 (scroll_bar_width_for_theme): New variable.
4030 (update_theme_scrollbar_width): New function.
4031 (xg_get_default_scrollbar_width): Move code to
4032 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4033 (xg_initialize): Call update_theme_scrollbar_width.
4034
4035 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4036
4037 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4038
e10ac9f1
MR
40392011-06-12 Martin Rudalics <rudalics@gmx.at>
4040
4041 * frame.c (make_frame): Call other_buffer_safely instead of
4042 other_buffer.
4043
4044 * window.c (temp_output_buffer_show): Call display_buffer with
4045 second argument Vtemp_buffer_show_specifiers and reset latter
4046 immediately after the call.
4047 (Vtemp_buffer_show_specifiers): New variable.
4048 (auto_window_vscroll_p, next_screen_context_lines)
4049 (Vscroll_preserve_screen_position): Remove leading asterisks from
4050 doc-strings.
4051
2d3c217e 40522011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4053
7b7f97e8 4054 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4055 * buffer.c (Qclone_number): Remove for now, as it's unused.
4056 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4057 (record_buffer): Remove unused local.
4058 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4059 (set_frame_buffer_list): Remove; unused.
4060 * frame.h (other_visible_frames): Remove decl.
4061 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4062 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4063 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4064 if HAVE_GPM.
4065 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4066 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4067 Define only if HAVE_GPM.
4068 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4069 (update_hints_inhibit): Remove; never set. All uses removed.
4070 * widgetprv.h (emacsFrameClassRec): Remove decl.
4071 * window.c (delete_deletable_window): Now returns void, since it
4072 wasn't returning anything.
4073 (compare_window_configurations): Remove unused locals.
4074 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4075 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4076 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4077 the same widths as pointers. This follows up on the 2011-05-06 patch.
4078 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4079 * xterm.h: Likewise.
4080 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4081
1384b89e
JB
40822011-06-12 Juanma Barranquero <lekktu@gmail.com>
4083
4084 * makefile.w32-in: Update dependencies.
4085 (LISP_H): Add lib/intprops.h.
4086
1100a63c
CY
40872011-06-11 Chong Yidong <cyd@stupidchicken.com>
4088
4089 * image.c (gif_load): Add animation frame delay to the metadata.
4090 (syms_of_image): Use DEFSYM. New symbol `delay'.
4091
6198ccd0
MR
40922011-06-11 Martin Rudalics <rudalics@gmx.at>
4093
4094 * window.c (delete_deletable_window): Re-add.
4095 (Fset_window_configuration): Rewrite to handle dead buffers and
4096 consequently deletable windows.
4097 (window_tree, Fwindow_tree): Remove. Supply functionality in
4098 window.el.
4099 (compare_window_configurations): Simplify code.
4100
b6e3633c
AS
41012011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4102
1ab0dee5
AS
4103 * image.c (imagemagick_load_image): Fix type mismatch.
4104 (Fimagemagick_types): Likewise.
4105
b6e3633c
AS
4106 * window.h (replace_buffer_in_windows): Declare.
4107
9397e56f
MR
41082011-06-11 Martin Rudalics <rudalics@gmx.at>
4109
4110 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4111 Qclone_number. Remove external declaration of Qdelete_window.
4112 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4113 code.
640c8776
SM
4114 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4115 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4116 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4117 buffer list implementation.
4118 (other_buffer_safely): New function.
4119 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4120 calls to replace_buffer_in_windows and
4121 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4122 if allowed.
4123 (record_buffer): Inhibit quitting and rewrite using quittable
4124 functions. Run Qbuffer_list_update_hook if allowed.
4125 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4126 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4127 Move switch-to-buffer to window.el.
9397e56f
MR
4128 (bury-buffer): Move to window.el.
4129 (Vbuffer_list_update_hook): New variable.
4130
4131 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4132 section.
4133
4134 * window.h (resize_frame_windows): Move up in code.
4135 (Fwindow_frame): Remove EXFUN.
4136 (replace_buffer_in_all_windows): Remove prototype.
4137 (replace_buffer_in_windows_safely): Add prototype.
4138
4139 * window.c: Declare Qdelete_window static again. Move down
4140 declaration of select_count.
4141 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4142 (Fother_window): Move to window.el.
4143 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4144 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4145 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4146 window.el.
4147 (replace_buffer_in_windows): Implement by calling
4148 Qreplace_buffer_in_windows.
4149 (replace_buffer_in_all_windows): Remove with some functionality
4150 moved into replace_buffer_in_windows_safely.
4151 (replace_buffer_in_windows_safely): New function.
4152 (select_window_norecord, select_frame_norecord): Move in front
4153 of run_window_configuration_change_hook. Remove now obsolete
4154 declarations.
640c8776
SM
4155 (Fset_window_buffer): Rewrite doc-string.
4156 Call Qrecord_window_buffer.
9397e56f
MR
4157 (keys_of_window): Move binding for other-window to window.el.
4158
b50691aa
CY
41592011-06-11 Chong Yidong <cyd@stupidchicken.com>
4160
4161 * dispextern.h (struct image): Replace data member, whose int_val
4162 and ptr_val fields were not used by anything, with a single
4163 lisp_val object.
4164
4165 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4166 (gif_clear_image, gif_load, imagemagick_load_image)
4167 (gs_clear_image, gs_load): Callers changed.
4168
3f754b86
PE
41692011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4170
cca69397
PE
4171 * buffer.h: Include <time.h>, for time_t.
4172 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4173
109e28d0
PE
4174 Fix minor problems found by static checking.
4175
60737f02
PE
4176 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4177
4b66faf3
PE
4178 Make identifiers static if they are not used in other modules.
4179 * data.c (Qcompiled_function, Qframe, Qvector):
4180 * image.c (QimageMagick, Qsvg):
4181 * minibuf.c (Qmetadata):
4182 * window.c (resize_window_check, resize_root_window): Now static.
4183 * window.h (resize_window_check, resize_root_window): Remove decls.
4184
109e28d0
PE
4185 * window.c (window_deletion_count, delete_deletable_window):
4186 Remove; unused.
46a4ce9e
PE
4187 (window_body_lines): Now static.
4188 (Fdelete_other_windows_internal): Mark vars as initialized.
4189 Make sure 'resize_failed' is initialized.
4190 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4191 (resize_window_apply): Remove unused local.
4192 * window.h (delete_deletable_window): Remove decl.
4193
109e28d0 4194 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4195 (imagemagick_load_image): Fix pointer signedness problem by changing
4196 last arg from unsigned char * to char *. All uses changed.
4197 Also, fix a local for similar reasons.
4198 Remove unused locals. Remove locals to avoid shadowing.
4199 (fn_rsvg_handle_free): Remove; unused.
4200 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4201 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4202
3f754b86
PE
4203 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4204
2547adb1
CY
42052011-06-10 Chong Yidong <cyd@stupidchicken.com>
4206
4207 * image.c (gif_load): Fix omitted cast error introduced by
4208 2011-06-06 change.
4209
2c8e37d4
MR
42102011-06-10 Martin Rudalics <rudalics@gmx.at>
4211
4212 * window.h (resize_proportionally, orig_total_lines)
4213 (orig_top_line): Remove from window structure.
4214 (set_window_height, set_window_width, change_window_heights)
4215 (Fdelete_window): Remove prototypes.
4216 (resize_frame_windows): Remove duplicate declaration.
4217
440a42e3
EZ
42182011-06-10 Eli Zaretskii <eliz@gnu.org>
4219
4220 * window.h (resize_frame_windows, resize_window_check)
4221 (delete_deletable_window, resize_root_window)
4222 (resize_frame_windows): Declare prototypes.
4223
4224 * window.c (resize_window_apply): Make definition be "static" to
4225 match the prototype.
4226
562dd5e9
MR
42272011-06-10 Martin Rudalics <rudalics@gmx.at>
4228
4229 * window.c: Remove declarations of Qwindow_size_fixed,
4230 window_min_size_1, window_min_size_2, window_min_size,
4231 size_window, window_fixed_size_p, enlarge_window, delete_window.
4232 Remove static from declaration of Qdelete_window, it's
4233 temporarily needed by Fbury_buffer.
4234 (replace_window): Don't assign orig_top_line and
4235 orig_total_lines.
4236 (Fdelete_window, delete_window): Remove. Window deletion is
4237 handled by window.el.
640c8776
SM
4238 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4239 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4240 (Fdelete_other_windows): Remove. Deleting other windows is
4241 handled by window.el.
4242 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4243 handled in window.el.
4244 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4245 Window minimum sizes are handled in window.el.
4246 (shrink_windows, size_window, set_window_height)
4247 (set_window_width, change_window_heights, window_height)
4248 (window_width, CURBEG, CURSIZE, enlarge_window)
4249 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4250 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4251 handled in window.el.
4252 (make_dummy_parent): Rename to make_parent_window and give it a
4253 second argument horflag.
4254 (make_window): Don't set resize_proportionally any more.
4255 (Fsplit_window): Remove. Windows are split in window.el.
4256 (save_restore_action, save_restore_orig_size)
4257 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4258 Resize mini windows in window.el.
4259 (grow_mini_window, shrink_mini_window): Implement by calling
4260 Qresize_root_window_vertically, resize_window_check and
4261 resize_window_apply.
640c8776
SM
4262 (saved_window, Fset_window_configuration, save_window_save):
4263 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4264 resize_proportionally.
4265 (window_min_height, window_min_width): Move to window.el.
4266 (keys_of_window): Move bindings for delete-other-windows,
4267 split-window, delete-window and enlarge-window to window.el.
4268
4269 * buffer.c: Temporarily extern Qdelete_window.
4270 (Fbury_buffer): Temporarily call Qdelete_window instead of
4271 Fdelete_window (Fbury_buffer will move to window.el soon).
4272
4273 * frame.c (set_menu_bar_lines_1): Remove code handling
4274 orig_top_line and orig_total_lines.
4275
4276 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4277 set_window_height but set heights directly.
4278 (change_frame_size_1): Use resize_frame_windows.
4279
4280 * xdisp.c (init_xdisp): Don't use set_window_height but set
4281 heights directly.
4282
640c8776
SM
4283 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4284 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4285 run_window_configuration_change_hook.
4286
4287 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4288 instead of change_window_heights and run
4289 run_window_configuration_change_hook.
4290
1a13852e
MR
42912011-06-09 Martin Rudalics <rudalics@gmx.at>
4292
4293 * window.c (replace_window): Rename second argument REPLACEMENT to
4294 NEW. New third argument SETFLAG. Rewrite.
4295 (delete_window, make_dummy_parent): Call replace_window with
4296 third argument 1.
4297 (window_list_1): Move down in code.
4298 (run_window_configuration_change_hook): Move set_buffer part
4299 before select_frame_norecord part in order to unwind correctly.
4300 Rename count1 to count.
4301 (recombine_windows, delete_deletable_window, resize_root_window)
4302 (Fdelete_other_windows_internal)
4303 (Frun_window_configuration_change_hook, make_parent_window)
4304 (resize_window_check, resize_window_apply, Fresize_window_apply)
4305 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4306 (Fdelete_window_internal, Fresize_mini_window_internal):
4307 New functions.
1a13852e
MR
4308 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4309
f3d1777e
MR
43102011-06-08 Martin Rudalics <rudalics@gmx.at>
4311
496e208e
MR
4312 * window.h (window): Add some new members to window structure -
4313 normal_lines, normal_cols, new_total, new_normal, clone_number,
4314 splits, nest, prev_buffers, next_buffers.
4315 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4316 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4317
f3d1777e
MR
4318 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4319 Remove.
496e208e
MR
4320 (make_dummy_parent): Set new members of windows structure.
4321 (make_window): Move down in code. Handle new members of window
4322 structure.
4323 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4324 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4325 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4326 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4327 (Fset_window_next_buffers, Fset_window_clone_number):
4328 New functions.
496e208e
MR
4329 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4330 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4331 Doc-string fixes.
4332 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4333 Argument WINDOW can be now internal window too.
4334 (Fwindow_use_time): Move up in code.
4335 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4336 Rewrite doc-string.
4337 (Fset_window_configuration, saved_window)
4338 (Fcurrent_window_configuration, save_window_save): Handle new
4339 members of window structure.
b9e809c2
MR
4340 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4341 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4342 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4343 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4344 Qget_mru_window, Qresize_root_window,
4345 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4346 Qauto_buffer_name; staticpro them.
f3d1777e 4347
abde8f8c
MR
43482011-06-07 Martin Rudalics <rudalics@gmx.at>
4349
4350 * window.c (Fwindow_total_size, Fwindow_left_column)
4351 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4352 (Fwindow_list_1): New functions.
4353 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4354 (Fwindow_width, Fscroll_left, Fscroll_right):
4355 Use window_body_cols instead of window_box_text_cols.
4356 (delete_window, Fset_window_configuration):
4357 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4358 (delete_all_subwindows): Take a window as argument and not a
4359 structure. Rewrite.
190b47e6
MR
4360 (window_loop): Remove handling of GET_LRU_WINDOW and
4361 GET_LARGEST_WINDOW.
4362 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4363
4364 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4365 window_box_text_cols. delete_all_subwindows now takes a
4366 Lisp_Object as argument.
abde8f8c 4367
640c8776
SM
4368 * indent.c (compute_motion, Fcompute_motion):
4369 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4370
fa8a67e6
MR
4371 * frame.c (delete_frame): Call delete_all_subwindows with root
4372 window as argument.
4373
a54e3482
DC
43742011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4375
4376 * fns.c (Fputhash): Document return value.
4377
60002bf5
CY
43782011-06-06 Chong Yidong <cyd@stupidchicken.com>
4379
4380 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4381
0c671da6 43822011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4383
b862a52a 4384 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4385
be44ca6c
PE
4386 Check for overflow when converting integer to cons and back.
4387 * charset.c (Fdefine_charset_internal, Fdecode_char):
4388 Use cons_to_unsigned to catch overflow.
4389 (Fencode_char): Use INTEGER_TO_CONS.
4390 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4391 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4392 * data.c (long_to_cons, cons_to_long): Remove.
4393 (cons_to_unsigned, cons_to_signed): New functions.
4394 These signal an error for invalid or out-of-range values.
4395 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4396 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4397 * font.c (Ffont_variation_glyphs):
4398 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4399 * lisp.h: Include <intprops.h>.
4400 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4401 (cons_to_signed, cons_to_unsigned): New decls.
4402 (long_to_cons, cons_to_long): Remove decls.
4403 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4404 (Fprimitive_undo): Use CONS_TO_INTEGER.
4405 * xfns.c (Fx_window_property): Likewise.
4406 * xselect.c: Include <limits.h>.
4407 (x_own_selection, selection_data_to_lisp_data):
4408 Use INTEGER_TO_CONS.
4409 (x_handle_selection_request, x_handle_selection_clear)
4410 (x_get_foreign_selection, Fx_disown_selection_internal)
4411 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4412 (lisp_data_to_selection_data): Use cons_to_unsigned.
4413 (x_fill_property_data): Use cons_to_signed.
4414 Report values out of range.
4415
d1f3d2af
PE
4416 Check for buffer and string overflow more precisely.
4417 * buffer.h (BUF_BYTES_MAX): New macro.
4418 * lisp.h (STRING_BYTES_MAX): New macro.
4419 * alloc.c (Fmake_string):
4420 * character.c (string_escape_byte8):
4421 * coding.c (coding_alloc_by_realloc):
4422 * doprnt.c (doprnt):
4423 * editfns.c (Fformat):
4424 * eval.c (verror):
4425 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4426 since they may not be the same number.
4427 * editfns.c (Finsert_char):
4428 * fileio.c (Finsert_file_contents):
4429 Likewise for BUF_BYTES_MAX.
4430
dd52fcea
PE
4431 * image.c: Use ptrdiff_t, not int, for sizes.
4432 (slurp_file): Switch from int to ptrdiff_t.
4433 All uses changed.
4434 (slurp_file): Check that file size fits in both size_t (for
4435 malloc) and ptrdiff_t (for sanity and safety).
4436
7f9bbdbb
PE
4437 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4438 if b->modtime has its maximal value.
4439
dfe18f82
PE
4440 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4441
84acfcf0
PE
4442 Don't assume time_t can fit into int.
4443 * buffer.h (struct buffer.modtime): Now time_t, not int.
4444 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4445 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4446
ccd9a01a
PE
4447 Minor fixes for signed vs unsigned integers.
4448 * character.h (MAYBE_UNIFY_CHAR):
4449 * charset.c (maybe_unify_char):
4450 * keyboard.c (read_char, reorder_modifiers):
4451 XINT -> XFASTINT, since the integer must be nonnegative.
4452 * ftfont.c (ftfont_spec_pattern):
4453 * keymap.c (access_keymap, silly_event_symbol_error):
4454 XUINT -> XFASTINT, since the integer must be nonnegative.
4455 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4456 since it makes no difference and we prefer signed.
4457 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4458 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4459 nonnegative.
4460
d6d100dd
SM
44612011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4462
4463 * window.h (Fwindow_frame): Declare.
4464
2b6148e4
PE
44652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4466
4467 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4468 (SPARE_MEMORY): Always define.
4469 (LARGE_REQUEST): Remove.
4470 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4471
f230ecc9
MR
44722011-06-06 Martin Rudalics <rudalics@gmx.at>
4473
727e958e
MR
4474 * lisp.h: Move EXFUNS for Fframe_root_window,
4475 Fframe_first_window and Fset_frame_selected_window to window.h.
4476
4477 * window.h: Move EXFUNS for Fframe_root_window,
4478 Fframe_first_window and Fset_frame_selected_window here from
4479 lisp.h.
4480
4481 * frame.c (Fwindow_frame, Fframe_first_window)
4482 (Fframe_root_window, Fframe_selected_window)
4483 (Fset_frame_selected_window): Move to window.c.
4484 (Factive_minibuffer_window): Move to minibuf.c.
4485 (Fother_visible_frames_p): New function.
4486
4487 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4488
f230ecc9
MR
4489 * window.c (decode_window, decode_any_window): Move up in code.
4490 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4491 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4492 (Fwindow_buffer): Move up and rewrite doc-string.
4493 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4494 (Fwindow_prev): New functions.
727e958e
MR
4495 (Fwindow_frame): Move here from frame.c. Accept any window as
4496 argument.
4497 (Fframe_root_window, Fframe_first_window)
4498 (Fframe_selected_window): Move here from frame.c. Accept frame
4499 or arbitrary window as argument. Update doc-strings.
4500 (Fminibuffer_window): Move up in code.
4501 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4502 (Fset_frame_selected_window): Move here from frame.c.
4503 Marginal rewrite.
727e958e
MR
4504 (Fselected_window, select_window, Fselect_window): Move up in
4505 code. Minor doc-string fixes.
f230ecc9 4506
4d09bcf6
PE
45072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4508
4509 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4510 Do not assume that spare memory exists; that assumption is valid
4511 only if SYSTEM_MALLOC.
4512 (LARGE_REQUEST): New macro, so that the issue of large requests
4513 is separated from the issue of spare memory.
4514
810928a2
AS
45152011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4516
172418ad
AS
4517 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4518 format. (Bug#8806)
4519
43f862f7
AS
4520 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4521
810928a2
AS
4522 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4523 before statements.
4524
a059fe24
JD
45252011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4526
4527 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4528
4529 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4530
4531 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4532 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4533
989bf368
JB
45342011-06-05 Juanma Barranquero <lekktu@gmail.com>
4535
4536 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4537
4b80f674
CY
45382011-06-04 Chong Yidong <cyd@stupidchicken.com>
4539
4540 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4541 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4542 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4543 New error handlers.
4b80f674
CY
4544 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4545 Obey Vx_select_enable_clipboard_manager. Catch errors in
4546 x_clipboard_manager_save (Bug#8779).
4547 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4548 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4549
99a33b77 45502011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4551
4552 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4553
99a33b77 45542011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4555
4556 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4557 in the current matrix if keep_current_p is non-zero.
4558
8264569d
EZ
45592011-06-04 Eli Zaretskii <eliz@gnu.org>
4560
4561 * bidi.c (bidi_level_of_next_char): Fix last change.
4562
57f97249
EZ
45632011-06-03 Eli Zaretskii <eliz@gnu.org>
4564
fec2107c 4565 Support bidi reordering of text covered by display properties.
57f97249 4566
fec2107c
EZ
4567 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4568 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4569 (bidi_cache_search, bidi_cache_iterator_state)
4570 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4571 (bidi_level_of_next_char, bidi_move_to_visually_next):
4572 Support character positions inside a run of characters covered by a
fec2107c
EZ
4573 display string.
4574 (bidi_paragraph_init, bidi_resolve_explicit_1)
4575 (bidi_level_of_next_char): Call bidi_fetch_char and
4576 bidi_fetch_char_advance instead of FETCH_CHAR and
4577 FETCH_CHAR_ADVANCE.
4578 (bidi_init_it): Initialize new members.
4579 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4580 definitions.
4581 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4582 instead of using explicit *_CHAR codes.
d6d100dd
SM
4583 (bidi_resolve_explicit, bidi_resolve_weak):
4584 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4585 bidirectional text is supported only in multibyte buffers.
4586 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4587 it to initialize the frame_window_p member of struct bidi_it.
4588 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4589 (bidi_resolve_explicit, bidi_resolve_weak)
4590 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4591 bidi_it->nchars is non-positive.
4592 (bidi_level_of_next_char): Don't try to lookup the cache for the
4593 next/previous character if nothing is cached there yet, or if we
4594 were just reseat()'ed to a new position.
c40e2fb2 4595
0e14fe90
EZ
4596 * xdisp.c (set_cursor_from_row): Set start and stop points
4597 according to the row's direction when priming the loop that looks
4598 for the glyph on which to display cursor.
4599 (single_display_spec_intangible_p): Function deleted.
4600 (display_prop_intangible_p): Reimplement to call
4601 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4602 Accept 3 additional arguments needed by handle_display_spec.
4603 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4604 values: lists, `(when COND...)' forms, etc.
4605 (single_display_spec_string_p): Support property values that are
4606 lists with the argument STRING its top-level element.
4607 (display_prop_string_p): Fix the condition for processing a
4608 property that is a list to be consistent with handle_display_spec.
fec2107c 4609 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4610 last portion of handle_display_prop.
4611 (compute_display_string_pos): Accept additional argument
4612 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4613 value of a `display' property is a "replacing spec".
4614 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4615 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4616 the display property, but just return a value indicating whether
4617 the display property will replace the characters it covers.
4618 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4619 frame_window_p members of struct bidi_it.
d6d100dd
SM
4620 (compute_display_string_pos, compute_display_string_end):
4621 New functions.
fec2107c
EZ
4622 (push_it): Accept second argument POSITION, where pop_it should
4623 jump to continue iteration.
4624 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4625
fec2107c
EZ
4626 * keyboard.c (adjust_point_for_property): Adjust the call to
4627 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4628
4629 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4630 (bidi_init_it): Update prototypes.
4631 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4632 (compute_display_string_pos, compute_display_string_end):
4633 Declare prototypes.
fec2107c
EZ
4634 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4635 EMACS_INT.
fc6f18ce 4636
40087514 46372011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4638
57f53182
PE
4639 Malloc failure behavior now depends on size of allocation.
4640 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4641 * lisp.h: Change signatures accordingly.
4642 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4643 All callers changed. (Bug#8762)
4644
4645 * gnutls.c: Use Emacs's memory allocators.
4646 Without this change, the gnutls library would invoke malloc etc.
4647 directly, which causes problems on non-SYNC_INPUT hosts, and which
4648 runs afoul of improving memory_full behavior. (Bug#8761)
4649 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4650 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4651 xfree instead of the default malloc, realloc, free.
4652 (Fgnutls_boot): No need to check for memory allocation failure,
4653 since xmalloc does that for us.
4654
ac32cd99 4655 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4656 * category.c (hash_get_category_set):
4657 * ccl.c (ccl_driver):
4658 * charset.c (Fdefine_charset_internal):
4659 * charset.h (struct charset.hash_index):
4660 * composite.c (get_composition_id, gstring_lookup_cache)
4661 (composition_gstring_put_cache):
4662 * composite.h (struct composition.hash_index):
4663 * dispextern.h (struct image.hash):
4664 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4665 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4666 (hashfn_equal, hashfn_user_defined, make_hash_table)
4667 (maybe_resize_hash_table, hash_lookup, hash_put)
4668 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4669 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4670 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4671 * image.c (make_image, search_image_cache, lookup_image)
4672 (xpm_put_color_table_h):
4673 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4674 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4675 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4676 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4677 * alloc.c (allocate_vectorlike):
4678 Check for overflow in vector size calculations.
4679 * ccl.c (ccl_driver):
4680 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4681 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4682 need to be updated by these changes.
40087514
PE
4683 * fns.c (make_hash_table, maybe_resize_hash_table):
4684 Check for integer overflow with large hash tables.
0de4bb68
PE
4685 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4686 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4687 (SXHASH_REDUCE): New macro.
4688 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4689 Use it instead of discarding useful hash info with large hash values.
4690 (sxhash_float): New function.
4691 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4692 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4693 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4694 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4695 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4696 Adjust signatures to match updated version of code.
4697 (consing_since_gc): Now EMACS_INT, since a single hash table can
4698 use more than INT_MAX bytes.
4699
698d32e2
DN
47002011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4701
4702 Make it possible to build with GCC-4.6+ -O2 -flto.
4703
4704 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4705
fd6fa53f
SM
47062011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4707
4708 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4709 Call minibuffer-inactive-mode.
4710
864db017
JB
47112011-05-31 Juanma Barranquero <lekktu@gmail.com>
4712
4713 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4714 Update dependencies.
4715
2ad0baf4
DN
47162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4717
4718 * data.c (init_data): Remove code for UTS, this system is not
4719 supported anymore.
4720
4fcc2638
DN
47212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4722
4723 Don't force ./temacs to start in terminal mode.
4724
4725 * frame.c (make_initial_frame): Initialize faces in all cases, not
4726 only when CANNOT_DUMP is defined.
4727 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4728
c56e0fd5
DN
47292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4730
4731 * dispnew.c (add_window_display_history): Use const for the string
4732 pointer. Remove declaration, not needed.
4733
333d54da 47342011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4735
55d4c1b2 4736 Use 'inline', not 'INLINE'.
333d54da 4737 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4738 * alloc.c, fontset.c (INLINE): Remove.
4739 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4740 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4741 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4742 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4743 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4744
738db178
DN
47452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4746
4747 Make it possible to run ./temacs.
4748
4749 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4750 syms_of_callproc does the same thing. Remove test for
4751 "initialized", do it in the caller.
4752 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4753
620c53a6
SM
47542011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4755
4756 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4757 (read_minibuf): Use get_minibuffer.
4758 (syms_of_minibuf): Use DEFSYM.
4759 (Qmetadata): New var.
4760 * data.c (Qbuffer): Don't make it static.
4761 (syms_of_data): Use DEFSYM.
4762
e003a292
PE
47632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4764
4765 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4766 (CCL_CODE_MIN): New macro.
4767
ed008a6d
PE
47682011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4769
3687c2ef
PE
4770 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4771
ed008a6d
PE
4772 * eval.c (Qdebug): Now static.
4773 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4774 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4775 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4776
d66c4c7c
CY
47772011-05-29 Chong Yidong <cyd@stupidchicken.com>
4778
4779 * image.c: Various fixes to ImageMagick code comments.
4780 (Fimagemagick_types): Doc fix.
4781
5fbc2025
PE
47822011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4783
0196f88a
PE
4784 Minor fixes prompted by GCC 4.6.0 warnings.
4785
4786 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4787
5fbc2025
PE
4788 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4789 (x_clipboard_manager_save_all): Move extern decl to ...
4790 * xterm.h: ... here, so that it can be checked for consistency.
4791
1dd3c2d9
CY
47922011-05-29 Chong Yidong <cyd@stupidchicken.com>
4793
4794 * xselect.c (x_clipboard_manager_save_frame)
4795 (x_clipboard_manager_save_all): New functions.
4796 (Fx_clipboard_manager_save): Lisp function deleted.
4797
4798 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4799 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4800
4801 * xterm.h: Update prototype.
4802
5ba6571d
WX
48032011-05-28 William Xu <william.xwl@gmail.com>
4804
4805 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4806 exiting (Bug#8239).
4807
3eaff834
JM
48082011-05-28 Jim Meyering <meyering@redhat.com>
4809
e1900994 4810 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4811 * fns.c (to_uchar): Define.
4812 (crypto_hash_function): Use it to convert some newly-signed
4813 variables to unsigned, to avoid sign-extension bugs. For example,
4814 without this change, (md5 "truc") would evaluate to
4815 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4816 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4817 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4818
0f6990a7
PE
48192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4820
4821 Integer overflow fixes.
c8a9ca5a 4822
08686060
PE
4823 * dbusbind.c: Serial number integer overflow fixes.
4824 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4825 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4826 to hold a serial number that is too large for a fixnum.
4827 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4828 Check for serial numbers out of range. Decode any serial number
59568bf0 4829 that was so large that it became a float. (Bug#8722)
08686060 4830
2d1fc3c7
PE
4831 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4832 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4833 Use XFASTINT rather than XUINT when numbers are nonnegative.
4834 (xd_append_arg, Fdbus_method_return_internal):
4835 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4836 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4837 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4838 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4839 (Bug#8722)
2d1fc3c7 4840
c8a9ca5a
PE
4841 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4842
519e1d69
PE
4843 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4844
30569699
PE
4845 ccl: add integer overflow checks
4846 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4847 (IN_INT_RANGE): New macros.
4848 (ccl_driver): Use them to check for integer overflow when
4849 decoding a CCL program. Many of the new checks are whether XINT (x)
4850 fits in int; it doesn't always, on 64-bit hosts. The new version
4851 doesn't catch all possible integer overflows, but it's an
847044ea 4852 improvement. (Bug#8719)
30569699 4853
c11285dc
PE
4854 * alloc.c (make_event_array): Use XINT, not XUINT.
4855 There's no need for unsigned here.
4856
fdccd48e
PE
4857 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4858 This follows up to the 2011-05-06 change that substituted uintptr_t
4859 for EMACS_INT. This case wasn't caught back then.
4860
37910ab2
PE
4861 Rework Fformat to avoid integer overflow issues.
4862 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4863 now (part of C89). Include <verify.h>.
4864 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4865 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4866 (Fformat): Avoid the prepass trying to compute sizes; it was only
4867 approximate and thus did not catch overflow reliably. Instead, walk
4868 through the format just once, formatting and computing sizes as we go,
4869 checking for integer overflow at every step, and allocating a larger
4870 buffer as needed. Keep track separately whether the format is
4871 multibyte. Keep only the most-recently calculated precision, rather
4872 than them all. Record whether each argument has been converted to
4873 string. Use EMACS_INT, not int, for byte and char and arg counts.
4874 Support field widths and precisions larger than INT_MAX. Avoid
4875 sprintf's undefined behavior with conversion specifications such as %#d
4876 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4877 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4878 formatting out-of-range floating point numbers with int
9173deec 4879 formats. (Bug#8668)
37910ab2 4880
2e6578fb
PE
4881 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4882
0ae6bdee
PE
4883 * data.c: Avoid integer truncation in expressions involving floats.
4884 * data.c: Include <intprops.h>.
4885 (arith_driver): When there's an integer overflow in an expression
4886 involving floating point, convert the integers to floating point
4887 so that the resulting value does not suffer from catastrophic
4888 integer truncation. For example, on a 64-bit host (* 4
4889 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4890 Do not rely on undefined behavior after integer overflow.
4891
de883a70
PE
4892 merge count_size_as_multibyte, parse_str_to_multibyte
4893 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4894 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4895 Check for integer overflow.
4896 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4897 since it's now a duplicate of the other. This is more of
4898 a character than a buffer op, so better that it's in character.c.
4899 * fns.c, print.c: Adjust to above changes.
4900
2ff916cb
PE
49012011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4902
4903 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4904
f1b54466
PE
49052011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4906
fb1ac845
PE
4907 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4908 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4909 (x_clipboard_manager_save): Now static.
4910 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4911
f1b54466
PE
4912 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4913 (crypto_hash_function): Now static.
4914 Fix pointer signedness problems. Avoid unnecessary initializations.
4915
a9f737ee
CY
49162011-05-27 Chong Yidong <cyd@stupidchicken.com>
4917
4918 * termhooks.h (Vselection_alist): Make it terminal-local.
4919
4920 * terminal.c (create_terminal): Initialize it.
4921
4922 * xselect.c: Support for clipboard managers.
4923 (Vselection_alist): Move to termhooks.h as terminal-local var.
4924 (LOCAL_SELECTION): New macro.
4925 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4926 (symbol_to_x_atom): Remove gratuitous arg.
4927 (x_handle_selection_request, lisp_data_to_selection_data)
4928 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4929 (x_own_selection, x_get_local_selection, x_convert_selection):
4930 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4931 (some_frame_on_display): Delete unused function.
4932 (Fx_own_selection_internal, Fx_get_selection_internal)
4933 (Fx_disown_selection_internal, Fx_selection_owner_p)
4934 (Fx_selection_exists_p): New optional frame arg.
4935 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4936 (x_handle_selection_clear): Don't treat other terminals with the
4937 same keyboard specially. Use the terminal-local Vselection_alist.
4938 (x_clear_frame_selections): Use Frun_hook_with_args.
4939
4940 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4941
4942 * xterm.h: Add support for those atoms.
4943
e067f0c1
CY
49442011-05-26 Chong Yidong <cyd@stupidchicken.com>
4945
4946 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4947 (converted_selections, conversion_fail_tag): New global variables.
4948 (x_selection_request_lisp_error): Free the above.
4949 (x_get_local_selection): Remove unnecessary code.
4950 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4951 of converted selections stored in converted_selections.
4952 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4953 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4954 (x_convert_selection): New function.
4955 (x_handle_selection_event): Simplify.
4956 (x_get_foreign_selection): Don't ignore incoming requests while
4957 waiting for an answer; this will fail when we implement
4958 SAVE_TARGETS, and seems unnecessary anyway.
4959 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4960 (Vx_sent_selection_functions): Doc fix.
4961
0f4aebc0
LL
49622011-05-26 Leo Liu <sdl.web@gmail.com>
4963
4964 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4965
e61124cd
YM
49662011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4967
4968 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4969
4970 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4971 for fringe update if it has periodic bitmap.
ac389d0c 4972 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4973 and fringe_bitmap_periodic_p.
4974
4975 * fringe.c (get_fringe_bitmap_data): New function.
4976 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4977 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4978 row. Mark glyph row for fringe update if periodicity changed.
4979
4980 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4981 for fringe update unless it has periodic bitmap.
4982
f16d9837
KH
49832011-05-25 Kenichi Handa <handa@m17n.org>
4984
4985 * xdisp.c (get_next_display_element): Set correct it->face_id for
4986 a static composition.
4987
e1b90ef6
LL
49882011-05-24 Leo Liu <sdl.web@gmail.com>
4989
4990 * deps.mk (fns.o):
4991 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4992
4993 * fns.c (crypto_hash_function, Fsha1): New function.
4994 (Fmd5): Use crypto_hash_function.
4995 (syms_of_fns): Add Ssha1.
4996
7400048f
PE
49972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4998
4999 * gnutls.c: Remove unused macros.
5000 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5001 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5002 Remove macros that are defined and never used.
5003 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5004
abb71cf4
CY
50052011-05-22 Chong Yidong <cyd@stupidchicken.com>
5006
5007 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5008 (Fx_get_selection_internal): Minor cleanup.
5009 (Fx_own_selection_internal): Rename arguments for consistency with
5010 select.el.
5011
6307db39
PE
50122011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5013
5014 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5015
f3d4e0a4
CY
50162011-05-22 Chong Yidong <cyd@stupidchicken.com>
5017
5018 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5019
4d8ade89
YM
50202011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5021
5022 * dispnew.c (scrolling_window): Don't exclude the case that the
5023 last enabled row in the desired matrix touches the bottom boundary.
5024
32078c8d
GM
50252011-05-21 Glenn Morris <rgm@gnu.org>
5026
5027 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5028 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5029 and add some more files.
32078c8d 5030
7285dc67
EZ
50312011-05-20 Eli Zaretskii <eliz@gnu.org>
5032
5033 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5034 report_file_error introduced by the change from 2011-05-07.
5035
89d1bd22
PE
50362011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5037
5038 * systime.h (Time): Define only if emacs is defined.
5039 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5040 where the include path doesn't have X11/X.h by default. See
5041 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5042
e23640bb 50432011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5044
5045 * composite.c (find_automatic_composition): Fix previous change.
5046
b9704ad9
GM
50472011-05-20 Glenn Morris <rgm@gnu.org>
5048
5049 * lisp.mk: New file, split from Makefile.in.
5050 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5051 (shortlisp): Remove.
5052 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5053
4a720484
GM
50542011-05-19 Glenn Morris <rgm@gnu.org>
5055
5056 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5057 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5058 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5059 (lisp): Set the order to that of loadup.el.
5060 (shortlisp): Make it a copy of $lisp.
5061 (SOME_MACHINE_LISP): Remove.
5062 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5063 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5064
a28d4396
KH
50652011-05-18 Kenichi Handa <handa@m17n.org>
5066
5067 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5068 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5069 (find_automatic_composition): Mostly rewrite for efficiency.
5070
a2b1fa8e
JB
50712011-05-18 Juanma Barranquero <lekktu@gmail.com>
5072
5073 * makefile.w32-in: Update dependencies.
5074
8e1f5610
CS
50752011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5076
5077 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5078 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5079
7025ee00 50802011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5081
cdfa6eab
PE
5082 Fix some integer overflow issues, such as string length overflow.
5083
06d6db33
PE
5084 * insdel.c (count_size_as_multibyte): Check for string overflow.
5085
2b4560a8
PE
5086 * character.c (lisp_string_width): Check for string overflow.
5087 Use EMACS_INT, not int, for string indexes and lengths; in
5088 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5089 the resulting string length overflows an EMACS_INT; instead,
5090 report a string overflow if no precision given. When checking for
5091 precision exhaustion, use a check that cannot possibly have
5092 integer overflow. (Bug#8675)
5093 * character.h (lisp_string_width): Adjust to new signature.
5094
cb93f9be
PE
5095 * alloc.c (string_overflow): New function.
5096 (Fmake_string): Use it. This doesn't change behavior, but saves
5097 a few bytes and will simplify future changes.
5098 * character.c (string_escape_byte8): Likewise.
5099 * lisp.h (string_overflow): New decl.
5100
1a1f3366
PE
5101 Fixups, following up to the user-interface timestamp change.
5102 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5103 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5104 * msdos.c (mouse_get_pos): Likewise.
5105 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5106 * w32gui.h (Time): Define by including "systime.h" rather than by
5107 declaring it ourselves. (Bug#8664)
5108
d4e3e4d3
PE
5109 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5110 * image.c (clear_image_cache): Likewise.
5111
f6a24d19
PE
5112 * term.c (term_mouse_position): Don't assume time_t wraparound.
5113
08dc5ae6
PE
5114 Be more systematic about user-interface timestamps.
5115 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5116 and sometimes 'EMACS_UINT', to represent these timestamps.
5117 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5118 This makes the code easier to follow, and makes it easier to catch
5119 integer overflow bugs such as Bug#8664.
5120 * frame.c (Fmouse_position, Fmouse_pixel_position):
5121 Use Time, not unsigned long, for user-interface timestamps.
5122 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5123 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5124 * keyboard.h (last_event_timestamp): Likewise.
5125 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5126 * menu.h (xmenu_show): Likewise.
5127 * term.c (term_mouse_position): Likewise.
5128 * termhooks.h (struct input_event.timestamp): Likewise.
5129 (struct terminal.mouse_position_hook): Likewise.
5130 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5131 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5132 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5133 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5134 what it was before.
5135 * menu.h, termhooks.h: Include "systime.h", for Time.
5136
8e55734a
PE
5137 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5138 Don't assume that the difference between two unsigned long values
5139 can fit into an integer. At this point, we know button_down_time
5140 <= event->timestamp, so the difference must be nonnegative, so
5141 there's no need to cast the result if double-click-time is
5142 nonnegative, as it should be; check that it's nonnegative, just in
5143 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5144 apart (about 25 days). (Bug#8664)
8e55734a 5145
841f1b75 5146 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5147 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5148
3e26f69c
PE
5149 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5150 that always fit in int. Use a sentinel instead of a counter, to
5151 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5152 * frame.h (struct frame): Use int for menu_bar_items_used
5153 instead of EMACS_INT, since it always fits in int.
3e26f69c 5154
5cc152c0
PE
5155 * menu.c (grow_menu_items): Check for int overflow.
5156
d89eb65e
PE
5157 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5158
5235bd3e
PE
5159 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5160 Before, the code was not consistent. These values cannot exceed
5161 2**31 - 1 so there's no need to make them unsigned.
5162 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5163 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5164 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5165 as modifiers.
5166 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5167
bc827e23
PE
5168 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5169 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5170 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5171 presumably because the widths might not match.
5172
78eb494e
PE
5173 * window.c (size_window): Avoid needless test at loop start.
5174
04f2d78b
CB
51752011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5176
5177 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5178
d2fc7e3d 51792011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5180
5181 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5182
d2fc7e3d 51832011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5184
5185 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5186 `width' to `bar_area_x' and `bar_area_width', respectively.
5187 (x_scroll_run): Take account of fringe background extension.
5188
04f2d78b
CB
5189 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5190 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5191 `bar_area_width', respectively.
5192 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5193 background extension.
5194
79b70037
GM
51952011-05-10 Jim Meyering <meyering@redhat.com>
5196
5197 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5198
2f142cc5
JB
51992011-05-10 Juanma Barranquero <lekktu@gmail.com>
5200
5201 * image.c (Finit_image_library): Return t for built-in image types,
5202 like pbm and xbm. (Bug#8640)
5203
57679c86
AS
52042011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5205
5206 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5207
888c9e86
EZ
52082011-05-07 Eli Zaretskii <eliz@gnu.org>
5209
b0512a1d
EZ
5210 * w32console.c (Fset_screen_color): Doc fix.
5211 (Fget_screen_color): New function.
5212 (syms_of_ntterm): Defsubr it.
5213
7285dc67
EZ
5214 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5215 unlink the temporary file if Fcall_process didn't create it in the
5216 first place.
5217 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5218 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5219 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5220 cue to call_process_cleanup not to close that handle.
5221
4d3fcc8e
BK
52222011-05-07 Ben Key <bkey76@gmail.com>
5223
5224 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5225 one of two shell specific rules, either bootstrap-temacs-CMD or
5226 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5227 to the previous implementation of the bootstrap-temacs rule.
5228 The bootstrap-temacs-CMD rule is similar to the previous
5229 implementation of the bootstrap-temacs rule except that it
5230 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5231 variable.
5232
5233 These changes, along with some changes to nt/configure.bat,
5234 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5235 earlier fix to add support for --cflags and --ldflags options
5236 that include quotes so that it works whether make uses cmd or
5237 sh as the shell.
5238
b4289b64
MA
52392011-05-06 Michael Albinus <michael.albinus@gmx.de>
5240
5241 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5242 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5243 is a constant.
5244 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5245 a string. Handle both cases.
5246 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5247 (Fdbus_register_method): Use Qinvalid_function.
5248
af4c0e28
JB
52492011-05-06 Juanma Barranquero <lekktu@gmail.com>
5250
5251 * makefile.w32-in: Update dependencies.
5252 (LISP_H): Add inttypes.h and stdin.h.
5253 (PROCESS_H): Add unistd.h.
5254
c51453d9
EZ
52552011-05-06 Eli Zaretskii <eliz@gnu.org>
5256
5257 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5258 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5259
8ff0ac3c 52602011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5261
4c4b566b
PE
5262 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5263
aab2b9b5
PE
5264 * term.c (vfatal): Remove stray call to va_end.
5265 It's not needed and the C Standard doesn't allow it here anyway.
5266
c378da0b
PE
5267 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5268 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5269
288b08c7
PE
5270 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5271 bytes.
5272
e3601888
PE
5273 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5274
db6c0e74
PE
5275 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5276
dd5963ea
PE
5277 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5278
88c9450f
PE
5279 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5280
2f9442b8
PE
5281 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5282
c032b5f8
PE
5283 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5284 * charset.c (Fdefine_charset_internal): Don't initialize
5285 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5286 32-bit int (Bug#8600).
a108c10b
PE
5287
5288 * lread.c (read_integer): Be more consistent with string-to-number.
5289 Use string_to_number to do the actual conversion; this avoids
5290 rounding errors and fixes some other screwups. Without this fix,
5291 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5292 (digit_to_number): Move earlier, for benefit of read_integer.
5293 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5294 not a digit in any supported base. (Bug#8602)
a108c10b 5295
ad5f9eea
PE
5296 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5297
aec1708a
PE
5298 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5299 to match comment at start of function. This also removes a
5300 GCC warning about overflow in a 32+64-bit port.
5301
47be4ab5
PE
5302 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5303
371cac43
PE
5304 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5305 Reported by Stefan Monnier in
5306 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5307 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5308 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5309
d01a7826
PE
5310 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5311 (EMACS_UINTPTR): Likewise, with uintptr_t.
5312
7fd47d5c
PE
5313 * lisp.h: Prefer 64-bit EMACS_INT if available.
5314 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5315 on 32-bit hosts that have 64-bit int, so that they can access
5316 large files.
122b0c86
PE
5317 However, temporarily disable this change unless the temporary
5318 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5319
8727937b
PE
5320 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5321
8ac068ac
PE
5322 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5323 This removes an assumption that EMACS_INT and long are the same
5324 width as pointers. The assumption is true for Emacs porting targets
5325 now, but we want to make other targets possible.
5326 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5327 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5328 In the rest of the code, change types of integers that hold casted
5329 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5330 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5331 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5332 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5333 No need to cast type when ORing.
5334 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5335 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5336 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5337 assume EMACS_INT is the same width as char *.
5338 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5339 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5340 Remove no-longer-needed casts.
5341 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5342 (xg_tool_bar_help_callback, xg_make_tool_item):
5343 Use EMACS_INTPTR to hold an integer
5344 that will be cast to void *; this can avoid a GCC warning
5345 if EMACS_INT is not the same width as void *.
5346 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5347 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5348 (current_message_1, set_message_1):
5349 Use a local to convert to proper width without a cast.
5350 * xmenu.c (dialog_selection_callback): Likewise.
5351
ede49d71
PE
5352 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5353 Also, don't assume VALBITS / RAND_BITS is less than 5,
5354 and don't rely on undefined behavior when shifting a 1 left into
5355 the sign bit.
5356 * lisp.h (get_random): Change signature to match.
5357
2f30ecd0
PE
5358 * lread.c (hash_string): Use size_t, not int, for hash computation.
5359 Normally we prefer signed values; but hashing is special, because
5360 it's better to use unsigned division on hash table sizes so that
5361 the remainder is nonnegative. Also, size_t is the natural width
5362 for hashing into memory. The previous code used 'int', which doesn't
5363 retain enough info to hash well into very large tables.
5364 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5365
2a866e7b
PE
5366 * dbusbind.c: Don't possibly lose pointer info when converting.
5367 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5368 Use XPNTR rather than XHASH, so that the high-order bits of
5369 the pointer aren't lost when converting through void *.
5370
51639eac
PE
5371 * eval.c (Fautoload): Don't double-shift a pointer.
5372
92394119
PE
5373 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5374
dbdb9a7c
JB
53752011-05-06 Juanma Barranquero <lekktu@gmail.com>
5376
5377 * gnutls.c (DEF_GNUTLS_FN):
5378 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5379
db7a0b4f
AS
53802011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5381
5382 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5383 marker. (Bug#8610)
5384
f7ff1b0f 53852011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5386
5387 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5388 New version that can reserve upto 2GB of heap space.
5389
f7ff1b0f 53902011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5391
5392 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5393
639c109b
TZ
53942011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5395
5396 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5397 `gnutls_certificate_set_x509_key_file'.
5398
d2127135
JB
53992011-05-05 Juanma Barranquero <lekktu@gmail.com>
5400
5401 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5402 Update dependencies.
5403
e968f4f3
JB
54042011-05-04 Juanma Barranquero <lekktu@gmail.com>
5405
5406 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5407 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5408 Remove unused parameter `fildes'.
5409 * process.c (read_process_output, send_process): Don't pass it.
5410
84d358f0
JB
54112011-05-04 Juanma Barranquero <lekktu@gmail.com>
5412
5413 Fix previous change: the library cache is defined in w32.c.
5414 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5415 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5416
0898ca10
JB
54172011-05-04 Juanma Barranquero <lekktu@gmail.com>
5418
5419 Implement dynamic loading of GnuTLS on Windows.
5420
5421 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5422 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5423 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5424 Declare.
5425
5426 * gnutls.c (Qgnutls_dll): Define.
5427 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5428 (gnutls_*): Declare function pointers.
5429 (init_gnutls_functions): New function to initialize function pointers.
5430 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5431 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5432 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5433 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5434 (emacs_gnutls_write, emacs_gnutls_read)
5435 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5436 (Fgnutls_available_p): New function.
5437 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5438 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5439 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5440
5441 * image.c: Include w32.h.
5442 (Vimage_type_cache): Delete.
5443 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5444 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5445 (w32_delayed_load): Move to w32.c.
5446
5447 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5448
5449 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5450 (w32_delayed_load): Move from image.c. When loading a library, record
5451 its filename in the :loaded-from property of the library id.
5452 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5453 Initialize and staticpro them.
5454 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5455
5456 * process.c: Include lisp.h before w32.h, not after.
5457 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5458 instead of gnutls_record_check_pending.
5459
5460 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5461
ff4de4aa
TZ
54622011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5463
5464 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5465 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5466 as passed in.
5467
abe95abb
JD
54682011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5469
5470 * xterm.c (x_set_frame_alpha): Do not set property on anything
5471 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5472
e16e55d4
JB
54732011-05-02 Juanma Barranquero <lekktu@gmail.com>
5474
5475 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5476
bafcf6a5
JB
54772011-05-02 Juanma Barranquero <lekktu@gmail.com>
5478
5479 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5480 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5481 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5482 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5483 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5484 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5485 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5486 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5487 (Qgnutls_bootprop_callbacks_verify): Make static.
5488
e7a6747f
AS
54892011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5490
19ed11ba
AS
5491 * callproc.c: Indentation fixup.
5492
e7a6747f 5493 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5494 (wait_for_termination, interruptible_wait_for_termination):
5495 Move after wait_for_termination_1.
e7a6747f 5496
1ef14cb4
LMI
54972011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5498
5499 * sysdep.c (interruptible_wait_for_termination): New function
5500 which is like wait_for_termination, but allows keyboard
5501 interruptions.
5502
5503 * callproc.c (Fcall_process): Add (:file "file") as an option for
5504 the STDOUT buffer.
5505 (Fcall_process_region): Ditto.
5506
330d880c
EZ
55072011-04-30 Eli Zaretskii <eliz@gnu.org>
5508
8db90b73
EZ
5509 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5510 rather than `XVECTOR (FOO)->size'.
5511
330d880c
EZ
5512 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5513 inttypes.h, as a gnulib replacement is used if it not available in
5514 system headers.
5515
15cbd324
EZ
55162011-04-21 Eli Zaretskii <eliz@gnu.org>
5517
5518 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5519 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5520 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5521
5522 * coding.c (coding_alloc_by_realloc): Error out if destination
5523 will grow beyond MOST_POSITIVE_FIXNUM.
5524 (decode_coding_emacs_mule): Abort if there isn't enough place in
5525 charbuf for the composition carryover bytes. Reserve an extra
5526 space for up to 2 characters produced in a loop.
5527 (decode_coding_iso_2022): Abort if there isn't enough place in
5528 charbuf for the composition carryover bytes.
5529
55302011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5531
ae940cca
EZ
5532 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5533 aborting when %lld or %lll format is passed.
5534 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5535 %llo or %llx format is passed. (Bug#8545)
5536
03ab8921
EZ
5537 * window.c (window_scroll_line_based): Use a marker instead of
5538 simple variables to record original value of point. (Bug#7952)
5539
afda1437
EZ
5540 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5541 produced by %s or %c overflows available buffer space. (Bug#8545)
5542
f76dee0c
PE
55432011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5544
5545 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5546 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5547
fdc5744d
JB
55482011-04-28 Juanma Barranquero <lekktu@gmail.com>
5549
5550 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5551
638f053a
JB
55522011-04-28 Juanma Barranquero <lekktu@gmail.com>
5553
5554 * keyboard.c (Qdelayed_warnings_hook): Define.
5555 (command_loop_1): Run `delayed-warnings-hook'
5556 if Vdelayed_warnings_list is non-nil.
5557 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5558 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5559
d178f871
EZ
55602011-04-28 Eli Zaretskii <eliz@gnu.org>
5561
5562 * doprnt.c (doprnt): Don't return value smaller than the buffer
5563 size if the message was truncated. (Bug#8545).
5564
b124fd93
JB
55652011-04-28 Juanma Barranquero <lekktu@gmail.com>
5566
5567 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5568 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5569
e810457d
PE
55702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5571
5572 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5573
ea51cceb
JB
55742011-04-27 Juanma Barranquero <lekktu@gmail.com>
5575
5576 * makefile.w32-in: Update dependencies.
5577
94dcfacf
EZ
55782011-04-27 Eli Zaretskii <eliz@gnu.org>
5579
5580 Improve `doprnt' and its usage. (Bug#8545)
5581 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5582 `format_end'. Remove support for %l as a conversion specifier.
5583 Don't use xrealloc. Improve diagnostics when the %l size modifier
5584 is used. Update the commentary.
5585
5586 * eval.c (verror): Simplify calculation of size_t.
5587
5588 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5589 messages.
5590
f61f41d7
PE
55912011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5592
5593 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5594 change.
5595
96fb4434
PE
55962011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5597
5598 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5599 This makes this file independent of the recent pseudovector change.
5600
671875da 56012011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5602
69e9b5a3
PE
5603 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5604
b5f869a7 5605 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5606 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5607 Remove unused local.
c8926152 5608 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5609
841a1577 5610 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5611 GCC 4.6.0 optimizes based on type-based alias analysis.
5612 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5613 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5614 != &v->size, and therefore "v->size = 1; b->size = 2; return
5615 v->size;" must therefore return 1. This assumption is incorrect
5616 for Emacs, since it type-puns struct Lisp_Vector * with many other
5617 types. To fix this problem, this patch adds a new type struct
f904488f 5618 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5619 and pseudovectors, and helps optimizing compilers not get fooled
5620 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5621 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5622 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5623 the size member.
eab3844f
PE
5624 (XSETPVECTYPE): Rewrite in terms of new macro.
5625 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5626 This is a bit clearer, and further avoids the possibility of
5627 undesirable aliasing.
5628 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5629 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5630 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5631 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5632 (ASIZE): Now uses header.size rather than size.
5633 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5634 to avoid the hassle of writing XVECTOR (foo)->header.size.
5635 (struct vectorlike_header): New type.
eab3844f
PE
5636 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5637 object, to help avoid aliasing.
5638 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5639 (SUBRP): Likewise, since Lisp_Subr is a special case.
5640 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5641 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5642 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5643 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5644 changed to be "header.size" and "header.next".
5645 * buffer.h (struct buffer): Likewise.
5646 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5647 * frame.h (struct frame): Likewise.
5648 * process.h (struct Lisp_Process): Likewise.
5649 * termhooks.h (struct terminal): Likewise.
5650 * window.c (struct save_window_data, struct saved_window): Likewise.
5651 * window.h (struct window): Likewise.
5652 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5653 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5654 * buffer.c (init_buffer_once): Likewise.
5655 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5656 special case.
5657 * process.c (Fformat_network_address): Use local var for size,
5658 for brevity.
5659
0df1eac5
PE
5660 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5661
847ab9d1 5662 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5663 * data.c (atof): Remove decl; no longer used or needed.
5664 (digit_to_number): Move to lread.c.
5665 (Fstring_to_number): Use new string_to_number function, to be
5666 consistent with how the Lisp reader treats infinities and NaNs.
5667 Do not assume that floating-point numbers represent EMACS_INT
5668 without losing information; this is not true on most 64-bit hosts.
5669 Avoid double-rounding errors, by insisting on integers when
5670 parsing non-base-10 numbers, as the documentation specifies.
5671 * lisp.h (string_to_number): New decl, replacing ...
5672 (isfloat_string): Remove.
bc0a5c13 5673 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5674 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5675 appears to have been a coding error. Similarly, do not accept
5676 strings like +-1e0 as floating point numbers. Do not report
5677 overflow for integer overflows unless the base is not 10 which
5678 means we have no simple and reliable way to continue.
5679 Break out the floating-point parsing into a new
5680 function string_to_number, so that Fstring_to_number parses
5681 floating point numbers consistently with the Lisp reader.
04f2d78b 5682 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5683 (E_CHAR, EXP_INT): Remove, replacing with ...
5684 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5685 (string_to_number): New function, replacing isfloat_string.
5686 This function checks for valid syntax and produces the resulting
5687 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5688 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5689 so that overflow for non-base-10 numbers is reported only when
5690 there's no portable and simple way to convert to floating point.
452f4150 5691
67769ffc
PE
5692 * textprop.c (set_text_properties_1): Rewrite for clarity,
5693 and to avoid GCC warning about integer overflow.
5694
c20db43f
PE
5695 * intervals.h (struct interval): Use EMACS_INT for members
5696 where EMACS_UINT might cause problems. See
5697 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5698 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5699 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5700 All uses changed.
37aa2f85
PE
5701 (offset_intervals): Tell GCC not to worry about length overflow
5702 when negating a negative length.
c20db43f 5703
2538aa2f
PE
5704 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5705 (overrun_check_free): Likewise.
5706
f2d3008d
PE
5707 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5708 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5709 word size.
5710
ec8df744
PE
5711 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5712 (gnutls_make_error): Rename local to avoid shadowing.
5713 (gnutls_emacs_global_deinit): ifdef out; not used.
5714 (Fgnutls_boot): Use const for pointer to readonly storage.
5715 Comment out unused local. Fix pointer signedness problems.
5716
640ee02d
PE
5717 * lread.c (openp): Don't stuff size_t into an 'int'.
5718 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5719 about possible signed overflow.
5720
6048fb2a
PE
5721 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5722 (GDK_KEY_g): Don't define if already defined.
5723 (xg_prepare_tooltip): Avoid pointer signedness problem.
5724 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5725
fa3c87e1
PE
5726 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5727 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5728
2172544b
PE
5729 * xfns.c (Fx_window_property): Simplify a bit,
5730 to make a bit faster and to avoid GCC 4.6.0 warning.
5731 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5732
9b821a21
PE
5733 * fns.c (internal_equal): Don't assume size_t fits in int.
5734
3c616cfa
PE
5735 * alloc.c (compact_small_strings): Tighten assertion a little.
5736
c2982e87
PE
5737 Replace pEd with more-general pI, and fix some printf arg casts.
5738 * lisp.h (pI): New macro, generalizing old pEd macro to other
5739 conversion specifiers. For example, use "...%"pI"d..." rather
5740 than "...%"pEd"...".
5741 (pEd): Remove. All uses replaced with similar uses of pI.
5742 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5743 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5744 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5745 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5746 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5747 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5748 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5749 64-bit hosts.
5750 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5751 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5752 * print.c (safe_debug_print, print_object): Likewise.
5753 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5754 to int.
6f04d126
PE
5755 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5756 avoiding the 0 flag, which is not portable.
c2982e87
PE
5757 * process.c (Fmake_network_process): Use pI to avoid cast.
5758 * region-cache.c (pp_cache): Likewise.
5759 * xdisp.c (decode_mode_spec): Likewise.
5760 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5761 behavior on 64-bit hosts with printf arg.
6f04d126 5762 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5763 (x_stop_queuing_selection_requests): Likewise.
5764 (x_get_window_property): Don't truncate byte count to an 'int'
5765 when tracing.
0b432f21 5766
5e073ec7
PE
5767 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5768 here, since it parses constructs like leading '-' and spaces,
5769 which are not wanted; and it overflows with large numbers.
5770 Instead, simply match F[0-9]+, which is what is wanted anyway.
5771
36372bf9
PE
5772 * alloc.c: Remove unportable assumptions about struct layout.
5773 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5774 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5775 (allocate_vectorlike, make_pure_vector): Use the new macros,
5776 plus offsetof, to remove unportable assumptions about struct layout.
5777 These assumptions hold on all porting targets that I know of, but
5778 they are not guaranteed, they're easy to remove, and removing them
5779 makes further changes easier.
5780
0b432f21
PE
5781 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5782 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5783 (string_overrun_cookie): Now const. Use initializers that
5784 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5785 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5786 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5787 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5788 multiple of sizeof (EMACS_INT); it need not be, if
5789 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5790 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5791
895009e1
JB
57922011-04-26 Juanma Barranquero <lekktu@gmail.com>
5793
5794 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5795
6a7a1b0b
TZ
57962011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5797
5798 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5799 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5800 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5801
841a1577 58022011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5803
5804 * lisp.h (Qdebug): List symbol.
895009e1 5805 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5806 * keyboard.c (debug-on-event): New variable.
5807 (handle_user_signal): Break into debugger when debug-on-event
5808 matches the current signal symbol.
5809
f2d3ba6f
DN
58102011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5811
5812 * alloc.c (check_sblock, check_string_bytes)
5813 (check_string_free_list): Convert to standard C.
5814
42ce4c63
TZ
58152011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5816
5817 * w32.c (emacs_gnutls_push): Fix typo.
5818
825cd63c
EZ
58192011-04-25 Eli Zaretskii <eliz@gnu.org>
5820
fb11d64d
EZ
5821 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5822 "cast to pointer from integer of different size".
5823
825cd63c
EZ
5824 Improve doprnt and its use in verror. (Bug#8545)
5825 * doprnt.c (doprnt): Document the set of format control sequences
5826 supported by the function. Use SAFE_ALLOCA instead of always
5827 using `alloca'.
5828
5829 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5830 is one byte too soon. Don't use xrealloc; instead xfree and
5831 xmalloc anew.
5832
e061a11b
TZ
58332011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5834
5835 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5836 callbacks stage.
5837
5838 * gnutls.c: Renamed global_initialized to
5839 gnutls_global_initialized. Added internals for the
5840 :verify-hostname-error, :verify-error, and :verify-flags
5841 parameters of `gnutls-boot' and documented those parameters in the
5842 docstring. Start callback support.
9173deec
JB
5843 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5844 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5845 on error. Return error code.
e061a11b
TZ
5846 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5847 (emacs_gnutls_read): Likewise.
5848 (Fgnutls_boot): Return handshake error code.
5849 (emacs_gnutls_handle_error): New function.
5850 (wsaerror_to_errno): Likewise.
5851
5852 * w32.h (emacs_gnutls_pull): Add prototype.
5853 (emacs_gnutls_push): Likewise.
5854
5855 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5856 (emacs_gnutls_push): Likewise.
5857
58582011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5859
5860 * process.c (wait_reading_process_output): Check if GnuTLS
5861 buffered some data internally if no FDs are set for TLS
5862 connections.
5863
5864 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5865 (LIBS): Link to USER_LIBS.
5866 ($(BLD)/gnutls.$(0)): New target.
5867
fa6996bc
EZ
58682011-04-24 Eli Zaretskii <eliz@gnu.org>
5869
eb35682e
EZ
5870 * xdisp.c (handle_single_display_spec): Rename the
5871 display_replaced_before_p argument into display_replaced_p, to
5872 make it consistent with the commentary. Fix typos in the
5873 commentary.
5874
e2ad650c
EZ
5875 * textprop.c (syms_of_textprop): Remove dead code.
5876 (copy_text_properties): Delete obsolete commentary about an
5877 interface that was deleted long ago. Fix typos in the description
5878 of arguments.
5879
1b2de274
EZ
5880 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5881 to changes in oldXMenu/XMenu.h from 2011-04-16.
5882 <menu_help_message, prev_menu_help_message>: Constify.
5883 (IT_menu_make_room): menu->help_text is now `const char **';
5884 adjust.
5885
5886 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5887 to changes in oldXMenu/XMenu.h from 2011-04-16.
5888 (struct XMenu): Declare `help_text' `const char **'.
5889
5890 * xfaces.c <Qunspecified>: Make extern again.
5891
5892 * syntax.c: Include sys/types.h before including regex.h, as
5893 required by Posix.
5894
762b15be
EZ
5895 * doc.c (get_doc_string): Improve the format passed to `error'.
5896
5897 * doprnt.c (doprnt): Improve commentary.
5898
5899 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5900
5901 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5902 them with etags.
5903
f1052e5d
EZ
5904 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5905 changes in globals.h immediately force recompilation.
762b15be
EZ
5906 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5907 $(CURDIR)/s/ms-w32.h.
5908 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5909
fa6996bc
EZ
5910 * character.c (Fchar_direction): Function deleted.
5911 (syms_of_character): Don't defsubr it.
5912 <char-direction-table>: Deleted.
5913
e6c3da20
EZ
59142011-04-23 Eli Zaretskii <eliz@gnu.org>
5915
5916 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5917 * doprnt.c: Include limits.h.
5918 (SIZE_MAX): New macro.
04f2d78b
CB
5919 (doprnt): Return a size_t value. 2nd arg is now size_t.
5920 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5921 Improve overflow protection. Support `l' modifier for integer
5922 conversions. Support %l conversion. Don't assume an EMACS_INT
5923 argument for integer conversions and for %c.
5924
5925 * lisp.h (doprnt): Restore prototype.
5926
5927 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5928 $(SRC)/character.h.
5929
5930 * Makefile.in (base_obj): Add back doprnt.o.
5931
5932 * deps.mk (doprnt.o): Add back prerequisites.
5933 (callint.o): Depend on character.h.
5934
5935 * eval.c (internal_lisp_condition_case): Include the handler
5936 representation in the error message.
5937 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5938 when breaking from the loop.
5939
5940 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5941
5942 * callint.c (Fcall_interactively): When displaying error message
5943 about invalid control letter, pass the character's codepoint, not
5944 a pointer to its multibyte form. Improve display of the character
5945 in octal and display also its hex code.
5946
5947 * character.c (char_string): Use %x to display the (unsigned)
5948 codepoint of an invalid character, to avoid displaying a bogus
5949 negative value.
5950
5951 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5952 `error', not SYMBOL_NAME itself.
5953
5954 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5955 character arguments to `error'.
5956
5957 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5958 to `error' in error message about FINAL_CHAR argument. Make sure
5959 FINAL_CHAR is a character, and use %c when it is passed as
5960 argument to `error'.
5961
4ffd0d6b 59622011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5963
5964 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5965
5966 * w32.c: Include <time.h>.
5967 (sys_localtime): New function.
5968
4ffd0d6b 59692011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5970
5971 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5972
4ffd0d6b 5973 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5974
4ffd0d6b 59752011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5976
4ffd0d6b
GM
5977 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5978 zombies (Bug#8467).
aac0c6e3 5979
04c56954
EZ
59802011-04-19 Eli Zaretskii <eliz@gnu.org>
5981
5982 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5983 gl_state.e_property when gl_state.object is Qt.
5984
5985 * insdel.c (make_gap_larger): Remove limitation of buffer size
5986 to <= INT_MAX.
5987
16a43933
CY
59882011-04-18 Chong Yidong <cyd@stupidchicken.com>
5989
5990 * xdisp.c (lookup_glyphless_char_display)
5991 (produce_glyphless_glyph): Handle cons cell entry in
5992 glyphless-char-display.
5993 (Vglyphless_char_display): Document it.
5994
5995 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5996 glyphless-char-display.
5997
4581706e
CY
59982011-04-17 Chong Yidong <cyd@stupidchicken.com>
5999
6000 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6001
6002 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6003
6004 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6005 definition for no-X builds.
6006
4887c6e2 60072011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6008
fd35b6f9
PE
6009 Static checks with GCC 4.6.0 and non-default toolkits.
6010
5c1ccb01
PE
6011 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6012
006c5daa
PE
6013 * process.c (keyboard_bit_set): Define only if SIGIO.
6014 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6015 (send_process): Repair possible setjmp clobbering.
6016
efc736d3
PE
6017 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6018
4e2fe2e6
PE
6019 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6020
f97334a2
PE
6021 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6022
4e75f29d
PE
6023 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6024 Define only if needed.
6025
90efadd1
PE
6026 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6027 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6028 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6029
3c647824
PE
6030 * dispextern.h (struct redisplay_interface): Rename param
6031 to avoid shadowing.
e264f262 6032 * termhooks.h (struct terminal): Likewise.
761383f4 6033 * xterm.c (xembed_send_message): Likewise.
3c647824 6034
b58c5c4a
PE
6035 * insdel.c (make_gap_smaller): Define only if
6036 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6037
cad59032
PE
6038 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6039 it.
6040
c339dc2e
PE
6041 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6042 so that we aren't warned about unused symbols.
6043
91a3e27b
PE
6044 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6045
399c71d3 6046 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6047
8ffc96f5
PE
6048 * xfns.c (x_real_positions): Mark locals as initialized.
6049
eef9bc79
PE
6050 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6051
098db9dd
PE
6052 * xterm.c: Fix problems found by static analysis with other toolkits.
6053 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6054 (x_dispatch_event): Declare static if USE_GTK, and
6055 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6056 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6057 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6058 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6059 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6060
eb18f6cc
PE
6061 * xmenu.c (menu_help_callback): Pointer type fixes.
6062 Use const pointers when pointing at readonly data. Avoid pointer
6063 signedness clashes.
6064 (FALSE): Remove unused macro.
6065 (update_frame_menubar): Remove unused decl.
6066
1fe72bf8
PE
6067 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6068
60d9e1db
PE
6069 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6070 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6071 (single_menu_item): Rename local to avoid shadowing.
6072
39261c26
PE
6073 * keyboard.c (make_lispy_event): Remove unused local var.
6074
018c5e19
PE
6075 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6076 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6077
63d2b86e
PE
6078 * bitmaps: Change bitmaps from unsigned char back to the X11
6079 compatible char. Avoid the old compiler warnings about
6080 out-of-range initializers by using, for example, '\xab' rather
6081 than 0xab.
6082
aefd87e1
PE
6083 * xgselect.c (xgselect_initialize): Check vs interface
6084 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6085
bf501fb9
PE
6086 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6087
e9829fdf
PE
6088 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6089 to read-only memory.
6090
1086c095
PE
6091 * fns.c (vector): Remove; this old hack is no longer needed.
6092
2baccd04 6093 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6094 Remove unused var.
dde42981 6095 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6096
72391843 6097 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6098
436c16df 6099 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6100 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6101 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6102
92bb796d 6103 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6104 (x_term_init): Remove local to avoid shadowing.
92bb796d 6105
764430a3 6106 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6107
6108 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6109 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6110
d1dfb56c
EZ
61112011-04-16 Eli Zaretskii <eliz@gnu.org>
6112
c4354cb4
EZ
6113 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6114
d1dfb56c
EZ
6115 Fix regex.c, syntax.c and friends for buffers > 2GB.
6116 * syntax.h (struct gl_state_s): Declare character position members
6117 EMACS_INT.
6118
6119 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6120
04f2d78b
CB
6121 * textprop.c (verify_interval_modification, interval_of):
6122 Declare arguments EMACS_INT.
d1dfb56c
EZ
6123
6124 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6125 EMACS_INT.
6126
6127 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6128
6129 * indent.c (Fvertical_motion): Local variable it_start is now
6130 EMACS_INT.
6131
6132 * regex.c (re_match, re_match_2, re_match_2_internal)
6133 (bcmp_translate, regcomp, regexec, print_double_string)
6134 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6135 (re_compile_pattern, re_exec): Declare arguments and local
6136 variables `size_t' and `ssize_t' and return values `regoff_t', as
6137 appropriate.
6138 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6139 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6140 <compile_stack_type>: `size' and `avail' are now `size_t'.
6141
6142 * regex.h <regoff_t>: Use ssize_t, not int.
6143 (re_search, re_search_2, re_match, re_match_2): Arguments that
6144 specify buffer/string position and length are now ssize_t and
6145 size_t. Return type is regoff_t.
6146
613052cd
BK
61472011-04-16 Ben Key <bkey76@gmail.com>
6148
6149 * nsfont.m: Fixed bugs in ns_get_family and
6150 ns_descriptor_to_entity that were caused by using free to
6151 deallocate memory blocks that were allocated by xmalloc (via
6152 xstrdup). This caused Emacs to crash when compiled with
6153 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6154 --enable-checking=xmallocoverrun). xfree is now used to
6155 deallocate these memory blocks.
6156
4170f62f 61572011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6158
71b41406
PE
6159 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6160
9587a89d
PE
6161 emacs_write: Accept and return EMACS_INT for sizes.
6162 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6163 et seq.
6164 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6165 Accept and return EMACS_INT.
6166 (emacs_gnutls_write): Return the number of bytes written on
6167 partial writes.
6168 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6169 (emacs_read, emacs_write): Remove check for negative size, as the
6170 Emacs source code has been audited now.
9587a89d
PE
6171 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6172 (emacs_read, emacs_write): Use it.
273a5f82
PE
6173 * process.c (send_process): Adjust to the new signatures of
6174 emacs_write and emacs_gnutls_write. Do not attempt to store
6175 a byte offset into an 'int'; it might overflow.
9587a89d 6176 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6177
3e047f51
PE
6178 * sound.c: Don't assume sizes fit in 'int'.
6179 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6180 Return EMACS_INT, not int.
3e047f51 6181 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6182 Accept EMACS_INT, not int.
6183 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6184 record read return values.
6185
cc39a9db
BK
61862011-04-15 Ben Key <bkey76@gmail.com>
6187
c9d0ec6d
JB
6188 * keyboard.c (Qundefined): Don't declare static since it is used
6189 in nsfns.m.
6190 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6191 static since they are used in nsfont.m.
cc39a9db 6192
6c60eb9f
SM
61932011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6194
6195 * process.c (Qprocessp): Don't declare static.
6196 * lisp.h (Qprocessp): Declare again.
6197
7990b61a
JB
61982011-04-15 Juanma Barranquero <lekktu@gmail.com>
6199
6200 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6201
5d4cb038
PE
62022011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6203
8bd7b830 6204 Improve C-level modularity by making more things 'static'.
cd64ea1d 6205
e3b27b31
PE
6206 Don't publish debugger-only interfaces to other modules.
6207 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6208 (verify_bytepos, count_markers): Move decls to the only modules
6209 that need them.
6210 * region-cache.h (pp_cache): Likewise.
6211 * window.h (check_all_windows): Likewise.
6212 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6213
5d4cb038
PE
6214 * sysdep.c (croak): Now static, if
6215 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6216 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6217
6218 * alloc.c (refill_memory_reserve): Now static if
6219 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6220 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6221
e87b6180
PE
6222 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6223 Define only if USE_LUCID.
6224
ac64929e
PE
6225 * xrdb.c (x_customization_string, x_rm_string): Now static.
6226
6f37259d
PE
6227 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6228 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6229
1683e3ab
PE
6230 * xdisp.c (draw_row_with_mouse_face): Now static.
6231 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6232
de9c2632
PE
6233 * window.h (check_all_windows): Mark externally visible.
6234
2b96acb7
PE
6235 * window.c (window_deletion_count): Now static.
6236
6237 * undo.c: Make symbols static if they're not exported.
6238 (last_undo_buffer, last_boundary_position, pending_boundary):
6239 Now static.
6240
50436f33
PE
6241 * textprop.c (interval_insert_behind_hooks): Now static.
6242 (interval_insert_in_front_hooks): Likewise.
6243
64520e5c
PE
6244 * term.c: Make symbols static if they're not exported.
6245 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6246 (max_frame_lines, tty_set_terminal_modes):
6247 (tty_reset_terminal_modes, tty_turn_off_highlight):
6248 (get_tty_terminal): Now static.
6249 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6250 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6251 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6252 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6253 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6254
1fa53021
PE
6255 * sysdep.c: Make symbols static if they're not exported.
6256 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6257 Now static.
6258 (sigprocmask_set, full_mask): Remove; unused.
6259 (wait_debugging): Mark as visible.
6260 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6261 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6262
d4b43b22
PE
6263 * syntax.c (syntax_temp): Define only if !__GNUC__.
6264
b7c513d0
PE
6265 * sound.c (current_sound_device, current_sound): Now static.
6266
989b29ad
PE
6267 * search.c (searchbufs, searchbuf_head): Now static.
6268
13a55a78
PE
6269 * scroll.c (scroll_cost): Remove; unused.
6270 * dispextern.h (scroll_cost): Remove decl.
6271
de68a1fc
PE
6272 * region-cache.h (pp_cache): Mark as externally visible.
6273
40ccffa6
PE
6274 * process.c: Make symbols static if they're not exported.
6275 (process_tick, update_tick, create_process, chan_process):
6276 (Vprocess_alist, proc_buffered_char, datagram_access):
6277 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6278 (deactivate_process): Mark defn as static, as well as decl.
6279 * lisp.h (create_process): Remove decl.
6280 * process.h (chan_process, Vprocess_alist): Remove decls.
6281
ad64fc97
PE
6282 * print.c: Make symbols static if they're not exported.
6283 (print_depth, new_backquote_output, being_printed, print_buffer):
6284 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6285 (print_interval, print_number_index, initial_stderr_stream):
6286 Now static.
6287 * lisp.h (Fprinc): Remove decl.
6288 (debug_output_compilation_hack): Mark as externally visible.
6289
adddb265
PE
6290 * sysdep.c (croak): Move decl from here to syssignal.h.
6291 * syssignal.h (croak): Put it here, so the API can be checked when
6292 'croak' is called from dissociate_if_controlling_tty.
6293
1717ede2
PE
6294 * minibuf.c: Make symbols static if they're not exported.
6295 (minibuf_save_list, choose_minibuf_frame): Now static.
6296 * lisp.h (choose_minibuf_frame): Remove decl.
6297
fa5fb2bc
PE
6298 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6299
1e3890d1
PE
6300 * lread.c: Make symbols static if they're not exported.
6301 (read_objects, initial_obarray, oblookup_last_bucket_number):
6302 Now static.
6303 (make_symbol): Remove; unused.
6304 * lisp.h (initial_obarray, make_symbol): Remove decls.
6305
8a1414fa
PE
6306 * keyboard.c: Make symbols static if they're not exported.
6307 (single_kboard, recent_keys_index, total_keys, recent_keys):
6308 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6309 (this_single_command_key_start, echoing, last_auto_save):
6310 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6311 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6312 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6313 (Vlispy_mouse_stem, double_click_count):
6314 Now static.
6315 (force_auto_save_soon): Define only if SIGDANGER.
6316 (ignore_mouse_drag_p): Now static if
6317 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6318 (print_help): Remove; unused.
6319 (stop_character, last_timer_event): Mark as externally visible.
6320 * keyboard.h (ignore_mouse_drag_p): Declare only if
6321 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6322 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6323 * lisp.h (echoing): Remove decl.
6324 (force_auto_save_soon): Declare only if SIGDANGER.
6325 * xdisp.c (redisplay_window): Simplify code, to make it more
6326 obvious that ignore_mouse_drag_p is not accessed if !defined
6327 USE_GTK && !defined HAVE_NS.
6328
93ea6e8f
PE
6329 * intervals.c: Make symbols static if they're not exported.
6330 (merge_properties_sticky, merge_interval_right, delete_interval):
6331 Now static.
6332 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6333
77382fcc
PE
6334 * insdel.c: Make symbols static if they're not exported.
6335 However, leave prepare_to_modify_buffer alone. It's never
6336 called from outside this function, but that appears to be a bug.
6337 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6338 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6339 (adjust_after_replace_noundo): Remove; unused.
6340 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6341 (signal_before_change): Remove decls.
77382fcc 6342
9306c32e
PE
6343 * indent.c (val_compute_motion, val_vmotion): Now static.
6344
cd44d2eb
PE
6345 * image.c: Make symbols static if they're not exported.
6346 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6347 if USE_GTK.
6348 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6349 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6350
ad9a7a06
PE
6351 * fringe.c (standard_bitmaps): Now static.
6352 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6353
81626931
PE
6354 * frame.c: Make symbols static if they're not exported.
6355 (x_report_frame_params, make_terminal_frame): Now static.
6356 (get_frame_param): Now static, unless HAVE_NS.
6357 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6358 (x_get_resource_string): Remove; not used.
6359 * frame.h (make_terminal_frame, x_report_frame_params):
6360 (x_get_resource_string); Remove decls.
6361 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6362 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6363
239f9db9
PE
6364 * font.c, fontset.c: Make symbols static if they're not exported.
6365 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6366 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6367 * font.c (font_close_object): Now static.
6368 * font.h (font_close_object): Remove.
6369 * fontset.c (FONTSET_OBJLIST): Remove.
6370 (free_realized_fontset) #if-0 the body, which does nothing.
6371 (face_suitable_for_char_p): #if-0, as it's never called.
6372 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6373 * xfaces.c (face_at_string_position):
6374 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6375 since 0 is always ASCII.
6376
dfcf3579
PE
6377 * fns.c (weak_hash_tables): Now static.
6378
5045092b
PE
6379 * fileio.c: Make symbols static if they're not exported.
6380 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6381 (Vwrite_region_annotation_buffers): Now static.
6382
57a96f5c
PE
6383 * eval.c: Make symbols static if they're not exported.
6384 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6385 * lisp.h (backtrace_list): Remove decl.
6386
35f08c38
PE
6387 * emacs.c: Make symbols static if they're not exported.
6388 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6389 (fatal_error_code, fatal_error_signal_hook, standard_args):
6390 Now static.
6391 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6392 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6393 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6394 * lisp.h (fatal_error_signal_hook): Remove decl.
6395 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6396
f44bd759
PE
6397 * editfns.c: Move a (normally-unused) function to its only use.
6398 * editfns.c, lisp.h (get_operating_system_release): Remove.
6399 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6400 worth the hassle of breaking this out.
6401
b532497d
PE
6402 * xterm.c: Make symbols static if they're not exported.
6403 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6404 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6405 (x_destroy_window, x_delete_display):
6406 Now static.
6407 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6408 (x_mouse_leave): Remove; unused.
6409 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6410 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6411 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6412 Remove decls.
6413 (x_mouse_leave): Declare only if WINDOWSNT.
6414 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6415 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6416 USE_X_TOOLKIT.
6417
1675728f
PE
6418 * ftxfont.c: Make symbols static if they're not exported.
6419 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6420 HAVE_FREETYPE.
6421 * font.h (ftxfont_driver): Likewise.
6422
e4cebfca
PE
6423 * xfns.c: Make symbols static if they're not exported.
6424 (x_last_font_name, x_display_info_for_name):
6425 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6426 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6427 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6428 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6429 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6430 (last_show_tip_args): Now static.
6431 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6432 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6433 (x_screen_planes): Remove; unused.
6434 * dispextern.h (x_screen_planes): Remove decl.
6435
5bf46f05
PE
6436 * dispnew.c: Make symbols static if they're not exported.
6437 * dispextern.h (redraw_garbaged_frames, scrolling):
6438 (increment_row_positions): Remove.
6439 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6440 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6441 Now static.
6442 (redraw_garbaged_frames): Remove; unused.
6443
435f4c28
PE
6444 * xfaces.c: Make symbols static if they're not exported.
6445 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6446 Remove decls.
6447 * xterm.h (defined_color): Remove decls.
6448 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6449 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6450 (menu_face_changed_default, defined_color, free_realized_face):
6451 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6452 (ascii_face_of_lisp_face): Remove; unused.
6453
8524aef3
PE
6454 * xdisp.c: Make symbols static if they're not exported.
6455 * dispextern.h (scratch_glyph_row, window_box_edges):
6456 (glyph_to_pixel_coords, set_cursor_from_row):
6457 (get_next_display_element, set_iterator_to_next):
6458 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6459 (show_mouse_face): Remove decls
6460 * frame.h (message_buf_print): Likewise.
6461 * lisp.h (pop_message, set_message, check_point_in_composition):
6462 Likewise.
6463 * xterm.h (set_vertical_scroll_bar): Likewise.
6464 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6465 (message_buf_print, scratch_glyph_row, displayed_buffer):
6466 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6467 (get_next_display_element, show_mouse_face, window_box_edges):
6468 (frame_to_window_pixel_xy, check_point_in_composition):
6469 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6470 (glyph_to_pixel_coords): Remove; unused.
6471
16390cd2
PE
6472 * dired.c (file_name_completion): Now static.
6473
6474 * dbusbind.c (xd_in_read_queued_messages): Now static.
6475
a25f4dfa
PE
6476 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6477 * data.c (circular_list_error): Remove.
6478
14a9c8df
PE
6479 * commands.h (last_point_position, last_point_position_buffer):
6480 (last_point_position_window): Remove decls.
6481 * keyboard.c: Make these variables static.
6482
04f2d78b
CB
6483 * coding.h (coding, code_convert_region, encode_coding_gap):
6484 Remove decls.
74ab6df5
PE
6485 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6486 (iso_code_class, detect_coding, code_convert_region): Now static.
6487 (encode_coding_gap): Remove; unused.
6488
38dfbee1
PE
6489 * chartab.c (chartab_chars, chartab_bits): Now static.
6490
a2cb4e63
PE
6491 * charset.h (charset_iso_8859_1): Remove decl.
6492 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6493 Now static.
6494
127198fd
PE
6495 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6496 * ccl.c (Vccl_program_table): Now static.
6497 (check_ccl_update): Remove; unused.
6498
d85b608f
PE
6499 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6500 * category.h: ... from here.
6501 * category.c (check_category_table, set_category_set): Now static.
6502
31cd66f3
PE
6503 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6504 * lisp.h: Remove these decls.
6505
c358e587
PE
6506 * buffer.c (buffer_count): Remove unused var.
6507
e78aecca
PE
6508 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6509 so that it's not optimized away.
6510 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6511 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6512 exported only to the debugger.
6513
e192d7d3 6514 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6515 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6516
92470028
PE
6517 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6518 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6519 was inaccessible from Lisp.
6520 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6521 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6522
244ed907
PE
6523 alloc.c: Import and export fewer symbols, and remove unused items.
6524 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6525 is defined.
6526 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6527 it's not optimized away by whole-program optimization.
6528 (message_enable_multibyte, free_misc): Remove.
6529 (catchlist, handlerlist, mark_backtrace):
6530 Declare only if BYTE_MARK_STACK.
6531 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6532 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6533 (message_enable_multibyte): Remove decl.
6534 (free_misc, interval_free_list, float_block, float_block_index):
6535 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6536 (cons_free_list, last_marked_index):
6537 Now static.
6538 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6539 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6540 (mark_backtrace): Define only if BYTE_MARK_STACK.
6541 * xdisp.c (message_enable_multibyte): Now static.
6542
61c2b50e 6543 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6544 This makes it easier for human readers (and static analyzers)
6545 to see whether these variables are used from other modules.
6546 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6547 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6548 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6549 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6550 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6551 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6552 * xmenu.c, xselect.c:
6553 Declare Q* vars static if they are not used in other modules.
6554 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6555 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6556 Remove decls of unexported vars.
6557 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6558
95c82688
PE
6559 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6560
16a97296
PE
6561 Make Emacs functions such as Fatom 'static' by default.
6562 This makes it easier for human readers (and static analyzers)
6563 to see whether these functions can be called from other modules.
6564 DEFUN now defines a static function. To make the function external
6565 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6566 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6567 (Finit_image_library):
16a97296
PE
6568 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6569 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6570 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6571 Remove decls, since these functions are now static.
6572 (Funintern, Fget_internal_run_time): New decls, since these functions
6573 were already external.
95c82688 6574
16a97296
PE
6575 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6576 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6577 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6578 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6579 * keyboard.c, keymap.c, lread.c:
6580 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6581 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6582 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6583 Mark functions with DEFUE instead of DEFUN,
6584 if they are used in other modules.
6585 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6586 decls for now-static functions.
6587 * buffer.h (Fdelete_overlay): Remove decl.
6588 * callproc.c (Fgetenv_internal): Mark as internal.
6589 * composite.c (Fremove_list_of_text_properties): Remove decl.
6590 (Fcomposition_get_gstring): New forward static decl.
6591 * composite.h (Fcomposite_get_gstring): Remove decl.
6592 * dired.c (Ffile_attributes): New forward static decl.
6593 * doc.c (Fdocumntation_property): New forward static decl.
6594 * eval.c (Ffetch_bytecode): New forward static decl.
6595 (Funintern): Remove extern decl; now in .h file where it belongs.
6596 * fileio.c (Fmake_symbolic_link): New forward static decl.
6597 * image.c (Finit_image_library): New forward static decl.
6598 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6599 * intervals.h (Fprevious_property_change):
6600 (Fremove_list_of_text_properties): Remove decls.
6601 * keyboard.c (Fthis_command_keys): Remove decl.
6602 (Fcommand_execute): New forward static decl.
6603 * keymap.c (Flookup_key): New forward static decl.
6604 (Fcopy_keymap): Now static.
6605 * keymap.h (Flookup_key): Remove decl.
6606 * process.c (Fget_process): New forward static decl.
6607 (Fprocess_datagram_address): Mark as internal.
6608 * syntax.c (Fsyntax_table_p): New forward static decl.
6609 (skip_chars): Remove duplicate decl.
6610 * textprop.c (Fprevious_property_change): New forward static decl.
6611 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6612 Now internal.
6613 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6614 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6615
785bbd42
PE
6616 * editfns.c (Fformat): Remove unreachable code.
6617
8b913b57
AS
66182011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6619
6620 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6621 change. (Bug#8496)
6622
a6744a35
EZ
66232011-04-13 Eli Zaretskii <eliz@gnu.org>
6624
6625 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6626 when at ZV. (Bug#8487)
6627
e7974947
AS
66282011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6629
baad03f0
AS
6630 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6631 (Bug#8437)
6632 * keyboard.c (parse_tool_bar_item): Likewise.
6633 * sound.c (sound_cleanup, alsa_close): Likewise.
6634 * termcap.c (tgetent): Likewise.
6635 * xfns.c (x_default_font_parameter): Likewise.
6636 * xsettings.c (read_and_apply_settings): Likewise.
6637
e7974947
AS
6638 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6639 (overrun_check_free): Protoize.
6640
28272684
PE
66412011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6642
6643 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6644 since callers should never pass a negative size.
6645 Change the signature to match that of plain 'read' and 'write'; see
6646 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6647 * lisp.h: Update prototypes of emacs_write and emacs_read.
6648
11997c76
EZ
66492011-04-11 Eli Zaretskii <eliz@gnu.org>
6650
6651 * xdisp.c (redisplay_window): Don't try to determine the character
6652 position of the scroll margin if the window start point w->startp
e896f03c 6653 is outside the buffer's accessible region. (Bug#8468)
11997c76 6654
8a2cbd72
EZ
66552011-04-10 Eli Zaretskii <eliz@gnu.org>
6656
6657 Fix write-region and its subroutines for buffers > 2GB.
6658 * fileio.c (a_write, e_write): Modify declaration of arguments and
6659 local variables to support buffers larger than 2GB.
6660 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6661
6662 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6663 argument, local variables, and return value.
6664
6665 * lisp.h: Update prototypes of emacs_write and emacs_read.
6666
6667 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6668
4073e537 66692011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6670
1ebfdcb6
PE
6671 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6672
b2ded58d
PE
6673 Fix more problems found by GCC 4.6.0's static checks.
6674
7d66342c
PE
6675 * xdisp.c (vmessage): Use a better test for character truncation.
6676
bbf47d44
PE
6677 * charset.c (load_charset_map): <, not <=, for optimization,
6678 and to avoid potential problems with integer overflow.
9248994d 6679 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6680 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6681 * editfns.c (Fformat): Likewise.
1e69125e 6682 * syntax.c (skip_chars): Likewise.
3befa583 6683
e3019616
PE
6684 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6685 This also lets GCC 4.6.0 generate slightly better loop code.
6686
becfa255
PE
6687 * callint.c (Fcall_interactively): <, not <=, for optimization.
6688 (Fcall_interactively): Count the number of arguments produced,
6689 not the number of arguments given. This is simpler and lets GCC
6690 4.6.0 generate slightly better code.
6691
dae0cd48
PE
6692 * ftfont.c: Distingish more carefully between FcChar8 and char.
6693 The previous code passed unsigned char * to a functions like
6694 strlen and xstrcasecmp that expect char *, which does not
6695 conform to the C standard.
6696 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6697 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6698 char * when the C standard requires it.
6699
76032d70
PE
6700 * keyboard.c (read_char): Remove unused var.
6701
eb3f1cc8
PE
6702 * eval.c: Port to Windows vsnprintf (Bug#8435).
6703 Include <limits.h>.
6704 (SIZE_MAX): Define if the headers do not.
6705 (verror): Do not give up if vsnprintf returns a negative count.
6706 Instead, grow the buffer. This ports to Windows vsnprintf, which
6707 does not conform to C99. Problem reported by Eli Zaretskii.
6708 Also, simplify the allocation scheme, by avoiding the need for
6709 calling realloc, and removing the ALLOCATED variable.
6710
70476b54
PE
6711 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6712
12020a9e
PE
6713 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6714 But keep the doprint source code for now, as we might revamp it
6715 and use it again (Bug#8435).
ea6c7ae6
PE
6716 * lisp.h (doprnt): Remove.
6717 * Makefile.in (base_obj): Remove doprnt.o.
6718 * deps.mk (doprnt.o): Remove.
6719
5fdb398c
PE
6720 error: Print 32- and 64-bit integers portably (Bug#8435).
6721 Without this change, on typical 64-bit hosts error ("...%d...", N)
6722 was used to print both 32- and 64-bit integers N, which relied on
6723 undefined behavior.
6724 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6725 New macro.
6726 * lisp.h (error, verror): Mark as printf-like functions.
6727 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6728 Report overflow in size calculations when allocating printf buffer.
6729 Do not truncate output string at its first null byte.
6730 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6731 Truncate the output at a character boundary, since vsnprintf does not
6732 do that.
6733 * charset.c (check_iso_charset_parameter): Convert internal
6734 character to string before calling 'error', since %c now has the
6735 printf meaning.
6736 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6737 overflow when computing char to be passed to 'error'. Do not
6738 pass Lisp_Object to 'error'; pass the integer instead.
6739 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6740 formatted with plain %d.
6741
b189fa66
PE
6742 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6743
bff87ef0
PE
6744 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6745
7e2cac20
PE
6746 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6747
ce4d90b5
PE
6748 * xterm.c (x_catch_errors): Remove duplicate declaration.
6749
266c9547
PE
6750 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6751
79c49ad2
PE
6752 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6753
368f4090
JM
67542011-04-10 Jim Meyering <meyering@redhat.com>
6755
6756 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6757 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6758 return ssize_t not "int", and use size_t as the buffer length.
6759 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6760 * gnutls.h: Update declarations.
6761 * process.c (read_process_output): Use ssize_t, to match.
6762 (send_process): Likewise.
6763
a32d4040
CY
67642011-04-09 Chong Yidong <cyd@stupidchicken.com>
6765
6766 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6767
8546720e 67682011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6769
04f2d78b
CB
6770 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6771 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6772
8546720e
GM
6773 * xterm.c (handle_one_xevent):
6774 * xmenu.c (create_and_show_popup_menu):
6775 * xselect.c (x_decline_selection_request)
6776 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6777
0a2f5c1a 67782011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6779
6780 Fix some uses of `int' instead of EMACS_INT.
6781 * search.c (string_match_1, fast_string_match)
6782 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6783 (scan_buffer, find_next_newline_no_quit)
6784 (find_before_next_newline, search_command, Freplace_match)
6785 (Fmatch_data): Make some `int' variables be EMACS_INT.
6786
6787 * xdisp.c (display_count_lines): 3rd argument and return value now
6788 EMACS_INT. All callers changed.
6789 (pint2hrstr): Last argument is now EMACS_INT.
6790
6791 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6792 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6793 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6794 (decode_coding_utf_16, decode_coding_emacs_mule)
6795 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6796 (decode_coding_ccl, decode_coding_charset)
6797 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6798 (decode_coding_iso_2022, decode_coding_emacs_mule)
6799 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6800 <char_offset, last_offset>: Declare EMACS_INT.
6801 (encode_coding_utf_8, encode_coding_utf_16)
6802 (encode_coding_emacs_mule, encode_invocation_designation)
6803 (encode_designation_at_bol, encode_coding_iso_2022)
6804 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6805 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6806 Declare EMACS_INT.
6807 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6808 (encode_invocation_designation): Last argument P_NCHARS is now
6809 EMACS_INT.
6810 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6811 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6812
6813 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6814 All users changed.
6815
6816 * ccl.c (Fccl_execute_on_string): Declare some variables
6817 EMACS_INT.
6818
8546720e 68192011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6820
6821 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6822
4e19a977
CS
68232011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6824
6825 * process.c (Fformat_network_address): Doc fix.
6826
87302331
R
68272011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6828
6829 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6830
cbb59342
CY
68312011-04-08 Chong Yidong <cyd@stupidchicken.com>
6832
6833 * keyboard.c (read_char): Call Lisp function help-form-show,
6834 instead of using internal_with_output_to_temp_buffer.
6835 (Qhelp_form_show): New var.
e0d38eeb 6836 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6837
6838 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6839
6840 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6841
e67a13ab
CY
68422011-04-06 Chong Yidong <cyd@stupidchicken.com>
6843
04f2d78b
CB
6844 * process.c (Flist_processes): Remove to Lisp.
6845 (list_processes_1): Delete.
e67a13ab 6846
973f782d
EZ
68472011-04-06 Eli Zaretskii <eliz@gnu.org>
6848
7c106b1e
EZ
6849 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6850
973f782d
EZ
6851 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6852
41cf7d1a 68532011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6854
ca23cc88
PE
6855 Fix more problems found by GCC 4.6.0's static checks.
6856
f390e2d5
PE
6857 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6858
42eea0d0
PE
6859 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6860
b69769da 6861 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6862
f9541e84
PE
6863 * xdisp.c (vmessage): Mark as a printf-like function.
6864
13841b55
PE
6865 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6866
c136c10f
PE
6867 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6868
5e2d4a30
PE
6869 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6870 printf-like functions.
6871 (tiff_load): Add casts to remove these marks before passing them
6872 to system-supplied API.
6873
583f48b9
PE
6874 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6875
b25d760e
PE
6876 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6877 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6878 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6879 directly, rather than having caller test rule sign. This avoids
6880 some unnecessary tests.
6881 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6882 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6883 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6884
bc7b6697 6885 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6886 (xfont_open): Avoid unnecessary tests.
bc7b6697 6887
27ccc379
PE
6888 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6889
dcd5c89a
PE
6890 * composite.h, composite.c (composition_gstring_put_cache):
6891 Use EMACS_INT, not int, for length.
6892
b13a45c6
PE
6893 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6894 breaking out part of COMPOSITION_DECODE_RULE.
6895 (COMPOSITION_DECODE_RULE): Use it.
6896 * composite.c (get_composition_id): Remove unused local vars,
6897 by using the new macro.
6898
1e792e4d
PE
6899 * textprop.c (set_text_properties_1): Change while to do-while,
6900 since the condition is always true at first.
6901
dc6c6455 6902 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6903 (interval_deletion_adjustment): Return unsigned value.
6904 All uses changed.
dc6c6455 6905
aba7731a
PE
6906 * process.c (list_processes_1, create_pty, read_process_output):
6907 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6908 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6909 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6910 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6911 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6912
fdfc4bf3
PE
6913 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6914
fca8fe46 6915 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6916 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6917
06a0259a 6918 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6919 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6920 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6921
e7b9e80f
PE
6922 * print.c (print_error_message): Avoid int overflow.
6923
56201685
PE
6924 * font.c (font_list_entities): Redo for clarity,
6925 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6926
78834453 6927 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6928 (font_score): Avoid potential overflow in diff calculation.
78834453 6929
0bc0b309 6930 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6931 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6932
e610eaca
PE
6933 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6934
b895abce
PE
6935 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6936 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6937 can always succeed if overflow has undefined behavior.
6938
1f1d9321 6939 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6940 (wordify): Omit three unnecessary tests.
1f1d9321 6941
c59478bc
PE
6942 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6943 All callers changed. This avoids the need for an unused var.
6944
79b73827
PE
6945 * casefiddle.c (casify_region): Remove var that is set but not used.
6946
a4db5dfe
PE
6947 * dired.c (file_name_completion): Remove var that is set but not used.
6948
43aae36e
PE
6949 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6950
2a47c44d 6951 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6952 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6953
a37c69bf
PE
6954 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6955 Check for integer overflow on size calculations.
6956
328ab8e7
PE
6957 * buffer.c (Fprevious_overlay_change): Remove var that is set
6958 but not used.
6959
e5a2a5cb
PE
6960 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6961 Remove vars that are set but not used.
8d84a6eb 6962 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6963 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6964
a60e5f68
PE
6965 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6966
f661cb61 6967 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6968 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6969
f0397f5a
PE
6970 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6971 that are set but not used.
6972
8664db06 6973 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6974 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6975
6abdaa4a
PE
6976 * xselect.c (x_get_local_selection, x_handle_property_notify):
6977 Remove vars that are set but not used.
6978
0ce7538d 6979 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6980 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6981
9ae848fc
PE
6982 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6983 Remove var that is set but not used.
0b918413
PE
6984 (scroll_bar_windows_size): Now size_t, not int.
6985 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6986 Check for overflow.
9ae848fc 6987
a5a62657
PE
6988 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6989 (map_tty_color) [!defined MSDOS]: Likewise.
6990
5c5cdd39
PE
6991 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6992
66ebf983
PE
6993 * coding.c: Remove vars that are set but not used.
6994 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6995 All callers changed.
6996 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6997 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6998 (decode_coding_charset): Remove vars that are set but not used.
6999
1be4d761
PE
7000 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7001 that is set but not used.
7002
47553fa8
PE
7003 * print.c (print_object): Remove var that is set but not used.
7004
1f7196bf 7005 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7006 The gnulib version avoids calling malloc in the usual case,
7007 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7008 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7009 * filelock.c (current_lock_owner): Likewise.
7010 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7011 * sysdep.c: Include allocator.h, careadlinkat.h.
7012 (emacs_no_realloc_allocator): New static constant.
7013 (emacs_readlink): New function.
fdb61804
PE
7014 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7015 ../lib/careadlinkat.h.
d1fdcab7 7016
f84c17c7
SM
70172011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7018
7019 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7020 first non-nil return value).
7021
ef3862ad
JD
70222011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7023
7024 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7025 if not defined (Bug#8403).
7026
376a7006
JB
70272011-04-02 Juanma Barranquero <lekktu@gmail.com>
7028
7029 * xdisp.c (display_count_lines): Remove parameter `start',
7030 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7031 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7032 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7033 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7034 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7035 and thereabouts. All callers changed.
7036 (get_per_char_metric): Remove parameter `f', unused since
7037 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7038
6ca3801d
JM
70392011-04-02 Jim Meyering <meyering@redhat.com>
7040
7041 do not dereference NULL upon failed strdup
7042 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7043 (ns_get_family): Likewise.
7044
d8e2b5ba
JB
70452011-04-02 Juanma Barranquero <lekktu@gmail.com>
7046
7047 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7048
8c74fcbd
JD
70492011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7050
7051 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7052 later (Bug#8403).
7053
7200d79c
SM
70542011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7055
03408648 7056 Add lexical binding.
7200d79c 7057
03408648
SM
7058 * window.c (Ftemp_output_buffer_show): New fun.
7059 (Fsave_window_excursion):
7060 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7061
7062 * lread.c (lisp_file_lexically_bound_p): New function.
7063 (Fload): Bind Qlexical_binding.
7064 (readevalloop): Remove `evalfun' arg.
7065 Bind Qinternal_interpreter_environment.
7066 (Feval_buffer): Bind Qlexical_binding.
7067 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7068 Mark as dynamic.
7069 (syms_of_lread): Declare `lexical-binding'.
7070
7071 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7072
7073 * keyboard.c (eval_dyn): New fun.
7074 (menu_item_eval_property): Use it.
ca105506
SM
7075
7076 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7077
03408648
SM
7078 * fns.c (concat, mapcar1): Accept byte-code-functions.
7079
7080 * eval.c (Fsetq): Handle lexical vars.
7081 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7082 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7083 (FletX, Flet): Obey lexical binding.
7084 (Fcommandp): Handle closures.
7085 (Feval): New `lexical' arg.
7086 (eval_sub): New function extracted from Feval. Use it almost
7087 everywhere where Feval was used. Look up vars in lexical env.
7088 Handle closures.
7089 (Ffunctionp): Move from subr.el.
7090 (Ffuncall): Handle closures.
7091 (apply_lambda): Remove `eval_flags'.
7092 (funcall_lambda): Handle closures and new byte-code-functions.
7093 (Fspecial_variable_p): New function.
7094 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7095 but without exporting it to Lisp.
23aba0ea 7096
23aba0ea 7097 * doc.c (Fdocumentation, store_function_docstring):
03408648 7098 * data.c (Finteractive_form): Handle closures.
23aba0ea 7099
03408648
SM
7100 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7101 interactive spec.
ba83908c 7102
04f2d78b
CB
7103 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7104 New byte-codes.
03408648
SM
7105 (exec_byte_code): New function extracted from Fbyte_code to handle new
7106 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7107
03408648 7108 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7109
03408648 7110 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7111
e2abce01
JB
71122011-03-31 Juanma Barranquero <lekktu@gmail.com>
7113
7114 * xdisp.c (redisplay_internal): Fix prototype.
7115
63696a73 71162011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7117
63696a73 7118 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7119 (try_scrolling): Use it when setting scroll_limit.
7120 Limit scrolling to 100 screen lines.
63696a73
EZ
7121 (redisplay_window): Even when falling back on "recentering",
7122 position point in the window according to scroll-conservatively,
7123 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7124
7125 (try_scrolling): When point is above the window, allow searching
7126 as far as scroll_max, or one screenful, to compute vertical
7127 distance from PT to the scroll margin position. This prevents
7128 try_scrolling from unnecessarily failing when
7129 scroll-conservatively is set to a value slightly larger than the
7130 window height. Clean up the case of PT below the margin at bottom
7131 of window: scroll_max can no longer be INT_MAX. When aggressive
7132 scrolling is in use, don't let point enter the opposite scroll
7133 margin as result of the scroll.
7134 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7135 threshold of 100 lines for never-recentering scrolling.
7136
e4cc2dfc
JB
71372011-03-31 Juanma Barranquero <lekktu@gmail.com>
7138
7139 * dispextern.h (move_it_by_lines):
7140 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7141 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7142 (message_log_check_duplicate): Remove parameters `prev_bol' and
7143 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7144 (redisplay_internal): Remove parameter `preserve_echo_area',
7145 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7146
7147 * indent.c (Fvertical_motion):
7148 * window.c (window_scroll_pixel_based, Frecenter):
7149 Don't pass `need_y_p' to `move_it_by_lines'.
7150
1c470562
SM
71512011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7152
44f230aa
SM
7153 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7154 steal a few bits to be more compact.
7155 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7156 Remove unneeded casts.
7157
1c470562
SM
7158 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7159
888adce9
ZK
71602011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7161
7162 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7163 binding" message (bug#7967).
7164
f838ed7b
PE
71652011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7166
77861b95
PE
7167 Fix more problems found by GCC 4.6.0's static checks.
7168
de6dbc14
PE
7169 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7170 Remove unused local var.
7171
f838ed7b
PE
7172 * editfns.c (Fmessage_box): Remove unused local var.
7173
792c7b2b
PE
7174 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7175 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7176 Omit unused local vars.
c499e557 7177 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7178 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7179 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7180 Omit unused local var.
7181
ba0165e1
PE
7182 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7183 Don't assume string length fits in int.
32ad8845 7184 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7185 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7186
3c59b4c9
PE
7187 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7188 instead of alloca (Bug#8344).
7189
a3eed478 7190 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7191 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7192
eb4d412d
PE
7193 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7194
1658b401
PE
7195 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7196 concerns.
7197
7198 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7199
7200 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7201
9a2c6e05
PE
7202 * keyboard.c (syms_of_keyboard): Use the same style as later
7203 in this function when indexing through an array. This also
7204 works around GCC bug 48267.
7205
03d0a109
PE
7206 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7207
44f730c8
PE
7208 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7209
fe75f926
PE
7210 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7211 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7212
ffa8c828
PE
7213 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7214 This avoids undefined behavior on integer overflow, and is a bit
7215 more convenient anyway since it is compared to a size_t variable.
7216
c5101a77
PE
7217 Variadic C functions now count arguments with size_t, not int.
7218 This avoids an unnecessary limitation on 64-bit machines, which
7219 caused (substring ...) to crash on large vectors (Bug#8344).
7220 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7221 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7222 All variadic functions and their callers changed accordingly.
c5101a77
PE
7223 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7224 * data.c (arith_driver, float_arith_driver): Likewise.
7225 * editfns.c (general_insert_function): Likewise.
7226 * eval.c (struct backtrace.nargs, interactive_p)
7227 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7228 (funcall_lambda, mark_backtrace): Likewise.
7229 * fns.c (concat): Likewise.
7230 * frame.c (x_set_frame_parameters): Likewise.
7231 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7232 0 if not found, not -1. All callers changed.
7233
dd3f25f7
PE
7234 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7235 (stack_copy_size): Now size_t, not int.
7236 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7237
461c2ab9
JB
72382011-03-28 Juanma Barranquero <lekktu@gmail.com>
7239
7240 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7241 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7242 All callers changed.
7243
7244 * lisp.h (multibyte_char_to_unibyte):
7245 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7246 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7247 * character.h (CHAR_TO_BYTE8):
7248 * cmds.c (internal_self_insert):
7249 * editfns.c (general_insert_function):
7250 * keymap.c (push_key_description):
7251 * search.c (Freplace_match):
7252 * xdisp.c (message_dolog, set_message_1): All callers changed.
7253
f6d62986
SM
72542011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7255
7256 * keyboard.c (safe_run_hook_funcall): New function.
7257 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7258 don't set the hook to nil, but remove the offending function instead.
7259 (Qcommand_hook_internal): Remove, unused.
7260 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7261 Vcommand_hook_internal.
7262
7263 * eval.c (enum run_hooks_condition): Remove.
7264 (funcall_nil, funcall_not): New functions.
7265 (run_hook_with_args): Call each function through a `funcall' argument.
7266 Remove `cond' argument, now redundant.
7267 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7268 (Frun_hook_with_args_until_failure): Adjust accordingly.
7269 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7270
1db5b1ad
JB
72712011-03-28 Juanma Barranquero <lekktu@gmail.com>
7272
7273 * dispextern.h (string_buffer_position): Remove declaration.
7274
7275 * print.c (strout): Remove parameter `multibyte', unused since
7276 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7277
7278 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7279 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7280 All callers changed.
7281
7282 * w32.c (_wsa_errlist): Use braces for struct initializers.
7283
7284 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7285 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7286 All callers changed.
7287 (string_buffer_position): Likewise. Also, make static (it's never
7288 used outside xdisp.c).
7289 (cursor_row_p): Remove parameter `w', unused since
7290 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7291 (decode_mode_spec): Remove parameter `precision', introduced during
7292 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7293 All callers changed.
7294
5ffb62aa
JD
72952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7296
7297 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7298
461c2ab9 72992011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7300
7301 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7302 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7303 (ns_update_auto_hide_menu_bar): New functions.
7304 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7305 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7306 ns_constrain_all_frames.
7307 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7308 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7309
5c380ffb
JD
73102011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7311
7312 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7313
9af30bdf
GM
73142011-03-27 Glenn Morris <rgm@gnu.org>
7315
7316 * syssignal.h: Replace RETSIGTYPE with void.
7317 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7318 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7319 Replace SIGTYPE with void everywhere.
7320 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7321 * s/template.h (SIGTYPE): Remove commented out definition.
7322
e2abce01
JB
73232011-03-26 Eli Zaretskii <eliz@gnu.org>
7324
7325 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7326 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7327
f868cd8a
JB
73282011-03-26 Juanma Barranquero <lekktu@gmail.com>
7329
59eb0929
JB
7330 * w32.c (read_unc_volume): Use parameter `henum', instead of
7331 global variable `wget_enum_handle'.
7332
7333 * keymap.c (describe_vector): Remove parameters `indices' and
7334 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7335 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7336
f868cd8a
JB
7337 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7338
7339 * keyboard.c (timer_check): Remove parameter `do_it_now',
7340 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7341 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7342 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7343
7344 * keyboard.c (read_char):
7345 * w32menu.c (w32_menu_display_help):
7346 * xmenu.c (show_help_event, menu_help_callback):
7347 Adjust calls to `show_help_echo'.
7348
7349 * gtkutil.c (xg_maybe_add_timer):
7350 * keyboard.c (readable_events):
7351 * process.c (wait_reading_process_output):
7352 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7353
7354 * insdel.c (adjust_markers_gap_motion):
7355 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7356 (gap_left, gap_right): Don't call it.
7357
2ecf6fdb
CY
73582011-03-25 Chong Yidong <cyd@stupidchicken.com>
7359
7360 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7361 incurred during fontification.
7362
6b1f9ba4
JB
73632011-03-25 Juanma Barranquero <lekktu@gmail.com>
7364
7365 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7366 (DEFVAR_PER_BUFFER): Don't pass it.
7367
7368 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7369 (scrolling_window): Don't pass it.
7370
0f4a96b5
JB
73712011-03-25 Juanma Barranquero <lekktu@gmail.com>
7372
7373 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7374
7375 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7376 and `suffix'.
7377 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7378 of variables specific to SELinux and computation of `encoded_absname'.
7379
7380 * image.c (XPutPixel): Remove unused variable `height'.
7381
7382 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7383
7384 * unexw32.c (get_section_info): Remove unused variable `section'.
7385
7386 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7387 (system_process_attributes): Remove unused variable `sess'.
7388 (sys_read): Remove unused variable `err'.
7389
7390 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7391 (w32_wnd_proc): Remove unused variable `isdead'.
7392 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7393 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7394 (x_create_tip_frame): Remove unused variable `tem'.
7395
7396 * w32inevt.c (w32_console_read_socket):
7397 Remove unused variable `no_events'.
7398
7399 * w32term.c (x_draw_composite_glyph_string_foreground):
7400 Remove unused variable `width'.
7401
1149507c
JB
74022011-03-24 Juanma Barranquero <lekktu@gmail.com>
7403
7404 * w32term.c (x_set_glyph_string_clipping):
7405 Don't pass uninitialized region to CombineRgn.
7406
9c88f339
JB
74072011-03-23 Juanma Barranquero <lekktu@gmail.com>
7408
7409 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7410 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7411 (Fx_close_connection): Remove unused variable `i'.
7412
7413 * w32font.c (w32font_draw): Return number of glyphs.
7414 (w32font_open_internal): Remove unused variable `i'.
7415 (w32font_driver): Add missing initializer.
7416
7417 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7418 (fill_in_menu): Remove unused variable `items_added'.
7419
7420 * w32term.c (last_mouse_press_frame): Remove static global variable.
7421 (w32_clip_to_row): Remove unused variable `f'.
7422 (x_delete_terminal): Remove unused variable `i'.
7423
7424 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7425 (NOTHING): Remove unused static global variable.
7426 (uniscribe_check_otf): Remove unused variable `table'.
7427 (uniscribe_font_driver): Add missing initializers.
7428
dee091a3
JD
74292011-03-23 Julien Danjou <julien@danjou.info>
7430
7431 * term.c (Fsuspend_tty, Fresume_tty):
7432 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7433 * window.c (temp_output_buffer_show):
7434 * insdel.c (signal_before_change):
7435 * frame.c (Fhandle_switch_frame):
7436 * fileio.c (Fdo_auto_save):
7437 * emacs.c (Fkill_emacs):
7438 * editfns.c (save_excursion_restore):
7439 * cmds.c (internal_self_insert):
7440 * callint.c (Fcall_interactively):
7441 * buffer.c (Fkill_all_local_variables):
7442 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7443 Use Frun_hooks.
0f4a96b5 7444 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7445 unconditionnaly since it does the check itself.
7446
2c520ab5 74472011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7448
c9c49752
PE
7449 Fix more problems found by GCC 4.5.2's static checks.
7450
8abc3f12
PE
7451 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7452 the first time through the loop, since we know p0 < p1 then.
7453 This also avoids a gcc -Wstrict-overflow warning.
7454
a2d26660
PE
7455 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7456 leading to a memory leak, possible in functions like
7457 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7458 of objects (Bug#8318).
a2d26660 7459
916c72e9
PE
7460 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7461 that could (at least in theory) be that large.
7462
19ab8a18
PE
7463 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7464 This is less likely to overflow, and avoids undefined behavior if
7465 overflow does occur. All callers changed. Use strtoul to scan
7466 for the unsigned long integer.
b7cbbd6f
PE
7467 (pint2hrstr): Simplify and tune code slightly.
7468 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7469
f0641eff
PE
7470 * scroll.c (do_scrolling): Work around GCC bug 48228.
7471 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7472
7f650bb9
PE
7473 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7474 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7475 (validate_x_resource_name): Simplify count usage.
7476 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7477
37dd57d1
PE
7478 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7479 fail (Bug#8306).
81e56e61 7480
699979fc 7481 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7482
401bf9b4
PE
7483 * process.c (Fmake_network_process): Use socklen_t, not int,
7484 where POSIX says socklen_t is required in portable programs.
7485 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7486 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7487 (Fmake_network_process, server_accept_connection):
7488 (wait_reading_process_output, read_process_output):
7489 Likewise.
7490
b93aacde
PE
7491 * process.c: Rename or move locals to avoid shadowing.
7492 (list_processes_1, Fmake_network_process):
7493 (read_process_output_error_handler, exec_sentinel_error_handler):
7494 Rename or move locals.
4dc343ee 7495 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7496 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7497 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7498 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7499 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7500
af8a867c 7501 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7502 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7503 Include tparam.h instead, since it declares them.
af8a867c
PE
7504 * cm.h (PC): Remove extern decl; tparam.h now does this.
7505 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7506 * terminfo.c: Include tparam.h, to check interfaces.
7507 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7508 (tparam): Adjust signature to match interface in tparam.h;
7509 this removes some undefined behavior. Check that outstring and len
7510 are zero, which they always are with Emacs.
7511 * tparam.h (PC, BC, UP): New extern decls.
7512
0248044d 7513 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7514 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7515
8ff096c1 7516 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7517 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7518 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7519 (ftfont_list): Remove unused local.
49eaafba
PE
7520 (get_adstyle_property, ftfont_pattern_entity):
7521 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7522 Rename locals to avoid shadowing.
8ff096c1 7523
e2be39f6
PE
7524 * xfont.c (xfont_list_family): Mark var as initialized.
7525
c9735e30
PE
7526 * xml.c (make_dom): Now static.
7527
8f5201ae
PE
7528 * composite.c (composition_compute_stop_pos): Rename local to
7529 avoid shadowing.
b246f932
PE
7530 (composition_reseat_it): Remove unused locals.
7531 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7532 (composition_update_it): Mark var as initialized.
11b61122
PE
7533 (find_automatic_composition): Mark vars as initialized,
7534 with a FIXME (Bug#8290).
8f5201ae 7535
760fbc2c
PE
7536 character.h: Rename locals to avoid shadowing.
7537 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7538 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7539 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7540 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7541 to avoid shadowing.
7542
ff08eb85
PE
7543 * textprop.c (property_change_between_p): Remove; unused.
7544
fc7bf025
PE
7545 * intervals.c (interval_start_pos): Now static.
7546
235d7abc
PE
7547 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7548
44f230aa
SM
7549 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7550 Rename locals to avoid shadowing.
3e7d6594 7551
50060332
PE
7552 * sound.c (wav_play, au_play, Fplay_sound_internal):
7553 Fix pointer signedness.
d01f234b 7554 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7555 (wav_play): Initialize a variable to 0, to prevent undefined
7556 behavior (Bug#8278).
50060332 7557
c4fc4e30
PE
7558 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7559
918436ed
PE
7560 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7561
c939f91b
PE
7562 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7563 clobbering (Bug#8298).
b9c7f648
PE
7564 * sysdep.c (sys_subshell): Likewise.
7565 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7566
6bd8c144
PE
7567 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7568 This should get cleaned up, so that child_setup has the
7569 same signature on all platforms.
7570
7710357c 7571 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7572 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7573
c59da222
CY
75742011-03-22 Chong Yidong <cyd@stupidchicken.com>
7575
7576 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7577 not to be necessary, and produces flickering.
7578
66b87493
GM
75792011-03-20 Glenn Morris <rgm@gnu.org>
7580
7581 * config.in: Remove file.
7582
45b6f6d5
JB
75832011-03-20 Juanma Barranquero <lekktu@gmail.com>
7584
7585 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7586 are now in src/globals.h.
7587 (syms_of_minibuf): Remove spurious & from previous change.
7588
3ec03f7e
LL
75892011-03-20 Leo <sdl.web@gmail.com>
7590
7591 * minibuf.c (completing-read-function): New variable.
7592 (completing-read-default): Rename from completing-read.
7593 (completing-read): Call completing-read-function.
7594
b14e3e21
CY
75952011-03-19 Juanma Barranquero <lekktu@gmail.com>
7596
7597 * xfaces.c (Fx_load_color_file):
7598 Read color file from absolute filename (bug#8250).
7599
f2b726e6
JB
76002011-03-19 Juanma Barranquero <lekktu@gmail.com>
7601
7602 * makefile.w32-in: Update dependencies.
7603
09f6ff02
EZ
76042011-03-17 Eli Zaretskii <eliz@gnu.org>
7605
7606 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7607
29a6015a
PE
76082011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7609
a3a6c54e
PE
7610 Fix more problems found by GCC 4.5.2's static checks.
7611
b766f867
PE
7612 * process.c (make_serial_process_unwind, send_process_trap):
7613 (sigchld_handler): Now static.
7614
be02381c
PE
7615 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7616 That way, the code declares only the vars that it needs.
7617 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7618 * s/cygwin.h (PTY_ITERATION): Likewise.
7619 * s/darwin.h (PTY_ITERATION): Likewise.
7620 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7621
57048744
PE
7622 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7623 * process.c (allocate_pty): Don't declare stb unless it's needed.
7624
7914961c 7625 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7626 (CONSTANTLIM): Remove; unused.
7627 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7628 Define only if needed.
7914961c 7629
b3967b18
PE
7630 * unexelf.c (unexec): Name an expression,
7631 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7632 Use a different way to cause a compilation error if anyone uses
7633 n rather than nn, a way that does not involve shadowing.
73366a00 7634 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7635
29a6015a
PE
7636 * deps.mk (unexalpha.o): Remove; unused.
7637
43cfc33e 7638 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7639 * unexec.h: New file.
ce701a33
PE
7640 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7641 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7642 Depend on unexec.h.
7643 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7644 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7645 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7646 Change as necessary to match prototype in unexec.h.
ce701a33 7647
01f44d5a
PE
7648 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7649 shadowing.
4f63c6bb 7650 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7651
a6670b0b
PE
7652 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7653 Rename locals to avoid shadowing.
7654
cef2010d 7655 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7656 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7657
d4d7173a
PE
7658 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7659
f08b802a
PE
7660 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7661 warning when compiling print.c.
7662
3ddb0639
PE
7663 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7664 instead of using an uninitialized var.
5ad03b97 7665 (font_sort_entities): Mark var as initialized.
3ddb0639 7666
170a2692
PE
7667 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7668
e663c700
PE
7669 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7670 pointers to constants.
89bc529a 7671 (font_parse_fcname): Remove unused vars.
7b81e2d0 7672 (font_delete_unmatched): Now static.
ea838e10 7673 (font_get_spec): Remove; unused.
13a547c6
PE
7674 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7675 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7676 Rename or move locals to avoid shadowing.
e663c700 7677
2a80c887 7678 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7679 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7680
1384fa33 7681 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7682 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7683
8b2c52e9
PE
7684 * alloc.c (mark_backtrace): Move decl from here ...
7685 * lisp.h: ... to here, so that it can be checked.
7686
475545b5 7687 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7688 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7689 (lisp_indirect_variable): Name an expression,
7690 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7691 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7692
b1349114 7693 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7694 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7695 Use const pointer when appropriate.
b1349114 7696
a2928364
PE
7697 * lisp.h (get_system_name, get_operating_system_release):
7698 Move decls here, to check interfaces.
7699 * process.c (get_operating_system_release): Move decl to lisp.h.
7700 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7701 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7702 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7703 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7704 (Fformat_time_string, Fencode_time, Finsert_char):
7705 (Ftranslate_region_internal, Fformat):
7706 Rename or remove local vars to avoid shadowing.
9710023e 7707 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7708
a415e694
PE
7709 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7710 avoid shadowing.
7711
8ef4622d
PE
7712 * lisp.h (eassert): Check that the argument compiles, even if
7713 ENABLE_CHECKING is not defined.
7714
946f9a5b
PE
7715 * data.c (Findirect_variable): Name an expression, to avoid
7716 gcc -Wbad-function-cast warning.
112396d6 7717 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7718 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7719 (Fmake_variable_buffer_local, Fmake_local_variable):
7720 Mark variables as initialized.
52746918 7721 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7722
e5aab7e7 7723 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7724 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7725 Rename locals to avoid shadowing.
dff45157
PE
7726 (mark_stack): Move local variables into the #ifdef region where
7727 they're used.
7bc26fdb
PE
7728 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7729 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7730 needed otherwise.
7731 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7732 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7733 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7734
e5aab7e7
PE
7735 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7736 avoids undefined behavior in theory.
7737
4da60324
PE
7738 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7739
88043301
PE
7740 Use functions, not macros, for up- and down-casing (Bug#8254).
7741 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7742 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7743 to use the following functions instead of these macros.
7744 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7745 EMACS_INT, since callers assume the returned value fits in int.
7746 (upcase1): Likewise, for UPCASE_TABLE.
7747 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7748 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7749 the race-condition problem in the old DOWNCASE.
88043301 7750
19ed5445
PE
7751 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7752 Rename locals to avoid shadowing.
7753 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7754 (regex_compile, re_search_2, re_match_2_internal):
7755 Remove unused local vars.
952db0d7
PE
7756 (FREE_VAR): Rewrite so as not to use empty "else",
7757 which gcc can warn about.
da053e48 7758 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7759 (RETALLOC_IF): Define only if needed.
7760 (WORDCHAR_P): Likewise. This one is never needed, but is used
7761 only in a comment talking about a compiler bug, so put inside
7762 the #if 0 of that comment.
7763 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7764 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7765 Remove; unused.
19ed5445 7766
1f3561e4 7767 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7768 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7769 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7770
ded6f8f7
PE
7771 * search.c (simple_search): Remove unused var.
7772
dbd37a95
PE
7773 * dired.c (compile_pattern): Move decl from here ...
7774 * lisp.h: ... to here, so that it can be checked.
7775 (struct re_registers): New forward decl.
7776
7e47afad
PE
7777 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7778
85f24f61
PE
7779 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7780 All uses changed.
7781 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7782 Rename locals to avoid shadowing.
5671df8f 7783 (Fvertical_motion): Mark locals as initialized.
85f24f61 7784
181aa2be 7785 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7786 (casify_region): Mark local as initialized.
181aa2be 7787
930d429c
PE
7788 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7789
7082eac6
PE
7790 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7791 New macros, so that the caller can use some names other than
7792 gcpro1, gcpro2, etc.
7793 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7794 of the new macros.
7795 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7796 argument, for consistency with GCPRO2_VAR, etc: it is now the
7797 prefix of the variable, not the variable itself. All uses
7798 changed.
38b2c076
PE
7799 * dired.c (directory_files_internal, file_name_completion):
7800 Rename locals to avoid shadowing.
7801
15206ed9
PE
7802 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7803 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7804 dired.c's scmp function, had undefined behavior.
7805 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7806 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7807 * buffer.h: ... to here, because these macros use current_buffer,
7808 and the new implementation with inline functions needs to have
7809 current_buffer in scope now, rather than later when the macros
7810 are used.
7811 (downcase, upcase1): New static inline functions.
7812 (DOWNCASE, UPCASE1): Reimplement using these functions.
7813 This avoids undefined behavior in expressions like
7814 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7815 from race conditions in accessing the global variables
7816 case_temp1 and case_temp2.
7817 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7818 * lisp.h (case_temp1, case_temp2): Remove their decls.
7819 * character.h (ASCII_CHAR_P): Move from here ...
7820 * lisp.h: ... to here, so that the inline functions mentioned
7821 above can use them.
7822
4a6bea26
PE
7823 * dired.c (directory_files_internal_unwind): Now static.
7824
f14b7e14
PE
7825 * fileio.c (file_name_as_directory, directory_file_name):
7826 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7827 Now static.
2893f146
PE
7828 (file_name_as_directory): Use const pointers when appropriate.
7829 (Fexpand_file_name): Likewise. In particular, newdir might
7830 point at constant storage, so make it a const pointer.
fd4ead52 7831 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7832 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7833 signedness issues.
f839df0c
PE
7834 (Fset_file_times, Finsert_file_contents, auto_save_error):
7835 Rename locals to avoid shadowing.
f14b7e14 7836
5716756e 7837 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7838 (Ftry_completion, Fall_completions): Rename or remove locals
7839 to avoid shadowing.
5716756e 7840
b4c3046a
PE
7841 * marker.c (bytepos_to_charpos): Remove; unused.
7842
b45db522
PE
7843 * lisp.h (verify_bytepos, count_markers): New decls,
7844 so that gcc does not warn that these functions aren't declared.
7845
85876d07
PE
7846 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7847 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7848 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7849 (copy_text): Remove unused local var.
85876d07 7850
03d78a21 7851 * filelock.c (within_one_second): Now static.
b3dd38ab 7852 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7853
5df8f01b
PE
7854 * buffer.c (fix_overlays_before): Mark locals as initialized.
7855 (fix_start_end_in_overlays): Likewise. This function should be
7856 simplified by using pointers-to-pointers, but that's a different
7857 matter.
b1d876f1 7858 (switch_to_buffer_1): Now static.
8f54f30a
PE
7859 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7860 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7861
a70072c9 7862 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7863 Fix pointer signedness issue.
edced198
PE
7864 (sys_subshell): Mark local as volatile if checking for lint,
7865 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7866 (MAXPATHLEN): Define only if needed.
a70072c9 7867
a0977c44
PE
7868 * process.c (serial_open, serial_configure): Move decls from here ...
7869 * systty.h: ... to here, so that they can be checked.
7870
a884fdcc
PE
7871 * fns.c (get_random, seed_random): Move extern decls from here ...
7872 * lisp.h: ... to here, so that they can be checked.
7873
604efe86 7874 * sysdep.c (reset_io): Now static.
b8950c94 7875 (wait_for_termination_signal): Remove; unused.
604efe86 7876
38fc62d9
PE
7877 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7878 (copy_keymap_item, append_key, push_text_char_description):
7879 Now static.
1004a21a 7880 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7881 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7882 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7883 (describe_map_tree):
7884 Rename locals to avoid shadowing.
38fc62d9 7885
2f2650da
PE
7886 * keyboard.c: Declare functions static if they are not used elsewhere.
7887 (echo_char, echo_dash, cmd_error, top_level_2):
7888 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7889 (read_char, kbd_buffer_get_event, make_lispy_position):
7890 (make_lispy_event, make_lispy_movement, apply_modifiers):
7891 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7892 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7893 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7894 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7895 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7896
a053e86c 7897 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7898 (mark_kboards): Move decl here ...
7899 * alloc.c (mark_kboards): ... from here.
a053e86c 7900
4752793e
PE
7901 * lisp.h (force_auto_save_soon): New decl.
7902
74f10ca7 7903 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7904 (DEFINE_DUMMY_FUNCTION): New macro.
7905 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7906 Use it.
c03cd23f
PE
7907 (main): Add casts to avoid warnings
7908 if GCC considers string literals to be constants.
74f10ca7 7909
022e70d4
PE
7910 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7911
59d6fe83
PE
7912 * dbusbind.c: Pointer signedness fixes.
7913 (xd_signature, xd_append_arg, xd_initialize):
7914 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7915 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7916 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7917 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7918
78320123
PE
7919 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7920 if GCC considers string literals to be constants.
49cebcca 7921 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7922
35ac2a97
SM
79232011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7924
fb103ca9
SM
7925 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7926 (print_preprocess, print_object): New macro to fix last change.
7927
35ac2a97
SM
7928 * print.c (print_preprocess): Don't forget font objects.
7929
62973b41
JB
79302011-03-16 Juanma Barranquero <lekktu@gmail.com>
7931
7932 * emacs.c (USAGE3): Doc fixes.
7933
0e48bb22
AS
79342011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7935
7936 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7937 structure.
7938
7684e57b
JB
79392011-03-14 Juanma Barranquero <lekktu@gmail.com>
7940
7941 * lisp.h (VWindow_system, Qfile_name_history):
7942 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7943 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7944 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7945
7946 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7947 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7948
7949 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7950 * w32console.c (detect_input_pending, read_input_pending)
7951 (encode_terminal_code):
7952 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7953 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7954 (w32_system_caret_y, Qfile_name_history):
7955 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7956 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7957 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7958 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7959 * w32proc.c (Qlocal, report_file_error):
7960 * w32term.c (Vwindow_system, updating_frame):
7961 * w32uniscribe.c (initialized, uniscribe_font_driver):
7962 Remove unneeded extern declarations.
7963
2aa46d6c
CY
79642011-03-14 Chong Yidong <cyd@stupidchicken.com>
7965
c96bbc66 7966 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7967
cffc6f3b
CY
79682011-03-13 Chong Yidong <cyd@stupidchicken.com>
7969
7970 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7971 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7972 These macros can no longer be used for assignment.
7973
44f230aa
SM
7974 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7975 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7976 (record_buffer_markers, fetch_buffer_markers): New functions for
7977 recording and fetching special buffer markers.
7978 (set_buffer_internal_1, set_buffer_temp): Use them.
7979
7980 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7981
7982 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7983
7984 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7985 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7986
7987 * xdisp.c (hscroll_window_tree):
7988 (reconsider_clip_changes): Use PT instead of BUF_PT.
7989
d251f04b
EZ
79902011-03-13 Eli Zaretskii <eliz@gnu.org>
7991
7992 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7993 $(EMACS_ROOT)/lib/intprops.h.
7994
f0c77cd1
PE
79952011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7996
3eca4629
PE
7997 Fix more problems found by GCC 4.5.2's static checks.
7998
7c86ee98
PE
7999 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8000 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8001 (xg_free_frame_widgets): Make it clear that a local variable is
8002 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8003 (gdk_window_get_screen): Make it clear that this macro is needed
8004 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8005 (int_gtk_range_get_value): New function, which avoids a diagnostic
8006 from gcc -Wbad-function-cast.
8007 (xg_set_toolkit_scroll_bar_thumb): Use it.
8008 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8009 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8010 (get_utf8_string, xg_get_file_with_chooser):
8011 Rename locals to avoid shadowing.
8012 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8013
41729b81
PE
8014 * xgselect.c (xg_select): Remove unused var.
8015
f0c77cd1
PE
8016 * image.c (four_corners_best): Mark locals as initialized.
8017 (gif_load): Initialize transparent_p to zero (Bug#8238).
8018 Mark another local as initialized.
ec6cf4c6 8019 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8020
ce0ad53d 8021 * image.c (clear_image_cache): Now static.
d5d5a617 8022 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8023 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8024 (x_edge_detection): Remove unnecessary cast that
8025 gcc -Wbad-function-cast diagnoses.
2037898d 8026 (gif_load): Fix pointer signedness.
6ae141d6
PE
8027 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8028 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8029
33383987 80302011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8031
d32df629
PE
8032 Improve quality of tests for time stamp overflow.
8033 For example, without this patch (encode-time 0 0 0 1 1
8034 1152921504606846976) returns the obviously-bogus value (-948597
8035 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8036 reports time overflow. See
8037 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8038 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8039 * editfns.c: Include limits.h and intprops.h.
8040 (TIME_T_MIN, TIME_T_MAX): New macros.
8041 (time_overflow): Move earlier, to before first use.
8042 (hi_time, lo_time): New functions, for an accurate test for
8043 out-of-range times.
8044 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8045 (Fget_internal_run_time): Don't assume time_t fits in int.
8046 (make_time): Use list2 instead of Fcons twice.
8047 (Fdecode_time): More accurate test for out-of-range times.
8048 (check_tm_member): New function.
8049 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8050 (lisp_time_argument): Don't rely on undefined left-shift and
8051 right-shift behavior when checking for time stamp overflow.
8be6f318 8052
fe31d94c
PE
8053 * editfns.c (time_overflow): New function, refactoring common code.
8054 (Fformat_time_string, Fdecode_time, Fencode_time):
8055 (Fcurrent_time_string): Use it.
8056
8be6f318
PE
8057 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8058 * dired.c (make_time): Move to ...
8059 * editfns.c (make_time): ... here.
8060 * systime.h: Note the move.
8061
09d9db2c 80622011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8063
126bc0dc
YM
8064 * fringe.c (update_window_fringes): Remove unused variables.
8065
c47cbdfd
YM
8066 * unexmacosx.c (copy_data_segment): Also copy __got section.
8067 (Bug#8223)
8068
7ac80be9
EZ
80692011-03-12 Eli Zaretskii <eliz@gnu.org>
8070
c96bbc66 8071 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8072 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8073 Constify `char *' arguments and their references according to
8074 prototypes in tparam.h.
8075
ecb0f94d 8076 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8077
7ac80be9
EZ
8078 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8079 Adapt all references accordingly.
8080
8081 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8082
ef1fd07e
TT
80832011-03-11 Tom Tromey <tromey@redhat.com>
8084
8085 * buffer.c (syms_of_buffer): Remove obsolete comment.
8086
7ef4b50c
EZ
80872011-03-11 Eli Zaretskii <eliz@gnu.org>
8088
8089 * termhooks.h (encode_terminal_code): Declare prototype.
8090
8091 * msdos.c (encode_terminal_code): Don't declare prototype.
8092
8093 * term.c (encode_terminal_code): Now external again, used by
8094 w32console.c and msdos.c.
8095
44f230aa
SM
8096 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8097 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8098
4b1ec863 80992011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8100
1714f52b 8101 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8102
4b1ec863
PE
8103 * fringe.c (update_window_fringes): Mark locals as initialized
8104 (Bug#8227).
8105 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8106
524c7aa6
PE
8107 * alloc.c (mark_fringe_data): Move decl from here ...
8108 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8109 to check its interface.
8110 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8111
a5c0af81 8112 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8113 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8114 (fontset_font): Mark local as initialized.
a9a06e0b 8115 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8116
b4716021
PE
8117 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8118
811e9bac 8119 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8120 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8121 (x_own_selection, Fx_disown_selection_internal): Rename locals
8122 to avoid shadowing.
8123 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8124
7e3ab302
PE
8125 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8126 so that the caller can use some name other than gcpro1.
8127 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8128 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8129 (Fx_backspace_delete_keys_p):
8130 Use them to avoid shadowing, and rename vars to avoid shadowing.
8131 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8132 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8133 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8134 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8135 Remove unused locals.
7e3ab302
PE
8136 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8137 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8138 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8139 macros.
f78faa98 8140
e2b13473
PE
8141 * xterm.h (x_mouse_leave): New decl.
8142
77f23912
PE
8143 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8144 Remove unused functions.
cdf4ba58
PE
8145 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8146 (x_calc_absolute_position): Now static.
7411c686 8147 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8148 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8149 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8150 unless they are used.
38d0b34a
PE
8151 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8152 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8153 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8154 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8155 (x_error_catcher, x_connection_closed, x_error_handler):
8156 (x_error_quitter, xembed_send_message, x_iconify_frame):
8157 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8158 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8159 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8160
44f230aa
SM
8161 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8162 Rename or move locals to avoid shadowing.
6b463e58 8163 (tty_defined_color, merge_face_heights): Now static.
5967d051 8164 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8165 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8166 does not deduce is never used uninitialized.
73719eba
PE
8167 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8168 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8169
426994c3 8170 * terminal.c (store_terminal_param): Now static.
5489860b 8171
032f1620 8172 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8173 (set_frame_menubar): Remove unused local.
d4323972 8174 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8175 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8176 since they might point to immutable storage.
281585b0
PE
8177 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8178 since it's unused otherwise.
032f1620 8179
367c19e5 8180 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8181 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8182 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8183 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8184 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8185 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8186 does not deduce are never used uninitialized.
70739cbe 8187
07b48fa9
PE
8188 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8189
8868a238 8190 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8191 * window.c (window_loop, size_window):
8192 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8193
7e5cf297 8194 * window.c (display_buffer): Now static.
d6550a9f
PE
8195 (size_window): Mark variables that gcc -Wuninitialized
8196 does not deduce are never used uninitialized.
a586633d
PE
8197 * window.h (check_all_windows): New decl, to forestall
8198 gcc -Wmissing-prototypes diagnostic.
5b555da1 8199 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8200
f6095868
PE
8201 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8202 shadowing.
8203 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8204 Include <limits.h>.
8205 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8206 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8207 (load_charset_map): Mark variables that gcc -Wuninitialized
8208 does not deduce are never used uninitialized.
53df7c11 8209 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8210
f38b440c
PE
8211 * coding.c (coding_set_source, coding_set_destination):
8212 Use "else { /* comment */ }" rather than "else /* comment */;"
8213 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8214 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8215 a block, when the outer 'i' will do.
8216 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8217 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8218 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8219 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8220 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8221 Rename locals to avoid shadowing.
8222 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8223 * coding.c (emacs_mule_char, encode_invocation_designation):
8224 Now static, since they're not used elsewhere.
413bb2db 8225 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8226 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8227 (decode_coding_emacs_mule): Mark variables that gcc
8228 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8229 (detect_coding_iso_2022): Initialize a local variable that might
8230 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8231 this initialization is needed. (Bug#8211)
5f58e762
PE
8232 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8233 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8234 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8235 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8236 Remove unused macros.
f38b440c 8237
232b38b9 8238 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8239 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8240 * character.c (string_count_byte8): Likewise.
232b38b9 8241
fb90da1b
PE
8242 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8243 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8244
fb93dbc2
PE
8245 * chartab.c (copy_sub_char_table): Now static, since it's not used
8246 elsewhere.
5c156ace
PE
8247 (sub_char_table_ref_and_range, char_table_ref_and_range):
8248 Rename locals to avoid shadowing.
bbcd0949 8249 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8250
7d3b3862 8251 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8252 (BIDI_BOB): Remove unused macro.
7d3b3862 8253
6be7d3da
PE
8254 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8255 deduce are never used uninitialized.
c2ed9c8b 8256 * term.c (encode_terminal_code): Likewise.
6be7d3da 8257
75f8807f 8258 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8259
50938595
PE
8260 * tparam.h: New file.
8261 * term.c, tparam.h: Include it.
8262 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8263 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8264 Move these decls to tparam.h, and make them agree with what
8265 is actually in tparam.c. The previous trick of using incompatible
8266 decls in different modules does not conform to the C standard.
8267 All callers of tparam changed to use tparam's actual API.
8268 * tparam.c (tparam1, tparam, tgoto):
8269 Use const pointers where appropriate.
8270
fbceeba2
PE
8271 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8272 * cm.h (struct cm): Likewise.
8273 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8274 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8275 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8276 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8277 (turn_on_face, init_tty): Likewise.
8278 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8279
7f3f1250
PE
8280 * term.c (term_mouse_position): Rename local to avoid shadowing.
8281
e6ca6543
PE
8282 * alloc.c (mark_ttys): Move decl from here ...
8283 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8284
c40f8d15
AS
82852011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8286
8287 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8288
cfe0661d
JB
82892011-03-09 Juanma Barranquero <lekktu@gmail.com>
8290
8291 * search.c (compile_pattern_1): Remove argument regp, unused since
8292 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8293 (compile_pattern): Don't pass it.
8294
0afb4571
J
82952011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8296
8297 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8298 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8299 for ! HAVE_GTK3.
8300 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8301
8302 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8303
8304 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8305 gdk_window_get_screen, gdk_window_get_geometry,
8306 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8307 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8308 (xg_get_pixbuf_from_pixmap): New function.
8309 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8310 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8311 Call xg_get_pixbuf_from_pixmap instead of
8312 gdk_pixbuf_get_from_drawable.
8313 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8314 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8315 (xg_check_special_colors): Use GtkStyleContext and its functions
8316 for HAVE_GTK3.
8317 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8318 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8319 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8320 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8321 Call gtk_widget_get_preferred_size.
0afb4571
J
8322 (xg_frame_resized): gdk_window_get_geometry only takes 5
8323 parameters.
44f230aa
SM
8324 (xg_win_to_widget, xg_event_is_for_menubar):
8325 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8326 (xg_set_widget_bg): New function.
8327 (delete_cb): New function.
895009e1 8328 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8329 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8330 (xg_set_background_color): Call xg_set_widget_bg.
8331 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8332 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8333 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8334 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8335 if ! HAVE_GTK3.
8336 (update_frame_tool_bar): Call gtk_widget_hide.
8337 (xg_initialize): Use GDK_KEY_g.
8338
8339 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8340 if ! HAVE_GTK3
8341 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8342
8343 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8344 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8345 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8346
1c2cc4ef
JB
83472011-03-08 Juanma Barranquero <lekktu@gmail.com>
8348
8349 * w32xfns.c (select_palette): Check success of RealizePalette against
8350 GDI_ERROR, not zero.
8351
33383987 8352See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8353
8354;; Local Variables:
8355;; coding: utf-8
aac0c6e3
MR
8356;; End:
8357
33383987 8358 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8359
8360 This file is part of GNU Emacs.
8361
8362 GNU Emacs is free software: you can redistribute it and/or modify
8363 it under the terms of the GNU General Public License as published by
8364 the Free Software Foundation, either version 3 of the License, or
8365 (at your option) any later version.
8366
8367 GNU Emacs is distributed in the hope that it will be useful,
8368 but WITHOUT ANY WARRANTY; without even the implied warranty of
8369 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8370 GNU General Public License for more details.
8371
8372 You should have received a copy of the GNU General Public License
8373 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.