Gnus: Update the header format of icon data for the most recent icontopbm program.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0068070e
SM
12011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * fileio.c (Finsert_file_contents): Move after-change-function call
4 to before the "handled:" label, since all "goto handled" appear in
5 cases where the *-change-functions have already been properly called
6 (bug#10117).
7
3360a3fc
AS
82011-12-01 Andreas Schwab <schwab@linux-m68k.org>
9
10 * keyboard.c (interrupt_signal): Don't call kill-emacs when
11 waiting for input. (Bug#10169)
12
73d6c093
EZ
132011-11-30 Eli Zaretskii <eliz@gnu.org>
14
15 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
16 verifies glyph row's hash code--we have just reallocated the
17 glyphs, so their contents can be complete garbage. (Bug#10164)
18
febe6bea
JB
192011-11-30 Juanma Barranquero <lekktu@gmail.com>
20
21 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
22
801a4313
EZ
232011-11-30 Eli Zaretskii <eliz@gnu.org>
24
25 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
26 attributes are tested _before_ calling verify_row_hash, to protect
27 against GCC re-ordering of the tests. (Bug#10164)
28
2b56b87e
JD
292011-11-29 Jan Djärv <jan.h.d@swipnet.se>
30
31 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
32
33 * xterm.c (handle_one_xevent): Only set async_visible and friends
34 if net_wm_state_hidden_seen is non-zero (Bug#10002)
35 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
36 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
37
dbf31225
PE
382011-11-28 Paul Eggert <eggert@cs.ucla.edu>
39
40 Remove GCPRO-related macros that exist only to avoid shadowing locals.
41 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
42 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
43 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
44 All uses changed to use GCPRO1 etc.
45 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
46 Revert to old implementation (i.e., before 2011-03-11).
47
1305621b
YM
482011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
49
50 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
51 of scroll runs so as to avoid assigning disabled bogus rows and
52 unnecessary graphics copy operations.
53
8c9afb46
EZ
542011-11-27 Eli Zaretskii <eliz@gnu.org>
55
56 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
57 (snprintf) [_MSC_VER]: Redirect to _snprintf.
58 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
59 (malloc, free, realloc, calloc): Redirect to e_* only when
60 compiling Emacs.
61
62 * lisp.h (GCTYPEBITS): Move before first use.
63 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
64 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
65 this macro definition.
66
67 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
68 _MSC_VER.
69
54e9e3bf
JD
702011-11-27 Jan Djärv <jan.h.d@swipnet.se>
71
72 * gtkutil.c (xg_create_frame_widgets): Call
73 gtk_window_set_has_resize_grip (FALSE) if that function is
74 present with Gtk+ 2.0.
75
83aca1cb
PE
762011-11-26 Paul Eggert <eggert@cs.ucla.edu>
77
78 * fileio.c (Finsert_file_contents): Undo previous change; see
79 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
80
5b76caa4
PE
812011-11-26 Paul Eggert <eggert@cs.ucla.edu>
82
83 Rename locals to avoid shadowing.
84 * fileio.c (Finsert_file_contents):
85 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
86 * process.c (wait_reading_process_output):
87 Rename inner 'proc' to 'p' to avoid shadowing.
88 Indent for consistency with usual Emacs style.
89
8c535114
EZ
902011-11-25 Eli Zaretskii <eliz@gnu.org>
91
92 * xdisp.c (redisplay_window): If cursor row is not fully visible
93 after recentering, and scroll-conservatively is set to a large
94 number, scroll window by a few more lines to make the cursor fully
95 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
96 (start_display): Don't move to the next line if the display should
97 start at a newline that is part of a display vector or an overlay
98 string. (Bug#10119)
8c535114 99
fa4fdb5c
JL
1002011-11-24 Juri Linkov <juri@jurta.org>
101
102 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
103 after the `MagickPingImage' call. (Bug#10112)
104
90ec88df
CY
1052011-11-23 Chong Yidong <cyd@gnu.org>
106
107 * window.c (Fcoordinates_in_window_p): Accept only live windows.
108
56e2e794
MR
1092011-11-23 Martin Rudalics <rudalics@gmx.at>
110
111 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
112 making another buffer current. (Bug#10114)
113
b6e64c41
GM
1142011-11-23 Glenn Morris <rgm@gnu.org>
115
116 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
117
6b21de18
CY
1182011-11-23 Chong Yidong <cyd@gnu.org>
119
120 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
121 using it (Bug#5984).
122
b12cd789
EZ
1232011-11-22 Eli Zaretskii <eliz@gnu.org>
124
125 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
126 and header-lines, as they don't have one computed for them.
127 (Bug#10098)
128
129 * .gdbinit (prow): Make displayed values more self-explaining.
130 Add row's hash code.
131
261b6fd4
LMI
1322011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
133
134 * process.c (wait_reading_process_output): Fix asynchrounous
135 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 136 (wait_reading_process_output): Add comment and URL.
261b6fd4 137
e7cfd277
JD
1382011-11-21 Jan Djärv <jan.h.d@swipnet.se>
139
140 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
141
a9b9b7f5
CY
1422011-11-21 Chong Yidong <cyd@gnu.org>
143
144 * window.c (Fnext_window, Fprevious_window): Doc fix.
145
b0d15b4f
SM
1462011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
147
148 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
149
fe7a3057
JB
1502011-11-20 Juanma Barranquero <lekktu@gmail.com>
151
152 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
153
d2999b1a
MR
1542011-11-20 Martin Rudalics <rudalics@gmx.at>
155
156 * window.c (Fset_window_combination_limit): Rename argument
157 STATUS to LIMIT.
158 (Vwindow_combination_limit): Remove "status" from doc-string.
159
d5ff9cd0
AS
1602011-11-20 Andreas Schwab <schwab@linux-m68k.org>
161
162 * m/ibms390.h: Remove.
163 * m/ibms390x.h: Don't include "ibms390.h".
164
a5bb9bd3
SM
1652011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
166
167 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
168 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
169
cd1181db
JB
1702011-11-20 Juanma Barranquero <lekktu@gmail.com>
171
172 * casetab.c (Fset_case_table):
173 * charset.c (Fcharset_after): Fix typos.
174
615a3b8d 1752011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 176
17e845af
PE
177 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
178 Otherwise, valgrind does not work on some platforms.
179 Problem reported by Andreas Schwab in
6a0bf43d
PE
180 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
181 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
182 is set, removing the need for VIRT_ADDRESS_VARIES.
183 (PURE_P): Use a more-efficient implementation that needs just one
184 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
185 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
186 to 4 (xorl, subq, cmpq, setbe).
187 * alloc.c (pure): Always extern now, since that's the
188 VIRT_ADDR_VARIES behavior.
189 (PURE_POINTER_P): Use a single comparison, not two, for
190 consistency with the new puresize.h.
191 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
192 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
193 Remove VIRT_ADDR_VARIES no longer needed.
194
f8fe6f96
EZ
1952011-11-19 Eli Zaretskii <eliz@gnu.org>
196
197 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
198 (erase_phys_cursor, update_window_cursor, show_mouse_face)
199 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
200 behave as if the cursor position were at the window margin.
201
202 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
203 and the cursor position is out of bounds, behave as if the cursor
204 position were at the window margin. (Bug#10075)
205
df05a53c
CY
2062011-11-18 Chong Yidong <cyd@gnu.org>
207
208 * window.c (Fwindow_combination_limit): Make first argument
209 non-optional, since it is meaningless for live windows like the
210 selected window.
211
2071918e
DA
2122011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
213
214 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
215
b50a28de
SM
2162011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
217
218 * intervals.c: Fix grafting over the whole buffer (bug#10071).
219 (graft_intervals_into_buffer): Simplify.
220
015137db
EZ
2212011-11-18 Eli Zaretskii <eliz@gnu.org>
222
223 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
224 hash values of the two rows.
225 (copy_row_except_pointers): Preserve the used[] arrays and the
226 hash values of the two rows. (Bug#10035)
68c95424 227 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
228
229 * xdisp.c (row_hash): New function, body extracted from
230 compute_line_metrics.
231 (compute_line_metrics): Call row_hash, instead of computing the
232 hash code inline.
233
234 * dispnew.c (verify_row_hash): Call row_hash for computing the
235 hash code of a row, instead of duplicating code from xdisp.c.
236
237 * dispextern.h (row_hash): Add prototype.
238
a2addb04
TH
2392011-11-18 Tassilo Horn <tassilo@member.fsf.org>
240
241 * frame.c (delete_frame): Don't delete the terminal when the last
242 X frame is closed if emacs is built with GTK toolkit.
243
df85d315
JB
2442011-11-17 Juanma Barranquero <lekktu@gmail.com>
245
246 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
247
a0c2d0ae
MR
2482011-11-17 Martin Rudalics <rudalics@gmx.at>
249
250 * window.c (Vwindow_splits): Rename to
251 Vwindow_combination_resize. Suggested by Juri Linkov.
252 (Fsplit_window_internal): Use Vwindow_combination_resize instead
253 of Vwindow_splits.
254
58179cce
JB
2552011-11-16 Juanma Barranquero <lekktu@gmail.com>
256
7877f373
JB
257 * nsfns.m (Fns_font_name):
258 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 259
b6f67890
MR
2602011-11-16 Martin Rudalics <rudalics@gmx.at>
261
262 * window.h (window): Rename slot "nest" to "combination_limit".
263 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
264 (Fset_window_nest): Rename to Fset_window_combination_limit.
265 (Vwindow_nest): Rename to Vwindow_combination_limit.
266 (recombine_windows, make_parent_window, make_window)
267 (Fsplit_window_internal, saved_window)
268 (Fset_window_configuration, save_window_save): Rename all
269 occurrences of window_nest to window_combination_limit.
270
c7015153
JB
2712011-11-15 Juanma Barranquero <lekktu@gmail.com>
272
273 * image.c (imagemagick_load_image): Fix typo.
274
322ad6ec
EZ
2752011-11-14 Eli Zaretskii <eliz@gnu.org>
276
277 * xdisp.c (display_line): Move the call to
278 highlight_trailing_whitespace before the call to
279 compute_line_metrics, since the latter needs to see the final
280 faces of all the glyphs to compute ROW's hash value. Fixes
281 assertion violations in row_equal_p. (Bug#10035)
282
f067b8ec
JB
2832011-11-14 Juanma Barranquero <lekktu@gmail.com>
284
285 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
286 just return (bug#10044).
287
1e5b2111
EZ
2882011-11-12 Eli Zaretskii <eliz@gnu.org>
289
7ef3cbd5
EZ
290 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
291 with user-defined heap size. Bump the default size of the temacs
292 heap to 27MB, to avoid memory warning when running temacs.
293 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
294
1e5b2111
EZ
295 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
296 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
297 (verify_row_hash) [XASSERTS]: New function.
298 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
299 that the hash value of glyph rows is correct.
1e5b2111 300
89d61221
MR
3012011-11-12 Martin Rudalics <rudalics@gmx.at>
302
303 * window.h (window): Remove splits slot.
304 * window.c (Fwindow_splits, Fset_window_splits): Remove.
305 (Fdelete_other_windows_internal, make_parent_window)
306 (make_window, Fsplit_window_internal, Fdelete_window_internal)
307 (Fset_window_configuration, save_window_save): Don't deal with
308 split status of windows.
309 (saved_window): Remove splits slot.
310 (Vwindow_splits): Rewrite doc-string.
311
97f18cc8
JD
3122011-11-11 Jan Djärv <jan.h.d@swipnet.se>
313
314 * xfns.c (unwind_create_frame):
315 * nsfns.m (unwind_create_frame):
316 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
317 Vframe_list (Bug#9999).
318
22a648b4
DA
3192011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
320
0b381c7e 321 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 322
659afede
KH
3232011-11-11 Kenichi Handa <handa@m17n.org>
324
325 * callproc.c (Fcall_process): Set the member dst_multibyte of
326 process_coding.
327
9ac0394b
KH
3282011-11-11 Johan Bockgård <bojohan@gnu.org>
329
330 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
331 avoid a crash (bug#9496).
332
2fbdc249
CY
3332011-11-09 Chong Yidong <cyd@gnu.org>
334
335 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
336 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
337
ac6b1f81
PE
3382011-11-08 Paul Eggert <eggert@cs.ucla.edu>
339
340 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
341
09db192c
PE
3422011-11-08 Paul Eggert <eggert@cs.ucla.edu>
343
344 Avoid some portability problems by eschewing 'extern inline' functions.
345 The trivial performance wins aren't worth the portability hassles; see
346 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
347 et seq.
348 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
349 (window_box_width, window_box_left, window_box_left_offset)
350 (window_box_right, window_box_right_offset): Undo previous change,
351 by removing the "extern"s.
352 * intervals.c (adjust_intervals_for_insertion)
353 (adjust_intervals_for_deletion): Undo previous change,
354 making these static again.
355 (offset_intervals, temp_set_point_both, temp_set_point)
356 (copy_intervals_to_string): No longer inline.
357 * xdisp.c (window_text_bottom_y, window_box_width)
358 (window_box_height, window_box_left_offset)
359 (window_box_right_offset, window_box_left, window_box_right)
360 (window_box): No longer inline.
361
105216ed
CY
3622011-11-08 Chong Yidong <cyd@gnu.org>
363
364 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
365 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
366 an error if not a live window.
367 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
368 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
369
ae9e237f
JB
3702011-11-07 Juanma Barranquero <lekktu@gmail.com>
371
372 * lisp.h (syms_of_abbrev): Remove declaration.
373 Reported by CHENG Gao <chenggao@royau.me>.
374
c7aa8333
EZ
3752011-11-07 Eli Zaretskii <eliz@gnu.org>
376
377 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
378 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
379 of temacs in GUI mode.
380
be7f5545
MR
3812011-11-07 Martin Rudalics <rudalics@gmx.at>
382
383 * window.h: Declare delete_all_child_windows instead of
384 delete_all_subwindows.
385 * window.c (Fwindow_nest, Fset_window_nest)
386 (Fset_window_new_total, Fset_window_new_normal)
387 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
388 (delete_all_subwindows): Rename to delete_all_child_windows.
389 (Fdelete_other_windows_internal, Fset_window_configuration):
390 Call delete_all_child_windows instead of delete_all_subwindows.
391 * frame.c (delete_frame): Call delete_all_child_windows instead
392 of delete_all_subwindows.
393
ca78dc43
PE
3942011-11-07 Paul Eggert <eggert@cs.ucla.edu>
395
396 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
397 This is also needed for porting to any host where GC_MARK_STACK is
398 not GC_MAKE_GCPROS_NOOPS.
399 (which_symbols): Use it.
400
a0241d01
KH
4012011-11-07 Kenichi Handa <handa@m17n.org>
402
403 * coding.c (coding_set_destination): Check coding->src_pos only
404 when coding->src_object is a buffer (bug#9910).
405
406 * process.c (send_process): Set the member src_multibyte of coding
407 to 0 (bug#9911) when sending a unibyte text.
408
409 * callproc.c (Fcall_process): Set the member src_multibyte of
410 process_coding to 0 (bug#9912).
411
a64bfdfa 4122011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
413
414 * xmenu.c (cleanup_widget_value_tree): New function.
415 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
416 calling free_menubar_widget_value_tree directly (Bug#9830).
417
cb41b32a
PE
4182011-11-06 Paul Eggert <eggert@cs.ucla.edu>
419
420 Fix some portability problems with 'inline'.
421 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
422 (window_box_width, window_box_left, window_box_left_offset)
423 (window_box_right, window_box_right_offset): Declare extern.
424 Otherwise, these inline functions do not conform to C99 and
425 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
426 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
427 * intervals.c (adjust_intervals_for_insertion)
428 (adjust_intervals_for_deletion): Now extern, because otherwise the
429 extern inline functions 'offset_intervals' couldn't refer to it.
430 (static_offset_intervals): Remove.
431 (offset_intervals): Rewrite using the old contents of
432 static_offset_intervals. The old version didn't conform to C99
433 because an extern inline function contained a reference to an
434 identifier with static linkage.
435
b7041366
AS
4362011-11-06 Andreas Schwab <schwab@linux-m68k.org>
437
438 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
439 GC.
440
88a37c4d
EZ
4412011-11-06 Eli Zaretskii <eliz@gnu.org>
442
443 * xdisp.c (init_iterator, reseat_to_string): Don't set the
444 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
445 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
446 return Qleft_to_right.
447
49745b39
CY
4482011-11-06 Chong Yidong <cyd@gnu.org>
449
450 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
451 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
452 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
453 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
454 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
455 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
456 (Fwindow_vscroll): Doc fix.
457 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
458 argument, since it makes no sense to pass a live window and for
459 consistency with window-child.
460
1f05cd82
CS
4612011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
462
463 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
464 support MSVC.
465
22610910
JR
4662011-11-05 Jason Rumney <jasonr@gnu.org>
467
468 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
469 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
470 fonts (Bug#6029).
471 (add_font_entity_to_list): Fix logic errors in mixed boolean and
472 bitwise arithmetic preventing use of unicode-sip and non-truetype
473 opentype fonts.
474
a06776b2
EZ
4752011-11-05 Eli Zaretskii <eliz@gnu.org>
476
3ad924ba
EZ
477 * s/ms-w32.h (fstat, stat, utime): Move redirections to
478 "emacs"-only part.
479
a06776b2
EZ
480 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
481 initialization code to keep similarity to xfns.c after changes
482 from 2011-11-05.
483
c9e7db78
JD
4842011-11-05 Jan Djärv <jan.h.d@swipnet.se>
485
a97f8f3f
JD
486 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
487 (unwind_create_frame): New function (Bug#9943).
488 (Fx_create_frame): Restructure code to be more similar to the one in
489 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
490 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
491 Move terminal->reference_count++ just before making the frame official
492 (Bug#9943).
493
494 * nsterm.m (x_free_frame_resources): New function.
495 (x_destroy_window): Move code to x_free_frame_resources.
496
c9e7db78
JD
497 * xfns.c (unwind_create_frame): Fix comment.
498 (Fx_create_frame, x_create_tip_frame): Move
499 terminal->reference_count++ just before making the frame
500 official. Move initialization of image_cache_refcount and
501 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
502
a6fc3b5c
EZ
5032011-11-05 Eli Zaretskii <eliz@gnu.org>
504
505 Support MSVC build with newer versions of Visual Studio.
506 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
507 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
508 nt/gmake.defs.
509
510 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
511 which are not supported by MSVC.
512 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
513 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
514 bitfields.
515 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
516 types in bitfields.
517 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
518
519 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
520
58179cce 5212011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
522
523 Support MSVC build with newer versions of Visual Studio.
524 * w32.c: Don't include w32api.h for MSVC.
525 (init_environment) [_MSC_VER]: Call sys_access, not _access.
526
527 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
528 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
529 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
530 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
531 e_* cousins.
532 (alloca) [_MSC_VER]: Define to _alloca.
533
534 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
535
536 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
537
a58c13ed
EZ
5382011-11-04 Eli Zaretskii <eliz@gnu.org>
539
540 * xdisp.c (note_mouse_highlight): If either of
541 previous/next-single-property-change returns nil, treat that as
542 the beginning or the end of the buffer. (Bug#9955)
543
fe0b6370
JD
5442011-11-04 Jan Djärv <jan.h.d@swipnet.se>
545
a58c13ed 546 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
547 label is not null (Bug#9951).
548 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
549 may be NULL.
550
89bd5ee1
EZ
5512011-11-04 Eli Zaretskii <eliz@gnu.org>
552
553 * window.c (Fwindow_body_size): Mention in the doc string that the
554 return value is in frame's canonical units. (Bug#9949)
555
84c3edb9
EZ
5562011-11-03 Eli Zaretskii <eliz@gnu.org>
557
4e2fb5c7
EZ
558 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
559
84c3edb9 560 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 561 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 562 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 563
bc17a887
EZ
5642011-11-01 Eli Zaretskii <eliz@gnu.org>
565
566 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
567 Don't stop backward scan on the continuation glyph, even though
568 its CHARPOS is positive.
26b46e51
EZ
569 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
570 cover_string to disp_string.
bc17a887 571
4ee88440
MR
5722011-11-01 Martin Rudalics <rudalics@gmx.at>
573
574 * window.c (temp_output_buffer_show): Don't use
575 Vtemp_buffer_show_specifiers.
576 (Vtemp_buffer_show_specifiers): Remove unused variable.
577
c2ff3c02
EZ
5782011-10-30 Eli Zaretskii <eliz@gnu.org>
579
580 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
581 past the beginning of the current glyph matrix.
582
58179cce 5832011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
584
585 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
586 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
587 HAVE_GTK3 (Bug#9869).
b77a6a7f 588
3b574623
JD
589 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
590 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
591
b77a6a7f
JD
592 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
593
594 * xterm.c: Declare x_handle_net_wm_state to return int.
595 (handle_one_xevent): Check if we are iconified but don't have
596 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
597 (get_current_wm_state): Return non-zero if not hidden,
598 check for _NET_WM_STATE_HIDDEN (Bug#9893).
599 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
600 (x_handle_net_wm_state): Return what get_current_wm_state returns.
601 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
602
196e41e4
PE
6032011-10-29 Paul Eggert <eggert@cs.ucla.edu>
604
605 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
606 so that this new function doesn't get optimized away by a
607 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
608
021f2e1a
AS
6092011-10-29 Andreas Schwab <schwab@linux-m68k.org>
610
611 * frame.h (MOUSE_HL_INFO): Remove excess parens.
612
8b058d44
EZ
6132011-10-29 Eli Zaretskii <eliz@gnu.org>
614
615 Fix the `xbytecode' command.
616 * .gdbinit (xprintbytestr): New command.
b50a28de 617 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
618 (xbytecode): Print the byte-code string as well.
619
4452fb80
EZ
6202011-10-29 Kim Storm <storm@cua.dk>
621
8b058d44
EZ
622 * alloc.c (which_symbols): New function.
623
21b72067
AS
6242011-10-29 Andreas Schwab <schwab@linux-m68k.org>
625
626 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
627 line. (Bug#9903)
628
83ed7b5c
GM
6292011-10-29 Glenn Morris <rgm@gnu.org>
630
631 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
632 Not clear what it was for, and it causes various bugs. (Bug#9839)
633
5a7a728b
EZ
6342011-10-28 Eli Zaretskii <eliz@gnu.org>
635
636 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
637 possible random value that matches one of those tested as
638 condition to clear the mouse face.
639
d3d0842f
CY
6402011-10-28 Chong Yidong <cyd@gnu.org>
641
642 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
643
31b39d13
DN
6442011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
645
646 * window.c (make_window): Initialize phys_cursor_on_p.
647
9aba6043
SM
6482011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
649
650 * lisp.h (struct Lisp_Symbol): Update comments.
651
c20992f4
JB
6522011-10-28 Juanma Barranquero <lekktu@gmail.com>
653
654 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
655
db4f02f2
EZ
6562011-10-28 Eli Zaretskii <eliz@gnu.org>
657
658 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
659 <oslsachem@gmail.com> for helping to debug this.
660
661 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
662 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
663 (g_b_init_get_glyph_outline_w): New static variables.
664 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
665 (GetGlyphOutlineW_Proc): New typedefs.
666 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
667 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
668 New functions.
669 (w32font_open_internal, compute_metrics):
670 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
671 instead of calling the "wide" APIs directly.
672
673 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
674
675 * w32.h (syms_of_w32font): Add prototype.
676
87e68db4
JB
6772011-10-27 Juanma Barranquero <lekktu@gmail.com>
678
679 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
680 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
681 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
682 (Fmove_to_window_line): Doc fix.
683
435c1d67
CY
6842011-10-27 Chong Yidong <cyd@gnu.org>
685
686 * process.c (make_process): Set gnutls_state to NULL.
687
688 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
689 non-NULL, regardless of GNUTLS_INITSTAGE.
690 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
691 an error. Set process slots as soon as we allocate them.
692
693 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
694
9c6c6f49
CY
6952011-10-27 Chong Yidong <cyd@gnu.org>
696
9aba6043
SM
697 * gnutls.c (emacs_gnutls_deinit): New function.
698 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
699 (Fgnutls_deinit, Fgnutls_boot): Use it.
700
701 * process.c (make_process): Initialize GnuTLS credentials to NULL.
702 (deactivate_process): Call emacs_gnutls_deinit.
703
657d08d3
JB
7042011-10-27 Juanma Barranquero <lekktu@gmail.com>
705
706 * image.c (x_create_x_image_and_pixmap):
707 * w32.c (sys_rename, w32_delayed_load):
708 * w32font.c (fill_in_logfont):
709 * w32reg.c (x_get_string_resource): Silence compiler warnings.
710
5430d399
JB
7112011-10-26 Juanma Barranquero <lekktu@gmail.com>
712
713 * w32fns.c (w32_default_color_map): New function,
714 extracted from Fw32_default_color_map.
a7ef684b 715 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 716
fe0055fa
PE
7172011-10-25 Paul Eggert <eggert@cs.ucla.edu>
718
719 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
720
e6346438
SM
7212011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
722
723 * keyboard.c (test_undefined): New function (bug#9751).
724 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
725
e112cc37
ET
7262011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
727
728 * sysdep.c (init_sys_modes): Fix the check for the controlling
729 terminal (Bug#6649).
730
7b5d6677
EZ
7312011-10-20 Eli Zaretskii <eliz@gnu.org>
732
733 * dispextern.h (struct bidi_it): New member next_en_type.
734
735 * bidi.c (bidi_line_init): Initialize the next_en_type member.
736 (bidi_resolve_explicit_1): When next_en_pos is valid for the
737 current character, check also for next_en_type being WEAK_EN.
738 (bidi_resolve_weak): Don't enter the expensive loop if the current
739 position is before next_en_pos. Record the bidi type of the first
740 non-ET, non-BN character we find, in addition to its position.
741 (bidi_level_of_next_char): Invalidate next_en_type when
742 next_en_pos is over-stepped.
743
7da0b018
PE
7442011-10-20 Paul Eggert <eggert@cs.ucla.edu>
745
746 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
747 * editfns.c: Rewrite current-time-zone so that it invokes
748 the equivalent of (format-time-string "%Z") to get the time zone name.
749 This fixes a bug when the time zone name contains characters that
750 need converting from the system time locale to Emacs internal format.
751 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
752 that patch fixed format-time-string to do the conversion, but
753 I forgot to fix current-time-zone.
754 (format_time_string): New function, containing most of
755 what Fformat_time_string used to contain.
756 (Fformat_time_string): Rewrite in terms of format_time_string.
757 This doesn't change this function's behavior.
758 (current-time-zone): Rewrite to use format_time_string.
759 This fixes the bug reported by Michael Schierl in
760 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
761 Jason Rumney's 2007-06-07 change worked around this bug, but
762 didn't fix it.
763 * systime.h (tzname, timezone): Remove no-longer-used declarations.
764
8547b010
EZ
7652011-10-19 Eli Zaretskii <eliz@gnu.org>
766
767 * xdisp.c (start_display): If the character at POS is displayed
768 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
769 (try_window_reusing_current_matrix): If a line ends in a display
770 vector or the next line starts in a display vector, continue
771 redrawing the window even though the character position of
772 start_row was reached.
8547b010
EZ
773 (Bug#9771, part 2)
774
4e948d15
CY
7752011-10-18 Chong Yidong <cyd@gnu.org>
776
777 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
778 with nobreak-char-display too.
779
4787455f
EZ
7802011-10-18 Eli Zaretskii <eliz@gnu.org>
781
782 Fix part 3 of bug#9771.
783 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
784 (bidi_resolve_neutral): Don't enter the expensive loop looking for
785 non-neutral characters if the current character is a paragraph
786 separator (a.k.a. Newline). This avoids running the same
787 expensive loop twice, once when we consume the preceding newline
788 and the other time when the line actually needs to be displayed.
789 Avoid the loop when we see neutrals on the base embedding level
790 following a character whose directionality is the same as the
791 paragraph's. This avoids running the expensive loop when a line
792 ends in a long sequence of neutrals, like control characters.
793 Add assertion against STRONG_AL type. Slightly rearrange code
794 that determines the type of a neutral given the first non-neutral
795 that follows it.
796 (bidi_level_of_next_char): Set next_en_pos to zero when
797 invalidating its info.
798
2c91f553
EZ
7992011-10-17 Eli Zaretskii <eliz@gnu.org>
800
801 * xdisp.c (push_display_prop): Determine whether to record string
802 or buffer position by IT->string, not by IT->method. Allow
803 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
804 (move_it_vertically_backward): Don't look for character position
805 immediately after the newline when in a continuation line.
806 (Bug#9771, part 1)
2c91f553 807
c7b08b0d
MR
8082011-10-15 Martin Rudalics <rudalics@gmx.at>
809
810 * window.c (coordinates_in_window): Rewrite and delabelize
811 vertical border check. (Bug#5357) (Bug#9618)
812
6b02f655
SM
8132011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
814
815 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
816 errors in XSetWindowBorder (bug#9310).
817
81d40c92
DA
8182011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
819
820 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
821 avoid crash when xmalloc overrun checking is enabled.
822
d4172c3b
EZ
8232011-10-13 Eli Zaretskii <eliz@gnu.org>
824
825 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
826 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
827 cursor motion with <left> and <right> arrow keys.
828
829 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
830 some callers set that themselves.
831
b00eea75
EZ
8322011-10-12 Eli Zaretskii <eliz@gnu.org>
833
834 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
835 display string and the previous row comes from the same string and
836 is empty. (Bug#9739) (Bug#9738)
837
8fe012c4
SM
8382011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
839
840 * doc.c (get_doc_string): Encode file name (bug#9735).
841
0074aef2
EZ
8422011-10-12 Eli Zaretskii <eliz@gnu.org>
843
79beb178
EZ
844 * bidi.c (bidi_level_of_next_char):
845 * xdisp.c (get_visually_first_element): Remove old incorrect
846 comments regarding the Unicode Line Separator character.
847
0074aef2
EZ
848 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
849
6e4b3fbe
DA
8502011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
851
852 * alloc.c (Fgc_status): Do not access beyond zombies array
853 boundary if nzombies > MAX_ZOMBIES.
854 * alloc.c (dump_zombies): Add missing format specifier.
855
0324f3af
PE
8562011-10-12 Paul Eggert <eggert@cs.ucla.edu>
857
b5525cac
PE
858 * xdisp.c (set_cursor_from_row): Simplify conditionals,
859 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
860
0324f3af
PE
861 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
862 Some packages use them to denote characters with modifiers.
863
e9b5f888
AS
8642011-10-11 Andreas Schwab <schwab@linux-m68k.org>
865
866 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
867 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
868 matching a pp-number. Rename parameter var to var1.
869
127827c0
SM
8702011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
871
872 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
873
c8fd3bd0
GM
8742011-10-08 Glenn Morris <rgm@gnu.org>
875
876 * callint.c (Fcall_interactively): Give a more explicit error for the
877 'c' case with a non-character input. (Bug#8479)
878
352ec8ff
EZ
8792011-10-08 Eli Zaretskii <eliz@gnu.org>
880
03669ccb
EZ
881 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
882 lines.
7061c986
EZ
883 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
884 lines that are hscrolled on the left.
03669ccb 885
352ec8ff
EZ
886 * dispnew.c (buffer_posn_from_coords): Account for a possible
887 presence of header-line. (Bug#4426)
888
a66cfb1c
SM
8892011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
890
6b02f655
SM
891 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
892 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 893
7c5ee88e
PE
8942011-10-07 Paul Eggert <eggert@cs.ucla.edu>
895
896 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
897 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
898 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
899 this makes Emacs dump core during garbage collection on rare
900 occasions. sizeof is obviously inferior to offsetof here, so
901 stick with offsetof.
902 (GC_POINTER_ALIGNMENT): New macro.
903 (mark_memory): Omit 3rd (offset) arg; caller changed.
904 Don't assume EMACS_INT alignment is the same as pointer alignment.
905
df1bbe5b
SM
9062011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
907
908 * keyboard.c (read_key_sequence_remapped): New var.
909 (read_key_sequence): Compute remapping in the right buffer.
910 (command_loop_1): Use read_key_sequence's remapping directly.
911
51553db6
SM
9122011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
913
32c1fffd
SM
914 * dired.c (file_name_completion): Don't expand file name.
915 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
916 before checking file name handler.
917
51553db6
SM
918 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
919 they've been requested explicitly (bug#9591).
920
b6bd1599 9212011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
922
923 * keymap.c (Fsingle_key_description): Use make_specified_string
924 instead of build_string to build string from push_key_description.
925 (Bug#5193)
926
f701dc2a
PE
9272011-09-30 Paul Eggert <eggert@cs.ucla.edu>
928
4222c55d
PE
929 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
930 This fixes a Y2038 bug on 64-bit hosts.
931 * buffer.c (reset_buffer):
932 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
933 (Fclear_buffer_auto_save_failure):
934 Use 0, not -1, to represent an unset failure time, since time_t
935 might not be signed.
936
f701dc2a
PE
937 Remove dependency on glibc malloc internals.
938 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
939 Move back here from lisp.h, but with their new implementations.
940 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
941 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
942 * charset.c (charset_table_init): New static var.
943 (syms_of_charset): Use it instead of xmalloc. This removes a
944 dependency on glibc malloc internals. See Eli Zaretskii's comment in
945 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
946 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
947 Move back to alloc.c.
948 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
949 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
950
9ceebf39
JD
9512011-09-30 Jan Djärv <jan.h.d@swipnet.se>
952
953 * nsterm.m (windowDidResize): Call x_set_window_size only when
954 ns_in_resize is true. Otherwise set pixelwidth/height and
955 call change_frame_size (Bug#9628).
956
cb993c58
PE
9572011-09-30 Paul Eggert <eggert@cs.ucla.edu>
958
3930c88b
PE
959 Port --enable-checking=all to Fedora 14 x86-64.
960 * charset.c (syms_of_charset): Also account for glibc malloc's
961 internal overhead when calculating the initial malloc maximum.
962
cb993c58
PE
963 Port --enable-checking=all to Fedora 14 x86.
964 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
965 Move to lisp.h.
966 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
967 (overrun_check_realloc, overrun_check_free):
968 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
969 That way, xmalloc returns a properly-aligned pointer even if
970 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
971 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
972 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
973 into account when calculating the initial malloc maximum.
974 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
975 Move here from alloc.c, so that charset.c can use it too.
976 Properly align; the old code wasn't right for common 32-bit hosts
977 when configured with --enable-checking=all.
978 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
979 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
980
31bed486
EZ
9812011-09-29 Eli Zaretskii <eliz@gnu.org>
982
04c70788 983 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
984 use EDOM.
985
fbcaa2f3
EZ
9862011-09-28 Eli Zaretskii <eliz@gnu.org>
987
988 * xdisp.c (compute_display_string_end): If there's no display
989 string at CHARPOS, return -1.
990
991 * bidi.c (bidi_fetch_char): When compute_display_string_end
992 returns a negative value, treat the character as a normal
993 character not covered by a display string. (Bug#9624)
994
a239d4e9
JB
9952011-09-28 Juanma Barranquero <lekktu@gmail.com>
996
997 * lread.c (Fread_from_string): Fix typo in docstring.
998
88652fd5
EZ
9992011-09-27 Eli Zaretskii <eliz@gnu.org>
1000
1001 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1002 newline, reseat the iterator instead of bidi-iterating there one
1003 character at a time. (Bug#9610)
32c1fffd
SM
1004 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1005 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1006
ed497dd4
AS
10072011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1008
1009 * lread.c (readevalloop): Use correct code for NBSP.
1010 (read1): Likewise. (Bug#9608)
1011
b2bf61aa
MA
10122011-09-25 Michael Albinus <michael.albinus@gmx.de>
1013
1014 * dbusbind.c (Fdbus_register_signal): When service is not
1015 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1016
32bbb17c
GM
10172011-09-25 Glenn Morris <rgm@gnu.org>
1018
1019 * buffer.c (truncate-lines): Doc fix.
1020
94e0933e
CY
10212011-09-24 Chong Yidong <cyd@stupidchicken.com>
1022
1023 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1024 (Fset_window_next_buffers): Doc fix.
1025
cddde921
GM
10262011-09-24 Glenn Morris <rgm@gnu.org>
1027
1028 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1029
1260aef1
PE
10302011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1031
25b4bfa0
PE
1032 Fix minor problems found by static checking.
1033 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1034 * indent.c (Fvertical_motion): Fix == vs = typo.
1035
e3cbd34b
EZ
10362011-09-24 Eli Zaretskii <eliz@gnu.org>
1037
a66cfb1c
SM
1038 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1039 Default value is now t. Doc fix.
6bf7006f 1040
e3cbd34b 1041 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1042 logic when moving up, not only when moving down. Fix the
e3cbd34b 1043 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1044 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1045
1046 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1047 CHARPOS is covered by a display string which includes newlines.
1048 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1049 is covered by a display string with embedded newlines.
1050
a3de0cbd
MA
10512011-09-24 Michael Albinus <michael.albinus@gmx.de>
1052
1053 * dbusbind.c (Fdbus_register_signal): Add match rule to
1054 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1055 (Fdbus_register_method, Vdbus_registered_objects_table):
1056 Fix docstring.
a3de0cbd 1057
b260039d
JM
10582011-09-24 Jim Meyering <meyering@redhat.com>
1059
32c1fffd 1060 do not ignore write error for any output size
b260039d
JM
1061 The previous change was incomplete.
1062 While it makes emacs --batch detect the vast majority of stdout
1063 write failures, errors were still ignored whenever the output size is
1064 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1065 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1066 && echo FAIL: ignored write error
1067 FAIL: ignored write error
1068 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1069 && echo FAIL: ignored write error
1070 FAIL: ignored write error
1071 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1072
8eca8a7c
AS
10732011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1074
1075 * emacs.c (Fkill_emacs): In noninteractive mode exit
1076 non-successfully if a write error occurred on stdout. (Bug#9574)
1077
3341db62
EZ
10782011-09-21 Eli Zaretskii <eliz@gnu.org>
1079
1080 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1081 the xassert test.
1082
1083 * dispextern.h (struct it): Update the comment documenting what
1084 can it->OBJECT be.
1085
8c203dbf
EZ
10862011-09-20 Eli Zaretskii <eliz@gnu.org>
1087
1088 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1089 a display string, extend search for cursor position to end of row.
1090 (find_row_edges): If the row ends in a newline from a display
1091 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1092 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1093 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1094 non-empty line. Fixes confusing cursor motion with arrow keys at
1095 the beginning of a line that starts with whitespace.
8c203dbf 1096
a4824228
LMI
10972011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1098
1099 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1100 (bug#9493).
1101
33ed493b
CY
11022011-09-18 Chong Yidong <cyd@stupidchicken.com>
1103
1104 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1105 boolean (Bug#9154).
1106
56cd55c8
EZ
11072011-09-18 Eli Zaretskii <eliz@gnu.org>
1108
1109 * xdisp.c (display_line): Record maximum and minimum buffer
1110 positions even if no glyphs were produced (e.g., by a zero-width
1111 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1112 buffer positions that will be removed from the glyph row because
1113 they don't fit.
c02dcedf
EZ
1114 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1115 column is beyond frame width: don't subtract 1 "pixel" when
1116 computing width of the stretch.
3e62b7e0
EZ
1117 (reseat_at_next_visible_line_start): Undo the change made on
1118 2011-09-17 that saved paragraph information and restored it after
1119 the call to `reseat'. (Bug#9545)
56cd55c8 1120
5ed99d36 11212011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1122
1123 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1124 and turn window cursor on if cleared (Bug#9415).
1125
5ed99d36 11262011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1127
1128 * search.c (boyer_moore): Take unibyte characters from pattern
1129 literally. (Bug#9458)
1130
9bade7b2
EZ
11312011-09-18 Eli Zaretskii <eliz@gnu.org>
1132
1133 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1134
e5e9d610
PE
11352011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1136
87e4427a
PE
1137 Fix minor problem found by static checking.
1138 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1139 initialized, to pacify gcc -Wuninitialized.
1140
e5e9d610
PE
1141 * fileio.c: Report proper errno when syscall falls.
1142 (Finsert_file_contents): Save and restore errno,
1143 so that report_file_error outputs the correct diagnostic.
1144 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1145
a1674f0b
EZ
11462011-09-18 Eli Zaretskii <eliz@gnu.org>
1147
1148 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1149
fbfb6dd4
EZ
11502011-09-17 Eli Zaretskii <eliz@gnu.org>
1151
1152 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1153 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1154
bb187662
EZ
11552011-09-17 Eli Zaretskii <eliz@gnu.org>
1156
1137e8b8 1157 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1158 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1159
1160 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1161 (bidi_find_paragraph_start): Search back for paragraph beginning
1162 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1163 (bidi_move_to_visually_next): Only trigger paragraph-related
1164 computations when the last character is a newline or at EOB, not
1165 just any NEUTRAL_B. (Bug#9470)
1166
bb187662
EZ
1167 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1168 truncated lines if point is covered by a display string. (Bug#9524)
1169
2e621251
PE
11702011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1171
1172 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1173 (cons_to_x_long): New function.
1174 (lisp_data_to_selection_data): Use it. Correct the test for
1175 short-versus-long data; it was negated. Break out of vector
1176 loop, for efficiency, when a long datum is discovered.
1177
91a15bc6
SM
11782011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1179
1180 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1181
b41c3a35
EZ
11822011-09-16 Eli Zaretskii <eliz@gnu.org>
1183
1184 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1185 GCC PR/17406) by declaring this function with external scope.
1186
7812ba2d
PE
11872011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1188
1189 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1190 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1191
cf7edc2a
AS
11922011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1193
1194 * editfns.c (Fformat): Correctly handle text properties on "%%".
1195
bd01620e
EZ
11962011-09-15 Eli Zaretskii <eliz@gnu.org>
1197
1198 * xterm.c (x_draw_composite_glyph_string_foreground):
1199 * w32term.c (x_draw_composite_glyph_string_foreground):
1200 * term.c (encode_terminal_code):
1201 * composite.c (composition_update_it, get_composition_id):
1202 * xdisp.c (get_next_display_element)
1203 (fill_composite_glyph_string): Add comments about special meaning
1204 of TAB characters in a composition.
1205
a02719a3
PE
12062011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1207
1208 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1209 This occurs when processing a multibyte format.
1210 Problem reported by Wolfgang Jenker.
a02719a3 1211
72589a3c
JB
12122011-09-15 Johan Bockgård <bojohan@gnu.org>
1213
1214 * xdisp.c (try_cursor_movement): Only check for exact match if
1215 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1216
1c14176c
PE
12172011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1218
1219 Remove unused external symbols.
1220 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1221 * xdisp.c (calc_pixel_width_or_height): Now static.
1222 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1223 * indent.c (check_display_width):
1224 * w32term.c: Fix comment to match code.
1225 * xterm.c, xterm.h (x_catching_errors): Remove.
1226
d2eea5b5
PE
12272011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1228
1229 * xselect.c: Use signed conversions more consistently (Bug#9498).
1230 (selection_data_to_lisp_data): Assume incoming selection data are
1231 signed integers, not unsigned. This is to be consistent with
1232 outgoing selection data, which was modified to use signed integers
1233 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1234 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1235 expects long, not unsigned long.
1236
46888499
EZ
12372011-09-14 Eli Zaretskii <eliz@gnu.org>
1238
1239 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1240 computation of loop end. Reported by Johan Bockgård
1241 <bojohan@gnu.org>.
1242
ef8ef9fb
CY
12432011-09-13 Chong Yidong <cyd@stupidchicken.com>
1244
1245 * frame.c (Fother_visible_frames_p): Function deleted.
1246
fa819fed
EZ
12472011-09-12 Eli Zaretskii <eliz@gnu.org>
1248
1249 * indent.c (compute_motion): Process display vector front to back
1250 rather than the other way around. (Bug#2496)
1251
2ba8e008
SM
12522011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1253
1254 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1255
20f53c69
CY
12562011-09-11 Chong Yidong <cyd@stupidchicken.com>
1257
1258 * minibuf.c (Fread_from_minibuffer): Doc fix.
1259
d562d7a4
EZ
12602011-09-11 Eli Zaretskii <eliz@gnu.org>
1261
1262 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1263 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1264
1c4d7f3d
LMI
12652011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1266
1267 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1268 value for non-existent files.
1269
b885bf36
EZ
12702011-09-11 Eli Zaretskii <eliz@gnu.org>
1271
1272 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1273 set its "size" to -1. This will set the modtime_size field of
1274 the corresponding buffer to -1, which is what
1275 verify-visited-file-modtime expects for files that do not exist.
1276 (Bug#9139)
1277
6612f0bf
PE
12782011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1279
1280 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1281 here ...
1282 * lisp.h: ... from here. push_key_description is no longer
1283 defined in keyboard.c, so its declaration should not be in
1284 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1285 logically belongs with push_key_description.
1286
dfb3f755
PE
12872011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1288
1289 * buffer.h: Include <sys/types.h> instead of <time.h>.
1290 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1291 Problem reported by Herbert J. Skuhra.
1292
3134906c
LMI
12932011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1294
1295 * xml.c (parse_region): Make the parsing work for
1296 non-comment-starting XML files again (bug#9144).
1297
8d903f4e
AS
12982011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1299
1300 * image.c (gif_load): Fix calculation of bottom and right corner.
1301 (Bug#9468)
1302
80ad64f4
EZ
13032011-09-10 Eli Zaretskii <eliz@gnu.org>
1304
1305 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1306 redisplay in small windows.
1307
208a048d
EZ
13082011-09-09 Eli Zaretskii <eliz@gnu.org>
1309
1310 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1311
9b1c252e
MR
13122011-09-08 Martin Rudalics <rudalics@gmx.at>
1313
1314 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1315 Operate on live windows only.
1316
2949f33b
JB
13172011-09-08 Juanma Barranquero <lekktu@gmail.com>
1318
1319 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1320
e08dcafd
EZ
13212011-09-07 Eli Zaretskii <eliz@gnu.org>
1322
1323 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1324 only under bidi iteration.
1325
115b96bd
JD
13262011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1327
1328 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1329
c8199d0f
PE
13302011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1331
1332 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1333 Without this fix, the command to link temacs failed due to an
1334 undefined symbol __builtin_isnan. This is because
1335 /usr/include/iso/math_c99.h #defines isnan(x) to
1336 __builtin_isnan(x), but the bundled gcc, which identifies itself
1337 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1338 a __builtin_isnan.
1339 * floatfns.c (isnan): #undef, and then #define to a clone of
1340 what's in data.c.
1341 (Fisnan): Always define, since it's always available now.
1342 (syms_of_floatfns): Always define isnan at the Lisp level.
1343
e39b275c 13442011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1345
1346 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1347
b2db44d9 13482011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1349
f4af5137 1350 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1351 The previous code assumed that file offsets (off_t values) fit in
1352 EMACS_INT variables, which is not true on typical 32-bit hosts.
1353 The code messed up by falsely reporting buffer overflow in cases
1354 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1355 when "big" contains more than 2**29 bytes, even though this
1356 inserts just one byte and does not overflow the buffer.
1357 (Finsert_file_contents): Store file offsets as off_t
1358 values, not as EMACS_INT values. Check for overflow when
1359 converting between EMACS_INT and off_t. When checking for
1360 buffer overflow or for overlap, take the offsets into account.
1361 Don't use EMACS_INT for small values where int suffices.
1362 When checking for overlap, fix a typo: ZV was used where
1363 ZV_BYTE was intended.
1364 (Fwrite_region): Don't assume off_t fits into 'long'.
1365 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1366
ecfc0a49
MA
13672011-09-05 Michael Albinus <michael.albinus@gmx.de>
1368
1369 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1370
6511acf2 13712011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1372
0999621a 1373 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1374
1375 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1376 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1377 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1378 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1379 (modify_event_symbol): Do not assume that the length of
1380 name_alist_or_stem is safe to alloca and fits in int.
1381 (Fexecute_extended_command): Likewise for function name and binding.
1382 (Frecursion_depth): Wrap around reliably on integer overflow.
1383 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1384 since some callers pass EMACS_INT values.
1385 (Fsingle_key_description): Don't crash if symbol name contains more
1386 than MAX_ALLOCA bytes.
1387 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1388 (get_minibuffer): Arg is now EMACS_INT, not int.
1389 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1390 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1391 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1392
2be7d702
PE
1393 * dbusbind.c (signature_cat): New function.
1394 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1395 Do not overrun buffer; instead, report string overflow.
1396
9d1df220
PE
1397 * dispnew.c (add_window_display_history): Don't overrun buffer.
1398 Truncate instead; this is OK since it's just a log.
1399
33ef5c64
PE
1400 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1401 even if the time zone offset is outlandishly large.
1402 Don't mishandle offset == INT_MIN.
1403
66c6fdd5
PE
1404 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1405 when creating daemon; the previous buffer-overflow check was incorrect.
1406
d749b01b
PE
1407 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1408 which has the guts of the old verror function.
1409
b5cd1905
PE
1410 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1411 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1412
6e1a67fb
PE
1413 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1414 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1415 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1416 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1417 length of string rather than counting it via multiple sprintfs;
1418 that's simpler and more reliable.
c21721cc
PE
1419 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1420 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1421 sprintf, in case result does not fit in int.
1422
c57b67fc
PE
1423 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1424 (fontset_from_font): Print it.
1425
8a401434
PE
1426 * frame.c (tty_frame_count): Now printmax_t, not int.
1427 (make_terminal_frame, set_term_frame_name): Print it.
1428 (x_report_frame_params): In X, window IDs are unsigned long,
1429 not signed long, so print them as unsigned.
1430 (validate_x_resource_name): Check for implausibly long names,
1431 and don't assume name length fits in 'int'.
1432 (x_get_resource_string): Don't blindly alloca invocation name;
1433 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1434 not fit in int.
1435
6e1a67fb
PE
1436 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1437 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1438 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1439
0df02bf3
PE
1440 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1441 Use esprintf, not sprintf, in case result does not fit in int.
1442
48e30793
PE
1443 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1444 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1445 it as a large positive number.
1446 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1447 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1448
a66ff6d8
PE
1449 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1450 in case result does not fit in int.
1451
aca216ff
PE
1452 * print.c (float_to_string): Detect width overflow more reliably.
1453 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1454 buffer overrun. Don't assume list length fits in 'int'. Treat
1455 print length of 0 as 0, not as infinity; to be consistent with other
1456 uses of print length in this function. Don't overflow print length
1457 index. Don't assume hash table size fits in 'long', or that
1458 vectorlike size fits in 'unsigned long'.
1459
31c286f7
PE
1460 * process.c (make_process): Use printmax_t, not int, to format
1461 process-name gensyms.
1462
55e5faa1
PE
1463 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1464
80f2e268
PE
1465 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1466 to avoid potential buffer overrun.
1467
670741ab
PE
1468 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1469 if X resource line is longer than 512 bytes.
1470
b7163a50
PE
1471 * xfns.c (x_window): Make sprintf buffer a bit bigger
1472 to avoid potential buffer overrun.
1473
ae58ff1f
PE
1474 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1475
c43c8a6a
PE
1476 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1477
3f8236f4
PE
14782011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1479
53e9fe90 1480 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1481 Without these, Emacs silently mishandles large integers sometimes.
1482 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1483 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1484
6511acf2
PE
1485 * xdisp.c (try_window_id): Check Emacs fixnum range before
1486 converting to 'int'.
806add1d 1487
6511acf2 1488 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1489 Check that an Emacs fixnum is in range before assigning it to 'int'.
1490 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1491 values converted from Emacs fixnums.
1492 (Frecenter): Don't wrap around a line count if it is out of 'int'
1493 range; instead, treat it as an extreme value.
1494 (Fset_window_configuration, compare_window_configurations):
1495 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1496
6511acf2
PE
1497 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1498 that can exceed INT_MAX. Check that EMACS_INT value is in range
1499 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1500 (match_limit): Don't assume that a fixnum can fit in 'int'.
1501
6511acf2 1502 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1503 exceed INT_MAX.
1504
6511acf2 1505 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1506 (Fvertical_motion): Don't wrap around LINES values that don't fit
1507 in 'int'. Instead, treat them as extreme values. This is good
1508 enough for windows, which can't have more than INT_MAX lines anyway.
1509
fcb901a7
LMI
15102011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1511
0f2f6b6d
LMI
1512 * Require libxml/parser.h to avoid compilation warning.
1513
fcb901a7
LMI
1514 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1515
1516 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1517 since this reportedly can destroy thread storage.
1518
6e20a0d4
CY
15192011-08-30 Chong Yidong <cyd@stupidchicken.com>
1520
1521 * syntax.c (find_defun_start): Update all cache variables if
1522 exiting early (Bug#9401).
1523
148ae00e
EZ
15242011-08-30 Eli Zaretskii <eliz@gnu.org>
1525
f6cfbd8f
EZ
1526 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1527
148ae00e
EZ
1528 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1529 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1530 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1531
1532 * term.c (tty_append_glyph): New function.
1533 (produce_stretch_glyph): Static function and its prototype deleted.
1534
a66cfb1c
SM
1535 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1536 Add prototypes.
148ae00e 1537
c4a07a4c
PE
15382011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1539
1540 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1541 when checking :margin (Bug#9390).
1542 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1543 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1544 so that the name doesn't mislead. All uses changed.
1545
6bc8cd65
JB
15462011-08-28 Johan Bockgård <bojohan@gnu.org>
1547
1548 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1549 set_tty_hooks.
1550
dca4927e
EZ
15512011-08-27 Eli Zaretskii <eliz@gnu.org>
1552
1553 * xdisp.c (move_it_to): Don't bail out early when reaching
1554 position beyond to_charpos, if we are scanning backwards.
1555 (move_it_vertically_backward): When DY == 0, make sure we get to
1556 the first character in the line after the newline.
1557
f2cad773
PE
15582011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1559
1560 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1561 (ccl_driver): Do not generate an out-of-range pointer.
1562 (Fccl_execute_on_string): Remove unnecessary check for
1563 integer overflow, noted by Stefan Monnier in
1564 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1565 Remove a FIXME that didn't need fixing.
1566 Simplify the newly-introduced buffer reallocation code.
1567
0cae2cdb
JB
15682011-08-27 Juanma Barranquero <lekktu@gmail.com>
1569
1570 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1571
5fc295a4 15722011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1573
70c60eb2 1574 Integer and memory overflow issues (Bug#9196).
726e0ab1 1575
d31850da
PE
1576 * doc.c (get_doc_string): Rework so that
1577 get_doc_string_buffer_size is the actual buffer size, rather than
1578 being 1 less than the actual buffer size; this makes xpalloc more
1579 convenient.
1580
a69fbedb
PE
1581 * image.c (x_allocate_bitmap_record, cache_image):
1582 * xselect.c (Fx_register_dnd_atom):
1583 Simplify previous changes by using xpalloc.
1584
fe5c5d37
PE
1585 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1586 since either will do and ptrdiff_t is convenient with xpalloc.
1587
0065d054
PE
1588 * charset.c (charset_table_size)
1589 (struct charset_sort_data.priority): Now ptrdiff_t.
1590 (charset_compare): Don't overflow if priorities differ greatly.
1591 (Fsort_charsets): Don't assume list length fits in int.
1592 Check for size-calculation overflow when allocating sort data.
1593 (syms_of_charset): Allocate an initial charset table that is
1594 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1595
1596 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1597
1598 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1599 The actual value is always <= INT_MAX, and leaving it unsigned made
1600 overflow checking harder.
1601
1602 * dispextern.h (struct glyph_matrix.rows_allocated)
1603 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1604 with xpalloc. The values are still always <= INT_MAX.
1605
1606 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1607
1608 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1609 (SAFE_NALLOCA): New macro.
1610
1611 * region-cache.c (struct boundary.pos, find_cache_boundary)
1612 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1613 (set_cache_region, invalidate_region_cache)
1614 (revalidate_region_cache, know_region_cache, region_cache_forward)
1615 (region_cache_backward, pp_cache):
1616 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1617 so that ptrdiff_t * can be passed to xpalloc.
1618 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1619 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1620 (pp_cache): Don't assume cache_len fits in int.
1621 * region-cache.h: Adjust extern decls to match.
1622
1623 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1624 EMACS_INT, since either will do, for xpalloc.
1625
1626 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1627 (xnmalloc, xnrealloc, xpalloc): New functions.
1628
726e0ab1
PE
1629 * bidi.c (bidi_shelve_header_size): New constant.
1630 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1631 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1632
51f30bc5 1633 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1634 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1635 (overlay_strings):
1636 Don't update size of array until after memory allocation succeeds,
1637 because xmalloc/xrealloc may not return.
0065d054
PE
1638 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1639 now that we have proper integer overflow checking.
1640 (record_overlay_string, overlay_strings): Catch overflows when
1641 calculating size of overlay_str_buf.
726e0ab1 1642
0065d054
PE
1643 * callproc.c (Fcall_process): Check for size overflow when
1644 calculating size of args2.
1645 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1646 Normally we prefer signed values, but sticking with ptrdiff_t would
1647 require adding more-complicated checks.
726e0ab1
PE
1648
1649 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1650 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1651 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1652 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1653
1654 * character.c (Fstring): Check for size-calculation overflow.
1655
1656 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1657 unnecessary integer overflow. Check for size overflow.
1658 (encode_coding_object): Don't update size until xmalloc succeeds.
1659
1660 * composite.c (get_composition_id): Check for overflow in glyph
1661 length calculations.
1662
1663 Integer and memory overflow fixes for display code.
1664 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1665 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1666 (scrolling_window): Check for overflow in size calculations.
1667 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1668 Don't assume glyph table len fits in int.
1669 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1670 (row_table_size): Now ptrdiff_t, not int.
1671 (scrolling_window): Avoid overflow in size calculations.
1672 Don't update size until allocation succeeds.
1673 * fns.c (concat): Check for overflow in size calculations.
1674 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1675 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1676 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1677
1678 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1679 (get_doc_string): Check for size calculation overflow.
1680 Don't update size until allocation succeeds.
1681 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1682 EMACS_INT, where ptrdiff_t will do.
1683 (Fsubstitute_command_keys): Check for string overflow.
1684
1685 * editfns.c (set_time_zone_rule): Don't assume environment length
1686 fits in int.
1687 (message_length): Now ptrdiff_t, not int.
1688 (Fmessage_box): Don't update size until allocation succeeds.
1689 Don't assume message length fits in int.
1690 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1691
0065d054
PE
1692 * emacs.c (main): Do not reallocate argv, since there is a null at
1693 the end that can be overwritten, and this way there's no need to
1694 worry about size-calculation overflow.
1695 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1696
1697 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1698 alloc succeeds.
1699 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1700
1701 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1702 (x_set_scroll_bar_width, x_figure_window_size):
1703 Check for integer overflow.
1704 (x_set_alpha): Do not assume XINT fits in int.
1705
1706 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1707 This is for the members text_lines, text_cols, total_lines, total_cols,
1708 where the system imposes an 'int' limit.
1709
1710 * fringe.c (Fdefine_fringe_bitmap):
1711 Don't update size until alloc works.
1712
1713 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1714 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1715
1716 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1717 Check for size-calculation overflow.
1718 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1719 do, as we prefer signed integers.
1720 (id_to_widget.max_size, id_to_widget.used)
1721 (xg_store_widget_in_map, xg_remove_widget_from_map)
1722 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1723 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1724 Use and return ptrdiff_t, not int.
1725 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1726 * gtkutil.h: Change prototypes to match the above.
1727
1728 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1729 are duplicate now that they've been promoted to lisp.h.
1730 (x_allocate_bitmap_record, x_alloc_image_color)
1731 (make_image_cache, cache_image, xpm_load):
1732 Don't update size until alloc is done.
1733 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1734 (x_detect_edges):
3256efce 1735 Check for size calculation overflow.
726e0ab1
PE
1736 (ct_colors_allocated_max): New constant.
1737 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1738 overflow.
3256efce 1739
726e0ab1
PE
1740 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1741 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1742 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1743 Use ptrdiff_t, not int, to count maps.
1744 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1745 calculations. Don't update size until allocation succeeds.
1746 Redo calculations to avoid overflow.
726e0ab1
PE
1747 * keyboard.h: Change prototypes to match the above.
1748
1749 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1750 to count maps.
1751 (current_minor_maps): Check for size calculation overflow.
1752 * keymap.h: Change prototypes to match the above.
1753
1754 * lread.c (read1, init_obarray): Don't update size until alloc done.
1755
1756 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1757 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1758
726e0ab1
PE
1759 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1760 Now ptrdiff_t, not int.
1761 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1762 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1763
1764 * process.c (Fnetwork_interface_list): Check for overflow
1765 in size calculation.
1766
1767 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1768
1769 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1770 overflow. Don't bother calling xmalloc when xrealloc will do.
1771
1772 * search.c (Freplace_match): Check for size calculation overflow.
1773 (Fset_match_data): Don't assume list lengths fit in 'int'.
1774
1775 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1776 for command line length. Do not attempt to address one before the
1777 beginning of an array, as that's not portable.
1778
1779 * term.c (max_frame_lines): Remove; unused.
1780 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1781 not int.
1782 (encode_terminal_code, calculate_costs): Check for size
1783 calculation overflow.
1784 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1785 table lengths and related sizes. Don't update size until alloc
1786 done. Redo calculations to avoid overflow.
1787 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1788
1789 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1790 subtracting pointers.
1791 (gobble_line): Check for overflow more carefully. Don't update size
1792 until alloc done.
1793
1794 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1795 Don't update size until alloc done.
1796 Redo size calculations to avoid overflow.
1797 Check for size calculation overflow.
0065d054 1798 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1799
1800 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1801 Use ptrdiff_t, not int, for sizes.
1802 (store_mode_line_noprop_char): Don't update size until alloc done.
1803
0065d054
PE
1804 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1805 Use ptrdiff_t, not int, for sizes.
1806 (Finternal_make_lisp_face, cache_face):
1807 Check for size calculation overflow.
1808 (cache_face): Treat size calculation overflows as if they were
1809 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1810
1811 * xfns.c (x_encode_text, x_set_name_internal)
1812 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1813 sizes, since they can exceed INT_MAX in size. Check for size
1814 calculation overflow.
1815
0065d054
PE
1816 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1817 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1818 Don't update size until alloc done.
1819
0065d054 1820 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1821 as sprintf is limited to int lengths.
1d526e2f 1822
252c5ee1
PE
1823 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1824 (X_LONG_MIN): New macros.
864d7ce7
PE
1825 Use them to make the following changes clearer.
1826 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1827 This change doesn't affect the value now, but it may help remind
1828 future maintainers not to raise the value too much later.
1829 (SELECTION_QUANTUM): Remove, replacing with ...
1830 (selection_quantum): ... new function, which avoids overflow.
1831 All uses changed.
1832 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1833 assumption that selection length fits in 'int'.
1834 (x_reply_selection_request, x_handle_selection_request)
1835 (x_get_window_property, receive_incremental_selection)
1836 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1837 (lisp_data_to_selection_data, clean_local_selection_data):
1838 Use ptrdiff_t, not int, to record length of selection.
1839 (x_reply_selection_request, x_get_window_property)
1840 (receive_incremental_selection, x_property_data_to_lisp):
1841 Redo calculations to avoid overflow.
1842 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1843 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1844 something.
1845 (x_get_window_property, receive_incremental_selection)
1846 (lisp_data_to_selection_data, x_property_data_to_lisp):
1847 Check for size-calculation overflow.
1848 (x_get_window_property, receive_incremental_selection)
1849 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1850 Don't store size until memory allocation succeeds.
1851 (x_get_window_property): Plug memory leak on memory exhaustion.
1852 Don't double-block input; malloc is safe here. Don't assume 2**34
1853 - 4 fits in unsigned long. Add an xassert to check
1854 XGetWindowProperty overflow. Be more careful about overflow
1855 calculations, and distinguish size from memory overflow better.
1856 (receive_incremental_selection): When tracing, don't assume
1857 unsigned int is less than INT_MAX.
1858 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1859 harmful) conversions of unsigned short to int.
1860 (lisp_data_to_selection_data): Don't assume that integers
1861 in the range -65535 through -1 fit in an X unsigned short.
1862 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1863 result parameters unless successful. Rely on cons_to_unsigned
1864 to report problems with elements; the old code wasn't right anyway.
1865 (x_check_property_data): Check for int overflow; we cannot use
1866 a wider type due to X limits.
1867 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1868
726e0ab1 1869 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1870
0065d054
PE
1871 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1872 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1873 (x_color_cells): Don't store size until memory allocation succeeds.
1874 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1875 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1876 (x_term_init): Don't assume length fits in int (sprintf is limited
1877 to int size).
bc18e09d 1878
ebfa62c0
PE
1879 Use ptrdiff_t for composition IDs.
1880 * character.c (lisp_string_width):
1881 * composite.c (composition_table_size, n_compositions)
1882 (get_composition_id, composition_gstring_from_id):
1883 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1884 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1885 * window.c (Frecenter):
1886 Use ptrdiff_t, not int, for composition IDs.
1887 * composite.c (get_composition_id): Check for integer overflow.
1888 * composite.h: Adjust prototypes to match the above changes.
1889
d3411f89
PE
1890 Use ptrdiff_t for hash table indexes.
1891 * category.c (hash_get_category_set):
1892 * ccl.c (ccl_driver):
1893 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1894 * coding.c (coding_system_charset_list, detect_coding_system):
1895 * coding.h (struct coding_system.id):
1896 * composite.c (get_composition_id, gstring_lookup_cache):
1897 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1898 * image.c (xpm_get_color_table_h):
1899 * lisp.h (hash_lookup, hash_put):
1900 * minibuf.c (Ftest_completion):
1901 Use ptrdiff_t for hash table indexes, not int (which is too
1902 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1903 32-bit --with-wide-int hosts).
1904
e097a6fa
PE
1905 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1906 Add a FIXME comment about memory leaks.
1907 (syms_of_charset): Don't assume xmalloc returns.
1908
5637687f
PE
1909 Don't assume that stated character widths fit in int.
1910 * character.c (Fchar_width, c_string_width, lisp_string_width):
1911 * character.h (CHAR_WIDTH):
1912 * indent.c (MULTIBYTE_BYTES_WIDTH):
1913 Use sanitize_char_width to avoid undefined and/or bad behavior
1914 with outlandish widths.
a66cfb1c 1915 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1916 now that we have two such functions. All uses changed.
1917 (sanitize_char_width): New inline function.
1918
a2271ba2
PE
1919 Don't assume that tab-width fits in int.
1920 * character.h (sanitize_width): New inline function.
1921 (SANE_TAB_WIDTH): New macro.
1922 (ASCII_CHAR_WIDTH): Use it.
1923 * indent.c (sane_tab_width): Remove. All uses replaced by
1924 SANE_TAB_WIDTH (current_buffer).
1925 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1926
18c52557
PE
1927 * fileio.c: Integer overflow issues with file modes.
1928 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1929
caeeedc1
PE
1930 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1931 Remove unreachable code.
1932 (read_hex, load_charset_map_from_file): Check for integer overflow.
1933
50849c52
PE
1934 * xterm.c: don't go over XClientMessageEvent limit
1935 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1936 (x_send_scroll_bar_event): Likewise. Check that the size does not
1937 exceed limits imposed by XClientMessageEvent, as well as the usual
1938 ptrdiff_t and size_t limits.
1939
b13995db
PE
1940 * keyboard.c: Overflow, signedness and related fixes.
1941 (make_lispy_movement): Use same integer type in forward decl
1942 that is used in the definition.
1943 (read_key_sequence, keyremap_step):
1944 Change bufsize argument back to int, undoing my 2011-03-30 change.
1945 We prefer signed types, and int is wide enough here.
1946 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1947 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1948 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1949 length, not size_t. Use ptrdiff_t for index, not int.
1950 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1951 possibility of integer overflow.
1952
13464394
PE
1953 Overflow, signedness and related fixes for images.
1954
1955 * dispextern.h (struct it.stack[0].u.image.image_id)
1956 (struct_it.image_id, struct image.id, struct image_cache.size)
1957 (struct image_cache.used, struct image_cache.ref_count):
1958 * gtkutil.c (update_frame_tool_bar):
1959 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1960 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1961 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1962 * nsmenu.m (update_frame_tool_bar):
1963 * xdisp.c (calc_pixel_width_or_height):
1964 * xfns.c (image_cache_refcount):
1965 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1966 on typical 64-bit hosts.
1967
1968 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1969 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1970 Omit unnecessary casts to int.
1971 (parse_image_spec): Check that integers fall into 'int' range
1972 when the callers expect that.
1973 (image_ascent): Redo ascent calculation to avoid int overflow.
1974 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1975 (lookup_image): Remove unnecessary tests.
1976 (xbm_image_p): Locals are now of int, not EMACS_INT,
1977 since parse_image_check makes sure they fit into int.
1978 (png_load, gif_load, svg_load_image):
1979 Prefer int to unsigned where either will do.
1980 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1981 old tiff_error_handler and tiff_warning_handler.
1982 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1983 stack buffer overflows. It uses only the features of vsnprintf
1984 that are common to both POSIX and native Microsoft.
1985 (tiff_error_handler, tiff_warning_handler): Use it.
1986 (tiff_load, gif_load, imagemagick_load_image):
1987 Don't assume :index value fits in 'int'.
1988 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1989 (imagemagick_load_image): Check that crop parameters fit into
1990 the integer types that MagickCropImage accepts. Don't assume
1991 Vimagemagick_render_type has a nonnegative value. Don't assume
1992 size_t fits in 'long'.
1993 (gs_load): Use printmax_t to print the widest integers possible.
1994 Check for integer overflow when computing image height and width.
1995
c11821d4
EZ
19962011-08-26 Eli Zaretskii <eliz@gnu.org>
1997
1998 * xdisp.c (redisplay_window): Don't force window start if point
1999 will be invisible in the resulting window. (Bug#9324)
2000
0c95fcf7
EZ
20012011-08-25 Eli Zaretskii <eliz@gnu.org>
2002
2003 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2004 the display spec is of the form `(space ...)'.
2005 (handle_display_spec): Return the value returned by
2006 handle_single_display_spec, not just 1 or zero.
2007 (handle_single_display_spec): If the display spec is of the form
2008 `(space ...)', and specifies display in the text area, return 2
2009 rather than 1.
fee65a97 2010 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2011 accurately, and prefer exact match for point under bidi.
2012 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2013
2014 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2015 into disp_prop; all users changed.
2016
2017 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2018 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2019 for the text covered by the display property.
2020
e4ed06f1
CY
20212011-08-25 Chong Yidong <cyd@stupidchicken.com>
2022
2023 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2024 Change return value to nil.
2025 (Frecord_buffer): Delete unused function.
2026
f67cdd7f
EZ
20272011-08-24 Eli Zaretskii <eliz@gnu.org>
2028
5980d4c6
EZ
2029 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2030 buffers, return left-to-right.
8610fe8b
EZ
2031 (set_cursor_from_row): Consider candidate row a win if its glyph
2032 represents a newline and point is on that newline. Fixes cursor
2033 positioning on the newline at EOL of R2L text within L2R
2034 paragraph, and vice versa.
2035 (try_cursor_movement): Check continued rows, in addition to
2036 continuation rows. Fixes unwarranted scroll when point enters a
2037 continued line of R2L text within an L2R paragraph, or vice versa.
2038 (cursor_row_p): Consider the case of point being equal to
2039 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2040 from the end of a short line to the beginning of a continued line
2041 of R2L text within L2R paragraph.
2042 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2043 composed characters.
5980d4c6 2044
f67cdd7f
EZ
2045 * bidi.c (bidi_check_type): Use xassert.
2046 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2047 members.
2048
bca633fb
EZ
20492011-08-23 Eli Zaretskii <eliz@gnu.org>
2050
2051 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2052 a character.
2053
4a5885a7
CY
20542011-08-23 Chong Yidong <cyd@stupidchicken.com>
2055
2056 * nsfont.m (ns_otf_to_script): Fix typo.
2057
0902a04e
KH
20582011-08-22 Kenichi Handa <handa@m17n.org>
2059
2060 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2061 extra slot even if the purpose is char-code-property-table.
2062
1a2e6670
EZ
20632011-08-23 Eli Zaretskii <eliz@gnu.org>
2064
8ddde651
EZ
2065 * xdisp.c (redisplay_window): When computing centering_position,
2066 account for the height of the header line. (Bug#8874)
2067
425cc014
EZ
2068 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2069 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2070 candidate is selected by the mouse, and that candidate has a
2071 composed character under the mouse.
2072
1a2e6670
EZ
2073 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2074 coordinates reported by pos-visible-in-window-p for a composed
2075 character in column zero.
2076
8b76d6f8
SM
20772011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2078
2079 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2080
dac347dd
EZ
20812011-08-22 Eli Zaretskii <eliz@gnu.org>
2082
2083 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2084 consider it a hit if to_charpos is anywhere in the range of the
2085 composed buffer positions.
2086
e013fb34
CY
20872011-08-22 Chong Yidong <cyd@stupidchicken.com>
2088
2089 * image.c (gif_load): Don't assume that each subimage has the same
2090 dimensions as the base image. Handle disposal method that is
2091 "undefined" by the gif spec (Bug#9335).
2092
bd1ba3e8
CY
20932011-08-20 Chong Yidong <cyd@stupidchicken.com>
2094
2095 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2096 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2097
54a1215b
EZ
20982011-08-19 Eli Zaretskii <eliz@gnu.org>
2099
823564e5
EZ
2100 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2101 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2102 from an Org mode buffer to a Speedbar frame.
2103
54a1215b
EZ
2104 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2105 a composition, take its buffer position from IT->cmp_it.charpos.
2106 Fixes cursor positioning at the beginning of a line that begins
2107 with a composed character.
2108
9778ebcc
EZ
21092011-08-18 Eli Zaretskii <eliz@gnu.org>
2110
0be6ee06
EZ
2111 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2112 character bidirectional type, use STRONG_L instead. Fixes crashes
2113 in a buffer produced by `describe-categories'.
2114
9778ebcc
EZ
2115 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2116 members before the level stack, so they would be saved and
2117 restored when copying iterator state. Fixes incorrect reordering
2118 around TABs covered by display properties.
2119
156bffbe
AS
21202011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2121
6b02f655 2122 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2123
72ad093b
CY
21242011-08-17 Chong Yidong <cyd@stupidchicken.com>
2125
2126 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2127 (internal_condition_case_2, internal_condition_case_n):
2128 Remove unnecessary aborts (Bug#9081).
72ad093b 2129
35774242
EZ
21302011-08-17 Eli Zaretskii <eliz@gnu.org>
2131
2132 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2133 has no `load' handler, try opening the file locally. (Bug#9311)
2134
db76dd85
KB
21352011-08-16 Ken Brown <kbrown@cornell.edu>
2136
2137 * gmalloc.c: Expand comment.
2138
b215eee5
EZ
21392011-08-16 Eli Zaretskii <eliz@gnu.org>
2140
2141 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2142 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2143
a4579d33
KB
21442011-08-16 Ken Brown <kbrown@cornell.edu>
2145
2146 Fix memory allocation problems in Cygwin build (Bug#9273).
2147
2148 * unexcw.c ( __malloc_initialized): Declare external variable.
2149 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2150
8b76d6f8
SM
2151 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2152 New variables.
a4579d33
KB
2153 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2154 dumped emacs.
2155 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2156 in the static heap.
2157 [CYGWIN] (special_realloc): New function.
2158 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2159 requests to realloc storage in the static heap.
2160
3ebec551
PE
21612011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2162
2163 * bidi.c (bidi_initialize): Remove unused local.
2164
9fd8be00
EZ
21652011-08-15 Eli Zaretskii <eliz@gnu.org>
2166
6b02f655
SM
2167 * bidimirror.h:
2168 * biditype.h: Remove file.
2169 * makefile.w32-in ($(BLD)/bidi.$(O)):
2170 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2171
2172 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2173
2174 * chartab.c: Improve commentary for the uniprop_table API.
2175
32413314
EZ
2176 * bidi.c (bidi_paragraph_init): Support zero value of
2177 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2178 (bidi_initialize): Use uniprop_table instead of including
2179 biditype.h and bidimirror.h.
32413314 2180
9fd8be00
EZ
2181 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2182 coordinates of the iterator when restoring from ppos_it.
2183 (Bug#9296)
2184
5cf2b69b
KH
21852011-08-14 Kenichi Handa <handa@m17n.org>
2186
2187 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2188 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2189
daf17d00
EZ
21902011-08-14 Eli Zaretskii <eliz@gnu.org>
2191
2192 * xdisp.c (move_it_in_display_line_to): Don't invoke
2193 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2194 ppos_it. Fixes vertical cursor motion when line beginning is
2195 covered by an image. (Bug#9296)
2196
08e3161a
JD
21972011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2198
2199 * nsterm.h (ns_run_ascript): Declare.
2200 (NSAPP_DATA2_RUNASSCRIPT): Define.
2201
2202 * nsfns.m (as_script, as_result, as_status): New static variables.
2203 (ns_run_ascript): New function.
5e617bc2 2204 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2205 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2206 the event loop. Get status from as_status (Bug#7276).
2207
2208 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2209 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2210 the event loop (Bug#7276).
2211
a3720aa2
AS
22122011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2213
2214 * gnutls.c (QCgnutls_bootprop_priority)
2215 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2216 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2217 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2218 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2219 (QCgnutls_bootprop_verify_hostname_error)
2220 (QCgnutls_bootprop_callbacks_verify): Rename from
2221 Qgnutls_bootprop_..., all uses changed.
2222
2223 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2224 uses changed.
2225
0a0d27fb
PE
22262011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2227
19d5c50c
PE
2228 * xfaces.c (Qframe_set_background_mode): Now static.
2229 * dispextern.h (Qframe_set_background_mode): Remove decl.
2230
0a0d27fb
PE
2231 * process.c (Fnetwork_interface_info): Declare local only if needed.
2232
377538cb
JD
22332011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2234
2235 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2236 (Fnetwork_interface_list): Allocate in increments of bytes instead
2237 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2238 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2239 sockaddr.
2240 (struct ifflag_def): notrailers is smart on OSX.
2241 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2242 Get hardware address with getifaddrs if available.
2243
08fff70c
EZ
22442011-08-12 Eli Zaretskii <eliz@gnu.org>
2245
2246 * xdisp.c (iterate_out_of_display_property): xassert that
2247 IT->position is set to within IT->object's boundaries. Break from
2248 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2249 when IT->position is set up wrongly due to some bug.
2250 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2251 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2252 entry. Force push_it to save on the stack the current
2253 buffer/string position, to be restored by pop_it. Fix flags in
2254 the iterator structure wrt the object coming from a display
2255 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2256 properties. (Bug#9284)
2257
7be1c708 22582011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2259
7be1c708
CY
2260 * fontset.c (fontset_get_font_group): Add proper type checks.
2261 (Bug#9172)
aac0c6e3 2262
7be1c708 22632011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2264
7be1c708
CY
2265 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2266 and LC_VERSION_MIN_MACOSX.
2267 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2268 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2269
97bb72a6
EZ
22702011-08-08 Eli Zaretskii <eliz@gnu.org>
2271
2272 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2273 no-display-properties-and-no-overlays under bidi display.
2274 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2275 properties and overlays.
97bb72a6 2276
d5617611
CY
22772011-08-08 Chong Yidong <cyd@stupidchicken.com>
2278
37e11a63
CY
2279 * editfns.c (Fset_time_zone_rule): Document relationship with the
2280 setenv function.
2281
d5617611
CY
2282 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2283 the font entity extracted from the cache (Bug#8109).
2284
58872834
CY
22852011-08-07 Chong Yidong <cyd@stupidchicken.com>
2286
2287 * composite.c (autocmp_chars): Don't reset point. That is done by
2288 restore_point_unwind (Bug#5984).
2289
75bfc667
JL
22902011-08-07 Juri Linkov <juri@jurta.org>
2291
2292 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2293 to show the arg `TIME' instead of `TIMEVAL'.
2294
d1410150
EZ
22952011-08-06 Eli Zaretskii <eliz@gnu.org>
2296
2297 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2298 display property strides EOL and includes a newline, as in
2299 longlines-mode. (Bug#9254)
75b771e4
EZ
2300 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2301 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2302
2303 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2304 is non-zero, even if the data buffer is NULL. Fixes a crash in
2305 vertical-motion with longlines-mode. (Bug#9254)
2306
35928349
EZ
23072011-08-05 Eli Zaretskii <eliz@gnu.org>
2308
ec7cc85b
EZ
2309 * bidi.c <bidi_cache_total_alloc>: Now static.
2310 (bidi_initialize): Initialize bidi_cache_total_alloc.
2311
8b76d6f8 2312 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2313 cache. (Bug#9221)
2314
2315 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2316 amount allocated this far in `bidi_cache_total_alloc'.
2317 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2318 non-zero, only free the data buffer without restoring the cache
2319 contents. All callers changed.
2320
2321 * dispextern.h (bidi_unshelve_cache): Update prototype.
2322
2323 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2324 (move_it_in_display_line, move_it_to)
2325 (move_it_vertically_backward, move_it_by_lines): Replace the call
2326 to xfree to an equivalent call to bidi_unshelve_cache.
2327 (move_it_in_display_line_to): Fix logic of returning
412b6358 2328 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2329
e2e2423b
EZ
23302011-08-05 Eli Zaretskii <eliz@gnu.org>
2331
2332 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2333 came from a string character with a `cursor' property. (Bug#9229)
2334
ae9e757a
JD
23352011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2336
2337 * Makefile.in (LIB_PTHREAD): New variable.
2338 (LIBES): Add LIB_PTHREAD (Bug#9216).
2339
2340 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2341 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2342
213bd7f2
AS
23432011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2344
6b02f655 2345 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2346
99aaf75f
JD
23472011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2348
2349 * xterm.c (x_find_topmost_parent): New function.
2350 (x_set_frame_alpha): Find topmost parent window with
2351 x_find_topmost_parent and set the property there also (bug#9181).
2352 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2353
c74e9d86
PE
23542011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2355
2356 * callproc.c (Fcall_process): Avoid vfork clobbering
2357 the local vars buffer, coding_systems, current_dir.
2358
640c8776
SM
23592011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2360
2361 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2362
f26d0e4c
PE
23632011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2364
8a10d76c
PE
2365 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2366 so that it is not optimized away.
2367
f26d0e4c
PE
2368 * xdisp.c (compute_display_string_pos): Remove unused local.
2369
55439c61
EZ
23702011-08-02 Eli Zaretskii <eliz@gnu.org>
2371
2372 Fix slow cursor motion and scrolling in large buffers with
2373 selective display, like Org Mode buffers. (Bug#9218)
2374
2375 * dispextern.h (struct bidi_it): New member disp_prop_p.
2376
2377 * xdisp.c: Remove one-slot cache of display string positions.
2378 (compute_display_string_pos): Accept an additional argument
5e617bc2 2379 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2380 for a display string or property. If found, set DISP_PROP_P
2381 non-zero.
2382
2383 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2384 DISP_PROP_P, and pass it to compute_display_string_pos.
2385 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2386 non-zero. All callers of bidi_fetch_char changed.
2387
fb33fa43
SM
23882011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2389
2390 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2391
b099e063
DM
23922010-12-03 Don March <don@ohspite.net>
2393
2394 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2395 last character M-[char] is translated to ESC [char] (bug#7541).
2396
5cc7f7af
KH
23972011-08-02 Kenichi Handa <handa@m17n.org>
2398
d0fffa3f 2399 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2400
2401 * chartab.c (uniprop_table): Make it non-static.
2402
525d5e6e
EZ
24032011-08-01 Eli Zaretskii <eliz@gnu.org>
2404
2405 * xdisp.c (forward_to_next_line_start): Accept additional argument
2406 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2407 on the newline.
2408 (reseat_at_next_visible_line_start): Use the bidi iterator state
2409 returned by forward_to_next_line_start to restore the state of
2410 it->bidi_it after backing up to previous newline. (Bug#9212)
2411
31011111
AS
24122011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2413
2414 * regex.c (re_comp): Protoize.
2415 (re_exec): Fix return type.
2416 (regexec): Fix type of `ret'. (Bug#9203)
2417
476371c4
PE
24182011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2419
e5d76069
PE
2420 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2421 This is needed if max-image-size is a floating-point number.
2422
9a79b20c
AS
24232011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2424
2425 * print.c (print_object): Print empty symbol as ##.
2426
2427 * lread.c (read1): Read ## as empty symbol.
2428
d8c2fa78
AA
24292011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2430
2431 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2432 setting frame foreground color (Bug#9175).
2433 (x_set_background_color): Likewise.
2434
ffe57a7a
AA
2435 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2436 contents (Bug#9176).
2437 (EmacsTooltip -init): Remove bezels and add shadows to
2438 tooltip windows.
2439
bf3492a5
AA
2440 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2441 or scroll bar (Bug#8470).
2442
d55e9c53
AA
2443 * nsfont.m (nsfont_open): Remove assignment to voffset and
2444 unnecessary vars hshink, expand, hd, full_height, min_height.
2445 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2446
2447 * nsterm.h (nsfont_info): Remove voffset field.
2448
d8c2fa78 24492011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2450
2451 Implement strike-through and overline on NextStep (Bug#8863).
2452
2453 * nsfont.m (nsfont_open): Use underline position provided by font,
2454 instead of hard-coded value of 2.
2455 (nsfont_draw): Call ns_draw_text_decoration instead.
2456
2457 * nsterm.h: Add declaration for ns_draw_text_decoration.
2458
2459 * nsterm.m (ns_draw_text_decoration): New function for drawing
2460 underline, overline, and strike-through.
2461 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2462 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2463 accommodate underlining, etc.
4843aac3 2464
4cc60b9b
EZ
24652011-07-28 Eli Zaretskii <eliz@gnu.org>
2466
bc7ece87
EZ
2467 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2468 default.
4cc60b9b 2469
476371c4
PE
24702011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2471
66606eea
PE
2472 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2473 Without this fix, if a signal arrives just after memory fills up,
2474 'malloc' might be invoked reentrantly.
2475
476371c4
PE
2476 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2477 In other words, assume that every image size is allowed, on non-X
2478 hosts. This assumption is probably wrong, but it lets Emacs compile.
2479
f3fcc40d
AS
24802011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2481
2482 * regex.c (re_iswctype): Convert return values to boolean.
2483
350c992f
EZ
24842011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2485
2486 * xdisp.c (compute_display_string_pos): Don't use cached display
2487 string position if the buffer had its restriction changed.
2488 (Bug#9184)
2489
5266b4bb
PE
24902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2491
2492 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2493
2573a837 24942011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2495
41f55ccd 2496 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2497
39e378da
PE
2498 * bidi.c: Integer size and overflow fixes.
2499 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2500 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2501 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2502 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2503 (bidi_find_other_level_edge):
2504 Use ptrdiff_t instead of EMACS_INT where either will do.
2505 This works better on 32-bit hosts configured --with-wide-int.
2506 (bidi_cache_ensure_space): Check for size-calculation overflow.
2507 Use % rather than repeated addition, for better worst-case speed.
2508 Don't set bidi_cache_size until after xrealloc returns, because it
2509 might not return.
2510 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2511 (bidi_cache_ensure_space): Also check that the bidi cache size
2512 does not exceed that of the largest Lisp string or buffer. See Eli
2513 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2514
5e927815
PE
2515 * alloc.c (__malloc_size_t): Remove.
2516 All uses replaced by size_t. See Andreas Schwab's note
2517 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2518
ca4aa935
PE
2519 * image.c: Improve checking for integer overflow.
2520 (check_image_size): Assume that f is nonnull, since
2521 it is always nonnull in practice. This is one less thing to
2522 worry about when checking for integer overflow later.
2523 (x_check_image_size): New function, which checks for integer
2524 overflow issues inside X.
2525 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2526 This removes the need for a memory_full check.
2527 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2528 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2529 (xbm_read_bitmap_data): Change locals back to 'int', since
2530 their values must fit in 'int'.
2531 (xpm_load_image, png_load, tiff_load):
2532 Invoke x_create_x_image_and_pixmap earlier,
2533 to avoid much needless work if the image is too large.
2534 (tiff_load): Treat overly large images as if
2535 x_create_x_image_and_pixmap failed, not as malloc failures.
2536 (gs_load): Use x_check_image_size.
2537
5f8f9cc2
PE
2538 * gtkutil.c: Omit integer casts.
2539 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2540 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2541
5adf60bc
PE
2542 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2543
c8907a93
PE
2544 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2545 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2546 would wrongly return t on a 64-bit host.
2547
e3c25c68
PE
2548 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2549 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2550 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2551 and therefore cause GCC to emit a bogus diagnostic in some cases.
2552
3f791afe
PE
2553 * image.c: Integer signedness and overflow and related fixes.
2554 This is not an exhaustive set of fixes, but it's time to
2555 record what I've got.
2556 (lookup_pixel_color, check_image_size): Remove redundant decls.
2557 (check_image_size): Don't assume that arbitrary EMACS_INT values
2558 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2559 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2560 (tiff_load, imagemagick_load_image):
2561 Check for overflow in size calculations.
2562 (x_create_x_image_and_pixmap): Remove unnecessary test for
2563 xmalloc returning NULL; that can't happen.
2564 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2565 (xpm_color_bucket): Use better integer hashing function.
2566 (xpm_cache_color): Don't possibly over-allocate memory.
2567 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2568 (gif_memory_source):
2569 Use ptrdiff_t, not int or size_t, to record sizes.
2570 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2571 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2572 either works, as we prefer signed integers.
2573 (tiff_read_from_memory, tiff_write_from_memory):
2574 Return tsize_t, not size_t, since that's what the TIFF API wants.
2575 (tiff_read_from_memory): Don't fail simply because the read would
2576 go past EOF; instead, return a short read.
2577 (tiff_load): Omit no-longer-needed casts.
2578 (Fimagemagick_types): Don't assume size fits into 'int'.
2579
3cc5a532
PE
2580 Improve hashing quality when configured --with-wide-int.
2581 * fns.c (hash_string): New function, taken from sxhash_string.
2582 Do not discard information about ASCII character case; this
2583 discarding is no longer needed.
2584 (sxhash-string): Use it. Change sig to match it. Caller changed.
2585 * lisp.h: Declare it.
2586 * lread.c (hash_string): Remove, since we now use fns.c's version.
2587 The fns.c version returns a wider integer if --with-wide-int is
2588 specified, so this should help the quality of the hashing a bit.
2589
b312a492
PE
2590 * emacs.c: Integer overflow minor fix.
2591 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2592 Define only if GNU_LINUX.
2593 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2594
dfd153ae
PE
2595 * dispnew.c: Integer signedness and overflow fixes.
2596 Remove unnecessary forward decls, that were a maintenance hassle.
2597 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2598 All uses changed.
2599 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2600 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2601 (prepare_desired_row, line_draw_cost):
2602 Use int, not unsigned, where either works.
2603 (save_current_matrix, restore_current_matrix):
2604 Use ptrdiff_t, not size_t, where either works.
2605 (init_display): Check for overflow more accurately, and without
2606 relying on undefined behavior.
2607
a81d11a3
PE
2608 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2609 Remove, replacing with the new symbols in lisp.h. All uses changed.
2610 * fileio.c (make_temp_name):
2611 * filelock.c (lock_file_1, lock_file):
2612 * xdisp.c (message_dolog):
2613 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2614 Use pMd etc. instead.
2615 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2616 replacing the pWIDE etc. symbols removed from editfns.c.
2617
3300e6fd
PE
2618 * keyboard.h (num_input_events): Now uintmax_t.
2619 This is (very slightly) less likely to mess up due to wraparound.
2620 All uses changed.
2621
fd05c7e9
PE
2622 * buffer.c: Integer signedness fixes.
2623 (alloc_buffer_text, enlarge_buffer_text):
2624 Use ptrdiff_t rather than size_t when either will do, as we prefer
2625 signed integers.
2626
903fe15d
PE
2627 * alloc.c: Integer signedness and overflow fixes.
2628 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2629 (__malloc_size_t): Default to size_t, not to int.
2630 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2631 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2632 Prefer ptrdiff_t to size_t when either would do, as we prefer
2633 signed integers.
2634 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2635 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2636 Now const. Initialize with values that are in range even if char
2637 is signed.
2638 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2639 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2640 These functions do the right thing with sizes > 2**32.
2641 (check_depth): Now ptrdiff_t, not int.
2642 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2643 Adjust to new way of storing sizes. Check for size overflow bugs
2644 in rest of code.
2645 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2646 slightly wrong anyway, as it missed one instance of
2647 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2648 (refill_memory_reserve): Omit needless cast to size_t.
2649 (mark_object_loop_halt): Mark as externally visible.
2650
ac82cc6a
PE
2651 * xselect.c: Integer signedness and overflow fixes.
2652 (Fx_register_dnd_atom, x_handle_dnd_message):
2653 Use ptrdiff_t, not size_t, since we prefer signed.
2654 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2655 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2656 x_dnd_atoms_size and x_dnd_atoms_length.
2657
c2d1e36d
PE
2658 * doprnt.c: Prefer signed to unsigned when either works.
2659 * eval.c (verror):
2660 * doprnt.c (doprnt):
2661 * lisp.h (doprnt):
2662 * xdisp.c (vmessage):
2663 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2664 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2665 prefer signed arithmetic to avoid comparison confusion.
2666 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2667 but is a bit tricky.
2668
0e926e56
PE
2669 Assume freestanding C89 headers, string.h, stdlib.h.
2670 * data.c, doprnt.c, floatfns.c, print.c:
2671 Include float.h unconditionally.
2672 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2673 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2674 * regex.c: Likewise for stddef.h, string.h.
2675 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2676 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2677 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2678 (STDC_HEADERS): Remove obsolete defines.
2679 * sysdep.c: Include limits.h unconditionally.
2680
9cfdb3ec
PE
2681 Assume support for memcmp, memcpy, memmove, memset.
2682 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2683 * regex.c (memcmp, memcpy):
2684 Remove; we assume C89 now.
2685
2686 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2687 (__malloc_safe_bcopy): Remove; no longer needed.
2688
cf950e6b 2689 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2690 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2691 well either way, and we prefer signed to unsigned.
2692
dbf38e02
LMI
26932011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2694
2695 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2696 closes the connection while we're reading (bug#9182).
2697
d6f0886c 26982011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2699
d6f0886c
JD
2700 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2701 are specified (Bug#9168).
24e0f6b1 2702
2eb1f9e6
PE
27032011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2704
2705 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2706 Found by GCC static checking and --with-wide-int on a 32-bit host.
2707
22381272 27082011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2709
2710 * xdisp.c (compute_display_string_pos): Fix logic of caching
2711 previous display string position. Initialize cached_prev_pos to
2712 -1. Fixes slow-down at the beginning of a buffer.
2713
f25e39b4
EZ
27142011-07-24 Eli Zaretskii <eliz@gnu.org>
2715
2716 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2717 for attrs[LFACE_FONTSET_INDEX].
2718
04c4b52e
PE
27192011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2720
2721 * xml.c (parse_region): Remove unused local
2722 that was recently introduced.
2723
c1734fbd
EZ
27242011-07-23 Eli Zaretskii <eliz@gnu.org>
2725
be18c5a5
EZ
2726 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2727 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2728
c1734fbd
EZ
2729 * xdisp.c (move_it_in_display_line_to): Record the best matching
2730 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2731 exit if none of the characters scanned was an exact match.
2732 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2733 when exact match is impossible due to invisible text, and the
2734 lines are truncated.
2735
a258d627
JD
27362011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2737
2738 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2739 for OSX >= 10.7.
2740
b6d5a689
EZ
27412011-07-22 Eli Zaretskii <eliz@gnu.org>
2742
0f74f785
EZ
2743 Fix a significant slow-down of cursor motion with C-n, C-p,
2744 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2745 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2746 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2747 (next_element_from_buffer): Call compute_stop_pos_backwards to
2748 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2749 base_level_stop.
2750 (reseat): Don't look for prev_stop, as that could mean a very long
2751 run.
2752 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2753 <cached_disp_overlay_modiff>: Cache for last found display string
2754 position.
551918c1 2755 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2756 about the same buffer in the same area of character positions, and
2757 the buffer wasn't changed since the time the display string
2758 position was cached.
551918c1 2759
b2d0c91a
EZ
27602011-07-22 Eli Zaretskii <eliz@gnu.org>
2761
2762 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2763 is an integer, which is important for empty lines. (Bug#9149)
2764
043604ee
CY
27652011-07-22 Chong Yidong <cyd@stupidchicken.com>
2766
2767 * frame.c (Fmodify_frame_parameters): In tty case, update the
2768 default face if necessary (Bug#4238).
2769
da4adb04
CY
27702011-07-21 Chong Yidong <cyd@stupidchicken.com>
2771
2772 * editfns.c (Fstring_to_char): No need to explain what a character
2773 is in the docstring (Bug#6576).
2774
9abd0532
LMI
27752011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2776
2777 * xml.c (parse_region): Make sure we always return a tree.
2778
36881d16
HK
27792011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2780
2781 * xml.c (parse_region): If a document contains only comments,
2782 return that, too.
2783
1e98674d
LMI
27842011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2785
2786 * xml.c (make_dom): Return comments, too.
2787
590bd467
PE
27882011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2789
2790 Port to OpenBSD.
2791 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2792 and the surrounding thread.
2793 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2794 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2795 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2796 timer goes off.
2797 * s/openbsd.h (BROKEN_SIGIO): Define.
2798 * unexelf.c (unexec) [__OpenBSD__]:
2799 Don't update the .mdebug section of the Alpha COFF symbol table.
2800
f41628b2
LMI
28012011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2802
2803 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2804 (bug#8460).
2805
b59b67c5
PE
28062011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2807
15e3a074
PE
2808 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2809 This fixes some race conditions on the permissions of any newly
2810 created file.
2811
41bed37d
PE
2812 * alloc.c (valid_pointer_p): Use pipe, not open.
2813 This fixes some permissions issues when debugging.
2814
b59b67c5
PE
2815 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2816 If fchown fails to set both uid and gid, try to set just gid,
2817 as that is sometimes allowed. Adjust the file's mode to eliminate
2818 setuid or setgid bits that are inappropriate if fchown fails.
2819
925a6be7
SM
28202011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2821
2822 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2823 to compare Lisp_Objects.
2824 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2825 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2826 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2827
52968808
AS
28282011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2829
0a6a104b
AS
2830 * lread.c (read_integer): Unread even EOF character.
2831 (read1): Likewise. Properly record start position of symbol.
2832
52968808
AS
2833 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2834 symbol character follows.
2835
9e381cdd
PE
28362011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2837
2838 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2839 This works around a problem with the previous change to Fcopy_file.
2840 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2841 and without this change, GCC might complain about discarding
2842 fchown's return value.
2843
b5641435
JB
28442011-07-16 Juanma Barranquero <lekktu@gmail.com>
2845
2846 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2847
a8031457
PE
28482011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2849
2850 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2851
dd889327
LMI
28522011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2853
750c33f7
LMI
2854 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2855 it's used from the C level.
2856
dd889327
LMI
2857 * process.c: Use the same condition for POLL_FOR_INPUT in both
2858 keyboard.c and process.c (bug#1858).
2859
87e86684
LM
28602011-07-09 Lawrence Mitchell <wence@gmx.li>
2861
2862 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2863 (Fgnutls_boot): Use it.
2864
64348f40
AS
28652011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2866
2867 * doc.c (Fsubstitute_command_keys): Revert last change.
2868
1d698799
LMI
28692011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2870
f863868c
LMI
2871 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2872 quotes the next character, and doesn't affect other longer
2873 sequences (bug#8935).
2874
1d698799
LMI
2875 * lread.c (syms_of_lread): Clarify that is isn't only
2876 `eval-buffer' and `eval-defun' that's affected by
2877 `lexical-binding' (bug#8460).
2878
aa4b6df6
EZ
28792011-07-15 Eli Zaretskii <eliz@gnu.org>
2880
2881 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2882 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2883
5d856da6
PE
28842011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2885
ad6042bb
PE
2886 Fix minor problems found by static checking.
2887 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2888 (elsz): Now a signed constant, not a size_t var. We prefer signed
2889 types to unsigned, to avoid integer comparison confusion. Without
2890 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2891 "cannot optimize loop, the loop counter may overflow", a symptom
2892 of the confusion.
f00bbb22 2893 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2894 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2895
6468f31c
LMI
28962011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2897
49080b10
LMI
2898 * search.c (Fre_search_backward): Mention `case-fold-search' in
2899 all the re_search_* functions (bug#8138).
2900
6468f31c
LMI
2901 * keyboard.c (Fopen_dribble_file): Document when the file is
2902 closed (bug#8056).
2903
c965adc5
EZ
29042011-07-14 Eli Zaretskii <eliz@gnu.org>
2905
df9733bf
EZ
2906 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2907 bidi_cache_idx.
2908
0bb23927
EZ
2909 Support bidi reordering of display and overlay strings.
2910 * xdisp.c (compute_display_string_pos)
2911 (compute_display_string_end): Accept additional argument STRING.
2912 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2913 (reseat_to_string): Initialize bidi_it->string.s and
2914 bidi_it->string.schars.
2915 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2916 NULL (avoids a crash in bidi_paragraph_init).
2917 Initialize itb.string.lstring.
0bb23927
EZ
2918 (init_iterator): Call bidi_init_it only of a valid
2919 buffer position was specified. Initialize paragraph_embedding to
2920 L2R.
2921 (reseat_to_string): Initialize the bidi iterator.
2922 (display_string): If we need to ignore text properties of
2923 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2924 original value of -1 will not work with bidi.)
2925 (compute_display_string_pos): First arg is now struct
2926 `text_pos *'; all callers changed. Support display properties on
2927 Lisp strings.
2928 (compute_display_string_end): Support display properties on Lisp
2929 strings.
2930 (init_iterator, reseat_1, reseat_to_string): Initialize the
2931 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2932 when iterating on a string not from display properties).
640c8776
SM
2933 (compute_display_string_pos, compute_display_string_end):
2934 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2935 arrow keys.
2936 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2937 base_level_stop; instead, set base_level_stop to BEGV.
2938 Fixes crashes in vertical-motion.
0bb23927
EZ
2939 (next_element_from_buffer): Improve commentary for when
2940 the iterator is before prev_stop.
2941 (init_iterator): Initialize bidi_p from the default value of
2942 bidi-display-reordering, not from buffer-local value. Use the
2943 buffer-local value only if initializing for buffer iteration.
2944 (handle_invisible_prop): Support invisible properties on strings
2945 that are being bidi-reordered.
2946 (set_iterator_to_next): Support bidi reordering of C strings and
2947 Lisp strings.
2948 (next_element_from_string): Support bidi reordering of Lisp
2949 strings.
2950 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2951 (display_string): Support display of R2L glyph rows.
2952 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2953 (init_iterator): Don't initialize it->bidi_p for strings
2954 here.
2955 (reseat_to_string): Initialize it->bidi_p for strings here.
2956 (next_element_from_string, next_element_from_c_string)
2957 (next_element_from_buffer): Add xassert's for correspondence
2958 between IT's object being iterated and it->bidi_it.string
2959 structure.
2960 (face_before_or_after_it_pos): Support bidi iteration.
2961 (next_element_from_c_string): Handle the case of the first string
2962 character that is not the first one in the visual order.
2963 (get_visually_first_element): New function, refactored from common
2964 parts of next_element_from_buffer, next_element_from_string, and
2965 next_element_from_c_string.
2966 (tool_bar_lines_needed, redisplay_tool_bar)
2967 (display_menu_bar): Force left-to-right direction. Add a FIXME
2968 comment for making that be controlled by a user option.
2969 (push_it, pop_it): Save and restore the state of the
2970 bidi iterator. Save and restore the bidi_p flag.
2971 (pop_it): Iterate out of display property for string iteration as
2972 well.
2973 (iterate_out_of_display_property): Support iteration over strings.
2974 (handle_single_display_spec): Set up it->bidi_it for iteration
2975 over a display string, and call bidi_init_it.
2976 (handle_single_display_spec, next_overlay_string)
2977 (get_overlay_strings_1, push_display_prop): Set up the bidi
2978 iterator for displaying display or overlay strings.
2979 (forward_to_next_line_start): Don't use the shortcut if
2980 bidi-iterating.
2981 (back_to_previous_visible_line_start): If handle_display_prop
2982 pushed the iterator stack, restore the internal state of the bidi
2983 iterator by calling bidi_pop_it same number of times.
2984 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2985 and we are bidi-iterating, don't decrement the iterator position;
2986 instead, set the first_elt flag in the bidi iterator, to produce
2987 the same effect.
2988 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2989 (push_display_prop): xassert that we are iterating a buffer.
2990 (push_it, pop_it): Save and restore paragraph_embedding member.
2991 (handle_single_display_spec, next_overlay_string)
2992 (get_overlay_strings_1, reseat_1, reseat_to_string)
2993 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2994 correctly. Don't assume unibyte strings are not bidi-reordered.
2995 (compute_display_string_pos)
2996 (compute_display_string_end): Fix handling the case of C string.
2997 (push_it, pop_it): Save and restore from_disp_prop_p.
2998 (handle_single_display_spec, push_display_prop): Set the
2999 from_disp_prop_p flag.
3000 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3001 (pop_it): Call iterate_out_of_display_property only if we are
3002 popping after iteration over a string that came from a display
3003 property. Fix a typo in popping stretch info. Add an assertion
3004 for verifying that the iterator position is in sync with the bidi
3005 iterator.
3006 (handle_single_display_spec, get_overlay_strings_1)
3007 (push_display_prop): Fix initialization of paragraph direction for
3008 string when that of the parent object is not yet determined.
3009 (reseat_1): Call bidi_init_it to resync the bidi
3010 iterator with IT's position. (Bug#7616)
3011 (find_row_edges): If ROW->start.pos gives position
3012 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3013 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3014 Reset the from_disp_prop_p flag.
3015 (SAVE_IT, RESTORE_IT): New macros.
3016 (pos_visible_p, face_before_or_after_it_pos)
3017 (back_to_previous_visible_line_start)
3018 (move_it_in_display_line_to, move_it_in_display_line)
3019 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3020 (try_scrolling, redisplay_window, display_line): Use them when
3021 saving a temporary copy of the iterator and restoring it back.
3022 (back_to_previous_visible_line_start, reseat_1)
3023 (init_iterator): Empty the bidi cache "stack".
3024 (move_it_in_display_line_to): If iterator ended up at
3025 EOL, but we never saw any buffer positions smaller than
3026 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3027 motion in bidi-reordered lines.
3028 (move_it_in_display_line_to): Record prev_method and prev_pos
3029 immediately before the call to set_iterator_to_next. Fixes cursor
3030 motion in bidi-reordered lines with stretch glyphs and strings
3031 displayed in margins. (Bug#8133) (Bug#8867)
3032 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3033 TO_CHARPOS.
640c8776
SM
3034 (pos_visible_p): Support positions in bidi-reordered lines.
3035 Save and restore bidi cache.
0bb23927
EZ
3036
3037 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3038 (bidi_paragraph_info): Delete unused struct.
3039 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3040 (bidi_cache_start): New variable.
3041 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3042 to zero.
3043 (bidi_cache_fetch_state, bidi_cache_search)
3044 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3045 (bidi_cache_find, bidi_peek_at_next_level)
3046 (bidi_level_of_next_char, bidi_find_other_level_edge)
3047 (bidi_move_to_visually_next): Compare cache index with
3048 bidi_cache_start rather than with zero.
3049 (bidi_fetch_char): Accept new argument STRING; all callers
3050 changed. Support iteration over a string. Support strings with
3051 display properties. Support unibyte strings. Fix the type of
3052 `len' according to what STRING_CHAR_AND_LENGTH expects.
3053 (bidi_paragraph_init, bidi_resolve_explicit_1)
3054 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3055 (bidi_level_of_next_char, bidi_move_to_visually_next):
3056 Support iteration over a string.
0bb23927
EZ
3057 (bidi_set_sor_type, bidi_resolve_explicit_1)
3058 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3059 can now be zero (for strings); special values 0 and -1 were
3060 changed to -1 and -2, respectively.
3061 (bidi_char_at_pos): New function.
3062 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3063 Call it instead of FETCH_MULTIBYTE_CHAR.
3064 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3065 initialized to valid values.
3066 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3067 values.
3068 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3069 the test for valid cached positions. Fix the logic for looking up
3070 the sentinel state in the cache. GCPRO the Lisp string we are
3071 iterating.
3072 (bidi_push_it, bidi_pop_it): New functions.
3073 (bidi_initialize): Initialize the bidi cache start stack pointer.
3074 (bidi_cache_ensure_space): New function, refactored from part of
3075 bidi_cache_iterator_state. Don't assume the required size is just
3076 one BIDI_CACHE_CHUNK away.
3077 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3078 (bidi_count_bytes, bidi_char_at_pos): New functions.
3079 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3080 always valid if bidi_cache_idx is valid.
3081 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3082 is valid if it's going to be used.
3083 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3084 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3085 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3086 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3087 (bidi_find_other_level_edge, bidi_cache_start_stack):
3088 All variables related to cache indices are now EMACS_INT.
c965adc5 3089
0bb23927
EZ
3090 * dispextern.h (struct bidi_string_data): New structure.
3091 (struct bidi_it): New member `string'. Make flag members be 1-bit
3092 fields, and put them last in the struct.
640c8776
SM
3093 (compute_display_string_pos, compute_display_string_end):
3094 Update prototypes.
0bb23927
EZ
3095 (bidi_push_it, bidi_pop_it): Add prototypes.
3096 (struct iterator_stack_entry): New members bidi_p,
3097 paragraph_embedding, and from_disp_prop_p.
3098 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3099 (bidi_shelve_cache, bidi_unshelve_cache):
3100 Declare prototypes.
0bb23927
EZ
3101
3102 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3103 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3104 and vector-like objects.
3105
3106 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3107 cache around display iteration.
3108
3109 * window.c (Fwindow_end, window_scroll_pixel_based)
3110 (displayed_window_lines, Frecenter): Save and restore the bidi
3111 cache around display iteration.
3112
3bbd2265
LMI
31132011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3114
3115 * editfns.c (Fdelete_region): Clarify the use of the named
3116 parameters (bug#6788).
3117
adc47434
MR
31182011-07-14 Martin Rudalics <rudalics@gmx.at>
3119
3120 * indent.c (Fvertical_motion): Set and restore w->pointm when
3121 saving and restoring the window's buffer (Bug#9006).
3122
837c31f8
LMI
31232011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3124
3125 * editfns.c (Fstring_to_char): Clarify just what is returned
3126 (bug#6576). Text by Eli Zaretskii.
3127
ac389d0c
JB
31282011-07-13 Juanma Barranquero <lekktu@gmail.com>
3129
3130 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3131
0be0ce47
EZ
31322011-07-13 Eli Zaretskii <eliz@gnu.org>
3133
3134 * buffer.c (mmap_find): Fix a typo.
3135
cd18e7e3
JB
31362011-07-13 Johan Bockgård <bojohan@gnu.org>
3137
3138 Fix execution of x selection hooks.
3139 * xselect.c (Qx_lost_selection_functions)
3140 (Qx_sent_selection_functions): New vars.
3141 (syms_of_xselect): DEFSYM them.
3142 (x_handle_selection_request): Pass Qx_sent_selection_functions
3143 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3144 (x_handle_selection_clear,x_clear_frame_selections):
3145 Pass Qx_lost_selection_functions rather than
3146 Vx_lost_selection_functions to Frun_hook_with_args.
3147
47ea7f44
PE
31482011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3149
ac389d0c 3150 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3151 The old code sometimes used this field without initializing it.
3152
47ea7f44
PE
3153 * alloc.c (gc_sweep): Don't read past end of array.
3154 In theory, the old code could also have corrupted Emacs internals,
3155 though it'd be very unlikely.
3156
bc985c87
AS
31572011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3158
3159 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3160 argument. (Bug#4026)
bc985c87 3161
0cf34688
LMI
31622011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3163
b3dadd76
LMI
3164 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3165 key" (bug#4257).
3166
0cf34688
LMI
3167 * window.c (Fset_window_start): Doc fix (bug#4199).
3168 (Fset_window_hscroll): Ditto.
3169
270768cd
PE
31702011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3171
077e3dda 3172 Fix minor new problems caught by GCC 4.6.1.
270768cd 3173 * term.c (init_tty): Remove unused local.
490011a6 3174 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3175 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3176 not used otherwise.
270768cd 3177
b1f58454
CY
31782011-07-12 Chong Yidong <cyd@stupidchicken.com>
3179
3180 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3181
22b9578d
LMI
31822011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3183
6e70ab07
LMI
3184 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3185 are the mini-buffer and the echo area (bug#3320).
3186
22b9578d
LMI
3187 * term.c (init_tty): Remove support for supdup, c10 and perq
3188 terminals, which are no longer supported (bug#1482).
3189
8974cc9f
JB
31902011-07-10 Johan Bockgård <bojohan@gnu.org>
3191
3192 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3193
a560d974
JD
31942011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3195
3196 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3197 for non-popups (Bug#3642).
3198
1dae0f0a
AS
31992011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3200
268c2c36 3201 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3202 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3203 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3204 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3205 * data.c (fmod): Likewise.
3206 * dispnew.c (swap_glyphs_in_rows): Likewise.
3207 * emacs.c (memory_warning_signal): Likewise.
3208 * floatfns.c (float_error): Likewise.
3209 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3210 (otf_open, font_otf_capability, generate_otf_features)
3211 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3212 Likewise.
3213 * image.c (pbm_read_file): Likewise.
3214 * indent.c (string_display_width): Likewise.
3215 * intervals.c (check_for_interval, search_for_interval)
3216 (inc_interval_count, count_intervals, root_interval)
3217 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3218 * lread.c (defalias): Likewise.
268c2c36 3219 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3220 * regex.c (set_image_of_range_1, set_image_of_range)
3221 (regex_grow_registers): Likewise.
3222 * sysdep.c (strerror): Likewise.
3223 * termcap.c (valid_filename_p, tprint, main): Likewise.
3224 * tparam.c (main): Likewise.
3225 * unexhp9k800.c (run_time_remap, save_data_space)
3226 (update_file_ptrs, read_header, write_header, calculate_checksum)
3227 (copy_file, copy_rest, display_header): Likewise.
3228 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3229 Likewise.
3230 * xdisp.c (check_it): Likewise.
3231 * xfaces.c (register_color, unregister_color, unregister_colors):
3232 Likewise.
3233 * xfns.c (print_fontset_result): Likewise.
3234 * xrdb.c (member, fatal, main): Likewise.
3235
99033785
PE
32362011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3237
3238 Fix minor problems found by static checking (Bug#9031).
3239 * chartab.c (char_table_set_range, map_sub_char_table):
3240 Remove unused locals.
3241 (uniprop_table): Now static.
3242 * composite.c (_work_char): Remove unused static var.
3243
9cb2ac56
JB
32442011-07-09 Juanma Barranquero <lekktu@gmail.com>
3245
3246 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3247
f25661f0
JD
32482011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3249
3250 * gtkutil.c (qttip_cb): Remove code without function.
3251
8278c4fe
EZ
32522011-07-09 Eli Zaretskii <eliz@gnu.org>
3253
3254 * w32.c (pthread_sigmask): New stub.
3255
1692ae2d 32562011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3257
8a6ebd58 3258 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3259 sigprocmask is portable only for single-threaded applications, and
3260 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3261 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3262 (LIBES): Use it.
3263 * callproc.c (Fcall_process):
3264 * process.c (create_process):
3265 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3266 Use pthread_sigmask, not sigprocmask.
123403e4 3267
1b854618
JD
32682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3269
3270 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3271 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3272 wrong (Bug#8591).
3273
3fe4b549
JD
32742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3275
0ce7e563
JD
3276 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3277 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3278 (xg_hide_tooltip): Fix comment.
3279
3fe4b549
JD
3280 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3281 in registerServicesMenuSendTypes.
3282 (validRequestorForSendType): Don't check ns_return_types.
3283
3284 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3285 ns_return_type.
3286
5df75e47
JR
32872011-07-08 Jason Rumney <jasonr@gnu.org>
3288
22610910
JR
3289 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3290 SH_SHOW for hidden windows (Bug#5482).
3291
5df75e47
JR
3292 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3293 frame struct members of non-existent frames (Bug#6284).
3294
699c10bd
JD
32952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3296
4393663b
JD
3297 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3298 variable firstTime not needed on OSX >= 10.6.
3299 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3300 >= 10.5. Use setKnobProportion, setDoubleValue.
3301
3302 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3303 (MAC_OS_X_VERSION_10_5): Define if not defined.
3304 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3305 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3306 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3307
3308 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3309 cString and lossyCString on OSX >= 10.4
3310
58179cce 3311 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3312 sizeToFit on OSX >= 10.2.
3313
3314 * nsimage.m (allocInitFromFile): Don't use deprecated method
3315 bestRepresentationForDevice on OSX >= 10.6.
3316
3317 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3318 to avoid warning.
3319
3320 * emacs.c: Declare unexec_init_emacs_zone.
3321
a63e0781
JD
3322 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3323
699c10bd
JD
3324 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3325
3326 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3327 on svcsMenu (Bug#8842).
3328
3329 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3330 ns_return_types.
3331 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3332
3333 * nsterm.m (QUTF8_STRING): Declare.
3334 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3335 (validRequestorForSendType): Return type is (id).
3336 Change indexOfObjectIdenticalTo to indexOfObject.
3337 Check if we have local selection before returning self (Bug#8842).
3338 (writeSelectionToPasteboard): Put local selection into paste board
3339 if we have a local selection (Bug#8842).
3340 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3341
3342 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3343 (ns_get_local_selection): Declare.
3344
54e10184
LMI
33452011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3346
9888ff71
LMI
3347 * keymap.c (describe_map_tree): Don't insert a double newline at
3348 the end of the buffer (bug#1169) and return whether we inserted
3349 something.
3350
54e10184
LMI
3351 * callint.c (Fcall_interactively): Change "reading args" to
3352 "providing args" to try to clarify what it does (bug#1010).
3353
15fa4783
KH
33542011-07-07 Kenichi Handa <handa@m17n.org>
3355
3356 * composite.c (composition_compute_stop_pos): Ignore a static
3357 composition starting before CHARPOS (Bug#8915).
3358
3359 * xdisp.c (handle_composition_prop): Likewise.
3360
a8815b00
EZ
33612011-07-07 Eli Zaretskii <eliz@gnu.org>
3362
3363 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3364 (Bug#9015)
3365
ef7b981d 33662011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3367
3368 * character.h (unicode_category_t): New enum type.
3369
3370 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3371 (Qchar_code_property_table): New variable.
3372 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3373 (UNIPROP_COMPRESSED_FORM_P): New macros.
3374 (char_table_ascii): Uncompress the compressed values.
3375 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3376 Uncompress the compressed values.
ac389d0c 3377 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3378 (char_table_ref_and_range): Uncompress the compressed values.
3379 (sub_char_table_set): New arg is_uniprop. Callers changed.
3380 Uncompress the compressed values.
3381 (sub_char_table_set_range): Args changed. Callers changed.
3382 (char_table_set_range): Adjuted for the above change.
3383 (map_sub_char_table): Delete args default_val and parent. Add arg
3384 top. Give decoded values to a Lisp function.
640c8776 3385 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3386 values to a Lisp function. Gcpro more variables.
3387 (uniprop_table_uncompress)
3388 (uniprop_decode_value_run_length): New functions.
3389 (uniprop_decoder, uniprop_decoder_count): New variables.
3390 (uniprop_get_decoder, uniprop_encode_value_character)
3391 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3392 New functions.
3393 (uniprop_encoder, uniprop_encoder_count): New variables.
3394 (uniprop_get_encoder, uniprop_table)
3395 (Funicode_property_table_internal, Fget_unicode_property_internal)
3396 (Fput_unicode_property_internal): New functions.
3397 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3398 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3399 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3400 char-code-property-alist.
3401
640c8776 3402 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3403 Vunicode_category_table.
3404
640c8776 3405 * font.c (font_range): Adjust for the change of
c805dec0
KH
3406 Vunicode_category_table.
3407
76b397fb
DN
34082011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3409
3410 * m/iris4d.h: Remove file, move contents ...
3411 * s/irix6-5.h: ... here.
3412
22b4128e
PE
34132011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3414
3415 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3416 * alloc.c (mark_buffer):
3417 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3418 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3419 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3420 This isn't true in general, and it's particularly not true
3421 if Emacs is configured with --with-wide-int.
3422 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3423 New macros, used in the buffer.c change.
3424
869795d6
JD
34252011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3426
3427 * xsettings.c: Use both GConf and GSettings if both are available.
3428 (store_config_changed_event): Add comment.
3429 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3430 (store_tool_bar_style_changed): New functions.
5e617bc2 3431 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3432 (struct xsettings): Move font inside HAVE_XFT.
3433 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3434 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3435 Move inside HAVE_XFT.
640c8776 3436 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3437 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3438 also.
3439 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3440 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3441 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3442 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3443 (parse_settings): Move check for font inside HAVE_XFT.
3444 (read_settings, apply_xft_settings): Add comment.
3445 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3446 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3447 call store_font_name_changed.
3448 (xft_settings_event): Add comment.
3449 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3450 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3451 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3452 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3453 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3454 (xsettings_get_system_font, xsettings_get_system_normal_font):
3455 Add comment.
869795d6 3456
d8ed26bd
PE
34572011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3458
3459 Random fixes. E.g., (random) never returned negative values.
3460 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3461 subseconds part to the entropy, as that's a bit more random.
3462 Prefer signed to unsigned, since the signedness doesn't matter and
3463 in general we prefer signed. When given a limit, use a
3464 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3465 latter isn't right if USE_2_TAGS_FOR_INTS.
3466 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3467 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3468
cabf1cac
SM
34692011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3470
3471 * textprop.c (text_property_stickiness):
3472 Obey Vtext_property_default_nonsticky.
3473 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3474 * w32fns.c (syms_of_w32fns):
3475 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3476
6e9b2be9
PE
34772011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3478
3479 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3480 This is more efficient than Ffile_directory_p and avoids a minor race.
3481
90186c68
LMI
34822011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3483
7c301272
LMI
3484 * buffer.c (Foverlay_put): Say what the return value is
3485 (bug#7835).
3486
c4f2d8d4
LMI
3487 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3488 is a directory before asking whether to use the file name
3489 (bug#7564).
ad637907
LMI
3490 (barf_or_query_if_file_exists): Make the "File is a directory"
3491 error be more correct.
c4f2d8d4 3492
90186c68
LMI
3493 * fns.c (Frequire): Remove the mention of the .gz files, since
3494 that's installation-specific, but keep the mention of
3495 `get-load-suffixes'.
3496
da64016e
PE
34972011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3498
3499 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3500 Report string overflow if the output is too long.
3501
7d47b580
JB
35022011-07-04 Juanma Barranquero <lekktu@gmail.com>
3503
a555cb87
JB
3504 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3505 (syms_of_gnutls): Remove duplicate DEFSYM for
3506 Qgnutls_bootprop_verify_hostname_error, an error for
3507 Qgnutls_bootprop_verify_error (which is no longer used).
3508
7d47b580
JB
3509 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3510 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3511 Also (re)move comments that are misplaced or no longer relevant.
3512
1e49bfab
LMI
35132011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3514
3515 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3516
1485f4c0
CY
35172011-07-03 Chong Yidong <cyd@stupidchicken.com>
3518
3519 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3520 and background color parameters if they have been changed.
3521
a9ab721e
LMI
35222011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3523
3524 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3525
cf7cff57
PE
35262011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3527
2e13213d
PE
3528 * xsettings.c (SYSTEM_FONT): Define only when used.
3529 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3530
cf7cff57
PE
3531 * keymap.c (access_keymap_1): Now static.
3532
7a8e04f7
CY
35332011-07-02 Chong Yidong <cyd@stupidchicken.com>
3534
3535 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3536 leave any prefix arg for the up event (Bug#1586).
3537
61352f62
LMI
35382011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3539
69bb1ef7
LMI
3540 * lread.c (syms_of_lread): Mention single symbols defined by
3541 `defvar' or `defconst' (bug#7154).
3542
61352f62 3543 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3544 (Frequire): Mention get-load-suffixes.
61352f62 3545
28545e04
MR
35462011-07-02 Martin Rudalics <rudalics@gmx.at>
3547
3548 * window.h (window): Remove clone_number slot.
3549 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3550 Remove.
3551 (make_parent_window, make_window, saved_window)
3552 (Fset_window_configuration, save_window_save): Don't deal with
3553 clone numbers.
3554 * buffer.c (Qclone_number): Remove declaration.
3555 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3556
3349e122
SM
35572011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3558
3559 Add multiple inheritance to keymaps.
3560 * keymap.c (Fmake_composed_keymap): New function.
3561 (Fset_keymap_parent): Simplify.
3562 (fix_submap_inheritance): Remove.
3563 (access_keymap_1): New function extracted from access_keymap to handle
3564 embedded parents and handle lists of maps.
3565 (access_keymap): Use it.
3566 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3567 (Fcopy_keymap): Handle embedded parents.
3568 (Fcommand_remapping, define_as_prefix): Simplify.
3569 (Fkey_binding): Simplify.
3570 (syms_of_keymap): Move minibuffer-local-completion-map,
3571 minibuffer-local-filename-completion-map,
3572 minibuffer-local-must-match-map, and
3573 minibuffer-local-filename-must-match-map to Elisp.
3574 (syms_of_keymap): Defsubr make-composed-keymap.
3575 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3576 (parse_menu_item): Trivial simplification.
3577
3279eb87
GM
35782011-07-01 Glenn Morris <rgm@gnu.org>
3579
3580 * Makefile.in (SETTINGS_LIBS): Fix typo.
3581
4550efdf
KI
35822011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3583
3584 * coding.c (Fencode_coding_string): Record the last coding system
3585 used, as the function doc string says (bug#8738).
3586
0949d2b6
JD
35872011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3588
3589 * xsettings.c (store_monospaced_changed): Take new font as arg and
3590 check for change against current_mono_font.
3591 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3592 (emacs_settings_constructor, emacs_settings_get_property)
3593 (emacs_settings_set_property, emacs_settings_class_init)
3594 (emacs_settings_init, gsettings_obj): Remove.
3595 (something_changedCB): New function for HAVE_GSETTINGS.
3596 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3597 with value as argument.
3598 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3599 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3600 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3601 "changed".
3602
3603 * xgselect.c: Add defined (HAVE_GSETTINGS).
3604 (xgselect_initialize): Ditto.
3605
3606 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3607 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3608 xg_select.
3609
bbc6b304
PE
36102011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3611
3612 * eval.c (struct backtrace): Simplify and port the data structure.
3613 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3614 signed bit field, as this assumption is not portable and it makes
3615 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3616 "char debug_on_exit : 1" as this is not portable either; instead,
3617 use the portable "unsigned int debug_on_exit : 1". Remove unused
3618 member evalargs. Remove obsolete comments about cc bombing out.
3619
9851bfc5
JD
36202011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3621
51bb811f 3622 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3623 Let HAVE_GSETTINGS override HAVE_GCONF.
3624 (store_monospaced_changed): New function.
3625 (EMACS_SETTINGS): A new type derived from GObject to handle
3626 GSettings notifications.
3627 (emacs_settings_constructor, emacs_settings_get_property)
3628 (emacs_settings_set_property, emacs_settings_class_init):
3629 New functions.
3630 (gsettings_client, gsettings_obj): New variables.
3631 (GSETTINGS_SCHEMA): New define.
3632 (something_changedCB): Call store_monospaced_changed.
3633 (init_gsettings): New function.
3634 (xsettings_initialize): Call init_gsettings.
3635 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3636 to NULL.
3637
640c8776 3638 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3639 GCONF_CFLAGS/LIBS.
3640
5386012d
MR
36412011-06-29 Martin Rudalics <rudalics@gmx.at>
3642
3643 * window.c (resize_root_window, grow_mini_window)
3644 (shrink_mini_window): Rename Qresize_root_window to
3645 Qwindow_resize_root_window and Qresize_root_window_vertically to
3646 Qwindow_resize_root_window_vertically.
3647
f13e0b08
PE
36482011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3649
3650 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3651
94515237
JB
36522011-06-27 Juanma Barranquero <lekktu@gmail.com>
3653
3654 * makefile.w32-in: Redesign dependencies so they reflect more
3655 clearly which files are directly included by each source file,
3656 and not through other includes.
3657
e43b6e43
MR
36582011-06-27 Martin Rudalics <rudalics@gmx.at>
3659
3660 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3661 (sort_overlays, overlay_strings): When an overlay's clone number
3662 matches the window's clone number process the overlay even if
3663 the overlay's window property doesn't match the current window.
3664
d68443dc
MR
3665 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3666 (Fwindow_hchild): Rename to Fwindow_left_child.
3667 (Fwindow_next): Rename to Fwindow_next_sibling.
3668 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3669 (resize_window_check): Rename to window_resize_check.
3670 (resize_window_apply): Rename to window_resize_apply.
3671 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3672 (Fdelete_other_windows_internal, resize_frame_windows)
3673 (Fsplit_window_internal, Fdelete_window_internal)
3674 (grow_mini_window, shrink_mini_window)
3675 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3676
c7e73be5
JD
36772011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3678
3679 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3680 (emacs_fixed_set_min_size): Remove.
3681 (emacs_fixed_new): Take frame as argument.
3682
3683 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3684 (_EmacsFixedPrivate): Remove minwidth/height.
3685 Add struct frame *f.
3686 (emacs_fixed_init): Initialize priv->f.
3687 (get_parent_class, emacs_fixed_set_min_size): Remove.
3688 (emacs_fixed_new): Set priv->f to argument.
3689 (emacs_fixed_get_preferred_width)
3690 (emacs_fixed_get_preferred_height): Use min_width/height from
3691 frames size_hint to set minimum and natural (Bug#8919).
3692 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3693 and use min_width/height from frames size_hint to set
3694 min_width/height (Bug#8919).
3695
3696 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3697 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3698 Fix indentation.
c7e73be5 3699
cf99dcf8
EZ
37002011-06-26 Eli Zaretskii <eliz@gnu.org>
3701
3702 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3703 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3704 called at ZV.
3705
029529ac
CY
37062011-06-26 Chong Yidong <cyd@stupidchicken.com>
3707
3708 * process.c (wait_reading_process_output): Bypass select if
3709 waiting for a cell while ignoring keyboard input, and input is
3710 pending. Suggested by Jan Djärv (Bug#8869).
3711
7a7ef429
PE
37122011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3713
3714 Use gnulib's dup2 module instead of rolling our own.
3715 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3716
11fdef7d 37172011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3718
3719 * dispnew.c (scrolling_window): Before scrolling, turn off a
3720 mouse-highlight in the window being scrolled.
3721
cd3520a4
JB
37222011-06-24 Juanma Barranquero <lekktu@gmail.com>
3723
3724 Move DEFSYM to lisp.h and use everywhere.
3725
3726 * character.h (DEFSYM): Move declaration...
3727 * lisp.h (DEFSYM): ...here.
3728
3729 * gnutls.c:
3730 * minibuf.c:
3731 * w32menu.c:
3732 * w32proc.c:
3733 * w32select.c: Don't include character.h.
3734
3735 * alloc.c (syms_of_alloc):
3736 * buffer.c (syms_of_buffer):
3737 * bytecode.c (syms_of_bytecode):
3738 * callint.c (syms_of_callint):
3739 * casefiddle.c (syms_of_casefiddle):
3740 * casetab.c (init_casetab_once):
3741 * category.c (init_category_once, syms_of_category):
3742 * ccl.c (syms_of_ccl):
3743 * cmds.c (syms_of_cmds):
3744 * composite.c (syms_of_composite):
3745 * dbusbind.c (syms_of_dbusbind):
3746 * dired.c (syms_of_dired):
3747 * dispnew.c (syms_of_display):
3748 * doc.c (syms_of_doc):
3749 * editfns.c (syms_of_editfns):
3750 * emacs.c (syms_of_emacs):
3751 * eval.c (syms_of_eval):
3752 * fileio.c (syms_of_fileio):
3753 * fns.c (syms_of_fns):
3754 * frame.c (syms_of_frame):
3755 * fringe.c (syms_of_fringe):
3756 * insdel.c (syms_of_insdel):
3757 * keymap.c (syms_of_keymap):
3758 * lread.c (init_obarray, syms_of_lread):
3759 * macros.c (syms_of_macros):
3760 * msdos.c (syms_of_msdos):
3761 * print.c (syms_of_print):
3762 * process.c (syms_of_process):
3763 * search.c (syms_of_search):
3764 * sound.c (syms_of_sound):
3765 * syntax.c (init_syntax_once, syms_of_syntax):
3766 * terminal.c (syms_of_terminal):
3767 * textprop.c (syms_of_textprop):
3768 * undo.c (syms_of_undo):
3769 * w32.c (globals_of_w32):
3770 * window.c (syms_of_window):
3771 * xdisp.c (syms_of_xdisp):
3772 * xfaces.c (syms_of_xfaces):
3773 * xfns.c (syms_of_xfns):
3774 * xmenu.c (syms_of_xmenu):
3775 * xsettings.c (syms_of_xsettings):
3776 * xterm.c (syms_of_xterm): Use DEFSYM.
3777
4228cf16
TZ
37782011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3779
cd3520a4 3780 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3781
7fcccf1e
PE
37822011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3783
7efb4e0e
PE
3784 Integer and buffer overflow fixes (Bug#8873).
3785
ff5844ad
PE
3786 * print.c (printchar, strout): Check for string overflow.
3787 (PRINTPREPARE, printchar, strout):
3788 Don't set size unless allocation succeeds.
3789
90532f02
PE
3790 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3791 for sizes. Check for string overflow more accurately.
3792 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3793
6d84508d
PE
3794 * macros.c: Integer and buffer overflow fixes.
3795 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3796 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3797 Use ptrdiff_t, not int, for sizes.
3798 Don't increment bufsize until after realloc succeeds.
3799 Check for size-calculation overflow.
3800 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3801
437b2cb4
PE
3802 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3803
8b9ac8b4
PE
3804 * lread.c: Integer overflow fixes.
3805 (read_integer): Radix is now EMACS_INT, not int,
3806 to improve quality of diagnostics for out-of-range radices.
3807 Calculate buffer size correctly for out-of-range radices.
3808 (read1): Check for integer overflow in radices, and in
3809 read-circle numbers.
82cb60d3
PE
3810 (read_escape): Avoid int overflow.
3811 (Fload, openp, read_buffer_size, read1)
3812 (substitute_object_recurse, read_vector, read_list, map_obarray):
3813 Use ptrdiff_t, not int, for sizes.
3814 (read1): Use EMACS_INT, not int, for sizes.
20270765 3815 Check for size overflow.
8b9ac8b4 3816
7fcccf1e
PE
3817 * image.c (cache_image): Check for size arithmetic overflow.
3818
bfbbd7e7
PE
3819 * lread.c: Integer overflow issues.
3820 (saved_doc_string_size, saved_doc_string_length)
3821 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3822 Now ptrdiff_t, not int.
3823 (read1): Don't assume doc string length fits in int. Check for
3824 out-of-range doc string lengths.
3825 (read_list): Don't assume file position fits in int.
39019e54 3826 (read_escape): Check for hex character overflow.
bfbbd7e7 3827
4e323265
LL
38282011-06-22 Leo Liu <sdl.web@gmail.com>
3829
3830 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3831 Move to minibuffer.el.
3832
85fece3e
PE
38332011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3834
20b84ce9 3835 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3836 The following patches are for when GLYPH_DEBUG && !XASSERT.
3837 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3838 * dispnew.c (flush_stdout):
3839 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3840 Mark as externally visible.
3841 * dispnew.c (check_window_matrix_pointers): Now static.
3842 * dispnew.c (window_to_frame_vpos):
3843 * xfns.c (unwind_create_frame):
3844 * xterm.c (x_check_font): Remove unused local.
3845 * scroll.c (CHECK_BOUNDS):
3846 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3847 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3848 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3849 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3850 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3851 Now static.
3852 (debug_method_add): Use va_list and vsprintf rather than relying
3853 on undefined behavior with wrong number of arguments.
3854 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3855 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3856 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3857 since we're not interested in debugging glyphs with old libraries.
3858 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3859 GCC 4.6.0's static checking.
3860
0766b489
PE
38612011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3862
31fd4b32
PE
3863 Integer overflow and signedness fixes (Bug#8873).
3864 A few related buffer overrun fixes, too.
3865
b79e8648
PE
3866 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3867
0766b489
PE
3868 * dispextern.h (struct face.stipple):
3869 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3870 (x_bitmap_mask, x_allocate_bitmap_record)
3871 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3872 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3873 (x_create_bitmap_from_xpm_data):
3874 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3875 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3876 (.bitmaps_last):
3877 * xfaces.c (load_pixmap):
3878 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3879 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3880 (.bitmaps_last, struct x_output.icon_bitmap):
3881 Use ptrdiff_t, not int, for bitmap indexes.
3882 (x_allocate_bitmap_record): Check for size overflow.
3883 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3884
b081724f
PE
3885 Use ptrdiff_t, not int, for overlay counts.
3886 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3887 * editfns.c (overlays_around, get_pos_property):
3888 * textprop.c (get_char_property_and_overlay):
3889 * xdisp.c (next_overlay_change, note_mouse_highlight):
3890 * xfaces.c (face_at_buffer_position):
21514da7
PE
3891 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3892 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3893 (Fnext_overlay_change, Fprevious_overlay_change)
3894 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3895 Use ptrdiff_t, not int, for sizes.
21514da7 3896 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3897
3de73e5e
PE
3898 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3899
2606c57b
PE
3900 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3901 (x_session_initialize): Do not assume string length fits in int.
3902
aaafe47a
PE
3903 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3904 This is unlikely, but can occur if DPI is outlandish.
3905
2674ddc8 3906 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3907 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3908
28154962
PE
3909 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3910 * xrdb.c (magic_file_p, search_magic_path):
3911 Omit last arg SUFFIX; it was always 0. All callers changed.
3912 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3913
7de51af5
PE
3914 * xfont.c (xfont_match): Avoid need for strlen.
3915
25ed6cc3
PE
3916 * xfns.c: Don't assume strlen fits in int.
3917 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3918
4eab31dd
PE
3919 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3920 not unsigned long, as we prefer signed integers. All callers changed.
3921 Detect integer overflow in repeat count.
3922 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3923 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3924
171e2a58
PE
3925 * termcap.c: Don't assume sizes fit in int and never overflow.
3926 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3927 (gobble_line): Check for size-calculation overflow.
3928
ad39faca 3929 * minibuf.c (Fread_buffer):
6e5bb2dc 3930 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3931 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3932 Don't assume string length fits in int.
3933
52c61c22 3934 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3935 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3936
b5b8c9e5
PE
3937 * font.c: Don't assume string length fits in int.
3938 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3939 Use ptrdiff_t, not int.
ccd6111c
PE
3940 (font_intern_prop): Don't assume string length fits in int.
3941 Don't assume integer property fits in fixnum.
3942 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3943
882f0d81 3944 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3945 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3946 Reformulate so as not to need the command string.
3947 Invoke gzip -cd rather than gunzip, as it's more portable.
3948 (lock_info_type, lock_file_1, lock_file):
3949 Don't assume pid_t and time_t fit in unsigned long.
3950 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3951 (current_lock_owner): Prefer signed type for sizes.
3952 Use memcpy, not strncpy, where memcpy is what is really wanted.
3953 Don't assume (via atoi) that time_t and pid_t fit in int.
3954 Check for time_t and/or pid_t out of range, e.g., via a network share.
3955 Don't alloca where an auto var works fine.
3956
93f4cf88
PE
3957 * fileio.c: Fix some integer overflow issues.
3958 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3959 Don't assume string length fits in int.
3960 (directory_file_name): Don't assume string length fits in long.
3961 (make_temp_name): Don't assume pid fits in int, or that its print
3962 length is less than 20.
3963
f3e92b69
PE
3964 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3965
1bfdaf10
PE
3966 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3967
35016e9a
PE
3968 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3969
3d1e65a1
PE
3970 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3971 We prefer signed integers, even for size calculations.
3972
0b963a93
PE
3973 * emacs.c: Don't assume string length fits in 'int'.
3974 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3975 (main): Don't invoke strlen when not needed.
3976
573f4b54
PE
3977 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3978 (XD_DEBUG_MESSAGE): Don't waste a byte.
3979
989f33ba
PE
3980 * callproc.c (getenv_internal_1, getenv_internal)
3981 (Fgetenv_internal):
965d34eb
PE
3982 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3983
e4d29b33
PE
3984 * lread.c (invalid_syntax): Omit length argument.
3985 All uses changed. This doesn't fix a bug, but it simplifies the
3986 code away from its former Hollerith-constant appearance, and it's
3987 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3988 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3989
eb49b136
PE
3990 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3991 This didn't break anything, but it didn't help either.
3992 It's confusing to put a bogus integer in a place where the actual
3993 value does not matter.
9f62aeb1 3994 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3995 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3996
15375a22
PE
3997 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3998 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3999 implementation.
b61cc01c
PE
4000 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4001 We prefer signed types, and the value cannot exceed the EMACS_INT
4002 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4003 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4004 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4005 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4006
53b2623d
PE
4007 * indent.c (sane_tab_width): New function.
4008 (current_column, scan_for_column, Findent_to, position_indentation)
4009 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4010 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4011
51cab52b 4012 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4013
f2ed8a70
PE
4014 * lisp.h (lint_assume): New macro.
4015 * composite.c (composition_gstring_put_cache):
4016 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4017
abe80cc6
PE
4018 * editfns.c, insdel.c:
4019 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4020
b02c740e
PE
4021 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4022
ebc96716
PE
4023 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4024
b4e50fa0 4025 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4026 Use much-faster test for byte-length change.
311d5d7c 4027 Don't assume string byte-length fits in 'int'.
a4cf38e4 4028 Check that character arg fits in 'int'.
85461888 4029 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4030
c0c1ee9f
PE
4031 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4032
a498d7f4
PE
4033 * fns.c (concat): Catch string overflow earlier.
4034 Do not rely on integer wraparound.
4035
51cab52b
PE
4036 * dispextern.h (struct it.overlay_strings_charpos)
4037 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4038 * xdisp.c (forward_to_next_line_start)
4039 (back_to_previous_visible_line_start)
4040 (reseat_at_next_visible_line_start, next_element_from_buffer):
4041 Don't arbitrarily truncate the value of 'selective' to int.
4042
76031fad
PE
4043 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4044
5eb55db9
PE
4045 * composite.c: Don't truncate sizes to 'int'.
4046 (composition_gstring_p, composition_reseat_it)
4047 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4048 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4049 not EMACS_UINT, for indexes.
5eb55db9 4050
0703a717
PE
4051 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4052
d6202519
PE
4053 * buffer.c: Include <verify.h>.
4054 (struct sortvec.priority, struct sortstr.priority):
8961a454 4055 Now EMACS_INT, not int.
c20998a7 4056 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4057 (struct sortstr.size, record_overlay_string)
4058 (struct sortstrlist.size, struct sortlist.used):
4059 Don't truncate size to int.
4060 (record_overlay_string): Check for size-calculation overflow.
d6202519 4061 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4062
d5a19415
JM
40632011-06-22 Jim Meyering <meyering@redhat.com>
4064
029529ac 4065 Don't leak an XBM-image-sized buffer
d5a19415
JM
4066 * image.c (xbm_load): Free the image buffer after using it.
4067
a9041e6c
PE
40682011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4069
4070 Port to Sun C.
4071 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4072 that Sun C diagnosed.
4073 * fns.c (secure_hash): Fix pointer signedness issue.
4074 * intervals.c (static_offset_intervals): New function.
4075 (offset_intervals): Use it.
4076
7f3f739f
LL
40772011-06-21 Leo Liu <sdl.web@gmail.com>
4078
4079 * deps.mk (fns.o):
4080 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4081 sha512.h.
4082
4083 * fns.c (secure_hash): Rename from crypto_hash_function and change
4084 the first arg to accept symbols.
5b66d427 4085 (Fsecure_hash): New primitive.
7f3f739f
LL
4086 (syms_of_fns): New symbols.
4087
76147d94
DD
40882011-06-20 Deniz Dogan <deniz@dogan.se>
4089
4090 * process.c (Fset_process_buffer): Clarify return value in
4091 docstring.
4092
7d7d0045
CY
40932011-06-18 Chong Yidong <cyd@stupidchicken.com>
4094
4095 * dispnew.c (add_window_display_history): Use BVAR.
4096
4097 * xdisp.c (debug_method_add): Use BVAR.
4098 (check_window_end, dump_glyph_matrix, dump_glyph)
4099 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4100
4101 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4102 Likewise.
4103
4104 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4105 check till after the cache is created in init_frame_faces.
4106
ff2bc410
SM
41072011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4108
4109 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4110
28177add
PE
41112011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4112
dd3482fe
PE
4113 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4114 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4115 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4116
393d71f3 4117 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4118 * fileio.c (Finsert_file_contents):
4119 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4120 Remove the old (too-loose) buffer overflow checks.
4121 They weren't needed, since make_gap checks for buffer overflow.
4122 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4123 The old code merely checked for Emacs fixnum overflow, and relied
4124 on undefined (wraparound) behavior. The new code avoids undefined
4125 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4126
2e6813b0 4127 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4128 Tune. Don't use wider integers than needed. Don't use alloca.
4129 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4130
599a9e4f
PE
4131 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4132
99561444
PE
4133 * insdel.c, lisp.h (buffer_overflow): New function.
4134 (insert_from_buffer_1, replace_range, replace_range_2):
4135 * insdel.c (make_gap_larger):
4136 * editfns.c (Finsert_char):
4137 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4138
28177add
PE
4139 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4140
e69dafad
PE
41412011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4142
a7af7fde 4143 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4144
b1c46f02
PE
4145 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4146 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4147
e69dafad
PE
4148 * fileio.c: Don't assume EMACS_INT fits in off_t.
4149 (emacs_lseek): New static function.
4150 (Finsert_file_contents, Fwrite_region): Use it.
4151 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4152
566684ea
PE
4153 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4154
e6966cd6
PE
4155 * fns.c: Don't overflow int when computing a list length.
4156 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4157 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4158 truncation on 64-bit hosts. Check for QUIT every
4159 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4160 faster and is responsive enough.
4161 (Flength): Report an error instead of overflowing an integer.
4162 (Fsafe_length): Return a float if the value is not representable
4163 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4164 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4165 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4166
dd0b0efb
PE
4167 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4168 (header_size, word_size): New constants.
4169 (allocate_vectorlike): Don't check size overflow here.
4170 (allocate_vector): Check it here instead, since this is the only
4171 caller of allocate_vectorlike that could cause overflow.
4172 Check that the new vector's length is representable as a fixnum.
4173
86fe5cfe
PE
4174 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4175 The previous code was bogus. For example, next_almost_prime (32)
4176 returned 39, which is undesirable as it is a multiple of 3; and
4177 next_almost_prime (24) returned 25, which is a multiple of 5 so
4178 why was the code bothering to check for multiples of 7?
4179
80e88859
PE
4180 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4181
4a2f0ad6
PE
4182 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4183
f66c7cf8
PE
4184 Variadic C functions now count arguments with ptrdiff_t.
4185 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4186 Back then I didn't know that the Emacs coding style prefers signed int.
4187 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4188 were being counted with int, which may truncate counts on 64-bit
4189 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4190 * lisp.h (struct Lisp_Subr.function.aMANY)
4191 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4192 Arg counts are now ptrdiff_t, not size_t.
4193 All variadic functions and their callers changed accordingly.
4194 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4195 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4196 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4197 * callint.c (Fcall_interactively): Check arg count for overflow,
4198 to avoid potential buffer overrun. Use signed char, not 'int',
4199 for 'varies' array, so that we needn't bother to check its size
4200 calculation for overflow.
4201 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4202 * eval.c (apply_lambda):
4203 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4204 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4205 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4206
a1759b76
PE
4207 * callint.c (Fcall_interactively): Don't use index var as event count.
4208
d96be9fc
PE
4209 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4210 * mem-limits.h (SIZE): Remove; no longer used.
4211
a690a978 4212 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4213
578c21e6
PE
4214 Remove unnecessary casts.
4215 * xterm.c (x_term_init):
4216 * xfns.c (x_set_border_pixel):
4217 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4218 These aren't needed now that we assume ANSI C.
4219
96f53c6c
PE
4220 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4221 It's more likely to cause problems (due to unsigned overflow)
4222 than to cure them.
4223
83c77d31
PE
4224 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4225
ee2079f1
PE
4226 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4227
6da65536
PE
4228 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4229
7147c4a4
PE
4230 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4231
193e32d9
PE
4232 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4233
e5533da6
PE
4234 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4235
9910e595
PE
4236 GLYPH_CODE_FACE returns EMACS_INT, not int.
4237 * dispextern.h (merge_faces):
4238 * xfaces.c (merge_faces):
01103c44
PE
4239 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4240 Don't assume EMACS_INT fits in int.
9910e595 4241
2638320e
PE
4242 * character.h (CHAR_VALID_P): Remove unused parameter.
4243 * fontset.c, lisp.h, xdisp.c: All uses changed.
4244
045eb8d9
PE
4245 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4246
c1f134b5
PE
4247 * fns.c (concat): Minor tuning based on overflow analysis.
4248 This doesn't fix any bugs. Use int to hold character, instead
4249 of constantly refetching from Emacs object. Use XFASTINT, not
4250 XINT, for value known to be a character. Don't bother comparing
4251 a single byte to 0400, as it's always less.
4252
395fcb93 4253 * floatfns.c (Fexpt):
327eeec8
PE
4254 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4255
abbd3d23
PE
4256 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4257 for characters.
4258
684a03ef
PE
4259 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4260
0fed43f3
PE
4261 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4262 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4263 incorrectly succeed when S was a string, because 4294967386 was
4264 truncated before it was used.
4265
8fd02eb7
PE
4266 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4267 Otherwise, an out-of-range integer could cause undefined behavior
4268 on a 64-bit host.
4269
f8c86b69
PE
4270 * composite.c: Use int, not EMACS_INT, for characters.
4271 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4272 EMACS_INT, for values that are known to be in character range.
4273 This doesn't fix any bugs but is the usual style inside Emacs and
4274 may generate better code on 32-bit machines.
4275
34206dd2
PE
4276 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4277 This is for reasons similar to the recent CHAR_STRING fix.
4278 * charset.c (Fencode_char): Check that character arg is actually
4279 a character. Pass an int to ENCODE_CHAR.
4280 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4281 wider than 'int', as a compile-time check to prevent future regressions
4282 in this area.
4283
c5958d4c 4284 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4285
4286 Make sure a 64-bit char is never passed to CHAR_STRING.
4287 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4288 by silently ignoring the top 32 bits, allowing some values
4289 that were far too large to be valid characters.
4290 * character.h: Include <verify.h>.
4291 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4292 arguments are no wider than unsigned, as a compile-time check
4293 to prevent future regressions in this area.
4294 * data.c (Faset):
01103c44 4295 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4296 (Fsubst_char_in_region):
4297 * fns.c (concat):
4298 * xdisp.c (decode_mode_spec_coding):
4299 Adjust to CHAR_STRING's new requirement.
4300 * editfns.c (Finsert_char, Fsubst_char_in_region):
4301 * fns.c (concat): Check that character args are actually
4302 characters. Without this test, these functions did the wrong
4303 thing with wildly out-of-range values on 64-bit hosts.
4304
d37ca623
PE
4305 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4306 These casts should not be needed on 32-bit hosts, either.
4307 * keyboard.c (read_char):
4308 * lread.c (Fload): Remove casts to unsigned.
4309
ea204efb
PE
4310 * lisp.h (UNSIGNED_CMP): New macro.
4311 This fixes comparison bugs on 64-bit hosts.
4312 (ASCII_CHAR_P): Use it.
4313 * casefiddle.c (casify_object):
01103c44 4314 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4315 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4316 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4317 * dispextern.h (FACE_FROM_ID):
4318 * keyboard.c (read_char): Use UNSIGNED_CMP.
4319
41cb286c
PE
4320 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4321 not to EMACS_INT, to avoid GCC warning.
4322
4a1b9832
PE
4323 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4324
55daad71
PE
4325 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4326 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4327 isn't needed on 32-bit machines.
8f95c75c 4328
01103c44
PE
4329 * buffer.c (Fgenerate_new_buffer_name):
4330 Use EMACS_INT for count, not int.
0ceccced 4331 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4332
4333 * data.c (Qcompiled_function): Now static.
4334
c6f072e7
PE
4335 * window.c (window_body_lines): Now static.
4336
20ce5912
PE
4337 * image.c (gif_load): Rename local to avoid shadowing.
4338
9c4c5f81
PE
4339 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4340 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4341 * alloc.c (make_save_value): Integer argument is now of type
4342 ptrdiff_t, not int.
4343 (mark_object): Use ptrdiff_t, not int.
4344 * lisp.h (pD): New macro.
4345 * print.c (print_object): Use it.
4346
c0c5c8ae
PE
4347 * alloc.c: Use EMACS_INT, not int, to count objects.
4348 (total_conses, total_markers, total_symbols, total_vector_size)
4349 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4350 (total_free_floats, total_floats, total_free_intervals)
4351 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4352 Now EMACS_INT, not int. All uses changed.
4353 (Fgarbage_collect): Compute overall total using a double, so that
4354 integer overflow is less likely to be a problem. Check for overflow
4355 when converting back to an integer.
5a25e253
PE
4356 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4357 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4358 These were 'int' variables that could overflow on 64-bit hosts;
4359 they were never used, so remove them instead of repairing them.
211a0b2a 4360 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4361 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4362 Previously, this ceilinged at INT_MAX, but that doesn't work on
4363 64-bit machines.
e46bb31a 4364 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4365
c78baabf 4366 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4367 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4368 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4369 when a (possibly-narrower) signed value would do just as well.
4370 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4371
c9d624c6
PE
4372 * alloc.c: Catch some string size overflows that we were missing.
4373 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4374 for convenience in STRING_BYTES_MAX.
4375 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4376 The definition here is exact; the one in lisp.h was approximate.
4377 (allocate_string_data): Check for string overflow. This catches
4378 some instances we weren't catching before. Also, it catches
4379 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4380 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4381 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4382
c9d624c6
PE
4383 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4384 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4385 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4386
353032ce
PE
4387 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4388
2bccce07
PE
4389 * alloc.c (Fmake_string): Check for out-of-range init.
4390
0ac30604
SM
43912011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4392
4393 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4394
c195f2de
JD
43952011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4396
4397 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4398 xg_get_default_scrollbar_width.
4399
4400 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4401 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4402 (style_changed_cb): Call update_theme_scrollbar_width and call
4403 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4404 all frames (Bug#8505).
4405 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4406 Call gtk_window_set_resizable if HAVE_GTK3.
4407 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4408 and height if HAVE_GTK3 (Bug#8505).
4409 (scroll_bar_width_for_theme): New variable.
4410 (update_theme_scrollbar_width): New function.
4411 (xg_get_default_scrollbar_width): Move code to
4412 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4413 (xg_initialize): Call update_theme_scrollbar_width.
4414
4415 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4416
4417 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4418
e10ac9f1
MR
44192011-06-12 Martin Rudalics <rudalics@gmx.at>
4420
4421 * frame.c (make_frame): Call other_buffer_safely instead of
4422 other_buffer.
4423
4424 * window.c (temp_output_buffer_show): Call display_buffer with
4425 second argument Vtemp_buffer_show_specifiers and reset latter
4426 immediately after the call.
4427 (Vtemp_buffer_show_specifiers): New variable.
4428 (auto_window_vscroll_p, next_screen_context_lines)
4429 (Vscroll_preserve_screen_position): Remove leading asterisks from
4430 doc-strings.
4431
2d3c217e 44322011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4433
7b7f97e8 4434 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4435 * buffer.c (Qclone_number): Remove for now, as it's unused.
4436 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4437 (record_buffer): Remove unused local.
4438 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4439 (set_frame_buffer_list): Remove; unused.
4440 * frame.h (other_visible_frames): Remove decl.
4441 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4442 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4443 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4444 if HAVE_GPM.
4445 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4446 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4447 Define only if HAVE_GPM.
4448 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4449 (update_hints_inhibit): Remove; never set. All uses removed.
4450 * widgetprv.h (emacsFrameClassRec): Remove decl.
4451 * window.c (delete_deletable_window): Now returns void, since it
4452 wasn't returning anything.
4453 (compare_window_configurations): Remove unused locals.
4454 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4455 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4456 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4457 the same widths as pointers. This follows up on the 2011-05-06 patch.
4458 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4459 * xterm.h: Likewise.
4460 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4461
1384b89e
JB
44622011-06-12 Juanma Barranquero <lekktu@gmail.com>
4463
4464 * makefile.w32-in: Update dependencies.
4465 (LISP_H): Add lib/intprops.h.
4466
1100a63c
CY
44672011-06-11 Chong Yidong <cyd@stupidchicken.com>
4468
4469 * image.c (gif_load): Add animation frame delay to the metadata.
4470 (syms_of_image): Use DEFSYM. New symbol `delay'.
4471
6198ccd0
MR
44722011-06-11 Martin Rudalics <rudalics@gmx.at>
4473
4474 * window.c (delete_deletable_window): Re-add.
4475 (Fset_window_configuration): Rewrite to handle dead buffers and
4476 consequently deletable windows.
4477 (window_tree, Fwindow_tree): Remove. Supply functionality in
4478 window.el.
4479 (compare_window_configurations): Simplify code.
4480
b6e3633c
AS
44812011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4482
1ab0dee5
AS
4483 * image.c (imagemagick_load_image): Fix type mismatch.
4484 (Fimagemagick_types): Likewise.
4485
b6e3633c
AS
4486 * window.h (replace_buffer_in_windows): Declare.
4487
9397e56f
MR
44882011-06-11 Martin Rudalics <rudalics@gmx.at>
4489
4490 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4491 Qclone_number. Remove external declaration of Qdelete_window.
4492 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4493 code.
640c8776
SM
4494 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4495 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4496 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4497 buffer list implementation.
4498 (other_buffer_safely): New function.
4499 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4500 calls to replace_buffer_in_windows and
4501 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4502 if allowed.
4503 (record_buffer): Inhibit quitting and rewrite using quittable
4504 functions. Run Qbuffer_list_update_hook if allowed.
4505 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4506 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4507 Move switch-to-buffer to window.el.
9397e56f
MR
4508 (bury-buffer): Move to window.el.
4509 (Vbuffer_list_update_hook): New variable.
4510
4511 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4512 section.
4513
4514 * window.h (resize_frame_windows): Move up in code.
4515 (Fwindow_frame): Remove EXFUN.
4516 (replace_buffer_in_all_windows): Remove prototype.
4517 (replace_buffer_in_windows_safely): Add prototype.
4518
4519 * window.c: Declare Qdelete_window static again. Move down
4520 declaration of select_count.
4521 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4522 (Fother_window): Move to window.el.
4523 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4524 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4525 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4526 window.el.
4527 (replace_buffer_in_windows): Implement by calling
4528 Qreplace_buffer_in_windows.
4529 (replace_buffer_in_all_windows): Remove with some functionality
4530 moved into replace_buffer_in_windows_safely.
4531 (replace_buffer_in_windows_safely): New function.
4532 (select_window_norecord, select_frame_norecord): Move in front
4533 of run_window_configuration_change_hook. Remove now obsolete
4534 declarations.
640c8776
SM
4535 (Fset_window_buffer): Rewrite doc-string.
4536 Call Qrecord_window_buffer.
9397e56f
MR
4537 (keys_of_window): Move binding for other-window to window.el.
4538
b50691aa
CY
45392011-06-11 Chong Yidong <cyd@stupidchicken.com>
4540
4541 * dispextern.h (struct image): Replace data member, whose int_val
4542 and ptr_val fields were not used by anything, with a single
4543 lisp_val object.
4544
4545 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4546 (gif_clear_image, gif_load, imagemagick_load_image)
4547 (gs_clear_image, gs_load): Callers changed.
4548
3f754b86
PE
45492011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4550
cca69397
PE
4551 * buffer.h: Include <time.h>, for time_t.
4552 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4553
109e28d0
PE
4554 Fix minor problems found by static checking.
4555
60737f02
PE
4556 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4557
4b66faf3
PE
4558 Make identifiers static if they are not used in other modules.
4559 * data.c (Qcompiled_function, Qframe, Qvector):
4560 * image.c (QimageMagick, Qsvg):
4561 * minibuf.c (Qmetadata):
4562 * window.c (resize_window_check, resize_root_window): Now static.
4563 * window.h (resize_window_check, resize_root_window): Remove decls.
4564
109e28d0
PE
4565 * window.c (window_deletion_count, delete_deletable_window):
4566 Remove; unused.
46a4ce9e
PE
4567 (window_body_lines): Now static.
4568 (Fdelete_other_windows_internal): Mark vars as initialized.
4569 Make sure 'resize_failed' is initialized.
4570 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4571 (resize_window_apply): Remove unused local.
4572 * window.h (delete_deletable_window): Remove decl.
4573
109e28d0 4574 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4575 (imagemagick_load_image): Fix pointer signedness problem by changing
4576 last arg from unsigned char * to char *. All uses changed.
4577 Also, fix a local for similar reasons.
4578 Remove unused locals. Remove locals to avoid shadowing.
4579 (fn_rsvg_handle_free): Remove; unused.
4580 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4581 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4582
3f754b86
PE
4583 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4584
2547adb1
CY
45852011-06-10 Chong Yidong <cyd@stupidchicken.com>
4586
4587 * image.c (gif_load): Fix omitted cast error introduced by
4588 2011-06-06 change.
4589
2c8e37d4
MR
45902011-06-10 Martin Rudalics <rudalics@gmx.at>
4591
4592 * window.h (resize_proportionally, orig_total_lines)
4593 (orig_top_line): Remove from window structure.
4594 (set_window_height, set_window_width, change_window_heights)
4595 (Fdelete_window): Remove prototypes.
4596 (resize_frame_windows): Remove duplicate declaration.
4597
440a42e3
EZ
45982011-06-10 Eli Zaretskii <eliz@gnu.org>
4599
4600 * window.h (resize_frame_windows, resize_window_check)
4601 (delete_deletable_window, resize_root_window)
4602 (resize_frame_windows): Declare prototypes.
4603
4604 * window.c (resize_window_apply): Make definition be "static" to
4605 match the prototype.
4606
562dd5e9
MR
46072011-06-10 Martin Rudalics <rudalics@gmx.at>
4608
4609 * window.c: Remove declarations of Qwindow_size_fixed,
4610 window_min_size_1, window_min_size_2, window_min_size,
4611 size_window, window_fixed_size_p, enlarge_window, delete_window.
4612 Remove static from declaration of Qdelete_window, it's
4613 temporarily needed by Fbury_buffer.
4614 (replace_window): Don't assign orig_top_line and
4615 orig_total_lines.
4616 (Fdelete_window, delete_window): Remove. Window deletion is
4617 handled by window.el.
640c8776
SM
4618 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4619 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4620 (Fdelete_other_windows): Remove. Deleting other windows is
4621 handled by window.el.
4622 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4623 handled in window.el.
4624 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4625 Window minimum sizes are handled in window.el.
4626 (shrink_windows, size_window, set_window_height)
4627 (set_window_width, change_window_heights, window_height)
4628 (window_width, CURBEG, CURSIZE, enlarge_window)
4629 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4630 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4631 handled in window.el.
4632 (make_dummy_parent): Rename to make_parent_window and give it a
4633 second argument horflag.
4634 (make_window): Don't set resize_proportionally any more.
4635 (Fsplit_window): Remove. Windows are split in window.el.
4636 (save_restore_action, save_restore_orig_size)
4637 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4638 Resize mini windows in window.el.
4639 (grow_mini_window, shrink_mini_window): Implement by calling
4640 Qresize_root_window_vertically, resize_window_check and
4641 resize_window_apply.
640c8776
SM
4642 (saved_window, Fset_window_configuration, save_window_save):
4643 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4644 resize_proportionally.
4645 (window_min_height, window_min_width): Move to window.el.
4646 (keys_of_window): Move bindings for delete-other-windows,
4647 split-window, delete-window and enlarge-window to window.el.
4648
4649 * buffer.c: Temporarily extern Qdelete_window.
4650 (Fbury_buffer): Temporarily call Qdelete_window instead of
4651 Fdelete_window (Fbury_buffer will move to window.el soon).
4652
4653 * frame.c (set_menu_bar_lines_1): Remove code handling
4654 orig_top_line and orig_total_lines.
4655
4656 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4657 set_window_height but set heights directly.
4658 (change_frame_size_1): Use resize_frame_windows.
4659
4660 * xdisp.c (init_xdisp): Don't use set_window_height but set
4661 heights directly.
4662
640c8776
SM
4663 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4664 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4665 run_window_configuration_change_hook.
4666
4667 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4668 instead of change_window_heights and run
4669 run_window_configuration_change_hook.
4670
1a13852e
MR
46712011-06-09 Martin Rudalics <rudalics@gmx.at>
4672
4673 * window.c (replace_window): Rename second argument REPLACEMENT to
4674 NEW. New third argument SETFLAG. Rewrite.
4675 (delete_window, make_dummy_parent): Call replace_window with
4676 third argument 1.
4677 (window_list_1): Move down in code.
4678 (run_window_configuration_change_hook): Move set_buffer part
4679 before select_frame_norecord part in order to unwind correctly.
4680 Rename count1 to count.
4681 (recombine_windows, delete_deletable_window, resize_root_window)
4682 (Fdelete_other_windows_internal)
4683 (Frun_window_configuration_change_hook, make_parent_window)
4684 (resize_window_check, resize_window_apply, Fresize_window_apply)
4685 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4686 (Fdelete_window_internal, Fresize_mini_window_internal):
4687 New functions.
1a13852e
MR
4688 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4689
f3d1777e
MR
46902011-06-08 Martin Rudalics <rudalics@gmx.at>
4691
496e208e
MR
4692 * window.h (window): Add some new members to window structure -
4693 normal_lines, normal_cols, new_total, new_normal, clone_number,
4694 splits, nest, prev_buffers, next_buffers.
4695 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4696 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4697
f3d1777e
MR
4698 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4699 Remove.
496e208e
MR
4700 (make_dummy_parent): Set new members of windows structure.
4701 (make_window): Move down in code. Handle new members of window
4702 structure.
4703 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4704 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4705 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4706 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4707 (Fset_window_next_buffers, Fset_window_clone_number):
4708 New functions.
496e208e
MR
4709 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4710 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4711 Doc-string fixes.
4712 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4713 Argument WINDOW can be now internal window too.
4714 (Fwindow_use_time): Move up in code.
4715 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4716 Rewrite doc-string.
4717 (Fset_window_configuration, saved_window)
4718 (Fcurrent_window_configuration, save_window_save): Handle new
4719 members of window structure.
b9e809c2
MR
4720 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4721 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4722 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4723 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4724 Qget_mru_window, Qresize_root_window,
4725 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4726 Qauto_buffer_name; staticpro them.
f3d1777e 4727
abde8f8c
MR
47282011-06-07 Martin Rudalics <rudalics@gmx.at>
4729
4730 * window.c (Fwindow_total_size, Fwindow_left_column)
4731 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4732 (Fwindow_list_1): New functions.
4733 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4734 (Fwindow_width, Fscroll_left, Fscroll_right):
4735 Use window_body_cols instead of window_box_text_cols.
4736 (delete_window, Fset_window_configuration):
4737 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4738 (delete_all_subwindows): Take a window as argument and not a
4739 structure. Rewrite.
190b47e6
MR
4740 (window_loop): Remove handling of GET_LRU_WINDOW and
4741 GET_LARGEST_WINDOW.
4742 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4743
4744 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4745 window_box_text_cols. delete_all_subwindows now takes a
4746 Lisp_Object as argument.
abde8f8c 4747
640c8776
SM
4748 * indent.c (compute_motion, Fcompute_motion):
4749 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4750
fa8a67e6
MR
4751 * frame.c (delete_frame): Call delete_all_subwindows with root
4752 window as argument.
4753
a54e3482
DC
47542011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4755
4756 * fns.c (Fputhash): Document return value.
4757
60002bf5
CY
47582011-06-06 Chong Yidong <cyd@stupidchicken.com>
4759
4760 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4761
0c671da6 47622011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4763
b862a52a 4764 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4765
be44ca6c
PE
4766 Check for overflow when converting integer to cons and back.
4767 * charset.c (Fdefine_charset_internal, Fdecode_char):
4768 Use cons_to_unsigned to catch overflow.
4769 (Fencode_char): Use INTEGER_TO_CONS.
4770 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4771 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4772 * data.c (long_to_cons, cons_to_long): Remove.
4773 (cons_to_unsigned, cons_to_signed): New functions.
4774 These signal an error for invalid or out-of-range values.
4775 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4776 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4777 * font.c (Ffont_variation_glyphs):
4778 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4779 * lisp.h: Include <intprops.h>.
4780 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4781 (cons_to_signed, cons_to_unsigned): New decls.
4782 (long_to_cons, cons_to_long): Remove decls.
4783 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4784 (Fprimitive_undo): Use CONS_TO_INTEGER.
4785 * xfns.c (Fx_window_property): Likewise.
4786 * xselect.c: Include <limits.h>.
4787 (x_own_selection, selection_data_to_lisp_data):
4788 Use INTEGER_TO_CONS.
4789 (x_handle_selection_request, x_handle_selection_clear)
4790 (x_get_foreign_selection, Fx_disown_selection_internal)
4791 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4792 (lisp_data_to_selection_data): Use cons_to_unsigned.
4793 (x_fill_property_data): Use cons_to_signed.
4794 Report values out of range.
4795
d1f3d2af
PE
4796 Check for buffer and string overflow more precisely.
4797 * buffer.h (BUF_BYTES_MAX): New macro.
4798 * lisp.h (STRING_BYTES_MAX): New macro.
4799 * alloc.c (Fmake_string):
4800 * character.c (string_escape_byte8):
4801 * coding.c (coding_alloc_by_realloc):
4802 * doprnt.c (doprnt):
4803 * editfns.c (Fformat):
4804 * eval.c (verror):
4805 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4806 since they may not be the same number.
4807 * editfns.c (Finsert_char):
4808 * fileio.c (Finsert_file_contents):
4809 Likewise for BUF_BYTES_MAX.
4810
dd52fcea
PE
4811 * image.c: Use ptrdiff_t, not int, for sizes.
4812 (slurp_file): Switch from int to ptrdiff_t.
4813 All uses changed.
4814 (slurp_file): Check that file size fits in both size_t (for
4815 malloc) and ptrdiff_t (for sanity and safety).
4816
7f9bbdbb
PE
4817 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4818 if b->modtime has its maximal value.
4819
dfe18f82
PE
4820 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4821
84acfcf0
PE
4822 Don't assume time_t can fit into int.
4823 * buffer.h (struct buffer.modtime): Now time_t, not int.
4824 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4825 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4826
ccd9a01a
PE
4827 Minor fixes for signed vs unsigned integers.
4828 * character.h (MAYBE_UNIFY_CHAR):
4829 * charset.c (maybe_unify_char):
4830 * keyboard.c (read_char, reorder_modifiers):
4831 XINT -> XFASTINT, since the integer must be nonnegative.
4832 * ftfont.c (ftfont_spec_pattern):
4833 * keymap.c (access_keymap, silly_event_symbol_error):
4834 XUINT -> XFASTINT, since the integer must be nonnegative.
4835 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4836 since it makes no difference and we prefer signed.
4837 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4838 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4839 nonnegative.
4840
d6d100dd
SM
48412011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4842
4843 * window.h (Fwindow_frame): Declare.
4844
2b6148e4
PE
48452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4846
4847 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4848 (SPARE_MEMORY): Always define.
4849 (LARGE_REQUEST): Remove.
4850 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4851
f230ecc9
MR
48522011-06-06 Martin Rudalics <rudalics@gmx.at>
4853
727e958e
MR
4854 * lisp.h: Move EXFUNS for Fframe_root_window,
4855 Fframe_first_window and Fset_frame_selected_window to window.h.
4856
4857 * window.h: Move EXFUNS for Fframe_root_window,
4858 Fframe_first_window and Fset_frame_selected_window here from
4859 lisp.h.
4860
4861 * frame.c (Fwindow_frame, Fframe_first_window)
4862 (Fframe_root_window, Fframe_selected_window)
4863 (Fset_frame_selected_window): Move to window.c.
4864 (Factive_minibuffer_window): Move to minibuf.c.
4865 (Fother_visible_frames_p): New function.
4866
4867 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4868
f230ecc9
MR
4869 * window.c (decode_window, decode_any_window): Move up in code.
4870 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4871 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4872 (Fwindow_buffer): Move up and rewrite doc-string.
4873 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4874 (Fwindow_prev): New functions.
727e958e
MR
4875 (Fwindow_frame): Move here from frame.c. Accept any window as
4876 argument.
4877 (Fframe_root_window, Fframe_first_window)
4878 (Fframe_selected_window): Move here from frame.c. Accept frame
4879 or arbitrary window as argument. Update doc-strings.
4880 (Fminibuffer_window): Move up in code.
4881 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4882 (Fset_frame_selected_window): Move here from frame.c.
4883 Marginal rewrite.
727e958e
MR
4884 (Fselected_window, select_window, Fselect_window): Move up in
4885 code. Minor doc-string fixes.
f230ecc9 4886
4d09bcf6
PE
48872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4888
4889 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4890 Do not assume that spare memory exists; that assumption is valid
4891 only if SYSTEM_MALLOC.
4892 (LARGE_REQUEST): New macro, so that the issue of large requests
4893 is separated from the issue of spare memory.
4894
810928a2
AS
48952011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4896
172418ad
AS
4897 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4898 format. (Bug#8806)
4899
43f862f7
AS
4900 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4901
810928a2
AS
4902 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4903 before statements.
4904
a059fe24
JD
49052011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4906
4907 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4908
4909 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4910
4911 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4912 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4913
989bf368
JB
49142011-06-05 Juanma Barranquero <lekktu@gmail.com>
4915
4916 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4917
4b80f674
CY
49182011-06-04 Chong Yidong <cyd@stupidchicken.com>
4919
4920 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4921 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4922 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4923 New error handlers.
4b80f674
CY
4924 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4925 Obey Vx_select_enable_clipboard_manager. Catch errors in
4926 x_clipboard_manager_save (Bug#8779).
4927 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4928 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4929
99a33b77 49302011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4931
4932 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4933
99a33b77 49342011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4935
4936 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4937 in the current matrix if keep_current_p is non-zero.
4938
8264569d
EZ
49392011-06-04 Eli Zaretskii <eliz@gnu.org>
4940
4941 * bidi.c (bidi_level_of_next_char): Fix last change.
4942
57f97249
EZ
49432011-06-03 Eli Zaretskii <eliz@gnu.org>
4944
fec2107c 4945 Support bidi reordering of text covered by display properties.
57f97249 4946
fec2107c
EZ
4947 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4948 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4949 (bidi_cache_search, bidi_cache_iterator_state)
4950 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4951 (bidi_level_of_next_char, bidi_move_to_visually_next):
4952 Support character positions inside a run of characters covered by a
fec2107c
EZ
4953 display string.
4954 (bidi_paragraph_init, bidi_resolve_explicit_1)
4955 (bidi_level_of_next_char): Call bidi_fetch_char and
4956 bidi_fetch_char_advance instead of FETCH_CHAR and
4957 FETCH_CHAR_ADVANCE.
4958 (bidi_init_it): Initialize new members.
4959 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4960 definitions.
4961 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4962 instead of using explicit *_CHAR codes.
d6d100dd
SM
4963 (bidi_resolve_explicit, bidi_resolve_weak):
4964 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4965 bidirectional text is supported only in multibyte buffers.
4966 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4967 it to initialize the frame_window_p member of struct bidi_it.
4968 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4969 (bidi_resolve_explicit, bidi_resolve_weak)
4970 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4971 bidi_it->nchars is non-positive.
4972 (bidi_level_of_next_char): Don't try to lookup the cache for the
4973 next/previous character if nothing is cached there yet, or if we
4974 were just reseat()'ed to a new position.
c40e2fb2 4975
0e14fe90
EZ
4976 * xdisp.c (set_cursor_from_row): Set start and stop points
4977 according to the row's direction when priming the loop that looks
4978 for the glyph on which to display cursor.
4979 (single_display_spec_intangible_p): Function deleted.
4980 (display_prop_intangible_p): Reimplement to call
4981 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4982 Accept 3 additional arguments needed by handle_display_spec.
4983 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4984 values: lists, `(when COND...)' forms, etc.
4985 (single_display_spec_string_p): Support property values that are
4986 lists with the argument STRING its top-level element.
4987 (display_prop_string_p): Fix the condition for processing a
4988 property that is a list to be consistent with handle_display_spec.
fec2107c 4989 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4990 last portion of handle_display_prop.
4991 (compute_display_string_pos): Accept additional argument
4992 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4993 value of a `display' property is a "replacing spec".
4994 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4995 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4996 the display property, but just return a value indicating whether
4997 the display property will replace the characters it covers.
4998 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4999 frame_window_p members of struct bidi_it.
d6d100dd
SM
5000 (compute_display_string_pos, compute_display_string_end):
5001 New functions.
fec2107c
EZ
5002 (push_it): Accept second argument POSITION, where pop_it should
5003 jump to continue iteration.
5004 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5005
fec2107c
EZ
5006 * keyboard.c (adjust_point_for_property): Adjust the call to
5007 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5008
5009 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5010 (bidi_init_it): Update prototypes.
5011 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5012 (compute_display_string_pos, compute_display_string_end):
5013 Declare prototypes.
fec2107c
EZ
5014 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5015 EMACS_INT.
fc6f18ce 5016
40087514 50172011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5018
57f53182
PE
5019 Malloc failure behavior now depends on size of allocation.
5020 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5021 * lisp.h: Change signatures accordingly.
5022 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5023 All callers changed. (Bug#8762)
5024
5025 * gnutls.c: Use Emacs's memory allocators.
5026 Without this change, the gnutls library would invoke malloc etc.
5027 directly, which causes problems on non-SYNC_INPUT hosts, and which
5028 runs afoul of improving memory_full behavior. (Bug#8761)
5029 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5030 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5031 xfree instead of the default malloc, realloc, free.
5032 (Fgnutls_boot): No need to check for memory allocation failure,
5033 since xmalloc does that for us.
5034
ac32cd99 5035 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5036 * category.c (hash_get_category_set):
5037 * ccl.c (ccl_driver):
5038 * charset.c (Fdefine_charset_internal):
5039 * charset.h (struct charset.hash_index):
5040 * composite.c (get_composition_id, gstring_lookup_cache)
5041 (composition_gstring_put_cache):
5042 * composite.h (struct composition.hash_index):
5043 * dispextern.h (struct image.hash):
5044 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5045 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5046 (hashfn_equal, hashfn_user_defined, make_hash_table)
5047 (maybe_resize_hash_table, hash_lookup, hash_put)
5048 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5049 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5050 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5051 * image.c (make_image, search_image_cache, lookup_image)
5052 (xpm_put_color_table_h):
5053 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5054 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5055 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5056 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5057 * alloc.c (allocate_vectorlike):
5058 Check for overflow in vector size calculations.
5059 * ccl.c (ccl_driver):
5060 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5061 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5062 need to be updated by these changes.
40087514
PE
5063 * fns.c (make_hash_table, maybe_resize_hash_table):
5064 Check for integer overflow with large hash tables.
0de4bb68
PE
5065 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5066 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5067 (SXHASH_REDUCE): New macro.
5068 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5069 Use it instead of discarding useful hash info with large hash values.
5070 (sxhash_float): New function.
5071 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5072 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5073 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5074 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5075 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5076 Adjust signatures to match updated version of code.
5077 (consing_since_gc): Now EMACS_INT, since a single hash table can
5078 use more than INT_MAX bytes.
5079
698d32e2
DN
50802011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5081
5082 Make it possible to build with GCC-4.6+ -O2 -flto.
5083
5084 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5085
fd6fa53f
SM
50862011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5087
5088 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5089 Call minibuffer-inactive-mode.
5090
864db017
JB
50912011-05-31 Juanma Barranquero <lekktu@gmail.com>
5092
5093 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5094 Update dependencies.
5095
2ad0baf4
DN
50962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5097
5098 * data.c (init_data): Remove code for UTS, this system is not
5099 supported anymore.
5100
4fcc2638
DN
51012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5102
5103 Don't force ./temacs to start in terminal mode.
5104
5105 * frame.c (make_initial_frame): Initialize faces in all cases, not
5106 only when CANNOT_DUMP is defined.
5107 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5108
c56e0fd5
DN
51092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5110
5111 * dispnew.c (add_window_display_history): Use const for the string
5112 pointer. Remove declaration, not needed.
5113
333d54da 51142011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5115
55d4c1b2 5116 Use 'inline', not 'INLINE'.
333d54da 5117 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5118 * alloc.c, fontset.c (INLINE): Remove.
5119 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5120 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5121 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5122 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5123 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5124
738db178
DN
51252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5126
5127 Make it possible to run ./temacs.
5128
5129 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5130 syms_of_callproc does the same thing. Remove test for
5131 "initialized", do it in the caller.
5132 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5133
620c53a6
SM
51342011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5135
5136 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5137 (read_minibuf): Use get_minibuffer.
5138 (syms_of_minibuf): Use DEFSYM.
5139 (Qmetadata): New var.
5140 * data.c (Qbuffer): Don't make it static.
5141 (syms_of_data): Use DEFSYM.
5142
e003a292
PE
51432011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5144
5145 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5146 (CCL_CODE_MIN): New macro.
5147
ed008a6d
PE
51482011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5149
3687c2ef
PE
5150 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5151
ed008a6d
PE
5152 * eval.c (Qdebug): Now static.
5153 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5154 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5155 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5156
d66c4c7c
CY
51572011-05-29 Chong Yidong <cyd@stupidchicken.com>
5158
5159 * image.c: Various fixes to ImageMagick code comments.
5160 (Fimagemagick_types): Doc fix.
5161
5fbc2025
PE
51622011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5163
0196f88a
PE
5164 Minor fixes prompted by GCC 4.6.0 warnings.
5165
5166 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5167
5fbc2025
PE
5168 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5169 (x_clipboard_manager_save_all): Move extern decl to ...
5170 * xterm.h: ... here, so that it can be checked for consistency.
5171
1dd3c2d9
CY
51722011-05-29 Chong Yidong <cyd@stupidchicken.com>
5173
5174 * xselect.c (x_clipboard_manager_save_frame)
5175 (x_clipboard_manager_save_all): New functions.
5176 (Fx_clipboard_manager_save): Lisp function deleted.
5177
5178 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5179 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5180
5181 * xterm.h: Update prototype.
5182
5ba6571d
WX
51832011-05-28 William Xu <william.xwl@gmail.com>
5184
5185 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5186 exiting (Bug#8239).
5187
3eaff834
JM
51882011-05-28 Jim Meyering <meyering@redhat.com>
5189
e1900994 5190 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5191 * fns.c (to_uchar): Define.
5192 (crypto_hash_function): Use it to convert some newly-signed
5193 variables to unsigned, to avoid sign-extension bugs. For example,
5194 without this change, (md5 "truc") would evaluate to
5195 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5196 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5197 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5198
0f6990a7
PE
51992011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5200
5201 Integer overflow fixes.
c8a9ca5a 5202
08686060
PE
5203 * dbusbind.c: Serial number integer overflow fixes.
5204 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5205 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5206 to hold a serial number that is too large for a fixnum.
5207 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5208 Check for serial numbers out of range. Decode any serial number
59568bf0 5209 that was so large that it became a float. (Bug#8722)
08686060 5210
2d1fc3c7
PE
5211 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5212 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5213 Use XFASTINT rather than XUINT when numbers are nonnegative.
5214 (xd_append_arg, Fdbus_method_return_internal):
5215 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5216 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5217 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5218 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5219 (Bug#8722)
2d1fc3c7 5220
c8a9ca5a
PE
5221 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5222
519e1d69
PE
5223 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5224
30569699
PE
5225 ccl: add integer overflow checks
5226 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5227 (IN_INT_RANGE): New macros.
5228 (ccl_driver): Use them to check for integer overflow when
5229 decoding a CCL program. Many of the new checks are whether XINT (x)
5230 fits in int; it doesn't always, on 64-bit hosts. The new version
5231 doesn't catch all possible integer overflows, but it's an
847044ea 5232 improvement. (Bug#8719)
30569699 5233
c11285dc
PE
5234 * alloc.c (make_event_array): Use XINT, not XUINT.
5235 There's no need for unsigned here.
5236
fdccd48e
PE
5237 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5238 This follows up to the 2011-05-06 change that substituted uintptr_t
5239 for EMACS_INT. This case wasn't caught back then.
5240
37910ab2
PE
5241 Rework Fformat to avoid integer overflow issues.
5242 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5243 now (part of C89). Include <verify.h>.
5244 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5245 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5246 (Fformat): Avoid the prepass trying to compute sizes; it was only
5247 approximate and thus did not catch overflow reliably. Instead, walk
5248 through the format just once, formatting and computing sizes as we go,
5249 checking for integer overflow at every step, and allocating a larger
5250 buffer as needed. Keep track separately whether the format is
5251 multibyte. Keep only the most-recently calculated precision, rather
5252 than them all. Record whether each argument has been converted to
5253 string. Use EMACS_INT, not int, for byte and char and arg counts.
5254 Support field widths and precisions larger than INT_MAX. Avoid
5255 sprintf's undefined behavior with conversion specifications such as %#d
5256 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5257 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5258 formatting out-of-range floating point numbers with int
9173deec 5259 formats. (Bug#8668)
37910ab2 5260
2e6578fb
PE
5261 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5262
0ae6bdee
PE
5263 * data.c: Avoid integer truncation in expressions involving floats.
5264 * data.c: Include <intprops.h>.
5265 (arith_driver): When there's an integer overflow in an expression
5266 involving floating point, convert the integers to floating point
5267 so that the resulting value does not suffer from catastrophic
5268 integer truncation. For example, on a 64-bit host (* 4
5269 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5270 Do not rely on undefined behavior after integer overflow.
5271
de883a70
PE
5272 merge count_size_as_multibyte, parse_str_to_multibyte
5273 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5274 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5275 Check for integer overflow.
5276 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5277 since it's now a duplicate of the other. This is more of
5278 a character than a buffer op, so better that it's in character.c.
5279 * fns.c, print.c: Adjust to above changes.
5280
2ff916cb
PE
52812011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5282
5283 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5284
f1b54466
PE
52852011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5286
fb1ac845
PE
5287 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5288 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5289 (x_clipboard_manager_save): Now static.
5290 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5291
f1b54466
PE
5292 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5293 (crypto_hash_function): Now static.
5294 Fix pointer signedness problems. Avoid unnecessary initializations.
5295
a9f737ee
CY
52962011-05-27 Chong Yidong <cyd@stupidchicken.com>
5297
5298 * termhooks.h (Vselection_alist): Make it terminal-local.
5299
5300 * terminal.c (create_terminal): Initialize it.
5301
5302 * xselect.c: Support for clipboard managers.
5303 (Vselection_alist): Move to termhooks.h as terminal-local var.
5304 (LOCAL_SELECTION): New macro.
5305 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5306 (symbol_to_x_atom): Remove gratuitous arg.
5307 (x_handle_selection_request, lisp_data_to_selection_data)
5308 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5309 (x_own_selection, x_get_local_selection, x_convert_selection):
5310 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5311 (some_frame_on_display): Delete unused function.
5312 (Fx_own_selection_internal, Fx_get_selection_internal)
5313 (Fx_disown_selection_internal, Fx_selection_owner_p)
5314 (Fx_selection_exists_p): New optional frame arg.
5315 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5316 (x_handle_selection_clear): Don't treat other terminals with the
5317 same keyboard specially. Use the terminal-local Vselection_alist.
5318 (x_clear_frame_selections): Use Frun_hook_with_args.
5319
5320 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5321
5322 * xterm.h: Add support for those atoms.
5323
e067f0c1
CY
53242011-05-26 Chong Yidong <cyd@stupidchicken.com>
5325
5326 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5327 (converted_selections, conversion_fail_tag): New global variables.
5328 (x_selection_request_lisp_error): Free the above.
5329 (x_get_local_selection): Remove unnecessary code.
5330 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5331 of converted selections stored in converted_selections.
5332 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5333 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5334 (x_convert_selection): New function.
5335 (x_handle_selection_event): Simplify.
5336 (x_get_foreign_selection): Don't ignore incoming requests while
5337 waiting for an answer; this will fail when we implement
5338 SAVE_TARGETS, and seems unnecessary anyway.
5339 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5340 (Vx_sent_selection_functions): Doc fix.
5341
0f4aebc0
LL
53422011-05-26 Leo Liu <sdl.web@gmail.com>
5343
5344 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5345
e61124cd
YM
53462011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5347
5348 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5349
5350 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5351 for fringe update if it has periodic bitmap.
ac389d0c 5352 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5353 and fringe_bitmap_periodic_p.
5354
5355 * fringe.c (get_fringe_bitmap_data): New function.
5356 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5357 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5358 row. Mark glyph row for fringe update if periodicity changed.
5359
5360 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5361 for fringe update unless it has periodic bitmap.
5362
f16d9837
KH
53632011-05-25 Kenichi Handa <handa@m17n.org>
5364
5365 * xdisp.c (get_next_display_element): Set correct it->face_id for
5366 a static composition.
5367
e1b90ef6
LL
53682011-05-24 Leo Liu <sdl.web@gmail.com>
5369
5370 * deps.mk (fns.o):
5371 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5372
5373 * fns.c (crypto_hash_function, Fsha1): New function.
5374 (Fmd5): Use crypto_hash_function.
5375 (syms_of_fns): Add Ssha1.
5376
7400048f
PE
53772011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5378
5379 * gnutls.c: Remove unused macros.
5380 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5381 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5382 Remove macros that are defined and never used.
5383 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5384
abb71cf4
CY
53852011-05-22 Chong Yidong <cyd@stupidchicken.com>
5386
5387 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5388 (Fx_get_selection_internal): Minor cleanup.
5389 (Fx_own_selection_internal): Rename arguments for consistency with
5390 select.el.
5391
6307db39
PE
53922011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5393
5394 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5395
f3d4e0a4
CY
53962011-05-22 Chong Yidong <cyd@stupidchicken.com>
5397
5398 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5399
4d8ade89
YM
54002011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5401
5402 * dispnew.c (scrolling_window): Don't exclude the case that the
5403 last enabled row in the desired matrix touches the bottom boundary.
5404
32078c8d
GM
54052011-05-21 Glenn Morris <rgm@gnu.org>
5406
5407 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5408 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5409 and add some more files.
32078c8d 5410
7285dc67
EZ
54112011-05-20 Eli Zaretskii <eliz@gnu.org>
5412
5413 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5414 report_file_error introduced by the change from 2011-05-07.
5415
89d1bd22
PE
54162011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5417
5418 * systime.h (Time): Define only if emacs is defined.
5419 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5420 where the include path doesn't have X11/X.h by default. See
5421 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5422
e23640bb 54232011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5424
5425 * composite.c (find_automatic_composition): Fix previous change.
5426
b9704ad9
GM
54272011-05-20 Glenn Morris <rgm@gnu.org>
5428
5429 * lisp.mk: New file, split from Makefile.in.
5430 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5431 (shortlisp): Remove.
5432 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5433
4a720484
GM
54342011-05-19 Glenn Morris <rgm@gnu.org>
5435
5436 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5437 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5438 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5439 (lisp): Set the order to that of loadup.el.
5440 (shortlisp): Make it a copy of $lisp.
5441 (SOME_MACHINE_LISP): Remove.
5442 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5443 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5444
a28d4396
KH
54452011-05-18 Kenichi Handa <handa@m17n.org>
5446
5447 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5448 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5449 (find_automatic_composition): Mostly rewrite for efficiency.
5450
a2b1fa8e
JB
54512011-05-18 Juanma Barranquero <lekktu@gmail.com>
5452
5453 * makefile.w32-in: Update dependencies.
5454
8e1f5610
CS
54552011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5456
5457 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5458 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5459
7025ee00 54602011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5461
cdfa6eab
PE
5462 Fix some integer overflow issues, such as string length overflow.
5463
06d6db33
PE
5464 * insdel.c (count_size_as_multibyte): Check for string overflow.
5465
2b4560a8
PE
5466 * character.c (lisp_string_width): Check for string overflow.
5467 Use EMACS_INT, not int, for string indexes and lengths; in
5468 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5469 the resulting string length overflows an EMACS_INT; instead,
5470 report a string overflow if no precision given. When checking for
5471 precision exhaustion, use a check that cannot possibly have
5472 integer overflow. (Bug#8675)
5473 * character.h (lisp_string_width): Adjust to new signature.
5474
cb93f9be
PE
5475 * alloc.c (string_overflow): New function.
5476 (Fmake_string): Use it. This doesn't change behavior, but saves
5477 a few bytes and will simplify future changes.
5478 * character.c (string_escape_byte8): Likewise.
5479 * lisp.h (string_overflow): New decl.
5480
1a1f3366
PE
5481 Fixups, following up to the user-interface timestamp change.
5482 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5483 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5484 * msdos.c (mouse_get_pos): Likewise.
5485 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5486 * w32gui.h (Time): Define by including "systime.h" rather than by
5487 declaring it ourselves. (Bug#8664)
5488
d4e3e4d3
PE
5489 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5490 * image.c (clear_image_cache): Likewise.
5491
f6a24d19
PE
5492 * term.c (term_mouse_position): Don't assume time_t wraparound.
5493
08dc5ae6
PE
5494 Be more systematic about user-interface timestamps.
5495 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5496 and sometimes 'EMACS_UINT', to represent these timestamps.
5497 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5498 This makes the code easier to follow, and makes it easier to catch
5499 integer overflow bugs such as Bug#8664.
5500 * frame.c (Fmouse_position, Fmouse_pixel_position):
5501 Use Time, not unsigned long, for user-interface timestamps.
5502 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5503 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5504 * keyboard.h (last_event_timestamp): Likewise.
5505 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5506 * menu.h (xmenu_show): Likewise.
5507 * term.c (term_mouse_position): Likewise.
5508 * termhooks.h (struct input_event.timestamp): Likewise.
5509 (struct terminal.mouse_position_hook): Likewise.
5510 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5511 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5512 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5513 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5514 what it was before.
5515 * menu.h, termhooks.h: Include "systime.h", for Time.
5516
8e55734a
PE
5517 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5518 Don't assume that the difference between two unsigned long values
5519 can fit into an integer. At this point, we know button_down_time
5520 <= event->timestamp, so the difference must be nonnegative, so
5521 there's no need to cast the result if double-click-time is
5522 nonnegative, as it should be; check that it's nonnegative, just in
5523 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5524 apart (about 25 days). (Bug#8664)
8e55734a 5525
841f1b75 5526 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5527 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5528
3e26f69c
PE
5529 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5530 that always fit in int. Use a sentinel instead of a counter, to
5531 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5532 * frame.h (struct frame): Use int for menu_bar_items_used
5533 instead of EMACS_INT, since it always fits in int.
3e26f69c 5534
5cc152c0
PE
5535 * menu.c (grow_menu_items): Check for int overflow.
5536
d89eb65e
PE
5537 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5538
5235bd3e
PE
5539 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5540 Before, the code was not consistent. These values cannot exceed
5541 2**31 - 1 so there's no need to make them unsigned.
5542 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5543 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5544 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5545 as modifiers.
5546 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5547
bc827e23
PE
5548 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5549 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5550 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5551 presumably because the widths might not match.
5552
78eb494e
PE
5553 * window.c (size_window): Avoid needless test at loop start.
5554
04f2d78b
CB
55552011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5556
5557 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5558
d2fc7e3d 55592011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5560
5561 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5562
d2fc7e3d 55632011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5564
5565 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5566 `width' to `bar_area_x' and `bar_area_width', respectively.
5567 (x_scroll_run): Take account of fringe background extension.
5568
04f2d78b
CB
5569 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5570 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5571 `bar_area_width', respectively.
5572 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5573 background extension.
5574
79b70037
GM
55752011-05-10 Jim Meyering <meyering@redhat.com>
5576
5577 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5578
2f142cc5
JB
55792011-05-10 Juanma Barranquero <lekktu@gmail.com>
5580
5581 * image.c (Finit_image_library): Return t for built-in image types,
5582 like pbm and xbm. (Bug#8640)
5583
57679c86
AS
55842011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5585
5586 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5587
888c9e86
EZ
55882011-05-07 Eli Zaretskii <eliz@gnu.org>
5589
b0512a1d
EZ
5590 * w32console.c (Fset_screen_color): Doc fix.
5591 (Fget_screen_color): New function.
5592 (syms_of_ntterm): Defsubr it.
5593
7285dc67
EZ
5594 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5595 unlink the temporary file if Fcall_process didn't create it in the
5596 first place.
5597 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5598 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5599 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5600 cue to call_process_cleanup not to close that handle.
5601
4d3fcc8e
BK
56022011-05-07 Ben Key <bkey76@gmail.com>
5603
5604 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5605 one of two shell specific rules, either bootstrap-temacs-CMD or
5606 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5607 to the previous implementation of the bootstrap-temacs rule.
5608 The bootstrap-temacs-CMD rule is similar to the previous
5609 implementation of the bootstrap-temacs rule except that it
5610 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5611 variable.
5612
5613 These changes, along with some changes to nt/configure.bat,
5614 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5615 earlier fix to add support for --cflags and --ldflags options
5616 that include quotes so that it works whether make uses cmd or
5617 sh as the shell.
5618
b4289b64
MA
56192011-05-06 Michael Albinus <michael.albinus@gmx.de>
5620
5621 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5622 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5623 is a constant.
5624 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5625 a string. Handle both cases.
5626 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5627 (Fdbus_register_method): Use Qinvalid_function.
5628
af4c0e28
JB
56292011-05-06 Juanma Barranquero <lekktu@gmail.com>
5630
5631 * makefile.w32-in: Update dependencies.
5632 (LISP_H): Add inttypes.h and stdin.h.
5633 (PROCESS_H): Add unistd.h.
5634
c51453d9
EZ
56352011-05-06 Eli Zaretskii <eliz@gnu.org>
5636
5637 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5638 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5639
8ff0ac3c 56402011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5641
4c4b566b
PE
5642 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5643
aab2b9b5
PE
5644 * term.c (vfatal): Remove stray call to va_end.
5645 It's not needed and the C Standard doesn't allow it here anyway.
5646
c378da0b
PE
5647 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5648 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5649
288b08c7
PE
5650 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5651 bytes.
5652
e3601888
PE
5653 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5654
db6c0e74
PE
5655 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5656
dd5963ea
PE
5657 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5658
88c9450f
PE
5659 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5660
2f9442b8
PE
5661 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5662
c032b5f8
PE
5663 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5664 * charset.c (Fdefine_charset_internal): Don't initialize
5665 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5666 32-bit int (Bug#8600).
a108c10b
PE
5667
5668 * lread.c (read_integer): Be more consistent with string-to-number.
5669 Use string_to_number to do the actual conversion; this avoids
5670 rounding errors and fixes some other screwups. Without this fix,
5671 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5672 (digit_to_number): Move earlier, for benefit of read_integer.
5673 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5674 not a digit in any supported base. (Bug#8602)
a108c10b 5675
ad5f9eea
PE
5676 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5677
aec1708a
PE
5678 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5679 to match comment at start of function. This also removes a
5680 GCC warning about overflow in a 32+64-bit port.
5681
47be4ab5
PE
5682 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5683
371cac43
PE
5684 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5685 Reported by Stefan Monnier in
5686 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5687 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5688 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5689
d01a7826
PE
5690 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5691 (EMACS_UINTPTR): Likewise, with uintptr_t.
5692
7fd47d5c
PE
5693 * lisp.h: Prefer 64-bit EMACS_INT if available.
5694 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5695 on 32-bit hosts that have 64-bit int, so that they can access
5696 large files.
122b0c86
PE
5697 However, temporarily disable this change unless the temporary
5698 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5699
8727937b
PE
5700 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5701
8ac068ac
PE
5702 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5703 This removes an assumption that EMACS_INT and long are the same
5704 width as pointers. The assumption is true for Emacs porting targets
5705 now, but we want to make other targets possible.
5706 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5707 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5708 In the rest of the code, change types of integers that hold casted
5709 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5710 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5711 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5712 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5713 No need to cast type when ORing.
5714 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5715 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5716 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5717 assume EMACS_INT is the same width as char *.
5718 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5719 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5720 Remove no-longer-needed casts.
5721 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5722 (xg_tool_bar_help_callback, xg_make_tool_item):
5723 Use EMACS_INTPTR to hold an integer
5724 that will be cast to void *; this can avoid a GCC warning
5725 if EMACS_INT is not the same width as void *.
5726 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5727 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5728 (current_message_1, set_message_1):
5729 Use a local to convert to proper width without a cast.
5730 * xmenu.c (dialog_selection_callback): Likewise.
5731
ede49d71
PE
5732 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5733 Also, don't assume VALBITS / RAND_BITS is less than 5,
5734 and don't rely on undefined behavior when shifting a 1 left into
5735 the sign bit.
5736 * lisp.h (get_random): Change signature to match.
5737
2f30ecd0
PE
5738 * lread.c (hash_string): Use size_t, not int, for hash computation.
5739 Normally we prefer signed values; but hashing is special, because
5740 it's better to use unsigned division on hash table sizes so that
5741 the remainder is nonnegative. Also, size_t is the natural width
5742 for hashing into memory. The previous code used 'int', which doesn't
5743 retain enough info to hash well into very large tables.
5744 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5745
2a866e7b
PE
5746 * dbusbind.c: Don't possibly lose pointer info when converting.
5747 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5748 Use XPNTR rather than XHASH, so that the high-order bits of
5749 the pointer aren't lost when converting through void *.
5750
51639eac
PE
5751 * eval.c (Fautoload): Don't double-shift a pointer.
5752
92394119
PE
5753 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5754
dbdb9a7c
JB
57552011-05-06 Juanma Barranquero <lekktu@gmail.com>
5756
5757 * gnutls.c (DEF_GNUTLS_FN):
5758 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5759
db7a0b4f
AS
57602011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5761
5762 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5763 marker. (Bug#8610)
5764
f7ff1b0f 57652011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5766
5767 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5768 New version that can reserve upto 2GB of heap space.
5769
f7ff1b0f 57702011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5771
5772 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5773
639c109b
TZ
57742011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5775
5776 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5777 `gnutls_certificate_set_x509_key_file'.
5778
d2127135
JB
57792011-05-05 Juanma Barranquero <lekktu@gmail.com>
5780
5781 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5782 Update dependencies.
5783
e968f4f3
JB
57842011-05-04 Juanma Barranquero <lekktu@gmail.com>
5785
5786 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5787 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5788 Remove unused parameter `fildes'.
5789 * process.c (read_process_output, send_process): Don't pass it.
5790
84d358f0
JB
57912011-05-04 Juanma Barranquero <lekktu@gmail.com>
5792
5793 Fix previous change: the library cache is defined in w32.c.
5794 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5795 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5796
0898ca10
JB
57972011-05-04 Juanma Barranquero <lekktu@gmail.com>
5798
5799 Implement dynamic loading of GnuTLS on Windows.
5800
5801 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5802 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5803 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5804 Declare.
5805
5806 * gnutls.c (Qgnutls_dll): Define.
5807 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5808 (gnutls_*): Declare function pointers.
5809 (init_gnutls_functions): New function to initialize function pointers.
5810 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5811 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5812 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5813 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5814 (emacs_gnutls_write, emacs_gnutls_read)
5815 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5816 (Fgnutls_available_p): New function.
5817 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5818 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5819 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5820
5821 * image.c: Include w32.h.
5822 (Vimage_type_cache): Delete.
5823 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5824 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5825 (w32_delayed_load): Move to w32.c.
5826
5827 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5828
5829 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5830 (w32_delayed_load): Move from image.c. When loading a library, record
5831 its filename in the :loaded-from property of the library id.
5832 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5833 Initialize and staticpro them.
5834 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5835
5836 * process.c: Include lisp.h before w32.h, not after.
5837 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5838 instead of gnutls_record_check_pending.
5839
5840 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5841
ff4de4aa
TZ
58422011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5843
5844 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5845 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5846 as passed in.
5847
abe95abb
JD
58482011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5849
5850 * xterm.c (x_set_frame_alpha): Do not set property on anything
5851 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5852
e16e55d4
JB
58532011-05-02 Juanma Barranquero <lekktu@gmail.com>
5854
5855 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5856
bafcf6a5
JB
58572011-05-02 Juanma Barranquero <lekktu@gmail.com>
5858
5859 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5860 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5861 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5862 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5863 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5864 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5865 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5866 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5867 (Qgnutls_bootprop_callbacks_verify): Make static.
5868
e7a6747f
AS
58692011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5870
19ed11ba
AS
5871 * callproc.c: Indentation fixup.
5872
e7a6747f 5873 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5874 (wait_for_termination, interruptible_wait_for_termination):
5875 Move after wait_for_termination_1.
e7a6747f 5876
1ef14cb4
LMI
58772011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5878
5879 * sysdep.c (interruptible_wait_for_termination): New function
5880 which is like wait_for_termination, but allows keyboard
5881 interruptions.
5882
5883 * callproc.c (Fcall_process): Add (:file "file") as an option for
5884 the STDOUT buffer.
5885 (Fcall_process_region): Ditto.
5886
330d880c
EZ
58872011-04-30 Eli Zaretskii <eliz@gnu.org>
5888
8db90b73
EZ
5889 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5890 rather than `XVECTOR (FOO)->size'.
5891
330d880c
EZ
5892 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5893 inttypes.h, as a gnulib replacement is used if it not available in
5894 system headers.
5895
15cbd324
EZ
58962011-04-21 Eli Zaretskii <eliz@gnu.org>
5897
5898 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5899 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5900 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5901
5902 * coding.c (coding_alloc_by_realloc): Error out if destination
5903 will grow beyond MOST_POSITIVE_FIXNUM.
5904 (decode_coding_emacs_mule): Abort if there isn't enough place in
5905 charbuf for the composition carryover bytes. Reserve an extra
5906 space for up to 2 characters produced in a loop.
5907 (decode_coding_iso_2022): Abort if there isn't enough place in
5908 charbuf for the composition carryover bytes.
5909
59102011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5911
ae940cca
EZ
5912 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5913 aborting when %lld or %lll format is passed.
5914 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5915 %llo or %llx format is passed. (Bug#8545)
5916
03ab8921
EZ
5917 * window.c (window_scroll_line_based): Use a marker instead of
5918 simple variables to record original value of point. (Bug#7952)
5919
afda1437
EZ
5920 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5921 produced by %s or %c overflows available buffer space. (Bug#8545)
5922
f76dee0c
PE
59232011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5924
5925 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5926 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5927
fdc5744d
JB
59282011-04-28 Juanma Barranquero <lekktu@gmail.com>
5929
5930 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5931
638f053a
JB
59322011-04-28 Juanma Barranquero <lekktu@gmail.com>
5933
5934 * keyboard.c (Qdelayed_warnings_hook): Define.
5935 (command_loop_1): Run `delayed-warnings-hook'
5936 if Vdelayed_warnings_list is non-nil.
5937 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5938 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5939
d178f871
EZ
59402011-04-28 Eli Zaretskii <eliz@gnu.org>
5941
5942 * doprnt.c (doprnt): Don't return value smaller than the buffer
5943 size if the message was truncated. (Bug#8545).
5944
b124fd93
JB
59452011-04-28 Juanma Barranquero <lekktu@gmail.com>
5946
5947 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5948 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5949
e810457d
PE
59502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5951
5952 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5953
ea51cceb
JB
59542011-04-27 Juanma Barranquero <lekktu@gmail.com>
5955
5956 * makefile.w32-in: Update dependencies.
5957
94dcfacf
EZ
59582011-04-27 Eli Zaretskii <eliz@gnu.org>
5959
5960 Improve `doprnt' and its usage. (Bug#8545)
5961 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5962 `format_end'. Remove support for %l as a conversion specifier.
5963 Don't use xrealloc. Improve diagnostics when the %l size modifier
5964 is used. Update the commentary.
5965
5966 * eval.c (verror): Simplify calculation of size_t.
5967
5968 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5969 messages.
5970
f61f41d7
PE
59712011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5972
5973 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5974 change.
5975
96fb4434
PE
59762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5977
5978 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5979 This makes this file independent of the recent pseudovector change.
5980
671875da 59812011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5982
69e9b5a3
PE
5983 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5984
b5f869a7 5985 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5986 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5987 Remove unused local.
c8926152 5988 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5989
841a1577 5990 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5991 GCC 4.6.0 optimizes based on type-based alias analysis.
5992 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5993 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5994 != &v->size, and therefore "v->size = 1; b->size = 2; return
5995 v->size;" must therefore return 1. This assumption is incorrect
5996 for Emacs, since it type-puns struct Lisp_Vector * with many other
5997 types. To fix this problem, this patch adds a new type struct
f904488f 5998 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5999 and pseudovectors, and helps optimizing compilers not get fooled
6000 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6001 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6002 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6003 the size member.
eab3844f
PE
6004 (XSETPVECTYPE): Rewrite in terms of new macro.
6005 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6006 This is a bit clearer, and further avoids the possibility of
6007 undesirable aliasing.
6008 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6009 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6010 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6011 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6012 (ASIZE): Now uses header.size rather than size.
6013 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6014 to avoid the hassle of writing XVECTOR (foo)->header.size.
6015 (struct vectorlike_header): New type.
eab3844f
PE
6016 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6017 object, to help avoid aliasing.
6018 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6019 (SUBRP): Likewise, since Lisp_Subr is a special case.
6020 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6021 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6022 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6023 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6024 changed to be "header.size" and "header.next".
6025 * buffer.h (struct buffer): Likewise.
6026 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6027 * frame.h (struct frame): Likewise.
6028 * process.h (struct Lisp_Process): Likewise.
6029 * termhooks.h (struct terminal): Likewise.
6030 * window.c (struct save_window_data, struct saved_window): Likewise.
6031 * window.h (struct window): Likewise.
6032 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6033 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6034 * buffer.c (init_buffer_once): Likewise.
6035 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6036 special case.
6037 * process.c (Fformat_network_address): Use local var for size,
6038 for brevity.
6039
0df1eac5
PE
6040 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6041
847ab9d1 6042 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6043 * data.c (atof): Remove decl; no longer used or needed.
6044 (digit_to_number): Move to lread.c.
6045 (Fstring_to_number): Use new string_to_number function, to be
6046 consistent with how the Lisp reader treats infinities and NaNs.
6047 Do not assume that floating-point numbers represent EMACS_INT
6048 without losing information; this is not true on most 64-bit hosts.
6049 Avoid double-rounding errors, by insisting on integers when
6050 parsing non-base-10 numbers, as the documentation specifies.
6051 * lisp.h (string_to_number): New decl, replacing ...
6052 (isfloat_string): Remove.
bc0a5c13 6053 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6054 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6055 appears to have been a coding error. Similarly, do not accept
6056 strings like +-1e0 as floating point numbers. Do not report
6057 overflow for integer overflows unless the base is not 10 which
6058 means we have no simple and reliable way to continue.
6059 Break out the floating-point parsing into a new
6060 function string_to_number, so that Fstring_to_number parses
6061 floating point numbers consistently with the Lisp reader.
04f2d78b 6062 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6063 (E_CHAR, EXP_INT): Remove, replacing with ...
6064 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6065 (string_to_number): New function, replacing isfloat_string.
6066 This function checks for valid syntax and produces the resulting
6067 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6068 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6069 so that overflow for non-base-10 numbers is reported only when
6070 there's no portable and simple way to convert to floating point.
452f4150 6071
67769ffc
PE
6072 * textprop.c (set_text_properties_1): Rewrite for clarity,
6073 and to avoid GCC warning about integer overflow.
6074
c20db43f
PE
6075 * intervals.h (struct interval): Use EMACS_INT for members
6076 where EMACS_UINT might cause problems. See
6077 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6078 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6079 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6080 All uses changed.
37aa2f85
PE
6081 (offset_intervals): Tell GCC not to worry about length overflow
6082 when negating a negative length.
c20db43f 6083
2538aa2f
PE
6084 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6085 (overrun_check_free): Likewise.
6086
f2d3008d
PE
6087 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6088 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6089 word size.
6090
ec8df744
PE
6091 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6092 (gnutls_make_error): Rename local to avoid shadowing.
6093 (gnutls_emacs_global_deinit): ifdef out; not used.
6094 (Fgnutls_boot): Use const for pointer to readonly storage.
6095 Comment out unused local. Fix pointer signedness problems.
6096
640ee02d
PE
6097 * lread.c (openp): Don't stuff size_t into an 'int'.
6098 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6099 about possible signed overflow.
6100
6048fb2a
PE
6101 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6102 (GDK_KEY_g): Don't define if already defined.
6103 (xg_prepare_tooltip): Avoid pointer signedness problem.
6104 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6105
fa3c87e1
PE
6106 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6107 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6108
2172544b
PE
6109 * xfns.c (Fx_window_property): Simplify a bit,
6110 to make a bit faster and to avoid GCC 4.6.0 warning.
6111 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6112
9b821a21
PE
6113 * fns.c (internal_equal): Don't assume size_t fits in int.
6114
3c616cfa
PE
6115 * alloc.c (compact_small_strings): Tighten assertion a little.
6116
c2982e87
PE
6117 Replace pEd with more-general pI, and fix some printf arg casts.
6118 * lisp.h (pI): New macro, generalizing old pEd macro to other
6119 conversion specifiers. For example, use "...%"pI"d..." rather
6120 than "...%"pEd"...".
6121 (pEd): Remove. All uses replaced with similar uses of pI.
6122 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6123 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6124 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6125 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6126 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6127 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6128 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6129 64-bit hosts.
6130 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6131 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6132 * print.c (safe_debug_print, print_object): Likewise.
6133 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6134 to int.
6f04d126
PE
6135 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6136 avoiding the 0 flag, which is not portable.
c2982e87
PE
6137 * process.c (Fmake_network_process): Use pI to avoid cast.
6138 * region-cache.c (pp_cache): Likewise.
6139 * xdisp.c (decode_mode_spec): Likewise.
6140 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6141 behavior on 64-bit hosts with printf arg.
6f04d126 6142 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6143 (x_stop_queuing_selection_requests): Likewise.
6144 (x_get_window_property): Don't truncate byte count to an 'int'
6145 when tracing.
0b432f21 6146
5e073ec7
PE
6147 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6148 here, since it parses constructs like leading '-' and spaces,
6149 which are not wanted; and it overflows with large numbers.
6150 Instead, simply match F[0-9]+, which is what is wanted anyway.
6151
36372bf9
PE
6152 * alloc.c: Remove unportable assumptions about struct layout.
6153 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6154 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6155 (allocate_vectorlike, make_pure_vector): Use the new macros,
6156 plus offsetof, to remove unportable assumptions about struct layout.
6157 These assumptions hold on all porting targets that I know of, but
6158 they are not guaranteed, they're easy to remove, and removing them
6159 makes further changes easier.
6160
0b432f21
PE
6161 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6162 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6163 (string_overrun_cookie): Now const. Use initializers that
6164 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6165 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6166 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6167 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6168 multiple of sizeof (EMACS_INT); it need not be, if
6169 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6170 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6171
895009e1
JB
61722011-04-26 Juanma Barranquero <lekktu@gmail.com>
6173
6174 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6175
6a7a1b0b
TZ
61762011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6177
6178 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6179 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6180 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6181
841a1577 61822011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6183
6184 * lisp.h (Qdebug): List symbol.
895009e1 6185 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6186 * keyboard.c (debug-on-event): New variable.
6187 (handle_user_signal): Break into debugger when debug-on-event
6188 matches the current signal symbol.
6189
f2d3ba6f
DN
61902011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6191
6192 * alloc.c (check_sblock, check_string_bytes)
6193 (check_string_free_list): Convert to standard C.
6194
42ce4c63
TZ
61952011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6196
6197 * w32.c (emacs_gnutls_push): Fix typo.
6198
825cd63c
EZ
61992011-04-25 Eli Zaretskii <eliz@gnu.org>
6200
fb11d64d
EZ
6201 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6202 "cast to pointer from integer of different size".
6203
825cd63c
EZ
6204 Improve doprnt and its use in verror. (Bug#8545)
6205 * doprnt.c (doprnt): Document the set of format control sequences
6206 supported by the function. Use SAFE_ALLOCA instead of always
6207 using `alloca'.
6208
6209 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6210 is one byte too soon. Don't use xrealloc; instead xfree and
6211 xmalloc anew.
6212
e061a11b
TZ
62132011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6214
6215 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6216 callbacks stage.
6217
6218 * gnutls.c: Renamed global_initialized to
6219 gnutls_global_initialized. Added internals for the
6220 :verify-hostname-error, :verify-error, and :verify-flags
6221 parameters of `gnutls-boot' and documented those parameters in the
6222 docstring. Start callback support.
9173deec
JB
6223 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6224 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6225 on error. Return error code.
e061a11b
TZ
6226 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6227 (emacs_gnutls_read): Likewise.
6228 (Fgnutls_boot): Return handshake error code.
6229 (emacs_gnutls_handle_error): New function.
6230 (wsaerror_to_errno): Likewise.
6231
6232 * w32.h (emacs_gnutls_pull): Add prototype.
6233 (emacs_gnutls_push): Likewise.
6234
6235 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6236 (emacs_gnutls_push): Likewise.
6237
62382011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6239
6240 * process.c (wait_reading_process_output): Check if GnuTLS
6241 buffered some data internally if no FDs are set for TLS
6242 connections.
6243
6244 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6245 (LIBS): Link to USER_LIBS.
6246 ($(BLD)/gnutls.$(0)): New target.
6247
fa6996bc
EZ
62482011-04-24 Eli Zaretskii <eliz@gnu.org>
6249
eb35682e
EZ
6250 * xdisp.c (handle_single_display_spec): Rename the
6251 display_replaced_before_p argument into display_replaced_p, to
6252 make it consistent with the commentary. Fix typos in the
6253 commentary.
6254
e2ad650c
EZ
6255 * textprop.c (syms_of_textprop): Remove dead code.
6256 (copy_text_properties): Delete obsolete commentary about an
6257 interface that was deleted long ago. Fix typos in the description
6258 of arguments.
6259
1b2de274
EZ
6260 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6261 to changes in oldXMenu/XMenu.h from 2011-04-16.
6262 <menu_help_message, prev_menu_help_message>: Constify.
6263 (IT_menu_make_room): menu->help_text is now `const char **';
6264 adjust.
6265
6266 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6267 to changes in oldXMenu/XMenu.h from 2011-04-16.
6268 (struct XMenu): Declare `help_text' `const char **'.
6269
6270 * xfaces.c <Qunspecified>: Make extern again.
6271
6272 * syntax.c: Include sys/types.h before including regex.h, as
6273 required by Posix.
6274
762b15be
EZ
6275 * doc.c (get_doc_string): Improve the format passed to `error'.
6276
6277 * doprnt.c (doprnt): Improve commentary.
6278
6279 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6280
6281 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6282 them with etags.
6283
f1052e5d
EZ
6284 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6285 changes in globals.h immediately force recompilation.
762b15be
EZ
6286 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6287 $(CURDIR)/s/ms-w32.h.
6288 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6289
fa6996bc
EZ
6290 * character.c (Fchar_direction): Function deleted.
6291 (syms_of_character): Don't defsubr it.
6292 <char-direction-table>: Deleted.
6293
e6c3da20
EZ
62942011-04-23 Eli Zaretskii <eliz@gnu.org>
6295
6296 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6297 * doprnt.c: Include limits.h.
6298 (SIZE_MAX): New macro.
04f2d78b
CB
6299 (doprnt): Return a size_t value. 2nd arg is now size_t.
6300 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6301 Improve overflow protection. Support `l' modifier for integer
6302 conversions. Support %l conversion. Don't assume an EMACS_INT
6303 argument for integer conversions and for %c.
6304
6305 * lisp.h (doprnt): Restore prototype.
6306
6307 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6308 $(SRC)/character.h.
6309
6310 * Makefile.in (base_obj): Add back doprnt.o.
6311
6312 * deps.mk (doprnt.o): Add back prerequisites.
6313 (callint.o): Depend on character.h.
6314
6315 * eval.c (internal_lisp_condition_case): Include the handler
6316 representation in the error message.
6317 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6318 when breaking from the loop.
6319
6320 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6321
6322 * callint.c (Fcall_interactively): When displaying error message
6323 about invalid control letter, pass the character's codepoint, not
6324 a pointer to its multibyte form. Improve display of the character
6325 in octal and display also its hex code.
6326
6327 * character.c (char_string): Use %x to display the (unsigned)
6328 codepoint of an invalid character, to avoid displaying a bogus
6329 negative value.
6330
6331 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6332 `error', not SYMBOL_NAME itself.
6333
6334 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6335 character arguments to `error'.
6336
6337 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6338 to `error' in error message about FINAL_CHAR argument. Make sure
6339 FINAL_CHAR is a character, and use %c when it is passed as
6340 argument to `error'.
6341
4ffd0d6b 63422011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6343
6344 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6345
6346 * w32.c: Include <time.h>.
6347 (sys_localtime): New function.
6348
4ffd0d6b 63492011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6350
6351 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6352
4ffd0d6b 6353 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6354
4ffd0d6b 63552011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6356
4ffd0d6b
GM
6357 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6358 zombies (Bug#8467).
aac0c6e3 6359
04c56954
EZ
63602011-04-19 Eli Zaretskii <eliz@gnu.org>
6361
6362 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6363 gl_state.e_property when gl_state.object is Qt.
6364
6365 * insdel.c (make_gap_larger): Remove limitation of buffer size
6366 to <= INT_MAX.
6367
16a43933
CY
63682011-04-18 Chong Yidong <cyd@stupidchicken.com>
6369
6370 * xdisp.c (lookup_glyphless_char_display)
6371 (produce_glyphless_glyph): Handle cons cell entry in
6372 glyphless-char-display.
6373 (Vglyphless_char_display): Document it.
6374
6375 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6376 glyphless-char-display.
6377
4581706e
CY
63782011-04-17 Chong Yidong <cyd@stupidchicken.com>
6379
6380 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6381
6382 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6383
6384 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6385 definition for no-X builds.
6386
4887c6e2 63872011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6388
fd35b6f9
PE
6389 Static checks with GCC 4.6.0 and non-default toolkits.
6390
5c1ccb01
PE
6391 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6392
006c5daa
PE
6393 * process.c (keyboard_bit_set): Define only if SIGIO.
6394 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6395 (send_process): Repair possible setjmp clobbering.
6396
efc736d3
PE
6397 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6398
4e2fe2e6
PE
6399 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6400
f97334a2
PE
6401 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6402
4e75f29d
PE
6403 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6404 Define only if needed.
6405
90efadd1
PE
6406 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6407 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6408 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6409
3c647824
PE
6410 * dispextern.h (struct redisplay_interface): Rename param
6411 to avoid shadowing.
e264f262 6412 * termhooks.h (struct terminal): Likewise.
761383f4 6413 * xterm.c (xembed_send_message): Likewise.
3c647824 6414
b58c5c4a
PE
6415 * insdel.c (make_gap_smaller): Define only if
6416 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6417
cad59032
PE
6418 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6419 it.
6420
c339dc2e
PE
6421 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6422 so that we aren't warned about unused symbols.
6423
91a3e27b
PE
6424 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6425
399c71d3 6426 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6427
8ffc96f5
PE
6428 * xfns.c (x_real_positions): Mark locals as initialized.
6429
eef9bc79
PE
6430 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6431
098db9dd
PE
6432 * xterm.c: Fix problems found by static analysis with other toolkits.
6433 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6434 (x_dispatch_event): Declare static if USE_GTK, and
6435 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6436 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6437 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6438 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6439 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6440
eb18f6cc
PE
6441 * xmenu.c (menu_help_callback): Pointer type fixes.
6442 Use const pointers when pointing at readonly data. Avoid pointer
6443 signedness clashes.
6444 (FALSE): Remove unused macro.
6445 (update_frame_menubar): Remove unused decl.
6446
1fe72bf8
PE
6447 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6448
60d9e1db
PE
6449 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6450 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6451 (single_menu_item): Rename local to avoid shadowing.
6452
39261c26
PE
6453 * keyboard.c (make_lispy_event): Remove unused local var.
6454
018c5e19
PE
6455 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6456 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6457
63d2b86e
PE
6458 * bitmaps: Change bitmaps from unsigned char back to the X11
6459 compatible char. Avoid the old compiler warnings about
6460 out-of-range initializers by using, for example, '\xab' rather
6461 than 0xab.
6462
aefd87e1
PE
6463 * xgselect.c (xgselect_initialize): Check vs interface
6464 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6465
bf501fb9
PE
6466 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6467
e9829fdf
PE
6468 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6469 to read-only memory.
6470
1086c095
PE
6471 * fns.c (vector): Remove; this old hack is no longer needed.
6472
2baccd04 6473 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6474 Remove unused var.
dde42981 6475 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6476
72391843 6477 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6478
436c16df 6479 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6480 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6481 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6482
92bb796d 6483 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6484 (x_term_init): Remove local to avoid shadowing.
92bb796d 6485
764430a3 6486 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6487
6488 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6489 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6490
d1dfb56c
EZ
64912011-04-16 Eli Zaretskii <eliz@gnu.org>
6492
c4354cb4
EZ
6493 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6494
d1dfb56c
EZ
6495 Fix regex.c, syntax.c and friends for buffers > 2GB.
6496 * syntax.h (struct gl_state_s): Declare character position members
6497 EMACS_INT.
6498
6499 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6500
04f2d78b
CB
6501 * textprop.c (verify_interval_modification, interval_of):
6502 Declare arguments EMACS_INT.
d1dfb56c
EZ
6503
6504 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6505 EMACS_INT.
6506
6507 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6508
6509 * indent.c (Fvertical_motion): Local variable it_start is now
6510 EMACS_INT.
6511
6512 * regex.c (re_match, re_match_2, re_match_2_internal)
6513 (bcmp_translate, regcomp, regexec, print_double_string)
6514 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6515 (re_compile_pattern, re_exec): Declare arguments and local
6516 variables `size_t' and `ssize_t' and return values `regoff_t', as
6517 appropriate.
6518 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6519 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6520 <compile_stack_type>: `size' and `avail' are now `size_t'.
6521
6522 * regex.h <regoff_t>: Use ssize_t, not int.
6523 (re_search, re_search_2, re_match, re_match_2): Arguments that
6524 specify buffer/string position and length are now ssize_t and
6525 size_t. Return type is regoff_t.
6526
613052cd
BK
65272011-04-16 Ben Key <bkey76@gmail.com>
6528
6529 * nsfont.m: Fixed bugs in ns_get_family and
6530 ns_descriptor_to_entity that were caused by using free to
6531 deallocate memory blocks that were allocated by xmalloc (via
6532 xstrdup). This caused Emacs to crash when compiled with
6533 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6534 --enable-checking=xmallocoverrun). xfree is now used to
6535 deallocate these memory blocks.
6536
4170f62f 65372011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6538
71b41406
PE
6539 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6540
9587a89d
PE
6541 emacs_write: Accept and return EMACS_INT for sizes.
6542 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6543 et seq.
6544 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6545 Accept and return EMACS_INT.
6546 (emacs_gnutls_write): Return the number of bytes written on
6547 partial writes.
6548 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6549 (emacs_read, emacs_write): Remove check for negative size, as the
6550 Emacs source code has been audited now.
9587a89d
PE
6551 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6552 (emacs_read, emacs_write): Use it.
273a5f82
PE
6553 * process.c (send_process): Adjust to the new signatures of
6554 emacs_write and emacs_gnutls_write. Do not attempt to store
6555 a byte offset into an 'int'; it might overflow.
9587a89d 6556 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6557
3e047f51
PE
6558 * sound.c: Don't assume sizes fit in 'int'.
6559 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6560 Return EMACS_INT, not int.
3e047f51 6561 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6562 Accept EMACS_INT, not int.
6563 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6564 record read return values.
6565
cc39a9db
BK
65662011-04-15 Ben Key <bkey76@gmail.com>
6567
c9d0ec6d
JB
6568 * keyboard.c (Qundefined): Don't declare static since it is used
6569 in nsfns.m.
6570 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6571 static since they are used in nsfont.m.
cc39a9db 6572
6c60eb9f
SM
65732011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6574
6575 * process.c (Qprocessp): Don't declare static.
6576 * lisp.h (Qprocessp): Declare again.
6577
7990b61a
JB
65782011-04-15 Juanma Barranquero <lekktu@gmail.com>
6579
6580 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6581
5d4cb038
PE
65822011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6583
8bd7b830 6584 Improve C-level modularity by making more things 'static'.
cd64ea1d 6585
e3b27b31
PE
6586 Don't publish debugger-only interfaces to other modules.
6587 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6588 (verify_bytepos, count_markers): Move decls to the only modules
6589 that need them.
6590 * region-cache.h (pp_cache): Likewise.
6591 * window.h (check_all_windows): Likewise.
6592 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6593
5d4cb038
PE
6594 * sysdep.c (croak): Now static, if
6595 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6596 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6597
6598 * alloc.c (refill_memory_reserve): Now static if
6599 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6600 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6601
e87b6180
PE
6602 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6603 Define only if USE_LUCID.
6604
ac64929e
PE
6605 * xrdb.c (x_customization_string, x_rm_string): Now static.
6606
6f37259d
PE
6607 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6608 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6609
1683e3ab
PE
6610 * xdisp.c (draw_row_with_mouse_face): Now static.
6611 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6612
de9c2632
PE
6613 * window.h (check_all_windows): Mark externally visible.
6614
2b96acb7
PE
6615 * window.c (window_deletion_count): Now static.
6616
6617 * undo.c: Make symbols static if they're not exported.
6618 (last_undo_buffer, last_boundary_position, pending_boundary):
6619 Now static.
6620
50436f33
PE
6621 * textprop.c (interval_insert_behind_hooks): Now static.
6622 (interval_insert_in_front_hooks): Likewise.
6623
64520e5c
PE
6624 * term.c: Make symbols static if they're not exported.
6625 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6626 (max_frame_lines, tty_set_terminal_modes):
6627 (tty_reset_terminal_modes, tty_turn_off_highlight):
6628 (get_tty_terminal): Now static.
6629 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6630 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6631 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6632 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6633 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6634
1fa53021
PE
6635 * sysdep.c: Make symbols static if they're not exported.
6636 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6637 Now static.
6638 (sigprocmask_set, full_mask): Remove; unused.
6639 (wait_debugging): Mark as visible.
6640 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6641 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6642
d4b43b22
PE
6643 * syntax.c (syntax_temp): Define only if !__GNUC__.
6644
b7c513d0
PE
6645 * sound.c (current_sound_device, current_sound): Now static.
6646
989b29ad
PE
6647 * search.c (searchbufs, searchbuf_head): Now static.
6648
13a55a78
PE
6649 * scroll.c (scroll_cost): Remove; unused.
6650 * dispextern.h (scroll_cost): Remove decl.
6651
de68a1fc
PE
6652 * region-cache.h (pp_cache): Mark as externally visible.
6653
40ccffa6
PE
6654 * process.c: Make symbols static if they're not exported.
6655 (process_tick, update_tick, create_process, chan_process):
6656 (Vprocess_alist, proc_buffered_char, datagram_access):
6657 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6658 (deactivate_process): Mark defn as static, as well as decl.
6659 * lisp.h (create_process): Remove decl.
6660 * process.h (chan_process, Vprocess_alist): Remove decls.
6661
ad64fc97
PE
6662 * print.c: Make symbols static if they're not exported.
6663 (print_depth, new_backquote_output, being_printed, print_buffer):
6664 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6665 (print_interval, print_number_index, initial_stderr_stream):
6666 Now static.
6667 * lisp.h (Fprinc): Remove decl.
6668 (debug_output_compilation_hack): Mark as externally visible.
6669
adddb265
PE
6670 * sysdep.c (croak): Move decl from here to syssignal.h.
6671 * syssignal.h (croak): Put it here, so the API can be checked when
6672 'croak' is called from dissociate_if_controlling_tty.
6673
1717ede2
PE
6674 * minibuf.c: Make symbols static if they're not exported.
6675 (minibuf_save_list, choose_minibuf_frame): Now static.
6676 * lisp.h (choose_minibuf_frame): Remove decl.
6677
fa5fb2bc
PE
6678 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6679
1e3890d1
PE
6680 * lread.c: Make symbols static if they're not exported.
6681 (read_objects, initial_obarray, oblookup_last_bucket_number):
6682 Now static.
6683 (make_symbol): Remove; unused.
6684 * lisp.h (initial_obarray, make_symbol): Remove decls.
6685
8a1414fa
PE
6686 * keyboard.c: Make symbols static if they're not exported.
6687 (single_kboard, recent_keys_index, total_keys, recent_keys):
6688 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6689 (this_single_command_key_start, echoing, last_auto_save):
6690 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6691 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6692 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6693 (Vlispy_mouse_stem, double_click_count):
6694 Now static.
6695 (force_auto_save_soon): Define only if SIGDANGER.
6696 (ignore_mouse_drag_p): Now static if
6697 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6698 (print_help): Remove; unused.
6699 (stop_character, last_timer_event): Mark as externally visible.
6700 * keyboard.h (ignore_mouse_drag_p): Declare only if
6701 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6702 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6703 * lisp.h (echoing): Remove decl.
6704 (force_auto_save_soon): Declare only if SIGDANGER.
6705 * xdisp.c (redisplay_window): Simplify code, to make it more
6706 obvious that ignore_mouse_drag_p is not accessed if !defined
6707 USE_GTK && !defined HAVE_NS.
6708
93ea6e8f
PE
6709 * intervals.c: Make symbols static if they're not exported.
6710 (merge_properties_sticky, merge_interval_right, delete_interval):
6711 Now static.
6712 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6713
77382fcc
PE
6714 * insdel.c: Make symbols static if they're not exported.
6715 However, leave prepare_to_modify_buffer alone. It's never
6716 called from outside this function, but that appears to be a bug.
6717 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6718 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6719 (adjust_after_replace_noundo): Remove; unused.
6720 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6721 (signal_before_change): Remove decls.
77382fcc 6722
9306c32e
PE
6723 * indent.c (val_compute_motion, val_vmotion): Now static.
6724
cd44d2eb
PE
6725 * image.c: Make symbols static if they're not exported.
6726 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6727 if USE_GTK.
6728 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6729 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6730
ad9a7a06
PE
6731 * fringe.c (standard_bitmaps): Now static.
6732 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6733
81626931
PE
6734 * frame.c: Make symbols static if they're not exported.
6735 (x_report_frame_params, make_terminal_frame): Now static.
6736 (get_frame_param): Now static, unless HAVE_NS.
6737 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6738 (x_get_resource_string): Remove; not used.
6739 * frame.h (make_terminal_frame, x_report_frame_params):
6740 (x_get_resource_string); Remove decls.
6741 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6742 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6743
239f9db9
PE
6744 * font.c, fontset.c: Make symbols static if they're not exported.
6745 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6746 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6747 * font.c (font_close_object): Now static.
6748 * font.h (font_close_object): Remove.
6749 * fontset.c (FONTSET_OBJLIST): Remove.
6750 (free_realized_fontset) #if-0 the body, which does nothing.
6751 (face_suitable_for_char_p): #if-0, as it's never called.
6752 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6753 * xfaces.c (face_at_string_position):
6754 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6755 since 0 is always ASCII.
6756
dfcf3579
PE
6757 * fns.c (weak_hash_tables): Now static.
6758
5045092b
PE
6759 * fileio.c: Make symbols static if they're not exported.
6760 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6761 (Vwrite_region_annotation_buffers): Now static.
6762
57a96f5c
PE
6763 * eval.c: Make symbols static if they're not exported.
6764 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6765 * lisp.h (backtrace_list): Remove decl.
6766
35f08c38
PE
6767 * emacs.c: Make symbols static if they're not exported.
6768 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6769 (fatal_error_code, fatal_error_signal_hook, standard_args):
6770 Now static.
6771 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6772 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6773 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6774 * lisp.h (fatal_error_signal_hook): Remove decl.
6775 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6776
f44bd759
PE
6777 * editfns.c: Move a (normally-unused) function to its only use.
6778 * editfns.c, lisp.h (get_operating_system_release): Remove.
6779 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6780 worth the hassle of breaking this out.
6781
b532497d
PE
6782 * xterm.c: Make symbols static if they're not exported.
6783 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6784 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6785 (x_destroy_window, x_delete_display):
6786 Now static.
6787 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6788 (x_mouse_leave): Remove; unused.
6789 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6790 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6791 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6792 Remove decls.
6793 (x_mouse_leave): Declare only if WINDOWSNT.
6794 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6795 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6796 USE_X_TOOLKIT.
6797
1675728f
PE
6798 * ftxfont.c: Make symbols static if they're not exported.
6799 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6800 HAVE_FREETYPE.
6801 * font.h (ftxfont_driver): Likewise.
6802
e4cebfca
PE
6803 * xfns.c: Make symbols static if they're not exported.
6804 (x_last_font_name, x_display_info_for_name):
6805 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6806 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6807 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6808 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6809 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6810 (last_show_tip_args): Now static.
6811 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6812 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6813 (x_screen_planes): Remove; unused.
6814 * dispextern.h (x_screen_planes): Remove decl.
6815
5bf46f05
PE
6816 * dispnew.c: Make symbols static if they're not exported.
6817 * dispextern.h (redraw_garbaged_frames, scrolling):
6818 (increment_row_positions): Remove.
6819 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6820 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6821 Now static.
6822 (redraw_garbaged_frames): Remove; unused.
6823
435f4c28
PE
6824 * xfaces.c: Make symbols static if they're not exported.
6825 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6826 Remove decls.
6827 * xterm.h (defined_color): Remove decls.
6828 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6829 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6830 (menu_face_changed_default, defined_color, free_realized_face):
6831 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6832 (ascii_face_of_lisp_face): Remove; unused.
6833
8524aef3
PE
6834 * xdisp.c: Make symbols static if they're not exported.
6835 * dispextern.h (scratch_glyph_row, window_box_edges):
6836 (glyph_to_pixel_coords, set_cursor_from_row):
6837 (get_next_display_element, set_iterator_to_next):
6838 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6839 (show_mouse_face): Remove decls
6840 * frame.h (message_buf_print): Likewise.
6841 * lisp.h (pop_message, set_message, check_point_in_composition):
6842 Likewise.
6843 * xterm.h (set_vertical_scroll_bar): Likewise.
6844 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6845 (message_buf_print, scratch_glyph_row, displayed_buffer):
6846 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6847 (get_next_display_element, show_mouse_face, window_box_edges):
6848 (frame_to_window_pixel_xy, check_point_in_composition):
6849 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6850 (glyph_to_pixel_coords): Remove; unused.
6851
16390cd2
PE
6852 * dired.c (file_name_completion): Now static.
6853
6854 * dbusbind.c (xd_in_read_queued_messages): Now static.
6855
a25f4dfa
PE
6856 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6857 * data.c (circular_list_error): Remove.
6858
14a9c8df
PE
6859 * commands.h (last_point_position, last_point_position_buffer):
6860 (last_point_position_window): Remove decls.
6861 * keyboard.c: Make these variables static.
6862
04f2d78b
CB
6863 * coding.h (coding, code_convert_region, encode_coding_gap):
6864 Remove decls.
74ab6df5
PE
6865 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6866 (iso_code_class, detect_coding, code_convert_region): Now static.
6867 (encode_coding_gap): Remove; unused.
6868
38dfbee1
PE
6869 * chartab.c (chartab_chars, chartab_bits): Now static.
6870
a2cb4e63
PE
6871 * charset.h (charset_iso_8859_1): Remove decl.
6872 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6873 Now static.
6874
127198fd
PE
6875 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6876 * ccl.c (Vccl_program_table): Now static.
6877 (check_ccl_update): Remove; unused.
6878
d85b608f
PE
6879 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6880 * category.h: ... from here.
6881 * category.c (check_category_table, set_category_set): Now static.
6882
31cd66f3
PE
6883 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6884 * lisp.h: Remove these decls.
6885
c358e587
PE
6886 * buffer.c (buffer_count): Remove unused var.
6887
e78aecca
PE
6888 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6889 so that it's not optimized away.
6890 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6891 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6892 exported only to the debugger.
6893
e192d7d3 6894 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6895 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6896
92470028
PE
6897 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6898 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6899 was inaccessible from Lisp.
6900 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6901 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6902
244ed907
PE
6903 alloc.c: Import and export fewer symbols, and remove unused items.
6904 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6905 is defined.
6906 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6907 it's not optimized away by whole-program optimization.
6908 (message_enable_multibyte, free_misc): Remove.
6909 (catchlist, handlerlist, mark_backtrace):
6910 Declare only if BYTE_MARK_STACK.
6911 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6912 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6913 (message_enable_multibyte): Remove decl.
6914 (free_misc, interval_free_list, float_block, float_block_index):
6915 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6916 (cons_free_list, last_marked_index):
6917 Now static.
6918 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6919 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6920 (mark_backtrace): Define only if BYTE_MARK_STACK.
6921 * xdisp.c (message_enable_multibyte): Now static.
6922
61c2b50e 6923 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6924 This makes it easier for human readers (and static analyzers)
6925 to see whether these variables are used from other modules.
6926 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6927 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6928 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6929 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6930 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6931 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6932 * xmenu.c, xselect.c:
6933 Declare Q* vars static if they are not used in other modules.
6934 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6935 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6936 Remove decls of unexported vars.
6937 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6938
95c82688
PE
6939 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6940
16a97296
PE
6941 Make Emacs functions such as Fatom 'static' by default.
6942 This makes it easier for human readers (and static analyzers)
6943 to see whether these functions can be called from other modules.
6944 DEFUN now defines a static function. To make the function external
6945 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6946 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6947 (Finit_image_library):
16a97296
PE
6948 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6949 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6950 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6951 Remove decls, since these functions are now static.
6952 (Funintern, Fget_internal_run_time): New decls, since these functions
6953 were already external.
95c82688 6954
16a97296
PE
6955 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6956 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6957 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6958 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6959 * keyboard.c, keymap.c, lread.c:
6960 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6961 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6962 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6963 Mark functions with DEFUE instead of DEFUN,
6964 if they are used in other modules.
6965 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6966 decls for now-static functions.
6967 * buffer.h (Fdelete_overlay): Remove decl.
6968 * callproc.c (Fgetenv_internal): Mark as internal.
6969 * composite.c (Fremove_list_of_text_properties): Remove decl.
6970 (Fcomposition_get_gstring): New forward static decl.
6971 * composite.h (Fcomposite_get_gstring): Remove decl.
6972 * dired.c (Ffile_attributes): New forward static decl.
6973 * doc.c (Fdocumntation_property): New forward static decl.
6974 * eval.c (Ffetch_bytecode): New forward static decl.
6975 (Funintern): Remove extern decl; now in .h file where it belongs.
6976 * fileio.c (Fmake_symbolic_link): New forward static decl.
6977 * image.c (Finit_image_library): New forward static decl.
6978 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6979 * intervals.h (Fprevious_property_change):
6980 (Fremove_list_of_text_properties): Remove decls.
6981 * keyboard.c (Fthis_command_keys): Remove decl.
6982 (Fcommand_execute): New forward static decl.
6983 * keymap.c (Flookup_key): New forward static decl.
6984 (Fcopy_keymap): Now static.
6985 * keymap.h (Flookup_key): Remove decl.
6986 * process.c (Fget_process): New forward static decl.
6987 (Fprocess_datagram_address): Mark as internal.
6988 * syntax.c (Fsyntax_table_p): New forward static decl.
6989 (skip_chars): Remove duplicate decl.
6990 * textprop.c (Fprevious_property_change): New forward static decl.
6991 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6992 Now internal.
6993 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6994 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6995
785bbd42
PE
6996 * editfns.c (Fformat): Remove unreachable code.
6997
8b913b57
AS
69982011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6999
7000 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7001 change. (Bug#8496)
7002
a6744a35
EZ
70032011-04-13 Eli Zaretskii <eliz@gnu.org>
7004
7005 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7006 when at ZV. (Bug#8487)
7007
e7974947
AS
70082011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7009
baad03f0
AS
7010 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7011 (Bug#8437)
7012 * keyboard.c (parse_tool_bar_item): Likewise.
7013 * sound.c (sound_cleanup, alsa_close): Likewise.
7014 * termcap.c (tgetent): Likewise.
7015 * xfns.c (x_default_font_parameter): Likewise.
7016 * xsettings.c (read_and_apply_settings): Likewise.
7017
e7974947
AS
7018 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7019 (overrun_check_free): Protoize.
7020
28272684
PE
70212011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7022
7023 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7024 since callers should never pass a negative size.
7025 Change the signature to match that of plain 'read' and 'write'; see
7026 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7027 * lisp.h: Update prototypes of emacs_write and emacs_read.
7028
11997c76
EZ
70292011-04-11 Eli Zaretskii <eliz@gnu.org>
7030
7031 * xdisp.c (redisplay_window): Don't try to determine the character
7032 position of the scroll margin if the window start point w->startp
e896f03c 7033 is outside the buffer's accessible region. (Bug#8468)
11997c76 7034
8a2cbd72
EZ
70352011-04-10 Eli Zaretskii <eliz@gnu.org>
7036
7037 Fix write-region and its subroutines for buffers > 2GB.
7038 * fileio.c (a_write, e_write): Modify declaration of arguments and
7039 local variables to support buffers larger than 2GB.
7040 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7041
7042 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7043 argument, local variables, and return value.
7044
7045 * lisp.h: Update prototypes of emacs_write and emacs_read.
7046
7047 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7048
4073e537 70492011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7050
1ebfdcb6
PE
7051 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7052
b2ded58d
PE
7053 Fix more problems found by GCC 4.6.0's static checks.
7054
7d66342c
PE
7055 * xdisp.c (vmessage): Use a better test for character truncation.
7056
bbf47d44
PE
7057 * charset.c (load_charset_map): <, not <=, for optimization,
7058 and to avoid potential problems with integer overflow.
9248994d 7059 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7060 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7061 * editfns.c (Fformat): Likewise.
1e69125e 7062 * syntax.c (skip_chars): Likewise.
3befa583 7063
e3019616
PE
7064 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7065 This also lets GCC 4.6.0 generate slightly better loop code.
7066
becfa255
PE
7067 * callint.c (Fcall_interactively): <, not <=, for optimization.
7068 (Fcall_interactively): Count the number of arguments produced,
7069 not the number of arguments given. This is simpler and lets GCC
7070 4.6.0 generate slightly better code.
7071
dae0cd48
PE
7072 * ftfont.c: Distingish more carefully between FcChar8 and char.
7073 The previous code passed unsigned char * to a functions like
7074 strlen and xstrcasecmp that expect char *, which does not
7075 conform to the C standard.
7076 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7077 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7078 char * when the C standard requires it.
7079
76032d70
PE
7080 * keyboard.c (read_char): Remove unused var.
7081
eb3f1cc8
PE
7082 * eval.c: Port to Windows vsnprintf (Bug#8435).
7083 Include <limits.h>.
7084 (SIZE_MAX): Define if the headers do not.
7085 (verror): Do not give up if vsnprintf returns a negative count.
7086 Instead, grow the buffer. This ports to Windows vsnprintf, which
7087 does not conform to C99. Problem reported by Eli Zaretskii.
7088 Also, simplify the allocation scheme, by avoiding the need for
7089 calling realloc, and removing the ALLOCATED variable.
7090
70476b54
PE
7091 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7092
12020a9e
PE
7093 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7094 But keep the doprint source code for now, as we might revamp it
7095 and use it again (Bug#8435).
ea6c7ae6
PE
7096 * lisp.h (doprnt): Remove.
7097 * Makefile.in (base_obj): Remove doprnt.o.
7098 * deps.mk (doprnt.o): Remove.
7099
5fdb398c
PE
7100 error: Print 32- and 64-bit integers portably (Bug#8435).
7101 Without this change, on typical 64-bit hosts error ("...%d...", N)
7102 was used to print both 32- and 64-bit integers N, which relied on
7103 undefined behavior.
7104 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7105 New macro.
7106 * lisp.h (error, verror): Mark as printf-like functions.
7107 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7108 Report overflow in size calculations when allocating printf buffer.
7109 Do not truncate output string at its first null byte.
7110 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7111 Truncate the output at a character boundary, since vsnprintf does not
7112 do that.
7113 * charset.c (check_iso_charset_parameter): Convert internal
7114 character to string before calling 'error', since %c now has the
7115 printf meaning.
7116 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7117 overflow when computing char to be passed to 'error'. Do not
7118 pass Lisp_Object to 'error'; pass the integer instead.
7119 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7120 formatted with plain %d.
7121
b189fa66
PE
7122 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7123
bff87ef0
PE
7124 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7125
7e2cac20
PE
7126 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7127
ce4d90b5
PE
7128 * xterm.c (x_catch_errors): Remove duplicate declaration.
7129
266c9547
PE
7130 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7131
79c49ad2
PE
7132 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7133
368f4090
JM
71342011-04-10 Jim Meyering <meyering@redhat.com>
7135
7136 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7137 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7138 return ssize_t not "int", and use size_t as the buffer length.
7139 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7140 * gnutls.h: Update declarations.
7141 * process.c (read_process_output): Use ssize_t, to match.
7142 (send_process): Likewise.
7143
a32d4040
CY
71442011-04-09 Chong Yidong <cyd@stupidchicken.com>
7145
7146 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7147
8546720e 71482011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7149
04f2d78b
CB
7150 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7151 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7152
8546720e
GM
7153 * xterm.c (handle_one_xevent):
7154 * xmenu.c (create_and_show_popup_menu):
7155 * xselect.c (x_decline_selection_request)
7156 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7157
0a2f5c1a 71582011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7159
7160 Fix some uses of `int' instead of EMACS_INT.
7161 * search.c (string_match_1, fast_string_match)
7162 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7163 (scan_buffer, find_next_newline_no_quit)
7164 (find_before_next_newline, search_command, Freplace_match)
7165 (Fmatch_data): Make some `int' variables be EMACS_INT.
7166
7167 * xdisp.c (display_count_lines): 3rd argument and return value now
7168 EMACS_INT. All callers changed.
7169 (pint2hrstr): Last argument is now EMACS_INT.
7170
7171 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7172 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7173 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7174 (decode_coding_utf_16, decode_coding_emacs_mule)
7175 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7176 (decode_coding_ccl, decode_coding_charset)
7177 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7178 (decode_coding_iso_2022, decode_coding_emacs_mule)
7179 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7180 <char_offset, last_offset>: Declare EMACS_INT.
7181 (encode_coding_utf_8, encode_coding_utf_16)
7182 (encode_coding_emacs_mule, encode_invocation_designation)
7183 (encode_designation_at_bol, encode_coding_iso_2022)
7184 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7185 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7186 Declare EMACS_INT.
7187 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7188 (encode_invocation_designation): Last argument P_NCHARS is now
7189 EMACS_INT.
7190 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7191 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7192
7193 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7194 All users changed.
7195
7196 * ccl.c (Fccl_execute_on_string): Declare some variables
7197 EMACS_INT.
7198
8546720e 71992011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7200
7201 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7202
4e19a977
CS
72032011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7204
7205 * process.c (Fformat_network_address): Doc fix.
7206
87302331
R
72072011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7208
ee7683eb 7209 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7210
cbb59342
CY
72112011-04-08 Chong Yidong <cyd@stupidchicken.com>
7212
7213 * keyboard.c (read_char): Call Lisp function help-form-show,
7214 instead of using internal_with_output_to_temp_buffer.
7215 (Qhelp_form_show): New var.
e0d38eeb 7216 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7217
7218 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7219
7220 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7221
e67a13ab
CY
72222011-04-06 Chong Yidong <cyd@stupidchicken.com>
7223
04f2d78b
CB
7224 * process.c (Flist_processes): Remove to Lisp.
7225 (list_processes_1): Delete.
e67a13ab 7226
973f782d
EZ
72272011-04-06 Eli Zaretskii <eliz@gnu.org>
7228
7c106b1e
EZ
7229 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7230
973f782d
EZ
7231 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7232
41cf7d1a 72332011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7234
ca23cc88
PE
7235 Fix more problems found by GCC 4.6.0's static checks.
7236
f390e2d5
PE
7237 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7238
42eea0d0
PE
7239 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7240
b69769da 7241 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7242
f9541e84
PE
7243 * xdisp.c (vmessage): Mark as a printf-like function.
7244
13841b55
PE
7245 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7246
c136c10f
PE
7247 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7248
5e2d4a30
PE
7249 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7250 printf-like functions.
7251 (tiff_load): Add casts to remove these marks before passing them
7252 to system-supplied API.
7253
583f48b9
PE
7254 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7255
b25d760e
PE
7256 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7257 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7258 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7259 directly, rather than having caller test rule sign. This avoids
7260 some unnecessary tests.
7261 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7262 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7263 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7264
bc7b6697 7265 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7266 (xfont_open): Avoid unnecessary tests.
bc7b6697 7267
27ccc379
PE
7268 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7269
dcd5c89a
PE
7270 * composite.h, composite.c (composition_gstring_put_cache):
7271 Use EMACS_INT, not int, for length.
7272
b13a45c6
PE
7273 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7274 breaking out part of COMPOSITION_DECODE_RULE.
7275 (COMPOSITION_DECODE_RULE): Use it.
7276 * composite.c (get_composition_id): Remove unused local vars,
7277 by using the new macro.
7278
1e792e4d
PE
7279 * textprop.c (set_text_properties_1): Change while to do-while,
7280 since the condition is always true at first.
7281
dc6c6455 7282 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7283 (interval_deletion_adjustment): Return unsigned value.
7284 All uses changed.
dc6c6455 7285
aba7731a
PE
7286 * process.c (list_processes_1, create_pty, read_process_output):
7287 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7288 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7289 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7290 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7291 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7292
fdfc4bf3
PE
7293 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7294
fca8fe46 7295 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7296 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7297
06a0259a 7298 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7299 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7300 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7301
e7b9e80f
PE
7302 * print.c (print_error_message): Avoid int overflow.
7303
56201685
PE
7304 * font.c (font_list_entities): Redo for clarity,
7305 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7306
78834453 7307 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7308 (font_score): Avoid potential overflow in diff calculation.
78834453 7309
0bc0b309 7310 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7311 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7312
e610eaca
PE
7313 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7314
b895abce
PE
7315 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7316 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7317 can always succeed if overflow has undefined behavior.
7318
1f1d9321 7319 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7320 (wordify): Omit three unnecessary tests.
1f1d9321 7321
c59478bc
PE
7322 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7323 All callers changed. This avoids the need for an unused var.
7324
79b73827
PE
7325 * casefiddle.c (casify_region): Remove var that is set but not used.
7326
a4db5dfe
PE
7327 * dired.c (file_name_completion): Remove var that is set but not used.
7328
43aae36e
PE
7329 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7330
2a47c44d 7331 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7332 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7333
a37c69bf
PE
7334 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7335 Check for integer overflow on size calculations.
7336
328ab8e7
PE
7337 * buffer.c (Fprevious_overlay_change): Remove var that is set
7338 but not used.
7339
e5a2a5cb
PE
7340 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7341 Remove vars that are set but not used.
8d84a6eb 7342 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7343 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7344
a60e5f68
PE
7345 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7346
f661cb61 7347 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7348 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7349
f0397f5a
PE
7350 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7351 that are set but not used.
7352
8664db06 7353 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7354 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7355
6abdaa4a
PE
7356 * xselect.c (x_get_local_selection, x_handle_property_notify):
7357 Remove vars that are set but not used.
7358
0ce7538d 7359 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7360 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7361
9ae848fc
PE
7362 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7363 Remove var that is set but not used.
0b918413
PE
7364 (scroll_bar_windows_size): Now size_t, not int.
7365 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7366 Check for overflow.
9ae848fc 7367
a5a62657
PE
7368 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7369 (map_tty_color) [!defined MSDOS]: Likewise.
7370
5c5cdd39
PE
7371 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7372
66ebf983
PE
7373 * coding.c: Remove vars that are set but not used.
7374 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7375 All callers changed.
7376 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7377 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7378 (decode_coding_charset): Remove vars that are set but not used.
7379
1be4d761
PE
7380 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7381 that is set but not used.
7382
47553fa8
PE
7383 * print.c (print_object): Remove var that is set but not used.
7384
1f7196bf 7385 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7386 The gnulib version avoids calling malloc in the usual case,
7387 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7388 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7389 * filelock.c (current_lock_owner): Likewise.
7390 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7391 * sysdep.c: Include allocator.h, careadlinkat.h.
7392 (emacs_no_realloc_allocator): New static constant.
7393 (emacs_readlink): New function.
fdb61804
PE
7394 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7395 ../lib/careadlinkat.h.
d1fdcab7 7396
f84c17c7
SM
73972011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7398
7399 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7400 first non-nil return value).
7401
ef3862ad
JD
74022011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7403
7404 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7405 if not defined (Bug#8403).
7406
376a7006
JB
74072011-04-02 Juanma Barranquero <lekktu@gmail.com>
7408
7409 * xdisp.c (display_count_lines): Remove parameter `start',
7410 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7411 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7412 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7413 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7414 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7415 and thereabouts. All callers changed.
7416 (get_per_char_metric): Remove parameter `f', unused since
7417 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7418
6ca3801d
JM
74192011-04-02 Jim Meyering <meyering@redhat.com>
7420
7421 do not dereference NULL upon failed strdup
7422 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7423 (ns_get_family): Likewise.
7424
d8e2b5ba
JB
74252011-04-02 Juanma Barranquero <lekktu@gmail.com>
7426
7427 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7428
8c74fcbd
JD
74292011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7430
7431 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7432 later (Bug#8403).
7433
7200d79c
SM
74342011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7435
03408648 7436 Add lexical binding.
7200d79c 7437
03408648
SM
7438 * window.c (Ftemp_output_buffer_show): New fun.
7439 (Fsave_window_excursion):
7440 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7441
7442 * lread.c (lisp_file_lexically_bound_p): New function.
7443 (Fload): Bind Qlexical_binding.
7444 (readevalloop): Remove `evalfun' arg.
7445 Bind Qinternal_interpreter_environment.
7446 (Feval_buffer): Bind Qlexical_binding.
7447 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7448 Mark as dynamic.
7449 (syms_of_lread): Declare `lexical-binding'.
7450
7451 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7452
7453 * keyboard.c (eval_dyn): New fun.
7454 (menu_item_eval_property): Use it.
ca105506
SM
7455
7456 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7457
03408648
SM
7458 * fns.c (concat, mapcar1): Accept byte-code-functions.
7459
7460 * eval.c (Fsetq): Handle lexical vars.
7461 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7462 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7463 (FletX, Flet): Obey lexical binding.
7464 (Fcommandp): Handle closures.
7465 (Feval): New `lexical' arg.
7466 (eval_sub): New function extracted from Feval. Use it almost
7467 everywhere where Feval was used. Look up vars in lexical env.
7468 Handle closures.
7469 (Ffunctionp): Move from subr.el.
7470 (Ffuncall): Handle closures.
7471 (apply_lambda): Remove `eval_flags'.
7472 (funcall_lambda): Handle closures and new byte-code-functions.
7473 (Fspecial_variable_p): New function.
7474 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7475 but without exporting it to Lisp.
23aba0ea 7476
23aba0ea 7477 * doc.c (Fdocumentation, store_function_docstring):
03408648 7478 * data.c (Finteractive_form): Handle closures.
23aba0ea 7479
03408648
SM
7480 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7481 interactive spec.
ba83908c 7482
04f2d78b
CB
7483 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7484 New byte-codes.
03408648
SM
7485 (exec_byte_code): New function extracted from Fbyte_code to handle new
7486 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7487
03408648 7488 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7489
03408648 7490 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7491
e2abce01
JB
74922011-03-31 Juanma Barranquero <lekktu@gmail.com>
7493
7494 * xdisp.c (redisplay_internal): Fix prototype.
7495
63696a73 74962011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7497
63696a73 7498 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7499 (try_scrolling): Use it when setting scroll_limit.
7500 Limit scrolling to 100 screen lines.
63696a73
EZ
7501 (redisplay_window): Even when falling back on "recentering",
7502 position point in the window according to scroll-conservatively,
7503 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7504
7505 (try_scrolling): When point is above the window, allow searching
7506 as far as scroll_max, or one screenful, to compute vertical
7507 distance from PT to the scroll margin position. This prevents
7508 try_scrolling from unnecessarily failing when
7509 scroll-conservatively is set to a value slightly larger than the
7510 window height. Clean up the case of PT below the margin at bottom
7511 of window: scroll_max can no longer be INT_MAX. When aggressive
7512 scrolling is in use, don't let point enter the opposite scroll
7513 margin as result of the scroll.
7514 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7515 threshold of 100 lines for never-recentering scrolling.
7516
e4cc2dfc
JB
75172011-03-31 Juanma Barranquero <lekktu@gmail.com>
7518
7519 * dispextern.h (move_it_by_lines):
7520 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7521 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7522 (message_log_check_duplicate): Remove parameters `prev_bol' and
7523 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7524 (redisplay_internal): Remove parameter `preserve_echo_area',
7525 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7526
7527 * indent.c (Fvertical_motion):
7528 * window.c (window_scroll_pixel_based, Frecenter):
7529 Don't pass `need_y_p' to `move_it_by_lines'.
7530
1c470562
SM
75312011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7532
44f230aa
SM
7533 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7534 steal a few bits to be more compact.
7535 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7536 Remove unneeded casts.
7537
1c470562
SM
7538 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7539
888adce9
ZK
75402011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7541
7542 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7543 binding" message (bug#7967).
7544
f838ed7b
PE
75452011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7546
77861b95
PE
7547 Fix more problems found by GCC 4.6.0's static checks.
7548
de6dbc14
PE
7549 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7550 Remove unused local var.
7551
f838ed7b
PE
7552 * editfns.c (Fmessage_box): Remove unused local var.
7553
792c7b2b
PE
7554 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7555 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7556 Omit unused local vars.
c499e557 7557 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7558 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7559 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7560 Omit unused local var.
7561
ba0165e1
PE
7562 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7563 Don't assume string length fits in int.
32ad8845 7564 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7565 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7566
3c59b4c9
PE
7567 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7568 instead of alloca (Bug#8344).
7569
a3eed478 7570 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7571 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7572
eb4d412d
PE
7573 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7574
1658b401
PE
7575 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7576 concerns.
7577
7578 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7579
7580 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7581
9a2c6e05
PE
7582 * keyboard.c (syms_of_keyboard): Use the same style as later
7583 in this function when indexing through an array. This also
7584 works around GCC bug 48267.
7585
03d0a109
PE
7586 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7587
44f730c8
PE
7588 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7589
fe75f926
PE
7590 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7591 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7592
ffa8c828
PE
7593 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7594 This avoids undefined behavior on integer overflow, and is a bit
7595 more convenient anyway since it is compared to a size_t variable.
7596
c5101a77
PE
7597 Variadic C functions now count arguments with size_t, not int.
7598 This avoids an unnecessary limitation on 64-bit machines, which
7599 caused (substring ...) to crash on large vectors (Bug#8344).
7600 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7601 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7602 All variadic functions and their callers changed accordingly.
c5101a77
PE
7603 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7604 * data.c (arith_driver, float_arith_driver): Likewise.
7605 * editfns.c (general_insert_function): Likewise.
7606 * eval.c (struct backtrace.nargs, interactive_p)
7607 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7608 (funcall_lambda, mark_backtrace): Likewise.
7609 * fns.c (concat): Likewise.
7610 * frame.c (x_set_frame_parameters): Likewise.
7611 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7612 0 if not found, not -1. All callers changed.
7613
dd3f25f7
PE
7614 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7615 (stack_copy_size): Now size_t, not int.
7616 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7617
461c2ab9
JB
76182011-03-28 Juanma Barranquero <lekktu@gmail.com>
7619
7620 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7621 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7622 All callers changed.
7623
7624 * lisp.h (multibyte_char_to_unibyte):
7625 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7626 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7627 * character.h (CHAR_TO_BYTE8):
7628 * cmds.c (internal_self_insert):
7629 * editfns.c (general_insert_function):
7630 * keymap.c (push_key_description):
7631 * search.c (Freplace_match):
7632 * xdisp.c (message_dolog, set_message_1): All callers changed.
7633
f6d62986
SM
76342011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7635
7636 * keyboard.c (safe_run_hook_funcall): New function.
7637 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7638 don't set the hook to nil, but remove the offending function instead.
7639 (Qcommand_hook_internal): Remove, unused.
7640 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7641 Vcommand_hook_internal.
7642
7643 * eval.c (enum run_hooks_condition): Remove.
7644 (funcall_nil, funcall_not): New functions.
7645 (run_hook_with_args): Call each function through a `funcall' argument.
7646 Remove `cond' argument, now redundant.
7647 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7648 (Frun_hook_with_args_until_failure): Adjust accordingly.
7649 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7650
1db5b1ad
JB
76512011-03-28 Juanma Barranquero <lekktu@gmail.com>
7652
7653 * dispextern.h (string_buffer_position): Remove declaration.
7654
7655 * print.c (strout): Remove parameter `multibyte', unused since
7656 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7657
7658 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7659 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7660 All callers changed.
7661
7662 * w32.c (_wsa_errlist): Use braces for struct initializers.
7663
7664 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7665 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7666 All callers changed.
7667 (string_buffer_position): Likewise. Also, make static (it's never
7668 used outside xdisp.c).
7669 (cursor_row_p): Remove parameter `w', unused since
7670 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7671 (decode_mode_spec): Remove parameter `precision', introduced during
7672 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7673 All callers changed.
7674
5ffb62aa
JD
76752011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7676
7677 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7678
461c2ab9 76792011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7680
7681 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7682 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7683 (ns_update_auto_hide_menu_bar): New functions.
7684 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7685 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7686 ns_constrain_all_frames.
7687 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7688 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7689
5c380ffb
JD
76902011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7691
7692 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7693
9af30bdf
GM
76942011-03-27 Glenn Morris <rgm@gnu.org>
7695
7696 * syssignal.h: Replace RETSIGTYPE with void.
7697 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7698 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7699 Replace SIGTYPE with void everywhere.
7700 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7701 * s/template.h (SIGTYPE): Remove commented out definition.
7702
e2abce01
JB
77032011-03-26 Eli Zaretskii <eliz@gnu.org>
7704
7705 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7706 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7707
f868cd8a
JB
77082011-03-26 Juanma Barranquero <lekktu@gmail.com>
7709
59eb0929
JB
7710 * w32.c (read_unc_volume): Use parameter `henum', instead of
7711 global variable `wget_enum_handle'.
7712
7713 * keymap.c (describe_vector): Remove parameters `indices' and
7714 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7715 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7716
f868cd8a
JB
7717 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7718
7719 * keyboard.c (timer_check): Remove parameter `do_it_now',
7720 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7721 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7722 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7723
7724 * keyboard.c (read_char):
7725 * w32menu.c (w32_menu_display_help):
7726 * xmenu.c (show_help_event, menu_help_callback):
7727 Adjust calls to `show_help_echo'.
7728
7729 * gtkutil.c (xg_maybe_add_timer):
7730 * keyboard.c (readable_events):
7731 * process.c (wait_reading_process_output):
7732 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7733
7734 * insdel.c (adjust_markers_gap_motion):
7735 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7736 (gap_left, gap_right): Don't call it.
7737
2ecf6fdb
CY
77382011-03-25 Chong Yidong <cyd@stupidchicken.com>
7739
7740 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7741 incurred during fontification.
7742
6b1f9ba4
JB
77432011-03-25 Juanma Barranquero <lekktu@gmail.com>
7744
7745 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7746 (DEFVAR_PER_BUFFER): Don't pass it.
7747
7748 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7749 (scrolling_window): Don't pass it.
7750
0f4a96b5
JB
77512011-03-25 Juanma Barranquero <lekktu@gmail.com>
7752
7753 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7754
7755 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7756 and `suffix'.
7757 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7758 of variables specific to SELinux and computation of `encoded_absname'.
7759
7760 * image.c (XPutPixel): Remove unused variable `height'.
7761
7762 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7763
7764 * unexw32.c (get_section_info): Remove unused variable `section'.
7765
7766 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7767 (system_process_attributes): Remove unused variable `sess'.
7768 (sys_read): Remove unused variable `err'.
7769
7770 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7771 (w32_wnd_proc): Remove unused variable `isdead'.
7772 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7773 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7774 (x_create_tip_frame): Remove unused variable `tem'.
7775
7776 * w32inevt.c (w32_console_read_socket):
7777 Remove unused variable `no_events'.
7778
7779 * w32term.c (x_draw_composite_glyph_string_foreground):
7780 Remove unused variable `width'.
7781
1149507c
JB
77822011-03-24 Juanma Barranquero <lekktu@gmail.com>
7783
7784 * w32term.c (x_set_glyph_string_clipping):
7785 Don't pass uninitialized region to CombineRgn.
7786
9c88f339
JB
77872011-03-23 Juanma Barranquero <lekktu@gmail.com>
7788
7789 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7790 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7791 (Fx_close_connection): Remove unused variable `i'.
7792
7793 * w32font.c (w32font_draw): Return number of glyphs.
7794 (w32font_open_internal): Remove unused variable `i'.
7795 (w32font_driver): Add missing initializer.
7796
7797 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7798 (fill_in_menu): Remove unused variable `items_added'.
7799
7800 * w32term.c (last_mouse_press_frame): Remove static global variable.
7801 (w32_clip_to_row): Remove unused variable `f'.
7802 (x_delete_terminal): Remove unused variable `i'.
7803
7804 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7805 (NOTHING): Remove unused static global variable.
7806 (uniscribe_check_otf): Remove unused variable `table'.
7807 (uniscribe_font_driver): Add missing initializers.
7808
dee091a3
JD
78092011-03-23 Julien Danjou <julien@danjou.info>
7810
7811 * term.c (Fsuspend_tty, Fresume_tty):
7812 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7813 * window.c (temp_output_buffer_show):
7814 * insdel.c (signal_before_change):
7815 * frame.c (Fhandle_switch_frame):
7816 * fileio.c (Fdo_auto_save):
7817 * emacs.c (Fkill_emacs):
7818 * editfns.c (save_excursion_restore):
7819 * cmds.c (internal_self_insert):
7820 * callint.c (Fcall_interactively):
7821 * buffer.c (Fkill_all_local_variables):
7822 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7823 Use Frun_hooks.
0f4a96b5 7824 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7825 unconditionally since it does the check itself.
dee091a3 7826
2c520ab5 78272011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7828
c9c49752
PE
7829 Fix more problems found by GCC 4.5.2's static checks.
7830
8abc3f12
PE
7831 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7832 the first time through the loop, since we know p0 < p1 then.
7833 This also avoids a gcc -Wstrict-overflow warning.
7834
a2d26660
PE
7835 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7836 leading to a memory leak, possible in functions like
7837 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7838 of objects (Bug#8318).
a2d26660 7839
916c72e9
PE
7840 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7841 that could (at least in theory) be that large.
7842
19ab8a18
PE
7843 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7844 This is less likely to overflow, and avoids undefined behavior if
7845 overflow does occur. All callers changed. Use strtoul to scan
7846 for the unsigned long integer.
b7cbbd6f
PE
7847 (pint2hrstr): Simplify and tune code slightly.
7848 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7849
f0641eff
PE
7850 * scroll.c (do_scrolling): Work around GCC bug 48228.
7851 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7852
7f650bb9
PE
7853 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7854 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7855 (validate_x_resource_name): Simplify count usage.
7856 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7857
37dd57d1
PE
7858 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7859 fail (Bug#8306).
81e56e61 7860
699979fc 7861 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7862
401bf9b4
PE
7863 * process.c (Fmake_network_process): Use socklen_t, not int,
7864 where POSIX says socklen_t is required in portable programs.
7865 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7866 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7867 (Fmake_network_process, server_accept_connection):
7868 (wait_reading_process_output, read_process_output):
7869 Likewise.
7870
b93aacde
PE
7871 * process.c: Rename or move locals to avoid shadowing.
7872 (list_processes_1, Fmake_network_process):
7873 (read_process_output_error_handler, exec_sentinel_error_handler):
7874 Rename or move locals.
4dc343ee 7875 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7876 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7877 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7878 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7879 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7880
af8a867c 7881 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7882 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7883 Include tparam.h instead, since it declares them.
af8a867c
PE
7884 * cm.h (PC): Remove extern decl; tparam.h now does this.
7885 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7886 * terminfo.c: Include tparam.h, to check interfaces.
7887 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7888 (tparam): Adjust signature to match interface in tparam.h;
7889 this removes some undefined behavior. Check that outstring and len
7890 are zero, which they always are with Emacs.
7891 * tparam.h (PC, BC, UP): New extern decls.
7892
0248044d 7893 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7894 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7895
8ff096c1 7896 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7897 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7898 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7899 (ftfont_list): Remove unused local.
49eaafba
PE
7900 (get_adstyle_property, ftfont_pattern_entity):
7901 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7902 Rename locals to avoid shadowing.
8ff096c1 7903
e2be39f6
PE
7904 * xfont.c (xfont_list_family): Mark var as initialized.
7905
c9735e30
PE
7906 * xml.c (make_dom): Now static.
7907
8f5201ae
PE
7908 * composite.c (composition_compute_stop_pos): Rename local to
7909 avoid shadowing.
b246f932
PE
7910 (composition_reseat_it): Remove unused locals.
7911 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7912 (composition_update_it): Mark var as initialized.
11b61122
PE
7913 (find_automatic_composition): Mark vars as initialized,
7914 with a FIXME (Bug#8290).
8f5201ae 7915
760fbc2c
PE
7916 character.h: Rename locals to avoid shadowing.
7917 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7918 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7919 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7920 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7921 to avoid shadowing.
7922
ff08eb85
PE
7923 * textprop.c (property_change_between_p): Remove; unused.
7924
fc7bf025
PE
7925 * intervals.c (interval_start_pos): Now static.
7926
235d7abc
PE
7927 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7928
44f230aa
SM
7929 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7930 Rename locals to avoid shadowing.
3e7d6594 7931
50060332
PE
7932 * sound.c (wav_play, au_play, Fplay_sound_internal):
7933 Fix pointer signedness.
d01f234b 7934 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7935 (wav_play): Initialize a variable to 0, to prevent undefined
7936 behavior (Bug#8278).
50060332 7937
c4fc4e30
PE
7938 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7939
918436ed
PE
7940 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7941
c939f91b
PE
7942 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7943 clobbering (Bug#8298).
b9c7f648
PE
7944 * sysdep.c (sys_subshell): Likewise.
7945 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7946
6bd8c144
PE
7947 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7948 This should get cleaned up, so that child_setup has the
7949 same signature on all platforms.
7950
7710357c 7951 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7952 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7953
c59da222
CY
79542011-03-22 Chong Yidong <cyd@stupidchicken.com>
7955
7956 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7957 not to be necessary, and produces flickering.
7958
66b87493
GM
79592011-03-20 Glenn Morris <rgm@gnu.org>
7960
7961 * config.in: Remove file.
7962
45b6f6d5
JB
79632011-03-20 Juanma Barranquero <lekktu@gmail.com>
7964
7965 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7966 are now in src/globals.h.
7967 (syms_of_minibuf): Remove spurious & from previous change.
7968
3ec03f7e
LL
79692011-03-20 Leo <sdl.web@gmail.com>
7970
7971 * minibuf.c (completing-read-function): New variable.
7972 (completing-read-default): Rename from completing-read.
7973 (completing-read): Call completing-read-function.
7974
b14e3e21
CY
79752011-03-19 Juanma Barranquero <lekktu@gmail.com>
7976
7977 * xfaces.c (Fx_load_color_file):
7978 Read color file from absolute filename (bug#8250).
7979
f2b726e6
JB
79802011-03-19 Juanma Barranquero <lekktu@gmail.com>
7981
7982 * makefile.w32-in: Update dependencies.
7983
09f6ff02
EZ
79842011-03-17 Eli Zaretskii <eliz@gnu.org>
7985
7986 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7987
29a6015a
PE
79882011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7989
a3a6c54e
PE
7990 Fix more problems found by GCC 4.5.2's static checks.
7991
b766f867
PE
7992 * process.c (make_serial_process_unwind, send_process_trap):
7993 (sigchld_handler): Now static.
7994
be02381c
PE
7995 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7996 That way, the code declares only the vars that it needs.
7997 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7998 * s/cygwin.h (PTY_ITERATION): Likewise.
7999 * s/darwin.h (PTY_ITERATION): Likewise.
8000 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8001
57048744
PE
8002 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8003 * process.c (allocate_pty): Don't declare stb unless it's needed.
8004
7914961c 8005 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8006 (CONSTANTLIM): Remove; unused.
8007 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8008 Define only if needed.
7914961c 8009
b3967b18
PE
8010 * unexelf.c (unexec): Name an expression,
8011 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8012 Use a different way to cause a compilation error if anyone uses
8013 n rather than nn, a way that does not involve shadowing.
73366a00 8014 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8015
29a6015a
PE
8016 * deps.mk (unexalpha.o): Remove; unused.
8017
43cfc33e 8018 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8019 * unexec.h: New file.
ce701a33
PE
8020 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8021 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8022 Depend on unexec.h.
8023 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8024 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8025 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8026 Change as necessary to match prototype in unexec.h.
ce701a33 8027
01f44d5a
PE
8028 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8029 shadowing.
4f63c6bb 8030 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8031
a6670b0b
PE
8032 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8033 Rename locals to avoid shadowing.
8034
cef2010d 8035 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8036 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8037
d4d7173a
PE
8038 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8039
f08b802a
PE
8040 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8041 warning when compiling print.c.
8042
3ddb0639
PE
8043 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8044 instead of using an uninitialized var.
5ad03b97 8045 (font_sort_entities): Mark var as initialized.
3ddb0639 8046
170a2692
PE
8047 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8048
e663c700
PE
8049 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8050 pointers to constants.
89bc529a 8051 (font_parse_fcname): Remove unused vars.
7b81e2d0 8052 (font_delete_unmatched): Now static.
ea838e10 8053 (font_get_spec): Remove; unused.
13a547c6
PE
8054 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8055 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8056 Rename or move locals to avoid shadowing.
e663c700 8057
2a80c887 8058 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8059 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8060
1384fa33 8061 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8062 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8063
8b2c52e9
PE
8064 * alloc.c (mark_backtrace): Move decl from here ...
8065 * lisp.h: ... to here, so that it can be checked.
8066
475545b5 8067 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8068 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8069 (lisp_indirect_variable): Name an expression,
8070 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8071 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8072
b1349114 8073 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8074 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8075 Use const pointer when appropriate.
b1349114 8076
a2928364
PE
8077 * lisp.h (get_system_name, get_operating_system_release):
8078 Move decls here, to check interfaces.
8079 * process.c (get_operating_system_release): Move decl to lisp.h.
8080 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8081 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8082 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8083 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8084 (Fformat_time_string, Fencode_time, Finsert_char):
8085 (Ftranslate_region_internal, Fformat):
8086 Rename or remove local vars to avoid shadowing.
9710023e 8087 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8088
a415e694
PE
8089 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8090 avoid shadowing.
8091
8ef4622d
PE
8092 * lisp.h (eassert): Check that the argument compiles, even if
8093 ENABLE_CHECKING is not defined.
8094
946f9a5b
PE
8095 * data.c (Findirect_variable): Name an expression, to avoid
8096 gcc -Wbad-function-cast warning.
112396d6 8097 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8098 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8099 (Fmake_variable_buffer_local, Fmake_local_variable):
8100 Mark variables as initialized.
52746918 8101 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8102
e5aab7e7 8103 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8104 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8105 Rename locals to avoid shadowing.
dff45157
PE
8106 (mark_stack): Move local variables into the #ifdef region where
8107 they're used.
7bc26fdb
PE
8108 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8109 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8110 needed otherwise.
8111 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8112 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8113 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8114
e5aab7e7
PE
8115 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8116 avoids undefined behavior in theory.
8117
4da60324
PE
8118 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8119
88043301
PE
8120 Use functions, not macros, for up- and down-casing (Bug#8254).
8121 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8122 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8123 to use the following functions instead of these macros.
8124 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8125 EMACS_INT, since callers assume the returned value fits in int.
8126 (upcase1): Likewise, for UPCASE_TABLE.
8127 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8128 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8129 the race-condition problem in the old DOWNCASE.
88043301 8130
19ed5445
PE
8131 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8132 Rename locals to avoid shadowing.
8133 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8134 (regex_compile, re_search_2, re_match_2_internal):
8135 Remove unused local vars.
952db0d7
PE
8136 (FREE_VAR): Rewrite so as not to use empty "else",
8137 which gcc can warn about.
da053e48 8138 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8139 (RETALLOC_IF): Define only if needed.
8140 (WORDCHAR_P): Likewise. This one is never needed, but is used
8141 only in a comment talking about a compiler bug, so put inside
8142 the #if 0 of that comment.
8143 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8144 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8145 Remove; unused.
19ed5445 8146
1f3561e4 8147 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8148 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8149 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8150
ded6f8f7
PE
8151 * search.c (simple_search): Remove unused var.
8152
dbd37a95
PE
8153 * dired.c (compile_pattern): Move decl from here ...
8154 * lisp.h: ... to here, so that it can be checked.
8155 (struct re_registers): New forward decl.
8156
7e47afad
PE
8157 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8158
85f24f61
PE
8159 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8160 All uses changed.
8161 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8162 Rename locals to avoid shadowing.
5671df8f 8163 (Fvertical_motion): Mark locals as initialized.
85f24f61 8164
181aa2be 8165 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8166 (casify_region): Mark local as initialized.
181aa2be 8167
930d429c
PE
8168 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8169
7082eac6
PE
8170 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8171 New macros, so that the caller can use some names other than
8172 gcpro1, gcpro2, etc.
8173 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8174 of the new macros.
8175 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8176 argument, for consistency with GCPRO2_VAR, etc: it is now the
8177 prefix of the variable, not the variable itself. All uses
8178 changed.
38b2c076
PE
8179 * dired.c (directory_files_internal, file_name_completion):
8180 Rename locals to avoid shadowing.
8181
15206ed9
PE
8182 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8183 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8184 dired.c's scmp function, had undefined behavior.
8185 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8186 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8187 * buffer.h: ... to here, because these macros use current_buffer,
8188 and the new implementation with inline functions needs to have
8189 current_buffer in scope now, rather than later when the macros
8190 are used.
8191 (downcase, upcase1): New static inline functions.
8192 (DOWNCASE, UPCASE1): Reimplement using these functions.
8193 This avoids undefined behavior in expressions like
8194 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8195 from race conditions in accessing the global variables
8196 case_temp1 and case_temp2.
8197 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8198 * lisp.h (case_temp1, case_temp2): Remove their decls.
8199 * character.h (ASCII_CHAR_P): Move from here ...
8200 * lisp.h: ... to here, so that the inline functions mentioned
8201 above can use them.
8202
4a6bea26
PE
8203 * dired.c (directory_files_internal_unwind): Now static.
8204
f14b7e14
PE
8205 * fileio.c (file_name_as_directory, directory_file_name):
8206 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8207 Now static.
2893f146
PE
8208 (file_name_as_directory): Use const pointers when appropriate.
8209 (Fexpand_file_name): Likewise. In particular, newdir might
8210 point at constant storage, so make it a const pointer.
fd4ead52 8211 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8212 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8213 signedness issues.
f839df0c
PE
8214 (Fset_file_times, Finsert_file_contents, auto_save_error):
8215 Rename locals to avoid shadowing.
f14b7e14 8216
5716756e 8217 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8218 (Ftry_completion, Fall_completions): Rename or remove locals
8219 to avoid shadowing.
5716756e 8220
b4c3046a
PE
8221 * marker.c (bytepos_to_charpos): Remove; unused.
8222
b45db522
PE
8223 * lisp.h (verify_bytepos, count_markers): New decls,
8224 so that gcc does not warn that these functions aren't declared.
8225
85876d07
PE
8226 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8227 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8228 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8229 (copy_text): Remove unused local var.
85876d07 8230
03d78a21 8231 * filelock.c (within_one_second): Now static.
b3dd38ab 8232 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8233
5df8f01b
PE
8234 * buffer.c (fix_overlays_before): Mark locals as initialized.
8235 (fix_start_end_in_overlays): Likewise. This function should be
8236 simplified by using pointers-to-pointers, but that's a different
8237 matter.
b1d876f1 8238 (switch_to_buffer_1): Now static.
8f54f30a
PE
8239 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8240 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8241
a70072c9 8242 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8243 Fix pointer signedness issue.
edced198
PE
8244 (sys_subshell): Mark local as volatile if checking for lint,
8245 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8246 (MAXPATHLEN): Define only if needed.
a70072c9 8247
a0977c44
PE
8248 * process.c (serial_open, serial_configure): Move decls from here ...
8249 * systty.h: ... to here, so that they can be checked.
8250
a884fdcc
PE
8251 * fns.c (get_random, seed_random): Move extern decls from here ...
8252 * lisp.h: ... to here, so that they can be checked.
8253
604efe86 8254 * sysdep.c (reset_io): Now static.
b8950c94 8255 (wait_for_termination_signal): Remove; unused.
604efe86 8256
38fc62d9
PE
8257 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8258 (copy_keymap_item, append_key, push_text_char_description):
8259 Now static.
1004a21a 8260 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8261 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8262 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8263 (describe_map_tree):
8264 Rename locals to avoid shadowing.
38fc62d9 8265
2f2650da
PE
8266 * keyboard.c: Declare functions static if they are not used elsewhere.
8267 (echo_char, echo_dash, cmd_error, top_level_2):
8268 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8269 (read_char, kbd_buffer_get_event, make_lispy_position):
8270 (make_lispy_event, make_lispy_movement, apply_modifiers):
8271 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8272 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8273 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8274 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8275 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8276
a053e86c 8277 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8278 (mark_kboards): Move decl here ...
8279 * alloc.c (mark_kboards): ... from here.
a053e86c 8280
4752793e
PE
8281 * lisp.h (force_auto_save_soon): New decl.
8282
74f10ca7 8283 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8284 (DEFINE_DUMMY_FUNCTION): New macro.
8285 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8286 Use it.
c03cd23f
PE
8287 (main): Add casts to avoid warnings
8288 if GCC considers string literals to be constants.
74f10ca7 8289
022e70d4
PE
8290 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8291
59d6fe83
PE
8292 * dbusbind.c: Pointer signedness fixes.
8293 (xd_signature, xd_append_arg, xd_initialize):
8294 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8295 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8296 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8297 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8298
78320123
PE
8299 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8300 if GCC considers string literals to be constants.
49cebcca 8301 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8302
35ac2a97
SM
83032011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8304
fb103ca9
SM
8305 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8306 (print_preprocess, print_object): New macro to fix last change.
8307
35ac2a97
SM
8308 * print.c (print_preprocess): Don't forget font objects.
8309
62973b41
JB
83102011-03-16 Juanma Barranquero <lekktu@gmail.com>
8311
8312 * emacs.c (USAGE3): Doc fixes.
8313
0e48bb22
AS
83142011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8315
8316 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8317 structure.
8318
7684e57b
JB
83192011-03-14 Juanma Barranquero <lekktu@gmail.com>
8320
8321 * lisp.h (VWindow_system, Qfile_name_history):
8322 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8323 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8324 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8325
8326 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8327 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8328
8329 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8330 * w32console.c (detect_input_pending, read_input_pending)
8331 (encode_terminal_code):
8332 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8333 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8334 (w32_system_caret_y, Qfile_name_history):
8335 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8336 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8337 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8338 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8339 * w32proc.c (Qlocal, report_file_error):
8340 * w32term.c (Vwindow_system, updating_frame):
8341 * w32uniscribe.c (initialized, uniscribe_font_driver):
8342 Remove unneeded extern declarations.
8343
2aa46d6c
CY
83442011-03-14 Chong Yidong <cyd@stupidchicken.com>
8345
c96bbc66 8346 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8347
cffc6f3b
CY
83482011-03-13 Chong Yidong <cyd@stupidchicken.com>
8349
8350 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8351 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8352 These macros can no longer be used for assignment.
8353
44f230aa
SM
8354 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8355 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8356 (record_buffer_markers, fetch_buffer_markers): New functions for
8357 recording and fetching special buffer markers.
8358 (set_buffer_internal_1, set_buffer_temp): Use them.
8359
8360 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8361
8362 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8363
8364 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8365 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8366
8367 * xdisp.c (hscroll_window_tree):
8368 (reconsider_clip_changes): Use PT instead of BUF_PT.
8369
d251f04b
EZ
83702011-03-13 Eli Zaretskii <eliz@gnu.org>
8371
8372 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8373 $(EMACS_ROOT)/lib/intprops.h.
8374
f0c77cd1
PE
83752011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8376
3eca4629
PE
8377 Fix more problems found by GCC 4.5.2's static checks.
8378
7c86ee98
PE
8379 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8380 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8381 (xg_free_frame_widgets): Make it clear that a local variable is
8382 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8383 (gdk_window_get_screen): Make it clear that this macro is needed
8384 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8385 (int_gtk_range_get_value): New function, which avoids a diagnostic
8386 from gcc -Wbad-function-cast.
8387 (xg_set_toolkit_scroll_bar_thumb): Use it.
8388 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8389 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8390 (get_utf8_string, xg_get_file_with_chooser):
8391 Rename locals to avoid shadowing.
8392 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8393
41729b81
PE
8394 * xgselect.c (xg_select): Remove unused var.
8395
f0c77cd1
PE
8396 * image.c (four_corners_best): Mark locals as initialized.
8397 (gif_load): Initialize transparent_p to zero (Bug#8238).
8398 Mark another local as initialized.
ec6cf4c6 8399 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8400
ce0ad53d 8401 * image.c (clear_image_cache): Now static.
d5d5a617 8402 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8403 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8404 (x_edge_detection): Remove unnecessary cast that
8405 gcc -Wbad-function-cast diagnoses.
2037898d 8406 (gif_load): Fix pointer signedness.
6ae141d6
PE
8407 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8408 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8409
33383987 84102011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8411
d32df629
PE
8412 Improve quality of tests for time stamp overflow.
8413 For example, without this patch (encode-time 0 0 0 1 1
8414 1152921504606846976) returns the obviously-bogus value (-948597
8415 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8416 reports time overflow. See
8417 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8418 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8419 * editfns.c: Include limits.h and intprops.h.
8420 (TIME_T_MIN, TIME_T_MAX): New macros.
8421 (time_overflow): Move earlier, to before first use.
8422 (hi_time, lo_time): New functions, for an accurate test for
8423 out-of-range times.
8424 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8425 (Fget_internal_run_time): Don't assume time_t fits in int.
8426 (make_time): Use list2 instead of Fcons twice.
8427 (Fdecode_time): More accurate test for out-of-range times.
8428 (check_tm_member): New function.
8429 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8430 (lisp_time_argument): Don't rely on undefined left-shift and
8431 right-shift behavior when checking for time stamp overflow.
8be6f318 8432
fe31d94c
PE
8433 * editfns.c (time_overflow): New function, refactoring common code.
8434 (Fformat_time_string, Fdecode_time, Fencode_time):
8435 (Fcurrent_time_string): Use it.
8436
8be6f318
PE
8437 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8438 * dired.c (make_time): Move to ...
8439 * editfns.c (make_time): ... here.
8440 * systime.h: Note the move.
8441
09d9db2c 84422011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8443
126bc0dc
YM
8444 * fringe.c (update_window_fringes): Remove unused variables.
8445
c47cbdfd
YM
8446 * unexmacosx.c (copy_data_segment): Also copy __got section.
8447 (Bug#8223)
8448
7ac80be9
EZ
84492011-03-12 Eli Zaretskii <eliz@gnu.org>
8450
c96bbc66 8451 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8452 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8453 Constify `char *' arguments and their references according to
8454 prototypes in tparam.h.
8455
ecb0f94d 8456 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8457
7ac80be9
EZ
8458 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8459 Adapt all references accordingly.
8460
8461 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8462
ef1fd07e
TT
84632011-03-11 Tom Tromey <tromey@redhat.com>
8464
8465 * buffer.c (syms_of_buffer): Remove obsolete comment.
8466
7ef4b50c
EZ
84672011-03-11 Eli Zaretskii <eliz@gnu.org>
8468
8469 * termhooks.h (encode_terminal_code): Declare prototype.
8470
8471 * msdos.c (encode_terminal_code): Don't declare prototype.
8472
8473 * term.c (encode_terminal_code): Now external again, used by
8474 w32console.c and msdos.c.
8475
44f230aa
SM
8476 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8477 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8478
4b1ec863 84792011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8480
1714f52b 8481 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8482
4b1ec863
PE
8483 * fringe.c (update_window_fringes): Mark locals as initialized
8484 (Bug#8227).
8485 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8486
524c7aa6
PE
8487 * alloc.c (mark_fringe_data): Move decl from here ...
8488 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8489 to check its interface.
8490 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8491
a5c0af81 8492 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8493 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8494 (fontset_font): Mark local as initialized.
a9a06e0b 8495 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8496
b4716021
PE
8497 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8498
811e9bac 8499 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8500 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8501 (x_own_selection, Fx_disown_selection_internal): Rename locals
8502 to avoid shadowing.
8503 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8504
7e3ab302
PE
8505 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8506 so that the caller can use some name other than gcpro1.
8507 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8508 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8509 (Fx_backspace_delete_keys_p):
8510 Use them to avoid shadowing, and rename vars to avoid shadowing.
8511 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8512 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8513 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8514 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8515 Remove unused locals.
7e3ab302
PE
8516 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8517 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8518 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8519 macros.
f78faa98 8520
e2b13473
PE
8521 * xterm.h (x_mouse_leave): New decl.
8522
77f23912
PE
8523 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8524 Remove unused functions.
cdf4ba58
PE
8525 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8526 (x_calc_absolute_position): Now static.
7411c686 8527 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8528 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8529 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8530 unless they are used.
38d0b34a
PE
8531 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8532 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8533 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8534 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8535 (x_error_catcher, x_connection_closed, x_error_handler):
8536 (x_error_quitter, xembed_send_message, x_iconify_frame):
8537 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8538 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8539 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8540
44f230aa
SM
8541 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8542 Rename or move locals to avoid shadowing.
6b463e58 8543 (tty_defined_color, merge_face_heights): Now static.
5967d051 8544 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8545 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8546 does not deduce is never used uninitialized.
73719eba
PE
8547 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8548 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8549
426994c3 8550 * terminal.c (store_terminal_param): Now static.
5489860b 8551
032f1620 8552 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8553 (set_frame_menubar): Remove unused local.
d4323972 8554 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8555 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8556 since they might point to immutable storage.
281585b0
PE
8557 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8558 since it's unused otherwise.
032f1620 8559
367c19e5 8560 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8561 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8562 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8563 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8564 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8565 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8566 does not deduce are never used uninitialized.
70739cbe 8567
07b48fa9
PE
8568 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8569
8868a238 8570 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8571 * window.c (window_loop, size_window):
8572 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8573
7e5cf297 8574 * window.c (display_buffer): Now static.
d6550a9f
PE
8575 (size_window): Mark variables that gcc -Wuninitialized
8576 does not deduce are never used uninitialized.
a586633d
PE
8577 * window.h (check_all_windows): New decl, to forestall
8578 gcc -Wmissing-prototypes diagnostic.
5b555da1 8579 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8580
f6095868
PE
8581 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8582 shadowing.
8583 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8584 Include <limits.h>.
8585 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8586 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8587 (load_charset_map): Mark variables that gcc -Wuninitialized
8588 does not deduce are never used uninitialized.
53df7c11 8589 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8590
f38b440c
PE
8591 * coding.c (coding_set_source, coding_set_destination):
8592 Use "else { /* comment */ }" rather than "else /* comment */;"
8593 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8594 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8595 a block, when the outer 'i' will do.
8596 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8597 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8598 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8599 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8600 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8601 Rename locals to avoid shadowing.
8602 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8603 * coding.c (emacs_mule_char, encode_invocation_designation):
8604 Now static, since they're not used elsewhere.
413bb2db 8605 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8606 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8607 (decode_coding_emacs_mule): Mark variables that gcc
8608 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8609 (detect_coding_iso_2022): Initialize a local variable that might
8610 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8611 this initialization is needed. (Bug#8211)
5f58e762
PE
8612 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8613 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8614 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8615 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8616 Remove unused macros.
f38b440c 8617
232b38b9 8618 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8619 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8620 * character.c (string_count_byte8): Likewise.
232b38b9 8621
fb90da1b
PE
8622 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8623 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8624
fb93dbc2
PE
8625 * chartab.c (copy_sub_char_table): Now static, since it's not used
8626 elsewhere.
5c156ace
PE
8627 (sub_char_table_ref_and_range, char_table_ref_and_range):
8628 Rename locals to avoid shadowing.
bbcd0949 8629 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8630
7d3b3862 8631 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8632 (BIDI_BOB): Remove unused macro.
7d3b3862 8633
6be7d3da
PE
8634 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8635 deduce are never used uninitialized.
c2ed9c8b 8636 * term.c (encode_terminal_code): Likewise.
6be7d3da 8637
75f8807f 8638 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8639
50938595
PE
8640 * tparam.h: New file.
8641 * term.c, tparam.h: Include it.
8642 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8643 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8644 Move these decls to tparam.h, and make them agree with what
8645 is actually in tparam.c. The previous trick of using incompatible
8646 decls in different modules does not conform to the C standard.
8647 All callers of tparam changed to use tparam's actual API.
8648 * tparam.c (tparam1, tparam, tgoto):
8649 Use const pointers where appropriate.
8650
fbceeba2
PE
8651 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8652 * cm.h (struct cm): Likewise.
8653 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8654 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8655 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8656 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8657 (turn_on_face, init_tty): Likewise.
8658 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8659
7f3f1250
PE
8660 * term.c (term_mouse_position): Rename local to avoid shadowing.
8661
e6ca6543
PE
8662 * alloc.c (mark_ttys): Move decl from here ...
8663 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8664
c40f8d15
AS
86652011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8666
8667 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8668
cfe0661d
JB
86692011-03-09 Juanma Barranquero <lekktu@gmail.com>
8670
8671 * search.c (compile_pattern_1): Remove argument regp, unused since
8672 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8673 (compile_pattern): Don't pass it.
8674
0afb4571
J
86752011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8676
8677 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8678 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8679 for ! HAVE_GTK3.
8680 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8681
8682 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8683
8684 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8685 gdk_window_get_screen, gdk_window_get_geometry,
8686 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8687 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8688 (xg_get_pixbuf_from_pixmap): New function.
8689 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8690 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8691 Call xg_get_pixbuf_from_pixmap instead of
8692 gdk_pixbuf_get_from_drawable.
8693 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8694 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8695 (xg_check_special_colors): Use GtkStyleContext and its functions
8696 for HAVE_GTK3.
8697 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8698 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8699 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8700 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8701 Call gtk_widget_get_preferred_size.
0afb4571
J
8702 (xg_frame_resized): gdk_window_get_geometry only takes 5
8703 parameters.
44f230aa
SM
8704 (xg_win_to_widget, xg_event_is_for_menubar):
8705 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8706 (xg_set_widget_bg): New function.
8707 (delete_cb): New function.
895009e1 8708 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8709 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8710 (xg_set_background_color): Call xg_set_widget_bg.
8711 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8712 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8713 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8714 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8715 if ! HAVE_GTK3.
8716 (update_frame_tool_bar): Call gtk_widget_hide.
8717 (xg_initialize): Use GDK_KEY_g.
8718
8719 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8720 if ! HAVE_GTK3
8721 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8722
8723 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8724 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8725 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8726
1c2cc4ef
JB
87272011-03-08 Juanma Barranquero <lekktu@gmail.com>
8728
8729 * w32xfns.c (select_palette): Check success of RealizePalette against
8730 GDI_ERROR, not zero.
8731
33383987 8732See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8733
8734;; Local Variables:
8735;; coding: utf-8
aac0c6e3
MR
8736;; End:
8737
33383987 8738 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8739
8740 This file is part of GNU Emacs.
8741
8742 GNU Emacs is free software: you can redistribute it and/or modify
8743 it under the terms of the GNU General Public License as published by
8744 the Free Software Foundation, either version 3 of the License, or
8745 (at your option) any later version.
8746
8747 GNU Emacs is distributed in the hope that it will be useful,
8748 but WITHOUT ANY WARRANTY; without even the implied warranty of
8749 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8750 GNU General Public License for more details.
8751
8752 You should have received a copy of the GNU General Public License
8753 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.