* alloc.c (allocate_vector_block): Remove redundant
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d12e8f5a
DA
12012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * alloc.c (allocate_vector_block): Remove redundant
4 calls to mallopt if DOUG_LEA_MALLOC is defined.
5 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
6 avoid calls to mallopt if zero_vector is returned.
7
296094c3
DA
82012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
9
10 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
11 is enabled, avoid dereferencing NULL current_sblock if
12 running undumped.
13
36429c89
DA
142012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
15
16 Cleanup basic buffer management.
17 * buffer.h (struct buffer): Change layout to use generic vector
18 marking code. Fix some comments. Change type of 'clip_changed'
19 to bitfield. Remove unused #ifndef old.
20 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
21 (GET_OVERLAYS_AT): Fix indentation.
22 (for_each_per_buffer_object_at): New macro.
23 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
24 (Fbuffer_local_variables): Use it.
25 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
26 * alloc.c (allocate_buffer): Adjust to match new layout of
27 struct buffer. Fix comment.
28 (mark_overlay): New function.
29 (mark_buffer): Use it. Use mark_vectorlike to mark normal
30 Lisp area of struct buffer.
31 (mark_object): Use it. Adjust marking of misc objects
32 and related comments.
33
3b3e4cac
PE
342012-07-02 Paul Eggert <eggert@cs.ucla.edu>
35
36 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
37 wrapper that is not needed because the wrapped code is a no-op (zero
38 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
39 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
40
cf5c0175
DA
412012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
42
43 * alloc.c (mark_buffer): Simplify. Remove prototype.
44 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 45 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
46 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
47 redundant calls to mark_vectorlike for bool vectors.
48
ca26824c
GM
492012-06-30 Glenn Morris <rgm@gnu.org>
50
2e4c5312
GM
51 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
52
ca26824c
GM
53 * epaths.in (PATH_SITELOADSEARCH): New.
54 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
55 This is rather than relying on --enable-locallisppath elements
56 having "site-lisp" in their names. (Bug#10208#25, 11658)
57
0d23c240
EZ
582012-06-30 Eli Zaretskii <eliz@gnu.org>
59
c9240d7a
EZ
60 * w32proc.c (sys_select): Accept and ignore one more argument.
61
62 * w32.c (emacs_gnutls_pull): Call select with one more argument.
63
0d23c240 64 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 65 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
66
67 * sysdep.c: Don't include dos.h and dosfns.h.
68
69 * process.c (sys_select):
70 * msdos.c (sys_select): Accept one more argument and ignore it.
71
72 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
73 adapt data types and code to that.
74
75 * dosfns.c:
76 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
77 which clashes with the gnulib function of the same name.
78
af5a5a98
AS
792012-06-30 Andreas Schwab <schwab@linux-m68k.org>
80
c5e4379c
AS
81 * font.c (font_style_to_value, font_style_symbolic)
82 (font_prop_validate_style): Add type checks for values in
83 font_style_table.
84
af5a5a98
AS
85 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
86 argument.
87 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
88 uses.
89
8d38f461
EZ
902012-06-29 Eli Zaretskii <eliz@gnu.org>
91
2e5a6631
EZ
92 * xdisp.c (try_window_id): Undo last change.
93
8d38f461
EZ
94 * w32.c (getwd): Adjust commentary about startup_dir.
95 (init_environment): Always call sys_access, even in non-MSVC
96 builds. Don't chdir to the directory of the Emacs executable.
97 This undoes code from 1997 which was justified by the need to
98 "avoid conflicts when removing and renaming directories". But its
99 downside was that every relative file name was being interpreted
100 relative to the directory of the Emacs executable, which can never
101 be TRT. In particular, it broke sys_access when called with
102 relative file names.
103 (sys_access): Map GetLastError to errno.
104
2af3565e
DA
1052012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
106
107 * window.h (struct window): Change type of 'fringes_outside_margins'
108 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 109 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
110 Adjust comment.
111 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
112 to ptrdiff_t.
113
c8d3a25c 1142012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 115
c8d3a25c
GM
116 * gnutls.c (emacs_gnutls_handshake):
117 Add QUIT to make the loop interruptible.
57570cd3 118
c8d3a25c 1192012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 120
c8d3a25c
GM
121 * charset.c (init_charset): Make lack of etc/charsets fatal.
122
3e984ee8
DA
1232012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
124
125 * editfns.c (region_limit): Fix type mismatch.
126
ef884f23
DA
1272012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
128
129 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
130 undefined. Convert from xassert to eassert.
131 * nsmenu.m: Convert from xassert to eassert.
132 * nsterm.m: Likewise.
133
7d7e0027
SM
1342012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
135
136 * editfns.c (region_limit): Clip to narrowing (bug#11770).
137
aa754e6a
PE
1382012-06-28 Paul Eggert <eggert@cs.ucla.edu>
139
140 Avoid integer overflow on scroll-left and scroll-right.
141 * window.c (HSCROLL_MAX): New macro.
142 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
143 overflow when requested scroll falls outside ptrdiff_t range.
144
80b00b08
DA
1452012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
146
147 * window.h (struct window): Change type of 'hscroll',
148 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
149 'last_modified' and 'last_overlay_modified' to EMACS_INT.
150 Adjust users accordingly.
151 * xdisp.c (try_cursor_movement): Replace type check with eassert.
152 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
153 from EMACS_INT to ptrdiff_t.
154 (make_window): Omit redundant initialization.
155
62b2bcf6
JB
1562012-06-28 Juanma Barranquero <lekktu@gmail.com>
157
158 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
159
45942c7d
DA
1602012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
161
162 * window.h (struct window): Change type of 'use_time' and
163 'sequence_number' from Lisp_Object to int.
164 * frame.c (make_frame): Adjust users accordingly.
165 * print.c (print_object): Likewise.
166 * window.c (select_window, Fwindow_use_time, make_parent_window)
167 (make_window): Likewise.
168
e509cfa6
DA
1692012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
170
171 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
172 enabled with --enable-checking=[all,glyphs] configure option.
173 Fix GLYPH_DEBUG usage assuming that it may be undefined,
174 adjust comments accordingly.
175 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
176 undefined, adjust comments accordingly.
177 * image.c: Likewise.
178 * scroll.c: Likewise.
179 * w32fns.c: Likewise.
180 * w32term.c: Likewise.
181 * xdisp.c: Likewise.
182 * xfaces.c: Likewise.
183 * xfns.c: Likewise.
184 * xterm.c: Likewise.
185
a54e2c05
DA
1862012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
187
188 Generalize run-time debugging checks.
189 * dispextern.h (XASSERTS): Remove.
190 * fontset.c (xassert): Remove.
191 Convert from xassert to eassert.
192 * alloc.c: Convert from xassert to eassert.
193 * bidi.c: Likewise.
194 * dispnew.c: Likewise.
195 * fns.c: Likewise.
196 * fringe.c: Likewise.
197 * ftfont.c: Likewise.
198 * gtkutil.c: Likewise.
199 * image.c: Likewise.
200 * keyboard.c: Likewise.
201 * menu.c: Likewise.
202 * process.c: Likewise.
203 * scroll.c: Likewise.
204 * sound.c: Likewise.
205 * term.c: Likewise.
206 * w32console.c: Likewise.
207 * w32fns.c: Likewise.
208 * w32term.c: Likewise.
209 * window.c: Likewise.
210 * xdisp.c: Likewise.
211 * xfaces.c: Likewise.
212 * xfns.c: Likewise.
213 * xselect.c: Likewise.
214 * xterm.c: Likewise.
215
1ec4b7b2
SM
2162012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
217
218 * fns.c (maybe_resize_hash_table): Output message when growing the
219 purify-hashtable.
220
2014308a
DA
2212012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
222
223 * alloc.c (allocate_string_data): Remove dead code.
224 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
225 avoid GCC warning about unused macro.
226
246155eb
DA
2272012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
228
229 * alloc.c (allocate_string): Omit intervals initialization.
230 * alloc.c (make_uninit_multibyte_string): Initialize intervals
231 as in make_pure_string and make_pure_c_string.
232
43184b7b
DA
2332012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
234
235 * alloc.c (allocate_string): Fix last change.
236
3fe6dd74
DA
2372012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
238
239 * alloc.c (allocate_string): Remove two redundant calls
240 to memset, add explicit initialization where appropriate.
241
1ba6038a
GM
2422012-06-27 Glenn Morris <rgm@gnu.org>
243
244 * lisp.mk (lisp): Remove paths.elc.
245
c89926a5
CY
2462012-06-27 Chong Yidong <cyd@gnu.org>
247
248 * doc.c (Fsubstitute_command_keys): Fix punctuation.
249
ed6b3510
JW
2502012-06-26 John Wiegley <johnw@newartisans.com>
251
1ec4b7b2 252 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
253 on Mac OS X Lion: __mod_init_func and __mod_term_func.
254
ed6b3510
JW
255 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
256 when building with Clang.
257
8edd4a2b
SM
2582012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
259
260 * eval.c (Fapply): Allow calling it with a single argument.
261
f6f62d1b
EZ
2622012-06-26 Eli Zaretskii <eliz@gnu.org>
263
264 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
265 _stricmp and _strnicmp.
266 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
267
62efea5e
DA
2682012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
269
270 * alloc.c (allocate_window): Zero out non-Lisp part of newly
271 allocated window.
272 (allocate_process): Likewise for new process.
8edd4a2b 273 (allocate_terminal): Change to use offsetof.
62efea5e
DA
274 (allocate_frame): Likewise.
275 * frame.c (make_frame): Omit redundant initialization.
276 * window.c (make_parent_window): Use memset.
277 (make_window): Omit redundant initialization.
278 * process.c (make_process): Omit redundant initialization.
279 * terminal.c (create_terminal): Likewise.
280
42997f4d
DA
2812012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
282
283 * term.c (delete_tty): Remove redundant call to memset.
284
1130ecfc
DA
2852012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
286
287 * alloc.c: Remove build_string.
288 * lisp.h: Define build_string as static inline. This provides
289 a better opportunity to optimize away calls to strlen when the
290 function is called with compile-time constant argument.
291 * image.c (imagemagick_error): Convert to build_string.
292 * w32proc.c (sys_spawnve): Likewise.
293 * xterm.c (x_term_init): Likewise.
294
cf38a720
PE
2952012-06-26 Paul Eggert <eggert@cs.ucla.edu>
296
99027bdd
PE
297 Use sprintf return value instead of invoking strlen on result.
298 In the old days this wasn't portable, since some sprintf
299 implementations returned char *. But they died out years ago and
300 Emacs already assumes sprintf returns int.
301 Similarly for float_to_string.
302 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
303 * ccl.c (ccl_driver):
304 * character.c (string_escape_byte8):
305 * data.c (Fnumber_to_string):
306 * doprnt.c (doprnt):
307 * print.c (print_object):
308 * xdisp.c (message_dolog):
309 * xfns.c (syms_of_xfns):
310 Use sprintf or float_to_string result to avoid need to call strlen.
311 * data.c (Fnumber_to_string):
312 Use make_unibyte_string, since the string must be ASCII.
313 * lisp.h, print.c (float_to_string): Now returns int length.
314 * term.c (produce_glyphless_glyph):
315 Use sprintf result rather than recomputing it.
316
cf38a720
PE
317 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
318 * Makefile.in (ALL_CFLAGS):
319 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
320 * gmalloc.c, regex.c: Include <config.h> unconditionally.
321
3511c784
DA
3222012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
323
0a08eb21 324 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
325 strcasecmp if available.
326 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
327
fb7da12e
AS
3282012-06-25 Andreas Schwab <schwab@linux-m68k.org>
329
330 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
331 Avoid comma operator.
332 * menu.c (push_submenu_start, push_submenu_end)
333 (push_left_right_boundary, push_menu_pane): Likewise.
334 * msdos.c (dos_rawgetc): Likewise.
335
afa2ffd8
DA
3362012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
337
338 * xfns.c (xic_create_fontsetname): Remove redundant calls
339 to memset.
340
b3b4476b
PE
3412012-06-25 Paul Eggert <eggert@cs.ucla.edu>
342
4495ff38
PE
343 * gtkutil.c (get_utf8_string): Remove redundant assignment.
344 sprintf already null-terminates its output.
345
b3b4476b
PE
346 * xfns.c (x_window): Remove redundant cast.
347
b00876c9
DA
3482012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
349
350 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
351 `const char *' to `char *' to avoid compiler warning.
352
d188e26b
PE
3532012-06-24 Paul Eggert <eggert@cs.ucla.edu>
354
885d1d74
PE
355 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
356 instead of truncating it to 63 (admittedly a generous limit).
357
d188e26b
PE
358 * process.c: Fix spelling and caps in comments.
359
e2f560b1
DN
3602012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
361
e86db54b 362 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
363 * sysdep.c (setpgrp): Remove definition, not used in this file.
364
7583a3a1
JB
3652012-06-24 Juanma Barranquero <lekktu@gmail.com>
366
367 * makefile.w32-in: Update dependencies.
368
696056c2
EZ
3692012-06-24 Eli Zaretskii <eliz@gnu.org>
370
371 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
372 (SYSTIME_H): Add nt/inc/sys/time.h.
373
374 * systime.h [WINDOWSNT]: Include sys/time.h.
375
376 * s/ms-w32.h (struct timespec): Definition moved from
377 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
378
845ca893
PE
3792012-06-24 Paul Eggert <eggert@cs.ucla.edu>
380
381 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
382 * buffer.h (buffer_slot_type_mismatch):
383 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
384 * eval.c (unwind_to_catch):
385 * image.c (my_png_error, my_error_exit):
386 * keyboard.c (quit_throw_to_read_char, user_error)
387 (Fexit_recursive_edit, Fabort_recursive_edit):
388 * lisp.h (die, args_out_of_range, args_out_of_range_3)
389 (wrong_type_argument, buffer_overflow, __executable_start)
390 (memory_full, buffer_memory_full, string_overflow, Fthrow)
391 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
392 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
393 (fatal):
394 (child_setup) [!DOS_NT]:
395 * lread.c (end_of_file_error, invalid_syntax):
396 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
397 * puresize.h (pure_write_error):
398 * search.c (matcher_overflow):
399 * sound.c (sound_perror, alsa_sound_perror):
400 * sysdep.c, syssignal.h (croak):
401 * term.c (maybe_fatal, vfatal):
402 * textprop.c (text_read_only):
403 * undo.c (user_error):
404 * unexmacosx.c (unexec_error):
405 * xterm.c (x_ins_del_lines, x_delete_glyphs):
406 Use _Noreturn rather than NO_RETURN.
407 No need for separate decl merely because of _Noreturn.
408 * sound.c (sound_warning, parse_sound):
409 Remove unnecessary forward decls.
410
f1dd8073
PE
4112012-06-24 Paul Eggert <eggert@cs.ucla.edu>
412
413 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
414 * lisp.h (WAIT_READING_MAX): New macro.
415 * dispnew.c (Fsleep_for, sit_for):
416 * keyboard.c (kbd_buffer_get_event):
417 * process.c (Faccept_process_output):
418 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
419 This improves on the previous patch, which introduced a bug
420 when time_t is unsigned and as wide as intmax_t.
421 See <http://bugs.gnu.org/9000#51>.
422
b82c1755
EZ
4232012-06-23 Eli Zaretskii <eliz@gnu.org>
424
425 * dispnew.c (sit_for, Fsleep_for):
426 * keyboard.c (kbd_buffer_get_event):
427 * process.c (Faccept_process_output): Avoid compiler warnings when
428 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
429
ca300656
JB
4302012-06-23 Juanma Barranquero <lekktu@gmail.com>
431
049ec95b
JB
432 * makefile.w32-in: Update dependencies.
433
ca300656
JB
434 * w32.c (ltime): Add return type and declare static.
435 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
436
db7b8d06
PE
4372012-06-23 Paul Eggert <eggert@cs.ucla.edu>
438
439 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
440 Privately reported by Herbert J. Skuhra.
441 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
442 All uses changed.
443 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
444 not make_lisp_timeval, when the argument is of type EMACS_TIME.
445
0bd8297f
EZ
4462012-06-23 Eli Zaretskii <eliz@gnu.org>
447
96512555
EZ
448 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
449 last argument of make_unibyte_string.
450
0bd8297f
EZ
451 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
452 language ID in the event parameters.
453
454 * w32term.c (w32_read_socket): Put the new keyboard codepage into
455 event.code, not the obscure "character set ID".
456
63def6b6
CY
4572012-06-23 Chong Yidong <cyd@gnu.org>
458
459 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
460
e8a02204
EZ
4612012-06-23 Eli Zaretskii <eliz@gnu.org>
462
388cdec0
EZ
463 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
464 * w32.c (fdutimens): New function.
465
466 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
467
468 * s/ms-w32.h (pselect): Redirect to sys_select.
469
470 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
471
e8a02204
EZ
472 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
473 in the logic of incrementing and decrementing the value of
474 use_relocatable_buffers.
475
d054f3fb
PE
4762012-06-23 Paul Eggert <eggert@cs.ucla.edu>
477
478 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
479 Privately reported by Herbert J. Skuhra.
480 [__FreeBSD__]: Remove "*/" typo after "#include".
481 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
482 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
483 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
484 Don't assume EMACS_TIME and struct timeval are the same type.
485
d35af63c
PE
4862012-06-22 Paul Eggert <eggert@cs.ucla.edu>
487
488 Support higher-resolution time stamps (Bug#9000).
489 The time stamps are only nanosecond-resolution at the C level,
490 since that's the best that any real-world system supports now.
491 But they are picosecond-resolution at the Lisp level, as that's
492 easy, and leaves room for future OS improvements.
493
494 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
495 (LIBES): Use it.
496
497 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
498 Don't get current time unless it's needed.
499
500 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
501 now provides it if it's absent.
502 (start_atimer): Port to higher-res time stamps.
503 Check for time stamp overflow. Don't get current time more
504 often than is needed.
505
506 * buffer.h (struct buffer): Buffer modtime now has high resolution.
507 Include systime.h, not time.h.
508 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
509
510 * dired.c: Include stat-time.h.
511 (Ffile-attributes): File times now have higher resolution.
512
513 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
514 (struct image): Timestamp now has higher resolution.
515
516 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
517 has at least microseconds now. All uses removed.
518 (update_frame, update_single_window, update_window, update_frame_1)
519 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
520
521 * editfns.c (time_overflow): Now extern.
522 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
523 (float-time, Fformat_time_string, Fcurrent_time_string)
524 (Fcurrent_time_zone): Accept and generate higher-resolution
525 time stamps.
526 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
527 (decode_time_components, lisp_seconds_argument): New functions.
528 (make_time): Now static.
529 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
530 Report an error if the time is invalid, rather than having the caller
531 do that.
532
533 * fileio.c: Include <stat-time.h>
534 (Fcopy_file): Copy higher-resolution time stamps.
535 Prefer to set the time stamp via a file descriptor if that works.
536 (Fset_file_times, Finsert_file_contents, Fwrite_region)
537 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
538 (Fvisited_file_modtime, Fset_visited_file_modtime):
539 Support higher-resolution time stamps.
540
541 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
542
543 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
544
545 * image.c (prepare_image_for_display, clear_image_cache)
546 (lookup_image): Port to higer-resolution time stamps.
547
548 * keyboard.c (start_polling, bind_polling_period):
549 Check for time stamp overflow.
550 (read_char, kbd_buffer_get_event, timer_start_idle)
551 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
552 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
553 Port to higher-resolution time stamps. Do not assume time_t is signed.
554 (decode_timer): New function. Timers are now vectors of length 9,
555 not 8, to accommodate the picosecond component.
556 (timer_check_2): Use it.
557
558 * nsterm.m (select_timeout, timeval_subtract): Remove.
559 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
560 as they're a bit more accurate and handle overflow better.
561 (ns_select): Change prototype to be compatible with pselect.
562 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
563 * nsterm.h (ns_select): Adjust prototype.
564
565 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
566 us-resolution time stamps.
567 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
568
569 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
570
571 * lisp.h (time_overflow): New decl.
572 (wait_reading_process_output): First arg is now intmax_t, not int,
573 to accommodate larger waits.
574
575 * process.h (struct Lisp_Process.read_output_delay):
576 Now counts nanoseconds, not microseconds.
577 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
578 EMACS_HAS_USECS.
579 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
580 (wait_reading_process_output):
581 Port to ns-resolution time stamps.
582 (Faccept_process_output, wait_reading_process_output):
583 Check for time stamp overflow. Do not assume time_t is signed.
584 (select_wrapper): Remove; we now use pselect.
585 (Fprocess_attributes): Now generates ns-resolution time stamps.
586
587 * sysdep.c: Include utimens.h. Don't include utime.h
588 or worry about struct utimbuf; gnulib does that for us now.
589 (gettimeofday): Remove; gnulib provides a substitute.
590 (make_timeval): New function.
591 (set_file_times): Now sets ns-resolution time stamps.
592 New arg FD; all uses changed.
593 (time_from_jiffies, ltime_from_jiffies, get_up_time)
594 (system_process_attributes):
595 Now returns ns-resolution time stamp. All uses changed.
596 Check for time stamp overflow.
597
598 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
599 provides a substitute now.
600
601 * systime.h: Include timespec.h rather than sys/time.h and time.h,
602 since it guarantees struct timespec.
603 (EMACS_TIME): Now struct timespec, so that we can support
604 ns-resolution time stamps.
605 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
606 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
607 (EMACS_USECS): Remove.
608 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
609 so multiply the arg by 1000 before storing it.
610 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
611 New macros.
612 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
613 Port to ns-resolution time stamps.
614 (EMACS_TIME_NEG_P): Remove; replaced by....
615 (EMACS_TIME_SIGN): New macro.
616 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
617 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
618 (set_file_times, make_time, lisp_time_argument): Adjust signature.
619 (make_timeval, make_lisp_time, decode_time_components): New decls.
620 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
621 that it mishandled time_t overflow. You can't compare by subtracting!
622 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
623 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
624
625 * term.c: Include <sys/time.h>.
626 (timeval_to_Time): New function, for proper overflow wraparound.
627 (term_mouse_position, term_mouse_click): Use it.
628
629 * undo.c (record_first_change): Support higher-resolution time stamps
630 in the undo buffer.
631 (Fprimitive_undo): Use them when restoring time stamps.
632
633 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
634 (w32_get_internal_run_time):
635 Port to higher-resolution Emacs time stamps.
636 (ltime): Now accepts single 64-bit integer, as that's more convenient
637 for callers.
638
639 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
640
641 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
642 for compatibility with pselect. Support ns-resolution time stamps.
643
644 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
645
646 * xselect.c (wait_for_property_change, x_get_foreign_selection):
647 Check for time stamp overflow, and support ns-resolution time stamps.
648
649 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
650 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
651 (timeval_subtract): Remove; no longer needed.
652 (XTflash, XTring_bell, x_wait_for_event):
653 Port to ns-resolution time stamps. Don't assume time_t is signed.
654
b6a92dfe
CY
6552012-06-22 Chong Yidong <cyd@gnu.org>
656
657 * xdisp.c (x_consider_frame_title): Revert last change.
658
d251c37c
EZ
6592012-06-22 Eli Zaretskii <eliz@gnu.org>
660
661 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
662 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
663 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
664 staticidx goes up to 1597 out of 1600 = 0x640.)
665
f10deafb
PE
6662012-06-20 Paul Eggert <eggert@cs.ucla.edu>
667
668 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
669 Otherwise, the umask might be mistakenly 0 while handling input signals.
670
ec6de1e2
SM
6712012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
672
673 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
674
28be1ada
DA
6752012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
676
677 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
678 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
679 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
680 access to `contents' member of Lisp_Vector objects with AREF and ASET
681 where appropriate.
682
c6bf3022
CY
6832012-06-19 Chong Yidong <cyd@gnu.org>
684
685 * frame.c (delete_frame): When selecting a frame on a different
686 text terminal, do not alter the terminal's top-frame.
687
688 * xdisp.c (format_mode_line_unwind_data): Record the target
689 frame's selected window and its terminal's top-frame.
690 (unwind_format_mode_line): Restore them.
691 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
692 Callers changed.
693 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
694 since tty frames can be explicitly named.
695 (prepare_menu_bars): Likewise.
696
697 * term.c (Ftty_top_frame): New function.
698
defd4196
PE
6992012-06-18 Paul Eggert <eggert@cs.ucla.edu>
700
701 Port byte-code-meter to modern targets.
702 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
703 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 704 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
705 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
706 (METER_1, METER_2): Simplify.
707
1053a871
SM
7082012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
709
710 * data.c (Fdefalias): Return `symbol' (bug#11686).
711
b7e8d081
MR
7122012-06-18 Martin Rudalics <rudalics@gmx.at>
713
714 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
715 gets killed during executing of this function (Bug#11665).
716 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
717 (Vkill_buffer_query_functions): In doc-string say that functions
718 run by this hook should not change the current buffer.
719
7ea2b339
PE
7202012-06-18 Paul Eggert <eggert@cs.ucla.edu>
721
722 Fix recently-introduced process.c problems found by static checking.
723 * process.c (write_queue_push, write_queue_pop, send_process):
724 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
725 (write_queue_pop): Fix pointer signedness problem.
726 (send_process): Remove unused local.
727
96a313a1
CY
7282012-06-17 Chong Yidong <cyd@gnu.org>
729
730 * xdisp.c (redisplay_internal): No need to redisplay terminal
731 frames that are not on top.
732
20ca2e94
TN
7332012-06-17 Troels Nielsen <bn.troels@gmail.com>
734
735 * process.c (make_process): Initialize write_queue.
736 (write_queue_push, write_queue_pop): New functions.
737 (send_process): Use them to maintain correct ordering of process
738 writes (Bug#10815).
739
9a900ca9
PE
7402012-06-17 Paul Eggert <eggert@cs.ucla.edu>
741
310fbfa8
PE
742 * lisp.h (eassert): Assume C89 or later.
743 This removes the need for CHECK.
744 (CHECK): Remove. Its comments about always evaluating its
745 argument were confusing, as 'eassert' typically does not evaluate
746 its argument.
747
27bb1ca4
PE
748 * coding.c (produce_chars): Use ptrdiff_t, not int.
749
9a900ca9
PE
750 * xterm.c (x_draw_underwave): Check for integer overflow.
751 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
752
41b7f8bc 7532012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
754
755 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
756 referenced (Bug#11583).
757
9b0e3eba
AA
7582012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
759
760 Implement wave-style variant of underlining.
761 * dispextern.h (face_underline_type): New enum.
762 (face): Add field for underline type.
763 * nsterm.m (ns_draw_underwave): New function.
764 (ns_draw_text_decoration): Use it.
765 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
766 New functions.
767 (x_draw_glyph_string): Use them.
768 * xfaces.c (Qline, Qwave): New Lisp objects.
769 (check_lface_attrs, merge_face_ref)
1053a871
SM
770 (Finternal_set_lisp_face_attribute, realize_x_face):
771 Handle wave-style underline face attributes.
9b0e3eba
AA
772 * xterm.c (x_draw_underwave): New function.
773 (x_draw_glyph_string): Use it.
774
0fb52f11
JB
7752012-06-16 Juanma Barranquero <lekktu@gmail.com>
776
777 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
778 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
779 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
780 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
781 ($(BLD)/w32select.$(O)): Update dependencies.
782
e5560ff7
AS
7832012-06-16 Andreas Schwab <schwab@linux-m68k.org>
784
785 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
786 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
787 * character.c (_fetch_multibyte_char_p): Remove.
788 * alloc.c: Include "character.h" before "buffer.h".
789 * bidi.c: Likewise.
790 * buffer.c: Likewise.
791 * bytecode.c: Likewise.
792 * callint.c: Likewise.
793 * callproc.c: Likewise.
794 * casefiddle.c: Likewise.
795 * casetab.c: Likewise.
796 * category.c: Likewise.
797 * cmds.c: Likewise.
798 * coding.c: Likewise.
799 * composite.c: Likewise.
800 * dired.c: Likewise.
801 * dispnew.c: Likewise.
802 * doc.c: Likewise.
803 * dosfns.c: Likewise.
804 * editfns.c: Likewise.
805 * emacs.c: Likewise.
806 * fileio.c: Likewise.
807 * filelock.c: Likewise.
808 * font.c: Likewise.
809 * fontset.c: Likewise.
810 * fringe.c: Likewise.
811 * indent.c: Likewise.
812 * insdel.c: Likewise.
813 * intervals.c: Likewise.
814 * keyboard.c: Likewise.
815 * keymap.c: Likewise.
816 * lread.c: Likewise.
817 * macros.c: Likewise.
818 * marker.c: Likewise.
819 * minibuf.c: Likewise.
820 * nsfns.m: Likewise.
821 * nsmenu.m: Likewise.
822 * print.c: Likewise.
823 * process.c: Likewise.
824 * regex.c: Likewise.
825 * region-cache.c: Likewise.
826 * search.c: Likewise.
827 * syntax.c: Likewise.
828 * term.c: Likewise.
829 * textprop.c: Likewise.
830 * undo.c: Likewise.
831 * unexsol.c: Likewise.
832 * w16select.c: Likewise.
833 * w32fns.c: Likewise.
834 * w32menu.c: Likewise.
835 * window.c: Likewise.
836 * xdisp.c: Likewise.
837 * xfns.c: Likewise.
838 * xmenu.c: Likewise.
839 * xml.c: Likewise.
840 * xselect.c: Likewise.
841
2f07e6af
EZ
8422012-06-16 Eli Zaretskii <eliz@gnu.org>
843
1053a871
SM
844 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
845 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 846 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
847 row.
848 (handle_face_prop): Use chunk-relative overlay string index when
849 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
850 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
851 the rightmost. (Bug#11720)
2f07e6af 852
29b83cec
AS
8532012-06-16 Andreas Schwab <schwab@linux-m68k.org>
854
855 * category.h (CHAR_HAS_CATEGORY): Define as inline.
856 (CATEGORY_MEMBER): Enforce 1/0 value.
857 * category.c (_temp_category_set): Remove.
858
4c5501e9
EZ
8592012-06-16 Eli Zaretskii <eliz@gnu.org>
860
861 * window.c (Fdelete_other_windows_internal)
862 (Fdelete_window_internal): Don't access frame's mouse highlight
863 info of the initial frame. (Bug#11677)
864
2b570124
PE
8652012-06-14 Paul Eggert <eggert@cs.ucla.edu>
866
e93864f9
PE
867 * .gdbinit (xgetint): Fix recently-introduced paren typo.
868 Assume USE_2_TAGS_FOR_INTS.
869 (xreload): Adjust $tagmask width to match recent lisp.h change.
870
2b570124
PE
871 Simplify lisp.h in minor ways that should not affect code.
872 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
873 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
874 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
875 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
876 (INTTYPEBITS): New macro, for clarity.
877 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
878 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
879 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
880 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
881 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
882
81755f69
JB
8832012-06-13 Juanma Barranquero <lekktu@gmail.com>
884
885 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
886
16192a57
GM
8872012-06-13 Glenn Morris <rgm@gnu.org>
888
889 * s/bsd-common.h (BSD4_3):
890 * s/usg5-4-common.h (USG5_4): No longer define; unused.
891
646b5f55
AS
8922012-06-13 Andreas Schwab <schwab@linux-m68k.org>
893
894 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
895 instead of union.
896 (XLI, XIL): Define.
1053a871
SM
897 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
898 Use them.
899 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 900 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 901 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
902 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
903 * frame.c (delete_frame): Remove outdated comment.
904 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
905 USE_LISP_UNION_TYPE.
906 (Fw32_unregister_hot_key): Likewise.
907 (Fw32_toggle_lock_key): Likewise.
908 * w32menu.c (add_menu_item): Likewise.
909 (w32_menu_display_help): Use XIL instead of checking
910 USE_LISP_UNION_TYPE.
911 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
912 (init_heap): Likewise.
913 * w32term.c (w32_read_socket): Update comment.
914
1d3823c9
GM
9152012-06-13 Glenn Morris <rgm@gnu.org>
916
c62ff706
GM
917 * s/usg5-4-common.h, src/s/unixware.h:
918 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
919
1d3823c9
GM
920 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
921
bfe3e0a2
PE
9222012-06-13 Paul Eggert <eggert@cs.ucla.edu>
923
924 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
925 * alloc.c (make_number) [!defined make_number]:
926 Remove, as lisp.h always defines this now.
927 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
928 (roundup_size): Verify that it is a power of 2.
929 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
930 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
931 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
932 -DUSE_LSB_TAG=0, to override the automatically-selected default.
933 USE_LSB_TAG now is always defined to be either 0 or 1.
934 All uses changed.
935 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
936 code works fine either way, and efficiency is not a concern here,
937 as the union type is for debugging, not for production.
938 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
939 Use an inline function on all platforms when using the union type,
940 since this is simpler and 'static inline' can be used portably
941 within Emacs now.
942 (LISP_INITIALLY_ZERO): New macro.
943 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
944 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
945
45fa9c0f
GM
9462012-06-12 Glenn Morris <rgm@gnu.org>
947
b4492cba
GM
948 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
949
950 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 951
45fa9c0f
GM
952 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
953 Move BROKEN_SIGIO to configure.
954
955 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
956 Move NO_TERMIO to configure.
957
0e25d334
CY
9582012-06-12 Chong Yidong <cyd@gnu.org>
959
960 * image.c (imagemagick_load_image): Use MagickFlattenImage if
961 MagickMergeImageLayers is undefined. Use pixel pusher loop if
962 MagickExportImagePixels is undefined.
963
43682bb6
PE
9642012-06-12 Paul Eggert <eggert@cs.ucla.edu>
965
966 * image.c (imagemagick_load_image): Remove unused label.
967
a9be7d2b
GM
9682012-06-11 Glenn Morris <rgm@gnu.org>
969
970 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
971 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
972 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
973 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
974
3017f87f
SM
9752012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
976
977 * alloc.c (make_byte_code): New function.
978 (Fmake_byte_code): Use it. Don't purify here.
979 * lread.c (read1): Use it as well to avoid extra allocation.
980
1b9b4cf4
CY
9812012-06-11 Chong Yidong <cyd@gnu.org>
982
983 * image.c (imagemagick_load_image): Implement transparency.
984
95988fcf
AS
9852012-06-10 Andreas Schwab <schwab@linux-m68k.org>
986
987 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
988 account for preceding backslashes. (Bug#11663)
989
cd4eb164
CY
9902012-06-09 Chong Yidong <cyd@gnu.org>
991
992 * term.c: Support italics in capable terminals (Bug#9652).
993 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
994 (turn_on_face): Output using TS_enter_italic_mode if available.
995 Don't handle unused blinking and alt-charset cases.
996 (turn_off_face): Handle italic case; discard unused tty_blinking_p
997 and tty_alt_charset_p cases.
998 (tty_capable_p, init_tty): Support italics.
999
1000 * termchar.h (struct tty_display_info): Add field for italics.
1001 Remove unused blink field.
1002
1003 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1004 Handle slant.
1005
1006 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1007 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1008 tty_alt_charset_p. Add tty_italic_p.
1009
ff88beb8
MA
10102012-06-09 Michael Albinus <michael.albinus@gmx.de>
1011
1012 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1013 dbus_type_is_basic if available.
1014 (xd_extract_signed, xd_extract_unsigned): Rename from
1015 extract_signed and extract_unsigned, respectively. Adapt callers.
1016
44286096
CY
10172012-06-09 Chong Yidong <cyd@gnu.org>
1018
1682701f
CY
1019 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1020
44286096
CY
1021 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1022 case (Bug#9752).
1023
d86feb17
PE
10242012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 * xdisp.c (vmessage): Treat frame message as multibyte.
1027 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1028 would generate the diagnostic "Making \302\247 buffer-local while
1029 let-bound!".
1030
d5c20fe8
EZ
10312012-06-08 Eli Zaretskii <eliz@gnu.org>
1032
1033 * dispnew.c (showing_window_margins_p): Undo last change, which
1034 was done due to an inadvertent commit.
1035 (adjust_frame_glyphs_for_frame_redisplay): Do call
1036 showing_window_margins_p.
1037
513749ee
SM
10382012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1039
1040 * eval.c (Fmake_var_non_special): New primitive.
1041 (syms_of_eval): Defsubr it.
1042 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1043
d4a8f5c1
JB
10442012-06-08 Juanma Barranquero <lekktu@gmail.com>
1045
1046 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1047 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1048
8bbbc977
EZ
10492012-06-08 Eli Zaretskii <eliz@gnu.org>
1050
1051 * alloc.c (allocate_vectorlike): Fix last change.
1052
f3372c87
DA
10532012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1054
1055 Block-based vector allocation of small vectors.
1056 * lisp.h (struct vectorlike_header): New field `nbytes',
1057 adjust comment accordingly.
1058 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1059 to denote vector blocks. Adjust users (live_vector_p,
1060 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1061 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1062 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1063 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1064 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1065 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1066 (roundup_size): New constant.
1067 (struct vector_block): New data type.
1068 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1069 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1070 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1071 (sweep_vectors): New functions.
1072 (allocate_vectorlike): Return `zero_vector' as the only vector of
1073 0 items. Allocate new vector from block if vector size is less than
1074 or equal to VBLOCK_BYTES_MAX.
1075 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1076 (init_alloc_once): Add call to init_vectors.
1077
4f18a4ed
SM
10782012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1079
1080 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1081
86f158bc
PE
10822012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1083
1084 * doprnt.c (doprnt): Truncate multibyte char correctly.
1085 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1086 would mishandle a string argument "Xc" if X was a multibyte
1087 character of length 2: it would truncate after X's first byte
1088 rather than including all of X.
1089
c5cfcbe0
CY
10902012-06-06 Chong Yidong <cyd@gnu.org>
1091
1092 * buffer.c (word_wrap): Doc fix.
1093
c05cf390
PE
10942012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1095
1096 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1097
0c3461de
GM
10982012-06-03 Glenn Morris <rgm@gnu.org>
1099
1100 * xdisp.c (tool-bar-style): Doc fix.
1101
c71232db
UM
11022012-06-03 Ulrich Müller <ulm@gentoo.org>
1103
1104 * Makefile.in (PAXCTL): Define.
1105 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1106 binary via PaX flags if the paxctl utility is available.
1107 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1108 Restore PaX flags to their default. (Bug#11398)
1109
383f7350
CY
11102012-06-03 Chong Yidong <cyd@gnu.org>
1111
1112 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1113 buffer (Bug#11226).
1114
5f2c76c6
CY
11152012-06-03 Chong Yidong <cyd@gnu.org>
1116
1117 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1118 (note_mode_line_or_margin_highlight): If there is no help echo,
1119 use mode-line-default-help-echo. Handle the case where the mouse
1120 position is past the end of the mode line string.
1121
1122 * buffer.c (buffer_local_value_1): New function, split from
1123 Fbuffer_local_value; can return Qunbound.
1124 (Fbuffer_local_value): Use it.
1125 (Vmode_line_format): Docstring tweaks.
1126
773d47f6
PE
11272012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1128
1129 * sysdep.c (system_process_attributes): Improve comment.
1130
f2d6a3df
SM
11312012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1132
1133 * keyboard.c: Export real-this-command to Elisp.
1134 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1135 and DEFVAR it. Update all users.
1136
63810350
PE
11372012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1138
7bd5c1f4
PE
1139 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1140
63810350
PE
1141 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1142 Convert pctcpu and pctmem to Lisp float properly.
1143 Let the compiler fold better, as 100.0/0x8000 is exact.
1144
a2821611
AS
11452012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1146
1147 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1148 cons_block.
1149
5fceba1d
PE
11502012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1151
1152 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1153
c98ff5dd
DA
11542012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1155
1156 For a 'struct window', replace some Lisp_Object fields to
1157 bitfields where appropriate, remove unused fields.
1158 * window.h (struct window): Remove unused 'last_mark_x' and
1159 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1160 change it's type from Lisp_Object to bitfield.
1161 Change type of 'force_start', 'optional_new_start',
1162 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1163 fields from Lisp_Object to bitfield. Adjust users accordingly.
1164
ca34e0be
PE
11652012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1166
1167 Pacify gcc -Wdouble-precision when using Xaw.
1168 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1169 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1170 Use 'float' consistently, rather than 'float' in most places
1171 and 'double' in a couple of places.
1172
efc00ab1 11732012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1174
1175 * xdisp.c (handle_stop): Detect whether we have overlay strings
1176 loaded by testing it->current.overlay_string_index to be
1177 non-negative, instead of checking whether n_overlay_strings is
1178 positive. (Bug#11587)
1179
efc00ab1 11802012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1181
1182 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1183
1184 * doc.c (Fsubstitute_command_keys): Doc fix.
1185
efc00ab1 11862012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1187
1188 * search.c (search_buffer): Remove calls to
1189 r_alloc_inhibit_buffer_relocation, as it is now called by
1190 maybe_unify_char, which was the cause of relocation of buffer text
1191 in bug#11519.
1192
efc00ab1 11932012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1194
1195 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1196 for the duration of call to load_charset, to avoid problems with
1197 callers of maybe_unify_char that access buffer text through C
1198 pointers.
1199
1200 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1201 decrement the inhibition flag, instead of just setting or
1202 resetting it.
1203
ba93a187
PE
12042012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1205
1206 Remove obsolete '#define static' cruft.
1207 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1208 This #undef was "temporary" in 2000; it is no longer needed
1209 now that '#define static' has gone away.
1210 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1211 (gray_bitmap_bits): Remove; no longer needed.
1212 All uses replaced with definiens.
1213 * xterm.c: Include "bitmaps/gray.xbm".
1214
9e4bf381
PE
12152012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1216
1217 Clean up __executable_start, monstartup when --enable-profiling.
1218 The following changes affect the code only when profiling.
1219 * dispnew.c (__executable_start): Rename from safe_bcopy.
1220 Define only on platforms that need it.
1221 * emacs.c: Include <sys/gmon.h> when profiling.
1222 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1223 (__executable_start): Remove decl, since lisp.h does it now.
1224 (safe_bcopy): Remove decl; no longer has that name.
1225 (main): Coalesce #if into single bit of code, for simplicity.
1226 Cast pointers to uintptr_t, since standard libraries want integers
1227 and not pointers.
1228 * lisp.h (__executable_start): New decl.
1229
32d72c2f
GM
12302012-05-31 Glenn Morris <rgm@gnu.org>
1231
1232 * image.c (Fimagemagick_types): Doc fix.
1233
baac5bc7
JM
12342012-05-30 Jim Meyering <meyering@redhat.com>
1235
1236 * callproc.c (Fcall_process_region): Include directory component
1237 in mkstemp error message (Bug#11586).
1238
72cb32cf
PE
12392012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1240
1241 * alloc.c, lisp.h (make_pure_vector): Now static.
1242
61b108cc
SM
12432012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1244
1245 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1246 Move to byte-run.el.
1247 (Fautoload): Do the hash-doc more carefully.
1248 * data.c (Fdefalias): Purify definition, except for keymaps.
1249 (Qdefun): Move from eval.c.
1250 * lisp.h (Qdefun): Remove.
1251 * lread.c (read1): Tiny simplification.
1252
471fe23d
TN
12532012-05-29 Troels Nielsen <bn.troels@gmail.com>
1254
934f3f58 1255 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1256 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1257 Bug#9642, but explicitly check that the buffer the overlay would
1258 be moved to is live and rearrange lines to make sure that errors
1259 will not put the overlay in an inconsistent state.
1260 (Fdelete_overlay): Cosmetics.
1261
85d0efd1
EZ
12622012-05-28 Eli Zaretskii <eliz@gnu.org>
1263
1264 * w32term.c (my_bring_window_to_top): New function.
1265 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1266 could be different from the original one.
1267 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1268 (Bug#11513)
1269
1270 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1271 by calling BringWindowToTop.
1272
1273 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1274 (WM_EMACS_END): Increase by one.
1275
da92a98c
PE
12762012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1277
1278 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1279 This avoids undefined behavior that might cause the eassert
1280 to not catch an out-of-range value.
1281
74d1f848
JB
12822012-05-28 Juanma Barranquero <lekktu@gmail.com>
1283
1284 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1285 Update dependencies.
1286
9e1a06fc
EZ
12872012-05-27 Eli Zaretskii <eliz@gnu.org>
1288
1289 * bidi.c (bidi_mirror_char): Fix last change.
1290
f3dd7312
AS
12912012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1292
1293 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1294 when referring to sectname field in printf format.
1295
81899c91
PE
12962012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1297
57b81a9f
PE
1298 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1299 Only r_alloc_inhibit_buffer_relocation needed to be added;
1300 the others were already declared.
1301
81899c91
PE
1302 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1303 before checking whether it's out of range. Put the check inside
1304 eassert. See
1305 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1306
33017faf 13072012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1308
1309 * callproc.c (Fcall_process): Restore a line that was accidentally
1310 commented out in the 2011-02-13 change (bug#11547).
1311
33017faf 13122012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1313
1314 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1315 defined on ralloc.c.
1316
1317 * buffer.c [REL_ALLOC]: Remove prototypes of
1318 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1319 they are now on lisp.h.
1320
1321 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1322
1323 * search.c (search_buffer): Use it to inhibit relocation of buffer
1324 text while re_search_2 is doing its job, because re_search_2 is
1325 passed C pointers to buffer text. (Bug#11519)
1326
23415acf
EZ
1327 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1328 Update value to 24.
1329
44e27368
EZ
1330 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1331 state after an additional call to move_it_in_display_line_to, keep
1332 the values of it->max_ascent and it->max_descent found for the
1333 entire line.
1334 (pos_visible_p): Revert the comparison against bottom_y to what it
1335 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1336 (Bug#11464)
1337
c1892f11
PE
13382012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1339
1340 Fix coding-related core dumps with gcc -ftrapv.
1341 The code was computing A - B, where A and B are pointers, and B is
1342 random garbage. This can lead to core dumps on platforms that
1343 have special pointer registers, and it also leads to core dumps on
1344 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1345 A - B only when B is initialized properly.
1346 * coding.c (coding_set_source, coding_set_destination): Return void.
1347 (coding_change_source, coding_change_destinations): New functions,
1348 with the old behaviors of coding_set_source and coding_set_destination.
1349 All callers that need an offset changed to use these new functions.
1350
eb7afdad
GM
13512012-05-26 Glenn Morris <rgm@gnu.org>
1352
1353 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1354
f12fdf02
EZ
13552012-05-26 Eli Zaretskii <eliz@gnu.org>
1356
53a63be6 1357 Extend mouse support on W32 text-mode console.
61b108cc
SM
1358 * xdisp.c (draw_row_with_mouse_face):
1359 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1360
eb3f6f01 1361 * w32console.c: Include window.h.
61b108cc
SM
1362 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1363 New functions.
eb3f6f01
EZ
1364 (initialize_w32_display): Initialize mouse-highlight data.
1365
53a63be6
EZ
1366 * w32inevt.c: Include termchar.h and window.h.
1367 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1368 moves, call note_mouse_highlight. If help_echo changed, call
1369 gen_help_event to produce help-echo message in the echo area.
1370 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1371 highlight info.
1372
4cfd81f6
PE
13732012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1374
1375 * lread.c (read1): Simplify slightly to avoid an overflow warning
1376 with GCC 4.7.0 on x86-64.
1377
4446092a
EZ
13782012-05-26 Eli Zaretskii <eliz@gnu.org>
1379
1380 * bidi.c (bidi_mirror_char): Revert last change: an int is
1381 definitely wide enough here.
1382
42b2a986 13832012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1384
42b2a986 1385 Fix integer width and related bugs (Bug#9874).
eb106a49 1386 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1387 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1388 (string_bytes, check_sblock, allocate_string_data):
1389 (compact_small_strings, Fmake_bool_vector, make_string)
1390 (make_unibyte_string, make_multibyte_string)
1391 (make_string_from_bytes, make_specified_string)
1392 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1393 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1394 (mark_vectorlike):
1395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1396 (allocate_pseudovector):
1397 Use int, not EMACS_INT, where int is wide enough.
1398 (inhibit_garbage_collection, Fgarbage_collect):
1399 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1400 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1401 int might not be wide enough.
1402 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1403 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1404 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1405 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1406 (bidi_level_of_next_char, bidi_move_to_visually_next):
1407 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1408 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1409 (Fkill_buffer, Fset_buffer_major_mode)
1410 (advance_to_char_boundary, Fbuffer_swap_text)
1411 (Fset_buffer_multibyte, overlays_at, overlays_in)
1412 (overlay_touches_p, struct sortvec, record_overlay_string)
1413 (overlay_strings, recenter_overlay_lists)
1414 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1415 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1416 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1417 (Foverlay_recenter, last_overlay_modification_hooks_used)
1418 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1420 (validate_region): Omit unnecessary test for b <= e,
1421 since that's guaranteed by the previous test.
d311d28c
PE
1422 (adjust_overlays_for_delete): Avoid pos + length overflow.
1423 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1424 (report_overlay_modification):
1425 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1426 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1427 Omit pointer cast, which isn't needed anyway, and doesn't work
1428 after the EMACS_INT -> ptrdiff_t change.
02481186 1429 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1430 * buffer.h: Adjust decls to match defn changes elsewhere.
1431 (struct buffer_text, struct buffer):
1432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1433 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1434 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1435 not int, to avoid needless 32-bit limit on 64-bit hosts.
1436 (exec_byte_code): Use tighter memory-full test, one that checks
1437 for alloca overflow. Don't compute the address of the object just
1438 before an array, as that's not portable. Use EMACS_INT, not
1439 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1440 * callint.c (Fcall_interactively):
1441 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1442 * callproc.c (call_process_kill, Fcall_process):
1443 Don't assume pid_t fits into an Emacs fixnum.
1444 (call_process_cleanup, Fcall_process, child_setup):
1445 Don't assume pid_t fits into int.
1446 (call_process_cleanup, Fcall_process, delete_temp_file)
1447 (Fcall_process_region):
1448 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1449 (Fcall_process): Simplify handling of volatile integers.
1450 Use int, not EMACS_INT, where int will do.
1451 * casefiddle.c (casify_object, casify_region, operate_on_word)
1452 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1454 (casify_object): Avoid integer overflow when overallocating buffer.
1455 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1456 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1457 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1458 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1459 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1460 integers are now checked earlier. All uses replaced with XINT.
1461 (ccl_driver):
1462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1463 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1464 (ccl_driver, Fregister_code_conversion_map):
1465 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1466 (resolve_symbol_ccl_program): Check that vector header is in range.
1467 Always copy the vector, so that we can check its contents reliably
1468 now rather than having to recheck each instruction as it's being
1469 executed. Check that vector words fit in 'int'.
1470 (ccl_get_compiled_code, Fregister_ccl_program)
1471 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1472 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1473 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1474 contents are in range.
1475 (Fccl_execute_on_string): Check that status is in range.
1476 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1477 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1478 Accept and return EMACS_INT, not int, because callers can pass values
1479 out of 'int' range.
1480 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1481 (multibyte_chars_in_text, parse_str_as_multibyte)
1482 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1483 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1484 (string_escape_byte8, Fget_byte):
1485 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1486 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1487 avoid mishandling large integers.
1488 * character.h: Adjust decls to match defn changes elsewhere.
1489 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1490 (Ffind_charset_region):
1491 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1492 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1493 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1494 Don't assume fixnum fits in int.
d311d28c
PE
1495 (load_charset_map_from_vector, Fmap_charset_chars):
1496 Remove now-unnecessary CHECK_NATNUMs.
1497 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1498 Don't rely on undefined behavior with signed left shift overflow.
1499 Don't assume unsigned int fits into fixnum, or that fixnum fits
1500 into unsigned int. Don't require max_code to be a valid fixnum;
1501 that's not true for gb10830 4-byte on a 32-bit host. Allow
1502 invalid_code to be a cons, for the same reason. Require code_offset
1503 to be a character. Avoid int overflow if max_char is close
1504 to INT_MAX.
1505 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1506 this is intended anyway and avoids some undefined behavior.
1507 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1508 INDEX_TO_CODE_POINT, as that's what it expects.
1509 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1510 * charset.h (DECODE_CHAR): Return int, not unsigned;
1511 this is what was intended anyway, and it avoids undefined behavior.
1512 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1513 integer-overflow issues.
1514 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1515 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1516 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1517 * chartab.c (Fmake_char_table, Fset_char_table_range)
1518 (uniprop_get_decoder, uniprop_get_encoder):
1519 Don't assume fixnum fits in int.
1520 * cmds.c (move_point): New function, that does the gist of
1521 Fforward_char and Fbackward_char, but does so while checking
1522 for integer overflow more accurately.
c96e5d6a 1523 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1524 (Fforward_line, Fend_of_line, internal_self_insert)
1525 (internal_self_insert):
1526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1527 Fix a FIXME, by checking for integer overflow when calculating
1528 target_clm and actual_clm.
1529 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1530 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1531 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1532 (coding_alloc_by_making_gap, alloc_destination)
1533 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1534 (encode_coding_utf_16, detect_coding_emacs_mule)
1535 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1536 (detect_coding_iso_2022, decode_coding_iso_2022)
1537 (encode_invocation_designation, encode_designation_at_bol)
1538 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1539 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1540 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1541 (encode_coding_ccl, encode_coding_raw_text)
1542 (detect_coding_charset, decode_coding_charset)
1543 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1544 (produce_composition, produce_charset, produce_annotation)
1545 (decode_coding, handle_composition_annotation)
1546 (handle_charset_annotation, consume_chars, decode_coding_gap)
1547 (decode_coding_object, encode_coding_object, detect_coding_system)
1548 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1549 (code_convert_region, code_convert_string)
8f50130c
PE
1550 (Fdefine_coding_system_internal)
1551 (coding_set_source, coding_set_destination):
d311d28c
PE
1552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1553 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1554 (Fdefine_coding_system_internal):
1555 Don't assume fixnums fit in int.
1556 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1557 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1558 (Funencodable_char_position, Fcheck_coding_systems_region)
1559 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1560 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1561 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1562 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1563 Don't access memory outside of the args array.
d311d28c 1564 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1565 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1566 result of ENCODE_CHAR.
d311d28c
PE
1567 * coding.h: Adjust decls to match defn changes elsewhere.
1568 (struct coding_system):
1569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1570 * composite.c (get_composition_id, find_composition)
1571 (run_composition_function, update_compositions)
1572 (compose_text, composition_gstring_put_cache)
1573 (composition_gstring_p, composition_gstring_width)
1574 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1575 (composition_compute_stop_pos, composition_reseat_it)
1576 (composition_update_it, struct position_record)
1577 (find_automatic_composition, composition_adjust_point)
1578 (Fcomposition_get_gstring, Ffind_composition_internal):
1579 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1580 (update_compositions):
1581 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1582 * composite.h: Adjust decls to match defn changes elsewhere.
1583 (struct composition):
1584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1585 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1586 Do not attempt to compute the address of the object just before a
1587 buffer; this is not portable.
1588 (Faref, Faset):
1589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1590 (Faset): Use int, not EMACS_INT, where int is wide enough.
1591 (Fstring_to_number): Don't assume fixnums fit in int.
1592 (Frem): Don't assume arg is nonnegative.
1593 * dbusbind.c (xd_append_arg): Check for integers out of range.
1594 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1595 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1596 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1597 (xd_get_connection_references): Return ptrdiff_t, not int.
1598 All uses changed.
1599 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1600 (xd_read_message_1):
1601 Use int, not unsigned, where the dbus API uses int.
1602 (Fdbus_message_internal): Don't overflow mtype.
1603 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1604 * dired.c (directory_files_internal, file_name_completion, scmp)
1605 (file_name_completion_stat):
1606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1607 (file_name_completion): Don't overflow matchcount.
1608 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1609 * dispextern.h: Adjust decls to match defn changes elsewhere.
1610 (struct text_pos, struct glyph, struct bidi_saved_info)
1611 (struct bidi_string_data, struct bidi_it, struct composition_it)
1612 (struct it):
1613 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1614 (struct display_pos, struct composition_it, struct it):
1615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1616 * dispnew.c (increment_matrix_positions)
1617 (increment_row_positions, mode_line_string)
1618 (marginal_area_string):
1619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1620 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1622 (duration_to_sec_usec): New function, to check for overflow better.
1623 (Fsleep_for, sit_for): Use it.
1624 * doc.c (get_doc_string, store_function_docstring):
1625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1626 (get_doc_string, Fsnarf_documentation):
1627 Use int, not EMACS_INT, where int is wide enough.
1628 (get_doc_string):
1629 Use SAFE_ALLOCA, not alloca.
1630 Check for overflow when converting EMACS_INT to off_t.
1631 * doprnt.c (doprnt):
1632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1633 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1634 Don't assume uid_t fits into fixnum.
1635 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1636 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1637 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1638 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1639 (general_insert_function)
1640 (Finsert_char, make_buffer_string, make_buffer_string_both)
1641 (update_buffer_properties, Fbuffer_substring)
1642 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1643 (Fsubst_char_in_region, check_translation)
1644 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1645 (transpose_markers, Ftranspose_regions):
1646 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1647 (clip_to_bounds): Move to lisp.h as an inline function).
1648 (Fconstrain_to_field): Don't assume integers are nonnegative.
1649 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1650 (Fsubst_char_in_region, Fsave_restriction):
1651 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1652 (Femacs_pid): Don't assume pid_t fits into fixnum.
1653 (lo_time): Use int, not EMACS_INT, when int suffices.
1654 (lisp_time_argument): Check for usec out of range.
1655 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1656 (Fuser_login_name, Fuser_full_name): Signal an error
1657 if a uid argument is out of range, rather than relying on
1658 undefined behavior.
c8d5c857
PE
1659 (Fformat_time_string): Remove now-unnecessary check.
1660 lisp_time_argument checks for out-of-range usec now.
243e0530 1661 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1662 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1663 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1664 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1665 (init_cmdargs, Fdump_emacs):
1666 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1667 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1668 the bottom (typically) 32 bits of the fixnum.
1669 * eval.c (specpdl_size, call_debugger):
1670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1671 (when_entered_debugger, Fbacktrace_debug):
1672 Don't assume fixnum can fit in int.
1673 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1674 the object just before a buffer; this is not portable.
1675 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1676 (grow_specpdl, unbind_to):
1677 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1678 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1679 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1680 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1681 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1682 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1684 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1685 (a_write, e_write):
1686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1687 (Fcopy_file, non_regular_nbytes, read_non_regular)
1688 (Finsert_file_contents):
1689 Use int, not EMACS_INT, where int is wide enough.
1690 (READ_BUF_SIZE): Verify that it fits in int.
1691 (Finsert_file_contents): Check that counts are in proper range,
1692 rather than assuming fixnums fit into ptrdiff_t etc.
1693 Don't assume fixnums fit into int.
125b3835 1694 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1695 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1696 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1697 (string_char_to_byte, string_byte_to_char)
1698 (string_make_multibyte, string_to_multibyte)
1699 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1700 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1701 (substring_both, Fdelete, internal_equal, Ffillarray)
1702 (Fclear_string, mapcar1)
1703 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1704 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1705 (larger_vector, make_hash_table, maybe_resize_hash_table)
1706 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1707 (Fmaphash, secure_hash):
1708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1709 (concat): Check for string index and length overflow.
1710 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1711 (Frequire):
1712 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1713 (larger_vector): New API (vec, incr_min, size_max) replaces old
1714 one (vec, new_size, init). This catches size overflow.
1715 INIT was removed because it was always Qnil.
1716 All callers changed.
1717 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1718 the upper bound on a hash table index size.
1719 (make_hash_table, maybe_resize_hash_table): Use it.
1720 (secure_hash): Computer start_byte and end_byte only after
1721 they're known to be in ptrdiff_t range.
1722 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1723 (Ffont_get_glyphs, Ffont_at):
1724 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1725 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1726 (Flist_fonts, Fopen_font):
1727 Don't assume fixnum can fit in int.
1728 (check_gstring): Don't assume index can fit in int.
1729 (font_match_p): Check that fixnum is a character, not a nonnegative
1730 fixnum, since the later code needs to stuff it into an int.
1731 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1732 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1733 conversion overflow issues.
1734 (Fopen_font): Check for integer out of range.
1735 (Ffont_get_glyphs): Don't assume index can fit in int.
1736 * font.h: Adjust decls to match defn changes elsewhere.
1737 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1738 integer overflow.
1739 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1740 printmax_t, where ptrdiff_t is wide enough.
1741 (Finternal_char_font):
1742 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1743 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1744 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1745 (Fset_frame_position, x_set_frame_parameters)
1746 (x_set_line_spacing, x_set_border_width)
1747 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1748 Check that fixnums are in proper range for system types.
1749 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1751 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1752 Use SAFE_ALLOCA_LISP, not alloca.
1753 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1754 intptr_t is wide enough.
1755 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1756 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1757 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1758 Check for fixnum out of range.
1759 * ftfont.c (ftfont_list): Don't assume index fits in int.
1760 Check that fixnums are in proper range for system types.
1761 (ftfont_shape_by_flt):
1762 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1763 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1764 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1765 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1766 Check that fixnums are in proper range for system types.
1767 * gnutls.h: Adjust decls to match defn changes elsewhere.
1768 * gtkutil.c (xg_dialog_run):
1769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1770 (update_frame_tool_bar):
1771 Check that fixnums are in proper range for system types.
1772 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1773 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1774 * indent.c (last_known_column, last_known_column_point):
1775 (current_column_bol_cache):
1776 (skip_invisible, current_column, check_display_width):
1777 (check_display_width, scan_for_column, current_column_1)
1778 (Findent_to, Fcurrent_indentation, position_indentation)
1779 (indented_beyond_p, Fmove_to_column, compute_motion):
1780 (Fcompute_motion, Fvertical_motion):
1781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1782 (last_known_column_modified): Use EMACS_INT, not int.
1783 (check_display_width):
1784 (Fcompute_motion):
1785 Check that fixnums and floats are in proper range for system types.
1786 (compute_motion): Don't assume index or fixnum fits in int.
1787 (compute_motion, Fcompute_motion):
1788 Use int, not EMACS_INT, when it is wide enough.
1789 (vmotion): Omit local var start_hpos that is always 0; that way
1790 we don't need to worry about overflow in expressions involving it.
1791 * indent.h: Adjust decls to match defn changes elsewhere.
1792 (struct position):
1793 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1794 Use int, not EMACS_INT, where int is wide enough.
1795 Remove unused members ovstring_chars_done and tab_offset;
1796 all uses removed.
1797 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1798 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1799 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1800 (make_gap, copy_text, insert, insert_and_inherit)
1801 (insert_before_markers, insert_before_markers_and_inherit)
1802 (insert_1, count_combining_before, count_combining_after)
1803 (insert_1_both, insert_from_string)
1804 (insert_from_string_before_markers, insert_from_string_1)
1805 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1806 (adjust_after_replace, adjust_after_insert, replace_range)
1807 (replace_range_2, del_range, del_range_1, del_range_byte)
1808 (del_range_both, del_range_2, modify_region)
1809 (prepare_to_modify_buffer, signal_before_change)
1810 (signal_after_change, Fcombine_after_change_execute):
1811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1812 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1813 (balance_an_interval, split_interval_right, split_interval_left)
1814 (find_interval, next_interval, update_interval)
1815 (adjust_intervals_for_insertion, delete_node, delete_interval)
1816 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1817 (static_offset_intervals, offset_intervals)
1818 (merge_interval_right, merge_interval_left, make_new_interval)
1819 (graft_intervals_into_buffer, temp_set_point_both)
1820 (temp_set_point, set_point, adjust_for_invis_intang)
1821 (set_point_both, move_if_not_intangible, get_property_and_range)
1822 (get_local_map, copy_intervals, copy_intervals_to_string)
1823 (compare_string_intervals, set_intervals_multibyte_1):
1824 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1825 * intervals.h: Adjust decls to match defn changes elsewhere.
1826 (struct interval):
1827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1828 * keyboard.c (this_command_key_count, this_single_command_key_start)
1829 (before_command_key_count, before_command_echo_length, echo_now)
1830 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1831 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1832 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1833 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1834 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1835 (last_non_minibuf_size, last_point_position, echo_truncate)
1836 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1837 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1838 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1839 (stuff_buffered_input):
1840 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1841 (last_auto_save, command_loop_1, read_char):
1842 Use EMACS_INT, not int, to avoid integer overflow.
1843 (record_char): Avoid overflow in total_keys computation.
1844 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1845 * keyboard.h: Adjust decls to match defn changes elsewhere.
1846 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1847 (Fkey_description, Fdescribe_vector, Flookup_key):
1848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1849 (click_position): New function, to check that positions are in range.
1850 (Fcurrent_active_maps):
1851 (describe_command):
1852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1853 (Faccessible_keymaps, Fkey_description):
1854 (preferred_sequence_p):
1855 Don't assume fixnum can fit into int.
1856 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1857 Check for integer overflow in size calculations.
1858 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1859 avoid mishandling large integers.
1860 * lisp.h: Adjust decls to match defn changes elsewhere.
1861 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1862 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1863 (struct Lisp_Marker):
1864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1865 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1866 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1867 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1868 All callers changed.
1869 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1870 Assume the arg has valid form, since it always does.
1871 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1872 unsigned integer system type.
1873 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1874 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1875 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1876 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1877 (duration_to_sec_usec): New decl.
1878 * lread.c (read_from_string_index, read_from_string_index_byte)
1879 (read_from_string_limit, readchar, unreadchar, openp)
1880 (read_internal_start, read1, oblookup):
1881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1882 (Fload, readevalloop, Feval_buffer, Feval_region):
1883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1884 (openp): Check for out-of-range argument to 'access'.
1885 (read1): Use int, not EMACS_INT, where int is wide enough.
1886 Don't assume fixnum fits into int.
6efdadfd 1887 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1888 (read_filtered_event): Use duration_to_sec_usec
1889 to do proper overflow checking on durations.
d311d28c
PE
1890 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1891 in size calculation.
1892 (Fexecute_kbd_macro):
1893 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1894 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1895 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1896 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1897 (set_marker_both, set_marker_restricted_both, marker_position)
1898 (marker_byte_position, Fbuffer_has_markers_at):
1899 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1900 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1901 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1902 It now merely ensures that the menu is large enough, without
1903 necessarily growing it, as this avoids some integer overflow issues.
1904 All callers changed.
1905 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1906 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1907 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1908 Use SAFE_ALLOCA_LISP, not alloca.
1909 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1910 to EMACS_INT. Check that fixnums are in proper range for system types.
1911 * minibuf.c (minibuf_prompt_width, string_to_object)
1912 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1913 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1915 (get_minibuffer, read_minibuf_unwind):
1916 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1917 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1918 this simplifies overflow checking. All callers changed.
1919 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1920 (Ftest_completion):
1921 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1922 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1923 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1924 Check that fixnums are in proper range for system types.
1925 (Fx_create_frame, Fx_show_tip):
1926 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1927 * nsfont.m (ns_findfonts, nsfont_list_family):
1928 Don't assume fixnum fits in long.
1929 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1931 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1932 wide enough.
17fdb222 1933 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1935 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1936 (PRINTDECLARE, PRINTPREPARE):
1937 (strout, print_string):
1938 (print, print_preprocess, print_check_string_charset_prop)
1939 (print_object):
1940 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1941 (PRINTDECLARE):
1942 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1943 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1944 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1945 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1946 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1947 (print_error_message): Use SAFE_ALLOCA, not alloca.
1948 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1949 (print_depth, new_backquote_output, print_number_index):
1950 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1951 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1952 (Fset_process_window_size, Fformat_network_address)
1953 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1954 (sigchld_handler):
d311d28c 1955 Check that fixnums are in proper range for system types.
d44287d4 1956 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1957 Check for process-ids out of pid_t range rather than relying on
1958 undefined behavior.
e4d81efc 1959 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1960 (Fformat_network_address, read_process_output, send_process)
1961 (Fprocess_send_region, status_notify):
1962 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1963 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1964 (wait_reading_process_output, read_process_output, exec_sentinel):
1965 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1966 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1967 (Faccept_process_output): Use duration_to_sec_usec to do proper
1968 overflow checking on durations.
dde14581
PE
1969 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1970 Don't assume pid_t fits in int.
02481186
PE
1971 * process.h (struct Lisp_Process): Members tick and update_tick
1972 are now of type EMACS_INT, not int.
b62b53e8
PE
1973 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1974 configured --with-wide-int.
d311d28c
PE
1975 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1976 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1977 * search.c (looking_at_1, string_match_1):
1978 (fast_string_match, fast_c_string_match_ignore_case)
1979 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1980 (scan_newline, find_before_next_newline, search_command)
1981 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1982 (set_search_regs, wordify):
1983 (Freplace_match):
1984 (Fmatch_data):
1985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1986 (string_match_1, search_buffer, set_search_regs):
1987 (Fmatch_data):
1988 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1989 (wordify): Check for overflow in size calculation.
1990 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1991 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1992 Check that fixnums are in proper range for system types.
1993 * sound.c (struct sound_device)
1994 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1996 (Fplay_sound_internal):
1997 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1998 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1999 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2000 (Fparse_partial_sexp):
2001 Don't assume fixnums can fit in int.
2002 (struct lisp_parse_state, find_start_pos, find_start_value)
2003 (find_start_value_byte, find_start_begv)
2004 (update_syntax_table, char_quoted, dec_bytepos)
2005 (find_defun_start, prev_char_comend_first, back_comment):
2006 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2007 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2008 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2009 (Finternal_describe_syntax_value): Check that match_lisp is a
2010 character, not an integer, since the code stuffs it into int.
2011 (scan_words, scan_sexps_forward):
2012 Check that fixnums are in proper range for system types.
2013 (Fforward_word):
2014 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2015 (scan_sexps_forward):
2016 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2017 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2018 * syntax.h: Adjust decls to match defn changes elsewhere.
2019 (struct gl_state_s):
2020 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2021 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2022 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2023 * sysdep.c (wait_for_termination_1, wait_for_termination)
2024 (interruptible_wait_for_termination, mkdir):
2025 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2026 (emacs_read, emacs_write):
2027 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2028 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2029 and double all fit in int.
d311d28c
PE
2030 * term.c (set_tty_color_mode):
2031 Check that fixnums are in proper range for system types.
2032 * termhooks.h (struct input_event):
2033 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2034 * textprop.c (validate_interval_range, interval_of)
2035 (Fadd_text_properties, set_text_properties_1)
2036 (Fremove_text_properties, Fremove_list_of_text_properties)
2037 (Ftext_property_any, Ftext_property_not_all)
2038 (copy_text_properties, text_property_list, extend_property_ranges)
2039 (verify_interval_modification):
2040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2041 (Fnext_single_char_property_change)
2042 (Fprevious_single_char_property_change):
2043 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2044 (copy_text_properties):
2045 Check for integer overflow in index calculation.
d311d28c
PE
2046 * undo.c (last_boundary_position, record_point, record_insert)
2047 (record_delete, record_marker_adjustment, record_change)
2048 (record_property_change):
2049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2050 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2052 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2053 (Fx_hide_tip, Fx_file_dialog):
2054 * w32menu.c (set_frame_menubar):
2055 Use ptrdiff_t, not int, for consistency with rest of code.
2056 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2057 (select_window, Fdelete_other_windows_internal)
2058 (window_scroll_pixel_based, window_scroll_line_based)
2059 (Frecenter, Fset_window_configuration):
2060 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2061 (Fset_window_hscroll, run_window_configuration_change_hook)
2062 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2063 (Fscroll_other_window, Frecenter):
d311d28c
PE
2064 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2065 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2066 Don't assume fixnum fits in int.
2067 (Fset_window_scroll_bars):
2068 Check that fixnums are in proper range for system types.
2069 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2070 (string_pos, c_string_pos, number_of_chars, init_iterator)
2071 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2072 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2073 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2074 (face_before_or_after_it_pos, handle_invisible_prop)
2075 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2076 (display_prop_intangible_p, string_buffer_position_lim)
2077 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2078 (get_overlay_strings_1, get_overlay_strings)
2079 (iterate_out_of_display_property, forward_to_next_line_start)
2080 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2081 (get_next_display_element, set_iterator_to_next)
2082 (get_visually_first_element, compute_stop_pos_backwards)
2083 (handle_stop_backwards, next_element_from_buffer)
2084 (move_it_in_display_line_to, move_it_in_display_line)
2085 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2086 (add_to_log, message_dolog, message_log_check_duplicate)
2087 (message2, message2_nolog, message3, message3_nolog
2088 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2089 (current_message_1, truncate_echo_area, truncate_message_1)
2090 (set_message, set_message_1, store_mode_line_noprop)
2091 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2092 (text_outside_line_unchanged_p, check_point_in_composition)
2093 (reconsider_clip_changes)
2094 (redisplay_internal, set_cursor_from_row, try_scrolling)
2095 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2096 (redisplay_window, find_last_unchanged_at_beg_row)
2097 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2098 (trailing_whitespace_p, find_row_edges, display_line)
2099 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2100 (display_mode_element, store_mode_line_string)
2101 (pint2str, pint2hrstr, decode_mode_spec)
2102 (display_count_lines, display_string, draw_glyphs)
2103 (x_produce_glyphs, x_insert_glyphs)
2104 (rows_from_pos_range, mouse_face_from_buffer_pos)
2105 (fast_find_string_pos, mouse_face_from_string_pos)
2106 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2107 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2108 (safe_call, init_from_display_pos, handle_fontified_prop)
2109 (handle_single_display_spec, load_overlay_strings)
2110 (with_echo_area_buffer, setup_echo_area_for_printing)
2111 (display_echo_area, echo_area_display)
2112 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2113 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2114 (redisplay_window, dump_glyph_row, display_mode_line)
2115 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2116 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2117 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2118 (handle_single_display_spec, build_desired_tool_bar_string)
2119 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2120 (get_specified_cursor_type):
2121 Check that fixnums are in proper range for system types.
2122 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2123 (Flookup_image_map):
2124 Don't assume fixnums fit in int.
2125 (compare_overlay_entries):
2126 Avoid mishandling comparisons due to subtraction overflow.
2127 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2128 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2129 (handle_tool_bar_click):
2130 Use int, not unsigned, since we prefer signed and the signedness
2131 doesn't matter here.
2132 (get_next_display_element, next_element_from_display_vector):
2133 Use int, not EMACS_INT, when int is wide enough.
2134 (start_hourglass): Use duration_to_sec_usec to do proper
2135 overflow checking on durations.
2136 * xfaces.c (Fbitmap_spec_p):
2137 Check that fixnums are in proper range for system types.
2138 (compare_fonts_by_sort_order):
2139 Avoid mishandling comparisons due to subtraction overflow.
2140 (Fx_family_fonts, realize_basic_faces):
2141 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2142 (Fx_family_fonts):
2143 Don't assume fixnum fits in int.
2144 Use SAFE_ALLOCA_LISP, not alloca.
2145 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2146 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2147 (face_at_buffer_position, face_for_overlay_string)
2148 (face_at_string_position):
2149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2150 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2151 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2152 (Fx_show_tip):
2153 Check that fixnums are in proper range for system types.
2154 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2155 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2156 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2157 (Fx_change_window_property): Don't assume fixnums fit in int.
2158 * xfont.c (xfont_chars_supported):
2159 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2160 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2161 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2162 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2163 * xml.c (parse_region):
2164 * xrdb.c (magic_file_p):
2165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2166 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2167 (x_get_local_selection, x_reply_selection_request)
2168 (x_handle_selection_request, wait_for_property_change):
2169 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2170 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2171 short is wide enough.
2172 (x_send_client_event): Don't assume fixnum fits in int.
2173 * xterm.c (x_x_to_emacs_modifiers):
2174 Don't assume EMACS_INT overflows nicely into int.
2175 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2176 may come from Lisp.
2177 (handle_one_xevent): NATNUMP can eval its arg twice.
2178 (x_connection_closed):
2179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2180 * xterm.h: Adjust decls to match defn changes elsewhere.
2181 (struct scroll_bar): Use struct vectorlike_header
2182 rather than rolling our own approximation.
2183 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2184
c6574eb5
GM
21852012-05-25 Glenn Morris <rgm@gnu.org>
2186
2187 * lisp.mk (lisp): Update for more files being compiled now.
2188
e8d32c7e
SM
21892012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2190
48def666
SM
2191 * lread.c: Remove `read_pure' which makes no difference.
2192 (read_pure): Remove var.
2193 (unreadpure): Remove function.
2194 (readevalloop): Don't call read_list with -1 flag.
2195 (read1, read_vector): Don't test read_pure any more.
2196 (read_list): Simplify.
2197
e8d32c7e
SM
2198 * fileio.c, character.h: Minor style tweaks.
2199
4b2addb7
DA
22002012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2201
2202 * window.h (clip_changed): Remove useless declaration.
2203
584461b2
JB
22042012-05-22 Juanma Barranquero <lekktu@gmail.com>
2205
2206 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2207 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2208
34374650
PE
22092012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2210
2211 Remove src/m/*.
2212 This directory predates autoconf and is no longer needed nowadays.
2213 Move its few remaining bits of functionality to where they're needed.
2214 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2215 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2216 * m/template.h: Remove.
2217 * Makefile.in (M_FILE): Remove. All uses removed.
2218 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2219 * lisp.h (USE_LSB_TAG):
2220 * mem-limits.h (EXCEEDS_LISP_PTR):
2221 Use VAL_MAX, not VALBITS, in #if.
2222 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2223 (EMACS_UINT): Define unconditionally now.
2224 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2225 (BITS_PER_EMACS_INT): New constants, replacing
2226 what used to be in config.h, but not useful in #if.
2227 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2228 define them any more.
2229 (VAL_MAX): New macro.
2230 (VALMASK): Use it.
2231 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2232 BITS_PER_EMACS_INT, in #if.
2233 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2234 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2235 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2236 * s/ms-w32.h (DATA_START):
2237 Move here from removed file m/intel386.h.
2238 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2239 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2240
261cb4bb
PE
22412012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2242
2243 Assume C89 or later.
2244 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2245 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2246 (xrealloc):
2247 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2248 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2249 * textprop.c, tparam.c (NULL): Remove.
2250 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2251 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2252 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2253 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2254 * xterm.c (input_signal_count): Assume volatile works.
2255
ff23cd9f
KB
22562012-05-21 Ken Brown <kbrown@cornell.edu>
2257
2258 * xgselect.c (xg_select): Fix first argument in call to 'select'
2259 (bug#11508).
2260
1b170bc6
KB
22612012-05-20 Ken Brown <kbrown@cornell.edu>
2262
2263 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2264 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2265
b2f4d39f
KB
22662012-05-19 Ken Brown <kbrown@cornell.edu>
2267
2268 * xfns.c (x_in_use): Remove `static' qualifier.
2269 * xterm.h (x_in_use): Declare.
2270 * xgselect.c: Include xterm.h.
2271 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2272 and `display_arg' (bug#9754).
2273
003fdae2
PE
22742012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2275
9232a6d9
PE
2276 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2277
003fdae2
PE
2278 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2279 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2280
784b56e2
EZ
22812012-05-18 Eli Zaretskii <eliz@gnu.org>
2282
2283 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2284
2285 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2286 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2287
2288 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2289 reference to image_cache->refcount.
2290 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2291
a0a79cde
JL
22922012-05-17 Juri Linkov <juri@jurta.org>
2293
2294 * search.c (Fword_search_regexp, Fword_search_backward)
2295 (Fword_search_forward, Fword_search_backward_lax)
2296 (Fword_search_forward_lax): Move functions to isearch.el
2297 (bug#10145, bug#11381).
2298
b0572523
PE
22992012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2300
2301 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2302
9660f5fc
SM
23032012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2304
2305 * lread.c (init_obarray): Declare Qt and Qnil as special.
2306
4374de83
GM
23072012-05-14 Glenn Morris <rgm@gnu.org>
2308
2309 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2310 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2311
dc44c39a
PE
23122012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2313
078c97cb
PE
2314 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2315
dc44c39a
PE
2316 * unexaix.c: Port to more-recent AIX compilers.
2317 (report_error, report_error_1, make_hdr, copy_sym)
2318 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2319 Make arguments const char *, not char *, to avoid violations of C
2320 standard and to fix some AIX warnings reported by Gilles Pion.
2321
e18afed7 23222012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2323
2324 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2325 already have overlays loaded.
2326 (handle_single_display_spec): Before returning without displaying
2327 fringe bitmap, synchronize the bidi iterator with the main display
2328 iterator, by calling iterate_out_of_display_property.
2329 (iterate_out_of_display_property): Detect buffer iteration by
2330 testing that it->string is a Lisp string.
2331 (get_next_display_element): When the current object is exhausted,
2332 and there's something on it->stack, call set_iterator_to_next to
2333 proceed with what's on the stack, instead of returning zero.
2334 (set_iterator_to_next): If called at the end of a Lisp string,
2335 proceed to consider_string_end without incrementing string
2336 position. Don't increment display vector index past the end of
2337 the display vector. (Bug#11417)
c8fb9dc6
EZ
2338 (pos_visible_p): Don't report a position visible when move_it_to
2339 stopped at the last line of window, which happens to be scanned
2340 backwards by the bidi iteration. (Bug#11464)
ac268e67 2341
e18afed7 23422012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2343
2344 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2345 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2346 are on a TTY, and thus unable to display on the fringes.
2347 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2348 so we need to signal to the caller that this is a "replacing"
2349 display spec. This fixes display when the spec is invalid or we
2350 are on a TTY.
2351
e18afed7 23522012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2353
2354 * unexaix.c (make_hdr): Fix typo in prototype.
2355 This bug broke the build on AIX. Problem reported by Gilles Pion.
2356
9d0a235a
MA
23572012-05-14 Michael Albinus <michael.albinus@gmx.de>
2358
2359 * keyboard.c (kbd_buffer_get_event): Read special events also in
2360 batch mode. (Bug#11415)
2361
9e6b06ed
GM
23622012-05-12 Glenn Morris <rgm@gnu.org>
2363
2364 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2365
c1a1d7a3
EZ
23662012-05-12 Eli Zaretskii <eliz@gnu.org>
2367
2368 * lisp.mk (lisp): Add newcomment.elc.
2369
3fe7cdc8
GM
23702012-05-12 Glenn Morris <rgm@gnu.org>
2371
2372 * Makefile.in (MKDIR_P): New, set by configure.
2373 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2374
53f7d2c0
PE
23752012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2376
2377 Remove unused function hourglass_started.
2378 * dispextern.h (hourglass_started):
2379 * w32fns.c (hourglass_started):
2380 * xdisp.c (hourglass_started): Remove.
2381
75aafb17
JB
23822012-05-10 Juanma Barranquero <lekktu@gmail.com>
2383
2384 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2385 Update dependencies.
2386
12959e8e
PE
23872012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2388
97107e2e
PE
2389 * xgselect.c (xg_select): Put maxfds+1 into a var.
2390 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2391
12959e8e
PE
2392 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2393
836d29b3
DA
23942012-05-10 Dave Abrahams <dave@boostpro.com>
2395
2396 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2397 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2398
5cb67954
MA
23992012-05-09 Michael Albinus <michael.albinus@gmx.de>
2400
2401 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2402 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2403 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2404 Initialize xd_registered_buses.
2405
3478ec45
PE
24062012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2407
b263a6b0
PE
2408 Untag more efficiently if USE_LSB_TAG.
2409 This is based on a proposal by YAMAMOTO Mitsuharu in
2410 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2411 For an admittedly artificial (nth 8000 longlist) benchmark on
2412 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2413 Emacs's overall text size by 1%.
2414 * lisp.h (XUNTAG): New macro.
2415 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2416 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2417 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2418 * eval.c (Fautoload):
2419 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2420 * frame.h (XFRAME): Use XUNTAG.
2421
3478ec45
PE
2422 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2423 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2424 Remove unportable assumptions about print widths of types like
2425 dbus_uint32_t.
2426 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2427 intptr_t when converting between pointer and integer, to avoid GCC
2428 warnings about wrong width.
2429
666b903b 24302012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2431
2432 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2433 stack for each reader_thread, instead of defaulting to 8MB
2434 determined by the linker. This avoids failures in creating
2435 subprocesses on Windows 7, see the discussion in this thread:
2436 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2437
b120cc17
JC
24382012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2439
2440 Fix up display of the *Minibuf-0* buffer in the mini window.
2441 * keyboard.c (read_char): Don't clear the echo area if there's no
2442 message to clear.
2443 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2444 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2445
9a4b36f8
MA
24462012-05-07 Michael Albinus <michael.albinus@gmx.de>
2447
2448 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2449 batch mode.
2450
e5f9458f
CY
24512012-05-06 Chong Yidong <cyd@gnu.org>
2452
2453 * lisp.mk (lisp): Update.
2454
eceeb5fc 24552012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2456
2457 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2458
71873e2b
SM
24592012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2460
2461 * data.c (PUT_ERROR): New macro.
2462 (syms_of_data): Use it. Add new error type `user-error'.
2463 * undo.c (user_error): New function.
2464 (Fprimitive_undo): Use it.
2465 * print.c (print_error_message): Adjust print style for `user-error'.
2466 * keyboard.c (user_error): New function.
2467 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2468
ab0fa4e4
PE
24692012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2470
2471 Do not limit current-time-string to years 1000..9999.
2472 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2473 (Fcurrent_time_string): Support any year that is supported by the
2474 underlying localtime representation. Don't use asctime, as it
2475 has undefined behavior for years outside the range -999..9999.
2476
7ed806a7
PE
24772012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2478
2479 Fix race conditions involving setenv, gmtime, localtime, asctime.
2480 Without this fix, interrupts could mess up code that uses these
2481 nonreentrant functions, since setting TZ invalidates existing
2482 tm_zone or tzname values, and since most of these functions return
2483 pointers to static storage.
2484 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2485 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2486 Grow the critical sections to include not just invoking
2487 localtime/gmtime, but also accessing these functions' results
2488 including their tm_zone values if any, and any related TZ setting.
2489 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2490 so that the struct tm is saved in the critical section.
2491 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2492 motivated by the fact that memory allocation needs to be outside
2493 the critical section.
2494
0c16dfed
DA
24952012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2496
2497 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2498 with RESET_INTERVAL.
2499
2500 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2501 Remove duplicated buffer name initialization.
2502
3f83ace8
JM
25032012-05-02 Jim Meyering <jim@meyering.net>
2504
2505 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2506
c7b8541e
JM
2507 * xfns.c (x_window): Use xstrdup (Bug#11375).
2508
90207a15 25092012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2510
2511 * xdisp.c (pos_visible_p): If already at a newline from the
2512 display string before the 'while' loop, don't walk back the glyphs
2513 from it3.glyph_row. Solves assertion violation when the display
2514 string begins with a newline (egg.el). (Bug#11367)
2515
b593d6a9
AH
25162012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2517
2518 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2519 Move to simple.el.
2520
4737362e
GM
25212012-05-01 Glenn Morris <rgm@gnu.org>
2522
99cf43f9
GM
2523 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2524 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2525 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2526 All were removed before 23.1.
2527
9311dcff
GM
2528 * dispnew.c: Remove HAVE_LIBNCURSES test;
2529 it is always true on relevant platforms.
2530
4d5c6349
GM
2531 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2532 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2533
4737362e
GM
2534 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2535
74dd3a6b
AS
25362012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2537
2538 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2539 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2540 Remove.
2541
13c379ee
PE
25422012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2543
2544 Do not avoid creating empty evaporating overlays (Bug#9642).
2545 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2546 That is, do not delete an evaporating overlay if it becomes
2547 empty after its bounds are adjusted to fit within its buffer.
2548 This fix caused other problems, and I'm reverting it until we get
2549 to the bottom of them.
2550
a8e7d6d7 25512012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2552
2553 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2554
a8e7d6d7 25552012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2556
2557 * xdisp.c (pos_visible_p): If the window start position is beyond
2558 ZV, start the display from buffer beginning. Prevents assertion
2559 violation in init_iterator when the minibuffer window is scrolled
2560 via the scroll bar.
2561
2562 * window.c (window_scroll_pixel_based): Likewise.
2563
a8e7d6d7 25642012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2565
2566 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2567
a8e7d6d7 25682012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2569
2570 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2571 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2572
a8e7d6d7 25732012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2574
b593d6a9
AH
2575 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2576 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2577
1c6900d9
EZ
25782012-04-26 Eli Zaretskii <eliz@gnu.org>
2579
4c3fa1d9
EZ
2580 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2581 display element, check also the underlying string or buffer
2582 character. (Bug#11341)
2583
1c6900d9
EZ
2584 * w32menu.c: Include w32heap.h.
2585 (add_menu_item): If the call to AppendMenuW (via
2586 unicode_append_menu) fails, disable Unicode menus only if we are
2587 running on Windows 9X/Me.
2588
42bf8205
AS
25892012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2590
2591 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2592 (xgetint): Add missing shift for LSB tags.
2593
b1bac16e
MR
25942012-04-24 Martin Rudalics <rudalics@gmx.at>
2595
2596 * keyboard.c (read_char): Don't wipe echo area for select window
2597 events: These might get delayed via `mouse-autoselect-window'
2598 (Bug#11304).
2599
d69621cc
JB
26002012-04-24 Juanma Barranquero <lekktu@gmail.com>
2601
2602 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2603 manipulation of :loaded-from data.
2604
02fd101b
JB
26052012-04-23 Juanma Barranquero <lekktu@gmail.com>
2606
2607 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2608 now a cons (bug#11311).
2609
888bec30
PE
26102012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2611
89a438bd
PE
2612 Do not create empty overlays with the evaporate property (Bug#9642).
2613 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2614 if it becomes empty after its bounds are adjusted to fit within
2615 its buffer. Without this fix, in a nonempty buffer (let ((o
2616 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2617 yields an empty overlay that has the evaporate property, which is
2618 not supposed to happen.
2619
1068fe4d
PE
2620 Fix minor GTK3 problems found by static checking.
2621 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2622 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2623 (struct _EmacsFixedClass, emacs_fixed_get_type):
2624 Move decls here from emacsgtkfixed.h, since they needn't be public.
2625 (emacs_fixed_get_type): Now static.
2626 (emacs_fixed_class_init): Omit unused local.
2627 (emacs_fixed_child_type): Remove; unused.
2628 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2629 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2630 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2631 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2632 (EMACS_FIXED_GET_CLASS): Remove; unused.
2633 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2634
888bec30
PE
2635 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2636 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2637
de85e130
PE
26382012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2639
d0baac98 2640 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2641 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2642 (__malloc_size_t, __malloc_ptrdiff_t):
2643 Remove. All uses removed, replaced by the definiens if needed,
2644 since we can assume C89 or better now.
2645 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2646 (protect_malloc_state, align, get_contiguous_space)
2647 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2648 (malloc_atfork_handler_child, malloc_enable_thread)
2649 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2650 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2651 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2652 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2653 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2654 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2655 Define using prototypes, not old style.
2656 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2657 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2658 (align): Don't assume that signed integer overflow wraps around.
2659 Omit unused local var.
2660 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2661 (_free_internal_nolock, memalign, mallochook, reallochook):
2662 Omit no-longer-needed casts.
2663 (valloc): Use getpagesize, not __getpagesize.
2664 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2665 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2666
de85e130
PE
2667 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2668
dcbf5805
MA
26692012-04-22 Michael Albinus <michael.albinus@gmx.de>
2670
2671 Move functions from C to Lisp. Make non-blocking method calls
2672 the default. Implement further D-Bus standard interfaces.
2673
2674 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2675 (QCdbus_request_name_allow_replacement)
2676 (QCdbus_request_name_replace_existing)
2677 (QCdbus_request_name_do_not_queue)
2678 (QCdbus_request_name_reply_primary_owner)
2679 (QCdbus_request_name_reply_in_queue)
2680 (QCdbus_request_name_reply_exists)
2681 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2682 (QCdbus_registered_serial, QCdbus_registered_method)
2683 (QCdbus_registered_signal): New Lisp objects.
2684 (XD_DEBUG_MESSAGE): Use sizeof.
2685 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2686 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2687 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2688 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2689 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2690 (xd_signature, xd_append_arg): Allow float for integer types.
2691 (xd_get_connection_references): New function.
b593d6a9
AH
2692 (xd_get_connection_address): Rename from xd_initialize.
2693 Return cached address.
dcbf5805
MA
2694 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2695 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2696 level.
2697 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2698 Return number of refcounts.
dcbf5805
MA
2699 (Fdbus_get_unique_name): Make stronger parameter check.
2700 (Fdbus_message_internal): New defun.
2701 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2702 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2703 (Fdbus_send_signal, Fdbus_register_service)
2704 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2705 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2706 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2707 (Vdbus_compiled_version, Vdbus_runtime_version)
2708 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2709 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2710 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2711 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2712 Adapt docstring.
dcbf5805 2713
52828e02
PE
27142012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2715
da05bc4c
PE
2716 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2717 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2718 Do not assume ptrdiff_t is the same width as 'int'.
2719
52828e02
PE
2720 * alloc.c: Handle unusual debugging option combinations.
2721 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2722 since the two debugging options are incompatible.
2723 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2724 is defined.
2725 (mem_init, mem_insert, mem_insert_fixup):
2726 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2727 (NEED_MEM_INSERT): Remove; no longer needed.
2728
f01769f9
LL
27292012-04-22 Leo Liu <sdl.web@gmail.com>
2730
2731 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2732
5790543d
PE
27332012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2734
2735 * sysdep.c [__FreeBSD__]: Minor cleanups.
2736 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2737 Use Emacs indenting style more consistently. Avoid some casts.
2738 Use 'double' consistently rather than mixing 'float' and 'double'.
2739
b91b7e4d
EW
27402012-04-21 Eduard Wiebe <usenet@pusto.de>
2741
b593d6a9
AH
2742 * sysdep.c (list_system_processes, system_process_attributes):
2743 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2744
6114eb15
AS
27452012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2746
2747 * lisp.mk (lisp): Update.
2748
2f38dff7
PE
27492012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2750
2751 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2752 It is never used otherwise.
2753
4ae29f89
SM
27542012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2755
2756 * print.c (print_preprocess): Only check print_depth if print-circle
2757 is nil.
2758 (print_object): Check for cycles even when print-circle is nil and
2759 print-gensym is t, but only check print_depth if print-circle is nil.
2760
f30d612a
CY
27612012-04-20 Chong Yidong <cyd@gnu.org>
2762
2763 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2764 set the status to "failed" and ensure that sentinel is run.
2765
c07a4c0b 27662012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2767
2768 * process.c (Fset_process_inherit_coding_system_flag)
2769 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2770 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2771
c07a4c0b 27722012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2773
2774 * xdisp.c (string_buffer_position_lim): Limit starting position to
2775 BEGV.
2776 (set_cursor_from_row): If called for a mode-line or header-line
2777 row, return zero immediately.
2778 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2779 farther than the first row after the header line, if any.
2780 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2781 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2782
c07a4c0b 27832012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2784
4ae29f89
SM
2785 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2786 (bug#11238).
ad3a2b41 2787
c07a4c0b 27882012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 27892012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2790
2791 configure: new option --enable-gcc-warnings (Bug#11207)
2792 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2793 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2794 (ALL_CFLAGS): Use new macros rather than old.
2795 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2796 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2797 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2798 -Wunused-result, -Wunused-variable. This should go away once
2799 the Emacs and Gnulib regex code is merged.
2800 (xmalloc, xrealloc): Now static.
2801
aba027e8
PE
28022012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2803
2804 * dired.c (Fsystem_groups): Remove unused local.
2805
e5a36063
GM
28062012-04-17 Glenn Morris <rgm@gnu.org>
2807
2808 * dired.c (Fsystem_users): Doc fix.
2809
316411f0
DA
28102012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2811
2812 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2813 (syms_of_dired): Add them.
2814
9426aba4
PE
28152012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2816
b62a57be
PE
2817 Fix minor alloc.c problems found by static checking.
2818 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2819 New extern decls, to avoid calling undeclared functions.
2820 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2821 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2822 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2823 (NEED_MEM_INSERT): New macro.
2824 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2825 Remove one incorrect comment and fix another.
b62a57be 2826
3539f31f
PE
2827 Fix minor ralloc.c problems found by static checking.
2828 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2829 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2830 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2831 (r_alloc_sbrk): Now static.
2832
a041960a
PE
2833 Improve ralloc.c interface checking.
2834 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2835 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2836 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2837 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2838 [REL_ALLOC]: ... to here, to check interface.
2839 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2840 Remove decls. This fixes an "It stinks!".
2841
9426aba4
PE
2842 * alloc.c (which_symbols): Fix alignment issue / type clash.
2843
d55c12ed
AS
28442012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2845
2846 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2847 (struct Lisp_Misc_Any): Likewise.
2848 (struct Lisp_Free): Likewise.
2849 * alloc.c (union aligned_Lisp_Symbol): Define.
2850 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2851 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2852 (union aligned_Lisp_Misc): Define.
2853 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2854 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2855 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2856
b948ce8b
PE
28572012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2858
2859 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2860 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2861 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2862 * s/netbsd.h, s/sol2-6.h:
2863 Remove definition of GC_MARK_STACK, since the default now works.
2864 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2865 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2866 no longer the default.
2867 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2868
35dc09a1 28692012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2870
35dc09a1
GM
2871 * lread.c (lisp_file_lexically_bound_p):
2872 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2873
35dc09a1
GM
28742012-04-14 Eli Zaretskii <eliz@gnu.org>
2875
2876 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2877 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2878
28792012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2880
2881 * nsterm.m (constrainFrameRect): Always constrain when there is only
2882 one screen (Bug#10962).
2883
bcd86815
KB
28842012-04-13 Ken Brown <kbrown@cornell.edu>
2885
2886 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2887
c25df26e
RT
28882012-04-13 Reuben Thomas <rrt@sc3d.org>
2889
2890 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2891
0fc59f1e
DC
28922012-04-11 Daniel Colascione <dancol@dancol.org>
2893
2894 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2895 against is gone. It's better to use vfork now so that when Cygwin
2896 gains a new, working vfork, we use it automatically (bug#10398).
2897
de8c03dc
SM
28982012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2899
2900 * window.c (save_window_save): Obey window-point-insertion-type.
2901
2f097256
GM
29022012-04-11 Glenn Morris <rgm@gnu.org>
2903
2904 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2905
453b951e
SM
29062012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2907
2908 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2909
75f1671a 29102012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2911
2912 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2913 (force_quit_count): New var.
2914 (handle_interrupt): Use it.
2915
2a8ce227
JB
29162012-04-10 Juanma Barranquero <lekktu@gmail.com>
2917
2918 * w32.c (w32_delayed_load): Record the full path of the library
2919 being loaded (bug#10424).
2920
935396c0
GM
29212012-04-09 Glenn Morris <rgm@gnu.org>
2922
05920a43
GM
2923 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2924 not just in the obarray, before snarfing them. (Bug#11036)
2925
935396c0
GM
2926 * Makefile.in ($(leimdir)/leim-list.el):
2927 Pass EMACS rather than BUILT_EMACS.
2928
a18ecafa
TZ
29292012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2930
2931 * process.c (make_process):
2932 * process.h: Add integer `gnutls_handshakes_tried' member to
2933 process struct.
2934
6bbef4e5
JC
2935 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2936 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2937
2938 * gnutls.c (gnutls_log_function2i): Convenience log function.
2939 (emacs_gnutls_read): Use new log functions,
2940 `gnutls_handshakes_tried' process member, and
2941 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2942 attempts per process (connection).
2943
b4d3bc10
CY
29442012-04-09 Chong Yidong <cyd@gnu.org>
2945
2946 * eval.c (Fuser_variable_p, user_variable_p_eh)
2947 (lisp_indirect_variable): Functions deleted.
2948 (Fdefvar): Caller changed.
2949
2950 * callint.c (Finteractive, Fcall_interactively):
2951 * minibuf.c (Fread_variable): Callers changed.
2952
70f4d973
EZ
29532012-04-09 Eli Zaretskii <eliz@gnu.org>
2954
2955 * xdisp.c (set_cursor_from_row): If the display string appears in
2956 the buffer at position that is closer to point than the position
2957 after the display string, display the cursor on the first glyph of
2958 the display string. Fixes cursor display when a 'display' text
2959 property immediately follows invisible text. (Bug#11094)
2960
cb3c2e3e
PE
29612012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2962
2963 composite.c: use 'double' consistently
2964 * composite.c (get_composition_id): Use 'double' consistently
2965 instead of converting 'float' to 'double' and vice versa; this is
2966 easier to understand and avoids a GCC warning.
2967
fd06db5d
GM
29682012-04-09 Glenn Morris <rgm@gnu.org>
2969
50fe702a
GM
2970 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2971 preparation for dumping it with emacs. (Bug#4789)
2972 (leimdir): New variable.
2973 ($(leimdir)/leim-list.el): New rule.
2974 (emacs$(EXEEXT)): Depend on leim-list.el.
2975
fd06db5d
GM
2976 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2977 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2978 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2979
55c131ee
AS
29802012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2981
2982 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2983 proper alignment.
2984
9209588f
JB
29852012-04-07 Juanma Barranquero <lekktu@gmail.com>
2986
2987 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2988 Remove unused local variable.
2989
e3fb2efb
PE
29902012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2991
2992 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2993 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2994 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2995 objects, as mark_maybe_pointer will catch them otherwise.
2996 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2997 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2998
b5385551
PE
29992012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3000
3001 Fix typo that broke non-Windows builds.
3002 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3003
9078ead6
EZ
30042012-04-07 Eli Zaretskii <eliz@gnu.org>
3005
3006 Support building on MS-Windows with libxml2.
3007
3008 * makefile.w32-in (OBJ2): Add xml.$(O).
3009 (GLOBAL_SOURCES): Add xml.c.
3010 ($(BLD)/xml.$(O)): New dependency list.
3011
3012 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3013 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3014 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3015 [!WINDOWSNT]: New macros.
3016 (init_libxml2_functions, libxml2_loaded_p): New functions.
3017 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3018 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3019 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3020 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3021 linked in).
6bbef4e5
JC
3022 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3023 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3024 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3025
3026 * emacs.c: Don't include libxml/parser.h.
3027 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3028 xmlCleanupParser directly.
3029
3030 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3031
3811fdf3
EZ
30322012-04-07 Eli Zaretskii <eliz@gnu.org>
3033
3034 * indent.c (Fvertical_motion): If there is a display string at
3035 point, use it.vpos to compute how many lines to backtrack after
3036 move_it_to point. (Bug#11133)
3037
2f8e16b2
EZ
30382012-04-06 Eli Zaretskii <eliz@gnu.org>
3039
3040 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3041 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3042 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3043 macros related to unification of CJK characters. For the details,
3044 see the discussion following the message here:
3045 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3046
3d439cd1
CY
30472012-04-04 Chong Yidong <cyd@gnu.org>
3048
3049 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3050
8bc53d00
EZ
30512012-04-01 Eli Zaretskii <eliz@gnu.org>
3052
3053 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3054 instead of alloca. (Bug#11138)
3055
3b0512a3
AS
30562012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3057
3058 * w32menu.c (is_simple_dialog): Properly check lisp types.
3059 (Bug#11141)
3060
8427ddd2
EZ
30612012-03-31 Eli Zaretskii <eliz@gnu.org>
3062
979022ef
EZ
3063 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3064 position we get to after a call to move_it_to fails the
3065 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3066 only if we wind up in a string from display property. (Bug#11063)
3067
a6b1c7cc
EZ
3068 * window.c (Fdelete_other_windows_internal): Invalidate the row
3069 and column information about mouse highlight, so that redisplay
3070 restores it after reallocating the glyph matrices. (Bug#7464)
3071
8427ddd2
EZ
3072 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3073 string comes from a `display' text property, use the buffer
3074 position of that property as if we actually saw that position in
3075 the row's glyphs.
697ba24b
EZ
3076 (move_it_by_lines): Remove the assertion that
3077 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3078 violated when there's a before-string at the beginning of a line.
3079 (Bug#11063)
8427ddd2 3080
65a0a738
EZ
30812012-03-30 Eli Zaretskii <eliz@gnu.org>
3082
3083 * xdisp.c (append_space_for_newline): If the default face was
3084 remapped, use the remapped face for the appended newline.
3085 (extend_face_to_end_of_line): Use the remapped default face for
3086 extending the face to the end of the line.
3087 (display_line): Call extend_face_to_end_of_line when the default
3088 face was remapped. (Bug#11068)
3089
581355cc
EZ
30902012-03-29 Eli Zaretskii <eliz@gnu.org>
3091
3092 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3093
e8fc049f
SM
30942012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3095
3096 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3097
4fb9a543
GM
30982012-03-27 Glenn Morris <rgm@gnu.org>
3099
3100 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3101 Doc fixes.
3102
679910f1
KH
31032012-03-26 Kenichi Handa <handa@m17n.org>
3104
3105 * dispextern.h (struct glyph): Fix previous change. Change the
3106 bit length of glyphless.ch to 25 (Bug#11082).
3107
90d49b7f
CY
31082012-03-26 Chong Yidong <cyd@gnu.org>
3109
3110 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3111 (command_loop_1): Use it; inhibit selection update for
3112 handle-select-window too (Bug#8996).
3113
f514f6f0
FP
31142012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3115
e8fc049f 3116 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3117
bf43fa51
KH
31182012-03-25 Kenichi Handa <handa@m17n.org>
3119
3120 * dispextern.h (struct glyph): Change the bit length of
3121 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3122
8a0c01dd
EZ
31232012-03-24 Eli Zaretskii <eliz@gnu.org>
3124
3125 * s/ms-w32.h (tzname): Include time.h before redirecting to
3126 _tzname. Fixes the MSVC build. (Bug#9960)
3127
7d1c3a76
AS
31282012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3129
8ed79523
AS
3130 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3131 characters.
3132
7d1c3a76
AS
3133 * xterm.c (XTread_socket): Only modify handling_signal if
3134 !SYNC_INPUT. (Bug#11080)
3135
e99a9b8b
EZ
31362012-03-23 Eli Zaretskii <eliz@gnu.org>
3137
3138 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3139 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3140 when fetching a multibyte character consumes more bytes than
3141 CHAR_BYTES returns, due to unification of CJK characters in
3142 string_char. (Bug#11073)
3143
5063c0e1
TN
31442012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3145
3146 * process.c (wait_reading_process_output): Handle pty disconnect
3147 by refraining from sending oneself a SIGCHLD (bug#10933).
3148
9f851fbd
CY
31492012-03-22 Chong Yidong <cyd@gnu.org>
3150
3151 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3152
5063c0e1 3153 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3154 Mark string as coming from a prefix property.
3155 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3156 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3157
fb5b8aca
CY
31582012-03-21 Chong Yidong <cyd@gnu.org>
3159
3160 * xfaces.c (Vface_remapping_alist): Doc fix.
3161
62356a1b
EZ
31622012-03-20 Eli Zaretskii <eliz@gnu.org>
3163
3164 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3165 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3166 Doc fixes.
62356a1b 3167
025de85b
CY
31682012-03-20 Chong Yidong <cyd@gnu.org>
3169
3170 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3171 to reflect default non-nil value of redisplay-dont-pause.
3172
4827f94e
KH
31732012-03-19 Kenichi Handa <handa@m17n.org>
3174
3175 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3176 it fit in a valid range (Bug#11003).
3177
e50a24a2
EZ
31782012-03-18 Eli Zaretskii <eliz@gnu.org>
3179
3180 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3181 that is not from display property, accept the row as a "cursor
3182 row" if one of the string's character has a non-nil `cursor'
3183 property. Fixes cursor positioning when there are newlines in
3184 overlay strings, e.g. in icomplete.el. (Bug#11035)
3185
9af5ed87
PE
31862012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3187
3188 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3189
d1f55f16
CY
31902012-03-12 Chong Yidong <cyd@gnu.org>
3191
3192 * eval.c (inhibit_lisp_code): Rename from
3193 inhibit_window_configuration_change_hook; move from window.c.
3194
3195 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3196 * window.c (run_window_configuration_change_hook)
3197 (syms_of_window): Callers changed.
3198
66c5eebd
CY
31992012-03-11 Chong Yidong <cyd@gnu.org>
3200
413df973
CY
3201 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3202
66c5eebd
CY
3203 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3204
1de11f56
CY
32052012-03-10 Chong Yidong <cyd@gnu.org>
3206
3207 * frame.c (other_visible_frames): Don't assume the selected frame
3208 is visible (Bug#10955).
3209
cae07000
SM
32102012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3211
3212 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3213
89c94350
JD
32142012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3215
3216 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3217 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3218 zero (Bug#10954).
3219
999dd333
GM
32202012-03-03 Glenn Morris <rgm@gnu.org>
3221
01a6dcc8 3222 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3223
de0100f2
EZ
32242012-03-02 Eli Zaretskii <eliz@gnu.org>
3225
3226 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3227 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3228 (redisplay_window, next_element_from_string): Fix typos in
3229 comments.
3e441275
EZ
3230 (redisplay_window): Pass to move_it_vertically the margin in
3231 pixels, not in screen lines.
de0100f2 3232
96a72ee9
GM
32332012-03-02 Glenn Morris <rgm@gnu.org>
3234
3235 * buffer.c (buffer-list-update-hook): Doc fix.
3236
312508d7
EZ
32372012-02-29 Eli Zaretskii <eliz@gnu.org>
3238
3239 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3240 push_it before setting up the iterator for the first overlay
3241 string, even if we have an empty string loaded.
3242 (next_overlay_string): If there's an empty string on the iterator
3243 stack, pop the stack. (Bug#10903)
3244
27f3c637
PE
32452012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3246
3247 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3248 Suggested by Stefan Monnier in
3249 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3250 * alloc.c (widen_to_Lisp_Object): New static function.
3251 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3252 and widening them to Lisp_Objects. This would work even if
3253 USE_LSB_TAG is defined and wide integers are used, which might
3254 happen in a future version of Emacs.
3255
3c9dfce6
CY
32562012-02-25 Chong Yidong <cyd@gnu.org>
3257
fa74b241
CY
3258 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3259 Doc fix.
3260
3c9dfce6
CY
3261 * xselect.c (Fx_selection_exists_p): Doc fix.
3262 (x_clipboard_manager_save_all): Print an informative message
3263 before saving to clipboard manager.
3264
9486df08
CY
32652012-02-24 Chong Yidong <cyd@gnu.org>
3266
3267 * keyboard.c (process_special_events): Handle all X selection
3268 requests in kbd_buffer, not just the next one (Bug#8869).
3269
f01d3321
CY
32702012-02-23 Chong Yidong <cyd@gnu.org>
3271
3272 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3273 call when setting menu-bar-lines and tool-bar-lines parameters.
3274 (unwind_create_frame_1): New helper function.
3275
3276 * window.c (inhibit_window_configuration_change_hook): New var.
3277 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3278 (syms_of_window): Initialize it.
f01d3321 3279
86b847b6
CY
32802012-02-22 Chong Yidong <cyd@gnu.org>
3281
3282 * xterm.c (x_draw_image_relief): Add missing type check for
3283 Vtool_bar_button_margin (Bug#10743).
3284
a59225b1
CY
32852012-02-21 Chong Yidong <cyd@gnu.org>
3286
3287 * fileio.c (Vfile_name_handler_alist): Doc fix.
3288
3289 * buffer.c (Fget_file_buffer): Protect against invalid file
3290 handler return value.
3291
310f5bd4
PE
32922012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3293
cb3a28cc
PE
3294 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3295 when computing $valmask.
3296
310f5bd4
PE
3297 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3298 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3299 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3300 It's useless in that case, and it can cause problems on hosts
3301 that allocate halves of EMACS_INT values separately.
3302 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3303 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3304 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3305 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3306 it avoids undefined behavior on hosts where shifting right by more
3307 than the word width has undefined behavior.
3308
2375c96a
CY
33092012-02-19 Chong Yidong <cyd@gnu.org>
3310
3311 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3312 (Funhandled_file_name_directory, Ffile_name_as_directory)
3313 (Fdirectory_file_name, Fexpand_file_name)
3314 (Fsubstitute_in_file_name): Protect against invalid file handler
3315 return values (Bug#10845).
3316
3eb49e71
EZ
33172012-02-18 Eli Zaretskii <eliz@gnu.org>
3318
3319 * .gdbinit (pitx): Fix incorrect references to fields of the
3320 iterator stack.
3321
7b926f3f
CY
33222012-02-17 Chong Yidong <cyd@gnu.org>
3323
3324 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3325
11273115
PE
33262012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3327
3328 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3329 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3330
c3a70e2b
CY
33312012-02-15 Chong Yidong <cyd@gnu.org>
3332
3333 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3334 marked as special. Also, starting docstrings with * is obsolete.
3335
0ca43699
AS
33362012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3337
3338 * gnutls.c (emacs_gnutls_write): Fix last change.
3339
2e8f3c56
LI
33402012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3341
3342 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3343 send_process.
3344
af70074f
SM
33452012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3346
3347 * keymap.c (Fsingle_key_description): Handle char ranges.
3348
95986d52
CY
33492012-02-12 Chong Yidong <cyd@gnu.org>
3350
afd83bd1
CY
3351 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3352 as that creates a dangerous corner case.
3353
95986d52
CY
3354 * window.c (Fdelete_window_internal): Invalidate the mouse
3355 highlight (Bug#9904).
3356
bd7da63e
GM
33572012-02-12 Glenn Morris <rgm@gnu.org>
3358
3359 * xselect.c (Fx_own_selection_internal)
3360 (Fx_get_selection_internal, Fx_disown_selection_internal)
3361 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3362 * nsselect.m (Fx_own_selection_internal)
3363 (Fx_disown_selection_internal, Fx_selection_exists_p)
3364 (Fx_selection_owner_p, Fx_get_selection_internal):
3365 Sync docs and argument specs with the xselect.c versions.
3366
77abcbc2
LI
33672012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3368
3369 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3370
90b671e2
EZ
33712012-02-11 Eli Zaretskii <eliz@gnu.org>
3372
1c0ca0b7
EZ
3373 * w32select.c (Fx_selection_exists_p): Sync doc string and
3374 argument list with xselect.c. (Bug#10783)
3375
3376 * w16select.c (Fx_selection_exists_p): Sync doc string and
3377 argument list with xselect.c. (Bug#10783)
90b671e2 3378
49241268
GM
33792012-02-10 Glenn Morris <rgm@gnu.org>
3380
3381 * fns.c (Fsecure_hash): Doc fix.
3382
f998bbe7 33832012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3384
3385 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3386
0992bd9c
CY
33872012-02-07 Chong Yidong <cyd@gnu.org>
3388
3389 * buffer.c (Fbuffer_local_variables)
3390 (buffer_lisp_local_variables): Handle unbound vars correctly;
3391 don't let Qunbound leak into Lisp.
3392
af008560
GM
33932012-02-07 Glenn Morris <rgm@gnu.org>
3394
dd605cc4
GM
3395 * image.c (Fimagemagick_types): Doc fix.
3396
af008560
GM
3397 * image.c (imagemagick-render-type): Change it from a lisp object
3398 to an integer. Move the doc here from the lisp manual.
3399 Treat all values not equal to 0 the same.
3400
1449fa1d
CY
34012012-02-06 Chong Yidong <cyd@gnu.org>
3402
3403 * doc.c (store_function_docstring): Avoid applying docstring of
3404 alias to base function (Bug#2603).
3405
3723ec07
AS
34062012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3407
3408 * .gdbinit (pp1, pv1): Remove redundant defines.
3409 (pr): Use pp.
3410
79c1cc1e
CY
34112012-02-04 Chong Yidong <cyd@gnu.org>
3412
3413 * nsterm.m: Declare a global (Bug#10694).
3414
d7f29f8e
EZ
34152012-02-04 Eli Zaretskii <eliz@gnu.org>
3416
cae07000
SM
3417 * w32.c (get_emacs_configuration_options):
3418 Include --enable-checking, if specified, in the return value.
d7f29f8e 3419
3b95a6f9
MR
34202012-02-04 Martin Rudalics <rudalics@gmx.at>
3421
3422 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3423 after rounding frame sizes. (Bug#9723)
3424
d6fa96a6
EZ
34252012-02-04 Eli Zaretskii <eliz@gnu.org>
3426
3427 * keyboard.c (adjust_point_for_property): Don't position point
3428 before BEGV. (Bug#10696)
3429
df0b2940
PE
34302012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3431
3432 Handle overflow when computing char display width (Bug#9496).
3433 * character.c (char_width): Return EMACS_INT, not int.
3434 (char_width, c_string_width): Check for overflow when
3435 computing the width; this is possible now that individual
3436 characters can have unbounded width. Problem introduced
3437 by merge from Emacs 23 on 2012-01-19.
3438
6bee44d6
MA
34392012-02-02 Michael Albinus <michael.albinus@gmx.de>
3440
3441 * dbusbind.c (Fdbus_register_method): Mention the return value
3442 :ignore in the docstring.
3443
44f92739
GM
34442012-02-02 Glenn Morris <rgm@gnu.org>
3445
1b9f60cc
GM
3446 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3447
44f92739
GM
3448 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3449 Unconditionally set to t. (Bug#10673)
3450 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3451 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3452 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3453
c5d3843c
KH
34542012-02-02 Kenichi Handa <handa@m17n.org>
3455
3456 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3457 0, do not call append_composite_glyph.
3458
159462d4 34592012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3460
3461 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3462 NULL (Bug#6988).
3463 (x_produce_glyphs): If the component of a composition is a null
3464 string, set it->pixel_width to 1 to avoid zero-width glyph.
3465
78cef877
EZ
34662012-02-01 Eli Zaretskii <eliz@gnu.org>
3467
3468 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3469 first 2 arguments are identical. This makes inserting large
3470 output from a subprocess an order of magnitude faster on
3471 MS-Windows, where all sbrk'ed memory is always contiguous.
3472
97897668
GM
34732012-01-31 Glenn Morris <rgm@gnu.org>
3474
3475 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3476 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3477 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3478
31fd3586
GM
34792012-01-29 Glenn Morris <rgm@gnu.org>
3480
3481 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3482
0e24a8b2
CY
34832012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3484
3485 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3486
cc0adcb0
CY
34872012-01-28 Chong Yidong <cyd@gnu.org>
3488
3489 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3490
acc28cb9
CY
34912012-01-26 Chong Yidong <cyd@gnu.org>
3492
9c69cfb7
CY
3493 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3494
acc28cb9
CY
3495 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3496 repeat counts (Bug#10507).
3497
48da7392
GM
34982012-01-26 Glenn Morris <rgm@gnu.org>
3499
3500 * lread.c (syms_of_lread): Doc fix.
3501
14af5f7f
CY
35022012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3503
3504 * coding.c (encode_designation_at_bol): Change return value to
3505 EMACS_INT.
3506
0b21c100
CY
35072012-01-25 Chong Yidong <cyd@gnu.org>
3508
3509 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3510
3c2907f7
CY
35112012-01-21 Chong Yidong <cyd@gnu.org>
3512
3513 * floatfns.c (Fcopysign): Make the second argument non-optional,
3514 since nil is not allowed anyway.
3515
959ad23f
AS
35162012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3517
3518 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3519 (send_process): Likewise.
3520
34a02f46
MR
35212012-01-19 Martin Rudalics <rudalics@gmx.at>
3522
3523 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3524 (Vwindow_persistent_parameters): Do not use Qstate.
3525 Rewrite doc-strings.
34a02f46 3526
1259009a 35272012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3528
3529 * character.c (char_width): New function.
70d4fdf6
GM
3530 (Fchar_width, c_string_width, lisp_string_width):
3531 Use char_width (Bug#9496).
25ed9e61 3532
6a6ee00d
MR
35332012-01-16 Martin Rudalics <rudalics@gmx.at>
3534
3535 * window.c (Vwindow_persistent_parameters): New variable.
3536 (Fset_window_configuration, save_window_save): Handle persistent
3537 window parameters.
3538
c85efaf7
EZ
35392012-01-14 Eli Zaretskii <eliz@gnu.org>
3540
3541 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3542 thrashing the stack of the thread. (Bug#9087)
3543
5944709e
PE
35442012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3545
3546 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3547
e71f5d99
EZ
35482012-01-11 Eli Zaretskii <eliz@gnu.org>
3549
3550 * xdisp.c (rows_from_pos_range): Handle the case where the
3551 highlight ends on a newline. (Bug#10464)
3552 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3553 he end column for display of highlight that ends on a newline
3554 before a R2L line.
3555
ce316182
GM
35562012-01-11 Glenn Morris <rgm@gnu.org>
3557
3558 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3559 from load-path also when installation-directory is nil. (Bug#10208)
3560
5b43da69
GM
35612012-01-10 Glenn Morris <rgm@gnu.org>
3562
74cc8ff9
GM
3563 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3564
7d8d6e4e
GM
3565 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3566 Update template values to be closer to their typical values these days.
5b43da69 3567
a0db8d43
EZ
35682012-01-09 Eli Zaretskii <eliz@gnu.org>
3569
3570 * xdisp.c (rows_from_pos_range): Accept additional argument
3571 DISP_STRING, and accept any glyph in a row whose object is that
3572 string as eligible for mouse highlight. Fixes mouse highlight of
3573 display strings from overlays. (Bug#10464)
3574
9a0115ab 35752012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3576
b9110d6a 3577 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3578 * fileio.c (auto_saving_dir_umask): New static var.
3579 (Fmake_directory_internal): Use it.
3580 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3581 creating the directory. The old code temporarily assigns
3582 too-generous permissions to the directory.
3583 (do_auto_save_eh): Clear it.
b9110d6a 3584 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3585 that the var is always cleared.
3586
6c1bd3f3
EZ
35872012-01-07 Eli Zaretskii <eliz@gnu.org>
3588
3589 * search.c (scan_buffer): Pass character positions to
3590 know_region_cache, not byte positions. (Bug#6540)
3591
069d2b50
L
35922012-01-07 LynX <_LynX@bk.ru> (tiny change)
3593
3594 * w32.c (sys_rename): Report EXDEV when rename of a directory
3595 fails because the target is on another logical disk. (Bug#10284)
3596
75bf0d33
DB
35972012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3598
3599 * xterm.c (x_embed_request_focus): New function.
3600
3601 * xterm.h: Add prototype.
3602
3603 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3604
1c6e5a32
GM
36052012-01-05 Glenn Morris <rgm@gnu.org>
3606
3607 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3608
651e947e
EZ
36092012-01-01 Eli Zaretskii <eliz@gnu.org>
3610
3611 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3612 Load gnutls_transport_set_lowat only if GnuTLS version is below
3613 2.11.1.
3614 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3615 GnuTLS versions below 2.11.1.
3616
3778cdd8
AL
36172011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3618
3619 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3620 to the doc string advising against its use for altering the way
3621 windows are scrolled.
3622
0e5317f7
KH
36232011-12-28 Kenichi Handa <handa@m17n.org>
3624
3625 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3626 coding-system ASCII compatible only when it does not produce BOM
3627 on encoding (Bug#10383).
3628
93d5ca1f
JD
36292011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3630
3631 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3632 can scroll.
3633 (create_and_show_popup_menu): Always use menu_position_func for
3634 Gtk3 (Bug#10361).
3635
ca22b785
AS
36362011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3637
3638 * callint.c (Fcall_interactively): Don't truncate prompt string.
3639
d048e1e6
EZ
36402011-12-23 Eli Zaretskii <eliz@gnu.org>
3641
3642 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3643 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3644 resumed from there (after widening). (Bug#10360)
d048e1e6 3645
5ccaba1f
JD
36462011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3647
3648 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3649
204ee57f
JD
36502011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3651
b81d40f0
JB
3652 * nsterm.m (x_free_frame_resources):
3653 Release f->output_data.ns->miniimage.
204ee57f
JD
3654 (ns_index_color): Fix indentation. Do not retain
3655 color_table->colors[i].
3656
3657 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3658 before returning.
3659
3660 * nsfns.m (x_set_background_color): Assign return value from
3661 ns_index_color to face-background instead of NSColor*.
3662 (ns_implicitly_set_icon_type): Fix indentation.
3663 Change assignment in for loop to comparison.
3664
3665 * emacs.c (ns_pool): New variable.
3666 (main): Assign ns_pool.
3667 (Fkill_emacs): Call ns_release_autorelease_pool.
3668
3669 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3670 autorelease fdesc, release fdAttrs and tdict.
3671 (ns_get_covering_families): Release charset.
3672 (ns_findfonts): Release NSFontDescriptor created with new.
3673 (ns_uni_to_glyphs): Fix indentation.
3674 (setString): Release attrStr before assigning new value.
3675
c803b2b7
JD
36762011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3677
678f4426
JD
3678 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3679 and NS_IMPL_COCOA.
3680 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3681 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3682
cd394be1 36832011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3684
5fecd5fc
JD
3685 * nsterm.m (ns_term_init): Subscribe for notifications
3686 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3687 to method trackingNotification in EmacsMenu.
3688
3689 * nsmenu.m (trackingMenu): New variable.
3771cb17 3690 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3691 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3692 from Aquamacs (Bug#7030).
678f4426
JD
3693
36942011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3695
c803b2b7
JD
3696 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3697 (symbol_to_nsstring): Fix indentation.
3698 (ns_symbol_to_pb): New function.
cae07000
SM
3699 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3700 (Fns_rotate_cut_buffers_internal): Remove.
3701 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3702 Fns_store_cut_buffer_internal.
3703 (ns_get_foreign_selection, Fx_own_selection_internal)
3704 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3705 (Fns_get_selection_internal, Fns_store_selection_internal):
3706 Use ns_symbol_to_pb and check if return value is nil.
3707 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3708 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3709 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3710 renamed to Sns_store_selection_internal.
3711 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3712 and remove this function.
3713 (ns_handle_selection_clear): Remove, never used.
3714 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3715 here.
3716
e1b01a3a
KB
37172011-12-17 Ken Brown <kbrown@cornell.edu>
3718
3719 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3720 GID is unknown (Bug#10257).
3721
2adb6e85
PE
37222011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3723
3724 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3725 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3726 which caused a build failure on GNU/Linux IA-64. This problem was
3727 introduced by my 2011-10-07 patch.
3728
d1d7b339
JL
37292011-12-15 Juri Linkov <juri@jurta.org>
3730
3731 * image.c (imagemagick_error): New function. (Bug#10112)
3732 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3733 Use `imagemagick_error' where ImageMagick functions return
3734 `MagickFalse'.
3735 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3736 proper order.
3737
100d5755
KH
37382011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3739
3740 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3741 fill background (Bug#8992).
3742
454592a6
MR
37432011-12-13 Martin Rudalics <rudalics@gmx.at>
3744
3745 * window.c (Vwindow_combination_resize)
3746 (Vwindow_combination_limit): Use t instead of non-nil in
3747 doc-strings.
61d4b438
MR
3748 (Vrecenter_redisplay): Add first sentence of doc-string on
3749 separate line.
53524d93 3750 (Frecenter): Fix doc-string typo.
454592a6 3751
3633e3aa
KH
37522011-12-11 Kenichi Handa <handa@m17n.org>
3753
3754 * coding.c (Funencodable_char_position): Pay attention to the
3755 buffer text relocation (Bug#9389).
3756
7b9d523a 37572011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3758
7b9d523a
JD
3759 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3760 gtk_init (Bug#10100).
3761
b73189c6
EZ
37622011-12-10 Eli Zaretskii <eliz@gnu.org>
3763
3764 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3765 IT->string is nil. (Bug#10263)
3766
f7dfe5d6
JD
37672011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3768
83faebb4
JD
3769 * nsterm.h (x_free_frame_resources): Declare.
3770
f7dfe5d6
JD
3771 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3772 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3773
3774 * nsterm.h (ns_get_defaults_value): Declare.
3775
3776 * nsterm.m (ns_default): Call ns_get_defaults_value.
3777
7cd4e72c
EZ
37782011-12-09 Eli Zaretskii <eliz@gnu.org>
3779
3780 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3781 (Bug#10170)
3782
b34d7317
YM
37832011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3784
3785 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3786 that where the value of an _OBJC_* symbol points to is in the .bss
3787 section (Bug#10240).
3788
76470ad1
KH
37892011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3790
3791 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3792 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3793
745fff94
KH
37942011-12-08 Kenichi Handa <handa@m17n.org>
3795
3796 * ftfont.c (get_adstyle_property): Fix previous change
3797 (Bug#10233).
3798
6e44397c
JB
37992011-12-07 Juanma Barranquero <lekktu@gmail.com>
3800
3801 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3802 dirs from the default value of EMACSLOADPATH (bug#10208).
3803
7efa6272
GM
38042011-12-07 Glenn Morris <rgm@gnu.org>
3805
3806 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3807 installation and source directories as well. (Bug#10208)
3808
f6fc4d87
CY
38092011-12-06 Chong Yidong <cyd@gnu.org>
3810
3811 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3812
2bf26180
GM
38132011-12-06 Glenn Morris <rgm@gnu.org>
3814
3815 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3816 as an error, not just -1. (Bug#10217)
3817
3a6ad4f0
CY
38182011-12-05 Chong Yidong <cyd@gnu.org>
3819
3820 * keyboard.c (process_special_events): New function.
3821 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3822
75a3b399
PE
38232011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3824
3825 * coding.c (encode_designation_at_bol): Don't use uninitialized
3826 local variable (Bug#9318).
3827
c3c9e25e
KH
38282011-12-05 Kenichi Handa <handa@m17n.org>
3829
3830 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3831 return Qnil (Bug#8046, Bug#10193).
3832
5eb05ea3
KH
38332011-12-05 Kenichi Handa <handa@m17n.org>
3834
3835 * coding.c (encode_designation_at_bol): New args charbuf_end and
3836 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3837 (coding_set_source): Return how many bytes coding->source was
3838 relocated.
3839 (coding_set_destination): Return how many bytes
3840 coding->destination was relocated.
3841 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3842 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3843
38442011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3845
3846 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3847 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3848 macro (Bug#9318).
3849
38502011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3851
3852 The following changes are to fix Bug#9318.
3853
a79703f5 3854 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3855 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3856 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3857 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3858
7dbda6df
JB
38592011-12-05 Juanma Barranquero <lekktu@gmail.com>
3860
3861 * lisp.h (process_quit_flag): Fix external declaration.
3862
6d5eb5b0
SM
38632011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3864
3865 Don't macro-inline non-performance-critical code.
3866 * eval.c (process_quit_flag): New function.
3867 * lisp.h (QUIT): Use it.
3868
a0c3fad0
JD
38692011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3870
3871 * nsfns.m (get_geometry_from_preferences): New function.
3872 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3873
6c07aac2
AS
38742011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3875
3876 * emacs.c (Qkill_emacs): Define.
3877 (syms_of_emacs): Initialize it.
3878 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3879 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3880 (quit_throw_to_read_char): Add parameter `from_signal'.
3881 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3882 * lisp.h (QUIT): Call Fkill_emacs if requested.
3883
c052ead4
JD
38842011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3885
3886 * widget.c (update_wm_hints): Return if wmshell is null.
3887 (widget_update_wm_size_hints): New function.
3888
3889 * widget.h (widget_update_wm_size_hints): Declare.
3890
3891 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3892 widget_update_wm_size_hints (Bug#10104).
3893
9e49252b
EZ
38942011-12-03 Eli Zaretskii <eliz@gnu.org>
3895
3896 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3897 before a newline, prepare the bidi iterator for consuming the
3898 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3899 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3900
02b16839
JL
39012011-12-02 Juri Linkov <juri@jurta.org>
3902
3903 * search.c (Fword_search_regexp): New Lisp function created from
3904 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3905 (Fword_search_backward, Fword_search_forward)
3906 (Fword_search_backward_lax, Fword_search_forward_lax):
3907 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3908 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3909
0068070e
SM
39102011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3911
3912 * fileio.c (Finsert_file_contents): Move after-change-function call
3913 to before the "handled:" label, since all "goto handled" appear in
3914 cases where the *-change-functions have already been properly called
3915 (bug#10117).
3916
3360a3fc
AS
39172011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3918
3919 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3920 waiting for input. (Bug#10169)
3921
73d6c093
EZ
39222011-11-30 Eli Zaretskii <eliz@gnu.org>
3923
3924 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3925 verifies glyph row's hash code--we have just reallocated the
3926 glyphs, so their contents can be complete garbage. (Bug#10164)
3927
febe6bea
JB
39282011-11-30 Juanma Barranquero <lekktu@gmail.com>
3929
3930 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3931
801a4313
EZ
39322011-11-30 Eli Zaretskii <eliz@gnu.org>
3933
3934 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3935 attributes are tested _before_ calling verify_row_hash, to protect
3936 against GCC re-ordering of the tests. (Bug#10164)
3937
2b56b87e
JD
39382011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3939
3940 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3941
3942 * xterm.c (handle_one_xevent): Only set async_visible and friends
3943 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3944 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3945 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3946
dbf31225
PE
39472011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3948
3949 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3950 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3951 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3952 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3953 All uses changed to use GCPRO1 etc.
3954 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3955 Revert to old implementation (i.e., before 2011-03-11).
3956
1305621b
YM
39572011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3958
3959 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3960 of scroll runs so as to avoid assigning disabled bogus rows and
3961 unnecessary graphics copy operations.
3962
8c9afb46
EZ
39632011-11-27 Eli Zaretskii <eliz@gnu.org>
3964
3965 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3966 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3967 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3968 (malloc, free, realloc, calloc): Redirect to e_* only when
3969 compiling Emacs.
3970
3971 * lisp.h (GCTYPEBITS): Move before first use.
3972 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3973 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3974 this macro definition.
3975
3976 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3977 _MSC_VER.
3978
54e9e3bf
JD
39792011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3980
6d5eb5b0
SM
3981 * gtkutil.c (xg_create_frame_widgets):
3982 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3983 present with Gtk+ 2.0.
3984
83aca1cb
PE
39852011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3986
3987 * fileio.c (Finsert_file_contents): Undo previous change; see
3988 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3989
5b76caa4
PE
39902011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3991
3992 Rename locals to avoid shadowing.
3993 * fileio.c (Finsert_file_contents):
3994 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3995 * process.c (wait_reading_process_output):
3996 Rename inner 'proc' to 'p' to avoid shadowing.
3997 Indent for consistency with usual Emacs style.
3998
8c535114
EZ
39992011-11-25 Eli Zaretskii <eliz@gnu.org>
4000
4001 * xdisp.c (redisplay_window): If cursor row is not fully visible
4002 after recentering, and scroll-conservatively is set to a large
4003 number, scroll window by a few more lines to make the cursor fully
4004 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4005 (start_display): Don't move to the next line if the display should
4006 start at a newline that is part of a display vector or an overlay
4007 string. (Bug#10119)
8c535114 4008
fa4fdb5c
JL
40092011-11-24 Juri Linkov <juri@jurta.org>
4010
4011 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4012 after the `MagickPingImage' call. (Bug#10112)
4013
90ec88df
CY
40142011-11-23 Chong Yidong <cyd@gnu.org>
4015
4016 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4017
56e2e794
MR
40182011-11-23 Martin Rudalics <rudalics@gmx.at>
4019
4020 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4021 making another buffer current. (Bug#10114)
4022
b6e64c41
GM
40232011-11-23 Glenn Morris <rgm@gnu.org>
4024
4025 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4026
6b21de18
CY
40272011-11-23 Chong Yidong <cyd@gnu.org>
4028
4029 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4030 using it (Bug#5984).
4031
b12cd789
EZ
40322011-11-22 Eli Zaretskii <eliz@gnu.org>
4033
4034 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4035 and header-lines, as they don't have one computed for them.
4036 (Bug#10098)
4037
4038 * .gdbinit (prow): Make displayed values more self-explaining.
4039 Add row's hash code.
4040
261b6fd4
LMI
40412011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4042
4043 * process.c (wait_reading_process_output): Fix asynchrounous
4044 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4045 (wait_reading_process_output): Add comment and URL.
261b6fd4 4046
e7cfd277
JD
40472011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4048
4049 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4050
a9b9b7f5
CY
40512011-11-21 Chong Yidong <cyd@gnu.org>
4052
4053 * window.c (Fnext_window, Fprevious_window): Doc fix.
4054
b0d15b4f
SM
40552011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4056
4057 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4058
fe7a3057
JB
40592011-11-20 Juanma Barranquero <lekktu@gmail.com>
4060
4061 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4062
d2999b1a
MR
40632011-11-20 Martin Rudalics <rudalics@gmx.at>
4064
4065 * window.c (Fset_window_combination_limit): Rename argument
4066 STATUS to LIMIT.
4067 (Vwindow_combination_limit): Remove "status" from doc-string.
4068
d5ff9cd0
AS
40692011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4070
4071 * m/ibms390.h: Remove.
4072 * m/ibms390x.h: Don't include "ibms390.h".
4073
a5bb9bd3
SM
40742011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4075
4076 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4077 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4078
cd1181db
JB
40792011-11-20 Juanma Barranquero <lekktu@gmail.com>
4080
4081 * casetab.c (Fset_case_table):
4082 * charset.c (Fcharset_after): Fix typos.
4083
615a3b8d 40842011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4085
17e845af
PE
4086 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4087 Otherwise, valgrind does not work on some platforms.
4088 Problem reported by Andreas Schwab in
6a0bf43d
PE
4089 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4090 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4091 is set, removing the need for VIRT_ADDRESS_VARIES.
4092 (PURE_P): Use a more-efficient implementation that needs just one
4093 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4094 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4095 to 4 (xorl, subq, cmpq, setbe).
4096 * alloc.c (pure): Always extern now, since that's the
4097 VIRT_ADDR_VARIES behavior.
4098 (PURE_POINTER_P): Use a single comparison, not two, for
4099 consistency with the new puresize.h.
4100 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4101 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4102 Remove VIRT_ADDR_VARIES no longer needed.
4103
f8fe6f96
EZ
41042011-11-19 Eli Zaretskii <eliz@gnu.org>
4105
4106 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4107 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4108 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4109 behave as if the cursor position were at the window margin.
4110
4111 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4112 and the cursor position is out of bounds, behave as if the cursor
4113 position were at the window margin. (Bug#10075)
4114
df05a53c
CY
41152011-11-18 Chong Yidong <cyd@gnu.org>
4116
4117 * window.c (Fwindow_combination_limit): Make first argument
4118 non-optional, since it is meaningless for live windows like the
4119 selected window.
61ccba97 4120
2071918e
DA
41212011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4122
4123 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4124
b50a28de
SM
41252011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4126
4127 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4128 (graft_intervals_into_buffer): Simplify.
4129
015137db
EZ
41302011-11-18 Eli Zaretskii <eliz@gnu.org>
4131
4132 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4133 hash values of the two rows.
4134 (copy_row_except_pointers): Preserve the used[] arrays and the
4135 hash values of the two rows. (Bug#10035)
68c95424 4136 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4137
4138 * xdisp.c (row_hash): New function, body extracted from
4139 compute_line_metrics.
4140 (compute_line_metrics): Call row_hash, instead of computing the
4141 hash code inline.
4142
4143 * dispnew.c (verify_row_hash): Call row_hash for computing the
4144 hash code of a row, instead of duplicating code from xdisp.c.
4145
4146 * dispextern.h (row_hash): Add prototype.
4147
a2addb04
TH
41482011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4149
4150 * frame.c (delete_frame): Don't delete the terminal when the last
4151 X frame is closed if emacs is built with GTK toolkit.
4152
df85d315
JB
41532011-11-17 Juanma Barranquero <lekktu@gmail.com>
4154
4155 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4156
a0c2d0ae
MR
41572011-11-17 Martin Rudalics <rudalics@gmx.at>
4158
4159 * window.c (Vwindow_splits): Rename to
4160 Vwindow_combination_resize. Suggested by Juri Linkov.
4161 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4162 of Vwindow_splits.
4163
58179cce
JB
41642011-11-16 Juanma Barranquero <lekktu@gmail.com>
4165
7877f373
JB
4166 * nsfns.m (Fns_font_name):
4167 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4168
b6f67890
MR
41692011-11-16 Martin Rudalics <rudalics@gmx.at>
4170
4171 * window.h (window): Rename slot "nest" to "combination_limit".
4172 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4173 (Fset_window_nest): Rename to Fset_window_combination_limit.
4174 (Vwindow_nest): Rename to Vwindow_combination_limit.
4175 (recombine_windows, make_parent_window, make_window)
4176 (Fsplit_window_internal, saved_window)
4177 (Fset_window_configuration, save_window_save): Rename all
4178 occurrences of window_nest to window_combination_limit.
4179
c7015153
JB
41802011-11-15 Juanma Barranquero <lekktu@gmail.com>
4181
4182 * image.c (imagemagick_load_image): Fix typo.
4183
322ad6ec
EZ
41842011-11-14 Eli Zaretskii <eliz@gnu.org>
4185
4186 * xdisp.c (display_line): Move the call to
4187 highlight_trailing_whitespace before the call to
4188 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4189 faces of all the glyphs to compute ROW's hash value.
4190 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4191
f067b8ec
JB
41922011-11-14 Juanma Barranquero <lekktu@gmail.com>
4193
4194 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4195 just return (bug#10044).
4196
1e5b2111
EZ
41972011-11-12 Eli Zaretskii <eliz@gnu.org>
4198
7ef3cbd5
EZ
4199 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4200 with user-defined heap size. Bump the default size of the temacs
4201 heap to 27MB, to avoid memory warning when running temacs.
4202 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4203
1e5b2111
EZ
4204 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4205 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4206 (verify_row_hash) [XASSERTS]: New function.
4207 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4208 that the hash value of glyph rows is correct.
1e5b2111 4209
89d61221
MR
42102011-11-12 Martin Rudalics <rudalics@gmx.at>
4211
4212 * window.h (window): Remove splits slot.
4213 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4214 (Fdelete_other_windows_internal, make_parent_window)
4215 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4216 (Fset_window_configuration, save_window_save): Don't deal with
4217 split status of windows.
4218 (saved_window): Remove splits slot.
4219 (Vwindow_splits): Rewrite doc-string.
4220
97f18cc8
JD
42212011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4222
4223 * xfns.c (unwind_create_frame):
4224 * nsfns.m (unwind_create_frame):
4225 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4226 Vframe_list (Bug#9999).
4227
22a648b4
DA
42282011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4229
0b381c7e 4230 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4231
659afede
KH
42322011-11-11 Kenichi Handa <handa@m17n.org>
4233
4234 * callproc.c (Fcall_process): Set the member dst_multibyte of
4235 process_coding.
4236
9ac0394b
KH
42372011-11-11 Johan Bockgård <bojohan@gnu.org>
4238
4239 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4240 avoid a crash (bug#9496).
4241
2fbdc249
CY
42422011-11-09 Chong Yidong <cyd@gnu.org>
4243
4244 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4245 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4246
ac6b1f81
PE
42472011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4248
4249 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4250
09db192c
PE
42512011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4252
4253 Avoid some portability problems by eschewing 'extern inline' functions.
4254 The trivial performance wins aren't worth the portability hassles; see
4255 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4256 et seq.
4257 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4258 (window_box_width, window_box_left, window_box_left_offset)
4259 (window_box_right, window_box_right_offset): Undo previous change,
4260 by removing the "extern"s.
4261 * intervals.c (adjust_intervals_for_insertion)
4262 (adjust_intervals_for_deletion): Undo previous change,
4263 making these static again.
4264 (offset_intervals, temp_set_point_both, temp_set_point)
4265 (copy_intervals_to_string): No longer inline.
4266 * xdisp.c (window_text_bottom_y, window_box_width)
4267 (window_box_height, window_box_left_offset)
4268 (window_box_right_offset, window_box_left, window_box_right)
4269 (window_box): No longer inline.
4270
105216ed
CY
42712011-11-08 Chong Yidong <cyd@gnu.org>
4272
4273 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4274 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4275 Signal an error if not a live window.
105216ed
CY
4276 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4277 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4278
ae9e237f
JB
42792011-11-07 Juanma Barranquero <lekktu@gmail.com>
4280
4281 * lisp.h (syms_of_abbrev): Remove declaration.
4282 Reported by CHENG Gao <chenggao@royau.me>.
4283
c7aa8333
EZ
42842011-11-07 Eli Zaretskii <eliz@gnu.org>
4285
4286 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4287 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4288 of temacs in GUI mode.
4289
be7f5545
MR
42902011-11-07 Martin Rudalics <rudalics@gmx.at>
4291
4292 * window.h: Declare delete_all_child_windows instead of
4293 delete_all_subwindows.
4294 * window.c (Fwindow_nest, Fset_window_nest)
4295 (Fset_window_new_total, Fset_window_new_normal)
4296 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4297 (delete_all_subwindows): Rename to delete_all_child_windows.
4298 (Fdelete_other_windows_internal, Fset_window_configuration):
4299 Call delete_all_child_windows instead of delete_all_subwindows.
4300 * frame.c (delete_frame): Call delete_all_child_windows instead
4301 of delete_all_subwindows.
4302
ca78dc43
PE
43032011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4304
4305 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4306 This is also needed for porting to any host where GC_MARK_STACK is
4307 not GC_MAKE_GCPROS_NOOPS.
4308 (which_symbols): Use it.
4309
a0241d01
KH
43102011-11-07 Kenichi Handa <handa@m17n.org>
4311
4312 * coding.c (coding_set_destination): Check coding->src_pos only
4313 when coding->src_object is a buffer (bug#9910).
4314
4315 * process.c (send_process): Set the member src_multibyte of coding
4316 to 0 (bug#9911) when sending a unibyte text.
4317
4318 * callproc.c (Fcall_process): Set the member src_multibyte of
4319 process_coding to 0 (bug#9912).
4320
a64bfdfa 43212011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4322
4323 * xmenu.c (cleanup_widget_value_tree): New function.
4324 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4325 calling free_menubar_widget_value_tree directly (Bug#9830).
4326
cb41b32a
PE
43272011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4328
4329 Fix some portability problems with 'inline'.
4330 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4331 (window_box_width, window_box_left, window_box_left_offset)
4332 (window_box_right, window_box_right_offset): Declare extern.
4333 Otherwise, these inline functions do not conform to C99 and
4334 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4335 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4336 * intervals.c (adjust_intervals_for_insertion)
4337 (adjust_intervals_for_deletion): Now extern, because otherwise the
4338 extern inline functions 'offset_intervals' couldn't refer to it.
4339 (static_offset_intervals): Remove.
4340 (offset_intervals): Rewrite using the old contents of
4341 static_offset_intervals. The old version didn't conform to C99
4342 because an extern inline function contained a reference to an
4343 identifier with static linkage.
4344
b7041366
AS
43452011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4346
4347 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4348 GC.
4349
88a37c4d
EZ
43502011-11-06 Eli Zaretskii <eliz@gnu.org>
4351
4352 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4353 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4354 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4355 return Qleft_to_right.
4356
49745b39
CY
43572011-11-06 Chong Yidong <cyd@gnu.org>
4358
4359 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4360 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4361 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4362 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4363 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4364 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4365 (Fwindow_vscroll): Doc fix.
4366 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4367 argument, since it makes no sense to pass a live window and for
4368 consistency with window-child.
4369
1f05cd82
CS
43702011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4371
4372 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4373 support MSVC.
4374
22610910
JR
43752011-11-05 Jason Rumney <jasonr@gnu.org>
4376
4377 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4378 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4379 fonts (Bug#6029).
4380 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4381 bitwise arithmetic preventing use of unicode-sip and non-truetype
4382 opentype fonts.
4383
a06776b2
EZ
43842011-11-05 Eli Zaretskii <eliz@gnu.org>
4385
3ad924ba
EZ
4386 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4387 "emacs"-only part.
4388
a06776b2
EZ
4389 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4390 initialization code to keep similarity to xfns.c after changes
4391 from 2011-11-05.
4392
c9e7db78
JD
43932011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4394
a97f8f3f
JD
4395 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4396 (unwind_create_frame): New function (Bug#9943).
4397 (Fx_create_frame): Restructure code to be more similar to the one in
4398 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4399 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4400 Move terminal->reference_count++ just before making the frame official
4401 (Bug#9943).
4402
4403 * nsterm.m (x_free_frame_resources): New function.
4404 (x_destroy_window): Move code to x_free_frame_resources.
4405
c9e7db78 4406 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4407 (Fx_create_frame, x_create_tip_frame):
4408 Move terminal->reference_count++ just before making the frame
75f1671a 4409 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4410 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4411
a6fc3b5c
EZ
44122011-11-05 Eli Zaretskii <eliz@gnu.org>
4413
4414 Support MSVC build with newer versions of Visual Studio.
4415 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4416 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4417 nt/gmake.defs.
4418
4419 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4420 which are not supported by MSVC.
4421 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4422 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4423 bitfields.
4424 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4425 types in bitfields.
4426 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4427
4428 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4429
58179cce 44302011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4431
4432 Support MSVC build with newer versions of Visual Studio.
4433 * w32.c: Don't include w32api.h for MSVC.
4434 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4435
4436 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4437 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4438 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4439 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4440 e_* cousins.
4441 (alloca) [_MSC_VER]: Define to _alloca.
4442
4443 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4444
4445 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4446
a58c13ed
EZ
44472011-11-04 Eli Zaretskii <eliz@gnu.org>
4448
4449 * xdisp.c (note_mouse_highlight): If either of
4450 previous/next-single-property-change returns nil, treat that as
4451 the beginning or the end of the buffer. (Bug#9955)
4452
fe0b6370
JD
44532011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4454
a58c13ed 4455 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4456 label is not null (Bug#9951).
4457 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4458 may be NULL.
4459
89bd5ee1
EZ
44602011-11-04 Eli Zaretskii <eliz@gnu.org>
4461
4462 * window.c (Fwindow_body_size): Mention in the doc string that the
4463 return value is in frame's canonical units. (Bug#9949)
4464
84c3edb9
EZ
44652011-11-03 Eli Zaretskii <eliz@gnu.org>
4466
4e2fb5c7
EZ
4467 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4468
84c3edb9 4469 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4470 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4471 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4472
bc17a887
EZ
44732011-11-01 Eli Zaretskii <eliz@gnu.org>
4474
4475 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4476 Don't stop backward scan on the continuation glyph, even though
4477 its CHARPOS is positive.
6d5eb5b0
SM
4478 (mouse_face_from_buffer_pos, note_mouse_highlight):
4479 Rename cover_string to disp_string.
bc17a887 4480
4ee88440
MR
44812011-11-01 Martin Rudalics <rudalics@gmx.at>
4482
4483 * window.c (temp_output_buffer_show): Don't use
4484 Vtemp_buffer_show_specifiers.
4485 (Vtemp_buffer_show_specifiers): Remove unused variable.
4486
c2ff3c02
EZ
44872011-10-30 Eli Zaretskii <eliz@gnu.org>
4488
4489 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4490 past the beginning of the current glyph matrix.
4491
58179cce 44922011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4493
4494 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4495 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4496 HAVE_GTK3 (Bug#9869).
b77a6a7f 4497
3b574623
JD
4498 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4499 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4500
b77a6a7f
JD
4501 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4502
4503 * xterm.c: Declare x_handle_net_wm_state to return int.
4504 (handle_one_xevent): Check if we are iconified but don't have
4505 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4506 (get_current_wm_state): Return non-zero if not hidden,
4507 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4508 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4509 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4510 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4511
196e41e4
PE
45122011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4513
4514 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4515 so that this new function doesn't get optimized away by a
4516 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4517
021f2e1a
AS
45182011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4519
4520 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4521
8b058d44
EZ
45222011-10-29 Eli Zaretskii <eliz@gnu.org>
4523
4524 Fix the `xbytecode' command.
4525 * .gdbinit (xprintbytestr): New command.
b50a28de 4526 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4527 (xbytecode): Print the byte-code string as well.
4528
4452fb80
EZ
45292011-10-29 Kim Storm <storm@cua.dk>
4530
8b058d44
EZ
4531 * alloc.c (which_symbols): New function.
4532
21b72067
AS
45332011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4534
4535 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4536 line. (Bug#9903)
4537
83ed7b5c
GM
45382011-10-29 Glenn Morris <rgm@gnu.org>
4539
4540 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4541 Not clear what it was for, and it causes various bugs. (Bug#9839)
4542
5a7a728b
EZ
45432011-10-28 Eli Zaretskii <eliz@gnu.org>
4544
4545 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4546 possible random value that matches one of those tested as
4547 condition to clear the mouse face.
4548
d3d0842f
CY
45492011-10-28 Chong Yidong <cyd@gnu.org>
4550
4551 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4552
31b39d13
DN
45532011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4554
4555 * window.c (make_window): Initialize phys_cursor_on_p.
4556
9aba6043
SM
45572011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4558
4559 * lisp.h (struct Lisp_Symbol): Update comments.
4560
c20992f4
JB
45612011-10-28 Juanma Barranquero <lekktu@gmail.com>
4562
4563 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4564
db4f02f2
EZ
45652011-10-28 Eli Zaretskii <eliz@gnu.org>
4566
4567 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4568 <oslsachem@gmail.com> for helping to debug this.
4569
4570 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4571 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4572 (g_b_init_get_glyph_outline_w): New static variables.
4573 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4574 (GetGlyphOutlineW_Proc): New typedefs.
4575 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4576 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4577 New functions.
4578 (w32font_open_internal, compute_metrics):
4579 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4580 instead of calling the "wide" APIs directly.
4581
4582 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4583
4584 * w32.h (syms_of_w32font): Add prototype.
4585
87e68db4
JB
45862011-10-27 Juanma Barranquero <lekktu@gmail.com>
4587
4588 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4589 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4590 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4591 (Fmove_to_window_line): Doc fix.
4592
435c1d67
CY
45932011-10-27 Chong Yidong <cyd@gnu.org>
4594
4595 * process.c (make_process): Set gnutls_state to NULL.
4596
4597 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4598 non-NULL, regardless of GNUTLS_INITSTAGE.
4599 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4600 an error. Set process slots as soon as we allocate them.
4601
4602 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4603
9c6c6f49
CY
46042011-10-27 Chong Yidong <cyd@gnu.org>
4605
9aba6043
SM
4606 * gnutls.c (emacs_gnutls_deinit): New function.
4607 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4608 (Fgnutls_deinit, Fgnutls_boot): Use it.
4609
4610 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4611 (deactivate_process): Call emacs_gnutls_deinit.
4612
657d08d3
JB
46132011-10-27 Juanma Barranquero <lekktu@gmail.com>
4614
4615 * image.c (x_create_x_image_and_pixmap):
4616 * w32.c (sys_rename, w32_delayed_load):
4617 * w32font.c (fill_in_logfont):
4618 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4619
5430d399
JB
46202011-10-26 Juanma Barranquero <lekktu@gmail.com>
4621
4622 * w32fns.c (w32_default_color_map): New function,
4623 extracted from Fw32_default_color_map.
a7ef684b 4624 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4625
fe0055fa
PE
46262011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4627
4628 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4629
e6346438
SM
46302011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4631
4632 * keyboard.c (test_undefined): New function (bug#9751).
4633 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4634
e112cc37
ET
46352011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4636
4637 * sysdep.c (init_sys_modes): Fix the check for the controlling
4638 terminal (Bug#6649).
4639
7b5d6677
EZ
46402011-10-20 Eli Zaretskii <eliz@gnu.org>
4641
4642 * dispextern.h (struct bidi_it): New member next_en_type.
4643
4644 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4645 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4646 current character, check also for next_en_type being WEAK_EN.
4647 (bidi_resolve_weak): Don't enter the expensive loop if the current
4648 position is before next_en_pos. Record the bidi type of the first
4649 non-ET, non-BN character we find, in addition to its position.
4650 (bidi_level_of_next_char): Invalidate next_en_type when
4651 next_en_pos is over-stepped.
4652
7da0b018
PE
46532011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4654
4655 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4656 * editfns.c: Rewrite current-time-zone so that it invokes
4657 the equivalent of (format-time-string "%Z") to get the time zone name.
4658 This fixes a bug when the time zone name contains characters that
4659 need converting from the system time locale to Emacs internal format.
4660 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4661 that patch fixed format-time-string to do the conversion, but
4662 I forgot to fix current-time-zone.
4663 (format_time_string): New function, containing most of
4664 what Fformat_time_string used to contain.
4665 (Fformat_time_string): Rewrite in terms of format_time_string.
4666 This doesn't change this function's behavior.
4667 (current-time-zone): Rewrite to use format_time_string.
4668 This fixes the bug reported by Michael Schierl in
4669 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4670 Jason Rumney's 2007-06-07 change worked around this bug, but
4671 didn't fix it.
4672 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4673
8547b010
EZ
46742011-10-19 Eli Zaretskii <eliz@gnu.org>
4675
4676 * xdisp.c (start_display): If the character at POS is displayed
4677 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4678 (try_window_reusing_current_matrix): If a line ends in a display
4679 vector or the next line starts in a display vector, continue
4680 redrawing the window even though the character position of
4681 start_row was reached.
8547b010
EZ
4682 (Bug#9771, part 2)
4683
4e948d15
CY
46842011-10-18 Chong Yidong <cyd@gnu.org>
4685
4686 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4687 with nobreak-char-display too.
4688
4787455f
EZ
46892011-10-18 Eli Zaretskii <eliz@gnu.org>
4690
4691 Fix part 3 of bug#9771.
4692 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4693 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4694 non-neutral characters if the current character is a paragraph
4695 separator (a.k.a. Newline). This avoids running the same
4696 expensive loop twice, once when we consume the preceding newline
4697 and the other time when the line actually needs to be displayed.
4698 Avoid the loop when we see neutrals on the base embedding level
4699 following a character whose directionality is the same as the
4700 paragraph's. This avoids running the expensive loop when a line
4701 ends in a long sequence of neutrals, like control characters.
4702 Add assertion against STRONG_AL type. Slightly rearrange code
4703 that determines the type of a neutral given the first non-neutral
4704 that follows it.
4705 (bidi_level_of_next_char): Set next_en_pos to zero when
4706 invalidating its info.
4707
2c91f553
EZ
47082011-10-17 Eli Zaretskii <eliz@gnu.org>
4709
4710 * xdisp.c (push_display_prop): Determine whether to record string
4711 or buffer position by IT->string, not by IT->method. Allow
4712 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4713 (move_it_vertically_backward): Don't look for character position
4714 immediately after the newline when in a continuation line.
4715 (Bug#9771, part 1)
2c91f553 4716
c7b08b0d
MR
47172011-10-15 Martin Rudalics <rudalics@gmx.at>
4718
4719 * window.c (coordinates_in_window): Rewrite and delabelize
4720 vertical border check. (Bug#5357) (Bug#9618)
4721
6b02f655
SM
47222011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4723
4724 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4725 errors in XSetWindowBorder (bug#9310).
4726
81d40c92
DA
47272011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4728
4729 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4730 avoid crash when xmalloc overrun checking is enabled.
4731
d4172c3b
EZ
47322011-10-13 Eli Zaretskii <eliz@gnu.org>
4733
4734 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4735 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4736 cursor motion with <left> and <right> arrow keys.
4737
4738 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4739 some callers set that themselves.
4740
b00eea75
EZ
47412011-10-12 Eli Zaretskii <eliz@gnu.org>
4742
4743 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4744 display string and the previous row comes from the same string and
4745 is empty. (Bug#9739) (Bug#9738)
4746
8fe012c4
SM
47472011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4748
4749 * doc.c (get_doc_string): Encode file name (bug#9735).
4750
0074aef2
EZ
47512011-10-12 Eli Zaretskii <eliz@gnu.org>
4752
79beb178
EZ
4753 * bidi.c (bidi_level_of_next_char):
4754 * xdisp.c (get_visually_first_element): Remove old incorrect
4755 comments regarding the Unicode Line Separator character.
4756
0074aef2
EZ
4757 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4758
6e4b3fbe
DA
47592011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4760
4761 * alloc.c (Fgc_status): Do not access beyond zombies array
4762 boundary if nzombies > MAX_ZOMBIES.
4763 * alloc.c (dump_zombies): Add missing format specifier.
4764
0324f3af
PE
47652011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4766
b5525cac
PE
4767 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4768 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4769
0324f3af
PE
4770 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4771 Some packages use them to denote characters with modifiers.
4772
e9b5f888
AS
47732011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4774
4775 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4776 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4777 matching a pp-number. Rename parameter var to var1.
4778
127827c0
SM
47792011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4780
4781 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4782
c8fd3bd0
GM
47832011-10-08 Glenn Morris <rgm@gnu.org>
4784
4785 * callint.c (Fcall_interactively): Give a more explicit error for the
4786 'c' case with a non-character input. (Bug#8479)
4787
352ec8ff
EZ
47882011-10-08 Eli Zaretskii <eliz@gnu.org>
4789
03669ccb
EZ
4790 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4791 lines.
7061c986
EZ
4792 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4793 lines that are hscrolled on the left.
03669ccb 4794
352ec8ff
EZ
4795 * dispnew.c (buffer_posn_from_coords): Account for a possible
4796 presence of header-line. (Bug#4426)
4797
a66cfb1c
SM
47982011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4799
6b02f655
SM
4800 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4801 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4802
7c5ee88e
PE
48032011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4804
4805 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4806 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4807 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4808 this makes Emacs dump core during garbage collection on rare
4809 occasions. sizeof is obviously inferior to offsetof here, so
4810 stick with offsetof.
4811 (GC_POINTER_ALIGNMENT): New macro.
4812 (mark_memory): Omit 3rd (offset) arg; caller changed.
4813 Don't assume EMACS_INT alignment is the same as pointer alignment.
4814
df1bbe5b
SM
48152011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4816
4817 * keyboard.c (read_key_sequence_remapped): New var.
4818 (read_key_sequence): Compute remapping in the right buffer.
4819 (command_loop_1): Use read_key_sequence's remapping directly.
4820
51553db6
SM
48212011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4822
32c1fffd
SM
4823 * dired.c (file_name_completion): Don't expand file name.
4824 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4825 before checking file name handler.
4826
51553db6
SM
4827 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4828 they've been requested explicitly (bug#9591).
4829
b6bd1599 48302011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4831
4832 * keymap.c (Fsingle_key_description): Use make_specified_string
4833 instead of build_string to build string from push_key_description.
4834 (Bug#5193)
4835
f701dc2a
PE
48362011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4837
4222c55d
PE
4838 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4839 This fixes a Y2038 bug on 64-bit hosts.
4840 * buffer.c (reset_buffer):
4841 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4842 (Fclear_buffer_auto_save_failure):
4843 Use 0, not -1, to represent an unset failure time, since time_t
4844 might not be signed.
4845
f701dc2a
PE
4846 Remove dependency on glibc malloc internals.
4847 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4848 Move back here from lisp.h, but with their new implementations.
4849 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4850 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4851 * charset.c (charset_table_init): New static var.
4852 (syms_of_charset): Use it instead of xmalloc. This removes a
4853 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4854 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4855 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4856 Move back to alloc.c.
4857 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4858 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4859
9ceebf39
JD
48602011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4861
4862 * nsterm.m (windowDidResize): Call x_set_window_size only when
4863 ns_in_resize is true. Otherwise set pixelwidth/height and
4864 call change_frame_size (Bug#9628).
4865
cb993c58
PE
48662011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4867
3930c88b
PE
4868 Port --enable-checking=all to Fedora 14 x86-64.
4869 * charset.c (syms_of_charset): Also account for glibc malloc's
4870 internal overhead when calculating the initial malloc maximum.
4871
cb993c58
PE
4872 Port --enable-checking=all to Fedora 14 x86.
4873 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4874 Move to lisp.h.
4875 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4876 (overrun_check_realloc, overrun_check_free):
4877 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4878 That way, xmalloc returns a properly-aligned pointer even if
4879 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4880 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4881 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4882 into account when calculating the initial malloc maximum.
4883 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4884 Move here from alloc.c, so that charset.c can use it too.
4885 Properly align; the old code wasn't right for common 32-bit hosts
4886 when configured with --enable-checking=all.
4887 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4888 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4889
31bed486
EZ
48902011-09-29 Eli Zaretskii <eliz@gnu.org>
4891
04c70788 4892 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4893 use EDOM.
4894
fbcaa2f3
EZ
48952011-09-28 Eli Zaretskii <eliz@gnu.org>
4896
4897 * xdisp.c (compute_display_string_end): If there's no display
4898 string at CHARPOS, return -1.
4899
4900 * bidi.c (bidi_fetch_char): When compute_display_string_end
4901 returns a negative value, treat the character as a normal
4902 character not covered by a display string. (Bug#9624)
4903
a239d4e9
JB
49042011-09-28 Juanma Barranquero <lekktu@gmail.com>
4905
4906 * lread.c (Fread_from_string): Fix typo in docstring.
4907
88652fd5
EZ
49082011-09-27 Eli Zaretskii <eliz@gnu.org>
4909
4910 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4911 newline, reseat the iterator instead of bidi-iterating there one
4912 character at a time. (Bug#9610)
32c1fffd
SM
4913 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4914 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4915
ed497dd4
AS
49162011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4917
4918 * lread.c (readevalloop): Use correct code for NBSP.
4919 (read1): Likewise. (Bug#9608)
4920
b2bf61aa
MA
49212011-09-25 Michael Albinus <michael.albinus@gmx.de>
4922
4923 * dbusbind.c (Fdbus_register_signal): When service is not
4924 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4925
32bbb17c
GM
49262011-09-25 Glenn Morris <rgm@gnu.org>
4927
4928 * buffer.c (truncate-lines): Doc fix.
4929
94e0933e
CY
49302011-09-24 Chong Yidong <cyd@stupidchicken.com>
4931
4932 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4933 (Fset_window_next_buffers): Doc fix.
4934
cddde921
GM
49352011-09-24 Glenn Morris <rgm@gnu.org>
4936
4937 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4938
1260aef1
PE
49392011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4940
25b4bfa0
PE
4941 Fix minor problems found by static checking.
4942 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4943 * indent.c (Fvertical_motion): Fix == vs = typo.
4944
e3cbd34b
EZ
49452011-09-24 Eli Zaretskii <eliz@gnu.org>
4946
a66cfb1c
SM
4947 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4948 Default value is now t. Doc fix.
6bf7006f 4949
e3cbd34b 4950 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4951 logic when moving up, not only when moving down. Fix the
e3cbd34b 4952 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4953 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4954
4955 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4956 CHARPOS is covered by a display string which includes newlines.
4957 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4958 is covered by a display string with embedded newlines.
4959
a3de0cbd
MA
49602011-09-24 Michael Albinus <michael.albinus@gmx.de>
4961
4962 * dbusbind.c (Fdbus_register_signal): Add match rule to
4963 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4964 (Fdbus_register_method, Vdbus_registered_objects_table):
4965 Fix docstring.
a3de0cbd 4966
b260039d
JM
49672011-09-24 Jim Meyering <meyering@redhat.com>
4968
32c1fffd 4969 do not ignore write error for any output size
b260039d
JM
4970 The previous change was incomplete.
4971 While it makes emacs --batch detect the vast majority of stdout
4972 write failures, errors were still ignored whenever the output size is
4973 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4974 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4975 && echo FAIL: ignored write error
4976 FAIL: ignored write error
4977 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4978 && echo FAIL: ignored write error
4979 FAIL: ignored write error
4980 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4981
8eca8a7c
AS
49822011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4983
4984 * emacs.c (Fkill_emacs): In noninteractive mode exit
4985 non-successfully if a write error occurred on stdout. (Bug#9574)
4986
3341db62
EZ
49872011-09-21 Eli Zaretskii <eliz@gnu.org>
4988
4989 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4990 the xassert test.
4991
4992 * dispextern.h (struct it): Update the comment documenting what
4993 can it->OBJECT be.
4994
8c203dbf
EZ
49952011-09-20 Eli Zaretskii <eliz@gnu.org>
4996
4997 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4998 a display string, extend search for cursor position to end of row.
4999 (find_row_edges): If the row ends in a newline from a display
5000 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5001 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5002 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5003 non-empty line. Fixes confusing cursor motion with arrow keys at
5004 the beginning of a line that starts with whitespace.
8c203dbf 5005
a4824228
LMI
50062011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5007
5008 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5009 (bug#9493).
5010
33ed493b
CY
50112011-09-18 Chong Yidong <cyd@stupidchicken.com>
5012
5013 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5014 boolean (Bug#9154).
5015
56cd55c8
EZ
50162011-09-18 Eli Zaretskii <eliz@gnu.org>
5017
5018 * xdisp.c (display_line): Record maximum and minimum buffer
5019 positions even if no glyphs were produced (e.g., by a zero-width
5020 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5021 buffer positions that will be removed from the glyph row because
5022 they don't fit.
c02dcedf
EZ
5023 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5024 column is beyond frame width: don't subtract 1 "pixel" when
5025 computing width of the stretch.
3e62b7e0
EZ
5026 (reseat_at_next_visible_line_start): Undo the change made on
5027 2011-09-17 that saved paragraph information and restored it after
5028 the call to `reseat'. (Bug#9545)
56cd55c8 5029
5ed99d36 50302011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5031
5032 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5033 and turn window cursor on if cleared (Bug#9415).
5034
5ed99d36 50352011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5036
5037 * search.c (boyer_moore): Take unibyte characters from pattern
5038 literally. (Bug#9458)
5039
9bade7b2
EZ
50402011-09-18 Eli Zaretskii <eliz@gnu.org>
5041
5042 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5043
e5e9d610
PE
50442011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5045
87e4427a
PE
5046 Fix minor problem found by static checking.
5047 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5048 initialized, to pacify gcc -Wuninitialized.
5049
e5e9d610
PE
5050 * fileio.c: Report proper errno when syscall falls.
5051 (Finsert_file_contents): Save and restore errno,
5052 so that report_file_error outputs the correct diagnostic.
5053 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5054
a1674f0b
EZ
50552011-09-18 Eli Zaretskii <eliz@gnu.org>
5056
5057 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5058
fbfb6dd4
EZ
50592011-09-17 Eli Zaretskii <eliz@gnu.org>
5060
5061 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5062 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5063
bb187662
EZ
50642011-09-17 Eli Zaretskii <eliz@gnu.org>
5065
1137e8b8 5066 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5067 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5068
5069 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5070 (bidi_find_paragraph_start): Search back for paragraph beginning
5071 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5072 (bidi_move_to_visually_next): Only trigger paragraph-related
5073 computations when the last character is a newline or at EOB, not
5074 just any NEUTRAL_B. (Bug#9470)
5075
bb187662
EZ
5076 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5077 truncated lines if point is covered by a display string. (Bug#9524)
5078
2e621251
PE
50792011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5080
5081 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5082 (cons_to_x_long): New function.
5083 (lisp_data_to_selection_data): Use it. Correct the test for
5084 short-versus-long data; it was negated. Break out of vector
5085 loop, for efficiency, when a long datum is discovered.
5086
91a15bc6
SM
50872011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5088
5089 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5090
b41c3a35
EZ
50912011-09-16 Eli Zaretskii <eliz@gnu.org>
5092
5093 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5094 GCC PR/17406) by declaring this function with external scope.
5095
7812ba2d
PE
50962011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5097
5098 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5099 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5100
cf7edc2a
AS
51012011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5102
5103 * editfns.c (Fformat): Correctly handle text properties on "%%".
5104
bd01620e
EZ
51052011-09-15 Eli Zaretskii <eliz@gnu.org>
5106
5107 * xterm.c (x_draw_composite_glyph_string_foreground):
5108 * w32term.c (x_draw_composite_glyph_string_foreground):
5109 * term.c (encode_terminal_code):
5110 * composite.c (composition_update_it, get_composition_id):
5111 * xdisp.c (get_next_display_element)
5112 (fill_composite_glyph_string): Add comments about special meaning
5113 of TAB characters in a composition.
5114
a02719a3
PE
51152011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5116
5117 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5118 This occurs when processing a multibyte format.
5119 Problem reported by Wolfgang Jenker.
a02719a3 5120
72589a3c
JB
51212011-09-15 Johan Bockgård <bojohan@gnu.org>
5122
5123 * xdisp.c (try_cursor_movement): Only check for exact match if
5124 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5125
1c14176c
PE
51262011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5127
5128 Remove unused external symbols.
5129 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5130 * xdisp.c (calc_pixel_width_or_height): Now static.
5131 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5132 * indent.c (check_display_width):
5133 * w32term.c: Fix comment to match code.
5134 * xterm.c, xterm.h (x_catching_errors): Remove.
5135
d2eea5b5
PE
51362011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5137
5138 * xselect.c: Use signed conversions more consistently (Bug#9498).
5139 (selection_data_to_lisp_data): Assume incoming selection data are
5140 signed integers, not unsigned. This is to be consistent with
5141 outgoing selection data, which was modified to use signed integers
5142 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5143 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5144 expects long, not unsigned long.
5145
46888499
EZ
51462011-09-14 Eli Zaretskii <eliz@gnu.org>
5147
5148 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5149 computation of loop end. Reported by Johan Bockgård
5150 <bojohan@gnu.org>.
5151
ef8ef9fb
CY
51522011-09-13 Chong Yidong <cyd@stupidchicken.com>
5153
5154 * frame.c (Fother_visible_frames_p): Function deleted.
5155
fa819fed
EZ
51562011-09-12 Eli Zaretskii <eliz@gnu.org>
5157
5158 * indent.c (compute_motion): Process display vector front to back
5159 rather than the other way around. (Bug#2496)
5160
2ba8e008
SM
51612011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5162
5163 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5164
20f53c69
CY
51652011-09-11 Chong Yidong <cyd@stupidchicken.com>
5166
5167 * minibuf.c (Fread_from_minibuffer): Doc fix.
5168
d562d7a4
EZ
51692011-09-11 Eli Zaretskii <eliz@gnu.org>
5170
5171 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5172 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5173
1c4d7f3d
LMI
51742011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5175
5176 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5177 value for non-existent files.
5178
b885bf36
EZ
51792011-09-11 Eli Zaretskii <eliz@gnu.org>
5180
5181 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5182 set its "size" to -1. This will set the modtime_size field of
5183 the corresponding buffer to -1, which is what
5184 verify-visited-file-modtime expects for files that do not exist.
5185 (Bug#9139)
5186
6612f0bf
PE
51872011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5188
5189 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5190 here ...
5191 * lisp.h: ... from here. push_key_description is no longer
5192 defined in keyboard.c, so its declaration should not be in
5193 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5194 logically belongs with push_key_description.
5195
dfb3f755
PE
51962011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5197
5198 * buffer.h: Include <sys/types.h> instead of <time.h>.
5199 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5200 Problem reported by Herbert J. Skuhra.
5201
3134906c
LMI
52022011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5203
5204 * xml.c (parse_region): Make the parsing work for
5205 non-comment-starting XML files again (bug#9144).
5206
8d903f4e
AS
52072011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5208
5209 * image.c (gif_load): Fix calculation of bottom and right corner.
5210 (Bug#9468)
5211
80ad64f4
EZ
52122011-09-10 Eli Zaretskii <eliz@gnu.org>
5213
5214 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5215 redisplay in small windows.
5216
208a048d
EZ
52172011-09-09 Eli Zaretskii <eliz@gnu.org>
5218
5219 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5220
9b1c252e
MR
52212011-09-08 Martin Rudalics <rudalics@gmx.at>
5222
5223 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5224 Operate on live windows only.
5225
2949f33b
JB
52262011-09-08 Juanma Barranquero <lekktu@gmail.com>
5227
5228 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5229
e08dcafd
EZ
52302011-09-07 Eli Zaretskii <eliz@gnu.org>
5231
5232 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5233 only under bidi iteration.
5234
115b96bd
JD
52352011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5236
5237 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5238
c8199d0f
PE
52392011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5240
5241 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5242 Without this fix, the command to link temacs failed due to an
5243 undefined symbol __builtin_isnan. This is because
5244 /usr/include/iso/math_c99.h #defines isnan(x) to
5245 __builtin_isnan(x), but the bundled gcc, which identifies itself
5246 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5247 a __builtin_isnan.
5248 * floatfns.c (isnan): #undef, and then #define to a clone of
5249 what's in data.c.
5250 (Fisnan): Always define, since it's always available now.
5251 (syms_of_floatfns): Always define isnan at the Lisp level.
5252
e39b275c 52532011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5254
5255 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5256
b2db44d9 52572011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5258
f4af5137 5259 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5260 The previous code assumed that file offsets (off_t values) fit in
5261 EMACS_INT variables, which is not true on typical 32-bit hosts.
5262 The code messed up by falsely reporting buffer overflow in cases
5263 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5264 when "big" contains more than 2**29 bytes, even though this
5265 inserts just one byte and does not overflow the buffer.
5266 (Finsert_file_contents): Store file offsets as off_t
5267 values, not as EMACS_INT values. Check for overflow when
5268 converting between EMACS_INT and off_t. When checking for
5269 buffer overflow or for overlap, take the offsets into account.
5270 Don't use EMACS_INT for small values where int suffices.
5271 When checking for overlap, fix a typo: ZV was used where
5272 ZV_BYTE was intended.
5273 (Fwrite_region): Don't assume off_t fits into 'long'.
5274 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5275
ecfc0a49
MA
52762011-09-05 Michael Albinus <michael.albinus@gmx.de>
5277
5278 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5279
6511acf2 52802011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5281
0999621a 5282 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5283
5284 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5285 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5286 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5287 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5288 (modify_event_symbol): Do not assume that the length of
5289 name_alist_or_stem is safe to alloca and fits in int.
5290 (Fexecute_extended_command): Likewise for function name and binding.
5291 (Frecursion_depth): Wrap around reliably on integer overflow.
5292 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5293 since some callers pass EMACS_INT values.
5294 (Fsingle_key_description): Don't crash if symbol name contains more
5295 than MAX_ALLOCA bytes.
5296 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5297 (get_minibuffer): Arg is now EMACS_INT, not int.
5298 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5299 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5300 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5301
2be7d702
PE
5302 * dbusbind.c (signature_cat): New function.
5303 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5304 Do not overrun buffer; instead, report string overflow.
5305
9d1df220
PE
5306 * dispnew.c (add_window_display_history): Don't overrun buffer.
5307 Truncate instead; this is OK since it's just a log.
5308
33ef5c64
PE
5309 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5310 even if the time zone offset is outlandishly large.
5311 Don't mishandle offset == INT_MIN.
5312
66c6fdd5
PE
5313 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5314 when creating daemon; the previous buffer-overflow check was incorrect.
5315
d749b01b
PE
5316 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5317 which has the guts of the old verror function.
5318
b5cd1905
PE
5319 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5320 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5321
6e1a67fb
PE
5322 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5323 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5324 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5325 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5326 length of string rather than counting it via multiple sprintfs;
5327 that's simpler and more reliable.
c21721cc
PE
5328 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5329 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5330 sprintf, in case result does not fit in int.
5331
c57b67fc
PE
5332 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5333 (fontset_from_font): Print it.
5334
8a401434
PE
5335 * frame.c (tty_frame_count): Now printmax_t, not int.
5336 (make_terminal_frame, set_term_frame_name): Print it.
5337 (x_report_frame_params): In X, window IDs are unsigned long,
5338 not signed long, so print them as unsigned.
5339 (validate_x_resource_name): Check for implausibly long names,
5340 and don't assume name length fits in 'int'.
5341 (x_get_resource_string): Don't blindly alloca invocation name;
5342 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5343 not fit in int.
5344
6e1a67fb
PE
5345 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5346 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5347 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5348
0df02bf3
PE
5349 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5350 Use esprintf, not sprintf, in case result does not fit in int.
5351
48e30793
PE
5352 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5353 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5354 it as a large positive number.
5355 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5356 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5357
a66ff6d8
PE
5358 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5359 in case result does not fit in int.
5360
aca216ff
PE
5361 * print.c (float_to_string): Detect width overflow more reliably.
5362 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5363 buffer overrun. Don't assume list length fits in 'int'. Treat
5364 print length of 0 as 0, not as infinity; to be consistent with other
5365 uses of print length in this function. Don't overflow print length
5366 index. Don't assume hash table size fits in 'long', or that
5367 vectorlike size fits in 'unsigned long'.
5368
31c286f7
PE
5369 * process.c (make_process): Use printmax_t, not int, to format
5370 process-name gensyms.
5371
55e5faa1
PE
5372 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5373
80f2e268
PE
5374 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5375 to avoid potential buffer overrun.
5376
670741ab
PE
5377 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5378 if X resource line is longer than 512 bytes.
5379
b7163a50
PE
5380 * xfns.c (x_window): Make sprintf buffer a bit bigger
5381 to avoid potential buffer overrun.
5382
ae58ff1f
PE
5383 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5384
c43c8a6a
PE
5385 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5386
3f8236f4
PE
53872011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5388
53e9fe90 5389 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5390 Without these, Emacs silently mishandles large integers sometimes.
5391 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5392 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5393
6511acf2
PE
5394 * xdisp.c (try_window_id): Check Emacs fixnum range before
5395 converting to 'int'.
806add1d 5396
6511acf2 5397 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5398 Check that an Emacs fixnum is in range before assigning it to 'int'.
5399 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5400 values converted from Emacs fixnums.
5401 (Frecenter): Don't wrap around a line count if it is out of 'int'
5402 range; instead, treat it as an extreme value.
5403 (Fset_window_configuration, compare_window_configurations):
5404 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5405
6511acf2
PE
5406 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5407 that can exceed INT_MAX. Check that EMACS_INT value is in range
5408 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5409 (match_limit): Don't assume that a fixnum can fit in 'int'.
5410
6511acf2 5411 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5412 exceed INT_MAX.
5413
6511acf2 5414 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5415 (Fvertical_motion): Don't wrap around LINES values that don't fit
5416 in 'int'. Instead, treat them as extreme values. This is good
5417 enough for windows, which can't have more than INT_MAX lines anyway.
5418
fcb901a7
LMI
54192011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5420
0f2f6b6d
LMI
5421 * Require libxml/parser.h to avoid compilation warning.
5422
fcb901a7
LMI
5423 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5424
5425 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5426 since this reportedly can destroy thread storage.
5427
6e20a0d4
CY
54282011-08-30 Chong Yidong <cyd@stupidchicken.com>
5429
5430 * syntax.c (find_defun_start): Update all cache variables if
5431 exiting early (Bug#9401).
5432
148ae00e
EZ
54332011-08-30 Eli Zaretskii <eliz@gnu.org>
5434
f6cfbd8f
EZ
5435 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5436
148ae00e
EZ
5437 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5438 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5439 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5440
5441 * term.c (tty_append_glyph): New function.
5442 (produce_stretch_glyph): Static function and its prototype deleted.
5443
a66cfb1c
SM
5444 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5445 Add prototypes.
148ae00e 5446
c4a07a4c
PE
54472011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5448
5449 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5450 when checking :margin (Bug#9390).
5451 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5452 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5453 so that the name doesn't mislead. All uses changed.
5454
6bc8cd65
JB
54552011-08-28 Johan Bockgård <bojohan@gnu.org>
5456
5457 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5458 set_tty_hooks.
5459
dca4927e
EZ
54602011-08-27 Eli Zaretskii <eliz@gnu.org>
5461
5462 * xdisp.c (move_it_to): Don't bail out early when reaching
5463 position beyond to_charpos, if we are scanning backwards.
5464 (move_it_vertically_backward): When DY == 0, make sure we get to
5465 the first character in the line after the newline.
5466
f2cad773
PE
54672011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5468
5469 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5470 (ccl_driver): Do not generate an out-of-range pointer.
5471 (Fccl_execute_on_string): Remove unnecessary check for
5472 integer overflow, noted by Stefan Monnier in
5473 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5474 Remove a FIXME that didn't need fixing.
5475 Simplify the newly-introduced buffer reallocation code.
5476
0cae2cdb
JB
54772011-08-27 Juanma Barranquero <lekktu@gmail.com>
5478
5479 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5480
5fc295a4 54812011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5482
70c60eb2 5483 Integer and memory overflow issues (Bug#9196).
726e0ab1 5484
d31850da
PE
5485 * doc.c (get_doc_string): Rework so that
5486 get_doc_string_buffer_size is the actual buffer size, rather than
5487 being 1 less than the actual buffer size; this makes xpalloc more
5488 convenient.
5489
a69fbedb
PE
5490 * image.c (x_allocate_bitmap_record, cache_image):
5491 * xselect.c (Fx_register_dnd_atom):
5492 Simplify previous changes by using xpalloc.
5493
fe5c5d37
PE
5494 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5495 since either will do and ptrdiff_t is convenient with xpalloc.
5496
0065d054
PE
5497 * charset.c (charset_table_size)
5498 (struct charset_sort_data.priority): Now ptrdiff_t.
5499 (charset_compare): Don't overflow if priorities differ greatly.
5500 (Fsort_charsets): Don't assume list length fits in int.
5501 Check for size-calculation overflow when allocating sort data.
5502 (syms_of_charset): Allocate an initial charset table that is
5503 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5504
5505 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5506
5507 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5508 The actual value is always <= INT_MAX, and leaving it unsigned made
5509 overflow checking harder.
5510
5511 * dispextern.h (struct glyph_matrix.rows_allocated)
5512 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5513 with xpalloc. The values are still always <= INT_MAX.
5514
5515 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5516
5517 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5518 (SAFE_NALLOCA): New macro.
5519
5520 * region-cache.c (struct boundary.pos, find_cache_boundary)
5521 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5522 (set_cache_region, invalidate_region_cache)
5523 (revalidate_region_cache, know_region_cache, region_cache_forward)
5524 (region_cache_backward, pp_cache):
5525 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5526 so that ptrdiff_t * can be passed to xpalloc.
5527 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5528 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5529 (pp_cache): Don't assume cache_len fits in int.
5530 * region-cache.h: Adjust extern decls to match.
5531
5532 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5533 EMACS_INT, since either will do, for xpalloc.
5534
5535 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5536 (xnmalloc, xnrealloc, xpalloc): New functions.
5537
726e0ab1
PE
5538 * bidi.c (bidi_shelve_header_size): New constant.
5539 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5540 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5541
51f30bc5 5542 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5543 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5544 (overlay_strings):
5545 Don't update size of array until after memory allocation succeeds,
5546 because xmalloc/xrealloc may not return.
0065d054
PE
5547 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5548 now that we have proper integer overflow checking.
5549 (record_overlay_string, overlay_strings): Catch overflows when
5550 calculating size of overlay_str_buf.
726e0ab1 5551
0065d054
PE
5552 * callproc.c (Fcall_process): Check for size overflow when
5553 calculating size of args2.
5554 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5555 Normally we prefer signed values, but sticking with ptrdiff_t would
5556 require adding more-complicated checks.
726e0ab1
PE
5557
5558 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5559 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5560 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5561 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5562
5563 * character.c (Fstring): Check for size-calculation overflow.
5564
5565 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5566 unnecessary integer overflow. Check for size overflow.
5567 (encode_coding_object): Don't update size until xmalloc succeeds.
5568
5569 * composite.c (get_composition_id): Check for overflow in glyph
5570 length calculations.
5571
5572 Integer and memory overflow fixes for display code.
5573 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5574 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5575 (scrolling_window): Check for overflow in size calculations.
5576 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5577 Don't assume glyph table len fits in int.
5578 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5579 (row_table_size): Now ptrdiff_t, not int.
5580 (scrolling_window): Avoid overflow in size calculations.
5581 Don't update size until allocation succeeds.
5582 * fns.c (concat): Check for overflow in size calculations.
5583 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5584 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5585 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5586
5587 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5588 (get_doc_string): Check for size calculation overflow.
5589 Don't update size until allocation succeeds.
5590 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5591 EMACS_INT, where ptrdiff_t will do.
5592 (Fsubstitute_command_keys): Check for string overflow.
5593
5594 * editfns.c (set_time_zone_rule): Don't assume environment length
5595 fits in int.
5596 (message_length): Now ptrdiff_t, not int.
5597 (Fmessage_box): Don't update size until allocation succeeds.
5598 Don't assume message length fits in int.
5599 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5600
0065d054
PE
5601 * emacs.c (main): Do not reallocate argv, since there is a null at
5602 the end that can be overwritten, and this way there's no need to
5603 worry about size-calculation overflow.
5604 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5605
5606 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5607 alloc succeeds.
5608 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5609
5610 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5611 (x_set_scroll_bar_width, x_figure_window_size):
5612 Check for integer overflow.
5613 (x_set_alpha): Do not assume XINT fits in int.
5614
5615 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5616 This is for the members text_lines, text_cols, total_lines, total_cols,
5617 where the system imposes an 'int' limit.
5618
5619 * fringe.c (Fdefine_fringe_bitmap):
5620 Don't update size until alloc works.
5621
5622 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5623 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5624
5625 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5626 Check for size-calculation overflow.
5627 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5628 do, as we prefer signed integers.
5629 (id_to_widget.max_size, id_to_widget.used)
5630 (xg_store_widget_in_map, xg_remove_widget_from_map)
5631 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5632 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5633 Use and return ptrdiff_t, not int.
5634 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5635 * gtkutil.h: Change prototypes to match the above.
5636
5637 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5638 are duplicate now that they've been promoted to lisp.h.
5639 (x_allocate_bitmap_record, x_alloc_image_color)
5640 (make_image_cache, cache_image, xpm_load):
5641 Don't update size until alloc is done.
5642 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5643 (x_detect_edges):
3256efce 5644 Check for size calculation overflow.
726e0ab1
PE
5645 (ct_colors_allocated_max): New constant.
5646 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5647 overflow.
3256efce 5648
726e0ab1
PE
5649 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5650 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5651 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5652 Use ptrdiff_t, not int, to count maps.
5653 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5654 calculations. Don't update size until allocation succeeds.
5655 Redo calculations to avoid overflow.
726e0ab1
PE
5656 * keyboard.h: Change prototypes to match the above.
5657
5658 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5659 to count maps.
5660 (current_minor_maps): Check for size calculation overflow.
5661 * keymap.h: Change prototypes to match the above.
5662
5663 * lread.c (read1, init_obarray): Don't update size until alloc done.
5664
5665 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5666 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5667
726e0ab1
PE
5668 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5669 Now ptrdiff_t, not int.
5670 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5671 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5672
5673 * process.c (Fnetwork_interface_list): Check for overflow
5674 in size calculation.
5675
5676 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5677
5678 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5679 overflow. Don't bother calling xmalloc when xrealloc will do.
5680
5681 * search.c (Freplace_match): Check for size calculation overflow.
5682 (Fset_match_data): Don't assume list lengths fit in 'int'.
5683
5684 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5685 for command line length. Do not attempt to address one before the
5686 beginning of an array, as that's not portable.
5687
5688 * term.c (max_frame_lines): Remove; unused.
5689 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5690 not int.
5691 (encode_terminal_code, calculate_costs): Check for size
5692 calculation overflow.
5693 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5694 table lengths and related sizes. Don't update size until alloc
5695 done. Redo calculations to avoid overflow.
5696 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5697
5698 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5699 subtracting pointers.
5700 (gobble_line): Check for overflow more carefully. Don't update size
5701 until alloc done.
5702
5703 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5704 Don't update size until alloc done.
5705 Redo size calculations to avoid overflow.
5706 Check for size calculation overflow.
0065d054 5707 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5708
5709 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5710 Use ptrdiff_t, not int, for sizes.
5711 (store_mode_line_noprop_char): Don't update size until alloc done.
5712
0065d054
PE
5713 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5714 Use ptrdiff_t, not int, for sizes.
5715 (Finternal_make_lisp_face, cache_face):
5716 Check for size calculation overflow.
5717 (cache_face): Treat size calculation overflows as if they were
5718 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5719
5720 * xfns.c (x_encode_text, x_set_name_internal)
5721 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5722 sizes, since they can exceed INT_MAX in size. Check for size
5723 calculation overflow.
5724
0065d054
PE
5725 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5726 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5727 Don't update size until alloc done.
5728
0065d054 5729 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5730 as sprintf is limited to int lengths.
1d526e2f 5731
252c5ee1
PE
5732 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5733 (X_LONG_MIN): New macros.
864d7ce7
PE
5734 Use them to make the following changes clearer.
5735 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5736 This change doesn't affect the value now, but it may help remind
5737 future maintainers not to raise the value too much later.
5738 (SELECTION_QUANTUM): Remove, replacing with ...
5739 (selection_quantum): ... new function, which avoids overflow.
5740 All uses changed.
5741 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5742 assumption that selection length fits in 'int'.
5743 (x_reply_selection_request, x_handle_selection_request)
5744 (x_get_window_property, receive_incremental_selection)
5745 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5746 (lisp_data_to_selection_data, clean_local_selection_data):
5747 Use ptrdiff_t, not int, to record length of selection.
5748 (x_reply_selection_request, x_get_window_property)
5749 (receive_incremental_selection, x_property_data_to_lisp):
5750 Redo calculations to avoid overflow.
5751 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5752 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5753 something.
5754 (x_get_window_property, receive_incremental_selection)
5755 (lisp_data_to_selection_data, x_property_data_to_lisp):
5756 Check for size-calculation overflow.
5757 (x_get_window_property, receive_incremental_selection)
5758 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5759 Don't store size until memory allocation succeeds.
5760 (x_get_window_property): Plug memory leak on memory exhaustion.
5761 Don't double-block input; malloc is safe here. Don't assume 2**34
5762 - 4 fits in unsigned long. Add an xassert to check
5763 XGetWindowProperty overflow. Be more careful about overflow
5764 calculations, and distinguish size from memory overflow better.
5765 (receive_incremental_selection): When tracing, don't assume
5766 unsigned int is less than INT_MAX.
5767 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5768 harmful) conversions of unsigned short to int.
5769 (lisp_data_to_selection_data): Don't assume that integers
5770 in the range -65535 through -1 fit in an X unsigned short.
5771 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5772 result parameters unless successful. Rely on cons_to_unsigned
5773 to report problems with elements; the old code wasn't right anyway.
5774 (x_check_property_data): Check for int overflow; we cannot use
5775 a wider type due to X limits.
5776 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5777
726e0ab1 5778 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5779
0065d054
PE
5780 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5781 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5782 (x_color_cells): Don't store size until memory allocation succeeds.
5783 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5784 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5785 (x_term_init): Don't assume length fits in int (sprintf is limited
5786 to int size).
bc18e09d 5787
ebfa62c0
PE
5788 Use ptrdiff_t for composition IDs.
5789 * character.c (lisp_string_width):
5790 * composite.c (composition_table_size, n_compositions)
5791 (get_composition_id, composition_gstring_from_id):
5792 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5793 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5794 * window.c (Frecenter):
5795 Use ptrdiff_t, not int, for composition IDs.
5796 * composite.c (get_composition_id): Check for integer overflow.
5797 * composite.h: Adjust prototypes to match the above changes.
5798
d3411f89
PE
5799 Use ptrdiff_t for hash table indexes.
5800 * category.c (hash_get_category_set):
5801 * ccl.c (ccl_driver):
5802 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5803 * coding.c (coding_system_charset_list, detect_coding_system):
5804 * coding.h (struct coding_system.id):
5805 * composite.c (get_composition_id, gstring_lookup_cache):
5806 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5807 * image.c (xpm_get_color_table_h):
5808 * lisp.h (hash_lookup, hash_put):
5809 * minibuf.c (Ftest_completion):
5810 Use ptrdiff_t for hash table indexes, not int (which is too
5811 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5812 32-bit --with-wide-int hosts).
5813
e097a6fa
PE
5814 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5815 Add a FIXME comment about memory leaks.
5816 (syms_of_charset): Don't assume xmalloc returns.
5817
5637687f
PE
5818 Don't assume that stated character widths fit in int.
5819 * character.c (Fchar_width, c_string_width, lisp_string_width):
5820 * character.h (CHAR_WIDTH):
5821 * indent.c (MULTIBYTE_BYTES_WIDTH):
5822 Use sanitize_char_width to avoid undefined and/or bad behavior
5823 with outlandish widths.
a66cfb1c 5824 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5825 now that we have two such functions. All uses changed.
5826 (sanitize_char_width): New inline function.
5827
a2271ba2
PE
5828 Don't assume that tab-width fits in int.
5829 * character.h (sanitize_width): New inline function.
5830 (SANE_TAB_WIDTH): New macro.
5831 (ASCII_CHAR_WIDTH): Use it.
5832 * indent.c (sane_tab_width): Remove. All uses replaced by
5833 SANE_TAB_WIDTH (current_buffer).
5834 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5835
18c52557
PE
5836 * fileio.c: Integer overflow issues with file modes.
5837 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5838
caeeedc1
PE
5839 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5840 Remove unreachable code.
5841 (read_hex, load_charset_map_from_file): Check for integer overflow.
5842
6df6ae42 5843 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5844 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5845 (x_send_scroll_bar_event): Likewise. Check that the size does not
5846 exceed limits imposed by XClientMessageEvent, as well as the usual
5847 ptrdiff_t and size_t limits.
5848
b13995db
PE
5849 * keyboard.c: Overflow, signedness and related fixes.
5850 (make_lispy_movement): Use same integer type in forward decl
5851 that is used in the definition.
5852 (read_key_sequence, keyremap_step):
5853 Change bufsize argument back to int, undoing my 2011-03-30 change.
5854 We prefer signed types, and int is wide enough here.
5855 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5856 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5857 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5858 length, not size_t. Use ptrdiff_t for index, not int.
5859 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5860 possibility of integer overflow.
5861
13464394
PE
5862 Overflow, signedness and related fixes for images.
5863
5864 * dispextern.h (struct it.stack[0].u.image.image_id)
5865 (struct_it.image_id, struct image.id, struct image_cache.size)
5866 (struct image_cache.used, struct image_cache.ref_count):
5867 * gtkutil.c (update_frame_tool_bar):
5868 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5869 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5870 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5871 * nsmenu.m (update_frame_tool_bar):
5872 * xdisp.c (calc_pixel_width_or_height):
5873 * xfns.c (image_cache_refcount):
5874 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5875 on typical 64-bit hosts.
5876
5877 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5878 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5879 Omit unnecessary casts to int.
5880 (parse_image_spec): Check that integers fall into 'int' range
5881 when the callers expect that.
5882 (image_ascent): Redo ascent calculation to avoid int overflow.
5883 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5884 (lookup_image): Remove unnecessary tests.
5885 (xbm_image_p): Locals are now of int, not EMACS_INT,
5886 since parse_image_check makes sure they fit into int.
5887 (png_load, gif_load, svg_load_image):
5888 Prefer int to unsigned where either will do.
5889 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5890 old tiff_error_handler and tiff_warning_handler.
5891 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5892 stack buffer overflows. It uses only the features of vsnprintf
5893 that are common to both POSIX and native Microsoft.
5894 (tiff_error_handler, tiff_warning_handler): Use it.
5895 (tiff_load, gif_load, imagemagick_load_image):
5896 Don't assume :index value fits in 'int'.
5897 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5898 (imagemagick_load_image): Check that crop parameters fit into
5899 the integer types that MagickCropImage accepts. Don't assume
5900 Vimagemagick_render_type has a nonnegative value. Don't assume
5901 size_t fits in 'long'.
5902 (gs_load): Use printmax_t to print the widest integers possible.
5903 Check for integer overflow when computing image height and width.
5904
c11821d4
EZ
59052011-08-26 Eli Zaretskii <eliz@gnu.org>
5906
5907 * xdisp.c (redisplay_window): Don't force window start if point
5908 will be invisible in the resulting window. (Bug#9324)
5909
0c95fcf7
EZ
59102011-08-25 Eli Zaretskii <eliz@gnu.org>
5911
5912 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5913 the display spec is of the form `(space ...)'.
5914 (handle_display_spec): Return the value returned by
5915 handle_single_display_spec, not just 1 or zero.
5916 (handle_single_display_spec): If the display spec is of the form
5917 `(space ...)', and specifies display in the text area, return 2
5918 rather than 1.
fee65a97 5919 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5920 accurately, and prefer exact match for point under bidi.
5921 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5922
5923 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5924 into disp_prop; all users changed.
5925
5926 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5927 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5928 for the text covered by the display property.
5929
e4ed06f1
CY
59302011-08-25 Chong Yidong <cyd@stupidchicken.com>
5931
5932 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5933 Change return value to nil.
5934 (Frecord_buffer): Delete unused function.
5935
f67cdd7f
EZ
59362011-08-24 Eli Zaretskii <eliz@gnu.org>
5937
5980d4c6
EZ
5938 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5939 buffers, return left-to-right.
8610fe8b
EZ
5940 (set_cursor_from_row): Consider candidate row a win if its glyph
5941 represents a newline and point is on that newline. Fixes cursor
5942 positioning on the newline at EOL of R2L text within L2R
5943 paragraph, and vice versa.
5944 (try_cursor_movement): Check continued rows, in addition to
5945 continuation rows. Fixes unwarranted scroll when point enters a
5946 continued line of R2L text within an L2R paragraph, or vice versa.
5947 (cursor_row_p): Consider the case of point being equal to
5948 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5949 from the end of a short line to the beginning of a continued line
5950 of R2L text within L2R paragraph.
5951 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5952 composed characters.
5980d4c6 5953
f67cdd7f
EZ
5954 * bidi.c (bidi_check_type): Use xassert.
5955 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5956 members.
5957
bca633fb
EZ
59582011-08-23 Eli Zaretskii <eliz@gnu.org>
5959
5960 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5961 a character.
5962
4a5885a7
CY
59632011-08-23 Chong Yidong <cyd@stupidchicken.com>
5964
5965 * nsfont.m (ns_otf_to_script): Fix typo.
5966
0902a04e
KH
59672011-08-22 Kenichi Handa <handa@m17n.org>
5968
5969 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5970 extra slot even if the purpose is char-code-property-table.
5971
1a2e6670
EZ
59722011-08-23 Eli Zaretskii <eliz@gnu.org>
5973
8ddde651
EZ
5974 * xdisp.c (redisplay_window): When computing centering_position,
5975 account for the height of the header line. (Bug#8874)
5976
425cc014
EZ
5977 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5978 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5979 candidate is selected by the mouse, and that candidate has a
5980 composed character under the mouse.
5981
1a2e6670
EZ
5982 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5983 coordinates reported by pos-visible-in-window-p for a composed
5984 character in column zero.
5985
8b76d6f8
SM
59862011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5987
5988 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5989
dac347dd
EZ
59902011-08-22 Eli Zaretskii <eliz@gnu.org>
5991
5992 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5993 consider it a hit if to_charpos is anywhere in the range of the
5994 composed buffer positions.
5995
e013fb34
CY
59962011-08-22 Chong Yidong <cyd@stupidchicken.com>
5997
5998 * image.c (gif_load): Don't assume that each subimage has the same
5999 dimensions as the base image. Handle disposal method that is
6000 "undefined" by the gif spec (Bug#9335).
6001
bd1ba3e8
CY
60022011-08-20 Chong Yidong <cyd@stupidchicken.com>
6003
6004 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6005 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6006
54a1215b
EZ
60072011-08-19 Eli Zaretskii <eliz@gnu.org>
6008
823564e5
EZ
6009 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6010 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6011 from an Org mode buffer to a Speedbar frame.
6012
54a1215b
EZ
6013 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6014 a composition, take its buffer position from IT->cmp_it.charpos.
6015 Fixes cursor positioning at the beginning of a line that begins
6016 with a composed character.
6017
9778ebcc
EZ
60182011-08-18 Eli Zaretskii <eliz@gnu.org>
6019
0be6ee06
EZ
6020 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6021 character bidirectional type, use STRONG_L instead. Fixes crashes
6022 in a buffer produced by `describe-categories'.
6023
9778ebcc
EZ
6024 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6025 members before the level stack, so they would be saved and
6026 restored when copying iterator state. Fixes incorrect reordering
6027 around TABs covered by display properties.
6028
156bffbe
AS
60292011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6030
6b02f655 6031 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6032
72ad093b
CY
60332011-08-17 Chong Yidong <cyd@stupidchicken.com>
6034
6035 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6036 (internal_condition_case_2, internal_condition_case_n):
6037 Remove unnecessary aborts (Bug#9081).
72ad093b 6038
35774242
EZ
60392011-08-17 Eli Zaretskii <eliz@gnu.org>
6040
6041 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6042 has no `load' handler, try opening the file locally. (Bug#9311)
6043
db76dd85
KB
60442011-08-16 Ken Brown <kbrown@cornell.edu>
6045
6046 * gmalloc.c: Expand comment.
6047
b215eee5
EZ
60482011-08-16 Eli Zaretskii <eliz@gnu.org>
6049
6050 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6051 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6052
a4579d33
KB
60532011-08-16 Ken Brown <kbrown@cornell.edu>
6054
6055 Fix memory allocation problems in Cygwin build (Bug#9273).
6056
6057 * unexcw.c ( __malloc_initialized): Declare external variable.
6058 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6059
8b76d6f8
SM
6060 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6061 New variables.
a4579d33
KB
6062 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6063 dumped emacs.
6064 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6065 in the static heap.
6066 [CYGWIN] (special_realloc): New function.
6067 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6068 requests to realloc storage in the static heap.
6069
3ebec551
PE
60702011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6071
6072 * bidi.c (bidi_initialize): Remove unused local.
6073
9fd8be00
EZ
60742011-08-15 Eli Zaretskii <eliz@gnu.org>
6075
6b02f655
SM
6076 * bidimirror.h:
6077 * biditype.h: Remove file.
6078 * makefile.w32-in ($(BLD)/bidi.$(O)):
6079 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6080
6081 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6082
6083 * chartab.c: Improve commentary for the uniprop_table API.
6084
32413314
EZ
6085 * bidi.c (bidi_paragraph_init): Support zero value of
6086 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6087 (bidi_initialize): Use uniprop_table instead of including
6088 biditype.h and bidimirror.h.
32413314 6089
9fd8be00
EZ
6090 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6091 coordinates of the iterator when restoring from ppos_it.
6092 (Bug#9296)
6093
5cf2b69b
KH
60942011-08-14 Kenichi Handa <handa@m17n.org>
6095
6096 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6097 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6098
daf17d00
EZ
60992011-08-14 Eli Zaretskii <eliz@gnu.org>
6100
6101 * xdisp.c (move_it_in_display_line_to): Don't invoke
6102 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6103 ppos_it. Fixes vertical cursor motion when line beginning is
6104 covered by an image. (Bug#9296)
6105
08e3161a
JD
61062011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6107
6108 * nsterm.h (ns_run_ascript): Declare.
6109 (NSAPP_DATA2_RUNASSCRIPT): Define.
6110
6111 * nsfns.m (as_script, as_result, as_status): New static variables.
6112 (ns_run_ascript): New function.
5e617bc2 6113 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6114 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6115 the event loop. Get status from as_status (Bug#7276).
6116
6117 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6118 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6119 the event loop (Bug#7276).
6120
a3720aa2
AS
61212011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6122
6123 * gnutls.c (QCgnutls_bootprop_priority)
6124 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6125 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6126 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6127 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6128 (QCgnutls_bootprop_verify_hostname_error)
6129 (QCgnutls_bootprop_callbacks_verify): Rename from
6130 Qgnutls_bootprop_..., all uses changed.
6131
6132 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6133 uses changed.
6134
0a0d27fb
PE
61352011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6136
19d5c50c
PE
6137 * xfaces.c (Qframe_set_background_mode): Now static.
6138 * dispextern.h (Qframe_set_background_mode): Remove decl.
6139
0a0d27fb
PE
6140 * process.c (Fnetwork_interface_info): Declare local only if needed.
6141
377538cb
JD
61422011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6143
6144 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6145 (Fnetwork_interface_list): Allocate in increments of bytes instead
6146 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6147 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6148 sockaddr.
6149 (struct ifflag_def): notrailers is smart on OSX.
6150 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6151 Get hardware address with getifaddrs if available.
6152
08fff70c
EZ
61532011-08-12 Eli Zaretskii <eliz@gnu.org>
6154
6155 * xdisp.c (iterate_out_of_display_property): xassert that
6156 IT->position is set to within IT->object's boundaries. Break from
6157 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6158 when IT->position is set up wrongly due to some bug.
6159 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6160 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6161 entry. Force push_it to save on the stack the current
6162 buffer/string position, to be restored by pop_it. Fix flags in
6163 the iterator structure wrt the object coming from a display
6164 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6165 properties. (Bug#9284)
6166
7be1c708 61672011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6168
7be1c708
CY
6169 * fontset.c (fontset_get_font_group): Add proper type checks.
6170 (Bug#9172)
aac0c6e3 6171
7be1c708 61722011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6173
7be1c708
CY
6174 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6175 and LC_VERSION_MIN_MACOSX.
6176 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6177 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6178
97bb72a6
EZ
61792011-08-08 Eli Zaretskii <eliz@gnu.org>
6180
6181 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6182 no-display-properties-and-no-overlays under bidi display.
6183 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6184 properties and overlays.
97bb72a6 6185
d5617611
CY
61862011-08-08 Chong Yidong <cyd@stupidchicken.com>
6187
37e11a63
CY
6188 * editfns.c (Fset_time_zone_rule): Document relationship with the
6189 setenv function.
6190
d5617611
CY
6191 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6192 the font entity extracted from the cache (Bug#8109).
6193
58872834
CY
61942011-08-07 Chong Yidong <cyd@stupidchicken.com>
6195
6196 * composite.c (autocmp_chars): Don't reset point. That is done by
6197 restore_point_unwind (Bug#5984).
6198
75bfc667
JL
61992011-08-07 Juri Linkov <juri@jurta.org>
6200
6201 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6202 to show the arg `TIME' instead of `TIMEVAL'.
6203
d1410150
EZ
62042011-08-06 Eli Zaretskii <eliz@gnu.org>
6205
6206 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6207 display property strides EOL and includes a newline, as in
6208 longlines-mode. (Bug#9254)
75b771e4
EZ
6209 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6210 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6211
6212 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6213 is non-zero, even if the data buffer is NULL. Fixes a crash in
6214 vertical-motion with longlines-mode. (Bug#9254)
6215
35928349
EZ
62162011-08-05 Eli Zaretskii <eliz@gnu.org>
6217
ec7cc85b
EZ
6218 * bidi.c <bidi_cache_total_alloc>: Now static.
6219 (bidi_initialize): Initialize bidi_cache_total_alloc.
6220
8b76d6f8 6221 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6222 cache. (Bug#9221)
6223
6224 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6225 amount allocated this far in `bidi_cache_total_alloc'.
6226 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6227 non-zero, only free the data buffer without restoring the cache
6228 contents. All callers changed.
6229
6230 * dispextern.h (bidi_unshelve_cache): Update prototype.
6231
6232 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6233 (move_it_in_display_line, move_it_to)
6234 (move_it_vertically_backward, move_it_by_lines): Replace the call
6235 to xfree to an equivalent call to bidi_unshelve_cache.
6236 (move_it_in_display_line_to): Fix logic of returning
412b6358 6237 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6238
e2e2423b
EZ
62392011-08-05 Eli Zaretskii <eliz@gnu.org>
6240
6241 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6242 came from a string character with a `cursor' property. (Bug#9229)
6243
ae9e757a
JD
62442011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6245
6246 * Makefile.in (LIB_PTHREAD): New variable.
6247 (LIBES): Add LIB_PTHREAD (Bug#9216).
6248
6249 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6250 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6251
213bd7f2
AS
62522011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6253
6b02f655 6254 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6255
99aaf75f
JD
62562011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6257
6258 * xterm.c (x_find_topmost_parent): New function.
6259 (x_set_frame_alpha): Find topmost parent window with
6260 x_find_topmost_parent and set the property there also (bug#9181).
6261 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6262
c74e9d86
PE
62632011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6264
6265 * callproc.c (Fcall_process): Avoid vfork clobbering
6266 the local vars buffer, coding_systems, current_dir.
6267
640c8776
SM
62682011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6269
6270 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6271
f26d0e4c
PE
62722011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6273
8a10d76c
PE
6274 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6275 so that it is not optimized away.
6276
f26d0e4c
PE
6277 * xdisp.c (compute_display_string_pos): Remove unused local.
6278
55439c61
EZ
62792011-08-02 Eli Zaretskii <eliz@gnu.org>
6280
6281 Fix slow cursor motion and scrolling in large buffers with
6282 selective display, like Org Mode buffers. (Bug#9218)
6283
6284 * dispextern.h (struct bidi_it): New member disp_prop_p.
6285
6286 * xdisp.c: Remove one-slot cache of display string positions.
6287 (compute_display_string_pos): Accept an additional argument
5e617bc2 6288 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6289 for a display string or property. If found, set DISP_PROP_P
6290 non-zero.
6291
6292 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6293 DISP_PROP_P, and pass it to compute_display_string_pos.
6294 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6295 non-zero. All callers of bidi_fetch_char changed.
6296
fb33fa43
SM
62972011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6298
6299 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6300
b099e063
DM
63012010-12-03 Don March <don@ohspite.net>
6302
6303 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6304 last character M-[char] is translated to ESC [char] (bug#7541).
6305
5cc7f7af
KH
63062011-08-02 Kenichi Handa <handa@m17n.org>
6307
d0fffa3f 6308 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6309
6310 * chartab.c (uniprop_table): Make it non-static.
6311
525d5e6e
EZ
63122011-08-01 Eli Zaretskii <eliz@gnu.org>
6313
6314 * xdisp.c (forward_to_next_line_start): Accept additional argument
6315 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6316 on the newline.
6317 (reseat_at_next_visible_line_start): Use the bidi iterator state
6318 returned by forward_to_next_line_start to restore the state of
6319 it->bidi_it after backing up to previous newline. (Bug#9212)
6320
31011111
AS
63212011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6322
6323 * regex.c (re_comp): Protoize.
6324 (re_exec): Fix return type.
6325 (regexec): Fix type of `ret'. (Bug#9203)
6326
476371c4
PE
63272011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6328
e5d76069
PE
6329 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6330 This is needed if max-image-size is a floating-point number.
6331
9a79b20c
AS
63322011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6333
6334 * print.c (print_object): Print empty symbol as ##.
6335
6336 * lread.c (read1): Read ## as empty symbol.
6337
d8c2fa78
AA
63382011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6339
6340 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6341 setting frame foreground color (Bug#9175).
6342 (x_set_background_color): Likewise.
6343
ffe57a7a
AA
6344 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6345 contents (Bug#9176).
6346 (EmacsTooltip -init): Remove bezels and add shadows to
6347 tooltip windows.
6348
bf3492a5
AA
6349 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6350 or scroll bar (Bug#8470).
6351
d55e9c53
AA
6352 * nsfont.m (nsfont_open): Remove assignment to voffset and
6353 unnecessary vars hshink, expand, hd, full_height, min_height.
6354 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6355
6356 * nsterm.h (nsfont_info): Remove voffset field.
6357
d8c2fa78 63582011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6359
6360 Implement strike-through and overline on NextStep (Bug#8863).
6361
6362 * nsfont.m (nsfont_open): Use underline position provided by font,
6363 instead of hard-coded value of 2.
6364 (nsfont_draw): Call ns_draw_text_decoration instead.
6365
6366 * nsterm.h: Add declaration for ns_draw_text_decoration.
6367
6368 * nsterm.m (ns_draw_text_decoration): New function for drawing
6369 underline, overline, and strike-through.
6370 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6371 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6372 accommodate underlining, etc.
4843aac3 6373
4cc60b9b
EZ
63742011-07-28 Eli Zaretskii <eliz@gnu.org>
6375
bc7ece87
EZ
6376 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6377 default.
4cc60b9b 6378
476371c4
PE
63792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6380
66606eea
PE
6381 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6382 Without this fix, if a signal arrives just after memory fills up,
6383 'malloc' might be invoked reentrantly.
6384
476371c4
PE
6385 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6386 In other words, assume that every image size is allowed, on non-X
6387 hosts. This assumption is probably wrong, but it lets Emacs compile.
6388
f3fcc40d
AS
63892011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6390
6391 * regex.c (re_iswctype): Convert return values to boolean.
6392
350c992f
EZ
63932011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6394
6395 * xdisp.c (compute_display_string_pos): Don't use cached display
6396 string position if the buffer had its restriction changed.
6397 (Bug#9184)
6398
5266b4bb
PE
63992011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6400
6401 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6402
2573a837 64032011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6404
41f55ccd 6405 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6406
39e378da
PE
6407 * bidi.c: Integer size and overflow fixes.
6408 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6409 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6410 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6411 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6412 (bidi_find_other_level_edge):
6413 Use ptrdiff_t instead of EMACS_INT where either will do.
6414 This works better on 32-bit hosts configured --with-wide-int.
6415 (bidi_cache_ensure_space): Check for size-calculation overflow.
6416 Use % rather than repeated addition, for better worst-case speed.
6417 Don't set bidi_cache_size until after xrealloc returns, because it
6418 might not return.
6419 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6420 (bidi_cache_ensure_space): Also check that the bidi cache size
6421 does not exceed that of the largest Lisp string or buffer. See Eli
6422 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6423
5e927815
PE
6424 * alloc.c (__malloc_size_t): Remove.
6425 All uses replaced by size_t. See Andreas Schwab's note
6426 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6427
ca4aa935
PE
6428 * image.c: Improve checking for integer overflow.
6429 (check_image_size): Assume that f is nonnull, since
6430 it is always nonnull in practice. This is one less thing to
6431 worry about when checking for integer overflow later.
6432 (x_check_image_size): New function, which checks for integer
6433 overflow issues inside X.
6434 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6435 This removes the need for a memory_full check.
6436 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6437 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6438 (xbm_read_bitmap_data): Change locals back to 'int', since
6439 their values must fit in 'int'.
6440 (xpm_load_image, png_load, tiff_load):
6441 Invoke x_create_x_image_and_pixmap earlier,
6442 to avoid much needless work if the image is too large.
6443 (tiff_load): Treat overly large images as if
6444 x_create_x_image_and_pixmap failed, not as malloc failures.
6445 (gs_load): Use x_check_image_size.
6446
5f8f9cc2
PE
6447 * gtkutil.c: Omit integer casts.
6448 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6449 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6450
5adf60bc
PE
6451 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6452
c8907a93
PE
6453 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6454 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6455 would wrongly return t on a 64-bit host.
6456
e3c25c68
PE
6457 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6458 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6459 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6460 and therefore cause GCC to emit a bogus diagnostic in some cases.
6461
3f791afe
PE
6462 * image.c: Integer signedness and overflow and related fixes.
6463 This is not an exhaustive set of fixes, but it's time to
6464 record what I've got.
6465 (lookup_pixel_color, check_image_size): Remove redundant decls.
6466 (check_image_size): Don't assume that arbitrary EMACS_INT values
6467 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6468 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6469 (tiff_load, imagemagick_load_image):
6470 Check for overflow in size calculations.
6471 (x_create_x_image_and_pixmap): Remove unnecessary test for
6472 xmalloc returning NULL; that can't happen.
6473 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6474 (xpm_color_bucket): Use better integer hashing function.
6475 (xpm_cache_color): Don't possibly over-allocate memory.
6476 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6477 (gif_memory_source):
6478 Use ptrdiff_t, not int or size_t, to record sizes.
6479 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6480 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6481 either works, as we prefer signed integers.
6482 (tiff_read_from_memory, tiff_write_from_memory):
6483 Return tsize_t, not size_t, since that's what the TIFF API wants.
6484 (tiff_read_from_memory): Don't fail simply because the read would
6485 go past EOF; instead, return a short read.
6486 (tiff_load): Omit no-longer-needed casts.
6487 (Fimagemagick_types): Don't assume size fits into 'int'.
6488
3cc5a532
PE
6489 Improve hashing quality when configured --with-wide-int.
6490 * fns.c (hash_string): New function, taken from sxhash_string.
6491 Do not discard information about ASCII character case; this
6492 discarding is no longer needed.
6493 (sxhash-string): Use it. Change sig to match it. Caller changed.
6494 * lisp.h: Declare it.
6495 * lread.c (hash_string): Remove, since we now use fns.c's version.
6496 The fns.c version returns a wider integer if --with-wide-int is
6497 specified, so this should help the quality of the hashing a bit.
6498
b312a492
PE
6499 * emacs.c: Integer overflow minor fix.
6500 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6501 Define only if GNU_LINUX.
6502 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6503
dfd153ae
PE
6504 * dispnew.c: Integer signedness and overflow fixes.
6505 Remove unnecessary forward decls, that were a maintenance hassle.
6506 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6507 All uses changed.
6508 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6509 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6510 (prepare_desired_row, line_draw_cost):
6511 Use int, not unsigned, where either works.
6512 (save_current_matrix, restore_current_matrix):
6513 Use ptrdiff_t, not size_t, where either works.
6514 (init_display): Check for overflow more accurately, and without
6515 relying on undefined behavior.
6516
a81d11a3
PE
6517 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6518 Remove, replacing with the new symbols in lisp.h. All uses changed.
6519 * fileio.c (make_temp_name):
6520 * filelock.c (lock_file_1, lock_file):
6521 * xdisp.c (message_dolog):
6522 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6523 Use pMd etc. instead.
6524 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6525 replacing the pWIDE etc. symbols removed from editfns.c.
6526
3300e6fd
PE
6527 * keyboard.h (num_input_events): Now uintmax_t.
6528 This is (very slightly) less likely to mess up due to wraparound.
6529 All uses changed.
6530
fd05c7e9
PE
6531 * buffer.c: Integer signedness fixes.
6532 (alloc_buffer_text, enlarge_buffer_text):
6533 Use ptrdiff_t rather than size_t when either will do, as we prefer
6534 signed integers.
6535
903fe15d
PE
6536 * alloc.c: Integer signedness and overflow fixes.
6537 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6538 (__malloc_size_t): Default to size_t, not to int.
6539 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6540 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6541 Prefer ptrdiff_t to size_t when either would do, as we prefer
6542 signed integers.
6543 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6544 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6545 Now const. Initialize with values that are in range even if char
6546 is signed.
6547 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6548 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6549 These functions do the right thing with sizes > 2**32.
6550 (check_depth): Now ptrdiff_t, not int.
6551 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6552 Adjust to new way of storing sizes. Check for size overflow bugs
6553 in rest of code.
6554 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6555 slightly wrong anyway, as it missed one instance of
6556 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6557 (refill_memory_reserve): Omit needless cast to size_t.
6558 (mark_object_loop_halt): Mark as externally visible.
6559
ac82cc6a
PE
6560 * xselect.c: Integer signedness and overflow fixes.
6561 (Fx_register_dnd_atom, x_handle_dnd_message):
6562 Use ptrdiff_t, not size_t, since we prefer signed.
6563 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6564 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6565 x_dnd_atoms_size and x_dnd_atoms_length.
6566
c2d1e36d
PE
6567 * doprnt.c: Prefer signed to unsigned when either works.
6568 * eval.c (verror):
6569 * doprnt.c (doprnt):
6570 * lisp.h (doprnt):
6571 * xdisp.c (vmessage):
6572 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6573 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6574 prefer signed arithmetic to avoid comparison confusion.
6575 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6576 but is a bit tricky.
6577
0e926e56
PE
6578 Assume freestanding C89 headers, string.h, stdlib.h.
6579 * data.c, doprnt.c, floatfns.c, print.c:
6580 Include float.h unconditionally.
6581 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6582 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6583 * regex.c: Likewise for stddef.h, string.h.
6584 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6585 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6586 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6587 (STDC_HEADERS): Remove obsolete defines.
6588 * sysdep.c: Include limits.h unconditionally.
6589
9cfdb3ec
PE
6590 Assume support for memcmp, memcpy, memmove, memset.
6591 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6592 * regex.c (memcmp, memcpy):
6593 Remove; we assume C89 now.
6594
6595 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6596 (__malloc_safe_bcopy): Remove; no longer needed.
6597
cf950e6b 6598 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6599 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6600 well either way, and we prefer signed to unsigned.
6601
dbf38e02
LMI
66022011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6603
6604 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6605 closes the connection while we're reading (bug#9182).
6606
d6f0886c 66072011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6608
d6f0886c
JD
6609 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6610 are specified (Bug#9168).
24e0f6b1 6611
2eb1f9e6
PE
66122011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6613
6614 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6615 Found by GCC static checking and --with-wide-int on a 32-bit host.
6616
22381272 66172011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6618
6619 * xdisp.c (compute_display_string_pos): Fix logic of caching
6620 previous display string position. Initialize cached_prev_pos to
6621 -1. Fixes slow-down at the beginning of a buffer.
6622
f25e39b4
EZ
66232011-07-24 Eli Zaretskii <eliz@gnu.org>
6624
6625 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6626 for attrs[LFACE_FONTSET_INDEX].
6627
04c4b52e
PE
66282011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6629
6630 * xml.c (parse_region): Remove unused local
6631 that was recently introduced.
6632
c1734fbd
EZ
66332011-07-23 Eli Zaretskii <eliz@gnu.org>
6634
be18c5a5
EZ
6635 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6636 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6637
c1734fbd
EZ
6638 * xdisp.c (move_it_in_display_line_to): Record the best matching
6639 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6640 exit if none of the characters scanned was an exact match.
6641 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6642 when exact match is impossible due to invisible text, and the
6643 lines are truncated.
6644
a258d627
JD
66452011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6646
6647 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6648 for OSX >= 10.7.
6649
b6d5a689
EZ
66502011-07-22 Eli Zaretskii <eliz@gnu.org>
6651
0f74f785
EZ
6652 Fix a significant slow-down of cursor motion with C-n, C-p,
6653 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6654 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6655 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6656 (next_element_from_buffer): Call compute_stop_pos_backwards to
6657 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6658 base_level_stop.
6659 (reseat): Don't look for prev_stop, as that could mean a very long
6660 run.
6661 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6662 <cached_disp_overlay_modiff>: Cache for last found display string
6663 position.
551918c1 6664 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6665 about the same buffer in the same area of character positions, and
6666 the buffer wasn't changed since the time the display string
6667 position was cached.
551918c1 6668
b2d0c91a
EZ
66692011-07-22 Eli Zaretskii <eliz@gnu.org>
6670
6671 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6672 is an integer, which is important for empty lines. (Bug#9149)
6673
043604ee
CY
66742011-07-22 Chong Yidong <cyd@stupidchicken.com>
6675
6676 * frame.c (Fmodify_frame_parameters): In tty case, update the
6677 default face if necessary (Bug#4238).
6678
da4adb04
CY
66792011-07-21 Chong Yidong <cyd@stupidchicken.com>
6680
6681 * editfns.c (Fstring_to_char): No need to explain what a character
6682 is in the docstring (Bug#6576).
6683
9abd0532
LMI
66842011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6685
6686 * xml.c (parse_region): Make sure we always return a tree.
6687
36881d16
HK
66882011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6689
6690 * xml.c (parse_region): If a document contains only comments,
6691 return that, too.
6692
1e98674d
LMI
66932011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6694
6695 * xml.c (make_dom): Return comments, too.
6696
590bd467
PE
66972011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6698
6699 Port to OpenBSD.
6700 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6701 and the surrounding thread.
6702 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6703 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6704 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6705 timer goes off.
6706 * s/openbsd.h (BROKEN_SIGIO): Define.
6707 * unexelf.c (unexec) [__OpenBSD__]:
6708 Don't update the .mdebug section of the Alpha COFF symbol table.
6709
f41628b2
LMI
67102011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6711
6712 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6713 (bug#8460).
6714
b59b67c5
PE
67152011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6716
15e3a074
PE
6717 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6718 This fixes some race conditions on the permissions of any newly
6719 created file.
6720
41bed37d
PE
6721 * alloc.c (valid_pointer_p): Use pipe, not open.
6722 This fixes some permissions issues when debugging.
6723
b59b67c5
PE
6724 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6725 If fchown fails to set both uid and gid, try to set just gid,
6726 as that is sometimes allowed. Adjust the file's mode to eliminate
6727 setuid or setgid bits that are inappropriate if fchown fails.
6728
925a6be7
SM
67292011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6730
6731 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6732 to compare Lisp_Objects.
6733 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6734 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6735 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6736
52968808
AS
67372011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6738
0a6a104b
AS
6739 * lread.c (read_integer): Unread even EOF character.
6740 (read1): Likewise. Properly record start position of symbol.
6741
52968808
AS
6742 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6743 symbol character follows.
6744
9e381cdd
PE
67452011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6746
6747 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6748 This works around a problem with the previous change to Fcopy_file.
6749 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6750 and without this change, GCC might complain about discarding
6751 fchown's return value.
6752
b5641435
JB
67532011-07-16 Juanma Barranquero <lekktu@gmail.com>
6754
6755 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6756
a8031457
PE
67572011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6758
6759 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6760
dd889327
LMI
67612011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6762
750c33f7
LMI
6763 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6764 it's used from the C level.
6765
dd889327
LMI
6766 * process.c: Use the same condition for POLL_FOR_INPUT in both
6767 keyboard.c and process.c (bug#1858).
6768
87e86684
LM
67692011-07-09 Lawrence Mitchell <wence@gmx.li>
6770
6771 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6772 (Fgnutls_boot): Use it.
6773
64348f40
AS
67742011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6775
6776 * doc.c (Fsubstitute_command_keys): Revert last change.
6777
1d698799
LMI
67782011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6779
f863868c
LMI
6780 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6781 quotes the next character, and doesn't affect other longer
6782 sequences (bug#8935).
6783
1d698799
LMI
6784 * lread.c (syms_of_lread): Clarify that is isn't only
6785 `eval-buffer' and `eval-defun' that's affected by
6786 `lexical-binding' (bug#8460).
6787
aa4b6df6
EZ
67882011-07-15 Eli Zaretskii <eliz@gnu.org>
6789
6790 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6791 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6792
5d856da6
PE
67932011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6794
ad6042bb
PE
6795 Fix minor problems found by static checking.
6796 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6797 (elsz): Now a signed constant, not a size_t var. We prefer signed
6798 types to unsigned, to avoid integer comparison confusion. Without
6799 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6800 "cannot optimize loop, the loop counter may overflow", a symptom
6801 of the confusion.
f00bbb22 6802 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6803 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6804
6468f31c
LMI
68052011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6806
49080b10
LMI
6807 * search.c (Fre_search_backward): Mention `case-fold-search' in
6808 all the re_search_* functions (bug#8138).
6809
6468f31c
LMI
6810 * keyboard.c (Fopen_dribble_file): Document when the file is
6811 closed (bug#8056).
6812
c965adc5
EZ
68132011-07-14 Eli Zaretskii <eliz@gnu.org>
6814
df9733bf
EZ
6815 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6816 bidi_cache_idx.
6817
0bb23927
EZ
6818 Support bidi reordering of display and overlay strings.
6819 * xdisp.c (compute_display_string_pos)
6820 (compute_display_string_end): Accept additional argument STRING.
6821 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6822 (reseat_to_string): Initialize bidi_it->string.s and
6823 bidi_it->string.schars.
6824 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6825 NULL (avoids a crash in bidi_paragraph_init).
6826 Initialize itb.string.lstring.
0bb23927
EZ
6827 (init_iterator): Call bidi_init_it only of a valid
6828 buffer position was specified. Initialize paragraph_embedding to
6829 L2R.
6830 (reseat_to_string): Initialize the bidi iterator.
6831 (display_string): If we need to ignore text properties of
6832 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6833 original value of -1 will not work with bidi.)
6834 (compute_display_string_pos): First arg is now struct
6835 `text_pos *'; all callers changed. Support display properties on
6836 Lisp strings.
6837 (compute_display_string_end): Support display properties on Lisp
6838 strings.
6839 (init_iterator, reseat_1, reseat_to_string): Initialize the
6840 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6841 when iterating on a string not from display properties).
640c8776
SM
6842 (compute_display_string_pos, compute_display_string_end):
6843 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6844 arrow keys.
6845 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6846 base_level_stop; instead, set base_level_stop to BEGV.
6847 Fixes crashes in vertical-motion.
0bb23927
EZ
6848 (next_element_from_buffer): Improve commentary for when
6849 the iterator is before prev_stop.
6850 (init_iterator): Initialize bidi_p from the default value of
6851 bidi-display-reordering, not from buffer-local value. Use the
6852 buffer-local value only if initializing for buffer iteration.
6853 (handle_invisible_prop): Support invisible properties on strings
6854 that are being bidi-reordered.
6855 (set_iterator_to_next): Support bidi reordering of C strings and
6856 Lisp strings.
6857 (next_element_from_string): Support bidi reordering of Lisp
6858 strings.
6859 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6860 (display_string): Support display of R2L glyph rows.
6861 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6862 (init_iterator): Don't initialize it->bidi_p for strings
6863 here.
6864 (reseat_to_string): Initialize it->bidi_p for strings here.
6865 (next_element_from_string, next_element_from_c_string)
6866 (next_element_from_buffer): Add xassert's for correspondence
6867 between IT's object being iterated and it->bidi_it.string
6868 structure.
6869 (face_before_or_after_it_pos): Support bidi iteration.
6870 (next_element_from_c_string): Handle the case of the first string
6871 character that is not the first one in the visual order.
6872 (get_visually_first_element): New function, refactored from common
6873 parts of next_element_from_buffer, next_element_from_string, and
6874 next_element_from_c_string.
6875 (tool_bar_lines_needed, redisplay_tool_bar)
6876 (display_menu_bar): Force left-to-right direction. Add a FIXME
6877 comment for making that be controlled by a user option.
6878 (push_it, pop_it): Save and restore the state of the
6879 bidi iterator. Save and restore the bidi_p flag.
6880 (pop_it): Iterate out of display property for string iteration as
6881 well.
6882 (iterate_out_of_display_property): Support iteration over strings.
6883 (handle_single_display_spec): Set up it->bidi_it for iteration
6884 over a display string, and call bidi_init_it.
6885 (handle_single_display_spec, next_overlay_string)
6886 (get_overlay_strings_1, push_display_prop): Set up the bidi
6887 iterator for displaying display or overlay strings.
6888 (forward_to_next_line_start): Don't use the shortcut if
6889 bidi-iterating.
6890 (back_to_previous_visible_line_start): If handle_display_prop
6891 pushed the iterator stack, restore the internal state of the bidi
6892 iterator by calling bidi_pop_it same number of times.
6893 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6894 and we are bidi-iterating, don't decrement the iterator position;
6895 instead, set the first_elt flag in the bidi iterator, to produce
6896 the same effect.
6897 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6898 (push_display_prop): xassert that we are iterating a buffer.
6899 (push_it, pop_it): Save and restore paragraph_embedding member.
6900 (handle_single_display_spec, next_overlay_string)
6901 (get_overlay_strings_1, reseat_1, reseat_to_string)
6902 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6903 correctly. Don't assume unibyte strings are not bidi-reordered.
6904 (compute_display_string_pos)
6905 (compute_display_string_end): Fix handling the case of C string.
6906 (push_it, pop_it): Save and restore from_disp_prop_p.
6907 (handle_single_display_spec, push_display_prop): Set the
6908 from_disp_prop_p flag.
6909 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6910 (pop_it): Call iterate_out_of_display_property only if we are
6911 popping after iteration over a string that came from a display
6912 property. Fix a typo in popping stretch info. Add an assertion
6913 for verifying that the iterator position is in sync with the bidi
6914 iterator.
6915 (handle_single_display_spec, get_overlay_strings_1)
6916 (push_display_prop): Fix initialization of paragraph direction for
6917 string when that of the parent object is not yet determined.
6918 (reseat_1): Call bidi_init_it to resync the bidi
6919 iterator with IT's position. (Bug#7616)
6920 (find_row_edges): If ROW->start.pos gives position
6921 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6922 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6923 Reset the from_disp_prop_p flag.
6924 (SAVE_IT, RESTORE_IT): New macros.
6925 (pos_visible_p, face_before_or_after_it_pos)
6926 (back_to_previous_visible_line_start)
6927 (move_it_in_display_line_to, move_it_in_display_line)
6928 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6929 (try_scrolling, redisplay_window, display_line): Use them when
6930 saving a temporary copy of the iterator and restoring it back.
6931 (back_to_previous_visible_line_start, reseat_1)
6932 (init_iterator): Empty the bidi cache "stack".
6933 (move_it_in_display_line_to): If iterator ended up at
6934 EOL, but we never saw any buffer positions smaller than
6935 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6936 motion in bidi-reordered lines.
6937 (move_it_in_display_line_to): Record prev_method and prev_pos
6938 immediately before the call to set_iterator_to_next. Fixes cursor
6939 motion in bidi-reordered lines with stretch glyphs and strings
6940 displayed in margins. (Bug#8133) (Bug#8867)
6941 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6942 TO_CHARPOS.
640c8776
SM
6943 (pos_visible_p): Support positions in bidi-reordered lines.
6944 Save and restore bidi cache.
0bb23927
EZ
6945
6946 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6947 (bidi_paragraph_info): Delete unused struct.
6948 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6949 (bidi_cache_start): New variable.
6950 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6951 to zero.
6952 (bidi_cache_fetch_state, bidi_cache_search)
6953 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6954 (bidi_cache_find, bidi_peek_at_next_level)
6955 (bidi_level_of_next_char, bidi_find_other_level_edge)
6956 (bidi_move_to_visually_next): Compare cache index with
6957 bidi_cache_start rather than with zero.
6958 (bidi_fetch_char): Accept new argument STRING; all callers
6959 changed. Support iteration over a string. Support strings with
6960 display properties. Support unibyte strings. Fix the type of
6961 `len' according to what STRING_CHAR_AND_LENGTH expects.
6962 (bidi_paragraph_init, bidi_resolve_explicit_1)
6963 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6964 (bidi_level_of_next_char, bidi_move_to_visually_next):
6965 Support iteration over a string.
0bb23927
EZ
6966 (bidi_set_sor_type, bidi_resolve_explicit_1)
6967 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6968 can now be zero (for strings); special values 0 and -1 were
6969 changed to -1 and -2, respectively.
6970 (bidi_char_at_pos): New function.
6971 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6972 Call it instead of FETCH_MULTIBYTE_CHAR.
6973 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6974 initialized to valid values.
6975 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6976 values.
6977 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6978 the test for valid cached positions. Fix the logic for looking up
6979 the sentinel state in the cache. GCPRO the Lisp string we are
6980 iterating.
6981 (bidi_push_it, bidi_pop_it): New functions.
6982 (bidi_initialize): Initialize the bidi cache start stack pointer.
6983 (bidi_cache_ensure_space): New function, refactored from part of
6984 bidi_cache_iterator_state. Don't assume the required size is just
6985 one BIDI_CACHE_CHUNK away.
6986 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6987 (bidi_count_bytes, bidi_char_at_pos): New functions.
6988 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6989 always valid if bidi_cache_idx is valid.
6990 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6991 is valid if it's going to be used.
6992 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6993 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6994 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6995 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6996 (bidi_find_other_level_edge, bidi_cache_start_stack):
6997 All variables related to cache indices are now EMACS_INT.
c965adc5 6998
0bb23927
EZ
6999 * dispextern.h (struct bidi_string_data): New structure.
7000 (struct bidi_it): New member `string'. Make flag members be 1-bit
7001 fields, and put them last in the struct.
640c8776
SM
7002 (compute_display_string_pos, compute_display_string_end):
7003 Update prototypes.
0bb23927
EZ
7004 (bidi_push_it, bidi_pop_it): Add prototypes.
7005 (struct iterator_stack_entry): New members bidi_p,
7006 paragraph_embedding, and from_disp_prop_p.
7007 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7008 (bidi_shelve_cache, bidi_unshelve_cache):
7009 Declare prototypes.
0bb23927
EZ
7010
7011 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7012 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7013 and vector-like objects.
7014
7015 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7016 cache around display iteration.
7017
7018 * window.c (Fwindow_end, window_scroll_pixel_based)
7019 (displayed_window_lines, Frecenter): Save and restore the bidi
7020 cache around display iteration.
7021
3bbd2265
LMI
70222011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7023
7024 * editfns.c (Fdelete_region): Clarify the use of the named
7025 parameters (bug#6788).
7026
adc47434
MR
70272011-07-14 Martin Rudalics <rudalics@gmx.at>
7028
7029 * indent.c (Fvertical_motion): Set and restore w->pointm when
7030 saving and restoring the window's buffer (Bug#9006).
7031
837c31f8
LMI
70322011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7033
7034 * editfns.c (Fstring_to_char): Clarify just what is returned
7035 (bug#6576). Text by Eli Zaretskii.
7036
ac389d0c
JB
70372011-07-13 Juanma Barranquero <lekktu@gmail.com>
7038
7039 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7040
0be0ce47
EZ
70412011-07-13 Eli Zaretskii <eliz@gnu.org>
7042
7043 * buffer.c (mmap_find): Fix a typo.
7044
cd18e7e3
JB
70452011-07-13 Johan Bockgård <bojohan@gnu.org>
7046
7047 Fix execution of x selection hooks.
7048 * xselect.c (Qx_lost_selection_functions)
7049 (Qx_sent_selection_functions): New vars.
7050 (syms_of_xselect): DEFSYM them.
7051 (x_handle_selection_request): Pass Qx_sent_selection_functions
7052 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7053 (x_handle_selection_clear,x_clear_frame_selections):
7054 Pass Qx_lost_selection_functions rather than
7055 Vx_lost_selection_functions to Frun_hook_with_args.
7056
47ea7f44
PE
70572011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7058
ac389d0c 7059 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7060 The old code sometimes used this field without initializing it.
7061
47ea7f44
PE
7062 * alloc.c (gc_sweep): Don't read past end of array.
7063 In theory, the old code could also have corrupted Emacs internals,
7064 though it'd be very unlikely.
7065
bc985c87
AS
70662011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7067
7068 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7069 argument. (Bug#4026)
bc985c87 7070
0cf34688
LMI
70712011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7072
b3dadd76
LMI
7073 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7074 key" (bug#4257).
7075
0cf34688
LMI
7076 * window.c (Fset_window_start): Doc fix (bug#4199).
7077 (Fset_window_hscroll): Ditto.
7078
270768cd
PE
70792011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7080
077e3dda 7081 Fix minor new problems caught by GCC 4.6.1.
270768cd 7082 * term.c (init_tty): Remove unused local.
490011a6 7083 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7084 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7085 not used otherwise.
270768cd 7086
b1f58454
CY
70872011-07-12 Chong Yidong <cyd@stupidchicken.com>
7088
7089 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7090
22b9578d
LMI
70912011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7092
6e70ab07
LMI
7093 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7094 are the mini-buffer and the echo area (bug#3320).
7095
22b9578d
LMI
7096 * term.c (init_tty): Remove support for supdup, c10 and perq
7097 terminals, which are no longer supported (bug#1482).
7098
8974cc9f
JB
70992011-07-10 Johan Bockgård <bojohan@gnu.org>
7100
7101 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7102
a560d974
JD
71032011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7104
7105 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7106 for non-popups (Bug#3642).
7107
1dae0f0a
AS
71082011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7109
268c2c36 7110 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7111 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7112 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7113 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7114 * data.c (fmod): Likewise.
7115 * dispnew.c (swap_glyphs_in_rows): Likewise.
7116 * emacs.c (memory_warning_signal): Likewise.
7117 * floatfns.c (float_error): Likewise.
7118 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7119 (otf_open, font_otf_capability, generate_otf_features)
7120 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7121 Likewise.
7122 * image.c (pbm_read_file): Likewise.
7123 * indent.c (string_display_width): Likewise.
7124 * intervals.c (check_for_interval, search_for_interval)
7125 (inc_interval_count, count_intervals, root_interval)
7126 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7127 * lread.c (defalias): Likewise.
268c2c36 7128 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7129 * regex.c (set_image_of_range_1, set_image_of_range)
7130 (regex_grow_registers): Likewise.
7131 * sysdep.c (strerror): Likewise.
7132 * termcap.c (valid_filename_p, tprint, main): Likewise.
7133 * tparam.c (main): Likewise.
7134 * unexhp9k800.c (run_time_remap, save_data_space)
7135 (update_file_ptrs, read_header, write_header, calculate_checksum)
7136 (copy_file, copy_rest, display_header): Likewise.
7137 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7138 Likewise.
7139 * xdisp.c (check_it): Likewise.
7140 * xfaces.c (register_color, unregister_color, unregister_colors):
7141 Likewise.
7142 * xfns.c (print_fontset_result): Likewise.
7143 * xrdb.c (member, fatal, main): Likewise.
7144
99033785
PE
71452011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7146
7147 Fix minor problems found by static checking (Bug#9031).
7148 * chartab.c (char_table_set_range, map_sub_char_table):
7149 Remove unused locals.
7150 (uniprop_table): Now static.
7151 * composite.c (_work_char): Remove unused static var.
7152
9cb2ac56
JB
71532011-07-09 Juanma Barranquero <lekktu@gmail.com>
7154
7155 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7156
f25661f0
JD
71572011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7158
7159 * gtkutil.c (qttip_cb): Remove code without function.
7160
8278c4fe
EZ
71612011-07-09 Eli Zaretskii <eliz@gnu.org>
7162
7163 * w32.c (pthread_sigmask): New stub.
7164
1692ae2d 71652011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7166
8a6ebd58 7167 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7168 sigprocmask is portable only for single-threaded applications, and
7169 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7170 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7171 (LIBES): Use it.
7172 * callproc.c (Fcall_process):
7173 * process.c (create_process):
7174 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7175 Use pthread_sigmask, not sigprocmask.
123403e4 7176
1b854618
JD
71772011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7178
7179 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7180 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7181 wrong (Bug#8591).
7182
3fe4b549
JD
71832011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7184
0ce7e563
JD
7185 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7186 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7187 (xg_hide_tooltip): Fix comment.
7188
3fe4b549
JD
7189 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7190 in registerServicesMenuSendTypes.
7191 (validRequestorForSendType): Don't check ns_return_types.
7192
7193 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7194 ns_return_type.
7195
5df75e47
JR
71962011-07-08 Jason Rumney <jasonr@gnu.org>
7197
22610910
JR
7198 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7199 SH_SHOW for hidden windows (Bug#5482).
7200
5df75e47
JR
7201 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7202 frame struct members of non-existent frames (Bug#6284).
7203
699c10bd
JD
72042011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7205
4393663b
JD
7206 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7207 variable firstTime not needed on OSX >= 10.6.
7208 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7209 >= 10.5. Use setKnobProportion, setDoubleValue.
7210
7211 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7212 (MAC_OS_X_VERSION_10_5): Define if not defined.
7213 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7214 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7215 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7216
7217 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7218 cString and lossyCString on OSX >= 10.4
7219
58179cce 7220 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7221 sizeToFit on OSX >= 10.2.
7222
7223 * nsimage.m (allocInitFromFile): Don't use deprecated method
7224 bestRepresentationForDevice on OSX >= 10.6.
7225
7226 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7227 to avoid warning.
7228
7229 * emacs.c: Declare unexec_init_emacs_zone.
7230
a63e0781
JD
7231 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7232
699c10bd
JD
7233 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7234
7235 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7236 on svcsMenu (Bug#8842).
7237
7238 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7239 ns_return_types.
7240 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7241
7242 * nsterm.m (QUTF8_STRING): Declare.
7243 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7244 (validRequestorForSendType): Return type is (id).
7245 Change indexOfObjectIdenticalTo to indexOfObject.
7246 Check if we have local selection before returning self (Bug#8842).
7247 (writeSelectionToPasteboard): Put local selection into paste board
7248 if we have a local selection (Bug#8842).
7249 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7250
7251 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7252 (ns_get_local_selection): Declare.
7253
54e10184
LMI
72542011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7255
9888ff71
LMI
7256 * keymap.c (describe_map_tree): Don't insert a double newline at
7257 the end of the buffer (bug#1169) and return whether we inserted
7258 something.
7259
54e10184
LMI
7260 * callint.c (Fcall_interactively): Change "reading args" to
7261 "providing args" to try to clarify what it does (bug#1010).
7262
15fa4783
KH
72632011-07-07 Kenichi Handa <handa@m17n.org>
7264
7265 * composite.c (composition_compute_stop_pos): Ignore a static
7266 composition starting before CHARPOS (Bug#8915).
7267
7268 * xdisp.c (handle_composition_prop): Likewise.
7269
a8815b00
EZ
72702011-07-07 Eli Zaretskii <eliz@gnu.org>
7271
7272 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7273 (Bug#9015)
7274
ef7b981d 72752011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7276
7277 * character.h (unicode_category_t): New enum type.
7278
7279 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7280 (Qchar_code_property_table): New variable.
7281 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7282 (UNIPROP_COMPRESSED_FORM_P): New macros.
7283 (char_table_ascii): Uncompress the compressed values.
7284 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7285 Uncompress the compressed values.
ac389d0c 7286 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7287 (char_table_ref_and_range): Uncompress the compressed values.
7288 (sub_char_table_set): New arg is_uniprop. Callers changed.
7289 Uncompress the compressed values.
7290 (sub_char_table_set_range): Args changed. Callers changed.
7291 (char_table_set_range): Adjuted for the above change.
7292 (map_sub_char_table): Delete args default_val and parent. Add arg
7293 top. Give decoded values to a Lisp function.
640c8776 7294 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7295 values to a Lisp function. Gcpro more variables.
7296 (uniprop_table_uncompress)
7297 (uniprop_decode_value_run_length): New functions.
7298 (uniprop_decoder, uniprop_decoder_count): New variables.
7299 (uniprop_get_decoder, uniprop_encode_value_character)
7300 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7301 New functions.
7302 (uniprop_encoder, uniprop_encoder_count): New variables.
7303 (uniprop_get_encoder, uniprop_table)
7304 (Funicode_property_table_internal, Fget_unicode_property_internal)
7305 (Fput_unicode_property_internal): New functions.
7306 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7307 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7308 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7309 char-code-property-alist.
7310
640c8776 7311 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7312 Vunicode_category_table.
7313
640c8776 7314 * font.c (font_range): Adjust for the change of
c805dec0
KH
7315 Vunicode_category_table.
7316
76b397fb
DN
73172011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7318
7319 * m/iris4d.h: Remove file, move contents ...
7320 * s/irix6-5.h: ... here.
7321
22b4128e
PE
73222011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7323
7324 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7325 * alloc.c (mark_buffer):
7326 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7327 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7328 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7329 This isn't true in general, and it's particularly not true
7330 if Emacs is configured with --with-wide-int.
7331 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7332 New macros, used in the buffer.c change.
7333
869795d6
JD
73342011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7335
7336 * xsettings.c: Use both GConf and GSettings if both are available.
7337 (store_config_changed_event): Add comment.
7338 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7339 (store_tool_bar_style_changed): New functions.
5e617bc2 7340 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7341 (struct xsettings): Move font inside HAVE_XFT.
7342 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7343 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7344 Move inside HAVE_XFT.
640c8776 7345 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7346 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7347 also.
7348 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7349 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7350 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7351 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7352 (parse_settings): Move check for font inside HAVE_XFT.
7353 (read_settings, apply_xft_settings): Add comment.
7354 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7355 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7356 call store_font_name_changed.
7357 (xft_settings_event): Add comment.
7358 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7359 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7360 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7361 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7362 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7363 (xsettings_get_system_font, xsettings_get_system_normal_font):
7364 Add comment.
869795d6 7365
d8ed26bd
PE
73662011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7367
7368 Random fixes. E.g., (random) never returned negative values.
7369 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7370 subseconds part to the entropy, as that's a bit more random.
7371 Prefer signed to unsigned, since the signedness doesn't matter and
7372 in general we prefer signed. When given a limit, use a
7373 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7374 latter isn't right if USE_2_TAGS_FOR_INTS.
7375 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7376 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7377
cabf1cac
SM
73782011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7379
7380 * textprop.c (text_property_stickiness):
7381 Obey Vtext_property_default_nonsticky.
7382 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7383 * w32fns.c (syms_of_w32fns):
7384 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7385
6e9b2be9
PE
73862011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7387
7388 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7389 This is more efficient than Ffile_directory_p and avoids a minor race.
7390
90186c68
LMI
73912011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7392
7c301272
LMI
7393 * buffer.c (Foverlay_put): Say what the return value is
7394 (bug#7835).
7395
c4f2d8d4
LMI
7396 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7397 is a directory before asking whether to use the file name
7398 (bug#7564).
ad637907
LMI
7399 (barf_or_query_if_file_exists): Make the "File is a directory"
7400 error be more correct.
c4f2d8d4 7401
90186c68
LMI
7402 * fns.c (Frequire): Remove the mention of the .gz files, since
7403 that's installation-specific, but keep the mention of
7404 `get-load-suffixes'.
7405
da64016e
PE
74062011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7407
7408 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7409 Report string overflow if the output is too long.
7410
7d47b580
JB
74112011-07-04 Juanma Barranquero <lekktu@gmail.com>
7412
a555cb87
JB
7413 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7414 (syms_of_gnutls): Remove duplicate DEFSYM for
7415 Qgnutls_bootprop_verify_hostname_error, an error for
7416 Qgnutls_bootprop_verify_error (which is no longer used).
7417
7d47b580
JB
7418 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7419 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7420 Also (re)move comments that are misplaced or no longer relevant.
7421
1e49bfab
LMI
74222011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7423
7424 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7425
1485f4c0
CY
74262011-07-03 Chong Yidong <cyd@stupidchicken.com>
7427
7428 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7429 and background color parameters if they have been changed.
7430
a9ab721e
LMI
74312011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7432
7433 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7434
cf7cff57
PE
74352011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7436
2e13213d
PE
7437 * xsettings.c (SYSTEM_FONT): Define only when used.
7438 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7439
cf7cff57
PE
7440 * keymap.c (access_keymap_1): Now static.
7441
7a8e04f7
CY
74422011-07-02 Chong Yidong <cyd@stupidchicken.com>
7443
7444 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7445 leave any prefix arg for the up event (Bug#1586).
7446
61352f62
LMI
74472011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7448
69bb1ef7
LMI
7449 * lread.c (syms_of_lread): Mention single symbols defined by
7450 `defvar' or `defconst' (bug#7154).
7451
61352f62 7452 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7453 (Frequire): Mention get-load-suffixes.
61352f62 7454
28545e04
MR
74552011-07-02 Martin Rudalics <rudalics@gmx.at>
7456
7457 * window.h (window): Remove clone_number slot.
7458 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7459 Remove.
7460 (make_parent_window, make_window, saved_window)
7461 (Fset_window_configuration, save_window_save): Don't deal with
7462 clone numbers.
7463 * buffer.c (Qclone_number): Remove declaration.
7464 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7465
3349e122
SM
74662011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7467
7468 Add multiple inheritance to keymaps.
7469 * keymap.c (Fmake_composed_keymap): New function.
7470 (Fset_keymap_parent): Simplify.
7471 (fix_submap_inheritance): Remove.
7472 (access_keymap_1): New function extracted from access_keymap to handle
7473 embedded parents and handle lists of maps.
7474 (access_keymap): Use it.
7475 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7476 (Fcopy_keymap): Handle embedded parents.
7477 (Fcommand_remapping, define_as_prefix): Simplify.
7478 (Fkey_binding): Simplify.
7479 (syms_of_keymap): Move minibuffer-local-completion-map,
7480 minibuffer-local-filename-completion-map,
7481 minibuffer-local-must-match-map, and
7482 minibuffer-local-filename-must-match-map to Elisp.
7483 (syms_of_keymap): Defsubr make-composed-keymap.
7484 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7485 (parse_menu_item): Trivial simplification.
7486
3279eb87
GM
74872011-07-01 Glenn Morris <rgm@gnu.org>
7488
7489 * Makefile.in (SETTINGS_LIBS): Fix typo.
7490
4550efdf
KI
74912011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7492
7493 * coding.c (Fencode_coding_string): Record the last coding system
7494 used, as the function doc string says (bug#8738).
7495
0949d2b6
JD
74962011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7497
7498 * xsettings.c (store_monospaced_changed): Take new font as arg and
7499 check for change against current_mono_font.
7500 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7501 (emacs_settings_constructor, emacs_settings_get_property)
7502 (emacs_settings_set_property, emacs_settings_class_init)
7503 (emacs_settings_init, gsettings_obj): Remove.
7504 (something_changedCB): New function for HAVE_GSETTINGS.
7505 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7506 with value as argument.
7507 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7508 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7509 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7510 "changed".
7511
7512 * xgselect.c: Add defined (HAVE_GSETTINGS).
7513 (xgselect_initialize): Ditto.
7514
7515 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7516 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7517 xg_select.
7518
bbc6b304
PE
75192011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7520
7521 * eval.c (struct backtrace): Simplify and port the data structure.
7522 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7523 signed bit field, as this assumption is not portable and it makes
7524 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7525 "char debug_on_exit : 1" as this is not portable either; instead,
7526 use the portable "unsigned int debug_on_exit : 1". Remove unused
7527 member evalargs. Remove obsolete comments about cc bombing out.
7528
9851bfc5
JD
75292011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7530
51bb811f 7531 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7532 Let HAVE_GSETTINGS override HAVE_GCONF.
7533 (store_monospaced_changed): New function.
7534 (EMACS_SETTINGS): A new type derived from GObject to handle
7535 GSettings notifications.
7536 (emacs_settings_constructor, emacs_settings_get_property)
7537 (emacs_settings_set_property, emacs_settings_class_init):
7538 New functions.
7539 (gsettings_client, gsettings_obj): New variables.
7540 (GSETTINGS_SCHEMA): New define.
7541 (something_changedCB): Call store_monospaced_changed.
7542 (init_gsettings): New function.
7543 (xsettings_initialize): Call init_gsettings.
7544 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7545 to NULL.
7546
640c8776 7547 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7548 GCONF_CFLAGS/LIBS.
7549
5386012d
MR
75502011-06-29 Martin Rudalics <rudalics@gmx.at>
7551
7552 * window.c (resize_root_window, grow_mini_window)
7553 (shrink_mini_window): Rename Qresize_root_window to
7554 Qwindow_resize_root_window and Qresize_root_window_vertically to
7555 Qwindow_resize_root_window_vertically.
7556
f13e0b08
PE
75572011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7558
7559 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7560
94515237
JB
75612011-06-27 Juanma Barranquero <lekktu@gmail.com>
7562
7563 * makefile.w32-in: Redesign dependencies so they reflect more
7564 clearly which files are directly included by each source file,
7565 and not through other includes.
7566
e43b6e43
MR
75672011-06-27 Martin Rudalics <rudalics@gmx.at>
7568
7569 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7570 (sort_overlays, overlay_strings): When an overlay's clone number
7571 matches the window's clone number process the overlay even if
7572 the overlay's window property doesn't match the current window.
7573
d68443dc
MR
7574 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7575 (Fwindow_hchild): Rename to Fwindow_left_child.
7576 (Fwindow_next): Rename to Fwindow_next_sibling.
7577 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7578 (resize_window_check): Rename to window_resize_check.
7579 (resize_window_apply): Rename to window_resize_apply.
7580 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7581 (Fdelete_other_windows_internal, resize_frame_windows)
7582 (Fsplit_window_internal, Fdelete_window_internal)
7583 (grow_mini_window, shrink_mini_window)
7584 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7585
c7e73be5
JD
75862011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7587
7588 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7589 (emacs_fixed_set_min_size): Remove.
7590 (emacs_fixed_new): Take frame as argument.
7591
7592 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7593 (_EmacsFixedPrivate): Remove minwidth/height.
7594 Add struct frame *f.
7595 (emacs_fixed_init): Initialize priv->f.
7596 (get_parent_class, emacs_fixed_set_min_size): Remove.
7597 (emacs_fixed_new): Set priv->f to argument.
7598 (emacs_fixed_get_preferred_width)
7599 (emacs_fixed_get_preferred_height): Use min_width/height from
7600 frames size_hint to set minimum and natural (Bug#8919).
7601 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7602 and use min_width/height from frames size_hint to set
7603 min_width/height (Bug#8919).
7604
7605 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7606 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7607 Fix indentation.
c7e73be5 7608
cf99dcf8
EZ
76092011-06-26 Eli Zaretskii <eliz@gnu.org>
7610
7611 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7612 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7613 called at ZV.
7614
029529ac
CY
76152011-06-26 Chong Yidong <cyd@stupidchicken.com>
7616
7617 * process.c (wait_reading_process_output): Bypass select if
7618 waiting for a cell while ignoring keyboard input, and input is
7619 pending. Suggested by Jan Djärv (Bug#8869).
7620
7a7ef429
PE
76212011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7622
7623 Use gnulib's dup2 module instead of rolling our own.
7624 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7625
11fdef7d 76262011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7627
7628 * dispnew.c (scrolling_window): Before scrolling, turn off a
7629 mouse-highlight in the window being scrolled.
7630
cd3520a4
JB
76312011-06-24 Juanma Barranquero <lekktu@gmail.com>
7632
7633 Move DEFSYM to lisp.h and use everywhere.
7634
7635 * character.h (DEFSYM): Move declaration...
7636 * lisp.h (DEFSYM): ...here.
7637
7638 * gnutls.c:
7639 * minibuf.c:
7640 * w32menu.c:
7641 * w32proc.c:
7642 * w32select.c: Don't include character.h.
7643
7644 * alloc.c (syms_of_alloc):
7645 * buffer.c (syms_of_buffer):
7646 * bytecode.c (syms_of_bytecode):
7647 * callint.c (syms_of_callint):
7648 * casefiddle.c (syms_of_casefiddle):
7649 * casetab.c (init_casetab_once):
7650 * category.c (init_category_once, syms_of_category):
7651 * ccl.c (syms_of_ccl):
7652 * cmds.c (syms_of_cmds):
7653 * composite.c (syms_of_composite):
7654 * dbusbind.c (syms_of_dbusbind):
7655 * dired.c (syms_of_dired):
7656 * dispnew.c (syms_of_display):
7657 * doc.c (syms_of_doc):
7658 * editfns.c (syms_of_editfns):
7659 * emacs.c (syms_of_emacs):
7660 * eval.c (syms_of_eval):
7661 * fileio.c (syms_of_fileio):
7662 * fns.c (syms_of_fns):
7663 * frame.c (syms_of_frame):
7664 * fringe.c (syms_of_fringe):
7665 * insdel.c (syms_of_insdel):
7666 * keymap.c (syms_of_keymap):
7667 * lread.c (init_obarray, syms_of_lread):
7668 * macros.c (syms_of_macros):
7669 * msdos.c (syms_of_msdos):
7670 * print.c (syms_of_print):
7671 * process.c (syms_of_process):
7672 * search.c (syms_of_search):
7673 * sound.c (syms_of_sound):
7674 * syntax.c (init_syntax_once, syms_of_syntax):
7675 * terminal.c (syms_of_terminal):
7676 * textprop.c (syms_of_textprop):
7677 * undo.c (syms_of_undo):
7678 * w32.c (globals_of_w32):
7679 * window.c (syms_of_window):
7680 * xdisp.c (syms_of_xdisp):
7681 * xfaces.c (syms_of_xfaces):
7682 * xfns.c (syms_of_xfns):
7683 * xmenu.c (syms_of_xmenu):
7684 * xsettings.c (syms_of_xsettings):
7685 * xterm.c (syms_of_xterm): Use DEFSYM.
7686
4228cf16
TZ
76872011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7688
cd3520a4 7689 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7690
7fcccf1e
PE
76912011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7692
7efb4e0e
PE
7693 Integer and buffer overflow fixes (Bug#8873).
7694
ff5844ad
PE
7695 * print.c (printchar, strout): Check for string overflow.
7696 (PRINTPREPARE, printchar, strout):
7697 Don't set size unless allocation succeeds.
7698
90532f02
PE
7699 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7700 for sizes. Check for string overflow more accurately.
7701 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7702
6d84508d
PE
7703 * macros.c: Integer and buffer overflow fixes.
7704 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7705 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7706 Use ptrdiff_t, not int, for sizes.
7707 Don't increment bufsize until after realloc succeeds.
7708 Check for size-calculation overflow.
7709 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7710
437b2cb4
PE
7711 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7712
8b9ac8b4
PE
7713 * lread.c: Integer overflow fixes.
7714 (read_integer): Radix is now EMACS_INT, not int,
7715 to improve quality of diagnostics for out-of-range radices.
7716 Calculate buffer size correctly for out-of-range radices.
7717 (read1): Check for integer overflow in radices, and in
7718 read-circle numbers.
82cb60d3
PE
7719 (read_escape): Avoid int overflow.
7720 (Fload, openp, read_buffer_size, read1)
7721 (substitute_object_recurse, read_vector, read_list, map_obarray):
7722 Use ptrdiff_t, not int, for sizes.
7723 (read1): Use EMACS_INT, not int, for sizes.
20270765 7724 Check for size overflow.
8b9ac8b4 7725
7fcccf1e
PE
7726 * image.c (cache_image): Check for size arithmetic overflow.
7727
bfbbd7e7
PE
7728 * lread.c: Integer overflow issues.
7729 (saved_doc_string_size, saved_doc_string_length)
7730 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7731 Now ptrdiff_t, not int.
7732 (read1): Don't assume doc string length fits in int. Check for
7733 out-of-range doc string lengths.
7734 (read_list): Don't assume file position fits in int.
39019e54 7735 (read_escape): Check for hex character overflow.
bfbbd7e7 7736
4e323265
LL
77372011-06-22 Leo Liu <sdl.web@gmail.com>
7738
7739 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7740 Move to minibuffer.el.
7741
85fece3e
PE
77422011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7743
20b84ce9 7744 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7745 The following patches are for when GLYPH_DEBUG && !XASSERT.
7746 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7747 * dispnew.c (flush_stdout):
7748 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7749 Mark as externally visible.
7750 * dispnew.c (check_window_matrix_pointers): Now static.
7751 * dispnew.c (window_to_frame_vpos):
7752 * xfns.c (unwind_create_frame):
7753 * xterm.c (x_check_font): Remove unused local.
7754 * scroll.c (CHECK_BOUNDS):
7755 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7756 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7757 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7758 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7759 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7760 Now static.
7761 (debug_method_add): Use va_list and vsprintf rather than relying
7762 on undefined behavior with wrong number of arguments.
7763 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7764 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7765 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7766 since we're not interested in debugging glyphs with old libraries.
7767 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7768 GCC 4.6.0's static checking.
7769
0766b489
PE
77702011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7771
31fd4b32
PE
7772 Integer overflow and signedness fixes (Bug#8873).
7773 A few related buffer overrun fixes, too.
7774
b79e8648
PE
7775 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7776
0766b489
PE
7777 * dispextern.h (struct face.stipple):
7778 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7779 (x_bitmap_mask, x_allocate_bitmap_record)
7780 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7781 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7782 (x_create_bitmap_from_xpm_data):
7783 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7784 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7785 (.bitmaps_last):
7786 * xfaces.c (load_pixmap):
7787 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7788 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7789 (.bitmaps_last, struct x_output.icon_bitmap):
7790 Use ptrdiff_t, not int, for bitmap indexes.
7791 (x_allocate_bitmap_record): Check for size overflow.
7792 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7793
b081724f
PE
7794 Use ptrdiff_t, not int, for overlay counts.
7795 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7796 * editfns.c (overlays_around, get_pos_property):
7797 * textprop.c (get_char_property_and_overlay):
7798 * xdisp.c (next_overlay_change, note_mouse_highlight):
7799 * xfaces.c (face_at_buffer_position):
21514da7
PE
7800 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7801 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7802 (Fnext_overlay_change, Fprevious_overlay_change)
7803 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7804 Use ptrdiff_t, not int, for sizes.
21514da7 7805 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7806
3de73e5e
PE
7807 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7808
2606c57b
PE
7809 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7810 (x_session_initialize): Do not assume string length fits in int.
7811
aaafe47a
PE
7812 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7813 This is unlikely, but can occur if DPI is outlandish.
7814
2674ddc8 7815 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7816 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7817
28154962
PE
7818 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7819 * xrdb.c (magic_file_p, search_magic_path):
7820 Omit last arg SUFFIX; it was always 0. All callers changed.
7821 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7822
7de51af5
PE
7823 * xfont.c (xfont_match): Avoid need for strlen.
7824
25ed6cc3
PE
7825 * xfns.c: Don't assume strlen fits in int.
7826 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7827
4eab31dd
PE
7828 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7829 not unsigned long, as we prefer signed integers. All callers changed.
7830 Detect integer overflow in repeat count.
7831 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7832 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7833
171e2a58
PE
7834 * termcap.c: Don't assume sizes fit in int and never overflow.
7835 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7836 (gobble_line): Check for size-calculation overflow.
7837
ad39faca 7838 * minibuf.c (Fread_buffer):
6e5bb2dc 7839 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7840 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7841 Don't assume string length fits in int.
7842
52c61c22 7843 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7844 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7845
b5b8c9e5
PE
7846 * font.c: Don't assume string length fits in int.
7847 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7848 Use ptrdiff_t, not int.
ccd6111c
PE
7849 (font_intern_prop): Don't assume string length fits in int.
7850 Don't assume integer property fits in fixnum.
7851 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7852
882f0d81 7853 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7854 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7855 Reformulate so as not to need the command string.
7856 Invoke gzip -cd rather than gunzip, as it's more portable.
7857 (lock_info_type, lock_file_1, lock_file):
7858 Don't assume pid_t and time_t fit in unsigned long.
7859 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7860 (current_lock_owner): Prefer signed type for sizes.
7861 Use memcpy, not strncpy, where memcpy is what is really wanted.
7862 Don't assume (via atoi) that time_t and pid_t fit in int.
7863 Check for time_t and/or pid_t out of range, e.g., via a network share.
7864 Don't alloca where an auto var works fine.
7865
93f4cf88
PE
7866 * fileio.c: Fix some integer overflow issues.
7867 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7868 Don't assume string length fits in int.
7869 (directory_file_name): Don't assume string length fits in long.
7870 (make_temp_name): Don't assume pid fits in int, or that its print
7871 length is less than 20.
7872
f3e92b69
PE
7873 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7874
1bfdaf10
PE
7875 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7876
35016e9a
PE
7877 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7878
3d1e65a1
PE
7879 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7880 We prefer signed integers, even for size calculations.
7881
0b963a93
PE
7882 * emacs.c: Don't assume string length fits in 'int'.
7883 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7884 (main): Don't invoke strlen when not needed.
7885
573f4b54
PE
7886 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7887 (XD_DEBUG_MESSAGE): Don't waste a byte.
7888
989f33ba
PE
7889 * callproc.c (getenv_internal_1, getenv_internal)
7890 (Fgetenv_internal):
965d34eb
PE
7891 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7892
e4d29b33
PE
7893 * lread.c (invalid_syntax): Omit length argument.
7894 All uses changed. This doesn't fix a bug, but it simplifies the
7895 code away from its former Hollerith-constant appearance, and it's
7896 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7897 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7898
eb49b136
PE
7899 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7900 This didn't break anything, but it didn't help either.
7901 It's confusing to put a bogus integer in a place where the actual
7902 value does not matter.
9f62aeb1 7903 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7904 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7905
15375a22
PE
7906 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7907 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7908 implementation.
b61cc01c
PE
7909 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7910 We prefer signed types, and the value cannot exceed the EMACS_INT
7911 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7912 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7913 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7914 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7915
53b2623d
PE
7916 * indent.c (sane_tab_width): New function.
7917 (current_column, scan_for_column, Findent_to, position_indentation)
7918 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7919 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7920
51cab52b 7921 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7922
f2ed8a70
PE
7923 * lisp.h (lint_assume): New macro.
7924 * composite.c (composition_gstring_put_cache):
7925 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7926
abe80cc6
PE
7927 * editfns.c, insdel.c:
7928 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7929
b02c740e
PE
7930 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7931
ebc96716
PE
7932 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7933
b4e50fa0 7934 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7935 Use much-faster test for byte-length change.
311d5d7c 7936 Don't assume string byte-length fits in 'int'.
a4cf38e4 7937 Check that character arg fits in 'int'.
85461888 7938 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7939
c0c1ee9f
PE
7940 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7941
a498d7f4
PE
7942 * fns.c (concat): Catch string overflow earlier.
7943 Do not rely on integer wraparound.
7944
51cab52b
PE
7945 * dispextern.h (struct it.overlay_strings_charpos)
7946 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7947 * xdisp.c (forward_to_next_line_start)
7948 (back_to_previous_visible_line_start)
7949 (reseat_at_next_visible_line_start, next_element_from_buffer):
7950 Don't arbitrarily truncate the value of 'selective' to int.
7951
76031fad
PE
7952 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7953
5eb55db9
PE
7954 * composite.c: Don't truncate sizes to 'int'.
7955 (composition_gstring_p, composition_reseat_it)
7956 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7957 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7958 not EMACS_UINT, for indexes.
5eb55db9 7959
0703a717
PE
7960 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7961
d6202519
PE
7962 * buffer.c: Include <verify.h>.
7963 (struct sortvec.priority, struct sortstr.priority):
8961a454 7964 Now EMACS_INT, not int.
c20998a7 7965 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7966 (struct sortstr.size, record_overlay_string)
7967 (struct sortstrlist.size, struct sortlist.used):
7968 Don't truncate size to int.
7969 (record_overlay_string): Check for size-calculation overflow.
d6202519 7970 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7971
d5a19415
JM
79722011-06-22 Jim Meyering <meyering@redhat.com>
7973
029529ac 7974 Don't leak an XBM-image-sized buffer
d5a19415
JM
7975 * image.c (xbm_load): Free the image buffer after using it.
7976
a9041e6c
PE
79772011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7978
7979 Port to Sun C.
7980 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7981 that Sun C diagnosed.
7982 * fns.c (secure_hash): Fix pointer signedness issue.
7983 * intervals.c (static_offset_intervals): New function.
7984 (offset_intervals): Use it.
7985
7f3f739f
LL
79862011-06-21 Leo Liu <sdl.web@gmail.com>
7987
7988 * deps.mk (fns.o):
7989 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7990 sha512.h.
7991
7992 * fns.c (secure_hash): Rename from crypto_hash_function and change
7993 the first arg to accept symbols.
5b66d427 7994 (Fsecure_hash): New primitive.
7f3f739f
LL
7995 (syms_of_fns): New symbols.
7996
76147d94
DD
79972011-06-20 Deniz Dogan <deniz@dogan.se>
7998
7999 * process.c (Fset_process_buffer): Clarify return value in
8000 docstring.
8001
7d7d0045
CY
80022011-06-18 Chong Yidong <cyd@stupidchicken.com>
8003
8004 * dispnew.c (add_window_display_history): Use BVAR.
8005
8006 * xdisp.c (debug_method_add): Use BVAR.
8007 (check_window_end, dump_glyph_matrix, dump_glyph)
8008 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8009
8010 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8011 Likewise.
8012
8013 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8014 check till after the cache is created in init_frame_faces.
8015
ff2bc410
SM
80162011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8017
8018 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8019
28177add
PE
80202011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8021
dd3482fe
PE
8022 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8023 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8024 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8025
393d71f3 8026 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8027 * fileio.c (Finsert_file_contents):
8028 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8029 Remove the old (too-loose) buffer overflow checks.
8030 They weren't needed, since make_gap checks for buffer overflow.
8031 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8032 The old code merely checked for Emacs fixnum overflow, and relied
8033 on undefined (wraparound) behavior. The new code avoids undefined
8034 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8035
2e6813b0 8036 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8037 Tune. Don't use wider integers than needed. Don't use alloca.
8038 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8039
599a9e4f
PE
8040 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8041
99561444
PE
8042 * insdel.c, lisp.h (buffer_overflow): New function.
8043 (insert_from_buffer_1, replace_range, replace_range_2):
8044 * insdel.c (make_gap_larger):
8045 * editfns.c (Finsert_char):
8046 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8047
28177add
PE
8048 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8049
e69dafad
PE
80502011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8051
4baa020d 8052 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8053
b1c46f02
PE
8054 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8055 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8056
e69dafad
PE
8057 * fileio.c: Don't assume EMACS_INT fits in off_t.
8058 (emacs_lseek): New static function.
8059 (Finsert_file_contents, Fwrite_region): Use it.
8060 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8061
566684ea
PE
8062 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8063
e6966cd6
PE
8064 * fns.c: Don't overflow int when computing a list length.
8065 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8066 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8067 truncation on 64-bit hosts. Check for QUIT every
8068 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8069 faster and is responsive enough.
8070 (Flength): Report an error instead of overflowing an integer.
8071 (Fsafe_length): Return a float if the value is not representable
8072 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8073 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8074 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8075
dd0b0efb
PE
8076 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8077 (header_size, word_size): New constants.
8078 (allocate_vectorlike): Don't check size overflow here.
8079 (allocate_vector): Check it here instead, since this is the only
8080 caller of allocate_vectorlike that could cause overflow.
8081 Check that the new vector's length is representable as a fixnum.
8082
86fe5cfe
PE
8083 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8084 The previous code was bogus. For example, next_almost_prime (32)
8085 returned 39, which is undesirable as it is a multiple of 3; and
8086 next_almost_prime (24) returned 25, which is a multiple of 5 so
8087 why was the code bothering to check for multiples of 7?
8088
80e88859
PE
8089 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8090
4a2f0ad6
PE
8091 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8092
f66c7cf8
PE
8093 Variadic C functions now count arguments with ptrdiff_t.
8094 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8095 Back then I didn't know that the Emacs coding style prefers signed int.
8096 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8097 were being counted with int, which may truncate counts on 64-bit
8098 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8099 * lisp.h (struct Lisp_Subr.function.aMANY)
8100 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8101 Arg counts are now ptrdiff_t, not size_t.
8102 All variadic functions and their callers changed accordingly.
8103 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8104 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8105 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8106 * callint.c (Fcall_interactively): Check arg count for overflow,
8107 to avoid potential buffer overrun. Use signed char, not 'int',
8108 for 'varies' array, so that we needn't bother to check its size
8109 calculation for overflow.
8110 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8111 * eval.c (apply_lambda):
8112 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8113 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8114 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8115
a1759b76
PE
8116 * callint.c (Fcall_interactively): Don't use index var as event count.
8117
d96be9fc
PE
8118 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8119 * mem-limits.h (SIZE): Remove; no longer used.
8120
a690a978 8121 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8122
578c21e6
PE
8123 Remove unnecessary casts.
8124 * xterm.c (x_term_init):
8125 * xfns.c (x_set_border_pixel):
8126 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8127 These aren't needed now that we assume ANSI C.
8128
96f53c6c
PE
8129 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8130 It's more likely to cause problems (due to unsigned overflow)
8131 than to cure them.
8132
83c77d31
PE
8133 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8134
ee2079f1
PE
8135 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8136
6da65536
PE
8137 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8138
7147c4a4
PE
8139 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8140
193e32d9
PE
8141 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8142
e5533da6
PE
8143 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8144
9910e595
PE
8145 GLYPH_CODE_FACE returns EMACS_INT, not int.
8146 * dispextern.h (merge_faces):
8147 * xfaces.c (merge_faces):
01103c44
PE
8148 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8149 Don't assume EMACS_INT fits in int.
9910e595 8150
2638320e
PE
8151 * character.h (CHAR_VALID_P): Remove unused parameter.
8152 * fontset.c, lisp.h, xdisp.c: All uses changed.
8153
045eb8d9
PE
8154 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8155
c1f134b5
PE
8156 * fns.c (concat): Minor tuning based on overflow analysis.
8157 This doesn't fix any bugs. Use int to hold character, instead
8158 of constantly refetching from Emacs object. Use XFASTINT, not
8159 XINT, for value known to be a character. Don't bother comparing
8160 a single byte to 0400, as it's always less.
8161
395fcb93 8162 * floatfns.c (Fexpt):
327eeec8
PE
8163 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8164
abbd3d23
PE
8165 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8166 for characters.
8167
684a03ef
PE
8168 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8169
0fed43f3
PE
8170 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8171 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8172 incorrectly succeed when S was a string, because 4294967386 was
8173 truncated before it was used.
8174
8fd02eb7
PE
8175 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8176 Otherwise, an out-of-range integer could cause undefined behavior
8177 on a 64-bit host.
8178
f8c86b69
PE
8179 * composite.c: Use int, not EMACS_INT, for characters.
8180 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8181 EMACS_INT, for values that are known to be in character range.
8182 This doesn't fix any bugs but is the usual style inside Emacs and
8183 may generate better code on 32-bit machines.
8184
34206dd2
PE
8185 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8186 This is for reasons similar to the recent CHAR_STRING fix.
8187 * charset.c (Fencode_char): Check that character arg is actually
8188 a character. Pass an int to ENCODE_CHAR.
8189 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8190 wider than 'int', as a compile-time check to prevent future regressions
8191 in this area.
8192
c5958d4c 8193 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8194
8195 Make sure a 64-bit char is never passed to CHAR_STRING.
8196 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8197 by silently ignoring the top 32 bits, allowing some values
8198 that were far too large to be valid characters.
8199 * character.h: Include <verify.h>.
8200 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8201 arguments are no wider than unsigned, as a compile-time check
8202 to prevent future regressions in this area.
8203 * data.c (Faset):
01103c44 8204 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8205 (Fsubst_char_in_region):
8206 * fns.c (concat):
8207 * xdisp.c (decode_mode_spec_coding):
8208 Adjust to CHAR_STRING's new requirement.
8209 * editfns.c (Finsert_char, Fsubst_char_in_region):
8210 * fns.c (concat): Check that character args are actually
8211 characters. Without this test, these functions did the wrong
8212 thing with wildly out-of-range values on 64-bit hosts.
8213
d37ca623
PE
8214 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8215 These casts should not be needed on 32-bit hosts, either.
8216 * keyboard.c (read_char):
8217 * lread.c (Fload): Remove casts to unsigned.
8218
ea204efb
PE
8219 * lisp.h (UNSIGNED_CMP): New macro.
8220 This fixes comparison bugs on 64-bit hosts.
8221 (ASCII_CHAR_P): Use it.
8222 * casefiddle.c (casify_object):
01103c44 8223 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8224 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8225 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8226 * dispextern.h (FACE_FROM_ID):
8227 * keyboard.c (read_char): Use UNSIGNED_CMP.
8228
41cb286c
PE
8229 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8230 not to EMACS_INT, to avoid GCC warning.
8231
4a1b9832
PE
8232 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8233
55daad71
PE
8234 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8235 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8236 isn't needed on 32-bit machines.
8f95c75c 8237
01103c44
PE
8238 * buffer.c (Fgenerate_new_buffer_name):
8239 Use EMACS_INT for count, not int.
0ceccced 8240 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8241
8242 * data.c (Qcompiled_function): Now static.
8243
c6f072e7
PE
8244 * window.c (window_body_lines): Now static.
8245
20ce5912
PE
8246 * image.c (gif_load): Rename local to avoid shadowing.
8247
9c4c5f81
PE
8248 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8249 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8250 * alloc.c (make_save_value): Integer argument is now of type
8251 ptrdiff_t, not int.
8252 (mark_object): Use ptrdiff_t, not int.
8253 * lisp.h (pD): New macro.
8254 * print.c (print_object): Use it.
8255
c0c5c8ae
PE
8256 * alloc.c: Use EMACS_INT, not int, to count objects.
8257 (total_conses, total_markers, total_symbols, total_vector_size)
8258 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8259 (total_free_floats, total_floats, total_free_intervals)
8260 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8261 Now EMACS_INT, not int. All uses changed.
8262 (Fgarbage_collect): Compute overall total using a double, so that
8263 integer overflow is less likely to be a problem. Check for overflow
8264 when converting back to an integer.
5a25e253
PE
8265 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8266 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8267 These were 'int' variables that could overflow on 64-bit hosts;
8268 they were never used, so remove them instead of repairing them.
211a0b2a 8269 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8270 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8271 Previously, this ceilinged at INT_MAX, but that doesn't work on
8272 64-bit machines.
e46bb31a 8273 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8274
c78baabf 8275 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8276 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8277 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8278 when a (possibly-narrower) signed value would do just as well.
8279 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8280
c9d624c6
PE
8281 * alloc.c: Catch some string size overflows that we were missing.
8282 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8283 for convenience in STRING_BYTES_MAX.
8284 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8285 The definition here is exact; the one in lisp.h was approximate.
8286 (allocate_string_data): Check for string overflow. This catches
8287 some instances we weren't catching before. Also, it catches
8288 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8289 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8290 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8291
c9d624c6
PE
8292 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8293 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8294 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8295
353032ce
PE
8296 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8297
2bccce07
PE
8298 * alloc.c (Fmake_string): Check for out-of-range init.
8299
0ac30604
SM
83002011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8301
8302 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8303
c195f2de
JD
83042011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8305
8306 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8307 xg_get_default_scrollbar_width.
8308
8309 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8310 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8311 (style_changed_cb): Call update_theme_scrollbar_width and call
8312 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8313 all frames (Bug#8505).
8314 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8315 Call gtk_window_set_resizable if HAVE_GTK3.
8316 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8317 and height if HAVE_GTK3 (Bug#8505).
8318 (scroll_bar_width_for_theme): New variable.
8319 (update_theme_scrollbar_width): New function.
8320 (xg_get_default_scrollbar_width): Move code to
8321 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8322 (xg_initialize): Call update_theme_scrollbar_width.
8323
8324 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8325
8326 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8327
e10ac9f1
MR
83282011-06-12 Martin Rudalics <rudalics@gmx.at>
8329
8330 * frame.c (make_frame): Call other_buffer_safely instead of
8331 other_buffer.
8332
8333 * window.c (temp_output_buffer_show): Call display_buffer with
8334 second argument Vtemp_buffer_show_specifiers and reset latter
8335 immediately after the call.
8336 (Vtemp_buffer_show_specifiers): New variable.
8337 (auto_window_vscroll_p, next_screen_context_lines)
8338 (Vscroll_preserve_screen_position): Remove leading asterisks from
8339 doc-strings.
8340
2d3c217e 83412011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8342
7b7f97e8 8343 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8344 * buffer.c (Qclone_number): Remove for now, as it's unused.
8345 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8346 (record_buffer): Remove unused local.
8347 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8348 (set_frame_buffer_list): Remove; unused.
8349 * frame.h (other_visible_frames): Remove decl.
8350 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8351 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8352 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8353 if HAVE_GPM.
8354 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8355 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8356 Define only if HAVE_GPM.
8357 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8358 (update_hints_inhibit): Remove; never set. All uses removed.
8359 * widgetprv.h (emacsFrameClassRec): Remove decl.
8360 * window.c (delete_deletable_window): Now returns void, since it
8361 wasn't returning anything.
8362 (compare_window_configurations): Remove unused locals.
8363 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8364 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8365 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8366 the same widths as pointers. This follows up on the 2011-05-06 patch.
8367 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8368 * xterm.h: Likewise.
8369 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8370
1384b89e
JB
83712011-06-12 Juanma Barranquero <lekktu@gmail.com>
8372
8373 * makefile.w32-in: Update dependencies.
8374 (LISP_H): Add lib/intprops.h.
8375
1100a63c
CY
83762011-06-11 Chong Yidong <cyd@stupidchicken.com>
8377
8378 * image.c (gif_load): Add animation frame delay to the metadata.
8379 (syms_of_image): Use DEFSYM. New symbol `delay'.
8380
6198ccd0
MR
83812011-06-11 Martin Rudalics <rudalics@gmx.at>
8382
8383 * window.c (delete_deletable_window): Re-add.
8384 (Fset_window_configuration): Rewrite to handle dead buffers and
8385 consequently deletable windows.
8386 (window_tree, Fwindow_tree): Remove. Supply functionality in
8387 window.el.
8388 (compare_window_configurations): Simplify code.
8389
b6e3633c
AS
83902011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8391
1ab0dee5
AS
8392 * image.c (imagemagick_load_image): Fix type mismatch.
8393 (Fimagemagick_types): Likewise.
8394
b6e3633c
AS
8395 * window.h (replace_buffer_in_windows): Declare.
8396
9397e56f
MR
83972011-06-11 Martin Rudalics <rudalics@gmx.at>
8398
8399 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8400 Qclone_number. Remove external declaration of Qdelete_window.
8401 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8402 code.
640c8776
SM
8403 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8404 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8405 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8406 buffer list implementation.
8407 (other_buffer_safely): New function.
8408 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8409 calls to replace_buffer_in_windows and
8410 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8411 if allowed.
8412 (record_buffer): Inhibit quitting and rewrite using quittable
8413 functions. Run Qbuffer_list_update_hook if allowed.
8414 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8415 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8416 Move switch-to-buffer to window.el.
9397e56f
MR
8417 (bury-buffer): Move to window.el.
8418 (Vbuffer_list_update_hook): New variable.
8419
8420 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8421 section.
8422
8423 * window.h (resize_frame_windows): Move up in code.
8424 (Fwindow_frame): Remove EXFUN.
8425 (replace_buffer_in_all_windows): Remove prototype.
8426 (replace_buffer_in_windows_safely): Add prototype.
8427
8428 * window.c: Declare Qdelete_window static again. Move down
8429 declaration of select_count.
8430 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8431 (Fother_window): Move to window.el.
8432 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8433 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8434 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8435 window.el.
8436 (replace_buffer_in_windows): Implement by calling
8437 Qreplace_buffer_in_windows.
8438 (replace_buffer_in_all_windows): Remove with some functionality
8439 moved into replace_buffer_in_windows_safely.
8440 (replace_buffer_in_windows_safely): New function.
8441 (select_window_norecord, select_frame_norecord): Move in front
8442 of run_window_configuration_change_hook. Remove now obsolete
8443 declarations.
640c8776
SM
8444 (Fset_window_buffer): Rewrite doc-string.
8445 Call Qrecord_window_buffer.
9397e56f
MR
8446 (keys_of_window): Move binding for other-window to window.el.
8447
b50691aa
CY
84482011-06-11 Chong Yidong <cyd@stupidchicken.com>
8449
8450 * dispextern.h (struct image): Replace data member, whose int_val
8451 and ptr_val fields were not used by anything, with a single
8452 lisp_val object.
8453
8454 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8455 (gif_clear_image, gif_load, imagemagick_load_image)
8456 (gs_clear_image, gs_load): Callers changed.
8457
3f754b86
PE
84582011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8459
cca69397
PE
8460 * buffer.h: Include <time.h>, for time_t.
8461 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8462
109e28d0
PE
8463 Fix minor problems found by static checking.
8464
60737f02
PE
8465 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8466
4b66faf3
PE
8467 Make identifiers static if they are not used in other modules.
8468 * data.c (Qcompiled_function, Qframe, Qvector):
8469 * image.c (QimageMagick, Qsvg):
8470 * minibuf.c (Qmetadata):
8471 * window.c (resize_window_check, resize_root_window): Now static.
8472 * window.h (resize_window_check, resize_root_window): Remove decls.
8473
109e28d0
PE
8474 * window.c (window_deletion_count, delete_deletable_window):
8475 Remove; unused.
46a4ce9e
PE
8476 (window_body_lines): Now static.
8477 (Fdelete_other_windows_internal): Mark vars as initialized.
8478 Make sure 'resize_failed' is initialized.
8479 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8480 (resize_window_apply): Remove unused local.
8481 * window.h (delete_deletable_window): Remove decl.
8482
109e28d0 8483 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8484 (imagemagick_load_image): Fix pointer signedness problem by changing
8485 last arg from unsigned char * to char *. All uses changed.
8486 Also, fix a local for similar reasons.
8487 Remove unused locals. Remove locals to avoid shadowing.
8488 (fn_rsvg_handle_free): Remove; unused.
8489 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8490 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8491
3f754b86
PE
8492 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8493
2547adb1
CY
84942011-06-10 Chong Yidong <cyd@stupidchicken.com>
8495
8496 * image.c (gif_load): Fix omitted cast error introduced by
8497 2011-06-06 change.
8498
2c8e37d4
MR
84992011-06-10 Martin Rudalics <rudalics@gmx.at>
8500
8501 * window.h (resize_proportionally, orig_total_lines)
8502 (orig_top_line): Remove from window structure.
8503 (set_window_height, set_window_width, change_window_heights)
8504 (Fdelete_window): Remove prototypes.
8505 (resize_frame_windows): Remove duplicate declaration.
8506
440a42e3
EZ
85072011-06-10 Eli Zaretskii <eliz@gnu.org>
8508
8509 * window.h (resize_frame_windows, resize_window_check)
8510 (delete_deletable_window, resize_root_window)
8511 (resize_frame_windows): Declare prototypes.
8512
8513 * window.c (resize_window_apply): Make definition be "static" to
8514 match the prototype.
8515
562dd5e9
MR
85162011-06-10 Martin Rudalics <rudalics@gmx.at>
8517
8518 * window.c: Remove declarations of Qwindow_size_fixed,
8519 window_min_size_1, window_min_size_2, window_min_size,
8520 size_window, window_fixed_size_p, enlarge_window, delete_window.
8521 Remove static from declaration of Qdelete_window, it's
8522 temporarily needed by Fbury_buffer.
8523 (replace_window): Don't assign orig_top_line and
8524 orig_total_lines.
8525 (Fdelete_window, delete_window): Remove. Window deletion is
8526 handled by window.el.
640c8776
SM
8527 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8528 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8529 (Fdelete_other_windows): Remove. Deleting other windows is
8530 handled by window.el.
8531 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8532 handled in window.el.
8533 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8534 Window minimum sizes are handled in window.el.
8535 (shrink_windows, size_window, set_window_height)
8536 (set_window_width, change_window_heights, window_height)
8537 (window_width, CURBEG, CURSIZE, enlarge_window)
8538 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8539 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8540 handled in window.el.
8541 (make_dummy_parent): Rename to make_parent_window and give it a
8542 second argument horflag.
8543 (make_window): Don't set resize_proportionally any more.
8544 (Fsplit_window): Remove. Windows are split in window.el.
8545 (save_restore_action, save_restore_orig_size)
8546 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8547 Resize mini windows in window.el.
8548 (grow_mini_window, shrink_mini_window): Implement by calling
8549 Qresize_root_window_vertically, resize_window_check and
8550 resize_window_apply.
640c8776
SM
8551 (saved_window, Fset_window_configuration, save_window_save):
8552 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8553 resize_proportionally.
8554 (window_min_height, window_min_width): Move to window.el.
8555 (keys_of_window): Move bindings for delete-other-windows,
8556 split-window, delete-window and enlarge-window to window.el.
8557
8558 * buffer.c: Temporarily extern Qdelete_window.
8559 (Fbury_buffer): Temporarily call Qdelete_window instead of
8560 Fdelete_window (Fbury_buffer will move to window.el soon).
8561
8562 * frame.c (set_menu_bar_lines_1): Remove code handling
8563 orig_top_line and orig_total_lines.
8564
8565 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8566 set_window_height but set heights directly.
8567 (change_frame_size_1): Use resize_frame_windows.
8568
8569 * xdisp.c (init_xdisp): Don't use set_window_height but set
8570 heights directly.
8571
640c8776
SM
8572 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8573 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8574 run_window_configuration_change_hook.
8575
8576 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8577 instead of change_window_heights and run
8578 run_window_configuration_change_hook.
8579
1a13852e
MR
85802011-06-09 Martin Rudalics <rudalics@gmx.at>
8581
8582 * window.c (replace_window): Rename second argument REPLACEMENT to
8583 NEW. New third argument SETFLAG. Rewrite.
8584 (delete_window, make_dummy_parent): Call replace_window with
8585 third argument 1.
8586 (window_list_1): Move down in code.
8587 (run_window_configuration_change_hook): Move set_buffer part
8588 before select_frame_norecord part in order to unwind correctly.
8589 Rename count1 to count.
8590 (recombine_windows, delete_deletable_window, resize_root_window)
8591 (Fdelete_other_windows_internal)
8592 (Frun_window_configuration_change_hook, make_parent_window)
8593 (resize_window_check, resize_window_apply, Fresize_window_apply)
8594 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8595 (Fdelete_window_internal, Fresize_mini_window_internal):
8596 New functions.
1a13852e
MR
8597 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8598
f3d1777e
MR
85992011-06-08 Martin Rudalics <rudalics@gmx.at>
8600
496e208e
MR
8601 * window.h (window): Add some new members to window structure -
8602 normal_lines, normal_cols, new_total, new_normal, clone_number,
8603 splits, nest, prev_buffers, next_buffers.
8604 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8605 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8606
f3d1777e
MR
8607 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8608 Remove.
496e208e
MR
8609 (make_dummy_parent): Set new members of windows structure.
8610 (make_window): Move down in code. Handle new members of window
8611 structure.
8612 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8613 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8614 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8615 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8616 (Fset_window_next_buffers, Fset_window_clone_number):
8617 New functions.
496e208e
MR
8618 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8619 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8620 Doc-string fixes.
8621 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8622 Argument WINDOW can be now internal window too.
8623 (Fwindow_use_time): Move up in code.
8624 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8625 Rewrite doc-string.
8626 (Fset_window_configuration, saved_window)
8627 (Fcurrent_window_configuration, save_window_save): Handle new
8628 members of window structure.
b9e809c2
MR
8629 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8630 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8631 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8632 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8633 Qget_mru_window, Qresize_root_window,
8634 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8635 Qauto_buffer_name; staticpro them.
f3d1777e 8636
abde8f8c
MR
86372011-06-07 Martin Rudalics <rudalics@gmx.at>
8638
8639 * window.c (Fwindow_total_size, Fwindow_left_column)
8640 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8641 (Fwindow_list_1): New functions.
8642 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8643 (Fwindow_width, Fscroll_left, Fscroll_right):
8644 Use window_body_cols instead of window_box_text_cols.
8645 (delete_window, Fset_window_configuration):
8646 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8647 (delete_all_subwindows): Take a window as argument and not a
8648 structure. Rewrite.
190b47e6
MR
8649 (window_loop): Remove handling of GET_LRU_WINDOW and
8650 GET_LARGEST_WINDOW.
8651 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8652
8653 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8654 window_box_text_cols. delete_all_subwindows now takes a
8655 Lisp_Object as argument.
abde8f8c 8656
640c8776
SM
8657 * indent.c (compute_motion, Fcompute_motion):
8658 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8659
fa8a67e6
MR
8660 * frame.c (delete_frame): Call delete_all_subwindows with root
8661 window as argument.
8662
a54e3482
DC
86632011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8664
8665 * fns.c (Fputhash): Document return value.
8666
60002bf5
CY
86672011-06-06 Chong Yidong <cyd@stupidchicken.com>
8668
8669 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8670
0c671da6 86712011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8672
b862a52a 8673 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8674
be44ca6c
PE
8675 Check for overflow when converting integer to cons and back.
8676 * charset.c (Fdefine_charset_internal, Fdecode_char):
8677 Use cons_to_unsigned to catch overflow.
8678 (Fencode_char): Use INTEGER_TO_CONS.
8679 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8680 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8681 * data.c (long_to_cons, cons_to_long): Remove.
8682 (cons_to_unsigned, cons_to_signed): New functions.
8683 These signal an error for invalid or out-of-range values.
8684 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8685 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8686 * font.c (Ffont_variation_glyphs):
8687 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8688 * lisp.h: Include <intprops.h>.
8689 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8690 (cons_to_signed, cons_to_unsigned): New decls.
8691 (long_to_cons, cons_to_long): Remove decls.
8692 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8693 (Fprimitive_undo): Use CONS_TO_INTEGER.
8694 * xfns.c (Fx_window_property): Likewise.
8695 * xselect.c: Include <limits.h>.
8696 (x_own_selection, selection_data_to_lisp_data):
8697 Use INTEGER_TO_CONS.
8698 (x_handle_selection_request, x_handle_selection_clear)
8699 (x_get_foreign_selection, Fx_disown_selection_internal)
8700 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8701 (lisp_data_to_selection_data): Use cons_to_unsigned.
8702 (x_fill_property_data): Use cons_to_signed.
8703 Report values out of range.
8704
d1f3d2af
PE
8705 Check for buffer and string overflow more precisely.
8706 * buffer.h (BUF_BYTES_MAX): New macro.
8707 * lisp.h (STRING_BYTES_MAX): New macro.
8708 * alloc.c (Fmake_string):
8709 * character.c (string_escape_byte8):
8710 * coding.c (coding_alloc_by_realloc):
8711 * doprnt.c (doprnt):
8712 * editfns.c (Fformat):
8713 * eval.c (verror):
8714 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8715 since they may not be the same number.
8716 * editfns.c (Finsert_char):
8717 * fileio.c (Finsert_file_contents):
8718 Likewise for BUF_BYTES_MAX.
8719
dd52fcea
PE
8720 * image.c: Use ptrdiff_t, not int, for sizes.
8721 (slurp_file): Switch from int to ptrdiff_t.
8722 All uses changed.
8723 (slurp_file): Check that file size fits in both size_t (for
8724 malloc) and ptrdiff_t (for sanity and safety).
8725
7f9bbdbb
PE
8726 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8727 if b->modtime has its maximal value.
8728
dfe18f82
PE
8729 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8730
84acfcf0
PE
8731 Don't assume time_t can fit into int.
8732 * buffer.h (struct buffer.modtime): Now time_t, not int.
8733 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8734 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8735
ccd9a01a
PE
8736 Minor fixes for signed vs unsigned integers.
8737 * character.h (MAYBE_UNIFY_CHAR):
8738 * charset.c (maybe_unify_char):
8739 * keyboard.c (read_char, reorder_modifiers):
8740 XINT -> XFASTINT, since the integer must be nonnegative.
8741 * ftfont.c (ftfont_spec_pattern):
8742 * keymap.c (access_keymap, silly_event_symbol_error):
8743 XUINT -> XFASTINT, since the integer must be nonnegative.
8744 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8745 since it makes no difference and we prefer signed.
8746 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8747 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8748 nonnegative.
8749
d6d100dd
SM
87502011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8751
8752 * window.h (Fwindow_frame): Declare.
8753
2b6148e4
PE
87542011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8755
8756 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8757 (SPARE_MEMORY): Always define.
8758 (LARGE_REQUEST): Remove.
8759 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8760
f230ecc9
MR
87612011-06-06 Martin Rudalics <rudalics@gmx.at>
8762
727e958e
MR
8763 * lisp.h: Move EXFUNS for Fframe_root_window,
8764 Fframe_first_window and Fset_frame_selected_window to window.h.
8765
8766 * window.h: Move EXFUNS for Fframe_root_window,
8767 Fframe_first_window and Fset_frame_selected_window here from
8768 lisp.h.
8769
8770 * frame.c (Fwindow_frame, Fframe_first_window)
8771 (Fframe_root_window, Fframe_selected_window)
8772 (Fset_frame_selected_window): Move to window.c.
8773 (Factive_minibuffer_window): Move to minibuf.c.
8774 (Fother_visible_frames_p): New function.
8775
8776 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8777
f230ecc9
MR
8778 * window.c (decode_window, decode_any_window): Move up in code.
8779 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8780 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8781 (Fwindow_buffer): Move up and rewrite doc-string.
8782 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8783 (Fwindow_prev): New functions.
727e958e
MR
8784 (Fwindow_frame): Move here from frame.c. Accept any window as
8785 argument.
8786 (Fframe_root_window, Fframe_first_window)
8787 (Fframe_selected_window): Move here from frame.c. Accept frame
8788 or arbitrary window as argument. Update doc-strings.
8789 (Fminibuffer_window): Move up in code.
8790 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8791 (Fset_frame_selected_window): Move here from frame.c.
8792 Marginal rewrite.
727e958e
MR
8793 (Fselected_window, select_window, Fselect_window): Move up in
8794 code. Minor doc-string fixes.
f230ecc9 8795
4d09bcf6
PE
87962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8797
8798 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8799 Do not assume that spare memory exists; that assumption is valid
8800 only if SYSTEM_MALLOC.
8801 (LARGE_REQUEST): New macro, so that the issue of large requests
8802 is separated from the issue of spare memory.
8803
810928a2
AS
88042011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8805
172418ad
AS
8806 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8807 format. (Bug#8806)
8808
43f862f7
AS
8809 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8810
810928a2
AS
8811 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8812 before statements.
8813
a059fe24
JD
88142011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8815
8816 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8817
8818 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8819
8820 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8821 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8822
989bf368
JB
88232011-06-05 Juanma Barranquero <lekktu@gmail.com>
8824
8825 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8826
4b80f674
CY
88272011-06-04 Chong Yidong <cyd@stupidchicken.com>
8828
8829 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8830 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8831 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8832 New error handlers.
4b80f674
CY
8833 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8834 Obey Vx_select_enable_clipboard_manager. Catch errors in
8835 x_clipboard_manager_save (Bug#8779).
8836 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8837 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8838
99a33b77 88392011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8840
8841 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8842
99a33b77 88432011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8844
8845 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8846 in the current matrix if keep_current_p is non-zero.
8847
8264569d
EZ
88482011-06-04 Eli Zaretskii <eliz@gnu.org>
8849
8850 * bidi.c (bidi_level_of_next_char): Fix last change.
8851
57f97249
EZ
88522011-06-03 Eli Zaretskii <eliz@gnu.org>
8853
fec2107c 8854 Support bidi reordering of text covered by display properties.
57f97249 8855
fec2107c
EZ
8856 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8857 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8858 (bidi_cache_search, bidi_cache_iterator_state)
8859 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8860 (bidi_level_of_next_char, bidi_move_to_visually_next):
8861 Support character positions inside a run of characters covered by a
fec2107c
EZ
8862 display string.
8863 (bidi_paragraph_init, bidi_resolve_explicit_1)
8864 (bidi_level_of_next_char): Call bidi_fetch_char and
8865 bidi_fetch_char_advance instead of FETCH_CHAR and
8866 FETCH_CHAR_ADVANCE.
8867 (bidi_init_it): Initialize new members.
8868 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8869 definitions.
8870 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8871 instead of using explicit *_CHAR codes.
d6d100dd
SM
8872 (bidi_resolve_explicit, bidi_resolve_weak):
8873 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8874 bidirectional text is supported only in multibyte buffers.
8875 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8876 it to initialize the frame_window_p member of struct bidi_it.
8877 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8878 (bidi_resolve_explicit, bidi_resolve_weak)
8879 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8880 bidi_it->nchars is non-positive.
8881 (bidi_level_of_next_char): Don't try to lookup the cache for the
8882 next/previous character if nothing is cached there yet, or if we
8883 were just reseat()'ed to a new position.
c40e2fb2 8884
0e14fe90
EZ
8885 * xdisp.c (set_cursor_from_row): Set start and stop points
8886 according to the row's direction when priming the loop that looks
8887 for the glyph on which to display cursor.
8888 (single_display_spec_intangible_p): Function deleted.
8889 (display_prop_intangible_p): Reimplement to call
8890 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8891 Accept 3 additional arguments needed by handle_display_spec.
8892 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8893 values: lists, `(when COND...)' forms, etc.
8894 (single_display_spec_string_p): Support property values that are
8895 lists with the argument STRING its top-level element.
8896 (display_prop_string_p): Fix the condition for processing a
8897 property that is a list to be consistent with handle_display_spec.
fec2107c 8898 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8899 last portion of handle_display_prop.
8900 (compute_display_string_pos): Accept additional argument
8901 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8902 value of a `display' property is a "replacing spec".
8903 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8904 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8905 the display property, but just return a value indicating whether
8906 the display property will replace the characters it covers.
8907 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8908 frame_window_p members of struct bidi_it.
d6d100dd
SM
8909 (compute_display_string_pos, compute_display_string_end):
8910 New functions.
fec2107c
EZ
8911 (push_it): Accept second argument POSITION, where pop_it should
8912 jump to continue iteration.
8913 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8914
fec2107c
EZ
8915 * keyboard.c (adjust_point_for_property): Adjust the call to
8916 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8917
8918 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8919 (bidi_init_it): Update prototypes.
8920 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8921 (compute_display_string_pos, compute_display_string_end):
8922 Declare prototypes.
fec2107c
EZ
8923 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8924 EMACS_INT.
fc6f18ce 8925
40087514 89262011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8927
57f53182
PE
8928 Malloc failure behavior now depends on size of allocation.
8929 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8930 * lisp.h: Change signatures accordingly.
8931 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8932 All callers changed. (Bug#8762)
8933
8934 * gnutls.c: Use Emacs's memory allocators.
8935 Without this change, the gnutls library would invoke malloc etc.
8936 directly, which causes problems on non-SYNC_INPUT hosts, and which
8937 runs afoul of improving memory_full behavior. (Bug#8761)
8938 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8939 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8940 xfree instead of the default malloc, realloc, free.
8941 (Fgnutls_boot): No need to check for memory allocation failure,
8942 since xmalloc does that for us.
8943
ac32cd99 8944 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8945 * category.c (hash_get_category_set):
8946 * ccl.c (ccl_driver):
8947 * charset.c (Fdefine_charset_internal):
8948 * charset.h (struct charset.hash_index):
8949 * composite.c (get_composition_id, gstring_lookup_cache)
8950 (composition_gstring_put_cache):
8951 * composite.h (struct composition.hash_index):
8952 * dispextern.h (struct image.hash):
8953 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8954 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8955 (hashfn_equal, hashfn_user_defined, make_hash_table)
8956 (maybe_resize_hash_table, hash_lookup, hash_put)
8957 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8958 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8959 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8960 * image.c (make_image, search_image_cache, lookup_image)
8961 (xpm_put_color_table_h):
8962 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8963 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8964 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8965 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8966 * alloc.c (allocate_vectorlike):
8967 Check for overflow in vector size calculations.
8968 * ccl.c (ccl_driver):
8969 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8970 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8971 need to be updated by these changes.
40087514
PE
8972 * fns.c (make_hash_table, maybe_resize_hash_table):
8973 Check for integer overflow with large hash tables.
0de4bb68
PE
8974 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8975 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8976 (SXHASH_REDUCE): New macro.
8977 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8978 Use it instead of discarding useful hash info with large hash values.
8979 (sxhash_float): New function.
8980 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8981 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8982 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8983 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8984 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8985 Adjust signatures to match updated version of code.
8986 (consing_since_gc): Now EMACS_INT, since a single hash table can
8987 use more than INT_MAX bytes.
8988
698d32e2
DN
89892011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8990
8991 Make it possible to build with GCC-4.6+ -O2 -flto.
8992
8993 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8994
fd6fa53f
SM
89952011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8996
8997 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8998 Call minibuffer-inactive-mode.
8999
864db017
JB
90002011-05-31 Juanma Barranquero <lekktu@gmail.com>
9001
9002 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9003 Update dependencies.
9004
2ad0baf4
DN
90052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9006
9007 * data.c (init_data): Remove code for UTS, this system is not
9008 supported anymore.
9009
4fcc2638
DN
90102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9011
9012 Don't force ./temacs to start in terminal mode.
9013
9014 * frame.c (make_initial_frame): Initialize faces in all cases, not
9015 only when CANNOT_DUMP is defined.
9016 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9017
c56e0fd5
DN
90182011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9019
9020 * dispnew.c (add_window_display_history): Use const for the string
9021 pointer. Remove declaration, not needed.
9022
333d54da 90232011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9024
55d4c1b2 9025 Use 'inline', not 'INLINE'.
333d54da 9026 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9027 * alloc.c, fontset.c (INLINE): Remove.
9028 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9029 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9030 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9031 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9032 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9033
738db178
DN
90342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9035
9036 Make it possible to run ./temacs.
9037
9038 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9039 syms_of_callproc does the same thing. Remove test for
9040 "initialized", do it in the caller.
9041 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9042
620c53a6
SM
90432011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9044
9045 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9046 (read_minibuf): Use get_minibuffer.
9047 (syms_of_minibuf): Use DEFSYM.
9048 (Qmetadata): New var.
9049 * data.c (Qbuffer): Don't make it static.
9050 (syms_of_data): Use DEFSYM.
9051
e003a292
PE
90522011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9053
9054 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9055 (CCL_CODE_MIN): New macro.
9056
ed008a6d
PE
90572011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9058
3687c2ef
PE
9059 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9060
ed008a6d
PE
9061 * eval.c (Qdebug): Now static.
9062 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9063 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9064 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9065
d66c4c7c
CY
90662011-05-29 Chong Yidong <cyd@stupidchicken.com>
9067
9068 * image.c: Various fixes to ImageMagick code comments.
9069 (Fimagemagick_types): Doc fix.
9070
5fbc2025
PE
90712011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9072
0196f88a
PE
9073 Minor fixes prompted by GCC 4.6.0 warnings.
9074
9075 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9076
5fbc2025
PE
9077 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9078 (x_clipboard_manager_save_all): Move extern decl to ...
9079 * xterm.h: ... here, so that it can be checked for consistency.
9080
1dd3c2d9
CY
90812011-05-29 Chong Yidong <cyd@stupidchicken.com>
9082
9083 * xselect.c (x_clipboard_manager_save_frame)
9084 (x_clipboard_manager_save_all): New functions.
9085 (Fx_clipboard_manager_save): Lisp function deleted.
9086
9087 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9088 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9089
9090 * xterm.h: Update prototype.
9091
5ba6571d
WX
90922011-05-28 William Xu <william.xwl@gmail.com>
9093
9094 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9095 exiting (Bug#8239).
9096
3eaff834
JM
90972011-05-28 Jim Meyering <meyering@redhat.com>
9098
e1900994 9099 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9100 * fns.c (to_uchar): Define.
9101 (crypto_hash_function): Use it to convert some newly-signed
9102 variables to unsigned, to avoid sign-extension bugs. For example,
9103 without this change, (md5 "truc") would evaluate to
9104 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9105 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9106 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9107
0f6990a7
PE
91082011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9109
9110 Integer overflow fixes.
c8a9ca5a 9111
08686060
PE
9112 * dbusbind.c: Serial number integer overflow fixes.
9113 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9114 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9115 to hold a serial number that is too large for a fixnum.
9116 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9117 Check for serial numbers out of range. Decode any serial number
59568bf0 9118 that was so large that it became a float. (Bug#8722)
08686060 9119
2d1fc3c7
PE
9120 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9121 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9122 Use XFASTINT rather than XUINT when numbers are nonnegative.
9123 (xd_append_arg, Fdbus_method_return_internal):
9124 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9125 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9126 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9127 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9128 (Bug#8722)
2d1fc3c7 9129
c8a9ca5a
PE
9130 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9131
519e1d69
PE
9132 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9133
6df6ae42 9134 ccl: Add integer overflow checks.
30569699
PE
9135 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9136 (IN_INT_RANGE): New macros.
9137 (ccl_driver): Use them to check for integer overflow when
9138 decoding a CCL program. Many of the new checks are whether XINT (x)
9139 fits in int; it doesn't always, on 64-bit hosts. The new version
9140 doesn't catch all possible integer overflows, but it's an
847044ea 9141 improvement. (Bug#8719)
30569699 9142
c11285dc
PE
9143 * alloc.c (make_event_array): Use XINT, not XUINT.
9144 There's no need for unsigned here.
9145
fdccd48e
PE
9146 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9147 This follows up to the 2011-05-06 change that substituted uintptr_t
9148 for EMACS_INT. This case wasn't caught back then.
9149
37910ab2
PE
9150 Rework Fformat to avoid integer overflow issues.
9151 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9152 now (part of C89). Include <verify.h>.
9153 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9154 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9155 (Fformat): Avoid the prepass trying to compute sizes; it was only
9156 approximate and thus did not catch overflow reliably. Instead, walk
9157 through the format just once, formatting and computing sizes as we go,
9158 checking for integer overflow at every step, and allocating a larger
9159 buffer as needed. Keep track separately whether the format is
9160 multibyte. Keep only the most-recently calculated precision, rather
9161 than them all. Record whether each argument has been converted to
9162 string. Use EMACS_INT, not int, for byte and char and arg counts.
9163 Support field widths and precisions larger than INT_MAX. Avoid
9164 sprintf's undefined behavior with conversion specifications such as %#d
9165 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9166 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9167 formatting out-of-range floating point numbers with int
9173deec 9168 formats. (Bug#8668)
37910ab2 9169
2e6578fb
PE
9170 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9171
0ae6bdee
PE
9172 * data.c: Avoid integer truncation in expressions involving floats.
9173 * data.c: Include <intprops.h>.
9174 (arith_driver): When there's an integer overflow in an expression
9175 involving floating point, convert the integers to floating point
9176 so that the resulting value does not suffer from catastrophic
9177 integer truncation. For example, on a 64-bit host (* 4
9178 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9179 Do not rely on undefined behavior after integer overflow.
9180
de883a70
PE
9181 merge count_size_as_multibyte, parse_str_to_multibyte
9182 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9183 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9184 Check for integer overflow.
9185 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9186 since it's now a duplicate of the other. This is more of
9187 a character than a buffer op, so better that it's in character.c.
9188 * fns.c, print.c: Adjust to above changes.
9189
2ff916cb
PE
91902011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9191
9192 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9193
f1b54466
PE
91942011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9195
fb1ac845
PE
9196 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9197 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9198 (x_clipboard_manager_save): Now static.
9199 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9200
f1b54466
PE
9201 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9202 (crypto_hash_function): Now static.
9203 Fix pointer signedness problems. Avoid unnecessary initializations.
9204
a9f737ee
CY
92052011-05-27 Chong Yidong <cyd@stupidchicken.com>
9206
9207 * termhooks.h (Vselection_alist): Make it terminal-local.
9208
9209 * terminal.c (create_terminal): Initialize it.
9210
9211 * xselect.c: Support for clipboard managers.
9212 (Vselection_alist): Move to termhooks.h as terminal-local var.
9213 (LOCAL_SELECTION): New macro.
9214 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9215 (symbol_to_x_atom): Remove gratuitous arg.
9216 (x_handle_selection_request, lisp_data_to_selection_data)
9217 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9218 (x_own_selection, x_get_local_selection, x_convert_selection):
9219 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9220 (some_frame_on_display): Delete unused function.
9221 (Fx_own_selection_internal, Fx_get_selection_internal)
9222 (Fx_disown_selection_internal, Fx_selection_owner_p)
9223 (Fx_selection_exists_p): New optional frame arg.
9224 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9225 (x_handle_selection_clear): Don't treat other terminals with the
9226 same keyboard specially. Use the terminal-local Vselection_alist.
9227 (x_clear_frame_selections): Use Frun_hook_with_args.
9228
9229 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9230
9231 * xterm.h: Add support for those atoms.
9232
e067f0c1
CY
92332011-05-26 Chong Yidong <cyd@stupidchicken.com>
9234
9235 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9236 (converted_selections, conversion_fail_tag): New global variables.
9237 (x_selection_request_lisp_error): Free the above.
9238 (x_get_local_selection): Remove unnecessary code.
9239 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9240 of converted selections stored in converted_selections.
9241 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9242 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9243 (x_convert_selection): New function.
9244 (x_handle_selection_event): Simplify.
9245 (x_get_foreign_selection): Don't ignore incoming requests while
9246 waiting for an answer; this will fail when we implement
9247 SAVE_TARGETS, and seems unnecessary anyway.
9248 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9249 (Vx_sent_selection_functions): Doc fix.
9250
0f4aebc0
LL
92512011-05-26 Leo Liu <sdl.web@gmail.com>
9252
9253 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9254
e61124cd
YM
92552011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9256
9257 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9258
9259 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9260 for fringe update if it has periodic bitmap.
ac389d0c 9261 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9262 and fringe_bitmap_periodic_p.
9263
9264 * fringe.c (get_fringe_bitmap_data): New function.
9265 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9266 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9267 row. Mark glyph row for fringe update if periodicity changed.
9268
9269 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9270 for fringe update unless it has periodic bitmap.
9271
f16d9837
KH
92722011-05-25 Kenichi Handa <handa@m17n.org>
9273
9274 * xdisp.c (get_next_display_element): Set correct it->face_id for
9275 a static composition.
9276
e1b90ef6
LL
92772011-05-24 Leo Liu <sdl.web@gmail.com>
9278
9279 * deps.mk (fns.o):
9280 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9281
9282 * fns.c (crypto_hash_function, Fsha1): New function.
9283 (Fmd5): Use crypto_hash_function.
9284 (syms_of_fns): Add Ssha1.
9285
7400048f
PE
92862011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9287
9288 * gnutls.c: Remove unused macros.
9289 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9290 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9291 Remove macros that are defined and never used.
9292 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9293
abb71cf4
CY
92942011-05-22 Chong Yidong <cyd@stupidchicken.com>
9295
9296 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9297 (Fx_get_selection_internal): Minor cleanup.
9298 (Fx_own_selection_internal): Rename arguments for consistency with
9299 select.el.
9300
6307db39
PE
93012011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9302
9303 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9304
f3d4e0a4
CY
93052011-05-22 Chong Yidong <cyd@stupidchicken.com>
9306
9307 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9308
4d8ade89
YM
93092011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9310
9311 * dispnew.c (scrolling_window): Don't exclude the case that the
9312 last enabled row in the desired matrix touches the bottom boundary.
9313
32078c8d
GM
93142011-05-21 Glenn Morris <rgm@gnu.org>
9315
9316 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9317 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9318 and add some more files.
32078c8d 9319
7285dc67
EZ
93202011-05-20 Eli Zaretskii <eliz@gnu.org>
9321
9322 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9323 report_file_error introduced by the change from 2011-05-07.
9324
89d1bd22
PE
93252011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9326
9327 * systime.h (Time): Define only if emacs is defined.
9328 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9329 where the include path doesn't have X11/X.h by default. See
9330 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9331
cd394be1 93322011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9333
9334 * composite.c (find_automatic_composition): Fix previous change.
9335
b9704ad9
GM
93362011-05-20 Glenn Morris <rgm@gnu.org>
9337
9338 * lisp.mk: New file, split from Makefile.in.
9339 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9340 (shortlisp): Remove.
9341 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9342
4a720484
GM
93432011-05-19 Glenn Morris <rgm@gnu.org>
9344
9345 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9346 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9347 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9348 (lisp): Set the order to that of loadup.el.
9349 (shortlisp): Make it a copy of $lisp.
9350 (SOME_MACHINE_LISP): Remove.
9351 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9352 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9353
a28d4396
KH
93542011-05-18 Kenichi Handa <handa@m17n.org>
9355
9356 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9357 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9358 (find_automatic_composition): Mostly rewrite for efficiency.
9359
a2b1fa8e
JB
93602011-05-18 Juanma Barranquero <lekktu@gmail.com>
9361
9362 * makefile.w32-in: Update dependencies.
9363
8e1f5610
CS
93642011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9365
9366 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9367 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9368
7025ee00 93692011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9370
cdfa6eab
PE
9371 Fix some integer overflow issues, such as string length overflow.
9372
06d6db33
PE
9373 * insdel.c (count_size_as_multibyte): Check for string overflow.
9374
2b4560a8
PE
9375 * character.c (lisp_string_width): Check for string overflow.
9376 Use EMACS_INT, not int, for string indexes and lengths; in
9377 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9378 the resulting string length overflows an EMACS_INT; instead,
9379 report a string overflow if no precision given. When checking for
9380 precision exhaustion, use a check that cannot possibly have
9381 integer overflow. (Bug#8675)
9382 * character.h (lisp_string_width): Adjust to new signature.
9383
cb93f9be
PE
9384 * alloc.c (string_overflow): New function.
9385 (Fmake_string): Use it. This doesn't change behavior, but saves
9386 a few bytes and will simplify future changes.
9387 * character.c (string_escape_byte8): Likewise.
9388 * lisp.h (string_overflow): New decl.
9389
1a1f3366
PE
9390 Fixups, following up to the user-interface timestamp change.
9391 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9392 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9393 * msdos.c (mouse_get_pos): Likewise.
9394 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9395 * w32gui.h (Time): Define by including "systime.h" rather than by
9396 declaring it ourselves. (Bug#8664)
9397
d4e3e4d3
PE
9398 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9399 * image.c (clear_image_cache): Likewise.
9400
f6a24d19
PE
9401 * term.c (term_mouse_position): Don't assume time_t wraparound.
9402
08dc5ae6
PE
9403 Be more systematic about user-interface timestamps.
9404 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9405 and sometimes 'EMACS_UINT', to represent these timestamps.
9406 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9407 This makes the code easier to follow, and makes it easier to catch
9408 integer overflow bugs such as Bug#8664.
9409 * frame.c (Fmouse_position, Fmouse_pixel_position):
9410 Use Time, not unsigned long, for user-interface timestamps.
9411 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9412 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9413 * keyboard.h (last_event_timestamp): Likewise.
9414 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9415 * menu.h (xmenu_show): Likewise.
9416 * term.c (term_mouse_position): Likewise.
9417 * termhooks.h (struct input_event.timestamp): Likewise.
9418 (struct terminal.mouse_position_hook): Likewise.
9419 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9420 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9421 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9422 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9423 what it was before.
9424 * menu.h, termhooks.h: Include "systime.h", for Time.
9425
8e55734a
PE
9426 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9427 Don't assume that the difference between two unsigned long values
9428 can fit into an integer. At this point, we know button_down_time
9429 <= event->timestamp, so the difference must be nonnegative, so
9430 there's no need to cast the result if double-click-time is
9431 nonnegative, as it should be; check that it's nonnegative, just in
9432 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9433 apart (about 25 days). (Bug#8664)
8e55734a 9434
841f1b75 9435 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9436 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9437
3e26f69c
PE
9438 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9439 that always fit in int. Use a sentinel instead of a counter, to
9440 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9441 * frame.h (struct frame): Use int for menu_bar_items_used
9442 instead of EMACS_INT, since it always fits in int.
3e26f69c 9443
5cc152c0
PE
9444 * menu.c (grow_menu_items): Check for int overflow.
9445
d89eb65e
PE
9446 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9447
5235bd3e
PE
9448 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9449 Before, the code was not consistent. These values cannot exceed
9450 2**31 - 1 so there's no need to make them unsigned.
9451 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9452 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9453 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9454 as modifiers.
9455 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9456
bc827e23
PE
9457 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9458 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9459 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9460 presumably because the widths might not match.
9461
78eb494e
PE
9462 * window.c (size_window): Avoid needless test at loop start.
9463
04f2d78b
CB
94642011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9465
9466 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9467
d2fc7e3d 94682011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9469
9470 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9471
d2fc7e3d 94722011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9473
9474 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9475 `width' to `bar_area_x' and `bar_area_width', respectively.
9476 (x_scroll_run): Take account of fringe background extension.
9477
04f2d78b
CB
9478 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9479 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9480 `bar_area_width', respectively.
9481 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9482 background extension.
9483
79b70037
GM
94842011-05-10 Jim Meyering <meyering@redhat.com>
9485
9486 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9487
2f142cc5
JB
94882011-05-10 Juanma Barranquero <lekktu@gmail.com>
9489
9490 * image.c (Finit_image_library): Return t for built-in image types,
9491 like pbm and xbm. (Bug#8640)
9492
57679c86
AS
94932011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9494
9495 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9496
888c9e86
EZ
94972011-05-07 Eli Zaretskii <eliz@gnu.org>
9498
b0512a1d
EZ
9499 * w32console.c (Fset_screen_color): Doc fix.
9500 (Fget_screen_color): New function.
9501 (syms_of_ntterm): Defsubr it.
9502
7285dc67
EZ
9503 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9504 unlink the temporary file if Fcall_process didn't create it in the
9505 first place.
9506 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9507 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9508 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9509 cue to call_process_cleanup not to close that handle.
9510
4d3fcc8e
BK
95112011-05-07 Ben Key <bkey76@gmail.com>
9512
9513 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9514 one of two shell specific rules, either bootstrap-temacs-CMD or
9515 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9516 to the previous implementation of the bootstrap-temacs rule.
9517 The bootstrap-temacs-CMD rule is similar to the previous
9518 implementation of the bootstrap-temacs rule except that it
9519 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9520 variable.
9521
9522 These changes, along with some changes to nt/configure.bat,
9523 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9524 earlier fix to add support for --cflags and --ldflags options
9525 that include quotes so that it works whether make uses cmd or
9526 sh as the shell.
9527
b4289b64
MA
95282011-05-06 Michael Albinus <michael.albinus@gmx.de>
9529
9530 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9531 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9532 is a constant.
9533 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9534 a string. Handle both cases.
9535 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9536 (Fdbus_register_method): Use Qinvalid_function.
9537
af4c0e28
JB
95382011-05-06 Juanma Barranquero <lekktu@gmail.com>
9539
9540 * makefile.w32-in: Update dependencies.
9541 (LISP_H): Add inttypes.h and stdin.h.
9542 (PROCESS_H): Add unistd.h.
9543
c51453d9
EZ
95442011-05-06 Eli Zaretskii <eliz@gnu.org>
9545
9546 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9547 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9548
8ff0ac3c 95492011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9550
4c4b566b
PE
9551 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9552
aab2b9b5
PE
9553 * term.c (vfatal): Remove stray call to va_end.
9554 It's not needed and the C Standard doesn't allow it here anyway.
9555
c378da0b
PE
9556 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9557 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9558
288b08c7
PE
9559 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9560 bytes.
9561
e3601888
PE
9562 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9563
db6c0e74
PE
9564 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9565
dd5963ea
PE
9566 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9567
88c9450f
PE
9568 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9569
2f9442b8
PE
9570 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9571
c032b5f8
PE
9572 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9573 * charset.c (Fdefine_charset_internal): Don't initialize
9574 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9575 32-bit int (Bug#8600).
a108c10b
PE
9576
9577 * lread.c (read_integer): Be more consistent with string-to-number.
9578 Use string_to_number to do the actual conversion; this avoids
9579 rounding errors and fixes some other screwups. Without this fix,
9580 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9581 (digit_to_number): Move earlier, for benefit of read_integer.
9582 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9583 not a digit in any supported base. (Bug#8602)
a108c10b 9584
ad5f9eea
PE
9585 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9586
aec1708a
PE
9587 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9588 to match comment at start of function. This also removes a
9589 GCC warning about overflow in a 32+64-bit port.
9590
47be4ab5
PE
9591 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9592
371cac43
PE
9593 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9594 Reported by Stefan Monnier in
9595 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9596 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9597 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9598
d01a7826
PE
9599 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9600 (EMACS_UINTPTR): Likewise, with uintptr_t.
9601
7fd47d5c
PE
9602 * lisp.h: Prefer 64-bit EMACS_INT if available.
9603 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9604 on 32-bit hosts that have 64-bit int, so that they can access
9605 large files.
122b0c86
PE
9606 However, temporarily disable this change unless the temporary
9607 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9608
8727937b
PE
9609 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9610
8ac068ac
PE
9611 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9612 This removes an assumption that EMACS_INT and long are the same
9613 width as pointers. The assumption is true for Emacs porting targets
9614 now, but we want to make other targets possible.
9615 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9616 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9617 In the rest of the code, change types of integers that hold casted
9618 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9619 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9620 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9621 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9622 No need to cast type when ORing.
9623 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9624 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9625 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9626 assume EMACS_INT is the same width as char *.
9627 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9628 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9629 Remove no-longer-needed casts.
9630 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9631 (xg_tool_bar_help_callback, xg_make_tool_item):
9632 Use EMACS_INTPTR to hold an integer
9633 that will be cast to void *; this can avoid a GCC warning
9634 if EMACS_INT is not the same width as void *.
9635 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9636 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9637 (current_message_1, set_message_1):
9638 Use a local to convert to proper width without a cast.
9639 * xmenu.c (dialog_selection_callback): Likewise.
9640
ede49d71
PE
9641 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9642 Also, don't assume VALBITS / RAND_BITS is less than 5,
9643 and don't rely on undefined behavior when shifting a 1 left into
9644 the sign bit.
9645 * lisp.h (get_random): Change signature to match.
9646
2f30ecd0
PE
9647 * lread.c (hash_string): Use size_t, not int, for hash computation.
9648 Normally we prefer signed values; but hashing is special, because
9649 it's better to use unsigned division on hash table sizes so that
9650 the remainder is nonnegative. Also, size_t is the natural width
9651 for hashing into memory. The previous code used 'int', which doesn't
9652 retain enough info to hash well into very large tables.
9653 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9654
2a866e7b
PE
9655 * dbusbind.c: Don't possibly lose pointer info when converting.
9656 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9657 Use XPNTR rather than XHASH, so that the high-order bits of
9658 the pointer aren't lost when converting through void *.
9659
51639eac
PE
9660 * eval.c (Fautoload): Don't double-shift a pointer.
9661
92394119
PE
9662 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9663
dbdb9a7c
JB
96642011-05-06 Juanma Barranquero <lekktu@gmail.com>
9665
9666 * gnutls.c (DEF_GNUTLS_FN):
9667 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9668
db7a0b4f
AS
96692011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9670
9671 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9672 marker. (Bug#8610)
9673
cd394be1 96742011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9675
9676 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9677 New version that can reserve upto 2GB of heap space.
9678
f7ff1b0f 96792011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9680
9681 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9682
639c109b
TZ
96832011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9684
9685 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9686 `gnutls_certificate_set_x509_key_file'.
9687
d2127135
JB
96882011-05-05 Juanma Barranquero <lekktu@gmail.com>
9689
9690 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9691 Update dependencies.
9692
e968f4f3
JB
96932011-05-04 Juanma Barranquero <lekktu@gmail.com>
9694
9695 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9696 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9697 Remove unused parameter `fildes'.
9698 * process.c (read_process_output, send_process): Don't pass it.
9699
84d358f0
JB
97002011-05-04 Juanma Barranquero <lekktu@gmail.com>
9701
9702 Fix previous change: the library cache is defined in w32.c.
9703 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9704 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9705
0898ca10
JB
97062011-05-04 Juanma Barranquero <lekktu@gmail.com>
9707
9708 Implement dynamic loading of GnuTLS on Windows.
9709
9710 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9711 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9712 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9713 Declare.
9714
9715 * gnutls.c (Qgnutls_dll): Define.
9716 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9717 (gnutls_*): Declare function pointers.
9718 (init_gnutls_functions): New function to initialize function pointers.
9719 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9720 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9721 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9722 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9723 (emacs_gnutls_write, emacs_gnutls_read)
9724 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9725 (Fgnutls_available_p): New function.
9726 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9727 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9728 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9729
9730 * image.c: Include w32.h.
9731 (Vimage_type_cache): Delete.
9732 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9733 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9734 (w32_delayed_load): Move to w32.c.
9735
9736 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9737
9738 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9739 (w32_delayed_load): Move from image.c. When loading a library, record
9740 its filename in the :loaded-from property of the library id.
9741 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9742 Initialize and staticpro them.
9743 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9744
9745 * process.c: Include lisp.h before w32.h, not after.
9746 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9747 instead of gnutls_record_check_pending.
9748
9749 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9750
ff4de4aa
TZ
97512011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9752
9753 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9754 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9755 as passed in.
9756
abe95abb
JD
97572011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9758
9759 * xterm.c (x_set_frame_alpha): Do not set property on anything
9760 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9761
e16e55d4
JB
97622011-05-02 Juanma Barranquero <lekktu@gmail.com>
9763
9764 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9765
bafcf6a5
JB
97662011-05-02 Juanma Barranquero <lekktu@gmail.com>
9767
9768 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9769 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9770 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9771 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9772 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9773 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9774 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9775 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9776 (Qgnutls_bootprop_callbacks_verify): Make static.
9777
e7a6747f
AS
97782011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9779
19ed11ba
AS
9780 * callproc.c: Indentation fixup.
9781
e7a6747f 9782 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9783 (wait_for_termination, interruptible_wait_for_termination):
9784 Move after wait_for_termination_1.
e7a6747f 9785
1ef14cb4
LMI
97862011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9787
9788 * sysdep.c (interruptible_wait_for_termination): New function
9789 which is like wait_for_termination, but allows keyboard
9790 interruptions.
9791
9792 * callproc.c (Fcall_process): Add (:file "file") as an option for
9793 the STDOUT buffer.
9794 (Fcall_process_region): Ditto.
9795
330d880c
EZ
97962011-04-30 Eli Zaretskii <eliz@gnu.org>
9797
8db90b73
EZ
9798 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9799 rather than `XVECTOR (FOO)->size'.
9800
330d880c
EZ
9801 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9802 inttypes.h, as a gnulib replacement is used if it not available in
9803 system headers.
9804
15cbd324
EZ
98052011-04-21 Eli Zaretskii <eliz@gnu.org>
9806
9807 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9808 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9809 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9810
9811 * coding.c (coding_alloc_by_realloc): Error out if destination
9812 will grow beyond MOST_POSITIVE_FIXNUM.
9813 (decode_coding_emacs_mule): Abort if there isn't enough place in
9814 charbuf for the composition carryover bytes. Reserve an extra
9815 space for up to 2 characters produced in a loop.
9816 (decode_coding_iso_2022): Abort if there isn't enough place in
9817 charbuf for the composition carryover bytes.
9818
98192011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9820
ae940cca
EZ
9821 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9822 aborting when %lld or %lll format is passed.
9823 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9824 %llo or %llx format is passed. (Bug#8545)
9825
03ab8921
EZ
9826 * window.c (window_scroll_line_based): Use a marker instead of
9827 simple variables to record original value of point. (Bug#7952)
9828
afda1437
EZ
9829 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9830 produced by %s or %c overflows available buffer space. (Bug#8545)
9831
f76dee0c
PE
98322011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9833
9834 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9835 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9836
fdc5744d
JB
98372011-04-28 Juanma Barranquero <lekktu@gmail.com>
9838
9839 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9840
638f053a
JB
98412011-04-28 Juanma Barranquero <lekktu@gmail.com>
9842
9843 * keyboard.c (Qdelayed_warnings_hook): Define.
9844 (command_loop_1): Run `delayed-warnings-hook'
9845 if Vdelayed_warnings_list is non-nil.
9846 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9847 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9848
d178f871
EZ
98492011-04-28 Eli Zaretskii <eliz@gnu.org>
9850
9851 * doprnt.c (doprnt): Don't return value smaller than the buffer
9852 size if the message was truncated. (Bug#8545).
9853
b124fd93
JB
98542011-04-28 Juanma Barranquero <lekktu@gmail.com>
9855
9856 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9857 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9858
e810457d
PE
98592011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9860
9861 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9862
ea51cceb
JB
98632011-04-27 Juanma Barranquero <lekktu@gmail.com>
9864
9865 * makefile.w32-in: Update dependencies.
9866
94dcfacf
EZ
98672011-04-27 Eli Zaretskii <eliz@gnu.org>
9868
9869 Improve `doprnt' and its usage. (Bug#8545)
9870 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9871 `format_end'. Remove support for %l as a conversion specifier.
9872 Don't use xrealloc. Improve diagnostics when the %l size modifier
9873 is used. Update the commentary.
9874
9875 * eval.c (verror): Simplify calculation of size_t.
9876
9877 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9878 messages.
9879
f61f41d7
PE
98802011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9881
9882 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9883 change.
9884
96fb4434
PE
98852011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9886
9887 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9888 This makes this file independent of the recent pseudovector change.
9889
671875da 98902011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9891
69e9b5a3
PE
9892 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9893
b5f869a7 9894 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9895 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9896 Remove unused local.
c8926152 9897 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9898
841a1577 9899 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9900 GCC 4.6.0 optimizes based on type-based alias analysis.
9901 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9902 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9903 != &v->size, and therefore "v->size = 1; b->size = 2; return
9904 v->size;" must therefore return 1. This assumption is incorrect
9905 for Emacs, since it type-puns struct Lisp_Vector * with many other
9906 types. To fix this problem, this patch adds a new type struct
f904488f 9907 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9908 and pseudovectors, and helps optimizing compilers not get fooled
9909 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9910 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9911 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9912 the size member.
eab3844f
PE
9913 (XSETPVECTYPE): Rewrite in terms of new macro.
9914 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9915 This is a bit clearer, and further avoids the possibility of
9916 undesirable aliasing.
9917 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9918 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9919 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9920 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9921 (ASIZE): Now uses header.size rather than size.
9922 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9923 to avoid the hassle of writing XVECTOR (foo)->header.size.
9924 (struct vectorlike_header): New type.
eab3844f
PE
9925 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9926 object, to help avoid aliasing.
9927 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9928 (SUBRP): Likewise, since Lisp_Subr is a special case.
9929 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9930 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9931 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9932 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9933 changed to be "header.size" and "header.next".
9934 * buffer.h (struct buffer): Likewise.
9935 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9936 * frame.h (struct frame): Likewise.
9937 * process.h (struct Lisp_Process): Likewise.
9938 * termhooks.h (struct terminal): Likewise.
9939 * window.c (struct save_window_data, struct saved_window): Likewise.
9940 * window.h (struct window): Likewise.
9941 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9942 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9943 * buffer.c (init_buffer_once): Likewise.
9944 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9945 special case.
9946 * process.c (Fformat_network_address): Use local var for size,
9947 for brevity.
9948
0df1eac5
PE
9949 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9950
847ab9d1 9951 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9952 * data.c (atof): Remove decl; no longer used or needed.
9953 (digit_to_number): Move to lread.c.
9954 (Fstring_to_number): Use new string_to_number function, to be
9955 consistent with how the Lisp reader treats infinities and NaNs.
9956 Do not assume that floating-point numbers represent EMACS_INT
9957 without losing information; this is not true on most 64-bit hosts.
9958 Avoid double-rounding errors, by insisting on integers when
9959 parsing non-base-10 numbers, as the documentation specifies.
9960 * lisp.h (string_to_number): New decl, replacing ...
9961 (isfloat_string): Remove.
bc0a5c13 9962 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9963 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9964 appears to have been a coding error. Similarly, do not accept
9965 strings like +-1e0 as floating point numbers. Do not report
9966 overflow for integer overflows unless the base is not 10 which
9967 means we have no simple and reliable way to continue.
9968 Break out the floating-point parsing into a new
9969 function string_to_number, so that Fstring_to_number parses
9970 floating point numbers consistently with the Lisp reader.
04f2d78b 9971 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9972 (E_CHAR, EXP_INT): Remove, replacing with ...
9973 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9974 (string_to_number): New function, replacing isfloat_string.
9975 This function checks for valid syntax and produces the resulting
9976 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9977 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9978 so that overflow for non-base-10 numbers is reported only when
9979 there's no portable and simple way to convert to floating point.
452f4150 9980
67769ffc
PE
9981 * textprop.c (set_text_properties_1): Rewrite for clarity,
9982 and to avoid GCC warning about integer overflow.
9983
c20db43f
PE
9984 * intervals.h (struct interval): Use EMACS_INT for members
9985 where EMACS_UINT might cause problems. See
9986 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9987 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9988 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9989 All uses changed.
37aa2f85
PE
9990 (offset_intervals): Tell GCC not to worry about length overflow
9991 when negating a negative length.
c20db43f 9992
2538aa2f
PE
9993 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9994 (overrun_check_free): Likewise.
9995
f2d3008d
PE
9996 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9997 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9998 word size.
9999
ec8df744
PE
10000 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10001 (gnutls_make_error): Rename local to avoid shadowing.
10002 (gnutls_emacs_global_deinit): ifdef out; not used.
10003 (Fgnutls_boot): Use const for pointer to readonly storage.
10004 Comment out unused local. Fix pointer signedness problems.
10005
640ee02d
PE
10006 * lread.c (openp): Don't stuff size_t into an 'int'.
10007 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10008 about possible signed overflow.
10009
6048fb2a
PE
10010 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10011 (GDK_KEY_g): Don't define if already defined.
10012 (xg_prepare_tooltip): Avoid pointer signedness problem.
10013 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10014
fa3c87e1
PE
10015 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10016 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10017
2172544b
PE
10018 * xfns.c (Fx_window_property): Simplify a bit,
10019 to make a bit faster and to avoid GCC 4.6.0 warning.
10020 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10021
9b821a21
PE
10022 * fns.c (internal_equal): Don't assume size_t fits in int.
10023
3c616cfa
PE
10024 * alloc.c (compact_small_strings): Tighten assertion a little.
10025
c2982e87
PE
10026 Replace pEd with more-general pI, and fix some printf arg casts.
10027 * lisp.h (pI): New macro, generalizing old pEd macro to other
10028 conversion specifiers. For example, use "...%"pI"d..." rather
10029 than "...%"pEd"...".
10030 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10031 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10032 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10033 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10034 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10035 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10036 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10037 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10038 64-bit hosts.
10039 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10040 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10041 * print.c (safe_debug_print, print_object): Likewise.
10042 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10043 to int.
6f04d126
PE
10044 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10045 avoiding the 0 flag, which is not portable.
c2982e87
PE
10046 * process.c (Fmake_network_process): Use pI to avoid cast.
10047 * region-cache.c (pp_cache): Likewise.
10048 * xdisp.c (decode_mode_spec): Likewise.
10049 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10050 behavior on 64-bit hosts with printf arg.
6f04d126 10051 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10052 (x_stop_queuing_selection_requests): Likewise.
10053 (x_get_window_property): Don't truncate byte count to an 'int'
10054 when tracing.
0b432f21 10055
5e073ec7
PE
10056 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10057 here, since it parses constructs like leading '-' and spaces,
10058 which are not wanted; and it overflows with large numbers.
10059 Instead, simply match F[0-9]+, which is what is wanted anyway.
10060
36372bf9
PE
10061 * alloc.c: Remove unportable assumptions about struct layout.
10062 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10063 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10064 (allocate_vectorlike, make_pure_vector): Use the new macros,
10065 plus offsetof, to remove unportable assumptions about struct layout.
10066 These assumptions hold on all porting targets that I know of, but
10067 they are not guaranteed, they're easy to remove, and removing them
10068 makes further changes easier.
10069
0b432f21
PE
10070 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10071 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10072 (string_overrun_cookie): Now const. Use initializers that
10073 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10074 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10075 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10076 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10077 multiple of sizeof (EMACS_INT); it need not be, if
10078 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10079 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10080
895009e1
JB
100812011-04-26 Juanma Barranquero <lekktu@gmail.com>
10082
10083 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10084
6a7a1b0b
TZ
100852011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10086
10087 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10088 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10089 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10090
841a1577 100912011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10092
10093 * lisp.h (Qdebug): List symbol.
895009e1 10094 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10095 * keyboard.c (debug-on-event): New variable.
10096 (handle_user_signal): Break into debugger when debug-on-event
10097 matches the current signal symbol.
10098
f2d3ba6f
DN
100992011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10100
10101 * alloc.c (check_sblock, check_string_bytes)
10102 (check_string_free_list): Convert to standard C.
10103
42ce4c63
TZ
101042011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10105
10106 * w32.c (emacs_gnutls_push): Fix typo.
10107
825cd63c
EZ
101082011-04-25 Eli Zaretskii <eliz@gnu.org>
10109
fb11d64d
EZ
10110 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10111 "cast to pointer from integer of different size".
10112
825cd63c
EZ
10113 Improve doprnt and its use in verror. (Bug#8545)
10114 * doprnt.c (doprnt): Document the set of format control sequences
10115 supported by the function. Use SAFE_ALLOCA instead of always
10116 using `alloca'.
10117
10118 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10119 is one byte too soon. Don't use xrealloc; instead xfree and
10120 xmalloc anew.
10121
e061a11b
TZ
101222011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10123
10124 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10125 callbacks stage.
10126
10127 * gnutls.c: Renamed global_initialized to
10128 gnutls_global_initialized. Added internals for the
10129 :verify-hostname-error, :verify-error, and :verify-flags
10130 parameters of `gnutls-boot' and documented those parameters in the
10131 docstring. Start callback support.
9173deec
JB
10132 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10133 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10134 on error. Return error code.
e061a11b
TZ
10135 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10136 (emacs_gnutls_read): Likewise.
10137 (Fgnutls_boot): Return handshake error code.
10138 (emacs_gnutls_handle_error): New function.
10139 (wsaerror_to_errno): Likewise.
10140
10141 * w32.h (emacs_gnutls_pull): Add prototype.
10142 (emacs_gnutls_push): Likewise.
10143
10144 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10145 (emacs_gnutls_push): Likewise.
10146
101472011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10148
10149 * process.c (wait_reading_process_output): Check if GnuTLS
10150 buffered some data internally if no FDs are set for TLS
10151 connections.
10152
10153 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10154 (LIBS): Link to USER_LIBS.
10155 ($(BLD)/gnutls.$(0)): New target.
10156
fa6996bc
EZ
101572011-04-24 Eli Zaretskii <eliz@gnu.org>
10158
eb35682e
EZ
10159 * xdisp.c (handle_single_display_spec): Rename the
10160 display_replaced_before_p argument into display_replaced_p, to
10161 make it consistent with the commentary. Fix typos in the
10162 commentary.
10163
e2ad650c
EZ
10164 * textprop.c (syms_of_textprop): Remove dead code.
10165 (copy_text_properties): Delete obsolete commentary about an
10166 interface that was deleted long ago. Fix typos in the description
10167 of arguments.
10168
1b2de274
EZ
10169 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10170 to changes in oldXMenu/XMenu.h from 2011-04-16.
10171 <menu_help_message, prev_menu_help_message>: Constify.
10172 (IT_menu_make_room): menu->help_text is now `const char **';
10173 adjust.
10174
10175 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10176 to changes in oldXMenu/XMenu.h from 2011-04-16.
10177 (struct XMenu): Declare `help_text' `const char **'.
10178
10179 * xfaces.c <Qunspecified>: Make extern again.
10180
10181 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10182 required by POSIX.
1b2de274 10183
762b15be
EZ
10184 * doc.c (get_doc_string): Improve the format passed to `error'.
10185
10186 * doprnt.c (doprnt): Improve commentary.
10187
10188 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10189
10190 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10191 them with etags.
10192
f1052e5d
EZ
10193 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10194 changes in globals.h immediately force recompilation.
762b15be
EZ
10195 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10196 $(CURDIR)/s/ms-w32.h.
10197 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10198
fa6996bc
EZ
10199 * character.c (Fchar_direction): Function deleted.
10200 (syms_of_character): Don't defsubr it.
10201 <char-direction-table>: Deleted.
10202
e6c3da20
EZ
102032011-04-23 Eli Zaretskii <eliz@gnu.org>
10204
10205 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10206 * doprnt.c: Include limits.h.
10207 (SIZE_MAX): New macro.
04f2d78b
CB
10208 (doprnt): Return a size_t value. 2nd arg is now size_t.
10209 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10210 Improve overflow protection. Support `l' modifier for integer
10211 conversions. Support %l conversion. Don't assume an EMACS_INT
10212 argument for integer conversions and for %c.
10213
10214 * lisp.h (doprnt): Restore prototype.
10215
10216 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10217 $(SRC)/character.h.
10218
10219 * Makefile.in (base_obj): Add back doprnt.o.
10220
10221 * deps.mk (doprnt.o): Add back prerequisites.
10222 (callint.o): Depend on character.h.
10223
10224 * eval.c (internal_lisp_condition_case): Include the handler
10225 representation in the error message.
10226 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10227 when breaking from the loop.
10228
10229 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10230
10231 * callint.c (Fcall_interactively): When displaying error message
10232 about invalid control letter, pass the character's codepoint, not
10233 a pointer to its multibyte form. Improve display of the character
10234 in octal and display also its hex code.
10235
10236 * character.c (char_string): Use %x to display the (unsigned)
10237 codepoint of an invalid character, to avoid displaying a bogus
10238 negative value.
10239
10240 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10241 `error', not SYMBOL_NAME itself.
10242
10243 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10244 character arguments to `error'.
10245
10246 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10247 to `error' in error message about FINAL_CHAR argument. Make sure
10248 FINAL_CHAR is a character, and use %c when it is passed as
10249 argument to `error'.
10250
4ffd0d6b 102512011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10252
10253 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10254
10255 * w32.c: Include <time.h>.
10256 (sys_localtime): New function.
10257
4ffd0d6b 102582011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10259
10260 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10261
4ffd0d6b 10262 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10263
4ffd0d6b 102642011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10265
4ffd0d6b
GM
10266 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10267 zombies (Bug#8467).
aac0c6e3 10268
04c56954
EZ
102692011-04-19 Eli Zaretskii <eliz@gnu.org>
10270
10271 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10272 gl_state.e_property when gl_state.object is Qt.
10273
10274 * insdel.c (make_gap_larger): Remove limitation of buffer size
10275 to <= INT_MAX.
10276
16a43933
CY
102772011-04-18 Chong Yidong <cyd@stupidchicken.com>
10278
10279 * xdisp.c (lookup_glyphless_char_display)
10280 (produce_glyphless_glyph): Handle cons cell entry in
10281 glyphless-char-display.
10282 (Vglyphless_char_display): Document it.
10283
10284 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10285 glyphless-char-display.
10286
4581706e
CY
102872011-04-17 Chong Yidong <cyd@stupidchicken.com>
10288
10289 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10290
10291 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10292
10293 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10294 definition for no-X builds.
10295
4887c6e2 102962011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10297
fd35b6f9
PE
10298 Static checks with GCC 4.6.0 and non-default toolkits.
10299
5c1ccb01
PE
10300 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10301
006c5daa
PE
10302 * process.c (keyboard_bit_set): Define only if SIGIO.
10303 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10304 (send_process): Repair possible setjmp clobbering.
10305
efc736d3
PE
10306 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10307
4e2fe2e6
PE
10308 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10309
f97334a2
PE
10310 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10311
4e75f29d
PE
10312 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10313 Define only if needed.
10314
90efadd1
PE
10315 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10316 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10317 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10318
3c647824
PE
10319 * dispextern.h (struct redisplay_interface): Rename param
10320 to avoid shadowing.
e264f262 10321 * termhooks.h (struct terminal): Likewise.
761383f4 10322 * xterm.c (xembed_send_message): Likewise.
3c647824 10323
b58c5c4a
PE
10324 * insdel.c (make_gap_smaller): Define only if
10325 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10326
cad59032
PE
10327 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10328 it.
10329
c339dc2e
PE
10330 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10331 so that we aren't warned about unused symbols.
10332
91a3e27b
PE
10333 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10334
399c71d3 10335 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10336
8ffc96f5
PE
10337 * xfns.c (x_real_positions): Mark locals as initialized.
10338
eef9bc79
PE
10339 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10340
098db9dd
PE
10341 * xterm.c: Fix problems found by static analysis with other toolkits.
10342 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10343 (x_dispatch_event): Declare static if USE_GTK, and
10344 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10345 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10346 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10347 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10348 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10349
eb18f6cc
PE
10350 * xmenu.c (menu_help_callback): Pointer type fixes.
10351 Use const pointers when pointing at readonly data. Avoid pointer
10352 signedness clashes.
10353 (FALSE): Remove unused macro.
10354 (update_frame_menubar): Remove unused decl.
10355
1fe72bf8
PE
10356 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10357
60d9e1db
PE
10358 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10359 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10360 (single_menu_item): Rename local to avoid shadowing.
10361
39261c26
PE
10362 * keyboard.c (make_lispy_event): Remove unused local var.
10363
018c5e19
PE
10364 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10365 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10366
63d2b86e
PE
10367 * bitmaps: Change bitmaps from unsigned char back to the X11
10368 compatible char. Avoid the old compiler warnings about
10369 out-of-range initializers by using, for example, '\xab' rather
10370 than 0xab.
10371
aefd87e1
PE
10372 * xgselect.c (xgselect_initialize): Check vs interface
10373 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10374
bf501fb9
PE
10375 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10376
e9829fdf
PE
10377 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10378 to read-only memory.
10379
1086c095
PE
10380 * fns.c (vector): Remove; this old hack is no longer needed.
10381
2baccd04 10382 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10383 Remove unused var.
dde42981 10384 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10385
72391843 10386 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10387
436c16df 10388 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10389 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10390 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10391
92bb796d 10392 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10393 (x_term_init): Remove local to avoid shadowing.
92bb796d 10394
764430a3 10395 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10396
10397 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10398 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10399
d1dfb56c
EZ
104002011-04-16 Eli Zaretskii <eliz@gnu.org>
10401
c4354cb4
EZ
10402 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10403
d1dfb56c
EZ
10404 Fix regex.c, syntax.c and friends for buffers > 2GB.
10405 * syntax.h (struct gl_state_s): Declare character position members
10406 EMACS_INT.
10407
10408 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10409
04f2d78b
CB
10410 * textprop.c (verify_interval_modification, interval_of):
10411 Declare arguments EMACS_INT.
d1dfb56c
EZ
10412
10413 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10414 EMACS_INT.
10415
10416 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10417
10418 * indent.c (Fvertical_motion): Local variable it_start is now
10419 EMACS_INT.
10420
10421 * regex.c (re_match, re_match_2, re_match_2_internal)
10422 (bcmp_translate, regcomp, regexec, print_double_string)
10423 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10424 (re_compile_pattern, re_exec): Declare arguments and local
10425 variables `size_t' and `ssize_t' and return values `regoff_t', as
10426 appropriate.
10427 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10428 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10429 <compile_stack_type>: `size' and `avail' are now `size_t'.
10430
10431 * regex.h <regoff_t>: Use ssize_t, not int.
10432 (re_search, re_search_2, re_match, re_match_2): Arguments that
10433 specify buffer/string position and length are now ssize_t and
10434 size_t. Return type is regoff_t.
10435
613052cd
BK
104362011-04-16 Ben Key <bkey76@gmail.com>
10437
10438 * nsfont.m: Fixed bugs in ns_get_family and
10439 ns_descriptor_to_entity that were caused by using free to
10440 deallocate memory blocks that were allocated by xmalloc (via
10441 xstrdup). This caused Emacs to crash when compiled with
10442 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10443 --enable-checking=xmallocoverrun). xfree is now used to
10444 deallocate these memory blocks.
10445
4170f62f 104462011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10447
71b41406
PE
10448 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10449
9587a89d
PE
10450 emacs_write: Accept and return EMACS_INT for sizes.
10451 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10452 et seq.
10453 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10454 Accept and return EMACS_INT.
10455 (emacs_gnutls_write): Return the number of bytes written on
10456 partial writes.
10457 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10458 (emacs_read, emacs_write): Remove check for negative size, as the
10459 Emacs source code has been audited now.
9587a89d
PE
10460 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10461 (emacs_read, emacs_write): Use it.
273a5f82
PE
10462 * process.c (send_process): Adjust to the new signatures of
10463 emacs_write and emacs_gnutls_write. Do not attempt to store
10464 a byte offset into an 'int'; it might overflow.
9587a89d 10465 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10466
3e047f51
PE
10467 * sound.c: Don't assume sizes fit in 'int'.
10468 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10469 Return EMACS_INT, not int.
3e047f51 10470 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10471 Accept EMACS_INT, not int.
10472 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10473 record read return values.
10474
cc39a9db
BK
104752011-04-15 Ben Key <bkey76@gmail.com>
10476
c9d0ec6d
JB
10477 * keyboard.c (Qundefined): Don't declare static since it is used
10478 in nsfns.m.
10479 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10480 static since they are used in nsfont.m.
cc39a9db 10481
6c60eb9f
SM
104822011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10483
10484 * process.c (Qprocessp): Don't declare static.
10485 * lisp.h (Qprocessp): Declare again.
10486
7990b61a
JB
104872011-04-15 Juanma Barranquero <lekktu@gmail.com>
10488
10489 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10490
5d4cb038
PE
104912011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10492
8bd7b830 10493 Improve C-level modularity by making more things 'static'.
cd64ea1d 10494
e3b27b31
PE
10495 Don't publish debugger-only interfaces to other modules.
10496 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10497 (verify_bytepos, count_markers): Move decls to the only modules
10498 that need them.
10499 * region-cache.h (pp_cache): Likewise.
10500 * window.h (check_all_windows): Likewise.
10501 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10502
5d4cb038
PE
10503 * sysdep.c (croak): Now static, if
10504 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10505 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10506
10507 * alloc.c (refill_memory_reserve): Now static if
10508 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10509 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10510
e87b6180
PE
10511 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10512 Define only if USE_LUCID.
10513
ac64929e
PE
10514 * xrdb.c (x_customization_string, x_rm_string): Now static.
10515
6f37259d
PE
10516 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10517 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10518
1683e3ab
PE
10519 * xdisp.c (draw_row_with_mouse_face): Now static.
10520 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10521
de9c2632
PE
10522 * window.h (check_all_windows): Mark externally visible.
10523
2b96acb7
PE
10524 * window.c (window_deletion_count): Now static.
10525
10526 * undo.c: Make symbols static if they're not exported.
10527 (last_undo_buffer, last_boundary_position, pending_boundary):
10528 Now static.
10529
50436f33
PE
10530 * textprop.c (interval_insert_behind_hooks): Now static.
10531 (interval_insert_in_front_hooks): Likewise.
10532
64520e5c
PE
10533 * term.c: Make symbols static if they're not exported.
10534 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10535 (max_frame_lines, tty_set_terminal_modes):
10536 (tty_reset_terminal_modes, tty_turn_off_highlight):
10537 (get_tty_terminal): Now static.
10538 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10539 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10540 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10541 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10542 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10543
1fa53021
PE
10544 * sysdep.c: Make symbols static if they're not exported.
10545 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10546 Now static.
10547 (sigprocmask_set, full_mask): Remove; unused.
10548 (wait_debugging): Mark as visible.
10549 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10550 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10551
d4b43b22
PE
10552 * syntax.c (syntax_temp): Define only if !__GNUC__.
10553
b7c513d0
PE
10554 * sound.c (current_sound_device, current_sound): Now static.
10555
989b29ad
PE
10556 * search.c (searchbufs, searchbuf_head): Now static.
10557
13a55a78
PE
10558 * scroll.c (scroll_cost): Remove; unused.
10559 * dispextern.h (scroll_cost): Remove decl.
10560
de68a1fc
PE
10561 * region-cache.h (pp_cache): Mark as externally visible.
10562
40ccffa6
PE
10563 * process.c: Make symbols static if they're not exported.
10564 (process_tick, update_tick, create_process, chan_process):
10565 (Vprocess_alist, proc_buffered_char, datagram_access):
10566 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10567 (deactivate_process): Mark defn as static, as well as decl.
10568 * lisp.h (create_process): Remove decl.
10569 * process.h (chan_process, Vprocess_alist): Remove decls.
10570
ad64fc97
PE
10571 * print.c: Make symbols static if they're not exported.
10572 (print_depth, new_backquote_output, being_printed, print_buffer):
10573 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10574 (print_interval, print_number_index, initial_stderr_stream):
10575 Now static.
10576 * lisp.h (Fprinc): Remove decl.
10577 (debug_output_compilation_hack): Mark as externally visible.
10578
adddb265
PE
10579 * sysdep.c (croak): Move decl from here to syssignal.h.
10580 * syssignal.h (croak): Put it here, so the API can be checked when
10581 'croak' is called from dissociate_if_controlling_tty.
10582
1717ede2
PE
10583 * minibuf.c: Make symbols static if they're not exported.
10584 (minibuf_save_list, choose_minibuf_frame): Now static.
10585 * lisp.h (choose_minibuf_frame): Remove decl.
10586
fa5fb2bc
PE
10587 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10588
1e3890d1
PE
10589 * lread.c: Make symbols static if they're not exported.
10590 (read_objects, initial_obarray, oblookup_last_bucket_number):
10591 Now static.
10592 (make_symbol): Remove; unused.
10593 * lisp.h (initial_obarray, make_symbol): Remove decls.
10594
8a1414fa
PE
10595 * keyboard.c: Make symbols static if they're not exported.
10596 (single_kboard, recent_keys_index, total_keys, recent_keys):
10597 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10598 (this_single_command_key_start, echoing, last_auto_save):
10599 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10600 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10601 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10602 (Vlispy_mouse_stem, double_click_count):
10603 Now static.
10604 (force_auto_save_soon): Define only if SIGDANGER.
10605 (ignore_mouse_drag_p): Now static if
10606 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10607 (print_help): Remove; unused.
10608 (stop_character, last_timer_event): Mark as externally visible.
10609 * keyboard.h (ignore_mouse_drag_p): Declare only if
10610 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10611 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10612 * lisp.h (echoing): Remove decl.
10613 (force_auto_save_soon): Declare only if SIGDANGER.
10614 * xdisp.c (redisplay_window): Simplify code, to make it more
10615 obvious that ignore_mouse_drag_p is not accessed if !defined
10616 USE_GTK && !defined HAVE_NS.
10617
93ea6e8f
PE
10618 * intervals.c: Make symbols static if they're not exported.
10619 (merge_properties_sticky, merge_interval_right, delete_interval):
10620 Now static.
10621 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10622
77382fcc
PE
10623 * insdel.c: Make symbols static if they're not exported.
10624 However, leave prepare_to_modify_buffer alone. It's never
10625 called from outside this function, but that appears to be a bug.
10626 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10627 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10628 (adjust_after_replace_noundo): Remove; unused.
10629 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10630 (signal_before_change): Remove decls.
77382fcc 10631
9306c32e
PE
10632 * indent.c (val_compute_motion, val_vmotion): Now static.
10633
cd44d2eb
PE
10634 * image.c: Make symbols static if they're not exported.
10635 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10636 if USE_GTK.
10637 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10638 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10639
ad9a7a06
PE
10640 * fringe.c (standard_bitmaps): Now static.
10641 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10642
81626931
PE
10643 * frame.c: Make symbols static if they're not exported.
10644 (x_report_frame_params, make_terminal_frame): Now static.
10645 (get_frame_param): Now static, unless HAVE_NS.
10646 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10647 (x_get_resource_string): Remove; not used.
10648 * frame.h (make_terminal_frame, x_report_frame_params):
10649 (x_get_resource_string); Remove decls.
10650 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10651 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10652
239f9db9
PE
10653 * font.c, fontset.c: Make symbols static if they're not exported.
10654 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10655 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10656 * font.c (font_close_object): Now static.
10657 * font.h (font_close_object): Remove.
10658 * fontset.c (FONTSET_OBJLIST): Remove.
10659 (free_realized_fontset) #if-0 the body, which does nothing.
10660 (face_suitable_for_char_p): #if-0, as it's never called.
10661 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10662 * xfaces.c (face_at_string_position):
10663 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10664 since 0 is always ASCII.
10665
dfcf3579
PE
10666 * fns.c (weak_hash_tables): Now static.
10667
5045092b
PE
10668 * fileio.c: Make symbols static if they're not exported.
10669 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10670 (Vwrite_region_annotation_buffers): Now static.
10671
57a96f5c
PE
10672 * eval.c: Make symbols static if they're not exported.
10673 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10674 * lisp.h (backtrace_list): Remove decl.
10675
35f08c38
PE
10676 * emacs.c: Make symbols static if they're not exported.
10677 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10678 (fatal_error_code, fatal_error_signal_hook, standard_args):
10679 Now static.
10680 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10681 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10682 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10683 * lisp.h (fatal_error_signal_hook): Remove decl.
10684 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10685
f44bd759
PE
10686 * editfns.c: Move a (normally-unused) function to its only use.
10687 * editfns.c, lisp.h (get_operating_system_release): Remove.
10688 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10689 worth the hassle of breaking this out.
10690
b532497d
PE
10691 * xterm.c: Make symbols static if they're not exported.
10692 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10693 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10694 (x_destroy_window, x_delete_display):
10695 Now static.
10696 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10697 (x_mouse_leave): Remove; unused.
10698 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10699 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10700 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10701 Remove decls.
10702 (x_mouse_leave): Declare only if WINDOWSNT.
10703 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10704 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10705 USE_X_TOOLKIT.
10706
1675728f
PE
10707 * ftxfont.c: Make symbols static if they're not exported.
10708 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10709 HAVE_FREETYPE.
10710 * font.h (ftxfont_driver): Likewise.
10711
e4cebfca
PE
10712 * xfns.c: Make symbols static if they're not exported.
10713 (x_last_font_name, x_display_info_for_name):
10714 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10715 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10716 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10717 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10718 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10719 (last_show_tip_args): Now static.
10720 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10721 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10722 (x_screen_planes): Remove; unused.
10723 * dispextern.h (x_screen_planes): Remove decl.
10724
5bf46f05
PE
10725 * dispnew.c: Make symbols static if they're not exported.
10726 * dispextern.h (redraw_garbaged_frames, scrolling):
10727 (increment_row_positions): Remove.
10728 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10729 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10730 Now static.
10731 (redraw_garbaged_frames): Remove; unused.
10732
435f4c28
PE
10733 * xfaces.c: Make symbols static if they're not exported.
10734 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10735 Remove decls.
10736 * xterm.h (defined_color): Remove decls.
10737 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10738 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10739 (menu_face_changed_default, defined_color, free_realized_face):
10740 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10741 (ascii_face_of_lisp_face): Remove; unused.
10742
8524aef3
PE
10743 * xdisp.c: Make symbols static if they're not exported.
10744 * dispextern.h (scratch_glyph_row, window_box_edges):
10745 (glyph_to_pixel_coords, set_cursor_from_row):
10746 (get_next_display_element, set_iterator_to_next):
10747 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10748 (show_mouse_face): Remove decls
10749 * frame.h (message_buf_print): Likewise.
10750 * lisp.h (pop_message, set_message, check_point_in_composition):
10751 Likewise.
10752 * xterm.h (set_vertical_scroll_bar): Likewise.
10753 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10754 (message_buf_print, scratch_glyph_row, displayed_buffer):
10755 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10756 (get_next_display_element, show_mouse_face, window_box_edges):
10757 (frame_to_window_pixel_xy, check_point_in_composition):
10758 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10759 (glyph_to_pixel_coords): Remove; unused.
10760
16390cd2
PE
10761 * dired.c (file_name_completion): Now static.
10762
10763 * dbusbind.c (xd_in_read_queued_messages): Now static.
10764
a25f4dfa
PE
10765 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10766 * data.c (circular_list_error): Remove.
10767
14a9c8df
PE
10768 * commands.h (last_point_position, last_point_position_buffer):
10769 (last_point_position_window): Remove decls.
10770 * keyboard.c: Make these variables static.
10771
04f2d78b
CB
10772 * coding.h (coding, code_convert_region, encode_coding_gap):
10773 Remove decls.
74ab6df5
PE
10774 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10775 (iso_code_class, detect_coding, code_convert_region): Now static.
10776 (encode_coding_gap): Remove; unused.
10777
38dfbee1
PE
10778 * chartab.c (chartab_chars, chartab_bits): Now static.
10779
a2cb4e63
PE
10780 * charset.h (charset_iso_8859_1): Remove decl.
10781 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10782 Now static.
10783
127198fd
PE
10784 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10785 * ccl.c (Vccl_program_table): Now static.
10786 (check_ccl_update): Remove; unused.
10787
d85b608f
PE
10788 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10789 * category.h: ... from here.
10790 * category.c (check_category_table, set_category_set): Now static.
10791
31cd66f3
PE
10792 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10793 * lisp.h: Remove these decls.
10794
c358e587
PE
10795 * buffer.c (buffer_count): Remove unused var.
10796
e78aecca
PE
10797 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10798 so that it's not optimized away.
10799 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10800 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10801 exported only to the debugger.
10802
e192d7d3 10803 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10804 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10805
92470028
PE
10806 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10807 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10808 was inaccessible from Lisp.
10809 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10810 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10811
244ed907
PE
10812 alloc.c: Import and export fewer symbols, and remove unused items.
10813 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10814 is defined.
10815 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10816 it's not optimized away by whole-program optimization.
10817 (message_enable_multibyte, free_misc): Remove.
10818 (catchlist, handlerlist, mark_backtrace):
10819 Declare only if BYTE_MARK_STACK.
10820 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10821 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10822 (message_enable_multibyte): Remove decl.
10823 (free_misc, interval_free_list, float_block, float_block_index):
10824 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10825 (cons_free_list, last_marked_index):
10826 Now static.
10827 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10828 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10829 (mark_backtrace): Define only if BYTE_MARK_STACK.
10830 * xdisp.c (message_enable_multibyte): Now static.
10831
61c2b50e 10832 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10833 This makes it easier for human readers (and static analyzers)
10834 to see whether these variables are used from other modules.
10835 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10836 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10837 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10838 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10839 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10840 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10841 * xmenu.c, xselect.c:
10842 Declare Q* vars static if they are not used in other modules.
10843 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10844 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10845 Remove decls of unexported vars.
10846 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10847
95c82688
PE
10848 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10849
16a97296
PE
10850 Make Emacs functions such as Fatom 'static' by default.
10851 This makes it easier for human readers (and static analyzers)
10852 to see whether these functions can be called from other modules.
10853 DEFUN now defines a static function. To make the function external
10854 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10855 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10856 (Finit_image_library):
16a97296
PE
10857 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10858 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10859 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10860 Remove decls, since these functions are now static.
10861 (Funintern, Fget_internal_run_time): New decls, since these functions
10862 were already external.
95c82688 10863
16a97296
PE
10864 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10865 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10866 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10867 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10868 * keyboard.c, keymap.c, lread.c:
10869 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10870 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10871 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10872 Mark functions with DEFUE instead of DEFUN,
10873 if they are used in other modules.
10874 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10875 decls for now-static functions.
10876 * buffer.h (Fdelete_overlay): Remove decl.
10877 * callproc.c (Fgetenv_internal): Mark as internal.
10878 * composite.c (Fremove_list_of_text_properties): Remove decl.
10879 (Fcomposition_get_gstring): New forward static decl.
10880 * composite.h (Fcomposite_get_gstring): Remove decl.
10881 * dired.c (Ffile_attributes): New forward static decl.
10882 * doc.c (Fdocumntation_property): New forward static decl.
10883 * eval.c (Ffetch_bytecode): New forward static decl.
10884 (Funintern): Remove extern decl; now in .h file where it belongs.
10885 * fileio.c (Fmake_symbolic_link): New forward static decl.
10886 * image.c (Finit_image_library): New forward static decl.
10887 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10888 * intervals.h (Fprevious_property_change):
10889 (Fremove_list_of_text_properties): Remove decls.
10890 * keyboard.c (Fthis_command_keys): Remove decl.
10891 (Fcommand_execute): New forward static decl.
10892 * keymap.c (Flookup_key): New forward static decl.
10893 (Fcopy_keymap): Now static.
10894 * keymap.h (Flookup_key): Remove decl.
10895 * process.c (Fget_process): New forward static decl.
10896 (Fprocess_datagram_address): Mark as internal.
10897 * syntax.c (Fsyntax_table_p): New forward static decl.
10898 (skip_chars): Remove duplicate decl.
10899 * textprop.c (Fprevious_property_change): New forward static decl.
10900 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10901 Now internal.
10902 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10903 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10904
785bbd42
PE
10905 * editfns.c (Fformat): Remove unreachable code.
10906
8b913b57
AS
109072011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10908
10909 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10910 change. (Bug#8496)
10911
a6744a35
EZ
109122011-04-13 Eli Zaretskii <eliz@gnu.org>
10913
10914 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10915 when at ZV. (Bug#8487)
10916
e7974947
AS
109172011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10918
baad03f0
AS
10919 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10920 (Bug#8437)
10921 * keyboard.c (parse_tool_bar_item): Likewise.
10922 * sound.c (sound_cleanup, alsa_close): Likewise.
10923 * termcap.c (tgetent): Likewise.
10924 * xfns.c (x_default_font_parameter): Likewise.
10925 * xsettings.c (read_and_apply_settings): Likewise.
10926
e7974947
AS
10927 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10928 (overrun_check_free): Protoize.
10929
28272684
PE
109302011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10931
10932 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10933 since callers should never pass a negative size.
10934 Change the signature to match that of plain 'read' and 'write'; see
10935 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10936 * lisp.h: Update prototypes of emacs_write and emacs_read.
10937
11997c76
EZ
109382011-04-11 Eli Zaretskii <eliz@gnu.org>
10939
10940 * xdisp.c (redisplay_window): Don't try to determine the character
10941 position of the scroll margin if the window start point w->startp
e896f03c 10942 is outside the buffer's accessible region. (Bug#8468)
11997c76 10943
8a2cbd72
EZ
109442011-04-10 Eli Zaretskii <eliz@gnu.org>
10945
10946 Fix write-region and its subroutines for buffers > 2GB.
10947 * fileio.c (a_write, e_write): Modify declaration of arguments and
10948 local variables to support buffers larger than 2GB.
10949 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10950
10951 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10952 argument, local variables, and return value.
10953
10954 * lisp.h: Update prototypes of emacs_write and emacs_read.
10955
10956 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10957
4073e537 109582011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10959
1ebfdcb6
PE
10960 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10961
b2ded58d
PE
10962 Fix more problems found by GCC 4.6.0's static checks.
10963
7d66342c
PE
10964 * xdisp.c (vmessage): Use a better test for character truncation.
10965
bbf47d44
PE
10966 * charset.c (load_charset_map): <, not <=, for optimization,
10967 and to avoid potential problems with integer overflow.
9248994d 10968 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10969 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10970 * editfns.c (Fformat): Likewise.
1e69125e 10971 * syntax.c (skip_chars): Likewise.
3befa583 10972
e3019616
PE
10973 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10974 This also lets GCC 4.6.0 generate slightly better loop code.
10975
becfa255
PE
10976 * callint.c (Fcall_interactively): <, not <=, for optimization.
10977 (Fcall_interactively): Count the number of arguments produced,
10978 not the number of arguments given. This is simpler and lets GCC
10979 4.6.0 generate slightly better code.
10980
dae0cd48
PE
10981 * ftfont.c: Distingish more carefully between FcChar8 and char.
10982 The previous code passed unsigned char * to a functions like
10983 strlen and xstrcasecmp that expect char *, which does not
10984 conform to the C standard.
10985 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10986 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10987 char * when the C standard requires it.
10988
76032d70
PE
10989 * keyboard.c (read_char): Remove unused var.
10990
eb3f1cc8
PE
10991 * eval.c: Port to Windows vsnprintf (Bug#8435).
10992 Include <limits.h>.
10993 (SIZE_MAX): Define if the headers do not.
10994 (verror): Do not give up if vsnprintf returns a negative count.
10995 Instead, grow the buffer. This ports to Windows vsnprintf, which
10996 does not conform to C99. Problem reported by Eli Zaretskii.
10997 Also, simplify the allocation scheme, by avoiding the need for
10998 calling realloc, and removing the ALLOCATED variable.
10999
70476b54
PE
11000 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11001
12020a9e
PE
11002 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11003 But keep the doprint source code for now, as we might revamp it
11004 and use it again (Bug#8435).
ea6c7ae6
PE
11005 * lisp.h (doprnt): Remove.
11006 * Makefile.in (base_obj): Remove doprnt.o.
11007 * deps.mk (doprnt.o): Remove.
11008
5fdb398c
PE
11009 error: Print 32- and 64-bit integers portably (Bug#8435).
11010 Without this change, on typical 64-bit hosts error ("...%d...", N)
11011 was used to print both 32- and 64-bit integers N, which relied on
11012 undefined behavior.
61bdb816 11013 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11014 * lisp.h (error, verror): Mark as printf-like functions.
11015 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11016 Report overflow in size calculations when allocating printf buffer.
11017 Do not truncate output string at its first null byte.
11018 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11019 Truncate the output at a character boundary, since vsnprintf does not
11020 do that.
11021 * charset.c (check_iso_charset_parameter): Convert internal
11022 character to string before calling 'error', since %c now has the
11023 printf meaning.
11024 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11025 overflow when computing char to be passed to 'error'. Do not
11026 pass Lisp_Object to 'error'; pass the integer instead.
11027 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11028 formatted with plain %d.
11029
b189fa66
PE
11030 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11031
bff87ef0
PE
11032 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11033
7e2cac20
PE
11034 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11035
ce4d90b5
PE
11036 * xterm.c (x_catch_errors): Remove duplicate declaration.
11037
266c9547
PE
11038 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11039
79c49ad2
PE
11040 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11041
368f4090
JM
110422011-04-10 Jim Meyering <meyering@redhat.com>
11043
11044 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11045 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11046 return ssize_t not "int", and use size_t as the buffer length.
11047 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11048 * gnutls.h: Update declarations.
11049 * process.c (read_process_output): Use ssize_t, to match.
11050 (send_process): Likewise.
11051
a32d4040
CY
110522011-04-09 Chong Yidong <cyd@stupidchicken.com>
11053
11054 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11055
8546720e 110562011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11057
04f2d78b
CB
11058 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11059 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11060
8546720e
GM
11061 * xterm.c (handle_one_xevent):
11062 * xmenu.c (create_and_show_popup_menu):
11063 * xselect.c (x_decline_selection_request)
11064 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11065
0a2f5c1a 110662011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11067
11068 Fix some uses of `int' instead of EMACS_INT.
11069 * search.c (string_match_1, fast_string_match)
11070 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11071 (scan_buffer, find_next_newline_no_quit)
11072 (find_before_next_newline, search_command, Freplace_match)
11073 (Fmatch_data): Make some `int' variables be EMACS_INT.
11074
11075 * xdisp.c (display_count_lines): 3rd argument and return value now
11076 EMACS_INT. All callers changed.
11077 (pint2hrstr): Last argument is now EMACS_INT.
11078
11079 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11080 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11081 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11082 (decode_coding_utf_16, decode_coding_emacs_mule)
11083 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11084 (decode_coding_ccl, decode_coding_charset)
11085 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11086 (decode_coding_iso_2022, decode_coding_emacs_mule)
11087 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11088 <char_offset, last_offset>: Declare EMACS_INT.
11089 (encode_coding_utf_8, encode_coding_utf_16)
11090 (encode_coding_emacs_mule, encode_invocation_designation)
11091 (encode_designation_at_bol, encode_coding_iso_2022)
11092 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11093 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11094 Declare EMACS_INT.
11095 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11096 (encode_invocation_designation): Last argument P_NCHARS is now
11097 EMACS_INT.
11098 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11099 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11100
11101 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11102 All users changed.
11103
11104 * ccl.c (Fccl_execute_on_string): Declare some variables
11105 EMACS_INT.
11106
8546720e 111072011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11108
11109 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11110
4e19a977
CS
111112011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11112
11113 * process.c (Fformat_network_address): Doc fix.
11114
87302331
R
111152011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11116
ee7683eb 11117 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11118
cbb59342
CY
111192011-04-08 Chong Yidong <cyd@stupidchicken.com>
11120
11121 * keyboard.c (read_char): Call Lisp function help-form-show,
11122 instead of using internal_with_output_to_temp_buffer.
11123 (Qhelp_form_show): New var.
e0d38eeb 11124 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11125
11126 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11127
11128 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11129
e67a13ab
CY
111302011-04-06 Chong Yidong <cyd@stupidchicken.com>
11131
04f2d78b
CB
11132 * process.c (Flist_processes): Remove to Lisp.
11133 (list_processes_1): Delete.
e67a13ab 11134
973f782d
EZ
111352011-04-06 Eli Zaretskii <eliz@gnu.org>
11136
7c106b1e
EZ
11137 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11138
973f782d
EZ
11139 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11140
41cf7d1a 111412011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11142
ca23cc88
PE
11143 Fix more problems found by GCC 4.6.0's static checks.
11144
f390e2d5
PE
11145 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11146
42eea0d0
PE
11147 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11148
b69769da 11149 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11150
f9541e84
PE
11151 * xdisp.c (vmessage): Mark as a printf-like function.
11152
13841b55
PE
11153 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11154
c136c10f
PE
11155 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11156
5e2d4a30
PE
11157 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11158 printf-like functions.
11159 (tiff_load): Add casts to remove these marks before passing them
11160 to system-supplied API.
11161
583f48b9
PE
11162 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11163
b25d760e
PE
11164 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11165 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11166 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11167 directly, rather than having caller test rule sign. This avoids
11168 some unnecessary tests.
11169 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11170 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11171 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11172
bc7b6697 11173 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11174 (xfont_open): Avoid unnecessary tests.
bc7b6697 11175
27ccc379
PE
11176 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11177
dcd5c89a
PE
11178 * composite.h, composite.c (composition_gstring_put_cache):
11179 Use EMACS_INT, not int, for length.
11180
b13a45c6
PE
11181 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11182 breaking out part of COMPOSITION_DECODE_RULE.
11183 (COMPOSITION_DECODE_RULE): Use it.
11184 * composite.c (get_composition_id): Remove unused local vars,
11185 by using the new macro.
11186
1e792e4d
PE
11187 * textprop.c (set_text_properties_1): Change while to do-while,
11188 since the condition is always true at first.
11189
dc6c6455 11190 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11191 (interval_deletion_adjustment): Return unsigned value.
11192 All uses changed.
dc6c6455 11193
aba7731a
PE
11194 * process.c (list_processes_1, create_pty, read_process_output):
11195 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11196 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11197 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11198 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11199 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11200
fdfc4bf3
PE
11201 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11202
fca8fe46 11203 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11204 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11205
06a0259a 11206 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11207 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11208 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11209
e7b9e80f
PE
11210 * print.c (print_error_message): Avoid int overflow.
11211
56201685
PE
11212 * font.c (font_list_entities): Redo for clarity,
11213 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11214
78834453 11215 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11216 (font_score): Avoid potential overflow in diff calculation.
78834453 11217
0bc0b309 11218 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11219 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11220
e610eaca
PE
11221 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11222
b895abce
PE
11223 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11224 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11225 can always succeed if overflow has undefined behavior.
11226
1f1d9321 11227 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11228 (wordify): Omit three unnecessary tests.
1f1d9321 11229
c59478bc
PE
11230 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11231 All callers changed. This avoids the need for an unused var.
11232
79b73827
PE
11233 * casefiddle.c (casify_region): Remove var that is set but not used.
11234
a4db5dfe
PE
11235 * dired.c (file_name_completion): Remove var that is set but not used.
11236
43aae36e
PE
11237 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11238
2a47c44d 11239 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11240 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11241
a37c69bf
PE
11242 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11243 Check for integer overflow on size calculations.
11244
328ab8e7
PE
11245 * buffer.c (Fprevious_overlay_change): Remove var that is set
11246 but not used.
11247
e5a2a5cb
PE
11248 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11249 Remove vars that are set but not used.
8d84a6eb 11250 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11251 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11252
a60e5f68
PE
11253 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11254
f661cb61 11255 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11256 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11257
f0397f5a
PE
11258 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11259 that are set but not used.
11260
8664db06 11261 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11262 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11263
6abdaa4a
PE
11264 * xselect.c (x_get_local_selection, x_handle_property_notify):
11265 Remove vars that are set but not used.
11266
0ce7538d 11267 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11268 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11269
9ae848fc
PE
11270 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11271 Remove var that is set but not used.
0b918413
PE
11272 (scroll_bar_windows_size): Now size_t, not int.
11273 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11274 Check for overflow.
9ae848fc 11275
a5a62657
PE
11276 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11277 (map_tty_color) [!defined MSDOS]: Likewise.
11278
5c5cdd39
PE
11279 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11280
66ebf983
PE
11281 * coding.c: Remove vars that are set but not used.
11282 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11283 All callers changed.
11284 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11285 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11286 (decode_coding_charset): Remove vars that are set but not used.
11287
1be4d761
PE
11288 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11289 that is set but not used.
11290
47553fa8
PE
11291 * print.c (print_object): Remove var that is set but not used.
11292
1f7196bf 11293 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11294 The gnulib version avoids calling malloc in the usual case,
11295 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11296 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11297 * filelock.c (current_lock_owner): Likewise.
11298 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11299 * sysdep.c: Include allocator.h, careadlinkat.h.
11300 (emacs_no_realloc_allocator): New static constant.
11301 (emacs_readlink): New function.
fdb61804
PE
11302 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11303 ../lib/careadlinkat.h.
d1fdcab7 11304
f84c17c7
SM
113052011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11306
11307 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11308 first non-nil return value).
11309
ef3862ad
JD
113102011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11311
11312 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11313 if not defined (Bug#8403).
11314
376a7006
JB
113152011-04-02 Juanma Barranquero <lekktu@gmail.com>
11316
11317 * xdisp.c (display_count_lines): Remove parameter `start',
11318 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11319 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11320 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11321 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11322 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11323 and thereabouts. All callers changed.
11324 (get_per_char_metric): Remove parameter `f', unused since
11325 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11326
6ca3801d
JM
113272011-04-02 Jim Meyering <meyering@redhat.com>
11328
11329 do not dereference NULL upon failed strdup
11330 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11331 (ns_get_family): Likewise.
11332
d8e2b5ba
JB
113332011-04-02 Juanma Barranquero <lekktu@gmail.com>
11334
11335 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11336
8c74fcbd
JD
113372011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11338
11339 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11340 later (Bug#8403).
11341
7200d79c
SM
113422011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11343
03408648 11344 Add lexical binding.
7200d79c 11345
03408648
SM
11346 * window.c (Ftemp_output_buffer_show): New fun.
11347 (Fsave_window_excursion):
11348 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11349
11350 * lread.c (lisp_file_lexically_bound_p): New function.
11351 (Fload): Bind Qlexical_binding.
11352 (readevalloop): Remove `evalfun' arg.
11353 Bind Qinternal_interpreter_environment.
11354 (Feval_buffer): Bind Qlexical_binding.
11355 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11356 Mark as dynamic.
11357 (syms_of_lread): Declare `lexical-binding'.
11358
11359 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11360
11361 * keyboard.c (eval_dyn): New fun.
11362 (menu_item_eval_property): Use it.
ca105506
SM
11363
11364 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11365
03408648
SM
11366 * fns.c (concat, mapcar1): Accept byte-code-functions.
11367
11368 * eval.c (Fsetq): Handle lexical vars.
11369 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11370 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11371 (FletX, Flet): Obey lexical binding.
11372 (Fcommandp): Handle closures.
11373 (Feval): New `lexical' arg.
11374 (eval_sub): New function extracted from Feval. Use it almost
11375 everywhere where Feval was used. Look up vars in lexical env.
11376 Handle closures.
11377 (Ffunctionp): Move from subr.el.
11378 (Ffuncall): Handle closures.
11379 (apply_lambda): Remove `eval_flags'.
11380 (funcall_lambda): Handle closures and new byte-code-functions.
11381 (Fspecial_variable_p): New function.
11382 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11383 but without exporting it to Lisp.
23aba0ea 11384
23aba0ea 11385 * doc.c (Fdocumentation, store_function_docstring):
03408648 11386 * data.c (Finteractive_form): Handle closures.
23aba0ea 11387
03408648
SM
11388 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11389 interactive spec.
ba83908c 11390
04f2d78b
CB
11391 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11392 New byte-codes.
03408648
SM
11393 (exec_byte_code): New function extracted from Fbyte_code to handle new
11394 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11395
03408648 11396 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11397
03408648 11398 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11399
e2abce01
JB
114002011-03-31 Juanma Barranquero <lekktu@gmail.com>
11401
11402 * xdisp.c (redisplay_internal): Fix prototype.
11403
63696a73 114042011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11405
63696a73 11406 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11407 (try_scrolling): Use it when setting scroll_limit.
11408 Limit scrolling to 100 screen lines.
63696a73
EZ
11409 (redisplay_window): Even when falling back on "recentering",
11410 position point in the window according to scroll-conservatively,
11411 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11412
11413 (try_scrolling): When point is above the window, allow searching
11414 as far as scroll_max, or one screenful, to compute vertical
11415 distance from PT to the scroll margin position. This prevents
11416 try_scrolling from unnecessarily failing when
11417 scroll-conservatively is set to a value slightly larger than the
11418 window height. Clean up the case of PT below the margin at bottom
11419 of window: scroll_max can no longer be INT_MAX. When aggressive
11420 scrolling is in use, don't let point enter the opposite scroll
11421 margin as result of the scroll.
11422 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11423 threshold of 100 lines for never-recentering scrolling.
11424
e4cc2dfc
JB
114252011-03-31 Juanma Barranquero <lekktu@gmail.com>
11426
11427 * dispextern.h (move_it_by_lines):
11428 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11429 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11430 (message_log_check_duplicate): Remove parameters `prev_bol' and
11431 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11432 (redisplay_internal): Remove parameter `preserve_echo_area',
11433 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11434
11435 * indent.c (Fvertical_motion):
11436 * window.c (window_scroll_pixel_based, Frecenter):
11437 Don't pass `need_y_p' to `move_it_by_lines'.
11438
1c470562
SM
114392011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11440
44f230aa
SM
11441 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11442 steal a few bits to be more compact.
11443 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11444 Remove unneeded casts.
11445
1c470562
SM
11446 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11447
888adce9
ZK
114482011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11449
11450 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11451 binding" message (bug#7967).
11452
f838ed7b
PE
114532011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11454
77861b95
PE
11455 Fix more problems found by GCC 4.6.0's static checks.
11456
de6dbc14
PE
11457 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11458 Remove unused local var.
11459
f838ed7b
PE
11460 * editfns.c (Fmessage_box): Remove unused local var.
11461
792c7b2b
PE
11462 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11463 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11464 Omit unused local vars.
c499e557 11465 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11466 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11467 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11468 Omit unused local var.
11469
ba0165e1
PE
11470 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11471 Don't assume string length fits in int.
32ad8845 11472 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11473 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11474
3c59b4c9
PE
11475 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11476 instead of alloca (Bug#8344).
11477
a3eed478 11478 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11479 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11480
eb4d412d
PE
11481 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11482
1658b401
PE
11483 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11484 concerns.
11485
11486 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11487
11488 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11489
9a2c6e05
PE
11490 * keyboard.c (syms_of_keyboard): Use the same style as later
11491 in this function when indexing through an array. This also
11492 works around GCC bug 48267.
11493
03d0a109
PE
11494 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11495
44f730c8
PE
11496 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11497
fe75f926
PE
11498 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11499 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11500
ffa8c828
PE
11501 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11502 This avoids undefined behavior on integer overflow, and is a bit
11503 more convenient anyway since it is compared to a size_t variable.
11504
c5101a77
PE
11505 Variadic C functions now count arguments with size_t, not int.
11506 This avoids an unnecessary limitation on 64-bit machines, which
11507 caused (substring ...) to crash on large vectors (Bug#8344).
11508 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11509 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11510 All variadic functions and their callers changed accordingly.
c5101a77
PE
11511 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11512 * data.c (arith_driver, float_arith_driver): Likewise.
11513 * editfns.c (general_insert_function): Likewise.
11514 * eval.c (struct backtrace.nargs, interactive_p)
11515 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11516 (funcall_lambda, mark_backtrace): Likewise.
11517 * fns.c (concat): Likewise.
11518 * frame.c (x_set_frame_parameters): Likewise.
11519 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11520 0 if not found, not -1. All callers changed.
11521
dd3f25f7
PE
11522 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11523 (stack_copy_size): Now size_t, not int.
11524 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11525
461c2ab9
JB
115262011-03-28 Juanma Barranquero <lekktu@gmail.com>
11527
11528 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11529 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11530 All callers changed.
11531
11532 * lisp.h (multibyte_char_to_unibyte):
11533 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11534 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11535 * character.h (CHAR_TO_BYTE8):
11536 * cmds.c (internal_self_insert):
11537 * editfns.c (general_insert_function):
11538 * keymap.c (push_key_description):
11539 * search.c (Freplace_match):
11540 * xdisp.c (message_dolog, set_message_1): All callers changed.
11541
f6d62986
SM
115422011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11543
11544 * keyboard.c (safe_run_hook_funcall): New function.
11545 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11546 don't set the hook to nil, but remove the offending function instead.
11547 (Qcommand_hook_internal): Remove, unused.
11548 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11549 Vcommand_hook_internal.
11550
11551 * eval.c (enum run_hooks_condition): Remove.
11552 (funcall_nil, funcall_not): New functions.
11553 (run_hook_with_args): Call each function through a `funcall' argument.
11554 Remove `cond' argument, now redundant.
11555 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11556 (Frun_hook_with_args_until_failure): Adjust accordingly.
11557 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11558
1db5b1ad
JB
115592011-03-28 Juanma Barranquero <lekktu@gmail.com>
11560
11561 * dispextern.h (string_buffer_position): Remove declaration.
11562
11563 * print.c (strout): Remove parameter `multibyte', unused since
11564 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11565
11566 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11567 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11568 All callers changed.
11569
11570 * w32.c (_wsa_errlist): Use braces for struct initializers.
11571
11572 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11573 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11574 All callers changed.
11575 (string_buffer_position): Likewise. Also, make static (it's never
11576 used outside xdisp.c).
11577 (cursor_row_p): Remove parameter `w', unused since
11578 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11579 (decode_mode_spec): Remove parameter `precision', introduced during
11580 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11581 All callers changed.
11582
5ffb62aa
JD
115832011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11584
11585 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11586
461c2ab9 115872011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11588
11589 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11590 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11591 (ns_update_auto_hide_menu_bar): New functions.
11592 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11593 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11594 ns_constrain_all_frames.
11595 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11596 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11597
5c380ffb
JD
115982011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11599
11600 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11601
9af30bdf
GM
116022011-03-27 Glenn Morris <rgm@gnu.org>
11603
11604 * syssignal.h: Replace RETSIGTYPE with void.
11605 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11606 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11607 Replace SIGTYPE with void everywhere.
11608 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11609 * s/template.h (SIGTYPE): Remove commented out definition.
11610
e2abce01
JB
116112011-03-26 Eli Zaretskii <eliz@gnu.org>
11612
11613 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11614 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11615
f868cd8a
JB
116162011-03-26 Juanma Barranquero <lekktu@gmail.com>
11617
59eb0929
JB
11618 * w32.c (read_unc_volume): Use parameter `henum', instead of
11619 global variable `wget_enum_handle'.
11620
11621 * keymap.c (describe_vector): Remove parameters `indices' and
11622 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11623 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11624
f868cd8a
JB
11625 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11626
11627 * keyboard.c (timer_check): Remove parameter `do_it_now',
11628 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11629 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11630 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11631
11632 * keyboard.c (read_char):
11633 * w32menu.c (w32_menu_display_help):
11634 * xmenu.c (show_help_event, menu_help_callback):
11635 Adjust calls to `show_help_echo'.
11636
11637 * gtkutil.c (xg_maybe_add_timer):
11638 * keyboard.c (readable_events):
11639 * process.c (wait_reading_process_output):
11640 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11641
11642 * insdel.c (adjust_markers_gap_motion):
11643 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11644 (gap_left, gap_right): Don't call it.
11645
2ecf6fdb
CY
116462011-03-25 Chong Yidong <cyd@stupidchicken.com>
11647
11648 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11649 incurred during fontification.
11650
6b1f9ba4
JB
116512011-03-25 Juanma Barranquero <lekktu@gmail.com>
11652
11653 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11654 (DEFVAR_PER_BUFFER): Don't pass it.
11655
11656 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11657 (scrolling_window): Don't pass it.
11658
0f4a96b5
JB
116592011-03-25 Juanma Barranquero <lekktu@gmail.com>
11660
11661 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11662
11663 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11664 and `suffix'.
11665 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11666 of variables specific to SELinux and computation of `encoded_absname'.
11667
11668 * image.c (XPutPixel): Remove unused variable `height'.
11669
11670 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11671
11672 * unexw32.c (get_section_info): Remove unused variable `section'.
11673
11674 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11675 (system_process_attributes): Remove unused variable `sess'.
11676 (sys_read): Remove unused variable `err'.
11677
11678 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11679 (w32_wnd_proc): Remove unused variable `isdead'.
11680 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11681 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11682 (x_create_tip_frame): Remove unused variable `tem'.
11683
11684 * w32inevt.c (w32_console_read_socket):
11685 Remove unused variable `no_events'.
11686
11687 * w32term.c (x_draw_composite_glyph_string_foreground):
11688 Remove unused variable `width'.
11689
1149507c
JB
116902011-03-24 Juanma Barranquero <lekktu@gmail.com>
11691
11692 * w32term.c (x_set_glyph_string_clipping):
11693 Don't pass uninitialized region to CombineRgn.
11694
9c88f339
JB
116952011-03-23 Juanma Barranquero <lekktu@gmail.com>
11696
11697 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11698 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11699 (Fx_close_connection): Remove unused variable `i'.
11700
11701 * w32font.c (w32font_draw): Return number of glyphs.
11702 (w32font_open_internal): Remove unused variable `i'.
11703 (w32font_driver): Add missing initializer.
11704
11705 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11706 (fill_in_menu): Remove unused variable `items_added'.
11707
11708 * w32term.c (last_mouse_press_frame): Remove static global variable.
11709 (w32_clip_to_row): Remove unused variable `f'.
11710 (x_delete_terminal): Remove unused variable `i'.
11711
11712 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11713 (NOTHING): Remove unused static global variable.
11714 (uniscribe_check_otf): Remove unused variable `table'.
11715 (uniscribe_font_driver): Add missing initializers.
11716
dee091a3
JD
117172011-03-23 Julien Danjou <julien@danjou.info>
11718
11719 * term.c (Fsuspend_tty, Fresume_tty):
11720 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11721 * window.c (temp_output_buffer_show):
11722 * insdel.c (signal_before_change):
11723 * frame.c (Fhandle_switch_frame):
11724 * fileio.c (Fdo_auto_save):
11725 * emacs.c (Fkill_emacs):
11726 * editfns.c (save_excursion_restore):
11727 * cmds.c (internal_self_insert):
11728 * callint.c (Fcall_interactively):
11729 * buffer.c (Fkill_all_local_variables):
11730 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11731 Use Frun_hooks.
0f4a96b5 11732 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11733 unconditionally since it does the check itself.
dee091a3 11734
2c520ab5 117352011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11736
c9c49752
PE
11737 Fix more problems found by GCC 4.5.2's static checks.
11738
8abc3f12
PE
11739 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11740 the first time through the loop, since we know p0 < p1 then.
11741 This also avoids a gcc -Wstrict-overflow warning.
11742
a2d26660
PE
11743 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11744 leading to a memory leak, possible in functions like
11745 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11746 of objects (Bug#8318).
a2d26660 11747
916c72e9
PE
11748 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11749 that could (at least in theory) be that large.
11750
19ab8a18
PE
11751 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11752 This is less likely to overflow, and avoids undefined behavior if
11753 overflow does occur. All callers changed. Use strtoul to scan
11754 for the unsigned long integer.
b7cbbd6f
PE
11755 (pint2hrstr): Simplify and tune code slightly.
11756 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11757
f0641eff
PE
11758 * scroll.c (do_scrolling): Work around GCC bug 48228.
11759 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11760
7f650bb9
PE
11761 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11762 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11763 (validate_x_resource_name): Simplify count usage.
11764 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11765
37dd57d1
PE
11766 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11767 fail (Bug#8306).
81e56e61 11768
699979fc 11769 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11770
401bf9b4
PE
11771 * process.c (Fmake_network_process): Use socklen_t, not int,
11772 where POSIX says socklen_t is required in portable programs.
11773 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11774 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11775 (Fmake_network_process, server_accept_connection):
11776 (wait_reading_process_output, read_process_output):
11777 Likewise.
11778
b93aacde
PE
11779 * process.c: Rename or move locals to avoid shadowing.
11780 (list_processes_1, Fmake_network_process):
11781 (read_process_output_error_handler, exec_sentinel_error_handler):
11782 Rename or move locals.
4dc343ee 11783 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11784 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11785 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11786 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11787 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11788
af8a867c 11789 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11790 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11791 Include tparam.h instead, since it declares them.
af8a867c
PE
11792 * cm.h (PC): Remove extern decl; tparam.h now does this.
11793 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11794 * terminfo.c: Include tparam.h, to check interfaces.
11795 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11796 (tparam): Adjust signature to match interface in tparam.h;
11797 this removes some undefined behavior. Check that outstring and len
11798 are zero, which they always are with Emacs.
11799 * tparam.h (PC, BC, UP): New extern decls.
11800
0248044d 11801 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11802 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11803
8ff096c1 11804 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11805 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11806 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11807 (ftfont_list): Remove unused local.
49eaafba
PE
11808 (get_adstyle_property, ftfont_pattern_entity):
11809 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11810 Rename locals to avoid shadowing.
8ff096c1 11811
e2be39f6
PE
11812 * xfont.c (xfont_list_family): Mark var as initialized.
11813
c9735e30
PE
11814 * xml.c (make_dom): Now static.
11815
8f5201ae
PE
11816 * composite.c (composition_compute_stop_pos): Rename local to
11817 avoid shadowing.
b246f932
PE
11818 (composition_reseat_it): Remove unused locals.
11819 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11820 (composition_update_it): Mark var as initialized.
11b61122
PE
11821 (find_automatic_composition): Mark vars as initialized,
11822 with a FIXME (Bug#8290).
8f5201ae 11823
760fbc2c
PE
11824 character.h: Rename locals to avoid shadowing.
11825 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11826 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11827 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11828 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11829 to avoid shadowing.
11830
ff08eb85
PE
11831 * textprop.c (property_change_between_p): Remove; unused.
11832
fc7bf025
PE
11833 * intervals.c (interval_start_pos): Now static.
11834
235d7abc
PE
11835 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11836
44f230aa
SM
11837 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11838 Rename locals to avoid shadowing.
3e7d6594 11839
50060332
PE
11840 * sound.c (wav_play, au_play, Fplay_sound_internal):
11841 Fix pointer signedness.
d01f234b 11842 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11843 (wav_play): Initialize a variable to 0, to prevent undefined
11844 behavior (Bug#8278).
50060332 11845
c4fc4e30
PE
11846 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11847
918436ed
PE
11848 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11849
c939f91b
PE
11850 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11851 clobbering (Bug#8298).
b9c7f648
PE
11852 * sysdep.c (sys_subshell): Likewise.
11853 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11854
6bd8c144
PE
11855 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11856 This should get cleaned up, so that child_setup has the
11857 same signature on all platforms.
11858
7710357c 11859 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11860 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11861
c59da222
CY
118622011-03-22 Chong Yidong <cyd@stupidchicken.com>
11863
11864 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11865 not to be necessary, and produces flickering.
11866
66b87493
GM
118672011-03-20 Glenn Morris <rgm@gnu.org>
11868
11869 * config.in: Remove file.
11870
45b6f6d5
JB
118712011-03-20 Juanma Barranquero <lekktu@gmail.com>
11872
11873 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11874 are now in src/globals.h.
11875 (syms_of_minibuf): Remove spurious & from previous change.
11876
cd394be1 118772011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11878
11879 * minibuf.c (completing-read-function): New variable.
11880 (completing-read-default): Rename from completing-read.
11881 (completing-read): Call completing-read-function.
11882
b14e3e21
CY
118832011-03-19 Juanma Barranquero <lekktu@gmail.com>
11884
11885 * xfaces.c (Fx_load_color_file):
11886 Read color file from absolute filename (bug#8250).
11887
f2b726e6
JB
118882011-03-19 Juanma Barranquero <lekktu@gmail.com>
11889
11890 * makefile.w32-in: Update dependencies.
11891
09f6ff02
EZ
118922011-03-17 Eli Zaretskii <eliz@gnu.org>
11893
11894 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11895
29a6015a
PE
118962011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11897
a3a6c54e
PE
11898 Fix more problems found by GCC 4.5.2's static checks.
11899
b766f867
PE
11900 * process.c (make_serial_process_unwind, send_process_trap):
11901 (sigchld_handler): Now static.
11902
be02381c
PE
11903 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11904 That way, the code declares only the vars that it needs.
11905 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11906 * s/cygwin.h (PTY_ITERATION): Likewise.
11907 * s/darwin.h (PTY_ITERATION): Likewise.
11908 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11909
57048744
PE
11910 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11911 * process.c (allocate_pty): Don't declare stb unless it's needed.
11912
7914961c 11913 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11914 (CONSTANTLIM): Remove; unused.
11915 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11916 Define only if needed.
7914961c 11917
b3967b18
PE
11918 * unexelf.c (unexec): Name an expression,
11919 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11920 Use a different way to cause a compilation error if anyone uses
11921 n rather than nn, a way that does not involve shadowing.
73366a00 11922 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11923
29a6015a
PE
11924 * deps.mk (unexalpha.o): Remove; unused.
11925
43cfc33e 11926 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11927 * unexec.h: New file.
ce701a33
PE
11928 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11929 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11930 Depend on unexec.h.
11931 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11932 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11933 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11934 Change as necessary to match prototype in unexec.h.
ce701a33 11935
01f44d5a
PE
11936 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11937 shadowing.
4f63c6bb 11938 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11939
a6670b0b
PE
11940 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11941 Rename locals to avoid shadowing.
11942
cef2010d 11943 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11944 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11945
d4d7173a
PE
11946 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11947
f08b802a
PE
11948 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11949 warning when compiling print.c.
11950
3ddb0639
PE
11951 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11952 instead of using an uninitialized var.
5ad03b97 11953 (font_sort_entities): Mark var as initialized.
3ddb0639 11954
170a2692
PE
11955 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11956
e663c700
PE
11957 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11958 pointers to constants.
89bc529a 11959 (font_parse_fcname): Remove unused vars.
7b81e2d0 11960 (font_delete_unmatched): Now static.
ea838e10 11961 (font_get_spec): Remove; unused.
13a547c6
PE
11962 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11963 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11964 Rename or move locals to avoid shadowing.
e663c700 11965
2a80c887 11966 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11967 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11968
1384fa33 11969 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11970 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11971
8b2c52e9
PE
11972 * alloc.c (mark_backtrace): Move decl from here ...
11973 * lisp.h: ... to here, so that it can be checked.
11974
475545b5 11975 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11976 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11977 (lisp_indirect_variable): Name an expression,
11978 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11979 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11980
b1349114 11981 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11982 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11983 Use const pointer when appropriate.
b1349114 11984
a2928364
PE
11985 * lisp.h (get_system_name, get_operating_system_release):
11986 Move decls here, to check interfaces.
11987 * process.c (get_operating_system_release): Move decl to lisp.h.
11988 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11989 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11990 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11991 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11992 (Fformat_time_string, Fencode_time, Finsert_char):
11993 (Ftranslate_region_internal, Fformat):
11994 Rename or remove local vars to avoid shadowing.
9710023e 11995 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11996
a415e694
PE
11997 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11998 avoid shadowing.
11999
8ef4622d
PE
12000 * lisp.h (eassert): Check that the argument compiles, even if
12001 ENABLE_CHECKING is not defined.
12002
946f9a5b
PE
12003 * data.c (Findirect_variable): Name an expression, to avoid
12004 gcc -Wbad-function-cast warning.
112396d6 12005 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12006 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12007 (Fmake_variable_buffer_local, Fmake_local_variable):
12008 Mark variables as initialized.
52746918 12009 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12010
e5aab7e7 12011 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12012 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12013 Rename locals to avoid shadowing.
dff45157
PE
12014 (mark_stack): Move local variables into the #ifdef region where
12015 they're used.
7bc26fdb
PE
12016 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12017 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12018 needed otherwise.
12019 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12020 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12021 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12022
e5aab7e7
PE
12023 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12024 avoids undefined behavior in theory.
12025
4da60324
PE
12026 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12027
88043301
PE
12028 Use functions, not macros, for up- and down-casing (Bug#8254).
12029 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12030 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12031 to use the following functions instead of these macros.
12032 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12033 EMACS_INT, since callers assume the returned value fits in int.
12034 (upcase1): Likewise, for UPCASE_TABLE.
12035 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12036 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12037 the race-condition problem in the old DOWNCASE.
88043301 12038
19ed5445
PE
12039 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12040 Rename locals to avoid shadowing.
12041 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12042 (regex_compile, re_search_2, re_match_2_internal):
12043 Remove unused local vars.
952db0d7
PE
12044 (FREE_VAR): Rewrite so as not to use empty "else",
12045 which gcc can warn about.
da053e48 12046 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12047 (RETALLOC_IF): Define only if needed.
12048 (WORDCHAR_P): Likewise. This one is never needed, but is used
12049 only in a comment talking about a compiler bug, so put inside
12050 the #if 0 of that comment.
12051 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12052 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12053 Remove; unused.
19ed5445 12054
1f3561e4 12055 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12056 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12057 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12058
ded6f8f7
PE
12059 * search.c (simple_search): Remove unused var.
12060
dbd37a95
PE
12061 * dired.c (compile_pattern): Move decl from here ...
12062 * lisp.h: ... to here, so that it can be checked.
12063 (struct re_registers): New forward decl.
12064
7e47afad
PE
12065 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12066
85f24f61
PE
12067 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12068 All uses changed.
12069 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12070 Rename locals to avoid shadowing.
5671df8f 12071 (Fvertical_motion): Mark locals as initialized.
85f24f61 12072
181aa2be 12073 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12074 (casify_region): Mark local as initialized.
181aa2be 12075
930d429c
PE
12076 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12077
7082eac6
PE
12078 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12079 New macros, so that the caller can use some names other than
12080 gcpro1, gcpro2, etc.
12081 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12082 of the new macros.
12083 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12084 argument, for consistency with GCPRO2_VAR, etc: it is now the
12085 prefix of the variable, not the variable itself. All uses
12086 changed.
38b2c076
PE
12087 * dired.c (directory_files_internal, file_name_completion):
12088 Rename locals to avoid shadowing.
12089
15206ed9
PE
12090 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12091 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12092 dired.c's scmp function, had undefined behavior.
12093 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12094 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12095 * buffer.h: ... to here, because these macros use current_buffer,
12096 and the new implementation with inline functions needs to have
12097 current_buffer in scope now, rather than later when the macros
12098 are used.
12099 (downcase, upcase1): New static inline functions.
12100 (DOWNCASE, UPCASE1): Reimplement using these functions.
12101 This avoids undefined behavior in expressions like
12102 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12103 from race conditions in accessing the global variables
12104 case_temp1 and case_temp2.
12105 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12106 * lisp.h (case_temp1, case_temp2): Remove their decls.
12107 * character.h (ASCII_CHAR_P): Move from here ...
12108 * lisp.h: ... to here, so that the inline functions mentioned
12109 above can use them.
12110
4a6bea26
PE
12111 * dired.c (directory_files_internal_unwind): Now static.
12112
f14b7e14
PE
12113 * fileio.c (file_name_as_directory, directory_file_name):
12114 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12115 Now static.
2893f146
PE
12116 (file_name_as_directory): Use const pointers when appropriate.
12117 (Fexpand_file_name): Likewise. In particular, newdir might
12118 point at constant storage, so make it a const pointer.
fd4ead52 12119 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12120 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12121 signedness issues.
f839df0c
PE
12122 (Fset_file_times, Finsert_file_contents, auto_save_error):
12123 Rename locals to avoid shadowing.
f14b7e14 12124
5716756e 12125 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12126 (Ftry_completion, Fall_completions): Rename or remove locals
12127 to avoid shadowing.
5716756e 12128
b4c3046a
PE
12129 * marker.c (bytepos_to_charpos): Remove; unused.
12130
b45db522
PE
12131 * lisp.h (verify_bytepos, count_markers): New decls,
12132 so that gcc does not warn that these functions aren't declared.
12133
85876d07
PE
12134 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12135 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12136 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12137 (copy_text): Remove unused local var.
85876d07 12138
03d78a21 12139 * filelock.c (within_one_second): Now static.
b3dd38ab 12140 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12141
5df8f01b
PE
12142 * buffer.c (fix_overlays_before): Mark locals as initialized.
12143 (fix_start_end_in_overlays): Likewise. This function should be
12144 simplified by using pointers-to-pointers, but that's a different
12145 matter.
b1d876f1 12146 (switch_to_buffer_1): Now static.
8f54f30a
PE
12147 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12148 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12149
a70072c9 12150 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12151 Fix pointer signedness issue.
edced198
PE
12152 (sys_subshell): Mark local as volatile if checking for lint,
12153 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12154 (MAXPATHLEN): Define only if needed.
a70072c9 12155
a0977c44
PE
12156 * process.c (serial_open, serial_configure): Move decls from here ...
12157 * systty.h: ... to here, so that they can be checked.
12158
a884fdcc
PE
12159 * fns.c (get_random, seed_random): Move extern decls from here ...
12160 * lisp.h: ... to here, so that they can be checked.
12161
604efe86 12162 * sysdep.c (reset_io): Now static.
b8950c94 12163 (wait_for_termination_signal): Remove; unused.
604efe86 12164
38fc62d9
PE
12165 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12166 (copy_keymap_item, append_key, push_text_char_description):
12167 Now static.
1004a21a 12168 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12169 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12170 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12171 (describe_map_tree):
12172 Rename locals to avoid shadowing.
38fc62d9 12173
2f2650da
PE
12174 * keyboard.c: Declare functions static if they are not used elsewhere.
12175 (echo_char, echo_dash, cmd_error, top_level_2):
12176 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12177 (read_char, kbd_buffer_get_event, make_lispy_position):
12178 (make_lispy_event, make_lispy_movement, apply_modifiers):
12179 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12180 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12181 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12182 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12183 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12184
a053e86c 12185 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12186 (mark_kboards): Move decl here ...
12187 * alloc.c (mark_kboards): ... from here.
a053e86c 12188
4752793e
PE
12189 * lisp.h (force_auto_save_soon): New decl.
12190
74f10ca7 12191 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12192 (DEFINE_DUMMY_FUNCTION): New macro.
12193 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12194 Use it.
c03cd23f
PE
12195 (main): Add casts to avoid warnings
12196 if GCC considers string literals to be constants.
74f10ca7 12197
022e70d4
PE
12198 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12199
59d6fe83
PE
12200 * dbusbind.c: Pointer signedness fixes.
12201 (xd_signature, xd_append_arg, xd_initialize):
12202 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12203 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12204 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12205 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12206
78320123
PE
12207 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12208 if GCC considers string literals to be constants.
49cebcca 12209 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12210
35ac2a97
SM
122112011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12212
fb103ca9
SM
12213 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12214 (print_preprocess, print_object): New macro to fix last change.
12215
35ac2a97
SM
12216 * print.c (print_preprocess): Don't forget font objects.
12217
62973b41
JB
122182011-03-16 Juanma Barranquero <lekktu@gmail.com>
12219
12220 * emacs.c (USAGE3): Doc fixes.
12221
0e48bb22
AS
122222011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12223
12224 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12225 structure.
12226
7684e57b
JB
122272011-03-14 Juanma Barranquero <lekktu@gmail.com>
12228
12229 * lisp.h (VWindow_system, Qfile_name_history):
12230 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12231 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12232 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12233
12234 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12235 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12236
12237 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12238 * w32console.c (detect_input_pending, read_input_pending)
12239 (encode_terminal_code):
12240 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12241 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12242 (w32_system_caret_y, Qfile_name_history):
12243 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12244 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12245 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12246 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12247 * w32proc.c (Qlocal, report_file_error):
12248 * w32term.c (Vwindow_system, updating_frame):
12249 * w32uniscribe.c (initialized, uniscribe_font_driver):
12250 Remove unneeded extern declarations.
12251
2aa46d6c
CY
122522011-03-14 Chong Yidong <cyd@stupidchicken.com>
12253
c96bbc66 12254 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12255
cffc6f3b
CY
122562011-03-13 Chong Yidong <cyd@stupidchicken.com>
12257
12258 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12259 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12260 These macros can no longer be used for assignment.
12261
44f230aa
SM
12262 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12263 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12264 (record_buffer_markers, fetch_buffer_markers): New functions for
12265 recording and fetching special buffer markers.
12266 (set_buffer_internal_1, set_buffer_temp): Use them.
12267
12268 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12269
12270 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12271
12272 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12273 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12274
12275 * xdisp.c (hscroll_window_tree):
12276 (reconsider_clip_changes): Use PT instead of BUF_PT.
12277
d251f04b
EZ
122782011-03-13 Eli Zaretskii <eliz@gnu.org>
12279
12280 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12281 $(EMACS_ROOT)/lib/intprops.h.
12282
f0c77cd1
PE
122832011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12284
3eca4629
PE
12285 Fix more problems found by GCC 4.5.2's static checks.
12286
7c86ee98
PE
12287 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12288 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12289 (xg_free_frame_widgets): Make it clear that a local variable is
12290 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12291 (gdk_window_get_screen): Make it clear that this macro is needed
12292 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12293 (int_gtk_range_get_value): New function, which avoids a diagnostic
12294 from gcc -Wbad-function-cast.
12295 (xg_set_toolkit_scroll_bar_thumb): Use it.
12296 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12297 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12298 (get_utf8_string, xg_get_file_with_chooser):
12299 Rename locals to avoid shadowing.
12300 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12301
41729b81
PE
12302 * xgselect.c (xg_select): Remove unused var.
12303
f0c77cd1
PE
12304 * image.c (four_corners_best): Mark locals as initialized.
12305 (gif_load): Initialize transparent_p to zero (Bug#8238).
12306 Mark another local as initialized.
ec6cf4c6 12307 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12308
ce0ad53d 12309 * image.c (clear_image_cache): Now static.
d5d5a617 12310 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12311 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12312 (x_edge_detection): Remove unnecessary cast that
12313 gcc -Wbad-function-cast diagnoses.
2037898d 12314 (gif_load): Fix pointer signedness.
6ae141d6
PE
12315 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12316 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12317
33383987 123182011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12319
d32df629
PE
12320 Improve quality of tests for time stamp overflow.
12321 For example, without this patch (encode-time 0 0 0 1 1
12322 1152921504606846976) returns the obviously-bogus value (-948597
12323 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12324 reports time overflow. See
12325 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12326 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12327 * editfns.c: Include limits.h and intprops.h.
12328 (TIME_T_MIN, TIME_T_MAX): New macros.
12329 (time_overflow): Move earlier, to before first use.
12330 (hi_time, lo_time): New functions, for an accurate test for
12331 out-of-range times.
12332 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12333 (Fget_internal_run_time): Don't assume time_t fits in int.
12334 (make_time): Use list2 instead of Fcons twice.
12335 (Fdecode_time): More accurate test for out-of-range times.
12336 (check_tm_member): New function.
12337 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12338 (lisp_time_argument): Don't rely on undefined left-shift and
12339 right-shift behavior when checking for time stamp overflow.
8be6f318 12340
fe31d94c
PE
12341 * editfns.c (time_overflow): New function, refactoring common code.
12342 (Fformat_time_string, Fdecode_time, Fencode_time):
12343 (Fcurrent_time_string): Use it.
12344
8be6f318
PE
12345 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12346 * dired.c (make_time): Move to ...
12347 * editfns.c (make_time): ... here.
12348 * systime.h: Note the move.
12349
09d9db2c 123502011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12351
126bc0dc
YM
12352 * fringe.c (update_window_fringes): Remove unused variables.
12353
c47cbdfd
YM
12354 * unexmacosx.c (copy_data_segment): Also copy __got section.
12355 (Bug#8223)
12356
7ac80be9
EZ
123572011-03-12 Eli Zaretskii <eliz@gnu.org>
12358
c96bbc66 12359 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12360 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12361 Constify `char *' arguments and their references according to
12362 prototypes in tparam.h.
12363
ecb0f94d 12364 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12365
7ac80be9
EZ
12366 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12367 Adapt all references accordingly.
12368
12369 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12370
ef1fd07e
TT
123712011-03-11 Tom Tromey <tromey@redhat.com>
12372
12373 * buffer.c (syms_of_buffer): Remove obsolete comment.
12374
7ef4b50c
EZ
123752011-03-11 Eli Zaretskii <eliz@gnu.org>
12376
12377 * termhooks.h (encode_terminal_code): Declare prototype.
12378
12379 * msdos.c (encode_terminal_code): Don't declare prototype.
12380
12381 * term.c (encode_terminal_code): Now external again, used by
12382 w32console.c and msdos.c.
12383
44f230aa
SM
12384 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12385 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12386
4b1ec863 123872011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12388
1714f52b 12389 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12390
4b1ec863
PE
12391 * fringe.c (update_window_fringes): Mark locals as initialized
12392 (Bug#8227).
12393 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12394
524c7aa6
PE
12395 * alloc.c (mark_fringe_data): Move decl from here ...
12396 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12397 to check its interface.
12398 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12399
a5c0af81 12400 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12401 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12402 (fontset_font): Mark local as initialized.
a9a06e0b 12403 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12404
b4716021
PE
12405 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12406
811e9bac 12407 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12408 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12409 (x_own_selection, Fx_disown_selection_internal): Rename locals
12410 to avoid shadowing.
12411 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12412
7e3ab302
PE
12413 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12414 so that the caller can use some name other than gcpro1.
12415 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12416 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12417 (Fx_backspace_delete_keys_p):
12418 Use them to avoid shadowing, and rename vars to avoid shadowing.
12419 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12420 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12421 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12422 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12423 Remove unused locals.
7e3ab302
PE
12424 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12425 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12426 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12427 macros.
f78faa98 12428
e2b13473
PE
12429 * xterm.h (x_mouse_leave): New decl.
12430
77f23912
PE
12431 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12432 Remove unused functions.
cdf4ba58
PE
12433 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12434 (x_calc_absolute_position): Now static.
7411c686 12435 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12436 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12437 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12438 unless they are used.
38d0b34a
PE
12439 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12440 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12441 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12442 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12443 (x_error_catcher, x_connection_closed, x_error_handler):
12444 (x_error_quitter, xembed_send_message, x_iconify_frame):
12445 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12446 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12447 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12448
44f230aa
SM
12449 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12450 Rename or move locals to avoid shadowing.
6b463e58 12451 (tty_defined_color, merge_face_heights): Now static.
5967d051 12452 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12453 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12454 does not deduce is never used uninitialized.
73719eba
PE
12455 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12456 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12457
426994c3 12458 * terminal.c (store_terminal_param): Now static.
5489860b 12459
032f1620 12460 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12461 (set_frame_menubar): Remove unused local.
d4323972 12462 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12463 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12464 since they might point to immutable storage.
281585b0
PE
12465 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12466 since it's unused otherwise.
032f1620 12467
367c19e5 12468 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12469 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12470 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12471 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12472 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12473 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12474 does not deduce are never used uninitialized.
70739cbe 12475
07b48fa9
PE
12476 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12477
8868a238 12478 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12479 * window.c (window_loop, size_window):
12480 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12481
7e5cf297 12482 * window.c (display_buffer): Now static.
d6550a9f
PE
12483 (size_window): Mark variables that gcc -Wuninitialized
12484 does not deduce are never used uninitialized.
a586633d
PE
12485 * window.h (check_all_windows): New decl, to forestall
12486 gcc -Wmissing-prototypes diagnostic.
5b555da1 12487 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12488
f6095868
PE
12489 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12490 shadowing.
12491 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12492 Include <limits.h>.
12493 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12494 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12495 (load_charset_map): Mark variables that gcc -Wuninitialized
12496 does not deduce are never used uninitialized.
53df7c11 12497 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12498
f38b440c
PE
12499 * coding.c (coding_set_source, coding_set_destination):
12500 Use "else { /* comment */ }" rather than "else /* comment */;"
12501 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12502 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12503 a block, when the outer 'i' will do.
12504 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12505 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12506 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12507 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12508 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12509 Rename locals to avoid shadowing.
12510 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12511 * coding.c (emacs_mule_char, encode_invocation_designation):
12512 Now static, since they're not used elsewhere.
413bb2db 12513 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12514 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12515 (decode_coding_emacs_mule): Mark variables that gcc
12516 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12517 (detect_coding_iso_2022): Initialize a local variable that might
12518 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12519 this initialization is needed. (Bug#8211)
5f58e762
PE
12520 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12521 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12522 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12523 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12524 Remove unused macros.
f38b440c 12525
232b38b9 12526 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12527 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12528 * character.c (string_count_byte8): Likewise.
232b38b9 12529
fb90da1b
PE
12530 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12531 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12532
fb93dbc2
PE
12533 * chartab.c (copy_sub_char_table): Now static, since it's not used
12534 elsewhere.
5c156ace
PE
12535 (sub_char_table_ref_and_range, char_table_ref_and_range):
12536 Rename locals to avoid shadowing.
bbcd0949 12537 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12538
7d3b3862 12539 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12540 (BIDI_BOB): Remove unused macro.
7d3b3862 12541
6be7d3da
PE
12542 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12543 deduce are never used uninitialized.
c2ed9c8b 12544 * term.c (encode_terminal_code): Likewise.
6be7d3da 12545
75f8807f 12546 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12547
50938595
PE
12548 * tparam.h: New file.
12549 * term.c, tparam.h: Include it.
12550 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12551 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12552 Move these decls to tparam.h, and make them agree with what
12553 is actually in tparam.c. The previous trick of using incompatible
12554 decls in different modules does not conform to the C standard.
12555 All callers of tparam changed to use tparam's actual API.
12556 * tparam.c (tparam1, tparam, tgoto):
12557 Use const pointers where appropriate.
12558
fbceeba2
PE
12559 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12560 * cm.h (struct cm): Likewise.
12561 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12562 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12563 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12564 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12565 (turn_on_face, init_tty): Likewise.
12566 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12567
7f3f1250
PE
12568 * term.c (term_mouse_position): Rename local to avoid shadowing.
12569
e6ca6543
PE
12570 * alloc.c (mark_ttys): Move decl from here ...
12571 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12572
c40f8d15
AS
125732011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12574
12575 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12576
cfe0661d
JB
125772011-03-09 Juanma Barranquero <lekktu@gmail.com>
12578
12579 * search.c (compile_pattern_1): Remove argument regp, unused since
12580 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12581 (compile_pattern): Don't pass it.
12582
0afb4571
J
125832011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12584
12585 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12586 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12587 for ! HAVE_GTK3.
12588 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12589
12590 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12591
12592 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12593 gdk_window_get_screen, gdk_window_get_geometry,
12594 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12595 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12596 (xg_get_pixbuf_from_pixmap): New function.
12597 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12598 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12599 Call xg_get_pixbuf_from_pixmap instead of
12600 gdk_pixbuf_get_from_drawable.
12601 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12602 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12603 (xg_check_special_colors): Use GtkStyleContext and its functions
12604 for HAVE_GTK3.
12605 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12606 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12607 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12608 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12609 Call gtk_widget_get_preferred_size.
0afb4571
J
12610 (xg_frame_resized): gdk_window_get_geometry only takes 5
12611 parameters.
44f230aa
SM
12612 (xg_win_to_widget, xg_event_is_for_menubar):
12613 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12614 (xg_set_widget_bg): New function.
12615 (delete_cb): New function.
895009e1 12616 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12617 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12618 (xg_set_background_color): Call xg_set_widget_bg.
12619 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12620 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12621 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12622 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12623 if ! HAVE_GTK3.
12624 (update_frame_tool_bar): Call gtk_widget_hide.
12625 (xg_initialize): Use GDK_KEY_g.
12626
12627 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12628 if ! HAVE_GTK3
12629 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12630
12631 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12632 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12633 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12634
1c2cc4ef
JB
126352011-03-08 Juanma Barranquero <lekktu@gmail.com>
12636
12637 * w32xfns.c (select_palette): Check success of RealizePalette against
12638 GDI_ERROR, not zero.
12639
33383987 12640See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12641
12642;; Local Variables:
12643;; coding: utf-8
aac0c6e3
MR
12644;; End:
12645
2f097256 12646 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12647
12648 This file is part of GNU Emacs.
12649
12650 GNU Emacs is free software: you can redistribute it and/or modify
12651 it under the terms of the GNU General Public License as published by
12652 the Free Software Foundation, either version 3 of the License, or
12653 (at your option) any later version.
12654
12655 GNU Emacs is distributed in the hope that it will be useful,
12656 but WITHOUT ANY WARRANTY; without even the implied warranty of
12657 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12658 GNU General Public License for more details.
12659
12660 You should have received a copy of the GNU General Public License
12661 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.