* fns.c (concat): Catch string overflow earlier.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e39e811e
PE
12011-06-18 Paul Eggert <eggert@cs.ucla.edu>
2
a498d7f4
PE
3 * fns.c (concat): Catch string overflow earlier.
4 Do not rely on integer wraparound.
5
e39e811e
PE
6 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
7
fadf4e30
PE
82011-06-17 Paul Eggert <eggert@cs.ucla.edu>
9
87830974
PE
10 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
11 * xdisp.c (forward_to_next_line_start)
12 (back_to_previous_visible_line_start)
13 (reseat_at_next_visible_line_start, next_element_from_buffer):
14 Don't arbitrarily truncate the value of 'selective' to int.
15
76031fad
PE
16 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
17
5eb55db9
PE
18 * composite.c: Don't truncate sizes to 'int'.
19 (composition_gstring_p, composition_reseat_it)
20 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
21 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
22 not EMACS_UINT, for indexes.
5eb55db9 23
0703a717
PE
24 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
25
d6202519
PE
26 * buffer.c: Include <verify.h>.
27 (struct sortvec.priority, struct sortstr.priority):
8961a454 28 Now EMACS_INT, not int.
c20998a7 29 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
30 (struct sortstr.size, record_overlay_string)
31 (struct sortstrlist.size, struct sortlist.used):
32 Don't truncate size to int.
33 (record_overlay_string): Check for size-calculation overflow.
d6202519 34 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 35
28177add
PE
362011-06-16 Paul Eggert <eggert@cs.ucla.edu>
37
dd3482fe
PE
38 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
39 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
40 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
41
393d71f3 42 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
43 * fileio.c (Finsert_file_contents):
44 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
45 Remove the old (too-loose) buffer overflow checks.
46 They weren't needed, since make_gap checks for buffer overflow.
47 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
48 The old code merely checked for Emacs fixnum overflow, and relied
49 on undefined (wraparound) behavior. The new code avoids undefined
50 behavior, and also checks for ptrdiff_t and/or size_t overflow.
51
2e6813b0 52 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
53 Tune. Don't use wider integers than needed. Don't use alloca.
54 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 55
599a9e4f
PE
56 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
57
99561444
PE
58 * insdel.c, lisp.h (buffer_overflow): New function.
59 (insert_from_buffer_1, replace_range, replace_range_2):
60 * insdel.c (make_gap_larger):
61 * editfns.c (Finsert_char):
62 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
63
28177add
PE
64 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
65
e69dafad
PE
662011-06-15 Paul Eggert <eggert@cs.ucla.edu>
67
a7af7fde 68 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 69
b1c46f02
PE
70 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
71 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
72
e69dafad
PE
73 * fileio.c: Don't assume EMACS_INT fits in off_t.
74 (emacs_lseek): New static function.
75 (Finsert_file_contents, Fwrite_region): Use it.
76 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
77
566684ea
PE
78 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
79
e6966cd6
PE
80 * fns.c: Don't overflow int when computing a list length.
81 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
82 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
83 truncation on 64-bit hosts. Check for QUIT every
84 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
85 faster and is responsive enough.
86 (Flength): Report an error instead of overflowing an integer.
87 (Fsafe_length): Return a float if the value is not representable
88 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 89 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 90 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 91
dd0b0efb
PE
92 * alloc.c: Check that resized vectors' lengths fit in fixnums.
93 (header_size, word_size): New constants.
94 (allocate_vectorlike): Don't check size overflow here.
95 (allocate_vector): Check it here instead, since this is the only
96 caller of allocate_vectorlike that could cause overflow.
97 Check that the new vector's length is representable as a fixnum.
98
86fe5cfe
PE
99 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
100 The previous code was bogus. For example, next_almost_prime (32)
101 returned 39, which is undesirable as it is a multiple of 3; and
102 next_almost_prime (24) returned 25, which is a multiple of 5 so
103 why was the code bothering to check for multiples of 7?
104
80e88859
PE
105 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
106
4a2f0ad6
PE
107 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
108
f66c7cf8
PE
109 Variadic C functions now count arguments with ptrdiff_t.
110 This partly undoes my 2011-03-30 change, which replaced int with size_t.
111 Back then I didn't know that the Emacs coding style prefers signed int.
112 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
113 were being counted with int, which may truncate counts on 64-bit
114 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
115 * lisp.h (struct Lisp_Subr.function.aMANY)
116 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
117 Arg counts are now ptrdiff_t, not size_t.
118 All variadic functions and their callers changed accordingly.
119 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
120 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
121 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
122 * callint.c (Fcall_interactively): Check arg count for overflow,
123 to avoid potential buffer overrun. Use signed char, not 'int',
124 for 'varies' array, so that we needn't bother to check its size
125 calculation for overflow.
126 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
127 * eval.c (apply_lambda):
128 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
129 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
130 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
131
a1759b76
PE
132 * callint.c (Fcall_interactively): Don't use index var as event count.
133
d96be9fc
PE
134 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
135 * mem-limits.h (SIZE): Remove; no longer used.
136
a690a978 137 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 138
578c21e6
PE
139 Remove unnecessary casts.
140 * xterm.c (x_term_init):
141 * xfns.c (x_set_border_pixel):
142 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
143 These aren't needed now that we assume ANSI C.
144
96f53c6c
PE
145 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
146 It's more likely to cause problems (due to unsigned overflow)
147 than to cure them.
148
83c77d31
PE
149 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
150
ee2079f1
PE
151 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
152
6da65536
PE
153 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
154
7147c4a4
PE
155 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
156
193e32d9
PE
157 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
158
e5533da6
PE
159 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
160
9910e595
PE
161 GLYPH_CODE_FACE returns EMACS_INT, not int.
162 * dispextern.h (merge_faces):
163 * xfaces.c (merge_faces):
01103c44
PE
164 * xdisp.c (get_next_display_element, next_element_from_display_vector):
165 Don't assume EMACS_INT fits in int.
9910e595 166
2638320e
PE
167 * character.h (CHAR_VALID_P): Remove unused parameter.
168 * fontset.c, lisp.h, xdisp.c: All uses changed.
169
045eb8d9
PE
170 * editfns.c (Ftranslate_region_internal): Omit redundant test.
171
c1f134b5
PE
172 * fns.c (concat): Minor tuning based on overflow analysis.
173 This doesn't fix any bugs. Use int to hold character, instead
174 of constantly refetching from Emacs object. Use XFASTINT, not
175 XINT, for value known to be a character. Don't bother comparing
176 a single byte to 0400, as it's always less.
177
395fcb93 178 * floatfns.c (Fexpt):
327eeec8
PE
179 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
180
abbd3d23
PE
181 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
182 for characters.
183
684a03ef
PE
184 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
185
0fed43f3
PE
186 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
187 Without this fix, on a 64-bit host (aset S 0 4294967386) would
188 incorrectly succeed when S was a string, because 4294967386 was
189 truncated before it was used.
190
8fd02eb7
PE
191 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
192 Otherwise, an out-of-range integer could cause undefined behavior
193 on a 64-bit host.
194
f8c86b69
PE
195 * composite.c: Use int, not EMACS_INT, for characters.
196 (fill_gstring_body, composition_compute_stop_pos): Use int, not
197 EMACS_INT, for values that are known to be in character range.
198 This doesn't fix any bugs but is the usual style inside Emacs and
199 may generate better code on 32-bit machines.
200
34206dd2
PE
201 Make sure a 64-bit char is never passed to ENCODE_CHAR.
202 This is for reasons similar to the recent CHAR_STRING fix.
203 * charset.c (Fencode_char): Check that character arg is actually
204 a character. Pass an int to ENCODE_CHAR.
205 * charset.h (ENCODE_CHAR): Verify that the character argument is no
206 wider than 'int', as a compile-time check to prevent future regressions
207 in this area.
208
c5958d4c 209 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
210
211 Make sure a 64-bit char is never passed to CHAR_STRING.
212 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
213 by silently ignoring the top 32 bits, allowing some values
214 that were far too large to be valid characters.
215 * character.h: Include <verify.h>.
216 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
217 arguments are no wider than unsigned, as a compile-time check
218 to prevent future regressions in this area.
219 * data.c (Faset):
01103c44 220 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
221 (Fsubst_char_in_region):
222 * fns.c (concat):
223 * xdisp.c (decode_mode_spec_coding):
224 Adjust to CHAR_STRING's new requirement.
225 * editfns.c (Finsert_char, Fsubst_char_in_region):
226 * fns.c (concat): Check that character args are actually
227 characters. Without this test, these functions did the wrong
228 thing with wildly out-of-range values on 64-bit hosts.
229
d37ca623
PE
230 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
231 These casts should not be needed on 32-bit hosts, either.
232 * keyboard.c (read_char):
233 * lread.c (Fload): Remove casts to unsigned.
234
ea204efb
PE
235 * lisp.h (UNSIGNED_CMP): New macro.
236 This fixes comparison bugs on 64-bit hosts.
237 (ASCII_CHAR_P): Use it.
238 * casefiddle.c (casify_object):
01103c44 239 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
240 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
241 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
242 * dispextern.h (FACE_FROM_ID):
243 * keyboard.c (read_char): Use UNSIGNED_CMP.
244
41cb286c
PE
245 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
246 not to EMACS_INT, to avoid GCC warning.
247
4a1b9832
PE
248 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
249
55daad71
PE
250 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
251 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
252 isn't needed on 32-bit machines.
8f95c75c 253
01103c44
PE
254 * buffer.c (Fgenerate_new_buffer_name):
255 Use EMACS_INT for count, not int.
0ceccced 256 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
257
258 * data.c (Qcompiled_function): Now static.
259
c6f072e7
PE
260 * window.c (window_body_lines): Now static.
261
20ce5912
PE
262 * image.c (gif_load): Rename local to avoid shadowing.
263
9c4c5f81
PE
264 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
265 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
266 * alloc.c (make_save_value): Integer argument is now of type
267 ptrdiff_t, not int.
268 (mark_object): Use ptrdiff_t, not int.
269 * lisp.h (pD): New macro.
270 * print.c (print_object): Use it.
271
c0c5c8ae
PE
272 * alloc.c: Use EMACS_INT, not int, to count objects.
273 (total_conses, total_markers, total_symbols, total_vector_size)
274 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
275 (total_free_floats, total_floats, total_free_intervals)
276 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
277 Now EMACS_INT, not int. All uses changed.
278 (Fgarbage_collect): Compute overall total using a double, so that
279 integer overflow is less likely to be a problem. Check for overflow
280 when converting back to an integer.
5a25e253
PE
281 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
282 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
283 These were 'int' variables that could overflow on 64-bit hosts;
284 they were never used, so remove them instead of repairing them.
211a0b2a 285 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
286 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
287 Previously, this ceilinged at INT_MAX, but that doesn't work on
288 64-bit machines.
e46bb31a 289 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 290
c78baabf 291 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 292 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
293 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
294 when a (possibly-narrower) signed value would do just as well.
295 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 296
c9d624c6
PE
297 * alloc.c: Catch some string size overflows that we were missing.
298 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
299 for convenience in STRING_BYTES_MAX.
300 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
301 The definition here is exact; the one in lisp.h was approximate.
302 (allocate_string_data): Check for string overflow. This catches
303 some instances we weren't catching before. Also, it catches
304 size_t overflow on (unusual) hosts where SIZE_MAX <= min
305 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
306 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 307
c9d624c6
PE
308 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
309 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
310 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
311
353032ce
PE
312 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
313
2bccce07
PE
314 * alloc.c (Fmake_string): Check for out-of-range init.
315
0ac30604
SM
3162011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
317
318 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
319
c195f2de
JD
3202011-06-14 Jan Djärv <jan.h.d@swipnet.se>
321
322 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
323 xg_get_default_scrollbar_width.
324
325 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
326 (int_gtk_range_get_value): Move to the scroll bar part of the file.
327 (style_changed_cb): Call update_theme_scrollbar_width and call
328 x_set_scroll_bar_default_width and xg_frame_set_char_size for
329 all frames (Bug#8505).
330 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
331 Call gtk_window_set_resizable if HAVE_GTK3.
332 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
333 and height if HAVE_GTK3 (Bug#8505).
334 (scroll_bar_width_for_theme): New variable.
335 (update_theme_scrollbar_width): New function.
336 (xg_get_default_scrollbar_width): Move code to
337 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
338 (xg_initialize): Call update_theme_scrollbar_width.
339
340 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
341
342 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
343
e10ac9f1
MR
3442011-06-12 Martin Rudalics <rudalics@gmx.at>
345
346 * frame.c (make_frame): Call other_buffer_safely instead of
347 other_buffer.
348
349 * window.c (temp_output_buffer_show): Call display_buffer with
350 second argument Vtemp_buffer_show_specifiers and reset latter
351 immediately after the call.
352 (Vtemp_buffer_show_specifiers): New variable.
353 (auto_window_vscroll_p, next_screen_context_lines)
354 (Vscroll_preserve_screen_position): Remove leading asterisks from
355 doc-strings.
356
2d3c217e 3572011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 358
7b7f97e8 359 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
360 * buffer.c (Qclone_number): Remove for now, as it's unused.
361 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
362 (record_buffer): Remove unused local.
363 * frame.c (other_visible_frames, frame_buffer_list): Now static.
364 (set_frame_buffer_list): Remove; unused.
365 * frame.h (other_visible_frames): Remove decl.
366 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
367 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
368 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
369 if HAVE_GPM.
370 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
371 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
372 Define only if HAVE_GPM.
373 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
374 (update_hints_inhibit): Remove; never set. All uses removed.
375 * widgetprv.h (emacsFrameClassRec): Remove decl.
376 * window.c (delete_deletable_window): Now returns void, since it
377 wasn't returning anything.
378 (compare_window_configurations): Remove unused locals.
379 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
380 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
381 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
382 the same widths as pointers. This follows up on the 2011-05-06 patch.
383 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
384 * xterm.h: Likewise.
385 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
386
1384b89e
JB
3872011-06-12 Juanma Barranquero <lekktu@gmail.com>
388
389 * makefile.w32-in: Update dependencies.
390 (LISP_H): Add lib/intprops.h.
391
1100a63c
CY
3922011-06-11 Chong Yidong <cyd@stupidchicken.com>
393
394 * image.c (gif_load): Add animation frame delay to the metadata.
395 (syms_of_image): Use DEFSYM. New symbol `delay'.
396
6198ccd0
MR
3972011-06-11 Martin Rudalics <rudalics@gmx.at>
398
399 * window.c (delete_deletable_window): Re-add.
400 (Fset_window_configuration): Rewrite to handle dead buffers and
401 consequently deletable windows.
402 (window_tree, Fwindow_tree): Remove. Supply functionality in
403 window.el.
404 (compare_window_configurations): Simplify code.
405
b6e3633c
AS
4062011-06-11 Andreas Schwab <schwab@linux-m68k.org>
407
1ab0dee5
AS
408 * image.c (imagemagick_load_image): Fix type mismatch.
409 (Fimagemagick_types): Likewise.
410
b6e3633c
AS
411 * window.h (replace_buffer_in_windows): Declare.
412
9397e56f
MR
4132011-06-11 Martin Rudalics <rudalics@gmx.at>
414
415 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
416 Qclone_number. Remove external declaration of Qdelete_window.
417 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
418 code.
419 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
420 Qbuffer_list_update_hook if allowed.
421 (Fother_buffer): Rewrite doc-string. Major rewrite for new
422 buffer list implementation.
423 (other_buffer_safely): New function.
424 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
425 calls to replace_buffer_in_windows and
426 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
427 if allowed.
428 (record_buffer): Inhibit quitting and rewrite using quittable
429 functions. Run Qbuffer_list_update_hook if allowed.
430 (Frecord_buffer, Funrecord_buffer): New functions.
431 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
432 switch-to-buffer to window.el.
433 (bury-buffer): Move to window.el.
434 (Vbuffer_list_update_hook): New variable.
435
436 * lisp.h (other_buffer_safely): Add prototype in buffer.c
437 section.
438
439 * window.h (resize_frame_windows): Move up in code.
440 (Fwindow_frame): Remove EXFUN.
441 (replace_buffer_in_all_windows): Remove prototype.
442 (replace_buffer_in_windows_safely): Add prototype.
443
444 * window.c: Declare Qdelete_window static again. Move down
445 declaration of select_count.
446 (Fnext_window, Fprevious_window): Rewrite doc-strings.
447 (Fother_window): Move to window.el.
448 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
449 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
450 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
451 window.el.
452 (replace_buffer_in_windows): Implement by calling
453 Qreplace_buffer_in_windows.
454 (replace_buffer_in_all_windows): Remove with some functionality
455 moved into replace_buffer_in_windows_safely.
456 (replace_buffer_in_windows_safely): New function.
457 (select_window_norecord, select_frame_norecord): Move in front
458 of run_window_configuration_change_hook. Remove now obsolete
459 declarations.
460 (Fset_window_buffer): Rewrite doc-string. Call
461 Qrecord_window_buffer.
462 (keys_of_window): Move binding for other-window to window.el.
463
b50691aa
CY
4642011-06-11 Chong Yidong <cyd@stupidchicken.com>
465
466 * dispextern.h (struct image): Replace data member, whose int_val
467 and ptr_val fields were not used by anything, with a single
468 lisp_val object.
469
470 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
471 (gif_clear_image, gif_load, imagemagick_load_image)
472 (gs_clear_image, gs_load): Callers changed.
473
3f754b86
PE
4742011-06-10 Paul Eggert <eggert@cs.ucla.edu>
475
cca69397
PE
476 * buffer.h: Include <time.h>, for time_t.
477 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
478
109e28d0
PE
479 Fix minor problems found by static checking.
480
60737f02
PE
481 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
482
4b66faf3
PE
483 Make identifiers static if they are not used in other modules.
484 * data.c (Qcompiled_function, Qframe, Qvector):
485 * image.c (QimageMagick, Qsvg):
486 * minibuf.c (Qmetadata):
487 * window.c (resize_window_check, resize_root_window): Now static.
488 * window.h (resize_window_check, resize_root_window): Remove decls.
489
109e28d0
PE
490 * window.c (window_deletion_count, delete_deletable_window):
491 Remove; unused.
46a4ce9e
PE
492 (window_body_lines): Now static.
493 (Fdelete_other_windows_internal): Mark vars as initialized.
494 Make sure 'resize_failed' is initialized.
495 (run_window_configuration_change_hook): Rename local to avoid shadowing.
496 (resize_window_apply): Remove unused local.
497 * window.h (delete_deletable_window): Remove decl.
498
109e28d0 499 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
500 (imagemagick_load_image): Fix pointer signedness problem by changing
501 last arg from unsigned char * to char *. All uses changed.
502 Also, fix a local for similar reasons.
503 Remove unused locals. Remove locals to avoid shadowing.
504 (fn_rsvg_handle_free): Remove; unused.
505 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 506 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 507
3f754b86
PE
508 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
509
2547adb1
CY
5102011-06-10 Chong Yidong <cyd@stupidchicken.com>
511
512 * image.c (gif_load): Fix omitted cast error introduced by
513 2011-06-06 change.
514
2c8e37d4
MR
5152011-06-10 Martin Rudalics <rudalics@gmx.at>
516
517 * window.h (resize_proportionally, orig_total_lines)
518 (orig_top_line): Remove from window structure.
519 (set_window_height, set_window_width, change_window_heights)
520 (Fdelete_window): Remove prototypes.
521 (resize_frame_windows): Remove duplicate declaration.
522
440a42e3
EZ
5232011-06-10 Eli Zaretskii <eliz@gnu.org>
524
525 * window.h (resize_frame_windows, resize_window_check)
526 (delete_deletable_window, resize_root_window)
527 (resize_frame_windows): Declare prototypes.
528
529 * window.c (resize_window_apply): Make definition be "static" to
530 match the prototype.
531
562dd5e9
MR
5322011-06-10 Martin Rudalics <rudalics@gmx.at>
533
534 * window.c: Remove declarations of Qwindow_size_fixed,
535 window_min_size_1, window_min_size_2, window_min_size,
536 size_window, window_fixed_size_p, enlarge_window, delete_window.
537 Remove static from declaration of Qdelete_window, it's
538 temporarily needed by Fbury_buffer.
539 (replace_window): Don't assign orig_top_line and
540 orig_total_lines.
541 (Fdelete_window, delete_window): Remove. Window deletion is
542 handled by window.el.
543 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
544 Fdelete_window calls with calls to Qdelete_window.
545 (Fdelete_other_windows): Remove. Deleting other windows is
546 handled by window.el.
547 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
548 handled in window.el.
549 (window_min_size_2, window_min_size_1, window_min_size): Remove.
550 Window minimum sizes are handled in window.el.
551 (shrink_windows, size_window, set_window_height)
552 (set_window_width, change_window_heights, window_height)
553 (window_width, CURBEG, CURSIZE, enlarge_window)
554 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
555 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
556 handled in window.el.
557 (make_dummy_parent): Rename to make_parent_window and give it a
558 second argument horflag.
559 (make_window): Don't set resize_proportionally any more.
560 (Fsplit_window): Remove. Windows are split in window.el.
561 (save_restore_action, save_restore_orig_size)
562 (shrink_window_lowest_first, save_restore_orig_size): Remove.
563 Resize mini windows in window.el.
564 (grow_mini_window, shrink_mini_window): Implement by calling
565 Qresize_root_window_vertically, resize_window_check and
566 resize_window_apply.
567 (saved_window, Fset_window_configuration, save_window_save): Do
568 not handle orig_top_line, orig_total_lines, and
569 resize_proportionally.
570 (window_min_height, window_min_width): Move to window.el.
571 (keys_of_window): Move bindings for delete-other-windows,
572 split-window, delete-window and enlarge-window to window.el.
573
574 * buffer.c: Temporarily extern Qdelete_window.
575 (Fbury_buffer): Temporarily call Qdelete_window instead of
576 Fdelete_window (Fbury_buffer will move to window.el soon).
577
578 * frame.c (set_menu_bar_lines_1): Remove code handling
579 orig_top_line and orig_total_lines.
580
581 * dispnew.c (adjust_frame_glyphs_initially): Don't use
582 set_window_height but set heights directly.
583 (change_frame_size_1): Use resize_frame_windows.
584
585 * xdisp.c (init_xdisp): Don't use set_window_height but set
586 heights directly.
587
588 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
589 resize_frame_windows instead of change_window_heights and run
590 run_window_configuration_change_hook.
591
592 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
593 instead of change_window_heights and run
594 run_window_configuration_change_hook.
595
1a13852e
MR
5962011-06-09 Martin Rudalics <rudalics@gmx.at>
597
598 * window.c (replace_window): Rename second argument REPLACEMENT to
599 NEW. New third argument SETFLAG. Rewrite.
600 (delete_window, make_dummy_parent): Call replace_window with
601 third argument 1.
602 (window_list_1): Move down in code.
603 (run_window_configuration_change_hook): Move set_buffer part
604 before select_frame_norecord part in order to unwind correctly.
605 Rename count1 to count.
606 (recombine_windows, delete_deletable_window, resize_root_window)
607 (Fdelete_other_windows_internal)
608 (Frun_window_configuration_change_hook, make_parent_window)
609 (resize_window_check, resize_window_apply, Fresize_window_apply)
610 (resize_frame_windows, Fsplit_window_internal)
611 (Fdelete_window_internal, Fresize_mini_window_internal): New
612 functions.
613 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
614
f3d1777e
MR
6152011-06-08 Martin Rudalics <rudalics@gmx.at>
616
496e208e
MR
617 * window.h (window): Add some new members to window structure -
618 normal_lines, normal_cols, new_total, new_normal, clone_number,
619 splits, nest, prev_buffers, next_buffers.
620 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 621 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 622
f3d1777e
MR
623 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
624 Remove.
496e208e
MR
625 (make_dummy_parent): Set new members of windows structure.
626 (make_window): Move down in code. Handle new members of window
627 structure.
628 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
629 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
630 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
631 (Fset_window_prev_buffers, Fwindow_next_buffers)
632 (Fset_window_next_buffers, Fset_window_clone_number): New
633 functions.
634 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
635 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
636 Doc-string fixes.
637 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
638 Argument WINDOW can be now internal window too.
639 (Fwindow_use_time): Move up in code.
640 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
641 Rewrite doc-string.
642 (Fset_window_configuration, saved_window)
643 (Fcurrent_window_configuration, save_window_save): Handle new
644 members of window structure.
b9e809c2
MR
645 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
646 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
647 (syms_of_window): New Lisp objects Qrecord_window_buffer,
648 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
649 Qget_mru_window, Qresize_root_window,
650 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
651 Qauto_buffer_name; staticpro them.
f3d1777e 652
abde8f8c
MR
6532011-06-07 Martin Rudalics <rudalics@gmx.at>
654
655 * window.c (Fwindow_total_size, Fwindow_left_column)
656 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
657 (Fwindow_list_1): New functions.
658 (window_box_text_cols): Replace with window_body_cols.
659 (Fwindow_width, Fscroll_left, Fscroll_right): Use
660 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
661 (delete_window, Fset_window_configuration): Call
662 delete_all_subwindows with window as argument.
663 (delete_all_subwindows): Take a window as argument and not a
664 structure. Rewrite.
190b47e6
MR
665 (window_loop): Remove handling of GET_LRU_WINDOW and
666 GET_LARGEST_WINDOW.
667 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
668
669 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
670 window_box_text_cols. delete_all_subwindows now takes a
671 Lisp_Object as argument.
abde8f8c
MR
672
673 * indent.c (compute_motion, Fcompute_motion): Use
674 window_body_cols instead of window_box_text_cols.
675
fa8a67e6
MR
676 * frame.c (delete_frame): Call delete_all_subwindows with root
677 window as argument.
678
a54e3482
DC
6792011-06-07 Daniel Colascione <dan.colascione@gmail.com>
680
681 * fns.c (Fputhash): Document return value.
682
60002bf5
CY
6832011-06-06 Chong Yidong <cyd@stupidchicken.com>
684
685 * image.c (gif_load): Implement gif89a spec "no disposal" method.
686
0c671da6 6872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 688
b862a52a 689 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 690
be44ca6c
PE
691 Check for overflow when converting integer to cons and back.
692 * charset.c (Fdefine_charset_internal, Fdecode_char):
693 Use cons_to_unsigned to catch overflow.
694 (Fencode_char): Use INTEGER_TO_CONS.
695 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
696 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
697 * data.c (long_to_cons, cons_to_long): Remove.
698 (cons_to_unsigned, cons_to_signed): New functions.
699 These signal an error for invalid or out-of-range values.
700 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
701 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
702 * font.c (Ffont_variation_glyphs):
703 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
704 * lisp.h: Include <intprops.h>.
705 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
706 (cons_to_signed, cons_to_unsigned): New decls.
707 (long_to_cons, cons_to_long): Remove decls.
708 * undo.c (record_first_change): Use INTEGER_TO_CONS.
709 (Fprimitive_undo): Use CONS_TO_INTEGER.
710 * xfns.c (Fx_window_property): Likewise.
711 * xselect.c: Include <limits.h>.
712 (x_own_selection, selection_data_to_lisp_data):
713 Use INTEGER_TO_CONS.
714 (x_handle_selection_request, x_handle_selection_clear)
715 (x_get_foreign_selection, Fx_disown_selection_internal)
716 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
717 (lisp_data_to_selection_data): Use cons_to_unsigned.
718 (x_fill_property_data): Use cons_to_signed.
719 Report values out of range.
720
d1f3d2af
PE
721 Check for buffer and string overflow more precisely.
722 * buffer.h (BUF_BYTES_MAX): New macro.
723 * lisp.h (STRING_BYTES_MAX): New macro.
724 * alloc.c (Fmake_string):
725 * character.c (string_escape_byte8):
726 * coding.c (coding_alloc_by_realloc):
727 * doprnt.c (doprnt):
728 * editfns.c (Fformat):
729 * eval.c (verror):
730 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
731 since they may not be the same number.
732 * editfns.c (Finsert_char):
733 * fileio.c (Finsert_file_contents):
734 Likewise for BUF_BYTES_MAX.
735
dd52fcea
PE
736 * image.c: Use ptrdiff_t, not int, for sizes.
737 (slurp_file): Switch from int to ptrdiff_t.
738 All uses changed.
739 (slurp_file): Check that file size fits in both size_t (for
740 malloc) and ptrdiff_t (for sanity and safety).
741
7f9bbdbb
PE
742 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
743 if b->modtime has its maximal value.
744
dfe18f82
PE
745 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
746
84acfcf0
PE
747 Don't assume time_t can fit into int.
748 * buffer.h (struct buffer.modtime): Now time_t, not int.
749 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
750 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
751
ccd9a01a
PE
752 Minor fixes for signed vs unsigned integers.
753 * character.h (MAYBE_UNIFY_CHAR):
754 * charset.c (maybe_unify_char):
755 * keyboard.c (read_char, reorder_modifiers):
756 XINT -> XFASTINT, since the integer must be nonnegative.
757 * ftfont.c (ftfont_spec_pattern):
758 * keymap.c (access_keymap, silly_event_symbol_error):
759 XUINT -> XFASTINT, since the integer must be nonnegative.
760 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
761 since it makes no difference and we prefer signed.
762 * keyboard.c (record_char): Use XUINT when all the neighbors do.
763 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
764 nonnegative.
765
d6d100dd
SM
7662011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
767
768 * window.h (Fwindow_frame): Declare.
769
2b6148e4
PE
7702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
771
772 * alloc.c: Simplify handling of large-request failures (Bug#8800).
773 (SPARE_MEMORY): Always define.
774 (LARGE_REQUEST): Remove.
775 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
776
f230ecc9
MR
7772011-06-06 Martin Rudalics <rudalics@gmx.at>
778
727e958e
MR
779 * lisp.h: Move EXFUNS for Fframe_root_window,
780 Fframe_first_window and Fset_frame_selected_window to window.h.
781
782 * window.h: Move EXFUNS for Fframe_root_window,
783 Fframe_first_window and Fset_frame_selected_window here from
784 lisp.h.
785
786 * frame.c (Fwindow_frame, Fframe_first_window)
787 (Fframe_root_window, Fframe_selected_window)
788 (Fset_frame_selected_window): Move to window.c.
789 (Factive_minibuffer_window): Move to minibuf.c.
790 (Fother_visible_frames_p): New function.
791
792 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
793
f230ecc9
MR
794 * window.c (decode_window, decode_any_window): Move up in code.
795 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
796 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
797 (Fwindow_buffer): Move up and rewrite doc-string.
798 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
799 (Fwindow_prev): New functions.
727e958e
MR
800 (Fwindow_frame): Move here from frame.c. Accept any window as
801 argument.
802 (Fframe_root_window, Fframe_first_window)
803 (Fframe_selected_window): Move here from frame.c. Accept frame
804 or arbitrary window as argument. Update doc-strings.
805 (Fminibuffer_window): Move up in code.
806 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
807 (Fset_frame_selected_window): Move here from frame.c.
808 Marginal rewrite.
727e958e
MR
809 (Fselected_window, select_window, Fselect_window): Move up in
810 code. Minor doc-string fixes.
f230ecc9 811
4d09bcf6
PE
8122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
813
814 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
815 Do not assume that spare memory exists; that assumption is valid
816 only if SYSTEM_MALLOC.
817 (LARGE_REQUEST): New macro, so that the issue of large requests
818 is separated from the issue of spare memory.
819
810928a2
AS
8202011-06-05 Andreas Schwab <schwab@linux-m68k.org>
821
172418ad
AS
822 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
823 format. (Bug#8806)
824
43f862f7
AS
825 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
826
810928a2
AS
827 * xfns.c (x_set_scroll_bar_default_width): Move declarations
828 before statements.
829
a059fe24
JD
8302011-06-05 Jan Djärv <jan.h.d@swipnet.se>
831
832 * gtkutil.c (xg_get_default_scrollbar_width): New function.
833
834 * gtkutil.h: Declare xg_get_default_scrollbar_width.
835
836 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
837 min width by calling x_set_scroll_bar_default_width (Bug#8505).
838
989bf368
JB
8392011-06-05 Juanma Barranquero <lekktu@gmail.com>
840
841 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
842
4b80f674
CY
8432011-06-04 Chong Yidong <cyd@stupidchicken.com>
844
845 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
846 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
847 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
848 New error handlers.
4b80f674
CY
849 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
850 Obey Vx_select_enable_clipboard_manager. Catch errors in
851 x_clipboard_manager_save (Bug#8779).
852 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 853 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 854
99a33b77 8552011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
856
857 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
858
99a33b77 8592011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
860
861 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
862 in the current matrix if keep_current_p is non-zero.
863
8264569d
EZ
8642011-06-04 Eli Zaretskii <eliz@gnu.org>
865
866 * bidi.c (bidi_level_of_next_char): Fix last change.
867
57f97249
EZ
8682011-06-03 Eli Zaretskii <eliz@gnu.org>
869
fec2107c 870 Support bidi reordering of text covered by display properties.
57f97249 871
fec2107c
EZ
872 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
873 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
874 (bidi_cache_search, bidi_cache_iterator_state)
875 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
876 (bidi_level_of_next_char, bidi_move_to_visually_next):
877 Support character positions inside a run of characters covered by a
fec2107c
EZ
878 display string.
879 (bidi_paragraph_init, bidi_resolve_explicit_1)
880 (bidi_level_of_next_char): Call bidi_fetch_char and
881 bidi_fetch_char_advance instead of FETCH_CHAR and
882 FETCH_CHAR_ADVANCE.
883 (bidi_init_it): Initialize new members.
884 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
885 definitions.
886 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
887 instead of using explicit *_CHAR codes.
d6d100dd
SM
888 (bidi_resolve_explicit, bidi_resolve_weak):
889 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
890 bidirectional text is supported only in multibyte buffers.
891 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
892 it to initialize the frame_window_p member of struct bidi_it.
893 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
894 (bidi_resolve_explicit, bidi_resolve_weak)
895 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
896 bidi_it->nchars is non-positive.
897 (bidi_level_of_next_char): Don't try to lookup the cache for the
898 next/previous character if nothing is cached there yet, or if we
899 were just reseat()'ed to a new position.
c40e2fb2 900
0e14fe90
EZ
901 * xdisp.c (set_cursor_from_row): Set start and stop points
902 according to the row's direction when priming the loop that looks
903 for the glyph on which to display cursor.
904 (single_display_spec_intangible_p): Function deleted.
905 (display_prop_intangible_p): Reimplement to call
906 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
907 Accept 3 additional arguments needed by handle_display_spec.
908 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
909 values: lists, `(when COND...)' forms, etc.
910 (single_display_spec_string_p): Support property values that are
911 lists with the argument STRING its top-level element.
912 (display_prop_string_p): Fix the condition for processing a
913 property that is a list to be consistent with handle_display_spec.
fec2107c 914 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
915 last portion of handle_display_prop.
916 (compute_display_string_pos): Accept additional argument
917 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
918 value of a `display' property is a "replacing spec".
919 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
920 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
921 the display property, but just return a value indicating whether
922 the display property will replace the characters it covers.
923 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
924 frame_window_p members of struct bidi_it.
d6d100dd
SM
925 (compute_display_string_pos, compute_display_string_end):
926 New functions.
fec2107c
EZ
927 (push_it): Accept second argument POSITION, where pop_it should
928 jump to continue iteration.
929 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 930
fec2107c
EZ
931 * keyboard.c (adjust_point_for_property): Adjust the call to
932 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
933
934 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
935 (bidi_init_it): Update prototypes.
936 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
937 (compute_display_string_pos, compute_display_string_end):
938 Declare prototypes.
fec2107c
EZ
939 (struct bidi_it): New members nchars and disp_pos. ch_len is now
940 EMACS_INT.
fc6f18ce 941
40087514 9422011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 943
57f53182
PE
944 Malloc failure behavior now depends on size of allocation.
945 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
946 * lisp.h: Change signatures accordingly.
947 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
948 All callers changed. (Bug#8762)
949
950 * gnutls.c: Use Emacs's memory allocators.
951 Without this change, the gnutls library would invoke malloc etc.
952 directly, which causes problems on non-SYNC_INPUT hosts, and which
953 runs afoul of improving memory_full behavior. (Bug#8761)
954 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
955 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
956 xfree instead of the default malloc, realloc, free.
957 (Fgnutls_boot): No need to check for memory allocation failure,
958 since xmalloc does that for us.
959
ac32cd99 960 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
961 * category.c (hash_get_category_set):
962 * ccl.c (ccl_driver):
963 * charset.c (Fdefine_charset_internal):
964 * charset.h (struct charset.hash_index):
965 * composite.c (get_composition_id, gstring_lookup_cache)
966 (composition_gstring_put_cache):
967 * composite.h (struct composition.hash_index):
968 * dispextern.h (struct image.hash):
969 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
970 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
971 (hashfn_equal, hashfn_user_defined, make_hash_table)
972 (maybe_resize_hash_table, hash_lookup, hash_put)
973 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
974 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
975 (Fsxhash, Fgethash, Fputhash, Fmaphash):
976 * image.c (make_image, search_image_cache, lookup_image)
977 (xpm_put_color_table_h):
978 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 979 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
980 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
981 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
982 * alloc.c (allocate_vectorlike):
983 Check for overflow in vector size calculations.
984 * ccl.c (ccl_driver):
985 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
986 * fns.c, image.c: Remove unnecessary static decls that would otherwise
987 need to be updated by these changes.
40087514
PE
988 * fns.c (make_hash_table, maybe_resize_hash_table):
989 Check for integer overflow with large hash tables.
0de4bb68
PE
990 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
991 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
992 (SXHASH_REDUCE): New macro.
993 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
994 Use it instead of discarding useful hash info with large hash values.
995 (sxhash_float): New function.
996 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
997 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
998 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
999 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1000 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1001 Adjust signatures to match updated version of code.
1002 (consing_since_gc): Now EMACS_INT, since a single hash table can
1003 use more than INT_MAX bytes.
1004
698d32e2
DN
10052011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1006
1007 Make it possible to build with GCC-4.6+ -O2 -flto.
1008
1009 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1010
fd6fa53f
SM
10112011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1012
1013 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1014 Call minibuffer-inactive-mode.
1015
864db017
JB
10162011-05-31 Juanma Barranquero <lekktu@gmail.com>
1017
1018 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1019 Update dependencies.
1020
2ad0baf4
DN
10212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1022
1023 * data.c (init_data): Remove code for UTS, this system is not
1024 supported anymore.
1025
4fcc2638
DN
10262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1027
1028 Don't force ./temacs to start in terminal mode.
1029
1030 * frame.c (make_initial_frame): Initialize faces in all cases, not
1031 only when CANNOT_DUMP is defined.
1032 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1033
c56e0fd5
DN
10342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1035
1036 * dispnew.c (add_window_display_history): Use const for the string
1037 pointer. Remove declaration, not needed.
1038
333d54da 10392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1040
55d4c1b2 1041 Use 'inline', not 'INLINE'.
333d54da 1042 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1043 * alloc.c, fontset.c (INLINE): Remove.
1044 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1045 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1046 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1047 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1048 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1049
738db178
DN
10502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1051
1052 Make it possible to run ./temacs.
1053
1054 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1055 syms_of_callproc does the same thing. Remove test for
1056 "initialized", do it in the caller.
1057 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1058
620c53a6
SM
10592011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1060
1061 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1062 (read_minibuf): Use get_minibuffer.
1063 (syms_of_minibuf): Use DEFSYM.
1064 (Qmetadata): New var.
1065 * data.c (Qbuffer): Don't make it static.
1066 (syms_of_data): Use DEFSYM.
1067
e003a292
PE
10682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1069
1070 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1071 (CCL_CODE_MIN): New macro.
1072
ed008a6d
PE
10732011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1074
3687c2ef
PE
1075 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1076
ed008a6d
PE
1077 * eval.c (Qdebug): Now static.
1078 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1079 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1080 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1081
d66c4c7c
CY
10822011-05-29 Chong Yidong <cyd@stupidchicken.com>
1083
1084 * image.c: Various fixes to ImageMagick code comments.
1085 (Fimagemagick_types): Doc fix.
1086
5fbc2025
PE
10872011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1088
0196f88a
PE
1089 Minor fixes prompted by GCC 4.6.0 warnings.
1090
1091 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1092
5fbc2025
PE
1093 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1094 (x_clipboard_manager_save_all): Move extern decl to ...
1095 * xterm.h: ... here, so that it can be checked for consistency.
1096
1dd3c2d9
CY
10972011-05-29 Chong Yidong <cyd@stupidchicken.com>
1098
1099 * xselect.c (x_clipboard_manager_save_frame)
1100 (x_clipboard_manager_save_all): New functions.
1101 (Fx_clipboard_manager_save): Lisp function deleted.
1102
1103 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1104 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1105
1106 * xterm.h: Update prototype.
1107
5ba6571d
WX
11082011-05-28 William Xu <william.xwl@gmail.com>
1109
1110 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1111 exiting (Bug#8239).
1112
3eaff834
JM
11132011-05-28 Jim Meyering <meyering@redhat.com>
1114
e1900994 1115 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1116 * fns.c (to_uchar): Define.
1117 (crypto_hash_function): Use it to convert some newly-signed
1118 variables to unsigned, to avoid sign-extension bugs. For example,
1119 without this change, (md5 "truc") would evaluate to
1120 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1121 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1122 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1123
0f6990a7
PE
11242011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1125
1126 Integer overflow fixes.
c8a9ca5a 1127
08686060
PE
1128 * dbusbind.c: Serial number integer overflow fixes.
1129 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1130 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1131 to hold a serial number that is too large for a fixnum.
1132 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1133 Check for serial numbers out of range. Decode any serial number
59568bf0 1134 that was so large that it became a float. (Bug#8722)
08686060 1135
2d1fc3c7
PE
1136 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1137 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1138 Use XFASTINT rather than XUINT when numbers are nonnegative.
1139 (xd_append_arg, Fdbus_method_return_internal):
1140 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1141 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1142 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1143 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1144 (Bug#8722)
2d1fc3c7 1145
c8a9ca5a
PE
1146 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1147
519e1d69
PE
1148 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1149
30569699
PE
1150 ccl: add integer overflow checks
1151 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1152 (IN_INT_RANGE): New macros.
1153 (ccl_driver): Use them to check for integer overflow when
1154 decoding a CCL program. Many of the new checks are whether XINT (x)
1155 fits in int; it doesn't always, on 64-bit hosts. The new version
1156 doesn't catch all possible integer overflows, but it's an
847044ea 1157 improvement. (Bug#8719)
30569699 1158
c11285dc
PE
1159 * alloc.c (make_event_array): Use XINT, not XUINT.
1160 There's no need for unsigned here.
1161
fdccd48e
PE
1162 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1163 This follows up to the 2011-05-06 change that substituted uintptr_t
1164 for EMACS_INT. This case wasn't caught back then.
1165
37910ab2
PE
1166 Rework Fformat to avoid integer overflow issues.
1167 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1168 now (part of C89). Include <verify.h>.
1169 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1170 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1171 (Fformat): Avoid the prepass trying to compute sizes; it was only
1172 approximate and thus did not catch overflow reliably. Instead, walk
1173 through the format just once, formatting and computing sizes as we go,
1174 checking for integer overflow at every step, and allocating a larger
1175 buffer as needed. Keep track separately whether the format is
1176 multibyte. Keep only the most-recently calculated precision, rather
1177 than them all. Record whether each argument has been converted to
1178 string. Use EMACS_INT, not int, for byte and char and arg counts.
1179 Support field widths and precisions larger than INT_MAX. Avoid
1180 sprintf's undefined behavior with conversion specifications such as %#d
1181 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1182 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1183 formatting out-of-range floating point numbers with int
1184 formats. (Bug#8668)
1185
2e6578fb
PE
1186 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1187
0ae6bdee
PE
1188 * data.c: Avoid integer truncation in expressions involving floats.
1189 * data.c: Include <intprops.h>.
1190 (arith_driver): When there's an integer overflow in an expression
1191 involving floating point, convert the integers to floating point
1192 so that the resulting value does not suffer from catastrophic
1193 integer truncation. For example, on a 64-bit host (* 4
1194 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1195 Do not rely on undefined behavior after integer overflow.
1196
de883a70
PE
1197 merge count_size_as_multibyte, parse_str_to_multibyte
1198 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1199 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1200 Check for integer overflow.
1201 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1202 since it's now a duplicate of the other. This is more of
1203 a character than a buffer op, so better that it's in character.c.
1204 * fns.c, print.c: Adjust to above changes.
1205
2ff916cb
PE
12062011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1207
1208 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1209
f1b54466
PE
12102011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1211
fb1ac845
PE
1212 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1213 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1214 (x_clipboard_manager_save): Now static.
1215 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1216
f1b54466
PE
1217 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1218 (crypto_hash_function): Now static.
1219 Fix pointer signedness problems. Avoid unnecessary initializations.
1220
a9f737ee
CY
12212011-05-27 Chong Yidong <cyd@stupidchicken.com>
1222
1223 * termhooks.h (Vselection_alist): Make it terminal-local.
1224
1225 * terminal.c (create_terminal): Initialize it.
1226
1227 * xselect.c: Support for clipboard managers.
1228 (Vselection_alist): Move to termhooks.h as terminal-local var.
1229 (LOCAL_SELECTION): New macro.
1230 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1231 (symbol_to_x_atom): Remove gratuitous arg.
1232 (x_handle_selection_request, lisp_data_to_selection_data)
1233 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1234 (x_own_selection, x_get_local_selection, x_convert_selection):
1235 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1236 (some_frame_on_display): Delete unused function.
1237 (Fx_own_selection_internal, Fx_get_selection_internal)
1238 (Fx_disown_selection_internal, Fx_selection_owner_p)
1239 (Fx_selection_exists_p): New optional frame arg.
1240 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1241 (x_handle_selection_clear): Don't treat other terminals with the
1242 same keyboard specially. Use the terminal-local Vselection_alist.
1243 (x_clear_frame_selections): Use Frun_hook_with_args.
1244
1245 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1246
1247 * xterm.h: Add support for those atoms.
1248
e067f0c1
CY
12492011-05-26 Chong Yidong <cyd@stupidchicken.com>
1250
1251 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1252 (converted_selections, conversion_fail_tag): New global variables.
1253 (x_selection_request_lisp_error): Free the above.
1254 (x_get_local_selection): Remove unnecessary code.
1255 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1256 of converted selections stored in converted_selections.
1257 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1258 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1259 (x_convert_selection): New function.
1260 (x_handle_selection_event): Simplify.
1261 (x_get_foreign_selection): Don't ignore incoming requests while
1262 waiting for an answer; this will fail when we implement
1263 SAVE_TARGETS, and seems unnecessary anyway.
1264 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1265 (Vx_sent_selection_functions): Doc fix.
1266
0f4aebc0
LL
12672011-05-26 Leo Liu <sdl.web@gmail.com>
1268
1269 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1270
e61124cd
YM
12712011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1272
1273 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1274
1275 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1276 for fringe update if it has periodic bitmap.
1277 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1278 and fringe_bitmap_periodic_p.
1279
1280 * fringe.c (get_fringe_bitmap_data): New function.
1281 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1282 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1283 row. Mark glyph row for fringe update if periodicity changed.
1284
1285 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1286 for fringe update unless it has periodic bitmap.
1287
f16d9837
KH
12882011-05-25 Kenichi Handa <handa@m17n.org>
1289
1290 * xdisp.c (get_next_display_element): Set correct it->face_id for
1291 a static composition.
1292
e1b90ef6
LL
12932011-05-24 Leo Liu <sdl.web@gmail.com>
1294
1295 * deps.mk (fns.o):
1296 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1297
1298 * fns.c (crypto_hash_function, Fsha1): New function.
1299 (Fmd5): Use crypto_hash_function.
1300 (syms_of_fns): Add Ssha1.
1301
7400048f
PE
13022011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1303
1304 * gnutls.c: Remove unused macros.
1305 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1306 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1307 Remove macros that are defined and never used.
1308 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1309
abb71cf4
CY
13102011-05-22 Chong Yidong <cyd@stupidchicken.com>
1311
1312 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1313 (Fx_get_selection_internal): Minor cleanup.
1314 (Fx_own_selection_internal): Rename arguments for consistency with
1315 select.el.
1316
6307db39
PE
13172011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1318
1319 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1320
f3d4e0a4
CY
13212011-05-22 Chong Yidong <cyd@stupidchicken.com>
1322
1323 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1324
4d8ade89
YM
13252011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1326
1327 * dispnew.c (scrolling_window): Don't exclude the case that the
1328 last enabled row in the desired matrix touches the bottom boundary.
1329
32078c8d
GM
13302011-05-21 Glenn Morris <rgm@gnu.org>
1331
1332 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1333 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1334 and add some more files.
32078c8d 1335
7285dc67
EZ
13362011-05-20 Eli Zaretskii <eliz@gnu.org>
1337
1338 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1339 report_file_error introduced by the change from 2011-05-07.
1340
89d1bd22
PE
13412011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1342
1343 * systime.h (Time): Define only if emacs is defined.
1344 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1345 where the include path doesn't have X11/X.h by default. See
1346 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1347
e23640bb 13482011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1349
1350 * composite.c (find_automatic_composition): Fix previous change.
1351
b9704ad9
GM
13522011-05-20 Glenn Morris <rgm@gnu.org>
1353
1354 * lisp.mk: New file, split from Makefile.in.
1355 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1356 (shortlisp): Remove.
1357 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1358
4a720484
GM
13592011-05-19 Glenn Morris <rgm@gnu.org>
1360
1361 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1362 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1363 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1364 (lisp): Set the order to that of loadup.el.
1365 (shortlisp): Make it a copy of $lisp.
1366 (SOME_MACHINE_LISP): Remove.
1367 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1368 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1369
a28d4396
KH
13702011-05-18 Kenichi Handa <handa@m17n.org>
1371
1372 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1373 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1374 (find_automatic_composition): Mostly rewrite for efficiency.
1375
a2b1fa8e
JB
13762011-05-18 Juanma Barranquero <lekktu@gmail.com>
1377
1378 * makefile.w32-in: Update dependencies.
1379
8e1f5610
CS
13802011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1381
1382 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1383 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1384
7025ee00 13852011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1386
cdfa6eab
PE
1387 Fix some integer overflow issues, such as string length overflow.
1388
06d6db33
PE
1389 * insdel.c (count_size_as_multibyte): Check for string overflow.
1390
2b4560a8
PE
1391 * character.c (lisp_string_width): Check for string overflow.
1392 Use EMACS_INT, not int, for string indexes and lengths; in
1393 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1394 the resulting string length overflows an EMACS_INT; instead,
1395 report a string overflow if no precision given. When checking for
1396 precision exhaustion, use a check that cannot possibly have
1397 integer overflow. (Bug#8675)
1398 * character.h (lisp_string_width): Adjust to new signature.
1399
cb93f9be
PE
1400 * alloc.c (string_overflow): New function.
1401 (Fmake_string): Use it. This doesn't change behavior, but saves
1402 a few bytes and will simplify future changes.
1403 * character.c (string_escape_byte8): Likewise.
1404 * lisp.h (string_overflow): New decl.
1405
1a1f3366
PE
1406 Fixups, following up to the user-interface timestamp change.
1407 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1408 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1409 * msdos.c (mouse_get_pos): Likewise.
1410 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1411 * w32gui.h (Time): Define by including "systime.h" rather than by
1412 declaring it ourselves. (Bug#8664)
1413
d4e3e4d3
PE
1414 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1415 * image.c (clear_image_cache): Likewise.
1416
f6a24d19
PE
1417 * term.c (term_mouse_position): Don't assume time_t wraparound.
1418
08dc5ae6
PE
1419 Be more systematic about user-interface timestamps.
1420 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1421 and sometimes 'EMACS_UINT', to represent these timestamps.
1422 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1423 This makes the code easier to follow, and makes it easier to catch
1424 integer overflow bugs such as Bug#8664.
1425 * frame.c (Fmouse_position, Fmouse_pixel_position):
1426 Use Time, not unsigned long, for user-interface timestamps.
1427 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1428 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1429 * keyboard.h (last_event_timestamp): Likewise.
1430 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1431 * menu.h (xmenu_show): Likewise.
1432 * term.c (term_mouse_position): Likewise.
1433 * termhooks.h (struct input_event.timestamp): Likewise.
1434 (struct terminal.mouse_position_hook): Likewise.
1435 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1436 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1437 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1438 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1439 what it was before.
1440 * menu.h, termhooks.h: Include "systime.h", for Time.
1441
8e55734a
PE
1442 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1443 Don't assume that the difference between two unsigned long values
1444 can fit into an integer. At this point, we know button_down_time
1445 <= event->timestamp, so the difference must be nonnegative, so
1446 there's no need to cast the result if double-click-time is
1447 nonnegative, as it should be; check that it's nonnegative, just in
1448 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1449 apart (about 25 days). (Bug#8664)
8e55734a 1450
841f1b75 1451 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1452 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1453
3e26f69c
PE
1454 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1455 that always fit in int. Use a sentinel instead of a counter, to
1456 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1457 * frame.h (struct frame): Use int for menu_bar_items_used
1458 instead of EMACS_INT, since it always fits in int.
3e26f69c 1459
5cc152c0
PE
1460 * menu.c (grow_menu_items): Check for int overflow.
1461
d89eb65e
PE
1462 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1463
5235bd3e
PE
1464 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1465 Before, the code was not consistent. These values cannot exceed
1466 2**31 - 1 so there's no need to make them unsigned.
1467 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1468 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1469 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1470 as modifiers.
1471 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1472
bc827e23
PE
1473 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1474 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1475 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1476 presumably because the widths might not match.
1477
78eb494e
PE
1478 * window.c (size_window): Avoid needless test at loop start.
1479
04f2d78b
CB
14802011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1481
1482 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1483
d2fc7e3d 14842011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1485
1486 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1487
d2fc7e3d 14882011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1489
1490 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1491 `width' to `bar_area_x' and `bar_area_width', respectively.
1492 (x_scroll_run): Take account of fringe background extension.
1493
04f2d78b
CB
1494 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1495 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1496 `bar_area_width', respectively.
1497 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1498 background extension.
1499
79b70037
GM
15002011-05-10 Jim Meyering <meyering@redhat.com>
1501
1502 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1503
2f142cc5
JB
15042011-05-10 Juanma Barranquero <lekktu@gmail.com>
1505
1506 * image.c (Finit_image_library): Return t for built-in image types,
1507 like pbm and xbm. (Bug#8640)
1508
57679c86
AS
15092011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1510
1511 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1512
888c9e86
EZ
15132011-05-07 Eli Zaretskii <eliz@gnu.org>
1514
b0512a1d
EZ
1515 * w32console.c (Fset_screen_color): Doc fix.
1516 (Fget_screen_color): New function.
1517 (syms_of_ntterm): Defsubr it.
1518
7285dc67
EZ
1519 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1520 unlink the temporary file if Fcall_process didn't create it in the
1521 first place.
1522 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1523 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1524 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1525 cue to call_process_cleanup not to close that handle.
1526
4d3fcc8e
BK
15272011-05-07 Ben Key <bkey76@gmail.com>
1528
1529 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1530 one of two shell specific rules, either bootstrap-temacs-CMD or
1531 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1532 to the previous implementation of the bootstrap-temacs rule.
1533 The bootstrap-temacs-CMD rule is similar to the previous
1534 implementation of the bootstrap-temacs rule except that it
1535 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1536 variable.
1537
1538 These changes, along with some changes to nt/configure.bat,
1539 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1540 earlier fix to add support for --cflags and --ldflags options
1541 that include quotes so that it works whether make uses cmd or
1542 sh as the shell.
1543
b4289b64
MA
15442011-05-06 Michael Albinus <michael.albinus@gmx.de>
1545
1546 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1547 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1548 is a constant.
1549 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1550 a string. Handle both cases.
1551 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1552 (Fdbus_register_method): Use Qinvalid_function.
1553
af4c0e28
JB
15542011-05-06 Juanma Barranquero <lekktu@gmail.com>
1555
1556 * makefile.w32-in: Update dependencies.
1557 (LISP_H): Add inttypes.h and stdin.h.
1558 (PROCESS_H): Add unistd.h.
1559
c51453d9
EZ
15602011-05-06 Eli Zaretskii <eliz@gnu.org>
1561
1562 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1563 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1564
8ff0ac3c 15652011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1566
4c4b566b
PE
1567 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1568
aab2b9b5
PE
1569 * term.c (vfatal): Remove stray call to va_end.
1570 It's not needed and the C Standard doesn't allow it here anyway.
1571
c378da0b
PE
1572 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1573 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1574
288b08c7
PE
1575 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1576 bytes.
1577
e3601888
PE
1578 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1579
db6c0e74
PE
1580 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1581
dd5963ea
PE
1582 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1583
88c9450f
PE
1584 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1585
2f9442b8
PE
1586 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1587
c032b5f8
PE
1588 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1589 * charset.c (Fdefine_charset_internal): Don't initialize
1590 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1591 32-bit int (Bug#8600).
a108c10b
PE
1592
1593 * lread.c (read_integer): Be more consistent with string-to-number.
1594 Use string_to_number to do the actual conversion; this avoids
1595 rounding errors and fixes some other screwups. Without this fix,
1596 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1597 (digit_to_number): Move earlier, for benefit of read_integer.
1598 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1599 not a digit in any supported base. (Bug#8602)
a108c10b 1600
ad5f9eea
PE
1601 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1602
aec1708a
PE
1603 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1604 to match comment at start of function. This also removes a
1605 GCC warning about overflow in a 32+64-bit port.
1606
47be4ab5
PE
1607 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1608
371cac43
PE
1609 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1610 Reported by Stefan Monnier in
1611 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1612 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1613 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1614
d01a7826
PE
1615 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1616 (EMACS_UINTPTR): Likewise, with uintptr_t.
1617
7fd47d5c
PE
1618 * lisp.h: Prefer 64-bit EMACS_INT if available.
1619 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1620 on 32-bit hosts that have 64-bit int, so that they can access
1621 large files.
122b0c86
PE
1622 However, temporarily disable this change unless the temporary
1623 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1624
8727937b
PE
1625 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1626
8ac068ac
PE
1627 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1628 This removes an assumption that EMACS_INT and long are the same
1629 width as pointers. The assumption is true for Emacs porting targets
1630 now, but we want to make other targets possible.
1631 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1632 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1633 In the rest of the code, change types of integers that hold casted
1634 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1635 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1636 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1637 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1638 No need to cast type when ORing.
1639 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1640 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1641 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1642 assume EMACS_INT is the same width as char *.
1643 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1644 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1645 Remove no-longer-needed casts.
1646 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1647 (xg_tool_bar_help_callback, xg_make_tool_item):
1648 Use EMACS_INTPTR to hold an integer
1649 that will be cast to void *; this can avoid a GCC warning
1650 if EMACS_INT is not the same width as void *.
1651 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1652 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1653 (current_message_1, set_message_1):
1654 Use a local to convert to proper width without a cast.
1655 * xmenu.c (dialog_selection_callback): Likewise.
1656
ede49d71
PE
1657 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1658 Also, don't assume VALBITS / RAND_BITS is less than 5,
1659 and don't rely on undefined behavior when shifting a 1 left into
1660 the sign bit.
1661 * lisp.h (get_random): Change signature to match.
1662
2f30ecd0
PE
1663 * lread.c (hash_string): Use size_t, not int, for hash computation.
1664 Normally we prefer signed values; but hashing is special, because
1665 it's better to use unsigned division on hash table sizes so that
1666 the remainder is nonnegative. Also, size_t is the natural width
1667 for hashing into memory. The previous code used 'int', which doesn't
1668 retain enough info to hash well into very large tables.
1669 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1670
2a866e7b
PE
1671 * dbusbind.c: Don't possibly lose pointer info when converting.
1672 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1673 Use XPNTR rather than XHASH, so that the high-order bits of
1674 the pointer aren't lost when converting through void *.
1675
51639eac
PE
1676 * eval.c (Fautoload): Don't double-shift a pointer.
1677
92394119
PE
1678 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1679
dbdb9a7c
JB
16802011-05-06 Juanma Barranquero <lekktu@gmail.com>
1681
1682 * gnutls.c (DEF_GNUTLS_FN):
1683 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1684
db7a0b4f
AS
16852011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1686
1687 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1688 marker. (Bug#8610)
1689
f7ff1b0f 16902011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1691
1692 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1693 New version that can reserve upto 2GB of heap space.
1694
f7ff1b0f 16952011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1696
1697 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1698
639c109b
TZ
16992011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1700
1701 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1702 `gnutls_certificate_set_x509_key_file'.
1703
d2127135
JB
17042011-05-05 Juanma Barranquero <lekktu@gmail.com>
1705
1706 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1707 Update dependencies.
1708
e968f4f3
JB
17092011-05-04 Juanma Barranquero <lekktu@gmail.com>
1710
1711 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1712 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1713 Remove unused parameter `fildes'.
1714 * process.c (read_process_output, send_process): Don't pass it.
1715
84d358f0
JB
17162011-05-04 Juanma Barranquero <lekktu@gmail.com>
1717
1718 Fix previous change: the library cache is defined in w32.c.
1719 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1720 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1721
0898ca10
JB
17222011-05-04 Juanma Barranquero <lekktu@gmail.com>
1723
1724 Implement dynamic loading of GnuTLS on Windows.
1725
1726 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1727 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1728 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1729 Declare.
1730
1731 * gnutls.c (Qgnutls_dll): Define.
1732 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1733 (gnutls_*): Declare function pointers.
1734 (init_gnutls_functions): New function to initialize function pointers.
1735 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1736 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1737 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1738 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1739 (emacs_gnutls_write, emacs_gnutls_read)
1740 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1741 (Fgnutls_available_p): New function.
1742 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1743 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1744 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1745
1746 * image.c: Include w32.h.
1747 (Vimage_type_cache): Delete.
1748 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1749 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1750 (w32_delayed_load): Move to w32.c.
1751
1752 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1753
1754 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1755 (w32_delayed_load): Move from image.c. When loading a library, record
1756 its filename in the :loaded-from property of the library id.
1757 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1758 Initialize and staticpro them.
1759 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1760
1761 * process.c: Include lisp.h before w32.h, not after.
1762 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1763 instead of gnutls_record_check_pending.
1764
1765 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1766
ff4de4aa
TZ
17672011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1768
1769 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1770 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1771 as passed in.
1772
abe95abb
JD
17732011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1774
1775 * xterm.c (x_set_frame_alpha): Do not set property on anything
1776 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1777
e16e55d4
JB
17782011-05-02 Juanma Barranquero <lekktu@gmail.com>
1779
1780 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1781
bafcf6a5
JB
17822011-05-02 Juanma Barranquero <lekktu@gmail.com>
1783
1784 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1785 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1786 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1787 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1788 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1789 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1790 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1791 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1792 (Qgnutls_bootprop_callbacks_verify): Make static.
1793
e7a6747f
AS
17942011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1795
19ed11ba
AS
1796 * callproc.c: Indentation fixup.
1797
e7a6747f 1798 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1799 (wait_for_termination, interruptible_wait_for_termination):
1800 Move after wait_for_termination_1.
e7a6747f 1801
1ef14cb4
LMI
18022011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1803
1804 * sysdep.c (interruptible_wait_for_termination): New function
1805 which is like wait_for_termination, but allows keyboard
1806 interruptions.
1807
1808 * callproc.c (Fcall_process): Add (:file "file") as an option for
1809 the STDOUT buffer.
1810 (Fcall_process_region): Ditto.
1811
330d880c
EZ
18122011-04-30 Eli Zaretskii <eliz@gnu.org>
1813
8db90b73
EZ
1814 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1815 rather than `XVECTOR (FOO)->size'.
1816
330d880c
EZ
1817 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1818 inttypes.h, as a gnulib replacement is used if it not available in
1819 system headers.
1820
15cbd324
EZ
18212011-04-21 Eli Zaretskii <eliz@gnu.org>
1822
1823 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1824 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1825 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1826
1827 * coding.c (coding_alloc_by_realloc): Error out if destination
1828 will grow beyond MOST_POSITIVE_FIXNUM.
1829 (decode_coding_emacs_mule): Abort if there isn't enough place in
1830 charbuf for the composition carryover bytes. Reserve an extra
1831 space for up to 2 characters produced in a loop.
1832 (decode_coding_iso_2022): Abort if there isn't enough place in
1833 charbuf for the composition carryover bytes.
1834
18352011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1836
ae940cca
EZ
1837 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1838 aborting when %lld or %lll format is passed.
1839 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1840 %llo or %llx format is passed. (Bug#8545)
1841
03ab8921
EZ
1842 * window.c (window_scroll_line_based): Use a marker instead of
1843 simple variables to record original value of point. (Bug#7952)
1844
afda1437
EZ
1845 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1846 produced by %s or %c overflows available buffer space. (Bug#8545)
1847
f76dee0c
PE
18482011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1849
1850 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1851 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1852
fdc5744d
JB
18532011-04-28 Juanma Barranquero <lekktu@gmail.com>
1854
1855 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1856
638f053a
JB
18572011-04-28 Juanma Barranquero <lekktu@gmail.com>
1858
1859 * keyboard.c (Qdelayed_warnings_hook): Define.
1860 (command_loop_1): Run `delayed-warnings-hook'
1861 if Vdelayed_warnings_list is non-nil.
1862 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1863 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1864
d178f871
EZ
18652011-04-28 Eli Zaretskii <eliz@gnu.org>
1866
1867 * doprnt.c (doprnt): Don't return value smaller than the buffer
1868 size if the message was truncated. (Bug#8545).
1869
b124fd93
JB
18702011-04-28 Juanma Barranquero <lekktu@gmail.com>
1871
1872 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1873 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1874
e810457d
PE
18752011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1876
1877 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1878
ea51cceb
JB
18792011-04-27 Juanma Barranquero <lekktu@gmail.com>
1880
1881 * makefile.w32-in: Update dependencies.
1882
94dcfacf
EZ
18832011-04-27 Eli Zaretskii <eliz@gnu.org>
1884
1885 Improve `doprnt' and its usage. (Bug#8545)
1886 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1887 `format_end'. Remove support for %l as a conversion specifier.
1888 Don't use xrealloc. Improve diagnostics when the %l size modifier
1889 is used. Update the commentary.
1890
1891 * eval.c (verror): Simplify calculation of size_t.
1892
1893 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1894 messages.
1895
f61f41d7
PE
18962011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1897
1898 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1899 change.
1900
96fb4434
PE
19012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1902
1903 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1904 This makes this file independent of the recent pseudovector change.
1905
671875da 19062011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1907
69e9b5a3
PE
1908 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1909
b5f869a7 1910 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1911 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1912 Remove unused local.
c8926152 1913 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1914
841a1577 1915 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1916 GCC 4.6.0 optimizes based on type-based alias analysis.
1917 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1918 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1919 != &v->size, and therefore "v->size = 1; b->size = 2; return
1920 v->size;" must therefore return 1. This assumption is incorrect
1921 for Emacs, since it type-puns struct Lisp_Vector * with many other
1922 types. To fix this problem, this patch adds a new type struct
f904488f 1923 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1924 and pseudovectors, and helps optimizing compilers not get fooled
1925 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1926 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1927 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1928 the size member.
eab3844f
PE
1929 (XSETPVECTYPE): Rewrite in terms of new macro.
1930 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1931 This is a bit clearer, and further avoids the possibility of
1932 undesirable aliasing.
1933 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1934 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1935 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1936 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1937 (ASIZE): Now uses header.size rather than size.
1938 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1939 to avoid the hassle of writing XVECTOR (foo)->header.size.
1940 (struct vectorlike_header): New type.
eab3844f
PE
1941 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1942 object, to help avoid aliasing.
1943 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1944 (SUBRP): Likewise, since Lisp_Subr is a special case.
1945 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1946 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1947 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1948 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1949 changed to be "header.size" and "header.next".
1950 * buffer.h (struct buffer): Likewise.
1951 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1952 * frame.h (struct frame): Likewise.
1953 * process.h (struct Lisp_Process): Likewise.
1954 * termhooks.h (struct terminal): Likewise.
1955 * window.c (struct save_window_data, struct saved_window): Likewise.
1956 * window.h (struct window): Likewise.
1957 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1958 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1959 * buffer.c (init_buffer_once): Likewise.
1960 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1961 special case.
1962 * process.c (Fformat_network_address): Use local var for size,
1963 for brevity.
1964
0df1eac5
PE
1965 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1966
847ab9d1 1967 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1968 * data.c (atof): Remove decl; no longer used or needed.
1969 (digit_to_number): Move to lread.c.
1970 (Fstring_to_number): Use new string_to_number function, to be
1971 consistent with how the Lisp reader treats infinities and NaNs.
1972 Do not assume that floating-point numbers represent EMACS_INT
1973 without losing information; this is not true on most 64-bit hosts.
1974 Avoid double-rounding errors, by insisting on integers when
1975 parsing non-base-10 numbers, as the documentation specifies.
1976 * lisp.h (string_to_number): New decl, replacing ...
1977 (isfloat_string): Remove.
bc0a5c13 1978 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1979 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1980 appears to have been a coding error. Similarly, do not accept
1981 strings like +-1e0 as floating point numbers. Do not report
1982 overflow for integer overflows unless the base is not 10 which
1983 means we have no simple and reliable way to continue.
1984 Break out the floating-point parsing into a new
1985 function string_to_number, so that Fstring_to_number parses
1986 floating point numbers consistently with the Lisp reader.
04f2d78b 1987 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1988 (E_CHAR, EXP_INT): Remove, replacing with ...
1989 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1990 (string_to_number): New function, replacing isfloat_string.
1991 This function checks for valid syntax and produces the resulting
1992 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1993 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1994 so that overflow for non-base-10 numbers is reported only when
1995 there's no portable and simple way to convert to floating point.
452f4150 1996
67769ffc
PE
1997 * textprop.c (set_text_properties_1): Rewrite for clarity,
1998 and to avoid GCC warning about integer overflow.
1999
c20db43f
PE
2000 * intervals.h (struct interval): Use EMACS_INT for members
2001 where EMACS_UINT might cause problems. See
2002 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2003 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2004 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2005 All uses changed.
37aa2f85
PE
2006 (offset_intervals): Tell GCC not to worry about length overflow
2007 when negating a negative length.
c20db43f 2008
2538aa2f
PE
2009 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2010 (overrun_check_free): Likewise.
2011
f2d3008d
PE
2012 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2013 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2014 word size.
2015
ec8df744
PE
2016 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2017 (gnutls_make_error): Rename local to avoid shadowing.
2018 (gnutls_emacs_global_deinit): ifdef out; not used.
2019 (Fgnutls_boot): Use const for pointer to readonly storage.
2020 Comment out unused local. Fix pointer signedness problems.
2021
640ee02d
PE
2022 * lread.c (openp): Don't stuff size_t into an 'int'.
2023 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2024 about possible signed overflow.
2025
6048fb2a
PE
2026 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2027 (GDK_KEY_g): Don't define if already defined.
2028 (xg_prepare_tooltip): Avoid pointer signedness problem.
2029 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2030
fa3c87e1
PE
2031 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2032 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2033
2172544b
PE
2034 * xfns.c (Fx_window_property): Simplify a bit,
2035 to make a bit faster and to avoid GCC 4.6.0 warning.
2036 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2037
9b821a21
PE
2038 * fns.c (internal_equal): Don't assume size_t fits in int.
2039
3c616cfa
PE
2040 * alloc.c (compact_small_strings): Tighten assertion a little.
2041
c2982e87
PE
2042 Replace pEd with more-general pI, and fix some printf arg casts.
2043 * lisp.h (pI): New macro, generalizing old pEd macro to other
2044 conversion specifiers. For example, use "...%"pI"d..." rather
2045 than "...%"pEd"...".
2046 (pEd): Remove. All uses replaced with similar uses of pI.
2047 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2048 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2049 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2050 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2051 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2052 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2053 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2054 64-bit hosts.
2055 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2056 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2057 * print.c (safe_debug_print, print_object): Likewise.
2058 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2059 to int.
6f04d126
PE
2060 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2061 avoiding the 0 flag, which is not portable.
c2982e87
PE
2062 * process.c (Fmake_network_process): Use pI to avoid cast.
2063 * region-cache.c (pp_cache): Likewise.
2064 * xdisp.c (decode_mode_spec): Likewise.
2065 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2066 behavior on 64-bit hosts with printf arg.
6f04d126 2067 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2068 (x_stop_queuing_selection_requests): Likewise.
2069 (x_get_window_property): Don't truncate byte count to an 'int'
2070 when tracing.
0b432f21 2071
5e073ec7
PE
2072 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2073 here, since it parses constructs like leading '-' and spaces,
2074 which are not wanted; and it overflows with large numbers.
2075 Instead, simply match F[0-9]+, which is what is wanted anyway.
2076
36372bf9
PE
2077 * alloc.c: Remove unportable assumptions about struct layout.
2078 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2079 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2080 (allocate_vectorlike, make_pure_vector): Use the new macros,
2081 plus offsetof, to remove unportable assumptions about struct layout.
2082 These assumptions hold on all porting targets that I know of, but
2083 they are not guaranteed, they're easy to remove, and removing them
2084 makes further changes easier.
2085
0b432f21
PE
2086 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2087 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2088 (string_overrun_cookie): Now const. Use initializers that
2089 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2090 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2091 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2092 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2093 multiple of sizeof (EMACS_INT); it need not be, if
2094 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2095 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2096
895009e1
JB
20972011-04-26 Juanma Barranquero <lekktu@gmail.com>
2098
2099 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2100
6a7a1b0b
TZ
21012011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2102
2103 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2104 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2105 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2106
841a1577 21072011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2108
2109 * lisp.h (Qdebug): List symbol.
895009e1 2110 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2111 * keyboard.c (debug-on-event): New variable.
2112 (handle_user_signal): Break into debugger when debug-on-event
2113 matches the current signal symbol.
2114
f2d3ba6f
DN
21152011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2116
2117 * alloc.c (check_sblock, check_string_bytes)
2118 (check_string_free_list): Convert to standard C.
2119
42ce4c63
TZ
21202011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2121
2122 * w32.c (emacs_gnutls_push): Fix typo.
2123
825cd63c
EZ
21242011-04-25 Eli Zaretskii <eliz@gnu.org>
2125
fb11d64d
EZ
2126 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2127 "cast to pointer from integer of different size".
2128
825cd63c
EZ
2129 Improve doprnt and its use in verror. (Bug#8545)
2130 * doprnt.c (doprnt): Document the set of format control sequences
2131 supported by the function. Use SAFE_ALLOCA instead of always
2132 using `alloca'.
2133
2134 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2135 is one byte too soon. Don't use xrealloc; instead xfree and
2136 xmalloc anew.
2137
e061a11b
TZ
21382011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2139
2140 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2141 callbacks stage.
2142
2143 * gnutls.c: Renamed global_initialized to
2144 gnutls_global_initialized. Added internals for the
2145 :verify-hostname-error, :verify-error, and :verify-flags
2146 parameters of `gnutls-boot' and documented those parameters in the
2147 docstring. Start callback support.
2148 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2149 unless a fatal error occured. Call gnutls_alert_send_appropriate
2150 on error. Return error code.
2151 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2152 (emacs_gnutls_read): Likewise.
2153 (Fgnutls_boot): Return handshake error code.
2154 (emacs_gnutls_handle_error): New function.
2155 (wsaerror_to_errno): Likewise.
2156
2157 * w32.h (emacs_gnutls_pull): Add prototype.
2158 (emacs_gnutls_push): Likewise.
2159
2160 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2161 (emacs_gnutls_push): Likewise.
2162
21632011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2164
2165 * process.c (wait_reading_process_output): Check if GnuTLS
2166 buffered some data internally if no FDs are set for TLS
2167 connections.
2168
2169 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2170 (LIBS): Link to USER_LIBS.
2171 ($(BLD)/gnutls.$(0)): New target.
2172
fa6996bc
EZ
21732011-04-24 Eli Zaretskii <eliz@gnu.org>
2174
eb35682e
EZ
2175 * xdisp.c (handle_single_display_spec): Rename the
2176 display_replaced_before_p argument into display_replaced_p, to
2177 make it consistent with the commentary. Fix typos in the
2178 commentary.
2179
e2ad650c
EZ
2180 * textprop.c (syms_of_textprop): Remove dead code.
2181 (copy_text_properties): Delete obsolete commentary about an
2182 interface that was deleted long ago. Fix typos in the description
2183 of arguments.
2184
1b2de274
EZ
2185 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2186 to changes in oldXMenu/XMenu.h from 2011-04-16.
2187 <menu_help_message, prev_menu_help_message>: Constify.
2188 (IT_menu_make_room): menu->help_text is now `const char **';
2189 adjust.
2190
2191 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2192 to changes in oldXMenu/XMenu.h from 2011-04-16.
2193 (struct XMenu): Declare `help_text' `const char **'.
2194
2195 * xfaces.c <Qunspecified>: Make extern again.
2196
2197 * syntax.c: Include sys/types.h before including regex.h, as
2198 required by Posix.
2199
762b15be
EZ
2200 * doc.c (get_doc_string): Improve the format passed to `error'.
2201
2202 * doprnt.c (doprnt): Improve commentary.
2203
2204 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2205
2206 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2207 them with etags.
2208
f1052e5d
EZ
2209 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2210 changes in globals.h immediately force recompilation.
762b15be
EZ
2211 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2212 $(CURDIR)/s/ms-w32.h.
2213 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2214
fa6996bc
EZ
2215 * character.c (Fchar_direction): Function deleted.
2216 (syms_of_character): Don't defsubr it.
2217 <char-direction-table>: Deleted.
2218
e6c3da20
EZ
22192011-04-23 Eli Zaretskii <eliz@gnu.org>
2220
2221 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2222 * doprnt.c: Include limits.h.
2223 (SIZE_MAX): New macro.
04f2d78b
CB
2224 (doprnt): Return a size_t value. 2nd arg is now size_t.
2225 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2226 Improve overflow protection. Support `l' modifier for integer
2227 conversions. Support %l conversion. Don't assume an EMACS_INT
2228 argument for integer conversions and for %c.
2229
2230 * lisp.h (doprnt): Restore prototype.
2231
2232 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2233 $(SRC)/character.h.
2234
2235 * Makefile.in (base_obj): Add back doprnt.o.
2236
2237 * deps.mk (doprnt.o): Add back prerequisites.
2238 (callint.o): Depend on character.h.
2239
2240 * eval.c (internal_lisp_condition_case): Include the handler
2241 representation in the error message.
2242 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2243 when breaking from the loop.
2244
2245 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2246
2247 * callint.c (Fcall_interactively): When displaying error message
2248 about invalid control letter, pass the character's codepoint, not
2249 a pointer to its multibyte form. Improve display of the character
2250 in octal and display also its hex code.
2251
2252 * character.c (char_string): Use %x to display the (unsigned)
2253 codepoint of an invalid character, to avoid displaying a bogus
2254 negative value.
2255
2256 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2257 `error', not SYMBOL_NAME itself.
2258
2259 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2260 character arguments to `error'.
2261
2262 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2263 to `error' in error message about FINAL_CHAR argument. Make sure
2264 FINAL_CHAR is a character, and use %c when it is passed as
2265 argument to `error'.
2266
4ffd0d6b 22672011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2268
2269 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2270
2271 * w32.c: Include <time.h>.
2272 (sys_localtime): New function.
2273
4ffd0d6b 22742011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2275
2276 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2277
4ffd0d6b 2278 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2279
4ffd0d6b 22802011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2281
4ffd0d6b
GM
2282 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2283 zombies (Bug#8467).
aac0c6e3 2284
04c56954
EZ
22852011-04-19 Eli Zaretskii <eliz@gnu.org>
2286
2287 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2288 gl_state.e_property when gl_state.object is Qt.
2289
2290 * insdel.c (make_gap_larger): Remove limitation of buffer size
2291 to <= INT_MAX.
2292
16a43933
CY
22932011-04-18 Chong Yidong <cyd@stupidchicken.com>
2294
2295 * xdisp.c (lookup_glyphless_char_display)
2296 (produce_glyphless_glyph): Handle cons cell entry in
2297 glyphless-char-display.
2298 (Vglyphless_char_display): Document it.
2299
2300 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2301 glyphless-char-display.
2302
4581706e
CY
23032011-04-17 Chong Yidong <cyd@stupidchicken.com>
2304
2305 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2306
2307 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2308
2309 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2310 definition for no-X builds.
2311
4887c6e2 23122011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2313
fd35b6f9
PE
2314 Static checks with GCC 4.6.0 and non-default toolkits.
2315
5c1ccb01
PE
2316 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2317
006c5daa
PE
2318 * process.c (keyboard_bit_set): Define only if SIGIO.
2319 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2320 (send_process): Repair possible setjmp clobbering.
2321
efc736d3
PE
2322 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2323
4e2fe2e6
PE
2324 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2325
f97334a2
PE
2326 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2327
4e75f29d
PE
2328 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2329 Define only if needed.
2330
90efadd1
PE
2331 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2332 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2333 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2334
3c647824
PE
2335 * dispextern.h (struct redisplay_interface): Rename param
2336 to avoid shadowing.
e264f262 2337 * termhooks.h (struct terminal): Likewise.
761383f4 2338 * xterm.c (xembed_send_message): Likewise.
3c647824 2339
b58c5c4a
PE
2340 * insdel.c (make_gap_smaller): Define only if
2341 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2342
cad59032
PE
2343 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2344 it.
2345
c339dc2e
PE
2346 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2347 so that we aren't warned about unused symbols.
2348
91a3e27b
PE
2349 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2350
399c71d3 2351 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2352
8ffc96f5
PE
2353 * xfns.c (x_real_positions): Mark locals as initialized.
2354
eef9bc79
PE
2355 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2356
098db9dd
PE
2357 * xterm.c: Fix problems found by static analysis with other toolkits.
2358 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2359 (x_dispatch_event): Declare static if USE_GTK, and
2360 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2361 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2362 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2363 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2364 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2365
eb18f6cc
PE
2366 * xmenu.c (menu_help_callback): Pointer type fixes.
2367 Use const pointers when pointing at readonly data. Avoid pointer
2368 signedness clashes.
2369 (FALSE): Remove unused macro.
2370 (update_frame_menubar): Remove unused decl.
2371
1fe72bf8
PE
2372 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2373
60d9e1db
PE
2374 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2375 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2376 (single_menu_item): Rename local to avoid shadowing.
2377
39261c26
PE
2378 * keyboard.c (make_lispy_event): Remove unused local var.
2379
018c5e19
PE
2380 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2381 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2382
63d2b86e
PE
2383 * bitmaps: Change bitmaps from unsigned char back to the X11
2384 compatible char. Avoid the old compiler warnings about
2385 out-of-range initializers by using, for example, '\xab' rather
2386 than 0xab.
2387
aefd87e1
PE
2388 * xgselect.c (xgselect_initialize): Check vs interface
2389 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2390
bf501fb9
PE
2391 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2392
e9829fdf
PE
2393 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2394 to read-only memory.
2395
1086c095
PE
2396 * fns.c (vector): Remove; this old hack is no longer needed.
2397
2baccd04 2398 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2399 Remove unused var.
dde42981 2400 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2401
72391843 2402 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2403
436c16df 2404 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2405 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2406 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2407
92bb796d 2408 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2409 (x_term_init): Remove local to avoid shadowing.
92bb796d 2410
764430a3 2411 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2412
2413 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2414 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2415
d1dfb56c
EZ
24162011-04-16 Eli Zaretskii <eliz@gnu.org>
2417
c4354cb4
EZ
2418 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2419
d1dfb56c
EZ
2420 Fix regex.c, syntax.c and friends for buffers > 2GB.
2421 * syntax.h (struct gl_state_s): Declare character position members
2422 EMACS_INT.
2423
2424 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2425
04f2d78b
CB
2426 * textprop.c (verify_interval_modification, interval_of):
2427 Declare arguments EMACS_INT.
d1dfb56c
EZ
2428
2429 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2430 EMACS_INT.
2431
2432 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2433
2434 * indent.c (Fvertical_motion): Local variable it_start is now
2435 EMACS_INT.
2436
2437 * regex.c (re_match, re_match_2, re_match_2_internal)
2438 (bcmp_translate, regcomp, regexec, print_double_string)
2439 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2440 (re_compile_pattern, re_exec): Declare arguments and local
2441 variables `size_t' and `ssize_t' and return values `regoff_t', as
2442 appropriate.
2443 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2444 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2445 <compile_stack_type>: `size' and `avail' are now `size_t'.
2446
2447 * regex.h <regoff_t>: Use ssize_t, not int.
2448 (re_search, re_search_2, re_match, re_match_2): Arguments that
2449 specify buffer/string position and length are now ssize_t and
2450 size_t. Return type is regoff_t.
2451
613052cd
BK
24522011-04-16 Ben Key <bkey76@gmail.com>
2453
2454 * nsfont.m: Fixed bugs in ns_get_family and
2455 ns_descriptor_to_entity that were caused by using free to
2456 deallocate memory blocks that were allocated by xmalloc (via
2457 xstrdup). This caused Emacs to crash when compiled with
2458 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2459 --enable-checking=xmallocoverrun). xfree is now used to
2460 deallocate these memory blocks.
2461
4170f62f 24622011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2463
71b41406
PE
2464 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2465
9587a89d
PE
2466 emacs_write: Accept and return EMACS_INT for sizes.
2467 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2468 et seq.
2469 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2470 Accept and return EMACS_INT.
2471 (emacs_gnutls_write): Return the number of bytes written on
2472 partial writes.
2473 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2474 (emacs_read, emacs_write): Remove check for negative size, as the
2475 Emacs source code has been audited now.
9587a89d
PE
2476 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2477 (emacs_read, emacs_write): Use it.
273a5f82
PE
2478 * process.c (send_process): Adjust to the new signatures of
2479 emacs_write and emacs_gnutls_write. Do not attempt to store
2480 a byte offset into an 'int'; it might overflow.
9587a89d 2481 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2482
3e047f51
PE
2483 * sound.c: Don't assume sizes fit in 'int'.
2484 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2485 Return EMACS_INT, not int.
3e047f51 2486 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2487 Accept EMACS_INT, not int.
2488 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2489 record read return values.
2490
cc39a9db
BK
24912011-04-15 Ben Key <bkey76@gmail.com>
2492
c9d0ec6d
JB
2493 * keyboard.c (Qundefined): Don't declare static since it is used
2494 in nsfns.m.
2495 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2496 static since they are used in nsfont.m.
cc39a9db 2497
6c60eb9f
SM
24982011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2499
2500 * process.c (Qprocessp): Don't declare static.
2501 * lisp.h (Qprocessp): Declare again.
2502
7990b61a
JB
25032011-04-15 Juanma Barranquero <lekktu@gmail.com>
2504
2505 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2506
5d4cb038
PE
25072011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2508
8bd7b830 2509 Improve C-level modularity by making more things 'static'.
cd64ea1d 2510
e3b27b31
PE
2511 Don't publish debugger-only interfaces to other modules.
2512 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2513 (verify_bytepos, count_markers): Move decls to the only modules
2514 that need them.
2515 * region-cache.h (pp_cache): Likewise.
2516 * window.h (check_all_windows): Likewise.
2517 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2518
5d4cb038
PE
2519 * sysdep.c (croak): Now static, if
2520 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2521 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2522
2523 * alloc.c (refill_memory_reserve): Now static if
2524 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2525 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2526
e87b6180
PE
2527 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2528 Define only if USE_LUCID.
2529
ac64929e
PE
2530 * xrdb.c (x_customization_string, x_rm_string): Now static.
2531
6f37259d
PE
2532 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2533 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2534
1683e3ab
PE
2535 * xdisp.c (draw_row_with_mouse_face): Now static.
2536 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2537
de9c2632
PE
2538 * window.h (check_all_windows): Mark externally visible.
2539
2b96acb7
PE
2540 * window.c (window_deletion_count): Now static.
2541
2542 * undo.c: Make symbols static if they're not exported.
2543 (last_undo_buffer, last_boundary_position, pending_boundary):
2544 Now static.
2545
50436f33
PE
2546 * textprop.c (interval_insert_behind_hooks): Now static.
2547 (interval_insert_in_front_hooks): Likewise.
2548
64520e5c
PE
2549 * term.c: Make symbols static if they're not exported.
2550 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2551 (max_frame_lines, tty_set_terminal_modes):
2552 (tty_reset_terminal_modes, tty_turn_off_highlight):
2553 (get_tty_terminal): Now static.
2554 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2555 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2556 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2557 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2558 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2559
1fa53021
PE
2560 * sysdep.c: Make symbols static if they're not exported.
2561 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2562 Now static.
2563 (sigprocmask_set, full_mask): Remove; unused.
2564 (wait_debugging): Mark as visible.
2565 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2566 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2567
d4b43b22
PE
2568 * syntax.c (syntax_temp): Define only if !__GNUC__.
2569
b7c513d0
PE
2570 * sound.c (current_sound_device, current_sound): Now static.
2571
989b29ad
PE
2572 * search.c (searchbufs, searchbuf_head): Now static.
2573
13a55a78
PE
2574 * scroll.c (scroll_cost): Remove; unused.
2575 * dispextern.h (scroll_cost): Remove decl.
2576
de68a1fc
PE
2577 * region-cache.h (pp_cache): Mark as externally visible.
2578
40ccffa6
PE
2579 * process.c: Make symbols static if they're not exported.
2580 (process_tick, update_tick, create_process, chan_process):
2581 (Vprocess_alist, proc_buffered_char, datagram_access):
2582 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2583 (deactivate_process): Mark defn as static, as well as decl.
2584 * lisp.h (create_process): Remove decl.
2585 * process.h (chan_process, Vprocess_alist): Remove decls.
2586
ad64fc97
PE
2587 * print.c: Make symbols static if they're not exported.
2588 (print_depth, new_backquote_output, being_printed, print_buffer):
2589 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2590 (print_interval, print_number_index, initial_stderr_stream):
2591 Now static.
2592 * lisp.h (Fprinc): Remove decl.
2593 (debug_output_compilation_hack): Mark as externally visible.
2594
adddb265
PE
2595 * sysdep.c (croak): Move decl from here to syssignal.h.
2596 * syssignal.h (croak): Put it here, so the API can be checked when
2597 'croak' is called from dissociate_if_controlling_tty.
2598
1717ede2
PE
2599 * minibuf.c: Make symbols static if they're not exported.
2600 (minibuf_save_list, choose_minibuf_frame): Now static.
2601 * lisp.h (choose_minibuf_frame): Remove decl.
2602
fa5fb2bc
PE
2603 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2604
1e3890d1
PE
2605 * lread.c: Make symbols static if they're not exported.
2606 (read_objects, initial_obarray, oblookup_last_bucket_number):
2607 Now static.
2608 (make_symbol): Remove; unused.
2609 * lisp.h (initial_obarray, make_symbol): Remove decls.
2610
8a1414fa
PE
2611 * keyboard.c: Make symbols static if they're not exported.
2612 (single_kboard, recent_keys_index, total_keys, recent_keys):
2613 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2614 (this_single_command_key_start, echoing, last_auto_save):
2615 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2616 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2617 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2618 (Vlispy_mouse_stem, double_click_count):
2619 Now static.
2620 (force_auto_save_soon): Define only if SIGDANGER.
2621 (ignore_mouse_drag_p): Now static if
2622 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2623 (print_help): Remove; unused.
2624 (stop_character, last_timer_event): Mark as externally visible.
2625 * keyboard.h (ignore_mouse_drag_p): Declare only if
2626 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2627 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2628 * lisp.h (echoing): Remove decl.
2629 (force_auto_save_soon): Declare only if SIGDANGER.
2630 * xdisp.c (redisplay_window): Simplify code, to make it more
2631 obvious that ignore_mouse_drag_p is not accessed if !defined
2632 USE_GTK && !defined HAVE_NS.
2633
93ea6e8f
PE
2634 * intervals.c: Make symbols static if they're not exported.
2635 (merge_properties_sticky, merge_interval_right, delete_interval):
2636 Now static.
2637 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2638
77382fcc
PE
2639 * insdel.c: Make symbols static if they're not exported.
2640 However, leave prepare_to_modify_buffer alone. It's never
2641 called from outside this function, but that appears to be a bug.
2642 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2643 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2644 (adjust_after_replace_noundo): Remove; unused.
2645 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2646 (signal_before_change): Remove decls.
77382fcc 2647
9306c32e
PE
2648 * indent.c (val_compute_motion, val_vmotion): Now static.
2649
cd44d2eb
PE
2650 * image.c: Make symbols static if they're not exported.
2651 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2652 if USE_GTK.
2653 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2654 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2655
ad9a7a06
PE
2656 * fringe.c (standard_bitmaps): Now static.
2657 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2658
81626931
PE
2659 * frame.c: Make symbols static if they're not exported.
2660 (x_report_frame_params, make_terminal_frame): Now static.
2661 (get_frame_param): Now static, unless HAVE_NS.
2662 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2663 (x_get_resource_string): Remove; not used.
2664 * frame.h (make_terminal_frame, x_report_frame_params):
2665 (x_get_resource_string); Remove decls.
2666 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2667 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2668
239f9db9
PE
2669 * font.c, fontset.c: Make symbols static if they're not exported.
2670 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2671 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2672 * font.c (font_close_object): Now static.
2673 * font.h (font_close_object): Remove.
2674 * fontset.c (FONTSET_OBJLIST): Remove.
2675 (free_realized_fontset) #if-0 the body, which does nothing.
2676 (face_suitable_for_char_p): #if-0, as it's never called.
2677 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2678 * xfaces.c (face_at_string_position):
2679 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2680 since 0 is always ASCII.
2681
dfcf3579
PE
2682 * fns.c (weak_hash_tables): Now static.
2683
5045092b
PE
2684 * fileio.c: Make symbols static if they're not exported.
2685 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2686 (Vwrite_region_annotation_buffers): Now static.
2687
57a96f5c
PE
2688 * eval.c: Make symbols static if they're not exported.
2689 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2690 * lisp.h (backtrace_list): Remove decl.
2691
35f08c38
PE
2692 * emacs.c: Make symbols static if they're not exported.
2693 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2694 (fatal_error_code, fatal_error_signal_hook, standard_args):
2695 Now static.
2696 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2697 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2698 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2699 * lisp.h (fatal_error_signal_hook): Remove decl.
2700 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2701
f44bd759
PE
2702 * editfns.c: Move a (normally-unused) function to its only use.
2703 * editfns.c, lisp.h (get_operating_system_release): Remove.
2704 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2705 worth the hassle of breaking this out.
2706
b532497d
PE
2707 * xterm.c: Make symbols static if they're not exported.
2708 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2709 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2710 (x_destroy_window, x_delete_display):
2711 Now static.
2712 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2713 (x_mouse_leave): Remove; unused.
2714 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2715 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2716 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2717 Remove decls.
2718 (x_mouse_leave): Declare only if WINDOWSNT.
2719 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2720 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2721 USE_X_TOOLKIT.
2722
1675728f
PE
2723 * ftxfont.c: Make symbols static if they're not exported.
2724 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2725 HAVE_FREETYPE.
2726 * font.h (ftxfont_driver): Likewise.
2727
e4cebfca
PE
2728 * xfns.c: Make symbols static if they're not exported.
2729 (x_last_font_name, x_display_info_for_name):
2730 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2731 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2732 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2733 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2734 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2735 (last_show_tip_args): Now static.
2736 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2737 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2738 (x_screen_planes): Remove; unused.
2739 * dispextern.h (x_screen_planes): Remove decl.
2740
5bf46f05
PE
2741 * dispnew.c: Make symbols static if they're not exported.
2742 * dispextern.h (redraw_garbaged_frames, scrolling):
2743 (increment_row_positions): Remove.
2744 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2745 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2746 Now static.
2747 (redraw_garbaged_frames): Remove; unused.
2748
435f4c28
PE
2749 * xfaces.c: Make symbols static if they're not exported.
2750 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2751 Remove decls.
2752 * xterm.h (defined_color): Remove decls.
2753 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2754 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2755 (menu_face_changed_default, defined_color, free_realized_face):
2756 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2757 (ascii_face_of_lisp_face): Remove; unused.
2758
8524aef3
PE
2759 * xdisp.c: Make symbols static if they're not exported.
2760 * dispextern.h (scratch_glyph_row, window_box_edges):
2761 (glyph_to_pixel_coords, set_cursor_from_row):
2762 (get_next_display_element, set_iterator_to_next):
2763 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2764 (show_mouse_face): Remove decls
2765 * frame.h (message_buf_print): Likewise.
2766 * lisp.h (pop_message, set_message, check_point_in_composition):
2767 Likewise.
2768 * xterm.h (set_vertical_scroll_bar): Likewise.
2769 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2770 (message_buf_print, scratch_glyph_row, displayed_buffer):
2771 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2772 (get_next_display_element, show_mouse_face, window_box_edges):
2773 (frame_to_window_pixel_xy, check_point_in_composition):
2774 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2775 (glyph_to_pixel_coords): Remove; unused.
2776
16390cd2
PE
2777 * dired.c (file_name_completion): Now static.
2778
2779 * dbusbind.c (xd_in_read_queued_messages): Now static.
2780
a25f4dfa
PE
2781 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2782 * data.c (circular_list_error): Remove.
2783
14a9c8df
PE
2784 * commands.h (last_point_position, last_point_position_buffer):
2785 (last_point_position_window): Remove decls.
2786 * keyboard.c: Make these variables static.
2787
04f2d78b
CB
2788 * coding.h (coding, code_convert_region, encode_coding_gap):
2789 Remove decls.
74ab6df5
PE
2790 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2791 (iso_code_class, detect_coding, code_convert_region): Now static.
2792 (encode_coding_gap): Remove; unused.
2793
38dfbee1
PE
2794 * chartab.c (chartab_chars, chartab_bits): Now static.
2795
a2cb4e63
PE
2796 * charset.h (charset_iso_8859_1): Remove decl.
2797 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2798 Now static.
2799
127198fd
PE
2800 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2801 * ccl.c (Vccl_program_table): Now static.
2802 (check_ccl_update): Remove; unused.
2803
d85b608f
PE
2804 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2805 * category.h: ... from here.
2806 * category.c (check_category_table, set_category_set): Now static.
2807
31cd66f3
PE
2808 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2809 * lisp.h: Remove these decls.
2810
c358e587
PE
2811 * buffer.c (buffer_count): Remove unused var.
2812
e78aecca
PE
2813 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2814 so that it's not optimized away.
2815 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2816 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2817 exported only to the debugger.
2818
e192d7d3 2819 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2820 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2821
92470028
PE
2822 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2823 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2824 was inaccessible from Lisp.
2825 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2826 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2827
244ed907
PE
2828 alloc.c: Import and export fewer symbols, and remove unused items.
2829 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2830 is defined.
2831 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2832 it's not optimized away by whole-program optimization.
2833 (message_enable_multibyte, free_misc): Remove.
2834 (catchlist, handlerlist, mark_backtrace):
2835 Declare only if BYTE_MARK_STACK.
2836 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2837 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2838 (message_enable_multibyte): Remove decl.
2839 (free_misc, interval_free_list, float_block, float_block_index):
2840 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2841 (cons_free_list, last_marked_index):
2842 Now static.
2843 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2844 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2845 (mark_backtrace): Define only if BYTE_MARK_STACK.
2846 * xdisp.c (message_enable_multibyte): Now static.
2847
61c2b50e 2848 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2849 This makes it easier for human readers (and static analyzers)
2850 to see whether these variables are used from other modules.
2851 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2852 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2853 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2854 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2855 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2856 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2857 * xmenu.c, xselect.c:
2858 Declare Q* vars static if they are not used in other modules.
2859 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2860 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2861 Remove decls of unexported vars.
2862 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2863
95c82688
PE
2864 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2865
16a97296
PE
2866 Make Emacs functions such as Fatom 'static' by default.
2867 This makes it easier for human readers (and static analyzers)
2868 to see whether these functions can be called from other modules.
2869 DEFUN now defines a static function. To make the function external
2870 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2871 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2872 (Finit_image_library):
16a97296
PE
2873 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2874 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2875 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2876 Remove decls, since these functions are now static.
2877 (Funintern, Fget_internal_run_time): New decls, since these functions
2878 were already external.
95c82688 2879
16a97296
PE
2880 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2881 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2882 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2883 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2884 * keyboard.c, keymap.c, lread.c:
2885 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2886 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2887 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2888 Mark functions with DEFUE instead of DEFUN,
2889 if they are used in other modules.
2890 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2891 decls for now-static functions.
2892 * buffer.h (Fdelete_overlay): Remove decl.
2893 * callproc.c (Fgetenv_internal): Mark as internal.
2894 * composite.c (Fremove_list_of_text_properties): Remove decl.
2895 (Fcomposition_get_gstring): New forward static decl.
2896 * composite.h (Fcomposite_get_gstring): Remove decl.
2897 * dired.c (Ffile_attributes): New forward static decl.
2898 * doc.c (Fdocumntation_property): New forward static decl.
2899 * eval.c (Ffetch_bytecode): New forward static decl.
2900 (Funintern): Remove extern decl; now in .h file where it belongs.
2901 * fileio.c (Fmake_symbolic_link): New forward static decl.
2902 * image.c (Finit_image_library): New forward static decl.
2903 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2904 * intervals.h (Fprevious_property_change):
2905 (Fremove_list_of_text_properties): Remove decls.
2906 * keyboard.c (Fthis_command_keys): Remove decl.
2907 (Fcommand_execute): New forward static decl.
2908 * keymap.c (Flookup_key): New forward static decl.
2909 (Fcopy_keymap): Now static.
2910 * keymap.h (Flookup_key): Remove decl.
2911 * process.c (Fget_process): New forward static decl.
2912 (Fprocess_datagram_address): Mark as internal.
2913 * syntax.c (Fsyntax_table_p): New forward static decl.
2914 (skip_chars): Remove duplicate decl.
2915 * textprop.c (Fprevious_property_change): New forward static decl.
2916 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2917 Now internal.
2918 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2919 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2920
785bbd42
PE
2921 * editfns.c (Fformat): Remove unreachable code.
2922
8b913b57
AS
29232011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2924
2925 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2926 change. (Bug#8496)
2927
a6744a35
EZ
29282011-04-13 Eli Zaretskii <eliz@gnu.org>
2929
2930 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2931 when at ZV. (Bug#8487)
2932
e7974947
AS
29332011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2934
baad03f0
AS
2935 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2936 (Bug#8437)
2937 * keyboard.c (parse_tool_bar_item): Likewise.
2938 * sound.c (sound_cleanup, alsa_close): Likewise.
2939 * termcap.c (tgetent): Likewise.
2940 * xfns.c (x_default_font_parameter): Likewise.
2941 * xsettings.c (read_and_apply_settings): Likewise.
2942
e7974947
AS
2943 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2944 (overrun_check_free): Protoize.
2945
28272684
PE
29462011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2947
2948 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2949 since callers should never pass a negative size.
2950 Change the signature to match that of plain 'read' and 'write'; see
2951 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2952 * lisp.h: Update prototypes of emacs_write and emacs_read.
2953
11997c76
EZ
29542011-04-11 Eli Zaretskii <eliz@gnu.org>
2955
2956 * xdisp.c (redisplay_window): Don't try to determine the character
2957 position of the scroll margin if the window start point w->startp
e896f03c 2958 is outside the buffer's accessible region. (Bug#8468)
11997c76 2959
8a2cbd72
EZ
29602011-04-10 Eli Zaretskii <eliz@gnu.org>
2961
2962 Fix write-region and its subroutines for buffers > 2GB.
2963 * fileio.c (a_write, e_write): Modify declaration of arguments and
2964 local variables to support buffers larger than 2GB.
2965 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2966
2967 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2968 argument, local variables, and return value.
2969
2970 * lisp.h: Update prototypes of emacs_write and emacs_read.
2971
2972 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2973
4073e537 29742011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2975
1ebfdcb6
PE
2976 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2977
b2ded58d
PE
2978 Fix more problems found by GCC 4.6.0's static checks.
2979
7d66342c
PE
2980 * xdisp.c (vmessage): Use a better test for character truncation.
2981
bbf47d44
PE
2982 * charset.c (load_charset_map): <, not <=, for optimization,
2983 and to avoid potential problems with integer overflow.
9248994d 2984 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2985 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2986 * editfns.c (Fformat): Likewise.
1e69125e 2987 * syntax.c (skip_chars): Likewise.
3befa583 2988
e3019616
PE
2989 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2990 This also lets GCC 4.6.0 generate slightly better loop code.
2991
becfa255
PE
2992 * callint.c (Fcall_interactively): <, not <=, for optimization.
2993 (Fcall_interactively): Count the number of arguments produced,
2994 not the number of arguments given. This is simpler and lets GCC
2995 4.6.0 generate slightly better code.
2996
dae0cd48
PE
2997 * ftfont.c: Distingish more carefully between FcChar8 and char.
2998 The previous code passed unsigned char * to a functions like
2999 strlen and xstrcasecmp that expect char *, which does not
3000 conform to the C standard.
3001 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3002 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3003 char * when the C standard requires it.
3004
76032d70
PE
3005 * keyboard.c (read_char): Remove unused var.
3006
eb3f1cc8
PE
3007 * eval.c: Port to Windows vsnprintf (Bug#8435).
3008 Include <limits.h>.
3009 (SIZE_MAX): Define if the headers do not.
3010 (verror): Do not give up if vsnprintf returns a negative count.
3011 Instead, grow the buffer. This ports to Windows vsnprintf, which
3012 does not conform to C99. Problem reported by Eli Zaretskii.
3013 Also, simplify the allocation scheme, by avoiding the need for
3014 calling realloc, and removing the ALLOCATED variable.
3015
70476b54
PE
3016 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3017
12020a9e
PE
3018 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3019 But keep the doprint source code for now, as we might revamp it
3020 and use it again (Bug#8435).
ea6c7ae6
PE
3021 * lisp.h (doprnt): Remove.
3022 * Makefile.in (base_obj): Remove doprnt.o.
3023 * deps.mk (doprnt.o): Remove.
3024
5fdb398c
PE
3025 error: Print 32- and 64-bit integers portably (Bug#8435).
3026 Without this change, on typical 64-bit hosts error ("...%d...", N)
3027 was used to print both 32- and 64-bit integers N, which relied on
3028 undefined behavior.
3029 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3030 New macro.
3031 * lisp.h (error, verror): Mark as printf-like functions.
3032 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3033 Report overflow in size calculations when allocating printf buffer.
3034 Do not truncate output string at its first null byte.
3035 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3036 Truncate the output at a character boundary, since vsnprintf does not
3037 do that.
3038 * charset.c (check_iso_charset_parameter): Convert internal
3039 character to string before calling 'error', since %c now has the
3040 printf meaning.
3041 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3042 overflow when computing char to be passed to 'error'. Do not
3043 pass Lisp_Object to 'error'; pass the integer instead.
3044 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3045 formatted with plain %d.
3046
b189fa66
PE
3047 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3048
bff87ef0
PE
3049 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3050
7e2cac20
PE
3051 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3052
ce4d90b5
PE
3053 * xterm.c (x_catch_errors): Remove duplicate declaration.
3054
266c9547
PE
3055 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3056
79c49ad2
PE
3057 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3058
368f4090
JM
30592011-04-10 Jim Meyering <meyering@redhat.com>
3060
3061 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3062 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3063 return ssize_t not "int", and use size_t as the buffer length.
3064 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3065 * gnutls.h: Update declarations.
3066 * process.c (read_process_output): Use ssize_t, to match.
3067 (send_process): Likewise.
3068
a32d4040
CY
30692011-04-09 Chong Yidong <cyd@stupidchicken.com>
3070
3071 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3072
8546720e 30732011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3074
04f2d78b
CB
3075 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3076 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3077
8546720e
GM
3078 * xterm.c (handle_one_xevent):
3079 * xmenu.c (create_and_show_popup_menu):
3080 * xselect.c (x_decline_selection_request)
3081 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3082
0a2f5c1a 30832011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3084
3085 Fix some uses of `int' instead of EMACS_INT.
3086 * search.c (string_match_1, fast_string_match)
3087 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3088 (scan_buffer, find_next_newline_no_quit)
3089 (find_before_next_newline, search_command, Freplace_match)
3090 (Fmatch_data): Make some `int' variables be EMACS_INT.
3091
3092 * xdisp.c (display_count_lines): 3rd argument and return value now
3093 EMACS_INT. All callers changed.
3094 (pint2hrstr): Last argument is now EMACS_INT.
3095
3096 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3097 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3098 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3099 (decode_coding_utf_16, decode_coding_emacs_mule)
3100 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3101 (decode_coding_ccl, decode_coding_charset)
3102 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3103 (decode_coding_iso_2022, decode_coding_emacs_mule)
3104 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3105 <char_offset, last_offset>: Declare EMACS_INT.
3106 (encode_coding_utf_8, encode_coding_utf_16)
3107 (encode_coding_emacs_mule, encode_invocation_designation)
3108 (encode_designation_at_bol, encode_coding_iso_2022)
3109 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3110 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3111 Declare EMACS_INT.
3112 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3113 (encode_invocation_designation): Last argument P_NCHARS is now
3114 EMACS_INT.
3115 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3116 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3117
3118 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3119 All users changed.
3120
3121 * ccl.c (Fccl_execute_on_string): Declare some variables
3122 EMACS_INT.
3123
8546720e 31242011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3125
3126 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3127
4e19a977
CS
31282011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3129
3130 * process.c (Fformat_network_address): Doc fix.
3131
87302331
R
31322011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3133
3134 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3135
cbb59342
CY
31362011-04-08 Chong Yidong <cyd@stupidchicken.com>
3137
3138 * keyboard.c (read_char): Call Lisp function help-form-show,
3139 instead of using internal_with_output_to_temp_buffer.
3140 (Qhelp_form_show): New var.
e0d38eeb 3141 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3142
3143 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3144
3145 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3146
e67a13ab
CY
31472011-04-06 Chong Yidong <cyd@stupidchicken.com>
3148
04f2d78b
CB
3149 * process.c (Flist_processes): Remove to Lisp.
3150 (list_processes_1): Delete.
e67a13ab 3151
973f782d
EZ
31522011-04-06 Eli Zaretskii <eliz@gnu.org>
3153
7c106b1e
EZ
3154 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3155
973f782d
EZ
3156 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3157
41cf7d1a 31582011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3159
ca23cc88
PE
3160 Fix more problems found by GCC 4.6.0's static checks.
3161
f390e2d5
PE
3162 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3163
42eea0d0
PE
3164 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3165
b69769da 3166 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3167
f9541e84
PE
3168 * xdisp.c (vmessage): Mark as a printf-like function.
3169
13841b55
PE
3170 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3171
c136c10f
PE
3172 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3173
5e2d4a30
PE
3174 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3175 printf-like functions.
3176 (tiff_load): Add casts to remove these marks before passing them
3177 to system-supplied API.
3178
583f48b9
PE
3179 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3180
b25d760e
PE
3181 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3182 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3183 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3184 directly, rather than having caller test rule sign. This avoids
3185 some unnecessary tests.
3186 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3187 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3188 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3189
bc7b6697 3190 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3191 (xfont_open): Avoid unnecessary tests.
bc7b6697 3192
27ccc379
PE
3193 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3194
dcd5c89a
PE
3195 * composite.h, composite.c (composition_gstring_put_cache):
3196 Use EMACS_INT, not int, for length.
3197
b13a45c6
PE
3198 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3199 breaking out part of COMPOSITION_DECODE_RULE.
3200 (COMPOSITION_DECODE_RULE): Use it.
3201 * composite.c (get_composition_id): Remove unused local vars,
3202 by using the new macro.
3203
1e792e4d
PE
3204 * textprop.c (set_text_properties_1): Change while to do-while,
3205 since the condition is always true at first.
3206
dc6c6455 3207 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3208 (interval_deletion_adjustment): Return unsigned value.
3209 All uses changed.
dc6c6455 3210
aba7731a
PE
3211 * process.c (list_processes_1, create_pty, read_process_output):
3212 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3213 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3214 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3215 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3216 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3217
fdfc4bf3
PE
3218 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3219
fca8fe46 3220 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3221 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3222
06a0259a 3223 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3224 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3225 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3226
e7b9e80f
PE
3227 * print.c (print_error_message): Avoid int overflow.
3228
56201685
PE
3229 * font.c (font_list_entities): Redo for clarity,
3230 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3231
78834453 3232 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3233 (font_score): Avoid potential overflow in diff calculation.
78834453 3234
0bc0b309 3235 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3236 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3237
e610eaca
PE
3238 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3239
b895abce
PE
3240 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3241 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3242 can always succeed if overflow has undefined behavior.
3243
1f1d9321 3244 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3245 (wordify): Omit three unnecessary tests.
1f1d9321 3246
c59478bc
PE
3247 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3248 All callers changed. This avoids the need for an unused var.
3249
79b73827
PE
3250 * casefiddle.c (casify_region): Remove var that is set but not used.
3251
a4db5dfe
PE
3252 * dired.c (file_name_completion): Remove var that is set but not used.
3253
43aae36e
PE
3254 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3255
2a47c44d 3256 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3257 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3258
a37c69bf
PE
3259 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3260 Check for integer overflow on size calculations.
3261
328ab8e7
PE
3262 * buffer.c (Fprevious_overlay_change): Remove var that is set
3263 but not used.
3264
e5a2a5cb
PE
3265 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3266 Remove vars that are set but not used.
8d84a6eb 3267 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3268 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3269
a60e5f68
PE
3270 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3271
f661cb61 3272 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3273 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3274
f0397f5a
PE
3275 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3276 that are set but not used.
3277
8664db06 3278 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3279 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3280
6abdaa4a
PE
3281 * xselect.c (x_get_local_selection, x_handle_property_notify):
3282 Remove vars that are set but not used.
3283
0ce7538d 3284 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3285 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3286
9ae848fc
PE
3287 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3288 Remove var that is set but not used.
0b918413
PE
3289 (scroll_bar_windows_size): Now size_t, not int.
3290 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3291 Check for overflow.
9ae848fc 3292
a5a62657
PE
3293 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3294 (map_tty_color) [!defined MSDOS]: Likewise.
3295
5c5cdd39
PE
3296 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3297
66ebf983
PE
3298 * coding.c: Remove vars that are set but not used.
3299 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3300 All callers changed.
3301 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3302 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3303 (decode_coding_charset): Remove vars that are set but not used.
3304
1be4d761
PE
3305 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3306 that is set but not used.
3307
47553fa8
PE
3308 * print.c (print_object): Remove var that is set but not used.
3309
1f7196bf 3310 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3311 The gnulib version avoids calling malloc in the usual case,
3312 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3313 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3314 * filelock.c (current_lock_owner): Likewise.
3315 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3316 * sysdep.c: Include allocator.h, careadlinkat.h.
3317 (emacs_no_realloc_allocator): New static constant.
3318 (emacs_readlink): New function.
fdb61804
PE
3319 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3320 ../lib/careadlinkat.h.
d1fdcab7 3321
f84c17c7
SM
33222011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3323
3324 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3325 first non-nil return value).
3326
ef3862ad
JD
33272011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3328
3329 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3330 if not defined (Bug#8403).
3331
376a7006
JB
33322011-04-02 Juanma Barranquero <lekktu@gmail.com>
3333
3334 * xdisp.c (display_count_lines): Remove parameter `start',
3335 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3336 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3337 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3338 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3339 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3340 and thereabouts. All callers changed.
3341 (get_per_char_metric): Remove parameter `f', unused since
3342 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3343
6ca3801d
JM
33442011-04-02 Jim Meyering <meyering@redhat.com>
3345
3346 do not dereference NULL upon failed strdup
3347 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3348 (ns_get_family): Likewise.
3349
d8e2b5ba
JB
33502011-04-02 Juanma Barranquero <lekktu@gmail.com>
3351
3352 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3353
8c74fcbd
JD
33542011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3355
3356 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3357 later (Bug#8403).
3358
7200d79c
SM
33592011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3360
03408648 3361 Add lexical binding.
7200d79c 3362
03408648
SM
3363 * window.c (Ftemp_output_buffer_show): New fun.
3364 (Fsave_window_excursion):
3365 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3366
3367 * lread.c (lisp_file_lexically_bound_p): New function.
3368 (Fload): Bind Qlexical_binding.
3369 (readevalloop): Remove `evalfun' arg.
3370 Bind Qinternal_interpreter_environment.
3371 (Feval_buffer): Bind Qlexical_binding.
3372 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3373 Mark as dynamic.
3374 (syms_of_lread): Declare `lexical-binding'.
3375
3376 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3377
3378 * keyboard.c (eval_dyn): New fun.
3379 (menu_item_eval_property): Use it.
ca105506
SM
3380
3381 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3382
03408648
SM
3383 * fns.c (concat, mapcar1): Accept byte-code-functions.
3384
3385 * eval.c (Fsetq): Handle lexical vars.
3386 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3387 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3388 (FletX, Flet): Obey lexical binding.
3389 (Fcommandp): Handle closures.
3390 (Feval): New `lexical' arg.
3391 (eval_sub): New function extracted from Feval. Use it almost
3392 everywhere where Feval was used. Look up vars in lexical env.
3393 Handle closures.
3394 (Ffunctionp): Move from subr.el.
3395 (Ffuncall): Handle closures.
3396 (apply_lambda): Remove `eval_flags'.
3397 (funcall_lambda): Handle closures and new byte-code-functions.
3398 (Fspecial_variable_p): New function.
3399 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3400 but without exporting it to Lisp.
23aba0ea 3401
23aba0ea 3402 * doc.c (Fdocumentation, store_function_docstring):
03408648 3403 * data.c (Finteractive_form): Handle closures.
23aba0ea 3404
03408648
SM
3405 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3406 interactive spec.
ba83908c 3407
04f2d78b
CB
3408 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3409 New byte-codes.
03408648
SM
3410 (exec_byte_code): New function extracted from Fbyte_code to handle new
3411 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3412
03408648 3413 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3414
03408648 3415 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3416
e2abce01
JB
34172011-03-31 Juanma Barranquero <lekktu@gmail.com>
3418
3419 * xdisp.c (redisplay_internal): Fix prototype.
3420
63696a73 34212011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3422
63696a73 3423 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3424 (try_scrolling): Use it when setting scroll_limit.
3425 Limit scrolling to 100 screen lines.
63696a73
EZ
3426 (redisplay_window): Even when falling back on "recentering",
3427 position point in the window according to scroll-conservatively,
3428 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3429
3430 (try_scrolling): When point is above the window, allow searching
3431 as far as scroll_max, or one screenful, to compute vertical
3432 distance from PT to the scroll margin position. This prevents
3433 try_scrolling from unnecessarily failing when
3434 scroll-conservatively is set to a value slightly larger than the
3435 window height. Clean up the case of PT below the margin at bottom
3436 of window: scroll_max can no longer be INT_MAX. When aggressive
3437 scrolling is in use, don't let point enter the opposite scroll
3438 margin as result of the scroll.
3439 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3440 threshold of 100 lines for never-recentering scrolling.
3441
e4cc2dfc
JB
34422011-03-31 Juanma Barranquero <lekktu@gmail.com>
3443
3444 * dispextern.h (move_it_by_lines):
3445 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3446 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3447 (message_log_check_duplicate): Remove parameters `prev_bol' and
3448 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3449 (redisplay_internal): Remove parameter `preserve_echo_area',
3450 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3451
3452 * indent.c (Fvertical_motion):
3453 * window.c (window_scroll_pixel_based, Frecenter):
3454 Don't pass `need_y_p' to `move_it_by_lines'.
3455
1c470562
SM
34562011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3457
44f230aa
SM
3458 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3459 steal a few bits to be more compact.
3460 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3461 Remove unneeded casts.
3462
1c470562
SM
3463 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3464
888adce9
ZK
34652011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3466
3467 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3468 binding" message (bug#7967).
3469
f838ed7b
PE
34702011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3471
77861b95
PE
3472 Fix more problems found by GCC 4.6.0's static checks.
3473
de6dbc14
PE
3474 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3475 Remove unused local var.
3476
f838ed7b
PE
3477 * editfns.c (Fmessage_box): Remove unused local var.
3478
792c7b2b
PE
3479 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3480 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3481 Omit unused local vars.
c499e557 3482 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3483 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3484 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3485 Omit unused local var.
3486
ba0165e1
PE
3487 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3488 Don't assume string length fits in int.
32ad8845 3489 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3490 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3491
3c59b4c9
PE
3492 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3493 instead of alloca (Bug#8344).
3494
a3eed478 3495 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3496 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3497
eb4d412d
PE
3498 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3499
1658b401
PE
3500 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3501 concerns.
3502
3503 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3504
3505 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3506
9a2c6e05
PE
3507 * keyboard.c (syms_of_keyboard): Use the same style as later
3508 in this function when indexing through an array. This also
3509 works around GCC bug 48267.
3510
03d0a109
PE
3511 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3512
44f730c8
PE
3513 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3514
fe75f926
PE
3515 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3516 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3517
ffa8c828
PE
3518 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3519 This avoids undefined behavior on integer overflow, and is a bit
3520 more convenient anyway since it is compared to a size_t variable.
3521
c5101a77
PE
3522 Variadic C functions now count arguments with size_t, not int.
3523 This avoids an unnecessary limitation on 64-bit machines, which
3524 caused (substring ...) to crash on large vectors (Bug#8344).
3525 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3526 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3527 All variadic functions and their callers changed accordingly.
c5101a77
PE
3528 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3529 * data.c (arith_driver, float_arith_driver): Likewise.
3530 * editfns.c (general_insert_function): Likewise.
3531 * eval.c (struct backtrace.nargs, interactive_p)
3532 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3533 (funcall_lambda, mark_backtrace): Likewise.
3534 * fns.c (concat): Likewise.
3535 * frame.c (x_set_frame_parameters): Likewise.
3536 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3537 0 if not found, not -1. All callers changed.
3538
dd3f25f7
PE
3539 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3540 (stack_copy_size): Now size_t, not int.
3541 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3542
461c2ab9
JB
35432011-03-28 Juanma Barranquero <lekktu@gmail.com>
3544
3545 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3546 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3547 All callers changed.
3548
3549 * lisp.h (multibyte_char_to_unibyte):
3550 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3551 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3552 * character.h (CHAR_TO_BYTE8):
3553 * cmds.c (internal_self_insert):
3554 * editfns.c (general_insert_function):
3555 * keymap.c (push_key_description):
3556 * search.c (Freplace_match):
3557 * xdisp.c (message_dolog, set_message_1): All callers changed.
3558
f6d62986
SM
35592011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3560
3561 * keyboard.c (safe_run_hook_funcall): New function.
3562 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3563 don't set the hook to nil, but remove the offending function instead.
3564 (Qcommand_hook_internal): Remove, unused.
3565 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3566 Vcommand_hook_internal.
3567
3568 * eval.c (enum run_hooks_condition): Remove.
3569 (funcall_nil, funcall_not): New functions.
3570 (run_hook_with_args): Call each function through a `funcall' argument.
3571 Remove `cond' argument, now redundant.
3572 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3573 (Frun_hook_with_args_until_failure): Adjust accordingly.
3574 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3575
1db5b1ad
JB
35762011-03-28 Juanma Barranquero <lekktu@gmail.com>
3577
3578 * dispextern.h (string_buffer_position): Remove declaration.
3579
3580 * print.c (strout): Remove parameter `multibyte', unused since
3581 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3582
3583 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3584 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3585 All callers changed.
3586
3587 * w32.c (_wsa_errlist): Use braces for struct initializers.
3588
3589 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3590 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3591 All callers changed.
3592 (string_buffer_position): Likewise. Also, make static (it's never
3593 used outside xdisp.c).
3594 (cursor_row_p): Remove parameter `w', unused since
3595 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3596 (decode_mode_spec): Remove parameter `precision', introduced during
3597 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3598 All callers changed.
3599
5ffb62aa
JD
36002011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3601
3602 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3603
461c2ab9 36042011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3605
3606 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3607 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3608 (ns_update_auto_hide_menu_bar): New functions.
3609 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3610 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3611 ns_constrain_all_frames.
3612 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3613 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3614
5c380ffb
JD
36152011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3616
3617 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3618
9af30bdf
GM
36192011-03-27 Glenn Morris <rgm@gnu.org>
3620
3621 * syssignal.h: Replace RETSIGTYPE with void.
3622 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3623 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3624 Replace SIGTYPE with void everywhere.
3625 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3626 * s/template.h (SIGTYPE): Remove commented out definition.
3627
e2abce01
JB
36282011-03-26 Eli Zaretskii <eliz@gnu.org>
3629
3630 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3631 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3632
f868cd8a
JB
36332011-03-26 Juanma Barranquero <lekktu@gmail.com>
3634
59eb0929
JB
3635 * w32.c (read_unc_volume): Use parameter `henum', instead of
3636 global variable `wget_enum_handle'.
3637
3638 * keymap.c (describe_vector): Remove parameters `indices' and
3639 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3640 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3641
f868cd8a
JB
3642 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3643
3644 * keyboard.c (timer_check): Remove parameter `do_it_now',
3645 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3646 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3647 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3648
3649 * keyboard.c (read_char):
3650 * w32menu.c (w32_menu_display_help):
3651 * xmenu.c (show_help_event, menu_help_callback):
3652 Adjust calls to `show_help_echo'.
3653
3654 * gtkutil.c (xg_maybe_add_timer):
3655 * keyboard.c (readable_events):
3656 * process.c (wait_reading_process_output):
3657 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3658
3659 * insdel.c (adjust_markers_gap_motion):
3660 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3661 (gap_left, gap_right): Don't call it.
3662
2ecf6fdb
CY
36632011-03-25 Chong Yidong <cyd@stupidchicken.com>
3664
3665 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3666 incurred during fontification.
3667
6b1f9ba4
JB
36682011-03-25 Juanma Barranquero <lekktu@gmail.com>
3669
3670 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3671 (DEFVAR_PER_BUFFER): Don't pass it.
3672
3673 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3674 (scrolling_window): Don't pass it.
3675
0f4a96b5
JB
36762011-03-25 Juanma Barranquero <lekktu@gmail.com>
3677
3678 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3679
3680 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3681 and `suffix'.
3682 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3683 of variables specific to SELinux and computation of `encoded_absname'.
3684
3685 * image.c (XPutPixel): Remove unused variable `height'.
3686
3687 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3688
3689 * unexw32.c (get_section_info): Remove unused variable `section'.
3690
3691 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3692 (system_process_attributes): Remove unused variable `sess'.
3693 (sys_read): Remove unused variable `err'.
3694
3695 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3696 (w32_wnd_proc): Remove unused variable `isdead'.
3697 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3698 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3699 (x_create_tip_frame): Remove unused variable `tem'.
3700
3701 * w32inevt.c (w32_console_read_socket):
3702 Remove unused variable `no_events'.
3703
3704 * w32term.c (x_draw_composite_glyph_string_foreground):
3705 Remove unused variable `width'.
3706
1149507c
JB
37072011-03-24 Juanma Barranquero <lekktu@gmail.com>
3708
3709 * w32term.c (x_set_glyph_string_clipping):
3710 Don't pass uninitialized region to CombineRgn.
3711
9c88f339
JB
37122011-03-23 Juanma Barranquero <lekktu@gmail.com>
3713
3714 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3715 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3716 (Fx_close_connection): Remove unused variable `i'.
3717
3718 * w32font.c (w32font_draw): Return number of glyphs.
3719 (w32font_open_internal): Remove unused variable `i'.
3720 (w32font_driver): Add missing initializer.
3721
3722 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3723 (fill_in_menu): Remove unused variable `items_added'.
3724
3725 * w32term.c (last_mouse_press_frame): Remove static global variable.
3726 (w32_clip_to_row): Remove unused variable `f'.
3727 (x_delete_terminal): Remove unused variable `i'.
3728
3729 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3730 (NOTHING): Remove unused static global variable.
3731 (uniscribe_check_otf): Remove unused variable `table'.
3732 (uniscribe_font_driver): Add missing initializers.
3733
dee091a3
JD
37342011-03-23 Julien Danjou <julien@danjou.info>
3735
3736 * term.c (Fsuspend_tty, Fresume_tty):
3737 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3738 * window.c (temp_output_buffer_show):
3739 * insdel.c (signal_before_change):
3740 * frame.c (Fhandle_switch_frame):
3741 * fileio.c (Fdo_auto_save):
3742 * emacs.c (Fkill_emacs):
3743 * editfns.c (save_excursion_restore):
3744 * cmds.c (internal_self_insert):
3745 * callint.c (Fcall_interactively):
3746 * buffer.c (Fkill_all_local_variables):
3747 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3748 Use Frun_hooks.
0f4a96b5 3749 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3750 unconditionnaly since it does the check itself.
3751
2c520ab5 37522011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3753
c9c49752
PE
3754 Fix more problems found by GCC 4.5.2's static checks.
3755
8abc3f12
PE
3756 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3757 the first time through the loop, since we know p0 < p1 then.
3758 This also avoids a gcc -Wstrict-overflow warning.
3759
a2d26660
PE
3760 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3761 leading to a memory leak, possible in functions like
3762 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3763 of objects (Bug#8318).
a2d26660 3764
916c72e9
PE
3765 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3766 that could (at least in theory) be that large.
3767
19ab8a18
PE
3768 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3769 This is less likely to overflow, and avoids undefined behavior if
3770 overflow does occur. All callers changed. Use strtoul to scan
3771 for the unsigned long integer.
b7cbbd6f
PE
3772 (pint2hrstr): Simplify and tune code slightly.
3773 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3774
f0641eff
PE
3775 * scroll.c (do_scrolling): Work around GCC bug 48228.
3776 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3777
7f650bb9
PE
3778 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3779 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3780 (validate_x_resource_name): Simplify count usage.
3781 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3782
37dd57d1
PE
3783 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3784 fail (Bug#8306).
81e56e61 3785
699979fc 3786 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3787
401bf9b4
PE
3788 * process.c (Fmake_network_process): Use socklen_t, not int,
3789 where POSIX says socklen_t is required in portable programs.
3790 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3791 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3792 (Fmake_network_process, server_accept_connection):
3793 (wait_reading_process_output, read_process_output):
3794 Likewise.
3795
b93aacde
PE
3796 * process.c: Rename or move locals to avoid shadowing.
3797 (list_processes_1, Fmake_network_process):
3798 (read_process_output_error_handler, exec_sentinel_error_handler):
3799 Rename or move locals.
4dc343ee 3800 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3801 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3802 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3803 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3804 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3805
af8a867c 3806 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3807 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3808 Include tparam.h instead, since it declares them.
af8a867c
PE
3809 * cm.h (PC): Remove extern decl; tparam.h now does this.
3810 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3811 * terminfo.c: Include tparam.h, to check interfaces.
3812 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3813 (tparam): Adjust signature to match interface in tparam.h;
3814 this removes some undefined behavior. Check that outstring and len
3815 are zero, which they always are with Emacs.
3816 * tparam.h (PC, BC, UP): New extern decls.
3817
0248044d 3818 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3819 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3820
8ff096c1 3821 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3822 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3823 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3824 (ftfont_list): Remove unused local.
49eaafba
PE
3825 (get_adstyle_property, ftfont_pattern_entity):
3826 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3827 Rename locals to avoid shadowing.
8ff096c1 3828
e2be39f6
PE
3829 * xfont.c (xfont_list_family): Mark var as initialized.
3830
c9735e30
PE
3831 * xml.c (make_dom): Now static.
3832
8f5201ae
PE
3833 * composite.c (composition_compute_stop_pos): Rename local to
3834 avoid shadowing.
b246f932
PE
3835 (composition_reseat_it): Remove unused locals.
3836 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3837 (composition_update_it): Mark var as initialized.
11b61122
PE
3838 (find_automatic_composition): Mark vars as initialized,
3839 with a FIXME (Bug#8290).
8f5201ae 3840
760fbc2c
PE
3841 character.h: Rename locals to avoid shadowing.
3842 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3843 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3844 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3845 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3846 to avoid shadowing.
3847
ff08eb85
PE
3848 * textprop.c (property_change_between_p): Remove; unused.
3849
fc7bf025
PE
3850 * intervals.c (interval_start_pos): Now static.
3851
235d7abc
PE
3852 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3853
44f230aa
SM
3854 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3855 Rename locals to avoid shadowing.
3e7d6594 3856
50060332
PE
3857 * sound.c (wav_play, au_play, Fplay_sound_internal):
3858 Fix pointer signedness.
d01f234b 3859 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3860 (wav_play): Initialize a variable to 0, to prevent undefined
3861 behavior (Bug#8278).
50060332 3862
c4fc4e30
PE
3863 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3864
918436ed
PE
3865 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3866
c939f91b
PE
3867 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3868 clobbering (Bug#8298).
b9c7f648
PE
3869 * sysdep.c (sys_subshell): Likewise.
3870 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3871
6bd8c144
PE
3872 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3873 This should get cleaned up, so that child_setup has the
3874 same signature on all platforms.
3875
7710357c 3876 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3877 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3878
c59da222
CY
38792011-03-22 Chong Yidong <cyd@stupidchicken.com>
3880
3881 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3882 not to be necessary, and produces flickering.
3883
66b87493
GM
38842011-03-20 Glenn Morris <rgm@gnu.org>
3885
3886 * config.in: Remove file.
3887
45b6f6d5
JB
38882011-03-20 Juanma Barranquero <lekktu@gmail.com>
3889
3890 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3891 are now in src/globals.h.
3892 (syms_of_minibuf): Remove spurious & from previous change.
3893
3ec03f7e
LL
38942011-03-20 Leo <sdl.web@gmail.com>
3895
3896 * minibuf.c (completing-read-function): New variable.
3897 (completing-read-default): Rename from completing-read.
3898 (completing-read): Call completing-read-function.
3899
b14e3e21
CY
39002011-03-19 Juanma Barranquero <lekktu@gmail.com>
3901
3902 * xfaces.c (Fx_load_color_file):
3903 Read color file from absolute filename (bug#8250).
3904
f2b726e6
JB
39052011-03-19 Juanma Barranquero <lekktu@gmail.com>
3906
3907 * makefile.w32-in: Update dependencies.
3908
09f6ff02
EZ
39092011-03-17 Eli Zaretskii <eliz@gnu.org>
3910
3911 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3912
29a6015a
PE
39132011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3914
a3a6c54e
PE
3915 Fix more problems found by GCC 4.5.2's static checks.
3916
b766f867
PE
3917 * process.c (make_serial_process_unwind, send_process_trap):
3918 (sigchld_handler): Now static.
3919
be02381c
PE
3920 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3921 That way, the code declares only the vars that it needs.
3922 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3923 * s/cygwin.h (PTY_ITERATION): Likewise.
3924 * s/darwin.h (PTY_ITERATION): Likewise.
3925 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3926
57048744
PE
3927 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3928 * process.c (allocate_pty): Don't declare stb unless it's needed.
3929
7914961c 3930 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3931 (CONSTANTLIM): Remove; unused.
3932 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3933 Define only if needed.
7914961c 3934
b3967b18
PE
3935 * unexelf.c (unexec): Name an expression,
3936 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3937 Use a different way to cause a compilation error if anyone uses
3938 n rather than nn, a way that does not involve shadowing.
73366a00 3939 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3940
29a6015a
PE
3941 * deps.mk (unexalpha.o): Remove; unused.
3942
43cfc33e 3943 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3944 * unexec.h: New file.
ce701a33
PE
3945 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3946 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3947 Depend on unexec.h.
3948 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3949 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3950 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3951 Change as necessary to match prototype in unexec.h.
ce701a33 3952
01f44d5a
PE
3953 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3954 shadowing.
4f63c6bb 3955 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3956
a6670b0b
PE
3957 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3958 Rename locals to avoid shadowing.
3959
cef2010d 3960 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3961 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3962
d4d7173a
PE
3963 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3964
f08b802a
PE
3965 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3966 warning when compiling print.c.
3967
3ddb0639
PE
3968 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3969 instead of using an uninitialized var.
5ad03b97 3970 (font_sort_entities): Mark var as initialized.
3ddb0639 3971
170a2692
PE
3972 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3973
e663c700
PE
3974 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3975 pointers to constants.
89bc529a 3976 (font_parse_fcname): Remove unused vars.
7b81e2d0 3977 (font_delete_unmatched): Now static.
ea838e10 3978 (font_get_spec): Remove; unused.
13a547c6
PE
3979 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3980 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3981 Rename or move locals to avoid shadowing.
e663c700 3982
2a80c887 3983 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3984 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3985
1384fa33 3986 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3987 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3988
8b2c52e9
PE
3989 * alloc.c (mark_backtrace): Move decl from here ...
3990 * lisp.h: ... to here, so that it can be checked.
3991
475545b5 3992 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3993 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3994 (lisp_indirect_variable): Name an expression,
3995 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3996 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3997
b1349114 3998 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3999 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4000 Use const pointer when appropriate.
b1349114 4001
a2928364
PE
4002 * lisp.h (get_system_name, get_operating_system_release):
4003 Move decls here, to check interfaces.
4004 * process.c (get_operating_system_release): Move decl to lisp.h.
4005 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4006 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4007 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4008 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4009 (Fformat_time_string, Fencode_time, Finsert_char):
4010 (Ftranslate_region_internal, Fformat):
4011 Rename or remove local vars to avoid shadowing.
9710023e 4012 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4013
a415e694
PE
4014 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4015 avoid shadowing.
4016
8ef4622d
PE
4017 * lisp.h (eassert): Check that the argument compiles, even if
4018 ENABLE_CHECKING is not defined.
4019
946f9a5b
PE
4020 * data.c (Findirect_variable): Name an expression, to avoid
4021 gcc -Wbad-function-cast warning.
112396d6 4022 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4023 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4024 (Fmake_variable_buffer_local, Fmake_local_variable):
4025 Mark variables as initialized.
52746918 4026 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4027
e5aab7e7 4028 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4029 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4030 Rename locals to avoid shadowing.
dff45157
PE
4031 (mark_stack): Move local variables into the #ifdef region where
4032 they're used.
7bc26fdb
PE
4033 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4034 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4035 needed otherwise.
4036 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4037 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4038 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4039
e5aab7e7
PE
4040 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4041 avoids undefined behavior in theory.
4042
4da60324
PE
4043 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4044
88043301
PE
4045 Use functions, not macros, for up- and down-casing (Bug#8254).
4046 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4047 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4048 to use the following functions instead of these macros.
4049 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4050 EMACS_INT, since callers assume the returned value fits in int.
4051 (upcase1): Likewise, for UPCASE_TABLE.
4052 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4053 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4054 the race-condition problem in the old DOWNCASE.
88043301 4055
19ed5445
PE
4056 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4057 Rename locals to avoid shadowing.
4058 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4059 (regex_compile, re_search_2, re_match_2_internal):
4060 Remove unused local vars.
952db0d7
PE
4061 (FREE_VAR): Rewrite so as not to use empty "else",
4062 which gcc can warn about.
da053e48 4063 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4064 (RETALLOC_IF): Define only if needed.
4065 (WORDCHAR_P): Likewise. This one is never needed, but is used
4066 only in a comment talking about a compiler bug, so put inside
4067 the #if 0 of that comment.
4068 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4069 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4070 Remove; unused.
19ed5445 4071
1f3561e4 4072 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4073 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4074 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4075
ded6f8f7
PE
4076 * search.c (simple_search): Remove unused var.
4077
dbd37a95
PE
4078 * dired.c (compile_pattern): Move decl from here ...
4079 * lisp.h: ... to here, so that it can be checked.
4080 (struct re_registers): New forward decl.
4081
7e47afad
PE
4082 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4083
85f24f61
PE
4084 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4085 All uses changed.
4086 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4087 Rename locals to avoid shadowing.
5671df8f 4088 (Fvertical_motion): Mark locals as initialized.
85f24f61 4089
181aa2be 4090 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4091 (casify_region): Mark local as initialized.
181aa2be 4092
930d429c
PE
4093 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4094
7082eac6
PE
4095 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4096 New macros, so that the caller can use some names other than
4097 gcpro1, gcpro2, etc.
4098 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4099 of the new macros.
4100 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4101 argument, for consistency with GCPRO2_VAR, etc: it is now the
4102 prefix of the variable, not the variable itself. All uses
4103 changed.
38b2c076
PE
4104 * dired.c (directory_files_internal, file_name_completion):
4105 Rename locals to avoid shadowing.
4106
15206ed9
PE
4107 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4108 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4109 dired.c's scmp function, had undefined behavior.
4110 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4111 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4112 * buffer.h: ... to here, because these macros use current_buffer,
4113 and the new implementation with inline functions needs to have
4114 current_buffer in scope now, rather than later when the macros
4115 are used.
4116 (downcase, upcase1): New static inline functions.
4117 (DOWNCASE, UPCASE1): Reimplement using these functions.
4118 This avoids undefined behavior in expressions like
4119 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4120 from race conditions in accessing the global variables
4121 case_temp1 and case_temp2.
4122 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4123 * lisp.h (case_temp1, case_temp2): Remove their decls.
4124 * character.h (ASCII_CHAR_P): Move from here ...
4125 * lisp.h: ... to here, so that the inline functions mentioned
4126 above can use them.
4127
4a6bea26
PE
4128 * dired.c (directory_files_internal_unwind): Now static.
4129
f14b7e14
PE
4130 * fileio.c (file_name_as_directory, directory_file_name):
4131 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4132 Now static.
2893f146
PE
4133 (file_name_as_directory): Use const pointers when appropriate.
4134 (Fexpand_file_name): Likewise. In particular, newdir might
4135 point at constant storage, so make it a const pointer.
fd4ead52 4136 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4137 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4138 signedness issues.
f839df0c
PE
4139 (Fset_file_times, Finsert_file_contents, auto_save_error):
4140 Rename locals to avoid shadowing.
f14b7e14 4141
5716756e 4142 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4143 (Ftry_completion, Fall_completions): Rename or remove locals
4144 to avoid shadowing.
5716756e 4145
b4c3046a
PE
4146 * marker.c (bytepos_to_charpos): Remove; unused.
4147
b45db522
PE
4148 * lisp.h (verify_bytepos, count_markers): New decls,
4149 so that gcc does not warn that these functions aren't declared.
4150
85876d07
PE
4151 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4152 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4153 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4154 (copy_text): Remove unused local var.
85876d07 4155
03d78a21 4156 * filelock.c (within_one_second): Now static.
b3dd38ab 4157 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4158
5df8f01b
PE
4159 * buffer.c (fix_overlays_before): Mark locals as initialized.
4160 (fix_start_end_in_overlays): Likewise. This function should be
4161 simplified by using pointers-to-pointers, but that's a different
4162 matter.
b1d876f1 4163 (switch_to_buffer_1): Now static.
8f54f30a
PE
4164 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4165 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4166
a70072c9 4167 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4168 Fix pointer signedness issue.
edced198
PE
4169 (sys_subshell): Mark local as volatile if checking for lint,
4170 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4171 (MAXPATHLEN): Define only if needed.
a70072c9 4172
a0977c44
PE
4173 * process.c (serial_open, serial_configure): Move decls from here ...
4174 * systty.h: ... to here, so that they can be checked.
4175
a884fdcc
PE
4176 * fns.c (get_random, seed_random): Move extern decls from here ...
4177 * lisp.h: ... to here, so that they can be checked.
4178
604efe86 4179 * sysdep.c (reset_io): Now static.
b8950c94 4180 (wait_for_termination_signal): Remove; unused.
604efe86 4181
38fc62d9
PE
4182 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4183 (copy_keymap_item, append_key, push_text_char_description):
4184 Now static.
1004a21a 4185 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4186 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4187 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4188 (describe_map_tree):
4189 Rename locals to avoid shadowing.
38fc62d9 4190
2f2650da
PE
4191 * keyboard.c: Declare functions static if they are not used elsewhere.
4192 (echo_char, echo_dash, cmd_error, top_level_2):
4193 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4194 (read_char, kbd_buffer_get_event, make_lispy_position):
4195 (make_lispy_event, make_lispy_movement, apply_modifiers):
4196 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4197 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4198 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4199 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4200 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4201
a053e86c 4202 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4203 (mark_kboards): Move decl here ...
4204 * alloc.c (mark_kboards): ... from here.
a053e86c 4205
4752793e
PE
4206 * lisp.h (force_auto_save_soon): New decl.
4207
74f10ca7 4208 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4209 (DEFINE_DUMMY_FUNCTION): New macro.
4210 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4211 Use it.
c03cd23f
PE
4212 (main): Add casts to avoid warnings
4213 if GCC considers string literals to be constants.
74f10ca7 4214
022e70d4
PE
4215 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4216
59d6fe83
PE
4217 * dbusbind.c: Pointer signedness fixes.
4218 (xd_signature, xd_append_arg, xd_initialize):
4219 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4220 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4221 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4222 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4223
78320123
PE
4224 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4225 if GCC considers string literals to be constants.
49cebcca 4226 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4227
35ac2a97
SM
42282011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4229
fb103ca9
SM
4230 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4231 (print_preprocess, print_object): New macro to fix last change.
4232
35ac2a97
SM
4233 * print.c (print_preprocess): Don't forget font objects.
4234
62973b41
JB
42352011-03-16 Juanma Barranquero <lekktu@gmail.com>
4236
4237 * emacs.c (USAGE3): Doc fixes.
4238
0e48bb22
AS
42392011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4240
4241 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4242 structure.
4243
7684e57b
JB
42442011-03-14 Juanma Barranquero <lekktu@gmail.com>
4245
4246 * lisp.h (VWindow_system, Qfile_name_history):
4247 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4248 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4249 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4250
4251 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4252 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4253
4254 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4255 * w32console.c (detect_input_pending, read_input_pending)
4256 (encode_terminal_code):
4257 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4258 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4259 (w32_system_caret_y, Qfile_name_history):
4260 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4261 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4262 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4263 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4264 * w32proc.c (Qlocal, report_file_error):
4265 * w32term.c (Vwindow_system, updating_frame):
4266 * w32uniscribe.c (initialized, uniscribe_font_driver):
4267 Remove unneeded extern declarations.
4268
2aa46d6c
CY
42692011-03-14 Chong Yidong <cyd@stupidchicken.com>
4270
c96bbc66 4271 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4272
cffc6f3b
CY
42732011-03-13 Chong Yidong <cyd@stupidchicken.com>
4274
4275 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4276 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4277 These macros can no longer be used for assignment.
4278
44f230aa
SM
4279 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4280 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4281 (record_buffer_markers, fetch_buffer_markers): New functions for
4282 recording and fetching special buffer markers.
4283 (set_buffer_internal_1, set_buffer_temp): Use them.
4284
4285 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4286
4287 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4288
4289 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4290 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4291
4292 * xdisp.c (hscroll_window_tree):
4293 (reconsider_clip_changes): Use PT instead of BUF_PT.
4294
d251f04b
EZ
42952011-03-13 Eli Zaretskii <eliz@gnu.org>
4296
4297 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4298 $(EMACS_ROOT)/lib/intprops.h.
4299
f0c77cd1
PE
43002011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4301
3eca4629
PE
4302 Fix more problems found by GCC 4.5.2's static checks.
4303
7c86ee98
PE
4304 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4305 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4306 (xg_free_frame_widgets): Make it clear that a local variable is
4307 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4308 (gdk_window_get_screen): Make it clear that this macro is needed
4309 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4310 (int_gtk_range_get_value): New function, which avoids a diagnostic
4311 from gcc -Wbad-function-cast.
4312 (xg_set_toolkit_scroll_bar_thumb): Use it.
4313 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4314 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4315 (get_utf8_string, xg_get_file_with_chooser):
4316 Rename locals to avoid shadowing.
4317 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4318
41729b81
PE
4319 * xgselect.c (xg_select): Remove unused var.
4320
f0c77cd1
PE
4321 * image.c (four_corners_best): Mark locals as initialized.
4322 (gif_load): Initialize transparent_p to zero (Bug#8238).
4323 Mark another local as initialized.
ec6cf4c6 4324 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4325
ce0ad53d 4326 * image.c (clear_image_cache): Now static.
d5d5a617 4327 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4328 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4329 (x_edge_detection): Remove unnecessary cast that
4330 gcc -Wbad-function-cast diagnoses.
2037898d 4331 (gif_load): Fix pointer signedness.
6ae141d6
PE
4332 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4333 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4334
33383987 43352011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4336
d32df629
PE
4337 Improve quality of tests for time stamp overflow.
4338 For example, without this patch (encode-time 0 0 0 1 1
4339 1152921504606846976) returns the obviously-bogus value (-948597
4340 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4341 reports time overflow. See
4342 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4343 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4344 * editfns.c: Include limits.h and intprops.h.
4345 (TIME_T_MIN, TIME_T_MAX): New macros.
4346 (time_overflow): Move earlier, to before first use.
4347 (hi_time, lo_time): New functions, for an accurate test for
4348 out-of-range times.
4349 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4350 (Fget_internal_run_time): Don't assume time_t fits in int.
4351 (make_time): Use list2 instead of Fcons twice.
4352 (Fdecode_time): More accurate test for out-of-range times.
4353 (check_tm_member): New function.
4354 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4355 (lisp_time_argument): Don't rely on undefined left-shift and
4356 right-shift behavior when checking for time stamp overflow.
8be6f318 4357
fe31d94c
PE
4358 * editfns.c (time_overflow): New function, refactoring common code.
4359 (Fformat_time_string, Fdecode_time, Fencode_time):
4360 (Fcurrent_time_string): Use it.
4361
8be6f318
PE
4362 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4363 * dired.c (make_time): Move to ...
4364 * editfns.c (make_time): ... here.
4365 * systime.h: Note the move.
4366
09d9db2c 43672011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4368
126bc0dc
YM
4369 * fringe.c (update_window_fringes): Remove unused variables.
4370
c47cbdfd
YM
4371 * unexmacosx.c (copy_data_segment): Also copy __got section.
4372 (Bug#8223)
4373
7ac80be9
EZ
43742011-03-12 Eli Zaretskii <eliz@gnu.org>
4375
c96bbc66 4376 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4377 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4378 Constify `char *' arguments and their references according to
4379 prototypes in tparam.h.
4380
ecb0f94d 4381 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4382
7ac80be9
EZ
4383 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4384 Adapt all references accordingly.
4385
4386 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4387
ef1fd07e
TT
43882011-03-11 Tom Tromey <tromey@redhat.com>
4389
4390 * buffer.c (syms_of_buffer): Remove obsolete comment.
4391
7ef4b50c
EZ
43922011-03-11 Eli Zaretskii <eliz@gnu.org>
4393
4394 * termhooks.h (encode_terminal_code): Declare prototype.
4395
4396 * msdos.c (encode_terminal_code): Don't declare prototype.
4397
4398 * term.c (encode_terminal_code): Now external again, used by
4399 w32console.c and msdos.c.
4400
44f230aa
SM
4401 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4402 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4403
4b1ec863 44042011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4405
1714f52b 4406 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4407
4b1ec863
PE
4408 * fringe.c (update_window_fringes): Mark locals as initialized
4409 (Bug#8227).
4410 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4411
524c7aa6
PE
4412 * alloc.c (mark_fringe_data): Move decl from here ...
4413 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4414 to check its interface.
4415 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4416
a5c0af81 4417 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4418 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4419 (fontset_font): Mark local as initialized.
a9a06e0b 4420 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4421
b4716021
PE
4422 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4423
811e9bac 4424 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4425 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4426 (x_own_selection, Fx_disown_selection_internal): Rename locals
4427 to avoid shadowing.
4428 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4429
7e3ab302
PE
4430 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4431 so that the caller can use some name other than gcpro1.
4432 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4433 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4434 (Fx_backspace_delete_keys_p):
4435 Use them to avoid shadowing, and rename vars to avoid shadowing.
4436 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4437 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4438 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4439 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4440 Remove unused locals.
7e3ab302
PE
4441 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4442 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4443 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4444 macros.
f78faa98 4445
e2b13473
PE
4446 * xterm.h (x_mouse_leave): New decl.
4447
77f23912
PE
4448 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4449 Remove unused functions.
cdf4ba58
PE
4450 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4451 (x_calc_absolute_position): Now static.
7411c686 4452 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4453 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4454 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4455 unless they are used.
38d0b34a
PE
4456 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4457 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4458 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4459 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4460 (x_error_catcher, x_connection_closed, x_error_handler):
4461 (x_error_quitter, xembed_send_message, x_iconify_frame):
4462 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4463 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4464 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4465
44f230aa
SM
4466 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4467 Rename or move locals to avoid shadowing.
6b463e58 4468 (tty_defined_color, merge_face_heights): Now static.
5967d051 4469 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4470 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4471 does not deduce is never used uninitialized.
73719eba
PE
4472 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4473 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4474
426994c3 4475 * terminal.c (store_terminal_param): Now static.
5489860b 4476
032f1620 4477 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4478 (set_frame_menubar): Remove unused local.
d4323972 4479 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4480 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4481 since they might point to immutable storage.
281585b0
PE
4482 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4483 since it's unused otherwise.
032f1620 4484
367c19e5 4485 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4486 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4487 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4488 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4489 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4490 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4491 does not deduce are never used uninitialized.
70739cbe 4492
07b48fa9
PE
4493 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4494
8868a238 4495 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4496 * window.c (window_loop, size_window):
4497 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4498
7e5cf297 4499 * window.c (display_buffer): Now static.
d6550a9f
PE
4500 (size_window): Mark variables that gcc -Wuninitialized
4501 does not deduce are never used uninitialized.
a586633d
PE
4502 * window.h (check_all_windows): New decl, to forestall
4503 gcc -Wmissing-prototypes diagnostic.
5b555da1 4504 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4505
f6095868
PE
4506 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4507 shadowing.
4508 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4509 Include <limits.h>.
4510 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4511 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4512 (load_charset_map): Mark variables that gcc -Wuninitialized
4513 does not deduce are never used uninitialized.
53df7c11 4514 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4515
f38b440c
PE
4516 * coding.c (coding_set_source, coding_set_destination):
4517 Use "else { /* comment */ }" rather than "else /* comment */;"
4518 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4519 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4520 a block, when the outer 'i' will do.
4521 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4522 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4523 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4524 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4525 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4526 Rename locals to avoid shadowing.
4527 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4528 * coding.c (emacs_mule_char, encode_invocation_designation):
4529 Now static, since they're not used elsewhere.
413bb2db 4530 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4531 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4532 (decode_coding_emacs_mule): Mark variables that gcc
4533 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4534 (detect_coding_iso_2022): Initialize a local variable that might
4535 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4536 this initialization is needed. (Bug#8211)
5f58e762
PE
4537 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4538 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4539 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4540 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4541 Remove unused macros.
f38b440c 4542
232b38b9 4543 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4544 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4545 * character.c (string_count_byte8): Likewise.
232b38b9 4546
fb90da1b
PE
4547 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4548 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4549
fb93dbc2
PE
4550 * chartab.c (copy_sub_char_table): Now static, since it's not used
4551 elsewhere.
5c156ace
PE
4552 (sub_char_table_ref_and_range, char_table_ref_and_range):
4553 Rename locals to avoid shadowing.
bbcd0949 4554 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4555
7d3b3862 4556 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4557 (BIDI_BOB): Remove unused macro.
7d3b3862 4558
6be7d3da
PE
4559 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4560 deduce are never used uninitialized.
c2ed9c8b 4561 * term.c (encode_terminal_code): Likewise.
6be7d3da 4562
75f8807f 4563 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4564
50938595
PE
4565 * tparam.h: New file.
4566 * term.c, tparam.h: Include it.
4567 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4568 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4569 Move these decls to tparam.h, and make them agree with what
4570 is actually in tparam.c. The previous trick of using incompatible
4571 decls in different modules does not conform to the C standard.
4572 All callers of tparam changed to use tparam's actual API.
4573 * tparam.c (tparam1, tparam, tgoto):
4574 Use const pointers where appropriate.
4575
fbceeba2
PE
4576 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4577 * cm.h (struct cm): Likewise.
4578 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4579 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4580 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4581 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4582 (turn_on_face, init_tty): Likewise.
4583 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4584
7f3f1250
PE
4585 * term.c (term_mouse_position): Rename local to avoid shadowing.
4586
e6ca6543
PE
4587 * alloc.c (mark_ttys): Move decl from here ...
4588 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4589
c40f8d15
AS
45902011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4591
4592 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4593
cfe0661d
JB
45942011-03-09 Juanma Barranquero <lekktu@gmail.com>
4595
4596 * search.c (compile_pattern_1): Remove argument regp, unused since
4597 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4598 (compile_pattern): Don't pass it.
4599
0afb4571
J
46002011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4601
4602 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4603 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4604 for ! HAVE_GTK3.
4605 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4606
4607 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4608
4609 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4610 gdk_window_get_screen, gdk_window_get_geometry,
4611 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4612 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4613 (xg_get_pixbuf_from_pixmap): New function.
4614 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4615 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4616 Call xg_get_pixbuf_from_pixmap instead of
4617 gdk_pixbuf_get_from_drawable.
4618 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4619 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4620 (xg_check_special_colors): Use GtkStyleContext and its functions
4621 for HAVE_GTK3.
4622 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4623 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4624 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4625 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4626 Call gtk_widget_get_preferred_size.
0afb4571
J
4627 (xg_frame_resized): gdk_window_get_geometry only takes 5
4628 parameters.
44f230aa
SM
4629 (xg_win_to_widget, xg_event_is_for_menubar):
4630 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4631 (xg_set_widget_bg): New function.
4632 (delete_cb): New function.
895009e1 4633 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4634 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4635 (xg_set_background_color): Call xg_set_widget_bg.
4636 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4637 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4638 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4639 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4640 if ! HAVE_GTK3.
4641 (update_frame_tool_bar): Call gtk_widget_hide.
4642 (xg_initialize): Use GDK_KEY_g.
4643
4644 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4645 if ! HAVE_GTK3
4646 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4647
4648 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4649 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4650 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4651
1c2cc4ef
JB
46522011-03-08 Juanma Barranquero <lekktu@gmail.com>
4653
4654 * w32xfns.c (select_palette): Check success of RealizePalette against
4655 GDI_ERROR, not zero.
4656
33383987 4657See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4658
4659;; Local Variables:
4660;; coding: utf-8
aac0c6e3
MR
4661;; End:
4662
33383987 4663 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4664
4665 This file is part of GNU Emacs.
4666
4667 GNU Emacs is free software: you can redistribute it and/or modify
4668 it under the terms of the GNU General Public License as published by
4669 the Free Software Foundation, either version 3 of the License, or
4670 (at your option) any later version.
4671
4672 GNU Emacs is distributed in the hope that it will be useful,
4673 but WITHOUT ANY WARRANTY; without even the implied warranty of
4674 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4675 GNU General Public License for more details.
4676
4677 You should have received a copy of the GNU General Public License
4678 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.