Merge: Integer signedness and overflow and related fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2573a837 12011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2
41f55ccd 3 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 4
39e378da
PE
5 * bidi.c: Integer size and overflow fixes.
6 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
10 (bidi_find_other_level_edge):
11 Use ptrdiff_t instead of EMACS_INT where either will do.
12 This works better on 32-bit hosts configured --with-wide-int.
13 (bidi_cache_ensure_space): Check for size-calculation overflow.
14 Use % rather than repeated addition, for better worst-case speed.
15 Don't set bidi_cache_size until after xrealloc returns, because it
16 might not return.
17 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
18 (bidi_cache_ensure_space): Also check that the bidi cache size
19 does not exceed that of the largest Lisp string or buffer. See Eli
20 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 21
5e927815
PE
22 * alloc.c (__malloc_size_t): Remove.
23 All uses replaced by size_t. See Andreas Schwab's note
24 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
25
ca4aa935
PE
26 * image.c: Improve checking for integer overflow.
27 (check_image_size): Assume that f is nonnull, since
28 it is always nonnull in practice. This is one less thing to
29 worry about when checking for integer overflow later.
30 (x_check_image_size): New function, which checks for integer
31 overflow issues inside X.
32 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
33 This removes the need for a memory_full check.
34 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
35 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
36 (xbm_read_bitmap_data): Change locals back to 'int', since
37 their values must fit in 'int'.
38 (xpm_load_image, png_load, tiff_load):
39 Invoke x_create_x_image_and_pixmap earlier,
40 to avoid much needless work if the image is too large.
41 (tiff_load): Treat overly large images as if
42 x_create_x_image_and_pixmap failed, not as malloc failures.
43 (gs_load): Use x_check_image_size.
44
5f8f9cc2
PE
45 * gtkutil.c: Omit integer casts.
46 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
47 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
48
5adf60bc
PE
49 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
50
c8907a93
PE
51 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
52 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
53 would wrongly return t on a 64-bit host.
54
e3c25c68
PE
55 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
56 The plain *_OVERFLOW macros run afoul of GCC bug 49705
57 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
58 and therefore cause GCC to emit a bogus diagnostic in some cases.
59
3f791afe
PE
60 * image.c: Integer signedness and overflow and related fixes.
61 This is not an exhaustive set of fixes, but it's time to
62 record what I've got.
63 (lookup_pixel_color, check_image_size): Remove redundant decls.
64 (check_image_size): Don't assume that arbitrary EMACS_INT values
65 fit in 'int', or that arbitrary 'double' values fit in 'int'.
66 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
67 (tiff_load, imagemagick_load_image):
68 Check for overflow in size calculations.
69 (x_create_x_image_and_pixmap): Remove unnecessary test for
70 xmalloc returning NULL; that can't happen.
71 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
72 (xpm_color_bucket): Use better integer hashing function.
73 (xpm_cache_color): Don't possibly over-allocate memory.
74 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
75 (gif_memory_source):
76 Use ptrdiff_t, not int or size_t, to record sizes.
77 (png_load): Don't assume values greater than 2**31 fit in 'int'.
78 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
79 either works, as we prefer signed integers.
80 (tiff_read_from_memory, tiff_write_from_memory):
81 Return tsize_t, not size_t, since that's what the TIFF API wants.
82 (tiff_read_from_memory): Don't fail simply because the read would
83 go past EOF; instead, return a short read.
84 (tiff_load): Omit no-longer-needed casts.
85 (Fimagemagick_types): Don't assume size fits into 'int'.
86
3cc5a532
PE
87 Improve hashing quality when configured --with-wide-int.
88 * fns.c (hash_string): New function, taken from sxhash_string.
89 Do not discard information about ASCII character case; this
90 discarding is no longer needed.
91 (sxhash-string): Use it. Change sig to match it. Caller changed.
92 * lisp.h: Declare it.
93 * lread.c (hash_string): Remove, since we now use fns.c's version.
94 The fns.c version returns a wider integer if --with-wide-int is
95 specified, so this should help the quality of the hashing a bit.
96
b312a492
PE
97 * emacs.c: Integer overflow minor fix.
98 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
99 Define only if GNU_LINUX.
100 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
101
dfd153ae
PE
102 * dispnew.c: Integer signedness and overflow fixes.
103 Remove unnecessary forward decls, that were a maintenance hassle.
104 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
105 All uses changed.
106 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
107 (scrolling_window): Use ptrdiff_t, not int, for byte count.
108 (prepare_desired_row, line_draw_cost):
109 Use int, not unsigned, where either works.
110 (save_current_matrix, restore_current_matrix):
111 Use ptrdiff_t, not size_t, where either works.
112 (init_display): Check for overflow more accurately, and without
113 relying on undefined behavior.
114
a81d11a3
PE
115 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
116 Remove, replacing with the new symbols in lisp.h. All uses changed.
117 * fileio.c (make_temp_name):
118 * filelock.c (lock_file_1, lock_file):
119 * xdisp.c (message_dolog):
120 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
121 Use pMd etc. instead.
122 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
123 replacing the pWIDE etc. symbols removed from editfns.c.
124
3300e6fd
PE
125 * keyboard.h (num_input_events): Now uintmax_t.
126 This is (very slightly) less likely to mess up due to wraparound.
127 All uses changed.
128
fd05c7e9
PE
129 * buffer.c: Integer signedness fixes.
130 (alloc_buffer_text, enlarge_buffer_text):
131 Use ptrdiff_t rather than size_t when either will do, as we prefer
132 signed integers.
133
903fe15d
PE
134 * alloc.c: Integer signedness and overflow fixes.
135 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
136 (__malloc_size_t): Default to size_t, not to int.
137 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
138 (Fgarbage_collect, mark_object_loop_halt, mark_object):
139 Prefer ptrdiff_t to size_t when either would do, as we prefer
140 signed integers.
141 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
142 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
143 Now const. Initialize with values that are in range even if char
144 is signed.
145 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
146 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
147 These functions do the right thing with sizes > 2**32.
148 (check_depth): Now ptrdiff_t, not int.
149 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
150 Adjust to new way of storing sizes. Check for size overflow bugs
151 in rest of code.
152 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
153 slightly wrong anyway, as it missed one instance of
154 XMALLOC_OVERRUN_CHECK_OVERHEAD.
155 (refill_memory_reserve): Omit needless cast to size_t.
156 (mark_object_loop_halt): Mark as externally visible.
157
ac82cc6a
PE
158 * xselect.c: Integer signedness and overflow fixes.
159 (Fx_register_dnd_atom, x_handle_dnd_message):
160 Use ptrdiff_t, not size_t, since we prefer signed.
161 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
162 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
163 x_dnd_atoms_size and x_dnd_atoms_length.
164
c2d1e36d
PE
165 * doprnt.c: Prefer signed to unsigned when either works.
166 * eval.c (verror):
167 * doprnt.c (doprnt):
168 * lisp.h (doprnt):
169 * xdisp.c (vmessage):
170 Use ptrdiff_t, not size_t, when using or implementing doprnt,
171 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
172 prefer signed arithmetic to avoid comparison confusion.
173 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
174 but is a bit tricky.
175
0e926e56
PE
176 Assume freestanding C89 headers, string.h, stdlib.h.
177 * data.c, doprnt.c, floatfns.c, print.c:
178 Include float.h unconditionally.
179 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
180 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
181 * regex.c: Likewise for stddef.h, string.h.
182 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
183 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
184 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
185 (STDC_HEADERS): Remove obsolete defines.
186 * sysdep.c: Include limits.h unconditionally.
187
9cfdb3ec
PE
188 Assume support for memcmp, memcpy, memmove, memset.
189 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
190 * regex.c (memcmp, memcpy):
191 Remove; we assume C89 now.
192
193 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
194 (__malloc_safe_bcopy): Remove; no longer needed.
195
cf950e6b 196 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
197 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
198 well either way, and we prefer signed to unsigned.
199
dbf38e02
LMI
2002011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
201
202 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
203 closes the connection while we're reading (bug#9182).
204
d6f0886c
JD
2052011-07-25 Jan Djärv <jan.h.d@swipnet.se>
206
207 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
208 are specified (Bug#9168).
209
2eb1f9e6
PE
2102011-07-25 Paul Eggert <eggert@cs.ucla.edu>
211
212 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
213 Found by GCC static checking and --with-wide-int on a 32-bit host.
214
22381272 2152011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
216
217 * xdisp.c (compute_display_string_pos): Fix logic of caching
218 previous display string position. Initialize cached_prev_pos to
219 -1. Fixes slow-down at the beginning of a buffer.
220
f25e39b4
EZ
2212011-07-24 Eli Zaretskii <eliz@gnu.org>
222
223 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
224 for attrs[LFACE_FONTSET_INDEX].
225
04c4b52e
PE
2262011-07-23 Paul Eggert <eggert@cs.ucla.edu>
227
228 * xml.c (parse_region): Remove unused local
229 that was recently introduced.
230
c1734fbd
EZ
2312011-07-23 Eli Zaretskii <eliz@gnu.org>
232
be18c5a5
EZ
233 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
234 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
235
c1734fbd
EZ
236 * xdisp.c (move_it_in_display_line_to): Record the best matching
237 position for TO_CHARPOS while scanning the line, and restore it on
238 exit if none of the characters scanned was an exact match. Fixes
a9269c18
EZ
239 vertical-motion and pos-visible-in-window-p under bidi redisplay
240 when exact match is impossible due to invisible text, and the
241 lines are truncated.
242
a258d627
JD
2432011-07-23 Jan Djärv <jan.h.d@swipnet.se>
244
245 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
246 for OSX >= 10.7.
247
b6d5a689
EZ
2482011-07-22 Eli Zaretskii <eliz@gnu.org>
249
0f74f785
EZ
250 Fix a significant slow-down of cursor motion with C-n, C-p,
251 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
252 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 253 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
254 (next_element_from_buffer): Call compute_stop_pos_backwards to
255 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
256 base_level_stop.
257 (reseat): Don't look for prev_stop, as that could mean a very long
258 run.
259 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
260 <cached_disp_overlay_modiff>: Cache for last found display string
261 position.
551918c1 262 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
263 about the same buffer in the same area of character positions, and
264 the buffer wasn't changed since the time the display string
265 position was cached.
551918c1 266
b2d0c91a
EZ
2672011-07-22 Eli Zaretskii <eliz@gnu.org>
268
269 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
270 is an integer, which is important for empty lines. (Bug#9149)
271
043604ee
CY
2722011-07-22 Chong Yidong <cyd@stupidchicken.com>
273
274 * frame.c (Fmodify_frame_parameters): In tty case, update the
275 default face if necessary (Bug#4238).
276
da4adb04
CY
2772011-07-21 Chong Yidong <cyd@stupidchicken.com>
278
279 * editfns.c (Fstring_to_char): No need to explain what a character
280 is in the docstring (Bug#6576).
281
9abd0532
LMI
2822011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
283
284 * xml.c (parse_region): Make sure we always return a tree.
285
36881d16
HK
2862011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
287
288 * xml.c (parse_region): If a document contains only comments,
289 return that, too.
290
1e98674d
LMI
2912011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
292
293 * xml.c (make_dom): Return comments, too.
294
590bd467
PE
2952011-07-19 Paul Eggert <eggert@cs.ucla.edu>
296
297 Port to OpenBSD.
298 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
299 and the surrounding thread.
300 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
301 rather than fgets, and retry after EINTR. Otherwise, 'emacs
302 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
303 timer goes off.
304 * s/openbsd.h (BROKEN_SIGIO): Define.
305 * unexelf.c (unexec) [__OpenBSD__]:
306 Don't update the .mdebug section of the Alpha COFF symbol table.
307
f41628b2
LMI
3082011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
309
310 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
311 (bug#8460).
312
b59b67c5
PE
3132011-07-18 Paul Eggert <eggert@cs.ucla.edu>
314
15e3a074
PE
315 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
316 This fixes some race conditions on the permissions of any newly
317 created file.
318
41bed37d
PE
319 * alloc.c (valid_pointer_p): Use pipe, not open.
320 This fixes some permissions issues when debugging.
321
b59b67c5
PE
322 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
323 If fchown fails to set both uid and gid, try to set just gid,
324 as that is sometimes allowed. Adjust the file's mode to eliminate
325 setuid or setgid bits that are inappropriate if fchown fails.
326
925a6be7
SM
3272011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
328
329 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
330 to compare Lisp_Objects.
331 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
332 global_gnutls_log_level, don't mistake it for a Lisp_Object.
333 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
334
52968808
AS
3352011-07-17 Andreas Schwab <schwab@linux-m68k.org>
336
0a6a104b
AS
337 * lread.c (read_integer): Unread even EOF character.
338 (read1): Likewise. Properly record start position of symbol.
339
52968808
AS
340 * lread.c (read1): Read `#:' as empty uninterned symbol if no
341 symbol character follows.
342
9e381cdd
PE
3432011-07-17 Paul Eggert <eggert@cs.ucla.edu>
344
345 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
346 This works around a problem with the previous change to Fcopy_file.
347 Recent glibc declares fchown with __attribute__((warn_unused_result)),
348 and without this change, GCC might complain about discarding
349 fchown's return value.
350
b5641435
JB
3512011-07-16 Juanma Barranquero <lekktu@gmail.com>
352
353 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
354
a8031457
PE
3552011-07-16 Paul Eggert <eggert@cs.ucla.edu>
356
357 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
358
dd889327
LMI
3592011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
360
750c33f7
LMI
361 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
362 it's used from the C level.
363
dd889327
LMI
364 * process.c: Use the same condition for POLL_FOR_INPUT in both
365 keyboard.c and process.c (bug#1858).
366
87e86684
LM
3672011-07-09 Lawrence Mitchell <wence@gmx.li>
368
369 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
370 (Fgnutls_boot): Use it.
371
64348f40
AS
3722011-07-15 Andreas Schwab <schwab@linux-m68k.org>
373
374 * doc.c (Fsubstitute_command_keys): Revert last change.
375
1d698799
LMI
3762011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
377
f863868c
LMI
378 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
379 quotes the next character, and doesn't affect other longer
380 sequences (bug#8935).
381
1d698799
LMI
382 * lread.c (syms_of_lread): Clarify that is isn't only
383 `eval-buffer' and `eval-defun' that's affected by
384 `lexical-binding' (bug#8460).
385
aa4b6df6
EZ
3862011-07-15 Eli Zaretskii <eliz@gnu.org>
387
388 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
389 bidi redisplay when a line includes both an image and is
390 truncated.
391
5d856da6
PE
3922011-07-14 Paul Eggert <eggert@cs.ucla.edu>
393
ad6042bb
PE
394 Fix minor problems found by static checking.
395 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
396 (elsz): Now a signed constant, not a size_t var. We prefer signed
397 types to unsigned, to avoid integer comparison confusion. Without
398 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
399 "cannot optimize loop, the loop counter may overflow", a symptom
400 of the confusion.
f00bbb22 401 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
402 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
403
6468f31c
LMI
4042011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
405
49080b10
LMI
406 * search.c (Fre_search_backward): Mention `case-fold-search' in
407 all the re_search_* functions (bug#8138).
408
6468f31c
LMI
409 * keyboard.c (Fopen_dribble_file): Document when the file is
410 closed (bug#8056).
411
c965adc5
EZ
4122011-07-14 Eli Zaretskii <eliz@gnu.org>
413
df9733bf
EZ
414 * bidi.c (bidi_dump_cached_states): Fix format of displaying
415 bidi_cache_idx.
416
0bb23927
EZ
417 Support bidi reordering of display and overlay strings.
418 * xdisp.c (compute_display_string_pos)
419 (compute_display_string_end): Accept additional argument STRING.
420 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
421 (reseat_to_string): Initialize bidi_it->string.s and
422 bidi_it->string.schars.
423 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
424 NULL (avoids a crash in bidi_paragraph_init). Initialize
425 itb.string.lstring.
426 (init_iterator): Call bidi_init_it only of a valid
427 buffer position was specified. Initialize paragraph_embedding to
428 L2R.
429 (reseat_to_string): Initialize the bidi iterator.
430 (display_string): If we need to ignore text properties of
431 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
432 original value of -1 will not work with bidi.)
433 (compute_display_string_pos): First arg is now struct
434 `text_pos *'; all callers changed. Support display properties on
435 Lisp strings.
436 (compute_display_string_end): Support display properties on Lisp
437 strings.
438 (init_iterator, reseat_1, reseat_to_string): Initialize the
439 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
440 when iterating on a string not from display properties).
441 (compute_display_string_pos, compute_display_string_end): Fix
442 calculation of the object to scan. Fixes an error when using
443 arrow keys.
444 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
445 base_level_stop; instead, set base_level_stop to BEGV. Fixes
446 crashes in vertical-motion.
447 (next_element_from_buffer): Improve commentary for when
448 the iterator is before prev_stop.
449 (init_iterator): Initialize bidi_p from the default value of
450 bidi-display-reordering, not from buffer-local value. Use the
451 buffer-local value only if initializing for buffer iteration.
452 (handle_invisible_prop): Support invisible properties on strings
453 that are being bidi-reordered.
454 (set_iterator_to_next): Support bidi reordering of C strings and
455 Lisp strings.
456 (next_element_from_string): Support bidi reordering of Lisp
457 strings.
458 (handle_stop_backwards): Support Lisp strings as well.
459 (display_string): Support display of R2L glyph rows. Use
460 IT_STRING_CHARPOS when displaying from a Lisp string.
461 (init_iterator): Don't initialize it->bidi_p for strings
462 here.
463 (reseat_to_string): Initialize it->bidi_p for strings here.
464 (next_element_from_string, next_element_from_c_string)
465 (next_element_from_buffer): Add xassert's for correspondence
466 between IT's object being iterated and it->bidi_it.string
467 structure.
468 (face_before_or_after_it_pos): Support bidi iteration.
469 (next_element_from_c_string): Handle the case of the first string
470 character that is not the first one in the visual order.
471 (get_visually_first_element): New function, refactored from common
472 parts of next_element_from_buffer, next_element_from_string, and
473 next_element_from_c_string.
474 (tool_bar_lines_needed, redisplay_tool_bar)
475 (display_menu_bar): Force left-to-right direction. Add a FIXME
476 comment for making that be controlled by a user option.
477 (push_it, pop_it): Save and restore the state of the
478 bidi iterator. Save and restore the bidi_p flag.
479 (pop_it): Iterate out of display property for string iteration as
480 well.
481 (iterate_out_of_display_property): Support iteration over strings.
482 (handle_single_display_spec): Set up it->bidi_it for iteration
483 over a display string, and call bidi_init_it.
484 (handle_single_display_spec, next_overlay_string)
485 (get_overlay_strings_1, push_display_prop): Set up the bidi
486 iterator for displaying display or overlay strings.
487 (forward_to_next_line_start): Don't use the shortcut if
488 bidi-iterating.
489 (back_to_previous_visible_line_start): If handle_display_prop
490 pushed the iterator stack, restore the internal state of the bidi
491 iterator by calling bidi_pop_it same number of times.
492 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
493 and we are bidi-iterating, don't decrement the iterator position;
494 instead, set the first_elt flag in the bidi iterator, to produce
495 the same effect.
496 (reseat_1): Remove redundant setting of string_from_display_prop_p.
497 (push_display_prop): xassert that we are iterating a buffer.
498 (push_it, pop_it): Save and restore paragraph_embedding member.
499 (handle_single_display_spec, next_overlay_string)
500 (get_overlay_strings_1, reseat_1, reseat_to_string)
501 (push_display_prop): Set up the `unibyte' member of bidi_it.string
502 correctly. Don't assume unibyte strings are not bidi-reordered.
503 (compute_display_string_pos)
504 (compute_display_string_end): Fix handling the case of C string.
505 (push_it, pop_it): Save and restore from_disp_prop_p.
506 (handle_single_display_spec, push_display_prop): Set the
507 from_disp_prop_p flag.
508 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
509 (pop_it): Call iterate_out_of_display_property only if we are
510 popping after iteration over a string that came from a display
511 property. Fix a typo in popping stretch info. Add an assertion
512 for verifying that the iterator position is in sync with the bidi
513 iterator.
514 (handle_single_display_spec, get_overlay_strings_1)
515 (push_display_prop): Fix initialization of paragraph direction for
516 string when that of the parent object is not yet determined.
517 (reseat_1): Call bidi_init_it to resync the bidi
518 iterator with IT's position. (Bug#7616)
519 (find_row_edges): If ROW->start.pos gives position
520 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
521 (handle_stop, back_to_previous_visible_line_start, reseat_1):
522 Reset the from_disp_prop_p flag.
523 (SAVE_IT, RESTORE_IT): New macros.
524 (pos_visible_p, face_before_or_after_it_pos)
525 (back_to_previous_visible_line_start)
526 (move_it_in_display_line_to, move_it_in_display_line)
527 (move_it_to, move_it_vertically_backward, move_it_by_lines)
528 (try_scrolling, redisplay_window, display_line): Use them when
529 saving a temporary copy of the iterator and restoring it back.
530 (back_to_previous_visible_line_start, reseat_1)
531 (init_iterator): Empty the bidi cache "stack".
532 (move_it_in_display_line_to): If iterator ended up at
533 EOL, but we never saw any buffer positions smaller than
534 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
535 motion in bidi-reordered lines.
536 (move_it_in_display_line_to): Record prev_method and prev_pos
537 immediately before the call to set_iterator_to_next. Fixes cursor
538 motion in bidi-reordered lines with stretch glyphs and strings
539 displayed in margins. (Bug#8133) (Bug#8867)
540 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
541 TO_CHARPOS.
542 (pos_visible_p): Support positions in bidi-reordered lines. Save
543 and restore bidi cache.
544
545 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
546 (bidi_paragraph_info): Delete unused struct.
547 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
548 (bidi_cache_start): New variable.
549 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
550 to zero.
551 (bidi_cache_fetch_state, bidi_cache_search)
552 (bidi_cache_find_level_change, bidi_cache_iterator_state)
553 (bidi_cache_find, bidi_peek_at_next_level)
554 (bidi_level_of_next_char, bidi_find_other_level_edge)
555 (bidi_move_to_visually_next): Compare cache index with
556 bidi_cache_start rather than with zero.
557 (bidi_fetch_char): Accept new argument STRING; all callers
558 changed. Support iteration over a string. Support strings with
559 display properties. Support unibyte strings. Fix the type of
560 `len' according to what STRING_CHAR_AND_LENGTH expects.
561 (bidi_paragraph_init, bidi_resolve_explicit_1)
562 (bidi_resolve_explicit, bidi_resolve_weak)
563 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
564 iteration over a string.
565 (bidi_set_sor_type, bidi_resolve_explicit_1)
566 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
567 can now be zero (for strings); special values 0 and -1 were
568 changed to -1 and -2, respectively.
569 (bidi_char_at_pos): New function.
570 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
571 Call it instead of FETCH_MULTIBYTE_CHAR.
572 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
573 initialized to valid values.
574 (bidi_init_it): Don't initialize charpos and bytepos with invalid
575 values.
576 (bidi_level_of_next_char): Allow the sentinel "position" to pass
577 the test for valid cached positions. Fix the logic for looking up
578 the sentinel state in the cache. GCPRO the Lisp string we are
579 iterating.
580 (bidi_push_it, bidi_pop_it): New functions.
581 (bidi_initialize): Initialize the bidi cache start stack pointer.
582 (bidi_cache_ensure_space): New function, refactored from part of
583 bidi_cache_iterator_state. Don't assume the required size is just
584 one BIDI_CACHE_CHUNK away.
585 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
586 (bidi_count_bytes, bidi_char_at_pos): New functions.
587 (bidi_cache_search): Don't assume bidi_cache_last_idx is
588 always valid if bidi_cache_idx is valid.
589 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
590 is valid if it's going to be used.
591 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
592 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
593 (bidi_cache_find_level_change, bidi_cache_ensure_space)
594 (bidi_cache_iterator_state, bidi_cache_find)
595 (bidi_find_other_level_edge, bidi_cache_start_stack): All
596 variables related to cache indices are now EMACS_INT.
597
0bb23927
EZ
598 * dispextern.h (struct bidi_string_data): New structure.
599 (struct bidi_it): New member `string'. Make flag members be 1-bit
600 fields, and put them last in the struct.
601 (compute_display_string_pos, compute_display_string_end): Update
602 prototypes.
603 (bidi_push_it, bidi_pop_it): Add prototypes.
604 (struct iterator_stack_entry): New members bidi_p,
605 paragraph_embedding, and from_disp_prop_p.
606 (struct it): Member bidi_p is now a bit field 1 bit wide.
607 (bidi_shelve_cache, bidi_unshelve_cache): Declare
608 prototypes.
609
610 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
611 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
612 and vector-like objects.
613
614 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
615 cache around display iteration.
616
617 * window.c (Fwindow_end, window_scroll_pixel_based)
618 (displayed_window_lines, Frecenter): Save and restore the bidi
619 cache around display iteration.
620
3bbd2265
LMI
6212011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
622
623 * editfns.c (Fdelete_region): Clarify the use of the named
624 parameters (bug#6788).
625
adc47434
MR
6262011-07-14 Martin Rudalics <rudalics@gmx.at>
627
628 * indent.c (Fvertical_motion): Set and restore w->pointm when
629 saving and restoring the window's buffer (Bug#9006).
630
837c31f8
LMI
6312011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
632
633 * editfns.c (Fstring_to_char): Clarify just what is returned
634 (bug#6576). Text by Eli Zaretskii.
635
ac389d0c
JB
6362011-07-13 Juanma Barranquero <lekktu@gmail.com>
637
638 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
639
0be0ce47
EZ
6402011-07-13 Eli Zaretskii <eliz@gnu.org>
641
642 * buffer.c (mmap_find): Fix a typo.
643
cd18e7e3
JB
6442011-07-13 Johan Bockgård <bojohan@gnu.org>
645
646 Fix execution of x selection hooks.
647 * xselect.c (Qx_lost_selection_functions)
648 (Qx_sent_selection_functions): New vars.
649 (syms_of_xselect): DEFSYM them.
650 (x_handle_selection_request): Pass Qx_sent_selection_functions
651 rather than Vx_sent_selection_functions to Frun_hook_with_args.
652 (x_handle_selection_clear,x_clear_frame_selections):
653 Pass Qx_lost_selection_functions rather than
654 Vx_lost_selection_functions to Frun_hook_with_args.
655
47ea7f44
PE
6562011-07-13 Paul Eggert <eggert@cs.ucla.edu>
657
ac389d0c 658 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
659 The old code sometimes used this field without initializing it.
660
47ea7f44
PE
661 * alloc.c (gc_sweep): Don't read past end of array.
662 In theory, the old code could also have corrupted Emacs internals,
663 though it'd be very unlikely.
664
bc985c87
AS
6652011-07-12 Andreas Schwab <schwab@linux-m68k.org>
666
667 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 668 argument. (Bug#4026)
bc985c87 669
0cf34688
LMI
6702011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
671
b3dadd76
LMI
672 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
673 key" (bug#4257).
674
0cf34688
LMI
675 * window.c (Fset_window_start): Doc fix (bug#4199).
676 (Fset_window_hscroll): Ditto.
677
270768cd
PE
6782011-07-12 Paul Eggert <eggert@cs.ucla.edu>
679
077e3dda 680 Fix minor new problems caught by GCC 4.6.1.
270768cd 681 * term.c (init_tty): Remove unused local.
490011a6 682 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 683 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 684 not used otherwise.
270768cd 685
b1f58454
CY
6862011-07-12 Chong Yidong <cyd@stupidchicken.com>
687
688 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
689
22b9578d
LMI
6902011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
691
6e70ab07
LMI
692 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
693 are the mini-buffer and the echo area (bug#3320).
694
22b9578d
LMI
695 * term.c (init_tty): Remove support for supdup, c10 and perq
696 terminals, which are no longer supported (bug#1482).
697
8974cc9f
JB
6982011-07-10 Johan Bockgård <bojohan@gnu.org>
699
700 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
701
a560d974
JD
7022011-07-10 Jan Djärv <jan.h.d@swipnet.se>
703
704 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
705 for non-popups (Bug#3642).
706
1dae0f0a
AS
7072011-07-10 Andreas Schwab <schwab@linux-m68k.org>
708
268c2c36 709 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 710 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
711 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
712 * cm.c (losecursor): Likewise.
1dae0f0a
AS
713 * data.c (fmod): Likewise.
714 * dispnew.c (swap_glyphs_in_rows): Likewise.
715 * emacs.c (memory_warning_signal): Likewise.
716 * floatfns.c (float_error): Likewise.
717 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
718 (otf_open, font_otf_capability, generate_otf_features)
719 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
720 Likewise.
721 * image.c (pbm_read_file): Likewise.
722 * indent.c (string_display_width): Likewise.
723 * intervals.c (check_for_interval, search_for_interval)
724 (inc_interval_count, count_intervals, root_interval)
725 (adjust_intervals_for_insertion, make_new_interval): Likewise.
726 * lread.c (defalias): Likewise.
268c2c36 727 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
728 * regex.c (set_image_of_range_1, set_image_of_range)
729 (regex_grow_registers): Likewise.
730 * sysdep.c (strerror): Likewise.
731 * termcap.c (valid_filename_p, tprint, main): Likewise.
732 * tparam.c (main): Likewise.
733 * unexhp9k800.c (run_time_remap, save_data_space)
734 (update_file_ptrs, read_header, write_header, calculate_checksum)
735 (copy_file, copy_rest, display_header): Likewise.
736 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
737 Likewise.
738 * xdisp.c (check_it): Likewise.
739 * xfaces.c (register_color, unregister_color, unregister_colors):
740 Likewise.
741 * xfns.c (print_fontset_result): Likewise.
742 * xrdb.c (member, fatal, main): Likewise.
743
99033785
PE
7442011-07-10 Paul Eggert <eggert@cs.ucla.edu>
745
746 Fix minor problems found by static checking (Bug#9031).
747 * chartab.c (char_table_set_range, map_sub_char_table):
748 Remove unused locals.
749 (uniprop_table): Now static.
750 * composite.c (_work_char): Remove unused static var.
751
9cb2ac56
JB
7522011-07-09 Juanma Barranquero <lekktu@gmail.com>
753
754 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
755
f25661f0
JD
7562011-07-09 Jan Djärv <jan.h.d@swipnet.se>
757
758 * gtkutil.c (qttip_cb): Remove code without function.
759
8278c4fe
EZ
7602011-07-09 Eli Zaretskii <eliz@gnu.org>
761
762 * w32.c (pthread_sigmask): New stub.
763
1692ae2d 7642011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 765
8a6ebd58 766 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
767 sigprocmask is portable only for single-threaded applications, and
768 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
769 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
770 (LIBES): Use it.
771 * callproc.c (Fcall_process):
772 * process.c (create_process):
773 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
774 Use pthread_sigmask, not sigprocmask.
123403e4 775
1b854618
JD
7762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
777
778 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
779 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
780 wrong (Bug#8591).
781
3fe4b549
JD
7822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
783
0ce7e563
JD
784 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
785 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
786 (xg_hide_tooltip): Fix comment.
787
3fe4b549
JD
788 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
789 in registerServicesMenuSendTypes.
790 (validRequestorForSendType): Don't check ns_return_types.
791
792 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
793 ns_return_type.
794
5df75e47
JR
7952011-07-08 Jason Rumney <jasonr@gnu.org>
796
797 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
798 frame struct members of non-existent frames (Bug#6284).
799
699c10bd
JD
8002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
801
4393663b
JD
802 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
803 variable firstTime not needed on OSX >= 10.6.
804 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
805 >= 10.5. Use setKnobProportion, setDoubleValue.
806
807 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
808 (MAC_OS_X_VERSION_10_5): Define if not defined.
809 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
810 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
811 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
812
813 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
814 cString and lossyCString on OSX >= 10.4
815
816 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
817 sizeToFit on OSX >= 10.2.
818
819 * nsimage.m (allocInitFromFile): Don't use deprecated method
820 bestRepresentationForDevice on OSX >= 10.6.
821
822 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
823 to avoid warning.
824
825 * emacs.c: Declare unexec_init_emacs_zone.
826
a63e0781
JD
827 * nsgui.h: Fix compiler warning about gnulib redefining verify.
828
699c10bd
JD
829 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
830
831 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
832 on svcsMenu (Bug#8842).
833
834 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
835 ns_return_types.
836 (Fns_list_services): Just return Qnil on 10.6, code not working there.
837
838 * nsterm.m (QUTF8_STRING): Declare.
839 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
840 (validRequestorForSendType): Return type is (id).
841 Change indexOfObjectIdenticalTo to indexOfObject.
842 Check if we have local selection before returning self (Bug#8842).
843 (writeSelectionToPasteboard): Put local selection into paste board
844 if we have a local selection (Bug#8842).
845 (syms_of_nsterm): DEFSYM QUTF8_STRING.
846
847 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
848 (ns_get_local_selection): Declare.
849
54e10184
LMI
8502011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
851
9888ff71
LMI
852 * keymap.c (describe_map_tree): Don't insert a double newline at
853 the end of the buffer (bug#1169) and return whether we inserted
854 something.
855
54e10184
LMI
856 * callint.c (Fcall_interactively): Change "reading args" to
857 "providing args" to try to clarify what it does (bug#1010).
858
15fa4783
KH
8592011-07-07 Kenichi Handa <handa@m17n.org>
860
861 * composite.c (composition_compute_stop_pos): Ignore a static
862 composition starting before CHARPOS (Bug#8915).
863
864 * xdisp.c (handle_composition_prop): Likewise.
865
a8815b00
EZ
8662011-07-07 Eli Zaretskii <eliz@gnu.org>
867
868 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
869 (Bug#9015)
870
ef7b981d 8712011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
872
873 * character.h (unicode_category_t): New enum type.
874
875 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
876 (Qchar_code_property_table): New variable.
877 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
878 (UNIPROP_COMPRESSED_FORM_P): New macros.
879 (char_table_ascii): Uncompress the compressed values.
880 (sub_char_table_ref): New arg is_uniprop. Callers changed.
881 Uncompress the compressed values.
ac389d0c 882 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
883 (char_table_ref_and_range): Uncompress the compressed values.
884 (sub_char_table_set): New arg is_uniprop. Callers changed.
885 Uncompress the compressed values.
886 (sub_char_table_set_range): Args changed. Callers changed.
887 (char_table_set_range): Adjuted for the above change.
888 (map_sub_char_table): Delete args default_val and parent. Add arg
889 top. Give decoded values to a Lisp function.
890 (map_char_table): Adjusted for the above change. Give decoded
891 values to a Lisp function. Gcpro more variables.
892 (uniprop_table_uncompress)
893 (uniprop_decode_value_run_length): New functions.
894 (uniprop_decoder, uniprop_decoder_count): New variables.
895 (uniprop_get_decoder, uniprop_encode_value_character)
896 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
897 New functions.
898 (uniprop_encoder, uniprop_encoder_count): New variables.
899 (uniprop_get_encoder, uniprop_table)
900 (Funicode_property_table_internal, Fget_unicode_property_internal)
901 (Fput_unicode_property_internal): New functions.
902 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
903 Sunicode_property_table_internal, Sget_unicode_property_internal,
904 and Sput_unicode_property_internal. Defvar_lisp
905 char-code-property-alist.
906
907 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
908 Vunicode_category_table.
909
910 * font.c (font_range): Adjusted for the change of
911 Vunicode_category_table.
912
76b397fb
DN
9132011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
914
915 * m/iris4d.h: Remove file, move contents ...
916 * s/irix6-5.h: ... here.
917
22b4128e
PE
9182011-07-06 Paul Eggert <eggert@cs.ucla.edu>
919
920 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
921 * alloc.c (mark_buffer):
922 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
923 (clone_per_buffer_values): Don't assume that
22b4128e
PE
924 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
925 This isn't true in general, and it's particularly not true
926 if Emacs is configured with --with-wide-int.
927 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
928 New macros, used in the buffer.c change.
929
869795d6
JD
9302011-07-05 Jan Djärv <jan.h.d@swipnet.se>
931
932 * xsettings.c: Use both GConf and GSettings if both are available.
933 (store_config_changed_event): Add comment.
934 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
935 (store_tool_bar_style_changed): New functions.
936 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
937 (struct xsettings): Move font inside HAVE_XFT.
938 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
939 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
940 Move inside HAVE_XFT.
941 (something_changed_gsettingsCB): Renamed from something_changedCB.
942 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
943 also.
944 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
945 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
946 (something_changed_gconfCB): Renamed from something_changedCB.
947 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
948 (parse_settings): Move check for font inside HAVE_XFT.
949 (read_settings, apply_xft_settings): Add comment.
950 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
951 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
952 call store_font_name_changed.
953 (xft_settings_event): Add comment.
954 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
955 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
956 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
957 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
958 (xsettings_initialize): Call init_gsettings last.
959 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
960 comment.
961
d8ed26bd
PE
9622011-07-05 Paul Eggert <eggert@cs.ucla.edu>
963
964 Random fixes. E.g., (random) never returned negative values.
965 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
966 subseconds part to the entropy, as that's a bit more random.
967 Prefer signed to unsigned, since the signedness doesn't matter and
968 in general we prefer signed. When given a limit, use a
969 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
970 latter isn't right if USE_2_TAGS_FOR_INTS.
971 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
972 not 0..VALMASK. Don't discard "excess" bits that random () returns.
973
cabf1cac
SM
9742011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
975
976 * textprop.c (text_property_stickiness):
977 Obey Vtext_property_default_nonsticky.
978 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
979 * w32fns.c (syms_of_w32fns):
980 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
981
6e9b2be9
PE
9822011-07-04 Paul Eggert <eggert@cs.ucla.edu>
983
984 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
985 This is more efficient than Ffile_directory_p and avoids a minor race.
986
90186c68
LMI
9872011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
988
7c301272
LMI
989 * buffer.c (Foverlay_put): Say what the return value is
990 (bug#7835).
991
c4f2d8d4
LMI
992 * fileio.c (barf_or_query_if_file_exists): Check first if the file
993 is a directory before asking whether to use the file name
994 (bug#7564).
ad637907
LMI
995 (barf_or_query_if_file_exists): Make the "File is a directory"
996 error be more correct.
c4f2d8d4 997
90186c68
LMI
998 * fns.c (Frequire): Remove the mention of the .gz files, since
999 that's installation-specific, but keep the mention of
1000 `get-load-suffixes'.
1001
da64016e
PE
10022011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1003
1004 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1005 Report string overflow if the output is too long.
1006
7d47b580
JB
10072011-07-04 Juanma Barranquero <lekktu@gmail.com>
1008
a555cb87
JB
1009 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1010 (syms_of_gnutls): Remove duplicate DEFSYM for
1011 Qgnutls_bootprop_verify_hostname_error, an error for
1012 Qgnutls_bootprop_verify_error (which is no longer used).
1013
7d47b580
JB
1014 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1015 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1016 Also (re)move comments that are misplaced or no longer relevant.
1017
1e49bfab
LMI
10182011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1019
1020 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1021
1485f4c0
CY
10222011-07-03 Chong Yidong <cyd@stupidchicken.com>
1023
1024 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1025 and background color parameters if they have been changed.
1026
a9ab721e
LMI
10272011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1028
1029 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1030
cf7cff57
PE
10312011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1032
2e13213d
PE
1033 * xsettings.c (SYSTEM_FONT): Define only when used.
1034 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1035
cf7cff57
PE
1036 * keymap.c (access_keymap_1): Now static.
1037
7a8e04f7
CY
10382011-07-02 Chong Yidong <cyd@stupidchicken.com>
1039
1040 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1041 leave any prefix arg for the up event (Bug#1586).
1042
61352f62
LMI
10432011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1044
69bb1ef7
LMI
1045 * lread.c (syms_of_lread): Mention single symbols defined by
1046 `defvar' or `defconst' (bug#7154).
1047
61352f62 1048 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1049 (Frequire): Mention get-load-suffixes.
61352f62 1050
28545e04
MR
10512011-07-02 Martin Rudalics <rudalics@gmx.at>
1052
1053 * window.h (window): Remove clone_number slot.
1054 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1055 Remove.
1056 (make_parent_window, make_window, saved_window)
1057 (Fset_window_configuration, save_window_save): Don't deal with
1058 clone numbers.
1059 * buffer.c (Qclone_number): Remove declaration.
1060 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1061
3349e122
SM
10622011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1063
1064 Add multiple inheritance to keymaps.
1065 * keymap.c (Fmake_composed_keymap): New function.
1066 (Fset_keymap_parent): Simplify.
1067 (fix_submap_inheritance): Remove.
1068 (access_keymap_1): New function extracted from access_keymap to handle
1069 embedded parents and handle lists of maps.
1070 (access_keymap): Use it.
1071 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1072 (Fcopy_keymap): Handle embedded parents.
1073 (Fcommand_remapping, define_as_prefix): Simplify.
1074 (Fkey_binding): Simplify.
1075 (syms_of_keymap): Move minibuffer-local-completion-map,
1076 minibuffer-local-filename-completion-map,
1077 minibuffer-local-must-match-map, and
1078 minibuffer-local-filename-must-match-map to Elisp.
1079 (syms_of_keymap): Defsubr make-composed-keymap.
1080 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1081 (parse_menu_item): Trivial simplification.
1082
3279eb87
GM
10832011-07-01 Glenn Morris <rgm@gnu.org>
1084
1085 * Makefile.in (SETTINGS_LIBS): Fix typo.
1086
4550efdf
KI
10872011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1088
1089 * coding.c (Fencode_coding_string): Record the last coding system
1090 used, as the function doc string says (bug#8738).
1091
0949d2b6
JD
10922011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1093
1094 * xsettings.c (store_monospaced_changed): Take new font as arg and
1095 check for change against current_mono_font.
1096 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1097 (emacs_settings_constructor, emacs_settings_get_property)
1098 (emacs_settings_set_property, emacs_settings_class_init)
1099 (emacs_settings_init, gsettings_obj): Remove.
1100 (something_changedCB): New function for HAVE_GSETTINGS.
1101 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1102 with value as argument.
1103 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1104 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1105 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1106 "changed".
1107
1108 * xgselect.c: Add defined (HAVE_GSETTINGS).
1109 (xgselect_initialize): Ditto.
1110
1111 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1112 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1113 xg_select.
1114
bbc6b304
PE
11152011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1116
1117 * eval.c (struct backtrace): Simplify and port the data structure.
1118 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1119 signed bit field, as this assumption is not portable and it makes
1120 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1121 "char debug_on_exit : 1" as this is not portable either; instead,
1122 use the portable "unsigned int debug_on_exit : 1". Remove unused
1123 member evalargs. Remove obsolete comments about cc bombing out.
1124
9851bfc5
JD
11252011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1126
51bb811f 1127 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1128 Let HAVE_GSETTINGS override HAVE_GCONF.
1129 (store_monospaced_changed): New function.
1130 (EMACS_SETTINGS): A new type derived from GObject to handle
1131 GSettings notifications.
1132 (emacs_settings_constructor, emacs_settings_get_property)
1133 (emacs_settings_set_property, emacs_settings_class_init):
1134 New functions.
1135 (gsettings_client, gsettings_obj): New variables.
1136 (GSETTINGS_SCHEMA): New define.
1137 (something_changedCB): Call store_monospaced_changed.
1138 (init_gsettings): New function.
1139 (xsettings_initialize): Call init_gsettings.
1140 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1141 to NULL.
1142
1143 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1144 GCONF_CFLAGS/LIBS.
1145
5386012d
MR
11462011-06-29 Martin Rudalics <rudalics@gmx.at>
1147
1148 * window.c (resize_root_window, grow_mini_window)
1149 (shrink_mini_window): Rename Qresize_root_window to
1150 Qwindow_resize_root_window and Qresize_root_window_vertically to
1151 Qwindow_resize_root_window_vertically.
1152
f13e0b08
PE
11532011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1154
1155 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1156
94515237
JB
11572011-06-27 Juanma Barranquero <lekktu@gmail.com>
1158
1159 * makefile.w32-in: Redesign dependencies so they reflect more
1160 clearly which files are directly included by each source file,
1161 and not through other includes.
1162
e43b6e43
MR
11632011-06-27 Martin Rudalics <rudalics@gmx.at>
1164
1165 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1166 (sort_overlays, overlay_strings): When an overlay's clone number
1167 matches the window's clone number process the overlay even if
1168 the overlay's window property doesn't match the current window.
1169
d68443dc
MR
1170 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1171 (Fwindow_hchild): Rename to Fwindow_left_child.
1172 (Fwindow_next): Rename to Fwindow_next_sibling.
1173 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1174 (resize_window_check): Rename to window_resize_check.
1175 (resize_window_apply): Rename to window_resize_apply.
1176 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1177 (Fdelete_other_windows_internal, resize_frame_windows)
1178 (Fsplit_window_internal, Fdelete_window_internal)
1179 (grow_mini_window, shrink_mini_window)
1180 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1181
c7e73be5
JD
11822011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1183
1184 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1185 (emacs_fixed_set_min_size): Remove.
1186 (emacs_fixed_new): Take frame as argument.
1187
1188 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1189 (_EmacsFixedPrivate): Remove minwidth/height.
1190 Add struct frame *f.
1191 (emacs_fixed_init): Initialize priv->f.
1192 (get_parent_class, emacs_fixed_set_min_size): Remove.
1193 (emacs_fixed_new): Set priv->f to argument.
1194 (emacs_fixed_get_preferred_width)
1195 (emacs_fixed_get_preferred_height): Use min_width/height from
1196 frames size_hint to set minimum and natural (Bug#8919).
1197 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1198 and use min_width/height from frames size_hint to set
1199 min_width/height (Bug#8919).
1200
1201 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1202 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1203 Fix indentation.
c7e73be5 1204
cf99dcf8
EZ
12052011-06-26 Eli Zaretskii <eliz@gnu.org>
1206
1207 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1208 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1209 called at ZV.
1210
029529ac
CY
12112011-06-26 Chong Yidong <cyd@stupidchicken.com>
1212
1213 * process.c (wait_reading_process_output): Bypass select if
1214 waiting for a cell while ignoring keyboard input, and input is
1215 pending. Suggested by Jan Djärv (Bug#8869).
1216
7a7ef429
PE
12172011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1218
1219 Use gnulib's dup2 module instead of rolling our own.
1220 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1221
11fdef7d 12222011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1223
1224 * dispnew.c (scrolling_window): Before scrolling, turn off a
1225 mouse-highlight in the window being scrolled.
1226
cd3520a4
JB
12272011-06-24 Juanma Barranquero <lekktu@gmail.com>
1228
1229 Move DEFSYM to lisp.h and use everywhere.
1230
1231 * character.h (DEFSYM): Move declaration...
1232 * lisp.h (DEFSYM): ...here.
1233
1234 * gnutls.c:
1235 * minibuf.c:
1236 * w32menu.c:
1237 * w32proc.c:
1238 * w32select.c: Don't include character.h.
1239
1240 * alloc.c (syms_of_alloc):
1241 * buffer.c (syms_of_buffer):
1242 * bytecode.c (syms_of_bytecode):
1243 * callint.c (syms_of_callint):
1244 * casefiddle.c (syms_of_casefiddle):
1245 * casetab.c (init_casetab_once):
1246 * category.c (init_category_once, syms_of_category):
1247 * ccl.c (syms_of_ccl):
1248 * cmds.c (syms_of_cmds):
1249 * composite.c (syms_of_composite):
1250 * dbusbind.c (syms_of_dbusbind):
1251 * dired.c (syms_of_dired):
1252 * dispnew.c (syms_of_display):
1253 * doc.c (syms_of_doc):
1254 * editfns.c (syms_of_editfns):
1255 * emacs.c (syms_of_emacs):
1256 * eval.c (syms_of_eval):
1257 * fileio.c (syms_of_fileio):
1258 * fns.c (syms_of_fns):
1259 * frame.c (syms_of_frame):
1260 * fringe.c (syms_of_fringe):
1261 * insdel.c (syms_of_insdel):
1262 * keymap.c (syms_of_keymap):
1263 * lread.c (init_obarray, syms_of_lread):
1264 * macros.c (syms_of_macros):
1265 * msdos.c (syms_of_msdos):
1266 * print.c (syms_of_print):
1267 * process.c (syms_of_process):
1268 * search.c (syms_of_search):
1269 * sound.c (syms_of_sound):
1270 * syntax.c (init_syntax_once, syms_of_syntax):
1271 * terminal.c (syms_of_terminal):
1272 * textprop.c (syms_of_textprop):
1273 * undo.c (syms_of_undo):
1274 * w32.c (globals_of_w32):
1275 * window.c (syms_of_window):
1276 * xdisp.c (syms_of_xdisp):
1277 * xfaces.c (syms_of_xfaces):
1278 * xfns.c (syms_of_xfns):
1279 * xmenu.c (syms_of_xmenu):
1280 * xsettings.c (syms_of_xsettings):
1281 * xterm.c (syms_of_xterm): Use DEFSYM.
1282
4228cf16
TZ
12832011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1284
cd3520a4 1285 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1286
7fcccf1e
PE
12872011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1288
7efb4e0e
PE
1289 Integer and buffer overflow fixes (Bug#8873).
1290
ff5844ad
PE
1291 * print.c (printchar, strout): Check for string overflow.
1292 (PRINTPREPARE, printchar, strout):
1293 Don't set size unless allocation succeeds.
1294
90532f02
PE
1295 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1296 for sizes. Check for string overflow more accurately.
1297 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1298
6d84508d
PE
1299 * macros.c: Integer and buffer overflow fixes.
1300 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1301 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1302 Use ptrdiff_t, not int, for sizes.
1303 Don't increment bufsize until after realloc succeeds.
1304 Check for size-calculation overflow.
1305 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1306
437b2cb4
PE
1307 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1308
8b9ac8b4
PE
1309 * lread.c: Integer overflow fixes.
1310 (read_integer): Radix is now EMACS_INT, not int,
1311 to improve quality of diagnostics for out-of-range radices.
1312 Calculate buffer size correctly for out-of-range radices.
1313 (read1): Check for integer overflow in radices, and in
1314 read-circle numbers.
82cb60d3
PE
1315 (read_escape): Avoid int overflow.
1316 (Fload, openp, read_buffer_size, read1)
1317 (substitute_object_recurse, read_vector, read_list, map_obarray):
1318 Use ptrdiff_t, not int, for sizes.
1319 (read1): Use EMACS_INT, not int, for sizes.
20270765 1320 Check for size overflow.
8b9ac8b4 1321
7fcccf1e
PE
1322 * image.c (cache_image): Check for size arithmetic overflow.
1323
bfbbd7e7
PE
1324 * lread.c: Integer overflow issues.
1325 (saved_doc_string_size, saved_doc_string_length)
1326 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1327 Now ptrdiff_t, not int.
1328 (read1): Don't assume doc string length fits in int. Check for
1329 out-of-range doc string lengths.
1330 (read_list): Don't assume file position fits in int.
39019e54 1331 (read_escape): Check for hex character overflow.
bfbbd7e7 1332
4e323265
LL
13332011-06-22 Leo Liu <sdl.web@gmail.com>
1334
1335 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1336 Move to minibuffer.el.
1337
85fece3e
PE
13382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1339
20b84ce9 1340 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1341 The following patches are for when GLYPH_DEBUG && !XASSERT.
1342 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1343 * dispnew.c (flush_stdout):
1344 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1345 Mark as externally visible.
1346 * dispnew.c (check_window_matrix_pointers): Now static.
1347 * dispnew.c (window_to_frame_vpos):
1348 * xfns.c (unwind_create_frame):
1349 * xterm.c (x_check_font): Remove unused local.
1350 * scroll.c (CHECK_BOUNDS):
1351 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1352 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1353 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1354 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1355 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1356 Now static.
1357 (debug_method_add): Use va_list and vsprintf rather than relying
1358 on undefined behavior with wrong number of arguments.
1359 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1360 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1361 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1362 since we're not interested in debugging glyphs with old libraries.
1363 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1364 GCC 4.6.0's static checking.
1365
0766b489
PE
13662011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1367
31fd4b32
PE
1368 Integer overflow and signedness fixes (Bug#8873).
1369 A few related buffer overrun fixes, too.
1370
b79e8648
PE
1371 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1372
0766b489
PE
1373 * dispextern.h (struct face.stipple):
1374 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1375 (x_bitmap_mask, x_allocate_bitmap_record)
1376 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1377 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1378 (x_create_bitmap_from_xpm_data):
1379 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1380 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1381 (.bitmaps_last):
1382 * xfaces.c (load_pixmap):
1383 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1384 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1385 (.bitmaps_last, struct x_output.icon_bitmap):
1386 Use ptrdiff_t, not int, for bitmap indexes.
1387 (x_allocate_bitmap_record): Check for size overflow.
1388 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1389
b081724f
PE
1390 Use ptrdiff_t, not int, for overlay counts.
1391 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1392 * editfns.c (overlays_around, get_pos_property):
1393 * textprop.c (get_char_property_and_overlay):
1394 * xdisp.c (next_overlay_change, note_mouse_highlight):
1395 * xfaces.c (face_at_buffer_position):
21514da7
PE
1396 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1397 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1398 (Fnext_overlay_change, Fprevious_overlay_change)
1399 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1400 Use ptrdiff_t, not int, for sizes.
21514da7 1401 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1402
3de73e5e
PE
1403 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1404
2606c57b
PE
1405 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1406 (x_session_initialize): Do not assume string length fits in int.
1407
aaafe47a
PE
1408 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1409 This is unlikely, but can occur if DPI is outlandish.
1410
2674ddc8 1411 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1412 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1413
28154962
PE
1414 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1415 * xrdb.c (magic_file_p, search_magic_path):
1416 Omit last arg SUFFIX; it was always 0. All callers changed.
1417 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1418
7de51af5
PE
1419 * xfont.c (xfont_match): Avoid need for strlen.
1420
25ed6cc3
PE
1421 * xfns.c: Don't assume strlen fits in int.
1422 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1423
4eab31dd
PE
1424 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1425 not unsigned long, as we prefer signed integers. All callers changed.
1426 Detect integer overflow in repeat count.
1427 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1428 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1429
171e2a58
PE
1430 * termcap.c: Don't assume sizes fit in int and never overflow.
1431 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1432 (gobble_line): Check for size-calculation overflow.
1433
ad39faca 1434 * minibuf.c (Fread_buffer):
6e5bb2dc 1435 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1436 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1437 Don't assume string length fits in int.
1438
52c61c22 1439 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1440 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1441
b5b8c9e5
PE
1442 * font.c: Don't assume string length fits in int.
1443 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1444 Use ptrdiff_t, not int.
ccd6111c
PE
1445 (font_intern_prop): Don't assume string length fits in int.
1446 Don't assume integer property fits in fixnum.
1447 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1448
882f0d81 1449 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1450 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1451 Reformulate so as not to need the command string.
1452 Invoke gzip -cd rather than gunzip, as it's more portable.
1453 (lock_info_type, lock_file_1, lock_file):
1454 Don't assume pid_t and time_t fit in unsigned long.
1455 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1456 (current_lock_owner): Prefer signed type for sizes.
1457 Use memcpy, not strncpy, where memcpy is what is really wanted.
1458 Don't assume (via atoi) that time_t and pid_t fit in int.
1459 Check for time_t and/or pid_t out of range, e.g., via a network share.
1460 Don't alloca where an auto var works fine.
1461
93f4cf88
PE
1462 * fileio.c: Fix some integer overflow issues.
1463 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1464 Don't assume string length fits in int.
1465 (directory_file_name): Don't assume string length fits in long.
1466 (make_temp_name): Don't assume pid fits in int, or that its print
1467 length is less than 20.
1468
f3e92b69
PE
1469 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1470
1bfdaf10
PE
1471 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1472
35016e9a
PE
1473 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1474
3d1e65a1
PE
1475 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1476 We prefer signed integers, even for size calculations.
1477
0b963a93
PE
1478 * emacs.c: Don't assume string length fits in 'int'.
1479 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1480 (main): Don't invoke strlen when not needed.
1481
573f4b54
PE
1482 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1483 (XD_DEBUG_MESSAGE): Don't waste a byte.
1484
989f33ba
PE
1485 * callproc.c (getenv_internal_1, getenv_internal)
1486 (Fgetenv_internal):
965d34eb
PE
1487 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1488
e4d29b33
PE
1489 * lread.c (invalid_syntax): Omit length argument.
1490 All uses changed. This doesn't fix a bug, but it simplifies the
1491 code away from its former Hollerith-constant appearance, and it's
1492 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1493 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1494
eb49b136
PE
1495 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1496 This didn't break anything, but it didn't help either.
1497 It's confusing to put a bogus integer in a place where the actual
1498 value does not matter.
9f62aeb1 1499 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1500 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1501
15375a22
PE
1502 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1503 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1504 implementation.
b61cc01c
PE
1505 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1506 We prefer signed types, and the value cannot exceed the EMACS_INT
1507 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1508 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1509 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1510 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1511
53b2623d
PE
1512 * indent.c (sane_tab_width): New function.
1513 (current_column, scan_for_column, Findent_to, position_indentation)
1514 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1515 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1516
51cab52b 1517 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1518
f2ed8a70
PE
1519 * lisp.h (lint_assume): New macro.
1520 * composite.c (composition_gstring_put_cache):
1521 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1522
abe80cc6
PE
1523 * editfns.c, insdel.c:
1524 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1525
b02c740e
PE
1526 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1527
ebc96716
PE
1528 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1529
b4e50fa0 1530 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1531 Use much-faster test for byte-length change.
311d5d7c 1532 Don't assume string byte-length fits in 'int'.
a4cf38e4 1533 Check that character arg fits in 'int'.
85461888 1534 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1535
c0c1ee9f
PE
1536 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1537
a498d7f4
PE
1538 * fns.c (concat): Catch string overflow earlier.
1539 Do not rely on integer wraparound.
1540
51cab52b
PE
1541 * dispextern.h (struct it.overlay_strings_charpos)
1542 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1543 * xdisp.c (forward_to_next_line_start)
1544 (back_to_previous_visible_line_start)
1545 (reseat_at_next_visible_line_start, next_element_from_buffer):
1546 Don't arbitrarily truncate the value of 'selective' to int.
1547
76031fad
PE
1548 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1549
5eb55db9
PE
1550 * composite.c: Don't truncate sizes to 'int'.
1551 (composition_gstring_p, composition_reseat_it)
1552 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1553 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1554 not EMACS_UINT, for indexes.
5eb55db9 1555
0703a717
PE
1556 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1557
d6202519
PE
1558 * buffer.c: Include <verify.h>.
1559 (struct sortvec.priority, struct sortstr.priority):
8961a454 1560 Now EMACS_INT, not int.
c20998a7 1561 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1562 (struct sortstr.size, record_overlay_string)
1563 (struct sortstrlist.size, struct sortlist.used):
1564 Don't truncate size to int.
1565 (record_overlay_string): Check for size-calculation overflow.
d6202519 1566 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1567
d5a19415
JM
15682011-06-22 Jim Meyering <meyering@redhat.com>
1569
029529ac 1570 Don't leak an XBM-image-sized buffer
d5a19415
JM
1571 * image.c (xbm_load): Free the image buffer after using it.
1572
a9041e6c
PE
15732011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1574
1575 Port to Sun C.
1576 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1577 that Sun C diagnosed.
1578 * fns.c (secure_hash): Fix pointer signedness issue.
1579 * intervals.c (static_offset_intervals): New function.
1580 (offset_intervals): Use it.
1581
7f3f739f
LL
15822011-06-21 Leo Liu <sdl.web@gmail.com>
1583
1584 * deps.mk (fns.o):
1585 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1586 sha512.h.
1587
1588 * fns.c (secure_hash): Rename from crypto_hash_function and change
1589 the first arg to accept symbols.
5b66d427 1590 (Fsecure_hash): New primitive.
7f3f739f
LL
1591 (syms_of_fns): New symbols.
1592
76147d94
DD
15932011-06-20 Deniz Dogan <deniz@dogan.se>
1594
1595 * process.c (Fset_process_buffer): Clarify return value in
1596 docstring.
1597
7d7d0045
CY
15982011-06-18 Chong Yidong <cyd@stupidchicken.com>
1599
1600 * dispnew.c (add_window_display_history): Use BVAR.
1601
1602 * xdisp.c (debug_method_add): Use BVAR.
1603 (check_window_end, dump_glyph_matrix, dump_glyph)
1604 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1605
1606 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1607 Likewise.
1608
1609 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1610 check till after the cache is created in init_frame_faces.
1611
ff2bc410
SM
16122011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1613
1614 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1615
28177add
PE
16162011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1617
dd3482fe
PE
1618 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1619 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1620 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1621
393d71f3 1622 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1623 * fileio.c (Finsert_file_contents):
1624 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1625 Remove the old (too-loose) buffer overflow checks.
1626 They weren't needed, since make_gap checks for buffer overflow.
1627 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1628 The old code merely checked for Emacs fixnum overflow, and relied
1629 on undefined (wraparound) behavior. The new code avoids undefined
1630 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1631
2e6813b0 1632 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1633 Tune. Don't use wider integers than needed. Don't use alloca.
1634 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1635
599a9e4f
PE
1636 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1637
99561444
PE
1638 * insdel.c, lisp.h (buffer_overflow): New function.
1639 (insert_from_buffer_1, replace_range, replace_range_2):
1640 * insdel.c (make_gap_larger):
1641 * editfns.c (Finsert_char):
1642 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1643
28177add
PE
1644 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1645
e69dafad
PE
16462011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1647
a7af7fde 1648 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1649
b1c46f02
PE
1650 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1651 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1652
e69dafad
PE
1653 * fileio.c: Don't assume EMACS_INT fits in off_t.
1654 (emacs_lseek): New static function.
1655 (Finsert_file_contents, Fwrite_region): Use it.
1656 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1657
566684ea
PE
1658 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1659
e6966cd6
PE
1660 * fns.c: Don't overflow int when computing a list length.
1661 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1662 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1663 truncation on 64-bit hosts. Check for QUIT every
1664 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1665 faster and is responsive enough.
1666 (Flength): Report an error instead of overflowing an integer.
1667 (Fsafe_length): Return a float if the value is not representable
1668 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1669 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1670 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1671
dd0b0efb
PE
1672 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1673 (header_size, word_size): New constants.
1674 (allocate_vectorlike): Don't check size overflow here.
1675 (allocate_vector): Check it here instead, since this is the only
1676 caller of allocate_vectorlike that could cause overflow.
1677 Check that the new vector's length is representable as a fixnum.
1678
86fe5cfe
PE
1679 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1680 The previous code was bogus. For example, next_almost_prime (32)
1681 returned 39, which is undesirable as it is a multiple of 3; and
1682 next_almost_prime (24) returned 25, which is a multiple of 5 so
1683 why was the code bothering to check for multiples of 7?
1684
80e88859
PE
1685 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1686
4a2f0ad6
PE
1687 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1688
f66c7cf8
PE
1689 Variadic C functions now count arguments with ptrdiff_t.
1690 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1691 Back then I didn't know that the Emacs coding style prefers signed int.
1692 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1693 were being counted with int, which may truncate counts on 64-bit
1694 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1695 * lisp.h (struct Lisp_Subr.function.aMANY)
1696 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1697 Arg counts are now ptrdiff_t, not size_t.
1698 All variadic functions and their callers changed accordingly.
1699 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1700 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1701 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1702 * callint.c (Fcall_interactively): Check arg count for overflow,
1703 to avoid potential buffer overrun. Use signed char, not 'int',
1704 for 'varies' array, so that we needn't bother to check its size
1705 calculation for overflow.
1706 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1707 * eval.c (apply_lambda):
1708 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1709 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1710 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1711
a1759b76
PE
1712 * callint.c (Fcall_interactively): Don't use index var as event count.
1713
d96be9fc
PE
1714 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1715 * mem-limits.h (SIZE): Remove; no longer used.
1716
a690a978 1717 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1718
578c21e6
PE
1719 Remove unnecessary casts.
1720 * xterm.c (x_term_init):
1721 * xfns.c (x_set_border_pixel):
1722 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1723 These aren't needed now that we assume ANSI C.
1724
96f53c6c
PE
1725 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1726 It's more likely to cause problems (due to unsigned overflow)
1727 than to cure them.
1728
83c77d31
PE
1729 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1730
ee2079f1
PE
1731 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1732
6da65536
PE
1733 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1734
7147c4a4
PE
1735 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1736
193e32d9
PE
1737 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1738
e5533da6
PE
1739 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1740
9910e595
PE
1741 GLYPH_CODE_FACE returns EMACS_INT, not int.
1742 * dispextern.h (merge_faces):
1743 * xfaces.c (merge_faces):
01103c44
PE
1744 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1745 Don't assume EMACS_INT fits in int.
9910e595 1746
2638320e
PE
1747 * character.h (CHAR_VALID_P): Remove unused parameter.
1748 * fontset.c, lisp.h, xdisp.c: All uses changed.
1749
045eb8d9
PE
1750 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1751
c1f134b5
PE
1752 * fns.c (concat): Minor tuning based on overflow analysis.
1753 This doesn't fix any bugs. Use int to hold character, instead
1754 of constantly refetching from Emacs object. Use XFASTINT, not
1755 XINT, for value known to be a character. Don't bother comparing
1756 a single byte to 0400, as it's always less.
1757
395fcb93 1758 * floatfns.c (Fexpt):
327eeec8
PE
1759 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1760
abbd3d23
PE
1761 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1762 for characters.
1763
684a03ef
PE
1764 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1765
0fed43f3
PE
1766 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1767 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1768 incorrectly succeed when S was a string, because 4294967386 was
1769 truncated before it was used.
1770
8fd02eb7
PE
1771 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1772 Otherwise, an out-of-range integer could cause undefined behavior
1773 on a 64-bit host.
1774
f8c86b69
PE
1775 * composite.c: Use int, not EMACS_INT, for characters.
1776 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1777 EMACS_INT, for values that are known to be in character range.
1778 This doesn't fix any bugs but is the usual style inside Emacs and
1779 may generate better code on 32-bit machines.
1780
34206dd2
PE
1781 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1782 This is for reasons similar to the recent CHAR_STRING fix.
1783 * charset.c (Fencode_char): Check that character arg is actually
1784 a character. Pass an int to ENCODE_CHAR.
1785 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1786 wider than 'int', as a compile-time check to prevent future regressions
1787 in this area.
1788
c5958d4c 1789 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1790
1791 Make sure a 64-bit char is never passed to CHAR_STRING.
1792 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1793 by silently ignoring the top 32 bits, allowing some values
1794 that were far too large to be valid characters.
1795 * character.h: Include <verify.h>.
1796 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1797 arguments are no wider than unsigned, as a compile-time check
1798 to prevent future regressions in this area.
1799 * data.c (Faset):
01103c44 1800 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1801 (Fsubst_char_in_region):
1802 * fns.c (concat):
1803 * xdisp.c (decode_mode_spec_coding):
1804 Adjust to CHAR_STRING's new requirement.
1805 * editfns.c (Finsert_char, Fsubst_char_in_region):
1806 * fns.c (concat): Check that character args are actually
1807 characters. Without this test, these functions did the wrong
1808 thing with wildly out-of-range values on 64-bit hosts.
1809
d37ca623
PE
1810 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1811 These casts should not be needed on 32-bit hosts, either.
1812 * keyboard.c (read_char):
1813 * lread.c (Fload): Remove casts to unsigned.
1814
ea204efb
PE
1815 * lisp.h (UNSIGNED_CMP): New macro.
1816 This fixes comparison bugs on 64-bit hosts.
1817 (ASCII_CHAR_P): Use it.
1818 * casefiddle.c (casify_object):
01103c44 1819 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1820 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1821 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1822 * dispextern.h (FACE_FROM_ID):
1823 * keyboard.c (read_char): Use UNSIGNED_CMP.
1824
41cb286c
PE
1825 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1826 not to EMACS_INT, to avoid GCC warning.
1827
4a1b9832
PE
1828 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1829
55daad71
PE
1830 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1831 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1832 isn't needed on 32-bit machines.
8f95c75c 1833
01103c44
PE
1834 * buffer.c (Fgenerate_new_buffer_name):
1835 Use EMACS_INT for count, not int.
0ceccced 1836 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1837
1838 * data.c (Qcompiled_function): Now static.
1839
c6f072e7
PE
1840 * window.c (window_body_lines): Now static.
1841
20ce5912
PE
1842 * image.c (gif_load): Rename local to avoid shadowing.
1843
9c4c5f81
PE
1844 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1845 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1846 * alloc.c (make_save_value): Integer argument is now of type
1847 ptrdiff_t, not int.
1848 (mark_object): Use ptrdiff_t, not int.
1849 * lisp.h (pD): New macro.
1850 * print.c (print_object): Use it.
1851
c0c5c8ae
PE
1852 * alloc.c: Use EMACS_INT, not int, to count objects.
1853 (total_conses, total_markers, total_symbols, total_vector_size)
1854 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1855 (total_free_floats, total_floats, total_free_intervals)
1856 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1857 Now EMACS_INT, not int. All uses changed.
1858 (Fgarbage_collect): Compute overall total using a double, so that
1859 integer overflow is less likely to be a problem. Check for overflow
1860 when converting back to an integer.
5a25e253
PE
1861 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1862 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1863 These were 'int' variables that could overflow on 64-bit hosts;
1864 they were never used, so remove them instead of repairing them.
211a0b2a 1865 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1866 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1867 Previously, this ceilinged at INT_MAX, but that doesn't work on
1868 64-bit machines.
e46bb31a 1869 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1870
c78baabf 1871 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1872 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1873 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1874 when a (possibly-narrower) signed value would do just as well.
1875 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1876
c9d624c6
PE
1877 * alloc.c: Catch some string size overflows that we were missing.
1878 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1879 for convenience in STRING_BYTES_MAX.
1880 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1881 The definition here is exact; the one in lisp.h was approximate.
1882 (allocate_string_data): Check for string overflow. This catches
1883 some instances we weren't catching before. Also, it catches
1884 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1885 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1886 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1887
c9d624c6
PE
1888 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1889 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1890 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1891
353032ce
PE
1892 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1893
2bccce07
PE
1894 * alloc.c (Fmake_string): Check for out-of-range init.
1895
0ac30604
SM
18962011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1897
1898 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1899
c195f2de
JD
19002011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1901
1902 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1903 xg_get_default_scrollbar_width.
1904
1905 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1906 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1907 (style_changed_cb): Call update_theme_scrollbar_width and call
1908 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1909 all frames (Bug#8505).
1910 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1911 Call gtk_window_set_resizable if HAVE_GTK3.
1912 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1913 and height if HAVE_GTK3 (Bug#8505).
1914 (scroll_bar_width_for_theme): New variable.
1915 (update_theme_scrollbar_width): New function.
1916 (xg_get_default_scrollbar_width): Move code to
1917 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1918 (xg_initialize): Call update_theme_scrollbar_width.
1919
1920 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1921
1922 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1923
e10ac9f1
MR
19242011-06-12 Martin Rudalics <rudalics@gmx.at>
1925
1926 * frame.c (make_frame): Call other_buffer_safely instead of
1927 other_buffer.
1928
1929 * window.c (temp_output_buffer_show): Call display_buffer with
1930 second argument Vtemp_buffer_show_specifiers and reset latter
1931 immediately after the call.
1932 (Vtemp_buffer_show_specifiers): New variable.
1933 (auto_window_vscroll_p, next_screen_context_lines)
1934 (Vscroll_preserve_screen_position): Remove leading asterisks from
1935 doc-strings.
1936
2d3c217e 19372011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1938
7b7f97e8 1939 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1940 * buffer.c (Qclone_number): Remove for now, as it's unused.
1941 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1942 (record_buffer): Remove unused local.
1943 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1944 (set_frame_buffer_list): Remove; unused.
1945 * frame.h (other_visible_frames): Remove decl.
1946 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1947 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1948 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1949 if HAVE_GPM.
1950 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1951 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1952 Define only if HAVE_GPM.
1953 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1954 (update_hints_inhibit): Remove; never set. All uses removed.
1955 * widgetprv.h (emacsFrameClassRec): Remove decl.
1956 * window.c (delete_deletable_window): Now returns void, since it
1957 wasn't returning anything.
1958 (compare_window_configurations): Remove unused locals.
1959 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1960 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1961 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1962 the same widths as pointers. This follows up on the 2011-05-06 patch.
1963 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1964 * xterm.h: Likewise.
1965 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1966
1384b89e
JB
19672011-06-12 Juanma Barranquero <lekktu@gmail.com>
1968
1969 * makefile.w32-in: Update dependencies.
1970 (LISP_H): Add lib/intprops.h.
1971
1100a63c
CY
19722011-06-11 Chong Yidong <cyd@stupidchicken.com>
1973
1974 * image.c (gif_load): Add animation frame delay to the metadata.
1975 (syms_of_image): Use DEFSYM. New symbol `delay'.
1976
6198ccd0
MR
19772011-06-11 Martin Rudalics <rudalics@gmx.at>
1978
1979 * window.c (delete_deletable_window): Re-add.
1980 (Fset_window_configuration): Rewrite to handle dead buffers and
1981 consequently deletable windows.
1982 (window_tree, Fwindow_tree): Remove. Supply functionality in
1983 window.el.
1984 (compare_window_configurations): Simplify code.
1985
b6e3633c
AS
19862011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1987
1ab0dee5
AS
1988 * image.c (imagemagick_load_image): Fix type mismatch.
1989 (Fimagemagick_types): Likewise.
1990
b6e3633c
AS
1991 * window.h (replace_buffer_in_windows): Declare.
1992
9397e56f
MR
19932011-06-11 Martin Rudalics <rudalics@gmx.at>
1994
1995 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1996 Qclone_number. Remove external declaration of Qdelete_window.
1997 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1998 code.
1999 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2000 Qbuffer_list_update_hook if allowed.
2001 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2002 buffer list implementation.
2003 (other_buffer_safely): New function.
2004 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2005 calls to replace_buffer_in_windows and
2006 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2007 if allowed.
2008 (record_buffer): Inhibit quitting and rewrite using quittable
2009 functions. Run Qbuffer_list_update_hook if allowed.
2010 (Frecord_buffer, Funrecord_buffer): New functions.
2011 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2012 switch-to-buffer to window.el.
2013 (bury-buffer): Move to window.el.
2014 (Vbuffer_list_update_hook): New variable.
2015
2016 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2017 section.
2018
2019 * window.h (resize_frame_windows): Move up in code.
2020 (Fwindow_frame): Remove EXFUN.
2021 (replace_buffer_in_all_windows): Remove prototype.
2022 (replace_buffer_in_windows_safely): Add prototype.
2023
2024 * window.c: Declare Qdelete_window static again. Move down
2025 declaration of select_count.
2026 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2027 (Fother_window): Move to window.el.
2028 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2029 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2030 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2031 window.el.
2032 (replace_buffer_in_windows): Implement by calling
2033 Qreplace_buffer_in_windows.
2034 (replace_buffer_in_all_windows): Remove with some functionality
2035 moved into replace_buffer_in_windows_safely.
2036 (replace_buffer_in_windows_safely): New function.
2037 (select_window_norecord, select_frame_norecord): Move in front
2038 of run_window_configuration_change_hook. Remove now obsolete
2039 declarations.
2040 (Fset_window_buffer): Rewrite doc-string. Call
2041 Qrecord_window_buffer.
2042 (keys_of_window): Move binding for other-window to window.el.
2043
b50691aa
CY
20442011-06-11 Chong Yidong <cyd@stupidchicken.com>
2045
2046 * dispextern.h (struct image): Replace data member, whose int_val
2047 and ptr_val fields were not used by anything, with a single
2048 lisp_val object.
2049
2050 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2051 (gif_clear_image, gif_load, imagemagick_load_image)
2052 (gs_clear_image, gs_load): Callers changed.
2053
3f754b86
PE
20542011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2055
cca69397
PE
2056 * buffer.h: Include <time.h>, for time_t.
2057 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2058
109e28d0
PE
2059 Fix minor problems found by static checking.
2060
60737f02
PE
2061 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2062
4b66faf3
PE
2063 Make identifiers static if they are not used in other modules.
2064 * data.c (Qcompiled_function, Qframe, Qvector):
2065 * image.c (QimageMagick, Qsvg):
2066 * minibuf.c (Qmetadata):
2067 * window.c (resize_window_check, resize_root_window): Now static.
2068 * window.h (resize_window_check, resize_root_window): Remove decls.
2069
109e28d0
PE
2070 * window.c (window_deletion_count, delete_deletable_window):
2071 Remove; unused.
46a4ce9e
PE
2072 (window_body_lines): Now static.
2073 (Fdelete_other_windows_internal): Mark vars as initialized.
2074 Make sure 'resize_failed' is initialized.
2075 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2076 (resize_window_apply): Remove unused local.
2077 * window.h (delete_deletable_window): Remove decl.
2078
109e28d0 2079 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2080 (imagemagick_load_image): Fix pointer signedness problem by changing
2081 last arg from unsigned char * to char *. All uses changed.
2082 Also, fix a local for similar reasons.
2083 Remove unused locals. Remove locals to avoid shadowing.
2084 (fn_rsvg_handle_free): Remove; unused.
2085 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2086 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2087
3f754b86
PE
2088 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2089
2547adb1
CY
20902011-06-10 Chong Yidong <cyd@stupidchicken.com>
2091
2092 * image.c (gif_load): Fix omitted cast error introduced by
2093 2011-06-06 change.
2094
2c8e37d4
MR
20952011-06-10 Martin Rudalics <rudalics@gmx.at>
2096
2097 * window.h (resize_proportionally, orig_total_lines)
2098 (orig_top_line): Remove from window structure.
2099 (set_window_height, set_window_width, change_window_heights)
2100 (Fdelete_window): Remove prototypes.
2101 (resize_frame_windows): Remove duplicate declaration.
2102
440a42e3
EZ
21032011-06-10 Eli Zaretskii <eliz@gnu.org>
2104
2105 * window.h (resize_frame_windows, resize_window_check)
2106 (delete_deletable_window, resize_root_window)
2107 (resize_frame_windows): Declare prototypes.
2108
2109 * window.c (resize_window_apply): Make definition be "static" to
2110 match the prototype.
2111
562dd5e9
MR
21122011-06-10 Martin Rudalics <rudalics@gmx.at>
2113
2114 * window.c: Remove declarations of Qwindow_size_fixed,
2115 window_min_size_1, window_min_size_2, window_min_size,
2116 size_window, window_fixed_size_p, enlarge_window, delete_window.
2117 Remove static from declaration of Qdelete_window, it's
2118 temporarily needed by Fbury_buffer.
2119 (replace_window): Don't assign orig_top_line and
2120 orig_total_lines.
2121 (Fdelete_window, delete_window): Remove. Window deletion is
2122 handled by window.el.
2123 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2124 Fdelete_window calls with calls to Qdelete_window.
2125 (Fdelete_other_windows): Remove. Deleting other windows is
2126 handled by window.el.
2127 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2128 handled in window.el.
2129 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2130 Window minimum sizes are handled in window.el.
2131 (shrink_windows, size_window, set_window_height)
2132 (set_window_width, change_window_heights, window_height)
2133 (window_width, CURBEG, CURSIZE, enlarge_window)
2134 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2135 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2136 handled in window.el.
2137 (make_dummy_parent): Rename to make_parent_window and give it a
2138 second argument horflag.
2139 (make_window): Don't set resize_proportionally any more.
2140 (Fsplit_window): Remove. Windows are split in window.el.
2141 (save_restore_action, save_restore_orig_size)
2142 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2143 Resize mini windows in window.el.
2144 (grow_mini_window, shrink_mini_window): Implement by calling
2145 Qresize_root_window_vertically, resize_window_check and
2146 resize_window_apply.
2147 (saved_window, Fset_window_configuration, save_window_save): Do
2148 not handle orig_top_line, orig_total_lines, and
2149 resize_proportionally.
2150 (window_min_height, window_min_width): Move to window.el.
2151 (keys_of_window): Move bindings for delete-other-windows,
2152 split-window, delete-window and enlarge-window to window.el.
2153
2154 * buffer.c: Temporarily extern Qdelete_window.
2155 (Fbury_buffer): Temporarily call Qdelete_window instead of
2156 Fdelete_window (Fbury_buffer will move to window.el soon).
2157
2158 * frame.c (set_menu_bar_lines_1): Remove code handling
2159 orig_top_line and orig_total_lines.
2160
2161 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2162 set_window_height but set heights directly.
2163 (change_frame_size_1): Use resize_frame_windows.
2164
2165 * xdisp.c (init_xdisp): Don't use set_window_height but set
2166 heights directly.
2167
2168 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2169 resize_frame_windows instead of change_window_heights and run
2170 run_window_configuration_change_hook.
2171
2172 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2173 instead of change_window_heights and run
2174 run_window_configuration_change_hook.
2175
1a13852e
MR
21762011-06-09 Martin Rudalics <rudalics@gmx.at>
2177
2178 * window.c (replace_window): Rename second argument REPLACEMENT to
2179 NEW. New third argument SETFLAG. Rewrite.
2180 (delete_window, make_dummy_parent): Call replace_window with
2181 third argument 1.
2182 (window_list_1): Move down in code.
2183 (run_window_configuration_change_hook): Move set_buffer part
2184 before select_frame_norecord part in order to unwind correctly.
2185 Rename count1 to count.
2186 (recombine_windows, delete_deletable_window, resize_root_window)
2187 (Fdelete_other_windows_internal)
2188 (Frun_window_configuration_change_hook, make_parent_window)
2189 (resize_window_check, resize_window_apply, Fresize_window_apply)
2190 (resize_frame_windows, Fsplit_window_internal)
2191 (Fdelete_window_internal, Fresize_mini_window_internal): New
2192 functions.
2193 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2194
f3d1777e
MR
21952011-06-08 Martin Rudalics <rudalics@gmx.at>
2196
496e208e
MR
2197 * window.h (window): Add some new members to window structure -
2198 normal_lines, normal_cols, new_total, new_normal, clone_number,
2199 splits, nest, prev_buffers, next_buffers.
2200 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2201 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2202
f3d1777e
MR
2203 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2204 Remove.
496e208e
MR
2205 (make_dummy_parent): Set new members of windows structure.
2206 (make_window): Move down in code. Handle new members of window
2207 structure.
2208 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2209 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2210 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2211 (Fset_window_prev_buffers, Fwindow_next_buffers)
2212 (Fset_window_next_buffers, Fset_window_clone_number): New
2213 functions.
2214 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2215 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2216 Doc-string fixes.
2217 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2218 Argument WINDOW can be now internal window too.
2219 (Fwindow_use_time): Move up in code.
2220 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2221 Rewrite doc-string.
2222 (Fset_window_configuration, saved_window)
2223 (Fcurrent_window_configuration, save_window_save): Handle new
2224 members of window structure.
b9e809c2
MR
2225 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2226 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2227 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2228 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2229 Qget_mru_window, Qresize_root_window,
2230 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2231 Qauto_buffer_name; staticpro them.
f3d1777e 2232
abde8f8c
MR
22332011-06-07 Martin Rudalics <rudalics@gmx.at>
2234
2235 * window.c (Fwindow_total_size, Fwindow_left_column)
2236 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2237 (Fwindow_list_1): New functions.
2238 (window_box_text_cols): Replace with window_body_cols.
2239 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2240 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2241 (delete_window, Fset_window_configuration): Call
2242 delete_all_subwindows with window as argument.
2243 (delete_all_subwindows): Take a window as argument and not a
2244 structure. Rewrite.
190b47e6
MR
2245 (window_loop): Remove handling of GET_LRU_WINDOW and
2246 GET_LARGEST_WINDOW.
2247 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2248
2249 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2250 window_box_text_cols. delete_all_subwindows now takes a
2251 Lisp_Object as argument.
abde8f8c
MR
2252
2253 * indent.c (compute_motion, Fcompute_motion): Use
2254 window_body_cols instead of window_box_text_cols.
2255
fa8a67e6
MR
2256 * frame.c (delete_frame): Call delete_all_subwindows with root
2257 window as argument.
2258
a54e3482
DC
22592011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2260
2261 * fns.c (Fputhash): Document return value.
2262
60002bf5
CY
22632011-06-06 Chong Yidong <cyd@stupidchicken.com>
2264
2265 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2266
0c671da6 22672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2268
b862a52a 2269 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2270
be44ca6c
PE
2271 Check for overflow when converting integer to cons and back.
2272 * charset.c (Fdefine_charset_internal, Fdecode_char):
2273 Use cons_to_unsigned to catch overflow.
2274 (Fencode_char): Use INTEGER_TO_CONS.
2275 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2276 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2277 * data.c (long_to_cons, cons_to_long): Remove.
2278 (cons_to_unsigned, cons_to_signed): New functions.
2279 These signal an error for invalid or out-of-range values.
2280 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2281 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2282 * font.c (Ffont_variation_glyphs):
2283 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2284 * lisp.h: Include <intprops.h>.
2285 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2286 (cons_to_signed, cons_to_unsigned): New decls.
2287 (long_to_cons, cons_to_long): Remove decls.
2288 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2289 (Fprimitive_undo): Use CONS_TO_INTEGER.
2290 * xfns.c (Fx_window_property): Likewise.
2291 * xselect.c: Include <limits.h>.
2292 (x_own_selection, selection_data_to_lisp_data):
2293 Use INTEGER_TO_CONS.
2294 (x_handle_selection_request, x_handle_selection_clear)
2295 (x_get_foreign_selection, Fx_disown_selection_internal)
2296 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2297 (lisp_data_to_selection_data): Use cons_to_unsigned.
2298 (x_fill_property_data): Use cons_to_signed.
2299 Report values out of range.
2300
d1f3d2af
PE
2301 Check for buffer and string overflow more precisely.
2302 * buffer.h (BUF_BYTES_MAX): New macro.
2303 * lisp.h (STRING_BYTES_MAX): New macro.
2304 * alloc.c (Fmake_string):
2305 * character.c (string_escape_byte8):
2306 * coding.c (coding_alloc_by_realloc):
2307 * doprnt.c (doprnt):
2308 * editfns.c (Fformat):
2309 * eval.c (verror):
2310 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2311 since they may not be the same number.
2312 * editfns.c (Finsert_char):
2313 * fileio.c (Finsert_file_contents):
2314 Likewise for BUF_BYTES_MAX.
2315
dd52fcea
PE
2316 * image.c: Use ptrdiff_t, not int, for sizes.
2317 (slurp_file): Switch from int to ptrdiff_t.
2318 All uses changed.
2319 (slurp_file): Check that file size fits in both size_t (for
2320 malloc) and ptrdiff_t (for sanity and safety).
2321
7f9bbdbb
PE
2322 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2323 if b->modtime has its maximal value.
2324
dfe18f82
PE
2325 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2326
84acfcf0
PE
2327 Don't assume time_t can fit into int.
2328 * buffer.h (struct buffer.modtime): Now time_t, not int.
2329 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2330 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2331
ccd9a01a
PE
2332 Minor fixes for signed vs unsigned integers.
2333 * character.h (MAYBE_UNIFY_CHAR):
2334 * charset.c (maybe_unify_char):
2335 * keyboard.c (read_char, reorder_modifiers):
2336 XINT -> XFASTINT, since the integer must be nonnegative.
2337 * ftfont.c (ftfont_spec_pattern):
2338 * keymap.c (access_keymap, silly_event_symbol_error):
2339 XUINT -> XFASTINT, since the integer must be nonnegative.
2340 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2341 since it makes no difference and we prefer signed.
2342 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2343 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2344 nonnegative.
2345
d6d100dd
SM
23462011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2347
2348 * window.h (Fwindow_frame): Declare.
2349
2b6148e4
PE
23502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2351
2352 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2353 (SPARE_MEMORY): Always define.
2354 (LARGE_REQUEST): Remove.
2355 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2356
f230ecc9
MR
23572011-06-06 Martin Rudalics <rudalics@gmx.at>
2358
727e958e
MR
2359 * lisp.h: Move EXFUNS for Fframe_root_window,
2360 Fframe_first_window and Fset_frame_selected_window to window.h.
2361
2362 * window.h: Move EXFUNS for Fframe_root_window,
2363 Fframe_first_window and Fset_frame_selected_window here from
2364 lisp.h.
2365
2366 * frame.c (Fwindow_frame, Fframe_first_window)
2367 (Fframe_root_window, Fframe_selected_window)
2368 (Fset_frame_selected_window): Move to window.c.
2369 (Factive_minibuffer_window): Move to minibuf.c.
2370 (Fother_visible_frames_p): New function.
2371
2372 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2373
f230ecc9
MR
2374 * window.c (decode_window, decode_any_window): Move up in code.
2375 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2376 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2377 (Fwindow_buffer): Move up and rewrite doc-string.
2378 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2379 (Fwindow_prev): New functions.
727e958e
MR
2380 (Fwindow_frame): Move here from frame.c. Accept any window as
2381 argument.
2382 (Fframe_root_window, Fframe_first_window)
2383 (Fframe_selected_window): Move here from frame.c. Accept frame
2384 or arbitrary window as argument. Update doc-strings.
2385 (Fminibuffer_window): Move up in code.
2386 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2387 (Fset_frame_selected_window): Move here from frame.c.
2388 Marginal rewrite.
727e958e
MR
2389 (Fselected_window, select_window, Fselect_window): Move up in
2390 code. Minor doc-string fixes.
f230ecc9 2391
4d09bcf6
PE
23922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2393
2394 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2395 Do not assume that spare memory exists; that assumption is valid
2396 only if SYSTEM_MALLOC.
2397 (LARGE_REQUEST): New macro, so that the issue of large requests
2398 is separated from the issue of spare memory.
2399
810928a2
AS
24002011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2401
172418ad
AS
2402 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2403 format. (Bug#8806)
2404
43f862f7
AS
2405 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2406
810928a2
AS
2407 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2408 before statements.
2409
a059fe24
JD
24102011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2411
2412 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2413
2414 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2415
2416 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2417 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2418
989bf368
JB
24192011-06-05 Juanma Barranquero <lekktu@gmail.com>
2420
2421 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2422
4b80f674
CY
24232011-06-04 Chong Yidong <cyd@stupidchicken.com>
2424
2425 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2426 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2427 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2428 New error handlers.
4b80f674
CY
2429 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2430 Obey Vx_select_enable_clipboard_manager. Catch errors in
2431 x_clipboard_manager_save (Bug#8779).
2432 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2433 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2434
99a33b77 24352011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2436
2437 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2438
99a33b77 24392011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2440
2441 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2442 in the current matrix if keep_current_p is non-zero.
2443
8264569d
EZ
24442011-06-04 Eli Zaretskii <eliz@gnu.org>
2445
2446 * bidi.c (bidi_level_of_next_char): Fix last change.
2447
57f97249
EZ
24482011-06-03 Eli Zaretskii <eliz@gnu.org>
2449
fec2107c 2450 Support bidi reordering of text covered by display properties.
57f97249 2451
fec2107c
EZ
2452 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2453 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2454 (bidi_cache_search, bidi_cache_iterator_state)
2455 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2456 (bidi_level_of_next_char, bidi_move_to_visually_next):
2457 Support character positions inside a run of characters covered by a
fec2107c
EZ
2458 display string.
2459 (bidi_paragraph_init, bidi_resolve_explicit_1)
2460 (bidi_level_of_next_char): Call bidi_fetch_char and
2461 bidi_fetch_char_advance instead of FETCH_CHAR and
2462 FETCH_CHAR_ADVANCE.
2463 (bidi_init_it): Initialize new members.
2464 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2465 definitions.
2466 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2467 instead of using explicit *_CHAR codes.
d6d100dd
SM
2468 (bidi_resolve_explicit, bidi_resolve_weak):
2469 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2470 bidirectional text is supported only in multibyte buffers.
2471 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2472 it to initialize the frame_window_p member of struct bidi_it.
2473 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2474 (bidi_resolve_explicit, bidi_resolve_weak)
2475 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2476 bidi_it->nchars is non-positive.
2477 (bidi_level_of_next_char): Don't try to lookup the cache for the
2478 next/previous character if nothing is cached there yet, or if we
2479 were just reseat()'ed to a new position.
c40e2fb2 2480
0e14fe90
EZ
2481 * xdisp.c (set_cursor_from_row): Set start and stop points
2482 according to the row's direction when priming the loop that looks
2483 for the glyph on which to display cursor.
2484 (single_display_spec_intangible_p): Function deleted.
2485 (display_prop_intangible_p): Reimplement to call
2486 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2487 Accept 3 additional arguments needed by handle_display_spec.
2488 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2489 values: lists, `(when COND...)' forms, etc.
2490 (single_display_spec_string_p): Support property values that are
2491 lists with the argument STRING its top-level element.
2492 (display_prop_string_p): Fix the condition for processing a
2493 property that is a list to be consistent with handle_display_spec.
fec2107c 2494 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2495 last portion of handle_display_prop.
2496 (compute_display_string_pos): Accept additional argument
2497 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2498 value of a `display' property is a "replacing spec".
2499 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2500 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2501 the display property, but just return a value indicating whether
2502 the display property will replace the characters it covers.
2503 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2504 frame_window_p members of struct bidi_it.
d6d100dd
SM
2505 (compute_display_string_pos, compute_display_string_end):
2506 New functions.
fec2107c
EZ
2507 (push_it): Accept second argument POSITION, where pop_it should
2508 jump to continue iteration.
2509 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2510
fec2107c
EZ
2511 * keyboard.c (adjust_point_for_property): Adjust the call to
2512 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2513
2514 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2515 (bidi_init_it): Update prototypes.
2516 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2517 (compute_display_string_pos, compute_display_string_end):
2518 Declare prototypes.
fec2107c
EZ
2519 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2520 EMACS_INT.
fc6f18ce 2521
40087514 25222011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2523
57f53182
PE
2524 Malloc failure behavior now depends on size of allocation.
2525 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2526 * lisp.h: Change signatures accordingly.
2527 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2528 All callers changed. (Bug#8762)
2529
2530 * gnutls.c: Use Emacs's memory allocators.
2531 Without this change, the gnutls library would invoke malloc etc.
2532 directly, which causes problems on non-SYNC_INPUT hosts, and which
2533 runs afoul of improving memory_full behavior. (Bug#8761)
2534 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2535 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2536 xfree instead of the default malloc, realloc, free.
2537 (Fgnutls_boot): No need to check for memory allocation failure,
2538 since xmalloc does that for us.
2539
ac32cd99 2540 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2541 * category.c (hash_get_category_set):
2542 * ccl.c (ccl_driver):
2543 * charset.c (Fdefine_charset_internal):
2544 * charset.h (struct charset.hash_index):
2545 * composite.c (get_composition_id, gstring_lookup_cache)
2546 (composition_gstring_put_cache):
2547 * composite.h (struct composition.hash_index):
2548 * dispextern.h (struct image.hash):
2549 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2550 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2551 (hashfn_equal, hashfn_user_defined, make_hash_table)
2552 (maybe_resize_hash_table, hash_lookup, hash_put)
2553 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2554 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2555 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2556 * image.c (make_image, search_image_cache, lookup_image)
2557 (xpm_put_color_table_h):
2558 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2559 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2560 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2561 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2562 * alloc.c (allocate_vectorlike):
2563 Check for overflow in vector size calculations.
2564 * ccl.c (ccl_driver):
2565 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2566 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2567 need to be updated by these changes.
40087514
PE
2568 * fns.c (make_hash_table, maybe_resize_hash_table):
2569 Check for integer overflow with large hash tables.
0de4bb68
PE
2570 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2571 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2572 (SXHASH_REDUCE): New macro.
2573 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2574 Use it instead of discarding useful hash info with large hash values.
2575 (sxhash_float): New function.
2576 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2577 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2578 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2579 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2580 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2581 Adjust signatures to match updated version of code.
2582 (consing_since_gc): Now EMACS_INT, since a single hash table can
2583 use more than INT_MAX bytes.
2584
698d32e2
DN
25852011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2586
2587 Make it possible to build with GCC-4.6+ -O2 -flto.
2588
2589 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2590
fd6fa53f
SM
25912011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2592
2593 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2594 Call minibuffer-inactive-mode.
2595
864db017
JB
25962011-05-31 Juanma Barranquero <lekktu@gmail.com>
2597
2598 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2599 Update dependencies.
2600
2ad0baf4
DN
26012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2602
2603 * data.c (init_data): Remove code for UTS, this system is not
2604 supported anymore.
2605
4fcc2638
DN
26062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2607
2608 Don't force ./temacs to start in terminal mode.
2609
2610 * frame.c (make_initial_frame): Initialize faces in all cases, not
2611 only when CANNOT_DUMP is defined.
2612 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2613
c56e0fd5
DN
26142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2615
2616 * dispnew.c (add_window_display_history): Use const for the string
2617 pointer. Remove declaration, not needed.
2618
333d54da 26192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2620
55d4c1b2 2621 Use 'inline', not 'INLINE'.
333d54da 2622 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2623 * alloc.c, fontset.c (INLINE): Remove.
2624 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2625 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2626 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2627 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2628 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2629
738db178
DN
26302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2631
2632 Make it possible to run ./temacs.
2633
2634 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2635 syms_of_callproc does the same thing. Remove test for
2636 "initialized", do it in the caller.
2637 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2638
620c53a6
SM
26392011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2640
2641 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2642 (read_minibuf): Use get_minibuffer.
2643 (syms_of_minibuf): Use DEFSYM.
2644 (Qmetadata): New var.
2645 * data.c (Qbuffer): Don't make it static.
2646 (syms_of_data): Use DEFSYM.
2647
e003a292
PE
26482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2649
2650 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2651 (CCL_CODE_MIN): New macro.
2652
ed008a6d
PE
26532011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2654
3687c2ef
PE
2655 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2656
ed008a6d
PE
2657 * eval.c (Qdebug): Now static.
2658 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2659 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2660 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2661
d66c4c7c
CY
26622011-05-29 Chong Yidong <cyd@stupidchicken.com>
2663
2664 * image.c: Various fixes to ImageMagick code comments.
2665 (Fimagemagick_types): Doc fix.
2666
5fbc2025
PE
26672011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2668
0196f88a
PE
2669 Minor fixes prompted by GCC 4.6.0 warnings.
2670
2671 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2672
5fbc2025
PE
2673 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2674 (x_clipboard_manager_save_all): Move extern decl to ...
2675 * xterm.h: ... here, so that it can be checked for consistency.
2676
1dd3c2d9
CY
26772011-05-29 Chong Yidong <cyd@stupidchicken.com>
2678
2679 * xselect.c (x_clipboard_manager_save_frame)
2680 (x_clipboard_manager_save_all): New functions.
2681 (Fx_clipboard_manager_save): Lisp function deleted.
2682
2683 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2684 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2685
2686 * xterm.h: Update prototype.
2687
5ba6571d
WX
26882011-05-28 William Xu <william.xwl@gmail.com>
2689
2690 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2691 exiting (Bug#8239).
2692
3eaff834
JM
26932011-05-28 Jim Meyering <meyering@redhat.com>
2694
e1900994 2695 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2696 * fns.c (to_uchar): Define.
2697 (crypto_hash_function): Use it to convert some newly-signed
2698 variables to unsigned, to avoid sign-extension bugs. For example,
2699 without this change, (md5 "truc") would evaluate to
2700 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2701 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2702 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2703
0f6990a7
PE
27042011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2705
2706 Integer overflow fixes.
c8a9ca5a 2707
08686060
PE
2708 * dbusbind.c: Serial number integer overflow fixes.
2709 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2710 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2711 to hold a serial number that is too large for a fixnum.
2712 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2713 Check for serial numbers out of range. Decode any serial number
59568bf0 2714 that was so large that it became a float. (Bug#8722)
08686060 2715
2d1fc3c7
PE
2716 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2717 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2718 Use XFASTINT rather than XUINT when numbers are nonnegative.
2719 (xd_append_arg, Fdbus_method_return_internal):
2720 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2721 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2722 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2723 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2724 (Bug#8722)
2d1fc3c7 2725
c8a9ca5a
PE
2726 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2727
519e1d69
PE
2728 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2729
30569699
PE
2730 ccl: add integer overflow checks
2731 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2732 (IN_INT_RANGE): New macros.
2733 (ccl_driver): Use them to check for integer overflow when
2734 decoding a CCL program. Many of the new checks are whether XINT (x)
2735 fits in int; it doesn't always, on 64-bit hosts. The new version
2736 doesn't catch all possible integer overflows, but it's an
847044ea 2737 improvement. (Bug#8719)
30569699 2738
c11285dc
PE
2739 * alloc.c (make_event_array): Use XINT, not XUINT.
2740 There's no need for unsigned here.
2741
fdccd48e
PE
2742 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2743 This follows up to the 2011-05-06 change that substituted uintptr_t
2744 for EMACS_INT. This case wasn't caught back then.
2745
37910ab2
PE
2746 Rework Fformat to avoid integer overflow issues.
2747 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2748 now (part of C89). Include <verify.h>.
2749 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2750 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2751 (Fformat): Avoid the prepass trying to compute sizes; it was only
2752 approximate and thus did not catch overflow reliably. Instead, walk
2753 through the format just once, formatting and computing sizes as we go,
2754 checking for integer overflow at every step, and allocating a larger
2755 buffer as needed. Keep track separately whether the format is
2756 multibyte. Keep only the most-recently calculated precision, rather
2757 than them all. Record whether each argument has been converted to
2758 string. Use EMACS_INT, not int, for byte and char and arg counts.
2759 Support field widths and precisions larger than INT_MAX. Avoid
2760 sprintf's undefined behavior with conversion specifications such as %#d
2761 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2762 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2763 formatting out-of-range floating point numbers with int
9173deec 2764 formats. (Bug#8668)
37910ab2 2765
2e6578fb
PE
2766 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2767
0ae6bdee
PE
2768 * data.c: Avoid integer truncation in expressions involving floats.
2769 * data.c: Include <intprops.h>.
2770 (arith_driver): When there's an integer overflow in an expression
2771 involving floating point, convert the integers to floating point
2772 so that the resulting value does not suffer from catastrophic
2773 integer truncation. For example, on a 64-bit host (* 4
2774 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2775 Do not rely on undefined behavior after integer overflow.
2776
de883a70
PE
2777 merge count_size_as_multibyte, parse_str_to_multibyte
2778 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2779 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2780 Check for integer overflow.
2781 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2782 since it's now a duplicate of the other. This is more of
2783 a character than a buffer op, so better that it's in character.c.
2784 * fns.c, print.c: Adjust to above changes.
2785
2ff916cb
PE
27862011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2787
2788 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2789
f1b54466
PE
27902011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2791
fb1ac845
PE
2792 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2793 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2794 (x_clipboard_manager_save): Now static.
2795 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2796
f1b54466
PE
2797 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2798 (crypto_hash_function): Now static.
2799 Fix pointer signedness problems. Avoid unnecessary initializations.
2800
a9f737ee
CY
28012011-05-27 Chong Yidong <cyd@stupidchicken.com>
2802
2803 * termhooks.h (Vselection_alist): Make it terminal-local.
2804
2805 * terminal.c (create_terminal): Initialize it.
2806
2807 * xselect.c: Support for clipboard managers.
2808 (Vselection_alist): Move to termhooks.h as terminal-local var.
2809 (LOCAL_SELECTION): New macro.
2810 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2811 (symbol_to_x_atom): Remove gratuitous arg.
2812 (x_handle_selection_request, lisp_data_to_selection_data)
2813 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2814 (x_own_selection, x_get_local_selection, x_convert_selection):
2815 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2816 (some_frame_on_display): Delete unused function.
2817 (Fx_own_selection_internal, Fx_get_selection_internal)
2818 (Fx_disown_selection_internal, Fx_selection_owner_p)
2819 (Fx_selection_exists_p): New optional frame arg.
2820 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2821 (x_handle_selection_clear): Don't treat other terminals with the
2822 same keyboard specially. Use the terminal-local Vselection_alist.
2823 (x_clear_frame_selections): Use Frun_hook_with_args.
2824
2825 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2826
2827 * xterm.h: Add support for those atoms.
2828
e067f0c1
CY
28292011-05-26 Chong Yidong <cyd@stupidchicken.com>
2830
2831 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2832 (converted_selections, conversion_fail_tag): New global variables.
2833 (x_selection_request_lisp_error): Free the above.
2834 (x_get_local_selection): Remove unnecessary code.
2835 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2836 of converted selections stored in converted_selections.
2837 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2838 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2839 (x_convert_selection): New function.
2840 (x_handle_selection_event): Simplify.
2841 (x_get_foreign_selection): Don't ignore incoming requests while
2842 waiting for an answer; this will fail when we implement
2843 SAVE_TARGETS, and seems unnecessary anyway.
2844 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2845 (Vx_sent_selection_functions): Doc fix.
2846
0f4aebc0
LL
28472011-05-26 Leo Liu <sdl.web@gmail.com>
2848
2849 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2850
e61124cd
YM
28512011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2852
2853 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2854
2855 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2856 for fringe update if it has periodic bitmap.
ac389d0c 2857 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2858 and fringe_bitmap_periodic_p.
2859
2860 * fringe.c (get_fringe_bitmap_data): New function.
2861 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2862 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2863 row. Mark glyph row for fringe update if periodicity changed.
2864
2865 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2866 for fringe update unless it has periodic bitmap.
2867
f16d9837
KH
28682011-05-25 Kenichi Handa <handa@m17n.org>
2869
2870 * xdisp.c (get_next_display_element): Set correct it->face_id for
2871 a static composition.
2872
e1b90ef6
LL
28732011-05-24 Leo Liu <sdl.web@gmail.com>
2874
2875 * deps.mk (fns.o):
2876 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2877
2878 * fns.c (crypto_hash_function, Fsha1): New function.
2879 (Fmd5): Use crypto_hash_function.
2880 (syms_of_fns): Add Ssha1.
2881
7400048f
PE
28822011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2883
2884 * gnutls.c: Remove unused macros.
2885 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2886 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2887 Remove macros that are defined and never used.
2888 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2889
abb71cf4
CY
28902011-05-22 Chong Yidong <cyd@stupidchicken.com>
2891
2892 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2893 (Fx_get_selection_internal): Minor cleanup.
2894 (Fx_own_selection_internal): Rename arguments for consistency with
2895 select.el.
2896
6307db39
PE
28972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2898
2899 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2900
f3d4e0a4
CY
29012011-05-22 Chong Yidong <cyd@stupidchicken.com>
2902
2903 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2904
4d8ade89
YM
29052011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2906
2907 * dispnew.c (scrolling_window): Don't exclude the case that the
2908 last enabled row in the desired matrix touches the bottom boundary.
2909
32078c8d
GM
29102011-05-21 Glenn Morris <rgm@gnu.org>
2911
2912 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2913 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2914 and add some more files.
32078c8d 2915
7285dc67
EZ
29162011-05-20 Eli Zaretskii <eliz@gnu.org>
2917
2918 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2919 report_file_error introduced by the change from 2011-05-07.
2920
89d1bd22
PE
29212011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2922
2923 * systime.h (Time): Define only if emacs is defined.
2924 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2925 where the include path doesn't have X11/X.h by default. See
2926 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2927
e23640bb 29282011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2929
2930 * composite.c (find_automatic_composition): Fix previous change.
2931
b9704ad9
GM
29322011-05-20 Glenn Morris <rgm@gnu.org>
2933
2934 * lisp.mk: New file, split from Makefile.in.
2935 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2936 (shortlisp): Remove.
2937 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2938
4a720484
GM
29392011-05-19 Glenn Morris <rgm@gnu.org>
2940
2941 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2942 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2943 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2944 (lisp): Set the order to that of loadup.el.
2945 (shortlisp): Make it a copy of $lisp.
2946 (SOME_MACHINE_LISP): Remove.
2947 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2948 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2949
a28d4396
KH
29502011-05-18 Kenichi Handa <handa@m17n.org>
2951
2952 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2953 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2954 (find_automatic_composition): Mostly rewrite for efficiency.
2955
a2b1fa8e
JB
29562011-05-18 Juanma Barranquero <lekktu@gmail.com>
2957
2958 * makefile.w32-in: Update dependencies.
2959
8e1f5610
CS
29602011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2961
2962 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2963 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2964
7025ee00 29652011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2966
cdfa6eab
PE
2967 Fix some integer overflow issues, such as string length overflow.
2968
06d6db33
PE
2969 * insdel.c (count_size_as_multibyte): Check for string overflow.
2970
2b4560a8
PE
2971 * character.c (lisp_string_width): Check for string overflow.
2972 Use EMACS_INT, not int, for string indexes and lengths; in
2973 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2974 the resulting string length overflows an EMACS_INT; instead,
2975 report a string overflow if no precision given. When checking for
2976 precision exhaustion, use a check that cannot possibly have
2977 integer overflow. (Bug#8675)
2978 * character.h (lisp_string_width): Adjust to new signature.
2979
cb93f9be
PE
2980 * alloc.c (string_overflow): New function.
2981 (Fmake_string): Use it. This doesn't change behavior, but saves
2982 a few bytes and will simplify future changes.
2983 * character.c (string_escape_byte8): Likewise.
2984 * lisp.h (string_overflow): New decl.
2985
1a1f3366
PE
2986 Fixups, following up to the user-interface timestamp change.
2987 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2988 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2989 * msdos.c (mouse_get_pos): Likewise.
2990 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2991 * w32gui.h (Time): Define by including "systime.h" rather than by
2992 declaring it ourselves. (Bug#8664)
2993
d4e3e4d3
PE
2994 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2995 * image.c (clear_image_cache): Likewise.
2996
f6a24d19
PE
2997 * term.c (term_mouse_position): Don't assume time_t wraparound.
2998
08dc5ae6
PE
2999 Be more systematic about user-interface timestamps.
3000 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3001 and sometimes 'EMACS_UINT', to represent these timestamps.
3002 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3003 This makes the code easier to follow, and makes it easier to catch
3004 integer overflow bugs such as Bug#8664.
3005 * frame.c (Fmouse_position, Fmouse_pixel_position):
3006 Use Time, not unsigned long, for user-interface timestamps.
3007 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3008 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3009 * keyboard.h (last_event_timestamp): Likewise.
3010 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3011 * menu.h (xmenu_show): Likewise.
3012 * term.c (term_mouse_position): Likewise.
3013 * termhooks.h (struct input_event.timestamp): Likewise.
3014 (struct terminal.mouse_position_hook): Likewise.
3015 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3016 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3017 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3018 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3019 what it was before.
3020 * menu.h, termhooks.h: Include "systime.h", for Time.
3021
8e55734a
PE
3022 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3023 Don't assume that the difference between two unsigned long values
3024 can fit into an integer. At this point, we know button_down_time
3025 <= event->timestamp, so the difference must be nonnegative, so
3026 there's no need to cast the result if double-click-time is
3027 nonnegative, as it should be; check that it's nonnegative, just in
3028 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3029 apart (about 25 days). (Bug#8664)
8e55734a 3030
841f1b75 3031 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3032 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3033
3e26f69c
PE
3034 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3035 that always fit in int. Use a sentinel instead of a counter, to
3036 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3037 * frame.h (struct frame): Use int for menu_bar_items_used
3038 instead of EMACS_INT, since it always fits in int.
3e26f69c 3039
5cc152c0
PE
3040 * menu.c (grow_menu_items): Check for int overflow.
3041
d89eb65e
PE
3042 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3043
5235bd3e
PE
3044 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3045 Before, the code was not consistent. These values cannot exceed
3046 2**31 - 1 so there's no need to make them unsigned.
3047 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3048 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3049 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3050 as modifiers.
3051 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3052
bc827e23
PE
3053 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3054 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3055 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3056 presumably because the widths might not match.
3057
78eb494e
PE
3058 * window.c (size_window): Avoid needless test at loop start.
3059
04f2d78b
CB
30602011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3061
3062 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3063
d2fc7e3d 30642011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3065
3066 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3067
d2fc7e3d 30682011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3069
3070 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3071 `width' to `bar_area_x' and `bar_area_width', respectively.
3072 (x_scroll_run): Take account of fringe background extension.
3073
04f2d78b
CB
3074 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3075 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3076 `bar_area_width', respectively.
3077 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3078 background extension.
3079
79b70037
GM
30802011-05-10 Jim Meyering <meyering@redhat.com>
3081
3082 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3083
2f142cc5
JB
30842011-05-10 Juanma Barranquero <lekktu@gmail.com>
3085
3086 * image.c (Finit_image_library): Return t for built-in image types,
3087 like pbm and xbm. (Bug#8640)
3088
57679c86
AS
30892011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3090
3091 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3092
888c9e86
EZ
30932011-05-07 Eli Zaretskii <eliz@gnu.org>
3094
b0512a1d
EZ
3095 * w32console.c (Fset_screen_color): Doc fix.
3096 (Fget_screen_color): New function.
3097 (syms_of_ntterm): Defsubr it.
3098
7285dc67
EZ
3099 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3100 unlink the temporary file if Fcall_process didn't create it in the
3101 first place.
3102 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3103 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3104 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3105 cue to call_process_cleanup not to close that handle.
3106
4d3fcc8e
BK
31072011-05-07 Ben Key <bkey76@gmail.com>
3108
3109 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3110 one of two shell specific rules, either bootstrap-temacs-CMD or
3111 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3112 to the previous implementation of the bootstrap-temacs rule.
3113 The bootstrap-temacs-CMD rule is similar to the previous
3114 implementation of the bootstrap-temacs rule except that it
3115 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3116 variable.
3117
3118 These changes, along with some changes to nt/configure.bat,
3119 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3120 earlier fix to add support for --cflags and --ldflags options
3121 that include quotes so that it works whether make uses cmd or
3122 sh as the shell.
3123
b4289b64
MA
31242011-05-06 Michael Albinus <michael.albinus@gmx.de>
3125
3126 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3127 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3128 is a constant.
3129 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3130 a string. Handle both cases.
3131 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3132 (Fdbus_register_method): Use Qinvalid_function.
3133
af4c0e28
JB
31342011-05-06 Juanma Barranquero <lekktu@gmail.com>
3135
3136 * makefile.w32-in: Update dependencies.
3137 (LISP_H): Add inttypes.h and stdin.h.
3138 (PROCESS_H): Add unistd.h.
3139
c51453d9
EZ
31402011-05-06 Eli Zaretskii <eliz@gnu.org>
3141
3142 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3143 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3144
8ff0ac3c 31452011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3146
4c4b566b
PE
3147 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3148
aab2b9b5
PE
3149 * term.c (vfatal): Remove stray call to va_end.
3150 It's not needed and the C Standard doesn't allow it here anyway.
3151
c378da0b
PE
3152 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3153 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3154
288b08c7
PE
3155 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3156 bytes.
3157
e3601888
PE
3158 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3159
db6c0e74
PE
3160 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3161
dd5963ea
PE
3162 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3163
88c9450f
PE
3164 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3165
2f9442b8
PE
3166 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3167
c032b5f8
PE
3168 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3169 * charset.c (Fdefine_charset_internal): Don't initialize
3170 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3171 32-bit int (Bug#8600).
a108c10b
PE
3172
3173 * lread.c (read_integer): Be more consistent with string-to-number.
3174 Use string_to_number to do the actual conversion; this avoids
3175 rounding errors and fixes some other screwups. Without this fix,
3176 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3177 (digit_to_number): Move earlier, for benefit of read_integer.
3178 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3179 not a digit in any supported base. (Bug#8602)
a108c10b 3180
ad5f9eea
PE
3181 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3182
aec1708a
PE
3183 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3184 to match comment at start of function. This also removes a
3185 GCC warning about overflow in a 32+64-bit port.
3186
47be4ab5
PE
3187 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3188
371cac43
PE
3189 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3190 Reported by Stefan Monnier in
3191 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3192 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3193 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3194
d01a7826
PE
3195 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3196 (EMACS_UINTPTR): Likewise, with uintptr_t.
3197
7fd47d5c
PE
3198 * lisp.h: Prefer 64-bit EMACS_INT if available.
3199 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3200 on 32-bit hosts that have 64-bit int, so that they can access
3201 large files.
122b0c86
PE
3202 However, temporarily disable this change unless the temporary
3203 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3204
8727937b
PE
3205 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3206
8ac068ac
PE
3207 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3208 This removes an assumption that EMACS_INT and long are the same
3209 width as pointers. The assumption is true for Emacs porting targets
3210 now, but we want to make other targets possible.
3211 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3212 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3213 In the rest of the code, change types of integers that hold casted
3214 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3215 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3216 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3217 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3218 No need to cast type when ORing.
3219 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3220 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3221 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3222 assume EMACS_INT is the same width as char *.
3223 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3224 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3225 Remove no-longer-needed casts.
3226 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3227 (xg_tool_bar_help_callback, xg_make_tool_item):
3228 Use EMACS_INTPTR to hold an integer
3229 that will be cast to void *; this can avoid a GCC warning
3230 if EMACS_INT is not the same width as void *.
3231 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3232 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3233 (current_message_1, set_message_1):
3234 Use a local to convert to proper width without a cast.
3235 * xmenu.c (dialog_selection_callback): Likewise.
3236
ede49d71
PE
3237 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3238 Also, don't assume VALBITS / RAND_BITS is less than 5,
3239 and don't rely on undefined behavior when shifting a 1 left into
3240 the sign bit.
3241 * lisp.h (get_random): Change signature to match.
3242
2f30ecd0
PE
3243 * lread.c (hash_string): Use size_t, not int, for hash computation.
3244 Normally we prefer signed values; but hashing is special, because
3245 it's better to use unsigned division on hash table sizes so that
3246 the remainder is nonnegative. Also, size_t is the natural width
3247 for hashing into memory. The previous code used 'int', which doesn't
3248 retain enough info to hash well into very large tables.
3249 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3250
2a866e7b
PE
3251 * dbusbind.c: Don't possibly lose pointer info when converting.
3252 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3253 Use XPNTR rather than XHASH, so that the high-order bits of
3254 the pointer aren't lost when converting through void *.
3255
51639eac
PE
3256 * eval.c (Fautoload): Don't double-shift a pointer.
3257
92394119
PE
3258 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3259
dbdb9a7c
JB
32602011-05-06 Juanma Barranquero <lekktu@gmail.com>
3261
3262 * gnutls.c (DEF_GNUTLS_FN):
3263 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3264
db7a0b4f
AS
32652011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3266
3267 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3268 marker. (Bug#8610)
3269
f7ff1b0f 32702011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3271
3272 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3273 New version that can reserve upto 2GB of heap space.
3274
f7ff1b0f 32752011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3276
3277 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3278
639c109b
TZ
32792011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3280
3281 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3282 `gnutls_certificate_set_x509_key_file'.
3283
d2127135
JB
32842011-05-05 Juanma Barranquero <lekktu@gmail.com>
3285
3286 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3287 Update dependencies.
3288
e968f4f3
JB
32892011-05-04 Juanma Barranquero <lekktu@gmail.com>
3290
3291 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3292 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3293 Remove unused parameter `fildes'.
3294 * process.c (read_process_output, send_process): Don't pass it.
3295
84d358f0
JB
32962011-05-04 Juanma Barranquero <lekktu@gmail.com>
3297
3298 Fix previous change: the library cache is defined in w32.c.
3299 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3300 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3301
0898ca10
JB
33022011-05-04 Juanma Barranquero <lekktu@gmail.com>
3303
3304 Implement dynamic loading of GnuTLS on Windows.
3305
3306 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3307 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3308 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3309 Declare.
3310
3311 * gnutls.c (Qgnutls_dll): Define.
3312 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3313 (gnutls_*): Declare function pointers.
3314 (init_gnutls_functions): New function to initialize function pointers.
3315 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3316 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3317 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3318 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3319 (emacs_gnutls_write, emacs_gnutls_read)
3320 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3321 (Fgnutls_available_p): New function.
3322 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3323 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3324 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3325
3326 * image.c: Include w32.h.
3327 (Vimage_type_cache): Delete.
3328 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3329 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3330 (w32_delayed_load): Move to w32.c.
3331
3332 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3333
3334 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3335 (w32_delayed_load): Move from image.c. When loading a library, record
3336 its filename in the :loaded-from property of the library id.
3337 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3338 Initialize and staticpro them.
3339 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3340
3341 * process.c: Include lisp.h before w32.h, not after.
3342 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3343 instead of gnutls_record_check_pending.
3344
3345 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3346
ff4de4aa
TZ
33472011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3348
3349 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3350 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3351 as passed in.
3352
abe95abb
JD
33532011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3354
3355 * xterm.c (x_set_frame_alpha): Do not set property on anything
3356 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3357
e16e55d4
JB
33582011-05-02 Juanma Barranquero <lekktu@gmail.com>
3359
3360 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3361
bafcf6a5
JB
33622011-05-02 Juanma Barranquero <lekktu@gmail.com>
3363
3364 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3365 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3366 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3367 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3368 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3369 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3370 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3371 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3372 (Qgnutls_bootprop_callbacks_verify): Make static.
3373
e7a6747f
AS
33742011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3375
19ed11ba
AS
3376 * callproc.c: Indentation fixup.
3377
e7a6747f 3378 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3379 (wait_for_termination, interruptible_wait_for_termination):
3380 Move after wait_for_termination_1.
e7a6747f 3381
1ef14cb4
LMI
33822011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3383
3384 * sysdep.c (interruptible_wait_for_termination): New function
3385 which is like wait_for_termination, but allows keyboard
3386 interruptions.
3387
3388 * callproc.c (Fcall_process): Add (:file "file") as an option for
3389 the STDOUT buffer.
3390 (Fcall_process_region): Ditto.
3391
330d880c
EZ
33922011-04-30 Eli Zaretskii <eliz@gnu.org>
3393
8db90b73
EZ
3394 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3395 rather than `XVECTOR (FOO)->size'.
3396
330d880c
EZ
3397 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3398 inttypes.h, as a gnulib replacement is used if it not available in
3399 system headers.
3400
15cbd324
EZ
34012011-04-21 Eli Zaretskii <eliz@gnu.org>
3402
3403 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3404 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3405 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3406
3407 * coding.c (coding_alloc_by_realloc): Error out if destination
3408 will grow beyond MOST_POSITIVE_FIXNUM.
3409 (decode_coding_emacs_mule): Abort if there isn't enough place in
3410 charbuf for the composition carryover bytes. Reserve an extra
3411 space for up to 2 characters produced in a loop.
3412 (decode_coding_iso_2022): Abort if there isn't enough place in
3413 charbuf for the composition carryover bytes.
3414
34152011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3416
ae940cca
EZ
3417 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3418 aborting when %lld or %lll format is passed.
3419 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3420 %llo or %llx format is passed. (Bug#8545)
3421
03ab8921
EZ
3422 * window.c (window_scroll_line_based): Use a marker instead of
3423 simple variables to record original value of point. (Bug#7952)
3424
afda1437
EZ
3425 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3426 produced by %s or %c overflows available buffer space. (Bug#8545)
3427
f76dee0c
PE
34282011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3429
3430 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3431 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3432
fdc5744d
JB
34332011-04-28 Juanma Barranquero <lekktu@gmail.com>
3434
3435 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3436
638f053a
JB
34372011-04-28 Juanma Barranquero <lekktu@gmail.com>
3438
3439 * keyboard.c (Qdelayed_warnings_hook): Define.
3440 (command_loop_1): Run `delayed-warnings-hook'
3441 if Vdelayed_warnings_list is non-nil.
3442 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3443 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3444
d178f871
EZ
34452011-04-28 Eli Zaretskii <eliz@gnu.org>
3446
3447 * doprnt.c (doprnt): Don't return value smaller than the buffer
3448 size if the message was truncated. (Bug#8545).
3449
b124fd93
JB
34502011-04-28 Juanma Barranquero <lekktu@gmail.com>
3451
3452 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3453 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3454
e810457d
PE
34552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3456
3457 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3458
ea51cceb
JB
34592011-04-27 Juanma Barranquero <lekktu@gmail.com>
3460
3461 * makefile.w32-in: Update dependencies.
3462
94dcfacf
EZ
34632011-04-27 Eli Zaretskii <eliz@gnu.org>
3464
3465 Improve `doprnt' and its usage. (Bug#8545)
3466 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3467 `format_end'. Remove support for %l as a conversion specifier.
3468 Don't use xrealloc. Improve diagnostics when the %l size modifier
3469 is used. Update the commentary.
3470
3471 * eval.c (verror): Simplify calculation of size_t.
3472
3473 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3474 messages.
3475
f61f41d7
PE
34762011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3477
3478 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3479 change.
3480
96fb4434
PE
34812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3482
3483 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3484 This makes this file independent of the recent pseudovector change.
3485
671875da 34862011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3487
69e9b5a3
PE
3488 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3489
b5f869a7 3490 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3491 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3492 Remove unused local.
c8926152 3493 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3494
841a1577 3495 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3496 GCC 4.6.0 optimizes based on type-based alias analysis.
3497 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3498 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3499 != &v->size, and therefore "v->size = 1; b->size = 2; return
3500 v->size;" must therefore return 1. This assumption is incorrect
3501 for Emacs, since it type-puns struct Lisp_Vector * with many other
3502 types. To fix this problem, this patch adds a new type struct
f904488f 3503 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3504 and pseudovectors, and helps optimizing compilers not get fooled
3505 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3506 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3507 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3508 the size member.
eab3844f
PE
3509 (XSETPVECTYPE): Rewrite in terms of new macro.
3510 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3511 This is a bit clearer, and further avoids the possibility of
3512 undesirable aliasing.
3513 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3514 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3515 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3516 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3517 (ASIZE): Now uses header.size rather than size.
3518 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3519 to avoid the hassle of writing XVECTOR (foo)->header.size.
3520 (struct vectorlike_header): New type.
eab3844f
PE
3521 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3522 object, to help avoid aliasing.
3523 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3524 (SUBRP): Likewise, since Lisp_Subr is a special case.
3525 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3526 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3527 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3528 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3529 changed to be "header.size" and "header.next".
3530 * buffer.h (struct buffer): Likewise.
3531 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3532 * frame.h (struct frame): Likewise.
3533 * process.h (struct Lisp_Process): Likewise.
3534 * termhooks.h (struct terminal): Likewise.
3535 * window.c (struct save_window_data, struct saved_window): Likewise.
3536 * window.h (struct window): Likewise.
3537 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3538 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3539 * buffer.c (init_buffer_once): Likewise.
3540 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3541 special case.
3542 * process.c (Fformat_network_address): Use local var for size,
3543 for brevity.
3544
0df1eac5
PE
3545 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3546
847ab9d1 3547 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3548 * data.c (atof): Remove decl; no longer used or needed.
3549 (digit_to_number): Move to lread.c.
3550 (Fstring_to_number): Use new string_to_number function, to be
3551 consistent with how the Lisp reader treats infinities and NaNs.
3552 Do not assume that floating-point numbers represent EMACS_INT
3553 without losing information; this is not true on most 64-bit hosts.
3554 Avoid double-rounding errors, by insisting on integers when
3555 parsing non-base-10 numbers, as the documentation specifies.
3556 * lisp.h (string_to_number): New decl, replacing ...
3557 (isfloat_string): Remove.
bc0a5c13 3558 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3559 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3560 appears to have been a coding error. Similarly, do not accept
3561 strings like +-1e0 as floating point numbers. Do not report
3562 overflow for integer overflows unless the base is not 10 which
3563 means we have no simple and reliable way to continue.
3564 Break out the floating-point parsing into a new
3565 function string_to_number, so that Fstring_to_number parses
3566 floating point numbers consistently with the Lisp reader.
04f2d78b 3567 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3568 (E_CHAR, EXP_INT): Remove, replacing with ...
3569 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3570 (string_to_number): New function, replacing isfloat_string.
3571 This function checks for valid syntax and produces the resulting
3572 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3573 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3574 so that overflow for non-base-10 numbers is reported only when
3575 there's no portable and simple way to convert to floating point.
452f4150 3576
67769ffc
PE
3577 * textprop.c (set_text_properties_1): Rewrite for clarity,
3578 and to avoid GCC warning about integer overflow.
3579
c20db43f
PE
3580 * intervals.h (struct interval): Use EMACS_INT for members
3581 where EMACS_UINT might cause problems. See
3582 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3583 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3584 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3585 All uses changed.
37aa2f85
PE
3586 (offset_intervals): Tell GCC not to worry about length overflow
3587 when negating a negative length.
c20db43f 3588
2538aa2f
PE
3589 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3590 (overrun_check_free): Likewise.
3591
f2d3008d
PE
3592 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3593 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3594 word size.
3595
ec8df744
PE
3596 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3597 (gnutls_make_error): Rename local to avoid shadowing.
3598 (gnutls_emacs_global_deinit): ifdef out; not used.
3599 (Fgnutls_boot): Use const for pointer to readonly storage.
3600 Comment out unused local. Fix pointer signedness problems.
3601
640ee02d
PE
3602 * lread.c (openp): Don't stuff size_t into an 'int'.
3603 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3604 about possible signed overflow.
3605
6048fb2a
PE
3606 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3607 (GDK_KEY_g): Don't define if already defined.
3608 (xg_prepare_tooltip): Avoid pointer signedness problem.
3609 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3610
fa3c87e1
PE
3611 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3612 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3613
2172544b
PE
3614 * xfns.c (Fx_window_property): Simplify a bit,
3615 to make a bit faster and to avoid GCC 4.6.0 warning.
3616 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3617
9b821a21
PE
3618 * fns.c (internal_equal): Don't assume size_t fits in int.
3619
3c616cfa
PE
3620 * alloc.c (compact_small_strings): Tighten assertion a little.
3621
c2982e87
PE
3622 Replace pEd with more-general pI, and fix some printf arg casts.
3623 * lisp.h (pI): New macro, generalizing old pEd macro to other
3624 conversion specifiers. For example, use "...%"pI"d..." rather
3625 than "...%"pEd"...".
3626 (pEd): Remove. All uses replaced with similar uses of pI.
3627 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3628 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3629 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3630 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3631 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3632 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3633 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3634 64-bit hosts.
3635 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3636 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3637 * print.c (safe_debug_print, print_object): Likewise.
3638 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3639 to int.
6f04d126
PE
3640 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3641 avoiding the 0 flag, which is not portable.
c2982e87
PE
3642 * process.c (Fmake_network_process): Use pI to avoid cast.
3643 * region-cache.c (pp_cache): Likewise.
3644 * xdisp.c (decode_mode_spec): Likewise.
3645 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3646 behavior on 64-bit hosts with printf arg.
6f04d126 3647 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3648 (x_stop_queuing_selection_requests): Likewise.
3649 (x_get_window_property): Don't truncate byte count to an 'int'
3650 when tracing.
0b432f21 3651
5e073ec7
PE
3652 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3653 here, since it parses constructs like leading '-' and spaces,
3654 which are not wanted; and it overflows with large numbers.
3655 Instead, simply match F[0-9]+, which is what is wanted anyway.
3656
36372bf9
PE
3657 * alloc.c: Remove unportable assumptions about struct layout.
3658 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3659 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3660 (allocate_vectorlike, make_pure_vector): Use the new macros,
3661 plus offsetof, to remove unportable assumptions about struct layout.
3662 These assumptions hold on all porting targets that I know of, but
3663 they are not guaranteed, they're easy to remove, and removing them
3664 makes further changes easier.
3665
0b432f21
PE
3666 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3667 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3668 (string_overrun_cookie): Now const. Use initializers that
3669 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3670 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3671 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3672 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3673 multiple of sizeof (EMACS_INT); it need not be, if
3674 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3675 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3676
895009e1
JB
36772011-04-26 Juanma Barranquero <lekktu@gmail.com>
3678
3679 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3680
6a7a1b0b
TZ
36812011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3682
3683 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3684 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3685 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3686
841a1577 36872011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3688
3689 * lisp.h (Qdebug): List symbol.
895009e1 3690 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3691 * keyboard.c (debug-on-event): New variable.
3692 (handle_user_signal): Break into debugger when debug-on-event
3693 matches the current signal symbol.
3694
f2d3ba6f
DN
36952011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3696
3697 * alloc.c (check_sblock, check_string_bytes)
3698 (check_string_free_list): Convert to standard C.
3699
42ce4c63
TZ
37002011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3701
3702 * w32.c (emacs_gnutls_push): Fix typo.
3703
825cd63c
EZ
37042011-04-25 Eli Zaretskii <eliz@gnu.org>
3705
fb11d64d
EZ
3706 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3707 "cast to pointer from integer of different size".
3708
825cd63c
EZ
3709 Improve doprnt and its use in verror. (Bug#8545)
3710 * doprnt.c (doprnt): Document the set of format control sequences
3711 supported by the function. Use SAFE_ALLOCA instead of always
3712 using `alloca'.
3713
3714 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3715 is one byte too soon. Don't use xrealloc; instead xfree and
3716 xmalloc anew.
3717
e061a11b
TZ
37182011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3719
3720 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3721 callbacks stage.
3722
3723 * gnutls.c: Renamed global_initialized to
3724 gnutls_global_initialized. Added internals for the
3725 :verify-hostname-error, :verify-error, and :verify-flags
3726 parameters of `gnutls-boot' and documented those parameters in the
3727 docstring. Start callback support.
9173deec
JB
3728 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3729 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3730 on error. Return error code.
e061a11b
TZ
3731 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3732 (emacs_gnutls_read): Likewise.
3733 (Fgnutls_boot): Return handshake error code.
3734 (emacs_gnutls_handle_error): New function.
3735 (wsaerror_to_errno): Likewise.
3736
3737 * w32.h (emacs_gnutls_pull): Add prototype.
3738 (emacs_gnutls_push): Likewise.
3739
3740 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3741 (emacs_gnutls_push): Likewise.
3742
37432011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3744
3745 * process.c (wait_reading_process_output): Check if GnuTLS
3746 buffered some data internally if no FDs are set for TLS
3747 connections.
3748
3749 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3750 (LIBS): Link to USER_LIBS.
3751 ($(BLD)/gnutls.$(0)): New target.
3752
fa6996bc
EZ
37532011-04-24 Eli Zaretskii <eliz@gnu.org>
3754
eb35682e
EZ
3755 * xdisp.c (handle_single_display_spec): Rename the
3756 display_replaced_before_p argument into display_replaced_p, to
3757 make it consistent with the commentary. Fix typos in the
3758 commentary.
3759
e2ad650c
EZ
3760 * textprop.c (syms_of_textprop): Remove dead code.
3761 (copy_text_properties): Delete obsolete commentary about an
3762 interface that was deleted long ago. Fix typos in the description
3763 of arguments.
3764
1b2de274
EZ
3765 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3766 to changes in oldXMenu/XMenu.h from 2011-04-16.
3767 <menu_help_message, prev_menu_help_message>: Constify.
3768 (IT_menu_make_room): menu->help_text is now `const char **';
3769 adjust.
3770
3771 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3772 to changes in oldXMenu/XMenu.h from 2011-04-16.
3773 (struct XMenu): Declare `help_text' `const char **'.
3774
3775 * xfaces.c <Qunspecified>: Make extern again.
3776
3777 * syntax.c: Include sys/types.h before including regex.h, as
3778 required by Posix.
3779
762b15be
EZ
3780 * doc.c (get_doc_string): Improve the format passed to `error'.
3781
3782 * doprnt.c (doprnt): Improve commentary.
3783
3784 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3785
3786 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3787 them with etags.
3788
f1052e5d
EZ
3789 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3790 changes in globals.h immediately force recompilation.
762b15be
EZ
3791 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3792 $(CURDIR)/s/ms-w32.h.
3793 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3794
fa6996bc
EZ
3795 * character.c (Fchar_direction): Function deleted.
3796 (syms_of_character): Don't defsubr it.
3797 <char-direction-table>: Deleted.
3798
e6c3da20
EZ
37992011-04-23 Eli Zaretskii <eliz@gnu.org>
3800
3801 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3802 * doprnt.c: Include limits.h.
3803 (SIZE_MAX): New macro.
04f2d78b
CB
3804 (doprnt): Return a size_t value. 2nd arg is now size_t.
3805 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3806 Improve overflow protection. Support `l' modifier for integer
3807 conversions. Support %l conversion. Don't assume an EMACS_INT
3808 argument for integer conversions and for %c.
3809
3810 * lisp.h (doprnt): Restore prototype.
3811
3812 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3813 $(SRC)/character.h.
3814
3815 * Makefile.in (base_obj): Add back doprnt.o.
3816
3817 * deps.mk (doprnt.o): Add back prerequisites.
3818 (callint.o): Depend on character.h.
3819
3820 * eval.c (internal_lisp_condition_case): Include the handler
3821 representation in the error message.
3822 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3823 when breaking from the loop.
3824
3825 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3826
3827 * callint.c (Fcall_interactively): When displaying error message
3828 about invalid control letter, pass the character's codepoint, not
3829 a pointer to its multibyte form. Improve display of the character
3830 in octal and display also its hex code.
3831
3832 * character.c (char_string): Use %x to display the (unsigned)
3833 codepoint of an invalid character, to avoid displaying a bogus
3834 negative value.
3835
3836 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3837 `error', not SYMBOL_NAME itself.
3838
3839 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3840 character arguments to `error'.
3841
3842 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3843 to `error' in error message about FINAL_CHAR argument. Make sure
3844 FINAL_CHAR is a character, and use %c when it is passed as
3845 argument to `error'.
3846
4ffd0d6b 38472011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3848
3849 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3850
3851 * w32.c: Include <time.h>.
3852 (sys_localtime): New function.
3853
4ffd0d6b 38542011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3855
3856 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3857
4ffd0d6b 3858 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3859
4ffd0d6b 38602011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3861
4ffd0d6b
GM
3862 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3863 zombies (Bug#8467).
aac0c6e3 3864
04c56954
EZ
38652011-04-19 Eli Zaretskii <eliz@gnu.org>
3866
3867 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3868 gl_state.e_property when gl_state.object is Qt.
3869
3870 * insdel.c (make_gap_larger): Remove limitation of buffer size
3871 to <= INT_MAX.
3872
16a43933
CY
38732011-04-18 Chong Yidong <cyd@stupidchicken.com>
3874
3875 * xdisp.c (lookup_glyphless_char_display)
3876 (produce_glyphless_glyph): Handle cons cell entry in
3877 glyphless-char-display.
3878 (Vglyphless_char_display): Document it.
3879
3880 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3881 glyphless-char-display.
3882
4581706e
CY
38832011-04-17 Chong Yidong <cyd@stupidchicken.com>
3884
3885 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3886
3887 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3888
3889 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3890 definition for no-X builds.
3891
4887c6e2 38922011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3893
fd35b6f9
PE
3894 Static checks with GCC 4.6.0 and non-default toolkits.
3895
5c1ccb01
PE
3896 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3897
006c5daa
PE
3898 * process.c (keyboard_bit_set): Define only if SIGIO.
3899 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3900 (send_process): Repair possible setjmp clobbering.
3901
efc736d3
PE
3902 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3903
4e2fe2e6
PE
3904 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3905
f97334a2
PE
3906 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3907
4e75f29d
PE
3908 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3909 Define only if needed.
3910
90efadd1
PE
3911 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3912 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3913 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3914
3c647824
PE
3915 * dispextern.h (struct redisplay_interface): Rename param
3916 to avoid shadowing.
e264f262 3917 * termhooks.h (struct terminal): Likewise.
761383f4 3918 * xterm.c (xembed_send_message): Likewise.
3c647824 3919
b58c5c4a
PE
3920 * insdel.c (make_gap_smaller): Define only if
3921 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3922
cad59032
PE
3923 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3924 it.
3925
c339dc2e
PE
3926 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3927 so that we aren't warned about unused symbols.
3928
91a3e27b
PE
3929 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3930
399c71d3 3931 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3932
8ffc96f5
PE
3933 * xfns.c (x_real_positions): Mark locals as initialized.
3934
eef9bc79
PE
3935 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3936
098db9dd
PE
3937 * xterm.c: Fix problems found by static analysis with other toolkits.
3938 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3939 (x_dispatch_event): Declare static if USE_GTK, and
3940 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3941 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3942 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3943 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3944 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3945
eb18f6cc
PE
3946 * xmenu.c (menu_help_callback): Pointer type fixes.
3947 Use const pointers when pointing at readonly data. Avoid pointer
3948 signedness clashes.
3949 (FALSE): Remove unused macro.
3950 (update_frame_menubar): Remove unused decl.
3951
1fe72bf8
PE
3952 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3953
60d9e1db
PE
3954 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3955 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3956 (single_menu_item): Rename local to avoid shadowing.
3957
39261c26
PE
3958 * keyboard.c (make_lispy_event): Remove unused local var.
3959
018c5e19
PE
3960 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3961 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3962
63d2b86e
PE
3963 * bitmaps: Change bitmaps from unsigned char back to the X11
3964 compatible char. Avoid the old compiler warnings about
3965 out-of-range initializers by using, for example, '\xab' rather
3966 than 0xab.
3967
aefd87e1
PE
3968 * xgselect.c (xgselect_initialize): Check vs interface
3969 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3970
bf501fb9
PE
3971 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3972
e9829fdf
PE
3973 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3974 to read-only memory.
3975
1086c095
PE
3976 * fns.c (vector): Remove; this old hack is no longer needed.
3977
2baccd04 3978 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3979 Remove unused var.
dde42981 3980 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3981
72391843 3982 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3983
436c16df 3984 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3985 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3986 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3987
92bb796d 3988 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3989 (x_term_init): Remove local to avoid shadowing.
92bb796d 3990
764430a3 3991 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3992
3993 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3994 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3995
d1dfb56c
EZ
39962011-04-16 Eli Zaretskii <eliz@gnu.org>
3997
c4354cb4
EZ
3998 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3999
d1dfb56c
EZ
4000 Fix regex.c, syntax.c and friends for buffers > 2GB.
4001 * syntax.h (struct gl_state_s): Declare character position members
4002 EMACS_INT.
4003
4004 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4005
04f2d78b
CB
4006 * textprop.c (verify_interval_modification, interval_of):
4007 Declare arguments EMACS_INT.
d1dfb56c
EZ
4008
4009 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4010 EMACS_INT.
4011
4012 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4013
4014 * indent.c (Fvertical_motion): Local variable it_start is now
4015 EMACS_INT.
4016
4017 * regex.c (re_match, re_match_2, re_match_2_internal)
4018 (bcmp_translate, regcomp, regexec, print_double_string)
4019 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4020 (re_compile_pattern, re_exec): Declare arguments and local
4021 variables `size_t' and `ssize_t' and return values `regoff_t', as
4022 appropriate.
4023 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4024 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4025 <compile_stack_type>: `size' and `avail' are now `size_t'.
4026
4027 * regex.h <regoff_t>: Use ssize_t, not int.
4028 (re_search, re_search_2, re_match, re_match_2): Arguments that
4029 specify buffer/string position and length are now ssize_t and
4030 size_t. Return type is regoff_t.
4031
613052cd
BK
40322011-04-16 Ben Key <bkey76@gmail.com>
4033
4034 * nsfont.m: Fixed bugs in ns_get_family and
4035 ns_descriptor_to_entity that were caused by using free to
4036 deallocate memory blocks that were allocated by xmalloc (via
4037 xstrdup). This caused Emacs to crash when compiled with
4038 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4039 --enable-checking=xmallocoverrun). xfree is now used to
4040 deallocate these memory blocks.
4041
4170f62f 40422011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4043
71b41406
PE
4044 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4045
9587a89d
PE
4046 emacs_write: Accept and return EMACS_INT for sizes.
4047 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4048 et seq.
4049 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4050 Accept and return EMACS_INT.
4051 (emacs_gnutls_write): Return the number of bytes written on
4052 partial writes.
4053 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4054 (emacs_read, emacs_write): Remove check for negative size, as the
4055 Emacs source code has been audited now.
9587a89d
PE
4056 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4057 (emacs_read, emacs_write): Use it.
273a5f82
PE
4058 * process.c (send_process): Adjust to the new signatures of
4059 emacs_write and emacs_gnutls_write. Do not attempt to store
4060 a byte offset into an 'int'; it might overflow.
9587a89d 4061 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4062
3e047f51
PE
4063 * sound.c: Don't assume sizes fit in 'int'.
4064 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4065 Return EMACS_INT, not int.
3e047f51 4066 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4067 Accept EMACS_INT, not int.
4068 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4069 record read return values.
4070
cc39a9db
BK
40712011-04-15 Ben Key <bkey76@gmail.com>
4072
c9d0ec6d
JB
4073 * keyboard.c (Qundefined): Don't declare static since it is used
4074 in nsfns.m.
4075 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4076 static since they are used in nsfont.m.
cc39a9db 4077
6c60eb9f
SM
40782011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4079
4080 * process.c (Qprocessp): Don't declare static.
4081 * lisp.h (Qprocessp): Declare again.
4082
7990b61a
JB
40832011-04-15 Juanma Barranquero <lekktu@gmail.com>
4084
4085 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4086
5d4cb038
PE
40872011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4088
8bd7b830 4089 Improve C-level modularity by making more things 'static'.
cd64ea1d 4090
e3b27b31
PE
4091 Don't publish debugger-only interfaces to other modules.
4092 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4093 (verify_bytepos, count_markers): Move decls to the only modules
4094 that need them.
4095 * region-cache.h (pp_cache): Likewise.
4096 * window.h (check_all_windows): Likewise.
4097 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4098
5d4cb038
PE
4099 * sysdep.c (croak): Now static, if
4100 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4101 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4102
4103 * alloc.c (refill_memory_reserve): Now static if
4104 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4105 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4106
e87b6180
PE
4107 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4108 Define only if USE_LUCID.
4109
ac64929e
PE
4110 * xrdb.c (x_customization_string, x_rm_string): Now static.
4111
6f37259d
PE
4112 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4113 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4114
1683e3ab
PE
4115 * xdisp.c (draw_row_with_mouse_face): Now static.
4116 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4117
de9c2632
PE
4118 * window.h (check_all_windows): Mark externally visible.
4119
2b96acb7
PE
4120 * window.c (window_deletion_count): Now static.
4121
4122 * undo.c: Make symbols static if they're not exported.
4123 (last_undo_buffer, last_boundary_position, pending_boundary):
4124 Now static.
4125
50436f33
PE
4126 * textprop.c (interval_insert_behind_hooks): Now static.
4127 (interval_insert_in_front_hooks): Likewise.
4128
64520e5c
PE
4129 * term.c: Make symbols static if they're not exported.
4130 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4131 (max_frame_lines, tty_set_terminal_modes):
4132 (tty_reset_terminal_modes, tty_turn_off_highlight):
4133 (get_tty_terminal): Now static.
4134 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4135 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4136 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4137 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4138 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4139
1fa53021
PE
4140 * sysdep.c: Make symbols static if they're not exported.
4141 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4142 Now static.
4143 (sigprocmask_set, full_mask): Remove; unused.
4144 (wait_debugging): Mark as visible.
4145 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4146 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4147
d4b43b22
PE
4148 * syntax.c (syntax_temp): Define only if !__GNUC__.
4149
b7c513d0
PE
4150 * sound.c (current_sound_device, current_sound): Now static.
4151
989b29ad
PE
4152 * search.c (searchbufs, searchbuf_head): Now static.
4153
13a55a78
PE
4154 * scroll.c (scroll_cost): Remove; unused.
4155 * dispextern.h (scroll_cost): Remove decl.
4156
de68a1fc
PE
4157 * region-cache.h (pp_cache): Mark as externally visible.
4158
40ccffa6
PE
4159 * process.c: Make symbols static if they're not exported.
4160 (process_tick, update_tick, create_process, chan_process):
4161 (Vprocess_alist, proc_buffered_char, datagram_access):
4162 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4163 (deactivate_process): Mark defn as static, as well as decl.
4164 * lisp.h (create_process): Remove decl.
4165 * process.h (chan_process, Vprocess_alist): Remove decls.
4166
ad64fc97
PE
4167 * print.c: Make symbols static if they're not exported.
4168 (print_depth, new_backquote_output, being_printed, print_buffer):
4169 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4170 (print_interval, print_number_index, initial_stderr_stream):
4171 Now static.
4172 * lisp.h (Fprinc): Remove decl.
4173 (debug_output_compilation_hack): Mark as externally visible.
4174
adddb265
PE
4175 * sysdep.c (croak): Move decl from here to syssignal.h.
4176 * syssignal.h (croak): Put it here, so the API can be checked when
4177 'croak' is called from dissociate_if_controlling_tty.
4178
1717ede2
PE
4179 * minibuf.c: Make symbols static if they're not exported.
4180 (minibuf_save_list, choose_minibuf_frame): Now static.
4181 * lisp.h (choose_minibuf_frame): Remove decl.
4182
fa5fb2bc
PE
4183 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4184
1e3890d1
PE
4185 * lread.c: Make symbols static if they're not exported.
4186 (read_objects, initial_obarray, oblookup_last_bucket_number):
4187 Now static.
4188 (make_symbol): Remove; unused.
4189 * lisp.h (initial_obarray, make_symbol): Remove decls.
4190
8a1414fa
PE
4191 * keyboard.c: Make symbols static if they're not exported.
4192 (single_kboard, recent_keys_index, total_keys, recent_keys):
4193 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4194 (this_single_command_key_start, echoing, last_auto_save):
4195 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4196 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4197 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4198 (Vlispy_mouse_stem, double_click_count):
4199 Now static.
4200 (force_auto_save_soon): Define only if SIGDANGER.
4201 (ignore_mouse_drag_p): Now static if
4202 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4203 (print_help): Remove; unused.
4204 (stop_character, last_timer_event): Mark as externally visible.
4205 * keyboard.h (ignore_mouse_drag_p): Declare only if
4206 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4207 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4208 * lisp.h (echoing): Remove decl.
4209 (force_auto_save_soon): Declare only if SIGDANGER.
4210 * xdisp.c (redisplay_window): Simplify code, to make it more
4211 obvious that ignore_mouse_drag_p is not accessed if !defined
4212 USE_GTK && !defined HAVE_NS.
4213
93ea6e8f
PE
4214 * intervals.c: Make symbols static if they're not exported.
4215 (merge_properties_sticky, merge_interval_right, delete_interval):
4216 Now static.
4217 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4218
77382fcc
PE
4219 * insdel.c: Make symbols static if they're not exported.
4220 However, leave prepare_to_modify_buffer alone. It's never
4221 called from outside this function, but that appears to be a bug.
4222 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4223 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4224 (adjust_after_replace_noundo): Remove; unused.
4225 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4226 (signal_before_change): Remove decls.
77382fcc 4227
9306c32e
PE
4228 * indent.c (val_compute_motion, val_vmotion): Now static.
4229
cd44d2eb
PE
4230 * image.c: Make symbols static if they're not exported.
4231 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4232 if USE_GTK.
4233 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4234 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4235
ad9a7a06
PE
4236 * fringe.c (standard_bitmaps): Now static.
4237 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4238
81626931
PE
4239 * frame.c: Make symbols static if they're not exported.
4240 (x_report_frame_params, make_terminal_frame): Now static.
4241 (get_frame_param): Now static, unless HAVE_NS.
4242 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4243 (x_get_resource_string): Remove; not used.
4244 * frame.h (make_terminal_frame, x_report_frame_params):
4245 (x_get_resource_string); Remove decls.
4246 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4247 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4248
239f9db9
PE
4249 * font.c, fontset.c: Make symbols static if they're not exported.
4250 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4251 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4252 * font.c (font_close_object): Now static.
4253 * font.h (font_close_object): Remove.
4254 * fontset.c (FONTSET_OBJLIST): Remove.
4255 (free_realized_fontset) #if-0 the body, which does nothing.
4256 (face_suitable_for_char_p): #if-0, as it's never called.
4257 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4258 * xfaces.c (face_at_string_position):
4259 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4260 since 0 is always ASCII.
4261
dfcf3579
PE
4262 * fns.c (weak_hash_tables): Now static.
4263
5045092b
PE
4264 * fileio.c: Make symbols static if they're not exported.
4265 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4266 (Vwrite_region_annotation_buffers): Now static.
4267
57a96f5c
PE
4268 * eval.c: Make symbols static if they're not exported.
4269 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4270 * lisp.h (backtrace_list): Remove decl.
4271
35f08c38
PE
4272 * emacs.c: Make symbols static if they're not exported.
4273 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4274 (fatal_error_code, fatal_error_signal_hook, standard_args):
4275 Now static.
4276 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4277 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4278 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4279 * lisp.h (fatal_error_signal_hook): Remove decl.
4280 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4281
f44bd759
PE
4282 * editfns.c: Move a (normally-unused) function to its only use.
4283 * editfns.c, lisp.h (get_operating_system_release): Remove.
4284 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4285 worth the hassle of breaking this out.
4286
b532497d
PE
4287 * xterm.c: Make symbols static if they're not exported.
4288 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4289 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4290 (x_destroy_window, x_delete_display):
4291 Now static.
4292 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4293 (x_mouse_leave): Remove; unused.
4294 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4295 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4296 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4297 Remove decls.
4298 (x_mouse_leave): Declare only if WINDOWSNT.
4299 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4300 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4301 USE_X_TOOLKIT.
4302
1675728f
PE
4303 * ftxfont.c: Make symbols static if they're not exported.
4304 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4305 HAVE_FREETYPE.
4306 * font.h (ftxfont_driver): Likewise.
4307
e4cebfca
PE
4308 * xfns.c: Make symbols static if they're not exported.
4309 (x_last_font_name, x_display_info_for_name):
4310 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4311 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4312 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4313 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4314 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4315 (last_show_tip_args): Now static.
4316 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4317 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4318 (x_screen_planes): Remove; unused.
4319 * dispextern.h (x_screen_planes): Remove decl.
4320
5bf46f05
PE
4321 * dispnew.c: Make symbols static if they're not exported.
4322 * dispextern.h (redraw_garbaged_frames, scrolling):
4323 (increment_row_positions): Remove.
4324 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4325 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4326 Now static.
4327 (redraw_garbaged_frames): Remove; unused.
4328
435f4c28
PE
4329 * xfaces.c: Make symbols static if they're not exported.
4330 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4331 Remove decls.
4332 * xterm.h (defined_color): Remove decls.
4333 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4334 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4335 (menu_face_changed_default, defined_color, free_realized_face):
4336 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4337 (ascii_face_of_lisp_face): Remove; unused.
4338
8524aef3
PE
4339 * xdisp.c: Make symbols static if they're not exported.
4340 * dispextern.h (scratch_glyph_row, window_box_edges):
4341 (glyph_to_pixel_coords, set_cursor_from_row):
4342 (get_next_display_element, set_iterator_to_next):
4343 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4344 (show_mouse_face): Remove decls
4345 * frame.h (message_buf_print): Likewise.
4346 * lisp.h (pop_message, set_message, check_point_in_composition):
4347 Likewise.
4348 * xterm.h (set_vertical_scroll_bar): Likewise.
4349 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4350 (message_buf_print, scratch_glyph_row, displayed_buffer):
4351 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4352 (get_next_display_element, show_mouse_face, window_box_edges):
4353 (frame_to_window_pixel_xy, check_point_in_composition):
4354 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4355 (glyph_to_pixel_coords): Remove; unused.
4356
16390cd2
PE
4357 * dired.c (file_name_completion): Now static.
4358
4359 * dbusbind.c (xd_in_read_queued_messages): Now static.
4360
a25f4dfa
PE
4361 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4362 * data.c (circular_list_error): Remove.
4363
14a9c8df
PE
4364 * commands.h (last_point_position, last_point_position_buffer):
4365 (last_point_position_window): Remove decls.
4366 * keyboard.c: Make these variables static.
4367
04f2d78b
CB
4368 * coding.h (coding, code_convert_region, encode_coding_gap):
4369 Remove decls.
74ab6df5
PE
4370 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4371 (iso_code_class, detect_coding, code_convert_region): Now static.
4372 (encode_coding_gap): Remove; unused.
4373
38dfbee1
PE
4374 * chartab.c (chartab_chars, chartab_bits): Now static.
4375
a2cb4e63
PE
4376 * charset.h (charset_iso_8859_1): Remove decl.
4377 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4378 Now static.
4379
127198fd
PE
4380 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4381 * ccl.c (Vccl_program_table): Now static.
4382 (check_ccl_update): Remove; unused.
4383
d85b608f
PE
4384 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4385 * category.h: ... from here.
4386 * category.c (check_category_table, set_category_set): Now static.
4387
31cd66f3
PE
4388 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4389 * lisp.h: Remove these decls.
4390
c358e587
PE
4391 * buffer.c (buffer_count): Remove unused var.
4392
e78aecca
PE
4393 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4394 so that it's not optimized away.
4395 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4396 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4397 exported only to the debugger.
4398
e192d7d3 4399 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4400 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4401
92470028
PE
4402 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4403 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4404 was inaccessible from Lisp.
4405 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4406 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4407
244ed907
PE
4408 alloc.c: Import and export fewer symbols, and remove unused items.
4409 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4410 is defined.
4411 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4412 it's not optimized away by whole-program optimization.
4413 (message_enable_multibyte, free_misc): Remove.
4414 (catchlist, handlerlist, mark_backtrace):
4415 Declare only if BYTE_MARK_STACK.
4416 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4417 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4418 (message_enable_multibyte): Remove decl.
4419 (free_misc, interval_free_list, float_block, float_block_index):
4420 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4421 (cons_free_list, last_marked_index):
4422 Now static.
4423 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4424 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4425 (mark_backtrace): Define only if BYTE_MARK_STACK.
4426 * xdisp.c (message_enable_multibyte): Now static.
4427
61c2b50e 4428 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4429 This makes it easier for human readers (and static analyzers)
4430 to see whether these variables are used from other modules.
4431 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4432 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4433 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4434 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4435 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4436 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4437 * xmenu.c, xselect.c:
4438 Declare Q* vars static if they are not used in other modules.
4439 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4440 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4441 Remove decls of unexported vars.
4442 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4443
95c82688
PE
4444 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4445
16a97296
PE
4446 Make Emacs functions such as Fatom 'static' by default.
4447 This makes it easier for human readers (and static analyzers)
4448 to see whether these functions can be called from other modules.
4449 DEFUN now defines a static function. To make the function external
4450 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4451 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4452 (Finit_image_library):
16a97296
PE
4453 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4454 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4455 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4456 Remove decls, since these functions are now static.
4457 (Funintern, Fget_internal_run_time): New decls, since these functions
4458 were already external.
95c82688 4459
16a97296
PE
4460 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4461 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4462 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4463 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4464 * keyboard.c, keymap.c, lread.c:
4465 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4466 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4467 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4468 Mark functions with DEFUE instead of DEFUN,
4469 if they are used in other modules.
4470 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4471 decls for now-static functions.
4472 * buffer.h (Fdelete_overlay): Remove decl.
4473 * callproc.c (Fgetenv_internal): Mark as internal.
4474 * composite.c (Fremove_list_of_text_properties): Remove decl.
4475 (Fcomposition_get_gstring): New forward static decl.
4476 * composite.h (Fcomposite_get_gstring): Remove decl.
4477 * dired.c (Ffile_attributes): New forward static decl.
4478 * doc.c (Fdocumntation_property): New forward static decl.
4479 * eval.c (Ffetch_bytecode): New forward static decl.
4480 (Funintern): Remove extern decl; now in .h file where it belongs.
4481 * fileio.c (Fmake_symbolic_link): New forward static decl.
4482 * image.c (Finit_image_library): New forward static decl.
4483 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4484 * intervals.h (Fprevious_property_change):
4485 (Fremove_list_of_text_properties): Remove decls.
4486 * keyboard.c (Fthis_command_keys): Remove decl.
4487 (Fcommand_execute): New forward static decl.
4488 * keymap.c (Flookup_key): New forward static decl.
4489 (Fcopy_keymap): Now static.
4490 * keymap.h (Flookup_key): Remove decl.
4491 * process.c (Fget_process): New forward static decl.
4492 (Fprocess_datagram_address): Mark as internal.
4493 * syntax.c (Fsyntax_table_p): New forward static decl.
4494 (skip_chars): Remove duplicate decl.
4495 * textprop.c (Fprevious_property_change): New forward static decl.
4496 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4497 Now internal.
4498 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4499 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4500
785bbd42
PE
4501 * editfns.c (Fformat): Remove unreachable code.
4502
8b913b57
AS
45032011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4504
4505 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4506 change. (Bug#8496)
4507
a6744a35
EZ
45082011-04-13 Eli Zaretskii <eliz@gnu.org>
4509
4510 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4511 when at ZV. (Bug#8487)
4512
e7974947
AS
45132011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4514
baad03f0
AS
4515 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4516 (Bug#8437)
4517 * keyboard.c (parse_tool_bar_item): Likewise.
4518 * sound.c (sound_cleanup, alsa_close): Likewise.
4519 * termcap.c (tgetent): Likewise.
4520 * xfns.c (x_default_font_parameter): Likewise.
4521 * xsettings.c (read_and_apply_settings): Likewise.
4522
e7974947
AS
4523 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4524 (overrun_check_free): Protoize.
4525
28272684
PE
45262011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4527
4528 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4529 since callers should never pass a negative size.
4530 Change the signature to match that of plain 'read' and 'write'; see
4531 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4532 * lisp.h: Update prototypes of emacs_write and emacs_read.
4533
11997c76
EZ
45342011-04-11 Eli Zaretskii <eliz@gnu.org>
4535
4536 * xdisp.c (redisplay_window): Don't try to determine the character
4537 position of the scroll margin if the window start point w->startp
e896f03c 4538 is outside the buffer's accessible region. (Bug#8468)
11997c76 4539
8a2cbd72
EZ
45402011-04-10 Eli Zaretskii <eliz@gnu.org>
4541
4542 Fix write-region and its subroutines for buffers > 2GB.
4543 * fileio.c (a_write, e_write): Modify declaration of arguments and
4544 local variables to support buffers larger than 2GB.
4545 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4546
4547 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4548 argument, local variables, and return value.
4549
4550 * lisp.h: Update prototypes of emacs_write and emacs_read.
4551
4552 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4553
4073e537 45542011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4555
1ebfdcb6
PE
4556 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4557
b2ded58d
PE
4558 Fix more problems found by GCC 4.6.0's static checks.
4559
7d66342c
PE
4560 * xdisp.c (vmessage): Use a better test for character truncation.
4561
bbf47d44
PE
4562 * charset.c (load_charset_map): <, not <=, for optimization,
4563 and to avoid potential problems with integer overflow.
9248994d 4564 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4565 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4566 * editfns.c (Fformat): Likewise.
1e69125e 4567 * syntax.c (skip_chars): Likewise.
3befa583 4568
e3019616
PE
4569 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4570 This also lets GCC 4.6.0 generate slightly better loop code.
4571
becfa255
PE
4572 * callint.c (Fcall_interactively): <, not <=, for optimization.
4573 (Fcall_interactively): Count the number of arguments produced,
4574 not the number of arguments given. This is simpler and lets GCC
4575 4.6.0 generate slightly better code.
4576
dae0cd48
PE
4577 * ftfont.c: Distingish more carefully between FcChar8 and char.
4578 The previous code passed unsigned char * to a functions like
4579 strlen and xstrcasecmp that expect char *, which does not
4580 conform to the C standard.
4581 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4582 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4583 char * when the C standard requires it.
4584
76032d70
PE
4585 * keyboard.c (read_char): Remove unused var.
4586
eb3f1cc8
PE
4587 * eval.c: Port to Windows vsnprintf (Bug#8435).
4588 Include <limits.h>.
4589 (SIZE_MAX): Define if the headers do not.
4590 (verror): Do not give up if vsnprintf returns a negative count.
4591 Instead, grow the buffer. This ports to Windows vsnprintf, which
4592 does not conform to C99. Problem reported by Eli Zaretskii.
4593 Also, simplify the allocation scheme, by avoiding the need for
4594 calling realloc, and removing the ALLOCATED variable.
4595
70476b54
PE
4596 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4597
12020a9e
PE
4598 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4599 But keep the doprint source code for now, as we might revamp it
4600 and use it again (Bug#8435).
ea6c7ae6
PE
4601 * lisp.h (doprnt): Remove.
4602 * Makefile.in (base_obj): Remove doprnt.o.
4603 * deps.mk (doprnt.o): Remove.
4604
5fdb398c
PE
4605 error: Print 32- and 64-bit integers portably (Bug#8435).
4606 Without this change, on typical 64-bit hosts error ("...%d...", N)
4607 was used to print both 32- and 64-bit integers N, which relied on
4608 undefined behavior.
4609 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4610 New macro.
4611 * lisp.h (error, verror): Mark as printf-like functions.
4612 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4613 Report overflow in size calculations when allocating printf buffer.
4614 Do not truncate output string at its first null byte.
4615 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4616 Truncate the output at a character boundary, since vsnprintf does not
4617 do that.
4618 * charset.c (check_iso_charset_parameter): Convert internal
4619 character to string before calling 'error', since %c now has the
4620 printf meaning.
4621 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4622 overflow when computing char to be passed to 'error'. Do not
4623 pass Lisp_Object to 'error'; pass the integer instead.
4624 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4625 formatted with plain %d.
4626
b189fa66
PE
4627 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4628
bff87ef0
PE
4629 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4630
7e2cac20
PE
4631 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4632
ce4d90b5
PE
4633 * xterm.c (x_catch_errors): Remove duplicate declaration.
4634
266c9547
PE
4635 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4636
79c49ad2
PE
4637 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4638
368f4090
JM
46392011-04-10 Jim Meyering <meyering@redhat.com>
4640
4641 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4642 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4643 return ssize_t not "int", and use size_t as the buffer length.
4644 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4645 * gnutls.h: Update declarations.
4646 * process.c (read_process_output): Use ssize_t, to match.
4647 (send_process): Likewise.
4648
a32d4040
CY
46492011-04-09 Chong Yidong <cyd@stupidchicken.com>
4650
4651 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4652
8546720e 46532011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4654
04f2d78b
CB
4655 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4656 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4657
8546720e
GM
4658 * xterm.c (handle_one_xevent):
4659 * xmenu.c (create_and_show_popup_menu):
4660 * xselect.c (x_decline_selection_request)
4661 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4662
0a2f5c1a 46632011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4664
4665 Fix some uses of `int' instead of EMACS_INT.
4666 * search.c (string_match_1, fast_string_match)
4667 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4668 (scan_buffer, find_next_newline_no_quit)
4669 (find_before_next_newline, search_command, Freplace_match)
4670 (Fmatch_data): Make some `int' variables be EMACS_INT.
4671
4672 * xdisp.c (display_count_lines): 3rd argument and return value now
4673 EMACS_INT. All callers changed.
4674 (pint2hrstr): Last argument is now EMACS_INT.
4675
4676 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4677 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4678 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4679 (decode_coding_utf_16, decode_coding_emacs_mule)
4680 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4681 (decode_coding_ccl, decode_coding_charset)
4682 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4683 (decode_coding_iso_2022, decode_coding_emacs_mule)
4684 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4685 <char_offset, last_offset>: Declare EMACS_INT.
4686 (encode_coding_utf_8, encode_coding_utf_16)
4687 (encode_coding_emacs_mule, encode_invocation_designation)
4688 (encode_designation_at_bol, encode_coding_iso_2022)
4689 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4690 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4691 Declare EMACS_INT.
4692 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4693 (encode_invocation_designation): Last argument P_NCHARS is now
4694 EMACS_INT.
4695 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4696 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4697
4698 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4699 All users changed.
4700
4701 * ccl.c (Fccl_execute_on_string): Declare some variables
4702 EMACS_INT.
4703
8546720e 47042011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4705
4706 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4707
4e19a977
CS
47082011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4709
4710 * process.c (Fformat_network_address): Doc fix.
4711
87302331
R
47122011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4713
4714 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4715
cbb59342
CY
47162011-04-08 Chong Yidong <cyd@stupidchicken.com>
4717
4718 * keyboard.c (read_char): Call Lisp function help-form-show,
4719 instead of using internal_with_output_to_temp_buffer.
4720 (Qhelp_form_show): New var.
e0d38eeb 4721 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4722
4723 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4724
4725 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4726
e67a13ab
CY
47272011-04-06 Chong Yidong <cyd@stupidchicken.com>
4728
04f2d78b
CB
4729 * process.c (Flist_processes): Remove to Lisp.
4730 (list_processes_1): Delete.
e67a13ab 4731
973f782d
EZ
47322011-04-06 Eli Zaretskii <eliz@gnu.org>
4733
7c106b1e
EZ
4734 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4735
973f782d
EZ
4736 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4737
41cf7d1a 47382011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4739
ca23cc88
PE
4740 Fix more problems found by GCC 4.6.0's static checks.
4741
f390e2d5
PE
4742 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4743
42eea0d0
PE
4744 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4745
b69769da 4746 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4747
f9541e84
PE
4748 * xdisp.c (vmessage): Mark as a printf-like function.
4749
13841b55
PE
4750 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4751
c136c10f
PE
4752 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4753
5e2d4a30
PE
4754 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4755 printf-like functions.
4756 (tiff_load): Add casts to remove these marks before passing them
4757 to system-supplied API.
4758
583f48b9
PE
4759 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4760
b25d760e
PE
4761 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4762 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4763 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4764 directly, rather than having caller test rule sign. This avoids
4765 some unnecessary tests.
4766 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4767 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4768 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4769
bc7b6697 4770 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4771 (xfont_open): Avoid unnecessary tests.
bc7b6697 4772
27ccc379
PE
4773 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4774
dcd5c89a
PE
4775 * composite.h, composite.c (composition_gstring_put_cache):
4776 Use EMACS_INT, not int, for length.
4777
b13a45c6
PE
4778 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4779 breaking out part of COMPOSITION_DECODE_RULE.
4780 (COMPOSITION_DECODE_RULE): Use it.
4781 * composite.c (get_composition_id): Remove unused local vars,
4782 by using the new macro.
4783
1e792e4d
PE
4784 * textprop.c (set_text_properties_1): Change while to do-while,
4785 since the condition is always true at first.
4786
dc6c6455 4787 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4788 (interval_deletion_adjustment): Return unsigned value.
4789 All uses changed.
dc6c6455 4790
aba7731a
PE
4791 * process.c (list_processes_1, create_pty, read_process_output):
4792 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4793 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4794 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4795 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4796 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4797
fdfc4bf3
PE
4798 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4799
fca8fe46 4800 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4801 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4802
06a0259a 4803 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4804 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4805 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4806
e7b9e80f
PE
4807 * print.c (print_error_message): Avoid int overflow.
4808
56201685
PE
4809 * font.c (font_list_entities): Redo for clarity,
4810 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4811
78834453 4812 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4813 (font_score): Avoid potential overflow in diff calculation.
78834453 4814
0bc0b309 4815 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4816 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4817
e610eaca
PE
4818 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4819
b895abce
PE
4820 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4821 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4822 can always succeed if overflow has undefined behavior.
4823
1f1d9321 4824 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4825 (wordify): Omit three unnecessary tests.
1f1d9321 4826
c59478bc
PE
4827 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4828 All callers changed. This avoids the need for an unused var.
4829
79b73827
PE
4830 * casefiddle.c (casify_region): Remove var that is set but not used.
4831
a4db5dfe
PE
4832 * dired.c (file_name_completion): Remove var that is set but not used.
4833
43aae36e
PE
4834 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4835
2a47c44d 4836 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4837 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4838
a37c69bf
PE
4839 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4840 Check for integer overflow on size calculations.
4841
328ab8e7
PE
4842 * buffer.c (Fprevious_overlay_change): Remove var that is set
4843 but not used.
4844
e5a2a5cb
PE
4845 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4846 Remove vars that are set but not used.
8d84a6eb 4847 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4848 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4849
a60e5f68
PE
4850 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4851
f661cb61 4852 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4853 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4854
f0397f5a
PE
4855 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4856 that are set but not used.
4857
8664db06 4858 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4859 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4860
6abdaa4a
PE
4861 * xselect.c (x_get_local_selection, x_handle_property_notify):
4862 Remove vars that are set but not used.
4863
0ce7538d 4864 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4865 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4866
9ae848fc
PE
4867 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4868 Remove var that is set but not used.
0b918413
PE
4869 (scroll_bar_windows_size): Now size_t, not int.
4870 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4871 Check for overflow.
9ae848fc 4872
a5a62657
PE
4873 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4874 (map_tty_color) [!defined MSDOS]: Likewise.
4875
5c5cdd39
PE
4876 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4877
66ebf983
PE
4878 * coding.c: Remove vars that are set but not used.
4879 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4880 All callers changed.
4881 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4882 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4883 (decode_coding_charset): Remove vars that are set but not used.
4884
1be4d761
PE
4885 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4886 that is set but not used.
4887
47553fa8
PE
4888 * print.c (print_object): Remove var that is set but not used.
4889
1f7196bf 4890 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4891 The gnulib version avoids calling malloc in the usual case,
4892 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4893 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4894 * filelock.c (current_lock_owner): Likewise.
4895 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4896 * sysdep.c: Include allocator.h, careadlinkat.h.
4897 (emacs_no_realloc_allocator): New static constant.
4898 (emacs_readlink): New function.
fdb61804
PE
4899 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4900 ../lib/careadlinkat.h.
d1fdcab7 4901
f84c17c7
SM
49022011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4903
4904 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4905 first non-nil return value).
4906
ef3862ad
JD
49072011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4908
4909 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4910 if not defined (Bug#8403).
4911
376a7006
JB
49122011-04-02 Juanma Barranquero <lekktu@gmail.com>
4913
4914 * xdisp.c (display_count_lines): Remove parameter `start',
4915 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4916 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4917 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4918 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4919 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4920 and thereabouts. All callers changed.
4921 (get_per_char_metric): Remove parameter `f', unused since
4922 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4923
6ca3801d
JM
49242011-04-02 Jim Meyering <meyering@redhat.com>
4925
4926 do not dereference NULL upon failed strdup
4927 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4928 (ns_get_family): Likewise.
4929
d8e2b5ba
JB
49302011-04-02 Juanma Barranquero <lekktu@gmail.com>
4931
4932 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4933
8c74fcbd
JD
49342011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4935
4936 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4937 later (Bug#8403).
4938
7200d79c
SM
49392011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4940
03408648 4941 Add lexical binding.
7200d79c 4942
03408648
SM
4943 * window.c (Ftemp_output_buffer_show): New fun.
4944 (Fsave_window_excursion):
4945 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4946
4947 * lread.c (lisp_file_lexically_bound_p): New function.
4948 (Fload): Bind Qlexical_binding.
4949 (readevalloop): Remove `evalfun' arg.
4950 Bind Qinternal_interpreter_environment.
4951 (Feval_buffer): Bind Qlexical_binding.
4952 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4953 Mark as dynamic.
4954 (syms_of_lread): Declare `lexical-binding'.
4955
4956 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4957
4958 * keyboard.c (eval_dyn): New fun.
4959 (menu_item_eval_property): Use it.
ca105506
SM
4960
4961 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4962
03408648
SM
4963 * fns.c (concat, mapcar1): Accept byte-code-functions.
4964
4965 * eval.c (Fsetq): Handle lexical vars.
4966 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4967 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4968 (FletX, Flet): Obey lexical binding.
4969 (Fcommandp): Handle closures.
4970 (Feval): New `lexical' arg.
4971 (eval_sub): New function extracted from Feval. Use it almost
4972 everywhere where Feval was used. Look up vars in lexical env.
4973 Handle closures.
4974 (Ffunctionp): Move from subr.el.
4975 (Ffuncall): Handle closures.
4976 (apply_lambda): Remove `eval_flags'.
4977 (funcall_lambda): Handle closures and new byte-code-functions.
4978 (Fspecial_variable_p): New function.
4979 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4980 but without exporting it to Lisp.
23aba0ea 4981
23aba0ea 4982 * doc.c (Fdocumentation, store_function_docstring):
03408648 4983 * data.c (Finteractive_form): Handle closures.
23aba0ea 4984
03408648
SM
4985 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4986 interactive spec.
ba83908c 4987
04f2d78b
CB
4988 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4989 New byte-codes.
03408648
SM
4990 (exec_byte_code): New function extracted from Fbyte_code to handle new
4991 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4992
03408648 4993 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4994
03408648 4995 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4996
e2abce01
JB
49972011-03-31 Juanma Barranquero <lekktu@gmail.com>
4998
4999 * xdisp.c (redisplay_internal): Fix prototype.
5000
63696a73 50012011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5002
63696a73 5003 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5004 (try_scrolling): Use it when setting scroll_limit.
5005 Limit scrolling to 100 screen lines.
63696a73
EZ
5006 (redisplay_window): Even when falling back on "recentering",
5007 position point in the window according to scroll-conservatively,
5008 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5009
5010 (try_scrolling): When point is above the window, allow searching
5011 as far as scroll_max, or one screenful, to compute vertical
5012 distance from PT to the scroll margin position. This prevents
5013 try_scrolling from unnecessarily failing when
5014 scroll-conservatively is set to a value slightly larger than the
5015 window height. Clean up the case of PT below the margin at bottom
5016 of window: scroll_max can no longer be INT_MAX. When aggressive
5017 scrolling is in use, don't let point enter the opposite scroll
5018 margin as result of the scroll.
5019 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5020 threshold of 100 lines for never-recentering scrolling.
5021
e4cc2dfc
JB
50222011-03-31 Juanma Barranquero <lekktu@gmail.com>
5023
5024 * dispextern.h (move_it_by_lines):
5025 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5026 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5027 (message_log_check_duplicate): Remove parameters `prev_bol' and
5028 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5029 (redisplay_internal): Remove parameter `preserve_echo_area',
5030 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5031
5032 * indent.c (Fvertical_motion):
5033 * window.c (window_scroll_pixel_based, Frecenter):
5034 Don't pass `need_y_p' to `move_it_by_lines'.
5035
1c470562
SM
50362011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5037
44f230aa
SM
5038 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5039 steal a few bits to be more compact.
5040 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5041 Remove unneeded casts.
5042
1c470562
SM
5043 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5044
888adce9
ZK
50452011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5046
5047 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5048 binding" message (bug#7967).
5049
f838ed7b
PE
50502011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5051
77861b95
PE
5052 Fix more problems found by GCC 4.6.0's static checks.
5053
de6dbc14
PE
5054 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5055 Remove unused local var.
5056
f838ed7b
PE
5057 * editfns.c (Fmessage_box): Remove unused local var.
5058
792c7b2b
PE
5059 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5060 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5061 Omit unused local vars.
c499e557 5062 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5063 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5064 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5065 Omit unused local var.
5066
ba0165e1
PE
5067 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5068 Don't assume string length fits in int.
32ad8845 5069 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5070 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5071
3c59b4c9
PE
5072 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5073 instead of alloca (Bug#8344).
5074
a3eed478 5075 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5076 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5077
eb4d412d
PE
5078 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5079
1658b401
PE
5080 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5081 concerns.
5082
5083 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5084
5085 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5086
9a2c6e05
PE
5087 * keyboard.c (syms_of_keyboard): Use the same style as later
5088 in this function when indexing through an array. This also
5089 works around GCC bug 48267.
5090
03d0a109
PE
5091 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5092
44f730c8
PE
5093 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5094
fe75f926
PE
5095 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5096 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5097
ffa8c828
PE
5098 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5099 This avoids undefined behavior on integer overflow, and is a bit
5100 more convenient anyway since it is compared to a size_t variable.
5101
c5101a77
PE
5102 Variadic C functions now count arguments with size_t, not int.
5103 This avoids an unnecessary limitation on 64-bit machines, which
5104 caused (substring ...) to crash on large vectors (Bug#8344).
5105 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5106 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5107 All variadic functions and their callers changed accordingly.
c5101a77
PE
5108 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5109 * data.c (arith_driver, float_arith_driver): Likewise.
5110 * editfns.c (general_insert_function): Likewise.
5111 * eval.c (struct backtrace.nargs, interactive_p)
5112 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5113 (funcall_lambda, mark_backtrace): Likewise.
5114 * fns.c (concat): Likewise.
5115 * frame.c (x_set_frame_parameters): Likewise.
5116 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5117 0 if not found, not -1. All callers changed.
5118
dd3f25f7
PE
5119 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5120 (stack_copy_size): Now size_t, not int.
5121 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5122
461c2ab9
JB
51232011-03-28 Juanma Barranquero <lekktu@gmail.com>
5124
5125 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5126 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5127 All callers changed.
5128
5129 * lisp.h (multibyte_char_to_unibyte):
5130 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5131 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5132 * character.h (CHAR_TO_BYTE8):
5133 * cmds.c (internal_self_insert):
5134 * editfns.c (general_insert_function):
5135 * keymap.c (push_key_description):
5136 * search.c (Freplace_match):
5137 * xdisp.c (message_dolog, set_message_1): All callers changed.
5138
f6d62986
SM
51392011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5140
5141 * keyboard.c (safe_run_hook_funcall): New function.
5142 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5143 don't set the hook to nil, but remove the offending function instead.
5144 (Qcommand_hook_internal): Remove, unused.
5145 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5146 Vcommand_hook_internal.
5147
5148 * eval.c (enum run_hooks_condition): Remove.
5149 (funcall_nil, funcall_not): New functions.
5150 (run_hook_with_args): Call each function through a `funcall' argument.
5151 Remove `cond' argument, now redundant.
5152 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5153 (Frun_hook_with_args_until_failure): Adjust accordingly.
5154 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5155
1db5b1ad
JB
51562011-03-28 Juanma Barranquero <lekktu@gmail.com>
5157
5158 * dispextern.h (string_buffer_position): Remove declaration.
5159
5160 * print.c (strout): Remove parameter `multibyte', unused since
5161 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5162
5163 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5164 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5165 All callers changed.
5166
5167 * w32.c (_wsa_errlist): Use braces for struct initializers.
5168
5169 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5170 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5171 All callers changed.
5172 (string_buffer_position): Likewise. Also, make static (it's never
5173 used outside xdisp.c).
5174 (cursor_row_p): Remove parameter `w', unused since
5175 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5176 (decode_mode_spec): Remove parameter `precision', introduced during
5177 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5178 All callers changed.
5179
5ffb62aa
JD
51802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5181
5182 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5183
461c2ab9 51842011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5185
5186 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5187 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5188 (ns_update_auto_hide_menu_bar): New functions.
5189 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5190 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5191 ns_constrain_all_frames.
5192 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5193 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5194
5c380ffb
JD
51952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5196
5197 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5198
9af30bdf
GM
51992011-03-27 Glenn Morris <rgm@gnu.org>
5200
5201 * syssignal.h: Replace RETSIGTYPE with void.
5202 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5203 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5204 Replace SIGTYPE with void everywhere.
5205 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5206 * s/template.h (SIGTYPE): Remove commented out definition.
5207
e2abce01
JB
52082011-03-26 Eli Zaretskii <eliz@gnu.org>
5209
5210 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5211 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5212
f868cd8a
JB
52132011-03-26 Juanma Barranquero <lekktu@gmail.com>
5214
59eb0929
JB
5215 * w32.c (read_unc_volume): Use parameter `henum', instead of
5216 global variable `wget_enum_handle'.
5217
5218 * keymap.c (describe_vector): Remove parameters `indices' and
5219 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5220 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5221
f868cd8a
JB
5222 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5223
5224 * keyboard.c (timer_check): Remove parameter `do_it_now',
5225 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5226 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5227 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5228
5229 * keyboard.c (read_char):
5230 * w32menu.c (w32_menu_display_help):
5231 * xmenu.c (show_help_event, menu_help_callback):
5232 Adjust calls to `show_help_echo'.
5233
5234 * gtkutil.c (xg_maybe_add_timer):
5235 * keyboard.c (readable_events):
5236 * process.c (wait_reading_process_output):
5237 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5238
5239 * insdel.c (adjust_markers_gap_motion):
5240 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5241 (gap_left, gap_right): Don't call it.
5242
2ecf6fdb
CY
52432011-03-25 Chong Yidong <cyd@stupidchicken.com>
5244
5245 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5246 incurred during fontification.
5247
6b1f9ba4
JB
52482011-03-25 Juanma Barranquero <lekktu@gmail.com>
5249
5250 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5251 (DEFVAR_PER_BUFFER): Don't pass it.
5252
5253 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5254 (scrolling_window): Don't pass it.
5255
0f4a96b5
JB
52562011-03-25 Juanma Barranquero <lekktu@gmail.com>
5257
5258 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5259
5260 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5261 and `suffix'.
5262 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5263 of variables specific to SELinux and computation of `encoded_absname'.
5264
5265 * image.c (XPutPixel): Remove unused variable `height'.
5266
5267 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5268
5269 * unexw32.c (get_section_info): Remove unused variable `section'.
5270
5271 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5272 (system_process_attributes): Remove unused variable `sess'.
5273 (sys_read): Remove unused variable `err'.
5274
5275 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5276 (w32_wnd_proc): Remove unused variable `isdead'.
5277 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5278 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5279 (x_create_tip_frame): Remove unused variable `tem'.
5280
5281 * w32inevt.c (w32_console_read_socket):
5282 Remove unused variable `no_events'.
5283
5284 * w32term.c (x_draw_composite_glyph_string_foreground):
5285 Remove unused variable `width'.
5286
1149507c
JB
52872011-03-24 Juanma Barranquero <lekktu@gmail.com>
5288
5289 * w32term.c (x_set_glyph_string_clipping):
5290 Don't pass uninitialized region to CombineRgn.
5291
9c88f339
JB
52922011-03-23 Juanma Barranquero <lekktu@gmail.com>
5293
5294 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5295 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5296 (Fx_close_connection): Remove unused variable `i'.
5297
5298 * w32font.c (w32font_draw): Return number of glyphs.
5299 (w32font_open_internal): Remove unused variable `i'.
5300 (w32font_driver): Add missing initializer.
5301
5302 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5303 (fill_in_menu): Remove unused variable `items_added'.
5304
5305 * w32term.c (last_mouse_press_frame): Remove static global variable.
5306 (w32_clip_to_row): Remove unused variable `f'.
5307 (x_delete_terminal): Remove unused variable `i'.
5308
5309 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5310 (NOTHING): Remove unused static global variable.
5311 (uniscribe_check_otf): Remove unused variable `table'.
5312 (uniscribe_font_driver): Add missing initializers.
5313
dee091a3
JD
53142011-03-23 Julien Danjou <julien@danjou.info>
5315
5316 * term.c (Fsuspend_tty, Fresume_tty):
5317 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5318 * window.c (temp_output_buffer_show):
5319 * insdel.c (signal_before_change):
5320 * frame.c (Fhandle_switch_frame):
5321 * fileio.c (Fdo_auto_save):
5322 * emacs.c (Fkill_emacs):
5323 * editfns.c (save_excursion_restore):
5324 * cmds.c (internal_self_insert):
5325 * callint.c (Fcall_interactively):
5326 * buffer.c (Fkill_all_local_variables):
5327 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5328 Use Frun_hooks.
0f4a96b5 5329 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5330 unconditionnaly since it does the check itself.
5331
2c520ab5 53322011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5333
c9c49752
PE
5334 Fix more problems found by GCC 4.5.2's static checks.
5335
8abc3f12
PE
5336 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5337 the first time through the loop, since we know p0 < p1 then.
5338 This also avoids a gcc -Wstrict-overflow warning.
5339
a2d26660
PE
5340 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5341 leading to a memory leak, possible in functions like
5342 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5343 of objects (Bug#8318).
a2d26660 5344
916c72e9
PE
5345 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5346 that could (at least in theory) be that large.
5347
19ab8a18
PE
5348 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5349 This is less likely to overflow, and avoids undefined behavior if
5350 overflow does occur. All callers changed. Use strtoul to scan
5351 for the unsigned long integer.
b7cbbd6f
PE
5352 (pint2hrstr): Simplify and tune code slightly.
5353 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5354
f0641eff
PE
5355 * scroll.c (do_scrolling): Work around GCC bug 48228.
5356 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5357
7f650bb9
PE
5358 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5359 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5360 (validate_x_resource_name): Simplify count usage.
5361 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5362
37dd57d1
PE
5363 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5364 fail (Bug#8306).
81e56e61 5365
699979fc 5366 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5367
401bf9b4
PE
5368 * process.c (Fmake_network_process): Use socklen_t, not int,
5369 where POSIX says socklen_t is required in portable programs.
5370 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5371 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5372 (Fmake_network_process, server_accept_connection):
5373 (wait_reading_process_output, read_process_output):
5374 Likewise.
5375
b93aacde
PE
5376 * process.c: Rename or move locals to avoid shadowing.
5377 (list_processes_1, Fmake_network_process):
5378 (read_process_output_error_handler, exec_sentinel_error_handler):
5379 Rename or move locals.
4dc343ee 5380 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5381 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5382 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5383 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5384 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5385
af8a867c 5386 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5387 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5388 Include tparam.h instead, since it declares them.
af8a867c
PE
5389 * cm.h (PC): Remove extern decl; tparam.h now does this.
5390 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5391 * terminfo.c: Include tparam.h, to check interfaces.
5392 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5393 (tparam): Adjust signature to match interface in tparam.h;
5394 this removes some undefined behavior. Check that outstring and len
5395 are zero, which they always are with Emacs.
5396 * tparam.h (PC, BC, UP): New extern decls.
5397
0248044d 5398 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5399 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5400
8ff096c1 5401 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5402 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5403 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5404 (ftfont_list): Remove unused local.
49eaafba
PE
5405 (get_adstyle_property, ftfont_pattern_entity):
5406 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5407 Rename locals to avoid shadowing.
8ff096c1 5408
e2be39f6
PE
5409 * xfont.c (xfont_list_family): Mark var as initialized.
5410
c9735e30
PE
5411 * xml.c (make_dom): Now static.
5412
8f5201ae
PE
5413 * composite.c (composition_compute_stop_pos): Rename local to
5414 avoid shadowing.
b246f932
PE
5415 (composition_reseat_it): Remove unused locals.
5416 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5417 (composition_update_it): Mark var as initialized.
11b61122
PE
5418 (find_automatic_composition): Mark vars as initialized,
5419 with a FIXME (Bug#8290).
8f5201ae 5420
760fbc2c
PE
5421 character.h: Rename locals to avoid shadowing.
5422 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5423 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5424 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5425 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5426 to avoid shadowing.
5427
ff08eb85
PE
5428 * textprop.c (property_change_between_p): Remove; unused.
5429
fc7bf025
PE
5430 * intervals.c (interval_start_pos): Now static.
5431
235d7abc
PE
5432 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5433
44f230aa
SM
5434 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5435 Rename locals to avoid shadowing.
3e7d6594 5436
50060332
PE
5437 * sound.c (wav_play, au_play, Fplay_sound_internal):
5438 Fix pointer signedness.
d01f234b 5439 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5440 (wav_play): Initialize a variable to 0, to prevent undefined
5441 behavior (Bug#8278).
50060332 5442
c4fc4e30
PE
5443 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5444
918436ed
PE
5445 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5446
c939f91b
PE
5447 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5448 clobbering (Bug#8298).
b9c7f648
PE
5449 * sysdep.c (sys_subshell): Likewise.
5450 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5451
6bd8c144
PE
5452 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5453 This should get cleaned up, so that child_setup has the
5454 same signature on all platforms.
5455
7710357c 5456 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5457 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5458
c59da222
CY
54592011-03-22 Chong Yidong <cyd@stupidchicken.com>
5460
5461 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5462 not to be necessary, and produces flickering.
5463
66b87493
GM
54642011-03-20 Glenn Morris <rgm@gnu.org>
5465
5466 * config.in: Remove file.
5467
45b6f6d5
JB
54682011-03-20 Juanma Barranquero <lekktu@gmail.com>
5469
5470 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5471 are now in src/globals.h.
5472 (syms_of_minibuf): Remove spurious & from previous change.
5473
3ec03f7e
LL
54742011-03-20 Leo <sdl.web@gmail.com>
5475
5476 * minibuf.c (completing-read-function): New variable.
5477 (completing-read-default): Rename from completing-read.
5478 (completing-read): Call completing-read-function.
5479
b14e3e21
CY
54802011-03-19 Juanma Barranquero <lekktu@gmail.com>
5481
5482 * xfaces.c (Fx_load_color_file):
5483 Read color file from absolute filename (bug#8250).
5484
f2b726e6
JB
54852011-03-19 Juanma Barranquero <lekktu@gmail.com>
5486
5487 * makefile.w32-in: Update dependencies.
5488
09f6ff02
EZ
54892011-03-17 Eli Zaretskii <eliz@gnu.org>
5490
5491 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5492
29a6015a
PE
54932011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5494
a3a6c54e
PE
5495 Fix more problems found by GCC 4.5.2's static checks.
5496
b766f867
PE
5497 * process.c (make_serial_process_unwind, send_process_trap):
5498 (sigchld_handler): Now static.
5499
be02381c
PE
5500 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5501 That way, the code declares only the vars that it needs.
5502 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5503 * s/cygwin.h (PTY_ITERATION): Likewise.
5504 * s/darwin.h (PTY_ITERATION): Likewise.
5505 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5506
57048744
PE
5507 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5508 * process.c (allocate_pty): Don't declare stb unless it's needed.
5509
7914961c 5510 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5511 (CONSTANTLIM): Remove; unused.
5512 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5513 Define only if needed.
7914961c 5514
b3967b18
PE
5515 * unexelf.c (unexec): Name an expression,
5516 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5517 Use a different way to cause a compilation error if anyone uses
5518 n rather than nn, a way that does not involve shadowing.
73366a00 5519 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5520
29a6015a
PE
5521 * deps.mk (unexalpha.o): Remove; unused.
5522
43cfc33e 5523 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5524 * unexec.h: New file.
ce701a33
PE
5525 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5526 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5527 Depend on unexec.h.
5528 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5529 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5530 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5531 Change as necessary to match prototype in unexec.h.
ce701a33 5532
01f44d5a
PE
5533 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5534 shadowing.
4f63c6bb 5535 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5536
a6670b0b
PE
5537 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5538 Rename locals to avoid shadowing.
5539
cef2010d 5540 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5541 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5542
d4d7173a
PE
5543 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5544
f08b802a
PE
5545 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5546 warning when compiling print.c.
5547
3ddb0639
PE
5548 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5549 instead of using an uninitialized var.
5ad03b97 5550 (font_sort_entities): Mark var as initialized.
3ddb0639 5551
170a2692
PE
5552 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5553
e663c700
PE
5554 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5555 pointers to constants.
89bc529a 5556 (font_parse_fcname): Remove unused vars.
7b81e2d0 5557 (font_delete_unmatched): Now static.
ea838e10 5558 (font_get_spec): Remove; unused.
13a547c6
PE
5559 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5560 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5561 Rename or move locals to avoid shadowing.
e663c700 5562
2a80c887 5563 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5564 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5565
1384fa33 5566 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5567 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5568
8b2c52e9
PE
5569 * alloc.c (mark_backtrace): Move decl from here ...
5570 * lisp.h: ... to here, so that it can be checked.
5571
475545b5 5572 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5573 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5574 (lisp_indirect_variable): Name an expression,
5575 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5576 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5577
b1349114 5578 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5579 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5580 Use const pointer when appropriate.
b1349114 5581
a2928364
PE
5582 * lisp.h (get_system_name, get_operating_system_release):
5583 Move decls here, to check interfaces.
5584 * process.c (get_operating_system_release): Move decl to lisp.h.
5585 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5586 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5587 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5588 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5589 (Fformat_time_string, Fencode_time, Finsert_char):
5590 (Ftranslate_region_internal, Fformat):
5591 Rename or remove local vars to avoid shadowing.
9710023e 5592 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5593
a415e694
PE
5594 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5595 avoid shadowing.
5596
8ef4622d
PE
5597 * lisp.h (eassert): Check that the argument compiles, even if
5598 ENABLE_CHECKING is not defined.
5599
946f9a5b
PE
5600 * data.c (Findirect_variable): Name an expression, to avoid
5601 gcc -Wbad-function-cast warning.
112396d6 5602 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5603 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5604 (Fmake_variable_buffer_local, Fmake_local_variable):
5605 Mark variables as initialized.
52746918 5606 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5607
e5aab7e7 5608 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5609 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5610 Rename locals to avoid shadowing.
dff45157
PE
5611 (mark_stack): Move local variables into the #ifdef region where
5612 they're used.
7bc26fdb
PE
5613 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5614 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5615 needed otherwise.
5616 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5617 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5618 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5619
e5aab7e7
PE
5620 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5621 avoids undefined behavior in theory.
5622
4da60324
PE
5623 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5624
88043301
PE
5625 Use functions, not macros, for up- and down-casing (Bug#8254).
5626 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5627 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5628 to use the following functions instead of these macros.
5629 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5630 EMACS_INT, since callers assume the returned value fits in int.
5631 (upcase1): Likewise, for UPCASE_TABLE.
5632 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5633 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5634 the race-condition problem in the old DOWNCASE.
88043301 5635
19ed5445
PE
5636 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5637 Rename locals to avoid shadowing.
5638 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5639 (regex_compile, re_search_2, re_match_2_internal):
5640 Remove unused local vars.
952db0d7
PE
5641 (FREE_VAR): Rewrite so as not to use empty "else",
5642 which gcc can warn about.
da053e48 5643 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5644 (RETALLOC_IF): Define only if needed.
5645 (WORDCHAR_P): Likewise. This one is never needed, but is used
5646 only in a comment talking about a compiler bug, so put inside
5647 the #if 0 of that comment.
5648 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5649 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5650 Remove; unused.
19ed5445 5651
1f3561e4 5652 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5653 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5654 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5655
ded6f8f7
PE
5656 * search.c (simple_search): Remove unused var.
5657
dbd37a95
PE
5658 * dired.c (compile_pattern): Move decl from here ...
5659 * lisp.h: ... to here, so that it can be checked.
5660 (struct re_registers): New forward decl.
5661
7e47afad
PE
5662 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5663
85f24f61
PE
5664 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5665 All uses changed.
5666 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5667 Rename locals to avoid shadowing.
5671df8f 5668 (Fvertical_motion): Mark locals as initialized.
85f24f61 5669
181aa2be 5670 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5671 (casify_region): Mark local as initialized.
181aa2be 5672
930d429c
PE
5673 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5674
7082eac6
PE
5675 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5676 New macros, so that the caller can use some names other than
5677 gcpro1, gcpro2, etc.
5678 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5679 of the new macros.
5680 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5681 argument, for consistency with GCPRO2_VAR, etc: it is now the
5682 prefix of the variable, not the variable itself. All uses
5683 changed.
38b2c076
PE
5684 * dired.c (directory_files_internal, file_name_completion):
5685 Rename locals to avoid shadowing.
5686
15206ed9
PE
5687 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5688 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5689 dired.c's scmp function, had undefined behavior.
5690 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5691 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5692 * buffer.h: ... to here, because these macros use current_buffer,
5693 and the new implementation with inline functions needs to have
5694 current_buffer in scope now, rather than later when the macros
5695 are used.
5696 (downcase, upcase1): New static inline functions.
5697 (DOWNCASE, UPCASE1): Reimplement using these functions.
5698 This avoids undefined behavior in expressions like
5699 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5700 from race conditions in accessing the global variables
5701 case_temp1 and case_temp2.
5702 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5703 * lisp.h (case_temp1, case_temp2): Remove their decls.
5704 * character.h (ASCII_CHAR_P): Move from here ...
5705 * lisp.h: ... to here, so that the inline functions mentioned
5706 above can use them.
5707
4a6bea26
PE
5708 * dired.c (directory_files_internal_unwind): Now static.
5709
f14b7e14
PE
5710 * fileio.c (file_name_as_directory, directory_file_name):
5711 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5712 Now static.
2893f146
PE
5713 (file_name_as_directory): Use const pointers when appropriate.
5714 (Fexpand_file_name): Likewise. In particular, newdir might
5715 point at constant storage, so make it a const pointer.
fd4ead52 5716 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5717 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5718 signedness issues.
f839df0c
PE
5719 (Fset_file_times, Finsert_file_contents, auto_save_error):
5720 Rename locals to avoid shadowing.
f14b7e14 5721
5716756e 5722 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5723 (Ftry_completion, Fall_completions): Rename or remove locals
5724 to avoid shadowing.
5716756e 5725
b4c3046a
PE
5726 * marker.c (bytepos_to_charpos): Remove; unused.
5727
b45db522
PE
5728 * lisp.h (verify_bytepos, count_markers): New decls,
5729 so that gcc does not warn that these functions aren't declared.
5730
85876d07
PE
5731 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5732 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5733 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5734 (copy_text): Remove unused local var.
85876d07 5735
03d78a21 5736 * filelock.c (within_one_second): Now static.
b3dd38ab 5737 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5738
5df8f01b
PE
5739 * buffer.c (fix_overlays_before): Mark locals as initialized.
5740 (fix_start_end_in_overlays): Likewise. This function should be
5741 simplified by using pointers-to-pointers, but that's a different
5742 matter.
b1d876f1 5743 (switch_to_buffer_1): Now static.
8f54f30a
PE
5744 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5745 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5746
a70072c9 5747 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5748 Fix pointer signedness issue.
edced198
PE
5749 (sys_subshell): Mark local as volatile if checking for lint,
5750 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5751 (MAXPATHLEN): Define only if needed.
a70072c9 5752
a0977c44
PE
5753 * process.c (serial_open, serial_configure): Move decls from here ...
5754 * systty.h: ... to here, so that they can be checked.
5755
a884fdcc
PE
5756 * fns.c (get_random, seed_random): Move extern decls from here ...
5757 * lisp.h: ... to here, so that they can be checked.
5758
604efe86 5759 * sysdep.c (reset_io): Now static.
b8950c94 5760 (wait_for_termination_signal): Remove; unused.
604efe86 5761
38fc62d9
PE
5762 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5763 (copy_keymap_item, append_key, push_text_char_description):
5764 Now static.
1004a21a 5765 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5766 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5767 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5768 (describe_map_tree):
5769 Rename locals to avoid shadowing.
38fc62d9 5770
2f2650da
PE
5771 * keyboard.c: Declare functions static if they are not used elsewhere.
5772 (echo_char, echo_dash, cmd_error, top_level_2):
5773 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5774 (read_char, kbd_buffer_get_event, make_lispy_position):
5775 (make_lispy_event, make_lispy_movement, apply_modifiers):
5776 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5777 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5778 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5779 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5780 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5781
a053e86c 5782 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5783 (mark_kboards): Move decl here ...
5784 * alloc.c (mark_kboards): ... from here.
a053e86c 5785
4752793e
PE
5786 * lisp.h (force_auto_save_soon): New decl.
5787
74f10ca7 5788 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5789 (DEFINE_DUMMY_FUNCTION): New macro.
5790 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5791 Use it.
c03cd23f
PE
5792 (main): Add casts to avoid warnings
5793 if GCC considers string literals to be constants.
74f10ca7 5794
022e70d4
PE
5795 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5796
59d6fe83
PE
5797 * dbusbind.c: Pointer signedness fixes.
5798 (xd_signature, xd_append_arg, xd_initialize):
5799 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5800 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5801 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5802 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5803
78320123
PE
5804 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5805 if GCC considers string literals to be constants.
49cebcca 5806 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5807
35ac2a97
SM
58082011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5809
fb103ca9
SM
5810 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5811 (print_preprocess, print_object): New macro to fix last change.
5812
35ac2a97
SM
5813 * print.c (print_preprocess): Don't forget font objects.
5814
62973b41
JB
58152011-03-16 Juanma Barranquero <lekktu@gmail.com>
5816
5817 * emacs.c (USAGE3): Doc fixes.
5818
0e48bb22
AS
58192011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5820
5821 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5822 structure.
5823
7684e57b
JB
58242011-03-14 Juanma Barranquero <lekktu@gmail.com>
5825
5826 * lisp.h (VWindow_system, Qfile_name_history):
5827 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5828 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5829 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5830
5831 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5832 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5833
5834 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5835 * w32console.c (detect_input_pending, read_input_pending)
5836 (encode_terminal_code):
5837 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5838 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5839 (w32_system_caret_y, Qfile_name_history):
5840 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5841 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5842 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5843 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5844 * w32proc.c (Qlocal, report_file_error):
5845 * w32term.c (Vwindow_system, updating_frame):
5846 * w32uniscribe.c (initialized, uniscribe_font_driver):
5847 Remove unneeded extern declarations.
5848
2aa46d6c
CY
58492011-03-14 Chong Yidong <cyd@stupidchicken.com>
5850
c96bbc66 5851 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5852
cffc6f3b
CY
58532011-03-13 Chong Yidong <cyd@stupidchicken.com>
5854
5855 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5856 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5857 These macros can no longer be used for assignment.
5858
44f230aa
SM
5859 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5860 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5861 (record_buffer_markers, fetch_buffer_markers): New functions for
5862 recording and fetching special buffer markers.
5863 (set_buffer_internal_1, set_buffer_temp): Use them.
5864
5865 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5866
5867 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5868
5869 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5870 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5871
5872 * xdisp.c (hscroll_window_tree):
5873 (reconsider_clip_changes): Use PT instead of BUF_PT.
5874
d251f04b
EZ
58752011-03-13 Eli Zaretskii <eliz@gnu.org>
5876
5877 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5878 $(EMACS_ROOT)/lib/intprops.h.
5879
f0c77cd1
PE
58802011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5881
3eca4629
PE
5882 Fix more problems found by GCC 4.5.2's static checks.
5883
7c86ee98
PE
5884 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5885 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5886 (xg_free_frame_widgets): Make it clear that a local variable is
5887 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5888 (gdk_window_get_screen): Make it clear that this macro is needed
5889 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5890 (int_gtk_range_get_value): New function, which avoids a diagnostic
5891 from gcc -Wbad-function-cast.
5892 (xg_set_toolkit_scroll_bar_thumb): Use it.
5893 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5894 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5895 (get_utf8_string, xg_get_file_with_chooser):
5896 Rename locals to avoid shadowing.
5897 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5898
41729b81
PE
5899 * xgselect.c (xg_select): Remove unused var.
5900
f0c77cd1
PE
5901 * image.c (four_corners_best): Mark locals as initialized.
5902 (gif_load): Initialize transparent_p to zero (Bug#8238).
5903 Mark another local as initialized.
ec6cf4c6 5904 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5905
ce0ad53d 5906 * image.c (clear_image_cache): Now static.
d5d5a617 5907 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5908 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5909 (x_edge_detection): Remove unnecessary cast that
5910 gcc -Wbad-function-cast diagnoses.
2037898d 5911 (gif_load): Fix pointer signedness.
6ae141d6
PE
5912 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5913 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5914
33383987 59152011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5916
d32df629
PE
5917 Improve quality of tests for time stamp overflow.
5918 For example, without this patch (encode-time 0 0 0 1 1
5919 1152921504606846976) returns the obviously-bogus value (-948597
5920 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5921 reports time overflow. See
5922 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5923 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5924 * editfns.c: Include limits.h and intprops.h.
5925 (TIME_T_MIN, TIME_T_MAX): New macros.
5926 (time_overflow): Move earlier, to before first use.
5927 (hi_time, lo_time): New functions, for an accurate test for
5928 out-of-range times.
5929 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5930 (Fget_internal_run_time): Don't assume time_t fits in int.
5931 (make_time): Use list2 instead of Fcons twice.
5932 (Fdecode_time): More accurate test for out-of-range times.
5933 (check_tm_member): New function.
5934 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5935 (lisp_time_argument): Don't rely on undefined left-shift and
5936 right-shift behavior when checking for time stamp overflow.
8be6f318 5937
fe31d94c
PE
5938 * editfns.c (time_overflow): New function, refactoring common code.
5939 (Fformat_time_string, Fdecode_time, Fencode_time):
5940 (Fcurrent_time_string): Use it.
5941
8be6f318
PE
5942 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5943 * dired.c (make_time): Move to ...
5944 * editfns.c (make_time): ... here.
5945 * systime.h: Note the move.
5946
09d9db2c 59472011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5948
126bc0dc
YM
5949 * fringe.c (update_window_fringes): Remove unused variables.
5950
c47cbdfd
YM
5951 * unexmacosx.c (copy_data_segment): Also copy __got section.
5952 (Bug#8223)
5953
7ac80be9
EZ
59542011-03-12 Eli Zaretskii <eliz@gnu.org>
5955
c96bbc66 5956 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5957 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5958 Constify `char *' arguments and their references according to
5959 prototypes in tparam.h.
5960
ecb0f94d 5961 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5962
7ac80be9
EZ
5963 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5964 Adapt all references accordingly.
5965
5966 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5967
ef1fd07e
TT
59682011-03-11 Tom Tromey <tromey@redhat.com>
5969
5970 * buffer.c (syms_of_buffer): Remove obsolete comment.
5971
7ef4b50c
EZ
59722011-03-11 Eli Zaretskii <eliz@gnu.org>
5973
5974 * termhooks.h (encode_terminal_code): Declare prototype.
5975
5976 * msdos.c (encode_terminal_code): Don't declare prototype.
5977
5978 * term.c (encode_terminal_code): Now external again, used by
5979 w32console.c and msdos.c.
5980
44f230aa
SM
5981 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5982 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5983
4b1ec863 59842011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5985
1714f52b 5986 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5987
4b1ec863
PE
5988 * fringe.c (update_window_fringes): Mark locals as initialized
5989 (Bug#8227).
5990 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5991
524c7aa6
PE
5992 * alloc.c (mark_fringe_data): Move decl from here ...
5993 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5994 to check its interface.
5995 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5996
a5c0af81 5997 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5998 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5999 (fontset_font): Mark local as initialized.
a9a06e0b 6000 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6001
b4716021
PE
6002 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6003
811e9bac 6004 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6005 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6006 (x_own_selection, Fx_disown_selection_internal): Rename locals
6007 to avoid shadowing.
6008 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6009
7e3ab302
PE
6010 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6011 so that the caller can use some name other than gcpro1.
6012 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6013 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6014 (Fx_backspace_delete_keys_p):
6015 Use them to avoid shadowing, and rename vars to avoid shadowing.
6016 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6017 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6018 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6019 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6020 Remove unused locals.
7e3ab302
PE
6021 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6022 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6023 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6024 macros.
f78faa98 6025
e2b13473
PE
6026 * xterm.h (x_mouse_leave): New decl.
6027
77f23912
PE
6028 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6029 Remove unused functions.
cdf4ba58
PE
6030 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6031 (x_calc_absolute_position): Now static.
7411c686 6032 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6033 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6034 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6035 unless they are used.
38d0b34a
PE
6036 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6037 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6038 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6039 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6040 (x_error_catcher, x_connection_closed, x_error_handler):
6041 (x_error_quitter, xembed_send_message, x_iconify_frame):
6042 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6043 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6044 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6045
44f230aa
SM
6046 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6047 Rename or move locals to avoid shadowing.
6b463e58 6048 (tty_defined_color, merge_face_heights): Now static.
5967d051 6049 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6050 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6051 does not deduce is never used uninitialized.
73719eba
PE
6052 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6053 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6054
426994c3 6055 * terminal.c (store_terminal_param): Now static.
5489860b 6056
032f1620 6057 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6058 (set_frame_menubar): Remove unused local.
d4323972 6059 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6060 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6061 since they might point to immutable storage.
281585b0
PE
6062 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6063 since it's unused otherwise.
032f1620 6064
367c19e5 6065 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6066 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6067 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6068 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6069 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6070 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6071 does not deduce are never used uninitialized.
70739cbe 6072
07b48fa9
PE
6073 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6074
8868a238 6075 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6076 * window.c (window_loop, size_window):
6077 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6078
7e5cf297 6079 * window.c (display_buffer): Now static.
d6550a9f
PE
6080 (size_window): Mark variables that gcc -Wuninitialized
6081 does not deduce are never used uninitialized.
a586633d
PE
6082 * window.h (check_all_windows): New decl, to forestall
6083 gcc -Wmissing-prototypes diagnostic.
5b555da1 6084 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6085
f6095868
PE
6086 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6087 shadowing.
6088 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6089 Include <limits.h>.
6090 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6091 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6092 (load_charset_map): Mark variables that gcc -Wuninitialized
6093 does not deduce are never used uninitialized.
53df7c11 6094 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6095
f38b440c
PE
6096 * coding.c (coding_set_source, coding_set_destination):
6097 Use "else { /* comment */ }" rather than "else /* comment */;"
6098 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6099 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6100 a block, when the outer 'i' will do.
6101 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6102 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6103 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6104 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6105 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6106 Rename locals to avoid shadowing.
6107 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6108 * coding.c (emacs_mule_char, encode_invocation_designation):
6109 Now static, since they're not used elsewhere.
413bb2db 6110 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6111 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6112 (decode_coding_emacs_mule): Mark variables that gcc
6113 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6114 (detect_coding_iso_2022): Initialize a local variable that might
6115 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6116 this initialization is needed. (Bug#8211)
5f58e762
PE
6117 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6118 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6119 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6120 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6121 Remove unused macros.
f38b440c 6122
232b38b9 6123 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6124 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6125 * character.c (string_count_byte8): Likewise.
232b38b9 6126
fb90da1b
PE
6127 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6128 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6129
fb93dbc2
PE
6130 * chartab.c (copy_sub_char_table): Now static, since it's not used
6131 elsewhere.
5c156ace
PE
6132 (sub_char_table_ref_and_range, char_table_ref_and_range):
6133 Rename locals to avoid shadowing.
bbcd0949 6134 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6135
7d3b3862 6136 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6137 (BIDI_BOB): Remove unused macro.
7d3b3862 6138
6be7d3da
PE
6139 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6140 deduce are never used uninitialized.
c2ed9c8b 6141 * term.c (encode_terminal_code): Likewise.
6be7d3da 6142
75f8807f 6143 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6144
50938595
PE
6145 * tparam.h: New file.
6146 * term.c, tparam.h: Include it.
6147 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6148 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6149 Move these decls to tparam.h, and make them agree with what
6150 is actually in tparam.c. The previous trick of using incompatible
6151 decls in different modules does not conform to the C standard.
6152 All callers of tparam changed to use tparam's actual API.
6153 * tparam.c (tparam1, tparam, tgoto):
6154 Use const pointers where appropriate.
6155
fbceeba2
PE
6156 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6157 * cm.h (struct cm): Likewise.
6158 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6159 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6160 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6161 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6162 (turn_on_face, init_tty): Likewise.
6163 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6164
7f3f1250
PE
6165 * term.c (term_mouse_position): Rename local to avoid shadowing.
6166
e6ca6543
PE
6167 * alloc.c (mark_ttys): Move decl from here ...
6168 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6169
c40f8d15
AS
61702011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6171
6172 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6173
cfe0661d
JB
61742011-03-09 Juanma Barranquero <lekktu@gmail.com>
6175
6176 * search.c (compile_pattern_1): Remove argument regp, unused since
6177 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6178 (compile_pattern): Don't pass it.
6179
0afb4571
J
61802011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6181
6182 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6183 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6184 for ! HAVE_GTK3.
6185 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6186
6187 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6188
6189 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6190 gdk_window_get_screen, gdk_window_get_geometry,
6191 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6192 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6193 (xg_get_pixbuf_from_pixmap): New function.
6194 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6195 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6196 Call xg_get_pixbuf_from_pixmap instead of
6197 gdk_pixbuf_get_from_drawable.
6198 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6199 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6200 (xg_check_special_colors): Use GtkStyleContext and its functions
6201 for HAVE_GTK3.
6202 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6203 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6204 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6205 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6206 Call gtk_widget_get_preferred_size.
0afb4571
J
6207 (xg_frame_resized): gdk_window_get_geometry only takes 5
6208 parameters.
44f230aa
SM
6209 (xg_win_to_widget, xg_event_is_for_menubar):
6210 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6211 (xg_set_widget_bg): New function.
6212 (delete_cb): New function.
895009e1 6213 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6214 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6215 (xg_set_background_color): Call xg_set_widget_bg.
6216 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6217 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6218 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6219 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6220 if ! HAVE_GTK3.
6221 (update_frame_tool_bar): Call gtk_widget_hide.
6222 (xg_initialize): Use GDK_KEY_g.
6223
6224 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6225 if ! HAVE_GTK3
6226 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6227
6228 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6229 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6230 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6231
1c2cc4ef
JB
62322011-03-08 Juanma Barranquero <lekktu@gmail.com>
6233
6234 * w32xfns.c (select_palette): Check success of RealizePalette against
6235 GDI_ERROR, not zero.
6236
33383987 6237See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6238
6239;; Local Variables:
6240;; coding: utf-8
aac0c6e3
MR
6241;; End:
6242
33383987 6243 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6244
6245 This file is part of GNU Emacs.
6246
6247 GNU Emacs is free software: you can redistribute it and/or modify
6248 it under the terms of the GNU General Public License as published by
6249 the Free Software Foundation, either version 3 of the License, or
6250 (at your option) any later version.
6251
6252 GNU Emacs is distributed in the hope that it will be useful,
6253 but WITHOUT ANY WARRANTY; without even the implied warranty of
6254 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6255 GNU General Public License for more details.
6256
6257 You should have received a copy of the GNU General Public License
6258 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.