Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
856bbc81 12011-09-26 Paul Eggert <eggert@cs.ucla.edu>
d311d28c
PE
2
3 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
4 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
5 (string_bytes, check_sblock, allocate_string_data):
6 (compact_small_strings, Fmake_bool_vector, make_string)
7 (make_unibyte_string, make_multibyte_string)
8 (make_string_from_bytes, make_specified_string)
9 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
10 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
11 (mark_vectorlike):
12 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
13 (allocate_pseudovector):
14 Use int, not EMACS_INT, where int is wide enough.
15 (inhibit_garbage_collection, Fgarbage_collect):
16 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
17 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
18 int might not be wide enough.
19 (bidi_cache_search, bidi_cache_find, bidi_init_it)
20 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
21 (bidi_at_paragraph_end, bidi_find_paragraph_start)
22 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
23 (bidi_level_of_next_char, bidi_move_to_visually_next):
24 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
25 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
26 (Fkill_buffer, Fset_buffer_major_mode)
27 (advance_to_char_boundary, Fbuffer_swap_text)
28 (Fset_buffer_multibyte, overlays_at, overlays_in)
29 (overlay_touches_p, struct sortvec, record_overlay_string)
30 (overlay_strings, recenter_overlay_lists)
31 (adjust_overlays_for_insert, adjust_overlays_for_delete)
32 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
33 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
34 (Foverlay_recenter, last_overlay_modification_hooks_used)
35 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
36 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
37 (validate_region): Omit unnecessary test for b <= e, since
38 that's guaranteed by the previous test.
39 (adjust_overlays_for_delete): Avoid pos + length overflow.
40 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
41 (report_overlay_modification):
42 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
43 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
44 Omit pointer cast, which isn't needed anyway, and doesn't work
45 after the EMACS_INT -> ptrdiff_t change.
46 * buffer.h: Adjust decls to match defn changes elsewhere.
47 (struct buffer_text, struct buffer):
48 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
49 Use EMACS_INT, not int, where int might not be wide enough.
50 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, to avoid
51 needless 32-bit limit on 64-bit hosts. Remove unnecessary
52 memory-full test. Use EMACS_INT, not ptrdiff_t or int, where
53 ptrdiff_t or int might not be wide enough.
54 * callint.c (Fcall_interactively):
55 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
56 * callproc.c (call_process_kill, Fcall_process):
57 Don't assume pid_t fits into an Emacs fixnum.
58 (call_process_cleanup, Fcall_process, child_setup):
59 Don't assume pid_t fits into int.
60 (call_process_cleanup, Fcall_process, delete_temp_file)
61 (Fcall_process_region):
62 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
63 (Fcall_process): Simplify handling of volatile integers.
64 Use int, not EMACS_INT, where int will do.
65 * casefiddle.c (casify_object, casify_region, operate_on_word)
66 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
67 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
68 (casify_object): Avoid integer overflow when overallocating buffer.
69 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 70 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
71 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
72 * category.h (CATEGORYP): Don't assume arg is nonnegative.
73 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
74 integers are now checked earlier. All uses replaced with XINT.
75 (ccl_driver):
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 For CCL_MapSingle, check that content and value are in int range.
78 (resolve_symbol_ccl_program): Check that vector header is in range.
79 Always copy the vector, so that we can check its contents reliably
80 now rather than having to recheck each instruction as it's being
81 executed. Check that vector words fit in 'int'.
82 (ccl_get_compiled_code, Fregister_ccl_program)
83 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
84 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
85 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
86 contents are in range.
87 (Fccl_execute_on_string): Check that status is in range.
88 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
89 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
90 Accept and return EMACS_INT, not int, because callers can pass values
91 out of 'int' range.
92 (c_string_width, strwidth, lisp_string_width, chars_in_text)
93 (multibyte_chars_in_text, parse_str_as_multibyte)
94 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
95 (str_as_unibyte, str_to_unibyte, string_count_byte8)
96 (string_escape_byte8, Fget_byte):
97 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
98 (Funibyte_string): Use CHECK_CHARACTER, not CHECK_NATNUM, to
99 avoid mishandling large integers.
100 * character.h: Adjust decls to match defn changes elsewhere.
101 * charset.c (load_charset_map_from_file, find_charsets_in_text)
102 (Ffind_charset_region):
103 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
104 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
105 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 106 Don't assume fixnum fits in int.
d311d28c
PE
107 (load_charset_map_from_vector, Fmap_charset_chars):
108 Remove now-unnecessary CHECK_NATNUMs.
109 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
110 Don't rely on undefined behavior with signed left shift overflow.
111 Don't assume unsigned int fits into fixnum, or that fixnum fits
112 into unsigned int. Don't require max_code to be a valid fixnum;
113 that's not true for gb10830 4-byte on a 32-bit host. Allow
114 invalid_code to be a cons, for the same reason. Require code_offset
115 to be a character. Avoid int overflow if max_char is close
116 to INT_MAX.
117 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
118 this is intended anyway and avoids some undefined behavior.
119 (load_charset_map): Pass unsigned, not int, as 2nd arg of
120 INDEX_TO_CODE_POINT, as that's what it expects.
121 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
122 * charset.h (DECODE_CHAR): Return int, not unsigned;
123 this is what was intended anyway, and it avoids undefined behavior.
124 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
125 integer-overflow issues.
126 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
127 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
128 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
129 * chartab.c (Fmake_char_table, Fset_char_table_range)
130 (uniprop_get_decoder, uniprop_get_encoder):
131 Don't assume fixnum fits in int.
132 * cmds.c (move_point): New function, that does the gist of
133 Fforward_char and Fbackward_char, but does so while checking
134 for integer overflow more accurately.
135 (Fforward_char, Fbackward_char, internal_self_insert): Use it.
136 (Fforward_line, Fend_of_line, internal_self_insert)
137 (internal_self_insert):
138 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
139 Fix a FIXME, by checking for integer overflow when calculating
140 target_clm and actual_clm.
141 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
142 (ASSURE_DESTINATION, coding_alloc_by_realloc)
143 (coding_alloc_by_making_gap, alloc_destination)
144 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
145 (encode_coding_utf_16, detect_coding_emacs_mule)
146 (decode_coding_emacs_mule, encode_coding_emacs_mule)
147 (detect_coding_iso_2022, decode_coding_iso_2022)
148 (encode_invocation_designation, encode_designation_at_bol)
149 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
150 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
151 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
152 (encode_coding_ccl, encode_coding_raw_text)
153 (detect_coding_charset, decode_coding_charset)
154 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
155 (produce_composition, produce_charset, produce_annotation)
156 (decode_coding, handle_composition_annotation)
157 (handle_charset_annotation, consume_chars, decode_coding_gap)
158 (decode_coding_object, encode_coding_object, detect_coding_system)
159 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
160 (code_convert_region, code_convert_string)
161 (Fdefine_coding_system_internal):
162 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
163 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
164 (Fdefine_coding_system_internal):
165 Don't assume fixnums fit in int.
166 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9
PE
167 (Fread_coding_system, Fdetect_coding_region)
168 (Funencodable_char_position, Fcheck_coding_systems_region):
d311d28c
PE
169 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
170 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
171 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
172 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
173 result of ENCODE_CHAR.
d311d28c
PE
174 * coding.h: Adjust decls to match defn changes elsewhere.
175 (struct coding_system):
176 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
177 * composite.c (get_composition_id, find_composition)
178 (run_composition_function, update_compositions)
179 (compose_text, composition_gstring_put_cache)
180 (composition_gstring_p, composition_gstring_width)
181 (fill_gstring_header, fill_gstring_body, autocmp_chars)
182 (composition_compute_stop_pos, composition_reseat_it)
183 (composition_update_it, struct position_record)
184 (find_automatic_composition, composition_adjust_point)
185 (Fcomposition_get_gstring, Ffind_composition_internal):
186 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
187 (update_compositions):
188 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
189 * composite.h: Adjust decls to match defn changes elsewhere.
190 (struct composition):
191 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
192 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
193 Do not attempt to compute the address of the object just before a
194 buffer; this is not portable.
195 (Faref, Faset):
196 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
197 (Faset): Use int, not EMACS_INT, where int is wide enough.
198 (Fstring_to_number): Don't assume fixnums fit in int.
199 (Frem): Don't assume arg is nonnegative.
200 * dbusbind.c (xd_append_arg): Check for integers out of range.
201 (Fdbus_call_method): Don't overflow the timeout int.
202 * dired.c (directory_files_internal, file_name_completion, scmp)
203 (file_name_completion_stat):
204 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
205 (file_name_completion): Don't overflow matchcount.
206 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
207 * dispextern.h: Adjust decls to match defn changes elsewhere.
208 (struct text_pos, struct glyph, struct bidi_saved_info)
209 (struct bidi_string_data, struct bidi_it, struct composition_it)
210 (struct it):
211 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
212 (struct display_pos, struct composition_it, struct it):
213 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
214 * dispnew.c (increment_matrix_positions)
215 (increment_row_positions, mode_line_string)
216 (marginal_area_string):
217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
218 (change_frame_size_1, Fredisplay):
219 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
220 (duration_to_sec_usec): New function, to check for overflow better.
221 (Fsleep_for, sit_for): Use it.
222 * doc.c (get_doc_string, store_function_docstring):
223 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
224 (get_doc_string, Fsnarf_documentation):
225 Use int, not EMACS_INT, where int is wide enough.
226 (get_doc_string):
227 Use SAFE_ALLOCA, not alloca.
228 Check for overflow when converting EMACS_INT to off_t.
229 * doprnt.c (doprnt):
230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
231 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
232 Don't assume uid_t fits into fixnum.
233 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
234 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
235 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
236 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
237 (general_insert_function)
238 (Finsert_char, make_buffer_string, make_buffer_string_both)
239 (update_buffer_properties, Fbuffer_substring)
240 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
241 (Fsubst_char_in_region, check_translation)
242 (Ftranslate_region_internal, save_restriction_restore, Fformat)
243 (transpose_markers, Ftranspose_regions):
244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
245 (clip_to_bounds): Move to lisp.h as an inline function).
246 (Fconstrain_to_field): Don't assume integers are nonnegative.
247 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
248 (Fsubst_char_in_region, Fsave_restriction):
249 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
250 (Femacs_pid): Don't assume pid_t fits into fixnum.
251 (lo_time): Use int, not EMACS_INT, when int suffices.
252 (lisp_time_argument): Check for usec out of range.
253 (Fencode_time): Don't assume fixnum fits in int.
254 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
255 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
256 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
257 (init_cmdargs, Fdump_emacs):
258 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
259 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
260 the bottom (typically) 32 bits of the fixnum.
261 * eval.c (specpdl_size, call_debugger):
262 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
263 (when_entered_debugger, Fbacktrace_debug):
264 Don't assume fixnum can fit in int.
265 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
266 the object just before a buffer; this is not portable.
267 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
268 (grow_specpdl, unbind_to):
269 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
270 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
271 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 272 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
273 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
274 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
275 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
276 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
277 (a_write, e_write):
278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
279 (Fcopy_file, non_regular_nbytes, read_non_regular)
280 (Finsert_file_contents):
281 Use int, not EMACS_INT, where int is wide enough.
282 (READ_BUF_SIZE): Verify that it fits in int.
283 (Finsert_file_contents): Check that counts are in proper range,
284 rather than assuming fixnums fit into ptrdiff_t etc.
285 Don't assume fixnums fit into int.
286 (Fdo_auto_save, Fset_buffer_auto_saved)
287 (Fclear_buffer_auto_save_failure):
288 Don't assume time_t is signed, or that it fits in int.
5895d7b9
PE
289 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
290 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
291 (string_char_to_byte, string_byte_to_char)
292 (string_make_multibyte, string_to_multibyte)
293 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
294 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
295 (substring_both, Fdelete, internal_equal, Ffillarray)
296 (Fclear_string, mapcar1)
297 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
298 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
299 (larger_vector, make_hash_table, maybe_resize_hash_table)
300 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
301 (Fmaphash, secure_hash):
302 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
303 (concat): Check for string index and length overflow.
304 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
305 (Frequire):
306 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
307 (larger_vector): New API (vec, incr_min, size_max) replaces old
308 one (vec, new_size, init). This catches size overflow.
309 INIT was removed because it was always Qnil.
310 All callers changed.
311 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
312 the upper bound on a hash table index size.
313 (make_hash_table, maybe_resize_hash_table): Use it.
314 (secure_hash): Computer start_byte and end_byte only after
315 they're known to be in ptrdiff_t range.
316 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
317 (Ffont_get_glyphs, Ffont_at):
318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
319 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
320 (Flist_fonts, Fopen_font):
321 Don't assume fixnum can fit in int.
322 (check_gstring): Don't assume index can fit in int.
323 (font_match_p): Check that fixnum is a character, not a nonnegative
324 fixnum, since the later code needs to stuff it into an int.
325 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
326 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
327 conversion overflow issues.
328 (Fopen_font): Check for integer out of range.
329 (Ffont_get_glyphs): Don't assume index can fit in int.
330 * font.h: Adjust decls to match defn changes elsewhere.
331 * fontset.c (reorder_font_vector): Redo score calculation to avoid
332 integer overflow.
333 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
334 printmax_t, where ptrdiff_t is wide enough.
335 (Finternal_char_font):
336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
337 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
338 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
339 (Fset_frame_position, x_set_frame_parameters)
340 (x_set_line_spacing, x_set_border_width)
341 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
342 Check that fixnums are in proper range for system types.
343 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
344 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
345 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
346 Use SAFE_ALLOCA_LISP, not alloca.
347 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
348 intptr_t is wide enough.
349 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
350 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
351 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
352 Check for fixnum out of range.
353 * ftfont.c (ftfont_list): Don't assume index fits in int.
354 Check that fixnums are in proper range for system types.
355 (ftfont_shape_by_flt):
356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
357 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
358 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
359 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
360 Check that fixnums are in proper range for system types.
361 * gnutls.h: Adjust decls to match defn changes elsewhere.
362 * gtkutil.c (xg_dialog_run):
363 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
364 (update_frame_tool_bar):
365 Check that fixnums are in proper range for system types.
366 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 367 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
368 * indent.c (last_known_column, last_known_column_point):
369 (current_column_bol_cache):
370 (skip_invisible, current_column, check_display_width):
371 (check_display_width, scan_for_column, current_column_1)
372 (Findent_to, Fcurrent_indentation, position_indentation)
373 (indented_beyond_p, Fmove_to_column, compute_motion):
374 (Fcompute_motion, Fvertical_motion):
375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
376 (last_known_column_modified): Use EMACS_INT, not int.
377 (check_display_width):
378 (Fcompute_motion):
379 Check that fixnums and floats are in proper range for system types.
380 (compute_motion): Don't assume index or fixnum fits in int.
381 (compute_motion, Fcompute_motion):
382 Use int, not EMACS_INT, when it is wide enough.
383 (vmotion): Omit local var start_hpos that is always 0; that way
384 we don't need to worry about overflow in expressions involving it.
385 * indent.h: Adjust decls to match defn changes elsewhere.
386 (struct position):
387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
388 Use int, not EMACS_INT, where int is wide enough.
389 Remove unused members ovstring_chars_done and tab_offset;
390 all uses removed.
391 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
392 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
393 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
394 (make_gap, copy_text, insert, insert_and_inherit)
395 (insert_before_markers, insert_before_markers_and_inherit)
396 (insert_1, count_combining_before, count_combining_after)
397 (insert_1_both, insert_from_string)
398 (insert_from_string_before_markers, insert_from_string_1)
399 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
400 (adjust_after_replace, adjust_after_insert, replace_range)
401 (replace_range_2, del_range, del_range_1, del_range_byte)
402 (del_range_both, del_range_2, modify_region)
403 (prepare_to_modify_buffer, signal_before_change)
404 (signal_after_change, Fcombine_after_change_execute):
405 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
406 * intervals.c (traverse_intervals, rotate_right, rotate_left)
407 (balance_an_interval, split_interval_right, split_interval_left)
408 (find_interval, next_interval, update_interval)
409 (adjust_intervals_for_insertion, delete_node, delete_interval)
410 (interval_deletion_adjustment, adjust_intervals_for_deletion)
411 (static_offset_intervals, offset_intervals)
412 (merge_interval_right, merge_interval_left, make_new_interval)
413 (graft_intervals_into_buffer, temp_set_point_both)
414 (temp_set_point, set_point, adjust_for_invis_intang)
415 (set_point_both, move_if_not_intangible, get_property_and_range)
416 (get_local_map, copy_intervals, copy_intervals_to_string)
417 (compare_string_intervals, set_intervals_multibyte_1):
418 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
419 * intervals.h: Adjust decls to match defn changes elsewhere.
420 (struct interval):
421 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
422 * keyboard.c (this_command_key_count, this_single_command_key_start)
423 (before_command_key_count, before_command_echo_length, echo_now)
424 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
425 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
426 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
427 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
428 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
429 (last_non_minibuf_size, last_point_position, echo_truncate)
430 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
431 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
432 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
433 (stuff_buffered_input):
434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
435 (last_auto_save, command_loop_1, read_char):
436 Use EMACS_INT, not int, to avoid integer overflow.
437 (record_char): Avoid overflow in total_keys computation.
438 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
439 * keyboard.h: Adjust decls to match defn changes elsewhere.
440 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
441 (Fkey_description, Fdescribe_vector, Flookup_key):
442 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
443 (click_position): New function, to check that positions are in range.
444 (Fcurrent_active_maps):
445 (describe_command):
446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
447 (Faccessible_keymaps, Fkey_description):
448 (preferred_sequence_p):
449 Don't assume fixnum can fit into int.
450 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
451 Check for integer overflow in size calculations.
452 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
453 avoid mishandling large integers.
454 * lisp.h: Adjust decls to match defn changes elsewhere.
455 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
456 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
457 (struct Lisp_Marker):
458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
459 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
460 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
461 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
462 All callers changed.
463 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
464 Assume the arg has valid form, since it always does.
465 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
466 unsigned integer system type.
467 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
468 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
469 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
470 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
471 (duration_to_sec_usec): New decl.
472 * lread.c (read_from_string_index, read_from_string_index_byte)
473 (read_from_string_limit, readchar, unreadchar, openp)
474 (read_internal_start, read1, oblookup):
475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
476 (Fload, readevalloop, Feval_buffer, Feval_region):
477 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
478 (openp): Check for out-of-range argument to 'access'.
479 (read1): Use int, not EMACS_INT, where int is wide enough.
480 Don't assume fixnum fits into int.
1ab7b8ac
PE
481 (read_filtered_event): Use duration_to_sec_usec
482 to do proper overflow checking on durations.
d311d28c
PE
483 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
484 in size calculation.
485 (Fexecute_kbd_macro):
486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
487 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
488 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
489 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
490 (set_marker_both, set_marker_restricted_both, marker_position)
491 (marker_byte_position, Fbuffer_has_markers_at):
492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
493 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
494 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
495 It now merely ensures that the menu is large enough, without
496 necessarily growing it, as this avoids some integer overflow issues.
497 All callers changed.
498 (keymap_panes, parse_single_submenu, Fx_popup_menu):
499 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
500 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
501 Use SAFE_ALLOCA_LISP, not alloca.
502 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
503 to EMACS_INT. Check that fixnums are in proper range for system types.
504 * minibuf.c (minibuf_prompt_width, string_to_object)
505 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
506 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
507 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
508 (get_minibuffer, read_minibuf_unwind):
509 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
510 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
511 this simplifies overflow checking. All callers changed.
512 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
513 (Ftest_completion):
514 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
515 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
516 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
517 Check that fixnums are in proper range for system types.
518 (Fx_create_frame, Fx_show_tip):
519 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
520 * nsfont.m (ns_findfonts, nsfont_list_family):
521 Don't assume fixnum fits in long.
522 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
523 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
524 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
525 wide enough.
526 * nsselect.m (ns_get_local_selection):
527 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
528 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
529 (PRINTDECLARE, PRINTPREPARE):
530 (strout, print_string):
531 (print, print_preprocess, print_check_string_charset_prop)
532 (print_object):
533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
534 (PRINTDECLARE):
535 (temp_output_buffer_setup, Fprin1_to_string, print_object):
536 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
537 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
538 (PRINTFINISH): Use SAFE_ALLOCA, not alloca.
539 (printchar, strout): Use xpalloc to catch size calculation overflow.
540 (Fexternal_debugging_output): Use CHECK_CHARACTER, not CHECK_NUMBER,
541 to avoid mishandling large integers.
542 (print_error_message): Use SAFE_ALLOCA, not alloca.
543 (print_object): Use int, not EMACS_INT, where int is wide enough.
544 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
545 (Fset_process_window_size, Fformat_network_address)
546 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
547 (Fsignal_process, sigchld_handler):
548 Check that fixnums are in proper range for system types.
549 (Fformat_network_address, read_process_output, send_process)
550 (Fprocess_send_region, status_notify):
551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
552 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
553 (wait_reading_process_output, read_process_output, exec_sentinel):
554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
555 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
556 (Faccept_process_output): Use duration_to_sec_usec to do proper
557 overflow checking on durations.
b62b53e8
PE
558 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
559 configured --with-wide-int.
d311d28c
PE
560 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
561 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
562 * search.c (looking_at_1, string_match_1):
563 (fast_string_match, fast_c_string_match_ignore_case)
564 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
565 (scan_newline, find_before_next_newline, search_command)
566 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
567 (set_search_regs, wordify):
568 (Freplace_match):
569 (Fmatch_data):
570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
571 (string_match_1, search_buffer, set_search_regs):
572 (Fmatch_data):
573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
574 (wordify): Check for overflow in size calculation.
575 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
576 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
577 Check that fixnums are in proper range for system types.
578 * sound.c (struct sound_device)
579 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
581 (Fplay_sound_internal):
582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
583 * syntax.c (ST_COMMENT_STYLE, ST_STRING_STYLE):
584 In definitions, make it clearer that these values must be out of range
5895d7b9
PE
585 for the respective integer ranges. This fixes a bug with
586 ST_STRING_STYLE and non-ASCII characters.
d311d28c
PE
587 (struct lisp_parse_state, find_start_modiff)
588 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
589 (Fparse_partial_sexp):
590 Don't assume fixnums can fit in int.
591 (struct lisp_parse_state, find_start_pos, find_start_value)
592 (find_start_value_byte, find_start_begv)
593 (update_syntax_table, char_quoted, dec_bytepos)
594 (find_defun_start, prev_char_comend_first, back_comment):
595 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
596 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
598 (Finternal_describe_syntax_value): Check that match_lisp is a
599 character, not an integer, since the code stuffs it into int.
600 (scan_words, scan_sexps_forward):
601 Check that fixnums are in proper range for system types.
602 (Fforward_word):
603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
604 (scan_sexps_forward):
605 Use CHARACTERP, not INTEGERP, since the value must fit into int.
606 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
607 * syntax.h: Adjust decls to match defn changes elsewhere.
608 (struct gl_state_s):
609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
610 * sysdep.c (wait_for_termination_1, wait_for_termination)
611 (interruptible_wait_for_termination, mkdir):
612 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
613 (emacs_read, emacs_write):
614 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
615 (system_process_attributes): Don't assume uid_t, gid_t, and
616 double all fit in int or even EMACS_INT.
617 * term.c (set_tty_color_mode):
618 Check that fixnums are in proper range for system types.
619 * termhooks.h (struct input_event):
620 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
621 * textprop.c (validate_interval_range, interval_of)
622 (Fadd_text_properties, set_text_properties_1)
623 (Fremove_text_properties, Fremove_list_of_text_properties)
624 (Ftext_property_any, Ftext_property_not_all)
625 (copy_text_properties, text_property_list, extend_property_ranges)
626 (verify_interval_modification):
627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
628 (Fnext_single_char_property_change)
629 (Fprevious_single_char_property_change):
630 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
631 (copy_text_properties):
632 Check for integer overflow in index calculation.
d311d28c
PE
633 * undo.c (last_boundary_position, record_point, record_insert)
634 (record_delete, record_marker_adjustment, record_change)
635 (record_property_change):
636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
637 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
638 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
639 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
640 (Fx_hide_tip, Fx_file_dialog):
641 * w32menu.c (set_frame_menubar):
642 Use ptrdiff_t, not int, for consistency with rest of code.
643 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
644 (select_window, Fdelete_other_windows_internal)
645 (window_scroll_pixel_based, window_scroll_line_based)
646 (Frecenter, Fset_window_configuration):
647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
648 (Fset_window_hscroll, run_window_configuration_change_hook)
649 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 650 (Fscroll_other_window, Frecenter):
d311d28c
PE
651 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
652 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
653 Don't assume fixnum fits in int.
654 (Fset_window_scroll_bars):
655 Check that fixnums are in proper range for system types.
656 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
657 (string_pos, c_string_pos, number_of_chars, init_iterator)
658 (in_ellipses_for_invisible_text_p, init_from_display_pos)
659 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
660 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
661 (face_before_or_after_it_pos, handle_invisible_prop)
662 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
663 (display_prop_intangible_p, string_buffer_position_lim)
664 (string_buffer_position, handle_composition_prop, load_overlay_strings)
665 (get_overlay_strings_1, get_overlay_strings)
666 (iterate_out_of_display_property, forward_to_next_line_start)
667 (back_to_previous_visible_line_start, reseat, reseat_to_string)
668 (get_next_display_element, set_iterator_to_next)
669 (get_visually_first_element, compute_stop_pos_backwards)
670 (handle_stop_backwards, next_element_from_buffer)
671 (move_it_in_display_line_to, move_it_in_display_line)
672 (move_it_to, move_it_vertically_backward, move_it_by_lines)
673 (add_to_log, message_dolog, message_log_check_duplicate)
674 (message2, message2_nolog, message3, message3_nolog
675 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
676 (current_message_1, truncate_echo_area, truncate_message_1)
677 (set_message, set_message_1, store_mode_line_noprop)
678 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
679 (text_outside_line_unchanged_p, check_point_in_composition)
680 (reconsider_clip_changes)
681 (redisplay_internal, set_cursor_from_row, try_scrolling)
682 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
683 (redisplay_window, find_last_unchanged_at_beg_row)
684 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
685 (trailing_whitespace_p, find_row_edges, display_line)
686 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
687 (display_mode_element, store_mode_line_string)
688 (pint2str, pint2hrstr, decode_mode_spec)
689 (display_count_lines, display_string, draw_glyphs)
690 (x_produce_glyphs, x_insert_glyphs)
691 (rows_from_pos_range, mouse_face_from_buffer_pos)
692 (fast_find_string_pos, mouse_face_from_string_pos)
693 (note_mode_line_or_margin_highlight, note_mouse_highlight):
694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
695 (safe_call, init_from_display_pos, handle_fontified_prop)
696 (handle_single_display_spec, load_overlay_strings)
697 (with_echo_area_buffer, setup_echo_area_for_printing)
698 (display_echo_area, echo_area_display)
699 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
700 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
701 (redisplay_window, dump_glyph_row, display_mode_line)
702 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
d311d28c
PE
703 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
704 (handle_single_display_spec, build_desired_tool_bar_string)
705 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
706 (get_specified_cursor_type):
707 Check that fixnums are in proper range for system types.
708 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
709 (Flookup_image_map):
710 Don't assume fixnums fit in int.
711 (compare_overlay_entries):
712 Avoid mishandling comparisons due to subtraction overflow.
713 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
714 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
715 (handle_tool_bar_click):
716 Use int, not unsigned, since we prefer signed and the signedness
717 doesn't matter here.
718 (get_next_display_element, next_element_from_display_vector):
719 Use int, not EMACS_INT, when int is wide enough.
720 (start_hourglass): Use duration_to_sec_usec to do proper
721 overflow checking on durations.
722 * xfaces.c (Fbitmap_spec_p):
723 Check that fixnums are in proper range for system types.
724 (compare_fonts_by_sort_order):
725 Avoid mishandling comparisons due to subtraction overflow.
726 (Fx_family_fonts, realize_basic_faces):
727 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
728 (Fx_family_fonts):
729 Don't assume fixnum fits in int.
730 Use SAFE_ALLOCA_LISP, not alloca.
731 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
732 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
733 (face_at_buffer_position, face_for_overlay_string)
734 (face_at_string_position):
735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
736 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
737 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
738 (Fx_show_tip):
739 Check that fixnums are in proper range for system types.
740 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
741 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
742 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
743 (Fx_change_window_property): Don't assume fixnums fit in int.
744 * xfont.c (xfont_chars_supported):
745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
746 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
747 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
748 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
749 * xml.c (parse_region):
750 * xrdb.c (magic_file_p):
751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
752 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
753 (x_get_local_selection, x_reply_selection_request)
754 (x_handle_selection_request, wait_for_property_change):
755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
756 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
757 short is wide enough.
758 (x_send_client_event): Don't assume fixnum fits in int.
759 * xterm.c (x_x_to_emacs_modifiers):
760 Don't assume EMACS_INT overflows nicely into int.
761 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
762 may come from Lisp.
763 (handle_one_xevent): NATNUMP can eval its arg twice.
764 (x_connection_closed):
765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
766 * xterm.h: Adjust decls to match defn changes elsewhere.
767 (struct scroll_bar): Use struct vectorlike_header
768 rather than rolling our own approximation.
769 (SCROLL_BAR_VEC_SIZE): Remove; not used.
770
b2bf61aa
MA
7712011-09-25 Michael Albinus <michael.albinus@gmx.de>
772
773 * dbusbind.c (Fdbus_register_signal): When service is not
774 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
775
32bbb17c
GM
7762011-09-25 Glenn Morris <rgm@gnu.org>
777
778 * buffer.c (truncate-lines): Doc fix.
779
94e0933e
CY
7802011-09-24 Chong Yidong <cyd@stupidchicken.com>
781
782 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
783 (Fset_window_next_buffers): Doc fix.
784
cddde921
GM
7852011-09-24 Glenn Morris <rgm@gnu.org>
786
787 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
788
1260aef1
PE
7892011-09-24 Paul Eggert <eggert@cs.ucla.edu>
790
25b4bfa0
PE
791 Fix minor problems found by static checking.
792 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
793 * indent.c (Fvertical_motion): Fix == vs = typo.
794
e3cbd34b
EZ
7952011-09-24 Eli Zaretskii <eliz@gnu.org>
796
6bf7006f
EZ
797 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
798 value is now t. Doc fix.
799
e3cbd34b
EZ
800 * indent.c (Fvertical_motion): Compute and apply the overshoot
801 logic when moving up, not only when moving down. Fix the
802 confusing name and values of the it_overshoot_expected variable;
803 logic changes accordingly. (Bug#9254) (Bug#9549)
804
805 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
806 CHARPOS is covered by a display string which includes newlines.
807 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
808 is covered by a display string with embedded newlines.
809
a3de0cbd
MA
8102011-09-24 Michael Albinus <michael.albinus@gmx.de>
811
812 * dbusbind.c (Fdbus_register_signal): Add match rule to
813 Vdbus_registered_objects_table. (Bug#9581)
814 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
815 docstring.
816
b260039d
JM
8172011-09-24 Jim Meyering <meyering@redhat.com>
818
819 do not ignore write error for any output size
820 The previous change was incomplete.
821 While it makes emacs --batch detect the vast majority of stdout
822 write failures, errors were still ignored whenever the output size is
823 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
824 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
825 && echo FAIL: ignored write error
826 FAIL: ignored write error
827 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
828 && echo FAIL: ignored write error
829 FAIL: ignored write error
830 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
831
8eca8a7c
AS
8322011-09-23 Andreas Schwab <schwab@linux-m68k.org>
833
834 * emacs.c (Fkill_emacs): In noninteractive mode exit
835 non-successfully if a write error occurred on stdout. (Bug#9574)
836
3341db62
EZ
8372011-09-21 Eli Zaretskii <eliz@gnu.org>
838
839 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
840 the xassert test.
841
842 * dispextern.h (struct it): Update the comment documenting what
843 can it->OBJECT be.
844
8c203dbf
EZ
8452011-09-20 Eli Zaretskii <eliz@gnu.org>
846
847 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
848 a display string, extend search for cursor position to end of row.
849 (find_row_edges): If the row ends in a newline from a display
850 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
851 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
852 (Fcurrent_bidi_paragraph_direction): Fix search for previous
853 non-empty line. Fixes confusing cursor motion with arrow keys at
854 the beginning of a line that starts with whitespace.
8c203dbf 855
a4824228
LMI
8562011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
857
858 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
859 (bug#9493).
860
33ed493b
CY
8612011-09-18 Chong Yidong <cyd@stupidchicken.com>
862
863 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
864 boolean (Bug#9154).
865
56cd55c8
EZ
8662011-09-18 Eli Zaretskii <eliz@gnu.org>
867
868 * xdisp.c (display_line): Record maximum and minimum buffer
869 positions even if no glyphs were produced (e.g., by a zero-width
870 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
871 buffer positions that will be removed from the glyph row because
872 they don't fit.
c02dcedf
EZ
873 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
874 column is beyond frame width: don't subtract 1 "pixel" when
875 computing width of the stretch.
3e62b7e0
EZ
876 (reseat_at_next_visible_line_start): Undo the change made on
877 2011-09-17 that saved paragraph information and restored it after
878 the call to `reseat'. (Bug#9545)
56cd55c8 879
5ed99d36 8802011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
881
882 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
883 and turn window cursor on if cleared (Bug#9415).
884
5ed99d36 8852011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
886
887 * search.c (boyer_moore): Take unibyte characters from pattern
888 literally. (Bug#9458)
889
9bade7b2
EZ
8902011-09-18 Eli Zaretskii <eliz@gnu.org>
891
892 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
893
e5e9d610
PE
8942011-09-18 Paul Eggert <eggert@cs.ucla.edu>
895
87e4427a
PE
896 Fix minor problem found by static checking.
897 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
898 initialized, to pacify gcc -Wuninitialized.
899
e5e9d610
PE
900 * fileio.c: Report proper errno when syscall falls.
901 (Finsert_file_contents): Save and restore errno,
902 so that report_file_error outputs the correct diagnostic.
903 (Fwrite_region) [CLASH_DETECTION]: Likewise.
904
a1674f0b
EZ
9052011-09-18 Eli Zaretskii <eliz@gnu.org>
906
907 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
908
fbfb6dd4
EZ
9092011-09-17 Eli Zaretskii <eliz@gnu.org>
910
911 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
912 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
913
bb187662
EZ
9142011-09-17 Eli Zaretskii <eliz@gnu.org>
915
1137e8b8
EZ
916 * xdisp.c (reseat_at_next_visible_line_start): Keep information
917 about the current paragraph and restore it after the call to
918 reseat.
919
920 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
921 (bidi_find_paragraph_start): Search back for paragraph beginning
922 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
923 (bidi_move_to_visually_next): Only trigger paragraph-related
924 computations when the last character is a newline or at EOB, not
925 just any NEUTRAL_B. (Bug#9470)
926
bb187662
EZ
927 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
928 truncated lines if point is covered by a display string. (Bug#9524)
929
2e621251
PE
9302011-09-16 Paul Eggert <eggert@cs.ucla.edu>
931
932 * xselect.c: Relax test for outgoing X longs (Bug#9498).
933 (cons_to_x_long): New function.
934 (lisp_data_to_selection_data): Use it. Correct the test for
935 short-versus-long data; it was negated. Break out of vector
936 loop, for efficiency, when a long datum is discovered.
937
91a15bc6
SM
9382011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
939
940 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
941
b41c3a35
EZ
9422011-09-16 Eli Zaretskii <eliz@gnu.org>
943
944 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
945 GCC PR/17406) by declaring this function with external scope.
946
7812ba2d
PE
9472011-09-15 Paul Eggert <eggert@cs.ucla.edu>
948
949 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
950 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
951
cf7edc2a
AS
9522011-09-15 Andreas Schwab <schwab@linux-m68k.org>
953
954 * editfns.c (Fformat): Correctly handle text properties on "%%".
955
bd01620e
EZ
9562011-09-15 Eli Zaretskii <eliz@gnu.org>
957
958 * xterm.c (x_draw_composite_glyph_string_foreground):
959 * w32term.c (x_draw_composite_glyph_string_foreground):
960 * term.c (encode_terminal_code):
961 * composite.c (composition_update_it, get_composition_id):
962 * xdisp.c (get_next_display_element)
963 (fill_composite_glyph_string): Add comments about special meaning
964 of TAB characters in a composition.
965
a02719a3
PE
9662011-09-15 Paul Eggert <eggert@cs.ucla.edu>
967
968 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
969 This occurs when processing a multibyte format.
970 Problem reported by Wolfgang Jenker.
a02719a3 971
72589a3c
JB
9722011-09-15 Johan Bockgård <bojohan@gnu.org>
973
974 * xdisp.c (try_cursor_movement): Only check for exact match if
975 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
976
1c14176c
PE
9772011-09-14 Paul Eggert <eggert@cs.ucla.edu>
978
979 Remove unused external symbols.
980 * dispextern.h (calc_pixel_width_or_height): Remove decl.
981 * xdisp.c (calc_pixel_width_or_height): Now static.
982 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
983 * indent.c (check_display_width):
984 * w32term.c: Fix comment to match code.
985 * xterm.c, xterm.h (x_catching_errors): Remove.
986
d2eea5b5
PE
9872011-09-14 Paul Eggert <eggert@cs.ucla.edu>
988
989 * xselect.c: Use signed conversions more consistently (Bug#9498).
990 (selection_data_to_lisp_data): Assume incoming selection data are
991 signed integers, not unsigned. This is to be consistent with
992 outgoing selection data, which was modified to use signed integers
993 in as part of the fix to Bug#9196 in response to Jan D.'s comment
994 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
995 expects long, not unsigned long.
996
46888499
EZ
9972011-09-14 Eli Zaretskii <eliz@gnu.org>
998
999 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1000 computation of loop end. Reported by Johan Bockgård
1001 <bojohan@gnu.org>.
1002
ef8ef9fb
CY
10032011-09-13 Chong Yidong <cyd@stupidchicken.com>
1004
1005 * frame.c (Fother_visible_frames_p): Function deleted.
1006
fa819fed
EZ
10072011-09-12 Eli Zaretskii <eliz@gnu.org>
1008
1009 * indent.c (compute_motion): Process display vector front to back
1010 rather than the other way around. (Bug#2496)
1011
2ba8e008
SM
10122011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1013
1014 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1015
20f53c69
CY
10162011-09-11 Chong Yidong <cyd@stupidchicken.com>
1017
1018 * minibuf.c (Fread_from_minibuffer): Doc fix.
1019
d562d7a4
EZ
10202011-09-11 Eli Zaretskii <eliz@gnu.org>
1021
1022 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1023 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1024
1c4d7f3d
LMI
10252011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1026
1027 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1028 value for non-existent files.
1029
b885bf36
EZ
10302011-09-11 Eli Zaretskii <eliz@gnu.org>
1031
1032 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1033 set its "size" to -1. This will set the modtime_size field of
1034 the corresponding buffer to -1, which is what
1035 verify-visited-file-modtime expects for files that do not exist.
1036 (Bug#9139)
1037
6612f0bf
PE
10382011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1039
1040 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1041 here ...
1042 * lisp.h: ... from here. push_key_description is no longer
1043 defined in keyboard.c, so its declaration should not be in
1044 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1045 logically belongs with push_key_description.
1046
dfb3f755
PE
10472011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1048
1049 * buffer.h: Include <sys/types.h> instead of <time.h>.
1050 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1051 Problem reported by Herbert J. Skuhra.
1052
3134906c
LMI
10532011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1054
1055 * xml.c (parse_region): Make the parsing work for
1056 non-comment-starting XML files again (bug#9144).
1057
8d903f4e
AS
10582011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1059
1060 * image.c (gif_load): Fix calculation of bottom and right corner.
1061 (Bug#9468)
1062
80ad64f4
EZ
10632011-09-10 Eli Zaretskii <eliz@gnu.org>
1064
1065 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1066 redisplay in small windows.
1067
208a048d
EZ
10682011-09-09 Eli Zaretskii <eliz@gnu.org>
1069
1070 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1071
9b1c252e
MR
10722011-09-08 Martin Rudalics <rudalics@gmx.at>
1073
1074 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1075 Operate on live windows only.
1076
2949f33b
JB
10772011-09-08 Juanma Barranquero <lekktu@gmail.com>
1078
1079 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1080
e08dcafd
EZ
10812011-09-07 Eli Zaretskii <eliz@gnu.org>
1082
1083 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1084 only under bidi iteration.
1085
115b96bd
JD
10862011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1087
1088 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1089
c8199d0f
PE
10902011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1091
1092 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1093 Without this fix, the command to link temacs failed due to an
1094 undefined symbol __builtin_isnan. This is because
1095 /usr/include/iso/math_c99.h #defines isnan(x) to
1096 __builtin_isnan(x), but the bundled gcc, which identifies itself
1097 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1098 a __builtin_isnan.
1099 * floatfns.c (isnan): #undef, and then #define to a clone of
1100 what's in data.c.
1101 (Fisnan): Always define, since it's always available now.
1102 (syms_of_floatfns): Always define isnan at the Lisp level.
1103
e39b275c 11042011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1105
1106 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1107
b2db44d9 11082011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1109
f4af5137 1110 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1111 The previous code assumed that file offsets (off_t values) fit in
1112 EMACS_INT variables, which is not true on typical 32-bit hosts.
1113 The code messed up by falsely reporting buffer overflow in cases
1114 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1115 when "big" contains more than 2**29 bytes, even though this
1116 inserts just one byte and does not overflow the buffer.
1117 (Finsert_file_contents): Store file offsets as off_t
1118 values, not as EMACS_INT values. Check for overflow when
1119 converting between EMACS_INT and off_t. When checking for
1120 buffer overflow or for overlap, take the offsets into account.
1121 Don't use EMACS_INT for small values where int suffices.
1122 When checking for overlap, fix a typo: ZV was used where
1123 ZV_BYTE was intended.
1124 (Fwrite_region): Don't assume off_t fits into 'long'.
1125 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1126
ecfc0a49
MA
11272011-09-05 Michael Albinus <michael.albinus@gmx.de>
1128
1129 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1130
6511acf2 11312011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1132
0999621a 1133 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1134
1135 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1136 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
1137 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1138 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
1139 (modify_event_symbol): Do not assume that the length of
1140 name_alist_or_stem is safe to alloca and fits in int.
1141 (Fexecute_extended_command): Likewise for function name and binding.
1142 (Frecursion_depth): Wrap around reliably on integer overflow.
1143 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1144 since some callers pass EMACS_INT values.
1145 (Fsingle_key_description): Don't crash if symbol name contains more
1146 than MAX_ALLOCA bytes.
1147 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1148 (get_minibuffer): Arg is now EMACS_INT, not int.
1149 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1150 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1151 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1152
2be7d702
PE
1153 * dbusbind.c (signature_cat): New function.
1154 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1155 Do not overrun buffer; instead, report string overflow.
1156
9d1df220
PE
1157 * dispnew.c (add_window_display_history): Don't overrun buffer.
1158 Truncate instead; this is OK since it's just a log.
1159
33ef5c64
PE
1160 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1161 even if the time zone offset is outlandishly large.
1162 Don't mishandle offset == INT_MIN.
1163
66c6fdd5
PE
1164 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1165 when creating daemon; the previous buffer-overflow check was incorrect.
1166
d749b01b
PE
1167 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1168 which has the guts of the old verror function.
1169
b5cd1905
PE
1170 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1171 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1172
6e1a67fb
PE
1173 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1174 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1175 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1176 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1177 length of string rather than counting it via multiple sprintfs;
1178 that's simpler and more reliable.
c21721cc
PE
1179 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1180 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1181 sprintf, in case result does not fit in int.
1182
c57b67fc
PE
1183 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1184 (fontset_from_font): Print it.
1185
8a401434
PE
1186 * frame.c (tty_frame_count): Now printmax_t, not int.
1187 (make_terminal_frame, set_term_frame_name): Print it.
1188 (x_report_frame_params): In X, window IDs are unsigned long,
1189 not signed long, so print them as unsigned.
1190 (validate_x_resource_name): Check for implausibly long names,
1191 and don't assume name length fits in 'int'.
1192 (x_get_resource_string): Don't blindly alloca invocation name;
1193 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1194 not fit in int.
1195
6e1a67fb
PE
1196 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1197 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1198 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1199
0df02bf3
PE
1200 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1201 Use esprintf, not sprintf, in case result does not fit in int.
1202
48e30793
PE
1203 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1204 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1205 it as a large positive number.
1206 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1207 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1208
a66ff6d8
PE
1209 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1210 in case result does not fit in int.
1211
aca216ff
PE
1212 * print.c (float_to_string): Detect width overflow more reliably.
1213 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1214 buffer overrun. Don't assume list length fits in 'int'. Treat
1215 print length of 0 as 0, not as infinity; to be consistent with other
1216 uses of print length in this function. Don't overflow print length
1217 index. Don't assume hash table size fits in 'long', or that
1218 vectorlike size fits in 'unsigned long'.
1219
31c286f7
PE
1220 * process.c (make_process): Use printmax_t, not int, to format
1221 process-name gensyms.
1222
55e5faa1
PE
1223 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1224
80f2e268
PE
1225 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1226 to avoid potential buffer overrun.
1227
670741ab
PE
1228 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1229 if X resource line is longer than 512 bytes.
1230
b7163a50
PE
1231 * xfns.c (x_window): Make sprintf buffer a bit bigger
1232 to avoid potential buffer overrun.
1233
ae58ff1f
PE
1234 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1235
c43c8a6a
PE
1236 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1237
3f8236f4
PE
12382011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1239
53e9fe90 1240 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1241 Without these, Emacs silently mishandles large integers sometimes.
1242 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1243 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1244
6511acf2
PE
1245 * xdisp.c (try_window_id): Check Emacs fixnum range before
1246 converting to 'int'.
806add1d 1247
6511acf2 1248 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1249 Check that an Emacs fixnum is in range before assigning it to 'int'.
1250 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1251 values converted from Emacs fixnums.
1252 (Frecenter): Don't wrap around a line count if it is out of 'int'
1253 range; instead, treat it as an extreme value.
1254 (Fset_window_configuration, compare_window_configurations):
1255 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1256
6511acf2
PE
1257 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1258 that can exceed INT_MAX. Check that EMACS_INT value is in range
1259 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1260 (match_limit): Don't assume that a fixnum can fit in 'int'.
1261
6511acf2 1262 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1263 exceed INT_MAX.
1264
6511acf2 1265 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1266 (Fvertical_motion): Don't wrap around LINES values that don't fit
1267 in 'int'. Instead, treat them as extreme values. This is good
1268 enough for windows, which can't have more than INT_MAX lines anyway.
1269
fcb901a7
LMI
12702011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1271
0f2f6b6d
LMI
1272 * Require libxml/parser.h to avoid compilation warning.
1273
fcb901a7
LMI
1274 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1275
1276 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1277 since this reportedly can destroy thread storage.
1278
6e20a0d4
CY
12792011-08-30 Chong Yidong <cyd@stupidchicken.com>
1280
1281 * syntax.c (find_defun_start): Update all cache variables if
1282 exiting early (Bug#9401).
1283
148ae00e
EZ
12842011-08-30 Eli Zaretskii <eliz@gnu.org>
1285
f6cfbd8f
EZ
1286 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1287
148ae00e
EZ
1288 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1289 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1290 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1291
1292 * term.c (tty_append_glyph): New function.
1293 (produce_stretch_glyph): Static function and its prototype deleted.
1294
1295 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
1296 prototypes.
1297
c4a07a4c
PE
12982011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1299
1300 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1301 when checking :margin (Bug#9390).
1302 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1303 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1304 so that the name doesn't mislead. All uses changed.
1305
6bc8cd65
JB
13062011-08-28 Johan Bockgård <bojohan@gnu.org>
1307
1308 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1309 set_tty_hooks.
1310
dca4927e
EZ
13112011-08-27 Eli Zaretskii <eliz@gnu.org>
1312
1313 * xdisp.c (move_it_to): Don't bail out early when reaching
1314 position beyond to_charpos, if we are scanning backwards.
1315 (move_it_vertically_backward): When DY == 0, make sure we get to
1316 the first character in the line after the newline.
1317
f2cad773
PE
13182011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1319
1320 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1321 (ccl_driver): Do not generate an out-of-range pointer.
1322 (Fccl_execute_on_string): Remove unnecessary check for
1323 integer overflow, noted by Stefan Monnier in
1324 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1325 Remove a FIXME that didn't need fixing.
1326 Simplify the newly-introduced buffer reallocation code.
1327
0cae2cdb
JB
13282011-08-27 Juanma Barranquero <lekktu@gmail.com>
1329
1330 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1331
5fc295a4 13322011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1333
70c60eb2 1334 Integer and memory overflow issues (Bug#9196).
726e0ab1 1335
d31850da
PE
1336 * doc.c (get_doc_string): Rework so that
1337 get_doc_string_buffer_size is the actual buffer size, rather than
1338 being 1 less than the actual buffer size; this makes xpalloc more
1339 convenient.
1340
a69fbedb
PE
1341 * image.c (x_allocate_bitmap_record, cache_image):
1342 * xselect.c (Fx_register_dnd_atom):
1343 Simplify previous changes by using xpalloc.
1344
fe5c5d37
PE
1345 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1346 since either will do and ptrdiff_t is convenient with xpalloc.
1347
0065d054
PE
1348 * charset.c (charset_table_size)
1349 (struct charset_sort_data.priority): Now ptrdiff_t.
1350 (charset_compare): Don't overflow if priorities differ greatly.
1351 (Fsort_charsets): Don't assume list length fits in int.
1352 Check for size-calculation overflow when allocating sort data.
1353 (syms_of_charset): Allocate an initial charset table that is
1354 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1355
1356 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1357
1358 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1359 The actual value is always <= INT_MAX, and leaving it unsigned made
1360 overflow checking harder.
1361
1362 * dispextern.h (struct glyph_matrix.rows_allocated)
1363 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1364 with xpalloc. The values are still always <= INT_MAX.
1365
1366 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1367
1368 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1369 (SAFE_NALLOCA): New macro.
1370
1371 * region-cache.c (struct boundary.pos, find_cache_boundary)
1372 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1373 (set_cache_region, invalidate_region_cache)
1374 (revalidate_region_cache, know_region_cache, region_cache_forward)
1375 (region_cache_backward, pp_cache):
1376 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1377 so that ptrdiff_t * can be passed to xpalloc.
1378 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1379 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1380 (pp_cache): Don't assume cache_len fits in int.
1381 * region-cache.h: Adjust extern decls to match.
1382
1383 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1384 EMACS_INT, since either will do, for xpalloc.
1385
1386 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1387 (xnmalloc, xnrealloc, xpalloc): New functions.
1388
726e0ab1
PE
1389 * bidi.c (bidi_shelve_header_size): New constant.
1390 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1391 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1392
51f30bc5 1393 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1394 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1395 (overlay_strings):
1396 Don't update size of array until after memory allocation succeeds,
1397 because xmalloc/xrealloc may not return.
0065d054
PE
1398 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1399 now that we have proper integer overflow checking.
1400 (record_overlay_string, overlay_strings): Catch overflows when
1401 calculating size of overlay_str_buf.
726e0ab1 1402
0065d054
PE
1403 * callproc.c (Fcall_process): Check for size overflow when
1404 calculating size of args2.
1405 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1406 Normally we prefer signed values, but sticking with ptrdiff_t would
1407 require adding more-complicated checks.
726e0ab1
PE
1408
1409 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1410 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1411 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1412 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1413
1414 * character.c (Fstring): Check for size-calculation overflow.
1415
1416 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1417 unnecessary integer overflow. Check for size overflow.
1418 (encode_coding_object): Don't update size until xmalloc succeeds.
1419
1420 * composite.c (get_composition_id): Check for overflow in glyph
1421 length calculations.
1422
1423 Integer and memory overflow fixes for display code.
1424 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1425 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1426 (scrolling_window): Check for overflow in size calculations.
1427 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1428 Don't assume glyph table len fits in int.
1429 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1430 (row_table_size): Now ptrdiff_t, not int.
1431 (scrolling_window): Avoid overflow in size calculations.
1432 Don't update size until allocation succeeds.
1433 * fns.c (concat): Check for overflow in size calculations.
1434 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1435 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1436 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1437
1438 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1439 (get_doc_string): Check for size calculation overflow.
1440 Don't update size until allocation succeeds.
1441 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1442 EMACS_INT, where ptrdiff_t will do.
1443 (Fsubstitute_command_keys): Check for string overflow.
1444
1445 * editfns.c (set_time_zone_rule): Don't assume environment length
1446 fits in int.
1447 (message_length): Now ptrdiff_t, not int.
1448 (Fmessage_box): Don't update size until allocation succeeds.
1449 Don't assume message length fits in int.
1450 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1451
0065d054
PE
1452 * emacs.c (main): Do not reallocate argv, since there is a null at
1453 the end that can be overwritten, and this way there's no need to
1454 worry about size-calculation overflow.
1455 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1456
1457 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1458 alloc succeeds.
1459 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1460
1461 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1462 (x_set_scroll_bar_width, x_figure_window_size):
1463 Check for integer overflow.
1464 (x_set_alpha): Do not assume XINT fits in int.
1465
1466 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1467 This is for the members text_lines, text_cols, total_lines, total_cols,
1468 where the system imposes an 'int' limit.
1469
1470 * fringe.c (Fdefine_fringe_bitmap):
1471 Don't update size until alloc works.
1472
1473 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1474 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1475
1476 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1477 Check for size-calculation overflow.
1478 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1479 do, as we prefer signed integers.
1480 (id_to_widget.max_size, id_to_widget.used)
1481 (xg_store_widget_in_map, xg_remove_widget_from_map)
1482 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1483 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1484 Use and return ptrdiff_t, not int.
1485 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1486 * gtkutil.h: Change prototypes to match the above.
1487
1488 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1489 are duplicate now that they've been promoted to lisp.h.
1490 (x_allocate_bitmap_record, x_alloc_image_color)
1491 (make_image_cache, cache_image, xpm_load):
1492 Don't update size until alloc is done.
1493 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1494 (x_detect_edges):
3256efce 1495 Check for size calculation overflow.
726e0ab1
PE
1496 (ct_colors_allocated_max): New constant.
1497 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1498 overflow.
3256efce 1499
726e0ab1
PE
1500 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1501 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1502 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1503 Use ptrdiff_t, not int, to count maps.
1504 (read_char_minibuf_menu_prompt): Check for overflow in size
1505 calculations. Don't update size until allocation succeeds. Redo
1506 calculations to avoid overflow.
1507 * keyboard.h: Change prototypes to match the above.
1508
1509 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1510 to count maps.
1511 (current_minor_maps): Check for size calculation overflow.
1512 * keymap.h: Change prototypes to match the above.
1513
1514 * lread.c (read1, init_obarray): Don't update size until alloc done.
1515
1516 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1517 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1518
726e0ab1
PE
1519 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1520 Now ptrdiff_t, not int.
1521 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1522 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1523
1524 * process.c (Fnetwork_interface_list): Check for overflow
1525 in size calculation.
1526
1527 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1528
1529 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1530 overflow. Don't bother calling xmalloc when xrealloc will do.
1531
1532 * search.c (Freplace_match): Check for size calculation overflow.
1533 (Fset_match_data): Don't assume list lengths fit in 'int'.
1534
1535 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1536 for command line length. Do not attempt to address one before the
1537 beginning of an array, as that's not portable.
1538
1539 * term.c (max_frame_lines): Remove; unused.
1540 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1541 not int.
1542 (encode_terminal_code, calculate_costs): Check for size
1543 calculation overflow.
1544 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1545 table lengths and related sizes. Don't update size until alloc
1546 done. Redo calculations to avoid overflow.
1547 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1548
1549 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1550 subtracting pointers.
1551 (gobble_line): Check for overflow more carefully. Don't update size
1552 until alloc done.
1553
1554 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1555 Don't update size until alloc done.
1556 Redo size calculations to avoid overflow.
1557 Check for size calculation overflow.
0065d054 1558 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1559
1560 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1561 Use ptrdiff_t, not int, for sizes.
1562 (store_mode_line_noprop_char): Don't update size until alloc done.
1563
0065d054
PE
1564 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1565 Use ptrdiff_t, not int, for sizes.
1566 (Finternal_make_lisp_face, cache_face):
1567 Check for size calculation overflow.
1568 (cache_face): Treat size calculation overflows as if they were
1569 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1570
1571 * xfns.c (x_encode_text, x_set_name_internal)
1572 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1573 sizes, since they can exceed INT_MAX in size. Check for size
1574 calculation overflow.
1575
0065d054
PE
1576 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1577 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1578 Don't update size until alloc done.
1579
0065d054 1580 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1581 as sprintf is limited to int lengths.
1d526e2f 1582
252c5ee1
PE
1583 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1584 (X_LONG_MIN): New macros.
864d7ce7
PE
1585 Use them to make the following changes clearer.
1586 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1587 This change doesn't affect the value now, but it may help remind
1588 future maintainers not to raise the value too much later.
1589 (SELECTION_QUANTUM): Remove, replacing with ...
1590 (selection_quantum): ... new function, which avoids overflow.
1591 All uses changed.
1592 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1593 assumption that selection length fits in 'int'.
1594 (x_reply_selection_request, x_handle_selection_request)
1595 (x_get_window_property, receive_incremental_selection)
1596 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1597 (lisp_data_to_selection_data, clean_local_selection_data):
1598 Use ptrdiff_t, not int, to record length of selection.
1599 (x_reply_selection_request, x_get_window_property)
1600 (receive_incremental_selection, x_property_data_to_lisp):
1601 Redo calculations to avoid overflow.
1602 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1603 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1604 something.
1605 (x_get_window_property, receive_incremental_selection)
1606 (lisp_data_to_selection_data, x_property_data_to_lisp):
1607 Check for size-calculation overflow.
1608 (x_get_window_property, receive_incremental_selection)
1609 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1610 Don't store size until memory allocation succeeds.
1611 (x_get_window_property): Plug memory leak on memory exhaustion.
1612 Don't double-block input; malloc is safe here. Don't assume 2**34
1613 - 4 fits in unsigned long. Add an xassert to check
1614 XGetWindowProperty overflow. Be more careful about overflow
1615 calculations, and distinguish size from memory overflow better.
1616 (receive_incremental_selection): When tracing, don't assume
1617 unsigned int is less than INT_MAX.
1618 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1619 harmful) conversions of unsigned short to int.
1620 (lisp_data_to_selection_data): Don't assume that integers
1621 in the range -65535 through -1 fit in an X unsigned short.
1622 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1623 result parameters unless successful. Rely on cons_to_unsigned
1624 to report problems with elements; the old code wasn't right anyway.
1625 (x_check_property_data): Check for int overflow; we cannot use
1626 a wider type due to X limits.
1627 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1628
726e0ab1 1629 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1630
0065d054
PE
1631 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1632 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1633 (x_color_cells): Don't store size until memory allocation succeeds.
1634 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1635 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1636 (x_term_init): Don't assume length fits in int (sprintf is limited
1637 to int size).
bc18e09d 1638
ebfa62c0
PE
1639 Use ptrdiff_t for composition IDs.
1640 * character.c (lisp_string_width):
1641 * composite.c (composition_table_size, n_compositions)
1642 (get_composition_id, composition_gstring_from_id):
1643 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1644 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1645 * window.c (Frecenter):
1646 Use ptrdiff_t, not int, for composition IDs.
1647 * composite.c (get_composition_id): Check for integer overflow.
1648 * composite.h: Adjust prototypes to match the above changes.
1649
d3411f89
PE
1650 Use ptrdiff_t for hash table indexes.
1651 * category.c (hash_get_category_set):
1652 * ccl.c (ccl_driver):
1653 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1654 * coding.c (coding_system_charset_list, detect_coding_system):
1655 * coding.h (struct coding_system.id):
1656 * composite.c (get_composition_id, gstring_lookup_cache):
1657 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1658 * image.c (xpm_get_color_table_h):
1659 * lisp.h (hash_lookup, hash_put):
1660 * minibuf.c (Ftest_completion):
1661 Use ptrdiff_t for hash table indexes, not int (which is too
1662 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1663 32-bit --with-wide-int hosts).
1664
e097a6fa
PE
1665 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1666 Add a FIXME comment about memory leaks.
1667 (syms_of_charset): Don't assume xmalloc returns.
1668
5637687f
PE
1669 Don't assume that stated character widths fit in int.
1670 * character.c (Fchar_width, c_string_width, lisp_string_width):
1671 * character.h (CHAR_WIDTH):
1672 * indent.c (MULTIBYTE_BYTES_WIDTH):
1673 Use sanitize_char_width to avoid undefined and/or bad behavior
1674 with outlandish widths.
1675 * character.h (sanitize_tab_width): Renamed from sanitize_width,
1676 now that we have two such functions. All uses changed.
1677 (sanitize_char_width): New inline function.
1678
a2271ba2
PE
1679 Don't assume that tab-width fits in int.
1680 * character.h (sanitize_width): New inline function.
1681 (SANE_TAB_WIDTH): New macro.
1682 (ASCII_CHAR_WIDTH): Use it.
1683 * indent.c (sane_tab_width): Remove. All uses replaced by
1684 SANE_TAB_WIDTH (current_buffer).
1685 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1686
18c52557
PE
1687 * fileio.c: Integer overflow issues with file modes.
1688 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1689
caeeedc1
PE
1690 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1691 Remove unreachable code.
1692 (read_hex, load_charset_map_from_file): Check for integer overflow.
1693
50849c52
PE
1694 * xterm.c: don't go over XClientMessageEvent limit
1695 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1696 (x_send_scroll_bar_event): Likewise. Check that the size does not
1697 exceed limits imposed by XClientMessageEvent, as well as the usual
1698 ptrdiff_t and size_t limits.
1699
b13995db
PE
1700 * keyboard.c: Overflow, signedness and related fixes.
1701 (make_lispy_movement): Use same integer type in forward decl
1702 that is used in the definition.
1703 (read_key_sequence, keyremap_step):
1704 Change bufsize argument back to int, undoing my 2011-03-30 change.
1705 We prefer signed types, and int is wide enough here.
1706 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1707 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1708 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1709 length, not size_t. Use ptrdiff_t for index, not int.
1710 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1711 possibility of integer overflow.
1712
13464394
PE
1713 Overflow, signedness and related fixes for images.
1714
1715 * dispextern.h (struct it.stack[0].u.image.image_id)
1716 (struct_it.image_id, struct image.id, struct image_cache.size)
1717 (struct image_cache.used, struct image_cache.ref_count):
1718 * gtkutil.c (update_frame_tool_bar):
1719 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1720 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1721 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1722 * nsmenu.m (update_frame_tool_bar):
1723 * xdisp.c (calc_pixel_width_or_height):
1724 * xfns.c (image_cache_refcount):
1725 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1726 on typical 64-bit hosts.
1727
1728 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1729 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1730 Omit unnecessary casts to int.
1731 (parse_image_spec): Check that integers fall into 'int' range
1732 when the callers expect that.
1733 (image_ascent): Redo ascent calculation to avoid int overflow.
1734 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1735 (lookup_image): Remove unnecessary tests.
1736 (xbm_image_p): Locals are now of int, not EMACS_INT,
1737 since parse_image_check makes sure they fit into int.
1738 (png_load, gif_load, svg_load_image):
1739 Prefer int to unsigned where either will do.
1740 (tiff_handler): New function, combining the cores of the
1741 old tiff_error_handler and tiff_warning_handler. This
1742 function is rewritten to use vsnprintf and thereby avoid
1743 stack buffer overflows. It uses only the features of vsnprintf
1744 that are common to both POSIX and native Microsoft.
1745 (tiff_error_handler, tiff_warning_handler): Use it.
1746 (tiff_load, gif_load, imagemagick_load_image):
1747 Don't assume :index value fits in 'int'.
1748 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1749 (imagemagick_load_image): Check that crop parameters fit into
1750 the integer types that MagickCropImage accepts. Don't assume
1751 Vimagemagick_render_type has a nonnegative value. Don't assume
1752 size_t fits in 'long'.
1753 (gs_load): Use printmax_t to print the widest integers possible.
1754 Check for integer overflow when computing image height and width.
1755
c11821d4
EZ
17562011-08-26 Eli Zaretskii <eliz@gnu.org>
1757
1758 * xdisp.c (redisplay_window): Don't force window start if point
1759 will be invisible in the resulting window. (Bug#9324)
1760
0c95fcf7
EZ
17612011-08-25 Eli Zaretskii <eliz@gnu.org>
1762
1763 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1764 the display spec is of the form `(space ...)'.
1765 (handle_display_spec): Return the value returned by
1766 handle_single_display_spec, not just 1 or zero.
1767 (handle_single_display_spec): If the display spec is of the form
1768 `(space ...)', and specifies display in the text area, return 2
1769 rather than 1.
fee65a97 1770 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
1771 accurately, and prefer exact match for point under bidi. Don't
1772 advance `row' beyond the last row of the window.
0c95fcf7
EZ
1773
1774 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1775 into disp_prop; all users changed.
1776
1777 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1778 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1779 for the text covered by the display property.
1780
e4ed06f1
CY
17812011-08-25 Chong Yidong <cyd@stupidchicken.com>
1782
1783 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1784 Change return value to nil.
1785 (Frecord_buffer): Delete unused function.
1786
f67cdd7f
EZ
17872011-08-24 Eli Zaretskii <eliz@gnu.org>
1788
5980d4c6
EZ
1789 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1790 buffers, return left-to-right.
8610fe8b
EZ
1791 (set_cursor_from_row): Consider candidate row a win if its glyph
1792 represents a newline and point is on that newline. Fixes cursor
1793 positioning on the newline at EOL of R2L text within L2R
1794 paragraph, and vice versa.
1795 (try_cursor_movement): Check continued rows, in addition to
1796 continuation rows. Fixes unwarranted scroll when point enters a
1797 continued line of R2L text within an L2R paragraph, or vice versa.
1798 (cursor_row_p): Consider the case of point being equal to
1799 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1800 from the end of a short line to the beginning of a continued line
1801 of R2L text within L2R paragraph.
1802 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1803 composed characters.
5980d4c6 1804
f67cdd7f
EZ
1805 * bidi.c (bidi_check_type): Use xassert.
1806 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1807 members.
1808
bca633fb
EZ
18092011-08-23 Eli Zaretskii <eliz@gnu.org>
1810
1811 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1812 a character.
1813
4a5885a7
CY
18142011-08-23 Chong Yidong <cyd@stupidchicken.com>
1815
1816 * nsfont.m (ns_otf_to_script): Fix typo.
1817
0902a04e
KH
18182011-08-22 Kenichi Handa <handa@m17n.org>
1819
1820 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1821 extra slot even if the purpose is char-code-property-table.
1822
1a2e6670
EZ
18232011-08-23 Eli Zaretskii <eliz@gnu.org>
1824
8ddde651
EZ
1825 * xdisp.c (redisplay_window): When computing centering_position,
1826 account for the height of the header line. (Bug#8874)
1827
425cc014
EZ
1828 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1829 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1830 candidate is selected by the mouse, and that candidate has a
1831 composed character under the mouse.
1832
1a2e6670
EZ
1833 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1834 coordinates reported by pos-visible-in-window-p for a composed
1835 character in column zero.
1836
8b76d6f8
SM
18372011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1838
1839 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1840
dac347dd
EZ
18412011-08-22 Eli Zaretskii <eliz@gnu.org>
1842
1843 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1844 consider it a hit if to_charpos is anywhere in the range of the
1845 composed buffer positions.
1846
e013fb34
CY
18472011-08-22 Chong Yidong <cyd@stupidchicken.com>
1848
1849 * image.c (gif_load): Don't assume that each subimage has the same
1850 dimensions as the base image. Handle disposal method that is
1851 "undefined" by the gif spec (Bug#9335).
1852
bd1ba3e8
CY
18532011-08-20 Chong Yidong <cyd@stupidchicken.com>
1854
1855 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1856 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1857
54a1215b
EZ
18582011-08-19 Eli Zaretskii <eliz@gnu.org>
1859
823564e5
EZ
1860 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1861 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1862 from an Org mode buffer to a Speedbar frame.
1863
54a1215b
EZ
1864 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1865 a composition, take its buffer position from IT->cmp_it.charpos.
1866 Fixes cursor positioning at the beginning of a line that begins
1867 with a composed character.
1868
9778ebcc
EZ
18692011-08-18 Eli Zaretskii <eliz@gnu.org>
1870
0be6ee06
EZ
1871 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1872 character bidirectional type, use STRONG_L instead. Fixes crashes
1873 in a buffer produced by `describe-categories'.
1874
9778ebcc
EZ
1875 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1876 members before the level stack, so they would be saved and
1877 restored when copying iterator state. Fixes incorrect reordering
1878 around TABs covered by display properties.
1879
156bffbe
AS
18802011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1881
1882 * process.c (Fnetwork_interface_list): Correctly determine buffer
1883 size.
1884
72ad093b
CY
18852011-08-17 Chong Yidong <cyd@stupidchicken.com>
1886
1887 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1888 (internal_condition_case_2, internal_condition_case_n):
1889 Remove unnecessary aborts (Bug#9081).
72ad093b 1890
35774242
EZ
18912011-08-17 Eli Zaretskii <eliz@gnu.org>
1892
1893 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1894 has no `load' handler, try opening the file locally. (Bug#9311)
1895
db76dd85
KB
18962011-08-16 Ken Brown <kbrown@cornell.edu>
1897
1898 * gmalloc.c: Expand comment.
1899
b215eee5
EZ
19002011-08-16 Eli Zaretskii <eliz@gnu.org>
1901
1902 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1903 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1904
a4579d33
KB
19052011-08-16 Ken Brown <kbrown@cornell.edu>
1906
1907 Fix memory allocation problems in Cygwin build (Bug#9273).
1908
1909 * unexcw.c ( __malloc_initialized): Declare external variable.
1910 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1911
8b76d6f8
SM
1912 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1913 New variables.
a4579d33
KB
1914 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1915 dumped emacs.
1916 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1917 in the static heap.
1918 [CYGWIN] (special_realloc): New function.
1919 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1920 requests to realloc storage in the static heap.
1921
3ebec551
PE
19222011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1923
1924 * bidi.c (bidi_initialize): Remove unused local.
1925
9fd8be00
EZ
19262011-08-15 Eli Zaretskii <eliz@gnu.org>
1927
474a8465
EZ
1928 * biditype.h: File removed.
1929
1930 * bidimirror.h: File removed.
1931
1932 * deps.mk (bidi.o): Remove biditype.h and
1933 bidimirror.h.
1934
1935 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1936 bidimirror.h.
1937
1938 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1939
1940 * chartab.c: Improve commentary for the uniprop_table API.
1941
32413314
EZ
1942 * bidi.c (bidi_paragraph_init): Support zero value of
1943 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1944 (bidi_initialize): Use uniprop_table instead of including
1945 biditype.h and bidimirror.h.
32413314 1946
9fd8be00
EZ
1947 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1948 coordinates of the iterator when restoring from ppos_it.
1949 (Bug#9296)
1950
5cf2b69b
KH
19512011-08-14 Kenichi Handa <handa@m17n.org>
1952
1953 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1954 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1955
daf17d00
EZ
19562011-08-14 Eli Zaretskii <eliz@gnu.org>
1957
1958 * xdisp.c (move_it_in_display_line_to): Don't invoke
1959 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1960 ppos_it. Fixes vertical cursor motion when line beginning is
1961 covered by an image. (Bug#9296)
1962
08e3161a
JD
19632011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1964
1965 * nsterm.h (ns_run_ascript): Declare.
1966 (NSAPP_DATA2_RUNASSCRIPT): Define.
1967
1968 * nsfns.m (as_script, as_result, as_status): New static variables.
1969 (ns_run_ascript): New function.
5e617bc2 1970 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1971 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1972 the event loop. Get status from as_status (Bug#7276).
1973
1974 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1975 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1976 the event loop (Bug#7276).
1977
a3720aa2
AS
19782011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1979
1980 * gnutls.c (QCgnutls_bootprop_priority)
1981 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1982 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1983 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1984 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1985 (QCgnutls_bootprop_verify_hostname_error)
1986 (QCgnutls_bootprop_callbacks_verify): Rename from
1987 Qgnutls_bootprop_..., all uses changed.
1988
1989 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1990 uses changed.
1991
0a0d27fb
PE
19922011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1993
19d5c50c
PE
1994 * xfaces.c (Qframe_set_background_mode): Now static.
1995 * dispextern.h (Qframe_set_background_mode): Remove decl.
1996
0a0d27fb
PE
1997 * process.c (Fnetwork_interface_info): Declare local only if needed.
1998
377538cb
JD
19992011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2000
2001 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2002 (Fnetwork_interface_list): Allocate in increments of bytes instead
2003 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2004 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2005 sockaddr.
2006 (struct ifflag_def): notrailers is smart on OSX.
2007 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2008 Get hardware address with getifaddrs if available.
2009
08fff70c
EZ
20102011-08-12 Eli Zaretskii <eliz@gnu.org>
2011
2012 * xdisp.c (iterate_out_of_display_property): xassert that
2013 IT->position is set to within IT->object's boundaries. Break from
2014 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2015 when IT->position is set up wrongly due to some bug.
2016 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2017 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2018 entry. Force push_it to save on the stack the current
2019 buffer/string position, to be restored by pop_it. Fix flags in
2020 the iterator structure wrt the object coming from a display
2021 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2022 properties. (Bug#9284)
2023
7be1c708 20242011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2025
7be1c708
CY
2026 * fontset.c (fontset_get_font_group): Add proper type checks.
2027 (Bug#9172)
aac0c6e3 2028
7be1c708 20292011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2030
7be1c708
CY
2031 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2032 and LC_VERSION_MIN_MACOSX.
2033 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2034 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2035
97bb72a6
EZ
20362011-08-08 Eli Zaretskii <eliz@gnu.org>
2037
2038 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2039 no-display-properties-and-no-overlays under bidi display.
2040 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2041 properties and overlays.
97bb72a6 2042
d5617611
CY
20432011-08-08 Chong Yidong <cyd@stupidchicken.com>
2044
37e11a63
CY
2045 * editfns.c (Fset_time_zone_rule): Document relationship with the
2046 setenv function.
2047
d5617611
CY
2048 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2049 the font entity extracted from the cache (Bug#8109).
2050
58872834
CY
20512011-08-07 Chong Yidong <cyd@stupidchicken.com>
2052
2053 * composite.c (autocmp_chars): Don't reset point. That is done by
2054 restore_point_unwind (Bug#5984).
2055
75bfc667
JL
20562011-08-07 Juri Linkov <juri@jurta.org>
2057
2058 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2059 to show the arg `TIME' instead of `TIMEVAL'.
2060
d1410150
EZ
20612011-08-06 Eli Zaretskii <eliz@gnu.org>
2062
2063 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2064 display property strides EOL and includes a newline, as in
2065 longlines-mode. (Bug#9254)
75b771e4
EZ
2066 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2067 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2068
2069 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2070 is non-zero, even if the data buffer is NULL. Fixes a crash in
2071 vertical-motion with longlines-mode. (Bug#9254)
2072
35928349
EZ
20732011-08-05 Eli Zaretskii <eliz@gnu.org>
2074
ec7cc85b
EZ
2075 * bidi.c <bidi_cache_total_alloc>: Now static.
2076 (bidi_initialize): Initialize bidi_cache_total_alloc.
2077
8b76d6f8 2078 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2079 cache. (Bug#9221)
2080
2081 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2082 amount allocated this far in `bidi_cache_total_alloc'.
2083 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2084 non-zero, only free the data buffer without restoring the cache
2085 contents. All callers changed.
2086
2087 * dispextern.h (bidi_unshelve_cache): Update prototype.
2088
2089 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2090 (move_it_in_display_line, move_it_to)
2091 (move_it_vertically_backward, move_it_by_lines): Replace the call
2092 to xfree to an equivalent call to bidi_unshelve_cache.
2093 (move_it_in_display_line_to): Fix logic of returning
412b6358 2094 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2095
e2e2423b
EZ
20962011-08-05 Eli Zaretskii <eliz@gnu.org>
2097
2098 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2099 came from a string character with a `cursor' property. (Bug#9229)
2100
ae9e757a
JD
21012011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2102
2103 * Makefile.in (LIB_PTHREAD): New variable.
2104 (LIBES): Add LIB_PTHREAD (Bug#9216).
2105
2106 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2107 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2108
213bd7f2
AS
21092011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2110
2111 * regex.c (re_iswctype): Remove some redundant boolean
2112 conversions.
2113
99aaf75f
JD
21142011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2115
2116 * xterm.c (x_find_topmost_parent): New function.
2117 (x_set_frame_alpha): Find topmost parent window with
2118 x_find_topmost_parent and set the property there also (bug#9181).
2119 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2120
c74e9d86
PE
21212011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2122
2123 * callproc.c (Fcall_process): Avoid vfork clobbering
2124 the local vars buffer, coding_systems, current_dir.
2125
640c8776
SM
21262011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2127
2128 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2129
f26d0e4c
PE
21302011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2131
8a10d76c
PE
2132 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2133 so that it is not optimized away.
2134
f26d0e4c
PE
2135 * xdisp.c (compute_display_string_pos): Remove unused local.
2136
55439c61
EZ
21372011-08-02 Eli Zaretskii <eliz@gnu.org>
2138
2139 Fix slow cursor motion and scrolling in large buffers with
2140 selective display, like Org Mode buffers. (Bug#9218)
2141
2142 * dispextern.h (struct bidi_it): New member disp_prop_p.
2143
2144 * xdisp.c: Remove one-slot cache of display string positions.
2145 (compute_display_string_pos): Accept an additional argument
5e617bc2 2146 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2147 for a display string or property. If found, set DISP_PROP_P
2148 non-zero.
2149
2150 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2151 DISP_PROP_P, and pass it to compute_display_string_pos.
2152 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2153 non-zero. All callers of bidi_fetch_char changed.
2154
fb33fa43
SM
21552011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2156
2157 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2158
b099e063
DM
21592010-12-03 Don March <don@ohspite.net>
2160
2161 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2162 last character M-[char] is translated to ESC [char] (bug#7541).
2163
5cc7f7af
KH
21642011-08-02 Kenichi Handa <handa@m17n.org>
2165
d0fffa3f 2166 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2167
2168 * chartab.c (uniprop_table): Make it non-static.
2169
525d5e6e
EZ
21702011-08-01 Eli Zaretskii <eliz@gnu.org>
2171
2172 * xdisp.c (forward_to_next_line_start): Accept additional argument
2173 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2174 on the newline.
2175 (reseat_at_next_visible_line_start): Use the bidi iterator state
2176 returned by forward_to_next_line_start to restore the state of
2177 it->bidi_it after backing up to previous newline. (Bug#9212)
2178
31011111
AS
21792011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2180
2181 * regex.c (re_comp): Protoize.
2182 (re_exec): Fix return type.
2183 (regexec): Fix type of `ret'. (Bug#9203)
2184
476371c4
PE
21852011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2186
e5d76069
PE
2187 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2188 This is needed if max-image-size is a floating-point number.
2189
9a79b20c
AS
21902011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2191
2192 * print.c (print_object): Print empty symbol as ##.
2193
2194 * lread.c (read1): Read ## as empty symbol.
2195
d8c2fa78
AA
21962011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2197
2198 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2199 setting frame foreground color (Bug#9175).
2200 (x_set_background_color): Likewise.
2201
ffe57a7a
AA
2202 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2203 contents (Bug#9176).
2204 (EmacsTooltip -init): Remove bezels and add shadows to
2205 tooltip windows.
2206
bf3492a5
AA
2207 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2208 or scroll bar (Bug#8470).
2209
d55e9c53
AA
2210 * nsfont.m (nsfont_open): Remove assignment to voffset and
2211 unnecessary vars hshink, expand, hd, full_height, min_height.
2212 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2213
2214 * nsterm.h (nsfont_info): Remove voffset field.
2215
d8c2fa78 22162011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2217
2218 Implement strike-through and overline on NextStep (Bug#8863).
2219
2220 * nsfont.m (nsfont_open): Use underline position provided by font,
2221 instead of hard-coded value of 2.
2222 (nsfont_draw): Call ns_draw_text_decoration instead.
2223
2224 * nsterm.h: Add declaration for ns_draw_text_decoration.
2225
2226 * nsterm.m (ns_draw_text_decoration): New function for drawing
2227 underline, overline, and strike-through.
2228 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2229 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2230 accommodate underlining, etc.
4843aac3 2231
4cc60b9b
EZ
22322011-07-28 Eli Zaretskii <eliz@gnu.org>
2233
bc7ece87
EZ
2234 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2235 default.
4cc60b9b 2236
476371c4
PE
22372011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2238
66606eea
PE
2239 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2240 Without this fix, if a signal arrives just after memory fills up,
2241 'malloc' might be invoked reentrantly.
2242
476371c4
PE
2243 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2244 In other words, assume that every image size is allowed, on non-X
2245 hosts. This assumption is probably wrong, but it lets Emacs compile.
2246
f3fcc40d
AS
22472011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2248
2249 * regex.c (re_iswctype): Convert return values to boolean.
2250
350c992f
EZ
22512011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2252
2253 * xdisp.c (compute_display_string_pos): Don't use cached display
2254 string position if the buffer had its restriction changed.
2255 (Bug#9184)
2256
5266b4bb
PE
22572011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2258
2259 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2260
2573a837 22612011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2262
41f55ccd 2263 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2264
39e378da
PE
2265 * bidi.c: Integer size and overflow fixes.
2266 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2267 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2268 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2269 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2270 (bidi_find_other_level_edge):
2271 Use ptrdiff_t instead of EMACS_INT where either will do.
2272 This works better on 32-bit hosts configured --with-wide-int.
2273 (bidi_cache_ensure_space): Check for size-calculation overflow.
2274 Use % rather than repeated addition, for better worst-case speed.
2275 Don't set bidi_cache_size until after xrealloc returns, because it
2276 might not return.
2277 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2278 (bidi_cache_ensure_space): Also check that the bidi cache size
2279 does not exceed that of the largest Lisp string or buffer. See Eli
2280 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2281
5e927815
PE
2282 * alloc.c (__malloc_size_t): Remove.
2283 All uses replaced by size_t. See Andreas Schwab's note
2284 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2285
ca4aa935
PE
2286 * image.c: Improve checking for integer overflow.
2287 (check_image_size): Assume that f is nonnull, since
2288 it is always nonnull in practice. This is one less thing to
2289 worry about when checking for integer overflow later.
2290 (x_check_image_size): New function, which checks for integer
2291 overflow issues inside X.
2292 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2293 This removes the need for a memory_full check.
2294 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2295 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2296 (xbm_read_bitmap_data): Change locals back to 'int', since
2297 their values must fit in 'int'.
2298 (xpm_load_image, png_load, tiff_load):
2299 Invoke x_create_x_image_and_pixmap earlier,
2300 to avoid much needless work if the image is too large.
2301 (tiff_load): Treat overly large images as if
2302 x_create_x_image_and_pixmap failed, not as malloc failures.
2303 (gs_load): Use x_check_image_size.
2304
5f8f9cc2
PE
2305 * gtkutil.c: Omit integer casts.
2306 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2307 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2308
5adf60bc
PE
2309 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2310
c8907a93
PE
2311 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2312 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2313 would wrongly return t on a 64-bit host.
2314
e3c25c68
PE
2315 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2316 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2317 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2318 and therefore cause GCC to emit a bogus diagnostic in some cases.
2319
3f791afe
PE
2320 * image.c: Integer signedness and overflow and related fixes.
2321 This is not an exhaustive set of fixes, but it's time to
2322 record what I've got.
2323 (lookup_pixel_color, check_image_size): Remove redundant decls.
2324 (check_image_size): Don't assume that arbitrary EMACS_INT values
2325 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2326 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2327 (tiff_load, imagemagick_load_image):
2328 Check for overflow in size calculations.
2329 (x_create_x_image_and_pixmap): Remove unnecessary test for
2330 xmalloc returning NULL; that can't happen.
2331 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2332 (xpm_color_bucket): Use better integer hashing function.
2333 (xpm_cache_color): Don't possibly over-allocate memory.
2334 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2335 (gif_memory_source):
2336 Use ptrdiff_t, not int or size_t, to record sizes.
2337 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2338 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2339 either works, as we prefer signed integers.
2340 (tiff_read_from_memory, tiff_write_from_memory):
2341 Return tsize_t, not size_t, since that's what the TIFF API wants.
2342 (tiff_read_from_memory): Don't fail simply because the read would
2343 go past EOF; instead, return a short read.
2344 (tiff_load): Omit no-longer-needed casts.
2345 (Fimagemagick_types): Don't assume size fits into 'int'.
2346
3cc5a532
PE
2347 Improve hashing quality when configured --with-wide-int.
2348 * fns.c (hash_string): New function, taken from sxhash_string.
2349 Do not discard information about ASCII character case; this
2350 discarding is no longer needed.
2351 (sxhash-string): Use it. Change sig to match it. Caller changed.
2352 * lisp.h: Declare it.
2353 * lread.c (hash_string): Remove, since we now use fns.c's version.
2354 The fns.c version returns a wider integer if --with-wide-int is
2355 specified, so this should help the quality of the hashing a bit.
2356
b312a492
PE
2357 * emacs.c: Integer overflow minor fix.
2358 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2359 Define only if GNU_LINUX.
2360 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2361
dfd153ae
PE
2362 * dispnew.c: Integer signedness and overflow fixes.
2363 Remove unnecessary forward decls, that were a maintenance hassle.
2364 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2365 All uses changed.
2366 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2367 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2368 (prepare_desired_row, line_draw_cost):
2369 Use int, not unsigned, where either works.
2370 (save_current_matrix, restore_current_matrix):
2371 Use ptrdiff_t, not size_t, where either works.
2372 (init_display): Check for overflow more accurately, and without
2373 relying on undefined behavior.
2374
a81d11a3
PE
2375 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2376 Remove, replacing with the new symbols in lisp.h. All uses changed.
2377 * fileio.c (make_temp_name):
2378 * filelock.c (lock_file_1, lock_file):
2379 * xdisp.c (message_dolog):
2380 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2381 Use pMd etc. instead.
2382 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2383 replacing the pWIDE etc. symbols removed from editfns.c.
2384
3300e6fd
PE
2385 * keyboard.h (num_input_events): Now uintmax_t.
2386 This is (very slightly) less likely to mess up due to wraparound.
2387 All uses changed.
2388
fd05c7e9
PE
2389 * buffer.c: Integer signedness fixes.
2390 (alloc_buffer_text, enlarge_buffer_text):
2391 Use ptrdiff_t rather than size_t when either will do, as we prefer
2392 signed integers.
2393
903fe15d
PE
2394 * alloc.c: Integer signedness and overflow fixes.
2395 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2396 (__malloc_size_t): Default to size_t, not to int.
2397 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2398 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2399 Prefer ptrdiff_t to size_t when either would do, as we prefer
2400 signed integers.
2401 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2402 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2403 Now const. Initialize with values that are in range even if char
2404 is signed.
2405 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2406 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2407 These functions do the right thing with sizes > 2**32.
2408 (check_depth): Now ptrdiff_t, not int.
2409 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2410 Adjust to new way of storing sizes. Check for size overflow bugs
2411 in rest of code.
2412 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2413 slightly wrong anyway, as it missed one instance of
2414 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2415 (refill_memory_reserve): Omit needless cast to size_t.
2416 (mark_object_loop_halt): Mark as externally visible.
2417
ac82cc6a
PE
2418 * xselect.c: Integer signedness and overflow fixes.
2419 (Fx_register_dnd_atom, x_handle_dnd_message):
2420 Use ptrdiff_t, not size_t, since we prefer signed.
2421 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2422 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2423 x_dnd_atoms_size and x_dnd_atoms_length.
2424
c2d1e36d
PE
2425 * doprnt.c: Prefer signed to unsigned when either works.
2426 * eval.c (verror):
2427 * doprnt.c (doprnt):
2428 * lisp.h (doprnt):
2429 * xdisp.c (vmessage):
2430 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2431 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2432 prefer signed arithmetic to avoid comparison confusion.
2433 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2434 but is a bit tricky.
2435
0e926e56
PE
2436 Assume freestanding C89 headers, string.h, stdlib.h.
2437 * data.c, doprnt.c, floatfns.c, print.c:
2438 Include float.h unconditionally.
2439 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2440 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2441 * regex.c: Likewise for stddef.h, string.h.
2442 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2443 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2444 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2445 (STDC_HEADERS): Remove obsolete defines.
2446 * sysdep.c: Include limits.h unconditionally.
2447
9cfdb3ec
PE
2448 Assume support for memcmp, memcpy, memmove, memset.
2449 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2450 * regex.c (memcmp, memcpy):
2451 Remove; we assume C89 now.
2452
2453 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2454 (__malloc_safe_bcopy): Remove; no longer needed.
2455
cf950e6b 2456 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2457 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2458 well either way, and we prefer signed to unsigned.
2459
dbf38e02
LMI
24602011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2461
2462 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2463 closes the connection while we're reading (bug#9182).
2464
d6f0886c 24652011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2466
d6f0886c
JD
2467 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2468 are specified (Bug#9168).
24e0f6b1 2469
2eb1f9e6
PE
24702011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2471
2472 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2473 Found by GCC static checking and --with-wide-int on a 32-bit host.
2474
22381272 24752011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2476
2477 * xdisp.c (compute_display_string_pos): Fix logic of caching
2478 previous display string position. Initialize cached_prev_pos to
2479 -1. Fixes slow-down at the beginning of a buffer.
2480
f25e39b4
EZ
24812011-07-24 Eli Zaretskii <eliz@gnu.org>
2482
2483 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2484 for attrs[LFACE_FONTSET_INDEX].
2485
04c4b52e
PE
24862011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2487
2488 * xml.c (parse_region): Remove unused local
2489 that was recently introduced.
2490
c1734fbd
EZ
24912011-07-23 Eli Zaretskii <eliz@gnu.org>
2492
be18c5a5
EZ
2493 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2494 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2495
c1734fbd
EZ
2496 * xdisp.c (move_it_in_display_line_to): Record the best matching
2497 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2498 exit if none of the characters scanned was an exact match.
2499 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2500 when exact match is impossible due to invisible text, and the
2501 lines are truncated.
2502
a258d627
JD
25032011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2504
2505 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2506 for OSX >= 10.7.
2507
b6d5a689
EZ
25082011-07-22 Eli Zaretskii <eliz@gnu.org>
2509
0f74f785
EZ
2510 Fix a significant slow-down of cursor motion with C-n, C-p,
2511 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2512 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2513 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2514 (next_element_from_buffer): Call compute_stop_pos_backwards to
2515 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2516 base_level_stop.
2517 (reseat): Don't look for prev_stop, as that could mean a very long
2518 run.
2519 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2520 <cached_disp_overlay_modiff>: Cache for last found display string
2521 position.
551918c1 2522 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2523 about the same buffer in the same area of character positions, and
2524 the buffer wasn't changed since the time the display string
2525 position was cached.
551918c1 2526
b2d0c91a
EZ
25272011-07-22 Eli Zaretskii <eliz@gnu.org>
2528
2529 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2530 is an integer, which is important for empty lines. (Bug#9149)
2531
043604ee
CY
25322011-07-22 Chong Yidong <cyd@stupidchicken.com>
2533
2534 * frame.c (Fmodify_frame_parameters): In tty case, update the
2535 default face if necessary (Bug#4238).
2536
da4adb04
CY
25372011-07-21 Chong Yidong <cyd@stupidchicken.com>
2538
2539 * editfns.c (Fstring_to_char): No need to explain what a character
2540 is in the docstring (Bug#6576).
2541
9abd0532
LMI
25422011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2543
2544 * xml.c (parse_region): Make sure we always return a tree.
2545
36881d16
HK
25462011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2547
2548 * xml.c (parse_region): If a document contains only comments,
2549 return that, too.
2550
1e98674d
LMI
25512011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2552
2553 * xml.c (make_dom): Return comments, too.
2554
590bd467
PE
25552011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2556
2557 Port to OpenBSD.
2558 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2559 and the surrounding thread.
2560 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2561 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2562 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2563 timer goes off.
2564 * s/openbsd.h (BROKEN_SIGIO): Define.
2565 * unexelf.c (unexec) [__OpenBSD__]:
2566 Don't update the .mdebug section of the Alpha COFF symbol table.
2567
f41628b2
LMI
25682011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2569
2570 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2571 (bug#8460).
2572
b59b67c5
PE
25732011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2574
15e3a074
PE
2575 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2576 This fixes some race conditions on the permissions of any newly
2577 created file.
2578
41bed37d
PE
2579 * alloc.c (valid_pointer_p): Use pipe, not open.
2580 This fixes some permissions issues when debugging.
2581
b59b67c5
PE
2582 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2583 If fchown fails to set both uid and gid, try to set just gid,
2584 as that is sometimes allowed. Adjust the file's mode to eliminate
2585 setuid or setgid bits that are inappropriate if fchown fails.
2586
925a6be7
SM
25872011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2588
2589 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2590 to compare Lisp_Objects.
2591 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2592 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2593 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2594
52968808
AS
25952011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2596
0a6a104b
AS
2597 * lread.c (read_integer): Unread even EOF character.
2598 (read1): Likewise. Properly record start position of symbol.
2599
52968808
AS
2600 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2601 symbol character follows.
2602
9e381cdd
PE
26032011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2604
2605 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2606 This works around a problem with the previous change to Fcopy_file.
2607 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2608 and without this change, GCC might complain about discarding
2609 fchown's return value.
2610
b5641435
JB
26112011-07-16 Juanma Barranquero <lekktu@gmail.com>
2612
2613 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2614
a8031457
PE
26152011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2616
2617 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2618
dd889327
LMI
26192011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2620
750c33f7
LMI
2621 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2622 it's used from the C level.
2623
dd889327
LMI
2624 * process.c: Use the same condition for POLL_FOR_INPUT in both
2625 keyboard.c and process.c (bug#1858).
2626
87e86684
LM
26272011-07-09 Lawrence Mitchell <wence@gmx.li>
2628
2629 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2630 (Fgnutls_boot): Use it.
2631
64348f40
AS
26322011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2633
2634 * doc.c (Fsubstitute_command_keys): Revert last change.
2635
1d698799
LMI
26362011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2637
f863868c
LMI
2638 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2639 quotes the next character, and doesn't affect other longer
2640 sequences (bug#8935).
2641
1d698799
LMI
2642 * lread.c (syms_of_lread): Clarify that is isn't only
2643 `eval-buffer' and `eval-defun' that's affected by
2644 `lexical-binding' (bug#8460).
2645
aa4b6df6
EZ
26462011-07-15 Eli Zaretskii <eliz@gnu.org>
2647
2648 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2649 bidi redisplay when a line includes both an image and is
2650 truncated.
2651
5d856da6
PE
26522011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2653
ad6042bb
PE
2654 Fix minor problems found by static checking.
2655 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2656 (elsz): Now a signed constant, not a size_t var. We prefer signed
2657 types to unsigned, to avoid integer comparison confusion. Without
2658 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2659 "cannot optimize loop, the loop counter may overflow", a symptom
2660 of the confusion.
f00bbb22 2661 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2662 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2663
6468f31c
LMI
26642011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2665
49080b10
LMI
2666 * search.c (Fre_search_backward): Mention `case-fold-search' in
2667 all the re_search_* functions (bug#8138).
2668
6468f31c
LMI
2669 * keyboard.c (Fopen_dribble_file): Document when the file is
2670 closed (bug#8056).
2671
c965adc5
EZ
26722011-07-14 Eli Zaretskii <eliz@gnu.org>
2673
df9733bf
EZ
2674 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2675 bidi_cache_idx.
2676
0bb23927
EZ
2677 Support bidi reordering of display and overlay strings.
2678 * xdisp.c (compute_display_string_pos)
2679 (compute_display_string_end): Accept additional argument STRING.
2680 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2681 (reseat_to_string): Initialize bidi_it->string.s and
2682 bidi_it->string.schars.
2683 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2684 NULL (avoids a crash in bidi_paragraph_init).
2685 Initialize itb.string.lstring.
0bb23927
EZ
2686 (init_iterator): Call bidi_init_it only of a valid
2687 buffer position was specified. Initialize paragraph_embedding to
2688 L2R.
2689 (reseat_to_string): Initialize the bidi iterator.
2690 (display_string): If we need to ignore text properties of
2691 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2692 original value of -1 will not work with bidi.)
2693 (compute_display_string_pos): First arg is now struct
2694 `text_pos *'; all callers changed. Support display properties on
2695 Lisp strings.
2696 (compute_display_string_end): Support display properties on Lisp
2697 strings.
2698 (init_iterator, reseat_1, reseat_to_string): Initialize the
2699 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2700 when iterating on a string not from display properties).
640c8776
SM
2701 (compute_display_string_pos, compute_display_string_end):
2702 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2703 arrow keys.
2704 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2705 base_level_stop; instead, set base_level_stop to BEGV.
2706 Fixes crashes in vertical-motion.
0bb23927
EZ
2707 (next_element_from_buffer): Improve commentary for when
2708 the iterator is before prev_stop.
2709 (init_iterator): Initialize bidi_p from the default value of
2710 bidi-display-reordering, not from buffer-local value. Use the
2711 buffer-local value only if initializing for buffer iteration.
2712 (handle_invisible_prop): Support invisible properties on strings
2713 that are being bidi-reordered.
2714 (set_iterator_to_next): Support bidi reordering of C strings and
2715 Lisp strings.
2716 (next_element_from_string): Support bidi reordering of Lisp
2717 strings.
2718 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2719 (display_string): Support display of R2L glyph rows.
2720 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2721 (init_iterator): Don't initialize it->bidi_p for strings
2722 here.
2723 (reseat_to_string): Initialize it->bidi_p for strings here.
2724 (next_element_from_string, next_element_from_c_string)
2725 (next_element_from_buffer): Add xassert's for correspondence
2726 between IT's object being iterated and it->bidi_it.string
2727 structure.
2728 (face_before_or_after_it_pos): Support bidi iteration.
2729 (next_element_from_c_string): Handle the case of the first string
2730 character that is not the first one in the visual order.
2731 (get_visually_first_element): New function, refactored from common
2732 parts of next_element_from_buffer, next_element_from_string, and
2733 next_element_from_c_string.
2734 (tool_bar_lines_needed, redisplay_tool_bar)
2735 (display_menu_bar): Force left-to-right direction. Add a FIXME
2736 comment for making that be controlled by a user option.
2737 (push_it, pop_it): Save and restore the state of the
2738 bidi iterator. Save and restore the bidi_p flag.
2739 (pop_it): Iterate out of display property for string iteration as
2740 well.
2741 (iterate_out_of_display_property): Support iteration over strings.
2742 (handle_single_display_spec): Set up it->bidi_it for iteration
2743 over a display string, and call bidi_init_it.
2744 (handle_single_display_spec, next_overlay_string)
2745 (get_overlay_strings_1, push_display_prop): Set up the bidi
2746 iterator for displaying display or overlay strings.
2747 (forward_to_next_line_start): Don't use the shortcut if
2748 bidi-iterating.
2749 (back_to_previous_visible_line_start): If handle_display_prop
2750 pushed the iterator stack, restore the internal state of the bidi
2751 iterator by calling bidi_pop_it same number of times.
2752 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2753 and we are bidi-iterating, don't decrement the iterator position;
2754 instead, set the first_elt flag in the bidi iterator, to produce
2755 the same effect.
2756 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2757 (push_display_prop): xassert that we are iterating a buffer.
2758 (push_it, pop_it): Save and restore paragraph_embedding member.
2759 (handle_single_display_spec, next_overlay_string)
2760 (get_overlay_strings_1, reseat_1, reseat_to_string)
2761 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2762 correctly. Don't assume unibyte strings are not bidi-reordered.
2763 (compute_display_string_pos)
2764 (compute_display_string_end): Fix handling the case of C string.
2765 (push_it, pop_it): Save and restore from_disp_prop_p.
2766 (handle_single_display_spec, push_display_prop): Set the
2767 from_disp_prop_p flag.
2768 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2769 (pop_it): Call iterate_out_of_display_property only if we are
2770 popping after iteration over a string that came from a display
2771 property. Fix a typo in popping stretch info. Add an assertion
2772 for verifying that the iterator position is in sync with the bidi
2773 iterator.
2774 (handle_single_display_spec, get_overlay_strings_1)
2775 (push_display_prop): Fix initialization of paragraph direction for
2776 string when that of the parent object is not yet determined.
2777 (reseat_1): Call bidi_init_it to resync the bidi
2778 iterator with IT's position. (Bug#7616)
2779 (find_row_edges): If ROW->start.pos gives position
2780 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2781 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2782 Reset the from_disp_prop_p flag.
2783 (SAVE_IT, RESTORE_IT): New macros.
2784 (pos_visible_p, face_before_or_after_it_pos)
2785 (back_to_previous_visible_line_start)
2786 (move_it_in_display_line_to, move_it_in_display_line)
2787 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2788 (try_scrolling, redisplay_window, display_line): Use them when
2789 saving a temporary copy of the iterator and restoring it back.
2790 (back_to_previous_visible_line_start, reseat_1)
2791 (init_iterator): Empty the bidi cache "stack".
2792 (move_it_in_display_line_to): If iterator ended up at
2793 EOL, but we never saw any buffer positions smaller than
2794 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2795 motion in bidi-reordered lines.
2796 (move_it_in_display_line_to): Record prev_method and prev_pos
2797 immediately before the call to set_iterator_to_next. Fixes cursor
2798 motion in bidi-reordered lines with stretch glyphs and strings
2799 displayed in margins. (Bug#8133) (Bug#8867)
2800 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2801 TO_CHARPOS.
640c8776
SM
2802 (pos_visible_p): Support positions in bidi-reordered lines.
2803 Save and restore bidi cache.
0bb23927
EZ
2804
2805 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2806 (bidi_paragraph_info): Delete unused struct.
2807 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2808 (bidi_cache_start): New variable.
2809 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2810 to zero.
2811 (bidi_cache_fetch_state, bidi_cache_search)
2812 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2813 (bidi_cache_find, bidi_peek_at_next_level)
2814 (bidi_level_of_next_char, bidi_find_other_level_edge)
2815 (bidi_move_to_visually_next): Compare cache index with
2816 bidi_cache_start rather than with zero.
2817 (bidi_fetch_char): Accept new argument STRING; all callers
2818 changed. Support iteration over a string. Support strings with
2819 display properties. Support unibyte strings. Fix the type of
2820 `len' according to what STRING_CHAR_AND_LENGTH expects.
2821 (bidi_paragraph_init, bidi_resolve_explicit_1)
2822 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2823 (bidi_level_of_next_char, bidi_move_to_visually_next):
2824 Support iteration over a string.
0bb23927
EZ
2825 (bidi_set_sor_type, bidi_resolve_explicit_1)
2826 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2827 can now be zero (for strings); special values 0 and -1 were
2828 changed to -1 and -2, respectively.
2829 (bidi_char_at_pos): New function.
2830 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2831 Call it instead of FETCH_MULTIBYTE_CHAR.
2832 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2833 initialized to valid values.
2834 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2835 values.
2836 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2837 the test for valid cached positions. Fix the logic for looking up
2838 the sentinel state in the cache. GCPRO the Lisp string we are
2839 iterating.
2840 (bidi_push_it, bidi_pop_it): New functions.
2841 (bidi_initialize): Initialize the bidi cache start stack pointer.
2842 (bidi_cache_ensure_space): New function, refactored from part of
2843 bidi_cache_iterator_state. Don't assume the required size is just
2844 one BIDI_CACHE_CHUNK away.
2845 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2846 (bidi_count_bytes, bidi_char_at_pos): New functions.
2847 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2848 always valid if bidi_cache_idx is valid.
2849 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2850 is valid if it's going to be used.
2851 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2852 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2853 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2854 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2855 (bidi_find_other_level_edge, bidi_cache_start_stack):
2856 All variables related to cache indices are now EMACS_INT.
c965adc5 2857
0bb23927
EZ
2858 * dispextern.h (struct bidi_string_data): New structure.
2859 (struct bidi_it): New member `string'. Make flag members be 1-bit
2860 fields, and put them last in the struct.
640c8776
SM
2861 (compute_display_string_pos, compute_display_string_end):
2862 Update prototypes.
0bb23927
EZ
2863 (bidi_push_it, bidi_pop_it): Add prototypes.
2864 (struct iterator_stack_entry): New members bidi_p,
2865 paragraph_embedding, and from_disp_prop_p.
2866 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2867 (bidi_shelve_cache, bidi_unshelve_cache):
2868 Declare prototypes.
0bb23927
EZ
2869
2870 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2871 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2872 and vector-like objects.
2873
2874 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2875 cache around display iteration.
2876
2877 * window.c (Fwindow_end, window_scroll_pixel_based)
2878 (displayed_window_lines, Frecenter): Save and restore the bidi
2879 cache around display iteration.
2880
3bbd2265
LMI
28812011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2882
2883 * editfns.c (Fdelete_region): Clarify the use of the named
2884 parameters (bug#6788).
2885
adc47434
MR
28862011-07-14 Martin Rudalics <rudalics@gmx.at>
2887
2888 * indent.c (Fvertical_motion): Set and restore w->pointm when
2889 saving and restoring the window's buffer (Bug#9006).
2890
837c31f8
LMI
28912011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2892
2893 * editfns.c (Fstring_to_char): Clarify just what is returned
2894 (bug#6576). Text by Eli Zaretskii.
2895
ac389d0c
JB
28962011-07-13 Juanma Barranquero <lekktu@gmail.com>
2897
2898 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2899
0be0ce47
EZ
29002011-07-13 Eli Zaretskii <eliz@gnu.org>
2901
2902 * buffer.c (mmap_find): Fix a typo.
2903
cd18e7e3
JB
29042011-07-13 Johan Bockgård <bojohan@gnu.org>
2905
2906 Fix execution of x selection hooks.
2907 * xselect.c (Qx_lost_selection_functions)
2908 (Qx_sent_selection_functions): New vars.
2909 (syms_of_xselect): DEFSYM them.
2910 (x_handle_selection_request): Pass Qx_sent_selection_functions
2911 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2912 (x_handle_selection_clear,x_clear_frame_selections):
2913 Pass Qx_lost_selection_functions rather than
2914 Vx_lost_selection_functions to Frun_hook_with_args.
2915
47ea7f44
PE
29162011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2917
ac389d0c 2918 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2919 The old code sometimes used this field without initializing it.
2920
47ea7f44
PE
2921 * alloc.c (gc_sweep): Don't read past end of array.
2922 In theory, the old code could also have corrupted Emacs internals,
2923 though it'd be very unlikely.
2924
bc985c87
AS
29252011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2926
2927 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2928 argument. (Bug#4026)
bc985c87 2929
0cf34688
LMI
29302011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2931
b3dadd76
LMI
2932 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2933 key" (bug#4257).
2934
0cf34688
LMI
2935 * window.c (Fset_window_start): Doc fix (bug#4199).
2936 (Fset_window_hscroll): Ditto.
2937
270768cd
PE
29382011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2939
077e3dda 2940 Fix minor new problems caught by GCC 4.6.1.
270768cd 2941 * term.c (init_tty): Remove unused local.
490011a6 2942 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2943 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2944 not used otherwise.
270768cd 2945
b1f58454
CY
29462011-07-12 Chong Yidong <cyd@stupidchicken.com>
2947
2948 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2949
22b9578d
LMI
29502011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2951
6e70ab07
LMI
2952 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2953 are the mini-buffer and the echo area (bug#3320).
2954
22b9578d
LMI
2955 * term.c (init_tty): Remove support for supdup, c10 and perq
2956 terminals, which are no longer supported (bug#1482).
2957
8974cc9f
JB
29582011-07-10 Johan Bockgård <bojohan@gnu.org>
2959
2960 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2961
a560d974
JD
29622011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2963
2964 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2965 for non-popups (Bug#3642).
2966
1dae0f0a
AS
29672011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2968
268c2c36 2969 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2970 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2971 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2972 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2973 * data.c (fmod): Likewise.
2974 * dispnew.c (swap_glyphs_in_rows): Likewise.
2975 * emacs.c (memory_warning_signal): Likewise.
2976 * floatfns.c (float_error): Likewise.
2977 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2978 (otf_open, font_otf_capability, generate_otf_features)
2979 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2980 Likewise.
2981 * image.c (pbm_read_file): Likewise.
2982 * indent.c (string_display_width): Likewise.
2983 * intervals.c (check_for_interval, search_for_interval)
2984 (inc_interval_count, count_intervals, root_interval)
2985 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2986 * lread.c (defalias): Likewise.
268c2c36 2987 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2988 * regex.c (set_image_of_range_1, set_image_of_range)
2989 (regex_grow_registers): Likewise.
2990 * sysdep.c (strerror): Likewise.
2991 * termcap.c (valid_filename_p, tprint, main): Likewise.
2992 * tparam.c (main): Likewise.
2993 * unexhp9k800.c (run_time_remap, save_data_space)
2994 (update_file_ptrs, read_header, write_header, calculate_checksum)
2995 (copy_file, copy_rest, display_header): Likewise.
2996 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2997 Likewise.
2998 * xdisp.c (check_it): Likewise.
2999 * xfaces.c (register_color, unregister_color, unregister_colors):
3000 Likewise.
3001 * xfns.c (print_fontset_result): Likewise.
3002 * xrdb.c (member, fatal, main): Likewise.
3003
99033785
PE
30042011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3005
3006 Fix minor problems found by static checking (Bug#9031).
3007 * chartab.c (char_table_set_range, map_sub_char_table):
3008 Remove unused locals.
3009 (uniprop_table): Now static.
3010 * composite.c (_work_char): Remove unused static var.
3011
9cb2ac56
JB
30122011-07-09 Juanma Barranquero <lekktu@gmail.com>
3013
3014 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3015
f25661f0
JD
30162011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3017
3018 * gtkutil.c (qttip_cb): Remove code without function.
3019
8278c4fe
EZ
30202011-07-09 Eli Zaretskii <eliz@gnu.org>
3021
3022 * w32.c (pthread_sigmask): New stub.
3023
1692ae2d 30242011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3025
8a6ebd58 3026 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3027 sigprocmask is portable only for single-threaded applications, and
3028 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3029 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3030 (LIBES): Use it.
3031 * callproc.c (Fcall_process):
3032 * process.c (create_process):
3033 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3034 Use pthread_sigmask, not sigprocmask.
123403e4 3035
1b854618
JD
30362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3037
3038 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3039 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3040 wrong (Bug#8591).
3041
3fe4b549
JD
30422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3043
0ce7e563
JD
3044 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3045 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3046 (xg_hide_tooltip): Fix comment.
3047
3fe4b549
JD
3048 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3049 in registerServicesMenuSendTypes.
3050 (validRequestorForSendType): Don't check ns_return_types.
3051
3052 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3053 ns_return_type.
3054
5df75e47
JR
30552011-07-08 Jason Rumney <jasonr@gnu.org>
3056
3057 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3058 frame struct members of non-existent frames (Bug#6284).
3059
699c10bd
JD
30602011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3061
4393663b
JD
3062 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3063 variable firstTime not needed on OSX >= 10.6.
3064 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3065 >= 10.5. Use setKnobProportion, setDoubleValue.
3066
3067 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3068 (MAC_OS_X_VERSION_10_5): Define if not defined.
3069 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3070 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3071 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3072
3073 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3074 cString and lossyCString on OSX >= 10.4
3075
3076 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3077 sizeToFit on OSX >= 10.2.
3078
3079 * nsimage.m (allocInitFromFile): Don't use deprecated method
3080 bestRepresentationForDevice on OSX >= 10.6.
3081
3082 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3083 to avoid warning.
3084
3085 * emacs.c: Declare unexec_init_emacs_zone.
3086
a63e0781
JD
3087 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3088
699c10bd
JD
3089 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3090
3091 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3092 on svcsMenu (Bug#8842).
3093
3094 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3095 ns_return_types.
3096 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3097
3098 * nsterm.m (QUTF8_STRING): Declare.
3099 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3100 (validRequestorForSendType): Return type is (id).
3101 Change indexOfObjectIdenticalTo to indexOfObject.
3102 Check if we have local selection before returning self (Bug#8842).
3103 (writeSelectionToPasteboard): Put local selection into paste board
3104 if we have a local selection (Bug#8842).
3105 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3106
3107 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3108 (ns_get_local_selection): Declare.
3109
54e10184
LMI
31102011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3111
9888ff71
LMI
3112 * keymap.c (describe_map_tree): Don't insert a double newline at
3113 the end of the buffer (bug#1169) and return whether we inserted
3114 something.
3115
54e10184
LMI
3116 * callint.c (Fcall_interactively): Change "reading args" to
3117 "providing args" to try to clarify what it does (bug#1010).
3118
15fa4783
KH
31192011-07-07 Kenichi Handa <handa@m17n.org>
3120
3121 * composite.c (composition_compute_stop_pos): Ignore a static
3122 composition starting before CHARPOS (Bug#8915).
3123
3124 * xdisp.c (handle_composition_prop): Likewise.
3125
a8815b00
EZ
31262011-07-07 Eli Zaretskii <eliz@gnu.org>
3127
3128 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3129 (Bug#9015)
3130
ef7b981d 31312011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3132
3133 * character.h (unicode_category_t): New enum type.
3134
3135 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3136 (Qchar_code_property_table): New variable.
3137 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3138 (UNIPROP_COMPRESSED_FORM_P): New macros.
3139 (char_table_ascii): Uncompress the compressed values.
3140 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3141 Uncompress the compressed values.
ac389d0c 3142 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3143 (char_table_ref_and_range): Uncompress the compressed values.
3144 (sub_char_table_set): New arg is_uniprop. Callers changed.
3145 Uncompress the compressed values.
3146 (sub_char_table_set_range): Args changed. Callers changed.
3147 (char_table_set_range): Adjuted for the above change.
3148 (map_sub_char_table): Delete args default_val and parent. Add arg
3149 top. Give decoded values to a Lisp function.
640c8776 3150 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3151 values to a Lisp function. Gcpro more variables.
3152 (uniprop_table_uncompress)
3153 (uniprop_decode_value_run_length): New functions.
3154 (uniprop_decoder, uniprop_decoder_count): New variables.
3155 (uniprop_get_decoder, uniprop_encode_value_character)
3156 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3157 New functions.
3158 (uniprop_encoder, uniprop_encoder_count): New variables.
3159 (uniprop_get_encoder, uniprop_table)
3160 (Funicode_property_table_internal, Fget_unicode_property_internal)
3161 (Fput_unicode_property_internal): New functions.
3162 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3163 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3164 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3165 char-code-property-alist.
3166
640c8776 3167 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3168 Vunicode_category_table.
3169
640c8776 3170 * font.c (font_range): Adjust for the change of
c805dec0
KH
3171 Vunicode_category_table.
3172
76b397fb
DN
31732011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3174
3175 * m/iris4d.h: Remove file, move contents ...
3176 * s/irix6-5.h: ... here.
3177
22b4128e
PE
31782011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3179
3180 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3181 * alloc.c (mark_buffer):
3182 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3183 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3184 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3185 This isn't true in general, and it's particularly not true
3186 if Emacs is configured with --with-wide-int.
3187 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3188 New macros, used in the buffer.c change.
3189
869795d6
JD
31902011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3191
3192 * xsettings.c: Use both GConf and GSettings if both are available.
3193 (store_config_changed_event): Add comment.
3194 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3195 (store_tool_bar_style_changed): New functions.
5e617bc2 3196 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3197 (struct xsettings): Move font inside HAVE_XFT.
3198 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3199 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3200 Move inside HAVE_XFT.
640c8776 3201 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3202 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3203 also.
3204 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3205 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3206 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3207 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3208 (parse_settings): Move check for font inside HAVE_XFT.
3209 (read_settings, apply_xft_settings): Add comment.
3210 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3211 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3212 call store_font_name_changed.
3213 (xft_settings_event): Add comment.
3214 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3215 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3216 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3217 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3218 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3219 (xsettings_get_system_font, xsettings_get_system_normal_font):
3220 Add comment.
869795d6 3221
d8ed26bd
PE
32222011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3223
3224 Random fixes. E.g., (random) never returned negative values.
3225 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3226 subseconds part to the entropy, as that's a bit more random.
3227 Prefer signed to unsigned, since the signedness doesn't matter and
3228 in general we prefer signed. When given a limit, use a
3229 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3230 latter isn't right if USE_2_TAGS_FOR_INTS.
3231 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3232 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3233
cabf1cac
SM
32342011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3235
3236 * textprop.c (text_property_stickiness):
3237 Obey Vtext_property_default_nonsticky.
3238 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3239 * w32fns.c (syms_of_w32fns):
3240 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3241
6e9b2be9
PE
32422011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3243
3244 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3245 This is more efficient than Ffile_directory_p and avoids a minor race.
3246
90186c68
LMI
32472011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3248
7c301272
LMI
3249 * buffer.c (Foverlay_put): Say what the return value is
3250 (bug#7835).
3251
c4f2d8d4
LMI
3252 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3253 is a directory before asking whether to use the file name
3254 (bug#7564).
ad637907
LMI
3255 (barf_or_query_if_file_exists): Make the "File is a directory"
3256 error be more correct.
c4f2d8d4 3257
90186c68
LMI
3258 * fns.c (Frequire): Remove the mention of the .gz files, since
3259 that's installation-specific, but keep the mention of
3260 `get-load-suffixes'.
3261
da64016e
PE
32622011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3263
3264 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3265 Report string overflow if the output is too long.
3266
7d47b580
JB
32672011-07-04 Juanma Barranquero <lekktu@gmail.com>
3268
a555cb87
JB
3269 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3270 (syms_of_gnutls): Remove duplicate DEFSYM for
3271 Qgnutls_bootprop_verify_hostname_error, an error for
3272 Qgnutls_bootprop_verify_error (which is no longer used).
3273
7d47b580
JB
3274 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3275 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3276 Also (re)move comments that are misplaced or no longer relevant.
3277
1e49bfab
LMI
32782011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3279
3280 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3281
1485f4c0
CY
32822011-07-03 Chong Yidong <cyd@stupidchicken.com>
3283
3284 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3285 and background color parameters if they have been changed.
3286
a9ab721e
LMI
32872011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3288
3289 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3290
cf7cff57
PE
32912011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3292
2e13213d
PE
3293 * xsettings.c (SYSTEM_FONT): Define only when used.
3294 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3295
cf7cff57
PE
3296 * keymap.c (access_keymap_1): Now static.
3297
7a8e04f7
CY
32982011-07-02 Chong Yidong <cyd@stupidchicken.com>
3299
3300 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3301 leave any prefix arg for the up event (Bug#1586).
3302
61352f62
LMI
33032011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3304
69bb1ef7
LMI
3305 * lread.c (syms_of_lread): Mention single symbols defined by
3306 `defvar' or `defconst' (bug#7154).
3307
61352f62 3308 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3309 (Frequire): Mention get-load-suffixes.
61352f62 3310
28545e04
MR
33112011-07-02 Martin Rudalics <rudalics@gmx.at>
3312
3313 * window.h (window): Remove clone_number slot.
3314 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3315 Remove.
3316 (make_parent_window, make_window, saved_window)
3317 (Fset_window_configuration, save_window_save): Don't deal with
3318 clone numbers.
3319 * buffer.c (Qclone_number): Remove declaration.
3320 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3321
3349e122
SM
33222011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3323
3324 Add multiple inheritance to keymaps.
3325 * keymap.c (Fmake_composed_keymap): New function.
3326 (Fset_keymap_parent): Simplify.
3327 (fix_submap_inheritance): Remove.
3328 (access_keymap_1): New function extracted from access_keymap to handle
3329 embedded parents and handle lists of maps.
3330 (access_keymap): Use it.
3331 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3332 (Fcopy_keymap): Handle embedded parents.
3333 (Fcommand_remapping, define_as_prefix): Simplify.
3334 (Fkey_binding): Simplify.
3335 (syms_of_keymap): Move minibuffer-local-completion-map,
3336 minibuffer-local-filename-completion-map,
3337 minibuffer-local-must-match-map, and
3338 minibuffer-local-filename-must-match-map to Elisp.
3339 (syms_of_keymap): Defsubr make-composed-keymap.
3340 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3341 (parse_menu_item): Trivial simplification.
3342
3279eb87
GM
33432011-07-01 Glenn Morris <rgm@gnu.org>
3344
3345 * Makefile.in (SETTINGS_LIBS): Fix typo.
3346
4550efdf
KI
33472011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3348
3349 * coding.c (Fencode_coding_string): Record the last coding system
3350 used, as the function doc string says (bug#8738).
3351
0949d2b6
JD
33522011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3353
3354 * xsettings.c (store_monospaced_changed): Take new font as arg and
3355 check for change against current_mono_font.
3356 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3357 (emacs_settings_constructor, emacs_settings_get_property)
3358 (emacs_settings_set_property, emacs_settings_class_init)
3359 (emacs_settings_init, gsettings_obj): Remove.
3360 (something_changedCB): New function for HAVE_GSETTINGS.
3361 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3362 with value as argument.
3363 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3364 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3365 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3366 "changed".
3367
3368 * xgselect.c: Add defined (HAVE_GSETTINGS).
3369 (xgselect_initialize): Ditto.
3370
3371 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3372 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3373 xg_select.
3374
bbc6b304
PE
33752011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3376
3377 * eval.c (struct backtrace): Simplify and port the data structure.
3378 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3379 signed bit field, as this assumption is not portable and it makes
3380 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3381 "char debug_on_exit : 1" as this is not portable either; instead,
3382 use the portable "unsigned int debug_on_exit : 1". Remove unused
3383 member evalargs. Remove obsolete comments about cc bombing out.
3384
9851bfc5
JD
33852011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3386
51bb811f 3387 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3388 Let HAVE_GSETTINGS override HAVE_GCONF.
3389 (store_monospaced_changed): New function.
3390 (EMACS_SETTINGS): A new type derived from GObject to handle
3391 GSettings notifications.
3392 (emacs_settings_constructor, emacs_settings_get_property)
3393 (emacs_settings_set_property, emacs_settings_class_init):
3394 New functions.
3395 (gsettings_client, gsettings_obj): New variables.
3396 (GSETTINGS_SCHEMA): New define.
3397 (something_changedCB): Call store_monospaced_changed.
3398 (init_gsettings): New function.
3399 (xsettings_initialize): Call init_gsettings.
3400 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3401 to NULL.
3402
640c8776 3403 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3404 GCONF_CFLAGS/LIBS.
3405
5386012d
MR
34062011-06-29 Martin Rudalics <rudalics@gmx.at>
3407
3408 * window.c (resize_root_window, grow_mini_window)
3409 (shrink_mini_window): Rename Qresize_root_window to
3410 Qwindow_resize_root_window and Qresize_root_window_vertically to
3411 Qwindow_resize_root_window_vertically.
3412
f13e0b08
PE
34132011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3414
3415 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3416
94515237
JB
34172011-06-27 Juanma Barranquero <lekktu@gmail.com>
3418
3419 * makefile.w32-in: Redesign dependencies so they reflect more
3420 clearly which files are directly included by each source file,
3421 and not through other includes.
3422
e43b6e43
MR
34232011-06-27 Martin Rudalics <rudalics@gmx.at>
3424
3425 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3426 (sort_overlays, overlay_strings): When an overlay's clone number
3427 matches the window's clone number process the overlay even if
3428 the overlay's window property doesn't match the current window.
3429
d68443dc
MR
3430 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3431 (Fwindow_hchild): Rename to Fwindow_left_child.
3432 (Fwindow_next): Rename to Fwindow_next_sibling.
3433 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3434 (resize_window_check): Rename to window_resize_check.
3435 (resize_window_apply): Rename to window_resize_apply.
3436 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3437 (Fdelete_other_windows_internal, resize_frame_windows)
3438 (Fsplit_window_internal, Fdelete_window_internal)
3439 (grow_mini_window, shrink_mini_window)
3440 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3441
c7e73be5
JD
34422011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3443
3444 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3445 (emacs_fixed_set_min_size): Remove.
3446 (emacs_fixed_new): Take frame as argument.
3447
3448 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3449 (_EmacsFixedPrivate): Remove minwidth/height.
3450 Add struct frame *f.
3451 (emacs_fixed_init): Initialize priv->f.
3452 (get_parent_class, emacs_fixed_set_min_size): Remove.
3453 (emacs_fixed_new): Set priv->f to argument.
3454 (emacs_fixed_get_preferred_width)
3455 (emacs_fixed_get_preferred_height): Use min_width/height from
3456 frames size_hint to set minimum and natural (Bug#8919).
3457 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3458 and use min_width/height from frames size_hint to set
3459 min_width/height (Bug#8919).
3460
3461 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3462 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3463 Fix indentation.
c7e73be5 3464
cf99dcf8
EZ
34652011-06-26 Eli Zaretskii <eliz@gnu.org>
3466
3467 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3468 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3469 called at ZV.
3470
029529ac
CY
34712011-06-26 Chong Yidong <cyd@stupidchicken.com>
3472
3473 * process.c (wait_reading_process_output): Bypass select if
3474 waiting for a cell while ignoring keyboard input, and input is
3475 pending. Suggested by Jan Djärv (Bug#8869).
3476
7a7ef429
PE
34772011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3478
3479 Use gnulib's dup2 module instead of rolling our own.
3480 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3481
11fdef7d 34822011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3483
3484 * dispnew.c (scrolling_window): Before scrolling, turn off a
3485 mouse-highlight in the window being scrolled.
3486
cd3520a4
JB
34872011-06-24 Juanma Barranquero <lekktu@gmail.com>
3488
3489 Move DEFSYM to lisp.h and use everywhere.
3490
3491 * character.h (DEFSYM): Move declaration...
3492 * lisp.h (DEFSYM): ...here.
3493
3494 * gnutls.c:
3495 * minibuf.c:
3496 * w32menu.c:
3497 * w32proc.c:
3498 * w32select.c: Don't include character.h.
3499
3500 * alloc.c (syms_of_alloc):
3501 * buffer.c (syms_of_buffer):
3502 * bytecode.c (syms_of_bytecode):
3503 * callint.c (syms_of_callint):
3504 * casefiddle.c (syms_of_casefiddle):
3505 * casetab.c (init_casetab_once):
3506 * category.c (init_category_once, syms_of_category):
3507 * ccl.c (syms_of_ccl):
3508 * cmds.c (syms_of_cmds):
3509 * composite.c (syms_of_composite):
3510 * dbusbind.c (syms_of_dbusbind):
3511 * dired.c (syms_of_dired):
3512 * dispnew.c (syms_of_display):
3513 * doc.c (syms_of_doc):
3514 * editfns.c (syms_of_editfns):
3515 * emacs.c (syms_of_emacs):
3516 * eval.c (syms_of_eval):
3517 * fileio.c (syms_of_fileio):
3518 * fns.c (syms_of_fns):
3519 * frame.c (syms_of_frame):
3520 * fringe.c (syms_of_fringe):
3521 * insdel.c (syms_of_insdel):
3522 * keymap.c (syms_of_keymap):
3523 * lread.c (init_obarray, syms_of_lread):
3524 * macros.c (syms_of_macros):
3525 * msdos.c (syms_of_msdos):
3526 * print.c (syms_of_print):
3527 * process.c (syms_of_process):
3528 * search.c (syms_of_search):
3529 * sound.c (syms_of_sound):
3530 * syntax.c (init_syntax_once, syms_of_syntax):
3531 * terminal.c (syms_of_terminal):
3532 * textprop.c (syms_of_textprop):
3533 * undo.c (syms_of_undo):
3534 * w32.c (globals_of_w32):
3535 * window.c (syms_of_window):
3536 * xdisp.c (syms_of_xdisp):
3537 * xfaces.c (syms_of_xfaces):
3538 * xfns.c (syms_of_xfns):
3539 * xmenu.c (syms_of_xmenu):
3540 * xsettings.c (syms_of_xsettings):
3541 * xterm.c (syms_of_xterm): Use DEFSYM.
3542
4228cf16
TZ
35432011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3544
cd3520a4 3545 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3546
7fcccf1e
PE
35472011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3548
7efb4e0e
PE
3549 Integer and buffer overflow fixes (Bug#8873).
3550
ff5844ad
PE
3551 * print.c (printchar, strout): Check for string overflow.
3552 (PRINTPREPARE, printchar, strout):
3553 Don't set size unless allocation succeeds.
3554
90532f02
PE
3555 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3556 for sizes. Check for string overflow more accurately.
3557 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3558
6d84508d
PE
3559 * macros.c: Integer and buffer overflow fixes.
3560 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3561 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3562 Use ptrdiff_t, not int, for sizes.
3563 Don't increment bufsize until after realloc succeeds.
3564 Check for size-calculation overflow.
3565 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3566
437b2cb4
PE
3567 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3568
8b9ac8b4
PE
3569 * lread.c: Integer overflow fixes.
3570 (read_integer): Radix is now EMACS_INT, not int,
3571 to improve quality of diagnostics for out-of-range radices.
3572 Calculate buffer size correctly for out-of-range radices.
3573 (read1): Check for integer overflow in radices, and in
3574 read-circle numbers.
82cb60d3
PE
3575 (read_escape): Avoid int overflow.
3576 (Fload, openp, read_buffer_size, read1)
3577 (substitute_object_recurse, read_vector, read_list, map_obarray):
3578 Use ptrdiff_t, not int, for sizes.
3579 (read1): Use EMACS_INT, not int, for sizes.
20270765 3580 Check for size overflow.
8b9ac8b4 3581
7fcccf1e
PE
3582 * image.c (cache_image): Check for size arithmetic overflow.
3583
bfbbd7e7
PE
3584 * lread.c: Integer overflow issues.
3585 (saved_doc_string_size, saved_doc_string_length)
3586 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3587 Now ptrdiff_t, not int.
3588 (read1): Don't assume doc string length fits in int. Check for
3589 out-of-range doc string lengths.
3590 (read_list): Don't assume file position fits in int.
39019e54 3591 (read_escape): Check for hex character overflow.
bfbbd7e7 3592
4e323265
LL
35932011-06-22 Leo Liu <sdl.web@gmail.com>
3594
3595 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3596 Move to minibuffer.el.
3597
85fece3e
PE
35982011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3599
20b84ce9 3600 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3601 The following patches are for when GLYPH_DEBUG && !XASSERT.
3602 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3603 * dispnew.c (flush_stdout):
3604 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3605 Mark as externally visible.
3606 * dispnew.c (check_window_matrix_pointers): Now static.
3607 * dispnew.c (window_to_frame_vpos):
3608 * xfns.c (unwind_create_frame):
3609 * xterm.c (x_check_font): Remove unused local.
3610 * scroll.c (CHECK_BOUNDS):
3611 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3612 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3613 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3614 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3615 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3616 Now static.
3617 (debug_method_add): Use va_list and vsprintf rather than relying
3618 on undefined behavior with wrong number of arguments.
3619 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3620 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3621 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3622 since we're not interested in debugging glyphs with old libraries.
3623 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3624 GCC 4.6.0's static checking.
3625
0766b489
PE
36262011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3627
31fd4b32
PE
3628 Integer overflow and signedness fixes (Bug#8873).
3629 A few related buffer overrun fixes, too.
3630
b79e8648
PE
3631 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3632
0766b489
PE
3633 * dispextern.h (struct face.stipple):
3634 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3635 (x_bitmap_mask, x_allocate_bitmap_record)
3636 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3637 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3638 (x_create_bitmap_from_xpm_data):
3639 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3640 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3641 (.bitmaps_last):
3642 * xfaces.c (load_pixmap):
3643 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3644 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3645 (.bitmaps_last, struct x_output.icon_bitmap):
3646 Use ptrdiff_t, not int, for bitmap indexes.
3647 (x_allocate_bitmap_record): Check for size overflow.
3648 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3649
b081724f
PE
3650 Use ptrdiff_t, not int, for overlay counts.
3651 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3652 * editfns.c (overlays_around, get_pos_property):
3653 * textprop.c (get_char_property_and_overlay):
3654 * xdisp.c (next_overlay_change, note_mouse_highlight):
3655 * xfaces.c (face_at_buffer_position):
21514da7
PE
3656 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3657 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3658 (Fnext_overlay_change, Fprevious_overlay_change)
3659 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3660 Use ptrdiff_t, not int, for sizes.
21514da7 3661 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3662
3de73e5e
PE
3663 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3664
2606c57b
PE
3665 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3666 (x_session_initialize): Do not assume string length fits in int.
3667
aaafe47a
PE
3668 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3669 This is unlikely, but can occur if DPI is outlandish.
3670
2674ddc8 3671 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3672 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3673
28154962
PE
3674 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3675 * xrdb.c (magic_file_p, search_magic_path):
3676 Omit last arg SUFFIX; it was always 0. All callers changed.
3677 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3678
7de51af5
PE
3679 * xfont.c (xfont_match): Avoid need for strlen.
3680
25ed6cc3
PE
3681 * xfns.c: Don't assume strlen fits in int.
3682 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3683
4eab31dd
PE
3684 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3685 not unsigned long, as we prefer signed integers. All callers changed.
3686 Detect integer overflow in repeat count.
3687 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3688 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3689
171e2a58
PE
3690 * termcap.c: Don't assume sizes fit in int and never overflow.
3691 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3692 (gobble_line): Check for size-calculation overflow.
3693
ad39faca 3694 * minibuf.c (Fread_buffer):
6e5bb2dc 3695 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3696 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3697 Don't assume string length fits in int.
3698
52c61c22 3699 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3700 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3701
b5b8c9e5
PE
3702 * font.c: Don't assume string length fits in int.
3703 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3704 Use ptrdiff_t, not int.
ccd6111c
PE
3705 (font_intern_prop): Don't assume string length fits in int.
3706 Don't assume integer property fits in fixnum.
3707 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3708
882f0d81 3709 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3710 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3711 Reformulate so as not to need the command string.
3712 Invoke gzip -cd rather than gunzip, as it's more portable.
3713 (lock_info_type, lock_file_1, lock_file):
3714 Don't assume pid_t and time_t fit in unsigned long.
3715 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3716 (current_lock_owner): Prefer signed type for sizes.
3717 Use memcpy, not strncpy, where memcpy is what is really wanted.
3718 Don't assume (via atoi) that time_t and pid_t fit in int.
3719 Check for time_t and/or pid_t out of range, e.g., via a network share.
3720 Don't alloca where an auto var works fine.
3721
93f4cf88
PE
3722 * fileio.c: Fix some integer overflow issues.
3723 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3724 Don't assume string length fits in int.
3725 (directory_file_name): Don't assume string length fits in long.
3726 (make_temp_name): Don't assume pid fits in int, or that its print
3727 length is less than 20.
3728
f3e92b69
PE
3729 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3730
1bfdaf10
PE
3731 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3732
35016e9a
PE
3733 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3734
3d1e65a1
PE
3735 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3736 We prefer signed integers, even for size calculations.
3737
0b963a93
PE
3738 * emacs.c: Don't assume string length fits in 'int'.
3739 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3740 (main): Don't invoke strlen when not needed.
3741
573f4b54
PE
3742 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3743 (XD_DEBUG_MESSAGE): Don't waste a byte.
3744
989f33ba
PE
3745 * callproc.c (getenv_internal_1, getenv_internal)
3746 (Fgetenv_internal):
965d34eb
PE
3747 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3748
e4d29b33
PE
3749 * lread.c (invalid_syntax): Omit length argument.
3750 All uses changed. This doesn't fix a bug, but it simplifies the
3751 code away from its former Hollerith-constant appearance, and it's
3752 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3753 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3754
eb49b136
PE
3755 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3756 This didn't break anything, but it didn't help either.
3757 It's confusing to put a bogus integer in a place where the actual
3758 value does not matter.
9f62aeb1 3759 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3760 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3761
15375a22
PE
3762 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3763 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3764 implementation.
b61cc01c
PE
3765 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3766 We prefer signed types, and the value cannot exceed the EMACS_INT
3767 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3768 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3769 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3770 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3771
53b2623d
PE
3772 * indent.c (sane_tab_width): New function.
3773 (current_column, scan_for_column, Findent_to, position_indentation)
3774 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3775 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3776
51cab52b 3777 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3778
f2ed8a70
PE
3779 * lisp.h (lint_assume): New macro.
3780 * composite.c (composition_gstring_put_cache):
3781 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3782
abe80cc6
PE
3783 * editfns.c, insdel.c:
3784 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3785
b02c740e
PE
3786 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3787
ebc96716
PE
3788 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3789
b4e50fa0 3790 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3791 Use much-faster test for byte-length change.
311d5d7c 3792 Don't assume string byte-length fits in 'int'.
a4cf38e4 3793 Check that character arg fits in 'int'.
85461888 3794 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3795
c0c1ee9f
PE
3796 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3797
a498d7f4
PE
3798 * fns.c (concat): Catch string overflow earlier.
3799 Do not rely on integer wraparound.
3800
51cab52b
PE
3801 * dispextern.h (struct it.overlay_strings_charpos)
3802 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3803 * xdisp.c (forward_to_next_line_start)
3804 (back_to_previous_visible_line_start)
3805 (reseat_at_next_visible_line_start, next_element_from_buffer):
3806 Don't arbitrarily truncate the value of 'selective' to int.
3807
76031fad
PE
3808 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3809
5eb55db9
PE
3810 * composite.c: Don't truncate sizes to 'int'.
3811 (composition_gstring_p, composition_reseat_it)
3812 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3813 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3814 not EMACS_UINT, for indexes.
5eb55db9 3815
0703a717
PE
3816 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3817
d6202519
PE
3818 * buffer.c: Include <verify.h>.
3819 (struct sortvec.priority, struct sortstr.priority):
8961a454 3820 Now EMACS_INT, not int.
c20998a7 3821 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3822 (struct sortstr.size, record_overlay_string)
3823 (struct sortstrlist.size, struct sortlist.used):
3824 Don't truncate size to int.
3825 (record_overlay_string): Check for size-calculation overflow.
d6202519 3826 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3827
d5a19415
JM
38282011-06-22 Jim Meyering <meyering@redhat.com>
3829
029529ac 3830 Don't leak an XBM-image-sized buffer
d5a19415
JM
3831 * image.c (xbm_load): Free the image buffer after using it.
3832
a9041e6c
PE
38332011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3834
3835 Port to Sun C.
3836 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3837 that Sun C diagnosed.
3838 * fns.c (secure_hash): Fix pointer signedness issue.
3839 * intervals.c (static_offset_intervals): New function.
3840 (offset_intervals): Use it.
3841
7f3f739f
LL
38422011-06-21 Leo Liu <sdl.web@gmail.com>
3843
3844 * deps.mk (fns.o):
3845 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3846 sha512.h.
3847
3848 * fns.c (secure_hash): Rename from crypto_hash_function and change
3849 the first arg to accept symbols.
5b66d427 3850 (Fsecure_hash): New primitive.
7f3f739f
LL
3851 (syms_of_fns): New symbols.
3852
76147d94
DD
38532011-06-20 Deniz Dogan <deniz@dogan.se>
3854
3855 * process.c (Fset_process_buffer): Clarify return value in
3856 docstring.
3857
7d7d0045
CY
38582011-06-18 Chong Yidong <cyd@stupidchicken.com>
3859
3860 * dispnew.c (add_window_display_history): Use BVAR.
3861
3862 * xdisp.c (debug_method_add): Use BVAR.
3863 (check_window_end, dump_glyph_matrix, dump_glyph)
3864 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3865
3866 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3867 Likewise.
3868
3869 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3870 check till after the cache is created in init_frame_faces.
3871
ff2bc410
SM
38722011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3873
3874 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3875
28177add
PE
38762011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3877
dd3482fe
PE
3878 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3879 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3880 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3881
393d71f3 3882 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3883 * fileio.c (Finsert_file_contents):
3884 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3885 Remove the old (too-loose) buffer overflow checks.
3886 They weren't needed, since make_gap checks for buffer overflow.
3887 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3888 The old code merely checked for Emacs fixnum overflow, and relied
3889 on undefined (wraparound) behavior. The new code avoids undefined
3890 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3891
2e6813b0 3892 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3893 Tune. Don't use wider integers than needed. Don't use alloca.
3894 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3895
599a9e4f
PE
3896 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3897
99561444
PE
3898 * insdel.c, lisp.h (buffer_overflow): New function.
3899 (insert_from_buffer_1, replace_range, replace_range_2):
3900 * insdel.c (make_gap_larger):
3901 * editfns.c (Finsert_char):
3902 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3903
28177add
PE
3904 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3905
e69dafad
PE
39062011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3907
a7af7fde 3908 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3909
b1c46f02
PE
3910 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3911 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3912
e69dafad
PE
3913 * fileio.c: Don't assume EMACS_INT fits in off_t.
3914 (emacs_lseek): New static function.
3915 (Finsert_file_contents, Fwrite_region): Use it.
3916 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3917
566684ea
PE
3918 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3919
e6966cd6
PE
3920 * fns.c: Don't overflow int when computing a list length.
3921 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3922 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3923 truncation on 64-bit hosts. Check for QUIT every
3924 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3925 faster and is responsive enough.
3926 (Flength): Report an error instead of overflowing an integer.
3927 (Fsafe_length): Return a float if the value is not representable
3928 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3929 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3930 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3931
dd0b0efb
PE
3932 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3933 (header_size, word_size): New constants.
3934 (allocate_vectorlike): Don't check size overflow here.
3935 (allocate_vector): Check it here instead, since this is the only
3936 caller of allocate_vectorlike that could cause overflow.
3937 Check that the new vector's length is representable as a fixnum.
3938
86fe5cfe
PE
3939 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3940 The previous code was bogus. For example, next_almost_prime (32)
3941 returned 39, which is undesirable as it is a multiple of 3; and
3942 next_almost_prime (24) returned 25, which is a multiple of 5 so
3943 why was the code bothering to check for multiples of 7?
3944
80e88859
PE
3945 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3946
4a2f0ad6
PE
3947 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3948
f66c7cf8
PE
3949 Variadic C functions now count arguments with ptrdiff_t.
3950 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3951 Back then I didn't know that the Emacs coding style prefers signed int.
3952 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3953 were being counted with int, which may truncate counts on 64-bit
3954 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3955 * lisp.h (struct Lisp_Subr.function.aMANY)
3956 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3957 Arg counts are now ptrdiff_t, not size_t.
3958 All variadic functions and their callers changed accordingly.
3959 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3960 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3961 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3962 * callint.c (Fcall_interactively): Check arg count for overflow,
3963 to avoid potential buffer overrun. Use signed char, not 'int',
3964 for 'varies' array, so that we needn't bother to check its size
3965 calculation for overflow.
3966 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3967 * eval.c (apply_lambda):
3968 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3969 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3970 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3971
a1759b76
PE
3972 * callint.c (Fcall_interactively): Don't use index var as event count.
3973
d96be9fc
PE
3974 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3975 * mem-limits.h (SIZE): Remove; no longer used.
3976
a690a978 3977 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3978
578c21e6
PE
3979 Remove unnecessary casts.
3980 * xterm.c (x_term_init):
3981 * xfns.c (x_set_border_pixel):
3982 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3983 These aren't needed now that we assume ANSI C.
3984
96f53c6c
PE
3985 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3986 It's more likely to cause problems (due to unsigned overflow)
3987 than to cure them.
3988
83c77d31
PE
3989 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3990
ee2079f1
PE
3991 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3992
6da65536
PE
3993 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3994
7147c4a4
PE
3995 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3996
193e32d9
PE
3997 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3998
e5533da6
PE
3999 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4000
9910e595
PE
4001 GLYPH_CODE_FACE returns EMACS_INT, not int.
4002 * dispextern.h (merge_faces):
4003 * xfaces.c (merge_faces):
01103c44
PE
4004 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4005 Don't assume EMACS_INT fits in int.
9910e595 4006
2638320e
PE
4007 * character.h (CHAR_VALID_P): Remove unused parameter.
4008 * fontset.c, lisp.h, xdisp.c: All uses changed.
4009
045eb8d9
PE
4010 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4011
c1f134b5
PE
4012 * fns.c (concat): Minor tuning based on overflow analysis.
4013 This doesn't fix any bugs. Use int to hold character, instead
4014 of constantly refetching from Emacs object. Use XFASTINT, not
4015 XINT, for value known to be a character. Don't bother comparing
4016 a single byte to 0400, as it's always less.
4017
395fcb93 4018 * floatfns.c (Fexpt):
327eeec8
PE
4019 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4020
abbd3d23
PE
4021 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4022 for characters.
4023
684a03ef
PE
4024 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4025
0fed43f3
PE
4026 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4027 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4028 incorrectly succeed when S was a string, because 4294967386 was
4029 truncated before it was used.
4030
8fd02eb7
PE
4031 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4032 Otherwise, an out-of-range integer could cause undefined behavior
4033 on a 64-bit host.
4034
f8c86b69
PE
4035 * composite.c: Use int, not EMACS_INT, for characters.
4036 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4037 EMACS_INT, for values that are known to be in character range.
4038 This doesn't fix any bugs but is the usual style inside Emacs and
4039 may generate better code on 32-bit machines.
4040
34206dd2
PE
4041 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4042 This is for reasons similar to the recent CHAR_STRING fix.
4043 * charset.c (Fencode_char): Check that character arg is actually
4044 a character. Pass an int to ENCODE_CHAR.
4045 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4046 wider than 'int', as a compile-time check to prevent future regressions
4047 in this area.
4048
c5958d4c 4049 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4050
4051 Make sure a 64-bit char is never passed to CHAR_STRING.
4052 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4053 by silently ignoring the top 32 bits, allowing some values
4054 that were far too large to be valid characters.
4055 * character.h: Include <verify.h>.
4056 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4057 arguments are no wider than unsigned, as a compile-time check
4058 to prevent future regressions in this area.
4059 * data.c (Faset):
01103c44 4060 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4061 (Fsubst_char_in_region):
4062 * fns.c (concat):
4063 * xdisp.c (decode_mode_spec_coding):
4064 Adjust to CHAR_STRING's new requirement.
4065 * editfns.c (Finsert_char, Fsubst_char_in_region):
4066 * fns.c (concat): Check that character args are actually
4067 characters. Without this test, these functions did the wrong
4068 thing with wildly out-of-range values on 64-bit hosts.
4069
d37ca623
PE
4070 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4071 These casts should not be needed on 32-bit hosts, either.
4072 * keyboard.c (read_char):
4073 * lread.c (Fload): Remove casts to unsigned.
4074
ea204efb
PE
4075 * lisp.h (UNSIGNED_CMP): New macro.
4076 This fixes comparison bugs on 64-bit hosts.
4077 (ASCII_CHAR_P): Use it.
4078 * casefiddle.c (casify_object):
01103c44 4079 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4080 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4081 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4082 * dispextern.h (FACE_FROM_ID):
4083 * keyboard.c (read_char): Use UNSIGNED_CMP.
4084
41cb286c
PE
4085 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4086 not to EMACS_INT, to avoid GCC warning.
4087
4a1b9832
PE
4088 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4089
55daad71
PE
4090 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4091 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4092 isn't needed on 32-bit machines.
8f95c75c 4093
01103c44
PE
4094 * buffer.c (Fgenerate_new_buffer_name):
4095 Use EMACS_INT for count, not int.
0ceccced 4096 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4097
4098 * data.c (Qcompiled_function): Now static.
4099
c6f072e7
PE
4100 * window.c (window_body_lines): Now static.
4101
20ce5912
PE
4102 * image.c (gif_load): Rename local to avoid shadowing.
4103
9c4c5f81
PE
4104 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4105 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4106 * alloc.c (make_save_value): Integer argument is now of type
4107 ptrdiff_t, not int.
4108 (mark_object): Use ptrdiff_t, not int.
4109 * lisp.h (pD): New macro.
4110 * print.c (print_object): Use it.
4111
c0c5c8ae
PE
4112 * alloc.c: Use EMACS_INT, not int, to count objects.
4113 (total_conses, total_markers, total_symbols, total_vector_size)
4114 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4115 (total_free_floats, total_floats, total_free_intervals)
4116 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4117 Now EMACS_INT, not int. All uses changed.
4118 (Fgarbage_collect): Compute overall total using a double, so that
4119 integer overflow is less likely to be a problem. Check for overflow
4120 when converting back to an integer.
5a25e253
PE
4121 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4122 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4123 These were 'int' variables that could overflow on 64-bit hosts;
4124 they were never used, so remove them instead of repairing them.
211a0b2a 4125 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4126 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4127 Previously, this ceilinged at INT_MAX, but that doesn't work on
4128 64-bit machines.
e46bb31a 4129 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4130
c78baabf 4131 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4132 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4133 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4134 when a (possibly-narrower) signed value would do just as well.
4135 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4136
c9d624c6
PE
4137 * alloc.c: Catch some string size overflows that we were missing.
4138 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4139 for convenience in STRING_BYTES_MAX.
4140 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4141 The definition here is exact; the one in lisp.h was approximate.
4142 (allocate_string_data): Check for string overflow. This catches
4143 some instances we weren't catching before. Also, it catches
4144 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4145 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4146 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4147
c9d624c6
PE
4148 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4149 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4150 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4151
353032ce
PE
4152 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4153
2bccce07
PE
4154 * alloc.c (Fmake_string): Check for out-of-range init.
4155
0ac30604
SM
41562011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4157
4158 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4159
c195f2de
JD
41602011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4161
4162 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4163 xg_get_default_scrollbar_width.
4164
4165 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4166 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4167 (style_changed_cb): Call update_theme_scrollbar_width and call
4168 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4169 all frames (Bug#8505).
4170 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4171 Call gtk_window_set_resizable if HAVE_GTK3.
4172 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4173 and height if HAVE_GTK3 (Bug#8505).
4174 (scroll_bar_width_for_theme): New variable.
4175 (update_theme_scrollbar_width): New function.
4176 (xg_get_default_scrollbar_width): Move code to
4177 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4178 (xg_initialize): Call update_theme_scrollbar_width.
4179
4180 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4181
4182 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4183
e10ac9f1
MR
41842011-06-12 Martin Rudalics <rudalics@gmx.at>
4185
4186 * frame.c (make_frame): Call other_buffer_safely instead of
4187 other_buffer.
4188
4189 * window.c (temp_output_buffer_show): Call display_buffer with
4190 second argument Vtemp_buffer_show_specifiers and reset latter
4191 immediately after the call.
4192 (Vtemp_buffer_show_specifiers): New variable.
4193 (auto_window_vscroll_p, next_screen_context_lines)
4194 (Vscroll_preserve_screen_position): Remove leading asterisks from
4195 doc-strings.
4196
2d3c217e 41972011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4198
7b7f97e8 4199 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4200 * buffer.c (Qclone_number): Remove for now, as it's unused.
4201 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4202 (record_buffer): Remove unused local.
4203 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4204 (set_frame_buffer_list): Remove; unused.
4205 * frame.h (other_visible_frames): Remove decl.
4206 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4207 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4208 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4209 if HAVE_GPM.
4210 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4211 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4212 Define only if HAVE_GPM.
4213 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4214 (update_hints_inhibit): Remove; never set. All uses removed.
4215 * widgetprv.h (emacsFrameClassRec): Remove decl.
4216 * window.c (delete_deletable_window): Now returns void, since it
4217 wasn't returning anything.
4218 (compare_window_configurations): Remove unused locals.
4219 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4220 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4221 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4222 the same widths as pointers. This follows up on the 2011-05-06 patch.
4223 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4224 * xterm.h: Likewise.
4225 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4226
1384b89e
JB
42272011-06-12 Juanma Barranquero <lekktu@gmail.com>
4228
4229 * makefile.w32-in: Update dependencies.
4230 (LISP_H): Add lib/intprops.h.
4231
1100a63c
CY
42322011-06-11 Chong Yidong <cyd@stupidchicken.com>
4233
4234 * image.c (gif_load): Add animation frame delay to the metadata.
4235 (syms_of_image): Use DEFSYM. New symbol `delay'.
4236
6198ccd0
MR
42372011-06-11 Martin Rudalics <rudalics@gmx.at>
4238
4239 * window.c (delete_deletable_window): Re-add.
4240 (Fset_window_configuration): Rewrite to handle dead buffers and
4241 consequently deletable windows.
4242 (window_tree, Fwindow_tree): Remove. Supply functionality in
4243 window.el.
4244 (compare_window_configurations): Simplify code.
4245
b6e3633c
AS
42462011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4247
1ab0dee5
AS
4248 * image.c (imagemagick_load_image): Fix type mismatch.
4249 (Fimagemagick_types): Likewise.
4250
b6e3633c
AS
4251 * window.h (replace_buffer_in_windows): Declare.
4252
9397e56f
MR
42532011-06-11 Martin Rudalics <rudalics@gmx.at>
4254
4255 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4256 Qclone_number. Remove external declaration of Qdelete_window.
4257 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4258 code.
640c8776
SM
4259 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4260 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4261 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4262 buffer list implementation.
4263 (other_buffer_safely): New function.
4264 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4265 calls to replace_buffer_in_windows and
4266 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4267 if allowed.
4268 (record_buffer): Inhibit quitting and rewrite using quittable
4269 functions. Run Qbuffer_list_update_hook if allowed.
4270 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4271 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4272 Move switch-to-buffer to window.el.
9397e56f
MR
4273 (bury-buffer): Move to window.el.
4274 (Vbuffer_list_update_hook): New variable.
4275
4276 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4277 section.
4278
4279 * window.h (resize_frame_windows): Move up in code.
4280 (Fwindow_frame): Remove EXFUN.
4281 (replace_buffer_in_all_windows): Remove prototype.
4282 (replace_buffer_in_windows_safely): Add prototype.
4283
4284 * window.c: Declare Qdelete_window static again. Move down
4285 declaration of select_count.
4286 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4287 (Fother_window): Move to window.el.
4288 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4289 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4290 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4291 window.el.
4292 (replace_buffer_in_windows): Implement by calling
4293 Qreplace_buffer_in_windows.
4294 (replace_buffer_in_all_windows): Remove with some functionality
4295 moved into replace_buffer_in_windows_safely.
4296 (replace_buffer_in_windows_safely): New function.
4297 (select_window_norecord, select_frame_norecord): Move in front
4298 of run_window_configuration_change_hook. Remove now obsolete
4299 declarations.
640c8776
SM
4300 (Fset_window_buffer): Rewrite doc-string.
4301 Call Qrecord_window_buffer.
9397e56f
MR
4302 (keys_of_window): Move binding for other-window to window.el.
4303
b50691aa
CY
43042011-06-11 Chong Yidong <cyd@stupidchicken.com>
4305
4306 * dispextern.h (struct image): Replace data member, whose int_val
4307 and ptr_val fields were not used by anything, with a single
4308 lisp_val object.
4309
4310 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4311 (gif_clear_image, gif_load, imagemagick_load_image)
4312 (gs_clear_image, gs_load): Callers changed.
4313
3f754b86
PE
43142011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4315
cca69397
PE
4316 * buffer.h: Include <time.h>, for time_t.
4317 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4318
109e28d0
PE
4319 Fix minor problems found by static checking.
4320
60737f02
PE
4321 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4322
4b66faf3
PE
4323 Make identifiers static if they are not used in other modules.
4324 * data.c (Qcompiled_function, Qframe, Qvector):
4325 * image.c (QimageMagick, Qsvg):
4326 * minibuf.c (Qmetadata):
4327 * window.c (resize_window_check, resize_root_window): Now static.
4328 * window.h (resize_window_check, resize_root_window): Remove decls.
4329
109e28d0
PE
4330 * window.c (window_deletion_count, delete_deletable_window):
4331 Remove; unused.
46a4ce9e
PE
4332 (window_body_lines): Now static.
4333 (Fdelete_other_windows_internal): Mark vars as initialized.
4334 Make sure 'resize_failed' is initialized.
4335 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4336 (resize_window_apply): Remove unused local.
4337 * window.h (delete_deletable_window): Remove decl.
4338
109e28d0 4339 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4340 (imagemagick_load_image): Fix pointer signedness problem by changing
4341 last arg from unsigned char * to char *. All uses changed.
4342 Also, fix a local for similar reasons.
4343 Remove unused locals. Remove locals to avoid shadowing.
4344 (fn_rsvg_handle_free): Remove; unused.
4345 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4346 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4347
3f754b86
PE
4348 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4349
2547adb1
CY
43502011-06-10 Chong Yidong <cyd@stupidchicken.com>
4351
4352 * image.c (gif_load): Fix omitted cast error introduced by
4353 2011-06-06 change.
4354
2c8e37d4
MR
43552011-06-10 Martin Rudalics <rudalics@gmx.at>
4356
4357 * window.h (resize_proportionally, orig_total_lines)
4358 (orig_top_line): Remove from window structure.
4359 (set_window_height, set_window_width, change_window_heights)
4360 (Fdelete_window): Remove prototypes.
4361 (resize_frame_windows): Remove duplicate declaration.
4362
440a42e3
EZ
43632011-06-10 Eli Zaretskii <eliz@gnu.org>
4364
4365 * window.h (resize_frame_windows, resize_window_check)
4366 (delete_deletable_window, resize_root_window)
4367 (resize_frame_windows): Declare prototypes.
4368
4369 * window.c (resize_window_apply): Make definition be "static" to
4370 match the prototype.
4371
562dd5e9
MR
43722011-06-10 Martin Rudalics <rudalics@gmx.at>
4373
4374 * window.c: Remove declarations of Qwindow_size_fixed,
4375 window_min_size_1, window_min_size_2, window_min_size,
4376 size_window, window_fixed_size_p, enlarge_window, delete_window.
4377 Remove static from declaration of Qdelete_window, it's
4378 temporarily needed by Fbury_buffer.
4379 (replace_window): Don't assign orig_top_line and
4380 orig_total_lines.
4381 (Fdelete_window, delete_window): Remove. Window deletion is
4382 handled by window.el.
640c8776
SM
4383 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4384 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4385 (Fdelete_other_windows): Remove. Deleting other windows is
4386 handled by window.el.
4387 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4388 handled in window.el.
4389 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4390 Window minimum sizes are handled in window.el.
4391 (shrink_windows, size_window, set_window_height)
4392 (set_window_width, change_window_heights, window_height)
4393 (window_width, CURBEG, CURSIZE, enlarge_window)
4394 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4395 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4396 handled in window.el.
4397 (make_dummy_parent): Rename to make_parent_window and give it a
4398 second argument horflag.
4399 (make_window): Don't set resize_proportionally any more.
4400 (Fsplit_window): Remove. Windows are split in window.el.
4401 (save_restore_action, save_restore_orig_size)
4402 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4403 Resize mini windows in window.el.
4404 (grow_mini_window, shrink_mini_window): Implement by calling
4405 Qresize_root_window_vertically, resize_window_check and
4406 resize_window_apply.
640c8776
SM
4407 (saved_window, Fset_window_configuration, save_window_save):
4408 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4409 resize_proportionally.
4410 (window_min_height, window_min_width): Move to window.el.
4411 (keys_of_window): Move bindings for delete-other-windows,
4412 split-window, delete-window and enlarge-window to window.el.
4413
4414 * buffer.c: Temporarily extern Qdelete_window.
4415 (Fbury_buffer): Temporarily call Qdelete_window instead of
4416 Fdelete_window (Fbury_buffer will move to window.el soon).
4417
4418 * frame.c (set_menu_bar_lines_1): Remove code handling
4419 orig_top_line and orig_total_lines.
4420
4421 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4422 set_window_height but set heights directly.
4423 (change_frame_size_1): Use resize_frame_windows.
4424
4425 * xdisp.c (init_xdisp): Don't use set_window_height but set
4426 heights directly.
4427
640c8776
SM
4428 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4429 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4430 run_window_configuration_change_hook.
4431
4432 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4433 instead of change_window_heights and run
4434 run_window_configuration_change_hook.
4435
1a13852e
MR
44362011-06-09 Martin Rudalics <rudalics@gmx.at>
4437
4438 * window.c (replace_window): Rename second argument REPLACEMENT to
4439 NEW. New third argument SETFLAG. Rewrite.
4440 (delete_window, make_dummy_parent): Call replace_window with
4441 third argument 1.
4442 (window_list_1): Move down in code.
4443 (run_window_configuration_change_hook): Move set_buffer part
4444 before select_frame_norecord part in order to unwind correctly.
4445 Rename count1 to count.
4446 (recombine_windows, delete_deletable_window, resize_root_window)
4447 (Fdelete_other_windows_internal)
4448 (Frun_window_configuration_change_hook, make_parent_window)
4449 (resize_window_check, resize_window_apply, Fresize_window_apply)
4450 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4451 (Fdelete_window_internal, Fresize_mini_window_internal):
4452 New functions.
1a13852e
MR
4453 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4454
f3d1777e
MR
44552011-06-08 Martin Rudalics <rudalics@gmx.at>
4456
496e208e
MR
4457 * window.h (window): Add some new members to window structure -
4458 normal_lines, normal_cols, new_total, new_normal, clone_number,
4459 splits, nest, prev_buffers, next_buffers.
4460 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4461 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4462
f3d1777e
MR
4463 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4464 Remove.
496e208e
MR
4465 (make_dummy_parent): Set new members of windows structure.
4466 (make_window): Move down in code. Handle new members of window
4467 structure.
4468 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4469 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4470 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4471 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4472 (Fset_window_next_buffers, Fset_window_clone_number):
4473 New functions.
496e208e
MR
4474 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4475 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4476 Doc-string fixes.
4477 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4478 Argument WINDOW can be now internal window too.
4479 (Fwindow_use_time): Move up in code.
4480 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4481 Rewrite doc-string.
4482 (Fset_window_configuration, saved_window)
4483 (Fcurrent_window_configuration, save_window_save): Handle new
4484 members of window structure.
b9e809c2
MR
4485 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4486 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4487 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4488 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4489 Qget_mru_window, Qresize_root_window,
4490 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4491 Qauto_buffer_name; staticpro them.
f3d1777e 4492
abde8f8c
MR
44932011-06-07 Martin Rudalics <rudalics@gmx.at>
4494
4495 * window.c (Fwindow_total_size, Fwindow_left_column)
4496 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4497 (Fwindow_list_1): New functions.
4498 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4499 (Fwindow_width, Fscroll_left, Fscroll_right):
4500 Use window_body_cols instead of window_box_text_cols.
4501 (delete_window, Fset_window_configuration):
4502 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4503 (delete_all_subwindows): Take a window as argument and not a
4504 structure. Rewrite.
190b47e6
MR
4505 (window_loop): Remove handling of GET_LRU_WINDOW and
4506 GET_LARGEST_WINDOW.
4507 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4508
4509 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4510 window_box_text_cols. delete_all_subwindows now takes a
4511 Lisp_Object as argument.
abde8f8c 4512
640c8776
SM
4513 * indent.c (compute_motion, Fcompute_motion):
4514 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4515
fa8a67e6
MR
4516 * frame.c (delete_frame): Call delete_all_subwindows with root
4517 window as argument.
4518
a54e3482
DC
45192011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4520
4521 * fns.c (Fputhash): Document return value.
4522
60002bf5
CY
45232011-06-06 Chong Yidong <cyd@stupidchicken.com>
4524
4525 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4526
0c671da6 45272011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4528
b862a52a 4529 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4530
be44ca6c
PE
4531 Check for overflow when converting integer to cons and back.
4532 * charset.c (Fdefine_charset_internal, Fdecode_char):
4533 Use cons_to_unsigned to catch overflow.
4534 (Fencode_char): Use INTEGER_TO_CONS.
4535 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4536 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4537 * data.c (long_to_cons, cons_to_long): Remove.
4538 (cons_to_unsigned, cons_to_signed): New functions.
4539 These signal an error for invalid or out-of-range values.
4540 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4541 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4542 * font.c (Ffont_variation_glyphs):
4543 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4544 * lisp.h: Include <intprops.h>.
4545 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4546 (cons_to_signed, cons_to_unsigned): New decls.
4547 (long_to_cons, cons_to_long): Remove decls.
4548 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4549 (Fprimitive_undo): Use CONS_TO_INTEGER.
4550 * xfns.c (Fx_window_property): Likewise.
4551 * xselect.c: Include <limits.h>.
4552 (x_own_selection, selection_data_to_lisp_data):
4553 Use INTEGER_TO_CONS.
4554 (x_handle_selection_request, x_handle_selection_clear)
4555 (x_get_foreign_selection, Fx_disown_selection_internal)
4556 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4557 (lisp_data_to_selection_data): Use cons_to_unsigned.
4558 (x_fill_property_data): Use cons_to_signed.
4559 Report values out of range.
4560
d1f3d2af
PE
4561 Check for buffer and string overflow more precisely.
4562 * buffer.h (BUF_BYTES_MAX): New macro.
4563 * lisp.h (STRING_BYTES_MAX): New macro.
4564 * alloc.c (Fmake_string):
4565 * character.c (string_escape_byte8):
4566 * coding.c (coding_alloc_by_realloc):
4567 * doprnt.c (doprnt):
4568 * editfns.c (Fformat):
4569 * eval.c (verror):
4570 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4571 since they may not be the same number.
4572 * editfns.c (Finsert_char):
4573 * fileio.c (Finsert_file_contents):
4574 Likewise for BUF_BYTES_MAX.
4575
dd52fcea
PE
4576 * image.c: Use ptrdiff_t, not int, for sizes.
4577 (slurp_file): Switch from int to ptrdiff_t.
4578 All uses changed.
4579 (slurp_file): Check that file size fits in both size_t (for
4580 malloc) and ptrdiff_t (for sanity and safety).
4581
7f9bbdbb
PE
4582 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4583 if b->modtime has its maximal value.
4584
dfe18f82
PE
4585 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4586
84acfcf0
PE
4587 Don't assume time_t can fit into int.
4588 * buffer.h (struct buffer.modtime): Now time_t, not int.
4589 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4590 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4591
ccd9a01a
PE
4592 Minor fixes for signed vs unsigned integers.
4593 * character.h (MAYBE_UNIFY_CHAR):
4594 * charset.c (maybe_unify_char):
4595 * keyboard.c (read_char, reorder_modifiers):
4596 XINT -> XFASTINT, since the integer must be nonnegative.
4597 * ftfont.c (ftfont_spec_pattern):
4598 * keymap.c (access_keymap, silly_event_symbol_error):
4599 XUINT -> XFASTINT, since the integer must be nonnegative.
4600 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4601 since it makes no difference and we prefer signed.
4602 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4603 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4604 nonnegative.
4605
d6d100dd
SM
46062011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4607
4608 * window.h (Fwindow_frame): Declare.
4609
2b6148e4
PE
46102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4611
4612 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4613 (SPARE_MEMORY): Always define.
4614 (LARGE_REQUEST): Remove.
4615 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4616
f230ecc9
MR
46172011-06-06 Martin Rudalics <rudalics@gmx.at>
4618
727e958e
MR
4619 * lisp.h: Move EXFUNS for Fframe_root_window,
4620 Fframe_first_window and Fset_frame_selected_window to window.h.
4621
4622 * window.h: Move EXFUNS for Fframe_root_window,
4623 Fframe_first_window and Fset_frame_selected_window here from
4624 lisp.h.
4625
4626 * frame.c (Fwindow_frame, Fframe_first_window)
4627 (Fframe_root_window, Fframe_selected_window)
4628 (Fset_frame_selected_window): Move to window.c.
4629 (Factive_minibuffer_window): Move to minibuf.c.
4630 (Fother_visible_frames_p): New function.
4631
4632 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4633
f230ecc9
MR
4634 * window.c (decode_window, decode_any_window): Move up in code.
4635 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4636 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4637 (Fwindow_buffer): Move up and rewrite doc-string.
4638 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4639 (Fwindow_prev): New functions.
727e958e
MR
4640 (Fwindow_frame): Move here from frame.c. Accept any window as
4641 argument.
4642 (Fframe_root_window, Fframe_first_window)
4643 (Fframe_selected_window): Move here from frame.c. Accept frame
4644 or arbitrary window as argument. Update doc-strings.
4645 (Fminibuffer_window): Move up in code.
4646 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4647 (Fset_frame_selected_window): Move here from frame.c.
4648 Marginal rewrite.
727e958e
MR
4649 (Fselected_window, select_window, Fselect_window): Move up in
4650 code. Minor doc-string fixes.
f230ecc9 4651
4d09bcf6
PE
46522011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4653
4654 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4655 Do not assume that spare memory exists; that assumption is valid
4656 only if SYSTEM_MALLOC.
4657 (LARGE_REQUEST): New macro, so that the issue of large requests
4658 is separated from the issue of spare memory.
4659
810928a2
AS
46602011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4661
172418ad
AS
4662 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4663 format. (Bug#8806)
4664
43f862f7
AS
4665 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4666
810928a2
AS
4667 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4668 before statements.
4669
a059fe24
JD
46702011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4671
4672 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4673
4674 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4675
4676 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4677 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4678
989bf368
JB
46792011-06-05 Juanma Barranquero <lekktu@gmail.com>
4680
4681 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4682
4b80f674
CY
46832011-06-04 Chong Yidong <cyd@stupidchicken.com>
4684
4685 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4686 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4687 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4688 New error handlers.
4b80f674
CY
4689 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4690 Obey Vx_select_enable_clipboard_manager. Catch errors in
4691 x_clipboard_manager_save (Bug#8779).
4692 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4693 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4694
99a33b77 46952011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4696
4697 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4698
99a33b77 46992011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4700
4701 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4702 in the current matrix if keep_current_p is non-zero.
4703
8264569d
EZ
47042011-06-04 Eli Zaretskii <eliz@gnu.org>
4705
4706 * bidi.c (bidi_level_of_next_char): Fix last change.
4707
57f97249
EZ
47082011-06-03 Eli Zaretskii <eliz@gnu.org>
4709
fec2107c 4710 Support bidi reordering of text covered by display properties.
57f97249 4711
fec2107c
EZ
4712 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4713 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4714 (bidi_cache_search, bidi_cache_iterator_state)
4715 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4716 (bidi_level_of_next_char, bidi_move_to_visually_next):
4717 Support character positions inside a run of characters covered by a
fec2107c
EZ
4718 display string.
4719 (bidi_paragraph_init, bidi_resolve_explicit_1)
4720 (bidi_level_of_next_char): Call bidi_fetch_char and
4721 bidi_fetch_char_advance instead of FETCH_CHAR and
4722 FETCH_CHAR_ADVANCE.
4723 (bidi_init_it): Initialize new members.
4724 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4725 definitions.
4726 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4727 instead of using explicit *_CHAR codes.
d6d100dd
SM
4728 (bidi_resolve_explicit, bidi_resolve_weak):
4729 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4730 bidirectional text is supported only in multibyte buffers.
4731 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4732 it to initialize the frame_window_p member of struct bidi_it.
4733 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4734 (bidi_resolve_explicit, bidi_resolve_weak)
4735 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4736 bidi_it->nchars is non-positive.
4737 (bidi_level_of_next_char): Don't try to lookup the cache for the
4738 next/previous character if nothing is cached there yet, or if we
4739 were just reseat()'ed to a new position.
c40e2fb2 4740
0e14fe90
EZ
4741 * xdisp.c (set_cursor_from_row): Set start and stop points
4742 according to the row's direction when priming the loop that looks
4743 for the glyph on which to display cursor.
4744 (single_display_spec_intangible_p): Function deleted.
4745 (display_prop_intangible_p): Reimplement to call
4746 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4747 Accept 3 additional arguments needed by handle_display_spec.
4748 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4749 values: lists, `(when COND...)' forms, etc.
4750 (single_display_spec_string_p): Support property values that are
4751 lists with the argument STRING its top-level element.
4752 (display_prop_string_p): Fix the condition for processing a
4753 property that is a list to be consistent with handle_display_spec.
fec2107c 4754 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4755 last portion of handle_display_prop.
4756 (compute_display_string_pos): Accept additional argument
4757 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4758 value of a `display' property is a "replacing spec".
4759 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4760 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4761 the display property, but just return a value indicating whether
4762 the display property will replace the characters it covers.
4763 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4764 frame_window_p members of struct bidi_it.
d6d100dd
SM
4765 (compute_display_string_pos, compute_display_string_end):
4766 New functions.
fec2107c
EZ
4767 (push_it): Accept second argument POSITION, where pop_it should
4768 jump to continue iteration.
4769 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4770
fec2107c
EZ
4771 * keyboard.c (adjust_point_for_property): Adjust the call to
4772 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4773
4774 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4775 (bidi_init_it): Update prototypes.
4776 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4777 (compute_display_string_pos, compute_display_string_end):
4778 Declare prototypes.
fec2107c
EZ
4779 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4780 EMACS_INT.
fc6f18ce 4781
40087514 47822011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4783
57f53182
PE
4784 Malloc failure behavior now depends on size of allocation.
4785 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4786 * lisp.h: Change signatures accordingly.
4787 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4788 All callers changed. (Bug#8762)
4789
4790 * gnutls.c: Use Emacs's memory allocators.
4791 Without this change, the gnutls library would invoke malloc etc.
4792 directly, which causes problems on non-SYNC_INPUT hosts, and which
4793 runs afoul of improving memory_full behavior. (Bug#8761)
4794 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4795 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4796 xfree instead of the default malloc, realloc, free.
4797 (Fgnutls_boot): No need to check for memory allocation failure,
4798 since xmalloc does that for us.
4799
ac32cd99 4800 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4801 * category.c (hash_get_category_set):
4802 * ccl.c (ccl_driver):
4803 * charset.c (Fdefine_charset_internal):
4804 * charset.h (struct charset.hash_index):
4805 * composite.c (get_composition_id, gstring_lookup_cache)
4806 (composition_gstring_put_cache):
4807 * composite.h (struct composition.hash_index):
4808 * dispextern.h (struct image.hash):
4809 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4810 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4811 (hashfn_equal, hashfn_user_defined, make_hash_table)
4812 (maybe_resize_hash_table, hash_lookup, hash_put)
4813 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4814 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4815 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4816 * image.c (make_image, search_image_cache, lookup_image)
4817 (xpm_put_color_table_h):
4818 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4819 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4820 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4821 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4822 * alloc.c (allocate_vectorlike):
4823 Check for overflow in vector size calculations.
4824 * ccl.c (ccl_driver):
4825 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4826 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4827 need to be updated by these changes.
40087514
PE
4828 * fns.c (make_hash_table, maybe_resize_hash_table):
4829 Check for integer overflow with large hash tables.
0de4bb68
PE
4830 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4831 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4832 (SXHASH_REDUCE): New macro.
4833 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4834 Use it instead of discarding useful hash info with large hash values.
4835 (sxhash_float): New function.
4836 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4837 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4838 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4839 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4840 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4841 Adjust signatures to match updated version of code.
4842 (consing_since_gc): Now EMACS_INT, since a single hash table can
4843 use more than INT_MAX bytes.
4844
698d32e2
DN
48452011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4846
4847 Make it possible to build with GCC-4.6+ -O2 -flto.
4848
4849 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4850
fd6fa53f
SM
48512011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4852
4853 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4854 Call minibuffer-inactive-mode.
4855
864db017
JB
48562011-05-31 Juanma Barranquero <lekktu@gmail.com>
4857
4858 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4859 Update dependencies.
4860
2ad0baf4
DN
48612011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4862
4863 * data.c (init_data): Remove code for UTS, this system is not
4864 supported anymore.
4865
4fcc2638
DN
48662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4867
4868 Don't force ./temacs to start in terminal mode.
4869
4870 * frame.c (make_initial_frame): Initialize faces in all cases, not
4871 only when CANNOT_DUMP is defined.
4872 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4873
c56e0fd5
DN
48742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4875
4876 * dispnew.c (add_window_display_history): Use const for the string
4877 pointer. Remove declaration, not needed.
4878
333d54da 48792011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4880
55d4c1b2 4881 Use 'inline', not 'INLINE'.
333d54da 4882 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4883 * alloc.c, fontset.c (INLINE): Remove.
4884 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4885 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4886 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4887 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4888 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4889
738db178
DN
48902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4891
4892 Make it possible to run ./temacs.
4893
4894 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4895 syms_of_callproc does the same thing. Remove test for
4896 "initialized", do it in the caller.
4897 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4898
620c53a6
SM
48992011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4900
4901 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4902 (read_minibuf): Use get_minibuffer.
4903 (syms_of_minibuf): Use DEFSYM.
4904 (Qmetadata): New var.
4905 * data.c (Qbuffer): Don't make it static.
4906 (syms_of_data): Use DEFSYM.
4907
e003a292
PE
49082011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4909
4910 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4911 (CCL_CODE_MIN): New macro.
4912
ed008a6d
PE
49132011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4914
3687c2ef
PE
4915 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4916
ed008a6d
PE
4917 * eval.c (Qdebug): Now static.
4918 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4919 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4920 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4921
d66c4c7c
CY
49222011-05-29 Chong Yidong <cyd@stupidchicken.com>
4923
4924 * image.c: Various fixes to ImageMagick code comments.
4925 (Fimagemagick_types): Doc fix.
4926
5fbc2025
PE
49272011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4928
0196f88a
PE
4929 Minor fixes prompted by GCC 4.6.0 warnings.
4930
4931 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4932
5fbc2025
PE
4933 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4934 (x_clipboard_manager_save_all): Move extern decl to ...
4935 * xterm.h: ... here, so that it can be checked for consistency.
4936
1dd3c2d9
CY
49372011-05-29 Chong Yidong <cyd@stupidchicken.com>
4938
4939 * xselect.c (x_clipboard_manager_save_frame)
4940 (x_clipboard_manager_save_all): New functions.
4941 (Fx_clipboard_manager_save): Lisp function deleted.
4942
4943 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4944 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4945
4946 * xterm.h: Update prototype.
4947
5ba6571d
WX
49482011-05-28 William Xu <william.xwl@gmail.com>
4949
4950 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4951 exiting (Bug#8239).
4952
3eaff834
JM
49532011-05-28 Jim Meyering <meyering@redhat.com>
4954
e1900994 4955 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4956 * fns.c (to_uchar): Define.
4957 (crypto_hash_function): Use it to convert some newly-signed
4958 variables to unsigned, to avoid sign-extension bugs. For example,
4959 without this change, (md5 "truc") would evaluate to
4960 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4961 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4962 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4963
0f6990a7
PE
49642011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4965
4966 Integer overflow fixes.
c8a9ca5a 4967
08686060
PE
4968 * dbusbind.c: Serial number integer overflow fixes.
4969 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4970 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4971 to hold a serial number that is too large for a fixnum.
4972 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4973 Check for serial numbers out of range. Decode any serial number
59568bf0 4974 that was so large that it became a float. (Bug#8722)
08686060 4975
2d1fc3c7
PE
4976 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4977 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4978 Use XFASTINT rather than XUINT when numbers are nonnegative.
4979 (xd_append_arg, Fdbus_method_return_internal):
4980 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4981 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4982 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4983 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4984 (Bug#8722)
2d1fc3c7 4985
c8a9ca5a
PE
4986 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4987
519e1d69
PE
4988 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4989
30569699
PE
4990 ccl: add integer overflow checks
4991 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4992 (IN_INT_RANGE): New macros.
4993 (ccl_driver): Use them to check for integer overflow when
4994 decoding a CCL program. Many of the new checks are whether XINT (x)
4995 fits in int; it doesn't always, on 64-bit hosts. The new version
4996 doesn't catch all possible integer overflows, but it's an
847044ea 4997 improvement. (Bug#8719)
30569699 4998
c11285dc
PE
4999 * alloc.c (make_event_array): Use XINT, not XUINT.
5000 There's no need for unsigned here.
5001
fdccd48e
PE
5002 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5003 This follows up to the 2011-05-06 change that substituted uintptr_t
5004 for EMACS_INT. This case wasn't caught back then.
5005
37910ab2
PE
5006 Rework Fformat to avoid integer overflow issues.
5007 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5008 now (part of C89). Include <verify.h>.
5009 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5010 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5011 (Fformat): Avoid the prepass trying to compute sizes; it was only
5012 approximate and thus did not catch overflow reliably. Instead, walk
5013 through the format just once, formatting and computing sizes as we go,
5014 checking for integer overflow at every step, and allocating a larger
5015 buffer as needed. Keep track separately whether the format is
5016 multibyte. Keep only the most-recently calculated precision, rather
5017 than them all. Record whether each argument has been converted to
5018 string. Use EMACS_INT, not int, for byte and char and arg counts.
5019 Support field widths and precisions larger than INT_MAX. Avoid
5020 sprintf's undefined behavior with conversion specifications such as %#d
5021 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5022 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5023 formatting out-of-range floating point numbers with int
9173deec 5024 formats. (Bug#8668)
37910ab2 5025
2e6578fb
PE
5026 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5027
0ae6bdee
PE
5028 * data.c: Avoid integer truncation in expressions involving floats.
5029 * data.c: Include <intprops.h>.
5030 (arith_driver): When there's an integer overflow in an expression
5031 involving floating point, convert the integers to floating point
5032 so that the resulting value does not suffer from catastrophic
5033 integer truncation. For example, on a 64-bit host (* 4
5034 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5035 Do not rely on undefined behavior after integer overflow.
5036
de883a70
PE
5037 merge count_size_as_multibyte, parse_str_to_multibyte
5038 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5039 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5040 Check for integer overflow.
5041 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5042 since it's now a duplicate of the other. This is more of
5043 a character than a buffer op, so better that it's in character.c.
5044 * fns.c, print.c: Adjust to above changes.
5045
2ff916cb
PE
50462011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5047
5048 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5049
f1b54466
PE
50502011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5051
fb1ac845
PE
5052 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5053 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5054 (x_clipboard_manager_save): Now static.
5055 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5056
f1b54466
PE
5057 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5058 (crypto_hash_function): Now static.
5059 Fix pointer signedness problems. Avoid unnecessary initializations.
5060
a9f737ee
CY
50612011-05-27 Chong Yidong <cyd@stupidchicken.com>
5062
5063 * termhooks.h (Vselection_alist): Make it terminal-local.
5064
5065 * terminal.c (create_terminal): Initialize it.
5066
5067 * xselect.c: Support for clipboard managers.
5068 (Vselection_alist): Move to termhooks.h as terminal-local var.
5069 (LOCAL_SELECTION): New macro.
5070 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5071 (symbol_to_x_atom): Remove gratuitous arg.
5072 (x_handle_selection_request, lisp_data_to_selection_data)
5073 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5074 (x_own_selection, x_get_local_selection, x_convert_selection):
5075 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5076 (some_frame_on_display): Delete unused function.
5077 (Fx_own_selection_internal, Fx_get_selection_internal)
5078 (Fx_disown_selection_internal, Fx_selection_owner_p)
5079 (Fx_selection_exists_p): New optional frame arg.
5080 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5081 (x_handle_selection_clear): Don't treat other terminals with the
5082 same keyboard specially. Use the terminal-local Vselection_alist.
5083 (x_clear_frame_selections): Use Frun_hook_with_args.
5084
5085 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5086
5087 * xterm.h: Add support for those atoms.
5088
e067f0c1
CY
50892011-05-26 Chong Yidong <cyd@stupidchicken.com>
5090
5091 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5092 (converted_selections, conversion_fail_tag): New global variables.
5093 (x_selection_request_lisp_error): Free the above.
5094 (x_get_local_selection): Remove unnecessary code.
5095 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5096 of converted selections stored in converted_selections.
5097 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5098 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5099 (x_convert_selection): New function.
5100 (x_handle_selection_event): Simplify.
5101 (x_get_foreign_selection): Don't ignore incoming requests while
5102 waiting for an answer; this will fail when we implement
5103 SAVE_TARGETS, and seems unnecessary anyway.
5104 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5105 (Vx_sent_selection_functions): Doc fix.
5106
0f4aebc0
LL
51072011-05-26 Leo Liu <sdl.web@gmail.com>
5108
5109 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5110
e61124cd
YM
51112011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5112
5113 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5114
5115 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5116 for fringe update if it has periodic bitmap.
ac389d0c 5117 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5118 and fringe_bitmap_periodic_p.
5119
5120 * fringe.c (get_fringe_bitmap_data): New function.
5121 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5122 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5123 row. Mark glyph row for fringe update if periodicity changed.
5124
5125 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5126 for fringe update unless it has periodic bitmap.
5127
f16d9837
KH
51282011-05-25 Kenichi Handa <handa@m17n.org>
5129
5130 * xdisp.c (get_next_display_element): Set correct it->face_id for
5131 a static composition.
5132
e1b90ef6
LL
51332011-05-24 Leo Liu <sdl.web@gmail.com>
5134
5135 * deps.mk (fns.o):
5136 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5137
5138 * fns.c (crypto_hash_function, Fsha1): New function.
5139 (Fmd5): Use crypto_hash_function.
5140 (syms_of_fns): Add Ssha1.
5141
7400048f
PE
51422011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5143
5144 * gnutls.c: Remove unused macros.
5145 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5146 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5147 Remove macros that are defined and never used.
5148 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5149
abb71cf4
CY
51502011-05-22 Chong Yidong <cyd@stupidchicken.com>
5151
5152 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5153 (Fx_get_selection_internal): Minor cleanup.
5154 (Fx_own_selection_internal): Rename arguments for consistency with
5155 select.el.
5156
6307db39
PE
51572011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5158
5159 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5160
f3d4e0a4
CY
51612011-05-22 Chong Yidong <cyd@stupidchicken.com>
5162
5163 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5164
4d8ade89
YM
51652011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5166
5167 * dispnew.c (scrolling_window): Don't exclude the case that the
5168 last enabled row in the desired matrix touches the bottom boundary.
5169
32078c8d
GM
51702011-05-21 Glenn Morris <rgm@gnu.org>
5171
5172 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5173 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5174 and add some more files.
32078c8d 5175
7285dc67
EZ
51762011-05-20 Eli Zaretskii <eliz@gnu.org>
5177
5178 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5179 report_file_error introduced by the change from 2011-05-07.
5180
89d1bd22
PE
51812011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5182
5183 * systime.h (Time): Define only if emacs is defined.
5184 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5185 where the include path doesn't have X11/X.h by default. See
5186 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5187
e23640bb 51882011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5189
5190 * composite.c (find_automatic_composition): Fix previous change.
5191
b9704ad9
GM
51922011-05-20 Glenn Morris <rgm@gnu.org>
5193
5194 * lisp.mk: New file, split from Makefile.in.
5195 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5196 (shortlisp): Remove.
5197 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5198
4a720484
GM
51992011-05-19 Glenn Morris <rgm@gnu.org>
5200
5201 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5202 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5203 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5204 (lisp): Set the order to that of loadup.el.
5205 (shortlisp): Make it a copy of $lisp.
5206 (SOME_MACHINE_LISP): Remove.
5207 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5208 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5209
a28d4396
KH
52102011-05-18 Kenichi Handa <handa@m17n.org>
5211
5212 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5213 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5214 (find_automatic_composition): Mostly rewrite for efficiency.
5215
a2b1fa8e
JB
52162011-05-18 Juanma Barranquero <lekktu@gmail.com>
5217
5218 * makefile.w32-in: Update dependencies.
5219
8e1f5610
CS
52202011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5221
5222 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5223 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5224
7025ee00 52252011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5226
cdfa6eab
PE
5227 Fix some integer overflow issues, such as string length overflow.
5228
06d6db33
PE
5229 * insdel.c (count_size_as_multibyte): Check for string overflow.
5230
2b4560a8
PE
5231 * character.c (lisp_string_width): Check for string overflow.
5232 Use EMACS_INT, not int, for string indexes and lengths; in
5233 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5234 the resulting string length overflows an EMACS_INT; instead,
5235 report a string overflow if no precision given. When checking for
5236 precision exhaustion, use a check that cannot possibly have
5237 integer overflow. (Bug#8675)
5238 * character.h (lisp_string_width): Adjust to new signature.
5239
cb93f9be
PE
5240 * alloc.c (string_overflow): New function.
5241 (Fmake_string): Use it. This doesn't change behavior, but saves
5242 a few bytes and will simplify future changes.
5243 * character.c (string_escape_byte8): Likewise.
5244 * lisp.h (string_overflow): New decl.
5245
1a1f3366
PE
5246 Fixups, following up to the user-interface timestamp change.
5247 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5248 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5249 * msdos.c (mouse_get_pos): Likewise.
5250 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5251 * w32gui.h (Time): Define by including "systime.h" rather than by
5252 declaring it ourselves. (Bug#8664)
5253
d4e3e4d3
PE
5254 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5255 * image.c (clear_image_cache): Likewise.
5256
f6a24d19
PE
5257 * term.c (term_mouse_position): Don't assume time_t wraparound.
5258
08dc5ae6
PE
5259 Be more systematic about user-interface timestamps.
5260 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5261 and sometimes 'EMACS_UINT', to represent these timestamps.
5262 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5263 This makes the code easier to follow, and makes it easier to catch
5264 integer overflow bugs such as Bug#8664.
5265 * frame.c (Fmouse_position, Fmouse_pixel_position):
5266 Use Time, not unsigned long, for user-interface timestamps.
5267 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5268 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5269 * keyboard.h (last_event_timestamp): Likewise.
5270 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5271 * menu.h (xmenu_show): Likewise.
5272 * term.c (term_mouse_position): Likewise.
5273 * termhooks.h (struct input_event.timestamp): Likewise.
5274 (struct terminal.mouse_position_hook): Likewise.
5275 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5276 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5277 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5278 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5279 what it was before.
5280 * menu.h, termhooks.h: Include "systime.h", for Time.
5281
8e55734a
PE
5282 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5283 Don't assume that the difference between two unsigned long values
5284 can fit into an integer. At this point, we know button_down_time
5285 <= event->timestamp, so the difference must be nonnegative, so
5286 there's no need to cast the result if double-click-time is
5287 nonnegative, as it should be; check that it's nonnegative, just in
5288 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5289 apart (about 25 days). (Bug#8664)
8e55734a 5290
841f1b75 5291 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5292 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5293
3e26f69c
PE
5294 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5295 that always fit in int. Use a sentinel instead of a counter, to
5296 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5297 * frame.h (struct frame): Use int for menu_bar_items_used
5298 instead of EMACS_INT, since it always fits in int.
3e26f69c 5299
5cc152c0
PE
5300 * menu.c (grow_menu_items): Check for int overflow.
5301
d89eb65e
PE
5302 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5303
5235bd3e
PE
5304 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5305 Before, the code was not consistent. These values cannot exceed
5306 2**31 - 1 so there's no need to make them unsigned.
5307 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5308 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5309 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5310 as modifiers.
5311 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5312
bc827e23
PE
5313 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5314 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5315 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5316 presumably because the widths might not match.
5317
78eb494e
PE
5318 * window.c (size_window): Avoid needless test at loop start.
5319
04f2d78b
CB
53202011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5321
5322 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5323
d2fc7e3d 53242011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5325
5326 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5327
d2fc7e3d 53282011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5329
5330 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5331 `width' to `bar_area_x' and `bar_area_width', respectively.
5332 (x_scroll_run): Take account of fringe background extension.
5333
04f2d78b
CB
5334 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5335 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5336 `bar_area_width', respectively.
5337 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5338 background extension.
5339
79b70037
GM
53402011-05-10 Jim Meyering <meyering@redhat.com>
5341
5342 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5343
2f142cc5
JB
53442011-05-10 Juanma Barranquero <lekktu@gmail.com>
5345
5346 * image.c (Finit_image_library): Return t for built-in image types,
5347 like pbm and xbm. (Bug#8640)
5348
57679c86
AS
53492011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5350
5351 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5352
888c9e86
EZ
53532011-05-07 Eli Zaretskii <eliz@gnu.org>
5354
b0512a1d
EZ
5355 * w32console.c (Fset_screen_color): Doc fix.
5356 (Fget_screen_color): New function.
5357 (syms_of_ntterm): Defsubr it.
5358
7285dc67
EZ
5359 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5360 unlink the temporary file if Fcall_process didn't create it in the
5361 first place.
5362 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5363 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5364 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5365 cue to call_process_cleanup not to close that handle.
5366
4d3fcc8e
BK
53672011-05-07 Ben Key <bkey76@gmail.com>
5368
5369 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5370 one of two shell specific rules, either bootstrap-temacs-CMD or
5371 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5372 to the previous implementation of the bootstrap-temacs rule.
5373 The bootstrap-temacs-CMD rule is similar to the previous
5374 implementation of the bootstrap-temacs rule except that it
5375 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5376 variable.
5377
5378 These changes, along with some changes to nt/configure.bat,
5379 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5380 earlier fix to add support for --cflags and --ldflags options
5381 that include quotes so that it works whether make uses cmd or
5382 sh as the shell.
5383
b4289b64
MA
53842011-05-06 Michael Albinus <michael.albinus@gmx.de>
5385
5386 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5387 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5388 is a constant.
5389 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5390 a string. Handle both cases.
5391 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5392 (Fdbus_register_method): Use Qinvalid_function.
5393
af4c0e28
JB
53942011-05-06 Juanma Barranquero <lekktu@gmail.com>
5395
5396 * makefile.w32-in: Update dependencies.
5397 (LISP_H): Add inttypes.h and stdin.h.
5398 (PROCESS_H): Add unistd.h.
5399
c51453d9
EZ
54002011-05-06 Eli Zaretskii <eliz@gnu.org>
5401
5402 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5403 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5404
8ff0ac3c 54052011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5406
4c4b566b
PE
5407 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5408
aab2b9b5
PE
5409 * term.c (vfatal): Remove stray call to va_end.
5410 It's not needed and the C Standard doesn't allow it here anyway.
5411
c378da0b
PE
5412 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5413 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5414
288b08c7
PE
5415 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5416 bytes.
5417
e3601888
PE
5418 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5419
db6c0e74
PE
5420 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5421
dd5963ea
PE
5422 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5423
88c9450f
PE
5424 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5425
2f9442b8
PE
5426 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5427
c032b5f8
PE
5428 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5429 * charset.c (Fdefine_charset_internal): Don't initialize
5430 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5431 32-bit int (Bug#8600).
a108c10b
PE
5432
5433 * lread.c (read_integer): Be more consistent with string-to-number.
5434 Use string_to_number to do the actual conversion; this avoids
5435 rounding errors and fixes some other screwups. Without this fix,
5436 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5437 (digit_to_number): Move earlier, for benefit of read_integer.
5438 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5439 not a digit in any supported base. (Bug#8602)
a108c10b 5440
ad5f9eea
PE
5441 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5442
aec1708a
PE
5443 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5444 to match comment at start of function. This also removes a
5445 GCC warning about overflow in a 32+64-bit port.
5446
47be4ab5
PE
5447 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5448
371cac43
PE
5449 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5450 Reported by Stefan Monnier in
5451 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5452 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5453 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5454
d01a7826
PE
5455 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5456 (EMACS_UINTPTR): Likewise, with uintptr_t.
5457
7fd47d5c
PE
5458 * lisp.h: Prefer 64-bit EMACS_INT if available.
5459 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5460 on 32-bit hosts that have 64-bit int, so that they can access
5461 large files.
122b0c86
PE
5462 However, temporarily disable this change unless the temporary
5463 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5464
8727937b
PE
5465 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5466
8ac068ac
PE
5467 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5468 This removes an assumption that EMACS_INT and long are the same
5469 width as pointers. The assumption is true for Emacs porting targets
5470 now, but we want to make other targets possible.
5471 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5472 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5473 In the rest of the code, change types of integers that hold casted
5474 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5475 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5476 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5477 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5478 No need to cast type when ORing.
5479 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5480 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5481 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5482 assume EMACS_INT is the same width as char *.
5483 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5484 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5485 Remove no-longer-needed casts.
5486 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5487 (xg_tool_bar_help_callback, xg_make_tool_item):
5488 Use EMACS_INTPTR to hold an integer
5489 that will be cast to void *; this can avoid a GCC warning
5490 if EMACS_INT is not the same width as void *.
5491 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5492 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5493 (current_message_1, set_message_1):
5494 Use a local to convert to proper width without a cast.
5495 * xmenu.c (dialog_selection_callback): Likewise.
5496
ede49d71
PE
5497 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5498 Also, don't assume VALBITS / RAND_BITS is less than 5,
5499 and don't rely on undefined behavior when shifting a 1 left into
5500 the sign bit.
5501 * lisp.h (get_random): Change signature to match.
5502
2f30ecd0
PE
5503 * lread.c (hash_string): Use size_t, not int, for hash computation.
5504 Normally we prefer signed values; but hashing is special, because
5505 it's better to use unsigned division on hash table sizes so that
5506 the remainder is nonnegative. Also, size_t is the natural width
5507 for hashing into memory. The previous code used 'int', which doesn't
5508 retain enough info to hash well into very large tables.
5509 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5510
2a866e7b
PE
5511 * dbusbind.c: Don't possibly lose pointer info when converting.
5512 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5513 Use XPNTR rather than XHASH, so that the high-order bits of
5514 the pointer aren't lost when converting through void *.
5515
51639eac
PE
5516 * eval.c (Fautoload): Don't double-shift a pointer.
5517
92394119
PE
5518 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5519
dbdb9a7c
JB
55202011-05-06 Juanma Barranquero <lekktu@gmail.com>
5521
5522 * gnutls.c (DEF_GNUTLS_FN):
5523 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5524
db7a0b4f
AS
55252011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5526
5527 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5528 marker. (Bug#8610)
5529
f7ff1b0f 55302011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5531
5532 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5533 New version that can reserve upto 2GB of heap space.
5534
f7ff1b0f 55352011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5536
5537 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5538
639c109b
TZ
55392011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5540
5541 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5542 `gnutls_certificate_set_x509_key_file'.
5543
d2127135
JB
55442011-05-05 Juanma Barranquero <lekktu@gmail.com>
5545
5546 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5547 Update dependencies.
5548
e968f4f3
JB
55492011-05-04 Juanma Barranquero <lekktu@gmail.com>
5550
5551 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5552 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5553 Remove unused parameter `fildes'.
5554 * process.c (read_process_output, send_process): Don't pass it.
5555
84d358f0
JB
55562011-05-04 Juanma Barranquero <lekktu@gmail.com>
5557
5558 Fix previous change: the library cache is defined in w32.c.
5559 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5560 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5561
0898ca10
JB
55622011-05-04 Juanma Barranquero <lekktu@gmail.com>
5563
5564 Implement dynamic loading of GnuTLS on Windows.
5565
5566 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5567 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5568 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5569 Declare.
5570
5571 * gnutls.c (Qgnutls_dll): Define.
5572 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5573 (gnutls_*): Declare function pointers.
5574 (init_gnutls_functions): New function to initialize function pointers.
5575 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5576 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5577 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5578 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5579 (emacs_gnutls_write, emacs_gnutls_read)
5580 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5581 (Fgnutls_available_p): New function.
5582 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5583 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5584 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5585
5586 * image.c: Include w32.h.
5587 (Vimage_type_cache): Delete.
5588 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5589 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5590 (w32_delayed_load): Move to w32.c.
5591
5592 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5593
5594 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5595 (w32_delayed_load): Move from image.c. When loading a library, record
5596 its filename in the :loaded-from property of the library id.
5597 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5598 Initialize and staticpro them.
5599 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5600
5601 * process.c: Include lisp.h before w32.h, not after.
5602 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5603 instead of gnutls_record_check_pending.
5604
5605 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5606
ff4de4aa
TZ
56072011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5608
5609 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5610 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5611 as passed in.
5612
abe95abb
JD
56132011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5614
5615 * xterm.c (x_set_frame_alpha): Do not set property on anything
5616 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5617
e16e55d4
JB
56182011-05-02 Juanma Barranquero <lekktu@gmail.com>
5619
5620 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5621
bafcf6a5
JB
56222011-05-02 Juanma Barranquero <lekktu@gmail.com>
5623
5624 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5625 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5626 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5627 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5628 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5629 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5630 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5631 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5632 (Qgnutls_bootprop_callbacks_verify): Make static.
5633
e7a6747f
AS
56342011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5635
19ed11ba
AS
5636 * callproc.c: Indentation fixup.
5637
e7a6747f 5638 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5639 (wait_for_termination, interruptible_wait_for_termination):
5640 Move after wait_for_termination_1.
e7a6747f 5641
1ef14cb4
LMI
56422011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5643
5644 * sysdep.c (interruptible_wait_for_termination): New function
5645 which is like wait_for_termination, but allows keyboard
5646 interruptions.
5647
5648 * callproc.c (Fcall_process): Add (:file "file") as an option for
5649 the STDOUT buffer.
5650 (Fcall_process_region): Ditto.
5651
330d880c
EZ
56522011-04-30 Eli Zaretskii <eliz@gnu.org>
5653
8db90b73
EZ
5654 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5655 rather than `XVECTOR (FOO)->size'.
5656
330d880c
EZ
5657 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5658 inttypes.h, as a gnulib replacement is used if it not available in
5659 system headers.
5660
15cbd324
EZ
56612011-04-21 Eli Zaretskii <eliz@gnu.org>
5662
5663 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5664 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5665 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5666
5667 * coding.c (coding_alloc_by_realloc): Error out if destination
5668 will grow beyond MOST_POSITIVE_FIXNUM.
5669 (decode_coding_emacs_mule): Abort if there isn't enough place in
5670 charbuf for the composition carryover bytes. Reserve an extra
5671 space for up to 2 characters produced in a loop.
5672 (decode_coding_iso_2022): Abort if there isn't enough place in
5673 charbuf for the composition carryover bytes.
5674
56752011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5676
ae940cca
EZ
5677 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5678 aborting when %lld or %lll format is passed.
5679 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5680 %llo or %llx format is passed. (Bug#8545)
5681
03ab8921
EZ
5682 * window.c (window_scroll_line_based): Use a marker instead of
5683 simple variables to record original value of point. (Bug#7952)
5684
afda1437
EZ
5685 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5686 produced by %s or %c overflows available buffer space. (Bug#8545)
5687
f76dee0c
PE
56882011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5689
5690 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5691 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5692
fdc5744d
JB
56932011-04-28 Juanma Barranquero <lekktu@gmail.com>
5694
5695 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5696
638f053a
JB
56972011-04-28 Juanma Barranquero <lekktu@gmail.com>
5698
5699 * keyboard.c (Qdelayed_warnings_hook): Define.
5700 (command_loop_1): Run `delayed-warnings-hook'
5701 if Vdelayed_warnings_list is non-nil.
5702 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5703 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5704
d178f871
EZ
57052011-04-28 Eli Zaretskii <eliz@gnu.org>
5706
5707 * doprnt.c (doprnt): Don't return value smaller than the buffer
5708 size if the message was truncated. (Bug#8545).
5709
b124fd93
JB
57102011-04-28 Juanma Barranquero <lekktu@gmail.com>
5711
5712 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5713 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5714
e810457d
PE
57152011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5716
5717 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5718
ea51cceb
JB
57192011-04-27 Juanma Barranquero <lekktu@gmail.com>
5720
5721 * makefile.w32-in: Update dependencies.
5722
94dcfacf
EZ
57232011-04-27 Eli Zaretskii <eliz@gnu.org>
5724
5725 Improve `doprnt' and its usage. (Bug#8545)
5726 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5727 `format_end'. Remove support for %l as a conversion specifier.
5728 Don't use xrealloc. Improve diagnostics when the %l size modifier
5729 is used. Update the commentary.
5730
5731 * eval.c (verror): Simplify calculation of size_t.
5732
5733 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5734 messages.
5735
f61f41d7
PE
57362011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5737
5738 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5739 change.
5740
96fb4434
PE
57412011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5742
5743 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5744 This makes this file independent of the recent pseudovector change.
5745
671875da 57462011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5747
69e9b5a3
PE
5748 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5749
b5f869a7 5750 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5751 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5752 Remove unused local.
c8926152 5753 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5754
841a1577 5755 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5756 GCC 4.6.0 optimizes based on type-based alias analysis.
5757 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5758 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5759 != &v->size, and therefore "v->size = 1; b->size = 2; return
5760 v->size;" must therefore return 1. This assumption is incorrect
5761 for Emacs, since it type-puns struct Lisp_Vector * with many other
5762 types. To fix this problem, this patch adds a new type struct
f904488f 5763 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5764 and pseudovectors, and helps optimizing compilers not get fooled
5765 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5766 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5767 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5768 the size member.
eab3844f
PE
5769 (XSETPVECTYPE): Rewrite in terms of new macro.
5770 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5771 This is a bit clearer, and further avoids the possibility of
5772 undesirable aliasing.
5773 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5774 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5775 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5776 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5777 (ASIZE): Now uses header.size rather than size.
5778 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5779 to avoid the hassle of writing XVECTOR (foo)->header.size.
5780 (struct vectorlike_header): New type.
eab3844f
PE
5781 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5782 object, to help avoid aliasing.
5783 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5784 (SUBRP): Likewise, since Lisp_Subr is a special case.
5785 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5786 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5787 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5788 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5789 changed to be "header.size" and "header.next".
5790 * buffer.h (struct buffer): Likewise.
5791 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5792 * frame.h (struct frame): Likewise.
5793 * process.h (struct Lisp_Process): Likewise.
5794 * termhooks.h (struct terminal): Likewise.
5795 * window.c (struct save_window_data, struct saved_window): Likewise.
5796 * window.h (struct window): Likewise.
5797 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5798 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5799 * buffer.c (init_buffer_once): Likewise.
5800 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5801 special case.
5802 * process.c (Fformat_network_address): Use local var for size,
5803 for brevity.
5804
0df1eac5
PE
5805 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5806
847ab9d1 5807 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5808 * data.c (atof): Remove decl; no longer used or needed.
5809 (digit_to_number): Move to lread.c.
5810 (Fstring_to_number): Use new string_to_number function, to be
5811 consistent with how the Lisp reader treats infinities and NaNs.
5812 Do not assume that floating-point numbers represent EMACS_INT
5813 without losing information; this is not true on most 64-bit hosts.
5814 Avoid double-rounding errors, by insisting on integers when
5815 parsing non-base-10 numbers, as the documentation specifies.
5816 * lisp.h (string_to_number): New decl, replacing ...
5817 (isfloat_string): Remove.
bc0a5c13 5818 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5819 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5820 appears to have been a coding error. Similarly, do not accept
5821 strings like +-1e0 as floating point numbers. Do not report
5822 overflow for integer overflows unless the base is not 10 which
5823 means we have no simple and reliable way to continue.
5824 Break out the floating-point parsing into a new
5825 function string_to_number, so that Fstring_to_number parses
5826 floating point numbers consistently with the Lisp reader.
04f2d78b 5827 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5828 (E_CHAR, EXP_INT): Remove, replacing with ...
5829 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5830 (string_to_number): New function, replacing isfloat_string.
5831 This function checks for valid syntax and produces the resulting
5832 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5833 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5834 so that overflow for non-base-10 numbers is reported only when
5835 there's no portable and simple way to convert to floating point.
452f4150 5836
67769ffc
PE
5837 * textprop.c (set_text_properties_1): Rewrite for clarity,
5838 and to avoid GCC warning about integer overflow.
5839
c20db43f
PE
5840 * intervals.h (struct interval): Use EMACS_INT for members
5841 where EMACS_UINT might cause problems. See
5842 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5843 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5844 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5845 All uses changed.
37aa2f85
PE
5846 (offset_intervals): Tell GCC not to worry about length overflow
5847 when negating a negative length.
c20db43f 5848
2538aa2f
PE
5849 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5850 (overrun_check_free): Likewise.
5851
f2d3008d
PE
5852 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5853 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5854 word size.
5855
ec8df744
PE
5856 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5857 (gnutls_make_error): Rename local to avoid shadowing.
5858 (gnutls_emacs_global_deinit): ifdef out; not used.
5859 (Fgnutls_boot): Use const for pointer to readonly storage.
5860 Comment out unused local. Fix pointer signedness problems.
5861
640ee02d
PE
5862 * lread.c (openp): Don't stuff size_t into an 'int'.
5863 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5864 about possible signed overflow.
5865
6048fb2a
PE
5866 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5867 (GDK_KEY_g): Don't define if already defined.
5868 (xg_prepare_tooltip): Avoid pointer signedness problem.
5869 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5870
fa3c87e1
PE
5871 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5872 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5873
2172544b
PE
5874 * xfns.c (Fx_window_property): Simplify a bit,
5875 to make a bit faster and to avoid GCC 4.6.0 warning.
5876 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5877
9b821a21
PE
5878 * fns.c (internal_equal): Don't assume size_t fits in int.
5879
3c616cfa
PE
5880 * alloc.c (compact_small_strings): Tighten assertion a little.
5881
c2982e87
PE
5882 Replace pEd with more-general pI, and fix some printf arg casts.
5883 * lisp.h (pI): New macro, generalizing old pEd macro to other
5884 conversion specifiers. For example, use "...%"pI"d..." rather
5885 than "...%"pEd"...".
5886 (pEd): Remove. All uses replaced with similar uses of pI.
5887 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5888 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5889 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5890 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5891 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5892 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5893 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5894 64-bit hosts.
5895 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5896 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5897 * print.c (safe_debug_print, print_object): Likewise.
5898 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5899 to int.
6f04d126
PE
5900 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5901 avoiding the 0 flag, which is not portable.
c2982e87
PE
5902 * process.c (Fmake_network_process): Use pI to avoid cast.
5903 * region-cache.c (pp_cache): Likewise.
5904 * xdisp.c (decode_mode_spec): Likewise.
5905 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5906 behavior on 64-bit hosts with printf arg.
6f04d126 5907 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5908 (x_stop_queuing_selection_requests): Likewise.
5909 (x_get_window_property): Don't truncate byte count to an 'int'
5910 when tracing.
0b432f21 5911
5e073ec7
PE
5912 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5913 here, since it parses constructs like leading '-' and spaces,
5914 which are not wanted; and it overflows with large numbers.
5915 Instead, simply match F[0-9]+, which is what is wanted anyway.
5916
36372bf9
PE
5917 * alloc.c: Remove unportable assumptions about struct layout.
5918 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5919 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5920 (allocate_vectorlike, make_pure_vector): Use the new macros,
5921 plus offsetof, to remove unportable assumptions about struct layout.
5922 These assumptions hold on all porting targets that I know of, but
5923 they are not guaranteed, they're easy to remove, and removing them
5924 makes further changes easier.
5925
0b432f21
PE
5926 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5927 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5928 (string_overrun_cookie): Now const. Use initializers that
5929 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5930 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5931 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5932 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5933 multiple of sizeof (EMACS_INT); it need not be, if
5934 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5935 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5936
895009e1
JB
59372011-04-26 Juanma Barranquero <lekktu@gmail.com>
5938
5939 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5940
6a7a1b0b
TZ
59412011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5942
5943 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5944 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5945 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5946
841a1577 59472011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5948
5949 * lisp.h (Qdebug): List symbol.
895009e1 5950 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5951 * keyboard.c (debug-on-event): New variable.
5952 (handle_user_signal): Break into debugger when debug-on-event
5953 matches the current signal symbol.
5954
f2d3ba6f
DN
59552011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5956
5957 * alloc.c (check_sblock, check_string_bytes)
5958 (check_string_free_list): Convert to standard C.
5959
42ce4c63
TZ
59602011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5961
5962 * w32.c (emacs_gnutls_push): Fix typo.
5963
825cd63c
EZ
59642011-04-25 Eli Zaretskii <eliz@gnu.org>
5965
fb11d64d
EZ
5966 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5967 "cast to pointer from integer of different size".
5968
825cd63c
EZ
5969 Improve doprnt and its use in verror. (Bug#8545)
5970 * doprnt.c (doprnt): Document the set of format control sequences
5971 supported by the function. Use SAFE_ALLOCA instead of always
5972 using `alloca'.
5973
5974 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5975 is one byte too soon. Don't use xrealloc; instead xfree and
5976 xmalloc anew.
5977
e061a11b
TZ
59782011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5979
5980 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5981 callbacks stage.
5982
5983 * gnutls.c: Renamed global_initialized to
5984 gnutls_global_initialized. Added internals for the
5985 :verify-hostname-error, :verify-error, and :verify-flags
5986 parameters of `gnutls-boot' and documented those parameters in the
5987 docstring. Start callback support.
9173deec
JB
5988 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5989 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5990 on error. Return error code.
e061a11b
TZ
5991 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5992 (emacs_gnutls_read): Likewise.
5993 (Fgnutls_boot): Return handshake error code.
5994 (emacs_gnutls_handle_error): New function.
5995 (wsaerror_to_errno): Likewise.
5996
5997 * w32.h (emacs_gnutls_pull): Add prototype.
5998 (emacs_gnutls_push): Likewise.
5999
6000 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6001 (emacs_gnutls_push): Likewise.
6002
60032011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6004
6005 * process.c (wait_reading_process_output): Check if GnuTLS
6006 buffered some data internally if no FDs are set for TLS
6007 connections.
6008
6009 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6010 (LIBS): Link to USER_LIBS.
6011 ($(BLD)/gnutls.$(0)): New target.
6012
fa6996bc
EZ
60132011-04-24 Eli Zaretskii <eliz@gnu.org>
6014
eb35682e
EZ
6015 * xdisp.c (handle_single_display_spec): Rename the
6016 display_replaced_before_p argument into display_replaced_p, to
6017 make it consistent with the commentary. Fix typos in the
6018 commentary.
6019
e2ad650c
EZ
6020 * textprop.c (syms_of_textprop): Remove dead code.
6021 (copy_text_properties): Delete obsolete commentary about an
6022 interface that was deleted long ago. Fix typos in the description
6023 of arguments.
6024
1b2de274
EZ
6025 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6026 to changes in oldXMenu/XMenu.h from 2011-04-16.
6027 <menu_help_message, prev_menu_help_message>: Constify.
6028 (IT_menu_make_room): menu->help_text is now `const char **';
6029 adjust.
6030
6031 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6032 to changes in oldXMenu/XMenu.h from 2011-04-16.
6033 (struct XMenu): Declare `help_text' `const char **'.
6034
6035 * xfaces.c <Qunspecified>: Make extern again.
6036
6037 * syntax.c: Include sys/types.h before including regex.h, as
6038 required by Posix.
6039
762b15be
EZ
6040 * doc.c (get_doc_string): Improve the format passed to `error'.
6041
6042 * doprnt.c (doprnt): Improve commentary.
6043
6044 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6045
6046 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6047 them with etags.
6048
f1052e5d
EZ
6049 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6050 changes in globals.h immediately force recompilation.
762b15be
EZ
6051 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6052 $(CURDIR)/s/ms-w32.h.
6053 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6054
fa6996bc
EZ
6055 * character.c (Fchar_direction): Function deleted.
6056 (syms_of_character): Don't defsubr it.
6057 <char-direction-table>: Deleted.
6058
e6c3da20
EZ
60592011-04-23 Eli Zaretskii <eliz@gnu.org>
6060
6061 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6062 * doprnt.c: Include limits.h.
6063 (SIZE_MAX): New macro.
04f2d78b
CB
6064 (doprnt): Return a size_t value. 2nd arg is now size_t.
6065 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6066 Improve overflow protection. Support `l' modifier for integer
6067 conversions. Support %l conversion. Don't assume an EMACS_INT
6068 argument for integer conversions and for %c.
6069
6070 * lisp.h (doprnt): Restore prototype.
6071
6072 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6073 $(SRC)/character.h.
6074
6075 * Makefile.in (base_obj): Add back doprnt.o.
6076
6077 * deps.mk (doprnt.o): Add back prerequisites.
6078 (callint.o): Depend on character.h.
6079
6080 * eval.c (internal_lisp_condition_case): Include the handler
6081 representation in the error message.
6082 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6083 when breaking from the loop.
6084
6085 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6086
6087 * callint.c (Fcall_interactively): When displaying error message
6088 about invalid control letter, pass the character's codepoint, not
6089 a pointer to its multibyte form. Improve display of the character
6090 in octal and display also its hex code.
6091
6092 * character.c (char_string): Use %x to display the (unsigned)
6093 codepoint of an invalid character, to avoid displaying a bogus
6094 negative value.
6095
6096 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6097 `error', not SYMBOL_NAME itself.
6098
6099 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6100 character arguments to `error'.
6101
6102 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6103 to `error' in error message about FINAL_CHAR argument. Make sure
6104 FINAL_CHAR is a character, and use %c when it is passed as
6105 argument to `error'.
6106
4ffd0d6b 61072011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6108
6109 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6110
6111 * w32.c: Include <time.h>.
6112 (sys_localtime): New function.
6113
4ffd0d6b 61142011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6115
6116 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6117
4ffd0d6b 6118 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6119
4ffd0d6b 61202011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6121
4ffd0d6b
GM
6122 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6123 zombies (Bug#8467).
aac0c6e3 6124
04c56954
EZ
61252011-04-19 Eli Zaretskii <eliz@gnu.org>
6126
6127 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6128 gl_state.e_property when gl_state.object is Qt.
6129
6130 * insdel.c (make_gap_larger): Remove limitation of buffer size
6131 to <= INT_MAX.
6132
16a43933
CY
61332011-04-18 Chong Yidong <cyd@stupidchicken.com>
6134
6135 * xdisp.c (lookup_glyphless_char_display)
6136 (produce_glyphless_glyph): Handle cons cell entry in
6137 glyphless-char-display.
6138 (Vglyphless_char_display): Document it.
6139
6140 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6141 glyphless-char-display.
6142
4581706e
CY
61432011-04-17 Chong Yidong <cyd@stupidchicken.com>
6144
6145 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6146
6147 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6148
6149 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6150 definition for no-X builds.
6151
4887c6e2 61522011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6153
fd35b6f9
PE
6154 Static checks with GCC 4.6.0 and non-default toolkits.
6155
5c1ccb01
PE
6156 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6157
006c5daa
PE
6158 * process.c (keyboard_bit_set): Define only if SIGIO.
6159 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6160 (send_process): Repair possible setjmp clobbering.
6161
efc736d3
PE
6162 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6163
4e2fe2e6
PE
6164 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6165
f97334a2
PE
6166 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6167
4e75f29d
PE
6168 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6169 Define only if needed.
6170
90efadd1
PE
6171 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6172 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6173 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6174
3c647824
PE
6175 * dispextern.h (struct redisplay_interface): Rename param
6176 to avoid shadowing.
e264f262 6177 * termhooks.h (struct terminal): Likewise.
761383f4 6178 * xterm.c (xembed_send_message): Likewise.
3c647824 6179
b58c5c4a
PE
6180 * insdel.c (make_gap_smaller): Define only if
6181 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6182
cad59032
PE
6183 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6184 it.
6185
c339dc2e
PE
6186 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6187 so that we aren't warned about unused symbols.
6188
91a3e27b
PE
6189 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6190
399c71d3 6191 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6192
8ffc96f5
PE
6193 * xfns.c (x_real_positions): Mark locals as initialized.
6194
eef9bc79
PE
6195 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6196
098db9dd
PE
6197 * xterm.c: Fix problems found by static analysis with other toolkits.
6198 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6199 (x_dispatch_event): Declare static if USE_GTK, and
6200 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6201 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6202 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6203 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6204 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6205
eb18f6cc
PE
6206 * xmenu.c (menu_help_callback): Pointer type fixes.
6207 Use const pointers when pointing at readonly data. Avoid pointer
6208 signedness clashes.
6209 (FALSE): Remove unused macro.
6210 (update_frame_menubar): Remove unused decl.
6211
1fe72bf8
PE
6212 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6213
60d9e1db
PE
6214 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6215 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6216 (single_menu_item): Rename local to avoid shadowing.
6217
39261c26
PE
6218 * keyboard.c (make_lispy_event): Remove unused local var.
6219
018c5e19
PE
6220 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6221 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6222
63d2b86e
PE
6223 * bitmaps: Change bitmaps from unsigned char back to the X11
6224 compatible char. Avoid the old compiler warnings about
6225 out-of-range initializers by using, for example, '\xab' rather
6226 than 0xab.
6227
aefd87e1
PE
6228 * xgselect.c (xgselect_initialize): Check vs interface
6229 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6230
bf501fb9
PE
6231 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6232
e9829fdf
PE
6233 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6234 to read-only memory.
6235
1086c095
PE
6236 * fns.c (vector): Remove; this old hack is no longer needed.
6237
2baccd04 6238 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6239 Remove unused var.
dde42981 6240 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6241
72391843 6242 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6243
436c16df 6244 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6245 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6246 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6247
92bb796d 6248 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6249 (x_term_init): Remove local to avoid shadowing.
92bb796d 6250
764430a3 6251 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6252
6253 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6254 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6255
d1dfb56c
EZ
62562011-04-16 Eli Zaretskii <eliz@gnu.org>
6257
c4354cb4
EZ
6258 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6259
d1dfb56c
EZ
6260 Fix regex.c, syntax.c and friends for buffers > 2GB.
6261 * syntax.h (struct gl_state_s): Declare character position members
6262 EMACS_INT.
6263
6264 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6265
04f2d78b
CB
6266 * textprop.c (verify_interval_modification, interval_of):
6267 Declare arguments EMACS_INT.
d1dfb56c
EZ
6268
6269 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6270 EMACS_INT.
6271
6272 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6273
6274 * indent.c (Fvertical_motion): Local variable it_start is now
6275 EMACS_INT.
6276
6277 * regex.c (re_match, re_match_2, re_match_2_internal)
6278 (bcmp_translate, regcomp, regexec, print_double_string)
6279 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6280 (re_compile_pattern, re_exec): Declare arguments and local
6281 variables `size_t' and `ssize_t' and return values `regoff_t', as
6282 appropriate.
6283 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6284 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6285 <compile_stack_type>: `size' and `avail' are now `size_t'.
6286
6287 * regex.h <regoff_t>: Use ssize_t, not int.
6288 (re_search, re_search_2, re_match, re_match_2): Arguments that
6289 specify buffer/string position and length are now ssize_t and
6290 size_t. Return type is regoff_t.
6291
613052cd
BK
62922011-04-16 Ben Key <bkey76@gmail.com>
6293
6294 * nsfont.m: Fixed bugs in ns_get_family and
6295 ns_descriptor_to_entity that were caused by using free to
6296 deallocate memory blocks that were allocated by xmalloc (via
6297 xstrdup). This caused Emacs to crash when compiled with
6298 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6299 --enable-checking=xmallocoverrun). xfree is now used to
6300 deallocate these memory blocks.
6301
4170f62f 63022011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6303
71b41406
PE
6304 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6305
9587a89d
PE
6306 emacs_write: Accept and return EMACS_INT for sizes.
6307 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6308 et seq.
6309 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6310 Accept and return EMACS_INT.
6311 (emacs_gnutls_write): Return the number of bytes written on
6312 partial writes.
6313 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6314 (emacs_read, emacs_write): Remove check for negative size, as the
6315 Emacs source code has been audited now.
9587a89d
PE
6316 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6317 (emacs_read, emacs_write): Use it.
273a5f82
PE
6318 * process.c (send_process): Adjust to the new signatures of
6319 emacs_write and emacs_gnutls_write. Do not attempt to store
6320 a byte offset into an 'int'; it might overflow.
9587a89d 6321 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6322
3e047f51
PE
6323 * sound.c: Don't assume sizes fit in 'int'.
6324 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6325 Return EMACS_INT, not int.
3e047f51 6326 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6327 Accept EMACS_INT, not int.
6328 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6329 record read return values.
6330
cc39a9db
BK
63312011-04-15 Ben Key <bkey76@gmail.com>
6332
c9d0ec6d
JB
6333 * keyboard.c (Qundefined): Don't declare static since it is used
6334 in nsfns.m.
6335 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6336 static since they are used in nsfont.m.
cc39a9db 6337
6c60eb9f
SM
63382011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6339
6340 * process.c (Qprocessp): Don't declare static.
6341 * lisp.h (Qprocessp): Declare again.
6342
7990b61a
JB
63432011-04-15 Juanma Barranquero <lekktu@gmail.com>
6344
6345 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6346
5d4cb038
PE
63472011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6348
8bd7b830 6349 Improve C-level modularity by making more things 'static'.
cd64ea1d 6350
e3b27b31
PE
6351 Don't publish debugger-only interfaces to other modules.
6352 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6353 (verify_bytepos, count_markers): Move decls to the only modules
6354 that need them.
6355 * region-cache.h (pp_cache): Likewise.
6356 * window.h (check_all_windows): Likewise.
6357 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6358
5d4cb038
PE
6359 * sysdep.c (croak): Now static, if
6360 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6361 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6362
6363 * alloc.c (refill_memory_reserve): Now static if
6364 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6365 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6366
e87b6180
PE
6367 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6368 Define only if USE_LUCID.
6369
ac64929e
PE
6370 * xrdb.c (x_customization_string, x_rm_string): Now static.
6371
6f37259d
PE
6372 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6373 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6374
1683e3ab
PE
6375 * xdisp.c (draw_row_with_mouse_face): Now static.
6376 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6377
de9c2632
PE
6378 * window.h (check_all_windows): Mark externally visible.
6379
2b96acb7
PE
6380 * window.c (window_deletion_count): Now static.
6381
6382 * undo.c: Make symbols static if they're not exported.
6383 (last_undo_buffer, last_boundary_position, pending_boundary):
6384 Now static.
6385
50436f33
PE
6386 * textprop.c (interval_insert_behind_hooks): Now static.
6387 (interval_insert_in_front_hooks): Likewise.
6388
64520e5c
PE
6389 * term.c: Make symbols static if they're not exported.
6390 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6391 (max_frame_lines, tty_set_terminal_modes):
6392 (tty_reset_terminal_modes, tty_turn_off_highlight):
6393 (get_tty_terminal): Now static.
6394 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6395 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6396 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6397 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6398 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6399
1fa53021
PE
6400 * sysdep.c: Make symbols static if they're not exported.
6401 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6402 Now static.
6403 (sigprocmask_set, full_mask): Remove; unused.
6404 (wait_debugging): Mark as visible.
6405 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6406 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6407
d4b43b22
PE
6408 * syntax.c (syntax_temp): Define only if !__GNUC__.
6409
b7c513d0
PE
6410 * sound.c (current_sound_device, current_sound): Now static.
6411
989b29ad
PE
6412 * search.c (searchbufs, searchbuf_head): Now static.
6413
13a55a78
PE
6414 * scroll.c (scroll_cost): Remove; unused.
6415 * dispextern.h (scroll_cost): Remove decl.
6416
de68a1fc
PE
6417 * region-cache.h (pp_cache): Mark as externally visible.
6418
40ccffa6
PE
6419 * process.c: Make symbols static if they're not exported.
6420 (process_tick, update_tick, create_process, chan_process):
6421 (Vprocess_alist, proc_buffered_char, datagram_access):
6422 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6423 (deactivate_process): Mark defn as static, as well as decl.
6424 * lisp.h (create_process): Remove decl.
6425 * process.h (chan_process, Vprocess_alist): Remove decls.
6426
ad64fc97
PE
6427 * print.c: Make symbols static if they're not exported.
6428 (print_depth, new_backquote_output, being_printed, print_buffer):
6429 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6430 (print_interval, print_number_index, initial_stderr_stream):
6431 Now static.
6432 * lisp.h (Fprinc): Remove decl.
6433 (debug_output_compilation_hack): Mark as externally visible.
6434
adddb265
PE
6435 * sysdep.c (croak): Move decl from here to syssignal.h.
6436 * syssignal.h (croak): Put it here, so the API can be checked when
6437 'croak' is called from dissociate_if_controlling_tty.
6438
1717ede2
PE
6439 * minibuf.c: Make symbols static if they're not exported.
6440 (minibuf_save_list, choose_minibuf_frame): Now static.
6441 * lisp.h (choose_minibuf_frame): Remove decl.
6442
fa5fb2bc
PE
6443 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6444
1e3890d1
PE
6445 * lread.c: Make symbols static if they're not exported.
6446 (read_objects, initial_obarray, oblookup_last_bucket_number):
6447 Now static.
6448 (make_symbol): Remove; unused.
6449 * lisp.h (initial_obarray, make_symbol): Remove decls.
6450
8a1414fa
PE
6451 * keyboard.c: Make symbols static if they're not exported.
6452 (single_kboard, recent_keys_index, total_keys, recent_keys):
6453 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6454 (this_single_command_key_start, echoing, last_auto_save):
6455 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6456 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6457 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6458 (Vlispy_mouse_stem, double_click_count):
6459 Now static.
6460 (force_auto_save_soon): Define only if SIGDANGER.
6461 (ignore_mouse_drag_p): Now static if
6462 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6463 (print_help): Remove; unused.
6464 (stop_character, last_timer_event): Mark as externally visible.
6465 * keyboard.h (ignore_mouse_drag_p): Declare only if
6466 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6467 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6468 * lisp.h (echoing): Remove decl.
6469 (force_auto_save_soon): Declare only if SIGDANGER.
6470 * xdisp.c (redisplay_window): Simplify code, to make it more
6471 obvious that ignore_mouse_drag_p is not accessed if !defined
6472 USE_GTK && !defined HAVE_NS.
6473
93ea6e8f
PE
6474 * intervals.c: Make symbols static if they're not exported.
6475 (merge_properties_sticky, merge_interval_right, delete_interval):
6476 Now static.
6477 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6478
77382fcc
PE
6479 * insdel.c: Make symbols static if they're not exported.
6480 However, leave prepare_to_modify_buffer alone. It's never
6481 called from outside this function, but that appears to be a bug.
6482 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6483 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6484 (adjust_after_replace_noundo): Remove; unused.
6485 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6486 (signal_before_change): Remove decls.
77382fcc 6487
9306c32e
PE
6488 * indent.c (val_compute_motion, val_vmotion): Now static.
6489
cd44d2eb
PE
6490 * image.c: Make symbols static if they're not exported.
6491 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6492 if USE_GTK.
6493 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6494 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6495
ad9a7a06
PE
6496 * fringe.c (standard_bitmaps): Now static.
6497 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6498
81626931
PE
6499 * frame.c: Make symbols static if they're not exported.
6500 (x_report_frame_params, make_terminal_frame): Now static.
6501 (get_frame_param): Now static, unless HAVE_NS.
6502 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6503 (x_get_resource_string): Remove; not used.
6504 * frame.h (make_terminal_frame, x_report_frame_params):
6505 (x_get_resource_string); Remove decls.
6506 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6507 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6508
239f9db9
PE
6509 * font.c, fontset.c: Make symbols static if they're not exported.
6510 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6511 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6512 * font.c (font_close_object): Now static.
6513 * font.h (font_close_object): Remove.
6514 * fontset.c (FONTSET_OBJLIST): Remove.
6515 (free_realized_fontset) #if-0 the body, which does nothing.
6516 (face_suitable_for_char_p): #if-0, as it's never called.
6517 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6518 * xfaces.c (face_at_string_position):
6519 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6520 since 0 is always ASCII.
6521
dfcf3579
PE
6522 * fns.c (weak_hash_tables): Now static.
6523
5045092b
PE
6524 * fileio.c: Make symbols static if they're not exported.
6525 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6526 (Vwrite_region_annotation_buffers): Now static.
6527
57a96f5c
PE
6528 * eval.c: Make symbols static if they're not exported.
6529 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6530 * lisp.h (backtrace_list): Remove decl.
6531
35f08c38
PE
6532 * emacs.c: Make symbols static if they're not exported.
6533 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6534 (fatal_error_code, fatal_error_signal_hook, standard_args):
6535 Now static.
6536 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6537 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6538 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6539 * lisp.h (fatal_error_signal_hook): Remove decl.
6540 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6541
f44bd759
PE
6542 * editfns.c: Move a (normally-unused) function to its only use.
6543 * editfns.c, lisp.h (get_operating_system_release): Remove.
6544 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6545 worth the hassle of breaking this out.
6546
b532497d
PE
6547 * xterm.c: Make symbols static if they're not exported.
6548 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6549 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6550 (x_destroy_window, x_delete_display):
6551 Now static.
6552 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6553 (x_mouse_leave): Remove; unused.
6554 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6555 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6556 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6557 Remove decls.
6558 (x_mouse_leave): Declare only if WINDOWSNT.
6559 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6560 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6561 USE_X_TOOLKIT.
6562
1675728f
PE
6563 * ftxfont.c: Make symbols static if they're not exported.
6564 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6565 HAVE_FREETYPE.
6566 * font.h (ftxfont_driver): Likewise.
6567
e4cebfca
PE
6568 * xfns.c: Make symbols static if they're not exported.
6569 (x_last_font_name, x_display_info_for_name):
6570 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6571 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6572 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6573 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6574 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6575 (last_show_tip_args): Now static.
6576 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6577 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6578 (x_screen_planes): Remove; unused.
6579 * dispextern.h (x_screen_planes): Remove decl.
6580
5bf46f05
PE
6581 * dispnew.c: Make symbols static if they're not exported.
6582 * dispextern.h (redraw_garbaged_frames, scrolling):
6583 (increment_row_positions): Remove.
6584 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6585 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6586 Now static.
6587 (redraw_garbaged_frames): Remove; unused.
6588
435f4c28
PE
6589 * xfaces.c: Make symbols static if they're not exported.
6590 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6591 Remove decls.
6592 * xterm.h (defined_color): Remove decls.
6593 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6594 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6595 (menu_face_changed_default, defined_color, free_realized_face):
6596 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6597 (ascii_face_of_lisp_face): Remove; unused.
6598
8524aef3
PE
6599 * xdisp.c: Make symbols static if they're not exported.
6600 * dispextern.h (scratch_glyph_row, window_box_edges):
6601 (glyph_to_pixel_coords, set_cursor_from_row):
6602 (get_next_display_element, set_iterator_to_next):
6603 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6604 (show_mouse_face): Remove decls
6605 * frame.h (message_buf_print): Likewise.
6606 * lisp.h (pop_message, set_message, check_point_in_composition):
6607 Likewise.
6608 * xterm.h (set_vertical_scroll_bar): Likewise.
6609 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6610 (message_buf_print, scratch_glyph_row, displayed_buffer):
6611 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6612 (get_next_display_element, show_mouse_face, window_box_edges):
6613 (frame_to_window_pixel_xy, check_point_in_composition):
6614 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6615 (glyph_to_pixel_coords): Remove; unused.
6616
16390cd2
PE
6617 * dired.c (file_name_completion): Now static.
6618
6619 * dbusbind.c (xd_in_read_queued_messages): Now static.
6620
a25f4dfa
PE
6621 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6622 * data.c (circular_list_error): Remove.
6623
14a9c8df
PE
6624 * commands.h (last_point_position, last_point_position_buffer):
6625 (last_point_position_window): Remove decls.
6626 * keyboard.c: Make these variables static.
6627
04f2d78b
CB
6628 * coding.h (coding, code_convert_region, encode_coding_gap):
6629 Remove decls.
74ab6df5
PE
6630 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6631 (iso_code_class, detect_coding, code_convert_region): Now static.
6632 (encode_coding_gap): Remove; unused.
6633
38dfbee1
PE
6634 * chartab.c (chartab_chars, chartab_bits): Now static.
6635
a2cb4e63
PE
6636 * charset.h (charset_iso_8859_1): Remove decl.
6637 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6638 Now static.
6639
127198fd
PE
6640 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6641 * ccl.c (Vccl_program_table): Now static.
6642 (check_ccl_update): Remove; unused.
6643
d85b608f
PE
6644 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6645 * category.h: ... from here.
6646 * category.c (check_category_table, set_category_set): Now static.
6647
31cd66f3
PE
6648 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6649 * lisp.h: Remove these decls.
6650
c358e587
PE
6651 * buffer.c (buffer_count): Remove unused var.
6652
e78aecca
PE
6653 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6654 so that it's not optimized away.
6655 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6656 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6657 exported only to the debugger.
6658
e192d7d3 6659 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6660 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6661
92470028
PE
6662 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6663 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6664 was inaccessible from Lisp.
6665 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6666 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6667
244ed907
PE
6668 alloc.c: Import and export fewer symbols, and remove unused items.
6669 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6670 is defined.
6671 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6672 it's not optimized away by whole-program optimization.
6673 (message_enable_multibyte, free_misc): Remove.
6674 (catchlist, handlerlist, mark_backtrace):
6675 Declare only if BYTE_MARK_STACK.
6676 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6677 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6678 (message_enable_multibyte): Remove decl.
6679 (free_misc, interval_free_list, float_block, float_block_index):
6680 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6681 (cons_free_list, last_marked_index):
6682 Now static.
6683 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6684 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6685 (mark_backtrace): Define only if BYTE_MARK_STACK.
6686 * xdisp.c (message_enable_multibyte): Now static.
6687
61c2b50e 6688 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6689 This makes it easier for human readers (and static analyzers)
6690 to see whether these variables are used from other modules.
6691 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6692 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6693 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6694 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6695 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6696 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6697 * xmenu.c, xselect.c:
6698 Declare Q* vars static if they are not used in other modules.
6699 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6700 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6701 Remove decls of unexported vars.
6702 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6703
95c82688
PE
6704 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6705
16a97296
PE
6706 Make Emacs functions such as Fatom 'static' by default.
6707 This makes it easier for human readers (and static analyzers)
6708 to see whether these functions can be called from other modules.
6709 DEFUN now defines a static function. To make the function external
6710 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6711 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6712 (Finit_image_library):
16a97296
PE
6713 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6714 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6715 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6716 Remove decls, since these functions are now static.
6717 (Funintern, Fget_internal_run_time): New decls, since these functions
6718 were already external.
95c82688 6719
16a97296
PE
6720 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6721 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6722 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6723 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6724 * keyboard.c, keymap.c, lread.c:
6725 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6726 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6727 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6728 Mark functions with DEFUE instead of DEFUN,
6729 if they are used in other modules.
6730 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6731 decls for now-static functions.
6732 * buffer.h (Fdelete_overlay): Remove decl.
6733 * callproc.c (Fgetenv_internal): Mark as internal.
6734 * composite.c (Fremove_list_of_text_properties): Remove decl.
6735 (Fcomposition_get_gstring): New forward static decl.
6736 * composite.h (Fcomposite_get_gstring): Remove decl.
6737 * dired.c (Ffile_attributes): New forward static decl.
6738 * doc.c (Fdocumntation_property): New forward static decl.
6739 * eval.c (Ffetch_bytecode): New forward static decl.
6740 (Funintern): Remove extern decl; now in .h file where it belongs.
6741 * fileio.c (Fmake_symbolic_link): New forward static decl.
6742 * image.c (Finit_image_library): New forward static decl.
6743 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6744 * intervals.h (Fprevious_property_change):
6745 (Fremove_list_of_text_properties): Remove decls.
6746 * keyboard.c (Fthis_command_keys): Remove decl.
6747 (Fcommand_execute): New forward static decl.
6748 * keymap.c (Flookup_key): New forward static decl.
6749 (Fcopy_keymap): Now static.
6750 * keymap.h (Flookup_key): Remove decl.
6751 * process.c (Fget_process): New forward static decl.
6752 (Fprocess_datagram_address): Mark as internal.
6753 * syntax.c (Fsyntax_table_p): New forward static decl.
6754 (skip_chars): Remove duplicate decl.
6755 * textprop.c (Fprevious_property_change): New forward static decl.
6756 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6757 Now internal.
6758 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6759 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6760
785bbd42
PE
6761 * editfns.c (Fformat): Remove unreachable code.
6762
8b913b57
AS
67632011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6764
6765 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6766 change. (Bug#8496)
6767
a6744a35
EZ
67682011-04-13 Eli Zaretskii <eliz@gnu.org>
6769
6770 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6771 when at ZV. (Bug#8487)
6772
e7974947
AS
67732011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6774
baad03f0
AS
6775 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6776 (Bug#8437)
6777 * keyboard.c (parse_tool_bar_item): Likewise.
6778 * sound.c (sound_cleanup, alsa_close): Likewise.
6779 * termcap.c (tgetent): Likewise.
6780 * xfns.c (x_default_font_parameter): Likewise.
6781 * xsettings.c (read_and_apply_settings): Likewise.
6782
e7974947
AS
6783 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6784 (overrun_check_free): Protoize.
6785
28272684
PE
67862011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6787
6788 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6789 since callers should never pass a negative size.
6790 Change the signature to match that of plain 'read' and 'write'; see
6791 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6792 * lisp.h: Update prototypes of emacs_write and emacs_read.
6793
11997c76
EZ
67942011-04-11 Eli Zaretskii <eliz@gnu.org>
6795
6796 * xdisp.c (redisplay_window): Don't try to determine the character
6797 position of the scroll margin if the window start point w->startp
e896f03c 6798 is outside the buffer's accessible region. (Bug#8468)
11997c76 6799
8a2cbd72
EZ
68002011-04-10 Eli Zaretskii <eliz@gnu.org>
6801
6802 Fix write-region and its subroutines for buffers > 2GB.
6803 * fileio.c (a_write, e_write): Modify declaration of arguments and
6804 local variables to support buffers larger than 2GB.
6805 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6806
6807 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6808 argument, local variables, and return value.
6809
6810 * lisp.h: Update prototypes of emacs_write and emacs_read.
6811
6812 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6813
4073e537 68142011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6815
1ebfdcb6
PE
6816 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6817
b2ded58d
PE
6818 Fix more problems found by GCC 4.6.0's static checks.
6819
7d66342c
PE
6820 * xdisp.c (vmessage): Use a better test for character truncation.
6821
bbf47d44
PE
6822 * charset.c (load_charset_map): <, not <=, for optimization,
6823 and to avoid potential problems with integer overflow.
9248994d 6824 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6825 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6826 * editfns.c (Fformat): Likewise.
1e69125e 6827 * syntax.c (skip_chars): Likewise.
3befa583 6828
e3019616
PE
6829 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6830 This also lets GCC 4.6.0 generate slightly better loop code.
6831
becfa255
PE
6832 * callint.c (Fcall_interactively): <, not <=, for optimization.
6833 (Fcall_interactively): Count the number of arguments produced,
6834 not the number of arguments given. This is simpler and lets GCC
6835 4.6.0 generate slightly better code.
6836
dae0cd48
PE
6837 * ftfont.c: Distingish more carefully between FcChar8 and char.
6838 The previous code passed unsigned char * to a functions like
6839 strlen and xstrcasecmp that expect char *, which does not
6840 conform to the C standard.
6841 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6842 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6843 char * when the C standard requires it.
6844
76032d70
PE
6845 * keyboard.c (read_char): Remove unused var.
6846
eb3f1cc8
PE
6847 * eval.c: Port to Windows vsnprintf (Bug#8435).
6848 Include <limits.h>.
6849 (SIZE_MAX): Define if the headers do not.
6850 (verror): Do not give up if vsnprintf returns a negative count.
6851 Instead, grow the buffer. This ports to Windows vsnprintf, which
6852 does not conform to C99. Problem reported by Eli Zaretskii.
6853 Also, simplify the allocation scheme, by avoiding the need for
6854 calling realloc, and removing the ALLOCATED variable.
6855
70476b54
PE
6856 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6857
12020a9e
PE
6858 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6859 But keep the doprint source code for now, as we might revamp it
6860 and use it again (Bug#8435).
ea6c7ae6
PE
6861 * lisp.h (doprnt): Remove.
6862 * Makefile.in (base_obj): Remove doprnt.o.
6863 * deps.mk (doprnt.o): Remove.
6864
5fdb398c
PE
6865 error: Print 32- and 64-bit integers portably (Bug#8435).
6866 Without this change, on typical 64-bit hosts error ("...%d...", N)
6867 was used to print both 32- and 64-bit integers N, which relied on
6868 undefined behavior.
6869 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6870 New macro.
6871 * lisp.h (error, verror): Mark as printf-like functions.
6872 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6873 Report overflow in size calculations when allocating printf buffer.
6874 Do not truncate output string at its first null byte.
6875 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6876 Truncate the output at a character boundary, since vsnprintf does not
6877 do that.
6878 * charset.c (check_iso_charset_parameter): Convert internal
6879 character to string before calling 'error', since %c now has the
6880 printf meaning.
6881 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6882 overflow when computing char to be passed to 'error'. Do not
6883 pass Lisp_Object to 'error'; pass the integer instead.
6884 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6885 formatted with plain %d.
6886
b189fa66
PE
6887 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6888
bff87ef0
PE
6889 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6890
7e2cac20
PE
6891 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6892
ce4d90b5
PE
6893 * xterm.c (x_catch_errors): Remove duplicate declaration.
6894
266c9547
PE
6895 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6896
79c49ad2
PE
6897 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6898
368f4090
JM
68992011-04-10 Jim Meyering <meyering@redhat.com>
6900
6901 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6902 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6903 return ssize_t not "int", and use size_t as the buffer length.
6904 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6905 * gnutls.h: Update declarations.
6906 * process.c (read_process_output): Use ssize_t, to match.
6907 (send_process): Likewise.
6908
a32d4040
CY
69092011-04-09 Chong Yidong <cyd@stupidchicken.com>
6910
6911 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6912
8546720e 69132011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6914
04f2d78b
CB
6915 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6916 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6917
8546720e
GM
6918 * xterm.c (handle_one_xevent):
6919 * xmenu.c (create_and_show_popup_menu):
6920 * xselect.c (x_decline_selection_request)
6921 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6922
0a2f5c1a 69232011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6924
6925 Fix some uses of `int' instead of EMACS_INT.
6926 * search.c (string_match_1, fast_string_match)
6927 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6928 (scan_buffer, find_next_newline_no_quit)
6929 (find_before_next_newline, search_command, Freplace_match)
6930 (Fmatch_data): Make some `int' variables be EMACS_INT.
6931
6932 * xdisp.c (display_count_lines): 3rd argument and return value now
6933 EMACS_INT. All callers changed.
6934 (pint2hrstr): Last argument is now EMACS_INT.
6935
6936 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6937 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6938 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6939 (decode_coding_utf_16, decode_coding_emacs_mule)
6940 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6941 (decode_coding_ccl, decode_coding_charset)
6942 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6943 (decode_coding_iso_2022, decode_coding_emacs_mule)
6944 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6945 <char_offset, last_offset>: Declare EMACS_INT.
6946 (encode_coding_utf_8, encode_coding_utf_16)
6947 (encode_coding_emacs_mule, encode_invocation_designation)
6948 (encode_designation_at_bol, encode_coding_iso_2022)
6949 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6950 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6951 Declare EMACS_INT.
6952 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6953 (encode_invocation_designation): Last argument P_NCHARS is now
6954 EMACS_INT.
6955 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6956 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6957
6958 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6959 All users changed.
6960
6961 * ccl.c (Fccl_execute_on_string): Declare some variables
6962 EMACS_INT.
6963
8546720e 69642011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6965
6966 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6967
4e19a977
CS
69682011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6969
6970 * process.c (Fformat_network_address): Doc fix.
6971
87302331
R
69722011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6973
6974 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6975
cbb59342
CY
69762011-04-08 Chong Yidong <cyd@stupidchicken.com>
6977
6978 * keyboard.c (read_char): Call Lisp function help-form-show,
6979 instead of using internal_with_output_to_temp_buffer.
6980 (Qhelp_form_show): New var.
e0d38eeb 6981 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6982
6983 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6984
6985 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6986
e67a13ab
CY
69872011-04-06 Chong Yidong <cyd@stupidchicken.com>
6988
04f2d78b
CB
6989 * process.c (Flist_processes): Remove to Lisp.
6990 (list_processes_1): Delete.
e67a13ab 6991
973f782d
EZ
69922011-04-06 Eli Zaretskii <eliz@gnu.org>
6993
7c106b1e
EZ
6994 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6995
973f782d
EZ
6996 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6997
41cf7d1a 69982011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6999
ca23cc88
PE
7000 Fix more problems found by GCC 4.6.0's static checks.
7001
f390e2d5
PE
7002 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7003
42eea0d0
PE
7004 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7005
b69769da 7006 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7007
f9541e84
PE
7008 * xdisp.c (vmessage): Mark as a printf-like function.
7009
13841b55
PE
7010 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7011
c136c10f
PE
7012 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7013
5e2d4a30
PE
7014 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7015 printf-like functions.
7016 (tiff_load): Add casts to remove these marks before passing them
7017 to system-supplied API.
7018
583f48b9
PE
7019 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7020
b25d760e
PE
7021 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7022 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7023 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7024 directly, rather than having caller test rule sign. This avoids
7025 some unnecessary tests.
7026 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7027 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7028 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7029
bc7b6697 7030 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7031 (xfont_open): Avoid unnecessary tests.
bc7b6697 7032
27ccc379
PE
7033 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7034
dcd5c89a
PE
7035 * composite.h, composite.c (composition_gstring_put_cache):
7036 Use EMACS_INT, not int, for length.
7037
b13a45c6
PE
7038 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7039 breaking out part of COMPOSITION_DECODE_RULE.
7040 (COMPOSITION_DECODE_RULE): Use it.
7041 * composite.c (get_composition_id): Remove unused local vars,
7042 by using the new macro.
7043
1e792e4d
PE
7044 * textprop.c (set_text_properties_1): Change while to do-while,
7045 since the condition is always true at first.
7046
dc6c6455 7047 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7048 (interval_deletion_adjustment): Return unsigned value.
7049 All uses changed.
dc6c6455 7050
aba7731a
PE
7051 * process.c (list_processes_1, create_pty, read_process_output):
7052 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7053 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7054 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7055 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7056 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7057
fdfc4bf3
PE
7058 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7059
fca8fe46 7060 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7061 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7062
06a0259a 7063 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7064 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7065 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7066
e7b9e80f
PE
7067 * print.c (print_error_message): Avoid int overflow.
7068
56201685
PE
7069 * font.c (font_list_entities): Redo for clarity,
7070 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7071
78834453 7072 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7073 (font_score): Avoid potential overflow in diff calculation.
78834453 7074
0bc0b309 7075 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7076 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7077
e610eaca
PE
7078 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7079
b895abce
PE
7080 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7081 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7082 can always succeed if overflow has undefined behavior.
7083
1f1d9321 7084 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7085 (wordify): Omit three unnecessary tests.
1f1d9321 7086
c59478bc
PE
7087 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7088 All callers changed. This avoids the need for an unused var.
7089
79b73827
PE
7090 * casefiddle.c (casify_region): Remove var that is set but not used.
7091
a4db5dfe
PE
7092 * dired.c (file_name_completion): Remove var that is set but not used.
7093
43aae36e
PE
7094 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7095
2a47c44d 7096 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7097 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7098
a37c69bf
PE
7099 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7100 Check for integer overflow on size calculations.
7101
328ab8e7
PE
7102 * buffer.c (Fprevious_overlay_change): Remove var that is set
7103 but not used.
7104
e5a2a5cb
PE
7105 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7106 Remove vars that are set but not used.
8d84a6eb 7107 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7108 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7109
a60e5f68
PE
7110 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7111
f661cb61 7112 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7113 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7114
f0397f5a
PE
7115 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7116 that are set but not used.
7117
8664db06 7118 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7119 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7120
6abdaa4a
PE
7121 * xselect.c (x_get_local_selection, x_handle_property_notify):
7122 Remove vars that are set but not used.
7123
0ce7538d 7124 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7125 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7126
9ae848fc
PE
7127 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7128 Remove var that is set but not used.
0b918413
PE
7129 (scroll_bar_windows_size): Now size_t, not int.
7130 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7131 Check for overflow.
9ae848fc 7132
a5a62657
PE
7133 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7134 (map_tty_color) [!defined MSDOS]: Likewise.
7135
5c5cdd39
PE
7136 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7137
66ebf983
PE
7138 * coding.c: Remove vars that are set but not used.
7139 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7140 All callers changed.
7141 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7142 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7143 (decode_coding_charset): Remove vars that are set but not used.
7144
1be4d761
PE
7145 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7146 that is set but not used.
7147
47553fa8
PE
7148 * print.c (print_object): Remove var that is set but not used.
7149
1f7196bf 7150 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7151 The gnulib version avoids calling malloc in the usual case,
7152 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7153 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7154 * filelock.c (current_lock_owner): Likewise.
7155 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7156 * sysdep.c: Include allocator.h, careadlinkat.h.
7157 (emacs_no_realloc_allocator): New static constant.
7158 (emacs_readlink): New function.
fdb61804
PE
7159 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7160 ../lib/careadlinkat.h.
d1fdcab7 7161
f84c17c7
SM
71622011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7163
7164 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7165 first non-nil return value).
7166
ef3862ad
JD
71672011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7168
7169 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7170 if not defined (Bug#8403).
7171
376a7006
JB
71722011-04-02 Juanma Barranquero <lekktu@gmail.com>
7173
7174 * xdisp.c (display_count_lines): Remove parameter `start',
7175 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7176 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7177 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7178 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7179 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7180 and thereabouts. All callers changed.
7181 (get_per_char_metric): Remove parameter `f', unused since
7182 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7183
6ca3801d
JM
71842011-04-02 Jim Meyering <meyering@redhat.com>
7185
7186 do not dereference NULL upon failed strdup
7187 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7188 (ns_get_family): Likewise.
7189
d8e2b5ba
JB
71902011-04-02 Juanma Barranquero <lekktu@gmail.com>
7191
7192 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7193
8c74fcbd
JD
71942011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7195
7196 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7197 later (Bug#8403).
7198
7200d79c
SM
71992011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7200
03408648 7201 Add lexical binding.
7200d79c 7202
03408648
SM
7203 * window.c (Ftemp_output_buffer_show): New fun.
7204 (Fsave_window_excursion):
7205 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7206
7207 * lread.c (lisp_file_lexically_bound_p): New function.
7208 (Fload): Bind Qlexical_binding.
7209 (readevalloop): Remove `evalfun' arg.
7210 Bind Qinternal_interpreter_environment.
7211 (Feval_buffer): Bind Qlexical_binding.
7212 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7213 Mark as dynamic.
7214 (syms_of_lread): Declare `lexical-binding'.
7215
7216 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7217
7218 * keyboard.c (eval_dyn): New fun.
7219 (menu_item_eval_property): Use it.
ca105506
SM
7220
7221 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7222
03408648
SM
7223 * fns.c (concat, mapcar1): Accept byte-code-functions.
7224
7225 * eval.c (Fsetq): Handle lexical vars.
7226 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7227 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7228 (FletX, Flet): Obey lexical binding.
7229 (Fcommandp): Handle closures.
7230 (Feval): New `lexical' arg.
7231 (eval_sub): New function extracted from Feval. Use it almost
7232 everywhere where Feval was used. Look up vars in lexical env.
7233 Handle closures.
7234 (Ffunctionp): Move from subr.el.
7235 (Ffuncall): Handle closures.
7236 (apply_lambda): Remove `eval_flags'.
7237 (funcall_lambda): Handle closures and new byte-code-functions.
7238 (Fspecial_variable_p): New function.
7239 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7240 but without exporting it to Lisp.
23aba0ea 7241
23aba0ea 7242 * doc.c (Fdocumentation, store_function_docstring):
03408648 7243 * data.c (Finteractive_form): Handle closures.
23aba0ea 7244
03408648
SM
7245 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7246 interactive spec.
ba83908c 7247
04f2d78b
CB
7248 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7249 New byte-codes.
03408648
SM
7250 (exec_byte_code): New function extracted from Fbyte_code to handle new
7251 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7252
03408648 7253 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7254
03408648 7255 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7256
e2abce01
JB
72572011-03-31 Juanma Barranquero <lekktu@gmail.com>
7258
7259 * xdisp.c (redisplay_internal): Fix prototype.
7260
63696a73 72612011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7262
63696a73 7263 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7264 (try_scrolling): Use it when setting scroll_limit.
7265 Limit scrolling to 100 screen lines.
63696a73
EZ
7266 (redisplay_window): Even when falling back on "recentering",
7267 position point in the window according to scroll-conservatively,
7268 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7269
7270 (try_scrolling): When point is above the window, allow searching
7271 as far as scroll_max, or one screenful, to compute vertical
7272 distance from PT to the scroll margin position. This prevents
7273 try_scrolling from unnecessarily failing when
7274 scroll-conservatively is set to a value slightly larger than the
7275 window height. Clean up the case of PT below the margin at bottom
7276 of window: scroll_max can no longer be INT_MAX. When aggressive
7277 scrolling is in use, don't let point enter the opposite scroll
7278 margin as result of the scroll.
7279 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7280 threshold of 100 lines for never-recentering scrolling.
7281
e4cc2dfc
JB
72822011-03-31 Juanma Barranquero <lekktu@gmail.com>
7283
7284 * dispextern.h (move_it_by_lines):
7285 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7286 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7287 (message_log_check_duplicate): Remove parameters `prev_bol' and
7288 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7289 (redisplay_internal): Remove parameter `preserve_echo_area',
7290 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7291
7292 * indent.c (Fvertical_motion):
7293 * window.c (window_scroll_pixel_based, Frecenter):
7294 Don't pass `need_y_p' to `move_it_by_lines'.
7295
1c470562
SM
72962011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7297
44f230aa
SM
7298 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7299 steal a few bits to be more compact.
7300 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7301 Remove unneeded casts.
7302
1c470562
SM
7303 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7304
888adce9
ZK
73052011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7306
7307 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7308 binding" message (bug#7967).
7309
f838ed7b
PE
73102011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7311
77861b95
PE
7312 Fix more problems found by GCC 4.6.0's static checks.
7313
de6dbc14
PE
7314 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7315 Remove unused local var.
7316
f838ed7b
PE
7317 * editfns.c (Fmessage_box): Remove unused local var.
7318
792c7b2b
PE
7319 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7320 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7321 Omit unused local vars.
c499e557 7322 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7323 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7324 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7325 Omit unused local var.
7326
ba0165e1
PE
7327 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7328 Don't assume string length fits in int.
32ad8845 7329 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7330 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7331
3c59b4c9
PE
7332 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7333 instead of alloca (Bug#8344).
7334
a3eed478 7335 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7336 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7337
eb4d412d
PE
7338 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7339
1658b401
PE
7340 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7341 concerns.
7342
7343 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7344
7345 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7346
9a2c6e05
PE
7347 * keyboard.c (syms_of_keyboard): Use the same style as later
7348 in this function when indexing through an array. This also
7349 works around GCC bug 48267.
7350
03d0a109
PE
7351 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7352
44f730c8
PE
7353 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7354
fe75f926
PE
7355 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7356 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7357
ffa8c828
PE
7358 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7359 This avoids undefined behavior on integer overflow, and is a bit
7360 more convenient anyway since it is compared to a size_t variable.
7361
c5101a77
PE
7362 Variadic C functions now count arguments with size_t, not int.
7363 This avoids an unnecessary limitation on 64-bit machines, which
7364 caused (substring ...) to crash on large vectors (Bug#8344).
7365 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7366 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7367 All variadic functions and their callers changed accordingly.
c5101a77
PE
7368 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7369 * data.c (arith_driver, float_arith_driver): Likewise.
7370 * editfns.c (general_insert_function): Likewise.
7371 * eval.c (struct backtrace.nargs, interactive_p)
7372 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7373 (funcall_lambda, mark_backtrace): Likewise.
7374 * fns.c (concat): Likewise.
7375 * frame.c (x_set_frame_parameters): Likewise.
7376 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7377 0 if not found, not -1. All callers changed.
7378
dd3f25f7
PE
7379 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7380 (stack_copy_size): Now size_t, not int.
7381 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7382
461c2ab9
JB
73832011-03-28 Juanma Barranquero <lekktu@gmail.com>
7384
7385 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7386 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7387 All callers changed.
7388
7389 * lisp.h (multibyte_char_to_unibyte):
7390 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7391 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7392 * character.h (CHAR_TO_BYTE8):
7393 * cmds.c (internal_self_insert):
7394 * editfns.c (general_insert_function):
7395 * keymap.c (push_key_description):
7396 * search.c (Freplace_match):
7397 * xdisp.c (message_dolog, set_message_1): All callers changed.
7398
f6d62986
SM
73992011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7400
7401 * keyboard.c (safe_run_hook_funcall): New function.
7402 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7403 don't set the hook to nil, but remove the offending function instead.
7404 (Qcommand_hook_internal): Remove, unused.
7405 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7406 Vcommand_hook_internal.
7407
7408 * eval.c (enum run_hooks_condition): Remove.
7409 (funcall_nil, funcall_not): New functions.
7410 (run_hook_with_args): Call each function through a `funcall' argument.
7411 Remove `cond' argument, now redundant.
7412 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7413 (Frun_hook_with_args_until_failure): Adjust accordingly.
7414 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7415
1db5b1ad
JB
74162011-03-28 Juanma Barranquero <lekktu@gmail.com>
7417
7418 * dispextern.h (string_buffer_position): Remove declaration.
7419
7420 * print.c (strout): Remove parameter `multibyte', unused since
7421 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7422
7423 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7424 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7425 All callers changed.
7426
7427 * w32.c (_wsa_errlist): Use braces for struct initializers.
7428
7429 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7430 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7431 All callers changed.
7432 (string_buffer_position): Likewise. Also, make static (it's never
7433 used outside xdisp.c).
7434 (cursor_row_p): Remove parameter `w', unused since
7435 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7436 (decode_mode_spec): Remove parameter `precision', introduced during
7437 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7438 All callers changed.
7439
5ffb62aa
JD
74402011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7441
7442 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7443
461c2ab9 74442011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7445
7446 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7447 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7448 (ns_update_auto_hide_menu_bar): New functions.
7449 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7450 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7451 ns_constrain_all_frames.
7452 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7453 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7454
5c380ffb
JD
74552011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7456
7457 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7458
9af30bdf
GM
74592011-03-27 Glenn Morris <rgm@gnu.org>
7460
7461 * syssignal.h: Replace RETSIGTYPE with void.
7462 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7463 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7464 Replace SIGTYPE with void everywhere.
7465 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7466 * s/template.h (SIGTYPE): Remove commented out definition.
7467
e2abce01
JB
74682011-03-26 Eli Zaretskii <eliz@gnu.org>
7469
7470 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7471 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7472
f868cd8a
JB
74732011-03-26 Juanma Barranquero <lekktu@gmail.com>
7474
59eb0929
JB
7475 * w32.c (read_unc_volume): Use parameter `henum', instead of
7476 global variable `wget_enum_handle'.
7477
7478 * keymap.c (describe_vector): Remove parameters `indices' and
7479 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7480 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7481
f868cd8a
JB
7482 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7483
7484 * keyboard.c (timer_check): Remove parameter `do_it_now',
7485 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7486 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7487 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7488
7489 * keyboard.c (read_char):
7490 * w32menu.c (w32_menu_display_help):
7491 * xmenu.c (show_help_event, menu_help_callback):
7492 Adjust calls to `show_help_echo'.
7493
7494 * gtkutil.c (xg_maybe_add_timer):
7495 * keyboard.c (readable_events):
7496 * process.c (wait_reading_process_output):
7497 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7498
7499 * insdel.c (adjust_markers_gap_motion):
7500 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7501 (gap_left, gap_right): Don't call it.
7502
2ecf6fdb
CY
75032011-03-25 Chong Yidong <cyd@stupidchicken.com>
7504
7505 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7506 incurred during fontification.
7507
6b1f9ba4
JB
75082011-03-25 Juanma Barranquero <lekktu@gmail.com>
7509
7510 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7511 (DEFVAR_PER_BUFFER): Don't pass it.
7512
7513 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7514 (scrolling_window): Don't pass it.
7515
0f4a96b5
JB
75162011-03-25 Juanma Barranquero <lekktu@gmail.com>
7517
7518 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7519
7520 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7521 and `suffix'.
7522 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7523 of variables specific to SELinux and computation of `encoded_absname'.
7524
7525 * image.c (XPutPixel): Remove unused variable `height'.
7526
7527 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7528
7529 * unexw32.c (get_section_info): Remove unused variable `section'.
7530
7531 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7532 (system_process_attributes): Remove unused variable `sess'.
7533 (sys_read): Remove unused variable `err'.
7534
7535 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7536 (w32_wnd_proc): Remove unused variable `isdead'.
7537 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7538 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7539 (x_create_tip_frame): Remove unused variable `tem'.
7540
7541 * w32inevt.c (w32_console_read_socket):
7542 Remove unused variable `no_events'.
7543
7544 * w32term.c (x_draw_composite_glyph_string_foreground):
7545 Remove unused variable `width'.
7546
1149507c
JB
75472011-03-24 Juanma Barranquero <lekktu@gmail.com>
7548
7549 * w32term.c (x_set_glyph_string_clipping):
7550 Don't pass uninitialized region to CombineRgn.
7551
9c88f339
JB
75522011-03-23 Juanma Barranquero <lekktu@gmail.com>
7553
7554 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7555 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7556 (Fx_close_connection): Remove unused variable `i'.
7557
7558 * w32font.c (w32font_draw): Return number of glyphs.
7559 (w32font_open_internal): Remove unused variable `i'.
7560 (w32font_driver): Add missing initializer.
7561
7562 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7563 (fill_in_menu): Remove unused variable `items_added'.
7564
7565 * w32term.c (last_mouse_press_frame): Remove static global variable.
7566 (w32_clip_to_row): Remove unused variable `f'.
7567 (x_delete_terminal): Remove unused variable `i'.
7568
7569 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7570 (NOTHING): Remove unused static global variable.
7571 (uniscribe_check_otf): Remove unused variable `table'.
7572 (uniscribe_font_driver): Add missing initializers.
7573
dee091a3
JD
75742011-03-23 Julien Danjou <julien@danjou.info>
7575
7576 * term.c (Fsuspend_tty, Fresume_tty):
7577 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7578 * window.c (temp_output_buffer_show):
7579 * insdel.c (signal_before_change):
7580 * frame.c (Fhandle_switch_frame):
7581 * fileio.c (Fdo_auto_save):
7582 * emacs.c (Fkill_emacs):
7583 * editfns.c (save_excursion_restore):
7584 * cmds.c (internal_self_insert):
7585 * callint.c (Fcall_interactively):
7586 * buffer.c (Fkill_all_local_variables):
7587 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7588 Use Frun_hooks.
0f4a96b5 7589 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7590 unconditionnaly since it does the check itself.
7591
2c520ab5 75922011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7593
c9c49752
PE
7594 Fix more problems found by GCC 4.5.2's static checks.
7595
8abc3f12
PE
7596 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7597 the first time through the loop, since we know p0 < p1 then.
7598 This also avoids a gcc -Wstrict-overflow warning.
7599
a2d26660
PE
7600 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7601 leading to a memory leak, possible in functions like
7602 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7603 of objects (Bug#8318).
a2d26660 7604
916c72e9
PE
7605 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7606 that could (at least in theory) be that large.
7607
19ab8a18
PE
7608 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7609 This is less likely to overflow, and avoids undefined behavior if
7610 overflow does occur. All callers changed. Use strtoul to scan
7611 for the unsigned long integer.
b7cbbd6f
PE
7612 (pint2hrstr): Simplify and tune code slightly.
7613 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7614
f0641eff
PE
7615 * scroll.c (do_scrolling): Work around GCC bug 48228.
7616 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7617
7f650bb9
PE
7618 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7619 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7620 (validate_x_resource_name): Simplify count usage.
7621 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7622
37dd57d1
PE
7623 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7624 fail (Bug#8306).
81e56e61 7625
699979fc 7626 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7627
401bf9b4
PE
7628 * process.c (Fmake_network_process): Use socklen_t, not int,
7629 where POSIX says socklen_t is required in portable programs.
7630 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7631 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7632 (Fmake_network_process, server_accept_connection):
7633 (wait_reading_process_output, read_process_output):
7634 Likewise.
7635
b93aacde
PE
7636 * process.c: Rename or move locals to avoid shadowing.
7637 (list_processes_1, Fmake_network_process):
7638 (read_process_output_error_handler, exec_sentinel_error_handler):
7639 Rename or move locals.
4dc343ee 7640 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7641 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7642 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7643 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7644 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7645
af8a867c 7646 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7647 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7648 Include tparam.h instead, since it declares them.
af8a867c
PE
7649 * cm.h (PC): Remove extern decl; tparam.h now does this.
7650 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7651 * terminfo.c: Include tparam.h, to check interfaces.
7652 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7653 (tparam): Adjust signature to match interface in tparam.h;
7654 this removes some undefined behavior. Check that outstring and len
7655 are zero, which they always are with Emacs.
7656 * tparam.h (PC, BC, UP): New extern decls.
7657
0248044d 7658 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7659 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7660
8ff096c1 7661 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7662 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7663 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7664 (ftfont_list): Remove unused local.
49eaafba
PE
7665 (get_adstyle_property, ftfont_pattern_entity):
7666 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7667 Rename locals to avoid shadowing.
8ff096c1 7668
e2be39f6
PE
7669 * xfont.c (xfont_list_family): Mark var as initialized.
7670
c9735e30
PE
7671 * xml.c (make_dom): Now static.
7672
8f5201ae
PE
7673 * composite.c (composition_compute_stop_pos): Rename local to
7674 avoid shadowing.
b246f932
PE
7675 (composition_reseat_it): Remove unused locals.
7676 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7677 (composition_update_it): Mark var as initialized.
11b61122
PE
7678 (find_automatic_composition): Mark vars as initialized,
7679 with a FIXME (Bug#8290).
8f5201ae 7680
760fbc2c
PE
7681 character.h: Rename locals to avoid shadowing.
7682 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7683 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7684 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7685 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7686 to avoid shadowing.
7687
ff08eb85
PE
7688 * textprop.c (property_change_between_p): Remove; unused.
7689
fc7bf025
PE
7690 * intervals.c (interval_start_pos): Now static.
7691
235d7abc
PE
7692 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7693
44f230aa
SM
7694 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7695 Rename locals to avoid shadowing.
3e7d6594 7696
50060332
PE
7697 * sound.c (wav_play, au_play, Fplay_sound_internal):
7698 Fix pointer signedness.
d01f234b 7699 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7700 (wav_play): Initialize a variable to 0, to prevent undefined
7701 behavior (Bug#8278).
50060332 7702
c4fc4e30
PE
7703 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7704
918436ed
PE
7705 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7706
c939f91b
PE
7707 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7708 clobbering (Bug#8298).
b9c7f648
PE
7709 * sysdep.c (sys_subshell): Likewise.
7710 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7711
6bd8c144
PE
7712 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7713 This should get cleaned up, so that child_setup has the
7714 same signature on all platforms.
7715
7710357c 7716 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7717 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7718
c59da222
CY
77192011-03-22 Chong Yidong <cyd@stupidchicken.com>
7720
7721 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7722 not to be necessary, and produces flickering.
7723
66b87493
GM
77242011-03-20 Glenn Morris <rgm@gnu.org>
7725
7726 * config.in: Remove file.
7727
45b6f6d5
JB
77282011-03-20 Juanma Barranquero <lekktu@gmail.com>
7729
7730 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7731 are now in src/globals.h.
7732 (syms_of_minibuf): Remove spurious & from previous change.
7733
3ec03f7e
LL
77342011-03-20 Leo <sdl.web@gmail.com>
7735
7736 * minibuf.c (completing-read-function): New variable.
7737 (completing-read-default): Rename from completing-read.
7738 (completing-read): Call completing-read-function.
7739
b14e3e21
CY
77402011-03-19 Juanma Barranquero <lekktu@gmail.com>
7741
7742 * xfaces.c (Fx_load_color_file):
7743 Read color file from absolute filename (bug#8250).
7744
f2b726e6
JB
77452011-03-19 Juanma Barranquero <lekktu@gmail.com>
7746
7747 * makefile.w32-in: Update dependencies.
7748
09f6ff02
EZ
77492011-03-17 Eli Zaretskii <eliz@gnu.org>
7750
7751 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7752
29a6015a
PE
77532011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7754
a3a6c54e
PE
7755 Fix more problems found by GCC 4.5.2's static checks.
7756
b766f867
PE
7757 * process.c (make_serial_process_unwind, send_process_trap):
7758 (sigchld_handler): Now static.
7759
be02381c
PE
7760 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7761 That way, the code declares only the vars that it needs.
7762 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7763 * s/cygwin.h (PTY_ITERATION): Likewise.
7764 * s/darwin.h (PTY_ITERATION): Likewise.
7765 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7766
57048744
PE
7767 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7768 * process.c (allocate_pty): Don't declare stb unless it's needed.
7769
7914961c 7770 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7771 (CONSTANTLIM): Remove; unused.
7772 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7773 Define only if needed.
7914961c 7774
b3967b18
PE
7775 * unexelf.c (unexec): Name an expression,
7776 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7777 Use a different way to cause a compilation error if anyone uses
7778 n rather than nn, a way that does not involve shadowing.
73366a00 7779 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7780
29a6015a
PE
7781 * deps.mk (unexalpha.o): Remove; unused.
7782
43cfc33e 7783 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7784 * unexec.h: New file.
ce701a33
PE
7785 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7786 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7787 Depend on unexec.h.
7788 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7789 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7790 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7791 Change as necessary to match prototype in unexec.h.
ce701a33 7792
01f44d5a
PE
7793 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7794 shadowing.
4f63c6bb 7795 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7796
a6670b0b
PE
7797 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7798 Rename locals to avoid shadowing.
7799
cef2010d 7800 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7801 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7802
d4d7173a
PE
7803 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7804
f08b802a
PE
7805 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7806 warning when compiling print.c.
7807
3ddb0639
PE
7808 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7809 instead of using an uninitialized var.
5ad03b97 7810 (font_sort_entities): Mark var as initialized.
3ddb0639 7811
170a2692
PE
7812 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7813
e663c700
PE
7814 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7815 pointers to constants.
89bc529a 7816 (font_parse_fcname): Remove unused vars.
7b81e2d0 7817 (font_delete_unmatched): Now static.
ea838e10 7818 (font_get_spec): Remove; unused.
13a547c6
PE
7819 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7820 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7821 Rename or move locals to avoid shadowing.
e663c700 7822
2a80c887 7823 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7824 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7825
1384fa33 7826 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7827 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7828
8b2c52e9
PE
7829 * alloc.c (mark_backtrace): Move decl from here ...
7830 * lisp.h: ... to here, so that it can be checked.
7831
475545b5 7832 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7833 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7834 (lisp_indirect_variable): Name an expression,
7835 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7836 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7837
b1349114 7838 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7839 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7840 Use const pointer when appropriate.
b1349114 7841
a2928364
PE
7842 * lisp.h (get_system_name, get_operating_system_release):
7843 Move decls here, to check interfaces.
7844 * process.c (get_operating_system_release): Move decl to lisp.h.
7845 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7846 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7847 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7848 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7849 (Fformat_time_string, Fencode_time, Finsert_char):
7850 (Ftranslate_region_internal, Fformat):
7851 Rename or remove local vars to avoid shadowing.
9710023e 7852 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7853
a415e694
PE
7854 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7855 avoid shadowing.
7856
8ef4622d
PE
7857 * lisp.h (eassert): Check that the argument compiles, even if
7858 ENABLE_CHECKING is not defined.
7859
946f9a5b
PE
7860 * data.c (Findirect_variable): Name an expression, to avoid
7861 gcc -Wbad-function-cast warning.
112396d6 7862 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7863 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7864 (Fmake_variable_buffer_local, Fmake_local_variable):
7865 Mark variables as initialized.
52746918 7866 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7867
e5aab7e7 7868 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7869 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7870 Rename locals to avoid shadowing.
dff45157
PE
7871 (mark_stack): Move local variables into the #ifdef region where
7872 they're used.
7bc26fdb
PE
7873 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7874 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7875 needed otherwise.
7876 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7877 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7878 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7879
e5aab7e7
PE
7880 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7881 avoids undefined behavior in theory.
7882
4da60324
PE
7883 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7884
88043301
PE
7885 Use functions, not macros, for up- and down-casing (Bug#8254).
7886 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7887 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7888 to use the following functions instead of these macros.
7889 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7890 EMACS_INT, since callers assume the returned value fits in int.
7891 (upcase1): Likewise, for UPCASE_TABLE.
7892 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7893 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7894 the race-condition problem in the old DOWNCASE.
88043301 7895
19ed5445
PE
7896 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7897 Rename locals to avoid shadowing.
7898 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7899 (regex_compile, re_search_2, re_match_2_internal):
7900 Remove unused local vars.
952db0d7
PE
7901 (FREE_VAR): Rewrite so as not to use empty "else",
7902 which gcc can warn about.
da053e48 7903 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7904 (RETALLOC_IF): Define only if needed.
7905 (WORDCHAR_P): Likewise. This one is never needed, but is used
7906 only in a comment talking about a compiler bug, so put inside
7907 the #if 0 of that comment.
7908 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7909 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7910 Remove; unused.
19ed5445 7911
1f3561e4 7912 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7913 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7914 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7915
ded6f8f7
PE
7916 * search.c (simple_search): Remove unused var.
7917
dbd37a95
PE
7918 * dired.c (compile_pattern): Move decl from here ...
7919 * lisp.h: ... to here, so that it can be checked.
7920 (struct re_registers): New forward decl.
7921
7e47afad
PE
7922 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7923
85f24f61
PE
7924 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7925 All uses changed.
7926 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7927 Rename locals to avoid shadowing.
5671df8f 7928 (Fvertical_motion): Mark locals as initialized.
85f24f61 7929
181aa2be 7930 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7931 (casify_region): Mark local as initialized.
181aa2be 7932
930d429c
PE
7933 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7934
7082eac6
PE
7935 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7936 New macros, so that the caller can use some names other than
7937 gcpro1, gcpro2, etc.
7938 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7939 of the new macros.
7940 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7941 argument, for consistency with GCPRO2_VAR, etc: it is now the
7942 prefix of the variable, not the variable itself. All uses
7943 changed.
38b2c076
PE
7944 * dired.c (directory_files_internal, file_name_completion):
7945 Rename locals to avoid shadowing.
7946
15206ed9
PE
7947 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7948 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7949 dired.c's scmp function, had undefined behavior.
7950 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7951 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7952 * buffer.h: ... to here, because these macros use current_buffer,
7953 and the new implementation with inline functions needs to have
7954 current_buffer in scope now, rather than later when the macros
7955 are used.
7956 (downcase, upcase1): New static inline functions.
7957 (DOWNCASE, UPCASE1): Reimplement using these functions.
7958 This avoids undefined behavior in expressions like
7959 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7960 from race conditions in accessing the global variables
7961 case_temp1 and case_temp2.
7962 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7963 * lisp.h (case_temp1, case_temp2): Remove their decls.
7964 * character.h (ASCII_CHAR_P): Move from here ...
7965 * lisp.h: ... to here, so that the inline functions mentioned
7966 above can use them.
7967
4a6bea26
PE
7968 * dired.c (directory_files_internal_unwind): Now static.
7969
f14b7e14
PE
7970 * fileio.c (file_name_as_directory, directory_file_name):
7971 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7972 Now static.
2893f146
PE
7973 (file_name_as_directory): Use const pointers when appropriate.
7974 (Fexpand_file_name): Likewise. In particular, newdir might
7975 point at constant storage, so make it a const pointer.
fd4ead52 7976 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7977 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7978 signedness issues.
f839df0c
PE
7979 (Fset_file_times, Finsert_file_contents, auto_save_error):
7980 Rename locals to avoid shadowing.
f14b7e14 7981
5716756e 7982 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7983 (Ftry_completion, Fall_completions): Rename or remove locals
7984 to avoid shadowing.
5716756e 7985
b4c3046a
PE
7986 * marker.c (bytepos_to_charpos): Remove; unused.
7987
b45db522
PE
7988 * lisp.h (verify_bytepos, count_markers): New decls,
7989 so that gcc does not warn that these functions aren't declared.
7990
85876d07
PE
7991 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7992 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7993 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7994 (copy_text): Remove unused local var.
85876d07 7995
03d78a21 7996 * filelock.c (within_one_second): Now static.
b3dd38ab 7997 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7998
5df8f01b
PE
7999 * buffer.c (fix_overlays_before): Mark locals as initialized.
8000 (fix_start_end_in_overlays): Likewise. This function should be
8001 simplified by using pointers-to-pointers, but that's a different
8002 matter.
b1d876f1 8003 (switch_to_buffer_1): Now static.
8f54f30a
PE
8004 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8005 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8006
a70072c9 8007 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8008 Fix pointer signedness issue.
edced198
PE
8009 (sys_subshell): Mark local as volatile if checking for lint,
8010 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8011 (MAXPATHLEN): Define only if needed.
a70072c9 8012
a0977c44
PE
8013 * process.c (serial_open, serial_configure): Move decls from here ...
8014 * systty.h: ... to here, so that they can be checked.
8015
a884fdcc
PE
8016 * fns.c (get_random, seed_random): Move extern decls from here ...
8017 * lisp.h: ... to here, so that they can be checked.
8018
604efe86 8019 * sysdep.c (reset_io): Now static.
b8950c94 8020 (wait_for_termination_signal): Remove; unused.
604efe86 8021
38fc62d9
PE
8022 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8023 (copy_keymap_item, append_key, push_text_char_description):
8024 Now static.
1004a21a 8025 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8026 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8027 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8028 (describe_map_tree):
8029 Rename locals to avoid shadowing.
38fc62d9 8030
2f2650da
PE
8031 * keyboard.c: Declare functions static if they are not used elsewhere.
8032 (echo_char, echo_dash, cmd_error, top_level_2):
8033 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8034 (read_char, kbd_buffer_get_event, make_lispy_position):
8035 (make_lispy_event, make_lispy_movement, apply_modifiers):
8036 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8037 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8038 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8039 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8040 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8041
a053e86c 8042 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8043 (mark_kboards): Move decl here ...
8044 * alloc.c (mark_kboards): ... from here.
a053e86c 8045
4752793e
PE
8046 * lisp.h (force_auto_save_soon): New decl.
8047
74f10ca7 8048 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8049 (DEFINE_DUMMY_FUNCTION): New macro.
8050 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8051 Use it.
c03cd23f
PE
8052 (main): Add casts to avoid warnings
8053 if GCC considers string literals to be constants.
74f10ca7 8054
022e70d4
PE
8055 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8056
59d6fe83
PE
8057 * dbusbind.c: Pointer signedness fixes.
8058 (xd_signature, xd_append_arg, xd_initialize):
8059 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8060 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8061 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8062 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8063
78320123
PE
8064 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8065 if GCC considers string literals to be constants.
49cebcca 8066 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8067
35ac2a97
SM
80682011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8069
fb103ca9
SM
8070 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8071 (print_preprocess, print_object): New macro to fix last change.
8072
35ac2a97
SM
8073 * print.c (print_preprocess): Don't forget font objects.
8074
62973b41
JB
80752011-03-16 Juanma Barranquero <lekktu@gmail.com>
8076
8077 * emacs.c (USAGE3): Doc fixes.
8078
0e48bb22
AS
80792011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8080
8081 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8082 structure.
8083
7684e57b
JB
80842011-03-14 Juanma Barranquero <lekktu@gmail.com>
8085
8086 * lisp.h (VWindow_system, Qfile_name_history):
8087 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8088 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8089 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8090
8091 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8092 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8093
8094 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8095 * w32console.c (detect_input_pending, read_input_pending)
8096 (encode_terminal_code):
8097 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8098 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8099 (w32_system_caret_y, Qfile_name_history):
8100 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8101 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8102 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8103 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8104 * w32proc.c (Qlocal, report_file_error):
8105 * w32term.c (Vwindow_system, updating_frame):
8106 * w32uniscribe.c (initialized, uniscribe_font_driver):
8107 Remove unneeded extern declarations.
8108
2aa46d6c
CY
81092011-03-14 Chong Yidong <cyd@stupidchicken.com>
8110
c96bbc66 8111 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8112
cffc6f3b
CY
81132011-03-13 Chong Yidong <cyd@stupidchicken.com>
8114
8115 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8116 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8117 These macros can no longer be used for assignment.
8118
44f230aa
SM
8119 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8120 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8121 (record_buffer_markers, fetch_buffer_markers): New functions for
8122 recording and fetching special buffer markers.
8123 (set_buffer_internal_1, set_buffer_temp): Use them.
8124
8125 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8126
8127 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8128
8129 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8130 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8131
8132 * xdisp.c (hscroll_window_tree):
8133 (reconsider_clip_changes): Use PT instead of BUF_PT.
8134
d251f04b
EZ
81352011-03-13 Eli Zaretskii <eliz@gnu.org>
8136
8137 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8138 $(EMACS_ROOT)/lib/intprops.h.
8139
f0c77cd1
PE
81402011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8141
3eca4629
PE
8142 Fix more problems found by GCC 4.5.2's static checks.
8143
7c86ee98
PE
8144 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8145 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8146 (xg_free_frame_widgets): Make it clear that a local variable is
8147 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8148 (gdk_window_get_screen): Make it clear that this macro is needed
8149 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8150 (int_gtk_range_get_value): New function, which avoids a diagnostic
8151 from gcc -Wbad-function-cast.
8152 (xg_set_toolkit_scroll_bar_thumb): Use it.
8153 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8154 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8155 (get_utf8_string, xg_get_file_with_chooser):
8156 Rename locals to avoid shadowing.
8157 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8158
41729b81
PE
8159 * xgselect.c (xg_select): Remove unused var.
8160
f0c77cd1
PE
8161 * image.c (four_corners_best): Mark locals as initialized.
8162 (gif_load): Initialize transparent_p to zero (Bug#8238).
8163 Mark another local as initialized.
ec6cf4c6 8164 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8165
ce0ad53d 8166 * image.c (clear_image_cache): Now static.
d5d5a617 8167 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8168 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8169 (x_edge_detection): Remove unnecessary cast that
8170 gcc -Wbad-function-cast diagnoses.
2037898d 8171 (gif_load): Fix pointer signedness.
6ae141d6
PE
8172 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8173 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8174
33383987 81752011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8176
d32df629
PE
8177 Improve quality of tests for time stamp overflow.
8178 For example, without this patch (encode-time 0 0 0 1 1
8179 1152921504606846976) returns the obviously-bogus value (-948597
8180 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8181 reports time overflow. See
8182 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8183 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8184 * editfns.c: Include limits.h and intprops.h.
8185 (TIME_T_MIN, TIME_T_MAX): New macros.
8186 (time_overflow): Move earlier, to before first use.
8187 (hi_time, lo_time): New functions, for an accurate test for
8188 out-of-range times.
8189 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8190 (Fget_internal_run_time): Don't assume time_t fits in int.
8191 (make_time): Use list2 instead of Fcons twice.
8192 (Fdecode_time): More accurate test for out-of-range times.
8193 (check_tm_member): New function.
8194 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8195 (lisp_time_argument): Don't rely on undefined left-shift and
8196 right-shift behavior when checking for time stamp overflow.
8be6f318 8197
fe31d94c
PE
8198 * editfns.c (time_overflow): New function, refactoring common code.
8199 (Fformat_time_string, Fdecode_time, Fencode_time):
8200 (Fcurrent_time_string): Use it.
8201
8be6f318
PE
8202 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8203 * dired.c (make_time): Move to ...
8204 * editfns.c (make_time): ... here.
8205 * systime.h: Note the move.
8206
09d9db2c 82072011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8208
126bc0dc
YM
8209 * fringe.c (update_window_fringes): Remove unused variables.
8210
c47cbdfd
YM
8211 * unexmacosx.c (copy_data_segment): Also copy __got section.
8212 (Bug#8223)
8213
7ac80be9
EZ
82142011-03-12 Eli Zaretskii <eliz@gnu.org>
8215
c96bbc66 8216 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8217 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8218 Constify `char *' arguments and their references according to
8219 prototypes in tparam.h.
8220
ecb0f94d 8221 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8222
7ac80be9
EZ
8223 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8224 Adapt all references accordingly.
8225
8226 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8227
ef1fd07e
TT
82282011-03-11 Tom Tromey <tromey@redhat.com>
8229
8230 * buffer.c (syms_of_buffer): Remove obsolete comment.
8231
7ef4b50c
EZ
82322011-03-11 Eli Zaretskii <eliz@gnu.org>
8233
8234 * termhooks.h (encode_terminal_code): Declare prototype.
8235
8236 * msdos.c (encode_terminal_code): Don't declare prototype.
8237
8238 * term.c (encode_terminal_code): Now external again, used by
8239 w32console.c and msdos.c.
8240
44f230aa
SM
8241 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8242 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8243
4b1ec863 82442011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8245
1714f52b 8246 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8247
4b1ec863
PE
8248 * fringe.c (update_window_fringes): Mark locals as initialized
8249 (Bug#8227).
8250 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8251
524c7aa6
PE
8252 * alloc.c (mark_fringe_data): Move decl from here ...
8253 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8254 to check its interface.
8255 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8256
a5c0af81 8257 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8258 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8259 (fontset_font): Mark local as initialized.
a9a06e0b 8260 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8261
b4716021
PE
8262 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8263
811e9bac 8264 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8265 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8266 (x_own_selection, Fx_disown_selection_internal): Rename locals
8267 to avoid shadowing.
8268 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8269
7e3ab302
PE
8270 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8271 so that the caller can use some name other than gcpro1.
8272 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8273 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8274 (Fx_backspace_delete_keys_p):
8275 Use them to avoid shadowing, and rename vars to avoid shadowing.
8276 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8277 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8278 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8279 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8280 Remove unused locals.
7e3ab302
PE
8281 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8282 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8283 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8284 macros.
f78faa98 8285
e2b13473
PE
8286 * xterm.h (x_mouse_leave): New decl.
8287
77f23912
PE
8288 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8289 Remove unused functions.
cdf4ba58
PE
8290 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8291 (x_calc_absolute_position): Now static.
7411c686 8292 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8293 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8294 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8295 unless they are used.
38d0b34a
PE
8296 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8297 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8298 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8299 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8300 (x_error_catcher, x_connection_closed, x_error_handler):
8301 (x_error_quitter, xembed_send_message, x_iconify_frame):
8302 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8303 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8304 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8305
44f230aa
SM
8306 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8307 Rename or move locals to avoid shadowing.
6b463e58 8308 (tty_defined_color, merge_face_heights): Now static.
5967d051 8309 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8310 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8311 does not deduce is never used uninitialized.
73719eba
PE
8312 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8313 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8314
426994c3 8315 * terminal.c (store_terminal_param): Now static.
5489860b 8316
032f1620 8317 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8318 (set_frame_menubar): Remove unused local.
d4323972 8319 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8320 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8321 since they might point to immutable storage.
281585b0
PE
8322 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8323 since it's unused otherwise.
032f1620 8324
367c19e5 8325 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8326 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8327 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8328 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8329 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8330 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8331 does not deduce are never used uninitialized.
70739cbe 8332
07b48fa9
PE
8333 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8334
8868a238 8335 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8336 * window.c (window_loop, size_window):
8337 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8338
7e5cf297 8339 * window.c (display_buffer): Now static.
d6550a9f
PE
8340 (size_window): Mark variables that gcc -Wuninitialized
8341 does not deduce are never used uninitialized.
a586633d
PE
8342 * window.h (check_all_windows): New decl, to forestall
8343 gcc -Wmissing-prototypes diagnostic.
5b555da1 8344 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8345
f6095868
PE
8346 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8347 shadowing.
8348 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8349 Include <limits.h>.
8350 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8351 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8352 (load_charset_map): Mark variables that gcc -Wuninitialized
8353 does not deduce are never used uninitialized.
53df7c11 8354 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8355
f38b440c
PE
8356 * coding.c (coding_set_source, coding_set_destination):
8357 Use "else { /* comment */ }" rather than "else /* comment */;"
8358 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8359 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8360 a block, when the outer 'i' will do.
8361 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8362 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8363 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8364 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8365 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8366 Rename locals to avoid shadowing.
8367 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8368 * coding.c (emacs_mule_char, encode_invocation_designation):
8369 Now static, since they're not used elsewhere.
413bb2db 8370 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8371 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8372 (decode_coding_emacs_mule): Mark variables that gcc
8373 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8374 (detect_coding_iso_2022): Initialize a local variable that might
8375 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8376 this initialization is needed. (Bug#8211)
5f58e762
PE
8377 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8378 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8379 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8380 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8381 Remove unused macros.
f38b440c 8382
232b38b9 8383 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8384 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8385 * character.c (string_count_byte8): Likewise.
232b38b9 8386
fb90da1b
PE
8387 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8388 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8389
fb93dbc2
PE
8390 * chartab.c (copy_sub_char_table): Now static, since it's not used
8391 elsewhere.
5c156ace
PE
8392 (sub_char_table_ref_and_range, char_table_ref_and_range):
8393 Rename locals to avoid shadowing.
bbcd0949 8394 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8395
7d3b3862 8396 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8397 (BIDI_BOB): Remove unused macro.
7d3b3862 8398
6be7d3da
PE
8399 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8400 deduce are never used uninitialized.
c2ed9c8b 8401 * term.c (encode_terminal_code): Likewise.
6be7d3da 8402
75f8807f 8403 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8404
50938595
PE
8405 * tparam.h: New file.
8406 * term.c, tparam.h: Include it.
8407 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8408 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8409 Move these decls to tparam.h, and make them agree with what
8410 is actually in tparam.c. The previous trick of using incompatible
8411 decls in different modules does not conform to the C standard.
8412 All callers of tparam changed to use tparam's actual API.
8413 * tparam.c (tparam1, tparam, tgoto):
8414 Use const pointers where appropriate.
8415
fbceeba2
PE
8416 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8417 * cm.h (struct cm): Likewise.
8418 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8419 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8420 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8421 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8422 (turn_on_face, init_tty): Likewise.
8423 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8424
7f3f1250
PE
8425 * term.c (term_mouse_position): Rename local to avoid shadowing.
8426
e6ca6543
PE
8427 * alloc.c (mark_ttys): Move decl from here ...
8428 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8429
c40f8d15
AS
84302011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8431
8432 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8433
cfe0661d
JB
84342011-03-09 Juanma Barranquero <lekktu@gmail.com>
8435
8436 * search.c (compile_pattern_1): Remove argument regp, unused since
8437 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8438 (compile_pattern): Don't pass it.
8439
0afb4571
J
84402011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8441
8442 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8443 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8444 for ! HAVE_GTK3.
8445 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8446
8447 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8448
8449 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8450 gdk_window_get_screen, gdk_window_get_geometry,
8451 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8452 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8453 (xg_get_pixbuf_from_pixmap): New function.
8454 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8455 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8456 Call xg_get_pixbuf_from_pixmap instead of
8457 gdk_pixbuf_get_from_drawable.
8458 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8459 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8460 (xg_check_special_colors): Use GtkStyleContext and its functions
8461 for HAVE_GTK3.
8462 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8463 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8464 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8465 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8466 Call gtk_widget_get_preferred_size.
0afb4571
J
8467 (xg_frame_resized): gdk_window_get_geometry only takes 5
8468 parameters.
44f230aa
SM
8469 (xg_win_to_widget, xg_event_is_for_menubar):
8470 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8471 (xg_set_widget_bg): New function.
8472 (delete_cb): New function.
895009e1 8473 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8474 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8475 (xg_set_background_color): Call xg_set_widget_bg.
8476 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8477 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8478 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8479 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8480 if ! HAVE_GTK3.
8481 (update_frame_tool_bar): Call gtk_widget_hide.
8482 (xg_initialize): Use GDK_KEY_g.
8483
8484 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8485 if ! HAVE_GTK3
8486 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8487
8488 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8489 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8490 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8491
1c2cc4ef
JB
84922011-03-08 Juanma Barranquero <lekktu@gmail.com>
8493
8494 * w32xfns.c (select_palette): Check success of RealizePalette against
8495 GDI_ERROR, not zero.
8496
33383987 8497See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8498
8499;; Local Variables:
8500;; coding: utf-8
aac0c6e3
MR
8501;; End:
8502
33383987 8503 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8504
8505 This file is part of GNU Emacs.
8506
8507 GNU Emacs is free software: you can redistribute it and/or modify
8508 it under the terms of the GNU General Public License as published by
8509 the Free Software Foundation, either version 3 of the License, or
8510 (at your option) any later version.
8511
8512 GNU Emacs is distributed in the hope that it will be useful,
8513 but WITHOUT ANY WARRANTY; without even the implied warranty of
8514 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8515 GNU General Public License for more details.
8516
8517 You should have received a copy of the GNU General Public License
8518 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.