lisp/server.el (server-ensure-safe-dir): Simplify.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e5a36063
GM
12012-04-17 Glenn Morris <rgm@gnu.org>
2
3 * dired.c (Fsystem_users): Doc fix.
4
316411f0
DA
52012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
6
7 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
8 (syms_of_dired): Add them.
9
9426aba4
PE
102012-04-16 Paul Eggert <eggert@cs.ucla.edu>
11
b62a57be
PE
12 Fix minor alloc.c problems found by static checking.
13 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
14 New extern decls, to avoid calling undeclared functions.
15 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
16 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
17 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
18 (NEED_MEM_INSERT): New macro.
19 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 20 Remove one incorrect comment and fix another.
b62a57be 21
3539f31f
PE
22 Fix minor ralloc.c problems found by static checking.
23 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
24 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
25 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
26 (r_alloc_sbrk): Now static.
27
a041960a
PE
28 Improve ralloc.c interface checking.
29 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
30 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
31 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
32 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
33 [REL_ALLOC]: ... to here, to check interface.
34 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
35 Remove decls. This fixes an "It stinks!".
36
9426aba4
PE
37 * alloc.c (which_symbols): Fix alignment issue / type clash.
38
d55c12ed
AS
392012-04-15 Andreas Schwab <schwab@linux-m68k.org>
40
41 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
42 (struct Lisp_Misc_Any): Likewise.
43 (struct Lisp_Free): Likewise.
44 * alloc.c (union aligned_Lisp_Symbol): Define.
45 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
46 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
47 (union aligned_Lisp_Misc): Define.
48 (MARKER_BLOCK_SIZE, struct marker_block): Use union
49 aligned_Lisp_Misc instead of union Lisp_Misc.
50 (Fmake_symbol, allocate_misc, gc_sweep): Adjust
51
b948ce8b
PE
522012-04-14 Paul Eggert <eggert@cs.ucla.edu>
53
54 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
55 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
56 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
57 * s/netbsd.h, s/sol2-6.h:
58 Remove definition of GC_MARK_STACK, since the default now works.
59 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
60 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
61 no longer the default.
62 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
63
35dc09a1 642012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 65
35dc09a1
GM
66 * lread.c (lisp_file_lexically_bound_p):
67 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 68
35dc09a1
GM
692012-04-14 Eli Zaretskii <eliz@gnu.org>
70
71 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
72 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
73
742012-04-14 Jan Djärv <jan.h.d@swipnet.se>
75
76 * nsterm.m (constrainFrameRect): Always constrain when there is only
77 one screen (Bug#10962).
78
bcd86815
KB
792012-04-13 Ken Brown <kbrown@cornell.edu>
80
81 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
82
c25df26e
RT
832012-04-13 Reuben Thomas <rrt@sc3d.org>
84
85 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
86
0fc59f1e
DC
872012-04-11 Daniel Colascione <dancol@dancol.org>
88
89 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
90 against is gone. It's better to use vfork now so that when Cygwin
91 gains a new, working vfork, we use it automatically (bug#10398).
92
de8c03dc
SM
932012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
94
95 * window.c (save_window_save): Obey window-point-insertion-type.
96
2f097256
GM
972012-04-11 Glenn Morris <rgm@gnu.org>
98
99 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
100
453b951e
SM
1012012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
102
103 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
104
75f1671a 1052012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
106
107 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
108 (force_quit_count): New var.
109 (handle_interrupt): Use it.
110
2a8ce227
JB
1112012-04-10 Juanma Barranquero <lekktu@gmail.com>
112
113 * w32.c (w32_delayed_load): Record the full path of the library
114 being loaded (bug#10424).
115
935396c0
GM
1162012-04-09 Glenn Morris <rgm@gnu.org>
117
05920a43
GM
118 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
119 not just in the obarray, before snarfing them. (Bug#11036)
120
935396c0
GM
121 * Makefile.in ($(leimdir)/leim-list.el):
122 Pass EMACS rather than BUILT_EMACS.
123
a18ecafa
TZ
1242012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
125
126 * process.c (make_process):
127 * process.h: Add integer `gnutls_handshakes_tried' member to
128 process struct.
129
6bbef4e5
JC
130 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
131 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
132
133 * gnutls.c (gnutls_log_function2i): Convenience log function.
134 (emacs_gnutls_read): Use new log functions,
135 `gnutls_handshakes_tried' process member, and
136 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
137 attempts per process (connection).
138
b4d3bc10
CY
1392012-04-09 Chong Yidong <cyd@gnu.org>
140
141 * eval.c (Fuser_variable_p, user_variable_p_eh)
142 (lisp_indirect_variable): Functions deleted.
143 (Fdefvar): Caller changed.
144
145 * callint.c (Finteractive, Fcall_interactively):
146 * minibuf.c (Fread_variable): Callers changed.
147
70f4d973
EZ
1482012-04-09 Eli Zaretskii <eliz@gnu.org>
149
150 * xdisp.c (set_cursor_from_row): If the display string appears in
151 the buffer at position that is closer to point than the position
152 after the display string, display the cursor on the first glyph of
153 the display string. Fixes cursor display when a 'display' text
154 property immediately follows invisible text. (Bug#11094)
155
cb3c2e3e
PE
1562012-04-09 Paul Eggert <eggert@cs.ucla.edu>
157
158 composite.c: use 'double' consistently
159 * composite.c (get_composition_id): Use 'double' consistently
160 instead of converting 'float' to 'double' and vice versa; this is
161 easier to understand and avoids a GCC warning.
162
fd06db5d
GM
1632012-04-09 Glenn Morris <rgm@gnu.org>
164
50fe702a
GM
165 * Makefile.in: Generate leim-list with bootstrap-emacs, in
166 preparation for dumping it with emacs. (Bug#4789)
167 (leimdir): New variable.
168 ($(leimdir)/leim-list.el): New rule.
169 (emacs$(EXEEXT)): Depend on leim-list.el.
170
fd06db5d
GM
171 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
172 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
173 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
174
55c131ee
AS
1752012-04-08 Andreas Schwab <schwab@linux-m68k.org>
176
177 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
178 proper alignment.
179
9209588f
JB
1802012-04-07 Juanma Barranquero <lekktu@gmail.com>
181
182 * xml.c (init_libxml2_functions) [WINDOWSNT]:
183 Remove unused local variable.
184
e3fb2efb
PE
1852012-04-07 Paul Eggert <eggert@cs.ucla.edu>
186
187 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
188 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
189 (mark_memory): Mark Lisp_Objects only if pointers might hide in
190 objects, as mark_maybe_pointer will catch them otherwise.
191 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
192 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
193
b5385551
PE
1942012-04-07 Paul Eggert <eggert@cs.ucla.edu>
195
196 Fix typo that broke non-Windows builds.
197 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
198
9078ead6
EZ
1992012-04-07 Eli Zaretskii <eliz@gnu.org>
200
201 Support building on MS-Windows with libxml2.
202
203 * makefile.w32-in (OBJ2): Add xml.$(O).
204 (GLOBAL_SOURCES): Add xml.c.
205 ($(BLD)/xml.$(O)): New dependency list.
206
207 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
208 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
209 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
210 [!WINDOWSNT]: New macros.
211 (init_libxml2_functions, libxml2_loaded_p): New functions.
212 (parse_region): Call fn_xmlCheckVersion instead of using the macro
213 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
214 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
215 Calls xmlCleanupParser only if libxml2 was loaded (or statically
216 linked in).
6bbef4e5
JC
217 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
218 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
219 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
220
221 * emacs.c: Don't include libxml/parser.h.
222 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
223 xmlCleanupParser directly.
224
225 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
226
3811fdf3
EZ
2272012-04-07 Eli Zaretskii <eliz@gnu.org>
228
229 * indent.c (Fvertical_motion): If there is a display string at
230 point, use it.vpos to compute how many lines to backtrack after
231 move_it_to point. (Bug#11133)
232
2f8e16b2
EZ
2332012-04-06 Eli Zaretskii <eliz@gnu.org>
234
235 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
236 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
237 about subtle differences between FETCH_CHAR* and STRING_CHAR*
238 macros related to unification of CJK characters. For the details,
239 see the discussion following the message here:
240 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
241
3d439cd1
CY
2422012-04-04 Chong Yidong <cyd@gnu.org>
243
244 * keyboard.c (Vdelayed_warnings_list): Doc fix.
245
8bc53d00
EZ
2462012-04-01 Eli Zaretskii <eliz@gnu.org>
247
248 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
249 instead of alloca. (Bug#11138)
250
3b0512a3
AS
2512012-04-01 Andreas Schwab <schwab@linux-m68k.org>
252
253 * w32menu.c (is_simple_dialog): Properly check lisp types.
254 (Bug#11141)
255
8427ddd2
EZ
2562012-03-31 Eli Zaretskii <eliz@gnu.org>
257
979022ef
EZ
258 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
259 position we get to after a call to move_it_to fails the
260 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
261 only if we wind up in a string from display property. (Bug#11063)
262
a6b1c7cc
EZ
263 * window.c (Fdelete_other_windows_internal): Invalidate the row
264 and column information about mouse highlight, so that redisplay
265 restores it after reallocating the glyph matrices. (Bug#7464)
266
8427ddd2
EZ
267 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
268 string comes from a `display' text property, use the buffer
269 position of that property as if we actually saw that position in
270 the row's glyphs.
697ba24b
EZ
271 (move_it_by_lines): Remove the assertion that
272 "it->current_x == 0 && it->hpos == 0" which can be legitimately
273 violated when there's a before-string at the beginning of a line.
274 (Bug#11063)
8427ddd2 275
65a0a738
EZ
2762012-03-30 Eli Zaretskii <eliz@gnu.org>
277
278 * xdisp.c (append_space_for_newline): If the default face was
279 remapped, use the remapped face for the appended newline.
280 (extend_face_to_end_of_line): Use the remapped default face for
281 extending the face to the end of the line.
282 (display_line): Call extend_face_to_end_of_line when the default
283 face was remapped. (Bug#11068)
284
581355cc
EZ
2852012-03-29 Eli Zaretskii <eliz@gnu.org>
286
287 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
288
e8fc049f
SM
2892012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
290
291 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
292
4fb9a543
GM
2932012-03-27 Glenn Morris <rgm@gnu.org>
294
295 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
296 Doc fixes.
297
679910f1
KH
2982012-03-26 Kenichi Handa <handa@m17n.org>
299
300 * dispextern.h (struct glyph): Fix previous change. Change the
301 bit length of glyphless.ch to 25 (Bug#11082).
302
90d49b7f
CY
3032012-03-26 Chong Yidong <cyd@gnu.org>
304
305 * keyboard.c (Vselection_inhibit_update_commands): New variable.
306 (command_loop_1): Use it; inhibit selection update for
307 handle-select-window too (Bug#8996).
308
f514f6f0
FP
3092012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
310
e8fc049f 311 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 312
bf43fa51
KH
3132012-03-25 Kenichi Handa <handa@m17n.org>
314
315 * dispextern.h (struct glyph): Change the bit length of
316 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
317
8a0c01dd
EZ
3182012-03-24 Eli Zaretskii <eliz@gnu.org>
319
320 * s/ms-w32.h (tzname): Include time.h before redirecting to
321 _tzname. Fixes the MSVC build. (Bug#9960)
322
7d1c3a76
AS
3232012-03-24 Andreas Schwab <schwab@linux-m68k.org>
324
8ed79523
AS
325 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
326 characters.
327
7d1c3a76
AS
328 * xterm.c (XTread_socket): Only modify handling_signal if
329 !SYNC_INPUT. (Bug#11080)
330
e99a9b8b
EZ
3312012-03-23 Eli Zaretskii <eliz@gnu.org>
332
333 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
334 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
335 when fetching a multibyte character consumes more bytes than
336 CHAR_BYTES returns, due to unification of CJK characters in
337 string_char. (Bug#11073)
338
5063c0e1
TN
3392012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
340
341 * process.c (wait_reading_process_output): Handle pty disconnect
342 by refraining from sending oneself a SIGCHLD (bug#10933).
343
9f851fbd
CY
3442012-03-22 Chong Yidong <cyd@gnu.org>
345
346 * dispextern.h (struct it): New member string_from_prefix_prop_p.
347
5063c0e1 348 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
349 Mark string as coming from a prefix property.
350 (handle_face_prop): Use default face for prefix strings (Bug#4281).
351 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
352
fb5b8aca
CY
3532012-03-21 Chong Yidong <cyd@gnu.org>
354
355 * xfaces.c (Vface_remapping_alist): Doc fix.
356
62356a1b
EZ
3572012-03-20 Eli Zaretskii <eliz@gnu.org>
358
359 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
360 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
361 Doc fixes.
62356a1b 362
025de85b
CY
3632012-03-20 Chong Yidong <cyd@gnu.org>
364
365 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
366 to reflect default non-nil value of redisplay-dont-pause.
367
4827f94e
KH
3682012-03-19 Kenichi Handa <handa@m17n.org>
369
370 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
371 it fit in a valid range (Bug#11003).
372
e50a24a2
EZ
3732012-03-18 Eli Zaretskii <eliz@gnu.org>
374
375 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
376 that is not from display property, accept the row as a "cursor
377 row" if one of the string's character has a non-nil `cursor'
378 property. Fixes cursor positioning when there are newlines in
379 overlay strings, e.g. in icomplete.el. (Bug#11035)
380
9af5ed87
PE
3812012-03-12 Paul Eggert <eggert@cs.ucla.edu>
382
383 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
384
d1f55f16
CY
3852012-03-12 Chong Yidong <cyd@gnu.org>
386
387 * eval.c (inhibit_lisp_code): Rename from
388 inhibit_window_configuration_change_hook; move from window.c.
389
390 * xfns.c (unwind_create_frame_1, Fx_create_frame):
391 * window.c (run_window_configuration_change_hook)
392 (syms_of_window): Callers changed.
393
66c5eebd
CY
3942012-03-11 Chong Yidong <cyd@gnu.org>
395
413df973
CY
396 * keymap.c (Fkey_description): Doc fix (Bug#9700).
397
66c5eebd
CY
398 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
399
1de11f56
CY
4002012-03-10 Chong Yidong <cyd@gnu.org>
401
402 * frame.c (other_visible_frames): Don't assume the selected frame
403 is visible (Bug#10955).
404
cae07000
SM
4052012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
406
407 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
408
89c94350
JD
4092012-03-08 Jan Djärv <jan.h.d@swipnet.se>
410
411 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
412 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
413 zero (Bug#10954).
414
999dd333
GM
4152012-03-03 Glenn Morris <rgm@gnu.org>
416
01a6dcc8 417 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 418
de0100f2
EZ
4192012-03-02 Eli Zaretskii <eliz@gnu.org>
420
421 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
422 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
423 (redisplay_window, next_element_from_string): Fix typos in
424 comments.
3e441275
EZ
425 (redisplay_window): Pass to move_it_vertically the margin in
426 pixels, not in screen lines.
de0100f2 427
96a72ee9
GM
4282012-03-02 Glenn Morris <rgm@gnu.org>
429
430 * buffer.c (buffer-list-update-hook): Doc fix.
431
312508d7
EZ
4322012-02-29 Eli Zaretskii <eliz@gnu.org>
433
434 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
435 push_it before setting up the iterator for the first overlay
436 string, even if we have an empty string loaded.
437 (next_overlay_string): If there's an empty string on the iterator
438 stack, pop the stack. (Bug#10903)
439
27f3c637
PE
4402012-02-25 Paul Eggert <eggert@cs.ucla.edu>
441
442 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
443 Suggested by Stefan Monnier in
444 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
445 * alloc.c (widen_to_Lisp_Object): New static function.
446 (mark_memory): Also mark Lisp_Objects by fetching pointer words
447 and widening them to Lisp_Objects. This would work even if
448 USE_LSB_TAG is defined and wide integers are used, which might
449 happen in a future version of Emacs.
450
3c9dfce6
CY
4512012-02-25 Chong Yidong <cyd@gnu.org>
452
fa74b241
CY
453 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
454 Doc fix.
455
3c9dfce6
CY
456 * xselect.c (Fx_selection_exists_p): Doc fix.
457 (x_clipboard_manager_save_all): Print an informative message
458 before saving to clipboard manager.
459
9486df08
CY
4602012-02-24 Chong Yidong <cyd@gnu.org>
461
462 * keyboard.c (process_special_events): Handle all X selection
463 requests in kbd_buffer, not just the next one (Bug#8869).
464
f01d3321
CY
4652012-02-23 Chong Yidong <cyd@gnu.org>
466
467 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
468 call when setting menu-bar-lines and tool-bar-lines parameters.
469 (unwind_create_frame_1): New helper function.
470
471 * window.c (inhibit_window_configuration_change_hook): New var.
472 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 473 (syms_of_window): Initialize it.
f01d3321 474
86b847b6
CY
4752012-02-22 Chong Yidong <cyd@gnu.org>
476
477 * xterm.c (x_draw_image_relief): Add missing type check for
478 Vtool_bar_button_margin (Bug#10743).
479
a59225b1
CY
4802012-02-21 Chong Yidong <cyd@gnu.org>
481
482 * fileio.c (Vfile_name_handler_alist): Doc fix.
483
484 * buffer.c (Fget_file_buffer): Protect against invalid file
485 handler return value.
486
310f5bd4
PE
4872012-02-20 Paul Eggert <eggert@cs.ucla.edu>
488
cb3a28cc
PE
489 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
490 when computing $valmask.
491
310f5bd4
PE
492 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
493 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
494 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
495 It's useless in that case, and it can cause problems on hosts
496 that allocate halves of EMACS_INT values separately.
497 Reported by Dan Horák. Diagnosed by Andreas Schwab in
498 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
499 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
500 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
501 it avoids undefined behavior on hosts where shifting right by more
502 than the word width has undefined behavior.
503
2375c96a
CY
5042012-02-19 Chong Yidong <cyd@gnu.org>
505
506 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
507 (Funhandled_file_name_directory, Ffile_name_as_directory)
508 (Fdirectory_file_name, Fexpand_file_name)
509 (Fsubstitute_in_file_name): Protect against invalid file handler
510 return values (Bug#10845).
511
3eb49e71
EZ
5122012-02-18 Eli Zaretskii <eliz@gnu.org>
513
514 * .gdbinit (pitx): Fix incorrect references to fields of the
515 iterator stack.
516
7b926f3f
CY
5172012-02-17 Chong Yidong <cyd@gnu.org>
518
519 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
520
11273115
PE
5212012-02-15 Paul Eggert <eggert@cs.ucla.edu>
522
523 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
524 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
525
c3a70e2b
CY
5262012-02-15 Chong Yidong <cyd@gnu.org>
527
528 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
529 marked as special. Also, starting docstrings with * is obsolete.
530
0ca43699
AS
5312012-02-13 Andreas Schwab <schwab@linux-m68k.org>
532
533 * gnutls.c (emacs_gnutls_write): Fix last change.
534
2e8f3c56
LI
5352012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
536
537 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
538 send_process.
539
af70074f
SM
5402012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
541
542 * keymap.c (Fsingle_key_description): Handle char ranges.
543
95986d52
CY
5442012-02-12 Chong Yidong <cyd@gnu.org>
545
afd83bd1
CY
546 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
547 as that creates a dangerous corner case.
548
95986d52
CY
549 * window.c (Fdelete_window_internal): Invalidate the mouse
550 highlight (Bug#9904).
551
bd7da63e
GM
5522012-02-12 Glenn Morris <rgm@gnu.org>
553
554 * xselect.c (Fx_own_selection_internal)
555 (Fx_get_selection_internal, Fx_disown_selection_internal)
556 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
557 * nsselect.m (Fx_own_selection_internal)
558 (Fx_disown_selection_internal, Fx_selection_exists_p)
559 (Fx_selection_owner_p, Fx_get_selection_internal):
560 Sync docs and argument specs with the xselect.c versions.
561
77abcbc2
LI
5622012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
563
564 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
565
90b671e2
EZ
5662012-02-11 Eli Zaretskii <eliz@gnu.org>
567
1c0ca0b7
EZ
568 * w32select.c (Fx_selection_exists_p): Sync doc string and
569 argument list with xselect.c. (Bug#10783)
570
571 * w16select.c (Fx_selection_exists_p): Sync doc string and
572 argument list with xselect.c. (Bug#10783)
90b671e2 573
49241268
GM
5742012-02-10 Glenn Morris <rgm@gnu.org>
575
576 * fns.c (Fsecure_hash): Doc fix.
577
f998bbe7 5782012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
579
580 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
581
0992bd9c
CY
5822012-02-07 Chong Yidong <cyd@gnu.org>
583
584 * buffer.c (Fbuffer_local_variables)
585 (buffer_lisp_local_variables): Handle unbound vars correctly;
586 don't let Qunbound leak into Lisp.
587
af008560
GM
5882012-02-07 Glenn Morris <rgm@gnu.org>
589
dd605cc4
GM
590 * image.c (Fimagemagick_types): Doc fix.
591
af008560
GM
592 * image.c (imagemagick-render-type): Change it from a lisp object
593 to an integer. Move the doc here from the lisp manual.
594 Treat all values not equal to 0 the same.
595
1449fa1d
CY
5962012-02-06 Chong Yidong <cyd@gnu.org>
597
598 * doc.c (store_function_docstring): Avoid applying docstring of
599 alias to base function (Bug#2603).
600
3723ec07
AS
6012012-02-04 Andreas Schwab <schwab@linux-m68k.org>
602
603 * .gdbinit (pp1, pv1): Remove redundant defines.
604 (pr): Use pp.
605
79c1cc1e
CY
6062012-02-04 Chong Yidong <cyd@gnu.org>
607
608 * nsterm.m: Declare a global (Bug#10694).
609
d7f29f8e
EZ
6102012-02-04 Eli Zaretskii <eliz@gnu.org>
611
cae07000
SM
612 * w32.c (get_emacs_configuration_options):
613 Include --enable-checking, if specified, in the return value.
d7f29f8e 614
3b95a6f9
MR
6152012-02-04 Martin Rudalics <rudalics@gmx.at>
616
617 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
618 after rounding frame sizes. (Bug#9723)
619
d6fa96a6
EZ
6202012-02-04 Eli Zaretskii <eliz@gnu.org>
621
622 * keyboard.c (adjust_point_for_property): Don't position point
623 before BEGV. (Bug#10696)
624
df0b2940
PE
6252012-02-03 Paul Eggert <eggert@cs.ucla.edu>
626
627 Handle overflow when computing char display width (Bug#9496).
628 * character.c (char_width): Return EMACS_INT, not int.
629 (char_width, c_string_width): Check for overflow when
630 computing the width; this is possible now that individual
631 characters can have unbounded width. Problem introduced
632 by merge from Emacs 23 on 2012-01-19.
633
6bee44d6
MA
6342012-02-02 Michael Albinus <michael.albinus@gmx.de>
635
636 * dbusbind.c (Fdbus_register_method): Mention the return value
637 :ignore in the docstring.
638
44f92739
GM
6392012-02-02 Glenn Morris <rgm@gnu.org>
640
1b9f60cc
GM
641 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
642
44f92739
GM
643 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
644 Unconditionally set to t. (Bug#10673)
645 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
646 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
647 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
648
c5d3843c
KH
6492012-02-02 Kenichi Handa <handa@m17n.org>
650
651 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
652 0, do not call append_composite_glyph.
653
159462d4 6542012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
655
656 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
657 NULL (Bug#6988).
658 (x_produce_glyphs): If the component of a composition is a null
659 string, set it->pixel_width to 1 to avoid zero-width glyph.
660
78cef877
EZ
6612012-02-01 Eli Zaretskii <eliz@gnu.org>
662
663 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
664 first 2 arguments are identical. This makes inserting large
665 output from a subprocess an order of magnitude faster on
666 MS-Windows, where all sbrk'ed memory is always contiguous.
667
97897668
GM
6682012-01-31 Glenn Morris <rgm@gnu.org>
669
670 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 671 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
672 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
673
31fd3586
GM
6742012-01-29 Glenn Morris <rgm@gnu.org>
675
676 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
677
0e24a8b2
CY
6782012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
679
680 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
681
cc0adcb0
CY
6822012-01-28 Chong Yidong <cyd@gnu.org>
683
684 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
685
acc28cb9
CY
6862012-01-26 Chong Yidong <cyd@gnu.org>
687
9c69cfb7
CY
688 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
689
acc28cb9
CY
690 * search.c (Fsearch_forward, Fsearch_backward): Document negative
691 repeat counts (Bug#10507).
692
48da7392
GM
6932012-01-26 Glenn Morris <rgm@gnu.org>
694
695 * lread.c (syms_of_lread): Doc fix.
696
14af5f7f
CY
6972012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
698
699 * coding.c (encode_designation_at_bol): Change return value to
700 EMACS_INT.
701
0b21c100
CY
7022012-01-25 Chong Yidong <cyd@gnu.org>
703
704 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
705
3c2907f7
CY
7062012-01-21 Chong Yidong <cyd@gnu.org>
707
708 * floatfns.c (Fcopysign): Make the second argument non-optional,
709 since nil is not allowed anyway.
710
959ad23f
AS
7112012-01-21 Andreas Schwab <schwab@linux-m68k.org>
712
713 * process.c (read_process_output): Use p instead of XPROCESS (proc).
714 (send_process): Likewise.
715
34a02f46
MR
7162012-01-19 Martin Rudalics <rudalics@gmx.at>
717
718 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
719 (Vwindow_persistent_parameters): Do not use Qstate.
720 Rewrite doc-strings.
34a02f46 721
1259009a 7222012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
723
724 * character.c (char_width): New function.
70d4fdf6
GM
725 (Fchar_width, c_string_width, lisp_string_width):
726 Use char_width (Bug#9496).
25ed9e61 727
6a6ee00d
MR
7282012-01-16 Martin Rudalics <rudalics@gmx.at>
729
730 * window.c (Vwindow_persistent_parameters): New variable.
731 (Fset_window_configuration, save_window_save): Handle persistent
732 window parameters.
733
c85efaf7
EZ
7342012-01-14 Eli Zaretskii <eliz@gnu.org>
735
736 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
737 thrashing the stack of the thread. (Bug#9087)
738
5944709e
PE
7392012-01-12 Paul Eggert <eggert@cs.ucla.edu>
740
741 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
742
e71f5d99
EZ
7432012-01-11 Eli Zaretskii <eliz@gnu.org>
744
745 * xdisp.c (rows_from_pos_range): Handle the case where the
746 highlight ends on a newline. (Bug#10464)
747 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
748 he end column for display of highlight that ends on a newline
749 before a R2L line.
750
ce316182
GM
7512012-01-11 Glenn Morris <rgm@gnu.org>
752
753 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
754 from load-path also when installation-directory is nil. (Bug#10208)
755
5b43da69
GM
7562012-01-10 Glenn Morris <rgm@gnu.org>
757
74cc8ff9
GM
758 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
759
7d8d6e4e
GM
760 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
761 Update template values to be closer to their typical values these days.
5b43da69 762
a0db8d43
EZ
7632012-01-09 Eli Zaretskii <eliz@gnu.org>
764
765 * xdisp.c (rows_from_pos_range): Accept additional argument
766 DISP_STRING, and accept any glyph in a row whose object is that
767 string as eligible for mouse highlight. Fixes mouse highlight of
768 display strings from overlays. (Bug#10464)
769
9a0115ab 7702012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 771
b9110d6a 772 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
773 * fileio.c (auto_saving_dir_umask): New static var.
774 (Fmake_directory_internal): Use it.
775 (do_auto_save_make_dir): Set it, instead of invoking chmod after
776 creating the directory. The old code temporarily assigns
777 too-generous permissions to the directory.
778 (do_auto_save_eh): Clear it.
b9110d6a 779 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
780 that the var is always cleared.
781
6c1bd3f3
EZ
7822012-01-07 Eli Zaretskii <eliz@gnu.org>
783
784 * search.c (scan_buffer): Pass character positions to
785 know_region_cache, not byte positions. (Bug#6540)
786
069d2b50
L
7872012-01-07 LynX <_LynX@bk.ru> (tiny change)
788
789 * w32.c (sys_rename): Report EXDEV when rename of a directory
790 fails because the target is on another logical disk. (Bug#10284)
791
75bf0d33
DB
7922012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
793
794 * xterm.c (x_embed_request_focus): New function.
795
796 * xterm.h: Add prototype.
797
798 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
799
1c6e5a32
GM
8002012-01-05 Glenn Morris <rgm@gnu.org>
801
802 * emacs.c (emacs_copyright): Update short copyright year to 2012.
803
651e947e
EZ
8042012-01-01 Eli Zaretskii <eliz@gnu.org>
805
806 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
807 Load gnutls_transport_set_lowat only if GnuTLS version is below
808 2.11.1.
809 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
810 GnuTLS versions below 2.11.1.
811
3778cdd8
AL
8122011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
813
814 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
815 to the doc string advising against its use for altering the way
816 windows are scrolled.
817
0e5317f7
KH
8182011-12-28 Kenichi Handa <handa@m17n.org>
819
820 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
821 coding-system ASCII compatible only when it does not produce BOM
822 on encoding (Bug#10383).
823
93d5ca1f
JD
8242011-12-26 Jan Djärv <jan.h.d@swipnet.se>
825
826 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
827 can scroll.
828 (create_and_show_popup_menu): Always use menu_position_func for
829 Gtk3 (Bug#10361).
830
ca22b785
AS
8312011-12-24 Andreas Schwab <schwab@linux-m68k.org>
832
833 * callint.c (Fcall_interactively): Don't truncate prompt string.
834
d048e1e6
EZ
8352011-12-23 Eli Zaretskii <eliz@gnu.org>
836
837 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
838 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 839 resumed from there (after widening). (Bug#10360)
d048e1e6 840
5ccaba1f
JD
8412011-12-22 Jan Djärv <jan.h.d@swipnet.se>
842
843 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
844
204ee57f
JD
8452011-12-21 Jan Djärv <jan.h.d@swipnet.se>
846
b81d40f0
JB
847 * nsterm.m (x_free_frame_resources):
848 Release f->output_data.ns->miniimage.
204ee57f
JD
849 (ns_index_color): Fix indentation. Do not retain
850 color_table->colors[i].
851
852 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
853 before returning.
854
855 * nsfns.m (x_set_background_color): Assign return value from
856 ns_index_color to face-background instead of NSColor*.
857 (ns_implicitly_set_icon_type): Fix indentation.
858 Change assignment in for loop to comparison.
859
860 * emacs.c (ns_pool): New variable.
861 (main): Assign ns_pool.
862 (Fkill_emacs): Call ns_release_autorelease_pool.
863
864 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
865 autorelease fdesc, release fdAttrs and tdict.
866 (ns_get_covering_families): Release charset.
867 (ns_findfonts): Release NSFontDescriptor created with new.
868 (ns_uni_to_glyphs): Fix indentation.
869 (setString): Release attrStr before assigning new value.
870
c803b2b7
JD
8712011-12-18 Jan Djärv <jan.h.d@swipnet.se>
872
678f4426
JD
873 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
874 and NS_IMPL_COCOA.
875 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
876 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
877
cd394be1 8782011-12-18 David Reitter <reitter@cmu.edu>
678f4426 879
5fecd5fc
JD
880 * nsterm.m (ns_term_init): Subscribe for notifications
881 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
882 to method trackingNotification in EmacsMenu.
883
884 * nsmenu.m (trackingMenu): New variable.
3771cb17 885 (trackingNotification): New method (from Aquamacs).
5fecd5fc 886 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 887 from Aquamacs (Bug#7030).
678f4426
JD
888
8892011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 890
c803b2b7
JD
891 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
892 (symbol_to_nsstring): Fix indentation.
893 (ns_symbol_to_pb): New function.
cae07000
SM
894 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
895 (Fns_rotate_cut_buffers_internal): Remove.
896 (Fns_store_selection_internal): Rename from
c803b2b7
JD
897 Fns_store_cut_buffer_internal.
898 (ns_get_foreign_selection, Fx_own_selection_internal)
899 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
900 (Fns_get_selection_internal, Fns_store_selection_internal):
901 Use ns_symbol_to_pb and check if return value is nil.
902 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
903 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
904 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
905 renamed to Sns_store_selection_internal.
906 (ns_handle_selection_request): Move code to Fx_own_selection_internal
907 and remove this function.
908 (ns_handle_selection_clear): Remove, never used.
909 (Fx_own_selection_internal): Move code from ns_handle_selection_request
910 here.
911
e1b01a3a
KB
9122011-12-17 Ken Brown <kbrown@cornell.edu>
913
914 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
915 GID is unknown (Bug#10257).
916
2adb6e85
PE
9172011-12-17 Paul Eggert <eggert@cs.ucla.edu>
918
919 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
920 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
921 which caused a build failure on GNU/Linux IA-64. This problem was
922 introduced by my 2011-10-07 patch.
923
d1d7b339
JL
9242011-12-15 Juri Linkov <juri@jurta.org>
925
926 * image.c (imagemagick_error): New function. (Bug#10112)
927 (imagemagick_load_image): Comment out `MagickSetResolution' call.
928 Use `imagemagick_error' where ImageMagick functions return
929 `MagickFalse'.
930 (Fimagemagick_types): Add `Fnreverse' to return the list in the
931 proper order.
932
100d5755
KH
9332011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
934
935 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
936 fill background (Bug#8992).
937
454592a6
MR
9382011-12-13 Martin Rudalics <rudalics@gmx.at>
939
940 * window.c (Vwindow_combination_resize)
941 (Vwindow_combination_limit): Use t instead of non-nil in
942 doc-strings.
61d4b438
MR
943 (Vrecenter_redisplay): Add first sentence of doc-string on
944 separate line.
53524d93 945 (Frecenter): Fix doc-string typo.
454592a6 946
3633e3aa
KH
9472011-12-11 Kenichi Handa <handa@m17n.org>
948
949 * coding.c (Funencodable_char_position): Pay attention to the
950 buffer text relocation (Bug#9389).
951
7b9d523a
JD
9522011-12-10 Jan Djärv <jan.h.d@swipnet.se>
953
954 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
955 gtk_init (Bug#10100).
956
b73189c6
EZ
9572011-12-10 Eli Zaretskii <eliz@gnu.org>
958
959 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
960 IT->string is nil. (Bug#10263)
961
f7dfe5d6
JD
9622011-12-10 Jan Djärv <jan.h.d@swipnet.se>
963
83faebb4
JD
964 * nsterm.h (x_free_frame_resources): Declare.
965
f7dfe5d6
JD
966 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
967 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
968
969 * nsterm.h (ns_get_defaults_value): Declare.
970
971 * nsterm.m (ns_default): Call ns_get_defaults_value.
972
7cd4e72c
EZ
9732011-12-09 Eli Zaretskii <eliz@gnu.org>
974
975 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
976 (Bug#10170)
977
b34d7317
YM
9782011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
979
980 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
981 that where the value of an _OBJC_* symbol points to is in the .bss
982 section (Bug#10240).
983
76470ad1
KH
9842011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
985
986 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 987 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 988
745fff94
KH
9892011-12-08 Kenichi Handa <handa@m17n.org>
990
991 * ftfont.c (get_adstyle_property): Fix previous change
992 (Bug#10233).
993
6e44397c
JB
9942011-12-07 Juanma Barranquero <lekktu@gmail.com>
995
996 * w32.c (init_environment): If no_site_lisp, remove site-lisp
997 dirs from the default value of EMACSLOADPATH (bug#10208).
998
7efa6272
GM
9992011-12-07 Glenn Morris <rgm@gnu.org>
1000
1001 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1002 installation and source directories as well. (Bug#10208)
1003
f6fc4d87
CY
10042011-12-06 Chong Yidong <cyd@gnu.org>
1005
1006 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1007
2bf26180
GM
10082011-12-06 Glenn Morris <rgm@gnu.org>
1009
1010 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1011 as an error, not just -1. (Bug#10217)
1012
3a6ad4f0
CY
10132011-12-05 Chong Yidong <cyd@gnu.org>
1014
1015 * keyboard.c (process_special_events): New function.
1016 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1017
75a3b399
PE
10182011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1019
1020 * coding.c (encode_designation_at_bol): Don't use uninitialized
1021 local variable (Bug#9318).
1022
c3c9e25e
KH
10232011-12-05 Kenichi Handa <handa@m17n.org>
1024
1025 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1026 return Qnil (Bug#8046, Bug#10193).
1027
5eb05ea3
KH
10282011-12-05 Kenichi Handa <handa@m17n.org>
1029
1030 * coding.c (encode_designation_at_bol): New args charbuf_end and
1031 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1032 (coding_set_source): Return how many bytes coding->source was
1033 relocated.
1034 (coding_set_destination): Return how many bytes
1035 coding->destination was relocated.
1036 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1037 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1038
10392011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1040
1041 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1042 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1043 macro (Bug#9318).
1044
10452011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1046
1047 The following changes are to fix Bug#9318.
1048
a79703f5 1049 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1050 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1051 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1052 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1053
7dbda6df
JB
10542011-12-05 Juanma Barranquero <lekktu@gmail.com>
1055
1056 * lisp.h (process_quit_flag): Fix external declaration.
1057
6d5eb5b0
SM
10582011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1059
1060 Don't macro-inline non-performance-critical code.
1061 * eval.c (process_quit_flag): New function.
1062 * lisp.h (QUIT): Use it.
1063
a0c3fad0
JD
10642011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1065
1066 * nsfns.m (get_geometry_from_preferences): New function.
1067 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1068
6c07aac2
AS
10692011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1070
1071 * emacs.c (Qkill_emacs): Define.
1072 (syms_of_emacs): Initialize it.
1073 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1074 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1075 (quit_throw_to_read_char): Add parameter `from_signal'.
1076 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1077 * lisp.h (QUIT): Call Fkill_emacs if requested.
1078
c052ead4
JD
10792011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1080
1081 * widget.c (update_wm_hints): Return if wmshell is null.
1082 (widget_update_wm_size_hints): New function.
1083
1084 * widget.h (widget_update_wm_size_hints): Declare.
1085
1086 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1087 widget_update_wm_size_hints (Bug#10104).
1088
9e49252b
EZ
10892011-12-03 Eli Zaretskii <eliz@gnu.org>
1090
1091 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1092 before a newline, prepare the bidi iterator for consuming the
1093 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1094 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1095
02b16839
JL
10962011-12-02 Juri Linkov <juri@jurta.org>
1097
1098 * search.c (Fword_search_regexp): New Lisp function created from
1099 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1100 (Fword_search_backward, Fword_search_forward)
1101 (Fword_search_backward_lax, Fword_search_forward_lax):
1102 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1103 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1104
0068070e
SM
11052011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1106
1107 * fileio.c (Finsert_file_contents): Move after-change-function call
1108 to before the "handled:" label, since all "goto handled" appear in
1109 cases where the *-change-functions have already been properly called
1110 (bug#10117).
1111
3360a3fc
AS
11122011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1113
1114 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1115 waiting for input. (Bug#10169)
1116
73d6c093
EZ
11172011-11-30 Eli Zaretskii <eliz@gnu.org>
1118
1119 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1120 verifies glyph row's hash code--we have just reallocated the
1121 glyphs, so their contents can be complete garbage. (Bug#10164)
1122
febe6bea
JB
11232011-11-30 Juanma Barranquero <lekktu@gmail.com>
1124
1125 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1126
801a4313
EZ
11272011-11-30 Eli Zaretskii <eliz@gnu.org>
1128
1129 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1130 attributes are tested _before_ calling verify_row_hash, to protect
1131 against GCC re-ordering of the tests. (Bug#10164)
1132
2b56b87e
JD
11332011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1134
1135 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1136
1137 * xterm.c (handle_one_xevent): Only set async_visible and friends
1138 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1139 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1140 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1141
dbf31225
PE
11422011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1143
1144 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1145 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1146 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1147 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1148 All uses changed to use GCPRO1 etc.
1149 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1150 Revert to old implementation (i.e., before 2011-03-11).
1151
1305621b
YM
11522011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1153
1154 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1155 of scroll runs so as to avoid assigning disabled bogus rows and
1156 unnecessary graphics copy operations.
1157
8c9afb46
EZ
11582011-11-27 Eli Zaretskii <eliz@gnu.org>
1159
1160 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1161 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1162 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1163 (malloc, free, realloc, calloc): Redirect to e_* only when
1164 compiling Emacs.
1165
1166 * lisp.h (GCTYPEBITS): Move before first use.
1167 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1168 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1169 this macro definition.
1170
1171 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1172 _MSC_VER.
1173
54e9e3bf
JD
11742011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1175
6d5eb5b0
SM
1176 * gtkutil.c (xg_create_frame_widgets):
1177 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1178 present with Gtk+ 2.0.
1179
83aca1cb
PE
11802011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1181
1182 * fileio.c (Finsert_file_contents): Undo previous change; see
1183 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1184
5b76caa4
PE
11852011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1186
1187 Rename locals to avoid shadowing.
1188 * fileio.c (Finsert_file_contents):
1189 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1190 * process.c (wait_reading_process_output):
1191 Rename inner 'proc' to 'p' to avoid shadowing.
1192 Indent for consistency with usual Emacs style.
1193
8c535114
EZ
11942011-11-25 Eli Zaretskii <eliz@gnu.org>
1195
1196 * xdisp.c (redisplay_window): If cursor row is not fully visible
1197 after recentering, and scroll-conservatively is set to a large
1198 number, scroll window by a few more lines to make the cursor fully
1199 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1200 (start_display): Don't move to the next line if the display should
1201 start at a newline that is part of a display vector or an overlay
1202 string. (Bug#10119)
8c535114 1203
fa4fdb5c
JL
12042011-11-24 Juri Linkov <juri@jurta.org>
1205
1206 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1207 after the `MagickPingImage' call. (Bug#10112)
1208
90ec88df
CY
12092011-11-23 Chong Yidong <cyd@gnu.org>
1210
1211 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1212
56e2e794
MR
12132011-11-23 Martin Rudalics <rudalics@gmx.at>
1214
1215 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1216 making another buffer current. (Bug#10114)
1217
b6e64c41
GM
12182011-11-23 Glenn Morris <rgm@gnu.org>
1219
1220 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1221
6b21de18
CY
12222011-11-23 Chong Yidong <cyd@gnu.org>
1223
1224 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1225 using it (Bug#5984).
1226
b12cd789
EZ
12272011-11-22 Eli Zaretskii <eliz@gnu.org>
1228
1229 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1230 and header-lines, as they don't have one computed for them.
1231 (Bug#10098)
1232
1233 * .gdbinit (prow): Make displayed values more self-explaining.
1234 Add row's hash code.
1235
261b6fd4
LMI
12362011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1237
1238 * process.c (wait_reading_process_output): Fix asynchrounous
1239 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1240 (wait_reading_process_output): Add comment and URL.
261b6fd4 1241
e7cfd277
JD
12422011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1243
1244 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1245
a9b9b7f5
CY
12462011-11-21 Chong Yidong <cyd@gnu.org>
1247
1248 * window.c (Fnext_window, Fprevious_window): Doc fix.
1249
b0d15b4f
SM
12502011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1251
1252 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1253
fe7a3057
JB
12542011-11-20 Juanma Barranquero <lekktu@gmail.com>
1255
1256 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1257
d2999b1a
MR
12582011-11-20 Martin Rudalics <rudalics@gmx.at>
1259
1260 * window.c (Fset_window_combination_limit): Rename argument
1261 STATUS to LIMIT.
1262 (Vwindow_combination_limit): Remove "status" from doc-string.
1263
d5ff9cd0
AS
12642011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1265
1266 * m/ibms390.h: Remove.
1267 * m/ibms390x.h: Don't include "ibms390.h".
1268
a5bb9bd3
SM
12692011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1270
1271 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1272 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1273
cd1181db
JB
12742011-11-20 Juanma Barranquero <lekktu@gmail.com>
1275
1276 * casetab.c (Fset_case_table):
1277 * charset.c (Fcharset_after): Fix typos.
1278
615a3b8d 12792011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1280
17e845af
PE
1281 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1282 Otherwise, valgrind does not work on some platforms.
1283 Problem reported by Andreas Schwab in
6a0bf43d
PE
1284 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1285 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1286 is set, removing the need for VIRT_ADDRESS_VARIES.
1287 (PURE_P): Use a more-efficient implementation that needs just one
1288 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1289 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1290 to 4 (xorl, subq, cmpq, setbe).
1291 * alloc.c (pure): Always extern now, since that's the
1292 VIRT_ADDR_VARIES behavior.
1293 (PURE_POINTER_P): Use a single comparison, not two, for
1294 consistency with the new puresize.h.
1295 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1296 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1297 Remove VIRT_ADDR_VARIES no longer needed.
1298
f8fe6f96
EZ
12992011-11-19 Eli Zaretskii <eliz@gnu.org>
1300
1301 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1302 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1303 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1304 behave as if the cursor position were at the window margin.
1305
1306 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1307 and the cursor position is out of bounds, behave as if the cursor
1308 position were at the window margin. (Bug#10075)
1309
df05a53c
CY
13102011-11-18 Chong Yidong <cyd@gnu.org>
1311
1312 * window.c (Fwindow_combination_limit): Make first argument
1313 non-optional, since it is meaningless for live windows like the
1314 selected window.
1315
2071918e
DA
13162011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1317
1318 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1319
b50a28de
SM
13202011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1321
1322 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1323 (graft_intervals_into_buffer): Simplify.
1324
015137db
EZ
13252011-11-18 Eli Zaretskii <eliz@gnu.org>
1326
1327 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1328 hash values of the two rows.
1329 (copy_row_except_pointers): Preserve the used[] arrays and the
1330 hash values of the two rows. (Bug#10035)
68c95424 1331 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1332
1333 * xdisp.c (row_hash): New function, body extracted from
1334 compute_line_metrics.
1335 (compute_line_metrics): Call row_hash, instead of computing the
1336 hash code inline.
1337
1338 * dispnew.c (verify_row_hash): Call row_hash for computing the
1339 hash code of a row, instead of duplicating code from xdisp.c.
1340
1341 * dispextern.h (row_hash): Add prototype.
1342
a2addb04
TH
13432011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1344
1345 * frame.c (delete_frame): Don't delete the terminal when the last
1346 X frame is closed if emacs is built with GTK toolkit.
1347
df85d315
JB
13482011-11-17 Juanma Barranquero <lekktu@gmail.com>
1349
1350 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1351
a0c2d0ae
MR
13522011-11-17 Martin Rudalics <rudalics@gmx.at>
1353
1354 * window.c (Vwindow_splits): Rename to
1355 Vwindow_combination_resize. Suggested by Juri Linkov.
1356 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1357 of Vwindow_splits.
1358
58179cce
JB
13592011-11-16 Juanma Barranquero <lekktu@gmail.com>
1360
7877f373
JB
1361 * nsfns.m (Fns_font_name):
1362 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1363
b6f67890
MR
13642011-11-16 Martin Rudalics <rudalics@gmx.at>
1365
1366 * window.h (window): Rename slot "nest" to "combination_limit".
1367 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1368 (Fset_window_nest): Rename to Fset_window_combination_limit.
1369 (Vwindow_nest): Rename to Vwindow_combination_limit.
1370 (recombine_windows, make_parent_window, make_window)
1371 (Fsplit_window_internal, saved_window)
1372 (Fset_window_configuration, save_window_save): Rename all
1373 occurrences of window_nest to window_combination_limit.
1374
c7015153
JB
13752011-11-15 Juanma Barranquero <lekktu@gmail.com>
1376
1377 * image.c (imagemagick_load_image): Fix typo.
1378
322ad6ec
EZ
13792011-11-14 Eli Zaretskii <eliz@gnu.org>
1380
1381 * xdisp.c (display_line): Move the call to
1382 highlight_trailing_whitespace before the call to
1383 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1384 faces of all the glyphs to compute ROW's hash value.
1385 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1386
f067b8ec
JB
13872011-11-14 Juanma Barranquero <lekktu@gmail.com>
1388
1389 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1390 just return (bug#10044).
1391
1e5b2111
EZ
13922011-11-12 Eli Zaretskii <eliz@gnu.org>
1393
7ef3cbd5
EZ
1394 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1395 with user-defined heap size. Bump the default size of the temacs
1396 heap to 27MB, to avoid memory warning when running temacs.
1397 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1398
1e5b2111
EZ
1399 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1400 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1401 (verify_row_hash) [XASSERTS]: New function.
1402 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1403 that the hash value of glyph rows is correct.
1e5b2111 1404
89d61221
MR
14052011-11-12 Martin Rudalics <rudalics@gmx.at>
1406
1407 * window.h (window): Remove splits slot.
1408 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1409 (Fdelete_other_windows_internal, make_parent_window)
1410 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1411 (Fset_window_configuration, save_window_save): Don't deal with
1412 split status of windows.
1413 (saved_window): Remove splits slot.
1414 (Vwindow_splits): Rewrite doc-string.
1415
97f18cc8
JD
14162011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1417
1418 * xfns.c (unwind_create_frame):
1419 * nsfns.m (unwind_create_frame):
1420 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1421 Vframe_list (Bug#9999).
1422
22a648b4
DA
14232011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1424
0b381c7e 1425 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1426
659afede
KH
14272011-11-11 Kenichi Handa <handa@m17n.org>
1428
1429 * callproc.c (Fcall_process): Set the member dst_multibyte of
1430 process_coding.
1431
9ac0394b
KH
14322011-11-11 Johan Bockgård <bojohan@gnu.org>
1433
1434 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1435 avoid a crash (bug#9496).
1436
2fbdc249
CY
14372011-11-09 Chong Yidong <cyd@gnu.org>
1438
1439 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1440 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1441
ac6b1f81
PE
14422011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1443
1444 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1445
09db192c
PE
14462011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1447
1448 Avoid some portability problems by eschewing 'extern inline' functions.
1449 The trivial performance wins aren't worth the portability hassles; see
1450 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1451 et seq.
1452 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1453 (window_box_width, window_box_left, window_box_left_offset)
1454 (window_box_right, window_box_right_offset): Undo previous change,
1455 by removing the "extern"s.
1456 * intervals.c (adjust_intervals_for_insertion)
1457 (adjust_intervals_for_deletion): Undo previous change,
1458 making these static again.
1459 (offset_intervals, temp_set_point_both, temp_set_point)
1460 (copy_intervals_to_string): No longer inline.
1461 * xdisp.c (window_text_bottom_y, window_box_width)
1462 (window_box_height, window_box_left_offset)
1463 (window_box_right_offset, window_box_left, window_box_right)
1464 (window_box): No longer inline.
1465
105216ed
CY
14662011-11-08 Chong Yidong <cyd@gnu.org>
1467
1468 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1469 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1470 Signal an error if not a live window.
105216ed
CY
1471 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1472 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1473
ae9e237f
JB
14742011-11-07 Juanma Barranquero <lekktu@gmail.com>
1475
1476 * lisp.h (syms_of_abbrev): Remove declaration.
1477 Reported by CHENG Gao <chenggao@royau.me>.
1478
c7aa8333
EZ
14792011-11-07 Eli Zaretskii <eliz@gnu.org>
1480
1481 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1482 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1483 of temacs in GUI mode.
1484
be7f5545
MR
14852011-11-07 Martin Rudalics <rudalics@gmx.at>
1486
1487 * window.h: Declare delete_all_child_windows instead of
1488 delete_all_subwindows.
1489 * window.c (Fwindow_nest, Fset_window_nest)
1490 (Fset_window_new_total, Fset_window_new_normal)
1491 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1492 (delete_all_subwindows): Rename to delete_all_child_windows.
1493 (Fdelete_other_windows_internal, Fset_window_configuration):
1494 Call delete_all_child_windows instead of delete_all_subwindows.
1495 * frame.c (delete_frame): Call delete_all_child_windows instead
1496 of delete_all_subwindows.
1497
ca78dc43
PE
14982011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1499
1500 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1501 This is also needed for porting to any host where GC_MARK_STACK is
1502 not GC_MAKE_GCPROS_NOOPS.
1503 (which_symbols): Use it.
1504
a0241d01
KH
15052011-11-07 Kenichi Handa <handa@m17n.org>
1506
1507 * coding.c (coding_set_destination): Check coding->src_pos only
1508 when coding->src_object is a buffer (bug#9910).
1509
1510 * process.c (send_process): Set the member src_multibyte of coding
1511 to 0 (bug#9911) when sending a unibyte text.
1512
1513 * callproc.c (Fcall_process): Set the member src_multibyte of
1514 process_coding to 0 (bug#9912).
1515
a64bfdfa 15162011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1517
1518 * xmenu.c (cleanup_widget_value_tree): New function.
1519 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1520 calling free_menubar_widget_value_tree directly (Bug#9830).
1521
cb41b32a
PE
15222011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1523
1524 Fix some portability problems with 'inline'.
1525 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1526 (window_box_width, window_box_left, window_box_left_offset)
1527 (window_box_right, window_box_right_offset): Declare extern.
1528 Otherwise, these inline functions do not conform to C99 and
1529 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1530 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1531 * intervals.c (adjust_intervals_for_insertion)
1532 (adjust_intervals_for_deletion): Now extern, because otherwise the
1533 extern inline functions 'offset_intervals' couldn't refer to it.
1534 (static_offset_intervals): Remove.
1535 (offset_intervals): Rewrite using the old contents of
1536 static_offset_intervals. The old version didn't conform to C99
1537 because an extern inline function contained a reference to an
1538 identifier with static linkage.
1539
b7041366
AS
15402011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1541
1542 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1543 GC.
1544
88a37c4d
EZ
15452011-11-06 Eli Zaretskii <eliz@gnu.org>
1546
1547 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1548 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1549 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1550 return Qleft_to_right.
1551
49745b39
CY
15522011-11-06 Chong Yidong <cyd@gnu.org>
1553
1554 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1555 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1556 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1557 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1558 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1559 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1560 (Fwindow_vscroll): Doc fix.
1561 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1562 argument, since it makes no sense to pass a live window and for
1563 consistency with window-child.
1564
1f05cd82
CS
15652011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1566
1567 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1568 support MSVC.
1569
22610910
JR
15702011-11-05 Jason Rumney <jasonr@gnu.org>
1571
1572 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1573 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1574 fonts (Bug#6029).
1575 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1576 bitwise arithmetic preventing use of unicode-sip and non-truetype
1577 opentype fonts.
1578
a06776b2
EZ
15792011-11-05 Eli Zaretskii <eliz@gnu.org>
1580
3ad924ba
EZ
1581 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1582 "emacs"-only part.
1583
a06776b2
EZ
1584 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1585 initialization code to keep similarity to xfns.c after changes
1586 from 2011-11-05.
1587
c9e7db78
JD
15882011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1589
a97f8f3f
JD
1590 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1591 (unwind_create_frame): New function (Bug#9943).
1592 (Fx_create_frame): Restructure code to be more similar to the one in
1593 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1594 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1595 Move terminal->reference_count++ just before making the frame official
1596 (Bug#9943).
1597
1598 * nsterm.m (x_free_frame_resources): New function.
1599 (x_destroy_window): Move code to x_free_frame_resources.
1600
c9e7db78 1601 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1602 (Fx_create_frame, x_create_tip_frame):
1603 Move terminal->reference_count++ just before making the frame
75f1671a 1604 official. Move initialization of image_cache_refcount and
c9e7db78
JD
1605 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1606
a6fc3b5c
EZ
16072011-11-05 Eli Zaretskii <eliz@gnu.org>
1608
1609 Support MSVC build with newer versions of Visual Studio.
1610 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1611 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1612 nt/gmake.defs.
1613
1614 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1615 which are not supported by MSVC.
1616 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1617 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1618 bitfields.
1619 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1620 types in bitfields.
1621 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1622
1623 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1624
58179cce 16252011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1626
1627 Support MSVC build with newer versions of Visual Studio.
1628 * w32.c: Don't include w32api.h for MSVC.
1629 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1630
1631 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1632 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1633 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1634 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1635 e_* cousins.
1636 (alloca) [_MSC_VER]: Define to _alloca.
1637
1638 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1639
1640 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1641
a58c13ed
EZ
16422011-11-04 Eli Zaretskii <eliz@gnu.org>
1643
1644 * xdisp.c (note_mouse_highlight): If either of
1645 previous/next-single-property-change returns nil, treat that as
1646 the beginning or the end of the buffer. (Bug#9955)
1647
fe0b6370
JD
16482011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1649
a58c13ed 1650 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1651 label is not null (Bug#9951).
1652 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1653 may be NULL.
1654
89bd5ee1
EZ
16552011-11-04 Eli Zaretskii <eliz@gnu.org>
1656
1657 * window.c (Fwindow_body_size): Mention in the doc string that the
1658 return value is in frame's canonical units. (Bug#9949)
1659
84c3edb9
EZ
16602011-11-03 Eli Zaretskii <eliz@gnu.org>
1661
4e2fb5c7
EZ
1662 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1663
84c3edb9 1664 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1665 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1666 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1667
bc17a887
EZ
16682011-11-01 Eli Zaretskii <eliz@gnu.org>
1669
1670 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1671 Don't stop backward scan on the continuation glyph, even though
1672 its CHARPOS is positive.
6d5eb5b0
SM
1673 (mouse_face_from_buffer_pos, note_mouse_highlight):
1674 Rename cover_string to disp_string.
bc17a887 1675
4ee88440
MR
16762011-11-01 Martin Rudalics <rudalics@gmx.at>
1677
1678 * window.c (temp_output_buffer_show): Don't use
1679 Vtemp_buffer_show_specifiers.
1680 (Vtemp_buffer_show_specifiers): Remove unused variable.
1681
c2ff3c02
EZ
16822011-10-30 Eli Zaretskii <eliz@gnu.org>
1683
1684 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1685 past the beginning of the current glyph matrix.
1686
58179cce 16872011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1688
1689 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1690 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1691 HAVE_GTK3 (Bug#9869).
b77a6a7f 1692
3b574623
JD
1693 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1694 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1695
b77a6a7f
JD
1696 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1697
1698 * xterm.c: Declare x_handle_net_wm_state to return int.
1699 (handle_one_xevent): Check if we are iconified but don't have
1700 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1701 (get_current_wm_state): Return non-zero if not hidden,
1702 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1703 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1704 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1705 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1706
196e41e4
PE
17072011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1708
1709 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1710 so that this new function doesn't get optimized away by a
1711 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1712
021f2e1a
AS
17132011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1714
1715 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1716
8b058d44
EZ
17172011-10-29 Eli Zaretskii <eliz@gnu.org>
1718
1719 Fix the `xbytecode' command.
1720 * .gdbinit (xprintbytestr): New command.
b50a28de 1721 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1722 (xbytecode): Print the byte-code string as well.
1723
4452fb80
EZ
17242011-10-29 Kim Storm <storm@cua.dk>
1725
8b058d44
EZ
1726 * alloc.c (which_symbols): New function.
1727
21b72067
AS
17282011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1729
1730 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1731 line. (Bug#9903)
1732
83ed7b5c
GM
17332011-10-29 Glenn Morris <rgm@gnu.org>
1734
1735 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1736 Not clear what it was for, and it causes various bugs. (Bug#9839)
1737
5a7a728b
EZ
17382011-10-28 Eli Zaretskii <eliz@gnu.org>
1739
1740 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1741 possible random value that matches one of those tested as
1742 condition to clear the mouse face.
1743
d3d0842f
CY
17442011-10-28 Chong Yidong <cyd@gnu.org>
1745
1746 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1747
31b39d13
DN
17482011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1749
1750 * window.c (make_window): Initialize phys_cursor_on_p.
1751
9aba6043
SM
17522011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1753
1754 * lisp.h (struct Lisp_Symbol): Update comments.
1755
c20992f4
JB
17562011-10-28 Juanma Barranquero <lekktu@gmail.com>
1757
1758 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1759
db4f02f2
EZ
17602011-10-28 Eli Zaretskii <eliz@gnu.org>
1761
1762 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1763 <oslsachem@gmail.com> for helping to debug this.
1764
1765 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1766 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1767 (g_b_init_get_glyph_outline_w): New static variables.
1768 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1769 (GetGlyphOutlineW_Proc): New typedefs.
1770 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1771 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1772 New functions.
1773 (w32font_open_internal, compute_metrics):
1774 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1775 instead of calling the "wide" APIs directly.
1776
1777 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1778
1779 * w32.h (syms_of_w32font): Add prototype.
1780
87e68db4
JB
17812011-10-27 Juanma Barranquero <lekktu@gmail.com>
1782
1783 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1784 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1785 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1786 (Fmove_to_window_line): Doc fix.
1787
435c1d67
CY
17882011-10-27 Chong Yidong <cyd@gnu.org>
1789
1790 * process.c (make_process): Set gnutls_state to NULL.
1791
1792 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1793 non-NULL, regardless of GNUTLS_INITSTAGE.
1794 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1795 an error. Set process slots as soon as we allocate them.
1796
1797 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1798
9c6c6f49
CY
17992011-10-27 Chong Yidong <cyd@gnu.org>
1800
9aba6043
SM
1801 * gnutls.c (emacs_gnutls_deinit): New function.
1802 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1803 (Fgnutls_deinit, Fgnutls_boot): Use it.
1804
1805 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1806 (deactivate_process): Call emacs_gnutls_deinit.
1807
657d08d3
JB
18082011-10-27 Juanma Barranquero <lekktu@gmail.com>
1809
1810 * image.c (x_create_x_image_and_pixmap):
1811 * w32.c (sys_rename, w32_delayed_load):
1812 * w32font.c (fill_in_logfont):
1813 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1814
5430d399
JB
18152011-10-26 Juanma Barranquero <lekktu@gmail.com>
1816
1817 * w32fns.c (w32_default_color_map): New function,
1818 extracted from Fw32_default_color_map.
a7ef684b 1819 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1820
fe0055fa
PE
18212011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1822
1823 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1824
e6346438
SM
18252011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1826
1827 * keyboard.c (test_undefined): New function (bug#9751).
1828 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1829
e112cc37
ET
18302011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1831
1832 * sysdep.c (init_sys_modes): Fix the check for the controlling
1833 terminal (Bug#6649).
1834
7b5d6677
EZ
18352011-10-20 Eli Zaretskii <eliz@gnu.org>
1836
1837 * dispextern.h (struct bidi_it): New member next_en_type.
1838
1839 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1840 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1841 current character, check also for next_en_type being WEAK_EN.
1842 (bidi_resolve_weak): Don't enter the expensive loop if the current
1843 position is before next_en_pos. Record the bidi type of the first
1844 non-ET, non-BN character we find, in addition to its position.
1845 (bidi_level_of_next_char): Invalidate next_en_type when
1846 next_en_pos is over-stepped.
1847
7da0b018
PE
18482011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1849
1850 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1851 * editfns.c: Rewrite current-time-zone so that it invokes
1852 the equivalent of (format-time-string "%Z") to get the time zone name.
1853 This fixes a bug when the time zone name contains characters that
1854 need converting from the system time locale to Emacs internal format.
1855 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1856 that patch fixed format-time-string to do the conversion, but
1857 I forgot to fix current-time-zone.
1858 (format_time_string): New function, containing most of
1859 what Fformat_time_string used to contain.
1860 (Fformat_time_string): Rewrite in terms of format_time_string.
1861 This doesn't change this function's behavior.
1862 (current-time-zone): Rewrite to use format_time_string.
1863 This fixes the bug reported by Michael Schierl in
1864 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1865 Jason Rumney's 2007-06-07 change worked around this bug, but
1866 didn't fix it.
1867 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1868
8547b010
EZ
18692011-10-19 Eli Zaretskii <eliz@gnu.org>
1870
1871 * xdisp.c (start_display): If the character at POS is displayed
1872 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1873 (try_window_reusing_current_matrix): If a line ends in a display
1874 vector or the next line starts in a display vector, continue
1875 redrawing the window even though the character position of
1876 start_row was reached.
8547b010
EZ
1877 (Bug#9771, part 2)
1878
4e948d15
CY
18792011-10-18 Chong Yidong <cyd@gnu.org>
1880
1881 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1882 with nobreak-char-display too.
1883
4787455f
EZ
18842011-10-18 Eli Zaretskii <eliz@gnu.org>
1885
1886 Fix part 3 of bug#9771.
1887 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1888 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1889 non-neutral characters if the current character is a paragraph
1890 separator (a.k.a. Newline). This avoids running the same
1891 expensive loop twice, once when we consume the preceding newline
1892 and the other time when the line actually needs to be displayed.
1893 Avoid the loop when we see neutrals on the base embedding level
1894 following a character whose directionality is the same as the
1895 paragraph's. This avoids running the expensive loop when a line
1896 ends in a long sequence of neutrals, like control characters.
1897 Add assertion against STRONG_AL type. Slightly rearrange code
1898 that determines the type of a neutral given the first non-neutral
1899 that follows it.
1900 (bidi_level_of_next_char): Set next_en_pos to zero when
1901 invalidating its info.
1902
2c91f553
EZ
19032011-10-17 Eli Zaretskii <eliz@gnu.org>
1904
1905 * xdisp.c (push_display_prop): Determine whether to record string
1906 or buffer position by IT->string, not by IT->method. Allow
1907 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1908 (move_it_vertically_backward): Don't look for character position
1909 immediately after the newline when in a continuation line.
1910 (Bug#9771, part 1)
2c91f553 1911
c7b08b0d
MR
19122011-10-15 Martin Rudalics <rudalics@gmx.at>
1913
1914 * window.c (coordinates_in_window): Rewrite and delabelize
1915 vertical border check. (Bug#5357) (Bug#9618)
1916
6b02f655
SM
19172011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1918
1919 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1920 errors in XSetWindowBorder (bug#9310).
1921
81d40c92
DA
19222011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1923
1924 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1925 avoid crash when xmalloc overrun checking is enabled.
1926
d4172c3b
EZ
19272011-10-13 Eli Zaretskii <eliz@gnu.org>
1928
1929 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1930 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1931 cursor motion with <left> and <right> arrow keys.
1932
1933 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1934 some callers set that themselves.
1935
b00eea75
EZ
19362011-10-12 Eli Zaretskii <eliz@gnu.org>
1937
1938 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1939 display string and the previous row comes from the same string and
1940 is empty. (Bug#9739) (Bug#9738)
1941
8fe012c4
SM
19422011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1943
1944 * doc.c (get_doc_string): Encode file name (bug#9735).
1945
0074aef2
EZ
19462011-10-12 Eli Zaretskii <eliz@gnu.org>
1947
79beb178
EZ
1948 * bidi.c (bidi_level_of_next_char):
1949 * xdisp.c (get_visually_first_element): Remove old incorrect
1950 comments regarding the Unicode Line Separator character.
1951
0074aef2
EZ
1952 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1953
6e4b3fbe
DA
19542011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1955
1956 * alloc.c (Fgc_status): Do not access beyond zombies array
1957 boundary if nzombies > MAX_ZOMBIES.
1958 * alloc.c (dump_zombies): Add missing format specifier.
1959
0324f3af
PE
19602011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1961
b5525cac
PE
1962 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1963 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1964
0324f3af
PE
1965 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1966 Some packages use them to denote characters with modifiers.
1967
e9b5f888
AS
19682011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1969
1970 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1971 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1972 matching a pp-number. Rename parameter var to var1.
1973
127827c0
SM
19742011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1975
1976 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1977
c8fd3bd0
GM
19782011-10-08 Glenn Morris <rgm@gnu.org>
1979
1980 * callint.c (Fcall_interactively): Give a more explicit error for the
1981 'c' case with a non-character input. (Bug#8479)
1982
352ec8ff
EZ
19832011-10-08 Eli Zaretskii <eliz@gnu.org>
1984
03669ccb
EZ
1985 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1986 lines.
7061c986
EZ
1987 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1988 lines that are hscrolled on the left.
03669ccb 1989
352ec8ff
EZ
1990 * dispnew.c (buffer_posn_from_coords): Account for a possible
1991 presence of header-line. (Bug#4426)
1992
a66cfb1c
SM
19932011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1994
6b02f655
SM
1995 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1996 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1997
7c5ee88e
PE
19982011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1999
2000 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2001 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2002 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2003 this makes Emacs dump core during garbage collection on rare
2004 occasions. sizeof is obviously inferior to offsetof here, so
2005 stick with offsetof.
2006 (GC_POINTER_ALIGNMENT): New macro.
2007 (mark_memory): Omit 3rd (offset) arg; caller changed.
2008 Don't assume EMACS_INT alignment is the same as pointer alignment.
2009
df1bbe5b
SM
20102011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2011
2012 * keyboard.c (read_key_sequence_remapped): New var.
2013 (read_key_sequence): Compute remapping in the right buffer.
2014 (command_loop_1): Use read_key_sequence's remapping directly.
2015
51553db6
SM
20162011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2017
32c1fffd
SM
2018 * dired.c (file_name_completion): Don't expand file name.
2019 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2020 before checking file name handler.
2021
51553db6
SM
2022 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2023 they've been requested explicitly (bug#9591).
2024
b6bd1599 20252011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2026
2027 * keymap.c (Fsingle_key_description): Use make_specified_string
2028 instead of build_string to build string from push_key_description.
2029 (Bug#5193)
2030
f701dc2a
PE
20312011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2032
4222c55d
PE
2033 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2034 This fixes a Y2038 bug on 64-bit hosts.
2035 * buffer.c (reset_buffer):
2036 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2037 (Fclear_buffer_auto_save_failure):
2038 Use 0, not -1, to represent an unset failure time, since time_t
2039 might not be signed.
2040
f701dc2a
PE
2041 Remove dependency on glibc malloc internals.
2042 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2043 Move back here from lisp.h, but with their new implementations.
2044 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2045 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2046 * charset.c (charset_table_init): New static var.
2047 (syms_of_charset): Use it instead of xmalloc. This removes a
2048 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2049 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2050 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2051 Move back to alloc.c.
2052 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2053 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2054
9ceebf39
JD
20552011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2056
2057 * nsterm.m (windowDidResize): Call x_set_window_size only when
2058 ns_in_resize is true. Otherwise set pixelwidth/height and
2059 call change_frame_size (Bug#9628).
2060
cb993c58
PE
20612011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2062
3930c88b
PE
2063 Port --enable-checking=all to Fedora 14 x86-64.
2064 * charset.c (syms_of_charset): Also account for glibc malloc's
2065 internal overhead when calculating the initial malloc maximum.
2066
cb993c58
PE
2067 Port --enable-checking=all to Fedora 14 x86.
2068 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2069 Move to lisp.h.
2070 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2071 (overrun_check_realloc, overrun_check_free):
2072 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2073 That way, xmalloc returns a properly-aligned pointer even if
2074 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2075 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2076 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2077 into account when calculating the initial malloc maximum.
2078 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2079 Move here from alloc.c, so that charset.c can use it too.
2080 Properly align; the old code wasn't right for common 32-bit hosts
2081 when configured with --enable-checking=all.
2082 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2083 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2084
31bed486
EZ
20852011-09-29 Eli Zaretskii <eliz@gnu.org>
2086
04c70788 2087 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2088 use EDOM.
2089
fbcaa2f3
EZ
20902011-09-28 Eli Zaretskii <eliz@gnu.org>
2091
2092 * xdisp.c (compute_display_string_end): If there's no display
2093 string at CHARPOS, return -1.
2094
2095 * bidi.c (bidi_fetch_char): When compute_display_string_end
2096 returns a negative value, treat the character as a normal
2097 character not covered by a display string. (Bug#9624)
2098
a239d4e9
JB
20992011-09-28 Juanma Barranquero <lekktu@gmail.com>
2100
2101 * lread.c (Fread_from_string): Fix typo in docstring.
2102
88652fd5
EZ
21032011-09-27 Eli Zaretskii <eliz@gnu.org>
2104
2105 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2106 newline, reseat the iterator instead of bidi-iterating there one
2107 character at a time. (Bug#9610)
32c1fffd
SM
2108 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2109 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2110
ed497dd4
AS
21112011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2112
2113 * lread.c (readevalloop): Use correct code for NBSP.
2114 (read1): Likewise. (Bug#9608)
2115
b2bf61aa
MA
21162011-09-25 Michael Albinus <michael.albinus@gmx.de>
2117
2118 * dbusbind.c (Fdbus_register_signal): When service is not
2119 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2120
32bbb17c
GM
21212011-09-25 Glenn Morris <rgm@gnu.org>
2122
2123 * buffer.c (truncate-lines): Doc fix.
2124
94e0933e
CY
21252011-09-24 Chong Yidong <cyd@stupidchicken.com>
2126
2127 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2128 (Fset_window_next_buffers): Doc fix.
2129
cddde921
GM
21302011-09-24 Glenn Morris <rgm@gnu.org>
2131
2132 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2133
1260aef1
PE
21342011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2135
25b4bfa0
PE
2136 Fix minor problems found by static checking.
2137 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2138 * indent.c (Fvertical_motion): Fix == vs = typo.
2139
e3cbd34b
EZ
21402011-09-24 Eli Zaretskii <eliz@gnu.org>
2141
a66cfb1c
SM
2142 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2143 Default value is now t. Doc fix.
6bf7006f 2144
e3cbd34b 2145 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2146 logic when moving up, not only when moving down. Fix the
e3cbd34b 2147 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2148 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2149
2150 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2151 CHARPOS is covered by a display string which includes newlines.
2152 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2153 is covered by a display string with embedded newlines.
2154
a3de0cbd
MA
21552011-09-24 Michael Albinus <michael.albinus@gmx.de>
2156
2157 * dbusbind.c (Fdbus_register_signal): Add match rule to
2158 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2159 (Fdbus_register_method, Vdbus_registered_objects_table):
2160 Fix docstring.
a3de0cbd 2161
b260039d
JM
21622011-09-24 Jim Meyering <meyering@redhat.com>
2163
32c1fffd 2164 do not ignore write error for any output size
b260039d
JM
2165 The previous change was incomplete.
2166 While it makes emacs --batch detect the vast majority of stdout
2167 write failures, errors were still ignored whenever the output size is
2168 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2169 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2170 && echo FAIL: ignored write error
2171 FAIL: ignored write error
2172 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2173 && echo FAIL: ignored write error
2174 FAIL: ignored write error
2175 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2176
8eca8a7c
AS
21772011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2178
2179 * emacs.c (Fkill_emacs): In noninteractive mode exit
2180 non-successfully if a write error occurred on stdout. (Bug#9574)
2181
3341db62
EZ
21822011-09-21 Eli Zaretskii <eliz@gnu.org>
2183
2184 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2185 the xassert test.
2186
2187 * dispextern.h (struct it): Update the comment documenting what
2188 can it->OBJECT be.
2189
8c203dbf
EZ
21902011-09-20 Eli Zaretskii <eliz@gnu.org>
2191
2192 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2193 a display string, extend search for cursor position to end of row.
2194 (find_row_edges): If the row ends in a newline from a display
2195 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2196 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2197 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2198 non-empty line. Fixes confusing cursor motion with arrow keys at
2199 the beginning of a line that starts with whitespace.
8c203dbf 2200
a4824228
LMI
22012011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2202
2203 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2204 (bug#9493).
2205
33ed493b
CY
22062011-09-18 Chong Yidong <cyd@stupidchicken.com>
2207
2208 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2209 boolean (Bug#9154).
2210
56cd55c8
EZ
22112011-09-18 Eli Zaretskii <eliz@gnu.org>
2212
2213 * xdisp.c (display_line): Record maximum and minimum buffer
2214 positions even if no glyphs were produced (e.g., by a zero-width
2215 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2216 buffer positions that will be removed from the glyph row because
2217 they don't fit.
c02dcedf
EZ
2218 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2219 column is beyond frame width: don't subtract 1 "pixel" when
2220 computing width of the stretch.
3e62b7e0
EZ
2221 (reseat_at_next_visible_line_start): Undo the change made on
2222 2011-09-17 that saved paragraph information and restored it after
2223 the call to `reseat'. (Bug#9545)
56cd55c8 2224
5ed99d36 22252011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2226
2227 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2228 and turn window cursor on if cleared (Bug#9415).
2229
5ed99d36 22302011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2231
2232 * search.c (boyer_moore): Take unibyte characters from pattern
2233 literally. (Bug#9458)
2234
9bade7b2
EZ
22352011-09-18 Eli Zaretskii <eliz@gnu.org>
2236
2237 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2238
e5e9d610
PE
22392011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2240
87e4427a
PE
2241 Fix minor problem found by static checking.
2242 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2243 initialized, to pacify gcc -Wuninitialized.
2244
e5e9d610
PE
2245 * fileio.c: Report proper errno when syscall falls.
2246 (Finsert_file_contents): Save and restore errno,
2247 so that report_file_error outputs the correct diagnostic.
2248 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2249
a1674f0b
EZ
22502011-09-18 Eli Zaretskii <eliz@gnu.org>
2251
2252 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2253
fbfb6dd4
EZ
22542011-09-17 Eli Zaretskii <eliz@gnu.org>
2255
2256 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2257 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2258
bb187662
EZ
22592011-09-17 Eli Zaretskii <eliz@gnu.org>
2260
1137e8b8 2261 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2262 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2263
2264 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2265 (bidi_find_paragraph_start): Search back for paragraph beginning
2266 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2267 (bidi_move_to_visually_next): Only trigger paragraph-related
2268 computations when the last character is a newline or at EOB, not
2269 just any NEUTRAL_B. (Bug#9470)
2270
bb187662
EZ
2271 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2272 truncated lines if point is covered by a display string. (Bug#9524)
2273
2e621251
PE
22742011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2275
2276 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2277 (cons_to_x_long): New function.
2278 (lisp_data_to_selection_data): Use it. Correct the test for
2279 short-versus-long data; it was negated. Break out of vector
2280 loop, for efficiency, when a long datum is discovered.
2281
91a15bc6
SM
22822011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2283
2284 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2285
b41c3a35
EZ
22862011-09-16 Eli Zaretskii <eliz@gnu.org>
2287
2288 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2289 GCC PR/17406) by declaring this function with external scope.
2290
7812ba2d
PE
22912011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2292
2293 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2294 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2295
cf7edc2a
AS
22962011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2297
2298 * editfns.c (Fformat): Correctly handle text properties on "%%".
2299
bd01620e
EZ
23002011-09-15 Eli Zaretskii <eliz@gnu.org>
2301
2302 * xterm.c (x_draw_composite_glyph_string_foreground):
2303 * w32term.c (x_draw_composite_glyph_string_foreground):
2304 * term.c (encode_terminal_code):
2305 * composite.c (composition_update_it, get_composition_id):
2306 * xdisp.c (get_next_display_element)
2307 (fill_composite_glyph_string): Add comments about special meaning
2308 of TAB characters in a composition.
2309
a02719a3
PE
23102011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2311
2312 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2313 This occurs when processing a multibyte format.
2314 Problem reported by Wolfgang Jenker.
a02719a3 2315
72589a3c
JB
23162011-09-15 Johan Bockgård <bojohan@gnu.org>
2317
2318 * xdisp.c (try_cursor_movement): Only check for exact match if
2319 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2320
1c14176c
PE
23212011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2322
2323 Remove unused external symbols.
2324 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2325 * xdisp.c (calc_pixel_width_or_height): Now static.
2326 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2327 * indent.c (check_display_width):
2328 * w32term.c: Fix comment to match code.
2329 * xterm.c, xterm.h (x_catching_errors): Remove.
2330
d2eea5b5
PE
23312011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2332
2333 * xselect.c: Use signed conversions more consistently (Bug#9498).
2334 (selection_data_to_lisp_data): Assume incoming selection data are
2335 signed integers, not unsigned. This is to be consistent with
2336 outgoing selection data, which was modified to use signed integers
2337 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2338 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2339 expects long, not unsigned long.
2340
46888499
EZ
23412011-09-14 Eli Zaretskii <eliz@gnu.org>
2342
2343 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2344 computation of loop end. Reported by Johan Bockgård
2345 <bojohan@gnu.org>.
2346
ef8ef9fb
CY
23472011-09-13 Chong Yidong <cyd@stupidchicken.com>
2348
2349 * frame.c (Fother_visible_frames_p): Function deleted.
2350
fa819fed
EZ
23512011-09-12 Eli Zaretskii <eliz@gnu.org>
2352
2353 * indent.c (compute_motion): Process display vector front to back
2354 rather than the other way around. (Bug#2496)
2355
2ba8e008
SM
23562011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2357
2358 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2359
20f53c69
CY
23602011-09-11 Chong Yidong <cyd@stupidchicken.com>
2361
2362 * minibuf.c (Fread_from_minibuffer): Doc fix.
2363
d562d7a4
EZ
23642011-09-11 Eli Zaretskii <eliz@gnu.org>
2365
2366 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2367 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2368
1c4d7f3d
LMI
23692011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2370
2371 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2372 value for non-existent files.
2373
b885bf36
EZ
23742011-09-11 Eli Zaretskii <eliz@gnu.org>
2375
2376 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2377 set its "size" to -1. This will set the modtime_size field of
2378 the corresponding buffer to -1, which is what
2379 verify-visited-file-modtime expects for files that do not exist.
2380 (Bug#9139)
2381
6612f0bf
PE
23822011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2383
2384 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2385 here ...
2386 * lisp.h: ... from here. push_key_description is no longer
2387 defined in keyboard.c, so its declaration should not be in
2388 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2389 logically belongs with push_key_description.
2390
dfb3f755
PE
23912011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2392
2393 * buffer.h: Include <sys/types.h> instead of <time.h>.
2394 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2395 Problem reported by Herbert J. Skuhra.
2396
3134906c
LMI
23972011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2398
2399 * xml.c (parse_region): Make the parsing work for
2400 non-comment-starting XML files again (bug#9144).
2401
8d903f4e
AS
24022011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2403
2404 * image.c (gif_load): Fix calculation of bottom and right corner.
2405 (Bug#9468)
2406
80ad64f4
EZ
24072011-09-10 Eli Zaretskii <eliz@gnu.org>
2408
2409 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2410 redisplay in small windows.
2411
208a048d
EZ
24122011-09-09 Eli Zaretskii <eliz@gnu.org>
2413
2414 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2415
9b1c252e
MR
24162011-09-08 Martin Rudalics <rudalics@gmx.at>
2417
2418 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2419 Operate on live windows only.
2420
2949f33b
JB
24212011-09-08 Juanma Barranquero <lekktu@gmail.com>
2422
2423 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2424
e08dcafd
EZ
24252011-09-07 Eli Zaretskii <eliz@gnu.org>
2426
2427 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2428 only under bidi iteration.
2429
115b96bd
JD
24302011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2431
2432 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2433
c8199d0f
PE
24342011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2435
2436 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2437 Without this fix, the command to link temacs failed due to an
2438 undefined symbol __builtin_isnan. This is because
2439 /usr/include/iso/math_c99.h #defines isnan(x) to
2440 __builtin_isnan(x), but the bundled gcc, which identifies itself
2441 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2442 a __builtin_isnan.
2443 * floatfns.c (isnan): #undef, and then #define to a clone of
2444 what's in data.c.
2445 (Fisnan): Always define, since it's always available now.
2446 (syms_of_floatfns): Always define isnan at the Lisp level.
2447
e39b275c 24482011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2449
2450 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2451
b2db44d9 24522011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2453
f4af5137 2454 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2455 The previous code assumed that file offsets (off_t values) fit in
2456 EMACS_INT variables, which is not true on typical 32-bit hosts.
2457 The code messed up by falsely reporting buffer overflow in cases
2458 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2459 when "big" contains more than 2**29 bytes, even though this
2460 inserts just one byte and does not overflow the buffer.
2461 (Finsert_file_contents): Store file offsets as off_t
2462 values, not as EMACS_INT values. Check for overflow when
2463 converting between EMACS_INT and off_t. When checking for
2464 buffer overflow or for overlap, take the offsets into account.
2465 Don't use EMACS_INT for small values where int suffices.
2466 When checking for overlap, fix a typo: ZV was used where
2467 ZV_BYTE was intended.
2468 (Fwrite_region): Don't assume off_t fits into 'long'.
2469 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2470
ecfc0a49
MA
24712011-09-05 Michael Albinus <michael.albinus@gmx.de>
2472
2473 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2474
6511acf2 24752011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2476
0999621a 2477 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2478
2479 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2480 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2481 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2482 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2483 (modify_event_symbol): Do not assume that the length of
2484 name_alist_or_stem is safe to alloca and fits in int.
2485 (Fexecute_extended_command): Likewise for function name and binding.
2486 (Frecursion_depth): Wrap around reliably on integer overflow.
2487 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2488 since some callers pass EMACS_INT values.
2489 (Fsingle_key_description): Don't crash if symbol name contains more
2490 than MAX_ALLOCA bytes.
2491 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2492 (get_minibuffer): Arg is now EMACS_INT, not int.
2493 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2494 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2495 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2496
2be7d702
PE
2497 * dbusbind.c (signature_cat): New function.
2498 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2499 Do not overrun buffer; instead, report string overflow.
2500
9d1df220
PE
2501 * dispnew.c (add_window_display_history): Don't overrun buffer.
2502 Truncate instead; this is OK since it's just a log.
2503
33ef5c64
PE
2504 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2505 even if the time zone offset is outlandishly large.
2506 Don't mishandle offset == INT_MIN.
2507
66c6fdd5
PE
2508 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2509 when creating daemon; the previous buffer-overflow check was incorrect.
2510
d749b01b
PE
2511 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2512 which has the guts of the old verror function.
2513
b5cd1905
PE
2514 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2515 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2516
6e1a67fb
PE
2517 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2518 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2519 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2520 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2521 length of string rather than counting it via multiple sprintfs;
2522 that's simpler and more reliable.
c21721cc
PE
2523 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2524 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2525 sprintf, in case result does not fit in int.
2526
c57b67fc
PE
2527 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2528 (fontset_from_font): Print it.
2529
8a401434
PE
2530 * frame.c (tty_frame_count): Now printmax_t, not int.
2531 (make_terminal_frame, set_term_frame_name): Print it.
2532 (x_report_frame_params): In X, window IDs are unsigned long,
2533 not signed long, so print them as unsigned.
2534 (validate_x_resource_name): Check for implausibly long names,
2535 and don't assume name length fits in 'int'.
2536 (x_get_resource_string): Don't blindly alloca invocation name;
2537 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2538 not fit in int.
2539
6e1a67fb
PE
2540 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2541 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2542 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2543
0df02bf3
PE
2544 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2545 Use esprintf, not sprintf, in case result does not fit in int.
2546
48e30793
PE
2547 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2548 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2549 it as a large positive number.
2550 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2551 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2552
a66ff6d8
PE
2553 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2554 in case result does not fit in int.
2555
aca216ff
PE
2556 * print.c (float_to_string): Detect width overflow more reliably.
2557 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2558 buffer overrun. Don't assume list length fits in 'int'. Treat
2559 print length of 0 as 0, not as infinity; to be consistent with other
2560 uses of print length in this function. Don't overflow print length
2561 index. Don't assume hash table size fits in 'long', or that
2562 vectorlike size fits in 'unsigned long'.
2563
31c286f7
PE
2564 * process.c (make_process): Use printmax_t, not int, to format
2565 process-name gensyms.
2566
55e5faa1
PE
2567 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2568
80f2e268
PE
2569 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2570 to avoid potential buffer overrun.
2571
670741ab
PE
2572 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2573 if X resource line is longer than 512 bytes.
2574
b7163a50
PE
2575 * xfns.c (x_window): Make sprintf buffer a bit bigger
2576 to avoid potential buffer overrun.
2577
ae58ff1f
PE
2578 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2579
c43c8a6a
PE
2580 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2581
3f8236f4
PE
25822011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2583
53e9fe90 2584 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2585 Without these, Emacs silently mishandles large integers sometimes.
2586 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2587 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2588
6511acf2
PE
2589 * xdisp.c (try_window_id): Check Emacs fixnum range before
2590 converting to 'int'.
806add1d 2591
6511acf2 2592 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2593 Check that an Emacs fixnum is in range before assigning it to 'int'.
2594 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2595 values converted from Emacs fixnums.
2596 (Frecenter): Don't wrap around a line count if it is out of 'int'
2597 range; instead, treat it as an extreme value.
2598 (Fset_window_configuration, compare_window_configurations):
2599 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2600
6511acf2
PE
2601 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2602 that can exceed INT_MAX. Check that EMACS_INT value is in range
2603 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2604 (match_limit): Don't assume that a fixnum can fit in 'int'.
2605
6511acf2 2606 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2607 exceed INT_MAX.
2608
6511acf2 2609 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2610 (Fvertical_motion): Don't wrap around LINES values that don't fit
2611 in 'int'. Instead, treat them as extreme values. This is good
2612 enough for windows, which can't have more than INT_MAX lines anyway.
2613
fcb901a7
LMI
26142011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2615
0f2f6b6d
LMI
2616 * Require libxml/parser.h to avoid compilation warning.
2617
fcb901a7
LMI
2618 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2619
2620 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2621 since this reportedly can destroy thread storage.
2622
6e20a0d4
CY
26232011-08-30 Chong Yidong <cyd@stupidchicken.com>
2624
2625 * syntax.c (find_defun_start): Update all cache variables if
2626 exiting early (Bug#9401).
2627
148ae00e
EZ
26282011-08-30 Eli Zaretskii <eliz@gnu.org>
2629
f6cfbd8f
EZ
2630 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2631
148ae00e
EZ
2632 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2633 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2634 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2635
2636 * term.c (tty_append_glyph): New function.
2637 (produce_stretch_glyph): Static function and its prototype deleted.
2638
a66cfb1c
SM
2639 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2640 Add prototypes.
148ae00e 2641
c4a07a4c
PE
26422011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2643
2644 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2645 when checking :margin (Bug#9390).
2646 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2647 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2648 so that the name doesn't mislead. All uses changed.
2649
6bc8cd65
JB
26502011-08-28 Johan Bockgård <bojohan@gnu.org>
2651
2652 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2653 set_tty_hooks.
2654
dca4927e
EZ
26552011-08-27 Eli Zaretskii <eliz@gnu.org>
2656
2657 * xdisp.c (move_it_to): Don't bail out early when reaching
2658 position beyond to_charpos, if we are scanning backwards.
2659 (move_it_vertically_backward): When DY == 0, make sure we get to
2660 the first character in the line after the newline.
2661
f2cad773
PE
26622011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2663
2664 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2665 (ccl_driver): Do not generate an out-of-range pointer.
2666 (Fccl_execute_on_string): Remove unnecessary check for
2667 integer overflow, noted by Stefan Monnier in
2668 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2669 Remove a FIXME that didn't need fixing.
2670 Simplify the newly-introduced buffer reallocation code.
2671
0cae2cdb
JB
26722011-08-27 Juanma Barranquero <lekktu@gmail.com>
2673
2674 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2675
5fc295a4 26762011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2677
70c60eb2 2678 Integer and memory overflow issues (Bug#9196).
726e0ab1 2679
d31850da
PE
2680 * doc.c (get_doc_string): Rework so that
2681 get_doc_string_buffer_size is the actual buffer size, rather than
2682 being 1 less than the actual buffer size; this makes xpalloc more
2683 convenient.
2684
a69fbedb
PE
2685 * image.c (x_allocate_bitmap_record, cache_image):
2686 * xselect.c (Fx_register_dnd_atom):
2687 Simplify previous changes by using xpalloc.
2688
fe5c5d37
PE
2689 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2690 since either will do and ptrdiff_t is convenient with xpalloc.
2691
0065d054
PE
2692 * charset.c (charset_table_size)
2693 (struct charset_sort_data.priority): Now ptrdiff_t.
2694 (charset_compare): Don't overflow if priorities differ greatly.
2695 (Fsort_charsets): Don't assume list length fits in int.
2696 Check for size-calculation overflow when allocating sort data.
2697 (syms_of_charset): Allocate an initial charset table that is
2698 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2699
2700 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2701
2702 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2703 The actual value is always <= INT_MAX, and leaving it unsigned made
2704 overflow checking harder.
2705
2706 * dispextern.h (struct glyph_matrix.rows_allocated)
2707 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2708 with xpalloc. The values are still always <= INT_MAX.
2709
2710 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2711
2712 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2713 (SAFE_NALLOCA): New macro.
2714
2715 * region-cache.c (struct boundary.pos, find_cache_boundary)
2716 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2717 (set_cache_region, invalidate_region_cache)
2718 (revalidate_region_cache, know_region_cache, region_cache_forward)
2719 (region_cache_backward, pp_cache):
2720 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2721 so that ptrdiff_t * can be passed to xpalloc.
2722 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2723 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2724 (pp_cache): Don't assume cache_len fits in int.
2725 * region-cache.h: Adjust extern decls to match.
2726
2727 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2728 EMACS_INT, since either will do, for xpalloc.
2729
2730 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2731 (xnmalloc, xnrealloc, xpalloc): New functions.
2732
726e0ab1
PE
2733 * bidi.c (bidi_shelve_header_size): New constant.
2734 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2735 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2736
51f30bc5 2737 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2738 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2739 (overlay_strings):
2740 Don't update size of array until after memory allocation succeeds,
2741 because xmalloc/xrealloc may not return.
0065d054
PE
2742 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2743 now that we have proper integer overflow checking.
2744 (record_overlay_string, overlay_strings): Catch overflows when
2745 calculating size of overlay_str_buf.
726e0ab1 2746
0065d054
PE
2747 * callproc.c (Fcall_process): Check for size overflow when
2748 calculating size of args2.
2749 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2750 Normally we prefer signed values, but sticking with ptrdiff_t would
2751 require adding more-complicated checks.
726e0ab1
PE
2752
2753 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2754 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2755 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2756 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2757
2758 * character.c (Fstring): Check for size-calculation overflow.
2759
2760 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2761 unnecessary integer overflow. Check for size overflow.
2762 (encode_coding_object): Don't update size until xmalloc succeeds.
2763
2764 * composite.c (get_composition_id): Check for overflow in glyph
2765 length calculations.
2766
2767 Integer and memory overflow fixes for display code.
2768 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2769 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2770 (scrolling_window): Check for overflow in size calculations.
2771 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2772 Don't assume glyph table len fits in int.
2773 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2774 (row_table_size): Now ptrdiff_t, not int.
2775 (scrolling_window): Avoid overflow in size calculations.
2776 Don't update size until allocation succeeds.
2777 * fns.c (concat): Check for overflow in size calculations.
2778 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2779 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2780 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2781
2782 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2783 (get_doc_string): Check for size calculation overflow.
2784 Don't update size until allocation succeeds.
2785 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2786 EMACS_INT, where ptrdiff_t will do.
2787 (Fsubstitute_command_keys): Check for string overflow.
2788
2789 * editfns.c (set_time_zone_rule): Don't assume environment length
2790 fits in int.
2791 (message_length): Now ptrdiff_t, not int.
2792 (Fmessage_box): Don't update size until allocation succeeds.
2793 Don't assume message length fits in int.
2794 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2795
0065d054
PE
2796 * emacs.c (main): Do not reallocate argv, since there is a null at
2797 the end that can be overwritten, and this way there's no need to
2798 worry about size-calculation overflow.
2799 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2800
2801 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2802 alloc succeeds.
2803 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2804
2805 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2806 (x_set_scroll_bar_width, x_figure_window_size):
2807 Check for integer overflow.
2808 (x_set_alpha): Do not assume XINT fits in int.
2809
2810 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2811 This is for the members text_lines, text_cols, total_lines, total_cols,
2812 where the system imposes an 'int' limit.
2813
2814 * fringe.c (Fdefine_fringe_bitmap):
2815 Don't update size until alloc works.
2816
2817 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2818 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2819
2820 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2821 Check for size-calculation overflow.
2822 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2823 do, as we prefer signed integers.
2824 (id_to_widget.max_size, id_to_widget.used)
2825 (xg_store_widget_in_map, xg_remove_widget_from_map)
2826 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2827 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2828 Use and return ptrdiff_t, not int.
2829 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2830 * gtkutil.h: Change prototypes to match the above.
2831
2832 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2833 are duplicate now that they've been promoted to lisp.h.
2834 (x_allocate_bitmap_record, x_alloc_image_color)
2835 (make_image_cache, cache_image, xpm_load):
2836 Don't update size until alloc is done.
2837 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2838 (x_detect_edges):
3256efce 2839 Check for size calculation overflow.
726e0ab1
PE
2840 (ct_colors_allocated_max): New constant.
2841 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2842 overflow.
3256efce 2843
726e0ab1
PE
2844 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2845 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2846 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2847 Use ptrdiff_t, not int, to count maps.
2848 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2849 calculations. Don't update size until allocation succeeds.
2850 Redo calculations to avoid overflow.
726e0ab1
PE
2851 * keyboard.h: Change prototypes to match the above.
2852
2853 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2854 to count maps.
2855 (current_minor_maps): Check for size calculation overflow.
2856 * keymap.h: Change prototypes to match the above.
2857
2858 * lread.c (read1, init_obarray): Don't update size until alloc done.
2859
2860 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2861 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2862
726e0ab1
PE
2863 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2864 Now ptrdiff_t, not int.
2865 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2866 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2867
2868 * process.c (Fnetwork_interface_list): Check for overflow
2869 in size calculation.
2870
2871 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2872
2873 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2874 overflow. Don't bother calling xmalloc when xrealloc will do.
2875
2876 * search.c (Freplace_match): Check for size calculation overflow.
2877 (Fset_match_data): Don't assume list lengths fit in 'int'.
2878
2879 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2880 for command line length. Do not attempt to address one before the
2881 beginning of an array, as that's not portable.
2882
2883 * term.c (max_frame_lines): Remove; unused.
2884 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2885 not int.
2886 (encode_terminal_code, calculate_costs): Check for size
2887 calculation overflow.
2888 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2889 table lengths and related sizes. Don't update size until alloc
2890 done. Redo calculations to avoid overflow.
2891 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2892
2893 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2894 subtracting pointers.
2895 (gobble_line): Check for overflow more carefully. Don't update size
2896 until alloc done.
2897
2898 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2899 Don't update size until alloc done.
2900 Redo size calculations to avoid overflow.
2901 Check for size calculation overflow.
0065d054 2902 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2903
2904 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2905 Use ptrdiff_t, not int, for sizes.
2906 (store_mode_line_noprop_char): Don't update size until alloc done.
2907
0065d054
PE
2908 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2909 Use ptrdiff_t, not int, for sizes.
2910 (Finternal_make_lisp_face, cache_face):
2911 Check for size calculation overflow.
2912 (cache_face): Treat size calculation overflows as if they were
2913 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2914
2915 * xfns.c (x_encode_text, x_set_name_internal)
2916 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2917 sizes, since they can exceed INT_MAX in size. Check for size
2918 calculation overflow.
2919
0065d054
PE
2920 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2921 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2922 Don't update size until alloc done.
2923
0065d054 2924 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2925 as sprintf is limited to int lengths.
1d526e2f 2926
252c5ee1
PE
2927 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2928 (X_LONG_MIN): New macros.
864d7ce7
PE
2929 Use them to make the following changes clearer.
2930 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2931 This change doesn't affect the value now, but it may help remind
2932 future maintainers not to raise the value too much later.
2933 (SELECTION_QUANTUM): Remove, replacing with ...
2934 (selection_quantum): ... new function, which avoids overflow.
2935 All uses changed.
2936 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2937 assumption that selection length fits in 'int'.
2938 (x_reply_selection_request, x_handle_selection_request)
2939 (x_get_window_property, receive_incremental_selection)
2940 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2941 (lisp_data_to_selection_data, clean_local_selection_data):
2942 Use ptrdiff_t, not int, to record length of selection.
2943 (x_reply_selection_request, x_get_window_property)
2944 (receive_incremental_selection, x_property_data_to_lisp):
2945 Redo calculations to avoid overflow.
2946 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2947 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2948 something.
2949 (x_get_window_property, receive_incremental_selection)
2950 (lisp_data_to_selection_data, x_property_data_to_lisp):
2951 Check for size-calculation overflow.
2952 (x_get_window_property, receive_incremental_selection)
2953 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2954 Don't store size until memory allocation succeeds.
2955 (x_get_window_property): Plug memory leak on memory exhaustion.
2956 Don't double-block input; malloc is safe here. Don't assume 2**34
2957 - 4 fits in unsigned long. Add an xassert to check
2958 XGetWindowProperty overflow. Be more careful about overflow
2959 calculations, and distinguish size from memory overflow better.
2960 (receive_incremental_selection): When tracing, don't assume
2961 unsigned int is less than INT_MAX.
2962 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2963 harmful) conversions of unsigned short to int.
2964 (lisp_data_to_selection_data): Don't assume that integers
2965 in the range -65535 through -1 fit in an X unsigned short.
2966 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2967 result parameters unless successful. Rely on cons_to_unsigned
2968 to report problems with elements; the old code wasn't right anyway.
2969 (x_check_property_data): Check for int overflow; we cannot use
2970 a wider type due to X limits.
2971 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2972
726e0ab1 2973 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2974
0065d054
PE
2975 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2976 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2977 (x_color_cells): Don't store size until memory allocation succeeds.
2978 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2979 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2980 (x_term_init): Don't assume length fits in int (sprintf is limited
2981 to int size).
bc18e09d 2982
ebfa62c0
PE
2983 Use ptrdiff_t for composition IDs.
2984 * character.c (lisp_string_width):
2985 * composite.c (composition_table_size, n_compositions)
2986 (get_composition_id, composition_gstring_from_id):
2987 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2988 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2989 * window.c (Frecenter):
2990 Use ptrdiff_t, not int, for composition IDs.
2991 * composite.c (get_composition_id): Check for integer overflow.
2992 * composite.h: Adjust prototypes to match the above changes.
2993
d3411f89
PE
2994 Use ptrdiff_t for hash table indexes.
2995 * category.c (hash_get_category_set):
2996 * ccl.c (ccl_driver):
2997 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2998 * coding.c (coding_system_charset_list, detect_coding_system):
2999 * coding.h (struct coding_system.id):
3000 * composite.c (get_composition_id, gstring_lookup_cache):
3001 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3002 * image.c (xpm_get_color_table_h):
3003 * lisp.h (hash_lookup, hash_put):
3004 * minibuf.c (Ftest_completion):
3005 Use ptrdiff_t for hash table indexes, not int (which is too
3006 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3007 32-bit --with-wide-int hosts).
3008
e097a6fa
PE
3009 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3010 Add a FIXME comment about memory leaks.
3011 (syms_of_charset): Don't assume xmalloc returns.
3012
5637687f
PE
3013 Don't assume that stated character widths fit in int.
3014 * character.c (Fchar_width, c_string_width, lisp_string_width):
3015 * character.h (CHAR_WIDTH):
3016 * indent.c (MULTIBYTE_BYTES_WIDTH):
3017 Use sanitize_char_width to avoid undefined and/or bad behavior
3018 with outlandish widths.
a66cfb1c 3019 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3020 now that we have two such functions. All uses changed.
3021 (sanitize_char_width): New inline function.
3022
a2271ba2
PE
3023 Don't assume that tab-width fits in int.
3024 * character.h (sanitize_width): New inline function.
3025 (SANE_TAB_WIDTH): New macro.
3026 (ASCII_CHAR_WIDTH): Use it.
3027 * indent.c (sane_tab_width): Remove. All uses replaced by
3028 SANE_TAB_WIDTH (current_buffer).
3029 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3030
18c52557
PE
3031 * fileio.c: Integer overflow issues with file modes.
3032 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3033
caeeedc1
PE
3034 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3035 Remove unreachable code.
3036 (read_hex, load_charset_map_from_file): Check for integer overflow.
3037
6df6ae42 3038 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3039 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3040 (x_send_scroll_bar_event): Likewise. Check that the size does not
3041 exceed limits imposed by XClientMessageEvent, as well as the usual
3042 ptrdiff_t and size_t limits.
3043
b13995db
PE
3044 * keyboard.c: Overflow, signedness and related fixes.
3045 (make_lispy_movement): Use same integer type in forward decl
3046 that is used in the definition.
3047 (read_key_sequence, keyremap_step):
3048 Change bufsize argument back to int, undoing my 2011-03-30 change.
3049 We prefer signed types, and int is wide enough here.
3050 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3051 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3052 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3053 length, not size_t. Use ptrdiff_t for index, not int.
3054 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3055 possibility of integer overflow.
3056
13464394
PE
3057 Overflow, signedness and related fixes for images.
3058
3059 * dispextern.h (struct it.stack[0].u.image.image_id)
3060 (struct_it.image_id, struct image.id, struct image_cache.size)
3061 (struct image_cache.used, struct image_cache.ref_count):
3062 * gtkutil.c (update_frame_tool_bar):
3063 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3064 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3065 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3066 * nsmenu.m (update_frame_tool_bar):
3067 * xdisp.c (calc_pixel_width_or_height):
3068 * xfns.c (image_cache_refcount):
3069 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3070 on typical 64-bit hosts.
3071
3072 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3073 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3074 Omit unnecessary casts to int.
3075 (parse_image_spec): Check that integers fall into 'int' range
3076 when the callers expect that.
3077 (image_ascent): Redo ascent calculation to avoid int overflow.
3078 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3079 (lookup_image): Remove unnecessary tests.
3080 (xbm_image_p): Locals are now of int, not EMACS_INT,
3081 since parse_image_check makes sure they fit into int.
3082 (png_load, gif_load, svg_load_image):
3083 Prefer int to unsigned where either will do.
3084 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3085 old tiff_error_handler and tiff_warning_handler.
3086 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3087 stack buffer overflows. It uses only the features of vsnprintf
3088 that are common to both POSIX and native Microsoft.
3089 (tiff_error_handler, tiff_warning_handler): Use it.
3090 (tiff_load, gif_load, imagemagick_load_image):
3091 Don't assume :index value fits in 'int'.
3092 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3093 (imagemagick_load_image): Check that crop parameters fit into
3094 the integer types that MagickCropImage accepts. Don't assume
3095 Vimagemagick_render_type has a nonnegative value. Don't assume
3096 size_t fits in 'long'.
3097 (gs_load): Use printmax_t to print the widest integers possible.
3098 Check for integer overflow when computing image height and width.
3099
c11821d4
EZ
31002011-08-26 Eli Zaretskii <eliz@gnu.org>
3101
3102 * xdisp.c (redisplay_window): Don't force window start if point
3103 will be invisible in the resulting window. (Bug#9324)
3104
0c95fcf7
EZ
31052011-08-25 Eli Zaretskii <eliz@gnu.org>
3106
3107 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3108 the display spec is of the form `(space ...)'.
3109 (handle_display_spec): Return the value returned by
3110 handle_single_display_spec, not just 1 or zero.
3111 (handle_single_display_spec): If the display spec is of the form
3112 `(space ...)', and specifies display in the text area, return 2
3113 rather than 1.
fee65a97 3114 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3115 accurately, and prefer exact match for point under bidi.
3116 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3117
3118 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3119 into disp_prop; all users changed.
3120
3121 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3122 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3123 for the text covered by the display property.
3124
e4ed06f1
CY
31252011-08-25 Chong Yidong <cyd@stupidchicken.com>
3126
3127 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3128 Change return value to nil.
3129 (Frecord_buffer): Delete unused function.
3130
f67cdd7f
EZ
31312011-08-24 Eli Zaretskii <eliz@gnu.org>
3132
5980d4c6
EZ
3133 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3134 buffers, return left-to-right.
8610fe8b
EZ
3135 (set_cursor_from_row): Consider candidate row a win if its glyph
3136 represents a newline and point is on that newline. Fixes cursor
3137 positioning on the newline at EOL of R2L text within L2R
3138 paragraph, and vice versa.
3139 (try_cursor_movement): Check continued rows, in addition to
3140 continuation rows. Fixes unwarranted scroll when point enters a
3141 continued line of R2L text within an L2R paragraph, or vice versa.
3142 (cursor_row_p): Consider the case of point being equal to
3143 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3144 from the end of a short line to the beginning of a continued line
3145 of R2L text within L2R paragraph.
3146 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3147 composed characters.
5980d4c6 3148
f67cdd7f
EZ
3149 * bidi.c (bidi_check_type): Use xassert.
3150 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3151 members.
3152
bca633fb
EZ
31532011-08-23 Eli Zaretskii <eliz@gnu.org>
3154
3155 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3156 a character.
3157
4a5885a7
CY
31582011-08-23 Chong Yidong <cyd@stupidchicken.com>
3159
3160 * nsfont.m (ns_otf_to_script): Fix typo.
3161
0902a04e
KH
31622011-08-22 Kenichi Handa <handa@m17n.org>
3163
3164 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3165 extra slot even if the purpose is char-code-property-table.
3166
1a2e6670
EZ
31672011-08-23 Eli Zaretskii <eliz@gnu.org>
3168
8ddde651
EZ
3169 * xdisp.c (redisplay_window): When computing centering_position,
3170 account for the height of the header line. (Bug#8874)
3171
425cc014
EZ
3172 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3173 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3174 candidate is selected by the mouse, and that candidate has a
3175 composed character under the mouse.
3176
1a2e6670
EZ
3177 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3178 coordinates reported by pos-visible-in-window-p for a composed
3179 character in column zero.
3180
8b76d6f8
SM
31812011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3182
3183 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3184
dac347dd
EZ
31852011-08-22 Eli Zaretskii <eliz@gnu.org>
3186
3187 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3188 consider it a hit if to_charpos is anywhere in the range of the
3189 composed buffer positions.
3190
e013fb34
CY
31912011-08-22 Chong Yidong <cyd@stupidchicken.com>
3192
3193 * image.c (gif_load): Don't assume that each subimage has the same
3194 dimensions as the base image. Handle disposal method that is
3195 "undefined" by the gif spec (Bug#9335).
3196
bd1ba3e8
CY
31972011-08-20 Chong Yidong <cyd@stupidchicken.com>
3198
3199 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3200 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3201
54a1215b
EZ
32022011-08-19 Eli Zaretskii <eliz@gnu.org>
3203
823564e5
EZ
3204 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3205 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3206 from an Org mode buffer to a Speedbar frame.
3207
54a1215b
EZ
3208 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3209 a composition, take its buffer position from IT->cmp_it.charpos.
3210 Fixes cursor positioning at the beginning of a line that begins
3211 with a composed character.
3212
9778ebcc
EZ
32132011-08-18 Eli Zaretskii <eliz@gnu.org>
3214
0be6ee06
EZ
3215 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3216 character bidirectional type, use STRONG_L instead. Fixes crashes
3217 in a buffer produced by `describe-categories'.
3218
9778ebcc
EZ
3219 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3220 members before the level stack, so they would be saved and
3221 restored when copying iterator state. Fixes incorrect reordering
3222 around TABs covered by display properties.
3223
156bffbe
AS
32242011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3225
6b02f655 3226 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3227
72ad093b
CY
32282011-08-17 Chong Yidong <cyd@stupidchicken.com>
3229
3230 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3231 (internal_condition_case_2, internal_condition_case_n):
3232 Remove unnecessary aborts (Bug#9081).
72ad093b 3233
35774242
EZ
32342011-08-17 Eli Zaretskii <eliz@gnu.org>
3235
3236 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3237 has no `load' handler, try opening the file locally. (Bug#9311)
3238
db76dd85
KB
32392011-08-16 Ken Brown <kbrown@cornell.edu>
3240
3241 * gmalloc.c: Expand comment.
3242
b215eee5
EZ
32432011-08-16 Eli Zaretskii <eliz@gnu.org>
3244
3245 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3246 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3247
a4579d33
KB
32482011-08-16 Ken Brown <kbrown@cornell.edu>
3249
3250 Fix memory allocation problems in Cygwin build (Bug#9273).
3251
3252 * unexcw.c ( __malloc_initialized): Declare external variable.
3253 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3254
8b76d6f8
SM
3255 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3256 New variables.
a4579d33
KB
3257 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3258 dumped emacs.
3259 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3260 in the static heap.
3261 [CYGWIN] (special_realloc): New function.
3262 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3263 requests to realloc storage in the static heap.
3264
3ebec551
PE
32652011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3266
3267 * bidi.c (bidi_initialize): Remove unused local.
3268
9fd8be00
EZ
32692011-08-15 Eli Zaretskii <eliz@gnu.org>
3270
6b02f655
SM
3271 * bidimirror.h:
3272 * biditype.h: Remove file.
3273 * makefile.w32-in ($(BLD)/bidi.$(O)):
3274 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3275
3276 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3277
3278 * chartab.c: Improve commentary for the uniprop_table API.
3279
32413314
EZ
3280 * bidi.c (bidi_paragraph_init): Support zero value of
3281 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3282 (bidi_initialize): Use uniprop_table instead of including
3283 biditype.h and bidimirror.h.
32413314 3284
9fd8be00
EZ
3285 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3286 coordinates of the iterator when restoring from ppos_it.
3287 (Bug#9296)
3288
5cf2b69b
KH
32892011-08-14 Kenichi Handa <handa@m17n.org>
3290
3291 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3292 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3293
daf17d00
EZ
32942011-08-14 Eli Zaretskii <eliz@gnu.org>
3295
3296 * xdisp.c (move_it_in_display_line_to): Don't invoke
3297 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3298 ppos_it. Fixes vertical cursor motion when line beginning is
3299 covered by an image. (Bug#9296)
3300
08e3161a
JD
33012011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3302
3303 * nsterm.h (ns_run_ascript): Declare.
3304 (NSAPP_DATA2_RUNASSCRIPT): Define.
3305
3306 * nsfns.m (as_script, as_result, as_status): New static variables.
3307 (ns_run_ascript): New function.
5e617bc2 3308 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3309 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3310 the event loop. Get status from as_status (Bug#7276).
3311
3312 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3313 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3314 the event loop (Bug#7276).
3315
a3720aa2
AS
33162011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3317
3318 * gnutls.c (QCgnutls_bootprop_priority)
3319 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3320 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3321 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3322 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3323 (QCgnutls_bootprop_verify_hostname_error)
3324 (QCgnutls_bootprop_callbacks_verify): Rename from
3325 Qgnutls_bootprop_..., all uses changed.
3326
3327 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3328 uses changed.
3329
0a0d27fb
PE
33302011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3331
19d5c50c
PE
3332 * xfaces.c (Qframe_set_background_mode): Now static.
3333 * dispextern.h (Qframe_set_background_mode): Remove decl.
3334
0a0d27fb
PE
3335 * process.c (Fnetwork_interface_info): Declare local only if needed.
3336
377538cb
JD
33372011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3338
3339 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3340 (Fnetwork_interface_list): Allocate in increments of bytes instead
3341 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3342 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3343 sockaddr.
3344 (struct ifflag_def): notrailers is smart on OSX.
3345 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3346 Get hardware address with getifaddrs if available.
3347
08fff70c
EZ
33482011-08-12 Eli Zaretskii <eliz@gnu.org>
3349
3350 * xdisp.c (iterate_out_of_display_property): xassert that
3351 IT->position is set to within IT->object's boundaries. Break from
3352 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3353 when IT->position is set up wrongly due to some bug.
3354 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3355 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3356 entry. Force push_it to save on the stack the current
3357 buffer/string position, to be restored by pop_it. Fix flags in
3358 the iterator structure wrt the object coming from a display
3359 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3360 properties. (Bug#9284)
3361
7be1c708 33622011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3363
7be1c708
CY
3364 * fontset.c (fontset_get_font_group): Add proper type checks.
3365 (Bug#9172)
aac0c6e3 3366
7be1c708 33672011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3368
7be1c708
CY
3369 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3370 and LC_VERSION_MIN_MACOSX.
3371 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3372 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3373
97bb72a6
EZ
33742011-08-08 Eli Zaretskii <eliz@gnu.org>
3375
3376 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3377 no-display-properties-and-no-overlays under bidi display.
3378 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3379 properties and overlays.
97bb72a6 3380
d5617611
CY
33812011-08-08 Chong Yidong <cyd@stupidchicken.com>
3382
37e11a63
CY
3383 * editfns.c (Fset_time_zone_rule): Document relationship with the
3384 setenv function.
3385
d5617611
CY
3386 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3387 the font entity extracted from the cache (Bug#8109).
3388
58872834
CY
33892011-08-07 Chong Yidong <cyd@stupidchicken.com>
3390
3391 * composite.c (autocmp_chars): Don't reset point. That is done by
3392 restore_point_unwind (Bug#5984).
3393
75bfc667
JL
33942011-08-07 Juri Linkov <juri@jurta.org>
3395
3396 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3397 to show the arg `TIME' instead of `TIMEVAL'.
3398
d1410150
EZ
33992011-08-06 Eli Zaretskii <eliz@gnu.org>
3400
3401 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3402 display property strides EOL and includes a newline, as in
3403 longlines-mode. (Bug#9254)
75b771e4
EZ
3404 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3405 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3406
3407 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3408 is non-zero, even if the data buffer is NULL. Fixes a crash in
3409 vertical-motion with longlines-mode. (Bug#9254)
3410
35928349
EZ
34112011-08-05 Eli Zaretskii <eliz@gnu.org>
3412
ec7cc85b
EZ
3413 * bidi.c <bidi_cache_total_alloc>: Now static.
3414 (bidi_initialize): Initialize bidi_cache_total_alloc.
3415
8b76d6f8 3416 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3417 cache. (Bug#9221)
3418
3419 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3420 amount allocated this far in `bidi_cache_total_alloc'.
3421 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3422 non-zero, only free the data buffer without restoring the cache
3423 contents. All callers changed.
3424
3425 * dispextern.h (bidi_unshelve_cache): Update prototype.
3426
3427 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3428 (move_it_in_display_line, move_it_to)
3429 (move_it_vertically_backward, move_it_by_lines): Replace the call
3430 to xfree to an equivalent call to bidi_unshelve_cache.
3431 (move_it_in_display_line_to): Fix logic of returning
412b6358 3432 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3433
e2e2423b
EZ
34342011-08-05 Eli Zaretskii <eliz@gnu.org>
3435
3436 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3437 came from a string character with a `cursor' property. (Bug#9229)
3438
ae9e757a
JD
34392011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3440
3441 * Makefile.in (LIB_PTHREAD): New variable.
3442 (LIBES): Add LIB_PTHREAD (Bug#9216).
3443
3444 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3445 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3446
213bd7f2
AS
34472011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3448
6b02f655 3449 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3450
99aaf75f
JD
34512011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3452
3453 * xterm.c (x_find_topmost_parent): New function.
3454 (x_set_frame_alpha): Find topmost parent window with
3455 x_find_topmost_parent and set the property there also (bug#9181).
3456 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3457
c74e9d86
PE
34582011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3459
3460 * callproc.c (Fcall_process): Avoid vfork clobbering
3461 the local vars buffer, coding_systems, current_dir.
3462
640c8776
SM
34632011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3464
3465 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3466
f26d0e4c
PE
34672011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3468
8a10d76c
PE
3469 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3470 so that it is not optimized away.
3471
f26d0e4c
PE
3472 * xdisp.c (compute_display_string_pos): Remove unused local.
3473
55439c61
EZ
34742011-08-02 Eli Zaretskii <eliz@gnu.org>
3475
3476 Fix slow cursor motion and scrolling in large buffers with
3477 selective display, like Org Mode buffers. (Bug#9218)
3478
3479 * dispextern.h (struct bidi_it): New member disp_prop_p.
3480
3481 * xdisp.c: Remove one-slot cache of display string positions.
3482 (compute_display_string_pos): Accept an additional argument
5e617bc2 3483 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3484 for a display string or property. If found, set DISP_PROP_P
3485 non-zero.
3486
3487 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3488 DISP_PROP_P, and pass it to compute_display_string_pos.
3489 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3490 non-zero. All callers of bidi_fetch_char changed.
3491
fb33fa43
SM
34922011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3493
3494 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3495
b099e063
DM
34962010-12-03 Don March <don@ohspite.net>
3497
3498 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3499 last character M-[char] is translated to ESC [char] (bug#7541).
3500
5cc7f7af
KH
35012011-08-02 Kenichi Handa <handa@m17n.org>
3502
d0fffa3f 3503 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3504
3505 * chartab.c (uniprop_table): Make it non-static.
3506
525d5e6e
EZ
35072011-08-01 Eli Zaretskii <eliz@gnu.org>
3508
3509 * xdisp.c (forward_to_next_line_start): Accept additional argument
3510 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3511 on the newline.
3512 (reseat_at_next_visible_line_start): Use the bidi iterator state
3513 returned by forward_to_next_line_start to restore the state of
3514 it->bidi_it after backing up to previous newline. (Bug#9212)
3515
31011111
AS
35162011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3517
3518 * regex.c (re_comp): Protoize.
3519 (re_exec): Fix return type.
3520 (regexec): Fix type of `ret'. (Bug#9203)
3521
476371c4
PE
35222011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3523
e5d76069
PE
3524 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3525 This is needed if max-image-size is a floating-point number.
3526
9a79b20c
AS
35272011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3528
3529 * print.c (print_object): Print empty symbol as ##.
3530
3531 * lread.c (read1): Read ## as empty symbol.
3532
d8c2fa78
AA
35332011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3534
3535 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3536 setting frame foreground color (Bug#9175).
3537 (x_set_background_color): Likewise.
3538
ffe57a7a
AA
3539 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3540 contents (Bug#9176).
3541 (EmacsTooltip -init): Remove bezels and add shadows to
3542 tooltip windows.
3543
bf3492a5
AA
3544 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3545 or scroll bar (Bug#8470).
3546
d55e9c53
AA
3547 * nsfont.m (nsfont_open): Remove assignment to voffset and
3548 unnecessary vars hshink, expand, hd, full_height, min_height.
3549 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3550
3551 * nsterm.h (nsfont_info): Remove voffset field.
3552
d8c2fa78 35532011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3554
3555 Implement strike-through and overline on NextStep (Bug#8863).
3556
3557 * nsfont.m (nsfont_open): Use underline position provided by font,
3558 instead of hard-coded value of 2.
3559 (nsfont_draw): Call ns_draw_text_decoration instead.
3560
3561 * nsterm.h: Add declaration for ns_draw_text_decoration.
3562
3563 * nsterm.m (ns_draw_text_decoration): New function for drawing
3564 underline, overline, and strike-through.
3565 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3566 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3567 accommodate underlining, etc.
4843aac3 3568
4cc60b9b
EZ
35692011-07-28 Eli Zaretskii <eliz@gnu.org>
3570
bc7ece87
EZ
3571 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3572 default.
4cc60b9b 3573
476371c4
PE
35742011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3575
66606eea
PE
3576 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3577 Without this fix, if a signal arrives just after memory fills up,
3578 'malloc' might be invoked reentrantly.
3579
476371c4
PE
3580 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3581 In other words, assume that every image size is allowed, on non-X
3582 hosts. This assumption is probably wrong, but it lets Emacs compile.
3583
f3fcc40d
AS
35842011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3585
3586 * regex.c (re_iswctype): Convert return values to boolean.
3587
350c992f
EZ
35882011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3589
3590 * xdisp.c (compute_display_string_pos): Don't use cached display
3591 string position if the buffer had its restriction changed.
3592 (Bug#9184)
3593
5266b4bb
PE
35942011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3595
3596 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3597
2573a837 35982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3599
41f55ccd 3600 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3601
39e378da
PE
3602 * bidi.c: Integer size and overflow fixes.
3603 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3604 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3605 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3606 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3607 (bidi_find_other_level_edge):
3608 Use ptrdiff_t instead of EMACS_INT where either will do.
3609 This works better on 32-bit hosts configured --with-wide-int.
3610 (bidi_cache_ensure_space): Check for size-calculation overflow.
3611 Use % rather than repeated addition, for better worst-case speed.
3612 Don't set bidi_cache_size until after xrealloc returns, because it
3613 might not return.
3614 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3615 (bidi_cache_ensure_space): Also check that the bidi cache size
3616 does not exceed that of the largest Lisp string or buffer. See Eli
3617 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3618
5e927815
PE
3619 * alloc.c (__malloc_size_t): Remove.
3620 All uses replaced by size_t. See Andreas Schwab's note
3621 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3622
ca4aa935
PE
3623 * image.c: Improve checking for integer overflow.
3624 (check_image_size): Assume that f is nonnull, since
3625 it is always nonnull in practice. This is one less thing to
3626 worry about when checking for integer overflow later.
3627 (x_check_image_size): New function, which checks for integer
3628 overflow issues inside X.
3629 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3630 This removes the need for a memory_full check.
3631 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3632 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3633 (xbm_read_bitmap_data): Change locals back to 'int', since
3634 their values must fit in 'int'.
3635 (xpm_load_image, png_load, tiff_load):
3636 Invoke x_create_x_image_and_pixmap earlier,
3637 to avoid much needless work if the image is too large.
3638 (tiff_load): Treat overly large images as if
3639 x_create_x_image_and_pixmap failed, not as malloc failures.
3640 (gs_load): Use x_check_image_size.
3641
5f8f9cc2
PE
3642 * gtkutil.c: Omit integer casts.
3643 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3644 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3645
5adf60bc
PE
3646 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3647
c8907a93
PE
3648 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3649 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3650 would wrongly return t on a 64-bit host.
3651
e3c25c68
PE
3652 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3653 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3654 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3655 and therefore cause GCC to emit a bogus diagnostic in some cases.
3656
3f791afe
PE
3657 * image.c: Integer signedness and overflow and related fixes.
3658 This is not an exhaustive set of fixes, but it's time to
3659 record what I've got.
3660 (lookup_pixel_color, check_image_size): Remove redundant decls.
3661 (check_image_size): Don't assume that arbitrary EMACS_INT values
3662 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3663 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3664 (tiff_load, imagemagick_load_image):
3665 Check for overflow in size calculations.
3666 (x_create_x_image_and_pixmap): Remove unnecessary test for
3667 xmalloc returning NULL; that can't happen.
3668 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3669 (xpm_color_bucket): Use better integer hashing function.
3670 (xpm_cache_color): Don't possibly over-allocate memory.
3671 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3672 (gif_memory_source):
3673 Use ptrdiff_t, not int or size_t, to record sizes.
3674 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3675 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3676 either works, as we prefer signed integers.
3677 (tiff_read_from_memory, tiff_write_from_memory):
3678 Return tsize_t, not size_t, since that's what the TIFF API wants.
3679 (tiff_read_from_memory): Don't fail simply because the read would
3680 go past EOF; instead, return a short read.
3681 (tiff_load): Omit no-longer-needed casts.
3682 (Fimagemagick_types): Don't assume size fits into 'int'.
3683
3cc5a532
PE
3684 Improve hashing quality when configured --with-wide-int.
3685 * fns.c (hash_string): New function, taken from sxhash_string.
3686 Do not discard information about ASCII character case; this
3687 discarding is no longer needed.
3688 (sxhash-string): Use it. Change sig to match it. Caller changed.
3689 * lisp.h: Declare it.
3690 * lread.c (hash_string): Remove, since we now use fns.c's version.
3691 The fns.c version returns a wider integer if --with-wide-int is
3692 specified, so this should help the quality of the hashing a bit.
3693
b312a492
PE
3694 * emacs.c: Integer overflow minor fix.
3695 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3696 Define only if GNU_LINUX.
3697 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3698
dfd153ae
PE
3699 * dispnew.c: Integer signedness and overflow fixes.
3700 Remove unnecessary forward decls, that were a maintenance hassle.
3701 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3702 All uses changed.
3703 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3704 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3705 (prepare_desired_row, line_draw_cost):
3706 Use int, not unsigned, where either works.
3707 (save_current_matrix, restore_current_matrix):
3708 Use ptrdiff_t, not size_t, where either works.
3709 (init_display): Check for overflow more accurately, and without
3710 relying on undefined behavior.
3711
a81d11a3
PE
3712 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3713 Remove, replacing with the new symbols in lisp.h. All uses changed.
3714 * fileio.c (make_temp_name):
3715 * filelock.c (lock_file_1, lock_file):
3716 * xdisp.c (message_dolog):
3717 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3718 Use pMd etc. instead.
3719 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3720 replacing the pWIDE etc. symbols removed from editfns.c.
3721
3300e6fd
PE
3722 * keyboard.h (num_input_events): Now uintmax_t.
3723 This is (very slightly) less likely to mess up due to wraparound.
3724 All uses changed.
3725
fd05c7e9
PE
3726 * buffer.c: Integer signedness fixes.
3727 (alloc_buffer_text, enlarge_buffer_text):
3728 Use ptrdiff_t rather than size_t when either will do, as we prefer
3729 signed integers.
3730
903fe15d
PE
3731 * alloc.c: Integer signedness and overflow fixes.
3732 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3733 (__malloc_size_t): Default to size_t, not to int.
3734 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3735 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3736 Prefer ptrdiff_t to size_t when either would do, as we prefer
3737 signed integers.
3738 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3739 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3740 Now const. Initialize with values that are in range even if char
3741 is signed.
3742 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3743 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3744 These functions do the right thing with sizes > 2**32.
3745 (check_depth): Now ptrdiff_t, not int.
3746 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3747 Adjust to new way of storing sizes. Check for size overflow bugs
3748 in rest of code.
3749 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3750 slightly wrong anyway, as it missed one instance of
3751 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3752 (refill_memory_reserve): Omit needless cast to size_t.
3753 (mark_object_loop_halt): Mark as externally visible.
3754
ac82cc6a
PE
3755 * xselect.c: Integer signedness and overflow fixes.
3756 (Fx_register_dnd_atom, x_handle_dnd_message):
3757 Use ptrdiff_t, not size_t, since we prefer signed.
3758 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3759 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3760 x_dnd_atoms_size and x_dnd_atoms_length.
3761
c2d1e36d
PE
3762 * doprnt.c: Prefer signed to unsigned when either works.
3763 * eval.c (verror):
3764 * doprnt.c (doprnt):
3765 * lisp.h (doprnt):
3766 * xdisp.c (vmessage):
3767 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3768 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3769 prefer signed arithmetic to avoid comparison confusion.
3770 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3771 but is a bit tricky.
3772
0e926e56
PE
3773 Assume freestanding C89 headers, string.h, stdlib.h.
3774 * data.c, doprnt.c, floatfns.c, print.c:
3775 Include float.h unconditionally.
3776 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3777 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3778 * regex.c: Likewise for stddef.h, string.h.
3779 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3780 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3781 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3782 (STDC_HEADERS): Remove obsolete defines.
3783 * sysdep.c: Include limits.h unconditionally.
3784
9cfdb3ec
PE
3785 Assume support for memcmp, memcpy, memmove, memset.
3786 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3787 * regex.c (memcmp, memcpy):
3788 Remove; we assume C89 now.
3789
3790 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3791 (__malloc_safe_bcopy): Remove; no longer needed.
3792
cf950e6b 3793 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3794 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3795 well either way, and we prefer signed to unsigned.
3796
dbf38e02
LMI
37972011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3798
3799 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3800 closes the connection while we're reading (bug#9182).
3801
d6f0886c 38022011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3803
d6f0886c
JD
3804 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3805 are specified (Bug#9168).
24e0f6b1 3806
2eb1f9e6
PE
38072011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3808
3809 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3810 Found by GCC static checking and --with-wide-int on a 32-bit host.
3811
22381272 38122011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3813
3814 * xdisp.c (compute_display_string_pos): Fix logic of caching
3815 previous display string position. Initialize cached_prev_pos to
3816 -1. Fixes slow-down at the beginning of a buffer.
3817
f25e39b4
EZ
38182011-07-24 Eli Zaretskii <eliz@gnu.org>
3819
3820 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3821 for attrs[LFACE_FONTSET_INDEX].
3822
04c4b52e
PE
38232011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3824
3825 * xml.c (parse_region): Remove unused local
3826 that was recently introduced.
3827
c1734fbd
EZ
38282011-07-23 Eli Zaretskii <eliz@gnu.org>
3829
be18c5a5
EZ
3830 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3831 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3832
c1734fbd
EZ
3833 * xdisp.c (move_it_in_display_line_to): Record the best matching
3834 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3835 exit if none of the characters scanned was an exact match.
3836 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3837 when exact match is impossible due to invisible text, and the
3838 lines are truncated.
3839
a258d627
JD
38402011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3841
3842 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3843 for OSX >= 10.7.
3844
b6d5a689
EZ
38452011-07-22 Eli Zaretskii <eliz@gnu.org>
3846
0f74f785
EZ
3847 Fix a significant slow-down of cursor motion with C-n, C-p,
3848 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3849 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3850 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3851 (next_element_from_buffer): Call compute_stop_pos_backwards to
3852 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3853 base_level_stop.
3854 (reseat): Don't look for prev_stop, as that could mean a very long
3855 run.
3856 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3857 <cached_disp_overlay_modiff>: Cache for last found display string
3858 position.
551918c1 3859 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3860 about the same buffer in the same area of character positions, and
3861 the buffer wasn't changed since the time the display string
3862 position was cached.
551918c1 3863
b2d0c91a
EZ
38642011-07-22 Eli Zaretskii <eliz@gnu.org>
3865
3866 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3867 is an integer, which is important for empty lines. (Bug#9149)
3868
043604ee
CY
38692011-07-22 Chong Yidong <cyd@stupidchicken.com>
3870
3871 * frame.c (Fmodify_frame_parameters): In tty case, update the
3872 default face if necessary (Bug#4238).
3873
da4adb04
CY
38742011-07-21 Chong Yidong <cyd@stupidchicken.com>
3875
3876 * editfns.c (Fstring_to_char): No need to explain what a character
3877 is in the docstring (Bug#6576).
3878
9abd0532
LMI
38792011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3880
3881 * xml.c (parse_region): Make sure we always return a tree.
3882
36881d16
HK
38832011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3884
3885 * xml.c (parse_region): If a document contains only comments,
3886 return that, too.
3887
1e98674d
LMI
38882011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3889
3890 * xml.c (make_dom): Return comments, too.
3891
590bd467
PE
38922011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3893
3894 Port to OpenBSD.
3895 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3896 and the surrounding thread.
3897 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3898 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3899 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3900 timer goes off.
3901 * s/openbsd.h (BROKEN_SIGIO): Define.
3902 * unexelf.c (unexec) [__OpenBSD__]:
3903 Don't update the .mdebug section of the Alpha COFF symbol table.
3904
f41628b2
LMI
39052011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3906
3907 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3908 (bug#8460).
3909
b59b67c5
PE
39102011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3911
15e3a074
PE
3912 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3913 This fixes some race conditions on the permissions of any newly
3914 created file.
3915
41bed37d
PE
3916 * alloc.c (valid_pointer_p): Use pipe, not open.
3917 This fixes some permissions issues when debugging.
3918
b59b67c5
PE
3919 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3920 If fchown fails to set both uid and gid, try to set just gid,
3921 as that is sometimes allowed. Adjust the file's mode to eliminate
3922 setuid or setgid bits that are inappropriate if fchown fails.
3923
925a6be7
SM
39242011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3925
3926 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3927 to compare Lisp_Objects.
3928 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3929 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3930 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3931
52968808
AS
39322011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3933
0a6a104b
AS
3934 * lread.c (read_integer): Unread even EOF character.
3935 (read1): Likewise. Properly record start position of symbol.
3936
52968808
AS
3937 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3938 symbol character follows.
3939
9e381cdd
PE
39402011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3941
3942 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3943 This works around a problem with the previous change to Fcopy_file.
3944 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3945 and without this change, GCC might complain about discarding
3946 fchown's return value.
3947
b5641435
JB
39482011-07-16 Juanma Barranquero <lekktu@gmail.com>
3949
3950 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3951
a8031457
PE
39522011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3953
3954 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3955
dd889327
LMI
39562011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3957
750c33f7
LMI
3958 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3959 it's used from the C level.
3960
dd889327
LMI
3961 * process.c: Use the same condition for POLL_FOR_INPUT in both
3962 keyboard.c and process.c (bug#1858).
3963
87e86684
LM
39642011-07-09 Lawrence Mitchell <wence@gmx.li>
3965
3966 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3967 (Fgnutls_boot): Use it.
3968
64348f40
AS
39692011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3970
3971 * doc.c (Fsubstitute_command_keys): Revert last change.
3972
1d698799
LMI
39732011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3974
f863868c
LMI
3975 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3976 quotes the next character, and doesn't affect other longer
3977 sequences (bug#8935).
3978
1d698799
LMI
3979 * lread.c (syms_of_lread): Clarify that is isn't only
3980 `eval-buffer' and `eval-defun' that's affected by
3981 `lexical-binding' (bug#8460).
3982
aa4b6df6
EZ
39832011-07-15 Eli Zaretskii <eliz@gnu.org>
3984
3985 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3986 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3987
5d856da6
PE
39882011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3989
ad6042bb
PE
3990 Fix minor problems found by static checking.
3991 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3992 (elsz): Now a signed constant, not a size_t var. We prefer signed
3993 types to unsigned, to avoid integer comparison confusion. Without
3994 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3995 "cannot optimize loop, the loop counter may overflow", a symptom
3996 of the confusion.
f00bbb22 3997 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3998 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3999
6468f31c
LMI
40002011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4001
49080b10
LMI
4002 * search.c (Fre_search_backward): Mention `case-fold-search' in
4003 all the re_search_* functions (bug#8138).
4004
6468f31c
LMI
4005 * keyboard.c (Fopen_dribble_file): Document when the file is
4006 closed (bug#8056).
4007
c965adc5
EZ
40082011-07-14 Eli Zaretskii <eliz@gnu.org>
4009
df9733bf
EZ
4010 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4011 bidi_cache_idx.
4012
0bb23927
EZ
4013 Support bidi reordering of display and overlay strings.
4014 * xdisp.c (compute_display_string_pos)
4015 (compute_display_string_end): Accept additional argument STRING.
4016 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4017 (reseat_to_string): Initialize bidi_it->string.s and
4018 bidi_it->string.schars.
4019 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4020 NULL (avoids a crash in bidi_paragraph_init).
4021 Initialize itb.string.lstring.
0bb23927
EZ
4022 (init_iterator): Call bidi_init_it only of a valid
4023 buffer position was specified. Initialize paragraph_embedding to
4024 L2R.
4025 (reseat_to_string): Initialize the bidi iterator.
4026 (display_string): If we need to ignore text properties of
4027 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4028 original value of -1 will not work with bidi.)
4029 (compute_display_string_pos): First arg is now struct
4030 `text_pos *'; all callers changed. Support display properties on
4031 Lisp strings.
4032 (compute_display_string_end): Support display properties on Lisp
4033 strings.
4034 (init_iterator, reseat_1, reseat_to_string): Initialize the
4035 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4036 when iterating on a string not from display properties).
640c8776
SM
4037 (compute_display_string_pos, compute_display_string_end):
4038 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4039 arrow keys.
4040 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4041 base_level_stop; instead, set base_level_stop to BEGV.
4042 Fixes crashes in vertical-motion.
0bb23927
EZ
4043 (next_element_from_buffer): Improve commentary for when
4044 the iterator is before prev_stop.
4045 (init_iterator): Initialize bidi_p from the default value of
4046 bidi-display-reordering, not from buffer-local value. Use the
4047 buffer-local value only if initializing for buffer iteration.
4048 (handle_invisible_prop): Support invisible properties on strings
4049 that are being bidi-reordered.
4050 (set_iterator_to_next): Support bidi reordering of C strings and
4051 Lisp strings.
4052 (next_element_from_string): Support bidi reordering of Lisp
4053 strings.
4054 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4055 (display_string): Support display of R2L glyph rows.
4056 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4057 (init_iterator): Don't initialize it->bidi_p for strings
4058 here.
4059 (reseat_to_string): Initialize it->bidi_p for strings here.
4060 (next_element_from_string, next_element_from_c_string)
4061 (next_element_from_buffer): Add xassert's for correspondence
4062 between IT's object being iterated and it->bidi_it.string
4063 structure.
4064 (face_before_or_after_it_pos): Support bidi iteration.
4065 (next_element_from_c_string): Handle the case of the first string
4066 character that is not the first one in the visual order.
4067 (get_visually_first_element): New function, refactored from common
4068 parts of next_element_from_buffer, next_element_from_string, and
4069 next_element_from_c_string.
4070 (tool_bar_lines_needed, redisplay_tool_bar)
4071 (display_menu_bar): Force left-to-right direction. Add a FIXME
4072 comment for making that be controlled by a user option.
4073 (push_it, pop_it): Save and restore the state of the
4074 bidi iterator. Save and restore the bidi_p flag.
4075 (pop_it): Iterate out of display property for string iteration as
4076 well.
4077 (iterate_out_of_display_property): Support iteration over strings.
4078 (handle_single_display_spec): Set up it->bidi_it for iteration
4079 over a display string, and call bidi_init_it.
4080 (handle_single_display_spec, next_overlay_string)
4081 (get_overlay_strings_1, push_display_prop): Set up the bidi
4082 iterator for displaying display or overlay strings.
4083 (forward_to_next_line_start): Don't use the shortcut if
4084 bidi-iterating.
4085 (back_to_previous_visible_line_start): If handle_display_prop
4086 pushed the iterator stack, restore the internal state of the bidi
4087 iterator by calling bidi_pop_it same number of times.
4088 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4089 and we are bidi-iterating, don't decrement the iterator position;
4090 instead, set the first_elt flag in the bidi iterator, to produce
4091 the same effect.
4092 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4093 (push_display_prop): xassert that we are iterating a buffer.
4094 (push_it, pop_it): Save and restore paragraph_embedding member.
4095 (handle_single_display_spec, next_overlay_string)
4096 (get_overlay_strings_1, reseat_1, reseat_to_string)
4097 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4098 correctly. Don't assume unibyte strings are not bidi-reordered.
4099 (compute_display_string_pos)
4100 (compute_display_string_end): Fix handling the case of C string.
4101 (push_it, pop_it): Save and restore from_disp_prop_p.
4102 (handle_single_display_spec, push_display_prop): Set the
4103 from_disp_prop_p flag.
4104 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4105 (pop_it): Call iterate_out_of_display_property only if we are
4106 popping after iteration over a string that came from a display
4107 property. Fix a typo in popping stretch info. Add an assertion
4108 for verifying that the iterator position is in sync with the bidi
4109 iterator.
4110 (handle_single_display_spec, get_overlay_strings_1)
4111 (push_display_prop): Fix initialization of paragraph direction for
4112 string when that of the parent object is not yet determined.
4113 (reseat_1): Call bidi_init_it to resync the bidi
4114 iterator with IT's position. (Bug#7616)
4115 (find_row_edges): If ROW->start.pos gives position
4116 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4117 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4118 Reset the from_disp_prop_p flag.
4119 (SAVE_IT, RESTORE_IT): New macros.
4120 (pos_visible_p, face_before_or_after_it_pos)
4121 (back_to_previous_visible_line_start)
4122 (move_it_in_display_line_to, move_it_in_display_line)
4123 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4124 (try_scrolling, redisplay_window, display_line): Use them when
4125 saving a temporary copy of the iterator and restoring it back.
4126 (back_to_previous_visible_line_start, reseat_1)
4127 (init_iterator): Empty the bidi cache "stack".
4128 (move_it_in_display_line_to): If iterator ended up at
4129 EOL, but we never saw any buffer positions smaller than
4130 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4131 motion in bidi-reordered lines.
4132 (move_it_in_display_line_to): Record prev_method and prev_pos
4133 immediately before the call to set_iterator_to_next. Fixes cursor
4134 motion in bidi-reordered lines with stretch glyphs and strings
4135 displayed in margins. (Bug#8133) (Bug#8867)
4136 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4137 TO_CHARPOS.
640c8776
SM
4138 (pos_visible_p): Support positions in bidi-reordered lines.
4139 Save and restore bidi cache.
0bb23927
EZ
4140
4141 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4142 (bidi_paragraph_info): Delete unused struct.
4143 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4144 (bidi_cache_start): New variable.
4145 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4146 to zero.
4147 (bidi_cache_fetch_state, bidi_cache_search)
4148 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4149 (bidi_cache_find, bidi_peek_at_next_level)
4150 (bidi_level_of_next_char, bidi_find_other_level_edge)
4151 (bidi_move_to_visually_next): Compare cache index with
4152 bidi_cache_start rather than with zero.
4153 (bidi_fetch_char): Accept new argument STRING; all callers
4154 changed. Support iteration over a string. Support strings with
4155 display properties. Support unibyte strings. Fix the type of
4156 `len' according to what STRING_CHAR_AND_LENGTH expects.
4157 (bidi_paragraph_init, bidi_resolve_explicit_1)
4158 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4159 (bidi_level_of_next_char, bidi_move_to_visually_next):
4160 Support iteration over a string.
0bb23927
EZ
4161 (bidi_set_sor_type, bidi_resolve_explicit_1)
4162 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4163 can now be zero (for strings); special values 0 and -1 were
4164 changed to -1 and -2, respectively.
4165 (bidi_char_at_pos): New function.
4166 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4167 Call it instead of FETCH_MULTIBYTE_CHAR.
4168 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4169 initialized to valid values.
4170 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4171 values.
4172 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4173 the test for valid cached positions. Fix the logic for looking up
4174 the sentinel state in the cache. GCPRO the Lisp string we are
4175 iterating.
4176 (bidi_push_it, bidi_pop_it): New functions.
4177 (bidi_initialize): Initialize the bidi cache start stack pointer.
4178 (bidi_cache_ensure_space): New function, refactored from part of
4179 bidi_cache_iterator_state. Don't assume the required size is just
4180 one BIDI_CACHE_CHUNK away.
4181 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4182 (bidi_count_bytes, bidi_char_at_pos): New functions.
4183 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4184 always valid if bidi_cache_idx is valid.
4185 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4186 is valid if it's going to be used.
4187 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4188 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4189 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4190 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4191 (bidi_find_other_level_edge, bidi_cache_start_stack):
4192 All variables related to cache indices are now EMACS_INT.
c965adc5 4193
0bb23927
EZ
4194 * dispextern.h (struct bidi_string_data): New structure.
4195 (struct bidi_it): New member `string'. Make flag members be 1-bit
4196 fields, and put them last in the struct.
640c8776
SM
4197 (compute_display_string_pos, compute_display_string_end):
4198 Update prototypes.
0bb23927
EZ
4199 (bidi_push_it, bidi_pop_it): Add prototypes.
4200 (struct iterator_stack_entry): New members bidi_p,
4201 paragraph_embedding, and from_disp_prop_p.
4202 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4203 (bidi_shelve_cache, bidi_unshelve_cache):
4204 Declare prototypes.
0bb23927
EZ
4205
4206 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4207 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4208 and vector-like objects.
4209
4210 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4211 cache around display iteration.
4212
4213 * window.c (Fwindow_end, window_scroll_pixel_based)
4214 (displayed_window_lines, Frecenter): Save and restore the bidi
4215 cache around display iteration.
4216
3bbd2265
LMI
42172011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4218
4219 * editfns.c (Fdelete_region): Clarify the use of the named
4220 parameters (bug#6788).
4221
adc47434
MR
42222011-07-14 Martin Rudalics <rudalics@gmx.at>
4223
4224 * indent.c (Fvertical_motion): Set and restore w->pointm when
4225 saving and restoring the window's buffer (Bug#9006).
4226
837c31f8
LMI
42272011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4228
4229 * editfns.c (Fstring_to_char): Clarify just what is returned
4230 (bug#6576). Text by Eli Zaretskii.
4231
ac389d0c
JB
42322011-07-13 Juanma Barranquero <lekktu@gmail.com>
4233
4234 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4235
0be0ce47
EZ
42362011-07-13 Eli Zaretskii <eliz@gnu.org>
4237
4238 * buffer.c (mmap_find): Fix a typo.
4239
cd18e7e3
JB
42402011-07-13 Johan Bockgård <bojohan@gnu.org>
4241
4242 Fix execution of x selection hooks.
4243 * xselect.c (Qx_lost_selection_functions)
4244 (Qx_sent_selection_functions): New vars.
4245 (syms_of_xselect): DEFSYM them.
4246 (x_handle_selection_request): Pass Qx_sent_selection_functions
4247 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4248 (x_handle_selection_clear,x_clear_frame_selections):
4249 Pass Qx_lost_selection_functions rather than
4250 Vx_lost_selection_functions to Frun_hook_with_args.
4251
47ea7f44
PE
42522011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4253
ac389d0c 4254 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4255 The old code sometimes used this field without initializing it.
4256
47ea7f44
PE
4257 * alloc.c (gc_sweep): Don't read past end of array.
4258 In theory, the old code could also have corrupted Emacs internals,
4259 though it'd be very unlikely.
4260
bc985c87
AS
42612011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4262
4263 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4264 argument. (Bug#4026)
bc985c87 4265
0cf34688
LMI
42662011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4267
b3dadd76
LMI
4268 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4269 key" (bug#4257).
4270
0cf34688
LMI
4271 * window.c (Fset_window_start): Doc fix (bug#4199).
4272 (Fset_window_hscroll): Ditto.
4273
270768cd
PE
42742011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4275
077e3dda 4276 Fix minor new problems caught by GCC 4.6.1.
270768cd 4277 * term.c (init_tty): Remove unused local.
490011a6 4278 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4279 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4280 not used otherwise.
270768cd 4281
b1f58454
CY
42822011-07-12 Chong Yidong <cyd@stupidchicken.com>
4283
4284 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4285
22b9578d
LMI
42862011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4287
6e70ab07
LMI
4288 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4289 are the mini-buffer and the echo area (bug#3320).
4290
22b9578d
LMI
4291 * term.c (init_tty): Remove support for supdup, c10 and perq
4292 terminals, which are no longer supported (bug#1482).
4293
8974cc9f
JB
42942011-07-10 Johan Bockgård <bojohan@gnu.org>
4295
4296 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4297
a560d974
JD
42982011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4299
4300 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4301 for non-popups (Bug#3642).
4302
1dae0f0a
AS
43032011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4304
268c2c36 4305 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4306 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4307 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4308 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4309 * data.c (fmod): Likewise.
4310 * dispnew.c (swap_glyphs_in_rows): Likewise.
4311 * emacs.c (memory_warning_signal): Likewise.
4312 * floatfns.c (float_error): Likewise.
4313 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4314 (otf_open, font_otf_capability, generate_otf_features)
4315 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4316 Likewise.
4317 * image.c (pbm_read_file): Likewise.
4318 * indent.c (string_display_width): Likewise.
4319 * intervals.c (check_for_interval, search_for_interval)
4320 (inc_interval_count, count_intervals, root_interval)
4321 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4322 * lread.c (defalias): Likewise.
268c2c36 4323 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4324 * regex.c (set_image_of_range_1, set_image_of_range)
4325 (regex_grow_registers): Likewise.
4326 * sysdep.c (strerror): Likewise.
4327 * termcap.c (valid_filename_p, tprint, main): Likewise.
4328 * tparam.c (main): Likewise.
4329 * unexhp9k800.c (run_time_remap, save_data_space)
4330 (update_file_ptrs, read_header, write_header, calculate_checksum)
4331 (copy_file, copy_rest, display_header): Likewise.
4332 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4333 Likewise.
4334 * xdisp.c (check_it): Likewise.
4335 * xfaces.c (register_color, unregister_color, unregister_colors):
4336 Likewise.
4337 * xfns.c (print_fontset_result): Likewise.
4338 * xrdb.c (member, fatal, main): Likewise.
4339
99033785
PE
43402011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4341
4342 Fix minor problems found by static checking (Bug#9031).
4343 * chartab.c (char_table_set_range, map_sub_char_table):
4344 Remove unused locals.
4345 (uniprop_table): Now static.
4346 * composite.c (_work_char): Remove unused static var.
4347
9cb2ac56
JB
43482011-07-09 Juanma Barranquero <lekktu@gmail.com>
4349
4350 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4351
f25661f0
JD
43522011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4353
4354 * gtkutil.c (qttip_cb): Remove code without function.
4355
8278c4fe
EZ
43562011-07-09 Eli Zaretskii <eliz@gnu.org>
4357
4358 * w32.c (pthread_sigmask): New stub.
4359
1692ae2d 43602011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4361
8a6ebd58 4362 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4363 sigprocmask is portable only for single-threaded applications, and
4364 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4365 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4366 (LIBES): Use it.
4367 * callproc.c (Fcall_process):
4368 * process.c (create_process):
4369 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4370 Use pthread_sigmask, not sigprocmask.
123403e4 4371
1b854618
JD
43722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4373
4374 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4375 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4376 wrong (Bug#8591).
4377
3fe4b549
JD
43782011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4379
0ce7e563
JD
4380 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4381 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4382 (xg_hide_tooltip): Fix comment.
4383
3fe4b549
JD
4384 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4385 in registerServicesMenuSendTypes.
4386 (validRequestorForSendType): Don't check ns_return_types.
4387
4388 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4389 ns_return_type.
4390
5df75e47
JR
43912011-07-08 Jason Rumney <jasonr@gnu.org>
4392
22610910
JR
4393 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4394 SH_SHOW for hidden windows (Bug#5482).
4395
5df75e47
JR
4396 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4397 frame struct members of non-existent frames (Bug#6284).
4398
699c10bd
JD
43992011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4400
4393663b
JD
4401 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4402 variable firstTime not needed on OSX >= 10.6.
4403 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4404 >= 10.5. Use setKnobProportion, setDoubleValue.
4405
4406 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4407 (MAC_OS_X_VERSION_10_5): Define if not defined.
4408 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4409 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4410 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4411
4412 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4413 cString and lossyCString on OSX >= 10.4
4414
58179cce 4415 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4416 sizeToFit on OSX >= 10.2.
4417
4418 * nsimage.m (allocInitFromFile): Don't use deprecated method
4419 bestRepresentationForDevice on OSX >= 10.6.
4420
4421 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4422 to avoid warning.
4423
4424 * emacs.c: Declare unexec_init_emacs_zone.
4425
a63e0781
JD
4426 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4427
699c10bd
JD
4428 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4429
4430 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4431 on svcsMenu (Bug#8842).
4432
4433 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4434 ns_return_types.
4435 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4436
4437 * nsterm.m (QUTF8_STRING): Declare.
4438 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4439 (validRequestorForSendType): Return type is (id).
4440 Change indexOfObjectIdenticalTo to indexOfObject.
4441 Check if we have local selection before returning self (Bug#8842).
4442 (writeSelectionToPasteboard): Put local selection into paste board
4443 if we have a local selection (Bug#8842).
4444 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4445
4446 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4447 (ns_get_local_selection): Declare.
4448
54e10184
LMI
44492011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4450
9888ff71
LMI
4451 * keymap.c (describe_map_tree): Don't insert a double newline at
4452 the end of the buffer (bug#1169) and return whether we inserted
4453 something.
4454
54e10184
LMI
4455 * callint.c (Fcall_interactively): Change "reading args" to
4456 "providing args" to try to clarify what it does (bug#1010).
4457
15fa4783
KH
44582011-07-07 Kenichi Handa <handa@m17n.org>
4459
4460 * composite.c (composition_compute_stop_pos): Ignore a static
4461 composition starting before CHARPOS (Bug#8915).
4462
4463 * xdisp.c (handle_composition_prop): Likewise.
4464
a8815b00
EZ
44652011-07-07 Eli Zaretskii <eliz@gnu.org>
4466
4467 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4468 (Bug#9015)
4469
ef7b981d 44702011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4471
4472 * character.h (unicode_category_t): New enum type.
4473
4474 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4475 (Qchar_code_property_table): New variable.
4476 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4477 (UNIPROP_COMPRESSED_FORM_P): New macros.
4478 (char_table_ascii): Uncompress the compressed values.
4479 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4480 Uncompress the compressed values.
ac389d0c 4481 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4482 (char_table_ref_and_range): Uncompress the compressed values.
4483 (sub_char_table_set): New arg is_uniprop. Callers changed.
4484 Uncompress the compressed values.
4485 (sub_char_table_set_range): Args changed. Callers changed.
4486 (char_table_set_range): Adjuted for the above change.
4487 (map_sub_char_table): Delete args default_val and parent. Add arg
4488 top. Give decoded values to a Lisp function.
640c8776 4489 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4490 values to a Lisp function. Gcpro more variables.
4491 (uniprop_table_uncompress)
4492 (uniprop_decode_value_run_length): New functions.
4493 (uniprop_decoder, uniprop_decoder_count): New variables.
4494 (uniprop_get_decoder, uniprop_encode_value_character)
4495 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4496 New functions.
4497 (uniprop_encoder, uniprop_encoder_count): New variables.
4498 (uniprop_get_encoder, uniprop_table)
4499 (Funicode_property_table_internal, Fget_unicode_property_internal)
4500 (Fput_unicode_property_internal): New functions.
4501 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4502 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4503 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4504 char-code-property-alist.
4505
640c8776 4506 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4507 Vunicode_category_table.
4508
640c8776 4509 * font.c (font_range): Adjust for the change of
c805dec0
KH
4510 Vunicode_category_table.
4511
76b397fb
DN
45122011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4513
4514 * m/iris4d.h: Remove file, move contents ...
4515 * s/irix6-5.h: ... here.
4516
22b4128e
PE
45172011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4518
4519 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4520 * alloc.c (mark_buffer):
4521 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4522 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4523 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4524 This isn't true in general, and it's particularly not true
4525 if Emacs is configured with --with-wide-int.
4526 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4527 New macros, used in the buffer.c change.
4528
869795d6
JD
45292011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4530
4531 * xsettings.c: Use both GConf and GSettings if both are available.
4532 (store_config_changed_event): Add comment.
4533 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4534 (store_tool_bar_style_changed): New functions.
5e617bc2 4535 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4536 (struct xsettings): Move font inside HAVE_XFT.
4537 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4538 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4539 Move inside HAVE_XFT.
640c8776 4540 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4541 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4542 also.
4543 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4544 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4545 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4546 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4547 (parse_settings): Move check for font inside HAVE_XFT.
4548 (read_settings, apply_xft_settings): Add comment.
4549 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4550 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4551 call store_font_name_changed.
4552 (xft_settings_event): Add comment.
4553 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4554 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4555 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4556 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4557 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4558 (xsettings_get_system_font, xsettings_get_system_normal_font):
4559 Add comment.
869795d6 4560
d8ed26bd
PE
45612011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4562
4563 Random fixes. E.g., (random) never returned negative values.
4564 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4565 subseconds part to the entropy, as that's a bit more random.
4566 Prefer signed to unsigned, since the signedness doesn't matter and
4567 in general we prefer signed. When given a limit, use a
4568 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4569 latter isn't right if USE_2_TAGS_FOR_INTS.
4570 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4571 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4572
cabf1cac
SM
45732011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4574
4575 * textprop.c (text_property_stickiness):
4576 Obey Vtext_property_default_nonsticky.
4577 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4578 * w32fns.c (syms_of_w32fns):
4579 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4580
6e9b2be9
PE
45812011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4582
4583 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4584 This is more efficient than Ffile_directory_p and avoids a minor race.
4585
90186c68
LMI
45862011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4587
7c301272
LMI
4588 * buffer.c (Foverlay_put): Say what the return value is
4589 (bug#7835).
4590
c4f2d8d4
LMI
4591 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4592 is a directory before asking whether to use the file name
4593 (bug#7564).
ad637907
LMI
4594 (barf_or_query_if_file_exists): Make the "File is a directory"
4595 error be more correct.
c4f2d8d4 4596
90186c68
LMI
4597 * fns.c (Frequire): Remove the mention of the .gz files, since
4598 that's installation-specific, but keep the mention of
4599 `get-load-suffixes'.
4600
da64016e
PE
46012011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4602
4603 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4604 Report string overflow if the output is too long.
4605
7d47b580
JB
46062011-07-04 Juanma Barranquero <lekktu@gmail.com>
4607
a555cb87
JB
4608 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4609 (syms_of_gnutls): Remove duplicate DEFSYM for
4610 Qgnutls_bootprop_verify_hostname_error, an error for
4611 Qgnutls_bootprop_verify_error (which is no longer used).
4612
7d47b580
JB
4613 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4614 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4615 Also (re)move comments that are misplaced or no longer relevant.
4616
1e49bfab
LMI
46172011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4618
4619 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4620
1485f4c0
CY
46212011-07-03 Chong Yidong <cyd@stupidchicken.com>
4622
4623 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4624 and background color parameters if they have been changed.
4625
a9ab721e
LMI
46262011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4627
4628 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4629
cf7cff57
PE
46302011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4631
2e13213d
PE
4632 * xsettings.c (SYSTEM_FONT): Define only when used.
4633 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4634
cf7cff57
PE
4635 * keymap.c (access_keymap_1): Now static.
4636
7a8e04f7
CY
46372011-07-02 Chong Yidong <cyd@stupidchicken.com>
4638
4639 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4640 leave any prefix arg for the up event (Bug#1586).
4641
61352f62
LMI
46422011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4643
69bb1ef7
LMI
4644 * lread.c (syms_of_lread): Mention single symbols defined by
4645 `defvar' or `defconst' (bug#7154).
4646
61352f62 4647 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4648 (Frequire): Mention get-load-suffixes.
61352f62 4649
28545e04
MR
46502011-07-02 Martin Rudalics <rudalics@gmx.at>
4651
4652 * window.h (window): Remove clone_number slot.
4653 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4654 Remove.
4655 (make_parent_window, make_window, saved_window)
4656 (Fset_window_configuration, save_window_save): Don't deal with
4657 clone numbers.
4658 * buffer.c (Qclone_number): Remove declaration.
4659 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4660
3349e122
SM
46612011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4662
4663 Add multiple inheritance to keymaps.
4664 * keymap.c (Fmake_composed_keymap): New function.
4665 (Fset_keymap_parent): Simplify.
4666 (fix_submap_inheritance): Remove.
4667 (access_keymap_1): New function extracted from access_keymap to handle
4668 embedded parents and handle lists of maps.
4669 (access_keymap): Use it.
4670 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4671 (Fcopy_keymap): Handle embedded parents.
4672 (Fcommand_remapping, define_as_prefix): Simplify.
4673 (Fkey_binding): Simplify.
4674 (syms_of_keymap): Move minibuffer-local-completion-map,
4675 minibuffer-local-filename-completion-map,
4676 minibuffer-local-must-match-map, and
4677 minibuffer-local-filename-must-match-map to Elisp.
4678 (syms_of_keymap): Defsubr make-composed-keymap.
4679 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4680 (parse_menu_item): Trivial simplification.
4681
3279eb87
GM
46822011-07-01 Glenn Morris <rgm@gnu.org>
4683
4684 * Makefile.in (SETTINGS_LIBS): Fix typo.
4685
4550efdf
KI
46862011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4687
4688 * coding.c (Fencode_coding_string): Record the last coding system
4689 used, as the function doc string says (bug#8738).
4690
0949d2b6
JD
46912011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4692
4693 * xsettings.c (store_monospaced_changed): Take new font as arg and
4694 check for change against current_mono_font.
4695 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4696 (emacs_settings_constructor, emacs_settings_get_property)
4697 (emacs_settings_set_property, emacs_settings_class_init)
4698 (emacs_settings_init, gsettings_obj): Remove.
4699 (something_changedCB): New function for HAVE_GSETTINGS.
4700 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4701 with value as argument.
4702 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4703 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4704 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4705 "changed".
4706
4707 * xgselect.c: Add defined (HAVE_GSETTINGS).
4708 (xgselect_initialize): Ditto.
4709
4710 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4711 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4712 xg_select.
4713
bbc6b304
PE
47142011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4715
4716 * eval.c (struct backtrace): Simplify and port the data structure.
4717 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4718 signed bit field, as this assumption is not portable and it makes
4719 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4720 "char debug_on_exit : 1" as this is not portable either; instead,
4721 use the portable "unsigned int debug_on_exit : 1". Remove unused
4722 member evalargs. Remove obsolete comments about cc bombing out.
4723
9851bfc5
JD
47242011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4725
51bb811f 4726 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4727 Let HAVE_GSETTINGS override HAVE_GCONF.
4728 (store_monospaced_changed): New function.
4729 (EMACS_SETTINGS): A new type derived from GObject to handle
4730 GSettings notifications.
4731 (emacs_settings_constructor, emacs_settings_get_property)
4732 (emacs_settings_set_property, emacs_settings_class_init):
4733 New functions.
4734 (gsettings_client, gsettings_obj): New variables.
4735 (GSETTINGS_SCHEMA): New define.
4736 (something_changedCB): Call store_monospaced_changed.
4737 (init_gsettings): New function.
4738 (xsettings_initialize): Call init_gsettings.
4739 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4740 to NULL.
4741
640c8776 4742 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4743 GCONF_CFLAGS/LIBS.
4744
5386012d
MR
47452011-06-29 Martin Rudalics <rudalics@gmx.at>
4746
4747 * window.c (resize_root_window, grow_mini_window)
4748 (shrink_mini_window): Rename Qresize_root_window to
4749 Qwindow_resize_root_window and Qresize_root_window_vertically to
4750 Qwindow_resize_root_window_vertically.
4751
f13e0b08
PE
47522011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4753
4754 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4755
94515237
JB
47562011-06-27 Juanma Barranquero <lekktu@gmail.com>
4757
4758 * makefile.w32-in: Redesign dependencies so they reflect more
4759 clearly which files are directly included by each source file,
4760 and not through other includes.
4761
e43b6e43
MR
47622011-06-27 Martin Rudalics <rudalics@gmx.at>
4763
4764 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4765 (sort_overlays, overlay_strings): When an overlay's clone number
4766 matches the window's clone number process the overlay even if
4767 the overlay's window property doesn't match the current window.
4768
d68443dc
MR
4769 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4770 (Fwindow_hchild): Rename to Fwindow_left_child.
4771 (Fwindow_next): Rename to Fwindow_next_sibling.
4772 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4773 (resize_window_check): Rename to window_resize_check.
4774 (resize_window_apply): Rename to window_resize_apply.
4775 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4776 (Fdelete_other_windows_internal, resize_frame_windows)
4777 (Fsplit_window_internal, Fdelete_window_internal)
4778 (grow_mini_window, shrink_mini_window)
4779 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4780
c7e73be5
JD
47812011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4782
4783 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4784 (emacs_fixed_set_min_size): Remove.
4785 (emacs_fixed_new): Take frame as argument.
4786
4787 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4788 (_EmacsFixedPrivate): Remove minwidth/height.
4789 Add struct frame *f.
4790 (emacs_fixed_init): Initialize priv->f.
4791 (get_parent_class, emacs_fixed_set_min_size): Remove.
4792 (emacs_fixed_new): Set priv->f to argument.
4793 (emacs_fixed_get_preferred_width)
4794 (emacs_fixed_get_preferred_height): Use min_width/height from
4795 frames size_hint to set minimum and natural (Bug#8919).
4796 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4797 and use min_width/height from frames size_hint to set
4798 min_width/height (Bug#8919).
4799
4800 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4801 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4802 Fix indentation.
c7e73be5 4803
cf99dcf8
EZ
48042011-06-26 Eli Zaretskii <eliz@gnu.org>
4805
4806 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4807 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4808 called at ZV.
4809
029529ac
CY
48102011-06-26 Chong Yidong <cyd@stupidchicken.com>
4811
4812 * process.c (wait_reading_process_output): Bypass select if
4813 waiting for a cell while ignoring keyboard input, and input is
4814 pending. Suggested by Jan Djärv (Bug#8869).
4815
7a7ef429
PE
48162011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4817
4818 Use gnulib's dup2 module instead of rolling our own.
4819 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4820
11fdef7d 48212011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4822
4823 * dispnew.c (scrolling_window): Before scrolling, turn off a
4824 mouse-highlight in the window being scrolled.
4825
cd3520a4
JB
48262011-06-24 Juanma Barranquero <lekktu@gmail.com>
4827
4828 Move DEFSYM to lisp.h and use everywhere.
4829
4830 * character.h (DEFSYM): Move declaration...
4831 * lisp.h (DEFSYM): ...here.
4832
4833 * gnutls.c:
4834 * minibuf.c:
4835 * w32menu.c:
4836 * w32proc.c:
4837 * w32select.c: Don't include character.h.
4838
4839 * alloc.c (syms_of_alloc):
4840 * buffer.c (syms_of_buffer):
4841 * bytecode.c (syms_of_bytecode):
4842 * callint.c (syms_of_callint):
4843 * casefiddle.c (syms_of_casefiddle):
4844 * casetab.c (init_casetab_once):
4845 * category.c (init_category_once, syms_of_category):
4846 * ccl.c (syms_of_ccl):
4847 * cmds.c (syms_of_cmds):
4848 * composite.c (syms_of_composite):
4849 * dbusbind.c (syms_of_dbusbind):
4850 * dired.c (syms_of_dired):
4851 * dispnew.c (syms_of_display):
4852 * doc.c (syms_of_doc):
4853 * editfns.c (syms_of_editfns):
4854 * emacs.c (syms_of_emacs):
4855 * eval.c (syms_of_eval):
4856 * fileio.c (syms_of_fileio):
4857 * fns.c (syms_of_fns):
4858 * frame.c (syms_of_frame):
4859 * fringe.c (syms_of_fringe):
4860 * insdel.c (syms_of_insdel):
4861 * keymap.c (syms_of_keymap):
4862 * lread.c (init_obarray, syms_of_lread):
4863 * macros.c (syms_of_macros):
4864 * msdos.c (syms_of_msdos):
4865 * print.c (syms_of_print):
4866 * process.c (syms_of_process):
4867 * search.c (syms_of_search):
4868 * sound.c (syms_of_sound):
4869 * syntax.c (init_syntax_once, syms_of_syntax):
4870 * terminal.c (syms_of_terminal):
4871 * textprop.c (syms_of_textprop):
4872 * undo.c (syms_of_undo):
4873 * w32.c (globals_of_w32):
4874 * window.c (syms_of_window):
4875 * xdisp.c (syms_of_xdisp):
4876 * xfaces.c (syms_of_xfaces):
4877 * xfns.c (syms_of_xfns):
4878 * xmenu.c (syms_of_xmenu):
4879 * xsettings.c (syms_of_xsettings):
4880 * xterm.c (syms_of_xterm): Use DEFSYM.
4881
4228cf16
TZ
48822011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4883
cd3520a4 4884 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4885
7fcccf1e
PE
48862011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4887
7efb4e0e
PE
4888 Integer and buffer overflow fixes (Bug#8873).
4889
ff5844ad
PE
4890 * print.c (printchar, strout): Check for string overflow.
4891 (PRINTPREPARE, printchar, strout):
4892 Don't set size unless allocation succeeds.
4893
90532f02
PE
4894 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4895 for sizes. Check for string overflow more accurately.
4896 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4897
6d84508d
PE
4898 * macros.c: Integer and buffer overflow fixes.
4899 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4900 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4901 Use ptrdiff_t, not int, for sizes.
4902 Don't increment bufsize until after realloc succeeds.
4903 Check for size-calculation overflow.
4904 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4905
437b2cb4
PE
4906 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4907
8b9ac8b4
PE
4908 * lread.c: Integer overflow fixes.
4909 (read_integer): Radix is now EMACS_INT, not int,
4910 to improve quality of diagnostics for out-of-range radices.
4911 Calculate buffer size correctly for out-of-range radices.
4912 (read1): Check for integer overflow in radices, and in
4913 read-circle numbers.
82cb60d3
PE
4914 (read_escape): Avoid int overflow.
4915 (Fload, openp, read_buffer_size, read1)
4916 (substitute_object_recurse, read_vector, read_list, map_obarray):
4917 Use ptrdiff_t, not int, for sizes.
4918 (read1): Use EMACS_INT, not int, for sizes.
20270765 4919 Check for size overflow.
8b9ac8b4 4920
7fcccf1e
PE
4921 * image.c (cache_image): Check for size arithmetic overflow.
4922
bfbbd7e7
PE
4923 * lread.c: Integer overflow issues.
4924 (saved_doc_string_size, saved_doc_string_length)
4925 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4926 Now ptrdiff_t, not int.
4927 (read1): Don't assume doc string length fits in int. Check for
4928 out-of-range doc string lengths.
4929 (read_list): Don't assume file position fits in int.
39019e54 4930 (read_escape): Check for hex character overflow.
bfbbd7e7 4931
4e323265
LL
49322011-06-22 Leo Liu <sdl.web@gmail.com>
4933
4934 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4935 Move to minibuffer.el.
4936
85fece3e
PE
49372011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4938
20b84ce9 4939 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4940 The following patches are for when GLYPH_DEBUG && !XASSERT.
4941 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4942 * dispnew.c (flush_stdout):
4943 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4944 Mark as externally visible.
4945 * dispnew.c (check_window_matrix_pointers): Now static.
4946 * dispnew.c (window_to_frame_vpos):
4947 * xfns.c (unwind_create_frame):
4948 * xterm.c (x_check_font): Remove unused local.
4949 * scroll.c (CHECK_BOUNDS):
4950 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4951 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4952 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4953 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4954 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4955 Now static.
4956 (debug_method_add): Use va_list and vsprintf rather than relying
4957 on undefined behavior with wrong number of arguments.
4958 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4959 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4960 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4961 since we're not interested in debugging glyphs with old libraries.
4962 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4963 GCC 4.6.0's static checking.
4964
0766b489
PE
49652011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4966
31fd4b32
PE
4967 Integer overflow and signedness fixes (Bug#8873).
4968 A few related buffer overrun fixes, too.
4969
b79e8648
PE
4970 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4971
0766b489
PE
4972 * dispextern.h (struct face.stipple):
4973 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4974 (x_bitmap_mask, x_allocate_bitmap_record)
4975 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4976 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4977 (x_create_bitmap_from_xpm_data):
4978 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4979 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4980 (.bitmaps_last):
4981 * xfaces.c (load_pixmap):
4982 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4983 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4984 (.bitmaps_last, struct x_output.icon_bitmap):
4985 Use ptrdiff_t, not int, for bitmap indexes.
4986 (x_allocate_bitmap_record): Check for size overflow.
4987 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4988
b081724f
PE
4989 Use ptrdiff_t, not int, for overlay counts.
4990 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4991 * editfns.c (overlays_around, get_pos_property):
4992 * textprop.c (get_char_property_and_overlay):
4993 * xdisp.c (next_overlay_change, note_mouse_highlight):
4994 * xfaces.c (face_at_buffer_position):
21514da7
PE
4995 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4996 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4997 (Fnext_overlay_change, Fprevious_overlay_change)
4998 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4999 Use ptrdiff_t, not int, for sizes.
21514da7 5000 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5001
3de73e5e
PE
5002 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5003
2606c57b
PE
5004 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5005 (x_session_initialize): Do not assume string length fits in int.
5006
aaafe47a
PE
5007 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5008 This is unlikely, but can occur if DPI is outlandish.
5009
2674ddc8 5010 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5011 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5012
28154962
PE
5013 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5014 * xrdb.c (magic_file_p, search_magic_path):
5015 Omit last arg SUFFIX; it was always 0. All callers changed.
5016 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5017
7de51af5
PE
5018 * xfont.c (xfont_match): Avoid need for strlen.
5019
25ed6cc3
PE
5020 * xfns.c: Don't assume strlen fits in int.
5021 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5022
4eab31dd
PE
5023 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5024 not unsigned long, as we prefer signed integers. All callers changed.
5025 Detect integer overflow in repeat count.
5026 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5027 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5028
171e2a58
PE
5029 * termcap.c: Don't assume sizes fit in int and never overflow.
5030 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5031 (gobble_line): Check for size-calculation overflow.
5032
ad39faca 5033 * minibuf.c (Fread_buffer):
6e5bb2dc 5034 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5035 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5036 Don't assume string length fits in int.
5037
52c61c22 5038 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5039 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5040
b5b8c9e5
PE
5041 * font.c: Don't assume string length fits in int.
5042 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5043 Use ptrdiff_t, not int.
ccd6111c
PE
5044 (font_intern_prop): Don't assume string length fits in int.
5045 Don't assume integer property fits in fixnum.
5046 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5047
882f0d81 5048 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5049 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5050 Reformulate so as not to need the command string.
5051 Invoke gzip -cd rather than gunzip, as it's more portable.
5052 (lock_info_type, lock_file_1, lock_file):
5053 Don't assume pid_t and time_t fit in unsigned long.
5054 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5055 (current_lock_owner): Prefer signed type for sizes.
5056 Use memcpy, not strncpy, where memcpy is what is really wanted.
5057 Don't assume (via atoi) that time_t and pid_t fit in int.
5058 Check for time_t and/or pid_t out of range, e.g., via a network share.
5059 Don't alloca where an auto var works fine.
5060
93f4cf88
PE
5061 * fileio.c: Fix some integer overflow issues.
5062 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5063 Don't assume string length fits in int.
5064 (directory_file_name): Don't assume string length fits in long.
5065 (make_temp_name): Don't assume pid fits in int, or that its print
5066 length is less than 20.
5067
f3e92b69
PE
5068 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5069
1bfdaf10
PE
5070 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5071
35016e9a
PE
5072 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5073
3d1e65a1
PE
5074 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5075 We prefer signed integers, even for size calculations.
5076
0b963a93
PE
5077 * emacs.c: Don't assume string length fits in 'int'.
5078 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5079 (main): Don't invoke strlen when not needed.
5080
573f4b54
PE
5081 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5082 (XD_DEBUG_MESSAGE): Don't waste a byte.
5083
989f33ba
PE
5084 * callproc.c (getenv_internal_1, getenv_internal)
5085 (Fgetenv_internal):
965d34eb
PE
5086 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5087
e4d29b33
PE
5088 * lread.c (invalid_syntax): Omit length argument.
5089 All uses changed. This doesn't fix a bug, but it simplifies the
5090 code away from its former Hollerith-constant appearance, and it's
5091 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5092 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5093
eb49b136
PE
5094 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5095 This didn't break anything, but it didn't help either.
5096 It's confusing to put a bogus integer in a place where the actual
5097 value does not matter.
9f62aeb1 5098 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5099 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5100
15375a22
PE
5101 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5102 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5103 implementation.
b61cc01c
PE
5104 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5105 We prefer signed types, and the value cannot exceed the EMACS_INT
5106 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5107 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5108 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5109 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5110
53b2623d
PE
5111 * indent.c (sane_tab_width): New function.
5112 (current_column, scan_for_column, Findent_to, position_indentation)
5113 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5114 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5115
51cab52b 5116 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5117
f2ed8a70
PE
5118 * lisp.h (lint_assume): New macro.
5119 * composite.c (composition_gstring_put_cache):
5120 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5121
abe80cc6
PE
5122 * editfns.c, insdel.c:
5123 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5124
b02c740e
PE
5125 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5126
ebc96716
PE
5127 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5128
b4e50fa0 5129 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5130 Use much-faster test for byte-length change.
311d5d7c 5131 Don't assume string byte-length fits in 'int'.
a4cf38e4 5132 Check that character arg fits in 'int'.
85461888 5133 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5134
c0c1ee9f
PE
5135 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5136
a498d7f4
PE
5137 * fns.c (concat): Catch string overflow earlier.
5138 Do not rely on integer wraparound.
5139
51cab52b
PE
5140 * dispextern.h (struct it.overlay_strings_charpos)
5141 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5142 * xdisp.c (forward_to_next_line_start)
5143 (back_to_previous_visible_line_start)
5144 (reseat_at_next_visible_line_start, next_element_from_buffer):
5145 Don't arbitrarily truncate the value of 'selective' to int.
5146
76031fad
PE
5147 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5148
5eb55db9
PE
5149 * composite.c: Don't truncate sizes to 'int'.
5150 (composition_gstring_p, composition_reseat_it)
5151 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5152 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5153 not EMACS_UINT, for indexes.
5eb55db9 5154
0703a717
PE
5155 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5156
d6202519
PE
5157 * buffer.c: Include <verify.h>.
5158 (struct sortvec.priority, struct sortstr.priority):
8961a454 5159 Now EMACS_INT, not int.
c20998a7 5160 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5161 (struct sortstr.size, record_overlay_string)
5162 (struct sortstrlist.size, struct sortlist.used):
5163 Don't truncate size to int.
5164 (record_overlay_string): Check for size-calculation overflow.
d6202519 5165 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5166
d5a19415
JM
51672011-06-22 Jim Meyering <meyering@redhat.com>
5168
029529ac 5169 Don't leak an XBM-image-sized buffer
d5a19415
JM
5170 * image.c (xbm_load): Free the image buffer after using it.
5171
a9041e6c
PE
51722011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5173
5174 Port to Sun C.
5175 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5176 that Sun C diagnosed.
5177 * fns.c (secure_hash): Fix pointer signedness issue.
5178 * intervals.c (static_offset_intervals): New function.
5179 (offset_intervals): Use it.
5180
7f3f739f
LL
51812011-06-21 Leo Liu <sdl.web@gmail.com>
5182
5183 * deps.mk (fns.o):
5184 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5185 sha512.h.
5186
5187 * fns.c (secure_hash): Rename from crypto_hash_function and change
5188 the first arg to accept symbols.
5b66d427 5189 (Fsecure_hash): New primitive.
7f3f739f
LL
5190 (syms_of_fns): New symbols.
5191
76147d94
DD
51922011-06-20 Deniz Dogan <deniz@dogan.se>
5193
5194 * process.c (Fset_process_buffer): Clarify return value in
5195 docstring.
5196
7d7d0045
CY
51972011-06-18 Chong Yidong <cyd@stupidchicken.com>
5198
5199 * dispnew.c (add_window_display_history): Use BVAR.
5200
5201 * xdisp.c (debug_method_add): Use BVAR.
5202 (check_window_end, dump_glyph_matrix, dump_glyph)
5203 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5204
5205 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5206 Likewise.
5207
5208 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5209 check till after the cache is created in init_frame_faces.
5210
ff2bc410
SM
52112011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5212
5213 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5214
28177add
PE
52152011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5216
dd3482fe
PE
5217 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5218 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5219 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5220
393d71f3 5221 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5222 * fileio.c (Finsert_file_contents):
5223 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5224 Remove the old (too-loose) buffer overflow checks.
5225 They weren't needed, since make_gap checks for buffer overflow.
5226 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5227 The old code merely checked for Emacs fixnum overflow, and relied
5228 on undefined (wraparound) behavior. The new code avoids undefined
5229 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5230
2e6813b0 5231 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5232 Tune. Don't use wider integers than needed. Don't use alloca.
5233 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5234
599a9e4f
PE
5235 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5236
99561444
PE
5237 * insdel.c, lisp.h (buffer_overflow): New function.
5238 (insert_from_buffer_1, replace_range, replace_range_2):
5239 * insdel.c (make_gap_larger):
5240 * editfns.c (Finsert_char):
5241 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5242
28177add
PE
5243 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5244
e69dafad
PE
52452011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5246
4baa020d 5247 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5248
b1c46f02
PE
5249 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5250 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5251
e69dafad
PE
5252 * fileio.c: Don't assume EMACS_INT fits in off_t.
5253 (emacs_lseek): New static function.
5254 (Finsert_file_contents, Fwrite_region): Use it.
5255 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5256
566684ea
PE
5257 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5258
e6966cd6
PE
5259 * fns.c: Don't overflow int when computing a list length.
5260 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5261 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5262 truncation on 64-bit hosts. Check for QUIT every
5263 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5264 faster and is responsive enough.
5265 (Flength): Report an error instead of overflowing an integer.
5266 (Fsafe_length): Return a float if the value is not representable
5267 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5268 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5269 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5270
dd0b0efb
PE
5271 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5272 (header_size, word_size): New constants.
5273 (allocate_vectorlike): Don't check size overflow here.
5274 (allocate_vector): Check it here instead, since this is the only
5275 caller of allocate_vectorlike that could cause overflow.
5276 Check that the new vector's length is representable as a fixnum.
5277
86fe5cfe
PE
5278 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5279 The previous code was bogus. For example, next_almost_prime (32)
5280 returned 39, which is undesirable as it is a multiple of 3; and
5281 next_almost_prime (24) returned 25, which is a multiple of 5 so
5282 why was the code bothering to check for multiples of 7?
5283
80e88859
PE
5284 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5285
4a2f0ad6
PE
5286 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5287
f66c7cf8
PE
5288 Variadic C functions now count arguments with ptrdiff_t.
5289 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5290 Back then I didn't know that the Emacs coding style prefers signed int.
5291 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5292 were being counted with int, which may truncate counts on 64-bit
5293 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5294 * lisp.h (struct Lisp_Subr.function.aMANY)
5295 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5296 Arg counts are now ptrdiff_t, not size_t.
5297 All variadic functions and their callers changed accordingly.
5298 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5299 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5300 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5301 * callint.c (Fcall_interactively): Check arg count for overflow,
5302 to avoid potential buffer overrun. Use signed char, not 'int',
5303 for 'varies' array, so that we needn't bother to check its size
5304 calculation for overflow.
5305 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5306 * eval.c (apply_lambda):
5307 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5308 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5309 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5310
a1759b76
PE
5311 * callint.c (Fcall_interactively): Don't use index var as event count.
5312
d96be9fc
PE
5313 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5314 * mem-limits.h (SIZE): Remove; no longer used.
5315
a690a978 5316 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5317
578c21e6
PE
5318 Remove unnecessary casts.
5319 * xterm.c (x_term_init):
5320 * xfns.c (x_set_border_pixel):
5321 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5322 These aren't needed now that we assume ANSI C.
5323
96f53c6c
PE
5324 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5325 It's more likely to cause problems (due to unsigned overflow)
5326 than to cure them.
5327
83c77d31
PE
5328 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5329
ee2079f1
PE
5330 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5331
6da65536
PE
5332 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5333
7147c4a4
PE
5334 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5335
193e32d9
PE
5336 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5337
e5533da6
PE
5338 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5339
9910e595
PE
5340 GLYPH_CODE_FACE returns EMACS_INT, not int.
5341 * dispextern.h (merge_faces):
5342 * xfaces.c (merge_faces):
01103c44
PE
5343 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5344 Don't assume EMACS_INT fits in int.
9910e595 5345
2638320e
PE
5346 * character.h (CHAR_VALID_P): Remove unused parameter.
5347 * fontset.c, lisp.h, xdisp.c: All uses changed.
5348
045eb8d9
PE
5349 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5350
c1f134b5
PE
5351 * fns.c (concat): Minor tuning based on overflow analysis.
5352 This doesn't fix any bugs. Use int to hold character, instead
5353 of constantly refetching from Emacs object. Use XFASTINT, not
5354 XINT, for value known to be a character. Don't bother comparing
5355 a single byte to 0400, as it's always less.
5356
395fcb93 5357 * floatfns.c (Fexpt):
327eeec8
PE
5358 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5359
abbd3d23
PE
5360 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5361 for characters.
5362
684a03ef
PE
5363 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5364
0fed43f3
PE
5365 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5366 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5367 incorrectly succeed when S was a string, because 4294967386 was
5368 truncated before it was used.
5369
8fd02eb7
PE
5370 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5371 Otherwise, an out-of-range integer could cause undefined behavior
5372 on a 64-bit host.
5373
f8c86b69
PE
5374 * composite.c: Use int, not EMACS_INT, for characters.
5375 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5376 EMACS_INT, for values that are known to be in character range.
5377 This doesn't fix any bugs but is the usual style inside Emacs and
5378 may generate better code on 32-bit machines.
5379
34206dd2
PE
5380 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5381 This is for reasons similar to the recent CHAR_STRING fix.
5382 * charset.c (Fencode_char): Check that character arg is actually
5383 a character. Pass an int to ENCODE_CHAR.
5384 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5385 wider than 'int', as a compile-time check to prevent future regressions
5386 in this area.
5387
c5958d4c 5388 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5389
5390 Make sure a 64-bit char is never passed to CHAR_STRING.
5391 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5392 by silently ignoring the top 32 bits, allowing some values
5393 that were far too large to be valid characters.
5394 * character.h: Include <verify.h>.
5395 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5396 arguments are no wider than unsigned, as a compile-time check
5397 to prevent future regressions in this area.
5398 * data.c (Faset):
01103c44 5399 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5400 (Fsubst_char_in_region):
5401 * fns.c (concat):
5402 * xdisp.c (decode_mode_spec_coding):
5403 Adjust to CHAR_STRING's new requirement.
5404 * editfns.c (Finsert_char, Fsubst_char_in_region):
5405 * fns.c (concat): Check that character args are actually
5406 characters. Without this test, these functions did the wrong
5407 thing with wildly out-of-range values on 64-bit hosts.
5408
d37ca623
PE
5409 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5410 These casts should not be needed on 32-bit hosts, either.
5411 * keyboard.c (read_char):
5412 * lread.c (Fload): Remove casts to unsigned.
5413
ea204efb
PE
5414 * lisp.h (UNSIGNED_CMP): New macro.
5415 This fixes comparison bugs on 64-bit hosts.
5416 (ASCII_CHAR_P): Use it.
5417 * casefiddle.c (casify_object):
01103c44 5418 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5419 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5420 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5421 * dispextern.h (FACE_FROM_ID):
5422 * keyboard.c (read_char): Use UNSIGNED_CMP.
5423
41cb286c
PE
5424 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5425 not to EMACS_INT, to avoid GCC warning.
5426
4a1b9832
PE
5427 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5428
55daad71
PE
5429 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5430 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5431 isn't needed on 32-bit machines.
8f95c75c 5432
01103c44
PE
5433 * buffer.c (Fgenerate_new_buffer_name):
5434 Use EMACS_INT for count, not int.
0ceccced 5435 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5436
5437 * data.c (Qcompiled_function): Now static.
5438
c6f072e7
PE
5439 * window.c (window_body_lines): Now static.
5440
20ce5912
PE
5441 * image.c (gif_load): Rename local to avoid shadowing.
5442
9c4c5f81
PE
5443 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5444 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5445 * alloc.c (make_save_value): Integer argument is now of type
5446 ptrdiff_t, not int.
5447 (mark_object): Use ptrdiff_t, not int.
5448 * lisp.h (pD): New macro.
5449 * print.c (print_object): Use it.
5450
c0c5c8ae
PE
5451 * alloc.c: Use EMACS_INT, not int, to count objects.
5452 (total_conses, total_markers, total_symbols, total_vector_size)
5453 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5454 (total_free_floats, total_floats, total_free_intervals)
5455 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5456 Now EMACS_INT, not int. All uses changed.
5457 (Fgarbage_collect): Compute overall total using a double, so that
5458 integer overflow is less likely to be a problem. Check for overflow
5459 when converting back to an integer.
5a25e253
PE
5460 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5461 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5462 These were 'int' variables that could overflow on 64-bit hosts;
5463 they were never used, so remove them instead of repairing them.
211a0b2a 5464 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5465 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5466 Previously, this ceilinged at INT_MAX, but that doesn't work on
5467 64-bit machines.
e46bb31a 5468 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5469
c78baabf 5470 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5471 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5472 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5473 when a (possibly-narrower) signed value would do just as well.
5474 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5475
c9d624c6
PE
5476 * alloc.c: Catch some string size overflows that we were missing.
5477 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5478 for convenience in STRING_BYTES_MAX.
5479 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5480 The definition here is exact; the one in lisp.h was approximate.
5481 (allocate_string_data): Check for string overflow. This catches
5482 some instances we weren't catching before. Also, it catches
5483 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5484 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5485 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5486
c9d624c6
PE
5487 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5488 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5489 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5490
353032ce
PE
5491 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5492
2bccce07
PE
5493 * alloc.c (Fmake_string): Check for out-of-range init.
5494
0ac30604
SM
54952011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5496
5497 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5498
c195f2de
JD
54992011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5500
5501 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5502 xg_get_default_scrollbar_width.
5503
5504 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5505 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5506 (style_changed_cb): Call update_theme_scrollbar_width and call
5507 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5508 all frames (Bug#8505).
5509 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5510 Call gtk_window_set_resizable if HAVE_GTK3.
5511 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5512 and height if HAVE_GTK3 (Bug#8505).
5513 (scroll_bar_width_for_theme): New variable.
5514 (update_theme_scrollbar_width): New function.
5515 (xg_get_default_scrollbar_width): Move code to
5516 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5517 (xg_initialize): Call update_theme_scrollbar_width.
5518
5519 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5520
5521 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5522
e10ac9f1
MR
55232011-06-12 Martin Rudalics <rudalics@gmx.at>
5524
5525 * frame.c (make_frame): Call other_buffer_safely instead of
5526 other_buffer.
5527
5528 * window.c (temp_output_buffer_show): Call display_buffer with
5529 second argument Vtemp_buffer_show_specifiers and reset latter
5530 immediately after the call.
5531 (Vtemp_buffer_show_specifiers): New variable.
5532 (auto_window_vscroll_p, next_screen_context_lines)
5533 (Vscroll_preserve_screen_position): Remove leading asterisks from
5534 doc-strings.
5535
2d3c217e 55362011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5537
7b7f97e8 5538 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5539 * buffer.c (Qclone_number): Remove for now, as it's unused.
5540 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5541 (record_buffer): Remove unused local.
5542 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5543 (set_frame_buffer_list): Remove; unused.
5544 * frame.h (other_visible_frames): Remove decl.
5545 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5546 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5547 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5548 if HAVE_GPM.
5549 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5550 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5551 Define only if HAVE_GPM.
5552 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5553 (update_hints_inhibit): Remove; never set. All uses removed.
5554 * widgetprv.h (emacsFrameClassRec): Remove decl.
5555 * window.c (delete_deletable_window): Now returns void, since it
5556 wasn't returning anything.
5557 (compare_window_configurations): Remove unused locals.
5558 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5559 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5560 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5561 the same widths as pointers. This follows up on the 2011-05-06 patch.
5562 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5563 * xterm.h: Likewise.
5564 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5565
1384b89e
JB
55662011-06-12 Juanma Barranquero <lekktu@gmail.com>
5567
5568 * makefile.w32-in: Update dependencies.
5569 (LISP_H): Add lib/intprops.h.
5570
1100a63c
CY
55712011-06-11 Chong Yidong <cyd@stupidchicken.com>
5572
5573 * image.c (gif_load): Add animation frame delay to the metadata.
5574 (syms_of_image): Use DEFSYM. New symbol `delay'.
5575
6198ccd0
MR
55762011-06-11 Martin Rudalics <rudalics@gmx.at>
5577
5578 * window.c (delete_deletable_window): Re-add.
5579 (Fset_window_configuration): Rewrite to handle dead buffers and
5580 consequently deletable windows.
5581 (window_tree, Fwindow_tree): Remove. Supply functionality in
5582 window.el.
5583 (compare_window_configurations): Simplify code.
5584
b6e3633c
AS
55852011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5586
1ab0dee5
AS
5587 * image.c (imagemagick_load_image): Fix type mismatch.
5588 (Fimagemagick_types): Likewise.
5589
b6e3633c
AS
5590 * window.h (replace_buffer_in_windows): Declare.
5591
9397e56f
MR
55922011-06-11 Martin Rudalics <rudalics@gmx.at>
5593
5594 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5595 Qclone_number. Remove external declaration of Qdelete_window.
5596 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5597 code.
640c8776
SM
5598 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5599 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5600 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5601 buffer list implementation.
5602 (other_buffer_safely): New function.
5603 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5604 calls to replace_buffer_in_windows and
5605 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5606 if allowed.
5607 (record_buffer): Inhibit quitting and rewrite using quittable
5608 functions. Run Qbuffer_list_update_hook if allowed.
5609 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5610 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5611 Move switch-to-buffer to window.el.
9397e56f
MR
5612 (bury-buffer): Move to window.el.
5613 (Vbuffer_list_update_hook): New variable.
5614
5615 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5616 section.
5617
5618 * window.h (resize_frame_windows): Move up in code.
5619 (Fwindow_frame): Remove EXFUN.
5620 (replace_buffer_in_all_windows): Remove prototype.
5621 (replace_buffer_in_windows_safely): Add prototype.
5622
5623 * window.c: Declare Qdelete_window static again. Move down
5624 declaration of select_count.
5625 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5626 (Fother_window): Move to window.el.
5627 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5628 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5629 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5630 window.el.
5631 (replace_buffer_in_windows): Implement by calling
5632 Qreplace_buffer_in_windows.
5633 (replace_buffer_in_all_windows): Remove with some functionality
5634 moved into replace_buffer_in_windows_safely.
5635 (replace_buffer_in_windows_safely): New function.
5636 (select_window_norecord, select_frame_norecord): Move in front
5637 of run_window_configuration_change_hook. Remove now obsolete
5638 declarations.
640c8776
SM
5639 (Fset_window_buffer): Rewrite doc-string.
5640 Call Qrecord_window_buffer.
9397e56f
MR
5641 (keys_of_window): Move binding for other-window to window.el.
5642
b50691aa
CY
56432011-06-11 Chong Yidong <cyd@stupidchicken.com>
5644
5645 * dispextern.h (struct image): Replace data member, whose int_val
5646 and ptr_val fields were not used by anything, with a single
5647 lisp_val object.
5648
5649 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5650 (gif_clear_image, gif_load, imagemagick_load_image)
5651 (gs_clear_image, gs_load): Callers changed.
5652
3f754b86
PE
56532011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5654
cca69397
PE
5655 * buffer.h: Include <time.h>, for time_t.
5656 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5657
109e28d0
PE
5658 Fix minor problems found by static checking.
5659
60737f02
PE
5660 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5661
4b66faf3
PE
5662 Make identifiers static if they are not used in other modules.
5663 * data.c (Qcompiled_function, Qframe, Qvector):
5664 * image.c (QimageMagick, Qsvg):
5665 * minibuf.c (Qmetadata):
5666 * window.c (resize_window_check, resize_root_window): Now static.
5667 * window.h (resize_window_check, resize_root_window): Remove decls.
5668
109e28d0
PE
5669 * window.c (window_deletion_count, delete_deletable_window):
5670 Remove; unused.
46a4ce9e
PE
5671 (window_body_lines): Now static.
5672 (Fdelete_other_windows_internal): Mark vars as initialized.
5673 Make sure 'resize_failed' is initialized.
5674 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5675 (resize_window_apply): Remove unused local.
5676 * window.h (delete_deletable_window): Remove decl.
5677
109e28d0 5678 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5679 (imagemagick_load_image): Fix pointer signedness problem by changing
5680 last arg from unsigned char * to char *. All uses changed.
5681 Also, fix a local for similar reasons.
5682 Remove unused locals. Remove locals to avoid shadowing.
5683 (fn_rsvg_handle_free): Remove; unused.
5684 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5685 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5686
3f754b86
PE
5687 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5688
2547adb1
CY
56892011-06-10 Chong Yidong <cyd@stupidchicken.com>
5690
5691 * image.c (gif_load): Fix omitted cast error introduced by
5692 2011-06-06 change.
5693
2c8e37d4
MR
56942011-06-10 Martin Rudalics <rudalics@gmx.at>
5695
5696 * window.h (resize_proportionally, orig_total_lines)
5697 (orig_top_line): Remove from window structure.
5698 (set_window_height, set_window_width, change_window_heights)
5699 (Fdelete_window): Remove prototypes.
5700 (resize_frame_windows): Remove duplicate declaration.
5701
440a42e3
EZ
57022011-06-10 Eli Zaretskii <eliz@gnu.org>
5703
5704 * window.h (resize_frame_windows, resize_window_check)
5705 (delete_deletable_window, resize_root_window)
5706 (resize_frame_windows): Declare prototypes.
5707
5708 * window.c (resize_window_apply): Make definition be "static" to
5709 match the prototype.
5710
562dd5e9
MR
57112011-06-10 Martin Rudalics <rudalics@gmx.at>
5712
5713 * window.c: Remove declarations of Qwindow_size_fixed,
5714 window_min_size_1, window_min_size_2, window_min_size,
5715 size_window, window_fixed_size_p, enlarge_window, delete_window.
5716 Remove static from declaration of Qdelete_window, it's
5717 temporarily needed by Fbury_buffer.
5718 (replace_window): Don't assign orig_top_line and
5719 orig_total_lines.
5720 (Fdelete_window, delete_window): Remove. Window deletion is
5721 handled by window.el.
640c8776
SM
5722 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5723 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5724 (Fdelete_other_windows): Remove. Deleting other windows is
5725 handled by window.el.
5726 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5727 handled in window.el.
5728 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5729 Window minimum sizes are handled in window.el.
5730 (shrink_windows, size_window, set_window_height)
5731 (set_window_width, change_window_heights, window_height)
5732 (window_width, CURBEG, CURSIZE, enlarge_window)
5733 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5734 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5735 handled in window.el.
5736 (make_dummy_parent): Rename to make_parent_window and give it a
5737 second argument horflag.
5738 (make_window): Don't set resize_proportionally any more.
5739 (Fsplit_window): Remove. Windows are split in window.el.
5740 (save_restore_action, save_restore_orig_size)
5741 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5742 Resize mini windows in window.el.
5743 (grow_mini_window, shrink_mini_window): Implement by calling
5744 Qresize_root_window_vertically, resize_window_check and
5745 resize_window_apply.
640c8776
SM
5746 (saved_window, Fset_window_configuration, save_window_save):
5747 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5748 resize_proportionally.
5749 (window_min_height, window_min_width): Move to window.el.
5750 (keys_of_window): Move bindings for delete-other-windows,
5751 split-window, delete-window and enlarge-window to window.el.
5752
5753 * buffer.c: Temporarily extern Qdelete_window.
5754 (Fbury_buffer): Temporarily call Qdelete_window instead of
5755 Fdelete_window (Fbury_buffer will move to window.el soon).
5756
5757 * frame.c (set_menu_bar_lines_1): Remove code handling
5758 orig_top_line and orig_total_lines.
5759
5760 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5761 set_window_height but set heights directly.
5762 (change_frame_size_1): Use resize_frame_windows.
5763
5764 * xdisp.c (init_xdisp): Don't use set_window_height but set
5765 heights directly.
5766
640c8776
SM
5767 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5768 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5769 run_window_configuration_change_hook.
5770
5771 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5772 instead of change_window_heights and run
5773 run_window_configuration_change_hook.
5774
1a13852e
MR
57752011-06-09 Martin Rudalics <rudalics@gmx.at>
5776
5777 * window.c (replace_window): Rename second argument REPLACEMENT to
5778 NEW. New third argument SETFLAG. Rewrite.
5779 (delete_window, make_dummy_parent): Call replace_window with
5780 third argument 1.
5781 (window_list_1): Move down in code.
5782 (run_window_configuration_change_hook): Move set_buffer part
5783 before select_frame_norecord part in order to unwind correctly.
5784 Rename count1 to count.
5785 (recombine_windows, delete_deletable_window, resize_root_window)
5786 (Fdelete_other_windows_internal)
5787 (Frun_window_configuration_change_hook, make_parent_window)
5788 (resize_window_check, resize_window_apply, Fresize_window_apply)
5789 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5790 (Fdelete_window_internal, Fresize_mini_window_internal):
5791 New functions.
1a13852e
MR
5792 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5793
f3d1777e
MR
57942011-06-08 Martin Rudalics <rudalics@gmx.at>
5795
496e208e
MR
5796 * window.h (window): Add some new members to window structure -
5797 normal_lines, normal_cols, new_total, new_normal, clone_number,
5798 splits, nest, prev_buffers, next_buffers.
5799 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5800 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5801
f3d1777e
MR
5802 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5803 Remove.
496e208e
MR
5804 (make_dummy_parent): Set new members of windows structure.
5805 (make_window): Move down in code. Handle new members of window
5806 structure.
5807 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5808 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5809 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5810 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5811 (Fset_window_next_buffers, Fset_window_clone_number):
5812 New functions.
496e208e
MR
5813 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5814 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5815 Doc-string fixes.
5816 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5817 Argument WINDOW can be now internal window too.
5818 (Fwindow_use_time): Move up in code.
5819 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5820 Rewrite doc-string.
5821 (Fset_window_configuration, saved_window)
5822 (Fcurrent_window_configuration, save_window_save): Handle new
5823 members of window structure.
b9e809c2
MR
5824 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5825 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5826 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5827 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5828 Qget_mru_window, Qresize_root_window,
5829 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5830 Qauto_buffer_name; staticpro them.
f3d1777e 5831
abde8f8c
MR
58322011-06-07 Martin Rudalics <rudalics@gmx.at>
5833
5834 * window.c (Fwindow_total_size, Fwindow_left_column)
5835 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5836 (Fwindow_list_1): New functions.
5837 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5838 (Fwindow_width, Fscroll_left, Fscroll_right):
5839 Use window_body_cols instead of window_box_text_cols.
5840 (delete_window, Fset_window_configuration):
5841 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5842 (delete_all_subwindows): Take a window as argument and not a
5843 structure. Rewrite.
190b47e6
MR
5844 (window_loop): Remove handling of GET_LRU_WINDOW and
5845 GET_LARGEST_WINDOW.
5846 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5847
5848 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5849 window_box_text_cols. delete_all_subwindows now takes a
5850 Lisp_Object as argument.
abde8f8c 5851
640c8776
SM
5852 * indent.c (compute_motion, Fcompute_motion):
5853 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5854
fa8a67e6
MR
5855 * frame.c (delete_frame): Call delete_all_subwindows with root
5856 window as argument.
5857
a54e3482
DC
58582011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5859
5860 * fns.c (Fputhash): Document return value.
5861
60002bf5
CY
58622011-06-06 Chong Yidong <cyd@stupidchicken.com>
5863
5864 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5865
0c671da6 58662011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5867
b862a52a 5868 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5869
be44ca6c
PE
5870 Check for overflow when converting integer to cons and back.
5871 * charset.c (Fdefine_charset_internal, Fdecode_char):
5872 Use cons_to_unsigned to catch overflow.
5873 (Fencode_char): Use INTEGER_TO_CONS.
5874 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5875 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5876 * data.c (long_to_cons, cons_to_long): Remove.
5877 (cons_to_unsigned, cons_to_signed): New functions.
5878 These signal an error for invalid or out-of-range values.
5879 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5880 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5881 * font.c (Ffont_variation_glyphs):
5882 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5883 * lisp.h: Include <intprops.h>.
5884 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5885 (cons_to_signed, cons_to_unsigned): New decls.
5886 (long_to_cons, cons_to_long): Remove decls.
5887 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5888 (Fprimitive_undo): Use CONS_TO_INTEGER.
5889 * xfns.c (Fx_window_property): Likewise.
5890 * xselect.c: Include <limits.h>.
5891 (x_own_selection, selection_data_to_lisp_data):
5892 Use INTEGER_TO_CONS.
5893 (x_handle_selection_request, x_handle_selection_clear)
5894 (x_get_foreign_selection, Fx_disown_selection_internal)
5895 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5896 (lisp_data_to_selection_data): Use cons_to_unsigned.
5897 (x_fill_property_data): Use cons_to_signed.
5898 Report values out of range.
5899
d1f3d2af
PE
5900 Check for buffer and string overflow more precisely.
5901 * buffer.h (BUF_BYTES_MAX): New macro.
5902 * lisp.h (STRING_BYTES_MAX): New macro.
5903 * alloc.c (Fmake_string):
5904 * character.c (string_escape_byte8):
5905 * coding.c (coding_alloc_by_realloc):
5906 * doprnt.c (doprnt):
5907 * editfns.c (Fformat):
5908 * eval.c (verror):
5909 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5910 since they may not be the same number.
5911 * editfns.c (Finsert_char):
5912 * fileio.c (Finsert_file_contents):
5913 Likewise for BUF_BYTES_MAX.
5914
dd52fcea
PE
5915 * image.c: Use ptrdiff_t, not int, for sizes.
5916 (slurp_file): Switch from int to ptrdiff_t.
5917 All uses changed.
5918 (slurp_file): Check that file size fits in both size_t (for
5919 malloc) and ptrdiff_t (for sanity and safety).
5920
7f9bbdbb
PE
5921 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5922 if b->modtime has its maximal value.
5923
dfe18f82
PE
5924 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5925
84acfcf0
PE
5926 Don't assume time_t can fit into int.
5927 * buffer.h (struct buffer.modtime): Now time_t, not int.
5928 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5929 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5930
ccd9a01a
PE
5931 Minor fixes for signed vs unsigned integers.
5932 * character.h (MAYBE_UNIFY_CHAR):
5933 * charset.c (maybe_unify_char):
5934 * keyboard.c (read_char, reorder_modifiers):
5935 XINT -> XFASTINT, since the integer must be nonnegative.
5936 * ftfont.c (ftfont_spec_pattern):
5937 * keymap.c (access_keymap, silly_event_symbol_error):
5938 XUINT -> XFASTINT, since the integer must be nonnegative.
5939 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5940 since it makes no difference and we prefer signed.
5941 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5942 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5943 nonnegative.
5944
d6d100dd
SM
59452011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5946
5947 * window.h (Fwindow_frame): Declare.
5948
2b6148e4
PE
59492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5950
5951 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5952 (SPARE_MEMORY): Always define.
5953 (LARGE_REQUEST): Remove.
5954 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5955
f230ecc9
MR
59562011-06-06 Martin Rudalics <rudalics@gmx.at>
5957
727e958e
MR
5958 * lisp.h: Move EXFUNS for Fframe_root_window,
5959 Fframe_first_window and Fset_frame_selected_window to window.h.
5960
5961 * window.h: Move EXFUNS for Fframe_root_window,
5962 Fframe_first_window and Fset_frame_selected_window here from
5963 lisp.h.
5964
5965 * frame.c (Fwindow_frame, Fframe_first_window)
5966 (Fframe_root_window, Fframe_selected_window)
5967 (Fset_frame_selected_window): Move to window.c.
5968 (Factive_minibuffer_window): Move to minibuf.c.
5969 (Fother_visible_frames_p): New function.
5970
5971 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5972
f230ecc9
MR
5973 * window.c (decode_window, decode_any_window): Move up in code.
5974 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5975 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5976 (Fwindow_buffer): Move up and rewrite doc-string.
5977 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5978 (Fwindow_prev): New functions.
727e958e
MR
5979 (Fwindow_frame): Move here from frame.c. Accept any window as
5980 argument.
5981 (Fframe_root_window, Fframe_first_window)
5982 (Fframe_selected_window): Move here from frame.c. Accept frame
5983 or arbitrary window as argument. Update doc-strings.
5984 (Fminibuffer_window): Move up in code.
5985 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5986 (Fset_frame_selected_window): Move here from frame.c.
5987 Marginal rewrite.
727e958e
MR
5988 (Fselected_window, select_window, Fselect_window): Move up in
5989 code. Minor doc-string fixes.
f230ecc9 5990
4d09bcf6
PE
59912011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5992
5993 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5994 Do not assume that spare memory exists; that assumption is valid
5995 only if SYSTEM_MALLOC.
5996 (LARGE_REQUEST): New macro, so that the issue of large requests
5997 is separated from the issue of spare memory.
5998
810928a2
AS
59992011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6000
172418ad
AS
6001 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6002 format. (Bug#8806)
6003
43f862f7
AS
6004 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6005
810928a2
AS
6006 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6007 before statements.
6008
a059fe24
JD
60092011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6010
6011 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6012
6013 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6014
6015 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6016 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6017
989bf368
JB
60182011-06-05 Juanma Barranquero <lekktu@gmail.com>
6019
6020 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6021
4b80f674
CY
60222011-06-04 Chong Yidong <cyd@stupidchicken.com>
6023
6024 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6025 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6026 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6027 New error handlers.
4b80f674
CY
6028 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6029 Obey Vx_select_enable_clipboard_manager. Catch errors in
6030 x_clipboard_manager_save (Bug#8779).
6031 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6032 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6033
99a33b77 60342011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6035
6036 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6037
99a33b77 60382011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6039
6040 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6041 in the current matrix if keep_current_p is non-zero.
6042
8264569d
EZ
60432011-06-04 Eli Zaretskii <eliz@gnu.org>
6044
6045 * bidi.c (bidi_level_of_next_char): Fix last change.
6046
57f97249
EZ
60472011-06-03 Eli Zaretskii <eliz@gnu.org>
6048
fec2107c 6049 Support bidi reordering of text covered by display properties.
57f97249 6050
fec2107c
EZ
6051 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6052 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6053 (bidi_cache_search, bidi_cache_iterator_state)
6054 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6055 (bidi_level_of_next_char, bidi_move_to_visually_next):
6056 Support character positions inside a run of characters covered by a
fec2107c
EZ
6057 display string.
6058 (bidi_paragraph_init, bidi_resolve_explicit_1)
6059 (bidi_level_of_next_char): Call bidi_fetch_char and
6060 bidi_fetch_char_advance instead of FETCH_CHAR and
6061 FETCH_CHAR_ADVANCE.
6062 (bidi_init_it): Initialize new members.
6063 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6064 definitions.
6065 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6066 instead of using explicit *_CHAR codes.
d6d100dd
SM
6067 (bidi_resolve_explicit, bidi_resolve_weak):
6068 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6069 bidirectional text is supported only in multibyte buffers.
6070 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6071 it to initialize the frame_window_p member of struct bidi_it.
6072 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6073 (bidi_resolve_explicit, bidi_resolve_weak)
6074 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6075 bidi_it->nchars is non-positive.
6076 (bidi_level_of_next_char): Don't try to lookup the cache for the
6077 next/previous character if nothing is cached there yet, or if we
6078 were just reseat()'ed to a new position.
c40e2fb2 6079
0e14fe90
EZ
6080 * xdisp.c (set_cursor_from_row): Set start and stop points
6081 according to the row's direction when priming the loop that looks
6082 for the glyph on which to display cursor.
6083 (single_display_spec_intangible_p): Function deleted.
6084 (display_prop_intangible_p): Reimplement to call
6085 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6086 Accept 3 additional arguments needed by handle_display_spec.
6087 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6088 values: lists, `(when COND...)' forms, etc.
6089 (single_display_spec_string_p): Support property values that are
6090 lists with the argument STRING its top-level element.
6091 (display_prop_string_p): Fix the condition for processing a
6092 property that is a list to be consistent with handle_display_spec.
fec2107c 6093 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6094 last portion of handle_display_prop.
6095 (compute_display_string_pos): Accept additional argument
6096 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6097 value of a `display' property is a "replacing spec".
6098 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6099 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6100 the display property, but just return a value indicating whether
6101 the display property will replace the characters it covers.
6102 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6103 frame_window_p members of struct bidi_it.
d6d100dd
SM
6104 (compute_display_string_pos, compute_display_string_end):
6105 New functions.
fec2107c
EZ
6106 (push_it): Accept second argument POSITION, where pop_it should
6107 jump to continue iteration.
6108 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6109
fec2107c
EZ
6110 * keyboard.c (adjust_point_for_property): Adjust the call to
6111 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6112
6113 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6114 (bidi_init_it): Update prototypes.
6115 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6116 (compute_display_string_pos, compute_display_string_end):
6117 Declare prototypes.
fec2107c
EZ
6118 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6119 EMACS_INT.
fc6f18ce 6120
40087514 61212011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6122
57f53182
PE
6123 Malloc failure behavior now depends on size of allocation.
6124 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6125 * lisp.h: Change signatures accordingly.
6126 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6127 All callers changed. (Bug#8762)
6128
6129 * gnutls.c: Use Emacs's memory allocators.
6130 Without this change, the gnutls library would invoke malloc etc.
6131 directly, which causes problems on non-SYNC_INPUT hosts, and which
6132 runs afoul of improving memory_full behavior. (Bug#8761)
6133 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6134 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6135 xfree instead of the default malloc, realloc, free.
6136 (Fgnutls_boot): No need to check for memory allocation failure,
6137 since xmalloc does that for us.
6138
ac32cd99 6139 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6140 * category.c (hash_get_category_set):
6141 * ccl.c (ccl_driver):
6142 * charset.c (Fdefine_charset_internal):
6143 * charset.h (struct charset.hash_index):
6144 * composite.c (get_composition_id, gstring_lookup_cache)
6145 (composition_gstring_put_cache):
6146 * composite.h (struct composition.hash_index):
6147 * dispextern.h (struct image.hash):
6148 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6149 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6150 (hashfn_equal, hashfn_user_defined, make_hash_table)
6151 (maybe_resize_hash_table, hash_lookup, hash_put)
6152 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6153 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6154 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6155 * image.c (make_image, search_image_cache, lookup_image)
6156 (xpm_put_color_table_h):
6157 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6158 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6159 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6160 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6161 * alloc.c (allocate_vectorlike):
6162 Check for overflow in vector size calculations.
6163 * ccl.c (ccl_driver):
6164 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6165 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6166 need to be updated by these changes.
40087514
PE
6167 * fns.c (make_hash_table, maybe_resize_hash_table):
6168 Check for integer overflow with large hash tables.
0de4bb68
PE
6169 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6170 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6171 (SXHASH_REDUCE): New macro.
6172 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6173 Use it instead of discarding useful hash info with large hash values.
6174 (sxhash_float): New function.
6175 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6176 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6177 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6178 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6179 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6180 Adjust signatures to match updated version of code.
6181 (consing_since_gc): Now EMACS_INT, since a single hash table can
6182 use more than INT_MAX bytes.
6183
698d32e2
DN
61842011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6185
6186 Make it possible to build with GCC-4.6+ -O2 -flto.
6187
6188 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6189
fd6fa53f
SM
61902011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6191
6192 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6193 Call minibuffer-inactive-mode.
6194
864db017
JB
61952011-05-31 Juanma Barranquero <lekktu@gmail.com>
6196
6197 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6198 Update dependencies.
6199
2ad0baf4
DN
62002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6201
6202 * data.c (init_data): Remove code for UTS, this system is not
6203 supported anymore.
6204
4fcc2638
DN
62052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6206
6207 Don't force ./temacs to start in terminal mode.
6208
6209 * frame.c (make_initial_frame): Initialize faces in all cases, not
6210 only when CANNOT_DUMP is defined.
6211 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6212
c56e0fd5
DN
62132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6214
6215 * dispnew.c (add_window_display_history): Use const for the string
6216 pointer. Remove declaration, not needed.
6217
333d54da 62182011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6219
55d4c1b2 6220 Use 'inline', not 'INLINE'.
333d54da 6221 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6222 * alloc.c, fontset.c (INLINE): Remove.
6223 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6224 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6225 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6226 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6227 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6228
738db178
DN
62292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6230
6231 Make it possible to run ./temacs.
6232
6233 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6234 syms_of_callproc does the same thing. Remove test for
6235 "initialized", do it in the caller.
6236 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6237
620c53a6
SM
62382011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6239
6240 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6241 (read_minibuf): Use get_minibuffer.
6242 (syms_of_minibuf): Use DEFSYM.
6243 (Qmetadata): New var.
6244 * data.c (Qbuffer): Don't make it static.
6245 (syms_of_data): Use DEFSYM.
6246
e003a292
PE
62472011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6248
6249 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6250 (CCL_CODE_MIN): New macro.
6251
ed008a6d
PE
62522011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6253
3687c2ef
PE
6254 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6255
ed008a6d
PE
6256 * eval.c (Qdebug): Now static.
6257 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6258 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6259 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6260
d66c4c7c
CY
62612011-05-29 Chong Yidong <cyd@stupidchicken.com>
6262
6263 * image.c: Various fixes to ImageMagick code comments.
6264 (Fimagemagick_types): Doc fix.
6265
5fbc2025
PE
62662011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6267
0196f88a
PE
6268 Minor fixes prompted by GCC 4.6.0 warnings.
6269
6270 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6271
5fbc2025
PE
6272 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6273 (x_clipboard_manager_save_all): Move extern decl to ...
6274 * xterm.h: ... here, so that it can be checked for consistency.
6275
1dd3c2d9
CY
62762011-05-29 Chong Yidong <cyd@stupidchicken.com>
6277
6278 * xselect.c (x_clipboard_manager_save_frame)
6279 (x_clipboard_manager_save_all): New functions.
6280 (Fx_clipboard_manager_save): Lisp function deleted.
6281
6282 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6283 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6284
6285 * xterm.h: Update prototype.
6286
5ba6571d
WX
62872011-05-28 William Xu <william.xwl@gmail.com>
6288
6289 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6290 exiting (Bug#8239).
6291
3eaff834
JM
62922011-05-28 Jim Meyering <meyering@redhat.com>
6293
e1900994 6294 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6295 * fns.c (to_uchar): Define.
6296 (crypto_hash_function): Use it to convert some newly-signed
6297 variables to unsigned, to avoid sign-extension bugs. For example,
6298 without this change, (md5 "truc") would evaluate to
6299 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6300 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6301 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6302
0f6990a7
PE
63032011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6304
6305 Integer overflow fixes.
c8a9ca5a 6306
08686060
PE
6307 * dbusbind.c: Serial number integer overflow fixes.
6308 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6309 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6310 to hold a serial number that is too large for a fixnum.
6311 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6312 Check for serial numbers out of range. Decode any serial number
59568bf0 6313 that was so large that it became a float. (Bug#8722)
08686060 6314
2d1fc3c7
PE
6315 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6316 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6317 Use XFASTINT rather than XUINT when numbers are nonnegative.
6318 (xd_append_arg, Fdbus_method_return_internal):
6319 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6320 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6321 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6322 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6323 (Bug#8722)
2d1fc3c7 6324
c8a9ca5a
PE
6325 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6326
519e1d69
PE
6327 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6328
6df6ae42 6329 ccl: Add integer overflow checks.
30569699
PE
6330 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6331 (IN_INT_RANGE): New macros.
6332 (ccl_driver): Use them to check for integer overflow when
6333 decoding a CCL program. Many of the new checks are whether XINT (x)
6334 fits in int; it doesn't always, on 64-bit hosts. The new version
6335 doesn't catch all possible integer overflows, but it's an
847044ea 6336 improvement. (Bug#8719)
30569699 6337
c11285dc
PE
6338 * alloc.c (make_event_array): Use XINT, not XUINT.
6339 There's no need for unsigned here.
6340
fdccd48e
PE
6341 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6342 This follows up to the 2011-05-06 change that substituted uintptr_t
6343 for EMACS_INT. This case wasn't caught back then.
6344
37910ab2
PE
6345 Rework Fformat to avoid integer overflow issues.
6346 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6347 now (part of C89). Include <verify.h>.
6348 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6349 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6350 (Fformat): Avoid the prepass trying to compute sizes; it was only
6351 approximate and thus did not catch overflow reliably. Instead, walk
6352 through the format just once, formatting and computing sizes as we go,
6353 checking for integer overflow at every step, and allocating a larger
6354 buffer as needed. Keep track separately whether the format is
6355 multibyte. Keep only the most-recently calculated precision, rather
6356 than them all. Record whether each argument has been converted to
6357 string. Use EMACS_INT, not int, for byte and char and arg counts.
6358 Support field widths and precisions larger than INT_MAX. Avoid
6359 sprintf's undefined behavior with conversion specifications such as %#d
6360 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6361 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6362 formatting out-of-range floating point numbers with int
9173deec 6363 formats. (Bug#8668)
37910ab2 6364
2e6578fb
PE
6365 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6366
0ae6bdee
PE
6367 * data.c: Avoid integer truncation in expressions involving floats.
6368 * data.c: Include <intprops.h>.
6369 (arith_driver): When there's an integer overflow in an expression
6370 involving floating point, convert the integers to floating point
6371 so that the resulting value does not suffer from catastrophic
6372 integer truncation. For example, on a 64-bit host (* 4
6373 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6374 Do not rely on undefined behavior after integer overflow.
6375
de883a70
PE
6376 merge count_size_as_multibyte, parse_str_to_multibyte
6377 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6378 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6379 Check for integer overflow.
6380 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6381 since it's now a duplicate of the other. This is more of
6382 a character than a buffer op, so better that it's in character.c.
6383 * fns.c, print.c: Adjust to above changes.
6384
2ff916cb
PE
63852011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6386
6387 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6388
f1b54466
PE
63892011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6390
fb1ac845
PE
6391 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6392 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6393 (x_clipboard_manager_save): Now static.
6394 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6395
f1b54466
PE
6396 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6397 (crypto_hash_function): Now static.
6398 Fix pointer signedness problems. Avoid unnecessary initializations.
6399
a9f737ee
CY
64002011-05-27 Chong Yidong <cyd@stupidchicken.com>
6401
6402 * termhooks.h (Vselection_alist): Make it terminal-local.
6403
6404 * terminal.c (create_terminal): Initialize it.
6405
6406 * xselect.c: Support for clipboard managers.
6407 (Vselection_alist): Move to termhooks.h as terminal-local var.
6408 (LOCAL_SELECTION): New macro.
6409 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6410 (symbol_to_x_atom): Remove gratuitous arg.
6411 (x_handle_selection_request, lisp_data_to_selection_data)
6412 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6413 (x_own_selection, x_get_local_selection, x_convert_selection):
6414 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6415 (some_frame_on_display): Delete unused function.
6416 (Fx_own_selection_internal, Fx_get_selection_internal)
6417 (Fx_disown_selection_internal, Fx_selection_owner_p)
6418 (Fx_selection_exists_p): New optional frame arg.
6419 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6420 (x_handle_selection_clear): Don't treat other terminals with the
6421 same keyboard specially. Use the terminal-local Vselection_alist.
6422 (x_clear_frame_selections): Use Frun_hook_with_args.
6423
6424 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6425
6426 * xterm.h: Add support for those atoms.
6427
e067f0c1
CY
64282011-05-26 Chong Yidong <cyd@stupidchicken.com>
6429
6430 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6431 (converted_selections, conversion_fail_tag): New global variables.
6432 (x_selection_request_lisp_error): Free the above.
6433 (x_get_local_selection): Remove unnecessary code.
6434 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6435 of converted selections stored in converted_selections.
6436 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6437 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6438 (x_convert_selection): New function.
6439 (x_handle_selection_event): Simplify.
6440 (x_get_foreign_selection): Don't ignore incoming requests while
6441 waiting for an answer; this will fail when we implement
6442 SAVE_TARGETS, and seems unnecessary anyway.
6443 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6444 (Vx_sent_selection_functions): Doc fix.
6445
0f4aebc0
LL
64462011-05-26 Leo Liu <sdl.web@gmail.com>
6447
6448 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6449
e61124cd
YM
64502011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6451
6452 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6453
6454 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6455 for fringe update if it has periodic bitmap.
ac389d0c 6456 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6457 and fringe_bitmap_periodic_p.
6458
6459 * fringe.c (get_fringe_bitmap_data): New function.
6460 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6461 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6462 row. Mark glyph row for fringe update if periodicity changed.
6463
6464 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6465 for fringe update unless it has periodic bitmap.
6466
f16d9837
KH
64672011-05-25 Kenichi Handa <handa@m17n.org>
6468
6469 * xdisp.c (get_next_display_element): Set correct it->face_id for
6470 a static composition.
6471
e1b90ef6
LL
64722011-05-24 Leo Liu <sdl.web@gmail.com>
6473
6474 * deps.mk (fns.o):
6475 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6476
6477 * fns.c (crypto_hash_function, Fsha1): New function.
6478 (Fmd5): Use crypto_hash_function.
6479 (syms_of_fns): Add Ssha1.
6480
7400048f
PE
64812011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6482
6483 * gnutls.c: Remove unused macros.
6484 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6485 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6486 Remove macros that are defined and never used.
6487 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6488
abb71cf4
CY
64892011-05-22 Chong Yidong <cyd@stupidchicken.com>
6490
6491 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6492 (Fx_get_selection_internal): Minor cleanup.
6493 (Fx_own_selection_internal): Rename arguments for consistency with
6494 select.el.
6495
6307db39
PE
64962011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6497
6498 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6499
f3d4e0a4
CY
65002011-05-22 Chong Yidong <cyd@stupidchicken.com>
6501
6502 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6503
4d8ade89
YM
65042011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6505
6506 * dispnew.c (scrolling_window): Don't exclude the case that the
6507 last enabled row in the desired matrix touches the bottom boundary.
6508
32078c8d
GM
65092011-05-21 Glenn Morris <rgm@gnu.org>
6510
6511 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6512 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6513 and add some more files.
32078c8d 6514
7285dc67
EZ
65152011-05-20 Eli Zaretskii <eliz@gnu.org>
6516
6517 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6518 report_file_error introduced by the change from 2011-05-07.
6519
89d1bd22
PE
65202011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6521
6522 * systime.h (Time): Define only if emacs is defined.
6523 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6524 where the include path doesn't have X11/X.h by default. See
6525 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6526
cd394be1 65272011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6528
6529 * composite.c (find_automatic_composition): Fix previous change.
6530
b9704ad9
GM
65312011-05-20 Glenn Morris <rgm@gnu.org>
6532
6533 * lisp.mk: New file, split from Makefile.in.
6534 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6535 (shortlisp): Remove.
6536 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6537
4a720484
GM
65382011-05-19 Glenn Morris <rgm@gnu.org>
6539
6540 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6541 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6542 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6543 (lisp): Set the order to that of loadup.el.
6544 (shortlisp): Make it a copy of $lisp.
6545 (SOME_MACHINE_LISP): Remove.
6546 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6547 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6548
a28d4396
KH
65492011-05-18 Kenichi Handa <handa@m17n.org>
6550
6551 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6552 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6553 (find_automatic_composition): Mostly rewrite for efficiency.
6554
a2b1fa8e
JB
65552011-05-18 Juanma Barranquero <lekktu@gmail.com>
6556
6557 * makefile.w32-in: Update dependencies.
6558
8e1f5610
CS
65592011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6560
6561 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6562 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6563
7025ee00 65642011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6565
cdfa6eab
PE
6566 Fix some integer overflow issues, such as string length overflow.
6567
06d6db33
PE
6568 * insdel.c (count_size_as_multibyte): Check for string overflow.
6569
2b4560a8
PE
6570 * character.c (lisp_string_width): Check for string overflow.
6571 Use EMACS_INT, not int, for string indexes and lengths; in
6572 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6573 the resulting string length overflows an EMACS_INT; instead,
6574 report a string overflow if no precision given. When checking for
6575 precision exhaustion, use a check that cannot possibly have
6576 integer overflow. (Bug#8675)
6577 * character.h (lisp_string_width): Adjust to new signature.
6578
cb93f9be
PE
6579 * alloc.c (string_overflow): New function.
6580 (Fmake_string): Use it. This doesn't change behavior, but saves
6581 a few bytes and will simplify future changes.
6582 * character.c (string_escape_byte8): Likewise.
6583 * lisp.h (string_overflow): New decl.
6584
1a1f3366
PE
6585 Fixups, following up to the user-interface timestamp change.
6586 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6587 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6588 * msdos.c (mouse_get_pos): Likewise.
6589 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6590 * w32gui.h (Time): Define by including "systime.h" rather than by
6591 declaring it ourselves. (Bug#8664)
6592
d4e3e4d3
PE
6593 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6594 * image.c (clear_image_cache): Likewise.
6595
f6a24d19
PE
6596 * term.c (term_mouse_position): Don't assume time_t wraparound.
6597
08dc5ae6
PE
6598 Be more systematic about user-interface timestamps.
6599 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6600 and sometimes 'EMACS_UINT', to represent these timestamps.
6601 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6602 This makes the code easier to follow, and makes it easier to catch
6603 integer overflow bugs such as Bug#8664.
6604 * frame.c (Fmouse_position, Fmouse_pixel_position):
6605 Use Time, not unsigned long, for user-interface timestamps.
6606 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6607 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6608 * keyboard.h (last_event_timestamp): Likewise.
6609 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6610 * menu.h (xmenu_show): Likewise.
6611 * term.c (term_mouse_position): Likewise.
6612 * termhooks.h (struct input_event.timestamp): Likewise.
6613 (struct terminal.mouse_position_hook): Likewise.
6614 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6615 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6616 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6617 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6618 what it was before.
6619 * menu.h, termhooks.h: Include "systime.h", for Time.
6620
8e55734a
PE
6621 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6622 Don't assume that the difference between two unsigned long values
6623 can fit into an integer. At this point, we know button_down_time
6624 <= event->timestamp, so the difference must be nonnegative, so
6625 there's no need to cast the result if double-click-time is
6626 nonnegative, as it should be; check that it's nonnegative, just in
6627 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6628 apart (about 25 days). (Bug#8664)
8e55734a 6629
841f1b75 6630 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6631 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6632
3e26f69c
PE
6633 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6634 that always fit in int. Use a sentinel instead of a counter, to
6635 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6636 * frame.h (struct frame): Use int for menu_bar_items_used
6637 instead of EMACS_INT, since it always fits in int.
3e26f69c 6638
5cc152c0
PE
6639 * menu.c (grow_menu_items): Check for int overflow.
6640
d89eb65e
PE
6641 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6642
5235bd3e
PE
6643 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6644 Before, the code was not consistent. These values cannot exceed
6645 2**31 - 1 so there's no need to make them unsigned.
6646 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6647 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6648 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6649 as modifiers.
6650 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6651
bc827e23
PE
6652 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6653 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6654 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6655 presumably because the widths might not match.
6656
78eb494e
PE
6657 * window.c (size_window): Avoid needless test at loop start.
6658
04f2d78b
CB
66592011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6660
6661 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6662
d2fc7e3d 66632011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6664
6665 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6666
d2fc7e3d 66672011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6668
6669 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6670 `width' to `bar_area_x' and `bar_area_width', respectively.
6671 (x_scroll_run): Take account of fringe background extension.
6672
04f2d78b
CB
6673 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6674 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6675 `bar_area_width', respectively.
6676 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6677 background extension.
6678
79b70037
GM
66792011-05-10 Jim Meyering <meyering@redhat.com>
6680
6681 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6682
2f142cc5
JB
66832011-05-10 Juanma Barranquero <lekktu@gmail.com>
6684
6685 * image.c (Finit_image_library): Return t for built-in image types,
6686 like pbm and xbm. (Bug#8640)
6687
57679c86
AS
66882011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6689
6690 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6691
888c9e86
EZ
66922011-05-07 Eli Zaretskii <eliz@gnu.org>
6693
b0512a1d
EZ
6694 * w32console.c (Fset_screen_color): Doc fix.
6695 (Fget_screen_color): New function.
6696 (syms_of_ntterm): Defsubr it.
6697
7285dc67
EZ
6698 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6699 unlink the temporary file if Fcall_process didn't create it in the
6700 first place.
6701 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6702 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6703 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6704 cue to call_process_cleanup not to close that handle.
6705
4d3fcc8e
BK
67062011-05-07 Ben Key <bkey76@gmail.com>
6707
6708 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6709 one of two shell specific rules, either bootstrap-temacs-CMD or
6710 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6711 to the previous implementation of the bootstrap-temacs rule.
6712 The bootstrap-temacs-CMD rule is similar to the previous
6713 implementation of the bootstrap-temacs rule except that it
6714 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6715 variable.
6716
6717 These changes, along with some changes to nt/configure.bat,
6718 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6719 earlier fix to add support for --cflags and --ldflags options
6720 that include quotes so that it works whether make uses cmd or
6721 sh as the shell.
6722
b4289b64
MA
67232011-05-06 Michael Albinus <michael.albinus@gmx.de>
6724
6725 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6726 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6727 is a constant.
6728 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6729 a string. Handle both cases.
6730 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6731 (Fdbus_register_method): Use Qinvalid_function.
6732
af4c0e28
JB
67332011-05-06 Juanma Barranquero <lekktu@gmail.com>
6734
6735 * makefile.w32-in: Update dependencies.
6736 (LISP_H): Add inttypes.h and stdin.h.
6737 (PROCESS_H): Add unistd.h.
6738
c51453d9
EZ
67392011-05-06 Eli Zaretskii <eliz@gnu.org>
6740
6741 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6742 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6743
8ff0ac3c 67442011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6745
4c4b566b
PE
6746 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6747
aab2b9b5
PE
6748 * term.c (vfatal): Remove stray call to va_end.
6749 It's not needed and the C Standard doesn't allow it here anyway.
6750
c378da0b
PE
6751 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6752 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6753
288b08c7
PE
6754 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6755 bytes.
6756
e3601888
PE
6757 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6758
db6c0e74
PE
6759 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6760
dd5963ea
PE
6761 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6762
88c9450f
PE
6763 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6764
2f9442b8
PE
6765 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6766
c032b5f8
PE
6767 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6768 * charset.c (Fdefine_charset_internal): Don't initialize
6769 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6770 32-bit int (Bug#8600).
a108c10b
PE
6771
6772 * lread.c (read_integer): Be more consistent with string-to-number.
6773 Use string_to_number to do the actual conversion; this avoids
6774 rounding errors and fixes some other screwups. Without this fix,
6775 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6776 (digit_to_number): Move earlier, for benefit of read_integer.
6777 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6778 not a digit in any supported base. (Bug#8602)
a108c10b 6779
ad5f9eea
PE
6780 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6781
aec1708a
PE
6782 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6783 to match comment at start of function. This also removes a
6784 GCC warning about overflow in a 32+64-bit port.
6785
47be4ab5
PE
6786 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6787
371cac43
PE
6788 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6789 Reported by Stefan Monnier in
6790 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6791 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6792 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6793
d01a7826
PE
6794 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6795 (EMACS_UINTPTR): Likewise, with uintptr_t.
6796
7fd47d5c
PE
6797 * lisp.h: Prefer 64-bit EMACS_INT if available.
6798 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6799 on 32-bit hosts that have 64-bit int, so that they can access
6800 large files.
122b0c86
PE
6801 However, temporarily disable this change unless the temporary
6802 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6803
8727937b
PE
6804 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6805
8ac068ac
PE
6806 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6807 This removes an assumption that EMACS_INT and long are the same
6808 width as pointers. The assumption is true for Emacs porting targets
6809 now, but we want to make other targets possible.
6810 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6811 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6812 In the rest of the code, change types of integers that hold casted
6813 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6814 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6815 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6816 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6817 No need to cast type when ORing.
6818 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6819 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6820 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6821 assume EMACS_INT is the same width as char *.
6822 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6823 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6824 Remove no-longer-needed casts.
6825 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6826 (xg_tool_bar_help_callback, xg_make_tool_item):
6827 Use EMACS_INTPTR to hold an integer
6828 that will be cast to void *; this can avoid a GCC warning
6829 if EMACS_INT is not the same width as void *.
6830 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6831 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6832 (current_message_1, set_message_1):
6833 Use a local to convert to proper width without a cast.
6834 * xmenu.c (dialog_selection_callback): Likewise.
6835
ede49d71
PE
6836 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6837 Also, don't assume VALBITS / RAND_BITS is less than 5,
6838 and don't rely on undefined behavior when shifting a 1 left into
6839 the sign bit.
6840 * lisp.h (get_random): Change signature to match.
6841
2f30ecd0
PE
6842 * lread.c (hash_string): Use size_t, not int, for hash computation.
6843 Normally we prefer signed values; but hashing is special, because
6844 it's better to use unsigned division on hash table sizes so that
6845 the remainder is nonnegative. Also, size_t is the natural width
6846 for hashing into memory. The previous code used 'int', which doesn't
6847 retain enough info to hash well into very large tables.
6848 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6849
2a866e7b
PE
6850 * dbusbind.c: Don't possibly lose pointer info when converting.
6851 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6852 Use XPNTR rather than XHASH, so that the high-order bits of
6853 the pointer aren't lost when converting through void *.
6854
51639eac
PE
6855 * eval.c (Fautoload): Don't double-shift a pointer.
6856
92394119
PE
6857 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6858
dbdb9a7c
JB
68592011-05-06 Juanma Barranquero <lekktu@gmail.com>
6860
6861 * gnutls.c (DEF_GNUTLS_FN):
6862 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6863
db7a0b4f
AS
68642011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6865
6866 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6867 marker. (Bug#8610)
6868
cd394be1 68692011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6870
6871 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6872 New version that can reserve upto 2GB of heap space.
6873
f7ff1b0f 68742011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6875
6876 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6877
639c109b
TZ
68782011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6879
6880 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6881 `gnutls_certificate_set_x509_key_file'.
6882
d2127135
JB
68832011-05-05 Juanma Barranquero <lekktu@gmail.com>
6884
6885 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6886 Update dependencies.
6887
e968f4f3
JB
68882011-05-04 Juanma Barranquero <lekktu@gmail.com>
6889
6890 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6891 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6892 Remove unused parameter `fildes'.
6893 * process.c (read_process_output, send_process): Don't pass it.
6894
84d358f0
JB
68952011-05-04 Juanma Barranquero <lekktu@gmail.com>
6896
6897 Fix previous change: the library cache is defined in w32.c.
6898 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6899 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6900
0898ca10
JB
69012011-05-04 Juanma Barranquero <lekktu@gmail.com>
6902
6903 Implement dynamic loading of GnuTLS on Windows.
6904
6905 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6906 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6907 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6908 Declare.
6909
6910 * gnutls.c (Qgnutls_dll): Define.
6911 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6912 (gnutls_*): Declare function pointers.
6913 (init_gnutls_functions): New function to initialize function pointers.
6914 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6915 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6916 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6917 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6918 (emacs_gnutls_write, emacs_gnutls_read)
6919 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6920 (Fgnutls_available_p): New function.
6921 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6922 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6923 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6924
6925 * image.c: Include w32.h.
6926 (Vimage_type_cache): Delete.
6927 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6928 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6929 (w32_delayed_load): Move to w32.c.
6930
6931 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6932
6933 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6934 (w32_delayed_load): Move from image.c. When loading a library, record
6935 its filename in the :loaded-from property of the library id.
6936 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6937 Initialize and staticpro them.
6938 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6939
6940 * process.c: Include lisp.h before w32.h, not after.
6941 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6942 instead of gnutls_record_check_pending.
6943
6944 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6945
ff4de4aa
TZ
69462011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6947
6948 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6949 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6950 as passed in.
6951
abe95abb
JD
69522011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6953
6954 * xterm.c (x_set_frame_alpha): Do not set property on anything
6955 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6956
e16e55d4
JB
69572011-05-02 Juanma Barranquero <lekktu@gmail.com>
6958
6959 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6960
bafcf6a5
JB
69612011-05-02 Juanma Barranquero <lekktu@gmail.com>
6962
6963 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6964 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6965 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6966 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6967 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6968 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6969 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6970 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6971 (Qgnutls_bootprop_callbacks_verify): Make static.
6972
e7a6747f
AS
69732011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6974
19ed11ba
AS
6975 * callproc.c: Indentation fixup.
6976
e7a6747f 6977 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6978 (wait_for_termination, interruptible_wait_for_termination):
6979 Move after wait_for_termination_1.
e7a6747f 6980
1ef14cb4
LMI
69812011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6982
6983 * sysdep.c (interruptible_wait_for_termination): New function
6984 which is like wait_for_termination, but allows keyboard
6985 interruptions.
6986
6987 * callproc.c (Fcall_process): Add (:file "file") as an option for
6988 the STDOUT buffer.
6989 (Fcall_process_region): Ditto.
6990
330d880c
EZ
69912011-04-30 Eli Zaretskii <eliz@gnu.org>
6992
8db90b73
EZ
6993 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6994 rather than `XVECTOR (FOO)->size'.
6995
330d880c
EZ
6996 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6997 inttypes.h, as a gnulib replacement is used if it not available in
6998 system headers.
6999
15cbd324
EZ
70002011-04-21 Eli Zaretskii <eliz@gnu.org>
7001
7002 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7003 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7004 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7005
7006 * coding.c (coding_alloc_by_realloc): Error out if destination
7007 will grow beyond MOST_POSITIVE_FIXNUM.
7008 (decode_coding_emacs_mule): Abort if there isn't enough place in
7009 charbuf for the composition carryover bytes. Reserve an extra
7010 space for up to 2 characters produced in a loop.
7011 (decode_coding_iso_2022): Abort if there isn't enough place in
7012 charbuf for the composition carryover bytes.
7013
70142011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7015
ae940cca
EZ
7016 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7017 aborting when %lld or %lll format is passed.
7018 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7019 %llo or %llx format is passed. (Bug#8545)
7020
03ab8921
EZ
7021 * window.c (window_scroll_line_based): Use a marker instead of
7022 simple variables to record original value of point. (Bug#7952)
7023
afda1437
EZ
7024 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7025 produced by %s or %c overflows available buffer space. (Bug#8545)
7026
f76dee0c
PE
70272011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7028
7029 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7030 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7031
fdc5744d
JB
70322011-04-28 Juanma Barranquero <lekktu@gmail.com>
7033
7034 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7035
638f053a
JB
70362011-04-28 Juanma Barranquero <lekktu@gmail.com>
7037
7038 * keyboard.c (Qdelayed_warnings_hook): Define.
7039 (command_loop_1): Run `delayed-warnings-hook'
7040 if Vdelayed_warnings_list is non-nil.
7041 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7042 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7043
d178f871
EZ
70442011-04-28 Eli Zaretskii <eliz@gnu.org>
7045
7046 * doprnt.c (doprnt): Don't return value smaller than the buffer
7047 size if the message was truncated. (Bug#8545).
7048
b124fd93
JB
70492011-04-28 Juanma Barranquero <lekktu@gmail.com>
7050
7051 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7052 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7053
e810457d
PE
70542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7055
7056 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7057
ea51cceb
JB
70582011-04-27 Juanma Barranquero <lekktu@gmail.com>
7059
7060 * makefile.w32-in: Update dependencies.
7061
94dcfacf
EZ
70622011-04-27 Eli Zaretskii <eliz@gnu.org>
7063
7064 Improve `doprnt' and its usage. (Bug#8545)
7065 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7066 `format_end'. Remove support for %l as a conversion specifier.
7067 Don't use xrealloc. Improve diagnostics when the %l size modifier
7068 is used. Update the commentary.
7069
7070 * eval.c (verror): Simplify calculation of size_t.
7071
7072 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7073 messages.
7074
f61f41d7
PE
70752011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7076
7077 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7078 change.
7079
96fb4434
PE
70802011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7081
7082 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7083 This makes this file independent of the recent pseudovector change.
7084
671875da 70852011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7086
69e9b5a3
PE
7087 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7088
b5f869a7 7089 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7090 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7091 Remove unused local.
c8926152 7092 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7093
841a1577 7094 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7095 GCC 4.6.0 optimizes based on type-based alias analysis.
7096 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7097 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7098 != &v->size, and therefore "v->size = 1; b->size = 2; return
7099 v->size;" must therefore return 1. This assumption is incorrect
7100 for Emacs, since it type-puns struct Lisp_Vector * with many other
7101 types. To fix this problem, this patch adds a new type struct
f904488f 7102 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7103 and pseudovectors, and helps optimizing compilers not get fooled
7104 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7105 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7106 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7107 the size member.
eab3844f
PE
7108 (XSETPVECTYPE): Rewrite in terms of new macro.
7109 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7110 This is a bit clearer, and further avoids the possibility of
7111 undesirable aliasing.
7112 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7113 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7114 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7115 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7116 (ASIZE): Now uses header.size rather than size.
7117 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7118 to avoid the hassle of writing XVECTOR (foo)->header.size.
7119 (struct vectorlike_header): New type.
eab3844f
PE
7120 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7121 object, to help avoid aliasing.
7122 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7123 (SUBRP): Likewise, since Lisp_Subr is a special case.
7124 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7125 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7126 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7127 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7128 changed to be "header.size" and "header.next".
7129 * buffer.h (struct buffer): Likewise.
7130 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7131 * frame.h (struct frame): Likewise.
7132 * process.h (struct Lisp_Process): Likewise.
7133 * termhooks.h (struct terminal): Likewise.
7134 * window.c (struct save_window_data, struct saved_window): Likewise.
7135 * window.h (struct window): Likewise.
7136 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7137 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7138 * buffer.c (init_buffer_once): Likewise.
7139 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7140 special case.
7141 * process.c (Fformat_network_address): Use local var for size,
7142 for brevity.
7143
0df1eac5
PE
7144 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7145
847ab9d1 7146 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7147 * data.c (atof): Remove decl; no longer used or needed.
7148 (digit_to_number): Move to lread.c.
7149 (Fstring_to_number): Use new string_to_number function, to be
7150 consistent with how the Lisp reader treats infinities and NaNs.
7151 Do not assume that floating-point numbers represent EMACS_INT
7152 without losing information; this is not true on most 64-bit hosts.
7153 Avoid double-rounding errors, by insisting on integers when
7154 parsing non-base-10 numbers, as the documentation specifies.
7155 * lisp.h (string_to_number): New decl, replacing ...
7156 (isfloat_string): Remove.
bc0a5c13 7157 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7158 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7159 appears to have been a coding error. Similarly, do not accept
7160 strings like +-1e0 as floating point numbers. Do not report
7161 overflow for integer overflows unless the base is not 10 which
7162 means we have no simple and reliable way to continue.
7163 Break out the floating-point parsing into a new
7164 function string_to_number, so that Fstring_to_number parses
7165 floating point numbers consistently with the Lisp reader.
04f2d78b 7166 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7167 (E_CHAR, EXP_INT): Remove, replacing with ...
7168 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7169 (string_to_number): New function, replacing isfloat_string.
7170 This function checks for valid syntax and produces the resulting
7171 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7172 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7173 so that overflow for non-base-10 numbers is reported only when
7174 there's no portable and simple way to convert to floating point.
452f4150 7175
67769ffc
PE
7176 * textprop.c (set_text_properties_1): Rewrite for clarity,
7177 and to avoid GCC warning about integer overflow.
7178
c20db43f
PE
7179 * intervals.h (struct interval): Use EMACS_INT for members
7180 where EMACS_UINT might cause problems. See
7181 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7182 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7183 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7184 All uses changed.
37aa2f85
PE
7185 (offset_intervals): Tell GCC not to worry about length overflow
7186 when negating a negative length.
c20db43f 7187
2538aa2f
PE
7188 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7189 (overrun_check_free): Likewise.
7190
f2d3008d
PE
7191 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7192 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7193 word size.
7194
ec8df744
PE
7195 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7196 (gnutls_make_error): Rename local to avoid shadowing.
7197 (gnutls_emacs_global_deinit): ifdef out; not used.
7198 (Fgnutls_boot): Use const for pointer to readonly storage.
7199 Comment out unused local. Fix pointer signedness problems.
7200
640ee02d
PE
7201 * lread.c (openp): Don't stuff size_t into an 'int'.
7202 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7203 about possible signed overflow.
7204
6048fb2a
PE
7205 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7206 (GDK_KEY_g): Don't define if already defined.
7207 (xg_prepare_tooltip): Avoid pointer signedness problem.
7208 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7209
fa3c87e1
PE
7210 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7211 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7212
2172544b
PE
7213 * xfns.c (Fx_window_property): Simplify a bit,
7214 to make a bit faster and to avoid GCC 4.6.0 warning.
7215 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7216
9b821a21
PE
7217 * fns.c (internal_equal): Don't assume size_t fits in int.
7218
3c616cfa
PE
7219 * alloc.c (compact_small_strings): Tighten assertion a little.
7220
c2982e87
PE
7221 Replace pEd with more-general pI, and fix some printf arg casts.
7222 * lisp.h (pI): New macro, generalizing old pEd macro to other
7223 conversion specifiers. For example, use "...%"pI"d..." rather
7224 than "...%"pEd"...".
7225 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7226 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7227 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7228 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7229 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7230 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7231 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7232 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7233 64-bit hosts.
7234 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7235 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7236 * print.c (safe_debug_print, print_object): Likewise.
7237 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7238 to int.
6f04d126
PE
7239 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7240 avoiding the 0 flag, which is not portable.
c2982e87
PE
7241 * process.c (Fmake_network_process): Use pI to avoid cast.
7242 * region-cache.c (pp_cache): Likewise.
7243 * xdisp.c (decode_mode_spec): Likewise.
7244 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7245 behavior on 64-bit hosts with printf arg.
6f04d126 7246 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7247 (x_stop_queuing_selection_requests): Likewise.
7248 (x_get_window_property): Don't truncate byte count to an 'int'
7249 when tracing.
0b432f21 7250
5e073ec7
PE
7251 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7252 here, since it parses constructs like leading '-' and spaces,
7253 which are not wanted; and it overflows with large numbers.
7254 Instead, simply match F[0-9]+, which is what is wanted anyway.
7255
36372bf9
PE
7256 * alloc.c: Remove unportable assumptions about struct layout.
7257 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7258 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7259 (allocate_vectorlike, make_pure_vector): Use the new macros,
7260 plus offsetof, to remove unportable assumptions about struct layout.
7261 These assumptions hold on all porting targets that I know of, but
7262 they are not guaranteed, they're easy to remove, and removing them
7263 makes further changes easier.
7264
0b432f21
PE
7265 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7266 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7267 (string_overrun_cookie): Now const. Use initializers that
7268 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7269 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7270 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7271 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7272 multiple of sizeof (EMACS_INT); it need not be, if
7273 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7274 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7275
895009e1
JB
72762011-04-26 Juanma Barranquero <lekktu@gmail.com>
7277
7278 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7279
6a7a1b0b
TZ
72802011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7281
7282 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7283 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7284 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7285
841a1577 72862011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7287
7288 * lisp.h (Qdebug): List symbol.
895009e1 7289 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7290 * keyboard.c (debug-on-event): New variable.
7291 (handle_user_signal): Break into debugger when debug-on-event
7292 matches the current signal symbol.
7293
f2d3ba6f
DN
72942011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7295
7296 * alloc.c (check_sblock, check_string_bytes)
7297 (check_string_free_list): Convert to standard C.
7298
42ce4c63
TZ
72992011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7300
7301 * w32.c (emacs_gnutls_push): Fix typo.
7302
825cd63c
EZ
73032011-04-25 Eli Zaretskii <eliz@gnu.org>
7304
fb11d64d
EZ
7305 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7306 "cast to pointer from integer of different size".
7307
825cd63c
EZ
7308 Improve doprnt and its use in verror. (Bug#8545)
7309 * doprnt.c (doprnt): Document the set of format control sequences
7310 supported by the function. Use SAFE_ALLOCA instead of always
7311 using `alloca'.
7312
7313 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7314 is one byte too soon. Don't use xrealloc; instead xfree and
7315 xmalloc anew.
7316
e061a11b
TZ
73172011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7318
7319 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7320 callbacks stage.
7321
7322 * gnutls.c: Renamed global_initialized to
7323 gnutls_global_initialized. Added internals for the
7324 :verify-hostname-error, :verify-error, and :verify-flags
7325 parameters of `gnutls-boot' and documented those parameters in the
7326 docstring. Start callback support.
9173deec
JB
7327 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7328 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7329 on error. Return error code.
e061a11b
TZ
7330 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7331 (emacs_gnutls_read): Likewise.
7332 (Fgnutls_boot): Return handshake error code.
7333 (emacs_gnutls_handle_error): New function.
7334 (wsaerror_to_errno): Likewise.
7335
7336 * w32.h (emacs_gnutls_pull): Add prototype.
7337 (emacs_gnutls_push): Likewise.
7338
7339 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7340 (emacs_gnutls_push): Likewise.
7341
73422011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7343
7344 * process.c (wait_reading_process_output): Check if GnuTLS
7345 buffered some data internally if no FDs are set for TLS
7346 connections.
7347
7348 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7349 (LIBS): Link to USER_LIBS.
7350 ($(BLD)/gnutls.$(0)): New target.
7351
fa6996bc
EZ
73522011-04-24 Eli Zaretskii <eliz@gnu.org>
7353
eb35682e
EZ
7354 * xdisp.c (handle_single_display_spec): Rename the
7355 display_replaced_before_p argument into display_replaced_p, to
7356 make it consistent with the commentary. Fix typos in the
7357 commentary.
7358
e2ad650c
EZ
7359 * textprop.c (syms_of_textprop): Remove dead code.
7360 (copy_text_properties): Delete obsolete commentary about an
7361 interface that was deleted long ago. Fix typos in the description
7362 of arguments.
7363
1b2de274
EZ
7364 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7365 to changes in oldXMenu/XMenu.h from 2011-04-16.
7366 <menu_help_message, prev_menu_help_message>: Constify.
7367 (IT_menu_make_room): menu->help_text is now `const char **';
7368 adjust.
7369
7370 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7371 to changes in oldXMenu/XMenu.h from 2011-04-16.
7372 (struct XMenu): Declare `help_text' `const char **'.
7373
7374 * xfaces.c <Qunspecified>: Make extern again.
7375
7376 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7377 required by POSIX.
1b2de274 7378
762b15be
EZ
7379 * doc.c (get_doc_string): Improve the format passed to `error'.
7380
7381 * doprnt.c (doprnt): Improve commentary.
7382
7383 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7384
7385 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7386 them with etags.
7387
f1052e5d
EZ
7388 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7389 changes in globals.h immediately force recompilation.
762b15be
EZ
7390 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7391 $(CURDIR)/s/ms-w32.h.
7392 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7393
fa6996bc
EZ
7394 * character.c (Fchar_direction): Function deleted.
7395 (syms_of_character): Don't defsubr it.
7396 <char-direction-table>: Deleted.
7397
e6c3da20
EZ
73982011-04-23 Eli Zaretskii <eliz@gnu.org>
7399
7400 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7401 * doprnt.c: Include limits.h.
7402 (SIZE_MAX): New macro.
04f2d78b
CB
7403 (doprnt): Return a size_t value. 2nd arg is now size_t.
7404 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7405 Improve overflow protection. Support `l' modifier for integer
7406 conversions. Support %l conversion. Don't assume an EMACS_INT
7407 argument for integer conversions and for %c.
7408
7409 * lisp.h (doprnt): Restore prototype.
7410
7411 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7412 $(SRC)/character.h.
7413
7414 * Makefile.in (base_obj): Add back doprnt.o.
7415
7416 * deps.mk (doprnt.o): Add back prerequisites.
7417 (callint.o): Depend on character.h.
7418
7419 * eval.c (internal_lisp_condition_case): Include the handler
7420 representation in the error message.
7421 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7422 when breaking from the loop.
7423
7424 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7425
7426 * callint.c (Fcall_interactively): When displaying error message
7427 about invalid control letter, pass the character's codepoint, not
7428 a pointer to its multibyte form. Improve display of the character
7429 in octal and display also its hex code.
7430
7431 * character.c (char_string): Use %x to display the (unsigned)
7432 codepoint of an invalid character, to avoid displaying a bogus
7433 negative value.
7434
7435 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7436 `error', not SYMBOL_NAME itself.
7437
7438 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7439 character arguments to `error'.
7440
7441 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7442 to `error' in error message about FINAL_CHAR argument. Make sure
7443 FINAL_CHAR is a character, and use %c when it is passed as
7444 argument to `error'.
7445
4ffd0d6b 74462011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7447
7448 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7449
7450 * w32.c: Include <time.h>.
7451 (sys_localtime): New function.
7452
4ffd0d6b 74532011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7454
7455 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7456
4ffd0d6b 7457 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7458
4ffd0d6b 74592011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7460
4ffd0d6b
GM
7461 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7462 zombies (Bug#8467).
aac0c6e3 7463
04c56954
EZ
74642011-04-19 Eli Zaretskii <eliz@gnu.org>
7465
7466 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7467 gl_state.e_property when gl_state.object is Qt.
7468
7469 * insdel.c (make_gap_larger): Remove limitation of buffer size
7470 to <= INT_MAX.
7471
16a43933
CY
74722011-04-18 Chong Yidong <cyd@stupidchicken.com>
7473
7474 * xdisp.c (lookup_glyphless_char_display)
7475 (produce_glyphless_glyph): Handle cons cell entry in
7476 glyphless-char-display.
7477 (Vglyphless_char_display): Document it.
7478
7479 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7480 glyphless-char-display.
7481
4581706e
CY
74822011-04-17 Chong Yidong <cyd@stupidchicken.com>
7483
7484 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7485
7486 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7487
7488 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7489 definition for no-X builds.
7490
4887c6e2 74912011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7492
fd35b6f9
PE
7493 Static checks with GCC 4.6.0 and non-default toolkits.
7494
5c1ccb01
PE
7495 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7496
006c5daa
PE
7497 * process.c (keyboard_bit_set): Define only if SIGIO.
7498 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7499 (send_process): Repair possible setjmp clobbering.
7500
efc736d3
PE
7501 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7502
4e2fe2e6
PE
7503 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7504
f97334a2
PE
7505 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7506
4e75f29d
PE
7507 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7508 Define only if needed.
7509
90efadd1
PE
7510 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7511 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7512 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7513
3c647824
PE
7514 * dispextern.h (struct redisplay_interface): Rename param
7515 to avoid shadowing.
e264f262 7516 * termhooks.h (struct terminal): Likewise.
761383f4 7517 * xterm.c (xembed_send_message): Likewise.
3c647824 7518
b58c5c4a
PE
7519 * insdel.c (make_gap_smaller): Define only if
7520 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7521
cad59032
PE
7522 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7523 it.
7524
c339dc2e
PE
7525 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7526 so that we aren't warned about unused symbols.
7527
91a3e27b
PE
7528 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7529
399c71d3 7530 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7531
8ffc96f5
PE
7532 * xfns.c (x_real_positions): Mark locals as initialized.
7533
eef9bc79
PE
7534 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7535
098db9dd
PE
7536 * xterm.c: Fix problems found by static analysis with other toolkits.
7537 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7538 (x_dispatch_event): Declare static if USE_GTK, and
7539 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7540 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7541 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7542 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7543 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7544
eb18f6cc
PE
7545 * xmenu.c (menu_help_callback): Pointer type fixes.
7546 Use const pointers when pointing at readonly data. Avoid pointer
7547 signedness clashes.
7548 (FALSE): Remove unused macro.
7549 (update_frame_menubar): Remove unused decl.
7550
1fe72bf8
PE
7551 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7552
60d9e1db
PE
7553 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7554 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7555 (single_menu_item): Rename local to avoid shadowing.
7556
39261c26
PE
7557 * keyboard.c (make_lispy_event): Remove unused local var.
7558
018c5e19
PE
7559 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7560 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7561
63d2b86e
PE
7562 * bitmaps: Change bitmaps from unsigned char back to the X11
7563 compatible char. Avoid the old compiler warnings about
7564 out-of-range initializers by using, for example, '\xab' rather
7565 than 0xab.
7566
aefd87e1
PE
7567 * xgselect.c (xgselect_initialize): Check vs interface
7568 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7569
bf501fb9
PE
7570 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7571
e9829fdf
PE
7572 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7573 to read-only memory.
7574
1086c095
PE
7575 * fns.c (vector): Remove; this old hack is no longer needed.
7576
2baccd04 7577 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7578 Remove unused var.
dde42981 7579 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7580
72391843 7581 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7582
436c16df 7583 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7584 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7585 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7586
92bb796d 7587 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7588 (x_term_init): Remove local to avoid shadowing.
92bb796d 7589
764430a3 7590 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7591
7592 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7593 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7594
d1dfb56c
EZ
75952011-04-16 Eli Zaretskii <eliz@gnu.org>
7596
c4354cb4
EZ
7597 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7598
d1dfb56c
EZ
7599 Fix regex.c, syntax.c and friends for buffers > 2GB.
7600 * syntax.h (struct gl_state_s): Declare character position members
7601 EMACS_INT.
7602
7603 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7604
04f2d78b
CB
7605 * textprop.c (verify_interval_modification, interval_of):
7606 Declare arguments EMACS_INT.
d1dfb56c
EZ
7607
7608 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7609 EMACS_INT.
7610
7611 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7612
7613 * indent.c (Fvertical_motion): Local variable it_start is now
7614 EMACS_INT.
7615
7616 * regex.c (re_match, re_match_2, re_match_2_internal)
7617 (bcmp_translate, regcomp, regexec, print_double_string)
7618 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7619 (re_compile_pattern, re_exec): Declare arguments and local
7620 variables `size_t' and `ssize_t' and return values `regoff_t', as
7621 appropriate.
7622 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7623 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7624 <compile_stack_type>: `size' and `avail' are now `size_t'.
7625
7626 * regex.h <regoff_t>: Use ssize_t, not int.
7627 (re_search, re_search_2, re_match, re_match_2): Arguments that
7628 specify buffer/string position and length are now ssize_t and
7629 size_t. Return type is regoff_t.
7630
613052cd
BK
76312011-04-16 Ben Key <bkey76@gmail.com>
7632
7633 * nsfont.m: Fixed bugs in ns_get_family and
7634 ns_descriptor_to_entity that were caused by using free to
7635 deallocate memory blocks that were allocated by xmalloc (via
7636 xstrdup). This caused Emacs to crash when compiled with
7637 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7638 --enable-checking=xmallocoverrun). xfree is now used to
7639 deallocate these memory blocks.
7640
4170f62f 76412011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7642
71b41406
PE
7643 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7644
9587a89d
PE
7645 emacs_write: Accept and return EMACS_INT for sizes.
7646 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7647 et seq.
7648 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7649 Accept and return EMACS_INT.
7650 (emacs_gnutls_write): Return the number of bytes written on
7651 partial writes.
7652 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7653 (emacs_read, emacs_write): Remove check for negative size, as the
7654 Emacs source code has been audited now.
9587a89d
PE
7655 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7656 (emacs_read, emacs_write): Use it.
273a5f82
PE
7657 * process.c (send_process): Adjust to the new signatures of
7658 emacs_write and emacs_gnutls_write. Do not attempt to store
7659 a byte offset into an 'int'; it might overflow.
9587a89d 7660 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7661
3e047f51
PE
7662 * sound.c: Don't assume sizes fit in 'int'.
7663 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7664 Return EMACS_INT, not int.
3e047f51 7665 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7666 Accept EMACS_INT, not int.
7667 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7668 record read return values.
7669
cc39a9db
BK
76702011-04-15 Ben Key <bkey76@gmail.com>
7671
c9d0ec6d
JB
7672 * keyboard.c (Qundefined): Don't declare static since it is used
7673 in nsfns.m.
7674 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7675 static since they are used in nsfont.m.
cc39a9db 7676
6c60eb9f
SM
76772011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7678
7679 * process.c (Qprocessp): Don't declare static.
7680 * lisp.h (Qprocessp): Declare again.
7681
7990b61a
JB
76822011-04-15 Juanma Barranquero <lekktu@gmail.com>
7683
7684 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7685
5d4cb038
PE
76862011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7687
8bd7b830 7688 Improve C-level modularity by making more things 'static'.
cd64ea1d 7689
e3b27b31
PE
7690 Don't publish debugger-only interfaces to other modules.
7691 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7692 (verify_bytepos, count_markers): Move decls to the only modules
7693 that need them.
7694 * region-cache.h (pp_cache): Likewise.
7695 * window.h (check_all_windows): Likewise.
7696 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7697
5d4cb038
PE
7698 * sysdep.c (croak): Now static, if
7699 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7700 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7701
7702 * alloc.c (refill_memory_reserve): Now static if
7703 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7704 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7705
e87b6180
PE
7706 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7707 Define only if USE_LUCID.
7708
ac64929e
PE
7709 * xrdb.c (x_customization_string, x_rm_string): Now static.
7710
6f37259d
PE
7711 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7712 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7713
1683e3ab
PE
7714 * xdisp.c (draw_row_with_mouse_face): Now static.
7715 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7716
de9c2632
PE
7717 * window.h (check_all_windows): Mark externally visible.
7718
2b96acb7
PE
7719 * window.c (window_deletion_count): Now static.
7720
7721 * undo.c: Make symbols static if they're not exported.
7722 (last_undo_buffer, last_boundary_position, pending_boundary):
7723 Now static.
7724
50436f33
PE
7725 * textprop.c (interval_insert_behind_hooks): Now static.
7726 (interval_insert_in_front_hooks): Likewise.
7727
64520e5c
PE
7728 * term.c: Make symbols static if they're not exported.
7729 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7730 (max_frame_lines, tty_set_terminal_modes):
7731 (tty_reset_terminal_modes, tty_turn_off_highlight):
7732 (get_tty_terminal): Now static.
7733 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7734 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7735 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7736 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7737 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7738
1fa53021
PE
7739 * sysdep.c: Make symbols static if they're not exported.
7740 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7741 Now static.
7742 (sigprocmask_set, full_mask): Remove; unused.
7743 (wait_debugging): Mark as visible.
7744 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7745 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7746
d4b43b22
PE
7747 * syntax.c (syntax_temp): Define only if !__GNUC__.
7748
b7c513d0
PE
7749 * sound.c (current_sound_device, current_sound): Now static.
7750
989b29ad
PE
7751 * search.c (searchbufs, searchbuf_head): Now static.
7752
13a55a78
PE
7753 * scroll.c (scroll_cost): Remove; unused.
7754 * dispextern.h (scroll_cost): Remove decl.
7755
de68a1fc
PE
7756 * region-cache.h (pp_cache): Mark as externally visible.
7757
40ccffa6
PE
7758 * process.c: Make symbols static if they're not exported.
7759 (process_tick, update_tick, create_process, chan_process):
7760 (Vprocess_alist, proc_buffered_char, datagram_access):
7761 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7762 (deactivate_process): Mark defn as static, as well as decl.
7763 * lisp.h (create_process): Remove decl.
7764 * process.h (chan_process, Vprocess_alist): Remove decls.
7765
ad64fc97
PE
7766 * print.c: Make symbols static if they're not exported.
7767 (print_depth, new_backquote_output, being_printed, print_buffer):
7768 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7769 (print_interval, print_number_index, initial_stderr_stream):
7770 Now static.
7771 * lisp.h (Fprinc): Remove decl.
7772 (debug_output_compilation_hack): Mark as externally visible.
7773
adddb265
PE
7774 * sysdep.c (croak): Move decl from here to syssignal.h.
7775 * syssignal.h (croak): Put it here, so the API can be checked when
7776 'croak' is called from dissociate_if_controlling_tty.
7777
1717ede2
PE
7778 * minibuf.c: Make symbols static if they're not exported.
7779 (minibuf_save_list, choose_minibuf_frame): Now static.
7780 * lisp.h (choose_minibuf_frame): Remove decl.
7781
fa5fb2bc
PE
7782 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7783
1e3890d1
PE
7784 * lread.c: Make symbols static if they're not exported.
7785 (read_objects, initial_obarray, oblookup_last_bucket_number):
7786 Now static.
7787 (make_symbol): Remove; unused.
7788 * lisp.h (initial_obarray, make_symbol): Remove decls.
7789
8a1414fa
PE
7790 * keyboard.c: Make symbols static if they're not exported.
7791 (single_kboard, recent_keys_index, total_keys, recent_keys):
7792 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7793 (this_single_command_key_start, echoing, last_auto_save):
7794 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7795 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7796 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7797 (Vlispy_mouse_stem, double_click_count):
7798 Now static.
7799 (force_auto_save_soon): Define only if SIGDANGER.
7800 (ignore_mouse_drag_p): Now static if
7801 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7802 (print_help): Remove; unused.
7803 (stop_character, last_timer_event): Mark as externally visible.
7804 * keyboard.h (ignore_mouse_drag_p): Declare only if
7805 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7806 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7807 * lisp.h (echoing): Remove decl.
7808 (force_auto_save_soon): Declare only if SIGDANGER.
7809 * xdisp.c (redisplay_window): Simplify code, to make it more
7810 obvious that ignore_mouse_drag_p is not accessed if !defined
7811 USE_GTK && !defined HAVE_NS.
7812
93ea6e8f
PE
7813 * intervals.c: Make symbols static if they're not exported.
7814 (merge_properties_sticky, merge_interval_right, delete_interval):
7815 Now static.
7816 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7817
77382fcc
PE
7818 * insdel.c: Make symbols static if they're not exported.
7819 However, leave prepare_to_modify_buffer alone. It's never
7820 called from outside this function, but that appears to be a bug.
7821 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7822 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7823 (adjust_after_replace_noundo): Remove; unused.
7824 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7825 (signal_before_change): Remove decls.
77382fcc 7826
9306c32e
PE
7827 * indent.c (val_compute_motion, val_vmotion): Now static.
7828
cd44d2eb
PE
7829 * image.c: Make symbols static if they're not exported.
7830 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7831 if USE_GTK.
7832 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7833 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7834
ad9a7a06
PE
7835 * fringe.c (standard_bitmaps): Now static.
7836 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7837
81626931
PE
7838 * frame.c: Make symbols static if they're not exported.
7839 (x_report_frame_params, make_terminal_frame): Now static.
7840 (get_frame_param): Now static, unless HAVE_NS.
7841 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7842 (x_get_resource_string): Remove; not used.
7843 * frame.h (make_terminal_frame, x_report_frame_params):
7844 (x_get_resource_string); Remove decls.
7845 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7846 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7847
239f9db9
PE
7848 * font.c, fontset.c: Make symbols static if they're not exported.
7849 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7850 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7851 * font.c (font_close_object): Now static.
7852 * font.h (font_close_object): Remove.
7853 * fontset.c (FONTSET_OBJLIST): Remove.
7854 (free_realized_fontset) #if-0 the body, which does nothing.
7855 (face_suitable_for_char_p): #if-0, as it's never called.
7856 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7857 * xfaces.c (face_at_string_position):
7858 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7859 since 0 is always ASCII.
7860
dfcf3579
PE
7861 * fns.c (weak_hash_tables): Now static.
7862
5045092b
PE
7863 * fileio.c: Make symbols static if they're not exported.
7864 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7865 (Vwrite_region_annotation_buffers): Now static.
7866
57a96f5c
PE
7867 * eval.c: Make symbols static if they're not exported.
7868 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7869 * lisp.h (backtrace_list): Remove decl.
7870
35f08c38
PE
7871 * emacs.c: Make symbols static if they're not exported.
7872 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7873 (fatal_error_code, fatal_error_signal_hook, standard_args):
7874 Now static.
7875 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7876 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7877 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7878 * lisp.h (fatal_error_signal_hook): Remove decl.
7879 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7880
f44bd759
PE
7881 * editfns.c: Move a (normally-unused) function to its only use.
7882 * editfns.c, lisp.h (get_operating_system_release): Remove.
7883 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7884 worth the hassle of breaking this out.
7885
b532497d
PE
7886 * xterm.c: Make symbols static if they're not exported.
7887 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7888 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7889 (x_destroy_window, x_delete_display):
7890 Now static.
7891 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7892 (x_mouse_leave): Remove; unused.
7893 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7894 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7895 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7896 Remove decls.
7897 (x_mouse_leave): Declare only if WINDOWSNT.
7898 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7899 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7900 USE_X_TOOLKIT.
7901
1675728f
PE
7902 * ftxfont.c: Make symbols static if they're not exported.
7903 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7904 HAVE_FREETYPE.
7905 * font.h (ftxfont_driver): Likewise.
7906
e4cebfca
PE
7907 * xfns.c: Make symbols static if they're not exported.
7908 (x_last_font_name, x_display_info_for_name):
7909 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7910 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7911 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7912 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7913 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7914 (last_show_tip_args): Now static.
7915 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7916 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7917 (x_screen_planes): Remove; unused.
7918 * dispextern.h (x_screen_planes): Remove decl.
7919
5bf46f05
PE
7920 * dispnew.c: Make symbols static if they're not exported.
7921 * dispextern.h (redraw_garbaged_frames, scrolling):
7922 (increment_row_positions): Remove.
7923 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7924 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7925 Now static.
7926 (redraw_garbaged_frames): Remove; unused.
7927
435f4c28
PE
7928 * xfaces.c: Make symbols static if they're not exported.
7929 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7930 Remove decls.
7931 * xterm.h (defined_color): Remove decls.
7932 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7933 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7934 (menu_face_changed_default, defined_color, free_realized_face):
7935 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7936 (ascii_face_of_lisp_face): Remove; unused.
7937
8524aef3
PE
7938 * xdisp.c: Make symbols static if they're not exported.
7939 * dispextern.h (scratch_glyph_row, window_box_edges):
7940 (glyph_to_pixel_coords, set_cursor_from_row):
7941 (get_next_display_element, set_iterator_to_next):
7942 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7943 (show_mouse_face): Remove decls
7944 * frame.h (message_buf_print): Likewise.
7945 * lisp.h (pop_message, set_message, check_point_in_composition):
7946 Likewise.
7947 * xterm.h (set_vertical_scroll_bar): Likewise.
7948 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7949 (message_buf_print, scratch_glyph_row, displayed_buffer):
7950 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7951 (get_next_display_element, show_mouse_face, window_box_edges):
7952 (frame_to_window_pixel_xy, check_point_in_composition):
7953 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7954 (glyph_to_pixel_coords): Remove; unused.
7955
16390cd2
PE
7956 * dired.c (file_name_completion): Now static.
7957
7958 * dbusbind.c (xd_in_read_queued_messages): Now static.
7959
a25f4dfa
PE
7960 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7961 * data.c (circular_list_error): Remove.
7962
14a9c8df
PE
7963 * commands.h (last_point_position, last_point_position_buffer):
7964 (last_point_position_window): Remove decls.
7965 * keyboard.c: Make these variables static.
7966
04f2d78b
CB
7967 * coding.h (coding, code_convert_region, encode_coding_gap):
7968 Remove decls.
74ab6df5
PE
7969 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7970 (iso_code_class, detect_coding, code_convert_region): Now static.
7971 (encode_coding_gap): Remove; unused.
7972
38dfbee1
PE
7973 * chartab.c (chartab_chars, chartab_bits): Now static.
7974
a2cb4e63
PE
7975 * charset.h (charset_iso_8859_1): Remove decl.
7976 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7977 Now static.
7978
127198fd
PE
7979 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7980 * ccl.c (Vccl_program_table): Now static.
7981 (check_ccl_update): Remove; unused.
7982
d85b608f
PE
7983 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7984 * category.h: ... from here.
7985 * category.c (check_category_table, set_category_set): Now static.
7986
31cd66f3
PE
7987 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7988 * lisp.h: Remove these decls.
7989
c358e587
PE
7990 * buffer.c (buffer_count): Remove unused var.
7991
e78aecca
PE
7992 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7993 so that it's not optimized away.
7994 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7995 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7996 exported only to the debugger.
7997
e192d7d3 7998 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7999 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8000
92470028
PE
8001 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8002 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8003 was inaccessible from Lisp.
8004 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8005 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8006
244ed907
PE
8007 alloc.c: Import and export fewer symbols, and remove unused items.
8008 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8009 is defined.
8010 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8011 it's not optimized away by whole-program optimization.
8012 (message_enable_multibyte, free_misc): Remove.
8013 (catchlist, handlerlist, mark_backtrace):
8014 Declare only if BYTE_MARK_STACK.
8015 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8016 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8017 (message_enable_multibyte): Remove decl.
8018 (free_misc, interval_free_list, float_block, float_block_index):
8019 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8020 (cons_free_list, last_marked_index):
8021 Now static.
8022 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8023 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8024 (mark_backtrace): Define only if BYTE_MARK_STACK.
8025 * xdisp.c (message_enable_multibyte): Now static.
8026
61c2b50e 8027 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8028 This makes it easier for human readers (and static analyzers)
8029 to see whether these variables are used from other modules.
8030 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8031 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8032 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8033 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8034 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8035 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8036 * xmenu.c, xselect.c:
8037 Declare Q* vars static if they are not used in other modules.
8038 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8039 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8040 Remove decls of unexported vars.
8041 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8042
95c82688
PE
8043 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8044
16a97296
PE
8045 Make Emacs functions such as Fatom 'static' by default.
8046 This makes it easier for human readers (and static analyzers)
8047 to see whether these functions can be called from other modules.
8048 DEFUN now defines a static function. To make the function external
8049 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8050 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8051 (Finit_image_library):
16a97296
PE
8052 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8053 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8054 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8055 Remove decls, since these functions are now static.
8056 (Funintern, Fget_internal_run_time): New decls, since these functions
8057 were already external.
95c82688 8058
16a97296
PE
8059 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8060 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8061 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8062 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8063 * keyboard.c, keymap.c, lread.c:
8064 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8065 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8066 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8067 Mark functions with DEFUE instead of DEFUN,
8068 if they are used in other modules.
8069 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8070 decls for now-static functions.
8071 * buffer.h (Fdelete_overlay): Remove decl.
8072 * callproc.c (Fgetenv_internal): Mark as internal.
8073 * composite.c (Fremove_list_of_text_properties): Remove decl.
8074 (Fcomposition_get_gstring): New forward static decl.
8075 * composite.h (Fcomposite_get_gstring): Remove decl.
8076 * dired.c (Ffile_attributes): New forward static decl.
8077 * doc.c (Fdocumntation_property): New forward static decl.
8078 * eval.c (Ffetch_bytecode): New forward static decl.
8079 (Funintern): Remove extern decl; now in .h file where it belongs.
8080 * fileio.c (Fmake_symbolic_link): New forward static decl.
8081 * image.c (Finit_image_library): New forward static decl.
8082 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8083 * intervals.h (Fprevious_property_change):
8084 (Fremove_list_of_text_properties): Remove decls.
8085 * keyboard.c (Fthis_command_keys): Remove decl.
8086 (Fcommand_execute): New forward static decl.
8087 * keymap.c (Flookup_key): New forward static decl.
8088 (Fcopy_keymap): Now static.
8089 * keymap.h (Flookup_key): Remove decl.
8090 * process.c (Fget_process): New forward static decl.
8091 (Fprocess_datagram_address): Mark as internal.
8092 * syntax.c (Fsyntax_table_p): New forward static decl.
8093 (skip_chars): Remove duplicate decl.
8094 * textprop.c (Fprevious_property_change): New forward static decl.
8095 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8096 Now internal.
8097 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8098 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8099
785bbd42
PE
8100 * editfns.c (Fformat): Remove unreachable code.
8101
8b913b57
AS
81022011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8103
8104 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8105 change. (Bug#8496)
8106
a6744a35
EZ
81072011-04-13 Eli Zaretskii <eliz@gnu.org>
8108
8109 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8110 when at ZV. (Bug#8487)
8111
e7974947
AS
81122011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8113
baad03f0
AS
8114 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8115 (Bug#8437)
8116 * keyboard.c (parse_tool_bar_item): Likewise.
8117 * sound.c (sound_cleanup, alsa_close): Likewise.
8118 * termcap.c (tgetent): Likewise.
8119 * xfns.c (x_default_font_parameter): Likewise.
8120 * xsettings.c (read_and_apply_settings): Likewise.
8121
e7974947
AS
8122 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8123 (overrun_check_free): Protoize.
8124
28272684
PE
81252011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8126
8127 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8128 since callers should never pass a negative size.
8129 Change the signature to match that of plain 'read' and 'write'; see
8130 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8131 * lisp.h: Update prototypes of emacs_write and emacs_read.
8132
11997c76
EZ
81332011-04-11 Eli Zaretskii <eliz@gnu.org>
8134
8135 * xdisp.c (redisplay_window): Don't try to determine the character
8136 position of the scroll margin if the window start point w->startp
e896f03c 8137 is outside the buffer's accessible region. (Bug#8468)
11997c76 8138
8a2cbd72
EZ
81392011-04-10 Eli Zaretskii <eliz@gnu.org>
8140
8141 Fix write-region and its subroutines for buffers > 2GB.
8142 * fileio.c (a_write, e_write): Modify declaration of arguments and
8143 local variables to support buffers larger than 2GB.
8144 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8145
8146 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8147 argument, local variables, and return value.
8148
8149 * lisp.h: Update prototypes of emacs_write and emacs_read.
8150
8151 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8152
4073e537 81532011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8154
1ebfdcb6
PE
8155 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8156
b2ded58d
PE
8157 Fix more problems found by GCC 4.6.0's static checks.
8158
7d66342c
PE
8159 * xdisp.c (vmessage): Use a better test for character truncation.
8160
bbf47d44
PE
8161 * charset.c (load_charset_map): <, not <=, for optimization,
8162 and to avoid potential problems with integer overflow.
9248994d 8163 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8164 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8165 * editfns.c (Fformat): Likewise.
1e69125e 8166 * syntax.c (skip_chars): Likewise.
3befa583 8167
e3019616
PE
8168 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8169 This also lets GCC 4.6.0 generate slightly better loop code.
8170
becfa255
PE
8171 * callint.c (Fcall_interactively): <, not <=, for optimization.
8172 (Fcall_interactively): Count the number of arguments produced,
8173 not the number of arguments given. This is simpler and lets GCC
8174 4.6.0 generate slightly better code.
8175
dae0cd48
PE
8176 * ftfont.c: Distingish more carefully between FcChar8 and char.
8177 The previous code passed unsigned char * to a functions like
8178 strlen and xstrcasecmp that expect char *, which does not
8179 conform to the C standard.
8180 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8181 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8182 char * when the C standard requires it.
8183
76032d70
PE
8184 * keyboard.c (read_char): Remove unused var.
8185
eb3f1cc8
PE
8186 * eval.c: Port to Windows vsnprintf (Bug#8435).
8187 Include <limits.h>.
8188 (SIZE_MAX): Define if the headers do not.
8189 (verror): Do not give up if vsnprintf returns a negative count.
8190 Instead, grow the buffer. This ports to Windows vsnprintf, which
8191 does not conform to C99. Problem reported by Eli Zaretskii.
8192 Also, simplify the allocation scheme, by avoiding the need for
8193 calling realloc, and removing the ALLOCATED variable.
8194
70476b54
PE
8195 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8196
12020a9e
PE
8197 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8198 But keep the doprint source code for now, as we might revamp it
8199 and use it again (Bug#8435).
ea6c7ae6
PE
8200 * lisp.h (doprnt): Remove.
8201 * Makefile.in (base_obj): Remove doprnt.o.
8202 * deps.mk (doprnt.o): Remove.
8203
5fdb398c
PE
8204 error: Print 32- and 64-bit integers portably (Bug#8435).
8205 Without this change, on typical 64-bit hosts error ("...%d...", N)
8206 was used to print both 32- and 64-bit integers N, which relied on
8207 undefined behavior.
61bdb816 8208 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8209 * lisp.h (error, verror): Mark as printf-like functions.
8210 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8211 Report overflow in size calculations when allocating printf buffer.
8212 Do not truncate output string at its first null byte.
8213 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8214 Truncate the output at a character boundary, since vsnprintf does not
8215 do that.
8216 * charset.c (check_iso_charset_parameter): Convert internal
8217 character to string before calling 'error', since %c now has the
8218 printf meaning.
8219 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8220 overflow when computing char to be passed to 'error'. Do not
8221 pass Lisp_Object to 'error'; pass the integer instead.
8222 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8223 formatted with plain %d.
8224
b189fa66
PE
8225 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8226
bff87ef0
PE
8227 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8228
7e2cac20
PE
8229 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8230
ce4d90b5
PE
8231 * xterm.c (x_catch_errors): Remove duplicate declaration.
8232
266c9547
PE
8233 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8234
79c49ad2
PE
8235 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8236
368f4090
JM
82372011-04-10 Jim Meyering <meyering@redhat.com>
8238
8239 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8240 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8241 return ssize_t not "int", and use size_t as the buffer length.
8242 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8243 * gnutls.h: Update declarations.
8244 * process.c (read_process_output): Use ssize_t, to match.
8245 (send_process): Likewise.
8246
a32d4040
CY
82472011-04-09 Chong Yidong <cyd@stupidchicken.com>
8248
8249 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8250
8546720e 82512011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8252
04f2d78b
CB
8253 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8254 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8255
8546720e
GM
8256 * xterm.c (handle_one_xevent):
8257 * xmenu.c (create_and_show_popup_menu):
8258 * xselect.c (x_decline_selection_request)
8259 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8260
0a2f5c1a 82612011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8262
8263 Fix some uses of `int' instead of EMACS_INT.
8264 * search.c (string_match_1, fast_string_match)
8265 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8266 (scan_buffer, find_next_newline_no_quit)
8267 (find_before_next_newline, search_command, Freplace_match)
8268 (Fmatch_data): Make some `int' variables be EMACS_INT.
8269
8270 * xdisp.c (display_count_lines): 3rd argument and return value now
8271 EMACS_INT. All callers changed.
8272 (pint2hrstr): Last argument is now EMACS_INT.
8273
8274 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8275 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8276 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8277 (decode_coding_utf_16, decode_coding_emacs_mule)
8278 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8279 (decode_coding_ccl, decode_coding_charset)
8280 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8281 (decode_coding_iso_2022, decode_coding_emacs_mule)
8282 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8283 <char_offset, last_offset>: Declare EMACS_INT.
8284 (encode_coding_utf_8, encode_coding_utf_16)
8285 (encode_coding_emacs_mule, encode_invocation_designation)
8286 (encode_designation_at_bol, encode_coding_iso_2022)
8287 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8288 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8289 Declare EMACS_INT.
8290 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8291 (encode_invocation_designation): Last argument P_NCHARS is now
8292 EMACS_INT.
8293 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8294 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8295
8296 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8297 All users changed.
8298
8299 * ccl.c (Fccl_execute_on_string): Declare some variables
8300 EMACS_INT.
8301
8546720e 83022011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8303
8304 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8305
4e19a977
CS
83062011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8307
8308 * process.c (Fformat_network_address): Doc fix.
8309
87302331
R
83102011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8311
ee7683eb 8312 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8313
cbb59342
CY
83142011-04-08 Chong Yidong <cyd@stupidchicken.com>
8315
8316 * keyboard.c (read_char): Call Lisp function help-form-show,
8317 instead of using internal_with_output_to_temp_buffer.
8318 (Qhelp_form_show): New var.
e0d38eeb 8319 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8320
8321 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8322
8323 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8324
e67a13ab
CY
83252011-04-06 Chong Yidong <cyd@stupidchicken.com>
8326
04f2d78b
CB
8327 * process.c (Flist_processes): Remove to Lisp.
8328 (list_processes_1): Delete.
e67a13ab 8329
973f782d
EZ
83302011-04-06 Eli Zaretskii <eliz@gnu.org>
8331
7c106b1e
EZ
8332 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8333
973f782d
EZ
8334 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8335
41cf7d1a 83362011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8337
ca23cc88
PE
8338 Fix more problems found by GCC 4.6.0's static checks.
8339
f390e2d5
PE
8340 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8341
42eea0d0
PE
8342 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8343
b69769da 8344 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8345
f9541e84
PE
8346 * xdisp.c (vmessage): Mark as a printf-like function.
8347
13841b55
PE
8348 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8349
c136c10f
PE
8350 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8351
5e2d4a30
PE
8352 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8353 printf-like functions.
8354 (tiff_load): Add casts to remove these marks before passing them
8355 to system-supplied API.
8356
583f48b9
PE
8357 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8358
b25d760e
PE
8359 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8360 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8361 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8362 directly, rather than having caller test rule sign. This avoids
8363 some unnecessary tests.
8364 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8365 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8366 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8367
bc7b6697 8368 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8369 (xfont_open): Avoid unnecessary tests.
bc7b6697 8370
27ccc379
PE
8371 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8372
dcd5c89a
PE
8373 * composite.h, composite.c (composition_gstring_put_cache):
8374 Use EMACS_INT, not int, for length.
8375
b13a45c6
PE
8376 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8377 breaking out part of COMPOSITION_DECODE_RULE.
8378 (COMPOSITION_DECODE_RULE): Use it.
8379 * composite.c (get_composition_id): Remove unused local vars,
8380 by using the new macro.
8381
1e792e4d
PE
8382 * textprop.c (set_text_properties_1): Change while to do-while,
8383 since the condition is always true at first.
8384
dc6c6455 8385 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8386 (interval_deletion_adjustment): Return unsigned value.
8387 All uses changed.
dc6c6455 8388
aba7731a
PE
8389 * process.c (list_processes_1, create_pty, read_process_output):
8390 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8391 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8392 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8393 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8394 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8395
fdfc4bf3
PE
8396 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8397
fca8fe46 8398 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8399 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8400
06a0259a 8401 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8402 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8403 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8404
e7b9e80f
PE
8405 * print.c (print_error_message): Avoid int overflow.
8406
56201685
PE
8407 * font.c (font_list_entities): Redo for clarity,
8408 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8409
78834453 8410 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8411 (font_score): Avoid potential overflow in diff calculation.
78834453 8412
0bc0b309 8413 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8414 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8415
e610eaca
PE
8416 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8417
b895abce
PE
8418 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8419 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8420 can always succeed if overflow has undefined behavior.
8421
1f1d9321 8422 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8423 (wordify): Omit three unnecessary tests.
1f1d9321 8424
c59478bc
PE
8425 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8426 All callers changed. This avoids the need for an unused var.
8427
79b73827
PE
8428 * casefiddle.c (casify_region): Remove var that is set but not used.
8429
a4db5dfe
PE
8430 * dired.c (file_name_completion): Remove var that is set but not used.
8431
43aae36e
PE
8432 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8433
2a47c44d 8434 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8435 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8436
a37c69bf
PE
8437 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8438 Check for integer overflow on size calculations.
8439
328ab8e7
PE
8440 * buffer.c (Fprevious_overlay_change): Remove var that is set
8441 but not used.
8442
e5a2a5cb
PE
8443 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8444 Remove vars that are set but not used.
8d84a6eb 8445 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8446 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8447
a60e5f68
PE
8448 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8449
f661cb61 8450 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8451 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8452
f0397f5a
PE
8453 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8454 that are set but not used.
8455
8664db06 8456 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8457 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8458
6abdaa4a
PE
8459 * xselect.c (x_get_local_selection, x_handle_property_notify):
8460 Remove vars that are set but not used.
8461
0ce7538d 8462 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8463 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8464
9ae848fc
PE
8465 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8466 Remove var that is set but not used.
0b918413
PE
8467 (scroll_bar_windows_size): Now size_t, not int.
8468 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8469 Check for overflow.
9ae848fc 8470
a5a62657
PE
8471 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8472 (map_tty_color) [!defined MSDOS]: Likewise.
8473
5c5cdd39
PE
8474 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8475
66ebf983
PE
8476 * coding.c: Remove vars that are set but not used.
8477 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8478 All callers changed.
8479 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8480 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8481 (decode_coding_charset): Remove vars that are set but not used.
8482
1be4d761
PE
8483 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8484 that is set but not used.
8485
47553fa8
PE
8486 * print.c (print_object): Remove var that is set but not used.
8487
1f7196bf 8488 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8489 The gnulib version avoids calling malloc in the usual case,
8490 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8491 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8492 * filelock.c (current_lock_owner): Likewise.
8493 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8494 * sysdep.c: Include allocator.h, careadlinkat.h.
8495 (emacs_no_realloc_allocator): New static constant.
8496 (emacs_readlink): New function.
fdb61804
PE
8497 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8498 ../lib/careadlinkat.h.
d1fdcab7 8499
f84c17c7
SM
85002011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8501
8502 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8503 first non-nil return value).
8504
ef3862ad
JD
85052011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8506
8507 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8508 if not defined (Bug#8403).
8509
376a7006
JB
85102011-04-02 Juanma Barranquero <lekktu@gmail.com>
8511
8512 * xdisp.c (display_count_lines): Remove parameter `start',
8513 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8514 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8515 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8516 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8517 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8518 and thereabouts. All callers changed.
8519 (get_per_char_metric): Remove parameter `f', unused since
8520 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8521
6ca3801d
JM
85222011-04-02 Jim Meyering <meyering@redhat.com>
8523
8524 do not dereference NULL upon failed strdup
8525 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8526 (ns_get_family): Likewise.
8527
d8e2b5ba
JB
85282011-04-02 Juanma Barranquero <lekktu@gmail.com>
8529
8530 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8531
8c74fcbd
JD
85322011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8533
8534 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8535 later (Bug#8403).
8536
7200d79c
SM
85372011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8538
03408648 8539 Add lexical binding.
7200d79c 8540
03408648
SM
8541 * window.c (Ftemp_output_buffer_show): New fun.
8542 (Fsave_window_excursion):
8543 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8544
8545 * lread.c (lisp_file_lexically_bound_p): New function.
8546 (Fload): Bind Qlexical_binding.
8547 (readevalloop): Remove `evalfun' arg.
8548 Bind Qinternal_interpreter_environment.
8549 (Feval_buffer): Bind Qlexical_binding.
8550 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8551 Mark as dynamic.
8552 (syms_of_lread): Declare `lexical-binding'.
8553
8554 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8555
8556 * keyboard.c (eval_dyn): New fun.
8557 (menu_item_eval_property): Use it.
ca105506
SM
8558
8559 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8560
03408648
SM
8561 * fns.c (concat, mapcar1): Accept byte-code-functions.
8562
8563 * eval.c (Fsetq): Handle lexical vars.
8564 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8565 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8566 (FletX, Flet): Obey lexical binding.
8567 (Fcommandp): Handle closures.
8568 (Feval): New `lexical' arg.
8569 (eval_sub): New function extracted from Feval. Use it almost
8570 everywhere where Feval was used. Look up vars in lexical env.
8571 Handle closures.
8572 (Ffunctionp): Move from subr.el.
8573 (Ffuncall): Handle closures.
8574 (apply_lambda): Remove `eval_flags'.
8575 (funcall_lambda): Handle closures and new byte-code-functions.
8576 (Fspecial_variable_p): New function.
8577 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8578 but without exporting it to Lisp.
23aba0ea 8579
23aba0ea 8580 * doc.c (Fdocumentation, store_function_docstring):
03408648 8581 * data.c (Finteractive_form): Handle closures.
23aba0ea 8582
03408648
SM
8583 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8584 interactive spec.
ba83908c 8585
04f2d78b
CB
8586 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8587 New byte-codes.
03408648
SM
8588 (exec_byte_code): New function extracted from Fbyte_code to handle new
8589 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8590
03408648 8591 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8592
03408648 8593 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8594
e2abce01
JB
85952011-03-31 Juanma Barranquero <lekktu@gmail.com>
8596
8597 * xdisp.c (redisplay_internal): Fix prototype.
8598
63696a73 85992011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8600
63696a73 8601 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8602 (try_scrolling): Use it when setting scroll_limit.
8603 Limit scrolling to 100 screen lines.
63696a73
EZ
8604 (redisplay_window): Even when falling back on "recentering",
8605 position point in the window according to scroll-conservatively,
8606 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8607
8608 (try_scrolling): When point is above the window, allow searching
8609 as far as scroll_max, or one screenful, to compute vertical
8610 distance from PT to the scroll margin position. This prevents
8611 try_scrolling from unnecessarily failing when
8612 scroll-conservatively is set to a value slightly larger than the
8613 window height. Clean up the case of PT below the margin at bottom
8614 of window: scroll_max can no longer be INT_MAX. When aggressive
8615 scrolling is in use, don't let point enter the opposite scroll
8616 margin as result of the scroll.
8617 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8618 threshold of 100 lines for never-recentering scrolling.
8619
e4cc2dfc
JB
86202011-03-31 Juanma Barranquero <lekktu@gmail.com>
8621
8622 * dispextern.h (move_it_by_lines):
8623 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8624 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8625 (message_log_check_duplicate): Remove parameters `prev_bol' and
8626 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8627 (redisplay_internal): Remove parameter `preserve_echo_area',
8628 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8629
8630 * indent.c (Fvertical_motion):
8631 * window.c (window_scroll_pixel_based, Frecenter):
8632 Don't pass `need_y_p' to `move_it_by_lines'.
8633
1c470562
SM
86342011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8635
44f230aa
SM
8636 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8637 steal a few bits to be more compact.
8638 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8639 Remove unneeded casts.
8640
1c470562
SM
8641 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8642
888adce9
ZK
86432011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8644
8645 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8646 binding" message (bug#7967).
8647
f838ed7b
PE
86482011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8649
77861b95
PE
8650 Fix more problems found by GCC 4.6.0's static checks.
8651
de6dbc14
PE
8652 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8653 Remove unused local var.
8654
f838ed7b
PE
8655 * editfns.c (Fmessage_box): Remove unused local var.
8656
792c7b2b
PE
8657 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8658 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8659 Omit unused local vars.
c499e557 8660 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8661 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8662 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8663 Omit unused local var.
8664
ba0165e1
PE
8665 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8666 Don't assume string length fits in int.
32ad8845 8667 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8668 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8669
3c59b4c9
PE
8670 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8671 instead of alloca (Bug#8344).
8672
a3eed478 8673 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8674 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8675
eb4d412d
PE
8676 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8677
1658b401
PE
8678 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8679 concerns.
8680
8681 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8682
8683 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8684
9a2c6e05
PE
8685 * keyboard.c (syms_of_keyboard): Use the same style as later
8686 in this function when indexing through an array. This also
8687 works around GCC bug 48267.
8688
03d0a109
PE
8689 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8690
44f730c8
PE
8691 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8692
fe75f926
PE
8693 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8694 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8695
ffa8c828
PE
8696 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8697 This avoids undefined behavior on integer overflow, and is a bit
8698 more convenient anyway since it is compared to a size_t variable.
8699
c5101a77
PE
8700 Variadic C functions now count arguments with size_t, not int.
8701 This avoids an unnecessary limitation on 64-bit machines, which
8702 caused (substring ...) to crash on large vectors (Bug#8344).
8703 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8704 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8705 All variadic functions and their callers changed accordingly.
c5101a77
PE
8706 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8707 * data.c (arith_driver, float_arith_driver): Likewise.
8708 * editfns.c (general_insert_function): Likewise.
8709 * eval.c (struct backtrace.nargs, interactive_p)
8710 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8711 (funcall_lambda, mark_backtrace): Likewise.
8712 * fns.c (concat): Likewise.
8713 * frame.c (x_set_frame_parameters): Likewise.
8714 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8715 0 if not found, not -1. All callers changed.
8716
dd3f25f7
PE
8717 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8718 (stack_copy_size): Now size_t, not int.
8719 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8720
461c2ab9
JB
87212011-03-28 Juanma Barranquero <lekktu@gmail.com>
8722
8723 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8724 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8725 All callers changed.
8726
8727 * lisp.h (multibyte_char_to_unibyte):
8728 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8729 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8730 * character.h (CHAR_TO_BYTE8):
8731 * cmds.c (internal_self_insert):
8732 * editfns.c (general_insert_function):
8733 * keymap.c (push_key_description):
8734 * search.c (Freplace_match):
8735 * xdisp.c (message_dolog, set_message_1): All callers changed.
8736
f6d62986
SM
87372011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8738
8739 * keyboard.c (safe_run_hook_funcall): New function.
8740 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8741 don't set the hook to nil, but remove the offending function instead.
8742 (Qcommand_hook_internal): Remove, unused.
8743 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8744 Vcommand_hook_internal.
8745
8746 * eval.c (enum run_hooks_condition): Remove.
8747 (funcall_nil, funcall_not): New functions.
8748 (run_hook_with_args): Call each function through a `funcall' argument.
8749 Remove `cond' argument, now redundant.
8750 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8751 (Frun_hook_with_args_until_failure): Adjust accordingly.
8752 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8753
1db5b1ad
JB
87542011-03-28 Juanma Barranquero <lekktu@gmail.com>
8755
8756 * dispextern.h (string_buffer_position): Remove declaration.
8757
8758 * print.c (strout): Remove parameter `multibyte', unused since
8759 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8760
8761 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8762 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8763 All callers changed.
8764
8765 * w32.c (_wsa_errlist): Use braces for struct initializers.
8766
8767 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8768 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8769 All callers changed.
8770 (string_buffer_position): Likewise. Also, make static (it's never
8771 used outside xdisp.c).
8772 (cursor_row_p): Remove parameter `w', unused since
8773 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8774 (decode_mode_spec): Remove parameter `precision', introduced during
8775 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8776 All callers changed.
8777
5ffb62aa
JD
87782011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8779
8780 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8781
461c2ab9 87822011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8783
8784 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8785 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8786 (ns_update_auto_hide_menu_bar): New functions.
8787 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8788 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8789 ns_constrain_all_frames.
8790 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8791 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8792
5c380ffb
JD
87932011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8794
8795 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8796
9af30bdf
GM
87972011-03-27 Glenn Morris <rgm@gnu.org>
8798
8799 * syssignal.h: Replace RETSIGTYPE with void.
8800 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8801 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8802 Replace SIGTYPE with void everywhere.
8803 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8804 * s/template.h (SIGTYPE): Remove commented out definition.
8805
e2abce01
JB
88062011-03-26 Eli Zaretskii <eliz@gnu.org>
8807
8808 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8809 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8810
f868cd8a
JB
88112011-03-26 Juanma Barranquero <lekktu@gmail.com>
8812
59eb0929
JB
8813 * w32.c (read_unc_volume): Use parameter `henum', instead of
8814 global variable `wget_enum_handle'.
8815
8816 * keymap.c (describe_vector): Remove parameters `indices' and
8817 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8818 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8819
f868cd8a
JB
8820 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8821
8822 * keyboard.c (timer_check): Remove parameter `do_it_now',
8823 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8824 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8825 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8826
8827 * keyboard.c (read_char):
8828 * w32menu.c (w32_menu_display_help):
8829 * xmenu.c (show_help_event, menu_help_callback):
8830 Adjust calls to `show_help_echo'.
8831
8832 * gtkutil.c (xg_maybe_add_timer):
8833 * keyboard.c (readable_events):
8834 * process.c (wait_reading_process_output):
8835 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8836
8837 * insdel.c (adjust_markers_gap_motion):
8838 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8839 (gap_left, gap_right): Don't call it.
8840
2ecf6fdb
CY
88412011-03-25 Chong Yidong <cyd@stupidchicken.com>
8842
8843 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8844 incurred during fontification.
8845
6b1f9ba4
JB
88462011-03-25 Juanma Barranquero <lekktu@gmail.com>
8847
8848 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8849 (DEFVAR_PER_BUFFER): Don't pass it.
8850
8851 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8852 (scrolling_window): Don't pass it.
8853
0f4a96b5
JB
88542011-03-25 Juanma Barranquero <lekktu@gmail.com>
8855
8856 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8857
8858 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8859 and `suffix'.
8860 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8861 of variables specific to SELinux and computation of `encoded_absname'.
8862
8863 * image.c (XPutPixel): Remove unused variable `height'.
8864
8865 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8866
8867 * unexw32.c (get_section_info): Remove unused variable `section'.
8868
8869 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8870 (system_process_attributes): Remove unused variable `sess'.
8871 (sys_read): Remove unused variable `err'.
8872
8873 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8874 (w32_wnd_proc): Remove unused variable `isdead'.
8875 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8876 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8877 (x_create_tip_frame): Remove unused variable `tem'.
8878
8879 * w32inevt.c (w32_console_read_socket):
8880 Remove unused variable `no_events'.
8881
8882 * w32term.c (x_draw_composite_glyph_string_foreground):
8883 Remove unused variable `width'.
8884
1149507c
JB
88852011-03-24 Juanma Barranquero <lekktu@gmail.com>
8886
8887 * w32term.c (x_set_glyph_string_clipping):
8888 Don't pass uninitialized region to CombineRgn.
8889
9c88f339
JB
88902011-03-23 Juanma Barranquero <lekktu@gmail.com>
8891
8892 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8893 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8894 (Fx_close_connection): Remove unused variable `i'.
8895
8896 * w32font.c (w32font_draw): Return number of glyphs.
8897 (w32font_open_internal): Remove unused variable `i'.
8898 (w32font_driver): Add missing initializer.
8899
8900 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8901 (fill_in_menu): Remove unused variable `items_added'.
8902
8903 * w32term.c (last_mouse_press_frame): Remove static global variable.
8904 (w32_clip_to_row): Remove unused variable `f'.
8905 (x_delete_terminal): Remove unused variable `i'.
8906
8907 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8908 (NOTHING): Remove unused static global variable.
8909 (uniscribe_check_otf): Remove unused variable `table'.
8910 (uniscribe_font_driver): Add missing initializers.
8911
dee091a3
JD
89122011-03-23 Julien Danjou <julien@danjou.info>
8913
8914 * term.c (Fsuspend_tty, Fresume_tty):
8915 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8916 * window.c (temp_output_buffer_show):
8917 * insdel.c (signal_before_change):
8918 * frame.c (Fhandle_switch_frame):
8919 * fileio.c (Fdo_auto_save):
8920 * emacs.c (Fkill_emacs):
8921 * editfns.c (save_excursion_restore):
8922 * cmds.c (internal_self_insert):
8923 * callint.c (Fcall_interactively):
8924 * buffer.c (Fkill_all_local_variables):
8925 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8926 Use Frun_hooks.
0f4a96b5 8927 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8928 unconditionally since it does the check itself.
dee091a3 8929
2c520ab5 89302011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8931
c9c49752
PE
8932 Fix more problems found by GCC 4.5.2's static checks.
8933
8abc3f12
PE
8934 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8935 the first time through the loop, since we know p0 < p1 then.
8936 This also avoids a gcc -Wstrict-overflow warning.
8937
a2d26660
PE
8938 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8939 leading to a memory leak, possible in functions like
8940 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8941 of objects (Bug#8318).
a2d26660 8942
916c72e9
PE
8943 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8944 that could (at least in theory) be that large.
8945
19ab8a18
PE
8946 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8947 This is less likely to overflow, and avoids undefined behavior if
8948 overflow does occur. All callers changed. Use strtoul to scan
8949 for the unsigned long integer.
b7cbbd6f
PE
8950 (pint2hrstr): Simplify and tune code slightly.
8951 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8952
f0641eff
PE
8953 * scroll.c (do_scrolling): Work around GCC bug 48228.
8954 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8955
7f650bb9
PE
8956 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8957 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8958 (validate_x_resource_name): Simplify count usage.
8959 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8960
37dd57d1
PE
8961 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8962 fail (Bug#8306).
81e56e61 8963
699979fc 8964 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8965
401bf9b4
PE
8966 * process.c (Fmake_network_process): Use socklen_t, not int,
8967 where POSIX says socklen_t is required in portable programs.
8968 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8969 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8970 (Fmake_network_process, server_accept_connection):
8971 (wait_reading_process_output, read_process_output):
8972 Likewise.
8973
b93aacde
PE
8974 * process.c: Rename or move locals to avoid shadowing.
8975 (list_processes_1, Fmake_network_process):
8976 (read_process_output_error_handler, exec_sentinel_error_handler):
8977 Rename or move locals.
4dc343ee 8978 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8979 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8980 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8981 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8982 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8983
af8a867c 8984 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8985 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8986 Include tparam.h instead, since it declares them.
af8a867c
PE
8987 * cm.h (PC): Remove extern decl; tparam.h now does this.
8988 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8989 * terminfo.c: Include tparam.h, to check interfaces.
8990 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8991 (tparam): Adjust signature to match interface in tparam.h;
8992 this removes some undefined behavior. Check that outstring and len
8993 are zero, which they always are with Emacs.
8994 * tparam.h (PC, BC, UP): New extern decls.
8995
0248044d 8996 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8997 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8998
8ff096c1 8999 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9000 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9001 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9002 (ftfont_list): Remove unused local.
49eaafba
PE
9003 (get_adstyle_property, ftfont_pattern_entity):
9004 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9005 Rename locals to avoid shadowing.
8ff096c1 9006
e2be39f6
PE
9007 * xfont.c (xfont_list_family): Mark var as initialized.
9008
c9735e30
PE
9009 * xml.c (make_dom): Now static.
9010
8f5201ae
PE
9011 * composite.c (composition_compute_stop_pos): Rename local to
9012 avoid shadowing.
b246f932
PE
9013 (composition_reseat_it): Remove unused locals.
9014 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9015 (composition_update_it): Mark var as initialized.
11b61122
PE
9016 (find_automatic_composition): Mark vars as initialized,
9017 with a FIXME (Bug#8290).
8f5201ae 9018
760fbc2c
PE
9019 character.h: Rename locals to avoid shadowing.
9020 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9021 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9022 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9023 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9024 to avoid shadowing.
9025
ff08eb85
PE
9026 * textprop.c (property_change_between_p): Remove; unused.
9027
fc7bf025
PE
9028 * intervals.c (interval_start_pos): Now static.
9029
235d7abc
PE
9030 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9031
44f230aa
SM
9032 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9033 Rename locals to avoid shadowing.
3e7d6594 9034
50060332
PE
9035 * sound.c (wav_play, au_play, Fplay_sound_internal):
9036 Fix pointer signedness.
d01f234b 9037 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9038 (wav_play): Initialize a variable to 0, to prevent undefined
9039 behavior (Bug#8278).
50060332 9040
c4fc4e30
PE
9041 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9042
918436ed
PE
9043 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9044
c939f91b
PE
9045 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9046 clobbering (Bug#8298).
b9c7f648
PE
9047 * sysdep.c (sys_subshell): Likewise.
9048 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9049
6bd8c144
PE
9050 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9051 This should get cleaned up, so that child_setup has the
9052 same signature on all platforms.
9053
7710357c 9054 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9055 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9056
c59da222
CY
90572011-03-22 Chong Yidong <cyd@stupidchicken.com>
9058
9059 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9060 not to be necessary, and produces flickering.
9061
66b87493
GM
90622011-03-20 Glenn Morris <rgm@gnu.org>
9063
9064 * config.in: Remove file.
9065
45b6f6d5
JB
90662011-03-20 Juanma Barranquero <lekktu@gmail.com>
9067
9068 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9069 are now in src/globals.h.
9070 (syms_of_minibuf): Remove spurious & from previous change.
9071
cd394be1 90722011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9073
9074 * minibuf.c (completing-read-function): New variable.
9075 (completing-read-default): Rename from completing-read.
9076 (completing-read): Call completing-read-function.
9077
b14e3e21
CY
90782011-03-19 Juanma Barranquero <lekktu@gmail.com>
9079
9080 * xfaces.c (Fx_load_color_file):
9081 Read color file from absolute filename (bug#8250).
9082
f2b726e6
JB
90832011-03-19 Juanma Barranquero <lekktu@gmail.com>
9084
9085 * makefile.w32-in: Update dependencies.
9086
09f6ff02
EZ
90872011-03-17 Eli Zaretskii <eliz@gnu.org>
9088
9089 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9090
29a6015a
PE
90912011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9092
a3a6c54e
PE
9093 Fix more problems found by GCC 4.5.2's static checks.
9094
b766f867
PE
9095 * process.c (make_serial_process_unwind, send_process_trap):
9096 (sigchld_handler): Now static.
9097
be02381c
PE
9098 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9099 That way, the code declares only the vars that it needs.
9100 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9101 * s/cygwin.h (PTY_ITERATION): Likewise.
9102 * s/darwin.h (PTY_ITERATION): Likewise.
9103 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9104
57048744
PE
9105 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9106 * process.c (allocate_pty): Don't declare stb unless it's needed.
9107
7914961c 9108 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9109 (CONSTANTLIM): Remove; unused.
9110 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9111 Define only if needed.
7914961c 9112
b3967b18
PE
9113 * unexelf.c (unexec): Name an expression,
9114 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9115 Use a different way to cause a compilation error if anyone uses
9116 n rather than nn, a way that does not involve shadowing.
73366a00 9117 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9118
29a6015a
PE
9119 * deps.mk (unexalpha.o): Remove; unused.
9120
43cfc33e 9121 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9122 * unexec.h: New file.
ce701a33
PE
9123 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9124 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9125 Depend on unexec.h.
9126 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9127 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9128 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9129 Change as necessary to match prototype in unexec.h.
ce701a33 9130
01f44d5a
PE
9131 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9132 shadowing.
4f63c6bb 9133 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9134
a6670b0b
PE
9135 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9136 Rename locals to avoid shadowing.
9137
cef2010d 9138 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9139 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9140
d4d7173a
PE
9141 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9142
f08b802a
PE
9143 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9144 warning when compiling print.c.
9145
3ddb0639
PE
9146 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9147 instead of using an uninitialized var.
5ad03b97 9148 (font_sort_entities): Mark var as initialized.
3ddb0639 9149
170a2692
PE
9150 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9151
e663c700
PE
9152 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9153 pointers to constants.
89bc529a 9154 (font_parse_fcname): Remove unused vars.
7b81e2d0 9155 (font_delete_unmatched): Now static.
ea838e10 9156 (font_get_spec): Remove; unused.
13a547c6
PE
9157 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9158 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9159 Rename or move locals to avoid shadowing.
e663c700 9160
2a80c887 9161 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9162 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9163
1384fa33 9164 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9165 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9166
8b2c52e9
PE
9167 * alloc.c (mark_backtrace): Move decl from here ...
9168 * lisp.h: ... to here, so that it can be checked.
9169
475545b5 9170 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9171 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9172 (lisp_indirect_variable): Name an expression,
9173 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9174 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9175
b1349114 9176 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9177 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9178 Use const pointer when appropriate.
b1349114 9179
a2928364
PE
9180 * lisp.h (get_system_name, get_operating_system_release):
9181 Move decls here, to check interfaces.
9182 * process.c (get_operating_system_release): Move decl to lisp.h.
9183 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9184 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9185 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9186 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9187 (Fformat_time_string, Fencode_time, Finsert_char):
9188 (Ftranslate_region_internal, Fformat):
9189 Rename or remove local vars to avoid shadowing.
9710023e 9190 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9191
a415e694
PE
9192 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9193 avoid shadowing.
9194
8ef4622d
PE
9195 * lisp.h (eassert): Check that the argument compiles, even if
9196 ENABLE_CHECKING is not defined.
9197
946f9a5b
PE
9198 * data.c (Findirect_variable): Name an expression, to avoid
9199 gcc -Wbad-function-cast warning.
112396d6 9200 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9201 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9202 (Fmake_variable_buffer_local, Fmake_local_variable):
9203 Mark variables as initialized.
52746918 9204 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9205
e5aab7e7 9206 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9207 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9208 Rename locals to avoid shadowing.
dff45157
PE
9209 (mark_stack): Move local variables into the #ifdef region where
9210 they're used.
7bc26fdb
PE
9211 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9212 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9213 needed otherwise.
9214 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9215 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9216 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9217
e5aab7e7
PE
9218 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9219 avoids undefined behavior in theory.
9220
4da60324
PE
9221 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9222
88043301
PE
9223 Use functions, not macros, for up- and down-casing (Bug#8254).
9224 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9225 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9226 to use the following functions instead of these macros.
9227 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9228 EMACS_INT, since callers assume the returned value fits in int.
9229 (upcase1): Likewise, for UPCASE_TABLE.
9230 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9231 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9232 the race-condition problem in the old DOWNCASE.
88043301 9233
19ed5445
PE
9234 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9235 Rename locals to avoid shadowing.
9236 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9237 (regex_compile, re_search_2, re_match_2_internal):
9238 Remove unused local vars.
952db0d7
PE
9239 (FREE_VAR): Rewrite so as not to use empty "else",
9240 which gcc can warn about.
da053e48 9241 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9242 (RETALLOC_IF): Define only if needed.
9243 (WORDCHAR_P): Likewise. This one is never needed, but is used
9244 only in a comment talking about a compiler bug, so put inside
9245 the #if 0 of that comment.
9246 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9247 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9248 Remove; unused.
19ed5445 9249
1f3561e4 9250 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9251 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9252 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9253
ded6f8f7
PE
9254 * search.c (simple_search): Remove unused var.
9255
dbd37a95
PE
9256 * dired.c (compile_pattern): Move decl from here ...
9257 * lisp.h: ... to here, so that it can be checked.
9258 (struct re_registers): New forward decl.
9259
7e47afad
PE
9260 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9261
85f24f61
PE
9262 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9263 All uses changed.
9264 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9265 Rename locals to avoid shadowing.
5671df8f 9266 (Fvertical_motion): Mark locals as initialized.
85f24f61 9267
181aa2be 9268 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9269 (casify_region): Mark local as initialized.
181aa2be 9270
930d429c
PE
9271 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9272
7082eac6
PE
9273 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9274 New macros, so that the caller can use some names other than
9275 gcpro1, gcpro2, etc.
9276 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9277 of the new macros.
9278 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9279 argument, for consistency with GCPRO2_VAR, etc: it is now the
9280 prefix of the variable, not the variable itself. All uses
9281 changed.
38b2c076
PE
9282 * dired.c (directory_files_internal, file_name_completion):
9283 Rename locals to avoid shadowing.
9284
15206ed9
PE
9285 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9286 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9287 dired.c's scmp function, had undefined behavior.
9288 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9289 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9290 * buffer.h: ... to here, because these macros use current_buffer,
9291 and the new implementation with inline functions needs to have
9292 current_buffer in scope now, rather than later when the macros
9293 are used.
9294 (downcase, upcase1): New static inline functions.
9295 (DOWNCASE, UPCASE1): Reimplement using these functions.
9296 This avoids undefined behavior in expressions like
9297 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9298 from race conditions in accessing the global variables
9299 case_temp1 and case_temp2.
9300 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9301 * lisp.h (case_temp1, case_temp2): Remove their decls.
9302 * character.h (ASCII_CHAR_P): Move from here ...
9303 * lisp.h: ... to here, so that the inline functions mentioned
9304 above can use them.
9305
4a6bea26
PE
9306 * dired.c (directory_files_internal_unwind): Now static.
9307
f14b7e14
PE
9308 * fileio.c (file_name_as_directory, directory_file_name):
9309 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9310 Now static.
2893f146
PE
9311 (file_name_as_directory): Use const pointers when appropriate.
9312 (Fexpand_file_name): Likewise. In particular, newdir might
9313 point at constant storage, so make it a const pointer.
fd4ead52 9314 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9315 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9316 signedness issues.
f839df0c
PE
9317 (Fset_file_times, Finsert_file_contents, auto_save_error):
9318 Rename locals to avoid shadowing.
f14b7e14 9319
5716756e 9320 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9321 (Ftry_completion, Fall_completions): Rename or remove locals
9322 to avoid shadowing.
5716756e 9323
b4c3046a
PE
9324 * marker.c (bytepos_to_charpos): Remove; unused.
9325
b45db522
PE
9326 * lisp.h (verify_bytepos, count_markers): New decls,
9327 so that gcc does not warn that these functions aren't declared.
9328
85876d07
PE
9329 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9330 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9331 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9332 (copy_text): Remove unused local var.
85876d07 9333
03d78a21 9334 * filelock.c (within_one_second): Now static.
b3dd38ab 9335 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9336
5df8f01b
PE
9337 * buffer.c (fix_overlays_before): Mark locals as initialized.
9338 (fix_start_end_in_overlays): Likewise. This function should be
9339 simplified by using pointers-to-pointers, but that's a different
9340 matter.
b1d876f1 9341 (switch_to_buffer_1): Now static.
8f54f30a
PE
9342 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9343 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9344
a70072c9 9345 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9346 Fix pointer signedness issue.
edced198
PE
9347 (sys_subshell): Mark local as volatile if checking for lint,
9348 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9349 (MAXPATHLEN): Define only if needed.
a70072c9 9350
a0977c44
PE
9351 * process.c (serial_open, serial_configure): Move decls from here ...
9352 * systty.h: ... to here, so that they can be checked.
9353
a884fdcc
PE
9354 * fns.c (get_random, seed_random): Move extern decls from here ...
9355 * lisp.h: ... to here, so that they can be checked.
9356
604efe86 9357 * sysdep.c (reset_io): Now static.
b8950c94 9358 (wait_for_termination_signal): Remove; unused.
604efe86 9359
38fc62d9
PE
9360 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9361 (copy_keymap_item, append_key, push_text_char_description):
9362 Now static.
1004a21a 9363 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9364 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9365 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9366 (describe_map_tree):
9367 Rename locals to avoid shadowing.
38fc62d9 9368
2f2650da
PE
9369 * keyboard.c: Declare functions static if they are not used elsewhere.
9370 (echo_char, echo_dash, cmd_error, top_level_2):
9371 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9372 (read_char, kbd_buffer_get_event, make_lispy_position):
9373 (make_lispy_event, make_lispy_movement, apply_modifiers):
9374 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9375 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9376 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9377 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9378 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9379
a053e86c 9380 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9381 (mark_kboards): Move decl here ...
9382 * alloc.c (mark_kboards): ... from here.
a053e86c 9383
4752793e
PE
9384 * lisp.h (force_auto_save_soon): New decl.
9385
74f10ca7 9386 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9387 (DEFINE_DUMMY_FUNCTION): New macro.
9388 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9389 Use it.
c03cd23f
PE
9390 (main): Add casts to avoid warnings
9391 if GCC considers string literals to be constants.
74f10ca7 9392
022e70d4
PE
9393 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9394
59d6fe83
PE
9395 * dbusbind.c: Pointer signedness fixes.
9396 (xd_signature, xd_append_arg, xd_initialize):
9397 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9398 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9399 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9400 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9401
78320123
PE
9402 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9403 if GCC considers string literals to be constants.
49cebcca 9404 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9405
35ac2a97
SM
94062011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9407
fb103ca9
SM
9408 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9409 (print_preprocess, print_object): New macro to fix last change.
9410
35ac2a97
SM
9411 * print.c (print_preprocess): Don't forget font objects.
9412
62973b41
JB
94132011-03-16 Juanma Barranquero <lekktu@gmail.com>
9414
9415 * emacs.c (USAGE3): Doc fixes.
9416
0e48bb22
AS
94172011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9418
9419 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9420 structure.
9421
7684e57b
JB
94222011-03-14 Juanma Barranquero <lekktu@gmail.com>
9423
9424 * lisp.h (VWindow_system, Qfile_name_history):
9425 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9426 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9427 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9428
9429 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9430 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9431
9432 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9433 * w32console.c (detect_input_pending, read_input_pending)
9434 (encode_terminal_code):
9435 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9436 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9437 (w32_system_caret_y, Qfile_name_history):
9438 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9439 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9440 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9441 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9442 * w32proc.c (Qlocal, report_file_error):
9443 * w32term.c (Vwindow_system, updating_frame):
9444 * w32uniscribe.c (initialized, uniscribe_font_driver):
9445 Remove unneeded extern declarations.
9446
2aa46d6c
CY
94472011-03-14 Chong Yidong <cyd@stupidchicken.com>
9448
c96bbc66 9449 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9450
cffc6f3b
CY
94512011-03-13 Chong Yidong <cyd@stupidchicken.com>
9452
9453 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9454 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9455 These macros can no longer be used for assignment.
9456
44f230aa
SM
9457 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9458 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9459 (record_buffer_markers, fetch_buffer_markers): New functions for
9460 recording and fetching special buffer markers.
9461 (set_buffer_internal_1, set_buffer_temp): Use them.
9462
9463 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9464
9465 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9466
9467 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9468 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9469
9470 * xdisp.c (hscroll_window_tree):
9471 (reconsider_clip_changes): Use PT instead of BUF_PT.
9472
d251f04b
EZ
94732011-03-13 Eli Zaretskii <eliz@gnu.org>
9474
9475 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9476 $(EMACS_ROOT)/lib/intprops.h.
9477
f0c77cd1
PE
94782011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9479
3eca4629
PE
9480 Fix more problems found by GCC 4.5.2's static checks.
9481
7c86ee98
PE
9482 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9483 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9484 (xg_free_frame_widgets): Make it clear that a local variable is
9485 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9486 (gdk_window_get_screen): Make it clear that this macro is needed
9487 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9488 (int_gtk_range_get_value): New function, which avoids a diagnostic
9489 from gcc -Wbad-function-cast.
9490 (xg_set_toolkit_scroll_bar_thumb): Use it.
9491 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9492 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9493 (get_utf8_string, xg_get_file_with_chooser):
9494 Rename locals to avoid shadowing.
9495 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9496
41729b81
PE
9497 * xgselect.c (xg_select): Remove unused var.
9498
f0c77cd1
PE
9499 * image.c (four_corners_best): Mark locals as initialized.
9500 (gif_load): Initialize transparent_p to zero (Bug#8238).
9501 Mark another local as initialized.
ec6cf4c6 9502 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9503
ce0ad53d 9504 * image.c (clear_image_cache): Now static.
d5d5a617 9505 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9506 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9507 (x_edge_detection): Remove unnecessary cast that
9508 gcc -Wbad-function-cast diagnoses.
2037898d 9509 (gif_load): Fix pointer signedness.
6ae141d6
PE
9510 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9511 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9512
33383987 95132011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9514
d32df629
PE
9515 Improve quality of tests for time stamp overflow.
9516 For example, without this patch (encode-time 0 0 0 1 1
9517 1152921504606846976) returns the obviously-bogus value (-948597
9518 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9519 reports time overflow. See
9520 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9521 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9522 * editfns.c: Include limits.h and intprops.h.
9523 (TIME_T_MIN, TIME_T_MAX): New macros.
9524 (time_overflow): Move earlier, to before first use.
9525 (hi_time, lo_time): New functions, for an accurate test for
9526 out-of-range times.
9527 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9528 (Fget_internal_run_time): Don't assume time_t fits in int.
9529 (make_time): Use list2 instead of Fcons twice.
9530 (Fdecode_time): More accurate test for out-of-range times.
9531 (check_tm_member): New function.
9532 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9533 (lisp_time_argument): Don't rely on undefined left-shift and
9534 right-shift behavior when checking for time stamp overflow.
8be6f318 9535
fe31d94c
PE
9536 * editfns.c (time_overflow): New function, refactoring common code.
9537 (Fformat_time_string, Fdecode_time, Fencode_time):
9538 (Fcurrent_time_string): Use it.
9539
8be6f318
PE
9540 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9541 * dired.c (make_time): Move to ...
9542 * editfns.c (make_time): ... here.
9543 * systime.h: Note the move.
9544
09d9db2c 95452011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9546
126bc0dc
YM
9547 * fringe.c (update_window_fringes): Remove unused variables.
9548
c47cbdfd
YM
9549 * unexmacosx.c (copy_data_segment): Also copy __got section.
9550 (Bug#8223)
9551
7ac80be9
EZ
95522011-03-12 Eli Zaretskii <eliz@gnu.org>
9553
c96bbc66 9554 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9555 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9556 Constify `char *' arguments and their references according to
9557 prototypes in tparam.h.
9558
ecb0f94d 9559 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9560
7ac80be9
EZ
9561 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9562 Adapt all references accordingly.
9563
9564 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9565
ef1fd07e
TT
95662011-03-11 Tom Tromey <tromey@redhat.com>
9567
9568 * buffer.c (syms_of_buffer): Remove obsolete comment.
9569
7ef4b50c
EZ
95702011-03-11 Eli Zaretskii <eliz@gnu.org>
9571
9572 * termhooks.h (encode_terminal_code): Declare prototype.
9573
9574 * msdos.c (encode_terminal_code): Don't declare prototype.
9575
9576 * term.c (encode_terminal_code): Now external again, used by
9577 w32console.c and msdos.c.
9578
44f230aa
SM
9579 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9580 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9581
4b1ec863 95822011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9583
1714f52b 9584 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9585
4b1ec863
PE
9586 * fringe.c (update_window_fringes): Mark locals as initialized
9587 (Bug#8227).
9588 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9589
524c7aa6
PE
9590 * alloc.c (mark_fringe_data): Move decl from here ...
9591 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9592 to check its interface.
9593 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9594
a5c0af81 9595 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9596 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9597 (fontset_font): Mark local as initialized.
a9a06e0b 9598 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9599
b4716021
PE
9600 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9601
811e9bac 9602 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9603 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9604 (x_own_selection, Fx_disown_selection_internal): Rename locals
9605 to avoid shadowing.
9606 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9607
7e3ab302
PE
9608 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9609 so that the caller can use some name other than gcpro1.
9610 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9611 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9612 (Fx_backspace_delete_keys_p):
9613 Use them to avoid shadowing, and rename vars to avoid shadowing.
9614 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9615 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9616 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9617 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9618 Remove unused locals.
7e3ab302
PE
9619 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9620 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9621 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9622 macros.
f78faa98 9623
e2b13473
PE
9624 * xterm.h (x_mouse_leave): New decl.
9625
77f23912
PE
9626 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9627 Remove unused functions.
cdf4ba58
PE
9628 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9629 (x_calc_absolute_position): Now static.
7411c686 9630 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9631 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9632 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9633 unless they are used.
38d0b34a
PE
9634 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9635 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9636 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9637 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9638 (x_error_catcher, x_connection_closed, x_error_handler):
9639 (x_error_quitter, xembed_send_message, x_iconify_frame):
9640 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9641 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9642 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9643
44f230aa
SM
9644 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9645 Rename or move locals to avoid shadowing.
6b463e58 9646 (tty_defined_color, merge_face_heights): Now static.
5967d051 9647 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9648 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9649 does not deduce is never used uninitialized.
73719eba
PE
9650 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9651 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9652
426994c3 9653 * terminal.c (store_terminal_param): Now static.
5489860b 9654
032f1620 9655 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9656 (set_frame_menubar): Remove unused local.
d4323972 9657 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9658 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9659 since they might point to immutable storage.
281585b0
PE
9660 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9661 since it's unused otherwise.
032f1620 9662
367c19e5 9663 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9664 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9665 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9666 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9667 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9668 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9669 does not deduce are never used uninitialized.
70739cbe 9670
07b48fa9
PE
9671 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9672
8868a238 9673 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9674 * window.c (window_loop, size_window):
9675 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9676
7e5cf297 9677 * window.c (display_buffer): Now static.
d6550a9f
PE
9678 (size_window): Mark variables that gcc -Wuninitialized
9679 does not deduce are never used uninitialized.
a586633d
PE
9680 * window.h (check_all_windows): New decl, to forestall
9681 gcc -Wmissing-prototypes diagnostic.
5b555da1 9682 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9683
f6095868
PE
9684 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9685 shadowing.
9686 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9687 Include <limits.h>.
9688 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9689 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9690 (load_charset_map): Mark variables that gcc -Wuninitialized
9691 does not deduce are never used uninitialized.
53df7c11 9692 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9693
f38b440c
PE
9694 * coding.c (coding_set_source, coding_set_destination):
9695 Use "else { /* comment */ }" rather than "else /* comment */;"
9696 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9697 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9698 a block, when the outer 'i' will do.
9699 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9700 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9701 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9702 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9703 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9704 Rename locals to avoid shadowing.
9705 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9706 * coding.c (emacs_mule_char, encode_invocation_designation):
9707 Now static, since they're not used elsewhere.
413bb2db 9708 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9709 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9710 (decode_coding_emacs_mule): Mark variables that gcc
9711 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9712 (detect_coding_iso_2022): Initialize a local variable that might
9713 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9714 this initialization is needed. (Bug#8211)
5f58e762
PE
9715 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9716 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9717 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9718 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9719 Remove unused macros.
f38b440c 9720
232b38b9 9721 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9722 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9723 * character.c (string_count_byte8): Likewise.
232b38b9 9724
fb90da1b
PE
9725 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9726 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9727
fb93dbc2
PE
9728 * chartab.c (copy_sub_char_table): Now static, since it's not used
9729 elsewhere.
5c156ace
PE
9730 (sub_char_table_ref_and_range, char_table_ref_and_range):
9731 Rename locals to avoid shadowing.
bbcd0949 9732 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9733
7d3b3862 9734 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9735 (BIDI_BOB): Remove unused macro.
7d3b3862 9736
6be7d3da
PE
9737 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9738 deduce are never used uninitialized.
c2ed9c8b 9739 * term.c (encode_terminal_code): Likewise.
6be7d3da 9740
75f8807f 9741 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9742
50938595
PE
9743 * tparam.h: New file.
9744 * term.c, tparam.h: Include it.
9745 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9746 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9747 Move these decls to tparam.h, and make them agree with what
9748 is actually in tparam.c. The previous trick of using incompatible
9749 decls in different modules does not conform to the C standard.
9750 All callers of tparam changed to use tparam's actual API.
9751 * tparam.c (tparam1, tparam, tgoto):
9752 Use const pointers where appropriate.
9753
fbceeba2
PE
9754 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9755 * cm.h (struct cm): Likewise.
9756 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9757 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9758 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9759 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9760 (turn_on_face, init_tty): Likewise.
9761 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9762
7f3f1250
PE
9763 * term.c (term_mouse_position): Rename local to avoid shadowing.
9764
e6ca6543
PE
9765 * alloc.c (mark_ttys): Move decl from here ...
9766 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9767
c40f8d15
AS
97682011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9769
9770 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9771
cfe0661d
JB
97722011-03-09 Juanma Barranquero <lekktu@gmail.com>
9773
9774 * search.c (compile_pattern_1): Remove argument regp, unused since
9775 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9776 (compile_pattern): Don't pass it.
9777
0afb4571
J
97782011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9779
9780 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9781 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9782 for ! HAVE_GTK3.
9783 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9784
9785 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9786
9787 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9788 gdk_window_get_screen, gdk_window_get_geometry,
9789 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9790 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9791 (xg_get_pixbuf_from_pixmap): New function.
9792 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9793 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9794 Call xg_get_pixbuf_from_pixmap instead of
9795 gdk_pixbuf_get_from_drawable.
9796 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9797 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9798 (xg_check_special_colors): Use GtkStyleContext and its functions
9799 for HAVE_GTK3.
9800 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9801 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9802 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9803 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9804 Call gtk_widget_get_preferred_size.
0afb4571
J
9805 (xg_frame_resized): gdk_window_get_geometry only takes 5
9806 parameters.
44f230aa
SM
9807 (xg_win_to_widget, xg_event_is_for_menubar):
9808 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9809 (xg_set_widget_bg): New function.
9810 (delete_cb): New function.
895009e1 9811 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9812 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9813 (xg_set_background_color): Call xg_set_widget_bg.
9814 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9815 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9816 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9817 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9818 if ! HAVE_GTK3.
9819 (update_frame_tool_bar): Call gtk_widget_hide.
9820 (xg_initialize): Use GDK_KEY_g.
9821
9822 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9823 if ! HAVE_GTK3
9824 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9825
9826 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9827 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9828 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9829
1c2cc4ef
JB
98302011-03-08 Juanma Barranquero <lekktu@gmail.com>
9831
9832 * w32xfns.c (select_palette): Check success of RealizePalette against
9833 GDI_ERROR, not zero.
9834
33383987 9835See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9836
9837;; Local Variables:
9838;; coding: utf-8
aac0c6e3
MR
9839;; End:
9840
2f097256 9841 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9842
9843 This file is part of GNU Emacs.
9844
9845 GNU Emacs is free software: you can redistribute it and/or modify
9846 it under the terms of the GNU General Public License as published by
9847 the Free Software Foundation, either version 3 of the License, or
9848 (at your option) any later version.
9849
9850 GNU Emacs is distributed in the hope that it will be useful,
9851 but WITHOUT ANY WARRANTY; without even the implied warranty of
9852 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9853 GNU General Public License for more details.
9854
9855 You should have received a copy of the GNU General Public License
9856 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.