* lisp/emacs-lisp/cl.el (flet): Fix case of obsolescence message.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e61d39cd 12012-09-28 Glenn Morris <rgm@gnu.org>
d393cefb
GM
2
3 * eval.c (Frun_hook_with_args, Frun_hook_with_args_until_success)
4 (Frun_hook_with_args_until_failure): Doc fixes.
5
404043ea
EZ
62012-09-28 Eli Zaretskii <eliz@gnu.org>
7
8 * xdisp.c (syms_of_xdisp) <Qredisplay_internal>: Rename from
9 Qautomatic_redisplay and change the symbol name. All users changed.
10
704d3f45
TM
112012-09-28 Tomohiro Matsuyama <tomo@cx4a.org>
12
13 * profiler.c (sigprof_handler): Fix race condition.
14
757140ff
GM
152012-09-28 Glenn Morris <rgm@gnu.org>
16
17 * lread.c (lisp_file_lexically_bound_p): Handle #! lines. (Bug#12528)
18
a615a3ae
PE
192012-09-27 Paul Eggert <eggert@cs.ucla.edu>
20
21 Check more robustly for timer_settime.
89d17fd0
PE
22 * Makefile.in (LIB_TIMER_TIME): New macro.
23 (LIBES): Add it.
a615a3ae
PE
24 * atimer.c (alarm_timer, alarm_timer_ok, set_alarm, init_atimer):
25 Use HAVE_TIMER_SETTIME, not SIGEV_SIGNAL, to decide whether to
26 call timer_settime.
27
3670daf7
TM
282012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
29
30 * profiler.c (Fprofiler_cpu_start): Remove unnecessary flag SA_SIGINFO.
31
6a586b7f
JB
322012-09-26 Juanma Barranquero <lekktu@gmail.com>
33
34 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
35
41c8bfcf
PE
362012-09-26 Paul Eggert <eggert@cs.ucla.edu>
37
38 * character.h (MAYBE_UNIFY_CHAR): Remove.
39 * charset.c, charset.h (maybe_unify_char): Now static.
40 * charset.c (decode_char): Use maybe_unify_char, not MAYBE_UNIFY_CHAR.
41 Since this stuff is now private to charset.c, there's no need for
42 a public macro and no need to inline by hand.
43
3a880af4
SM
442012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
45 Stefan Monnier <monnier@iro.umontreal.ca>
46 Juanma Barranquero <lekktu@gmail.com>
611b7507 47
3a880af4
SM
48 * profiler.c: New file.
49 * Makefile.in (base_obj): Add profiler.o.
611b7507
JB
50 * makefile.w32-in (OBJ2, GLOBAL_SOURCES): Add profiler.c.
51 ($(BLD)/profiler.$(O)): New target.
3a880af4
SM
52 * emacs.c (main): Call syms_of_profiler.
53 * alloc.c (Qautomatic_gc): New constant.
54 (MALLOC_PROBE): New macro.
55 (xmalloc, xzalloc, xrealloc, lisp_malloc, lisp_align_malloc): Use it.
56 (total_bytes_of_live_objects): New function.
57 (Fgarbage_collect): Use it. Record itself in backtrace_list.
58 Call malloc_probe for the memory profiler.
59 (syms_of_alloc): Define Qautomatic_gc.
60 * eval.c (eval_sub, Ffuncall): Reorder assignments to avoid
61 race condition.
62 (struct backtrace): Move definition...
63 * lisp.h (struct backtrace): ..here.
64 (Qautomatic_gc, profiler_memory_running): Declare vars.
65 (malloc_probe, syms_of_profiler): Declare functions.
66 * xdisp.c (Qautomatic_redisplay): New constant.
67 (redisplay_internal): Record itself in backtrace_list.
68 (syms_of_xdisp): Define Qautomatic_redisplay.
611b7507 69
b67238c2
JB
702012-09-25 Juanma Barranquero <lekktu@gmail.com>
71
72 * makefile.w32-in ($(BLD)/callproc.$(O)): Update dependencies.
73
e26fd2e4
PE
742012-09-25 Paul Eggert <eggert@cs.ucla.edu>
75
76 Prefer POSIX timers if available.
77 They avoid a race if the timer is too close to the current time.
78 * atimer.c (alarm_timer, alarm_timer_ok) [SIGEV_SIGNAL]: New static vars.
79 (set_alarm) [SIGEV_SIGNAL]: Use POSIX timers if available.
9180598c 80 (init_atimer) [SIGEV_SIGNAL]: Initialize them.
e26fd2e4 81
eedec3ee
EZ
822012-09-25 Eli Zaretskii <eliz@gnu.org>
83
84 * coding.c (CHAR_STRING_ADVANCE_NO_UNIFY): Make it an alias of
85 CHAR_STRING_ADVANCE.
86 (STRING_CHAR_ADVANCE_NO_UNIFY): Make it an alias of
87 STRING_CHAR_ADVANCE.
88
aa15c6bb
JB
892012-09-25 Juanma Barranquero <lekktu@gmail.com>
90
91 Move Vlibrary_cache to emacs.c and reset before dumping.
92
93 * lisp.h (reset_image_types): Declare.
94 [WINDOWSNT] (Vlibrary_cache): Declare.
95
96 * image.c (reset_image_types): New function.
97
98 * emacs.c [WINDOWSNT] (Vlibrary_cache): Move from w32.c.
99 (syms_of_emacs) [WINDOWSNT] <Vlibrary_cache>: Initialize and staticpro.
100 (Fdump_emacs): Reset Vlibrary_cache and image_types.
101
102 * w32.c (Vlibrary_cache): Do not define; moved to emacs.c
103 (globals_of_w32) <Vlibrary_cache>: Do not initialize.
104
105 * w32.h (Vlibrary_cache): Do not declare.
106
54d629be
EZ
1072012-09-25 Eli Zaretskii <eliz@gnu.org>
108
16b22fef
EZ
109 * w32proc.c (sys_signal): Handle all signals defined by the
110 MS-Windows runtime, not just SIGCHLD. Actually install the signal
111 handlers for signals supported by Windows. Don't override
112 term_ntproc as the handler for SIGABRT.
113 (sigaction): Rewrite to call sys_signal instead of duplicating its
114 code.
115 (sys_kill): Improve commentary.
116
117 * w32.c (term_ntproc): Accept (and ignore) one argument, for
118 consistency with a signature of a signal handler. All callers
119 changed.
120 (init_ntproc): Accept an argument DUMPING. If dumping, don't
121 install term_ntproc as a signal handler for SIGABRT, as that
122 should be done by the dumped Emacs.
123
124 * w32.h (init_ntproc, term_ntproc): Adjust prototypes.
125
126 * w32select.c (term_w32select): Protect against repeated
127 invocation by setting clipboard_owner to NULL after calling
128 DestroyWindow.
129
130 * emacs.c (shut_down_emacs, main): Adapt the calls to init_ntproc
131 and term_ntproc to their modified signatures.
132
54d629be
EZ
133 * character.c (char_string, string_char): Remove calls to
134 MAYBE_UNIFY_CHAR. See the discussion starting at
135 http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00433.html
136 for the details.
137
59f7af81
CY
1382012-09-25 Chong Yidong <cyd@gnu.org>
139
140 * xdisp.c (mode_line_inverse_video): Delete obsolete variable.
141
22e8cf4a
SM
1422012-09-24 Stefan Monnier <monnier@iro.umontreal.ca>
143
144 * bytecode.c (exec_byte_code): Signal an error instead of aborting,
145 when encountering an unknown bytecode.
146
578098f3
PE
1472012-09-24 Paul Eggert <eggert@cs.ucla.edu>
148
149 image.c, indent.c: Use bool for booleans.
150 * dispextern.h (struct image_type): Members valid_p, load, init
151 now return bool, not int. All uses changed.
152 * image.c: Omit unnecessary static decls.
153 (x_create_bitmap_mask, x_build_heuristic_mask):
154 Return void, not int, since callers don't care about the return value.
155 (x_create_bitmap_mask, define_image_type, valid_image_p)
156 (struct image_keyword, parse_image_spec, image_spec_value)
157 (check_image_size, image_background)
158 (image_background_transparent, x_clear_image_1)
159 (postprocess_image, lookup_image, x_check_image_size)
160 (x_create_x_image_and_pixmap, xbm_image_p)
161 (Create_Pixmap_From_Bitmap_Data, xbm_read_bitmap_data)
162 (xbm_load_image, xbm_file_p, xbm_load, xpm_lookup_color)
163 (init_xpm_functions, xpm_valid_color_symbols_p, xpm_image_p)
164 (xpm_load, xpm_load_image, lookup_rgb_color, lookup_pixel_color)
165 (x_to_xcolors, x_build_heuristic_mask, pbm_image_p, pbm_load)
166 (png_image_p, init_png_functions, png_load_body, png_load)
167 (jpeg_image_p, init_jpeg_functions, jpeg_load_body, jpeg_load)
168 (tiff_image_p, init_tiff_functions, tiff_load, gif_image_p)
169 (init_gif_functions, gif_load, imagemagick_image_p)
170 (imagemagick_load_image, imagemagick_load, svg_image_p)
171 (init_svg_functions, svg_load, svg_load_image, gs_image_p)
172 (gs_load):
173 * nsimage.m (ns_load_image):
174 * nsterm.m (ns_defined_color):
175 * xfaces.c (tty_lookup_color, tty_defined_color, defined_color):
176 * xfns.c (x_defined_color):
177 * xterm.c (x_alloc_lighter_color_for_widget)
178 (x_alloc_nearest_color_1, x_alloc_nearest_color)
179 (x_alloc_lighter_color):
180 * indent.c (disptab_matches_widthtab, current_column)
181 (scan_for_column, string_display_width, indented_beyond_p)
182 (compute_motion, vmotion, Fvertical_motion):
183 Use bool for booleans.
184
a5f2b6ec
CY
1852012-09-24 Chong Yidong <cyd@gnu.org>
186
187 * chartab.c (Fset_char_table_default): Obsolete function removed.
188
18e27ea8
PE
1892012-09-23 Paul Eggert <eggert@cs.ucla.edu>
190
afea8a8a
PE
191 Move pid_t related decls out of lisp.h.
192 * lisp.h, syswait.h (record_child_status_change, wait_for_termination)
193 (interruptible_wait_for_termination):
194 Move these decls from lisp.h to syswait.h, since they use pid_t.
195 Needed on FreeBSD; see Herbert J. Skuhra in
196 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00571.html>.
197 * callproc.c: Include syswait.h.
198
18e27ea8
PE
199 gnutls.c, gtkutil.c: Use bool for boolean.
200 * gnutls.c (gnutls_global_initialized, init_gnutls_functions)
201 (emacs_gnutls_handle_error):
202 * gtkutil.c (xg_check_special_colors, xg_prepare_tooltip)
203 (xg_hide_tooltip, xg_create_frame_widgets)
204 (create_dialog, xg_uses_old_file_dialog)
205 (xg_get_file_with_chooser, xg_get_file_with_selection)
206 (xg_get_file_name, xg_have_tear_offs, create_menus, xg_create_widget)
207 (xg_item_label_same_p, xg_update_menubar)
208 (xg_modify_menubar_widgets, xg_event_is_for_menubar)
209 (xg_ignore_gtk_scrollbar, xg_set_toolkit_scroll_bar_thumb)
210 (xg_event_is_for_scrollbar, xg_pack_tool_bar, xg_make_tool_item)
211 (is_box_type, xg_tool_item_stale_p, xg_update_tool_bar_sizes)
212 (update_frame_tool_bar, free_frame_tool_bar):
213 * gtkutil.c, w32term.c, xterm.c (x_wm_set_size_hint):
214 * nsmenu.m (ns_update_menubar):
215 * nsmenu.m, w32menu.c, xmenu.c (set_frame_menubar):
216 * xfns.c (Fx_show_tip) [USE_GTK]:
217 Use bool for boolean.
218 * gtkutil.c (xg_update_frame_menubar):
219 * xmenu.c (update_frame_menubar):
220 Return void, not int, since caller ignores return value.
221 * gtkutil.c (xg_change_toolbar_position):
222 Return void, not 1.
223
af0e9f75
JB
2242012-09-23 Juanma Barranquero <lekktu@gmail.com>
225
226 * makefile.w32-in (BLOCKINPUT_H): Remove.
227 (SYSSIGNAL_H): New macro.
228 ($(BLD)/alloc.$(O), $(BLD)/atimer.$(O), $(BLD)/buffer.$(O))
229 ($(BLD)/callproc.$(O), $(BLD)/data.$(O), $(BLD)/dired.$(O))
230 ($(BLD)/dispnew.$(O), $(BLD)/editfns.$(O), $(BLD)/emacs.$(O))
231 ($(BLD)/eval.$(O), $(BLD)/fileio.$(O), $(BLD)/floatfns.$(O))
232 ($(BLD)/fns.$(O), $(BLD)/fontset.$(O), $(BLD)/frame.$(O))
233 ($(BLD)/fringe.$(O), $(BLD)/image.$(O), $(BLD)/insdel.$(O))
234 ($(BLD)/keyboard.$(O), $(BLD)/keymap.$(O), $(BLD)/lread.$(O))
235 ($(BLD)/menu.$(O), $(BLD)/w32inevt.$(O), $(BLD)/w32proc.$(O))
236 ($(BLD)/print.$(O), $(BLD)/process.$(O), $(BLD)/ralloc.$(O))
237 ($(BLD)/search.$(O), $(BLD)/sound.$(O), $(BLD)/sysdep.$(O))
238 ($(BLD)/term.$(O), $(BLD)/window.$(O), $(BLD)/xdisp.$(O))
239 ($(BLD)/xfaces.$(O), $(BLD)/w32fns.$(O), $(BLD)/w32menu.$(O))
240 ($(BLD)/w32term.$(O), $(BLD)/w32select.$(O), $(BLD)/w32reg.$(O))
241 ($(BLD)/w32xfns.$(O)): Update dependencies.
242
5101529e
EZ
2432012-09-23 Eli Zaretskii <eliz@gnu.org>
244
245 * .gdbinit: Set breakpoint on terminate_due_to_signal, not on
246 fatal_error_backtrace.
247
248 * w32proc.c (sys_kill): Undo last change: don't do anything when
249 invoked to deliver SIGABRT to our own process. This is now
250 handled by emacs_raise.
251
2c3ee0ad
JB
2522012-09-23 Juanma Barranquero <lekktu@gmail.com>
253
254 * w32term.c (w32_read_socket): Remove leftover reference to
255 interrupt_input_pending.
256
62a1d661
PE
2572012-09-23 Paul Eggert <eggert@cs.ucla.edu>
258
259 Do not use SA_NODEFER.
260 Problem reported by Dani Moncayo in
261 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00557.html>.
262 * alloc.c (die):
263 * sysdep.c (emacs_abort): Do not reset signal handler.
264 * emacs.c (terminate_due_to_signal): Reset signal handler here.
265 * sysdep.c (init_signals): Do not use SA_NODEFER. It wasn't
266 wanted even on POSIXish hosts, and it doesn't work on Windows.
267
a0942b9a
JD
2682012-09-23 Jan Djärv <jan.h.d@swipnet.se>
269
270 * xterm.c (x_term_init): Call fixup_locale before and after calling
271 gtk_init (Bug#12392).
272
d07ff9db
CY
2732012-09-23 Chong Yidong <cyd@gnu.org>
274
275 * w32.c (w32_delayed_load): Remove LIBRARIES argument; always use
276 Vdynamic_library_alist.
277
278 * gnutls.c (init_gnutls_functions): Caller changed; remove arg.
279 (Fgnutls_available_p): Caller changed.
280
281 * xml.c (init_libxml2_functions, Flibxml_parse_html_region)
282 (Flibxml_parse_xml_region): Likewise.
283
284 * dispextern.h (struct image_type): Remove arg from init function.
285
286 * image.c (Finit_image_library, lookup_image_type)
287 (define_image_type): Remove now-unneeded second arg.
288 (init_xpm_functions, init_png_functions, init_jpeg_functions)
289 (init_tiff_functions, init_gif_functions, init_svg_functions):
290 Arglist and w32_delayed_load calling convention changed.
291 (gs_type): Remove init_gs_functions; there is no such function.
641cfd14 292 (valid_image_p, make_image): Fix caller to lookup_image_type.
d07ff9db 293
4d7e6e51
PE
2942012-09-23 Paul Eggert <eggert@cs.ucla.edu>
295
296 Simplify and avoid signal-handling races (Bug#12471).
297 * alloc.c (die):
298 * sysdep.c (emacs_abort) [HAVE_NTGUI]:
299 Avoid recursive loop if there's a fatal error in the function itself.
300 * atimer.c (pending_atimers):
301 * blockinput.h: Don't include "atimer.h"; no longer needed.
302 (interrupt_input_pending): Remove. All uses removed.
303 pending_signals now counts both atimers and ordinary interrupts.
304 This is less racy than having three separate pending-signal flags.
305 (block_input, unblock_input, totally_unblock_input, unblock_input_to)
306 (input_blocked_p):
307 Rename from their upper-case counterparts BLOCK_INPUT,
308 UNBLOCK_INPUT, TOTALLY_UNBLOCK_INPUT, UNBLOCK_INPUT_TO,
309 INPUT_BLOCKED_P, and turn into functions. All uses changed.
310 This makes it easier to access volatile variables more accurately.
311 (BLOCK_INPUT_RESIGNAL): Remove. All uses replaced by unblock_input ().
312 (input_blocked_p): Prefer this to 'interrupt_input_blocked', as
313 that's more reliable if the code is buggy and sets
314 interrupt_input_blocked to a negative value. All uses changed.
315 * atimer.c (deliver_alarm_signal):
316 Remove. No need to deliver this to the parent; any thread can
317 handle this signal now. All uses replaced by underlying handler.
318 * atimer.c (turn_on_atimers):
319 * dispnew.c (handle_window_change_signal):
320 * emacs.c (handle_danger_signal):
321 * keyboard.c (kbd_buffer_get_event):
322 Don't reestablish signal handler; not needed with sigaction.
323 * blockinput.h (UNBLOCK_INPUT_TO, TOTALLY_UNBLOCK_INPUT)
324 (UNBLOCK_INPUT_TO):
325 Rework to avoid unnecessary accesses to volatile variables.
326 (UNBLOCK_INPUT_TO): Now a function.
327 (totally_unblock_input, unblock_input): New decls.
328 * data.c (handle_arith_signal, deliver_arith_signal): Move to sysdep.c
329 (init_data): Remove. Necessary stuff now done in init_signal.
330 * emacs.c, xdisp.c: Include "atimer.h", since we invoke atimer functions.
331 * emacs.c (handle_fatal_signal, deliver_fatal_signal): Move to sysdep.c.
332 (fatal_error_code): Remove; no longer needed.
333 (terminate_due_to_signal): Rename from fatal_error_backtrace, since
334 it doesn't always backtrace. All uses changed. No need to reset
335 signal to default, since sigaction and/or die does that for us now.
336 Use emacs_raise (FOO), not kill (getpid (), FOO).
337 (main): Check more-accurately whether we're dumping.
338 Move fatal-error setup to sysdep.c
339 * floatfns.c: Do not include "syssignal.h"; no longer needed.
340 * gtkutil.c (xg_get_file_name, xg_get_font):
341 Remove no-longer-needed signal-mask manipulation.
342 * keyboard.c, process.c (POLL_FOR_INPUT):
343 Don't depend on USE_ASYNC_EVENTS, a symbol that is never defined.
344 * keyboard.c (read_avail_input): Remove.
345 All uses replaced by gobble_input.
346 (Ftop_level): Use TOTALLY_UNBLOCK_INPUT rather than open code.
347 (kbd_buffer_store_event_hold, gobble_input):
348 (record_asynch_buffer_change) [USABLE_SIGIO]:
349 (store_user_signal_events):
350 No need to mess with signal mask.
351 (gobble_input): If blocking input and there are terminals, simply
352 set pending_signals to 1 and return. All hooks changed to not
353 worry about whether input is blocked.
354 (process_pending_signals): Clear pending_signals before processing
355 them, in case a signal comes in while we're processing.
356 By convention callers now test pending_signals before calling us.
357 (UNBLOCK_INPUT_TO, unblock_input, totally_unblock_input):
358 New functions, to support changes to blockinput.h.
359 (handle_input_available_signal): Now extern.
360 (reinvoke_input_signal): Remove. All uses replaced by
361 handle_async_input.
362 (quit_count): Now volatile, since a signal handler uses it.
3a880af4
SM
363 (handle_interrupt): Now takes bool IN_SIGNAL_HANDLER as arg.
364 All callers changed. Block SIGINT only if not already blocked.
4d7e6e51
PE
365 Clear sigmask reliably, even if Fsignal returns, which it can.
366 Omit unnecessary accesses to volatile var.
367 (quit_throw_to_read_char): No need to restore sigmask.
368 * keyboard.c (gobble_input, handle_user_signal):
369 * process.c (wait_reading_process_output):
370 Call signal-handling code rather than killing ourselves.
371 * lisp.h: Include <float.h>, for...
372 (IEEE_FLOATING_POINT): New macro, moved here to avoid duplication.
373 (pending_signals): Now volatile.
374 (syms_of_data): Now const if IEEE floating point.
375 (handle_input_available_signal) [USABLE_SIGIO]:
376 (terminate_due_to_signal, record_child_status_change): New decls.
377 * process.c (create_process): Avoid disaster if memory is exhausted
378 while we're processing a vfork, by tightening the critical section
379 around the vfork.
380 (send_process_frame, process_sent_to, handle_pipe_signal)
381 (deliver_pipe_signal): Remove. No longer needed, as Emacs now
382 ignores SIGPIPE.
383 (send_process): No need for setjmp/longjmp any more, since the
384 SIGPIPE stuff is now gone. Instead, report an error if errno
385 is EPIPE.
386 (record_child_status_change): Now extern. PID and W are now args.
387 Return void, not bool. All callers changed.
388 * sysdep.c (wait_debugging) [(BSD_SYSTEM || HPUX) && !defined (__GNU__)]:
389 Remove. All uses removed. This bug should be fixed now in a
390 different way.
391 (wait_for_termination_1): Use waitpid rather than sigsuspend,
392 and record the child status change directly. This avoids the
393 need to futz with the signal mask.
394 (process_fatal_action): Move here from emacs.c.
395 (emacs_sigaction_flags): New function, containing
396 much of what used to be in emacs_sigaction_init.
397 (emacs_sigaction_init): Use it. Block nonfatal system signals that are
398 caught by emacs, to make races less likely.
399 (deliver_process_signal): Rename from handle_on_main_thread.
400 All uses changed.
401 (BACKTRACE_LIMIT_MAX): Now at top level.
402 (thread_backtrace_buffer, threadback_backtrace_pointers):
403 New static vars.
404 (deliver_thread_signal, deliver_fatal_thread_signal):
405 New functions, for more-accurate delivery of thread-specific signals.
406 (handle_fatal_signal, deliver_fatal_signal): Move here from emacs.c.
407 (deliver_arith_signal): Handle in this thread, not
408 in the main thread, since it's triggered by this thread.
409 (maybe_fatal_sig): New function.
410 (init_signals): New arg DUMPING so that we can be more accurate
411 about whether we're dumping. Caller changed.
412 Treat thread-specific signals differently from process-general signals.
413 Block all signals while handling fatal error; that's safer.
414 xsignal from SIGFPE only on non-IEEE hosts, treating it as fatal
415 on IEEE hosts.
416 When batch, ignore SIGHUP, SIGINT, SIGTERM if they were already ignored.
417 Ignore SIGPIPE unless batch.
418 (emacs_backtrace): Output backtrace for the appropriate thread,
419 which is not necessarily the main thread.
420 * syssignal.h: Include <stdbool.h>.
421 (emacs_raise): New macro.
422 * xterm.c (x_connection_signal): Remove; no longer needed
423 now that we use sigaction.
424 (x_connection_closed): No need to mess with sigmask now.
425 (x_initialize): No need to reset SIGPIPE handler here, since
426 init_signals does this for us now.
427
8f4635e9
JD
4282012-09-23 Jan Djärv <jan.h.d@swipnet.se>
429
430 * nsterm.m (ns_dumpglyphs_image): dr is a new rect to draw image into,
fb39b937 431 background rect may be larger (Bug#12245).
8f4635e9 432
3296976d
CY
4332012-09-23 Chong Yidong <cyd@gnu.org>
434
435 * keyboard.c (timer_check): Avoid quitting during Fcopy_sequence.
436
d41e491e
PE
4372012-09-22 Paul Eggert <eggert@cs.ucla.edu>
438
439 * .gdbinit: Just stop at fatal_error_backtrace.
440 See Stefan Monnier's request in
441 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00549.html>.
442 Remove no-longer-used query of system type.
443
c88b867f
CY
4442012-09-22 Chong Yidong <cyd@gnu.org>
445
446 * search.c (Freplace_match): Doc fix (Bug#12325).
447
448 * minibuf.c (Finternal_complete_buffer): Doc fix (Bug#12391).
449
450 * editfns.c (Fline_beginning_position): Doc fix (Bug#12416).
451 (Fline_end_position): Doc fix.
452
453 * cmds.c (Fforward_char, Fbackward_char): Doc fix (Bug#12414).
454
bb4d86b4
CY
4552012-09-22 Chong Yidong <cyd@gnu.org>
456
457 * dispextern.h (struct image_type): Add new slot, storing a type
458 initialization function.
459
460 * image.c (define_image_type): Call the image initializer function
461 if it is defined. Arguments and return value changed.
462 (valid_image_p, make_image): Callers changed.
463 (xbm_type, xpm_type, pbm_type, png_type, jpeg_type, tiff_type)
3a880af4
SM
464 (gif_type, imagemagick_type, svg_type, gs_type):
465 Add initialization functions.
bb4d86b4
CY
466 (Finit_image_library): Call lookup_image_type.
467 (CHECK_LIB_AVAILABLE): Macro deleted.
468 (lookup_image_type): Call define_image_type here, rather than via
469 Finit_image_library, and without using CHECK_LIB_AVAILABLE.
470 (syms_of_image): Move define_image_type calls for xbm_type and
471 pbm_type to lookup_image_type.
472
df9685f3
EZ
4732012-09-22 Eli Zaretskii <eliz@gnu.org>
474
475 * keyboard.c (timer_check_2): Move calculation of 'timers' and
476 'idle_timers' from here ...
477 (timer_check): ... to here. Use Fcopy_sequence to copy the timer
478 lists, to avoid infloops when the timer does something stupid,
479 like reinvoke itself with the same or smaller time-out.
480 (Bug#12447)
481
8e17c9ba
MR
4822012-09-22 Martin Rudalics <rudalics@gmx.at>
483
484 * window.c (Fsplit_window_internal): Handle only Qt value of
485 Vwindow_combination_limit separately.
486 (Qtemp_buffer_resize): New symbol.
3a880af4
SM
487 (Vwindow_combination_limit): New default value.
488 Rewrite doc-string.
8e17c9ba 489
589bd69b
EZ
4902012-09-22 Eli Zaretskii <eliz@gnu.org>
491
492 * xdisp.c (next_overlay_string): Initialize it->end_charpos for
493 the new overlay string. (Bug#10159)
494
01108e3f
PE
4952012-09-22 Paul Eggert <eggert@cs.ucla.edu>
496
497 * emacs.c (shut_down_emacs): Don't assume stderr is buffered,
498 or that fprintf is async-signal-safe. POSIX doesn't require
499 either assumption.
500
82f8cd94
CY
5012012-09-22 Chong Yidong <cyd@gnu.org>
502
503 * buffer.c (Fset_buffer_modified_p): Handle indirect buffers
504 (Bug#8207).
505
3cccbd87
KH
5062012-09-22 Kenichi Handa <handa@gnu.org>
507
508 * composite.c (composition_reseat_it): Handle the case that a
509 grapheme cluster is not covered by a single font (Bug#12352).
510
09c01941
CY
5112012-09-21 Chong Yidong <cyd@gnu.org>
512
513 * image.c (define_image_type): Avoid adding duplicate types to
514 image_types (Bug#12463). Suggested by Jörg Walter.
515
acfa068f 5162012-09-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
e25c1a30
YM
517
518 * unexmacosx.c: Define LC_DATA_IN_CODE if not defined.
519 (print_load_command_name): Add case LC_DATA_IN_CODE.
520 (dump_it) [LC_DATA_IN_CODE]: Call copy_linkedit_data.
521
acfa068f 5222012-09-21 Glenn Morris <rgm@gnu.org>
1e9bbf47
GM
523
524 * eval.c (Frun_hook_with_args_until_success)
525 (Frun_hook_with_args_until_failure): Doc fixes. (Bug#12393)
526
acfa068f 5272012-09-21 Andreas Schwab <schwab@linux-m68k.org>
c6ba4138
AS
528
529 * fileio.c (Ffile_selinux_context): Only call freecon when
530 lgetfilecon succeeded.
531 (Fset_file_selinux_context): Likewise. (Bug#12444)
532
acfa068f 5332012-09-21 Eli Zaretskii <eliz@gnu.org>
aa36e4d2
EZ
534
535 * xdisp.c (try_window_reusing_current_matrix): Under bidi
536 reordering, locate the cursor by calling set_cursor_from_row; if
537 that fails, clear the desired glyph matrix before returning a
538 failure indication to the caller. Fixes leaving garbled display
539 when fast scrolling with a down-key. (Bug#12403)
f2016bea
EZ
540 (compute_stop_pos_backwards): Fix a typo that caused crashes while
541 scrolling through multibyte text.
aa36e4d2 542
e99f70c8
SM
5432012-09-20 Stefan Monnier <monnier@iro.umontreal.ca>
544
545 * alloc.c (mark_object) <PVEC_WINDOW>: Mark prev/next_buffers *after*
546 calling mark_vectorlike since that's the one that marks the window.
547 (mark_discard_killed_buffers): Mark the final cdr.
548 * window.h (struct window): Move prev/next_buffers to the
549 non-standard fields.
550 * window.c (make_window): Initialize prev/next_buffers manually.
551
f75beb47
PE
5522012-09-20 Paul Eggert <eggert@cs.ucla.edu>
553
554 Omit unused arg EXPECTED from socket hooks.
555 * keyboard.c (gobble_input, read_avail_input, tty_read_avail_input):
556 * nsterm.m (ns_term_init):
557 * termhooks.h (struct terminal.read_socket_hook):
558 * w32inevt.c (w32_console_read_socket):
559 * w32term.c (w32_read_socket):
560 * xterm.c (XTread_socket):
561 Omit unused arg EXPECTED. All callers changed.
562 (store_user_signal_events): Return void, not int, since callers no
563 longer care about the return value. All uses changed.
564
b019b76a
JB
5652012-09-20 Juanma Barranquero <lekktu@gmail.com>
566
567 * w32gui.h (XParseGeometry): Do not declare.
568
05642592
PE
5692012-09-19 Paul Eggert <eggert@cs.ucla.edu>
570
e4bce92a
PE
571 * w32inevt.c (w32_console_read_socket): Return -1 on failure, not 0.
572 Ignore 'expected'. See Eli Zaretskii in
573 <http://bugs.gnu.org/12471#8> (last line).
574
05642592
PE
575 * frame.c (read_integer): Remove. All uses replaced by strtol/strtoul.
576 (XParseGeometry): Now static. Substitute extremal values for
577 values that are out of range.
578
e543ae91
JD
5792012-09-19 Jan Djärv <jan.h.d@swipnet.se>
580
581 * w32xfns.c (read_integer, XParseGeometry): Move to frame.c.
582
583 * nsfns.m (XParseGeometry): Remove.
584 (Fx_create_frame): Call x_set_offset to correctly interpret
585 top_pos in geometry.
586
3a880af4 587 * frame.c (read_integer, XParseGeometry): Move from w32xfns.c.
e543ae91
JD
588 (Fx_parse_geometry): If there is a space in string, call
589 Qns_parse_geometry, otherwise do as on other terms (Bug#12368).
590
45ba16c7
EZ
5912012-09-17 Eli Zaretskii <eliz@gnu.org>
592
c8b9f1bc
EZ
593 * search.c (scan_buffer): Use character positions in calls to
594 region_cache_forward and region_cache_backward, not byte
595 positions. (Bug#12196)
596
b4c932a2
EZ
597 * w32term.c (w32_read_socket): Set pending_signals to 1, like
598 xterm.c does. Reported by Daniel Colascione <dancol@dancol.org>.
599
45ba16c7
EZ
600 * ralloc.c (r_alloc_init) [!SYSTEM_MALLOC]: Initialize
601 __malloc_extra_blocks to 32 instead of 64, like alloc.c did in
602 emacs_blocked_malloc, now deleted.
603
eeceac93
PE
6042012-09-17 Paul Eggert <eggert@cs.ucla.edu>
605
606 Remove no-longer-needed Solaris 2.4 vfork bug workaround.
607 The workaround was for improving performance on Solaris 2.4, but
608 is getting in the way now. Emacs will still work if someone is
609 still running Solaris 2.4 in a museum somewhere; Sun dropped
610 support for Solaris 2.4 in 2003.
611 * callproc.c (Fcall_process) [HAVE_WORKING_VFORK]:
612 * process.c (create_process) [HAVE_WORKING_VFORK]:
613 Omit now-unnecessary workaround for the Solaris 2.4 vfork bug,
614 since Emacs no longer uses vfork on that platform.
615
78f83752
GM
6162012-09-17 Glenn Morris <rgm@gnu.org>
617
618 * emacs.c: Use COPYRIGHT.
619
634b8cac
PE
6202012-09-16 Paul Eggert <eggert@cs.ucla.edu>
621
0caaedb1
PE
622 Remove configure's --without-sync-input option (Bug#12450).
623 When auditing signal-handling in preparation for cleaning it up,
624 I found that SYNC_INPUT has race conditions and would be a real
625 pain to fix. Since it's an undocumented and deprecated
626 configure-time option, now seems like a good time to remove it.
627 Also see <http://bugs.gnu.org/11080#16>.
628 * alloc.c (_bytes_used, __malloc_extra_blocks, _malloc_internal)
629 (_free_internal) [!DOUG_LEA_MALLOC]: Remove decls.
630 (alloc_mutex) [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
631 (malloc_hysteresis):
632 (check_depth) [XMALLOC_OVERRUN_CHECK]:
633 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT):
634 (__malloc_hook, __realloc_hook, __free_hook, BYTES_USED)
635 (dont_register_blocks, bytes_used_when_reconsidered)
636 (bytes_used_when_full, emacs_blocked_free, emacs_blocked_malloc)
637 (emacs_blocked_realloc, reset_malloc_hooks, uninterrupt_malloc):
638 [!SYSTEM_MALLOC && !SYNC_INPUT]:
639 Remove. All uses removed.
640 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT): Use a different
641 implementation, one that depends on whether the new macro
642 XMALLOC_BLOCK_INPUT_CHECK is defined, not on whether SYNC_INPUT
643 is defined.
644 * atimer.c (run_timers, handle_alarm_signal):
645 * keyboard.c (pending_signal, poll_for_input_1, poll_for_input)
646 (handle_async_input, process_pending_signals)
647 (handle_input_available_signal, init_keyboard):
648 * nsterm.m (ns_read_socket):
649 * process.c (wait_reading_process_output):
650 * regex.c (immediate_quit, IMMEDIATE_QUIT_CHECK):
651 * sysdep.c (emacs_sigaction_init) [SA_RESTART]:
652 (emacs_write):
653 * xterm.c (XTread_socket):
654 Assume SYNC_INPUT.
655 * conf_post.h (SA_RESTART) [IRIX6_5]: Do not #undef.
656 * eval.c (handling_signal): Remove. All uses removed.
657 * lisp.h (ELSE_PENDING_SIGNALS): Remove.
658 All uses replaced with the SYNC_INPUT version.
659 (reset_malloc_hooks, uninterrupt_malloc, handling_signal):
660 Remove decls.
661 * sysdep.c, syssignal.h (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
662 Now static.
663
634b8cac
PE
664 * font.c (Ffont_shape_gstring): Remove unused local.
665
83da1b55
GM
6662012-09-16 Glenn Morris <rgm@gnu.org>
667
518650a5
GM
668 * Makefile.in (clean): No longer run nextstep's clean.
669
83da1b55
GM
670 * Makefile.in (ns_appdir, ns_appbindir, ns_appsrc): Remove variables.
671 (ns_frag): Remove.
672 (ns-app): Move here from ns.mk, and simplify.
673 (clean): Simplify nextstep entry.
674 * ns.mk: Remove file.
675
85a43e2e
KH
6762012-09-17 Kenichi Handa <handa@gnu.org>
677
678 * font.c (Ffont_shape_gstring): Fix previous change; GLYPHs may
679 not covert the last few charactes.
680
ba13e616 6812012-09-16 Kenichi Handa <handa@gnu.org>
ea964864
KH
682
683 * font.c (Ffont_shape_gstring): Don't adjust grapheme cluster
684 here, but just check the validity of glyphs in the glyph-string.
685
a8c729af
MR
6862012-09-16 Martin Rudalics <rudalics@gmx.at>
687
3a880af4
SM
688 * window.c (Fwindow_parameter, Fset_window_parameter):
689 Accept any window as argument (Bug#12452).
a8c729af 690
c077c059
JD
6912012-09-16 Jan Djärv <jan.h.d@swipnet.se>
692
693 * nsfns.m (Fx_open_connection): Move initialization of ns_*_types
694 to ns_term_init to avoid memory leak.
695
696 * nsterm.m (ns_update_begin): Initialize bp after lcokFocus, use
697 explicit retain/release.
698 (ns_term_init): Only allow one display. Initialize outerpool and
699 ns_*_types.
700
39a57ad0
PE
7012012-09-15 Paul Eggert <eggert@cs.ucla.edu>
702
703 Port _setjmp fix to POSIXish hosts as well as Microsoft.
704 * image.c (_setjmp) [!HAVE__SETJMP]: Restore definition, as
705 it's needed on POSIXish hosts that lack _setjmp. Attempt to solve
706 the Microsoft problem in a different way, by altering ../nt/config.nt.
707
7105c8cb
EZ
7082012-09-15 Eli Zaretskii <eliz@gnu.org>
709
710 * w32xfns.c:
711 * w32uniscribe.c:
712 * w32term.c:
713 * w32select.c:
714 * w32reg.c:
715 * w32proc.c:
716 * w32menu.c:
717 * w32inevt.c:
718 * w32heap.c:
719 * w32font.c:
720 * w32fns.c:
721 * w32console.c:
722 * w32.c:
723 * w16select.c: Remove inclusion of setjmp.h, as it is now included
724 by lisp.h. This completes removal of setjmp.h inclusion
725 erroneously announced in the previous commit. (Bug#12446)
726
727 * lisp.h [!HAVE__SETJMP, !HAVE_SIGSETJMP]: Make the commentary
728 more accurate.
729
730 * image.c (_setjmp) [!HAVE__SETJMP]: Define only if 'setjmp' is
731 not defined as a macro. The latter happens on MS-Windows.
732 (Bug#12446)
733
0328b6de
PE
7342012-09-15 Paul Eggert <eggert@cs.ucla.edu>
735
736 Port better to POSIX hosts lacking _setjmp (Bug#12446).
737 * lisp.h: Include <setjmp.h> here, since we use its symbols here.
7105c8cb 738 Some instances of '#include <setjmp.h>' removed, if the
0328b6de
PE
739 only reason for the instance was because "lisp.h" was included.
740 (sys_jmp_buf, sys_setjmp, sys_longjmp): New symbols.
741 Unless otherwise specified, replace all uses of jmp_buf, _setjmp,
742 and _longjmp with the new symbols. Emacs already uses _setjmp if
743 available, so this change affects only POSIXish hosts that have
744 sigsetjmp but not _setjmp, such as some versions of Solaris and
745 Unixware. (Also, POSIX-2008 marks _setjmp as obsolescent.)
746 * image.c (_setjmp, _longjmp) [HAVE_PNG && !HAVE__SETJMP]: New macros.
747 (png_load_body) [HAVE_PNG]:
748 (PNG_LONGJMP) [HAVE_PNG && PNG_LIBPNG_VER < 10500]:
749 (PNG_JMPBUF) [HAVE_PNG && PNG_LIBPNG_VER >= 10500]:
750 Use _setjmp and _longjmp rather than sys_setjmp and sys_longjmp,
751 since PNG requires jmp_buf. This is the only exception to the
752 general rule that we now use sys_setjmp and sys_longjmp.
753 This exception is OK since this code does not change the signal
754 mask or longjmp out of a signal handler.
755
2af03429
PE
7562012-09-14 Paul Eggert <eggert@cs.ucla.edu>
757
758 * alloc.c [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
759 Include "syssignal.h", for 'main_thread'.
760
2f294edf
DA
7612012-09-14 Dmitry Antipov <dmantipov@yandex.ru>
762
763 Avoid out-of-range marker position (Bug#12426).
3a880af4
SM
764 * insdel.c (replace_range, replace_range_2):
765 Adjust markers before overlays, as suggested by comments.
2f294edf
DA
766 (insert_1_both, insert_from_buffer_1, adjust_after_replace):
767 Remove redundant check before calling offset_intervals.
768
6b533e9c
MR
7692012-09-14 Martin Rudalics <rudalics@gmx.at>
770
771 * xdisp.c (Fformat_mode_line): Unconditionally save/restore
772 current buffer (Bug#12387).
773
2a7931e3
JB
7742012-09-14 Juanma Barranquero <lekktu@gmail.com>
775
776 * makefile.w32-in ($(BLD)/alloc.$(O)): Update dependencies.
777
c18e885b
PE
7782012-09-13 Paul Eggert <eggert@cs.ucla.edu>
779
780 Use a more backwards-compatible timer format (Bug#12430).
781 * keyboard.c (decode_timer): Get PSECS from the 8th (origin-0)
782 vector element, not from the 4th, since PSECS is now at the end.
783 (Fcurrent_idle_time): Doc fix.
784
d59a1afb
DA
7852012-09-13 Dmitry Antipov <dmantipov@yandex.ru>
786
787 Function to mark objects and remove killed buffers at once.
788 * alloc.c (discard_killed_buffers): Rename to ...
789 (mark_discard_killed buffers) ... new name. Add marking
790 of remaining objects. Fix comment. Adjust users.
791 (mark_object): Do not touch frame buffer lists here.
792 * frame.c (delete_frame): Reset frame buffer lists here.
793
5f0cb45a
PE
7942012-09-13 Paul Eggert <eggert@cs.ucla.edu>
795
8ea47e3a
PE
796 Better workaround for GNOME bug when --enable-gcc-warnings.
797 * emacsgtkfixed.c (G_STATIC_ASSERT): Remove, undoing last change.
798 Instead, disable -Wunused-local-typedefs. See Dmitry Antipov in
799 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00335.html>.
800
4a4bbad2
PE
801 Simplify SIGIO usage (Bug#12408).
802 The code that dealt with SIGIO was crufty and confusing, e.g., it
803 played tricks like "#undef SIGIO" but these tricks were not used
804 consistently. Simplify mostly by not #undeffing standard symbols,
805 e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
806 or not as we please) rather than "defined SIGIO" (standard symbol
807 that we probably shouldn't #undef).
808 * conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
809 Modules that need it can include it.
810 [USG5_4 && emacs]: Likewise, do not include the streams stuff here.
811 * dispextern.h (ignore_sigio): New decl.
812 * emacs.c (shut_down_emacs): Invoke unrequest_sigio
813 unconditionally, since it's now a no-op if !USABLE_SIGIO.
814 * emacs.c (shut_down_emacs):
815 * keyboard.c (kbd_buffer_store_event_hold):
816 Use ignore_sigio rather than invoking 'signal' directly.
817 * keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
818 for FIONREAD.
819 (FIONREAD, SIGIO): Do not #undef.
820 (tty_read_avail_input): Use #error rather than a syntax error.
821 * process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
822 for I_PIPE, used by SETUP_SLAVE_PTY.
823 (DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
824 * sysdep.c (croak): Remove; no longer needed. This bit of
825 temporary code, with Fred N. Fish's comment that it's temporary,
826 has been in Emacs since at least 1992!
827 (init_sigio, reset_sigio, request_sigio, unrequest_sigio):
828 Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
829 * syssignal.h (croak): Remove decl.
830 (SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
831 * systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
832 now that we're termios-only.
833 (FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
834 * term.c (dissociate_if_controlling_tty): Use #error rather than
835 a run-time error.
836
5f0cb45a
PE
837 Work around GCC and GNOME bugs when --enable-gcc-warnings.
838 * emacsgtkfixed.c (G_STATIC_ASSERT): Redefine to use 'verify',
839 to work around GNOME bug 683906.
840 * image.c (jpeg_load_body) [HAVE_JPEG && lint]: Pacify gcc -Wclobber.
841 (struct my_jpeg_error_mgr) [HAVE_JPEG && lint]: New member fp.
842 This works around GCC bug 54561.
843
40bce90b
PE
8442012-09-12 Paul Eggert <eggert@cs.ucla.edu>
845
846 More fixes for 'volatile' and setjmp/longjmp.
847 * eval.c (Fdefvar, Fcondition_case): Remove unnecessary 'volatile's.
848 * image.c (struct png_load_context) [HAVE_PNG]: New type.
849 (png_load_body) [HAVE_PNG]:
850 (jpeg_load_body) [HAVE_JPEG]:
851 New function, with most of the old parent function's body.
852 (png_load) [HAVE_PNG]:
853 (jpeg_load) [HAVE_JPEG]:
854 Invoke the new function, to avoid longjmp munging our locals.
855 (struct my_jpeg_error_mgr) [HAVE_JPEG]: New members cinfo, failure_code.
856 (my_error_exit) [HAVE_JPEG]: Don't trust 'setjmp' to return 2 when
857 longjmp is passed 2, as the C standard doesn't guarantee this.
858 Instead, store the failure code into mgr->failure_code.
859
bfeae2cf
SM
8602012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
861
862 * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
863 (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
864 (syms_of_keyboard): Remove support for unread-command-char.
865
8099e36b
EZ
8662012-09-12 Eli Zaretskii <eliz@gnu.org>
867
868 * w32proc.c (sys_kill): If PID is our process ID and the signal is
869 SIGABRT, call emacs_abort. Avoids silently exiting upon assertion
870 violation. (Bug#12426)
871
92547ff9
PE
8722012-09-12 Paul Eggert <eggert@cs.ucla.edu>
873
874 * image.c (jpeg_memory_src): Don't assume string len fits in unsigned.
875
45b82ad0
SM
8762012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
877
878 * eval.c: Add `inhibit-debugger'.
879 (Qinhibit_debugger): New symbol.
880 (call_debugger): Bind it instead of Qdebug_on_error.
881 (maybe_call_debugger): Test Vinhibit_debugger.
882 (syms_of_eval): Define inhibit-debugger.
883 * xdisp.c (set_message): Don't bind Qinhibit_debug_on_message.
884 (syms_of_xdisp): Remove inhibit-debug-on-message.
885
5779a1dc
PE
8862012-09-11 Paul Eggert <eggert@cs.ucla.edu>
887
50f2e553
PE
888 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
889 If a nonvolatile local variable is written before a _longjmp to
890 the frame containing the variable, and is read after the _longjmp,
891 the value read is indeterminate. Some local variables of type
892 'struct handler' and 'struct catchtag' are used in this way, so
893 mark each of their slots as volatile if the slot can be set before
894 _longjmp and read afterwards.
895 * lisp.h (struct handler): var and chosen_clause are now volatile.
896 (struct catchtag): val, next, and pdlcount are now volatile.
897
ae1d87e2
PE
898 * bidi.c (bidi_push_it, bidi_pop_it):
899 * fns.c (copy_hash_table):
900 * image.c (define_image_type):
901 * keyboard.c (kbd_buffer_store_event_hold):
902 * process.c (Fprocess_send_eof):
903 * xfaces.c (x_create_gc) [HAVE_NS]:
904 * xgselect.c (xg_select):
905 Prefer assignment to memcpy when either will do.
906
5779a1dc
PE
907 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
908 Use pointer-to-a-pointer to simplify and avoid a NILP check each
909 time an item is removed. No need to mark this function 'inline';
910 the compiler knows better than we do.
911
c4c9756b
JD
9122012-09-11 Jan Djärv <jan.h.d@swipnet.se>
913
914 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
915 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
916 to change_frame_size (Bug#12388).
917 (windowDidResize:): Pass YES to updateFrameSize.
918
919 * nsterm.h: Add delay parameter to updateFrameSize.
920
d73e321c
DA
9212012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
922
923 Discard killed buffers from deleted window and frame objects.
924 This reduces an amount of references to killed buffers and
925 helps GC to reclaim them faster.
926 * alloc.c (discard_killed_buffers): New function.
927 (mark_object): Use it for deleted windows and frames.
928 (mark_object): If symbol's value is set up for a killed buffer
929 or deleted frame, restore it's global binding.
930 * data.c (swap_in_global_binding): Add GC notice.
931 (swap_in_symval_forwarding): Use convenient set_blv_where.
932 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
933 * window.h: ... to here.
934
e578f381
DA
9352012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
936
937 Convenient macro to check whether the buffer is live.
938 * buffer.h (BUFFER_LIVE_P): New macro.
939 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
940 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
941
3057e615
YM
9422012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
943
944 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
945 composition cases (Bug#12364).
946
947 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
948 overhang of succeeding glyphs overlapping box cursor.
949
950 * w32term.c (x_draw_glyph_string): Likewise.
951
6fda35f2
PE
9522012-09-11 Paul Eggert <eggert@cs.ucla.edu>
953
c990426a
PE
954 Simplify, document, and port floating-point (Bug#12381).
955 The porting part of this patch fixes bugs on non-IEEE platforms
956 with frexp, ldexp, logb.
957 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
958 Now static.
959 * floatfns.c: Simplify discussion of functions that Emacs doesn't
960 support, by removing commented-out code and briefly listing the
961 C89 functions excluded. The commented-out stuff was confusing
962 maintenance, e.g., we thought we needed cbrt but it was commented out.
963 (logb): Remove decl; no longer needed.
964 (isfinite): New macro, if not already supplied.
965 (isnan): Don't replace any existing macro.
966 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
967 are present on all C89 platforms.
968 (Ffrexp): Do not special-case zero, as frexp does the right thing
969 for that case.
970 (Flogb): Do not use logb, as it doesn't have the desired meaning
971 on hosts that use non-base-2 floating point. Instead, stick with
972 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
973 frexp, to avoid getting an unspecified result.
974
6fda35f2
PE
975 * xdisp.c (Qinhibit_debug_on_message): Now static.
976
16130a58
JD
9772012-09-10 Jan Djärv <jan.h.d@swipnet.se>
978
979 * nsterm.m (ns_update_begin): Set clip path to whole view by using
980 NSBezierPath (Bug#12131).
981
d105a573
CY
9822012-09-10 Chong Yidong <cyd@gnu.org>
983
984 * fns.c (Fdelq, Fdelete): Doc fix.
985
ff55dfe8
PE
9862012-09-10 Paul Eggert <eggert@cs.ucla.edu>
987
988 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
989 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
990
e7032e7c
SM
9912012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
992
993 * lisp.h (make_lisp_ptr): New macro to replace XSET.
994 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
995 Use it.
996
e9957956
EZ
9972012-09-09 Eli Zaretskii <eliz@gnu.org>
998
aba05ce9
EZ
999 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
1000 left fringe if the window has a left margin. This avoids leaving
1001 traces of the cursor because its leftmost pixel is not drawn over.
1002
e9957956
EZ
1003 * dispnew.c (update_window_line): When the left margin area of a
1004 screen line is updated, set the redraw_fringe_bitmaps_p flag of
1005 that screen line. (Bug#12277)
1006
f6196b87
PE
10072012-09-09 Paul Eggert <eggert@cs.ucla.edu>
1008
1009 Assume C89 or later for math functions (Bug#12381).
1010 This simplifies the code, and makes it a bit smaller and faster,
1011 and (most important) makes it easier to clean up signal handling
1012 since we can stop worring about floating-point exceptions in
1013 library code. That was a problem before C89, but the problem
1014 went away many years ago on all practical Emacs targets.
1015 * data.c, image.c, lread.c, print.c:
1016 Don't include <math.h>; no longer needed.
1017 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
1018 might be autoconfigured, as that never happens.
1019 * data.c (fmod):
1020 * doprnt.c (DBL_MAX_10_EXP):
1021 * print.c (DBL_DIG):
1022 Remove. C89 or later always defines these.
1023 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
1024 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
1025 (arith_error, domain_error, domain_error2):
1026 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
1027 no longer needed -- we simply return what C returns. All uses removed.
1028 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
1029 the wrapped code.
1030 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
1031 Remove. All uses expanded, as these macros are no longer used
1032 more than once and are now more trouble than they're worth.
1033 (Ftan): Use tan, not sin / cos.
1034 (Flogb): Assume C89 frexp.
1035 (fmod_float): Assume C89 fmod.
1036 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
1037 (init_floatfns): Remove. All uses removed.
1038
9d7f1863
JD
10392012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1040
1041 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
1042 compositeToPoint for OSX < 10.6 (Bug#12390).
1043
eabf0404
PE
10442012-09-08 Paul Eggert <eggert@cs.ucla.edu>
1045
1046 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
1047 This produces more-accurate results.
1048
0b3b1d23
JD
10492012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1050
1051 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
1052 changes (Bug#12088).
1053
6dcef6ec
CY
10542012-09-08 Chong Yidong <cyd@gnu.org>
1055
1056 * syntax.c (Fstring_to_syntax): Doc fix.
1057
aa7d57c5
JD
10582012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1059
1060 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
1061 in the internal border.
1062 (x_set_window_size): Remove static variables and their usage.
1063 (ns_redraw_scroll_bars): Fix NSTRACE arg.
3a880af4
SM
1064 (ns_after_update_window_line, ns_draw_fringe_bitmap):
1065 Remove fringe/internal border adjustment (Bug#11052).
aa7d57c5
JD
1066 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
1067 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
1068 (ns_fix_rect_ibw): Remove.
1069 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
1070 (ns_dumpglyphs_box_or_relief): Ditto.
1071 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
1072 adjustment.
1073 (ns_dumpglyphs_image): Ditto.
fc0c31f8 1074 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
aa7d57c5
JD
1075 border adjustment.
1076 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
1077 their usage. Add fringe_extended_p and its use as in other terms.
1078 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
1079 scroll bar was removed.
1080 (updateFrameSize): New function.
1081 (windowDidResize): Move code to updateFrameSize and call it.
1082
1083 * nsterm.h (EmacsView): Add updateFrameSize.
1084
1a5432bc
CY
10852012-09-07 Chong Yidong <cyd@gnu.org>
1086
b4f5313e
CY
1087 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
1088
1a5432bc
CY
1089 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
1090
1a4f1e9b
PE
10912012-09-07 Paul Eggert <eggert@cs.ucla.edu>
1092
1093 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
1094 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
1095 Problem introduced when merging patches. Noted by Eli Zaretskii in
1096 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
1097 * floatfns.c: Comment fix.
1098 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
1099 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
1100 and anyway the declaration is harmless even if SIGDANGER is not defined.
1101 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
1102 defined BROKEN_FIONREAD). systty.h formerly did this, but other
1103 source files not surprisingly expected syssignal.h to define, or
1104 not define, SIGIO, and it's cleaner to do it that way, for consistency.
1105 Include <sys/ioctl.h>, for FIONREAD.
1106 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
1107 This eliminates a problem whereby other files mysteriously had
1108 to include "syssignal.h" before including "systty.h" if they
1109 wanted to use "#ifdef SIGIO".
1110
bc8000ff
EZ
11112012-09-07 Eli Zaretskii <eliz@gnu.org>
1112
3e6d6928
EZ
1113 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
1114
1115 * w32.c (sigemptyset): Empty the set.
1116 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
1117
bc8000ff
EZ
1118 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
1119
b4fa72f2
DA
11202012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
1121
1122 * alloc.c (mark_buffer): Revert unsafe marking optimization.
1123 (mark_object): Likewise for frame objects.
1124
30730c93
PE
11252012-09-07 Paul Eggert <eggert@cs.ucla.edu>
1126
1127 * syssignal.h (handle_on_main_thread): Always declare,
1128 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
1129 This ports to platforms without HAVE_PTHREAD.
1130
2fe28299
PE
11312012-09-06 Paul Eggert <eggert@cs.ucla.edu>
1132
1133 Signal-handler cleanup (Bug#12327).
1134 Emacs's signal handlers were written in the old 4.2BSD style with
1135 sigblock and sigmask and so forth, and this led to some
1136 inefficiencies and confusion. Rewrite these to use
1137 pthread_sigmask etc. without copying signal sets around. Also,
1138 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
1139 'signal', and instead use functions that do not attempt to take
1140 over the system name space. This patch causes Emacs's text
1141 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
1142 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
1143 Do not include <signal.h> or "syssignal.h", as these
1144 modules do not use signals.
1145 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
1146 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
1147 Do not include <signal.h>, as "syssignal.h" does that for us now.
1148 * atimer.c (sigmask_atimers): New function.
1149 (block_atimers, unblock_atimers): New functions,
1150 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
1151 All uses replaced.
1152 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
1153 no longer needed here.
1154 * emacs.c (main): Inspect existing signal handler with sigaction,
fc0c31f8 1155 so that there's no need to block and unblock SIGHUP.
2fe28299
PE
1156 * sysdep.c (struct save_signal): New member 'action', replacing
1157 old member 'handler'.
1158 (save_signal_handlers, restore_signal_handlers):
1159 Use sigaction instead of 'signal' to save and restore.
1160 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
1161 New function. All users of 'signal' modified to use set_sighandler
1162 if they're writeonly, and to use sys_signal if they're read+write.
1163 (emacs_sigaction_init, forwarded_signal): New functions.
1164 (sys_signal): Remove. All uses replaced by calls to sigaction
1165 and emacs_sigaction_init, or by direct calls to 'signal'.
1166 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
1167 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
1168 all uses replaced by pthread_sigmask etc. calls.
1169 * syssignal.h: Include <signal.h>.
1170 (emacs_sigaction_init, forwarded_signal): New decls.
1171 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
1172 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
1173 (sigmask, sys_sigmask): Remove; no longer needed.
1174 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
1175 (sigblock, sigunblock, sigfree):
1176 (sigsetmask) [!defined sigsetmask]:
1177 Remove. All uses replaced by pthread_sigmask.
1178 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
1179 no longer need to be replaced, and its typical old uses
1180 are now done via emacs_sigaction_init and sigaction.
1181 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
1182 (sys_sigdel): Remove; unused.
1183 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
1184
0216c128
EZ
11852012-09-06 Eli Zaretskii <eliz@gnu.org>
1186
1187 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
1188 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
1189
c752cfa9
DA
11902012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1191
1192 Explicitly mark buffer_defaults and buffer_local_symbols.
1193 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
1194 mark_local_symbols here.
1195 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
1196 since special buffers aren't marked here any more.
1197 (allocate_buffer): Chain new buffer with all_buffers here...
1198 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
1199 not here.
1200 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
1201 (syms_of_buffer): Remove staticpro of the above.
1202 (init_buffer_once): Set names for buffer_defaults and
1203 buffer_local_symbols.
1204
a864ef14
PE
12052012-09-06 Paul Eggert <eggert@cs.ucla.edu>
1206
1207 Use bool for booleans in font-related modules.
1208 * font.c (font_intern_prop, font_style_to_value)
1209 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
1210 (generate_otf_features, font_check_otf_features, font_check_otf)
1211 (font_match_p, font_list_entities, font_at):
1212 * fontset.c (fontset_id_valid_p, reorder_font_vector
1213 (fontset_find_font, Fset_fontset_font)
1214 (face_suitable_for_char_p) [0]:
1215 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
1216 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
1217 (m17n_flt_initialized, ftfont_shape_by_flt):
1218 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
1219 * nsfont.m (nsfont_draw):
1220 * w32font.c (w32font_draw):
1221 * w32term.c (x_draw_glyphless_glyph_string_foreground):
1222 Use bool for booleans.
1223 * font.h: Adjust to above API changes.
1224 (struct font, struct font_driver, struct font_driver_list):
1225 Use bool for booleans.
1226 (struct font): Remove useless member encoding_type.
1227 All users removed.
1228 * fontset.c, xftfont.c: Omit unnecessary static decls.
1229
0699fc18
DA
12302012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1231
1232 * alloc.c (mark_object): Revert window marking code
1233 since it's unsafe for the Fset_window_configuration.
1234
20ef56db
PE
12352012-09-05 Paul Eggert <eggert@cs.ucla.edu>
1236
2fe28299 1237 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
1238 Be more systematic about preserving errno whenever a signal
1239 handler returns, even if it's not in the main thread. Do this by
1240 renaming signal handlers to distinguish between signal delivery
1241 and signal handling. All uses changed.
1242 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
1243 * data.c (deliver_arith_signal): Rename from arith_error.
1244 * dispnew.c (deliver_window_change_signal): Rename from
1245 window_change_signal.
1246 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
1247 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
1248 * keyboard.c (deliver_input_available_signal): Rename from
1249 input_available_signal.
1250 (deliver_user_signal): Rename from handle_user_signal.
1251 (deliver_interrupt_signal): Rename from interrupt_signal.
1252 * process.c (deliver_pipe_signal): Rename from send_process_trap.
1253 (deliver_child_signal): Rename from sigchld_handler.
1254 * atimer.c (handle_alarm_signal):
1255 * data.c (handle_arith_signal):
1256 * dispnew.c (handle_window_change_signal):
1257 * emacs.c (handle_fatal_signal, handle_danger_signal):
1258 * keyboard.c (handle_input_available_signal):
1259 * keyboard.c (handle_user_signal, handle_interrupt_signal):
1260 * process.c (handle_pipe_signal, handle_child_signal):
1261 New functions, with the actual signal-handling code taken from the
1262 original respective signal handlers, sans the sporadic attempts to
1263 preserve errno, since that's now done by handle_on_main_thread.
1264 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
1265 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
1266 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1267 Move to sysdep.c.
1268 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1269 Move initialization of main_thread to sysdep.c's init_signals.
1270 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
1271 our usage, and simplifies the mainline code.
1272 (record_child_status_change): New static function, as a helper
1273 for handle_child_signal, and with most of the old child handler's
1274 contents.
1275 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
1276 (handle_child_signal): Use the above.
1277 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1278 Moved here from emacs.c.
1279 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
1280 code moved here from emacs.c's main function.
1281 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
3a880af4
SM
1282 replacing the old SIGNAL_THREAD_CHECK. All uses changed.
1283 This lets callers save and restore errno properly.
20ef56db 1284
e3ccf108
DA
12852012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1286
1287 Remove redundant or unused things here and there.
1288 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
1289 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
1290 * editfns.c (Fcompare_buffer_substrings): Likewise.
1291 * frame.h (struct terminal, struct font_driver_list):
1292 Remove redundant declarations.
1293 * window.h (Qleft, Qright): Likewise.
1294
697e1e39
DA
12952012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1296
1297 Do not mark objects from deleted buffers, windows and frames.
1298 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
1299 (mark_object): Likewise for windows and frames.
1300
c1ca42ca
DA
13012012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1302
1303 * alloc.c (valid_lisp_object_p): Treat killed buffers,
1304 buffer_defaults and buffer_local_symbols as valid objects.
1305 Return special value to denote them.
1306
014d93be
PE
13072012-09-05 Paul Eggert <eggert@cs.ucla.edu>
1308
f75d7a91
PE
1309 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
1310 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
1311 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
1312 (file_name_absolute_p, Fsubstitute_in_file_name):
1313 (check_executable, check_writable, Ffile_accessible_directory_p)
1314 (Fset_file_selinux_context, Fdefault_file_modes)
1315 (Finsert_file_contents, choose_write_coding_system)
1316 (Fwrite_region, build_annotations, a_write, e_write)
1317 (Fdo_auto_save):
1318 * filelock.c (boot_time_initialized, get_boot_time)
1319 (get_boot_time_1, lock_file_1, within_one_second):
1320 * floatfns.c (in_float):
1321 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
1322 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
1323 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
1324 * lisp.h (struct Lisp_Hash_Table.cmpfn):
1325 * window.c (compare_window_configurations):
1326 Use bool for booleans.
1327 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
1328 (Fdefault_file_modes): Now mode_t, not int, for modes.
1329 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
1330 (internal_delete_file): Now returns void, not a (boolean) int,
1331 since nobody was looking at the return value.
1332 * lisp.h, window.h: Adjust to above API changes.
1333
014d93be
PE
1334 * xdisp.c (set_message): Simplify and reindent last change.
1335
776f29e1
JB
13362012-09-05 Juanma Barranquero <lekktu@gmail.com>
1337
1338 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
1339
7f7e0167
LI
13402012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
1341
1342 * eval.c (call_debugger): Make the function non-static so that we
1343 can call it from set_message.
1344
1345 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
1346 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
1347
cf29dd84
PE
13482012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1349
1350 Give more-useful info on a fatal error (Bug#12328).
1351 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
1352 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
1353 of doing the work ourselves.
1354 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
1355 do most of the work.
1356 (fatal_error_backtrace): New function, taken from the guts
1357 of the old fatal_error_signal, but with a new option to output
1358 a backtrace.
1359 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
1360 info about the signal than just its number.
1361 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
1362 * sysdep.c: Include <execinfo.h>
1363 (emacs_backtrace): New function, taken partly from the previous
1364 code of the 'die' function.
1365 (emacs_abort): Call fatal_error_backtrace rather than abort.
1366
972debf2
SM
13672012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
1368
1369 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
1370 eager (load-time) macro-expansion.
1371 * lisp.mk (lisp): Add macroexp.
1372
1088b922
PE
13732012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1374
1375 Simplify redefinition of 'abort' (Bug#12316).
1376 Do not try to redefine the 'abort' function. Instead, redo
1377 the code so that it calls 'emacs_abort' rather than 'abort'.
1378 This removes the need for the NO_ABORT configure-time macro
1379 and makes it easier to change the abort code to do a backtrace.
1380 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
1381 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
1382 Remove; sysdep.c's emacs_abort now takes its place.
1383 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
1384 'abort' changed to use 'emacs_abort'.
1385 * msdos.c (dos_abort) [defined abort]: Remove; not used.
1386 (abort) [!defined abort]: Rename to ...
1387 (emacs_abort): ... new name.
1388 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
1389 the place of the old 'abort' in emacs.c.
1390 * w32.c, w32fns.c (abort): Do not #undef.
1391 * w32.c (emacs_abort): Rename from w32_abort.
1392
30934d33
EZ
13932012-09-04 Eli Zaretskii <eliz@gnu.org>
1394
1395 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
1396 offsets[j].dv, since the y axis of the screen coordinates points
1397 down, while the y axis of the font definition coordinates points
1398 up. This fixes display of Arabic diacritics such as KASRA and
1399 KASRATAN. (Bug#11860)
1400
af26b72c
PE
14012012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1402
1403 Be more systematic about _setjmp vs setjmp.
1404 * alloc.c (test_setjmp, mark_stack):
1405 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
1406 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
1407 (png_load, my_error_exit, jpeg_load):
1408 * process.c (send_process_trap, send_process):
1409 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
1410 The underscored versions are up to 30x faster on some hosts.
1411 Formerly, the code used setjmp+longjmp sometimes and
1412 _setjmp+_longjmp at other times, with no particular reason to
1413 prefer setjmp+longjmp.
1414
26d4541d
PE
14152012-09-03 Paul Eggert <eggert@cs.ucla.edu>
1416
d42f4f0f 1417 Fix minor problem found by static checking.
26d4541d 1418 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 1419
c5e28e39
MR
14202012-09-03 Martin Rudalics <rudalics@gmx.at>
1421
1422 * buffer.c (Fdelete_all_overlays): New function.
1423
3eab3ca9
CY
14242012-09-03 Chong Yidong <cyd@gnu.org>
1425
1426 * gtkutil.c: Add extern decl for Qxft.
1427
c04889f8
PE
14282012-09-02 Paul Eggert <eggert@cs.ucla.edu>
1429
1882aa38
PE
1430 * emacs.c, eval.c: Use bool for boolean.
1431 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
1432 (malloc_using_checking) [DOUG_LEA_MALLOC]:
1433 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
1434 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
1435 (main, decode_env_path, Fdaemon_initialized):
1436 * eval.c (call_debugger, Finteractive_p, interactive_p):
1437 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
1438 (maybe_call_debugger, Fbacktrace):
1439 * process.c (read_process_output, exec_sentinel):
1440 Use bool for booleans.
1441 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
1442 All callers changed.
1443 * eval.c (interactive_p): Omit always-true boolean argument
1444 EXCLUDE_SUBRS_P. All callers changed.
1445 * dispextern.h, lisp.h: Reflect above API changes.
1446 * firstfile.c (dummy): Use the address of 'main', whose signature
1447 won't change, instead of the address of 'initialize', whose
1448 signature just changed from int to bool.
1449 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
1450 * msdos.c (fatal_error_in_progress): ... from here.
1451 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
1452 of incrementing it.
1453 (redisplay_internal, unwind_redisplay): Simply clear
1454 REDISPLAYING_P when unwinding, instead of saving its previous,
1455 always-false value and then restoring it.
1456
a411ac43
PE
1457 Clean up some extern decls.
1458 Mostly, this hoists extern decls out of .c files and into .h files.
1459 That way, we're more likely to catch errors if the interfaces change.
1460 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
1461 declare xg_mark_data.
1462 * dispextern.h (x_frame_parm_handlers):
1463 * font.h (Qxft):
1464 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
1465 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
1466 (Qultra_bold, Qoblique, Qitalic):
1467 Move extern decl here from .c file.
1468 * alloc.c (xg_mark_data) [USE_GTK]:
1469 * doc.c (Qclosure):
1470 * eval.c (Qlexical_binding):
1471 * fns.c (time) [!HAVE_UNISTD_H]:
1472 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
1473 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
1474 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
1475 * lread.c (Qinternal_interpreter_environment):
1476 * minibuf.c (Qbuffer):
1477 * process.c (QCfamily, QCfilter):
1478 * widget.c (free_frame_faces):
1479 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
1480 * xfont.c (x_clear_errors):
1481 * xterm.c (x_frame_parm_handlers):
1482 Remove now-redundant extern decls.
1483 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
1484 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
1485 Now static.
1486 * xfaces.c: Remove unnecessary static decls.
1487 * xterm.c (updating_frame): Remove decl of nonexistent object.
1488
c04889f8
PE
1489 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
1490 when building globals.h, as the objects that are not built on
1491 this host are not needed to compile C files on this host.
1492
8b339673
JD
14932012-09-02 Jan Djärv <jan.h.d@swipnet.se>
1494
1495 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
1496
1497 * frame.h: Add missing prototype for x_wm_set_size_hint.
1498
a08d4ba7
PE
14992012-09-02 Paul Eggert <eggert@cs.ucla.edu>
1500
1501 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
1502 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
1503 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
1504 (Fsubstitute_command_keys):
1505 * editfns.c (region_limit, find_field, Fconstrain_to_field)
1506 (save_excursion_save, save_excursion_restore)
1507 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
1508 (format_time_string, general_insert_function)
1509 (make_buffer_string, make_buffer_string_both)
1510 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
1511 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
1512 (copy_text, insert_1, insert_1_both, insert_from_string)
1513 (insert_from_string_before_markers, insert_from_string_1)
1514 (insert_from_buffer, insert_from_buffer_1, replace_range)
1515 (replace_range_2, del_range_1, del_range_byte, del_range_both)
1516 (del_range_2, modify_region):
1517 * intervals.c (intervals_equal, balance_possible_root_interval)
1518 (adjust_intervals_for_insertion, merge_properties_sticky)
1519 (graft_intervals_into_buffer, lookup_char_property)
1520 (adjust_for_invis_intang, set_point_both)
1521 (get_property_and_range, compare_string_intervals)
1522 (set_intervals_multibyte_1, set_intervals_multibyte):
1523 * keyboard.c (decode_timer):
1524 Use bool for boolean.
1525 * intervals.h, lisp.h, systime.h: Reflect above API changes.
1526 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
1527
48c948de
CY
15282012-09-02 Chong Yidong <cyd@gnu.org>
1529
1530 * keymap.c (push_key_description): Print M-TAB as C-M-i
1531 (Bug#11758).
1532
6c49a40b
JB
15332012-09-02 Juanma Barranquero <lekktu@gmail.com>
1534
1535 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
1536 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
1537 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
1538 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
1539 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
1540 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
1541 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
1542
4dfbd238
EZ
15432012-09-01 Eli Zaretskii <eliz@gnu.org>
1544
7e510e28
EZ
1545 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
1546 more than one grapheme cluster passed to the shaper: compute the
1547 offset adjustment values separately for each cluster. (Bug#11860)
1548
4dfbd238
EZ
1549 * image.c: Restore mistakenly removed inclusion of w32.h. Without
1550 it, GCC doesn't see prototypes of w32_delayed_load, and complains
1551 about implicit conversions from integer to pointer.
1552
86571ae0
DC
15532012-09-01 Daniel Colascione <dancol@dancol.org>
1554
1555 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
1556 system used too early.
1557
0e23ef9d
PE
15582012-09-01 Paul Eggert <eggert@cs.ucla.edu>
1559
1560 Better seed support for (random).
1561 * emacs.c (main): Call init_random.
1562 * fns.c (Frandom): Set the seed from a string argument, if given.
1563 Remove long-obsolete Gentzel cruft.
1564 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
1565 (init_random): New function.
1566
17a2cbbd
DC
15672012-09-01 Daniel Colascione <dancol@dancol.org>
1568
1569 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
1570 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
1571 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
1572 x_wm_set_size_hint, x_query_colors, x_real_positions,
1573 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
1574 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
1575 all of which have been moved to common code.
1576
1577 * xfaces.c: Include TERM_HEADER instead of listing all possible
1578 window-system headers.
1579
1580 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
1581 to match header.
1582
1583 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
1584 directly accessing frame internals.
1585
f18cbb28 1586 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
1587 globals_of_w32font.
1588
1589 * process.c: Include TERM_HEADER instead of listing all possible
1590 window-system headers.
1591
3a880af4
SM
1592 * nsterm.h: Remove declarations now in frame.h.
1593 Define FRAME_X_SCREEN, FRAME_X_VISUAL.
17a2cbbd
DC
1594
1595 * menu.c: Include TERM_HEADER instead of listing all possible
1596 window-system headers.
1597
1598 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
1599 window system.
1600
1601 * keyboard.c: Include TERM_HEADER instead of listing all possible
1602 window-system headers.
1603
1604 * image.c: Include TERM_HEADER instead of listing all possible
1605 window-system headers. Declare Vlibrary_cache when compiling for
1606 Windows.
1607
1608 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
1609 window system declarations.
1610
1611 * frame.h: Move common functions here: set_frame_menubar,
1612 x_set_window_size, x_sync, x_get_focus_frame,
1613 x_set_mouse_position, x_set_mouse_pixel_position,
1614 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
1615 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
1616 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
1617 x_activate_menubar, x_real_positions, x_bitmap_icon,
1618 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
1619 and x_query_colors.
1620
1621 * frame.c: Include TERM_HEADER instead of listing all possible
1622 window-system headers.
1623
1624 * font.c: Include TERM_HEADER instead of listing all possible
1625 window-system headers.
1626
1627 * emacs.c: Include TERM_HEADER.
1628
f18cbb28
EZ
1629 * dispnew.c: Include TERM_HEADER instead of listing all possible
1630 window-system headers.
17a2cbbd 1631
f18cbb28 1632 * ccl.h: Include character.h.
17a2cbbd
DC
1633
1634 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
1635 the current window system; include in list of objects to link into
1636 Emacs.
1637
c650a5de
DA
16382012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
1639
1640 Remove mark_ttys function and fix tty_display_info initialization.
1641 * lisp.h (mark_ttys): Remove prototype.
1642 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
1643 to mark_ttys because all possible values of 'top_frame' slot are
1644 the frames which are reachable from Vframe_list.
1645 * term.c (mark_ttys): Remove.
1646 (init_tty): Safely initialize 'top_frame' slot with Qnil.
1647
4e0f6479
DA
16482012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
1649
1650 Change struct frame bitfields from unsigned char to unsigned.
1651 * frame.h (struct frame): Change type of 'display_preempted',
1652 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
1653 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
1654 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
1655 bitfields from unsigned char to unsigned.
1656
8b96a52c
DA
16572012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
1658
1659 Remove unused member of struct x_output and struct w32_output.
1660 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
1661 * w32term.h (struct w32_output): Likewise.
1662
b4444c8a
JD
16632012-08-30 Jan Djärv <jan.h.d@swipnet.se>
1664
1665 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
1666 does not become zero (Bug#12234).
1667
b98521db
PE
16682012-08-30 Paul Eggert <eggert@cs.ucla.edu>
1669
1670 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
1671 for GCC 4.7.1 x86-64.
1672
31d02438
GM
16732012-08-30 Glenn Morris <rgm@gnu.org>
1674
1675 * lread.c (init_lread): For out-of-tree builds, only add the
1676 source directory's site-lisp dir to the load-path if it exists,
1677 consistent with in-tree builds. (Bug#12302)
1678
7f8941d8
JD
16792012-08-28 Jan Djärv <jan.h.d@swipnet.se>
1680
1681 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
fc0c31f8 1682 button_values to NULL. Call setStykeMask so dialogs get a close button.
7f8941d8
JD
1683 (windowShouldClose:): Set window_closed.
1684 (dealloc): New member, free button_values.
fc0c31f8
JB
1685 (process_dialog:): Make member function. Remove window argument,
1686 replace window with self. Count buttons and allocate and store values
7f8941d8
JD
1687 in button_values.
1688 (addButton:value:row:): value is int with the name tag. Call setTag
fc0c31f8 1689 with tag. Remove return self, declare return value as void.
7f8941d8
JD
1690 (addString:row:): Remove return self, declare return value as void.
1691 (addSplit): Remove return self, declare return value as void.
1692 (clicked:): Remove return self, declare return value as void.
fc0c31f8 1693 Set dialog_return to button_values[seltag]. Code formatting change.
7f8941d8
JD
1694 (initFromContents:isQuestion:): Adjust call to process_dialog.
1695 Code formatting change.
1696 (timeout_handler:): Set timer_fired to YES.
1697 (runDialogAt:): Set timer_fired to NO.
1698 Handle click on close button as quit.
1699
1700 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
1701 Add window_closed and button_values. Add void as return value for
1702 add(Button|String|Split). addButton takes int instead of Lisp_Object.
1703 Add process_dialog as new member.
1704
eada0861 17052012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 1706
eada0861
GM
1707 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
1708 is not one of the heaps we manage. (Bug#12242)
1709
17102012-08-28 Glenn Morris <rgm@gnu.org>
1711
1712 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
1713
457294dd
MR
17142012-08-28 Martin Rudalics <rudalics@gmx.at>
1715
1716 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
1717 auto-buffer-name window parameter. Install revision of reverted
1718 fix.
457294dd 1719
4f2daf31
DA
17202012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1721
1722 Do not allow to set major mode for a dead buffer.
1723 * buffer.c (Fset_buffer_major_mode): Signal an error
1724 if the buffer is dead.
1725 (Fother_buffer, other_buffer_safely): Remove redundant
1726 nested declaration.
1727
66322887
DA
17282012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1729
1730 Always use set_buffer_if_live to restore original buffer at unwind.
1731 * buffer.h (record_unwind_current_buffer): New function.
1732 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
1733 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
1734 * undo.c, window.c: Adjust users.
1735 * buffer.c (set_buffer_if_live): Fix comment.
1736
a3d794a1
DA
17372012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1738
1739 Fix usage of set_buffer_internal.
1740 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
1741 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
1742 * coding.c (decode_coding): Omit redundant test.
1743 * fileio.c (decide_coding_unwind): Likewise.
1744 * fns.c (secure_hash): Likewise.
1745 * insdel.c (modify_region): Likewise.
1746 * keyboard.c (command_loop_1): Likewise.
1747 * print.c (PRINTFINISH): Likewise.
1748 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
1749
59ea14cd
PE
17502012-08-27 Paul Eggert <eggert@cs.ucla.edu>
1751
1752 * dispnew.c: Use bool for boolean.
1753 (frame_garbaged, display_completed, delayed_size_change)
1754 (fonts_changed_p, add_window_display_history)
1755 (add_frame_display_history, verify_row_hash)
1756 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
1757 (row_equal_p, realloc_glyph_pool)
1758 (allocate_matrices_for_frame_redisplay)
1759 (showing_window_margins_p)
1760 (adjust_frame_glyphs_for_frame_redisplay)
1761 (build_frame_matrix_from_leaf_window, make_current)
1762 (mirrored_line_dance, mirror_line_dance, update_frame)
1763 (update_window_tree, update_single_window)
1764 (check_current_matrix_flags, update_window, update_text_area)
1765 (update_window_line, set_window_update_flags, scrolling_window)
1766 (update_frame_1, scrolling, buffer_posn_from_coords)
1767 (do_pending_window_change, change_frame_size)
1768 (change_frame_size_1, sit_for):
1769 Use bool for boolean.
1770 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
1771 and remove last int (actually boolean) argument, which was always 0.
1772 All callers changed.
1773 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
1774 * dispextern.h (struct composition_it): Use bool for boolean.
1775 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
1776 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
1777 * dired.c (file_name_completion):
1778 Use bool for boolean. (This was missed in an earlier change.)
1779
95072a94
MR
17802012-08-27 Martin Rudalics <rudalics@gmx.at>
1781
1782 * window.c (Fset_window_configuration): Revert first part of
1783 last change.
1784
0f19feff
JD
17852012-08-27 Jan Djärv <jan.h.d@swipnet.se>
1786
1787 * nsterm.h (NSPanel): New class variable dialog_return.
1788
3a880af4
SM
1789 * nsmenu.m (initWithContentRect:styleMask:backing:defer:):
1790 Initialize dialog_return.
0f19feff
JD
1791 (windowShouldClose:): Use stop instead of stopModalWithCode.
1792 (clicked:): Ditto, and also set dialog_return (Bug#12258).
1793 (timeout_handler:): Use stop instead of abortModal. Send a dummy
1794 event.
1795 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
1796 modal loop returns.
1797
f10fe38f
PE
17982012-08-27 Paul Eggert <eggert@cs.ucla.edu>
1799
de1339b0
PE
1800 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
1801 * composite.c (find_composition, composition_gstring_p)
1802 (composition_reseat_it, find_automatic_composition):
1803 * data.c (let_shadows_buffer_binding_p)
1804 (let_shadows_global_binding_p, set_internal, make_blv)
1805 (Fmake_variable_buffer_local, Fmake_local_variable)
1806 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
1807 (cons_to_signed, arith_driver):
1808 * dbusbind.c (xd_in_read_queued_messages):
1809 * dired.c (directory_files_internal, file_name_completion):
1810 Use bool for booleans.
1811 * dired.c (file_name_completion):
1812 * process.h (fd_callback):
1813 Omit int (actually boolean) argument. It wasn't being used.
1814 All uses changed.
1815 * composite.h, lisp.h: Reflect above API changes.
1816
f10fe38f
PE
1817 * cmds.c, coding.c: Use bool for booleans.
1818 * cmds.c (move_point, Fself_insert_command):
1819 * coding.h (struct composition status, struct coding_system):
1820 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
1821 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
1822 (emacs_mule_char, decode_coding_emacs_mule)
1823 (encode_coding_emacs_mule, detect_coding_iso_2022)
1824 (decode_coding_iso_2022, encode_invocation_designation)
1825 (encode_designation_at_bol, encode_coding_iso_2022)
1826 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
1827 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
1828 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
1829 (encode_coding_raw_text, detect_coding_charset)
1830 (decode_coding_charset, encode_coding_charset, detect_eol)
1831 (detect_coding, get_translation_table, produce_chars)
1832 (consume_chars, reused_workbuf_in_use)
1833 (make_conversion_work_buffer, code_conversion_save)
1834 (decode_coding_object, encode_coding_object)
1835 (detect_coding_system, char_encodable_p)
1836 (Funencodable_char_position, code_convert_region)
1837 (code_convert_string, code_convert_string_norecord)
1838 (Fset_coding_system_priority):
1839 * fileio.c (Finsert_file_contents):
1840 Use bool for booleans.
1841 * coding.h, lisp.h: Reflect above API changes.
1842 * coding.c: Remove unnecessary static function decls.
1843 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
1844 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
1845 not a boolean 'int', since callers never look at the return value.
1846 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
1847 * coding.h (decoding_buffer_size, encoding_buffer_size)
1848 (emacs_mule_string_char): Remove unused extern decls.
1849 (struct iso_2022_spec, struct coding_system):
1850 Use 'unsigned int : 1' for boolean fields, since there's more than one.
1851 (struct emacs_mule_spec): Remove unused field 'full_support'.
1852 All initializations removed.
1853 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
1854
5474c384
DA
18552012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1856
f10fe38f 1857 Fix spare memory change (Bug#12286).
5474c384
DA
1858 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
1859 (valid_lisp_object_p): Likewise.
1860
c4b6914d
MR
18612012-08-27 Martin Rudalics <rudalics@gmx.at>
1862
1863 * window.c (Fset_window_configuration): Record any window's old
1864 buffer if it's replaced (see Bug#8789). If the new current
1865 buffer doesn't appear in the selected window, go to its old
1866 point (Bug#12208).
1867
35aaa1ea
DA
18682012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1869
1870 Special MEM_TYPE_SPARE to denote reserved memory.
1871 * alloc.c (enum mem_type): New memory type.
1872 (refill_memory_reserve): Use new type for spare memory.
1873 This prevents live_cons_p and live_string_p from incorrect
1874 detection of uninitialized objects from spare memory as live.
1875
6af64513
PE
18762012-08-26 Paul Eggert <eggert@cs.ucla.edu>
1877
8b2e00a3
PE
1878 Spelling fixes.
1879 * Makefile.in (.PHONY): versioclean -> versionclean.
1880
b52d6985
PE
1881 Remove unused external symbols.
1882 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
1883 * window.c (Qwindow_valid_p, decode_valid_window):
1884 Now static, not extern.
1885 * data.c (Qinterval): Remove; unused.
1886 (syms_of_data): Do not define 'interval'.
1887 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
1888 * window.h (decode_valid_window):
1889 Remove decls.
1890
d5172d4f
PE
1891 * character.c, charset.c, chartab.c: Use bool for booleans.
1892 * character.c (lisp_string_width, string_count_byte8)
1893 (string_escape_byte8):
1894 * charset.c (charset_map_loaded, load_charset_map, read_hex):
1895 (load_charset_map_from_file, map_charset_chars)
1896 (Fdefine_charset_internal, define_charset_internal)
1897 (Fdeclare_equiv_charset, find_charsets_in_text)
1898 (Ffind_charset_region, char_charset, Fiso_charset):
1899 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
1900 (sub_char_table_set, sub_char_table_set_range)
1901 (char_table_set_range, optimize_sub_char_table)
1902 (map_sub_char_table):
1903 Use bool for boolean.
1904 * character.c (str_to_unibyte): Omit last boolean argument; it was
1905 always 0. All callers changed.
1906 * character.h, charset.h: Adjust to match previous changes.
1907 * character.h (char_printable_p): Remove decl of nonexistent function.
1908 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
1909 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
1910 are all boolean, so make them single-bit bitfields.
1911
6af64513
PE
1912 * lisp.h (ASET): Remove attempt to detect side effects.
1913 It was meant to be temporary and it often doesn't work,
1914 because when IDX has side effects the behavior of IDX==IDX
1915 is undefined. See Stefan Monnier in
1916 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
1917
e1f29348
BR
19182012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1919
1920 * lisp.h (functionp): New function (extracted from Ffunctionp).
1921 (FUNCTIONP): Use it.
1922 * eval.c (Ffunctionp): Use it.
1923
17c05d74
PE
19242012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1925
0f46bc75
PE
1926 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
1927 as that's faster and simpler than static storage. Don't bother
1928 with the g_main_context_query overhead if g_main_context_pending
1929 says no events are pending.
1930 (gfds, gfds_size): Remove these static vars.
1931 (xgselect_initialize): Remove; no longer needed.
1932 All uses and decls removed.
1933
ee4c0f69
PE
1934 * emacs.c (fatal_error_signal_hook): Remove.
1935 All uses removed. This leftover from old code was always 0.
1936
17c05d74
PE
1937 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
1938 * casefiddle.c (casify_object, casify_region):
1939 * casetab.c (set_case_table):
1940 * category.c, category.h (word_boundary_p):
1941 * category.h (CHAR_HAS_CATEGORY):
1942 Use bool for booleans, instead of int.
1943
391ceac5
EZ
19442012-08-25 Eli Zaretskii <eliz@gnu.org>
1945
1946 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
1947
2f221583
PE
19482012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1949
f4a681b0
PE
1950 On assertion failure, print backtrace if available.
1951 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
1952 (die) [ENABLE_CHECKING]: Print a backtrace if available.
1953 * Makefile.in (LIB_EXECINFO): New macro.
1954 (LIBES): Use it.
1955
2f221583
PE
1956 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
1957 * bytecode.c (exec_byte_code):
1958 * callint.c (check_mark, Fcall_interactively):
1959 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
1960 (getenv_internal, sync_process_alive, call_process_exited):
1961 * lisp.h (USE_SAFE_ALLOCA):
1962 Use bool for booleans, instead of int.
1963 * lisp.h, process.h: Adjust prototypes to match above changes.
1964 * callint.c (Fcall_interactively): Don't assume the mark's
1965 offset fits in 'int'.
1966
37ef52bb
PE
19672012-08-24 Paul Eggert <eggert@cs.ucla.edu>
1968
1969 * buffer.c, buffer.h: Use bool for boolean.
1970 * buffer.c (reset_buffer_local_variables)
1971 (buffer_lisp_local_variables, Fset_buffer_modified_p)
1972 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
1973 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
1974 (overlay_touches_p, overlay_strings, Foverlay_put)
1975 (report_overlay_modification, call_overlay_mod_hooks):
1976 (mmap_enlarge, mmap_set_vars):
1977 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
1978 Use bool for booleans, instead of int.
1979 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
1980 since the 1-or-0 return value is always ignored anyway.
1981 (mmap_initialized_p):
1982 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
1983 * buffer.h, lisp.h: Adjust prototypes to match above changes.
1984
2cc21167
PE
19852012-08-23 Paul Eggert <eggert@cs.ucla.edu>
1986
1987 * bidi.c: Use bool for boolean.
1988 This is a bit more readable, and makes the text segment of bidi.o
1989 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
1990 Presumably it's faster too.
1991 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
1992 Now bool.
1993 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1994 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
1995 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
1996 (bidi_explicit_dir_char, bidi_level_of_next_char)
1997 (bidi_find_other_level_edge, bidi_move_to_visually_next):
1998 Use bool for booleans, instead of int.
1999 * dispextern.h (bidi_init_it, bidi_paragraph_init)
2000 (bidi_unshelve_cache): Adjust decls to match code.
2001
7db4ddf4
MR
20022012-08-23 Martin Rudalics <rudalics@gmx.at>
2003
2004 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
2005 argument.
2006
b1bb8011
PE
20072012-08-23 Paul Eggert <eggert@cs.ucla.edu>
2008
2009 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
2010 * atimer.h: Include <stdbool.h>.
2011
ff687885
DN
20122012-08-22 Dan Nicolaescu <dann@gnu.org>
2013
2014 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
2015 compile time tests instead of run time tests on systems that do
2016 not use them.
2017 (FRAME_MAC_P): Remove leftover from deleted code.
2018 * frame.c (syms_of_frame): Remove leftover from deleted code.
2019
4ce7a138
JD
20202012-08-22 Jan Djärv <jan.h.d@swipnet.se>
2021
2022 * nsterm.m (insertText:): Don't clear modifiers if code is space.
2023
d733ec6d
PE
20242012-08-22 Paul Eggert <eggert@cs.ucla.edu>
2025
2026 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
2027 Otherwise, the compiler complains about (A?B:C) where B is void
fc0c31f8 2028 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
d733ec6d
PE
2029 (fontset_add): Return void, for FONTSET_ADD.
2030
d0d2d26f
PE
20312012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2032
fce31d69
PE
2033 * alloc.c: Use bool for booleans.
2034 (gc_in_progress, abort_on_gc)
2035 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2036 (dont_register_blocks) [GC_MALLOC_CHECK]:
2037 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
2038 (check_string_bytes, make_specified_string, memory_full)
2039 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
2040 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
2041 (mark_stack, valid_pointer_p, make_pure_string)
2042 (Fgarbage_collect, survives_gc_p, gc_sweep):
2043 Use bool for booleans, instead of int.
2044 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2045 Remove unused local.
2046 * alloc.c (PURE_POINTER_P):
2047 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
2048 * editfns.c (Fformat):
2049 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
2050 (Fdo_auto_save):
2051 * fns.c (sweep_weak_table):
2052 * lisp.h (suppress_checking, push_message, survives_gc_p)
2053 (make_pure_string, gc_in_progress, abort_on_gc):
2054 * lread.c (readchar, read1):
2055 * print.c (Fprin1_to_string):
2056 * xdisp.c (push_message):
2057 Use bool for booleans affected directly or indirectly by
2058 alloc.c's changes.
2059
d0d2d26f
PE
2060 Make recently-introduced setters macros.
2061 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
2062 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
2063 (set_fontset_default, set_fontset_fallback): Rename from their
2064 upper-case counterparts, and make them functions rather than macros.
2065 This is more consistent with the other recently-introduced setters.
2066 These don't need to be inline, since they're local.
2067
d18e2bb6
JD
20682012-08-21 Jan Djärv <jan.h.d@swipnet.se>
2069
2070 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
2071 the loop (Bug#12247).
2072
1b9d9d16
PE
20732012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2074
2075 * lisp.h (vcopy): Use memcpy rather than our own loop.
2076 This fixes a performance regression introduced by the recent
2077 addition of vcopy. This means 'vcopy' will need to be modified
2078 for a copying collector, but that's OK. Also, tighten the
2079 checking in the assertion.
2080
b2f09701
EZ
20812012-08-21 Eli Zaretskii <eliz@gnu.org>
2082
2083 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
2084 components for RTL text (Bug#11860). Adjust X-OFFSET of each
2085 non-base glyph for the width of the base character, according to
e1f29348
BR
2086 what x_draw_composite_glyph_string_foreground expects.
2087 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
2088 expectations, to produce correct width of the composed character.
2089 Reverse the sign of the DU offset produced by ScriptPlace.
2090
9b994fed
PE
20912012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2092
2093 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
2094
086ca913
DA
20952012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
2096
2097 Avoid direct writes to contents member of struct Lisp_Vector.
2098 * lisp.h (vcopy): New function to copy data into vector.
2099 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
2100 * fns.c (Ffillarray): Use ASET.
2101 * keyboard.c (timer_check_2): Use AREF and ASET.
2102 (append_tool_bar_item, Frecent_keys): Use vcopy.
2103 * lread.c (read_vector): Use ASET.
2104 * msdos.c (Frecent_doskeys): Use vcopy.
2105 * xface.c (Finternal_copy_lisp_face): Use vcopy.
2106 (Finternal_merge_in_global_face): Use ASET and vcopy.
2107 * xfont.c (xfont_list_pattern): Likewise.
2108
5481664a
MR
21092012-08-21 Martin Rudalics <rudalics@gmx.at>
2110
2111 * window.c (Fwindow_point): For the selected window always return
2112 the position of its buffer's point.
2113 (Fset_window_point): For the selected window always go in its
2114 buffer to the specified position.
2115
6d470bdd
DA
21162012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
2117
2118 Setter macros for fontsets.
2119 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
2120 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
2121 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
2122 Adjust users.
2123
24564fe1
GM
21242012-08-20 Glenn Morris <rgm@gnu.org>
2125
2126 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2127 Don't assume that `ln -f' works.
2128
0a05a035
EZ
21292012-08-20 Eli Zaretskii <eliz@gnu.org>
2130
2131 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
2132 and later about non-assignments with no effect. See discussion at
2133 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
2134 details.
2135
e46f2325
DA
21362012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2137
2138 Inline setter functions for Lisp_Objects slots of struct specbinding.
2139 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
2140 Adjust users.
2141
734fbd86
MR
21422012-08-20 Martin Rudalics <rudalics@gmx.at>
2143
2144 * window.c (select_window): Always make selected window's buffer
2145 current.
2146
f1a95992
DA
21472012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2148
2149 Use AREF and ASET for docstrings of category tables.
2150 * category.h (CATEGORY_DOCSTRING): Use AREF.
2151 (SET_CATEGORY_DOCSTRING): Use ASET.
2152 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
2153
e83064be
DA
21542012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2155
2156 Inline setter functions for hash table members.
2157 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
2158 (set_hash_hash, set_hash_index): Rename with _slot suffix.
2159 (set_hash_key_and_value, set_hash_index, set_hash_next)
2160 (set_hash_hash): New functions.
2161 * charset.c, fns.c: Adjust users.
2162
4ce60d2e
DA
21632012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2164
2165 Inline getter and setter functions for per-buffer values.
2166 * buffer.h (per_buffer_default, set_per_buffer_default)
2167 (per_buffer_value, set_per_buffer_value): New functions.
2168 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
2169 * buffer.c, data.c: Adjust users.
2170
c06c9690
JB
21712012-08-20 Juanma Barranquero <lekktu@gmail.com>
2172
2173 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
2174
32bd4250
PE
21752012-08-19 Paul Eggert <eggert@cs.ucla.edu>
2176
bad03192 2177 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
2178 as gnulib does this if the system doesn't.
2179 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
2180 Remove declaration. MS-Windows declares it on stdlib.h which is
2181 included by conf_post.h.
b69a6d22
PE
2182 * emacs.c (environ) [DOUG_LEA_MALLOC]:
2183 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
2184 * vm-limit.c: Include <unistd.h>, for 'environ'.
2185
22d7feb2
PE
2186 * unexaix.c, unexcoff.c: Include "mem-limits.h".
2187 (start_of_data): Remove decl; mem-limits.h provides it.
2188
32bd4250
PE
2189 * xdisp.c (handle_invisible_prop): Make it a bit faster
2190 and avoid a gcc -Wmaybe-uninitialized diagnostic.
2191
450809af
CY
21922012-08-19 Chong Yidong <cyd@gnu.org>
2193
2194 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
2195 ends (Bug#3874).
2196
9e677988
AS
21972012-08-19 Andreas Schwab <schwab@linux-m68k.org>
2198
6b1319ce
AS
2199 * .gdbinit: Use call instead of set when calling a function in the
2200 inferior.
2201
9e677988
AS
2202 * data.c (set_internal): Don't use set_blv_found.
2203 (Fkill_local_variable): Likewise.
2204
d7191076
AA
22052012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
2206
2207 * nsfont.m (ns_ascii_average_width): Ensure the string
2208 ascii_printable is initialized with a null-terminated character
2209 array. Otherwise, it can contain undesired extra characters.
2210
e757f1c6
PE
22112012-08-18 Paul Eggert <eggert@cs.ucla.edu>
2212
2213 port new setting code to Sun C 5.8 2005/10/13
2214 * chartab.c, lisp.h (char_table_set, char_table_set_range):
2215 Return void, not Lisp_Object. Otherwise, the compiler
2216 complains about (A?B:C) where B is void and C is Lisp_Object
2217 when compiling CHAR_TABLE_SET, due to the recent change to
2218 the API of sub_char_table_set_contents.
2219
a999ce26
CY
22202012-08-18 Chong Yidong <cyd@gnu.org>
2221
2222 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
2223 for the string case (Bug#3874).
2224
3f22b86f
PE
22252012-08-18 Paul Eggert <eggert@cs.ucla.edu>
2226
39eb03f1
PE
2227 * buffer.h (BSET): Remove (Bug#12215).
2228 Replace all uses with calls to new setter functions.
2229 (bset_bidi_paragraph_direction, bset_case_canon_table)
2230 (bset_case_eqv_table, bset_directory, bset_display_count)
2231 (bset_display_time, bset_downcase_table)
2232 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
2233 (bset_last_selected_window, bset_local_var_alist)
2234 (bset_mark_active, bset_point_before_scroll, bset_read_only)
2235 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
2236 (bset_width_table):
2237 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
2238 (bset_auto_fill_function, bset_auto_save_file_format)
2239 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
2240 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
2241 (bset_cache_long_line_scans, bset_case_fold_search)
2242 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
2243 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
2244 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
2245 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
2246 (bset_header_line_format, bset_indicate_buffer_boundaries)
2247 (bset_indicate_empty_lines, bset_invisibility_spec)
2248 (bset_left_fringe_width, bset_major_mode, bset_mark)
2249 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
2250 (bset_name, bset_overwrite_mode, bset_pt_marker)
2251 (bset_right_fringe_width, bset_save_length)
2252 (bset_scroll_bar_width, bset_scroll_down_aggressively)
2253 (bset_scroll_up_aggressively, bset_selective_display)
2254 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
2255 (bset_word_wrap, bset_zv_marker):
2256 * category.c (bset_category_table):
2257 * syntax.c (bset_syntax_table):
2258 New setter functions.
2259
6a09a33b
PE
2260 * process.h (PSET): Remove (Bug#12215).
2261 Replace all uses with calls to new setter functions.
2262 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2263 (PROCESS_INLINE): New macro.
2264 (pset_childp): New setter function.
2265 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
2266 * process.c (PROCESS_INLINE):
2267 Define to EXTERN_INLINE, so that the corresponding functions
2268 are compiled into code.
2269 (pset_buffer, pset_command, pset_decode_coding_system)
2270 (pset_decoding_buf, pset_encode_coding_system)
2271 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
2272 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
2273 (pset_type, pset_write_queue): New setter functions.
2274
e8c17b81
PE
2275 * window.h (WSET): Remove (Bug#12215).
2276 Replace all uses with calls to new setter functions.
2277 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2278 (WINDOW_INLINE): New macro.
2279 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
2280 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
2281 (wset_total_lines, wset_vertical_scroll_bar)
2282 (wset_window_end_pos, wset_window_end_valid)
2283 (wset_window_end_vpos): New setter functions.
2284 * window.c (WINDOW_INLINE):
2285 Define to EXTERN_INLINE, so that the corresponding functions
2286 are compiled into code.
2287 (wset_combination_limit, wset_dedicated, wset_display_table)
2288 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
2289 (wset_new_normal, wset_new_total, wset_next_buffers)
2290 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
2291 (wset_prev_buffers, wset_right_fringe_width)
2292 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
2293 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
2294 (wset_window_parameters):
2295 * xdisp.c (wset_base_line_number, wset_base_line_pos)
2296 (wset_column_number_displayed, wset_region_showing):
2297 New setter functions.
2298
3f22b86f
PE
2299 * termhooks.h (TSET): Remove (Bug#12215).
2300 Replace all uses with calls to new setter functions.
2301 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2302 (TERMHOOKS_INLINE): New macro.
2303 (tset_charset_list, tset_selection_alist): New setter functions.
2304 * terminal.c (TERMHOOKS_INLINE):
2305 Define to EXTERN_INLINE, so that the corresponding functions
2306 are compiled into code.
2307 (tset_param_alist): New setter function.
2308
742af32f
PE
23092012-08-17 Paul Eggert <eggert@cs.ucla.edu>
2310
15dbb4d6
PE
2311 * keyboard.h (KSET): Remove (Bug#12215).
2312 Replace all uses with calls to new setter functions.
2313 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2314 (KEYBOARD_INLINE): New macro.
2315 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
2316 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
2317 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
2318 New setter functions.
2319 * keyboard.c (KEYBOARD_INLINE):
2320 Define to EXTERN_INLINE, so that the corresponding functions
2321 are compiled into code.
2322 (kset_echo_string, kset_kbd_queue)
2323 (kset_keyboard_translate_table, kset_last_prefix_arg)
2324 (kset_last_repeatable_command, kset_local_function_key_map)
2325 (kset_overriding_terminal_local_map, kset_real_last_command)
2326 (kset_system_key_syms): New setter functions.
2327
f00af5b1
PE
2328 * frame.h (FSET): Remove (Bug#12215).
2329 Replace all uses with calls to new setter functions.
2330 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2331 (FRAME_INLINE): New macro.
2332 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
2333 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
2334 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
2335 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
2336 (fset_param_alist, fset_root_window, fset_scroll_bars)
2337 (fset_selected_window, fset_title, fset_tool_bar_items)
2338 (fset_tool_bar_position, fset_tool_bar_window): New functions.
2339 * frame.c (FRAME_INLINE):
2340 Define to EXTERN_INLINE, so that the corresponding functions
2341 are compiled into code.
2342 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
2343
0c94c8d6
PE
2344 A few more naming-convention fixes for getters and setters.
2345 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
2346 and rename from buffer_overlays_set_before.
2347 (set_buffer_overlays_after): Move here from buffer.h, and rename
2348 from buffer_overlays_set_after.
2349 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
2350 All uses changed.
2351 (set_buffer_intervals): Rename from buffer_set_intervals.
2352 * intervals.c (set_interval_object): Move here from intervals.h,
2353 and rename from interval_set_object.
2354 (set_interval_left): Move here from intervals.h, and rename from
2355 interval_set_left.
2356 (set_interval_right): Move here from intervals.h, and rename from
2357 interval_set_right.
2358 (copy_interval_parent): Move here from intervals.h, and rename from
2359 interval_copy_parent.
2360 * intervals.h (set_interval_parent): Rename from interval_set_parent.
2361 (set_interval_plist): Rename from interval_set_plist.
2362 Return void, not Lisp_Object, since no caller uses the result.
2363 * lisp.h (string_intervals): Rename from string_get_intervals.
2364 (set_string_intervals): Rename from string_set_intervals.
2365
34dabdb7
PE
2366 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
2367 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 2368 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
2369 All uses changed. See the end of
2370 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
2371
742af32f
PE
2372 * lisp.h (CSET): Remove (Bug#12215).
2373 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
2374 (set_char_table_purpose): New functions,
2375 replacing CSET. All uses changed. For example, replace
2376 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 2377 "set_char_table_parent (char_table, parent);".
742af32f
PE
2378 The old version was confusing because it used the same name
2379 'parent' for two different things.
2380
a04e2c62
DA
23812012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
2382
2383 Functions to get and set Lisp_Object fields of buffer-local variables.
2384 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
2385 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
2386 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
2387 * data.c, eval.c, frame.c: Adjust users.
2388
383dcbf9
CY
23892012-08-17 Chong Yidong <cyd@gnu.org>
2390
2391 * xfaces.c (merge_face_vectors): If the target font specfies a
2392 font spec, make the font's attributes take precedence over
2393 directly-specified attributes.
2394 (merge_face_ref): Recognize :font.
2395
44386687
DA
23962012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
2397
2398 Do not use memcpy for copying intervals.
2399 * intervals.c (reproduce_interval): New function.
2400 (reproduce_tree, reproduce_tree_obj): Use it.
2401 (reproduce_tree_obj): Remove prototype.
2402
927c7216
PE
24032012-08-17 Paul Eggert <eggert@cs.ucla.edu>
2404
2405 * lisp.h (duration_to_sec_usec): Remove unused decl.
2406
93044f7b
AA
24072012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
2408
2409 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
2410 to an allocated instance of NSString, not to the class itself.
2411
9851e4a5
JB
24122012-08-17 Juanma Barranquero <lekktu@gmail.com>
2413
2414 * makefile.w32-in (C_CTYPE_H): New macro.
2415 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
2416 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
2417 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
2418
620f13b0
PE
24192012-08-16 Paul Eggert <eggert@cs.ucla.edu>
2420
2421 Use ASCII tests for character types.
2422 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
2423 * xfns.c, xterm.c:
2424 Don't include <ctype.h>; was not needed.
2425 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
2426 * sysdep.c, xfaces.c:
2427 Include <c-ctype.h> instead of <ctype.h>.
2428 * nsterm.m: Include <c-ctype.h>.
2429 * charset.c (read_hex):
2430 * doc.c (Fsnarf_documentation):
2431 * fileio.c (IS_DRIVE) [WINDOWSNT]:
2432 (DRIVE_LETTER) [DOS_NT]:
2433 (Ffile_name_directory, Fexpand_file_name)
2434 (Fsubstitute_in_file_name):
2435 * font.c (font_parse_xlfd, font_parse_fcname):
2436 * frame.c (x_set_font_backend):
2437 * gtkutil.c (xg_get_font):
2438 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
2439 * nsimage.m (hexchar):
2440 * nsterm.m (ns_xlfd_to_fontname):
2441 * sysdep.c (system_process_attributes):
2442 * xfaces.c (hash_string_case_insensitive):
2443 Use C-locale tests instead of locale-specific tests for character
2444 types, since we want the ASCII interpretation here, not the
2445 interpretation suitable for whatever happens to be the current locale.
2446
52162052
MR
24472012-08-16 Martin Rudalics <rudalics@gmx.at>
2448
2449 Consistently check windows for validity/liveness
2450 (Bug#11984, Bug#12025, Bug#12026).
2451 * lisp.h (CHECK_VALID_WINDOW): New macro.
2452 * window.c (decode_window): Rename to decode_live_window.
2453 (decode_valid_window, Fwindow_valid_p): New functions.
2454 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
2455 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
2456 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
2457 (Fwindow_prev_sibling, Fwindow_combination_limit)
2458 (Fset_window_combination_limit, Fwindow_use_time)
2459 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
2460 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
2461 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
2462 (Fwindow_hscroll, Fset_window_hscroll)
2463 (Fwindow_redisplay_end_trigger)
2464 (Fset_window_redisplay_end_trigger, Fwindow_edges)
2465 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
2466 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2467 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
2468 (Fwindow_end, Fset_window_point, Fset_window_start)
2469 (Fpos_visible_in_window_p, Fwindow_line_height)
2470 (Fwindow_dedicated_p, Fset_window_dedicated_p)
2471 (Fwindow_prev_buffers, Fset_window_prev_buffers)
2472 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
2473 (Fset_window_parameter, Fwindow_display_table)
2474 (Fset_window_display_table, Fdelete_other_windows_internal)
2475 (Fset_window_buffer, Fset_window_new_total)
2476 (Fset_window_new_normal, Fdelete_window_internal)
2477 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
2478 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
2479 (Fwindow_scroll_bars): Check whether argument window is a valid or
2480 live window. Update doc-strings.
2481 (syms_of_window): New symbol Qwindow_valid_p.
2482 * keyboard.c (Fposn_at_x_y): Check whether argument
2483 frame_or_window denotes a valid window.
2484
2751c80f
DA
24852012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
2486
2487 Fix previous char table change.
2488 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
2489 * chartab.c (optimize_sub_char_table): Likewise.
2490
032a42c8
CY
24912012-08-16 Chong Yidong <cyd@gnu.org>
2492
a2d19368
CY
2493 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
2494
032a42c8
CY
2495 * xfont.c (xfont_open):
2496 * xftfont.c (xftfont_open): Set the font's max_width field.
2497
2498 * nsfont.m (nsfont_open): Similar to the Xft backend, set
2499 min_width to space_width and average_width to the average over
2500 printable ASCII characters.
2501 (ns_char_width): Code cleanup.
2502 (ns_ascii_average_width): New utility function.
2503
2504 * font.h (struct font): Update comments.
2505
a098c930
DA
25062012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
2507
032a42c8 2508 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
2509 * lisp.h (CSET): New macro.
2510 (char_table_set_extras, char_table_set_contents)
2511 (sub_char_table_set_contents): New function.
2512 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
2513 * syntax.c: Adjust users.
2514
8be3a09c
SM
25152012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
2516
2517 * eval.c (eval_sub): Bind lexical-binding.
2518 * lread.c (Qlexical_binding): Make non-static.
2519
ac4845a6
JD
25202012-08-15 Jan Djärv <jan.h.d@swipnet.se>
2521
ddee6515
JD
2522 * nsmenu.m (popupSession): Remove.
2523 (pop_down_menu): Remove endModalSession.
2524 (timeout_handler:): New method.
2525 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
2526 Call runModalForWindow. Check timer_fired when it returns.
2527 If not set, cancel timer and break out of loop.
2528 Otherwise loop again, with a new timeout.
2529
2530 * nsterm.m: Include fcntl.h if present.
2531 (fd_entry, t_readfds, inNsSelect): Remove.
2532 (select_writefds, select_valid, select_timeout, selfds)
2533 (select_mutex, apploopnr): Add.
2534 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
2535 Otherwise call kbd_buffer_store_event.
2536 (ns_send_appdefined): Remove release of fd_entry.
2537 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
2538 Increment and decrement apploopnr.
2539 (ns_select): If no file descriptors, just do a NSTimer.
2540 Otherwise copy read/write masks and start select thread (fd_handler).
2541 Start main loop and wait for application defined event.
2542 Inform select thread to stop selecting after main loop is exited.
2543 (ns_term_init): Create selfds pipe and set non-blocking.
fc0c31f8 2544 Initialize select_mutex. Start the select thread (fd_handler).
ddee6515
JD
2545 (fd_handler:): Loop forever, wait for info from the main thread
2546 to either start or stop selecting. When select returns, send
2547 and appdefined event.
2548 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
2549 If not call kbd_buffer_store_event.
2550
2551 * nsterm.h (EmacsApp): fd_handler takes id argument.
2552 (EmacsDialogPanel): Add timer_fired and timeout_handler.
2553
ac4845a6
JD
2554 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
2555
eb424fe3
EZ
25562012-08-15 Eli Zaretskii <eliz@gnu.org>
2557
2558 * region-cache.c (move_cache_gap): Update gap_len using the actual
2559 growth of the boundaries array. Do not change cache_len.
2560 (Bug#12196)
2561
4e6a86c6
DA
25622012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2563
2564 Generalize and cleanup font subsystem checks.
2565 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
2566 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
2567 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 2568
5bf192ca
DA
25692012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2570
2571 * gtkutil.c (xg_get_font): Use pango_units_to_double.
2572
f2045622
CY
25732012-08-15 Chong Yidong <cyd@gnu.org>
2574
8be3a09c
SM
2575 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
2576 When using the new font chooser, use gtk_font_chooser_get_font_desc to
2577 extract the font descriptor instead of just the font name.
2578 In that case, return a font spec instead of a string.
f2045622
CY
2579 (x_last_font_name): Move to this file from xfns.c.
2580
2581 * xfns.c (Fx_select_font): The return value can also be a font
2582 spec. Move x_last_font_name management to gtkutil.c.
2583
2584 * xfaces.c: Make font weight and style symbols non-static.
2585
7f6feb56
SM
25862012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
2587
2588 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
2589 (bug#12117).
2590
fecbd8ff
SM
25912012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
2592
2593 * alloc.c (Fgarbage_collect): Use plural form consistently.
2594
9b8d5165
EZ
25952012-08-14 Eli Zaretskii <eliz@gnu.org>
2596
2597 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
2598 iteration through the command loop. Fixes a problem whereby mouse
2599 movements are ignored until the first mouse click.
2600
f5d9e83a
PE
26012012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2602
2603 Use bool, not int, for Lisp booleans.
2604 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
2605 makes Emacs a bit smaller and presumably a bit faster.
2606 * lisp.h: Include <stdbool.h>.
2607 (struct Lisp_Boolfwd, defvar_bool):
2608 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
2609 * regex.c [!emacs]: Include <stdbool.h>.
2610 (false, true): Remove; <stdbool.h> does this for us now.
2611
55802e4a
CY
26122012-08-14 Chong Yidong <cyd@gnu.org>
2613
4abcdac8
CY
2614 * character.c (Fcharacterp): Doc fix (Bug#12076).
2615
2616 * data.c (Findirect_variable): Doc fix (Bug#11040).
2617
55802e4a
CY
2618 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
2619
2620 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 2621 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 2622
8e99d072
BR
26232012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2624
2625 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
2626 (bug#12022).
2627
08908aca
MR
26282012-08-14 Martin Rudalics <rudalics@gmx.at>
2629
2630 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
2631 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
2632 * minibuf.c (choose_minibuf_frame, read_minibuf):
2633 * w32fns.c (x_create_tip_frame):
2634 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
2635 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
2636
56120d6f
PE
26372012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2638
2639 * intervals.c (offset_intervals): Remove obsolete comment.
2640
67b77c0b
AS
26412012-08-14 Andreas Schwab <schwab@linux-m68k.org>
2642
2643 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
2644
f48b82fd
GR
26452012-08-14 Gergely Risko <gergely@risko.hu>
2646
2647 * coding.c (decode_coding): Record buffer modification before
2648 disabling undo_list (Bug#11773).
2649
fd318b54
DA
26502012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2651
2652 Revert and cleanup some recent overlay changes.
2653 * buffer.h (enum overlay_type): Remove.
2654 (buffer_get_overlays, buffer_set_overlays): Likewise.
2655 (buffer_set_overlays_before, buffer_set_overlays_after):
2656 New function. Adjust users.
2657 (unchain_both): Add eassert.
2658
41a62dd9
DA
26592012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2660
2661 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
2662
5884c324
PE
26632012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2664
2665 * gtkutil.c (xg_mark_data): Don't assume C99.
2666
ca06f160
JD
26672012-08-13 Jan Djärv <jan.h.d@swipnet.se>
2668
2669 * gtkutil.c (xg_frame_tb_info): New struct.
2670 (TB_INFO_KEY): New define.
2671 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
2672 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
2673 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
2674 if not present.
2675 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
fc0c31f8 2676 is up to date. Otherwise store new data.
ca06f160
JD
2677 (free_frame_tool_bar): Free xg_frame_tb_info if present.
2678
7864a3f7
DA
26792012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2680
2681 Use KSET for write access to Lisp_Object members of struct kboard.
2682 * keyboard.h (KSET): New macro.
2683 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
2684 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
2685 * xterm.c: Adjust users.
2686
4c31be61
DA
26872012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2688
2689 Use BSET for write access to Lisp_Object members of struct buffer.
2690 * buffer.h (BSET): New macro.
2691 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
2692 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
2693 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
2694 * window.c, xdisp.c, xfns.c: Adjust users.
2695
14ae4239
BT
26962012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
2697
2698 * lread.c (syms_of_lread): Initialize Vlexical_binding.
2699
32bcadb4
JD
27002012-08-11 Jan Djärv <jan.h.d@swipnet.se>
2701
3d29b2ce 2702 * nsterm.m (not_in_argv): New function.
fc0c31f8 2703 (application:openFile, application:openTempFile:):
3d29b2ce
JD
2704 (application:openFileWithoutUI:, application:openFiles:): Open file
2705 if not_in_argv returns non-zero (bug#12171).
2706
32bcadb4 2707 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
2708 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
2709 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
2710 (xg_get_font_name): Use those functions/macros here.
2711 Reported by Frans Oilinki <moilinki@gmail.com>.
2712
9ff9402d 27132012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
2714
2715 * unexmacosx.c (copy_data_segment): Copy initialized data in
2716 statically linked libraries from input file rather than memory.
2717
db74a5fc
YM
2718 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
2719 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
2720 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
2721
25e65510
GM
27222012-08-10 Glenn Morris <rgm@gnu.org>
2723
2724 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
2725 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
2726
7961135c
DA
27272012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2728
2729 Fix last change to allow compilation with low optimization levels.
2730 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
2731 Reported by Jan Djärv <jan.h.d@swipnet.se>.
2732
42b3a444
DA
27332012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2734
2735 Use common inline syntax in intervals.h.
2736 * intervals.h (INTERVALS_INLINE): New macro.
2737 Change all users from LISP_INLINE.
2738
9fb0c957
DA
27392012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2740
2741 Define Qnone once for all platforms.
2742 * frame.c (Qnone): Define here.
2743 (syms_of_frame): DEFSYM it.
2744 * lisp.h (Qnone): New declaration.
2745 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
2746 * xfns.c: Remove duplication. Adjust users.
2747
65e8ee52
DA
27482012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2749
2750 Remove unused macros from intervals.h.
2751 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
2752 * intervals.c: Adjust comment.
2753
9b855fd6
EZ
27542012-08-10 Eli Zaretskii <eliz@gnu.org>
2755
2756 * w32fns.c <w32_unicode_gui>: New static variable.
2757 (globals_of_w32fns): Initialize it according to os_subtype.
2758 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
2759 testing os_subtype.
2760
39cb9e56 27612012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
2762 Eli Zaretskii <eliz@gnu.org>
2763
2764 Fix bug #10299 with Unicode characters sent by customized
2765 keyboards created by MSKLC.
2766 * w32fns.c (INIT_WINDOW_CLASS): New macro.
2767 (w32_init_class): Use it to initialize the Emacs class with either
2768 ANSI or Unicode API calls.
2769 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
2770 later.
2771 (w32_wnd_proc): If the character code sent by WM_CHAR or
2772 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
2773 original message. Call DefWindowProcW on NT and later.
2774
9374581a
GM
27752012-08-10 Glenn Morris <rgm@gnu.org>
2776
4b94e8cf
GM
2777 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
2778
9374581a
GM
2779 * lisp.h (DIRECTORY_SEP): Let configure set it.
2780
a2752828
DA
27812012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2782
2783 Use TSET for write access to Lisp_Object slots of struct terminal.
2784 * termhooks.h (TSET): New macro.
2785 * coding.c, terminal.c, xselect.c: Adjust users.
2786
cc92c454
SM
27872012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
2788
2789 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
2790 the failing expression, include them in the error message.
2791 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
2792 * lisp.h (internal_condition_case_n): Update declaration.
2793
4cb3e6b3
DA
27942012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2795
2796 Inline functions to examine and change buffer overlays.
2797 * buffer.c (unchain_both): New function.
2798 * buffer.h (buffer_get_overlays, buffer_set_overlays):
2799 (buffer_has_overlays): New function.
2800 (enum overlay_type): New enum.
2801 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
2802 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
2803
8707c1e5
DA
28042012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2805
2806 Inline functions to examine and change buffer intervals.
2807 * alloc.c (mark_interval_tree): Remove.
2808 (MARK_INTERVAL_TREE): Simplify.
2809 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
2810 * intervals.c (buffer_balance_intervals): New function.
2811 (graft_intervals_into_buffer): Adjust indentation.
2812 (set_intervals_multibyte): Simplify.
2813 * buffer.h (BUF_INTERVALS): Remove.
2814 (buffer_get_intervals, buffer_set_intervals): New function.
2815 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
2816 * intervals.c, textprop.c: Adjust users.
2817
ad8c997f
DA
28182012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2819
2820 Inline functions to examine and change string intervals.
2821 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
2822 (string_get_intervals, string_set_intervals): New function.
2823 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2824 * lread.c, print.c, textprop.c: Adjust users.
2825
32ac3a6b
GM
28262012-08-08 Glenn Morris <rgm@gnu.org>
2827
2828 * lisp.mk (lisp): Remove language/persian.elc.
2829
77c7bcb1
DA
28302012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2831
2832 Cleanup intervals.
2833 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
2834 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
2835 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
2836 Adjust comment. Move under #if 0.
77c7bcb1
DA
2837 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2838 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
2839
9c08a8d4
DA
28402012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2841
2842 Check total length of intervals with eassert.
2843 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
2844 * intervals.c: Change all users to eassert.
2845
26d16b35
EZ
28462012-08-07 Eli Zaretskii <eliz@gnu.org>
2847
14ae4239
BT
2848 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
2849 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
2850 INTERNAL_FIELD in Lisp_Cons.
2851
c644523b
DA
28522012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2853
2854 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
2855 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
2856 name since all xname users are fixed long time ago. Do not
2857 use INTERNAL_FIELD.
2858 (set_symbol_name, set_symbol_function, set_symbol_plist):
2859 (set_symbol_next, set_overlay_plist): New function.
2860 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
2861 (struct Lisp_Overlay): Likewise.
2862 (CVAR, MVAR, SVAR): Remove.
2863 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
2864 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
2865 * xterm.c: Adjust users.
2866 * .gdbinit: Change to use name field of struct Lisp_Symbol
2867 where appropriate.
2868
6a3d20cc
DA
28692012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2870
2871 Basic functions to set Lisp_Object and pointer slots of intervals.
2872 * intervals.h (interval_set_parent, interval_set_object):
2873 (interval_set_left, interval_set_right, interval_set_plist):
2874 (interval_copy_parent): New function.
2875 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
2876 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
2877 Adjust indentation.
6a3d20cc
DA
2878 (INTERVAL_SIZE): Remove. Adjust users.
2879 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
2880
4d2b044c
DA
28812012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2882
2883 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
2884 * process.h (PGET): Remove.
2885 (struct Lisp_Process): Do not use INTERNAL_FIELD.
2886 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2887
d3d50620
DA
28882012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2889
2890 Drop WGET and revert read access to Lisp_Objects slots of struct window.
2891 * window.h (WGET): Remove.
2892 (struct window): Do not use INTERNAL_FIELD.
2893 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2894 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2895 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2896 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2897 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2898 Adjust users.
2899
d10a51dc
CY
29002012-08-07 Chong Yidong <cyd@gnu.org>
2901
2902 * window.c (Fwindow_edges, Fwindow_pixel_edges)
2903 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
2904 (Fdelete_window_internal): Signal an error if the window is not on
2905 a live frame (Bug#12025).
2906
e69b0960
DA
29072012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2908
2909 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
2910 * frame.h (FGET): Remove.
2911 (struct frame): Do not use INTERNAL_FIELD.
2912 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2913 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2914 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2915 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2916
25a20a3a
JB
29172012-08-06 Juanma Barranquero <lekktu@gmail.com>
2918
2919 * w32.c: Silence compiler warnings.
2920 (map_w32_filename): Remove unused variable `is_fat'.
2921 (chase_symlinks): Add parentheses around expression.
2922
1c6f11f4
GM
29232012-08-06 Glenn Morris <rgm@gnu.org>
2924
1db4583a
GM
2925 * sysdep.c: Respect BROKEN_GETWD.
2926
1c6f11f4
GM
2927 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
2928 Let configure handle it.
2929 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
2930
2b90362b
DA
29312012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2932
2933 Use GCALIGNMENT where appropriate.
2934 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
2935 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
2936 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
2937
5f50daf2
EZ
29382012-08-06 Eli Zaretskii <eliz@gnu.org>
2939
14ae4239
BT
2940 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
2941 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 2942
cbcc7007
SM
29432012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
2944
2945 * buffer.h (struct buffer): Revert `indirections' to a simple int;
2946 that should be sufficient for everyone.
2947
4d365fa4
JD
29482012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2949
2950 * keyboard.c (timer_check_2): Add break so timer_check returns next
2951 timeout.
2952
dd86bd82
DA
29532012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2954
2955 Fix Windows build errors introduced after converting to WGET and WSET.
2956 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
2957 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2958
054e1668
JD
29592012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2960
2961 * nsterm.m (ns_frame_rehighlight): Use FSET.
2962
2963 * nsmenu.m (ns_update_menubar): Use FSET.
2964
21238f11
DA
29652012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2966
2967 Separate read and write access to Lisp_Object slots of Lisp_Process.
2968 * process.h (PGET, PSET): New macros similar to AREF and ASET.
2969 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2970
077288cf
DA
29712012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2972
2973 Separate read and write access to Lisp_Object slots of struct window.
2974 * window.h (WGET, WSET): New macros similar to AREF and ASET.
2975 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2976 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2977 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2978 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2979 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2980 Adjust users.
2981
71688bd7
DA
29822012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2983
2984 Fix Windows build errors introduced after converting to FGET and FSET.
2985 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
2986 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
2987 (w32_judge_scroll_bars): Change to use FSET.
2988 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2989
f99bac93
DA
29902012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2991
2992 Fix replacement typo.
2993 * window.c (replace_window): Set root_window instead of
2994 selected_window. This fixes a total window subsystem
2995 malfunction reported by Bastien Guerry <bzg@gnu.org>.
2996
8c2a0f2d
GM
29972012-08-06 Glenn Morris <rgm@gnu.org>
2998
2999 * lisp.mk (lisp): Add language/persian.elc.
3000
edd74c35
DA
30012012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3002
3003 Separate read and write access to Lisp_Object slots of struct frame.
3004 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
3005 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
3006 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
3007 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
3008 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
3009
8671676c
AS
30102012-08-05 Andreas Schwab <schwab@linux-m68k.org>
3011
3012 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
3013
663e2b3f
DA
30142012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
3015
3016 Generalize common compile-time constants.
3017 * lisp.h (header_size, bool_header_size, word_size): Now here.
3018 (struct Lisp_Vector): Add comment.
3019 (struct Lisp_Bool_Vector): Move up to define handy constants.
3020 (VECSIZE, PSEUDOVECSIZE): Simplify.
3021 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
3022 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
3023 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
3024 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
3025 * xfont.c, xmenu.c: Use word_size where appropriate.
3026
d32e47af
LM
30272012-08-05 Lawrence Mitchell <wence@gmx.li>
3028
3029 * search.c (Freplace_match): Treat \? in the replacement text
3030 literally (Bug#8161).
3031
e5d9c0d1
CY
30322012-08-05 Chong Yidong <cyd@gnu.org>
3033
3034 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
3035 * frame.c (Vdelete_frame_functions):
3036 * emacs.c (Vkill_emacs_hook): Doc fix.
3037
8da0576b
EZ
30382012-08-04 Eli Zaretskii <eliz@gnu.org>
3039
3040 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
3041 --with-x-toolkit=no builds.
3042 Reported by Carsten Mattner <carstenmattner@gmail.com>.
3043
02676e5d
CY
30442012-08-04 Chong Yidong <cyd@gnu.org>
3045
3046 * syntax.c (Fmodify_syntax_entry): Doc fix.
3047
97147da9
EZ
30482012-08-04 Eli Zaretskii <eliz@gnu.org>
3049
76151e2c
EZ
3050 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
3051 * w32.c (init_environment): Change the default values of many
3052 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
3053 them into environment when they were not already defined.
3054 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 3055 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
3056 (check_windows_init_file): Now external, not static.
3057 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
3058 called when Vload_path is already set up.
3059
3060 * w32.h (check_windows_init_file): Add prototype.
3061
3062 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
3063 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
3064 compatibility with Posix platforms.
3065 (main): Move the call to check_windows_init_file to here from
3066 w32.c.
3067 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
3068 any, in the DEFALT argument into the root of the Emacs build or
3069 installation tree, as appropriate.
3070
3071 * callproc.c (init_callproc_1): Call decode_env_path instead of
3072 doing its equivalent by hand.
3073 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
3074 the code that sets Vexec_path run on MS-Windows.
3075
3076 * lread.c (init_lread): Add comments to #ifdef's.
3077
97147da9
EZ
3078 * msdos.c (dos_set_window_size, IT_update_begin)
3079 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
3080 instead of direct references.
3081
185ee146
PE
30822012-08-04 Paul Eggert <eggert@cs.ucla.edu>
3083
3084 Export DEFAULT_REHASH_* to GDB.
3085 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
3086 Now constants, not macros.
3087
8834c57a
PE
30882012-08-03 Paul Eggert <eggert@cs.ucla.edu>
3089
98c6f1e3
PE
3090 Remove unnecessary casts involving pointers.
3091 These casts are no longer needed now that we assume C89 or later,
3092 since they involve casting to or from void *.
3093 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
3094 (make_pure_float, make_pure_vector):
3095 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
3096 * macros.c (Fstart_kbd_macro):
3097 * menu.c (find_and_return_menu_selection):
3098 * minibuf.c (read_minibuf_noninteractive):
3099 * sysdep.c (closedir):
3100 * xdisp.c (x_produce_glyphs):
3101 * xfaces.c (compare_fonts_by_sort_order):
3102 * xfns.c (x_real_positions, select_visual):
3103 * xselect.c (x_stop_queuing_selection_requests)
3104 (x_get_window_property, x_get_window_property_as_lisp_data):
3105 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
3106 Remove unnecessary pointer casts.
3107 * alloc.c (record_xmalloc): New function.
3108 * lisp.h (record_xmalloc): New decl.
3109 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
3110 more like a function. This is because the pointer cast is not
3111 needed. All uses changed.
3112 * print.c (print_string, print_error_message): Avoid length recalc.
3113
8834c57a
PE
3114 Improve fix for macroexp crash with debugging (Bug#12118).
3115 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
3116 ARRAY_MARK_FLAG when checking subscripts, because ASET is
3117 not supposed to be invoked from the garbage collector.
3118 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
3119 (gc_aset): New function, which is like ASET but can be
3120 used in the garbage collector.
3121 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
3122 (set_hash_index): Use it instead of ASET.
3123
6dad7178
EZ
31242012-08-03 Eli Zaretskii <eliz@gnu.org>
3125
3126 Support symlinks on latest versions of MS-Windows.
3127 * w32.c: Include winioctl.h and aclapi.h.
3128 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
3129 (revert_to_self): Forward declarations of static functions.
3130 <static BOOL g_b_init_get_security_info>:
3131 <g_b_init_create_symbolic_link>: New static flags.
3132 (globals_of_w32): Initialize them to zero.
3133 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
3134 (map_w32_filename): Improve commentary. Simplify switch.
3135 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
3136 headers (most versions of MinGW w32api don't).
3137 (get_security_info, create_symbolic_link)
3138 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
3139 New functions.
3140 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
3141 in the argument file name.
3142 (sys_access): Call unc_volume_file_attributes only if
3143 GetFileAttributes fails with network-related error codes.
3144 (sys_rename): Diagnose renaming of a symlink when the user doesn't
3145 have the required privileges.
14ae4239 3146 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
3147 get_file_security_desc.
3148 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
3149 with addition of handling of symlinks and support for 'lstat'.
3150 If possible, get file's attributes and security information by
6dad7178
EZ
3151 handle, not by name. Produce S_IFLNK bit for symlinks, when
3152 called from 'lstat'.
3153 (stat, lstat): New functions, call 'stat_worker'.
3154 (symlink, readlink, careadlinkat): Rewritten to create and resolve
3155 symlinks when the underlying filesystem supports them.
3156
f162bcc3
PE
31572012-08-02 Paul Eggert <eggert@cs.ucla.edu>
3158
79ea6c20
PE
3159 Fix macroexp crash on Windows with debugging (Bug#12118).
3160 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
3161 checking subscripts; problem introduced with the recent
3162 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
3163 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
3164 since it's used in non-static inline functions now.
3165
c0ce93fd
PE
3166 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
3167 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 3168
f162bcc3
PE
3169 Use C99-style 'extern inline' if available.
3170 * buffer.h (BUFFER_INLINE):
3171 * category.h (CATEGORY_INLINE):
3172 * character.h (CHARACTER_INLINE):
3173 * charset.h (CHARSET_INLINE):
3174 * composite.h (COMPOSITE_INLINE):
3175 * dispextern.h (DISPEXTERN_INLINE):
3176 * lisp.h (LISP_INLINE):
3177 * systime.h (SYSTIME_INLINE):
3178 New macro, replacing 'static inline' in this header.
3179 * buffer.h, category.h, character.h, charset.h, composite.h:
3180 * dispextern.h, lisp.h, systime.h:
3181 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3182 * alloc.c (LISP_INLINE):
3183 * buffer.c (BUFFER_INLINE):
3184 * category.c (CATEGORY_INLINE):
3185 * character.c (CHARACTER_INLINE):
3186 * charset.c (CHARSET_INLINE):
3187 * composite.c (COMPOSITE_INLINE):
3188 * dispnew.c (DISPEXTERN_INLINE):
3189 * sysdep.c (SYSTIME_INLINE):
3190 Define to EXTERN_INLINE, so that the corresponding functions
3191 are compiled into code.
3192 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
3193 (INLINE_HEADER_END): New macros.
3194 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
3195 since it's used in non-static inline functions now.
a8333d03 3196 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 3197
837b365b
GM
31982012-08-02 Glenn Morris <rgm@gnu.org>
3199
d66b744d
GM
3200 * s/: Remove empty directory.
3201
837b365b
GM
3202 * s/ms-w32.h: Move to ../nt/inc.
3203 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
3204 Update for new ms-w32.h location.
3205
13294f95
PE
32062012-08-02 Paul Eggert <eggert@cs.ucla.edu>
3207
3208 Port to Solaris 8.
3209 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
3210
90df0db3
GM
32112012-08-02 Glenn Morris <rgm@gnu.org>
3212
3213 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
3214 hard-coding the path separator.
3215
4939150c
PE
32162012-08-01 Paul Eggert <eggert@cs.ucla.edu>
3217
3218 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
3219 This how ASET and AREF are supposed to work, and makes
3220 it easier to think about future improvements. See
3221 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
3222 * charset.h (set_charset_attr): New function.
3223 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
3224 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
3225 (aref_addr): New function. All uses of &AREF(...) changed.
3226 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
3227 (set_hash_index): New functions. All lvalue-style uses of
3228 HASH_KEY etc. changed.
3229 * keyboard.c (set_prop): New function. All lvalue-style uses
3230 of PROP changed.
3231
947b2afd
AA
32322012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
3233
3234 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
3235 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
3236 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
3237 * nsfns.m (ns_set_name_as_filename): Likewise.
3238 * nsmenu.m (ns_update_menubar): Likewise.
3239 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
3240
4f5d0325
EZ
32412012-08-01 Eli Zaretskii <eliz@gnu.org>
3242
2008beae
EZ
3243 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
3244 Adapt to latest changes in field names of the corresponding Lisp
288479f6 3245 objects.
2008beae 3246
4f5d0325
EZ
3247 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
3248
fe3cc771
GM
32492012-08-01 Glenn Morris <rgm@gnu.org>
3250
3251 * s/msdos.h: Remove file.
3252 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
3253 * Makefile.in (S_FILE): Remove.
3254 (config_h): Remove S_FILE.
3255
c90acc54
JB
32562012-08-01 Juanma Barranquero <lekktu@gmail.com>
3257
3258 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
3259 Remove; moved to nt/config.nt.
3260
d8a05828
DA
32612012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3262
3263 Use INTERNAL_FIELD for conses and overlays.
3264 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
3265 Remove obsolete comment.
3266 (MVAR): New macro.
3267 (struct Lisp_Overlay): Use INTERNAL_FIELD.
3268 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
3269
8271d590
DA
32702012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3271
3272 Use INTERNAL_FIELD for symbols.
3273 * lisp.h (SVAR): New macro. Adjust users.
3274 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
3275 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
3276
3193acd2
DA
32772012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3278
3279 Use INTERNAL_FIELD for processes.
3280 * process.h (PVAR): New macro. Adjust style.
3281 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
3282 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
3283
3a45383a
DA
32842012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3285
3286 Use INTERNAL_FIELD for windows.
3287 * window.h (WVAR): New macro.
3288 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
3289 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3290 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3291 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
3292 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
3293 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
3294
c1dbc63c
PE
32952012-08-01 Paul Eggert <eggert@cs.ucla.edu>
3296
3297 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
3298
5c0c0e8a
GM
32992012-08-01 Glenn Morris <rgm@gnu.org>
3300
3301 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
3302 Move to configure.ac.
3303
552a99b4
JB
33042012-08-01 Juanma Barranquero <lekktu@gmail.com>
3305
3306 * makefile.w32-in (CONFIG_H): Update dependencies.
3307 (CONF_POST_H): New macro.
3308
3309 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
3310
8d8e2dfe
GM
33112012-07-31 Glenn Morris <rgm@gnu.org>
3312
bc96620a
GM
3313 * Makefile.in (S_FILE): No longer set by configure.
3314
476b1b2d
GM
3315 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
3316 is available.
3317 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
3318
b2c7a106
GM
3319 * process.h (NULL_DEVICE):
3320 * emacs.c (SEPCHAR):
3321 * editfns.c (USER_FULL_NAME): Let configure set them.
3322
d53d062a
GM
3323 * s/README, s/template.h: Remove files.
3324
4515017f
GM
3325 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
3326
8d8e2dfe
GM
3327 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
3328 Move to configure.ac.
3329
5b20b3cc
EZ
33302012-07-31 Eli Zaretskii <eliz@gnu.org>
3331
1e0afd9a
EZ
3332 * .gdbinit (xframe): Adapt to introduction of FVAR and the
3333 resulting renaming of 'struct frame' members.
3334
5b20b3cc
EZ
3335 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
3336
3337 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
3338 after introduction of FVAR.
3339
f1310128
JD
33402012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3341
79e721e0
JD
3342 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
3343
3344 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
3345 instead of compositeToPoint.
3346 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
3347
8d7c7eed 3348 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 3349
e34f7f79
DA
33502012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3351
3352 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
3353 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 3354 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
3355 (BVAR): Change to use INTERNAL_FIELD.
3356 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
3357 (KVAR): Change to use INTERNAL_FIELD.
3358 * frame.h (FVAR): New macro.
3359 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
3360 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
3361 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
3362 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
3363 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
3364
c09bfb2f
DA
33652012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3366
3367 Miscellaneous fixes for non-default X toolkits.
3368 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
3369 * xterm.c (x_frame_of_widget): Remove redundant prototype.
3370 Move under #ifdef USE_LUCID.
3371 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
3372 definition and usage to avoid warnings.
3373
14c114ae
JD
33742012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3375
3376 * nsterm.m (openFiles): Fix previous checkin.
3377
3bd21e82
PE
33782012-07-31 Paul Eggert <eggert@cs.ucla.edu>
3379
3380 * indent.c (compute_motion): Remove unused local.
3381
c1529ded
GM
33822012-07-31 Glenn Morris <rgm@gnu.org>
3383
400d5621
GM
3384 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
3385
268e2432
GM
3386 * conf_post.h [USG5_4]:
3387 Move remaining contents of s/usg5-4-common.h here.
3388 * s/usg5-4-common.h: Remove file.
3389
7552f3ee
GM
3390 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
3391 * s/irix6-5.h: Remove file.
3392
6a381852
GM
3393 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
3394 * s/darwin.h: Remove file.
3395
c1529ded
GM
3396 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
3397 * s/hpux10-20.h: Remove file, which is now empty.
3398
b429a4ee
GM
33992012-07-30 Glenn Morris <rgm@gnu.org>
3400
3401 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
3402 * Makefile.in (config_h): Add conf_post.h.
3403 * makefile.w32-in (CONFIG_H): Add conf_post.h.
3404
adff3182
JD
34052012-07-30 Jan Djärv <jan.h.d@swipnet.se>
3406
3407 * nsterm.m (ns_do_open_file): New variable.
b9031d69 3408 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
3409 (openFile, openTempFile, openFileWithoutUI, openFiles):
3410 Open files only if ns_do_open_file.
adff3182 3411
c32af1e4
PE
34122012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3413
7393bcbb
PE
3414 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
3415 This no-op macro hasn't been needed for many years.
3416 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
3417
c32af1e4
PE
3418 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
3419 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
3420 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
3421 gdb_make_enums_visible.
3422 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
3423 (DIRECTORY_SEP): Now a constant, not a macro.
3424
302fc036
EZ
34252012-07-30 Eli Zaretskii <eliz@gnu.org>
3426
3427 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
3428 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
3429
3430 * w32term.c <w32_keyboard_codepage>: Renamed from
3431 keyboard_codepage and now external. All users changed.
3432
3433 * w32term.h: Add declaration of w32_keyboard_codepage.
3434
3435 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
3436 the codepage to translate keys to Unicode. If this argument is
3437 -1, use the value returned by GetConsoleCP. All callers changed.
3438
88fb40b4
PE
34392012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3440
0aee6912
PE
3441 Update .PHONY listings in makefiles.
3442 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
3443 bootstrap-clean, distclean, maintainer-clean, versioclean,
3444 extraclean, frc.
3445
88fb40b4
PE
3446 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
3447 This is a bit clearer. Fix some commentary typos.
3448
0a763bd1
GM
34492012-07-30 Glenn Morris <rgm@gnu.org>
3450
32bac6d6
GM
3451 * s/netbsd.h: Let configure include signal.h if needed.
3452 Remove file, which is now empty.
3453
b65e7c46
GM
3454 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
3455 Let configure set them.
3456 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
3457 No more need to undefine.
0a763bd1 3458
169304bd
AS
34592012-07-30 Andreas Schwab <schwab@linux-m68k.org>
3460
3461 * keymap.c (Fkey_description): Don't remove 0x80 bit from
3462 non-single-byte char when adding meta modifier. (Bug#12090)
3463
6cd7a139
DA
34642012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
3465
3466 Convert safe_call to use variable number of arguments.
3467 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
3468 (safe_call2): Fix comment.
3469 * lisp.h (safe_call): Adjust prototype.
3470 * coding.c (encode_coding_object): Change to use safe_call2.
3471 * xfaces.c (merge_face_heights): Change to use safe_call1.
3472
d34d6ffc
GM
34732012-07-30 Glenn Morris <rgm@gnu.org>
3474
7b8a48e4 3475 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 3476 does that unconditionally. Remove file, which is now empty.
7b8a48e4 3477
d34d6ffc
GM
3478 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
3479 Remove empty files.
3480
03a660a6
PE
34812012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3482
3483 Export to GDB most of lisp.h's remaining object-like macros.
3484 * lisp.h (min, max): Move earlier, because they're used earlier now.
3485 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
3486 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
3487 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
3488 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
3489 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
3490 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
3491 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
3492 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
3493 Now constants, for GDB. They need not be macros.
3494 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
3495 Now constants, for GDB, as well as macros, for static initializers.
3496 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
3497 Move to after the definition of struct Lisp_Char_Table,
3498 since the former now needs that type defined.
3499 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
3500 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
3501 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
3502 New enums, for gdb_make_enums_visible.
3503 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 3504 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
3505 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
3506 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
3507 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
3508 enum maxargs, enum MAX_ALLOCA.
3509 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
3510 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
3511 no longer needed, now that they are done in lisp.h.
3512
e499d0ee
DA
35132012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
3514
3515 Cleanup string bytes checking.
3516 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
3517 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
3518 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
3519 (check_sblock, compact_small_strings): Simplify.
3520
d5040d2d
PE
35212012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3522
3523 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
3524 These macros are confusing and no longer need to be defined, as
3525 the enum values now suffice. All uses replaced with definiens.
3526 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
3527
7f259ae6
JB
35282012-07-29 Juanma Barranquero <lekktu@gmail.com>
3529
3530 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
3531 ($(BLD)/w32console.$(O)): Update dependencies.
3532
7e63e0c3
DA
35332012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3534
3535 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
3536 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
3537 time. Adjust users.
3538 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
3539
ffd817eb
JD
35402012-07-29 Jan Djärv <jan.h.d@swipnet.se>
3541
3542 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
3543 setting sitelisp (Bug#12010).
3544
417a7a0e
EZ
35452012-07-29 Eli Zaretskii <eliz@gnu.org>
3546
14ae4239 3547 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
3548
3549 * w32heap.c (cache_system_info):
3550 * w32.c (sys_rename):
3551 * w32proc.c (find_child_console, sys_kill): All users changed.
3552
387d4d92
PE
35532012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3554
3555 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
3556
55a6cca6
EZ
35572012-07-29 Eli Zaretskii <eliz@gnu.org>
3558
3559 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
3560
dbcf001c
DA
35612012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3562
3563 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
3564 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
3565 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 3566
e2688e4a
DA
35672012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3568
3569 Generalize marker debugging code under MARKER_DEBUG and use eassert.
3570 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
3571 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
3572 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
3573 (replace_range, replace_range_2, del_range_2): Change to eassert.
3574 * marker.c (byte_char_debug_check): Adjust style.
3575
b46a6a83
PE
35762012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3577
3578 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
3579 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
3580 long-ago-commented-out code that talks about "WIN32".
3581 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
3582 All uses changed.
3583
e32a5799
PE
35842012-07-28 Paul Eggert <eggert@cs.ucla.edu>
3585
3586 Use Gnulib stdalign module (Bug#9772, Bug#9960).
3587 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
3588 Simplify by using alignof.
3589 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
3590 * lisp.h: Include <stdalign.h>.
3591 (GCALIGNMENT): New macro and constant.
3592 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
3593 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
3594 (stdalign): New macro, if not already defined.
3595
df81cd29
EZ
35962012-07-28 Eli Zaretskii <eliz@gnu.org>
3597
01bd1b0d
EZ
3598 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
3599 * w32inevt.c: Include w32inevt.h.
3600 (w32_read_console_input): New inline function, calls either
3601 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
3602 w32_console_unicode_input.
3603 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
3604 (w32_kbd_patch_key, key_event): Use the codepage returned by
3605 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
3606 (key_event): use uChar.UnicodeChar only if
3607 w32_console_unicode_input is non-zero.
3608
3609 * w32console.c: Include w32heap.h.
3610 <w32_console_unicode_input>: New global variable.
3611 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
3612 family of Windows, zero otherwise.
3613
3614 * w32inevt.h: Declare w32_console_unicode_input.
3615
df81cd29
EZ
3616 * xdisp.c (init_iterator): Don't reference tip_frame in a build
3617 --without-x. (Bug#11742)
3618
c20fdd9e
PE
36192012-07-27 Paul Eggert <eggert@cs.ucla.edu>
3620
3621 Adjust GDB to reflect pvec_type changes (Bug#12036).
3622 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
3623 2012-07-04 changes to pseudovector representation.
3624 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 3625
32770973 36262012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
3627
3628 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
3629 bus address.
3630 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
3631
3438fe21
EZ
36322012-07-27 Eli Zaretskii <eliz@gnu.org>
3633
bcfbc9de
EZ
3634 * alloc.c (listn): Fix the order the arguments are consed onto the
3635 list.
3636
3438fe21
EZ
3637 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
3638 enumeration constants, as PURE and HEAP are too general, and clash
3639 with other headers and sources, such as gmalloc.c and the
3640 MS-Windows system headers. All users changed.
3641
eeaea515
DA
36422012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3643
3644 Revert last save_excursion_save and save_excursion_restore changes.
3645 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
3646 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
3647
073c88c2
DA
36482012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3649
3650 Fix recently-introduced typos in Windows port.
3651 Reported by Martin Rudalics <rudalics@gmx.at>.
3652 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 3653 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 3654
4706125e
PE
36552012-07-27 Paul Eggert <eggert@cs.ucla.edu>
3656
3657 Improve GDB symbol export (Bug#12036).
3658 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
3659 arms of an 'if', not using conditional expressions; otherwise GDB
3660 complains about the types in the unevaluated arm when the argument
3661 is an integer literal.
3662 (xgetint): Simplify expression.
3663 * alloc.c (gdb_make_enums_visible): New constant. This ports to
3664 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
3665 Zaretskii in <http://bugs.gnu.org/12036#13>.
3666 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
3667 needed now that we have gdb_make_enums_visible.
3668 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
3669 (enum enum_USE_LSB_TAG):
3670 New enum types, packaging up enums that need to be exported to GDB.
3671
694b6c97
DA
36722012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3673
3674 Utility function to make a list from specified amount of objects.
3675 * lisp.h (enum constype): New datatype.
3676 (listn): New prototype.
3677 * alloc.c (listn): New function.
3678 (Fmemory_use_count, syms_of_alloc): Use it.
3679 * buffer.c (syms_of_buffer): Likewise.
3680 * callint.c (syms_of_callint): Likewise.
3681 * charset.c (define_charset_internal): Likewise.
3682 * coding.c (syms_of_coding): Likewise.
3683 * keymap.c (syms_of_keymap): Likewise.
3684 * search.c (syms_of_search): Likewise.
3685 * syntax.c (syms_of_syntax): Likewise.
3686 * w32.c (init_environment): Likewise.
3687 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
3688 * xdisp.c (syms_of_xdisp): Likewise.
3689 * xfns.c (syms_of_xfns): Likewise.
3690
6195f384
DA
36912012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3692
3693 Fast save_excursion_save and save_excursion_restore.
3694 * lisp.h (struct Lisp_Excursion): New data type.
3695 (PVEC_EXCURSION): New pseudovector type.
3696 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
3697 to deal with it. Adjust comments.
3698 (init_marker, attach_marker): New prototype.
3699 (unchain_marker): Adjust prototype.
3700 * marker.c (attach_marker): Change to global.
3701 (init_marker): New function.
3702 * alloc.c (Fmake_marker, build_marker): Use it.
3703 (build_marker): More easserts.
3704 (mark_object): Handle struct Lisp_Excursion.
3705 * editfns.c (save_excursion_save, save_excursion_restore):
3706 Reimplement to use struct Lisp_Excursion. Add comments.
3707
5eceb8fb
PE
37082012-07-26 Paul Eggert <eggert@cs.ucla.edu>
3709
3710 Fix export of symbols to GDB (Bug#12036).
3711 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
3712 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
3713 emacs.c, as this is a more-suitable home. Had this been done earlier
3714 the fix for 12036 would have avoided some of the problems noted in
3715 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
3716 would have been more obvious.
562157c8
PE
3717 * emacs.c: Do not include <verify.h>; no longer needed.
3718 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
3719 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
3720 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
3721 Remove; now done in lisp.h.
3722 * lisp.h (PUBLISH_TO_GDB): New macro.
3723 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
3724 (DATA_SEG_BITS): Use it.
3725 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
3726 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
3727 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
3728 not be usable in #if. This simplifies things.
3729
d6749401
JB
37302012-07-26 Juanma Barranquero <lekktu@gmail.com>
3731
3732 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
3733
1781b9e9
PE
37342012-07-26 Paul Eggert <eggert@cs.ucla.edu>
3735
d89518db 3736 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
3737 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
3738 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
3739 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
3740 Adjust to changes in lisp.h and emacs.c, by using
3741 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
3742 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
3743 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
3744 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
3745 instead of gdb_valbits.
3746 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
3747 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
3748 instead of gdb_array_mark_flag.
3749 (xboolvector): Get size from $->size, not $->header.size.
3750 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
3751 (xreload, hook-run, hookpost-run): Remove.
3752 * emacs.c: Include <verify.h>.
3753 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
3754 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
3755 Remove.
3756 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
3757 (gdb_USE_LSB_TAG): New enum constants.
3758 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
3759 Also define these as enum constants, so they're visible to GDB.
3760 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
3761 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
3762 as constants, so they're visible to GDB.
3763 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
3764 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
3765 Now enum constants, not macros, so they're visible to GDB.
3766 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
3767 more convenient now. All uses changed.
3768 (VALMASK) [USE_LSB_TAG]: Also define in this case.
3769 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
3770
3628596a
DA
37712012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
3772
3773 Explicitly free restriction data that are not needed anymore.
3774 * editfns.c (save_restriction_restore): Free restriction data.
3775
7abaf5cc
SM
37762012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
3777
3778 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
3779 add argument, tune behavior, and adjust all callers.
3780
71f88e00
PE
37812012-07-25 Paul Eggert <eggert@cs.ucla.edu>
3782
3783 Use typedef for EMACS_INT, EMACS_UINT.
3784 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
3785 than macros. This simplifies debugging in the usual case, since
3786 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
3787 and it allows expressions involving EMACS_INT casts.
3788 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
3789
57ec3034
JD
37902012-07-25 Jan Djärv <jan.h.d@swipnet.se>
3791
3792 * nsterm.m (ns_read_socket): Return early if there is a modal
3793 window (Bug#12043).
3794
8137e7b3
MR
37952012-07-25 Martin Rudalics <rudalics@gmx.at>
3796
3797 * frame.c (Fredirect_frame_focus): In doc-string don't mention
3798 that FOCUS-FRAME can be omitted.
3799
04e9897c
DA
38002012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
3801
3802 Adjust buffer text indirection counters at the end of Fkill_buffer.
3803 * buffer.c (Fkill_buffer): Adjust indirection counters when the
3804 buffer is definitely dead. This should really fix an issue reported
3805 by Christoph Scholtes again. (Bug#12007).
3806 (init_buffer_once): Initialize indirection counters of
3807 buffer_defaults and buffer_local_symbols (for sanity and safety).
3808
8a0484e1
EZ
38092012-07-24 Eli Zaretskii <eliz@gnu.org>
3810
3811 * xdisp.c (init_iterator): Don't compute dimensions of truncation
3812 and continuation glyphs on tooltip frames, leave them at zero.
3813 Avoids continued lines in tooltips. (Bug#11832)
3814
fa691a83
DA
38152012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
3816
3817 Simplify copy_overlay.
04e9897c 3818 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
3819 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
3820
436bc8e0
EZ
38212012-07-23 Eli Zaretskii <eliz@gnu.org>
3822
3823 * print.c (print_object): Don't crash when a frame's name is nil
3824 or invalid. (Bug#12025)
3825
3826 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
3827 it signals an error when a tooltip frame is being created.
3828
d7a7fda3
DA
38292012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
3830
3831 Cleanup miscellaneous objects allocation and initialization.
3832 * alloc.c (allocate_misc): Change to static. Add argument to
3833 specify the subtype. Adjust comment and users.
3834 (build_overlay): New function.
3835 * buffer.c (copy_overlays, Fmake_overlay): Use it.
3836 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
3837 (allocate_misc): Remove prototype.
3838 (build_overlay): Add prototype.
3839
38402012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
3841
3842 Swap buffer text indirection counters in Fbuffer_swap_text.
3843 * buffer.c (Fbuffer_swap_text): Swap indirections too.
3844 This avoids crash reported by Christoph Scholtes at
3845 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
3846
9d7fa573
JD
38472012-07-22 Jan Djärv <jan.h.d@swipnet.se>
3848
3849 * nsmenu.m (Popdown_data): New struct.
3850 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
3851 free Popdown_data.
3852 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
3853 (initWithContentRect): Make imgView and contentView non-static
3854 and autorelease them. Also autorelease img and matrix (Bug#12005).
3855 (dealloc): Remove (Bug#12005).
3856
0dd6d66d
DA
38572012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3858
3859 Adjust consing_since_gc when objects are explicitly freed.
3860 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
3861 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
3862 (free_cons, free_misc): Subtract object size from consing_since_gc.
3863
d36d71df
DA
38642012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3865
3866 Simplify and cleanup markers positioning code.
3867 * marker.c (attach_marker): More useful eassert.
3868 (live_buffer, set_marker_internal): New function.
3869 (Fset_marker, set_marker_restricted): Use set_marker_internal.
3870 (set_marker_both, set_marker_restricted_both): Use live_buffer.
3871
fb9ea40f
PE
38722012-07-22 Paul Eggert <eggert@cs.ucla.edu>
3873
3874 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
3875 as it's limited by the amount of memory, not by INT_MAX.
3876
2d5c5f7d
EZ
38772012-07-21 Eli Zaretskii <eliz@gnu.org>
3878
07fb592e
EZ
3879 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
3880 in special-event-map. See the discussion at
3881 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
3882 for the reasons.
3883
37a9eac8 3884 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
3885 info.dwItemData. Fixes crashes on 64-bit Windows.
3886 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 3887
c4328746
JD
38882012-07-21 Jan Djärv <jan.h.d@swipnet.se>
3889
fc0c31f8 3890 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 3891 (conversationIdentifier): Return value is NSInteger.
784051c4 3892 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 3893
6e5d1c12
CY
38942012-07-21 Chong Yidong <cyd@gnu.org>
3895
3896 * window.c (decode_any_window): Signal an error if the window is
3897 on a dead frame (Bug#11984).
3898
9928463d
DA
38992012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3900
3901 Add indirection counting to speed up Fkill_buffer.
3902 * buffer.h (struct buffer): New member.
3903 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
3904 (Fmake_indirect_buffer): Set indirection counter to -1, increment
3905 base buffer indirection counter.
3906 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
3907 (Fkill_buffer): Adjust indirection counters as needed, don't walk
3908 through buffer list if indirection counter is 0.
3909
f8643a6b
DA
39102012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3911
3912 Extend the value returned by Fgarbage_collect with heap statistics.
3913 * alloc.c (Qheap): New symbol.
3914 (syms_of_alloc): DEFSYM it.
3915 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
3916 (Fmemory_free): Remove.
3917 (syms_of_alloc): Don't defsubr it.
3918 * buffer.c (Fcompact_buffer): Remove.
3919 (syms_of_buffer): Don't defsubr it.
3920
dac616ff
DA
39212012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3922
3923 Make maybe_gc inline.
3924 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
3925 * lisp.h (consing_since_gc, gc_relative_threshold)
3926 (memory_full_cons_threshold): Revert declaration.
3927 (maybe_gc): Remove prototype, define as inline.
3928 * alloc.c: Remove old commented-out code.
3929 (consing_since_gc, gc_relative_threshold)
3930 (memory_full_cons_threshold): Revert to global.
3931 (maybe_gc): Remove.
3932
d7ea76b4
DA
39332012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3934
3935 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
3936 * lisp.h (build_unibyte_string): New function.
3937 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
3938 * sysdep.c, w32fns.c, xfns.c: Use it.
3939 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
3940 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
3941 Adjust users accordingly.
3942 * font.h (font_open_by_name): Adjust prototype.
3943
765e61e3
DA
39442012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3945
3946 Cleanup calls to Fgarbage_collect.
3947 * lisp.h (maybe_gc): New prototype.
3948 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3949 Remove declarations.
3950 * alloc.c (maybe_gc): New function.
3951 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3952 Make them static.
3953 * bytecode.c (MAYBE_GC): Use maybe_gc.
3954 * eval.c (eval_sub, Ffuncall): Likewise.
3955 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
3956 to avoid dependency from auto-save feature.
3957
52b852c7
PE
39582012-07-19 Paul Eggert <eggert@cs.ucla.edu>
3959
3960 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
3961 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
3962 'for_each_per_buffer_object_at'.
3963 All uses changed. It's better to use upper-case for macros that
3964 cannot be implemented as functions, to give the reader a clue
3965 that they're special.
3966
5db81e33
SM
39672012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
3968
3969 * alloc.c (Fgarbage_collect): Tweak docstring.
3970
5b835e1d
DA
39712012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3972
3973 Tweak the value returned from Fgarbage_collect again.
3974 * alloc.c (Fgarbage_collect): New return value, as confirmed in
3975 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
3976 Adjust documentation.
3977 (total_vector_bytes): Rename to total_vector_slots, adjust
3978 accounting.
3979 (total_free_vector_bytes): Rename to total_free_vector_slots,
3980 adjust accounting.
3981 (Qstring_bytes, Qvector_slots): New symbols.
3982 (syms_of_alloc): DEFSYM them.
3983
9cd47b72
DA
39842012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3985
3986 Buffer compaction primitive which may be used from Lisp.
3987 * buffer.c (compact_buffer, Fcompact_buffer): New function.
3988 (syms_of_buffer): Register Fcompact_buffer.
3989 * alloc.c (Fgarbage_collect): Use compact_buffer.
3990 * buffer.h (compact_buffer): New prototype.
3991 (struct buffer_text): New member.
3992
d17337e5
DA
39932012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3994
3995 New macro to iterate over all buffers, miscellaneous cleanups.
3996 * lisp.h (all_buffers): Remove declaration.
3997 * buffer.h (all_buffers): Add declaration, with comment.
3998 (for_each_buffer): New macro.
3999 * alloc.c (Fgarbage_collect, mark_object): Use it.
4000 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
4001 (init_buffer): Likewise.
4002 * data.c (Fset_default): Likewise.
4003 * coding.c (code_conversion_restore): Remove redundant check
4004 for dead buffer.
4005 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
4006
60cfd278
AS
40072012-07-18 Andreas Schwab <schwab@linux-m68k.org>
4008
4009 Fix bug that created negative-length intervals.
4010 * intervals.c (merge_interval_right, merge_interval_left):
4011 Do not zero out this interval if it is absorbed by its children,
4012 as this interval's total length doesn't change in that case. See
4013 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
4014
d06714cb
PE
40152012-07-18 Paul Eggert <eggert@cs.ucla.edu>
4016
83713154
PE
4017 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
4018 when invoking (make-bool-vector N t) and N is a positive
4019 multiple of 8 -- the last 8 bits were mistakenly cleared.
4020
d06714cb
PE
4021 Remove some struct layout assumptions in bool vectors.
4022 * alloc.c (bool_header_size): New constant.
4023 (header_size, word_size): Move earlier, as they're now used earlier.
4024 Use 'word_size' in a few more places, where it's appropriate.
4025 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
4026 padding before the data member of a bool vector.
4027 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
4028 than doing the check by hand with an abort ().
4029
464d5a5e
SM
40302012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4031
5fbc0409
SM
4032 * eval.c (Fdefvar): Don't check constants since we only set the var if
4033 it's not yet defined anyway (bug#11904).
4034
464d5a5e
SM
4035 * lisp.h (last_undo_boundary): Declare new var.
4036 * keyboard.c (command_loop_1): Set it.
4037 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
4038 were auto-added by the command loop (bug#11774).
4039
8dc2e44a
AS
40402012-07-18 Andreas Schwab <schwab@linux-m68k.org>
4041
4042 * w32font.c (Qsymbol): Remove local definition.
4043 (syms_of_w32font): Don't DEFSYM it.
4044
169925ec
DA
40452012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4046
4047 Fix sweep_vectors to handle large bool vectors correctly.
4048 * alloc.c (sweep_vectors): Account total_vector_bytes for
4049 bool vectors larger than VBLOCK_BYTES_MAX.
4050
5fbfb018
CY
40512012-07-18 Chong Yidong <cyd@gnu.org>
4052
4053 * frame.c (x_set_frame_parameters): Revert bogus change introduced
4054 in 2012-05-25 commit by Paul Eggert (Bug#11738).
4055
3ab6e069
DA
40562012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4057
4058 Return more descriptive data from Fgarbage_collect.
4059 Suggested by Stefan Monnier in
4060 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
4061 * alloc.c (bounded_number): New function.
4062 (total_buffers, total_vectors): New variable.
4063 (total_string_size): Rename to total_string_bytes, adjust users.
4064 (total_vector_size): Rename to total_vector_bytes, adjust users.
4065 (sweep_vectors): Account total_vectors and total_vector_bytes.
4066 (Fgarbage_collect): New return value. Adjust documentation.
4067 (gc_sweep): Account total_buffers.
4068 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
4069 (VECTOR_SIZE): Remove.
4070 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
4071 (Qinterval, Qmisc): New symbols.
4072 (syms_of_data): Initialize them.
4073 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
4074 (Qcons, Qbuffer): New declarations.
4075
6d02fe5b
PE
40762012-07-17 Paul Eggert <eggert@cs.ucla.edu>
4077
4078 * alloc.c (Fmemory_free): Account for memory-free's own storage.
4079 Round up, not down. Improve doc.
4080
b7ffe040
DA
40812012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4082
4083 Restore old code in allocate_string_data to avoid Faset breakage.
4084 Reported by Julien Danjou <julien@danjou.info> in
4085 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
4086 * alloc.c (allocate_string_data): Restore old code with minor
4087 adjustments, fix comment to explain this subtle issue.
4088
4dc7c8d5
SM
40892012-07-17 Eli Zaretskii <eliz@gnu.org>
4090
4091 Remove FILE_SYSTEM_CASE.
4092 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
4093
4094 * fileio.c (FILE_SYSTEM_CASE): Don't define.
4095 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
4096 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
4097 call-process-region passes it through expand-file-name.
4098
4099 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
4100
41012012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4102
4103 Fix crash when creating indirect buffer (Bug#11917)
4104 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
4105 Don't handle unbound variables specially if non-zero.
4106 (Fbuffer_local_variables): Pass zero.
4107 (clone_per_buffer_values): Pass non-zero.
4108
41092012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4110
4111 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
4112 to make the loop interruptible.
4113
41142012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4115
4116 * gnutls.c (emacs_gnutls_handshake): Only retry if
4117 GNUTLS_E_INTERRUPTED.
4118
cce7fefc
DA
41192012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4120
4121 Cleanup and convert miscellaneous checks to eassert.
4122 * alloc.c (mark_interval): Fix comment, partially rephrase
4123 old comment from intervals.h (see below).
4124 * intervals.c (find_interval, adjust_intervals_for_insertion)
4125 (delete_interval, adjust_intervals_for_deletion)
4126 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
4127 Convert to eassert.
4128 (adjust_intervals_for_insertion, make_new_interval):
4129 Remove obsolete and unused code.
4130 * intervals.h (struct interval): Remove obsolete comment.
4131 * textprotp.c (erase_properties): Remove unused code.
4132 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
4133 (Fremove_list_of_text_properties): Convert to eassert.
4134
9ea10cc3
CY
41352012-07-17 Chong Yidong <cyd@gnu.org>
4136
4137 * editfns.c (Finsert_char): Doc fix.
4138
3900d5de
DA
41392012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4140
4141 Fix previous change to make Fmemory_free always accurate.
4142 * alloc.c (make_interval): Update total_free_intervals.
4143 (make_float): Likewise for total_free_floats.
4144 (free_cons, Fcons): Likewise for total_free_conses.
4145 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
4146 Likewise for total_free_vector_bytes.
4147 (Fmake_symbol): Likewise for total_free_symbols.
4148 (bytes_free): Remove.
4149
7098646f
DA
41502012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4151
4152 Simple free memory accounting feature.
4153 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
4154 (sweep_vectors): Accumulate size of free vectors.
4155 (Fgarbage_collect): Setup bytes_free.
4156 (Fmemory_free): New function.
4157 (syms_of_alloc): Register it.
4158
22657b40
DA
41592012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4160
4161 Cleanup overlays checking.
4162 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
4163 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
4164 eassert and OVERLAYP.
4165 (sort_overlays): Change to use OVERLAYP.
4166
ddfc8813
RK
41672012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
4168
4169 * editfns.c (Finsert_char): Make it interactive, and make the
4170 second arg optional. Copy interactive spec and docstring from
4171 ucs-insert.
4172
7c26cf3c
PE
41732012-07-17 Paul Eggert <eggert@cs.ucla.edu>
4174
4175 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
4176 Unlike the other wrapped functions, fabs has an unspecified
4177 effect on errno.
4178
5d127af9
JD
41792012-07-16 Jan Djärv <jan.h.d@swipnet.se>
4180
4181 * nsterm.m (keyDown): Interpret flags without left/right bits
4182 as the left key (Bug#11670).
4183
6a0dd1d7
DA
41842012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
4185
4186 Remove empty and useless init functions.
4187 * lisp.h (init_character_once, init_fns, init_image)
4188 (init_filelock, init_sound): Remove prototype.
4189 * character.c (init_character_once): Remove.
4190 * filelock.c (init_filelock): Likewise.
4191 * fns.c (init_fns): Likewise.
4192 * image.c (init_image): Likewise.
4193 * sound.c (init_sound): Likewise.
4194 * emacs.c (main): Adjust accordingly.
4195
7a6136fd
DA
41962012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
4197
4198 * gtkutil.h: Tiny cleanups.
4199 (use_old_gtk_file_dialog): Remove useless declaration.
4200 (xg_uses_old_file_dialog): Add suggested const attribute.
4201
ce811ad9
EZ
42022012-07-15 Eli Zaretskii <eliz@gnu.org>
4203
4204 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
4205 (bidi_paragraph_init): Use it to limit search forward for a strong
4206 directional character in abnormally large paragraphs full of
4207 neutral or weak characters. (Bug#11943)
4208
c9adfeaa
SF
42092012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
4210
4211 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
4212 the toolbar (Bug#9451).
4213 (xg_make_tool_item): Give the widget event box a transparent
4214 background.
4215
fff62aa9
DA
42162012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
4217
4218 Cleanup basic allocation variables and functions.
4219 * alloc.c (ignore_warnings, init_intervals, init_float)
4220 (init_cons, init_symbol, init_marker): Remove.
4221 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
4222 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
4223 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
4224 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
4225 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
4226 (staticidx, init_alloc_once, init_strings, free_ablock):
4227 Remove redundant initialization.
4228 * fns.c (init_weak_hash_tables): Remove.
4229 * lisp.h (init_weak_hash_tables): Remove prototype.
4230
9730daca
DA
42312012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
4232
4233 Use zero_vector where appropriate.
4234 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
4235 accordingly.
4236 * lisp.h (zero_vector): New declaration.
4237 * font.c (null_vector): Remove.
4238 (syms_of_font): Remove initialization and staticpro.
4239 (font_list_entities, font_find_for_lface): Change to use zero_vector.
4240 * keymap.c (Faccessible_keymaps): Likewise.
4241
2e2d2a13
LL
42422012-07-15 Leo Liu <sdl.web@gmail.com>
4243
4244 * fringe.c: Fix typo in comments.
4245
cd276f6e
LL
42462012-07-14 Leo Liu <sdl.web@gmail.com>
4247
4248 * fringe.c: Add a new bitmap exclamation-mark.
4249
5a1131d9
EZ
42502012-07-14 Eli Zaretskii <eliz@gnu.org>
4251
4252 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
4253
4254 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
4255 (HAVE_MENUS): Don't define, defined by editing config.in with
4256 msdos/sed2v2.inp.
4257 (GMALLOC_INHIBIT_VALLOC): Don't define.
4258 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
4259
22e983b7
JB
42602012-07-14 Juanma Barranquero <lekktu@gmail.com>
4261
4262 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
4263
5b3f250f
GM
42642012-07-14 Glenn Morris <rgm@gnu.org>
4265
4266 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
4267 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
4268 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
4269
33d63ff4
GM
42702012-07-13 Glenn Morris <rgm@gnu.org>
4271
5b633342
GM
4272 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
4273
33d63ff4
GM
4274 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
4275 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
4276
b55b9f85
JD
42772012-07-13 Jan Djärv <jan.h.d@swipnet.se>
4278
0dc8cf50
JD
4279 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
4280 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
4281 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
4282 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
4283 where appropriate.
4284 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
4285 as boolean expression.
4286 (x_set_window_size): Remove unused variable toolbar.
4287 (ns_get_color_default, ns_mod_to_lisp): Remove.
4288 (ns_mouse_position): Remove unused variables xchar and ychar.
4289 (ns_compute_glyph_string_overhangs): Remove unused variable face.
4290 (ns_set_vertical_scroll_bar): Remove unused variable count.
4291 (ns_delete_terminal): Remove unused variable i.
4292 (ns_term_init): Remove unused variables r, g and b.
4293 (mouseDown): Remove unused variable window.
4294 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
4295 (initFrameFromEmacs): Remove unused variable vbextra.
4296 (mouseEntered): Remove unused variables p and dpyinfo.
4297 (mouseExited): Remove unused variables p and r.
4298 (ns_define_frame_cursor, ns_clear_frame_area)
4299 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
4300 (menuDown): Assign [sender tag] to variable and cast the variable.
4301
4302 * nsterm.h (menuDown): Add id as type to argument sender.
4303 (ns_display_info_for_name): Add Lisp_Object argument.
4304 (ns_term_init): Add Lisp_Object argument.
4305 (ns_map_event_to_object): Add void argument.
4306 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
4307 prototype with arguments and only declare if __OBJC__.
4308 (nxatoms_of_nsselect): Add void argument.
4309 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
4310 (ns_alloc_autorelease_pool): Add void argument.
4311 (ns_release_autorelease_pool): Add void* argument.
4312 (ns_get_defaults_value): Add const char* argument.
4313
4314 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
4315 (initFromContents): Use SSDATA where appropriate.
4316 (ns_update_menubar): Add braces to ambigous if-else.
4317 (initWithTitle): Put () around assignment in if statement.
4318 (ns_menu_show): Remove unused variables window and keymap.
4319 (update_frame_tool_bar): Remove unused variable selected_p.
4320 (initWithContentRect): Remove unused variable this_cmd_name.
4321
4322 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
4323 appropriate.
4324 (setXBMColor): Remove unused variable len.
4325 (setPixmapData): Put () around assignment in loop statement.
4326
4327 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
4328 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
4329 where appropriate.
4330 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
4331 around assignment in loop statement.
4332 (nsfont_open): Remove unused variable i.
4333 (nsfont_open): Remove unused variable len.
4334 (nsfont_draw): Remove unused variable cs.
4335
4336 * nsfns.m (x_set_icon_name, ns_set_name_internal)
4337 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
4338 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
4339 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
4340 (Fns_font_name, Fns_perform_service)
4341 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
4342 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
4343 (ns_set_name): Remove unused variable view.
4344 (x_set_menu_bar_lines): Remove unused variable olines.
4345 (x_set_tool_bar_lines): Remove unused variable root_window.
4346 (Fns_list_colors): Put () around assignment in while statement.
4347 (Fns_perform_service): Remove unused variable len.
4348 (Fns_display_usable_bounds): Remove unused variable top.
4349 (syms_of_nsfns): Remove unused variable i.
4350
b55b9f85
JD
4351 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
4352 memcpy (Bug#11907).
4353
ed9265fc 43542012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
4355
4356 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
4357 and free it with DestroyExceptionInfo (Bug#11558).
4358
ef099b57
JB
43592012-07-13 Juanma Barranquero <lekktu@gmail.com>
4360
4361 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
4362 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
4363 Set here, not in nt/config.nt.
4364
ea814a5d
EZ
43652012-07-13 Eli Zaretskii <eliz@gnu.org>
4366
4367 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
4368 cursor overflow into the last glyph on display line when the right
4369 fringe is off. (Bug#11832)
4370
1a952767
PE
43712012-07-13 Paul Eggert <eggert@cs.ucla.edu>
4372
4373 * xdisp.c (produce_special_glyphs): Now static.
4374 * dispextern.h (produce_special_glyphs): Remove decl.
4375
983188fd
GM
43762012-07-13 Glenn Morris <rgm@gnu.org>
4377
8d7c7eed 4378 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
4379 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
4380
983188fd
GM
4381 * s/usg5-4-common.h (USG, USG5):
4382 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
4383 * s/sol2-6.h (SOLARIS2):
4384 * s/irix6-5.h (IRIX6_5):
4385 * s/hpux10-20.h (USG, USG5, HPUX):
4386 * s/gnu-linux.h (USG, GNU_LINUX):
4387 * s/freebsd.h (BSD_SYSTEM):
4388 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
4389 * s/cygwin.h (CYGWIN):
4390 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
4391 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
4392
d1e68667 43932012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
4394
4395 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 4396
6de0e799
GM
43972012-07-13 Glenn Morris <rgm@gnu.org>
4398
739ae010
GM
4399 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
4400
dbee5793
GM
4401 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
4402
6de0e799
GM
4403 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
4404 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
4405
b82da769
GM
44062012-07-12 Glenn Morris <rgm@gnu.org>
4407
4fae5a7a 4408 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
4409
4410 * process.c (init_process_emacs): Rename from init_process.
4411 The old name is also the name of a Mach system call.
4412 * lisp.h, emacs.c: Update for this name change.
4413 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
4414 longer needed.
4415
5a979817
EZ
44162012-07-12 Eli Zaretskii <eliz@gnu.org>
4417
4418 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
4419 memmove call that removes glyphs covered by the left truncation
4420 glyph. Improve commentary.
4421 (display_line): Fix display of continuation glyphs on GUI frames
4422 when the right fringe is turned off and variable-size fonts are
4423 used in the window. Move the code that appends a stretch glyph to
4424 produce_special_glyphs, so that it could be used for truncation
4425 and continuation glyphs alike.
4426 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
4427 glyph of a suitably computed width, to align the special glyphs at
4428 the window margin. Code moved from display_line. (Bug#11832)
4429
3e91a053
GM
44302012-07-12 Glenn Morris <rgm@gnu.org>
4431
ba9e4b84
GM
4432 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
4433
4434 * s/gnu-linux.h, s/hpux10-20.h:
4435 Do not unconditionally define HAVE_XRMSETDATABASE.
4436
3e91a053
GM
4437 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
4438
b300b1f4
PE
44392012-07-12 Paul Eggert <eggert@cs.ucla.edu>
4440
4441 Fix typos that broke OS X build.
4442 Reported by Randal L. Schwartz in
4443 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
4444 * nsterm.m (ns_timeout): Add missing local decl.
4445 (ns_get_color): snprintf -> sprintf, to fix typo.
4446
6e777848
GM
44472012-07-12 Glenn Morris <rgm@gnu.org>
4448
3f922c37
GM
4449 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
4450 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
4451 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
4452 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
4453
0ab7b23a
GM
4454 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
4455 Move PTY_OPEN to configure.
4456
6e777848
GM
4457 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4458 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
4459 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
4460
4a7edc24
DA
44612012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
4462
4463 Use empty_unibyte_string where applicable.
4464 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
4465 * lread.c (read1): Likewise.
4466 * xsettings.c (syms_of_xsettings): Likewise.
4467
308aab79
GM
44682012-07-12 Glenn Morris <rgm@gnu.org>
4469
42bd1719
GM
4470 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
4471 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
4472 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
4473 * s/hpux10-20.h (RUN_TIME_REMAP):
4474 * s/bsd-common.h (TABDLY): Move to configure.
4475
4476 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
4477
4478 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
4479
ea0bbd17 4480 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 4481 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
4482
4483 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 4484
308aab79
GM
4485 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
4486 * s/template.h: Move NARROWPROTO to configure.
4487
ee1cf5cf
GM
44882012-07-11 Glenn Morris <rgm@gnu.org>
4489
30fe9bf4
GM
4490 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
4491 unused since 2011-01-17 change to systty.h.
4492
ee1cf5cf
GM
4493 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
4494 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
4495 Move HAVE_PTYS and HAVE_SOCKETS to configure.
4496
63e47e07
PE
44972012-07-11 Paul Eggert <eggert@cs.ucla.edu>
4498
4499 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
4500
c43fb4c3
GM
45012012-07-11 Glenn Morris <rgm@gnu.org>
4502
4503 * s/darwin.h, s/gnu-linux.h, s/template.h:
4504 Move INTERRUPT_INPUT to configure.
4505
e8df9267
DA
45062012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4507
4508 Minor adjustments to interning code.
4509 * lisp.h (intern, intern_c_string): Redefine as static inline
4510 wrappers for intern_1 and intern_c_string_1, respectively.
4511 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
4512 * lread.c (intern_1, intern_c_string_1, oblookup):
4513 Simplify Vobarray checking.
e8df9267
DA
4514 * font.c (font_intern_prop): Likewise. Adjust comment.
4515 * w32font.c (intern_font_name): Likewise.
4516
34348bd4
AS
45172012-07-11 Andreas Schwab <schwab@linux-m68k.org>
4518
d96a1e0c
AS
4519 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
4520
34348bd4
AS
4521 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
4522 of Fcar/Fcdr if possible.
4523 * font.c (check_otf_features): Likewise.
4524 * fontset.c (Fnew_fontset): Likewise.
4525 * gnutls.c (Fgnutls_boot): Likewise.
4526 * minibuf.c (read_minibuf): Likewise.
4527 * msdos.c (IT_set_frame_parameters): Likewise.
4528 * xmenu.c (Fx_popup_dialog): Likewise.
4529 * w32menu.c (Fx_popup_dialog): Likewise.
4530
c8add24e
GM
45312012-07-11 Glenn Morris <rgm@gnu.org>
4532
4b575b3c
GM
4533 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
4534 since nothing has defined it on these platforms.
4535
09f4e3b0
GM
4536 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
4537 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
4538
172bedef
GM
4539 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4540 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
4541 Move CLASH_DETECTION to configure.
4542
249685df
GM
4543 * s/gnu.h: Remove file, which is now empty.
4544
c8add24e
GM
4545 * s/gnu.h, s/gnu-linux.h:
4546 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
4547
b41253a3
JW
45482012-07-11 John Wiegley <johnw@newartisans.com>
4549
4550 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
4551 function attribute, so we only use it if it exists in the
4552 compiler.
4553
d923b542
DA
45542012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4555
4556 Avoid call to strlen in fast_c_string_match_ignore_case.
4557 * search.c (fast_c_string_match_ignore_case): Change to use
4558 length argument. Adjust users accordingly.
4559 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
4560
5ebbef1d
PE
45612012-07-11 Paul Eggert <eggert@cs.ucla.edu>
4562
bb352260
PE
4563 Assume mkdir, rmdir.
4564 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
4565 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
4566
57054ddd
PE
4567 Assume rename.
4568 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
4569
b747d3f7
PE
4570 Assume perror.
4571 * s/hpux10-20.h (HAVE_PERROR): Remove.
4572 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
4573 Remove dummy definition, as this problem was obsolete long ago.
4574
5ebbef1d
PE
4575 Assume strerror.
4576 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
4577
984e7f30
DA
45782012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4579
4580 Avoid calls to strlen in font processing functions.
4581 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
4582 (font_open_by_name): Change to use length argument.
4583 Adjust users accordingly.
d923b542
DA
4584 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
4585 Adjust prototypes.
4586 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
4587 Change to return ptrdiff_t.
984e7f30
DA
4588 (xfont_list_pattern, xfont_match): Use length returned by
4589 xfont_decode_coding_xlfd.
4590 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
4591
20e94fdd
GM
45922012-07-11 Glenn Morris <rgm@gnu.org>
4593
9d596af3
GM
4594 * s/darwin.h, s/freebsd.h, s/netbsd.h:
4595 Move DONT_REOPEN_PTY to configure.
4596
20e94fdd
GM
4597 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
4598 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
4599
e99a530f
PE
46002012-07-10 Paul Eggert <eggert@cs.ucla.edu>
4601
22ffb973
PE
4602 Remove "#define unix" that is no longer needed (Bug#11905).
4603 * s/aix4-2.h (unix): Remove; no longer needed.
4604
e9a9ae03
PE
4605 EMACS_TIME simplification (Bug#11875).
4606 This replaces macros (which typically do not work in GDB)
4607 with functions, typedefs and enums, making the code easier to debug.
4608 The functional style also makes code easier to read and maintain.
4609 * systime.h: Include <sys/time.h> on all hosts, not just if
4610 WINDOWSNT, since 'struct timeval' is needed in general.
4611 (EMACS_TIME): Now a typedef, not a macro.
4612 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
4613 not macros.
4614 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
4615 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
4616 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
4617 (EMACS_TIME_LE): Now functions, not macros.
4618 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
4619 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
4620 which are not functions. All uses rewritten to use:
4621 (make_emacs_time): New function.
4622 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
4623 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
4624 not functions. All uses rewritten to use the following, respectively:
4625 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
4626 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 4627 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
4628 * fileio.c (Fcopy_file):
4629 * xterm.c (XTflash): Get the current time closer to when it's used.
4630 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
4631
ffacb126
PE
4632 * bytecode.c (targets): Suppress -Woverride-init warnings.
4633
e99a530f
PE
4634 Simplify by avoiding confusing use of strncpy etc.
4635 * doc.c (Fsnarf_documentation):
4636 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
4637 * frame.c (Fmake_terminal_frame):
4638 * gtkutil.c (get_utf8_string):
4639 * lread.c (openp):
4640 * nsmenu.m (ns_update_menubar):
4641 * regex.c (regerror):
4642 Prefer memcpy to strncpy and strncat when either will do.
4643 * fileio.c (Fsubstitute_in_file_name):
4644 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
4645 (menu_separator_name_p):
4646 * nsmenu.m (ns_update_menubar):
4647 Prefer memcmp to strncmp when either will do.
4648 * nsterm.m: Include <ftoastr.h>.
4649 (ns_get_color):
4650 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
4651 Prefer snprintf to strncpy.
4652 * nsterm.m (ns_term_init):
4653 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
4654 * nsterm.m (ns_term_init):
4655 Avoid the need for strncpy, by using build_string or
4656 make_unibyte_string directly. Use dtoastr, not snprintf.
4657 * process.c (Fmake_network_process): Diagnose service names that
4658 are too long, rather than silently truncating them or creating
4659 non-null-terminated names.
4660 (Fnetwork_interface_info): Likewise, for interface names.
4661 * sysdep.c (system_process_attributes) [GNU_LINUX]:
4662 Prefer sprintf to strncat.
4663 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
4664 Prefer vsnprintf to vsprintf + strncpy.
4665
c59592b3
GM
46662012-07-10 Glenn Morris <rgm@gnu.org>
4667
4668 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
4669 Clarify fallback case.
4670
7d7bbefd
DA
46712012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4672
4673 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
4674 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
4675 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 4676 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
4677 where argument type is known to be a Lisp_Cons.
4678
3a4c8000
TT
46792012-07-10 Tom Tromey <tromey@redhat.com>
4680
4681 * bytecode.c (BYTE_CODE_THREADED): New macro.
4682 (BYTE_CODES): New macro. Replaces all old byte-code defines.
4683 (enum byte_code_op): New type.
4684 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
4685 (exec_byte_code): Use them. Use token threading when applicable.
4686
2a0213a6
DA
46872012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4688
4689 Optimize pure C strings initialization.
4690 * lisp.h (make_pure_string): Fix prototype.
4691 (build_pure_c_string): New function, defined as static inline. This
4692 provides a better opportunity to optimize away calls to strlen when
4693 the function is called with compile-time constant argument.
4694 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
4695 argument, adjust users accordingly. Use build_pure_c_string where
4696 appropriate.
4697 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
4698 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
4699 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
4700
cb1caeaf
DA
47012012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4702
4703 Avoid calls to strlen in miscellaneous functions.
4704 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
4705 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
4706 * lread.c (openp): Likewise.
4707
c293e30c
DA
47082012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4709
4710 Avoid calls to strlen in path processing functions.
4711 * fileio.c (file_name_as_directory): Add comment. Change to add
4712 srclen argument and return the length of result. Adjust users
4713 accordingly.
4714 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
4715 swap 1st and 2nd arguments to obey the common convention.
4716 Adjust users accordingly.
c293e30c
DA
4717 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
4718
9e059e3f
GM
47192012-07-10 Glenn Morris <rgm@gnu.org>
4720
d02eb359
GM
4721 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
4722 Move PENDING_OUTPUT_COUNT definition to configure.
4723
882cf227
GM
4724 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
4725 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
4726 * s/gnu.h (DATA_START): Move definitions to configure.
4727
af6e839f
GM
4728 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
4729 We include usg5-4-common.h, which defines them both.
4730
40289a12
GM
4731 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
4732 O_RDONLY already includes it).
4733
9e059e3f
GM
4734 Stop ns builds setting the EMACSLOADPATH environment variable.
4735 * nsterm.m (ns_load_path): Rename from ns_init_paths.
4736 Now it does not set EMACSLOADPATH, just returns the load-path string.
4737 * nsterm.h: Update accordingly.
4738 * lread.c [HAVE_NS]: Include nsterm.h.
4739 (init_lread) [HAVE_NS]: Use ns_load_path.
4740 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
4741
7c4e8ec0
GM
47422012-07-09 Glenn Morris <rgm@gnu.org>
4743
d4f600ff
GM
4744 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
4745 since the included bsd-common.h does so.
4746
cbb31951
GM
4747 Stop ns builds setting the EMACSPATH environment variable.
4748 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
4749 (ns_init_paths): Do not set EMACSPATH.
4750 * nsterm.h (ns_exec_path): Add it.
4751 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
4752 Use ns_exec_path.
4753
7c4e8ec0
GM
4754 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
4755
26bccfae
PE
47562012-07-09 Paul Eggert <eggert@cs.ucla.edu>
4757
a0bee46f
PE
4758 * process.c (wait_reading_process_output): 'waitchannels' was unset
4759 when read_kbd || !NILP (wait_for_cell); fix this.
4760
5994c183
PE
4761 Add GCC-style 'const' attribute to functions that can use it.
4762 * character.h (char_resolve_modifier_mask):
4763 * keyboard.h (make_ctrl_char):
4764 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
4765 (init_character_once, next_almost_prime, init_fns, init_image)
4766 (flush_pending_output, init_sound):
4767 * mem-limits.h (start_of_data):
4768 * menu.h (finish_menu_items):
4769 Add ATTRIBUTE_CONST.
4770 * emacs.c (DEFINE_DUMMY_FUNCTION):
4771 Declare the dummy function with ATTRIBUTE_CONST.
4772 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
4773 Add decls with ATTRIBUTE_CONST.
4774
26bccfae
PE
4775 Minor improvements to make_formatted_string.
4776 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
4777 where int is good enough, as vsprintf returns an int.
4778 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
4779
a8290ec3
DA
47802012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
4781
4782 Use make_formatted_string to avoid double length calculation.
4783 * lisp.h (make_formatted_string): New prototype.
4784 * alloc.c (make_formatted_string): New function.
4785 * buffer.c (Fgenerate_new_buffer_name): Use it.
4786 * dbus.c (syms_of_dbusbind): Likewise.
4787 * editfns.c (Fcurrent_time_zone): Likewise.
4788 * filelock.c (get_boot_time): Likewise.
4789 * frame.c (make_terminal_frame, set_term_frame_name)
4790 (x_report_frame_params): Likewise.
4791 * image.c (gs_load): Likewise.
4792 * minibuf.c (get_minibuffer): Likewise.
4793 * msdos.c (dos_set_window_size): Likewise.
4794 * process.c (make_process): Likewise.
4795 * xdisp.c (ensure_echo_area_buffers): Likewise.
4796 * xsettings.c (apply_xft_settings): Likewise.
4797
d01ba2f1
GM
47982012-07-09 Glenn Morris <rgm@gnu.org>
4799
4800 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
4801 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
4802 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
4803 * nsterm.h (ns_etc_directory): Add it.
4804 * callproc.c [HAVE_NS]: Include nsterm.h.
4805 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
4806
f1f924b6
DA
48072012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
4808
4809 Move marker debugging code under MARKER_DEBUG.
4810 * marker.c (MARKER_DEBUG): Move marker debugging code under
4811 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
4812 for bootstrap with --enable-checking (~3x slowdown reported
4813 by Juanma Barranquero <lekktu@gmail.com>).
4814 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
4815
ab531b66
PE
48162012-07-08 Paul Eggert <eggert@cs.ucla.edu>
4817
4818 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
4819 See <http://bugs.gnu.org/11825#29>.
4820
c4b3bc8a
EZ
48212012-07-08 Eli Zaretskii <eliz@gnu.org>
4822
4823 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
4824 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
4825 (display_line): Add commentary about displaying truncation glyphs
4826 on GUI frames.
4827 (produce_special_glyphs): Move here from term.c.
4828
4829 * term.c (produce_special_glyphs): Move to xdisp.c.
4830
4831 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
4832 section.
c4b3bc8a 4833
b676b881
AS
48342012-07-07 Andreas Schwab <schwab@linux-m68k.org>
4835
f17c5273
AS
4836 * xdisp.c (display_line): Avoid warning about implicit declaration
4837 of FRAME_FONT.
4838
298819b9
AS
4839 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
4840
b676b881
AS
4841 * lisp.h: Remove empty conditional.
4842
6045c4fd
PE
48432012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4844
b3350bf9
PE
4845 * lread.c (load_path_check): Now static.
4846
6045c4fd
PE
4847 Fix some minor --with-ns problems found by static checking.
4848 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
4849 (x_set_font) [!HAVE_X_WINDOWS]:
4850 * image.c (xpm_load_image) [HAVE_NS]:
4851 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
4852 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
4853 Remove unused local.
4854 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
4855 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
4856 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
4857 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
4858 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
4859 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
4860 Fix pointer signedness problem.
4861 * xfaces.c (FRAME_X_FONT_TABLE):
4862 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
4863
929e7845
GM
48642012-07-07 Glenn Morris <rgm@gnu.org>
4865
4866 * lread.c (load_path_check): New function, split from init_lread.
4867 (init_lread): Reorganize. Motivation:
4868 If EMACSLOADPATH is set, check/warn about that rather than the
4869 defaults, which we are not going to use. Hence we can remove
4870 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
4871 Don't warn if site-lisp directories are missing.
4872 If not installed, start from a blank load-path, since
4873 PATH_LOADSEARCH refers to the eventual installation directories.
4874
58dd0aa4
EZ
48752012-07-07 Eli Zaretskii <eliz@gnu.org>
4876
4877 Support truncation and continuation glyphs on GUI frames, when
4878 fringes are disabled. (Bug#11832)
4879 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
4880 continuation glyphs even if on GUI frames.
4881 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
4882 or both, are absent.
4883 (start_display, move_it_in_display_line_to): Handle the case of a
4884 GUI frame without a fringe to display continuation or truncation
4885 glyphs.
4886 (insert_left_trunc_glyphs): Support GUI frames: make sure
4887 truncation glyphs overwrite enough glyphs from the current line to
4888 have sufficient space in pixels.
4889 (display_line): Support truncation and continuation glyphs on GUI
4890 frames. If some spare pixels are left on the line after inserting
4891 the truncation glyphs, fill that space with a stretch glyph of a
4892 suitably computed width.
4893
4894 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
4895 produce_glyphs, to support GUI sessions.
4896
31571fd7
PE
48972012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4898
5a16b9bc
PE
4899 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
4900
f3047c75
PE
4901 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
4902
31571fd7
PE
4903 Do not require float-time's arg to fit in time_t (Bug#11825).
4904 This works better on hosts where time_t is unsigned, and where
4905 float-time is applied to the (negative) difference between two times.
4906 * editfns.c (decode_time_components): Last arg is now double *,
4907 not int *, and means to store all the result as a double, without
4908 worrying about whether the seconds part fits in time_t.
4909 All callers changed.
4910 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
4911 All callers changed.
4912 (Ffloat_time): Do not fail merely because the specified time falls
4913 outside of time_t range.
4914
4516fbef
GM
49152012-07-07 Glenn Morris <rgm@gnu.org>
4916
4917 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
4918 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
4919 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
4920
07adc2c6
JB
49212012-07-07 Juanma Barranquero <lekktu@gmail.com>
4922
4923 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
4924 Update dependencies.
4925
4926 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
4927
fd573f31
PE
49282012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4929
fee5959d
PE
4930 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
4931 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
4932 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
4933 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
4934 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
4935 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
4936
fd573f31
PE
4937 * xfont.c (compare_font_names): Redo to omit the need for casts.
4938
ddadbc0e
AS
49392012-07-06 Andreas Schwab <schwab@linux-m68k.org>
4940
fca8d6b6
AS
4941 * xfns.c (Fx_change_window_property): Doc fix.
4942 * w32fns.c (Fx_change_window_property): Doc fix.
4943
ddadbc0e
AS
4944 * w32fns.c (Fx_window_property): Accept the same arguments as the
4945 X Windows version. Doc fix.
4946 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
4947
ed9265fc 49482012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
4949 Eli Zaretskii <eliz@gnu.org>
4950
4951 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
4952 Windows-specific code from nt/config.nt moved here.
4953 Obsolete settings removed.
4954
216ee680
PE
49552012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4956
4957 * process.c: Avoid unnecessary calls to gettime.
4958 (wait_reading_process_output): Don't get the time of day
4959 when gobbling data immediately and not waiting, as there's no need
4960 for it in that case. This removes a FIXME.
4961
bdd091e4
JD
49622012-07-06 Jan Djärv <jan.h.d@swipnet.se>
4963
4964 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
4965 is defined (Bug#11768).
4966
9d44f8ce
DA
49672012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4968
4969 Fix marker debugging code.
4970 * marker.c (byte_char_debug_check): Do not perform the check
4971 if buffer is not multibyte.
090bd7cb
JB
4972 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4973 Call byte_char_debug_check with correct arguments.
9d44f8ce 4974
90fc4786
DA
49752012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4976
4977 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
4978 * marker.c (byte_char_debug_check, count_markers):
4979 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
4980 (byte_debug_flag): Remove.
4981 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4982 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
4983
7b7ae965
DA
49842012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4985
4e57b342
DA
4986 Avoid code repetition in marker-related functions.
4987 * marker.c (attach_marker): New function.
4988 (Fset_marker, set_marker_restricted, set_marker_both)
4989 (set_marker_restricted_both): Use it.
4990 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
4991 Consistently rename charno to charpos.
4992 (marker_position): Add eassert.
4993 (marker_byte_position): Convert to eassert.
4994
49952012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4996
4997 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 4998 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 4999 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 5000
657924ff
DA
50012012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5002
5003 Introduce fast path for the widely used marker operation.
5004 * alloc.c (build_marker): New function.
5005 * lisp.h (build_marker): New prototype.
5006 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
5007 * composite.c (autocmp_chars): Likewise.
5008 * editfns.c (buildmark): Remove.
5009 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
5010 (save_restriction_save): Use build_marker.
5011 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
5012 * window.c (save_window_save): Likewise.
5013
041a49a6
DA
50142012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5015
5016 Do not use Fdelete_overlay in delete_all_overlays
5017 to avoid redundant calls to unchain_overlay.
5018 * buffer.c (drop_overlay): New function.
5019 (delete_all_overlays, Fdelete_overlay): Use it.
5020 * minibuf.c (get_minibuffer): Fix comment.
5021
7dca65a4
PE
50222012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5023
5024 Port to OpenBSD 5.1 amd64.
5025 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
5026 This is needed for OpenBSD, and should be harmless on all BSD systems.
5027 Also, include <sys/sysctl.h>, as it should be available on all
5028 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
5029 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
5030 use p_pid member, not kp_proc.pid.
5031
8eb876e2
GM
50322012-07-06 Glenn Morris <rgm@gnu.org>
5033
5034 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
5035
38182d90
PE
50362012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5037
5038 More xmalloc and related cleanup.
5039 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
5040 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
5041 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
5042 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
5043 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
5044 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
5045 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
5046 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
5047 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
5048 * xterm.c:
5049 Omit needless casts involving void * pointers and allocation.
5050 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
5051 as the former is more robust if P's type is changed.
5052 Prefer xzalloc to xmalloc + memset 0.
5053 Simplify malloc-or-realloc to realloc.
5054 Don't worry about xmalloc returning a null pointer.
5055 Prefer xstrdup to xmalloc + strcpy.
5056 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
5057 growing it.
5058 * keyboard.c (apply_modifiers_uncached): Prefer local array to
5059 alloca of a constant.
5060
6dd5a677
EZ
50612012-07-05 Eli Zaretskii <eliz@gnu.org>
5062
5063 * xdisp.c (display_line): Fix horizontal pixel coordinates when
5064 hscroll is larger than the line width. Fixes long and futile
5065 looping inside extend_face_to_end_of_line (on a TTY) producing
5066 glyphs that are not needed and thrown away.
5067
6b312f0f
DA
50682012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
5069
5070 * marker.c (set_marker_restricted_both): Simplify by using
5071 clip_to_bounds.
5072
f520ef9b
PE
50732012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5074
5075 * editfns.c (region_limit): Simplify by using clip_to_bounds.
5076
383b7c95
JD
50772012-07-05 Jan Djärv <jan.h.d@swipnet.se>
5078
5079 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
5080 not defined (Bug#11768).
5081 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
5082 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
5083 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
5084 followed by gtk_box_set_homogeneous (Bug#11768).
5085 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
5086 (update_theme_scrollbar_width, xg_create_scroll_bar):
5087 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
5088 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
5089 (is_box_type): New function (Bug#11768).
5090 (xg_tool_item_stale_p): Call is_box_type.
5293d758 5091 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
5092 with default display (Bug#11768).
5093
d6e7bf45
EZ
50942012-07-05 Eli Zaretskii <eliz@gnu.org>
5095
5096 * xdisp.c (window_hscroll_limited): New function.
5097 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
5098 coordinates when window's hscroll is set to insanely large
5099 values. (Bug#11857)
5100
431391ec
JB
51012012-07-05 Juanma Barranquero <lekktu@gmail.com>
5102
5103 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
5104 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
5105
23f86fce
DA
51062012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
5107
5108 Cleanup xmalloc.
5109 * lisp.h (xzalloc): New prototype. Omit needless casts.
5110 * alloc.c (xzalloc): New function. Omit needless casts.
5111 * charset.c: Omit needless casts. Convert all calls to
5112 xmalloc with following memset to xzalloc.
5113 * dispnew.c: Likewise.
5114 * fringe.c: Likewise.
5115 * image.c: Likewise.
5116 * sound.c: Likewise.
5117 * term.c: Likewise.
5118 * w32fns.c: Likewise.
5119 * w32font.c: Likewise.
5120 * w32term.c: Likewise.
5121 * xfaces.c: Likewise.
5122 * xfns.c: Likewise.
5123 * xterm.c: Likewise.
5124 * atimer.c: Omit needless casts.
5125 * buffer.c: Likewise.
5126 * callproc.c: Likewise.
5127 * ccl.c: Likewise.
5128 * coding.c: Likewise.
5129 * composite.c: Likewise.
5130 * doc.c: Likewise.
5131 * doprnt.c: Likewise.
5132 * editfns.c: Likewise.
5133 * emacs.c: Likewise.
5134 * eval.c: Likewise.
5135 * filelock.c: Likewise.
5136 * fns.c: Likewise.
5137 * gtkutil.c: Likewise.
5138 * keyboard.c: Likewise.
5139 * lisp.h: Likewise.
5140 * lread.c: Likewise.
5141 * minibuf.c: Likewise.
5142 * msdos.c: Likewise.
5143 * print.c: Likewise.
5144 * process.c: Likewise.
5145 * region-cache.c: Likewise.
5146 * search.c: Likewise.
5147 * sysdep.c: Likewise.
5148 * termcap.c: Likewise.
5149 * terminal.c: Likewise.
5150 * tparam.c: Likewise.
5151 * w16select.c: Likewise.
5152 * w32.c: Likewise.
5153 * w32reg.c: Likewise.
5154 * w32select.c: Likewise.
5155 * w32uniscribe.c: Likewise.
5156 * widget.c: Likewise.
5157 * xdisp.c: Likewise.
5158 * xmenu.c: Likewise.
5159 * xrdb.c: Likewise.
5160 * xselect.c: Likewise.
5161
0497dc44
PE
51622012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5163
5164 * fileio.c (time_error_value): Check the right error number.
5165 Problem reported by Troels Nielsen in
5166 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
5167
356e7178
PE
51682012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5169
4e71fd89
PE
5170 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
5171 This should be fixed in a better way; see Eli Zaretskii in
5172 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
5173 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
5174
f0941253
PE
5175 * fileio.c (time_error_value): Rename from special_mtime.
5176 The old name's problems were noted by Eli Zaretskii in
5177 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
5178
065c9eb4
PE
5179 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
5180 This variable's comment says Emacs needs at least one GDB-visible
5181 symbol of type enum pvec_type, to work around GDB problems.
5182 The symbol's value doesn't matter.
5183
356e7178
PE
5184 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
5185 that causes compilation to fail on pre-C99 compilers.
5186
ed9265fc 51872012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
5188
5189 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
5190 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
5191
3884d954
DA
51922012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5193
d209e2fb 5194 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
5195 headers for buffer_defaults and buffer_local_symbols.
5196 Reported by Juanma Barranquero <lekktu@gmail.com>.
5197
ee28be33
SM
51982012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5199
5200 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
5201 * lisp.h (enum pvec_type): Use fewer bits.
5202 (PSEUDOVECTOR_SIZE_BITS): New constant.
5203 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
5204 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
5205 change in pvec_type.
5206 (PSEUDOVECTOR_TYPEP): New macro.
5207 (TYPED_PSEUDOVECTORP): Use it.
5208 * fns.c (internal_equal): Adapt code to extract pvectype.
5209 * emacs.c (gdb_pvec_type): Update type.
5210 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
5211 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
5212 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
5213 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
5214 (sweep_vectors): Use it. Use local var `total_bytes' instead of
5215 abusing vector->header.next.nbytes.
5216 (live_vector_p): Use PVEC_TYPE.
5217 (mark_object): Adapt code to extract pvectype. Use switch.
5218
c7f2cd7f
PE
52192012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5220
5221 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
5222 Tighten new eassert a bit.
5223
8ce70ed2
DA
52242012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5225
5226 Fix compilation with --enable-gcc-warnings and -O1
5227 optimization level.
5228 * doprnt.c (doprnt): Change type of tem to int, initialize
5229 to avoid compiler warning. Add eassert.
5230 * search.c (simple_search): Initialize match_byte to avoid
5231 compiler warning. Add eassert.
5232
dea7f1e5
PE
52332012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5234
24a212eb
PE
5235 Avoid weird behavior with large horizontal scrolls.
5236 Without this change, for example, large hscroll values would
5237 mess up Emacs's display on Fedora 15 x86, presumably due to
5238 overflows in int calculations in the display code.
5239 Also, if buffers had long lines, Emacs would freeze.
5240 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
5241 (set_window_hscroll): New function, containing the old guts of
5242 Fset_window_hscroll. Return the clipped value.
5243 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
5244 This avoids the need to check against PTRDIFF_MAX.
5245
dea7f1e5
PE
5246 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
5247
76046526
DA
52482012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5249
5250 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
5251
39adff0d
PE
52522012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5253
63807d47
PE
5254 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
5255 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
5256 since GCC 4.4.6 issues a bogus warning for them.
5257
39adff0d
PE
5258 Fix bugs in file timestamp newness comparisons.
5259 * fileio.c (Ffile_newer_than_file_p):
5260 * lread.c (Fload): Use full timestamp resolution of files,
5261 not just the 1-second resolution, so that files that are only
5262 slightly newer still count as newer.
5263 * fileio.c (Ffile_newer_than_file_p): Don't assume file
5264 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
5265
dbeed9a6
PE
52662012-07-03 Paul Eggert <eggert@cs.ucla.edu>
5267
5268 * fileio.c: Improve handling of file time marker. (Bug#11852)
5269 (special_mtime): New function.
5270 (Finsert_file_contents, Fverify_visited_file_modtime):
5271 Use it to set special mtime values consistently.
5272
636334d6
AS
52732012-07-03 Andreas Schwab <schwab@linux-m68k.org>
5274
5275 * fileio.c (Finsert_file_contents): Properly handle st_mtime
5276 marker for non-existing file. (Bug#11852)
5277
e2017fe2
GM
52782012-07-03 Glenn Morris <rgm@gnu.org>
5279
5280 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
5281 and did not make it into globals.h).
5282
404dbd37
TT
52832012-07-03 Tom Tromey <tromey@redhat.com>
5284
5285 * window.c (Fset_window_margins, Fset_window_fringes)
5286 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
5287 * textprop.c (Fprevious_property_change): No longer static.
5288 * syntax.c (Fsyntax_table_p): No longer static.
5289 * process.c (Fget_process, Fprocess_datagram_address): No longer
5290 static.
5291 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
5292 * keyboard.c (Fcommand_execute): No longer static.
5293 Remove EXFUN.
5294 * insdel.c (Fcombine_after_change_execute): No longer static.
5295 * image.c (Finit_image_library): No longer static.
5296 * fileio.c (Fmake_symbolic_link): No longer static.
5297 * eval.c (Ffetch_bytecode): No longer static.
5298 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
5299 * doc.c (Fdocumentation_property, Fsnarf_documentation):
5300 No longer static.
404dbd37
TT
5301 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
5302 static.
5303 * dired.c (Ffile_attributes): No longer static.
5304 * composite.c (Fcomposition_get_gstring): No longer static.
5305 * callproc.c (Fgetenv_internal): No longer static.
5306
5307 * ccl.h: Remove EXFUNs.
5308 * buffer.h: Remove EXFUNs.
5309 * dispextern.h: Remove EXFUNs.
5310 * intervals.h: Remove EXFUNs.
5311 * fontset.h: Remove EXFUN.
5312 * font.h: Remove EXFUNs.
5313 * dosfns.c (system_process_attributes): Remove EXFUN.
5314 * keymap.h: Remove EXFUNs.
5315 * lisp.h: Remove EXFUNs.
5316 * w32term.h: Remove EXFUNs.
5317 * window.h: Remove EXFUNs.
5318 * xsettings.h: Remove EXFUN.
5319 * xterm.h: Remove EXFUN.
5320
8e4fd1e1
GM
53212012-07-03 Glenn Morris <rgm@gnu.org>
5322
5323 * lisp.h (Frandom): Make it visible to C.
5324 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
5325 buffer for invisible buffers. (Bug#1229)
5326
ca95b3eb
DA
53272012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5328
5329 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
5330 values which aren't power of 2.
14ae4239
BT
5331 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
5332 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
5333 accordingly.
5334
7555c33f
SM
53352012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
5336
5337 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
5338
5339 * alloc.c (mark_object): Revert part of last patch to use `switch'.
5340
d12e8f5a
DA
53412012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5342
5343 * alloc.c (allocate_vector_block): Remove redundant
5344 calls to mallopt if DOUG_LEA_MALLOC is defined.
5345 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
5346 avoid calls to mallopt if zero_vector is returned.
5347
296094c3
DA
53482012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5349
5350 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
5351 is enabled, avoid dereferencing NULL current_sblock if
5352 running undumped.
5353
36429c89
DA
53542012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5355
5356 Cleanup basic buffer management.
5357 * buffer.h (struct buffer): Change layout to use generic vector
5358 marking code. Fix some comments. Change type of 'clip_changed'
5359 to bitfield. Remove unused #ifndef old.
5360 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
5361 (GET_OVERLAYS_AT): Fix indentation.
5362 (for_each_per_buffer_object_at): New macro.
5363 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
5364 (Fbuffer_local_variables): Use it.
5365 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
5366 * alloc.c (allocate_buffer): Adjust to match new layout of
5367 struct buffer. Fix comment.
5368 (mark_overlay): New function.
5369 (mark_buffer): Use it. Use mark_vectorlike to mark normal
5370 Lisp area of struct buffer.
5371 (mark_object): Use it. Adjust marking of misc objects
5372 and related comments.
5373
3b3e4cac
PE
53742012-07-02 Paul Eggert <eggert@cs.ucla.edu>
5375
5376 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
5377 wrapper that is not needed because the wrapped code is a no-op (zero
5378 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
5379 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
5380
cf5c0175
DA
53812012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
5382
5383 * alloc.c (mark_buffer): Simplify. Remove prototype.
5384 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 5385 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
5386 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
5387 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 5388
ca26824c
GM
53892012-06-30 Glenn Morris <rgm@gnu.org>
5390
2e4c5312
GM
5391 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
5392
ca26824c
GM
5393 * epaths.in (PATH_SITELOADSEARCH): New.
5394 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
5395 This is rather than relying on --enable-locallisppath elements
5396 having "site-lisp" in their names. (Bug#10208#25, 11658)
5397
0d23c240
EZ
53982012-06-30 Eli Zaretskii <eliz@gnu.org>
5399
c9240d7a
EZ
5400 * w32proc.c (sys_select): Accept and ignore one more argument.
5401
5402 * w32.c (emacs_gnutls_pull): Call select with one more argument.
5403
0d23c240 5404 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 5405 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
5406
5407 * sysdep.c: Don't include dos.h and dosfns.h.
5408
5409 * process.c (sys_select):
5410 * msdos.c (sys_select): Accept one more argument and ignore it.
5411
5412 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
5413 adapt data types and code to that.
5414
5415 * dosfns.c:
5416 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
5417 which clashes with the gnulib function of the same name.
5418
af5a5a98
AS
54192012-06-30 Andreas Schwab <schwab@linux-m68k.org>
5420
c5e4379c
AS
5421 * font.c (font_style_to_value, font_style_symbolic)
5422 (font_prop_validate_style): Add type checks for values in
5423 font_style_table.
5424
af5a5a98
AS
5425 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
5426 argument.
5427 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
5428 uses.
5429
8d38f461
EZ
54302012-06-29 Eli Zaretskii <eliz@gnu.org>
5431
2e5a6631
EZ
5432 * xdisp.c (try_window_id): Undo last change.
5433
8d38f461
EZ
5434 * w32.c (getwd): Adjust commentary about startup_dir.
5435 (init_environment): Always call sys_access, even in non-MSVC
5436 builds. Don't chdir to the directory of the Emacs executable.
5437 This undoes code from 1997 which was justified by the need to
5438 "avoid conflicts when removing and renaming directories". But its
5439 downside was that every relative file name was being interpreted
5440 relative to the directory of the Emacs executable, which can never
5441 be TRT. In particular, it broke sys_access when called with
5442 relative file names.
5443 (sys_access): Map GetLastError to errno.
5444
2af3565e
DA
54452012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5446
5447 * window.h (struct window): Change type of 'fringes_outside_margins'
5448 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 5449 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
5450 Adjust comment.
5451 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
5452 to ptrdiff_t.
5453
c8d3a25c 54542012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 5455
c8d3a25c
GM
5456 * gnutls.c (emacs_gnutls_handshake):
5457 Add QUIT to make the loop interruptible.
57570cd3 5458
c8d3a25c 54592012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 5460
c8d3a25c
GM
5461 * charset.c (init_charset): Make lack of etc/charsets fatal.
5462
3e984ee8
DA
54632012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5464
5465 * editfns.c (region_limit): Fix type mismatch.
5466
ef884f23
DA
54672012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5468
5469 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
5470 undefined. Convert from xassert to eassert.
5471 * nsmenu.m: Convert from xassert to eassert.
5472 * nsterm.m: Likewise.
5473
7d7e0027
SM
54742012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
5475
5476 * editfns.c (region_limit): Clip to narrowing (bug#11770).
5477
aa754e6a
PE
54782012-06-28 Paul Eggert <eggert@cs.ucla.edu>
5479
5480 Avoid integer overflow on scroll-left and scroll-right.
5481 * window.c (HSCROLL_MAX): New macro.
5482 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
5483 overflow when requested scroll falls outside ptrdiff_t range.
5484
80b00b08
DA
54852012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5486
5487 * window.h (struct window): Change type of 'hscroll',
5488 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
5489 'last_modified' and 'last_overlay_modified' to EMACS_INT.
5490 Adjust users accordingly.
5491 * xdisp.c (try_cursor_movement): Replace type check with eassert.
5492 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
5493 from EMACS_INT to ptrdiff_t.
5494 (make_window): Omit redundant initialization.
5495
62b2bcf6
JB
54962012-06-28 Juanma Barranquero <lekktu@gmail.com>
5497
5498 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
5499
45942c7d
DA
55002012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5501
5502 * window.h (struct window): Change type of 'use_time' and
5503 'sequence_number' from Lisp_Object to int.
5504 * frame.c (make_frame): Adjust users accordingly.
5505 * print.c (print_object): Likewise.
5506 * window.c (select_window, Fwindow_use_time, make_parent_window)
5507 (make_window): Likewise.
5508
e509cfa6
DA
55092012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5510
5511 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
5512 enabled with --enable-checking=[all,glyphs] configure option.
5513 Fix GLYPH_DEBUG usage assuming that it may be undefined,
5514 adjust comments accordingly.
5515 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
5516 undefined, adjust comments accordingly.
5517 * image.c: Likewise.
5518 * scroll.c: Likewise.
5519 * w32fns.c: Likewise.
5520 * w32term.c: Likewise.
5521 * xdisp.c: Likewise.
5522 * xfaces.c: Likewise.
5523 * xfns.c: Likewise.
5524 * xterm.c: Likewise.
5525
a54e2c05
DA
55262012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5527
5528 Generalize run-time debugging checks.
5529 * dispextern.h (XASSERTS): Remove.
5530 * fontset.c (xassert): Remove.
5531 Convert from xassert to eassert.
5532 * alloc.c: Convert from xassert to eassert.
5533 * bidi.c: Likewise.
5534 * dispnew.c: Likewise.
5535 * fns.c: Likewise.
5536 * fringe.c: Likewise.
5537 * ftfont.c: Likewise.
5538 * gtkutil.c: Likewise.
5539 * image.c: Likewise.
5540 * keyboard.c: Likewise.
5541 * menu.c: Likewise.
5542 * process.c: Likewise.
5543 * scroll.c: Likewise.
5544 * sound.c: Likewise.
5545 * term.c: Likewise.
5546 * w32console.c: Likewise.
5547 * w32fns.c: Likewise.
5548 * w32term.c: Likewise.
5549 * window.c: Likewise.
5550 * xdisp.c: Likewise.
5551 * xfaces.c: Likewise.
5552 * xfns.c: Likewise.
5553 * xselect.c: Likewise.
5554 * xterm.c: Likewise.
5555
1ec4b7b2
SM
55562012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
5557
5558 * fns.c (maybe_resize_hash_table): Output message when growing the
5559 purify-hashtable.
5560
2014308a
DA
55612012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5562
5563 * alloc.c (allocate_string_data): Remove dead code.
5564 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
5565 avoid GCC warning about unused macro.
5566
246155eb
DA
55672012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5568
5569 * alloc.c (allocate_string): Omit intervals initialization.
5570 * alloc.c (make_uninit_multibyte_string): Initialize intervals
5571 as in make_pure_string and make_pure_c_string.
5572
43184b7b
DA
55732012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5574
d209e2fb 5575 * alloc.c (allocate_string): Fix last change.
43184b7b 5576
3fe6dd74
DA
55772012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5578
d209e2fb 5579 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
5580 to memset, add explicit initialization where appropriate.
5581
1ba6038a
GM
55822012-06-27 Glenn Morris <rgm@gnu.org>
5583
5584 * lisp.mk (lisp): Remove paths.elc.
5585
c89926a5
CY
55862012-06-27 Chong Yidong <cyd@gnu.org>
5587
5588 * doc.c (Fsubstitute_command_keys): Fix punctuation.
5589
ed6b3510
JW
55902012-06-26 John Wiegley <johnw@newartisans.com>
5591
1ec4b7b2 5592 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
5593 on Mac OS X Lion: __mod_init_func and __mod_term_func.
5594
ed6b3510
JW
5595 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
5596 when building with Clang.
5597
8edd4a2b
SM
55982012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
5599
5600 * eval.c (Fapply): Allow calling it with a single argument.
5601
f6f62d1b
EZ
56022012-06-26 Eli Zaretskii <eliz@gnu.org>
5603
5604 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
5605 _stricmp and _strnicmp.
5606 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
5607
62efea5e
DA
56082012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
5609
5610 * alloc.c (allocate_window): Zero out non-Lisp part of newly
5611 allocated window.
5612 (allocate_process): Likewise for new process.
8edd4a2b 5613 (allocate_terminal): Change to use offsetof.
62efea5e
DA
5614 (allocate_frame): Likewise.
5615 * frame.c (make_frame): Omit redundant initialization.
5616 * window.c (make_parent_window): Use memset.
5617 (make_window): Omit redundant initialization.
5618 * process.c (make_process): Omit redundant initialization.
5619 * terminal.c (create_terminal): Likewise.
5620
42997f4d
DA
56212012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
5622
5623 * term.c (delete_tty): Remove redundant call to memset.
5624
1130ecfc
DA
56252012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
5626
5627 * alloc.c: Remove build_string.
5628 * lisp.h: Define build_string as static inline. This provides
5629 a better opportunity to optimize away calls to strlen when the
5630 function is called with compile-time constant argument.
5631 * image.c (imagemagick_error): Convert to build_string.
5632 * w32proc.c (sys_spawnve): Likewise.
5633 * xterm.c (x_term_init): Likewise.
5634
cf38a720
PE
56352012-06-26 Paul Eggert <eggert@cs.ucla.edu>
5636
99027bdd
PE
5637 Use sprintf return value instead of invoking strlen on result.
5638 In the old days this wasn't portable, since some sprintf
5639 implementations returned char *. But they died out years ago and
5640 Emacs already assumes sprintf returns int.
5641 Similarly for float_to_string.
5642 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
5643 * ccl.c (ccl_driver):
5644 * character.c (string_escape_byte8):
5645 * data.c (Fnumber_to_string):
5646 * doprnt.c (doprnt):
5647 * print.c (print_object):
5648 * xdisp.c (message_dolog):
5649 * xfns.c (syms_of_xfns):
5650 Use sprintf or float_to_string result to avoid need to call strlen.
5651 * data.c (Fnumber_to_string):
5652 Use make_unibyte_string, since the string must be ASCII.
5653 * lisp.h, print.c (float_to_string): Now returns int length.
5654 * term.c (produce_glyphless_glyph):
5655 Use sprintf result rather than recomputing it.
5656
cf38a720
PE
5657 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
5658 * Makefile.in (ALL_CFLAGS):
5659 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
5660 * gmalloc.c, regex.c: Include <config.h> unconditionally.
5661
3511c784
DA
56622012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
5663
0a08eb21 5664 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
5665 strcasecmp if available.
5666 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
5667
fb7da12e
AS
56682012-06-25 Andreas Schwab <schwab@linux-m68k.org>
5669
5670 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
5671 Avoid comma operator.
5672 * menu.c (push_submenu_start, push_submenu_end)
5673 (push_left_right_boundary, push_menu_pane): Likewise.
5674 * msdos.c (dos_rawgetc): Likewise.
5675
afa2ffd8
DA
56762012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
5677
5678 * xfns.c (xic_create_fontsetname): Remove redundant calls
5679 to memset.
5680
b3b4476b
PE
56812012-06-25 Paul Eggert <eggert@cs.ucla.edu>
5682
4495ff38
PE
5683 * gtkutil.c (get_utf8_string): Remove redundant assignment.
5684 sprintf already null-terminates its output.
5685
b3b4476b
PE
5686 * xfns.c (x_window): Remove redundant cast.
5687
b00876c9
DA
56882012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
5689
5690 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
5691 `const char *' to `char *' to avoid compiler warning.
5692
d188e26b
PE
56932012-06-24 Paul Eggert <eggert@cs.ucla.edu>
5694
885d1d74
PE
5695 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
5696 instead of truncating it to 63 (admittedly a generous limit).
5697
d188e26b
PE
5698 * process.c: Fix spelling and caps in comments.
5699
e2f560b1
DN
57002012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
5701
e86db54b 5702 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
5703 * sysdep.c (setpgrp): Remove definition, not used in this file.
5704
7583a3a1
JB
57052012-06-24 Juanma Barranquero <lekktu@gmail.com>
5706
5707 * makefile.w32-in: Update dependencies.
5708
696056c2
EZ
57092012-06-24 Eli Zaretskii <eliz@gnu.org>
5710
5711 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
5712 (SYSTIME_H): Add nt/inc/sys/time.h.
5713
5714 * systime.h [WINDOWSNT]: Include sys/time.h.
5715
5716 * s/ms-w32.h (struct timespec): Definition moved from
5717 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
5718
845ca893
PE
57192012-06-24 Paul Eggert <eggert@cs.ucla.edu>
5720
5721 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
5722 * buffer.h (buffer_slot_type_mismatch):
5723 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
5724 * eval.c (unwind_to_catch):
5725 * image.c (my_png_error, my_error_exit):
5726 * keyboard.c (quit_throw_to_read_char, user_error)
5727 (Fexit_recursive_edit, Fabort_recursive_edit):
5728 * lisp.h (die, args_out_of_range, args_out_of_range_3)
5729 (wrong_type_argument, buffer_overflow, __executable_start)
5730 (memory_full, buffer_memory_full, string_overflow, Fthrow)
5731 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
5732 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
5733 (fatal):
5734 (child_setup) [!DOS_NT]:
5735 * lread.c (end_of_file_error, invalid_syntax):
5736 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
5737 * puresize.h (pure_write_error):
5738 * search.c (matcher_overflow):
5739 * sound.c (sound_perror, alsa_sound_perror):
5740 * sysdep.c, syssignal.h (croak):
5741 * term.c (maybe_fatal, vfatal):
5742 * textprop.c (text_read_only):
5743 * undo.c (user_error):
5744 * unexmacosx.c (unexec_error):
5745 * xterm.c (x_ins_del_lines, x_delete_glyphs):
5746 Use _Noreturn rather than NO_RETURN.
5747 No need for separate decl merely because of _Noreturn.
5748 * sound.c (sound_warning, parse_sound):
5749 Remove unnecessary forward decls.
5750
f1dd8073
PE
57512012-06-24 Paul Eggert <eggert@cs.ucla.edu>
5752
5753 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
5754 * lisp.h (WAIT_READING_MAX): New macro.
5755 * dispnew.c (Fsleep_for, sit_for):
5756 * keyboard.c (kbd_buffer_get_event):
5757 * process.c (Faccept_process_output):
5758 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
5759 This improves on the previous patch, which introduced a bug
5760 when time_t is unsigned and as wide as intmax_t.
5761 See <http://bugs.gnu.org/9000#51>.
5762
b82c1755
EZ
57632012-06-23 Eli Zaretskii <eliz@gnu.org>
5764
5765 * dispnew.c (sit_for, Fsleep_for):
5766 * keyboard.c (kbd_buffer_get_event):
5767 * process.c (Faccept_process_output): Avoid compiler warnings when
5768 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
5769
ca300656
JB
57702012-06-23 Juanma Barranquero <lekktu@gmail.com>
5771
049ec95b
JB
5772 * makefile.w32-in: Update dependencies.
5773
ca300656
JB
5774 * w32.c (ltime): Add return type and declare static.
5775 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
5776
db7b8d06
PE
57772012-06-23 Paul Eggert <eggert@cs.ucla.edu>
5778
5779 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
5780 Privately reported by Herbert J. Skuhra.
5781 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
5782 All uses changed.
5783 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
5784 not make_lisp_timeval, when the argument is of type EMACS_TIME.
5785
0bd8297f
EZ
57862012-06-23 Eli Zaretskii <eliz@gnu.org>
5787
96512555
EZ
5788 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
5789 last argument of make_unibyte_string.
5790
0bd8297f
EZ
5791 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
5792 language ID in the event parameters.
5793
5794 * w32term.c (w32_read_socket): Put the new keyboard codepage into
5795 event.code, not the obscure "character set ID".
5796
63def6b6
CY
57972012-06-23 Chong Yidong <cyd@gnu.org>
5798
5799 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
5800
e8a02204
EZ
58012012-06-23 Eli Zaretskii <eliz@gnu.org>
5802
388cdec0
EZ
5803 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
5804 * w32.c (fdutimens): New function.
5805
5806 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
5807
5808 * s/ms-w32.h (pselect): Redirect to sys_select.
5809
5810 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
5811
e8a02204
EZ
5812 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
5813 in the logic of incrementing and decrementing the value of
5814 use_relocatable_buffers.
5815
d054f3fb
PE
58162012-06-23 Paul Eggert <eggert@cs.ucla.edu>
5817
5818 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
5819 Privately reported by Herbert J. Skuhra.
5820 [__FreeBSD__]: Remove "*/" typo after "#include".
5821 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
5822 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
5823 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
5824 Don't assume EMACS_TIME and struct timeval are the same type.
5825
d35af63c
PE
58262012-06-22 Paul Eggert <eggert@cs.ucla.edu>
5827
5828 Support higher-resolution time stamps (Bug#9000).
5829 The time stamps are only nanosecond-resolution at the C level,
5830 since that's the best that any real-world system supports now.
5831 But they are picosecond-resolution at the Lisp level, as that's
5832 easy, and leaves room for future OS improvements.
5833
5834 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
5835 (LIBES): Use it.
5836
5837 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
5838 Don't get current time unless it's needed.
5839
5840 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
5841 now provides it if it's absent.
5842 (start_atimer): Port to higher-res time stamps.
5843 Check for time stamp overflow. Don't get current time more
5844 often than is needed.
5845
5846 * buffer.h (struct buffer): Buffer modtime now has high resolution.
5847 Include systime.h, not time.h.
5848 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
5849
5850 * dired.c: Include stat-time.h.
5851 (Ffile-attributes): File times now have higher resolution.
5852
5853 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
5854 (struct image): Timestamp now has higher resolution.
5855
5856 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
5857 has at least microseconds now. All uses removed.
5858 (update_frame, update_single_window, update_window, update_frame_1)
5859 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 5860 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
5861
5862 * editfns.c (time_overflow): Now extern.
5863 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
5864 (float-time, Fformat_time_string, Fcurrent_time_string)
5865 (Fcurrent_time_zone): Accept and generate higher-resolution
5866 time stamps.
5867 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
5868 (decode_time_components, lisp_seconds_argument): New functions.
5869 (make_time): Now static.
5870 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
5871 Report an error if the time is invalid, rather than having the caller
5872 do that.
5873
5874 * fileio.c: Include <stat-time.h>
5875 (Fcopy_file): Copy higher-resolution time stamps.
5876 Prefer to set the time stamp via a file descriptor if that works.
5877 (Fset_file_times, Finsert_file_contents, Fwrite_region)
5878 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
5879 (Fvisited_file_modtime, Fset_visited_file_modtime):
5880 Support higher-resolution time stamps.
5881
5882 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
5883
5884 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
5885
5886 * image.c (prepare_image_for_display, clear_image_cache)
5887 (lookup_image): Port to higer-resolution time stamps.
5888
5889 * keyboard.c (start_polling, bind_polling_period):
5890 Check for time stamp overflow.
5891 (read_char, kbd_buffer_get_event, timer_start_idle)
5892 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
5893 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
5894 Port to higher-resolution time stamps. Do not assume time_t is signed.
5895 (decode_timer): New function. Timers are now vectors of length 9,
5896 not 8, to accommodate the picosecond component.
5897 (timer_check_2): Use it.
5898
5899 * nsterm.m (select_timeout, timeval_subtract): Remove.
5900 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
5901 as they're a bit more accurate and handle overflow better.
5902 (ns_select): Change prototype to be compatible with pselect.
5903 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
5904 * nsterm.h (ns_select): Adjust prototype.
5905
5906 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
5907 us-resolution time stamps.
5908 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
5909
5910 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
5911
5912 * lisp.h (time_overflow): New decl.
5913 (wait_reading_process_output): First arg is now intmax_t, not int,
5914 to accommodate larger waits.
5915
5916 * process.h (struct Lisp_Process.read_output_delay):
5917 Now counts nanoseconds, not microseconds.
5918 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
5919 EMACS_HAS_USECS.
5920 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
5921 (wait_reading_process_output):
5922 Port to ns-resolution time stamps.
5923 (Faccept_process_output, wait_reading_process_output):
5924 Check for time stamp overflow. Do not assume time_t is signed.
5925 (select_wrapper): Remove; we now use pselect.
5926 (Fprocess_attributes): Now generates ns-resolution time stamps.
5927
5928 * sysdep.c: Include utimens.h. Don't include utime.h
5929 or worry about struct utimbuf; gnulib does that for us now.
5930 (gettimeofday): Remove; gnulib provides a substitute.
5931 (make_timeval): New function.
5932 (set_file_times): Now sets ns-resolution time stamps.
5933 New arg FD; all uses changed.
5934 (time_from_jiffies, ltime_from_jiffies, get_up_time)
5935 (system_process_attributes):
5936 Now returns ns-resolution time stamp. All uses changed.
5937 Check for time stamp overflow.
5938
5939 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
5940 provides a substitute now.
5941
5942 * systime.h: Include timespec.h rather than sys/time.h and time.h,
5943 since it guarantees struct timespec.
5944 (EMACS_TIME): Now struct timespec, so that we can support
5945 ns-resolution time stamps.
5946 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
5947 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
5948 (EMACS_USECS): Remove.
5949 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
5950 so multiply the arg by 1000 before storing it.
5951 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
5952 New macros.
5953 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
5954 Port to ns-resolution time stamps.
5955 (EMACS_TIME_NEG_P): Remove; replaced by....
5956 (EMACS_TIME_SIGN): New macro.
5957 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
5958 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
5959 (set_file_times, make_time, lisp_time_argument): Adjust signature.
5960 (make_timeval, make_lisp_time, decode_time_components): New decls.
5961 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
5962 that it mishandled time_t overflow. You can't compare by subtracting!
5963 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
5964 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
5965
5966 * term.c: Include <sys/time.h>.
5967 (timeval_to_Time): New function, for proper overflow wraparound.
5968 (term_mouse_position, term_mouse_click): Use it.
5969
5970 * undo.c (record_first_change): Support higher-resolution time stamps
5971 in the undo buffer.
5972 (Fprimitive_undo): Use them when restoring time stamps.
5973
5974 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
5975 (w32_get_internal_run_time):
5976 Port to higher-resolution Emacs time stamps.
5977 (ltime): Now accepts single 64-bit integer, as that's more convenient
5978 for callers.
5979
5980 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
5981
5982 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
5983 for compatibility with pselect. Support ns-resolution time stamps.
5984
5985 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
5986
5987 * xselect.c (wait_for_property_change, x_get_foreign_selection):
5988 Check for time stamp overflow, and support ns-resolution time stamps.
5989
5990 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
5991 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
5992 (timeval_subtract): Remove; no longer needed.
5993 (XTflash, XTring_bell, x_wait_for_event):
5994 Port to ns-resolution time stamps. Don't assume time_t is signed.
5995
b6a92dfe
CY
59962012-06-22 Chong Yidong <cyd@gnu.org>
5997
5998 * xdisp.c (x_consider_frame_title): Revert last change.
5999
d251c37c
EZ
60002012-06-22 Eli Zaretskii <eliz@gnu.org>
6001
6002 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
6003 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
6004 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
6005 staticidx goes up to 1597 out of 1600 = 0x640.)
6006
f10deafb
PE
60072012-06-20 Paul Eggert <eggert@cs.ucla.edu>
6008
6009 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
6010 Otherwise, the umask might be mistakenly 0 while handling input signals.
6011
ec6de1e2
SM
60122012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
6013
6014 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
6015
28be1ada
DA
60162012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
6017
6018 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
6019 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
6020 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
6021 access to `contents' member of Lisp_Vector objects with AREF and ASET
6022 where appropriate.
6023
c6bf3022
CY
60242012-06-19 Chong Yidong <cyd@gnu.org>
6025
6026 * frame.c (delete_frame): When selecting a frame on a different
6027 text terminal, do not alter the terminal's top-frame.
6028
6029 * xdisp.c (format_mode_line_unwind_data): Record the target
6030 frame's selected window and its terminal's top-frame.
6031 (unwind_format_mode_line): Restore them.
6032 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
6033 Callers changed.
6034 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
6035 since tty frames can be explicitly named.
6036 (prepare_menu_bars): Likewise.
6037
6038 * term.c (Ftty_top_frame): New function.
6039
defd4196
PE
60402012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6041
6042 Port byte-code-meter to modern targets.
6043 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
6044 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 6045 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
6046 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
6047 (METER_1, METER_2): Simplify.
6048
1053a871
SM
60492012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
6050
6051 * data.c (Fdefalias): Return `symbol' (bug#11686).
6052
b7e8d081
MR
60532012-06-18 Martin Rudalics <rudalics@gmx.at>
6054
6055 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
6056 gets killed during executing of this function (Bug#11665).
6057 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
6058 (Vkill_buffer_query_functions): In doc-string say that functions
6059 run by this hook should not change the current buffer.
6060
7ea2b339
PE
60612012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6062
6063 Fix recently-introduced process.c problems found by static checking.
6064 * process.c (write_queue_push, write_queue_pop, send_process):
6065 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
6066 (write_queue_pop): Fix pointer signedness problem.
6067 (send_process): Remove unused local.
6068
96a313a1
CY
60692012-06-17 Chong Yidong <cyd@gnu.org>
6070
6071 * xdisp.c (redisplay_internal): No need to redisplay terminal
6072 frames that are not on top.
6073
20ca2e94
TN
60742012-06-17 Troels Nielsen <bn.troels@gmail.com>
6075
6076 * process.c (make_process): Initialize write_queue.
6077 (write_queue_push, write_queue_pop): New functions.
6078 (send_process): Use them to maintain correct ordering of process
6079 writes (Bug#10815).
6080
9a900ca9
PE
60812012-06-17 Paul Eggert <eggert@cs.ucla.edu>
6082
310fbfa8
PE
6083 * lisp.h (eassert): Assume C89 or later.
6084 This removes the need for CHECK.
6085 (CHECK): Remove. Its comments about always evaluating its
6086 argument were confusing, as 'eassert' typically does not evaluate
6087 its argument.
6088
27bb1ca4
PE
6089 * coding.c (produce_chars): Use ptrdiff_t, not int.
6090
9a900ca9
PE
6091 * xterm.c (x_draw_underwave): Check for integer overflow.
6092 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
6093
41b7f8bc 60942012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
6095
6096 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
6097 referenced (Bug#11583).
6098
9b0e3eba
AA
60992012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
6100
6101 Implement wave-style variant of underlining.
6102 * dispextern.h (face_underline_type): New enum.
6103 (face): Add field for underline type.
6104 * nsterm.m (ns_draw_underwave): New function.
6105 (ns_draw_text_decoration): Use it.
6106 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
6107 New functions.
6108 (x_draw_glyph_string): Use them.
6109 * xfaces.c (Qline, Qwave): New Lisp objects.
6110 (check_lface_attrs, merge_face_ref)
1053a871
SM
6111 (Finternal_set_lisp_face_attribute, realize_x_face):
6112 Handle wave-style underline face attributes.
9b0e3eba
AA
6113 * xterm.c (x_draw_underwave): New function.
6114 (x_draw_glyph_string): Use it.
6115
0fb52f11
JB
61162012-06-16 Juanma Barranquero <lekktu@gmail.com>
6117
6118 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
6119 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
6120 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
6121 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
6122 ($(BLD)/w32select.$(O)): Update dependencies.
6123
e5560ff7
AS
61242012-06-16 Andreas Schwab <schwab@linux-m68k.org>
6125
6126 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
6127 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
6128 * character.c (_fetch_multibyte_char_p): Remove.
6129 * alloc.c: Include "character.h" before "buffer.h".
6130 * bidi.c: Likewise.
6131 * buffer.c: Likewise.
6132 * bytecode.c: Likewise.
6133 * callint.c: Likewise.
6134 * callproc.c: Likewise.
6135 * casefiddle.c: Likewise.
6136 * casetab.c: Likewise.
6137 * category.c: Likewise.
6138 * cmds.c: Likewise.
6139 * coding.c: Likewise.
6140 * composite.c: Likewise.
6141 * dired.c: Likewise.
6142 * dispnew.c: Likewise.
6143 * doc.c: Likewise.
6144 * dosfns.c: Likewise.
6145 * editfns.c: Likewise.
6146 * emacs.c: Likewise.
6147 * fileio.c: Likewise.
6148 * filelock.c: Likewise.
6149 * font.c: Likewise.
6150 * fontset.c: Likewise.
6151 * fringe.c: Likewise.
6152 * indent.c: Likewise.
6153 * insdel.c: Likewise.
6154 * intervals.c: Likewise.
6155 * keyboard.c: Likewise.
6156 * keymap.c: Likewise.
6157 * lread.c: Likewise.
6158 * macros.c: Likewise.
6159 * marker.c: Likewise.
6160 * minibuf.c: Likewise.
6161 * nsfns.m: Likewise.
6162 * nsmenu.m: Likewise.
6163 * print.c: Likewise.
6164 * process.c: Likewise.
6165 * regex.c: Likewise.
6166 * region-cache.c: Likewise.
6167 * search.c: Likewise.
6168 * syntax.c: Likewise.
6169 * term.c: Likewise.
6170 * textprop.c: Likewise.
6171 * undo.c: Likewise.
6172 * unexsol.c: Likewise.
6173 * w16select.c: Likewise.
6174 * w32fns.c: Likewise.
6175 * w32menu.c: Likewise.
6176 * window.c: Likewise.
6177 * xdisp.c: Likewise.
6178 * xfns.c: Likewise.
6179 * xmenu.c: Likewise.
6180 * xml.c: Likewise.
6181 * xselect.c: Likewise.
6182
2f07e6af
EZ
61832012-06-16 Eli Zaretskii <eliz@gnu.org>
6184
1053a871
SM
6185 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
6186 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 6187 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
6188 row.
6189 (handle_face_prop): Use chunk-relative overlay string index when
6190 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
6191 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
6192 the rightmost. (Bug#11720)
2f07e6af 6193
29b83cec
AS
61942012-06-16 Andreas Schwab <schwab@linux-m68k.org>
6195
6196 * category.h (CHAR_HAS_CATEGORY): Define as inline.
6197 (CATEGORY_MEMBER): Enforce 1/0 value.
6198 * category.c (_temp_category_set): Remove.
6199
4c5501e9
EZ
62002012-06-16 Eli Zaretskii <eliz@gnu.org>
6201
6202 * window.c (Fdelete_other_windows_internal)
6203 (Fdelete_window_internal): Don't access frame's mouse highlight
6204 info of the initial frame. (Bug#11677)
6205
2b570124
PE
62062012-06-14 Paul Eggert <eggert@cs.ucla.edu>
6207
e93864f9
PE
6208 * .gdbinit (xgetint): Fix recently-introduced paren typo.
6209 Assume USE_2_TAGS_FOR_INTS.
6210 (xreload): Adjust $tagmask width to match recent lisp.h change.
6211
2b570124
PE
6212 Simplify lisp.h in minor ways that should not affect code.
6213 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
6214 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
6215 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
6216 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
6217 (INTTYPEBITS): New macro, for clarity.
6218 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
6219 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
6220 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
6221 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
6222 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
6223
81755f69
JB
62242012-06-13 Juanma Barranquero <lekktu@gmail.com>
6225
6226 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
6227
16192a57
GM
62282012-06-13 Glenn Morris <rgm@gnu.org>
6229
6230 * s/bsd-common.h (BSD4_3):
6231 * s/usg5-4-common.h (USG5_4): No longer define; unused.
6232
646b5f55
AS
62332012-06-13 Andreas Schwab <schwab@linux-m68k.org>
6234
6235 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
6236 instead of union.
6237 (XLI, XIL): Define.
1053a871
SM
6238 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
6239 Use them.
6240 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 6241 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 6242 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
6243 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
6244 * frame.c (delete_frame): Remove outdated comment.
6245 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
6246 USE_LISP_UNION_TYPE.
6247 (Fw32_unregister_hot_key): Likewise.
6248 (Fw32_toggle_lock_key): Likewise.
6249 * w32menu.c (add_menu_item): Likewise.
6250 (w32_menu_display_help): Use XIL instead of checking
6251 USE_LISP_UNION_TYPE.
6252 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
6253 (init_heap): Likewise.
6254 * w32term.c (w32_read_socket): Update comment.
6255
1d3823c9
GM
62562012-06-13 Glenn Morris <rgm@gnu.org>
6257
c62ff706
GM
6258 * s/usg5-4-common.h, src/s/unixware.h:
6259 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
6260
1d3823c9
GM
6261 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
6262
bfe3e0a2
PE
62632012-06-13 Paul Eggert <eggert@cs.ucla.edu>
6264
6265 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
6266 * alloc.c (make_number) [!defined make_number]:
6267 Remove, as lisp.h always defines this now.
6268 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
6269 (roundup_size): Verify that it is a power of 2.
6270 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
6271 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
6272 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
6273 -DUSE_LSB_TAG=0, to override the automatically-selected default.
6274 USE_LSB_TAG now is always defined to be either 0 or 1.
6275 All uses changed.
6276 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
6277 code works fine either way, and efficiency is not a concern here,
6278 as the union type is for debugging, not for production.
6279 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
6280 Use an inline function on all platforms when using the union type,
6281 since this is simpler and 'static inline' can be used portably
6282 within Emacs now.
6283 (LISP_INITIALLY_ZERO): New macro.
6284 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
6285 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
6286
45fa9c0f
GM
62872012-06-12 Glenn Morris <rgm@gnu.org>
6288
b4492cba
GM
6289 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
6290
6291 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 6292
45fa9c0f
GM
6293 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
6294 Move BROKEN_SIGIO to configure.
6295
6296 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
6297 Move NO_TERMIO to configure.
6298
0e25d334
CY
62992012-06-12 Chong Yidong <cyd@gnu.org>
6300
6301 * image.c (imagemagick_load_image): Use MagickFlattenImage if
6302 MagickMergeImageLayers is undefined. Use pixel pusher loop if
6303 MagickExportImagePixels is undefined.
6304
43682bb6
PE
63052012-06-12 Paul Eggert <eggert@cs.ucla.edu>
6306
6307 * image.c (imagemagick_load_image): Remove unused label.
6308
a9be7d2b
GM
63092012-06-11 Glenn Morris <rgm@gnu.org>
6310
6311 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
6312 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
6313 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
6314 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
6315
3017f87f
SM
63162012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
6317
6318 * alloc.c (make_byte_code): New function.
6319 (Fmake_byte_code): Use it. Don't purify here.
6320 * lread.c (read1): Use it as well to avoid extra allocation.
6321
1b9b4cf4
CY
63222012-06-11 Chong Yidong <cyd@gnu.org>
6323
6324 * image.c (imagemagick_load_image): Implement transparency.
6325
95988fcf
AS
63262012-06-10 Andreas Schwab <schwab@linux-m68k.org>
6327
6328 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
6329 account for preceding backslashes. (Bug#11663)
6330
cd4eb164
CY
63312012-06-09 Chong Yidong <cyd@gnu.org>
6332
6333 * term.c: Support italics in capable terminals (Bug#9652).
6334 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
6335 (turn_on_face): Output using TS_enter_italic_mode if available.
6336 Don't handle unused blinking and alt-charset cases.
6337 (turn_off_face): Handle italic case; discard unused tty_blinking_p
6338 and tty_alt_charset_p cases.
6339 (tty_capable_p, init_tty): Support italics.
6340
6341 * termchar.h (struct tty_display_info): Add field for italics.
6342 Remove unused blink field.
6343
6344 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
6345 Handle slant.
6346
6347 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
6348 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
6349 tty_alt_charset_p. Add tty_italic_p.
6350
ff88beb8
MA
63512012-06-09 Michael Albinus <michael.albinus@gmx.de>
6352
6353 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
6354 dbus_type_is_basic if available.
6355 (xd_extract_signed, xd_extract_unsigned): Rename from
6356 extract_signed and extract_unsigned, respectively. Adapt callers.
6357
44286096
CY
63582012-06-09 Chong Yidong <cyd@gnu.org>
6359
1682701f
CY
6360 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
6361
44286096
CY
6362 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
6363 case (Bug#9752).
6364
d86feb17
PE
63652012-06-08 Paul Eggert <eggert@cs.ucla.edu>
6366
6367 * xdisp.c (vmessage): Treat frame message as multibyte.
6368 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
6369 would generate the diagnostic "Making \302\247 buffer-local while
6370 let-bound!".
6371
d5c20fe8
EZ
63722012-06-08 Eli Zaretskii <eliz@gnu.org>
6373
6374 * dispnew.c (showing_window_margins_p): Undo last change, which
6375 was done due to an inadvertent commit.
6376 (adjust_frame_glyphs_for_frame_redisplay): Do call
6377 showing_window_margins_p.
6378
513749ee
SM
63792012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
6380
6381 * eval.c (Fmake_var_non_special): New primitive.
6382 (syms_of_eval): Defsubr it.
6383 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
6384
d4a8f5c1
JB
63852012-06-08 Juanma Barranquero <lekktu@gmail.com>
6386
6387 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
6388 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
6389
8bbbc977
EZ
63902012-06-08 Eli Zaretskii <eliz@gnu.org>
6391
6392 * alloc.c (allocate_vectorlike): Fix last change.
6393
f3372c87
DA
63942012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
6395
6396 Block-based vector allocation of small vectors.
6397 * lisp.h (struct vectorlike_header): New field `nbytes',
6398 adjust comment accordingly.
6399 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
fc0c31f8 6400 to denote vector blocks. Adjust users (live_vector_p,
f3372c87
DA
6401 mark_maybe_pointer, valid_lisp_object_p) accordingly.
6402 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
6403 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
6404 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
6405 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
6406 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
6407 (roundup_size): New constant.
6408 (struct vector_block): New data type.
6409 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 6410 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
6411 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
6412 (sweep_vectors): New functions.
6413 (allocate_vectorlike): Return `zero_vector' as the only vector of
fc0c31f8 6414 0 items. Allocate new vector from block if vector size is less than
f3372c87
DA
6415 or equal to VBLOCK_BYTES_MAX.
6416 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
6417 (init_alloc_once): Add call to init_vectors.
6418
4f18a4ed
SM
64192012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
6420
6421 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
6422
86f158bc
PE
64232012-06-07 Paul Eggert <eggert@cs.ucla.edu>
6424
6425 * doprnt.c (doprnt): Truncate multibyte char correctly.
6426 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
6427 would mishandle a string argument "Xc" if X was a multibyte
6428 character of length 2: it would truncate after X's first byte
6429 rather than including all of X.
6430
c5cfcbe0
CY
64312012-06-06 Chong Yidong <cyd@gnu.org>
6432
6433 * buffer.c (word_wrap): Doc fix.
6434
c05cf390
PE
64352012-06-04 Paul Eggert <eggert@cs.ucla.edu>
6436
6437 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
6438
0c3461de
GM
64392012-06-03 Glenn Morris <rgm@gnu.org>
6440
6441 * xdisp.c (tool-bar-style): Doc fix.
6442
c71232db
UM
64432012-06-03 Ulrich Müller <ulm@gentoo.org>
6444
6445 * Makefile.in (PAXCTL): Define.
6446 (temacs$(EXEEXT)): Disable memory randomization for the temacs
6447 binary via PaX flags if the paxctl utility is available.
6448 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
6449 Restore PaX flags to their default. (Bug#11398)
6450
383f7350
CY
64512012-06-03 Chong Yidong <cyd@gnu.org>
6452
6453 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
6454 buffer (Bug#11226).
6455
5f2c76c6
CY
64562012-06-03 Chong Yidong <cyd@gnu.org>
6457
6458 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
6459 (note_mode_line_or_margin_highlight): If there is no help echo,
6460 use mode-line-default-help-echo. Handle the case where the mouse
6461 position is past the end of the mode line string.
6462
6463 * buffer.c (buffer_local_value_1): New function, split from
6464 Fbuffer_local_value; can return Qunbound.
6465 (Fbuffer_local_value): Use it.
6466 (Vmode_line_format): Docstring tweaks.
6467
773d47f6
PE
64682012-06-02 Paul Eggert <eggert@cs.ucla.edu>
6469
6470 * sysdep.c (system_process_attributes): Improve comment.
6471
f2d6a3df
SM
64722012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
6473
6474 * keyboard.c: Export real-this-command to Elisp.
6475 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
6476 and DEFVAR it. Update all users.
6477
63810350
PE
64782012-06-02 Paul Eggert <eggert@cs.ucla.edu>
6479
7bd5c1f4
PE
6480 * minibuf.c (Fassoc_string): Remove duplicate declaration.
6481
63810350
PE
6482 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
6483 Convert pctcpu and pctmem to Lisp float properly.
6484 Let the compiler fold better, as 100.0/0x8000 is exact.
6485
a2821611
AS
64862012-06-02 Andreas Schwab <schwab@linux-m68k.org>
6487
6488 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
6489 cons_block.
6490
5fceba1d
PE
64912012-06-01 Paul Eggert <eggert@cs.ucla.edu>
6492
6493 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
6494
c98ff5dd
DA
64952012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
6496
6497 For a 'struct window', replace some Lisp_Object fields to
6498 bitfields where appropriate, remove unused fields.
6499 * window.h (struct window): Remove unused 'last_mark_x' and
6500 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
6501 change it's type from Lisp_Object to bitfield.
6502 Change type of 'force_start', 'optional_new_start',
6503 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
fc0c31f8 6504 fields from Lisp_Object to bitfield. Adjust users accordingly.
c98ff5dd 6505
ca34e0be
PE
65062012-05-31 Paul Eggert <eggert@cs.ucla.edu>
6507
6508 Pacify gcc -Wdouble-precision when using Xaw.
6509 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
6510 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
6511 Use 'float' consistently, rather than 'float' in most places
6512 and 'double' in a couple of places.
6513
efc00ab1 65142012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
6515
6516 * xdisp.c (handle_stop): Detect whether we have overlay strings
6517 loaded by testing it->current.overlay_string_index to be
6518 non-negative, instead of checking whether n_overlay_strings is
6519 positive. (Bug#11587)
6520
efc00ab1 65212012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
6522
6523 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
6524
6525 * doc.c (Fsubstitute_command_keys): Doc fix.
6526
efc00ab1 65272012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
6528
6529 * search.c (search_buffer): Remove calls to
6530 r_alloc_inhibit_buffer_relocation, as it is now called by
6531 maybe_unify_char, which was the cause of relocation of buffer text
6532 in bug#11519.
6533
efc00ab1 65342012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
6535
6536 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
6537 for the duration of call to load_charset, to avoid problems with
6538 callers of maybe_unify_char that access buffer text through C
6539 pointers.
6540
6541 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
6542 decrement the inhibition flag, instead of just setting or
6543 resetting it.
6544
ba93a187
PE
65452012-05-31 Paul Eggert <eggert@cs.ucla.edu>
6546
6547 Remove obsolete '#define static' cruft.
6548 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
6549 This #undef was "temporary" in 2000; it is no longer needed
6550 now that '#define static' has gone away.
6551 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
6552 (gray_bitmap_bits): Remove; no longer needed.
6553 All uses replaced with definiens.
6554 * xterm.c: Include "bitmaps/gray.xbm".
6555
9e4bf381
PE
65562012-05-30 Paul Eggert <eggert@cs.ucla.edu>
6557
6558 Clean up __executable_start, monstartup when --enable-profiling.
6559 The following changes affect the code only when profiling.
6560 * dispnew.c (__executable_start): Rename from safe_bcopy.
6561 Define only on platforms that need it.
6562 * emacs.c: Include <sys/gmon.h> when profiling.
6563 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
6564 (__executable_start): Remove decl, since lisp.h does it now.
6565 (safe_bcopy): Remove decl; no longer has that name.
6566 (main): Coalesce #if into single bit of code, for simplicity.
6567 Cast pointers to uintptr_t, since standard libraries want integers
6568 and not pointers.
6569 * lisp.h (__executable_start): New decl.
6570
32d72c2f
GM
65712012-05-31 Glenn Morris <rgm@gnu.org>
6572
6573 * image.c (Fimagemagick_types): Doc fix.
6574
baac5bc7
JM
65752012-05-30 Jim Meyering <meyering@redhat.com>
6576
6577 * callproc.c (Fcall_process_region): Include directory component
6578 in mkstemp error message (Bug#11586).
6579
72cb32cf
PE
65802012-05-30 Paul Eggert <eggert@cs.ucla.edu>
6581
6582 * alloc.c, lisp.h (make_pure_vector): Now static.
6583
61b108cc
SM
65842012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
6585
6586 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
6587 Move to byte-run.el.
6588 (Fautoload): Do the hash-doc more carefully.
6589 * data.c (Fdefalias): Purify definition, except for keymaps.
6590 (Qdefun): Move from eval.c.
6591 * lisp.h (Qdefun): Remove.
6592 * lread.c (read1): Tiny simplification.
6593
471fe23d
TN
65942012-05-29 Troels Nielsen <bn.troels@gmail.com>
6595
934f3f58 6596 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
6597 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
6598 Bug#9642, but explicitly check that the buffer the overlay would
6599 be moved to is live and rearrange lines to make sure that errors
6600 will not put the overlay in an inconsistent state.
6601 (Fdelete_overlay): Cosmetics.
6602
85d0efd1
EZ
66032012-05-28 Eli Zaretskii <eliz@gnu.org>
6604
6605 * w32term.c (my_bring_window_to_top): New function.
6606 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
6607 could be different from the original one.
6608 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
6609 (Bug#11513)
6610
6611 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
6612 by calling BringWindowToTop.
6613
6614 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
6615 (WM_EMACS_END): Increase by one.
6616
da92a98c
PE
66172012-05-28 Paul Eggert <eggert@cs.ucla.edu>
6618
6619 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
6620 This avoids undefined behavior that might cause the eassert
6621 to not catch an out-of-range value.
6622
74d1f848
JB
66232012-05-28 Juanma Barranquero <lekktu@gmail.com>
6624
6625 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
6626 Update dependencies.
6627
9e1a06fc
EZ
66282012-05-27 Eli Zaretskii <eliz@gnu.org>
6629
6630 * bidi.c (bidi_mirror_char): Fix last change.
6631
f3dd7312
AS
66322012-05-27 Andreas Schwab <schwab@linux-m68k.org>
6633
6634 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
6635 when referring to sectname field in printf format.
6636
81899c91
PE
66372012-05-27 Paul Eggert <eggert@cs.ucla.edu>
6638
57b81a9f
PE
6639 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
6640 Only r_alloc_inhibit_buffer_relocation needed to be added;
6641 the others were already declared.
6642
81899c91
PE
6643 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
6644 before checking whether it's out of range. Put the check inside
6645 eassert. See
6646 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
6647
33017faf 66482012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
6649
6650 * callproc.c (Fcall_process): Restore a line that was accidentally
6651 commented out in the 2011-02-13 change (bug#11547).
6652
33017faf 66532012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
6654
6655 * lisp.h [REL_ALLOC]: Add prototypes for external functions
6656 defined on ralloc.c.
6657
6658 * buffer.c [REL_ALLOC]: Remove prototypes of
6659 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
6660 they are now on lisp.h.
6661
6662 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
6663
6664 * search.c (search_buffer): Use it to inhibit relocation of buffer
6665 text while re_search_2 is doing its job, because re_search_2 is
6666 passed C pointers to buffer text. (Bug#11519)
6667
23415acf
EZ
6668 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
6669 Update value to 24.
6670
44e27368
EZ
6671 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
6672 state after an additional call to move_it_in_display_line_to, keep
6673 the values of it->max_ascent and it->max_descent found for the
6674 entire line.
6675 (pos_visible_p): Revert the comparison against bottom_y to what it
6676 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
6677 (Bug#11464)
6678
c1892f11
PE
66792012-05-26 Paul Eggert <eggert@cs.ucla.edu>
6680
6681 Fix coding-related core dumps with gcc -ftrapv.
6682 The code was computing A - B, where A and B are pointers, and B is
6683 random garbage. This can lead to core dumps on platforms that
6684 have special pointer registers, and it also leads to core dumps on
6685 x86-64 when compiled with gcc -ftrapv. The fix is to compute
6686 A - B only when B is initialized properly.
6687 * coding.c (coding_set_source, coding_set_destination): Return void.
6688 (coding_change_source, coding_change_destinations): New functions,
6689 with the old behaviors of coding_set_source and coding_set_destination.
6690 All callers that need an offset changed to use these new functions.
6691
eb7afdad
GM
66922012-05-26 Glenn Morris <rgm@gnu.org>
6693
6694 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
6695
f12fdf02
EZ
66962012-05-26 Eli Zaretskii <eliz@gnu.org>
6697
53a63be6 6698 Extend mouse support on W32 text-mode console.
61b108cc
SM
6699 * xdisp.c (draw_row_with_mouse_face):
6700 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 6701
eb3f6f01 6702 * w32console.c: Include window.h.
61b108cc
SM
6703 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
6704 New functions.
eb3f6f01
EZ
6705 (initialize_w32_display): Initialize mouse-highlight data.
6706
53a63be6
EZ
6707 * w32inevt.c: Include termchar.h and window.h.
6708 (do_mouse_event): Support mouse-autoselect-window. When the mouse
6709 moves, call note_mouse_highlight. If help_echo changed, call
6710 gen_help_event to produce help-echo message in the echo area.
6711 Call clear_mouse_face if mouse_face_hidden is set in the mouse
6712 highlight info.
6713
4cfd81f6
PE
67142012-05-26 Paul Eggert <eggert@cs.ucla.edu>
6715
6716 * lread.c (read1): Simplify slightly to avoid an overflow warning
6717 with GCC 4.7.0 on x86-64.
6718
4446092a
EZ
67192012-05-26 Eli Zaretskii <eliz@gnu.org>
6720
6721 * bidi.c (bidi_mirror_char): Revert last change: an int is
6722 definitely wide enough here.
6723
42b2a986 67242012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 6725
42b2a986 6726 Fix integer width and related bugs (Bug#9874).
eb106a49 6727 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
6728 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6729 (string_bytes, check_sblock, allocate_string_data):
6730 (compact_small_strings, Fmake_bool_vector, make_string)
6731 (make_unibyte_string, make_multibyte_string)
6732 (make_string_from_bytes, make_specified_string)
6733 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
6734 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
6735 (mark_vectorlike):
6736 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6737 (allocate_pseudovector):
6738 Use int, not EMACS_INT, where int is wide enough.
6739 (inhibit_garbage_collection, Fgarbage_collect):
6740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6741 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
6742 int might not be wide enough.
6743 (bidi_cache_search, bidi_cache_find, bidi_init_it)
6744 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
6745 (bidi_at_paragraph_end, bidi_find_paragraph_start)
6746 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6747 (bidi_level_of_next_char, bidi_move_to_visually_next):
6748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6749 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
6750 (Fkill_buffer, Fset_buffer_major_mode)
6751 (advance_to_char_boundary, Fbuffer_swap_text)
6752 (Fset_buffer_multibyte, overlays_at, overlays_in)
6753 (overlay_touches_p, struct sortvec, record_overlay_string)
6754 (overlay_strings, recenter_overlay_lists)
6755 (adjust_overlays_for_insert, adjust_overlays_for_delete)
6756 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
6757 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
6758 (Foverlay_recenter, last_overlay_modification_hooks_used)
6759 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
6760 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
6761 (validate_region): Omit unnecessary test for b <= e,
6762 since that's guaranteed by the previous test.
d311d28c
PE
6763 (adjust_overlays_for_delete): Avoid pos + length overflow.
6764 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
6765 (report_overlay_modification):
6766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6767 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
6768 Omit pointer cast, which isn't needed anyway, and doesn't work
6769 after the EMACS_INT -> ptrdiff_t change.
02481186 6770 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
6771 * buffer.h: Adjust decls to match defn changes elsewhere.
6772 (struct buffer_text, struct buffer):
6773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6774 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
6775 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
6776 not int, to avoid needless 32-bit limit on 64-bit hosts.
6777 (exec_byte_code): Use tighter memory-full test, one that checks
6778 for alloca overflow. Don't compute the address of the object just
6779 before an array, as that's not portable. Use EMACS_INT, not
6780 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
6781 * callint.c (Fcall_interactively):
6782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6783 * callproc.c (call_process_kill, Fcall_process):
6784 Don't assume pid_t fits into an Emacs fixnum.
6785 (call_process_cleanup, Fcall_process, child_setup):
6786 Don't assume pid_t fits into int.
6787 (call_process_cleanup, Fcall_process, delete_temp_file)
6788 (Fcall_process_region):
6789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6790 (Fcall_process): Simplify handling of volatile integers.
6791 Use int, not EMACS_INT, where int will do.
6792 * casefiddle.c (casify_object, casify_region, operate_on_word)
6793 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
6794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6795 (casify_object): Avoid integer overflow when overallocating buffer.
6796 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 6797 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
6798 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
6799 * category.h (CATEGORYP): Don't assume arg is nonnegative.
6800 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
6801 integers are now checked earlier. All uses replaced with XINT.
6802 (ccl_driver):
6803 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6804 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
6805 (ccl_driver, Fregister_code_conversion_map):
6806 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
6807 (resolve_symbol_ccl_program): Check that vector header is in range.
6808 Always copy the vector, so that we can check its contents reliably
6809 now rather than having to recheck each instruction as it's being
6810 executed. Check that vector words fit in 'int'.
6811 (ccl_get_compiled_code, Fregister_ccl_program)
6812 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
6813 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
6814 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
6815 contents are in range.
6816 (Fccl_execute_on_string): Check that status is in range.
6817 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
6818 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
6819 Accept and return EMACS_INT, not int, because callers can pass values
6820 out of 'int' range.
6821 (c_string_width, strwidth, lisp_string_width, chars_in_text)
6822 (multibyte_chars_in_text, parse_str_as_multibyte)
6823 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
6824 (str_as_unibyte, str_to_unibyte, string_count_byte8)
6825 (string_escape_byte8, Fget_byte):
6826 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 6827 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
6828 avoid mishandling large integers.
6829 * character.h: Adjust decls to match defn changes elsewhere.
6830 * charset.c (load_charset_map_from_file, find_charsets_in_text)
6831 (Ffind_charset_region):
6832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6833 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
6834 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 6835 Don't assume fixnum fits in int.
d311d28c
PE
6836 (load_charset_map_from_vector, Fmap_charset_chars):
6837 Remove now-unnecessary CHECK_NATNUMs.
6838 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
6839 Don't rely on undefined behavior with signed left shift overflow.
6840 Don't assume unsigned int fits into fixnum, or that fixnum fits
6841 into unsigned int. Don't require max_code to be a valid fixnum;
6842 that's not true for gb10830 4-byte on a 32-bit host. Allow
6843 invalid_code to be a cons, for the same reason. Require code_offset
6844 to be a character. Avoid int overflow if max_char is close
6845 to INT_MAX.
6846 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
6847 this is intended anyway and avoids some undefined behavior.
6848 (load_charset_map): Pass unsigned, not int, as 2nd arg of
6849 INDEX_TO_CODE_POINT, as that's what it expects.
6850 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
6851 * charset.h (DECODE_CHAR): Return int, not unsigned;
6852 this is what was intended anyway, and it avoids undefined behavior.
6853 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
6854 integer-overflow issues.
6855 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
6856 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
6857 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
6858 * chartab.c (Fmake_char_table, Fset_char_table_range)
6859 (uniprop_get_decoder, uniprop_get_encoder):
6860 Don't assume fixnum fits in int.
6861 * cmds.c (move_point): New function, that does the gist of
6862 Fforward_char and Fbackward_char, but does so while checking
6863 for integer overflow more accurately.
c96e5d6a 6864 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
6865 (Fforward_line, Fend_of_line, internal_self_insert)
6866 (internal_self_insert):
6867 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6868 Fix a FIXME, by checking for integer overflow when calculating
6869 target_clm and actual_clm.
6870 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 6871 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
6872 (ASSURE_DESTINATION, coding_alloc_by_realloc)
6873 (coding_alloc_by_making_gap, alloc_destination)
6874 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
6875 (encode_coding_utf_16, detect_coding_emacs_mule)
6876 (decode_coding_emacs_mule, encode_coding_emacs_mule)
6877 (detect_coding_iso_2022, decode_coding_iso_2022)
6878 (encode_invocation_designation, encode_designation_at_bol)
6879 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6880 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
6881 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
6882 (encode_coding_ccl, encode_coding_raw_text)
6883 (detect_coding_charset, decode_coding_charset)
6884 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
6885 (produce_composition, produce_charset, produce_annotation)
6886 (decode_coding, handle_composition_annotation)
6887 (handle_charset_annotation, consume_chars, decode_coding_gap)
6888 (decode_coding_object, encode_coding_object, detect_coding_system)
6889 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
6890 (code_convert_region, code_convert_string)
8f50130c
PE
6891 (Fdefine_coding_system_internal)
6892 (coding_set_source, coding_set_destination):
d311d28c
PE
6893 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6894 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
6895 (Fdefine_coding_system_internal):
6896 Don't assume fixnums fit in int.
6897 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 6898 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
6899 (Funencodable_char_position, Fcheck_coding_systems_region)
6900 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 6901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 6902 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 6903 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 6904 Don't access memory outside of the args array.
d311d28c 6905 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
6906 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
6907 result of ENCODE_CHAR.
d311d28c
PE
6908 * coding.h: Adjust decls to match defn changes elsewhere.
6909 (struct coding_system):
6910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6911 * composite.c (get_composition_id, find_composition)
6912 (run_composition_function, update_compositions)
6913 (compose_text, composition_gstring_put_cache)
6914 (composition_gstring_p, composition_gstring_width)
6915 (fill_gstring_header, fill_gstring_body, autocmp_chars)
6916 (composition_compute_stop_pos, composition_reseat_it)
6917 (composition_update_it, struct position_record)
6918 (find_automatic_composition, composition_adjust_point)
6919 (Fcomposition_get_gstring, Ffind_composition_internal):
6920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6921 (update_compositions):
6922 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6923 * composite.h: Adjust decls to match defn changes elsewhere.
6924 (struct composition):
6925 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6926 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
6927 Do not attempt to compute the address of the object just before a
6928 buffer; this is not portable.
6929 (Faref, Faset):
6930 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6931 (Faset): Use int, not EMACS_INT, where int is wide enough.
6932 (Fstring_to_number): Don't assume fixnums fit in int.
6933 (Frem): Don't assume arg is nonnegative.
6934 * dbusbind.c (xd_append_arg): Check for integers out of range.
6935 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 6936 (extract_signed, extract_unsigned): New functions.
243e0530
PE
6937 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
6938 (xd_get_connection_references): Return ptrdiff_t, not int.
6939 All uses changed.
6940 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
6941 (xd_read_message_1):
6942 Use int, not unsigned, where the dbus API uses int.
6943 (Fdbus_message_internal): Don't overflow mtype.
6944 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
6945 * dired.c (directory_files_internal, file_name_completion, scmp)
6946 (file_name_completion_stat):
6947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6948 (file_name_completion): Don't overflow matchcount.
6949 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
6950 * dispextern.h: Adjust decls to match defn changes elsewhere.
6951 (struct text_pos, struct glyph, struct bidi_saved_info)
6952 (struct bidi_string_data, struct bidi_it, struct composition_it)
6953 (struct it):
6954 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6955 (struct display_pos, struct composition_it, struct it):
6956 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6957 * dispnew.c (increment_matrix_positions)
6958 (increment_row_positions, mode_line_string)
6959 (marginal_area_string):
6960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 6961 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
6962 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6963 (duration_to_sec_usec): New function, to check for overflow better.
6964 (Fsleep_for, sit_for): Use it.
6965 * doc.c (get_doc_string, store_function_docstring):
6966 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6967 (get_doc_string, Fsnarf_documentation):
6968 Use int, not EMACS_INT, where int is wide enough.
6969 (get_doc_string):
6970 Use SAFE_ALLOCA, not alloca.
6971 Check for overflow when converting EMACS_INT to off_t.
6972 * doprnt.c (doprnt):
6973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6974 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
6975 Don't assume uid_t fits into fixnum.
6976 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
6977 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
6978 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
6979 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
6980 (general_insert_function)
6981 (Finsert_char, make_buffer_string, make_buffer_string_both)
6982 (update_buffer_properties, Fbuffer_substring)
6983 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
6984 (Fsubst_char_in_region, check_translation)
6985 (Ftranslate_region_internal, save_restriction_restore, Fformat)
6986 (transpose_markers, Ftranspose_regions):
6987 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6988 (clip_to_bounds): Move to lisp.h as an inline function).
6989 (Fconstrain_to_field): Don't assume integers are nonnegative.
6990 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
6991 (Fsubst_char_in_region, Fsave_restriction):
6992 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6993 (Femacs_pid): Don't assume pid_t fits into fixnum.
6994 (lo_time): Use int, not EMACS_INT, when int suffices.
6995 (lisp_time_argument): Check for usec out of range.
6996 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
6997 (Fuser_login_name, Fuser_full_name): Signal an error
6998 if a uid argument is out of range, rather than relying on
6999 undefined behavior.
c8d5c857
PE
7000 (Fformat_time_string): Remove now-unnecessary check.
7001 lisp_time_argument checks for out-of-range usec now.
243e0530 7002 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
7003 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
7004 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
7005 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
7006 (init_cmdargs, Fdump_emacs):
7007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7008 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
7009 the bottom (typically) 32 bits of the fixnum.
7010 * eval.c (specpdl_size, call_debugger):
7011 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7012 (when_entered_debugger, Fbacktrace_debug):
7013 Don't assume fixnum can fit in int.
7014 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
7015 the object just before a buffer; this is not portable.
7016 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
7017 (grow_specpdl, unbind_to):
7018 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7019 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
7020 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 7021 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
7022 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
7023 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
7024 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7025 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
7026 (a_write, e_write):
7027 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7028 (Fcopy_file, non_regular_nbytes, read_non_regular)
7029 (Finsert_file_contents):
7030 Use int, not EMACS_INT, where int is wide enough.
7031 (READ_BUF_SIZE): Verify that it fits in int.
7032 (Finsert_file_contents): Check that counts are in proper range,
7033 rather than assuming fixnums fit into ptrdiff_t etc.
7034 Don't assume fixnums fit into int.
125b3835 7035 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
7036 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
7037 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
7038 (string_char_to_byte, string_byte_to_char)
7039 (string_make_multibyte, string_to_multibyte)
7040 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
7041 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
7042 (substring_both, Fdelete, internal_equal, Ffillarray)
7043 (Fclear_string, mapcar1)
7044 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
7045 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
7046 (larger_vector, make_hash_table, maybe_resize_hash_table)
7047 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
7048 (Fmaphash, secure_hash):
7049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7050 (concat): Check for string index and length overflow.
7051 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
7052 (Frequire):
7053 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7054 (larger_vector): New API (vec, incr_min, size_max) replaces old
7055 one (vec, new_size, init). This catches size overflow.
7056 INIT was removed because it was always Qnil.
7057 All callers changed.
7058 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
7059 the upper bound on a hash table index size.
7060 (make_hash_table, maybe_resize_hash_table): Use it.
7061 (secure_hash): Computer start_byte and end_byte only after
7062 they're known to be in ptrdiff_t range.
7063 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
7064 (Ffont_get_glyphs, Ffont_at):
7065 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7066 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
7067 (Flist_fonts, Fopen_font):
7068 Don't assume fixnum can fit in int.
7069 (check_gstring): Don't assume index can fit in int.
7070 (font_match_p): Check that fixnum is a character, not a nonnegative
7071 fixnum, since the later code needs to stuff it into an int.
7072 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
7073 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
7074 conversion overflow issues.
7075 (Fopen_font): Check for integer out of range.
7076 (Ffont_get_glyphs): Don't assume index can fit in int.
7077 * font.h: Adjust decls to match defn changes elsewhere.
7078 * fontset.c (reorder_font_vector): Redo score calculation to avoid
7079 integer overflow.
7080 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
7081 printmax_t, where ptrdiff_t is wide enough.
7082 (Finternal_char_font):
7083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7084 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
7085 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
7086 (Fset_frame_position, x_set_frame_parameters)
7087 (x_set_line_spacing, x_set_border_width)
7088 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
7089 Check that fixnums are in proper range for system types.
7090 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
7091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7092 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
7093 Use SAFE_ALLOCA_LISP, not alloca.
7094 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
7095 intptr_t is wide enough.
7096 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
7097 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
7098 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
7099 Check for fixnum out of range.
7100 * ftfont.c (ftfont_list): Don't assume index fits in int.
7101 Check that fixnums are in proper range for system types.
7102 (ftfont_shape_by_flt):
7103 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
7104 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7105 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7106 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
7107 Check that fixnums are in proper range for system types.
7108 * gnutls.h: Adjust decls to match defn changes elsewhere.
7109 * gtkutil.c (xg_dialog_run):
7110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7111 (update_frame_tool_bar):
7112 Check that fixnums are in proper range for system types.
7113 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 7114 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
7115 * indent.c (last_known_column, last_known_column_point):
7116 (current_column_bol_cache):
7117 (skip_invisible, current_column, check_display_width):
7118 (check_display_width, scan_for_column, current_column_1)
7119 (Findent_to, Fcurrent_indentation, position_indentation)
7120 (indented_beyond_p, Fmove_to_column, compute_motion):
7121 (Fcompute_motion, Fvertical_motion):
7122 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7123 (last_known_column_modified): Use EMACS_INT, not int.
7124 (check_display_width):
7125 (Fcompute_motion):
7126 Check that fixnums and floats are in proper range for system types.
7127 (compute_motion): Don't assume index or fixnum fits in int.
7128 (compute_motion, Fcompute_motion):
7129 Use int, not EMACS_INT, when it is wide enough.
7130 (vmotion): Omit local var start_hpos that is always 0; that way
7131 we don't need to worry about overflow in expressions involving it.
7132 * indent.h: Adjust decls to match defn changes elsewhere.
7133 (struct position):
7134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7135 Use int, not EMACS_INT, where int is wide enough.
7136 Remove unused members ovstring_chars_done and tab_offset;
7137 all uses removed.
7138 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
7139 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
7140 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
7141 (make_gap, copy_text, insert, insert_and_inherit)
7142 (insert_before_markers, insert_before_markers_and_inherit)
7143 (insert_1, count_combining_before, count_combining_after)
7144 (insert_1_both, insert_from_string)
7145 (insert_from_string_before_markers, insert_from_string_1)
7146 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
7147 (adjust_after_replace, adjust_after_insert, replace_range)
7148 (replace_range_2, del_range, del_range_1, del_range_byte)
7149 (del_range_both, del_range_2, modify_region)
7150 (prepare_to_modify_buffer, signal_before_change)
7151 (signal_after_change, Fcombine_after_change_execute):
7152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7153 * intervals.c (traverse_intervals, rotate_right, rotate_left)
7154 (balance_an_interval, split_interval_right, split_interval_left)
7155 (find_interval, next_interval, update_interval)
7156 (adjust_intervals_for_insertion, delete_node, delete_interval)
7157 (interval_deletion_adjustment, adjust_intervals_for_deletion)
7158 (static_offset_intervals, offset_intervals)
7159 (merge_interval_right, merge_interval_left, make_new_interval)
7160 (graft_intervals_into_buffer, temp_set_point_both)
7161 (temp_set_point, set_point, adjust_for_invis_intang)
7162 (set_point_both, move_if_not_intangible, get_property_and_range)
7163 (get_local_map, copy_intervals, copy_intervals_to_string)
7164 (compare_string_intervals, set_intervals_multibyte_1):
7165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7166 * intervals.h: Adjust decls to match defn changes elsewhere.
7167 (struct interval):
7168 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7169 * keyboard.c (this_command_key_count, this_single_command_key_start)
7170 (before_command_key_count, before_command_echo_length, echo_now)
7171 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
7172 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
7173 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
7174 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
7175 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7176 (last_non_minibuf_size, last_point_position, echo_truncate)
7177 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
7178 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
7179 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
7180 (stuff_buffered_input):
7181 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7182 (last_auto_save, command_loop_1, read_char):
7183 Use EMACS_INT, not int, to avoid integer overflow.
7184 (record_char): Avoid overflow in total_keys computation.
7185 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
7186 * keyboard.h: Adjust decls to match defn changes elsewhere.
7187 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
7188 (Fkey_description, Fdescribe_vector, Flookup_key):
7189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7190 (click_position): New function, to check that positions are in range.
7191 (Fcurrent_active_maps):
7192 (describe_command):
7193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7194 (Faccessible_keymaps, Fkey_description):
7195 (preferred_sequence_p):
7196 Don't assume fixnum can fit into int.
7197 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
7198 Check for integer overflow in size calculations.
7199 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
7200 avoid mishandling large integers.
7201 * lisp.h: Adjust decls to match defn changes elsewhere.
7202 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
7203 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
7204 (struct Lisp_Marker):
7205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7206 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
7207 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
7208 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
7209 All callers changed.
7210 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
7211 Assume the arg has valid form, since it always does.
7212 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
7213 unsigned integer system type.
7214 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
7215 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
7216 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7217 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
7218 (duration_to_sec_usec): New decl.
7219 * lread.c (read_from_string_index, read_from_string_index_byte)
7220 (read_from_string_limit, readchar, unreadchar, openp)
7221 (read_internal_start, read1, oblookup):
7222 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7223 (Fload, readevalloop, Feval_buffer, Feval_region):
7224 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7225 (openp): Check for out-of-range argument to 'access'.
7226 (read1): Use int, not EMACS_INT, where int is wide enough.
7227 Don't assume fixnum fits into int.
6efdadfd 7228 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
7229 (read_filtered_event): Use duration_to_sec_usec
7230 to do proper overflow checking on durations.
d311d28c
PE
7231 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
7232 in size calculation.
7233 (Fexecute_kbd_macro):
7234 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7235 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
7236 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
7237 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
7238 (set_marker_both, set_marker_restricted_both, marker_position)
7239 (marker_byte_position, Fbuffer_has_markers_at):
7240 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7241 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 7242 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
7243 It now merely ensures that the menu is large enough, without
7244 necessarily growing it, as this avoids some integer overflow issues.
7245 All callers changed.
7246 (keymap_panes, parse_single_submenu, Fx_popup_menu):
7247 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7248 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
7249 Use SAFE_ALLOCA_LISP, not alloca.
7250 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
7251 to EMACS_INT. Check that fixnums are in proper range for system types.
7252 * minibuf.c (minibuf_prompt_width, string_to_object)
7253 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
7254 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
7255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7256 (get_minibuffer, read_minibuf_unwind):
7257 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7258 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
7259 this simplifies overflow checking. All callers changed.
7260 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
7261 (Ftest_completion):
7262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7263 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
7264 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
7265 Check that fixnums are in proper range for system types.
7266 (Fx_create_frame, Fx_show_tip):
7267 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7268 * nsfont.m (ns_findfonts, nsfont_list_family):
7269 Don't assume fixnum fits in long.
7270 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
7271 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7272 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
7273 wide enough.
17fdb222 7274 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
7275 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7276 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
7277 (PRINTDECLARE, PRINTPREPARE):
7278 (strout, print_string):
7279 (print, print_preprocess, print_check_string_charset_prop)
7280 (print_object):
7281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7282 (PRINTDECLARE):
7283 (temp_output_buffer_setup, Fprin1_to_string, print_object):
7284 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7285 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 7286 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 7287 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
7288 (print_error_message): Use SAFE_ALLOCA, not alloca.
7289 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
7290 (print_depth, new_backquote_output, print_number_index):
7291 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
7292 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
7293 (Fset_process_window_size, Fformat_network_address)
7294 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 7295 (sigchld_handler):
d311d28c 7296 Check that fixnums are in proper range for system types.
d44287d4 7297 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
7298 Check for process-ids out of pid_t range rather than relying on
7299 undefined behavior.
e4d81efc 7300 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
7301 (Fformat_network_address, read_process_output, send_process)
7302 (Fprocess_send_region, status_notify):
7303 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7304 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
7305 (wait_reading_process_output, read_process_output, exec_sentinel):
7306 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7307 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
7308 (Faccept_process_output): Use duration_to_sec_usec to do proper
7309 overflow checking on durations.
dde14581
PE
7310 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
7311 Don't assume pid_t fits in int.
02481186
PE
7312 * process.h (struct Lisp_Process): Members tick and update_tick
7313 are now of type EMACS_INT, not int.
b62b53e8
PE
7314 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
7315 configured --with-wide-int.
d311d28c
PE
7316 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
7317 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
7318 * search.c (looking_at_1, string_match_1):
7319 (fast_string_match, fast_c_string_match_ignore_case)
7320 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
7321 (scan_newline, find_before_next_newline, search_command)
7322 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
7323 (set_search_regs, wordify):
7324 (Freplace_match):
7325 (Fmatch_data):
7326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7327 (string_match_1, search_buffer, set_search_regs):
7328 (Fmatch_data):
7329 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7330 (wordify): Check for overflow in size calculation.
7331 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
7332 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
7333 Check that fixnums are in proper range for system types.
7334 * sound.c (struct sound_device)
7335 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
7336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7337 (Fplay_sound_internal):
7338 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 7339 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
7340 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
7341 (Fparse_partial_sexp):
7342 Don't assume fixnums can fit in int.
7343 (struct lisp_parse_state, find_start_pos, find_start_value)
7344 (find_start_value_byte, find_start_begv)
7345 (update_syntax_table, char_quoted, dec_bytepos)
7346 (find_defun_start, prev_char_comend_first, back_comment):
7347 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
7348 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
7349 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7350 (Finternal_describe_syntax_value): Check that match_lisp is a
7351 character, not an integer, since the code stuffs it into int.
7352 (scan_words, scan_sexps_forward):
7353 Check that fixnums are in proper range for system types.
7354 (Fforward_word):
7355 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7356 (scan_sexps_forward):
7357 Use CHARACTERP, not INTEGERP, since the value must fit into int.
7358 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
7359 * syntax.h: Adjust decls to match defn changes elsewhere.
7360 (struct gl_state_s):
7361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
7362 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
7363 MOST_POSITIVE_FIXNUM.
d311d28c
PE
7364 * sysdep.c (wait_for_termination_1, wait_for_termination)
7365 (interruptible_wait_for_termination, mkdir):
7366 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
7367 (emacs_read, emacs_write):
7368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
7369 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
7370 and double all fit in int.
d311d28c
PE
7371 * term.c (set_tty_color_mode):
7372 Check that fixnums are in proper range for system types.
7373 * termhooks.h (struct input_event):
7374 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7375 * textprop.c (validate_interval_range, interval_of)
7376 (Fadd_text_properties, set_text_properties_1)
7377 (Fremove_text_properties, Fremove_list_of_text_properties)
7378 (Ftext_property_any, Ftext_property_not_all)
7379 (copy_text_properties, text_property_list, extend_property_ranges)
7380 (verify_interval_modification):
7381 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7382 (Fnext_single_char_property_change)
7383 (Fprevious_single_char_property_change):
7384 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
7385 (copy_text_properties):
7386 Check for integer overflow in index calculation.
d311d28c
PE
7387 * undo.c (last_boundary_position, record_point, record_insert)
7388 (record_delete, record_marker_adjustment, record_change)
7389 (record_property_change):
7390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7391 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
7392 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7393 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
7394 (Fx_hide_tip, Fx_file_dialog):
7395 * w32menu.c (set_frame_menubar):
7396 Use ptrdiff_t, not int, for consistency with rest of code.
7397 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
7398 (select_window, Fdelete_other_windows_internal)
7399 (window_scroll_pixel_based, window_scroll_line_based)
7400 (Frecenter, Fset_window_configuration):
7401 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7402 (Fset_window_hscroll, run_window_configuration_change_hook)
7403 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 7404 (Fscroll_other_window, Frecenter):
d311d28c
PE
7405 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7406 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
7407 Don't assume fixnum fits in int.
7408 (Fset_window_scroll_bars):
7409 Check that fixnums are in proper range for system types.
7410 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
7411 (string_pos, c_string_pos, number_of_chars, init_iterator)
7412 (in_ellipses_for_invisible_text_p, init_from_display_pos)
7413 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
7414 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
7415 (face_before_or_after_it_pos, handle_invisible_prop)
7416 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
7417 (display_prop_intangible_p, string_buffer_position_lim)
7418 (string_buffer_position, handle_composition_prop, load_overlay_strings)
7419 (get_overlay_strings_1, get_overlay_strings)
7420 (iterate_out_of_display_property, forward_to_next_line_start)
7421 (back_to_previous_visible_line_start, reseat, reseat_to_string)
7422 (get_next_display_element, set_iterator_to_next)
7423 (get_visually_first_element, compute_stop_pos_backwards)
7424 (handle_stop_backwards, next_element_from_buffer)
7425 (move_it_in_display_line_to, move_it_in_display_line)
7426 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7427 (add_to_log, message_dolog, message_log_check_duplicate)
7428 (message2, message2_nolog, message3, message3_nolog
7429 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
7430 (current_message_1, truncate_echo_area, truncate_message_1)
7431 (set_message, set_message_1, store_mode_line_noprop)
7432 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
7433 (text_outside_line_unchanged_p, check_point_in_composition)
7434 (reconsider_clip_changes)
7435 (redisplay_internal, set_cursor_from_row, try_scrolling)
7436 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
7437 (redisplay_window, find_last_unchanged_at_beg_row)
7438 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
7439 (trailing_whitespace_p, find_row_edges, display_line)
7440 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
7441 (display_mode_element, store_mode_line_string)
7442 (pint2str, pint2hrstr, decode_mode_spec)
7443 (display_count_lines, display_string, draw_glyphs)
7444 (x_produce_glyphs, x_insert_glyphs)
7445 (rows_from_pos_range, mouse_face_from_buffer_pos)
7446 (fast_find_string_pos, mouse_face_from_string_pos)
7447 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7449 (safe_call, init_from_display_pos, handle_fontified_prop)
7450 (handle_single_display_spec, load_overlay_strings)
7451 (with_echo_area_buffer, setup_echo_area_for_printing)
7452 (display_echo_area, echo_area_display)
7453 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
7454 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
7455 (redisplay_window, dump_glyph_row, display_mode_line)
7456 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 7457 (handle_display_spec, display_prop_string_p):
d311d28c
PE
7458 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7459 (handle_single_display_spec, build_desired_tool_bar_string)
7460 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
7461 (get_specified_cursor_type):
7462 Check that fixnums are in proper range for system types.
7463 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
7464 (Flookup_image_map):
7465 Don't assume fixnums fit in int.
7466 (compare_overlay_entries):
7467 Avoid mishandling comparisons due to subtraction overflow.
7468 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
7469 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
7470 (handle_tool_bar_click):
7471 Use int, not unsigned, since we prefer signed and the signedness
7472 doesn't matter here.
7473 (get_next_display_element, next_element_from_display_vector):
7474 Use int, not EMACS_INT, when int is wide enough.
7475 (start_hourglass): Use duration_to_sec_usec to do proper
7476 overflow checking on durations.
7477 * xfaces.c (Fbitmap_spec_p):
7478 Check that fixnums are in proper range for system types.
7479 (compare_fonts_by_sort_order):
7480 Avoid mishandling comparisons due to subtraction overflow.
7481 (Fx_family_fonts, realize_basic_faces):
7482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7483 (Fx_family_fonts):
7484 Don't assume fixnum fits in int.
7485 Use SAFE_ALLOCA_LISP, not alloca.
7486 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
7487 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
7488 (face_at_buffer_position, face_for_overlay_string)
7489 (face_at_string_position):
7490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7491 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
7492 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
7493 (Fx_show_tip):
7494 Check that fixnums are in proper range for system types.
7495 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
7496 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
7497 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7498 (Fx_change_window_property): Don't assume fixnums fit in int.
7499 * xfont.c (xfont_chars_supported):
7500 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7501 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
7502 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
7503 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7504 * xml.c (parse_region):
7505 * xrdb.c (magic_file_p):
7506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7507 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
7508 (x_get_local_selection, x_reply_selection_request)
7509 (x_handle_selection_request, wait_for_property_change):
7510 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7511 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
7512 short is wide enough.
7513 (x_send_client_event): Don't assume fixnum fits in int.
7514 * xterm.c (x_x_to_emacs_modifiers):
7515 Don't assume EMACS_INT overflows nicely into int.
7516 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
7517 may come from Lisp.
7518 (handle_one_xevent): NATNUMP can eval its arg twice.
7519 (x_connection_closed):
7520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7521 * xterm.h: Adjust decls to match defn changes elsewhere.
7522 (struct scroll_bar): Use struct vectorlike_header
7523 rather than rolling our own approximation.
7524 (SCROLL_BAR_VEC_SIZE): Remove; not used.
7525
c6574eb5
GM
75262012-05-25 Glenn Morris <rgm@gnu.org>
7527
7528 * lisp.mk (lisp): Update for more files being compiled now.
7529
e8d32c7e
SM
75302012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
7531
48def666
SM
7532 * lread.c: Remove `read_pure' which makes no difference.
7533 (read_pure): Remove var.
7534 (unreadpure): Remove function.
7535 (readevalloop): Don't call read_list with -1 flag.
7536 (read1, read_vector): Don't test read_pure any more.
7537 (read_list): Simplify.
7538
e8d32c7e
SM
7539 * fileio.c, character.h: Minor style tweaks.
7540
4b2addb7
DA
75412012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
7542
7543 * window.h (clip_changed): Remove useless declaration.
7544
584461b2
JB
75452012-05-22 Juanma Barranquero <lekktu@gmail.com>
7546
7547 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
7548 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
7549
34374650
PE
75502012-05-22 Paul Eggert <eggert@cs.ucla.edu>
7551
7552 Remove src/m/*.
7553 This directory predates autoconf and is no longer needed nowadays.
7554 Move its few remaining bits of functionality to where they're needed.
7555 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
7556 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
7557 * m/template.h: Remove.
7558 * Makefile.in (M_FILE): Remove. All uses removed.
7559 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
7560 * lisp.h (USE_LSB_TAG):
7561 * mem-limits.h (EXCEEDS_LISP_PTR):
7562 Use VAL_MAX, not VALBITS, in #if.
7563 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
7564 (EMACS_UINT): Define unconditionally now.
7565 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
7566 (BITS_PER_EMACS_INT): New constants, replacing
7567 what used to be in config.h, but not useful in #if.
7568 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
7569 define them any more.
7570 (VAL_MAX): New macro.
7571 (VALMASK): Use it.
7572 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
7573 BITS_PER_EMACS_INT, in #if.
7574 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
7575 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
7576 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
7577 * s/ms-w32.h (DATA_START):
7578 Move here from removed file m/intel386.h.
7579 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
7580 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
7581
261cb4bb
PE
75822012-05-21 Paul Eggert <eggert@cs.ucla.edu>
7583
7584 Assume C89 or later.
7585 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
7586 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
7587 (xrealloc):
7588 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
7589 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
7590 * textprop.c, tparam.c (NULL): Remove.
7591 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
7592 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
7593 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
7594 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
7595 * xterm.c (input_signal_count): Assume volatile works.
7596
ff23cd9f
KB
75972012-05-21 Ken Brown <kbrown@cornell.edu>
7598
7599 * xgselect.c (xg_select): Fix first argument in call to 'select'
7600 (bug#11508).
7601
1b170bc6
KB
76022012-05-20 Ken Brown <kbrown@cornell.edu>
7603
7604 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 7605 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 7606
b2f4d39f
KB
76072012-05-19 Ken Brown <kbrown@cornell.edu>
7608
7609 * xfns.c (x_in_use): Remove `static' qualifier.
7610 * xterm.h (x_in_use): Declare.
7611 * xgselect.c: Include xterm.h.
7612 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
7613 and `display_arg' (bug#9754).
7614
003fdae2
PE
76152012-05-19 Paul Eggert <eggert@cs.ucla.edu>
7616
9232a6d9
PE
7617 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
7618
003fdae2
PE
7619 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
7620 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
7621
784b56e2
EZ
76222012-05-18 Eli Zaretskii <eliz@gnu.org>
7623
7624 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
7625
7626 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 7627 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
7628
7629 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
7630 reference to image_cache->refcount.
7631 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
7632
a0a79cde
JL
76332012-05-17 Juri Linkov <juri@jurta.org>
7634
7635 * search.c (Fword_search_regexp, Fword_search_backward)
7636 (Fword_search_forward, Fword_search_backward_lax)
7637 (Fword_search_forward_lax): Move functions to isearch.el
7638 (bug#10145, bug#11381).
7639
b0572523
PE
76402012-05-16 Paul Eggert <eggert@cs.ucla.edu>
7641
7642 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
7643
9660f5fc
SM
76442012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
7645
7646 * lread.c (init_obarray): Declare Qt and Qnil as special.
7647
4374de83
GM
76482012-05-14 Glenn Morris <rgm@gnu.org>
7649
7650 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 7651 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 7652
dc44c39a
PE
76532012-05-14 Paul Eggert <eggert@cs.ucla.edu>
7654
078c97cb
PE
7655 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
7656
dc44c39a
PE
7657 * unexaix.c: Port to more-recent AIX compilers.
7658 (report_error, report_error_1, make_hdr, copy_sym)
7659 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
7660 Make arguments const char *, not char *, to avoid violations of C
7661 standard and to fix some AIX warnings reported by Gilles Pion.
7662
e18afed7 76632012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
7664
7665 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
7666 already have overlays loaded.
7667 (handle_single_display_spec): Before returning without displaying
7668 fringe bitmap, synchronize the bidi iterator with the main display
7669 iterator, by calling iterate_out_of_display_property.
7670 (iterate_out_of_display_property): Detect buffer iteration by
7671 testing that it->string is a Lisp string.
7672 (get_next_display_element): When the current object is exhausted,
7673 and there's something on it->stack, call set_iterator_to_next to
7674 proceed with what's on the stack, instead of returning zero.
7675 (set_iterator_to_next): If called at the end of a Lisp string,
7676 proceed to consider_string_end without incrementing string
7677 position. Don't increment display vector index past the end of
7678 the display vector. (Bug#11417)
c8fb9dc6
EZ
7679 (pos_visible_p): Don't report a position visible when move_it_to
7680 stopped at the last line of window, which happens to be scanned
7681 backwards by the bidi iteration. (Bug#11464)
ac268e67 7682
e18afed7 76832012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
7684
7685 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
7686 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
7687 are on a TTY, and thus unable to display on the fringes.
7688 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
7689 so we need to signal to the caller that this is a "replacing"
7690 display spec. This fixes display when the spec is invalid or we
7691 are on a TTY.
7692
e18afed7 76932012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
7694
7695 * unexaix.c (make_hdr): Fix typo in prototype.
7696 This bug broke the build on AIX. Problem reported by Gilles Pion.
7697
9d0a235a
MA
76982012-05-14 Michael Albinus <michael.albinus@gmx.de>
7699
7700 * keyboard.c (kbd_buffer_get_event): Read special events also in
7701 batch mode. (Bug#11415)
7702
9e6b06ed
GM
77032012-05-12 Glenn Morris <rgm@gnu.org>
7704
7705 * ns.mk: Update for ns_appbindir no longer having trailing "/".
7706
c1a1d7a3
EZ
77072012-05-12 Eli Zaretskii <eliz@gnu.org>
7708
7709 * lisp.mk (lisp): Add newcomment.elc.
7710
3fe7cdc8
GM
77112012-05-12 Glenn Morris <rgm@gnu.org>
7712
7713 * Makefile.in (MKDIR_P): New, set by configure.
7714 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
7715
53f7d2c0
PE
77162012-05-11 Paul Eggert <eggert@cs.ucla.edu>
7717
7718 Remove unused function hourglass_started.
7719 * dispextern.h (hourglass_started):
7720 * w32fns.c (hourglass_started):
7721 * xdisp.c (hourglass_started): Remove.
7722
75aafb17
JB
77232012-05-10 Juanma Barranquero <lekktu@gmail.com>
7724
7725 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
7726 Update dependencies.
7727
12959e8e
PE
77282012-05-10 Paul Eggert <eggert@cs.ucla.edu>
7729
97107e2e
PE
7730 * xgselect.c (xg_select): Put maxfds+1 into a var.
7731 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
7732
12959e8e
PE
7733 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
7734
836d29b3
DA
77352012-05-10 Dave Abrahams <dave@boostpro.com>
7736
7737 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
7738 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
7739
5cb67954
MA
77402012-05-09 Michael Albinus <michael.albinus@gmx.de>
7741
7742 * dbusbind.c (xd_registered_buses): New internal Lisp object.
7743 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
7744 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
7745 Initialize xd_registered_buses.
7746
3478ec45
PE
77472012-05-09 Paul Eggert <eggert@cs.ucla.edu>
7748
b263a6b0
PE
7749 Untag more efficiently if USE_LSB_TAG.
7750 This is based on a proposal by YAMAMOTO Mitsuharu in
7751 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
7752 For an admittedly artificial (nth 8000 longlist) benchmark on
7753 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
7754 Emacs's overall text size by 1%.
7755 * lisp.h (XUNTAG): New macro.
7756 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
7757 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
7758 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
7759 * eval.c (Fautoload):
7760 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
7761 * frame.h (XFRAME): Use XUNTAG.
7762
3478ec45
PE
7763 Port recent dbusbind.c changes to 32-bit --with-wide-int.
7764 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
7765 Remove unportable assumptions about print widths of types like
7766 dbus_uint32_t.
7767 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
7768 intptr_t when converting between pointer and integer, to avoid GCC
7769 warnings about wrong width.
7770
666b903b 77712012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
7772
7773 * w32proc.c (new_child): Force Windows to reserve only 64KB of
7774 stack for each reader_thread, instead of defaulting to 8MB
7775 determined by the linker. This avoids failures in creating
7776 subprocesses on Windows 7, see the discussion in this thread:
7777 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
7778
b120cc17
JC
77792012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
7780
7781 Fix up display of the *Minibuf-0* buffer in the mini window.
7782 * keyboard.c (read_char): Don't clear the echo area if there's no
7783 message to clear.
7784 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 7785 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 7786
9a4b36f8
MA
77872012-05-07 Michael Albinus <michael.albinus@gmx.de>
7788
7789 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
7790 batch mode.
7791
e5f9458f
CY
77922012-05-06 Chong Yidong <cyd@gnu.org>
7793
7794 * lisp.mk (lisp): Update.
7795
eceeb5fc 77962012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
7797
7798 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
7799
71873e2b
SM
78002012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
7801
7802 * data.c (PUT_ERROR): New macro.
7803 (syms_of_data): Use it. Add new error type `user-error'.
7804 * undo.c (user_error): New function.
7805 (Fprimitive_undo): Use it.
7806 * print.c (print_error_message): Adjust print style for `user-error'.
7807 * keyboard.c (user_error): New function.
7808 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
7809
ab0fa4e4
PE
78102012-05-03 Paul Eggert <eggert@cs.ucla.edu>
7811
7812 Do not limit current-time-string to years 1000..9999.
7813 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
7814 (Fcurrent_time_string): Support any year that is supported by the
7815 underlying localtime representation. Don't use asctime, as it
7816 has undefined behavior for years outside the range -999..9999.
7817
7ed806a7
PE
78182012-05-02 Paul Eggert <eggert@cs.ucla.edu>
7819
7820 Fix race conditions involving setenv, gmtime, localtime, asctime.
7821 Without this fix, interrupts could mess up code that uses these
7822 nonreentrant functions, since setting TZ invalidates existing
7823 tm_zone or tzname values, and since most of these functions return
7824 pointers to static storage.
7825 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
7826 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
7827 Grow the critical sections to include not just invoking
7828 localtime/gmtime, but also accessing these functions' results
7829 including their tm_zone values if any, and any related TZ setting.
7830 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
7831 so that the struct tm is saved in the critical section.
7832 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
7833 motivated by the fact that memory allocation needs to be outside
7834 the critical section.
7835
0c16dfed
DA
78362012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
7837
7838 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
7839 with RESET_INTERVAL.
7840
7841 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7842 Remove duplicated buffer name initialization.
7843
3f83ace8
JM
78442012-05-02 Jim Meyering <jim@meyering.net>
7845
7846 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
7847
c7b8541e
JM
7848 * xfns.c (x_window): Use xstrdup (Bug#11375).
7849
90207a15 78502012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
7851
7852 * xdisp.c (pos_visible_p): If already at a newline from the
7853 display string before the 'while' loop, don't walk back the glyphs
7854 from it3.glyph_row. Solves assertion violation when the display
7855 string begins with a newline (egg.el). (Bug#11367)
7856
b593d6a9
AH
78572012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
7858
7859 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
7860 Move to simple.el.
7861
4737362e
GM
78622012-05-01 Glenn Morris <rgm@gnu.org>
7863
99cf43f9
GM
7864 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
7865 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
7866 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
7867 All were removed before 23.1.
7868
9311dcff
GM
7869 * dispnew.c: Remove HAVE_LIBNCURSES test;
7870 it is always true on relevant platforms.
7871
4d5c6349
GM
7872 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
7873 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
7874
4737362e
GM
7875 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
7876
74dd3a6b
AS
78772012-04-30 Andreas Schwab <schwab@linux-m68k.org>
7878
7879 * .gdbinit (xpr): Remove checks for no longer existing misc types.
7880 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
7881 Remove.
7882
13c379ee
PE
78832012-04-28 Paul Eggert <eggert@cs.ucla.edu>
7884
7885 Do not avoid creating empty evaporating overlays (Bug#9642).
7886 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
7887 That is, do not delete an evaporating overlay if it becomes
7888 empty after its bounds are adjusted to fit within its buffer.
7889 This fix caused other problems, and I'm reverting it until we get
7890 to the bottom of them.
7891
a8e7d6d7 78922012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
7893
7894 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
7895
a8e7d6d7 78962012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
7897
7898 * xdisp.c (pos_visible_p): If the window start position is beyond
7899 ZV, start the display from buffer beginning. Prevents assertion
7900 violation in init_iterator when the minibuffer window is scrolled
7901 via the scroll bar.
7902
7903 * window.c (window_scroll_pixel_based): Likewise.
7904
a8e7d6d7 79052012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
7906
7907 * keymap.c (where_is_internal): Doc fix (Bug#10872).
7908
a8e7d6d7 79092012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
7910
7911 * fileio.c (Fcopy_file, Fset_file_selinux_context):
7912 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
7913
a8e7d6d7 79142012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 7915
b593d6a9
AH
7916 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
7917 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 7918
1c6900d9
EZ
79192012-04-26 Eli Zaretskii <eliz@gnu.org>
7920
4c3fa1d9
EZ
7921 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
7922 display element, check also the underlying string or buffer
7923 character. (Bug#11341)
7924
1c6900d9
EZ
7925 * w32menu.c: Include w32heap.h.
7926 (add_menu_item): If the call to AppendMenuW (via
7927 unicode_append_menu) fails, disable Unicode menus only if we are
7928 running on Windows 9X/Me.
7929
42bf8205
AS
79302012-04-24 Andreas Schwab <schwab@linux-m68k.org>
7931
7932 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
7933 (xgetint): Add missing shift for LSB tags.
7934
b1bac16e
MR
79352012-04-24 Martin Rudalics <rudalics@gmx.at>
7936
7937 * keyboard.c (read_char): Don't wipe echo area for select window
7938 events: These might get delayed via `mouse-autoselect-window'
7939 (Bug#11304).
7940
d69621cc
JB
79412012-04-24 Juanma Barranquero <lekktu@gmail.com>
7942
7943 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
7944 manipulation of :loaded-from data.
7945
02fd101b
JB
79462012-04-23 Juanma Barranquero <lekktu@gmail.com>
7947
7948 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
7949 now a cons (bug#11311).
7950
888bec30
PE
79512012-04-23 Paul Eggert <eggert@cs.ucla.edu>
7952
89a438bd
PE
7953 Do not create empty overlays with the evaporate property (Bug#9642).
7954 * buffer.c (Fmove_overlay): Delete an evaporating overlay
7955 if it becomes empty after its bounds are adjusted to fit within
7956 its buffer. Without this fix, in a nonempty buffer (let ((o
7957 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
7958 yields an empty overlay that has the evaporate property, which is
7959 not supposed to happen.
7960
1068fe4d
PE
7961 Fix minor GTK3 problems found by static checking.
7962 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7963 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7964 (struct _EmacsFixedClass, emacs_fixed_get_type):
7965 Move decls here from emacsgtkfixed.h, since they needn't be public.
7966 (emacs_fixed_get_type): Now static.
7967 (emacs_fixed_class_init): Omit unused local.
7968 (emacs_fixed_child_type): Remove; unused.
7969 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7970 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7971 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
7972 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
7973 (EMACS_FIXED_GET_CLASS): Remove; unused.
7974 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
7975
888bec30
PE
7976 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
7977 Problem reported by Juanma Barranquero for Windows -Wunused-function.
7978
de85e130
PE
79792012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7980
d0baac98 7981 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 7982 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
7983 (__malloc_size_t, __malloc_ptrdiff_t):
7984 Remove. All uses removed, replaced by the definiens if needed,
7985 since we can assume C89 or better now.
7986 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
7987 (protect_malloc_state, align, get_contiguous_space)
7988 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
7989 (malloc_atfork_handler_child, malloc_enable_thread)
7990 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
7991 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
7992 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
7993 (special_realloc, _realloc_internal_nolock, _realloc_internal)
7994 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
7995 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
7996 Define using prototypes, not old style.
7997 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
7998 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
7999 (align): Don't assume that signed integer overflow wraps around.
8000 Omit unused local var.
8001 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
8002 (_free_internal_nolock, memalign, mallochook, reallochook):
8003 Omit no-longer-needed casts.
8004 (valloc): Use getpagesize, not __getpagesize.
8005 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
8006 (struct hdr): The 'magic' member is now size_t, not unsigned long.
8007
de85e130
PE
8008 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
8009
dcbf5805
MA
80102012-04-22 Michael Albinus <michael.albinus@gmx.de>
8011
8012 Move functions from C to Lisp. Make non-blocking method calls
8013 the default. Implement further D-Bus standard interfaces.
8014
8015 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
8016 (QCdbus_request_name_allow_replacement)
8017 (QCdbus_request_name_replace_existing)
8018 (QCdbus_request_name_do_not_queue)
8019 (QCdbus_request_name_reply_primary_owner)
8020 (QCdbus_request_name_reply_in_queue)
8021 (QCdbus_request_name_reply_exists)
8022 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
8023 (QCdbus_registered_serial, QCdbus_registered_method)
8024 (QCdbus_registered_signal): New Lisp objects.
8025 (XD_DEBUG_MESSAGE): Use sizeof.
8026 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
8027 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
8028 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
8029 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
8030 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
8031 (xd_signature, xd_append_arg): Allow float for integer types.
8032 (xd_get_connection_references): New function.
b593d6a9
AH
8033 (xd_get_connection_address): Rename from xd_initialize.
8034 Return cached address.
dcbf5805
MA
8035 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
8036 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
8037 level.
8038 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 8039 Return number of refcounts.
dcbf5805
MA
8040 (Fdbus_get_unique_name): Make stronger parameter check.
8041 (Fdbus_message_internal): New defun.
8042 (Fdbus_call_method, Fdbus_call_method_asynchronously)
8043 (Fdbus_method_return_internal, Fdbus_method_error_internal)
8044 (Fdbus_send_signal, Fdbus_register_service)
8045 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
8046 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
8047 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
8048 (Vdbus_compiled_version, Vdbus_runtime_version)
8049 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
8050 (Vdbus_message_type_method_return, Vdbus_message_type_error)
8051 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
8052 (Vdbus_registered_buses, Vdbus_registered_objects_table):
8053 Adapt docstring.
dcbf5805 8054
52828e02
PE
80552012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8056
da05bc4c
PE
8057 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
8058 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
8059 Do not assume ptrdiff_t is the same width as 'int'.
8060
52828e02
PE
8061 * alloc.c: Handle unusual debugging option combinations.
8062 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
8063 since the two debugging options are incompatible.
8064 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
8065 is defined.
8066 (mem_init, mem_insert, mem_insert_fixup):
8067 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
8068 (NEED_MEM_INSERT): Remove; no longer needed.
8069
f01769f9
LL
80702012-04-22 Leo Liu <sdl.web@gmail.com>
8071
8072 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
8073
5790543d
PE
80742012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8075
8076 * sysdep.c [__FreeBSD__]: Minor cleanups.
8077 (list_system_processes, system_process_attributes) [__FreeBSD__]:
8078 Use Emacs indenting style more consistently. Avoid some casts.
8079 Use 'double' consistently rather than mixing 'float' and 'double'.
8080
b91b7e4d
EW
80812012-04-21 Eduard Wiebe <usenet@pusto.de>
8082
b593d6a9
AH
8083 * sysdep.c (list_system_processes, system_process_attributes):
8084 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 8085
6114eb15
AS
80862012-04-21 Andreas Schwab <schwab@linux-m68k.org>
8087
8088 * lisp.mk (lisp): Update.
8089
2f38dff7
PE
80902012-04-20 Paul Eggert <eggert@cs.ucla.edu>
8091
8092 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
8093 It is never used otherwise.
8094
4ae29f89
SM
80952012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
8096
8097 * print.c (print_preprocess): Only check print_depth if print-circle
8098 is nil.
8099 (print_object): Check for cycles even when print-circle is nil and
8100 print-gensym is t, but only check print_depth if print-circle is nil.
8101
f30d612a
CY
81022012-04-20 Chong Yidong <cyd@gnu.org>
8103
8104 * process.c (wait_reading_process_output): If EIO occurs on a pty,
8105 set the status to "failed" and ensure that sentinel is run.
8106
c07a4c0b 81072012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
8108
8109 * process.c (Fset_process_inherit_coding_system_flag)
8110 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 8111 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 8112
c07a4c0b 81132012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
8114
8115 * xdisp.c (string_buffer_position_lim): Limit starting position to
8116 BEGV.
8117 (set_cursor_from_row): If called for a mode-line or header-line
8118 row, return zero immediately.
8119 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
8120 farther than the first row after the header line, if any.
8121 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
8122 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
8123
c07a4c0b 81242012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 8125
4ae29f89
SM
8126 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
8127 (bug#11238).
ad3a2b41 8128
c07a4c0b 81292012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 81302012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
8131
8132 configure: new option --enable-gcc-warnings (Bug#11207)
8133 * Makefile.in (C_WARNINGS_SWITCH): Remove.
8134 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
8135 (ALL_CFLAGS): Use new macros rather than old.
8136 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
8137 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
8138 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
8139 -Wunused-result, -Wunused-variable. This should go away once
8140 the Emacs and Gnulib regex code is merged.
8141 (xmalloc, xrealloc): Now static.
8142
aba027e8
PE
81432012-04-17 Paul Eggert <eggert@cs.ucla.edu>
8144
8145 * dired.c (Fsystem_groups): Remove unused local.
8146
e5a36063
GM
81472012-04-17 Glenn Morris <rgm@gnu.org>
8148
8149 * dired.c (Fsystem_users): Doc fix.
8150
316411f0
DA
81512012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
8152
8153 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
8154 (syms_of_dired): Add them.
8155
9426aba4
PE
81562012-04-16 Paul Eggert <eggert@cs.ucla.edu>
8157
b62a57be
PE
8158 Fix minor alloc.c problems found by static checking.
8159 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
8160 New extern decls, to avoid calling undeclared functions.
8161 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
8162 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
8163 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
8164 (NEED_MEM_INSERT): New macro.
8165 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 8166 Remove one incorrect comment and fix another.
b62a57be 8167
3539f31f
PE
8168 Fix minor ralloc.c problems found by static checking.
8169 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
8170 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
8171 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
8172 (r_alloc_sbrk): Now static.
8173
a041960a
PE
8174 Improve ralloc.c interface checking.
8175 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
8176 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
8177 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
8178 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
8179 [REL_ALLOC]: ... to here, to check interface.
8180 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
8181 Remove decls. This fixes an "It stinks!".
8182
9426aba4
PE
8183 * alloc.c (which_symbols): Fix alignment issue / type clash.
8184
d55c12ed
AS
81852012-04-15 Andreas Schwab <schwab@linux-m68k.org>
8186
8187 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
8188 (struct Lisp_Misc_Any): Likewise.
8189 (struct Lisp_Free): Likewise.
8190 * alloc.c (union aligned_Lisp_Symbol): Define.
8191 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
8192 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
8193 (union aligned_Lisp_Misc): Define.
8194 (MARKER_BLOCK_SIZE, struct marker_block): Use union
8195 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 8196 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 8197
b948ce8b
PE
81982012-04-14 Paul Eggert <eggert@cs.ucla.edu>
8199
8200 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
8201 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
8202 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
8203 * s/netbsd.h, s/sol2-6.h:
8204 Remove definition of GC_MARK_STACK, since the default now works.
8205 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
8206 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
8207 no longer the default.
8208 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
8209
35dc09a1 82102012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 8211
35dc09a1
GM
8212 * lread.c (lisp_file_lexically_bound_p):
8213 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 8214
35dc09a1
GM
82152012-04-14 Eli Zaretskii <eliz@gnu.org>
8216
8217 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
8218 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
8219
82202012-04-14 Jan Djärv <jan.h.d@swipnet.se>
8221
8222 * nsterm.m (constrainFrameRect): Always constrain when there is only
8223 one screen (Bug#10962).
8224
bcd86815
KB
82252012-04-13 Ken Brown <kbrown@cornell.edu>
8226
8227 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
8228
c25df26e
RT
82292012-04-13 Reuben Thomas <rrt@sc3d.org>
8230
8231 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
8232
0fc59f1e
DC
82332012-04-11 Daniel Colascione <dancol@dancol.org>
8234
8235 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
8236 against is gone. It's better to use vfork now so that when Cygwin
8237 gains a new, working vfork, we use it automatically (bug#10398).
8238
de8c03dc
SM
82392012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
8240
8241 * window.c (save_window_save): Obey window-point-insertion-type.
8242
2f097256
GM
82432012-04-11 Glenn Morris <rgm@gnu.org>
8244
8245 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
8246
453b951e
SM
82472012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
8248
8249 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
8250
75f1671a 82512012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
8252
8253 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
8254 (force_quit_count): New var.
8255 (handle_interrupt): Use it.
8256
2a8ce227
JB
82572012-04-10 Juanma Barranquero <lekktu@gmail.com>
8258
8259 * w32.c (w32_delayed_load): Record the full path of the library
8260 being loaded (bug#10424).
8261
935396c0
GM
82622012-04-09 Glenn Morris <rgm@gnu.org>
8263
05920a43
GM
8264 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
8265 not just in the obarray, before snarfing them. (Bug#11036)
8266
935396c0
GM
8267 * Makefile.in ($(leimdir)/leim-list.el):
8268 Pass EMACS rather than BUILT_EMACS.
8269
a18ecafa
TZ
82702012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
8271
8272 * process.c (make_process):
8273 * process.h: Add integer `gnutls_handshakes_tried' member to
8274 process struct.
8275
6bbef4e5
JC
8276 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
8277 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
8278
8279 * gnutls.c (gnutls_log_function2i): Convenience log function.
8280 (emacs_gnutls_read): Use new log functions,
8281 `gnutls_handshakes_tried' process member, and
8282 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
8283 attempts per process (connection).
8284
b4d3bc10
CY
82852012-04-09 Chong Yidong <cyd@gnu.org>
8286
8287 * eval.c (Fuser_variable_p, user_variable_p_eh)
8288 (lisp_indirect_variable): Functions deleted.
8289 (Fdefvar): Caller changed.
8290
8291 * callint.c (Finteractive, Fcall_interactively):
8292 * minibuf.c (Fread_variable): Callers changed.
8293
70f4d973
EZ
82942012-04-09 Eli Zaretskii <eliz@gnu.org>
8295
8296 * xdisp.c (set_cursor_from_row): If the display string appears in
8297 the buffer at position that is closer to point than the position
8298 after the display string, display the cursor on the first glyph of
8299 the display string. Fixes cursor display when a 'display' text
8300 property immediately follows invisible text. (Bug#11094)
8301
cb3c2e3e
PE
83022012-04-09 Paul Eggert <eggert@cs.ucla.edu>
8303
8304 composite.c: use 'double' consistently
8305 * composite.c (get_composition_id): Use 'double' consistently
8306 instead of converting 'float' to 'double' and vice versa; this is
8307 easier to understand and avoids a GCC warning.
8308
fd06db5d
GM
83092012-04-09 Glenn Morris <rgm@gnu.org>
8310
50fe702a
GM
8311 * Makefile.in: Generate leim-list with bootstrap-emacs, in
8312 preparation for dumping it with emacs. (Bug#4789)
8313 (leimdir): New variable.
8314 ($(leimdir)/leim-list.el): New rule.
8315 (emacs$(EXEEXT)): Depend on leim-list.el.
8316
fd06db5d
GM
8317 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
8318 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
8319 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
8320
55c131ee
AS
83212012-04-08 Andreas Schwab <schwab@linux-m68k.org>
8322
8323 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
8324 proper alignment.
8325
9209588f
JB
83262012-04-07 Juanma Barranquero <lekktu@gmail.com>
8327
8328 * xml.c (init_libxml2_functions) [WINDOWSNT]:
8329 Remove unused local variable.
8330
e3fb2efb
PE
83312012-04-07 Paul Eggert <eggert@cs.ucla.edu>
8332
8333 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
8334 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
8335 (mark_memory): Mark Lisp_Objects only if pointers might hide in
8336 objects, as mark_maybe_pointer will catch them otherwise.
8337 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
8338 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
8339
b5385551
PE
83402012-04-07 Paul Eggert <eggert@cs.ucla.edu>
8341
8342 Fix typo that broke non-Windows builds.
8343 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
8344
9078ead6
EZ
83452012-04-07 Eli Zaretskii <eliz@gnu.org>
8346
8347 Support building on MS-Windows with libxml2.
8348
8349 * makefile.w32-in (OBJ2): Add xml.$(O).
8350 (GLOBAL_SOURCES): Add xml.c.
8351 ($(BLD)/xml.$(O)): New dependency list.
8352
8353 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
8354 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
8355 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
8356 [!WINDOWSNT]: New macros.
8357 (init_libxml2_functions, libxml2_loaded_p): New functions.
8358 (parse_region): Call fn_xmlCheckVersion instead of using the macro
8359 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
8360 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
8361 Calls xmlCleanupParser only if libxml2 was loaded (or statically
8362 linked in).
6bbef4e5
JC
8363 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
8364 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
8365 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
8366
8367 * emacs.c: Don't include libxml/parser.h.
8368 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
8369 xmlCleanupParser directly.
8370
8371 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
8372
3811fdf3
EZ
83732012-04-07 Eli Zaretskii <eliz@gnu.org>
8374
8375 * indent.c (Fvertical_motion): If there is a display string at
8376 point, use it.vpos to compute how many lines to backtrack after
8377 move_it_to point. (Bug#11133)
8378
2f8e16b2
EZ
83792012-04-06 Eli Zaretskii <eliz@gnu.org>
8380
8381 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
8382 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
8383 about subtle differences between FETCH_CHAR* and STRING_CHAR*
8384 macros related to unification of CJK characters. For the details,
8385 see the discussion following the message here:
8386 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
8387
3d439cd1
CY
83882012-04-04 Chong Yidong <cyd@gnu.org>
8389
8390 * keyboard.c (Vdelayed_warnings_list): Doc fix.
8391
8bc53d00
EZ
83922012-04-01 Eli Zaretskii <eliz@gnu.org>
8393
8394 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
8395 instead of alloca. (Bug#11138)
8396
3b0512a3
AS
83972012-04-01 Andreas Schwab <schwab@linux-m68k.org>
8398
8399 * w32menu.c (is_simple_dialog): Properly check lisp types.
8400 (Bug#11141)
8401
8427ddd2
EZ
84022012-03-31 Eli Zaretskii <eliz@gnu.org>
8403
979022ef
EZ
8404 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
8405 position we get to after a call to move_it_to fails the
8406 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
8407 only if we wind up in a string from display property. (Bug#11063)
8408
a6b1c7cc
EZ
8409 * window.c (Fdelete_other_windows_internal): Invalidate the row
8410 and column information about mouse highlight, so that redisplay
8411 restores it after reallocating the glyph matrices. (Bug#7464)
8412
8427ddd2
EZ
8413 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
8414 string comes from a `display' text property, use the buffer
8415 position of that property as if we actually saw that position in
8416 the row's glyphs.
697ba24b
EZ
8417 (move_it_by_lines): Remove the assertion that
8418 "it->current_x == 0 && it->hpos == 0" which can be legitimately
8419 violated when there's a before-string at the beginning of a line.
8420 (Bug#11063)
8427ddd2 8421
65a0a738
EZ
84222012-03-30 Eli Zaretskii <eliz@gnu.org>
8423
8424 * xdisp.c (append_space_for_newline): If the default face was
8425 remapped, use the remapped face for the appended newline.
8426 (extend_face_to_end_of_line): Use the remapped default face for
8427 extending the face to the end of the line.
8428 (display_line): Call extend_face_to_end_of_line when the default
8429 face was remapped. (Bug#11068)
8430
581355cc
EZ
84312012-03-29 Eli Zaretskii <eliz@gnu.org>
8432
8433 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
8434
e8fc049f
SM
84352012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8436
8437 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
8438
4fb9a543
GM
84392012-03-27 Glenn Morris <rgm@gnu.org>
8440
8441 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
8442 Doc fixes.
8443
679910f1
KH
84442012-03-26 Kenichi Handa <handa@m17n.org>
8445
8446 * dispextern.h (struct glyph): Fix previous change. Change the
8447 bit length of glyphless.ch to 25 (Bug#11082).
8448
90d49b7f
CY
84492012-03-26 Chong Yidong <cyd@gnu.org>
8450
8451 * keyboard.c (Vselection_inhibit_update_commands): New variable.
8452 (command_loop_1): Use it; inhibit selection update for
8453 handle-select-window too (Bug#8996).
8454
f514f6f0
FP
84552012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
8456
e8fc049f 8457 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 8458
bf43fa51
KH
84592012-03-25 Kenichi Handa <handa@m17n.org>
8460
8461 * dispextern.h (struct glyph): Change the bit length of
8462 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
8463
8a0c01dd
EZ
84642012-03-24 Eli Zaretskii <eliz@gnu.org>
8465
8466 * s/ms-w32.h (tzname): Include time.h before redirecting to
8467 _tzname. Fixes the MSVC build. (Bug#9960)
8468
7d1c3a76
AS
84692012-03-24 Andreas Schwab <schwab@linux-m68k.org>
8470
8ed79523
AS
8471 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
8472 characters.
8473
7d1c3a76
AS
8474 * xterm.c (XTread_socket): Only modify handling_signal if
8475 !SYNC_INPUT. (Bug#11080)
8476
e99a9b8b
EZ
84772012-03-23 Eli Zaretskii <eliz@gnu.org>
8478
8479 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
8480 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
8481 when fetching a multibyte character consumes more bytes than
8482 CHAR_BYTES returns, due to unification of CJK characters in
8483 string_char. (Bug#11073)
8484
5063c0e1
TN
84852012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
8486
8487 * process.c (wait_reading_process_output): Handle pty disconnect
8488 by refraining from sending oneself a SIGCHLD (bug#10933).
8489
9f851fbd
CY
84902012-03-22 Chong Yidong <cyd@gnu.org>
8491
8492 * dispextern.h (struct it): New member string_from_prefix_prop_p.
8493
5063c0e1 8494 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
8495 Mark string as coming from a prefix property.
8496 (handle_face_prop): Use default face for prefix strings (Bug#4281).
8497 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
8498
fb5b8aca
CY
84992012-03-21 Chong Yidong <cyd@gnu.org>
8500
8501 * xfaces.c (Vface_remapping_alist): Doc fix.
8502
62356a1b
EZ
85032012-03-20 Eli Zaretskii <eliz@gnu.org>
8504
8505 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
8506 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
8507 Doc fixes.
62356a1b 8508
025de85b
CY
85092012-03-20 Chong Yidong <cyd@gnu.org>
8510
8511 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
8512 to reflect default non-nil value of redisplay-dont-pause.
8513
4827f94e
KH
85142012-03-19 Kenichi Handa <handa@m17n.org>
8515
8516 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
8517 it fit in a valid range (Bug#11003).
8518
e50a24a2
EZ
85192012-03-18 Eli Zaretskii <eliz@gnu.org>
8520
8521 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
8522 that is not from display property, accept the row as a "cursor
8523 row" if one of the string's character has a non-nil `cursor'
8524 property. Fixes cursor positioning when there are newlines in
8525 overlay strings, e.g. in icomplete.el. (Bug#11035)
8526
9af5ed87
PE
85272012-03-12 Paul Eggert <eggert@cs.ucla.edu>
8528
8529 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
8530
d1f55f16
CY
85312012-03-12 Chong Yidong <cyd@gnu.org>
8532
8533 * eval.c (inhibit_lisp_code): Rename from
8534 inhibit_window_configuration_change_hook; move from window.c.
8535
8536 * xfns.c (unwind_create_frame_1, Fx_create_frame):
8537 * window.c (run_window_configuration_change_hook)
8538 (syms_of_window): Callers changed.
8539
66c5eebd
CY
85402012-03-11 Chong Yidong <cyd@gnu.org>
8541
413df973
CY
8542 * keymap.c (Fkey_description): Doc fix (Bug#9700).
8543
66c5eebd
CY
8544 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
8545
1de11f56
CY
85462012-03-10 Chong Yidong <cyd@gnu.org>
8547
8548 * frame.c (other_visible_frames): Don't assume the selected frame
8549 is visible (Bug#10955).
8550
cae07000
SM
85512012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
8552
8553 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
8554
89c94350
JD
85552012-03-08 Jan Djärv <jan.h.d@swipnet.se>
8556
8557 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
8558 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
8559 zero (Bug#10954).
8560
999dd333
GM
85612012-03-03 Glenn Morris <rgm@gnu.org>
8562
01a6dcc8 8563 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 8564
de0100f2
EZ
85652012-03-02 Eli Zaretskii <eliz@gnu.org>
8566
8567 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
8568 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
8569 (redisplay_window, next_element_from_string): Fix typos in
8570 comments.
3e441275
EZ
8571 (redisplay_window): Pass to move_it_vertically the margin in
8572 pixels, not in screen lines.
de0100f2 8573
96a72ee9
GM
85742012-03-02 Glenn Morris <rgm@gnu.org>
8575
8576 * buffer.c (buffer-list-update-hook): Doc fix.
8577
312508d7
EZ
85782012-02-29 Eli Zaretskii <eliz@gnu.org>
8579
8580 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
8581 push_it before setting up the iterator for the first overlay
8582 string, even if we have an empty string loaded.
8583 (next_overlay_string): If there's an empty string on the iterator
8584 stack, pop the stack. (Bug#10903)
8585
27f3c637
PE
85862012-02-25 Paul Eggert <eggert@cs.ucla.edu>
8587
8588 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
8589 Suggested by Stefan Monnier in
8590 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
8591 * alloc.c (widen_to_Lisp_Object): New static function.
8592 (mark_memory): Also mark Lisp_Objects by fetching pointer words
8593 and widening them to Lisp_Objects. This would work even if
8594 USE_LSB_TAG is defined and wide integers are used, which might
8595 happen in a future version of Emacs.
8596
3c9dfce6
CY
85972012-02-25 Chong Yidong <cyd@gnu.org>
8598
fa74b241
CY
8599 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
8600 Doc fix.
8601
3c9dfce6
CY
8602 * xselect.c (Fx_selection_exists_p): Doc fix.
8603 (x_clipboard_manager_save_all): Print an informative message
8604 before saving to clipboard manager.
8605
9486df08
CY
86062012-02-24 Chong Yidong <cyd@gnu.org>
8607
8608 * keyboard.c (process_special_events): Handle all X selection
8609 requests in kbd_buffer, not just the next one (Bug#8869).
8610
f01d3321
CY
86112012-02-23 Chong Yidong <cyd@gnu.org>
8612
8613 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
8614 call when setting menu-bar-lines and tool-bar-lines parameters.
8615 (unwind_create_frame_1): New helper function.
8616
8617 * window.c (inhibit_window_configuration_change_hook): New var.
8618 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 8619 (syms_of_window): Initialize it.
f01d3321 8620
86b847b6
CY
86212012-02-22 Chong Yidong <cyd@gnu.org>
8622
8623 * xterm.c (x_draw_image_relief): Add missing type check for
8624 Vtool_bar_button_margin (Bug#10743).
8625
a59225b1
CY
86262012-02-21 Chong Yidong <cyd@gnu.org>
8627
8628 * fileio.c (Vfile_name_handler_alist): Doc fix.
8629
8630 * buffer.c (Fget_file_buffer): Protect against invalid file
8631 handler return value.
8632
310f5bd4
PE
86332012-02-20 Paul Eggert <eggert@cs.ucla.edu>
8634
cb3a28cc
PE
8635 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
8636 when computing $valmask.
8637
310f5bd4
PE
8638 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
8639 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
8640 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
8641 It's useless in that case, and it can cause problems on hosts
8642 that allocate halves of EMACS_INT values separately.
8643 Reported by Dan Horák. Diagnosed by Andreas Schwab in
8644 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
8645 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
8646 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
8647 it avoids undefined behavior on hosts where shifting right by more
8648 than the word width has undefined behavior.
8649
2375c96a
CY
86502012-02-19 Chong Yidong <cyd@gnu.org>
8651
8652 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
8653 (Funhandled_file_name_directory, Ffile_name_as_directory)
8654 (Fdirectory_file_name, Fexpand_file_name)
8655 (Fsubstitute_in_file_name): Protect against invalid file handler
8656 return values (Bug#10845).
8657
3eb49e71
EZ
86582012-02-18 Eli Zaretskii <eliz@gnu.org>
8659
8660 * .gdbinit (pitx): Fix incorrect references to fields of the
8661 iterator stack.
8662
7b926f3f
CY
86632012-02-17 Chong Yidong <cyd@gnu.org>
8664
8665 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
8666
11273115
PE
86672012-02-15 Paul Eggert <eggert@cs.ucla.edu>
8668
8669 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
8670 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
8671
c3a70e2b
CY
86722012-02-15 Chong Yidong <cyd@gnu.org>
8673
8674 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
8675 marked as special. Also, starting docstrings with * is obsolete.
8676
0ca43699
AS
86772012-02-13 Andreas Schwab <schwab@linux-m68k.org>
8678
8679 * gnutls.c (emacs_gnutls_write): Fix last change.
8680
2e8f3c56
LI
86812012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
8682
8683 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
8684 send_process.
8685
af70074f
SM
86862012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
8687
8688 * keymap.c (Fsingle_key_description): Handle char ranges.
8689
95986d52
CY
86902012-02-12 Chong Yidong <cyd@gnu.org>
8691
afd83bd1
CY
8692 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
8693 as that creates a dangerous corner case.
8694
95986d52
CY
8695 * window.c (Fdelete_window_internal): Invalidate the mouse
8696 highlight (Bug#9904).
8697
bd7da63e
GM
86982012-02-12 Glenn Morris <rgm@gnu.org>
8699
8700 * xselect.c (Fx_own_selection_internal)
8701 (Fx_get_selection_internal, Fx_disown_selection_internal)
8702 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
8703 * nsselect.m (Fx_own_selection_internal)
8704 (Fx_disown_selection_internal, Fx_selection_exists_p)
8705 (Fx_selection_owner_p, Fx_get_selection_internal):
8706 Sync docs and argument specs with the xselect.c versions.
8707
77abcbc2
LI
87082012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
8709
8710 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
8711
90b671e2
EZ
87122012-02-11 Eli Zaretskii <eliz@gnu.org>
8713
1c0ca0b7
EZ
8714 * w32select.c (Fx_selection_exists_p): Sync doc string and
8715 argument list with xselect.c. (Bug#10783)
8716
8717 * w16select.c (Fx_selection_exists_p): Sync doc string and
8718 argument list with xselect.c. (Bug#10783)
90b671e2 8719
49241268
GM
87202012-02-10 Glenn Morris <rgm@gnu.org>
8721
8722 * fns.c (Fsecure_hash): Doc fix.
8723
f998bbe7 87242012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
8725
8726 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
8727
0992bd9c
CY
87282012-02-07 Chong Yidong <cyd@gnu.org>
8729
8730 * buffer.c (Fbuffer_local_variables)
8731 (buffer_lisp_local_variables): Handle unbound vars correctly;
8732 don't let Qunbound leak into Lisp.
8733
af008560
GM
87342012-02-07 Glenn Morris <rgm@gnu.org>
8735
dd605cc4
GM
8736 * image.c (Fimagemagick_types): Doc fix.
8737
af008560
GM
8738 * image.c (imagemagick-render-type): Change it from a lisp object
8739 to an integer. Move the doc here from the lisp manual.
8740 Treat all values not equal to 0 the same.
8741
1449fa1d
CY
87422012-02-06 Chong Yidong <cyd@gnu.org>
8743
8744 * doc.c (store_function_docstring): Avoid applying docstring of
8745 alias to base function (Bug#2603).
8746
3723ec07
AS
87472012-02-04 Andreas Schwab <schwab@linux-m68k.org>
8748
8749 * .gdbinit (pp1, pv1): Remove redundant defines.
8750 (pr): Use pp.
8751
79c1cc1e
CY
87522012-02-04 Chong Yidong <cyd@gnu.org>
8753
8754 * nsterm.m: Declare a global (Bug#10694).
8755
d7f29f8e
EZ
87562012-02-04 Eli Zaretskii <eliz@gnu.org>
8757
cae07000
SM
8758 * w32.c (get_emacs_configuration_options):
8759 Include --enable-checking, if specified, in the return value.
d7f29f8e 8760
3b95a6f9
MR
87612012-02-04 Martin Rudalics <rudalics@gmx.at>
8762
8763 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
8764 after rounding frame sizes. (Bug#9723)
8765
d6fa96a6
EZ
87662012-02-04 Eli Zaretskii <eliz@gnu.org>
8767
8768 * keyboard.c (adjust_point_for_property): Don't position point
8769 before BEGV. (Bug#10696)
8770
df0b2940
PE
87712012-02-03 Paul Eggert <eggert@cs.ucla.edu>
8772
8773 Handle overflow when computing char display width (Bug#9496).
8774 * character.c (char_width): Return EMACS_INT, not int.
8775 (char_width, c_string_width): Check for overflow when
8776 computing the width; this is possible now that individual
8777 characters can have unbounded width. Problem introduced
8778 by merge from Emacs 23 on 2012-01-19.
8779
6bee44d6
MA
87802012-02-02 Michael Albinus <michael.albinus@gmx.de>
8781
8782 * dbusbind.c (Fdbus_register_method): Mention the return value
8783 :ignore in the docstring.
8784
44f92739
GM
87852012-02-02 Glenn Morris <rgm@gnu.org>
8786
1b9f60cc
GM
8787 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
8788
44f92739
GM
8789 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
8790 Unconditionally set to t. (Bug#10673)
8791 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
8792 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
8793 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
8794
c5d3843c
KH
87952012-02-02 Kenichi Handa <handa@m17n.org>
8796
8797 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
8798 0, do not call append_composite_glyph.
8799
159462d4 88002012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
8801
8802 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
8803 NULL (Bug#6988).
8804 (x_produce_glyphs): If the component of a composition is a null
8805 string, set it->pixel_width to 1 to avoid zero-width glyph.
8806
78cef877
EZ
88072012-02-01 Eli Zaretskii <eliz@gnu.org>
8808
8809 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
8810 first 2 arguments are identical. This makes inserting large
8811 output from a subprocess an order of magnitude faster on
8812 MS-Windows, where all sbrk'ed memory is always contiguous.
8813
97897668
GM
88142012-01-31 Glenn Morris <rgm@gnu.org>
8815
8816 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 8817 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
8818 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
8819
31fd3586
GM
88202012-01-29 Glenn Morris <rgm@gnu.org>
8821
8822 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
8823
0e24a8b2
CY
88242012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
8825
8826 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
8827
cc0adcb0
CY
88282012-01-28 Chong Yidong <cyd@gnu.org>
8829
8830 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
8831
acc28cb9
CY
88322012-01-26 Chong Yidong <cyd@gnu.org>
8833
9c69cfb7
CY
8834 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
8835
acc28cb9
CY
8836 * search.c (Fsearch_forward, Fsearch_backward): Document negative
8837 repeat counts (Bug#10507).
8838
48da7392
GM
88392012-01-26 Glenn Morris <rgm@gnu.org>
8840
8841 * lread.c (syms_of_lread): Doc fix.
8842
14af5f7f
CY
88432012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
8844
8845 * coding.c (encode_designation_at_bol): Change return value to
8846 EMACS_INT.
8847
0b21c100
CY
88482012-01-25 Chong Yidong <cyd@gnu.org>
8849
8850 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
8851
3c2907f7
CY
88522012-01-21 Chong Yidong <cyd@gnu.org>
8853
8854 * floatfns.c (Fcopysign): Make the second argument non-optional,
8855 since nil is not allowed anyway.
8856
959ad23f
AS
88572012-01-21 Andreas Schwab <schwab@linux-m68k.org>
8858
8859 * process.c (read_process_output): Use p instead of XPROCESS (proc).
8860 (send_process): Likewise.
8861
34a02f46
MR
88622012-01-19 Martin Rudalics <rudalics@gmx.at>
8863
8864 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
8865 (Vwindow_persistent_parameters): Do not use Qstate.
8866 Rewrite doc-strings.
34a02f46 8867
1259009a 88682012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
8869
8870 * character.c (char_width): New function.
70d4fdf6
GM
8871 (Fchar_width, c_string_width, lisp_string_width):
8872 Use char_width (Bug#9496).
25ed9e61 8873
6a6ee00d
MR
88742012-01-16 Martin Rudalics <rudalics@gmx.at>
8875
8876 * window.c (Vwindow_persistent_parameters): New variable.
8877 (Fset_window_configuration, save_window_save): Handle persistent
8878 window parameters.
8879
c85efaf7
EZ
88802012-01-14 Eli Zaretskii <eliz@gnu.org>
8881
8882 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
8883 thrashing the stack of the thread. (Bug#9087)
8884
5944709e
PE
88852012-01-12 Paul Eggert <eggert@cs.ucla.edu>
8886
8887 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
8888
e71f5d99
EZ
88892012-01-11 Eli Zaretskii <eliz@gnu.org>
8890
8891 * xdisp.c (rows_from_pos_range): Handle the case where the
8892 highlight ends on a newline. (Bug#10464)
8893 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
8894 he end column for display of highlight that ends on a newline
8895 before a R2L line.
8896
ce316182
GM
88972012-01-11 Glenn Morris <rgm@gnu.org>
8898
8899 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
8900 from load-path also when installation-directory is nil. (Bug#10208)
8901
5b43da69
GM
89022012-01-10 Glenn Morris <rgm@gnu.org>
8903
74cc8ff9
GM
8904 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
8905
7d8d6e4e
GM
8906 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
8907 Update template values to be closer to their typical values these days.
5b43da69 8908
a0db8d43
EZ
89092012-01-09 Eli Zaretskii <eliz@gnu.org>
8910
8911 * xdisp.c (rows_from_pos_range): Accept additional argument
8912 DISP_STRING, and accept any glyph in a row whose object is that
8913 string as eligible for mouse highlight. Fixes mouse highlight of
8914 display strings from overlays. (Bug#10464)
8915
9a0115ab 89162012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 8917
b9110d6a 8918 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
8919 * fileio.c (auto_saving_dir_umask): New static var.
8920 (Fmake_directory_internal): Use it.
8921 (do_auto_save_make_dir): Set it, instead of invoking chmod after
8922 creating the directory. The old code temporarily assigns
8923 too-generous permissions to the directory.
8924 (do_auto_save_eh): Clear it.
b9110d6a 8925 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
8926 that the var is always cleared.
8927
6c1bd3f3
EZ
89282012-01-07 Eli Zaretskii <eliz@gnu.org>
8929
8930 * search.c (scan_buffer): Pass character positions to
8931 know_region_cache, not byte positions. (Bug#6540)
8932
069d2b50
L
89332012-01-07 LynX <_LynX@bk.ru> (tiny change)
8934
8935 * w32.c (sys_rename): Report EXDEV when rename of a directory
8936 fails because the target is on another logical disk. (Bug#10284)
8937
75bf0d33
DB
89382012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
8939
8940 * xterm.c (x_embed_request_focus): New function.
8941
8942 * xterm.h: Add prototype.
8943
8944 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
8945
1c6e5a32
GM
89462012-01-05 Glenn Morris <rgm@gnu.org>
8947
8948 * emacs.c (emacs_copyright): Update short copyright year to 2012.
8949
651e947e
EZ
89502012-01-01 Eli Zaretskii <eliz@gnu.org>
8951
8952 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
8953 Load gnutls_transport_set_lowat only if GnuTLS version is below
8954 2.11.1.
8955 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
8956 GnuTLS versions below 2.11.1.
8957
3778cdd8
AL
89582011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
8959
8960 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
8961 to the doc string advising against its use for altering the way
8962 windows are scrolled.
8963
0e5317f7
KH
89642011-12-28 Kenichi Handa <handa@m17n.org>
8965
8966 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
8967 coding-system ASCII compatible only when it does not produce BOM
8968 on encoding (Bug#10383).
8969
93d5ca1f
JD
89702011-12-26 Jan Djärv <jan.h.d@swipnet.se>
8971
8972 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
8973 can scroll.
8974 (create_and_show_popup_menu): Always use menu_position_func for
8975 Gtk3 (Bug#10361).
8976
ca22b785
AS
89772011-12-24 Andreas Schwab <schwab@linux-m68k.org>
8978
8979 * callint.c (Fcall_interactively): Don't truncate prompt string.
8980
d048e1e6
EZ
89812011-12-23 Eli Zaretskii <eliz@gnu.org>
8982
8983 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
8984 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 8985 resumed from there (after widening). (Bug#10360)
d048e1e6 8986
5ccaba1f
JD
89872011-12-22 Jan Djärv <jan.h.d@swipnet.se>
8988
8989 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
8990
204ee57f
JD
89912011-12-21 Jan Djärv <jan.h.d@swipnet.se>
8992
b81d40f0
JB
8993 * nsterm.m (x_free_frame_resources):
8994 Release f->output_data.ns->miniimage.
204ee57f
JD
8995 (ns_index_color): Fix indentation. Do not retain
8996 color_table->colors[i].
8997
8998 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
8999 before returning.
9000
9001 * nsfns.m (x_set_background_color): Assign return value from
9002 ns_index_color to face-background instead of NSColor*.
9003 (ns_implicitly_set_icon_type): Fix indentation.
9004 Change assignment in for loop to comparison.
9005
9006 * emacs.c (ns_pool): New variable.
9007 (main): Assign ns_pool.
9008 (Fkill_emacs): Call ns_release_autorelease_pool.
9009
9010 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
9011 autorelease fdesc, release fdAttrs and tdict.
9012 (ns_get_covering_families): Release charset.
9013 (ns_findfonts): Release NSFontDescriptor created with new.
9014 (ns_uni_to_glyphs): Fix indentation.
9015 (setString): Release attrStr before assigning new value.
9016
c803b2b7
JD
90172011-12-18 Jan Djärv <jan.h.d@swipnet.se>
9018
678f4426
JD
9019 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
9020 and NS_IMPL_COCOA.
9021 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
9022 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
9023
cd394be1 90242011-12-18 David Reitter <reitter@cmu.edu>
678f4426 9025
5fecd5fc
JD
9026 * nsterm.m (ns_term_init): Subscribe for notifications
9027 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
9028 to method trackingNotification in EmacsMenu.
9029
9030 * nsmenu.m (trackingMenu): New variable.
3771cb17 9031 (trackingNotification): New method (from Aquamacs).
5fecd5fc 9032 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 9033 from Aquamacs (Bug#7030).
678f4426
JD
9034
90352011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 9036
c803b2b7
JD
9037 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
9038 (symbol_to_nsstring): Fix indentation.
9039 (ns_symbol_to_pb): New function.
cae07000
SM
9040 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
9041 (Fns_rotate_cut_buffers_internal): Remove.
9042 (Fns_store_selection_internal): Rename from
c803b2b7
JD
9043 Fns_store_cut_buffer_internal.
9044 (ns_get_foreign_selection, Fx_own_selection_internal)
9045 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
9046 (Fns_get_selection_internal, Fns_store_selection_internal):
9047 Use ns_symbol_to_pb and check if return value is nil.
9048 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
9049 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
9050 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
9051 renamed to Sns_store_selection_internal.
9052 (ns_handle_selection_request): Move code to Fx_own_selection_internal
9053 and remove this function.
9054 (ns_handle_selection_clear): Remove, never used.
9055 (Fx_own_selection_internal): Move code from ns_handle_selection_request
9056 here.
9057
e1b01a3a
KB
90582011-12-17 Ken Brown <kbrown@cornell.edu>
9059
9060 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
9061 GID is unknown (Bug#10257).
9062
2adb6e85
PE
90632011-12-17 Paul Eggert <eggert@cs.ucla.edu>
9064
9065 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
9066 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
9067 which caused a build failure on GNU/Linux IA-64. This problem was
9068 introduced by my 2011-10-07 patch.
9069
d1d7b339
JL
90702011-12-15 Juri Linkov <juri@jurta.org>
9071
9072 * image.c (imagemagick_error): New function. (Bug#10112)
9073 (imagemagick_load_image): Comment out `MagickSetResolution' call.
9074 Use `imagemagick_error' where ImageMagick functions return
9075 `MagickFalse'.
9076 (Fimagemagick_types): Add `Fnreverse' to return the list in the
9077 proper order.
9078
100d5755
KH
90792011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9080
9081 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
9082 fill background (Bug#8992).
9083
454592a6
MR
90842011-12-13 Martin Rudalics <rudalics@gmx.at>
9085
9086 * window.c (Vwindow_combination_resize)
9087 (Vwindow_combination_limit): Use t instead of non-nil in
9088 doc-strings.
61d4b438
MR
9089 (Vrecenter_redisplay): Add first sentence of doc-string on
9090 separate line.
53524d93 9091 (Frecenter): Fix doc-string typo.
454592a6 9092
3633e3aa
KH
90932011-12-11 Kenichi Handa <handa@m17n.org>
9094
9095 * coding.c (Funencodable_char_position): Pay attention to the
9096 buffer text relocation (Bug#9389).
9097
7b9d523a 90982011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 9099
7b9d523a
JD
9100 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
9101 gtk_init (Bug#10100).
9102
b73189c6
EZ
91032011-12-10 Eli Zaretskii <eliz@gnu.org>
9104
9105 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
9106 IT->string is nil. (Bug#10263)
9107
f7dfe5d6
JD
91082011-12-10 Jan Djärv <jan.h.d@swipnet.se>
9109
83faebb4
JD
9110 * nsterm.h (x_free_frame_resources): Declare.
9111
f7dfe5d6
JD
9112 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
9113 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
9114
9115 * nsterm.h (ns_get_defaults_value): Declare.
9116
9117 * nsterm.m (ns_default): Call ns_get_defaults_value.
9118
7cd4e72c
EZ
91192011-12-09 Eli Zaretskii <eliz@gnu.org>
9120
9121 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
9122 (Bug#10170)
9123
b34d7317
YM
91242011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9125
9126 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
9127 that where the value of an _OBJC_* symbol points to is in the .bss
9128 section (Bug#10240).
9129
76470ad1
KH
91302011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
9131
9132 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 9133 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 9134
745fff94
KH
91352011-12-08 Kenichi Handa <handa@m17n.org>
9136
9137 * ftfont.c (get_adstyle_property): Fix previous change
9138 (Bug#10233).
9139
6e44397c
JB
91402011-12-07 Juanma Barranquero <lekktu@gmail.com>
9141
9142 * w32.c (init_environment): If no_site_lisp, remove site-lisp
9143 dirs from the default value of EMACSLOADPATH (bug#10208).
9144
7efa6272
GM
91452011-12-07 Glenn Morris <rgm@gnu.org>
9146
9147 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
9148 installation and source directories as well. (Bug#10208)
9149
f6fc4d87
CY
91502011-12-06 Chong Yidong <cyd@gnu.org>
9151
9152 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
9153
2bf26180
GM
91542011-12-06 Glenn Morris <rgm@gnu.org>
9155
9156 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
9157 as an error, not just -1. (Bug#10217)
9158
3a6ad4f0
CY
91592011-12-05 Chong Yidong <cyd@gnu.org>
9160
9161 * keyboard.c (process_special_events): New function.
9162 (swallow_events, Finput_pending_p): Use it (Bug#10195).
9163
75a3b399
PE
91642011-12-05 Paul Eggert <eggert@cs.ucla.edu>
9165
9166 * coding.c (encode_designation_at_bol): Don't use uninitialized
9167 local variable (Bug#9318).
9168
c3c9e25e
KH
91692011-12-05 Kenichi Handa <handa@m17n.org>
9170
9171 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
9172 return Qnil (Bug#8046, Bug#10193).
9173
5eb05ea3
KH
91742011-12-05 Kenichi Handa <handa@m17n.org>
9175
9176 * coding.c (encode_designation_at_bol): New args charbuf_end and
9177 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
9178 (coding_set_source): Return how many bytes coding->source was
9179 relocated.
9180 (coding_set_destination): Return how many bytes
9181 coding->destination was relocated.
9182 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 9183 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
9184
91852011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
9186
9187 * coding.c (CODING_CHAR_CHARSET_P): New macro.
9188 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
9189 macro (Bug#9318).
9190
91912011-12-05 Andreas Schwab <schwab@linux-m68k.org>
9192
9193 The following changes are to fix Bug#9318.
9194
a79703f5 9195 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
9196 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
9197 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 9198 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 9199
7dbda6df
JB
92002011-12-05 Juanma Barranquero <lekktu@gmail.com>
9201
9202 * lisp.h (process_quit_flag): Fix external declaration.
9203
6d5eb5b0
SM
92042011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
9205
9206 Don't macro-inline non-performance-critical code.
9207 * eval.c (process_quit_flag): New function.
9208 * lisp.h (QUIT): Use it.
9209
a0c3fad0
JD
92102011-12-04 Jan Djärv <jan.h.d@swipnet.se>
9211
9212 * nsfns.m (get_geometry_from_preferences): New function.
9213 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
9214
6c07aac2
AS
92152011-12-04 Andreas Schwab <schwab@linux-m68k.org>
9216
9217 * emacs.c (Qkill_emacs): Define.
9218 (syms_of_emacs): Initialize it.
9219 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
9220 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
9221 (quit_throw_to_read_char): Add parameter `from_signal'.
9222 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
9223 * lisp.h (QUIT): Call Fkill_emacs if requested.
9224
c052ead4
JD
92252011-12-03 Jan Djärv <jan.h.d@swipnet.se>
9226
9227 * widget.c (update_wm_hints): Return if wmshell is null.
9228 (widget_update_wm_size_hints): New function.
9229
9230 * widget.h (widget_update_wm_size_hints): Declare.
9231
9232 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
9233 widget_update_wm_size_hints (Bug#10104).
9234
9e49252b
EZ
92352011-12-03 Eli Zaretskii <eliz@gnu.org>
9236
9237 * xdisp.c (handle_invisible_prop): If the invisible text ends just
9238 before a newline, prepare the bidi iterator for consuming the
9239 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 9240 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 9241
02b16839
JL
92422011-12-02 Juri Linkov <juri@jurta.org>
9243
9244 * search.c (Fword_search_regexp): New Lisp function created from
9245 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
9246 (Fword_search_backward, Fword_search_forward)
9247 (Fword_search_backward_lax, Fword_search_forward_lax):
9248 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
9249 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
9250
0068070e
SM
92512011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
9252
9253 * fileio.c (Finsert_file_contents): Move after-change-function call
9254 to before the "handled:" label, since all "goto handled" appear in
9255 cases where the *-change-functions have already been properly called
9256 (bug#10117).
9257
3360a3fc
AS
92582011-12-01 Andreas Schwab <schwab@linux-m68k.org>
9259
9260 * keyboard.c (interrupt_signal): Don't call kill-emacs when
9261 waiting for input. (Bug#10169)
9262
73d6c093
EZ
92632011-11-30 Eli Zaretskii <eliz@gnu.org>
9264
9265 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
9266 verifies glyph row's hash code--we have just reallocated the
9267 glyphs, so their contents can be complete garbage. (Bug#10164)
9268
febe6bea
JB
92692011-11-30 Juanma Barranquero <lekktu@gmail.com>
9270
9271 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
9272
801a4313
EZ
92732011-11-30 Eli Zaretskii <eliz@gnu.org>
9274
9275 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
9276 attributes are tested _before_ calling verify_row_hash, to protect
9277 against GCC re-ordering of the tests. (Bug#10164)
9278
2b56b87e
JD
92792011-11-29 Jan Djärv <jan.h.d@swipnet.se>
9280
9281 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
9282
9283 * xterm.c (handle_one_xevent): Only set async_visible and friends
9284 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 9285 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
9286 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
9287
dbf31225
PE
92882011-11-28 Paul Eggert <eggert@cs.ucla.edu>
9289
9290 Remove GCPRO-related macros that exist only to avoid shadowing locals.
9291 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
9292 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
9293 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
9294 All uses changed to use GCPRO1 etc.
9295 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
9296 Revert to old implementation (i.e., before 2011-03-11).
9297
1305621b
YM
92982011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9299
9300 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
9301 of scroll runs so as to avoid assigning disabled bogus rows and
9302 unnecessary graphics copy operations.
9303
8c9afb46
EZ
93042011-11-27 Eli Zaretskii <eliz@gnu.org>
9305
9306 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
9307 (snprintf) [_MSC_VER]: Redirect to _snprintf.
9308 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
9309 (malloc, free, realloc, calloc): Redirect to e_* only when
9310 compiling Emacs.
9311
9312 * lisp.h (GCTYPEBITS): Move before first use.
9313 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
9314 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
9315 this macro definition.
9316
9317 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
9318 _MSC_VER.
9319
54e9e3bf
JD
93202011-11-27 Jan Djärv <jan.h.d@swipnet.se>
9321
6d5eb5b0
SM
9322 * gtkutil.c (xg_create_frame_widgets):
9323 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
9324 present with Gtk+ 2.0.
9325
83aca1cb
PE
93262011-11-26 Paul Eggert <eggert@cs.ucla.edu>
9327
9328 * fileio.c (Finsert_file_contents): Undo previous change; see
9329 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
9330
5b76caa4
PE
93312011-11-26 Paul Eggert <eggert@cs.ucla.edu>
9332
9333 Rename locals to avoid shadowing.
9334 * fileio.c (Finsert_file_contents):
9335 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
9336 * process.c (wait_reading_process_output):
9337 Rename inner 'proc' to 'p' to avoid shadowing.
9338 Indent for consistency with usual Emacs style.
9339
8c535114
EZ
93402011-11-25 Eli Zaretskii <eliz@gnu.org>
9341
9342 * xdisp.c (redisplay_window): If cursor row is not fully visible
9343 after recentering, and scroll-conservatively is set to a large
9344 number, scroll window by a few more lines to make the cursor fully
9345 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
9346 (start_display): Don't move to the next line if the display should
9347 start at a newline that is part of a display vector or an overlay
9348 string. (Bug#10119)
8c535114 9349
fa4fdb5c
JL
93502011-11-24 Juri Linkov <juri@jurta.org>
9351
9352 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
9353 after the `MagickPingImage' call. (Bug#10112)
9354
90ec88df
CY
93552011-11-23 Chong Yidong <cyd@gnu.org>
9356
9357 * window.c (Fcoordinates_in_window_p): Accept only live windows.
9358
56e2e794
MR
93592011-11-23 Martin Rudalics <rudalics@gmx.at>
9360
9361 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
9362 making another buffer current. (Bug#10114)
9363
b6e64c41
GM
93642011-11-23 Glenn Morris <rgm@gnu.org>
9365
9366 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
9367
6b21de18
CY
93682011-11-23 Chong Yidong <cyd@gnu.org>
9369
9370 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
9371 using it (Bug#5984).
9372
b12cd789
EZ
93732011-11-22 Eli Zaretskii <eliz@gnu.org>
9374
9375 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
9376 and header-lines, as they don't have one computed for them.
9377 (Bug#10098)
9378
9379 * .gdbinit (prow): Make displayed values more self-explaining.
9380 Add row's hash code.
9381
261b6fd4
LMI
93822011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
9383
9384 * process.c (wait_reading_process_output): Fix asynchrounous
9385 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 9386 (wait_reading_process_output): Add comment and URL.
261b6fd4 9387
e7cfd277
JD
93882011-11-21 Jan Djärv <jan.h.d@swipnet.se>
9389
9390 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
9391
a9b9b7f5
CY
93922011-11-21 Chong Yidong <cyd@gnu.org>
9393
9394 * window.c (Fnext_window, Fprevious_window): Doc fix.
9395
b0d15b4f
SM
93962011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
9397
9398 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
9399
fe7a3057
JB
94002011-11-20 Juanma Barranquero <lekktu@gmail.com>
9401
9402 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
9403
d2999b1a
MR
94042011-11-20 Martin Rudalics <rudalics@gmx.at>
9405
9406 * window.c (Fset_window_combination_limit): Rename argument
9407 STATUS to LIMIT.
9408 (Vwindow_combination_limit): Remove "status" from doc-string.
9409
d5ff9cd0
AS
94102011-11-20 Andreas Schwab <schwab@linux-m68k.org>
9411
9412 * m/ibms390.h: Remove.
9413 * m/ibms390x.h: Don't include "ibms390.h".
9414
a5bb9bd3
SM
94152011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
9416
9417 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
9418 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
9419
cd1181db
JB
94202011-11-20 Juanma Barranquero <lekktu@gmail.com>
9421
9422 * casetab.c (Fset_case_table):
9423 * charset.c (Fcharset_after): Fix typos.
9424
615a3b8d 94252011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 9426
17e845af
PE
9427 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
9428 Otherwise, valgrind does not work on some platforms.
9429 Problem reported by Andreas Schwab in
6a0bf43d
PE
9430 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
9431 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
9432 is set, removing the need for VIRT_ADDRESS_VARIES.
9433 (PURE_P): Use a more-efficient implementation that needs just one
9434 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
9435 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
9436 to 4 (xorl, subq, cmpq, setbe).
9437 * alloc.c (pure): Always extern now, since that's the
9438 VIRT_ADDR_VARIES behavior.
9439 (PURE_POINTER_P): Use a single comparison, not two, for
9440 consistency with the new puresize.h.
9441 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
9442 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
9443 Remove VIRT_ADDR_VARIES no longer needed.
9444
f8fe6f96
EZ
94452011-11-19 Eli Zaretskii <eliz@gnu.org>
9446
9447 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
9448 (erase_phys_cursor, update_window_cursor, show_mouse_face)
9449 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
9450 behave as if the cursor position were at the window margin.
9451
9452 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
9453 and the cursor position is out of bounds, behave as if the cursor
9454 position were at the window margin. (Bug#10075)
9455
df05a53c
CY
94562011-11-18 Chong Yidong <cyd@gnu.org>
9457
9458 * window.c (Fwindow_combination_limit): Make first argument
9459 non-optional, since it is meaningless for live windows like the
9460 selected window.
61ccba97 9461
2071918e
DA
94622011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
9463
9464 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
9465
b50a28de
SM
94662011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
9467
9468 * intervals.c: Fix grafting over the whole buffer (bug#10071).
9469 (graft_intervals_into_buffer): Simplify.
9470
015137db
EZ
94712011-11-18 Eli Zaretskii <eliz@gnu.org>
9472
9473 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
9474 hash values of the two rows.
9475 (copy_row_except_pointers): Preserve the used[] arrays and the
9476 hash values of the two rows. (Bug#10035)
68c95424 9477 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
9478
9479 * xdisp.c (row_hash): New function, body extracted from
9480 compute_line_metrics.
9481 (compute_line_metrics): Call row_hash, instead of computing the
9482 hash code inline.
9483
9484 * dispnew.c (verify_row_hash): Call row_hash for computing the
9485 hash code of a row, instead of duplicating code from xdisp.c.
9486
9487 * dispextern.h (row_hash): Add prototype.
9488
a2addb04
TH
94892011-11-18 Tassilo Horn <tassilo@member.fsf.org>
9490
9491 * frame.c (delete_frame): Don't delete the terminal when the last
9492 X frame is closed if emacs is built with GTK toolkit.
9493
df85d315
JB
94942011-11-17 Juanma Barranquero <lekktu@gmail.com>
9495
9496 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
9497
a0c2d0ae
MR
94982011-11-17 Martin Rudalics <rudalics@gmx.at>
9499
9500 * window.c (Vwindow_splits): Rename to
9501 Vwindow_combination_resize. Suggested by Juri Linkov.
9502 (Fsplit_window_internal): Use Vwindow_combination_resize instead
9503 of Vwindow_splits.
9504
58179cce
JB
95052011-11-16 Juanma Barranquero <lekktu@gmail.com>
9506
7877f373
JB
9507 * nsfns.m (Fns_font_name):
9508 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 9509
b6f67890
MR
95102011-11-16 Martin Rudalics <rudalics@gmx.at>
9511
9512 * window.h (window): Rename slot "nest" to "combination_limit".
9513 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
9514 (Fset_window_nest): Rename to Fset_window_combination_limit.
9515 (Vwindow_nest): Rename to Vwindow_combination_limit.
9516 (recombine_windows, make_parent_window, make_window)
9517 (Fsplit_window_internal, saved_window)
9518 (Fset_window_configuration, save_window_save): Rename all
9519 occurrences of window_nest to window_combination_limit.
9520
c7015153
JB
95212011-11-15 Juanma Barranquero <lekktu@gmail.com>
9522
9523 * image.c (imagemagick_load_image): Fix typo.
9524
322ad6ec
EZ
95252011-11-14 Eli Zaretskii <eliz@gnu.org>
9526
9527 * xdisp.c (display_line): Move the call to
9528 highlight_trailing_whitespace before the call to
9529 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
9530 faces of all the glyphs to compute ROW's hash value.
9531 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 9532
f067b8ec
JB
95332011-11-14 Juanma Barranquero <lekktu@gmail.com>
9534
9535 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
9536 just return (bug#10044).
9537
1e5b2111
EZ
95382011-11-12 Eli Zaretskii <eliz@gnu.org>
9539
7ef3cbd5
EZ
9540 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
9541 with user-defined heap size. Bump the default size of the temacs
9542 heap to 27MB, to avoid memory warning when running temacs.
9543 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
9544
1e5b2111
EZ
9545 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
9546 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
9547 (verify_row_hash) [XASSERTS]: New function.
9548 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
9549 that the hash value of glyph rows is correct.
1e5b2111 9550
89d61221
MR
95512011-11-12 Martin Rudalics <rudalics@gmx.at>
9552
9553 * window.h (window): Remove splits slot.
9554 * window.c (Fwindow_splits, Fset_window_splits): Remove.
9555 (Fdelete_other_windows_internal, make_parent_window)
9556 (make_window, Fsplit_window_internal, Fdelete_window_internal)
9557 (Fset_window_configuration, save_window_save): Don't deal with
9558 split status of windows.
9559 (saved_window): Remove splits slot.
9560 (Vwindow_splits): Rewrite doc-string.
9561
97f18cc8
JD
95622011-11-11 Jan Djärv <jan.h.d@swipnet.se>
9563
9564 * xfns.c (unwind_create_frame):
9565 * nsfns.m (unwind_create_frame):
9566 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
9567 Vframe_list (Bug#9999).
9568
22a648b4
DA
95692011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
9570
0b381c7e 9571 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 9572
659afede
KH
95732011-11-11 Kenichi Handa <handa@m17n.org>
9574
9575 * callproc.c (Fcall_process): Set the member dst_multibyte of
9576 process_coding.
9577
9ac0394b
KH
95782011-11-11 Johan Bockgård <bojohan@gnu.org>
9579
9580 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
9581 avoid a crash (bug#9496).
9582
2fbdc249
CY
95832011-11-09 Chong Yidong <cyd@gnu.org>
9584
9585 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
9586 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
9587
ac6b1f81
PE
95882011-11-08 Paul Eggert <eggert@cs.ucla.edu>
9589
9590 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
9591
09db192c
PE
95922011-11-08 Paul Eggert <eggert@cs.ucla.edu>
9593
9594 Avoid some portability problems by eschewing 'extern inline' functions.
9595 The trivial performance wins aren't worth the portability hassles; see
9596 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
9597 et seq.
9598 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
9599 (window_box_width, window_box_left, window_box_left_offset)
9600 (window_box_right, window_box_right_offset): Undo previous change,
9601 by removing the "extern"s.
9602 * intervals.c (adjust_intervals_for_insertion)
9603 (adjust_intervals_for_deletion): Undo previous change,
9604 making these static again.
9605 (offset_intervals, temp_set_point_both, temp_set_point)
9606 (copy_intervals_to_string): No longer inline.
9607 * xdisp.c (window_text_bottom_y, window_box_width)
9608 (window_box_height, window_box_left_offset)
9609 (window_box_right_offset, window_box_left, window_box_right)
9610 (window_box): No longer inline.
9611
105216ed
CY
96122011-11-08 Chong Yidong <cyd@gnu.org>
9613
9614 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
9615 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
9616 Signal an error if not a live window.
105216ed
CY
9617 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
9618 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
9619
ae9e237f
JB
96202011-11-07 Juanma Barranquero <lekktu@gmail.com>
9621
9622 * lisp.h (syms_of_abbrev): Remove declaration.
9623 Reported by CHENG Gao <chenggao@royau.me>.
9624
c7aa8333
EZ
96252011-11-07 Eli Zaretskii <eliz@gnu.org>
9626
9627 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
9628 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
9629 of temacs in GUI mode.
9630
be7f5545
MR
96312011-11-07 Martin Rudalics <rudalics@gmx.at>
9632
9633 * window.h: Declare delete_all_child_windows instead of
9634 delete_all_subwindows.
9635 * window.c (Fwindow_nest, Fset_window_nest)
9636 (Fset_window_new_total, Fset_window_new_normal)
9637 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
9638 (delete_all_subwindows): Rename to delete_all_child_windows.
9639 (Fdelete_other_windows_internal, Fset_window_configuration):
9640 Call delete_all_child_windows instead of delete_all_subwindows.
9641 * frame.c (delete_frame): Call delete_all_child_windows instead
9642 of delete_all_subwindows.
9643
ca78dc43
PE
96442011-11-07 Paul Eggert <eggert@cs.ucla.edu>
9645
9646 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
9647 This is also needed for porting to any host where GC_MARK_STACK is
9648 not GC_MAKE_GCPROS_NOOPS.
9649 (which_symbols): Use it.
9650
a0241d01
KH
96512011-11-07 Kenichi Handa <handa@m17n.org>
9652
9653 * coding.c (coding_set_destination): Check coding->src_pos only
9654 when coding->src_object is a buffer (bug#9910).
9655
9656 * process.c (send_process): Set the member src_multibyte of coding
9657 to 0 (bug#9911) when sending a unibyte text.
9658
9659 * callproc.c (Fcall_process): Set the member src_multibyte of
9660 process_coding to 0 (bug#9912).
9661
a64bfdfa 96622011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
9663
9664 * xmenu.c (cleanup_widget_value_tree): New function.
9665 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
9666 calling free_menubar_widget_value_tree directly (Bug#9830).
9667
cb41b32a
PE
96682011-11-06 Paul Eggert <eggert@cs.ucla.edu>
9669
9670 Fix some portability problems with 'inline'.
9671 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
9672 (window_box_width, window_box_left, window_box_left_offset)
9673 (window_box_right, window_box_right_offset): Declare extern.
9674 Otherwise, these inline functions do not conform to C99 and
9675 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
9676 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
9677 * intervals.c (adjust_intervals_for_insertion)
9678 (adjust_intervals_for_deletion): Now extern, because otherwise the
9679 extern inline functions 'offset_intervals' couldn't refer to it.
9680 (static_offset_intervals): Remove.
9681 (offset_intervals): Rewrite using the old contents of
9682 static_offset_intervals. The old version didn't conform to C99
9683 because an extern inline function contained a reference to an
9684 identifier with static linkage.
9685
b7041366
AS
96862011-11-06 Andreas Schwab <schwab@linux-m68k.org>
9687
9688 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
9689 GC.
9690
88a37c4d
EZ
96912011-11-06 Eli Zaretskii <eliz@gnu.org>
9692
9693 * xdisp.c (init_iterator, reseat_to_string): Don't set the
9694 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
9695 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
9696 return Qleft_to_right.
9697
49745b39
CY
96982011-11-06 Chong Yidong <cyd@gnu.org>
9699
9700 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
9701 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
9702 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
9703 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
9704 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
9705 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
9706 (Fwindow_vscroll): Doc fix.
9707 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
9708 argument, since it makes no sense to pass a live window and for
9709 consistency with window-child.
9710
1f05cd82
CS
97112011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
9712
9713 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
9714 support MSVC.
9715
22610910
JR
97162011-11-05 Jason Rumney <jasonr@gnu.org>
9717
9718 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
9719 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
9720 fonts (Bug#6029).
9721 (add_font_entity_to_list): Fix logic errors in mixed boolean and
9722 bitwise arithmetic preventing use of unicode-sip and non-truetype
9723 opentype fonts.
9724
a06776b2
EZ
97252011-11-05 Eli Zaretskii <eliz@gnu.org>
9726
3ad924ba
EZ
9727 * s/ms-w32.h (fstat, stat, utime): Move redirections to
9728 "emacs"-only part.
9729
a06776b2
EZ
9730 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
9731 initialization code to keep similarity to xfns.c after changes
9732 from 2011-11-05.
9733
c9e7db78
JD
97342011-11-05 Jan Djärv <jan.h.d@swipnet.se>
9735
a97f8f3f
JD
9736 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
9737 (unwind_create_frame): New function (Bug#9943).
9738 (Fx_create_frame): Restructure code to be more similar to the one in
9739 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
9740 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
9741 Move terminal->reference_count++ just before making the frame official
9742 (Bug#9943).
9743
9744 * nsterm.m (x_free_frame_resources): New function.
9745 (x_destroy_window): Move code to x_free_frame_resources.
9746
c9e7db78 9747 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
9748 (Fx_create_frame, x_create_tip_frame):
9749 Move terminal->reference_count++ just before making the frame
75f1671a 9750 official. Move initialization of image_cache_refcount and
c9e7db78
JD
9751 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
9752
a6fc3b5c
EZ
97532011-11-05 Eli Zaretskii <eliz@gnu.org>
9754
9755 Support MSVC build with newer versions of Visual Studio.
9756 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
9757 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
9758 nt/gmake.defs.
9759
9760 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
9761 which are not supported by MSVC.
9762 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
9763 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
9764 bitfields.
9765 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
9766 types in bitfields.
9767 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
9768
9769 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
9770
58179cce 97712011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
9772
9773 Support MSVC build with newer versions of Visual Studio.
9774 * w32.c: Don't include w32api.h for MSVC.
9775 (init_environment) [_MSC_VER]: Call sys_access, not _access.
9776
9777 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
9778 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
9779 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
9780 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
9781 e_* cousins.
9782 (alloca) [_MSC_VER]: Define to _alloca.
9783
9784 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
9785
9786 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
9787
a58c13ed
EZ
97882011-11-04 Eli Zaretskii <eliz@gnu.org>
9789
9790 * xdisp.c (note_mouse_highlight): If either of
9791 previous/next-single-property-change returns nil, treat that as
9792 the beginning or the end of the buffer. (Bug#9955)
9793
fe0b6370
JD
97942011-11-04 Jan Djärv <jan.h.d@swipnet.se>
9795
a58c13ed 9796 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
9797 label is not null (Bug#9951).
9798 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
9799 may be NULL.
9800
89bd5ee1
EZ
98012011-11-04 Eli Zaretskii <eliz@gnu.org>
9802
9803 * window.c (Fwindow_body_size): Mention in the doc string that the
9804 return value is in frame's canonical units. (Bug#9949)
9805
84c3edb9
EZ
98062011-11-03 Eli Zaretskii <eliz@gnu.org>
9807
4e2fb5c7
EZ
9808 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
9809
84c3edb9 9810 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 9811 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 9812 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 9813
bc17a887
EZ
98142011-11-01 Eli Zaretskii <eliz@gnu.org>
9815
9816 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
9817 Don't stop backward scan on the continuation glyph, even though
9818 its CHARPOS is positive.
6d5eb5b0
SM
9819 (mouse_face_from_buffer_pos, note_mouse_highlight):
9820 Rename cover_string to disp_string.
bc17a887 9821
4ee88440
MR
98222011-11-01 Martin Rudalics <rudalics@gmx.at>
9823
9824 * window.c (temp_output_buffer_show): Don't use
9825 Vtemp_buffer_show_specifiers.
9826 (Vtemp_buffer_show_specifiers): Remove unused variable.
9827
c2ff3c02
EZ
98282011-10-30 Eli Zaretskii <eliz@gnu.org>
9829
9830 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
9831 past the beginning of the current glyph matrix.
9832
58179cce 98332011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
9834
9835 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
9836 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
9837 HAVE_GTK3 (Bug#9869).
b77a6a7f 9838
3b574623
JD
9839 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
9840 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
9841
b77a6a7f
JD
9842 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
9843
9844 * xterm.c: Declare x_handle_net_wm_state to return int.
9845 (handle_one_xevent): Check if we are iconified but don't have
9846 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
9847 (get_current_wm_state): Return non-zero if not hidden,
9848 check for _NET_WM_STATE_HIDDEN (Bug#9893).
9849 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
9850 (x_handle_net_wm_state): Return what get_current_wm_state returns.
9851 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
9852
196e41e4
PE
98532011-10-29 Paul Eggert <eggert@cs.ucla.edu>
9854
9855 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
9856 so that this new function doesn't get optimized away by a
9857 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
9858
021f2e1a
AS
98592011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9860
9861 * frame.h (MOUSE_HL_INFO): Remove excess parens.
9862
8b058d44
EZ
98632011-10-29 Eli Zaretskii <eliz@gnu.org>
9864
9865 Fix the `xbytecode' command.
9866 * .gdbinit (xprintbytestr): New command.
b50a28de 9867 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
9868 (xbytecode): Print the byte-code string as well.
9869
4452fb80
EZ
98702011-10-29 Kim Storm <storm@cua.dk>
9871
8b058d44
EZ
9872 * alloc.c (which_symbols): New function.
9873
21b72067
AS
98742011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9875
9876 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
9877 line. (Bug#9903)
9878
83ed7b5c
GM
98792011-10-29 Glenn Morris <rgm@gnu.org>
9880
9881 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
9882 Not clear what it was for, and it causes various bugs. (Bug#9839)
9883
5a7a728b
EZ
98842011-10-28 Eli Zaretskii <eliz@gnu.org>
9885
9886 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
9887 possible random value that matches one of those tested as
9888 condition to clear the mouse face.
9889
d3d0842f
CY
98902011-10-28 Chong Yidong <cyd@gnu.org>
9891
9892 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
9893
31b39d13
DN
98942011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
9895
9896 * window.c (make_window): Initialize phys_cursor_on_p.
9897
9aba6043
SM
98982011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
9899
9900 * lisp.h (struct Lisp_Symbol): Update comments.
9901
c20992f4
JB
99022011-10-28 Juanma Barranquero <lekktu@gmail.com>
9903
9904 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
9905
db4f02f2
EZ
99062011-10-28 Eli Zaretskii <eliz@gnu.org>
9907
9908 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
9909 <oslsachem@gmail.com> for helping to debug this.
9910
9911 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
9912 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
9913 (g_b_init_get_glyph_outline_w): New static variables.
9914 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
9915 (GetGlyphOutlineW_Proc): New typedefs.
9916 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
9917 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
9918 New functions.
9919 (w32font_open_internal, compute_metrics):
9920 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
9921 instead of calling the "wide" APIs directly.
9922
9923 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
9924
9925 * w32.h (syms_of_w32font): Add prototype.
9926
87e68db4
JB
99272011-10-27 Juanma Barranquero <lekktu@gmail.com>
9928
9929 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
9930 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
9931 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
9932 (Fmove_to_window_line): Doc fix.
9933
435c1d67
CY
99342011-10-27 Chong Yidong <cyd@gnu.org>
9935
9936 * process.c (make_process): Set gnutls_state to NULL.
9937
9938 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
9939 non-NULL, regardless of GNUTLS_INITSTAGE.
9940 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
9941 an error. Set process slots as soon as we allocate them.
9942
9943 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
9944
9c6c6f49
CY
99452011-10-27 Chong Yidong <cyd@gnu.org>
9946
9aba6043
SM
9947 * gnutls.c (emacs_gnutls_deinit): New function.
9948 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
9949 (Fgnutls_deinit, Fgnutls_boot): Use it.
9950
9951 * process.c (make_process): Initialize GnuTLS credentials to NULL.
9952 (deactivate_process): Call emacs_gnutls_deinit.
9953
657d08d3
JB
99542011-10-27 Juanma Barranquero <lekktu@gmail.com>
9955
9956 * image.c (x_create_x_image_and_pixmap):
9957 * w32.c (sys_rename, w32_delayed_load):
9958 * w32font.c (fill_in_logfont):
9959 * w32reg.c (x_get_string_resource): Silence compiler warnings.
9960
5430d399
JB
99612011-10-26 Juanma Barranquero <lekktu@gmail.com>
9962
9963 * w32fns.c (w32_default_color_map): New function,
9964 extracted from Fw32_default_color_map.
a7ef684b 9965 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 9966
fe0055fa
PE
99672011-10-25 Paul Eggert <eggert@cs.ucla.edu>
9968
9969 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
9970
e6346438
SM
99712011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
9972
9973 * keyboard.c (test_undefined): New function (bug#9751).
9974 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
9975
e112cc37
ET
99762011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
9977
9978 * sysdep.c (init_sys_modes): Fix the check for the controlling
9979 terminal (Bug#6649).
9980
7b5d6677
EZ
99812011-10-20 Eli Zaretskii <eliz@gnu.org>
9982
9983 * dispextern.h (struct bidi_it): New member next_en_type.
9984
9985 * bidi.c (bidi_line_init): Initialize the next_en_type member.
9986 (bidi_resolve_explicit_1): When next_en_pos is valid for the
9987 current character, check also for next_en_type being WEAK_EN.
9988 (bidi_resolve_weak): Don't enter the expensive loop if the current
9989 position is before next_en_pos. Record the bidi type of the first
9990 non-ET, non-BN character we find, in addition to its position.
9991 (bidi_level_of_next_char): Invalidate next_en_type when
9992 next_en_pos is over-stepped.
9993
7da0b018
PE
99942011-10-20 Paul Eggert <eggert@cs.ucla.edu>
9995
9996 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
9997 * editfns.c: Rewrite current-time-zone so that it invokes
9998 the equivalent of (format-time-string "%Z") to get the time zone name.
9999 This fixes a bug when the time zone name contains characters that
10000 need converting from the system time locale to Emacs internal format.
10001 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
10002 that patch fixed format-time-string to do the conversion, but
10003 I forgot to fix current-time-zone.
10004 (format_time_string): New function, containing most of
10005 what Fformat_time_string used to contain.
10006 (Fformat_time_string): Rewrite in terms of format_time_string.
10007 This doesn't change this function's behavior.
10008 (current-time-zone): Rewrite to use format_time_string.
10009 This fixes the bug reported by Michael Schierl in
10010 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
10011 Jason Rumney's 2007-06-07 change worked around this bug, but
10012 didn't fix it.
10013 * systime.h (tzname, timezone): Remove no-longer-used declarations.
10014
8547b010
EZ
100152011-10-19 Eli Zaretskii <eliz@gnu.org>
10016
10017 * xdisp.c (start_display): If the character at POS is displayed
10018 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
10019 (try_window_reusing_current_matrix): If a line ends in a display
10020 vector or the next line starts in a display vector, continue
10021 redrawing the window even though the character position of
10022 start_row was reached.
8547b010
EZ
10023 (Bug#9771, part 2)
10024
4e948d15
CY
100252011-10-18 Chong Yidong <cyd@gnu.org>
10026
10027 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
10028 with nobreak-char-display too.
10029
4787455f
EZ
100302011-10-18 Eli Zaretskii <eliz@gnu.org>
10031
10032 Fix part 3 of bug#9771.
10033 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
10034 (bidi_resolve_neutral): Don't enter the expensive loop looking for
10035 non-neutral characters if the current character is a paragraph
10036 separator (a.k.a. Newline). This avoids running the same
10037 expensive loop twice, once when we consume the preceding newline
10038 and the other time when the line actually needs to be displayed.
10039 Avoid the loop when we see neutrals on the base embedding level
10040 following a character whose directionality is the same as the
10041 paragraph's. This avoids running the expensive loop when a line
10042 ends in a long sequence of neutrals, like control characters.
10043 Add assertion against STRONG_AL type. Slightly rearrange code
10044 that determines the type of a neutral given the first non-neutral
10045 that follows it.
10046 (bidi_level_of_next_char): Set next_en_pos to zero when
10047 invalidating its info.
10048
2c91f553
EZ
100492011-10-17 Eli Zaretskii <eliz@gnu.org>
10050
10051 * xdisp.c (push_display_prop): Determine whether to record string
10052 or buffer position by IT->string, not by IT->method. Allow
10053 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
10054 (move_it_vertically_backward): Don't look for character position
10055 immediately after the newline when in a continuation line.
10056 (Bug#9771, part 1)
2c91f553 10057
c7b08b0d
MR
100582011-10-15 Martin Rudalics <rudalics@gmx.at>
10059
10060 * window.c (coordinates_in_window): Rewrite and delabelize
10061 vertical border check. (Bug#5357) (Bug#9618)
10062
6b02f655
SM
100632011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
10064
10065 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
10066 errors in XSetWindowBorder (bug#9310).
10067
81d40c92
DA
100682011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
10069
10070 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
10071 avoid crash when xmalloc overrun checking is enabled.
10072
d4172c3b
EZ
100732011-10-13 Eli Zaretskii <eliz@gnu.org>
10074
10075 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
10076 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
10077 cursor motion with <left> and <right> arrow keys.
10078
10079 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
10080 some callers set that themselves.
10081
b00eea75
EZ
100822011-10-12 Eli Zaretskii <eliz@gnu.org>
10083
10084 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
10085 display string and the previous row comes from the same string and
10086 is empty. (Bug#9739) (Bug#9738)
10087
8fe012c4
SM
100882011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
10089
10090 * doc.c (get_doc_string): Encode file name (bug#9735).
10091
0074aef2
EZ
100922011-10-12 Eli Zaretskii <eliz@gnu.org>
10093
79beb178
EZ
10094 * bidi.c (bidi_level_of_next_char):
10095 * xdisp.c (get_visually_first_element): Remove old incorrect
10096 comments regarding the Unicode Line Separator character.
10097
0074aef2
EZ
10098 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
10099
6e4b3fbe
DA
101002011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
10101
10102 * alloc.c (Fgc_status): Do not access beyond zombies array
10103 boundary if nzombies > MAX_ZOMBIES.
10104 * alloc.c (dump_zombies): Add missing format specifier.
10105
0324f3af
PE
101062011-10-12 Paul Eggert <eggert@cs.ucla.edu>
10107
b5525cac
PE
10108 * xdisp.c (set_cursor_from_row): Simplify conditionals,
10109 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
10110
0324f3af
PE
10111 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
10112 Some packages use them to denote characters with modifiers.
10113
e9b5f888
AS
101142011-10-11 Andreas Schwab <schwab@linux-m68k.org>
10115
10116 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
10117 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
10118 matching a pp-number. Rename parameter var to var1.
10119
127827c0
SM
101202011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
10121
10122 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
10123
c8fd3bd0
GM
101242011-10-08 Glenn Morris <rgm@gnu.org>
10125
10126 * callint.c (Fcall_interactively): Give a more explicit error for the
10127 'c' case with a non-character input. (Bug#8479)
10128
352ec8ff
EZ
101292011-10-08 Eli Zaretskii <eliz@gnu.org>
10130
03669ccb
EZ
10131 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
10132 lines.
7061c986
EZ
10133 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
10134 lines that are hscrolled on the left.
03669ccb 10135
352ec8ff
EZ
10136 * dispnew.c (buffer_posn_from_coords): Account for a possible
10137 presence of header-line. (Bug#4426)
10138
a66cfb1c
SM
101392011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
10140
6b02f655
SM
10141 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
10142 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 10143
7c5ee88e
PE
101442011-10-07 Paul Eggert <eggert@cs.ucla.edu>
10145
10146 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
10147 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
10148 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
10149 this makes Emacs dump core during garbage collection on rare
10150 occasions. sizeof is obviously inferior to offsetof here, so
10151 stick with offsetof.
10152 (GC_POINTER_ALIGNMENT): New macro.
10153 (mark_memory): Omit 3rd (offset) arg; caller changed.
10154 Don't assume EMACS_INT alignment is the same as pointer alignment.
10155
df1bbe5b
SM
101562011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
10157
10158 * keyboard.c (read_key_sequence_remapped): New var.
10159 (read_key_sequence): Compute remapping in the right buffer.
10160 (command_loop_1): Use read_key_sequence's remapping directly.
10161
51553db6
SM
101622011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
10163
32c1fffd
SM
10164 * dired.c (file_name_completion): Don't expand file name.
10165 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
10166 before checking file name handler.
10167
51553db6
SM
10168 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
10169 they've been requested explicitly (bug#9591).
10170
b6bd1599 101712011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
10172
10173 * keymap.c (Fsingle_key_description): Use make_specified_string
10174 instead of build_string to build string from push_key_description.
10175 (Bug#5193)
10176
f701dc2a
PE
101772011-09-30 Paul Eggert <eggert@cs.ucla.edu>
10178
4222c55d
PE
10179 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
10180 This fixes a Y2038 bug on 64-bit hosts.
10181 * buffer.c (reset_buffer):
10182 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
10183 (Fclear_buffer_auto_save_failure):
10184 Use 0, not -1, to represent an unset failure time, since time_t
10185 might not be signed.
10186
f701dc2a
PE
10187 Remove dependency on glibc malloc internals.
10188 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10189 Move back here from lisp.h, but with their new implementations.
10190 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10191 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
10192 * charset.c (charset_table_init): New static var.
10193 (syms_of_charset): Use it instead of xmalloc. This removes a
10194 dependency on glibc malloc internals. See Eli Zaretskii's comment in
10195 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
10196 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10197 Move back to alloc.c.
10198 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10199 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
10200
9ceebf39
JD
102012011-09-30 Jan Djärv <jan.h.d@swipnet.se>
10202
10203 * nsterm.m (windowDidResize): Call x_set_window_size only when
10204 ns_in_resize is true. Otherwise set pixelwidth/height and
10205 call change_frame_size (Bug#9628).
10206
cb993c58
PE
102072011-09-30 Paul Eggert <eggert@cs.ucla.edu>
10208
3930c88b
PE
10209 Port --enable-checking=all to Fedora 14 x86-64.
10210 * charset.c (syms_of_charset): Also account for glibc malloc's
10211 internal overhead when calculating the initial malloc maximum.
10212
cb993c58
PE
10213 Port --enable-checking=all to Fedora 14 x86.
10214 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10215 Move to lisp.h.
10216 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
10217 (overrun_check_realloc, overrun_check_free):
10218 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
10219 That way, xmalloc returns a properly-aligned pointer even if
10220 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
10221 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
10222 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
10223 into account when calculating the initial malloc maximum.
10224 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10225 Move here from alloc.c, so that charset.c can use it too.
10226 Properly align; the old code wasn't right for common 32-bit hosts
10227 when configured with --enable-checking=all.
10228 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10229 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
10230
31bed486
EZ
102312011-09-29 Eli Zaretskii <eliz@gnu.org>
10232
04c70788 10233 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
10234 use EDOM.
10235
fbcaa2f3
EZ
102362011-09-28 Eli Zaretskii <eliz@gnu.org>
10237
10238 * xdisp.c (compute_display_string_end): If there's no display
10239 string at CHARPOS, return -1.
10240
10241 * bidi.c (bidi_fetch_char): When compute_display_string_end
10242 returns a negative value, treat the character as a normal
10243 character not covered by a display string. (Bug#9624)
10244
a239d4e9
JB
102452011-09-28 Juanma Barranquero <lekktu@gmail.com>
10246
10247 * lread.c (Fread_from_string): Fix typo in docstring.
10248
88652fd5
EZ
102492011-09-27 Eli Zaretskii <eliz@gnu.org>
10250
10251 * xdisp.c (handle_invisible_prop): If invisible text ends on a
10252 newline, reseat the iterator instead of bidi-iterating there one
10253 character at a time. (Bug#9610)
32c1fffd
SM
10254 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
10255 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 10256
ed497dd4
AS
102572011-09-27 Andreas Schwab <schwab@linux-m68k.org>
10258
10259 * lread.c (readevalloop): Use correct code for NBSP.
10260 (read1): Likewise. (Bug#9608)
10261
b2bf61aa
MA
102622011-09-25 Michael Albinus <michael.albinus@gmx.de>
10263
10264 * dbusbind.c (Fdbus_register_signal): When service is not
10265 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
10266
32bbb17c
GM
102672011-09-25 Glenn Morris <rgm@gnu.org>
10268
10269 * buffer.c (truncate-lines): Doc fix.
10270
94e0933e
CY
102712011-09-24 Chong Yidong <cyd@stupidchicken.com>
10272
10273 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
10274 (Fset_window_next_buffers): Doc fix.
10275
cddde921
GM
102762011-09-24 Glenn Morris <rgm@gnu.org>
10277
10278 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
10279
1260aef1
PE
102802011-09-24 Paul Eggert <eggert@cs.ucla.edu>
10281
25b4bfa0
PE
10282 Fix minor problems found by static checking.
10283 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
10284 * indent.c (Fvertical_motion): Fix == vs = typo.
10285
e3cbd34b
EZ
102862011-09-24 Eli Zaretskii <eliz@gnu.org>
10287
a66cfb1c
SM
10288 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
10289 Default value is now t. Doc fix.
6bf7006f 10290
e3cbd34b 10291 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 10292 logic when moving up, not only when moving down. Fix the
e3cbd34b 10293 confusing name and values of the it_overshoot_expected variable;
32c1fffd 10294 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
10295
10296 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
10297 CHARPOS is covered by a display string which includes newlines.
10298 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
10299 is covered by a display string with embedded newlines.
10300
a3de0cbd
MA
103012011-09-24 Michael Albinus <michael.albinus@gmx.de>
10302
10303 * dbusbind.c (Fdbus_register_signal): Add match rule to
10304 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
10305 (Fdbus_register_method, Vdbus_registered_objects_table):
10306 Fix docstring.
a3de0cbd 10307
b260039d
JM
103082011-09-24 Jim Meyering <meyering@redhat.com>
10309
32c1fffd 10310 do not ignore write error for any output size
b260039d
JM
10311 The previous change was incomplete.
10312 While it makes emacs --batch detect the vast majority of stdout
10313 write failures, errors were still ignored whenever the output size is
10314 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
10315 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
10316 && echo FAIL: ignored write error
10317 FAIL: ignored write error
10318 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
10319 && echo FAIL: ignored write error
10320 FAIL: ignored write error
10321 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
10322
8eca8a7c
AS
103232011-09-23 Andreas Schwab <schwab@linux-m68k.org>
10324
10325 * emacs.c (Fkill_emacs): In noninteractive mode exit
10326 non-successfully if a write error occurred on stdout. (Bug#9574)
10327
3341db62
EZ
103282011-09-21 Eli Zaretskii <eliz@gnu.org>
10329
10330 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
10331 the xassert test.
10332
10333 * dispextern.h (struct it): Update the comment documenting what
10334 can it->OBJECT be.
10335
8c203dbf
EZ
103362011-09-20 Eli Zaretskii <eliz@gnu.org>
10337
10338 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
10339 a display string, extend search for cursor position to end of row.
10340 (find_row_edges): If the row ends in a newline from a display
10341 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
10342 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
10343 (Fcurrent_bidi_paragraph_direction): Fix search for previous
10344 non-empty line. Fixes confusing cursor motion with arrow keys at
10345 the beginning of a line that starts with whitespace.
8c203dbf 10346
a4824228
LMI
103472011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
10348
10349 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
10350 (bug#9493).
10351
33ed493b
CY
103522011-09-18 Chong Yidong <cyd@stupidchicken.com>
10353
10354 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
10355 boolean (Bug#9154).
10356
56cd55c8
EZ
103572011-09-18 Eli Zaretskii <eliz@gnu.org>
10358
10359 * xdisp.c (display_line): Record maximum and minimum buffer
10360 positions even if no glyphs were produced (e.g., by a zero-width
10361 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
10362 buffer positions that will be removed from the glyph row because
10363 they don't fit.
c02dcedf
EZ
10364 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
10365 column is beyond frame width: don't subtract 1 "pixel" when
10366 computing width of the stretch.
3e62b7e0
EZ
10367 (reseat_at_next_visible_line_start): Undo the change made on
10368 2011-09-17 that saved paragraph information and restored it after
10369 the call to `reseat'. (Bug#9545)
56cd55c8 10370
5ed99d36 103712011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
10372
10373 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
10374 and turn window cursor on if cleared (Bug#9415).
10375
5ed99d36 103762011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
10377
10378 * search.c (boyer_moore): Take unibyte characters from pattern
10379 literally. (Bug#9458)
10380
9bade7b2
EZ
103812011-09-18 Eli Zaretskii <eliz@gnu.org>
10382
10383 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
10384
e5e9d610
PE
103852011-09-18 Paul Eggert <eggert@cs.ucla.edu>
10386
87e4427a
PE
10387 Fix minor problem found by static checking.
10388 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
10389 initialized, to pacify gcc -Wuninitialized.
10390
e5e9d610
PE
10391 * fileio.c: Report proper errno when syscall falls.
10392 (Finsert_file_contents): Save and restore errno,
10393 so that report_file_error outputs the correct diagnostic.
10394 (Fwrite_region) [CLASH_DETECTION]: Likewise.
10395
a1674f0b
EZ
103962011-09-18 Eli Zaretskii <eliz@gnu.org>
10397
10398 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
10399
fbfb6dd4
EZ
104002011-09-17 Eli Zaretskii <eliz@gnu.org>
10401
10402 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
10403 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
10404
bb187662
EZ
104052011-09-17 Eli Zaretskii <eliz@gnu.org>
10406
1137e8b8 10407 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 10408 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
10409
10410 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
10411 (bidi_find_paragraph_start): Search back for paragraph beginning
10412 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
10413 (bidi_move_to_visually_next): Only trigger paragraph-related
10414 computations when the last character is a newline or at EOB, not
10415 just any NEUTRAL_B. (Bug#9470)
10416
bb187662
EZ
10417 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
10418 truncated lines if point is covered by a display string. (Bug#9524)
10419
2e621251
PE
104202011-09-16 Paul Eggert <eggert@cs.ucla.edu>
10421
10422 * xselect.c: Relax test for outgoing X longs (Bug#9498).
10423 (cons_to_x_long): New function.
10424 (lisp_data_to_selection_data): Use it. Correct the test for
10425 short-versus-long data; it was negated. Break out of vector
10426 loop, for efficiency, when a long datum is discovered.
10427
91a15bc6
SM
104282011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
10429
10430 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
10431
b41c3a35
EZ
104322011-09-16 Eli Zaretskii <eliz@gnu.org>
10433
10434 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
10435 GCC PR/17406) by declaring this function with external scope.
10436
7812ba2d
PE
104372011-09-15 Paul Eggert <eggert@cs.ucla.edu>
10438
10439 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
10440 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
10441
cf7edc2a
AS
104422011-09-15 Andreas Schwab <schwab@linux-m68k.org>
10443
10444 * editfns.c (Fformat): Correctly handle text properties on "%%".
10445
bd01620e
EZ
104462011-09-15 Eli Zaretskii <eliz@gnu.org>
10447
10448 * xterm.c (x_draw_composite_glyph_string_foreground):
10449 * w32term.c (x_draw_composite_glyph_string_foreground):
10450 * term.c (encode_terminal_code):
10451 * composite.c (composition_update_it, get_composition_id):
10452 * xdisp.c (get_next_display_element)
10453 (fill_composite_glyph_string): Add comments about special meaning
10454 of TAB characters in a composition.
10455
a02719a3
PE
104562011-09-15 Paul Eggert <eggert@cs.ucla.edu>
10457
10458 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
10459 This occurs when processing a multibyte format.
10460 Problem reported by Wolfgang Jenker.
a02719a3 10461
72589a3c
JB
104622011-09-15 Johan Bockgård <bojohan@gnu.org>
10463
10464 * xdisp.c (try_cursor_movement): Only check for exact match if
10465 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
10466
1c14176c
PE
104672011-09-14 Paul Eggert <eggert@cs.ucla.edu>
10468
10469 Remove unused external symbols.
10470 * dispextern.h (calc_pixel_width_or_height): Remove decl.
10471 * xdisp.c (calc_pixel_width_or_height): Now static.
10472 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
10473 * indent.c (check_display_width):
10474 * w32term.c: Fix comment to match code.
10475 * xterm.c, xterm.h (x_catching_errors): Remove.
10476
d2eea5b5
PE
104772011-09-14 Paul Eggert <eggert@cs.ucla.edu>
10478
10479 * xselect.c: Use signed conversions more consistently (Bug#9498).
10480 (selection_data_to_lisp_data): Assume incoming selection data are
10481 signed integers, not unsigned. This is to be consistent with
10482 outgoing selection data, which was modified to use signed integers
10483 in as part of the fix to Bug#9196 in response to Jan D.'s comment
10484 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
10485 expects long, not unsigned long.
10486
46888499
EZ
104872011-09-14 Eli Zaretskii <eliz@gnu.org>
10488
10489 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
10490 computation of loop end. Reported by Johan Bockgård
10491 <bojohan@gnu.org>.
10492
ef8ef9fb
CY
104932011-09-13 Chong Yidong <cyd@stupidchicken.com>
10494
10495 * frame.c (Fother_visible_frames_p): Function deleted.
10496
fa819fed
EZ
104972011-09-12 Eli Zaretskii <eliz@gnu.org>
10498
10499 * indent.c (compute_motion): Process display vector front to back
10500 rather than the other way around. (Bug#2496)
10501
2ba8e008
SM
105022011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
10503
10504 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
10505
20f53c69
CY
105062011-09-11 Chong Yidong <cyd@stupidchicken.com>
10507
10508 * minibuf.c (Fread_from_minibuffer): Doc fix.
10509
d562d7a4
EZ
105102011-09-11 Eli Zaretskii <eliz@gnu.org>
10511
10512 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
10513 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
10514
1c4d7f3d
LMI
105152011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
10516
10517 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
10518 value for non-existent files.
10519
b885bf36
EZ
105202011-09-11 Eli Zaretskii <eliz@gnu.org>
10521
10522 * fileio.c (Finsert_file_contents): If the file cannot be opened,
10523 set its "size" to -1. This will set the modtime_size field of
10524 the corresponding buffer to -1, which is what
10525 verify-visited-file-modtime expects for files that do not exist.
10526 (Bug#9139)
10527
6612f0bf
PE
105282011-09-11 Paul Eggert <eggert@cs.ucla.edu>
10529
10530 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
10531 here ...
10532 * lisp.h: ... from here. push_key_description is no longer
10533 defined in keyboard.c, so its declaration should not be in
10534 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
10535 logically belongs with push_key_description.
10536
dfb3f755
PE
105372011-09-10 Paul Eggert <eggert@cs.ucla.edu>
10538
10539 * buffer.h: Include <sys/types.h> instead of <time.h>.
10540 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
10541 Problem reported by Herbert J. Skuhra.
10542
3134906c
LMI
105432011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
10544
10545 * xml.c (parse_region): Make the parsing work for
10546 non-comment-starting XML files again (bug#9144).
10547
8d903f4e
AS
105482011-09-10 Andreas Schwab <schwab@linux-m68k.org>
10549
10550 * image.c (gif_load): Fix calculation of bottom and right corner.
10551 (Bug#9468)
10552
80ad64f4
EZ
105532011-09-10 Eli Zaretskii <eliz@gnu.org>
10554
10555 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
10556 redisplay in small windows.
10557
208a048d
EZ
105582011-09-09 Eli Zaretskii <eliz@gnu.org>
10559
10560 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
10561
9b1c252e
MR
105622011-09-08 Martin Rudalics <rudalics@gmx.at>
10563
10564 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
10565 Operate on live windows only.
10566
2949f33b
JB
105672011-09-08 Juanma Barranquero <lekktu@gmail.com>
10568
10569 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
10570
e08dcafd
EZ
105712011-09-07 Eli Zaretskii <eliz@gnu.org>
10572
10573 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
10574 only under bidi iteration.
10575
115b96bd
JD
105762011-09-07 Jan Djärv <jan.h.d@swipnet.se>
10577
10578 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
10579
c8199d0f
PE
105802011-09-06 Paul Eggert <eggert@cs.ucla.edu>
10581
10582 isnan: Fix porting problem to Solaris 10 with bundled gcc.
10583 Without this fix, the command to link temacs failed due to an
10584 undefined symbol __builtin_isnan. This is because
10585 /usr/include/iso/math_c99.h #defines isnan(x) to
10586 __builtin_isnan(x), but the bundled gcc, which identifies itself
10587 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
10588 a __builtin_isnan.
10589 * floatfns.c (isnan): #undef, and then #define to a clone of
10590 what's in data.c.
10591 (Fisnan): Always define, since it's always available now.
10592 (syms_of_floatfns): Always define isnan at the Lisp level.
10593
e39b275c 105942011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
10595
10596 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
10597
b2db44d9 105982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 10599
f4af5137 10600 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
10601 The previous code assumed that file offsets (off_t values) fit in
10602 EMACS_INT variables, which is not true on typical 32-bit hosts.
10603 The code messed up by falsely reporting buffer overflow in cases
10604 such as (insert-file-contents "big" nil 1 2) into an empty buffer
10605 when "big" contains more than 2**29 bytes, even though this
10606 inserts just one byte and does not overflow the buffer.
10607 (Finsert_file_contents): Store file offsets as off_t
10608 values, not as EMACS_INT values. Check for overflow when
10609 converting between EMACS_INT and off_t. When checking for
10610 buffer overflow or for overlap, take the offsets into account.
10611 Don't use EMACS_INT for small values where int suffices.
10612 When checking for overlap, fix a typo: ZV was used where
10613 ZV_BYTE was intended.
10614 (Fwrite_region): Don't assume off_t fits into 'long'.
10615 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
10616
ecfc0a49
MA
106172011-09-05 Michael Albinus <michael.albinus@gmx.de>
10618
10619 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
10620
6511acf2 106212011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 10622
0999621a 10623 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
10624
10625 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 10626 (esprintf, exprintf, evxprintf): New functions.
62f19c19 10627 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 10628 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
10629 (modify_event_symbol): Do not assume that the length of
10630 name_alist_or_stem is safe to alloca and fits in int.
10631 (Fexecute_extended_command): Likewise for function name and binding.
10632 (Frecursion_depth): Wrap around reliably on integer overflow.
10633 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
10634 since some callers pass EMACS_INT values.
10635 (Fsingle_key_description): Don't crash if symbol name contains more
10636 than MAX_ALLOCA bytes.
10637 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
10638 (get_minibuffer): Arg is now EMACS_INT, not int.
10639 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 10640 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
10641 * window.h (command_loop_level, minibuf_level): Reflect API changes.
10642
2be7d702
PE
10643 * dbusbind.c (signature_cat): New function.
10644 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
10645 Do not overrun buffer; instead, report string overflow.
10646
9d1df220
PE
10647 * dispnew.c (add_window_display_history): Don't overrun buffer.
10648 Truncate instead; this is OK since it's just a log.
10649
33ef5c64
PE
10650 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
10651 even if the time zone offset is outlandishly large.
10652 Don't mishandle offset == INT_MIN.
10653
66c6fdd5
PE
10654 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
10655 when creating daemon; the previous buffer-overflow check was incorrect.
10656
d749b01b
PE
10657 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
10658 which has the guts of the old verror function.
10659
b5cd1905
PE
10660 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
10661 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
10662
6e1a67fb
PE
10663 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
10664 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 10665 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 10666 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
10667 length of string rather than counting it via multiple sprintfs;
10668 that's simpler and more reliable.
c21721cc
PE
10669 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
10670 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
10671 sprintf, in case result does not fit in int.
10672
c57b67fc
PE
10673 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
10674 (fontset_from_font): Print it.
10675
8a401434
PE
10676 * frame.c (tty_frame_count): Now printmax_t, not int.
10677 (make_terminal_frame, set_term_frame_name): Print it.
10678 (x_report_frame_params): In X, window IDs are unsigned long,
10679 not signed long, so print them as unsigned.
10680 (validate_x_resource_name): Check for implausibly long names,
10681 and don't assume name length fits in 'int'.
10682 (x_get_resource_string): Don't blindly alloca invocation name;
10683 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
10684 not fit in int.
10685
6e1a67fb
PE
10686 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
10687 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
10688 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
10689
0df02bf3
PE
10690 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
10691 Use esprintf, not sprintf, in case result does not fit in int.
10692
48e30793
PE
10693 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
10694 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
10695 it as a large positive number.
10696 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
10697 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
10698
a66ff6d8
PE
10699 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
10700 in case result does not fit in int.
10701
aca216ff
PE
10702 * print.c (float_to_string): Detect width overflow more reliably.
10703 (print_object): Make sprintf buffer a bit bigger, to avoid potential
10704 buffer overrun. Don't assume list length fits in 'int'. Treat
10705 print length of 0 as 0, not as infinity; to be consistent with other
10706 uses of print length in this function. Don't overflow print length
10707 index. Don't assume hash table size fits in 'long', or that
10708 vectorlike size fits in 'unsigned long'.
10709
31c286f7
PE
10710 * process.c (make_process): Use printmax_t, not int, to format
10711 process-name gensyms.
10712
55e5faa1
PE
10713 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
10714
80f2e268
PE
10715 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
10716 to avoid potential buffer overrun.
10717
670741ab
PE
10718 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
10719 if X resource line is longer than 512 bytes.
10720
b7163a50
PE
10721 * xfns.c (x_window): Make sprintf buffer a bit bigger
10722 to avoid potential buffer overrun.
10723
ae58ff1f
PE
10724 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
10725
c43c8a6a
PE
10726 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
10727
3f8236f4
PE
107282011-09-04 Paul Eggert <eggert@cs.ucla.edu>
10729
53e9fe90 10730 Integer overflow fixes for scrolling, etc.
6511acf2
PE
10731 Without these, Emacs silently mishandles large integers sometimes.
10732 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
10733 it were "C-u 1 M-x recenter" on a typical 64-bit host.
10734
6511acf2
PE
10735 * xdisp.c (try_window_id): Check Emacs fixnum range before
10736 converting to 'int'.
806add1d 10737
6511acf2 10738 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
10739 Check that an Emacs fixnum is in range before assigning it to 'int'.
10740 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
10741 values converted from Emacs fixnums.
10742 (Frecenter): Don't wrap around a line count if it is out of 'int'
10743 range; instead, treat it as an extreme value.
10744 (Fset_window_configuration, compare_window_configurations):
10745 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
10746
6511acf2
PE
10747 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
10748 that can exceed INT_MAX. Check that EMACS_INT value is in range
10749 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
10750 (match_limit): Don't assume that a fixnum can fit in 'int'.
10751
6511acf2 10752 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
10753 exceed INT_MAX.
10754
6511acf2 10755 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
10756 (Fvertical_motion): Don't wrap around LINES values that don't fit
10757 in 'int'. Instead, treat them as extreme values. This is good
10758 enough for windows, which can't have more than INT_MAX lines anyway.
10759
fcb901a7
LMI
107602011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10761
0f2f6b6d
LMI
10762 * Require libxml/parser.h to avoid compilation warning.
10763
fcb901a7
LMI
10764 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
10765
10766 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
10767 since this reportedly can destroy thread storage.
10768
6e20a0d4
CY
107692011-08-30 Chong Yidong <cyd@stupidchicken.com>
10770
10771 * syntax.c (find_defun_start): Update all cache variables if
10772 exiting early (Bug#9401).
10773
148ae00e
EZ
107742011-08-30 Eli Zaretskii <eliz@gnu.org>
10775
f6cfbd8f
EZ
10776 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
10777
148ae00e
EZ
10778 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
10779 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
10780 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
10781
10782 * term.c (tty_append_glyph): New function.
10783 (produce_stretch_glyph): Static function and its prototype deleted.
10784
a66cfb1c
SM
10785 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
10786 Add prototypes.
148ae00e 10787
c4a07a4c
PE
107882011-08-29 Paul Eggert <eggert@cs.ucla.edu>
10789
10790 * image.c (parse_image_spec): Check for nonnegative, not for positive,
10791 when checking :margin (Bug#9390).
10792 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 10793 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
10794 so that the name doesn't mislead. All uses changed.
10795
6bc8cd65
JB
107962011-08-28 Johan Bockgård <bojohan@gnu.org>
10797
10798 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
10799 set_tty_hooks.
10800
dca4927e
EZ
108012011-08-27 Eli Zaretskii <eliz@gnu.org>
10802
10803 * xdisp.c (move_it_to): Don't bail out early when reaching
10804 position beyond to_charpos, if we are scanning backwards.
10805 (move_it_vertically_backward): When DY == 0, make sure we get to
10806 the first character in the line after the newline.
10807
f2cad773
PE
108082011-08-27 Paul Eggert <eggert@cs.ucla.edu>
10809
10810 * ccl.c: Improve and simplify overflow checking (Bug#9196).
10811 (ccl_driver): Do not generate an out-of-range pointer.
10812 (Fccl_execute_on_string): Remove unnecessary check for
10813 integer overflow, noted by Stefan Monnier in
10814 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
10815 Remove a FIXME that didn't need fixing.
10816 Simplify the newly-introduced buffer reallocation code.
10817
0cae2cdb
JB
108182011-08-27 Juanma Barranquero <lekktu@gmail.com>
10819
10820 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
10821
5fc295a4 108222011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 10823
70c60eb2 10824 Integer and memory overflow issues (Bug#9196).
726e0ab1 10825
d31850da
PE
10826 * doc.c (get_doc_string): Rework so that
10827 get_doc_string_buffer_size is the actual buffer size, rather than
10828 being 1 less than the actual buffer size; this makes xpalloc more
10829 convenient.
10830
a69fbedb
PE
10831 * image.c (x_allocate_bitmap_record, cache_image):
10832 * xselect.c (Fx_register_dnd_atom):
10833 Simplify previous changes by using xpalloc.
10834
fe5c5d37
PE
10835 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
10836 since either will do and ptrdiff_t is convenient with xpalloc.
10837
0065d054
PE
10838 * charset.c (charset_table_size)
10839 (struct charset_sort_data.priority): Now ptrdiff_t.
10840 (charset_compare): Don't overflow if priorities differ greatly.
10841 (Fsort_charsets): Don't assume list length fits in int.
10842 Check for size-calculation overflow when allocating sort data.
10843 (syms_of_charset): Allocate an initial charset table that is
10844 just under 64 KiB, to avoid problems with glibc malloc and mmap.
10845
10846 * cmds.c (internal_self_insert): Check for size-calculation overflow.
10847
10848 * composite.h (struct composition.glyph_len): Now int, not unsigned.
10849 The actual value is always <= INT_MAX, and leaving it unsigned made
10850 overflow checking harder.
10851
10852 * dispextern.h (struct glyph_matrix.rows_allocated)
10853 (struct face_cache.size): Now ptrdiff_t, for convenience in use
10854 with xpalloc. The values are still always <= INT_MAX.
10855
10856 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
10857
10858 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
10859 (SAFE_NALLOCA): New macro.
10860
10861 * region-cache.c (struct boundary.pos, find_cache_boundary)
10862 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
10863 (set_cache_region, invalidate_region_cache)
10864 (revalidate_region_cache, know_region_cache, region_cache_forward)
10865 (region_cache_backward, pp_cache):
10866 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
10867 so that ptrdiff_t * can be passed to xpalloc.
10868 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
10869 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
10870 (pp_cache): Don't assume cache_len fits in int.
10871 * region-cache.h: Adjust extern decls to match.
10872
10873 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
10874 EMACS_INT, since either will do, for xpalloc.
10875
10876 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
10877 (xnmalloc, xnrealloc, xpalloc): New functions.
10878
726e0ab1
PE
10879 * bidi.c (bidi_shelve_header_size): New constant.
10880 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
10881 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
10882
51f30bc5 10883 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
10884 * buffer.c (overlays_at, overlays_in, record_overlay_string)
10885 (overlay_strings):
10886 Don't update size of array until after memory allocation succeeds,
10887 because xmalloc/xrealloc may not return.
0065d054
PE
10888 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
10889 now that we have proper integer overflow checking.
10890 (record_overlay_string, overlay_strings): Catch overflows when
10891 calculating size of overlay_str_buf.
726e0ab1 10892
0065d054
PE
10893 * callproc.c (Fcall_process): Check for size overflow when
10894 calculating size of args2.
10895 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
10896 Normally we prefer signed values, but sticking with ptrdiff_t would
10897 require adding more-complicated checks.
726e0ab1
PE
10898
10899 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
10900 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
10901 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 10902 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
10903
10904 * character.c (Fstring): Check for size-calculation overflow.
10905
10906 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
10907 unnecessary integer overflow. Check for size overflow.
10908 (encode_coding_object): Don't update size until xmalloc succeeds.
10909
10910 * composite.c (get_composition_id): Check for overflow in glyph
10911 length calculations.
10912
10913 Integer and memory overflow fixes for display code.
10914 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
10915 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
10916 (scrolling_window): Check for overflow in size calculations.
10917 (line_draw_cost, realloc_glyph_pool, add_row_entry):
10918 Don't assume glyph table len fits in int.
10919 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
10920 (row_table_size): Now ptrdiff_t, not int.
10921 (scrolling_window): Avoid overflow in size calculations.
10922 Don't update size until allocation succeeds.
10923 * fns.c (concat): Check for overflow in size calculations.
10924 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
10925 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
10926 (NEXT_ALMOST_PRIME_LIMIT): New constant.
10927
10928 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
10929 (get_doc_string): Check for size calculation overflow.
10930 Don't update size until allocation succeeds.
10931 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
10932 EMACS_INT, where ptrdiff_t will do.
10933 (Fsubstitute_command_keys): Check for string overflow.
10934
10935 * editfns.c (set_time_zone_rule): Don't assume environment length
10936 fits in int.
10937 (message_length): Now ptrdiff_t, not int.
10938 (Fmessage_box): Don't update size until allocation succeeds.
10939 Don't assume message length fits in int.
10940 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
10941
0065d054
PE
10942 * emacs.c (main): Do not reallocate argv, since there is a null at
10943 the end that can be overwritten, and this way there's no need to
10944 worry about size-calculation overflow.
10945 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
10946
10947 * eval.c (init_eval_once, grow_specpdl): Don't update size until
10948 alloc succeeds.
10949 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
10950
10951 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
10952 (x_set_scroll_bar_width, x_figure_window_size):
10953 Check for integer overflow.
10954 (x_set_alpha): Do not assume XINT fits in int.
10955
10956 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
10957 This is for the members text_lines, text_cols, total_lines, total_cols,
10958 where the system imposes an 'int' limit.
10959
10960 * fringe.c (Fdefine_fringe_bitmap):
10961 Don't update size until alloc works.
10962
10963 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
10964 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
10965
10966 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
10967 Check for size-calculation overflow.
10968 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
10969 do, as we prefer signed integers.
10970 (id_to_widget.max_size, id_to_widget.used)
10971 (xg_store_widget_in_map, xg_remove_widget_from_map)
10972 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
10973 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
10974 Use and return ptrdiff_t, not int.
10975 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
10976 * gtkutil.h: Change prototypes to match the above.
10977
10978 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
10979 are duplicate now that they've been promoted to lisp.h.
10980 (x_allocate_bitmap_record, x_alloc_image_color)
10981 (make_image_cache, cache_image, xpm_load):
10982 Don't update size until alloc is done.
10983 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
10984 (x_detect_edges):
3256efce 10985 Check for size calculation overflow.
726e0ab1
PE
10986 (ct_colors_allocated_max): New constant.
10987 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
10988 overflow.
3256efce 10989
726e0ab1
PE
10990 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
10991 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
10992 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
10993 Use ptrdiff_t, not int, to count maps.
10994 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
10995 calculations. Don't update size until allocation succeeds.
10996 Redo calculations to avoid overflow.
726e0ab1
PE
10997 * keyboard.h: Change prototypes to match the above.
10998
10999 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
11000 to count maps.
11001 (current_minor_maps): Check for size calculation overflow.
11002 * keymap.h: Change prototypes to match the above.
11003
11004 * lread.c (read1, init_obarray): Don't update size until alloc done.
11005
11006 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
11007 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
11008
726e0ab1
PE
11009 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
11010 Now ptrdiff_t, not int.
11011 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
11012 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
11013
11014 * process.c (Fnetwork_interface_list): Check for overflow
11015 in size calculation.
11016
11017 * region-cache.c (move_cache_gap): Check for size calculation overflow.
11018
11019 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
11020 overflow. Don't bother calling xmalloc when xrealloc will do.
11021
11022 * search.c (Freplace_match): Check for size calculation overflow.
11023 (Fset_match_data): Don't assume list lengths fit in 'int'.
11024
11025 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
11026 for command line length. Do not attempt to address one before the
11027 beginning of an array, as that's not portable.
11028
11029 * term.c (max_frame_lines): Remove; unused.
11030 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
11031 not int.
11032 (encode_terminal_code, calculate_costs): Check for size
11033 calculation overflow.
11034 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
11035 table lengths and related sizes. Don't update size until alloc
11036 done. Redo calculations to avoid overflow.
11037 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
11038
11039 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
11040 subtracting pointers.
11041 (gobble_line): Check for overflow more carefully. Don't update size
11042 until alloc done.
11043
11044 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
11045 Don't update size until alloc done.
11046 Redo size calculations to avoid overflow.
11047 Check for size calculation overflow.
0065d054 11048 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
11049
11050 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
11051 Use ptrdiff_t, not int, for sizes.
11052 (store_mode_line_noprop_char): Don't update size until alloc done.
11053
0065d054
PE
11054 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
11055 Use ptrdiff_t, not int, for sizes.
11056 (Finternal_make_lisp_face, cache_face):
11057 Check for size calculation overflow.
11058 (cache_face): Treat size calculation overflows as if they were
11059 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
11060
11061 * xfns.c (x_encode_text, x_set_name_internal)
11062 (Fx_change_window_property): Use ptrdiff_t, not int, to count
11063 sizes, since they can exceed INT_MAX in size. Check for size
11064 calculation overflow.
11065
0065d054
PE
11066 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
11067 (xg_select): Check for size calculation overflow.
726e0ab1
PE
11068 Don't update size until alloc done.
11069
0065d054 11070 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 11071 as sprintf is limited to int lengths.
1d526e2f 11072
252c5ee1
PE
11073 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
11074 (X_LONG_MIN): New macros.
864d7ce7
PE
11075 Use them to make the following changes clearer.
11076 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
11077 This change doesn't affect the value now, but it may help remind
11078 future maintainers not to raise the value too much later.
11079 (SELECTION_QUANTUM): Remove, replacing with ...
11080 (selection_quantum): ... new function, which avoids overflow.
11081 All uses changed.
11082 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
11083 assumption that selection length fits in 'int'.
11084 (x_reply_selection_request, x_handle_selection_request)
11085 (x_get_window_property, receive_incremental_selection)
11086 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
11087 (lisp_data_to_selection_data, clean_local_selection_data):
11088 Use ptrdiff_t, not int, to record length of selection.
11089 (x_reply_selection_request, x_get_window_property)
11090 (receive_incremental_selection, x_property_data_to_lisp):
11091 Redo calculations to avoid overflow.
11092 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 11093 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
11094 something.
11095 (x_get_window_property, receive_incremental_selection)
11096 (lisp_data_to_selection_data, x_property_data_to_lisp):
11097 Check for size-calculation overflow.
11098 (x_get_window_property, receive_incremental_selection)
11099 (lisp_data_to_selection_data, Fx_register_dnd_atom):
11100 Don't store size until memory allocation succeeds.
11101 (x_get_window_property): Plug memory leak on memory exhaustion.
11102 Don't double-block input; malloc is safe here. Don't assume 2**34
11103 - 4 fits in unsigned long. Add an xassert to check
11104 XGetWindowProperty overflow. Be more careful about overflow
11105 calculations, and distinguish size from memory overflow better.
11106 (receive_incremental_selection): When tracing, don't assume
11107 unsigned int is less than INT_MAX.
11108 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
11109 harmful) conversions of unsigned short to int.
11110 (lisp_data_to_selection_data): Don't assume that integers
11111 in the range -65535 through -1 fit in an X unsigned short.
11112 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
11113 result parameters unless successful. Rely on cons_to_unsigned
11114 to report problems with elements; the old code wasn't right anyway.
11115 (x_check_property_data): Check for int overflow; we cannot use
11116 a wider type due to X limits.
11117 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
11118
726e0ab1 11119 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 11120
0065d054
PE
11121 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
11122 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
11123 (x_color_cells): Don't store size until memory allocation succeeds.
11124 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 11125 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
11126 (x_term_init): Don't assume length fits in int (sprintf is limited
11127 to int size).
bc18e09d 11128
ebfa62c0
PE
11129 Use ptrdiff_t for composition IDs.
11130 * character.c (lisp_string_width):
11131 * composite.c (composition_table_size, n_compositions)
11132 (get_composition_id, composition_gstring_from_id):
11133 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
11134 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
11135 * window.c (Frecenter):
11136 Use ptrdiff_t, not int, for composition IDs.
11137 * composite.c (get_composition_id): Check for integer overflow.
11138 * composite.h: Adjust prototypes to match the above changes.
11139
d3411f89
PE
11140 Use ptrdiff_t for hash table indexes.
11141 * category.c (hash_get_category_set):
11142 * ccl.c (ccl_driver):
11143 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
11144 * coding.c (coding_system_charset_list, detect_coding_system):
11145 * coding.h (struct coding_system.id):
11146 * composite.c (get_composition_id, gstring_lookup_cache):
11147 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
11148 * image.c (xpm_get_color_table_h):
11149 * lisp.h (hash_lookup, hash_put):
11150 * minibuf.c (Ftest_completion):
11151 Use ptrdiff_t for hash table indexes, not int (which is too
11152 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
11153 32-bit --with-wide-int hosts).
11154
e097a6fa
PE
11155 * charset.c (Fdefine_charset_internal): Check for integer overflow.
11156 Add a FIXME comment about memory leaks.
11157 (syms_of_charset): Don't assume xmalloc returns.
11158
5637687f
PE
11159 Don't assume that stated character widths fit in int.
11160 * character.c (Fchar_width, c_string_width, lisp_string_width):
11161 * character.h (CHAR_WIDTH):
11162 * indent.c (MULTIBYTE_BYTES_WIDTH):
11163 Use sanitize_char_width to avoid undefined and/or bad behavior
11164 with outlandish widths.
a66cfb1c 11165 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
11166 now that we have two such functions. All uses changed.
11167 (sanitize_char_width): New inline function.
11168
a2271ba2
PE
11169 Don't assume that tab-width fits in int.
11170 * character.h (sanitize_width): New inline function.
11171 (SANE_TAB_WIDTH): New macro.
11172 (ASCII_CHAR_WIDTH): Use it.
11173 * indent.c (sane_tab_width): Remove. All uses replaced by
11174 SANE_TAB_WIDTH (current_buffer).
11175 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
11176
18c52557
PE
11177 * fileio.c: Integer overflow issues with file modes.
11178 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
11179
caeeedc1
PE
11180 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
11181 Remove unreachable code.
11182 (read_hex, load_charset_map_from_file): Check for integer overflow.
11183
6df6ae42 11184 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
11185 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
11186 (x_send_scroll_bar_event): Likewise. Check that the size does not
11187 exceed limits imposed by XClientMessageEvent, as well as the usual
11188 ptrdiff_t and size_t limits.
11189
b13995db
PE
11190 * keyboard.c: Overflow, signedness and related fixes.
11191 (make_lispy_movement): Use same integer type in forward decl
11192 that is used in the definition.
11193 (read_key_sequence, keyremap_step):
11194 Change bufsize argument back to int, undoing my 2011-03-30 change.
11195 We prefer signed types, and int is wide enough here.
11196 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
11197 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
11198 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
11199 length, not size_t. Use ptrdiff_t for index, not int.
11200 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
11201 possibility of integer overflow.
11202
13464394
PE
11203 Overflow, signedness and related fixes for images.
11204
11205 * dispextern.h (struct it.stack[0].u.image.image_id)
11206 (struct_it.image_id, struct image.id, struct image_cache.size)
11207 (struct image_cache.used, struct image_cache.ref_count):
11208 * gtkutil.c (update_frame_tool_bar):
11209 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
11210 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
11211 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
11212 * nsmenu.m (update_frame_tool_bar):
11213 * xdisp.c (calc_pixel_width_or_height):
11214 * xfns.c (image_cache_refcount):
11215 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
11216 on typical 64-bit hosts.
11217
11218 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
11219 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
11220 Omit unnecessary casts to int.
11221 (parse_image_spec): Check that integers fall into 'int' range
11222 when the callers expect that.
11223 (image_ascent): Redo ascent calculation to avoid int overflow.
11224 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
11225 (lookup_image): Remove unnecessary tests.
11226 (xbm_image_p): Locals are now of int, not EMACS_INT,
11227 since parse_image_check makes sure they fit into int.
11228 (png_load, gif_load, svg_load_image):
11229 Prefer int to unsigned where either will do.
11230 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
11231 old tiff_error_handler and tiff_warning_handler.
11232 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
11233 stack buffer overflows. It uses only the features of vsnprintf
11234 that are common to both POSIX and native Microsoft.
11235 (tiff_error_handler, tiff_warning_handler): Use it.
11236 (tiff_load, gif_load, imagemagick_load_image):
11237 Don't assume :index value fits in 'int'.
11238 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
11239 (imagemagick_load_image): Check that crop parameters fit into
11240 the integer types that MagickCropImage accepts. Don't assume
11241 Vimagemagick_render_type has a nonnegative value. Don't assume
11242 size_t fits in 'long'.
11243 (gs_load): Use printmax_t to print the widest integers possible.
11244 Check for integer overflow when computing image height and width.
11245
c11821d4
EZ
112462011-08-26 Eli Zaretskii <eliz@gnu.org>
11247
11248 * xdisp.c (redisplay_window): Don't force window start if point
11249 will be invisible in the resulting window. (Bug#9324)
11250
0c95fcf7
EZ
112512011-08-25 Eli Zaretskii <eliz@gnu.org>
11252
11253 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
11254 the display spec is of the form `(space ...)'.
11255 (handle_display_spec): Return the value returned by
11256 handle_single_display_spec, not just 1 or zero.
11257 (handle_single_display_spec): If the display spec is of the form
11258 `(space ...)', and specifies display in the text area, return 2
11259 rather than 1.
fee65a97 11260 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
11261 accurately, and prefer exact match for point under bidi.
11262 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
11263
11264 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
11265 into disp_prop; all users changed.
11266
11267 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
11268 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
11269 for the text covered by the display property.
11270
e4ed06f1
CY
112712011-08-25 Chong Yidong <cyd@stupidchicken.com>
11272
11273 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
11274 Change return value to nil.
11275 (Frecord_buffer): Delete unused function.
11276
f67cdd7f
EZ
112772011-08-24 Eli Zaretskii <eliz@gnu.org>
11278
5980d4c6
EZ
11279 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
11280 buffers, return left-to-right.
8610fe8b
EZ
11281 (set_cursor_from_row): Consider candidate row a win if its glyph
11282 represents a newline and point is on that newline. Fixes cursor
11283 positioning on the newline at EOL of R2L text within L2R
11284 paragraph, and vice versa.
11285 (try_cursor_movement): Check continued rows, in addition to
11286 continuation rows. Fixes unwarranted scroll when point enters a
11287 continued line of R2L text within an L2R paragraph, or vice versa.
11288 (cursor_row_p): Consider the case of point being equal to
11289 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
11290 from the end of a short line to the beginning of a continued line
11291 of R2L text within L2R paragraph.
11292 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
11293 composed characters.
5980d4c6 11294
f67cdd7f
EZ
11295 * bidi.c (bidi_check_type): Use xassert.
11296 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
11297 members.
11298
bca633fb
EZ
112992011-08-23 Eli Zaretskii <eliz@gnu.org>
11300
11301 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
11302 a character.
11303
4a5885a7
CY
113042011-08-23 Chong Yidong <cyd@stupidchicken.com>
11305
11306 * nsfont.m (ns_otf_to_script): Fix typo.
11307
0902a04e
KH
113082011-08-22 Kenichi Handa <handa@m17n.org>
11309
11310 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
11311 extra slot even if the purpose is char-code-property-table.
11312
1a2e6670
EZ
113132011-08-23 Eli Zaretskii <eliz@gnu.org>
11314
8ddde651
EZ
11315 * xdisp.c (redisplay_window): When computing centering_position,
11316 account for the height of the header line. (Bug#8874)
11317
425cc014
EZ
11318 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
11319 instead of CHAR_TO_BYTE. Fixes a crash when a completion
11320 candidate is selected by the mouse, and that candidate has a
11321 composed character under the mouse.
11322
1a2e6670
EZ
11323 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
11324 coordinates reported by pos-visible-in-window-p for a composed
11325 character in column zero.
11326
8b76d6f8
SM
113272011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
11328
11329 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
11330
dac347dd
EZ
113312011-08-22 Eli Zaretskii <eliz@gnu.org>
11332
11333 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
11334 consider it a hit if to_charpos is anywhere in the range of the
11335 composed buffer positions.
11336
e013fb34
CY
113372011-08-22 Chong Yidong <cyd@stupidchicken.com>
11338
11339 * image.c (gif_load): Don't assume that each subimage has the same
11340 dimensions as the base image. Handle disposal method that is
11341 "undefined" by the gif spec (Bug#9335).
11342
bd1ba3e8
CY
113432011-08-20 Chong Yidong <cyd@stupidchicken.com>
11344
11345 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 11346 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 11347
54a1215b
EZ
113482011-08-19 Eli Zaretskii <eliz@gnu.org>
11349
823564e5
EZ
11350 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
11351 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
11352 from an Org mode buffer to a Speedbar frame.
11353
54a1215b
EZ
11354 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
11355 a composition, take its buffer position from IT->cmp_it.charpos.
11356 Fixes cursor positioning at the beginning of a line that begins
11357 with a composed character.
11358
9778ebcc
EZ
113592011-08-18 Eli Zaretskii <eliz@gnu.org>
11360
0be6ee06
EZ
11361 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
11362 character bidirectional type, use STRONG_L instead. Fixes crashes
11363 in a buffer produced by `describe-categories'.
11364
9778ebcc
EZ
11365 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
11366 members before the level stack, so they would be saved and
11367 restored when copying iterator state. Fixes incorrect reordering
11368 around TABs covered by display properties.
11369
156bffbe
AS
113702011-08-18 Andreas Schwab <schwab@linux-m68k.org>
11371
6b02f655 11372 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 11373
72ad093b
CY
113742011-08-17 Chong Yidong <cyd@stupidchicken.com>
11375
11376 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
11377 (internal_condition_case_2, internal_condition_case_n):
11378 Remove unnecessary aborts (Bug#9081).
72ad093b 11379
35774242
EZ
113802011-08-17 Eli Zaretskii <eliz@gnu.org>
11381
11382 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
11383 has no `load' handler, try opening the file locally. (Bug#9311)
11384
db76dd85
KB
113852011-08-16 Ken Brown <kbrown@cornell.edu>
11386
11387 * gmalloc.c: Expand comment.
11388
b215eee5
EZ
113892011-08-16 Eli Zaretskii <eliz@gnu.org>
11390
11391 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
11392 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
11393
a4579d33
KB
113942011-08-16 Ken Brown <kbrown@cornell.edu>
11395
11396 Fix memory allocation problems in Cygwin build (Bug#9273).
11397
11398 * unexcw.c ( __malloc_initialized): Declare external variable.
11399 (fixup_executable): Force the dumped emacs to reinitialize malloc.
11400
8b76d6f8
SM
11401 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
11402 New variables.
a4579d33
KB
11403 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
11404 dumped emacs.
11405 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
11406 in the static heap.
11407 [CYGWIN] (special_realloc): New function.
11408 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
11409 requests to realloc storage in the static heap.
11410
3ebec551
PE
114112011-08-15 Paul Eggert <eggert@cs.ucla.edu>
11412
11413 * bidi.c (bidi_initialize): Remove unused local.
11414
9fd8be00
EZ
114152011-08-15 Eli Zaretskii <eliz@gnu.org>
11416
6b02f655
SM
11417 * bidimirror.h:
11418 * biditype.h: Remove file.
11419 * makefile.w32-in ($(BLD)/bidi.$(O)):
11420 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
11421
11422 * dispextern.h: Fix a typo in the comment to bidi_type_t.
11423
11424 * chartab.c: Improve commentary for the uniprop_table API.
11425
32413314
EZ
11426 * bidi.c (bidi_paragraph_init): Support zero value of
11427 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
11428 (bidi_initialize): Use uniprop_table instead of including
11429 biditype.h and bidimirror.h.
32413314 11430
9fd8be00
EZ
11431 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
11432 coordinates of the iterator when restoring from ppos_it.
11433 (Bug#9296)
11434
5cf2b69b
KH
114352011-08-14 Kenichi Handa <handa@m17n.org>
11436
11437 * process.c (create_process): Call setup_process_coding_systems
72ad093b 11438 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 11439
daf17d00
EZ
114402011-08-14 Eli Zaretskii <eliz@gnu.org>
11441
11442 * xdisp.c (move_it_in_display_line_to): Don't invoke
11443 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
11444 ppos_it. Fixes vertical cursor motion when line beginning is
11445 covered by an image. (Bug#9296)
11446
08e3161a
JD
114472011-08-14 Jan Djärv <jan.h.d@swipnet.se>
11448
11449 * nsterm.h (ns_run_ascript): Declare.
11450 (NSAPP_DATA2_RUNASSCRIPT): Define.
11451
11452 * nsfns.m (as_script, as_result, as_status): New static variables.
11453 (ns_run_ascript): New function.
5e617bc2 11454 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
11455 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
11456 the event loop. Get status from as_status (Bug#7276).
11457
11458 * nsterm.m (sendEvent): If event is NSApplicationDefined and
11459 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
11460 the event loop (Bug#7276).
11461
a3720aa2
AS
114622011-08-14 Andreas Schwab <schwab@linux-m68k.org>
11463
11464 * gnutls.c (QCgnutls_bootprop_priority)
11465 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
11466 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
11467 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
11468 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
11469 (QCgnutls_bootprop_verify_hostname_error)
11470 (QCgnutls_bootprop_callbacks_verify): Rename from
11471 Qgnutls_bootprop_..., all uses changed.
11472
11473 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
11474 uses changed.
11475
0a0d27fb
PE
114762011-08-14 Paul Eggert <eggert@cs.ucla.edu>
11477
19d5c50c
PE
11478 * xfaces.c (Qframe_set_background_mode): Now static.
11479 * dispextern.h (Qframe_set_background_mode): Remove decl.
11480
0a0d27fb
PE
11481 * process.c (Fnetwork_interface_info): Declare local only if needed.
11482
377538cb
JD
114832011-08-13 Jan Djärv <jan.h.d@swipnet.se>
11484
11485 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
11486 (Fnetwork_interface_list): Allocate in increments of bytes instead
11487 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
11488 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
11489 sockaddr.
11490 (struct ifflag_def): notrailers is smart on OSX.
11491 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
11492 Get hardware address with getifaddrs if available.
11493
08fff70c
EZ
114942011-08-12 Eli Zaretskii <eliz@gnu.org>
11495
11496 * xdisp.c (iterate_out_of_display_property): xassert that
11497 IT->position is set to within IT->object's boundaries. Break from
11498 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
11499 when IT->position is set up wrongly due to some bug.
11500 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
11501 (push_display_prop): Allow GET_FROM_STRING as IT->method on
11502 entry. Force push_it to save on the stack the current
11503 buffer/string position, to be restored by pop_it. Fix flags in
11504 the iterator structure wrt the object coming from a display
11505 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
11506 properties. (Bug#9284)
11507
7be1c708 115082011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 11509
7be1c708
CY
11510 * fontset.c (fontset_get_font_group): Add proper type checks.
11511 (Bug#9172)
aac0c6e3 11512
7be1c708 115132011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 11514
7be1c708
CY
11515 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
11516 and LC_VERSION_MIN_MACOSX.
11517 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
11518 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 11519
97bb72a6
EZ
115202011-08-08 Eli Zaretskii <eliz@gnu.org>
11521
11522 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
11523 no-display-properties-and-no-overlays under bidi display.
11524 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 11525 properties and overlays.
97bb72a6 11526
d5617611
CY
115272011-08-08 Chong Yidong <cyd@stupidchicken.com>
11528
37e11a63
CY
11529 * editfns.c (Fset_time_zone_rule): Document relationship with the
11530 setenv function.
11531
d5617611
CY
11532 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
11533 the font entity extracted from the cache (Bug#8109).
11534
58872834
CY
115352011-08-07 Chong Yidong <cyd@stupidchicken.com>
11536
11537 * composite.c (autocmp_chars): Don't reset point. That is done by
11538 restore_point_unwind (Bug#5984).
11539
75bfc667
JL
115402011-08-07 Juri Linkov <juri@jurta.org>
11541
11542 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
11543 to show the arg `TIME' instead of `TIMEVAL'.
11544
d1410150
EZ
115452011-08-06 Eli Zaretskii <eliz@gnu.org>
11546
11547 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
11548 display property strides EOL and includes a newline, as in
11549 longlines-mode. (Bug#9254)
75b771e4
EZ
11550 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
11551 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
11552
11553 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
11554 is non-zero, even if the data buffer is NULL. Fixes a crash in
11555 vertical-motion with longlines-mode. (Bug#9254)
11556
35928349
EZ
115572011-08-05 Eli Zaretskii <eliz@gnu.org>
11558
ec7cc85b
EZ
11559 * bidi.c <bidi_cache_total_alloc>: Now static.
11560 (bidi_initialize): Initialize bidi_cache_total_alloc.
11561
8b76d6f8 11562 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
11563 cache. (Bug#9221)
11564
11565 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
11566 amount allocated this far in `bidi_cache_total_alloc'.
11567 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
11568 non-zero, only free the data buffer without restoring the cache
11569 contents. All callers changed.
11570
11571 * dispextern.h (bidi_unshelve_cache): Update prototype.
11572
11573 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
11574 (move_it_in_display_line, move_it_to)
11575 (move_it_vertically_backward, move_it_by_lines): Replace the call
11576 to xfree to an equivalent call to bidi_unshelve_cache.
11577 (move_it_in_display_line_to): Fix logic of returning
412b6358 11578 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 11579
e2e2423b
EZ
115802011-08-05 Eli Zaretskii <eliz@gnu.org>
11581
11582 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
11583 came from a string character with a `cursor' property. (Bug#9229)
11584
ae9e757a
JD
115852011-08-04 Jan Djärv <jan.h.d@swipnet.se>
11586
11587 * Makefile.in (LIB_PTHREAD): New variable.
11588 (LIBES): Add LIB_PTHREAD (Bug#9216).
11589
11590 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
11591 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
11592
213bd7f2
AS
115932011-08-04 Andreas Schwab <schwab@linux-m68k.org>
11594
6b02f655 11595 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 11596
99aaf75f
JD
115972011-08-04 Jan Djärv <jan.h.d@swipnet.se>
11598
11599 * xterm.c (x_find_topmost_parent): New function.
11600 (x_set_frame_alpha): Find topmost parent window with
11601 x_find_topmost_parent and set the property there also (bug#9181).
11602 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
11603
c74e9d86
PE
116042011-08-04 Paul Eggert <eggert@cs.ucla.edu>
11605
11606 * callproc.c (Fcall_process): Avoid vfork clobbering
11607 the local vars buffer, coding_systems, current_dir.
11608
640c8776
SM
116092011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
11610
11611 * keymap.c (Fmake_composed_keymap): Move to subr.el.
11612
f26d0e4c
PE
116132011-08-03 Paul Eggert <eggert@cs.ucla.edu>
11614
8a10d76c
PE
11615 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
11616 so that it is not optimized away.
11617
f26d0e4c
PE
11618 * xdisp.c (compute_display_string_pos): Remove unused local.
11619
55439c61
EZ
116202011-08-02 Eli Zaretskii <eliz@gnu.org>
11621
11622 Fix slow cursor motion and scrolling in large buffers with
11623 selective display, like Org Mode buffers. (Bug#9218)
11624
11625 * dispextern.h (struct bidi_it): New member disp_prop_p.
11626
11627 * xdisp.c: Remove one-slot cache of display string positions.
11628 (compute_display_string_pos): Accept an additional argument
5e617bc2 11629 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
11630 for a display string or property. If found, set DISP_PROP_P
11631 non-zero.
11632
11633 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
11634 DISP_PROP_P, and pass it to compute_display_string_pos.
11635 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
11636 non-zero. All callers of bidi_fetch_char changed.
11637
fb33fa43
SM
116382011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
11639
11640 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
11641
b099e063
DM
116422010-12-03 Don March <don@ohspite.net>
11643
11644 * keymap.c (Fdefine_key): Fix non-prefix key error message when
11645 last character M-[char] is translated to ESC [char] (bug#7541).
11646
5cc7f7af
KH
116472011-08-02 Kenichi Handa <handa@m17n.org>
11648
d0fffa3f 11649 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
11650
11651 * chartab.c (uniprop_table): Make it non-static.
11652
525d5e6e
EZ
116532011-08-01 Eli Zaretskii <eliz@gnu.org>
11654
11655 * xdisp.c (forward_to_next_line_start): Accept additional argument
11656 BIDI_IT_PREV, and store into it the state of the bidi iterator had
11657 on the newline.
11658 (reseat_at_next_visible_line_start): Use the bidi iterator state
11659 returned by forward_to_next_line_start to restore the state of
11660 it->bidi_it after backing up to previous newline. (Bug#9212)
11661
31011111
AS
116622011-07-30 Andreas Schwab <schwab@linux-m68k.org>
11663
11664 * regex.c (re_comp): Protoize.
11665 (re_exec): Fix return type.
11666 (regexec): Fix type of `ret'. (Bug#9203)
11667
476371c4
PE
116682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
11669
e5d76069
PE
11670 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
11671 This is needed if max-image-size is a floating-point number.
11672
9a79b20c
AS
116732011-07-28 Andreas Schwab <schwab@linux-m68k.org>
11674
11675 * print.c (print_object): Print empty symbol as ##.
11676
11677 * lread.c (read1): Read ## as empty symbol.
11678
d8c2fa78
AA
116792011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
11680
11681 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
11682 setting frame foreground color (Bug#9175).
11683 (x_set_background_color): Likewise.
11684
ffe57a7a
AA
11685 * nsmenu.m (-setText): Size tooltip dimensions precisely to
11686 contents (Bug#9176).
11687 (EmacsTooltip -init): Remove bezels and add shadows to
11688 tooltip windows.
11689
bf3492a5
AA
11690 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
11691 or scroll bar (Bug#8470).
11692
d55e9c53
AA
11693 * nsfont.m (nsfont_open): Remove assignment to voffset and
11694 unnecessary vars hshink, expand, hd, full_height, min_height.
11695 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
11696
11697 * nsterm.h (nsfont_info): Remove voffset field.
11698
d8c2fa78 116992011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
11700
11701 Implement strike-through and overline on NextStep (Bug#8863).
11702
11703 * nsfont.m (nsfont_open): Use underline position provided by font,
11704 instead of hard-coded value of 2.
11705 (nsfont_draw): Call ns_draw_text_decoration instead.
11706
11707 * nsterm.h: Add declaration for ns_draw_text_decoration.
11708
11709 * nsterm.m (ns_draw_text_decoration): New function for drawing
11710 underline, overline, and strike-through.
11711 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
11712 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 11713 accommodate underlining, etc.
4843aac3 11714
4cc60b9b
EZ
117152011-07-28 Eli Zaretskii <eliz@gnu.org>
11716
bc7ece87
EZ
11717 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
11718 default.
4cc60b9b 11719
476371c4
PE
117202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
11721
66606eea
PE
11722 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
11723 Without this fix, if a signal arrives just after memory fills up,
11724 'malloc' might be invoked reentrantly.
11725
476371c4
PE
11726 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
11727 In other words, assume that every image size is allowed, on non-X
11728 hosts. This assumption is probably wrong, but it lets Emacs compile.
11729
f3fcc40d
AS
117302011-07-28 Andreas Schwab <schwab@linux-m68k.org>
11731
11732 * regex.c (re_iswctype): Convert return values to boolean.
11733
350c992f
EZ
117342011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
11735
11736 * xdisp.c (compute_display_string_pos): Don't use cached display
11737 string position if the buffer had its restriction changed.
11738 (Bug#9184)
11739
5266b4bb
PE
117402011-07-28 Paul Eggert <eggert@cs.ucla.edu>
11741
11742 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11743
2573a837 117442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 11745
41f55ccd 11746 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 11747
39e378da
PE
11748 * bidi.c: Integer size and overflow fixes.
11749 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
11750 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
11751 (bidi_cache_find_level_change, bidi_cache_ensure_space)
11752 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
11753 (bidi_find_other_level_edge):
11754 Use ptrdiff_t instead of EMACS_INT where either will do.
11755 This works better on 32-bit hosts configured --with-wide-int.
11756 (bidi_cache_ensure_space): Check for size-calculation overflow.
11757 Use % rather than repeated addition, for better worst-case speed.
11758 Don't set bidi_cache_size until after xrealloc returns, because it
11759 might not return.
11760 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
11761 (bidi_cache_ensure_space): Also check that the bidi cache size
11762 does not exceed that of the largest Lisp string or buffer. See Eli
11763 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 11764
5e927815
PE
11765 * alloc.c (__malloc_size_t): Remove.
11766 All uses replaced by size_t. See Andreas Schwab's note
11767 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
11768
ca4aa935
PE
11769 * image.c: Improve checking for integer overflow.
11770 (check_image_size): Assume that f is nonnull, since
11771 it is always nonnull in practice. This is one less thing to
11772 worry about when checking for integer overflow later.
11773 (x_check_image_size): New function, which checks for integer
11774 overflow issues inside X.
11775 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
11776 This removes the need for a memory_full check.
11777 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
11778 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
11779 (xbm_read_bitmap_data): Change locals back to 'int', since
11780 their values must fit in 'int'.
11781 (xpm_load_image, png_load, tiff_load):
11782 Invoke x_create_x_image_and_pixmap earlier,
11783 to avoid much needless work if the image is too large.
11784 (tiff_load): Treat overly large images as if
11785 x_create_x_image_and_pixmap failed, not as malloc failures.
11786 (gs_load): Use x_check_image_size.
11787
5f8f9cc2
PE
11788 * gtkutil.c: Omit integer casts.
11789 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
11790 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
11791
5adf60bc
PE
11792 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
11793
c8907a93
PE
11794 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
11795 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
11796 would wrongly return t on a 64-bit host.
11797
e3c25c68
PE
11798 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
11799 The plain *_OVERFLOW macros run afoul of GCC bug 49705
11800 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
11801 and therefore cause GCC to emit a bogus diagnostic in some cases.
11802
3f791afe
PE
11803 * image.c: Integer signedness and overflow and related fixes.
11804 This is not an exhaustive set of fixes, but it's time to
11805 record what I've got.
11806 (lookup_pixel_color, check_image_size): Remove redundant decls.
11807 (check_image_size): Don't assume that arbitrary EMACS_INT values
11808 fit in 'int', or that arbitrary 'double' values fit in 'int'.
11809 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
11810 (tiff_load, imagemagick_load_image):
11811 Check for overflow in size calculations.
11812 (x_create_x_image_and_pixmap): Remove unnecessary test for
11813 xmalloc returning NULL; that can't happen.
11814 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
11815 (xpm_color_bucket): Use better integer hashing function.
11816 (xpm_cache_color): Don't possibly over-allocate memory.
11817 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
11818 (gif_memory_source):
11819 Use ptrdiff_t, not int or size_t, to record sizes.
11820 (png_load): Don't assume values greater than 2**31 fit in 'int'.
11821 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
11822 either works, as we prefer signed integers.
11823 (tiff_read_from_memory, tiff_write_from_memory):
11824 Return tsize_t, not size_t, since that's what the TIFF API wants.
11825 (tiff_read_from_memory): Don't fail simply because the read would
11826 go past EOF; instead, return a short read.
11827 (tiff_load): Omit no-longer-needed casts.
11828 (Fimagemagick_types): Don't assume size fits into 'int'.
11829
3cc5a532
PE
11830 Improve hashing quality when configured --with-wide-int.
11831 * fns.c (hash_string): New function, taken from sxhash_string.
11832 Do not discard information about ASCII character case; this
11833 discarding is no longer needed.
11834 (sxhash-string): Use it. Change sig to match it. Caller changed.
11835 * lisp.h: Declare it.
11836 * lread.c (hash_string): Remove, since we now use fns.c's version.
11837 The fns.c version returns a wider integer if --with-wide-int is
11838 specified, so this should help the quality of the hashing a bit.
11839
b312a492
PE
11840 * emacs.c: Integer overflow minor fix.
11841 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
11842 Define only if GNU_LINUX.
11843 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
11844
dfd153ae
PE
11845 * dispnew.c: Integer signedness and overflow fixes.
11846 Remove unnecessary forward decls, that were a maintenance hassle.
11847 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
11848 All uses changed.
11849 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
11850 (scrolling_window): Use ptrdiff_t, not int, for byte count.
11851 (prepare_desired_row, line_draw_cost):
11852 Use int, not unsigned, where either works.
11853 (save_current_matrix, restore_current_matrix):
11854 Use ptrdiff_t, not size_t, where either works.
11855 (init_display): Check for overflow more accurately, and without
11856 relying on undefined behavior.
11857
a81d11a3
PE
11858 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
11859 Remove, replacing with the new symbols in lisp.h. All uses changed.
11860 * fileio.c (make_temp_name):
11861 * filelock.c (lock_file_1, lock_file):
11862 * xdisp.c (message_dolog):
11863 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
11864 Use pMd etc. instead.
11865 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
11866 replacing the pWIDE etc. symbols removed from editfns.c.
11867
3300e6fd
PE
11868 * keyboard.h (num_input_events): Now uintmax_t.
11869 This is (very slightly) less likely to mess up due to wraparound.
11870 All uses changed.
11871
fd05c7e9
PE
11872 * buffer.c: Integer signedness fixes.
11873 (alloc_buffer_text, enlarge_buffer_text):
11874 Use ptrdiff_t rather than size_t when either will do, as we prefer
11875 signed integers.
11876
903fe15d
PE
11877 * alloc.c: Integer signedness and overflow fixes.
11878 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
11879 (__malloc_size_t): Default to size_t, not to int.
11880 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
11881 (Fgarbage_collect, mark_object_loop_halt, mark_object):
11882 Prefer ptrdiff_t to size_t when either would do, as we prefer
11883 signed integers.
11884 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
11885 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
11886 Now const. Initialize with values that are in range even if char
11887 is signed.
11888 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
11889 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
11890 These functions do the right thing with sizes > 2**32.
11891 (check_depth): Now ptrdiff_t, not int.
11892 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
11893 Adjust to new way of storing sizes. Check for size overflow bugs
11894 in rest of code.
11895 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
11896 slightly wrong anyway, as it missed one instance of
11897 XMALLOC_OVERRUN_CHECK_OVERHEAD.
11898 (refill_memory_reserve): Omit needless cast to size_t.
11899 (mark_object_loop_halt): Mark as externally visible.
11900
ac82cc6a
PE
11901 * xselect.c: Integer signedness and overflow fixes.
11902 (Fx_register_dnd_atom, x_handle_dnd_message):
11903 Use ptrdiff_t, not size_t, since we prefer signed.
11904 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
11905 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
11906 x_dnd_atoms_size and x_dnd_atoms_length.
11907
c2d1e36d
PE
11908 * doprnt.c: Prefer signed to unsigned when either works.
11909 * eval.c (verror):
11910 * doprnt.c (doprnt):
11911 * lisp.h (doprnt):
11912 * xdisp.c (vmessage):
11913 Use ptrdiff_t, not size_t, when using or implementing doprnt,
11914 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
11915 prefer signed arithmetic to avoid comparison confusion.
11916 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
11917 but is a bit tricky.
11918
0e926e56
PE
11919 Assume freestanding C89 headers, string.h, stdlib.h.
11920 * data.c, doprnt.c, floatfns.c, print.c:
11921 Include float.h unconditionally.
11922 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
11923 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
11924 * regex.c: Likewise for stddef.h, string.h.
11925 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
11926 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
11927 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
11928 (STDC_HEADERS): Remove obsolete defines.
11929 * sysdep.c: Include limits.h unconditionally.
11930
9cfdb3ec
PE
11931 Assume support for memcmp, memcpy, memmove, memset.
11932 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
11933 * regex.c (memcmp, memcpy):
11934 Remove; we assume C89 now.
11935
11936 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
11937 (__malloc_safe_bcopy): Remove; no longer needed.
11938
cf950e6b 11939 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
11940 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
11941 well either way, and we prefer signed to unsigned.
11942
dbf38e02
LMI
119432011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
11944
11945 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
11946 closes the connection while we're reading (bug#9182).
11947
d6f0886c 119482011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 11949
d6f0886c
JD
11950 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
11951 are specified (Bug#9168).
24e0f6b1 11952
2eb1f9e6
PE
119532011-07-25 Paul Eggert <eggert@cs.ucla.edu>
11954
11955 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
11956 Found by GCC static checking and --with-wide-int on a 32-bit host.
11957
22381272 119582011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
11959
11960 * xdisp.c (compute_display_string_pos): Fix logic of caching
11961 previous display string position. Initialize cached_prev_pos to
11962 -1. Fixes slow-down at the beginning of a buffer.
11963
f25e39b4
EZ
119642011-07-24 Eli Zaretskii <eliz@gnu.org>
11965
11966 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
11967 for attrs[LFACE_FONTSET_INDEX].
11968
04c4b52e
PE
119692011-07-23 Paul Eggert <eggert@cs.ucla.edu>
11970
11971 * xml.c (parse_region): Remove unused local
11972 that was recently introduced.
11973
c1734fbd
EZ
119742011-07-23 Eli Zaretskii <eliz@gnu.org>
11975
be18c5a5
EZ
11976 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
11977 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
11978
c1734fbd
EZ
11979 * xdisp.c (move_it_in_display_line_to): Record the best matching
11980 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
11981 exit if none of the characters scanned was an exact match.
11982 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
11983 when exact match is impossible due to invisible text, and the
11984 lines are truncated.
11985
a258d627
JD
119862011-07-23 Jan Djärv <jan.h.d@swipnet.se>
11987
11988 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
11989 for OSX >= 10.7.
11990
b6d5a689
EZ
119912011-07-22 Eli Zaretskii <eliz@gnu.org>
11992
0f74f785
EZ
11993 Fix a significant slow-down of cursor motion with C-n, C-p,
11994 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
11995 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 11996 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
11997 (next_element_from_buffer): Call compute_stop_pos_backwards to
11998 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
11999 base_level_stop.
12000 (reseat): Don't look for prev_stop, as that could mean a very long
12001 run.
12002 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
12003 <cached_disp_overlay_modiff>: Cache for last found display string
12004 position.
551918c1 12005 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
12006 about the same buffer in the same area of character positions, and
12007 the buffer wasn't changed since the time the display string
12008 position was cached.
551918c1 12009
b2d0c91a
EZ
120102011-07-22 Eli Zaretskii <eliz@gnu.org>
12011
12012 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
12013 is an integer, which is important for empty lines. (Bug#9149)
12014
043604ee
CY
120152011-07-22 Chong Yidong <cyd@stupidchicken.com>
12016
12017 * frame.c (Fmodify_frame_parameters): In tty case, update the
12018 default face if necessary (Bug#4238).
12019
da4adb04
CY
120202011-07-21 Chong Yidong <cyd@stupidchicken.com>
12021
12022 * editfns.c (Fstring_to_char): No need to explain what a character
12023 is in the docstring (Bug#6576).
12024
9abd0532
LMI
120252011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12026
12027 * xml.c (parse_region): Make sure we always return a tree.
12028
36881d16
HK
120292011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
12030
12031 * xml.c (parse_region): If a document contains only comments,
12032 return that, too.
12033
1e98674d
LMI
120342011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12035
12036 * xml.c (make_dom): Return comments, too.
12037
590bd467
PE
120382011-07-19 Paul Eggert <eggert@cs.ucla.edu>
12039
12040 Port to OpenBSD.
12041 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
12042 and the surrounding thread.
12043 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
12044 rather than fgets, and retry after EINTR. Otherwise, 'emacs
12045 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
12046 timer goes off.
12047 * s/openbsd.h (BROKEN_SIGIO): Define.
12048 * unexelf.c (unexec) [__OpenBSD__]:
12049 Don't update the .mdebug section of the Alpha COFF symbol table.
12050
f41628b2
LMI
120512011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
12052
12053 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
12054 (bug#8460).
12055
b59b67c5
PE
120562011-07-18 Paul Eggert <eggert@cs.ucla.edu>
12057
15e3a074
PE
12058 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
12059 This fixes some race conditions on the permissions of any newly
12060 created file.
12061
41bed37d
PE
12062 * alloc.c (valid_pointer_p): Use pipe, not open.
12063 This fixes some permissions issues when debugging.
12064
b59b67c5
PE
12065 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
12066 If fchown fails to set both uid and gid, try to set just gid,
12067 as that is sometimes allowed. Adjust the file's mode to eliminate
12068 setuid or setgid bits that are inappropriate if fchown fails.
12069
925a6be7
SM
120702011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
12071
12072 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
12073 to compare Lisp_Objects.
12074 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
12075 global_gnutls_log_level, don't mistake it for a Lisp_Object.
12076 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
12077
52968808
AS
120782011-07-17 Andreas Schwab <schwab@linux-m68k.org>
12079
0a6a104b
AS
12080 * lread.c (read_integer): Unread even EOF character.
12081 (read1): Likewise. Properly record start position of symbol.
12082
52968808
AS
12083 * lread.c (read1): Read `#:' as empty uninterned symbol if no
12084 symbol character follows.
12085
9e381cdd
PE
120862011-07-17 Paul Eggert <eggert@cs.ucla.edu>
12087
12088 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
12089 This works around a problem with the previous change to Fcopy_file.
12090 Recent glibc declares fchown with __attribute__((warn_unused_result)),
12091 and without this change, GCC might complain about discarding
12092 fchown's return value.
12093
b5641435
JB
120942011-07-16 Juanma Barranquero <lekktu@gmail.com>
12095
12096 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
12097
a8031457
PE
120982011-07-16 Paul Eggert <eggert@cs.ucla.edu>
12099
12100 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
12101
dd889327
LMI
121022011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
12103
750c33f7
LMI
12104 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
12105 it's used from the C level.
12106
dd889327
LMI
12107 * process.c: Use the same condition for POLL_FOR_INPUT in both
12108 keyboard.c and process.c (bug#1858).
12109
87e86684
LM
121102011-07-09 Lawrence Mitchell <wence@gmx.li>
12111
12112 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
12113 (Fgnutls_boot): Use it.
12114
64348f40
AS
121152011-07-15 Andreas Schwab <schwab@linux-m68k.org>
12116
12117 * doc.c (Fsubstitute_command_keys): Revert last change.
12118
1d698799
LMI
121192011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
12120
f863868c
LMI
12121 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
12122 quotes the next character, and doesn't affect other longer
12123 sequences (bug#8935).
12124
1d698799
LMI
12125 * lread.c (syms_of_lread): Clarify that is isn't only
12126 `eval-buffer' and `eval-defun' that's affected by
12127 `lexical-binding' (bug#8460).
12128
aa4b6df6
EZ
121292011-07-15 Eli Zaretskii <eliz@gnu.org>
12130
12131 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 12132 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 12133
5d856da6
PE
121342011-07-14 Paul Eggert <eggert@cs.ucla.edu>
12135
ad6042bb
PE
12136 Fix minor problems found by static checking.
12137 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
12138 (elsz): Now a signed constant, not a size_t var. We prefer signed
12139 types to unsigned, to avoid integer comparison confusion. Without
12140 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
12141 "cannot optimize loop, the loop counter may overflow", a symptom
12142 of the confusion.
f00bbb22 12143 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
12144 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
12145
6468f31c
LMI
121462011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
12147
49080b10
LMI
12148 * search.c (Fre_search_backward): Mention `case-fold-search' in
12149 all the re_search_* functions (bug#8138).
12150
6468f31c
LMI
12151 * keyboard.c (Fopen_dribble_file): Document when the file is
12152 closed (bug#8056).
12153
c965adc5
EZ
121542011-07-14 Eli Zaretskii <eliz@gnu.org>
12155
df9733bf
EZ
12156 * bidi.c (bidi_dump_cached_states): Fix format of displaying
12157 bidi_cache_idx.
12158
0bb23927
EZ
12159 Support bidi reordering of display and overlay strings.
12160 * xdisp.c (compute_display_string_pos)
12161 (compute_display_string_end): Accept additional argument STRING.
12162 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
12163 (reseat_to_string): Initialize bidi_it->string.s and
12164 bidi_it->string.schars.
12165 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
12166 NULL (avoids a crash in bidi_paragraph_init).
12167 Initialize itb.string.lstring.
0bb23927
EZ
12168 (init_iterator): Call bidi_init_it only of a valid
12169 buffer position was specified. Initialize paragraph_embedding to
12170 L2R.
12171 (reseat_to_string): Initialize the bidi iterator.
12172 (display_string): If we need to ignore text properties of
12173 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
12174 original value of -1 will not work with bidi.)
12175 (compute_display_string_pos): First arg is now struct
12176 `text_pos *'; all callers changed. Support display properties on
12177 Lisp strings.
12178 (compute_display_string_end): Support display properties on Lisp
12179 strings.
12180 (init_iterator, reseat_1, reseat_to_string): Initialize the
12181 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
12182 when iterating on a string not from display properties).
640c8776
SM
12183 (compute_display_string_pos, compute_display_string_end):
12184 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
12185 arrow keys.
12186 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
12187 base_level_stop; instead, set base_level_stop to BEGV.
12188 Fixes crashes in vertical-motion.
0bb23927
EZ
12189 (next_element_from_buffer): Improve commentary for when
12190 the iterator is before prev_stop.
12191 (init_iterator): Initialize bidi_p from the default value of
12192 bidi-display-reordering, not from buffer-local value. Use the
12193 buffer-local value only if initializing for buffer iteration.
12194 (handle_invisible_prop): Support invisible properties on strings
12195 that are being bidi-reordered.
12196 (set_iterator_to_next): Support bidi reordering of C strings and
12197 Lisp strings.
12198 (next_element_from_string): Support bidi reordering of Lisp
12199 strings.
12200 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
12201 (display_string): Support display of R2L glyph rows.
12202 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
12203 (init_iterator): Don't initialize it->bidi_p for strings
12204 here.
12205 (reseat_to_string): Initialize it->bidi_p for strings here.
12206 (next_element_from_string, next_element_from_c_string)
12207 (next_element_from_buffer): Add xassert's for correspondence
12208 between IT's object being iterated and it->bidi_it.string
12209 structure.
12210 (face_before_or_after_it_pos): Support bidi iteration.
12211 (next_element_from_c_string): Handle the case of the first string
12212 character that is not the first one in the visual order.
12213 (get_visually_first_element): New function, refactored from common
12214 parts of next_element_from_buffer, next_element_from_string, and
12215 next_element_from_c_string.
12216 (tool_bar_lines_needed, redisplay_tool_bar)
12217 (display_menu_bar): Force left-to-right direction. Add a FIXME
12218 comment for making that be controlled by a user option.
12219 (push_it, pop_it): Save and restore the state of the
12220 bidi iterator. Save and restore the bidi_p flag.
12221 (pop_it): Iterate out of display property for string iteration as
12222 well.
12223 (iterate_out_of_display_property): Support iteration over strings.
12224 (handle_single_display_spec): Set up it->bidi_it for iteration
12225 over a display string, and call bidi_init_it.
12226 (handle_single_display_spec, next_overlay_string)
12227 (get_overlay_strings_1, push_display_prop): Set up the bidi
12228 iterator for displaying display or overlay strings.
12229 (forward_to_next_line_start): Don't use the shortcut if
12230 bidi-iterating.
12231 (back_to_previous_visible_line_start): If handle_display_prop
12232 pushed the iterator stack, restore the internal state of the bidi
12233 iterator by calling bidi_pop_it same number of times.
12234 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
12235 and we are bidi-iterating, don't decrement the iterator position;
12236 instead, set the first_elt flag in the bidi iterator, to produce
12237 the same effect.
12238 (reseat_1): Remove redundant setting of string_from_display_prop_p.
12239 (push_display_prop): xassert that we are iterating a buffer.
12240 (push_it, pop_it): Save and restore paragraph_embedding member.
12241 (handle_single_display_spec, next_overlay_string)
12242 (get_overlay_strings_1, reseat_1, reseat_to_string)
12243 (push_display_prop): Set up the `unibyte' member of bidi_it.string
12244 correctly. Don't assume unibyte strings are not bidi-reordered.
12245 (compute_display_string_pos)
12246 (compute_display_string_end): Fix handling the case of C string.
12247 (push_it, pop_it): Save and restore from_disp_prop_p.
12248 (handle_single_display_spec, push_display_prop): Set the
12249 from_disp_prop_p flag.
12250 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
12251 (pop_it): Call iterate_out_of_display_property only if we are
12252 popping after iteration over a string that came from a display
12253 property. Fix a typo in popping stretch info. Add an assertion
12254 for verifying that the iterator position is in sync with the bidi
12255 iterator.
12256 (handle_single_display_spec, get_overlay_strings_1)
12257 (push_display_prop): Fix initialization of paragraph direction for
12258 string when that of the parent object is not yet determined.
12259 (reseat_1): Call bidi_init_it to resync the bidi
12260 iterator with IT's position. (Bug#7616)
12261 (find_row_edges): If ROW->start.pos gives position
12262 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
12263 (handle_stop, back_to_previous_visible_line_start, reseat_1):
12264 Reset the from_disp_prop_p flag.
12265 (SAVE_IT, RESTORE_IT): New macros.
12266 (pos_visible_p, face_before_or_after_it_pos)
12267 (back_to_previous_visible_line_start)
12268 (move_it_in_display_line_to, move_it_in_display_line)
12269 (move_it_to, move_it_vertically_backward, move_it_by_lines)
12270 (try_scrolling, redisplay_window, display_line): Use them when
12271 saving a temporary copy of the iterator and restoring it back.
12272 (back_to_previous_visible_line_start, reseat_1)
12273 (init_iterator): Empty the bidi cache "stack".
12274 (move_it_in_display_line_to): If iterator ended up at
12275 EOL, but we never saw any buffer positions smaller than
12276 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
12277 motion in bidi-reordered lines.
12278 (move_it_in_display_line_to): Record prev_method and prev_pos
12279 immediately before the call to set_iterator_to_next. Fixes cursor
12280 motion in bidi-reordered lines with stretch glyphs and strings
12281 displayed in margins. (Bug#8133) (Bug#8867)
12282 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
12283 TO_CHARPOS.
640c8776
SM
12284 (pos_visible_p): Support positions in bidi-reordered lines.
12285 Save and restore bidi cache.
0bb23927
EZ
12286
12287 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
12288 (bidi_paragraph_info): Delete unused struct.
12289 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
12290 (bidi_cache_start): New variable.
12291 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
12292 to zero.
12293 (bidi_cache_fetch_state, bidi_cache_search)
12294 (bidi_cache_find_level_change, bidi_cache_iterator_state)
12295 (bidi_cache_find, bidi_peek_at_next_level)
12296 (bidi_level_of_next_char, bidi_find_other_level_edge)
12297 (bidi_move_to_visually_next): Compare cache index with
12298 bidi_cache_start rather than with zero.
12299 (bidi_fetch_char): Accept new argument STRING; all callers
12300 changed. Support iteration over a string. Support strings with
12301 display properties. Support unibyte strings. Fix the type of
12302 `len' according to what STRING_CHAR_AND_LENGTH expects.
12303 (bidi_paragraph_init, bidi_resolve_explicit_1)
12304 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
12305 (bidi_level_of_next_char, bidi_move_to_visually_next):
12306 Support iteration over a string.
0bb23927
EZ
12307 (bidi_set_sor_type, bidi_resolve_explicit_1)
12308 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
12309 can now be zero (for strings); special values 0 and -1 were
12310 changed to -1 and -2, respectively.
12311 (bidi_char_at_pos): New function.
12312 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
12313 Call it instead of FETCH_MULTIBYTE_CHAR.
12314 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
12315 initialized to valid values.
12316 (bidi_init_it): Don't initialize charpos and bytepos with invalid
12317 values.
12318 (bidi_level_of_next_char): Allow the sentinel "position" to pass
12319 the test for valid cached positions. Fix the logic for looking up
12320 the sentinel state in the cache. GCPRO the Lisp string we are
12321 iterating.
12322 (bidi_push_it, bidi_pop_it): New functions.
12323 (bidi_initialize): Initialize the bidi cache start stack pointer.
12324 (bidi_cache_ensure_space): New function, refactored from part of
12325 bidi_cache_iterator_state. Don't assume the required size is just
12326 one BIDI_CACHE_CHUNK away.
12327 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
12328 (bidi_count_bytes, bidi_char_at_pos): New functions.
12329 (bidi_cache_search): Don't assume bidi_cache_last_idx is
12330 always valid if bidi_cache_idx is valid.
12331 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
12332 is valid if it's going to be used.
12333 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
12334 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
12335 (bidi_cache_find_level_change, bidi_cache_ensure_space)
12336 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
12337 (bidi_find_other_level_edge, bidi_cache_start_stack):
12338 All variables related to cache indices are now EMACS_INT.
c965adc5 12339
0bb23927
EZ
12340 * dispextern.h (struct bidi_string_data): New structure.
12341 (struct bidi_it): New member `string'. Make flag members be 1-bit
12342 fields, and put them last in the struct.
640c8776
SM
12343 (compute_display_string_pos, compute_display_string_end):
12344 Update prototypes.
0bb23927
EZ
12345 (bidi_push_it, bidi_pop_it): Add prototypes.
12346 (struct iterator_stack_entry): New members bidi_p,
12347 paragraph_embedding, and from_disp_prop_p.
12348 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
12349 (bidi_shelve_cache, bidi_unshelve_cache):
12350 Declare prototypes.
0bb23927
EZ
12351
12352 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
12353 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
12354 and vector-like objects.
12355
12356 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
12357 cache around display iteration.
12358
12359 * window.c (Fwindow_end, window_scroll_pixel_based)
12360 (displayed_window_lines, Frecenter): Save and restore the bidi
12361 cache around display iteration.
12362
3bbd2265
LMI
123632011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
12364
12365 * editfns.c (Fdelete_region): Clarify the use of the named
12366 parameters (bug#6788).
12367
adc47434
MR
123682011-07-14 Martin Rudalics <rudalics@gmx.at>
12369
12370 * indent.c (Fvertical_motion): Set and restore w->pointm when
12371 saving and restoring the window's buffer (Bug#9006).
12372
837c31f8
LMI
123732011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
12374
12375 * editfns.c (Fstring_to_char): Clarify just what is returned
12376 (bug#6576). Text by Eli Zaretskii.
12377
ac389d0c
JB
123782011-07-13 Juanma Barranquero <lekktu@gmail.com>
12379
12380 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
12381
0be0ce47
EZ
123822011-07-13 Eli Zaretskii <eliz@gnu.org>
12383
12384 * buffer.c (mmap_find): Fix a typo.
12385
cd18e7e3
JB
123862011-07-13 Johan Bockgård <bojohan@gnu.org>
12387
12388 Fix execution of x selection hooks.
12389 * xselect.c (Qx_lost_selection_functions)
12390 (Qx_sent_selection_functions): New vars.
12391 (syms_of_xselect): DEFSYM them.
12392 (x_handle_selection_request): Pass Qx_sent_selection_functions
12393 rather than Vx_sent_selection_functions to Frun_hook_with_args.
12394 (x_handle_selection_clear,x_clear_frame_selections):
12395 Pass Qx_lost_selection_functions rather than
12396 Vx_lost_selection_functions to Frun_hook_with_args.
12397
47ea7f44
PE
123982011-07-13 Paul Eggert <eggert@cs.ucla.edu>
12399
ac389d0c 12400 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
12401 The old code sometimes used this field without initializing it.
12402
47ea7f44
PE
12403 * alloc.c (gc_sweep): Don't read past end of array.
12404 In theory, the old code could also have corrupted Emacs internals,
12405 though it'd be very unlikely.
12406
bc985c87
AS
124072011-07-12 Andreas Schwab <schwab@linux-m68k.org>
12408
12409 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 12410 argument. (Bug#4026)
bc985c87 12411
0cf34688
LMI
124122011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
12413
b3dadd76
LMI
12414 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
12415 key" (bug#4257).
12416
0cf34688
LMI
12417 * window.c (Fset_window_start): Doc fix (bug#4199).
12418 (Fset_window_hscroll): Ditto.
12419
270768cd
PE
124202011-07-12 Paul Eggert <eggert@cs.ucla.edu>
12421
077e3dda 12422 Fix minor new problems caught by GCC 4.6.1.
270768cd 12423 * term.c (init_tty): Remove unused local.
490011a6 12424 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 12425 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 12426 not used otherwise.
270768cd 12427
b1f58454
CY
124282011-07-12 Chong Yidong <cyd@stupidchicken.com>
12429
12430 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
12431
22b9578d
LMI
124322011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
12433
6e70ab07
LMI
12434 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
12435 are the mini-buffer and the echo area (bug#3320).
12436
22b9578d
LMI
12437 * term.c (init_tty): Remove support for supdup, c10 and perq
12438 terminals, which are no longer supported (bug#1482).
12439
8974cc9f
JB
124402011-07-10 Johan Bockgård <bojohan@gnu.org>
12441
12442 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
12443
a560d974
JD
124442011-07-10 Jan Djärv <jan.h.d@swipnet.se>
12445
12446 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
12447 for non-popups (Bug#3642).
12448
1dae0f0a
AS
124492011-07-10 Andreas Schwab <schwab@linux-m68k.org>
12450
268c2c36 12451 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 12452 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
12453 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
12454 * cm.c (losecursor): Likewise.
1dae0f0a
AS
12455 * data.c (fmod): Likewise.
12456 * dispnew.c (swap_glyphs_in_rows): Likewise.
12457 * emacs.c (memory_warning_signal): Likewise.
12458 * floatfns.c (float_error): Likewise.
12459 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
12460 (otf_open, font_otf_capability, generate_otf_features)
12461 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
12462 Likewise.
12463 * image.c (pbm_read_file): Likewise.
12464 * indent.c (string_display_width): Likewise.
12465 * intervals.c (check_for_interval, search_for_interval)
12466 (inc_interval_count, count_intervals, root_interval)
12467 (adjust_intervals_for_insertion, make_new_interval): Likewise.
12468 * lread.c (defalias): Likewise.
268c2c36 12469 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
12470 * regex.c (set_image_of_range_1, set_image_of_range)
12471 (regex_grow_registers): Likewise.
12472 * sysdep.c (strerror): Likewise.
12473 * termcap.c (valid_filename_p, tprint, main): Likewise.
12474 * tparam.c (main): Likewise.
12475 * unexhp9k800.c (run_time_remap, save_data_space)
12476 (update_file_ptrs, read_header, write_header, calculate_checksum)
12477 (copy_file, copy_rest, display_header): Likewise.
12478 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
12479 Likewise.
12480 * xdisp.c (check_it): Likewise.
12481 * xfaces.c (register_color, unregister_color, unregister_colors):
12482 Likewise.
12483 * xfns.c (print_fontset_result): Likewise.
12484 * xrdb.c (member, fatal, main): Likewise.
12485
99033785
PE
124862011-07-10 Paul Eggert <eggert@cs.ucla.edu>
12487
12488 Fix minor problems found by static checking (Bug#9031).
12489 * chartab.c (char_table_set_range, map_sub_char_table):
12490 Remove unused locals.
12491 (uniprop_table): Now static.
12492 * composite.c (_work_char): Remove unused static var.
12493
9cb2ac56
JB
124942011-07-09 Juanma Barranquero <lekktu@gmail.com>
12495
12496 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
12497
f25661f0
JD
124982011-07-09 Jan Djärv <jan.h.d@swipnet.se>
12499
12500 * gtkutil.c (qttip_cb): Remove code without function.
12501
8278c4fe
EZ
125022011-07-09 Eli Zaretskii <eliz@gnu.org>
12503
12504 * w32.c (pthread_sigmask): New stub.
12505
1692ae2d 125062011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 12507
8a6ebd58 12508 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
12509 sigprocmask is portable only for single-threaded applications, and
12510 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
12511 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
12512 (LIBES): Use it.
12513 * callproc.c (Fcall_process):
12514 * process.c (create_process):
12515 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
12516 Use pthread_sigmask, not sigprocmask.
123403e4 12517
1b854618
JD
125182011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12519
12520 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
12521 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
12522 wrong (Bug#8591).
12523
3fe4b549
JD
125242011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12525
0ce7e563
JD
12526 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
12527 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
12528 (xg_hide_tooltip): Fix comment.
12529
3fe4b549
JD
12530 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
12531 in registerServicesMenuSendTypes.
12532 (validRequestorForSendType): Don't check ns_return_types.
12533
12534 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
12535 ns_return_type.
12536
5df75e47
JR
125372011-07-08 Jason Rumney <jasonr@gnu.org>
12538
22610910
JR
12539 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
12540 SH_SHOW for hidden windows (Bug#5482).
12541
5df75e47
JR
12542 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
12543 frame struct members of non-existent frames (Bug#6284).
12544
699c10bd
JD
125452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12546
4393663b
JD
12547 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
12548 variable firstTime not needed on OSX >= 10.6.
12549 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
12550 >= 10.5. Use setKnobProportion, setDoubleValue.
12551
12552 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
12553 (MAC_OS_X_VERSION_10_5): Define if not defined.
12554 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
12555 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
12556 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
12557
12558 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 12559 cString and lossyCString on OSX >= 10.4.
4393663b 12560
58179cce 12561 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
12562 sizeToFit on OSX >= 10.2.
12563
12564 * nsimage.m (allocInitFromFile): Don't use deprecated method
12565 bestRepresentationForDevice on OSX >= 10.6.
12566
12567 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
12568 to avoid warning.
12569
12570 * emacs.c: Declare unexec_init_emacs_zone.
12571
a63e0781
JD
12572 * nsgui.h: Fix compiler warning about gnulib redefining verify.
12573
699c10bd
JD
12574 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
12575
12576 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
12577 on svcsMenu (Bug#8842).
12578
12579 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
12580 ns_return_types.
12581 (Fns_list_services): Just return Qnil on 10.6, code not working there.
12582
12583 * nsterm.m (QUTF8_STRING): Declare.
12584 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
12585 (validRequestorForSendType): Return type is (id).
12586 Change indexOfObjectIdenticalTo to indexOfObject.
12587 Check if we have local selection before returning self (Bug#8842).
12588 (writeSelectionToPasteboard): Put local selection into paste board
12589 if we have a local selection (Bug#8842).
12590 (syms_of_nsterm): DEFSYM QUTF8_STRING.
12591
12592 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
12593 (ns_get_local_selection): Declare.
12594
54e10184
LMI
125952011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
12596
9888ff71
LMI
12597 * keymap.c (describe_map_tree): Don't insert a double newline at
12598 the end of the buffer (bug#1169) and return whether we inserted
12599 something.
12600
54e10184
LMI
12601 * callint.c (Fcall_interactively): Change "reading args" to
12602 "providing args" to try to clarify what it does (bug#1010).
12603
15fa4783
KH
126042011-07-07 Kenichi Handa <handa@m17n.org>
12605
12606 * composite.c (composition_compute_stop_pos): Ignore a static
12607 composition starting before CHARPOS (Bug#8915).
12608
12609 * xdisp.c (handle_composition_prop): Likewise.
12610
a8815b00
EZ
126112011-07-07 Eli Zaretskii <eliz@gnu.org>
12612
12613 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
12614 (Bug#9015)
12615
ef7b981d 126162011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
12617
12618 * character.h (unicode_category_t): New enum type.
12619
12620 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
12621 (Qchar_code_property_table): New variable.
12622 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
12623 (UNIPROP_COMPRESSED_FORM_P): New macros.
12624 (char_table_ascii): Uncompress the compressed values.
12625 (sub_char_table_ref): New arg is_uniprop. Callers changed.
12626 Uncompress the compressed values.
ac389d0c 12627 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
12628 (char_table_ref_and_range): Uncompress the compressed values.
12629 (sub_char_table_set): New arg is_uniprop. Callers changed.
12630 Uncompress the compressed values.
12631 (sub_char_table_set_range): Args changed. Callers changed.
12632 (char_table_set_range): Adjuted for the above change.
12633 (map_sub_char_table): Delete args default_val and parent. Add arg
12634 top. Give decoded values to a Lisp function.
640c8776 12635 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
12636 values to a Lisp function. Gcpro more variables.
12637 (uniprop_table_uncompress)
12638 (uniprop_decode_value_run_length): New functions.
12639 (uniprop_decoder, uniprop_decoder_count): New variables.
12640 (uniprop_get_decoder, uniprop_encode_value_character)
12641 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
12642 New functions.
12643 (uniprop_encoder, uniprop_encoder_count): New variables.
12644 (uniprop_get_encoder, uniprop_table)
12645 (Funicode_property_table_internal, Fget_unicode_property_internal)
12646 (Fput_unicode_property_internal): New functions.
12647 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
12648 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 12649 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
12650 char-code-property-alist.
12651
640c8776 12652 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
12653 Vunicode_category_table.
12654
640c8776 12655 * font.c (font_range): Adjust for the change of
c805dec0
KH
12656 Vunicode_category_table.
12657
76b397fb
DN
126582011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
12659
12660 * m/iris4d.h: Remove file, move contents ...
12661 * s/irix6-5.h: ... here.
12662
22b4128e
PE
126632011-07-06 Paul Eggert <eggert@cs.ucla.edu>
12664
12665 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
12666 * alloc.c (mark_buffer):
12667 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
12668 (clone_per_buffer_values): Don't assume that
22b4128e
PE
12669 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
12670 This isn't true in general, and it's particularly not true
12671 if Emacs is configured with --with-wide-int.
12672 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
12673 New macros, used in the buffer.c change.
12674
869795d6
JD
126752011-07-05 Jan Djärv <jan.h.d@swipnet.se>
12676
12677 * xsettings.c: Use both GConf and GSettings if both are available.
12678 (store_config_changed_event): Add comment.
12679 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
12680 (store_tool_bar_style_changed): New functions.
5e617bc2 12681 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
12682 (struct xsettings): Move font inside HAVE_XFT.
12683 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 12684 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 12685 Move inside HAVE_XFT.
640c8776 12686 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
12687 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
12688 also.
12689 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 12690 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 12691 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
12692 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
12693 (parse_settings): Move check for font inside HAVE_XFT.
12694 (read_settings, apply_xft_settings): Add comment.
12695 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
12696 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
12697 call store_font_name_changed.
12698 (xft_settings_event): Add comment.
12699 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
12700 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
12701 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
12702 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
12703 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
12704 (xsettings_get_system_font, xsettings_get_system_normal_font):
12705 Add comment.
869795d6 12706
d8ed26bd
PE
127072011-07-05 Paul Eggert <eggert@cs.ucla.edu>
12708
12709 Random fixes. E.g., (random) never returned negative values.
12710 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
12711 subseconds part to the entropy, as that's a bit more random.
12712 Prefer signed to unsigned, since the signedness doesn't matter and
12713 in general we prefer signed. When given a limit, use a
12714 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
12715 latter isn't right if USE_2_TAGS_FOR_INTS.
12716 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
12717 not 0..VALMASK. Don't discard "excess" bits that random () returns.
12718
cabf1cac
SM
127192011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
12720
12721 * textprop.c (text_property_stickiness):
12722 Obey Vtext_property_default_nonsticky.
12723 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
12724 * w32fns.c (syms_of_w32fns):
12725 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
12726
6e9b2be9
PE
127272011-07-04 Paul Eggert <eggert@cs.ucla.edu>
12728
12729 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
12730 This is more efficient than Ffile_directory_p and avoids a minor race.
12731
90186c68
LMI
127322011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
12733
7c301272
LMI
12734 * buffer.c (Foverlay_put): Say what the return value is
12735 (bug#7835).
12736
c4f2d8d4
LMI
12737 * fileio.c (barf_or_query_if_file_exists): Check first if the file
12738 is a directory before asking whether to use the file name
12739 (bug#7564).
ad637907
LMI
12740 (barf_or_query_if_file_exists): Make the "File is a directory"
12741 error be more correct.
c4f2d8d4 12742
90186c68
LMI
12743 * fns.c (Frequire): Remove the mention of the .gz files, since
12744 that's installation-specific, but keep the mention of
12745 `get-load-suffixes'.
12746
da64016e
PE
127472011-07-04 Paul Eggert <eggert@cs.ucla.edu>
12748
12749 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
12750 Report string overflow if the output is too long.
12751
7d47b580
JB
127522011-07-04 Juanma Barranquero <lekktu@gmail.com>
12753
a555cb87
JB
12754 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
12755 (syms_of_gnutls): Remove duplicate DEFSYM for
12756 Qgnutls_bootprop_verify_hostname_error, an error for
12757 Qgnutls_bootprop_verify_error (which is no longer used).
12758
7d47b580
JB
12759 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
12760 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
12761 Also (re)move comments that are misplaced or no longer relevant.
12762
1e49bfab
LMI
127632011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
12764
12765 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
12766
1485f4c0
CY
127672011-07-03 Chong Yidong <cyd@stupidchicken.com>
12768
12769 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
12770 and background color parameters if they have been changed.
12771
a9ab721e
LMI
127722011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
12773
12774 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
12775
cf7cff57
PE
127762011-07-03 Paul Eggert <eggert@cs.ucla.edu>
12777
2e13213d
PE
12778 * xsettings.c (SYSTEM_FONT): Define only when used.
12779 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
12780
cf7cff57
PE
12781 * keymap.c (access_keymap_1): Now static.
12782
7a8e04f7
CY
127832011-07-02 Chong Yidong <cyd@stupidchicken.com>
12784
12785 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
12786 leave any prefix arg for the up event (Bug#1586).
12787
61352f62
LMI
127882011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
12789
69bb1ef7
LMI
12790 * lread.c (syms_of_lread): Mention single symbols defined by
12791 `defvar' or `defconst' (bug#7154).
12792
61352f62 12793 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 12794 (Frequire): Mention get-load-suffixes.
61352f62 12795
28545e04
MR
127962011-07-02 Martin Rudalics <rudalics@gmx.at>
12797
12798 * window.h (window): Remove clone_number slot.
12799 * window.c (Fwindow_clone_number, Fset_window_clone_number):
12800 Remove.
12801 (make_parent_window, make_window, saved_window)
12802 (Fset_window_configuration, save_window_save): Don't deal with
12803 clone numbers.
12804 * buffer.c (Qclone_number): Remove declaration.
12805 (sort_overlays, overlay_strings): Don't deal with clone numbers.
12806
3349e122
SM
128072011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
12808
12809 Add multiple inheritance to keymaps.
12810 * keymap.c (Fmake_composed_keymap): New function.
12811 (Fset_keymap_parent): Simplify.
12812 (fix_submap_inheritance): Remove.
12813 (access_keymap_1): New function extracted from access_keymap to handle
12814 embedded parents and handle lists of maps.
12815 (access_keymap): Use it.
12816 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
12817 (Fcopy_keymap): Handle embedded parents.
12818 (Fcommand_remapping, define_as_prefix): Simplify.
12819 (Fkey_binding): Simplify.
12820 (syms_of_keymap): Move minibuffer-local-completion-map,
12821 minibuffer-local-filename-completion-map,
12822 minibuffer-local-must-match-map, and
12823 minibuffer-local-filename-must-match-map to Elisp.
12824 (syms_of_keymap): Defsubr make-composed-keymap.
12825 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
12826 (parse_menu_item): Trivial simplification.
12827
3279eb87
GM
128282011-07-01 Glenn Morris <rgm@gnu.org>
12829
12830 * Makefile.in (SETTINGS_LIBS): Fix typo.
12831
39cb9e56 128322011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
12833
12834 * coding.c (Fencode_coding_string): Record the last coding system
12835 used, as the function doc string says (bug#8738).
12836
0949d2b6
JD
128372011-07-01 Jan Djärv <jan.h.d@swipnet.se>
12838
12839 * xsettings.c (store_monospaced_changed): Take new font as arg and
12840 check for change against current_mono_font.
12841 (EMACS_TYPE_SETTINGS): Remove this and related defines.
12842 (emacs_settings_constructor, emacs_settings_get_property)
12843 (emacs_settings_set_property, emacs_settings_class_init)
12844 (emacs_settings_init, gsettings_obj): Remove.
12845 (something_changedCB): New function for HAVE_GSETTINGS.
12846 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
12847 with value as argument.
12848 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
12849 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 12850 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
12851 "changed".
12852
12853 * xgselect.c: Add defined (HAVE_GSETTINGS).
12854 (xgselect_initialize): Ditto.
12855
12856 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
12857 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
12858 xg_select.
12859
bbc6b304
PE
128602011-07-01 Paul Eggert <eggert@cs.ucla.edu>
12861
12862 * eval.c (struct backtrace): Simplify and port the data structure.
12863 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
12864 signed bit field, as this assumption is not portable and it makes
12865 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
12866 "char debug_on_exit : 1" as this is not portable either; instead,
12867 use the portable "unsigned int debug_on_exit : 1". Remove unused
12868 member evalargs. Remove obsolete comments about cc bombing out.
12869
9851bfc5
JD
128702011-06-30 Jan Djärv <jan.h.d@swipnet.se>
12871
51bb811f 12872 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
12873 Let HAVE_GSETTINGS override HAVE_GCONF.
12874 (store_monospaced_changed): New function.
12875 (EMACS_SETTINGS): A new type derived from GObject to handle
12876 GSettings notifications.
12877 (emacs_settings_constructor, emacs_settings_get_property)
12878 (emacs_settings_set_property, emacs_settings_class_init):
12879 New functions.
12880 (gsettings_client, gsettings_obj): New variables.
12881 (GSETTINGS_SCHEMA): New define.
12882 (something_changedCB): Call store_monospaced_changed.
12883 (init_gsettings): New function.
12884 (xsettings_initialize): Call init_gsettings.
12885 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
12886 to NULL.
12887
640c8776 12888 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
12889 GCONF_CFLAGS/LIBS.
12890
5386012d
MR
128912011-06-29 Martin Rudalics <rudalics@gmx.at>
12892
12893 * window.c (resize_root_window, grow_mini_window)
12894 (shrink_mini_window): Rename Qresize_root_window to
12895 Qwindow_resize_root_window and Qresize_root_window_vertically to
12896 Qwindow_resize_root_window_vertically.
12897
f13e0b08
PE
128982011-06-28 Paul Eggert <eggert@cs.ucla.edu>
12899
12900 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
12901
94515237
JB
129022011-06-27 Juanma Barranquero <lekktu@gmail.com>
12903
12904 * makefile.w32-in: Redesign dependencies so they reflect more
12905 clearly which files are directly included by each source file,
12906 and not through other includes.
12907
e43b6e43
MR
129082011-06-27 Martin Rudalics <rudalics@gmx.at>
12909
12910 * buffer.c (Qclone_number): Declare static and DEFSYM it.
12911 (sort_overlays, overlay_strings): When an overlay's clone number
12912 matches the window's clone number process the overlay even if
12913 the overlay's window property doesn't match the current window.
12914
d68443dc
MR
12915 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
12916 (Fwindow_hchild): Rename to Fwindow_left_child.
12917 (Fwindow_next): Rename to Fwindow_next_sibling.
12918 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
12919 (resize_window_check): Rename to window_resize_check.
12920 (resize_window_apply): Rename to window_resize_apply.
12921 (Fresize_window_apply): Rename to Fwindow_resize_apply.
12922 (Fdelete_other_windows_internal, resize_frame_windows)
12923 (Fsplit_window_internal, Fdelete_window_internal)
12924 (grow_mini_window, shrink_mini_window)
12925 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 12926
c7e73be5
JD
129272011-06-26 Jan Djärv <jan.h.d@swipnet.se>
12928
12929 * emacsgtkfixed.h: State that this is only used with Gtk+3.
12930 (emacs_fixed_set_min_size): Remove.
12931 (emacs_fixed_new): Take frame as argument.
12932
12933 * emacsgtkfixed.c: State that this is only used with Gtk+3.
12934 (_EmacsFixedPrivate): Remove minwidth/height.
12935 Add struct frame *f.
12936 (emacs_fixed_init): Initialize priv->f.
12937 (get_parent_class, emacs_fixed_set_min_size): Remove.
12938 (emacs_fixed_new): Set priv->f to argument.
12939 (emacs_fixed_get_preferred_width)
12940 (emacs_fixed_get_preferred_height): Use min_width/height from
12941 frames size_hint to set minimum and natural (Bug#8919).
12942 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
12943 and use min_width/height from frames size_hint to set
12944 min_width/height (Bug#8919).
12945
12946 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
12947 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
12948 Fix indentation.
c7e73be5 12949
cf99dcf8
EZ
129502011-06-26 Eli Zaretskii <eliz@gnu.org>
12951
12952 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
12953 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
12954 called at ZV.
12955
029529ac
CY
129562011-06-26 Chong Yidong <cyd@stupidchicken.com>
12957
12958 * process.c (wait_reading_process_output): Bypass select if
12959 waiting for a cell while ignoring keyboard input, and input is
12960 pending. Suggested by Jan Djärv (Bug#8869).
12961
7a7ef429
PE
129622011-06-25 Paul Eggert <eggert@cs.ucla.edu>
12963
12964 Use gnulib's dup2 module instead of rolling our own.
12965 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
12966
11fdef7d 129672011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
12968
12969 * dispnew.c (scrolling_window): Before scrolling, turn off a
12970 mouse-highlight in the window being scrolled.
12971
cd3520a4
JB
129722011-06-24 Juanma Barranquero <lekktu@gmail.com>
12973
12974 Move DEFSYM to lisp.h and use everywhere.
12975
12976 * character.h (DEFSYM): Move declaration...
12977 * lisp.h (DEFSYM): ...here.
12978
12979 * gnutls.c:
12980 * minibuf.c:
12981 * w32menu.c:
12982 * w32proc.c:
12983 * w32select.c: Don't include character.h.
12984
12985 * alloc.c (syms_of_alloc):
12986 * buffer.c (syms_of_buffer):
12987 * bytecode.c (syms_of_bytecode):
12988 * callint.c (syms_of_callint):
12989 * casefiddle.c (syms_of_casefiddle):
12990 * casetab.c (init_casetab_once):
12991 * category.c (init_category_once, syms_of_category):
12992 * ccl.c (syms_of_ccl):
12993 * cmds.c (syms_of_cmds):
12994 * composite.c (syms_of_composite):
12995 * dbusbind.c (syms_of_dbusbind):
12996 * dired.c (syms_of_dired):
12997 * dispnew.c (syms_of_display):
12998 * doc.c (syms_of_doc):
12999 * editfns.c (syms_of_editfns):
13000 * emacs.c (syms_of_emacs):
13001 * eval.c (syms_of_eval):
13002 * fileio.c (syms_of_fileio):
13003 * fns.c (syms_of_fns):
13004 * frame.c (syms_of_frame):
13005 * fringe.c (syms_of_fringe):
13006 * insdel.c (syms_of_insdel):
13007 * keymap.c (syms_of_keymap):
13008 * lread.c (init_obarray, syms_of_lread):
13009 * macros.c (syms_of_macros):
13010 * msdos.c (syms_of_msdos):
13011 * print.c (syms_of_print):
13012 * process.c (syms_of_process):
13013 * search.c (syms_of_search):
13014 * sound.c (syms_of_sound):
13015 * syntax.c (init_syntax_once, syms_of_syntax):
13016 * terminal.c (syms_of_terminal):
13017 * textprop.c (syms_of_textprop):
13018 * undo.c (syms_of_undo):
13019 * w32.c (globals_of_w32):
13020 * window.c (syms_of_window):
13021 * xdisp.c (syms_of_xdisp):
13022 * xfaces.c (syms_of_xfaces):
13023 * xfns.c (syms_of_xfns):
13024 * xmenu.c (syms_of_xmenu):
13025 * xsettings.c (syms_of_xsettings):
13026 * xterm.c (syms_of_xterm): Use DEFSYM.
13027
4228cf16
TZ
130282011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
13029
cd3520a4 13030 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 13031
7fcccf1e
PE
130322011-06-23 Paul Eggert <eggert@cs.ucla.edu>
13033
7efb4e0e
PE
13034 Integer and buffer overflow fixes (Bug#8873).
13035
ff5844ad
PE
13036 * print.c (printchar, strout): Check for string overflow.
13037 (PRINTPREPARE, printchar, strout):
13038 Don't set size unless allocation succeeds.
13039
90532f02
PE
13040 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
13041 for sizes. Check for string overflow more accurately.
13042 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
13043
6d84508d
PE
13044 * macros.c: Integer and buffer overflow fixes.
13045 * keyboard.h (struct keyboard.kbd_macro_bufsize):
13046 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
13047 Use ptrdiff_t, not int, for sizes.
13048 Don't increment bufsize until after realloc succeeds.
13049 Check for size-calculation overflow.
13050 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
13051
437b2cb4
PE
13052 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
13053
8b9ac8b4
PE
13054 * lread.c: Integer overflow fixes.
13055 (read_integer): Radix is now EMACS_INT, not int,
13056 to improve quality of diagnostics for out-of-range radices.
13057 Calculate buffer size correctly for out-of-range radices.
13058 (read1): Check for integer overflow in radices, and in
13059 read-circle numbers.
82cb60d3
PE
13060 (read_escape): Avoid int overflow.
13061 (Fload, openp, read_buffer_size, read1)
13062 (substitute_object_recurse, read_vector, read_list, map_obarray):
13063 Use ptrdiff_t, not int, for sizes.
13064 (read1): Use EMACS_INT, not int, for sizes.
20270765 13065 Check for size overflow.
8b9ac8b4 13066
7fcccf1e
PE
13067 * image.c (cache_image): Check for size arithmetic overflow.
13068
bfbbd7e7
PE
13069 * lread.c: Integer overflow issues.
13070 (saved_doc_string_size, saved_doc_string_length)
13071 (prev_saved_doc_string_size, prev_saved_doc_string_length):
13072 Now ptrdiff_t, not int.
13073 (read1): Don't assume doc string length fits in int. Check for
13074 out-of-range doc string lengths.
13075 (read_list): Don't assume file position fits in int.
39019e54 13076 (read_escape): Check for hex character overflow.
bfbbd7e7 13077
4e323265
LL
130782011-06-22 Leo Liu <sdl.web@gmail.com>
13079
13080 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
13081 Move to minibuffer.el.
13082
85fece3e
PE
130832011-06-22 Paul Eggert <eggert@cs.ucla.edu>
13084
20b84ce9 13085 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
13086 The following patches are for when GLYPH_DEBUG && !XASSERT.
13087 * dispextern.h (trace_redisplay_p, dump_glyph_string):
13088 * dispnew.c (flush_stdout):
13089 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
13090 Mark as externally visible.
13091 * dispnew.c (check_window_matrix_pointers): Now static.
13092 * dispnew.c (window_to_frame_vpos):
13093 * xfns.c (unwind_create_frame):
13094 * xterm.c (x_check_font): Remove unused local.
13095 * scroll.c (CHECK_BOUNDS):
13096 * xfaces.c (cache_fache): Rename local to avoid shadowing.
13097 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
13098 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
13099 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
13100 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
13101 Now static.
13102 (debug_method_add): Use va_list and vsprintf rather than relying
13103 on undefined behavior with wrong number of arguments.
13104 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
13105 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
13106 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
13107 since we're not interested in debugging glyphs with old libraries.
13108 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
13109 GCC 4.6.0's static checking.
13110
0766b489
PE
131112011-06-22 Paul Eggert <eggert@cs.ucla.edu>
13112
31fd4b32
PE
13113 Integer overflow and signedness fixes (Bug#8873).
13114 A few related buffer overrun fixes, too.
13115
b79e8648
PE
13116 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
13117
0766b489
PE
13118 * dispextern.h (struct face.stipple):
13119 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
13120 (x_bitmap_mask, x_allocate_bitmap_record)
13121 (x_create_bitmap_from_data, x_create_bitmap_from_file)
13122 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
13123 (x_create_bitmap_from_xpm_data):
13124 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
13125 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
13126 (.bitmaps_last):
13127 * xfaces.c (load_pixmap):
13128 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
13129 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
13130 (.bitmaps_last, struct x_output.icon_bitmap):
13131 Use ptrdiff_t, not int, for bitmap indexes.
13132 (x_allocate_bitmap_record): Check for size overflow.
13133 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
13134
b081724f
PE
13135 Use ptrdiff_t, not int, for overlay counts.
13136 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
13137 * editfns.c (overlays_around, get_pos_property):
13138 * textprop.c (get_char_property_and_overlay):
13139 * xdisp.c (next_overlay_change, note_mouse_highlight):
13140 * xfaces.c (face_at_buffer_position):
21514da7
PE
13141 * buffer.c (OVERLAY_COUNT_MAX): New macro.
13142 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
13143 (Fnext_overlay_change, Fprevious_overlay_change)
13144 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 13145 Use ptrdiff_t, not int, for sizes.
21514da7 13146 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 13147
3de73e5e
PE
13148 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
13149
2606c57b
PE
13150 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
13151 (x_session_initialize): Do not assume string length fits in int.
13152
aaafe47a
PE
13153 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
13154 This is unlikely, but can occur if DPI is outlandish.
13155
2674ddc8 13156 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
13157 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
13158
28154962
PE
13159 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
13160 * xrdb.c (magic_file_p, search_magic_path):
13161 Omit last arg SUFFIX; it was always 0. All callers changed.
13162 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
13163
7de51af5
PE
13164 * xfont.c (xfont_match): Avoid need for strlen.
13165
25ed6cc3
PE
13166 * xfns.c: Don't assume strlen fits in int.
13167 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
13168
4eab31dd
PE
13169 * xdisp.c (message_log_check_duplicate): Return intmax_t,
13170 not unsigned long, as we prefer signed integers. All callers changed.
13171 Detect integer overflow in repeat count.
13172 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 13173 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 13174
171e2a58
PE
13175 * termcap.c: Don't assume sizes fit in int and never overflow.
13176 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
13177 (gobble_line): Check for size-calculation overflow.
13178
ad39faca 13179 * minibuf.c (Fread_buffer):
6e5bb2dc 13180 * lread.c (intern, intern_c_string):
74ca2eb3
PE
13181 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
13182 Don't assume string length fits in int.
13183
52c61c22 13184 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
13185 * gtkutil.c (style_changed_cb): Avoid need for strlen.
13186
b5b8c9e5
PE
13187 * font.c: Don't assume string length fits in int.
13188 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
13189 Use ptrdiff_t, not int.
ccd6111c
PE
13190 (font_intern_prop): Don't assume string length fits in int.
13191 Don't assume integer property fits in fixnum.
13192 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 13193
882f0d81 13194 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 13195 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
13196 Reformulate so as not to need the command string.
13197 Invoke gzip -cd rather than gunzip, as it's more portable.
13198 (lock_info_type, lock_file_1, lock_file):
13199 Don't assume pid_t and time_t fit in unsigned long.
13200 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
13201 (current_lock_owner): Prefer signed type for sizes.
13202 Use memcpy, not strncpy, where memcpy is what is really wanted.
13203 Don't assume (via atoi) that time_t and pid_t fit in int.
13204 Check for time_t and/or pid_t out of range, e.g., via a network share.
13205 Don't alloca where an auto var works fine.
13206
93f4cf88
PE
13207 * fileio.c: Fix some integer overflow issues.
13208 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
13209 Don't assume string length fits in int.
13210 (directory_file_name): Don't assume string length fits in long.
13211 (make_temp_name): Don't assume pid fits in int, or that its print
13212 length is less than 20.
13213
f3e92b69
PE
13214 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
13215
1bfdaf10
PE
13216 * coding.c (make_subsidiaries): Don't assume string length fits in int.
13217
35016e9a
PE
13218 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
13219
3d1e65a1
PE
13220 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
13221 We prefer signed integers, even for size calculations.
13222
0b963a93
PE
13223 * emacs.c: Don't assume string length fits in 'int'.
13224 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
13225 (main): Don't invoke strlen when not needed.
13226
573f4b54
PE
13227 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
13228 (XD_DEBUG_MESSAGE): Don't waste a byte.
13229
989f33ba
PE
13230 * callproc.c (getenv_internal_1, getenv_internal)
13231 (Fgetenv_internal):
965d34eb
PE
13232 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
13233
e4d29b33
PE
13234 * lread.c (invalid_syntax): Omit length argument.
13235 All uses changed. This doesn't fix a bug, but it simplifies the
13236 code away from its former Hollerith-constant appearance, and it's
13237 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 13238 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 13239
eb49b136
PE
13240 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
13241 This didn't break anything, but it didn't help either.
13242 It's confusing to put a bogus integer in a place where the actual
13243 value does not matter.
9f62aeb1 13244 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 13245 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 13246
15375a22
PE
13247 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
13248 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
13249 implementation.
b61cc01c
PE
13250 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
13251 We prefer signed types, and the value cannot exceed the EMACS_INT
13252 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
13253 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
13254 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
13255 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 13256
53b2623d
PE
13257 * indent.c (sane_tab_width): New function.
13258 (current_column, scan_for_column, Findent_to, position_indentation)
13259 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 13260 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 13261
51cab52b 13262 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 13263
f2ed8a70
PE
13264 * lisp.h (lint_assume): New macro.
13265 * composite.c (composition_gstring_put_cache):
13266 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
13267
abe80cc6
PE
13268 * editfns.c, insdel.c:
13269 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 13270
b02c740e
PE
13271 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
13272
ebc96716
PE
13273 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
13274
b4e50fa0 13275 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 13276 Use much-faster test for byte-length change.
311d5d7c 13277 Don't assume string byte-length fits in 'int'.
a4cf38e4 13278 Check that character arg fits in 'int'.
85461888 13279 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 13280
c0c1ee9f
PE
13281 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
13282
a498d7f4
PE
13283 * fns.c (concat): Catch string overflow earlier.
13284 Do not rely on integer wraparound.
13285
51cab52b
PE
13286 * dispextern.h (struct it.overlay_strings_charpos)
13287 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
13288 * xdisp.c (forward_to_next_line_start)
13289 (back_to_previous_visible_line_start)
13290 (reseat_at_next_visible_line_start, next_element_from_buffer):
13291 Don't arbitrarily truncate the value of 'selective' to int.
13292
76031fad
PE
13293 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
13294
5eb55db9
PE
13295 * composite.c: Don't truncate sizes to 'int'.
13296 (composition_gstring_p, composition_reseat_it)
13297 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
13298 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
13299 not EMACS_UINT, for indexes.
5eb55db9 13300
0703a717
PE
13301 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
13302
d6202519
PE
13303 * buffer.c: Include <verify.h>.
13304 (struct sortvec.priority, struct sortstr.priority):
8961a454 13305 Now EMACS_INT, not int.
c20998a7 13306 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
13307 (struct sortstr.size, record_overlay_string)
13308 (struct sortstrlist.size, struct sortlist.used):
13309 Don't truncate size to int.
13310 (record_overlay_string): Check for size-calculation overflow.
d6202519 13311 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 13312
d5a19415
JM
133132011-06-22 Jim Meyering <meyering@redhat.com>
13314
029529ac 13315 Don't leak an XBM-image-sized buffer
d5a19415
JM
13316 * image.c (xbm_load): Free the image buffer after using it.
13317
a9041e6c
PE
133182011-06-21 Paul Eggert <eggert@cs.ucla.edu>
13319
13320 Port to Sun C.
13321 * composite.c (find_automatic_composition): Omit needless 'return 0;'
13322 that Sun C diagnosed.
13323 * fns.c (secure_hash): Fix pointer signedness issue.
13324 * intervals.c (static_offset_intervals): New function.
13325 (offset_intervals): Use it.
13326
7f3f739f
LL
133272011-06-21 Leo Liu <sdl.web@gmail.com>
13328
13329 * deps.mk (fns.o):
13330 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
13331 sha512.h.
13332
13333 * fns.c (secure_hash): Rename from crypto_hash_function and change
13334 the first arg to accept symbols.
5b66d427 13335 (Fsecure_hash): New primitive.
7f3f739f
LL
13336 (syms_of_fns): New symbols.
13337
76147d94
DD
133382011-06-20 Deniz Dogan <deniz@dogan.se>
13339
13340 * process.c (Fset_process_buffer): Clarify return value in
13341 docstring.
13342
7d7d0045
CY
133432011-06-18 Chong Yidong <cyd@stupidchicken.com>
13344
13345 * dispnew.c (add_window_display_history): Use BVAR.
13346
13347 * xdisp.c (debug_method_add): Use BVAR.
13348 (check_window_end, dump_glyph_matrix, dump_glyph)
13349 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
13350
13351 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
13352 Likewise.
13353
13354 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
13355 check till after the cache is created in init_frame_faces.
13356
ff2bc410
SM
133572011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
13358
13359 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
13360
28177add
PE
133612011-06-16 Paul Eggert <eggert@cs.ucla.edu>
13362
dd3482fe
PE
13363 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
13364 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
13365 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
13366
393d71f3 13367 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
13368 * fileio.c (Finsert_file_contents):
13369 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
13370 Remove the old (too-loose) buffer overflow checks.
13371 They weren't needed, since make_gap checks for buffer overflow.
13372 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
13373 The old code merely checked for Emacs fixnum overflow, and relied
13374 on undefined (wraparound) behavior. The new code avoids undefined
13375 behavior, and also checks for ptrdiff_t and/or size_t overflow.
13376
2e6813b0 13377 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
13378 Tune. Don't use wider integers than needed. Don't use alloca.
13379 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 13380
599a9e4f
PE
13381 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
13382
99561444
PE
13383 * insdel.c, lisp.h (buffer_overflow): New function.
13384 (insert_from_buffer_1, replace_range, replace_range_2):
13385 * insdel.c (make_gap_larger):
13386 * editfns.c (Finsert_char):
13387 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
13388
28177add
PE
13389 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
13390
e69dafad
PE
133912011-06-15 Paul Eggert <eggert@cs.ucla.edu>
13392
4baa020d 13393 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 13394
b1c46f02
PE
13395 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
13396 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
13397
e69dafad
PE
13398 * fileio.c: Don't assume EMACS_INT fits in off_t.
13399 (emacs_lseek): New static function.
13400 (Finsert_file_contents, Fwrite_region): Use it.
13401 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
13402
566684ea
PE
13403 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
13404
e6966cd6
PE
13405 * fns.c: Don't overflow int when computing a list length.
13406 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
13407 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
13408 truncation on 64-bit hosts. Check for QUIT every
13409 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
13410 faster and is responsive enough.
13411 (Flength): Report an error instead of overflowing an integer.
13412 (Fsafe_length): Return a float if the value is not representable
13413 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 13414 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 13415 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 13416
dd0b0efb
PE
13417 * alloc.c: Check that resized vectors' lengths fit in fixnums.
13418 (header_size, word_size): New constants.
13419 (allocate_vectorlike): Don't check size overflow here.
13420 (allocate_vector): Check it here instead, since this is the only
13421 caller of allocate_vectorlike that could cause overflow.
13422 Check that the new vector's length is representable as a fixnum.
13423
86fe5cfe
PE
13424 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
13425 The previous code was bogus. For example, next_almost_prime (32)
13426 returned 39, which is undesirable as it is a multiple of 3; and
13427 next_almost_prime (24) returned 25, which is a multiple of 5 so
13428 why was the code bothering to check for multiples of 7?
13429
80e88859
PE
13430 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
13431
4a2f0ad6
PE
13432 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
13433
f66c7cf8
PE
13434 Variadic C functions now count arguments with ptrdiff_t.
13435 This partly undoes my 2011-03-30 change, which replaced int with size_t.
13436 Back then I didn't know that the Emacs coding style prefers signed int.
13437 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
13438 were being counted with int, which may truncate counts on 64-bit
13439 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
13440 * lisp.h (struct Lisp_Subr.function.aMANY)
13441 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
13442 Arg counts are now ptrdiff_t, not size_t.
13443 All variadic functions and their callers changed accordingly.
13444 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
13445 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
13446 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
13447 * callint.c (Fcall_interactively): Check arg count for overflow,
13448 to avoid potential buffer overrun. Use signed char, not 'int',
13449 for 'varies' array, so that we needn't bother to check its size
13450 calculation for overflow.
13451 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
13452 * eval.c (apply_lambda):
13453 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
13454 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
13455 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
13456
a1759b76
PE
13457 * callint.c (Fcall_interactively): Don't use index var as event count.
13458
d96be9fc
PE
13459 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
13460 * mem-limits.h (SIZE): Remove; no longer used.
13461
a690a978 13462 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 13463
578c21e6
PE
13464 Remove unnecessary casts.
13465 * xterm.c (x_term_init):
13466 * xfns.c (x_set_border_pixel):
13467 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
13468 These aren't needed now that we assume ANSI C.
13469
96f53c6c
PE
13470 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
13471 It's more likely to cause problems (due to unsigned overflow)
13472 than to cure them.
13473
83c77d31
PE
13474 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
13475
ee2079f1
PE
13476 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
13477
6da65536
PE
13478 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
13479
7147c4a4
PE
13480 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
13481
193e32d9
PE
13482 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
13483
e5533da6
PE
13484 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
13485
9910e595
PE
13486 GLYPH_CODE_FACE returns EMACS_INT, not int.
13487 * dispextern.h (merge_faces):
13488 * xfaces.c (merge_faces):
01103c44
PE
13489 * xdisp.c (get_next_display_element, next_element_from_display_vector):
13490 Don't assume EMACS_INT fits in int.
9910e595 13491
2638320e
PE
13492 * character.h (CHAR_VALID_P): Remove unused parameter.
13493 * fontset.c, lisp.h, xdisp.c: All uses changed.
13494
045eb8d9
PE
13495 * editfns.c (Ftranslate_region_internal): Omit redundant test.
13496
c1f134b5
PE
13497 * fns.c (concat): Minor tuning based on overflow analysis.
13498 This doesn't fix any bugs. Use int to hold character, instead
13499 of constantly refetching from Emacs object. Use XFASTINT, not
13500 XINT, for value known to be a character. Don't bother comparing
13501 a single byte to 0400, as it's always less.
13502
395fcb93 13503 * floatfns.c (Fexpt):
327eeec8
PE
13504 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
13505
abbd3d23
PE
13506 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
13507 for characters.
13508
684a03ef
PE
13509 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
13510
0fed43f3
PE
13511 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
13512 Without this fix, on a 64-bit host (aset S 0 4294967386) would
13513 incorrectly succeed when S was a string, because 4294967386 was
13514 truncated before it was used.
13515
8fd02eb7
PE
13516 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
13517 Otherwise, an out-of-range integer could cause undefined behavior
13518 on a 64-bit host.
13519
f8c86b69
PE
13520 * composite.c: Use int, not EMACS_INT, for characters.
13521 (fill_gstring_body, composition_compute_stop_pos): Use int, not
13522 EMACS_INT, for values that are known to be in character range.
13523 This doesn't fix any bugs but is the usual style inside Emacs and
13524 may generate better code on 32-bit machines.
13525
34206dd2
PE
13526 Make sure a 64-bit char is never passed to ENCODE_CHAR.
13527 This is for reasons similar to the recent CHAR_STRING fix.
13528 * charset.c (Fencode_char): Check that character arg is actually
13529 a character. Pass an int to ENCODE_CHAR.
13530 * charset.h (ENCODE_CHAR): Verify that the character argument is no
13531 wider than 'int', as a compile-time check to prevent future regressions
13532 in this area.
13533
c5958d4c 13534 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
13535
13536 Make sure a 64-bit char is never passed to CHAR_STRING.
13537 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
13538 by silently ignoring the top 32 bits, allowing some values
13539 that were far too large to be valid characters.
13540 * character.h: Include <verify.h>.
13541 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
13542 arguments are no wider than unsigned, as a compile-time check
13543 to prevent future regressions in this area.
13544 * data.c (Faset):
01103c44 13545 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
13546 (Fsubst_char_in_region):
13547 * fns.c (concat):
13548 * xdisp.c (decode_mode_spec_coding):
13549 Adjust to CHAR_STRING's new requirement.
13550 * editfns.c (Finsert_char, Fsubst_char_in_region):
13551 * fns.c (concat): Check that character args are actually
13552 characters. Without this test, these functions did the wrong
13553 thing with wildly out-of-range values on 64-bit hosts.
13554
d37ca623
PE
13555 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
13556 These casts should not be needed on 32-bit hosts, either.
13557 * keyboard.c (read_char):
13558 * lread.c (Fload): Remove casts to unsigned.
13559
ea204efb
PE
13560 * lisp.h (UNSIGNED_CMP): New macro.
13561 This fixes comparison bugs on 64-bit hosts.
13562 (ASCII_CHAR_P): Use it.
13563 * casefiddle.c (casify_object):
01103c44 13564 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
13565 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
13566 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
13567 * dispextern.h (FACE_FROM_ID):
13568 * keyboard.c (read_char): Use UNSIGNED_CMP.
13569
41cb286c
PE
13570 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
13571 not to EMACS_INT, to avoid GCC warning.
13572
4a1b9832
PE
13573 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
13574
55daad71
PE
13575 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
13576 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
13577 isn't needed on 32-bit machines.
8f95c75c 13578
01103c44
PE
13579 * buffer.c (Fgenerate_new_buffer_name):
13580 Use EMACS_INT for count, not int.
0ceccced 13581 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
13582
13583 * data.c (Qcompiled_function): Now static.
13584
c6f072e7
PE
13585 * window.c (window_body_lines): Now static.
13586
20ce5912
PE
13587 * image.c (gif_load): Rename local to avoid shadowing.
13588
9c4c5f81
PE
13589 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
13590 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
13591 * alloc.c (make_save_value): Integer argument is now of type
13592 ptrdiff_t, not int.
13593 (mark_object): Use ptrdiff_t, not int.
13594 * lisp.h (pD): New macro.
13595 * print.c (print_object): Use it.
13596
c0c5c8ae
PE
13597 * alloc.c: Use EMACS_INT, not int, to count objects.
13598 (total_conses, total_markers, total_symbols, total_vector_size)
13599 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
13600 (total_free_floats, total_floats, total_free_intervals)
13601 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
13602 Now EMACS_INT, not int. All uses changed.
13603 (Fgarbage_collect): Compute overall total using a double, so that
13604 integer overflow is less likely to be a problem. Check for overflow
13605 when converting back to an integer.
5a25e253
PE
13606 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
13607 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
13608 These were 'int' variables that could overflow on 64-bit hosts;
13609 they were never used, so remove them instead of repairing them.
211a0b2a 13610 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
13611 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
13612 Previously, this ceilinged at INT_MAX, but that doesn't work on
13613 64-bit machines.
e46bb31a 13614 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 13615
c78baabf 13616 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 13617 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
13618 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
13619 when a (possibly-narrower) signed value would do just as well.
13620 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 13621
c9d624c6
PE
13622 * alloc.c: Catch some string size overflows that we were missing.
13623 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
13624 for convenience in STRING_BYTES_MAX.
13625 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
13626 The definition here is exact; the one in lisp.h was approximate.
13627 (allocate_string_data): Check for string overflow. This catches
13628 some instances we weren't catching before. Also, it catches
13629 size_t overflow on (unusual) hosts where SIZE_MAX <= min
13630 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
13631 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 13632
c9d624c6
PE
13633 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
13634 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 13635 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 13636
353032ce
PE
13637 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
13638
2bccce07
PE
13639 * alloc.c (Fmake_string): Check for out-of-range init.
13640
0ac30604
SM
136412011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
13642
13643 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
13644
c195f2de
JD
136452011-06-14 Jan Djärv <jan.h.d@swipnet.se>
13646
13647 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
13648 xg_get_default_scrollbar_width.
13649
13650 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
13651 (int_gtk_range_get_value): Move to the scroll bar part of the file.
13652 (style_changed_cb): Call update_theme_scrollbar_width and call
13653 x_set_scroll_bar_default_width and xg_frame_set_char_size for
13654 all frames (Bug#8505).
13655 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
13656 Call gtk_window_set_resizable if HAVE_GTK3.
13657 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
13658 and height if HAVE_GTK3 (Bug#8505).
13659 (scroll_bar_width_for_theme): New variable.
13660 (update_theme_scrollbar_width): New function.
13661 (xg_get_default_scrollbar_width): Move code to
13662 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
13663 (xg_initialize): Call update_theme_scrollbar_width.
13664
13665 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
13666
13667 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
13668
e10ac9f1
MR
136692011-06-12 Martin Rudalics <rudalics@gmx.at>
13670
13671 * frame.c (make_frame): Call other_buffer_safely instead of
13672 other_buffer.
13673
13674 * window.c (temp_output_buffer_show): Call display_buffer with
13675 second argument Vtemp_buffer_show_specifiers and reset latter
13676 immediately after the call.
13677 (Vtemp_buffer_show_specifiers): New variable.
13678 (auto_window_vscroll_p, next_screen_context_lines)
13679 (Vscroll_preserve_screen_position): Remove leading asterisks from
13680 doc-strings.
13681
2d3c217e 136822011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 13683
7b7f97e8 13684 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
13685 * buffer.c (Qclone_number): Remove for now, as it's unused.
13686 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
13687 (record_buffer): Remove unused local.
13688 * frame.c (other_visible_frames, frame_buffer_list): Now static.
13689 (set_frame_buffer_list): Remove; unused.
13690 * frame.h (other_visible_frames): Remove decl.
13691 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
13692 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
13693 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
13694 if HAVE_GPM.
13695 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
13696 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
13697 Define only if HAVE_GPM.
13698 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
13699 (update_hints_inhibit): Remove; never set. All uses removed.
13700 * widgetprv.h (emacsFrameClassRec): Remove decl.
13701 * window.c (delete_deletable_window): Now returns void, since it
13702 wasn't returning anything.
13703 (compare_window_configurations): Remove unused locals.
13704 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
13705 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
13706 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
13707 the same widths as pointers. This follows up on the 2011-05-06 patch.
13708 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
13709 * xterm.h: Likewise.
13710 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
13711
1384b89e
JB
137122011-06-12 Juanma Barranquero <lekktu@gmail.com>
13713
13714 * makefile.w32-in: Update dependencies.
13715 (LISP_H): Add lib/intprops.h.
13716
1100a63c
CY
137172011-06-11 Chong Yidong <cyd@stupidchicken.com>
13718
13719 * image.c (gif_load): Add animation frame delay to the metadata.
13720 (syms_of_image): Use DEFSYM. New symbol `delay'.
13721
6198ccd0
MR
137222011-06-11 Martin Rudalics <rudalics@gmx.at>
13723
13724 * window.c (delete_deletable_window): Re-add.
13725 (Fset_window_configuration): Rewrite to handle dead buffers and
13726 consequently deletable windows.
13727 (window_tree, Fwindow_tree): Remove. Supply functionality in
13728 window.el.
13729 (compare_window_configurations): Simplify code.
13730
b6e3633c
AS
137312011-06-11 Andreas Schwab <schwab@linux-m68k.org>
13732
1ab0dee5
AS
13733 * image.c (imagemagick_load_image): Fix type mismatch.
13734 (Fimagemagick_types): Likewise.
13735
b6e3633c
AS
13736 * window.h (replace_buffer_in_windows): Declare.
13737
9397e56f
MR
137382011-06-11 Martin Rudalics <rudalics@gmx.at>
13739
13740 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
13741 Qclone_number. Remove external declaration of Qdelete_window.
13742 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
13743 code.
640c8776
SM
13744 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
13745 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
13746 (Fother_buffer): Rewrite doc-string. Major rewrite for new
13747 buffer list implementation.
13748 (other_buffer_safely): New function.
13749 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
13750 calls to replace_buffer_in_windows and
13751 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
13752 if allowed.
13753 (record_buffer): Inhibit quitting and rewrite using quittable
13754 functions. Run Qbuffer_list_update_hook if allowed.
13755 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
13756 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
13757 Move switch-to-buffer to window.el.
9397e56f
MR
13758 (bury-buffer): Move to window.el.
13759 (Vbuffer_list_update_hook): New variable.
13760
13761 * lisp.h (other_buffer_safely): Add prototype in buffer.c
13762 section.
13763
13764 * window.h (resize_frame_windows): Move up in code.
13765 (Fwindow_frame): Remove EXFUN.
13766 (replace_buffer_in_all_windows): Remove prototype.
13767 (replace_buffer_in_windows_safely): Add prototype.
13768
13769 * window.c: Declare Qdelete_window static again. Move down
13770 declaration of select_count.
13771 (Fnext_window, Fprevious_window): Rewrite doc-strings.
13772 (Fother_window): Move to window.el.
13773 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
13774 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
13775 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
13776 window.el.
13777 (replace_buffer_in_windows): Implement by calling
13778 Qreplace_buffer_in_windows.
13779 (replace_buffer_in_all_windows): Remove with some functionality
13780 moved into replace_buffer_in_windows_safely.
13781 (replace_buffer_in_windows_safely): New function.
13782 (select_window_norecord, select_frame_norecord): Move in front
13783 of run_window_configuration_change_hook. Remove now obsolete
13784 declarations.
640c8776
SM
13785 (Fset_window_buffer): Rewrite doc-string.
13786 Call Qrecord_window_buffer.
9397e56f
MR
13787 (keys_of_window): Move binding for other-window to window.el.
13788
b50691aa
CY
137892011-06-11 Chong Yidong <cyd@stupidchicken.com>
13790
13791 * dispextern.h (struct image): Replace data member, whose int_val
13792 and ptr_val fields were not used by anything, with a single
13793 lisp_val object.
13794
13795 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
13796 (gif_clear_image, gif_load, imagemagick_load_image)
13797 (gs_clear_image, gs_load): Callers changed.
13798
3f754b86
PE
137992011-06-10 Paul Eggert <eggert@cs.ucla.edu>
13800
cca69397
PE
13801 * buffer.h: Include <time.h>, for time_t.
13802 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
13803
109e28d0
PE
13804 Fix minor problems found by static checking.
13805
60737f02
PE
13806 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
13807
4b66faf3
PE
13808 Make identifiers static if they are not used in other modules.
13809 * data.c (Qcompiled_function, Qframe, Qvector):
13810 * image.c (QimageMagick, Qsvg):
13811 * minibuf.c (Qmetadata):
13812 * window.c (resize_window_check, resize_root_window): Now static.
13813 * window.h (resize_window_check, resize_root_window): Remove decls.
13814
109e28d0
PE
13815 * window.c (window_deletion_count, delete_deletable_window):
13816 Remove; unused.
46a4ce9e
PE
13817 (window_body_lines): Now static.
13818 (Fdelete_other_windows_internal): Mark vars as initialized.
13819 Make sure 'resize_failed' is initialized.
13820 (run_window_configuration_change_hook): Rename local to avoid shadowing.
13821 (resize_window_apply): Remove unused local.
13822 * window.h (delete_deletable_window): Remove decl.
13823
109e28d0 13824 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
13825 (imagemagick_load_image): Fix pointer signedness problem by changing
13826 last arg from unsigned char * to char *. All uses changed.
13827 Also, fix a local for similar reasons.
13828 Remove unused locals. Remove locals to avoid shadowing.
13829 (fn_rsvg_handle_free): Remove; unused.
13830 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 13831 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 13832
3f754b86
PE
13833 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
13834
2547adb1
CY
138352011-06-10 Chong Yidong <cyd@stupidchicken.com>
13836
13837 * image.c (gif_load): Fix omitted cast error introduced by
13838 2011-06-06 change.
13839
2c8e37d4
MR
138402011-06-10 Martin Rudalics <rudalics@gmx.at>
13841
13842 * window.h (resize_proportionally, orig_total_lines)
13843 (orig_top_line): Remove from window structure.
13844 (set_window_height, set_window_width, change_window_heights)
13845 (Fdelete_window): Remove prototypes.
13846 (resize_frame_windows): Remove duplicate declaration.
13847
440a42e3
EZ
138482011-06-10 Eli Zaretskii <eliz@gnu.org>
13849
13850 * window.h (resize_frame_windows, resize_window_check)
13851 (delete_deletable_window, resize_root_window)
13852 (resize_frame_windows): Declare prototypes.
13853
13854 * window.c (resize_window_apply): Make definition be "static" to
13855 match the prototype.
13856
562dd5e9
MR
138572011-06-10 Martin Rudalics <rudalics@gmx.at>
13858
13859 * window.c: Remove declarations of Qwindow_size_fixed,
13860 window_min_size_1, window_min_size_2, window_min_size,
13861 size_window, window_fixed_size_p, enlarge_window, delete_window.
13862 Remove static from declaration of Qdelete_window, it's
13863 temporarily needed by Fbury_buffer.
13864 (replace_window): Don't assign orig_top_line and
13865 orig_total_lines.
13866 (Fdelete_window, delete_window): Remove. Window deletion is
13867 handled by window.el.
640c8776
SM
13868 (window_loop): Remove DELETE_OTHER_WINDOWS case.
13869 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
13870 (Fdelete_other_windows): Remove. Deleting other windows is
13871 handled by window.el.
13872 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
13873 handled in window.el.
13874 (window_min_size_2, window_min_size_1, window_min_size): Remove.
13875 Window minimum sizes are handled in window.el.
13876 (shrink_windows, size_window, set_window_height)
13877 (set_window_width, change_window_heights, window_height)
13878 (window_width, CURBEG, CURSIZE, enlarge_window)
13879 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
13880 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
13881 handled in window.el.
13882 (make_dummy_parent): Rename to make_parent_window and give it a
13883 second argument horflag.
13884 (make_window): Don't set resize_proportionally any more.
13885 (Fsplit_window): Remove. Windows are split in window.el.
13886 (save_restore_action, save_restore_orig_size)
13887 (shrink_window_lowest_first, save_restore_orig_size): Remove.
13888 Resize mini windows in window.el.
13889 (grow_mini_window, shrink_mini_window): Implement by calling
13890 Qresize_root_window_vertically, resize_window_check and
13891 resize_window_apply.
640c8776
SM
13892 (saved_window, Fset_window_configuration, save_window_save):
13893 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
13894 resize_proportionally.
13895 (window_min_height, window_min_width): Move to window.el.
13896 (keys_of_window): Move bindings for delete-other-windows,
13897 split-window, delete-window and enlarge-window to window.el.
13898
13899 * buffer.c: Temporarily extern Qdelete_window.
13900 (Fbury_buffer): Temporarily call Qdelete_window instead of
13901 Fdelete_window (Fbury_buffer will move to window.el soon).
13902
13903 * frame.c (set_menu_bar_lines_1): Remove code handling
13904 orig_top_line and orig_total_lines.
13905
13906 * dispnew.c (adjust_frame_glyphs_initially): Don't use
13907 set_window_height but set heights directly.
13908 (change_frame_size_1): Use resize_frame_windows.
13909
13910 * xdisp.c (init_xdisp): Don't use set_window_height but set
13911 heights directly.
13912
640c8776
SM
13913 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
13914 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
13915 run_window_configuration_change_hook.
13916
13917 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
13918 instead of change_window_heights and run
13919 run_window_configuration_change_hook.
13920
1a13852e
MR
139212011-06-09 Martin Rudalics <rudalics@gmx.at>
13922
13923 * window.c (replace_window): Rename second argument REPLACEMENT to
13924 NEW. New third argument SETFLAG. Rewrite.
13925 (delete_window, make_dummy_parent): Call replace_window with
13926 third argument 1.
13927 (window_list_1): Move down in code.
13928 (run_window_configuration_change_hook): Move set_buffer part
13929 before select_frame_norecord part in order to unwind correctly.
13930 Rename count1 to count.
13931 (recombine_windows, delete_deletable_window, resize_root_window)
13932 (Fdelete_other_windows_internal)
13933 (Frun_window_configuration_change_hook, make_parent_window)
13934 (resize_window_check, resize_window_apply, Fresize_window_apply)
13935 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
13936 (Fdelete_window_internal, Fresize_mini_window_internal):
13937 New functions.
1a13852e
MR
13938 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
13939
f3d1777e
MR
139402011-06-08 Martin Rudalics <rudalics@gmx.at>
13941
496e208e
MR
13942 * window.h (window): Add some new members to window structure -
13943 normal_lines, normal_cols, new_total, new_normal, clone_number,
13944 splits, nest, prev_buffers, next_buffers.
13945 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 13946 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 13947
f3d1777e
MR
13948 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
13949 Remove.
496e208e
MR
13950 (make_dummy_parent): Set new members of windows structure.
13951 (make_window): Move down in code. Handle new members of window
13952 structure.
13953 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
13954 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
13955 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
13956 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
13957 (Fset_window_next_buffers, Fset_window_clone_number):
13958 New functions.
496e208e
MR
13959 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
13960 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
13961 Doc-string fixes.
13962 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
13963 Argument WINDOW can be now internal window too.
13964 (Fwindow_use_time): Move up in code.
13965 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
13966 Rewrite doc-string.
13967 (Fset_window_configuration, saved_window)
13968 (Fcurrent_window_configuration, save_window_save): Handle new
13969 members of window structure.
b9e809c2
MR
13970 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
13971 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
13972 (syms_of_window): New Lisp objects Qrecord_window_buffer,
13973 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
13974 Qget_mru_window, Qresize_root_window,
13975 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
13976 Qauto_buffer_name; staticpro them.
f3d1777e 13977
abde8f8c
MR
139782011-06-07 Martin Rudalics <rudalics@gmx.at>
13979
13980 * window.c (Fwindow_total_size, Fwindow_left_column)
13981 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
13982 (Fwindow_list_1): New functions.
13983 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
13984 (Fwindow_width, Fscroll_left, Fscroll_right):
13985 Use window_body_cols instead of window_box_text_cols.
13986 (delete_window, Fset_window_configuration):
13987 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
13988 (delete_all_subwindows): Take a window as argument and not a
13989 structure. Rewrite.
190b47e6
MR
13990 (window_loop): Remove handling of GET_LRU_WINDOW and
13991 GET_LARGEST_WINDOW.
13992 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
13993
13994 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
13995 window_box_text_cols. delete_all_subwindows now takes a
13996 Lisp_Object as argument.
abde8f8c 13997
640c8776
SM
13998 * indent.c (compute_motion, Fcompute_motion):
13999 Use window_body_cols instead of window_box_text_cols.
abde8f8c 14000
fa8a67e6
MR
14001 * frame.c (delete_frame): Call delete_all_subwindows with root
14002 window as argument.
14003
a54e3482
DC
140042011-06-07 Daniel Colascione <dan.colascione@gmail.com>
14005
14006 * fns.c (Fputhash): Document return value.
14007
60002bf5
CY
140082011-06-06 Chong Yidong <cyd@stupidchicken.com>
14009
14010 * image.c (gif_load): Implement gif89a spec "no disposal" method.
14011
0c671da6 140122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 14013
b862a52a 14014 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 14015
be44ca6c
PE
14016 Check for overflow when converting integer to cons and back.
14017 * charset.c (Fdefine_charset_internal, Fdecode_char):
14018 Use cons_to_unsigned to catch overflow.
14019 (Fencode_char): Use INTEGER_TO_CONS.
14020 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
14021 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
14022 * data.c (long_to_cons, cons_to_long): Remove.
14023 (cons_to_unsigned, cons_to_signed): New functions.
14024 These signal an error for invalid or out-of-range values.
14025 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
14026 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
14027 * font.c (Ffont_variation_glyphs):
14028 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
14029 * lisp.h: Include <intprops.h>.
14030 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
14031 (cons_to_signed, cons_to_unsigned): New decls.
14032 (long_to_cons, cons_to_long): Remove decls.
14033 * undo.c (record_first_change): Use INTEGER_TO_CONS.
14034 (Fprimitive_undo): Use CONS_TO_INTEGER.
14035 * xfns.c (Fx_window_property): Likewise.
14036 * xselect.c: Include <limits.h>.
14037 (x_own_selection, selection_data_to_lisp_data):
14038 Use INTEGER_TO_CONS.
14039 (x_handle_selection_request, x_handle_selection_clear)
14040 (x_get_foreign_selection, Fx_disown_selection_internal)
14041 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
14042 (lisp_data_to_selection_data): Use cons_to_unsigned.
14043 (x_fill_property_data): Use cons_to_signed.
14044 Report values out of range.
14045
d1f3d2af
PE
14046 Check for buffer and string overflow more precisely.
14047 * buffer.h (BUF_BYTES_MAX): New macro.
14048 * lisp.h (STRING_BYTES_MAX): New macro.
14049 * alloc.c (Fmake_string):
14050 * character.c (string_escape_byte8):
14051 * coding.c (coding_alloc_by_realloc):
14052 * doprnt.c (doprnt):
14053 * editfns.c (Fformat):
14054 * eval.c (verror):
14055 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
14056 since they may not be the same number.
14057 * editfns.c (Finsert_char):
14058 * fileio.c (Finsert_file_contents):
14059 Likewise for BUF_BYTES_MAX.
14060
dd52fcea
PE
14061 * image.c: Use ptrdiff_t, not int, for sizes.
14062 (slurp_file): Switch from int to ptrdiff_t.
14063 All uses changed.
14064 (slurp_file): Check that file size fits in both size_t (for
14065 malloc) and ptrdiff_t (for sanity and safety).
14066
7f9bbdbb
PE
14067 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
14068 if b->modtime has its maximal value.
14069
dfe18f82
PE
14070 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
14071
84acfcf0
PE
14072 Don't assume time_t can fit into int.
14073 * buffer.h (struct buffer.modtime): Now time_t, not int.
14074 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
14075 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
14076
ccd9a01a
PE
14077 Minor fixes for signed vs unsigned integers.
14078 * character.h (MAYBE_UNIFY_CHAR):
14079 * charset.c (maybe_unify_char):
14080 * keyboard.c (read_char, reorder_modifiers):
14081 XINT -> XFASTINT, since the integer must be nonnegative.
14082 * ftfont.c (ftfont_spec_pattern):
14083 * keymap.c (access_keymap, silly_event_symbol_error):
14084 XUINT -> XFASTINT, since the integer must be nonnegative.
14085 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
14086 since it makes no difference and we prefer signed.
14087 * keyboard.c (record_char): Use XUINT when all the neighbors do.
14088 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
14089 nonnegative.
14090
d6d100dd
SM
140912011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
14092
14093 * window.h (Fwindow_frame): Declare.
14094
2b6148e4
PE
140952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
14096
14097 * alloc.c: Simplify handling of large-request failures (Bug#8800).
14098 (SPARE_MEMORY): Always define.
14099 (LARGE_REQUEST): Remove.
14100 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
14101
f230ecc9
MR
141022011-06-06 Martin Rudalics <rudalics@gmx.at>
14103
727e958e
MR
14104 * lisp.h: Move EXFUNS for Fframe_root_window,
14105 Fframe_first_window and Fset_frame_selected_window to window.h.
14106
14107 * window.h: Move EXFUNS for Fframe_root_window,
14108 Fframe_first_window and Fset_frame_selected_window here from
14109 lisp.h.
14110
14111 * frame.c (Fwindow_frame, Fframe_first_window)
14112 (Fframe_root_window, Fframe_selected_window)
14113 (Fset_frame_selected_window): Move to window.c.
14114 (Factive_minibuffer_window): Move to minibuf.c.
14115 (Fother_visible_frames_p): New function.
14116
14117 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
14118
f230ecc9
MR
14119 * window.c (decode_window, decode_any_window): Move up in code.
14120 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
14121 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
14122 (Fwindow_buffer): Move up and rewrite doc-string.
14123 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
14124 (Fwindow_prev): New functions.
727e958e
MR
14125 (Fwindow_frame): Move here from frame.c. Accept any window as
14126 argument.
14127 (Fframe_root_window, Fframe_first_window)
14128 (Fframe_selected_window): Move here from frame.c. Accept frame
14129 or arbitrary window as argument. Update doc-strings.
14130 (Fminibuffer_window): Move up in code.
14131 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
14132 (Fset_frame_selected_window): Move here from frame.c.
14133 Marginal rewrite.
727e958e
MR
14134 (Fselected_window, select_window, Fselect_window): Move up in
14135 code. Minor doc-string fixes.
f230ecc9 14136
4d09bcf6
PE
141372011-06-06 Paul Eggert <eggert@cs.ucla.edu>
14138
14139 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
14140 Do not assume that spare memory exists; that assumption is valid
14141 only if SYSTEM_MALLOC.
14142 (LARGE_REQUEST): New macro, so that the issue of large requests
14143 is separated from the issue of spare memory.
14144
810928a2
AS
141452011-06-05 Andreas Schwab <schwab@linux-m68k.org>
14146
172418ad
AS
14147 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
14148 format. (Bug#8806)
14149
43f862f7
AS
14150 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
14151
810928a2
AS
14152 * xfns.c (x_set_scroll_bar_default_width): Move declarations
14153 before statements.
14154
a059fe24
JD
141552011-06-05 Jan Djärv <jan.h.d@swipnet.se>
14156
14157 * gtkutil.c (xg_get_default_scrollbar_width): New function.
14158
14159 * gtkutil.h: Declare xg_get_default_scrollbar_width.
14160
14161 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
14162 min width by calling x_set_scroll_bar_default_width (Bug#8505).
14163
989bf368
JB
141642011-06-05 Juanma Barranquero <lekktu@gmail.com>
14165
14166 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
14167
4b80f674
CY
141682011-06-04 Chong Yidong <cyd@stupidchicken.com>
14169
14170 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
14171 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
14172 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
14173 New error handlers.
4b80f674
CY
14174 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
14175 Obey Vx_select_enable_clipboard_manager. Catch errors in
14176 x_clipboard_manager_save (Bug#8779).
14177 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 14178 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 14179
99a33b77 141802011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
14181
14182 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
14183
99a33b77 141842011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
14185
14186 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
14187 in the current matrix if keep_current_p is non-zero.
14188
8264569d
EZ
141892011-06-04 Eli Zaretskii <eliz@gnu.org>
14190
14191 * bidi.c (bidi_level_of_next_char): Fix last change.
14192
57f97249
EZ
141932011-06-03 Eli Zaretskii <eliz@gnu.org>
14194
fec2107c 14195 Support bidi reordering of text covered by display properties.
57f97249 14196
fec2107c
EZ
14197 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
14198 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
14199 (bidi_cache_search, bidi_cache_iterator_state)
14200 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
14201 (bidi_level_of_next_char, bidi_move_to_visually_next):
14202 Support character positions inside a run of characters covered by a
fec2107c
EZ
14203 display string.
14204 (bidi_paragraph_init, bidi_resolve_explicit_1)
14205 (bidi_level_of_next_char): Call bidi_fetch_char and
14206 bidi_fetch_char_advance instead of FETCH_CHAR and
14207 FETCH_CHAR_ADVANCE.
14208 (bidi_init_it): Initialize new members.
14209 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
14210 definitions.
14211 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
14212 instead of using explicit *_CHAR codes.
d6d100dd
SM
14213 (bidi_resolve_explicit, bidi_resolve_weak):
14214 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
14215 bidirectional text is supported only in multibyte buffers.
14216 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
14217 it to initialize the frame_window_p member of struct bidi_it.
14218 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
14219 (bidi_resolve_explicit, bidi_resolve_weak)
14220 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
14221 bidi_it->nchars is non-positive.
14222 (bidi_level_of_next_char): Don't try to lookup the cache for the
14223 next/previous character if nothing is cached there yet, or if we
14224 were just reseat()'ed to a new position.
c40e2fb2 14225
0e14fe90
EZ
14226 * xdisp.c (set_cursor_from_row): Set start and stop points
14227 according to the row's direction when priming the loop that looks
14228 for the glyph on which to display cursor.
14229 (single_display_spec_intangible_p): Function deleted.
14230 (display_prop_intangible_p): Reimplement to call
14231 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
14232 Accept 3 additional arguments needed by handle_display_spec.
14233 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
14234 values: lists, `(when COND...)' forms, etc.
14235 (single_display_spec_string_p): Support property values that are
14236 lists with the argument STRING its top-level element.
14237 (display_prop_string_p): Fix the condition for processing a
14238 property that is a list to be consistent with handle_display_spec.
fec2107c 14239 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
14240 last portion of handle_display_prop.
14241 (compute_display_string_pos): Accept additional argument
14242 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
14243 value of a `display' property is a "replacing spec".
14244 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
14245 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
14246 the display property, but just return a value indicating whether
14247 the display property will replace the characters it covers.
14248 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
14249 frame_window_p members of struct bidi_it.
d6d100dd
SM
14250 (compute_display_string_pos, compute_display_string_end):
14251 New functions.
fec2107c
EZ
14252 (push_it): Accept second argument POSITION, where pop_it should
14253 jump to continue iteration.
14254 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 14255
fec2107c
EZ
14256 * keyboard.c (adjust_point_for_property): Adjust the call to
14257 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
14258
14259 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
14260 (bidi_init_it): Update prototypes.
14261 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
14262 (compute_display_string_pos, compute_display_string_end):
14263 Declare prototypes.
fec2107c
EZ
14264 (struct bidi_it): New members nchars and disp_pos. ch_len is now
14265 EMACS_INT.
fc6f18ce 14266
40087514 142672011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 14268
57f53182
PE
14269 Malloc failure behavior now depends on size of allocation.
14270 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
14271 * lisp.h: Change signatures accordingly.
14272 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
14273 All callers changed. (Bug#8762)
14274
14275 * gnutls.c: Use Emacs's memory allocators.
14276 Without this change, the gnutls library would invoke malloc etc.
14277 directly, which causes problems on non-SYNC_INPUT hosts, and which
14278 runs afoul of improving memory_full behavior. (Bug#8761)
14279 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
14280 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
14281 xfree instead of the default malloc, realloc, free.
14282 (Fgnutls_boot): No need to check for memory allocation failure,
14283 since xmalloc does that for us.
14284
ac32cd99 14285 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
14286 * category.c (hash_get_category_set):
14287 * ccl.c (ccl_driver):
14288 * charset.c (Fdefine_charset_internal):
14289 * charset.h (struct charset.hash_index):
14290 * composite.c (get_composition_id, gstring_lookup_cache)
14291 (composition_gstring_put_cache):
14292 * composite.h (struct composition.hash_index):
14293 * dispextern.h (struct image.hash):
14294 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
14295 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
14296 (hashfn_equal, hashfn_user_defined, make_hash_table)
14297 (maybe_resize_hash_table, hash_lookup, hash_put)
14298 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
14299 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
14300 (Fsxhash, Fgethash, Fputhash, Fmaphash):
14301 * image.c (make_image, search_image_cache, lookup_image)
14302 (xpm_put_color_table_h):
14303 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 14304 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 14305 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 14306 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
14307 * alloc.c (allocate_vectorlike):
14308 Check for overflow in vector size calculations.
14309 * ccl.c (ccl_driver):
14310 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
14311 * fns.c, image.c: Remove unnecessary static decls that would otherwise
14312 need to be updated by these changes.
40087514
PE
14313 * fns.c (make_hash_table, maybe_resize_hash_table):
14314 Check for integer overflow with large hash tables.
0de4bb68
PE
14315 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
14316 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
14317 (SXHASH_REDUCE): New macro.
14318 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
14319 Use it instead of discarding useful hash info with large hash values.
14320 (sxhash_float): New function.
14321 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
14322 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
14323 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
14324 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
14325 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
14326 Adjust signatures to match updated version of code.
14327 (consing_since_gc): Now EMACS_INT, since a single hash table can
14328 use more than INT_MAX bytes.
14329
698d32e2
DN
143302011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
14331
14332 Make it possible to build with GCC-4.6+ -O2 -flto.
14333
14334 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
14335
fd6fa53f
SM
143362011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
14337
14338 * minibuf.c (get_minibuffer, read_minibuf_unwind):
14339 Call minibuffer-inactive-mode.
14340
864db017
JB
143412011-05-31 Juanma Barranquero <lekktu@gmail.com>
14342
14343 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
14344 Update dependencies.
14345
2ad0baf4
DN
143462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14347
14348 * data.c (init_data): Remove code for UTS, this system is not
14349 supported anymore.
14350
4fcc2638
DN
143512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14352
14353 Don't force ./temacs to start in terminal mode.
14354
14355 * frame.c (make_initial_frame): Initialize faces in all cases, not
14356 only when CANNOT_DUMP is defined.
14357 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
14358
c56e0fd5
DN
143592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14360
14361 * dispnew.c (add_window_display_history): Use const for the string
14362 pointer. Remove declaration, not needed.
14363
333d54da 143642011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 14365
55d4c1b2 14366 Use 'inline', not 'INLINE'.
333d54da 14367 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
14368 * alloc.c, fontset.c (INLINE): Remove.
14369 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
14370 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
14371 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
14372 * gmalloc.c (register_heapinfo): Use inline unconditionally.
14373 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
14374
738db178
DN
143752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14376
14377 Make it possible to run ./temacs.
14378
14379 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
14380 syms_of_callproc does the same thing. Remove test for
14381 "initialized", do it in the caller.
14382 * emacs.c (main): Avoid calling set_initial_environment when dumping.
14383
620c53a6
SM
143842011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
14385
14386 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
14387 (read_minibuf): Use get_minibuffer.
14388 (syms_of_minibuf): Use DEFSYM.
14389 (Qmetadata): New var.
14390 * data.c (Qbuffer): Don't make it static.
14391 (syms_of_data): Use DEFSYM.
14392
e003a292
PE
143932011-05-31 Paul Eggert <eggert@cs.ucla.edu>
14394
14395 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
14396 (CCL_CODE_MIN): New macro.
14397
ed008a6d
PE
143982011-05-30 Paul Eggert <eggert@cs.ucla.edu>
14399
3687c2ef
PE
14400 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
14401
ed008a6d
PE
14402 * eval.c (Qdebug): Now static.
14403 * lisp.h (Qdebug): Remove decl. This reverts a part of the
14404 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
14405 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
14406
d66c4c7c
CY
144072011-05-29 Chong Yidong <cyd@stupidchicken.com>
14408
14409 * image.c: Various fixes to ImageMagick code comments.
14410 (Fimagemagick_types): Doc fix.
14411
5fbc2025
PE
144122011-05-29 Paul Eggert <eggert@cs.ucla.edu>
14413
0196f88a
PE
14414 Minor fixes prompted by GCC 4.6.0 warnings.
14415
14416 * xselect.c (converted_selections, conversion_fail_tag): Now static.
14417
5fbc2025
PE
14418 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
14419 (x_clipboard_manager_save_all): Move extern decl to ...
14420 * xterm.h: ... here, so that it can be checked for consistency.
14421
1dd3c2d9
CY
144222011-05-29 Chong Yidong <cyd@stupidchicken.com>
14423
14424 * xselect.c (x_clipboard_manager_save_frame)
14425 (x_clipboard_manager_save_all): New functions.
14426 (Fx_clipboard_manager_save): Lisp function deleted.
14427
14428 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
14429 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
14430
14431 * xterm.h: Update prototype.
14432
5ba6571d
WX
144332011-05-28 William Xu <william.xwl@gmail.com>
14434
14435 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
14436 exiting (Bug#8239).
14437
3eaff834
JM
144382011-05-28 Jim Meyering <meyering@redhat.com>
14439
e1900994 14440 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
14441 * fns.c (to_uchar): Define.
14442 (crypto_hash_function): Use it to convert some newly-signed
14443 variables to unsigned, to avoid sign-extension bugs. For example,
14444 without this change, (md5 "truc") would evaluate to
14445 45723a2aff78ff4fff7fff1114760e62 rather than the expected
14446 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 14447 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 14448
0f6990a7
PE
144492011-05-27 Paul Eggert <eggert@cs.ucla.edu>
14450
14451 Integer overflow fixes.
c8a9ca5a 14452
08686060
PE
14453 * dbusbind.c: Serial number integer overflow fixes.
14454 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
14455 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
14456 to hold a serial number that is too large for a fixnum.
14457 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14458 Check for serial numbers out of range. Decode any serial number
59568bf0 14459 that was so large that it became a float. (Bug#8722)
08686060 14460
2d1fc3c7
PE
14461 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
14462 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14463 Use XFASTINT rather than XUINT when numbers are nonnegative.
14464 (xd_append_arg, Fdbus_method_return_internal):
14465 (Fdbus_method_error_internal): Likewise. Also, for unsigned
14466 arguments, check that Lisp number is nonnegative, rather than
59568bf0 14467 silently wrapping negative numbers around. (Bug#8722)
30217ff0 14468 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 14469 (Bug#8722)
2d1fc3c7 14470
c8a9ca5a
PE
14471 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
14472
519e1d69
PE
14473 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
14474
6df6ae42 14475 ccl: Add integer overflow checks.
30569699
PE
14476 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
14477 (IN_INT_RANGE): New macros.
14478 (ccl_driver): Use them to check for integer overflow when
14479 decoding a CCL program. Many of the new checks are whether XINT (x)
14480 fits in int; it doesn't always, on 64-bit hosts. The new version
14481 doesn't catch all possible integer overflows, but it's an
847044ea 14482 improvement. (Bug#8719)
30569699 14483
c11285dc
PE
14484 * alloc.c (make_event_array): Use XINT, not XUINT.
14485 There's no need for unsigned here.
14486
fdccd48e
PE
14487 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
14488 This follows up to the 2011-05-06 change that substituted uintptr_t
14489 for EMACS_INT. This case wasn't caught back then.
14490
37910ab2
PE
14491 Rework Fformat to avoid integer overflow issues.
14492 * editfns.c: Include <float.h> unconditionally, as it's everywhere
14493 now (part of C89). Include <verify.h>.
14494 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
14495 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
14496 (Fformat): Avoid the prepass trying to compute sizes; it was only
14497 approximate and thus did not catch overflow reliably. Instead, walk
14498 through the format just once, formatting and computing sizes as we go,
14499 checking for integer overflow at every step, and allocating a larger
14500 buffer as needed. Keep track separately whether the format is
14501 multibyte. Keep only the most-recently calculated precision, rather
14502 than them all. Record whether each argument has been converted to
14503 string. Use EMACS_INT, not int, for byte and char and arg counts.
14504 Support field widths and precisions larger than INT_MAX. Avoid
14505 sprintf's undefined behavior with conversion specifications such as %#d
14506 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
14507 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
14508 formatting out-of-range floating point numbers with int
9173deec 14509 formats. (Bug#8668)
37910ab2 14510
2e6578fb
PE
14511 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
14512
0ae6bdee
PE
14513 * data.c: Avoid integer truncation in expressions involving floats.
14514 * data.c: Include <intprops.h>.
14515 (arith_driver): When there's an integer overflow in an expression
14516 involving floating point, convert the integers to floating point
14517 so that the resulting value does not suffer from catastrophic
14518 integer truncation. For example, on a 64-bit host (* 4
14519 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
14520 Do not rely on undefined behavior after integer overflow.
14521
de883a70
PE
14522 merge count_size_as_multibyte, parse_str_to_multibyte
14523 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 14524 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
14525 Check for integer overflow.
14526 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
14527 since it's now a duplicate of the other. This is more of
14528 a character than a buffer op, so better that it's in character.c.
14529 * fns.c, print.c: Adjust to above changes.
14530
2ff916cb
PE
145312011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
14532
14533 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
14534
f1b54466
PE
145352011-05-27 Paul Eggert <eggert@cs.ucla.edu>
14536
fb1ac845
PE
14537 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
14538 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
14539 (x_clipboard_manager_save): Now static.
14540 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
14541
f1b54466
PE
14542 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
14543 (crypto_hash_function): Now static.
14544 Fix pointer signedness problems. Avoid unnecessary initializations.
14545
a9f737ee
CY
145462011-05-27 Chong Yidong <cyd@stupidchicken.com>
14547
14548 * termhooks.h (Vselection_alist): Make it terminal-local.
14549
14550 * terminal.c (create_terminal): Initialize it.
14551
14552 * xselect.c: Support for clipboard managers.
14553 (Vselection_alist): Move to termhooks.h as terminal-local var.
14554 (LOCAL_SELECTION): New macro.
14555 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
14556 (symbol_to_x_atom): Remove gratuitous arg.
14557 (x_handle_selection_request, lisp_data_to_selection_data)
14558 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
14559 (x_own_selection, x_get_local_selection, x_convert_selection):
14560 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
14561 (some_frame_on_display): Delete unused function.
14562 (Fx_own_selection_internal, Fx_get_selection_internal)
14563 (Fx_disown_selection_internal, Fx_selection_owner_p)
14564 (Fx_selection_exists_p): New optional frame arg.
14565 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
14566 (x_handle_selection_clear): Don't treat other terminals with the
14567 same keyboard specially. Use the terminal-local Vselection_alist.
14568 (x_clear_frame_selections): Use Frun_hook_with_args.
14569
14570 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
14571
14572 * xterm.h: Add support for those atoms.
14573
e067f0c1
CY
145742011-05-26 Chong Yidong <cyd@stupidchicken.com>
14575
14576 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
14577 (converted_selections, conversion_fail_tag): New global variables.
14578 (x_selection_request_lisp_error): Free the above.
14579 (x_get_local_selection): Remove unnecessary code.
14580 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
14581 of converted selections stored in converted_selections.
14582 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
14583 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
14584 (x_convert_selection): New function.
14585 (x_handle_selection_event): Simplify.
14586 (x_get_foreign_selection): Don't ignore incoming requests while
14587 waiting for an answer; this will fail when we implement
14588 SAVE_TARGETS, and seems unnecessary anyway.
14589 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
14590 (Vx_sent_selection_functions): Doc fix.
14591
0f4aebc0
LL
145922011-05-26 Leo Liu <sdl.web@gmail.com>
14593
14594 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
14595
e61124cd
YM
145962011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14597
14598 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
14599
14600 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
14601 for fringe update if it has periodic bitmap.
ac389d0c 14602 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
14603 and fringe_bitmap_periodic_p.
14604
14605 * fringe.c (get_fringe_bitmap_data): New function.
14606 (draw_fringe_bitmap_1, update_window_fringes): Use it.
14607 (update_window_fringes): Record periodicity of fringe bitmap in glyph
14608 row. Mark glyph row for fringe update if periodicity changed.
14609
14610 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
14611 for fringe update unless it has periodic bitmap.
14612
f16d9837
KH
146132011-05-25 Kenichi Handa <handa@m17n.org>
14614
14615 * xdisp.c (get_next_display_element): Set correct it->face_id for
14616 a static composition.
14617
e1b90ef6
LL
146182011-05-24 Leo Liu <sdl.web@gmail.com>
14619
14620 * deps.mk (fns.o):
14621 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
14622
14623 * fns.c (crypto_hash_function, Fsha1): New function.
14624 (Fmd5): Use crypto_hash_function.
14625 (syms_of_fns): Add Ssha1.
14626
7400048f
PE
146272011-05-22 Paul Eggert <eggert@cs.ucla.edu>
14628
14629 * gnutls.c: Remove unused macros.
14630 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
14631 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
14632 Remove macros that are defined and never used.
14633 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
14634
abb71cf4
CY
146352011-05-22 Chong Yidong <cyd@stupidchicken.com>
14636
14637 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
14638 (Fx_get_selection_internal): Minor cleanup.
14639 (Fx_own_selection_internal): Rename arguments for consistency with
14640 select.el.
14641
6307db39
PE
146422011-05-22 Paul Eggert <eggert@cs.ucla.edu>
14643
14644 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
14645
f3d4e0a4
CY
146462011-05-22 Chong Yidong <cyd@stupidchicken.com>
14647
14648 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
14649
4d8ade89
YM
146502011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14651
14652 * dispnew.c (scrolling_window): Don't exclude the case that the
14653 last enabled row in the desired matrix touches the bottom boundary.
14654
32078c8d
GM
146552011-05-21 Glenn Morris <rgm@gnu.org>
14656
14657 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
14658 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
14659 and add some more files.
32078c8d 14660
7285dc67
EZ
146612011-05-20 Eli Zaretskii <eliz@gnu.org>
14662
14663 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
14664 report_file_error introduced by the change from 2011-05-07.
14665
89d1bd22
PE
146662011-05-20 Paul Eggert <eggert@cs.ucla.edu>
14667
14668 * systime.h (Time): Define only if emacs is defined.
14669 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
14670 where the include path doesn't have X11/X.h by default. See
14671 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
14672
cd394be1 146732011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
14674
14675 * composite.c (find_automatic_composition): Fix previous change.
14676
b9704ad9
GM
146772011-05-20 Glenn Morris <rgm@gnu.org>
14678
14679 * lisp.mk: New file, split from Makefile.in.
14680 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
14681 (shortlisp): Remove.
14682 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
14683
4a720484
GM
146842011-05-19 Glenn Morris <rgm@gnu.org>
14685
14686 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
14687 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
14688 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
14689 (lisp): Set the order to that of loadup.el.
14690 (shortlisp): Make it a copy of $lisp.
14691 (SOME_MACHINE_LISP): Remove.
14692 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
14693 Use just $shortlisp, not $SOME_MACHINE_LISP too.
14694
a28d4396
KH
146952011-05-18 Kenichi Handa <handa@m17n.org>
14696
14697 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
14698 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
14699 (find_automatic_composition): Mostly rewrite for efficiency.
14700
a2b1fa8e
JB
147012011-05-18 Juanma Barranquero <lekktu@gmail.com>
14702
14703 * makefile.w32-in: Update dependencies.
14704
8e1f5610
CS
147052011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
14706
14707 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 14708 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 14709
7025ee00 147102011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 14711
cdfa6eab
PE
14712 Fix some integer overflow issues, such as string length overflow.
14713
06d6db33
PE
14714 * insdel.c (count_size_as_multibyte): Check for string overflow.
14715
2b4560a8
PE
14716 * character.c (lisp_string_width): Check for string overflow.
14717 Use EMACS_INT, not int, for string indexes and lengths; in
14718 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
14719 the resulting string length overflows an EMACS_INT; instead,
14720 report a string overflow if no precision given. When checking for
14721 precision exhaustion, use a check that cannot possibly have
14722 integer overflow. (Bug#8675)
14723 * character.h (lisp_string_width): Adjust to new signature.
14724
cb93f9be
PE
14725 * alloc.c (string_overflow): New function.
14726 (Fmake_string): Use it. This doesn't change behavior, but saves
14727 a few bytes and will simplify future changes.
14728 * character.c (string_escape_byte8): Likewise.
14729 * lisp.h (string_overflow): New decl.
14730
1a1f3366
PE
14731 Fixups, following up to the user-interface timestamp change.
14732 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
14733 for UI timestamps, instead of unsigned long.
9fbd6841
PE
14734 * msdos.c (mouse_get_pos): Likewise.
14735 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
14736 * w32gui.h (Time): Define by including "systime.h" rather than by
14737 declaring it ourselves. (Bug#8664)
14738
d4e3e4d3
PE
14739 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
14740 * image.c (clear_image_cache): Likewise.
14741
f6a24d19
PE
14742 * term.c (term_mouse_position): Don't assume time_t wraparound.
14743
08dc5ae6
PE
14744 Be more systematic about user-interface timestamps.
14745 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
14746 and sometimes 'EMACS_UINT', to represent these timestamps.
14747 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
14748 This makes the code easier to follow, and makes it easier to catch
14749 integer overflow bugs such as Bug#8664.
14750 * frame.c (Fmouse_position, Fmouse_pixel_position):
14751 Use Time, not unsigned long, for user-interface timestamps.
14752 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
14753 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
14754 * keyboard.h (last_event_timestamp): Likewise.
14755 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
14756 * menu.h (xmenu_show): Likewise.
14757 * term.c (term_mouse_position): Likewise.
14758 * termhooks.h (struct input_event.timestamp): Likewise.
14759 (struct terminal.mouse_position_hook): Likewise.
14760 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
14761 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
14762 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
14763 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
14764 what it was before.
14765 * menu.h, termhooks.h: Include "systime.h", for Time.
14766
8e55734a
PE
14767 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
14768 Don't assume that the difference between two unsigned long values
14769 can fit into an integer. At this point, we know button_down_time
14770 <= event->timestamp, so the difference must be nonnegative, so
14771 there's no need to cast the result if double-click-time is
14772 nonnegative, as it should be; check that it's nonnegative, just in
14773 case. This bug is triggered when events are more than 2**31 ms
86db42d2 14774 apart (about 25 days). (Bug#8664)
8e55734a 14775
841f1b75 14776 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 14777 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 14778
3e26f69c
PE
14779 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
14780 that always fit in int. Use a sentinel instead of a counter, to
14781 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
14782 * frame.h (struct frame): Use int for menu_bar_items_used
14783 instead of EMACS_INT, since it always fits in int.
3e26f69c 14784
5cc152c0
PE
14785 * menu.c (grow_menu_items): Check for int overflow.
14786
d89eb65e
PE
14787 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
14788
5235bd3e
PE
14789 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
14790 Before, the code was not consistent. These values cannot exceed
14791 2**31 - 1 so there's no need to make them unsigned.
14792 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
14793 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
14794 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
14795 as modifiers.
14796 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
14797
bc827e23
PE
14798 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
14799 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
14800 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
14801 presumably because the widths might not match.
14802
78eb494e
PE
14803 * window.c (size_window): Avoid needless test at loop start.
14804
04f2d78b
CB
148052011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
14806
14807 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
14808
d2fc7e3d 148092011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
14810
14811 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
14812
d2fc7e3d 148132011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
14814
14815 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
14816 `width' to `bar_area_x' and `bar_area_width', respectively.
14817 (x_scroll_run): Take account of fringe background extension.
14818
04f2d78b
CB
14819 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
14820 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
14821 `bar_area_width', respectively.
14822 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
14823 background extension.
14824
79b70037
GM
148252011-05-10 Jim Meyering <meyering@redhat.com>
14826
14827 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
14828
2f142cc5
JB
148292011-05-10 Juanma Barranquero <lekktu@gmail.com>
14830
14831 * image.c (Finit_image_library): Return t for built-in image types,
14832 like pbm and xbm. (Bug#8640)
14833
57679c86
AS
148342011-05-09 Andreas Schwab <schwab@linux-m68k.org>
14835
14836 * w32menu.c (set_frame_menubar): Fix submenu allocation.
14837
888c9e86
EZ
148382011-05-07 Eli Zaretskii <eliz@gnu.org>
14839
b0512a1d
EZ
14840 * w32console.c (Fset_screen_color): Doc fix.
14841 (Fget_screen_color): New function.
14842 (syms_of_ntterm): Defsubr it.
14843
7285dc67
EZ
14844 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
14845 unlink the temporary file if Fcall_process didn't create it in the
14846 first place.
14847 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
14848 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
14849 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
14850 cue to call_process_cleanup not to close that handle.
14851
4d3fcc8e
BK
148522011-05-07 Ben Key <bkey76@gmail.com>
14853
14854 * makefile.w32-in: The bootstrap-temacs rule now makes use of
14855 one of two shell specific rules, either bootstrap-temacs-CMD or
14856 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
14857 to the previous implementation of the bootstrap-temacs rule.
14858 The bootstrap-temacs-CMD rule is similar to the previous
14859 implementation of the bootstrap-temacs rule except that it
14860 makes use of the ESC_CFLAGS variable instead of the CFLAGS
14861 variable.
14862
14863 These changes, along with some changes to nt/configure.bat,
14864 nt/gmake.defs, and nt/nmake.defs, are required to extend my
14865 earlier fix to add support for --cflags and --ldflags options
14866 that include quotes so that it works whether make uses cmd or
14867 sh as the shell.
14868
b4289b64
MA
148692011-05-06 Michael Albinus <michael.albinus@gmx.de>
14870
14871 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
14872 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
14873 is a constant.
14874 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
14875 a string. Handle both cases.
14876 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
14877 (Fdbus_register_method): Use Qinvalid_function.
14878
af4c0e28
JB
148792011-05-06 Juanma Barranquero <lekktu@gmail.com>
14880
14881 * makefile.w32-in: Update dependencies.
14882 (LISP_H): Add inttypes.h and stdin.h.
14883 (PROCESS_H): Add unistd.h.
14884
c51453d9
EZ
148852011-05-06 Eli Zaretskii <eliz@gnu.org>
14886
14887 * lread.c: Include limits.h (fixes the MS-Windows build broken by
14888 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
14889
8ff0ac3c 148902011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 14891
4c4b566b
PE
14892 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
14893
aab2b9b5
PE
14894 * term.c (vfatal): Remove stray call to va_end.
14895 It's not needed and the C Standard doesn't allow it here anyway.
14896
c378da0b
PE
14897 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
14898 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
14899
288b08c7
PE
14900 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
14901 bytes.
14902
e3601888
PE
14903 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
14904
db6c0e74
PE
14905 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
14906
dd5963ea
PE
14907 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
14908
88c9450f
PE
14909 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
14910
2f9442b8
PE
14911 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
14912
c032b5f8
PE
14913 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
14914 * charset.c (Fdefine_charset_internal): Don't initialize
14915 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 14916 32-bit int (Bug#8600).
a108c10b
PE
14917
14918 * lread.c (read_integer): Be more consistent with string-to-number.
14919 Use string_to_number to do the actual conversion; this avoids
14920 rounding errors and fixes some other screwups. Without this fix,
14921 for example, #x1fffffffffffffff was misread as -2305843009213693952.
14922 (digit_to_number): Move earlier, for benefit of read_integer.
14923 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 14924 not a digit in any supported base. (Bug#8602)
a108c10b 14925
ad5f9eea
PE
14926 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
14927
aec1708a
PE
14928 * dispnew.c (scrolling_window): Return 1 if we scrolled,
14929 to match comment at start of function. This also removes a
14930 GCC warning about overflow in a 32+64-bit port.
14931
47be4ab5
PE
14932 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
14933
371cac43
PE
14934 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
14935 Reported by Stefan Monnier in
14936 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
14937 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14938 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 14939
d01a7826
PE
14940 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
14941 (EMACS_UINTPTR): Likewise, with uintptr_t.
14942
7fd47d5c
PE
14943 * lisp.h: Prefer 64-bit EMACS_INT if available.
14944 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
14945 on 32-bit hosts that have 64-bit int, so that they can access
14946 large files.
122b0c86
PE
14947 However, temporarily disable this change unless the temporary
14948 symbol WIDE_EMACS_INT is defined.
7fd47d5c 14949
8727937b
PE
14950 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
14951
8ac068ac
PE
14952 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
14953 This removes an assumption that EMACS_INT and long are the same
14954 width as pointers. The assumption is true for Emacs porting targets
14955 now, but we want to make other targets possible.
14956 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
14957 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
14958 In the rest of the code, change types of integers that hold casted
14959 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
14960 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
14961 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
14962 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
14963 No need to cast type when ORing.
14964 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
14965 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
14966 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
14967 assume EMACS_INT is the same width as char *.
14968 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
14969 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
14970 Remove no-longer-needed casts.
14971 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
14972 (xg_tool_bar_help_callback, xg_make_tool_item):
14973 Use EMACS_INTPTR to hold an integer
14974 that will be cast to void *; this can avoid a GCC warning
14975 if EMACS_INT is not the same width as void *.
14976 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
14977 * xdisp.c (display_echo_area_1, resize_mini_window_1):
14978 (current_message_1, set_message_1):
14979 Use a local to convert to proper width without a cast.
14980 * xmenu.c (dialog_selection_callback): Likewise.
14981
ede49d71
PE
14982 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
14983 Also, don't assume VALBITS / RAND_BITS is less than 5,
14984 and don't rely on undefined behavior when shifting a 1 left into
14985 the sign bit.
14986 * lisp.h (get_random): Change signature to match.
14987
2f30ecd0
PE
14988 * lread.c (hash_string): Use size_t, not int, for hash computation.
14989 Normally we prefer signed values; but hashing is special, because
14990 it's better to use unsigned division on hash table sizes so that
14991 the remainder is nonnegative. Also, size_t is the natural width
14992 for hashing into memory. The previous code used 'int', which doesn't
14993 retain enough info to hash well into very large tables.
14994 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
14995
2a866e7b
PE
14996 * dbusbind.c: Don't possibly lose pointer info when converting.
14997 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14998 Use XPNTR rather than XHASH, so that the high-order bits of
14999 the pointer aren't lost when converting through void *.
15000
51639eac
PE
15001 * eval.c (Fautoload): Don't double-shift a pointer.
15002
92394119
PE
15003 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
15004
dbdb9a7c
JB
150052011-05-06 Juanma Barranquero <lekktu@gmail.com>
15006
15007 * gnutls.c (DEF_GNUTLS_FN):
15008 * image.c (DEF_IMGLIB_FN): Make function pointers static.
15009
db7a0b4f
AS
150102011-05-05 Andreas Schwab <schwab@linux-m68k.org>
15011
15012 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
15013 marker. (Bug#8610)
15014
cd394be1 150152011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
15016
15017 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
15018 New version that can reserve upto 2GB of heap space.
15019
f7ff1b0f 150202011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
15021
15022 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
15023
639c109b
TZ
150242011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
15025
15026 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
15027 `gnutls_certificate_set_x509_key_file'.
15028
d2127135
JB
150292011-05-05 Juanma Barranquero <lekktu@gmail.com>
15030
15031 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
15032 Update dependencies.
15033
e968f4f3
JB
150342011-05-04 Juanma Barranquero <lekktu@gmail.com>
15035
15036 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
15037 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
15038 Remove unused parameter `fildes'.
15039 * process.c (read_process_output, send_process): Don't pass it.
15040
84d358f0
JB
150412011-05-04 Juanma Barranquero <lekktu@gmail.com>
15042
15043 Fix previous change: the library cache is defined in w32.c.
15044 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
15045 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
15046
0898ca10
JB
150472011-05-04 Juanma Barranquero <lekktu@gmail.com>
15048
15049 Implement dynamic loading of GnuTLS on Windows.
15050
15051 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
15052 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
15053 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15054 Declare.
15055
15056 * gnutls.c (Qgnutls_dll): Define.
15057 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
15058 (gnutls_*): Declare function pointers.
15059 (init_gnutls_functions): New function to initialize function pointers.
15060 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
15061 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
15062 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15063 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
15064 (emacs_gnutls_write, emacs_gnutls_read)
15065 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
15066 (Fgnutls_available_p): New function.
15067 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
15068 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
15069 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
15070
15071 * image.c: Include w32.h.
15072 (Vimage_type_cache): Delete.
15073 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
15074 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
15075 (w32_delayed_load): Move to w32.c.
15076
15077 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
15078
15079 * w32.c (QCloaded_from, Vlibrary_cache): Define.
15080 (w32_delayed_load): Move from image.c. When loading a library, record
15081 its filename in the :loaded-from property of the library id.
15082 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
15083 Initialize and staticpro them.
15084 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
15085
15086 * process.c: Include lisp.h before w32.h, not after.
15087 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
15088 instead of gnutls_record_check_pending.
15089
15090 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
15091
ff4de4aa
TZ
150922011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
15093
15094 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
15095 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
15096 as passed in.
15097
abe95abb
JD
150982011-05-03 Jan Djärv <jan.h.d@swipnet.se>
15099
15100 * xterm.c (x_set_frame_alpha): Do not set property on anything
15101 else than FRAME_X_OUTER_WINDOW (Bug#8608).
15102
e16e55d4
JB
151032011-05-02 Juanma Barranquero <lekktu@gmail.com>
15104
15105 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
15106
bafcf6a5
JB
151072011-05-02 Juanma Barranquero <lekktu@gmail.com>
15108
15109 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
15110 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
15111 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
15112 (gnutls_global_initialized, Qgnutls_bootprop_priority)
15113 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
15114 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
15115 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
15116 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
15117 (Qgnutls_bootprop_callbacks_verify): Make static.
15118
e7a6747f
AS
151192011-05-01 Andreas Schwab <schwab@linux-m68k.org>
15120
19ed11ba
AS
15121 * callproc.c: Indentation fixup.
15122
e7a6747f 15123 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
15124 (wait_for_termination, interruptible_wait_for_termination):
15125 Move after wait_for_termination_1.
e7a6747f 15126
1ef14cb4
LMI
151272011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
15128
15129 * sysdep.c (interruptible_wait_for_termination): New function
15130 which is like wait_for_termination, but allows keyboard
15131 interruptions.
15132
15133 * callproc.c (Fcall_process): Add (:file "file") as an option for
15134 the STDOUT buffer.
15135 (Fcall_process_region): Ditto.
15136
330d880c
EZ
151372011-04-30 Eli Zaretskii <eliz@gnu.org>
15138
8db90b73
EZ
15139 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
15140 rather than `XVECTOR (FOO)->size'.
15141
330d880c
EZ
15142 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
15143 inttypes.h, as a gnulib replacement is used if it not available in
15144 system headers.
15145
15cbd324
EZ
151462011-04-21 Eli Zaretskii <eliz@gnu.org>
15147
15148 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
15149 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
15150 of MOST_POSITIVE_FIXNUM. (Bug#8528)
15151
15152 * coding.c (coding_alloc_by_realloc): Error out if destination
15153 will grow beyond MOST_POSITIVE_FIXNUM.
15154 (decode_coding_emacs_mule): Abort if there isn't enough place in
15155 charbuf for the composition carryover bytes. Reserve an extra
15156 space for up to 2 characters produced in a loop.
15157 (decode_coding_iso_2022): Abort if there isn't enough place in
15158 charbuf for the composition carryover bytes.
15159
151602011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 15161
ae940cca
EZ
15162 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
15163 aborting when %lld or %lll format is passed.
15164 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
15165 %llo or %llx format is passed. (Bug#8545)
15166
03ab8921
EZ
15167 * window.c (window_scroll_line_based): Use a marker instead of
15168 simple variables to record original value of point. (Bug#7952)
15169
afda1437
EZ
15170 * doprnt.c (doprnt): Fix the case where a multibyte sequence
15171 produced by %s or %c overflows available buffer space. (Bug#8545)
15172
f76dee0c
PE
151732011-04-28 Paul Eggert <eggert@cs.ucla.edu>
15174
15175 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 15176 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 15177
fdc5744d
JB
151782011-04-28 Juanma Barranquero <lekktu@gmail.com>
15179
15180 * w32.c (init_environment): Warn about defaulting HOME to C:\.
15181
638f053a
JB
151822011-04-28 Juanma Barranquero <lekktu@gmail.com>
15183
15184 * keyboard.c (Qdelayed_warnings_hook): Define.
15185 (command_loop_1): Run `delayed-warnings-hook'
15186 if Vdelayed_warnings_list is non-nil.
15187 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
15188 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
15189
d178f871
EZ
151902011-04-28 Eli Zaretskii <eliz@gnu.org>
15191
15192 * doprnt.c (doprnt): Don't return value smaller than the buffer
15193 size if the message was truncated. (Bug#8545).
15194
b124fd93
JB
151952011-04-28 Juanma Barranquero <lekktu@gmail.com>
15196
15197 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
15198 (Fx_window_property): #if-0 the whole functions, not just the bodies.
15199
e810457d
PE
152002011-04-27 Paul Eggert <eggert@cs.ucla.edu>
15201
15202 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
15203
ea51cceb
JB
152042011-04-27 Juanma Barranquero <lekktu@gmail.com>
15205
15206 * makefile.w32-in: Update dependencies.
15207
94dcfacf
EZ
152082011-04-27 Eli Zaretskii <eliz@gnu.org>
15209
15210 Improve `doprnt' and its usage. (Bug#8545)
15211 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
15212 `format_end'. Remove support for %l as a conversion specifier.
15213 Don't use xrealloc. Improve diagnostics when the %l size modifier
15214 is used. Update the commentary.
15215
15216 * eval.c (verror): Simplify calculation of size_t.
15217
15218 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
15219 messages.
15220
f61f41d7
PE
152212011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
15222
15223 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
15224 change.
15225
96fb4434
PE
152262011-04-27 Paul Eggert <eggert@cs.ucla.edu>
15227
15228 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
15229 This makes this file independent of the recent pseudovector change.
15230
671875da 152312011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 15232
69e9b5a3
PE
15233 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
15234
b5f869a7 15235 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 15236 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 15237 Remove unused local.
c8926152 15238 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 15239
841a1577 15240 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
15241 GCC 4.6.0 optimizes based on type-based alias analysis.
15242 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
15243 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
15244 != &v->size, and therefore "v->size = 1; b->size = 2; return
15245 v->size;" must therefore return 1. This assumption is incorrect
15246 for Emacs, since it type-puns struct Lisp_Vector * with many other
15247 types. To fix this problem, this patch adds a new type struct
f904488f 15248 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
15249 and pseudovectors, and helps optimizing compilers not get fooled
15250 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
15251 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
15252 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
15253 the size member.
eab3844f
PE
15254 (XSETPVECTYPE): Rewrite in terms of new macro.
15255 (XSETPVECTYPESIZE): New macro, specifying both type and size.
15256 This is a bit clearer, and further avoids the possibility of
15257 undesirable aliasing.
15258 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 15259 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
15260 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
15261 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
15262 (ASIZE): Now uses header.size rather than size.
15263 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
15264 to avoid the hassle of writing XVECTOR (foo)->header.size.
15265 (struct vectorlike_header): New type.
eab3844f
PE
15266 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
15267 object, to help avoid aliasing.
15268 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
15269 (SUBRP): Likewise, since Lisp_Subr is a special case.
15270 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
15271 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
15272 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 15273 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
15274 changed to be "header.size" and "header.next".
15275 * buffer.h (struct buffer): Likewise.
15276 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
15277 * frame.h (struct frame): Likewise.
15278 * process.h (struct Lisp_Process): Likewise.
15279 * termhooks.h (struct terminal): Likewise.
15280 * window.c (struct save_window_data, struct saved_window): Likewise.
15281 * window.h (struct window): Likewise.
15282 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
15283 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
15284 * buffer.c (init_buffer_once): Likewise.
15285 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
15286 special case.
15287 * process.c (Fformat_network_address): Use local var for size,
15288 for brevity.
15289
0df1eac5
PE
15290 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
15291
847ab9d1 15292 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
15293 * data.c (atof): Remove decl; no longer used or needed.
15294 (digit_to_number): Move to lread.c.
15295 (Fstring_to_number): Use new string_to_number function, to be
15296 consistent with how the Lisp reader treats infinities and NaNs.
15297 Do not assume that floating-point numbers represent EMACS_INT
15298 without losing information; this is not true on most 64-bit hosts.
15299 Avoid double-rounding errors, by insisting on integers when
15300 parsing non-base-10 numbers, as the documentation specifies.
15301 * lisp.h (string_to_number): New decl, replacing ...
15302 (isfloat_string): Remove.
bc0a5c13 15303 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 15304 (read1): Do not accept +. and -. as integers; this
452f4150
PE
15305 appears to have been a coding error. Similarly, do not accept
15306 strings like +-1e0 as floating point numbers. Do not report
15307 overflow for integer overflows unless the base is not 10 which
15308 means we have no simple and reliable way to continue.
15309 Break out the floating-point parsing into a new
15310 function string_to_number, so that Fstring_to_number parses
15311 floating point numbers consistently with the Lisp reader.
04f2d78b 15312 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
15313 (E_CHAR, EXP_INT): Remove, replacing with ...
15314 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
15315 (string_to_number): New function, replacing isfloat_string.
15316 This function checks for valid syntax and produces the resulting
15317 Lisp float number too. Rework it so that string-to-number
bc0a5c13 15318 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
15319 so that overflow for non-base-10 numbers is reported only when
15320 there's no portable and simple way to convert to floating point.
452f4150 15321
67769ffc
PE
15322 * textprop.c (set_text_properties_1): Rewrite for clarity,
15323 and to avoid GCC warning about integer overflow.
15324
c20db43f
PE
15325 * intervals.h (struct interval): Use EMACS_INT for members
15326 where EMACS_UINT might cause problems. See
15327 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
15328 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
15329 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
15330 All uses changed.
37aa2f85
PE
15331 (offset_intervals): Tell GCC not to worry about length overflow
15332 when negating a negative length.
c20db43f 15333
2538aa2f
PE
15334 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
15335 (overrun_check_free): Likewise.
15336
f2d3008d
PE
15337 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
15338 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
15339 word size.
15340
ec8df744
PE
15341 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
15342 (gnutls_make_error): Rename local to avoid shadowing.
15343 (gnutls_emacs_global_deinit): ifdef out; not used.
15344 (Fgnutls_boot): Use const for pointer to readonly storage.
15345 Comment out unused local. Fix pointer signedness problems.
15346
640ee02d
PE
15347 * lread.c (openp): Don't stuff size_t into an 'int'.
15348 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
15349 about possible signed overflow.
15350
6048fb2a
PE
15351 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
15352 (GDK_KEY_g): Don't define if already defined.
15353 (xg_prepare_tooltip): Avoid pointer signedness problem.
15354 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
15355
fa3c87e1
PE
15356 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
15357 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
15358
2172544b
PE
15359 * xfns.c (Fx_window_property): Simplify a bit,
15360 to make a bit faster and to avoid GCC 4.6.0 warning.
15361 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
15362
9b821a21
PE
15363 * fns.c (internal_equal): Don't assume size_t fits in int.
15364
3c616cfa
PE
15365 * alloc.c (compact_small_strings): Tighten assertion a little.
15366
c2982e87
PE
15367 Replace pEd with more-general pI, and fix some printf arg casts.
15368 * lisp.h (pI): New macro, generalizing old pEd macro to other
15369 conversion specifiers. For example, use "...%"pI"d..." rather
15370 than "...%"pEd"...".
15371 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 15372 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
15373 * alloc.c (check_pure_size): Don't overflow by converting size to int.
15374 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
15375 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
15376 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
15377 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
15378 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
15379 64-bit hosts.
15380 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
15381 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
15382 * print.c (safe_debug_print, print_object): Likewise.
15383 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
15384 to int.
6f04d126
PE
15385 Use pI instead of if-then-else-abort. Use %p to avoid casts,
15386 avoiding the 0 flag, which is not portable.
c2982e87
PE
15387 * process.c (Fmake_network_process): Use pI to avoid cast.
15388 * region-cache.c (pp_cache): Likewise.
15389 * xdisp.c (decode_mode_spec): Likewise.
15390 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
15391 behavior on 64-bit hosts with printf arg.
6f04d126 15392 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
15393 (x_stop_queuing_selection_requests): Likewise.
15394 (x_get_window_property): Don't truncate byte count to an 'int'
15395 when tracing.
0b432f21 15396
5e073ec7
PE
15397 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
15398 here, since it parses constructs like leading '-' and spaces,
15399 which are not wanted; and it overflows with large numbers.
15400 Instead, simply match F[0-9]+, which is what is wanted anyway.
15401
36372bf9
PE
15402 * alloc.c: Remove unportable assumptions about struct layout.
15403 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
15404 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
15405 (allocate_vectorlike, make_pure_vector): Use the new macros,
15406 plus offsetof, to remove unportable assumptions about struct layout.
15407 These assumptions hold on all porting targets that I know of, but
15408 they are not guaranteed, they're easy to remove, and removing them
15409 makes further changes easier.
15410
0b432f21
PE
15411 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
15412 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
15413 (string_overrun_cookie): Now const. Use initializers that
15414 don't formally overflow signed char, to avoid warnings.
000098c1
PE
15415 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
15416 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
15417 (allocate_buffer): Don't assume sizeof (struct buffer) is a
15418 multiple of sizeof (EMACS_INT); it need not be, if
15419 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 15420 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 15421
895009e1
JB
154222011-04-26 Juanma Barranquero <lekktu@gmail.com>
15423
15424 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
15425
6a7a1b0b
TZ
154262011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
15427
15428 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 15429 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
15430 Reported by Paul Eggert <eggert@cs.ucla.edu>.
15431
841a1577 154322011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
15433
15434 * lisp.h (Qdebug): List symbol.
895009e1 15435 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
15436 * keyboard.c (debug-on-event): New variable.
15437 (handle_user_signal): Break into debugger when debug-on-event
15438 matches the current signal symbol.
15439
f2d3ba6f
DN
154402011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
15441
15442 * alloc.c (check_sblock, check_string_bytes)
15443 (check_string_free_list): Convert to standard C.
15444
42ce4c63
TZ
154452011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
15446
15447 * w32.c (emacs_gnutls_push): Fix typo.
15448
825cd63c
EZ
154492011-04-25 Eli Zaretskii <eliz@gnu.org>
15450
fb11d64d
EZ
15451 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
15452 "cast to pointer from integer of different size".
15453
825cd63c
EZ
15454 Improve doprnt and its use in verror. (Bug#8545)
15455 * doprnt.c (doprnt): Document the set of format control sequences
15456 supported by the function. Use SAFE_ALLOCA instead of always
15457 using `alloca'.
15458
15459 * eval.c (verror): Don't limit the buffer size at size_max-1, that
15460 is one byte too soon. Don't use xrealloc; instead xfree and
15461 xmalloc anew.
15462
e061a11b
TZ
154632011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
15464
15465 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
15466 callbacks stage.
15467
15468 * gnutls.c: Renamed global_initialized to
15469 gnutls_global_initialized. Added internals for the
15470 :verify-hostname-error, :verify-error, and :verify-flags
15471 parameters of `gnutls-boot' and documented those parameters in the
15472 docstring. Start callback support.
9173deec
JB
15473 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
15474 unless a fatal error occurred. Call gnutls_alert_send_appropriate
15475 on error. Return error code.
e061a11b
TZ
15476 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
15477 (emacs_gnutls_read): Likewise.
15478 (Fgnutls_boot): Return handshake error code.
15479 (emacs_gnutls_handle_error): New function.
15480 (wsaerror_to_errno): Likewise.
15481
15482 * w32.h (emacs_gnutls_pull): Add prototype.
15483 (emacs_gnutls_push): Likewise.
15484
15485 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
15486 (emacs_gnutls_push): Likewise.
15487
154882011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
15489
15490 * process.c (wait_reading_process_output): Check if GnuTLS
15491 buffered some data internally if no FDs are set for TLS
15492 connections.
15493
15494 * makefile.w32-in (OBJ2): Add gnutls.$(O).
15495 (LIBS): Link to USER_LIBS.
15496 ($(BLD)/gnutls.$(0)): New target.
15497
fa6996bc
EZ
154982011-04-24 Eli Zaretskii <eliz@gnu.org>
15499
eb35682e
EZ
15500 * xdisp.c (handle_single_display_spec): Rename the
15501 display_replaced_before_p argument into display_replaced_p, to
15502 make it consistent with the commentary. Fix typos in the
15503 commentary.
15504
e2ad650c
EZ
15505 * textprop.c (syms_of_textprop): Remove dead code.
15506 (copy_text_properties): Delete obsolete commentary about an
15507 interface that was deleted long ago. Fix typos in the description
15508 of arguments.
15509
1b2de274
EZ
15510 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
15511 to changes in oldXMenu/XMenu.h from 2011-04-16.
15512 <menu_help_message, prev_menu_help_message>: Constify.
15513 (IT_menu_make_room): menu->help_text is now `const char **';
15514 adjust.
15515
15516 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
15517 to changes in oldXMenu/XMenu.h from 2011-04-16.
15518 (struct XMenu): Declare `help_text' `const char **'.
15519
15520 * xfaces.c <Qunspecified>: Make extern again.
15521
15522 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 15523 required by POSIX.
1b2de274 15524
762b15be
EZ
15525 * doc.c (get_doc_string): Improve the format passed to `error'.
15526
15527 * doprnt.c (doprnt): Improve commentary.
15528
15529 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
15530
15531 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
15532 them with etags.
15533
f1052e5d
EZ
15534 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
15535 changes in globals.h immediately force recompilation.
762b15be
EZ
15536 (TAGS): Depend on $(CURDIR)/m/intel386.h and
15537 $(CURDIR)/s/ms-w32.h.
15538 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 15539
fa6996bc
EZ
15540 * character.c (Fchar_direction): Function deleted.
15541 (syms_of_character): Don't defsubr it.
15542 <char-direction-table>: Deleted.
15543
e6c3da20
EZ
155442011-04-23 Eli Zaretskii <eliz@gnu.org>
15545
15546 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
15547 * doprnt.c: Include limits.h.
15548 (SIZE_MAX): New macro.
04f2d78b
CB
15549 (doprnt): Return a size_t value. 2nd arg is now size_t.
15550 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
15551 Improve overflow protection. Support `l' modifier for integer
15552 conversions. Support %l conversion. Don't assume an EMACS_INT
15553 argument for integer conversions and for %c.
15554
15555 * lisp.h (doprnt): Restore prototype.
15556
15557 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
15558 $(SRC)/character.h.
15559
15560 * Makefile.in (base_obj): Add back doprnt.o.
15561
15562 * deps.mk (doprnt.o): Add back prerequisites.
15563 (callint.o): Depend on character.h.
15564
15565 * eval.c (internal_lisp_condition_case): Include the handler
15566 representation in the error message.
15567 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
15568 when breaking from the loop.
15569
15570 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
15571
15572 * callint.c (Fcall_interactively): When displaying error message
15573 about invalid control letter, pass the character's codepoint, not
15574 a pointer to its multibyte form. Improve display of the character
15575 in octal and display also its hex code.
15576
15577 * character.c (char_string): Use %x to display the (unsigned)
15578 codepoint of an invalid character, to avoid displaying a bogus
15579 negative value.
15580
15581 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
15582 `error', not SYMBOL_NAME itself.
15583
15584 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
15585 character arguments to `error'.
15586
15587 * charset.c (check_iso_charset_parameter): Fix incorrect argument
15588 to `error' in error message about FINAL_CHAR argument. Make sure
15589 FINAL_CHAR is a character, and use %c when it is passed as
15590 argument to `error'.
15591
4ffd0d6b 155922011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
15593
15594 * s/ms-w32.h (localtime): Redirect to sys_localtime.
15595
15596 * w32.c: Include <time.h>.
15597 (sys_localtime): New function.
15598
4ffd0d6b 155992011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
15600
15601 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
15602
4ffd0d6b 15603 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 15604
4ffd0d6b 156052011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 15606
4ffd0d6b
GM
15607 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
15608 zombies (Bug#8467).
aac0c6e3 15609
04c56954
EZ
156102011-04-19 Eli Zaretskii <eliz@gnu.org>
15611
15612 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
15613 gl_state.e_property when gl_state.object is Qt.
15614
15615 * insdel.c (make_gap_larger): Remove limitation of buffer size
15616 to <= INT_MAX.
15617
16a43933
CY
156182011-04-18 Chong Yidong <cyd@stupidchicken.com>
15619
15620 * xdisp.c (lookup_glyphless_char_display)
15621 (produce_glyphless_glyph): Handle cons cell entry in
15622 glyphless-char-display.
15623 (Vglyphless_char_display): Document it.
15624
15625 * term.c (produce_glyphless_glyph): Handle cons cell entry in
15626 glyphless-char-display.
15627
4581706e
CY
156282011-04-17 Chong Yidong <cyd@stupidchicken.com>
15629
15630 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
15631
15632 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
15633
15634 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
15635 definition for no-X builds.
15636
4887c6e2 156372011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 15638
fd35b6f9
PE
15639 Static checks with GCC 4.6.0 and non-default toolkits.
15640
5c1ccb01
PE
15641 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
15642
006c5daa
PE
15643 * process.c (keyboard_bit_set): Define only if SIGIO.
15644 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
15645 (send_process): Repair possible setjmp clobbering.
15646
efc736d3
PE
15647 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
15648
4e2fe2e6
PE
15649 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
15650
f97334a2
PE
15651 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
15652
4e75f29d
PE
15653 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
15654 Define only if needed.
15655
90efadd1
PE
15656 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
15657 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 15658 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 15659
3c647824
PE
15660 * dispextern.h (struct redisplay_interface): Rename param
15661 to avoid shadowing.
e264f262 15662 * termhooks.h (struct terminal): Likewise.
761383f4 15663 * xterm.c (xembed_send_message): Likewise.
3c647824 15664
b58c5c4a
PE
15665 * insdel.c (make_gap_smaller): Define only if
15666 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
15667
cad59032
PE
15668 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
15669 it.
15670
c339dc2e
PE
15671 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
15672 so that we aren't warned about unused symbols.
15673
91a3e27b
PE
15674 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
15675
399c71d3 15676 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 15677
8ffc96f5
PE
15678 * xfns.c (x_real_positions): Mark locals as initialized.
15679
eef9bc79
PE
15680 * xmenu.c (xmenu_show): Don't use uninitialized vars.
15681
098db9dd
PE
15682 * xterm.c: Fix problems found by static analysis with other toolkits.
15683 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
15684 (x_dispatch_event): Declare static if USE_GTK, and
15685 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 15686 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 15687 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
15688 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
15689 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 15690
eb18f6cc
PE
15691 * xmenu.c (menu_help_callback): Pointer type fixes.
15692 Use const pointers when pointing at readonly data. Avoid pointer
15693 signedness clashes.
15694 (FALSE): Remove unused macro.
15695 (update_frame_menubar): Remove unused decl.
15696
1fe72bf8
PE
15697 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
15698
60d9e1db
PE
15699 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
15700 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
15701 (single_menu_item): Rename local to avoid shadowing.
15702
39261c26
PE
15703 * keyboard.c (make_lispy_event): Remove unused local var.
15704
018c5e19
PE
15705 * frame.c, frame.h (x_get_resource_string): Bring this back, but
15706 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
15707
63d2b86e
PE
15708 * bitmaps: Change bitmaps from unsigned char back to the X11
15709 compatible char. Avoid the old compiler warnings about
15710 out-of-range initializers by using, for example, '\xab' rather
15711 than 0xab.
15712
aefd87e1
PE
15713 * xgselect.c (xgselect_initialize): Check vs interface
15714 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
15715
bf501fb9
PE
15716 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
15717
e9829fdf
PE
15718 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
15719 to read-only memory.
15720
1086c095
PE
15721 * fns.c (vector): Remove; this old hack is no longer needed.
15722
2baccd04 15723 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 15724 Remove unused var.
dde42981 15725 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 15726
72391843 15727 * xrdb.c (x_load_resources): Omit unused local.
3565b346 15728
436c16df 15729 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 15730 (x_window): Rename locals to avoid shadowing.
dc5ddd85 15731 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 15732
92bb796d 15733 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 15734 (x_term_init): Remove local to avoid shadowing.
92bb796d 15735
764430a3 15736 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
15737
15738 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
15739 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
15740
d1dfb56c
EZ
157412011-04-16 Eli Zaretskii <eliz@gnu.org>
15742
c4354cb4
EZ
15743 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
15744
d1dfb56c
EZ
15745 Fix regex.c, syntax.c and friends for buffers > 2GB.
15746 * syntax.h (struct gl_state_s): Declare character position members
15747 EMACS_INT.
15748
15749 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
15750
04f2d78b
CB
15751 * textprop.c (verify_interval_modification, interval_of):
15752 Declare arguments EMACS_INT.
d1dfb56c
EZ
15753
15754 * intervals.c (adjust_intervals_for_insertion): Declare arguments
15755 EMACS_INT.
15756
15757 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
15758
15759 * indent.c (Fvertical_motion): Local variable it_start is now
15760 EMACS_INT.
15761
15762 * regex.c (re_match, re_match_2, re_match_2_internal)
15763 (bcmp_translate, regcomp, regexec, print_double_string)
15764 (group_in_compile_stack, re_search, re_search_2, regex_compile)
15765 (re_compile_pattern, re_exec): Declare arguments and local
15766 variables `size_t' and `ssize_t' and return values `regoff_t', as
15767 appropriate.
15768 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
15769 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
15770 <compile_stack_type>: `size' and `avail' are now `size_t'.
15771
15772 * regex.h <regoff_t>: Use ssize_t, not int.
15773 (re_search, re_search_2, re_match, re_match_2): Arguments that
15774 specify buffer/string position and length are now ssize_t and
15775 size_t. Return type is regoff_t.
15776
613052cd
BK
157772011-04-16 Ben Key <bkey76@gmail.com>
15778
15779 * nsfont.m: Fixed bugs in ns_get_family and
15780 ns_descriptor_to_entity that were caused by using free to
15781 deallocate memory blocks that were allocated by xmalloc (via
15782 xstrdup). This caused Emacs to crash when compiled with
15783 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
15784 --enable-checking=xmallocoverrun). xfree is now used to
15785 deallocate these memory blocks.
15786
4170f62f 157872011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 15788
71b41406
PE
15789 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
15790
9587a89d
PE
15791 emacs_write: Accept and return EMACS_INT for sizes.
15792 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
15793 et seq.
15794 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
15795 Accept and return EMACS_INT.
15796 (emacs_gnutls_write): Return the number of bytes written on
15797 partial writes.
15798 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
15799 (emacs_read, emacs_write): Remove check for negative size, as the
15800 Emacs source code has been audited now.
9587a89d
PE
15801 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
15802 (emacs_read, emacs_write): Use it.
273a5f82
PE
15803 * process.c (send_process): Adjust to the new signatures of
15804 emacs_write and emacs_gnutls_write. Do not attempt to store
15805 a byte offset into an 'int'; it might overflow.
9587a89d 15806 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 15807
3e047f51
PE
15808 * sound.c: Don't assume sizes fit in 'int'.
15809 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 15810 Return EMACS_INT, not int.
3e047f51 15811 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
15812 Accept EMACS_INT, not int.
15813 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
15814 record read return values.
15815
cc39a9db
BK
158162011-04-15 Ben Key <bkey76@gmail.com>
15817
c9d0ec6d
JB
15818 * keyboard.c (Qundefined): Don't declare static since it is used
15819 in nsfns.m.
15820 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
15821 static since they are used in nsfont.m.
cc39a9db 15822
6c60eb9f
SM
158232011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
15824
15825 * process.c (Qprocessp): Don't declare static.
15826 * lisp.h (Qprocessp): Declare again.
15827
7990b61a
JB
158282011-04-15 Juanma Barranquero <lekktu@gmail.com>
15829
15830 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
15831
5d4cb038
PE
158322011-04-14 Paul Eggert <eggert@cs.ucla.edu>
15833
8bd7b830 15834 Improve C-level modularity by making more things 'static'.
cd64ea1d 15835
e3b27b31
PE
15836 Don't publish debugger-only interfaces to other modules.
15837 * lisp.h (safe_debug_print, debug_output_compilation_hack):
15838 (verify_bytepos, count_markers): Move decls to the only modules
15839 that need them.
15840 * region-cache.h (pp_cache): Likewise.
15841 * window.h (check_all_windows): Likewise.
15842 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
15843
5d4cb038
PE
15844 * sysdep.c (croak): Now static, if
15845 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
15846 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
15847
15848 * alloc.c (refill_memory_reserve): Now static if
15849 !defined REL_ALLOC || defined SYSTEM_MALLOC.
15850 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 15851
e87b6180
PE
15852 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
15853 Define only if USE_LUCID.
15854
ac64929e
PE
15855 * xrdb.c (x_customization_string, x_rm_string): Now static.
15856
6f37259d
PE
15857 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
15858 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
15859
1683e3ab
PE
15860 * xdisp.c (draw_row_with_mouse_face): Now static.
15861 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
15862
de9c2632
PE
15863 * window.h (check_all_windows): Mark externally visible.
15864
2b96acb7
PE
15865 * window.c (window_deletion_count): Now static.
15866
15867 * undo.c: Make symbols static if they're not exported.
15868 (last_undo_buffer, last_boundary_position, pending_boundary):
15869 Now static.
15870
50436f33
PE
15871 * textprop.c (interval_insert_behind_hooks): Now static.
15872 (interval_insert_in_front_hooks): Likewise.
15873
64520e5c
PE
15874 * term.c: Make symbols static if they're not exported.
15875 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
15876 (max_frame_lines, tty_set_terminal_modes):
15877 (tty_reset_terminal_modes, tty_turn_off_highlight):
15878 (get_tty_terminal): Now static.
15879 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
15880 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 15881 HAVE_WINDOW_SYSTEM.
64520e5c
PE
15882 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
15883 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
15884
1fa53021
PE
15885 * sysdep.c: Make symbols static if they're not exported.
15886 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
15887 Now static.
15888 (sigprocmask_set, full_mask): Remove; unused.
15889 (wait_debugging): Mark as visible.
15890 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
15891 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
15892
d4b43b22
PE
15893 * syntax.c (syntax_temp): Define only if !__GNUC__.
15894
b7c513d0
PE
15895 * sound.c (current_sound_device, current_sound): Now static.
15896
989b29ad
PE
15897 * search.c (searchbufs, searchbuf_head): Now static.
15898
13a55a78
PE
15899 * scroll.c (scroll_cost): Remove; unused.
15900 * dispextern.h (scroll_cost): Remove decl.
15901
de68a1fc
PE
15902 * region-cache.h (pp_cache): Mark as externally visible.
15903
40ccffa6
PE
15904 * process.c: Make symbols static if they're not exported.
15905 (process_tick, update_tick, create_process, chan_process):
15906 (Vprocess_alist, proc_buffered_char, datagram_access):
15907 (fd_callback_data, send_process_frame, process_sent_to): Now static.
15908 (deactivate_process): Mark defn as static, as well as decl.
15909 * lisp.h (create_process): Remove decl.
15910 * process.h (chan_process, Vprocess_alist): Remove decls.
15911
ad64fc97
PE
15912 * print.c: Make symbols static if they're not exported.
15913 (print_depth, new_backquote_output, being_printed, print_buffer):
15914 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
15915 (print_interval, print_number_index, initial_stderr_stream):
15916 Now static.
15917 * lisp.h (Fprinc): Remove decl.
15918 (debug_output_compilation_hack): Mark as externally visible.
15919
adddb265
PE
15920 * sysdep.c (croak): Move decl from here to syssignal.h.
15921 * syssignal.h (croak): Put it here, so the API can be checked when
15922 'croak' is called from dissociate_if_controlling_tty.
15923
1717ede2
PE
15924 * minibuf.c: Make symbols static if they're not exported.
15925 (minibuf_save_list, choose_minibuf_frame): Now static.
15926 * lisp.h (choose_minibuf_frame): Remove decl.
15927
fa5fb2bc
PE
15928 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
15929
1e3890d1
PE
15930 * lread.c: Make symbols static if they're not exported.
15931 (read_objects, initial_obarray, oblookup_last_bucket_number):
15932 Now static.
15933 (make_symbol): Remove; unused.
15934 * lisp.h (initial_obarray, make_symbol): Remove decls.
15935
8a1414fa
PE
15936 * keyboard.c: Make symbols static if they're not exported.
15937 (single_kboard, recent_keys_index, total_keys, recent_keys):
15938 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
15939 (this_single_command_key_start, echoing, last_auto_save):
15940 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
15941 (command_loop, echo_now, keyboard_init_hook, help_char_p):
15942 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
15943 (Vlispy_mouse_stem, double_click_count):
15944 Now static.
15945 (force_auto_save_soon): Define only if SIGDANGER.
15946 (ignore_mouse_drag_p): Now static if
15947 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
15948 (print_help): Remove; unused.
15949 (stop_character, last_timer_event): Mark as externally visible.
15950 * keyboard.h (ignore_mouse_drag_p): Declare only if
15951 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
15952 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
15953 * lisp.h (echoing): Remove decl.
15954 (force_auto_save_soon): Declare only if SIGDANGER.
15955 * xdisp.c (redisplay_window): Simplify code, to make it more
15956 obvious that ignore_mouse_drag_p is not accessed if !defined
15957 USE_GTK && !defined HAVE_NS.
15958
93ea6e8f
PE
15959 * intervals.c: Make symbols static if they're not exported.
15960 (merge_properties_sticky, merge_interval_right, delete_interval):
15961 Now static.
15962 * intervals.h (merge_interval_right, delete_interval): Remove decls.
15963
77382fcc
PE
15964 * insdel.c: Make symbols static if they're not exported.
15965 However, leave prepare_to_modify_buffer alone. It's never
15966 called from outside this function, but that appears to be a bug.
15967 (combine_after_change_list, combine_after_change_buffer):
4889fc82 15968 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
15969 (adjust_after_replace_noundo): Remove; unused.
15970 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 15971 (signal_before_change): Remove decls.
77382fcc 15972
9306c32e
PE
15973 * indent.c (val_compute_motion, val_vmotion): Now static.
15974
cd44d2eb
PE
15975 * image.c: Make symbols static if they're not exported.
15976 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
15977 if USE_GTK.
15978 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
15979 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
15980
ad9a7a06
PE
15981 * fringe.c (standard_bitmaps): Now static.
15982 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
15983
81626931
PE
15984 * frame.c: Make symbols static if they're not exported.
15985 (x_report_frame_params, make_terminal_frame): Now static.
15986 (get_frame_param): Now static, unless HAVE_NS.
15987 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
15988 (x_get_resource_string): Remove; not used.
15989 * frame.h (make_terminal_frame, x_report_frame_params):
15990 (x_get_resource_string); Remove decls.
15991 (x_fullscreen_adjust): Declare only if WINDOWSNT.
15992 * lisp.h (get_frame_param): Declare only if HAVE_NS.
15993
239f9db9
PE
15994 * font.c, fontset.c: Make symbols static if they're not exported.
15995 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
15996 (FACE_SUITABLE_FOR_CHAR_P): Use it.
15997 * font.c (font_close_object): Now static.
15998 * font.h (font_close_object): Remove.
15999 * fontset.c (FONTSET_OBJLIST): Remove.
16000 (free_realized_fontset) #if-0 the body, which does nothing.
16001 (face_suitable_for_char_p): #if-0, as it's never called.
16002 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
16003 * xfaces.c (face_at_string_position):
16004 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
16005 since 0 is always ASCII.
16006
dfcf3579
PE
16007 * fns.c (weak_hash_tables): Now static.
16008
5045092b
PE
16009 * fileio.c: Make symbols static if they're not exported.
16010 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
16011 (Vwrite_region_annotation_buffers): Now static.
16012
57a96f5c
PE
16013 * eval.c: Make symbols static if they're not exported.
16014 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
16015 * lisp.h (backtrace_list): Remove decl.
16016
35f08c38
PE
16017 * emacs.c: Make symbols static if they're not exported.
16018 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
16019 (fatal_error_code, fatal_error_signal_hook, standard_args):
16020 Now static.
16021 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
16022 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
16023 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
16024 * lisp.h (fatal_error_signal_hook): Remove decl.
16025 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
16026
f44bd759
PE
16027 * editfns.c: Move a (normally-unused) function to its only use.
16028 * editfns.c, lisp.h (get_operating_system_release): Remove.
16029 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
16030 worth the hassle of breaking this out.
16031
b532497d
PE
16032 * xterm.c: Make symbols static if they're not exported.
16033 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
16034 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
16035 (x_destroy_window, x_delete_display):
16036 Now static.
16037 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
16038 (x_mouse_leave): Remove; unused.
16039 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
16040 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
16041 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
16042 Remove decls.
16043 (x_mouse_leave): Declare only if WINDOWSNT.
16044 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
16045 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
16046 USE_X_TOOLKIT.
16047
1675728f
PE
16048 * ftxfont.c: Make symbols static if they're not exported.
16049 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
16050 HAVE_FREETYPE.
16051 * font.h (ftxfont_driver): Likewise.
16052
e4cebfca
PE
16053 * xfns.c: Make symbols static if they're not exported.
16054 (x_last_font_name, x_display_info_for_name):
16055 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
16056 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
16057 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
16058 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
16059 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
16060 (last_show_tip_args): Now static.
16061 (xic_defaut_fontset, xic_create_fontsetname): Define only if
16062 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
16063 (x_screen_planes): Remove; unused.
16064 * dispextern.h (x_screen_planes): Remove decl.
16065
5bf46f05
PE
16066 * dispnew.c: Make symbols static if they're not exported.
16067 * dispextern.h (redraw_garbaged_frames, scrolling):
16068 (increment_row_positions): Remove.
16069 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
16070 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
16071 Now static.
16072 (redraw_garbaged_frames): Remove; unused.
16073
435f4c28
PE
16074 * xfaces.c: Make symbols static if they're not exported.
16075 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
16076 Remove decls.
16077 * xterm.h (defined_color): Remove decls.
16078 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
16079 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
16080 (menu_face_changed_default, defined_color, free_realized_face):
16081 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
16082 (ascii_face_of_lisp_face): Remove; unused.
16083
8524aef3
PE
16084 * xdisp.c: Make symbols static if they're not exported.
16085 * dispextern.h (scratch_glyph_row, window_box_edges):
16086 (glyph_to_pixel_coords, set_cursor_from_row):
16087 (get_next_display_element, set_iterator_to_next):
16088 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
16089 (show_mouse_face): Remove decls
16090 * frame.h (message_buf_print): Likewise.
16091 * lisp.h (pop_message, set_message, check_point_in_composition):
16092 Likewise.
16093 * xterm.h (set_vertical_scroll_bar): Likewise.
16094 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
16095 (message_buf_print, scratch_glyph_row, displayed_buffer):
16096 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
16097 (get_next_display_element, show_mouse_face, window_box_edges):
16098 (frame_to_window_pixel_xy, check_point_in_composition):
16099 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
16100 (glyph_to_pixel_coords): Remove; unused.
16101
16390cd2
PE
16102 * dired.c (file_name_completion): Now static.
16103
16104 * dbusbind.c (xd_in_read_queued_messages): Now static.
16105
a25f4dfa
PE
16106 * lisp.h (circular_list_error, FOREACH): Remove; unused.
16107 * data.c (circular_list_error): Remove.
16108
14a9c8df
PE
16109 * commands.h (last_point_position, last_point_position_buffer):
16110 (last_point_position_window): Remove decls.
16111 * keyboard.c: Make these variables static.
16112
04f2d78b
CB
16113 * coding.h (coding, code_convert_region, encode_coding_gap):
16114 Remove decls.
74ab6df5
PE
16115 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
16116 (iso_code_class, detect_coding, code_convert_region): Now static.
16117 (encode_coding_gap): Remove; unused.
16118
38dfbee1
PE
16119 * chartab.c (chartab_chars, chartab_bits): Now static.
16120
a2cb4e63
PE
16121 * charset.h (charset_iso_8859_1): Remove decl.
16122 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
16123 Now static.
16124
127198fd
PE
16125 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
16126 * ccl.c (Vccl_program_table): Now static.
16127 (check_ccl_update): Remove; unused.
16128
d85b608f
PE
16129 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
16130 * category.h: ... from here.
16131 * category.c (check_category_table, set_category_set): Now static.
16132
31cd66f3
PE
16133 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
16134 * lisp.h: Remove these decls.
16135
c358e587
PE
16136 * buffer.c (buffer_count): Remove unused var.
16137
e78aecca
PE
16138 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
16139 so that it's not optimized away.
16140 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
16141 * dispextern.h (bidi_dump_cached_states): Remove, since it's
16142 exported only to the debugger.
16143
e192d7d3 16144 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 16145 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 16146
92470028
PE
16147 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
16148 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
16149 was inaccessible from Lisp.
16150 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
16151 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
16152
244ed907
PE
16153 alloc.c: Import and export fewer symbols, and remove unused items.
16154 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
16155 is defined.
16156 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
16157 it's not optimized away by whole-program optimization.
16158 (message_enable_multibyte, free_misc): Remove.
16159 (catchlist, handlerlist, mark_backtrace):
16160 Declare only if BYTE_MARK_STACK.
16161 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
16162 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
16163 (message_enable_multibyte): Remove decl.
16164 (free_misc, interval_free_list, float_block, float_block_index):
16165 (n_float_blocks, float_free_list, cons_block, cons_block_index):
16166 (cons_free_list, last_marked_index):
16167 Now static.
16168 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
16169 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
16170 (mark_backtrace): Define only if BYTE_MARK_STACK.
16171 * xdisp.c (message_enable_multibyte): Now static.
16172
61c2b50e 16173 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
16174 This makes it easier for human readers (and static analyzers)
16175 to see whether these variables are used from other modules.
16176 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
16177 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
16178 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
16179 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
16180 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
16181 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
16182 * xmenu.c, xselect.c:
16183 Declare Q* vars static if they are not used in other modules.
16184 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
16185 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
16186 Remove decls of unexported vars.
16187 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
16188
95c82688
PE
16189 * lisp.h (DEFINE_FUNC): Make sname 'static'.
16190
16a97296
PE
16191 Make Emacs functions such as Fatom 'static' by default.
16192 This makes it easier for human readers (and static analyzers)
16193 to see whether these functions can be called from other modules.
16194 DEFUN now defines a static function. To make the function external
16195 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
16196 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
16197 (Finit_image_library):
16a97296
PE
16198 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
16199 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
16200 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
16201 Remove decls, since these functions are now static.
16202 (Funintern, Fget_internal_run_time): New decls, since these functions
16203 were already external.
95c82688 16204
16a97296
PE
16205 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
16206 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
16207 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
16208 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
16209 * keyboard.c, keymap.c, lread.c:
16210 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
16211 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
16212 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
16213 Mark functions with DEFUE instead of DEFUN,
16214 if they are used in other modules.
16215 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
16216 decls for now-static functions.
16217 * buffer.h (Fdelete_overlay): Remove decl.
16218 * callproc.c (Fgetenv_internal): Mark as internal.
16219 * composite.c (Fremove_list_of_text_properties): Remove decl.
16220 (Fcomposition_get_gstring): New forward static decl.
16221 * composite.h (Fcomposite_get_gstring): Remove decl.
16222 * dired.c (Ffile_attributes): New forward static decl.
16223 * doc.c (Fdocumntation_property): New forward static decl.
16224 * eval.c (Ffetch_bytecode): New forward static decl.
16225 (Funintern): Remove extern decl; now in .h file where it belongs.
16226 * fileio.c (Fmake_symbolic_link): New forward static decl.
16227 * image.c (Finit_image_library): New forward static decl.
16228 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
16229 * intervals.h (Fprevious_property_change):
16230 (Fremove_list_of_text_properties): Remove decls.
16231 * keyboard.c (Fthis_command_keys): Remove decl.
16232 (Fcommand_execute): New forward static decl.
16233 * keymap.c (Flookup_key): New forward static decl.
16234 (Fcopy_keymap): Now static.
16235 * keymap.h (Flookup_key): Remove decl.
16236 * process.c (Fget_process): New forward static decl.
16237 (Fprocess_datagram_address): Mark as internal.
16238 * syntax.c (Fsyntax_table_p): New forward static decl.
16239 (skip_chars): Remove duplicate decl.
16240 * textprop.c (Fprevious_property_change): New forward static decl.
16241 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
16242 Now internal.
16243 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
16244 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
16245
785bbd42
PE
16246 * editfns.c (Fformat): Remove unreachable code.
16247
8b913b57
AS
162482011-04-14 Andreas Schwab <schwab@linux-m68k.org>
16249
16250 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
16251 change. (Bug#8496)
16252
a6744a35
EZ
162532011-04-13 Eli Zaretskii <eliz@gnu.org>
16254
16255 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
16256 when at ZV. (Bug#8487)
16257
e7974947
AS
162582011-04-12 Andreas Schwab <schwab@linux-m68k.org>
16259
baad03f0
AS
16260 * charset.c (Fclear_charset_maps): Use xfree instead of free.
16261 (Bug#8437)
16262 * keyboard.c (parse_tool_bar_item): Likewise.
16263 * sound.c (sound_cleanup, alsa_close): Likewise.
16264 * termcap.c (tgetent): Likewise.
16265 * xfns.c (x_default_font_parameter): Likewise.
16266 * xsettings.c (read_and_apply_settings): Likewise.
16267
e7974947
AS
16268 * alloc.c (overrun_check_malloc, overrun_check_realloc)
16269 (overrun_check_free): Protoize.
16270
28272684
PE
162712011-04-12 Paul Eggert <eggert@cs.ucla.edu>
16272
16273 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
16274 since callers should never pass a negative size.
16275 Change the signature to match that of plain 'read' and 'write'; see
16276 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
16277 * lisp.h: Update prototypes of emacs_write and emacs_read.
16278
11997c76
EZ
162792011-04-11 Eli Zaretskii <eliz@gnu.org>
16280
16281 * xdisp.c (redisplay_window): Don't try to determine the character
16282 position of the scroll margin if the window start point w->startp
e896f03c 16283 is outside the buffer's accessible region. (Bug#8468)
11997c76 16284
8a2cbd72
EZ
162852011-04-10 Eli Zaretskii <eliz@gnu.org>
16286
16287 Fix write-region and its subroutines for buffers > 2GB.
16288 * fileio.c (a_write, e_write): Modify declaration of arguments and
16289 local variables to support buffers larger than 2GB.
16290 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
16291
16292 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
16293 argument, local variables, and return value.
16294
16295 * lisp.h: Update prototypes of emacs_write and emacs_read.
16296
16297 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
16298
4073e537 162992011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 16300
1ebfdcb6
PE
16301 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
16302
b2ded58d
PE
16303 Fix more problems found by GCC 4.6.0's static checks.
16304
7d66342c
PE
16305 * xdisp.c (vmessage): Use a better test for character truncation.
16306
bbf47d44
PE
16307 * charset.c (load_charset_map): <, not <=, for optimization,
16308 and to avoid potential problems with integer overflow.
9248994d 16309 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 16310 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 16311 * editfns.c (Fformat): Likewise.
1e69125e 16312 * syntax.c (skip_chars): Likewise.
3befa583 16313
e3019616
PE
16314 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
16315 This also lets GCC 4.6.0 generate slightly better loop code.
16316
becfa255
PE
16317 * callint.c (Fcall_interactively): <, not <=, for optimization.
16318 (Fcall_interactively): Count the number of arguments produced,
16319 not the number of arguments given. This is simpler and lets GCC
16320 4.6.0 generate slightly better code.
16321
dae0cd48
PE
16322 * ftfont.c: Distingish more carefully between FcChar8 and char.
16323 The previous code passed unsigned char * to a functions like
16324 strlen and xstrcasecmp that expect char *, which does not
16325 conform to the C standard.
16326 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
16327 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
16328 char * when the C standard requires it.
16329
76032d70
PE
16330 * keyboard.c (read_char): Remove unused var.
16331
eb3f1cc8
PE
16332 * eval.c: Port to Windows vsnprintf (Bug#8435).
16333 Include <limits.h>.
16334 (SIZE_MAX): Define if the headers do not.
16335 (verror): Do not give up if vsnprintf returns a negative count.
16336 Instead, grow the buffer. This ports to Windows vsnprintf, which
16337 does not conform to C99. Problem reported by Eli Zaretskii.
16338 Also, simplify the allocation scheme, by avoiding the need for
16339 calling realloc, and removing the ALLOCATED variable.
16340
70476b54
PE
16341 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
16342
12020a9e
PE
16343 Remove invocations of doprnt, as Emacs now uses vsnprintf.
16344 But keep the doprint source code for now, as we might revamp it
16345 and use it again (Bug#8435).
ea6c7ae6
PE
16346 * lisp.h (doprnt): Remove.
16347 * Makefile.in (base_obj): Remove doprnt.o.
16348 * deps.mk (doprnt.o): Remove.
16349
5fdb398c
PE
16350 error: Print 32- and 64-bit integers portably (Bug#8435).
16351 Without this change, on typical 64-bit hosts error ("...%d...", N)
16352 was used to print both 32- and 64-bit integers N, which relied on
16353 undefined behavior.
61bdb816 16354 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
16355 * lisp.h (error, verror): Mark as printf-like functions.
16356 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
16357 Report overflow in size calculations when allocating printf buffer.
16358 Do not truncate output string at its first null byte.
16359 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
16360 Truncate the output at a character boundary, since vsnprintf does not
16361 do that.
16362 * charset.c (check_iso_charset_parameter): Convert internal
16363 character to string before calling 'error', since %c now has the
16364 printf meaning.
16365 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
16366 overflow when computing char to be passed to 'error'. Do not
16367 pass Lisp_Object to 'error'; pass the integer instead.
16368 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
16369 formatted with plain %d.
16370
b189fa66
PE
16371 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
16372
bff87ef0
PE
16373 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
16374
7e2cac20
PE
16375 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
16376
ce4d90b5
PE
16377 * xterm.c (x_catch_errors): Remove duplicate declaration.
16378
266c9547
PE
16379 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
16380
79c49ad2
PE
16381 * xdisp.c, lisp.h (message_nolog): Remove; unused.
16382
368f4090
JM
163832011-04-10 Jim Meyering <meyering@redhat.com>
16384
16385 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
16386 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
16387 return ssize_t not "int", and use size_t as the buffer length.
16388 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
16389 * gnutls.h: Update declarations.
16390 * process.c (read_process_output): Use ssize_t, to match.
16391 (send_process): Likewise.
16392
a32d4040
CY
163932011-04-09 Chong Yidong <cyd@stupidchicken.com>
16394
16395 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
16396
8546720e 163972011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 16398
04f2d78b
CB
16399 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
16400 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 16401
8546720e
GM
16402 * xterm.c (handle_one_xevent):
16403 * xmenu.c (create_and_show_popup_menu):
16404 * xselect.c (x_decline_selection_request)
16405 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 16406
0a2f5c1a 164072011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
16408
16409 Fix some uses of `int' instead of EMACS_INT.
16410 * search.c (string_match_1, fast_string_match)
16411 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
16412 (scan_buffer, find_next_newline_no_quit)
16413 (find_before_next_newline, search_command, Freplace_match)
16414 (Fmatch_data): Make some `int' variables be EMACS_INT.
16415
16416 * xdisp.c (display_count_lines): 3rd argument and return value now
16417 EMACS_INT. All callers changed.
16418 (pint2hrstr): Last argument is now EMACS_INT.
16419
16420 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
16421 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
16422 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
16423 (decode_coding_utf_16, decode_coding_emacs_mule)
16424 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
16425 (decode_coding_ccl, decode_coding_charset)
16426 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
16427 (decode_coding_iso_2022, decode_coding_emacs_mule)
16428 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
16429 <char_offset, last_offset>: Declare EMACS_INT.
16430 (encode_coding_utf_8, encode_coding_utf_16)
16431 (encode_coding_emacs_mule, encode_invocation_designation)
16432 (encode_designation_at_bol, encode_coding_iso_2022)
16433 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
16434 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
16435 Declare EMACS_INT.
16436 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
16437 (encode_invocation_designation): Last argument P_NCHARS is now
16438 EMACS_INT.
16439 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
16440 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
16441
16442 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
16443 All users changed.
16444
16445 * ccl.c (Fccl_execute_on_string): Declare some variables
16446 EMACS_INT.
16447
8546720e 164482011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
16449
16450 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
16451
4e19a977
CS
164522011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
16453
16454 * process.c (Fformat_network_address): Doc fix.
16455
87302331
R
164562011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
16457
ee7683eb 16458 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 16459
cbb59342
CY
164602011-04-08 Chong Yidong <cyd@stupidchicken.com>
16461
16462 * keyboard.c (read_char): Call Lisp function help-form-show,
16463 instead of using internal_with_output_to_temp_buffer.
16464 (Qhelp_form_show): New var.
e0d38eeb 16465 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
16466
16467 * print.c (internal_with_output_to_temp_buffer): Function deleted.
16468
16469 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
16470
e67a13ab
CY
164712011-04-06 Chong Yidong <cyd@stupidchicken.com>
16472
04f2d78b
CB
16473 * process.c (Flist_processes): Remove to Lisp.
16474 (list_processes_1): Delete.
e67a13ab 16475
973f782d
EZ
164762011-04-06 Eli Zaretskii <eliz@gnu.org>
16477
7c106b1e
EZ
16478 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
16479
973f782d
EZ
16480 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
16481
41cf7d1a 164822011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 16483
ca23cc88
PE
16484 Fix more problems found by GCC 4.6.0's static checks.
16485
f390e2d5
PE
16486 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
16487
42eea0d0
PE
16488 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
16489
b69769da 16490 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 16491
f9541e84
PE
16492 * xdisp.c (vmessage): Mark as a printf-like function.
16493
13841b55
PE
16494 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
16495
c136c10f
PE
16496 * sound.c (sound_warning): Don't crash if arg contains a printf format.
16497
5e2d4a30
PE
16498 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
16499 printf-like functions.
16500 (tiff_load): Add casts to remove these marks before passing them
16501 to system-supplied API.
16502
583f48b9
PE
16503 * eval.c (Fsignal): Remove excess argument to 'fatal'.
16504
b25d760e
PE
16505 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
16506 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
16507 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
16508 directly, rather than having caller test rule sign. This avoids
16509 some unnecessary tests.
16510 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
16511 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
16512 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 16513
bc7b6697 16514 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 16515 (xfont_open): Avoid unnecessary tests.
bc7b6697 16516
27ccc379
PE
16517 * composite.c (composition_gstring_put_cache): Use unsigned integer.
16518
dcd5c89a
PE
16519 * composite.h, composite.c (composition_gstring_put_cache):
16520 Use EMACS_INT, not int, for length.
16521
b13a45c6
PE
16522 * composite.h (COMPOSITION_DECODE_REFS): New macro,
16523 breaking out part of COMPOSITION_DECODE_RULE.
16524 (COMPOSITION_DECODE_RULE): Use it.
16525 * composite.c (get_composition_id): Remove unused local vars,
16526 by using the new macro.
16527
1e792e4d
PE
16528 * textprop.c (set_text_properties_1): Change while to do-while,
16529 since the condition is always true at first.
16530
dc6c6455 16531 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
16532 (interval_deletion_adjustment): Return unsigned value.
16533 All uses changed.
dc6c6455 16534
aba7731a
PE
16535 * process.c (list_processes_1, create_pty, read_process_output):
16536 (exec_sentinel): Remove vars that were set but not used.
afd4052b 16537 (create_pty): Remove unnecessary "volatile"s.
bc57d757 16538 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 16539 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 16540 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 16541
fdfc4bf3
PE
16542 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
16543
fca8fe46 16544 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 16545 (update_syntax_table): Use unsigned instead of int.
fca8fe46 16546
06a0259a 16547 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 16548 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 16549 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 16550
e7b9e80f
PE
16551 * print.c (print_error_message): Avoid int overflow.
16552
56201685
PE
16553 * font.c (font_list_entities): Redo for clarity,
16554 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
16555
78834453 16556 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 16557 (font_score): Avoid potential overflow in diff calculation.
78834453 16558
0bc0b309 16559 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 16560 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 16561
e610eaca
PE
16562 * eval.c (funcall_lambda): Rename local to avoid shadowing.
16563
b895abce
PE
16564 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
16565 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
16566 can always succeed if overflow has undefined behavior.
16567
1f1d9321 16568 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 16569 (wordify): Omit three unnecessary tests.
1f1d9321 16570
c59478bc
PE
16571 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
16572 All callers changed. This avoids the need for an unused var.
16573
79b73827
PE
16574 * casefiddle.c (casify_region): Remove var that is set but not used.
16575
a4db5dfe
PE
16576 * dired.c (file_name_completion): Remove var that is set but not used.
16577
43aae36e
PE
16578 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
16579
2a47c44d 16580 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 16581 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 16582
a37c69bf
PE
16583 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
16584 Check for integer overflow on size calculations.
16585
328ab8e7
PE
16586 * buffer.c (Fprevious_overlay_change): Remove var that is set
16587 but not used.
16588
e5a2a5cb
PE
16589 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
16590 Remove vars that are set but not used.
8d84a6eb 16591 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 16592 (timer_check_2): Mark vars as initialized.
e5a2a5cb 16593
a60e5f68
PE
16594 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
16595
f661cb61 16596 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 16597 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 16598
f0397f5a
PE
16599 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
16600 that are set but not used.
16601
8664db06 16602 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 16603 if XCreateBitmapFromData fails (Bug#8410).
8664db06 16604
6abdaa4a
PE
16605 * xselect.c (x_get_local_selection, x_handle_property_notify):
16606 Remove vars that are set but not used.
16607
0ce7538d 16608 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 16609 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 16610
9ae848fc
PE
16611 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
16612 Remove var that is set but not used.
0b918413
PE
16613 (scroll_bar_windows_size): Now size_t, not int.
16614 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
16615 Check for overflow.
9ae848fc 16616
a5a62657
PE
16617 * xfaces.c (realize_named_face): Remove vars that are set but not used.
16618 (map_tty_color) [!defined MSDOS]: Likewise.
16619
5c5cdd39
PE
16620 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
16621
66ebf983
PE
16622 * coding.c: Remove vars that are set but not used.
16623 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
16624 All callers changed.
16625 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
16626 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
16627 (decode_coding_charset): Remove vars that are set but not used.
16628
1be4d761
PE
16629 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
16630 that is set but not used.
16631
47553fa8
PE
16632 * print.c (print_object): Remove var that is set but not used.
16633
1f7196bf 16634 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
16635 The gnulib version avoids calling malloc in the usual case,
16636 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
16637 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
16638 * filelock.c (current_lock_owner): Likewise.
16639 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
16640 * sysdep.c: Include allocator.h, careadlinkat.h.
16641 (emacs_no_realloc_allocator): New static constant.
16642 (emacs_readlink): New function.
fdb61804
PE
16643 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
16644 ../lib/careadlinkat.h.
d1fdcab7 16645
f84c17c7
SM
166462011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
16647
16648 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
16649 first non-nil return value).
16650
ef3862ad
JD
166512011-04-03 Jan Djärv <jan.h.d@swipnet.se>
16652
16653 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
16654 if not defined (Bug#8403).
16655
376a7006
JB
166562011-04-02 Juanma Barranquero <lekktu@gmail.com>
16657
16658 * xdisp.c (display_count_lines): Remove parameter `start',
16659 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
16660 (get_char_face_and_encoding): Remove parameter `multibyte_p',
16661 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
16662 (fill_stretch_glyph_string): Remove parameters `row' and `area',
16663 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
16664 and thereabouts. All callers changed.
16665 (get_per_char_metric): Remove parameter `f', unused since
16666 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
16667
6ca3801d
JM
166682011-04-02 Jim Meyering <meyering@redhat.com>
16669
16670 do not dereference NULL upon failed strdup
16671 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
16672 (ns_get_family): Likewise.
16673
d8e2b5ba
JB
166742011-04-02 Juanma Barranquero <lekktu@gmail.com>
16675
16676 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
16677
8c74fcbd
JD
166782011-04-02 Jan Djärv <jan.h.d@swipnet.se>
16679
16680 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
16681 later (Bug#8403).
16682
7200d79c
SM
166832011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
16684
03408648 16685 Add lexical binding.
7200d79c 16686
03408648
SM
16687 * window.c (Ftemp_output_buffer_show): New fun.
16688 (Fsave_window_excursion):
16689 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
16690
16691 * lread.c (lisp_file_lexically_bound_p): New function.
16692 (Fload): Bind Qlexical_binding.
16693 (readevalloop): Remove `evalfun' arg.
16694 Bind Qinternal_interpreter_environment.
16695 (Feval_buffer): Bind Qlexical_binding.
16696 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
16697 Mark as dynamic.
16698 (syms_of_lread): Declare `lexical-binding'.
16699
16700 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
16701
16702 * keyboard.c (eval_dyn): New fun.
16703 (menu_item_eval_property): Use it.
ca105506
SM
16704
16705 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 16706
03408648
SM
16707 * fns.c (concat, mapcar1): Accept byte-code-functions.
16708
16709 * eval.c (Fsetq): Handle lexical vars.
16710 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
16711 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
16712 (FletX, Flet): Obey lexical binding.
16713 (Fcommandp): Handle closures.
16714 (Feval): New `lexical' arg.
16715 (eval_sub): New function extracted from Feval. Use it almost
16716 everywhere where Feval was used. Look up vars in lexical env.
16717 Handle closures.
16718 (Ffunctionp): Move from subr.el.
16719 (Ffuncall): Handle closures.
16720 (apply_lambda): Remove `eval_flags'.
16721 (funcall_lambda): Handle closures and new byte-code-functions.
16722 (Fspecial_variable_p): New function.
16723 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
16724 but without exporting it to Lisp.
23aba0ea 16725
23aba0ea 16726 * doc.c (Fdocumentation, store_function_docstring):
03408648 16727 * data.c (Finteractive_form): Handle closures.
23aba0ea 16728
03408648
SM
16729 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
16730 interactive spec.
ba83908c 16731
04f2d78b
CB
16732 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
16733 New byte-codes.
03408648
SM
16734 (exec_byte_code): New function extracted from Fbyte_code to handle new
16735 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 16736
03408648 16737 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 16738
03408648 16739 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 16740
e2abce01
JB
167412011-03-31 Juanma Barranquero <lekktu@gmail.com>
16742
16743 * xdisp.c (redisplay_internal): Fix prototype.
16744
63696a73 167452011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 16746
63696a73 16747 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
16748 (try_scrolling): Use it when setting scroll_limit.
16749 Limit scrolling to 100 screen lines.
63696a73
EZ
16750 (redisplay_window): Even when falling back on "recentering",
16751 position point in the window according to scroll-conservatively,
16752 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
16753
16754 (try_scrolling): When point is above the window, allow searching
16755 as far as scroll_max, or one screenful, to compute vertical
16756 distance from PT to the scroll margin position. This prevents
16757 try_scrolling from unnecessarily failing when
16758 scroll-conservatively is set to a value slightly larger than the
16759 window height. Clean up the case of PT below the margin at bottom
16760 of window: scroll_max can no longer be INT_MAX. When aggressive
16761 scrolling is in use, don't let point enter the opposite scroll
16762 margin as result of the scroll.
16763 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
16764 threshold of 100 lines for never-recentering scrolling.
16765
e4cc2dfc
JB
167662011-03-31 Juanma Barranquero <lekktu@gmail.com>
16767
16768 * dispextern.h (move_it_by_lines):
16769 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
16770 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
16771 (message_log_check_duplicate): Remove parameters `prev_bol' and
16772 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
16773 (redisplay_internal): Remove parameter `preserve_echo_area',
16774 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
16775
16776 * indent.c (Fvertical_motion):
16777 * window.c (window_scroll_pixel_based, Frecenter):
16778 Don't pass `need_y_p' to `move_it_by_lines'.
16779
1c470562
SM
167802011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
16781
44f230aa
SM
16782 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
16783 steal a few bits to be more compact.
16784 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
16785 Remove unneeded casts.
16786
1c470562
SM
16787 * bytecode.c (Fbyte_code): CAR and CDR can GC.
16788
888adce9
ZK
167892011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
16790
16791 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
16792 binding" message (bug#7967).
16793
f838ed7b
PE
167942011-03-30 Paul Eggert <eggert@cs.ucla.edu>
16795
77861b95
PE
16796 Fix more problems found by GCC 4.6.0's static checks.
16797
de6dbc14
PE
16798 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
16799 Remove unused local var.
16800
f838ed7b
PE
16801 * editfns.c (Fmessage_box): Remove unused local var.
16802
792c7b2b
PE
16803 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
16804 (note_mode_line_or_margin_highlight, note_mouse_highlight):
16805 Omit unused local vars.
c499e557 16806 * window.c (shrink_windows): Omit unused local var.
b01a1c29 16807 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
16808 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
16809 Omit unused local var.
16810
ba0165e1
PE
16811 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
16812 Don't assume string length fits in int.
32ad8845 16813 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 16814 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 16815
3c59b4c9
PE
16816 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
16817 instead of alloca (Bug#8344).
16818
a3eed478 16819 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 16820 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 16821
eb4d412d
PE
16822 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
16823
1658b401
PE
16824 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
16825 concerns.
16826
16827 * term.c (produce_glyphless_glyph): Remove unnecessary test.
16828
16829 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 16830
9a2c6e05
PE
16831 * keyboard.c (syms_of_keyboard): Use the same style as later
16832 in this function when indexing through an array. This also
16833 works around GCC bug 48267.
16834
03d0a109
PE
16835 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
16836
44f730c8
PE
16837 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
16838
fe75f926
PE
16839 * chartab.c (sub_char_table_ref_and_range): Redo for slight
16840 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
16841
ffa8c828
PE
16842 * keyboard.c, keyboard.h (num_input_events): Now size_t.
16843 This avoids undefined behavior on integer overflow, and is a bit
16844 more convenient anyway since it is compared to a size_t variable.
16845
c5101a77
PE
16846 Variadic C functions now count arguments with size_t, not int.
16847 This avoids an unnecessary limitation on 64-bit machines, which
16848 caused (substring ...) to crash on large vectors (Bug#8344).
16849 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
16850 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 16851 All variadic functions and their callers changed accordingly.
c5101a77
PE
16852 (struct gcpro.nvars): Now size_t, not int. All uses changed.
16853 * data.c (arith_driver, float_arith_driver): Likewise.
16854 * editfns.c (general_insert_function): Likewise.
16855 * eval.c (struct backtrace.nargs, interactive_p)
16856 (internal_condition_case_n, run_hook_with_args, apply_lambda)
16857 (funcall_lambda, mark_backtrace): Likewise.
16858 * fns.c (concat): Likewise.
16859 * frame.c (x_set_frame_parameters): Likewise.
16860 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
16861 0 if not found, not -1. All callers changed.
16862
dd3f25f7
PE
16863 * alloc.c (garbage_collect): Don't assume stack size fits in int.
16864 (stack_copy_size): Now size_t, not int.
16865 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
16866
461c2ab9
JB
168672011-03-28 Juanma Barranquero <lekktu@gmail.com>
16868
16869 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
16870 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16871 All callers changed.
16872
16873 * lisp.h (multibyte_char_to_unibyte):
16874 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
16875 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16876 * character.h (CHAR_TO_BYTE8):
16877 * cmds.c (internal_self_insert):
16878 * editfns.c (general_insert_function):
16879 * keymap.c (push_key_description):
16880 * search.c (Freplace_match):
16881 * xdisp.c (message_dolog, set_message_1): All callers changed.
16882
f6d62986
SM
168832011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
16884
16885 * keyboard.c (safe_run_hook_funcall): New function.
16886 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
16887 don't set the hook to nil, but remove the offending function instead.
16888 (Qcommand_hook_internal): Remove, unused.
16889 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
16890 Vcommand_hook_internal.
16891
16892 * eval.c (enum run_hooks_condition): Remove.
16893 (funcall_nil, funcall_not): New functions.
16894 (run_hook_with_args): Call each function through a `funcall' argument.
16895 Remove `cond' argument, now redundant.
16896 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
16897 (Frun_hook_with_args_until_failure): Adjust accordingly.
16898 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
16899
1db5b1ad
JB
169002011-03-28 Juanma Barranquero <lekktu@gmail.com>
16901
16902 * dispextern.h (string_buffer_position): Remove declaration.
16903
16904 * print.c (strout): Remove parameter `multibyte', unused since
16905 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
16906
16907 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
16908 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
16909 All callers changed.
16910
16911 * w32.c (_wsa_errlist): Use braces for struct initializers.
16912
16913 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
16914 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
16915 All callers changed.
16916 (string_buffer_position): Likewise. Also, make static (it's never
16917 used outside xdisp.c).
16918 (cursor_row_p): Remove parameter `w', unused since
16919 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
16920 (decode_mode_spec): Remove parameter `precision', introduced during
16921 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
16922 All callers changed.
16923
5ffb62aa
JD
169242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16925
16926 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
16927
461c2ab9 169282011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
16929
16930 * nsterm.m (ns_menu_bar_is_hidden): New variable.
16931 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
16932 (ns_update_auto_hide_menu_bar): New functions.
16933 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
16934 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
16935 ns_constrain_all_frames.
16936 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
16937 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
16938
5c380ffb
JD
169392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16940
16941 * nsmenu.m (runDialogAt): Remove argument to timer_check.
16942
9af30bdf
GM
169432011-03-27 Glenn Morris <rgm@gnu.org>
16944
16945 * syssignal.h: Replace RETSIGTYPE with void.
16946 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
16947 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
16948 Replace SIGTYPE with void everywhere.
16949 * s/usg5-4-common.h (SIGTYPE): Remove definition.
16950 * s/template.h (SIGTYPE): Remove commented out definition.
16951
e2abce01
JB
169522011-03-26 Eli Zaretskii <eliz@gnu.org>
16953
16954 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
16955 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
16956
f868cd8a
JB
169572011-03-26 Juanma Barranquero <lekktu@gmail.com>
16958
59eb0929
JB
16959 * w32.c (read_unc_volume): Use parameter `henum', instead of
16960 global variable `wget_enum_handle'.
16961
16962 * keymap.c (describe_vector): Remove parameters `indices' and
16963 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
16964 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
16965
f868cd8a
JB
16966 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
16967
16968 * keyboard.c (timer_check): Remove parameter `do_it_now',
16969 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
16970 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
16971 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
16972
16973 * keyboard.c (read_char):
16974 * w32menu.c (w32_menu_display_help):
16975 * xmenu.c (show_help_event, menu_help_callback):
16976 Adjust calls to `show_help_echo'.
16977
16978 * gtkutil.c (xg_maybe_add_timer):
16979 * keyboard.c (readable_events):
16980 * process.c (wait_reading_process_output):
16981 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
16982
16983 * insdel.c (adjust_markers_gap_motion):
16984 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
16985 (gap_left, gap_right): Don't call it.
16986
2ecf6fdb
CY
169872011-03-25 Chong Yidong <cyd@stupidchicken.com>
16988
16989 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
16990 incurred during fontification.
16991
6b1f9ba4
JB
169922011-03-25 Juanma Barranquero <lekktu@gmail.com>
16993
16994 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
16995 (DEFVAR_PER_BUFFER): Don't pass it.
16996
16997 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
16998 (scrolling_window): Don't pass it.
16999
0f4a96b5
JB
170002011-03-25 Juanma Barranquero <lekktu@gmail.com>
17001
17002 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
17003
17004 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
17005 and `suffix'.
17006 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
17007 of variables specific to SELinux and computation of `encoded_absname'.
17008
17009 * image.c (XPutPixel): Remove unused variable `height'.
17010
17011 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
17012
17013 * unexw32.c (get_section_info): Remove unused variable `section'.
17014
17015 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
17016 (system_process_attributes): Remove unused variable `sess'.
17017 (sys_read): Remove unused variable `err'.
17018
17019 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
17020 (w32_wnd_proc): Remove unused variable `isdead'.
17021 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
17022 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
17023 (x_create_tip_frame): Remove unused variable `tem'.
17024
17025 * w32inevt.c (w32_console_read_socket):
17026 Remove unused variable `no_events'.
17027
17028 * w32term.c (x_draw_composite_glyph_string_foreground):
17029 Remove unused variable `width'.
17030
1149507c
JB
170312011-03-24 Juanma Barranquero <lekktu@gmail.com>
17032
17033 * w32term.c (x_set_glyph_string_clipping):
17034 Don't pass uninitialized region to CombineRgn.
17035
9c88f339
JB
170362011-03-23 Juanma Barranquero <lekktu@gmail.com>
17037
17038 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
17039 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
17040 (Fx_close_connection): Remove unused variable `i'.
17041
17042 * w32font.c (w32font_draw): Return number of glyphs.
17043 (w32font_open_internal): Remove unused variable `i'.
17044 (w32font_driver): Add missing initializer.
17045
17046 * w32menu.c (utf8to16): Remove unused variable `utf16'.
17047 (fill_in_menu): Remove unused variable `items_added'.
17048
17049 * w32term.c (last_mouse_press_frame): Remove static global variable.
17050 (w32_clip_to_row): Remove unused variable `f'.
17051 (x_delete_terminal): Remove unused variable `i'.
17052
17053 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
17054 (NOTHING): Remove unused static global variable.
17055 (uniscribe_check_otf): Remove unused variable `table'.
17056 (uniscribe_font_driver): Add missing initializers.
17057
dee091a3
JD
170582011-03-23 Julien Danjou <julien@danjou.info>
17059
17060 * term.c (Fsuspend_tty, Fresume_tty):
17061 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
17062 * window.c (temp_output_buffer_show):
17063 * insdel.c (signal_before_change):
17064 * frame.c (Fhandle_switch_frame):
17065 * fileio.c (Fdo_auto_save):
17066 * emacs.c (Fkill_emacs):
17067 * editfns.c (save_excursion_restore):
17068 * cmds.c (internal_self_insert):
17069 * callint.c (Fcall_interactively):
17070 * buffer.c (Fkill_all_local_variables):
17071 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
17072 Use Frun_hooks.
0f4a96b5 17073 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 17074 unconditionally since it does the check itself.
dee091a3 17075
2c520ab5 170762011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 17077
c9c49752
PE
17078 Fix more problems found by GCC 4.5.2's static checks.
17079
8abc3f12
PE
17080 * coding.c (encode_coding_raw_text): Avoid unnecessary test
17081 the first time through the loop, since we know p0 < p1 then.
17082 This also avoids a gcc -Wstrict-overflow warning.
17083
a2d26660
PE
17084 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
17085 leading to a memory leak, possible in functions like
17086 load_charset_map_from_file that can allocate an unbounded number
b12ef411 17087 of objects (Bug#8318).
a2d26660 17088
916c72e9
PE
17089 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
17090 that could (at least in theory) be that large.
17091
19ab8a18
PE
17092 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
17093 This is less likely to overflow, and avoids undefined behavior if
17094 overflow does occur. All callers changed. Use strtoul to scan
17095 for the unsigned long integer.
b7cbbd6f
PE
17096 (pint2hrstr): Simplify and tune code slightly.
17097 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 17098
f0641eff
PE
17099 * scroll.c (do_scrolling): Work around GCC bug 48228.
17100 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
17101
7f650bb9
PE
17102 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
17103 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
17104 (validate_x_resource_name): Simplify count usage.
17105 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 17106
37dd57d1
PE
17107 * fileio.c (Fcopy_file): Report error if fchown or fchmod
17108 fail (Bug#8306).
81e56e61 17109
699979fc 17110 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 17111
401bf9b4
PE
17112 * process.c (Fmake_network_process): Use socklen_t, not int,
17113 where POSIX says socklen_t is required in portable programs.
17114 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 17115 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
17116 (Fmake_network_process, server_accept_connection):
17117 (wait_reading_process_output, read_process_output):
17118 Likewise.
17119
b93aacde
PE
17120 * process.c: Rename or move locals to avoid shadowing.
17121 (list_processes_1, Fmake_network_process):
17122 (read_process_output_error_handler, exec_sentinel_error_handler):
17123 Rename or move locals.
4dc343ee 17124 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 17125 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 17126 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 17127 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 17128 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 17129
af8a867c 17130 Make tparam.h and terminfo.c consistent.
44f230aa
SM
17131 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
17132 Include tparam.h instead, since it declares them.
af8a867c
PE
17133 * cm.h (PC): Remove extern decl; tparam.h now does this.
17134 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
17135 * terminfo.c: Include tparam.h, to check interfaces.
17136 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
17137 (tparam): Adjust signature to match interface in tparam.h;
17138 this removes some undefined behavior. Check that outstring and len
17139 are zero, which they always are with Emacs.
17140 * tparam.h (PC, BC, UP): New extern decls.
17141
0248044d 17142 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 17143 (xftfont_open): Rename locals to avoid shadowing.
0248044d 17144
8ff096c1 17145 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
17146 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
17147 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 17148 (ftfont_list): Remove unused local.
49eaafba
PE
17149 (get_adstyle_property, ftfont_pattern_entity):
17150 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
17151 Rename locals to avoid shadowing.
8ff096c1 17152
e2be39f6
PE
17153 * xfont.c (xfont_list_family): Mark var as initialized.
17154
c9735e30
PE
17155 * xml.c (make_dom): Now static.
17156
8f5201ae
PE
17157 * composite.c (composition_compute_stop_pos): Rename local to
17158 avoid shadowing.
b246f932
PE
17159 (composition_reseat_it): Remove unused locals.
17160 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 17161 (composition_update_it): Mark var as initialized.
11b61122
PE
17162 (find_automatic_composition): Mark vars as initialized,
17163 with a FIXME (Bug#8290).
8f5201ae 17164
760fbc2c
PE
17165 character.h: Rename locals to avoid shadowing.
17166 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
17167 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
17168 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
17169 (BUF_DEC_POS): Be more systematic about renaming local temporaries
17170 to avoid shadowing.
17171
ff08eb85
PE
17172 * textprop.c (property_change_between_p): Remove; unused.
17173
fc7bf025
PE
17174 * intervals.c (interval_start_pos): Now static.
17175
235d7abc
PE
17176 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
17177
44f230aa
SM
17178 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
17179 Rename locals to avoid shadowing.
3e7d6594 17180
50060332
PE
17181 * sound.c (wav_play, au_play, Fplay_sound_internal):
17182 Fix pointer signedness.
d01f234b 17183 (alsa_choose_format): Remove unused local var.
c83b8872
PE
17184 (wav_play): Initialize a variable to 0, to prevent undefined
17185 behavior (Bug#8278).
50060332 17186
c4fc4e30
PE
17187 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
17188
918436ed
PE
17189 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
17190
c939f91b
PE
17191 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
17192 clobbering (Bug#8298).
b9c7f648
PE
17193 * sysdep.c (sys_subshell): Likewise.
17194 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 17195
6bd8c144
PE
17196 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
17197 This should get cleaned up, so that child_setup has the
17198 same signature on all platforms.
17199
7710357c 17200 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 17201 (relocate_fd): Rename locals to avoid shadowing.
7710357c 17202
c59da222
CY
172032011-03-22 Chong Yidong <cyd@stupidchicken.com>
17204
17205 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
17206 not to be necessary, and produces flickering.
17207
66b87493
GM
172082011-03-20 Glenn Morris <rgm@gnu.org>
17209
17210 * config.in: Remove file.
17211
45b6f6d5
JB
172122011-03-20 Juanma Barranquero <lekktu@gmail.com>
17213
17214 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
17215 are now in src/globals.h.
17216 (syms_of_minibuf): Remove spurious & from previous change.
17217
cd394be1 172182011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
17219
17220 * minibuf.c (completing-read-function): New variable.
17221 (completing-read-default): Rename from completing-read.
17222 (completing-read): Call completing-read-function.
17223
b14e3e21
CY
172242011-03-19 Juanma Barranquero <lekktu@gmail.com>
17225
17226 * xfaces.c (Fx_load_color_file):
17227 Read color file from absolute filename (bug#8250).
17228
f2b726e6
JB
172292011-03-19 Juanma Barranquero <lekktu@gmail.com>
17230
17231 * makefile.w32-in: Update dependencies.
17232
09f6ff02
EZ
172332011-03-17 Eli Zaretskii <eliz@gnu.org>
17234
17235 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
17236
29a6015a
PE
172372011-03-17 Paul Eggert <eggert@cs.ucla.edu>
17238
a3a6c54e
PE
17239 Fix more problems found by GCC 4.5.2's static checks.
17240
b766f867
PE
17241 * process.c (make_serial_process_unwind, send_process_trap):
17242 (sigchld_handler): Now static.
17243
be02381c
PE
17244 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
17245 That way, the code declares only the vars that it needs.
17246 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
17247 * s/cygwin.h (PTY_ITERATION): Likewise.
17248 * s/darwin.h (PTY_ITERATION): Likewise.
17249 * s/gnu-linux.h (PTY_ITERATION): Likewise.
17250
57048744
PE
17251 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
17252 * process.c (allocate_pty): Don't declare stb unless it's needed.
17253
7914961c 17254 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
17255 (CONSTANTLIM): Remove; unused.
17256 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
17257 Define only if needed.
7914961c 17258
b3967b18
PE
17259 * unexelf.c (unexec): Name an expression,
17260 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
17261 Use a different way to cause a compilation error if anyone uses
17262 n rather than nn, a way that does not involve shadowing.
73366a00 17263 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 17264
29a6015a
PE
17265 * deps.mk (unexalpha.o): Remove; unused.
17266
43cfc33e 17267 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 17268 * unexec.h: New file.
ce701a33
PE
17269 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
17270 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
17271 Depend on unexec.h.
17272 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
17273 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
17274 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 17275 Change as necessary to match prototype in unexec.h.
ce701a33 17276
01f44d5a
PE
17277 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
17278 shadowing.
4f63c6bb 17279 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 17280
a6670b0b
PE
17281 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
17282 Rename locals to avoid shadowing.
17283
cef2010d 17284 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 17285 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 17286
d4d7173a
PE
17287 * print.c (Fredirect_debugging_output): Fix pointer signedess.
17288
f08b802a
PE
17289 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
17290 warning when compiling print.c.
17291
3ddb0639
PE
17292 * font.c (font_unparse_fcname): Abort in an "impossible" situation
17293 instead of using an uninitialized var.
5ad03b97 17294 (font_sort_entities): Mark var as initialized.
3ddb0639 17295
170a2692
PE
17296 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
17297
e663c700
PE
17298 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
17299 pointers to constants.
89bc529a 17300 (font_parse_fcname): Remove unused vars.
7b81e2d0 17301 (font_delete_unmatched): Now static.
ea838e10 17302 (font_get_spec): Remove; unused.
13a547c6
PE
17303 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
17304 (font_update_drivers, Ffont_get_glyphs, font_add_log):
17305 Rename or move locals to avoid shadowing.
e663c700 17306
2a80c887 17307 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 17308 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 17309
1384fa33 17310 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 17311 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 17312
8b2c52e9
PE
17313 * alloc.c (mark_backtrace): Move decl from here ...
17314 * lisp.h: ... to here, so that it can be checked.
17315
475545b5 17316 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 17317 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
17318 (lisp_indirect_variable): Name an expression,
17319 to avoid gcc -Wbad-function-cast warning.
1faed8ae 17320 (Fdefvar): Rename locals to avoid shadowing.
475545b5 17321
b1349114 17322 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 17323 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 17324 Use const pointer when appropriate.
b1349114 17325
a2928364
PE
17326 * lisp.h (get_system_name, get_operating_system_release):
17327 Move decls here, to check interfaces.
17328 * process.c (get_operating_system_release): Move decl to lisp.h.
17329 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
17330 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
17331 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
17332 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
17333 (Fformat_time_string, Fencode_time, Finsert_char):
17334 (Ftranslate_region_internal, Fformat):
17335 Rename or remove local vars to avoid shadowing.
9710023e 17336 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 17337
a415e694
PE
17338 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
17339 avoid shadowing.
17340
8ef4622d
PE
17341 * lisp.h (eassert): Check that the argument compiles, even if
17342 ENABLE_CHECKING is not defined.
17343
946f9a5b
PE
17344 * data.c (Findirect_variable): Name an expression, to avoid
17345 gcc -Wbad-function-cast warning.
112396d6 17346 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 17347 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
17348 (Fmake_variable_buffer_local, Fmake_local_variable):
17349 Mark variables as initialized.
52746918 17350 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 17351
e5aab7e7 17352 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
17353 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
17354 Rename locals to avoid shadowing.
dff45157
PE
17355 (mark_stack): Move local variables into the #ifdef region where
17356 they're used.
7bc26fdb
PE
17357 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
17358 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
17359 needed otherwise.
17360 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
17361 (GC_STRING_CHARS): Remove; not used.
d40d4be1 17362 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 17363
e5aab7e7
PE
17364 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
17365 avoids undefined behavior in theory.
17366
4da60324
PE
17367 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
17368
88043301
PE
17369 Use functions, not macros, for up- and down-casing (Bug#8254).
17370 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
17371 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
17372 to use the following functions instead of these macros.
17373 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
17374 EMACS_INT, since callers assume the returned value fits in int.
17375 (upcase1): Likewise, for UPCASE_TABLE.
17376 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 17377 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 17378 the race-condition problem in the old DOWNCASE.
88043301 17379
19ed5445
PE
17380 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
17381 Rename locals to avoid shadowing.
17382 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
17383 (regex_compile, re_search_2, re_match_2_internal):
17384 Remove unused local vars.
952db0d7
PE
17385 (FREE_VAR): Rewrite so as not to use empty "else",
17386 which gcc can warn about.
da053e48 17387 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
17388 (RETALLOC_IF): Define only if needed.
17389 (WORDCHAR_P): Likewise. This one is never needed, but is used
17390 only in a comment talking about a compiler bug, so put inside
17391 the #if 0 of that comment.
17392 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
17393 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
17394 Remove; unused.
19ed5445 17395
1f3561e4 17396 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
17397 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
17398 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 17399
ded6f8f7
PE
17400 * search.c (simple_search): Remove unused var.
17401
dbd37a95
PE
17402 * dired.c (compile_pattern): Move decl from here ...
17403 * lisp.h: ... to here, so that it can be checked.
17404 (struct re_registers): New forward decl.
17405
7e47afad
PE
17406 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
17407
85f24f61
PE
17408 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
17409 All uses changed.
17410 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
17411 Rename locals to avoid shadowing.
5671df8f 17412 (Fvertical_motion): Mark locals as initialized.
85f24f61 17413
181aa2be 17414 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 17415 (casify_region): Mark local as initialized.
181aa2be 17416
930d429c
PE
17417 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
17418
7082eac6
PE
17419 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
17420 New macros, so that the caller can use some names other than
17421 gcpro1, gcpro2, etc.
17422 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
17423 of the new macros.
17424 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
17425 argument, for consistency with GCPRO2_VAR, etc: it is now the
17426 prefix of the variable, not the variable itself. All uses
17427 changed.
38b2c076
PE
17428 * dired.c (directory_files_internal, file_name_completion):
17429 Rename locals to avoid shadowing.
17430
15206ed9
PE
17431 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
17432 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
17433 dired.c's scmp function, had undefined behavior.
17434 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
17435 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
17436 * buffer.h: ... to here, because these macros use current_buffer,
17437 and the new implementation with inline functions needs to have
17438 current_buffer in scope now, rather than later when the macros
17439 are used.
17440 (downcase, upcase1): New static inline functions.
17441 (DOWNCASE, UPCASE1): Reimplement using these functions.
17442 This avoids undefined behavior in expressions like
17443 DOWNCASE (x) == DOWNCASE (y), which previously suffered
17444 from race conditions in accessing the global variables
17445 case_temp1 and case_temp2.
17446 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
17447 * lisp.h (case_temp1, case_temp2): Remove their decls.
17448 * character.h (ASCII_CHAR_P): Move from here ...
17449 * lisp.h: ... to here, so that the inline functions mentioned
17450 above can use them.
17451
4a6bea26
PE
17452 * dired.c (directory_files_internal_unwind): Now static.
17453
f14b7e14
PE
17454 * fileio.c (file_name_as_directory, directory_file_name):
17455 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
17456 Now static.
2893f146
PE
17457 (file_name_as_directory): Use const pointers when appropriate.
17458 (Fexpand_file_name): Likewise. In particular, newdir might
17459 point at constant storage, so make it a const pointer.
fd4ead52 17460 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
17461 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
17462 signedness issues.
f839df0c
PE
17463 (Fset_file_times, Finsert_file_contents, auto_save_error):
17464 Rename locals to avoid shadowing.
f14b7e14 17465
5716756e 17466 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
17467 (Ftry_completion, Fall_completions): Rename or remove locals
17468 to avoid shadowing.
5716756e 17469
b4c3046a
PE
17470 * marker.c (bytepos_to_charpos): Remove; unused.
17471
b45db522
PE
17472 * lisp.h (verify_bytepos, count_markers): New decls,
17473 so that gcc does not warn that these functions aren't declared.
17474
85876d07
PE
17475 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
17476 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 17477 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 17478 (copy_text): Remove unused local var.
85876d07 17479
03d78a21 17480 * filelock.c (within_one_second): Now static.
b3dd38ab 17481 (lock_file_1): Rename local to avoid shadowing.
03d78a21 17482
5df8f01b
PE
17483 * buffer.c (fix_overlays_before): Mark locals as initialized.
17484 (fix_start_end_in_overlays): Likewise. This function should be
17485 simplified by using pointers-to-pointers, but that's a different
17486 matter.
b1d876f1 17487 (switch_to_buffer_1): Now static.
8f54f30a
PE
17488 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
17489 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 17490
a70072c9 17491 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 17492 Fix pointer signedness issue.
edced198
PE
17493 (sys_subshell): Mark local as volatile if checking for lint,
17494 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 17495 (MAXPATHLEN): Define only if needed.
a70072c9 17496
a0977c44
PE
17497 * process.c (serial_open, serial_configure): Move decls from here ...
17498 * systty.h: ... to here, so that they can be checked.
17499
a884fdcc
PE
17500 * fns.c (get_random, seed_random): Move extern decls from here ...
17501 * lisp.h: ... to here, so that they can be checked.
17502
604efe86 17503 * sysdep.c (reset_io): Now static.
b8950c94 17504 (wait_for_termination_signal): Remove; unused.
604efe86 17505
38fc62d9
PE
17506 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
17507 (copy_keymap_item, append_key, push_text_char_description):
17508 Now static.
1004a21a 17509 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 17510 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
17511 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
17512 (describe_map_tree):
17513 Rename locals to avoid shadowing.
38fc62d9 17514
2f2650da
PE
17515 * keyboard.c: Declare functions static if they are not used elsewhere.
17516 (echo_char, echo_dash, cmd_error, top_level_2):
17517 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
17518 (read_char, kbd_buffer_get_event, make_lispy_position):
17519 (make_lispy_event, make_lispy_movement, apply_modifiers):
17520 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
17521 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
17522 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 17523 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 17524 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 17525
a053e86c 17526 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
17527 (mark_kboards): Move decl here ...
17528 * alloc.c (mark_kboards): ... from here.
a053e86c 17529
4752793e
PE
17530 * lisp.h (force_auto_save_soon): New decl.
17531
74f10ca7 17532 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
17533 (DEFINE_DUMMY_FUNCTION): New macro.
17534 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
17535 Use it.
c03cd23f
PE
17536 (main): Add casts to avoid warnings
17537 if GCC considers string literals to be constants.
74f10ca7 17538
022e70d4
PE
17539 * lisp.h (fatal_error_signal): Add decl, since it's exported.
17540
59d6fe83
PE
17541 * dbusbind.c: Pointer signedness fixes.
17542 (xd_signature, xd_append_arg, xd_initialize):
17543 (Fdbus_call_method, Fdbus_call_method_asynchronously):
17544 (Fdbus_method_return_internal, Fdbus_method_error_internal):
17545 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
17546 (Fdbus_register_signal): Use SSDATA when the context wants char *.
17547
78320123
PE
17548 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
17549 if GCC considers string literals to be constants.
49cebcca 17550 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 17551
35ac2a97
SM
175522011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
17553
fb103ca9
SM
17554 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
17555 (print_preprocess, print_object): New macro to fix last change.
17556
35ac2a97
SM
17557 * print.c (print_preprocess): Don't forget font objects.
17558
62973b41
JB
175592011-03-16 Juanma Barranquero <lekktu@gmail.com>
17560
17561 * emacs.c (USAGE3): Doc fixes.
17562
0e48bb22
AS
175632011-03-15 Andreas Schwab <schwab@linux-m68k.org>
17564
17565 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
17566 structure.
17567
7684e57b
JB
175682011-03-14 Juanma Barranquero <lekktu@gmail.com>
17569
17570 * lisp.h (VWindow_system, Qfile_name_history):
17571 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
17572 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
17573 (w32_system_caret_x, w32_system_caret_y): Declare extern.
17574
17575 * w32select.c: Don't #include "keyboard.h".
c96bbc66 17576 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
17577
17578 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
17579 * w32console.c (detect_input_pending, read_input_pending)
17580 (encode_terminal_code):
17581 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
17582 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
17583 (w32_system_caret_y, Qfile_name_history):
17584 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
17585 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
17586 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
17587 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
17588 * w32proc.c (Qlocal, report_file_error):
17589 * w32term.c (Vwindow_system, updating_frame):
17590 * w32uniscribe.c (initialized, uniscribe_font_driver):
17591 Remove unneeded extern declarations.
17592
2aa46d6c
CY
175932011-03-14 Chong Yidong <cyd@stupidchicken.com>
17594
c96bbc66 17595 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 17596
cffc6f3b
CY
175972011-03-13 Chong Yidong <cyd@stupidchicken.com>
17598
17599 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
17600 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
17601 These macros can no longer be used for assignment.
17602
44f230aa
SM
17603 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
17604 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
17605 (record_buffer_markers, fetch_buffer_markers): New functions for
17606 recording and fetching special buffer markers.
17607 (set_buffer_internal_1, set_buffer_temp): Use them.
17608
17609 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
17610
17611 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
17612
17613 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
17614 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
17615
17616 * xdisp.c (hscroll_window_tree):
17617 (reconsider_clip_changes): Use PT instead of BUF_PT.
17618
d251f04b
EZ
176192011-03-13 Eli Zaretskii <eliz@gnu.org>
17620
17621 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
17622 $(EMACS_ROOT)/lib/intprops.h.
17623
f0c77cd1
PE
176242011-03-13 Paul Eggert <eggert@cs.ucla.edu>
17625
3eca4629
PE
17626 Fix more problems found by GCC 4.5.2's static checks.
17627
7c86ee98
PE
17628 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
17629 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
17630 (xg_free_frame_widgets): Make it clear that a local variable is
17631 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
17632 (gdk_window_get_screen): Make it clear that this macro is needed
17633 only if USE_GTK_TOOLTIP.
1e5524e7
PE
17634 (int_gtk_range_get_value): New function, which avoids a diagnostic
17635 from gcc -Wbad-function-cast.
17636 (xg_set_toolkit_scroll_bar_thumb): Use it.
17637 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
17638 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
17639 (get_utf8_string, xg_get_file_with_chooser):
17640 Rename locals to avoid shadowing.
17641 (create_dialog): Move locals to avoid shadowing.
7c86ee98 17642
41729b81
PE
17643 * xgselect.c (xg_select): Remove unused var.
17644
f0c77cd1
PE
17645 * image.c (four_corners_best): Mark locals as initialized.
17646 (gif_load): Initialize transparent_p to zero (Bug#8238).
17647 Mark another local as initialized.
ec6cf4c6 17648 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 17649
ce0ad53d 17650 * image.c (clear_image_cache): Now static.
d5d5a617 17651 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 17652 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
17653 (x_edge_detection): Remove unnecessary cast that
17654 gcc -Wbad-function-cast diagnoses.
2037898d 17655 (gif_load): Fix pointer signedness.
6ae141d6
PE
17656 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
17657 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 17658
33383987 176592011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 17660
d32df629
PE
17661 Improve quality of tests for time stamp overflow.
17662 For example, without this patch (encode-time 0 0 0 1 1
17663 1152921504606846976) returns the obviously-bogus value (-948597
17664 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
17665 reports time overflow. See
17666 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
17667 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
17668 * editfns.c: Include limits.h and intprops.h.
17669 (TIME_T_MIN, TIME_T_MAX): New macros.
17670 (time_overflow): Move earlier, to before first use.
17671 (hi_time, lo_time): New functions, for an accurate test for
17672 out-of-range times.
17673 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
17674 (Fget_internal_run_time): Don't assume time_t fits in int.
17675 (make_time): Use list2 instead of Fcons twice.
17676 (Fdecode_time): More accurate test for out-of-range times.
17677 (check_tm_member): New function.
17678 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
17679 (lisp_time_argument): Don't rely on undefined left-shift and
17680 right-shift behavior when checking for time stamp overflow.
8be6f318 17681
fe31d94c
PE
17682 * editfns.c (time_overflow): New function, refactoring common code.
17683 (Fformat_time_string, Fdecode_time, Fencode_time):
17684 (Fcurrent_time_string): Use it.
17685
8be6f318
PE
17686 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
17687 * dired.c (make_time): Move to ...
17688 * editfns.c (make_time): ... here.
17689 * systime.h: Note the move.
17690
09d9db2c 176912011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 17692
126bc0dc
YM
17693 * fringe.c (update_window_fringes): Remove unused variables.
17694
c47cbdfd
YM
17695 * unexmacosx.c (copy_data_segment): Also copy __got section.
17696 (Bug#8223)
17697
7ac80be9
EZ
176982011-03-12 Eli Zaretskii <eliz@gnu.org>
17699
c96bbc66 17700 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
17701 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
17702 Constify `char *' arguments and their references according to
17703 prototypes in tparam.h.
17704
ecb0f94d 17705 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 17706
7ac80be9
EZ
17707 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
17708 Adapt all references accordingly.
17709
17710 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
17711
ef1fd07e
TT
177122011-03-11 Tom Tromey <tromey@redhat.com>
17713
17714 * buffer.c (syms_of_buffer): Remove obsolete comment.
17715
7ef4b50c
EZ
177162011-03-11 Eli Zaretskii <eliz@gnu.org>
17717
17718 * termhooks.h (encode_terminal_code): Declare prototype.
17719
17720 * msdos.c (encode_terminal_code): Don't declare prototype.
17721
17722 * term.c (encode_terminal_code): Now external again, used by
17723 w32console.c and msdos.c.
17724
44f230aa
SM
17725 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
17726 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 17727
4b1ec863 177282011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 17729
1714f52b 17730 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 17731
4b1ec863
PE
17732 * fringe.c (update_window_fringes): Mark locals as initialized
17733 (Bug#8227).
17734 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 17735
524c7aa6
PE
17736 * alloc.c (mark_fringe_data): Move decl from here ...
17737 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
17738 to check its interface.
17739 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
17740
a5c0af81 17741 * fontset.c (free_realized_fontset): Now static.
7519b8cd 17742 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 17743 (fontset_font): Mark local as initialized.
a9a06e0b 17744 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 17745
b4716021
PE
17746 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
17747
811e9bac 17748 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 17749 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
17750 (x_own_selection, Fx_disown_selection_internal): Rename locals
17751 to avoid shadowing.
17752 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 17753
7e3ab302
PE
17754 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
17755 so that the caller can use some name other than gcpro1.
17756 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
17757 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
17758 (Fx_backspace_delete_keys_p):
17759 Use them to avoid shadowing, and rename vars to avoid shadowing.
17760 (x_decode_color, x_set_name, x_window): Now static.
6b437900 17761 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 17762 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
17763 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
17764 Remove unused locals.
7e3ab302
PE
17765 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
17766 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
17767 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
17768 macros.
f78faa98 17769
e2b13473
PE
17770 * xterm.h (x_mouse_leave): New decl.
17771
77f23912
PE
17772 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
17773 Remove unused functions.
cdf4ba58
PE
17774 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
17775 (x_calc_absolute_position): Now static.
7411c686 17776 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 17777 Don't declare local "event" unless it's used.
ed7bf3a5
PE
17778 (x_iconify_frame, x_free_frame_resources): Don't declare locals
17779 unless they are used.
38d0b34a
PE
17780 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
17781 (x_fatal_error_signal): Remove; not used.
a6067996
PE
17782 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
17783 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
17784 (x_error_catcher, x_connection_closed, x_error_handler):
17785 (x_error_quitter, xembed_send_message, x_iconify_frame):
17786 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 17787 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 17788 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 17789
44f230aa
SM
17790 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
17791 Rename or move locals to avoid shadowing.
6b463e58 17792 (tty_defined_color, merge_face_heights): Now static.
5967d051 17793 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
17794 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
17795 does not deduce is never used uninitialized.
73719eba
PE
17796 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
17797 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 17798
426994c3 17799 * terminal.c (store_terminal_param): Now static.
5489860b 17800
032f1620 17801 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 17802 (set_frame_menubar): Remove unused local.
d4323972 17803 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
17804 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
17805 since they might point to immutable storage.
281585b0
PE
17806 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
17807 since it's unused otherwise.
032f1620 17808
367c19e5 17809 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 17810 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
17811 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
17812 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 17813 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
17814 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
17815 does not deduce are never used uninitialized.
70739cbe 17816
07b48fa9
PE
17817 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
17818
8868a238 17819 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
17820 * window.c (window_loop, size_window):
17821 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 17822
7e5cf297 17823 * window.c (display_buffer): Now static.
d6550a9f
PE
17824 (size_window): Mark variables that gcc -Wuninitialized
17825 does not deduce are never used uninitialized.
a586633d
PE
17826 * window.h (check_all_windows): New decl, to forestall
17827 gcc -Wmissing-prototypes diagnostic.
5b555da1 17828 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 17829
f6095868
PE
17830 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
17831 shadowing.
17832 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
17833 Include <limits.h>.
17834 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
17835 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
17836 (load_charset_map): Mark variables that gcc -Wuninitialized
17837 does not deduce are never used uninitialized.
53df7c11 17838 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 17839
f38b440c
PE
17840 * coding.c (coding_set_source, coding_set_destination):
17841 Use "else { /* comment */ }" rather than "else /* comment */;"
17842 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
17843 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
17844 a block, when the outer 'i' will do.
17845 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
17846 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
17847 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
17848 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
17849 (Fdecode_sjis_char, Fdefine_coding_system_internal):
17850 Rename locals to avoid shadowing.
17851 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
17852 * coding.c (emacs_mule_char, encode_invocation_designation):
17853 Now static, since they're not used elsewhere.
413bb2db 17854 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 17855 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
17856 (decode_coding_emacs_mule): Mark variables that gcc
17857 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
17858 (detect_coding_iso_2022): Initialize a local variable that might
17859 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 17860 this initialization is needed. (Bug#8211)
5f58e762
PE
17861 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
17862 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
17863 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
17864 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
17865 Remove unused macros.
f38b440c 17866
232b38b9 17867 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 17868 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 17869 * character.c (string_count_byte8): Likewise.
232b38b9 17870
fb90da1b
PE
17871 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
17872 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
17873
fb93dbc2
PE
17874 * chartab.c (copy_sub_char_table): Now static, since it's not used
17875 elsewhere.
5c156ace
PE
17876 (sub_char_table_ref_and_range, char_table_ref_and_range):
17877 Rename locals to avoid shadowing.
bbcd0949 17878 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 17879
7d3b3862 17880 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 17881 (BIDI_BOB): Remove unused macro.
7d3b3862 17882
6be7d3da
PE
17883 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
17884 deduce are never used uninitialized.
c2ed9c8b 17885 * term.c (encode_terminal_code): Likewise.
6be7d3da 17886
75f8807f 17887 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 17888
50938595
PE
17889 * tparam.h: New file.
17890 * term.c, tparam.h: Include it.
17891 * deps.mk (term.o, tparam.o): Depend on tparam.h.
17892 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
17893 Move these decls to tparam.h, and make them agree with what
17894 is actually in tparam.c. The previous trick of using incompatible
17895 decls in different modules does not conform to the C standard.
17896 All callers of tparam changed to use tparam's actual API.
17897 * tparam.c (tparam1, tparam, tgoto):
17898 Use const pointers where appropriate.
17899
fbceeba2
PE
17900 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
17901 * cm.h (struct cm): Likewise.
17902 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
17903 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
17904 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
17905 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
17906 (turn_on_face, init_tty): Likewise.
17907 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 17908
7f3f1250
PE
17909 * term.c (term_mouse_position): Rename local to avoid shadowing.
17910
e6ca6543
PE
17911 * alloc.c (mark_ttys): Move decl from here ...
17912 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
17913
c40f8d15
AS
179142011-03-11 Andreas Schwab <schwab@linux-m68k.org>
17915
17916 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
17917
cfe0661d
JB
179182011-03-09 Juanma Barranquero <lekktu@gmail.com>
17919
17920 * search.c (compile_pattern_1): Remove argument regp, unused since
17921 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
17922 (compile_pattern): Don't pass it.
17923
0afb4571
J
179242011-03-08 Jan Djärv <jan.h.d@swipnet.se>
17925
17926 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
17927 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
17928 for ! HAVE_GTK3.
17929 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
17930
17931 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
17932
17933 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
17934 gdk_window_get_screen, gdk_window_get_geometry,
17935 gdk_x11_window_lookup_for_display and GDK_KEY_g.
17936 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
17937 (xg_get_pixbuf_from_pixmap): New function.
17938 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
17939 to Pixmap, take frame as parameter, remove GdkColormap parameter.
17940 Call xg_get_pixbuf_from_pixmap instead of
17941 gdk_pixbuf_get_from_drawable.
17942 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
17943 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
17944 (xg_check_special_colors): Use GtkStyleContext and its functions
17945 for HAVE_GTK3.
17946 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
17947 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
17948 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
17949 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
17950 Call gtk_widget_get_preferred_size.
0afb4571
J
17951 (xg_frame_resized): gdk_window_get_geometry only takes 5
17952 parameters.
44f230aa
SM
17953 (xg_win_to_widget, xg_event_is_for_menubar):
17954 Call gdk_x11_window_lookup_for_display.
0afb4571
J
17955 (xg_set_widget_bg): New function.
17956 (delete_cb): New function.
895009e1 17957 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 17958 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
17959 (xg_set_background_color): Call xg_set_widget_bg.
17960 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
17961 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
17962 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
17963 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
17964 if ! HAVE_GTK3.
17965 (update_frame_tool_bar): Call gtk_widget_hide.
17966 (xg_initialize): Use GDK_KEY_g.
17967
17968 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
17969 if ! HAVE_GTK3
17970 (x_session_initialize): Call gdk_x11_set_sm_client_id.
17971
17972 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
17973 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
17974 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
17975
1c2cc4ef
JB
179762011-03-08 Juanma Barranquero <lekktu@gmail.com>
17977
17978 * w32xfns.c (select_palette): Check success of RealizePalette against
17979 GDI_ERROR, not zero.
17980
33383987 17981See ChangeLog.11 for earlier changes.
aac0c6e3
MR
17982
17983;; Local Variables:
17984;; coding: utf-8
aac0c6e3
MR
17985;; End:
17986
2f097256 17987 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
17988
17989 This file is part of GNU Emacs.
17990
17991 GNU Emacs is free software: you can redistribute it and/or modify
17992 it under the terms of the GNU General Public License as published by
17993 the Free Software Foundation, either version 3 of the License, or
17994 (at your option) any later version.
17995
17996 GNU Emacs is distributed in the hope that it will be useful,
17997 but WITHOUT ANY WARRANTY; without even the implied warranty of
17998 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17999 GNU General Public License for more details.
18000
18001 You should have received a copy of the GNU General Public License
18002 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.