Auto-commit of loaddefs files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
56e2e794
MR
12011-11-23 Martin Rudalics <rudalics@gmx.at>
2
3 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4 making another buffer current. (Bug#10114)
5
b6e64c41
GM
62011-11-23 Glenn Morris <rgm@gnu.org>
7
8 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
9
6b21de18
CY
102011-11-23 Chong Yidong <cyd@gnu.org>
11
12 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
13 using it (Bug#5984).
14
b12cd789
EZ
152011-11-22 Eli Zaretskii <eliz@gnu.org>
16
17 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
18 and header-lines, as they don't have one computed for them.
19 (Bug#10098)
20
21 * .gdbinit (prow): Make displayed values more self-explaining.
22 Add row's hash code.
23
261b6fd4
LMI
242011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
25
26 * process.c (wait_reading_process_output): Fix asynchrounous
27 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 28 (wait_reading_process_output): Add comment and URL.
261b6fd4 29
e7cfd277
JD
302011-11-21 Jan Djärv <jan.h.d@swipnet.se>
31
32 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
33
a9b9b7f5
CY
342011-11-21 Chong Yidong <cyd@gnu.org>
35
36 * window.c (Fnext_window, Fprevious_window): Doc fix.
37
b0d15b4f
SM
382011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
39
40 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
41
fe7a3057
JB
422011-11-20 Juanma Barranquero <lekktu@gmail.com>
43
44 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
45
d2999b1a
MR
462011-11-20 Martin Rudalics <rudalics@gmx.at>
47
48 * window.c (Fset_window_combination_limit): Rename argument
49 STATUS to LIMIT.
50 (Vwindow_combination_limit): Remove "status" from doc-string.
51
d5ff9cd0
AS
522011-11-20 Andreas Schwab <schwab@linux-m68k.org>
53
54 * m/ibms390.h: Remove.
55 * m/ibms390x.h: Don't include "ibms390.h".
56
a5bb9bd3
SM
572011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
58
59 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
60 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
61
cd1181db
JB
622011-11-20 Juanma Barranquero <lekktu@gmail.com>
63
64 * casetab.c (Fset_case_table):
65 * charset.c (Fcharset_after): Fix typos.
66
615a3b8d 672011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 68
17e845af
PE
69 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
70 Otherwise, valgrind does not work on some platforms.
71 Problem reported by Andreas Schwab in
6a0bf43d
PE
72 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
73 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
74 is set, removing the need for VIRT_ADDRESS_VARIES.
75 (PURE_P): Use a more-efficient implementation that needs just one
76 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
77 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
78 to 4 (xorl, subq, cmpq, setbe).
79 * alloc.c (pure): Always extern now, since that's the
80 VIRT_ADDR_VARIES behavior.
81 (PURE_POINTER_P): Use a single comparison, not two, for
82 consistency with the new puresize.h.
83 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
84 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
85 Remove VIRT_ADDR_VARIES no longer needed.
86
f8fe6f96
EZ
872011-11-19 Eli Zaretskii <eliz@gnu.org>
88
89 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
90 (erase_phys_cursor, update_window_cursor, show_mouse_face)
91 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
92 behave as if the cursor position were at the window margin.
93
94 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
95 and the cursor position is out of bounds, behave as if the cursor
96 position were at the window margin. (Bug#10075)
97
df05a53c
CY
982011-11-18 Chong Yidong <cyd@gnu.org>
99
100 * window.c (Fwindow_combination_limit): Make first argument
101 non-optional, since it is meaningless for live windows like the
102 selected window.
103
2071918e
DA
1042011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
105
106 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
107
b50a28de
SM
1082011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
109
110 * intervals.c: Fix grafting over the whole buffer (bug#10071).
111 (graft_intervals_into_buffer): Simplify.
112
015137db
EZ
1132011-11-18 Eli Zaretskii <eliz@gnu.org>
114
115 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
116 hash values of the two rows.
117 (copy_row_except_pointers): Preserve the used[] arrays and the
118 hash values of the two rows. (Bug#10035)
68c95424 119 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
120
121 * xdisp.c (row_hash): New function, body extracted from
122 compute_line_metrics.
123 (compute_line_metrics): Call row_hash, instead of computing the
124 hash code inline.
125
126 * dispnew.c (verify_row_hash): Call row_hash for computing the
127 hash code of a row, instead of duplicating code from xdisp.c.
128
129 * dispextern.h (row_hash): Add prototype.
130
a2addb04
TH
1312011-11-18 Tassilo Horn <tassilo@member.fsf.org>
132
133 * frame.c (delete_frame): Don't delete the terminal when the last
134 X frame is closed if emacs is built with GTK toolkit.
135
df85d315
JB
1362011-11-17 Juanma Barranquero <lekktu@gmail.com>
137
138 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
139
a0c2d0ae
MR
1402011-11-17 Martin Rudalics <rudalics@gmx.at>
141
142 * window.c (Vwindow_splits): Rename to
143 Vwindow_combination_resize. Suggested by Juri Linkov.
144 (Fsplit_window_internal): Use Vwindow_combination_resize instead
145 of Vwindow_splits.
146
58179cce
JB
1472011-11-16 Juanma Barranquero <lekktu@gmail.com>
148
7877f373
JB
149 * nsfns.m (Fns_font_name):
150 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 151
b6f67890
MR
1522011-11-16 Martin Rudalics <rudalics@gmx.at>
153
154 * window.h (window): Rename slot "nest" to "combination_limit".
155 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
156 (Fset_window_nest): Rename to Fset_window_combination_limit.
157 (Vwindow_nest): Rename to Vwindow_combination_limit.
158 (recombine_windows, make_parent_window, make_window)
159 (Fsplit_window_internal, saved_window)
160 (Fset_window_configuration, save_window_save): Rename all
161 occurrences of window_nest to window_combination_limit.
162
c7015153
JB
1632011-11-15 Juanma Barranquero <lekktu@gmail.com>
164
165 * image.c (imagemagick_load_image): Fix typo.
166
322ad6ec
EZ
1672011-11-14 Eli Zaretskii <eliz@gnu.org>
168
169 * xdisp.c (display_line): Move the call to
170 highlight_trailing_whitespace before the call to
171 compute_line_metrics, since the latter needs to see the final
172 faces of all the glyphs to compute ROW's hash value. Fixes
173 assertion violations in row_equal_p. (Bug#10035)
174
f067b8ec
JB
1752011-11-14 Juanma Barranquero <lekktu@gmail.com>
176
177 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
178 just return (bug#10044).
179
1e5b2111
EZ
1802011-11-12 Eli Zaretskii <eliz@gnu.org>
181
7ef3cbd5
EZ
182 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
183 with user-defined heap size. Bump the default size of the temacs
184 heap to 27MB, to avoid memory warning when running temacs.
185 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
186
1e5b2111
EZ
187 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
188 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
189 (verify_row_hash) [XASSERTS]: New function.
190 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
191 that the hash value of glyph rows is correct.
1e5b2111 192
89d61221
MR
1932011-11-12 Martin Rudalics <rudalics@gmx.at>
194
195 * window.h (window): Remove splits slot.
196 * window.c (Fwindow_splits, Fset_window_splits): Remove.
197 (Fdelete_other_windows_internal, make_parent_window)
198 (make_window, Fsplit_window_internal, Fdelete_window_internal)
199 (Fset_window_configuration, save_window_save): Don't deal with
200 split status of windows.
201 (saved_window): Remove splits slot.
202 (Vwindow_splits): Rewrite doc-string.
203
97f18cc8
JD
2042011-11-11 Jan Djärv <jan.h.d@swipnet.se>
205
206 * xfns.c (unwind_create_frame):
207 * nsfns.m (unwind_create_frame):
208 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
209 Vframe_list (Bug#9999).
210
22a648b4
DA
2112011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
212
0b381c7e 213 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 214
659afede
KH
2152011-11-11 Kenichi Handa <handa@m17n.org>
216
217 * callproc.c (Fcall_process): Set the member dst_multibyte of
218 process_coding.
219
9ac0394b
KH
2202011-11-11 Johan Bockgård <bojohan@gnu.org>
221
222 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
223 avoid a crash (bug#9496).
224
2fbdc249
CY
2252011-11-09 Chong Yidong <cyd@gnu.org>
226
227 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
228 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
229
ac6b1f81
PE
2302011-11-08 Paul Eggert <eggert@cs.ucla.edu>
231
232 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
233
09db192c
PE
2342011-11-08 Paul Eggert <eggert@cs.ucla.edu>
235
236 Avoid some portability problems by eschewing 'extern inline' functions.
237 The trivial performance wins aren't worth the portability hassles; see
238 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
239 et seq.
240 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
241 (window_box_width, window_box_left, window_box_left_offset)
242 (window_box_right, window_box_right_offset): Undo previous change,
243 by removing the "extern"s.
244 * intervals.c (adjust_intervals_for_insertion)
245 (adjust_intervals_for_deletion): Undo previous change,
246 making these static again.
247 (offset_intervals, temp_set_point_both, temp_set_point)
248 (copy_intervals_to_string): No longer inline.
249 * xdisp.c (window_text_bottom_y, window_box_width)
250 (window_box_height, window_box_left_offset)
251 (window_box_right_offset, window_box_left, window_box_right)
252 (window_box): No longer inline.
253
105216ed
CY
2542011-11-08 Chong Yidong <cyd@gnu.org>
255
256 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
257 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
258 an error if not a live window.
259 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
260 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
261
ae9e237f
JB
2622011-11-07 Juanma Barranquero <lekktu@gmail.com>
263
264 * lisp.h (syms_of_abbrev): Remove declaration.
265 Reported by CHENG Gao <chenggao@royau.me>.
266
c7aa8333
EZ
2672011-11-07 Eli Zaretskii <eliz@gnu.org>
268
269 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
270 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
271 of temacs in GUI mode.
272
be7f5545
MR
2732011-11-07 Martin Rudalics <rudalics@gmx.at>
274
275 * window.h: Declare delete_all_child_windows instead of
276 delete_all_subwindows.
277 * window.c (Fwindow_nest, Fset_window_nest)
278 (Fset_window_new_total, Fset_window_new_normal)
279 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
280 (delete_all_subwindows): Rename to delete_all_child_windows.
281 (Fdelete_other_windows_internal, Fset_window_configuration):
282 Call delete_all_child_windows instead of delete_all_subwindows.
283 * frame.c (delete_frame): Call delete_all_child_windows instead
284 of delete_all_subwindows.
285
ca78dc43
PE
2862011-11-07 Paul Eggert <eggert@cs.ucla.edu>
287
288 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
289 This is also needed for porting to any host where GC_MARK_STACK is
290 not GC_MAKE_GCPROS_NOOPS.
291 (which_symbols): Use it.
292
a0241d01
KH
2932011-11-07 Kenichi Handa <handa@m17n.org>
294
295 * coding.c (coding_set_destination): Check coding->src_pos only
296 when coding->src_object is a buffer (bug#9910).
297
298 * process.c (send_process): Set the member src_multibyte of coding
299 to 0 (bug#9911) when sending a unibyte text.
300
301 * callproc.c (Fcall_process): Set the member src_multibyte of
302 process_coding to 0 (bug#9912).
303
a64bfdfa 3042011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
305
306 * xmenu.c (cleanup_widget_value_tree): New function.
307 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
308 calling free_menubar_widget_value_tree directly (Bug#9830).
309
cb41b32a
PE
3102011-11-06 Paul Eggert <eggert@cs.ucla.edu>
311
312 Fix some portability problems with 'inline'.
313 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
314 (window_box_width, window_box_left, window_box_left_offset)
315 (window_box_right, window_box_right_offset): Declare extern.
316 Otherwise, these inline functions do not conform to C99 and
317 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
318 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
319 * intervals.c (adjust_intervals_for_insertion)
320 (adjust_intervals_for_deletion): Now extern, because otherwise the
321 extern inline functions 'offset_intervals' couldn't refer to it.
322 (static_offset_intervals): Remove.
323 (offset_intervals): Rewrite using the old contents of
324 static_offset_intervals. The old version didn't conform to C99
325 because an extern inline function contained a reference to an
326 identifier with static linkage.
327
b7041366
AS
3282011-11-06 Andreas Schwab <schwab@linux-m68k.org>
329
330 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
331 GC.
332
88a37c4d
EZ
3332011-11-06 Eli Zaretskii <eliz@gnu.org>
334
335 * xdisp.c (init_iterator, reseat_to_string): Don't set the
336 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
337 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
338 return Qleft_to_right.
339
49745b39
CY
3402011-11-06 Chong Yidong <cyd@gnu.org>
341
342 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
343 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
344 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
345 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
346 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
347 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
348 (Fwindow_vscroll): Doc fix.
349 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
350 argument, since it makes no sense to pass a live window and for
351 consistency with window-child.
352
1f05cd82
CS
3532011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
354
355 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
356 support MSVC.
357
22610910
JR
3582011-11-05 Jason Rumney <jasonr@gnu.org>
359
360 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
361 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
362 fonts (Bug#6029).
363 (add_font_entity_to_list): Fix logic errors in mixed boolean and
364 bitwise arithmetic preventing use of unicode-sip and non-truetype
365 opentype fonts.
366
a06776b2
EZ
3672011-11-05 Eli Zaretskii <eliz@gnu.org>
368
3ad924ba
EZ
369 * s/ms-w32.h (fstat, stat, utime): Move redirections to
370 "emacs"-only part.
371
a06776b2
EZ
372 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
373 initialization code to keep similarity to xfns.c after changes
374 from 2011-11-05.
375
c9e7db78
JD
3762011-11-05 Jan Djärv <jan.h.d@swipnet.se>
377
a97f8f3f
JD
378 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
379 (unwind_create_frame): New function (Bug#9943).
380 (Fx_create_frame): Restructure code to be more similar to the one in
381 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
382 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
383 Move terminal->reference_count++ just before making the frame official
384 (Bug#9943).
385
386 * nsterm.m (x_free_frame_resources): New function.
387 (x_destroy_window): Move code to x_free_frame_resources.
388
c9e7db78
JD
389 * xfns.c (unwind_create_frame): Fix comment.
390 (Fx_create_frame, x_create_tip_frame): Move
391 terminal->reference_count++ just before making the frame
392 official. Move initialization of image_cache_refcount and
393 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
394
a6fc3b5c
EZ
3952011-11-05 Eli Zaretskii <eliz@gnu.org>
396
397 Support MSVC build with newer versions of Visual Studio.
398 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
399 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
400 nt/gmake.defs.
401
402 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
403 which are not supported by MSVC.
404 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
405 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
406 bitfields.
407 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
408 types in bitfields.
409 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
410
411 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
412
58179cce 4132011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
414
415 Support MSVC build with newer versions of Visual Studio.
416 * w32.c: Don't include w32api.h for MSVC.
417 (init_environment) [_MSC_VER]: Call sys_access, not _access.
418
419 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
420 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
421 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
422 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
423 e_* cousins.
424 (alloca) [_MSC_VER]: Define to _alloca.
425
426 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
427
428 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
429
a58c13ed
EZ
4302011-11-04 Eli Zaretskii <eliz@gnu.org>
431
432 * xdisp.c (note_mouse_highlight): If either of
433 previous/next-single-property-change returns nil, treat that as
434 the beginning or the end of the buffer. (Bug#9955)
435
fe0b6370
JD
4362011-11-04 Jan Djärv <jan.h.d@swipnet.se>
437
a58c13ed 438 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
439 label is not null (Bug#9951).
440 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
441 may be NULL.
442
89bd5ee1
EZ
4432011-11-04 Eli Zaretskii <eliz@gnu.org>
444
445 * window.c (Fwindow_body_size): Mention in the doc string that the
446 return value is in frame's canonical units. (Bug#9949)
447
84c3edb9
EZ
4482011-11-03 Eli Zaretskii <eliz@gnu.org>
449
4e2fb5c7
EZ
450 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
451
84c3edb9 452 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 453 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 454 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 455
bc17a887
EZ
4562011-11-01 Eli Zaretskii <eliz@gnu.org>
457
458 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
459 Don't stop backward scan on the continuation glyph, even though
460 its CHARPOS is positive.
26b46e51
EZ
461 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
462 cover_string to disp_string.
bc17a887 463
4ee88440
MR
4642011-11-01 Martin Rudalics <rudalics@gmx.at>
465
466 * window.c (temp_output_buffer_show): Don't use
467 Vtemp_buffer_show_specifiers.
468 (Vtemp_buffer_show_specifiers): Remove unused variable.
469
c2ff3c02
EZ
4702011-10-30 Eli Zaretskii <eliz@gnu.org>
471
472 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
473 past the beginning of the current glyph matrix.
474
58179cce 4752011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
476
477 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
478 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
479 HAVE_GTK3 (Bug#9869).
b77a6a7f 480
3b574623
JD
481 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
482 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
483
b77a6a7f
JD
484 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
485
486 * xterm.c: Declare x_handle_net_wm_state to return int.
487 (handle_one_xevent): Check if we are iconified but don't have
488 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
489 (get_current_wm_state): Return non-zero if not hidden,
490 check for _NET_WM_STATE_HIDDEN (Bug#9893).
491 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
492 (x_handle_net_wm_state): Return what get_current_wm_state returns.
493 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
494
196e41e4
PE
4952011-10-29 Paul Eggert <eggert@cs.ucla.edu>
496
497 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
498 so that this new function doesn't get optimized away by a
499 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
500
021f2e1a
AS
5012011-10-29 Andreas Schwab <schwab@linux-m68k.org>
502
503 * frame.h (MOUSE_HL_INFO): Remove excess parens.
504
8b058d44
EZ
5052011-10-29 Eli Zaretskii <eliz@gnu.org>
506
507 Fix the `xbytecode' command.
508 * .gdbinit (xprintbytestr): New command.
b50a28de 509 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
510 (xbytecode): Print the byte-code string as well.
511
4452fb80
EZ
5122011-10-29 Kim Storm <storm@cua.dk>
513
8b058d44
EZ
514 * alloc.c (which_symbols): New function.
515
21b72067
AS
5162011-10-29 Andreas Schwab <schwab@linux-m68k.org>
517
518 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
519 line. (Bug#9903)
520
83ed7b5c
GM
5212011-10-29 Glenn Morris <rgm@gnu.org>
522
523 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
524 Not clear what it was for, and it causes various bugs. (Bug#9839)
525
5a7a728b
EZ
5262011-10-28 Eli Zaretskii <eliz@gnu.org>
527
528 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
529 possible random value that matches one of those tested as
530 condition to clear the mouse face.
531
d3d0842f
CY
5322011-10-28 Chong Yidong <cyd@gnu.org>
533
534 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
535
31b39d13
DN
5362011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
537
538 * window.c (make_window): Initialize phys_cursor_on_p.
539
9aba6043
SM
5402011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
541
542 * lisp.h (struct Lisp_Symbol): Update comments.
543
c20992f4
JB
5442011-10-28 Juanma Barranquero <lekktu@gmail.com>
545
546 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
547
db4f02f2
EZ
5482011-10-28 Eli Zaretskii <eliz@gnu.org>
549
550 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
551 <oslsachem@gmail.com> for helping to debug this.
552
553 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
554 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
555 (g_b_init_get_glyph_outline_w): New static variables.
556 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
557 (GetGlyphOutlineW_Proc): New typedefs.
558 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
559 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
560 New functions.
561 (w32font_open_internal, compute_metrics):
562 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
563 instead of calling the "wide" APIs directly.
564
565 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
566
567 * w32.h (syms_of_w32font): Add prototype.
568
87e68db4
JB
5692011-10-27 Juanma Barranquero <lekktu@gmail.com>
570
571 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
572 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
573 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
574 (Fmove_to_window_line): Doc fix.
575
435c1d67
CY
5762011-10-27 Chong Yidong <cyd@gnu.org>
577
578 * process.c (make_process): Set gnutls_state to NULL.
579
580 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
581 non-NULL, regardless of GNUTLS_INITSTAGE.
582 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
583 an error. Set process slots as soon as we allocate them.
584
585 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
586
9c6c6f49
CY
5872011-10-27 Chong Yidong <cyd@gnu.org>
588
9aba6043
SM
589 * gnutls.c (emacs_gnutls_deinit): New function.
590 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
591 (Fgnutls_deinit, Fgnutls_boot): Use it.
592
593 * process.c (make_process): Initialize GnuTLS credentials to NULL.
594 (deactivate_process): Call emacs_gnutls_deinit.
595
657d08d3
JB
5962011-10-27 Juanma Barranquero <lekktu@gmail.com>
597
598 * image.c (x_create_x_image_and_pixmap):
599 * w32.c (sys_rename, w32_delayed_load):
600 * w32font.c (fill_in_logfont):
601 * w32reg.c (x_get_string_resource): Silence compiler warnings.
602
5430d399
JB
6032011-10-26 Juanma Barranquero <lekktu@gmail.com>
604
605 * w32fns.c (w32_default_color_map): New function,
606 extracted from Fw32_default_color_map.
a7ef684b 607 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 608
fe0055fa
PE
6092011-10-25 Paul Eggert <eggert@cs.ucla.edu>
610
611 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
612
e6346438
SM
6132011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
614
615 * keyboard.c (test_undefined): New function (bug#9751).
616 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
617
e112cc37
ET
6182011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
619
620 * sysdep.c (init_sys_modes): Fix the check for the controlling
621 terminal (Bug#6649).
622
7b5d6677
EZ
6232011-10-20 Eli Zaretskii <eliz@gnu.org>
624
625 * dispextern.h (struct bidi_it): New member next_en_type.
626
627 * bidi.c (bidi_line_init): Initialize the next_en_type member.
628 (bidi_resolve_explicit_1): When next_en_pos is valid for the
629 current character, check also for next_en_type being WEAK_EN.
630 (bidi_resolve_weak): Don't enter the expensive loop if the current
631 position is before next_en_pos. Record the bidi type of the first
632 non-ET, non-BN character we find, in addition to its position.
633 (bidi_level_of_next_char): Invalidate next_en_type when
634 next_en_pos is over-stepped.
635
7da0b018
PE
6362011-10-20 Paul Eggert <eggert@cs.ucla.edu>
637
638 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
639 * editfns.c: Rewrite current-time-zone so that it invokes
640 the equivalent of (format-time-string "%Z") to get the time zone name.
641 This fixes a bug when the time zone name contains characters that
642 need converting from the system time locale to Emacs internal format.
643 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
644 that patch fixed format-time-string to do the conversion, but
645 I forgot to fix current-time-zone.
646 (format_time_string): New function, containing most of
647 what Fformat_time_string used to contain.
648 (Fformat_time_string): Rewrite in terms of format_time_string.
649 This doesn't change this function's behavior.
650 (current-time-zone): Rewrite to use format_time_string.
651 This fixes the bug reported by Michael Schierl in
652 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
653 Jason Rumney's 2007-06-07 change worked around this bug, but
654 didn't fix it.
655 * systime.h (tzname, timezone): Remove no-longer-used declarations.
656
8547b010
EZ
6572011-10-19 Eli Zaretskii <eliz@gnu.org>
658
659 * xdisp.c (start_display): If the character at POS is displayed
660 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
661 (try_window_reusing_current_matrix): If a line ends in a display
662 vector or the next line starts in a display vector, continue
663 redrawing the window even though the character position of
664 start_row was reached.
8547b010
EZ
665 (Bug#9771, part 2)
666
4e948d15
CY
6672011-10-18 Chong Yidong <cyd@gnu.org>
668
669 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
670 with nobreak-char-display too.
671
4787455f
EZ
6722011-10-18 Eli Zaretskii <eliz@gnu.org>
673
674 Fix part 3 of bug#9771.
675 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
676 (bidi_resolve_neutral): Don't enter the expensive loop looking for
677 non-neutral characters if the current character is a paragraph
678 separator (a.k.a. Newline). This avoids running the same
679 expensive loop twice, once when we consume the preceding newline
680 and the other time when the line actually needs to be displayed.
681 Avoid the loop when we see neutrals on the base embedding level
682 following a character whose directionality is the same as the
683 paragraph's. This avoids running the expensive loop when a line
684 ends in a long sequence of neutrals, like control characters.
685 Add assertion against STRONG_AL type. Slightly rearrange code
686 that determines the type of a neutral given the first non-neutral
687 that follows it.
688 (bidi_level_of_next_char): Set next_en_pos to zero when
689 invalidating its info.
690
2c91f553
EZ
6912011-10-17 Eli Zaretskii <eliz@gnu.org>
692
693 * xdisp.c (push_display_prop): Determine whether to record string
694 or buffer position by IT->string, not by IT->method. Allow
695 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
696 (move_it_vertically_backward): Don't look for character position
697 immediately after the newline when in a continuation line.
698 (Bug#9771, part 1)
2c91f553 699
c7b08b0d
MR
7002011-10-15 Martin Rudalics <rudalics@gmx.at>
701
702 * window.c (coordinates_in_window): Rewrite and delabelize
703 vertical border check. (Bug#5357) (Bug#9618)
704
6b02f655
SM
7052011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
706
707 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
708 errors in XSetWindowBorder (bug#9310).
709
81d40c92
DA
7102011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
711
712 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
713 avoid crash when xmalloc overrun checking is enabled.
714
d4172c3b
EZ
7152011-10-13 Eli Zaretskii <eliz@gnu.org>
716
717 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
718 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
719 cursor motion with <left> and <right> arrow keys.
720
721 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
722 some callers set that themselves.
723
b00eea75
EZ
7242011-10-12 Eli Zaretskii <eliz@gnu.org>
725
726 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
727 display string and the previous row comes from the same string and
728 is empty. (Bug#9739) (Bug#9738)
729
8fe012c4
SM
7302011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
731
732 * doc.c (get_doc_string): Encode file name (bug#9735).
733
0074aef2
EZ
7342011-10-12 Eli Zaretskii <eliz@gnu.org>
735
79beb178
EZ
736 * bidi.c (bidi_level_of_next_char):
737 * xdisp.c (get_visually_first_element): Remove old incorrect
738 comments regarding the Unicode Line Separator character.
739
0074aef2
EZ
740 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
741
6e4b3fbe
DA
7422011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
743
744 * alloc.c (Fgc_status): Do not access beyond zombies array
745 boundary if nzombies > MAX_ZOMBIES.
746 * alloc.c (dump_zombies): Add missing format specifier.
747
0324f3af
PE
7482011-10-12 Paul Eggert <eggert@cs.ucla.edu>
749
b5525cac
PE
750 * xdisp.c (set_cursor_from_row): Simplify conditionals,
751 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
752
0324f3af
PE
753 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
754 Some packages use them to denote characters with modifiers.
755
e9b5f888
AS
7562011-10-11 Andreas Schwab <schwab@linux-m68k.org>
757
758 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
759 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
760 matching a pp-number. Rename parameter var to var1.
761
127827c0
SM
7622011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
763
764 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
765
c8fd3bd0
GM
7662011-10-08 Glenn Morris <rgm@gnu.org>
767
768 * callint.c (Fcall_interactively): Give a more explicit error for the
769 'c' case with a non-character input. (Bug#8479)
770
352ec8ff
EZ
7712011-10-08 Eli Zaretskii <eliz@gnu.org>
772
03669ccb
EZ
773 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
774 lines.
7061c986
EZ
775 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
776 lines that are hscrolled on the left.
03669ccb 777
352ec8ff
EZ
778 * dispnew.c (buffer_posn_from_coords): Account for a possible
779 presence of header-line. (Bug#4426)
780
a66cfb1c
SM
7812011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
782
6b02f655
SM
783 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
784 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 785
7c5ee88e
PE
7862011-10-07 Paul Eggert <eggert@cs.ucla.edu>
787
788 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
789 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
790 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
791 this makes Emacs dump core during garbage collection on rare
792 occasions. sizeof is obviously inferior to offsetof here, so
793 stick with offsetof.
794 (GC_POINTER_ALIGNMENT): New macro.
795 (mark_memory): Omit 3rd (offset) arg; caller changed.
796 Don't assume EMACS_INT alignment is the same as pointer alignment.
797
df1bbe5b
SM
7982011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
799
800 * keyboard.c (read_key_sequence_remapped): New var.
801 (read_key_sequence): Compute remapping in the right buffer.
802 (command_loop_1): Use read_key_sequence's remapping directly.
803
51553db6
SM
8042011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
805
32c1fffd
SM
806 * dired.c (file_name_completion): Don't expand file name.
807 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
808 before checking file name handler.
809
51553db6
SM
810 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
811 they've been requested explicitly (bug#9591).
812
b6bd1599 8132011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
814
815 * keymap.c (Fsingle_key_description): Use make_specified_string
816 instead of build_string to build string from push_key_description.
817 (Bug#5193)
818
f701dc2a
PE
8192011-09-30 Paul Eggert <eggert@cs.ucla.edu>
820
4222c55d
PE
821 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
822 This fixes a Y2038 bug on 64-bit hosts.
823 * buffer.c (reset_buffer):
824 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
825 (Fclear_buffer_auto_save_failure):
826 Use 0, not -1, to represent an unset failure time, since time_t
827 might not be signed.
828
f701dc2a
PE
829 Remove dependency on glibc malloc internals.
830 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
831 Move back here from lisp.h, but with their new implementations.
832 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
833 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
834 * charset.c (charset_table_init): New static var.
835 (syms_of_charset): Use it instead of xmalloc. This removes a
836 dependency on glibc malloc internals. See Eli Zaretskii's comment in
837 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
838 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
839 Move back to alloc.c.
840 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
841 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
842
9ceebf39
JD
8432011-09-30 Jan Djärv <jan.h.d@swipnet.se>
844
845 * nsterm.m (windowDidResize): Call x_set_window_size only when
846 ns_in_resize is true. Otherwise set pixelwidth/height and
847 call change_frame_size (Bug#9628).
848
cb993c58
PE
8492011-09-30 Paul Eggert <eggert@cs.ucla.edu>
850
3930c88b
PE
851 Port --enable-checking=all to Fedora 14 x86-64.
852 * charset.c (syms_of_charset): Also account for glibc malloc's
853 internal overhead when calculating the initial malloc maximum.
854
cb993c58
PE
855 Port --enable-checking=all to Fedora 14 x86.
856 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
857 Move to lisp.h.
858 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
859 (overrun_check_realloc, overrun_check_free):
860 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
861 That way, xmalloc returns a properly-aligned pointer even if
862 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
863 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
864 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
865 into account when calculating the initial malloc maximum.
866 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
867 Move here from alloc.c, so that charset.c can use it too.
868 Properly align; the old code wasn't right for common 32-bit hosts
869 when configured with --enable-checking=all.
870 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
871 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
872
31bed486
EZ
8732011-09-29 Eli Zaretskii <eliz@gnu.org>
874
04c70788 875 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
876 use EDOM.
877
fbcaa2f3
EZ
8782011-09-28 Eli Zaretskii <eliz@gnu.org>
879
880 * xdisp.c (compute_display_string_end): If there's no display
881 string at CHARPOS, return -1.
882
883 * bidi.c (bidi_fetch_char): When compute_display_string_end
884 returns a negative value, treat the character as a normal
885 character not covered by a display string. (Bug#9624)
886
a239d4e9
JB
8872011-09-28 Juanma Barranquero <lekktu@gmail.com>
888
889 * lread.c (Fread_from_string): Fix typo in docstring.
890
88652fd5
EZ
8912011-09-27 Eli Zaretskii <eliz@gnu.org>
892
893 * xdisp.c (handle_invisible_prop): If invisible text ends on a
894 newline, reseat the iterator instead of bidi-iterating there one
895 character at a time. (Bug#9610)
32c1fffd
SM
896 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
897 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 898
ed497dd4
AS
8992011-09-27 Andreas Schwab <schwab@linux-m68k.org>
900
901 * lread.c (readevalloop): Use correct code for NBSP.
902 (read1): Likewise. (Bug#9608)
903
b2bf61aa
MA
9042011-09-25 Michael Albinus <michael.albinus@gmx.de>
905
906 * dbusbind.c (Fdbus_register_signal): When service is not
907 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
908
32bbb17c
GM
9092011-09-25 Glenn Morris <rgm@gnu.org>
910
911 * buffer.c (truncate-lines): Doc fix.
912
94e0933e
CY
9132011-09-24 Chong Yidong <cyd@stupidchicken.com>
914
915 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
916 (Fset_window_next_buffers): Doc fix.
917
cddde921
GM
9182011-09-24 Glenn Morris <rgm@gnu.org>
919
920 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
921
1260aef1
PE
9222011-09-24 Paul Eggert <eggert@cs.ucla.edu>
923
25b4bfa0
PE
924 Fix minor problems found by static checking.
925 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
926 * indent.c (Fvertical_motion): Fix == vs = typo.
927
e3cbd34b
EZ
9282011-09-24 Eli Zaretskii <eliz@gnu.org>
929
a66cfb1c
SM
930 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
931 Default value is now t. Doc fix.
6bf7006f 932
e3cbd34b 933 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 934 logic when moving up, not only when moving down. Fix the
e3cbd34b 935 confusing name and values of the it_overshoot_expected variable;
32c1fffd 936 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
937
938 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
939 CHARPOS is covered by a display string which includes newlines.
940 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
941 is covered by a display string with embedded newlines.
942
a3de0cbd
MA
9432011-09-24 Michael Albinus <michael.albinus@gmx.de>
944
945 * dbusbind.c (Fdbus_register_signal): Add match rule to
946 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
947 (Fdbus_register_method, Vdbus_registered_objects_table):
948 Fix docstring.
a3de0cbd 949
b260039d
JM
9502011-09-24 Jim Meyering <meyering@redhat.com>
951
32c1fffd 952 do not ignore write error for any output size
b260039d
JM
953 The previous change was incomplete.
954 While it makes emacs --batch detect the vast majority of stdout
955 write failures, errors were still ignored whenever the output size is
956 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
957 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
958 && echo FAIL: ignored write error
959 FAIL: ignored write error
960 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
961 && echo FAIL: ignored write error
962 FAIL: ignored write error
963 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
964
8eca8a7c
AS
9652011-09-23 Andreas Schwab <schwab@linux-m68k.org>
966
967 * emacs.c (Fkill_emacs): In noninteractive mode exit
968 non-successfully if a write error occurred on stdout. (Bug#9574)
969
3341db62
EZ
9702011-09-21 Eli Zaretskii <eliz@gnu.org>
971
972 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
973 the xassert test.
974
975 * dispextern.h (struct it): Update the comment documenting what
976 can it->OBJECT be.
977
8c203dbf
EZ
9782011-09-20 Eli Zaretskii <eliz@gnu.org>
979
980 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
981 a display string, extend search for cursor position to end of row.
982 (find_row_edges): If the row ends in a newline from a display
983 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
984 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
985 (Fcurrent_bidi_paragraph_direction): Fix search for previous
986 non-empty line. Fixes confusing cursor motion with arrow keys at
987 the beginning of a line that starts with whitespace.
8c203dbf 988
a4824228
LMI
9892011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
990
991 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
992 (bug#9493).
993
33ed493b
CY
9942011-09-18 Chong Yidong <cyd@stupidchicken.com>
995
996 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
997 boolean (Bug#9154).
998
56cd55c8
EZ
9992011-09-18 Eli Zaretskii <eliz@gnu.org>
1000
1001 * xdisp.c (display_line): Record maximum and minimum buffer
1002 positions even if no glyphs were produced (e.g., by a zero-width
1003 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1004 buffer positions that will be removed from the glyph row because
1005 they don't fit.
c02dcedf
EZ
1006 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1007 column is beyond frame width: don't subtract 1 "pixel" when
1008 computing width of the stretch.
3e62b7e0
EZ
1009 (reseat_at_next_visible_line_start): Undo the change made on
1010 2011-09-17 that saved paragraph information and restored it after
1011 the call to `reseat'. (Bug#9545)
56cd55c8 1012
5ed99d36 10132011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1014
1015 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1016 and turn window cursor on if cleared (Bug#9415).
1017
5ed99d36 10182011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1019
1020 * search.c (boyer_moore): Take unibyte characters from pattern
1021 literally. (Bug#9458)
1022
9bade7b2
EZ
10232011-09-18 Eli Zaretskii <eliz@gnu.org>
1024
1025 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1026
e5e9d610
PE
10272011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1028
87e4427a
PE
1029 Fix minor problem found by static checking.
1030 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1031 initialized, to pacify gcc -Wuninitialized.
1032
e5e9d610
PE
1033 * fileio.c: Report proper errno when syscall falls.
1034 (Finsert_file_contents): Save and restore errno,
1035 so that report_file_error outputs the correct diagnostic.
1036 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1037
a1674f0b
EZ
10382011-09-18 Eli Zaretskii <eliz@gnu.org>
1039
1040 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1041
fbfb6dd4
EZ
10422011-09-17 Eli Zaretskii <eliz@gnu.org>
1043
1044 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1045 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1046
bb187662
EZ
10472011-09-17 Eli Zaretskii <eliz@gnu.org>
1048
1137e8b8 1049 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1050 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1051
1052 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1053 (bidi_find_paragraph_start): Search back for paragraph beginning
1054 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1055 (bidi_move_to_visually_next): Only trigger paragraph-related
1056 computations when the last character is a newline or at EOB, not
1057 just any NEUTRAL_B. (Bug#9470)
1058
bb187662
EZ
1059 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1060 truncated lines if point is covered by a display string. (Bug#9524)
1061
2e621251
PE
10622011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1063
1064 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1065 (cons_to_x_long): New function.
1066 (lisp_data_to_selection_data): Use it. Correct the test for
1067 short-versus-long data; it was negated. Break out of vector
1068 loop, for efficiency, when a long datum is discovered.
1069
91a15bc6
SM
10702011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1071
1072 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1073
b41c3a35
EZ
10742011-09-16 Eli Zaretskii <eliz@gnu.org>
1075
1076 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1077 GCC PR/17406) by declaring this function with external scope.
1078
7812ba2d
PE
10792011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1082 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1083
cf7edc2a
AS
10842011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1085
1086 * editfns.c (Fformat): Correctly handle text properties on "%%".
1087
bd01620e
EZ
10882011-09-15 Eli Zaretskii <eliz@gnu.org>
1089
1090 * xterm.c (x_draw_composite_glyph_string_foreground):
1091 * w32term.c (x_draw_composite_glyph_string_foreground):
1092 * term.c (encode_terminal_code):
1093 * composite.c (composition_update_it, get_composition_id):
1094 * xdisp.c (get_next_display_element)
1095 (fill_composite_glyph_string): Add comments about special meaning
1096 of TAB characters in a composition.
1097
a02719a3
PE
10982011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1099
1100 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1101 This occurs when processing a multibyte format.
1102 Problem reported by Wolfgang Jenker.
a02719a3 1103
72589a3c
JB
11042011-09-15 Johan Bockgård <bojohan@gnu.org>
1105
1106 * xdisp.c (try_cursor_movement): Only check for exact match if
1107 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1108
1c14176c
PE
11092011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1110
1111 Remove unused external symbols.
1112 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1113 * xdisp.c (calc_pixel_width_or_height): Now static.
1114 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1115 * indent.c (check_display_width):
1116 * w32term.c: Fix comment to match code.
1117 * xterm.c, xterm.h (x_catching_errors): Remove.
1118
d2eea5b5
PE
11192011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1120
1121 * xselect.c: Use signed conversions more consistently (Bug#9498).
1122 (selection_data_to_lisp_data): Assume incoming selection data are
1123 signed integers, not unsigned. This is to be consistent with
1124 outgoing selection data, which was modified to use signed integers
1125 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1126 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1127 expects long, not unsigned long.
1128
46888499
EZ
11292011-09-14 Eli Zaretskii <eliz@gnu.org>
1130
1131 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1132 computation of loop end. Reported by Johan Bockgård
1133 <bojohan@gnu.org>.
1134
ef8ef9fb
CY
11352011-09-13 Chong Yidong <cyd@stupidchicken.com>
1136
1137 * frame.c (Fother_visible_frames_p): Function deleted.
1138
fa819fed
EZ
11392011-09-12 Eli Zaretskii <eliz@gnu.org>
1140
1141 * indent.c (compute_motion): Process display vector front to back
1142 rather than the other way around. (Bug#2496)
1143
2ba8e008
SM
11442011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1145
1146 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1147
20f53c69
CY
11482011-09-11 Chong Yidong <cyd@stupidchicken.com>
1149
1150 * minibuf.c (Fread_from_minibuffer): Doc fix.
1151
d562d7a4
EZ
11522011-09-11 Eli Zaretskii <eliz@gnu.org>
1153
1154 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1155 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1156
1c4d7f3d
LMI
11572011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1158
1159 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1160 value for non-existent files.
1161
b885bf36
EZ
11622011-09-11 Eli Zaretskii <eliz@gnu.org>
1163
1164 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1165 set its "size" to -1. This will set the modtime_size field of
1166 the corresponding buffer to -1, which is what
1167 verify-visited-file-modtime expects for files that do not exist.
1168 (Bug#9139)
1169
6612f0bf
PE
11702011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1171
1172 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1173 here ...
1174 * lisp.h: ... from here. push_key_description is no longer
1175 defined in keyboard.c, so its declaration should not be in
1176 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1177 logically belongs with push_key_description.
1178
dfb3f755
PE
11792011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1180
1181 * buffer.h: Include <sys/types.h> instead of <time.h>.
1182 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1183 Problem reported by Herbert J. Skuhra.
1184
3134906c
LMI
11852011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1186
1187 * xml.c (parse_region): Make the parsing work for
1188 non-comment-starting XML files again (bug#9144).
1189
8d903f4e
AS
11902011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1191
1192 * image.c (gif_load): Fix calculation of bottom and right corner.
1193 (Bug#9468)
1194
80ad64f4
EZ
11952011-09-10 Eli Zaretskii <eliz@gnu.org>
1196
1197 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1198 redisplay in small windows.
1199
208a048d
EZ
12002011-09-09 Eli Zaretskii <eliz@gnu.org>
1201
1202 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1203
9b1c252e
MR
12042011-09-08 Martin Rudalics <rudalics@gmx.at>
1205
1206 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1207 Operate on live windows only.
1208
2949f33b
JB
12092011-09-08 Juanma Barranquero <lekktu@gmail.com>
1210
1211 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1212
e08dcafd
EZ
12132011-09-07 Eli Zaretskii <eliz@gnu.org>
1214
1215 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1216 only under bidi iteration.
1217
115b96bd
JD
12182011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1219
1220 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1221
c8199d0f
PE
12222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1223
1224 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1225 Without this fix, the command to link temacs failed due to an
1226 undefined symbol __builtin_isnan. This is because
1227 /usr/include/iso/math_c99.h #defines isnan(x) to
1228 __builtin_isnan(x), but the bundled gcc, which identifies itself
1229 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1230 a __builtin_isnan.
1231 * floatfns.c (isnan): #undef, and then #define to a clone of
1232 what's in data.c.
1233 (Fisnan): Always define, since it's always available now.
1234 (syms_of_floatfns): Always define isnan at the Lisp level.
1235
e39b275c 12362011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1237
1238 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1239
b2db44d9 12402011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1241
f4af5137 1242 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1243 The previous code assumed that file offsets (off_t values) fit in
1244 EMACS_INT variables, which is not true on typical 32-bit hosts.
1245 The code messed up by falsely reporting buffer overflow in cases
1246 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1247 when "big" contains more than 2**29 bytes, even though this
1248 inserts just one byte and does not overflow the buffer.
1249 (Finsert_file_contents): Store file offsets as off_t
1250 values, not as EMACS_INT values. Check for overflow when
1251 converting between EMACS_INT and off_t. When checking for
1252 buffer overflow or for overlap, take the offsets into account.
1253 Don't use EMACS_INT for small values where int suffices.
1254 When checking for overlap, fix a typo: ZV was used where
1255 ZV_BYTE was intended.
1256 (Fwrite_region): Don't assume off_t fits into 'long'.
1257 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1258
ecfc0a49
MA
12592011-09-05 Michael Albinus <michael.albinus@gmx.de>
1260
1261 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1262
6511acf2 12632011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1264
0999621a 1265 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1266
1267 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1268 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1269 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1270 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1271 (modify_event_symbol): Do not assume that the length of
1272 name_alist_or_stem is safe to alloca and fits in int.
1273 (Fexecute_extended_command): Likewise for function name and binding.
1274 (Frecursion_depth): Wrap around reliably on integer overflow.
1275 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1276 since some callers pass EMACS_INT values.
1277 (Fsingle_key_description): Don't crash if symbol name contains more
1278 than MAX_ALLOCA bytes.
1279 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1280 (get_minibuffer): Arg is now EMACS_INT, not int.
1281 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1282 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1283 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1284
2be7d702
PE
1285 * dbusbind.c (signature_cat): New function.
1286 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1287 Do not overrun buffer; instead, report string overflow.
1288
9d1df220
PE
1289 * dispnew.c (add_window_display_history): Don't overrun buffer.
1290 Truncate instead; this is OK since it's just a log.
1291
33ef5c64
PE
1292 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1293 even if the time zone offset is outlandishly large.
1294 Don't mishandle offset == INT_MIN.
1295
66c6fdd5
PE
1296 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1297 when creating daemon; the previous buffer-overflow check was incorrect.
1298
d749b01b
PE
1299 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1300 which has the guts of the old verror function.
1301
b5cd1905
PE
1302 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1303 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1304
6e1a67fb
PE
1305 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1306 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1307 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1308 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1309 length of string rather than counting it via multiple sprintfs;
1310 that's simpler and more reliable.
c21721cc
PE
1311 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1312 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1313 sprintf, in case result does not fit in int.
1314
c57b67fc
PE
1315 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1316 (fontset_from_font): Print it.
1317
8a401434
PE
1318 * frame.c (tty_frame_count): Now printmax_t, not int.
1319 (make_terminal_frame, set_term_frame_name): Print it.
1320 (x_report_frame_params): In X, window IDs are unsigned long,
1321 not signed long, so print them as unsigned.
1322 (validate_x_resource_name): Check for implausibly long names,
1323 and don't assume name length fits in 'int'.
1324 (x_get_resource_string): Don't blindly alloca invocation name;
1325 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1326 not fit in int.
1327
6e1a67fb
PE
1328 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1329 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1330 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1331
0df02bf3
PE
1332 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1333 Use esprintf, not sprintf, in case result does not fit in int.
1334
48e30793
PE
1335 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1336 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1337 it as a large positive number.
1338 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1339 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1340
a66ff6d8
PE
1341 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1342 in case result does not fit in int.
1343
aca216ff
PE
1344 * print.c (float_to_string): Detect width overflow more reliably.
1345 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1346 buffer overrun. Don't assume list length fits in 'int'. Treat
1347 print length of 0 as 0, not as infinity; to be consistent with other
1348 uses of print length in this function. Don't overflow print length
1349 index. Don't assume hash table size fits in 'long', or that
1350 vectorlike size fits in 'unsigned long'.
1351
31c286f7
PE
1352 * process.c (make_process): Use printmax_t, not int, to format
1353 process-name gensyms.
1354
55e5faa1
PE
1355 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1356
80f2e268
PE
1357 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1358 to avoid potential buffer overrun.
1359
670741ab
PE
1360 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1361 if X resource line is longer than 512 bytes.
1362
b7163a50
PE
1363 * xfns.c (x_window): Make sprintf buffer a bit bigger
1364 to avoid potential buffer overrun.
1365
ae58ff1f
PE
1366 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1367
c43c8a6a
PE
1368 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1369
3f8236f4
PE
13702011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1371
53e9fe90 1372 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1373 Without these, Emacs silently mishandles large integers sometimes.
1374 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1375 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1376
6511acf2
PE
1377 * xdisp.c (try_window_id): Check Emacs fixnum range before
1378 converting to 'int'.
806add1d 1379
6511acf2 1380 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1381 Check that an Emacs fixnum is in range before assigning it to 'int'.
1382 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1383 values converted from Emacs fixnums.
1384 (Frecenter): Don't wrap around a line count if it is out of 'int'
1385 range; instead, treat it as an extreme value.
1386 (Fset_window_configuration, compare_window_configurations):
1387 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1388
6511acf2
PE
1389 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1390 that can exceed INT_MAX. Check that EMACS_INT value is in range
1391 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1392 (match_limit): Don't assume that a fixnum can fit in 'int'.
1393
6511acf2 1394 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1395 exceed INT_MAX.
1396
6511acf2 1397 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1398 (Fvertical_motion): Don't wrap around LINES values that don't fit
1399 in 'int'. Instead, treat them as extreme values. This is good
1400 enough for windows, which can't have more than INT_MAX lines anyway.
1401
fcb901a7
LMI
14022011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1403
0f2f6b6d
LMI
1404 * Require libxml/parser.h to avoid compilation warning.
1405
fcb901a7
LMI
1406 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1407
1408 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1409 since this reportedly can destroy thread storage.
1410
6e20a0d4
CY
14112011-08-30 Chong Yidong <cyd@stupidchicken.com>
1412
1413 * syntax.c (find_defun_start): Update all cache variables if
1414 exiting early (Bug#9401).
1415
148ae00e
EZ
14162011-08-30 Eli Zaretskii <eliz@gnu.org>
1417
f6cfbd8f
EZ
1418 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1419
148ae00e
EZ
1420 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1421 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1422 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1423
1424 * term.c (tty_append_glyph): New function.
1425 (produce_stretch_glyph): Static function and its prototype deleted.
1426
a66cfb1c
SM
1427 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1428 Add prototypes.
148ae00e 1429
c4a07a4c
PE
14302011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1431
1432 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1433 when checking :margin (Bug#9390).
1434 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1435 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1436 so that the name doesn't mislead. All uses changed.
1437
6bc8cd65
JB
14382011-08-28 Johan Bockgård <bojohan@gnu.org>
1439
1440 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1441 set_tty_hooks.
1442
dca4927e
EZ
14432011-08-27 Eli Zaretskii <eliz@gnu.org>
1444
1445 * xdisp.c (move_it_to): Don't bail out early when reaching
1446 position beyond to_charpos, if we are scanning backwards.
1447 (move_it_vertically_backward): When DY == 0, make sure we get to
1448 the first character in the line after the newline.
1449
f2cad773
PE
14502011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1451
1452 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1453 (ccl_driver): Do not generate an out-of-range pointer.
1454 (Fccl_execute_on_string): Remove unnecessary check for
1455 integer overflow, noted by Stefan Monnier in
1456 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1457 Remove a FIXME that didn't need fixing.
1458 Simplify the newly-introduced buffer reallocation code.
1459
0cae2cdb
JB
14602011-08-27 Juanma Barranquero <lekktu@gmail.com>
1461
1462 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1463
5fc295a4 14642011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1465
70c60eb2 1466 Integer and memory overflow issues (Bug#9196).
726e0ab1 1467
d31850da
PE
1468 * doc.c (get_doc_string): Rework so that
1469 get_doc_string_buffer_size is the actual buffer size, rather than
1470 being 1 less than the actual buffer size; this makes xpalloc more
1471 convenient.
1472
a69fbedb
PE
1473 * image.c (x_allocate_bitmap_record, cache_image):
1474 * xselect.c (Fx_register_dnd_atom):
1475 Simplify previous changes by using xpalloc.
1476
fe5c5d37
PE
1477 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1478 since either will do and ptrdiff_t is convenient with xpalloc.
1479
0065d054
PE
1480 * charset.c (charset_table_size)
1481 (struct charset_sort_data.priority): Now ptrdiff_t.
1482 (charset_compare): Don't overflow if priorities differ greatly.
1483 (Fsort_charsets): Don't assume list length fits in int.
1484 Check for size-calculation overflow when allocating sort data.
1485 (syms_of_charset): Allocate an initial charset table that is
1486 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1487
1488 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1489
1490 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1491 The actual value is always <= INT_MAX, and leaving it unsigned made
1492 overflow checking harder.
1493
1494 * dispextern.h (struct glyph_matrix.rows_allocated)
1495 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1496 with xpalloc. The values are still always <= INT_MAX.
1497
1498 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1499
1500 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1501 (SAFE_NALLOCA): New macro.
1502
1503 * region-cache.c (struct boundary.pos, find_cache_boundary)
1504 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1505 (set_cache_region, invalidate_region_cache)
1506 (revalidate_region_cache, know_region_cache, region_cache_forward)
1507 (region_cache_backward, pp_cache):
1508 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1509 so that ptrdiff_t * can be passed to xpalloc.
1510 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1511 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1512 (pp_cache): Don't assume cache_len fits in int.
1513 * region-cache.h: Adjust extern decls to match.
1514
1515 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1516 EMACS_INT, since either will do, for xpalloc.
1517
1518 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1519 (xnmalloc, xnrealloc, xpalloc): New functions.
1520
726e0ab1
PE
1521 * bidi.c (bidi_shelve_header_size): New constant.
1522 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1523 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1524
51f30bc5 1525 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1526 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1527 (overlay_strings):
1528 Don't update size of array until after memory allocation succeeds,
1529 because xmalloc/xrealloc may not return.
0065d054
PE
1530 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1531 now that we have proper integer overflow checking.
1532 (record_overlay_string, overlay_strings): Catch overflows when
1533 calculating size of overlay_str_buf.
726e0ab1 1534
0065d054
PE
1535 * callproc.c (Fcall_process): Check for size overflow when
1536 calculating size of args2.
1537 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1538 Normally we prefer signed values, but sticking with ptrdiff_t would
1539 require adding more-complicated checks.
726e0ab1
PE
1540
1541 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1542 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1543 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1544 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1545
1546 * character.c (Fstring): Check for size-calculation overflow.
1547
1548 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1549 unnecessary integer overflow. Check for size overflow.
1550 (encode_coding_object): Don't update size until xmalloc succeeds.
1551
1552 * composite.c (get_composition_id): Check for overflow in glyph
1553 length calculations.
1554
1555 Integer and memory overflow fixes for display code.
1556 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1557 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1558 (scrolling_window): Check for overflow in size calculations.
1559 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1560 Don't assume glyph table len fits in int.
1561 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1562 (row_table_size): Now ptrdiff_t, not int.
1563 (scrolling_window): Avoid overflow in size calculations.
1564 Don't update size until allocation succeeds.
1565 * fns.c (concat): Check for overflow in size calculations.
1566 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1567 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1568 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1569
1570 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1571 (get_doc_string): Check for size calculation overflow.
1572 Don't update size until allocation succeeds.
1573 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1574 EMACS_INT, where ptrdiff_t will do.
1575 (Fsubstitute_command_keys): Check for string overflow.
1576
1577 * editfns.c (set_time_zone_rule): Don't assume environment length
1578 fits in int.
1579 (message_length): Now ptrdiff_t, not int.
1580 (Fmessage_box): Don't update size until allocation succeeds.
1581 Don't assume message length fits in int.
1582 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1583
0065d054
PE
1584 * emacs.c (main): Do not reallocate argv, since there is a null at
1585 the end that can be overwritten, and this way there's no need to
1586 worry about size-calculation overflow.
1587 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1588
1589 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1590 alloc succeeds.
1591 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1592
1593 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1594 (x_set_scroll_bar_width, x_figure_window_size):
1595 Check for integer overflow.
1596 (x_set_alpha): Do not assume XINT fits in int.
1597
1598 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1599 This is for the members text_lines, text_cols, total_lines, total_cols,
1600 where the system imposes an 'int' limit.
1601
1602 * fringe.c (Fdefine_fringe_bitmap):
1603 Don't update size until alloc works.
1604
1605 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1606 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1607
1608 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1609 Check for size-calculation overflow.
1610 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1611 do, as we prefer signed integers.
1612 (id_to_widget.max_size, id_to_widget.used)
1613 (xg_store_widget_in_map, xg_remove_widget_from_map)
1614 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1615 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1616 Use and return ptrdiff_t, not int.
1617 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1618 * gtkutil.h: Change prototypes to match the above.
1619
1620 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1621 are duplicate now that they've been promoted to lisp.h.
1622 (x_allocate_bitmap_record, x_alloc_image_color)
1623 (make_image_cache, cache_image, xpm_load):
1624 Don't update size until alloc is done.
1625 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1626 (x_detect_edges):
3256efce 1627 Check for size calculation overflow.
726e0ab1
PE
1628 (ct_colors_allocated_max): New constant.
1629 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1630 overflow.
3256efce 1631
726e0ab1
PE
1632 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1633 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1634 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1635 Use ptrdiff_t, not int, to count maps.
1636 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1637 calculations. Don't update size until allocation succeeds.
1638 Redo calculations to avoid overflow.
726e0ab1
PE
1639 * keyboard.h: Change prototypes to match the above.
1640
1641 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1642 to count maps.
1643 (current_minor_maps): Check for size calculation overflow.
1644 * keymap.h: Change prototypes to match the above.
1645
1646 * lread.c (read1, init_obarray): Don't update size until alloc done.
1647
1648 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1649 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1650
726e0ab1
PE
1651 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1652 Now ptrdiff_t, not int.
1653 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1654 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1655
1656 * process.c (Fnetwork_interface_list): Check for overflow
1657 in size calculation.
1658
1659 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1660
1661 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1662 overflow. Don't bother calling xmalloc when xrealloc will do.
1663
1664 * search.c (Freplace_match): Check for size calculation overflow.
1665 (Fset_match_data): Don't assume list lengths fit in 'int'.
1666
1667 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1668 for command line length. Do not attempt to address one before the
1669 beginning of an array, as that's not portable.
1670
1671 * term.c (max_frame_lines): Remove; unused.
1672 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1673 not int.
1674 (encode_terminal_code, calculate_costs): Check for size
1675 calculation overflow.
1676 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1677 table lengths and related sizes. Don't update size until alloc
1678 done. Redo calculations to avoid overflow.
1679 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1680
1681 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1682 subtracting pointers.
1683 (gobble_line): Check for overflow more carefully. Don't update size
1684 until alloc done.
1685
1686 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1687 Don't update size until alloc done.
1688 Redo size calculations to avoid overflow.
1689 Check for size calculation overflow.
0065d054 1690 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1691
1692 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1693 Use ptrdiff_t, not int, for sizes.
1694 (store_mode_line_noprop_char): Don't update size until alloc done.
1695
0065d054
PE
1696 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1697 Use ptrdiff_t, not int, for sizes.
1698 (Finternal_make_lisp_face, cache_face):
1699 Check for size calculation overflow.
1700 (cache_face): Treat size calculation overflows as if they were
1701 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1702
1703 * xfns.c (x_encode_text, x_set_name_internal)
1704 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1705 sizes, since they can exceed INT_MAX in size. Check for size
1706 calculation overflow.
1707
0065d054
PE
1708 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1709 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1710 Don't update size until alloc done.
1711
0065d054 1712 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1713 as sprintf is limited to int lengths.
1d526e2f 1714
252c5ee1
PE
1715 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1716 (X_LONG_MIN): New macros.
864d7ce7
PE
1717 Use them to make the following changes clearer.
1718 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1719 This change doesn't affect the value now, but it may help remind
1720 future maintainers not to raise the value too much later.
1721 (SELECTION_QUANTUM): Remove, replacing with ...
1722 (selection_quantum): ... new function, which avoids overflow.
1723 All uses changed.
1724 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1725 assumption that selection length fits in 'int'.
1726 (x_reply_selection_request, x_handle_selection_request)
1727 (x_get_window_property, receive_incremental_selection)
1728 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1729 (lisp_data_to_selection_data, clean_local_selection_data):
1730 Use ptrdiff_t, not int, to record length of selection.
1731 (x_reply_selection_request, x_get_window_property)
1732 (receive_incremental_selection, x_property_data_to_lisp):
1733 Redo calculations to avoid overflow.
1734 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1735 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1736 something.
1737 (x_get_window_property, receive_incremental_selection)
1738 (lisp_data_to_selection_data, x_property_data_to_lisp):
1739 Check for size-calculation overflow.
1740 (x_get_window_property, receive_incremental_selection)
1741 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1742 Don't store size until memory allocation succeeds.
1743 (x_get_window_property): Plug memory leak on memory exhaustion.
1744 Don't double-block input; malloc is safe here. Don't assume 2**34
1745 - 4 fits in unsigned long. Add an xassert to check
1746 XGetWindowProperty overflow. Be more careful about overflow
1747 calculations, and distinguish size from memory overflow better.
1748 (receive_incremental_selection): When tracing, don't assume
1749 unsigned int is less than INT_MAX.
1750 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1751 harmful) conversions of unsigned short to int.
1752 (lisp_data_to_selection_data): Don't assume that integers
1753 in the range -65535 through -1 fit in an X unsigned short.
1754 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1755 result parameters unless successful. Rely on cons_to_unsigned
1756 to report problems with elements; the old code wasn't right anyway.
1757 (x_check_property_data): Check for int overflow; we cannot use
1758 a wider type due to X limits.
1759 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1760
726e0ab1 1761 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1762
0065d054
PE
1763 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1764 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1765 (x_color_cells): Don't store size until memory allocation succeeds.
1766 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1767 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1768 (x_term_init): Don't assume length fits in int (sprintf is limited
1769 to int size).
bc18e09d 1770
ebfa62c0
PE
1771 Use ptrdiff_t for composition IDs.
1772 * character.c (lisp_string_width):
1773 * composite.c (composition_table_size, n_compositions)
1774 (get_composition_id, composition_gstring_from_id):
1775 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1776 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1777 * window.c (Frecenter):
1778 Use ptrdiff_t, not int, for composition IDs.
1779 * composite.c (get_composition_id): Check for integer overflow.
1780 * composite.h: Adjust prototypes to match the above changes.
1781
d3411f89
PE
1782 Use ptrdiff_t for hash table indexes.
1783 * category.c (hash_get_category_set):
1784 * ccl.c (ccl_driver):
1785 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1786 * coding.c (coding_system_charset_list, detect_coding_system):
1787 * coding.h (struct coding_system.id):
1788 * composite.c (get_composition_id, gstring_lookup_cache):
1789 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1790 * image.c (xpm_get_color_table_h):
1791 * lisp.h (hash_lookup, hash_put):
1792 * minibuf.c (Ftest_completion):
1793 Use ptrdiff_t for hash table indexes, not int (which is too
1794 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1795 32-bit --with-wide-int hosts).
1796
e097a6fa
PE
1797 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1798 Add a FIXME comment about memory leaks.
1799 (syms_of_charset): Don't assume xmalloc returns.
1800
5637687f
PE
1801 Don't assume that stated character widths fit in int.
1802 * character.c (Fchar_width, c_string_width, lisp_string_width):
1803 * character.h (CHAR_WIDTH):
1804 * indent.c (MULTIBYTE_BYTES_WIDTH):
1805 Use sanitize_char_width to avoid undefined and/or bad behavior
1806 with outlandish widths.
a66cfb1c 1807 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1808 now that we have two such functions. All uses changed.
1809 (sanitize_char_width): New inline function.
1810
a2271ba2
PE
1811 Don't assume that tab-width fits in int.
1812 * character.h (sanitize_width): New inline function.
1813 (SANE_TAB_WIDTH): New macro.
1814 (ASCII_CHAR_WIDTH): Use it.
1815 * indent.c (sane_tab_width): Remove. All uses replaced by
1816 SANE_TAB_WIDTH (current_buffer).
1817 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1818
18c52557
PE
1819 * fileio.c: Integer overflow issues with file modes.
1820 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1821
caeeedc1
PE
1822 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1823 Remove unreachable code.
1824 (read_hex, load_charset_map_from_file): Check for integer overflow.
1825
50849c52
PE
1826 * xterm.c: don't go over XClientMessageEvent limit
1827 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1828 (x_send_scroll_bar_event): Likewise. Check that the size does not
1829 exceed limits imposed by XClientMessageEvent, as well as the usual
1830 ptrdiff_t and size_t limits.
1831
b13995db
PE
1832 * keyboard.c: Overflow, signedness and related fixes.
1833 (make_lispy_movement): Use same integer type in forward decl
1834 that is used in the definition.
1835 (read_key_sequence, keyremap_step):
1836 Change bufsize argument back to int, undoing my 2011-03-30 change.
1837 We prefer signed types, and int is wide enough here.
1838 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1839 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1840 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1841 length, not size_t. Use ptrdiff_t for index, not int.
1842 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1843 possibility of integer overflow.
1844
13464394
PE
1845 Overflow, signedness and related fixes for images.
1846
1847 * dispextern.h (struct it.stack[0].u.image.image_id)
1848 (struct_it.image_id, struct image.id, struct image_cache.size)
1849 (struct image_cache.used, struct image_cache.ref_count):
1850 * gtkutil.c (update_frame_tool_bar):
1851 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1852 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1853 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1854 * nsmenu.m (update_frame_tool_bar):
1855 * xdisp.c (calc_pixel_width_or_height):
1856 * xfns.c (image_cache_refcount):
1857 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1858 on typical 64-bit hosts.
1859
1860 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1861 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1862 Omit unnecessary casts to int.
1863 (parse_image_spec): Check that integers fall into 'int' range
1864 when the callers expect that.
1865 (image_ascent): Redo ascent calculation to avoid int overflow.
1866 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1867 (lookup_image): Remove unnecessary tests.
1868 (xbm_image_p): Locals are now of int, not EMACS_INT,
1869 since parse_image_check makes sure they fit into int.
1870 (png_load, gif_load, svg_load_image):
1871 Prefer int to unsigned where either will do.
1872 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1873 old tiff_error_handler and tiff_warning_handler.
1874 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1875 stack buffer overflows. It uses only the features of vsnprintf
1876 that are common to both POSIX and native Microsoft.
1877 (tiff_error_handler, tiff_warning_handler): Use it.
1878 (tiff_load, gif_load, imagemagick_load_image):
1879 Don't assume :index value fits in 'int'.
1880 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1881 (imagemagick_load_image): Check that crop parameters fit into
1882 the integer types that MagickCropImage accepts. Don't assume
1883 Vimagemagick_render_type has a nonnegative value. Don't assume
1884 size_t fits in 'long'.
1885 (gs_load): Use printmax_t to print the widest integers possible.
1886 Check for integer overflow when computing image height and width.
1887
c11821d4
EZ
18882011-08-26 Eli Zaretskii <eliz@gnu.org>
1889
1890 * xdisp.c (redisplay_window): Don't force window start if point
1891 will be invisible in the resulting window. (Bug#9324)
1892
0c95fcf7
EZ
18932011-08-25 Eli Zaretskii <eliz@gnu.org>
1894
1895 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1896 the display spec is of the form `(space ...)'.
1897 (handle_display_spec): Return the value returned by
1898 handle_single_display_spec, not just 1 or zero.
1899 (handle_single_display_spec): If the display spec is of the form
1900 `(space ...)', and specifies display in the text area, return 2
1901 rather than 1.
fee65a97 1902 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1903 accurately, and prefer exact match for point under bidi.
1904 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1905
1906 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1907 into disp_prop; all users changed.
1908
1909 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1910 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1911 for the text covered by the display property.
1912
e4ed06f1
CY
19132011-08-25 Chong Yidong <cyd@stupidchicken.com>
1914
1915 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1916 Change return value to nil.
1917 (Frecord_buffer): Delete unused function.
1918
f67cdd7f
EZ
19192011-08-24 Eli Zaretskii <eliz@gnu.org>
1920
5980d4c6
EZ
1921 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1922 buffers, return left-to-right.
8610fe8b
EZ
1923 (set_cursor_from_row): Consider candidate row a win if its glyph
1924 represents a newline and point is on that newline. Fixes cursor
1925 positioning on the newline at EOL of R2L text within L2R
1926 paragraph, and vice versa.
1927 (try_cursor_movement): Check continued rows, in addition to
1928 continuation rows. Fixes unwarranted scroll when point enters a
1929 continued line of R2L text within an L2R paragraph, or vice versa.
1930 (cursor_row_p): Consider the case of point being equal to
1931 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1932 from the end of a short line to the beginning of a continued line
1933 of R2L text within L2R paragraph.
1934 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1935 composed characters.
5980d4c6 1936
f67cdd7f
EZ
1937 * bidi.c (bidi_check_type): Use xassert.
1938 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1939 members.
1940
bca633fb
EZ
19412011-08-23 Eli Zaretskii <eliz@gnu.org>
1942
1943 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1944 a character.
1945
4a5885a7
CY
19462011-08-23 Chong Yidong <cyd@stupidchicken.com>
1947
1948 * nsfont.m (ns_otf_to_script): Fix typo.
1949
0902a04e
KH
19502011-08-22 Kenichi Handa <handa@m17n.org>
1951
1952 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1953 extra slot even if the purpose is char-code-property-table.
1954
1a2e6670
EZ
19552011-08-23 Eli Zaretskii <eliz@gnu.org>
1956
8ddde651
EZ
1957 * xdisp.c (redisplay_window): When computing centering_position,
1958 account for the height of the header line. (Bug#8874)
1959
425cc014
EZ
1960 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1961 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1962 candidate is selected by the mouse, and that candidate has a
1963 composed character under the mouse.
1964
1a2e6670
EZ
1965 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1966 coordinates reported by pos-visible-in-window-p for a composed
1967 character in column zero.
1968
8b76d6f8
SM
19692011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1970
1971 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1972
dac347dd
EZ
19732011-08-22 Eli Zaretskii <eliz@gnu.org>
1974
1975 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1976 consider it a hit if to_charpos is anywhere in the range of the
1977 composed buffer positions.
1978
e013fb34
CY
19792011-08-22 Chong Yidong <cyd@stupidchicken.com>
1980
1981 * image.c (gif_load): Don't assume that each subimage has the same
1982 dimensions as the base image. Handle disposal method that is
1983 "undefined" by the gif spec (Bug#9335).
1984
bd1ba3e8
CY
19852011-08-20 Chong Yidong <cyd@stupidchicken.com>
1986
1987 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1988 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1989
54a1215b
EZ
19902011-08-19 Eli Zaretskii <eliz@gnu.org>
1991
823564e5
EZ
1992 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1993 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1994 from an Org mode buffer to a Speedbar frame.
1995
54a1215b
EZ
1996 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1997 a composition, take its buffer position from IT->cmp_it.charpos.
1998 Fixes cursor positioning at the beginning of a line that begins
1999 with a composed character.
2000
9778ebcc
EZ
20012011-08-18 Eli Zaretskii <eliz@gnu.org>
2002
0be6ee06
EZ
2003 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2004 character bidirectional type, use STRONG_L instead. Fixes crashes
2005 in a buffer produced by `describe-categories'.
2006
9778ebcc
EZ
2007 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2008 members before the level stack, so they would be saved and
2009 restored when copying iterator state. Fixes incorrect reordering
2010 around TABs covered by display properties.
2011
156bffbe
AS
20122011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2013
6b02f655 2014 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2015
72ad093b
CY
20162011-08-17 Chong Yidong <cyd@stupidchicken.com>
2017
2018 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2019 (internal_condition_case_2, internal_condition_case_n):
2020 Remove unnecessary aborts (Bug#9081).
72ad093b 2021
35774242
EZ
20222011-08-17 Eli Zaretskii <eliz@gnu.org>
2023
2024 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2025 has no `load' handler, try opening the file locally. (Bug#9311)
2026
db76dd85
KB
20272011-08-16 Ken Brown <kbrown@cornell.edu>
2028
2029 * gmalloc.c: Expand comment.
2030
b215eee5
EZ
20312011-08-16 Eli Zaretskii <eliz@gnu.org>
2032
2033 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2034 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2035
a4579d33
KB
20362011-08-16 Ken Brown <kbrown@cornell.edu>
2037
2038 Fix memory allocation problems in Cygwin build (Bug#9273).
2039
2040 * unexcw.c ( __malloc_initialized): Declare external variable.
2041 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2042
8b76d6f8
SM
2043 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2044 New variables.
a4579d33
KB
2045 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2046 dumped emacs.
2047 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2048 in the static heap.
2049 [CYGWIN] (special_realloc): New function.
2050 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2051 requests to realloc storage in the static heap.
2052
3ebec551
PE
20532011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2054
2055 * bidi.c (bidi_initialize): Remove unused local.
2056
9fd8be00
EZ
20572011-08-15 Eli Zaretskii <eliz@gnu.org>
2058
6b02f655
SM
2059 * bidimirror.h:
2060 * biditype.h: Remove file.
2061 * makefile.w32-in ($(BLD)/bidi.$(O)):
2062 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2063
2064 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2065
2066 * chartab.c: Improve commentary for the uniprop_table API.
2067
32413314
EZ
2068 * bidi.c (bidi_paragraph_init): Support zero value of
2069 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2070 (bidi_initialize): Use uniprop_table instead of including
2071 biditype.h and bidimirror.h.
32413314 2072
9fd8be00
EZ
2073 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2074 coordinates of the iterator when restoring from ppos_it.
2075 (Bug#9296)
2076
5cf2b69b
KH
20772011-08-14 Kenichi Handa <handa@m17n.org>
2078
2079 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2080 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2081
daf17d00
EZ
20822011-08-14 Eli Zaretskii <eliz@gnu.org>
2083
2084 * xdisp.c (move_it_in_display_line_to): Don't invoke
2085 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2086 ppos_it. Fixes vertical cursor motion when line beginning is
2087 covered by an image. (Bug#9296)
2088
08e3161a
JD
20892011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2090
2091 * nsterm.h (ns_run_ascript): Declare.
2092 (NSAPP_DATA2_RUNASSCRIPT): Define.
2093
2094 * nsfns.m (as_script, as_result, as_status): New static variables.
2095 (ns_run_ascript): New function.
5e617bc2 2096 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2097 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2098 the event loop. Get status from as_status (Bug#7276).
2099
2100 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2101 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2102 the event loop (Bug#7276).
2103
a3720aa2
AS
21042011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2105
2106 * gnutls.c (QCgnutls_bootprop_priority)
2107 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2108 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2109 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2110 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2111 (QCgnutls_bootprop_verify_hostname_error)
2112 (QCgnutls_bootprop_callbacks_verify): Rename from
2113 Qgnutls_bootprop_..., all uses changed.
2114
2115 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2116 uses changed.
2117
0a0d27fb
PE
21182011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2119
19d5c50c
PE
2120 * xfaces.c (Qframe_set_background_mode): Now static.
2121 * dispextern.h (Qframe_set_background_mode): Remove decl.
2122
0a0d27fb
PE
2123 * process.c (Fnetwork_interface_info): Declare local only if needed.
2124
377538cb
JD
21252011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2126
2127 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2128 (Fnetwork_interface_list): Allocate in increments of bytes instead
2129 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2130 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2131 sockaddr.
2132 (struct ifflag_def): notrailers is smart on OSX.
2133 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2134 Get hardware address with getifaddrs if available.
2135
08fff70c
EZ
21362011-08-12 Eli Zaretskii <eliz@gnu.org>
2137
2138 * xdisp.c (iterate_out_of_display_property): xassert that
2139 IT->position is set to within IT->object's boundaries. Break from
2140 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2141 when IT->position is set up wrongly due to some bug.
2142 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2143 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2144 entry. Force push_it to save on the stack the current
2145 buffer/string position, to be restored by pop_it. Fix flags in
2146 the iterator structure wrt the object coming from a display
2147 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2148 properties. (Bug#9284)
2149
7be1c708 21502011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2151
7be1c708
CY
2152 * fontset.c (fontset_get_font_group): Add proper type checks.
2153 (Bug#9172)
aac0c6e3 2154
7be1c708 21552011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2156
7be1c708
CY
2157 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2158 and LC_VERSION_MIN_MACOSX.
2159 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2160 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2161
97bb72a6
EZ
21622011-08-08 Eli Zaretskii <eliz@gnu.org>
2163
2164 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2165 no-display-properties-and-no-overlays under bidi display.
2166 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2167 properties and overlays.
97bb72a6 2168
d5617611
CY
21692011-08-08 Chong Yidong <cyd@stupidchicken.com>
2170
37e11a63
CY
2171 * editfns.c (Fset_time_zone_rule): Document relationship with the
2172 setenv function.
2173
d5617611
CY
2174 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2175 the font entity extracted from the cache (Bug#8109).
2176
58872834
CY
21772011-08-07 Chong Yidong <cyd@stupidchicken.com>
2178
2179 * composite.c (autocmp_chars): Don't reset point. That is done by
2180 restore_point_unwind (Bug#5984).
2181
75bfc667
JL
21822011-08-07 Juri Linkov <juri@jurta.org>
2183
2184 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2185 to show the arg `TIME' instead of `TIMEVAL'.
2186
d1410150
EZ
21872011-08-06 Eli Zaretskii <eliz@gnu.org>
2188
2189 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2190 display property strides EOL and includes a newline, as in
2191 longlines-mode. (Bug#9254)
75b771e4
EZ
2192 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2193 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2194
2195 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2196 is non-zero, even if the data buffer is NULL. Fixes a crash in
2197 vertical-motion with longlines-mode. (Bug#9254)
2198
35928349
EZ
21992011-08-05 Eli Zaretskii <eliz@gnu.org>
2200
ec7cc85b
EZ
2201 * bidi.c <bidi_cache_total_alloc>: Now static.
2202 (bidi_initialize): Initialize bidi_cache_total_alloc.
2203
8b76d6f8 2204 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2205 cache. (Bug#9221)
2206
2207 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2208 amount allocated this far in `bidi_cache_total_alloc'.
2209 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2210 non-zero, only free the data buffer without restoring the cache
2211 contents. All callers changed.
2212
2213 * dispextern.h (bidi_unshelve_cache): Update prototype.
2214
2215 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2216 (move_it_in_display_line, move_it_to)
2217 (move_it_vertically_backward, move_it_by_lines): Replace the call
2218 to xfree to an equivalent call to bidi_unshelve_cache.
2219 (move_it_in_display_line_to): Fix logic of returning
412b6358 2220 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2221
e2e2423b
EZ
22222011-08-05 Eli Zaretskii <eliz@gnu.org>
2223
2224 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2225 came from a string character with a `cursor' property. (Bug#9229)
2226
ae9e757a
JD
22272011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2228
2229 * Makefile.in (LIB_PTHREAD): New variable.
2230 (LIBES): Add LIB_PTHREAD (Bug#9216).
2231
2232 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2233 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2234
213bd7f2
AS
22352011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2236
6b02f655 2237 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2238
99aaf75f
JD
22392011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2240
2241 * xterm.c (x_find_topmost_parent): New function.
2242 (x_set_frame_alpha): Find topmost parent window with
2243 x_find_topmost_parent and set the property there also (bug#9181).
2244 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2245
c74e9d86
PE
22462011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2247
2248 * callproc.c (Fcall_process): Avoid vfork clobbering
2249 the local vars buffer, coding_systems, current_dir.
2250
640c8776
SM
22512011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2252
2253 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2254
f26d0e4c
PE
22552011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2256
8a10d76c
PE
2257 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2258 so that it is not optimized away.
2259
f26d0e4c
PE
2260 * xdisp.c (compute_display_string_pos): Remove unused local.
2261
55439c61
EZ
22622011-08-02 Eli Zaretskii <eliz@gnu.org>
2263
2264 Fix slow cursor motion and scrolling in large buffers with
2265 selective display, like Org Mode buffers. (Bug#9218)
2266
2267 * dispextern.h (struct bidi_it): New member disp_prop_p.
2268
2269 * xdisp.c: Remove one-slot cache of display string positions.
2270 (compute_display_string_pos): Accept an additional argument
5e617bc2 2271 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2272 for a display string or property. If found, set DISP_PROP_P
2273 non-zero.
2274
2275 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2276 DISP_PROP_P, and pass it to compute_display_string_pos.
2277 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2278 non-zero. All callers of bidi_fetch_char changed.
2279
fb33fa43
SM
22802011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2281
2282 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2283
b099e063
DM
22842010-12-03 Don March <don@ohspite.net>
2285
2286 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2287 last character M-[char] is translated to ESC [char] (bug#7541).
2288
5cc7f7af
KH
22892011-08-02 Kenichi Handa <handa@m17n.org>
2290
d0fffa3f 2291 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2292
2293 * chartab.c (uniprop_table): Make it non-static.
2294
525d5e6e
EZ
22952011-08-01 Eli Zaretskii <eliz@gnu.org>
2296
2297 * xdisp.c (forward_to_next_line_start): Accept additional argument
2298 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2299 on the newline.
2300 (reseat_at_next_visible_line_start): Use the bidi iterator state
2301 returned by forward_to_next_line_start to restore the state of
2302 it->bidi_it after backing up to previous newline. (Bug#9212)
2303
31011111
AS
23042011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2305
2306 * regex.c (re_comp): Protoize.
2307 (re_exec): Fix return type.
2308 (regexec): Fix type of `ret'. (Bug#9203)
2309
476371c4
PE
23102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2311
e5d76069
PE
2312 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2313 This is needed if max-image-size is a floating-point number.
2314
9a79b20c
AS
23152011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2316
2317 * print.c (print_object): Print empty symbol as ##.
2318
2319 * lread.c (read1): Read ## as empty symbol.
2320
d8c2fa78
AA
23212011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2322
2323 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2324 setting frame foreground color (Bug#9175).
2325 (x_set_background_color): Likewise.
2326
ffe57a7a
AA
2327 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2328 contents (Bug#9176).
2329 (EmacsTooltip -init): Remove bezels and add shadows to
2330 tooltip windows.
2331
bf3492a5
AA
2332 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2333 or scroll bar (Bug#8470).
2334
d55e9c53
AA
2335 * nsfont.m (nsfont_open): Remove assignment to voffset and
2336 unnecessary vars hshink, expand, hd, full_height, min_height.
2337 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2338
2339 * nsterm.h (nsfont_info): Remove voffset field.
2340
d8c2fa78 23412011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2342
2343 Implement strike-through and overline on NextStep (Bug#8863).
2344
2345 * nsfont.m (nsfont_open): Use underline position provided by font,
2346 instead of hard-coded value of 2.
2347 (nsfont_draw): Call ns_draw_text_decoration instead.
2348
2349 * nsterm.h: Add declaration for ns_draw_text_decoration.
2350
2351 * nsterm.m (ns_draw_text_decoration): New function for drawing
2352 underline, overline, and strike-through.
2353 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2354 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2355 accommodate underlining, etc.
4843aac3 2356
4cc60b9b
EZ
23572011-07-28 Eli Zaretskii <eliz@gnu.org>
2358
bc7ece87
EZ
2359 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2360 default.
4cc60b9b 2361
476371c4
PE
23622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2363
66606eea
PE
2364 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2365 Without this fix, if a signal arrives just after memory fills up,
2366 'malloc' might be invoked reentrantly.
2367
476371c4
PE
2368 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2369 In other words, assume that every image size is allowed, on non-X
2370 hosts. This assumption is probably wrong, but it lets Emacs compile.
2371
f3fcc40d
AS
23722011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2373
2374 * regex.c (re_iswctype): Convert return values to boolean.
2375
350c992f
EZ
23762011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2377
2378 * xdisp.c (compute_display_string_pos): Don't use cached display
2379 string position if the buffer had its restriction changed.
2380 (Bug#9184)
2381
5266b4bb
PE
23822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2383
2384 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2385
2573a837 23862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2387
41f55ccd 2388 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2389
39e378da
PE
2390 * bidi.c: Integer size and overflow fixes.
2391 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2392 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2393 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2394 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2395 (bidi_find_other_level_edge):
2396 Use ptrdiff_t instead of EMACS_INT where either will do.
2397 This works better on 32-bit hosts configured --with-wide-int.
2398 (bidi_cache_ensure_space): Check for size-calculation overflow.
2399 Use % rather than repeated addition, for better worst-case speed.
2400 Don't set bidi_cache_size until after xrealloc returns, because it
2401 might not return.
2402 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2403 (bidi_cache_ensure_space): Also check that the bidi cache size
2404 does not exceed that of the largest Lisp string or buffer. See Eli
2405 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2406
5e927815
PE
2407 * alloc.c (__malloc_size_t): Remove.
2408 All uses replaced by size_t. See Andreas Schwab's note
2409 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2410
ca4aa935
PE
2411 * image.c: Improve checking for integer overflow.
2412 (check_image_size): Assume that f is nonnull, since
2413 it is always nonnull in practice. This is one less thing to
2414 worry about when checking for integer overflow later.
2415 (x_check_image_size): New function, which checks for integer
2416 overflow issues inside X.
2417 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2418 This removes the need for a memory_full check.
2419 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2420 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2421 (xbm_read_bitmap_data): Change locals back to 'int', since
2422 their values must fit in 'int'.
2423 (xpm_load_image, png_load, tiff_load):
2424 Invoke x_create_x_image_and_pixmap earlier,
2425 to avoid much needless work if the image is too large.
2426 (tiff_load): Treat overly large images as if
2427 x_create_x_image_and_pixmap failed, not as malloc failures.
2428 (gs_load): Use x_check_image_size.
2429
5f8f9cc2
PE
2430 * gtkutil.c: Omit integer casts.
2431 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2432 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2433
5adf60bc
PE
2434 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2435
c8907a93
PE
2436 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2437 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2438 would wrongly return t on a 64-bit host.
2439
e3c25c68
PE
2440 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2441 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2442 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2443 and therefore cause GCC to emit a bogus diagnostic in some cases.
2444
3f791afe
PE
2445 * image.c: Integer signedness and overflow and related fixes.
2446 This is not an exhaustive set of fixes, but it's time to
2447 record what I've got.
2448 (lookup_pixel_color, check_image_size): Remove redundant decls.
2449 (check_image_size): Don't assume that arbitrary EMACS_INT values
2450 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2451 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2452 (tiff_load, imagemagick_load_image):
2453 Check for overflow in size calculations.
2454 (x_create_x_image_and_pixmap): Remove unnecessary test for
2455 xmalloc returning NULL; that can't happen.
2456 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2457 (xpm_color_bucket): Use better integer hashing function.
2458 (xpm_cache_color): Don't possibly over-allocate memory.
2459 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2460 (gif_memory_source):
2461 Use ptrdiff_t, not int or size_t, to record sizes.
2462 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2463 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2464 either works, as we prefer signed integers.
2465 (tiff_read_from_memory, tiff_write_from_memory):
2466 Return tsize_t, not size_t, since that's what the TIFF API wants.
2467 (tiff_read_from_memory): Don't fail simply because the read would
2468 go past EOF; instead, return a short read.
2469 (tiff_load): Omit no-longer-needed casts.
2470 (Fimagemagick_types): Don't assume size fits into 'int'.
2471
3cc5a532
PE
2472 Improve hashing quality when configured --with-wide-int.
2473 * fns.c (hash_string): New function, taken from sxhash_string.
2474 Do not discard information about ASCII character case; this
2475 discarding is no longer needed.
2476 (sxhash-string): Use it. Change sig to match it. Caller changed.
2477 * lisp.h: Declare it.
2478 * lread.c (hash_string): Remove, since we now use fns.c's version.
2479 The fns.c version returns a wider integer if --with-wide-int is
2480 specified, so this should help the quality of the hashing a bit.
2481
b312a492
PE
2482 * emacs.c: Integer overflow minor fix.
2483 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2484 Define only if GNU_LINUX.
2485 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2486
dfd153ae
PE
2487 * dispnew.c: Integer signedness and overflow fixes.
2488 Remove unnecessary forward decls, that were a maintenance hassle.
2489 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2490 All uses changed.
2491 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2492 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2493 (prepare_desired_row, line_draw_cost):
2494 Use int, not unsigned, where either works.
2495 (save_current_matrix, restore_current_matrix):
2496 Use ptrdiff_t, not size_t, where either works.
2497 (init_display): Check for overflow more accurately, and without
2498 relying on undefined behavior.
2499
a81d11a3
PE
2500 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2501 Remove, replacing with the new symbols in lisp.h. All uses changed.
2502 * fileio.c (make_temp_name):
2503 * filelock.c (lock_file_1, lock_file):
2504 * xdisp.c (message_dolog):
2505 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2506 Use pMd etc. instead.
2507 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2508 replacing the pWIDE etc. symbols removed from editfns.c.
2509
3300e6fd
PE
2510 * keyboard.h (num_input_events): Now uintmax_t.
2511 This is (very slightly) less likely to mess up due to wraparound.
2512 All uses changed.
2513
fd05c7e9
PE
2514 * buffer.c: Integer signedness fixes.
2515 (alloc_buffer_text, enlarge_buffer_text):
2516 Use ptrdiff_t rather than size_t when either will do, as we prefer
2517 signed integers.
2518
903fe15d
PE
2519 * alloc.c: Integer signedness and overflow fixes.
2520 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2521 (__malloc_size_t): Default to size_t, not to int.
2522 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2523 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2524 Prefer ptrdiff_t to size_t when either would do, as we prefer
2525 signed integers.
2526 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2527 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2528 Now const. Initialize with values that are in range even if char
2529 is signed.
2530 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2531 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2532 These functions do the right thing with sizes > 2**32.
2533 (check_depth): Now ptrdiff_t, not int.
2534 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2535 Adjust to new way of storing sizes. Check for size overflow bugs
2536 in rest of code.
2537 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2538 slightly wrong anyway, as it missed one instance of
2539 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2540 (refill_memory_reserve): Omit needless cast to size_t.
2541 (mark_object_loop_halt): Mark as externally visible.
2542
ac82cc6a
PE
2543 * xselect.c: Integer signedness and overflow fixes.
2544 (Fx_register_dnd_atom, x_handle_dnd_message):
2545 Use ptrdiff_t, not size_t, since we prefer signed.
2546 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2547 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2548 x_dnd_atoms_size and x_dnd_atoms_length.
2549
c2d1e36d
PE
2550 * doprnt.c: Prefer signed to unsigned when either works.
2551 * eval.c (verror):
2552 * doprnt.c (doprnt):
2553 * lisp.h (doprnt):
2554 * xdisp.c (vmessage):
2555 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2556 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2557 prefer signed arithmetic to avoid comparison confusion.
2558 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2559 but is a bit tricky.
2560
0e926e56
PE
2561 Assume freestanding C89 headers, string.h, stdlib.h.
2562 * data.c, doprnt.c, floatfns.c, print.c:
2563 Include float.h unconditionally.
2564 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2565 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2566 * regex.c: Likewise for stddef.h, string.h.
2567 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2568 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2569 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2570 (STDC_HEADERS): Remove obsolete defines.
2571 * sysdep.c: Include limits.h unconditionally.
2572
9cfdb3ec
PE
2573 Assume support for memcmp, memcpy, memmove, memset.
2574 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2575 * regex.c (memcmp, memcpy):
2576 Remove; we assume C89 now.
2577
2578 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2579 (__malloc_safe_bcopy): Remove; no longer needed.
2580
cf950e6b 2581 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2582 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2583 well either way, and we prefer signed to unsigned.
2584
dbf38e02
LMI
25852011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2586
2587 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2588 closes the connection while we're reading (bug#9182).
2589
d6f0886c 25902011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2591
d6f0886c
JD
2592 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2593 are specified (Bug#9168).
24e0f6b1 2594
2eb1f9e6
PE
25952011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2596
2597 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2598 Found by GCC static checking and --with-wide-int on a 32-bit host.
2599
22381272 26002011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2601
2602 * xdisp.c (compute_display_string_pos): Fix logic of caching
2603 previous display string position. Initialize cached_prev_pos to
2604 -1. Fixes slow-down at the beginning of a buffer.
2605
f25e39b4
EZ
26062011-07-24 Eli Zaretskii <eliz@gnu.org>
2607
2608 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2609 for attrs[LFACE_FONTSET_INDEX].
2610
04c4b52e
PE
26112011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2612
2613 * xml.c (parse_region): Remove unused local
2614 that was recently introduced.
2615
c1734fbd
EZ
26162011-07-23 Eli Zaretskii <eliz@gnu.org>
2617
be18c5a5
EZ
2618 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2619 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2620
c1734fbd
EZ
2621 * xdisp.c (move_it_in_display_line_to): Record the best matching
2622 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2623 exit if none of the characters scanned was an exact match.
2624 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2625 when exact match is impossible due to invisible text, and the
2626 lines are truncated.
2627
a258d627
JD
26282011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2629
2630 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2631 for OSX >= 10.7.
2632
b6d5a689
EZ
26332011-07-22 Eli Zaretskii <eliz@gnu.org>
2634
0f74f785
EZ
2635 Fix a significant slow-down of cursor motion with C-n, C-p,
2636 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2637 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2638 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2639 (next_element_from_buffer): Call compute_stop_pos_backwards to
2640 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2641 base_level_stop.
2642 (reseat): Don't look for prev_stop, as that could mean a very long
2643 run.
2644 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2645 <cached_disp_overlay_modiff>: Cache for last found display string
2646 position.
551918c1 2647 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2648 about the same buffer in the same area of character positions, and
2649 the buffer wasn't changed since the time the display string
2650 position was cached.
551918c1 2651
b2d0c91a
EZ
26522011-07-22 Eli Zaretskii <eliz@gnu.org>
2653
2654 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2655 is an integer, which is important for empty lines. (Bug#9149)
2656
043604ee
CY
26572011-07-22 Chong Yidong <cyd@stupidchicken.com>
2658
2659 * frame.c (Fmodify_frame_parameters): In tty case, update the
2660 default face if necessary (Bug#4238).
2661
da4adb04
CY
26622011-07-21 Chong Yidong <cyd@stupidchicken.com>
2663
2664 * editfns.c (Fstring_to_char): No need to explain what a character
2665 is in the docstring (Bug#6576).
2666
9abd0532
LMI
26672011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2668
2669 * xml.c (parse_region): Make sure we always return a tree.
2670
36881d16
HK
26712011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2672
2673 * xml.c (parse_region): If a document contains only comments,
2674 return that, too.
2675
1e98674d
LMI
26762011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2677
2678 * xml.c (make_dom): Return comments, too.
2679
590bd467
PE
26802011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2681
2682 Port to OpenBSD.
2683 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2684 and the surrounding thread.
2685 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2686 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2687 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2688 timer goes off.
2689 * s/openbsd.h (BROKEN_SIGIO): Define.
2690 * unexelf.c (unexec) [__OpenBSD__]:
2691 Don't update the .mdebug section of the Alpha COFF symbol table.
2692
f41628b2
LMI
26932011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2694
2695 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2696 (bug#8460).
2697
b59b67c5
PE
26982011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2699
15e3a074
PE
2700 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2701 This fixes some race conditions on the permissions of any newly
2702 created file.
2703
41bed37d
PE
2704 * alloc.c (valid_pointer_p): Use pipe, not open.
2705 This fixes some permissions issues when debugging.
2706
b59b67c5
PE
2707 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2708 If fchown fails to set both uid and gid, try to set just gid,
2709 as that is sometimes allowed. Adjust the file's mode to eliminate
2710 setuid or setgid bits that are inappropriate if fchown fails.
2711
925a6be7
SM
27122011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2713
2714 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2715 to compare Lisp_Objects.
2716 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2717 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2718 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2719
52968808
AS
27202011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2721
0a6a104b
AS
2722 * lread.c (read_integer): Unread even EOF character.
2723 (read1): Likewise. Properly record start position of symbol.
2724
52968808
AS
2725 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2726 symbol character follows.
2727
9e381cdd
PE
27282011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2729
2730 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2731 This works around a problem with the previous change to Fcopy_file.
2732 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2733 and without this change, GCC might complain about discarding
2734 fchown's return value.
2735
b5641435
JB
27362011-07-16 Juanma Barranquero <lekktu@gmail.com>
2737
2738 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2739
a8031457
PE
27402011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2741
2742 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2743
dd889327
LMI
27442011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2745
750c33f7
LMI
2746 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2747 it's used from the C level.
2748
dd889327
LMI
2749 * process.c: Use the same condition for POLL_FOR_INPUT in both
2750 keyboard.c and process.c (bug#1858).
2751
87e86684
LM
27522011-07-09 Lawrence Mitchell <wence@gmx.li>
2753
2754 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2755 (Fgnutls_boot): Use it.
2756
64348f40
AS
27572011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2758
2759 * doc.c (Fsubstitute_command_keys): Revert last change.
2760
1d698799
LMI
27612011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2762
f863868c
LMI
2763 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2764 quotes the next character, and doesn't affect other longer
2765 sequences (bug#8935).
2766
1d698799
LMI
2767 * lread.c (syms_of_lread): Clarify that is isn't only
2768 `eval-buffer' and `eval-defun' that's affected by
2769 `lexical-binding' (bug#8460).
2770
aa4b6df6
EZ
27712011-07-15 Eli Zaretskii <eliz@gnu.org>
2772
2773 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2774 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2775
5d856da6
PE
27762011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2777
ad6042bb
PE
2778 Fix minor problems found by static checking.
2779 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2780 (elsz): Now a signed constant, not a size_t var. We prefer signed
2781 types to unsigned, to avoid integer comparison confusion. Without
2782 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2783 "cannot optimize loop, the loop counter may overflow", a symptom
2784 of the confusion.
f00bbb22 2785 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2786 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2787
6468f31c
LMI
27882011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2789
49080b10
LMI
2790 * search.c (Fre_search_backward): Mention `case-fold-search' in
2791 all the re_search_* functions (bug#8138).
2792
6468f31c
LMI
2793 * keyboard.c (Fopen_dribble_file): Document when the file is
2794 closed (bug#8056).
2795
c965adc5
EZ
27962011-07-14 Eli Zaretskii <eliz@gnu.org>
2797
df9733bf
EZ
2798 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2799 bidi_cache_idx.
2800
0bb23927
EZ
2801 Support bidi reordering of display and overlay strings.
2802 * xdisp.c (compute_display_string_pos)
2803 (compute_display_string_end): Accept additional argument STRING.
2804 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2805 (reseat_to_string): Initialize bidi_it->string.s and
2806 bidi_it->string.schars.
2807 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2808 NULL (avoids a crash in bidi_paragraph_init).
2809 Initialize itb.string.lstring.
0bb23927
EZ
2810 (init_iterator): Call bidi_init_it only of a valid
2811 buffer position was specified. Initialize paragraph_embedding to
2812 L2R.
2813 (reseat_to_string): Initialize the bidi iterator.
2814 (display_string): If we need to ignore text properties of
2815 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2816 original value of -1 will not work with bidi.)
2817 (compute_display_string_pos): First arg is now struct
2818 `text_pos *'; all callers changed. Support display properties on
2819 Lisp strings.
2820 (compute_display_string_end): Support display properties on Lisp
2821 strings.
2822 (init_iterator, reseat_1, reseat_to_string): Initialize the
2823 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2824 when iterating on a string not from display properties).
640c8776
SM
2825 (compute_display_string_pos, compute_display_string_end):
2826 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2827 arrow keys.
2828 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2829 base_level_stop; instead, set base_level_stop to BEGV.
2830 Fixes crashes in vertical-motion.
0bb23927
EZ
2831 (next_element_from_buffer): Improve commentary for when
2832 the iterator is before prev_stop.
2833 (init_iterator): Initialize bidi_p from the default value of
2834 bidi-display-reordering, not from buffer-local value. Use the
2835 buffer-local value only if initializing for buffer iteration.
2836 (handle_invisible_prop): Support invisible properties on strings
2837 that are being bidi-reordered.
2838 (set_iterator_to_next): Support bidi reordering of C strings and
2839 Lisp strings.
2840 (next_element_from_string): Support bidi reordering of Lisp
2841 strings.
2842 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2843 (display_string): Support display of R2L glyph rows.
2844 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2845 (init_iterator): Don't initialize it->bidi_p for strings
2846 here.
2847 (reseat_to_string): Initialize it->bidi_p for strings here.
2848 (next_element_from_string, next_element_from_c_string)
2849 (next_element_from_buffer): Add xassert's for correspondence
2850 between IT's object being iterated and it->bidi_it.string
2851 structure.
2852 (face_before_or_after_it_pos): Support bidi iteration.
2853 (next_element_from_c_string): Handle the case of the first string
2854 character that is not the first one in the visual order.
2855 (get_visually_first_element): New function, refactored from common
2856 parts of next_element_from_buffer, next_element_from_string, and
2857 next_element_from_c_string.
2858 (tool_bar_lines_needed, redisplay_tool_bar)
2859 (display_menu_bar): Force left-to-right direction. Add a FIXME
2860 comment for making that be controlled by a user option.
2861 (push_it, pop_it): Save and restore the state of the
2862 bidi iterator. Save and restore the bidi_p flag.
2863 (pop_it): Iterate out of display property for string iteration as
2864 well.
2865 (iterate_out_of_display_property): Support iteration over strings.
2866 (handle_single_display_spec): Set up it->bidi_it for iteration
2867 over a display string, and call bidi_init_it.
2868 (handle_single_display_spec, next_overlay_string)
2869 (get_overlay_strings_1, push_display_prop): Set up the bidi
2870 iterator for displaying display or overlay strings.
2871 (forward_to_next_line_start): Don't use the shortcut if
2872 bidi-iterating.
2873 (back_to_previous_visible_line_start): If handle_display_prop
2874 pushed the iterator stack, restore the internal state of the bidi
2875 iterator by calling bidi_pop_it same number of times.
2876 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2877 and we are bidi-iterating, don't decrement the iterator position;
2878 instead, set the first_elt flag in the bidi iterator, to produce
2879 the same effect.
2880 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2881 (push_display_prop): xassert that we are iterating a buffer.
2882 (push_it, pop_it): Save and restore paragraph_embedding member.
2883 (handle_single_display_spec, next_overlay_string)
2884 (get_overlay_strings_1, reseat_1, reseat_to_string)
2885 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2886 correctly. Don't assume unibyte strings are not bidi-reordered.
2887 (compute_display_string_pos)
2888 (compute_display_string_end): Fix handling the case of C string.
2889 (push_it, pop_it): Save and restore from_disp_prop_p.
2890 (handle_single_display_spec, push_display_prop): Set the
2891 from_disp_prop_p flag.
2892 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2893 (pop_it): Call iterate_out_of_display_property only if we are
2894 popping after iteration over a string that came from a display
2895 property. Fix a typo in popping stretch info. Add an assertion
2896 for verifying that the iterator position is in sync with the bidi
2897 iterator.
2898 (handle_single_display_spec, get_overlay_strings_1)
2899 (push_display_prop): Fix initialization of paragraph direction for
2900 string when that of the parent object is not yet determined.
2901 (reseat_1): Call bidi_init_it to resync the bidi
2902 iterator with IT's position. (Bug#7616)
2903 (find_row_edges): If ROW->start.pos gives position
2904 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2905 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2906 Reset the from_disp_prop_p flag.
2907 (SAVE_IT, RESTORE_IT): New macros.
2908 (pos_visible_p, face_before_or_after_it_pos)
2909 (back_to_previous_visible_line_start)
2910 (move_it_in_display_line_to, move_it_in_display_line)
2911 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2912 (try_scrolling, redisplay_window, display_line): Use them when
2913 saving a temporary copy of the iterator and restoring it back.
2914 (back_to_previous_visible_line_start, reseat_1)
2915 (init_iterator): Empty the bidi cache "stack".
2916 (move_it_in_display_line_to): If iterator ended up at
2917 EOL, but we never saw any buffer positions smaller than
2918 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2919 motion in bidi-reordered lines.
2920 (move_it_in_display_line_to): Record prev_method and prev_pos
2921 immediately before the call to set_iterator_to_next. Fixes cursor
2922 motion in bidi-reordered lines with stretch glyphs and strings
2923 displayed in margins. (Bug#8133) (Bug#8867)
2924 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2925 TO_CHARPOS.
640c8776
SM
2926 (pos_visible_p): Support positions in bidi-reordered lines.
2927 Save and restore bidi cache.
0bb23927
EZ
2928
2929 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2930 (bidi_paragraph_info): Delete unused struct.
2931 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2932 (bidi_cache_start): New variable.
2933 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2934 to zero.
2935 (bidi_cache_fetch_state, bidi_cache_search)
2936 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2937 (bidi_cache_find, bidi_peek_at_next_level)
2938 (bidi_level_of_next_char, bidi_find_other_level_edge)
2939 (bidi_move_to_visually_next): Compare cache index with
2940 bidi_cache_start rather than with zero.
2941 (bidi_fetch_char): Accept new argument STRING; all callers
2942 changed. Support iteration over a string. Support strings with
2943 display properties. Support unibyte strings. Fix the type of
2944 `len' according to what STRING_CHAR_AND_LENGTH expects.
2945 (bidi_paragraph_init, bidi_resolve_explicit_1)
2946 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2947 (bidi_level_of_next_char, bidi_move_to_visually_next):
2948 Support iteration over a string.
0bb23927
EZ
2949 (bidi_set_sor_type, bidi_resolve_explicit_1)
2950 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2951 can now be zero (for strings); special values 0 and -1 were
2952 changed to -1 and -2, respectively.
2953 (bidi_char_at_pos): New function.
2954 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2955 Call it instead of FETCH_MULTIBYTE_CHAR.
2956 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2957 initialized to valid values.
2958 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2959 values.
2960 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2961 the test for valid cached positions. Fix the logic for looking up
2962 the sentinel state in the cache. GCPRO the Lisp string we are
2963 iterating.
2964 (bidi_push_it, bidi_pop_it): New functions.
2965 (bidi_initialize): Initialize the bidi cache start stack pointer.
2966 (bidi_cache_ensure_space): New function, refactored from part of
2967 bidi_cache_iterator_state. Don't assume the required size is just
2968 one BIDI_CACHE_CHUNK away.
2969 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2970 (bidi_count_bytes, bidi_char_at_pos): New functions.
2971 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2972 always valid if bidi_cache_idx is valid.
2973 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2974 is valid if it's going to be used.
2975 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2976 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2977 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2978 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2979 (bidi_find_other_level_edge, bidi_cache_start_stack):
2980 All variables related to cache indices are now EMACS_INT.
c965adc5 2981
0bb23927
EZ
2982 * dispextern.h (struct bidi_string_data): New structure.
2983 (struct bidi_it): New member `string'. Make flag members be 1-bit
2984 fields, and put them last in the struct.
640c8776
SM
2985 (compute_display_string_pos, compute_display_string_end):
2986 Update prototypes.
0bb23927
EZ
2987 (bidi_push_it, bidi_pop_it): Add prototypes.
2988 (struct iterator_stack_entry): New members bidi_p,
2989 paragraph_embedding, and from_disp_prop_p.
2990 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2991 (bidi_shelve_cache, bidi_unshelve_cache):
2992 Declare prototypes.
0bb23927
EZ
2993
2994 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2995 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2996 and vector-like objects.
2997
2998 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2999 cache around display iteration.
3000
3001 * window.c (Fwindow_end, window_scroll_pixel_based)
3002 (displayed_window_lines, Frecenter): Save and restore the bidi
3003 cache around display iteration.
3004
3bbd2265
LMI
30052011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3006
3007 * editfns.c (Fdelete_region): Clarify the use of the named
3008 parameters (bug#6788).
3009
adc47434
MR
30102011-07-14 Martin Rudalics <rudalics@gmx.at>
3011
3012 * indent.c (Fvertical_motion): Set and restore w->pointm when
3013 saving and restoring the window's buffer (Bug#9006).
3014
837c31f8
LMI
30152011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3016
3017 * editfns.c (Fstring_to_char): Clarify just what is returned
3018 (bug#6576). Text by Eli Zaretskii.
3019
ac389d0c
JB
30202011-07-13 Juanma Barranquero <lekktu@gmail.com>
3021
3022 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3023
0be0ce47
EZ
30242011-07-13 Eli Zaretskii <eliz@gnu.org>
3025
3026 * buffer.c (mmap_find): Fix a typo.
3027
cd18e7e3
JB
30282011-07-13 Johan Bockgård <bojohan@gnu.org>
3029
3030 Fix execution of x selection hooks.
3031 * xselect.c (Qx_lost_selection_functions)
3032 (Qx_sent_selection_functions): New vars.
3033 (syms_of_xselect): DEFSYM them.
3034 (x_handle_selection_request): Pass Qx_sent_selection_functions
3035 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3036 (x_handle_selection_clear,x_clear_frame_selections):
3037 Pass Qx_lost_selection_functions rather than
3038 Vx_lost_selection_functions to Frun_hook_with_args.
3039
47ea7f44
PE
30402011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3041
ac389d0c 3042 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3043 The old code sometimes used this field without initializing it.
3044
47ea7f44
PE
3045 * alloc.c (gc_sweep): Don't read past end of array.
3046 In theory, the old code could also have corrupted Emacs internals,
3047 though it'd be very unlikely.
3048
bc985c87
AS
30492011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3050
3051 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3052 argument. (Bug#4026)
bc985c87 3053
0cf34688
LMI
30542011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3055
b3dadd76
LMI
3056 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3057 key" (bug#4257).
3058
0cf34688
LMI
3059 * window.c (Fset_window_start): Doc fix (bug#4199).
3060 (Fset_window_hscroll): Ditto.
3061
270768cd
PE
30622011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3063
077e3dda 3064 Fix minor new problems caught by GCC 4.6.1.
270768cd 3065 * term.c (init_tty): Remove unused local.
490011a6 3066 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3067 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3068 not used otherwise.
270768cd 3069
b1f58454
CY
30702011-07-12 Chong Yidong <cyd@stupidchicken.com>
3071
3072 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3073
22b9578d
LMI
30742011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3075
6e70ab07
LMI
3076 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3077 are the mini-buffer and the echo area (bug#3320).
3078
22b9578d
LMI
3079 * term.c (init_tty): Remove support for supdup, c10 and perq
3080 terminals, which are no longer supported (bug#1482).
3081
8974cc9f
JB
30822011-07-10 Johan Bockgård <bojohan@gnu.org>
3083
3084 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3085
a560d974
JD
30862011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3087
3088 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3089 for non-popups (Bug#3642).
3090
1dae0f0a
AS
30912011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3092
268c2c36 3093 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3094 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3095 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3096 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3097 * data.c (fmod): Likewise.
3098 * dispnew.c (swap_glyphs_in_rows): Likewise.
3099 * emacs.c (memory_warning_signal): Likewise.
3100 * floatfns.c (float_error): Likewise.
3101 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3102 (otf_open, font_otf_capability, generate_otf_features)
3103 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3104 Likewise.
3105 * image.c (pbm_read_file): Likewise.
3106 * indent.c (string_display_width): Likewise.
3107 * intervals.c (check_for_interval, search_for_interval)
3108 (inc_interval_count, count_intervals, root_interval)
3109 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3110 * lread.c (defalias): Likewise.
268c2c36 3111 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3112 * regex.c (set_image_of_range_1, set_image_of_range)
3113 (regex_grow_registers): Likewise.
3114 * sysdep.c (strerror): Likewise.
3115 * termcap.c (valid_filename_p, tprint, main): Likewise.
3116 * tparam.c (main): Likewise.
3117 * unexhp9k800.c (run_time_remap, save_data_space)
3118 (update_file_ptrs, read_header, write_header, calculate_checksum)
3119 (copy_file, copy_rest, display_header): Likewise.
3120 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3121 Likewise.
3122 * xdisp.c (check_it): Likewise.
3123 * xfaces.c (register_color, unregister_color, unregister_colors):
3124 Likewise.
3125 * xfns.c (print_fontset_result): Likewise.
3126 * xrdb.c (member, fatal, main): Likewise.
3127
99033785
PE
31282011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3129
3130 Fix minor problems found by static checking (Bug#9031).
3131 * chartab.c (char_table_set_range, map_sub_char_table):
3132 Remove unused locals.
3133 (uniprop_table): Now static.
3134 * composite.c (_work_char): Remove unused static var.
3135
9cb2ac56
JB
31362011-07-09 Juanma Barranquero <lekktu@gmail.com>
3137
3138 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3139
f25661f0
JD
31402011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3141
3142 * gtkutil.c (qttip_cb): Remove code without function.
3143
8278c4fe
EZ
31442011-07-09 Eli Zaretskii <eliz@gnu.org>
3145
3146 * w32.c (pthread_sigmask): New stub.
3147
1692ae2d 31482011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3149
8a6ebd58 3150 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3151 sigprocmask is portable only for single-threaded applications, and
3152 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3153 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3154 (LIBES): Use it.
3155 * callproc.c (Fcall_process):
3156 * process.c (create_process):
3157 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3158 Use pthread_sigmask, not sigprocmask.
123403e4 3159
1b854618
JD
31602011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3161
3162 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3163 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3164 wrong (Bug#8591).
3165
3fe4b549
JD
31662011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3167
0ce7e563
JD
3168 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3169 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3170 (xg_hide_tooltip): Fix comment.
3171
3fe4b549
JD
3172 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3173 in registerServicesMenuSendTypes.
3174 (validRequestorForSendType): Don't check ns_return_types.
3175
3176 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3177 ns_return_type.
3178
5df75e47
JR
31792011-07-08 Jason Rumney <jasonr@gnu.org>
3180
22610910
JR
3181 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3182 SH_SHOW for hidden windows (Bug#5482).
3183
5df75e47
JR
3184 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3185 frame struct members of non-existent frames (Bug#6284).
3186
699c10bd
JD
31872011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3188
4393663b
JD
3189 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3190 variable firstTime not needed on OSX >= 10.6.
3191 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3192 >= 10.5. Use setKnobProportion, setDoubleValue.
3193
3194 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3195 (MAC_OS_X_VERSION_10_5): Define if not defined.
3196 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3197 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3198 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3199
3200 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3201 cString and lossyCString on OSX >= 10.4
3202
58179cce 3203 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3204 sizeToFit on OSX >= 10.2.
3205
3206 * nsimage.m (allocInitFromFile): Don't use deprecated method
3207 bestRepresentationForDevice on OSX >= 10.6.
3208
3209 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3210 to avoid warning.
3211
3212 * emacs.c: Declare unexec_init_emacs_zone.
3213
a63e0781
JD
3214 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3215
699c10bd
JD
3216 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3217
3218 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3219 on svcsMenu (Bug#8842).
3220
3221 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3222 ns_return_types.
3223 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3224
3225 * nsterm.m (QUTF8_STRING): Declare.
3226 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3227 (validRequestorForSendType): Return type is (id).
3228 Change indexOfObjectIdenticalTo to indexOfObject.
3229 Check if we have local selection before returning self (Bug#8842).
3230 (writeSelectionToPasteboard): Put local selection into paste board
3231 if we have a local selection (Bug#8842).
3232 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3233
3234 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3235 (ns_get_local_selection): Declare.
3236
54e10184
LMI
32372011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3238
9888ff71
LMI
3239 * keymap.c (describe_map_tree): Don't insert a double newline at
3240 the end of the buffer (bug#1169) and return whether we inserted
3241 something.
3242
54e10184
LMI
3243 * callint.c (Fcall_interactively): Change "reading args" to
3244 "providing args" to try to clarify what it does (bug#1010).
3245
15fa4783
KH
32462011-07-07 Kenichi Handa <handa@m17n.org>
3247
3248 * composite.c (composition_compute_stop_pos): Ignore a static
3249 composition starting before CHARPOS (Bug#8915).
3250
3251 * xdisp.c (handle_composition_prop): Likewise.
3252
a8815b00
EZ
32532011-07-07 Eli Zaretskii <eliz@gnu.org>
3254
3255 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3256 (Bug#9015)
3257
ef7b981d 32582011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3259
3260 * character.h (unicode_category_t): New enum type.
3261
3262 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3263 (Qchar_code_property_table): New variable.
3264 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3265 (UNIPROP_COMPRESSED_FORM_P): New macros.
3266 (char_table_ascii): Uncompress the compressed values.
3267 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3268 Uncompress the compressed values.
ac389d0c 3269 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3270 (char_table_ref_and_range): Uncompress the compressed values.
3271 (sub_char_table_set): New arg is_uniprop. Callers changed.
3272 Uncompress the compressed values.
3273 (sub_char_table_set_range): Args changed. Callers changed.
3274 (char_table_set_range): Adjuted for the above change.
3275 (map_sub_char_table): Delete args default_val and parent. Add arg
3276 top. Give decoded values to a Lisp function.
640c8776 3277 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3278 values to a Lisp function. Gcpro more variables.
3279 (uniprop_table_uncompress)
3280 (uniprop_decode_value_run_length): New functions.
3281 (uniprop_decoder, uniprop_decoder_count): New variables.
3282 (uniprop_get_decoder, uniprop_encode_value_character)
3283 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3284 New functions.
3285 (uniprop_encoder, uniprop_encoder_count): New variables.
3286 (uniprop_get_encoder, uniprop_table)
3287 (Funicode_property_table_internal, Fget_unicode_property_internal)
3288 (Fput_unicode_property_internal): New functions.
3289 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3290 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3291 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3292 char-code-property-alist.
3293
640c8776 3294 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3295 Vunicode_category_table.
3296
640c8776 3297 * font.c (font_range): Adjust for the change of
c805dec0
KH
3298 Vunicode_category_table.
3299
76b397fb
DN
33002011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3301
3302 * m/iris4d.h: Remove file, move contents ...
3303 * s/irix6-5.h: ... here.
3304
22b4128e
PE
33052011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3306
3307 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3308 * alloc.c (mark_buffer):
3309 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3310 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3311 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3312 This isn't true in general, and it's particularly not true
3313 if Emacs is configured with --with-wide-int.
3314 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3315 New macros, used in the buffer.c change.
3316
869795d6
JD
33172011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3318
3319 * xsettings.c: Use both GConf and GSettings if both are available.
3320 (store_config_changed_event): Add comment.
3321 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3322 (store_tool_bar_style_changed): New functions.
5e617bc2 3323 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3324 (struct xsettings): Move font inside HAVE_XFT.
3325 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3326 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3327 Move inside HAVE_XFT.
640c8776 3328 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3329 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3330 also.
3331 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3332 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3333 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3334 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3335 (parse_settings): Move check for font inside HAVE_XFT.
3336 (read_settings, apply_xft_settings): Add comment.
3337 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3338 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3339 call store_font_name_changed.
3340 (xft_settings_event): Add comment.
3341 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3342 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3343 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3344 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3345 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3346 (xsettings_get_system_font, xsettings_get_system_normal_font):
3347 Add comment.
869795d6 3348
d8ed26bd
PE
33492011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3350
3351 Random fixes. E.g., (random) never returned negative values.
3352 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3353 subseconds part to the entropy, as that's a bit more random.
3354 Prefer signed to unsigned, since the signedness doesn't matter and
3355 in general we prefer signed. When given a limit, use a
3356 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3357 latter isn't right if USE_2_TAGS_FOR_INTS.
3358 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3359 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3360
cabf1cac
SM
33612011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3362
3363 * textprop.c (text_property_stickiness):
3364 Obey Vtext_property_default_nonsticky.
3365 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3366 * w32fns.c (syms_of_w32fns):
3367 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3368
6e9b2be9
PE
33692011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3370
3371 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3372 This is more efficient than Ffile_directory_p and avoids a minor race.
3373
90186c68
LMI
33742011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3375
7c301272
LMI
3376 * buffer.c (Foverlay_put): Say what the return value is
3377 (bug#7835).
3378
c4f2d8d4
LMI
3379 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3380 is a directory before asking whether to use the file name
3381 (bug#7564).
ad637907
LMI
3382 (barf_or_query_if_file_exists): Make the "File is a directory"
3383 error be more correct.
c4f2d8d4 3384
90186c68
LMI
3385 * fns.c (Frequire): Remove the mention of the .gz files, since
3386 that's installation-specific, but keep the mention of
3387 `get-load-suffixes'.
3388
da64016e
PE
33892011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3390
3391 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3392 Report string overflow if the output is too long.
3393
7d47b580
JB
33942011-07-04 Juanma Barranquero <lekktu@gmail.com>
3395
a555cb87
JB
3396 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3397 (syms_of_gnutls): Remove duplicate DEFSYM for
3398 Qgnutls_bootprop_verify_hostname_error, an error for
3399 Qgnutls_bootprop_verify_error (which is no longer used).
3400
7d47b580
JB
3401 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3402 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3403 Also (re)move comments that are misplaced or no longer relevant.
3404
1e49bfab
LMI
34052011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3406
3407 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3408
1485f4c0
CY
34092011-07-03 Chong Yidong <cyd@stupidchicken.com>
3410
3411 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3412 and background color parameters if they have been changed.
3413
a9ab721e
LMI
34142011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3415
3416 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3417
cf7cff57
PE
34182011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3419
2e13213d
PE
3420 * xsettings.c (SYSTEM_FONT): Define only when used.
3421 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3422
cf7cff57
PE
3423 * keymap.c (access_keymap_1): Now static.
3424
7a8e04f7
CY
34252011-07-02 Chong Yidong <cyd@stupidchicken.com>
3426
3427 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3428 leave any prefix arg for the up event (Bug#1586).
3429
61352f62
LMI
34302011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3431
69bb1ef7
LMI
3432 * lread.c (syms_of_lread): Mention single symbols defined by
3433 `defvar' or `defconst' (bug#7154).
3434
61352f62 3435 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3436 (Frequire): Mention get-load-suffixes.
61352f62 3437
28545e04
MR
34382011-07-02 Martin Rudalics <rudalics@gmx.at>
3439
3440 * window.h (window): Remove clone_number slot.
3441 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3442 Remove.
3443 (make_parent_window, make_window, saved_window)
3444 (Fset_window_configuration, save_window_save): Don't deal with
3445 clone numbers.
3446 * buffer.c (Qclone_number): Remove declaration.
3447 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3448
3349e122
SM
34492011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3450
3451 Add multiple inheritance to keymaps.
3452 * keymap.c (Fmake_composed_keymap): New function.
3453 (Fset_keymap_parent): Simplify.
3454 (fix_submap_inheritance): Remove.
3455 (access_keymap_1): New function extracted from access_keymap to handle
3456 embedded parents and handle lists of maps.
3457 (access_keymap): Use it.
3458 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3459 (Fcopy_keymap): Handle embedded parents.
3460 (Fcommand_remapping, define_as_prefix): Simplify.
3461 (Fkey_binding): Simplify.
3462 (syms_of_keymap): Move minibuffer-local-completion-map,
3463 minibuffer-local-filename-completion-map,
3464 minibuffer-local-must-match-map, and
3465 minibuffer-local-filename-must-match-map to Elisp.
3466 (syms_of_keymap): Defsubr make-composed-keymap.
3467 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3468 (parse_menu_item): Trivial simplification.
3469
3279eb87
GM
34702011-07-01 Glenn Morris <rgm@gnu.org>
3471
3472 * Makefile.in (SETTINGS_LIBS): Fix typo.
3473
4550efdf
KI
34742011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3475
3476 * coding.c (Fencode_coding_string): Record the last coding system
3477 used, as the function doc string says (bug#8738).
3478
0949d2b6
JD
34792011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3480
3481 * xsettings.c (store_monospaced_changed): Take new font as arg and
3482 check for change against current_mono_font.
3483 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3484 (emacs_settings_constructor, emacs_settings_get_property)
3485 (emacs_settings_set_property, emacs_settings_class_init)
3486 (emacs_settings_init, gsettings_obj): Remove.
3487 (something_changedCB): New function for HAVE_GSETTINGS.
3488 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3489 with value as argument.
3490 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3491 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3492 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3493 "changed".
3494
3495 * xgselect.c: Add defined (HAVE_GSETTINGS).
3496 (xgselect_initialize): Ditto.
3497
3498 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3499 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3500 xg_select.
3501
bbc6b304
PE
35022011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3503
3504 * eval.c (struct backtrace): Simplify and port the data structure.
3505 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3506 signed bit field, as this assumption is not portable and it makes
3507 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3508 "char debug_on_exit : 1" as this is not portable either; instead,
3509 use the portable "unsigned int debug_on_exit : 1". Remove unused
3510 member evalargs. Remove obsolete comments about cc bombing out.
3511
9851bfc5
JD
35122011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3513
51bb811f 3514 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3515 Let HAVE_GSETTINGS override HAVE_GCONF.
3516 (store_monospaced_changed): New function.
3517 (EMACS_SETTINGS): A new type derived from GObject to handle
3518 GSettings notifications.
3519 (emacs_settings_constructor, emacs_settings_get_property)
3520 (emacs_settings_set_property, emacs_settings_class_init):
3521 New functions.
3522 (gsettings_client, gsettings_obj): New variables.
3523 (GSETTINGS_SCHEMA): New define.
3524 (something_changedCB): Call store_monospaced_changed.
3525 (init_gsettings): New function.
3526 (xsettings_initialize): Call init_gsettings.
3527 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3528 to NULL.
3529
640c8776 3530 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3531 GCONF_CFLAGS/LIBS.
3532
5386012d
MR
35332011-06-29 Martin Rudalics <rudalics@gmx.at>
3534
3535 * window.c (resize_root_window, grow_mini_window)
3536 (shrink_mini_window): Rename Qresize_root_window to
3537 Qwindow_resize_root_window and Qresize_root_window_vertically to
3538 Qwindow_resize_root_window_vertically.
3539
f13e0b08
PE
35402011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3541
3542 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3543
94515237
JB
35442011-06-27 Juanma Barranquero <lekktu@gmail.com>
3545
3546 * makefile.w32-in: Redesign dependencies so they reflect more
3547 clearly which files are directly included by each source file,
3548 and not through other includes.
3549
e43b6e43
MR
35502011-06-27 Martin Rudalics <rudalics@gmx.at>
3551
3552 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3553 (sort_overlays, overlay_strings): When an overlay's clone number
3554 matches the window's clone number process the overlay even if
3555 the overlay's window property doesn't match the current window.
3556
d68443dc
MR
3557 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3558 (Fwindow_hchild): Rename to Fwindow_left_child.
3559 (Fwindow_next): Rename to Fwindow_next_sibling.
3560 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3561 (resize_window_check): Rename to window_resize_check.
3562 (resize_window_apply): Rename to window_resize_apply.
3563 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3564 (Fdelete_other_windows_internal, resize_frame_windows)
3565 (Fsplit_window_internal, Fdelete_window_internal)
3566 (grow_mini_window, shrink_mini_window)
3567 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3568
c7e73be5
JD
35692011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3570
3571 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3572 (emacs_fixed_set_min_size): Remove.
3573 (emacs_fixed_new): Take frame as argument.
3574
3575 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3576 (_EmacsFixedPrivate): Remove minwidth/height.
3577 Add struct frame *f.
3578 (emacs_fixed_init): Initialize priv->f.
3579 (get_parent_class, emacs_fixed_set_min_size): Remove.
3580 (emacs_fixed_new): Set priv->f to argument.
3581 (emacs_fixed_get_preferred_width)
3582 (emacs_fixed_get_preferred_height): Use min_width/height from
3583 frames size_hint to set minimum and natural (Bug#8919).
3584 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3585 and use min_width/height from frames size_hint to set
3586 min_width/height (Bug#8919).
3587
3588 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3589 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3590 Fix indentation.
c7e73be5 3591
cf99dcf8
EZ
35922011-06-26 Eli Zaretskii <eliz@gnu.org>
3593
3594 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3595 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3596 called at ZV.
3597
029529ac
CY
35982011-06-26 Chong Yidong <cyd@stupidchicken.com>
3599
3600 * process.c (wait_reading_process_output): Bypass select if
3601 waiting for a cell while ignoring keyboard input, and input is
3602 pending. Suggested by Jan Djärv (Bug#8869).
3603
7a7ef429
PE
36042011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3605
3606 Use gnulib's dup2 module instead of rolling our own.
3607 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3608
11fdef7d 36092011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3610
3611 * dispnew.c (scrolling_window): Before scrolling, turn off a
3612 mouse-highlight in the window being scrolled.
3613
cd3520a4
JB
36142011-06-24 Juanma Barranquero <lekktu@gmail.com>
3615
3616 Move DEFSYM to lisp.h and use everywhere.
3617
3618 * character.h (DEFSYM): Move declaration...
3619 * lisp.h (DEFSYM): ...here.
3620
3621 * gnutls.c:
3622 * minibuf.c:
3623 * w32menu.c:
3624 * w32proc.c:
3625 * w32select.c: Don't include character.h.
3626
3627 * alloc.c (syms_of_alloc):
3628 * buffer.c (syms_of_buffer):
3629 * bytecode.c (syms_of_bytecode):
3630 * callint.c (syms_of_callint):
3631 * casefiddle.c (syms_of_casefiddle):
3632 * casetab.c (init_casetab_once):
3633 * category.c (init_category_once, syms_of_category):
3634 * ccl.c (syms_of_ccl):
3635 * cmds.c (syms_of_cmds):
3636 * composite.c (syms_of_composite):
3637 * dbusbind.c (syms_of_dbusbind):
3638 * dired.c (syms_of_dired):
3639 * dispnew.c (syms_of_display):
3640 * doc.c (syms_of_doc):
3641 * editfns.c (syms_of_editfns):
3642 * emacs.c (syms_of_emacs):
3643 * eval.c (syms_of_eval):
3644 * fileio.c (syms_of_fileio):
3645 * fns.c (syms_of_fns):
3646 * frame.c (syms_of_frame):
3647 * fringe.c (syms_of_fringe):
3648 * insdel.c (syms_of_insdel):
3649 * keymap.c (syms_of_keymap):
3650 * lread.c (init_obarray, syms_of_lread):
3651 * macros.c (syms_of_macros):
3652 * msdos.c (syms_of_msdos):
3653 * print.c (syms_of_print):
3654 * process.c (syms_of_process):
3655 * search.c (syms_of_search):
3656 * sound.c (syms_of_sound):
3657 * syntax.c (init_syntax_once, syms_of_syntax):
3658 * terminal.c (syms_of_terminal):
3659 * textprop.c (syms_of_textprop):
3660 * undo.c (syms_of_undo):
3661 * w32.c (globals_of_w32):
3662 * window.c (syms_of_window):
3663 * xdisp.c (syms_of_xdisp):
3664 * xfaces.c (syms_of_xfaces):
3665 * xfns.c (syms_of_xfns):
3666 * xmenu.c (syms_of_xmenu):
3667 * xsettings.c (syms_of_xsettings):
3668 * xterm.c (syms_of_xterm): Use DEFSYM.
3669
4228cf16
TZ
36702011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3671
cd3520a4 3672 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3673
7fcccf1e
PE
36742011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3675
7efb4e0e
PE
3676 Integer and buffer overflow fixes (Bug#8873).
3677
ff5844ad
PE
3678 * print.c (printchar, strout): Check for string overflow.
3679 (PRINTPREPARE, printchar, strout):
3680 Don't set size unless allocation succeeds.
3681
90532f02
PE
3682 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3683 for sizes. Check for string overflow more accurately.
3684 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3685
6d84508d
PE
3686 * macros.c: Integer and buffer overflow fixes.
3687 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3688 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3689 Use ptrdiff_t, not int, for sizes.
3690 Don't increment bufsize until after realloc succeeds.
3691 Check for size-calculation overflow.
3692 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3693
437b2cb4
PE
3694 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3695
8b9ac8b4
PE
3696 * lread.c: Integer overflow fixes.
3697 (read_integer): Radix is now EMACS_INT, not int,
3698 to improve quality of diagnostics for out-of-range radices.
3699 Calculate buffer size correctly for out-of-range radices.
3700 (read1): Check for integer overflow in radices, and in
3701 read-circle numbers.
82cb60d3
PE
3702 (read_escape): Avoid int overflow.
3703 (Fload, openp, read_buffer_size, read1)
3704 (substitute_object_recurse, read_vector, read_list, map_obarray):
3705 Use ptrdiff_t, not int, for sizes.
3706 (read1): Use EMACS_INT, not int, for sizes.
20270765 3707 Check for size overflow.
8b9ac8b4 3708
7fcccf1e
PE
3709 * image.c (cache_image): Check for size arithmetic overflow.
3710
bfbbd7e7
PE
3711 * lread.c: Integer overflow issues.
3712 (saved_doc_string_size, saved_doc_string_length)
3713 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3714 Now ptrdiff_t, not int.
3715 (read1): Don't assume doc string length fits in int. Check for
3716 out-of-range doc string lengths.
3717 (read_list): Don't assume file position fits in int.
39019e54 3718 (read_escape): Check for hex character overflow.
bfbbd7e7 3719
4e323265
LL
37202011-06-22 Leo Liu <sdl.web@gmail.com>
3721
3722 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3723 Move to minibuffer.el.
3724
85fece3e
PE
37252011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3726
20b84ce9 3727 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3728 The following patches are for when GLYPH_DEBUG && !XASSERT.
3729 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3730 * dispnew.c (flush_stdout):
3731 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3732 Mark as externally visible.
3733 * dispnew.c (check_window_matrix_pointers): Now static.
3734 * dispnew.c (window_to_frame_vpos):
3735 * xfns.c (unwind_create_frame):
3736 * xterm.c (x_check_font): Remove unused local.
3737 * scroll.c (CHECK_BOUNDS):
3738 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3739 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3740 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3741 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3742 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3743 Now static.
3744 (debug_method_add): Use va_list and vsprintf rather than relying
3745 on undefined behavior with wrong number of arguments.
3746 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3747 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3748 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3749 since we're not interested in debugging glyphs with old libraries.
3750 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3751 GCC 4.6.0's static checking.
3752
0766b489
PE
37532011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3754
31fd4b32
PE
3755 Integer overflow and signedness fixes (Bug#8873).
3756 A few related buffer overrun fixes, too.
3757
b79e8648
PE
3758 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3759
0766b489
PE
3760 * dispextern.h (struct face.stipple):
3761 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3762 (x_bitmap_mask, x_allocate_bitmap_record)
3763 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3764 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3765 (x_create_bitmap_from_xpm_data):
3766 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3767 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3768 (.bitmaps_last):
3769 * xfaces.c (load_pixmap):
3770 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3771 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3772 (.bitmaps_last, struct x_output.icon_bitmap):
3773 Use ptrdiff_t, not int, for bitmap indexes.
3774 (x_allocate_bitmap_record): Check for size overflow.
3775 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3776
b081724f
PE
3777 Use ptrdiff_t, not int, for overlay counts.
3778 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3779 * editfns.c (overlays_around, get_pos_property):
3780 * textprop.c (get_char_property_and_overlay):
3781 * xdisp.c (next_overlay_change, note_mouse_highlight):
3782 * xfaces.c (face_at_buffer_position):
21514da7
PE
3783 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3784 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3785 (Fnext_overlay_change, Fprevious_overlay_change)
3786 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3787 Use ptrdiff_t, not int, for sizes.
21514da7 3788 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3789
3de73e5e
PE
3790 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3791
2606c57b
PE
3792 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3793 (x_session_initialize): Do not assume string length fits in int.
3794
aaafe47a
PE
3795 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3796 This is unlikely, but can occur if DPI is outlandish.
3797
2674ddc8 3798 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3799 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3800
28154962
PE
3801 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3802 * xrdb.c (magic_file_p, search_magic_path):
3803 Omit last arg SUFFIX; it was always 0. All callers changed.
3804 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3805
7de51af5
PE
3806 * xfont.c (xfont_match): Avoid need for strlen.
3807
25ed6cc3
PE
3808 * xfns.c: Don't assume strlen fits in int.
3809 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3810
4eab31dd
PE
3811 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3812 not unsigned long, as we prefer signed integers. All callers changed.
3813 Detect integer overflow in repeat count.
3814 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3815 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3816
171e2a58
PE
3817 * termcap.c: Don't assume sizes fit in int and never overflow.
3818 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3819 (gobble_line): Check for size-calculation overflow.
3820
ad39faca 3821 * minibuf.c (Fread_buffer):
6e5bb2dc 3822 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3823 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3824 Don't assume string length fits in int.
3825
52c61c22 3826 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3827 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3828
b5b8c9e5
PE
3829 * font.c: Don't assume string length fits in int.
3830 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3831 Use ptrdiff_t, not int.
ccd6111c
PE
3832 (font_intern_prop): Don't assume string length fits in int.
3833 Don't assume integer property fits in fixnum.
3834 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3835
882f0d81 3836 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3837 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3838 Reformulate so as not to need the command string.
3839 Invoke gzip -cd rather than gunzip, as it's more portable.
3840 (lock_info_type, lock_file_1, lock_file):
3841 Don't assume pid_t and time_t fit in unsigned long.
3842 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3843 (current_lock_owner): Prefer signed type for sizes.
3844 Use memcpy, not strncpy, where memcpy is what is really wanted.
3845 Don't assume (via atoi) that time_t and pid_t fit in int.
3846 Check for time_t and/or pid_t out of range, e.g., via a network share.
3847 Don't alloca where an auto var works fine.
3848
93f4cf88
PE
3849 * fileio.c: Fix some integer overflow issues.
3850 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3851 Don't assume string length fits in int.
3852 (directory_file_name): Don't assume string length fits in long.
3853 (make_temp_name): Don't assume pid fits in int, or that its print
3854 length is less than 20.
3855
f3e92b69
PE
3856 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3857
1bfdaf10
PE
3858 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3859
35016e9a
PE
3860 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3861
3d1e65a1
PE
3862 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3863 We prefer signed integers, even for size calculations.
3864
0b963a93
PE
3865 * emacs.c: Don't assume string length fits in 'int'.
3866 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3867 (main): Don't invoke strlen when not needed.
3868
573f4b54
PE
3869 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3870 (XD_DEBUG_MESSAGE): Don't waste a byte.
3871
989f33ba
PE
3872 * callproc.c (getenv_internal_1, getenv_internal)
3873 (Fgetenv_internal):
965d34eb
PE
3874 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3875
e4d29b33
PE
3876 * lread.c (invalid_syntax): Omit length argument.
3877 All uses changed. This doesn't fix a bug, but it simplifies the
3878 code away from its former Hollerith-constant appearance, and it's
3879 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3880 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3881
eb49b136
PE
3882 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3883 This didn't break anything, but it didn't help either.
3884 It's confusing to put a bogus integer in a place where the actual
3885 value does not matter.
9f62aeb1 3886 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3887 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3888
15375a22
PE
3889 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3890 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3891 implementation.
b61cc01c
PE
3892 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3893 We prefer signed types, and the value cannot exceed the EMACS_INT
3894 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3895 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3896 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3897 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3898
53b2623d
PE
3899 * indent.c (sane_tab_width): New function.
3900 (current_column, scan_for_column, Findent_to, position_indentation)
3901 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3902 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3903
51cab52b 3904 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3905
f2ed8a70
PE
3906 * lisp.h (lint_assume): New macro.
3907 * composite.c (composition_gstring_put_cache):
3908 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3909
abe80cc6
PE
3910 * editfns.c, insdel.c:
3911 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3912
b02c740e
PE
3913 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3914
ebc96716
PE
3915 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3916
b4e50fa0 3917 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3918 Use much-faster test for byte-length change.
311d5d7c 3919 Don't assume string byte-length fits in 'int'.
a4cf38e4 3920 Check that character arg fits in 'int'.
85461888 3921 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3922
c0c1ee9f
PE
3923 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3924
a498d7f4
PE
3925 * fns.c (concat): Catch string overflow earlier.
3926 Do not rely on integer wraparound.
3927
51cab52b
PE
3928 * dispextern.h (struct it.overlay_strings_charpos)
3929 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3930 * xdisp.c (forward_to_next_line_start)
3931 (back_to_previous_visible_line_start)
3932 (reseat_at_next_visible_line_start, next_element_from_buffer):
3933 Don't arbitrarily truncate the value of 'selective' to int.
3934
76031fad
PE
3935 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3936
5eb55db9
PE
3937 * composite.c: Don't truncate sizes to 'int'.
3938 (composition_gstring_p, composition_reseat_it)
3939 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3940 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3941 not EMACS_UINT, for indexes.
5eb55db9 3942
0703a717
PE
3943 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3944
d6202519
PE
3945 * buffer.c: Include <verify.h>.
3946 (struct sortvec.priority, struct sortstr.priority):
8961a454 3947 Now EMACS_INT, not int.
c20998a7 3948 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3949 (struct sortstr.size, record_overlay_string)
3950 (struct sortstrlist.size, struct sortlist.used):
3951 Don't truncate size to int.
3952 (record_overlay_string): Check for size-calculation overflow.
d6202519 3953 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3954
d5a19415
JM
39552011-06-22 Jim Meyering <meyering@redhat.com>
3956
029529ac 3957 Don't leak an XBM-image-sized buffer
d5a19415
JM
3958 * image.c (xbm_load): Free the image buffer after using it.
3959
a9041e6c
PE
39602011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3961
3962 Port to Sun C.
3963 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3964 that Sun C diagnosed.
3965 * fns.c (secure_hash): Fix pointer signedness issue.
3966 * intervals.c (static_offset_intervals): New function.
3967 (offset_intervals): Use it.
3968
7f3f739f
LL
39692011-06-21 Leo Liu <sdl.web@gmail.com>
3970
3971 * deps.mk (fns.o):
3972 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3973 sha512.h.
3974
3975 * fns.c (secure_hash): Rename from crypto_hash_function and change
3976 the first arg to accept symbols.
5b66d427 3977 (Fsecure_hash): New primitive.
7f3f739f
LL
3978 (syms_of_fns): New symbols.
3979
76147d94
DD
39802011-06-20 Deniz Dogan <deniz@dogan.se>
3981
3982 * process.c (Fset_process_buffer): Clarify return value in
3983 docstring.
3984
7d7d0045
CY
39852011-06-18 Chong Yidong <cyd@stupidchicken.com>
3986
3987 * dispnew.c (add_window_display_history): Use BVAR.
3988
3989 * xdisp.c (debug_method_add): Use BVAR.
3990 (check_window_end, dump_glyph_matrix, dump_glyph)
3991 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3992
3993 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3994 Likewise.
3995
3996 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3997 check till after the cache is created in init_frame_faces.
3998
ff2bc410
SM
39992011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4000
4001 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4002
28177add
PE
40032011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4004
dd3482fe
PE
4005 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4006 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4007 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4008
393d71f3 4009 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4010 * fileio.c (Finsert_file_contents):
4011 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4012 Remove the old (too-loose) buffer overflow checks.
4013 They weren't needed, since make_gap checks for buffer overflow.
4014 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4015 The old code merely checked for Emacs fixnum overflow, and relied
4016 on undefined (wraparound) behavior. The new code avoids undefined
4017 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4018
2e6813b0 4019 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4020 Tune. Don't use wider integers than needed. Don't use alloca.
4021 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4022
599a9e4f
PE
4023 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4024
99561444
PE
4025 * insdel.c, lisp.h (buffer_overflow): New function.
4026 (insert_from_buffer_1, replace_range, replace_range_2):
4027 * insdel.c (make_gap_larger):
4028 * editfns.c (Finsert_char):
4029 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4030
28177add
PE
4031 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4032
e69dafad
PE
40332011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4034
a7af7fde 4035 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4036
b1c46f02
PE
4037 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4038 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4039
e69dafad
PE
4040 * fileio.c: Don't assume EMACS_INT fits in off_t.
4041 (emacs_lseek): New static function.
4042 (Finsert_file_contents, Fwrite_region): Use it.
4043 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4044
566684ea
PE
4045 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4046
e6966cd6
PE
4047 * fns.c: Don't overflow int when computing a list length.
4048 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4049 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4050 truncation on 64-bit hosts. Check for QUIT every
4051 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4052 faster and is responsive enough.
4053 (Flength): Report an error instead of overflowing an integer.
4054 (Fsafe_length): Return a float if the value is not representable
4055 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4056 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4057 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4058
dd0b0efb
PE
4059 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4060 (header_size, word_size): New constants.
4061 (allocate_vectorlike): Don't check size overflow here.
4062 (allocate_vector): Check it here instead, since this is the only
4063 caller of allocate_vectorlike that could cause overflow.
4064 Check that the new vector's length is representable as a fixnum.
4065
86fe5cfe
PE
4066 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4067 The previous code was bogus. For example, next_almost_prime (32)
4068 returned 39, which is undesirable as it is a multiple of 3; and
4069 next_almost_prime (24) returned 25, which is a multiple of 5 so
4070 why was the code bothering to check for multiples of 7?
4071
80e88859
PE
4072 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4073
4a2f0ad6
PE
4074 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4075
f66c7cf8
PE
4076 Variadic C functions now count arguments with ptrdiff_t.
4077 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4078 Back then I didn't know that the Emacs coding style prefers signed int.
4079 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4080 were being counted with int, which may truncate counts on 64-bit
4081 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4082 * lisp.h (struct Lisp_Subr.function.aMANY)
4083 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4084 Arg counts are now ptrdiff_t, not size_t.
4085 All variadic functions and their callers changed accordingly.
4086 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4087 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4088 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4089 * callint.c (Fcall_interactively): Check arg count for overflow,
4090 to avoid potential buffer overrun. Use signed char, not 'int',
4091 for 'varies' array, so that we needn't bother to check its size
4092 calculation for overflow.
4093 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4094 * eval.c (apply_lambda):
4095 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4096 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4097 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4098
a1759b76
PE
4099 * callint.c (Fcall_interactively): Don't use index var as event count.
4100
d96be9fc
PE
4101 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4102 * mem-limits.h (SIZE): Remove; no longer used.
4103
a690a978 4104 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4105
578c21e6
PE
4106 Remove unnecessary casts.
4107 * xterm.c (x_term_init):
4108 * xfns.c (x_set_border_pixel):
4109 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4110 These aren't needed now that we assume ANSI C.
4111
96f53c6c
PE
4112 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4113 It's more likely to cause problems (due to unsigned overflow)
4114 than to cure them.
4115
83c77d31
PE
4116 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4117
ee2079f1
PE
4118 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4119
6da65536
PE
4120 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4121
7147c4a4
PE
4122 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4123
193e32d9
PE
4124 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4125
e5533da6
PE
4126 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4127
9910e595
PE
4128 GLYPH_CODE_FACE returns EMACS_INT, not int.
4129 * dispextern.h (merge_faces):
4130 * xfaces.c (merge_faces):
01103c44
PE
4131 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4132 Don't assume EMACS_INT fits in int.
9910e595 4133
2638320e
PE
4134 * character.h (CHAR_VALID_P): Remove unused parameter.
4135 * fontset.c, lisp.h, xdisp.c: All uses changed.
4136
045eb8d9
PE
4137 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4138
c1f134b5
PE
4139 * fns.c (concat): Minor tuning based on overflow analysis.
4140 This doesn't fix any bugs. Use int to hold character, instead
4141 of constantly refetching from Emacs object. Use XFASTINT, not
4142 XINT, for value known to be a character. Don't bother comparing
4143 a single byte to 0400, as it's always less.
4144
395fcb93 4145 * floatfns.c (Fexpt):
327eeec8
PE
4146 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4147
abbd3d23
PE
4148 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4149 for characters.
4150
684a03ef
PE
4151 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4152
0fed43f3
PE
4153 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4154 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4155 incorrectly succeed when S was a string, because 4294967386 was
4156 truncated before it was used.
4157
8fd02eb7
PE
4158 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4159 Otherwise, an out-of-range integer could cause undefined behavior
4160 on a 64-bit host.
4161
f8c86b69
PE
4162 * composite.c: Use int, not EMACS_INT, for characters.
4163 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4164 EMACS_INT, for values that are known to be in character range.
4165 This doesn't fix any bugs but is the usual style inside Emacs and
4166 may generate better code on 32-bit machines.
4167
34206dd2
PE
4168 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4169 This is for reasons similar to the recent CHAR_STRING fix.
4170 * charset.c (Fencode_char): Check that character arg is actually
4171 a character. Pass an int to ENCODE_CHAR.
4172 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4173 wider than 'int', as a compile-time check to prevent future regressions
4174 in this area.
4175
c5958d4c 4176 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4177
4178 Make sure a 64-bit char is never passed to CHAR_STRING.
4179 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4180 by silently ignoring the top 32 bits, allowing some values
4181 that were far too large to be valid characters.
4182 * character.h: Include <verify.h>.
4183 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4184 arguments are no wider than unsigned, as a compile-time check
4185 to prevent future regressions in this area.
4186 * data.c (Faset):
01103c44 4187 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4188 (Fsubst_char_in_region):
4189 * fns.c (concat):
4190 * xdisp.c (decode_mode_spec_coding):
4191 Adjust to CHAR_STRING's new requirement.
4192 * editfns.c (Finsert_char, Fsubst_char_in_region):
4193 * fns.c (concat): Check that character args are actually
4194 characters. Without this test, these functions did the wrong
4195 thing with wildly out-of-range values on 64-bit hosts.
4196
d37ca623
PE
4197 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4198 These casts should not be needed on 32-bit hosts, either.
4199 * keyboard.c (read_char):
4200 * lread.c (Fload): Remove casts to unsigned.
4201
ea204efb
PE
4202 * lisp.h (UNSIGNED_CMP): New macro.
4203 This fixes comparison bugs on 64-bit hosts.
4204 (ASCII_CHAR_P): Use it.
4205 * casefiddle.c (casify_object):
01103c44 4206 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4207 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4208 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4209 * dispextern.h (FACE_FROM_ID):
4210 * keyboard.c (read_char): Use UNSIGNED_CMP.
4211
41cb286c
PE
4212 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4213 not to EMACS_INT, to avoid GCC warning.
4214
4a1b9832
PE
4215 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4216
55daad71
PE
4217 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4218 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4219 isn't needed on 32-bit machines.
8f95c75c 4220
01103c44
PE
4221 * buffer.c (Fgenerate_new_buffer_name):
4222 Use EMACS_INT for count, not int.
0ceccced 4223 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4224
4225 * data.c (Qcompiled_function): Now static.
4226
c6f072e7
PE
4227 * window.c (window_body_lines): Now static.
4228
20ce5912
PE
4229 * image.c (gif_load): Rename local to avoid shadowing.
4230
9c4c5f81
PE
4231 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4232 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4233 * alloc.c (make_save_value): Integer argument is now of type
4234 ptrdiff_t, not int.
4235 (mark_object): Use ptrdiff_t, not int.
4236 * lisp.h (pD): New macro.
4237 * print.c (print_object): Use it.
4238
c0c5c8ae
PE
4239 * alloc.c: Use EMACS_INT, not int, to count objects.
4240 (total_conses, total_markers, total_symbols, total_vector_size)
4241 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4242 (total_free_floats, total_floats, total_free_intervals)
4243 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4244 Now EMACS_INT, not int. All uses changed.
4245 (Fgarbage_collect): Compute overall total using a double, so that
4246 integer overflow is less likely to be a problem. Check for overflow
4247 when converting back to an integer.
5a25e253
PE
4248 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4249 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4250 These were 'int' variables that could overflow on 64-bit hosts;
4251 they were never used, so remove them instead of repairing them.
211a0b2a 4252 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4253 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4254 Previously, this ceilinged at INT_MAX, but that doesn't work on
4255 64-bit machines.
e46bb31a 4256 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4257
c78baabf 4258 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4259 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4260 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4261 when a (possibly-narrower) signed value would do just as well.
4262 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4263
c9d624c6
PE
4264 * alloc.c: Catch some string size overflows that we were missing.
4265 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4266 for convenience in STRING_BYTES_MAX.
4267 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4268 The definition here is exact; the one in lisp.h was approximate.
4269 (allocate_string_data): Check for string overflow. This catches
4270 some instances we weren't catching before. Also, it catches
4271 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4272 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4273 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4274
c9d624c6
PE
4275 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4276 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4277 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4278
353032ce
PE
4279 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4280
2bccce07
PE
4281 * alloc.c (Fmake_string): Check for out-of-range init.
4282
0ac30604
SM
42832011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4284
4285 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4286
c195f2de
JD
42872011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4288
4289 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4290 xg_get_default_scrollbar_width.
4291
4292 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4293 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4294 (style_changed_cb): Call update_theme_scrollbar_width and call
4295 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4296 all frames (Bug#8505).
4297 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4298 Call gtk_window_set_resizable if HAVE_GTK3.
4299 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4300 and height if HAVE_GTK3 (Bug#8505).
4301 (scroll_bar_width_for_theme): New variable.
4302 (update_theme_scrollbar_width): New function.
4303 (xg_get_default_scrollbar_width): Move code to
4304 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4305 (xg_initialize): Call update_theme_scrollbar_width.
4306
4307 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4308
4309 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4310
e10ac9f1
MR
43112011-06-12 Martin Rudalics <rudalics@gmx.at>
4312
4313 * frame.c (make_frame): Call other_buffer_safely instead of
4314 other_buffer.
4315
4316 * window.c (temp_output_buffer_show): Call display_buffer with
4317 second argument Vtemp_buffer_show_specifiers and reset latter
4318 immediately after the call.
4319 (Vtemp_buffer_show_specifiers): New variable.
4320 (auto_window_vscroll_p, next_screen_context_lines)
4321 (Vscroll_preserve_screen_position): Remove leading asterisks from
4322 doc-strings.
4323
2d3c217e 43242011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4325
7b7f97e8 4326 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4327 * buffer.c (Qclone_number): Remove for now, as it's unused.
4328 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4329 (record_buffer): Remove unused local.
4330 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4331 (set_frame_buffer_list): Remove; unused.
4332 * frame.h (other_visible_frames): Remove decl.
4333 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4334 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4335 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4336 if HAVE_GPM.
4337 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4338 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4339 Define only if HAVE_GPM.
4340 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4341 (update_hints_inhibit): Remove; never set. All uses removed.
4342 * widgetprv.h (emacsFrameClassRec): Remove decl.
4343 * window.c (delete_deletable_window): Now returns void, since it
4344 wasn't returning anything.
4345 (compare_window_configurations): Remove unused locals.
4346 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4347 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4348 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4349 the same widths as pointers. This follows up on the 2011-05-06 patch.
4350 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4351 * xterm.h: Likewise.
4352 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4353
1384b89e
JB
43542011-06-12 Juanma Barranquero <lekktu@gmail.com>
4355
4356 * makefile.w32-in: Update dependencies.
4357 (LISP_H): Add lib/intprops.h.
4358
1100a63c
CY
43592011-06-11 Chong Yidong <cyd@stupidchicken.com>
4360
4361 * image.c (gif_load): Add animation frame delay to the metadata.
4362 (syms_of_image): Use DEFSYM. New symbol `delay'.
4363
6198ccd0
MR
43642011-06-11 Martin Rudalics <rudalics@gmx.at>
4365
4366 * window.c (delete_deletable_window): Re-add.
4367 (Fset_window_configuration): Rewrite to handle dead buffers and
4368 consequently deletable windows.
4369 (window_tree, Fwindow_tree): Remove. Supply functionality in
4370 window.el.
4371 (compare_window_configurations): Simplify code.
4372
b6e3633c
AS
43732011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4374
1ab0dee5
AS
4375 * image.c (imagemagick_load_image): Fix type mismatch.
4376 (Fimagemagick_types): Likewise.
4377
b6e3633c
AS
4378 * window.h (replace_buffer_in_windows): Declare.
4379
9397e56f
MR
43802011-06-11 Martin Rudalics <rudalics@gmx.at>
4381
4382 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4383 Qclone_number. Remove external declaration of Qdelete_window.
4384 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4385 code.
640c8776
SM
4386 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4387 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4388 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4389 buffer list implementation.
4390 (other_buffer_safely): New function.
4391 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4392 calls to replace_buffer_in_windows and
4393 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4394 if allowed.
4395 (record_buffer): Inhibit quitting and rewrite using quittable
4396 functions. Run Qbuffer_list_update_hook if allowed.
4397 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4398 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4399 Move switch-to-buffer to window.el.
9397e56f
MR
4400 (bury-buffer): Move to window.el.
4401 (Vbuffer_list_update_hook): New variable.
4402
4403 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4404 section.
4405
4406 * window.h (resize_frame_windows): Move up in code.
4407 (Fwindow_frame): Remove EXFUN.
4408 (replace_buffer_in_all_windows): Remove prototype.
4409 (replace_buffer_in_windows_safely): Add prototype.
4410
4411 * window.c: Declare Qdelete_window static again. Move down
4412 declaration of select_count.
4413 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4414 (Fother_window): Move to window.el.
4415 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4416 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4417 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4418 window.el.
4419 (replace_buffer_in_windows): Implement by calling
4420 Qreplace_buffer_in_windows.
4421 (replace_buffer_in_all_windows): Remove with some functionality
4422 moved into replace_buffer_in_windows_safely.
4423 (replace_buffer_in_windows_safely): New function.
4424 (select_window_norecord, select_frame_norecord): Move in front
4425 of run_window_configuration_change_hook. Remove now obsolete
4426 declarations.
640c8776
SM
4427 (Fset_window_buffer): Rewrite doc-string.
4428 Call Qrecord_window_buffer.
9397e56f
MR
4429 (keys_of_window): Move binding for other-window to window.el.
4430
b50691aa
CY
44312011-06-11 Chong Yidong <cyd@stupidchicken.com>
4432
4433 * dispextern.h (struct image): Replace data member, whose int_val
4434 and ptr_val fields were not used by anything, with a single
4435 lisp_val object.
4436
4437 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4438 (gif_clear_image, gif_load, imagemagick_load_image)
4439 (gs_clear_image, gs_load): Callers changed.
4440
3f754b86
PE
44412011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4442
cca69397
PE
4443 * buffer.h: Include <time.h>, for time_t.
4444 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4445
109e28d0
PE
4446 Fix minor problems found by static checking.
4447
60737f02
PE
4448 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4449
4b66faf3
PE
4450 Make identifiers static if they are not used in other modules.
4451 * data.c (Qcompiled_function, Qframe, Qvector):
4452 * image.c (QimageMagick, Qsvg):
4453 * minibuf.c (Qmetadata):
4454 * window.c (resize_window_check, resize_root_window): Now static.
4455 * window.h (resize_window_check, resize_root_window): Remove decls.
4456
109e28d0
PE
4457 * window.c (window_deletion_count, delete_deletable_window):
4458 Remove; unused.
46a4ce9e
PE
4459 (window_body_lines): Now static.
4460 (Fdelete_other_windows_internal): Mark vars as initialized.
4461 Make sure 'resize_failed' is initialized.
4462 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4463 (resize_window_apply): Remove unused local.
4464 * window.h (delete_deletable_window): Remove decl.
4465
109e28d0 4466 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4467 (imagemagick_load_image): Fix pointer signedness problem by changing
4468 last arg from unsigned char * to char *. All uses changed.
4469 Also, fix a local for similar reasons.
4470 Remove unused locals. Remove locals to avoid shadowing.
4471 (fn_rsvg_handle_free): Remove; unused.
4472 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4473 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4474
3f754b86
PE
4475 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4476
2547adb1
CY
44772011-06-10 Chong Yidong <cyd@stupidchicken.com>
4478
4479 * image.c (gif_load): Fix omitted cast error introduced by
4480 2011-06-06 change.
4481
2c8e37d4
MR
44822011-06-10 Martin Rudalics <rudalics@gmx.at>
4483
4484 * window.h (resize_proportionally, orig_total_lines)
4485 (orig_top_line): Remove from window structure.
4486 (set_window_height, set_window_width, change_window_heights)
4487 (Fdelete_window): Remove prototypes.
4488 (resize_frame_windows): Remove duplicate declaration.
4489
440a42e3
EZ
44902011-06-10 Eli Zaretskii <eliz@gnu.org>
4491
4492 * window.h (resize_frame_windows, resize_window_check)
4493 (delete_deletable_window, resize_root_window)
4494 (resize_frame_windows): Declare prototypes.
4495
4496 * window.c (resize_window_apply): Make definition be "static" to
4497 match the prototype.
4498
562dd5e9
MR
44992011-06-10 Martin Rudalics <rudalics@gmx.at>
4500
4501 * window.c: Remove declarations of Qwindow_size_fixed,
4502 window_min_size_1, window_min_size_2, window_min_size,
4503 size_window, window_fixed_size_p, enlarge_window, delete_window.
4504 Remove static from declaration of Qdelete_window, it's
4505 temporarily needed by Fbury_buffer.
4506 (replace_window): Don't assign orig_top_line and
4507 orig_total_lines.
4508 (Fdelete_window, delete_window): Remove. Window deletion is
4509 handled by window.el.
640c8776
SM
4510 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4511 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4512 (Fdelete_other_windows): Remove. Deleting other windows is
4513 handled by window.el.
4514 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4515 handled in window.el.
4516 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4517 Window minimum sizes are handled in window.el.
4518 (shrink_windows, size_window, set_window_height)
4519 (set_window_width, change_window_heights, window_height)
4520 (window_width, CURBEG, CURSIZE, enlarge_window)
4521 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4522 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4523 handled in window.el.
4524 (make_dummy_parent): Rename to make_parent_window and give it a
4525 second argument horflag.
4526 (make_window): Don't set resize_proportionally any more.
4527 (Fsplit_window): Remove. Windows are split in window.el.
4528 (save_restore_action, save_restore_orig_size)
4529 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4530 Resize mini windows in window.el.
4531 (grow_mini_window, shrink_mini_window): Implement by calling
4532 Qresize_root_window_vertically, resize_window_check and
4533 resize_window_apply.
640c8776
SM
4534 (saved_window, Fset_window_configuration, save_window_save):
4535 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4536 resize_proportionally.
4537 (window_min_height, window_min_width): Move to window.el.
4538 (keys_of_window): Move bindings for delete-other-windows,
4539 split-window, delete-window and enlarge-window to window.el.
4540
4541 * buffer.c: Temporarily extern Qdelete_window.
4542 (Fbury_buffer): Temporarily call Qdelete_window instead of
4543 Fdelete_window (Fbury_buffer will move to window.el soon).
4544
4545 * frame.c (set_menu_bar_lines_1): Remove code handling
4546 orig_top_line and orig_total_lines.
4547
4548 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4549 set_window_height but set heights directly.
4550 (change_frame_size_1): Use resize_frame_windows.
4551
4552 * xdisp.c (init_xdisp): Don't use set_window_height but set
4553 heights directly.
4554
640c8776
SM
4555 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4556 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4557 run_window_configuration_change_hook.
4558
4559 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4560 instead of change_window_heights and run
4561 run_window_configuration_change_hook.
4562
1a13852e
MR
45632011-06-09 Martin Rudalics <rudalics@gmx.at>
4564
4565 * window.c (replace_window): Rename second argument REPLACEMENT to
4566 NEW. New third argument SETFLAG. Rewrite.
4567 (delete_window, make_dummy_parent): Call replace_window with
4568 third argument 1.
4569 (window_list_1): Move down in code.
4570 (run_window_configuration_change_hook): Move set_buffer part
4571 before select_frame_norecord part in order to unwind correctly.
4572 Rename count1 to count.
4573 (recombine_windows, delete_deletable_window, resize_root_window)
4574 (Fdelete_other_windows_internal)
4575 (Frun_window_configuration_change_hook, make_parent_window)
4576 (resize_window_check, resize_window_apply, Fresize_window_apply)
4577 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4578 (Fdelete_window_internal, Fresize_mini_window_internal):
4579 New functions.
1a13852e
MR
4580 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4581
f3d1777e
MR
45822011-06-08 Martin Rudalics <rudalics@gmx.at>
4583
496e208e
MR
4584 * window.h (window): Add some new members to window structure -
4585 normal_lines, normal_cols, new_total, new_normal, clone_number,
4586 splits, nest, prev_buffers, next_buffers.
4587 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4588 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4589
f3d1777e
MR
4590 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4591 Remove.
496e208e
MR
4592 (make_dummy_parent): Set new members of windows structure.
4593 (make_window): Move down in code. Handle new members of window
4594 structure.
4595 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4596 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4597 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4598 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4599 (Fset_window_next_buffers, Fset_window_clone_number):
4600 New functions.
496e208e
MR
4601 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4602 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4603 Doc-string fixes.
4604 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4605 Argument WINDOW can be now internal window too.
4606 (Fwindow_use_time): Move up in code.
4607 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4608 Rewrite doc-string.
4609 (Fset_window_configuration, saved_window)
4610 (Fcurrent_window_configuration, save_window_save): Handle new
4611 members of window structure.
b9e809c2
MR
4612 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4613 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4614 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4615 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4616 Qget_mru_window, Qresize_root_window,
4617 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4618 Qauto_buffer_name; staticpro them.
f3d1777e 4619
abde8f8c
MR
46202011-06-07 Martin Rudalics <rudalics@gmx.at>
4621
4622 * window.c (Fwindow_total_size, Fwindow_left_column)
4623 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4624 (Fwindow_list_1): New functions.
4625 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4626 (Fwindow_width, Fscroll_left, Fscroll_right):
4627 Use window_body_cols instead of window_box_text_cols.
4628 (delete_window, Fset_window_configuration):
4629 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4630 (delete_all_subwindows): Take a window as argument and not a
4631 structure. Rewrite.
190b47e6
MR
4632 (window_loop): Remove handling of GET_LRU_WINDOW and
4633 GET_LARGEST_WINDOW.
4634 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4635
4636 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4637 window_box_text_cols. delete_all_subwindows now takes a
4638 Lisp_Object as argument.
abde8f8c 4639
640c8776
SM
4640 * indent.c (compute_motion, Fcompute_motion):
4641 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4642
fa8a67e6
MR
4643 * frame.c (delete_frame): Call delete_all_subwindows with root
4644 window as argument.
4645
a54e3482
DC
46462011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4647
4648 * fns.c (Fputhash): Document return value.
4649
60002bf5
CY
46502011-06-06 Chong Yidong <cyd@stupidchicken.com>
4651
4652 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4653
0c671da6 46542011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4655
b862a52a 4656 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4657
be44ca6c
PE
4658 Check for overflow when converting integer to cons and back.
4659 * charset.c (Fdefine_charset_internal, Fdecode_char):
4660 Use cons_to_unsigned to catch overflow.
4661 (Fencode_char): Use INTEGER_TO_CONS.
4662 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4663 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4664 * data.c (long_to_cons, cons_to_long): Remove.
4665 (cons_to_unsigned, cons_to_signed): New functions.
4666 These signal an error for invalid or out-of-range values.
4667 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4668 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4669 * font.c (Ffont_variation_glyphs):
4670 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4671 * lisp.h: Include <intprops.h>.
4672 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4673 (cons_to_signed, cons_to_unsigned): New decls.
4674 (long_to_cons, cons_to_long): Remove decls.
4675 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4676 (Fprimitive_undo): Use CONS_TO_INTEGER.
4677 * xfns.c (Fx_window_property): Likewise.
4678 * xselect.c: Include <limits.h>.
4679 (x_own_selection, selection_data_to_lisp_data):
4680 Use INTEGER_TO_CONS.
4681 (x_handle_selection_request, x_handle_selection_clear)
4682 (x_get_foreign_selection, Fx_disown_selection_internal)
4683 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4684 (lisp_data_to_selection_data): Use cons_to_unsigned.
4685 (x_fill_property_data): Use cons_to_signed.
4686 Report values out of range.
4687
d1f3d2af
PE
4688 Check for buffer and string overflow more precisely.
4689 * buffer.h (BUF_BYTES_MAX): New macro.
4690 * lisp.h (STRING_BYTES_MAX): New macro.
4691 * alloc.c (Fmake_string):
4692 * character.c (string_escape_byte8):
4693 * coding.c (coding_alloc_by_realloc):
4694 * doprnt.c (doprnt):
4695 * editfns.c (Fformat):
4696 * eval.c (verror):
4697 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4698 since they may not be the same number.
4699 * editfns.c (Finsert_char):
4700 * fileio.c (Finsert_file_contents):
4701 Likewise for BUF_BYTES_MAX.
4702
dd52fcea
PE
4703 * image.c: Use ptrdiff_t, not int, for sizes.
4704 (slurp_file): Switch from int to ptrdiff_t.
4705 All uses changed.
4706 (slurp_file): Check that file size fits in both size_t (for
4707 malloc) and ptrdiff_t (for sanity and safety).
4708
7f9bbdbb
PE
4709 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4710 if b->modtime has its maximal value.
4711
dfe18f82
PE
4712 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4713
84acfcf0
PE
4714 Don't assume time_t can fit into int.
4715 * buffer.h (struct buffer.modtime): Now time_t, not int.
4716 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4717 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4718
ccd9a01a
PE
4719 Minor fixes for signed vs unsigned integers.
4720 * character.h (MAYBE_UNIFY_CHAR):
4721 * charset.c (maybe_unify_char):
4722 * keyboard.c (read_char, reorder_modifiers):
4723 XINT -> XFASTINT, since the integer must be nonnegative.
4724 * ftfont.c (ftfont_spec_pattern):
4725 * keymap.c (access_keymap, silly_event_symbol_error):
4726 XUINT -> XFASTINT, since the integer must be nonnegative.
4727 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4728 since it makes no difference and we prefer signed.
4729 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4730 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4731 nonnegative.
4732
d6d100dd
SM
47332011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4734
4735 * window.h (Fwindow_frame): Declare.
4736
2b6148e4
PE
47372011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4738
4739 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4740 (SPARE_MEMORY): Always define.
4741 (LARGE_REQUEST): Remove.
4742 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4743
f230ecc9
MR
47442011-06-06 Martin Rudalics <rudalics@gmx.at>
4745
727e958e
MR
4746 * lisp.h: Move EXFUNS for Fframe_root_window,
4747 Fframe_first_window and Fset_frame_selected_window to window.h.
4748
4749 * window.h: Move EXFUNS for Fframe_root_window,
4750 Fframe_first_window and Fset_frame_selected_window here from
4751 lisp.h.
4752
4753 * frame.c (Fwindow_frame, Fframe_first_window)
4754 (Fframe_root_window, Fframe_selected_window)
4755 (Fset_frame_selected_window): Move to window.c.
4756 (Factive_minibuffer_window): Move to minibuf.c.
4757 (Fother_visible_frames_p): New function.
4758
4759 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4760
f230ecc9
MR
4761 * window.c (decode_window, decode_any_window): Move up in code.
4762 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4763 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4764 (Fwindow_buffer): Move up and rewrite doc-string.
4765 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4766 (Fwindow_prev): New functions.
727e958e
MR
4767 (Fwindow_frame): Move here from frame.c. Accept any window as
4768 argument.
4769 (Fframe_root_window, Fframe_first_window)
4770 (Fframe_selected_window): Move here from frame.c. Accept frame
4771 or arbitrary window as argument. Update doc-strings.
4772 (Fminibuffer_window): Move up in code.
4773 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4774 (Fset_frame_selected_window): Move here from frame.c.
4775 Marginal rewrite.
727e958e
MR
4776 (Fselected_window, select_window, Fselect_window): Move up in
4777 code. Minor doc-string fixes.
f230ecc9 4778
4d09bcf6
PE
47792011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4780
4781 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4782 Do not assume that spare memory exists; that assumption is valid
4783 only if SYSTEM_MALLOC.
4784 (LARGE_REQUEST): New macro, so that the issue of large requests
4785 is separated from the issue of spare memory.
4786
810928a2
AS
47872011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4788
172418ad
AS
4789 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4790 format. (Bug#8806)
4791
43f862f7
AS
4792 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4793
810928a2
AS
4794 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4795 before statements.
4796
a059fe24
JD
47972011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4798
4799 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4800
4801 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4802
4803 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4804 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4805
989bf368
JB
48062011-06-05 Juanma Barranquero <lekktu@gmail.com>
4807
4808 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4809
4b80f674
CY
48102011-06-04 Chong Yidong <cyd@stupidchicken.com>
4811
4812 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4813 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4814 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4815 New error handlers.
4b80f674
CY
4816 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4817 Obey Vx_select_enable_clipboard_manager. Catch errors in
4818 x_clipboard_manager_save (Bug#8779).
4819 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4820 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4821
99a33b77 48222011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4823
4824 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4825
99a33b77 48262011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4827
4828 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4829 in the current matrix if keep_current_p is non-zero.
4830
8264569d
EZ
48312011-06-04 Eli Zaretskii <eliz@gnu.org>
4832
4833 * bidi.c (bidi_level_of_next_char): Fix last change.
4834
57f97249
EZ
48352011-06-03 Eli Zaretskii <eliz@gnu.org>
4836
fec2107c 4837 Support bidi reordering of text covered by display properties.
57f97249 4838
fec2107c
EZ
4839 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4840 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4841 (bidi_cache_search, bidi_cache_iterator_state)
4842 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4843 (bidi_level_of_next_char, bidi_move_to_visually_next):
4844 Support character positions inside a run of characters covered by a
fec2107c
EZ
4845 display string.
4846 (bidi_paragraph_init, bidi_resolve_explicit_1)
4847 (bidi_level_of_next_char): Call bidi_fetch_char and
4848 bidi_fetch_char_advance instead of FETCH_CHAR and
4849 FETCH_CHAR_ADVANCE.
4850 (bidi_init_it): Initialize new members.
4851 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4852 definitions.
4853 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4854 instead of using explicit *_CHAR codes.
d6d100dd
SM
4855 (bidi_resolve_explicit, bidi_resolve_weak):
4856 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4857 bidirectional text is supported only in multibyte buffers.
4858 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4859 it to initialize the frame_window_p member of struct bidi_it.
4860 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4861 (bidi_resolve_explicit, bidi_resolve_weak)
4862 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4863 bidi_it->nchars is non-positive.
4864 (bidi_level_of_next_char): Don't try to lookup the cache for the
4865 next/previous character if nothing is cached there yet, or if we
4866 were just reseat()'ed to a new position.
c40e2fb2 4867
0e14fe90
EZ
4868 * xdisp.c (set_cursor_from_row): Set start and stop points
4869 according to the row's direction when priming the loop that looks
4870 for the glyph on which to display cursor.
4871 (single_display_spec_intangible_p): Function deleted.
4872 (display_prop_intangible_p): Reimplement to call
4873 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4874 Accept 3 additional arguments needed by handle_display_spec.
4875 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4876 values: lists, `(when COND...)' forms, etc.
4877 (single_display_spec_string_p): Support property values that are
4878 lists with the argument STRING its top-level element.
4879 (display_prop_string_p): Fix the condition for processing a
4880 property that is a list to be consistent with handle_display_spec.
fec2107c 4881 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4882 last portion of handle_display_prop.
4883 (compute_display_string_pos): Accept additional argument
4884 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4885 value of a `display' property is a "replacing spec".
4886 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4887 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4888 the display property, but just return a value indicating whether
4889 the display property will replace the characters it covers.
4890 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4891 frame_window_p members of struct bidi_it.
d6d100dd
SM
4892 (compute_display_string_pos, compute_display_string_end):
4893 New functions.
fec2107c
EZ
4894 (push_it): Accept second argument POSITION, where pop_it should
4895 jump to continue iteration.
4896 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4897
fec2107c
EZ
4898 * keyboard.c (adjust_point_for_property): Adjust the call to
4899 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4900
4901 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4902 (bidi_init_it): Update prototypes.
4903 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4904 (compute_display_string_pos, compute_display_string_end):
4905 Declare prototypes.
fec2107c
EZ
4906 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4907 EMACS_INT.
fc6f18ce 4908
40087514 49092011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4910
57f53182
PE
4911 Malloc failure behavior now depends on size of allocation.
4912 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4913 * lisp.h: Change signatures accordingly.
4914 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4915 All callers changed. (Bug#8762)
4916
4917 * gnutls.c: Use Emacs's memory allocators.
4918 Without this change, the gnutls library would invoke malloc etc.
4919 directly, which causes problems on non-SYNC_INPUT hosts, and which
4920 runs afoul of improving memory_full behavior. (Bug#8761)
4921 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4922 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4923 xfree instead of the default malloc, realloc, free.
4924 (Fgnutls_boot): No need to check for memory allocation failure,
4925 since xmalloc does that for us.
4926
ac32cd99 4927 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4928 * category.c (hash_get_category_set):
4929 * ccl.c (ccl_driver):
4930 * charset.c (Fdefine_charset_internal):
4931 * charset.h (struct charset.hash_index):
4932 * composite.c (get_composition_id, gstring_lookup_cache)
4933 (composition_gstring_put_cache):
4934 * composite.h (struct composition.hash_index):
4935 * dispextern.h (struct image.hash):
4936 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4937 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4938 (hashfn_equal, hashfn_user_defined, make_hash_table)
4939 (maybe_resize_hash_table, hash_lookup, hash_put)
4940 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4941 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4942 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4943 * image.c (make_image, search_image_cache, lookup_image)
4944 (xpm_put_color_table_h):
4945 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4946 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4947 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4948 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4949 * alloc.c (allocate_vectorlike):
4950 Check for overflow in vector size calculations.
4951 * ccl.c (ccl_driver):
4952 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4953 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4954 need to be updated by these changes.
40087514
PE
4955 * fns.c (make_hash_table, maybe_resize_hash_table):
4956 Check for integer overflow with large hash tables.
0de4bb68
PE
4957 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4958 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4959 (SXHASH_REDUCE): New macro.
4960 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4961 Use it instead of discarding useful hash info with large hash values.
4962 (sxhash_float): New function.
4963 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4964 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4965 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4966 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4967 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4968 Adjust signatures to match updated version of code.
4969 (consing_since_gc): Now EMACS_INT, since a single hash table can
4970 use more than INT_MAX bytes.
4971
698d32e2
DN
49722011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4973
4974 Make it possible to build with GCC-4.6+ -O2 -flto.
4975
4976 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4977
fd6fa53f
SM
49782011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4979
4980 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4981 Call minibuffer-inactive-mode.
4982
864db017
JB
49832011-05-31 Juanma Barranquero <lekktu@gmail.com>
4984
4985 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4986 Update dependencies.
4987
2ad0baf4
DN
49882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4989
4990 * data.c (init_data): Remove code for UTS, this system is not
4991 supported anymore.
4992
4fcc2638
DN
49932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4994
4995 Don't force ./temacs to start in terminal mode.
4996
4997 * frame.c (make_initial_frame): Initialize faces in all cases, not
4998 only when CANNOT_DUMP is defined.
4999 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5000
c56e0fd5
DN
50012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5002
5003 * dispnew.c (add_window_display_history): Use const for the string
5004 pointer. Remove declaration, not needed.
5005
333d54da 50062011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5007
55d4c1b2 5008 Use 'inline', not 'INLINE'.
333d54da 5009 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5010 * alloc.c, fontset.c (INLINE): Remove.
5011 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5012 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5013 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5014 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5015 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5016
738db178
DN
50172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5018
5019 Make it possible to run ./temacs.
5020
5021 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5022 syms_of_callproc does the same thing. Remove test for
5023 "initialized", do it in the caller.
5024 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5025
620c53a6
SM
50262011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5027
5028 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5029 (read_minibuf): Use get_minibuffer.
5030 (syms_of_minibuf): Use DEFSYM.
5031 (Qmetadata): New var.
5032 * data.c (Qbuffer): Don't make it static.
5033 (syms_of_data): Use DEFSYM.
5034
e003a292
PE
50352011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5036
5037 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5038 (CCL_CODE_MIN): New macro.
5039
ed008a6d
PE
50402011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5041
3687c2ef
PE
5042 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5043
ed008a6d
PE
5044 * eval.c (Qdebug): Now static.
5045 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5046 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5047 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5048
d66c4c7c
CY
50492011-05-29 Chong Yidong <cyd@stupidchicken.com>
5050
5051 * image.c: Various fixes to ImageMagick code comments.
5052 (Fimagemagick_types): Doc fix.
5053
5fbc2025
PE
50542011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5055
0196f88a
PE
5056 Minor fixes prompted by GCC 4.6.0 warnings.
5057
5058 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5059
5fbc2025
PE
5060 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5061 (x_clipboard_manager_save_all): Move extern decl to ...
5062 * xterm.h: ... here, so that it can be checked for consistency.
5063
1dd3c2d9
CY
50642011-05-29 Chong Yidong <cyd@stupidchicken.com>
5065
5066 * xselect.c (x_clipboard_manager_save_frame)
5067 (x_clipboard_manager_save_all): New functions.
5068 (Fx_clipboard_manager_save): Lisp function deleted.
5069
5070 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5071 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5072
5073 * xterm.h: Update prototype.
5074
5ba6571d
WX
50752011-05-28 William Xu <william.xwl@gmail.com>
5076
5077 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5078 exiting (Bug#8239).
5079
3eaff834
JM
50802011-05-28 Jim Meyering <meyering@redhat.com>
5081
e1900994 5082 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5083 * fns.c (to_uchar): Define.
5084 (crypto_hash_function): Use it to convert some newly-signed
5085 variables to unsigned, to avoid sign-extension bugs. For example,
5086 without this change, (md5 "truc") would evaluate to
5087 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5088 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5089 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5090
0f6990a7
PE
50912011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5092
5093 Integer overflow fixes.
c8a9ca5a 5094
08686060
PE
5095 * dbusbind.c: Serial number integer overflow fixes.
5096 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5097 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5098 to hold a serial number that is too large for a fixnum.
5099 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5100 Check for serial numbers out of range. Decode any serial number
59568bf0 5101 that was so large that it became a float. (Bug#8722)
08686060 5102
2d1fc3c7
PE
5103 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5104 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5105 Use XFASTINT rather than XUINT when numbers are nonnegative.
5106 (xd_append_arg, Fdbus_method_return_internal):
5107 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5108 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5109 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5110 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5111 (Bug#8722)
2d1fc3c7 5112
c8a9ca5a
PE
5113 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5114
519e1d69
PE
5115 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5116
30569699
PE
5117 ccl: add integer overflow checks
5118 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5119 (IN_INT_RANGE): New macros.
5120 (ccl_driver): Use them to check for integer overflow when
5121 decoding a CCL program. Many of the new checks are whether XINT (x)
5122 fits in int; it doesn't always, on 64-bit hosts. The new version
5123 doesn't catch all possible integer overflows, but it's an
847044ea 5124 improvement. (Bug#8719)
30569699 5125
c11285dc
PE
5126 * alloc.c (make_event_array): Use XINT, not XUINT.
5127 There's no need for unsigned here.
5128
fdccd48e
PE
5129 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5130 This follows up to the 2011-05-06 change that substituted uintptr_t
5131 for EMACS_INT. This case wasn't caught back then.
5132
37910ab2
PE
5133 Rework Fformat to avoid integer overflow issues.
5134 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5135 now (part of C89). Include <verify.h>.
5136 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5137 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5138 (Fformat): Avoid the prepass trying to compute sizes; it was only
5139 approximate and thus did not catch overflow reliably. Instead, walk
5140 through the format just once, formatting and computing sizes as we go,
5141 checking for integer overflow at every step, and allocating a larger
5142 buffer as needed. Keep track separately whether the format is
5143 multibyte. Keep only the most-recently calculated precision, rather
5144 than them all. Record whether each argument has been converted to
5145 string. Use EMACS_INT, not int, for byte and char and arg counts.
5146 Support field widths and precisions larger than INT_MAX. Avoid
5147 sprintf's undefined behavior with conversion specifications such as %#d
5148 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5149 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5150 formatting out-of-range floating point numbers with int
9173deec 5151 formats. (Bug#8668)
37910ab2 5152
2e6578fb
PE
5153 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5154
0ae6bdee
PE
5155 * data.c: Avoid integer truncation in expressions involving floats.
5156 * data.c: Include <intprops.h>.
5157 (arith_driver): When there's an integer overflow in an expression
5158 involving floating point, convert the integers to floating point
5159 so that the resulting value does not suffer from catastrophic
5160 integer truncation. For example, on a 64-bit host (* 4
5161 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5162 Do not rely on undefined behavior after integer overflow.
5163
de883a70
PE
5164 merge count_size_as_multibyte, parse_str_to_multibyte
5165 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5166 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5167 Check for integer overflow.
5168 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5169 since it's now a duplicate of the other. This is more of
5170 a character than a buffer op, so better that it's in character.c.
5171 * fns.c, print.c: Adjust to above changes.
5172
2ff916cb
PE
51732011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5174
5175 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5176
f1b54466
PE
51772011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5178
fb1ac845
PE
5179 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5180 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5181 (x_clipboard_manager_save): Now static.
5182 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5183
f1b54466
PE
5184 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5185 (crypto_hash_function): Now static.
5186 Fix pointer signedness problems. Avoid unnecessary initializations.
5187
a9f737ee
CY
51882011-05-27 Chong Yidong <cyd@stupidchicken.com>
5189
5190 * termhooks.h (Vselection_alist): Make it terminal-local.
5191
5192 * terminal.c (create_terminal): Initialize it.
5193
5194 * xselect.c: Support for clipboard managers.
5195 (Vselection_alist): Move to termhooks.h as terminal-local var.
5196 (LOCAL_SELECTION): New macro.
5197 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5198 (symbol_to_x_atom): Remove gratuitous arg.
5199 (x_handle_selection_request, lisp_data_to_selection_data)
5200 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5201 (x_own_selection, x_get_local_selection, x_convert_selection):
5202 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5203 (some_frame_on_display): Delete unused function.
5204 (Fx_own_selection_internal, Fx_get_selection_internal)
5205 (Fx_disown_selection_internal, Fx_selection_owner_p)
5206 (Fx_selection_exists_p): New optional frame arg.
5207 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5208 (x_handle_selection_clear): Don't treat other terminals with the
5209 same keyboard specially. Use the terminal-local Vselection_alist.
5210 (x_clear_frame_selections): Use Frun_hook_with_args.
5211
5212 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5213
5214 * xterm.h: Add support for those atoms.
5215
e067f0c1
CY
52162011-05-26 Chong Yidong <cyd@stupidchicken.com>
5217
5218 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5219 (converted_selections, conversion_fail_tag): New global variables.
5220 (x_selection_request_lisp_error): Free the above.
5221 (x_get_local_selection): Remove unnecessary code.
5222 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5223 of converted selections stored in converted_selections.
5224 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5225 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5226 (x_convert_selection): New function.
5227 (x_handle_selection_event): Simplify.
5228 (x_get_foreign_selection): Don't ignore incoming requests while
5229 waiting for an answer; this will fail when we implement
5230 SAVE_TARGETS, and seems unnecessary anyway.
5231 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5232 (Vx_sent_selection_functions): Doc fix.
5233
0f4aebc0
LL
52342011-05-26 Leo Liu <sdl.web@gmail.com>
5235
5236 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5237
e61124cd
YM
52382011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5239
5240 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5241
5242 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5243 for fringe update if it has periodic bitmap.
ac389d0c 5244 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5245 and fringe_bitmap_periodic_p.
5246
5247 * fringe.c (get_fringe_bitmap_data): New function.
5248 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5249 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5250 row. Mark glyph row for fringe update if periodicity changed.
5251
5252 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5253 for fringe update unless it has periodic bitmap.
5254
f16d9837
KH
52552011-05-25 Kenichi Handa <handa@m17n.org>
5256
5257 * xdisp.c (get_next_display_element): Set correct it->face_id for
5258 a static composition.
5259
e1b90ef6
LL
52602011-05-24 Leo Liu <sdl.web@gmail.com>
5261
5262 * deps.mk (fns.o):
5263 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5264
5265 * fns.c (crypto_hash_function, Fsha1): New function.
5266 (Fmd5): Use crypto_hash_function.
5267 (syms_of_fns): Add Ssha1.
5268
7400048f
PE
52692011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5270
5271 * gnutls.c: Remove unused macros.
5272 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5273 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5274 Remove macros that are defined and never used.
5275 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5276
abb71cf4
CY
52772011-05-22 Chong Yidong <cyd@stupidchicken.com>
5278
5279 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5280 (Fx_get_selection_internal): Minor cleanup.
5281 (Fx_own_selection_internal): Rename arguments for consistency with
5282 select.el.
5283
6307db39
PE
52842011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5285
5286 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5287
f3d4e0a4
CY
52882011-05-22 Chong Yidong <cyd@stupidchicken.com>
5289
5290 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5291
4d8ade89
YM
52922011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5293
5294 * dispnew.c (scrolling_window): Don't exclude the case that the
5295 last enabled row in the desired matrix touches the bottom boundary.
5296
32078c8d
GM
52972011-05-21 Glenn Morris <rgm@gnu.org>
5298
5299 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5300 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5301 and add some more files.
32078c8d 5302
7285dc67
EZ
53032011-05-20 Eli Zaretskii <eliz@gnu.org>
5304
5305 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5306 report_file_error introduced by the change from 2011-05-07.
5307
89d1bd22
PE
53082011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5309
5310 * systime.h (Time): Define only if emacs is defined.
5311 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5312 where the include path doesn't have X11/X.h by default. See
5313 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5314
e23640bb 53152011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5316
5317 * composite.c (find_automatic_composition): Fix previous change.
5318
b9704ad9
GM
53192011-05-20 Glenn Morris <rgm@gnu.org>
5320
5321 * lisp.mk: New file, split from Makefile.in.
5322 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5323 (shortlisp): Remove.
5324 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5325
4a720484
GM
53262011-05-19 Glenn Morris <rgm@gnu.org>
5327
5328 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5329 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5330 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5331 (lisp): Set the order to that of loadup.el.
5332 (shortlisp): Make it a copy of $lisp.
5333 (SOME_MACHINE_LISP): Remove.
5334 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5335 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5336
a28d4396
KH
53372011-05-18 Kenichi Handa <handa@m17n.org>
5338
5339 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5340 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5341 (find_automatic_composition): Mostly rewrite for efficiency.
5342
a2b1fa8e
JB
53432011-05-18 Juanma Barranquero <lekktu@gmail.com>
5344
5345 * makefile.w32-in: Update dependencies.
5346
8e1f5610
CS
53472011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5348
5349 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5350 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5351
7025ee00 53522011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5353
cdfa6eab
PE
5354 Fix some integer overflow issues, such as string length overflow.
5355
06d6db33
PE
5356 * insdel.c (count_size_as_multibyte): Check for string overflow.
5357
2b4560a8
PE
5358 * character.c (lisp_string_width): Check for string overflow.
5359 Use EMACS_INT, not int, for string indexes and lengths; in
5360 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5361 the resulting string length overflows an EMACS_INT; instead,
5362 report a string overflow if no precision given. When checking for
5363 precision exhaustion, use a check that cannot possibly have
5364 integer overflow. (Bug#8675)
5365 * character.h (lisp_string_width): Adjust to new signature.
5366
cb93f9be
PE
5367 * alloc.c (string_overflow): New function.
5368 (Fmake_string): Use it. This doesn't change behavior, but saves
5369 a few bytes and will simplify future changes.
5370 * character.c (string_escape_byte8): Likewise.
5371 * lisp.h (string_overflow): New decl.
5372
1a1f3366
PE
5373 Fixups, following up to the user-interface timestamp change.
5374 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5375 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5376 * msdos.c (mouse_get_pos): Likewise.
5377 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5378 * w32gui.h (Time): Define by including "systime.h" rather than by
5379 declaring it ourselves. (Bug#8664)
5380
d4e3e4d3
PE
5381 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5382 * image.c (clear_image_cache): Likewise.
5383
f6a24d19
PE
5384 * term.c (term_mouse_position): Don't assume time_t wraparound.
5385
08dc5ae6
PE
5386 Be more systematic about user-interface timestamps.
5387 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5388 and sometimes 'EMACS_UINT', to represent these timestamps.
5389 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5390 This makes the code easier to follow, and makes it easier to catch
5391 integer overflow bugs such as Bug#8664.
5392 * frame.c (Fmouse_position, Fmouse_pixel_position):
5393 Use Time, not unsigned long, for user-interface timestamps.
5394 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5395 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5396 * keyboard.h (last_event_timestamp): Likewise.
5397 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5398 * menu.h (xmenu_show): Likewise.
5399 * term.c (term_mouse_position): Likewise.
5400 * termhooks.h (struct input_event.timestamp): Likewise.
5401 (struct terminal.mouse_position_hook): Likewise.
5402 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5403 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5404 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5405 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5406 what it was before.
5407 * menu.h, termhooks.h: Include "systime.h", for Time.
5408
8e55734a
PE
5409 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5410 Don't assume that the difference between two unsigned long values
5411 can fit into an integer. At this point, we know button_down_time
5412 <= event->timestamp, so the difference must be nonnegative, so
5413 there's no need to cast the result if double-click-time is
5414 nonnegative, as it should be; check that it's nonnegative, just in
5415 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5416 apart (about 25 days). (Bug#8664)
8e55734a 5417
841f1b75 5418 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5419 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5420
3e26f69c
PE
5421 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5422 that always fit in int. Use a sentinel instead of a counter, to
5423 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5424 * frame.h (struct frame): Use int for menu_bar_items_used
5425 instead of EMACS_INT, since it always fits in int.
3e26f69c 5426
5cc152c0
PE
5427 * menu.c (grow_menu_items): Check for int overflow.
5428
d89eb65e
PE
5429 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5430
5235bd3e
PE
5431 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5432 Before, the code was not consistent. These values cannot exceed
5433 2**31 - 1 so there's no need to make them unsigned.
5434 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5435 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5436 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5437 as modifiers.
5438 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5439
bc827e23
PE
5440 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5441 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5442 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5443 presumably because the widths might not match.
5444
78eb494e
PE
5445 * window.c (size_window): Avoid needless test at loop start.
5446
04f2d78b
CB
54472011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5448
5449 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5450
d2fc7e3d 54512011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5452
5453 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5454
d2fc7e3d 54552011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5456
5457 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5458 `width' to `bar_area_x' and `bar_area_width', respectively.
5459 (x_scroll_run): Take account of fringe background extension.
5460
04f2d78b
CB
5461 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5462 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5463 `bar_area_width', respectively.
5464 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5465 background extension.
5466
79b70037
GM
54672011-05-10 Jim Meyering <meyering@redhat.com>
5468
5469 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5470
2f142cc5
JB
54712011-05-10 Juanma Barranquero <lekktu@gmail.com>
5472
5473 * image.c (Finit_image_library): Return t for built-in image types,
5474 like pbm and xbm. (Bug#8640)
5475
57679c86
AS
54762011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5477
5478 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5479
888c9e86
EZ
54802011-05-07 Eli Zaretskii <eliz@gnu.org>
5481
b0512a1d
EZ
5482 * w32console.c (Fset_screen_color): Doc fix.
5483 (Fget_screen_color): New function.
5484 (syms_of_ntterm): Defsubr it.
5485
7285dc67
EZ
5486 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5487 unlink the temporary file if Fcall_process didn't create it in the
5488 first place.
5489 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5490 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5491 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5492 cue to call_process_cleanup not to close that handle.
5493
4d3fcc8e
BK
54942011-05-07 Ben Key <bkey76@gmail.com>
5495
5496 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5497 one of two shell specific rules, either bootstrap-temacs-CMD or
5498 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5499 to the previous implementation of the bootstrap-temacs rule.
5500 The bootstrap-temacs-CMD rule is similar to the previous
5501 implementation of the bootstrap-temacs rule except that it
5502 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5503 variable.
5504
5505 These changes, along with some changes to nt/configure.bat,
5506 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5507 earlier fix to add support for --cflags and --ldflags options
5508 that include quotes so that it works whether make uses cmd or
5509 sh as the shell.
5510
b4289b64
MA
55112011-05-06 Michael Albinus <michael.albinus@gmx.de>
5512
5513 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5514 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5515 is a constant.
5516 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5517 a string. Handle both cases.
5518 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5519 (Fdbus_register_method): Use Qinvalid_function.
5520
af4c0e28
JB
55212011-05-06 Juanma Barranquero <lekktu@gmail.com>
5522
5523 * makefile.w32-in: Update dependencies.
5524 (LISP_H): Add inttypes.h and stdin.h.
5525 (PROCESS_H): Add unistd.h.
5526
c51453d9
EZ
55272011-05-06 Eli Zaretskii <eliz@gnu.org>
5528
5529 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5530 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5531
8ff0ac3c 55322011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5533
4c4b566b
PE
5534 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5535
aab2b9b5
PE
5536 * term.c (vfatal): Remove stray call to va_end.
5537 It's not needed and the C Standard doesn't allow it here anyway.
5538
c378da0b
PE
5539 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5540 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5541
288b08c7
PE
5542 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5543 bytes.
5544
e3601888
PE
5545 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5546
db6c0e74
PE
5547 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5548
dd5963ea
PE
5549 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5550
88c9450f
PE
5551 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5552
2f9442b8
PE
5553 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5554
c032b5f8
PE
5555 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5556 * charset.c (Fdefine_charset_internal): Don't initialize
5557 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5558 32-bit int (Bug#8600).
a108c10b
PE
5559
5560 * lread.c (read_integer): Be more consistent with string-to-number.
5561 Use string_to_number to do the actual conversion; this avoids
5562 rounding errors and fixes some other screwups. Without this fix,
5563 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5564 (digit_to_number): Move earlier, for benefit of read_integer.
5565 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5566 not a digit in any supported base. (Bug#8602)
a108c10b 5567
ad5f9eea
PE
5568 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5569
aec1708a
PE
5570 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5571 to match comment at start of function. This also removes a
5572 GCC warning about overflow in a 32+64-bit port.
5573
47be4ab5
PE
5574 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5575
371cac43
PE
5576 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5577 Reported by Stefan Monnier in
5578 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5579 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5580 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5581
d01a7826
PE
5582 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5583 (EMACS_UINTPTR): Likewise, with uintptr_t.
5584
7fd47d5c
PE
5585 * lisp.h: Prefer 64-bit EMACS_INT if available.
5586 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5587 on 32-bit hosts that have 64-bit int, so that they can access
5588 large files.
122b0c86
PE
5589 However, temporarily disable this change unless the temporary
5590 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5591
8727937b
PE
5592 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5593
8ac068ac
PE
5594 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5595 This removes an assumption that EMACS_INT and long are the same
5596 width as pointers. The assumption is true for Emacs porting targets
5597 now, but we want to make other targets possible.
5598 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5599 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5600 In the rest of the code, change types of integers that hold casted
5601 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5602 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5603 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5604 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5605 No need to cast type when ORing.
5606 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5607 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5608 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5609 assume EMACS_INT is the same width as char *.
5610 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5611 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5612 Remove no-longer-needed casts.
5613 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5614 (xg_tool_bar_help_callback, xg_make_tool_item):
5615 Use EMACS_INTPTR to hold an integer
5616 that will be cast to void *; this can avoid a GCC warning
5617 if EMACS_INT is not the same width as void *.
5618 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5619 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5620 (current_message_1, set_message_1):
5621 Use a local to convert to proper width without a cast.
5622 * xmenu.c (dialog_selection_callback): Likewise.
5623
ede49d71
PE
5624 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5625 Also, don't assume VALBITS / RAND_BITS is less than 5,
5626 and don't rely on undefined behavior when shifting a 1 left into
5627 the sign bit.
5628 * lisp.h (get_random): Change signature to match.
5629
2f30ecd0
PE
5630 * lread.c (hash_string): Use size_t, not int, for hash computation.
5631 Normally we prefer signed values; but hashing is special, because
5632 it's better to use unsigned division on hash table sizes so that
5633 the remainder is nonnegative. Also, size_t is the natural width
5634 for hashing into memory. The previous code used 'int', which doesn't
5635 retain enough info to hash well into very large tables.
5636 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5637
2a866e7b
PE
5638 * dbusbind.c: Don't possibly lose pointer info when converting.
5639 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5640 Use XPNTR rather than XHASH, so that the high-order bits of
5641 the pointer aren't lost when converting through void *.
5642
51639eac
PE
5643 * eval.c (Fautoload): Don't double-shift a pointer.
5644
92394119
PE
5645 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5646
dbdb9a7c
JB
56472011-05-06 Juanma Barranquero <lekktu@gmail.com>
5648
5649 * gnutls.c (DEF_GNUTLS_FN):
5650 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5651
db7a0b4f
AS
56522011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5653
5654 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5655 marker. (Bug#8610)
5656
f7ff1b0f 56572011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5658
5659 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5660 New version that can reserve upto 2GB of heap space.
5661
f7ff1b0f 56622011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5663
5664 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5665
639c109b
TZ
56662011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5667
5668 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5669 `gnutls_certificate_set_x509_key_file'.
5670
d2127135
JB
56712011-05-05 Juanma Barranquero <lekktu@gmail.com>
5672
5673 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5674 Update dependencies.
5675
e968f4f3
JB
56762011-05-04 Juanma Barranquero <lekktu@gmail.com>
5677
5678 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5679 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5680 Remove unused parameter `fildes'.
5681 * process.c (read_process_output, send_process): Don't pass it.
5682
84d358f0
JB
56832011-05-04 Juanma Barranquero <lekktu@gmail.com>
5684
5685 Fix previous change: the library cache is defined in w32.c.
5686 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5687 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5688
0898ca10
JB
56892011-05-04 Juanma Barranquero <lekktu@gmail.com>
5690
5691 Implement dynamic loading of GnuTLS on Windows.
5692
5693 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5694 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5695 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5696 Declare.
5697
5698 * gnutls.c (Qgnutls_dll): Define.
5699 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5700 (gnutls_*): Declare function pointers.
5701 (init_gnutls_functions): New function to initialize function pointers.
5702 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5703 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5704 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5705 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5706 (emacs_gnutls_write, emacs_gnutls_read)
5707 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5708 (Fgnutls_available_p): New function.
5709 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5710 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5711 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5712
5713 * image.c: Include w32.h.
5714 (Vimage_type_cache): Delete.
5715 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5716 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5717 (w32_delayed_load): Move to w32.c.
5718
5719 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5720
5721 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5722 (w32_delayed_load): Move from image.c. When loading a library, record
5723 its filename in the :loaded-from property of the library id.
5724 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5725 Initialize and staticpro them.
5726 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5727
5728 * process.c: Include lisp.h before w32.h, not after.
5729 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5730 instead of gnutls_record_check_pending.
5731
5732 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5733
ff4de4aa
TZ
57342011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5735
5736 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5737 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5738 as passed in.
5739
abe95abb
JD
57402011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5741
5742 * xterm.c (x_set_frame_alpha): Do not set property on anything
5743 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5744
e16e55d4
JB
57452011-05-02 Juanma Barranquero <lekktu@gmail.com>
5746
5747 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5748
bafcf6a5
JB
57492011-05-02 Juanma Barranquero <lekktu@gmail.com>
5750
5751 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5752 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5753 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5754 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5755 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5756 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5757 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5758 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5759 (Qgnutls_bootprop_callbacks_verify): Make static.
5760
e7a6747f
AS
57612011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5762
19ed11ba
AS
5763 * callproc.c: Indentation fixup.
5764
e7a6747f 5765 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5766 (wait_for_termination, interruptible_wait_for_termination):
5767 Move after wait_for_termination_1.
e7a6747f 5768
1ef14cb4
LMI
57692011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5770
5771 * sysdep.c (interruptible_wait_for_termination): New function
5772 which is like wait_for_termination, but allows keyboard
5773 interruptions.
5774
5775 * callproc.c (Fcall_process): Add (:file "file") as an option for
5776 the STDOUT buffer.
5777 (Fcall_process_region): Ditto.
5778
330d880c
EZ
57792011-04-30 Eli Zaretskii <eliz@gnu.org>
5780
8db90b73
EZ
5781 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5782 rather than `XVECTOR (FOO)->size'.
5783
330d880c
EZ
5784 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5785 inttypes.h, as a gnulib replacement is used if it not available in
5786 system headers.
5787
15cbd324
EZ
57882011-04-21 Eli Zaretskii <eliz@gnu.org>
5789
5790 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5791 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5792 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5793
5794 * coding.c (coding_alloc_by_realloc): Error out if destination
5795 will grow beyond MOST_POSITIVE_FIXNUM.
5796 (decode_coding_emacs_mule): Abort if there isn't enough place in
5797 charbuf for the composition carryover bytes. Reserve an extra
5798 space for up to 2 characters produced in a loop.
5799 (decode_coding_iso_2022): Abort if there isn't enough place in
5800 charbuf for the composition carryover bytes.
5801
58022011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5803
ae940cca
EZ
5804 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5805 aborting when %lld or %lll format is passed.
5806 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5807 %llo or %llx format is passed. (Bug#8545)
5808
03ab8921
EZ
5809 * window.c (window_scroll_line_based): Use a marker instead of
5810 simple variables to record original value of point. (Bug#7952)
5811
afda1437
EZ
5812 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5813 produced by %s or %c overflows available buffer space. (Bug#8545)
5814
f76dee0c
PE
58152011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5816
5817 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5818 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5819
fdc5744d
JB
58202011-04-28 Juanma Barranquero <lekktu@gmail.com>
5821
5822 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5823
638f053a
JB
58242011-04-28 Juanma Barranquero <lekktu@gmail.com>
5825
5826 * keyboard.c (Qdelayed_warnings_hook): Define.
5827 (command_loop_1): Run `delayed-warnings-hook'
5828 if Vdelayed_warnings_list is non-nil.
5829 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5830 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5831
d178f871
EZ
58322011-04-28 Eli Zaretskii <eliz@gnu.org>
5833
5834 * doprnt.c (doprnt): Don't return value smaller than the buffer
5835 size if the message was truncated. (Bug#8545).
5836
b124fd93
JB
58372011-04-28 Juanma Barranquero <lekktu@gmail.com>
5838
5839 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5840 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5841
e810457d
PE
58422011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5843
5844 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5845
ea51cceb
JB
58462011-04-27 Juanma Barranquero <lekktu@gmail.com>
5847
5848 * makefile.w32-in: Update dependencies.
5849
94dcfacf
EZ
58502011-04-27 Eli Zaretskii <eliz@gnu.org>
5851
5852 Improve `doprnt' and its usage. (Bug#8545)
5853 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5854 `format_end'. Remove support for %l as a conversion specifier.
5855 Don't use xrealloc. Improve diagnostics when the %l size modifier
5856 is used. Update the commentary.
5857
5858 * eval.c (verror): Simplify calculation of size_t.
5859
5860 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5861 messages.
5862
f61f41d7
PE
58632011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5864
5865 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5866 change.
5867
96fb4434
PE
58682011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5869
5870 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5871 This makes this file independent of the recent pseudovector change.
5872
671875da 58732011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5874
69e9b5a3
PE
5875 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5876
b5f869a7 5877 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5878 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5879 Remove unused local.
c8926152 5880 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5881
841a1577 5882 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5883 GCC 4.6.0 optimizes based on type-based alias analysis.
5884 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5885 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5886 != &v->size, and therefore "v->size = 1; b->size = 2; return
5887 v->size;" must therefore return 1. This assumption is incorrect
5888 for Emacs, since it type-puns struct Lisp_Vector * with many other
5889 types. To fix this problem, this patch adds a new type struct
f904488f 5890 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5891 and pseudovectors, and helps optimizing compilers not get fooled
5892 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5893 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5894 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5895 the size member.
eab3844f
PE
5896 (XSETPVECTYPE): Rewrite in terms of new macro.
5897 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5898 This is a bit clearer, and further avoids the possibility of
5899 undesirable aliasing.
5900 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5901 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5902 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5903 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5904 (ASIZE): Now uses header.size rather than size.
5905 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5906 to avoid the hassle of writing XVECTOR (foo)->header.size.
5907 (struct vectorlike_header): New type.
eab3844f
PE
5908 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5909 object, to help avoid aliasing.
5910 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5911 (SUBRP): Likewise, since Lisp_Subr is a special case.
5912 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5913 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5914 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5915 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5916 changed to be "header.size" and "header.next".
5917 * buffer.h (struct buffer): Likewise.
5918 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5919 * frame.h (struct frame): Likewise.
5920 * process.h (struct Lisp_Process): Likewise.
5921 * termhooks.h (struct terminal): Likewise.
5922 * window.c (struct save_window_data, struct saved_window): Likewise.
5923 * window.h (struct window): Likewise.
5924 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5925 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5926 * buffer.c (init_buffer_once): Likewise.
5927 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5928 special case.
5929 * process.c (Fformat_network_address): Use local var for size,
5930 for brevity.
5931
0df1eac5
PE
5932 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5933
847ab9d1 5934 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5935 * data.c (atof): Remove decl; no longer used or needed.
5936 (digit_to_number): Move to lread.c.
5937 (Fstring_to_number): Use new string_to_number function, to be
5938 consistent with how the Lisp reader treats infinities and NaNs.
5939 Do not assume that floating-point numbers represent EMACS_INT
5940 without losing information; this is not true on most 64-bit hosts.
5941 Avoid double-rounding errors, by insisting on integers when
5942 parsing non-base-10 numbers, as the documentation specifies.
5943 * lisp.h (string_to_number): New decl, replacing ...
5944 (isfloat_string): Remove.
bc0a5c13 5945 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5946 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5947 appears to have been a coding error. Similarly, do not accept
5948 strings like +-1e0 as floating point numbers. Do not report
5949 overflow for integer overflows unless the base is not 10 which
5950 means we have no simple and reliable way to continue.
5951 Break out the floating-point parsing into a new
5952 function string_to_number, so that Fstring_to_number parses
5953 floating point numbers consistently with the Lisp reader.
04f2d78b 5954 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5955 (E_CHAR, EXP_INT): Remove, replacing with ...
5956 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5957 (string_to_number): New function, replacing isfloat_string.
5958 This function checks for valid syntax and produces the resulting
5959 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5960 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5961 so that overflow for non-base-10 numbers is reported only when
5962 there's no portable and simple way to convert to floating point.
452f4150 5963
67769ffc
PE
5964 * textprop.c (set_text_properties_1): Rewrite for clarity,
5965 and to avoid GCC warning about integer overflow.
5966
c20db43f
PE
5967 * intervals.h (struct interval): Use EMACS_INT for members
5968 where EMACS_UINT might cause problems. See
5969 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5970 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5971 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5972 All uses changed.
37aa2f85
PE
5973 (offset_intervals): Tell GCC not to worry about length overflow
5974 when negating a negative length.
c20db43f 5975
2538aa2f
PE
5976 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5977 (overrun_check_free): Likewise.
5978
f2d3008d
PE
5979 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5980 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5981 word size.
5982
ec8df744
PE
5983 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5984 (gnutls_make_error): Rename local to avoid shadowing.
5985 (gnutls_emacs_global_deinit): ifdef out; not used.
5986 (Fgnutls_boot): Use const for pointer to readonly storage.
5987 Comment out unused local. Fix pointer signedness problems.
5988
640ee02d
PE
5989 * lread.c (openp): Don't stuff size_t into an 'int'.
5990 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5991 about possible signed overflow.
5992
6048fb2a
PE
5993 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5994 (GDK_KEY_g): Don't define if already defined.
5995 (xg_prepare_tooltip): Avoid pointer signedness problem.
5996 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5997
fa3c87e1
PE
5998 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5999 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6000
2172544b
PE
6001 * xfns.c (Fx_window_property): Simplify a bit,
6002 to make a bit faster and to avoid GCC 4.6.0 warning.
6003 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6004
9b821a21
PE
6005 * fns.c (internal_equal): Don't assume size_t fits in int.
6006
3c616cfa
PE
6007 * alloc.c (compact_small_strings): Tighten assertion a little.
6008
c2982e87
PE
6009 Replace pEd with more-general pI, and fix some printf arg casts.
6010 * lisp.h (pI): New macro, generalizing old pEd macro to other
6011 conversion specifiers. For example, use "...%"pI"d..." rather
6012 than "...%"pEd"...".
6013 (pEd): Remove. All uses replaced with similar uses of pI.
6014 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6015 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6016 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6017 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6018 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6019 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6020 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6021 64-bit hosts.
6022 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6023 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6024 * print.c (safe_debug_print, print_object): Likewise.
6025 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6026 to int.
6f04d126
PE
6027 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6028 avoiding the 0 flag, which is not portable.
c2982e87
PE
6029 * process.c (Fmake_network_process): Use pI to avoid cast.
6030 * region-cache.c (pp_cache): Likewise.
6031 * xdisp.c (decode_mode_spec): Likewise.
6032 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6033 behavior on 64-bit hosts with printf arg.
6f04d126 6034 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6035 (x_stop_queuing_selection_requests): Likewise.
6036 (x_get_window_property): Don't truncate byte count to an 'int'
6037 when tracing.
0b432f21 6038
5e073ec7
PE
6039 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6040 here, since it parses constructs like leading '-' and spaces,
6041 which are not wanted; and it overflows with large numbers.
6042 Instead, simply match F[0-9]+, which is what is wanted anyway.
6043
36372bf9
PE
6044 * alloc.c: Remove unportable assumptions about struct layout.
6045 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6046 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6047 (allocate_vectorlike, make_pure_vector): Use the new macros,
6048 plus offsetof, to remove unportable assumptions about struct layout.
6049 These assumptions hold on all porting targets that I know of, but
6050 they are not guaranteed, they're easy to remove, and removing them
6051 makes further changes easier.
6052
0b432f21
PE
6053 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6054 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6055 (string_overrun_cookie): Now const. Use initializers that
6056 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6057 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6058 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6059 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6060 multiple of sizeof (EMACS_INT); it need not be, if
6061 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6062 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6063
895009e1
JB
60642011-04-26 Juanma Barranquero <lekktu@gmail.com>
6065
6066 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6067
6a7a1b0b
TZ
60682011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6069
6070 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6071 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6072 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6073
841a1577 60742011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6075
6076 * lisp.h (Qdebug): List symbol.
895009e1 6077 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6078 * keyboard.c (debug-on-event): New variable.
6079 (handle_user_signal): Break into debugger when debug-on-event
6080 matches the current signal symbol.
6081
f2d3ba6f
DN
60822011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6083
6084 * alloc.c (check_sblock, check_string_bytes)
6085 (check_string_free_list): Convert to standard C.
6086
42ce4c63
TZ
60872011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6088
6089 * w32.c (emacs_gnutls_push): Fix typo.
6090
825cd63c
EZ
60912011-04-25 Eli Zaretskii <eliz@gnu.org>
6092
fb11d64d
EZ
6093 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6094 "cast to pointer from integer of different size".
6095
825cd63c
EZ
6096 Improve doprnt and its use in verror. (Bug#8545)
6097 * doprnt.c (doprnt): Document the set of format control sequences
6098 supported by the function. Use SAFE_ALLOCA instead of always
6099 using `alloca'.
6100
6101 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6102 is one byte too soon. Don't use xrealloc; instead xfree and
6103 xmalloc anew.
6104
e061a11b
TZ
61052011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6106
6107 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6108 callbacks stage.
6109
6110 * gnutls.c: Renamed global_initialized to
6111 gnutls_global_initialized. Added internals for the
6112 :verify-hostname-error, :verify-error, and :verify-flags
6113 parameters of `gnutls-boot' and documented those parameters in the
6114 docstring. Start callback support.
9173deec
JB
6115 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6116 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6117 on error. Return error code.
e061a11b
TZ
6118 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6119 (emacs_gnutls_read): Likewise.
6120 (Fgnutls_boot): Return handshake error code.
6121 (emacs_gnutls_handle_error): New function.
6122 (wsaerror_to_errno): Likewise.
6123
6124 * w32.h (emacs_gnutls_pull): Add prototype.
6125 (emacs_gnutls_push): Likewise.
6126
6127 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6128 (emacs_gnutls_push): Likewise.
6129
61302011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6131
6132 * process.c (wait_reading_process_output): Check if GnuTLS
6133 buffered some data internally if no FDs are set for TLS
6134 connections.
6135
6136 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6137 (LIBS): Link to USER_LIBS.
6138 ($(BLD)/gnutls.$(0)): New target.
6139
fa6996bc
EZ
61402011-04-24 Eli Zaretskii <eliz@gnu.org>
6141
eb35682e
EZ
6142 * xdisp.c (handle_single_display_spec): Rename the
6143 display_replaced_before_p argument into display_replaced_p, to
6144 make it consistent with the commentary. Fix typos in the
6145 commentary.
6146
e2ad650c
EZ
6147 * textprop.c (syms_of_textprop): Remove dead code.
6148 (copy_text_properties): Delete obsolete commentary about an
6149 interface that was deleted long ago. Fix typos in the description
6150 of arguments.
6151
1b2de274
EZ
6152 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6153 to changes in oldXMenu/XMenu.h from 2011-04-16.
6154 <menu_help_message, prev_menu_help_message>: Constify.
6155 (IT_menu_make_room): menu->help_text is now `const char **';
6156 adjust.
6157
6158 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6159 to changes in oldXMenu/XMenu.h from 2011-04-16.
6160 (struct XMenu): Declare `help_text' `const char **'.
6161
6162 * xfaces.c <Qunspecified>: Make extern again.
6163
6164 * syntax.c: Include sys/types.h before including regex.h, as
6165 required by Posix.
6166
762b15be
EZ
6167 * doc.c (get_doc_string): Improve the format passed to `error'.
6168
6169 * doprnt.c (doprnt): Improve commentary.
6170
6171 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6172
6173 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6174 them with etags.
6175
f1052e5d
EZ
6176 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6177 changes in globals.h immediately force recompilation.
762b15be
EZ
6178 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6179 $(CURDIR)/s/ms-w32.h.
6180 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6181
fa6996bc
EZ
6182 * character.c (Fchar_direction): Function deleted.
6183 (syms_of_character): Don't defsubr it.
6184 <char-direction-table>: Deleted.
6185
e6c3da20
EZ
61862011-04-23 Eli Zaretskii <eliz@gnu.org>
6187
6188 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6189 * doprnt.c: Include limits.h.
6190 (SIZE_MAX): New macro.
04f2d78b
CB
6191 (doprnt): Return a size_t value. 2nd arg is now size_t.
6192 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6193 Improve overflow protection. Support `l' modifier for integer
6194 conversions. Support %l conversion. Don't assume an EMACS_INT
6195 argument for integer conversions and for %c.
6196
6197 * lisp.h (doprnt): Restore prototype.
6198
6199 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6200 $(SRC)/character.h.
6201
6202 * Makefile.in (base_obj): Add back doprnt.o.
6203
6204 * deps.mk (doprnt.o): Add back prerequisites.
6205 (callint.o): Depend on character.h.
6206
6207 * eval.c (internal_lisp_condition_case): Include the handler
6208 representation in the error message.
6209 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6210 when breaking from the loop.
6211
6212 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6213
6214 * callint.c (Fcall_interactively): When displaying error message
6215 about invalid control letter, pass the character's codepoint, not
6216 a pointer to its multibyte form. Improve display of the character
6217 in octal and display also its hex code.
6218
6219 * character.c (char_string): Use %x to display the (unsigned)
6220 codepoint of an invalid character, to avoid displaying a bogus
6221 negative value.
6222
6223 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6224 `error', not SYMBOL_NAME itself.
6225
6226 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6227 character arguments to `error'.
6228
6229 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6230 to `error' in error message about FINAL_CHAR argument. Make sure
6231 FINAL_CHAR is a character, and use %c when it is passed as
6232 argument to `error'.
6233
4ffd0d6b 62342011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6235
6236 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6237
6238 * w32.c: Include <time.h>.
6239 (sys_localtime): New function.
6240
4ffd0d6b 62412011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6242
6243 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6244
4ffd0d6b 6245 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6246
4ffd0d6b 62472011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6248
4ffd0d6b
GM
6249 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6250 zombies (Bug#8467).
aac0c6e3 6251
04c56954
EZ
62522011-04-19 Eli Zaretskii <eliz@gnu.org>
6253
6254 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6255 gl_state.e_property when gl_state.object is Qt.
6256
6257 * insdel.c (make_gap_larger): Remove limitation of buffer size
6258 to <= INT_MAX.
6259
16a43933
CY
62602011-04-18 Chong Yidong <cyd@stupidchicken.com>
6261
6262 * xdisp.c (lookup_glyphless_char_display)
6263 (produce_glyphless_glyph): Handle cons cell entry in
6264 glyphless-char-display.
6265 (Vglyphless_char_display): Document it.
6266
6267 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6268 glyphless-char-display.
6269
4581706e
CY
62702011-04-17 Chong Yidong <cyd@stupidchicken.com>
6271
6272 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6273
6274 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6275
6276 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6277 definition for no-X builds.
6278
4887c6e2 62792011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6280
fd35b6f9
PE
6281 Static checks with GCC 4.6.0 and non-default toolkits.
6282
5c1ccb01
PE
6283 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6284
006c5daa
PE
6285 * process.c (keyboard_bit_set): Define only if SIGIO.
6286 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6287 (send_process): Repair possible setjmp clobbering.
6288
efc736d3
PE
6289 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6290
4e2fe2e6
PE
6291 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6292
f97334a2
PE
6293 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6294
4e75f29d
PE
6295 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6296 Define only if needed.
6297
90efadd1
PE
6298 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6299 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6300 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6301
3c647824
PE
6302 * dispextern.h (struct redisplay_interface): Rename param
6303 to avoid shadowing.
e264f262 6304 * termhooks.h (struct terminal): Likewise.
761383f4 6305 * xterm.c (xembed_send_message): Likewise.
3c647824 6306
b58c5c4a
PE
6307 * insdel.c (make_gap_smaller): Define only if
6308 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6309
cad59032
PE
6310 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6311 it.
6312
c339dc2e
PE
6313 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6314 so that we aren't warned about unused symbols.
6315
91a3e27b
PE
6316 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6317
399c71d3 6318 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6319
8ffc96f5
PE
6320 * xfns.c (x_real_positions): Mark locals as initialized.
6321
eef9bc79
PE
6322 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6323
098db9dd
PE
6324 * xterm.c: Fix problems found by static analysis with other toolkits.
6325 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6326 (x_dispatch_event): Declare static if USE_GTK, and
6327 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6328 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6329 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6330 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6331 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6332
eb18f6cc
PE
6333 * xmenu.c (menu_help_callback): Pointer type fixes.
6334 Use const pointers when pointing at readonly data. Avoid pointer
6335 signedness clashes.
6336 (FALSE): Remove unused macro.
6337 (update_frame_menubar): Remove unused decl.
6338
1fe72bf8
PE
6339 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6340
60d9e1db
PE
6341 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6342 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6343 (single_menu_item): Rename local to avoid shadowing.
6344
39261c26
PE
6345 * keyboard.c (make_lispy_event): Remove unused local var.
6346
018c5e19
PE
6347 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6348 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6349
63d2b86e
PE
6350 * bitmaps: Change bitmaps from unsigned char back to the X11
6351 compatible char. Avoid the old compiler warnings about
6352 out-of-range initializers by using, for example, '\xab' rather
6353 than 0xab.
6354
aefd87e1
PE
6355 * xgselect.c (xgselect_initialize): Check vs interface
6356 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6357
bf501fb9
PE
6358 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6359
e9829fdf
PE
6360 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6361 to read-only memory.
6362
1086c095
PE
6363 * fns.c (vector): Remove; this old hack is no longer needed.
6364
2baccd04 6365 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6366 Remove unused var.
dde42981 6367 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6368
72391843 6369 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6370
436c16df 6371 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6372 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6373 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6374
92bb796d 6375 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6376 (x_term_init): Remove local to avoid shadowing.
92bb796d 6377
764430a3 6378 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6379
6380 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6381 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6382
d1dfb56c
EZ
63832011-04-16 Eli Zaretskii <eliz@gnu.org>
6384
c4354cb4
EZ
6385 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6386
d1dfb56c
EZ
6387 Fix regex.c, syntax.c and friends for buffers > 2GB.
6388 * syntax.h (struct gl_state_s): Declare character position members
6389 EMACS_INT.
6390
6391 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6392
04f2d78b
CB
6393 * textprop.c (verify_interval_modification, interval_of):
6394 Declare arguments EMACS_INT.
d1dfb56c
EZ
6395
6396 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6397 EMACS_INT.
6398
6399 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6400
6401 * indent.c (Fvertical_motion): Local variable it_start is now
6402 EMACS_INT.
6403
6404 * regex.c (re_match, re_match_2, re_match_2_internal)
6405 (bcmp_translate, regcomp, regexec, print_double_string)
6406 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6407 (re_compile_pattern, re_exec): Declare arguments and local
6408 variables `size_t' and `ssize_t' and return values `regoff_t', as
6409 appropriate.
6410 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6411 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6412 <compile_stack_type>: `size' and `avail' are now `size_t'.
6413
6414 * regex.h <regoff_t>: Use ssize_t, not int.
6415 (re_search, re_search_2, re_match, re_match_2): Arguments that
6416 specify buffer/string position and length are now ssize_t and
6417 size_t. Return type is regoff_t.
6418
613052cd
BK
64192011-04-16 Ben Key <bkey76@gmail.com>
6420
6421 * nsfont.m: Fixed bugs in ns_get_family and
6422 ns_descriptor_to_entity that were caused by using free to
6423 deallocate memory blocks that were allocated by xmalloc (via
6424 xstrdup). This caused Emacs to crash when compiled with
6425 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6426 --enable-checking=xmallocoverrun). xfree is now used to
6427 deallocate these memory blocks.
6428
4170f62f 64292011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6430
71b41406
PE
6431 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6432
9587a89d
PE
6433 emacs_write: Accept and return EMACS_INT for sizes.
6434 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6435 et seq.
6436 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6437 Accept and return EMACS_INT.
6438 (emacs_gnutls_write): Return the number of bytes written on
6439 partial writes.
6440 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6441 (emacs_read, emacs_write): Remove check for negative size, as the
6442 Emacs source code has been audited now.
9587a89d
PE
6443 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6444 (emacs_read, emacs_write): Use it.
273a5f82
PE
6445 * process.c (send_process): Adjust to the new signatures of
6446 emacs_write and emacs_gnutls_write. Do not attempt to store
6447 a byte offset into an 'int'; it might overflow.
9587a89d 6448 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6449
3e047f51
PE
6450 * sound.c: Don't assume sizes fit in 'int'.
6451 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6452 Return EMACS_INT, not int.
3e047f51 6453 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6454 Accept EMACS_INT, not int.
6455 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6456 record read return values.
6457
cc39a9db
BK
64582011-04-15 Ben Key <bkey76@gmail.com>
6459
c9d0ec6d
JB
6460 * keyboard.c (Qundefined): Don't declare static since it is used
6461 in nsfns.m.
6462 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6463 static since they are used in nsfont.m.
cc39a9db 6464
6c60eb9f
SM
64652011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6466
6467 * process.c (Qprocessp): Don't declare static.
6468 * lisp.h (Qprocessp): Declare again.
6469
7990b61a
JB
64702011-04-15 Juanma Barranquero <lekktu@gmail.com>
6471
6472 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6473
5d4cb038
PE
64742011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6475
8bd7b830 6476 Improve C-level modularity by making more things 'static'.
cd64ea1d 6477
e3b27b31
PE
6478 Don't publish debugger-only interfaces to other modules.
6479 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6480 (verify_bytepos, count_markers): Move decls to the only modules
6481 that need them.
6482 * region-cache.h (pp_cache): Likewise.
6483 * window.h (check_all_windows): Likewise.
6484 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6485
5d4cb038
PE
6486 * sysdep.c (croak): Now static, if
6487 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6488 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6489
6490 * alloc.c (refill_memory_reserve): Now static if
6491 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6492 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6493
e87b6180
PE
6494 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6495 Define only if USE_LUCID.
6496
ac64929e
PE
6497 * xrdb.c (x_customization_string, x_rm_string): Now static.
6498
6f37259d
PE
6499 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6500 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6501
1683e3ab
PE
6502 * xdisp.c (draw_row_with_mouse_face): Now static.
6503 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6504
de9c2632
PE
6505 * window.h (check_all_windows): Mark externally visible.
6506
2b96acb7
PE
6507 * window.c (window_deletion_count): Now static.
6508
6509 * undo.c: Make symbols static if they're not exported.
6510 (last_undo_buffer, last_boundary_position, pending_boundary):
6511 Now static.
6512
50436f33
PE
6513 * textprop.c (interval_insert_behind_hooks): Now static.
6514 (interval_insert_in_front_hooks): Likewise.
6515
64520e5c
PE
6516 * term.c: Make symbols static if they're not exported.
6517 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6518 (max_frame_lines, tty_set_terminal_modes):
6519 (tty_reset_terminal_modes, tty_turn_off_highlight):
6520 (get_tty_terminal): Now static.
6521 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6522 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6523 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6524 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6525 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6526
1fa53021
PE
6527 * sysdep.c: Make symbols static if they're not exported.
6528 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6529 Now static.
6530 (sigprocmask_set, full_mask): Remove; unused.
6531 (wait_debugging): Mark as visible.
6532 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6533 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6534
d4b43b22
PE
6535 * syntax.c (syntax_temp): Define only if !__GNUC__.
6536
b7c513d0
PE
6537 * sound.c (current_sound_device, current_sound): Now static.
6538
989b29ad
PE
6539 * search.c (searchbufs, searchbuf_head): Now static.
6540
13a55a78
PE
6541 * scroll.c (scroll_cost): Remove; unused.
6542 * dispextern.h (scroll_cost): Remove decl.
6543
de68a1fc
PE
6544 * region-cache.h (pp_cache): Mark as externally visible.
6545
40ccffa6
PE
6546 * process.c: Make symbols static if they're not exported.
6547 (process_tick, update_tick, create_process, chan_process):
6548 (Vprocess_alist, proc_buffered_char, datagram_access):
6549 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6550 (deactivate_process): Mark defn as static, as well as decl.
6551 * lisp.h (create_process): Remove decl.
6552 * process.h (chan_process, Vprocess_alist): Remove decls.
6553
ad64fc97
PE
6554 * print.c: Make symbols static if they're not exported.
6555 (print_depth, new_backquote_output, being_printed, print_buffer):
6556 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6557 (print_interval, print_number_index, initial_stderr_stream):
6558 Now static.
6559 * lisp.h (Fprinc): Remove decl.
6560 (debug_output_compilation_hack): Mark as externally visible.
6561
adddb265
PE
6562 * sysdep.c (croak): Move decl from here to syssignal.h.
6563 * syssignal.h (croak): Put it here, so the API can be checked when
6564 'croak' is called from dissociate_if_controlling_tty.
6565
1717ede2
PE
6566 * minibuf.c: Make symbols static if they're not exported.
6567 (minibuf_save_list, choose_minibuf_frame): Now static.
6568 * lisp.h (choose_minibuf_frame): Remove decl.
6569
fa5fb2bc
PE
6570 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6571
1e3890d1
PE
6572 * lread.c: Make symbols static if they're not exported.
6573 (read_objects, initial_obarray, oblookup_last_bucket_number):
6574 Now static.
6575 (make_symbol): Remove; unused.
6576 * lisp.h (initial_obarray, make_symbol): Remove decls.
6577
8a1414fa
PE
6578 * keyboard.c: Make symbols static if they're not exported.
6579 (single_kboard, recent_keys_index, total_keys, recent_keys):
6580 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6581 (this_single_command_key_start, echoing, last_auto_save):
6582 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6583 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6584 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6585 (Vlispy_mouse_stem, double_click_count):
6586 Now static.
6587 (force_auto_save_soon): Define only if SIGDANGER.
6588 (ignore_mouse_drag_p): Now static if
6589 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6590 (print_help): Remove; unused.
6591 (stop_character, last_timer_event): Mark as externally visible.
6592 * keyboard.h (ignore_mouse_drag_p): Declare only if
6593 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6594 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6595 * lisp.h (echoing): Remove decl.
6596 (force_auto_save_soon): Declare only if SIGDANGER.
6597 * xdisp.c (redisplay_window): Simplify code, to make it more
6598 obvious that ignore_mouse_drag_p is not accessed if !defined
6599 USE_GTK && !defined HAVE_NS.
6600
93ea6e8f
PE
6601 * intervals.c: Make symbols static if they're not exported.
6602 (merge_properties_sticky, merge_interval_right, delete_interval):
6603 Now static.
6604 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6605
77382fcc
PE
6606 * insdel.c: Make symbols static if they're not exported.
6607 However, leave prepare_to_modify_buffer alone. It's never
6608 called from outside this function, but that appears to be a bug.
6609 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6610 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6611 (adjust_after_replace_noundo): Remove; unused.
6612 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6613 (signal_before_change): Remove decls.
77382fcc 6614
9306c32e
PE
6615 * indent.c (val_compute_motion, val_vmotion): Now static.
6616
cd44d2eb
PE
6617 * image.c: Make symbols static if they're not exported.
6618 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6619 if USE_GTK.
6620 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6621 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6622
ad9a7a06
PE
6623 * fringe.c (standard_bitmaps): Now static.
6624 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6625
81626931
PE
6626 * frame.c: Make symbols static if they're not exported.
6627 (x_report_frame_params, make_terminal_frame): Now static.
6628 (get_frame_param): Now static, unless HAVE_NS.
6629 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6630 (x_get_resource_string): Remove; not used.
6631 * frame.h (make_terminal_frame, x_report_frame_params):
6632 (x_get_resource_string); Remove decls.
6633 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6634 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6635
239f9db9
PE
6636 * font.c, fontset.c: Make symbols static if they're not exported.
6637 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6638 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6639 * font.c (font_close_object): Now static.
6640 * font.h (font_close_object): Remove.
6641 * fontset.c (FONTSET_OBJLIST): Remove.
6642 (free_realized_fontset) #if-0 the body, which does nothing.
6643 (face_suitable_for_char_p): #if-0, as it's never called.
6644 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6645 * xfaces.c (face_at_string_position):
6646 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6647 since 0 is always ASCII.
6648
dfcf3579
PE
6649 * fns.c (weak_hash_tables): Now static.
6650
5045092b
PE
6651 * fileio.c: Make symbols static if they're not exported.
6652 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6653 (Vwrite_region_annotation_buffers): Now static.
6654
57a96f5c
PE
6655 * eval.c: Make symbols static if they're not exported.
6656 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6657 * lisp.h (backtrace_list): Remove decl.
6658
35f08c38
PE
6659 * emacs.c: Make symbols static if they're not exported.
6660 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6661 (fatal_error_code, fatal_error_signal_hook, standard_args):
6662 Now static.
6663 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6664 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6665 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6666 * lisp.h (fatal_error_signal_hook): Remove decl.
6667 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6668
f44bd759
PE
6669 * editfns.c: Move a (normally-unused) function to its only use.
6670 * editfns.c, lisp.h (get_operating_system_release): Remove.
6671 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6672 worth the hassle of breaking this out.
6673
b532497d
PE
6674 * xterm.c: Make symbols static if they're not exported.
6675 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6676 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6677 (x_destroy_window, x_delete_display):
6678 Now static.
6679 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6680 (x_mouse_leave): Remove; unused.
6681 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6682 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6683 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6684 Remove decls.
6685 (x_mouse_leave): Declare only if WINDOWSNT.
6686 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6687 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6688 USE_X_TOOLKIT.
6689
1675728f
PE
6690 * ftxfont.c: Make symbols static if they're not exported.
6691 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6692 HAVE_FREETYPE.
6693 * font.h (ftxfont_driver): Likewise.
6694
e4cebfca
PE
6695 * xfns.c: Make symbols static if they're not exported.
6696 (x_last_font_name, x_display_info_for_name):
6697 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6698 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6699 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6700 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6701 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6702 (last_show_tip_args): Now static.
6703 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6704 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6705 (x_screen_planes): Remove; unused.
6706 * dispextern.h (x_screen_planes): Remove decl.
6707
5bf46f05
PE
6708 * dispnew.c: Make symbols static if they're not exported.
6709 * dispextern.h (redraw_garbaged_frames, scrolling):
6710 (increment_row_positions): Remove.
6711 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6712 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6713 Now static.
6714 (redraw_garbaged_frames): Remove; unused.
6715
435f4c28
PE
6716 * xfaces.c: Make symbols static if they're not exported.
6717 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6718 Remove decls.
6719 * xterm.h (defined_color): Remove decls.
6720 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6721 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6722 (menu_face_changed_default, defined_color, free_realized_face):
6723 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6724 (ascii_face_of_lisp_face): Remove; unused.
6725
8524aef3
PE
6726 * xdisp.c: Make symbols static if they're not exported.
6727 * dispextern.h (scratch_glyph_row, window_box_edges):
6728 (glyph_to_pixel_coords, set_cursor_from_row):
6729 (get_next_display_element, set_iterator_to_next):
6730 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6731 (show_mouse_face): Remove decls
6732 * frame.h (message_buf_print): Likewise.
6733 * lisp.h (pop_message, set_message, check_point_in_composition):
6734 Likewise.
6735 * xterm.h (set_vertical_scroll_bar): Likewise.
6736 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6737 (message_buf_print, scratch_glyph_row, displayed_buffer):
6738 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6739 (get_next_display_element, show_mouse_face, window_box_edges):
6740 (frame_to_window_pixel_xy, check_point_in_composition):
6741 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6742 (glyph_to_pixel_coords): Remove; unused.
6743
16390cd2
PE
6744 * dired.c (file_name_completion): Now static.
6745
6746 * dbusbind.c (xd_in_read_queued_messages): Now static.
6747
a25f4dfa
PE
6748 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6749 * data.c (circular_list_error): Remove.
6750
14a9c8df
PE
6751 * commands.h (last_point_position, last_point_position_buffer):
6752 (last_point_position_window): Remove decls.
6753 * keyboard.c: Make these variables static.
6754
04f2d78b
CB
6755 * coding.h (coding, code_convert_region, encode_coding_gap):
6756 Remove decls.
74ab6df5
PE
6757 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6758 (iso_code_class, detect_coding, code_convert_region): Now static.
6759 (encode_coding_gap): Remove; unused.
6760
38dfbee1
PE
6761 * chartab.c (chartab_chars, chartab_bits): Now static.
6762
a2cb4e63
PE
6763 * charset.h (charset_iso_8859_1): Remove decl.
6764 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6765 Now static.
6766
127198fd
PE
6767 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6768 * ccl.c (Vccl_program_table): Now static.
6769 (check_ccl_update): Remove; unused.
6770
d85b608f
PE
6771 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6772 * category.h: ... from here.
6773 * category.c (check_category_table, set_category_set): Now static.
6774
31cd66f3
PE
6775 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6776 * lisp.h: Remove these decls.
6777
c358e587
PE
6778 * buffer.c (buffer_count): Remove unused var.
6779
e78aecca
PE
6780 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6781 so that it's not optimized away.
6782 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6783 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6784 exported only to the debugger.
6785
e192d7d3 6786 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6787 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6788
92470028
PE
6789 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6790 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6791 was inaccessible from Lisp.
6792 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6793 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6794
244ed907
PE
6795 alloc.c: Import and export fewer symbols, and remove unused items.
6796 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6797 is defined.
6798 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6799 it's not optimized away by whole-program optimization.
6800 (message_enable_multibyte, free_misc): Remove.
6801 (catchlist, handlerlist, mark_backtrace):
6802 Declare only if BYTE_MARK_STACK.
6803 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6804 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6805 (message_enable_multibyte): Remove decl.
6806 (free_misc, interval_free_list, float_block, float_block_index):
6807 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6808 (cons_free_list, last_marked_index):
6809 Now static.
6810 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6811 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6812 (mark_backtrace): Define only if BYTE_MARK_STACK.
6813 * xdisp.c (message_enable_multibyte): Now static.
6814
61c2b50e 6815 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6816 This makes it easier for human readers (and static analyzers)
6817 to see whether these variables are used from other modules.
6818 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6819 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6820 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6821 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6822 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6823 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6824 * xmenu.c, xselect.c:
6825 Declare Q* vars static if they are not used in other modules.
6826 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6827 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6828 Remove decls of unexported vars.
6829 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6830
95c82688
PE
6831 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6832
16a97296
PE
6833 Make Emacs functions such as Fatom 'static' by default.
6834 This makes it easier for human readers (and static analyzers)
6835 to see whether these functions can be called from other modules.
6836 DEFUN now defines a static function. To make the function external
6837 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6838 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6839 (Finit_image_library):
16a97296
PE
6840 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6841 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6842 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6843 Remove decls, since these functions are now static.
6844 (Funintern, Fget_internal_run_time): New decls, since these functions
6845 were already external.
95c82688 6846
16a97296
PE
6847 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6848 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6849 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6850 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6851 * keyboard.c, keymap.c, lread.c:
6852 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6853 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6854 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6855 Mark functions with DEFUE instead of DEFUN,
6856 if they are used in other modules.
6857 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6858 decls for now-static functions.
6859 * buffer.h (Fdelete_overlay): Remove decl.
6860 * callproc.c (Fgetenv_internal): Mark as internal.
6861 * composite.c (Fremove_list_of_text_properties): Remove decl.
6862 (Fcomposition_get_gstring): New forward static decl.
6863 * composite.h (Fcomposite_get_gstring): Remove decl.
6864 * dired.c (Ffile_attributes): New forward static decl.
6865 * doc.c (Fdocumntation_property): New forward static decl.
6866 * eval.c (Ffetch_bytecode): New forward static decl.
6867 (Funintern): Remove extern decl; now in .h file where it belongs.
6868 * fileio.c (Fmake_symbolic_link): New forward static decl.
6869 * image.c (Finit_image_library): New forward static decl.
6870 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6871 * intervals.h (Fprevious_property_change):
6872 (Fremove_list_of_text_properties): Remove decls.
6873 * keyboard.c (Fthis_command_keys): Remove decl.
6874 (Fcommand_execute): New forward static decl.
6875 * keymap.c (Flookup_key): New forward static decl.
6876 (Fcopy_keymap): Now static.
6877 * keymap.h (Flookup_key): Remove decl.
6878 * process.c (Fget_process): New forward static decl.
6879 (Fprocess_datagram_address): Mark as internal.
6880 * syntax.c (Fsyntax_table_p): New forward static decl.
6881 (skip_chars): Remove duplicate decl.
6882 * textprop.c (Fprevious_property_change): New forward static decl.
6883 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6884 Now internal.
6885 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6886 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6887
785bbd42
PE
6888 * editfns.c (Fformat): Remove unreachable code.
6889
8b913b57
AS
68902011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6891
6892 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6893 change. (Bug#8496)
6894
a6744a35
EZ
68952011-04-13 Eli Zaretskii <eliz@gnu.org>
6896
6897 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6898 when at ZV. (Bug#8487)
6899
e7974947
AS
69002011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6901
baad03f0
AS
6902 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6903 (Bug#8437)
6904 * keyboard.c (parse_tool_bar_item): Likewise.
6905 * sound.c (sound_cleanup, alsa_close): Likewise.
6906 * termcap.c (tgetent): Likewise.
6907 * xfns.c (x_default_font_parameter): Likewise.
6908 * xsettings.c (read_and_apply_settings): Likewise.
6909
e7974947
AS
6910 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6911 (overrun_check_free): Protoize.
6912
28272684
PE
69132011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6914
6915 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6916 since callers should never pass a negative size.
6917 Change the signature to match that of plain 'read' and 'write'; see
6918 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6919 * lisp.h: Update prototypes of emacs_write and emacs_read.
6920
11997c76
EZ
69212011-04-11 Eli Zaretskii <eliz@gnu.org>
6922
6923 * xdisp.c (redisplay_window): Don't try to determine the character
6924 position of the scroll margin if the window start point w->startp
e896f03c 6925 is outside the buffer's accessible region. (Bug#8468)
11997c76 6926
8a2cbd72
EZ
69272011-04-10 Eli Zaretskii <eliz@gnu.org>
6928
6929 Fix write-region and its subroutines for buffers > 2GB.
6930 * fileio.c (a_write, e_write): Modify declaration of arguments and
6931 local variables to support buffers larger than 2GB.
6932 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6933
6934 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6935 argument, local variables, and return value.
6936
6937 * lisp.h: Update prototypes of emacs_write and emacs_read.
6938
6939 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6940
4073e537 69412011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6942
1ebfdcb6
PE
6943 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6944
b2ded58d
PE
6945 Fix more problems found by GCC 4.6.0's static checks.
6946
7d66342c
PE
6947 * xdisp.c (vmessage): Use a better test for character truncation.
6948
bbf47d44
PE
6949 * charset.c (load_charset_map): <, not <=, for optimization,
6950 and to avoid potential problems with integer overflow.
9248994d 6951 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6952 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6953 * editfns.c (Fformat): Likewise.
1e69125e 6954 * syntax.c (skip_chars): Likewise.
3befa583 6955
e3019616
PE
6956 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6957 This also lets GCC 4.6.0 generate slightly better loop code.
6958
becfa255
PE
6959 * callint.c (Fcall_interactively): <, not <=, for optimization.
6960 (Fcall_interactively): Count the number of arguments produced,
6961 not the number of arguments given. This is simpler and lets GCC
6962 4.6.0 generate slightly better code.
6963
dae0cd48
PE
6964 * ftfont.c: Distingish more carefully between FcChar8 and char.
6965 The previous code passed unsigned char * to a functions like
6966 strlen and xstrcasecmp that expect char *, which does not
6967 conform to the C standard.
6968 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6969 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6970 char * when the C standard requires it.
6971
76032d70
PE
6972 * keyboard.c (read_char): Remove unused var.
6973
eb3f1cc8
PE
6974 * eval.c: Port to Windows vsnprintf (Bug#8435).
6975 Include <limits.h>.
6976 (SIZE_MAX): Define if the headers do not.
6977 (verror): Do not give up if vsnprintf returns a negative count.
6978 Instead, grow the buffer. This ports to Windows vsnprintf, which
6979 does not conform to C99. Problem reported by Eli Zaretskii.
6980 Also, simplify the allocation scheme, by avoiding the need for
6981 calling realloc, and removing the ALLOCATED variable.
6982
70476b54
PE
6983 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6984
12020a9e
PE
6985 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6986 But keep the doprint source code for now, as we might revamp it
6987 and use it again (Bug#8435).
ea6c7ae6
PE
6988 * lisp.h (doprnt): Remove.
6989 * Makefile.in (base_obj): Remove doprnt.o.
6990 * deps.mk (doprnt.o): Remove.
6991
5fdb398c
PE
6992 error: Print 32- and 64-bit integers portably (Bug#8435).
6993 Without this change, on typical 64-bit hosts error ("...%d...", N)
6994 was used to print both 32- and 64-bit integers N, which relied on
6995 undefined behavior.
6996 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6997 New macro.
6998 * lisp.h (error, verror): Mark as printf-like functions.
6999 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7000 Report overflow in size calculations when allocating printf buffer.
7001 Do not truncate output string at its first null byte.
7002 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7003 Truncate the output at a character boundary, since vsnprintf does not
7004 do that.
7005 * charset.c (check_iso_charset_parameter): Convert internal
7006 character to string before calling 'error', since %c now has the
7007 printf meaning.
7008 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7009 overflow when computing char to be passed to 'error'. Do not
7010 pass Lisp_Object to 'error'; pass the integer instead.
7011 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7012 formatted with plain %d.
7013
b189fa66
PE
7014 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7015
bff87ef0
PE
7016 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7017
7e2cac20
PE
7018 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7019
ce4d90b5
PE
7020 * xterm.c (x_catch_errors): Remove duplicate declaration.
7021
266c9547
PE
7022 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7023
79c49ad2
PE
7024 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7025
368f4090
JM
70262011-04-10 Jim Meyering <meyering@redhat.com>
7027
7028 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7029 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7030 return ssize_t not "int", and use size_t as the buffer length.
7031 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7032 * gnutls.h: Update declarations.
7033 * process.c (read_process_output): Use ssize_t, to match.
7034 (send_process): Likewise.
7035
a32d4040
CY
70362011-04-09 Chong Yidong <cyd@stupidchicken.com>
7037
7038 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7039
8546720e 70402011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7041
04f2d78b
CB
7042 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7043 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7044
8546720e
GM
7045 * xterm.c (handle_one_xevent):
7046 * xmenu.c (create_and_show_popup_menu):
7047 * xselect.c (x_decline_selection_request)
7048 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7049
0a2f5c1a 70502011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7051
7052 Fix some uses of `int' instead of EMACS_INT.
7053 * search.c (string_match_1, fast_string_match)
7054 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7055 (scan_buffer, find_next_newline_no_quit)
7056 (find_before_next_newline, search_command, Freplace_match)
7057 (Fmatch_data): Make some `int' variables be EMACS_INT.
7058
7059 * xdisp.c (display_count_lines): 3rd argument and return value now
7060 EMACS_INT. All callers changed.
7061 (pint2hrstr): Last argument is now EMACS_INT.
7062
7063 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7064 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7065 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7066 (decode_coding_utf_16, decode_coding_emacs_mule)
7067 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7068 (decode_coding_ccl, decode_coding_charset)
7069 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7070 (decode_coding_iso_2022, decode_coding_emacs_mule)
7071 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7072 <char_offset, last_offset>: Declare EMACS_INT.
7073 (encode_coding_utf_8, encode_coding_utf_16)
7074 (encode_coding_emacs_mule, encode_invocation_designation)
7075 (encode_designation_at_bol, encode_coding_iso_2022)
7076 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7077 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7078 Declare EMACS_INT.
7079 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7080 (encode_invocation_designation): Last argument P_NCHARS is now
7081 EMACS_INT.
7082 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7083 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7084
7085 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7086 All users changed.
7087
7088 * ccl.c (Fccl_execute_on_string): Declare some variables
7089 EMACS_INT.
7090
8546720e 70912011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7092
7093 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7094
4e19a977
CS
70952011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7096
7097 * process.c (Fformat_network_address): Doc fix.
7098
87302331
R
70992011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7100
ee7683eb 7101 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7102
cbb59342
CY
71032011-04-08 Chong Yidong <cyd@stupidchicken.com>
7104
7105 * keyboard.c (read_char): Call Lisp function help-form-show,
7106 instead of using internal_with_output_to_temp_buffer.
7107 (Qhelp_form_show): New var.
e0d38eeb 7108 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7109
7110 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7111
7112 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7113
e67a13ab
CY
71142011-04-06 Chong Yidong <cyd@stupidchicken.com>
7115
04f2d78b
CB
7116 * process.c (Flist_processes): Remove to Lisp.
7117 (list_processes_1): Delete.
e67a13ab 7118
973f782d
EZ
71192011-04-06 Eli Zaretskii <eliz@gnu.org>
7120
7c106b1e
EZ
7121 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7122
973f782d
EZ
7123 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7124
41cf7d1a 71252011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7126
ca23cc88
PE
7127 Fix more problems found by GCC 4.6.0's static checks.
7128
f390e2d5
PE
7129 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7130
42eea0d0
PE
7131 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7132
b69769da 7133 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7134
f9541e84
PE
7135 * xdisp.c (vmessage): Mark as a printf-like function.
7136
13841b55
PE
7137 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7138
c136c10f
PE
7139 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7140
5e2d4a30
PE
7141 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7142 printf-like functions.
7143 (tiff_load): Add casts to remove these marks before passing them
7144 to system-supplied API.
7145
583f48b9
PE
7146 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7147
b25d760e
PE
7148 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7149 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7150 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7151 directly, rather than having caller test rule sign. This avoids
7152 some unnecessary tests.
7153 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7154 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7155 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7156
bc7b6697 7157 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7158 (xfont_open): Avoid unnecessary tests.
bc7b6697 7159
27ccc379
PE
7160 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7161
dcd5c89a
PE
7162 * composite.h, composite.c (composition_gstring_put_cache):
7163 Use EMACS_INT, not int, for length.
7164
b13a45c6
PE
7165 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7166 breaking out part of COMPOSITION_DECODE_RULE.
7167 (COMPOSITION_DECODE_RULE): Use it.
7168 * composite.c (get_composition_id): Remove unused local vars,
7169 by using the new macro.
7170
1e792e4d
PE
7171 * textprop.c (set_text_properties_1): Change while to do-while,
7172 since the condition is always true at first.
7173
dc6c6455 7174 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7175 (interval_deletion_adjustment): Return unsigned value.
7176 All uses changed.
dc6c6455 7177
aba7731a
PE
7178 * process.c (list_processes_1, create_pty, read_process_output):
7179 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7180 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7181 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7182 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7183 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7184
fdfc4bf3
PE
7185 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7186
fca8fe46 7187 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7188 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7189
06a0259a 7190 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7191 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7192 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7193
e7b9e80f
PE
7194 * print.c (print_error_message): Avoid int overflow.
7195
56201685
PE
7196 * font.c (font_list_entities): Redo for clarity,
7197 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7198
78834453 7199 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7200 (font_score): Avoid potential overflow in diff calculation.
78834453 7201
0bc0b309 7202 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7203 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7204
e610eaca
PE
7205 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7206
b895abce
PE
7207 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7208 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7209 can always succeed if overflow has undefined behavior.
7210
1f1d9321 7211 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7212 (wordify): Omit three unnecessary tests.
1f1d9321 7213
c59478bc
PE
7214 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7215 All callers changed. This avoids the need for an unused var.
7216
79b73827
PE
7217 * casefiddle.c (casify_region): Remove var that is set but not used.
7218
a4db5dfe
PE
7219 * dired.c (file_name_completion): Remove var that is set but not used.
7220
43aae36e
PE
7221 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7222
2a47c44d 7223 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7224 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7225
a37c69bf
PE
7226 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7227 Check for integer overflow on size calculations.
7228
328ab8e7
PE
7229 * buffer.c (Fprevious_overlay_change): Remove var that is set
7230 but not used.
7231
e5a2a5cb
PE
7232 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7233 Remove vars that are set but not used.
8d84a6eb 7234 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7235 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7236
a60e5f68
PE
7237 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7238
f661cb61 7239 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7240 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7241
f0397f5a
PE
7242 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7243 that are set but not used.
7244
8664db06 7245 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7246 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7247
6abdaa4a
PE
7248 * xselect.c (x_get_local_selection, x_handle_property_notify):
7249 Remove vars that are set but not used.
7250
0ce7538d 7251 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7252 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7253
9ae848fc
PE
7254 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7255 Remove var that is set but not used.
0b918413
PE
7256 (scroll_bar_windows_size): Now size_t, not int.
7257 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7258 Check for overflow.
9ae848fc 7259
a5a62657
PE
7260 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7261 (map_tty_color) [!defined MSDOS]: Likewise.
7262
5c5cdd39
PE
7263 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7264
66ebf983
PE
7265 * coding.c: Remove vars that are set but not used.
7266 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7267 All callers changed.
7268 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7269 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7270 (decode_coding_charset): Remove vars that are set but not used.
7271
1be4d761
PE
7272 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7273 that is set but not used.
7274
47553fa8
PE
7275 * print.c (print_object): Remove var that is set but not used.
7276
1f7196bf 7277 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7278 The gnulib version avoids calling malloc in the usual case,
7279 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7280 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7281 * filelock.c (current_lock_owner): Likewise.
7282 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7283 * sysdep.c: Include allocator.h, careadlinkat.h.
7284 (emacs_no_realloc_allocator): New static constant.
7285 (emacs_readlink): New function.
fdb61804
PE
7286 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7287 ../lib/careadlinkat.h.
d1fdcab7 7288
f84c17c7
SM
72892011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7290
7291 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7292 first non-nil return value).
7293
ef3862ad
JD
72942011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7295
7296 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7297 if not defined (Bug#8403).
7298
376a7006
JB
72992011-04-02 Juanma Barranquero <lekktu@gmail.com>
7300
7301 * xdisp.c (display_count_lines): Remove parameter `start',
7302 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7303 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7304 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7305 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7306 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7307 and thereabouts. All callers changed.
7308 (get_per_char_metric): Remove parameter `f', unused since
7309 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7310
6ca3801d
JM
73112011-04-02 Jim Meyering <meyering@redhat.com>
7312
7313 do not dereference NULL upon failed strdup
7314 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7315 (ns_get_family): Likewise.
7316
d8e2b5ba
JB
73172011-04-02 Juanma Barranquero <lekktu@gmail.com>
7318
7319 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7320
8c74fcbd
JD
73212011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7322
7323 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7324 later (Bug#8403).
7325
7200d79c
SM
73262011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7327
03408648 7328 Add lexical binding.
7200d79c 7329
03408648
SM
7330 * window.c (Ftemp_output_buffer_show): New fun.
7331 (Fsave_window_excursion):
7332 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7333
7334 * lread.c (lisp_file_lexically_bound_p): New function.
7335 (Fload): Bind Qlexical_binding.
7336 (readevalloop): Remove `evalfun' arg.
7337 Bind Qinternal_interpreter_environment.
7338 (Feval_buffer): Bind Qlexical_binding.
7339 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7340 Mark as dynamic.
7341 (syms_of_lread): Declare `lexical-binding'.
7342
7343 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7344
7345 * keyboard.c (eval_dyn): New fun.
7346 (menu_item_eval_property): Use it.
ca105506
SM
7347
7348 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7349
03408648
SM
7350 * fns.c (concat, mapcar1): Accept byte-code-functions.
7351
7352 * eval.c (Fsetq): Handle lexical vars.
7353 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7354 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7355 (FletX, Flet): Obey lexical binding.
7356 (Fcommandp): Handle closures.
7357 (Feval): New `lexical' arg.
7358 (eval_sub): New function extracted from Feval. Use it almost
7359 everywhere where Feval was used. Look up vars in lexical env.
7360 Handle closures.
7361 (Ffunctionp): Move from subr.el.
7362 (Ffuncall): Handle closures.
7363 (apply_lambda): Remove `eval_flags'.
7364 (funcall_lambda): Handle closures and new byte-code-functions.
7365 (Fspecial_variable_p): New function.
7366 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7367 but without exporting it to Lisp.
23aba0ea 7368
23aba0ea 7369 * doc.c (Fdocumentation, store_function_docstring):
03408648 7370 * data.c (Finteractive_form): Handle closures.
23aba0ea 7371
03408648
SM
7372 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7373 interactive spec.
ba83908c 7374
04f2d78b
CB
7375 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7376 New byte-codes.
03408648
SM
7377 (exec_byte_code): New function extracted from Fbyte_code to handle new
7378 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7379
03408648 7380 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7381
03408648 7382 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7383
e2abce01
JB
73842011-03-31 Juanma Barranquero <lekktu@gmail.com>
7385
7386 * xdisp.c (redisplay_internal): Fix prototype.
7387
63696a73 73882011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7389
63696a73 7390 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7391 (try_scrolling): Use it when setting scroll_limit.
7392 Limit scrolling to 100 screen lines.
63696a73
EZ
7393 (redisplay_window): Even when falling back on "recentering",
7394 position point in the window according to scroll-conservatively,
7395 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7396
7397 (try_scrolling): When point is above the window, allow searching
7398 as far as scroll_max, or one screenful, to compute vertical
7399 distance from PT to the scroll margin position. This prevents
7400 try_scrolling from unnecessarily failing when
7401 scroll-conservatively is set to a value slightly larger than the
7402 window height. Clean up the case of PT below the margin at bottom
7403 of window: scroll_max can no longer be INT_MAX. When aggressive
7404 scrolling is in use, don't let point enter the opposite scroll
7405 margin as result of the scroll.
7406 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7407 threshold of 100 lines for never-recentering scrolling.
7408
e4cc2dfc
JB
74092011-03-31 Juanma Barranquero <lekktu@gmail.com>
7410
7411 * dispextern.h (move_it_by_lines):
7412 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7413 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7414 (message_log_check_duplicate): Remove parameters `prev_bol' and
7415 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7416 (redisplay_internal): Remove parameter `preserve_echo_area',
7417 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7418
7419 * indent.c (Fvertical_motion):
7420 * window.c (window_scroll_pixel_based, Frecenter):
7421 Don't pass `need_y_p' to `move_it_by_lines'.
7422
1c470562
SM
74232011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7424
44f230aa
SM
7425 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7426 steal a few bits to be more compact.
7427 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7428 Remove unneeded casts.
7429
1c470562
SM
7430 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7431
888adce9
ZK
74322011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7433
7434 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7435 binding" message (bug#7967).
7436
f838ed7b
PE
74372011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7438
77861b95
PE
7439 Fix more problems found by GCC 4.6.0's static checks.
7440
de6dbc14
PE
7441 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7442 Remove unused local var.
7443
f838ed7b
PE
7444 * editfns.c (Fmessage_box): Remove unused local var.
7445
792c7b2b
PE
7446 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7447 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7448 Omit unused local vars.
c499e557 7449 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7450 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7451 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7452 Omit unused local var.
7453
ba0165e1
PE
7454 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7455 Don't assume string length fits in int.
32ad8845 7456 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7457 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7458
3c59b4c9
PE
7459 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7460 instead of alloca (Bug#8344).
7461
a3eed478 7462 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7463 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7464
eb4d412d
PE
7465 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7466
1658b401
PE
7467 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7468 concerns.
7469
7470 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7471
7472 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7473
9a2c6e05
PE
7474 * keyboard.c (syms_of_keyboard): Use the same style as later
7475 in this function when indexing through an array. This also
7476 works around GCC bug 48267.
7477
03d0a109
PE
7478 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7479
44f730c8
PE
7480 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7481
fe75f926
PE
7482 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7483 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7484
ffa8c828
PE
7485 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7486 This avoids undefined behavior on integer overflow, and is a bit
7487 more convenient anyway since it is compared to a size_t variable.
7488
c5101a77
PE
7489 Variadic C functions now count arguments with size_t, not int.
7490 This avoids an unnecessary limitation on 64-bit machines, which
7491 caused (substring ...) to crash on large vectors (Bug#8344).
7492 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7493 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7494 All variadic functions and their callers changed accordingly.
c5101a77
PE
7495 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7496 * data.c (arith_driver, float_arith_driver): Likewise.
7497 * editfns.c (general_insert_function): Likewise.
7498 * eval.c (struct backtrace.nargs, interactive_p)
7499 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7500 (funcall_lambda, mark_backtrace): Likewise.
7501 * fns.c (concat): Likewise.
7502 * frame.c (x_set_frame_parameters): Likewise.
7503 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7504 0 if not found, not -1. All callers changed.
7505
dd3f25f7
PE
7506 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7507 (stack_copy_size): Now size_t, not int.
7508 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7509
461c2ab9
JB
75102011-03-28 Juanma Barranquero <lekktu@gmail.com>
7511
7512 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7513 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7514 All callers changed.
7515
7516 * lisp.h (multibyte_char_to_unibyte):
7517 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7518 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7519 * character.h (CHAR_TO_BYTE8):
7520 * cmds.c (internal_self_insert):
7521 * editfns.c (general_insert_function):
7522 * keymap.c (push_key_description):
7523 * search.c (Freplace_match):
7524 * xdisp.c (message_dolog, set_message_1): All callers changed.
7525
f6d62986
SM
75262011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7527
7528 * keyboard.c (safe_run_hook_funcall): New function.
7529 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7530 don't set the hook to nil, but remove the offending function instead.
7531 (Qcommand_hook_internal): Remove, unused.
7532 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7533 Vcommand_hook_internal.
7534
7535 * eval.c (enum run_hooks_condition): Remove.
7536 (funcall_nil, funcall_not): New functions.
7537 (run_hook_with_args): Call each function through a `funcall' argument.
7538 Remove `cond' argument, now redundant.
7539 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7540 (Frun_hook_with_args_until_failure): Adjust accordingly.
7541 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7542
1db5b1ad
JB
75432011-03-28 Juanma Barranquero <lekktu@gmail.com>
7544
7545 * dispextern.h (string_buffer_position): Remove declaration.
7546
7547 * print.c (strout): Remove parameter `multibyte', unused since
7548 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7549
7550 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7551 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7552 All callers changed.
7553
7554 * w32.c (_wsa_errlist): Use braces for struct initializers.
7555
7556 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7557 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7558 All callers changed.
7559 (string_buffer_position): Likewise. Also, make static (it's never
7560 used outside xdisp.c).
7561 (cursor_row_p): Remove parameter `w', unused since
7562 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7563 (decode_mode_spec): Remove parameter `precision', introduced during
7564 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7565 All callers changed.
7566
5ffb62aa
JD
75672011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7568
7569 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7570
461c2ab9 75712011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7572
7573 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7574 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7575 (ns_update_auto_hide_menu_bar): New functions.
7576 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7577 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7578 ns_constrain_all_frames.
7579 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7580 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7581
5c380ffb
JD
75822011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7583
7584 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7585
9af30bdf
GM
75862011-03-27 Glenn Morris <rgm@gnu.org>
7587
7588 * syssignal.h: Replace RETSIGTYPE with void.
7589 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7590 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7591 Replace SIGTYPE with void everywhere.
7592 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7593 * s/template.h (SIGTYPE): Remove commented out definition.
7594
e2abce01
JB
75952011-03-26 Eli Zaretskii <eliz@gnu.org>
7596
7597 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7598 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7599
f868cd8a
JB
76002011-03-26 Juanma Barranquero <lekktu@gmail.com>
7601
59eb0929
JB
7602 * w32.c (read_unc_volume): Use parameter `henum', instead of
7603 global variable `wget_enum_handle'.
7604
7605 * keymap.c (describe_vector): Remove parameters `indices' and
7606 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7607 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7608
f868cd8a
JB
7609 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7610
7611 * keyboard.c (timer_check): Remove parameter `do_it_now',
7612 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7613 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7614 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7615
7616 * keyboard.c (read_char):
7617 * w32menu.c (w32_menu_display_help):
7618 * xmenu.c (show_help_event, menu_help_callback):
7619 Adjust calls to `show_help_echo'.
7620
7621 * gtkutil.c (xg_maybe_add_timer):
7622 * keyboard.c (readable_events):
7623 * process.c (wait_reading_process_output):
7624 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7625
7626 * insdel.c (adjust_markers_gap_motion):
7627 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7628 (gap_left, gap_right): Don't call it.
7629
2ecf6fdb
CY
76302011-03-25 Chong Yidong <cyd@stupidchicken.com>
7631
7632 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7633 incurred during fontification.
7634
6b1f9ba4
JB
76352011-03-25 Juanma Barranquero <lekktu@gmail.com>
7636
7637 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7638 (DEFVAR_PER_BUFFER): Don't pass it.
7639
7640 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7641 (scrolling_window): Don't pass it.
7642
0f4a96b5
JB
76432011-03-25 Juanma Barranquero <lekktu@gmail.com>
7644
7645 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7646
7647 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7648 and `suffix'.
7649 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7650 of variables specific to SELinux and computation of `encoded_absname'.
7651
7652 * image.c (XPutPixel): Remove unused variable `height'.
7653
7654 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7655
7656 * unexw32.c (get_section_info): Remove unused variable `section'.
7657
7658 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7659 (system_process_attributes): Remove unused variable `sess'.
7660 (sys_read): Remove unused variable `err'.
7661
7662 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7663 (w32_wnd_proc): Remove unused variable `isdead'.
7664 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7665 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7666 (x_create_tip_frame): Remove unused variable `tem'.
7667
7668 * w32inevt.c (w32_console_read_socket):
7669 Remove unused variable `no_events'.
7670
7671 * w32term.c (x_draw_composite_glyph_string_foreground):
7672 Remove unused variable `width'.
7673
1149507c
JB
76742011-03-24 Juanma Barranquero <lekktu@gmail.com>
7675
7676 * w32term.c (x_set_glyph_string_clipping):
7677 Don't pass uninitialized region to CombineRgn.
7678
9c88f339
JB
76792011-03-23 Juanma Barranquero <lekktu@gmail.com>
7680
7681 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7682 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7683 (Fx_close_connection): Remove unused variable `i'.
7684
7685 * w32font.c (w32font_draw): Return number of glyphs.
7686 (w32font_open_internal): Remove unused variable `i'.
7687 (w32font_driver): Add missing initializer.
7688
7689 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7690 (fill_in_menu): Remove unused variable `items_added'.
7691
7692 * w32term.c (last_mouse_press_frame): Remove static global variable.
7693 (w32_clip_to_row): Remove unused variable `f'.
7694 (x_delete_terminal): Remove unused variable `i'.
7695
7696 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7697 (NOTHING): Remove unused static global variable.
7698 (uniscribe_check_otf): Remove unused variable `table'.
7699 (uniscribe_font_driver): Add missing initializers.
7700
dee091a3
JD
77012011-03-23 Julien Danjou <julien@danjou.info>
7702
7703 * term.c (Fsuspend_tty, Fresume_tty):
7704 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7705 * window.c (temp_output_buffer_show):
7706 * insdel.c (signal_before_change):
7707 * frame.c (Fhandle_switch_frame):
7708 * fileio.c (Fdo_auto_save):
7709 * emacs.c (Fkill_emacs):
7710 * editfns.c (save_excursion_restore):
7711 * cmds.c (internal_self_insert):
7712 * callint.c (Fcall_interactively):
7713 * buffer.c (Fkill_all_local_variables):
7714 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7715 Use Frun_hooks.
0f4a96b5 7716 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7717 unconditionnaly since it does the check itself.
7718
2c520ab5 77192011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7720
c9c49752
PE
7721 Fix more problems found by GCC 4.5.2's static checks.
7722
8abc3f12
PE
7723 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7724 the first time through the loop, since we know p0 < p1 then.
7725 This also avoids a gcc -Wstrict-overflow warning.
7726
a2d26660
PE
7727 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7728 leading to a memory leak, possible in functions like
7729 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7730 of objects (Bug#8318).
a2d26660 7731
916c72e9
PE
7732 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7733 that could (at least in theory) be that large.
7734
19ab8a18
PE
7735 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7736 This is less likely to overflow, and avoids undefined behavior if
7737 overflow does occur. All callers changed. Use strtoul to scan
7738 for the unsigned long integer.
b7cbbd6f
PE
7739 (pint2hrstr): Simplify and tune code slightly.
7740 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7741
f0641eff
PE
7742 * scroll.c (do_scrolling): Work around GCC bug 48228.
7743 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7744
7f650bb9
PE
7745 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7746 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7747 (validate_x_resource_name): Simplify count usage.
7748 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7749
37dd57d1
PE
7750 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7751 fail (Bug#8306).
81e56e61 7752
699979fc 7753 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7754
401bf9b4
PE
7755 * process.c (Fmake_network_process): Use socklen_t, not int,
7756 where POSIX says socklen_t is required in portable programs.
7757 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7758 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7759 (Fmake_network_process, server_accept_connection):
7760 (wait_reading_process_output, read_process_output):
7761 Likewise.
7762
b93aacde
PE
7763 * process.c: Rename or move locals to avoid shadowing.
7764 (list_processes_1, Fmake_network_process):
7765 (read_process_output_error_handler, exec_sentinel_error_handler):
7766 Rename or move locals.
4dc343ee 7767 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7768 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7769 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7770 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7771 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7772
af8a867c 7773 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7774 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7775 Include tparam.h instead, since it declares them.
af8a867c
PE
7776 * cm.h (PC): Remove extern decl; tparam.h now does this.
7777 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7778 * terminfo.c: Include tparam.h, to check interfaces.
7779 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7780 (tparam): Adjust signature to match interface in tparam.h;
7781 this removes some undefined behavior. Check that outstring and len
7782 are zero, which they always are with Emacs.
7783 * tparam.h (PC, BC, UP): New extern decls.
7784
0248044d 7785 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7786 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7787
8ff096c1 7788 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7789 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7790 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7791 (ftfont_list): Remove unused local.
49eaafba
PE
7792 (get_adstyle_property, ftfont_pattern_entity):
7793 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7794 Rename locals to avoid shadowing.
8ff096c1 7795
e2be39f6
PE
7796 * xfont.c (xfont_list_family): Mark var as initialized.
7797
c9735e30
PE
7798 * xml.c (make_dom): Now static.
7799
8f5201ae
PE
7800 * composite.c (composition_compute_stop_pos): Rename local to
7801 avoid shadowing.
b246f932
PE
7802 (composition_reseat_it): Remove unused locals.
7803 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7804 (composition_update_it): Mark var as initialized.
11b61122
PE
7805 (find_automatic_composition): Mark vars as initialized,
7806 with a FIXME (Bug#8290).
8f5201ae 7807
760fbc2c
PE
7808 character.h: Rename locals to avoid shadowing.
7809 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7810 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7811 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7812 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7813 to avoid shadowing.
7814
ff08eb85
PE
7815 * textprop.c (property_change_between_p): Remove; unused.
7816
fc7bf025
PE
7817 * intervals.c (interval_start_pos): Now static.
7818
235d7abc
PE
7819 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7820
44f230aa
SM
7821 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7822 Rename locals to avoid shadowing.
3e7d6594 7823
50060332
PE
7824 * sound.c (wav_play, au_play, Fplay_sound_internal):
7825 Fix pointer signedness.
d01f234b 7826 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7827 (wav_play): Initialize a variable to 0, to prevent undefined
7828 behavior (Bug#8278).
50060332 7829
c4fc4e30
PE
7830 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7831
918436ed
PE
7832 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7833
c939f91b
PE
7834 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7835 clobbering (Bug#8298).
b9c7f648
PE
7836 * sysdep.c (sys_subshell): Likewise.
7837 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7838
6bd8c144
PE
7839 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7840 This should get cleaned up, so that child_setup has the
7841 same signature on all platforms.
7842
7710357c 7843 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7844 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7845
c59da222
CY
78462011-03-22 Chong Yidong <cyd@stupidchicken.com>
7847
7848 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7849 not to be necessary, and produces flickering.
7850
66b87493
GM
78512011-03-20 Glenn Morris <rgm@gnu.org>
7852
7853 * config.in: Remove file.
7854
45b6f6d5
JB
78552011-03-20 Juanma Barranquero <lekktu@gmail.com>
7856
7857 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7858 are now in src/globals.h.
7859 (syms_of_minibuf): Remove spurious & from previous change.
7860
3ec03f7e
LL
78612011-03-20 Leo <sdl.web@gmail.com>
7862
7863 * minibuf.c (completing-read-function): New variable.
7864 (completing-read-default): Rename from completing-read.
7865 (completing-read): Call completing-read-function.
7866
b14e3e21
CY
78672011-03-19 Juanma Barranquero <lekktu@gmail.com>
7868
7869 * xfaces.c (Fx_load_color_file):
7870 Read color file from absolute filename (bug#8250).
7871
f2b726e6
JB
78722011-03-19 Juanma Barranquero <lekktu@gmail.com>
7873
7874 * makefile.w32-in: Update dependencies.
7875
09f6ff02
EZ
78762011-03-17 Eli Zaretskii <eliz@gnu.org>
7877
7878 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7879
29a6015a
PE
78802011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7881
a3a6c54e
PE
7882 Fix more problems found by GCC 4.5.2's static checks.
7883
b766f867
PE
7884 * process.c (make_serial_process_unwind, send_process_trap):
7885 (sigchld_handler): Now static.
7886
be02381c
PE
7887 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7888 That way, the code declares only the vars that it needs.
7889 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7890 * s/cygwin.h (PTY_ITERATION): Likewise.
7891 * s/darwin.h (PTY_ITERATION): Likewise.
7892 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7893
57048744
PE
7894 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7895 * process.c (allocate_pty): Don't declare stb unless it's needed.
7896
7914961c 7897 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7898 (CONSTANTLIM): Remove; unused.
7899 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7900 Define only if needed.
7914961c 7901
b3967b18
PE
7902 * unexelf.c (unexec): Name an expression,
7903 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7904 Use a different way to cause a compilation error if anyone uses
7905 n rather than nn, a way that does not involve shadowing.
73366a00 7906 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7907
29a6015a
PE
7908 * deps.mk (unexalpha.o): Remove; unused.
7909
43cfc33e 7910 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7911 * unexec.h: New file.
ce701a33
PE
7912 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7913 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7914 Depend on unexec.h.
7915 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7916 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7917 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7918 Change as necessary to match prototype in unexec.h.
ce701a33 7919
01f44d5a
PE
7920 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7921 shadowing.
4f63c6bb 7922 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7923
a6670b0b
PE
7924 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7925 Rename locals to avoid shadowing.
7926
cef2010d 7927 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7928 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7929
d4d7173a
PE
7930 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7931
f08b802a
PE
7932 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7933 warning when compiling print.c.
7934
3ddb0639
PE
7935 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7936 instead of using an uninitialized var.
5ad03b97 7937 (font_sort_entities): Mark var as initialized.
3ddb0639 7938
170a2692
PE
7939 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7940
e663c700
PE
7941 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7942 pointers to constants.
89bc529a 7943 (font_parse_fcname): Remove unused vars.
7b81e2d0 7944 (font_delete_unmatched): Now static.
ea838e10 7945 (font_get_spec): Remove; unused.
13a547c6
PE
7946 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7947 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7948 Rename or move locals to avoid shadowing.
e663c700 7949
2a80c887 7950 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7951 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7952
1384fa33 7953 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7954 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7955
8b2c52e9
PE
7956 * alloc.c (mark_backtrace): Move decl from here ...
7957 * lisp.h: ... to here, so that it can be checked.
7958
475545b5 7959 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7960 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7961 (lisp_indirect_variable): Name an expression,
7962 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7963 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7964
b1349114 7965 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7966 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7967 Use const pointer when appropriate.
b1349114 7968
a2928364
PE
7969 * lisp.h (get_system_name, get_operating_system_release):
7970 Move decls here, to check interfaces.
7971 * process.c (get_operating_system_release): Move decl to lisp.h.
7972 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7973 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7974 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7975 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7976 (Fformat_time_string, Fencode_time, Finsert_char):
7977 (Ftranslate_region_internal, Fformat):
7978 Rename or remove local vars to avoid shadowing.
9710023e 7979 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7980
a415e694
PE
7981 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7982 avoid shadowing.
7983
8ef4622d
PE
7984 * lisp.h (eassert): Check that the argument compiles, even if
7985 ENABLE_CHECKING is not defined.
7986
946f9a5b
PE
7987 * data.c (Findirect_variable): Name an expression, to avoid
7988 gcc -Wbad-function-cast warning.
112396d6 7989 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7990 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7991 (Fmake_variable_buffer_local, Fmake_local_variable):
7992 Mark variables as initialized.
52746918 7993 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7994
e5aab7e7 7995 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7996 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7997 Rename locals to avoid shadowing.
dff45157
PE
7998 (mark_stack): Move local variables into the #ifdef region where
7999 they're used.
7bc26fdb
PE
8000 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8001 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8002 needed otherwise.
8003 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8004 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8005 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8006
e5aab7e7
PE
8007 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8008 avoids undefined behavior in theory.
8009
4da60324
PE
8010 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8011
88043301
PE
8012 Use functions, not macros, for up- and down-casing (Bug#8254).
8013 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8014 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8015 to use the following functions instead of these macros.
8016 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8017 EMACS_INT, since callers assume the returned value fits in int.
8018 (upcase1): Likewise, for UPCASE_TABLE.
8019 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8020 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8021 the race-condition problem in the old DOWNCASE.
88043301 8022
19ed5445
PE
8023 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8024 Rename locals to avoid shadowing.
8025 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8026 (regex_compile, re_search_2, re_match_2_internal):
8027 Remove unused local vars.
952db0d7
PE
8028 (FREE_VAR): Rewrite so as not to use empty "else",
8029 which gcc can warn about.
da053e48 8030 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8031 (RETALLOC_IF): Define only if needed.
8032 (WORDCHAR_P): Likewise. This one is never needed, but is used
8033 only in a comment talking about a compiler bug, so put inside
8034 the #if 0 of that comment.
8035 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8036 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8037 Remove; unused.
19ed5445 8038
1f3561e4 8039 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8040 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8041 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8042
ded6f8f7
PE
8043 * search.c (simple_search): Remove unused var.
8044
dbd37a95
PE
8045 * dired.c (compile_pattern): Move decl from here ...
8046 * lisp.h: ... to here, so that it can be checked.
8047 (struct re_registers): New forward decl.
8048
7e47afad
PE
8049 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8050
85f24f61
PE
8051 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8052 All uses changed.
8053 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8054 Rename locals to avoid shadowing.
5671df8f 8055 (Fvertical_motion): Mark locals as initialized.
85f24f61 8056
181aa2be 8057 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8058 (casify_region): Mark local as initialized.
181aa2be 8059
930d429c
PE
8060 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8061
7082eac6
PE
8062 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8063 New macros, so that the caller can use some names other than
8064 gcpro1, gcpro2, etc.
8065 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8066 of the new macros.
8067 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8068 argument, for consistency with GCPRO2_VAR, etc: it is now the
8069 prefix of the variable, not the variable itself. All uses
8070 changed.
38b2c076
PE
8071 * dired.c (directory_files_internal, file_name_completion):
8072 Rename locals to avoid shadowing.
8073
15206ed9
PE
8074 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8075 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8076 dired.c's scmp function, had undefined behavior.
8077 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8078 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8079 * buffer.h: ... to here, because these macros use current_buffer,
8080 and the new implementation with inline functions needs to have
8081 current_buffer in scope now, rather than later when the macros
8082 are used.
8083 (downcase, upcase1): New static inline functions.
8084 (DOWNCASE, UPCASE1): Reimplement using these functions.
8085 This avoids undefined behavior in expressions like
8086 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8087 from race conditions in accessing the global variables
8088 case_temp1 and case_temp2.
8089 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8090 * lisp.h (case_temp1, case_temp2): Remove their decls.
8091 * character.h (ASCII_CHAR_P): Move from here ...
8092 * lisp.h: ... to here, so that the inline functions mentioned
8093 above can use them.
8094
4a6bea26
PE
8095 * dired.c (directory_files_internal_unwind): Now static.
8096
f14b7e14
PE
8097 * fileio.c (file_name_as_directory, directory_file_name):
8098 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8099 Now static.
2893f146
PE
8100 (file_name_as_directory): Use const pointers when appropriate.
8101 (Fexpand_file_name): Likewise. In particular, newdir might
8102 point at constant storage, so make it a const pointer.
fd4ead52 8103 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8104 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8105 signedness issues.
f839df0c
PE
8106 (Fset_file_times, Finsert_file_contents, auto_save_error):
8107 Rename locals to avoid shadowing.
f14b7e14 8108
5716756e 8109 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8110 (Ftry_completion, Fall_completions): Rename or remove locals
8111 to avoid shadowing.
5716756e 8112
b4c3046a
PE
8113 * marker.c (bytepos_to_charpos): Remove; unused.
8114
b45db522
PE
8115 * lisp.h (verify_bytepos, count_markers): New decls,
8116 so that gcc does not warn that these functions aren't declared.
8117
85876d07
PE
8118 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8119 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8120 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8121 (copy_text): Remove unused local var.
85876d07 8122
03d78a21 8123 * filelock.c (within_one_second): Now static.
b3dd38ab 8124 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8125
5df8f01b
PE
8126 * buffer.c (fix_overlays_before): Mark locals as initialized.
8127 (fix_start_end_in_overlays): Likewise. This function should be
8128 simplified by using pointers-to-pointers, but that's a different
8129 matter.
b1d876f1 8130 (switch_to_buffer_1): Now static.
8f54f30a
PE
8131 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8132 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8133
a70072c9 8134 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8135 Fix pointer signedness issue.
edced198
PE
8136 (sys_subshell): Mark local as volatile if checking for lint,
8137 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8138 (MAXPATHLEN): Define only if needed.
a70072c9 8139
a0977c44
PE
8140 * process.c (serial_open, serial_configure): Move decls from here ...
8141 * systty.h: ... to here, so that they can be checked.
8142
a884fdcc
PE
8143 * fns.c (get_random, seed_random): Move extern decls from here ...
8144 * lisp.h: ... to here, so that they can be checked.
8145
604efe86 8146 * sysdep.c (reset_io): Now static.
b8950c94 8147 (wait_for_termination_signal): Remove; unused.
604efe86 8148
38fc62d9
PE
8149 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8150 (copy_keymap_item, append_key, push_text_char_description):
8151 Now static.
1004a21a 8152 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8153 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8154 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8155 (describe_map_tree):
8156 Rename locals to avoid shadowing.
38fc62d9 8157
2f2650da
PE
8158 * keyboard.c: Declare functions static if they are not used elsewhere.
8159 (echo_char, echo_dash, cmd_error, top_level_2):
8160 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8161 (read_char, kbd_buffer_get_event, make_lispy_position):
8162 (make_lispy_event, make_lispy_movement, apply_modifiers):
8163 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8164 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8165 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8166 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8167 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8168
a053e86c 8169 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8170 (mark_kboards): Move decl here ...
8171 * alloc.c (mark_kboards): ... from here.
a053e86c 8172
4752793e
PE
8173 * lisp.h (force_auto_save_soon): New decl.
8174
74f10ca7 8175 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8176 (DEFINE_DUMMY_FUNCTION): New macro.
8177 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8178 Use it.
c03cd23f
PE
8179 (main): Add casts to avoid warnings
8180 if GCC considers string literals to be constants.
74f10ca7 8181
022e70d4
PE
8182 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8183
59d6fe83
PE
8184 * dbusbind.c: Pointer signedness fixes.
8185 (xd_signature, xd_append_arg, xd_initialize):
8186 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8187 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8188 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8189 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8190
78320123
PE
8191 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8192 if GCC considers string literals to be constants.
49cebcca 8193 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8194
35ac2a97
SM
81952011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8196
fb103ca9
SM
8197 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8198 (print_preprocess, print_object): New macro to fix last change.
8199
35ac2a97
SM
8200 * print.c (print_preprocess): Don't forget font objects.
8201
62973b41
JB
82022011-03-16 Juanma Barranquero <lekktu@gmail.com>
8203
8204 * emacs.c (USAGE3): Doc fixes.
8205
0e48bb22
AS
82062011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8207
8208 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8209 structure.
8210
7684e57b
JB
82112011-03-14 Juanma Barranquero <lekktu@gmail.com>
8212
8213 * lisp.h (VWindow_system, Qfile_name_history):
8214 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8215 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8216 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8217
8218 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8219 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8220
8221 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8222 * w32console.c (detect_input_pending, read_input_pending)
8223 (encode_terminal_code):
8224 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8225 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8226 (w32_system_caret_y, Qfile_name_history):
8227 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8228 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8229 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8230 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8231 * w32proc.c (Qlocal, report_file_error):
8232 * w32term.c (Vwindow_system, updating_frame):
8233 * w32uniscribe.c (initialized, uniscribe_font_driver):
8234 Remove unneeded extern declarations.
8235
2aa46d6c
CY
82362011-03-14 Chong Yidong <cyd@stupidchicken.com>
8237
c96bbc66 8238 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8239
cffc6f3b
CY
82402011-03-13 Chong Yidong <cyd@stupidchicken.com>
8241
8242 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8243 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8244 These macros can no longer be used for assignment.
8245
44f230aa
SM
8246 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8247 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8248 (record_buffer_markers, fetch_buffer_markers): New functions for
8249 recording and fetching special buffer markers.
8250 (set_buffer_internal_1, set_buffer_temp): Use them.
8251
8252 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8253
8254 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8255
8256 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8257 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8258
8259 * xdisp.c (hscroll_window_tree):
8260 (reconsider_clip_changes): Use PT instead of BUF_PT.
8261
d251f04b
EZ
82622011-03-13 Eli Zaretskii <eliz@gnu.org>
8263
8264 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8265 $(EMACS_ROOT)/lib/intprops.h.
8266
f0c77cd1
PE
82672011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8268
3eca4629
PE
8269 Fix more problems found by GCC 4.5.2's static checks.
8270
7c86ee98
PE
8271 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8272 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8273 (xg_free_frame_widgets): Make it clear that a local variable is
8274 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8275 (gdk_window_get_screen): Make it clear that this macro is needed
8276 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8277 (int_gtk_range_get_value): New function, which avoids a diagnostic
8278 from gcc -Wbad-function-cast.
8279 (xg_set_toolkit_scroll_bar_thumb): Use it.
8280 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8281 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8282 (get_utf8_string, xg_get_file_with_chooser):
8283 Rename locals to avoid shadowing.
8284 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8285
41729b81
PE
8286 * xgselect.c (xg_select): Remove unused var.
8287
f0c77cd1
PE
8288 * image.c (four_corners_best): Mark locals as initialized.
8289 (gif_load): Initialize transparent_p to zero (Bug#8238).
8290 Mark another local as initialized.
ec6cf4c6 8291 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8292
ce0ad53d 8293 * image.c (clear_image_cache): Now static.
d5d5a617 8294 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8295 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8296 (x_edge_detection): Remove unnecessary cast that
8297 gcc -Wbad-function-cast diagnoses.
2037898d 8298 (gif_load): Fix pointer signedness.
6ae141d6
PE
8299 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8300 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8301
33383987 83022011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8303
d32df629
PE
8304 Improve quality of tests for time stamp overflow.
8305 For example, without this patch (encode-time 0 0 0 1 1
8306 1152921504606846976) returns the obviously-bogus value (-948597
8307 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8308 reports time overflow. See
8309 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8310 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8311 * editfns.c: Include limits.h and intprops.h.
8312 (TIME_T_MIN, TIME_T_MAX): New macros.
8313 (time_overflow): Move earlier, to before first use.
8314 (hi_time, lo_time): New functions, for an accurate test for
8315 out-of-range times.
8316 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8317 (Fget_internal_run_time): Don't assume time_t fits in int.
8318 (make_time): Use list2 instead of Fcons twice.
8319 (Fdecode_time): More accurate test for out-of-range times.
8320 (check_tm_member): New function.
8321 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8322 (lisp_time_argument): Don't rely on undefined left-shift and
8323 right-shift behavior when checking for time stamp overflow.
8be6f318 8324
fe31d94c
PE
8325 * editfns.c (time_overflow): New function, refactoring common code.
8326 (Fformat_time_string, Fdecode_time, Fencode_time):
8327 (Fcurrent_time_string): Use it.
8328
8be6f318
PE
8329 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8330 * dired.c (make_time): Move to ...
8331 * editfns.c (make_time): ... here.
8332 * systime.h: Note the move.
8333
09d9db2c 83342011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8335
126bc0dc
YM
8336 * fringe.c (update_window_fringes): Remove unused variables.
8337
c47cbdfd
YM
8338 * unexmacosx.c (copy_data_segment): Also copy __got section.
8339 (Bug#8223)
8340
7ac80be9
EZ
83412011-03-12 Eli Zaretskii <eliz@gnu.org>
8342
c96bbc66 8343 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8344 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8345 Constify `char *' arguments and their references according to
8346 prototypes in tparam.h.
8347
ecb0f94d 8348 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8349
7ac80be9
EZ
8350 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8351 Adapt all references accordingly.
8352
8353 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8354
ef1fd07e
TT
83552011-03-11 Tom Tromey <tromey@redhat.com>
8356
8357 * buffer.c (syms_of_buffer): Remove obsolete comment.
8358
7ef4b50c
EZ
83592011-03-11 Eli Zaretskii <eliz@gnu.org>
8360
8361 * termhooks.h (encode_terminal_code): Declare prototype.
8362
8363 * msdos.c (encode_terminal_code): Don't declare prototype.
8364
8365 * term.c (encode_terminal_code): Now external again, used by
8366 w32console.c and msdos.c.
8367
44f230aa
SM
8368 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8369 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8370
4b1ec863 83712011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8372
1714f52b 8373 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8374
4b1ec863
PE
8375 * fringe.c (update_window_fringes): Mark locals as initialized
8376 (Bug#8227).
8377 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8378
524c7aa6
PE
8379 * alloc.c (mark_fringe_data): Move decl from here ...
8380 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8381 to check its interface.
8382 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8383
a5c0af81 8384 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8385 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8386 (fontset_font): Mark local as initialized.
a9a06e0b 8387 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8388
b4716021
PE
8389 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8390
811e9bac 8391 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8392 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8393 (x_own_selection, Fx_disown_selection_internal): Rename locals
8394 to avoid shadowing.
8395 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8396
7e3ab302
PE
8397 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8398 so that the caller can use some name other than gcpro1.
8399 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8400 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8401 (Fx_backspace_delete_keys_p):
8402 Use them to avoid shadowing, and rename vars to avoid shadowing.
8403 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8404 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8405 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8406 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8407 Remove unused locals.
7e3ab302
PE
8408 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8409 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8410 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8411 macros.
f78faa98 8412
e2b13473
PE
8413 * xterm.h (x_mouse_leave): New decl.
8414
77f23912
PE
8415 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8416 Remove unused functions.
cdf4ba58
PE
8417 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8418 (x_calc_absolute_position): Now static.
7411c686 8419 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8420 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8421 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8422 unless they are used.
38d0b34a
PE
8423 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8424 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8425 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8426 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8427 (x_error_catcher, x_connection_closed, x_error_handler):
8428 (x_error_quitter, xembed_send_message, x_iconify_frame):
8429 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8430 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8431 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8432
44f230aa
SM
8433 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8434 Rename or move locals to avoid shadowing.
6b463e58 8435 (tty_defined_color, merge_face_heights): Now static.
5967d051 8436 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8437 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8438 does not deduce is never used uninitialized.
73719eba
PE
8439 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8440 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8441
426994c3 8442 * terminal.c (store_terminal_param): Now static.
5489860b 8443
032f1620 8444 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8445 (set_frame_menubar): Remove unused local.
d4323972 8446 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8447 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8448 since they might point to immutable storage.
281585b0
PE
8449 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8450 since it's unused otherwise.
032f1620 8451
367c19e5 8452 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8453 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8454 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8455 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8456 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8457 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8458 does not deduce are never used uninitialized.
70739cbe 8459
07b48fa9
PE
8460 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8461
8868a238 8462 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8463 * window.c (window_loop, size_window):
8464 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8465
7e5cf297 8466 * window.c (display_buffer): Now static.
d6550a9f
PE
8467 (size_window): Mark variables that gcc -Wuninitialized
8468 does not deduce are never used uninitialized.
a586633d
PE
8469 * window.h (check_all_windows): New decl, to forestall
8470 gcc -Wmissing-prototypes diagnostic.
5b555da1 8471 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8472
f6095868
PE
8473 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8474 shadowing.
8475 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8476 Include <limits.h>.
8477 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8478 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8479 (load_charset_map): Mark variables that gcc -Wuninitialized
8480 does not deduce are never used uninitialized.
53df7c11 8481 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8482
f38b440c
PE
8483 * coding.c (coding_set_source, coding_set_destination):
8484 Use "else { /* comment */ }" rather than "else /* comment */;"
8485 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8486 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8487 a block, when the outer 'i' will do.
8488 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8489 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8490 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8491 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8492 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8493 Rename locals to avoid shadowing.
8494 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8495 * coding.c (emacs_mule_char, encode_invocation_designation):
8496 Now static, since they're not used elsewhere.
413bb2db 8497 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8498 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8499 (decode_coding_emacs_mule): Mark variables that gcc
8500 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8501 (detect_coding_iso_2022): Initialize a local variable that might
8502 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8503 this initialization is needed. (Bug#8211)
5f58e762
PE
8504 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8505 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8506 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8507 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8508 Remove unused macros.
f38b440c 8509
232b38b9 8510 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8511 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8512 * character.c (string_count_byte8): Likewise.
232b38b9 8513
fb90da1b
PE
8514 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8515 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8516
fb93dbc2
PE
8517 * chartab.c (copy_sub_char_table): Now static, since it's not used
8518 elsewhere.
5c156ace
PE
8519 (sub_char_table_ref_and_range, char_table_ref_and_range):
8520 Rename locals to avoid shadowing.
bbcd0949 8521 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8522
7d3b3862 8523 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8524 (BIDI_BOB): Remove unused macro.
7d3b3862 8525
6be7d3da
PE
8526 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8527 deduce are never used uninitialized.
c2ed9c8b 8528 * term.c (encode_terminal_code): Likewise.
6be7d3da 8529
75f8807f 8530 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8531
50938595
PE
8532 * tparam.h: New file.
8533 * term.c, tparam.h: Include it.
8534 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8535 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8536 Move these decls to tparam.h, and make them agree with what
8537 is actually in tparam.c. The previous trick of using incompatible
8538 decls in different modules does not conform to the C standard.
8539 All callers of tparam changed to use tparam's actual API.
8540 * tparam.c (tparam1, tparam, tgoto):
8541 Use const pointers where appropriate.
8542
fbceeba2
PE
8543 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8544 * cm.h (struct cm): Likewise.
8545 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8546 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8547 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8548 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8549 (turn_on_face, init_tty): Likewise.
8550 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8551
7f3f1250
PE
8552 * term.c (term_mouse_position): Rename local to avoid shadowing.
8553
e6ca6543
PE
8554 * alloc.c (mark_ttys): Move decl from here ...
8555 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8556
c40f8d15
AS
85572011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8558
8559 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8560
cfe0661d
JB
85612011-03-09 Juanma Barranquero <lekktu@gmail.com>
8562
8563 * search.c (compile_pattern_1): Remove argument regp, unused since
8564 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8565 (compile_pattern): Don't pass it.
8566
0afb4571
J
85672011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8568
8569 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8570 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8571 for ! HAVE_GTK3.
8572 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8573
8574 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8575
8576 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8577 gdk_window_get_screen, gdk_window_get_geometry,
8578 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8579 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8580 (xg_get_pixbuf_from_pixmap): New function.
8581 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8582 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8583 Call xg_get_pixbuf_from_pixmap instead of
8584 gdk_pixbuf_get_from_drawable.
8585 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8586 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8587 (xg_check_special_colors): Use GtkStyleContext and its functions
8588 for HAVE_GTK3.
8589 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8590 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8591 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8592 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8593 Call gtk_widget_get_preferred_size.
0afb4571
J
8594 (xg_frame_resized): gdk_window_get_geometry only takes 5
8595 parameters.
44f230aa
SM
8596 (xg_win_to_widget, xg_event_is_for_menubar):
8597 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8598 (xg_set_widget_bg): New function.
8599 (delete_cb): New function.
895009e1 8600 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8601 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8602 (xg_set_background_color): Call xg_set_widget_bg.
8603 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8604 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8605 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8606 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8607 if ! HAVE_GTK3.
8608 (update_frame_tool_bar): Call gtk_widget_hide.
8609 (xg_initialize): Use GDK_KEY_g.
8610
8611 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8612 if ! HAVE_GTK3
8613 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8614
8615 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8616 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8617 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8618
1c2cc4ef
JB
86192011-03-08 Juanma Barranquero <lekktu@gmail.com>
8620
8621 * w32xfns.c (select_palette): Check success of RealizePalette against
8622 GDI_ERROR, not zero.
8623
33383987 8624See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8625
8626;; Local Variables:
8627;; coding: utf-8
aac0c6e3
MR
8628;; End:
8629
33383987 8630 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8631
8632 This file is part of GNU Emacs.
8633
8634 GNU Emacs is free software: you can redistribute it and/or modify
8635 it under the terms of the GNU General Public License as published by
8636 the Free Software Foundation, either version 3 of the License, or
8637 (at your option) any later version.
8638
8639 GNU Emacs is distributed in the hope that it will be useful,
8640 but WITHOUT ANY WARRANTY; without even the implied warranty of
8641 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8642 GNU General Public License for more details.
8643
8644 You should have received a copy of the GNU General Public License
8645 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.