Use empty_unibyte_string where applicable.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4a7edc24
DA
12012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Use empty_unibyte_string where applicable.
4 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
5 * lread.c (read1): Likewise.
6 * xsettings.c (syms_of_xsettings): Likewise.
7
308aab79
GM
82012-07-12 Glenn Morris <rgm@gnu.org>
9
42bd1719
GM
10 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
11 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
12 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
13 * s/hpux10-20.h (RUN_TIME_REMAP):
14 * s/bsd-common.h (TABDLY): Move to configure.
15
16 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
17
18 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
19
ea0bbd17 20 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 21 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
22
23 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 24
308aab79
GM
25 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
26 * s/template.h: Move NARROWPROTO to configure.
27
ee1cf5cf
GM
282012-07-11 Glenn Morris <rgm@gnu.org>
29
30fe9bf4
GM
30 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
31 unused since 2011-01-17 change to systty.h.
32
ee1cf5cf
GM
33 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
34 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
35 Move HAVE_PTYS and HAVE_SOCKETS to configure.
36
63e47e07
PE
372012-07-11 Paul Eggert <eggert@cs.ucla.edu>
38
39 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
40
c43fb4c3
GM
412012-07-11 Glenn Morris <rgm@gnu.org>
42
43 * s/darwin.h, s/gnu-linux.h, s/template.h:
44 Move INTERRUPT_INPUT to configure.
45
e8df9267
DA
462012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
47
48 Minor adjustments to interning code.
49 * lisp.h (intern, intern_c_string): Redefine as static inline
50 wrappers for intern_1 and intern_c_string_1, respectively.
51 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
52 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
53 Vobarray checking.
e8df9267
DA
54 * font.c (font_intern_prop): Likewise. Adjust comment.
55 * w32font.c (intern_font_name): Likewise.
56
34348bd4
AS
572012-07-11 Andreas Schwab <schwab@linux-m68k.org>
58
d96a1e0c
AS
59 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
60
34348bd4
AS
61 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
62 of Fcar/Fcdr if possible.
63 * font.c (check_otf_features): Likewise.
64 * fontset.c (Fnew_fontset): Likewise.
65 * gnutls.c (Fgnutls_boot): Likewise.
66 * minibuf.c (read_minibuf): Likewise.
67 * msdos.c (IT_set_frame_parameters): Likewise.
68 * xmenu.c (Fx_popup_dialog): Likewise.
69 * w32menu.c (Fx_popup_dialog): Likewise.
70
c8add24e
GM
712012-07-11 Glenn Morris <rgm@gnu.org>
72
4b575b3c
GM
73 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
74 since nothing has defined it on these platforms.
75
09f4e3b0
GM
76 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
77 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
78
172bedef
GM
79 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
80 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
81 Move CLASH_DETECTION to configure.
82
249685df
GM
83 * s/gnu.h: Remove file, which is now empty.
84
c8add24e
GM
85 * s/gnu.h, s/gnu-linux.h:
86 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
87
b41253a3
JW
882012-07-11 John Wiegley <johnw@newartisans.com>
89
90 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
91 function attribute, so we only use it if it exists in the
92 compiler.
93
d923b542
DA
942012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
95
96 Avoid call to strlen in fast_c_string_match_ignore_case.
97 * search.c (fast_c_string_match_ignore_case): Change to use
98 length argument. Adjust users accordingly.
99 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
100
5ebbef1d
PE
1012012-07-11 Paul Eggert <eggert@cs.ucla.edu>
102
bb352260
PE
103 Assume mkdir, rmdir.
104 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
105 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
106
57054ddd
PE
107 Assume rename.
108 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
109
b747d3f7
PE
110 Assume perror.
111 * s/hpux10-20.h (HAVE_PERROR): Remove.
112 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
113 Remove dummy definition, as this problem was obsolete long ago.
114
5ebbef1d
PE
115 Assume strerror.
116 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
117
984e7f30
DA
1182012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
119
120 Avoid calls to strlen in font processing functions.
121 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 122 (font_open_by_name): Change to use length argument. Adjust
984e7f30 123 users accordingly.
d923b542
DA
124 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
125 Adjust prototypes.
126 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
127 Change to return ptrdiff_t.
984e7f30
DA
128 (xfont_list_pattern, xfont_match): Use length returned by
129 xfont_decode_coding_xlfd.
130 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
131
20e94fdd
GM
1322012-07-11 Glenn Morris <rgm@gnu.org>
133
9d596af3
GM
134 * s/darwin.h, s/freebsd.h, s/netbsd.h:
135 Move DONT_REOPEN_PTY to configure.
136
20e94fdd
GM
137 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
138 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
139
e99a530f
PE
1402012-07-10 Paul Eggert <eggert@cs.ucla.edu>
141
22ffb973
PE
142 Remove "#define unix" that is no longer needed (Bug#11905).
143 * s/aix4-2.h (unix): Remove; no longer needed.
144
e9a9ae03
PE
145 EMACS_TIME simplification (Bug#11875).
146 This replaces macros (which typically do not work in GDB)
147 with functions, typedefs and enums, making the code easier to debug.
148 The functional style also makes code easier to read and maintain.
149 * systime.h: Include <sys/time.h> on all hosts, not just if
150 WINDOWSNT, since 'struct timeval' is needed in general.
151 (EMACS_TIME): Now a typedef, not a macro.
152 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
153 not macros.
154 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
155 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
156 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
157 (EMACS_TIME_LE): Now functions, not macros.
158 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
159 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
160 which are not functions. All uses rewritten to use:
161 (make_emacs_time): New function.
162 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
163 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
164 not functions. All uses rewritten to use the following, respectively:
165 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
166 (add_emacs_time, sub_emacs_time): New functions.
167 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
168 * fileio.c (Fcopy_file):
169 * xterm.c (XTflash): Get the current time closer to when it's used.
170 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
171
ffacb126
PE
172 * bytecode.c (targets): Suppress -Woverride-init warnings.
173
e99a530f
PE
174 Simplify by avoiding confusing use of strncpy etc.
175 * doc.c (Fsnarf_documentation):
176 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
177 * frame.c (Fmake_terminal_frame):
178 * gtkutil.c (get_utf8_string):
179 * lread.c (openp):
180 * nsmenu.m (ns_update_menubar):
181 * regex.c (regerror):
182 Prefer memcpy to strncpy and strncat when either will do.
183 * fileio.c (Fsubstitute_in_file_name):
184 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
185 (menu_separator_name_p):
186 * nsmenu.m (ns_update_menubar):
187 Prefer memcmp to strncmp when either will do.
188 * nsterm.m: Include <ftoastr.h>.
189 (ns_get_color):
190 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
191 Prefer snprintf to strncpy.
192 * nsterm.m (ns_term_init):
193 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
194 * nsterm.m (ns_term_init):
195 Avoid the need for strncpy, by using build_string or
196 make_unibyte_string directly. Use dtoastr, not snprintf.
197 * process.c (Fmake_network_process): Diagnose service names that
198 are too long, rather than silently truncating them or creating
199 non-null-terminated names.
200 (Fnetwork_interface_info): Likewise, for interface names.
201 * sysdep.c (system_process_attributes) [GNU_LINUX]:
202 Prefer sprintf to strncat.
203 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
204 Prefer vsnprintf to vsprintf + strncpy.
205
c59592b3
GM
2062012-07-10 Glenn Morris <rgm@gnu.org>
207
208 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
209 Clarify fallback case.
210
7d7bbefd
DA
2112012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
212
213 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
214 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
215 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 216 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
217 where argument type is known to be a Lisp_Cons.
218
3a4c8000
TT
2192012-07-10 Tom Tromey <tromey@redhat.com>
220
221 * bytecode.c (BYTE_CODE_THREADED): New macro.
222 (BYTE_CODES): New macro. Replaces all old byte-code defines.
223 (enum byte_code_op): New type.
224 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
225 (exec_byte_code): Use them. Use token threading when applicable.
226
2a0213a6
DA
2272012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
228
229 Optimize pure C strings initialization.
230 * lisp.h (make_pure_string): Fix prototype.
231 (build_pure_c_string): New function, defined as static inline. This
232 provides a better opportunity to optimize away calls to strlen when
233 the function is called with compile-time constant argument.
234 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
235 argument, adjust users accordingly. Use build_pure_c_string where
236 appropriate.
237 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
238 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
239 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
240
cb1caeaf
DA
2412012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
242
243 Avoid calls to strlen in miscellaneous functions.
244 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
245 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
246 * lread.c (openp): Likewise.
247
c293e30c
DA
2482012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
249
250 Avoid calls to strlen in path processing functions.
251 * fileio.c (file_name_as_directory): Add comment. Change to add
252 srclen argument and return the length of result. Adjust users
253 accordingly.
254 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 255 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
256 users accordingly.
257 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
258
9e059e3f
GM
2592012-07-10 Glenn Morris <rgm@gnu.org>
260
d02eb359
GM
261 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
262 Move PENDING_OUTPUT_COUNT definition to configure.
263
882cf227
GM
264 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
265 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
266 * s/gnu.h (DATA_START): Move definitions to configure.
267
af6e839f
GM
268 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
269 We include usg5-4-common.h, which defines them both.
270
40289a12
GM
271 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
272 O_RDONLY already includes it).
273
9e059e3f
GM
274 Stop ns builds setting the EMACSLOADPATH environment variable.
275 * nsterm.m (ns_load_path): Rename from ns_init_paths.
276 Now it does not set EMACSLOADPATH, just returns the load-path string.
277 * nsterm.h: Update accordingly.
278 * lread.c [HAVE_NS]: Include nsterm.h.
279 (init_lread) [HAVE_NS]: Use ns_load_path.
280 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
281
7c4e8ec0
GM
2822012-07-09 Glenn Morris <rgm@gnu.org>
283
d4f600ff
GM
284 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
285 since the included bsd-common.h does so.
286
cbb31951
GM
287 Stop ns builds setting the EMACSPATH environment variable.
288 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
289 (ns_init_paths): Do not set EMACSPATH.
290 * nsterm.h (ns_exec_path): Add it.
291 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
292 Use ns_exec_path.
293
7c4e8ec0
GM
294 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
295
26bccfae
PE
2962012-07-09 Paul Eggert <eggert@cs.ucla.edu>
297
a0bee46f
PE
298 * process.c (wait_reading_process_output): 'waitchannels' was unset
299 when read_kbd || !NILP (wait_for_cell); fix this.
300
5994c183
PE
301 Add GCC-style 'const' attribute to functions that can use it.
302 * character.h (char_resolve_modifier_mask):
303 * keyboard.h (make_ctrl_char):
304 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
305 (init_character_once, next_almost_prime, init_fns, init_image)
306 (flush_pending_output, init_sound):
307 * mem-limits.h (start_of_data):
308 * menu.h (finish_menu_items):
309 Add ATTRIBUTE_CONST.
310 * emacs.c (DEFINE_DUMMY_FUNCTION):
311 Declare the dummy function with ATTRIBUTE_CONST.
312 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
313 Add decls with ATTRIBUTE_CONST.
314
26bccfae
PE
315 Minor improvements to make_formatted_string.
316 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
317 where int is good enough, as vsprintf returns an int.
318 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
319
a8290ec3
DA
3202012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
321
322 Use make_formatted_string to avoid double length calculation.
323 * lisp.h (make_formatted_string): New prototype.
324 * alloc.c (make_formatted_string): New function.
325 * buffer.c (Fgenerate_new_buffer_name): Use it.
326 * dbus.c (syms_of_dbusbind): Likewise.
327 * editfns.c (Fcurrent_time_zone): Likewise.
328 * filelock.c (get_boot_time): Likewise.
329 * frame.c (make_terminal_frame, set_term_frame_name)
330 (x_report_frame_params): Likewise.
331 * image.c (gs_load): Likewise.
332 * minibuf.c (get_minibuffer): Likewise.
333 * msdos.c (dos_set_window_size): Likewise.
334 * process.c (make_process): Likewise.
335 * xdisp.c (ensure_echo_area_buffers): Likewise.
336 * xsettings.c (apply_xft_settings): Likewise.
337
d01ba2f1
GM
3382012-07-09 Glenn Morris <rgm@gnu.org>
339
340 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
341 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
342 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
343 * nsterm.h (ns_etc_directory): Add it.
344 * callproc.c [HAVE_NS]: Include nsterm.h.
345 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
346
f1f924b6
DA
3472012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
348
349 Move marker debugging code under MARKER_DEBUG.
350 * marker.c (MARKER_DEBUG): Move marker debugging code under
351 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
352 for bootstrap with --enable-checking (~3x slowdown reported
353 by Juanma Barranquero <lekktu@gmail.com>).
354 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
355
ab531b66
PE
3562012-07-08 Paul Eggert <eggert@cs.ucla.edu>
357
358 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
359 See <http://bugs.gnu.org/11825#29>.
360
c4b3bc8a
EZ
3612012-07-08 Eli Zaretskii <eliz@gnu.org>
362
363 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
364 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
365 (display_line): Add commentary about displaying truncation glyphs
366 on GUI frames.
367 (produce_special_glyphs): Move here from term.c.
368
369 * term.c (produce_special_glyphs): Move to xdisp.c.
370
371 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
372 section.
c4b3bc8a 373
b676b881
AS
3742012-07-07 Andreas Schwab <schwab@linux-m68k.org>
375
f17c5273
AS
376 * xdisp.c (display_line): Avoid warning about implicit declaration
377 of FRAME_FONT.
378
298819b9
AS
379 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
380
b676b881
AS
381 * lisp.h: Remove empty conditional.
382
6045c4fd
PE
3832012-07-07 Paul Eggert <eggert@cs.ucla.edu>
384
b3350bf9
PE
385 * lread.c (load_path_check): Now static.
386
6045c4fd
PE
387 Fix some minor --with-ns problems found by static checking.
388 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
389 (x_set_font) [!HAVE_X_WINDOWS]:
390 * image.c (xpm_load_image) [HAVE_NS]:
391 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
392 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
393 Remove unused local.
394 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
395 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
396 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
397 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
398 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
399 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
400 Fix pointer signedness problem.
401 * xfaces.c (FRAME_X_FONT_TABLE):
402 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
403
929e7845
GM
4042012-07-07 Glenn Morris <rgm@gnu.org>
405
406 * lread.c (load_path_check): New function, split from init_lread.
407 (init_lread): Reorganize. Motivation:
408 If EMACSLOADPATH is set, check/warn about that rather than the
409 defaults, which we are not going to use. Hence we can remove
410 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
411 Don't warn if site-lisp directories are missing.
412 If not installed, start from a blank load-path, since
413 PATH_LOADSEARCH refers to the eventual installation directories.
414
58dd0aa4
EZ
4152012-07-07 Eli Zaretskii <eliz@gnu.org>
416
417 Support truncation and continuation glyphs on GUI frames, when
418 fringes are disabled. (Bug#11832)
419 * xdisp.c (init_iterator): Get dimensions of truncation and
420 continuation glyphs even if on GUI frames. Adjust
421 it->last_visible_x on GUI frames when the left or right fringes,
422 or both, are absent.
423 (start_display, move_it_in_display_line_to): Handle the case of a
424 GUI frame without a fringe to display continuation or truncation
425 glyphs.
426 (insert_left_trunc_glyphs): Support GUI frames: make sure
427 truncation glyphs overwrite enough glyphs from the current line to
428 have sufficient space in pixels.
429 (display_line): Support truncation and continuation glyphs on GUI
430 frames. If some spare pixels are left on the line after inserting
431 the truncation glyphs, fill that space with a stretch glyph of a
432 suitably computed width.
433
434 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
435 produce_glyphs, to support GUI sessions.
436
31571fd7
PE
4372012-07-07 Paul Eggert <eggert@cs.ucla.edu>
438
5a16b9bc
PE
439 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
440
f3047c75
PE
441 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
442
31571fd7
PE
443 Do not require float-time's arg to fit in time_t (Bug#11825).
444 This works better on hosts where time_t is unsigned, and where
445 float-time is applied to the (negative) difference between two times.
446 * editfns.c (decode_time_components): Last arg is now double *,
447 not int *, and means to store all the result as a double, without
448 worrying about whether the seconds part fits in time_t.
449 All callers changed.
450 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
451 All callers changed.
452 (Ffloat_time): Do not fail merely because the specified time falls
453 outside of time_t range.
454
4516fbef
GM
4552012-07-07 Glenn Morris <rgm@gnu.org>
456
457 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
458 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
459 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
460
07adc2c6
JB
4612012-07-07 Juanma Barranquero <lekktu@gmail.com>
462
463 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
464 Update dependencies.
465
466 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
467
fd573f31
PE
4682012-07-06 Paul Eggert <eggert@cs.ucla.edu>
469
fee5959d
PE
470 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
471 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
472 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
473 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
474 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
475 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
476
fd573f31
PE
477 * xfont.c (compare_font_names): Redo to omit the need for casts.
478
ddadbc0e
AS
4792012-07-06 Andreas Schwab <schwab@linux-m68k.org>
480
fca8d6b6
AS
481 * xfns.c (Fx_change_window_property): Doc fix.
482 * w32fns.c (Fx_change_window_property): Doc fix.
483
ddadbc0e
AS
484 * w32fns.c (Fx_window_property): Accept the same arguments as the
485 X Windows version. Doc fix.
486 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
487
f247498e
JB
4882012-07-06 Juanma Barranquero <lekktu@gmail.com>
489 Eli Zaretskii <eliz@gnu.org>
490
491 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
492 Windows-specific code from nt/config.nt moved here.
493 Obsolete settings removed.
494
216ee680
PE
4952012-07-06 Paul Eggert <eggert@cs.ucla.edu>
496
497 * process.c: Avoid unnecessary calls to gettime.
498 (wait_reading_process_output): Don't get the time of day
499 when gobbling data immediately and not waiting, as there's no need
500 for it in that case. This removes a FIXME.
501
bdd091e4
JD
5022012-07-06 Jan Djärv <jan.h.d@swipnet.se>
503
504 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
505 is defined (Bug#11768).
506
9d44f8ce
DA
5072012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
508
509 Fix marker debugging code.
510 * marker.c (byte_char_debug_check): Do not perform the check
511 if buffer is not multibyte.
090bd7cb
JB
512 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
513 Call byte_char_debug_check with correct arguments.
9d44f8ce 514
90fc4786
DA
5152012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
516
517 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
518 * marker.c (byte_char_debug_check, count_markers):
519 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
520 (byte_debug_flag): Remove.
521 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
522 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
523
7b7ae965
DA
5242012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
525
4e57b342
DA
526 Avoid code repetition in marker-related functions.
527 * marker.c (attach_marker): New function.
528 (Fset_marker, set_marker_restricted, set_marker_both)
529 (set_marker_restricted_both): Use it.
530 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
531 Consistently rename charno to charpos.
532 (marker_position): Add eassert.
533 (marker_byte_position): Convert to eassert.
534
5352012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
536
537 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 538 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 539 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 540
657924ff
DA
5412012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
542
543 Introduce fast path for the widely used marker operation.
544 * alloc.c (build_marker): New function.
545 * lisp.h (build_marker): New prototype.
546 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
547 * composite.c (autocmp_chars): Likewise.
548 * editfns.c (buildmark): Remove.
549 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
550 (save_restriction_save): Use build_marker.
551 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
552 * window.c (save_window_save): Likewise.
553
041a49a6
DA
5542012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
555
556 Do not use Fdelete_overlay in delete_all_overlays
557 to avoid redundant calls to unchain_overlay.
558 * buffer.c (drop_overlay): New function.
559 (delete_all_overlays, Fdelete_overlay): Use it.
560 * minibuf.c (get_minibuffer): Fix comment.
561
7dca65a4
PE
5622012-07-06 Paul Eggert <eggert@cs.ucla.edu>
563
564 Port to OpenBSD 5.1 amd64.
565 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
566 This is needed for OpenBSD, and should be harmless on all BSD systems.
567 Also, include <sys/sysctl.h>, as it should be available on all
568 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
569 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
570 use p_pid member, not kp_proc.pid.
571
8eb876e2
GM
5722012-07-06 Glenn Morris <rgm@gnu.org>
573
574 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
575
38182d90
PE
5762012-07-05 Paul Eggert <eggert@cs.ucla.edu>
577
578 More xmalloc and related cleanup.
579 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
580 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
581 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
582 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
583 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
584 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
585 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
586 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
587 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
588 * xterm.c:
589 Omit needless casts involving void * pointers and allocation.
590 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
591 as the former is more robust if P's type is changed.
592 Prefer xzalloc to xmalloc + memset 0.
593 Simplify malloc-or-realloc to realloc.
594 Don't worry about xmalloc returning a null pointer.
595 Prefer xstrdup to xmalloc + strcpy.
596 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
597 growing it.
598 * keyboard.c (apply_modifiers_uncached): Prefer local array to
599 alloca of a constant.
600
6dd5a677
EZ
6012012-07-05 Eli Zaretskii <eliz@gnu.org>
602
603 * xdisp.c (display_line): Fix horizontal pixel coordinates when
604 hscroll is larger than the line width. Fixes long and futile
605 looping inside extend_face_to_end_of_line (on a TTY) producing
606 glyphs that are not needed and thrown away.
607
6b312f0f
DA
6082012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
609
610 * marker.c (set_marker_restricted_both): Simplify by using
611 clip_to_bounds.
612
f520ef9b
PE
6132012-07-05 Paul Eggert <eggert@cs.ucla.edu>
614
615 * editfns.c (region_limit): Simplify by using clip_to_bounds.
616
383b7c95
JD
6172012-07-05 Jan Djärv <jan.h.d@swipnet.se>
618
619 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
620 not defined (Bug#11768).
621 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
622 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
623 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
624 followed by gtk_box_set_homogeneous (Bug#11768).
625 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
626 (update_theme_scrollbar_width, xg_create_scroll_bar):
627 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
628 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
629 (is_box_type): New function (Bug#11768).
630 (xg_tool_item_stale_p): Call is_box_type.
5293d758 631 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
632 with default display (Bug#11768).
633
d6e7bf45
EZ
6342012-07-05 Eli Zaretskii <eliz@gnu.org>
635
636 * xdisp.c (window_hscroll_limited): New function.
637 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
638 coordinates when window's hscroll is set to insanely large
639 values. (Bug#11857)
640
431391ec
JB
6412012-07-05 Juanma Barranquero <lekktu@gmail.com>
642
643 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
644 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
645
23f86fce
DA
6462012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
647
648 Cleanup xmalloc.
649 * lisp.h (xzalloc): New prototype. Omit needless casts.
650 * alloc.c (xzalloc): New function. Omit needless casts.
651 * charset.c: Omit needless casts. Convert all calls to
652 xmalloc with following memset to xzalloc.
653 * dispnew.c: Likewise.
654 * fringe.c: Likewise.
655 * image.c: Likewise.
656 * sound.c: Likewise.
657 * term.c: Likewise.
658 * w32fns.c: Likewise.
659 * w32font.c: Likewise.
660 * w32term.c: Likewise.
661 * xfaces.c: Likewise.
662 * xfns.c: Likewise.
663 * xterm.c: Likewise.
664 * atimer.c: Omit needless casts.
665 * buffer.c: Likewise.
666 * callproc.c: Likewise.
667 * ccl.c: Likewise.
668 * coding.c: Likewise.
669 * composite.c: Likewise.
670 * doc.c: Likewise.
671 * doprnt.c: Likewise.
672 * editfns.c: Likewise.
673 * emacs.c: Likewise.
674 * eval.c: Likewise.
675 * filelock.c: Likewise.
676 * fns.c: Likewise.
677 * gtkutil.c: Likewise.
678 * keyboard.c: Likewise.
679 * lisp.h: Likewise.
680 * lread.c: Likewise.
681 * minibuf.c: Likewise.
682 * msdos.c: Likewise.
683 * print.c: Likewise.
684 * process.c: Likewise.
685 * region-cache.c: Likewise.
686 * search.c: Likewise.
687 * sysdep.c: Likewise.
688 * termcap.c: Likewise.
689 * terminal.c: Likewise.
690 * tparam.c: Likewise.
691 * w16select.c: Likewise.
692 * w32.c: Likewise.
693 * w32reg.c: Likewise.
694 * w32select.c: Likewise.
695 * w32uniscribe.c: Likewise.
696 * widget.c: Likewise.
697 * xdisp.c: Likewise.
698 * xmenu.c: Likewise.
699 * xrdb.c: Likewise.
700 * xselect.c: Likewise.
701
0497dc44
PE
7022012-07-05 Paul Eggert <eggert@cs.ucla.edu>
703
704 * fileio.c (time_error_value): Check the right error number.
705 Problem reported by Troels Nielsen in
706 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
707
356e7178
PE
7082012-07-04 Paul Eggert <eggert@cs.ucla.edu>
709
4e71fd89
PE
710 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
711 This should be fixed in a better way; see Eli Zaretskii in
712 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
713 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
714
f0941253
PE
715 * fileio.c (time_error_value): Rename from special_mtime.
716 The old name's problems were noted by Eli Zaretskii in
717 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
718
065c9eb4
PE
719 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
720 This variable's comment says Emacs needs at least one GDB-visible
721 symbol of type enum pvec_type, to work around GDB problems.
722 The symbol's value doesn't matter.
723
356e7178
PE
724 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
725 that causes compilation to fail on pre-C99 compilers.
726
95f61aa2
JB
7272012-07-04 Juanma Barranquero <lekktu@gmail.com>
728
729 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
730 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
731
3884d954
DA
7322012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
733
d209e2fb 734 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
735 headers for buffer_defaults and buffer_local_symbols.
736 Reported by Juanma Barranquero <lekktu@gmail.com>.
737
ee28be33
SM
7382012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
739
740 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
741 * lisp.h (enum pvec_type): Use fewer bits.
742 (PSEUDOVECTOR_SIZE_BITS): New constant.
743 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
744 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
745 change in pvec_type.
746 (PSEUDOVECTOR_TYPEP): New macro.
747 (TYPED_PSEUDOVECTORP): Use it.
748 * fns.c (internal_equal): Adapt code to extract pvectype.
749 * emacs.c (gdb_pvec_type): Update type.
750 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
751 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
752 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
753 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
754 (sweep_vectors): Use it. Use local var `total_bytes' instead of
755 abusing vector->header.next.nbytes.
756 (live_vector_p): Use PVEC_TYPE.
757 (mark_object): Adapt code to extract pvectype. Use switch.
758
c7f2cd7f
PE
7592012-07-04 Paul Eggert <eggert@cs.ucla.edu>
760
761 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
762 Tighten new eassert a bit.
763
8ce70ed2
DA
7642012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
765
766 Fix compilation with --enable-gcc-warnings and -O1
767 optimization level.
768 * doprnt.c (doprnt): Change type of tem to int, initialize
769 to avoid compiler warning. Add eassert.
770 * search.c (simple_search): Initialize match_byte to avoid
771 compiler warning. Add eassert.
772
dea7f1e5
PE
7732012-07-04 Paul Eggert <eggert@cs.ucla.edu>
774
24a212eb
PE
775 Avoid weird behavior with large horizontal scrolls.
776 Without this change, for example, large hscroll values would
777 mess up Emacs's display on Fedora 15 x86, presumably due to
778 overflows in int calculations in the display code.
779 Also, if buffers had long lines, Emacs would freeze.
780 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
781 (set_window_hscroll): New function, containing the old guts of
782 Fset_window_hscroll. Return the clipped value.
783 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
784 This avoids the need to check against PTRDIFF_MAX.
785
dea7f1e5
PE
786 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
787
76046526
DA
7882012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
789
790 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
791
39adff0d
PE
7922012-07-04 Paul Eggert <eggert@cs.ucla.edu>
793
63807d47
PE
794 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
795 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
796 since GCC 4.4.6 issues a bogus warning for them.
797
39adff0d
PE
798 Fix bugs in file timestamp newness comparisons.
799 * fileio.c (Ffile_newer_than_file_p):
800 * lread.c (Fload): Use full timestamp resolution of files,
801 not just the 1-second resolution, so that files that are only
802 slightly newer still count as newer.
803 * fileio.c (Ffile_newer_than_file_p): Don't assume file
804 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
805
dbeed9a6
PE
8062012-07-03 Paul Eggert <eggert@cs.ucla.edu>
807
808 * fileio.c: Improve handling of file time marker. (Bug#11852)
809 (special_mtime): New function.
810 (Finsert_file_contents, Fverify_visited_file_modtime):
811 Use it to set special mtime values consistently.
812
636334d6
AS
8132012-07-03 Andreas Schwab <schwab@linux-m68k.org>
814
815 * fileio.c (Finsert_file_contents): Properly handle st_mtime
816 marker for non-existing file. (Bug#11852)
817
e2017fe2
GM
8182012-07-03 Glenn Morris <rgm@gnu.org>
819
820 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
821 and did not make it into globals.h).
822
404dbd37
TT
8232012-07-03 Tom Tromey <tromey@redhat.com>
824
825 * window.c (Fset_window_margins, Fset_window_fringes)
826 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
827 * textprop.c (Fprevious_property_change): No longer static.
828 * syntax.c (Fsyntax_table_p): No longer static.
829 * process.c (Fget_process, Fprocess_datagram_address): No longer
830 static.
831 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
832 * keyboard.c (Fcommand_execute): No longer static.
833 Remove EXFUN.
834 * insdel.c (Fcombine_after_change_execute): No longer static.
835 * image.c (Finit_image_library): No longer static.
836 * fileio.c (Fmake_symbolic_link): No longer static.
837 * eval.c (Ffetch_bytecode): No longer static.
838 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
839 * doc.c (Fdocumentation_property, Fsnarf_documentation):
840 No longer static.
404dbd37
TT
841 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
842 static.
843 * dired.c (Ffile_attributes): No longer static.
844 * composite.c (Fcomposition_get_gstring): No longer static.
845 * callproc.c (Fgetenv_internal): No longer static.
846
847 * ccl.h: Remove EXFUNs.
848 * buffer.h: Remove EXFUNs.
849 * dispextern.h: Remove EXFUNs.
850 * intervals.h: Remove EXFUNs.
851 * fontset.h: Remove EXFUN.
852 * font.h: Remove EXFUNs.
853 * dosfns.c (system_process_attributes): Remove EXFUN.
854 * keymap.h: Remove EXFUNs.
855 * lisp.h: Remove EXFUNs.
856 * w32term.h: Remove EXFUNs.
857 * window.h: Remove EXFUNs.
858 * xsettings.h: Remove EXFUN.
859 * xterm.h: Remove EXFUN.
860
8e4fd1e1
GM
8612012-07-03 Glenn Morris <rgm@gnu.org>
862
863 * lisp.h (Frandom): Make it visible to C.
864 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
865 buffer for invisible buffers. (Bug#1229)
866
ca95b3eb
DA
8672012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
868
869 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
870 values which aren't power of 2.
871 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
872 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
873 accordingly.
874
7555c33f
SM
8752012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
876
877 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
878
879 * alloc.c (mark_object): Revert part of last patch to use `switch'.
880
d12e8f5a
DA
8812012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
882
883 * alloc.c (allocate_vector_block): Remove redundant
884 calls to mallopt if DOUG_LEA_MALLOC is defined.
885 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
886 avoid calls to mallopt if zero_vector is returned.
887
296094c3
DA
8882012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
889
890 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
891 is enabled, avoid dereferencing NULL current_sblock if
892 running undumped.
893
36429c89
DA
8942012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
895
896 Cleanup basic buffer management.
897 * buffer.h (struct buffer): Change layout to use generic vector
898 marking code. Fix some comments. Change type of 'clip_changed'
899 to bitfield. Remove unused #ifndef old.
900 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
901 (GET_OVERLAYS_AT): Fix indentation.
902 (for_each_per_buffer_object_at): New macro.
903 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
904 (Fbuffer_local_variables): Use it.
905 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
906 * alloc.c (allocate_buffer): Adjust to match new layout of
907 struct buffer. Fix comment.
908 (mark_overlay): New function.
909 (mark_buffer): Use it. Use mark_vectorlike to mark normal
910 Lisp area of struct buffer.
911 (mark_object): Use it. Adjust marking of misc objects
912 and related comments.
913
3b3e4cac
PE
9142012-07-02 Paul Eggert <eggert@cs.ucla.edu>
915
916 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
917 wrapper that is not needed because the wrapped code is a no-op (zero
918 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
919 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
920
cf5c0175
DA
9212012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
922
923 * alloc.c (mark_buffer): Simplify. Remove prototype.
924 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 925 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
926 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
927 redundant calls to mark_vectorlike for bool vectors.
928
ca26824c
GM
9292012-06-30 Glenn Morris <rgm@gnu.org>
930
2e4c5312
GM
931 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
932
ca26824c
GM
933 * epaths.in (PATH_SITELOADSEARCH): New.
934 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
935 This is rather than relying on --enable-locallisppath elements
936 having "site-lisp" in their names. (Bug#10208#25, 11658)
937
0d23c240
EZ
9382012-06-30 Eli Zaretskii <eliz@gnu.org>
939
c9240d7a
EZ
940 * w32proc.c (sys_select): Accept and ignore one more argument.
941
942 * w32.c (emacs_gnutls_pull): Call select with one more argument.
943
0d23c240 944 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 945 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
946
947 * sysdep.c: Don't include dos.h and dosfns.h.
948
949 * process.c (sys_select):
950 * msdos.c (sys_select): Accept one more argument and ignore it.
951
952 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
953 adapt data types and code to that.
954
955 * dosfns.c:
956 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
957 which clashes with the gnulib function of the same name.
958
af5a5a98
AS
9592012-06-30 Andreas Schwab <schwab@linux-m68k.org>
960
c5e4379c
AS
961 * font.c (font_style_to_value, font_style_symbolic)
962 (font_prop_validate_style): Add type checks for values in
963 font_style_table.
964
af5a5a98
AS
965 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
966 argument.
967 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
968 uses.
969
8d38f461
EZ
9702012-06-29 Eli Zaretskii <eliz@gnu.org>
971
2e5a6631
EZ
972 * xdisp.c (try_window_id): Undo last change.
973
8d38f461
EZ
974 * w32.c (getwd): Adjust commentary about startup_dir.
975 (init_environment): Always call sys_access, even in non-MSVC
976 builds. Don't chdir to the directory of the Emacs executable.
977 This undoes code from 1997 which was justified by the need to
978 "avoid conflicts when removing and renaming directories". But its
979 downside was that every relative file name was being interpreted
980 relative to the directory of the Emacs executable, which can never
981 be TRT. In particular, it broke sys_access when called with
982 relative file names.
983 (sys_access): Map GetLastError to errno.
984
2af3565e
DA
9852012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
986
987 * window.h (struct window): Change type of 'fringes_outside_margins'
988 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 989 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
990 Adjust comment.
991 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
992 to ptrdiff_t.
993
c8d3a25c 9942012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 995
c8d3a25c
GM
996 * gnutls.c (emacs_gnutls_handshake):
997 Add QUIT to make the loop interruptible.
57570cd3 998
c8d3a25c 9992012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1000
c8d3a25c
GM
1001 * charset.c (init_charset): Make lack of etc/charsets fatal.
1002
3e984ee8
DA
10032012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1004
1005 * editfns.c (region_limit): Fix type mismatch.
1006
ef884f23
DA
10072012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1008
1009 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1010 undefined. Convert from xassert to eassert.
1011 * nsmenu.m: Convert from xassert to eassert.
1012 * nsterm.m: Likewise.
1013
7d7e0027
SM
10142012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1015
1016 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1017
aa754e6a
PE
10182012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1019
1020 Avoid integer overflow on scroll-left and scroll-right.
1021 * window.c (HSCROLL_MAX): New macro.
1022 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1023 overflow when requested scroll falls outside ptrdiff_t range.
1024
80b00b08
DA
10252012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1026
1027 * window.h (struct window): Change type of 'hscroll',
1028 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1029 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1030 Adjust users accordingly.
1031 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1032 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1033 from EMACS_INT to ptrdiff_t.
1034 (make_window): Omit redundant initialization.
1035
62b2bcf6
JB
10362012-06-28 Juanma Barranquero <lekktu@gmail.com>
1037
1038 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1039
45942c7d
DA
10402012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1041
1042 * window.h (struct window): Change type of 'use_time' and
1043 'sequence_number' from Lisp_Object to int.
1044 * frame.c (make_frame): Adjust users accordingly.
1045 * print.c (print_object): Likewise.
1046 * window.c (select_window, Fwindow_use_time, make_parent_window)
1047 (make_window): Likewise.
1048
e509cfa6
DA
10492012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1050
1051 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1052 enabled with --enable-checking=[all,glyphs] configure option.
1053 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1054 adjust comments accordingly.
1055 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1056 undefined, adjust comments accordingly.
1057 * image.c: Likewise.
1058 * scroll.c: Likewise.
1059 * w32fns.c: Likewise.
1060 * w32term.c: Likewise.
1061 * xdisp.c: Likewise.
1062 * xfaces.c: Likewise.
1063 * xfns.c: Likewise.
1064 * xterm.c: Likewise.
1065
a54e2c05
DA
10662012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1067
1068 Generalize run-time debugging checks.
1069 * dispextern.h (XASSERTS): Remove.
1070 * fontset.c (xassert): Remove.
1071 Convert from xassert to eassert.
1072 * alloc.c: Convert from xassert to eassert.
1073 * bidi.c: Likewise.
1074 * dispnew.c: Likewise.
1075 * fns.c: Likewise.
1076 * fringe.c: Likewise.
1077 * ftfont.c: Likewise.
1078 * gtkutil.c: Likewise.
1079 * image.c: Likewise.
1080 * keyboard.c: Likewise.
1081 * menu.c: Likewise.
1082 * process.c: Likewise.
1083 * scroll.c: Likewise.
1084 * sound.c: Likewise.
1085 * term.c: Likewise.
1086 * w32console.c: Likewise.
1087 * w32fns.c: Likewise.
1088 * w32term.c: Likewise.
1089 * window.c: Likewise.
1090 * xdisp.c: Likewise.
1091 * xfaces.c: Likewise.
1092 * xfns.c: Likewise.
1093 * xselect.c: Likewise.
1094 * xterm.c: Likewise.
1095
1ec4b7b2
SM
10962012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1097
1098 * fns.c (maybe_resize_hash_table): Output message when growing the
1099 purify-hashtable.
1100
2014308a
DA
11012012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1102
1103 * alloc.c (allocate_string_data): Remove dead code.
1104 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1105 avoid GCC warning about unused macro.
1106
246155eb
DA
11072012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1108
1109 * alloc.c (allocate_string): Omit intervals initialization.
1110 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1111 as in make_pure_string and make_pure_c_string.
1112
43184b7b
DA
11132012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1114
d209e2fb 1115 * alloc.c (allocate_string): Fix last change.
43184b7b 1116
3fe6dd74
DA
11172012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1118
d209e2fb 1119 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1120 to memset, add explicit initialization where appropriate.
1121
1ba6038a
GM
11222012-06-27 Glenn Morris <rgm@gnu.org>
1123
1124 * lisp.mk (lisp): Remove paths.elc.
1125
c89926a5
CY
11262012-06-27 Chong Yidong <cyd@gnu.org>
1127
1128 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1129
ed6b3510
JW
11302012-06-26 John Wiegley <johnw@newartisans.com>
1131
1ec4b7b2 1132 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1133 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1134
ed6b3510
JW
1135 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1136 when building with Clang.
1137
8edd4a2b
SM
11382012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1139
1140 * eval.c (Fapply): Allow calling it with a single argument.
1141
f6f62d1b
EZ
11422012-06-26 Eli Zaretskii <eliz@gnu.org>
1143
1144 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1145 _stricmp and _strnicmp.
1146 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1147
62efea5e
DA
11482012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1149
1150 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1151 allocated window.
1152 (allocate_process): Likewise for new process.
8edd4a2b 1153 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1154 (allocate_frame): Likewise.
1155 * frame.c (make_frame): Omit redundant initialization.
1156 * window.c (make_parent_window): Use memset.
1157 (make_window): Omit redundant initialization.
1158 * process.c (make_process): Omit redundant initialization.
1159 * terminal.c (create_terminal): Likewise.
1160
42997f4d
DA
11612012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1162
1163 * term.c (delete_tty): Remove redundant call to memset.
1164
1130ecfc
DA
11652012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1166
1167 * alloc.c: Remove build_string.
1168 * lisp.h: Define build_string as static inline. This provides
1169 a better opportunity to optimize away calls to strlen when the
1170 function is called with compile-time constant argument.
1171 * image.c (imagemagick_error): Convert to build_string.
1172 * w32proc.c (sys_spawnve): Likewise.
1173 * xterm.c (x_term_init): Likewise.
1174
cf38a720
PE
11752012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1176
99027bdd
PE
1177 Use sprintf return value instead of invoking strlen on result.
1178 In the old days this wasn't portable, since some sprintf
1179 implementations returned char *. But they died out years ago and
1180 Emacs already assumes sprintf returns int.
1181 Similarly for float_to_string.
1182 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1183 * ccl.c (ccl_driver):
1184 * character.c (string_escape_byte8):
1185 * data.c (Fnumber_to_string):
1186 * doprnt.c (doprnt):
1187 * print.c (print_object):
1188 * xdisp.c (message_dolog):
1189 * xfns.c (syms_of_xfns):
1190 Use sprintf or float_to_string result to avoid need to call strlen.
1191 * data.c (Fnumber_to_string):
1192 Use make_unibyte_string, since the string must be ASCII.
1193 * lisp.h, print.c (float_to_string): Now returns int length.
1194 * term.c (produce_glyphless_glyph):
1195 Use sprintf result rather than recomputing it.
1196
cf38a720
PE
1197 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1198 * Makefile.in (ALL_CFLAGS):
1199 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1200 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1201
3511c784
DA
12022012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1203
0a08eb21 1204 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1205 strcasecmp if available.
1206 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1207
fb7da12e
AS
12082012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1209
1210 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1211 Avoid comma operator.
1212 * menu.c (push_submenu_start, push_submenu_end)
1213 (push_left_right_boundary, push_menu_pane): Likewise.
1214 * msdos.c (dos_rawgetc): Likewise.
1215
afa2ffd8
DA
12162012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1217
1218 * xfns.c (xic_create_fontsetname): Remove redundant calls
1219 to memset.
1220
b3b4476b
PE
12212012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1222
4495ff38
PE
1223 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1224 sprintf already null-terminates its output.
1225
b3b4476b
PE
1226 * xfns.c (x_window): Remove redundant cast.
1227
b00876c9
DA
12282012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1229
1230 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1231 `const char *' to `char *' to avoid compiler warning.
1232
d188e26b
PE
12332012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1234
885d1d74
PE
1235 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1236 instead of truncating it to 63 (admittedly a generous limit).
1237
d188e26b
PE
1238 * process.c: Fix spelling and caps in comments.
1239
e2f560b1
DN
12402012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1241
e86db54b 1242 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1243 * sysdep.c (setpgrp): Remove definition, not used in this file.
1244
7583a3a1
JB
12452012-06-24 Juanma Barranquero <lekktu@gmail.com>
1246
1247 * makefile.w32-in: Update dependencies.
1248
696056c2
EZ
12492012-06-24 Eli Zaretskii <eliz@gnu.org>
1250
1251 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1252 (SYSTIME_H): Add nt/inc/sys/time.h.
1253
1254 * systime.h [WINDOWSNT]: Include sys/time.h.
1255
1256 * s/ms-w32.h (struct timespec): Definition moved from
1257 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1258
845ca893
PE
12592012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1260
1261 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1262 * buffer.h (buffer_slot_type_mismatch):
1263 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1264 * eval.c (unwind_to_catch):
1265 * image.c (my_png_error, my_error_exit):
1266 * keyboard.c (quit_throw_to_read_char, user_error)
1267 (Fexit_recursive_edit, Fabort_recursive_edit):
1268 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1269 (wrong_type_argument, buffer_overflow, __executable_start)
1270 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1271 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1272 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1273 (fatal):
1274 (child_setup) [!DOS_NT]:
1275 * lread.c (end_of_file_error, invalid_syntax):
1276 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1277 * puresize.h (pure_write_error):
1278 * search.c (matcher_overflow):
1279 * sound.c (sound_perror, alsa_sound_perror):
1280 * sysdep.c, syssignal.h (croak):
1281 * term.c (maybe_fatal, vfatal):
1282 * textprop.c (text_read_only):
1283 * undo.c (user_error):
1284 * unexmacosx.c (unexec_error):
1285 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1286 Use _Noreturn rather than NO_RETURN.
1287 No need for separate decl merely because of _Noreturn.
1288 * sound.c (sound_warning, parse_sound):
1289 Remove unnecessary forward decls.
1290
f1dd8073
PE
12912012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1292
1293 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1294 * lisp.h (WAIT_READING_MAX): New macro.
1295 * dispnew.c (Fsleep_for, sit_for):
1296 * keyboard.c (kbd_buffer_get_event):
1297 * process.c (Faccept_process_output):
1298 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1299 This improves on the previous patch, which introduced a bug
1300 when time_t is unsigned and as wide as intmax_t.
1301 See <http://bugs.gnu.org/9000#51>.
1302
b82c1755
EZ
13032012-06-23 Eli Zaretskii <eliz@gnu.org>
1304
1305 * dispnew.c (sit_for, Fsleep_for):
1306 * keyboard.c (kbd_buffer_get_event):
1307 * process.c (Faccept_process_output): Avoid compiler warnings when
1308 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1309
ca300656
JB
13102012-06-23 Juanma Barranquero <lekktu@gmail.com>
1311
049ec95b
JB
1312 * makefile.w32-in: Update dependencies.
1313
ca300656
JB
1314 * w32.c (ltime): Add return type and declare static.
1315 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1316
db7b8d06
PE
13172012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1318
1319 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1320 Privately reported by Herbert J. Skuhra.
1321 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1322 All uses changed.
1323 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1324 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1325
0bd8297f
EZ
13262012-06-23 Eli Zaretskii <eliz@gnu.org>
1327
96512555
EZ
1328 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1329 last argument of make_unibyte_string.
1330
0bd8297f
EZ
1331 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1332 language ID in the event parameters.
1333
1334 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1335 event.code, not the obscure "character set ID".
1336
63def6b6
CY
13372012-06-23 Chong Yidong <cyd@gnu.org>
1338
1339 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1340
e8a02204
EZ
13412012-06-23 Eli Zaretskii <eliz@gnu.org>
1342
388cdec0
EZ
1343 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1344 * w32.c (fdutimens): New function.
1345
1346 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1347
1348 * s/ms-w32.h (pselect): Redirect to sys_select.
1349
1350 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1351
e8a02204
EZ
1352 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1353 in the logic of incrementing and decrementing the value of
1354 use_relocatable_buffers.
1355
d054f3fb
PE
13562012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1357
1358 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1359 Privately reported by Herbert J. Skuhra.
1360 [__FreeBSD__]: Remove "*/" typo after "#include".
1361 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1362 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1363 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1364 Don't assume EMACS_TIME and struct timeval are the same type.
1365
d35af63c
PE
13662012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1367
1368 Support higher-resolution time stamps (Bug#9000).
1369 The time stamps are only nanosecond-resolution at the C level,
1370 since that's the best that any real-world system supports now.
1371 But they are picosecond-resolution at the Lisp level, as that's
1372 easy, and leaves room for future OS improvements.
1373
1374 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1375 (LIBES): Use it.
1376
1377 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1378 Don't get current time unless it's needed.
1379
1380 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1381 now provides it if it's absent.
1382 (start_atimer): Port to higher-res time stamps.
1383 Check for time stamp overflow. Don't get current time more
1384 often than is needed.
1385
1386 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1387 Include systime.h, not time.h.
1388 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1389
1390 * dired.c: Include stat-time.h.
1391 (Ffile-attributes): File times now have higher resolution.
1392
1393 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1394 (struct image): Timestamp now has higher resolution.
1395
1396 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1397 has at least microseconds now. All uses removed.
1398 (update_frame, update_single_window, update_window, update_frame_1)
1399 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1400
1401 * editfns.c (time_overflow): Now extern.
1402 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1403 (float-time, Fformat_time_string, Fcurrent_time_string)
1404 (Fcurrent_time_zone): Accept and generate higher-resolution
1405 time stamps.
1406 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1407 (decode_time_components, lisp_seconds_argument): New functions.
1408 (make_time): Now static.
1409 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1410 Report an error if the time is invalid, rather than having the caller
1411 do that.
1412
1413 * fileio.c: Include <stat-time.h>
1414 (Fcopy_file): Copy higher-resolution time stamps.
1415 Prefer to set the time stamp via a file descriptor if that works.
1416 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1417 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1418 (Fvisited_file_modtime, Fset_visited_file_modtime):
1419 Support higher-resolution time stamps.
1420
1421 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1422
1423 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1424
1425 * image.c (prepare_image_for_display, clear_image_cache)
1426 (lookup_image): Port to higer-resolution time stamps.
1427
1428 * keyboard.c (start_polling, bind_polling_period):
1429 Check for time stamp overflow.
1430 (read_char, kbd_buffer_get_event, timer_start_idle)
1431 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1432 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1433 Port to higher-resolution time stamps. Do not assume time_t is signed.
1434 (decode_timer): New function. Timers are now vectors of length 9,
1435 not 8, to accommodate the picosecond component.
1436 (timer_check_2): Use it.
1437
1438 * nsterm.m (select_timeout, timeval_subtract): Remove.
1439 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1440 as they're a bit more accurate and handle overflow better.
1441 (ns_select): Change prototype to be compatible with pselect.
1442 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1443 * nsterm.h (ns_select): Adjust prototype.
1444
1445 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1446 us-resolution time stamps.
1447 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1448
1449 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1450
1451 * lisp.h (time_overflow): New decl.
1452 (wait_reading_process_output): First arg is now intmax_t, not int,
1453 to accommodate larger waits.
1454
1455 * process.h (struct Lisp_Process.read_output_delay):
1456 Now counts nanoseconds, not microseconds.
1457 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1458 EMACS_HAS_USECS.
1459 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1460 (wait_reading_process_output):
1461 Port to ns-resolution time stamps.
1462 (Faccept_process_output, wait_reading_process_output):
1463 Check for time stamp overflow. Do not assume time_t is signed.
1464 (select_wrapper): Remove; we now use pselect.
1465 (Fprocess_attributes): Now generates ns-resolution time stamps.
1466
1467 * sysdep.c: Include utimens.h. Don't include utime.h
1468 or worry about struct utimbuf; gnulib does that for us now.
1469 (gettimeofday): Remove; gnulib provides a substitute.
1470 (make_timeval): New function.
1471 (set_file_times): Now sets ns-resolution time stamps.
1472 New arg FD; all uses changed.
1473 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1474 (system_process_attributes):
1475 Now returns ns-resolution time stamp. All uses changed.
1476 Check for time stamp overflow.
1477
1478 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1479 provides a substitute now.
1480
1481 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1482 since it guarantees struct timespec.
1483 (EMACS_TIME): Now struct timespec, so that we can support
1484 ns-resolution time stamps.
1485 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1486 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1487 (EMACS_USECS): Remove.
1488 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1489 so multiply the arg by 1000 before storing it.
1490 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1491 New macros.
1492 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1493 Port to ns-resolution time stamps.
1494 (EMACS_TIME_NEG_P): Remove; replaced by....
1495 (EMACS_TIME_SIGN): New macro.
1496 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1497 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1498 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1499 (make_timeval, make_lisp_time, decode_time_components): New decls.
1500 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1501 that it mishandled time_t overflow. You can't compare by subtracting!
1502 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1503 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1504
1505 * term.c: Include <sys/time.h>.
1506 (timeval_to_Time): New function, for proper overflow wraparound.
1507 (term_mouse_position, term_mouse_click): Use it.
1508
1509 * undo.c (record_first_change): Support higher-resolution time stamps
1510 in the undo buffer.
1511 (Fprimitive_undo): Use them when restoring time stamps.
1512
1513 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1514 (w32_get_internal_run_time):
1515 Port to higher-resolution Emacs time stamps.
1516 (ltime): Now accepts single 64-bit integer, as that's more convenient
1517 for callers.
1518
1519 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1520
1521 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1522 for compatibility with pselect. Support ns-resolution time stamps.
1523
1524 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1525
1526 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1527 Check for time stamp overflow, and support ns-resolution time stamps.
1528
1529 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1530 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1531 (timeval_subtract): Remove; no longer needed.
1532 (XTflash, XTring_bell, x_wait_for_event):
1533 Port to ns-resolution time stamps. Don't assume time_t is signed.
1534
b6a92dfe
CY
15352012-06-22 Chong Yidong <cyd@gnu.org>
1536
1537 * xdisp.c (x_consider_frame_title): Revert last change.
1538
d251c37c
EZ
15392012-06-22 Eli Zaretskii <eliz@gnu.org>
1540
1541 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1542 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1543 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1544 staticidx goes up to 1597 out of 1600 = 0x640.)
1545
f10deafb
PE
15462012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1547
1548 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1549 Otherwise, the umask might be mistakenly 0 while handling input signals.
1550
ec6de1e2
SM
15512012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1552
1553 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1554
28be1ada
DA
15552012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1556
1557 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1558 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1559 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1560 access to `contents' member of Lisp_Vector objects with AREF and ASET
1561 where appropriate.
1562
c6bf3022
CY
15632012-06-19 Chong Yidong <cyd@gnu.org>
1564
1565 * frame.c (delete_frame): When selecting a frame on a different
1566 text terminal, do not alter the terminal's top-frame.
1567
1568 * xdisp.c (format_mode_line_unwind_data): Record the target
1569 frame's selected window and its terminal's top-frame.
1570 (unwind_format_mode_line): Restore them.
1571 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1572 Callers changed.
1573 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1574 since tty frames can be explicitly named.
1575 (prepare_menu_bars): Likewise.
1576
1577 * term.c (Ftty_top_frame): New function.
1578
defd4196
PE
15792012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1580
1581 Port byte-code-meter to modern targets.
1582 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1583 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1584 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1585 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1586 (METER_1, METER_2): Simplify.
1587
1053a871
SM
15882012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1589
1590 * data.c (Fdefalias): Return `symbol' (bug#11686).
1591
b7e8d081
MR
15922012-06-18 Martin Rudalics <rudalics@gmx.at>
1593
1594 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1595 gets killed during executing of this function (Bug#11665).
1596 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1597 (Vkill_buffer_query_functions): In doc-string say that functions
1598 run by this hook should not change the current buffer.
1599
7ea2b339
PE
16002012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1601
1602 Fix recently-introduced process.c problems found by static checking.
1603 * process.c (write_queue_push, write_queue_pop, send_process):
1604 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1605 (write_queue_pop): Fix pointer signedness problem.
1606 (send_process): Remove unused local.
1607
96a313a1
CY
16082012-06-17 Chong Yidong <cyd@gnu.org>
1609
1610 * xdisp.c (redisplay_internal): No need to redisplay terminal
1611 frames that are not on top.
1612
20ca2e94
TN
16132012-06-17 Troels Nielsen <bn.troels@gmail.com>
1614
1615 * process.c (make_process): Initialize write_queue.
1616 (write_queue_push, write_queue_pop): New functions.
1617 (send_process): Use them to maintain correct ordering of process
1618 writes (Bug#10815).
1619
9a900ca9
PE
16202012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1621
310fbfa8
PE
1622 * lisp.h (eassert): Assume C89 or later.
1623 This removes the need for CHECK.
1624 (CHECK): Remove. Its comments about always evaluating its
1625 argument were confusing, as 'eassert' typically does not evaluate
1626 its argument.
1627
27bb1ca4
PE
1628 * coding.c (produce_chars): Use ptrdiff_t, not int.
1629
9a900ca9
PE
1630 * xterm.c (x_draw_underwave): Check for integer overflow.
1631 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1632
41b7f8bc 16332012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1634
1635 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1636 referenced (Bug#11583).
1637
9b0e3eba
AA
16382012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1639
1640 Implement wave-style variant of underlining.
1641 * dispextern.h (face_underline_type): New enum.
1642 (face): Add field for underline type.
1643 * nsterm.m (ns_draw_underwave): New function.
1644 (ns_draw_text_decoration): Use it.
1645 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1646 New functions.
1647 (x_draw_glyph_string): Use them.
1648 * xfaces.c (Qline, Qwave): New Lisp objects.
1649 (check_lface_attrs, merge_face_ref)
1053a871
SM
1650 (Finternal_set_lisp_face_attribute, realize_x_face):
1651 Handle wave-style underline face attributes.
9b0e3eba
AA
1652 * xterm.c (x_draw_underwave): New function.
1653 (x_draw_glyph_string): Use it.
1654
0fb52f11
JB
16552012-06-16 Juanma Barranquero <lekktu@gmail.com>
1656
1657 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1658 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1659 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1660 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1661 ($(BLD)/w32select.$(O)): Update dependencies.
1662
e5560ff7
AS
16632012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1664
1665 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1666 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1667 * character.c (_fetch_multibyte_char_p): Remove.
1668 * alloc.c: Include "character.h" before "buffer.h".
1669 * bidi.c: Likewise.
1670 * buffer.c: Likewise.
1671 * bytecode.c: Likewise.
1672 * callint.c: Likewise.
1673 * callproc.c: Likewise.
1674 * casefiddle.c: Likewise.
1675 * casetab.c: Likewise.
1676 * category.c: Likewise.
1677 * cmds.c: Likewise.
1678 * coding.c: Likewise.
1679 * composite.c: Likewise.
1680 * dired.c: Likewise.
1681 * dispnew.c: Likewise.
1682 * doc.c: Likewise.
1683 * dosfns.c: Likewise.
1684 * editfns.c: Likewise.
1685 * emacs.c: Likewise.
1686 * fileio.c: Likewise.
1687 * filelock.c: Likewise.
1688 * font.c: Likewise.
1689 * fontset.c: Likewise.
1690 * fringe.c: Likewise.
1691 * indent.c: Likewise.
1692 * insdel.c: Likewise.
1693 * intervals.c: Likewise.
1694 * keyboard.c: Likewise.
1695 * keymap.c: Likewise.
1696 * lread.c: Likewise.
1697 * macros.c: Likewise.
1698 * marker.c: Likewise.
1699 * minibuf.c: Likewise.
1700 * nsfns.m: Likewise.
1701 * nsmenu.m: Likewise.
1702 * print.c: Likewise.
1703 * process.c: Likewise.
1704 * regex.c: Likewise.
1705 * region-cache.c: Likewise.
1706 * search.c: Likewise.
1707 * syntax.c: Likewise.
1708 * term.c: Likewise.
1709 * textprop.c: Likewise.
1710 * undo.c: Likewise.
1711 * unexsol.c: Likewise.
1712 * w16select.c: Likewise.
1713 * w32fns.c: Likewise.
1714 * w32menu.c: Likewise.
1715 * window.c: Likewise.
1716 * xdisp.c: Likewise.
1717 * xfns.c: Likewise.
1718 * xmenu.c: Likewise.
1719 * xml.c: Likewise.
1720 * xselect.c: Likewise.
1721
2f07e6af
EZ
17222012-06-16 Eli Zaretskii <eliz@gnu.org>
1723
1053a871
SM
1724 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1725 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1726 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1727 row.
1728 (handle_face_prop): Use chunk-relative overlay string index when
1729 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1730 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1731 the rightmost. (Bug#11720)
2f07e6af 1732
29b83cec
AS
17332012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1734
1735 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1736 (CATEGORY_MEMBER): Enforce 1/0 value.
1737 * category.c (_temp_category_set): Remove.
1738
4c5501e9
EZ
17392012-06-16 Eli Zaretskii <eliz@gnu.org>
1740
1741 * window.c (Fdelete_other_windows_internal)
1742 (Fdelete_window_internal): Don't access frame's mouse highlight
1743 info of the initial frame. (Bug#11677)
1744
2b570124
PE
17452012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1746
e93864f9
PE
1747 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1748 Assume USE_2_TAGS_FOR_INTS.
1749 (xreload): Adjust $tagmask width to match recent lisp.h change.
1750
2b570124
PE
1751 Simplify lisp.h in minor ways that should not affect code.
1752 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1753 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1754 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1755 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1756 (INTTYPEBITS): New macro, for clarity.
1757 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1758 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1759 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1760 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1761 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1762
81755f69
JB
17632012-06-13 Juanma Barranquero <lekktu@gmail.com>
1764
1765 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1766
16192a57
GM
17672012-06-13 Glenn Morris <rgm@gnu.org>
1768
1769 * s/bsd-common.h (BSD4_3):
1770 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1771
646b5f55
AS
17722012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1773
1774 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1775 instead of union.
1776 (XLI, XIL): Define.
1053a871
SM
1777 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1778 Use them.
1779 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1780 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1781 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1782 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1783 * frame.c (delete_frame): Remove outdated comment.
1784 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1785 USE_LISP_UNION_TYPE.
1786 (Fw32_unregister_hot_key): Likewise.
1787 (Fw32_toggle_lock_key): Likewise.
1788 * w32menu.c (add_menu_item): Likewise.
1789 (w32_menu_display_help): Use XIL instead of checking
1790 USE_LISP_UNION_TYPE.
1791 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1792 (init_heap): Likewise.
1793 * w32term.c (w32_read_socket): Update comment.
1794
1d3823c9
GM
17952012-06-13 Glenn Morris <rgm@gnu.org>
1796
c62ff706
GM
1797 * s/usg5-4-common.h, src/s/unixware.h:
1798 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1799
1d3823c9
GM
1800 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1801
bfe3e0a2
PE
18022012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1803
1804 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1805 * alloc.c (make_number) [!defined make_number]:
1806 Remove, as lisp.h always defines this now.
1807 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1808 (roundup_size): Verify that it is a power of 2.
1809 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1810 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1811 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1812 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1813 USE_LSB_TAG now is always defined to be either 0 or 1.
1814 All uses changed.
1815 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1816 code works fine either way, and efficiency is not a concern here,
1817 as the union type is for debugging, not for production.
1818 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1819 Use an inline function on all platforms when using the union type,
1820 since this is simpler and 'static inline' can be used portably
1821 within Emacs now.
1822 (LISP_INITIALLY_ZERO): New macro.
1823 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1824 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1825
45fa9c0f
GM
18262012-06-12 Glenn Morris <rgm@gnu.org>
1827
b4492cba
GM
1828 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1829
1830 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1831
45fa9c0f
GM
1832 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1833 Move BROKEN_SIGIO to configure.
1834
1835 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1836 Move NO_TERMIO to configure.
1837
0e25d334
CY
18382012-06-12 Chong Yidong <cyd@gnu.org>
1839
1840 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1841 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1842 MagickExportImagePixels is undefined.
1843
43682bb6
PE
18442012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1845
1846 * image.c (imagemagick_load_image): Remove unused label.
1847
a9be7d2b
GM
18482012-06-11 Glenn Morris <rgm@gnu.org>
1849
1850 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1851 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1852 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1853 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1854
3017f87f
SM
18552012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1856
1857 * alloc.c (make_byte_code): New function.
1858 (Fmake_byte_code): Use it. Don't purify here.
1859 * lread.c (read1): Use it as well to avoid extra allocation.
1860
1b9b4cf4
CY
18612012-06-11 Chong Yidong <cyd@gnu.org>
1862
1863 * image.c (imagemagick_load_image): Implement transparency.
1864
95988fcf
AS
18652012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1866
1867 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1868 account for preceding backslashes. (Bug#11663)
1869
cd4eb164
CY
18702012-06-09 Chong Yidong <cyd@gnu.org>
1871
1872 * term.c: Support italics in capable terminals (Bug#9652).
1873 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1874 (turn_on_face): Output using TS_enter_italic_mode if available.
1875 Don't handle unused blinking and alt-charset cases.
1876 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1877 and tty_alt_charset_p cases.
1878 (tty_capable_p, init_tty): Support italics.
1879
1880 * termchar.h (struct tty_display_info): Add field for italics.
1881 Remove unused blink field.
1882
1883 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1884 Handle slant.
1885
1886 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1887 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1888 tty_alt_charset_p. Add tty_italic_p.
1889
ff88beb8
MA
18902012-06-09 Michael Albinus <michael.albinus@gmx.de>
1891
1892 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1893 dbus_type_is_basic if available.
1894 (xd_extract_signed, xd_extract_unsigned): Rename from
1895 extract_signed and extract_unsigned, respectively. Adapt callers.
1896
44286096
CY
18972012-06-09 Chong Yidong <cyd@gnu.org>
1898
1682701f
CY
1899 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1900
44286096
CY
1901 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1902 case (Bug#9752).
1903
d86feb17
PE
19042012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1905
1906 * xdisp.c (vmessage): Treat frame message as multibyte.
1907 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1908 would generate the diagnostic "Making \302\247 buffer-local while
1909 let-bound!".
1910
d5c20fe8
EZ
19112012-06-08 Eli Zaretskii <eliz@gnu.org>
1912
1913 * dispnew.c (showing_window_margins_p): Undo last change, which
1914 was done due to an inadvertent commit.
1915 (adjust_frame_glyphs_for_frame_redisplay): Do call
1916 showing_window_margins_p.
1917
513749ee
SM
19182012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1919
1920 * eval.c (Fmake_var_non_special): New primitive.
1921 (syms_of_eval): Defsubr it.
1922 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1923
d4a8f5c1
JB
19242012-06-08 Juanma Barranquero <lekktu@gmail.com>
1925
1926 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1927 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1928
8bbbc977
EZ
19292012-06-08 Eli Zaretskii <eliz@gnu.org>
1930
1931 * alloc.c (allocate_vectorlike): Fix last change.
1932
f3372c87
DA
19332012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1934
1935 Block-based vector allocation of small vectors.
1936 * lisp.h (struct vectorlike_header): New field `nbytes',
1937 adjust comment accordingly.
1938 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1939 to denote vector blocks. Adjust users (live_vector_p,
1940 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1941 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1942 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1943 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1944 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1945 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1946 (roundup_size): New constant.
1947 (struct vector_block): New data type.
1948 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1949 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1950 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1951 (sweep_vectors): New functions.
1952 (allocate_vectorlike): Return `zero_vector' as the only vector of
1953 0 items. Allocate new vector from block if vector size is less than
1954 or equal to VBLOCK_BYTES_MAX.
1955 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1956 (init_alloc_once): Add call to init_vectors.
1957
4f18a4ed
SM
19582012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1959
1960 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1961
86f158bc
PE
19622012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1963
1964 * doprnt.c (doprnt): Truncate multibyte char correctly.
1965 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1966 would mishandle a string argument "Xc" if X was a multibyte
1967 character of length 2: it would truncate after X's first byte
1968 rather than including all of X.
1969
c5cfcbe0
CY
19702012-06-06 Chong Yidong <cyd@gnu.org>
1971
1972 * buffer.c (word_wrap): Doc fix.
1973
c05cf390
PE
19742012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1975
1976 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1977
0c3461de
GM
19782012-06-03 Glenn Morris <rgm@gnu.org>
1979
1980 * xdisp.c (tool-bar-style): Doc fix.
1981
c71232db
UM
19822012-06-03 Ulrich Müller <ulm@gentoo.org>
1983
1984 * Makefile.in (PAXCTL): Define.
1985 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1986 binary via PaX flags if the paxctl utility is available.
1987 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1988 Restore PaX flags to their default. (Bug#11398)
1989
383f7350
CY
19902012-06-03 Chong Yidong <cyd@gnu.org>
1991
1992 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1993 buffer (Bug#11226).
1994
5f2c76c6
CY
19952012-06-03 Chong Yidong <cyd@gnu.org>
1996
1997 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1998 (note_mode_line_or_margin_highlight): If there is no help echo,
1999 use mode-line-default-help-echo. Handle the case where the mouse
2000 position is past the end of the mode line string.
2001
2002 * buffer.c (buffer_local_value_1): New function, split from
2003 Fbuffer_local_value; can return Qunbound.
2004 (Fbuffer_local_value): Use it.
2005 (Vmode_line_format): Docstring tweaks.
2006
773d47f6
PE
20072012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2008
2009 * sysdep.c (system_process_attributes): Improve comment.
2010
f2d6a3df
SM
20112012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2012
2013 * keyboard.c: Export real-this-command to Elisp.
2014 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2015 and DEFVAR it. Update all users.
2016
63810350
PE
20172012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2018
7bd5c1f4
PE
2019 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2020
63810350
PE
2021 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2022 Convert pctcpu and pctmem to Lisp float properly.
2023 Let the compiler fold better, as 100.0/0x8000 is exact.
2024
a2821611
AS
20252012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2026
2027 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2028 cons_block.
2029
5fceba1d
PE
20302012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2031
2032 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2033
c98ff5dd
DA
20342012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2035
2036 For a 'struct window', replace some Lisp_Object fields to
2037 bitfields where appropriate, remove unused fields.
2038 * window.h (struct window): Remove unused 'last_mark_x' and
2039 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2040 change it's type from Lisp_Object to bitfield.
2041 Change type of 'force_start', 'optional_new_start',
2042 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2043 fields from Lisp_Object to bitfield. Adjust users accordingly.
2044
ca34e0be
PE
20452012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2046
2047 Pacify gcc -Wdouble-precision when using Xaw.
2048 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2049 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2050 Use 'float' consistently, rather than 'float' in most places
2051 and 'double' in a couple of places.
2052
efc00ab1 20532012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2054
2055 * xdisp.c (handle_stop): Detect whether we have overlay strings
2056 loaded by testing it->current.overlay_string_index to be
2057 non-negative, instead of checking whether n_overlay_strings is
2058 positive. (Bug#11587)
2059
efc00ab1 20602012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2061
2062 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2063
2064 * doc.c (Fsubstitute_command_keys): Doc fix.
2065
efc00ab1 20662012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2067
2068 * search.c (search_buffer): Remove calls to
2069 r_alloc_inhibit_buffer_relocation, as it is now called by
2070 maybe_unify_char, which was the cause of relocation of buffer text
2071 in bug#11519.
2072
efc00ab1 20732012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2074
2075 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2076 for the duration of call to load_charset, to avoid problems with
2077 callers of maybe_unify_char that access buffer text through C
2078 pointers.
2079
2080 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2081 decrement the inhibition flag, instead of just setting or
2082 resetting it.
2083
ba93a187
PE
20842012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2085
2086 Remove obsolete '#define static' cruft.
2087 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2088 This #undef was "temporary" in 2000; it is no longer needed
2089 now that '#define static' has gone away.
2090 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2091 (gray_bitmap_bits): Remove; no longer needed.
2092 All uses replaced with definiens.
2093 * xterm.c: Include "bitmaps/gray.xbm".
2094
9e4bf381
PE
20952012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2096
2097 Clean up __executable_start, monstartup when --enable-profiling.
2098 The following changes affect the code only when profiling.
2099 * dispnew.c (__executable_start): Rename from safe_bcopy.
2100 Define only on platforms that need it.
2101 * emacs.c: Include <sys/gmon.h> when profiling.
2102 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2103 (__executable_start): Remove decl, since lisp.h does it now.
2104 (safe_bcopy): Remove decl; no longer has that name.
2105 (main): Coalesce #if into single bit of code, for simplicity.
2106 Cast pointers to uintptr_t, since standard libraries want integers
2107 and not pointers.
2108 * lisp.h (__executable_start): New decl.
2109
32d72c2f
GM
21102012-05-31 Glenn Morris <rgm@gnu.org>
2111
2112 * image.c (Fimagemagick_types): Doc fix.
2113
baac5bc7
JM
21142012-05-30 Jim Meyering <meyering@redhat.com>
2115
2116 * callproc.c (Fcall_process_region): Include directory component
2117 in mkstemp error message (Bug#11586).
2118
72cb32cf
PE
21192012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2120
2121 * alloc.c, lisp.h (make_pure_vector): Now static.
2122
61b108cc
SM
21232012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2124
2125 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2126 Move to byte-run.el.
2127 (Fautoload): Do the hash-doc more carefully.
2128 * data.c (Fdefalias): Purify definition, except for keymaps.
2129 (Qdefun): Move from eval.c.
2130 * lisp.h (Qdefun): Remove.
2131 * lread.c (read1): Tiny simplification.
2132
471fe23d
TN
21332012-05-29 Troels Nielsen <bn.troels@gmail.com>
2134
934f3f58 2135 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2136 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2137 Bug#9642, but explicitly check that the buffer the overlay would
2138 be moved to is live and rearrange lines to make sure that errors
2139 will not put the overlay in an inconsistent state.
2140 (Fdelete_overlay): Cosmetics.
2141
85d0efd1
EZ
21422012-05-28 Eli Zaretskii <eliz@gnu.org>
2143
2144 * w32term.c (my_bring_window_to_top): New function.
2145 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2146 could be different from the original one.
2147 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2148 (Bug#11513)
2149
2150 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2151 by calling BringWindowToTop.
2152
2153 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2154 (WM_EMACS_END): Increase by one.
2155
da92a98c
PE
21562012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2157
2158 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2159 This avoids undefined behavior that might cause the eassert
2160 to not catch an out-of-range value.
2161
74d1f848
JB
21622012-05-28 Juanma Barranquero <lekktu@gmail.com>
2163
2164 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2165 Update dependencies.
2166
9e1a06fc
EZ
21672012-05-27 Eli Zaretskii <eliz@gnu.org>
2168
2169 * bidi.c (bidi_mirror_char): Fix last change.
2170
f3dd7312
AS
21712012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2172
2173 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2174 when referring to sectname field in printf format.
2175
81899c91
PE
21762012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2177
57b81a9f
PE
2178 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2179 Only r_alloc_inhibit_buffer_relocation needed to be added;
2180 the others were already declared.
2181
81899c91
PE
2182 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2183 before checking whether it's out of range. Put the check inside
2184 eassert. See
2185 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2186
33017faf 21872012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2188
2189 * callproc.c (Fcall_process): Restore a line that was accidentally
2190 commented out in the 2011-02-13 change (bug#11547).
2191
33017faf 21922012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2193
2194 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2195 defined on ralloc.c.
2196
2197 * buffer.c [REL_ALLOC]: Remove prototypes of
2198 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2199 they are now on lisp.h.
2200
2201 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2202
2203 * search.c (search_buffer): Use it to inhibit relocation of buffer
2204 text while re_search_2 is doing its job, because re_search_2 is
2205 passed C pointers to buffer text. (Bug#11519)
2206
23415acf
EZ
2207 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2208 Update value to 24.
2209
44e27368
EZ
2210 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2211 state after an additional call to move_it_in_display_line_to, keep
2212 the values of it->max_ascent and it->max_descent found for the
2213 entire line.
2214 (pos_visible_p): Revert the comparison against bottom_y to what it
2215 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2216 (Bug#11464)
2217
c1892f11
PE
22182012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2219
2220 Fix coding-related core dumps with gcc -ftrapv.
2221 The code was computing A - B, where A and B are pointers, and B is
2222 random garbage. This can lead to core dumps on platforms that
2223 have special pointer registers, and it also leads to core dumps on
2224 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2225 A - B only when B is initialized properly.
2226 * coding.c (coding_set_source, coding_set_destination): Return void.
2227 (coding_change_source, coding_change_destinations): New functions,
2228 with the old behaviors of coding_set_source and coding_set_destination.
2229 All callers that need an offset changed to use these new functions.
2230
eb7afdad
GM
22312012-05-26 Glenn Morris <rgm@gnu.org>
2232
2233 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2234
f12fdf02
EZ
22352012-05-26 Eli Zaretskii <eliz@gnu.org>
2236
53a63be6 2237 Extend mouse support on W32 text-mode console.
61b108cc
SM
2238 * xdisp.c (draw_row_with_mouse_face):
2239 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2240
eb3f6f01 2241 * w32console.c: Include window.h.
61b108cc
SM
2242 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2243 New functions.
eb3f6f01
EZ
2244 (initialize_w32_display): Initialize mouse-highlight data.
2245
53a63be6
EZ
2246 * w32inevt.c: Include termchar.h and window.h.
2247 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2248 moves, call note_mouse_highlight. If help_echo changed, call
2249 gen_help_event to produce help-echo message in the echo area.
2250 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2251 highlight info.
2252
4cfd81f6
PE
22532012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2254
2255 * lread.c (read1): Simplify slightly to avoid an overflow warning
2256 with GCC 4.7.0 on x86-64.
2257
4446092a
EZ
22582012-05-26 Eli Zaretskii <eliz@gnu.org>
2259
2260 * bidi.c (bidi_mirror_char): Revert last change: an int is
2261 definitely wide enough here.
2262
42b2a986 22632012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2264
42b2a986 2265 Fix integer width and related bugs (Bug#9874).
eb106a49 2266 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2267 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2268 (string_bytes, check_sblock, allocate_string_data):
2269 (compact_small_strings, Fmake_bool_vector, make_string)
2270 (make_unibyte_string, make_multibyte_string)
2271 (make_string_from_bytes, make_specified_string)
2272 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2273 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2274 (mark_vectorlike):
2275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2276 (allocate_pseudovector):
2277 Use int, not EMACS_INT, where int is wide enough.
2278 (inhibit_garbage_collection, Fgarbage_collect):
2279 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2280 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2281 int might not be wide enough.
2282 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2283 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2284 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2285 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2286 (bidi_level_of_next_char, bidi_move_to_visually_next):
2287 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2288 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2289 (Fkill_buffer, Fset_buffer_major_mode)
2290 (advance_to_char_boundary, Fbuffer_swap_text)
2291 (Fset_buffer_multibyte, overlays_at, overlays_in)
2292 (overlay_touches_p, struct sortvec, record_overlay_string)
2293 (overlay_strings, recenter_overlay_lists)
2294 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2295 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2296 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2297 (Foverlay_recenter, last_overlay_modification_hooks_used)
2298 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2299 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2300 (validate_region): Omit unnecessary test for b <= e,
2301 since that's guaranteed by the previous test.
d311d28c
PE
2302 (adjust_overlays_for_delete): Avoid pos + length overflow.
2303 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2304 (report_overlay_modification):
2305 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2306 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2307 Omit pointer cast, which isn't needed anyway, and doesn't work
2308 after the EMACS_INT -> ptrdiff_t change.
02481186 2309 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2310 * buffer.h: Adjust decls to match defn changes elsewhere.
2311 (struct buffer_text, struct buffer):
2312 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2313 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2314 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2315 not int, to avoid needless 32-bit limit on 64-bit hosts.
2316 (exec_byte_code): Use tighter memory-full test, one that checks
2317 for alloca overflow. Don't compute the address of the object just
2318 before an array, as that's not portable. Use EMACS_INT, not
2319 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2320 * callint.c (Fcall_interactively):
2321 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2322 * callproc.c (call_process_kill, Fcall_process):
2323 Don't assume pid_t fits into an Emacs fixnum.
2324 (call_process_cleanup, Fcall_process, child_setup):
2325 Don't assume pid_t fits into int.
2326 (call_process_cleanup, Fcall_process, delete_temp_file)
2327 (Fcall_process_region):
2328 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2329 (Fcall_process): Simplify handling of volatile integers.
2330 Use int, not EMACS_INT, where int will do.
2331 * casefiddle.c (casify_object, casify_region, operate_on_word)
2332 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2334 (casify_object): Avoid integer overflow when overallocating buffer.
2335 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2336 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2337 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2338 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2339 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2340 integers are now checked earlier. All uses replaced with XINT.
2341 (ccl_driver):
2342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2343 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2344 (ccl_driver, Fregister_code_conversion_map):
2345 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2346 (resolve_symbol_ccl_program): Check that vector header is in range.
2347 Always copy the vector, so that we can check its contents reliably
2348 now rather than having to recheck each instruction as it's being
2349 executed. Check that vector words fit in 'int'.
2350 (ccl_get_compiled_code, Fregister_ccl_program)
2351 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2352 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2353 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2354 contents are in range.
2355 (Fccl_execute_on_string): Check that status is in range.
2356 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2357 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2358 Accept and return EMACS_INT, not int, because callers can pass values
2359 out of 'int' range.
2360 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2361 (multibyte_chars_in_text, parse_str_as_multibyte)
2362 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2363 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2364 (string_escape_byte8, Fget_byte):
2365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2366 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2367 avoid mishandling large integers.
2368 * character.h: Adjust decls to match defn changes elsewhere.
2369 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2370 (Ffind_charset_region):
2371 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2372 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2373 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2374 Don't assume fixnum fits in int.
d311d28c
PE
2375 (load_charset_map_from_vector, Fmap_charset_chars):
2376 Remove now-unnecessary CHECK_NATNUMs.
2377 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2378 Don't rely on undefined behavior with signed left shift overflow.
2379 Don't assume unsigned int fits into fixnum, or that fixnum fits
2380 into unsigned int. Don't require max_code to be a valid fixnum;
2381 that's not true for gb10830 4-byte on a 32-bit host. Allow
2382 invalid_code to be a cons, for the same reason. Require code_offset
2383 to be a character. Avoid int overflow if max_char is close
2384 to INT_MAX.
2385 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2386 this is intended anyway and avoids some undefined behavior.
2387 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2388 INDEX_TO_CODE_POINT, as that's what it expects.
2389 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2390 * charset.h (DECODE_CHAR): Return int, not unsigned;
2391 this is what was intended anyway, and it avoids undefined behavior.
2392 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2393 integer-overflow issues.
2394 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2395 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2396 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2397 * chartab.c (Fmake_char_table, Fset_char_table_range)
2398 (uniprop_get_decoder, uniprop_get_encoder):
2399 Don't assume fixnum fits in int.
2400 * cmds.c (move_point): New function, that does the gist of
2401 Fforward_char and Fbackward_char, but does so while checking
2402 for integer overflow more accurately.
c96e5d6a 2403 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2404 (Fforward_line, Fend_of_line, internal_self_insert)
2405 (internal_self_insert):
2406 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2407 Fix a FIXME, by checking for integer overflow when calculating
2408 target_clm and actual_clm.
2409 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2410 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2411 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2412 (coding_alloc_by_making_gap, alloc_destination)
2413 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2414 (encode_coding_utf_16, detect_coding_emacs_mule)
2415 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2416 (detect_coding_iso_2022, decode_coding_iso_2022)
2417 (encode_invocation_designation, encode_designation_at_bol)
2418 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2419 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2420 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2421 (encode_coding_ccl, encode_coding_raw_text)
2422 (detect_coding_charset, decode_coding_charset)
2423 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2424 (produce_composition, produce_charset, produce_annotation)
2425 (decode_coding, handle_composition_annotation)
2426 (handle_charset_annotation, consume_chars, decode_coding_gap)
2427 (decode_coding_object, encode_coding_object, detect_coding_system)
2428 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2429 (code_convert_region, code_convert_string)
8f50130c
PE
2430 (Fdefine_coding_system_internal)
2431 (coding_set_source, coding_set_destination):
d311d28c
PE
2432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2433 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2434 (Fdefine_coding_system_internal):
2435 Don't assume fixnums fit in int.
2436 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2437 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2438 (Funencodable_char_position, Fcheck_coding_systems_region)
2439 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2440 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2441 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2442 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2443 Don't access memory outside of the args array.
d311d28c 2444 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2445 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2446 result of ENCODE_CHAR.
d311d28c
PE
2447 * coding.h: Adjust decls to match defn changes elsewhere.
2448 (struct coding_system):
2449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2450 * composite.c (get_composition_id, find_composition)
2451 (run_composition_function, update_compositions)
2452 (compose_text, composition_gstring_put_cache)
2453 (composition_gstring_p, composition_gstring_width)
2454 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2455 (composition_compute_stop_pos, composition_reseat_it)
2456 (composition_update_it, struct position_record)
2457 (find_automatic_composition, composition_adjust_point)
2458 (Fcomposition_get_gstring, Ffind_composition_internal):
2459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2460 (update_compositions):
2461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2462 * composite.h: Adjust decls to match defn changes elsewhere.
2463 (struct composition):
2464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2465 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2466 Do not attempt to compute the address of the object just before a
2467 buffer; this is not portable.
2468 (Faref, Faset):
2469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2470 (Faset): Use int, not EMACS_INT, where int is wide enough.
2471 (Fstring_to_number): Don't assume fixnums fit in int.
2472 (Frem): Don't assume arg is nonnegative.
2473 * dbusbind.c (xd_append_arg): Check for integers out of range.
2474 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2475 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2476 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2477 (xd_get_connection_references): Return ptrdiff_t, not int.
2478 All uses changed.
2479 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2480 (xd_read_message_1):
2481 Use int, not unsigned, where the dbus API uses int.
2482 (Fdbus_message_internal): Don't overflow mtype.
2483 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2484 * dired.c (directory_files_internal, file_name_completion, scmp)
2485 (file_name_completion_stat):
2486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2487 (file_name_completion): Don't overflow matchcount.
2488 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2489 * dispextern.h: Adjust decls to match defn changes elsewhere.
2490 (struct text_pos, struct glyph, struct bidi_saved_info)
2491 (struct bidi_string_data, struct bidi_it, struct composition_it)
2492 (struct it):
2493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2494 (struct display_pos, struct composition_it, struct it):
2495 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2496 * dispnew.c (increment_matrix_positions)
2497 (increment_row_positions, mode_line_string)
2498 (marginal_area_string):
2499 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2500 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2501 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2502 (duration_to_sec_usec): New function, to check for overflow better.
2503 (Fsleep_for, sit_for): Use it.
2504 * doc.c (get_doc_string, store_function_docstring):
2505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2506 (get_doc_string, Fsnarf_documentation):
2507 Use int, not EMACS_INT, where int is wide enough.
2508 (get_doc_string):
2509 Use SAFE_ALLOCA, not alloca.
2510 Check for overflow when converting EMACS_INT to off_t.
2511 * doprnt.c (doprnt):
2512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2513 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2514 Don't assume uid_t fits into fixnum.
2515 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2516 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2517 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2518 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2519 (general_insert_function)
2520 (Finsert_char, make_buffer_string, make_buffer_string_both)
2521 (update_buffer_properties, Fbuffer_substring)
2522 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2523 (Fsubst_char_in_region, check_translation)
2524 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2525 (transpose_markers, Ftranspose_regions):
2526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2527 (clip_to_bounds): Move to lisp.h as an inline function).
2528 (Fconstrain_to_field): Don't assume integers are nonnegative.
2529 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2530 (Fsubst_char_in_region, Fsave_restriction):
2531 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2532 (Femacs_pid): Don't assume pid_t fits into fixnum.
2533 (lo_time): Use int, not EMACS_INT, when int suffices.
2534 (lisp_time_argument): Check for usec out of range.
2535 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2536 (Fuser_login_name, Fuser_full_name): Signal an error
2537 if a uid argument is out of range, rather than relying on
2538 undefined behavior.
c8d5c857
PE
2539 (Fformat_time_string): Remove now-unnecessary check.
2540 lisp_time_argument checks for out-of-range usec now.
243e0530 2541 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2542 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2543 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2544 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2545 (init_cmdargs, Fdump_emacs):
2546 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2547 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2548 the bottom (typically) 32 bits of the fixnum.
2549 * eval.c (specpdl_size, call_debugger):
2550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2551 (when_entered_debugger, Fbacktrace_debug):
2552 Don't assume fixnum can fit in int.
2553 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2554 the object just before a buffer; this is not portable.
2555 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2556 (grow_specpdl, unbind_to):
2557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2558 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2559 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2560 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2561 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2562 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2563 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2564 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2565 (a_write, e_write):
2566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2567 (Fcopy_file, non_regular_nbytes, read_non_regular)
2568 (Finsert_file_contents):
2569 Use int, not EMACS_INT, where int is wide enough.
2570 (READ_BUF_SIZE): Verify that it fits in int.
2571 (Finsert_file_contents): Check that counts are in proper range,
2572 rather than assuming fixnums fit into ptrdiff_t etc.
2573 Don't assume fixnums fit into int.
125b3835 2574 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2575 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2576 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2577 (string_char_to_byte, string_byte_to_char)
2578 (string_make_multibyte, string_to_multibyte)
2579 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2580 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2581 (substring_both, Fdelete, internal_equal, Ffillarray)
2582 (Fclear_string, mapcar1)
2583 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2584 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2585 (larger_vector, make_hash_table, maybe_resize_hash_table)
2586 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2587 (Fmaphash, secure_hash):
2588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2589 (concat): Check for string index and length overflow.
2590 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2591 (Frequire):
2592 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2593 (larger_vector): New API (vec, incr_min, size_max) replaces old
2594 one (vec, new_size, init). This catches size overflow.
2595 INIT was removed because it was always Qnil.
2596 All callers changed.
2597 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2598 the upper bound on a hash table index size.
2599 (make_hash_table, maybe_resize_hash_table): Use it.
2600 (secure_hash): Computer start_byte and end_byte only after
2601 they're known to be in ptrdiff_t range.
2602 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2603 (Ffont_get_glyphs, Ffont_at):
2604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2605 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2606 (Flist_fonts, Fopen_font):
2607 Don't assume fixnum can fit in int.
2608 (check_gstring): Don't assume index can fit in int.
2609 (font_match_p): Check that fixnum is a character, not a nonnegative
2610 fixnum, since the later code needs to stuff it into an int.
2611 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2612 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2613 conversion overflow issues.
2614 (Fopen_font): Check for integer out of range.
2615 (Ffont_get_glyphs): Don't assume index can fit in int.
2616 * font.h: Adjust decls to match defn changes elsewhere.
2617 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2618 integer overflow.
2619 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2620 printmax_t, where ptrdiff_t is wide enough.
2621 (Finternal_char_font):
2622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2623 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2624 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2625 (Fset_frame_position, x_set_frame_parameters)
2626 (x_set_line_spacing, x_set_border_width)
2627 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2628 Check that fixnums are in proper range for system types.
2629 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2631 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2632 Use SAFE_ALLOCA_LISP, not alloca.
2633 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2634 intptr_t is wide enough.
2635 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2636 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2637 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2638 Check for fixnum out of range.
2639 * ftfont.c (ftfont_list): Don't assume index fits in int.
2640 Check that fixnums are in proper range for system types.
2641 (ftfont_shape_by_flt):
2642 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2643 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2645 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2646 Check that fixnums are in proper range for system types.
2647 * gnutls.h: Adjust decls to match defn changes elsewhere.
2648 * gtkutil.c (xg_dialog_run):
2649 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2650 (update_frame_tool_bar):
2651 Check that fixnums are in proper range for system types.
2652 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2653 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2654 * indent.c (last_known_column, last_known_column_point):
2655 (current_column_bol_cache):
2656 (skip_invisible, current_column, check_display_width):
2657 (check_display_width, scan_for_column, current_column_1)
2658 (Findent_to, Fcurrent_indentation, position_indentation)
2659 (indented_beyond_p, Fmove_to_column, compute_motion):
2660 (Fcompute_motion, Fvertical_motion):
2661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2662 (last_known_column_modified): Use EMACS_INT, not int.
2663 (check_display_width):
2664 (Fcompute_motion):
2665 Check that fixnums and floats are in proper range for system types.
2666 (compute_motion): Don't assume index or fixnum fits in int.
2667 (compute_motion, Fcompute_motion):
2668 Use int, not EMACS_INT, when it is wide enough.
2669 (vmotion): Omit local var start_hpos that is always 0; that way
2670 we don't need to worry about overflow in expressions involving it.
2671 * indent.h: Adjust decls to match defn changes elsewhere.
2672 (struct position):
2673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2674 Use int, not EMACS_INT, where int is wide enough.
2675 Remove unused members ovstring_chars_done and tab_offset;
2676 all uses removed.
2677 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2678 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2679 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2680 (make_gap, copy_text, insert, insert_and_inherit)
2681 (insert_before_markers, insert_before_markers_and_inherit)
2682 (insert_1, count_combining_before, count_combining_after)
2683 (insert_1_both, insert_from_string)
2684 (insert_from_string_before_markers, insert_from_string_1)
2685 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2686 (adjust_after_replace, adjust_after_insert, replace_range)
2687 (replace_range_2, del_range, del_range_1, del_range_byte)
2688 (del_range_both, del_range_2, modify_region)
2689 (prepare_to_modify_buffer, signal_before_change)
2690 (signal_after_change, Fcombine_after_change_execute):
2691 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2692 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2693 (balance_an_interval, split_interval_right, split_interval_left)
2694 (find_interval, next_interval, update_interval)
2695 (adjust_intervals_for_insertion, delete_node, delete_interval)
2696 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2697 (static_offset_intervals, offset_intervals)
2698 (merge_interval_right, merge_interval_left, make_new_interval)
2699 (graft_intervals_into_buffer, temp_set_point_both)
2700 (temp_set_point, set_point, adjust_for_invis_intang)
2701 (set_point_both, move_if_not_intangible, get_property_and_range)
2702 (get_local_map, copy_intervals, copy_intervals_to_string)
2703 (compare_string_intervals, set_intervals_multibyte_1):
2704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2705 * intervals.h: Adjust decls to match defn changes elsewhere.
2706 (struct interval):
2707 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2708 * keyboard.c (this_command_key_count, this_single_command_key_start)
2709 (before_command_key_count, before_command_echo_length, echo_now)
2710 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2711 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2712 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2713 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2715 (last_non_minibuf_size, last_point_position, echo_truncate)
2716 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2717 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2718 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2719 (stuff_buffered_input):
2720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2721 (last_auto_save, command_loop_1, read_char):
2722 Use EMACS_INT, not int, to avoid integer overflow.
2723 (record_char): Avoid overflow in total_keys computation.
2724 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2725 * keyboard.h: Adjust decls to match defn changes elsewhere.
2726 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2727 (Fkey_description, Fdescribe_vector, Flookup_key):
2728 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2729 (click_position): New function, to check that positions are in range.
2730 (Fcurrent_active_maps):
2731 (describe_command):
2732 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2733 (Faccessible_keymaps, Fkey_description):
2734 (preferred_sequence_p):
2735 Don't assume fixnum can fit into int.
2736 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2737 Check for integer overflow in size calculations.
2738 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2739 avoid mishandling large integers.
2740 * lisp.h: Adjust decls to match defn changes elsewhere.
2741 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2742 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2743 (struct Lisp_Marker):
2744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2745 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2746 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2747 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2748 All callers changed.
2749 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2750 Assume the arg has valid form, since it always does.
2751 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2752 unsigned integer system type.
2753 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2754 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2756 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2757 (duration_to_sec_usec): New decl.
2758 * lread.c (read_from_string_index, read_from_string_index_byte)
2759 (read_from_string_limit, readchar, unreadchar, openp)
2760 (read_internal_start, read1, oblookup):
2761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2762 (Fload, readevalloop, Feval_buffer, Feval_region):
2763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2764 (openp): Check for out-of-range argument to 'access'.
2765 (read1): Use int, not EMACS_INT, where int is wide enough.
2766 Don't assume fixnum fits into int.
6efdadfd 2767 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2768 (read_filtered_event): Use duration_to_sec_usec
2769 to do proper overflow checking on durations.
d311d28c
PE
2770 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2771 in size calculation.
2772 (Fexecute_kbd_macro):
2773 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2774 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2775 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2776 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2777 (set_marker_both, set_marker_restricted_both, marker_position)
2778 (marker_byte_position, Fbuffer_has_markers_at):
2779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2780 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2781 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2782 It now merely ensures that the menu is large enough, without
2783 necessarily growing it, as this avoids some integer overflow issues.
2784 All callers changed.
2785 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2787 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2788 Use SAFE_ALLOCA_LISP, not alloca.
2789 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2790 to EMACS_INT. Check that fixnums are in proper range for system types.
2791 * minibuf.c (minibuf_prompt_width, string_to_object)
2792 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2793 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2795 (get_minibuffer, read_minibuf_unwind):
2796 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2797 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2798 this simplifies overflow checking. All callers changed.
2799 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2800 (Ftest_completion):
2801 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2802 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2803 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2804 Check that fixnums are in proper range for system types.
2805 (Fx_create_frame, Fx_show_tip):
2806 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2807 * nsfont.m (ns_findfonts, nsfont_list_family):
2808 Don't assume fixnum fits in long.
2809 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2811 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2812 wide enough.
17fdb222 2813 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2814 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2815 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2816 (PRINTDECLARE, PRINTPREPARE):
2817 (strout, print_string):
2818 (print, print_preprocess, print_check_string_charset_prop)
2819 (print_object):
2820 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2821 (PRINTDECLARE):
2822 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2823 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2824 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2825 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2826 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2827 (print_error_message): Use SAFE_ALLOCA, not alloca.
2828 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2829 (print_depth, new_backquote_output, print_number_index):
2830 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2831 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2832 (Fset_process_window_size, Fformat_network_address)
2833 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2834 (sigchld_handler):
d311d28c 2835 Check that fixnums are in proper range for system types.
d44287d4 2836 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2837 Check for process-ids out of pid_t range rather than relying on
2838 undefined behavior.
e4d81efc 2839 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2840 (Fformat_network_address, read_process_output, send_process)
2841 (Fprocess_send_region, status_notify):
2842 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2843 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2844 (wait_reading_process_output, read_process_output, exec_sentinel):
2845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2846 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2847 (Faccept_process_output): Use duration_to_sec_usec to do proper
2848 overflow checking on durations.
dde14581
PE
2849 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2850 Don't assume pid_t fits in int.
02481186
PE
2851 * process.h (struct Lisp_Process): Members tick and update_tick
2852 are now of type EMACS_INT, not int.
b62b53e8
PE
2853 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2854 configured --with-wide-int.
d311d28c
PE
2855 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2856 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2857 * search.c (looking_at_1, string_match_1):
2858 (fast_string_match, fast_c_string_match_ignore_case)
2859 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2860 (scan_newline, find_before_next_newline, search_command)
2861 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2862 (set_search_regs, wordify):
2863 (Freplace_match):
2864 (Fmatch_data):
2865 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2866 (string_match_1, search_buffer, set_search_regs):
2867 (Fmatch_data):
2868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2869 (wordify): Check for overflow in size calculation.
2870 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2871 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2872 Check that fixnums are in proper range for system types.
2873 * sound.c (struct sound_device)
2874 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2876 (Fplay_sound_internal):
2877 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2878 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2879 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2880 (Fparse_partial_sexp):
2881 Don't assume fixnums can fit in int.
2882 (struct lisp_parse_state, find_start_pos, find_start_value)
2883 (find_start_value_byte, find_start_begv)
2884 (update_syntax_table, char_quoted, dec_bytepos)
2885 (find_defun_start, prev_char_comend_first, back_comment):
2886 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2887 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2888 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2889 (Finternal_describe_syntax_value): Check that match_lisp is a
2890 character, not an integer, since the code stuffs it into int.
2891 (scan_words, scan_sexps_forward):
2892 Check that fixnums are in proper range for system types.
2893 (Fforward_word):
2894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2895 (scan_sexps_forward):
2896 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2897 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2898 * syntax.h: Adjust decls to match defn changes elsewhere.
2899 (struct gl_state_s):
2900 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2901 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2902 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2903 * sysdep.c (wait_for_termination_1, wait_for_termination)
2904 (interruptible_wait_for_termination, mkdir):
2905 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2906 (emacs_read, emacs_write):
2907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2908 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2909 and double all fit in int.
d311d28c
PE
2910 * term.c (set_tty_color_mode):
2911 Check that fixnums are in proper range for system types.
2912 * termhooks.h (struct input_event):
2913 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2914 * textprop.c (validate_interval_range, interval_of)
2915 (Fadd_text_properties, set_text_properties_1)
2916 (Fremove_text_properties, Fremove_list_of_text_properties)
2917 (Ftext_property_any, Ftext_property_not_all)
2918 (copy_text_properties, text_property_list, extend_property_ranges)
2919 (verify_interval_modification):
2920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2921 (Fnext_single_char_property_change)
2922 (Fprevious_single_char_property_change):
2923 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2924 (copy_text_properties):
2925 Check for integer overflow in index calculation.
d311d28c
PE
2926 * undo.c (last_boundary_position, record_point, record_insert)
2927 (record_delete, record_marker_adjustment, record_change)
2928 (record_property_change):
2929 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2930 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2931 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2932 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2933 (Fx_hide_tip, Fx_file_dialog):
2934 * w32menu.c (set_frame_menubar):
2935 Use ptrdiff_t, not int, for consistency with rest of code.
2936 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2937 (select_window, Fdelete_other_windows_internal)
2938 (window_scroll_pixel_based, window_scroll_line_based)
2939 (Frecenter, Fset_window_configuration):
2940 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2941 (Fset_window_hscroll, run_window_configuration_change_hook)
2942 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2943 (Fscroll_other_window, Frecenter):
d311d28c
PE
2944 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2945 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2946 Don't assume fixnum fits in int.
2947 (Fset_window_scroll_bars):
2948 Check that fixnums are in proper range for system types.
2949 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2950 (string_pos, c_string_pos, number_of_chars, init_iterator)
2951 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2952 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2953 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2954 (face_before_or_after_it_pos, handle_invisible_prop)
2955 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2956 (display_prop_intangible_p, string_buffer_position_lim)
2957 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2958 (get_overlay_strings_1, get_overlay_strings)
2959 (iterate_out_of_display_property, forward_to_next_line_start)
2960 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2961 (get_next_display_element, set_iterator_to_next)
2962 (get_visually_first_element, compute_stop_pos_backwards)
2963 (handle_stop_backwards, next_element_from_buffer)
2964 (move_it_in_display_line_to, move_it_in_display_line)
2965 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2966 (add_to_log, message_dolog, message_log_check_duplicate)
2967 (message2, message2_nolog, message3, message3_nolog
2968 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2969 (current_message_1, truncate_echo_area, truncate_message_1)
2970 (set_message, set_message_1, store_mode_line_noprop)
2971 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2972 (text_outside_line_unchanged_p, check_point_in_composition)
2973 (reconsider_clip_changes)
2974 (redisplay_internal, set_cursor_from_row, try_scrolling)
2975 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2976 (redisplay_window, find_last_unchanged_at_beg_row)
2977 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2978 (trailing_whitespace_p, find_row_edges, display_line)
2979 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2980 (display_mode_element, store_mode_line_string)
2981 (pint2str, pint2hrstr, decode_mode_spec)
2982 (display_count_lines, display_string, draw_glyphs)
2983 (x_produce_glyphs, x_insert_glyphs)
2984 (rows_from_pos_range, mouse_face_from_buffer_pos)
2985 (fast_find_string_pos, mouse_face_from_string_pos)
2986 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2987 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2988 (safe_call, init_from_display_pos, handle_fontified_prop)
2989 (handle_single_display_spec, load_overlay_strings)
2990 (with_echo_area_buffer, setup_echo_area_for_printing)
2991 (display_echo_area, echo_area_display)
2992 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2993 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2994 (redisplay_window, dump_glyph_row, display_mode_line)
2995 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2996 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2997 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2998 (handle_single_display_spec, build_desired_tool_bar_string)
2999 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3000 (get_specified_cursor_type):
3001 Check that fixnums are in proper range for system types.
3002 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3003 (Flookup_image_map):
3004 Don't assume fixnums fit in int.
3005 (compare_overlay_entries):
3006 Avoid mishandling comparisons due to subtraction overflow.
3007 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3008 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3009 (handle_tool_bar_click):
3010 Use int, not unsigned, since we prefer signed and the signedness
3011 doesn't matter here.
3012 (get_next_display_element, next_element_from_display_vector):
3013 Use int, not EMACS_INT, when int is wide enough.
3014 (start_hourglass): Use duration_to_sec_usec to do proper
3015 overflow checking on durations.
3016 * xfaces.c (Fbitmap_spec_p):
3017 Check that fixnums are in proper range for system types.
3018 (compare_fonts_by_sort_order):
3019 Avoid mishandling comparisons due to subtraction overflow.
3020 (Fx_family_fonts, realize_basic_faces):
3021 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3022 (Fx_family_fonts):
3023 Don't assume fixnum fits in int.
3024 Use SAFE_ALLOCA_LISP, not alloca.
3025 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3026 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3027 (face_at_buffer_position, face_for_overlay_string)
3028 (face_at_string_position):
3029 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3030 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3031 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3032 (Fx_show_tip):
3033 Check that fixnums are in proper range for system types.
3034 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3035 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3036 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3037 (Fx_change_window_property): Don't assume fixnums fit in int.
3038 * xfont.c (xfont_chars_supported):
3039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3040 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3041 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3043 * xml.c (parse_region):
3044 * xrdb.c (magic_file_p):
3045 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3046 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3047 (x_get_local_selection, x_reply_selection_request)
3048 (x_handle_selection_request, wait_for_property_change):
3049 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3050 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3051 short is wide enough.
3052 (x_send_client_event): Don't assume fixnum fits in int.
3053 * xterm.c (x_x_to_emacs_modifiers):
3054 Don't assume EMACS_INT overflows nicely into int.
3055 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3056 may come from Lisp.
3057 (handle_one_xevent): NATNUMP can eval its arg twice.
3058 (x_connection_closed):
3059 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3060 * xterm.h: Adjust decls to match defn changes elsewhere.
3061 (struct scroll_bar): Use struct vectorlike_header
3062 rather than rolling our own approximation.
3063 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3064
c6574eb5
GM
30652012-05-25 Glenn Morris <rgm@gnu.org>
3066
3067 * lisp.mk (lisp): Update for more files being compiled now.
3068
e8d32c7e
SM
30692012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3070
48def666
SM
3071 * lread.c: Remove `read_pure' which makes no difference.
3072 (read_pure): Remove var.
3073 (unreadpure): Remove function.
3074 (readevalloop): Don't call read_list with -1 flag.
3075 (read1, read_vector): Don't test read_pure any more.
3076 (read_list): Simplify.
3077
e8d32c7e
SM
3078 * fileio.c, character.h: Minor style tweaks.
3079
4b2addb7
DA
30802012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3081
3082 * window.h (clip_changed): Remove useless declaration.
3083
584461b2
JB
30842012-05-22 Juanma Barranquero <lekktu@gmail.com>
3085
3086 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3087 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3088
34374650
PE
30892012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3090
3091 Remove src/m/*.
3092 This directory predates autoconf and is no longer needed nowadays.
3093 Move its few remaining bits of functionality to where they're needed.
3094 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3095 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3096 * m/template.h: Remove.
3097 * Makefile.in (M_FILE): Remove. All uses removed.
3098 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3099 * lisp.h (USE_LSB_TAG):
3100 * mem-limits.h (EXCEEDS_LISP_PTR):
3101 Use VAL_MAX, not VALBITS, in #if.
3102 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3103 (EMACS_UINT): Define unconditionally now.
3104 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3105 (BITS_PER_EMACS_INT): New constants, replacing
3106 what used to be in config.h, but not useful in #if.
3107 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3108 define them any more.
3109 (VAL_MAX): New macro.
3110 (VALMASK): Use it.
3111 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3112 BITS_PER_EMACS_INT, in #if.
3113 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3114 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3115 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3116 * s/ms-w32.h (DATA_START):
3117 Move here from removed file m/intel386.h.
3118 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3119 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3120
261cb4bb
PE
31212012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3122
3123 Assume C89 or later.
3124 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3125 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3126 (xrealloc):
3127 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3128 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3129 * textprop.c, tparam.c (NULL): Remove.
3130 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3131 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3132 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3133 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3134 * xterm.c (input_signal_count): Assume volatile works.
3135
ff23cd9f
KB
31362012-05-21 Ken Brown <kbrown@cornell.edu>
3137
3138 * xgselect.c (xg_select): Fix first argument in call to 'select'
3139 (bug#11508).
3140
1b170bc6
KB
31412012-05-20 Ken Brown <kbrown@cornell.edu>
3142
3143 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3144 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3145
b2f4d39f
KB
31462012-05-19 Ken Brown <kbrown@cornell.edu>
3147
3148 * xfns.c (x_in_use): Remove `static' qualifier.
3149 * xterm.h (x_in_use): Declare.
3150 * xgselect.c: Include xterm.h.
3151 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3152 and `display_arg' (bug#9754).
3153
003fdae2
PE
31542012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3155
9232a6d9
PE
3156 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3157
003fdae2
PE
3158 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3159 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3160
784b56e2
EZ
31612012-05-18 Eli Zaretskii <eliz@gnu.org>
3162
3163 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3164
3165 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3166 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3167
3168 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3169 reference to image_cache->refcount.
3170 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3171
a0a79cde
JL
31722012-05-17 Juri Linkov <juri@jurta.org>
3173
3174 * search.c (Fword_search_regexp, Fword_search_backward)
3175 (Fword_search_forward, Fword_search_backward_lax)
3176 (Fword_search_forward_lax): Move functions to isearch.el
3177 (bug#10145, bug#11381).
3178
b0572523
PE
31792012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3180
3181 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3182
9660f5fc
SM
31832012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3184
3185 * lread.c (init_obarray): Declare Qt and Qnil as special.
3186
4374de83
GM
31872012-05-14 Glenn Morris <rgm@gnu.org>
3188
3189 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3190 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3191
dc44c39a
PE
31922012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3193
078c97cb
PE
3194 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3195
dc44c39a
PE
3196 * unexaix.c: Port to more-recent AIX compilers.
3197 (report_error, report_error_1, make_hdr, copy_sym)
3198 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3199 Make arguments const char *, not char *, to avoid violations of C
3200 standard and to fix some AIX warnings reported by Gilles Pion.
3201
e18afed7 32022012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3203
3204 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3205 already have overlays loaded.
3206 (handle_single_display_spec): Before returning without displaying
3207 fringe bitmap, synchronize the bidi iterator with the main display
3208 iterator, by calling iterate_out_of_display_property.
3209 (iterate_out_of_display_property): Detect buffer iteration by
3210 testing that it->string is a Lisp string.
3211 (get_next_display_element): When the current object is exhausted,
3212 and there's something on it->stack, call set_iterator_to_next to
3213 proceed with what's on the stack, instead of returning zero.
3214 (set_iterator_to_next): If called at the end of a Lisp string,
3215 proceed to consider_string_end without incrementing string
3216 position. Don't increment display vector index past the end of
3217 the display vector. (Bug#11417)
c8fb9dc6
EZ
3218 (pos_visible_p): Don't report a position visible when move_it_to
3219 stopped at the last line of window, which happens to be scanned
3220 backwards by the bidi iteration. (Bug#11464)
ac268e67 3221
e18afed7 32222012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3223
3224 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3225 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3226 are on a TTY, and thus unable to display on the fringes.
3227 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3228 so we need to signal to the caller that this is a "replacing"
3229 display spec. This fixes display when the spec is invalid or we
3230 are on a TTY.
3231
e18afed7 32322012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3233
3234 * unexaix.c (make_hdr): Fix typo in prototype.
3235 This bug broke the build on AIX. Problem reported by Gilles Pion.
3236
9d0a235a
MA
32372012-05-14 Michael Albinus <michael.albinus@gmx.de>
3238
3239 * keyboard.c (kbd_buffer_get_event): Read special events also in
3240 batch mode. (Bug#11415)
3241
9e6b06ed
GM
32422012-05-12 Glenn Morris <rgm@gnu.org>
3243
3244 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3245
c1a1d7a3
EZ
32462012-05-12 Eli Zaretskii <eliz@gnu.org>
3247
3248 * lisp.mk (lisp): Add newcomment.elc.
3249
3fe7cdc8
GM
32502012-05-12 Glenn Morris <rgm@gnu.org>
3251
3252 * Makefile.in (MKDIR_P): New, set by configure.
3253 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3254
53f7d2c0
PE
32552012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3256
3257 Remove unused function hourglass_started.
3258 * dispextern.h (hourglass_started):
3259 * w32fns.c (hourglass_started):
3260 * xdisp.c (hourglass_started): Remove.
3261
75aafb17
JB
32622012-05-10 Juanma Barranquero <lekktu@gmail.com>
3263
3264 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3265 Update dependencies.
3266
12959e8e
PE
32672012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3268
97107e2e
PE
3269 * xgselect.c (xg_select): Put maxfds+1 into a var.
3270 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3271
12959e8e
PE
3272 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3273
836d29b3
DA
32742012-05-10 Dave Abrahams <dave@boostpro.com>
3275
3276 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3277 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3278
5cb67954
MA
32792012-05-09 Michael Albinus <michael.albinus@gmx.de>
3280
3281 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3282 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3283 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3284 Initialize xd_registered_buses.
3285
3478ec45
PE
32862012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3287
b263a6b0
PE
3288 Untag more efficiently if USE_LSB_TAG.
3289 This is based on a proposal by YAMAMOTO Mitsuharu in
3290 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3291 For an admittedly artificial (nth 8000 longlist) benchmark on
3292 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3293 Emacs's overall text size by 1%.
3294 * lisp.h (XUNTAG): New macro.
3295 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3296 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3297 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3298 * eval.c (Fautoload):
3299 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3300 * frame.h (XFRAME): Use XUNTAG.
3301
3478ec45
PE
3302 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3303 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3304 Remove unportable assumptions about print widths of types like
3305 dbus_uint32_t.
3306 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3307 intptr_t when converting between pointer and integer, to avoid GCC
3308 warnings about wrong width.
3309
666b903b 33102012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3311
3312 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3313 stack for each reader_thread, instead of defaulting to 8MB
3314 determined by the linker. This avoids failures in creating
3315 subprocesses on Windows 7, see the discussion in this thread:
3316 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3317
b120cc17
JC
33182012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3319
3320 Fix up display of the *Minibuf-0* buffer in the mini window.
3321 * keyboard.c (read_char): Don't clear the echo area if there's no
3322 message to clear.
3323 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3324 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3325
9a4b36f8
MA
33262012-05-07 Michael Albinus <michael.albinus@gmx.de>
3327
3328 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3329 batch mode.
3330
e5f9458f
CY
33312012-05-06 Chong Yidong <cyd@gnu.org>
3332
3333 * lisp.mk (lisp): Update.
3334
eceeb5fc 33352012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3336
3337 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3338
71873e2b
SM
33392012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3340
3341 * data.c (PUT_ERROR): New macro.
3342 (syms_of_data): Use it. Add new error type `user-error'.
3343 * undo.c (user_error): New function.
3344 (Fprimitive_undo): Use it.
3345 * print.c (print_error_message): Adjust print style for `user-error'.
3346 * keyboard.c (user_error): New function.
3347 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3348
ab0fa4e4
PE
33492012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3350
3351 Do not limit current-time-string to years 1000..9999.
3352 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3353 (Fcurrent_time_string): Support any year that is supported by the
3354 underlying localtime representation. Don't use asctime, as it
3355 has undefined behavior for years outside the range -999..9999.
3356
7ed806a7
PE
33572012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3358
3359 Fix race conditions involving setenv, gmtime, localtime, asctime.
3360 Without this fix, interrupts could mess up code that uses these
3361 nonreentrant functions, since setting TZ invalidates existing
3362 tm_zone or tzname values, and since most of these functions return
3363 pointers to static storage.
3364 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3365 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3366 Grow the critical sections to include not just invoking
3367 localtime/gmtime, but also accessing these functions' results
3368 including their tm_zone values if any, and any related TZ setting.
3369 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3370 so that the struct tm is saved in the critical section.
3371 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3372 motivated by the fact that memory allocation needs to be outside
3373 the critical section.
3374
0c16dfed
DA
33752012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3376
3377 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3378 with RESET_INTERVAL.
3379
3380 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3381 Remove duplicated buffer name initialization.
3382
3f83ace8
JM
33832012-05-02 Jim Meyering <jim@meyering.net>
3384
3385 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3386
c7b8541e
JM
3387 * xfns.c (x_window): Use xstrdup (Bug#11375).
3388
90207a15 33892012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3390
3391 * xdisp.c (pos_visible_p): If already at a newline from the
3392 display string before the 'while' loop, don't walk back the glyphs
3393 from it3.glyph_row. Solves assertion violation when the display
3394 string begins with a newline (egg.el). (Bug#11367)
3395
b593d6a9
AH
33962012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3397
3398 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3399 Move to simple.el.
3400
4737362e
GM
34012012-05-01 Glenn Morris <rgm@gnu.org>
3402
99cf43f9
GM
3403 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3404 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3405 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3406 All were removed before 23.1.
3407
9311dcff
GM
3408 * dispnew.c: Remove HAVE_LIBNCURSES test;
3409 it is always true on relevant platforms.
3410
4d5c6349
GM
3411 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3412 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3413
4737362e
GM
3414 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3415
74dd3a6b
AS
34162012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3417
3418 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3419 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3420 Remove.
3421
13c379ee
PE
34222012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3423
3424 Do not avoid creating empty evaporating overlays (Bug#9642).
3425 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3426 That is, do not delete an evaporating overlay if it becomes
3427 empty after its bounds are adjusted to fit within its buffer.
3428 This fix caused other problems, and I'm reverting it until we get
3429 to the bottom of them.
3430
a8e7d6d7 34312012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3432
3433 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3434
a8e7d6d7 34352012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3436
3437 * xdisp.c (pos_visible_p): If the window start position is beyond
3438 ZV, start the display from buffer beginning. Prevents assertion
3439 violation in init_iterator when the minibuffer window is scrolled
3440 via the scroll bar.
3441
3442 * window.c (window_scroll_pixel_based): Likewise.
3443
a8e7d6d7 34442012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3445
3446 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3447
a8e7d6d7 34482012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3449
3450 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3451 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3452
a8e7d6d7 34532012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3454
b593d6a9
AH
3455 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3456 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3457
1c6900d9
EZ
34582012-04-26 Eli Zaretskii <eliz@gnu.org>
3459
4c3fa1d9
EZ
3460 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3461 display element, check also the underlying string or buffer
3462 character. (Bug#11341)
3463
1c6900d9
EZ
3464 * w32menu.c: Include w32heap.h.
3465 (add_menu_item): If the call to AppendMenuW (via
3466 unicode_append_menu) fails, disable Unicode menus only if we are
3467 running on Windows 9X/Me.
3468
42bf8205
AS
34692012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3470
3471 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3472 (xgetint): Add missing shift for LSB tags.
3473
b1bac16e
MR
34742012-04-24 Martin Rudalics <rudalics@gmx.at>
3475
3476 * keyboard.c (read_char): Don't wipe echo area for select window
3477 events: These might get delayed via `mouse-autoselect-window'
3478 (Bug#11304).
3479
d69621cc
JB
34802012-04-24 Juanma Barranquero <lekktu@gmail.com>
3481
3482 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3483 manipulation of :loaded-from data.
3484
02fd101b
JB
34852012-04-23 Juanma Barranquero <lekktu@gmail.com>
3486
3487 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3488 now a cons (bug#11311).
3489
888bec30
PE
34902012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3491
89a438bd
PE
3492 Do not create empty overlays with the evaporate property (Bug#9642).
3493 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3494 if it becomes empty after its bounds are adjusted to fit within
3495 its buffer. Without this fix, in a nonempty buffer (let ((o
3496 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3497 yields an empty overlay that has the evaporate property, which is
3498 not supposed to happen.
3499
1068fe4d
PE
3500 Fix minor GTK3 problems found by static checking.
3501 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3502 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3503 (struct _EmacsFixedClass, emacs_fixed_get_type):
3504 Move decls here from emacsgtkfixed.h, since they needn't be public.
3505 (emacs_fixed_get_type): Now static.
3506 (emacs_fixed_class_init): Omit unused local.
3507 (emacs_fixed_child_type): Remove; unused.
3508 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3509 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3510 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3511 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3512 (EMACS_FIXED_GET_CLASS): Remove; unused.
3513 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3514
888bec30
PE
3515 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3516 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3517
de85e130
PE
35182012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3519
d0baac98 3520 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3521 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3522 (__malloc_size_t, __malloc_ptrdiff_t):
3523 Remove. All uses removed, replaced by the definiens if needed,
3524 since we can assume C89 or better now.
3525 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3526 (protect_malloc_state, align, get_contiguous_space)
3527 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3528 (malloc_atfork_handler_child, malloc_enable_thread)
3529 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3530 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3531 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3532 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3533 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3534 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3535 Define using prototypes, not old style.
3536 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3537 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3538 (align): Don't assume that signed integer overflow wraps around.
3539 Omit unused local var.
3540 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3541 (_free_internal_nolock, memalign, mallochook, reallochook):
3542 Omit no-longer-needed casts.
3543 (valloc): Use getpagesize, not __getpagesize.
3544 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3545 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3546
de85e130
PE
3547 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3548
dcbf5805
MA
35492012-04-22 Michael Albinus <michael.albinus@gmx.de>
3550
3551 Move functions from C to Lisp. Make non-blocking method calls
3552 the default. Implement further D-Bus standard interfaces.
3553
3554 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3555 (QCdbus_request_name_allow_replacement)
3556 (QCdbus_request_name_replace_existing)
3557 (QCdbus_request_name_do_not_queue)
3558 (QCdbus_request_name_reply_primary_owner)
3559 (QCdbus_request_name_reply_in_queue)
3560 (QCdbus_request_name_reply_exists)
3561 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3562 (QCdbus_registered_serial, QCdbus_registered_method)
3563 (QCdbus_registered_signal): New Lisp objects.
3564 (XD_DEBUG_MESSAGE): Use sizeof.
3565 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3566 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3567 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3568 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3569 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3570 (xd_signature, xd_append_arg): Allow float for integer types.
3571 (xd_get_connection_references): New function.
b593d6a9
AH
3572 (xd_get_connection_address): Rename from xd_initialize.
3573 Return cached address.
dcbf5805
MA
3574 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3575 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3576 level.
3577 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3578 Return number of refcounts.
dcbf5805
MA
3579 (Fdbus_get_unique_name): Make stronger parameter check.
3580 (Fdbus_message_internal): New defun.
3581 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3582 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3583 (Fdbus_send_signal, Fdbus_register_service)
3584 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3585 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3586 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3587 (Vdbus_compiled_version, Vdbus_runtime_version)
3588 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3589 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3590 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3591 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3592 Adapt docstring.
dcbf5805 3593
52828e02
PE
35942012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3595
da05bc4c
PE
3596 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3597 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3598 Do not assume ptrdiff_t is the same width as 'int'.
3599
52828e02
PE
3600 * alloc.c: Handle unusual debugging option combinations.
3601 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3602 since the two debugging options are incompatible.
3603 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3604 is defined.
3605 (mem_init, mem_insert, mem_insert_fixup):
3606 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3607 (NEED_MEM_INSERT): Remove; no longer needed.
3608
f01769f9
LL
36092012-04-22 Leo Liu <sdl.web@gmail.com>
3610
3611 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3612
5790543d
PE
36132012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3614
3615 * sysdep.c [__FreeBSD__]: Minor cleanups.
3616 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3617 Use Emacs indenting style more consistently. Avoid some casts.
3618 Use 'double' consistently rather than mixing 'float' and 'double'.
3619
b91b7e4d
EW
36202012-04-21 Eduard Wiebe <usenet@pusto.de>
3621
b593d6a9
AH
3622 * sysdep.c (list_system_processes, system_process_attributes):
3623 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3624
6114eb15
AS
36252012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3626
3627 * lisp.mk (lisp): Update.
3628
2f38dff7
PE
36292012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3630
3631 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3632 It is never used otherwise.
3633
4ae29f89
SM
36342012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3635
3636 * print.c (print_preprocess): Only check print_depth if print-circle
3637 is nil.
3638 (print_object): Check for cycles even when print-circle is nil and
3639 print-gensym is t, but only check print_depth if print-circle is nil.
3640
f30d612a
CY
36412012-04-20 Chong Yidong <cyd@gnu.org>
3642
3643 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3644 set the status to "failed" and ensure that sentinel is run.
3645
c07a4c0b 36462012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3647
3648 * process.c (Fset_process_inherit_coding_system_flag)
3649 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3650 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3651
c07a4c0b 36522012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3653
3654 * xdisp.c (string_buffer_position_lim): Limit starting position to
3655 BEGV.
3656 (set_cursor_from_row): If called for a mode-line or header-line
3657 row, return zero immediately.
3658 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3659 farther than the first row after the header line, if any.
3660 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3661 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3662
c07a4c0b 36632012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3664
4ae29f89
SM
3665 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3666 (bug#11238).
ad3a2b41 3667
c07a4c0b 36682012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 36692012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3670
3671 configure: new option --enable-gcc-warnings (Bug#11207)
3672 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3673 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3674 (ALL_CFLAGS): Use new macros rather than old.
3675 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3676 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3677 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3678 -Wunused-result, -Wunused-variable. This should go away once
3679 the Emacs and Gnulib regex code is merged.
3680 (xmalloc, xrealloc): Now static.
3681
aba027e8
PE
36822012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3683
3684 * dired.c (Fsystem_groups): Remove unused local.
3685
e5a36063
GM
36862012-04-17 Glenn Morris <rgm@gnu.org>
3687
3688 * dired.c (Fsystem_users): Doc fix.
3689
316411f0
DA
36902012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3691
3692 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3693 (syms_of_dired): Add them.
3694
9426aba4
PE
36952012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3696
b62a57be
PE
3697 Fix minor alloc.c problems found by static checking.
3698 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3699 New extern decls, to avoid calling undeclared functions.
3700 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3701 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3702 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3703 (NEED_MEM_INSERT): New macro.
3704 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3705 Remove one incorrect comment and fix another.
b62a57be 3706
3539f31f
PE
3707 Fix minor ralloc.c problems found by static checking.
3708 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3709 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3710 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3711 (r_alloc_sbrk): Now static.
3712
a041960a
PE
3713 Improve ralloc.c interface checking.
3714 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3715 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3716 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3717 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3718 [REL_ALLOC]: ... to here, to check interface.
3719 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3720 Remove decls. This fixes an "It stinks!".
3721
9426aba4
PE
3722 * alloc.c (which_symbols): Fix alignment issue / type clash.
3723
d55c12ed
AS
37242012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3725
3726 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3727 (struct Lisp_Misc_Any): Likewise.
3728 (struct Lisp_Free): Likewise.
3729 * alloc.c (union aligned_Lisp_Symbol): Define.
3730 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3731 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3732 (union aligned_Lisp_Misc): Define.
3733 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3734 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3735 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3736
b948ce8b
PE
37372012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3738
3739 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3740 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3741 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3742 * s/netbsd.h, s/sol2-6.h:
3743 Remove definition of GC_MARK_STACK, since the default now works.
3744 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3745 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3746 no longer the default.
3747 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3748
35dc09a1 37492012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3750
35dc09a1
GM
3751 * lread.c (lisp_file_lexically_bound_p):
3752 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3753
35dc09a1
GM
37542012-04-14 Eli Zaretskii <eliz@gnu.org>
3755
3756 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3757 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3758
37592012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3760
3761 * nsterm.m (constrainFrameRect): Always constrain when there is only
3762 one screen (Bug#10962).
3763
bcd86815
KB
37642012-04-13 Ken Brown <kbrown@cornell.edu>
3765
3766 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3767
c25df26e
RT
37682012-04-13 Reuben Thomas <rrt@sc3d.org>
3769
3770 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3771
0fc59f1e
DC
37722012-04-11 Daniel Colascione <dancol@dancol.org>
3773
3774 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3775 against is gone. It's better to use vfork now so that when Cygwin
3776 gains a new, working vfork, we use it automatically (bug#10398).
3777
de8c03dc
SM
37782012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3779
3780 * window.c (save_window_save): Obey window-point-insertion-type.
3781
2f097256
GM
37822012-04-11 Glenn Morris <rgm@gnu.org>
3783
3784 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3785
453b951e
SM
37862012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3787
3788 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3789
75f1671a 37902012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3791
3792 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3793 (force_quit_count): New var.
3794 (handle_interrupt): Use it.
3795
2a8ce227
JB
37962012-04-10 Juanma Barranquero <lekktu@gmail.com>
3797
3798 * w32.c (w32_delayed_load): Record the full path of the library
3799 being loaded (bug#10424).
3800
935396c0
GM
38012012-04-09 Glenn Morris <rgm@gnu.org>
3802
05920a43
GM
3803 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3804 not just in the obarray, before snarfing them. (Bug#11036)
3805
935396c0
GM
3806 * Makefile.in ($(leimdir)/leim-list.el):
3807 Pass EMACS rather than BUILT_EMACS.
3808
a18ecafa
TZ
38092012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3810
3811 * process.c (make_process):
3812 * process.h: Add integer `gnutls_handshakes_tried' member to
3813 process struct.
3814
6bbef4e5
JC
3815 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3816 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3817
3818 * gnutls.c (gnutls_log_function2i): Convenience log function.
3819 (emacs_gnutls_read): Use new log functions,
3820 `gnutls_handshakes_tried' process member, and
3821 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3822 attempts per process (connection).
3823
b4d3bc10
CY
38242012-04-09 Chong Yidong <cyd@gnu.org>
3825
3826 * eval.c (Fuser_variable_p, user_variable_p_eh)
3827 (lisp_indirect_variable): Functions deleted.
3828 (Fdefvar): Caller changed.
3829
3830 * callint.c (Finteractive, Fcall_interactively):
3831 * minibuf.c (Fread_variable): Callers changed.
3832
70f4d973
EZ
38332012-04-09 Eli Zaretskii <eliz@gnu.org>
3834
3835 * xdisp.c (set_cursor_from_row): If the display string appears in
3836 the buffer at position that is closer to point than the position
3837 after the display string, display the cursor on the first glyph of
3838 the display string. Fixes cursor display when a 'display' text
3839 property immediately follows invisible text. (Bug#11094)
3840
cb3c2e3e
PE
38412012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3842
3843 composite.c: use 'double' consistently
3844 * composite.c (get_composition_id): Use 'double' consistently
3845 instead of converting 'float' to 'double' and vice versa; this is
3846 easier to understand and avoids a GCC warning.
3847
fd06db5d
GM
38482012-04-09 Glenn Morris <rgm@gnu.org>
3849
50fe702a
GM
3850 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3851 preparation for dumping it with emacs. (Bug#4789)
3852 (leimdir): New variable.
3853 ($(leimdir)/leim-list.el): New rule.
3854 (emacs$(EXEEXT)): Depend on leim-list.el.
3855
fd06db5d
GM
3856 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3857 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3858 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3859
55c131ee
AS
38602012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3861
3862 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3863 proper alignment.
3864
9209588f
JB
38652012-04-07 Juanma Barranquero <lekktu@gmail.com>
3866
3867 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3868 Remove unused local variable.
3869
e3fb2efb
PE
38702012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3871
3872 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3873 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3874 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3875 objects, as mark_maybe_pointer will catch them otherwise.
3876 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3877 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3878
b5385551
PE
38792012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3880
3881 Fix typo that broke non-Windows builds.
3882 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3883
9078ead6
EZ
38842012-04-07 Eli Zaretskii <eliz@gnu.org>
3885
3886 Support building on MS-Windows with libxml2.
3887
3888 * makefile.w32-in (OBJ2): Add xml.$(O).
3889 (GLOBAL_SOURCES): Add xml.c.
3890 ($(BLD)/xml.$(O)): New dependency list.
3891
3892 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3893 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3894 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3895 [!WINDOWSNT]: New macros.
3896 (init_libxml2_functions, libxml2_loaded_p): New functions.
3897 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3898 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3899 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3900 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3901 linked in).
6bbef4e5
JC
3902 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3903 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3904 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3905
3906 * emacs.c: Don't include libxml/parser.h.
3907 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3908 xmlCleanupParser directly.
3909
3910 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3911
3811fdf3
EZ
39122012-04-07 Eli Zaretskii <eliz@gnu.org>
3913
3914 * indent.c (Fvertical_motion): If there is a display string at
3915 point, use it.vpos to compute how many lines to backtrack after
3916 move_it_to point. (Bug#11133)
3917
2f8e16b2
EZ
39182012-04-06 Eli Zaretskii <eliz@gnu.org>
3919
3920 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3921 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3922 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3923 macros related to unification of CJK characters. For the details,
3924 see the discussion following the message here:
3925 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3926
3d439cd1
CY
39272012-04-04 Chong Yidong <cyd@gnu.org>
3928
3929 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3930
8bc53d00
EZ
39312012-04-01 Eli Zaretskii <eliz@gnu.org>
3932
3933 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3934 instead of alloca. (Bug#11138)
3935
3b0512a3
AS
39362012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3937
3938 * w32menu.c (is_simple_dialog): Properly check lisp types.
3939 (Bug#11141)
3940
8427ddd2
EZ
39412012-03-31 Eli Zaretskii <eliz@gnu.org>
3942
979022ef
EZ
3943 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3944 position we get to after a call to move_it_to fails the
3945 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3946 only if we wind up in a string from display property. (Bug#11063)
3947
a6b1c7cc
EZ
3948 * window.c (Fdelete_other_windows_internal): Invalidate the row
3949 and column information about mouse highlight, so that redisplay
3950 restores it after reallocating the glyph matrices. (Bug#7464)
3951
8427ddd2
EZ
3952 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3953 string comes from a `display' text property, use the buffer
3954 position of that property as if we actually saw that position in
3955 the row's glyphs.
697ba24b
EZ
3956 (move_it_by_lines): Remove the assertion that
3957 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3958 violated when there's a before-string at the beginning of a line.
3959 (Bug#11063)
8427ddd2 3960
65a0a738
EZ
39612012-03-30 Eli Zaretskii <eliz@gnu.org>
3962
3963 * xdisp.c (append_space_for_newline): If the default face was
3964 remapped, use the remapped face for the appended newline.
3965 (extend_face_to_end_of_line): Use the remapped default face for
3966 extending the face to the end of the line.
3967 (display_line): Call extend_face_to_end_of_line when the default
3968 face was remapped. (Bug#11068)
3969
581355cc
EZ
39702012-03-29 Eli Zaretskii <eliz@gnu.org>
3971
3972 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3973
e8fc049f
SM
39742012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3975
3976 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3977
4fb9a543
GM
39782012-03-27 Glenn Morris <rgm@gnu.org>
3979
3980 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3981 Doc fixes.
3982
679910f1
KH
39832012-03-26 Kenichi Handa <handa@m17n.org>
3984
3985 * dispextern.h (struct glyph): Fix previous change. Change the
3986 bit length of glyphless.ch to 25 (Bug#11082).
3987
90d49b7f
CY
39882012-03-26 Chong Yidong <cyd@gnu.org>
3989
3990 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3991 (command_loop_1): Use it; inhibit selection update for
3992 handle-select-window too (Bug#8996).
3993
f514f6f0
FP
39942012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3995
e8fc049f 3996 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3997
bf43fa51
KH
39982012-03-25 Kenichi Handa <handa@m17n.org>
3999
4000 * dispextern.h (struct glyph): Change the bit length of
4001 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4002
8a0c01dd
EZ
40032012-03-24 Eli Zaretskii <eliz@gnu.org>
4004
4005 * s/ms-w32.h (tzname): Include time.h before redirecting to
4006 _tzname. Fixes the MSVC build. (Bug#9960)
4007
7d1c3a76
AS
40082012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4009
8ed79523
AS
4010 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4011 characters.
4012
7d1c3a76
AS
4013 * xterm.c (XTread_socket): Only modify handling_signal if
4014 !SYNC_INPUT. (Bug#11080)
4015
e99a9b8b
EZ
40162012-03-23 Eli Zaretskii <eliz@gnu.org>
4017
4018 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4019 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4020 when fetching a multibyte character consumes more bytes than
4021 CHAR_BYTES returns, due to unification of CJK characters in
4022 string_char. (Bug#11073)
4023
5063c0e1
TN
40242012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4025
4026 * process.c (wait_reading_process_output): Handle pty disconnect
4027 by refraining from sending oneself a SIGCHLD (bug#10933).
4028
9f851fbd
CY
40292012-03-22 Chong Yidong <cyd@gnu.org>
4030
4031 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4032
5063c0e1 4033 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4034 Mark string as coming from a prefix property.
4035 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4036 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4037
fb5b8aca
CY
40382012-03-21 Chong Yidong <cyd@gnu.org>
4039
4040 * xfaces.c (Vface_remapping_alist): Doc fix.
4041
62356a1b
EZ
40422012-03-20 Eli Zaretskii <eliz@gnu.org>
4043
4044 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4045 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4046 Doc fixes.
62356a1b 4047
025de85b
CY
40482012-03-20 Chong Yidong <cyd@gnu.org>
4049
4050 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4051 to reflect default non-nil value of redisplay-dont-pause.
4052
4827f94e
KH
40532012-03-19 Kenichi Handa <handa@m17n.org>
4054
4055 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4056 it fit in a valid range (Bug#11003).
4057
e50a24a2
EZ
40582012-03-18 Eli Zaretskii <eliz@gnu.org>
4059
4060 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4061 that is not from display property, accept the row as a "cursor
4062 row" if one of the string's character has a non-nil `cursor'
4063 property. Fixes cursor positioning when there are newlines in
4064 overlay strings, e.g. in icomplete.el. (Bug#11035)
4065
9af5ed87
PE
40662012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4067
4068 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4069
d1f55f16
CY
40702012-03-12 Chong Yidong <cyd@gnu.org>
4071
4072 * eval.c (inhibit_lisp_code): Rename from
4073 inhibit_window_configuration_change_hook; move from window.c.
4074
4075 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4076 * window.c (run_window_configuration_change_hook)
4077 (syms_of_window): Callers changed.
4078
66c5eebd
CY
40792012-03-11 Chong Yidong <cyd@gnu.org>
4080
413df973
CY
4081 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4082
66c5eebd
CY
4083 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4084
1de11f56
CY
40852012-03-10 Chong Yidong <cyd@gnu.org>
4086
4087 * frame.c (other_visible_frames): Don't assume the selected frame
4088 is visible (Bug#10955).
4089
cae07000
SM
40902012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4091
4092 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4093
89c94350
JD
40942012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4095
4096 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4097 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4098 zero (Bug#10954).
4099
999dd333
GM
41002012-03-03 Glenn Morris <rgm@gnu.org>
4101
01a6dcc8 4102 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4103
de0100f2
EZ
41042012-03-02 Eli Zaretskii <eliz@gnu.org>
4105
4106 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4107 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4108 (redisplay_window, next_element_from_string): Fix typos in
4109 comments.
3e441275
EZ
4110 (redisplay_window): Pass to move_it_vertically the margin in
4111 pixels, not in screen lines.
de0100f2 4112
96a72ee9
GM
41132012-03-02 Glenn Morris <rgm@gnu.org>
4114
4115 * buffer.c (buffer-list-update-hook): Doc fix.
4116
312508d7
EZ
41172012-02-29 Eli Zaretskii <eliz@gnu.org>
4118
4119 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4120 push_it before setting up the iterator for the first overlay
4121 string, even if we have an empty string loaded.
4122 (next_overlay_string): If there's an empty string on the iterator
4123 stack, pop the stack. (Bug#10903)
4124
27f3c637
PE
41252012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4126
4127 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4128 Suggested by Stefan Monnier in
4129 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4130 * alloc.c (widen_to_Lisp_Object): New static function.
4131 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4132 and widening them to Lisp_Objects. This would work even if
4133 USE_LSB_TAG is defined and wide integers are used, which might
4134 happen in a future version of Emacs.
4135
3c9dfce6
CY
41362012-02-25 Chong Yidong <cyd@gnu.org>
4137
fa74b241
CY
4138 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4139 Doc fix.
4140
3c9dfce6
CY
4141 * xselect.c (Fx_selection_exists_p): Doc fix.
4142 (x_clipboard_manager_save_all): Print an informative message
4143 before saving to clipboard manager.
4144
9486df08
CY
41452012-02-24 Chong Yidong <cyd@gnu.org>
4146
4147 * keyboard.c (process_special_events): Handle all X selection
4148 requests in kbd_buffer, not just the next one (Bug#8869).
4149
f01d3321
CY
41502012-02-23 Chong Yidong <cyd@gnu.org>
4151
4152 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4153 call when setting menu-bar-lines and tool-bar-lines parameters.
4154 (unwind_create_frame_1): New helper function.
4155
4156 * window.c (inhibit_window_configuration_change_hook): New var.
4157 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4158 (syms_of_window): Initialize it.
f01d3321 4159
86b847b6
CY
41602012-02-22 Chong Yidong <cyd@gnu.org>
4161
4162 * xterm.c (x_draw_image_relief): Add missing type check for
4163 Vtool_bar_button_margin (Bug#10743).
4164
a59225b1
CY
41652012-02-21 Chong Yidong <cyd@gnu.org>
4166
4167 * fileio.c (Vfile_name_handler_alist): Doc fix.
4168
4169 * buffer.c (Fget_file_buffer): Protect against invalid file
4170 handler return value.
4171
310f5bd4
PE
41722012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4173
cb3a28cc
PE
4174 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4175 when computing $valmask.
4176
310f5bd4
PE
4177 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4178 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4179 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4180 It's useless in that case, and it can cause problems on hosts
4181 that allocate halves of EMACS_INT values separately.
4182 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4183 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4184 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4185 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4186 it avoids undefined behavior on hosts where shifting right by more
4187 than the word width has undefined behavior.
4188
2375c96a
CY
41892012-02-19 Chong Yidong <cyd@gnu.org>
4190
4191 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4192 (Funhandled_file_name_directory, Ffile_name_as_directory)
4193 (Fdirectory_file_name, Fexpand_file_name)
4194 (Fsubstitute_in_file_name): Protect against invalid file handler
4195 return values (Bug#10845).
4196
3eb49e71
EZ
41972012-02-18 Eli Zaretskii <eliz@gnu.org>
4198
4199 * .gdbinit (pitx): Fix incorrect references to fields of the
4200 iterator stack.
4201
7b926f3f
CY
42022012-02-17 Chong Yidong <cyd@gnu.org>
4203
4204 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4205
11273115
PE
42062012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4207
4208 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4209 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4210
c3a70e2b
CY
42112012-02-15 Chong Yidong <cyd@gnu.org>
4212
4213 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4214 marked as special. Also, starting docstrings with * is obsolete.
4215
0ca43699
AS
42162012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4217
4218 * gnutls.c (emacs_gnutls_write): Fix last change.
4219
2e8f3c56
LI
42202012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4221
4222 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4223 send_process.
4224
af70074f
SM
42252012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4226
4227 * keymap.c (Fsingle_key_description): Handle char ranges.
4228
95986d52
CY
42292012-02-12 Chong Yidong <cyd@gnu.org>
4230
afd83bd1
CY
4231 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4232 as that creates a dangerous corner case.
4233
95986d52
CY
4234 * window.c (Fdelete_window_internal): Invalidate the mouse
4235 highlight (Bug#9904).
4236
bd7da63e
GM
42372012-02-12 Glenn Morris <rgm@gnu.org>
4238
4239 * xselect.c (Fx_own_selection_internal)
4240 (Fx_get_selection_internal, Fx_disown_selection_internal)
4241 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4242 * nsselect.m (Fx_own_selection_internal)
4243 (Fx_disown_selection_internal, Fx_selection_exists_p)
4244 (Fx_selection_owner_p, Fx_get_selection_internal):
4245 Sync docs and argument specs with the xselect.c versions.
4246
77abcbc2
LI
42472012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4248
4249 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4250
90b671e2
EZ
42512012-02-11 Eli Zaretskii <eliz@gnu.org>
4252
1c0ca0b7
EZ
4253 * w32select.c (Fx_selection_exists_p): Sync doc string and
4254 argument list with xselect.c. (Bug#10783)
4255
4256 * w16select.c (Fx_selection_exists_p): Sync doc string and
4257 argument list with xselect.c. (Bug#10783)
90b671e2 4258
49241268
GM
42592012-02-10 Glenn Morris <rgm@gnu.org>
4260
4261 * fns.c (Fsecure_hash): Doc fix.
4262
f998bbe7 42632012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4264
4265 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4266
0992bd9c
CY
42672012-02-07 Chong Yidong <cyd@gnu.org>
4268
4269 * buffer.c (Fbuffer_local_variables)
4270 (buffer_lisp_local_variables): Handle unbound vars correctly;
4271 don't let Qunbound leak into Lisp.
4272
af008560
GM
42732012-02-07 Glenn Morris <rgm@gnu.org>
4274
dd605cc4
GM
4275 * image.c (Fimagemagick_types): Doc fix.
4276
af008560
GM
4277 * image.c (imagemagick-render-type): Change it from a lisp object
4278 to an integer. Move the doc here from the lisp manual.
4279 Treat all values not equal to 0 the same.
4280
1449fa1d
CY
42812012-02-06 Chong Yidong <cyd@gnu.org>
4282
4283 * doc.c (store_function_docstring): Avoid applying docstring of
4284 alias to base function (Bug#2603).
4285
3723ec07
AS
42862012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4287
4288 * .gdbinit (pp1, pv1): Remove redundant defines.
4289 (pr): Use pp.
4290
79c1cc1e
CY
42912012-02-04 Chong Yidong <cyd@gnu.org>
4292
4293 * nsterm.m: Declare a global (Bug#10694).
4294
d7f29f8e
EZ
42952012-02-04 Eli Zaretskii <eliz@gnu.org>
4296
cae07000
SM
4297 * w32.c (get_emacs_configuration_options):
4298 Include --enable-checking, if specified, in the return value.
d7f29f8e 4299
3b95a6f9
MR
43002012-02-04 Martin Rudalics <rudalics@gmx.at>
4301
4302 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4303 after rounding frame sizes. (Bug#9723)
4304
d6fa96a6
EZ
43052012-02-04 Eli Zaretskii <eliz@gnu.org>
4306
4307 * keyboard.c (adjust_point_for_property): Don't position point
4308 before BEGV. (Bug#10696)
4309
df0b2940
PE
43102012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4311
4312 Handle overflow when computing char display width (Bug#9496).
4313 * character.c (char_width): Return EMACS_INT, not int.
4314 (char_width, c_string_width): Check for overflow when
4315 computing the width; this is possible now that individual
4316 characters can have unbounded width. Problem introduced
4317 by merge from Emacs 23 on 2012-01-19.
4318
6bee44d6
MA
43192012-02-02 Michael Albinus <michael.albinus@gmx.de>
4320
4321 * dbusbind.c (Fdbus_register_method): Mention the return value
4322 :ignore in the docstring.
4323
44f92739
GM
43242012-02-02 Glenn Morris <rgm@gnu.org>
4325
1b9f60cc
GM
4326 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4327
44f92739
GM
4328 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4329 Unconditionally set to t. (Bug#10673)
4330 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4331 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4332 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4333
c5d3843c
KH
43342012-02-02 Kenichi Handa <handa@m17n.org>
4335
4336 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4337 0, do not call append_composite_glyph.
4338
159462d4 43392012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4340
4341 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4342 NULL (Bug#6988).
4343 (x_produce_glyphs): If the component of a composition is a null
4344 string, set it->pixel_width to 1 to avoid zero-width glyph.
4345
78cef877
EZ
43462012-02-01 Eli Zaretskii <eliz@gnu.org>
4347
4348 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4349 first 2 arguments are identical. This makes inserting large
4350 output from a subprocess an order of magnitude faster on
4351 MS-Windows, where all sbrk'ed memory is always contiguous.
4352
97897668
GM
43532012-01-31 Glenn Morris <rgm@gnu.org>
4354
4355 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4356 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4357 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4358
31fd3586
GM
43592012-01-29 Glenn Morris <rgm@gnu.org>
4360
4361 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4362
0e24a8b2
CY
43632012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4364
4365 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4366
cc0adcb0
CY
43672012-01-28 Chong Yidong <cyd@gnu.org>
4368
4369 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4370
acc28cb9
CY
43712012-01-26 Chong Yidong <cyd@gnu.org>
4372
9c69cfb7
CY
4373 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4374
acc28cb9
CY
4375 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4376 repeat counts (Bug#10507).
4377
48da7392
GM
43782012-01-26 Glenn Morris <rgm@gnu.org>
4379
4380 * lread.c (syms_of_lread): Doc fix.
4381
14af5f7f
CY
43822012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4383
4384 * coding.c (encode_designation_at_bol): Change return value to
4385 EMACS_INT.
4386
0b21c100
CY
43872012-01-25 Chong Yidong <cyd@gnu.org>
4388
4389 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4390
3c2907f7
CY
43912012-01-21 Chong Yidong <cyd@gnu.org>
4392
4393 * floatfns.c (Fcopysign): Make the second argument non-optional,
4394 since nil is not allowed anyway.
4395
959ad23f
AS
43962012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4397
4398 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4399 (send_process): Likewise.
4400
34a02f46
MR
44012012-01-19 Martin Rudalics <rudalics@gmx.at>
4402
4403 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4404 (Vwindow_persistent_parameters): Do not use Qstate.
4405 Rewrite doc-strings.
34a02f46 4406
1259009a 44072012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4408
4409 * character.c (char_width): New function.
70d4fdf6
GM
4410 (Fchar_width, c_string_width, lisp_string_width):
4411 Use char_width (Bug#9496).
25ed9e61 4412
6a6ee00d
MR
44132012-01-16 Martin Rudalics <rudalics@gmx.at>
4414
4415 * window.c (Vwindow_persistent_parameters): New variable.
4416 (Fset_window_configuration, save_window_save): Handle persistent
4417 window parameters.
4418
c85efaf7
EZ
44192012-01-14 Eli Zaretskii <eliz@gnu.org>
4420
4421 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4422 thrashing the stack of the thread. (Bug#9087)
4423
5944709e
PE
44242012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4425
4426 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4427
e71f5d99
EZ
44282012-01-11 Eli Zaretskii <eliz@gnu.org>
4429
4430 * xdisp.c (rows_from_pos_range): Handle the case where the
4431 highlight ends on a newline. (Bug#10464)
4432 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4433 he end column for display of highlight that ends on a newline
4434 before a R2L line.
4435
ce316182
GM
44362012-01-11 Glenn Morris <rgm@gnu.org>
4437
4438 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4439 from load-path also when installation-directory is nil. (Bug#10208)
4440
5b43da69
GM
44412012-01-10 Glenn Morris <rgm@gnu.org>
4442
74cc8ff9
GM
4443 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4444
7d8d6e4e
GM
4445 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4446 Update template values to be closer to their typical values these days.
5b43da69 4447
a0db8d43
EZ
44482012-01-09 Eli Zaretskii <eliz@gnu.org>
4449
4450 * xdisp.c (rows_from_pos_range): Accept additional argument
4451 DISP_STRING, and accept any glyph in a row whose object is that
4452 string as eligible for mouse highlight. Fixes mouse highlight of
4453 display strings from overlays. (Bug#10464)
4454
9a0115ab 44552012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4456
b9110d6a 4457 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4458 * fileio.c (auto_saving_dir_umask): New static var.
4459 (Fmake_directory_internal): Use it.
4460 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4461 creating the directory. The old code temporarily assigns
4462 too-generous permissions to the directory.
4463 (do_auto_save_eh): Clear it.
b9110d6a 4464 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4465 that the var is always cleared.
4466
6c1bd3f3
EZ
44672012-01-07 Eli Zaretskii <eliz@gnu.org>
4468
4469 * search.c (scan_buffer): Pass character positions to
4470 know_region_cache, not byte positions. (Bug#6540)
4471
069d2b50
L
44722012-01-07 LynX <_LynX@bk.ru> (tiny change)
4473
4474 * w32.c (sys_rename): Report EXDEV when rename of a directory
4475 fails because the target is on another logical disk. (Bug#10284)
4476
75bf0d33
DB
44772012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4478
4479 * xterm.c (x_embed_request_focus): New function.
4480
4481 * xterm.h: Add prototype.
4482
4483 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4484
1c6e5a32
GM
44852012-01-05 Glenn Morris <rgm@gnu.org>
4486
4487 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4488
651e947e
EZ
44892012-01-01 Eli Zaretskii <eliz@gnu.org>
4490
4491 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4492 Load gnutls_transport_set_lowat only if GnuTLS version is below
4493 2.11.1.
4494 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4495 GnuTLS versions below 2.11.1.
4496
3778cdd8
AL
44972011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4498
4499 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4500 to the doc string advising against its use for altering the way
4501 windows are scrolled.
4502
0e5317f7
KH
45032011-12-28 Kenichi Handa <handa@m17n.org>
4504
4505 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4506 coding-system ASCII compatible only when it does not produce BOM
4507 on encoding (Bug#10383).
4508
93d5ca1f
JD
45092011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4510
4511 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4512 can scroll.
4513 (create_and_show_popup_menu): Always use menu_position_func for
4514 Gtk3 (Bug#10361).
4515
ca22b785
AS
45162011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4517
4518 * callint.c (Fcall_interactively): Don't truncate prompt string.
4519
d048e1e6
EZ
45202011-12-23 Eli Zaretskii <eliz@gnu.org>
4521
4522 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4523 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4524 resumed from there (after widening). (Bug#10360)
d048e1e6 4525
5ccaba1f
JD
45262011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4527
4528 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4529
204ee57f
JD
45302011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4531
b81d40f0
JB
4532 * nsterm.m (x_free_frame_resources):
4533 Release f->output_data.ns->miniimage.
204ee57f
JD
4534 (ns_index_color): Fix indentation. Do not retain
4535 color_table->colors[i].
4536
4537 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4538 before returning.
4539
4540 * nsfns.m (x_set_background_color): Assign return value from
4541 ns_index_color to face-background instead of NSColor*.
4542 (ns_implicitly_set_icon_type): Fix indentation.
4543 Change assignment in for loop to comparison.
4544
4545 * emacs.c (ns_pool): New variable.
4546 (main): Assign ns_pool.
4547 (Fkill_emacs): Call ns_release_autorelease_pool.
4548
4549 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4550 autorelease fdesc, release fdAttrs and tdict.
4551 (ns_get_covering_families): Release charset.
4552 (ns_findfonts): Release NSFontDescriptor created with new.
4553 (ns_uni_to_glyphs): Fix indentation.
4554 (setString): Release attrStr before assigning new value.
4555
c803b2b7
JD
45562011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4557
678f4426
JD
4558 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4559 and NS_IMPL_COCOA.
4560 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4561 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4562
cd394be1 45632011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4564
5fecd5fc
JD
4565 * nsterm.m (ns_term_init): Subscribe for notifications
4566 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4567 to method trackingNotification in EmacsMenu.
4568
4569 * nsmenu.m (trackingMenu): New variable.
3771cb17 4570 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4571 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4572 from Aquamacs (Bug#7030).
678f4426
JD
4573
45742011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4575
c803b2b7
JD
4576 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4577 (symbol_to_nsstring): Fix indentation.
4578 (ns_symbol_to_pb): New function.
cae07000
SM
4579 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4580 (Fns_rotate_cut_buffers_internal): Remove.
4581 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4582 Fns_store_cut_buffer_internal.
4583 (ns_get_foreign_selection, Fx_own_selection_internal)
4584 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4585 (Fns_get_selection_internal, Fns_store_selection_internal):
4586 Use ns_symbol_to_pb and check if return value is nil.
4587 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4588 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4589 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4590 renamed to Sns_store_selection_internal.
4591 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4592 and remove this function.
4593 (ns_handle_selection_clear): Remove, never used.
4594 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4595 here.
4596
e1b01a3a
KB
45972011-12-17 Ken Brown <kbrown@cornell.edu>
4598
4599 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4600 GID is unknown (Bug#10257).
4601
2adb6e85
PE
46022011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4603
4604 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4605 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4606 which caused a build failure on GNU/Linux IA-64. This problem was
4607 introduced by my 2011-10-07 patch.
4608
d1d7b339
JL
46092011-12-15 Juri Linkov <juri@jurta.org>
4610
4611 * image.c (imagemagick_error): New function. (Bug#10112)
4612 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4613 Use `imagemagick_error' where ImageMagick functions return
4614 `MagickFalse'.
4615 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4616 proper order.
4617
100d5755
KH
46182011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4619
4620 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4621 fill background (Bug#8992).
4622
454592a6
MR
46232011-12-13 Martin Rudalics <rudalics@gmx.at>
4624
4625 * window.c (Vwindow_combination_resize)
4626 (Vwindow_combination_limit): Use t instead of non-nil in
4627 doc-strings.
61d4b438
MR
4628 (Vrecenter_redisplay): Add first sentence of doc-string on
4629 separate line.
53524d93 4630 (Frecenter): Fix doc-string typo.
454592a6 4631
3633e3aa
KH
46322011-12-11 Kenichi Handa <handa@m17n.org>
4633
4634 * coding.c (Funencodable_char_position): Pay attention to the
4635 buffer text relocation (Bug#9389).
4636
7b9d523a 46372011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4638
7b9d523a
JD
4639 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4640 gtk_init (Bug#10100).
4641
b73189c6
EZ
46422011-12-10 Eli Zaretskii <eliz@gnu.org>
4643
4644 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4645 IT->string is nil. (Bug#10263)
4646
f7dfe5d6
JD
46472011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4648
83faebb4
JD
4649 * nsterm.h (x_free_frame_resources): Declare.
4650
f7dfe5d6
JD
4651 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4652 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4653
4654 * nsterm.h (ns_get_defaults_value): Declare.
4655
4656 * nsterm.m (ns_default): Call ns_get_defaults_value.
4657
7cd4e72c
EZ
46582011-12-09 Eli Zaretskii <eliz@gnu.org>
4659
4660 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4661 (Bug#10170)
4662
b34d7317
YM
46632011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4664
4665 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4666 that where the value of an _OBJC_* symbol points to is in the .bss
4667 section (Bug#10240).
4668
76470ad1
KH
46692011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4670
4671 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4672 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4673
745fff94
KH
46742011-12-08 Kenichi Handa <handa@m17n.org>
4675
4676 * ftfont.c (get_adstyle_property): Fix previous change
4677 (Bug#10233).
4678
6e44397c
JB
46792011-12-07 Juanma Barranquero <lekktu@gmail.com>
4680
4681 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4682 dirs from the default value of EMACSLOADPATH (bug#10208).
4683
7efa6272
GM
46842011-12-07 Glenn Morris <rgm@gnu.org>
4685
4686 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4687 installation and source directories as well. (Bug#10208)
4688
f6fc4d87
CY
46892011-12-06 Chong Yidong <cyd@gnu.org>
4690
4691 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4692
2bf26180
GM
46932011-12-06 Glenn Morris <rgm@gnu.org>
4694
4695 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4696 as an error, not just -1. (Bug#10217)
4697
3a6ad4f0
CY
46982011-12-05 Chong Yidong <cyd@gnu.org>
4699
4700 * keyboard.c (process_special_events): New function.
4701 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4702
75a3b399
PE
47032011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4704
4705 * coding.c (encode_designation_at_bol): Don't use uninitialized
4706 local variable (Bug#9318).
4707
c3c9e25e
KH
47082011-12-05 Kenichi Handa <handa@m17n.org>
4709
4710 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4711 return Qnil (Bug#8046, Bug#10193).
4712
5eb05ea3
KH
47132011-12-05 Kenichi Handa <handa@m17n.org>
4714
4715 * coding.c (encode_designation_at_bol): New args charbuf_end and
4716 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4717 (coding_set_source): Return how many bytes coding->source was
4718 relocated.
4719 (coding_set_destination): Return how many bytes
4720 coding->destination was relocated.
4721 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4722 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4723
47242011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4725
4726 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4727 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4728 macro (Bug#9318).
4729
47302011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4731
4732 The following changes are to fix Bug#9318.
4733
a79703f5 4734 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4735 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4736 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4737 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4738
7dbda6df
JB
47392011-12-05 Juanma Barranquero <lekktu@gmail.com>
4740
4741 * lisp.h (process_quit_flag): Fix external declaration.
4742
6d5eb5b0
SM
47432011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4744
4745 Don't macro-inline non-performance-critical code.
4746 * eval.c (process_quit_flag): New function.
4747 * lisp.h (QUIT): Use it.
4748
a0c3fad0
JD
47492011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4750
4751 * nsfns.m (get_geometry_from_preferences): New function.
4752 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4753
6c07aac2
AS
47542011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4755
4756 * emacs.c (Qkill_emacs): Define.
4757 (syms_of_emacs): Initialize it.
4758 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4759 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4760 (quit_throw_to_read_char): Add parameter `from_signal'.
4761 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4762 * lisp.h (QUIT): Call Fkill_emacs if requested.
4763
c052ead4
JD
47642011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4765
4766 * widget.c (update_wm_hints): Return if wmshell is null.
4767 (widget_update_wm_size_hints): New function.
4768
4769 * widget.h (widget_update_wm_size_hints): Declare.
4770
4771 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4772 widget_update_wm_size_hints (Bug#10104).
4773
9e49252b
EZ
47742011-12-03 Eli Zaretskii <eliz@gnu.org>
4775
4776 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4777 before a newline, prepare the bidi iterator for consuming the
4778 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4779 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4780
02b16839
JL
47812011-12-02 Juri Linkov <juri@jurta.org>
4782
4783 * search.c (Fword_search_regexp): New Lisp function created from
4784 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4785 (Fword_search_backward, Fword_search_forward)
4786 (Fword_search_backward_lax, Fword_search_forward_lax):
4787 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4788 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4789
0068070e
SM
47902011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4791
4792 * fileio.c (Finsert_file_contents): Move after-change-function call
4793 to before the "handled:" label, since all "goto handled" appear in
4794 cases where the *-change-functions have already been properly called
4795 (bug#10117).
4796
3360a3fc
AS
47972011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4798
4799 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4800 waiting for input. (Bug#10169)
4801
73d6c093
EZ
48022011-11-30 Eli Zaretskii <eliz@gnu.org>
4803
4804 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4805 verifies glyph row's hash code--we have just reallocated the
4806 glyphs, so their contents can be complete garbage. (Bug#10164)
4807
febe6bea
JB
48082011-11-30 Juanma Barranquero <lekktu@gmail.com>
4809
4810 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4811
801a4313
EZ
48122011-11-30 Eli Zaretskii <eliz@gnu.org>
4813
4814 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4815 attributes are tested _before_ calling verify_row_hash, to protect
4816 against GCC re-ordering of the tests. (Bug#10164)
4817
2b56b87e
JD
48182011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4819
4820 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4821
4822 * xterm.c (handle_one_xevent): Only set async_visible and friends
4823 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4824 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4825 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4826
dbf31225
PE
48272011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4828
4829 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4830 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4831 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4832 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4833 All uses changed to use GCPRO1 etc.
4834 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4835 Revert to old implementation (i.e., before 2011-03-11).
4836
1305621b
YM
48372011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4838
4839 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4840 of scroll runs so as to avoid assigning disabled bogus rows and
4841 unnecessary graphics copy operations.
4842
8c9afb46
EZ
48432011-11-27 Eli Zaretskii <eliz@gnu.org>
4844
4845 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4846 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4847 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4848 (malloc, free, realloc, calloc): Redirect to e_* only when
4849 compiling Emacs.
4850
4851 * lisp.h (GCTYPEBITS): Move before first use.
4852 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4853 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4854 this macro definition.
4855
4856 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4857 _MSC_VER.
4858
54e9e3bf
JD
48592011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4860
6d5eb5b0
SM
4861 * gtkutil.c (xg_create_frame_widgets):
4862 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4863 present with Gtk+ 2.0.
4864
83aca1cb
PE
48652011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4866
4867 * fileio.c (Finsert_file_contents): Undo previous change; see
4868 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4869
5b76caa4
PE
48702011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4871
4872 Rename locals to avoid shadowing.
4873 * fileio.c (Finsert_file_contents):
4874 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4875 * process.c (wait_reading_process_output):
4876 Rename inner 'proc' to 'p' to avoid shadowing.
4877 Indent for consistency with usual Emacs style.
4878
8c535114
EZ
48792011-11-25 Eli Zaretskii <eliz@gnu.org>
4880
4881 * xdisp.c (redisplay_window): If cursor row is not fully visible
4882 after recentering, and scroll-conservatively is set to a large
4883 number, scroll window by a few more lines to make the cursor fully
4884 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4885 (start_display): Don't move to the next line if the display should
4886 start at a newline that is part of a display vector or an overlay
4887 string. (Bug#10119)
8c535114 4888
fa4fdb5c
JL
48892011-11-24 Juri Linkov <juri@jurta.org>
4890
4891 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4892 after the `MagickPingImage' call. (Bug#10112)
4893
90ec88df
CY
48942011-11-23 Chong Yidong <cyd@gnu.org>
4895
4896 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4897
56e2e794
MR
48982011-11-23 Martin Rudalics <rudalics@gmx.at>
4899
4900 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4901 making another buffer current. (Bug#10114)
4902
b6e64c41
GM
49032011-11-23 Glenn Morris <rgm@gnu.org>
4904
4905 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4906
6b21de18
CY
49072011-11-23 Chong Yidong <cyd@gnu.org>
4908
4909 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4910 using it (Bug#5984).
4911
b12cd789
EZ
49122011-11-22 Eli Zaretskii <eliz@gnu.org>
4913
4914 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4915 and header-lines, as they don't have one computed for them.
4916 (Bug#10098)
4917
4918 * .gdbinit (prow): Make displayed values more self-explaining.
4919 Add row's hash code.
4920
261b6fd4
LMI
49212011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4922
4923 * process.c (wait_reading_process_output): Fix asynchrounous
4924 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4925 (wait_reading_process_output): Add comment and URL.
261b6fd4 4926
e7cfd277
JD
49272011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4928
4929 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4930
a9b9b7f5
CY
49312011-11-21 Chong Yidong <cyd@gnu.org>
4932
4933 * window.c (Fnext_window, Fprevious_window): Doc fix.
4934
b0d15b4f
SM
49352011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4936
4937 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4938
fe7a3057
JB
49392011-11-20 Juanma Barranquero <lekktu@gmail.com>
4940
4941 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4942
d2999b1a
MR
49432011-11-20 Martin Rudalics <rudalics@gmx.at>
4944
4945 * window.c (Fset_window_combination_limit): Rename argument
4946 STATUS to LIMIT.
4947 (Vwindow_combination_limit): Remove "status" from doc-string.
4948
d5ff9cd0
AS
49492011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4950
4951 * m/ibms390.h: Remove.
4952 * m/ibms390x.h: Don't include "ibms390.h".
4953
a5bb9bd3
SM
49542011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4955
4956 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4957 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4958
cd1181db
JB
49592011-11-20 Juanma Barranquero <lekktu@gmail.com>
4960
4961 * casetab.c (Fset_case_table):
4962 * charset.c (Fcharset_after): Fix typos.
4963
615a3b8d 49642011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4965
17e845af
PE
4966 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4967 Otherwise, valgrind does not work on some platforms.
4968 Problem reported by Andreas Schwab in
6a0bf43d
PE
4969 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4970 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4971 is set, removing the need for VIRT_ADDRESS_VARIES.
4972 (PURE_P): Use a more-efficient implementation that needs just one
4973 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4974 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4975 to 4 (xorl, subq, cmpq, setbe).
4976 * alloc.c (pure): Always extern now, since that's the
4977 VIRT_ADDR_VARIES behavior.
4978 (PURE_POINTER_P): Use a single comparison, not two, for
4979 consistency with the new puresize.h.
4980 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4981 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4982 Remove VIRT_ADDR_VARIES no longer needed.
4983
f8fe6f96
EZ
49842011-11-19 Eli Zaretskii <eliz@gnu.org>
4985
4986 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4987 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4988 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4989 behave as if the cursor position were at the window margin.
4990
4991 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4992 and the cursor position is out of bounds, behave as if the cursor
4993 position were at the window margin. (Bug#10075)
4994
df05a53c
CY
49952011-11-18 Chong Yidong <cyd@gnu.org>
4996
4997 * window.c (Fwindow_combination_limit): Make first argument
4998 non-optional, since it is meaningless for live windows like the
4999 selected window.
61ccba97 5000
2071918e
DA
50012011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5002
5003 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5004
b50a28de
SM
50052011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5006
5007 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5008 (graft_intervals_into_buffer): Simplify.
5009
015137db
EZ
50102011-11-18 Eli Zaretskii <eliz@gnu.org>
5011
5012 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5013 hash values of the two rows.
5014 (copy_row_except_pointers): Preserve the used[] arrays and the
5015 hash values of the two rows. (Bug#10035)
68c95424 5016 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5017
5018 * xdisp.c (row_hash): New function, body extracted from
5019 compute_line_metrics.
5020 (compute_line_metrics): Call row_hash, instead of computing the
5021 hash code inline.
5022
5023 * dispnew.c (verify_row_hash): Call row_hash for computing the
5024 hash code of a row, instead of duplicating code from xdisp.c.
5025
5026 * dispextern.h (row_hash): Add prototype.
5027
a2addb04
TH
50282011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5029
5030 * frame.c (delete_frame): Don't delete the terminal when the last
5031 X frame is closed if emacs is built with GTK toolkit.
5032
df85d315
JB
50332011-11-17 Juanma Barranquero <lekktu@gmail.com>
5034
5035 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5036
a0c2d0ae
MR
50372011-11-17 Martin Rudalics <rudalics@gmx.at>
5038
5039 * window.c (Vwindow_splits): Rename to
5040 Vwindow_combination_resize. Suggested by Juri Linkov.
5041 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5042 of Vwindow_splits.
5043
58179cce
JB
50442011-11-16 Juanma Barranquero <lekktu@gmail.com>
5045
7877f373
JB
5046 * nsfns.m (Fns_font_name):
5047 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5048
b6f67890
MR
50492011-11-16 Martin Rudalics <rudalics@gmx.at>
5050
5051 * window.h (window): Rename slot "nest" to "combination_limit".
5052 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5053 (Fset_window_nest): Rename to Fset_window_combination_limit.
5054 (Vwindow_nest): Rename to Vwindow_combination_limit.
5055 (recombine_windows, make_parent_window, make_window)
5056 (Fsplit_window_internal, saved_window)
5057 (Fset_window_configuration, save_window_save): Rename all
5058 occurrences of window_nest to window_combination_limit.
5059
c7015153
JB
50602011-11-15 Juanma Barranquero <lekktu@gmail.com>
5061
5062 * image.c (imagemagick_load_image): Fix typo.
5063
322ad6ec
EZ
50642011-11-14 Eli Zaretskii <eliz@gnu.org>
5065
5066 * xdisp.c (display_line): Move the call to
5067 highlight_trailing_whitespace before the call to
5068 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5069 faces of all the glyphs to compute ROW's hash value.
5070 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5071
f067b8ec
JB
50722011-11-14 Juanma Barranquero <lekktu@gmail.com>
5073
5074 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5075 just return (bug#10044).
5076
1e5b2111
EZ
50772011-11-12 Eli Zaretskii <eliz@gnu.org>
5078
7ef3cbd5
EZ
5079 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5080 with user-defined heap size. Bump the default size of the temacs
5081 heap to 27MB, to avoid memory warning when running temacs.
5082 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5083
1e5b2111
EZ
5084 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5085 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5086 (verify_row_hash) [XASSERTS]: New function.
5087 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5088 that the hash value of glyph rows is correct.
1e5b2111 5089
89d61221
MR
50902011-11-12 Martin Rudalics <rudalics@gmx.at>
5091
5092 * window.h (window): Remove splits slot.
5093 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5094 (Fdelete_other_windows_internal, make_parent_window)
5095 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5096 (Fset_window_configuration, save_window_save): Don't deal with
5097 split status of windows.
5098 (saved_window): Remove splits slot.
5099 (Vwindow_splits): Rewrite doc-string.
5100
97f18cc8
JD
51012011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5102
5103 * xfns.c (unwind_create_frame):
5104 * nsfns.m (unwind_create_frame):
5105 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5106 Vframe_list (Bug#9999).
5107
22a648b4
DA
51082011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5109
0b381c7e 5110 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5111
659afede
KH
51122011-11-11 Kenichi Handa <handa@m17n.org>
5113
5114 * callproc.c (Fcall_process): Set the member dst_multibyte of
5115 process_coding.
5116
9ac0394b
KH
51172011-11-11 Johan Bockgård <bojohan@gnu.org>
5118
5119 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5120 avoid a crash (bug#9496).
5121
2fbdc249
CY
51222011-11-09 Chong Yidong <cyd@gnu.org>
5123
5124 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5125 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5126
ac6b1f81
PE
51272011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5128
5129 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5130
09db192c
PE
51312011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5132
5133 Avoid some portability problems by eschewing 'extern inline' functions.
5134 The trivial performance wins aren't worth the portability hassles; see
5135 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5136 et seq.
5137 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5138 (window_box_width, window_box_left, window_box_left_offset)
5139 (window_box_right, window_box_right_offset): Undo previous change,
5140 by removing the "extern"s.
5141 * intervals.c (adjust_intervals_for_insertion)
5142 (adjust_intervals_for_deletion): Undo previous change,
5143 making these static again.
5144 (offset_intervals, temp_set_point_both, temp_set_point)
5145 (copy_intervals_to_string): No longer inline.
5146 * xdisp.c (window_text_bottom_y, window_box_width)
5147 (window_box_height, window_box_left_offset)
5148 (window_box_right_offset, window_box_left, window_box_right)
5149 (window_box): No longer inline.
5150
105216ed
CY
51512011-11-08 Chong Yidong <cyd@gnu.org>
5152
5153 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5154 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5155 Signal an error if not a live window.
105216ed
CY
5156 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5157 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5158
ae9e237f
JB
51592011-11-07 Juanma Barranquero <lekktu@gmail.com>
5160
5161 * lisp.h (syms_of_abbrev): Remove declaration.
5162 Reported by CHENG Gao <chenggao@royau.me>.
5163
c7aa8333
EZ
51642011-11-07 Eli Zaretskii <eliz@gnu.org>
5165
5166 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5167 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5168 of temacs in GUI mode.
5169
be7f5545
MR
51702011-11-07 Martin Rudalics <rudalics@gmx.at>
5171
5172 * window.h: Declare delete_all_child_windows instead of
5173 delete_all_subwindows.
5174 * window.c (Fwindow_nest, Fset_window_nest)
5175 (Fset_window_new_total, Fset_window_new_normal)
5176 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5177 (delete_all_subwindows): Rename to delete_all_child_windows.
5178 (Fdelete_other_windows_internal, Fset_window_configuration):
5179 Call delete_all_child_windows instead of delete_all_subwindows.
5180 * frame.c (delete_frame): Call delete_all_child_windows instead
5181 of delete_all_subwindows.
5182
ca78dc43
PE
51832011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5184
5185 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5186 This is also needed for porting to any host where GC_MARK_STACK is
5187 not GC_MAKE_GCPROS_NOOPS.
5188 (which_symbols): Use it.
5189
a0241d01
KH
51902011-11-07 Kenichi Handa <handa@m17n.org>
5191
5192 * coding.c (coding_set_destination): Check coding->src_pos only
5193 when coding->src_object is a buffer (bug#9910).
5194
5195 * process.c (send_process): Set the member src_multibyte of coding
5196 to 0 (bug#9911) when sending a unibyte text.
5197
5198 * callproc.c (Fcall_process): Set the member src_multibyte of
5199 process_coding to 0 (bug#9912).
5200
a64bfdfa 52012011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5202
5203 * xmenu.c (cleanup_widget_value_tree): New function.
5204 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5205 calling free_menubar_widget_value_tree directly (Bug#9830).
5206
cb41b32a
PE
52072011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5208
5209 Fix some portability problems with 'inline'.
5210 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5211 (window_box_width, window_box_left, window_box_left_offset)
5212 (window_box_right, window_box_right_offset): Declare extern.
5213 Otherwise, these inline functions do not conform to C99 and
5214 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5215 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5216 * intervals.c (adjust_intervals_for_insertion)
5217 (adjust_intervals_for_deletion): Now extern, because otherwise the
5218 extern inline functions 'offset_intervals' couldn't refer to it.
5219 (static_offset_intervals): Remove.
5220 (offset_intervals): Rewrite using the old contents of
5221 static_offset_intervals. The old version didn't conform to C99
5222 because an extern inline function contained a reference to an
5223 identifier with static linkage.
5224
b7041366
AS
52252011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5226
5227 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5228 GC.
5229
88a37c4d
EZ
52302011-11-06 Eli Zaretskii <eliz@gnu.org>
5231
5232 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5233 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5234 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5235 return Qleft_to_right.
5236
49745b39
CY
52372011-11-06 Chong Yidong <cyd@gnu.org>
5238
5239 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5240 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5241 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5242 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5243 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5244 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5245 (Fwindow_vscroll): Doc fix.
5246 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5247 argument, since it makes no sense to pass a live window and for
5248 consistency with window-child.
5249
1f05cd82
CS
52502011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5251
5252 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5253 support MSVC.
5254
22610910
JR
52552011-11-05 Jason Rumney <jasonr@gnu.org>
5256
5257 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5258 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5259 fonts (Bug#6029).
5260 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5261 bitwise arithmetic preventing use of unicode-sip and non-truetype
5262 opentype fonts.
5263
a06776b2
EZ
52642011-11-05 Eli Zaretskii <eliz@gnu.org>
5265
3ad924ba
EZ
5266 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5267 "emacs"-only part.
5268
a06776b2
EZ
5269 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5270 initialization code to keep similarity to xfns.c after changes
5271 from 2011-11-05.
5272
c9e7db78
JD
52732011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5274
a97f8f3f
JD
5275 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5276 (unwind_create_frame): New function (Bug#9943).
5277 (Fx_create_frame): Restructure code to be more similar to the one in
5278 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5279 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5280 Move terminal->reference_count++ just before making the frame official
5281 (Bug#9943).
5282
5283 * nsterm.m (x_free_frame_resources): New function.
5284 (x_destroy_window): Move code to x_free_frame_resources.
5285
c9e7db78 5286 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5287 (Fx_create_frame, x_create_tip_frame):
5288 Move terminal->reference_count++ just before making the frame
75f1671a 5289 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5290 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5291
a6fc3b5c
EZ
52922011-11-05 Eli Zaretskii <eliz@gnu.org>
5293
5294 Support MSVC build with newer versions of Visual Studio.
5295 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5296 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5297 nt/gmake.defs.
5298
5299 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5300 which are not supported by MSVC.
5301 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5302 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5303 bitfields.
5304 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5305 types in bitfields.
5306 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5307
5308 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5309
58179cce 53102011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5311
5312 Support MSVC build with newer versions of Visual Studio.
5313 * w32.c: Don't include w32api.h for MSVC.
5314 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5315
5316 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5317 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5318 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5319 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5320 e_* cousins.
5321 (alloca) [_MSC_VER]: Define to _alloca.
5322
5323 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5324
5325 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5326
a58c13ed
EZ
53272011-11-04 Eli Zaretskii <eliz@gnu.org>
5328
5329 * xdisp.c (note_mouse_highlight): If either of
5330 previous/next-single-property-change returns nil, treat that as
5331 the beginning or the end of the buffer. (Bug#9955)
5332
fe0b6370
JD
53332011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5334
a58c13ed 5335 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5336 label is not null (Bug#9951).
5337 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5338 may be NULL.
5339
89bd5ee1
EZ
53402011-11-04 Eli Zaretskii <eliz@gnu.org>
5341
5342 * window.c (Fwindow_body_size): Mention in the doc string that the
5343 return value is in frame's canonical units. (Bug#9949)
5344
84c3edb9
EZ
53452011-11-03 Eli Zaretskii <eliz@gnu.org>
5346
4e2fb5c7
EZ
5347 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5348
84c3edb9 5349 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5350 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5351 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5352
bc17a887
EZ
53532011-11-01 Eli Zaretskii <eliz@gnu.org>
5354
5355 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5356 Don't stop backward scan on the continuation glyph, even though
5357 its CHARPOS is positive.
6d5eb5b0
SM
5358 (mouse_face_from_buffer_pos, note_mouse_highlight):
5359 Rename cover_string to disp_string.
bc17a887 5360
4ee88440
MR
53612011-11-01 Martin Rudalics <rudalics@gmx.at>
5362
5363 * window.c (temp_output_buffer_show): Don't use
5364 Vtemp_buffer_show_specifiers.
5365 (Vtemp_buffer_show_specifiers): Remove unused variable.
5366
c2ff3c02
EZ
53672011-10-30 Eli Zaretskii <eliz@gnu.org>
5368
5369 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5370 past the beginning of the current glyph matrix.
5371
58179cce 53722011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5373
5374 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5375 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5376 HAVE_GTK3 (Bug#9869).
b77a6a7f 5377
3b574623
JD
5378 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5379 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5380
b77a6a7f
JD
5381 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5382
5383 * xterm.c: Declare x_handle_net_wm_state to return int.
5384 (handle_one_xevent): Check if we are iconified but don't have
5385 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5386 (get_current_wm_state): Return non-zero if not hidden,
5387 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5388 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5389 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5390 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5391
196e41e4
PE
53922011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5393
5394 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5395 so that this new function doesn't get optimized away by a
5396 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5397
021f2e1a
AS
53982011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5399
5400 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5401
8b058d44
EZ
54022011-10-29 Eli Zaretskii <eliz@gnu.org>
5403
5404 Fix the `xbytecode' command.
5405 * .gdbinit (xprintbytestr): New command.
b50a28de 5406 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5407 (xbytecode): Print the byte-code string as well.
5408
4452fb80
EZ
54092011-10-29 Kim Storm <storm@cua.dk>
5410
8b058d44
EZ
5411 * alloc.c (which_symbols): New function.
5412
21b72067
AS
54132011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5414
5415 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5416 line. (Bug#9903)
5417
83ed7b5c
GM
54182011-10-29 Glenn Morris <rgm@gnu.org>
5419
5420 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5421 Not clear what it was for, and it causes various bugs. (Bug#9839)
5422
5a7a728b
EZ
54232011-10-28 Eli Zaretskii <eliz@gnu.org>
5424
5425 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5426 possible random value that matches one of those tested as
5427 condition to clear the mouse face.
5428
d3d0842f
CY
54292011-10-28 Chong Yidong <cyd@gnu.org>
5430
5431 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5432
31b39d13
DN
54332011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5434
5435 * window.c (make_window): Initialize phys_cursor_on_p.
5436
9aba6043
SM
54372011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5438
5439 * lisp.h (struct Lisp_Symbol): Update comments.
5440
c20992f4
JB
54412011-10-28 Juanma Barranquero <lekktu@gmail.com>
5442
5443 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5444
db4f02f2
EZ
54452011-10-28 Eli Zaretskii <eliz@gnu.org>
5446
5447 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5448 <oslsachem@gmail.com> for helping to debug this.
5449
5450 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5451 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5452 (g_b_init_get_glyph_outline_w): New static variables.
5453 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5454 (GetGlyphOutlineW_Proc): New typedefs.
5455 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5456 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5457 New functions.
5458 (w32font_open_internal, compute_metrics):
5459 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5460 instead of calling the "wide" APIs directly.
5461
5462 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5463
5464 * w32.h (syms_of_w32font): Add prototype.
5465
87e68db4
JB
54662011-10-27 Juanma Barranquero <lekktu@gmail.com>
5467
5468 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5469 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5470 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5471 (Fmove_to_window_line): Doc fix.
5472
435c1d67
CY
54732011-10-27 Chong Yidong <cyd@gnu.org>
5474
5475 * process.c (make_process): Set gnutls_state to NULL.
5476
5477 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5478 non-NULL, regardless of GNUTLS_INITSTAGE.
5479 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5480 an error. Set process slots as soon as we allocate them.
5481
5482 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5483
9c6c6f49
CY
54842011-10-27 Chong Yidong <cyd@gnu.org>
5485
9aba6043
SM
5486 * gnutls.c (emacs_gnutls_deinit): New function.
5487 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5488 (Fgnutls_deinit, Fgnutls_boot): Use it.
5489
5490 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5491 (deactivate_process): Call emacs_gnutls_deinit.
5492
657d08d3
JB
54932011-10-27 Juanma Barranquero <lekktu@gmail.com>
5494
5495 * image.c (x_create_x_image_and_pixmap):
5496 * w32.c (sys_rename, w32_delayed_load):
5497 * w32font.c (fill_in_logfont):
5498 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5499
5430d399
JB
55002011-10-26 Juanma Barranquero <lekktu@gmail.com>
5501
5502 * w32fns.c (w32_default_color_map): New function,
5503 extracted from Fw32_default_color_map.
a7ef684b 5504 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5505
fe0055fa
PE
55062011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5507
5508 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5509
e6346438
SM
55102011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5511
5512 * keyboard.c (test_undefined): New function (bug#9751).
5513 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5514
e112cc37
ET
55152011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5516
5517 * sysdep.c (init_sys_modes): Fix the check for the controlling
5518 terminal (Bug#6649).
5519
7b5d6677
EZ
55202011-10-20 Eli Zaretskii <eliz@gnu.org>
5521
5522 * dispextern.h (struct bidi_it): New member next_en_type.
5523
5524 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5525 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5526 current character, check also for next_en_type being WEAK_EN.
5527 (bidi_resolve_weak): Don't enter the expensive loop if the current
5528 position is before next_en_pos. Record the bidi type of the first
5529 non-ET, non-BN character we find, in addition to its position.
5530 (bidi_level_of_next_char): Invalidate next_en_type when
5531 next_en_pos is over-stepped.
5532
7da0b018
PE
55332011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5534
5535 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5536 * editfns.c: Rewrite current-time-zone so that it invokes
5537 the equivalent of (format-time-string "%Z") to get the time zone name.
5538 This fixes a bug when the time zone name contains characters that
5539 need converting from the system time locale to Emacs internal format.
5540 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5541 that patch fixed format-time-string to do the conversion, but
5542 I forgot to fix current-time-zone.
5543 (format_time_string): New function, containing most of
5544 what Fformat_time_string used to contain.
5545 (Fformat_time_string): Rewrite in terms of format_time_string.
5546 This doesn't change this function's behavior.
5547 (current-time-zone): Rewrite to use format_time_string.
5548 This fixes the bug reported by Michael Schierl in
5549 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5550 Jason Rumney's 2007-06-07 change worked around this bug, but
5551 didn't fix it.
5552 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5553
8547b010
EZ
55542011-10-19 Eli Zaretskii <eliz@gnu.org>
5555
5556 * xdisp.c (start_display): If the character at POS is displayed
5557 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5558 (try_window_reusing_current_matrix): If a line ends in a display
5559 vector or the next line starts in a display vector, continue
5560 redrawing the window even though the character position of
5561 start_row was reached.
8547b010
EZ
5562 (Bug#9771, part 2)
5563
4e948d15
CY
55642011-10-18 Chong Yidong <cyd@gnu.org>
5565
5566 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5567 with nobreak-char-display too.
5568
4787455f
EZ
55692011-10-18 Eli Zaretskii <eliz@gnu.org>
5570
5571 Fix part 3 of bug#9771.
5572 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5573 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5574 non-neutral characters if the current character is a paragraph
5575 separator (a.k.a. Newline). This avoids running the same
5576 expensive loop twice, once when we consume the preceding newline
5577 and the other time when the line actually needs to be displayed.
5578 Avoid the loop when we see neutrals on the base embedding level
5579 following a character whose directionality is the same as the
5580 paragraph's. This avoids running the expensive loop when a line
5581 ends in a long sequence of neutrals, like control characters.
5582 Add assertion against STRONG_AL type. Slightly rearrange code
5583 that determines the type of a neutral given the first non-neutral
5584 that follows it.
5585 (bidi_level_of_next_char): Set next_en_pos to zero when
5586 invalidating its info.
5587
2c91f553
EZ
55882011-10-17 Eli Zaretskii <eliz@gnu.org>
5589
5590 * xdisp.c (push_display_prop): Determine whether to record string
5591 or buffer position by IT->string, not by IT->method. Allow
5592 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5593 (move_it_vertically_backward): Don't look for character position
5594 immediately after the newline when in a continuation line.
5595 (Bug#9771, part 1)
2c91f553 5596
c7b08b0d
MR
55972011-10-15 Martin Rudalics <rudalics@gmx.at>
5598
5599 * window.c (coordinates_in_window): Rewrite and delabelize
5600 vertical border check. (Bug#5357) (Bug#9618)
5601
6b02f655
SM
56022011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5603
5604 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5605 errors in XSetWindowBorder (bug#9310).
5606
81d40c92
DA
56072011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5608
5609 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5610 avoid crash when xmalloc overrun checking is enabled.
5611
d4172c3b
EZ
56122011-10-13 Eli Zaretskii <eliz@gnu.org>
5613
5614 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5615 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5616 cursor motion with <left> and <right> arrow keys.
5617
5618 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5619 some callers set that themselves.
5620
b00eea75
EZ
56212011-10-12 Eli Zaretskii <eliz@gnu.org>
5622
5623 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5624 display string and the previous row comes from the same string and
5625 is empty. (Bug#9739) (Bug#9738)
5626
8fe012c4
SM
56272011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5628
5629 * doc.c (get_doc_string): Encode file name (bug#9735).
5630
0074aef2
EZ
56312011-10-12 Eli Zaretskii <eliz@gnu.org>
5632
79beb178
EZ
5633 * bidi.c (bidi_level_of_next_char):
5634 * xdisp.c (get_visually_first_element): Remove old incorrect
5635 comments regarding the Unicode Line Separator character.
5636
0074aef2
EZ
5637 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5638
6e4b3fbe
DA
56392011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5640
5641 * alloc.c (Fgc_status): Do not access beyond zombies array
5642 boundary if nzombies > MAX_ZOMBIES.
5643 * alloc.c (dump_zombies): Add missing format specifier.
5644
0324f3af
PE
56452011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5646
b5525cac
PE
5647 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5648 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5649
0324f3af
PE
5650 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5651 Some packages use them to denote characters with modifiers.
5652
e9b5f888
AS
56532011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5654
5655 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5656 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5657 matching a pp-number. Rename parameter var to var1.
5658
127827c0
SM
56592011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5660
5661 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5662
c8fd3bd0
GM
56632011-10-08 Glenn Morris <rgm@gnu.org>
5664
5665 * callint.c (Fcall_interactively): Give a more explicit error for the
5666 'c' case with a non-character input. (Bug#8479)
5667
352ec8ff
EZ
56682011-10-08 Eli Zaretskii <eliz@gnu.org>
5669
03669ccb
EZ
5670 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5671 lines.
7061c986
EZ
5672 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5673 lines that are hscrolled on the left.
03669ccb 5674
352ec8ff
EZ
5675 * dispnew.c (buffer_posn_from_coords): Account for a possible
5676 presence of header-line. (Bug#4426)
5677
a66cfb1c
SM
56782011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5679
6b02f655
SM
5680 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5681 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5682
7c5ee88e
PE
56832011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5684
5685 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5686 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5687 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5688 this makes Emacs dump core during garbage collection on rare
5689 occasions. sizeof is obviously inferior to offsetof here, so
5690 stick with offsetof.
5691 (GC_POINTER_ALIGNMENT): New macro.
5692 (mark_memory): Omit 3rd (offset) arg; caller changed.
5693 Don't assume EMACS_INT alignment is the same as pointer alignment.
5694
df1bbe5b
SM
56952011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5696
5697 * keyboard.c (read_key_sequence_remapped): New var.
5698 (read_key_sequence): Compute remapping in the right buffer.
5699 (command_loop_1): Use read_key_sequence's remapping directly.
5700
51553db6
SM
57012011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5702
32c1fffd
SM
5703 * dired.c (file_name_completion): Don't expand file name.
5704 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5705 before checking file name handler.
5706
51553db6
SM
5707 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5708 they've been requested explicitly (bug#9591).
5709
b6bd1599 57102011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5711
5712 * keymap.c (Fsingle_key_description): Use make_specified_string
5713 instead of build_string to build string from push_key_description.
5714 (Bug#5193)
5715
f701dc2a
PE
57162011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5717
4222c55d
PE
5718 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5719 This fixes a Y2038 bug on 64-bit hosts.
5720 * buffer.c (reset_buffer):
5721 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5722 (Fclear_buffer_auto_save_failure):
5723 Use 0, not -1, to represent an unset failure time, since time_t
5724 might not be signed.
5725
f701dc2a
PE
5726 Remove dependency on glibc malloc internals.
5727 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5728 Move back here from lisp.h, but with their new implementations.
5729 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5730 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5731 * charset.c (charset_table_init): New static var.
5732 (syms_of_charset): Use it instead of xmalloc. This removes a
5733 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5734 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5735 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5736 Move back to alloc.c.
5737 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5738 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5739
9ceebf39
JD
57402011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5741
5742 * nsterm.m (windowDidResize): Call x_set_window_size only when
5743 ns_in_resize is true. Otherwise set pixelwidth/height and
5744 call change_frame_size (Bug#9628).
5745
cb993c58
PE
57462011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5747
3930c88b
PE
5748 Port --enable-checking=all to Fedora 14 x86-64.
5749 * charset.c (syms_of_charset): Also account for glibc malloc's
5750 internal overhead when calculating the initial malloc maximum.
5751
cb993c58
PE
5752 Port --enable-checking=all to Fedora 14 x86.
5753 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5754 Move to lisp.h.
5755 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5756 (overrun_check_realloc, overrun_check_free):
5757 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5758 That way, xmalloc returns a properly-aligned pointer even if
5759 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5760 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5761 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5762 into account when calculating the initial malloc maximum.
5763 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5764 Move here from alloc.c, so that charset.c can use it too.
5765 Properly align; the old code wasn't right for common 32-bit hosts
5766 when configured with --enable-checking=all.
5767 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5768 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5769
31bed486
EZ
57702011-09-29 Eli Zaretskii <eliz@gnu.org>
5771
04c70788 5772 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5773 use EDOM.
5774
fbcaa2f3
EZ
57752011-09-28 Eli Zaretskii <eliz@gnu.org>
5776
5777 * xdisp.c (compute_display_string_end): If there's no display
5778 string at CHARPOS, return -1.
5779
5780 * bidi.c (bidi_fetch_char): When compute_display_string_end
5781 returns a negative value, treat the character as a normal
5782 character not covered by a display string. (Bug#9624)
5783
a239d4e9
JB
57842011-09-28 Juanma Barranquero <lekktu@gmail.com>
5785
5786 * lread.c (Fread_from_string): Fix typo in docstring.
5787
88652fd5
EZ
57882011-09-27 Eli Zaretskii <eliz@gnu.org>
5789
5790 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5791 newline, reseat the iterator instead of bidi-iterating there one
5792 character at a time. (Bug#9610)
32c1fffd
SM
5793 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5794 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5795
ed497dd4
AS
57962011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5797
5798 * lread.c (readevalloop): Use correct code for NBSP.
5799 (read1): Likewise. (Bug#9608)
5800
b2bf61aa
MA
58012011-09-25 Michael Albinus <michael.albinus@gmx.de>
5802
5803 * dbusbind.c (Fdbus_register_signal): When service is not
5804 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5805
32bbb17c
GM
58062011-09-25 Glenn Morris <rgm@gnu.org>
5807
5808 * buffer.c (truncate-lines): Doc fix.
5809
94e0933e
CY
58102011-09-24 Chong Yidong <cyd@stupidchicken.com>
5811
5812 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5813 (Fset_window_next_buffers): Doc fix.
5814
cddde921
GM
58152011-09-24 Glenn Morris <rgm@gnu.org>
5816
5817 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5818
1260aef1
PE
58192011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5820
25b4bfa0
PE
5821 Fix minor problems found by static checking.
5822 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5823 * indent.c (Fvertical_motion): Fix == vs = typo.
5824
e3cbd34b
EZ
58252011-09-24 Eli Zaretskii <eliz@gnu.org>
5826
a66cfb1c
SM
5827 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5828 Default value is now t. Doc fix.
6bf7006f 5829
e3cbd34b 5830 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5831 logic when moving up, not only when moving down. Fix the
e3cbd34b 5832 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5833 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5834
5835 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5836 CHARPOS is covered by a display string which includes newlines.
5837 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5838 is covered by a display string with embedded newlines.
5839
a3de0cbd
MA
58402011-09-24 Michael Albinus <michael.albinus@gmx.de>
5841
5842 * dbusbind.c (Fdbus_register_signal): Add match rule to
5843 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5844 (Fdbus_register_method, Vdbus_registered_objects_table):
5845 Fix docstring.
a3de0cbd 5846
b260039d
JM
58472011-09-24 Jim Meyering <meyering@redhat.com>
5848
32c1fffd 5849 do not ignore write error for any output size
b260039d
JM
5850 The previous change was incomplete.
5851 While it makes emacs --batch detect the vast majority of stdout
5852 write failures, errors were still ignored whenever the output size is
5853 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5854 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5855 && echo FAIL: ignored write error
5856 FAIL: ignored write error
5857 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5858 && echo FAIL: ignored write error
5859 FAIL: ignored write error
5860 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5861
8eca8a7c
AS
58622011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5863
5864 * emacs.c (Fkill_emacs): In noninteractive mode exit
5865 non-successfully if a write error occurred on stdout. (Bug#9574)
5866
3341db62
EZ
58672011-09-21 Eli Zaretskii <eliz@gnu.org>
5868
5869 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5870 the xassert test.
5871
5872 * dispextern.h (struct it): Update the comment documenting what
5873 can it->OBJECT be.
5874
8c203dbf
EZ
58752011-09-20 Eli Zaretskii <eliz@gnu.org>
5876
5877 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5878 a display string, extend search for cursor position to end of row.
5879 (find_row_edges): If the row ends in a newline from a display
5880 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5881 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5882 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5883 non-empty line. Fixes confusing cursor motion with arrow keys at
5884 the beginning of a line that starts with whitespace.
8c203dbf 5885
a4824228
LMI
58862011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5887
5888 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5889 (bug#9493).
5890
33ed493b
CY
58912011-09-18 Chong Yidong <cyd@stupidchicken.com>
5892
5893 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5894 boolean (Bug#9154).
5895
56cd55c8
EZ
58962011-09-18 Eli Zaretskii <eliz@gnu.org>
5897
5898 * xdisp.c (display_line): Record maximum and minimum buffer
5899 positions even if no glyphs were produced (e.g., by a zero-width
5900 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5901 buffer positions that will be removed from the glyph row because
5902 they don't fit.
c02dcedf
EZ
5903 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5904 column is beyond frame width: don't subtract 1 "pixel" when
5905 computing width of the stretch.
3e62b7e0
EZ
5906 (reseat_at_next_visible_line_start): Undo the change made on
5907 2011-09-17 that saved paragraph information and restored it after
5908 the call to `reseat'. (Bug#9545)
56cd55c8 5909
5ed99d36 59102011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5911
5912 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5913 and turn window cursor on if cleared (Bug#9415).
5914
5ed99d36 59152011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5916
5917 * search.c (boyer_moore): Take unibyte characters from pattern
5918 literally. (Bug#9458)
5919
9bade7b2
EZ
59202011-09-18 Eli Zaretskii <eliz@gnu.org>
5921
5922 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5923
e5e9d610
PE
59242011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5925
87e4427a
PE
5926 Fix minor problem found by static checking.
5927 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5928 initialized, to pacify gcc -Wuninitialized.
5929
e5e9d610
PE
5930 * fileio.c: Report proper errno when syscall falls.
5931 (Finsert_file_contents): Save and restore errno,
5932 so that report_file_error outputs the correct diagnostic.
5933 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5934
a1674f0b
EZ
59352011-09-18 Eli Zaretskii <eliz@gnu.org>
5936
5937 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5938
fbfb6dd4
EZ
59392011-09-17 Eli Zaretskii <eliz@gnu.org>
5940
5941 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5942 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5943
bb187662
EZ
59442011-09-17 Eli Zaretskii <eliz@gnu.org>
5945
1137e8b8 5946 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5947 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5948
5949 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5950 (bidi_find_paragraph_start): Search back for paragraph beginning
5951 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5952 (bidi_move_to_visually_next): Only trigger paragraph-related
5953 computations when the last character is a newline or at EOB, not
5954 just any NEUTRAL_B. (Bug#9470)
5955
bb187662
EZ
5956 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5957 truncated lines if point is covered by a display string. (Bug#9524)
5958
2e621251
PE
59592011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5960
5961 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5962 (cons_to_x_long): New function.
5963 (lisp_data_to_selection_data): Use it. Correct the test for
5964 short-versus-long data; it was negated. Break out of vector
5965 loop, for efficiency, when a long datum is discovered.
5966
91a15bc6
SM
59672011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5968
5969 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5970
b41c3a35
EZ
59712011-09-16 Eli Zaretskii <eliz@gnu.org>
5972
5973 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5974 GCC PR/17406) by declaring this function with external scope.
5975
7812ba2d
PE
59762011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5977
5978 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5979 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5980
cf7edc2a
AS
59812011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5982
5983 * editfns.c (Fformat): Correctly handle text properties on "%%".
5984
bd01620e
EZ
59852011-09-15 Eli Zaretskii <eliz@gnu.org>
5986
5987 * xterm.c (x_draw_composite_glyph_string_foreground):
5988 * w32term.c (x_draw_composite_glyph_string_foreground):
5989 * term.c (encode_terminal_code):
5990 * composite.c (composition_update_it, get_composition_id):
5991 * xdisp.c (get_next_display_element)
5992 (fill_composite_glyph_string): Add comments about special meaning
5993 of TAB characters in a composition.
5994
a02719a3
PE
59952011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5996
5997 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5998 This occurs when processing a multibyte format.
5999 Problem reported by Wolfgang Jenker.
a02719a3 6000
72589a3c
JB
60012011-09-15 Johan Bockgård <bojohan@gnu.org>
6002
6003 * xdisp.c (try_cursor_movement): Only check for exact match if
6004 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6005
1c14176c
PE
60062011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6007
6008 Remove unused external symbols.
6009 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6010 * xdisp.c (calc_pixel_width_or_height): Now static.
6011 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6012 * indent.c (check_display_width):
6013 * w32term.c: Fix comment to match code.
6014 * xterm.c, xterm.h (x_catching_errors): Remove.
6015
d2eea5b5
PE
60162011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6017
6018 * xselect.c: Use signed conversions more consistently (Bug#9498).
6019 (selection_data_to_lisp_data): Assume incoming selection data are
6020 signed integers, not unsigned. This is to be consistent with
6021 outgoing selection data, which was modified to use signed integers
6022 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6023 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6024 expects long, not unsigned long.
6025
46888499
EZ
60262011-09-14 Eli Zaretskii <eliz@gnu.org>
6027
6028 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6029 computation of loop end. Reported by Johan Bockgård
6030 <bojohan@gnu.org>.
6031
ef8ef9fb
CY
60322011-09-13 Chong Yidong <cyd@stupidchicken.com>
6033
6034 * frame.c (Fother_visible_frames_p): Function deleted.
6035
fa819fed
EZ
60362011-09-12 Eli Zaretskii <eliz@gnu.org>
6037
6038 * indent.c (compute_motion): Process display vector front to back
6039 rather than the other way around. (Bug#2496)
6040
2ba8e008
SM
60412011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6042
6043 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6044
20f53c69
CY
60452011-09-11 Chong Yidong <cyd@stupidchicken.com>
6046
6047 * minibuf.c (Fread_from_minibuffer): Doc fix.
6048
d562d7a4
EZ
60492011-09-11 Eli Zaretskii <eliz@gnu.org>
6050
6051 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6052 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6053
1c4d7f3d
LMI
60542011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6055
6056 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6057 value for non-existent files.
6058
b885bf36
EZ
60592011-09-11 Eli Zaretskii <eliz@gnu.org>
6060
6061 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6062 set its "size" to -1. This will set the modtime_size field of
6063 the corresponding buffer to -1, which is what
6064 verify-visited-file-modtime expects for files that do not exist.
6065 (Bug#9139)
6066
6612f0bf
PE
60672011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6068
6069 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6070 here ...
6071 * lisp.h: ... from here. push_key_description is no longer
6072 defined in keyboard.c, so its declaration should not be in
6073 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6074 logically belongs with push_key_description.
6075
dfb3f755
PE
60762011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6077
6078 * buffer.h: Include <sys/types.h> instead of <time.h>.
6079 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6080 Problem reported by Herbert J. Skuhra.
6081
3134906c
LMI
60822011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6083
6084 * xml.c (parse_region): Make the parsing work for
6085 non-comment-starting XML files again (bug#9144).
6086
8d903f4e
AS
60872011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6088
6089 * image.c (gif_load): Fix calculation of bottom and right corner.
6090 (Bug#9468)
6091
80ad64f4
EZ
60922011-09-10 Eli Zaretskii <eliz@gnu.org>
6093
6094 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6095 redisplay in small windows.
6096
208a048d
EZ
60972011-09-09 Eli Zaretskii <eliz@gnu.org>
6098
6099 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6100
9b1c252e
MR
61012011-09-08 Martin Rudalics <rudalics@gmx.at>
6102
6103 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6104 Operate on live windows only.
6105
2949f33b
JB
61062011-09-08 Juanma Barranquero <lekktu@gmail.com>
6107
6108 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6109
e08dcafd
EZ
61102011-09-07 Eli Zaretskii <eliz@gnu.org>
6111
6112 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6113 only under bidi iteration.
6114
115b96bd
JD
61152011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6116
6117 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6118
c8199d0f
PE
61192011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6120
6121 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6122 Without this fix, the command to link temacs failed due to an
6123 undefined symbol __builtin_isnan. This is because
6124 /usr/include/iso/math_c99.h #defines isnan(x) to
6125 __builtin_isnan(x), but the bundled gcc, which identifies itself
6126 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6127 a __builtin_isnan.
6128 * floatfns.c (isnan): #undef, and then #define to a clone of
6129 what's in data.c.
6130 (Fisnan): Always define, since it's always available now.
6131 (syms_of_floatfns): Always define isnan at the Lisp level.
6132
e39b275c 61332011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6134
6135 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6136
b2db44d9 61372011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6138
f4af5137 6139 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6140 The previous code assumed that file offsets (off_t values) fit in
6141 EMACS_INT variables, which is not true on typical 32-bit hosts.
6142 The code messed up by falsely reporting buffer overflow in cases
6143 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6144 when "big" contains more than 2**29 bytes, even though this
6145 inserts just one byte and does not overflow the buffer.
6146 (Finsert_file_contents): Store file offsets as off_t
6147 values, not as EMACS_INT values. Check for overflow when
6148 converting between EMACS_INT and off_t. When checking for
6149 buffer overflow or for overlap, take the offsets into account.
6150 Don't use EMACS_INT for small values where int suffices.
6151 When checking for overlap, fix a typo: ZV was used where
6152 ZV_BYTE was intended.
6153 (Fwrite_region): Don't assume off_t fits into 'long'.
6154 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6155
ecfc0a49
MA
61562011-09-05 Michael Albinus <michael.albinus@gmx.de>
6157
6158 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6159
6511acf2 61602011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6161
0999621a 6162 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6163
6164 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6165 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6166 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6167 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6168 (modify_event_symbol): Do not assume that the length of
6169 name_alist_or_stem is safe to alloca and fits in int.
6170 (Fexecute_extended_command): Likewise for function name and binding.
6171 (Frecursion_depth): Wrap around reliably on integer overflow.
6172 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6173 since some callers pass EMACS_INT values.
6174 (Fsingle_key_description): Don't crash if symbol name contains more
6175 than MAX_ALLOCA bytes.
6176 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6177 (get_minibuffer): Arg is now EMACS_INT, not int.
6178 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6179 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6180 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6181
2be7d702
PE
6182 * dbusbind.c (signature_cat): New function.
6183 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6184 Do not overrun buffer; instead, report string overflow.
6185
9d1df220
PE
6186 * dispnew.c (add_window_display_history): Don't overrun buffer.
6187 Truncate instead; this is OK since it's just a log.
6188
33ef5c64
PE
6189 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6190 even if the time zone offset is outlandishly large.
6191 Don't mishandle offset == INT_MIN.
6192
66c6fdd5
PE
6193 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6194 when creating daemon; the previous buffer-overflow check was incorrect.
6195
d749b01b
PE
6196 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6197 which has the guts of the old verror function.
6198
b5cd1905
PE
6199 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6200 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6201
6e1a67fb
PE
6202 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6203 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6204 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6205 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6206 length of string rather than counting it via multiple sprintfs;
6207 that's simpler and more reliable.
c21721cc
PE
6208 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6209 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6210 sprintf, in case result does not fit in int.
6211
c57b67fc
PE
6212 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6213 (fontset_from_font): Print it.
6214
8a401434
PE
6215 * frame.c (tty_frame_count): Now printmax_t, not int.
6216 (make_terminal_frame, set_term_frame_name): Print it.
6217 (x_report_frame_params): In X, window IDs are unsigned long,
6218 not signed long, so print them as unsigned.
6219 (validate_x_resource_name): Check for implausibly long names,
6220 and don't assume name length fits in 'int'.
6221 (x_get_resource_string): Don't blindly alloca invocation name;
6222 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6223 not fit in int.
6224
6e1a67fb
PE
6225 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6226 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6227 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6228
0df02bf3
PE
6229 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6230 Use esprintf, not sprintf, in case result does not fit in int.
6231
48e30793
PE
6232 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6233 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6234 it as a large positive number.
6235 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6236 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6237
a66ff6d8
PE
6238 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6239 in case result does not fit in int.
6240
aca216ff
PE
6241 * print.c (float_to_string): Detect width overflow more reliably.
6242 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6243 buffer overrun. Don't assume list length fits in 'int'. Treat
6244 print length of 0 as 0, not as infinity; to be consistent with other
6245 uses of print length in this function. Don't overflow print length
6246 index. Don't assume hash table size fits in 'long', or that
6247 vectorlike size fits in 'unsigned long'.
6248
31c286f7
PE
6249 * process.c (make_process): Use printmax_t, not int, to format
6250 process-name gensyms.
6251
55e5faa1
PE
6252 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6253
80f2e268
PE
6254 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6255 to avoid potential buffer overrun.
6256
670741ab
PE
6257 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6258 if X resource line is longer than 512 bytes.
6259
b7163a50
PE
6260 * xfns.c (x_window): Make sprintf buffer a bit bigger
6261 to avoid potential buffer overrun.
6262
ae58ff1f
PE
6263 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6264
c43c8a6a
PE
6265 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6266
3f8236f4
PE
62672011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6268
53e9fe90 6269 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6270 Without these, Emacs silently mishandles large integers sometimes.
6271 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6272 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6273
6511acf2
PE
6274 * xdisp.c (try_window_id): Check Emacs fixnum range before
6275 converting to 'int'.
806add1d 6276
6511acf2 6277 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6278 Check that an Emacs fixnum is in range before assigning it to 'int'.
6279 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6280 values converted from Emacs fixnums.
6281 (Frecenter): Don't wrap around a line count if it is out of 'int'
6282 range; instead, treat it as an extreme value.
6283 (Fset_window_configuration, compare_window_configurations):
6284 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6285
6511acf2
PE
6286 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6287 that can exceed INT_MAX. Check that EMACS_INT value is in range
6288 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6289 (match_limit): Don't assume that a fixnum can fit in 'int'.
6290
6511acf2 6291 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6292 exceed INT_MAX.
6293
6511acf2 6294 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6295 (Fvertical_motion): Don't wrap around LINES values that don't fit
6296 in 'int'. Instead, treat them as extreme values. This is good
6297 enough for windows, which can't have more than INT_MAX lines anyway.
6298
fcb901a7
LMI
62992011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6300
0f2f6b6d
LMI
6301 * Require libxml/parser.h to avoid compilation warning.
6302
fcb901a7
LMI
6303 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6304
6305 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6306 since this reportedly can destroy thread storage.
6307
6e20a0d4
CY
63082011-08-30 Chong Yidong <cyd@stupidchicken.com>
6309
6310 * syntax.c (find_defun_start): Update all cache variables if
6311 exiting early (Bug#9401).
6312
148ae00e
EZ
63132011-08-30 Eli Zaretskii <eliz@gnu.org>
6314
f6cfbd8f
EZ
6315 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6316
148ae00e
EZ
6317 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6318 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6319 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6320
6321 * term.c (tty_append_glyph): New function.
6322 (produce_stretch_glyph): Static function and its prototype deleted.
6323
a66cfb1c
SM
6324 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6325 Add prototypes.
148ae00e 6326
c4a07a4c
PE
63272011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6328
6329 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6330 when checking :margin (Bug#9390).
6331 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6332 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6333 so that the name doesn't mislead. All uses changed.
6334
6bc8cd65
JB
63352011-08-28 Johan Bockgård <bojohan@gnu.org>
6336
6337 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6338 set_tty_hooks.
6339
dca4927e
EZ
63402011-08-27 Eli Zaretskii <eliz@gnu.org>
6341
6342 * xdisp.c (move_it_to): Don't bail out early when reaching
6343 position beyond to_charpos, if we are scanning backwards.
6344 (move_it_vertically_backward): When DY == 0, make sure we get to
6345 the first character in the line after the newline.
6346
f2cad773
PE
63472011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6348
6349 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6350 (ccl_driver): Do not generate an out-of-range pointer.
6351 (Fccl_execute_on_string): Remove unnecessary check for
6352 integer overflow, noted by Stefan Monnier in
6353 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6354 Remove a FIXME that didn't need fixing.
6355 Simplify the newly-introduced buffer reallocation code.
6356
0cae2cdb
JB
63572011-08-27 Juanma Barranquero <lekktu@gmail.com>
6358
6359 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6360
5fc295a4 63612011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6362
70c60eb2 6363 Integer and memory overflow issues (Bug#9196).
726e0ab1 6364
d31850da
PE
6365 * doc.c (get_doc_string): Rework so that
6366 get_doc_string_buffer_size is the actual buffer size, rather than
6367 being 1 less than the actual buffer size; this makes xpalloc more
6368 convenient.
6369
a69fbedb
PE
6370 * image.c (x_allocate_bitmap_record, cache_image):
6371 * xselect.c (Fx_register_dnd_atom):
6372 Simplify previous changes by using xpalloc.
6373
fe5c5d37
PE
6374 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6375 since either will do and ptrdiff_t is convenient with xpalloc.
6376
0065d054
PE
6377 * charset.c (charset_table_size)
6378 (struct charset_sort_data.priority): Now ptrdiff_t.
6379 (charset_compare): Don't overflow if priorities differ greatly.
6380 (Fsort_charsets): Don't assume list length fits in int.
6381 Check for size-calculation overflow when allocating sort data.
6382 (syms_of_charset): Allocate an initial charset table that is
6383 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6384
6385 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6386
6387 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6388 The actual value is always <= INT_MAX, and leaving it unsigned made
6389 overflow checking harder.
6390
6391 * dispextern.h (struct glyph_matrix.rows_allocated)
6392 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6393 with xpalloc. The values are still always <= INT_MAX.
6394
6395 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6396
6397 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6398 (SAFE_NALLOCA): New macro.
6399
6400 * region-cache.c (struct boundary.pos, find_cache_boundary)
6401 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6402 (set_cache_region, invalidate_region_cache)
6403 (revalidate_region_cache, know_region_cache, region_cache_forward)
6404 (region_cache_backward, pp_cache):
6405 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6406 so that ptrdiff_t * can be passed to xpalloc.
6407 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6408 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6409 (pp_cache): Don't assume cache_len fits in int.
6410 * region-cache.h: Adjust extern decls to match.
6411
6412 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6413 EMACS_INT, since either will do, for xpalloc.
6414
6415 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6416 (xnmalloc, xnrealloc, xpalloc): New functions.
6417
726e0ab1
PE
6418 * bidi.c (bidi_shelve_header_size): New constant.
6419 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6420 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6421
51f30bc5 6422 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6423 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6424 (overlay_strings):
6425 Don't update size of array until after memory allocation succeeds,
6426 because xmalloc/xrealloc may not return.
0065d054
PE
6427 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6428 now that we have proper integer overflow checking.
6429 (record_overlay_string, overlay_strings): Catch overflows when
6430 calculating size of overlay_str_buf.
726e0ab1 6431
0065d054
PE
6432 * callproc.c (Fcall_process): Check for size overflow when
6433 calculating size of args2.
6434 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6435 Normally we prefer signed values, but sticking with ptrdiff_t would
6436 require adding more-complicated checks.
726e0ab1
PE
6437
6438 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6439 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6440 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6441 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6442
6443 * character.c (Fstring): Check for size-calculation overflow.
6444
6445 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6446 unnecessary integer overflow. Check for size overflow.
6447 (encode_coding_object): Don't update size until xmalloc succeeds.
6448
6449 * composite.c (get_composition_id): Check for overflow in glyph
6450 length calculations.
6451
6452 Integer and memory overflow fixes for display code.
6453 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6454 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6455 (scrolling_window): Check for overflow in size calculations.
6456 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6457 Don't assume glyph table len fits in int.
6458 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6459 (row_table_size): Now ptrdiff_t, not int.
6460 (scrolling_window): Avoid overflow in size calculations.
6461 Don't update size until allocation succeeds.
6462 * fns.c (concat): Check for overflow in size calculations.
6463 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6464 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6465 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6466
6467 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6468 (get_doc_string): Check for size calculation overflow.
6469 Don't update size until allocation succeeds.
6470 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6471 EMACS_INT, where ptrdiff_t will do.
6472 (Fsubstitute_command_keys): Check for string overflow.
6473
6474 * editfns.c (set_time_zone_rule): Don't assume environment length
6475 fits in int.
6476 (message_length): Now ptrdiff_t, not int.
6477 (Fmessage_box): Don't update size until allocation succeeds.
6478 Don't assume message length fits in int.
6479 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6480
0065d054
PE
6481 * emacs.c (main): Do not reallocate argv, since there is a null at
6482 the end that can be overwritten, and this way there's no need to
6483 worry about size-calculation overflow.
6484 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6485
6486 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6487 alloc succeeds.
6488 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6489
6490 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6491 (x_set_scroll_bar_width, x_figure_window_size):
6492 Check for integer overflow.
6493 (x_set_alpha): Do not assume XINT fits in int.
6494
6495 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6496 This is for the members text_lines, text_cols, total_lines, total_cols,
6497 where the system imposes an 'int' limit.
6498
6499 * fringe.c (Fdefine_fringe_bitmap):
6500 Don't update size until alloc works.
6501
6502 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6503 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6504
6505 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6506 Check for size-calculation overflow.
6507 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6508 do, as we prefer signed integers.
6509 (id_to_widget.max_size, id_to_widget.used)
6510 (xg_store_widget_in_map, xg_remove_widget_from_map)
6511 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6512 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6513 Use and return ptrdiff_t, not int.
6514 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6515 * gtkutil.h: Change prototypes to match the above.
6516
6517 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6518 are duplicate now that they've been promoted to lisp.h.
6519 (x_allocate_bitmap_record, x_alloc_image_color)
6520 (make_image_cache, cache_image, xpm_load):
6521 Don't update size until alloc is done.
6522 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6523 (x_detect_edges):
3256efce 6524 Check for size calculation overflow.
726e0ab1
PE
6525 (ct_colors_allocated_max): New constant.
6526 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6527 overflow.
3256efce 6528
726e0ab1
PE
6529 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6530 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6531 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6532 Use ptrdiff_t, not int, to count maps.
6533 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6534 calculations. Don't update size until allocation succeeds.
6535 Redo calculations to avoid overflow.
726e0ab1
PE
6536 * keyboard.h: Change prototypes to match the above.
6537
6538 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6539 to count maps.
6540 (current_minor_maps): Check for size calculation overflow.
6541 * keymap.h: Change prototypes to match the above.
6542
6543 * lread.c (read1, init_obarray): Don't update size until alloc done.
6544
6545 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6546 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6547
726e0ab1
PE
6548 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6549 Now ptrdiff_t, not int.
6550 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6551 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6552
6553 * process.c (Fnetwork_interface_list): Check for overflow
6554 in size calculation.
6555
6556 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6557
6558 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6559 overflow. Don't bother calling xmalloc when xrealloc will do.
6560
6561 * search.c (Freplace_match): Check for size calculation overflow.
6562 (Fset_match_data): Don't assume list lengths fit in 'int'.
6563
6564 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6565 for command line length. Do not attempt to address one before the
6566 beginning of an array, as that's not portable.
6567
6568 * term.c (max_frame_lines): Remove; unused.
6569 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6570 not int.
6571 (encode_terminal_code, calculate_costs): Check for size
6572 calculation overflow.
6573 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6574 table lengths and related sizes. Don't update size until alloc
6575 done. Redo calculations to avoid overflow.
6576 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6577
6578 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6579 subtracting pointers.
6580 (gobble_line): Check for overflow more carefully. Don't update size
6581 until alloc done.
6582
6583 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6584 Don't update size until alloc done.
6585 Redo size calculations to avoid overflow.
6586 Check for size calculation overflow.
0065d054 6587 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6588
6589 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6590 Use ptrdiff_t, not int, for sizes.
6591 (store_mode_line_noprop_char): Don't update size until alloc done.
6592
0065d054
PE
6593 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6594 Use ptrdiff_t, not int, for sizes.
6595 (Finternal_make_lisp_face, cache_face):
6596 Check for size calculation overflow.
6597 (cache_face): Treat size calculation overflows as if they were
6598 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6599
6600 * xfns.c (x_encode_text, x_set_name_internal)
6601 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6602 sizes, since they can exceed INT_MAX in size. Check for size
6603 calculation overflow.
6604
0065d054
PE
6605 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6606 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6607 Don't update size until alloc done.
6608
0065d054 6609 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6610 as sprintf is limited to int lengths.
1d526e2f 6611
252c5ee1
PE
6612 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6613 (X_LONG_MIN): New macros.
864d7ce7
PE
6614 Use them to make the following changes clearer.
6615 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6616 This change doesn't affect the value now, but it may help remind
6617 future maintainers not to raise the value too much later.
6618 (SELECTION_QUANTUM): Remove, replacing with ...
6619 (selection_quantum): ... new function, which avoids overflow.
6620 All uses changed.
6621 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6622 assumption that selection length fits in 'int'.
6623 (x_reply_selection_request, x_handle_selection_request)
6624 (x_get_window_property, receive_incremental_selection)
6625 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6626 (lisp_data_to_selection_data, clean_local_selection_data):
6627 Use ptrdiff_t, not int, to record length of selection.
6628 (x_reply_selection_request, x_get_window_property)
6629 (receive_incremental_selection, x_property_data_to_lisp):
6630 Redo calculations to avoid overflow.
6631 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6632 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6633 something.
6634 (x_get_window_property, receive_incremental_selection)
6635 (lisp_data_to_selection_data, x_property_data_to_lisp):
6636 Check for size-calculation overflow.
6637 (x_get_window_property, receive_incremental_selection)
6638 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6639 Don't store size until memory allocation succeeds.
6640 (x_get_window_property): Plug memory leak on memory exhaustion.
6641 Don't double-block input; malloc is safe here. Don't assume 2**34
6642 - 4 fits in unsigned long. Add an xassert to check
6643 XGetWindowProperty overflow. Be more careful about overflow
6644 calculations, and distinguish size from memory overflow better.
6645 (receive_incremental_selection): When tracing, don't assume
6646 unsigned int is less than INT_MAX.
6647 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6648 harmful) conversions of unsigned short to int.
6649 (lisp_data_to_selection_data): Don't assume that integers
6650 in the range -65535 through -1 fit in an X unsigned short.
6651 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6652 result parameters unless successful. Rely on cons_to_unsigned
6653 to report problems with elements; the old code wasn't right anyway.
6654 (x_check_property_data): Check for int overflow; we cannot use
6655 a wider type due to X limits.
6656 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6657
726e0ab1 6658 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6659
0065d054
PE
6660 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6661 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6662 (x_color_cells): Don't store size until memory allocation succeeds.
6663 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6664 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6665 (x_term_init): Don't assume length fits in int (sprintf is limited
6666 to int size).
bc18e09d 6667
ebfa62c0
PE
6668 Use ptrdiff_t for composition IDs.
6669 * character.c (lisp_string_width):
6670 * composite.c (composition_table_size, n_compositions)
6671 (get_composition_id, composition_gstring_from_id):
6672 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6673 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6674 * window.c (Frecenter):
6675 Use ptrdiff_t, not int, for composition IDs.
6676 * composite.c (get_composition_id): Check for integer overflow.
6677 * composite.h: Adjust prototypes to match the above changes.
6678
d3411f89
PE
6679 Use ptrdiff_t for hash table indexes.
6680 * category.c (hash_get_category_set):
6681 * ccl.c (ccl_driver):
6682 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6683 * coding.c (coding_system_charset_list, detect_coding_system):
6684 * coding.h (struct coding_system.id):
6685 * composite.c (get_composition_id, gstring_lookup_cache):
6686 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6687 * image.c (xpm_get_color_table_h):
6688 * lisp.h (hash_lookup, hash_put):
6689 * minibuf.c (Ftest_completion):
6690 Use ptrdiff_t for hash table indexes, not int (which is too
6691 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6692 32-bit --with-wide-int hosts).
6693
e097a6fa
PE
6694 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6695 Add a FIXME comment about memory leaks.
6696 (syms_of_charset): Don't assume xmalloc returns.
6697
5637687f
PE
6698 Don't assume that stated character widths fit in int.
6699 * character.c (Fchar_width, c_string_width, lisp_string_width):
6700 * character.h (CHAR_WIDTH):
6701 * indent.c (MULTIBYTE_BYTES_WIDTH):
6702 Use sanitize_char_width to avoid undefined and/or bad behavior
6703 with outlandish widths.
a66cfb1c 6704 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6705 now that we have two such functions. All uses changed.
6706 (sanitize_char_width): New inline function.
6707
a2271ba2
PE
6708 Don't assume that tab-width fits in int.
6709 * character.h (sanitize_width): New inline function.
6710 (SANE_TAB_WIDTH): New macro.
6711 (ASCII_CHAR_WIDTH): Use it.
6712 * indent.c (sane_tab_width): Remove. All uses replaced by
6713 SANE_TAB_WIDTH (current_buffer).
6714 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6715
18c52557
PE
6716 * fileio.c: Integer overflow issues with file modes.
6717 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6718
caeeedc1
PE
6719 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6720 Remove unreachable code.
6721 (read_hex, load_charset_map_from_file): Check for integer overflow.
6722
6df6ae42 6723 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6724 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6725 (x_send_scroll_bar_event): Likewise. Check that the size does not
6726 exceed limits imposed by XClientMessageEvent, as well as the usual
6727 ptrdiff_t and size_t limits.
6728
b13995db
PE
6729 * keyboard.c: Overflow, signedness and related fixes.
6730 (make_lispy_movement): Use same integer type in forward decl
6731 that is used in the definition.
6732 (read_key_sequence, keyremap_step):
6733 Change bufsize argument back to int, undoing my 2011-03-30 change.
6734 We prefer signed types, and int is wide enough here.
6735 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6736 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6737 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6738 length, not size_t. Use ptrdiff_t for index, not int.
6739 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6740 possibility of integer overflow.
6741
13464394
PE
6742 Overflow, signedness and related fixes for images.
6743
6744 * dispextern.h (struct it.stack[0].u.image.image_id)
6745 (struct_it.image_id, struct image.id, struct image_cache.size)
6746 (struct image_cache.used, struct image_cache.ref_count):
6747 * gtkutil.c (update_frame_tool_bar):
6748 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6749 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6750 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6751 * nsmenu.m (update_frame_tool_bar):
6752 * xdisp.c (calc_pixel_width_or_height):
6753 * xfns.c (image_cache_refcount):
6754 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6755 on typical 64-bit hosts.
6756
6757 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6758 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6759 Omit unnecessary casts to int.
6760 (parse_image_spec): Check that integers fall into 'int' range
6761 when the callers expect that.
6762 (image_ascent): Redo ascent calculation to avoid int overflow.
6763 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6764 (lookup_image): Remove unnecessary tests.
6765 (xbm_image_p): Locals are now of int, not EMACS_INT,
6766 since parse_image_check makes sure they fit into int.
6767 (png_load, gif_load, svg_load_image):
6768 Prefer int to unsigned where either will do.
6769 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6770 old tiff_error_handler and tiff_warning_handler.
6771 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6772 stack buffer overflows. It uses only the features of vsnprintf
6773 that are common to both POSIX and native Microsoft.
6774 (tiff_error_handler, tiff_warning_handler): Use it.
6775 (tiff_load, gif_load, imagemagick_load_image):
6776 Don't assume :index value fits in 'int'.
6777 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6778 (imagemagick_load_image): Check that crop parameters fit into
6779 the integer types that MagickCropImage accepts. Don't assume
6780 Vimagemagick_render_type has a nonnegative value. Don't assume
6781 size_t fits in 'long'.
6782 (gs_load): Use printmax_t to print the widest integers possible.
6783 Check for integer overflow when computing image height and width.
6784
c11821d4
EZ
67852011-08-26 Eli Zaretskii <eliz@gnu.org>
6786
6787 * xdisp.c (redisplay_window): Don't force window start if point
6788 will be invisible in the resulting window. (Bug#9324)
6789
0c95fcf7
EZ
67902011-08-25 Eli Zaretskii <eliz@gnu.org>
6791
6792 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6793 the display spec is of the form `(space ...)'.
6794 (handle_display_spec): Return the value returned by
6795 handle_single_display_spec, not just 1 or zero.
6796 (handle_single_display_spec): If the display spec is of the form
6797 `(space ...)', and specifies display in the text area, return 2
6798 rather than 1.
fee65a97 6799 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6800 accurately, and prefer exact match for point under bidi.
6801 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6802
6803 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6804 into disp_prop; all users changed.
6805
6806 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6807 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6808 for the text covered by the display property.
6809
e4ed06f1
CY
68102011-08-25 Chong Yidong <cyd@stupidchicken.com>
6811
6812 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6813 Change return value to nil.
6814 (Frecord_buffer): Delete unused function.
6815
f67cdd7f
EZ
68162011-08-24 Eli Zaretskii <eliz@gnu.org>
6817
5980d4c6
EZ
6818 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6819 buffers, return left-to-right.
8610fe8b
EZ
6820 (set_cursor_from_row): Consider candidate row a win if its glyph
6821 represents a newline and point is on that newline. Fixes cursor
6822 positioning on the newline at EOL of R2L text within L2R
6823 paragraph, and vice versa.
6824 (try_cursor_movement): Check continued rows, in addition to
6825 continuation rows. Fixes unwarranted scroll when point enters a
6826 continued line of R2L text within an L2R paragraph, or vice versa.
6827 (cursor_row_p): Consider the case of point being equal to
6828 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6829 from the end of a short line to the beginning of a continued line
6830 of R2L text within L2R paragraph.
6831 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6832 composed characters.
5980d4c6 6833
f67cdd7f
EZ
6834 * bidi.c (bidi_check_type): Use xassert.
6835 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6836 members.
6837
bca633fb
EZ
68382011-08-23 Eli Zaretskii <eliz@gnu.org>
6839
6840 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6841 a character.
6842
4a5885a7
CY
68432011-08-23 Chong Yidong <cyd@stupidchicken.com>
6844
6845 * nsfont.m (ns_otf_to_script): Fix typo.
6846
0902a04e
KH
68472011-08-22 Kenichi Handa <handa@m17n.org>
6848
6849 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6850 extra slot even if the purpose is char-code-property-table.
6851
1a2e6670
EZ
68522011-08-23 Eli Zaretskii <eliz@gnu.org>
6853
8ddde651
EZ
6854 * xdisp.c (redisplay_window): When computing centering_position,
6855 account for the height of the header line. (Bug#8874)
6856
425cc014
EZ
6857 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6858 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6859 candidate is selected by the mouse, and that candidate has a
6860 composed character under the mouse.
6861
1a2e6670
EZ
6862 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6863 coordinates reported by pos-visible-in-window-p for a composed
6864 character in column zero.
6865
8b76d6f8
SM
68662011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6867
6868 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6869
dac347dd
EZ
68702011-08-22 Eli Zaretskii <eliz@gnu.org>
6871
6872 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6873 consider it a hit if to_charpos is anywhere in the range of the
6874 composed buffer positions.
6875
e013fb34
CY
68762011-08-22 Chong Yidong <cyd@stupidchicken.com>
6877
6878 * image.c (gif_load): Don't assume that each subimage has the same
6879 dimensions as the base image. Handle disposal method that is
6880 "undefined" by the gif spec (Bug#9335).
6881
bd1ba3e8
CY
68822011-08-20 Chong Yidong <cyd@stupidchicken.com>
6883
6884 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6885 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6886
54a1215b
EZ
68872011-08-19 Eli Zaretskii <eliz@gnu.org>
6888
823564e5
EZ
6889 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6890 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6891 from an Org mode buffer to a Speedbar frame.
6892
54a1215b
EZ
6893 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6894 a composition, take its buffer position from IT->cmp_it.charpos.
6895 Fixes cursor positioning at the beginning of a line that begins
6896 with a composed character.
6897
9778ebcc
EZ
68982011-08-18 Eli Zaretskii <eliz@gnu.org>
6899
0be6ee06
EZ
6900 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6901 character bidirectional type, use STRONG_L instead. Fixes crashes
6902 in a buffer produced by `describe-categories'.
6903
9778ebcc
EZ
6904 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6905 members before the level stack, so they would be saved and
6906 restored when copying iterator state. Fixes incorrect reordering
6907 around TABs covered by display properties.
6908
156bffbe
AS
69092011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6910
6b02f655 6911 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6912
72ad093b
CY
69132011-08-17 Chong Yidong <cyd@stupidchicken.com>
6914
6915 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6916 (internal_condition_case_2, internal_condition_case_n):
6917 Remove unnecessary aborts (Bug#9081).
72ad093b 6918
35774242
EZ
69192011-08-17 Eli Zaretskii <eliz@gnu.org>
6920
6921 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6922 has no `load' handler, try opening the file locally. (Bug#9311)
6923
db76dd85
KB
69242011-08-16 Ken Brown <kbrown@cornell.edu>
6925
6926 * gmalloc.c: Expand comment.
6927
b215eee5
EZ
69282011-08-16 Eli Zaretskii <eliz@gnu.org>
6929
6930 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6931 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6932
a4579d33
KB
69332011-08-16 Ken Brown <kbrown@cornell.edu>
6934
6935 Fix memory allocation problems in Cygwin build (Bug#9273).
6936
6937 * unexcw.c ( __malloc_initialized): Declare external variable.
6938 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6939
8b76d6f8
SM
6940 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6941 New variables.
a4579d33
KB
6942 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6943 dumped emacs.
6944 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6945 in the static heap.
6946 [CYGWIN] (special_realloc): New function.
6947 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6948 requests to realloc storage in the static heap.
6949
3ebec551
PE
69502011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6951
6952 * bidi.c (bidi_initialize): Remove unused local.
6953
9fd8be00
EZ
69542011-08-15 Eli Zaretskii <eliz@gnu.org>
6955
6b02f655
SM
6956 * bidimirror.h:
6957 * biditype.h: Remove file.
6958 * makefile.w32-in ($(BLD)/bidi.$(O)):
6959 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6960
6961 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6962
6963 * chartab.c: Improve commentary for the uniprop_table API.
6964
32413314
EZ
6965 * bidi.c (bidi_paragraph_init): Support zero value of
6966 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6967 (bidi_initialize): Use uniprop_table instead of including
6968 biditype.h and bidimirror.h.
32413314 6969
9fd8be00
EZ
6970 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6971 coordinates of the iterator when restoring from ppos_it.
6972 (Bug#9296)
6973
5cf2b69b
KH
69742011-08-14 Kenichi Handa <handa@m17n.org>
6975
6976 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6977 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6978
daf17d00
EZ
69792011-08-14 Eli Zaretskii <eliz@gnu.org>
6980
6981 * xdisp.c (move_it_in_display_line_to): Don't invoke
6982 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6983 ppos_it. Fixes vertical cursor motion when line beginning is
6984 covered by an image. (Bug#9296)
6985
08e3161a
JD
69862011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6987
6988 * nsterm.h (ns_run_ascript): Declare.
6989 (NSAPP_DATA2_RUNASSCRIPT): Define.
6990
6991 * nsfns.m (as_script, as_result, as_status): New static variables.
6992 (ns_run_ascript): New function.
5e617bc2 6993 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6994 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6995 the event loop. Get status from as_status (Bug#7276).
6996
6997 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6998 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6999 the event loop (Bug#7276).
7000
a3720aa2
AS
70012011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7002
7003 * gnutls.c (QCgnutls_bootprop_priority)
7004 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7005 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7006 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7007 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7008 (QCgnutls_bootprop_verify_hostname_error)
7009 (QCgnutls_bootprop_callbacks_verify): Rename from
7010 Qgnutls_bootprop_..., all uses changed.
7011
7012 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7013 uses changed.
7014
0a0d27fb
PE
70152011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7016
19d5c50c
PE
7017 * xfaces.c (Qframe_set_background_mode): Now static.
7018 * dispextern.h (Qframe_set_background_mode): Remove decl.
7019
0a0d27fb
PE
7020 * process.c (Fnetwork_interface_info): Declare local only if needed.
7021
377538cb
JD
70222011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7023
7024 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7025 (Fnetwork_interface_list): Allocate in increments of bytes instead
7026 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7027 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7028 sockaddr.
7029 (struct ifflag_def): notrailers is smart on OSX.
7030 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7031 Get hardware address with getifaddrs if available.
7032
08fff70c
EZ
70332011-08-12 Eli Zaretskii <eliz@gnu.org>
7034
7035 * xdisp.c (iterate_out_of_display_property): xassert that
7036 IT->position is set to within IT->object's boundaries. Break from
7037 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7038 when IT->position is set up wrongly due to some bug.
7039 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7040 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7041 entry. Force push_it to save on the stack the current
7042 buffer/string position, to be restored by pop_it. Fix flags in
7043 the iterator structure wrt the object coming from a display
7044 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7045 properties. (Bug#9284)
7046
7be1c708 70472011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7048
7be1c708
CY
7049 * fontset.c (fontset_get_font_group): Add proper type checks.
7050 (Bug#9172)
aac0c6e3 7051
7be1c708 70522011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7053
7be1c708
CY
7054 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7055 and LC_VERSION_MIN_MACOSX.
7056 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7057 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7058
97bb72a6
EZ
70592011-08-08 Eli Zaretskii <eliz@gnu.org>
7060
7061 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7062 no-display-properties-and-no-overlays under bidi display.
7063 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7064 properties and overlays.
97bb72a6 7065
d5617611
CY
70662011-08-08 Chong Yidong <cyd@stupidchicken.com>
7067
37e11a63
CY
7068 * editfns.c (Fset_time_zone_rule): Document relationship with the
7069 setenv function.
7070
d5617611
CY
7071 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7072 the font entity extracted from the cache (Bug#8109).
7073
58872834
CY
70742011-08-07 Chong Yidong <cyd@stupidchicken.com>
7075
7076 * composite.c (autocmp_chars): Don't reset point. That is done by
7077 restore_point_unwind (Bug#5984).
7078
75bfc667
JL
70792011-08-07 Juri Linkov <juri@jurta.org>
7080
7081 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7082 to show the arg `TIME' instead of `TIMEVAL'.
7083
d1410150
EZ
70842011-08-06 Eli Zaretskii <eliz@gnu.org>
7085
7086 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7087 display property strides EOL and includes a newline, as in
7088 longlines-mode. (Bug#9254)
75b771e4
EZ
7089 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7090 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7091
7092 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7093 is non-zero, even if the data buffer is NULL. Fixes a crash in
7094 vertical-motion with longlines-mode. (Bug#9254)
7095
35928349
EZ
70962011-08-05 Eli Zaretskii <eliz@gnu.org>
7097
ec7cc85b
EZ
7098 * bidi.c <bidi_cache_total_alloc>: Now static.
7099 (bidi_initialize): Initialize bidi_cache_total_alloc.
7100
8b76d6f8 7101 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7102 cache. (Bug#9221)
7103
7104 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7105 amount allocated this far in `bidi_cache_total_alloc'.
7106 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7107 non-zero, only free the data buffer without restoring the cache
7108 contents. All callers changed.
7109
7110 * dispextern.h (bidi_unshelve_cache): Update prototype.
7111
7112 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7113 (move_it_in_display_line, move_it_to)
7114 (move_it_vertically_backward, move_it_by_lines): Replace the call
7115 to xfree to an equivalent call to bidi_unshelve_cache.
7116 (move_it_in_display_line_to): Fix logic of returning
412b6358 7117 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7118
e2e2423b
EZ
71192011-08-05 Eli Zaretskii <eliz@gnu.org>
7120
7121 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7122 came from a string character with a `cursor' property. (Bug#9229)
7123
ae9e757a
JD
71242011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7125
7126 * Makefile.in (LIB_PTHREAD): New variable.
7127 (LIBES): Add LIB_PTHREAD (Bug#9216).
7128
7129 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7130 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7131
213bd7f2
AS
71322011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7133
6b02f655 7134 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7135
99aaf75f
JD
71362011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7137
7138 * xterm.c (x_find_topmost_parent): New function.
7139 (x_set_frame_alpha): Find topmost parent window with
7140 x_find_topmost_parent and set the property there also (bug#9181).
7141 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7142
c74e9d86
PE
71432011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7144
7145 * callproc.c (Fcall_process): Avoid vfork clobbering
7146 the local vars buffer, coding_systems, current_dir.
7147
640c8776
SM
71482011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7149
7150 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7151
f26d0e4c
PE
71522011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7153
8a10d76c
PE
7154 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7155 so that it is not optimized away.
7156
f26d0e4c
PE
7157 * xdisp.c (compute_display_string_pos): Remove unused local.
7158
55439c61
EZ
71592011-08-02 Eli Zaretskii <eliz@gnu.org>
7160
7161 Fix slow cursor motion and scrolling in large buffers with
7162 selective display, like Org Mode buffers. (Bug#9218)
7163
7164 * dispextern.h (struct bidi_it): New member disp_prop_p.
7165
7166 * xdisp.c: Remove one-slot cache of display string positions.
7167 (compute_display_string_pos): Accept an additional argument
5e617bc2 7168 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7169 for a display string or property. If found, set DISP_PROP_P
7170 non-zero.
7171
7172 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7173 DISP_PROP_P, and pass it to compute_display_string_pos.
7174 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7175 non-zero. All callers of bidi_fetch_char changed.
7176
fb33fa43
SM
71772011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7178
7179 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7180
b099e063
DM
71812010-12-03 Don March <don@ohspite.net>
7182
7183 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7184 last character M-[char] is translated to ESC [char] (bug#7541).
7185
5cc7f7af
KH
71862011-08-02 Kenichi Handa <handa@m17n.org>
7187
d0fffa3f 7188 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7189
7190 * chartab.c (uniprop_table): Make it non-static.
7191
525d5e6e
EZ
71922011-08-01 Eli Zaretskii <eliz@gnu.org>
7193
7194 * xdisp.c (forward_to_next_line_start): Accept additional argument
7195 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7196 on the newline.
7197 (reseat_at_next_visible_line_start): Use the bidi iterator state
7198 returned by forward_to_next_line_start to restore the state of
7199 it->bidi_it after backing up to previous newline. (Bug#9212)
7200
31011111
AS
72012011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7202
7203 * regex.c (re_comp): Protoize.
7204 (re_exec): Fix return type.
7205 (regexec): Fix type of `ret'. (Bug#9203)
7206
476371c4
PE
72072011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7208
e5d76069
PE
7209 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7210 This is needed if max-image-size is a floating-point number.
7211
9a79b20c
AS
72122011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7213
7214 * print.c (print_object): Print empty symbol as ##.
7215
7216 * lread.c (read1): Read ## as empty symbol.
7217
d8c2fa78
AA
72182011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7219
7220 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7221 setting frame foreground color (Bug#9175).
7222 (x_set_background_color): Likewise.
7223
ffe57a7a
AA
7224 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7225 contents (Bug#9176).
7226 (EmacsTooltip -init): Remove bezels and add shadows to
7227 tooltip windows.
7228
bf3492a5
AA
7229 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7230 or scroll bar (Bug#8470).
7231
d55e9c53
AA
7232 * nsfont.m (nsfont_open): Remove assignment to voffset and
7233 unnecessary vars hshink, expand, hd, full_height, min_height.
7234 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7235
7236 * nsterm.h (nsfont_info): Remove voffset field.
7237
d8c2fa78 72382011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7239
7240 Implement strike-through and overline on NextStep (Bug#8863).
7241
7242 * nsfont.m (nsfont_open): Use underline position provided by font,
7243 instead of hard-coded value of 2.
7244 (nsfont_draw): Call ns_draw_text_decoration instead.
7245
7246 * nsterm.h: Add declaration for ns_draw_text_decoration.
7247
7248 * nsterm.m (ns_draw_text_decoration): New function for drawing
7249 underline, overline, and strike-through.
7250 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7251 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7252 accommodate underlining, etc.
4843aac3 7253
4cc60b9b
EZ
72542011-07-28 Eli Zaretskii <eliz@gnu.org>
7255
bc7ece87
EZ
7256 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7257 default.
4cc60b9b 7258
476371c4
PE
72592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7260
66606eea
PE
7261 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7262 Without this fix, if a signal arrives just after memory fills up,
7263 'malloc' might be invoked reentrantly.
7264
476371c4
PE
7265 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7266 In other words, assume that every image size is allowed, on non-X
7267 hosts. This assumption is probably wrong, but it lets Emacs compile.
7268
f3fcc40d
AS
72692011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7270
7271 * regex.c (re_iswctype): Convert return values to boolean.
7272
350c992f
EZ
72732011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7274
7275 * xdisp.c (compute_display_string_pos): Don't use cached display
7276 string position if the buffer had its restriction changed.
7277 (Bug#9184)
7278
5266b4bb
PE
72792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7280
7281 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7282
2573a837 72832011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7284
41f55ccd 7285 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7286
39e378da
PE
7287 * bidi.c: Integer size and overflow fixes.
7288 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7289 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7290 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7291 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7292 (bidi_find_other_level_edge):
7293 Use ptrdiff_t instead of EMACS_INT where either will do.
7294 This works better on 32-bit hosts configured --with-wide-int.
7295 (bidi_cache_ensure_space): Check for size-calculation overflow.
7296 Use % rather than repeated addition, for better worst-case speed.
7297 Don't set bidi_cache_size until after xrealloc returns, because it
7298 might not return.
7299 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7300 (bidi_cache_ensure_space): Also check that the bidi cache size
7301 does not exceed that of the largest Lisp string or buffer. See Eli
7302 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7303
5e927815
PE
7304 * alloc.c (__malloc_size_t): Remove.
7305 All uses replaced by size_t. See Andreas Schwab's note
7306 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7307
ca4aa935
PE
7308 * image.c: Improve checking for integer overflow.
7309 (check_image_size): Assume that f is nonnull, since
7310 it is always nonnull in practice. This is one less thing to
7311 worry about when checking for integer overflow later.
7312 (x_check_image_size): New function, which checks for integer
7313 overflow issues inside X.
7314 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7315 This removes the need for a memory_full check.
7316 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7317 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7318 (xbm_read_bitmap_data): Change locals back to 'int', since
7319 their values must fit in 'int'.
7320 (xpm_load_image, png_load, tiff_load):
7321 Invoke x_create_x_image_and_pixmap earlier,
7322 to avoid much needless work if the image is too large.
7323 (tiff_load): Treat overly large images as if
7324 x_create_x_image_and_pixmap failed, not as malloc failures.
7325 (gs_load): Use x_check_image_size.
7326
5f8f9cc2
PE
7327 * gtkutil.c: Omit integer casts.
7328 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7329 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7330
5adf60bc
PE
7331 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7332
c8907a93
PE
7333 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7334 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7335 would wrongly return t on a 64-bit host.
7336
e3c25c68
PE
7337 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7338 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7339 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7340 and therefore cause GCC to emit a bogus diagnostic in some cases.
7341
3f791afe
PE
7342 * image.c: Integer signedness and overflow and related fixes.
7343 This is not an exhaustive set of fixes, but it's time to
7344 record what I've got.
7345 (lookup_pixel_color, check_image_size): Remove redundant decls.
7346 (check_image_size): Don't assume that arbitrary EMACS_INT values
7347 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7348 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7349 (tiff_load, imagemagick_load_image):
7350 Check for overflow in size calculations.
7351 (x_create_x_image_and_pixmap): Remove unnecessary test for
7352 xmalloc returning NULL; that can't happen.
7353 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7354 (xpm_color_bucket): Use better integer hashing function.
7355 (xpm_cache_color): Don't possibly over-allocate memory.
7356 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7357 (gif_memory_source):
7358 Use ptrdiff_t, not int or size_t, to record sizes.
7359 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7360 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7361 either works, as we prefer signed integers.
7362 (tiff_read_from_memory, tiff_write_from_memory):
7363 Return tsize_t, not size_t, since that's what the TIFF API wants.
7364 (tiff_read_from_memory): Don't fail simply because the read would
7365 go past EOF; instead, return a short read.
7366 (tiff_load): Omit no-longer-needed casts.
7367 (Fimagemagick_types): Don't assume size fits into 'int'.
7368
3cc5a532
PE
7369 Improve hashing quality when configured --with-wide-int.
7370 * fns.c (hash_string): New function, taken from sxhash_string.
7371 Do not discard information about ASCII character case; this
7372 discarding is no longer needed.
7373 (sxhash-string): Use it. Change sig to match it. Caller changed.
7374 * lisp.h: Declare it.
7375 * lread.c (hash_string): Remove, since we now use fns.c's version.
7376 The fns.c version returns a wider integer if --with-wide-int is
7377 specified, so this should help the quality of the hashing a bit.
7378
b312a492
PE
7379 * emacs.c: Integer overflow minor fix.
7380 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7381 Define only if GNU_LINUX.
7382 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7383
dfd153ae
PE
7384 * dispnew.c: Integer signedness and overflow fixes.
7385 Remove unnecessary forward decls, that were a maintenance hassle.
7386 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7387 All uses changed.
7388 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7389 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7390 (prepare_desired_row, line_draw_cost):
7391 Use int, not unsigned, where either works.
7392 (save_current_matrix, restore_current_matrix):
7393 Use ptrdiff_t, not size_t, where either works.
7394 (init_display): Check for overflow more accurately, and without
7395 relying on undefined behavior.
7396
a81d11a3
PE
7397 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7398 Remove, replacing with the new symbols in lisp.h. All uses changed.
7399 * fileio.c (make_temp_name):
7400 * filelock.c (lock_file_1, lock_file):
7401 * xdisp.c (message_dolog):
7402 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7403 Use pMd etc. instead.
7404 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7405 replacing the pWIDE etc. symbols removed from editfns.c.
7406
3300e6fd
PE
7407 * keyboard.h (num_input_events): Now uintmax_t.
7408 This is (very slightly) less likely to mess up due to wraparound.
7409 All uses changed.
7410
fd05c7e9
PE
7411 * buffer.c: Integer signedness fixes.
7412 (alloc_buffer_text, enlarge_buffer_text):
7413 Use ptrdiff_t rather than size_t when either will do, as we prefer
7414 signed integers.
7415
903fe15d
PE
7416 * alloc.c: Integer signedness and overflow fixes.
7417 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7418 (__malloc_size_t): Default to size_t, not to int.
7419 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7420 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7421 Prefer ptrdiff_t to size_t when either would do, as we prefer
7422 signed integers.
7423 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7424 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7425 Now const. Initialize with values that are in range even if char
7426 is signed.
7427 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7428 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7429 These functions do the right thing with sizes > 2**32.
7430 (check_depth): Now ptrdiff_t, not int.
7431 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7432 Adjust to new way of storing sizes. Check for size overflow bugs
7433 in rest of code.
7434 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7435 slightly wrong anyway, as it missed one instance of
7436 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7437 (refill_memory_reserve): Omit needless cast to size_t.
7438 (mark_object_loop_halt): Mark as externally visible.
7439
ac82cc6a
PE
7440 * xselect.c: Integer signedness and overflow fixes.
7441 (Fx_register_dnd_atom, x_handle_dnd_message):
7442 Use ptrdiff_t, not size_t, since we prefer signed.
7443 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7444 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7445 x_dnd_atoms_size and x_dnd_atoms_length.
7446
c2d1e36d
PE
7447 * doprnt.c: Prefer signed to unsigned when either works.
7448 * eval.c (verror):
7449 * doprnt.c (doprnt):
7450 * lisp.h (doprnt):
7451 * xdisp.c (vmessage):
7452 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7453 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7454 prefer signed arithmetic to avoid comparison confusion.
7455 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7456 but is a bit tricky.
7457
0e926e56
PE
7458 Assume freestanding C89 headers, string.h, stdlib.h.
7459 * data.c, doprnt.c, floatfns.c, print.c:
7460 Include float.h unconditionally.
7461 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7462 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7463 * regex.c: Likewise for stddef.h, string.h.
7464 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7465 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7466 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7467 (STDC_HEADERS): Remove obsolete defines.
7468 * sysdep.c: Include limits.h unconditionally.
7469
9cfdb3ec
PE
7470 Assume support for memcmp, memcpy, memmove, memset.
7471 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7472 * regex.c (memcmp, memcpy):
7473 Remove; we assume C89 now.
7474
7475 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7476 (__malloc_safe_bcopy): Remove; no longer needed.
7477
cf950e6b 7478 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7479 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7480 well either way, and we prefer signed to unsigned.
7481
dbf38e02
LMI
74822011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7483
7484 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7485 closes the connection while we're reading (bug#9182).
7486
d6f0886c 74872011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7488
d6f0886c
JD
7489 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7490 are specified (Bug#9168).
24e0f6b1 7491
2eb1f9e6
PE
74922011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7493
7494 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7495 Found by GCC static checking and --with-wide-int on a 32-bit host.
7496
22381272 74972011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7498
7499 * xdisp.c (compute_display_string_pos): Fix logic of caching
7500 previous display string position. Initialize cached_prev_pos to
7501 -1. Fixes slow-down at the beginning of a buffer.
7502
f25e39b4
EZ
75032011-07-24 Eli Zaretskii <eliz@gnu.org>
7504
7505 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7506 for attrs[LFACE_FONTSET_INDEX].
7507
04c4b52e
PE
75082011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7509
7510 * xml.c (parse_region): Remove unused local
7511 that was recently introduced.
7512
c1734fbd
EZ
75132011-07-23 Eli Zaretskii <eliz@gnu.org>
7514
be18c5a5
EZ
7515 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7516 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7517
c1734fbd
EZ
7518 * xdisp.c (move_it_in_display_line_to): Record the best matching
7519 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7520 exit if none of the characters scanned was an exact match.
7521 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7522 when exact match is impossible due to invisible text, and the
7523 lines are truncated.
7524
a258d627
JD
75252011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7526
7527 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7528 for OSX >= 10.7.
7529
b6d5a689
EZ
75302011-07-22 Eli Zaretskii <eliz@gnu.org>
7531
0f74f785
EZ
7532 Fix a significant slow-down of cursor motion with C-n, C-p,
7533 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7534 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7535 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7536 (next_element_from_buffer): Call compute_stop_pos_backwards to
7537 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7538 base_level_stop.
7539 (reseat): Don't look for prev_stop, as that could mean a very long
7540 run.
7541 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7542 <cached_disp_overlay_modiff>: Cache for last found display string
7543 position.
551918c1 7544 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7545 about the same buffer in the same area of character positions, and
7546 the buffer wasn't changed since the time the display string
7547 position was cached.
551918c1 7548
b2d0c91a
EZ
75492011-07-22 Eli Zaretskii <eliz@gnu.org>
7550
7551 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7552 is an integer, which is important for empty lines. (Bug#9149)
7553
043604ee
CY
75542011-07-22 Chong Yidong <cyd@stupidchicken.com>
7555
7556 * frame.c (Fmodify_frame_parameters): In tty case, update the
7557 default face if necessary (Bug#4238).
7558
da4adb04
CY
75592011-07-21 Chong Yidong <cyd@stupidchicken.com>
7560
7561 * editfns.c (Fstring_to_char): No need to explain what a character
7562 is in the docstring (Bug#6576).
7563
9abd0532
LMI
75642011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7565
7566 * xml.c (parse_region): Make sure we always return a tree.
7567
36881d16
HK
75682011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7569
7570 * xml.c (parse_region): If a document contains only comments,
7571 return that, too.
7572
1e98674d
LMI
75732011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7574
7575 * xml.c (make_dom): Return comments, too.
7576
590bd467
PE
75772011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7578
7579 Port to OpenBSD.
7580 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7581 and the surrounding thread.
7582 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7583 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7584 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7585 timer goes off.
7586 * s/openbsd.h (BROKEN_SIGIO): Define.
7587 * unexelf.c (unexec) [__OpenBSD__]:
7588 Don't update the .mdebug section of the Alpha COFF symbol table.
7589
f41628b2
LMI
75902011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7591
7592 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7593 (bug#8460).
7594
b59b67c5
PE
75952011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7596
15e3a074
PE
7597 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7598 This fixes some race conditions on the permissions of any newly
7599 created file.
7600
41bed37d
PE
7601 * alloc.c (valid_pointer_p): Use pipe, not open.
7602 This fixes some permissions issues when debugging.
7603
b59b67c5
PE
7604 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7605 If fchown fails to set both uid and gid, try to set just gid,
7606 as that is sometimes allowed. Adjust the file's mode to eliminate
7607 setuid or setgid bits that are inappropriate if fchown fails.
7608
925a6be7
SM
76092011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7610
7611 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7612 to compare Lisp_Objects.
7613 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7614 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7615 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7616
52968808
AS
76172011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7618
0a6a104b
AS
7619 * lread.c (read_integer): Unread even EOF character.
7620 (read1): Likewise. Properly record start position of symbol.
7621
52968808
AS
7622 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7623 symbol character follows.
7624
9e381cdd
PE
76252011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7626
7627 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7628 This works around a problem with the previous change to Fcopy_file.
7629 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7630 and without this change, GCC might complain about discarding
7631 fchown's return value.
7632
b5641435
JB
76332011-07-16 Juanma Barranquero <lekktu@gmail.com>
7634
7635 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7636
a8031457
PE
76372011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7638
7639 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7640
dd889327
LMI
76412011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7642
750c33f7
LMI
7643 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7644 it's used from the C level.
7645
dd889327
LMI
7646 * process.c: Use the same condition for POLL_FOR_INPUT in both
7647 keyboard.c and process.c (bug#1858).
7648
87e86684
LM
76492011-07-09 Lawrence Mitchell <wence@gmx.li>
7650
7651 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7652 (Fgnutls_boot): Use it.
7653
64348f40
AS
76542011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7655
7656 * doc.c (Fsubstitute_command_keys): Revert last change.
7657
1d698799
LMI
76582011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7659
f863868c
LMI
7660 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7661 quotes the next character, and doesn't affect other longer
7662 sequences (bug#8935).
7663
1d698799
LMI
7664 * lread.c (syms_of_lread): Clarify that is isn't only
7665 `eval-buffer' and `eval-defun' that's affected by
7666 `lexical-binding' (bug#8460).
7667
aa4b6df6
EZ
76682011-07-15 Eli Zaretskii <eliz@gnu.org>
7669
7670 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7671 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7672
5d856da6
PE
76732011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7674
ad6042bb
PE
7675 Fix minor problems found by static checking.
7676 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7677 (elsz): Now a signed constant, not a size_t var. We prefer signed
7678 types to unsigned, to avoid integer comparison confusion. Without
7679 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7680 "cannot optimize loop, the loop counter may overflow", a symptom
7681 of the confusion.
f00bbb22 7682 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7683 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7684
6468f31c
LMI
76852011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7686
49080b10
LMI
7687 * search.c (Fre_search_backward): Mention `case-fold-search' in
7688 all the re_search_* functions (bug#8138).
7689
6468f31c
LMI
7690 * keyboard.c (Fopen_dribble_file): Document when the file is
7691 closed (bug#8056).
7692
c965adc5
EZ
76932011-07-14 Eli Zaretskii <eliz@gnu.org>
7694
df9733bf
EZ
7695 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7696 bidi_cache_idx.
7697
0bb23927
EZ
7698 Support bidi reordering of display and overlay strings.
7699 * xdisp.c (compute_display_string_pos)
7700 (compute_display_string_end): Accept additional argument STRING.
7701 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7702 (reseat_to_string): Initialize bidi_it->string.s and
7703 bidi_it->string.schars.
7704 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7705 NULL (avoids a crash in bidi_paragraph_init).
7706 Initialize itb.string.lstring.
0bb23927
EZ
7707 (init_iterator): Call bidi_init_it only of a valid
7708 buffer position was specified. Initialize paragraph_embedding to
7709 L2R.
7710 (reseat_to_string): Initialize the bidi iterator.
7711 (display_string): If we need to ignore text properties of
7712 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7713 original value of -1 will not work with bidi.)
7714 (compute_display_string_pos): First arg is now struct
7715 `text_pos *'; all callers changed. Support display properties on
7716 Lisp strings.
7717 (compute_display_string_end): Support display properties on Lisp
7718 strings.
7719 (init_iterator, reseat_1, reseat_to_string): Initialize the
7720 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7721 when iterating on a string not from display properties).
640c8776
SM
7722 (compute_display_string_pos, compute_display_string_end):
7723 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7724 arrow keys.
7725 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7726 base_level_stop; instead, set base_level_stop to BEGV.
7727 Fixes crashes in vertical-motion.
0bb23927
EZ
7728 (next_element_from_buffer): Improve commentary for when
7729 the iterator is before prev_stop.
7730 (init_iterator): Initialize bidi_p from the default value of
7731 bidi-display-reordering, not from buffer-local value. Use the
7732 buffer-local value only if initializing for buffer iteration.
7733 (handle_invisible_prop): Support invisible properties on strings
7734 that are being bidi-reordered.
7735 (set_iterator_to_next): Support bidi reordering of C strings and
7736 Lisp strings.
7737 (next_element_from_string): Support bidi reordering of Lisp
7738 strings.
7739 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7740 (display_string): Support display of R2L glyph rows.
7741 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7742 (init_iterator): Don't initialize it->bidi_p for strings
7743 here.
7744 (reseat_to_string): Initialize it->bidi_p for strings here.
7745 (next_element_from_string, next_element_from_c_string)
7746 (next_element_from_buffer): Add xassert's for correspondence
7747 between IT's object being iterated and it->bidi_it.string
7748 structure.
7749 (face_before_or_after_it_pos): Support bidi iteration.
7750 (next_element_from_c_string): Handle the case of the first string
7751 character that is not the first one in the visual order.
7752 (get_visually_first_element): New function, refactored from common
7753 parts of next_element_from_buffer, next_element_from_string, and
7754 next_element_from_c_string.
7755 (tool_bar_lines_needed, redisplay_tool_bar)
7756 (display_menu_bar): Force left-to-right direction. Add a FIXME
7757 comment for making that be controlled by a user option.
7758 (push_it, pop_it): Save and restore the state of the
7759 bidi iterator. Save and restore the bidi_p flag.
7760 (pop_it): Iterate out of display property for string iteration as
7761 well.
7762 (iterate_out_of_display_property): Support iteration over strings.
7763 (handle_single_display_spec): Set up it->bidi_it for iteration
7764 over a display string, and call bidi_init_it.
7765 (handle_single_display_spec, next_overlay_string)
7766 (get_overlay_strings_1, push_display_prop): Set up the bidi
7767 iterator for displaying display or overlay strings.
7768 (forward_to_next_line_start): Don't use the shortcut if
7769 bidi-iterating.
7770 (back_to_previous_visible_line_start): If handle_display_prop
7771 pushed the iterator stack, restore the internal state of the bidi
7772 iterator by calling bidi_pop_it same number of times.
7773 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7774 and we are bidi-iterating, don't decrement the iterator position;
7775 instead, set the first_elt flag in the bidi iterator, to produce
7776 the same effect.
7777 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7778 (push_display_prop): xassert that we are iterating a buffer.
7779 (push_it, pop_it): Save and restore paragraph_embedding member.
7780 (handle_single_display_spec, next_overlay_string)
7781 (get_overlay_strings_1, reseat_1, reseat_to_string)
7782 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7783 correctly. Don't assume unibyte strings are not bidi-reordered.
7784 (compute_display_string_pos)
7785 (compute_display_string_end): Fix handling the case of C string.
7786 (push_it, pop_it): Save and restore from_disp_prop_p.
7787 (handle_single_display_spec, push_display_prop): Set the
7788 from_disp_prop_p flag.
7789 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7790 (pop_it): Call iterate_out_of_display_property only if we are
7791 popping after iteration over a string that came from a display
7792 property. Fix a typo in popping stretch info. Add an assertion
7793 for verifying that the iterator position is in sync with the bidi
7794 iterator.
7795 (handle_single_display_spec, get_overlay_strings_1)
7796 (push_display_prop): Fix initialization of paragraph direction for
7797 string when that of the parent object is not yet determined.
7798 (reseat_1): Call bidi_init_it to resync the bidi
7799 iterator with IT's position. (Bug#7616)
7800 (find_row_edges): If ROW->start.pos gives position
7801 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7802 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7803 Reset the from_disp_prop_p flag.
7804 (SAVE_IT, RESTORE_IT): New macros.
7805 (pos_visible_p, face_before_or_after_it_pos)
7806 (back_to_previous_visible_line_start)
7807 (move_it_in_display_line_to, move_it_in_display_line)
7808 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7809 (try_scrolling, redisplay_window, display_line): Use them when
7810 saving a temporary copy of the iterator and restoring it back.
7811 (back_to_previous_visible_line_start, reseat_1)
7812 (init_iterator): Empty the bidi cache "stack".
7813 (move_it_in_display_line_to): If iterator ended up at
7814 EOL, but we never saw any buffer positions smaller than
7815 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7816 motion in bidi-reordered lines.
7817 (move_it_in_display_line_to): Record prev_method and prev_pos
7818 immediately before the call to set_iterator_to_next. Fixes cursor
7819 motion in bidi-reordered lines with stretch glyphs and strings
7820 displayed in margins. (Bug#8133) (Bug#8867)
7821 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7822 TO_CHARPOS.
640c8776
SM
7823 (pos_visible_p): Support positions in bidi-reordered lines.
7824 Save and restore bidi cache.
0bb23927
EZ
7825
7826 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7827 (bidi_paragraph_info): Delete unused struct.
7828 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7829 (bidi_cache_start): New variable.
7830 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7831 to zero.
7832 (bidi_cache_fetch_state, bidi_cache_search)
7833 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7834 (bidi_cache_find, bidi_peek_at_next_level)
7835 (bidi_level_of_next_char, bidi_find_other_level_edge)
7836 (bidi_move_to_visually_next): Compare cache index with
7837 bidi_cache_start rather than with zero.
7838 (bidi_fetch_char): Accept new argument STRING; all callers
7839 changed. Support iteration over a string. Support strings with
7840 display properties. Support unibyte strings. Fix the type of
7841 `len' according to what STRING_CHAR_AND_LENGTH expects.
7842 (bidi_paragraph_init, bidi_resolve_explicit_1)
7843 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7844 (bidi_level_of_next_char, bidi_move_to_visually_next):
7845 Support iteration over a string.
0bb23927
EZ
7846 (bidi_set_sor_type, bidi_resolve_explicit_1)
7847 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7848 can now be zero (for strings); special values 0 and -1 were
7849 changed to -1 and -2, respectively.
7850 (bidi_char_at_pos): New function.
7851 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7852 Call it instead of FETCH_MULTIBYTE_CHAR.
7853 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7854 initialized to valid values.
7855 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7856 values.
7857 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7858 the test for valid cached positions. Fix the logic for looking up
7859 the sentinel state in the cache. GCPRO the Lisp string we are
7860 iterating.
7861 (bidi_push_it, bidi_pop_it): New functions.
7862 (bidi_initialize): Initialize the bidi cache start stack pointer.
7863 (bidi_cache_ensure_space): New function, refactored from part of
7864 bidi_cache_iterator_state. Don't assume the required size is just
7865 one BIDI_CACHE_CHUNK away.
7866 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7867 (bidi_count_bytes, bidi_char_at_pos): New functions.
7868 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7869 always valid if bidi_cache_idx is valid.
7870 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7871 is valid if it's going to be used.
7872 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7873 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7874 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7875 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7876 (bidi_find_other_level_edge, bidi_cache_start_stack):
7877 All variables related to cache indices are now EMACS_INT.
c965adc5 7878
0bb23927
EZ
7879 * dispextern.h (struct bidi_string_data): New structure.
7880 (struct bidi_it): New member `string'. Make flag members be 1-bit
7881 fields, and put them last in the struct.
640c8776
SM
7882 (compute_display_string_pos, compute_display_string_end):
7883 Update prototypes.
0bb23927
EZ
7884 (bidi_push_it, bidi_pop_it): Add prototypes.
7885 (struct iterator_stack_entry): New members bidi_p,
7886 paragraph_embedding, and from_disp_prop_p.
7887 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7888 (bidi_shelve_cache, bidi_unshelve_cache):
7889 Declare prototypes.
0bb23927
EZ
7890
7891 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7892 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7893 and vector-like objects.
7894
7895 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7896 cache around display iteration.
7897
7898 * window.c (Fwindow_end, window_scroll_pixel_based)
7899 (displayed_window_lines, Frecenter): Save and restore the bidi
7900 cache around display iteration.
7901
3bbd2265
LMI
79022011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7903
7904 * editfns.c (Fdelete_region): Clarify the use of the named
7905 parameters (bug#6788).
7906
adc47434
MR
79072011-07-14 Martin Rudalics <rudalics@gmx.at>
7908
7909 * indent.c (Fvertical_motion): Set and restore w->pointm when
7910 saving and restoring the window's buffer (Bug#9006).
7911
837c31f8
LMI
79122011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7913
7914 * editfns.c (Fstring_to_char): Clarify just what is returned
7915 (bug#6576). Text by Eli Zaretskii.
7916
ac389d0c
JB
79172011-07-13 Juanma Barranquero <lekktu@gmail.com>
7918
7919 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7920
0be0ce47
EZ
79212011-07-13 Eli Zaretskii <eliz@gnu.org>
7922
7923 * buffer.c (mmap_find): Fix a typo.
7924
cd18e7e3
JB
79252011-07-13 Johan Bockgård <bojohan@gnu.org>
7926
7927 Fix execution of x selection hooks.
7928 * xselect.c (Qx_lost_selection_functions)
7929 (Qx_sent_selection_functions): New vars.
7930 (syms_of_xselect): DEFSYM them.
7931 (x_handle_selection_request): Pass Qx_sent_selection_functions
7932 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7933 (x_handle_selection_clear,x_clear_frame_selections):
7934 Pass Qx_lost_selection_functions rather than
7935 Vx_lost_selection_functions to Frun_hook_with_args.
7936
47ea7f44
PE
79372011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7938
ac389d0c 7939 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7940 The old code sometimes used this field without initializing it.
7941
47ea7f44
PE
7942 * alloc.c (gc_sweep): Don't read past end of array.
7943 In theory, the old code could also have corrupted Emacs internals,
7944 though it'd be very unlikely.
7945
bc985c87
AS
79462011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7947
7948 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7949 argument. (Bug#4026)
bc985c87 7950
0cf34688
LMI
79512011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7952
b3dadd76
LMI
7953 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7954 key" (bug#4257).
7955
0cf34688
LMI
7956 * window.c (Fset_window_start): Doc fix (bug#4199).
7957 (Fset_window_hscroll): Ditto.
7958
270768cd
PE
79592011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7960
077e3dda 7961 Fix minor new problems caught by GCC 4.6.1.
270768cd 7962 * term.c (init_tty): Remove unused local.
490011a6 7963 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7964 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7965 not used otherwise.
270768cd 7966
b1f58454
CY
79672011-07-12 Chong Yidong <cyd@stupidchicken.com>
7968
7969 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7970
22b9578d
LMI
79712011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7972
6e70ab07
LMI
7973 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7974 are the mini-buffer and the echo area (bug#3320).
7975
22b9578d
LMI
7976 * term.c (init_tty): Remove support for supdup, c10 and perq
7977 terminals, which are no longer supported (bug#1482).
7978
8974cc9f
JB
79792011-07-10 Johan Bockgård <bojohan@gnu.org>
7980
7981 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7982
a560d974
JD
79832011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7984
7985 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7986 for non-popups (Bug#3642).
7987
1dae0f0a
AS
79882011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7989
268c2c36 7990 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7991 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7992 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7993 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7994 * data.c (fmod): Likewise.
7995 * dispnew.c (swap_glyphs_in_rows): Likewise.
7996 * emacs.c (memory_warning_signal): Likewise.
7997 * floatfns.c (float_error): Likewise.
7998 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7999 (otf_open, font_otf_capability, generate_otf_features)
8000 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8001 Likewise.
8002 * image.c (pbm_read_file): Likewise.
8003 * indent.c (string_display_width): Likewise.
8004 * intervals.c (check_for_interval, search_for_interval)
8005 (inc_interval_count, count_intervals, root_interval)
8006 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8007 * lread.c (defalias): Likewise.
268c2c36 8008 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8009 * regex.c (set_image_of_range_1, set_image_of_range)
8010 (regex_grow_registers): Likewise.
8011 * sysdep.c (strerror): Likewise.
8012 * termcap.c (valid_filename_p, tprint, main): Likewise.
8013 * tparam.c (main): Likewise.
8014 * unexhp9k800.c (run_time_remap, save_data_space)
8015 (update_file_ptrs, read_header, write_header, calculate_checksum)
8016 (copy_file, copy_rest, display_header): Likewise.
8017 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8018 Likewise.
8019 * xdisp.c (check_it): Likewise.
8020 * xfaces.c (register_color, unregister_color, unregister_colors):
8021 Likewise.
8022 * xfns.c (print_fontset_result): Likewise.
8023 * xrdb.c (member, fatal, main): Likewise.
8024
99033785
PE
80252011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8026
8027 Fix minor problems found by static checking (Bug#9031).
8028 * chartab.c (char_table_set_range, map_sub_char_table):
8029 Remove unused locals.
8030 (uniprop_table): Now static.
8031 * composite.c (_work_char): Remove unused static var.
8032
9cb2ac56
JB
80332011-07-09 Juanma Barranquero <lekktu@gmail.com>
8034
8035 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8036
f25661f0
JD
80372011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8038
8039 * gtkutil.c (qttip_cb): Remove code without function.
8040
8278c4fe
EZ
80412011-07-09 Eli Zaretskii <eliz@gnu.org>
8042
8043 * w32.c (pthread_sigmask): New stub.
8044
1692ae2d 80452011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8046
8a6ebd58 8047 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8048 sigprocmask is portable only for single-threaded applications, and
8049 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8050 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8051 (LIBES): Use it.
8052 * callproc.c (Fcall_process):
8053 * process.c (create_process):
8054 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8055 Use pthread_sigmask, not sigprocmask.
123403e4 8056
1b854618
JD
80572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8058
8059 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8060 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8061 wrong (Bug#8591).
8062
3fe4b549
JD
80632011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8064
0ce7e563
JD
8065 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8066 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8067 (xg_hide_tooltip): Fix comment.
8068
3fe4b549
JD
8069 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8070 in registerServicesMenuSendTypes.
8071 (validRequestorForSendType): Don't check ns_return_types.
8072
8073 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8074 ns_return_type.
8075
5df75e47
JR
80762011-07-08 Jason Rumney <jasonr@gnu.org>
8077
22610910
JR
8078 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8079 SH_SHOW for hidden windows (Bug#5482).
8080
5df75e47
JR
8081 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8082 frame struct members of non-existent frames (Bug#6284).
8083
699c10bd
JD
80842011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8085
4393663b
JD
8086 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8087 variable firstTime not needed on OSX >= 10.6.
8088 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8089 >= 10.5. Use setKnobProportion, setDoubleValue.
8090
8091 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8092 (MAC_OS_X_VERSION_10_5): Define if not defined.
8093 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8094 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8095 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8096
8097 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8098 cString and lossyCString on OSX >= 10.4.
4393663b 8099
58179cce 8100 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8101 sizeToFit on OSX >= 10.2.
8102
8103 * nsimage.m (allocInitFromFile): Don't use deprecated method
8104 bestRepresentationForDevice on OSX >= 10.6.
8105
8106 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8107 to avoid warning.
8108
8109 * emacs.c: Declare unexec_init_emacs_zone.
8110
a63e0781
JD
8111 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8112
699c10bd
JD
8113 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8114
8115 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8116 on svcsMenu (Bug#8842).
8117
8118 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8119 ns_return_types.
8120 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8121
8122 * nsterm.m (QUTF8_STRING): Declare.
8123 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8124 (validRequestorForSendType): Return type is (id).
8125 Change indexOfObjectIdenticalTo to indexOfObject.
8126 Check if we have local selection before returning self (Bug#8842).
8127 (writeSelectionToPasteboard): Put local selection into paste board
8128 if we have a local selection (Bug#8842).
8129 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8130
8131 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8132 (ns_get_local_selection): Declare.
8133
54e10184
LMI
81342011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8135
9888ff71
LMI
8136 * keymap.c (describe_map_tree): Don't insert a double newline at
8137 the end of the buffer (bug#1169) and return whether we inserted
8138 something.
8139
54e10184
LMI
8140 * callint.c (Fcall_interactively): Change "reading args" to
8141 "providing args" to try to clarify what it does (bug#1010).
8142
15fa4783
KH
81432011-07-07 Kenichi Handa <handa@m17n.org>
8144
8145 * composite.c (composition_compute_stop_pos): Ignore a static
8146 composition starting before CHARPOS (Bug#8915).
8147
8148 * xdisp.c (handle_composition_prop): Likewise.
8149
a8815b00
EZ
81502011-07-07 Eli Zaretskii <eliz@gnu.org>
8151
8152 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8153 (Bug#9015)
8154
ef7b981d 81552011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8156
8157 * character.h (unicode_category_t): New enum type.
8158
8159 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8160 (Qchar_code_property_table): New variable.
8161 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8162 (UNIPROP_COMPRESSED_FORM_P): New macros.
8163 (char_table_ascii): Uncompress the compressed values.
8164 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8165 Uncompress the compressed values.
ac389d0c 8166 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8167 (char_table_ref_and_range): Uncompress the compressed values.
8168 (sub_char_table_set): New arg is_uniprop. Callers changed.
8169 Uncompress the compressed values.
8170 (sub_char_table_set_range): Args changed. Callers changed.
8171 (char_table_set_range): Adjuted for the above change.
8172 (map_sub_char_table): Delete args default_val and parent. Add arg
8173 top. Give decoded values to a Lisp function.
640c8776 8174 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8175 values to a Lisp function. Gcpro more variables.
8176 (uniprop_table_uncompress)
8177 (uniprop_decode_value_run_length): New functions.
8178 (uniprop_decoder, uniprop_decoder_count): New variables.
8179 (uniprop_get_decoder, uniprop_encode_value_character)
8180 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8181 New functions.
8182 (uniprop_encoder, uniprop_encoder_count): New variables.
8183 (uniprop_get_encoder, uniprop_table)
8184 (Funicode_property_table_internal, Fget_unicode_property_internal)
8185 (Fput_unicode_property_internal): New functions.
8186 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8187 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8188 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8189 char-code-property-alist.
8190
640c8776 8191 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8192 Vunicode_category_table.
8193
640c8776 8194 * font.c (font_range): Adjust for the change of
c805dec0
KH
8195 Vunicode_category_table.
8196
76b397fb
DN
81972011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8198
8199 * m/iris4d.h: Remove file, move contents ...
8200 * s/irix6-5.h: ... here.
8201
22b4128e
PE
82022011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8203
8204 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8205 * alloc.c (mark_buffer):
8206 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8207 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8208 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8209 This isn't true in general, and it's particularly not true
8210 if Emacs is configured with --with-wide-int.
8211 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8212 New macros, used in the buffer.c change.
8213
869795d6
JD
82142011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8215
8216 * xsettings.c: Use both GConf and GSettings if both are available.
8217 (store_config_changed_event): Add comment.
8218 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8219 (store_tool_bar_style_changed): New functions.
5e617bc2 8220 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8221 (struct xsettings): Move font inside HAVE_XFT.
8222 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8223 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8224 Move inside HAVE_XFT.
640c8776 8225 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8226 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8227 also.
8228 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8229 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8230 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8231 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8232 (parse_settings): Move check for font inside HAVE_XFT.
8233 (read_settings, apply_xft_settings): Add comment.
8234 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8235 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8236 call store_font_name_changed.
8237 (xft_settings_event): Add comment.
8238 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8239 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8240 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8241 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8242 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8243 (xsettings_get_system_font, xsettings_get_system_normal_font):
8244 Add comment.
869795d6 8245
d8ed26bd
PE
82462011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8247
8248 Random fixes. E.g., (random) never returned negative values.
8249 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8250 subseconds part to the entropy, as that's a bit more random.
8251 Prefer signed to unsigned, since the signedness doesn't matter and
8252 in general we prefer signed. When given a limit, use a
8253 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8254 latter isn't right if USE_2_TAGS_FOR_INTS.
8255 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8256 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8257
cabf1cac
SM
82582011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8259
8260 * textprop.c (text_property_stickiness):
8261 Obey Vtext_property_default_nonsticky.
8262 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8263 * w32fns.c (syms_of_w32fns):
8264 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8265
6e9b2be9
PE
82662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8267
8268 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8269 This is more efficient than Ffile_directory_p and avoids a minor race.
8270
90186c68
LMI
82712011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8272
7c301272
LMI
8273 * buffer.c (Foverlay_put): Say what the return value is
8274 (bug#7835).
8275
c4f2d8d4
LMI
8276 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8277 is a directory before asking whether to use the file name
8278 (bug#7564).
ad637907
LMI
8279 (barf_or_query_if_file_exists): Make the "File is a directory"
8280 error be more correct.
c4f2d8d4 8281
90186c68
LMI
8282 * fns.c (Frequire): Remove the mention of the .gz files, since
8283 that's installation-specific, but keep the mention of
8284 `get-load-suffixes'.
8285
da64016e
PE
82862011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8287
8288 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8289 Report string overflow if the output is too long.
8290
7d47b580
JB
82912011-07-04 Juanma Barranquero <lekktu@gmail.com>
8292
a555cb87
JB
8293 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8294 (syms_of_gnutls): Remove duplicate DEFSYM for
8295 Qgnutls_bootprop_verify_hostname_error, an error for
8296 Qgnutls_bootprop_verify_error (which is no longer used).
8297
7d47b580
JB
8298 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8299 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8300 Also (re)move comments that are misplaced or no longer relevant.
8301
1e49bfab
LMI
83022011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8303
8304 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8305
1485f4c0
CY
83062011-07-03 Chong Yidong <cyd@stupidchicken.com>
8307
8308 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8309 and background color parameters if they have been changed.
8310
a9ab721e
LMI
83112011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8312
8313 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8314
cf7cff57
PE
83152011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8316
2e13213d
PE
8317 * xsettings.c (SYSTEM_FONT): Define only when used.
8318 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8319
cf7cff57
PE
8320 * keymap.c (access_keymap_1): Now static.
8321
7a8e04f7
CY
83222011-07-02 Chong Yidong <cyd@stupidchicken.com>
8323
8324 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8325 leave any prefix arg for the up event (Bug#1586).
8326
61352f62
LMI
83272011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8328
69bb1ef7
LMI
8329 * lread.c (syms_of_lread): Mention single symbols defined by
8330 `defvar' or `defconst' (bug#7154).
8331
61352f62 8332 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8333 (Frequire): Mention get-load-suffixes.
61352f62 8334
28545e04
MR
83352011-07-02 Martin Rudalics <rudalics@gmx.at>
8336
8337 * window.h (window): Remove clone_number slot.
8338 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8339 Remove.
8340 (make_parent_window, make_window, saved_window)
8341 (Fset_window_configuration, save_window_save): Don't deal with
8342 clone numbers.
8343 * buffer.c (Qclone_number): Remove declaration.
8344 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8345
3349e122
SM
83462011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8347
8348 Add multiple inheritance to keymaps.
8349 * keymap.c (Fmake_composed_keymap): New function.
8350 (Fset_keymap_parent): Simplify.
8351 (fix_submap_inheritance): Remove.
8352 (access_keymap_1): New function extracted from access_keymap to handle
8353 embedded parents and handle lists of maps.
8354 (access_keymap): Use it.
8355 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8356 (Fcopy_keymap): Handle embedded parents.
8357 (Fcommand_remapping, define_as_prefix): Simplify.
8358 (Fkey_binding): Simplify.
8359 (syms_of_keymap): Move minibuffer-local-completion-map,
8360 minibuffer-local-filename-completion-map,
8361 minibuffer-local-must-match-map, and
8362 minibuffer-local-filename-must-match-map to Elisp.
8363 (syms_of_keymap): Defsubr make-composed-keymap.
8364 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8365 (parse_menu_item): Trivial simplification.
8366
3279eb87
GM
83672011-07-01 Glenn Morris <rgm@gnu.org>
8368
8369 * Makefile.in (SETTINGS_LIBS): Fix typo.
8370
4550efdf
KI
83712011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8372
8373 * coding.c (Fencode_coding_string): Record the last coding system
8374 used, as the function doc string says (bug#8738).
8375
0949d2b6
JD
83762011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8377
8378 * xsettings.c (store_monospaced_changed): Take new font as arg and
8379 check for change against current_mono_font.
8380 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8381 (emacs_settings_constructor, emacs_settings_get_property)
8382 (emacs_settings_set_property, emacs_settings_class_init)
8383 (emacs_settings_init, gsettings_obj): Remove.
8384 (something_changedCB): New function for HAVE_GSETTINGS.
8385 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8386 with value as argument.
8387 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8388 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8389 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8390 "changed".
8391
8392 * xgselect.c: Add defined (HAVE_GSETTINGS).
8393 (xgselect_initialize): Ditto.
8394
8395 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8396 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8397 xg_select.
8398
bbc6b304
PE
83992011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8400
8401 * eval.c (struct backtrace): Simplify and port the data structure.
8402 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8403 signed bit field, as this assumption is not portable and it makes
8404 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8405 "char debug_on_exit : 1" as this is not portable either; instead,
8406 use the portable "unsigned int debug_on_exit : 1". Remove unused
8407 member evalargs. Remove obsolete comments about cc bombing out.
8408
9851bfc5
JD
84092011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8410
51bb811f 8411 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8412 Let HAVE_GSETTINGS override HAVE_GCONF.
8413 (store_monospaced_changed): New function.
8414 (EMACS_SETTINGS): A new type derived from GObject to handle
8415 GSettings notifications.
8416 (emacs_settings_constructor, emacs_settings_get_property)
8417 (emacs_settings_set_property, emacs_settings_class_init):
8418 New functions.
8419 (gsettings_client, gsettings_obj): New variables.
8420 (GSETTINGS_SCHEMA): New define.
8421 (something_changedCB): Call store_monospaced_changed.
8422 (init_gsettings): New function.
8423 (xsettings_initialize): Call init_gsettings.
8424 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8425 to NULL.
8426
640c8776 8427 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8428 GCONF_CFLAGS/LIBS.
8429
5386012d
MR
84302011-06-29 Martin Rudalics <rudalics@gmx.at>
8431
8432 * window.c (resize_root_window, grow_mini_window)
8433 (shrink_mini_window): Rename Qresize_root_window to
8434 Qwindow_resize_root_window and Qresize_root_window_vertically to
8435 Qwindow_resize_root_window_vertically.
8436
f13e0b08
PE
84372011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8438
8439 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8440
94515237
JB
84412011-06-27 Juanma Barranquero <lekktu@gmail.com>
8442
8443 * makefile.w32-in: Redesign dependencies so they reflect more
8444 clearly which files are directly included by each source file,
8445 and not through other includes.
8446
e43b6e43
MR
84472011-06-27 Martin Rudalics <rudalics@gmx.at>
8448
8449 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8450 (sort_overlays, overlay_strings): When an overlay's clone number
8451 matches the window's clone number process the overlay even if
8452 the overlay's window property doesn't match the current window.
8453
d68443dc
MR
8454 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8455 (Fwindow_hchild): Rename to Fwindow_left_child.
8456 (Fwindow_next): Rename to Fwindow_next_sibling.
8457 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8458 (resize_window_check): Rename to window_resize_check.
8459 (resize_window_apply): Rename to window_resize_apply.
8460 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8461 (Fdelete_other_windows_internal, resize_frame_windows)
8462 (Fsplit_window_internal, Fdelete_window_internal)
8463 (grow_mini_window, shrink_mini_window)
8464 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8465
c7e73be5
JD
84662011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8467
8468 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8469 (emacs_fixed_set_min_size): Remove.
8470 (emacs_fixed_new): Take frame as argument.
8471
8472 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8473 (_EmacsFixedPrivate): Remove minwidth/height.
8474 Add struct frame *f.
8475 (emacs_fixed_init): Initialize priv->f.
8476 (get_parent_class, emacs_fixed_set_min_size): Remove.
8477 (emacs_fixed_new): Set priv->f to argument.
8478 (emacs_fixed_get_preferred_width)
8479 (emacs_fixed_get_preferred_height): Use min_width/height from
8480 frames size_hint to set minimum and natural (Bug#8919).
8481 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8482 and use min_width/height from frames size_hint to set
8483 min_width/height (Bug#8919).
8484
8485 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8486 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8487 Fix indentation.
c7e73be5 8488
cf99dcf8
EZ
84892011-06-26 Eli Zaretskii <eliz@gnu.org>
8490
8491 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8492 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8493 called at ZV.
8494
029529ac
CY
84952011-06-26 Chong Yidong <cyd@stupidchicken.com>
8496
8497 * process.c (wait_reading_process_output): Bypass select if
8498 waiting for a cell while ignoring keyboard input, and input is
8499 pending. Suggested by Jan Djärv (Bug#8869).
8500
7a7ef429
PE
85012011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8502
8503 Use gnulib's dup2 module instead of rolling our own.
8504 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8505
11fdef7d 85062011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8507
8508 * dispnew.c (scrolling_window): Before scrolling, turn off a
8509 mouse-highlight in the window being scrolled.
8510
cd3520a4
JB
85112011-06-24 Juanma Barranquero <lekktu@gmail.com>
8512
8513 Move DEFSYM to lisp.h and use everywhere.
8514
8515 * character.h (DEFSYM): Move declaration...
8516 * lisp.h (DEFSYM): ...here.
8517
8518 * gnutls.c:
8519 * minibuf.c:
8520 * w32menu.c:
8521 * w32proc.c:
8522 * w32select.c: Don't include character.h.
8523
8524 * alloc.c (syms_of_alloc):
8525 * buffer.c (syms_of_buffer):
8526 * bytecode.c (syms_of_bytecode):
8527 * callint.c (syms_of_callint):
8528 * casefiddle.c (syms_of_casefiddle):
8529 * casetab.c (init_casetab_once):
8530 * category.c (init_category_once, syms_of_category):
8531 * ccl.c (syms_of_ccl):
8532 * cmds.c (syms_of_cmds):
8533 * composite.c (syms_of_composite):
8534 * dbusbind.c (syms_of_dbusbind):
8535 * dired.c (syms_of_dired):
8536 * dispnew.c (syms_of_display):
8537 * doc.c (syms_of_doc):
8538 * editfns.c (syms_of_editfns):
8539 * emacs.c (syms_of_emacs):
8540 * eval.c (syms_of_eval):
8541 * fileio.c (syms_of_fileio):
8542 * fns.c (syms_of_fns):
8543 * frame.c (syms_of_frame):
8544 * fringe.c (syms_of_fringe):
8545 * insdel.c (syms_of_insdel):
8546 * keymap.c (syms_of_keymap):
8547 * lread.c (init_obarray, syms_of_lread):
8548 * macros.c (syms_of_macros):
8549 * msdos.c (syms_of_msdos):
8550 * print.c (syms_of_print):
8551 * process.c (syms_of_process):
8552 * search.c (syms_of_search):
8553 * sound.c (syms_of_sound):
8554 * syntax.c (init_syntax_once, syms_of_syntax):
8555 * terminal.c (syms_of_terminal):
8556 * textprop.c (syms_of_textprop):
8557 * undo.c (syms_of_undo):
8558 * w32.c (globals_of_w32):
8559 * window.c (syms_of_window):
8560 * xdisp.c (syms_of_xdisp):
8561 * xfaces.c (syms_of_xfaces):
8562 * xfns.c (syms_of_xfns):
8563 * xmenu.c (syms_of_xmenu):
8564 * xsettings.c (syms_of_xsettings):
8565 * xterm.c (syms_of_xterm): Use DEFSYM.
8566
4228cf16
TZ
85672011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8568
cd3520a4 8569 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8570
7fcccf1e
PE
85712011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8572
7efb4e0e
PE
8573 Integer and buffer overflow fixes (Bug#8873).
8574
ff5844ad
PE
8575 * print.c (printchar, strout): Check for string overflow.
8576 (PRINTPREPARE, printchar, strout):
8577 Don't set size unless allocation succeeds.
8578
90532f02
PE
8579 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8580 for sizes. Check for string overflow more accurately.
8581 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8582
6d84508d
PE
8583 * macros.c: Integer and buffer overflow fixes.
8584 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8585 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8586 Use ptrdiff_t, not int, for sizes.
8587 Don't increment bufsize until after realloc succeeds.
8588 Check for size-calculation overflow.
8589 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8590
437b2cb4
PE
8591 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8592
8b9ac8b4
PE
8593 * lread.c: Integer overflow fixes.
8594 (read_integer): Radix is now EMACS_INT, not int,
8595 to improve quality of diagnostics for out-of-range radices.
8596 Calculate buffer size correctly for out-of-range radices.
8597 (read1): Check for integer overflow in radices, and in
8598 read-circle numbers.
82cb60d3
PE
8599 (read_escape): Avoid int overflow.
8600 (Fload, openp, read_buffer_size, read1)
8601 (substitute_object_recurse, read_vector, read_list, map_obarray):
8602 Use ptrdiff_t, not int, for sizes.
8603 (read1): Use EMACS_INT, not int, for sizes.
20270765 8604 Check for size overflow.
8b9ac8b4 8605
7fcccf1e
PE
8606 * image.c (cache_image): Check for size arithmetic overflow.
8607
bfbbd7e7
PE
8608 * lread.c: Integer overflow issues.
8609 (saved_doc_string_size, saved_doc_string_length)
8610 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8611 Now ptrdiff_t, not int.
8612 (read1): Don't assume doc string length fits in int. Check for
8613 out-of-range doc string lengths.
8614 (read_list): Don't assume file position fits in int.
39019e54 8615 (read_escape): Check for hex character overflow.
bfbbd7e7 8616
4e323265
LL
86172011-06-22 Leo Liu <sdl.web@gmail.com>
8618
8619 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8620 Move to minibuffer.el.
8621
85fece3e
PE
86222011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8623
20b84ce9 8624 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8625 The following patches are for when GLYPH_DEBUG && !XASSERT.
8626 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8627 * dispnew.c (flush_stdout):
8628 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8629 Mark as externally visible.
8630 * dispnew.c (check_window_matrix_pointers): Now static.
8631 * dispnew.c (window_to_frame_vpos):
8632 * xfns.c (unwind_create_frame):
8633 * xterm.c (x_check_font): Remove unused local.
8634 * scroll.c (CHECK_BOUNDS):
8635 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8636 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8637 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8638 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8639 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8640 Now static.
8641 (debug_method_add): Use va_list and vsprintf rather than relying
8642 on undefined behavior with wrong number of arguments.
8643 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8644 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8645 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8646 since we're not interested in debugging glyphs with old libraries.
8647 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8648 GCC 4.6.0's static checking.
8649
0766b489
PE
86502011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8651
31fd4b32
PE
8652 Integer overflow and signedness fixes (Bug#8873).
8653 A few related buffer overrun fixes, too.
8654
b79e8648
PE
8655 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8656
0766b489
PE
8657 * dispextern.h (struct face.stipple):
8658 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8659 (x_bitmap_mask, x_allocate_bitmap_record)
8660 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8661 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8662 (x_create_bitmap_from_xpm_data):
8663 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8664 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8665 (.bitmaps_last):
8666 * xfaces.c (load_pixmap):
8667 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8668 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8669 (.bitmaps_last, struct x_output.icon_bitmap):
8670 Use ptrdiff_t, not int, for bitmap indexes.
8671 (x_allocate_bitmap_record): Check for size overflow.
8672 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8673
b081724f
PE
8674 Use ptrdiff_t, not int, for overlay counts.
8675 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8676 * editfns.c (overlays_around, get_pos_property):
8677 * textprop.c (get_char_property_and_overlay):
8678 * xdisp.c (next_overlay_change, note_mouse_highlight):
8679 * xfaces.c (face_at_buffer_position):
21514da7
PE
8680 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8681 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8682 (Fnext_overlay_change, Fprevious_overlay_change)
8683 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8684 Use ptrdiff_t, not int, for sizes.
21514da7 8685 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8686
3de73e5e
PE
8687 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8688
2606c57b
PE
8689 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8690 (x_session_initialize): Do not assume string length fits in int.
8691
aaafe47a
PE
8692 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8693 This is unlikely, but can occur if DPI is outlandish.
8694
2674ddc8 8695 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8696 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8697
28154962
PE
8698 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8699 * xrdb.c (magic_file_p, search_magic_path):
8700 Omit last arg SUFFIX; it was always 0. All callers changed.
8701 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8702
7de51af5
PE
8703 * xfont.c (xfont_match): Avoid need for strlen.
8704
25ed6cc3
PE
8705 * xfns.c: Don't assume strlen fits in int.
8706 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8707
4eab31dd
PE
8708 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8709 not unsigned long, as we prefer signed integers. All callers changed.
8710 Detect integer overflow in repeat count.
8711 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8712 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8713
171e2a58
PE
8714 * termcap.c: Don't assume sizes fit in int and never overflow.
8715 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8716 (gobble_line): Check for size-calculation overflow.
8717
ad39faca 8718 * minibuf.c (Fread_buffer):
6e5bb2dc 8719 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8720 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8721 Don't assume string length fits in int.
8722
52c61c22 8723 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8724 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8725
b5b8c9e5
PE
8726 * font.c: Don't assume string length fits in int.
8727 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8728 Use ptrdiff_t, not int.
ccd6111c
PE
8729 (font_intern_prop): Don't assume string length fits in int.
8730 Don't assume integer property fits in fixnum.
8731 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8732
882f0d81 8733 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8734 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8735 Reformulate so as not to need the command string.
8736 Invoke gzip -cd rather than gunzip, as it's more portable.
8737 (lock_info_type, lock_file_1, lock_file):
8738 Don't assume pid_t and time_t fit in unsigned long.
8739 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8740 (current_lock_owner): Prefer signed type for sizes.
8741 Use memcpy, not strncpy, where memcpy is what is really wanted.
8742 Don't assume (via atoi) that time_t and pid_t fit in int.
8743 Check for time_t and/or pid_t out of range, e.g., via a network share.
8744 Don't alloca where an auto var works fine.
8745
93f4cf88
PE
8746 * fileio.c: Fix some integer overflow issues.
8747 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8748 Don't assume string length fits in int.
8749 (directory_file_name): Don't assume string length fits in long.
8750 (make_temp_name): Don't assume pid fits in int, or that its print
8751 length is less than 20.
8752
f3e92b69
PE
8753 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8754
1bfdaf10
PE
8755 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8756
35016e9a
PE
8757 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8758
3d1e65a1
PE
8759 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8760 We prefer signed integers, even for size calculations.
8761
0b963a93
PE
8762 * emacs.c: Don't assume string length fits in 'int'.
8763 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8764 (main): Don't invoke strlen when not needed.
8765
573f4b54
PE
8766 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8767 (XD_DEBUG_MESSAGE): Don't waste a byte.
8768
989f33ba
PE
8769 * callproc.c (getenv_internal_1, getenv_internal)
8770 (Fgetenv_internal):
965d34eb
PE
8771 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8772
e4d29b33
PE
8773 * lread.c (invalid_syntax): Omit length argument.
8774 All uses changed. This doesn't fix a bug, but it simplifies the
8775 code away from its former Hollerith-constant appearance, and it's
8776 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8777 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8778
eb49b136
PE
8779 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8780 This didn't break anything, but it didn't help either.
8781 It's confusing to put a bogus integer in a place where the actual
8782 value does not matter.
9f62aeb1 8783 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8784 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8785
15375a22
PE
8786 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8787 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8788 implementation.
b61cc01c
PE
8789 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8790 We prefer signed types, and the value cannot exceed the EMACS_INT
8791 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8792 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8793 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8794 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8795
53b2623d
PE
8796 * indent.c (sane_tab_width): New function.
8797 (current_column, scan_for_column, Findent_to, position_indentation)
8798 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8799 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8800
51cab52b 8801 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8802
f2ed8a70
PE
8803 * lisp.h (lint_assume): New macro.
8804 * composite.c (composition_gstring_put_cache):
8805 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8806
abe80cc6
PE
8807 * editfns.c, insdel.c:
8808 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8809
b02c740e
PE
8810 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8811
ebc96716
PE
8812 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8813
b4e50fa0 8814 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8815 Use much-faster test for byte-length change.
311d5d7c 8816 Don't assume string byte-length fits in 'int'.
a4cf38e4 8817 Check that character arg fits in 'int'.
85461888 8818 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8819
c0c1ee9f
PE
8820 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8821
a498d7f4
PE
8822 * fns.c (concat): Catch string overflow earlier.
8823 Do not rely on integer wraparound.
8824
51cab52b
PE
8825 * dispextern.h (struct it.overlay_strings_charpos)
8826 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8827 * xdisp.c (forward_to_next_line_start)
8828 (back_to_previous_visible_line_start)
8829 (reseat_at_next_visible_line_start, next_element_from_buffer):
8830 Don't arbitrarily truncate the value of 'selective' to int.
8831
76031fad
PE
8832 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8833
5eb55db9
PE
8834 * composite.c: Don't truncate sizes to 'int'.
8835 (composition_gstring_p, composition_reseat_it)
8836 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8837 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8838 not EMACS_UINT, for indexes.
5eb55db9 8839
0703a717
PE
8840 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8841
d6202519
PE
8842 * buffer.c: Include <verify.h>.
8843 (struct sortvec.priority, struct sortstr.priority):
8961a454 8844 Now EMACS_INT, not int.
c20998a7 8845 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8846 (struct sortstr.size, record_overlay_string)
8847 (struct sortstrlist.size, struct sortlist.used):
8848 Don't truncate size to int.
8849 (record_overlay_string): Check for size-calculation overflow.
d6202519 8850 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8851
d5a19415
JM
88522011-06-22 Jim Meyering <meyering@redhat.com>
8853
029529ac 8854 Don't leak an XBM-image-sized buffer
d5a19415
JM
8855 * image.c (xbm_load): Free the image buffer after using it.
8856
a9041e6c
PE
88572011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8858
8859 Port to Sun C.
8860 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8861 that Sun C diagnosed.
8862 * fns.c (secure_hash): Fix pointer signedness issue.
8863 * intervals.c (static_offset_intervals): New function.
8864 (offset_intervals): Use it.
8865
7f3f739f
LL
88662011-06-21 Leo Liu <sdl.web@gmail.com>
8867
8868 * deps.mk (fns.o):
8869 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8870 sha512.h.
8871
8872 * fns.c (secure_hash): Rename from crypto_hash_function and change
8873 the first arg to accept symbols.
5b66d427 8874 (Fsecure_hash): New primitive.
7f3f739f
LL
8875 (syms_of_fns): New symbols.
8876
76147d94
DD
88772011-06-20 Deniz Dogan <deniz@dogan.se>
8878
8879 * process.c (Fset_process_buffer): Clarify return value in
8880 docstring.
8881
7d7d0045
CY
88822011-06-18 Chong Yidong <cyd@stupidchicken.com>
8883
8884 * dispnew.c (add_window_display_history): Use BVAR.
8885
8886 * xdisp.c (debug_method_add): Use BVAR.
8887 (check_window_end, dump_glyph_matrix, dump_glyph)
8888 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8889
8890 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8891 Likewise.
8892
8893 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8894 check till after the cache is created in init_frame_faces.
8895
ff2bc410
SM
88962011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8897
8898 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8899
28177add
PE
89002011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8901
dd3482fe
PE
8902 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8903 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8904 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8905
393d71f3 8906 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8907 * fileio.c (Finsert_file_contents):
8908 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8909 Remove the old (too-loose) buffer overflow checks.
8910 They weren't needed, since make_gap checks for buffer overflow.
8911 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8912 The old code merely checked for Emacs fixnum overflow, and relied
8913 on undefined (wraparound) behavior. The new code avoids undefined
8914 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8915
2e6813b0 8916 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8917 Tune. Don't use wider integers than needed. Don't use alloca.
8918 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8919
599a9e4f
PE
8920 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8921
99561444
PE
8922 * insdel.c, lisp.h (buffer_overflow): New function.
8923 (insert_from_buffer_1, replace_range, replace_range_2):
8924 * insdel.c (make_gap_larger):
8925 * editfns.c (Finsert_char):
8926 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8927
28177add
PE
8928 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8929
e69dafad
PE
89302011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8931
4baa020d 8932 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8933
b1c46f02
PE
8934 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8935 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8936
e69dafad
PE
8937 * fileio.c: Don't assume EMACS_INT fits in off_t.
8938 (emacs_lseek): New static function.
8939 (Finsert_file_contents, Fwrite_region): Use it.
8940 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8941
566684ea
PE
8942 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8943
e6966cd6
PE
8944 * fns.c: Don't overflow int when computing a list length.
8945 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8946 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8947 truncation on 64-bit hosts. Check for QUIT every
8948 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8949 faster and is responsive enough.
8950 (Flength): Report an error instead of overflowing an integer.
8951 (Fsafe_length): Return a float if the value is not representable
8952 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8953 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8954 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8955
dd0b0efb
PE
8956 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8957 (header_size, word_size): New constants.
8958 (allocate_vectorlike): Don't check size overflow here.
8959 (allocate_vector): Check it here instead, since this is the only
8960 caller of allocate_vectorlike that could cause overflow.
8961 Check that the new vector's length is representable as a fixnum.
8962
86fe5cfe
PE
8963 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8964 The previous code was bogus. For example, next_almost_prime (32)
8965 returned 39, which is undesirable as it is a multiple of 3; and
8966 next_almost_prime (24) returned 25, which is a multiple of 5 so
8967 why was the code bothering to check for multiples of 7?
8968
80e88859
PE
8969 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8970
4a2f0ad6
PE
8971 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8972
f66c7cf8
PE
8973 Variadic C functions now count arguments with ptrdiff_t.
8974 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8975 Back then I didn't know that the Emacs coding style prefers signed int.
8976 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8977 were being counted with int, which may truncate counts on 64-bit
8978 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8979 * lisp.h (struct Lisp_Subr.function.aMANY)
8980 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8981 Arg counts are now ptrdiff_t, not size_t.
8982 All variadic functions and their callers changed accordingly.
8983 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8984 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8985 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8986 * callint.c (Fcall_interactively): Check arg count for overflow,
8987 to avoid potential buffer overrun. Use signed char, not 'int',
8988 for 'varies' array, so that we needn't bother to check its size
8989 calculation for overflow.
8990 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8991 * eval.c (apply_lambda):
8992 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8993 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8994 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8995
a1759b76
PE
8996 * callint.c (Fcall_interactively): Don't use index var as event count.
8997
d96be9fc
PE
8998 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8999 * mem-limits.h (SIZE): Remove; no longer used.
9000
a690a978 9001 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9002
578c21e6
PE
9003 Remove unnecessary casts.
9004 * xterm.c (x_term_init):
9005 * xfns.c (x_set_border_pixel):
9006 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9007 These aren't needed now that we assume ANSI C.
9008
96f53c6c
PE
9009 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9010 It's more likely to cause problems (due to unsigned overflow)
9011 than to cure them.
9012
83c77d31
PE
9013 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9014
ee2079f1
PE
9015 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9016
6da65536
PE
9017 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9018
7147c4a4
PE
9019 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9020
193e32d9
PE
9021 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9022
e5533da6
PE
9023 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9024
9910e595
PE
9025 GLYPH_CODE_FACE returns EMACS_INT, not int.
9026 * dispextern.h (merge_faces):
9027 * xfaces.c (merge_faces):
01103c44
PE
9028 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9029 Don't assume EMACS_INT fits in int.
9910e595 9030
2638320e
PE
9031 * character.h (CHAR_VALID_P): Remove unused parameter.
9032 * fontset.c, lisp.h, xdisp.c: All uses changed.
9033
045eb8d9
PE
9034 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9035
c1f134b5
PE
9036 * fns.c (concat): Minor tuning based on overflow analysis.
9037 This doesn't fix any bugs. Use int to hold character, instead
9038 of constantly refetching from Emacs object. Use XFASTINT, not
9039 XINT, for value known to be a character. Don't bother comparing
9040 a single byte to 0400, as it's always less.
9041
395fcb93 9042 * floatfns.c (Fexpt):
327eeec8
PE
9043 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9044
abbd3d23
PE
9045 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9046 for characters.
9047
684a03ef
PE
9048 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9049
0fed43f3
PE
9050 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9051 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9052 incorrectly succeed when S was a string, because 4294967386 was
9053 truncated before it was used.
9054
8fd02eb7
PE
9055 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9056 Otherwise, an out-of-range integer could cause undefined behavior
9057 on a 64-bit host.
9058
f8c86b69
PE
9059 * composite.c: Use int, not EMACS_INT, for characters.
9060 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9061 EMACS_INT, for values that are known to be in character range.
9062 This doesn't fix any bugs but is the usual style inside Emacs and
9063 may generate better code on 32-bit machines.
9064
34206dd2
PE
9065 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9066 This is for reasons similar to the recent CHAR_STRING fix.
9067 * charset.c (Fencode_char): Check that character arg is actually
9068 a character. Pass an int to ENCODE_CHAR.
9069 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9070 wider than 'int', as a compile-time check to prevent future regressions
9071 in this area.
9072
c5958d4c 9073 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9074
9075 Make sure a 64-bit char is never passed to CHAR_STRING.
9076 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9077 by silently ignoring the top 32 bits, allowing some values
9078 that were far too large to be valid characters.
9079 * character.h: Include <verify.h>.
9080 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9081 arguments are no wider than unsigned, as a compile-time check
9082 to prevent future regressions in this area.
9083 * data.c (Faset):
01103c44 9084 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9085 (Fsubst_char_in_region):
9086 * fns.c (concat):
9087 * xdisp.c (decode_mode_spec_coding):
9088 Adjust to CHAR_STRING's new requirement.
9089 * editfns.c (Finsert_char, Fsubst_char_in_region):
9090 * fns.c (concat): Check that character args are actually
9091 characters. Without this test, these functions did the wrong
9092 thing with wildly out-of-range values on 64-bit hosts.
9093
d37ca623
PE
9094 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9095 These casts should not be needed on 32-bit hosts, either.
9096 * keyboard.c (read_char):
9097 * lread.c (Fload): Remove casts to unsigned.
9098
ea204efb
PE
9099 * lisp.h (UNSIGNED_CMP): New macro.
9100 This fixes comparison bugs on 64-bit hosts.
9101 (ASCII_CHAR_P): Use it.
9102 * casefiddle.c (casify_object):
01103c44 9103 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9104 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9105 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9106 * dispextern.h (FACE_FROM_ID):
9107 * keyboard.c (read_char): Use UNSIGNED_CMP.
9108
41cb286c
PE
9109 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9110 not to EMACS_INT, to avoid GCC warning.
9111
4a1b9832
PE
9112 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9113
55daad71
PE
9114 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9115 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9116 isn't needed on 32-bit machines.
8f95c75c 9117
01103c44
PE
9118 * buffer.c (Fgenerate_new_buffer_name):
9119 Use EMACS_INT for count, not int.
0ceccced 9120 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9121
9122 * data.c (Qcompiled_function): Now static.
9123
c6f072e7
PE
9124 * window.c (window_body_lines): Now static.
9125
20ce5912
PE
9126 * image.c (gif_load): Rename local to avoid shadowing.
9127
9c4c5f81
PE
9128 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9129 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9130 * alloc.c (make_save_value): Integer argument is now of type
9131 ptrdiff_t, not int.
9132 (mark_object): Use ptrdiff_t, not int.
9133 * lisp.h (pD): New macro.
9134 * print.c (print_object): Use it.
9135
c0c5c8ae
PE
9136 * alloc.c: Use EMACS_INT, not int, to count objects.
9137 (total_conses, total_markers, total_symbols, total_vector_size)
9138 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9139 (total_free_floats, total_floats, total_free_intervals)
9140 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9141 Now EMACS_INT, not int. All uses changed.
9142 (Fgarbage_collect): Compute overall total using a double, so that
9143 integer overflow is less likely to be a problem. Check for overflow
9144 when converting back to an integer.
5a25e253
PE
9145 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9146 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9147 These were 'int' variables that could overflow on 64-bit hosts;
9148 they were never used, so remove them instead of repairing them.
211a0b2a 9149 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9150 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9151 Previously, this ceilinged at INT_MAX, but that doesn't work on
9152 64-bit machines.
e46bb31a 9153 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9154
c78baabf 9155 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9156 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9157 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9158 when a (possibly-narrower) signed value would do just as well.
9159 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9160
c9d624c6
PE
9161 * alloc.c: Catch some string size overflows that we were missing.
9162 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9163 for convenience in STRING_BYTES_MAX.
9164 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9165 The definition here is exact; the one in lisp.h was approximate.
9166 (allocate_string_data): Check for string overflow. This catches
9167 some instances we weren't catching before. Also, it catches
9168 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9169 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9170 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9171
c9d624c6
PE
9172 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9173 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9174 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9175
353032ce
PE
9176 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9177
2bccce07
PE
9178 * alloc.c (Fmake_string): Check for out-of-range init.
9179
0ac30604
SM
91802011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9181
9182 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9183
c195f2de
JD
91842011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9185
9186 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9187 xg_get_default_scrollbar_width.
9188
9189 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9190 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9191 (style_changed_cb): Call update_theme_scrollbar_width and call
9192 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9193 all frames (Bug#8505).
9194 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9195 Call gtk_window_set_resizable if HAVE_GTK3.
9196 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9197 and height if HAVE_GTK3 (Bug#8505).
9198 (scroll_bar_width_for_theme): New variable.
9199 (update_theme_scrollbar_width): New function.
9200 (xg_get_default_scrollbar_width): Move code to
9201 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9202 (xg_initialize): Call update_theme_scrollbar_width.
9203
9204 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9205
9206 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9207
e10ac9f1
MR
92082011-06-12 Martin Rudalics <rudalics@gmx.at>
9209
9210 * frame.c (make_frame): Call other_buffer_safely instead of
9211 other_buffer.
9212
9213 * window.c (temp_output_buffer_show): Call display_buffer with
9214 second argument Vtemp_buffer_show_specifiers and reset latter
9215 immediately after the call.
9216 (Vtemp_buffer_show_specifiers): New variable.
9217 (auto_window_vscroll_p, next_screen_context_lines)
9218 (Vscroll_preserve_screen_position): Remove leading asterisks from
9219 doc-strings.
9220
2d3c217e 92212011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9222
7b7f97e8 9223 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9224 * buffer.c (Qclone_number): Remove for now, as it's unused.
9225 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9226 (record_buffer): Remove unused local.
9227 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9228 (set_frame_buffer_list): Remove; unused.
9229 * frame.h (other_visible_frames): Remove decl.
9230 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9231 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9232 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9233 if HAVE_GPM.
9234 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9235 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9236 Define only if HAVE_GPM.
9237 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9238 (update_hints_inhibit): Remove; never set. All uses removed.
9239 * widgetprv.h (emacsFrameClassRec): Remove decl.
9240 * window.c (delete_deletable_window): Now returns void, since it
9241 wasn't returning anything.
9242 (compare_window_configurations): Remove unused locals.
9243 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9244 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9245 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9246 the same widths as pointers. This follows up on the 2011-05-06 patch.
9247 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9248 * xterm.h: Likewise.
9249 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9250
1384b89e
JB
92512011-06-12 Juanma Barranquero <lekktu@gmail.com>
9252
9253 * makefile.w32-in: Update dependencies.
9254 (LISP_H): Add lib/intprops.h.
9255
1100a63c
CY
92562011-06-11 Chong Yidong <cyd@stupidchicken.com>
9257
9258 * image.c (gif_load): Add animation frame delay to the metadata.
9259 (syms_of_image): Use DEFSYM. New symbol `delay'.
9260
6198ccd0
MR
92612011-06-11 Martin Rudalics <rudalics@gmx.at>
9262
9263 * window.c (delete_deletable_window): Re-add.
9264 (Fset_window_configuration): Rewrite to handle dead buffers and
9265 consequently deletable windows.
9266 (window_tree, Fwindow_tree): Remove. Supply functionality in
9267 window.el.
9268 (compare_window_configurations): Simplify code.
9269
b6e3633c
AS
92702011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9271
1ab0dee5
AS
9272 * image.c (imagemagick_load_image): Fix type mismatch.
9273 (Fimagemagick_types): Likewise.
9274
b6e3633c
AS
9275 * window.h (replace_buffer_in_windows): Declare.
9276
9397e56f
MR
92772011-06-11 Martin Rudalics <rudalics@gmx.at>
9278
9279 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9280 Qclone_number. Remove external declaration of Qdelete_window.
9281 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9282 code.
640c8776
SM
9283 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9284 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9285 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9286 buffer list implementation.
9287 (other_buffer_safely): New function.
9288 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9289 calls to replace_buffer_in_windows and
9290 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9291 if allowed.
9292 (record_buffer): Inhibit quitting and rewrite using quittable
9293 functions. Run Qbuffer_list_update_hook if allowed.
9294 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9295 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9296 Move switch-to-buffer to window.el.
9397e56f
MR
9297 (bury-buffer): Move to window.el.
9298 (Vbuffer_list_update_hook): New variable.
9299
9300 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9301 section.
9302
9303 * window.h (resize_frame_windows): Move up in code.
9304 (Fwindow_frame): Remove EXFUN.
9305 (replace_buffer_in_all_windows): Remove prototype.
9306 (replace_buffer_in_windows_safely): Add prototype.
9307
9308 * window.c: Declare Qdelete_window static again. Move down
9309 declaration of select_count.
9310 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9311 (Fother_window): Move to window.el.
9312 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9313 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9314 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9315 window.el.
9316 (replace_buffer_in_windows): Implement by calling
9317 Qreplace_buffer_in_windows.
9318 (replace_buffer_in_all_windows): Remove with some functionality
9319 moved into replace_buffer_in_windows_safely.
9320 (replace_buffer_in_windows_safely): New function.
9321 (select_window_norecord, select_frame_norecord): Move in front
9322 of run_window_configuration_change_hook. Remove now obsolete
9323 declarations.
640c8776
SM
9324 (Fset_window_buffer): Rewrite doc-string.
9325 Call Qrecord_window_buffer.
9397e56f
MR
9326 (keys_of_window): Move binding for other-window to window.el.
9327
b50691aa
CY
93282011-06-11 Chong Yidong <cyd@stupidchicken.com>
9329
9330 * dispextern.h (struct image): Replace data member, whose int_val
9331 and ptr_val fields were not used by anything, with a single
9332 lisp_val object.
9333
9334 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9335 (gif_clear_image, gif_load, imagemagick_load_image)
9336 (gs_clear_image, gs_load): Callers changed.
9337
3f754b86
PE
93382011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9339
cca69397
PE
9340 * buffer.h: Include <time.h>, for time_t.
9341 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9342
109e28d0
PE
9343 Fix minor problems found by static checking.
9344
60737f02
PE
9345 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9346
4b66faf3
PE
9347 Make identifiers static if they are not used in other modules.
9348 * data.c (Qcompiled_function, Qframe, Qvector):
9349 * image.c (QimageMagick, Qsvg):
9350 * minibuf.c (Qmetadata):
9351 * window.c (resize_window_check, resize_root_window): Now static.
9352 * window.h (resize_window_check, resize_root_window): Remove decls.
9353
109e28d0
PE
9354 * window.c (window_deletion_count, delete_deletable_window):
9355 Remove; unused.
46a4ce9e
PE
9356 (window_body_lines): Now static.
9357 (Fdelete_other_windows_internal): Mark vars as initialized.
9358 Make sure 'resize_failed' is initialized.
9359 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9360 (resize_window_apply): Remove unused local.
9361 * window.h (delete_deletable_window): Remove decl.
9362
109e28d0 9363 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9364 (imagemagick_load_image): Fix pointer signedness problem by changing
9365 last arg from unsigned char * to char *. All uses changed.
9366 Also, fix a local for similar reasons.
9367 Remove unused locals. Remove locals to avoid shadowing.
9368 (fn_rsvg_handle_free): Remove; unused.
9369 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9370 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9371
3f754b86
PE
9372 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9373
2547adb1
CY
93742011-06-10 Chong Yidong <cyd@stupidchicken.com>
9375
9376 * image.c (gif_load): Fix omitted cast error introduced by
9377 2011-06-06 change.
9378
2c8e37d4
MR
93792011-06-10 Martin Rudalics <rudalics@gmx.at>
9380
9381 * window.h (resize_proportionally, orig_total_lines)
9382 (orig_top_line): Remove from window structure.
9383 (set_window_height, set_window_width, change_window_heights)
9384 (Fdelete_window): Remove prototypes.
9385 (resize_frame_windows): Remove duplicate declaration.
9386
440a42e3
EZ
93872011-06-10 Eli Zaretskii <eliz@gnu.org>
9388
9389 * window.h (resize_frame_windows, resize_window_check)
9390 (delete_deletable_window, resize_root_window)
9391 (resize_frame_windows): Declare prototypes.
9392
9393 * window.c (resize_window_apply): Make definition be "static" to
9394 match the prototype.
9395
562dd5e9
MR
93962011-06-10 Martin Rudalics <rudalics@gmx.at>
9397
9398 * window.c: Remove declarations of Qwindow_size_fixed,
9399 window_min_size_1, window_min_size_2, window_min_size,
9400 size_window, window_fixed_size_p, enlarge_window, delete_window.
9401 Remove static from declaration of Qdelete_window, it's
9402 temporarily needed by Fbury_buffer.
9403 (replace_window): Don't assign orig_top_line and
9404 orig_total_lines.
9405 (Fdelete_window, delete_window): Remove. Window deletion is
9406 handled by window.el.
640c8776
SM
9407 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9408 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9409 (Fdelete_other_windows): Remove. Deleting other windows is
9410 handled by window.el.
9411 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9412 handled in window.el.
9413 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9414 Window minimum sizes are handled in window.el.
9415 (shrink_windows, size_window, set_window_height)
9416 (set_window_width, change_window_heights, window_height)
9417 (window_width, CURBEG, CURSIZE, enlarge_window)
9418 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9419 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9420 handled in window.el.
9421 (make_dummy_parent): Rename to make_parent_window and give it a
9422 second argument horflag.
9423 (make_window): Don't set resize_proportionally any more.
9424 (Fsplit_window): Remove. Windows are split in window.el.
9425 (save_restore_action, save_restore_orig_size)
9426 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9427 Resize mini windows in window.el.
9428 (grow_mini_window, shrink_mini_window): Implement by calling
9429 Qresize_root_window_vertically, resize_window_check and
9430 resize_window_apply.
640c8776
SM
9431 (saved_window, Fset_window_configuration, save_window_save):
9432 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9433 resize_proportionally.
9434 (window_min_height, window_min_width): Move to window.el.
9435 (keys_of_window): Move bindings for delete-other-windows,
9436 split-window, delete-window and enlarge-window to window.el.
9437
9438 * buffer.c: Temporarily extern Qdelete_window.
9439 (Fbury_buffer): Temporarily call Qdelete_window instead of
9440 Fdelete_window (Fbury_buffer will move to window.el soon).
9441
9442 * frame.c (set_menu_bar_lines_1): Remove code handling
9443 orig_top_line and orig_total_lines.
9444
9445 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9446 set_window_height but set heights directly.
9447 (change_frame_size_1): Use resize_frame_windows.
9448
9449 * xdisp.c (init_xdisp): Don't use set_window_height but set
9450 heights directly.
9451
640c8776
SM
9452 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9453 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9454 run_window_configuration_change_hook.
9455
9456 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9457 instead of change_window_heights and run
9458 run_window_configuration_change_hook.
9459
1a13852e
MR
94602011-06-09 Martin Rudalics <rudalics@gmx.at>
9461
9462 * window.c (replace_window): Rename second argument REPLACEMENT to
9463 NEW. New third argument SETFLAG. Rewrite.
9464 (delete_window, make_dummy_parent): Call replace_window with
9465 third argument 1.
9466 (window_list_1): Move down in code.
9467 (run_window_configuration_change_hook): Move set_buffer part
9468 before select_frame_norecord part in order to unwind correctly.
9469 Rename count1 to count.
9470 (recombine_windows, delete_deletable_window, resize_root_window)
9471 (Fdelete_other_windows_internal)
9472 (Frun_window_configuration_change_hook, make_parent_window)
9473 (resize_window_check, resize_window_apply, Fresize_window_apply)
9474 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9475 (Fdelete_window_internal, Fresize_mini_window_internal):
9476 New functions.
1a13852e
MR
9477 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9478
f3d1777e
MR
94792011-06-08 Martin Rudalics <rudalics@gmx.at>
9480
496e208e
MR
9481 * window.h (window): Add some new members to window structure -
9482 normal_lines, normal_cols, new_total, new_normal, clone_number,
9483 splits, nest, prev_buffers, next_buffers.
9484 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9485 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9486
f3d1777e
MR
9487 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9488 Remove.
496e208e
MR
9489 (make_dummy_parent): Set new members of windows structure.
9490 (make_window): Move down in code. Handle new members of window
9491 structure.
9492 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9493 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9494 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9495 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9496 (Fset_window_next_buffers, Fset_window_clone_number):
9497 New functions.
496e208e
MR
9498 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9499 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9500 Doc-string fixes.
9501 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9502 Argument WINDOW can be now internal window too.
9503 (Fwindow_use_time): Move up in code.
9504 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9505 Rewrite doc-string.
9506 (Fset_window_configuration, saved_window)
9507 (Fcurrent_window_configuration, save_window_save): Handle new
9508 members of window structure.
b9e809c2
MR
9509 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9510 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9511 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9512 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9513 Qget_mru_window, Qresize_root_window,
9514 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9515 Qauto_buffer_name; staticpro them.
f3d1777e 9516
abde8f8c
MR
95172011-06-07 Martin Rudalics <rudalics@gmx.at>
9518
9519 * window.c (Fwindow_total_size, Fwindow_left_column)
9520 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9521 (Fwindow_list_1): New functions.
9522 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9523 (Fwindow_width, Fscroll_left, Fscroll_right):
9524 Use window_body_cols instead of window_box_text_cols.
9525 (delete_window, Fset_window_configuration):
9526 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9527 (delete_all_subwindows): Take a window as argument and not a
9528 structure. Rewrite.
190b47e6
MR
9529 (window_loop): Remove handling of GET_LRU_WINDOW and
9530 GET_LARGEST_WINDOW.
9531 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9532
9533 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9534 window_box_text_cols. delete_all_subwindows now takes a
9535 Lisp_Object as argument.
abde8f8c 9536
640c8776
SM
9537 * indent.c (compute_motion, Fcompute_motion):
9538 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9539
fa8a67e6
MR
9540 * frame.c (delete_frame): Call delete_all_subwindows with root
9541 window as argument.
9542
a54e3482
DC
95432011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9544
9545 * fns.c (Fputhash): Document return value.
9546
60002bf5
CY
95472011-06-06 Chong Yidong <cyd@stupidchicken.com>
9548
9549 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9550
0c671da6 95512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9552
b862a52a 9553 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9554
be44ca6c
PE
9555 Check for overflow when converting integer to cons and back.
9556 * charset.c (Fdefine_charset_internal, Fdecode_char):
9557 Use cons_to_unsigned to catch overflow.
9558 (Fencode_char): Use INTEGER_TO_CONS.
9559 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9560 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9561 * data.c (long_to_cons, cons_to_long): Remove.
9562 (cons_to_unsigned, cons_to_signed): New functions.
9563 These signal an error for invalid or out-of-range values.
9564 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9565 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9566 * font.c (Ffont_variation_glyphs):
9567 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9568 * lisp.h: Include <intprops.h>.
9569 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9570 (cons_to_signed, cons_to_unsigned): New decls.
9571 (long_to_cons, cons_to_long): Remove decls.
9572 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9573 (Fprimitive_undo): Use CONS_TO_INTEGER.
9574 * xfns.c (Fx_window_property): Likewise.
9575 * xselect.c: Include <limits.h>.
9576 (x_own_selection, selection_data_to_lisp_data):
9577 Use INTEGER_TO_CONS.
9578 (x_handle_selection_request, x_handle_selection_clear)
9579 (x_get_foreign_selection, Fx_disown_selection_internal)
9580 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9581 (lisp_data_to_selection_data): Use cons_to_unsigned.
9582 (x_fill_property_data): Use cons_to_signed.
9583 Report values out of range.
9584
d1f3d2af
PE
9585 Check for buffer and string overflow more precisely.
9586 * buffer.h (BUF_BYTES_MAX): New macro.
9587 * lisp.h (STRING_BYTES_MAX): New macro.
9588 * alloc.c (Fmake_string):
9589 * character.c (string_escape_byte8):
9590 * coding.c (coding_alloc_by_realloc):
9591 * doprnt.c (doprnt):
9592 * editfns.c (Fformat):
9593 * eval.c (verror):
9594 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9595 since they may not be the same number.
9596 * editfns.c (Finsert_char):
9597 * fileio.c (Finsert_file_contents):
9598 Likewise for BUF_BYTES_MAX.
9599
dd52fcea
PE
9600 * image.c: Use ptrdiff_t, not int, for sizes.
9601 (slurp_file): Switch from int to ptrdiff_t.
9602 All uses changed.
9603 (slurp_file): Check that file size fits in both size_t (for
9604 malloc) and ptrdiff_t (for sanity and safety).
9605
7f9bbdbb
PE
9606 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9607 if b->modtime has its maximal value.
9608
dfe18f82
PE
9609 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9610
84acfcf0
PE
9611 Don't assume time_t can fit into int.
9612 * buffer.h (struct buffer.modtime): Now time_t, not int.
9613 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9614 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9615
ccd9a01a
PE
9616 Minor fixes for signed vs unsigned integers.
9617 * character.h (MAYBE_UNIFY_CHAR):
9618 * charset.c (maybe_unify_char):
9619 * keyboard.c (read_char, reorder_modifiers):
9620 XINT -> XFASTINT, since the integer must be nonnegative.
9621 * ftfont.c (ftfont_spec_pattern):
9622 * keymap.c (access_keymap, silly_event_symbol_error):
9623 XUINT -> XFASTINT, since the integer must be nonnegative.
9624 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9625 since it makes no difference and we prefer signed.
9626 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9627 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9628 nonnegative.
9629
d6d100dd
SM
96302011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9631
9632 * window.h (Fwindow_frame): Declare.
9633
2b6148e4
PE
96342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9635
9636 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9637 (SPARE_MEMORY): Always define.
9638 (LARGE_REQUEST): Remove.
9639 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9640
f230ecc9
MR
96412011-06-06 Martin Rudalics <rudalics@gmx.at>
9642
727e958e
MR
9643 * lisp.h: Move EXFUNS for Fframe_root_window,
9644 Fframe_first_window and Fset_frame_selected_window to window.h.
9645
9646 * window.h: Move EXFUNS for Fframe_root_window,
9647 Fframe_first_window and Fset_frame_selected_window here from
9648 lisp.h.
9649
9650 * frame.c (Fwindow_frame, Fframe_first_window)
9651 (Fframe_root_window, Fframe_selected_window)
9652 (Fset_frame_selected_window): Move to window.c.
9653 (Factive_minibuffer_window): Move to minibuf.c.
9654 (Fother_visible_frames_p): New function.
9655
9656 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9657
f230ecc9
MR
9658 * window.c (decode_window, decode_any_window): Move up in code.
9659 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9660 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9661 (Fwindow_buffer): Move up and rewrite doc-string.
9662 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9663 (Fwindow_prev): New functions.
727e958e
MR
9664 (Fwindow_frame): Move here from frame.c. Accept any window as
9665 argument.
9666 (Fframe_root_window, Fframe_first_window)
9667 (Fframe_selected_window): Move here from frame.c. Accept frame
9668 or arbitrary window as argument. Update doc-strings.
9669 (Fminibuffer_window): Move up in code.
9670 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9671 (Fset_frame_selected_window): Move here from frame.c.
9672 Marginal rewrite.
727e958e
MR
9673 (Fselected_window, select_window, Fselect_window): Move up in
9674 code. Minor doc-string fixes.
f230ecc9 9675
4d09bcf6
PE
96762011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9677
9678 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9679 Do not assume that spare memory exists; that assumption is valid
9680 only if SYSTEM_MALLOC.
9681 (LARGE_REQUEST): New macro, so that the issue of large requests
9682 is separated from the issue of spare memory.
9683
810928a2
AS
96842011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9685
172418ad
AS
9686 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9687 format. (Bug#8806)
9688
43f862f7
AS
9689 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9690
810928a2
AS
9691 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9692 before statements.
9693
a059fe24
JD
96942011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9695
9696 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9697
9698 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9699
9700 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9701 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9702
989bf368
JB
97032011-06-05 Juanma Barranquero <lekktu@gmail.com>
9704
9705 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9706
4b80f674
CY
97072011-06-04 Chong Yidong <cyd@stupidchicken.com>
9708
9709 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9710 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9711 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9712 New error handlers.
4b80f674
CY
9713 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9714 Obey Vx_select_enable_clipboard_manager. Catch errors in
9715 x_clipboard_manager_save (Bug#8779).
9716 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9717 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9718
99a33b77 97192011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9720
9721 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9722
99a33b77 97232011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9724
9725 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9726 in the current matrix if keep_current_p is non-zero.
9727
8264569d
EZ
97282011-06-04 Eli Zaretskii <eliz@gnu.org>
9729
9730 * bidi.c (bidi_level_of_next_char): Fix last change.
9731
57f97249
EZ
97322011-06-03 Eli Zaretskii <eliz@gnu.org>
9733
fec2107c 9734 Support bidi reordering of text covered by display properties.
57f97249 9735
fec2107c
EZ
9736 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9737 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9738 (bidi_cache_search, bidi_cache_iterator_state)
9739 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9740 (bidi_level_of_next_char, bidi_move_to_visually_next):
9741 Support character positions inside a run of characters covered by a
fec2107c
EZ
9742 display string.
9743 (bidi_paragraph_init, bidi_resolve_explicit_1)
9744 (bidi_level_of_next_char): Call bidi_fetch_char and
9745 bidi_fetch_char_advance instead of FETCH_CHAR and
9746 FETCH_CHAR_ADVANCE.
9747 (bidi_init_it): Initialize new members.
9748 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9749 definitions.
9750 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9751 instead of using explicit *_CHAR codes.
d6d100dd
SM
9752 (bidi_resolve_explicit, bidi_resolve_weak):
9753 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9754 bidirectional text is supported only in multibyte buffers.
9755 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9756 it to initialize the frame_window_p member of struct bidi_it.
9757 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9758 (bidi_resolve_explicit, bidi_resolve_weak)
9759 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9760 bidi_it->nchars is non-positive.
9761 (bidi_level_of_next_char): Don't try to lookup the cache for the
9762 next/previous character if nothing is cached there yet, or if we
9763 were just reseat()'ed to a new position.
c40e2fb2 9764
0e14fe90
EZ
9765 * xdisp.c (set_cursor_from_row): Set start and stop points
9766 according to the row's direction when priming the loop that looks
9767 for the glyph on which to display cursor.
9768 (single_display_spec_intangible_p): Function deleted.
9769 (display_prop_intangible_p): Reimplement to call
9770 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9771 Accept 3 additional arguments needed by handle_display_spec.
9772 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9773 values: lists, `(when COND...)' forms, etc.
9774 (single_display_spec_string_p): Support property values that are
9775 lists with the argument STRING its top-level element.
9776 (display_prop_string_p): Fix the condition for processing a
9777 property that is a list to be consistent with handle_display_spec.
fec2107c 9778 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9779 last portion of handle_display_prop.
9780 (compute_display_string_pos): Accept additional argument
9781 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9782 value of a `display' property is a "replacing spec".
9783 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9784 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9785 the display property, but just return a value indicating whether
9786 the display property will replace the characters it covers.
9787 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9788 frame_window_p members of struct bidi_it.
d6d100dd
SM
9789 (compute_display_string_pos, compute_display_string_end):
9790 New functions.
fec2107c
EZ
9791 (push_it): Accept second argument POSITION, where pop_it should
9792 jump to continue iteration.
9793 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9794
fec2107c
EZ
9795 * keyboard.c (adjust_point_for_property): Adjust the call to
9796 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9797
9798 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9799 (bidi_init_it): Update prototypes.
9800 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9801 (compute_display_string_pos, compute_display_string_end):
9802 Declare prototypes.
fec2107c
EZ
9803 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9804 EMACS_INT.
fc6f18ce 9805
40087514 98062011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9807
57f53182
PE
9808 Malloc failure behavior now depends on size of allocation.
9809 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9810 * lisp.h: Change signatures accordingly.
9811 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9812 All callers changed. (Bug#8762)
9813
9814 * gnutls.c: Use Emacs's memory allocators.
9815 Without this change, the gnutls library would invoke malloc etc.
9816 directly, which causes problems on non-SYNC_INPUT hosts, and which
9817 runs afoul of improving memory_full behavior. (Bug#8761)
9818 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9819 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9820 xfree instead of the default malloc, realloc, free.
9821 (Fgnutls_boot): No need to check for memory allocation failure,
9822 since xmalloc does that for us.
9823
ac32cd99 9824 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9825 * category.c (hash_get_category_set):
9826 * ccl.c (ccl_driver):
9827 * charset.c (Fdefine_charset_internal):
9828 * charset.h (struct charset.hash_index):
9829 * composite.c (get_composition_id, gstring_lookup_cache)
9830 (composition_gstring_put_cache):
9831 * composite.h (struct composition.hash_index):
9832 * dispextern.h (struct image.hash):
9833 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9834 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9835 (hashfn_equal, hashfn_user_defined, make_hash_table)
9836 (maybe_resize_hash_table, hash_lookup, hash_put)
9837 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9838 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9839 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9840 * image.c (make_image, search_image_cache, lookup_image)
9841 (xpm_put_color_table_h):
9842 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9843 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9844 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9845 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9846 * alloc.c (allocate_vectorlike):
9847 Check for overflow in vector size calculations.
9848 * ccl.c (ccl_driver):
9849 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9850 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9851 need to be updated by these changes.
40087514
PE
9852 * fns.c (make_hash_table, maybe_resize_hash_table):
9853 Check for integer overflow with large hash tables.
0de4bb68
PE
9854 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9855 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9856 (SXHASH_REDUCE): New macro.
9857 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9858 Use it instead of discarding useful hash info with large hash values.
9859 (sxhash_float): New function.
9860 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9861 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9862 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9863 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9864 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9865 Adjust signatures to match updated version of code.
9866 (consing_since_gc): Now EMACS_INT, since a single hash table can
9867 use more than INT_MAX bytes.
9868
698d32e2
DN
98692011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9870
9871 Make it possible to build with GCC-4.6+ -O2 -flto.
9872
9873 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9874
fd6fa53f
SM
98752011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9876
9877 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9878 Call minibuffer-inactive-mode.
9879
864db017
JB
98802011-05-31 Juanma Barranquero <lekktu@gmail.com>
9881
9882 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9883 Update dependencies.
9884
2ad0baf4
DN
98852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9886
9887 * data.c (init_data): Remove code for UTS, this system is not
9888 supported anymore.
9889
4fcc2638
DN
98902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9891
9892 Don't force ./temacs to start in terminal mode.
9893
9894 * frame.c (make_initial_frame): Initialize faces in all cases, not
9895 only when CANNOT_DUMP is defined.
9896 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9897
c56e0fd5
DN
98982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9899
9900 * dispnew.c (add_window_display_history): Use const for the string
9901 pointer. Remove declaration, not needed.
9902
333d54da 99032011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9904
55d4c1b2 9905 Use 'inline', not 'INLINE'.
333d54da 9906 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9907 * alloc.c, fontset.c (INLINE): Remove.
9908 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9909 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9910 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9911 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9912 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9913
738db178
DN
99142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9915
9916 Make it possible to run ./temacs.
9917
9918 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9919 syms_of_callproc does the same thing. Remove test for
9920 "initialized", do it in the caller.
9921 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9922
620c53a6
SM
99232011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9924
9925 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9926 (read_minibuf): Use get_minibuffer.
9927 (syms_of_minibuf): Use DEFSYM.
9928 (Qmetadata): New var.
9929 * data.c (Qbuffer): Don't make it static.
9930 (syms_of_data): Use DEFSYM.
9931
e003a292
PE
99322011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9933
9934 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9935 (CCL_CODE_MIN): New macro.
9936
ed008a6d
PE
99372011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9938
3687c2ef
PE
9939 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9940
ed008a6d
PE
9941 * eval.c (Qdebug): Now static.
9942 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9943 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9944 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9945
d66c4c7c
CY
99462011-05-29 Chong Yidong <cyd@stupidchicken.com>
9947
9948 * image.c: Various fixes to ImageMagick code comments.
9949 (Fimagemagick_types): Doc fix.
9950
5fbc2025
PE
99512011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9952
0196f88a
PE
9953 Minor fixes prompted by GCC 4.6.0 warnings.
9954
9955 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9956
5fbc2025
PE
9957 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9958 (x_clipboard_manager_save_all): Move extern decl to ...
9959 * xterm.h: ... here, so that it can be checked for consistency.
9960
1dd3c2d9
CY
99612011-05-29 Chong Yidong <cyd@stupidchicken.com>
9962
9963 * xselect.c (x_clipboard_manager_save_frame)
9964 (x_clipboard_manager_save_all): New functions.
9965 (Fx_clipboard_manager_save): Lisp function deleted.
9966
9967 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9968 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9969
9970 * xterm.h: Update prototype.
9971
5ba6571d
WX
99722011-05-28 William Xu <william.xwl@gmail.com>
9973
9974 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9975 exiting (Bug#8239).
9976
3eaff834
JM
99772011-05-28 Jim Meyering <meyering@redhat.com>
9978
e1900994 9979 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9980 * fns.c (to_uchar): Define.
9981 (crypto_hash_function): Use it to convert some newly-signed
9982 variables to unsigned, to avoid sign-extension bugs. For example,
9983 without this change, (md5 "truc") would evaluate to
9984 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9985 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9986 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9987
0f6990a7
PE
99882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9989
9990 Integer overflow fixes.
c8a9ca5a 9991
08686060
PE
9992 * dbusbind.c: Serial number integer overflow fixes.
9993 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9994 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9995 to hold a serial number that is too large for a fixnum.
9996 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9997 Check for serial numbers out of range. Decode any serial number
59568bf0 9998 that was so large that it became a float. (Bug#8722)
08686060 9999
2d1fc3c7
PE
10000 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10001 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10002 Use XFASTINT rather than XUINT when numbers are nonnegative.
10003 (xd_append_arg, Fdbus_method_return_internal):
10004 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10005 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10006 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10007 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10008 (Bug#8722)
2d1fc3c7 10009
c8a9ca5a
PE
10010 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10011
519e1d69
PE
10012 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10013
6df6ae42 10014 ccl: Add integer overflow checks.
30569699
PE
10015 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10016 (IN_INT_RANGE): New macros.
10017 (ccl_driver): Use them to check for integer overflow when
10018 decoding a CCL program. Many of the new checks are whether XINT (x)
10019 fits in int; it doesn't always, on 64-bit hosts. The new version
10020 doesn't catch all possible integer overflows, but it's an
847044ea 10021 improvement. (Bug#8719)
30569699 10022
c11285dc
PE
10023 * alloc.c (make_event_array): Use XINT, not XUINT.
10024 There's no need for unsigned here.
10025
fdccd48e
PE
10026 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10027 This follows up to the 2011-05-06 change that substituted uintptr_t
10028 for EMACS_INT. This case wasn't caught back then.
10029
37910ab2
PE
10030 Rework Fformat to avoid integer overflow issues.
10031 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10032 now (part of C89). Include <verify.h>.
10033 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10034 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10035 (Fformat): Avoid the prepass trying to compute sizes; it was only
10036 approximate and thus did not catch overflow reliably. Instead, walk
10037 through the format just once, formatting and computing sizes as we go,
10038 checking for integer overflow at every step, and allocating a larger
10039 buffer as needed. Keep track separately whether the format is
10040 multibyte. Keep only the most-recently calculated precision, rather
10041 than them all. Record whether each argument has been converted to
10042 string. Use EMACS_INT, not int, for byte and char and arg counts.
10043 Support field widths and precisions larger than INT_MAX. Avoid
10044 sprintf's undefined behavior with conversion specifications such as %#d
10045 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10046 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10047 formatting out-of-range floating point numbers with int
9173deec 10048 formats. (Bug#8668)
37910ab2 10049
2e6578fb
PE
10050 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10051
0ae6bdee
PE
10052 * data.c: Avoid integer truncation in expressions involving floats.
10053 * data.c: Include <intprops.h>.
10054 (arith_driver): When there's an integer overflow in an expression
10055 involving floating point, convert the integers to floating point
10056 so that the resulting value does not suffer from catastrophic
10057 integer truncation. For example, on a 64-bit host (* 4
10058 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10059 Do not rely on undefined behavior after integer overflow.
10060
de883a70
PE
10061 merge count_size_as_multibyte, parse_str_to_multibyte
10062 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10063 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10064 Check for integer overflow.
10065 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10066 since it's now a duplicate of the other. This is more of
10067 a character than a buffer op, so better that it's in character.c.
10068 * fns.c, print.c: Adjust to above changes.
10069
2ff916cb
PE
100702011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10071
10072 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10073
f1b54466
PE
100742011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10075
fb1ac845
PE
10076 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10077 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10078 (x_clipboard_manager_save): Now static.
10079 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10080
f1b54466
PE
10081 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10082 (crypto_hash_function): Now static.
10083 Fix pointer signedness problems. Avoid unnecessary initializations.
10084
a9f737ee
CY
100852011-05-27 Chong Yidong <cyd@stupidchicken.com>
10086
10087 * termhooks.h (Vselection_alist): Make it terminal-local.
10088
10089 * terminal.c (create_terminal): Initialize it.
10090
10091 * xselect.c: Support for clipboard managers.
10092 (Vselection_alist): Move to termhooks.h as terminal-local var.
10093 (LOCAL_SELECTION): New macro.
10094 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10095 (symbol_to_x_atom): Remove gratuitous arg.
10096 (x_handle_selection_request, lisp_data_to_selection_data)
10097 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10098 (x_own_selection, x_get_local_selection, x_convert_selection):
10099 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10100 (some_frame_on_display): Delete unused function.
10101 (Fx_own_selection_internal, Fx_get_selection_internal)
10102 (Fx_disown_selection_internal, Fx_selection_owner_p)
10103 (Fx_selection_exists_p): New optional frame arg.
10104 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10105 (x_handle_selection_clear): Don't treat other terminals with the
10106 same keyboard specially. Use the terminal-local Vselection_alist.
10107 (x_clear_frame_selections): Use Frun_hook_with_args.
10108
10109 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10110
10111 * xterm.h: Add support for those atoms.
10112
e067f0c1
CY
101132011-05-26 Chong Yidong <cyd@stupidchicken.com>
10114
10115 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10116 (converted_selections, conversion_fail_tag): New global variables.
10117 (x_selection_request_lisp_error): Free the above.
10118 (x_get_local_selection): Remove unnecessary code.
10119 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10120 of converted selections stored in converted_selections.
10121 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10122 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10123 (x_convert_selection): New function.
10124 (x_handle_selection_event): Simplify.
10125 (x_get_foreign_selection): Don't ignore incoming requests while
10126 waiting for an answer; this will fail when we implement
10127 SAVE_TARGETS, and seems unnecessary anyway.
10128 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10129 (Vx_sent_selection_functions): Doc fix.
10130
0f4aebc0
LL
101312011-05-26 Leo Liu <sdl.web@gmail.com>
10132
10133 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10134
e61124cd
YM
101352011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10136
10137 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10138
10139 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10140 for fringe update if it has periodic bitmap.
ac389d0c 10141 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10142 and fringe_bitmap_periodic_p.
10143
10144 * fringe.c (get_fringe_bitmap_data): New function.
10145 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10146 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10147 row. Mark glyph row for fringe update if periodicity changed.
10148
10149 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10150 for fringe update unless it has periodic bitmap.
10151
f16d9837
KH
101522011-05-25 Kenichi Handa <handa@m17n.org>
10153
10154 * xdisp.c (get_next_display_element): Set correct it->face_id for
10155 a static composition.
10156
e1b90ef6
LL
101572011-05-24 Leo Liu <sdl.web@gmail.com>
10158
10159 * deps.mk (fns.o):
10160 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10161
10162 * fns.c (crypto_hash_function, Fsha1): New function.
10163 (Fmd5): Use crypto_hash_function.
10164 (syms_of_fns): Add Ssha1.
10165
7400048f
PE
101662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10167
10168 * gnutls.c: Remove unused macros.
10169 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10170 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10171 Remove macros that are defined and never used.
10172 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10173
abb71cf4
CY
101742011-05-22 Chong Yidong <cyd@stupidchicken.com>
10175
10176 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10177 (Fx_get_selection_internal): Minor cleanup.
10178 (Fx_own_selection_internal): Rename arguments for consistency with
10179 select.el.
10180
6307db39
PE
101812011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10182
10183 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10184
f3d4e0a4
CY
101852011-05-22 Chong Yidong <cyd@stupidchicken.com>
10186
10187 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10188
4d8ade89
YM
101892011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10190
10191 * dispnew.c (scrolling_window): Don't exclude the case that the
10192 last enabled row in the desired matrix touches the bottom boundary.
10193
32078c8d
GM
101942011-05-21 Glenn Morris <rgm@gnu.org>
10195
10196 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10197 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10198 and add some more files.
32078c8d 10199
7285dc67
EZ
102002011-05-20 Eli Zaretskii <eliz@gnu.org>
10201
10202 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10203 report_file_error introduced by the change from 2011-05-07.
10204
89d1bd22
PE
102052011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10206
10207 * systime.h (Time): Define only if emacs is defined.
10208 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10209 where the include path doesn't have X11/X.h by default. See
10210 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10211
cd394be1 102122011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10213
10214 * composite.c (find_automatic_composition): Fix previous change.
10215
b9704ad9
GM
102162011-05-20 Glenn Morris <rgm@gnu.org>
10217
10218 * lisp.mk: New file, split from Makefile.in.
10219 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10220 (shortlisp): Remove.
10221 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10222
4a720484
GM
102232011-05-19 Glenn Morris <rgm@gnu.org>
10224
10225 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10226 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10227 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10228 (lisp): Set the order to that of loadup.el.
10229 (shortlisp): Make it a copy of $lisp.
10230 (SOME_MACHINE_LISP): Remove.
10231 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10232 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10233
a28d4396
KH
102342011-05-18 Kenichi Handa <handa@m17n.org>
10235
10236 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10237 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10238 (find_automatic_composition): Mostly rewrite for efficiency.
10239
a2b1fa8e
JB
102402011-05-18 Juanma Barranquero <lekktu@gmail.com>
10241
10242 * makefile.w32-in: Update dependencies.
10243
8e1f5610
CS
102442011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10245
10246 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10247 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10248
7025ee00 102492011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10250
cdfa6eab
PE
10251 Fix some integer overflow issues, such as string length overflow.
10252
06d6db33
PE
10253 * insdel.c (count_size_as_multibyte): Check for string overflow.
10254
2b4560a8
PE
10255 * character.c (lisp_string_width): Check for string overflow.
10256 Use EMACS_INT, not int, for string indexes and lengths; in
10257 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10258 the resulting string length overflows an EMACS_INT; instead,
10259 report a string overflow if no precision given. When checking for
10260 precision exhaustion, use a check that cannot possibly have
10261 integer overflow. (Bug#8675)
10262 * character.h (lisp_string_width): Adjust to new signature.
10263
cb93f9be
PE
10264 * alloc.c (string_overflow): New function.
10265 (Fmake_string): Use it. This doesn't change behavior, but saves
10266 a few bytes and will simplify future changes.
10267 * character.c (string_escape_byte8): Likewise.
10268 * lisp.h (string_overflow): New decl.
10269
1a1f3366
PE
10270 Fixups, following up to the user-interface timestamp change.
10271 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10272 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10273 * msdos.c (mouse_get_pos): Likewise.
10274 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10275 * w32gui.h (Time): Define by including "systime.h" rather than by
10276 declaring it ourselves. (Bug#8664)
10277
d4e3e4d3
PE
10278 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10279 * image.c (clear_image_cache): Likewise.
10280
f6a24d19
PE
10281 * term.c (term_mouse_position): Don't assume time_t wraparound.
10282
08dc5ae6
PE
10283 Be more systematic about user-interface timestamps.
10284 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10285 and sometimes 'EMACS_UINT', to represent these timestamps.
10286 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10287 This makes the code easier to follow, and makes it easier to catch
10288 integer overflow bugs such as Bug#8664.
10289 * frame.c (Fmouse_position, Fmouse_pixel_position):
10290 Use Time, not unsigned long, for user-interface timestamps.
10291 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10292 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10293 * keyboard.h (last_event_timestamp): Likewise.
10294 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10295 * menu.h (xmenu_show): Likewise.
10296 * term.c (term_mouse_position): Likewise.
10297 * termhooks.h (struct input_event.timestamp): Likewise.
10298 (struct terminal.mouse_position_hook): Likewise.
10299 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10300 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10301 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10302 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10303 what it was before.
10304 * menu.h, termhooks.h: Include "systime.h", for Time.
10305
8e55734a
PE
10306 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10307 Don't assume that the difference between two unsigned long values
10308 can fit into an integer. At this point, we know button_down_time
10309 <= event->timestamp, so the difference must be nonnegative, so
10310 there's no need to cast the result if double-click-time is
10311 nonnegative, as it should be; check that it's nonnegative, just in
10312 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10313 apart (about 25 days). (Bug#8664)
8e55734a 10314
841f1b75 10315 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10316 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10317
3e26f69c
PE
10318 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10319 that always fit in int. Use a sentinel instead of a counter, to
10320 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10321 * frame.h (struct frame): Use int for menu_bar_items_used
10322 instead of EMACS_INT, since it always fits in int.
3e26f69c 10323
5cc152c0
PE
10324 * menu.c (grow_menu_items): Check for int overflow.
10325
d89eb65e
PE
10326 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10327
5235bd3e
PE
10328 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10329 Before, the code was not consistent. These values cannot exceed
10330 2**31 - 1 so there's no need to make them unsigned.
10331 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10332 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10333 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10334 as modifiers.
10335 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10336
bc827e23
PE
10337 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10338 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10339 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10340 presumably because the widths might not match.
10341
78eb494e
PE
10342 * window.c (size_window): Avoid needless test at loop start.
10343
04f2d78b
CB
103442011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10345
10346 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10347
d2fc7e3d 103482011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10349
10350 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10351
d2fc7e3d 103522011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10353
10354 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10355 `width' to `bar_area_x' and `bar_area_width', respectively.
10356 (x_scroll_run): Take account of fringe background extension.
10357
04f2d78b
CB
10358 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10359 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10360 `bar_area_width', respectively.
10361 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10362 background extension.
10363
79b70037
GM
103642011-05-10 Jim Meyering <meyering@redhat.com>
10365
10366 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10367
2f142cc5
JB
103682011-05-10 Juanma Barranquero <lekktu@gmail.com>
10369
10370 * image.c (Finit_image_library): Return t for built-in image types,
10371 like pbm and xbm. (Bug#8640)
10372
57679c86
AS
103732011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10374
10375 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10376
888c9e86
EZ
103772011-05-07 Eli Zaretskii <eliz@gnu.org>
10378
b0512a1d
EZ
10379 * w32console.c (Fset_screen_color): Doc fix.
10380 (Fget_screen_color): New function.
10381 (syms_of_ntterm): Defsubr it.
10382
7285dc67
EZ
10383 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10384 unlink the temporary file if Fcall_process didn't create it in the
10385 first place.
10386 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10387 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10388 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10389 cue to call_process_cleanup not to close that handle.
10390
4d3fcc8e
BK
103912011-05-07 Ben Key <bkey76@gmail.com>
10392
10393 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10394 one of two shell specific rules, either bootstrap-temacs-CMD or
10395 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10396 to the previous implementation of the bootstrap-temacs rule.
10397 The bootstrap-temacs-CMD rule is similar to the previous
10398 implementation of the bootstrap-temacs rule except that it
10399 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10400 variable.
10401
10402 These changes, along with some changes to nt/configure.bat,
10403 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10404 earlier fix to add support for --cflags and --ldflags options
10405 that include quotes so that it works whether make uses cmd or
10406 sh as the shell.
10407
b4289b64
MA
104082011-05-06 Michael Albinus <michael.albinus@gmx.de>
10409
10410 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10411 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10412 is a constant.
10413 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10414 a string. Handle both cases.
10415 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10416 (Fdbus_register_method): Use Qinvalid_function.
10417
af4c0e28
JB
104182011-05-06 Juanma Barranquero <lekktu@gmail.com>
10419
10420 * makefile.w32-in: Update dependencies.
10421 (LISP_H): Add inttypes.h and stdin.h.
10422 (PROCESS_H): Add unistd.h.
10423
c51453d9
EZ
104242011-05-06 Eli Zaretskii <eliz@gnu.org>
10425
10426 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10427 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10428
8ff0ac3c 104292011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10430
4c4b566b
PE
10431 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10432
aab2b9b5
PE
10433 * term.c (vfatal): Remove stray call to va_end.
10434 It's not needed and the C Standard doesn't allow it here anyway.
10435
c378da0b
PE
10436 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10437 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10438
288b08c7
PE
10439 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10440 bytes.
10441
e3601888
PE
10442 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10443
db6c0e74
PE
10444 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10445
dd5963ea
PE
10446 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10447
88c9450f
PE
10448 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10449
2f9442b8
PE
10450 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10451
c032b5f8
PE
10452 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10453 * charset.c (Fdefine_charset_internal): Don't initialize
10454 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10455 32-bit int (Bug#8600).
a108c10b
PE
10456
10457 * lread.c (read_integer): Be more consistent with string-to-number.
10458 Use string_to_number to do the actual conversion; this avoids
10459 rounding errors and fixes some other screwups. Without this fix,
10460 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10461 (digit_to_number): Move earlier, for benefit of read_integer.
10462 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10463 not a digit in any supported base. (Bug#8602)
a108c10b 10464
ad5f9eea
PE
10465 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10466
aec1708a
PE
10467 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10468 to match comment at start of function. This also removes a
10469 GCC warning about overflow in a 32+64-bit port.
10470
47be4ab5
PE
10471 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10472
371cac43
PE
10473 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10474 Reported by Stefan Monnier in
10475 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10476 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10477 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10478
d01a7826
PE
10479 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10480 (EMACS_UINTPTR): Likewise, with uintptr_t.
10481
7fd47d5c
PE
10482 * lisp.h: Prefer 64-bit EMACS_INT if available.
10483 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10484 on 32-bit hosts that have 64-bit int, so that they can access
10485 large files.
122b0c86
PE
10486 However, temporarily disable this change unless the temporary
10487 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10488
8727937b
PE
10489 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10490
8ac068ac
PE
10491 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10492 This removes an assumption that EMACS_INT and long are the same
10493 width as pointers. The assumption is true for Emacs porting targets
10494 now, but we want to make other targets possible.
10495 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10496 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10497 In the rest of the code, change types of integers that hold casted
10498 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10499 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10500 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10501 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10502 No need to cast type when ORing.
10503 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10504 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10505 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10506 assume EMACS_INT is the same width as char *.
10507 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10508 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10509 Remove no-longer-needed casts.
10510 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10511 (xg_tool_bar_help_callback, xg_make_tool_item):
10512 Use EMACS_INTPTR to hold an integer
10513 that will be cast to void *; this can avoid a GCC warning
10514 if EMACS_INT is not the same width as void *.
10515 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10516 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10517 (current_message_1, set_message_1):
10518 Use a local to convert to proper width without a cast.
10519 * xmenu.c (dialog_selection_callback): Likewise.
10520
ede49d71
PE
10521 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10522 Also, don't assume VALBITS / RAND_BITS is less than 5,
10523 and don't rely on undefined behavior when shifting a 1 left into
10524 the sign bit.
10525 * lisp.h (get_random): Change signature to match.
10526
2f30ecd0
PE
10527 * lread.c (hash_string): Use size_t, not int, for hash computation.
10528 Normally we prefer signed values; but hashing is special, because
10529 it's better to use unsigned division on hash table sizes so that
10530 the remainder is nonnegative. Also, size_t is the natural width
10531 for hashing into memory. The previous code used 'int', which doesn't
10532 retain enough info to hash well into very large tables.
10533 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10534
2a866e7b
PE
10535 * dbusbind.c: Don't possibly lose pointer info when converting.
10536 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10537 Use XPNTR rather than XHASH, so that the high-order bits of
10538 the pointer aren't lost when converting through void *.
10539
51639eac
PE
10540 * eval.c (Fautoload): Don't double-shift a pointer.
10541
92394119
PE
10542 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10543
dbdb9a7c
JB
105442011-05-06 Juanma Barranquero <lekktu@gmail.com>
10545
10546 * gnutls.c (DEF_GNUTLS_FN):
10547 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10548
db7a0b4f
AS
105492011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10550
10551 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10552 marker. (Bug#8610)
10553
cd394be1 105542011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10555
10556 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10557 New version that can reserve upto 2GB of heap space.
10558
f7ff1b0f 105592011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10560
10561 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10562
639c109b
TZ
105632011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10564
10565 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10566 `gnutls_certificate_set_x509_key_file'.
10567
d2127135
JB
105682011-05-05 Juanma Barranquero <lekktu@gmail.com>
10569
10570 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10571 Update dependencies.
10572
e968f4f3
JB
105732011-05-04 Juanma Barranquero <lekktu@gmail.com>
10574
10575 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10576 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10577 Remove unused parameter `fildes'.
10578 * process.c (read_process_output, send_process): Don't pass it.
10579
84d358f0
JB
105802011-05-04 Juanma Barranquero <lekktu@gmail.com>
10581
10582 Fix previous change: the library cache is defined in w32.c.
10583 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10584 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10585
0898ca10
JB
105862011-05-04 Juanma Barranquero <lekktu@gmail.com>
10587
10588 Implement dynamic loading of GnuTLS on Windows.
10589
10590 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10591 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10592 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10593 Declare.
10594
10595 * gnutls.c (Qgnutls_dll): Define.
10596 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10597 (gnutls_*): Declare function pointers.
10598 (init_gnutls_functions): New function to initialize function pointers.
10599 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10600 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10601 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10602 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10603 (emacs_gnutls_write, emacs_gnutls_read)
10604 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10605 (Fgnutls_available_p): New function.
10606 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10607 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10608 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10609
10610 * image.c: Include w32.h.
10611 (Vimage_type_cache): Delete.
10612 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10613 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10614 (w32_delayed_load): Move to w32.c.
10615
10616 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10617
10618 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10619 (w32_delayed_load): Move from image.c. When loading a library, record
10620 its filename in the :loaded-from property of the library id.
10621 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10622 Initialize and staticpro them.
10623 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10624
10625 * process.c: Include lisp.h before w32.h, not after.
10626 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10627 instead of gnutls_record_check_pending.
10628
10629 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10630
ff4de4aa
TZ
106312011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10632
10633 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10634 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10635 as passed in.
10636
abe95abb
JD
106372011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10638
10639 * xterm.c (x_set_frame_alpha): Do not set property on anything
10640 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10641
e16e55d4
JB
106422011-05-02 Juanma Barranquero <lekktu@gmail.com>
10643
10644 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10645
bafcf6a5
JB
106462011-05-02 Juanma Barranquero <lekktu@gmail.com>
10647
10648 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10649 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10650 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10651 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10652 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10653 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10654 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10655 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10656 (Qgnutls_bootprop_callbacks_verify): Make static.
10657
e7a6747f
AS
106582011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10659
19ed11ba
AS
10660 * callproc.c: Indentation fixup.
10661
e7a6747f 10662 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10663 (wait_for_termination, interruptible_wait_for_termination):
10664 Move after wait_for_termination_1.
e7a6747f 10665
1ef14cb4
LMI
106662011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10667
10668 * sysdep.c (interruptible_wait_for_termination): New function
10669 which is like wait_for_termination, but allows keyboard
10670 interruptions.
10671
10672 * callproc.c (Fcall_process): Add (:file "file") as an option for
10673 the STDOUT buffer.
10674 (Fcall_process_region): Ditto.
10675
330d880c
EZ
106762011-04-30 Eli Zaretskii <eliz@gnu.org>
10677
8db90b73
EZ
10678 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10679 rather than `XVECTOR (FOO)->size'.
10680
330d880c
EZ
10681 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10682 inttypes.h, as a gnulib replacement is used if it not available in
10683 system headers.
10684
15cbd324
EZ
106852011-04-21 Eli Zaretskii <eliz@gnu.org>
10686
10687 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10688 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10689 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10690
10691 * coding.c (coding_alloc_by_realloc): Error out if destination
10692 will grow beyond MOST_POSITIVE_FIXNUM.
10693 (decode_coding_emacs_mule): Abort if there isn't enough place in
10694 charbuf for the composition carryover bytes. Reserve an extra
10695 space for up to 2 characters produced in a loop.
10696 (decode_coding_iso_2022): Abort if there isn't enough place in
10697 charbuf for the composition carryover bytes.
10698
106992011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10700
ae940cca
EZ
10701 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10702 aborting when %lld or %lll format is passed.
10703 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10704 %llo or %llx format is passed. (Bug#8545)
10705
03ab8921
EZ
10706 * window.c (window_scroll_line_based): Use a marker instead of
10707 simple variables to record original value of point. (Bug#7952)
10708
afda1437
EZ
10709 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10710 produced by %s or %c overflows available buffer space. (Bug#8545)
10711
f76dee0c
PE
107122011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10713
10714 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10715 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10716
fdc5744d
JB
107172011-04-28 Juanma Barranquero <lekktu@gmail.com>
10718
10719 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10720
638f053a
JB
107212011-04-28 Juanma Barranquero <lekktu@gmail.com>
10722
10723 * keyboard.c (Qdelayed_warnings_hook): Define.
10724 (command_loop_1): Run `delayed-warnings-hook'
10725 if Vdelayed_warnings_list is non-nil.
10726 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10727 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10728
d178f871
EZ
107292011-04-28 Eli Zaretskii <eliz@gnu.org>
10730
10731 * doprnt.c (doprnt): Don't return value smaller than the buffer
10732 size if the message was truncated. (Bug#8545).
10733
b124fd93
JB
107342011-04-28 Juanma Barranquero <lekktu@gmail.com>
10735
10736 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10737 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10738
e810457d
PE
107392011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10740
10741 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10742
ea51cceb
JB
107432011-04-27 Juanma Barranquero <lekktu@gmail.com>
10744
10745 * makefile.w32-in: Update dependencies.
10746
94dcfacf
EZ
107472011-04-27 Eli Zaretskii <eliz@gnu.org>
10748
10749 Improve `doprnt' and its usage. (Bug#8545)
10750 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10751 `format_end'. Remove support for %l as a conversion specifier.
10752 Don't use xrealloc. Improve diagnostics when the %l size modifier
10753 is used. Update the commentary.
10754
10755 * eval.c (verror): Simplify calculation of size_t.
10756
10757 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10758 messages.
10759
f61f41d7
PE
107602011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10761
10762 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10763 change.
10764
96fb4434
PE
107652011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10766
10767 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10768 This makes this file independent of the recent pseudovector change.
10769
671875da 107702011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10771
69e9b5a3
PE
10772 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10773
b5f869a7 10774 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10775 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10776 Remove unused local.
c8926152 10777 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10778
841a1577 10779 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10780 GCC 4.6.0 optimizes based on type-based alias analysis.
10781 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10782 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10783 != &v->size, and therefore "v->size = 1; b->size = 2; return
10784 v->size;" must therefore return 1. This assumption is incorrect
10785 for Emacs, since it type-puns struct Lisp_Vector * with many other
10786 types. To fix this problem, this patch adds a new type struct
f904488f 10787 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10788 and pseudovectors, and helps optimizing compilers not get fooled
10789 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10790 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10791 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10792 the size member.
eab3844f
PE
10793 (XSETPVECTYPE): Rewrite in terms of new macro.
10794 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10795 This is a bit clearer, and further avoids the possibility of
10796 undesirable aliasing.
10797 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10798 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10799 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10800 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10801 (ASIZE): Now uses header.size rather than size.
10802 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10803 to avoid the hassle of writing XVECTOR (foo)->header.size.
10804 (struct vectorlike_header): New type.
eab3844f
PE
10805 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10806 object, to help avoid aliasing.
10807 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10808 (SUBRP): Likewise, since Lisp_Subr is a special case.
10809 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10810 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10811 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10812 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10813 changed to be "header.size" and "header.next".
10814 * buffer.h (struct buffer): Likewise.
10815 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10816 * frame.h (struct frame): Likewise.
10817 * process.h (struct Lisp_Process): Likewise.
10818 * termhooks.h (struct terminal): Likewise.
10819 * window.c (struct save_window_data, struct saved_window): Likewise.
10820 * window.h (struct window): Likewise.
10821 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10822 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10823 * buffer.c (init_buffer_once): Likewise.
10824 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10825 special case.
10826 * process.c (Fformat_network_address): Use local var for size,
10827 for brevity.
10828
0df1eac5
PE
10829 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10830
847ab9d1 10831 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10832 * data.c (atof): Remove decl; no longer used or needed.
10833 (digit_to_number): Move to lread.c.
10834 (Fstring_to_number): Use new string_to_number function, to be
10835 consistent with how the Lisp reader treats infinities and NaNs.
10836 Do not assume that floating-point numbers represent EMACS_INT
10837 without losing information; this is not true on most 64-bit hosts.
10838 Avoid double-rounding errors, by insisting on integers when
10839 parsing non-base-10 numbers, as the documentation specifies.
10840 * lisp.h (string_to_number): New decl, replacing ...
10841 (isfloat_string): Remove.
bc0a5c13 10842 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10843 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10844 appears to have been a coding error. Similarly, do not accept
10845 strings like +-1e0 as floating point numbers. Do not report
10846 overflow for integer overflows unless the base is not 10 which
10847 means we have no simple and reliable way to continue.
10848 Break out the floating-point parsing into a new
10849 function string_to_number, so that Fstring_to_number parses
10850 floating point numbers consistently with the Lisp reader.
04f2d78b 10851 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10852 (E_CHAR, EXP_INT): Remove, replacing with ...
10853 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10854 (string_to_number): New function, replacing isfloat_string.
10855 This function checks for valid syntax and produces the resulting
10856 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10857 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10858 so that overflow for non-base-10 numbers is reported only when
10859 there's no portable and simple way to convert to floating point.
452f4150 10860
67769ffc
PE
10861 * textprop.c (set_text_properties_1): Rewrite for clarity,
10862 and to avoid GCC warning about integer overflow.
10863
c20db43f
PE
10864 * intervals.h (struct interval): Use EMACS_INT for members
10865 where EMACS_UINT might cause problems. See
10866 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10867 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10868 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10869 All uses changed.
37aa2f85
PE
10870 (offset_intervals): Tell GCC not to worry about length overflow
10871 when negating a negative length.
c20db43f 10872
2538aa2f
PE
10873 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10874 (overrun_check_free): Likewise.
10875
f2d3008d
PE
10876 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10877 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10878 word size.
10879
ec8df744
PE
10880 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10881 (gnutls_make_error): Rename local to avoid shadowing.
10882 (gnutls_emacs_global_deinit): ifdef out; not used.
10883 (Fgnutls_boot): Use const for pointer to readonly storage.
10884 Comment out unused local. Fix pointer signedness problems.
10885
640ee02d
PE
10886 * lread.c (openp): Don't stuff size_t into an 'int'.
10887 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10888 about possible signed overflow.
10889
6048fb2a
PE
10890 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10891 (GDK_KEY_g): Don't define if already defined.
10892 (xg_prepare_tooltip): Avoid pointer signedness problem.
10893 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10894
fa3c87e1
PE
10895 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10896 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10897
2172544b
PE
10898 * xfns.c (Fx_window_property): Simplify a bit,
10899 to make a bit faster and to avoid GCC 4.6.0 warning.
10900 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10901
9b821a21
PE
10902 * fns.c (internal_equal): Don't assume size_t fits in int.
10903
3c616cfa
PE
10904 * alloc.c (compact_small_strings): Tighten assertion a little.
10905
c2982e87
PE
10906 Replace pEd with more-general pI, and fix some printf arg casts.
10907 * lisp.h (pI): New macro, generalizing old pEd macro to other
10908 conversion specifiers. For example, use "...%"pI"d..." rather
10909 than "...%"pEd"...".
10910 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10911 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10912 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10913 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10914 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10915 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10916 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10917 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10918 64-bit hosts.
10919 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10920 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10921 * print.c (safe_debug_print, print_object): Likewise.
10922 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10923 to int.
6f04d126
PE
10924 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10925 avoiding the 0 flag, which is not portable.
c2982e87
PE
10926 * process.c (Fmake_network_process): Use pI to avoid cast.
10927 * region-cache.c (pp_cache): Likewise.
10928 * xdisp.c (decode_mode_spec): Likewise.
10929 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10930 behavior on 64-bit hosts with printf arg.
6f04d126 10931 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10932 (x_stop_queuing_selection_requests): Likewise.
10933 (x_get_window_property): Don't truncate byte count to an 'int'
10934 when tracing.
0b432f21 10935
5e073ec7
PE
10936 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10937 here, since it parses constructs like leading '-' and spaces,
10938 which are not wanted; and it overflows with large numbers.
10939 Instead, simply match F[0-9]+, which is what is wanted anyway.
10940
36372bf9
PE
10941 * alloc.c: Remove unportable assumptions about struct layout.
10942 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10943 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10944 (allocate_vectorlike, make_pure_vector): Use the new macros,
10945 plus offsetof, to remove unportable assumptions about struct layout.
10946 These assumptions hold on all porting targets that I know of, but
10947 they are not guaranteed, they're easy to remove, and removing them
10948 makes further changes easier.
10949
0b432f21
PE
10950 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10951 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10952 (string_overrun_cookie): Now const. Use initializers that
10953 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10954 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10955 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10956 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10957 multiple of sizeof (EMACS_INT); it need not be, if
10958 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10959 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10960
895009e1
JB
109612011-04-26 Juanma Barranquero <lekktu@gmail.com>
10962
10963 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10964
6a7a1b0b
TZ
109652011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10966
10967 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10968 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10969 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10970
841a1577 109712011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10972
10973 * lisp.h (Qdebug): List symbol.
895009e1 10974 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10975 * keyboard.c (debug-on-event): New variable.
10976 (handle_user_signal): Break into debugger when debug-on-event
10977 matches the current signal symbol.
10978
f2d3ba6f
DN
109792011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10980
10981 * alloc.c (check_sblock, check_string_bytes)
10982 (check_string_free_list): Convert to standard C.
10983
42ce4c63
TZ
109842011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10985
10986 * w32.c (emacs_gnutls_push): Fix typo.
10987
825cd63c
EZ
109882011-04-25 Eli Zaretskii <eliz@gnu.org>
10989
fb11d64d
EZ
10990 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10991 "cast to pointer from integer of different size".
10992
825cd63c
EZ
10993 Improve doprnt and its use in verror. (Bug#8545)
10994 * doprnt.c (doprnt): Document the set of format control sequences
10995 supported by the function. Use SAFE_ALLOCA instead of always
10996 using `alloca'.
10997
10998 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10999 is one byte too soon. Don't use xrealloc; instead xfree and
11000 xmalloc anew.
11001
e061a11b
TZ
110022011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11003
11004 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11005 callbacks stage.
11006
11007 * gnutls.c: Renamed global_initialized to
11008 gnutls_global_initialized. Added internals for the
11009 :verify-hostname-error, :verify-error, and :verify-flags
11010 parameters of `gnutls-boot' and documented those parameters in the
11011 docstring. Start callback support.
9173deec
JB
11012 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11013 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11014 on error. Return error code.
e061a11b
TZ
11015 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11016 (emacs_gnutls_read): Likewise.
11017 (Fgnutls_boot): Return handshake error code.
11018 (emacs_gnutls_handle_error): New function.
11019 (wsaerror_to_errno): Likewise.
11020
11021 * w32.h (emacs_gnutls_pull): Add prototype.
11022 (emacs_gnutls_push): Likewise.
11023
11024 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11025 (emacs_gnutls_push): Likewise.
11026
110272011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11028
11029 * process.c (wait_reading_process_output): Check if GnuTLS
11030 buffered some data internally if no FDs are set for TLS
11031 connections.
11032
11033 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11034 (LIBS): Link to USER_LIBS.
11035 ($(BLD)/gnutls.$(0)): New target.
11036
fa6996bc
EZ
110372011-04-24 Eli Zaretskii <eliz@gnu.org>
11038
eb35682e
EZ
11039 * xdisp.c (handle_single_display_spec): Rename the
11040 display_replaced_before_p argument into display_replaced_p, to
11041 make it consistent with the commentary. Fix typos in the
11042 commentary.
11043
e2ad650c
EZ
11044 * textprop.c (syms_of_textprop): Remove dead code.
11045 (copy_text_properties): Delete obsolete commentary about an
11046 interface that was deleted long ago. Fix typos in the description
11047 of arguments.
11048
1b2de274
EZ
11049 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11050 to changes in oldXMenu/XMenu.h from 2011-04-16.
11051 <menu_help_message, prev_menu_help_message>: Constify.
11052 (IT_menu_make_room): menu->help_text is now `const char **';
11053 adjust.
11054
11055 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11056 to changes in oldXMenu/XMenu.h from 2011-04-16.
11057 (struct XMenu): Declare `help_text' `const char **'.
11058
11059 * xfaces.c <Qunspecified>: Make extern again.
11060
11061 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11062 required by POSIX.
1b2de274 11063
762b15be
EZ
11064 * doc.c (get_doc_string): Improve the format passed to `error'.
11065
11066 * doprnt.c (doprnt): Improve commentary.
11067
11068 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11069
11070 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11071 them with etags.
11072
f1052e5d
EZ
11073 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11074 changes in globals.h immediately force recompilation.
762b15be
EZ
11075 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11076 $(CURDIR)/s/ms-w32.h.
11077 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11078
fa6996bc
EZ
11079 * character.c (Fchar_direction): Function deleted.
11080 (syms_of_character): Don't defsubr it.
11081 <char-direction-table>: Deleted.
11082
e6c3da20
EZ
110832011-04-23 Eli Zaretskii <eliz@gnu.org>
11084
11085 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11086 * doprnt.c: Include limits.h.
11087 (SIZE_MAX): New macro.
04f2d78b
CB
11088 (doprnt): Return a size_t value. 2nd arg is now size_t.
11089 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11090 Improve overflow protection. Support `l' modifier for integer
11091 conversions. Support %l conversion. Don't assume an EMACS_INT
11092 argument for integer conversions and for %c.
11093
11094 * lisp.h (doprnt): Restore prototype.
11095
11096 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11097 $(SRC)/character.h.
11098
11099 * Makefile.in (base_obj): Add back doprnt.o.
11100
11101 * deps.mk (doprnt.o): Add back prerequisites.
11102 (callint.o): Depend on character.h.
11103
11104 * eval.c (internal_lisp_condition_case): Include the handler
11105 representation in the error message.
11106 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11107 when breaking from the loop.
11108
11109 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11110
11111 * callint.c (Fcall_interactively): When displaying error message
11112 about invalid control letter, pass the character's codepoint, not
11113 a pointer to its multibyte form. Improve display of the character
11114 in octal and display also its hex code.
11115
11116 * character.c (char_string): Use %x to display the (unsigned)
11117 codepoint of an invalid character, to avoid displaying a bogus
11118 negative value.
11119
11120 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11121 `error', not SYMBOL_NAME itself.
11122
11123 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11124 character arguments to `error'.
11125
11126 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11127 to `error' in error message about FINAL_CHAR argument. Make sure
11128 FINAL_CHAR is a character, and use %c when it is passed as
11129 argument to `error'.
11130
4ffd0d6b 111312011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11132
11133 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11134
11135 * w32.c: Include <time.h>.
11136 (sys_localtime): New function.
11137
4ffd0d6b 111382011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11139
11140 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11141
4ffd0d6b 11142 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11143
4ffd0d6b 111442011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11145
4ffd0d6b
GM
11146 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11147 zombies (Bug#8467).
aac0c6e3 11148
04c56954
EZ
111492011-04-19 Eli Zaretskii <eliz@gnu.org>
11150
11151 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11152 gl_state.e_property when gl_state.object is Qt.
11153
11154 * insdel.c (make_gap_larger): Remove limitation of buffer size
11155 to <= INT_MAX.
11156
16a43933
CY
111572011-04-18 Chong Yidong <cyd@stupidchicken.com>
11158
11159 * xdisp.c (lookup_glyphless_char_display)
11160 (produce_glyphless_glyph): Handle cons cell entry in
11161 glyphless-char-display.
11162 (Vglyphless_char_display): Document it.
11163
11164 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11165 glyphless-char-display.
11166
4581706e
CY
111672011-04-17 Chong Yidong <cyd@stupidchicken.com>
11168
11169 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11170
11171 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11172
11173 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11174 definition for no-X builds.
11175
4887c6e2 111762011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11177
fd35b6f9
PE
11178 Static checks with GCC 4.6.0 and non-default toolkits.
11179
5c1ccb01
PE
11180 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11181
006c5daa
PE
11182 * process.c (keyboard_bit_set): Define only if SIGIO.
11183 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11184 (send_process): Repair possible setjmp clobbering.
11185
efc736d3
PE
11186 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11187
4e2fe2e6
PE
11188 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11189
f97334a2
PE
11190 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11191
4e75f29d
PE
11192 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11193 Define only if needed.
11194
90efadd1
PE
11195 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11196 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11197 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11198
3c647824
PE
11199 * dispextern.h (struct redisplay_interface): Rename param
11200 to avoid shadowing.
e264f262 11201 * termhooks.h (struct terminal): Likewise.
761383f4 11202 * xterm.c (xembed_send_message): Likewise.
3c647824 11203
b58c5c4a
PE
11204 * insdel.c (make_gap_smaller): Define only if
11205 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11206
cad59032
PE
11207 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11208 it.
11209
c339dc2e
PE
11210 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11211 so that we aren't warned about unused symbols.
11212
91a3e27b
PE
11213 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11214
399c71d3 11215 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11216
8ffc96f5
PE
11217 * xfns.c (x_real_positions): Mark locals as initialized.
11218
eef9bc79
PE
11219 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11220
098db9dd
PE
11221 * xterm.c: Fix problems found by static analysis with other toolkits.
11222 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11223 (x_dispatch_event): Declare static if USE_GTK, and
11224 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11225 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11226 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11227 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11228 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11229
eb18f6cc
PE
11230 * xmenu.c (menu_help_callback): Pointer type fixes.
11231 Use const pointers when pointing at readonly data. Avoid pointer
11232 signedness clashes.
11233 (FALSE): Remove unused macro.
11234 (update_frame_menubar): Remove unused decl.
11235
1fe72bf8
PE
11236 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11237
60d9e1db
PE
11238 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11239 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11240 (single_menu_item): Rename local to avoid shadowing.
11241
39261c26
PE
11242 * keyboard.c (make_lispy_event): Remove unused local var.
11243
018c5e19
PE
11244 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11245 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11246
63d2b86e
PE
11247 * bitmaps: Change bitmaps from unsigned char back to the X11
11248 compatible char. Avoid the old compiler warnings about
11249 out-of-range initializers by using, for example, '\xab' rather
11250 than 0xab.
11251
aefd87e1
PE
11252 * xgselect.c (xgselect_initialize): Check vs interface
11253 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11254
bf501fb9
PE
11255 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11256
e9829fdf
PE
11257 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11258 to read-only memory.
11259
1086c095
PE
11260 * fns.c (vector): Remove; this old hack is no longer needed.
11261
2baccd04 11262 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11263 Remove unused var.
dde42981 11264 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11265
72391843 11266 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11267
436c16df 11268 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11269 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11270 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11271
92bb796d 11272 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11273 (x_term_init): Remove local to avoid shadowing.
92bb796d 11274
764430a3 11275 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11276
11277 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11278 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11279
d1dfb56c
EZ
112802011-04-16 Eli Zaretskii <eliz@gnu.org>
11281
c4354cb4
EZ
11282 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11283
d1dfb56c
EZ
11284 Fix regex.c, syntax.c and friends for buffers > 2GB.
11285 * syntax.h (struct gl_state_s): Declare character position members
11286 EMACS_INT.
11287
11288 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11289
04f2d78b
CB
11290 * textprop.c (verify_interval_modification, interval_of):
11291 Declare arguments EMACS_INT.
d1dfb56c
EZ
11292
11293 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11294 EMACS_INT.
11295
11296 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11297
11298 * indent.c (Fvertical_motion): Local variable it_start is now
11299 EMACS_INT.
11300
11301 * regex.c (re_match, re_match_2, re_match_2_internal)
11302 (bcmp_translate, regcomp, regexec, print_double_string)
11303 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11304 (re_compile_pattern, re_exec): Declare arguments and local
11305 variables `size_t' and `ssize_t' and return values `regoff_t', as
11306 appropriate.
11307 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11308 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11309 <compile_stack_type>: `size' and `avail' are now `size_t'.
11310
11311 * regex.h <regoff_t>: Use ssize_t, not int.
11312 (re_search, re_search_2, re_match, re_match_2): Arguments that
11313 specify buffer/string position and length are now ssize_t and
11314 size_t. Return type is regoff_t.
11315
613052cd
BK
113162011-04-16 Ben Key <bkey76@gmail.com>
11317
11318 * nsfont.m: Fixed bugs in ns_get_family and
11319 ns_descriptor_to_entity that were caused by using free to
11320 deallocate memory blocks that were allocated by xmalloc (via
11321 xstrdup). This caused Emacs to crash when compiled with
11322 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11323 --enable-checking=xmallocoverrun). xfree is now used to
11324 deallocate these memory blocks.
11325
4170f62f 113262011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11327
71b41406
PE
11328 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11329
9587a89d
PE
11330 emacs_write: Accept and return EMACS_INT for sizes.
11331 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11332 et seq.
11333 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11334 Accept and return EMACS_INT.
11335 (emacs_gnutls_write): Return the number of bytes written on
11336 partial writes.
11337 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11338 (emacs_read, emacs_write): Remove check for negative size, as the
11339 Emacs source code has been audited now.
9587a89d
PE
11340 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11341 (emacs_read, emacs_write): Use it.
273a5f82
PE
11342 * process.c (send_process): Adjust to the new signatures of
11343 emacs_write and emacs_gnutls_write. Do not attempt to store
11344 a byte offset into an 'int'; it might overflow.
9587a89d 11345 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11346
3e047f51
PE
11347 * sound.c: Don't assume sizes fit in 'int'.
11348 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11349 Return EMACS_INT, not int.
3e047f51 11350 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11351 Accept EMACS_INT, not int.
11352 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11353 record read return values.
11354
cc39a9db
BK
113552011-04-15 Ben Key <bkey76@gmail.com>
11356
c9d0ec6d
JB
11357 * keyboard.c (Qundefined): Don't declare static since it is used
11358 in nsfns.m.
11359 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11360 static since they are used in nsfont.m.
cc39a9db 11361
6c60eb9f
SM
113622011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11363
11364 * process.c (Qprocessp): Don't declare static.
11365 * lisp.h (Qprocessp): Declare again.
11366
7990b61a
JB
113672011-04-15 Juanma Barranquero <lekktu@gmail.com>
11368
11369 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11370
5d4cb038
PE
113712011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11372
8bd7b830 11373 Improve C-level modularity by making more things 'static'.
cd64ea1d 11374
e3b27b31
PE
11375 Don't publish debugger-only interfaces to other modules.
11376 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11377 (verify_bytepos, count_markers): Move decls to the only modules
11378 that need them.
11379 * region-cache.h (pp_cache): Likewise.
11380 * window.h (check_all_windows): Likewise.
11381 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11382
5d4cb038
PE
11383 * sysdep.c (croak): Now static, if
11384 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11385 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11386
11387 * alloc.c (refill_memory_reserve): Now static if
11388 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11389 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11390
e87b6180
PE
11391 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11392 Define only if USE_LUCID.
11393
ac64929e
PE
11394 * xrdb.c (x_customization_string, x_rm_string): Now static.
11395
6f37259d
PE
11396 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11397 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11398
1683e3ab
PE
11399 * xdisp.c (draw_row_with_mouse_face): Now static.
11400 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11401
de9c2632
PE
11402 * window.h (check_all_windows): Mark externally visible.
11403
2b96acb7
PE
11404 * window.c (window_deletion_count): Now static.
11405
11406 * undo.c: Make symbols static if they're not exported.
11407 (last_undo_buffer, last_boundary_position, pending_boundary):
11408 Now static.
11409
50436f33
PE
11410 * textprop.c (interval_insert_behind_hooks): Now static.
11411 (interval_insert_in_front_hooks): Likewise.
11412
64520e5c
PE
11413 * term.c: Make symbols static if they're not exported.
11414 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11415 (max_frame_lines, tty_set_terminal_modes):
11416 (tty_reset_terminal_modes, tty_turn_off_highlight):
11417 (get_tty_terminal): Now static.
11418 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11419 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11420 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11421 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11422 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11423
1fa53021
PE
11424 * sysdep.c: Make symbols static if they're not exported.
11425 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11426 Now static.
11427 (sigprocmask_set, full_mask): Remove; unused.
11428 (wait_debugging): Mark as visible.
11429 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11430 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11431
d4b43b22
PE
11432 * syntax.c (syntax_temp): Define only if !__GNUC__.
11433
b7c513d0
PE
11434 * sound.c (current_sound_device, current_sound): Now static.
11435
989b29ad
PE
11436 * search.c (searchbufs, searchbuf_head): Now static.
11437
13a55a78
PE
11438 * scroll.c (scroll_cost): Remove; unused.
11439 * dispextern.h (scroll_cost): Remove decl.
11440
de68a1fc
PE
11441 * region-cache.h (pp_cache): Mark as externally visible.
11442
40ccffa6
PE
11443 * process.c: Make symbols static if they're not exported.
11444 (process_tick, update_tick, create_process, chan_process):
11445 (Vprocess_alist, proc_buffered_char, datagram_access):
11446 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11447 (deactivate_process): Mark defn as static, as well as decl.
11448 * lisp.h (create_process): Remove decl.
11449 * process.h (chan_process, Vprocess_alist): Remove decls.
11450
ad64fc97
PE
11451 * print.c: Make symbols static if they're not exported.
11452 (print_depth, new_backquote_output, being_printed, print_buffer):
11453 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11454 (print_interval, print_number_index, initial_stderr_stream):
11455 Now static.
11456 * lisp.h (Fprinc): Remove decl.
11457 (debug_output_compilation_hack): Mark as externally visible.
11458
adddb265
PE
11459 * sysdep.c (croak): Move decl from here to syssignal.h.
11460 * syssignal.h (croak): Put it here, so the API can be checked when
11461 'croak' is called from dissociate_if_controlling_tty.
11462
1717ede2
PE
11463 * minibuf.c: Make symbols static if they're not exported.
11464 (minibuf_save_list, choose_minibuf_frame): Now static.
11465 * lisp.h (choose_minibuf_frame): Remove decl.
11466
fa5fb2bc
PE
11467 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11468
1e3890d1
PE
11469 * lread.c: Make symbols static if they're not exported.
11470 (read_objects, initial_obarray, oblookup_last_bucket_number):
11471 Now static.
11472 (make_symbol): Remove; unused.
11473 * lisp.h (initial_obarray, make_symbol): Remove decls.
11474
8a1414fa
PE
11475 * keyboard.c: Make symbols static if they're not exported.
11476 (single_kboard, recent_keys_index, total_keys, recent_keys):
11477 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11478 (this_single_command_key_start, echoing, last_auto_save):
11479 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11480 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11481 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11482 (Vlispy_mouse_stem, double_click_count):
11483 Now static.
11484 (force_auto_save_soon): Define only if SIGDANGER.
11485 (ignore_mouse_drag_p): Now static if
11486 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11487 (print_help): Remove; unused.
11488 (stop_character, last_timer_event): Mark as externally visible.
11489 * keyboard.h (ignore_mouse_drag_p): Declare only if
11490 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11491 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11492 * lisp.h (echoing): Remove decl.
11493 (force_auto_save_soon): Declare only if SIGDANGER.
11494 * xdisp.c (redisplay_window): Simplify code, to make it more
11495 obvious that ignore_mouse_drag_p is not accessed if !defined
11496 USE_GTK && !defined HAVE_NS.
11497
93ea6e8f
PE
11498 * intervals.c: Make symbols static if they're not exported.
11499 (merge_properties_sticky, merge_interval_right, delete_interval):
11500 Now static.
11501 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11502
77382fcc
PE
11503 * insdel.c: Make symbols static if they're not exported.
11504 However, leave prepare_to_modify_buffer alone. It's never
11505 called from outside this function, but that appears to be a bug.
11506 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11507 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11508 (adjust_after_replace_noundo): Remove; unused.
11509 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11510 (signal_before_change): Remove decls.
77382fcc 11511
9306c32e
PE
11512 * indent.c (val_compute_motion, val_vmotion): Now static.
11513
cd44d2eb
PE
11514 * image.c: Make symbols static if they're not exported.
11515 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11516 if USE_GTK.
11517 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11518 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11519
ad9a7a06
PE
11520 * fringe.c (standard_bitmaps): Now static.
11521 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11522
81626931
PE
11523 * frame.c: Make symbols static if they're not exported.
11524 (x_report_frame_params, make_terminal_frame): Now static.
11525 (get_frame_param): Now static, unless HAVE_NS.
11526 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11527 (x_get_resource_string): Remove; not used.
11528 * frame.h (make_terminal_frame, x_report_frame_params):
11529 (x_get_resource_string); Remove decls.
11530 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11531 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11532
239f9db9
PE
11533 * font.c, fontset.c: Make symbols static if they're not exported.
11534 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11535 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11536 * font.c (font_close_object): Now static.
11537 * font.h (font_close_object): Remove.
11538 * fontset.c (FONTSET_OBJLIST): Remove.
11539 (free_realized_fontset) #if-0 the body, which does nothing.
11540 (face_suitable_for_char_p): #if-0, as it's never called.
11541 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11542 * xfaces.c (face_at_string_position):
11543 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11544 since 0 is always ASCII.
11545
dfcf3579
PE
11546 * fns.c (weak_hash_tables): Now static.
11547
5045092b
PE
11548 * fileio.c: Make symbols static if they're not exported.
11549 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11550 (Vwrite_region_annotation_buffers): Now static.
11551
57a96f5c
PE
11552 * eval.c: Make symbols static if they're not exported.
11553 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11554 * lisp.h (backtrace_list): Remove decl.
11555
35f08c38
PE
11556 * emacs.c: Make symbols static if they're not exported.
11557 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11558 (fatal_error_code, fatal_error_signal_hook, standard_args):
11559 Now static.
11560 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11561 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11562 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11563 * lisp.h (fatal_error_signal_hook): Remove decl.
11564 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11565
f44bd759
PE
11566 * editfns.c: Move a (normally-unused) function to its only use.
11567 * editfns.c, lisp.h (get_operating_system_release): Remove.
11568 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11569 worth the hassle of breaking this out.
11570
b532497d
PE
11571 * xterm.c: Make symbols static if they're not exported.
11572 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11573 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11574 (x_destroy_window, x_delete_display):
11575 Now static.
11576 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11577 (x_mouse_leave): Remove; unused.
11578 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11579 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11580 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11581 Remove decls.
11582 (x_mouse_leave): Declare only if WINDOWSNT.
11583 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11584 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11585 USE_X_TOOLKIT.
11586
1675728f
PE
11587 * ftxfont.c: Make symbols static if they're not exported.
11588 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11589 HAVE_FREETYPE.
11590 * font.h (ftxfont_driver): Likewise.
11591
e4cebfca
PE
11592 * xfns.c: Make symbols static if they're not exported.
11593 (x_last_font_name, x_display_info_for_name):
11594 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11595 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11596 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11597 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11598 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11599 (last_show_tip_args): Now static.
11600 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11601 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11602 (x_screen_planes): Remove; unused.
11603 * dispextern.h (x_screen_planes): Remove decl.
11604
5bf46f05
PE
11605 * dispnew.c: Make symbols static if they're not exported.
11606 * dispextern.h (redraw_garbaged_frames, scrolling):
11607 (increment_row_positions): Remove.
11608 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11609 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11610 Now static.
11611 (redraw_garbaged_frames): Remove; unused.
11612
435f4c28
PE
11613 * xfaces.c: Make symbols static if they're not exported.
11614 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11615 Remove decls.
11616 * xterm.h (defined_color): Remove decls.
11617 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11618 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11619 (menu_face_changed_default, defined_color, free_realized_face):
11620 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11621 (ascii_face_of_lisp_face): Remove; unused.
11622
8524aef3
PE
11623 * xdisp.c: Make symbols static if they're not exported.
11624 * dispextern.h (scratch_glyph_row, window_box_edges):
11625 (glyph_to_pixel_coords, set_cursor_from_row):
11626 (get_next_display_element, set_iterator_to_next):
11627 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11628 (show_mouse_face): Remove decls
11629 * frame.h (message_buf_print): Likewise.
11630 * lisp.h (pop_message, set_message, check_point_in_composition):
11631 Likewise.
11632 * xterm.h (set_vertical_scroll_bar): Likewise.
11633 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11634 (message_buf_print, scratch_glyph_row, displayed_buffer):
11635 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11636 (get_next_display_element, show_mouse_face, window_box_edges):
11637 (frame_to_window_pixel_xy, check_point_in_composition):
11638 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11639 (glyph_to_pixel_coords): Remove; unused.
11640
16390cd2
PE
11641 * dired.c (file_name_completion): Now static.
11642
11643 * dbusbind.c (xd_in_read_queued_messages): Now static.
11644
a25f4dfa
PE
11645 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11646 * data.c (circular_list_error): Remove.
11647
14a9c8df
PE
11648 * commands.h (last_point_position, last_point_position_buffer):
11649 (last_point_position_window): Remove decls.
11650 * keyboard.c: Make these variables static.
11651
04f2d78b
CB
11652 * coding.h (coding, code_convert_region, encode_coding_gap):
11653 Remove decls.
74ab6df5
PE
11654 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11655 (iso_code_class, detect_coding, code_convert_region): Now static.
11656 (encode_coding_gap): Remove; unused.
11657
38dfbee1
PE
11658 * chartab.c (chartab_chars, chartab_bits): Now static.
11659
a2cb4e63
PE
11660 * charset.h (charset_iso_8859_1): Remove decl.
11661 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11662 Now static.
11663
127198fd
PE
11664 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11665 * ccl.c (Vccl_program_table): Now static.
11666 (check_ccl_update): Remove; unused.
11667
d85b608f
PE
11668 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11669 * category.h: ... from here.
11670 * category.c (check_category_table, set_category_set): Now static.
11671
31cd66f3
PE
11672 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11673 * lisp.h: Remove these decls.
11674
c358e587
PE
11675 * buffer.c (buffer_count): Remove unused var.
11676
e78aecca
PE
11677 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11678 so that it's not optimized away.
11679 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11680 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11681 exported only to the debugger.
11682
e192d7d3 11683 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11684 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11685
92470028
PE
11686 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11687 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11688 was inaccessible from Lisp.
11689 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11690 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11691
244ed907
PE
11692 alloc.c: Import and export fewer symbols, and remove unused items.
11693 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11694 is defined.
11695 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11696 it's not optimized away by whole-program optimization.
11697 (message_enable_multibyte, free_misc): Remove.
11698 (catchlist, handlerlist, mark_backtrace):
11699 Declare only if BYTE_MARK_STACK.
11700 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11701 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11702 (message_enable_multibyte): Remove decl.
11703 (free_misc, interval_free_list, float_block, float_block_index):
11704 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11705 (cons_free_list, last_marked_index):
11706 Now static.
11707 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11708 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11709 (mark_backtrace): Define only if BYTE_MARK_STACK.
11710 * xdisp.c (message_enable_multibyte): Now static.
11711
61c2b50e 11712 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11713 This makes it easier for human readers (and static analyzers)
11714 to see whether these variables are used from other modules.
11715 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11716 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11717 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11718 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11719 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11720 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11721 * xmenu.c, xselect.c:
11722 Declare Q* vars static if they are not used in other modules.
11723 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11724 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11725 Remove decls of unexported vars.
11726 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11727
95c82688
PE
11728 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11729
16a97296
PE
11730 Make Emacs functions such as Fatom 'static' by default.
11731 This makes it easier for human readers (and static analyzers)
11732 to see whether these functions can be called from other modules.
11733 DEFUN now defines a static function. To make the function external
11734 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11735 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11736 (Finit_image_library):
16a97296
PE
11737 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11738 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11739 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11740 Remove decls, since these functions are now static.
11741 (Funintern, Fget_internal_run_time): New decls, since these functions
11742 were already external.
95c82688 11743
16a97296
PE
11744 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11745 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11746 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11747 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11748 * keyboard.c, keymap.c, lread.c:
11749 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11750 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11751 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11752 Mark functions with DEFUE instead of DEFUN,
11753 if they are used in other modules.
11754 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11755 decls for now-static functions.
11756 * buffer.h (Fdelete_overlay): Remove decl.
11757 * callproc.c (Fgetenv_internal): Mark as internal.
11758 * composite.c (Fremove_list_of_text_properties): Remove decl.
11759 (Fcomposition_get_gstring): New forward static decl.
11760 * composite.h (Fcomposite_get_gstring): Remove decl.
11761 * dired.c (Ffile_attributes): New forward static decl.
11762 * doc.c (Fdocumntation_property): New forward static decl.
11763 * eval.c (Ffetch_bytecode): New forward static decl.
11764 (Funintern): Remove extern decl; now in .h file where it belongs.
11765 * fileio.c (Fmake_symbolic_link): New forward static decl.
11766 * image.c (Finit_image_library): New forward static decl.
11767 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11768 * intervals.h (Fprevious_property_change):
11769 (Fremove_list_of_text_properties): Remove decls.
11770 * keyboard.c (Fthis_command_keys): Remove decl.
11771 (Fcommand_execute): New forward static decl.
11772 * keymap.c (Flookup_key): New forward static decl.
11773 (Fcopy_keymap): Now static.
11774 * keymap.h (Flookup_key): Remove decl.
11775 * process.c (Fget_process): New forward static decl.
11776 (Fprocess_datagram_address): Mark as internal.
11777 * syntax.c (Fsyntax_table_p): New forward static decl.
11778 (skip_chars): Remove duplicate decl.
11779 * textprop.c (Fprevious_property_change): New forward static decl.
11780 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11781 Now internal.
11782 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11783 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11784
785bbd42
PE
11785 * editfns.c (Fformat): Remove unreachable code.
11786
8b913b57
AS
117872011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11788
11789 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11790 change. (Bug#8496)
11791
a6744a35
EZ
117922011-04-13 Eli Zaretskii <eliz@gnu.org>
11793
11794 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11795 when at ZV. (Bug#8487)
11796
e7974947
AS
117972011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11798
baad03f0
AS
11799 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11800 (Bug#8437)
11801 * keyboard.c (parse_tool_bar_item): Likewise.
11802 * sound.c (sound_cleanup, alsa_close): Likewise.
11803 * termcap.c (tgetent): Likewise.
11804 * xfns.c (x_default_font_parameter): Likewise.
11805 * xsettings.c (read_and_apply_settings): Likewise.
11806
e7974947
AS
11807 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11808 (overrun_check_free): Protoize.
11809
28272684
PE
118102011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11811
11812 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11813 since callers should never pass a negative size.
11814 Change the signature to match that of plain 'read' and 'write'; see
11815 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11816 * lisp.h: Update prototypes of emacs_write and emacs_read.
11817
11997c76
EZ
118182011-04-11 Eli Zaretskii <eliz@gnu.org>
11819
11820 * xdisp.c (redisplay_window): Don't try to determine the character
11821 position of the scroll margin if the window start point w->startp
e896f03c 11822 is outside the buffer's accessible region. (Bug#8468)
11997c76 11823
8a2cbd72
EZ
118242011-04-10 Eli Zaretskii <eliz@gnu.org>
11825
11826 Fix write-region and its subroutines for buffers > 2GB.
11827 * fileio.c (a_write, e_write): Modify declaration of arguments and
11828 local variables to support buffers larger than 2GB.
11829 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11830
11831 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11832 argument, local variables, and return value.
11833
11834 * lisp.h: Update prototypes of emacs_write and emacs_read.
11835
11836 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11837
4073e537 118382011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11839
1ebfdcb6
PE
11840 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11841
b2ded58d
PE
11842 Fix more problems found by GCC 4.6.0's static checks.
11843
7d66342c
PE
11844 * xdisp.c (vmessage): Use a better test for character truncation.
11845
bbf47d44
PE
11846 * charset.c (load_charset_map): <, not <=, for optimization,
11847 and to avoid potential problems with integer overflow.
9248994d 11848 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11849 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11850 * editfns.c (Fformat): Likewise.
1e69125e 11851 * syntax.c (skip_chars): Likewise.
3befa583 11852
e3019616
PE
11853 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11854 This also lets GCC 4.6.0 generate slightly better loop code.
11855
becfa255
PE
11856 * callint.c (Fcall_interactively): <, not <=, for optimization.
11857 (Fcall_interactively): Count the number of arguments produced,
11858 not the number of arguments given. This is simpler and lets GCC
11859 4.6.0 generate slightly better code.
11860
dae0cd48
PE
11861 * ftfont.c: Distingish more carefully between FcChar8 and char.
11862 The previous code passed unsigned char * to a functions like
11863 strlen and xstrcasecmp that expect char *, which does not
11864 conform to the C standard.
11865 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11866 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11867 char * when the C standard requires it.
11868
76032d70
PE
11869 * keyboard.c (read_char): Remove unused var.
11870
eb3f1cc8
PE
11871 * eval.c: Port to Windows vsnprintf (Bug#8435).
11872 Include <limits.h>.
11873 (SIZE_MAX): Define if the headers do not.
11874 (verror): Do not give up if vsnprintf returns a negative count.
11875 Instead, grow the buffer. This ports to Windows vsnprintf, which
11876 does not conform to C99. Problem reported by Eli Zaretskii.
11877 Also, simplify the allocation scheme, by avoiding the need for
11878 calling realloc, and removing the ALLOCATED variable.
11879
70476b54
PE
11880 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11881
12020a9e
PE
11882 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11883 But keep the doprint source code for now, as we might revamp it
11884 and use it again (Bug#8435).
ea6c7ae6
PE
11885 * lisp.h (doprnt): Remove.
11886 * Makefile.in (base_obj): Remove doprnt.o.
11887 * deps.mk (doprnt.o): Remove.
11888
5fdb398c
PE
11889 error: Print 32- and 64-bit integers portably (Bug#8435).
11890 Without this change, on typical 64-bit hosts error ("...%d...", N)
11891 was used to print both 32- and 64-bit integers N, which relied on
11892 undefined behavior.
61bdb816 11893 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11894 * lisp.h (error, verror): Mark as printf-like functions.
11895 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11896 Report overflow in size calculations when allocating printf buffer.
11897 Do not truncate output string at its first null byte.
11898 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11899 Truncate the output at a character boundary, since vsnprintf does not
11900 do that.
11901 * charset.c (check_iso_charset_parameter): Convert internal
11902 character to string before calling 'error', since %c now has the
11903 printf meaning.
11904 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11905 overflow when computing char to be passed to 'error'. Do not
11906 pass Lisp_Object to 'error'; pass the integer instead.
11907 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11908 formatted with plain %d.
11909
b189fa66
PE
11910 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11911
bff87ef0
PE
11912 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11913
7e2cac20
PE
11914 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11915
ce4d90b5
PE
11916 * xterm.c (x_catch_errors): Remove duplicate declaration.
11917
266c9547
PE
11918 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11919
79c49ad2
PE
11920 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11921
368f4090
JM
119222011-04-10 Jim Meyering <meyering@redhat.com>
11923
11924 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11925 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11926 return ssize_t not "int", and use size_t as the buffer length.
11927 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11928 * gnutls.h: Update declarations.
11929 * process.c (read_process_output): Use ssize_t, to match.
11930 (send_process): Likewise.
11931
a32d4040
CY
119322011-04-09 Chong Yidong <cyd@stupidchicken.com>
11933
11934 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11935
8546720e 119362011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11937
04f2d78b
CB
11938 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11939 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11940
8546720e
GM
11941 * xterm.c (handle_one_xevent):
11942 * xmenu.c (create_and_show_popup_menu):
11943 * xselect.c (x_decline_selection_request)
11944 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11945
0a2f5c1a 119462011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11947
11948 Fix some uses of `int' instead of EMACS_INT.
11949 * search.c (string_match_1, fast_string_match)
11950 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11951 (scan_buffer, find_next_newline_no_quit)
11952 (find_before_next_newline, search_command, Freplace_match)
11953 (Fmatch_data): Make some `int' variables be EMACS_INT.
11954
11955 * xdisp.c (display_count_lines): 3rd argument and return value now
11956 EMACS_INT. All callers changed.
11957 (pint2hrstr): Last argument is now EMACS_INT.
11958
11959 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11960 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11961 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11962 (decode_coding_utf_16, decode_coding_emacs_mule)
11963 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11964 (decode_coding_ccl, decode_coding_charset)
11965 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11966 (decode_coding_iso_2022, decode_coding_emacs_mule)
11967 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11968 <char_offset, last_offset>: Declare EMACS_INT.
11969 (encode_coding_utf_8, encode_coding_utf_16)
11970 (encode_coding_emacs_mule, encode_invocation_designation)
11971 (encode_designation_at_bol, encode_coding_iso_2022)
11972 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11973 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11974 Declare EMACS_INT.
11975 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11976 (encode_invocation_designation): Last argument P_NCHARS is now
11977 EMACS_INT.
11978 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11979 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11980
11981 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11982 All users changed.
11983
11984 * ccl.c (Fccl_execute_on_string): Declare some variables
11985 EMACS_INT.
11986
8546720e 119872011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11988
11989 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11990
4e19a977
CS
119912011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11992
11993 * process.c (Fformat_network_address): Doc fix.
11994
87302331
R
119952011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11996
ee7683eb 11997 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11998
cbb59342
CY
119992011-04-08 Chong Yidong <cyd@stupidchicken.com>
12000
12001 * keyboard.c (read_char): Call Lisp function help-form-show,
12002 instead of using internal_with_output_to_temp_buffer.
12003 (Qhelp_form_show): New var.
e0d38eeb 12004 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12005
12006 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12007
12008 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12009
e67a13ab
CY
120102011-04-06 Chong Yidong <cyd@stupidchicken.com>
12011
04f2d78b
CB
12012 * process.c (Flist_processes): Remove to Lisp.
12013 (list_processes_1): Delete.
e67a13ab 12014
973f782d
EZ
120152011-04-06 Eli Zaretskii <eliz@gnu.org>
12016
7c106b1e
EZ
12017 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12018
973f782d
EZ
12019 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12020
41cf7d1a 120212011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12022
ca23cc88
PE
12023 Fix more problems found by GCC 4.6.0's static checks.
12024
f390e2d5
PE
12025 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12026
42eea0d0
PE
12027 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12028
b69769da 12029 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12030
f9541e84
PE
12031 * xdisp.c (vmessage): Mark as a printf-like function.
12032
13841b55
PE
12033 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12034
c136c10f
PE
12035 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12036
5e2d4a30
PE
12037 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12038 printf-like functions.
12039 (tiff_load): Add casts to remove these marks before passing them
12040 to system-supplied API.
12041
583f48b9
PE
12042 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12043
b25d760e
PE
12044 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12045 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12046 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12047 directly, rather than having caller test rule sign. This avoids
12048 some unnecessary tests.
12049 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12050 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12051 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12052
bc7b6697 12053 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12054 (xfont_open): Avoid unnecessary tests.
bc7b6697 12055
27ccc379
PE
12056 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12057
dcd5c89a
PE
12058 * composite.h, composite.c (composition_gstring_put_cache):
12059 Use EMACS_INT, not int, for length.
12060
b13a45c6
PE
12061 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12062 breaking out part of COMPOSITION_DECODE_RULE.
12063 (COMPOSITION_DECODE_RULE): Use it.
12064 * composite.c (get_composition_id): Remove unused local vars,
12065 by using the new macro.
12066
1e792e4d
PE
12067 * textprop.c (set_text_properties_1): Change while to do-while,
12068 since the condition is always true at first.
12069
dc6c6455 12070 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12071 (interval_deletion_adjustment): Return unsigned value.
12072 All uses changed.
dc6c6455 12073
aba7731a
PE
12074 * process.c (list_processes_1, create_pty, read_process_output):
12075 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12076 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12077 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12078 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12079 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12080
fdfc4bf3
PE
12081 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12082
fca8fe46 12083 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12084 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12085
06a0259a 12086 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12087 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12088 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12089
e7b9e80f
PE
12090 * print.c (print_error_message): Avoid int overflow.
12091
56201685
PE
12092 * font.c (font_list_entities): Redo for clarity,
12093 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12094
78834453 12095 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12096 (font_score): Avoid potential overflow in diff calculation.
78834453 12097
0bc0b309 12098 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12099 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12100
e610eaca
PE
12101 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12102
b895abce
PE
12103 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12104 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12105 can always succeed if overflow has undefined behavior.
12106
1f1d9321 12107 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12108 (wordify): Omit three unnecessary tests.
1f1d9321 12109
c59478bc
PE
12110 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12111 All callers changed. This avoids the need for an unused var.
12112
79b73827
PE
12113 * casefiddle.c (casify_region): Remove var that is set but not used.
12114
a4db5dfe
PE
12115 * dired.c (file_name_completion): Remove var that is set but not used.
12116
43aae36e
PE
12117 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12118
2a47c44d 12119 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12120 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12121
a37c69bf
PE
12122 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12123 Check for integer overflow on size calculations.
12124
328ab8e7
PE
12125 * buffer.c (Fprevious_overlay_change): Remove var that is set
12126 but not used.
12127
e5a2a5cb
PE
12128 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12129 Remove vars that are set but not used.
8d84a6eb 12130 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12131 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12132
a60e5f68
PE
12133 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12134
f661cb61 12135 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12136 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12137
f0397f5a
PE
12138 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12139 that are set but not used.
12140
8664db06 12141 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12142 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12143
6abdaa4a
PE
12144 * xselect.c (x_get_local_selection, x_handle_property_notify):
12145 Remove vars that are set but not used.
12146
0ce7538d 12147 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12148 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12149
9ae848fc
PE
12150 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12151 Remove var that is set but not used.
0b918413
PE
12152 (scroll_bar_windows_size): Now size_t, not int.
12153 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12154 Check for overflow.
9ae848fc 12155
a5a62657
PE
12156 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12157 (map_tty_color) [!defined MSDOS]: Likewise.
12158
5c5cdd39
PE
12159 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12160
66ebf983
PE
12161 * coding.c: Remove vars that are set but not used.
12162 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12163 All callers changed.
12164 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12165 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12166 (decode_coding_charset): Remove vars that are set but not used.
12167
1be4d761
PE
12168 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12169 that is set but not used.
12170
47553fa8
PE
12171 * print.c (print_object): Remove var that is set but not used.
12172
1f7196bf 12173 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12174 The gnulib version avoids calling malloc in the usual case,
12175 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12176 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12177 * filelock.c (current_lock_owner): Likewise.
12178 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12179 * sysdep.c: Include allocator.h, careadlinkat.h.
12180 (emacs_no_realloc_allocator): New static constant.
12181 (emacs_readlink): New function.
fdb61804
PE
12182 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12183 ../lib/careadlinkat.h.
d1fdcab7 12184
f84c17c7
SM
121852011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12186
12187 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12188 first non-nil return value).
12189
ef3862ad
JD
121902011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12191
12192 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12193 if not defined (Bug#8403).
12194
376a7006
JB
121952011-04-02 Juanma Barranquero <lekktu@gmail.com>
12196
12197 * xdisp.c (display_count_lines): Remove parameter `start',
12198 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12199 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12200 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12201 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12202 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12203 and thereabouts. All callers changed.
12204 (get_per_char_metric): Remove parameter `f', unused since
12205 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12206
6ca3801d
JM
122072011-04-02 Jim Meyering <meyering@redhat.com>
12208
12209 do not dereference NULL upon failed strdup
12210 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12211 (ns_get_family): Likewise.
12212
d8e2b5ba
JB
122132011-04-02 Juanma Barranquero <lekktu@gmail.com>
12214
12215 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12216
8c74fcbd
JD
122172011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12218
12219 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12220 later (Bug#8403).
12221
7200d79c
SM
122222011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12223
03408648 12224 Add lexical binding.
7200d79c 12225
03408648
SM
12226 * window.c (Ftemp_output_buffer_show): New fun.
12227 (Fsave_window_excursion):
12228 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12229
12230 * lread.c (lisp_file_lexically_bound_p): New function.
12231 (Fload): Bind Qlexical_binding.
12232 (readevalloop): Remove `evalfun' arg.
12233 Bind Qinternal_interpreter_environment.
12234 (Feval_buffer): Bind Qlexical_binding.
12235 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12236 Mark as dynamic.
12237 (syms_of_lread): Declare `lexical-binding'.
12238
12239 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12240
12241 * keyboard.c (eval_dyn): New fun.
12242 (menu_item_eval_property): Use it.
ca105506
SM
12243
12244 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12245
03408648
SM
12246 * fns.c (concat, mapcar1): Accept byte-code-functions.
12247
12248 * eval.c (Fsetq): Handle lexical vars.
12249 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12250 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12251 (FletX, Flet): Obey lexical binding.
12252 (Fcommandp): Handle closures.
12253 (Feval): New `lexical' arg.
12254 (eval_sub): New function extracted from Feval. Use it almost
12255 everywhere where Feval was used. Look up vars in lexical env.
12256 Handle closures.
12257 (Ffunctionp): Move from subr.el.
12258 (Ffuncall): Handle closures.
12259 (apply_lambda): Remove `eval_flags'.
12260 (funcall_lambda): Handle closures and new byte-code-functions.
12261 (Fspecial_variable_p): New function.
12262 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12263 but without exporting it to Lisp.
23aba0ea 12264
23aba0ea 12265 * doc.c (Fdocumentation, store_function_docstring):
03408648 12266 * data.c (Finteractive_form): Handle closures.
23aba0ea 12267
03408648
SM
12268 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12269 interactive spec.
ba83908c 12270
04f2d78b
CB
12271 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12272 New byte-codes.
03408648
SM
12273 (exec_byte_code): New function extracted from Fbyte_code to handle new
12274 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12275
03408648 12276 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12277
03408648 12278 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12279
e2abce01
JB
122802011-03-31 Juanma Barranquero <lekktu@gmail.com>
12281
12282 * xdisp.c (redisplay_internal): Fix prototype.
12283
63696a73 122842011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12285
63696a73 12286 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12287 (try_scrolling): Use it when setting scroll_limit.
12288 Limit scrolling to 100 screen lines.
63696a73
EZ
12289 (redisplay_window): Even when falling back on "recentering",
12290 position point in the window according to scroll-conservatively,
12291 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12292
12293 (try_scrolling): When point is above the window, allow searching
12294 as far as scroll_max, or one screenful, to compute vertical
12295 distance from PT to the scroll margin position. This prevents
12296 try_scrolling from unnecessarily failing when
12297 scroll-conservatively is set to a value slightly larger than the
12298 window height. Clean up the case of PT below the margin at bottom
12299 of window: scroll_max can no longer be INT_MAX. When aggressive
12300 scrolling is in use, don't let point enter the opposite scroll
12301 margin as result of the scroll.
12302 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12303 threshold of 100 lines for never-recentering scrolling.
12304
e4cc2dfc
JB
123052011-03-31 Juanma Barranquero <lekktu@gmail.com>
12306
12307 * dispextern.h (move_it_by_lines):
12308 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12309 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12310 (message_log_check_duplicate): Remove parameters `prev_bol' and
12311 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12312 (redisplay_internal): Remove parameter `preserve_echo_area',
12313 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12314
12315 * indent.c (Fvertical_motion):
12316 * window.c (window_scroll_pixel_based, Frecenter):
12317 Don't pass `need_y_p' to `move_it_by_lines'.
12318
1c470562
SM
123192011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12320
44f230aa
SM
12321 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12322 steal a few bits to be more compact.
12323 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12324 Remove unneeded casts.
12325
1c470562
SM
12326 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12327
888adce9
ZK
123282011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12329
12330 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12331 binding" message (bug#7967).
12332
f838ed7b
PE
123332011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12334
77861b95
PE
12335 Fix more problems found by GCC 4.6.0's static checks.
12336
de6dbc14
PE
12337 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12338 Remove unused local var.
12339
f838ed7b
PE
12340 * editfns.c (Fmessage_box): Remove unused local var.
12341
792c7b2b
PE
12342 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12343 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12344 Omit unused local vars.
c499e557 12345 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12346 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12347 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12348 Omit unused local var.
12349
ba0165e1
PE
12350 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12351 Don't assume string length fits in int.
32ad8845 12352 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12353 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12354
3c59b4c9
PE
12355 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12356 instead of alloca (Bug#8344).
12357
a3eed478 12358 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12359 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12360
eb4d412d
PE
12361 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12362
1658b401
PE
12363 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12364 concerns.
12365
12366 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12367
12368 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12369
9a2c6e05
PE
12370 * keyboard.c (syms_of_keyboard): Use the same style as later
12371 in this function when indexing through an array. This also
12372 works around GCC bug 48267.
12373
03d0a109
PE
12374 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12375
44f730c8
PE
12376 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12377
fe75f926
PE
12378 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12379 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12380
ffa8c828
PE
12381 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12382 This avoids undefined behavior on integer overflow, and is a bit
12383 more convenient anyway since it is compared to a size_t variable.
12384
c5101a77
PE
12385 Variadic C functions now count arguments with size_t, not int.
12386 This avoids an unnecessary limitation on 64-bit machines, which
12387 caused (substring ...) to crash on large vectors (Bug#8344).
12388 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12389 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12390 All variadic functions and their callers changed accordingly.
c5101a77
PE
12391 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12392 * data.c (arith_driver, float_arith_driver): Likewise.
12393 * editfns.c (general_insert_function): Likewise.
12394 * eval.c (struct backtrace.nargs, interactive_p)
12395 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12396 (funcall_lambda, mark_backtrace): Likewise.
12397 * fns.c (concat): Likewise.
12398 * frame.c (x_set_frame_parameters): Likewise.
12399 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12400 0 if not found, not -1. All callers changed.
12401
dd3f25f7
PE
12402 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12403 (stack_copy_size): Now size_t, not int.
12404 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12405
461c2ab9
JB
124062011-03-28 Juanma Barranquero <lekktu@gmail.com>
12407
12408 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12409 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12410 All callers changed.
12411
12412 * lisp.h (multibyte_char_to_unibyte):
12413 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12414 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12415 * character.h (CHAR_TO_BYTE8):
12416 * cmds.c (internal_self_insert):
12417 * editfns.c (general_insert_function):
12418 * keymap.c (push_key_description):
12419 * search.c (Freplace_match):
12420 * xdisp.c (message_dolog, set_message_1): All callers changed.
12421
f6d62986
SM
124222011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12423
12424 * keyboard.c (safe_run_hook_funcall): New function.
12425 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12426 don't set the hook to nil, but remove the offending function instead.
12427 (Qcommand_hook_internal): Remove, unused.
12428 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12429 Vcommand_hook_internal.
12430
12431 * eval.c (enum run_hooks_condition): Remove.
12432 (funcall_nil, funcall_not): New functions.
12433 (run_hook_with_args): Call each function through a `funcall' argument.
12434 Remove `cond' argument, now redundant.
12435 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12436 (Frun_hook_with_args_until_failure): Adjust accordingly.
12437 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12438
1db5b1ad
JB
124392011-03-28 Juanma Barranquero <lekktu@gmail.com>
12440
12441 * dispextern.h (string_buffer_position): Remove declaration.
12442
12443 * print.c (strout): Remove parameter `multibyte', unused since
12444 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12445
12446 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12447 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12448 All callers changed.
12449
12450 * w32.c (_wsa_errlist): Use braces for struct initializers.
12451
12452 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12453 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12454 All callers changed.
12455 (string_buffer_position): Likewise. Also, make static (it's never
12456 used outside xdisp.c).
12457 (cursor_row_p): Remove parameter `w', unused since
12458 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12459 (decode_mode_spec): Remove parameter `precision', introduced during
12460 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12461 All callers changed.
12462
5ffb62aa
JD
124632011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12464
12465 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12466
461c2ab9 124672011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12468
12469 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12470 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12471 (ns_update_auto_hide_menu_bar): New functions.
12472 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12473 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12474 ns_constrain_all_frames.
12475 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12476 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12477
5c380ffb
JD
124782011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12479
12480 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12481
9af30bdf
GM
124822011-03-27 Glenn Morris <rgm@gnu.org>
12483
12484 * syssignal.h: Replace RETSIGTYPE with void.
12485 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12486 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12487 Replace SIGTYPE with void everywhere.
12488 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12489 * s/template.h (SIGTYPE): Remove commented out definition.
12490
e2abce01
JB
124912011-03-26 Eli Zaretskii <eliz@gnu.org>
12492
12493 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12494 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12495
f868cd8a
JB
124962011-03-26 Juanma Barranquero <lekktu@gmail.com>
12497
59eb0929
JB
12498 * w32.c (read_unc_volume): Use parameter `henum', instead of
12499 global variable `wget_enum_handle'.
12500
12501 * keymap.c (describe_vector): Remove parameters `indices' and
12502 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12503 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12504
f868cd8a
JB
12505 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12506
12507 * keyboard.c (timer_check): Remove parameter `do_it_now',
12508 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12509 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12510 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12511
12512 * keyboard.c (read_char):
12513 * w32menu.c (w32_menu_display_help):
12514 * xmenu.c (show_help_event, menu_help_callback):
12515 Adjust calls to `show_help_echo'.
12516
12517 * gtkutil.c (xg_maybe_add_timer):
12518 * keyboard.c (readable_events):
12519 * process.c (wait_reading_process_output):
12520 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12521
12522 * insdel.c (adjust_markers_gap_motion):
12523 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12524 (gap_left, gap_right): Don't call it.
12525
2ecf6fdb
CY
125262011-03-25 Chong Yidong <cyd@stupidchicken.com>
12527
12528 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12529 incurred during fontification.
12530
6b1f9ba4
JB
125312011-03-25 Juanma Barranquero <lekktu@gmail.com>
12532
12533 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12534 (DEFVAR_PER_BUFFER): Don't pass it.
12535
12536 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12537 (scrolling_window): Don't pass it.
12538
0f4a96b5
JB
125392011-03-25 Juanma Barranquero <lekktu@gmail.com>
12540
12541 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12542
12543 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12544 and `suffix'.
12545 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12546 of variables specific to SELinux and computation of `encoded_absname'.
12547
12548 * image.c (XPutPixel): Remove unused variable `height'.
12549
12550 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12551
12552 * unexw32.c (get_section_info): Remove unused variable `section'.
12553
12554 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12555 (system_process_attributes): Remove unused variable `sess'.
12556 (sys_read): Remove unused variable `err'.
12557
12558 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12559 (w32_wnd_proc): Remove unused variable `isdead'.
12560 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12561 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12562 (x_create_tip_frame): Remove unused variable `tem'.
12563
12564 * w32inevt.c (w32_console_read_socket):
12565 Remove unused variable `no_events'.
12566
12567 * w32term.c (x_draw_composite_glyph_string_foreground):
12568 Remove unused variable `width'.
12569
1149507c
JB
125702011-03-24 Juanma Barranquero <lekktu@gmail.com>
12571
12572 * w32term.c (x_set_glyph_string_clipping):
12573 Don't pass uninitialized region to CombineRgn.
12574
9c88f339
JB
125752011-03-23 Juanma Barranquero <lekktu@gmail.com>
12576
12577 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12578 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12579 (Fx_close_connection): Remove unused variable `i'.
12580
12581 * w32font.c (w32font_draw): Return number of glyphs.
12582 (w32font_open_internal): Remove unused variable `i'.
12583 (w32font_driver): Add missing initializer.
12584
12585 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12586 (fill_in_menu): Remove unused variable `items_added'.
12587
12588 * w32term.c (last_mouse_press_frame): Remove static global variable.
12589 (w32_clip_to_row): Remove unused variable `f'.
12590 (x_delete_terminal): Remove unused variable `i'.
12591
12592 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12593 (NOTHING): Remove unused static global variable.
12594 (uniscribe_check_otf): Remove unused variable `table'.
12595 (uniscribe_font_driver): Add missing initializers.
12596
dee091a3
JD
125972011-03-23 Julien Danjou <julien@danjou.info>
12598
12599 * term.c (Fsuspend_tty, Fresume_tty):
12600 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12601 * window.c (temp_output_buffer_show):
12602 * insdel.c (signal_before_change):
12603 * frame.c (Fhandle_switch_frame):
12604 * fileio.c (Fdo_auto_save):
12605 * emacs.c (Fkill_emacs):
12606 * editfns.c (save_excursion_restore):
12607 * cmds.c (internal_self_insert):
12608 * callint.c (Fcall_interactively):
12609 * buffer.c (Fkill_all_local_variables):
12610 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12611 Use Frun_hooks.
0f4a96b5 12612 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12613 unconditionally since it does the check itself.
dee091a3 12614
2c520ab5 126152011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12616
c9c49752
PE
12617 Fix more problems found by GCC 4.5.2's static checks.
12618
8abc3f12
PE
12619 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12620 the first time through the loop, since we know p0 < p1 then.
12621 This also avoids a gcc -Wstrict-overflow warning.
12622
a2d26660
PE
12623 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12624 leading to a memory leak, possible in functions like
12625 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12626 of objects (Bug#8318).
a2d26660 12627
916c72e9
PE
12628 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12629 that could (at least in theory) be that large.
12630
19ab8a18
PE
12631 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12632 This is less likely to overflow, and avoids undefined behavior if
12633 overflow does occur. All callers changed. Use strtoul to scan
12634 for the unsigned long integer.
b7cbbd6f
PE
12635 (pint2hrstr): Simplify and tune code slightly.
12636 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12637
f0641eff
PE
12638 * scroll.c (do_scrolling): Work around GCC bug 48228.
12639 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12640
7f650bb9
PE
12641 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12642 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12643 (validate_x_resource_name): Simplify count usage.
12644 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12645
37dd57d1
PE
12646 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12647 fail (Bug#8306).
81e56e61 12648
699979fc 12649 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12650
401bf9b4
PE
12651 * process.c (Fmake_network_process): Use socklen_t, not int,
12652 where POSIX says socklen_t is required in portable programs.
12653 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12654 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12655 (Fmake_network_process, server_accept_connection):
12656 (wait_reading_process_output, read_process_output):
12657 Likewise.
12658
b93aacde
PE
12659 * process.c: Rename or move locals to avoid shadowing.
12660 (list_processes_1, Fmake_network_process):
12661 (read_process_output_error_handler, exec_sentinel_error_handler):
12662 Rename or move locals.
4dc343ee 12663 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12664 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12665 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12666 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12667 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12668
af8a867c 12669 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12670 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12671 Include tparam.h instead, since it declares them.
af8a867c
PE
12672 * cm.h (PC): Remove extern decl; tparam.h now does this.
12673 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12674 * terminfo.c: Include tparam.h, to check interfaces.
12675 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12676 (tparam): Adjust signature to match interface in tparam.h;
12677 this removes some undefined behavior. Check that outstring and len
12678 are zero, which they always are with Emacs.
12679 * tparam.h (PC, BC, UP): New extern decls.
12680
0248044d 12681 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12682 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12683
8ff096c1 12684 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12685 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12686 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12687 (ftfont_list): Remove unused local.
49eaafba
PE
12688 (get_adstyle_property, ftfont_pattern_entity):
12689 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12690 Rename locals to avoid shadowing.
8ff096c1 12691
e2be39f6
PE
12692 * xfont.c (xfont_list_family): Mark var as initialized.
12693
c9735e30
PE
12694 * xml.c (make_dom): Now static.
12695
8f5201ae
PE
12696 * composite.c (composition_compute_stop_pos): Rename local to
12697 avoid shadowing.
b246f932
PE
12698 (composition_reseat_it): Remove unused locals.
12699 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12700 (composition_update_it): Mark var as initialized.
11b61122
PE
12701 (find_automatic_composition): Mark vars as initialized,
12702 with a FIXME (Bug#8290).
8f5201ae 12703
760fbc2c
PE
12704 character.h: Rename locals to avoid shadowing.
12705 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12706 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12707 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12708 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12709 to avoid shadowing.
12710
ff08eb85
PE
12711 * textprop.c (property_change_between_p): Remove; unused.
12712
fc7bf025
PE
12713 * intervals.c (interval_start_pos): Now static.
12714
235d7abc
PE
12715 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12716
44f230aa
SM
12717 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12718 Rename locals to avoid shadowing.
3e7d6594 12719
50060332
PE
12720 * sound.c (wav_play, au_play, Fplay_sound_internal):
12721 Fix pointer signedness.
d01f234b 12722 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12723 (wav_play): Initialize a variable to 0, to prevent undefined
12724 behavior (Bug#8278).
50060332 12725
c4fc4e30
PE
12726 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12727
918436ed
PE
12728 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12729
c939f91b
PE
12730 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12731 clobbering (Bug#8298).
b9c7f648
PE
12732 * sysdep.c (sys_subshell): Likewise.
12733 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12734
6bd8c144
PE
12735 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12736 This should get cleaned up, so that child_setup has the
12737 same signature on all platforms.
12738
7710357c 12739 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12740 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12741
c59da222
CY
127422011-03-22 Chong Yidong <cyd@stupidchicken.com>
12743
12744 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12745 not to be necessary, and produces flickering.
12746
66b87493
GM
127472011-03-20 Glenn Morris <rgm@gnu.org>
12748
12749 * config.in: Remove file.
12750
45b6f6d5
JB
127512011-03-20 Juanma Barranquero <lekktu@gmail.com>
12752
12753 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12754 are now in src/globals.h.
12755 (syms_of_minibuf): Remove spurious & from previous change.
12756
cd394be1 127572011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12758
12759 * minibuf.c (completing-read-function): New variable.
12760 (completing-read-default): Rename from completing-read.
12761 (completing-read): Call completing-read-function.
12762
b14e3e21
CY
127632011-03-19 Juanma Barranquero <lekktu@gmail.com>
12764
12765 * xfaces.c (Fx_load_color_file):
12766 Read color file from absolute filename (bug#8250).
12767
f2b726e6
JB
127682011-03-19 Juanma Barranquero <lekktu@gmail.com>
12769
12770 * makefile.w32-in: Update dependencies.
12771
09f6ff02
EZ
127722011-03-17 Eli Zaretskii <eliz@gnu.org>
12773
12774 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12775
29a6015a
PE
127762011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12777
a3a6c54e
PE
12778 Fix more problems found by GCC 4.5.2's static checks.
12779
b766f867
PE
12780 * process.c (make_serial_process_unwind, send_process_trap):
12781 (sigchld_handler): Now static.
12782
be02381c
PE
12783 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12784 That way, the code declares only the vars that it needs.
12785 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12786 * s/cygwin.h (PTY_ITERATION): Likewise.
12787 * s/darwin.h (PTY_ITERATION): Likewise.
12788 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12789
57048744
PE
12790 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12791 * process.c (allocate_pty): Don't declare stb unless it's needed.
12792
7914961c 12793 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12794 (CONSTANTLIM): Remove; unused.
12795 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12796 Define only if needed.
7914961c 12797
b3967b18
PE
12798 * unexelf.c (unexec): Name an expression,
12799 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12800 Use a different way to cause a compilation error if anyone uses
12801 n rather than nn, a way that does not involve shadowing.
73366a00 12802 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12803
29a6015a
PE
12804 * deps.mk (unexalpha.o): Remove; unused.
12805
43cfc33e 12806 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12807 * unexec.h: New file.
ce701a33
PE
12808 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12809 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12810 Depend on unexec.h.
12811 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12812 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12813 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12814 Change as necessary to match prototype in unexec.h.
ce701a33 12815
01f44d5a
PE
12816 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12817 shadowing.
4f63c6bb 12818 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12819
a6670b0b
PE
12820 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12821 Rename locals to avoid shadowing.
12822
cef2010d 12823 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12824 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12825
d4d7173a
PE
12826 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12827
f08b802a
PE
12828 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12829 warning when compiling print.c.
12830
3ddb0639
PE
12831 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12832 instead of using an uninitialized var.
5ad03b97 12833 (font_sort_entities): Mark var as initialized.
3ddb0639 12834
170a2692
PE
12835 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12836
e663c700
PE
12837 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12838 pointers to constants.
89bc529a 12839 (font_parse_fcname): Remove unused vars.
7b81e2d0 12840 (font_delete_unmatched): Now static.
ea838e10 12841 (font_get_spec): Remove; unused.
13a547c6
PE
12842 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12843 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12844 Rename or move locals to avoid shadowing.
e663c700 12845
2a80c887 12846 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12847 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12848
1384fa33 12849 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12850 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12851
8b2c52e9
PE
12852 * alloc.c (mark_backtrace): Move decl from here ...
12853 * lisp.h: ... to here, so that it can be checked.
12854
475545b5 12855 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12856 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12857 (lisp_indirect_variable): Name an expression,
12858 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12859 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12860
b1349114 12861 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12862 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12863 Use const pointer when appropriate.
b1349114 12864
a2928364
PE
12865 * lisp.h (get_system_name, get_operating_system_release):
12866 Move decls here, to check interfaces.
12867 * process.c (get_operating_system_release): Move decl to lisp.h.
12868 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12869 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12870 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12871 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12872 (Fformat_time_string, Fencode_time, Finsert_char):
12873 (Ftranslate_region_internal, Fformat):
12874 Rename or remove local vars to avoid shadowing.
9710023e 12875 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12876
a415e694
PE
12877 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12878 avoid shadowing.
12879
8ef4622d
PE
12880 * lisp.h (eassert): Check that the argument compiles, even if
12881 ENABLE_CHECKING is not defined.
12882
946f9a5b
PE
12883 * data.c (Findirect_variable): Name an expression, to avoid
12884 gcc -Wbad-function-cast warning.
112396d6 12885 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12886 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12887 (Fmake_variable_buffer_local, Fmake_local_variable):
12888 Mark variables as initialized.
52746918 12889 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12890
e5aab7e7 12891 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12892 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12893 Rename locals to avoid shadowing.
dff45157
PE
12894 (mark_stack): Move local variables into the #ifdef region where
12895 they're used.
7bc26fdb
PE
12896 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12897 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12898 needed otherwise.
12899 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12900 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12901 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12902
e5aab7e7
PE
12903 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12904 avoids undefined behavior in theory.
12905
4da60324
PE
12906 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12907
88043301
PE
12908 Use functions, not macros, for up- and down-casing (Bug#8254).
12909 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12910 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12911 to use the following functions instead of these macros.
12912 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12913 EMACS_INT, since callers assume the returned value fits in int.
12914 (upcase1): Likewise, for UPCASE_TABLE.
12915 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12916 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12917 the race-condition problem in the old DOWNCASE.
88043301 12918
19ed5445
PE
12919 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12920 Rename locals to avoid shadowing.
12921 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12922 (regex_compile, re_search_2, re_match_2_internal):
12923 Remove unused local vars.
952db0d7
PE
12924 (FREE_VAR): Rewrite so as not to use empty "else",
12925 which gcc can warn about.
da053e48 12926 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12927 (RETALLOC_IF): Define only if needed.
12928 (WORDCHAR_P): Likewise. This one is never needed, but is used
12929 only in a comment talking about a compiler bug, so put inside
12930 the #if 0 of that comment.
12931 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12932 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12933 Remove; unused.
19ed5445 12934
1f3561e4 12935 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12936 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12937 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12938
ded6f8f7
PE
12939 * search.c (simple_search): Remove unused var.
12940
dbd37a95
PE
12941 * dired.c (compile_pattern): Move decl from here ...
12942 * lisp.h: ... to here, so that it can be checked.
12943 (struct re_registers): New forward decl.
12944
7e47afad
PE
12945 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12946
85f24f61
PE
12947 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12948 All uses changed.
12949 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12950 Rename locals to avoid shadowing.
5671df8f 12951 (Fvertical_motion): Mark locals as initialized.
85f24f61 12952
181aa2be 12953 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12954 (casify_region): Mark local as initialized.
181aa2be 12955
930d429c
PE
12956 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12957
7082eac6
PE
12958 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12959 New macros, so that the caller can use some names other than
12960 gcpro1, gcpro2, etc.
12961 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12962 of the new macros.
12963 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12964 argument, for consistency with GCPRO2_VAR, etc: it is now the
12965 prefix of the variable, not the variable itself. All uses
12966 changed.
38b2c076
PE
12967 * dired.c (directory_files_internal, file_name_completion):
12968 Rename locals to avoid shadowing.
12969
15206ed9
PE
12970 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12971 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12972 dired.c's scmp function, had undefined behavior.
12973 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12974 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12975 * buffer.h: ... to here, because these macros use current_buffer,
12976 and the new implementation with inline functions needs to have
12977 current_buffer in scope now, rather than later when the macros
12978 are used.
12979 (downcase, upcase1): New static inline functions.
12980 (DOWNCASE, UPCASE1): Reimplement using these functions.
12981 This avoids undefined behavior in expressions like
12982 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12983 from race conditions in accessing the global variables
12984 case_temp1 and case_temp2.
12985 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12986 * lisp.h (case_temp1, case_temp2): Remove their decls.
12987 * character.h (ASCII_CHAR_P): Move from here ...
12988 * lisp.h: ... to here, so that the inline functions mentioned
12989 above can use them.
12990
4a6bea26
PE
12991 * dired.c (directory_files_internal_unwind): Now static.
12992
f14b7e14
PE
12993 * fileio.c (file_name_as_directory, directory_file_name):
12994 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12995 Now static.
2893f146
PE
12996 (file_name_as_directory): Use const pointers when appropriate.
12997 (Fexpand_file_name): Likewise. In particular, newdir might
12998 point at constant storage, so make it a const pointer.
fd4ead52 12999 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13000 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13001 signedness issues.
f839df0c
PE
13002 (Fset_file_times, Finsert_file_contents, auto_save_error):
13003 Rename locals to avoid shadowing.
f14b7e14 13004
5716756e 13005 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13006 (Ftry_completion, Fall_completions): Rename or remove locals
13007 to avoid shadowing.
5716756e 13008
b4c3046a
PE
13009 * marker.c (bytepos_to_charpos): Remove; unused.
13010
b45db522
PE
13011 * lisp.h (verify_bytepos, count_markers): New decls,
13012 so that gcc does not warn that these functions aren't declared.
13013
85876d07
PE
13014 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13015 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13016 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13017 (copy_text): Remove unused local var.
85876d07 13018
03d78a21 13019 * filelock.c (within_one_second): Now static.
b3dd38ab 13020 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13021
5df8f01b
PE
13022 * buffer.c (fix_overlays_before): Mark locals as initialized.
13023 (fix_start_end_in_overlays): Likewise. This function should be
13024 simplified by using pointers-to-pointers, but that's a different
13025 matter.
b1d876f1 13026 (switch_to_buffer_1): Now static.
8f54f30a
PE
13027 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13028 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13029
a70072c9 13030 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13031 Fix pointer signedness issue.
edced198
PE
13032 (sys_subshell): Mark local as volatile if checking for lint,
13033 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13034 (MAXPATHLEN): Define only if needed.
a70072c9 13035
a0977c44
PE
13036 * process.c (serial_open, serial_configure): Move decls from here ...
13037 * systty.h: ... to here, so that they can be checked.
13038
a884fdcc
PE
13039 * fns.c (get_random, seed_random): Move extern decls from here ...
13040 * lisp.h: ... to here, so that they can be checked.
13041
604efe86 13042 * sysdep.c (reset_io): Now static.
b8950c94 13043 (wait_for_termination_signal): Remove; unused.
604efe86 13044
38fc62d9
PE
13045 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13046 (copy_keymap_item, append_key, push_text_char_description):
13047 Now static.
1004a21a 13048 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13049 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13050 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13051 (describe_map_tree):
13052 Rename locals to avoid shadowing.
38fc62d9 13053
2f2650da
PE
13054 * keyboard.c: Declare functions static if they are not used elsewhere.
13055 (echo_char, echo_dash, cmd_error, top_level_2):
13056 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13057 (read_char, kbd_buffer_get_event, make_lispy_position):
13058 (make_lispy_event, make_lispy_movement, apply_modifiers):
13059 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13060 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13061 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13062 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13063 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13064
a053e86c 13065 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13066 (mark_kboards): Move decl here ...
13067 * alloc.c (mark_kboards): ... from here.
a053e86c 13068
4752793e
PE
13069 * lisp.h (force_auto_save_soon): New decl.
13070
74f10ca7 13071 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13072 (DEFINE_DUMMY_FUNCTION): New macro.
13073 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13074 Use it.
c03cd23f
PE
13075 (main): Add casts to avoid warnings
13076 if GCC considers string literals to be constants.
74f10ca7 13077
022e70d4
PE
13078 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13079
59d6fe83
PE
13080 * dbusbind.c: Pointer signedness fixes.
13081 (xd_signature, xd_append_arg, xd_initialize):
13082 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13083 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13084 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13085 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13086
78320123
PE
13087 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13088 if GCC considers string literals to be constants.
49cebcca 13089 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13090
35ac2a97
SM
130912011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13092
fb103ca9
SM
13093 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13094 (print_preprocess, print_object): New macro to fix last change.
13095
35ac2a97
SM
13096 * print.c (print_preprocess): Don't forget font objects.
13097
62973b41
JB
130982011-03-16 Juanma Barranquero <lekktu@gmail.com>
13099
13100 * emacs.c (USAGE3): Doc fixes.
13101
0e48bb22
AS
131022011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13103
13104 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13105 structure.
13106
7684e57b
JB
131072011-03-14 Juanma Barranquero <lekktu@gmail.com>
13108
13109 * lisp.h (VWindow_system, Qfile_name_history):
13110 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13111 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13112 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13113
13114 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13115 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13116
13117 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13118 * w32console.c (detect_input_pending, read_input_pending)
13119 (encode_terminal_code):
13120 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13121 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13122 (w32_system_caret_y, Qfile_name_history):
13123 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13124 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13125 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13126 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13127 * w32proc.c (Qlocal, report_file_error):
13128 * w32term.c (Vwindow_system, updating_frame):
13129 * w32uniscribe.c (initialized, uniscribe_font_driver):
13130 Remove unneeded extern declarations.
13131
2aa46d6c
CY
131322011-03-14 Chong Yidong <cyd@stupidchicken.com>
13133
c96bbc66 13134 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13135
cffc6f3b
CY
131362011-03-13 Chong Yidong <cyd@stupidchicken.com>
13137
13138 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13139 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13140 These macros can no longer be used for assignment.
13141
44f230aa
SM
13142 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13143 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13144 (record_buffer_markers, fetch_buffer_markers): New functions for
13145 recording and fetching special buffer markers.
13146 (set_buffer_internal_1, set_buffer_temp): Use them.
13147
13148 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13149
13150 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13151
13152 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13153 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13154
13155 * xdisp.c (hscroll_window_tree):
13156 (reconsider_clip_changes): Use PT instead of BUF_PT.
13157
d251f04b
EZ
131582011-03-13 Eli Zaretskii <eliz@gnu.org>
13159
13160 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13161 $(EMACS_ROOT)/lib/intprops.h.
13162
f0c77cd1
PE
131632011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13164
3eca4629
PE
13165 Fix more problems found by GCC 4.5.2's static checks.
13166
7c86ee98
PE
13167 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13168 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13169 (xg_free_frame_widgets): Make it clear that a local variable is
13170 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13171 (gdk_window_get_screen): Make it clear that this macro is needed
13172 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13173 (int_gtk_range_get_value): New function, which avoids a diagnostic
13174 from gcc -Wbad-function-cast.
13175 (xg_set_toolkit_scroll_bar_thumb): Use it.
13176 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13177 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13178 (get_utf8_string, xg_get_file_with_chooser):
13179 Rename locals to avoid shadowing.
13180 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13181
41729b81
PE
13182 * xgselect.c (xg_select): Remove unused var.
13183
f0c77cd1
PE
13184 * image.c (four_corners_best): Mark locals as initialized.
13185 (gif_load): Initialize transparent_p to zero (Bug#8238).
13186 Mark another local as initialized.
ec6cf4c6 13187 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13188
ce0ad53d 13189 * image.c (clear_image_cache): Now static.
d5d5a617 13190 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13191 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13192 (x_edge_detection): Remove unnecessary cast that
13193 gcc -Wbad-function-cast diagnoses.
2037898d 13194 (gif_load): Fix pointer signedness.
6ae141d6
PE
13195 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13196 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13197
33383987 131982011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13199
d32df629
PE
13200 Improve quality of tests for time stamp overflow.
13201 For example, without this patch (encode-time 0 0 0 1 1
13202 1152921504606846976) returns the obviously-bogus value (-948597
13203 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13204 reports time overflow. See
13205 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13206 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13207 * editfns.c: Include limits.h and intprops.h.
13208 (TIME_T_MIN, TIME_T_MAX): New macros.
13209 (time_overflow): Move earlier, to before first use.
13210 (hi_time, lo_time): New functions, for an accurate test for
13211 out-of-range times.
13212 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13213 (Fget_internal_run_time): Don't assume time_t fits in int.
13214 (make_time): Use list2 instead of Fcons twice.
13215 (Fdecode_time): More accurate test for out-of-range times.
13216 (check_tm_member): New function.
13217 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13218 (lisp_time_argument): Don't rely on undefined left-shift and
13219 right-shift behavior when checking for time stamp overflow.
8be6f318 13220
fe31d94c
PE
13221 * editfns.c (time_overflow): New function, refactoring common code.
13222 (Fformat_time_string, Fdecode_time, Fencode_time):
13223 (Fcurrent_time_string): Use it.
13224
8be6f318
PE
13225 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13226 * dired.c (make_time): Move to ...
13227 * editfns.c (make_time): ... here.
13228 * systime.h: Note the move.
13229
09d9db2c 132302011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13231
126bc0dc
YM
13232 * fringe.c (update_window_fringes): Remove unused variables.
13233
c47cbdfd
YM
13234 * unexmacosx.c (copy_data_segment): Also copy __got section.
13235 (Bug#8223)
13236
7ac80be9
EZ
132372011-03-12 Eli Zaretskii <eliz@gnu.org>
13238
c96bbc66 13239 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13240 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13241 Constify `char *' arguments and their references according to
13242 prototypes in tparam.h.
13243
ecb0f94d 13244 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13245
7ac80be9
EZ
13246 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13247 Adapt all references accordingly.
13248
13249 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13250
ef1fd07e
TT
132512011-03-11 Tom Tromey <tromey@redhat.com>
13252
13253 * buffer.c (syms_of_buffer): Remove obsolete comment.
13254
7ef4b50c
EZ
132552011-03-11 Eli Zaretskii <eliz@gnu.org>
13256
13257 * termhooks.h (encode_terminal_code): Declare prototype.
13258
13259 * msdos.c (encode_terminal_code): Don't declare prototype.
13260
13261 * term.c (encode_terminal_code): Now external again, used by
13262 w32console.c and msdos.c.
13263
44f230aa
SM
13264 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13265 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13266
4b1ec863 132672011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13268
1714f52b 13269 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13270
4b1ec863
PE
13271 * fringe.c (update_window_fringes): Mark locals as initialized
13272 (Bug#8227).
13273 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13274
524c7aa6
PE
13275 * alloc.c (mark_fringe_data): Move decl from here ...
13276 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13277 to check its interface.
13278 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13279
a5c0af81 13280 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13281 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13282 (fontset_font): Mark local as initialized.
a9a06e0b 13283 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13284
b4716021
PE
13285 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13286
811e9bac 13287 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13288 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13289 (x_own_selection, Fx_disown_selection_internal): Rename locals
13290 to avoid shadowing.
13291 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13292
7e3ab302
PE
13293 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13294 so that the caller can use some name other than gcpro1.
13295 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13296 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13297 (Fx_backspace_delete_keys_p):
13298 Use them to avoid shadowing, and rename vars to avoid shadowing.
13299 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13300 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13301 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13302 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13303 Remove unused locals.
7e3ab302
PE
13304 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13305 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13306 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13307 macros.
f78faa98 13308
e2b13473
PE
13309 * xterm.h (x_mouse_leave): New decl.
13310
77f23912
PE
13311 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13312 Remove unused functions.
cdf4ba58
PE
13313 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13314 (x_calc_absolute_position): Now static.
7411c686 13315 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13316 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13317 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13318 unless they are used.
38d0b34a
PE
13319 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13320 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13321 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13322 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13323 (x_error_catcher, x_connection_closed, x_error_handler):
13324 (x_error_quitter, xembed_send_message, x_iconify_frame):
13325 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13326 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13327 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13328
44f230aa
SM
13329 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13330 Rename or move locals to avoid shadowing.
6b463e58 13331 (tty_defined_color, merge_face_heights): Now static.
5967d051 13332 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13333 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13334 does not deduce is never used uninitialized.
73719eba
PE
13335 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13336 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13337
426994c3 13338 * terminal.c (store_terminal_param): Now static.
5489860b 13339
032f1620 13340 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13341 (set_frame_menubar): Remove unused local.
d4323972 13342 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13343 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13344 since they might point to immutable storage.
281585b0
PE
13345 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13346 since it's unused otherwise.
032f1620 13347
367c19e5 13348 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13349 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13350 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13351 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13352 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13353 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13354 does not deduce are never used uninitialized.
70739cbe 13355
07b48fa9
PE
13356 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13357
8868a238 13358 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13359 * window.c (window_loop, size_window):
13360 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13361
7e5cf297 13362 * window.c (display_buffer): Now static.
d6550a9f
PE
13363 (size_window): Mark variables that gcc -Wuninitialized
13364 does not deduce are never used uninitialized.
a586633d
PE
13365 * window.h (check_all_windows): New decl, to forestall
13366 gcc -Wmissing-prototypes diagnostic.
5b555da1 13367 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13368
f6095868
PE
13369 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13370 shadowing.
13371 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13372 Include <limits.h>.
13373 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13374 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13375 (load_charset_map): Mark variables that gcc -Wuninitialized
13376 does not deduce are never used uninitialized.
53df7c11 13377 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13378
f38b440c
PE
13379 * coding.c (coding_set_source, coding_set_destination):
13380 Use "else { /* comment */ }" rather than "else /* comment */;"
13381 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13382 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13383 a block, when the outer 'i' will do.
13384 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13385 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13386 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13387 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13388 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13389 Rename locals to avoid shadowing.
13390 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13391 * coding.c (emacs_mule_char, encode_invocation_designation):
13392 Now static, since they're not used elsewhere.
413bb2db 13393 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13394 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13395 (decode_coding_emacs_mule): Mark variables that gcc
13396 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13397 (detect_coding_iso_2022): Initialize a local variable that might
13398 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13399 this initialization is needed. (Bug#8211)
5f58e762
PE
13400 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13401 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13402 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13403 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13404 Remove unused macros.
f38b440c 13405
232b38b9 13406 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13407 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13408 * character.c (string_count_byte8): Likewise.
232b38b9 13409
fb90da1b
PE
13410 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13411 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13412
fb93dbc2
PE
13413 * chartab.c (copy_sub_char_table): Now static, since it's not used
13414 elsewhere.
5c156ace
PE
13415 (sub_char_table_ref_and_range, char_table_ref_and_range):
13416 Rename locals to avoid shadowing.
bbcd0949 13417 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13418
7d3b3862 13419 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13420 (BIDI_BOB): Remove unused macro.
7d3b3862 13421
6be7d3da
PE
13422 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13423 deduce are never used uninitialized.
c2ed9c8b 13424 * term.c (encode_terminal_code): Likewise.
6be7d3da 13425
75f8807f 13426 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13427
50938595
PE
13428 * tparam.h: New file.
13429 * term.c, tparam.h: Include it.
13430 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13431 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13432 Move these decls to tparam.h, and make them agree with what
13433 is actually in tparam.c. The previous trick of using incompatible
13434 decls in different modules does not conform to the C standard.
13435 All callers of tparam changed to use tparam's actual API.
13436 * tparam.c (tparam1, tparam, tgoto):
13437 Use const pointers where appropriate.
13438
fbceeba2
PE
13439 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13440 * cm.h (struct cm): Likewise.
13441 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13442 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13443 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13444 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13445 (turn_on_face, init_tty): Likewise.
13446 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13447
7f3f1250
PE
13448 * term.c (term_mouse_position): Rename local to avoid shadowing.
13449
e6ca6543
PE
13450 * alloc.c (mark_ttys): Move decl from here ...
13451 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13452
c40f8d15
AS
134532011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13454
13455 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13456
cfe0661d
JB
134572011-03-09 Juanma Barranquero <lekktu@gmail.com>
13458
13459 * search.c (compile_pattern_1): Remove argument regp, unused since
13460 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13461 (compile_pattern): Don't pass it.
13462
0afb4571
J
134632011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13464
13465 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13466 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13467 for ! HAVE_GTK3.
13468 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13469
13470 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13471
13472 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13473 gdk_window_get_screen, gdk_window_get_geometry,
13474 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13475 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13476 (xg_get_pixbuf_from_pixmap): New function.
13477 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13478 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13479 Call xg_get_pixbuf_from_pixmap instead of
13480 gdk_pixbuf_get_from_drawable.
13481 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13482 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13483 (xg_check_special_colors): Use GtkStyleContext and its functions
13484 for HAVE_GTK3.
13485 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13486 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13487 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13488 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13489 Call gtk_widget_get_preferred_size.
0afb4571
J
13490 (xg_frame_resized): gdk_window_get_geometry only takes 5
13491 parameters.
44f230aa
SM
13492 (xg_win_to_widget, xg_event_is_for_menubar):
13493 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13494 (xg_set_widget_bg): New function.
13495 (delete_cb): New function.
895009e1 13496 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13497 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13498 (xg_set_background_color): Call xg_set_widget_bg.
13499 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13500 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13501 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13502 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13503 if ! HAVE_GTK3.
13504 (update_frame_tool_bar): Call gtk_widget_hide.
13505 (xg_initialize): Use GDK_KEY_g.
13506
13507 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13508 if ! HAVE_GTK3
13509 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13510
13511 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13512 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13513 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13514
1c2cc4ef
JB
135152011-03-08 Juanma Barranquero <lekktu@gmail.com>
13516
13517 * w32xfns.c (select_palette): Check success of RealizePalette against
13518 GDI_ERROR, not zero.
13519
33383987 13520See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13521
13522;; Local Variables:
13523;; coding: utf-8
aac0c6e3
MR
13524;; End:
13525
2f097256 13526 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13527
13528 This file is part of GNU Emacs.
13529
13530 GNU Emacs is free software: you can redistribute it and/or modify
13531 it under the terms of the GNU General Public License as published by
13532 the Free Software Foundation, either version 3 of the License, or
13533 (at your option) any later version.
13534
13535 GNU Emacs is distributed in the hope that it will be useful,
13536 but WITHOUT ANY WARRANTY; without even the implied warranty of
13537 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13538 GNU General Public License for more details.
13539
13540 You should have received a copy of the GNU General Public License
13541 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.