* gtkutil.c (xg_make_tool_item): Add callbacks of one of wimage or
[bpt/emacs.git] / src / ChangeLog
CommitLineData
fe0b6370
JD
12011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2
3 * gtkutil.c (xg_make_tool_item): Add callbacks of one of wimage or
4 label is not null (Bug#9951).
5 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6 may be NULL.
7
89bd5ee1
EZ
82011-11-04 Eli Zaretskii <eliz@gnu.org>
9
10 * window.c (Fwindow_body_size): Mention in the doc string that the
11 return value is in frame's canonical units. (Bug#9949)
12
84c3edb9
EZ
132011-11-03 Eli Zaretskii <eliz@gnu.org>
14
4e2fb5c7
EZ
15 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
16
84c3edb9 17 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 18 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 19 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 20
bc17a887
EZ
212011-11-01 Eli Zaretskii <eliz@gnu.org>
22
23 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
24 Don't stop backward scan on the continuation glyph, even though
25 its CHARPOS is positive.
26b46e51
EZ
26 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
27 cover_string to disp_string.
bc17a887 28
4ee88440
MR
292011-11-01 Martin Rudalics <rudalics@gmx.at>
30
31 * window.c (temp_output_buffer_show): Don't use
32 Vtemp_buffer_show_specifiers.
33 (Vtemp_buffer_show_specifiers): Remove unused variable.
34
c2ff3c02
EZ
352011-10-30 Eli Zaretskii <eliz@gnu.org>
36
37 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
38 past the beginning of the current glyph matrix.
39
6e56383b
JD
402011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
41
42 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
43 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
44 HAVE_GTK3 (Bug#9869).
b77a6a7f 45
3b574623
JD
46 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
47 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
48
b77a6a7f
JD
49 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
50
51 * xterm.c: Declare x_handle_net_wm_state to return int.
52 (handle_one_xevent): Check if we are iconified but don't have
53 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
54 (get_current_wm_state): Return non-zero if not hidden,
55 check for _NET_WM_STATE_HIDDEN (Bug#9893).
56 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
57 (x_handle_net_wm_state): Return what get_current_wm_state returns.
58 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
59
196e41e4
PE
602011-10-29 Paul Eggert <eggert@cs.ucla.edu>
61
62 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
63 so that this new function doesn't get optimized away by a
64 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
65
021f2e1a
AS
662011-10-29 Andreas Schwab <schwab@linux-m68k.org>
67
68 * frame.h (MOUSE_HL_INFO): Remove excess parens.
69
8b058d44
EZ
702011-10-29 Eli Zaretskii <eliz@gnu.org>
71
72 Fix the `xbytecode' command.
73 * .gdbinit (xprintbytestr): New command.
74 (xwhichsymbols): Renamed from `which'; all callers changed.
75 (xbytecode): Print the byte-code string as well.
76
4452fb80
EZ
772011-10-29 Kim Storm <storm@cua.dk>
78
8b058d44
EZ
79 * alloc.c (which_symbols): New function.
80
21b72067
AS
812011-10-29 Andreas Schwab <schwab@linux-m68k.org>
82
83 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
84 line. (Bug#9903)
85
83ed7b5c
GM
862011-10-29 Glenn Morris <rgm@gnu.org>
87
88 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
89 Not clear what it was for, and it causes various bugs. (Bug#9839)
90
5a7a728b
EZ
912011-10-28 Eli Zaretskii <eliz@gnu.org>
92
93 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
94 possible random value that matches one of those tested as
95 condition to clear the mouse face.
96
d3d0842f
CY
972011-10-28 Chong Yidong <cyd@gnu.org>
98
99 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
100
31b39d13
DN
1012011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
102
103 * window.c (make_window): Initialize phys_cursor_on_p.
104
9aba6043
SM
1052011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
106
107 * lisp.h (struct Lisp_Symbol): Update comments.
108
c20992f4
JB
1092011-10-28 Juanma Barranquero <lekktu@gmail.com>
110
111 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
112
db4f02f2
EZ
1132011-10-28 Eli Zaretskii <eliz@gnu.org>
114
115 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
116 <oslsachem@gmail.com> for helping to debug this.
117
118 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
119 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
120 (g_b_init_get_glyph_outline_w): New static variables.
121 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
122 (GetGlyphOutlineW_Proc): New typedefs.
123 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
124 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
125 New functions.
126 (w32font_open_internal, compute_metrics):
127 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
128 instead of calling the "wide" APIs directly.
129
130 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
131
132 * w32.h (syms_of_w32font): Add prototype.
133
87e68db4
JB
1342011-10-27 Juanma Barranquero <lekktu@gmail.com>
135
136 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
137 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
138 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
139 (Fmove_to_window_line): Doc fix.
140
435c1d67
CY
1412011-10-27 Chong Yidong <cyd@gnu.org>
142
143 * process.c (make_process): Set gnutls_state to NULL.
144
145 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
146 non-NULL, regardless of GNUTLS_INITSTAGE.
147 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
148 an error. Set process slots as soon as we allocate them.
149
150 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
151
9c6c6f49
CY
1522011-10-27 Chong Yidong <cyd@gnu.org>
153
9aba6043
SM
154 * gnutls.c (emacs_gnutls_deinit): New function.
155 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
156 (Fgnutls_deinit, Fgnutls_boot): Use it.
157
158 * process.c (make_process): Initialize GnuTLS credentials to NULL.
159 (deactivate_process): Call emacs_gnutls_deinit.
160
657d08d3
JB
1612011-10-27 Juanma Barranquero <lekktu@gmail.com>
162
163 * image.c (x_create_x_image_and_pixmap):
164 * w32.c (sys_rename, w32_delayed_load):
165 * w32font.c (fill_in_logfont):
166 * w32reg.c (x_get_string_resource): Silence compiler warnings.
167
5430d399
JB
1682011-10-26 Juanma Barranquero <lekktu@gmail.com>
169
170 * w32fns.c (w32_default_color_map): New function,
171 extracted from Fw32_default_color_map.
a7ef684b 172 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 173
fe0055fa
PE
1742011-10-25 Paul Eggert <eggert@cs.ucla.edu>
175
176 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
177
e6346438
SM
1782011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
179
180 * keyboard.c (test_undefined): New function (bug#9751).
181 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
182
e112cc37
ET
1832011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
184
185 * sysdep.c (init_sys_modes): Fix the check for the controlling
186 terminal (Bug#6649).
187
7b5d6677
EZ
1882011-10-20 Eli Zaretskii <eliz@gnu.org>
189
190 * dispextern.h (struct bidi_it): New member next_en_type.
191
192 * bidi.c (bidi_line_init): Initialize the next_en_type member.
193 (bidi_resolve_explicit_1): When next_en_pos is valid for the
194 current character, check also for next_en_type being WEAK_EN.
195 (bidi_resolve_weak): Don't enter the expensive loop if the current
196 position is before next_en_pos. Record the bidi type of the first
197 non-ET, non-BN character we find, in addition to its position.
198 (bidi_level_of_next_char): Invalidate next_en_type when
199 next_en_pos is over-stepped.
200
7da0b018
PE
2012011-10-20 Paul Eggert <eggert@cs.ucla.edu>
202
203 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
204 * editfns.c: Rewrite current-time-zone so that it invokes
205 the equivalent of (format-time-string "%Z") to get the time zone name.
206 This fixes a bug when the time zone name contains characters that
207 need converting from the system time locale to Emacs internal format.
208 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
209 that patch fixed format-time-string to do the conversion, but
210 I forgot to fix current-time-zone.
211 (format_time_string): New function, containing most of
212 what Fformat_time_string used to contain.
213 (Fformat_time_string): Rewrite in terms of format_time_string.
214 This doesn't change this function's behavior.
215 (current-time-zone): Rewrite to use format_time_string.
216 This fixes the bug reported by Michael Schierl in
217 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
218 Jason Rumney's 2007-06-07 change worked around this bug, but
219 didn't fix it.
220 * systime.h (tzname, timezone): Remove no-longer-used declarations.
221
8547b010
EZ
2222011-10-19 Eli Zaretskii <eliz@gnu.org>
223
224 * xdisp.c (start_display): If the character at POS is displayed
225 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
226 (try_window_reusing_current_matrix): If a line ends in a display
227 vector or the next line starts in a display vector, continue
228 redrawing the window even though the character position of
229 start_row was reached.
8547b010
EZ
230 (Bug#9771, part 2)
231
4e948d15
CY
2322011-10-18 Chong Yidong <cyd@gnu.org>
233
234 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
235 with nobreak-char-display too.
236
4787455f
EZ
2372011-10-18 Eli Zaretskii <eliz@gnu.org>
238
239 Fix part 3 of bug#9771.
240 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
241 (bidi_resolve_neutral): Don't enter the expensive loop looking for
242 non-neutral characters if the current character is a paragraph
243 separator (a.k.a. Newline). This avoids running the same
244 expensive loop twice, once when we consume the preceding newline
245 and the other time when the line actually needs to be displayed.
246 Avoid the loop when we see neutrals on the base embedding level
247 following a character whose directionality is the same as the
248 paragraph's. This avoids running the expensive loop when a line
249 ends in a long sequence of neutrals, like control characters.
250 Add assertion against STRONG_AL type. Slightly rearrange code
251 that determines the type of a neutral given the first non-neutral
252 that follows it.
253 (bidi_level_of_next_char): Set next_en_pos to zero when
254 invalidating its info.
255
2c91f553
EZ
2562011-10-17 Eli Zaretskii <eliz@gnu.org>
257
258 * xdisp.c (push_display_prop): Determine whether to record string
259 or buffer position by IT->string, not by IT->method. Allow
260 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
261 (move_it_vertically_backward): Don't look for character position
262 immediately after the newline when in a continuation line.
263 (Bug#9771, part 1)
2c91f553 264
c7b08b0d
MR
2652011-10-15 Martin Rudalics <rudalics@gmx.at>
266
267 * window.c (coordinates_in_window): Rewrite and delabelize
268 vertical border check. (Bug#5357) (Bug#9618)
269
6b02f655
SM
2702011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
271
272 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
273 errors in XSetWindowBorder (bug#9310).
274
81d40c92
DA
2752011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
276
277 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
278 avoid crash when xmalloc overrun checking is enabled.
279
d4172c3b
EZ
2802011-10-13 Eli Zaretskii <eliz@gnu.org>
281
282 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
283 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
284 cursor motion with <left> and <right> arrow keys.
285
286 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
287 some callers set that themselves.
288
b00eea75
EZ
2892011-10-12 Eli Zaretskii <eliz@gnu.org>
290
291 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
292 display string and the previous row comes from the same string and
293 is empty. (Bug#9739) (Bug#9738)
294
8fe012c4
SM
2952011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
296
297 * doc.c (get_doc_string): Encode file name (bug#9735).
298
0074aef2
EZ
2992011-10-12 Eli Zaretskii <eliz@gnu.org>
300
79beb178
EZ
301 * bidi.c (bidi_level_of_next_char):
302 * xdisp.c (get_visually_first_element): Remove old incorrect
303 comments regarding the Unicode Line Separator character.
304
0074aef2
EZ
305 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
306
6e4b3fbe
DA
3072011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
308
309 * alloc.c (Fgc_status): Do not access beyond zombies array
310 boundary if nzombies > MAX_ZOMBIES.
311 * alloc.c (dump_zombies): Add missing format specifier.
312
0324f3af
PE
3132011-10-12 Paul Eggert <eggert@cs.ucla.edu>
314
b5525cac
PE
315 * xdisp.c (set_cursor_from_row): Simplify conditionals,
316 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
317
0324f3af
PE
318 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
319 Some packages use them to denote characters with modifiers.
320
e9b5f888
AS
3212011-10-11 Andreas Schwab <schwab@linux-m68k.org>
322
323 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
324 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
325 matching a pp-number. Rename parameter var to var1.
326
127827c0
SM
3272011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
328
329 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
330
c8fd3bd0
GM
3312011-10-08 Glenn Morris <rgm@gnu.org>
332
333 * callint.c (Fcall_interactively): Give a more explicit error for the
334 'c' case with a non-character input. (Bug#8479)
335
352ec8ff
EZ
3362011-10-08 Eli Zaretskii <eliz@gnu.org>
337
03669ccb
EZ
338 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
339 lines.
7061c986
EZ
340 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
341 lines that are hscrolled on the left.
03669ccb 342
352ec8ff
EZ
343 * dispnew.c (buffer_posn_from_coords): Account for a possible
344 presence of header-line. (Bug#4426)
345
a66cfb1c
SM
3462011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
347
6b02f655
SM
348 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
349 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 350
7c5ee88e
PE
3512011-10-07 Paul Eggert <eggert@cs.ucla.edu>
352
353 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
354 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
355 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
356 this makes Emacs dump core during garbage collection on rare
357 occasions. sizeof is obviously inferior to offsetof here, so
358 stick with offsetof.
359 (GC_POINTER_ALIGNMENT): New macro.
360 (mark_memory): Omit 3rd (offset) arg; caller changed.
361 Don't assume EMACS_INT alignment is the same as pointer alignment.
362
df1bbe5b
SM
3632011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
364
365 * keyboard.c (read_key_sequence_remapped): New var.
366 (read_key_sequence): Compute remapping in the right buffer.
367 (command_loop_1): Use read_key_sequence's remapping directly.
368
51553db6
SM
3692011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
370
32c1fffd
SM
371 * dired.c (file_name_completion): Don't expand file name.
372 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
373 before checking file name handler.
374
51553db6
SM
375 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
376 they've been requested explicitly (bug#9591).
377
b6bd1599 3782011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
379
380 * keymap.c (Fsingle_key_description): Use make_specified_string
381 instead of build_string to build string from push_key_description.
382 (Bug#5193)
383
f701dc2a
PE
3842011-09-30 Paul Eggert <eggert@cs.ucla.edu>
385
4222c55d
PE
386 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
387 This fixes a Y2038 bug on 64-bit hosts.
388 * buffer.c (reset_buffer):
389 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
390 (Fclear_buffer_auto_save_failure):
391 Use 0, not -1, to represent an unset failure time, since time_t
392 might not be signed.
393
f701dc2a
PE
394 Remove dependency on glibc malloc internals.
395 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
396 Move back here from lisp.h, but with their new implementations.
397 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
398 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
399 * charset.c (charset_table_init): New static var.
400 (syms_of_charset): Use it instead of xmalloc. This removes a
401 dependency on glibc malloc internals. See Eli Zaretskii's comment in
402 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
403 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
404 Move back to alloc.c.
405 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
406 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
407
9ceebf39
JD
4082011-09-30 Jan Djärv <jan.h.d@swipnet.se>
409
410 * nsterm.m (windowDidResize): Call x_set_window_size only when
411 ns_in_resize is true. Otherwise set pixelwidth/height and
412 call change_frame_size (Bug#9628).
413
cb993c58
PE
4142011-09-30 Paul Eggert <eggert@cs.ucla.edu>
415
3930c88b
PE
416 Port --enable-checking=all to Fedora 14 x86-64.
417 * charset.c (syms_of_charset): Also account for glibc malloc's
418 internal overhead when calculating the initial malloc maximum.
419
cb993c58
PE
420 Port --enable-checking=all to Fedora 14 x86.
421 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
422 Move to lisp.h.
423 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
424 (overrun_check_realloc, overrun_check_free):
425 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
426 That way, xmalloc returns a properly-aligned pointer even if
427 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
428 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
429 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
430 into account when calculating the initial malloc maximum.
431 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
432 Move here from alloc.c, so that charset.c can use it too.
433 Properly align; the old code wasn't right for common 32-bit hosts
434 when configured with --enable-checking=all.
435 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
436 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
437
31bed486
EZ
4382011-09-29 Eli Zaretskii <eliz@gnu.org>
439
04c70788 440 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
441 use EDOM.
442
fbcaa2f3
EZ
4432011-09-28 Eli Zaretskii <eliz@gnu.org>
444
445 * xdisp.c (compute_display_string_end): If there's no display
446 string at CHARPOS, return -1.
447
448 * bidi.c (bidi_fetch_char): When compute_display_string_end
449 returns a negative value, treat the character as a normal
450 character not covered by a display string. (Bug#9624)
451
a239d4e9
JB
4522011-09-28 Juanma Barranquero <lekktu@gmail.com>
453
454 * lread.c (Fread_from_string): Fix typo in docstring.
455
88652fd5
EZ
4562011-09-27 Eli Zaretskii <eliz@gnu.org>
457
458 * xdisp.c (handle_invisible_prop): If invisible text ends on a
459 newline, reseat the iterator instead of bidi-iterating there one
460 character at a time. (Bug#9610)
32c1fffd
SM
461 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
462 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 463
ed497dd4
AS
4642011-09-27 Andreas Schwab <schwab@linux-m68k.org>
465
466 * lread.c (readevalloop): Use correct code for NBSP.
467 (read1): Likewise. (Bug#9608)
468
b2bf61aa
MA
4692011-09-25 Michael Albinus <michael.albinus@gmx.de>
470
471 * dbusbind.c (Fdbus_register_signal): When service is not
472 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
473
32bbb17c
GM
4742011-09-25 Glenn Morris <rgm@gnu.org>
475
476 * buffer.c (truncate-lines): Doc fix.
477
94e0933e
CY
4782011-09-24 Chong Yidong <cyd@stupidchicken.com>
479
480 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
481 (Fset_window_next_buffers): Doc fix.
482
cddde921
GM
4832011-09-24 Glenn Morris <rgm@gnu.org>
484
485 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
486
1260aef1
PE
4872011-09-24 Paul Eggert <eggert@cs.ucla.edu>
488
25b4bfa0
PE
489 Fix minor problems found by static checking.
490 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
491 * indent.c (Fvertical_motion): Fix == vs = typo.
492
e3cbd34b
EZ
4932011-09-24 Eli Zaretskii <eliz@gnu.org>
494
a66cfb1c
SM
495 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
496 Default value is now t. Doc fix.
6bf7006f 497
e3cbd34b 498 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 499 logic when moving up, not only when moving down. Fix the
e3cbd34b 500 confusing name and values of the it_overshoot_expected variable;
32c1fffd 501 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
502
503 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
504 CHARPOS is covered by a display string which includes newlines.
505 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
506 is covered by a display string with embedded newlines.
507
a3de0cbd
MA
5082011-09-24 Michael Albinus <michael.albinus@gmx.de>
509
510 * dbusbind.c (Fdbus_register_signal): Add match rule to
511 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
512 (Fdbus_register_method, Vdbus_registered_objects_table):
513 Fix docstring.
a3de0cbd 514
b260039d
JM
5152011-09-24 Jim Meyering <meyering@redhat.com>
516
32c1fffd 517 do not ignore write error for any output size
b260039d
JM
518 The previous change was incomplete.
519 While it makes emacs --batch detect the vast majority of stdout
520 write failures, errors were still ignored whenever the output size is
521 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
522 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
523 && echo FAIL: ignored write error
524 FAIL: ignored write error
525 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
526 && echo FAIL: ignored write error
527 FAIL: ignored write error
528 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
529
8eca8a7c
AS
5302011-09-23 Andreas Schwab <schwab@linux-m68k.org>
531
532 * emacs.c (Fkill_emacs): In noninteractive mode exit
533 non-successfully if a write error occurred on stdout. (Bug#9574)
534
3341db62
EZ
5352011-09-21 Eli Zaretskii <eliz@gnu.org>
536
537 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
538 the xassert test.
539
540 * dispextern.h (struct it): Update the comment documenting what
541 can it->OBJECT be.
542
8c203dbf
EZ
5432011-09-20 Eli Zaretskii <eliz@gnu.org>
544
545 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
546 a display string, extend search for cursor position to end of row.
547 (find_row_edges): If the row ends in a newline from a display
548 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
549 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
550 (Fcurrent_bidi_paragraph_direction): Fix search for previous
551 non-empty line. Fixes confusing cursor motion with arrow keys at
552 the beginning of a line that starts with whitespace.
8c203dbf 553
a4824228
LMI
5542011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
555
556 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
557 (bug#9493).
558
33ed493b
CY
5592011-09-18 Chong Yidong <cyd@stupidchicken.com>
560
561 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
562 boolean (Bug#9154).
563
56cd55c8
EZ
5642011-09-18 Eli Zaretskii <eliz@gnu.org>
565
566 * xdisp.c (display_line): Record maximum and minimum buffer
567 positions even if no glyphs were produced (e.g., by a zero-width
568 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
569 buffer positions that will be removed from the glyph row because
570 they don't fit.
c02dcedf
EZ
571 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
572 column is beyond frame width: don't subtract 1 "pixel" when
573 computing width of the stretch.
3e62b7e0
EZ
574 (reseat_at_next_visible_line_start): Undo the change made on
575 2011-09-17 that saved paragraph information and restored it after
576 the call to `reseat'. (Bug#9545)
56cd55c8 577
5ed99d36 5782011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
579
580 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
581 and turn window cursor on if cleared (Bug#9415).
582
5ed99d36 5832011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
584
585 * search.c (boyer_moore): Take unibyte characters from pattern
586 literally. (Bug#9458)
587
9bade7b2
EZ
5882011-09-18 Eli Zaretskii <eliz@gnu.org>
589
590 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
591
e5e9d610
PE
5922011-09-18 Paul Eggert <eggert@cs.ucla.edu>
593
87e4427a
PE
594 Fix minor problem found by static checking.
595 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
596 initialized, to pacify gcc -Wuninitialized.
597
e5e9d610
PE
598 * fileio.c: Report proper errno when syscall falls.
599 (Finsert_file_contents): Save and restore errno,
600 so that report_file_error outputs the correct diagnostic.
601 (Fwrite_region) [CLASH_DETECTION]: Likewise.
602
a1674f0b
EZ
6032011-09-18 Eli Zaretskii <eliz@gnu.org>
604
605 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
606
fbfb6dd4
EZ
6072011-09-17 Eli Zaretskii <eliz@gnu.org>
608
609 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
610 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
611
bb187662
EZ
6122011-09-17 Eli Zaretskii <eliz@gnu.org>
613
1137e8b8 614 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 615 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
616
617 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
618 (bidi_find_paragraph_start): Search back for paragraph beginning
619 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
620 (bidi_move_to_visually_next): Only trigger paragraph-related
621 computations when the last character is a newline or at EOB, not
622 just any NEUTRAL_B. (Bug#9470)
623
bb187662
EZ
624 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
625 truncated lines if point is covered by a display string. (Bug#9524)
626
2e621251
PE
6272011-09-16 Paul Eggert <eggert@cs.ucla.edu>
628
629 * xselect.c: Relax test for outgoing X longs (Bug#9498).
630 (cons_to_x_long): New function.
631 (lisp_data_to_selection_data): Use it. Correct the test for
632 short-versus-long data; it was negated. Break out of vector
633 loop, for efficiency, when a long datum is discovered.
634
91a15bc6
SM
6352011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
636
637 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
638
b41c3a35
EZ
6392011-09-16 Eli Zaretskii <eliz@gnu.org>
640
641 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
642 GCC PR/17406) by declaring this function with external scope.
643
7812ba2d
PE
6442011-09-15 Paul Eggert <eggert@cs.ucla.edu>
645
646 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
647 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
648
cf7edc2a
AS
6492011-09-15 Andreas Schwab <schwab@linux-m68k.org>
650
651 * editfns.c (Fformat): Correctly handle text properties on "%%".
652
bd01620e
EZ
6532011-09-15 Eli Zaretskii <eliz@gnu.org>
654
655 * xterm.c (x_draw_composite_glyph_string_foreground):
656 * w32term.c (x_draw_composite_glyph_string_foreground):
657 * term.c (encode_terminal_code):
658 * composite.c (composition_update_it, get_composition_id):
659 * xdisp.c (get_next_display_element)
660 (fill_composite_glyph_string): Add comments about special meaning
661 of TAB characters in a composition.
662
a02719a3
PE
6632011-09-15 Paul Eggert <eggert@cs.ucla.edu>
664
665 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
666 This occurs when processing a multibyte format.
667 Problem reported by Wolfgang Jenker.
a02719a3 668
72589a3c
JB
6692011-09-15 Johan Bockgård <bojohan@gnu.org>
670
671 * xdisp.c (try_cursor_movement): Only check for exact match if
672 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
673
1c14176c
PE
6742011-09-14 Paul Eggert <eggert@cs.ucla.edu>
675
676 Remove unused external symbols.
677 * dispextern.h (calc_pixel_width_or_height): Remove decl.
678 * xdisp.c (calc_pixel_width_or_height): Now static.
679 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
680 * indent.c (check_display_width):
681 * w32term.c: Fix comment to match code.
682 * xterm.c, xterm.h (x_catching_errors): Remove.
683
d2eea5b5
PE
6842011-09-14 Paul Eggert <eggert@cs.ucla.edu>
685
686 * xselect.c: Use signed conversions more consistently (Bug#9498).
687 (selection_data_to_lisp_data): Assume incoming selection data are
688 signed integers, not unsigned. This is to be consistent with
689 outgoing selection data, which was modified to use signed integers
690 in as part of the fix to Bug#9196 in response to Jan D.'s comment
691 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
692 expects long, not unsigned long.
693
46888499
EZ
6942011-09-14 Eli Zaretskii <eliz@gnu.org>
695
696 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
697 computation of loop end. Reported by Johan Bockgård
698 <bojohan@gnu.org>.
699
ef8ef9fb
CY
7002011-09-13 Chong Yidong <cyd@stupidchicken.com>
701
702 * frame.c (Fother_visible_frames_p): Function deleted.
703
fa819fed
EZ
7042011-09-12 Eli Zaretskii <eliz@gnu.org>
705
706 * indent.c (compute_motion): Process display vector front to back
707 rather than the other way around. (Bug#2496)
708
2ba8e008
SM
7092011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
710
711 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
712
20f53c69
CY
7132011-09-11 Chong Yidong <cyd@stupidchicken.com>
714
715 * minibuf.c (Fread_from_minibuffer): Doc fix.
716
d562d7a4
EZ
7172011-09-11 Eli Zaretskii <eliz@gnu.org>
718
719 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
720 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
721
1c4d7f3d
LMI
7222011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
723
724 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
725 value for non-existent files.
726
b885bf36
EZ
7272011-09-11 Eli Zaretskii <eliz@gnu.org>
728
729 * fileio.c (Finsert_file_contents): If the file cannot be opened,
730 set its "size" to -1. This will set the modtime_size field of
731 the corresponding buffer to -1, which is what
732 verify-visited-file-modtime expects for files that do not exist.
733 (Bug#9139)
734
6612f0bf
PE
7352011-09-11 Paul Eggert <eggert@cs.ucla.edu>
736
737 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
738 here ...
739 * lisp.h: ... from here. push_key_description is no longer
740 defined in keyboard.c, so its declaration should not be in
741 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
742 logically belongs with push_key_description.
743
dfb3f755
PE
7442011-09-10 Paul Eggert <eggert@cs.ucla.edu>
745
746 * buffer.h: Include <sys/types.h> instead of <time.h>.
747 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
748 Problem reported by Herbert J. Skuhra.
749
3134906c
LMI
7502011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
751
752 * xml.c (parse_region): Make the parsing work for
753 non-comment-starting XML files again (bug#9144).
754
8d903f4e
AS
7552011-09-10 Andreas Schwab <schwab@linux-m68k.org>
756
757 * image.c (gif_load): Fix calculation of bottom and right corner.
758 (Bug#9468)
759
80ad64f4
EZ
7602011-09-10 Eli Zaretskii <eliz@gnu.org>
761
762 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
763 redisplay in small windows.
764
208a048d
EZ
7652011-09-09 Eli Zaretskii <eliz@gnu.org>
766
767 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
768
9b1c252e
MR
7692011-09-08 Martin Rudalics <rudalics@gmx.at>
770
771 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
772 Operate on live windows only.
773
2949f33b
JB
7742011-09-08 Juanma Barranquero <lekktu@gmail.com>
775
776 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
777
e08dcafd
EZ
7782011-09-07 Eli Zaretskii <eliz@gnu.org>
779
780 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
781 only under bidi iteration.
782
115b96bd
JD
7832011-09-07 Jan Djärv <jan.h.d@swipnet.se>
784
785 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
786
c8199d0f
PE
7872011-09-06 Paul Eggert <eggert@cs.ucla.edu>
788
789 isnan: Fix porting problem to Solaris 10 with bundled gcc.
790 Without this fix, the command to link temacs failed due to an
791 undefined symbol __builtin_isnan. This is because
792 /usr/include/iso/math_c99.h #defines isnan(x) to
793 __builtin_isnan(x), but the bundled gcc, which identifies itself
794 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
795 a __builtin_isnan.
796 * floatfns.c (isnan): #undef, and then #define to a clone of
797 what's in data.c.
798 (Fisnan): Always define, since it's always available now.
799 (syms_of_floatfns): Always define isnan at the Lisp level.
800
e39b275c 8012011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
802
803 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
804
b2db44d9 8052011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 806
f4af5137 807 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
808 The previous code assumed that file offsets (off_t values) fit in
809 EMACS_INT variables, which is not true on typical 32-bit hosts.
810 The code messed up by falsely reporting buffer overflow in cases
811 such as (insert-file-contents "big" nil 1 2) into an empty buffer
812 when "big" contains more than 2**29 bytes, even though this
813 inserts just one byte and does not overflow the buffer.
814 (Finsert_file_contents): Store file offsets as off_t
815 values, not as EMACS_INT values. Check for overflow when
816 converting between EMACS_INT and off_t. When checking for
817 buffer overflow or for overlap, take the offsets into account.
818 Don't use EMACS_INT for small values where int suffices.
819 When checking for overlap, fix a typo: ZV was used where
820 ZV_BYTE was intended.
821 (Fwrite_region): Don't assume off_t fits into 'long'.
822 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
823
ecfc0a49
MA
8242011-09-05 Michael Albinus <michael.albinus@gmx.de>
825
826 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
827
6511acf2 8282011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 829
0999621a 830 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
831
832 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 833 (esprintf, exprintf, evxprintf): New functions.
62f19c19 834 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 835 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
836 (modify_event_symbol): Do not assume that the length of
837 name_alist_or_stem is safe to alloca and fits in int.
838 (Fexecute_extended_command): Likewise for function name and binding.
839 (Frecursion_depth): Wrap around reliably on integer overflow.
840 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
841 since some callers pass EMACS_INT values.
842 (Fsingle_key_description): Don't crash if symbol name contains more
843 than MAX_ALLOCA bytes.
844 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
845 (get_minibuffer): Arg is now EMACS_INT, not int.
846 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 847 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
848 * window.h (command_loop_level, minibuf_level): Reflect API changes.
849
2be7d702
PE
850 * dbusbind.c (signature_cat): New function.
851 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
852 Do not overrun buffer; instead, report string overflow.
853
9d1df220
PE
854 * dispnew.c (add_window_display_history): Don't overrun buffer.
855 Truncate instead; this is OK since it's just a log.
856
33ef5c64
PE
857 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
858 even if the time zone offset is outlandishly large.
859 Don't mishandle offset == INT_MIN.
860
66c6fdd5
PE
861 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
862 when creating daemon; the previous buffer-overflow check was incorrect.
863
d749b01b
PE
864 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
865 which has the guts of the old verror function.
866
b5cd1905
PE
867 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
868 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
869
6e1a67fb
PE
870 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
871 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 872 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 873 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
874 length of string rather than counting it via multiple sprintfs;
875 that's simpler and more reliable.
c21721cc
PE
876 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
877 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
878 sprintf, in case result does not fit in int.
879
c57b67fc
PE
880 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
881 (fontset_from_font): Print it.
882
8a401434
PE
883 * frame.c (tty_frame_count): Now printmax_t, not int.
884 (make_terminal_frame, set_term_frame_name): Print it.
885 (x_report_frame_params): In X, window IDs are unsigned long,
886 not signed long, so print them as unsigned.
887 (validate_x_resource_name): Check for implausibly long names,
888 and don't assume name length fits in 'int'.
889 (x_get_resource_string): Don't blindly alloca invocation name;
890 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
891 not fit in int.
892
6e1a67fb
PE
893 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
894 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
895 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
896
0df02bf3
PE
897 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
898 Use esprintf, not sprintf, in case result does not fit in int.
899
48e30793
PE
900 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
901 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
902 it as a large positive number.
903 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
904 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
905
a66ff6d8
PE
906 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
907 in case result does not fit in int.
908
aca216ff
PE
909 * print.c (float_to_string): Detect width overflow more reliably.
910 (print_object): Make sprintf buffer a bit bigger, to avoid potential
911 buffer overrun. Don't assume list length fits in 'int'. Treat
912 print length of 0 as 0, not as infinity; to be consistent with other
913 uses of print length in this function. Don't overflow print length
914 index. Don't assume hash table size fits in 'long', or that
915 vectorlike size fits in 'unsigned long'.
916
31c286f7
PE
917 * process.c (make_process): Use printmax_t, not int, to format
918 process-name gensyms.
919
55e5faa1
PE
920 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
921
80f2e268
PE
922 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
923 to avoid potential buffer overrun.
924
670741ab
PE
925 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
926 if X resource line is longer than 512 bytes.
927
b7163a50
PE
928 * xfns.c (x_window): Make sprintf buffer a bit bigger
929 to avoid potential buffer overrun.
930
ae58ff1f
PE
931 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
932
c43c8a6a
PE
933 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
934
3f8236f4
PE
9352011-09-04 Paul Eggert <eggert@cs.ucla.edu>
936
53e9fe90 937 Integer overflow fixes for scrolling, etc.
6511acf2
PE
938 Without these, Emacs silently mishandles large integers sometimes.
939 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
940 it were "C-u 1 M-x recenter" on a typical 64-bit host.
941
6511acf2
PE
942 * xdisp.c (try_window_id): Check Emacs fixnum range before
943 converting to 'int'.
806add1d 944
6511acf2 945 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
946 Check that an Emacs fixnum is in range before assigning it to 'int'.
947 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
948 values converted from Emacs fixnums.
949 (Frecenter): Don't wrap around a line count if it is out of 'int'
950 range; instead, treat it as an extreme value.
951 (Fset_window_configuration, compare_window_configurations):
952 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
953
6511acf2
PE
954 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
955 that can exceed INT_MAX. Check that EMACS_INT value is in range
956 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
957 (match_limit): Don't assume that a fixnum can fit in 'int'.
958
6511acf2 959 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
960 exceed INT_MAX.
961
6511acf2 962 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
963 (Fvertical_motion): Don't wrap around LINES values that don't fit
964 in 'int'. Instead, treat them as extreme values. This is good
965 enough for windows, which can't have more than INT_MAX lines anyway.
966
fcb901a7
LMI
9672011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
968
0f2f6b6d
LMI
969 * Require libxml/parser.h to avoid compilation warning.
970
fcb901a7
LMI
971 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
972
973 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
974 since this reportedly can destroy thread storage.
975
6e20a0d4
CY
9762011-08-30 Chong Yidong <cyd@stupidchicken.com>
977
978 * syntax.c (find_defun_start): Update all cache variables if
979 exiting early (Bug#9401).
980
148ae00e
EZ
9812011-08-30 Eli Zaretskii <eliz@gnu.org>
982
f6cfbd8f
EZ
983 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
984
148ae00e
EZ
985 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
986 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
987 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
988
989 * term.c (tty_append_glyph): New function.
990 (produce_stretch_glyph): Static function and its prototype deleted.
991
a66cfb1c
SM
992 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
993 Add prototypes.
148ae00e 994
c4a07a4c
PE
9952011-08-29 Paul Eggert <eggert@cs.ucla.edu>
996
997 * image.c (parse_image_spec): Check for nonnegative, not for positive,
998 when checking :margin (Bug#9390).
999 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1000 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1001 so that the name doesn't mislead. All uses changed.
1002
6bc8cd65
JB
10032011-08-28 Johan Bockgård <bojohan@gnu.org>
1004
1005 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1006 set_tty_hooks.
1007
dca4927e
EZ
10082011-08-27 Eli Zaretskii <eliz@gnu.org>
1009
1010 * xdisp.c (move_it_to): Don't bail out early when reaching
1011 position beyond to_charpos, if we are scanning backwards.
1012 (move_it_vertically_backward): When DY == 0, make sure we get to
1013 the first character in the line after the newline.
1014
f2cad773
PE
10152011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1018 (ccl_driver): Do not generate an out-of-range pointer.
1019 (Fccl_execute_on_string): Remove unnecessary check for
1020 integer overflow, noted by Stefan Monnier in
1021 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1022 Remove a FIXME that didn't need fixing.
1023 Simplify the newly-introduced buffer reallocation code.
1024
0cae2cdb
JB
10252011-08-27 Juanma Barranquero <lekktu@gmail.com>
1026
1027 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1028
5fc295a4 10292011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1030
70c60eb2 1031 Integer and memory overflow issues (Bug#9196).
726e0ab1 1032
d31850da
PE
1033 * doc.c (get_doc_string): Rework so that
1034 get_doc_string_buffer_size is the actual buffer size, rather than
1035 being 1 less than the actual buffer size; this makes xpalloc more
1036 convenient.
1037
a69fbedb
PE
1038 * image.c (x_allocate_bitmap_record, cache_image):
1039 * xselect.c (Fx_register_dnd_atom):
1040 Simplify previous changes by using xpalloc.
1041
fe5c5d37
PE
1042 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1043 since either will do and ptrdiff_t is convenient with xpalloc.
1044
0065d054
PE
1045 * charset.c (charset_table_size)
1046 (struct charset_sort_data.priority): Now ptrdiff_t.
1047 (charset_compare): Don't overflow if priorities differ greatly.
1048 (Fsort_charsets): Don't assume list length fits in int.
1049 Check for size-calculation overflow when allocating sort data.
1050 (syms_of_charset): Allocate an initial charset table that is
1051 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1052
1053 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1054
1055 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1056 The actual value is always <= INT_MAX, and leaving it unsigned made
1057 overflow checking harder.
1058
1059 * dispextern.h (struct glyph_matrix.rows_allocated)
1060 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1061 with xpalloc. The values are still always <= INT_MAX.
1062
1063 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1064
1065 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1066 (SAFE_NALLOCA): New macro.
1067
1068 * region-cache.c (struct boundary.pos, find_cache_boundary)
1069 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1070 (set_cache_region, invalidate_region_cache)
1071 (revalidate_region_cache, know_region_cache, region_cache_forward)
1072 (region_cache_backward, pp_cache):
1073 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1074 so that ptrdiff_t * can be passed to xpalloc.
1075 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1076 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1077 (pp_cache): Don't assume cache_len fits in int.
1078 * region-cache.h: Adjust extern decls to match.
1079
1080 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1081 EMACS_INT, since either will do, for xpalloc.
1082
1083 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1084 (xnmalloc, xnrealloc, xpalloc): New functions.
1085
726e0ab1
PE
1086 * bidi.c (bidi_shelve_header_size): New constant.
1087 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1088 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1089
51f30bc5 1090 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1091 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1092 (overlay_strings):
1093 Don't update size of array until after memory allocation succeeds,
1094 because xmalloc/xrealloc may not return.
0065d054
PE
1095 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1096 now that we have proper integer overflow checking.
1097 (record_overlay_string, overlay_strings): Catch overflows when
1098 calculating size of overlay_str_buf.
726e0ab1 1099
0065d054
PE
1100 * callproc.c (Fcall_process): Check for size overflow when
1101 calculating size of args2.
1102 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1103 Normally we prefer signed values, but sticking with ptrdiff_t would
1104 require adding more-complicated checks.
726e0ab1
PE
1105
1106 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1107 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1108 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1109 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1110
1111 * character.c (Fstring): Check for size-calculation overflow.
1112
1113 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1114 unnecessary integer overflow. Check for size overflow.
1115 (encode_coding_object): Don't update size until xmalloc succeeds.
1116
1117 * composite.c (get_composition_id): Check for overflow in glyph
1118 length calculations.
1119
1120 Integer and memory overflow fixes for display code.
1121 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1122 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1123 (scrolling_window): Check for overflow in size calculations.
1124 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1125 Don't assume glyph table len fits in int.
1126 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1127 (row_table_size): Now ptrdiff_t, not int.
1128 (scrolling_window): Avoid overflow in size calculations.
1129 Don't update size until allocation succeeds.
1130 * fns.c (concat): Check for overflow in size calculations.
1131 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1132 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1133 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1134
1135 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1136 (get_doc_string): Check for size calculation overflow.
1137 Don't update size until allocation succeeds.
1138 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1139 EMACS_INT, where ptrdiff_t will do.
1140 (Fsubstitute_command_keys): Check for string overflow.
1141
1142 * editfns.c (set_time_zone_rule): Don't assume environment length
1143 fits in int.
1144 (message_length): Now ptrdiff_t, not int.
1145 (Fmessage_box): Don't update size until allocation succeeds.
1146 Don't assume message length fits in int.
1147 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1148
0065d054
PE
1149 * emacs.c (main): Do not reallocate argv, since there is a null at
1150 the end that can be overwritten, and this way there's no need to
1151 worry about size-calculation overflow.
1152 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1153
1154 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1155 alloc succeeds.
1156 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1157
1158 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1159 (x_set_scroll_bar_width, x_figure_window_size):
1160 Check for integer overflow.
1161 (x_set_alpha): Do not assume XINT fits in int.
1162
1163 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1164 This is for the members text_lines, text_cols, total_lines, total_cols,
1165 where the system imposes an 'int' limit.
1166
1167 * fringe.c (Fdefine_fringe_bitmap):
1168 Don't update size until alloc works.
1169
1170 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1171 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1172
1173 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1174 Check for size-calculation overflow.
1175 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1176 do, as we prefer signed integers.
1177 (id_to_widget.max_size, id_to_widget.used)
1178 (xg_store_widget_in_map, xg_remove_widget_from_map)
1179 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1180 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1181 Use and return ptrdiff_t, not int.
1182 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1183 * gtkutil.h: Change prototypes to match the above.
1184
1185 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1186 are duplicate now that they've been promoted to lisp.h.
1187 (x_allocate_bitmap_record, x_alloc_image_color)
1188 (make_image_cache, cache_image, xpm_load):
1189 Don't update size until alloc is done.
1190 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1191 (x_detect_edges):
3256efce 1192 Check for size calculation overflow.
726e0ab1
PE
1193 (ct_colors_allocated_max): New constant.
1194 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1195 overflow.
3256efce 1196
726e0ab1
PE
1197 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1198 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1199 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1200 Use ptrdiff_t, not int, to count maps.
1201 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1202 calculations. Don't update size until allocation succeeds.
1203 Redo calculations to avoid overflow.
726e0ab1
PE
1204 * keyboard.h: Change prototypes to match the above.
1205
1206 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1207 to count maps.
1208 (current_minor_maps): Check for size calculation overflow.
1209 * keymap.h: Change prototypes to match the above.
1210
1211 * lread.c (read1, init_obarray): Don't update size until alloc done.
1212
1213 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1214 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1215
726e0ab1
PE
1216 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1217 Now ptrdiff_t, not int.
1218 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1219 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1220
1221 * process.c (Fnetwork_interface_list): Check for overflow
1222 in size calculation.
1223
1224 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1225
1226 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1227 overflow. Don't bother calling xmalloc when xrealloc will do.
1228
1229 * search.c (Freplace_match): Check for size calculation overflow.
1230 (Fset_match_data): Don't assume list lengths fit in 'int'.
1231
1232 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1233 for command line length. Do not attempt to address one before the
1234 beginning of an array, as that's not portable.
1235
1236 * term.c (max_frame_lines): Remove; unused.
1237 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1238 not int.
1239 (encode_terminal_code, calculate_costs): Check for size
1240 calculation overflow.
1241 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1242 table lengths and related sizes. Don't update size until alloc
1243 done. Redo calculations to avoid overflow.
1244 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1245
1246 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1247 subtracting pointers.
1248 (gobble_line): Check for overflow more carefully. Don't update size
1249 until alloc done.
1250
1251 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1252 Don't update size until alloc done.
1253 Redo size calculations to avoid overflow.
1254 Check for size calculation overflow.
0065d054 1255 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1256
1257 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1258 Use ptrdiff_t, not int, for sizes.
1259 (store_mode_line_noprop_char): Don't update size until alloc done.
1260
0065d054
PE
1261 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1262 Use ptrdiff_t, not int, for sizes.
1263 (Finternal_make_lisp_face, cache_face):
1264 Check for size calculation overflow.
1265 (cache_face): Treat size calculation overflows as if they were
1266 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1267
1268 * xfns.c (x_encode_text, x_set_name_internal)
1269 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1270 sizes, since they can exceed INT_MAX in size. Check for size
1271 calculation overflow.
1272
0065d054
PE
1273 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1274 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1275 Don't update size until alloc done.
1276
0065d054 1277 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1278 as sprintf is limited to int lengths.
1d526e2f 1279
252c5ee1
PE
1280 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1281 (X_LONG_MIN): New macros.
864d7ce7
PE
1282 Use them to make the following changes clearer.
1283 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1284 This change doesn't affect the value now, but it may help remind
1285 future maintainers not to raise the value too much later.
1286 (SELECTION_QUANTUM): Remove, replacing with ...
1287 (selection_quantum): ... new function, which avoids overflow.
1288 All uses changed.
1289 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1290 assumption that selection length fits in 'int'.
1291 (x_reply_selection_request, x_handle_selection_request)
1292 (x_get_window_property, receive_incremental_selection)
1293 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1294 (lisp_data_to_selection_data, clean_local_selection_data):
1295 Use ptrdiff_t, not int, to record length of selection.
1296 (x_reply_selection_request, x_get_window_property)
1297 (receive_incremental_selection, x_property_data_to_lisp):
1298 Redo calculations to avoid overflow.
1299 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1300 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1301 something.
1302 (x_get_window_property, receive_incremental_selection)
1303 (lisp_data_to_selection_data, x_property_data_to_lisp):
1304 Check for size-calculation overflow.
1305 (x_get_window_property, receive_incremental_selection)
1306 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1307 Don't store size until memory allocation succeeds.
1308 (x_get_window_property): Plug memory leak on memory exhaustion.
1309 Don't double-block input; malloc is safe here. Don't assume 2**34
1310 - 4 fits in unsigned long. Add an xassert to check
1311 XGetWindowProperty overflow. Be more careful about overflow
1312 calculations, and distinguish size from memory overflow better.
1313 (receive_incremental_selection): When tracing, don't assume
1314 unsigned int is less than INT_MAX.
1315 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1316 harmful) conversions of unsigned short to int.
1317 (lisp_data_to_selection_data): Don't assume that integers
1318 in the range -65535 through -1 fit in an X unsigned short.
1319 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1320 result parameters unless successful. Rely on cons_to_unsigned
1321 to report problems with elements; the old code wasn't right anyway.
1322 (x_check_property_data): Check for int overflow; we cannot use
1323 a wider type due to X limits.
1324 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1325
726e0ab1 1326 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1327
0065d054
PE
1328 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1329 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1330 (x_color_cells): Don't store size until memory allocation succeeds.
1331 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1332 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1333 (x_term_init): Don't assume length fits in int (sprintf is limited
1334 to int size).
bc18e09d 1335
ebfa62c0
PE
1336 Use ptrdiff_t for composition IDs.
1337 * character.c (lisp_string_width):
1338 * composite.c (composition_table_size, n_compositions)
1339 (get_composition_id, composition_gstring_from_id):
1340 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1341 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1342 * window.c (Frecenter):
1343 Use ptrdiff_t, not int, for composition IDs.
1344 * composite.c (get_composition_id): Check for integer overflow.
1345 * composite.h: Adjust prototypes to match the above changes.
1346
d3411f89
PE
1347 Use ptrdiff_t for hash table indexes.
1348 * category.c (hash_get_category_set):
1349 * ccl.c (ccl_driver):
1350 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1351 * coding.c (coding_system_charset_list, detect_coding_system):
1352 * coding.h (struct coding_system.id):
1353 * composite.c (get_composition_id, gstring_lookup_cache):
1354 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1355 * image.c (xpm_get_color_table_h):
1356 * lisp.h (hash_lookup, hash_put):
1357 * minibuf.c (Ftest_completion):
1358 Use ptrdiff_t for hash table indexes, not int (which is too
1359 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1360 32-bit --with-wide-int hosts).
1361
e097a6fa
PE
1362 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1363 Add a FIXME comment about memory leaks.
1364 (syms_of_charset): Don't assume xmalloc returns.
1365
5637687f
PE
1366 Don't assume that stated character widths fit in int.
1367 * character.c (Fchar_width, c_string_width, lisp_string_width):
1368 * character.h (CHAR_WIDTH):
1369 * indent.c (MULTIBYTE_BYTES_WIDTH):
1370 Use sanitize_char_width to avoid undefined and/or bad behavior
1371 with outlandish widths.
a66cfb1c 1372 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1373 now that we have two such functions. All uses changed.
1374 (sanitize_char_width): New inline function.
1375
a2271ba2
PE
1376 Don't assume that tab-width fits in int.
1377 * character.h (sanitize_width): New inline function.
1378 (SANE_TAB_WIDTH): New macro.
1379 (ASCII_CHAR_WIDTH): Use it.
1380 * indent.c (sane_tab_width): Remove. All uses replaced by
1381 SANE_TAB_WIDTH (current_buffer).
1382 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1383
18c52557
PE
1384 * fileio.c: Integer overflow issues with file modes.
1385 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1386
caeeedc1
PE
1387 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1388 Remove unreachable code.
1389 (read_hex, load_charset_map_from_file): Check for integer overflow.
1390
50849c52
PE
1391 * xterm.c: don't go over XClientMessageEvent limit
1392 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1393 (x_send_scroll_bar_event): Likewise. Check that the size does not
1394 exceed limits imposed by XClientMessageEvent, as well as the usual
1395 ptrdiff_t and size_t limits.
1396
b13995db
PE
1397 * keyboard.c: Overflow, signedness and related fixes.
1398 (make_lispy_movement): Use same integer type in forward decl
1399 that is used in the definition.
1400 (read_key_sequence, keyremap_step):
1401 Change bufsize argument back to int, undoing my 2011-03-30 change.
1402 We prefer signed types, and int is wide enough here.
1403 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1404 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1405 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1406 length, not size_t. Use ptrdiff_t for index, not int.
1407 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1408 possibility of integer overflow.
1409
13464394
PE
1410 Overflow, signedness and related fixes for images.
1411
1412 * dispextern.h (struct it.stack[0].u.image.image_id)
1413 (struct_it.image_id, struct image.id, struct image_cache.size)
1414 (struct image_cache.used, struct image_cache.ref_count):
1415 * gtkutil.c (update_frame_tool_bar):
1416 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1417 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1418 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1419 * nsmenu.m (update_frame_tool_bar):
1420 * xdisp.c (calc_pixel_width_or_height):
1421 * xfns.c (image_cache_refcount):
1422 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1423 on typical 64-bit hosts.
1424
1425 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1426 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1427 Omit unnecessary casts to int.
1428 (parse_image_spec): Check that integers fall into 'int' range
1429 when the callers expect that.
1430 (image_ascent): Redo ascent calculation to avoid int overflow.
1431 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1432 (lookup_image): Remove unnecessary tests.
1433 (xbm_image_p): Locals are now of int, not EMACS_INT,
1434 since parse_image_check makes sure they fit into int.
1435 (png_load, gif_load, svg_load_image):
1436 Prefer int to unsigned where either will do.
1437 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1438 old tiff_error_handler and tiff_warning_handler.
1439 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1440 stack buffer overflows. It uses only the features of vsnprintf
1441 that are common to both POSIX and native Microsoft.
1442 (tiff_error_handler, tiff_warning_handler): Use it.
1443 (tiff_load, gif_load, imagemagick_load_image):
1444 Don't assume :index value fits in 'int'.
1445 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1446 (imagemagick_load_image): Check that crop parameters fit into
1447 the integer types that MagickCropImage accepts. Don't assume
1448 Vimagemagick_render_type has a nonnegative value. Don't assume
1449 size_t fits in 'long'.
1450 (gs_load): Use printmax_t to print the widest integers possible.
1451 Check for integer overflow when computing image height and width.
1452
c11821d4
EZ
14532011-08-26 Eli Zaretskii <eliz@gnu.org>
1454
1455 * xdisp.c (redisplay_window): Don't force window start if point
1456 will be invisible in the resulting window. (Bug#9324)
1457
0c95fcf7
EZ
14582011-08-25 Eli Zaretskii <eliz@gnu.org>
1459
1460 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1461 the display spec is of the form `(space ...)'.
1462 (handle_display_spec): Return the value returned by
1463 handle_single_display_spec, not just 1 or zero.
1464 (handle_single_display_spec): If the display spec is of the form
1465 `(space ...)', and specifies display in the text area, return 2
1466 rather than 1.
fee65a97 1467 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1468 accurately, and prefer exact match for point under bidi.
1469 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1470
1471 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1472 into disp_prop; all users changed.
1473
1474 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1475 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1476 for the text covered by the display property.
1477
e4ed06f1
CY
14782011-08-25 Chong Yidong <cyd@stupidchicken.com>
1479
1480 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1481 Change return value to nil.
1482 (Frecord_buffer): Delete unused function.
1483
f67cdd7f
EZ
14842011-08-24 Eli Zaretskii <eliz@gnu.org>
1485
5980d4c6
EZ
1486 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1487 buffers, return left-to-right.
8610fe8b
EZ
1488 (set_cursor_from_row): Consider candidate row a win if its glyph
1489 represents a newline and point is on that newline. Fixes cursor
1490 positioning on the newline at EOL of R2L text within L2R
1491 paragraph, and vice versa.
1492 (try_cursor_movement): Check continued rows, in addition to
1493 continuation rows. Fixes unwarranted scroll when point enters a
1494 continued line of R2L text within an L2R paragraph, or vice versa.
1495 (cursor_row_p): Consider the case of point being equal to
1496 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1497 from the end of a short line to the beginning of a continued line
1498 of R2L text within L2R paragraph.
1499 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1500 composed characters.
5980d4c6 1501
f67cdd7f
EZ
1502 * bidi.c (bidi_check_type): Use xassert.
1503 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1504 members.
1505
bca633fb
EZ
15062011-08-23 Eli Zaretskii <eliz@gnu.org>
1507
1508 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1509 a character.
1510
4a5885a7
CY
15112011-08-23 Chong Yidong <cyd@stupidchicken.com>
1512
1513 * nsfont.m (ns_otf_to_script): Fix typo.
1514
0902a04e
KH
15152011-08-22 Kenichi Handa <handa@m17n.org>
1516
1517 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1518 extra slot even if the purpose is char-code-property-table.
1519
1a2e6670
EZ
15202011-08-23 Eli Zaretskii <eliz@gnu.org>
1521
8ddde651
EZ
1522 * xdisp.c (redisplay_window): When computing centering_position,
1523 account for the height of the header line. (Bug#8874)
1524
425cc014
EZ
1525 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1526 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1527 candidate is selected by the mouse, and that candidate has a
1528 composed character under the mouse.
1529
1a2e6670
EZ
1530 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1531 coordinates reported by pos-visible-in-window-p for a composed
1532 character in column zero.
1533
8b76d6f8
SM
15342011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1535
1536 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1537
dac347dd
EZ
15382011-08-22 Eli Zaretskii <eliz@gnu.org>
1539
1540 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1541 consider it a hit if to_charpos is anywhere in the range of the
1542 composed buffer positions.
1543
e013fb34
CY
15442011-08-22 Chong Yidong <cyd@stupidchicken.com>
1545
1546 * image.c (gif_load): Don't assume that each subimage has the same
1547 dimensions as the base image. Handle disposal method that is
1548 "undefined" by the gif spec (Bug#9335).
1549
bd1ba3e8
CY
15502011-08-20 Chong Yidong <cyd@stupidchicken.com>
1551
1552 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1553 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1554
54a1215b
EZ
15552011-08-19 Eli Zaretskii <eliz@gnu.org>
1556
823564e5
EZ
1557 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1558 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1559 from an Org mode buffer to a Speedbar frame.
1560
54a1215b
EZ
1561 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1562 a composition, take its buffer position from IT->cmp_it.charpos.
1563 Fixes cursor positioning at the beginning of a line that begins
1564 with a composed character.
1565
9778ebcc
EZ
15662011-08-18 Eli Zaretskii <eliz@gnu.org>
1567
0be6ee06
EZ
1568 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1569 character bidirectional type, use STRONG_L instead. Fixes crashes
1570 in a buffer produced by `describe-categories'.
1571
9778ebcc
EZ
1572 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1573 members before the level stack, so they would be saved and
1574 restored when copying iterator state. Fixes incorrect reordering
1575 around TABs covered by display properties.
1576
156bffbe
AS
15772011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1578
6b02f655 1579 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1580
72ad093b
CY
15812011-08-17 Chong Yidong <cyd@stupidchicken.com>
1582
1583 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1584 (internal_condition_case_2, internal_condition_case_n):
1585 Remove unnecessary aborts (Bug#9081).
72ad093b 1586
35774242
EZ
15872011-08-17 Eli Zaretskii <eliz@gnu.org>
1588
1589 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1590 has no `load' handler, try opening the file locally. (Bug#9311)
1591
db76dd85
KB
15922011-08-16 Ken Brown <kbrown@cornell.edu>
1593
1594 * gmalloc.c: Expand comment.
1595
b215eee5
EZ
15962011-08-16 Eli Zaretskii <eliz@gnu.org>
1597
1598 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1599 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1600
a4579d33
KB
16012011-08-16 Ken Brown <kbrown@cornell.edu>
1602
1603 Fix memory allocation problems in Cygwin build (Bug#9273).
1604
1605 * unexcw.c ( __malloc_initialized): Declare external variable.
1606 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1607
8b76d6f8
SM
1608 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1609 New variables.
a4579d33
KB
1610 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1611 dumped emacs.
1612 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1613 in the static heap.
1614 [CYGWIN] (special_realloc): New function.
1615 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1616 requests to realloc storage in the static heap.
1617
3ebec551
PE
16182011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 * bidi.c (bidi_initialize): Remove unused local.
1621
9fd8be00
EZ
16222011-08-15 Eli Zaretskii <eliz@gnu.org>
1623
6b02f655
SM
1624 * bidimirror.h:
1625 * biditype.h: Remove file.
1626 * makefile.w32-in ($(BLD)/bidi.$(O)):
1627 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1628
1629 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1630
1631 * chartab.c: Improve commentary for the uniprop_table API.
1632
32413314
EZ
1633 * bidi.c (bidi_paragraph_init): Support zero value of
1634 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1635 (bidi_initialize): Use uniprop_table instead of including
1636 biditype.h and bidimirror.h.
32413314 1637
9fd8be00
EZ
1638 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1639 coordinates of the iterator when restoring from ppos_it.
1640 (Bug#9296)
1641
5cf2b69b
KH
16422011-08-14 Kenichi Handa <handa@m17n.org>
1643
1644 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1645 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1646
daf17d00
EZ
16472011-08-14 Eli Zaretskii <eliz@gnu.org>
1648
1649 * xdisp.c (move_it_in_display_line_to): Don't invoke
1650 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1651 ppos_it. Fixes vertical cursor motion when line beginning is
1652 covered by an image. (Bug#9296)
1653
08e3161a
JD
16542011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1655
1656 * nsterm.h (ns_run_ascript): Declare.
1657 (NSAPP_DATA2_RUNASSCRIPT): Define.
1658
1659 * nsfns.m (as_script, as_result, as_status): New static variables.
1660 (ns_run_ascript): New function.
5e617bc2 1661 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1662 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1663 the event loop. Get status from as_status (Bug#7276).
1664
1665 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1666 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1667 the event loop (Bug#7276).
1668
a3720aa2
AS
16692011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1670
1671 * gnutls.c (QCgnutls_bootprop_priority)
1672 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1673 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1674 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1675 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1676 (QCgnutls_bootprop_verify_hostname_error)
1677 (QCgnutls_bootprop_callbacks_verify): Rename from
1678 Qgnutls_bootprop_..., all uses changed.
1679
1680 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1681 uses changed.
1682
0a0d27fb
PE
16832011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1684
19d5c50c
PE
1685 * xfaces.c (Qframe_set_background_mode): Now static.
1686 * dispextern.h (Qframe_set_background_mode): Remove decl.
1687
0a0d27fb
PE
1688 * process.c (Fnetwork_interface_info): Declare local only if needed.
1689
377538cb
JD
16902011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1691
1692 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1693 (Fnetwork_interface_list): Allocate in increments of bytes instead
1694 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1695 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1696 sockaddr.
1697 (struct ifflag_def): notrailers is smart on OSX.
1698 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1699 Get hardware address with getifaddrs if available.
1700
08fff70c
EZ
17012011-08-12 Eli Zaretskii <eliz@gnu.org>
1702
1703 * xdisp.c (iterate_out_of_display_property): xassert that
1704 IT->position is set to within IT->object's boundaries. Break from
1705 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1706 when IT->position is set up wrongly due to some bug.
1707 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1708 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1709 entry. Force push_it to save on the stack the current
1710 buffer/string position, to be restored by pop_it. Fix flags in
1711 the iterator structure wrt the object coming from a display
1712 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1713 properties. (Bug#9284)
1714
7be1c708 17152011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1716
7be1c708
CY
1717 * fontset.c (fontset_get_font_group): Add proper type checks.
1718 (Bug#9172)
aac0c6e3 1719
7be1c708 17202011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1721
7be1c708
CY
1722 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1723 and LC_VERSION_MIN_MACOSX.
1724 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1725 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1726
97bb72a6
EZ
17272011-08-08 Eli Zaretskii <eliz@gnu.org>
1728
1729 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1730 no-display-properties-and-no-overlays under bidi display.
1731 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1732 properties and overlays.
97bb72a6 1733
d5617611
CY
17342011-08-08 Chong Yidong <cyd@stupidchicken.com>
1735
37e11a63
CY
1736 * editfns.c (Fset_time_zone_rule): Document relationship with the
1737 setenv function.
1738
d5617611
CY
1739 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1740 the font entity extracted from the cache (Bug#8109).
1741
58872834
CY
17422011-08-07 Chong Yidong <cyd@stupidchicken.com>
1743
1744 * composite.c (autocmp_chars): Don't reset point. That is done by
1745 restore_point_unwind (Bug#5984).
1746
75bfc667
JL
17472011-08-07 Juri Linkov <juri@jurta.org>
1748
1749 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1750 to show the arg `TIME' instead of `TIMEVAL'.
1751
d1410150
EZ
17522011-08-06 Eli Zaretskii <eliz@gnu.org>
1753
1754 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1755 display property strides EOL and includes a newline, as in
1756 longlines-mode. (Bug#9254)
75b771e4
EZ
1757 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1758 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1759
1760 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1761 is non-zero, even if the data buffer is NULL. Fixes a crash in
1762 vertical-motion with longlines-mode. (Bug#9254)
1763
35928349
EZ
17642011-08-05 Eli Zaretskii <eliz@gnu.org>
1765
ec7cc85b
EZ
1766 * bidi.c <bidi_cache_total_alloc>: Now static.
1767 (bidi_initialize): Initialize bidi_cache_total_alloc.
1768
8b76d6f8 1769 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1770 cache. (Bug#9221)
1771
1772 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1773 amount allocated this far in `bidi_cache_total_alloc'.
1774 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1775 non-zero, only free the data buffer without restoring the cache
1776 contents. All callers changed.
1777
1778 * dispextern.h (bidi_unshelve_cache): Update prototype.
1779
1780 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1781 (move_it_in_display_line, move_it_to)
1782 (move_it_vertically_backward, move_it_by_lines): Replace the call
1783 to xfree to an equivalent call to bidi_unshelve_cache.
1784 (move_it_in_display_line_to): Fix logic of returning
412b6358 1785 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1786
e2e2423b
EZ
17872011-08-05 Eli Zaretskii <eliz@gnu.org>
1788
1789 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1790 came from a string character with a `cursor' property. (Bug#9229)
1791
ae9e757a
JD
17922011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1793
1794 * Makefile.in (LIB_PTHREAD): New variable.
1795 (LIBES): Add LIB_PTHREAD (Bug#9216).
1796
1797 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1798 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1799
213bd7f2
AS
18002011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1801
6b02f655 1802 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1803
99aaf75f
JD
18042011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1805
1806 * xterm.c (x_find_topmost_parent): New function.
1807 (x_set_frame_alpha): Find topmost parent window with
1808 x_find_topmost_parent and set the property there also (bug#9181).
1809 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1810
c74e9d86
PE
18112011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1812
1813 * callproc.c (Fcall_process): Avoid vfork clobbering
1814 the local vars buffer, coding_systems, current_dir.
1815
640c8776
SM
18162011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1817
1818 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1819
f26d0e4c
PE
18202011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1821
8a10d76c
PE
1822 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1823 so that it is not optimized away.
1824
f26d0e4c
PE
1825 * xdisp.c (compute_display_string_pos): Remove unused local.
1826
55439c61
EZ
18272011-08-02 Eli Zaretskii <eliz@gnu.org>
1828
1829 Fix slow cursor motion and scrolling in large buffers with
1830 selective display, like Org Mode buffers. (Bug#9218)
1831
1832 * dispextern.h (struct bidi_it): New member disp_prop_p.
1833
1834 * xdisp.c: Remove one-slot cache of display string positions.
1835 (compute_display_string_pos): Accept an additional argument
5e617bc2 1836 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1837 for a display string or property. If found, set DISP_PROP_P
1838 non-zero.
1839
1840 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1841 DISP_PROP_P, and pass it to compute_display_string_pos.
1842 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1843 non-zero. All callers of bidi_fetch_char changed.
1844
fb33fa43
SM
18452011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1846
1847 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1848
b099e063
DM
18492010-12-03 Don March <don@ohspite.net>
1850
1851 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1852 last character M-[char] is translated to ESC [char] (bug#7541).
1853
5cc7f7af
KH
18542011-08-02 Kenichi Handa <handa@m17n.org>
1855
d0fffa3f 1856 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1857
1858 * chartab.c (uniprop_table): Make it non-static.
1859
525d5e6e
EZ
18602011-08-01 Eli Zaretskii <eliz@gnu.org>
1861
1862 * xdisp.c (forward_to_next_line_start): Accept additional argument
1863 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1864 on the newline.
1865 (reseat_at_next_visible_line_start): Use the bidi iterator state
1866 returned by forward_to_next_line_start to restore the state of
1867 it->bidi_it after backing up to previous newline. (Bug#9212)
1868
31011111
AS
18692011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1870
1871 * regex.c (re_comp): Protoize.
1872 (re_exec): Fix return type.
1873 (regexec): Fix type of `ret'. (Bug#9203)
1874
476371c4
PE
18752011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1876
e5d76069
PE
1877 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1878 This is needed if max-image-size is a floating-point number.
1879
9a79b20c
AS
18802011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1881
1882 * print.c (print_object): Print empty symbol as ##.
1883
1884 * lread.c (read1): Read ## as empty symbol.
1885
d8c2fa78
AA
18862011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1887
1888 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1889 setting frame foreground color (Bug#9175).
1890 (x_set_background_color): Likewise.
1891
ffe57a7a
AA
1892 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1893 contents (Bug#9176).
1894 (EmacsTooltip -init): Remove bezels and add shadows to
1895 tooltip windows.
1896
bf3492a5
AA
1897 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1898 or scroll bar (Bug#8470).
1899
d55e9c53
AA
1900 * nsfont.m (nsfont_open): Remove assignment to voffset and
1901 unnecessary vars hshink, expand, hd, full_height, min_height.
1902 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1903
1904 * nsterm.h (nsfont_info): Remove voffset field.
1905
d8c2fa78 19062011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1907
1908 Implement strike-through and overline on NextStep (Bug#8863).
1909
1910 * nsfont.m (nsfont_open): Use underline position provided by font,
1911 instead of hard-coded value of 2.
1912 (nsfont_draw): Call ns_draw_text_decoration instead.
1913
1914 * nsterm.h: Add declaration for ns_draw_text_decoration.
1915
1916 * nsterm.m (ns_draw_text_decoration): New function for drawing
1917 underline, overline, and strike-through.
1918 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1919 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1920 accommodate underlining, etc.
4843aac3 1921
4cc60b9b
EZ
19222011-07-28 Eli Zaretskii <eliz@gnu.org>
1923
bc7ece87
EZ
1924 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1925 default.
4cc60b9b 1926
476371c4
PE
19272011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1928
66606eea
PE
1929 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1930 Without this fix, if a signal arrives just after memory fills up,
1931 'malloc' might be invoked reentrantly.
1932
476371c4
PE
1933 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1934 In other words, assume that every image size is allowed, on non-X
1935 hosts. This assumption is probably wrong, but it lets Emacs compile.
1936
f3fcc40d
AS
19372011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1938
1939 * regex.c (re_iswctype): Convert return values to boolean.
1940
350c992f
EZ
19412011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1942
1943 * xdisp.c (compute_display_string_pos): Don't use cached display
1944 string position if the buffer had its restriction changed.
1945 (Bug#9184)
1946
5266b4bb
PE
19472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1948
1949 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1950
2573a837 19512011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1952
41f55ccd 1953 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1954
39e378da
PE
1955 * bidi.c: Integer size and overflow fixes.
1956 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1957 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1958 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1959 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1960 (bidi_find_other_level_edge):
1961 Use ptrdiff_t instead of EMACS_INT where either will do.
1962 This works better on 32-bit hosts configured --with-wide-int.
1963 (bidi_cache_ensure_space): Check for size-calculation overflow.
1964 Use % rather than repeated addition, for better worst-case speed.
1965 Don't set bidi_cache_size until after xrealloc returns, because it
1966 might not return.
1967 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1968 (bidi_cache_ensure_space): Also check that the bidi cache size
1969 does not exceed that of the largest Lisp string or buffer. See Eli
1970 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1971
5e927815
PE
1972 * alloc.c (__malloc_size_t): Remove.
1973 All uses replaced by size_t. See Andreas Schwab's note
1974 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1975
ca4aa935
PE
1976 * image.c: Improve checking for integer overflow.
1977 (check_image_size): Assume that f is nonnull, since
1978 it is always nonnull in practice. This is one less thing to
1979 worry about when checking for integer overflow later.
1980 (x_check_image_size): New function, which checks for integer
1981 overflow issues inside X.
1982 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1983 This removes the need for a memory_full check.
1984 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1985 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1986 (xbm_read_bitmap_data): Change locals back to 'int', since
1987 their values must fit in 'int'.
1988 (xpm_load_image, png_load, tiff_load):
1989 Invoke x_create_x_image_and_pixmap earlier,
1990 to avoid much needless work if the image is too large.
1991 (tiff_load): Treat overly large images as if
1992 x_create_x_image_and_pixmap failed, not as malloc failures.
1993 (gs_load): Use x_check_image_size.
1994
5f8f9cc2
PE
1995 * gtkutil.c: Omit integer casts.
1996 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1997 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1998
5adf60bc
PE
1999 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2000
c8907a93
PE
2001 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2002 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2003 would wrongly return t on a 64-bit host.
2004
e3c25c68
PE
2005 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2006 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2007 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2008 and therefore cause GCC to emit a bogus diagnostic in some cases.
2009
3f791afe
PE
2010 * image.c: Integer signedness and overflow and related fixes.
2011 This is not an exhaustive set of fixes, but it's time to
2012 record what I've got.
2013 (lookup_pixel_color, check_image_size): Remove redundant decls.
2014 (check_image_size): Don't assume that arbitrary EMACS_INT values
2015 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2016 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2017 (tiff_load, imagemagick_load_image):
2018 Check for overflow in size calculations.
2019 (x_create_x_image_and_pixmap): Remove unnecessary test for
2020 xmalloc returning NULL; that can't happen.
2021 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2022 (xpm_color_bucket): Use better integer hashing function.
2023 (xpm_cache_color): Don't possibly over-allocate memory.
2024 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2025 (gif_memory_source):
2026 Use ptrdiff_t, not int or size_t, to record sizes.
2027 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2028 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2029 either works, as we prefer signed integers.
2030 (tiff_read_from_memory, tiff_write_from_memory):
2031 Return tsize_t, not size_t, since that's what the TIFF API wants.
2032 (tiff_read_from_memory): Don't fail simply because the read would
2033 go past EOF; instead, return a short read.
2034 (tiff_load): Omit no-longer-needed casts.
2035 (Fimagemagick_types): Don't assume size fits into 'int'.
2036
3cc5a532
PE
2037 Improve hashing quality when configured --with-wide-int.
2038 * fns.c (hash_string): New function, taken from sxhash_string.
2039 Do not discard information about ASCII character case; this
2040 discarding is no longer needed.
2041 (sxhash-string): Use it. Change sig to match it. Caller changed.
2042 * lisp.h: Declare it.
2043 * lread.c (hash_string): Remove, since we now use fns.c's version.
2044 The fns.c version returns a wider integer if --with-wide-int is
2045 specified, so this should help the quality of the hashing a bit.
2046
b312a492
PE
2047 * emacs.c: Integer overflow minor fix.
2048 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2049 Define only if GNU_LINUX.
2050 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2051
dfd153ae
PE
2052 * dispnew.c: Integer signedness and overflow fixes.
2053 Remove unnecessary forward decls, that were a maintenance hassle.
2054 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2055 All uses changed.
2056 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2057 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2058 (prepare_desired_row, line_draw_cost):
2059 Use int, not unsigned, where either works.
2060 (save_current_matrix, restore_current_matrix):
2061 Use ptrdiff_t, not size_t, where either works.
2062 (init_display): Check for overflow more accurately, and without
2063 relying on undefined behavior.
2064
a81d11a3
PE
2065 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2066 Remove, replacing with the new symbols in lisp.h. All uses changed.
2067 * fileio.c (make_temp_name):
2068 * filelock.c (lock_file_1, lock_file):
2069 * xdisp.c (message_dolog):
2070 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2071 Use pMd etc. instead.
2072 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2073 replacing the pWIDE etc. symbols removed from editfns.c.
2074
3300e6fd
PE
2075 * keyboard.h (num_input_events): Now uintmax_t.
2076 This is (very slightly) less likely to mess up due to wraparound.
2077 All uses changed.
2078
fd05c7e9
PE
2079 * buffer.c: Integer signedness fixes.
2080 (alloc_buffer_text, enlarge_buffer_text):
2081 Use ptrdiff_t rather than size_t when either will do, as we prefer
2082 signed integers.
2083
903fe15d
PE
2084 * alloc.c: Integer signedness and overflow fixes.
2085 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2086 (__malloc_size_t): Default to size_t, not to int.
2087 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2088 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2089 Prefer ptrdiff_t to size_t when either would do, as we prefer
2090 signed integers.
2091 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2092 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2093 Now const. Initialize with values that are in range even if char
2094 is signed.
2095 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2096 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2097 These functions do the right thing with sizes > 2**32.
2098 (check_depth): Now ptrdiff_t, not int.
2099 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2100 Adjust to new way of storing sizes. Check for size overflow bugs
2101 in rest of code.
2102 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2103 slightly wrong anyway, as it missed one instance of
2104 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2105 (refill_memory_reserve): Omit needless cast to size_t.
2106 (mark_object_loop_halt): Mark as externally visible.
2107
ac82cc6a
PE
2108 * xselect.c: Integer signedness and overflow fixes.
2109 (Fx_register_dnd_atom, x_handle_dnd_message):
2110 Use ptrdiff_t, not size_t, since we prefer signed.
2111 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2112 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2113 x_dnd_atoms_size and x_dnd_atoms_length.
2114
c2d1e36d
PE
2115 * doprnt.c: Prefer signed to unsigned when either works.
2116 * eval.c (verror):
2117 * doprnt.c (doprnt):
2118 * lisp.h (doprnt):
2119 * xdisp.c (vmessage):
2120 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2121 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2122 prefer signed arithmetic to avoid comparison confusion.
2123 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2124 but is a bit tricky.
2125
0e926e56
PE
2126 Assume freestanding C89 headers, string.h, stdlib.h.
2127 * data.c, doprnt.c, floatfns.c, print.c:
2128 Include float.h unconditionally.
2129 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2130 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2131 * regex.c: Likewise for stddef.h, string.h.
2132 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2133 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2134 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2135 (STDC_HEADERS): Remove obsolete defines.
2136 * sysdep.c: Include limits.h unconditionally.
2137
9cfdb3ec
PE
2138 Assume support for memcmp, memcpy, memmove, memset.
2139 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2140 * regex.c (memcmp, memcpy):
2141 Remove; we assume C89 now.
2142
2143 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2144 (__malloc_safe_bcopy): Remove; no longer needed.
2145
cf950e6b 2146 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2147 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2148 well either way, and we prefer signed to unsigned.
2149
dbf38e02
LMI
21502011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2151
2152 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2153 closes the connection while we're reading (bug#9182).
2154
d6f0886c 21552011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2156
d6f0886c
JD
2157 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2158 are specified (Bug#9168).
24e0f6b1 2159
2eb1f9e6
PE
21602011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2161
2162 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2163 Found by GCC static checking and --with-wide-int on a 32-bit host.
2164
22381272 21652011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2166
2167 * xdisp.c (compute_display_string_pos): Fix logic of caching
2168 previous display string position. Initialize cached_prev_pos to
2169 -1. Fixes slow-down at the beginning of a buffer.
2170
f25e39b4
EZ
21712011-07-24 Eli Zaretskii <eliz@gnu.org>
2172
2173 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2174 for attrs[LFACE_FONTSET_INDEX].
2175
04c4b52e
PE
21762011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2177
2178 * xml.c (parse_region): Remove unused local
2179 that was recently introduced.
2180
c1734fbd
EZ
21812011-07-23 Eli Zaretskii <eliz@gnu.org>
2182
be18c5a5
EZ
2183 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2184 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2185
c1734fbd
EZ
2186 * xdisp.c (move_it_in_display_line_to): Record the best matching
2187 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2188 exit if none of the characters scanned was an exact match.
2189 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2190 when exact match is impossible due to invisible text, and the
2191 lines are truncated.
2192
a258d627
JD
21932011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2194
2195 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2196 for OSX >= 10.7.
2197
b6d5a689
EZ
21982011-07-22 Eli Zaretskii <eliz@gnu.org>
2199
0f74f785
EZ
2200 Fix a significant slow-down of cursor motion with C-n, C-p,
2201 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2202 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2203 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2204 (next_element_from_buffer): Call compute_stop_pos_backwards to
2205 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2206 base_level_stop.
2207 (reseat): Don't look for prev_stop, as that could mean a very long
2208 run.
2209 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2210 <cached_disp_overlay_modiff>: Cache for last found display string
2211 position.
551918c1 2212 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2213 about the same buffer in the same area of character positions, and
2214 the buffer wasn't changed since the time the display string
2215 position was cached.
551918c1 2216
b2d0c91a
EZ
22172011-07-22 Eli Zaretskii <eliz@gnu.org>
2218
2219 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2220 is an integer, which is important for empty lines. (Bug#9149)
2221
043604ee
CY
22222011-07-22 Chong Yidong <cyd@stupidchicken.com>
2223
2224 * frame.c (Fmodify_frame_parameters): In tty case, update the
2225 default face if necessary (Bug#4238).
2226
da4adb04
CY
22272011-07-21 Chong Yidong <cyd@stupidchicken.com>
2228
2229 * editfns.c (Fstring_to_char): No need to explain what a character
2230 is in the docstring (Bug#6576).
2231
9abd0532
LMI
22322011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2233
2234 * xml.c (parse_region): Make sure we always return a tree.
2235
36881d16
HK
22362011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2237
2238 * xml.c (parse_region): If a document contains only comments,
2239 return that, too.
2240
1e98674d
LMI
22412011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2242
2243 * xml.c (make_dom): Return comments, too.
2244
590bd467
PE
22452011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2246
2247 Port to OpenBSD.
2248 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2249 and the surrounding thread.
2250 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2251 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2252 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2253 timer goes off.
2254 * s/openbsd.h (BROKEN_SIGIO): Define.
2255 * unexelf.c (unexec) [__OpenBSD__]:
2256 Don't update the .mdebug section of the Alpha COFF symbol table.
2257
f41628b2
LMI
22582011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2259
2260 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2261 (bug#8460).
2262
b59b67c5
PE
22632011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2264
15e3a074
PE
2265 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2266 This fixes some race conditions on the permissions of any newly
2267 created file.
2268
41bed37d
PE
2269 * alloc.c (valid_pointer_p): Use pipe, not open.
2270 This fixes some permissions issues when debugging.
2271
b59b67c5
PE
2272 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2273 If fchown fails to set both uid and gid, try to set just gid,
2274 as that is sometimes allowed. Adjust the file's mode to eliminate
2275 setuid or setgid bits that are inappropriate if fchown fails.
2276
925a6be7
SM
22772011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2278
2279 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2280 to compare Lisp_Objects.
2281 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2282 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2283 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2284
52968808
AS
22852011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2286
0a6a104b
AS
2287 * lread.c (read_integer): Unread even EOF character.
2288 (read1): Likewise. Properly record start position of symbol.
2289
52968808
AS
2290 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2291 symbol character follows.
2292
9e381cdd
PE
22932011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2294
2295 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2296 This works around a problem with the previous change to Fcopy_file.
2297 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2298 and without this change, GCC might complain about discarding
2299 fchown's return value.
2300
b5641435
JB
23012011-07-16 Juanma Barranquero <lekktu@gmail.com>
2302
2303 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2304
a8031457
PE
23052011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2306
2307 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2308
dd889327
LMI
23092011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2310
750c33f7
LMI
2311 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2312 it's used from the C level.
2313
dd889327
LMI
2314 * process.c: Use the same condition for POLL_FOR_INPUT in both
2315 keyboard.c and process.c (bug#1858).
2316
87e86684
LM
23172011-07-09 Lawrence Mitchell <wence@gmx.li>
2318
2319 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2320 (Fgnutls_boot): Use it.
2321
64348f40
AS
23222011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2323
2324 * doc.c (Fsubstitute_command_keys): Revert last change.
2325
1d698799
LMI
23262011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2327
f863868c
LMI
2328 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2329 quotes the next character, and doesn't affect other longer
2330 sequences (bug#8935).
2331
1d698799
LMI
2332 * lread.c (syms_of_lread): Clarify that is isn't only
2333 `eval-buffer' and `eval-defun' that's affected by
2334 `lexical-binding' (bug#8460).
2335
aa4b6df6
EZ
23362011-07-15 Eli Zaretskii <eliz@gnu.org>
2337
2338 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2339 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2340
5d856da6
PE
23412011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2342
ad6042bb
PE
2343 Fix minor problems found by static checking.
2344 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2345 (elsz): Now a signed constant, not a size_t var. We prefer signed
2346 types to unsigned, to avoid integer comparison confusion. Without
2347 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2348 "cannot optimize loop, the loop counter may overflow", a symptom
2349 of the confusion.
f00bbb22 2350 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2351 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2352
6468f31c
LMI
23532011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2354
49080b10
LMI
2355 * search.c (Fre_search_backward): Mention `case-fold-search' in
2356 all the re_search_* functions (bug#8138).
2357
6468f31c
LMI
2358 * keyboard.c (Fopen_dribble_file): Document when the file is
2359 closed (bug#8056).
2360
c965adc5
EZ
23612011-07-14 Eli Zaretskii <eliz@gnu.org>
2362
df9733bf
EZ
2363 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2364 bidi_cache_idx.
2365
0bb23927
EZ
2366 Support bidi reordering of display and overlay strings.
2367 * xdisp.c (compute_display_string_pos)
2368 (compute_display_string_end): Accept additional argument STRING.
2369 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2370 (reseat_to_string): Initialize bidi_it->string.s and
2371 bidi_it->string.schars.
2372 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2373 NULL (avoids a crash in bidi_paragraph_init).
2374 Initialize itb.string.lstring.
0bb23927
EZ
2375 (init_iterator): Call bidi_init_it only of a valid
2376 buffer position was specified. Initialize paragraph_embedding to
2377 L2R.
2378 (reseat_to_string): Initialize the bidi iterator.
2379 (display_string): If we need to ignore text properties of
2380 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2381 original value of -1 will not work with bidi.)
2382 (compute_display_string_pos): First arg is now struct
2383 `text_pos *'; all callers changed. Support display properties on
2384 Lisp strings.
2385 (compute_display_string_end): Support display properties on Lisp
2386 strings.
2387 (init_iterator, reseat_1, reseat_to_string): Initialize the
2388 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2389 when iterating on a string not from display properties).
640c8776
SM
2390 (compute_display_string_pos, compute_display_string_end):
2391 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2392 arrow keys.
2393 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2394 base_level_stop; instead, set base_level_stop to BEGV.
2395 Fixes crashes in vertical-motion.
0bb23927
EZ
2396 (next_element_from_buffer): Improve commentary for when
2397 the iterator is before prev_stop.
2398 (init_iterator): Initialize bidi_p from the default value of
2399 bidi-display-reordering, not from buffer-local value. Use the
2400 buffer-local value only if initializing for buffer iteration.
2401 (handle_invisible_prop): Support invisible properties on strings
2402 that are being bidi-reordered.
2403 (set_iterator_to_next): Support bidi reordering of C strings and
2404 Lisp strings.
2405 (next_element_from_string): Support bidi reordering of Lisp
2406 strings.
2407 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2408 (display_string): Support display of R2L glyph rows.
2409 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2410 (init_iterator): Don't initialize it->bidi_p for strings
2411 here.
2412 (reseat_to_string): Initialize it->bidi_p for strings here.
2413 (next_element_from_string, next_element_from_c_string)
2414 (next_element_from_buffer): Add xassert's for correspondence
2415 between IT's object being iterated and it->bidi_it.string
2416 structure.
2417 (face_before_or_after_it_pos): Support bidi iteration.
2418 (next_element_from_c_string): Handle the case of the first string
2419 character that is not the first one in the visual order.
2420 (get_visually_first_element): New function, refactored from common
2421 parts of next_element_from_buffer, next_element_from_string, and
2422 next_element_from_c_string.
2423 (tool_bar_lines_needed, redisplay_tool_bar)
2424 (display_menu_bar): Force left-to-right direction. Add a FIXME
2425 comment for making that be controlled by a user option.
2426 (push_it, pop_it): Save and restore the state of the
2427 bidi iterator. Save and restore the bidi_p flag.
2428 (pop_it): Iterate out of display property for string iteration as
2429 well.
2430 (iterate_out_of_display_property): Support iteration over strings.
2431 (handle_single_display_spec): Set up it->bidi_it for iteration
2432 over a display string, and call bidi_init_it.
2433 (handle_single_display_spec, next_overlay_string)
2434 (get_overlay_strings_1, push_display_prop): Set up the bidi
2435 iterator for displaying display or overlay strings.
2436 (forward_to_next_line_start): Don't use the shortcut if
2437 bidi-iterating.
2438 (back_to_previous_visible_line_start): If handle_display_prop
2439 pushed the iterator stack, restore the internal state of the bidi
2440 iterator by calling bidi_pop_it same number of times.
2441 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2442 and we are bidi-iterating, don't decrement the iterator position;
2443 instead, set the first_elt flag in the bidi iterator, to produce
2444 the same effect.
2445 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2446 (push_display_prop): xassert that we are iterating a buffer.
2447 (push_it, pop_it): Save and restore paragraph_embedding member.
2448 (handle_single_display_spec, next_overlay_string)
2449 (get_overlay_strings_1, reseat_1, reseat_to_string)
2450 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2451 correctly. Don't assume unibyte strings are not bidi-reordered.
2452 (compute_display_string_pos)
2453 (compute_display_string_end): Fix handling the case of C string.
2454 (push_it, pop_it): Save and restore from_disp_prop_p.
2455 (handle_single_display_spec, push_display_prop): Set the
2456 from_disp_prop_p flag.
2457 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2458 (pop_it): Call iterate_out_of_display_property only if we are
2459 popping after iteration over a string that came from a display
2460 property. Fix a typo in popping stretch info. Add an assertion
2461 for verifying that the iterator position is in sync with the bidi
2462 iterator.
2463 (handle_single_display_spec, get_overlay_strings_1)
2464 (push_display_prop): Fix initialization of paragraph direction for
2465 string when that of the parent object is not yet determined.
2466 (reseat_1): Call bidi_init_it to resync the bidi
2467 iterator with IT's position. (Bug#7616)
2468 (find_row_edges): If ROW->start.pos gives position
2469 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2470 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2471 Reset the from_disp_prop_p flag.
2472 (SAVE_IT, RESTORE_IT): New macros.
2473 (pos_visible_p, face_before_or_after_it_pos)
2474 (back_to_previous_visible_line_start)
2475 (move_it_in_display_line_to, move_it_in_display_line)
2476 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2477 (try_scrolling, redisplay_window, display_line): Use them when
2478 saving a temporary copy of the iterator and restoring it back.
2479 (back_to_previous_visible_line_start, reseat_1)
2480 (init_iterator): Empty the bidi cache "stack".
2481 (move_it_in_display_line_to): If iterator ended up at
2482 EOL, but we never saw any buffer positions smaller than
2483 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2484 motion in bidi-reordered lines.
2485 (move_it_in_display_line_to): Record prev_method and prev_pos
2486 immediately before the call to set_iterator_to_next. Fixes cursor
2487 motion in bidi-reordered lines with stretch glyphs and strings
2488 displayed in margins. (Bug#8133) (Bug#8867)
2489 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2490 TO_CHARPOS.
640c8776
SM
2491 (pos_visible_p): Support positions in bidi-reordered lines.
2492 Save and restore bidi cache.
0bb23927
EZ
2493
2494 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2495 (bidi_paragraph_info): Delete unused struct.
2496 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2497 (bidi_cache_start): New variable.
2498 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2499 to zero.
2500 (bidi_cache_fetch_state, bidi_cache_search)
2501 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2502 (bidi_cache_find, bidi_peek_at_next_level)
2503 (bidi_level_of_next_char, bidi_find_other_level_edge)
2504 (bidi_move_to_visually_next): Compare cache index with
2505 bidi_cache_start rather than with zero.
2506 (bidi_fetch_char): Accept new argument STRING; all callers
2507 changed. Support iteration over a string. Support strings with
2508 display properties. Support unibyte strings. Fix the type of
2509 `len' according to what STRING_CHAR_AND_LENGTH expects.
2510 (bidi_paragraph_init, bidi_resolve_explicit_1)
2511 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2512 (bidi_level_of_next_char, bidi_move_to_visually_next):
2513 Support iteration over a string.
0bb23927
EZ
2514 (bidi_set_sor_type, bidi_resolve_explicit_1)
2515 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2516 can now be zero (for strings); special values 0 and -1 were
2517 changed to -1 and -2, respectively.
2518 (bidi_char_at_pos): New function.
2519 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2520 Call it instead of FETCH_MULTIBYTE_CHAR.
2521 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2522 initialized to valid values.
2523 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2524 values.
2525 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2526 the test for valid cached positions. Fix the logic for looking up
2527 the sentinel state in the cache. GCPRO the Lisp string we are
2528 iterating.
2529 (bidi_push_it, bidi_pop_it): New functions.
2530 (bidi_initialize): Initialize the bidi cache start stack pointer.
2531 (bidi_cache_ensure_space): New function, refactored from part of
2532 bidi_cache_iterator_state. Don't assume the required size is just
2533 one BIDI_CACHE_CHUNK away.
2534 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2535 (bidi_count_bytes, bidi_char_at_pos): New functions.
2536 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2537 always valid if bidi_cache_idx is valid.
2538 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2539 is valid if it's going to be used.
2540 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2541 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2542 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2543 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2544 (bidi_find_other_level_edge, bidi_cache_start_stack):
2545 All variables related to cache indices are now EMACS_INT.
c965adc5 2546
0bb23927
EZ
2547 * dispextern.h (struct bidi_string_data): New structure.
2548 (struct bidi_it): New member `string'. Make flag members be 1-bit
2549 fields, and put them last in the struct.
640c8776
SM
2550 (compute_display_string_pos, compute_display_string_end):
2551 Update prototypes.
0bb23927
EZ
2552 (bidi_push_it, bidi_pop_it): Add prototypes.
2553 (struct iterator_stack_entry): New members bidi_p,
2554 paragraph_embedding, and from_disp_prop_p.
2555 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2556 (bidi_shelve_cache, bidi_unshelve_cache):
2557 Declare prototypes.
0bb23927
EZ
2558
2559 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2560 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2561 and vector-like objects.
2562
2563 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2564 cache around display iteration.
2565
2566 * window.c (Fwindow_end, window_scroll_pixel_based)
2567 (displayed_window_lines, Frecenter): Save and restore the bidi
2568 cache around display iteration.
2569
3bbd2265
LMI
25702011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2571
2572 * editfns.c (Fdelete_region): Clarify the use of the named
2573 parameters (bug#6788).
2574
adc47434
MR
25752011-07-14 Martin Rudalics <rudalics@gmx.at>
2576
2577 * indent.c (Fvertical_motion): Set and restore w->pointm when
2578 saving and restoring the window's buffer (Bug#9006).
2579
837c31f8
LMI
25802011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2581
2582 * editfns.c (Fstring_to_char): Clarify just what is returned
2583 (bug#6576). Text by Eli Zaretskii.
2584
ac389d0c
JB
25852011-07-13 Juanma Barranquero <lekktu@gmail.com>
2586
2587 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2588
0be0ce47
EZ
25892011-07-13 Eli Zaretskii <eliz@gnu.org>
2590
2591 * buffer.c (mmap_find): Fix a typo.
2592
cd18e7e3
JB
25932011-07-13 Johan Bockgård <bojohan@gnu.org>
2594
2595 Fix execution of x selection hooks.
2596 * xselect.c (Qx_lost_selection_functions)
2597 (Qx_sent_selection_functions): New vars.
2598 (syms_of_xselect): DEFSYM them.
2599 (x_handle_selection_request): Pass Qx_sent_selection_functions
2600 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2601 (x_handle_selection_clear,x_clear_frame_selections):
2602 Pass Qx_lost_selection_functions rather than
2603 Vx_lost_selection_functions to Frun_hook_with_args.
2604
47ea7f44
PE
26052011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2606
ac389d0c 2607 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2608 The old code sometimes used this field without initializing it.
2609
47ea7f44
PE
2610 * alloc.c (gc_sweep): Don't read past end of array.
2611 In theory, the old code could also have corrupted Emacs internals,
2612 though it'd be very unlikely.
2613
bc985c87
AS
26142011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2615
2616 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2617 argument. (Bug#4026)
bc985c87 2618
0cf34688
LMI
26192011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2620
b3dadd76
LMI
2621 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2622 key" (bug#4257).
2623
0cf34688
LMI
2624 * window.c (Fset_window_start): Doc fix (bug#4199).
2625 (Fset_window_hscroll): Ditto.
2626
270768cd
PE
26272011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2628
077e3dda 2629 Fix minor new problems caught by GCC 4.6.1.
270768cd 2630 * term.c (init_tty): Remove unused local.
490011a6 2631 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2632 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2633 not used otherwise.
270768cd 2634
b1f58454
CY
26352011-07-12 Chong Yidong <cyd@stupidchicken.com>
2636
2637 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2638
22b9578d
LMI
26392011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2640
6e70ab07
LMI
2641 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2642 are the mini-buffer and the echo area (bug#3320).
2643
22b9578d
LMI
2644 * term.c (init_tty): Remove support for supdup, c10 and perq
2645 terminals, which are no longer supported (bug#1482).
2646
8974cc9f
JB
26472011-07-10 Johan Bockgård <bojohan@gnu.org>
2648
2649 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2650
a560d974
JD
26512011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2652
2653 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2654 for non-popups (Bug#3642).
2655
1dae0f0a
AS
26562011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2657
268c2c36 2658 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2659 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2660 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2661 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2662 * data.c (fmod): Likewise.
2663 * dispnew.c (swap_glyphs_in_rows): Likewise.
2664 * emacs.c (memory_warning_signal): Likewise.
2665 * floatfns.c (float_error): Likewise.
2666 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2667 (otf_open, font_otf_capability, generate_otf_features)
2668 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2669 Likewise.
2670 * image.c (pbm_read_file): Likewise.
2671 * indent.c (string_display_width): Likewise.
2672 * intervals.c (check_for_interval, search_for_interval)
2673 (inc_interval_count, count_intervals, root_interval)
2674 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2675 * lread.c (defalias): Likewise.
268c2c36 2676 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2677 * regex.c (set_image_of_range_1, set_image_of_range)
2678 (regex_grow_registers): Likewise.
2679 * sysdep.c (strerror): Likewise.
2680 * termcap.c (valid_filename_p, tprint, main): Likewise.
2681 * tparam.c (main): Likewise.
2682 * unexhp9k800.c (run_time_remap, save_data_space)
2683 (update_file_ptrs, read_header, write_header, calculate_checksum)
2684 (copy_file, copy_rest, display_header): Likewise.
2685 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2686 Likewise.
2687 * xdisp.c (check_it): Likewise.
2688 * xfaces.c (register_color, unregister_color, unregister_colors):
2689 Likewise.
2690 * xfns.c (print_fontset_result): Likewise.
2691 * xrdb.c (member, fatal, main): Likewise.
2692
99033785
PE
26932011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2694
2695 Fix minor problems found by static checking (Bug#9031).
2696 * chartab.c (char_table_set_range, map_sub_char_table):
2697 Remove unused locals.
2698 (uniprop_table): Now static.
2699 * composite.c (_work_char): Remove unused static var.
2700
9cb2ac56
JB
27012011-07-09 Juanma Barranquero <lekktu@gmail.com>
2702
2703 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2704
f25661f0
JD
27052011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2706
2707 * gtkutil.c (qttip_cb): Remove code without function.
2708
8278c4fe
EZ
27092011-07-09 Eli Zaretskii <eliz@gnu.org>
2710
2711 * w32.c (pthread_sigmask): New stub.
2712
1692ae2d 27132011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2714
8a6ebd58 2715 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2716 sigprocmask is portable only for single-threaded applications, and
2717 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2718 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2719 (LIBES): Use it.
2720 * callproc.c (Fcall_process):
2721 * process.c (create_process):
2722 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2723 Use pthread_sigmask, not sigprocmask.
123403e4 2724
1b854618
JD
27252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2726
2727 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2728 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2729 wrong (Bug#8591).
2730
3fe4b549
JD
27312011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2732
0ce7e563
JD
2733 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2734 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2735 (xg_hide_tooltip): Fix comment.
2736
3fe4b549
JD
2737 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2738 in registerServicesMenuSendTypes.
2739 (validRequestorForSendType): Don't check ns_return_types.
2740
2741 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2742 ns_return_type.
2743
5df75e47
JR
27442011-07-08 Jason Rumney <jasonr@gnu.org>
2745
2746 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2747 frame struct members of non-existent frames (Bug#6284).
2748
699c10bd
JD
27492011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2750
4393663b
JD
2751 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2752 variable firstTime not needed on OSX >= 10.6.
2753 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2754 >= 10.5. Use setKnobProportion, setDoubleValue.
2755
2756 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2757 (MAC_OS_X_VERSION_10_5): Define if not defined.
2758 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2759 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2760 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2761
2762 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2763 cString and lossyCString on OSX >= 10.4
2764
2765 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2766 sizeToFit on OSX >= 10.2.
2767
2768 * nsimage.m (allocInitFromFile): Don't use deprecated method
2769 bestRepresentationForDevice on OSX >= 10.6.
2770
2771 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2772 to avoid warning.
2773
2774 * emacs.c: Declare unexec_init_emacs_zone.
2775
a63e0781
JD
2776 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2777
699c10bd
JD
2778 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2779
2780 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2781 on svcsMenu (Bug#8842).
2782
2783 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2784 ns_return_types.
2785 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2786
2787 * nsterm.m (QUTF8_STRING): Declare.
2788 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2789 (validRequestorForSendType): Return type is (id).
2790 Change indexOfObjectIdenticalTo to indexOfObject.
2791 Check if we have local selection before returning self (Bug#8842).
2792 (writeSelectionToPasteboard): Put local selection into paste board
2793 if we have a local selection (Bug#8842).
2794 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2795
2796 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2797 (ns_get_local_selection): Declare.
2798
54e10184
LMI
27992011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2800
9888ff71
LMI
2801 * keymap.c (describe_map_tree): Don't insert a double newline at
2802 the end of the buffer (bug#1169) and return whether we inserted
2803 something.
2804
54e10184
LMI
2805 * callint.c (Fcall_interactively): Change "reading args" to
2806 "providing args" to try to clarify what it does (bug#1010).
2807
15fa4783
KH
28082011-07-07 Kenichi Handa <handa@m17n.org>
2809
2810 * composite.c (composition_compute_stop_pos): Ignore a static
2811 composition starting before CHARPOS (Bug#8915).
2812
2813 * xdisp.c (handle_composition_prop): Likewise.
2814
a8815b00
EZ
28152011-07-07 Eli Zaretskii <eliz@gnu.org>
2816
2817 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2818 (Bug#9015)
2819
ef7b981d 28202011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2821
2822 * character.h (unicode_category_t): New enum type.
2823
2824 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2825 (Qchar_code_property_table): New variable.
2826 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2827 (UNIPROP_COMPRESSED_FORM_P): New macros.
2828 (char_table_ascii): Uncompress the compressed values.
2829 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2830 Uncompress the compressed values.
ac389d0c 2831 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2832 (char_table_ref_and_range): Uncompress the compressed values.
2833 (sub_char_table_set): New arg is_uniprop. Callers changed.
2834 Uncompress the compressed values.
2835 (sub_char_table_set_range): Args changed. Callers changed.
2836 (char_table_set_range): Adjuted for the above change.
2837 (map_sub_char_table): Delete args default_val and parent. Add arg
2838 top. Give decoded values to a Lisp function.
640c8776 2839 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2840 values to a Lisp function. Gcpro more variables.
2841 (uniprop_table_uncompress)
2842 (uniprop_decode_value_run_length): New functions.
2843 (uniprop_decoder, uniprop_decoder_count): New variables.
2844 (uniprop_get_decoder, uniprop_encode_value_character)
2845 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2846 New functions.
2847 (uniprop_encoder, uniprop_encoder_count): New variables.
2848 (uniprop_get_encoder, uniprop_table)
2849 (Funicode_property_table_internal, Fget_unicode_property_internal)
2850 (Fput_unicode_property_internal): New functions.
2851 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2852 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2853 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2854 char-code-property-alist.
2855
640c8776 2856 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2857 Vunicode_category_table.
2858
640c8776 2859 * font.c (font_range): Adjust for the change of
c805dec0
KH
2860 Vunicode_category_table.
2861
76b397fb
DN
28622011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2863
2864 * m/iris4d.h: Remove file, move contents ...
2865 * s/irix6-5.h: ... here.
2866
22b4128e
PE
28672011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2868
2869 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2870 * alloc.c (mark_buffer):
2871 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2872 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2873 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2874 This isn't true in general, and it's particularly not true
2875 if Emacs is configured with --with-wide-int.
2876 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2877 New macros, used in the buffer.c change.
2878
869795d6
JD
28792011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2880
2881 * xsettings.c: Use both GConf and GSettings if both are available.
2882 (store_config_changed_event): Add comment.
2883 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2884 (store_tool_bar_style_changed): New functions.
5e617bc2 2885 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2886 (struct xsettings): Move font inside HAVE_XFT.
2887 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2888 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2889 Move inside HAVE_XFT.
640c8776 2890 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2891 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2892 also.
2893 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2894 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2895 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2896 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2897 (parse_settings): Move check for font inside HAVE_XFT.
2898 (read_settings, apply_xft_settings): Add comment.
2899 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2900 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2901 call store_font_name_changed.
2902 (xft_settings_event): Add comment.
2903 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2904 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2905 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2906 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2907 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2908 (xsettings_get_system_font, xsettings_get_system_normal_font):
2909 Add comment.
869795d6 2910
d8ed26bd
PE
29112011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2912
2913 Random fixes. E.g., (random) never returned negative values.
2914 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2915 subseconds part to the entropy, as that's a bit more random.
2916 Prefer signed to unsigned, since the signedness doesn't matter and
2917 in general we prefer signed. When given a limit, use a
2918 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2919 latter isn't right if USE_2_TAGS_FOR_INTS.
2920 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2921 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2922
cabf1cac
SM
29232011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2924
2925 * textprop.c (text_property_stickiness):
2926 Obey Vtext_property_default_nonsticky.
2927 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2928 * w32fns.c (syms_of_w32fns):
2929 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2930
6e9b2be9
PE
29312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2932
2933 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2934 This is more efficient than Ffile_directory_p and avoids a minor race.
2935
90186c68
LMI
29362011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2937
7c301272
LMI
2938 * buffer.c (Foverlay_put): Say what the return value is
2939 (bug#7835).
2940
c4f2d8d4
LMI
2941 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2942 is a directory before asking whether to use the file name
2943 (bug#7564).
ad637907
LMI
2944 (barf_or_query_if_file_exists): Make the "File is a directory"
2945 error be more correct.
c4f2d8d4 2946
90186c68
LMI
2947 * fns.c (Frequire): Remove the mention of the .gz files, since
2948 that's installation-specific, but keep the mention of
2949 `get-load-suffixes'.
2950
da64016e
PE
29512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2952
2953 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2954 Report string overflow if the output is too long.
2955
7d47b580
JB
29562011-07-04 Juanma Barranquero <lekktu@gmail.com>
2957
a555cb87
JB
2958 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2959 (syms_of_gnutls): Remove duplicate DEFSYM for
2960 Qgnutls_bootprop_verify_hostname_error, an error for
2961 Qgnutls_bootprop_verify_error (which is no longer used).
2962
7d47b580
JB
2963 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2964 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2965 Also (re)move comments that are misplaced or no longer relevant.
2966
1e49bfab
LMI
29672011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2968
2969 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2970
1485f4c0
CY
29712011-07-03 Chong Yidong <cyd@stupidchicken.com>
2972
2973 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2974 and background color parameters if they have been changed.
2975
a9ab721e
LMI
29762011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2977
2978 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2979
cf7cff57
PE
29802011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2981
2e13213d
PE
2982 * xsettings.c (SYSTEM_FONT): Define only when used.
2983 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2984
cf7cff57
PE
2985 * keymap.c (access_keymap_1): Now static.
2986
7a8e04f7
CY
29872011-07-02 Chong Yidong <cyd@stupidchicken.com>
2988
2989 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2990 leave any prefix arg for the up event (Bug#1586).
2991
61352f62
LMI
29922011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2993
69bb1ef7
LMI
2994 * lread.c (syms_of_lread): Mention single symbols defined by
2995 `defvar' or `defconst' (bug#7154).
2996
61352f62 2997 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2998 (Frequire): Mention get-load-suffixes.
61352f62 2999
28545e04
MR
30002011-07-02 Martin Rudalics <rudalics@gmx.at>
3001
3002 * window.h (window): Remove clone_number slot.
3003 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3004 Remove.
3005 (make_parent_window, make_window, saved_window)
3006 (Fset_window_configuration, save_window_save): Don't deal with
3007 clone numbers.
3008 * buffer.c (Qclone_number): Remove declaration.
3009 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3010
3349e122
SM
30112011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3012
3013 Add multiple inheritance to keymaps.
3014 * keymap.c (Fmake_composed_keymap): New function.
3015 (Fset_keymap_parent): Simplify.
3016 (fix_submap_inheritance): Remove.
3017 (access_keymap_1): New function extracted from access_keymap to handle
3018 embedded parents and handle lists of maps.
3019 (access_keymap): Use it.
3020 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3021 (Fcopy_keymap): Handle embedded parents.
3022 (Fcommand_remapping, define_as_prefix): Simplify.
3023 (Fkey_binding): Simplify.
3024 (syms_of_keymap): Move minibuffer-local-completion-map,
3025 minibuffer-local-filename-completion-map,
3026 minibuffer-local-must-match-map, and
3027 minibuffer-local-filename-must-match-map to Elisp.
3028 (syms_of_keymap): Defsubr make-composed-keymap.
3029 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3030 (parse_menu_item): Trivial simplification.
3031
3279eb87
GM
30322011-07-01 Glenn Morris <rgm@gnu.org>
3033
3034 * Makefile.in (SETTINGS_LIBS): Fix typo.
3035
4550efdf
KI
30362011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3037
3038 * coding.c (Fencode_coding_string): Record the last coding system
3039 used, as the function doc string says (bug#8738).
3040
0949d2b6
JD
30412011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3042
3043 * xsettings.c (store_monospaced_changed): Take new font as arg and
3044 check for change against current_mono_font.
3045 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3046 (emacs_settings_constructor, emacs_settings_get_property)
3047 (emacs_settings_set_property, emacs_settings_class_init)
3048 (emacs_settings_init, gsettings_obj): Remove.
3049 (something_changedCB): New function for HAVE_GSETTINGS.
3050 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3051 with value as argument.
3052 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3053 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3054 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3055 "changed".
3056
3057 * xgselect.c: Add defined (HAVE_GSETTINGS).
3058 (xgselect_initialize): Ditto.
3059
3060 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3061 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3062 xg_select.
3063
bbc6b304
PE
30642011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3065
3066 * eval.c (struct backtrace): Simplify and port the data structure.
3067 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3068 signed bit field, as this assumption is not portable and it makes
3069 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3070 "char debug_on_exit : 1" as this is not portable either; instead,
3071 use the portable "unsigned int debug_on_exit : 1". Remove unused
3072 member evalargs. Remove obsolete comments about cc bombing out.
3073
9851bfc5
JD
30742011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3075
51bb811f 3076 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3077 Let HAVE_GSETTINGS override HAVE_GCONF.
3078 (store_monospaced_changed): New function.
3079 (EMACS_SETTINGS): A new type derived from GObject to handle
3080 GSettings notifications.
3081 (emacs_settings_constructor, emacs_settings_get_property)
3082 (emacs_settings_set_property, emacs_settings_class_init):
3083 New functions.
3084 (gsettings_client, gsettings_obj): New variables.
3085 (GSETTINGS_SCHEMA): New define.
3086 (something_changedCB): Call store_monospaced_changed.
3087 (init_gsettings): New function.
3088 (xsettings_initialize): Call init_gsettings.
3089 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3090 to NULL.
3091
640c8776 3092 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3093 GCONF_CFLAGS/LIBS.
3094
5386012d
MR
30952011-06-29 Martin Rudalics <rudalics@gmx.at>
3096
3097 * window.c (resize_root_window, grow_mini_window)
3098 (shrink_mini_window): Rename Qresize_root_window to
3099 Qwindow_resize_root_window and Qresize_root_window_vertically to
3100 Qwindow_resize_root_window_vertically.
3101
f13e0b08
PE
31022011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3103
3104 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3105
94515237
JB
31062011-06-27 Juanma Barranquero <lekktu@gmail.com>
3107
3108 * makefile.w32-in: Redesign dependencies so they reflect more
3109 clearly which files are directly included by each source file,
3110 and not through other includes.
3111
e43b6e43
MR
31122011-06-27 Martin Rudalics <rudalics@gmx.at>
3113
3114 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3115 (sort_overlays, overlay_strings): When an overlay's clone number
3116 matches the window's clone number process the overlay even if
3117 the overlay's window property doesn't match the current window.
3118
d68443dc
MR
3119 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3120 (Fwindow_hchild): Rename to Fwindow_left_child.
3121 (Fwindow_next): Rename to Fwindow_next_sibling.
3122 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3123 (resize_window_check): Rename to window_resize_check.
3124 (resize_window_apply): Rename to window_resize_apply.
3125 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3126 (Fdelete_other_windows_internal, resize_frame_windows)
3127 (Fsplit_window_internal, Fdelete_window_internal)
3128 (grow_mini_window, shrink_mini_window)
3129 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3130
c7e73be5
JD
31312011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3132
3133 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3134 (emacs_fixed_set_min_size): Remove.
3135 (emacs_fixed_new): Take frame as argument.
3136
3137 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3138 (_EmacsFixedPrivate): Remove minwidth/height.
3139 Add struct frame *f.
3140 (emacs_fixed_init): Initialize priv->f.
3141 (get_parent_class, emacs_fixed_set_min_size): Remove.
3142 (emacs_fixed_new): Set priv->f to argument.
3143 (emacs_fixed_get_preferred_width)
3144 (emacs_fixed_get_preferred_height): Use min_width/height from
3145 frames size_hint to set minimum and natural (Bug#8919).
3146 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3147 and use min_width/height from frames size_hint to set
3148 min_width/height (Bug#8919).
3149
3150 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3151 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3152 Fix indentation.
c7e73be5 3153
cf99dcf8
EZ
31542011-06-26 Eli Zaretskii <eliz@gnu.org>
3155
3156 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3157 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3158 called at ZV.
3159
029529ac
CY
31602011-06-26 Chong Yidong <cyd@stupidchicken.com>
3161
3162 * process.c (wait_reading_process_output): Bypass select if
3163 waiting for a cell while ignoring keyboard input, and input is
3164 pending. Suggested by Jan Djärv (Bug#8869).
3165
7a7ef429
PE
31662011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3167
3168 Use gnulib's dup2 module instead of rolling our own.
3169 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3170
11fdef7d 31712011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3172
3173 * dispnew.c (scrolling_window): Before scrolling, turn off a
3174 mouse-highlight in the window being scrolled.
3175
cd3520a4
JB
31762011-06-24 Juanma Barranquero <lekktu@gmail.com>
3177
3178 Move DEFSYM to lisp.h and use everywhere.
3179
3180 * character.h (DEFSYM): Move declaration...
3181 * lisp.h (DEFSYM): ...here.
3182
3183 * gnutls.c:
3184 * minibuf.c:
3185 * w32menu.c:
3186 * w32proc.c:
3187 * w32select.c: Don't include character.h.
3188
3189 * alloc.c (syms_of_alloc):
3190 * buffer.c (syms_of_buffer):
3191 * bytecode.c (syms_of_bytecode):
3192 * callint.c (syms_of_callint):
3193 * casefiddle.c (syms_of_casefiddle):
3194 * casetab.c (init_casetab_once):
3195 * category.c (init_category_once, syms_of_category):
3196 * ccl.c (syms_of_ccl):
3197 * cmds.c (syms_of_cmds):
3198 * composite.c (syms_of_composite):
3199 * dbusbind.c (syms_of_dbusbind):
3200 * dired.c (syms_of_dired):
3201 * dispnew.c (syms_of_display):
3202 * doc.c (syms_of_doc):
3203 * editfns.c (syms_of_editfns):
3204 * emacs.c (syms_of_emacs):
3205 * eval.c (syms_of_eval):
3206 * fileio.c (syms_of_fileio):
3207 * fns.c (syms_of_fns):
3208 * frame.c (syms_of_frame):
3209 * fringe.c (syms_of_fringe):
3210 * insdel.c (syms_of_insdel):
3211 * keymap.c (syms_of_keymap):
3212 * lread.c (init_obarray, syms_of_lread):
3213 * macros.c (syms_of_macros):
3214 * msdos.c (syms_of_msdos):
3215 * print.c (syms_of_print):
3216 * process.c (syms_of_process):
3217 * search.c (syms_of_search):
3218 * sound.c (syms_of_sound):
3219 * syntax.c (init_syntax_once, syms_of_syntax):
3220 * terminal.c (syms_of_terminal):
3221 * textprop.c (syms_of_textprop):
3222 * undo.c (syms_of_undo):
3223 * w32.c (globals_of_w32):
3224 * window.c (syms_of_window):
3225 * xdisp.c (syms_of_xdisp):
3226 * xfaces.c (syms_of_xfaces):
3227 * xfns.c (syms_of_xfns):
3228 * xmenu.c (syms_of_xmenu):
3229 * xsettings.c (syms_of_xsettings):
3230 * xterm.c (syms_of_xterm): Use DEFSYM.
3231
4228cf16
TZ
32322011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3233
cd3520a4 3234 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3235
7fcccf1e
PE
32362011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3237
7efb4e0e
PE
3238 Integer and buffer overflow fixes (Bug#8873).
3239
ff5844ad
PE
3240 * print.c (printchar, strout): Check for string overflow.
3241 (PRINTPREPARE, printchar, strout):
3242 Don't set size unless allocation succeeds.
3243
90532f02
PE
3244 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3245 for sizes. Check for string overflow more accurately.
3246 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3247
6d84508d
PE
3248 * macros.c: Integer and buffer overflow fixes.
3249 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3250 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3251 Use ptrdiff_t, not int, for sizes.
3252 Don't increment bufsize until after realloc succeeds.
3253 Check for size-calculation overflow.
3254 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3255
437b2cb4
PE
3256 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3257
8b9ac8b4
PE
3258 * lread.c: Integer overflow fixes.
3259 (read_integer): Radix is now EMACS_INT, not int,
3260 to improve quality of diagnostics for out-of-range radices.
3261 Calculate buffer size correctly for out-of-range radices.
3262 (read1): Check for integer overflow in radices, and in
3263 read-circle numbers.
82cb60d3
PE
3264 (read_escape): Avoid int overflow.
3265 (Fload, openp, read_buffer_size, read1)
3266 (substitute_object_recurse, read_vector, read_list, map_obarray):
3267 Use ptrdiff_t, not int, for sizes.
3268 (read1): Use EMACS_INT, not int, for sizes.
20270765 3269 Check for size overflow.
8b9ac8b4 3270
7fcccf1e
PE
3271 * image.c (cache_image): Check for size arithmetic overflow.
3272
bfbbd7e7
PE
3273 * lread.c: Integer overflow issues.
3274 (saved_doc_string_size, saved_doc_string_length)
3275 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3276 Now ptrdiff_t, not int.
3277 (read1): Don't assume doc string length fits in int. Check for
3278 out-of-range doc string lengths.
3279 (read_list): Don't assume file position fits in int.
39019e54 3280 (read_escape): Check for hex character overflow.
bfbbd7e7 3281
4e323265
LL
32822011-06-22 Leo Liu <sdl.web@gmail.com>
3283
3284 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3285 Move to minibuffer.el.
3286
85fece3e
PE
32872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3288
20b84ce9 3289 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3290 The following patches are for when GLYPH_DEBUG && !XASSERT.
3291 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3292 * dispnew.c (flush_stdout):
3293 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3294 Mark as externally visible.
3295 * dispnew.c (check_window_matrix_pointers): Now static.
3296 * dispnew.c (window_to_frame_vpos):
3297 * xfns.c (unwind_create_frame):
3298 * xterm.c (x_check_font): Remove unused local.
3299 * scroll.c (CHECK_BOUNDS):
3300 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3301 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3302 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3303 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3304 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3305 Now static.
3306 (debug_method_add): Use va_list and vsprintf rather than relying
3307 on undefined behavior with wrong number of arguments.
3308 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3309 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3310 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3311 since we're not interested in debugging glyphs with old libraries.
3312 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3313 GCC 4.6.0's static checking.
3314
0766b489
PE
33152011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3316
31fd4b32
PE
3317 Integer overflow and signedness fixes (Bug#8873).
3318 A few related buffer overrun fixes, too.
3319
b79e8648
PE
3320 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3321
0766b489
PE
3322 * dispextern.h (struct face.stipple):
3323 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3324 (x_bitmap_mask, x_allocate_bitmap_record)
3325 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3326 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3327 (x_create_bitmap_from_xpm_data):
3328 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3329 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3330 (.bitmaps_last):
3331 * xfaces.c (load_pixmap):
3332 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3333 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3334 (.bitmaps_last, struct x_output.icon_bitmap):
3335 Use ptrdiff_t, not int, for bitmap indexes.
3336 (x_allocate_bitmap_record): Check for size overflow.
3337 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3338
b081724f
PE
3339 Use ptrdiff_t, not int, for overlay counts.
3340 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3341 * editfns.c (overlays_around, get_pos_property):
3342 * textprop.c (get_char_property_and_overlay):
3343 * xdisp.c (next_overlay_change, note_mouse_highlight):
3344 * xfaces.c (face_at_buffer_position):
21514da7
PE
3345 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3346 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3347 (Fnext_overlay_change, Fprevious_overlay_change)
3348 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3349 Use ptrdiff_t, not int, for sizes.
21514da7 3350 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3351
3de73e5e
PE
3352 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3353
2606c57b
PE
3354 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3355 (x_session_initialize): Do not assume string length fits in int.
3356
aaafe47a
PE
3357 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3358 This is unlikely, but can occur if DPI is outlandish.
3359
2674ddc8 3360 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3361 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3362
28154962
PE
3363 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3364 * xrdb.c (magic_file_p, search_magic_path):
3365 Omit last arg SUFFIX; it was always 0. All callers changed.
3366 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3367
7de51af5
PE
3368 * xfont.c (xfont_match): Avoid need for strlen.
3369
25ed6cc3
PE
3370 * xfns.c: Don't assume strlen fits in int.
3371 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3372
4eab31dd
PE
3373 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3374 not unsigned long, as we prefer signed integers. All callers changed.
3375 Detect integer overflow in repeat count.
3376 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3377 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3378
171e2a58
PE
3379 * termcap.c: Don't assume sizes fit in int and never overflow.
3380 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3381 (gobble_line): Check for size-calculation overflow.
3382
ad39faca 3383 * minibuf.c (Fread_buffer):
6e5bb2dc 3384 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3385 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3386 Don't assume string length fits in int.
3387
52c61c22 3388 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3389 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3390
b5b8c9e5
PE
3391 * font.c: Don't assume string length fits in int.
3392 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3393 Use ptrdiff_t, not int.
ccd6111c
PE
3394 (font_intern_prop): Don't assume string length fits in int.
3395 Don't assume integer property fits in fixnum.
3396 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3397
882f0d81 3398 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3399 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3400 Reformulate so as not to need the command string.
3401 Invoke gzip -cd rather than gunzip, as it's more portable.
3402 (lock_info_type, lock_file_1, lock_file):
3403 Don't assume pid_t and time_t fit in unsigned long.
3404 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3405 (current_lock_owner): Prefer signed type for sizes.
3406 Use memcpy, not strncpy, where memcpy is what is really wanted.
3407 Don't assume (via atoi) that time_t and pid_t fit in int.
3408 Check for time_t and/or pid_t out of range, e.g., via a network share.
3409 Don't alloca where an auto var works fine.
3410
93f4cf88
PE
3411 * fileio.c: Fix some integer overflow issues.
3412 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3413 Don't assume string length fits in int.
3414 (directory_file_name): Don't assume string length fits in long.
3415 (make_temp_name): Don't assume pid fits in int, or that its print
3416 length is less than 20.
3417
f3e92b69
PE
3418 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3419
1bfdaf10
PE
3420 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3421
35016e9a
PE
3422 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3423
3d1e65a1
PE
3424 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3425 We prefer signed integers, even for size calculations.
3426
0b963a93
PE
3427 * emacs.c: Don't assume string length fits in 'int'.
3428 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3429 (main): Don't invoke strlen when not needed.
3430
573f4b54
PE
3431 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3432 (XD_DEBUG_MESSAGE): Don't waste a byte.
3433
989f33ba
PE
3434 * callproc.c (getenv_internal_1, getenv_internal)
3435 (Fgetenv_internal):
965d34eb
PE
3436 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3437
e4d29b33
PE
3438 * lread.c (invalid_syntax): Omit length argument.
3439 All uses changed. This doesn't fix a bug, but it simplifies the
3440 code away from its former Hollerith-constant appearance, and it's
3441 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3442 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3443
eb49b136
PE
3444 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3445 This didn't break anything, but it didn't help either.
3446 It's confusing to put a bogus integer in a place where the actual
3447 value does not matter.
9f62aeb1 3448 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3449 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3450
15375a22
PE
3451 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3452 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3453 implementation.
b61cc01c
PE
3454 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3455 We prefer signed types, and the value cannot exceed the EMACS_INT
3456 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3457 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3458 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3459 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3460
53b2623d
PE
3461 * indent.c (sane_tab_width): New function.
3462 (current_column, scan_for_column, Findent_to, position_indentation)
3463 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3464 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3465
51cab52b 3466 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3467
f2ed8a70
PE
3468 * lisp.h (lint_assume): New macro.
3469 * composite.c (composition_gstring_put_cache):
3470 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3471
abe80cc6
PE
3472 * editfns.c, insdel.c:
3473 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3474
b02c740e
PE
3475 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3476
ebc96716
PE
3477 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3478
b4e50fa0 3479 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3480 Use much-faster test for byte-length change.
311d5d7c 3481 Don't assume string byte-length fits in 'int'.
a4cf38e4 3482 Check that character arg fits in 'int'.
85461888 3483 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3484
c0c1ee9f
PE
3485 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3486
a498d7f4
PE
3487 * fns.c (concat): Catch string overflow earlier.
3488 Do not rely on integer wraparound.
3489
51cab52b
PE
3490 * dispextern.h (struct it.overlay_strings_charpos)
3491 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3492 * xdisp.c (forward_to_next_line_start)
3493 (back_to_previous_visible_line_start)
3494 (reseat_at_next_visible_line_start, next_element_from_buffer):
3495 Don't arbitrarily truncate the value of 'selective' to int.
3496
76031fad
PE
3497 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3498
5eb55db9
PE
3499 * composite.c: Don't truncate sizes to 'int'.
3500 (composition_gstring_p, composition_reseat_it)
3501 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3502 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3503 not EMACS_UINT, for indexes.
5eb55db9 3504
0703a717
PE
3505 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3506
d6202519
PE
3507 * buffer.c: Include <verify.h>.
3508 (struct sortvec.priority, struct sortstr.priority):
8961a454 3509 Now EMACS_INT, not int.
c20998a7 3510 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3511 (struct sortstr.size, record_overlay_string)
3512 (struct sortstrlist.size, struct sortlist.used):
3513 Don't truncate size to int.
3514 (record_overlay_string): Check for size-calculation overflow.
d6202519 3515 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3516
d5a19415
JM
35172011-06-22 Jim Meyering <meyering@redhat.com>
3518
029529ac 3519 Don't leak an XBM-image-sized buffer
d5a19415
JM
3520 * image.c (xbm_load): Free the image buffer after using it.
3521
a9041e6c
PE
35222011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3523
3524 Port to Sun C.
3525 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3526 that Sun C diagnosed.
3527 * fns.c (secure_hash): Fix pointer signedness issue.
3528 * intervals.c (static_offset_intervals): New function.
3529 (offset_intervals): Use it.
3530
7f3f739f
LL
35312011-06-21 Leo Liu <sdl.web@gmail.com>
3532
3533 * deps.mk (fns.o):
3534 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3535 sha512.h.
3536
3537 * fns.c (secure_hash): Rename from crypto_hash_function and change
3538 the first arg to accept symbols.
5b66d427 3539 (Fsecure_hash): New primitive.
7f3f739f
LL
3540 (syms_of_fns): New symbols.
3541
76147d94
DD
35422011-06-20 Deniz Dogan <deniz@dogan.se>
3543
3544 * process.c (Fset_process_buffer): Clarify return value in
3545 docstring.
3546
7d7d0045
CY
35472011-06-18 Chong Yidong <cyd@stupidchicken.com>
3548
3549 * dispnew.c (add_window_display_history): Use BVAR.
3550
3551 * xdisp.c (debug_method_add): Use BVAR.
3552 (check_window_end, dump_glyph_matrix, dump_glyph)
3553 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3554
3555 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3556 Likewise.
3557
3558 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3559 check till after the cache is created in init_frame_faces.
3560
ff2bc410
SM
35612011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3562
3563 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3564
28177add
PE
35652011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3566
dd3482fe
PE
3567 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3568 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3569 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3570
393d71f3 3571 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3572 * fileio.c (Finsert_file_contents):
3573 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3574 Remove the old (too-loose) buffer overflow checks.
3575 They weren't needed, since make_gap checks for buffer overflow.
3576 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3577 The old code merely checked for Emacs fixnum overflow, and relied
3578 on undefined (wraparound) behavior. The new code avoids undefined
3579 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3580
2e6813b0 3581 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3582 Tune. Don't use wider integers than needed. Don't use alloca.
3583 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3584
599a9e4f
PE
3585 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3586
99561444
PE
3587 * insdel.c, lisp.h (buffer_overflow): New function.
3588 (insert_from_buffer_1, replace_range, replace_range_2):
3589 * insdel.c (make_gap_larger):
3590 * editfns.c (Finsert_char):
3591 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3592
28177add
PE
3593 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3594
e69dafad
PE
35952011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3596
a7af7fde 3597 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3598
b1c46f02
PE
3599 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3600 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3601
e69dafad
PE
3602 * fileio.c: Don't assume EMACS_INT fits in off_t.
3603 (emacs_lseek): New static function.
3604 (Finsert_file_contents, Fwrite_region): Use it.
3605 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3606
566684ea
PE
3607 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3608
e6966cd6
PE
3609 * fns.c: Don't overflow int when computing a list length.
3610 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3611 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3612 truncation on 64-bit hosts. Check for QUIT every
3613 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3614 faster and is responsive enough.
3615 (Flength): Report an error instead of overflowing an integer.
3616 (Fsafe_length): Return a float if the value is not representable
3617 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3618 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3619 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3620
dd0b0efb
PE
3621 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3622 (header_size, word_size): New constants.
3623 (allocate_vectorlike): Don't check size overflow here.
3624 (allocate_vector): Check it here instead, since this is the only
3625 caller of allocate_vectorlike that could cause overflow.
3626 Check that the new vector's length is representable as a fixnum.
3627
86fe5cfe
PE
3628 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3629 The previous code was bogus. For example, next_almost_prime (32)
3630 returned 39, which is undesirable as it is a multiple of 3; and
3631 next_almost_prime (24) returned 25, which is a multiple of 5 so
3632 why was the code bothering to check for multiples of 7?
3633
80e88859
PE
3634 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3635
4a2f0ad6
PE
3636 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3637
f66c7cf8
PE
3638 Variadic C functions now count arguments with ptrdiff_t.
3639 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3640 Back then I didn't know that the Emacs coding style prefers signed int.
3641 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3642 were being counted with int, which may truncate counts on 64-bit
3643 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3644 * lisp.h (struct Lisp_Subr.function.aMANY)
3645 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3646 Arg counts are now ptrdiff_t, not size_t.
3647 All variadic functions and their callers changed accordingly.
3648 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3649 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3650 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3651 * callint.c (Fcall_interactively): Check arg count for overflow,
3652 to avoid potential buffer overrun. Use signed char, not 'int',
3653 for 'varies' array, so that we needn't bother to check its size
3654 calculation for overflow.
3655 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3656 * eval.c (apply_lambda):
3657 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3658 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3659 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3660
a1759b76
PE
3661 * callint.c (Fcall_interactively): Don't use index var as event count.
3662
d96be9fc
PE
3663 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3664 * mem-limits.h (SIZE): Remove; no longer used.
3665
a690a978 3666 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3667
578c21e6
PE
3668 Remove unnecessary casts.
3669 * xterm.c (x_term_init):
3670 * xfns.c (x_set_border_pixel):
3671 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3672 These aren't needed now that we assume ANSI C.
3673
96f53c6c
PE
3674 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3675 It's more likely to cause problems (due to unsigned overflow)
3676 than to cure them.
3677
83c77d31
PE
3678 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3679
ee2079f1
PE
3680 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3681
6da65536
PE
3682 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3683
7147c4a4
PE
3684 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3685
193e32d9
PE
3686 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3687
e5533da6
PE
3688 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3689
9910e595
PE
3690 GLYPH_CODE_FACE returns EMACS_INT, not int.
3691 * dispextern.h (merge_faces):
3692 * xfaces.c (merge_faces):
01103c44
PE
3693 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3694 Don't assume EMACS_INT fits in int.
9910e595 3695
2638320e
PE
3696 * character.h (CHAR_VALID_P): Remove unused parameter.
3697 * fontset.c, lisp.h, xdisp.c: All uses changed.
3698
045eb8d9
PE
3699 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3700
c1f134b5
PE
3701 * fns.c (concat): Minor tuning based on overflow analysis.
3702 This doesn't fix any bugs. Use int to hold character, instead
3703 of constantly refetching from Emacs object. Use XFASTINT, not
3704 XINT, for value known to be a character. Don't bother comparing
3705 a single byte to 0400, as it's always less.
3706
395fcb93 3707 * floatfns.c (Fexpt):
327eeec8
PE
3708 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3709
abbd3d23
PE
3710 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3711 for characters.
3712
684a03ef
PE
3713 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3714
0fed43f3
PE
3715 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3716 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3717 incorrectly succeed when S was a string, because 4294967386 was
3718 truncated before it was used.
3719
8fd02eb7
PE
3720 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3721 Otherwise, an out-of-range integer could cause undefined behavior
3722 on a 64-bit host.
3723
f8c86b69
PE
3724 * composite.c: Use int, not EMACS_INT, for characters.
3725 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3726 EMACS_INT, for values that are known to be in character range.
3727 This doesn't fix any bugs but is the usual style inside Emacs and
3728 may generate better code on 32-bit machines.
3729
34206dd2
PE
3730 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3731 This is for reasons similar to the recent CHAR_STRING fix.
3732 * charset.c (Fencode_char): Check that character arg is actually
3733 a character. Pass an int to ENCODE_CHAR.
3734 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3735 wider than 'int', as a compile-time check to prevent future regressions
3736 in this area.
3737
c5958d4c 3738 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3739
3740 Make sure a 64-bit char is never passed to CHAR_STRING.
3741 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3742 by silently ignoring the top 32 bits, allowing some values
3743 that were far too large to be valid characters.
3744 * character.h: Include <verify.h>.
3745 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3746 arguments are no wider than unsigned, as a compile-time check
3747 to prevent future regressions in this area.
3748 * data.c (Faset):
01103c44 3749 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3750 (Fsubst_char_in_region):
3751 * fns.c (concat):
3752 * xdisp.c (decode_mode_spec_coding):
3753 Adjust to CHAR_STRING's new requirement.
3754 * editfns.c (Finsert_char, Fsubst_char_in_region):
3755 * fns.c (concat): Check that character args are actually
3756 characters. Without this test, these functions did the wrong
3757 thing with wildly out-of-range values on 64-bit hosts.
3758
d37ca623
PE
3759 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3760 These casts should not be needed on 32-bit hosts, either.
3761 * keyboard.c (read_char):
3762 * lread.c (Fload): Remove casts to unsigned.
3763
ea204efb
PE
3764 * lisp.h (UNSIGNED_CMP): New macro.
3765 This fixes comparison bugs on 64-bit hosts.
3766 (ASCII_CHAR_P): Use it.
3767 * casefiddle.c (casify_object):
01103c44 3768 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3769 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3770 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3771 * dispextern.h (FACE_FROM_ID):
3772 * keyboard.c (read_char): Use UNSIGNED_CMP.
3773
41cb286c
PE
3774 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3775 not to EMACS_INT, to avoid GCC warning.
3776
4a1b9832
PE
3777 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3778
55daad71
PE
3779 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3780 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3781 isn't needed on 32-bit machines.
8f95c75c 3782
01103c44
PE
3783 * buffer.c (Fgenerate_new_buffer_name):
3784 Use EMACS_INT for count, not int.
0ceccced 3785 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3786
3787 * data.c (Qcompiled_function): Now static.
3788
c6f072e7
PE
3789 * window.c (window_body_lines): Now static.
3790
20ce5912
PE
3791 * image.c (gif_load): Rename local to avoid shadowing.
3792
9c4c5f81
PE
3793 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3794 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3795 * alloc.c (make_save_value): Integer argument is now of type
3796 ptrdiff_t, not int.
3797 (mark_object): Use ptrdiff_t, not int.
3798 * lisp.h (pD): New macro.
3799 * print.c (print_object): Use it.
3800
c0c5c8ae
PE
3801 * alloc.c: Use EMACS_INT, not int, to count objects.
3802 (total_conses, total_markers, total_symbols, total_vector_size)
3803 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3804 (total_free_floats, total_floats, total_free_intervals)
3805 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3806 Now EMACS_INT, not int. All uses changed.
3807 (Fgarbage_collect): Compute overall total using a double, so that
3808 integer overflow is less likely to be a problem. Check for overflow
3809 when converting back to an integer.
5a25e253
PE
3810 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3811 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3812 These were 'int' variables that could overflow on 64-bit hosts;
3813 they were never used, so remove them instead of repairing them.
211a0b2a 3814 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3815 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3816 Previously, this ceilinged at INT_MAX, but that doesn't work on
3817 64-bit machines.
e46bb31a 3818 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3819
c78baabf 3820 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3821 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3822 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3823 when a (possibly-narrower) signed value would do just as well.
3824 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3825
c9d624c6
PE
3826 * alloc.c: Catch some string size overflows that we were missing.
3827 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3828 for convenience in STRING_BYTES_MAX.
3829 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3830 The definition here is exact; the one in lisp.h was approximate.
3831 (allocate_string_data): Check for string overflow. This catches
3832 some instances we weren't catching before. Also, it catches
3833 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3834 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3835 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3836
c9d624c6
PE
3837 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3838 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3839 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3840
353032ce
PE
3841 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3842
2bccce07
PE
3843 * alloc.c (Fmake_string): Check for out-of-range init.
3844
0ac30604
SM
38452011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3846
3847 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3848
c195f2de
JD
38492011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3850
3851 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3852 xg_get_default_scrollbar_width.
3853
3854 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3855 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3856 (style_changed_cb): Call update_theme_scrollbar_width and call
3857 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3858 all frames (Bug#8505).
3859 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3860 Call gtk_window_set_resizable if HAVE_GTK3.
3861 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3862 and height if HAVE_GTK3 (Bug#8505).
3863 (scroll_bar_width_for_theme): New variable.
3864 (update_theme_scrollbar_width): New function.
3865 (xg_get_default_scrollbar_width): Move code to
3866 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3867 (xg_initialize): Call update_theme_scrollbar_width.
3868
3869 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3870
3871 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3872
e10ac9f1
MR
38732011-06-12 Martin Rudalics <rudalics@gmx.at>
3874
3875 * frame.c (make_frame): Call other_buffer_safely instead of
3876 other_buffer.
3877
3878 * window.c (temp_output_buffer_show): Call display_buffer with
3879 second argument Vtemp_buffer_show_specifiers and reset latter
3880 immediately after the call.
3881 (Vtemp_buffer_show_specifiers): New variable.
3882 (auto_window_vscroll_p, next_screen_context_lines)
3883 (Vscroll_preserve_screen_position): Remove leading asterisks from
3884 doc-strings.
3885
2d3c217e 38862011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3887
7b7f97e8 3888 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3889 * buffer.c (Qclone_number): Remove for now, as it's unused.
3890 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3891 (record_buffer): Remove unused local.
3892 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3893 (set_frame_buffer_list): Remove; unused.
3894 * frame.h (other_visible_frames): Remove decl.
3895 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3896 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3897 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3898 if HAVE_GPM.
3899 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3900 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3901 Define only if HAVE_GPM.
3902 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3903 (update_hints_inhibit): Remove; never set. All uses removed.
3904 * widgetprv.h (emacsFrameClassRec): Remove decl.
3905 * window.c (delete_deletable_window): Now returns void, since it
3906 wasn't returning anything.
3907 (compare_window_configurations): Remove unused locals.
3908 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3909 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3910 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3911 the same widths as pointers. This follows up on the 2011-05-06 patch.
3912 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3913 * xterm.h: Likewise.
3914 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3915
1384b89e
JB
39162011-06-12 Juanma Barranquero <lekktu@gmail.com>
3917
3918 * makefile.w32-in: Update dependencies.
3919 (LISP_H): Add lib/intprops.h.
3920
1100a63c
CY
39212011-06-11 Chong Yidong <cyd@stupidchicken.com>
3922
3923 * image.c (gif_load): Add animation frame delay to the metadata.
3924 (syms_of_image): Use DEFSYM. New symbol `delay'.
3925
6198ccd0
MR
39262011-06-11 Martin Rudalics <rudalics@gmx.at>
3927
3928 * window.c (delete_deletable_window): Re-add.
3929 (Fset_window_configuration): Rewrite to handle dead buffers and
3930 consequently deletable windows.
3931 (window_tree, Fwindow_tree): Remove. Supply functionality in
3932 window.el.
3933 (compare_window_configurations): Simplify code.
3934
b6e3633c
AS
39352011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3936
1ab0dee5
AS
3937 * image.c (imagemagick_load_image): Fix type mismatch.
3938 (Fimagemagick_types): Likewise.
3939
b6e3633c
AS
3940 * window.h (replace_buffer_in_windows): Declare.
3941
9397e56f
MR
39422011-06-11 Martin Rudalics <rudalics@gmx.at>
3943
3944 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3945 Qclone_number. Remove external declaration of Qdelete_window.
3946 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3947 code.
640c8776
SM
3948 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3949 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3950 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3951 buffer list implementation.
3952 (other_buffer_safely): New function.
3953 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3954 calls to replace_buffer_in_windows and
3955 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3956 if allowed.
3957 (record_buffer): Inhibit quitting and rewrite using quittable
3958 functions. Run Qbuffer_list_update_hook if allowed.
3959 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3960 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3961 Move switch-to-buffer to window.el.
9397e56f
MR
3962 (bury-buffer): Move to window.el.
3963 (Vbuffer_list_update_hook): New variable.
3964
3965 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3966 section.
3967
3968 * window.h (resize_frame_windows): Move up in code.
3969 (Fwindow_frame): Remove EXFUN.
3970 (replace_buffer_in_all_windows): Remove prototype.
3971 (replace_buffer_in_windows_safely): Add prototype.
3972
3973 * window.c: Declare Qdelete_window static again. Move down
3974 declaration of select_count.
3975 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3976 (Fother_window): Move to window.el.
3977 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3978 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3979 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3980 window.el.
3981 (replace_buffer_in_windows): Implement by calling
3982 Qreplace_buffer_in_windows.
3983 (replace_buffer_in_all_windows): Remove with some functionality
3984 moved into replace_buffer_in_windows_safely.
3985 (replace_buffer_in_windows_safely): New function.
3986 (select_window_norecord, select_frame_norecord): Move in front
3987 of run_window_configuration_change_hook. Remove now obsolete
3988 declarations.
640c8776
SM
3989 (Fset_window_buffer): Rewrite doc-string.
3990 Call Qrecord_window_buffer.
9397e56f
MR
3991 (keys_of_window): Move binding for other-window to window.el.
3992
b50691aa
CY
39932011-06-11 Chong Yidong <cyd@stupidchicken.com>
3994
3995 * dispextern.h (struct image): Replace data member, whose int_val
3996 and ptr_val fields were not used by anything, with a single
3997 lisp_val object.
3998
3999 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4000 (gif_clear_image, gif_load, imagemagick_load_image)
4001 (gs_clear_image, gs_load): Callers changed.
4002
3f754b86
PE
40032011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4004
cca69397
PE
4005 * buffer.h: Include <time.h>, for time_t.
4006 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4007
109e28d0
PE
4008 Fix minor problems found by static checking.
4009
60737f02
PE
4010 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4011
4b66faf3
PE
4012 Make identifiers static if they are not used in other modules.
4013 * data.c (Qcompiled_function, Qframe, Qvector):
4014 * image.c (QimageMagick, Qsvg):
4015 * minibuf.c (Qmetadata):
4016 * window.c (resize_window_check, resize_root_window): Now static.
4017 * window.h (resize_window_check, resize_root_window): Remove decls.
4018
109e28d0
PE
4019 * window.c (window_deletion_count, delete_deletable_window):
4020 Remove; unused.
46a4ce9e
PE
4021 (window_body_lines): Now static.
4022 (Fdelete_other_windows_internal): Mark vars as initialized.
4023 Make sure 'resize_failed' is initialized.
4024 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4025 (resize_window_apply): Remove unused local.
4026 * window.h (delete_deletable_window): Remove decl.
4027
109e28d0 4028 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4029 (imagemagick_load_image): Fix pointer signedness problem by changing
4030 last arg from unsigned char * to char *. All uses changed.
4031 Also, fix a local for similar reasons.
4032 Remove unused locals. Remove locals to avoid shadowing.
4033 (fn_rsvg_handle_free): Remove; unused.
4034 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4035 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4036
3f754b86
PE
4037 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4038
2547adb1
CY
40392011-06-10 Chong Yidong <cyd@stupidchicken.com>
4040
4041 * image.c (gif_load): Fix omitted cast error introduced by
4042 2011-06-06 change.
4043
2c8e37d4
MR
40442011-06-10 Martin Rudalics <rudalics@gmx.at>
4045
4046 * window.h (resize_proportionally, orig_total_lines)
4047 (orig_top_line): Remove from window structure.
4048 (set_window_height, set_window_width, change_window_heights)
4049 (Fdelete_window): Remove prototypes.
4050 (resize_frame_windows): Remove duplicate declaration.
4051
440a42e3
EZ
40522011-06-10 Eli Zaretskii <eliz@gnu.org>
4053
4054 * window.h (resize_frame_windows, resize_window_check)
4055 (delete_deletable_window, resize_root_window)
4056 (resize_frame_windows): Declare prototypes.
4057
4058 * window.c (resize_window_apply): Make definition be "static" to
4059 match the prototype.
4060
562dd5e9
MR
40612011-06-10 Martin Rudalics <rudalics@gmx.at>
4062
4063 * window.c: Remove declarations of Qwindow_size_fixed,
4064 window_min_size_1, window_min_size_2, window_min_size,
4065 size_window, window_fixed_size_p, enlarge_window, delete_window.
4066 Remove static from declaration of Qdelete_window, it's
4067 temporarily needed by Fbury_buffer.
4068 (replace_window): Don't assign orig_top_line and
4069 orig_total_lines.
4070 (Fdelete_window, delete_window): Remove. Window deletion is
4071 handled by window.el.
640c8776
SM
4072 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4073 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4074 (Fdelete_other_windows): Remove. Deleting other windows is
4075 handled by window.el.
4076 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4077 handled in window.el.
4078 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4079 Window minimum sizes are handled in window.el.
4080 (shrink_windows, size_window, set_window_height)
4081 (set_window_width, change_window_heights, window_height)
4082 (window_width, CURBEG, CURSIZE, enlarge_window)
4083 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4084 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4085 handled in window.el.
4086 (make_dummy_parent): Rename to make_parent_window and give it a
4087 second argument horflag.
4088 (make_window): Don't set resize_proportionally any more.
4089 (Fsplit_window): Remove. Windows are split in window.el.
4090 (save_restore_action, save_restore_orig_size)
4091 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4092 Resize mini windows in window.el.
4093 (grow_mini_window, shrink_mini_window): Implement by calling
4094 Qresize_root_window_vertically, resize_window_check and
4095 resize_window_apply.
640c8776
SM
4096 (saved_window, Fset_window_configuration, save_window_save):
4097 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4098 resize_proportionally.
4099 (window_min_height, window_min_width): Move to window.el.
4100 (keys_of_window): Move bindings for delete-other-windows,
4101 split-window, delete-window and enlarge-window to window.el.
4102
4103 * buffer.c: Temporarily extern Qdelete_window.
4104 (Fbury_buffer): Temporarily call Qdelete_window instead of
4105 Fdelete_window (Fbury_buffer will move to window.el soon).
4106
4107 * frame.c (set_menu_bar_lines_1): Remove code handling
4108 orig_top_line and orig_total_lines.
4109
4110 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4111 set_window_height but set heights directly.
4112 (change_frame_size_1): Use resize_frame_windows.
4113
4114 * xdisp.c (init_xdisp): Don't use set_window_height but set
4115 heights directly.
4116
640c8776
SM
4117 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4118 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4119 run_window_configuration_change_hook.
4120
4121 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4122 instead of change_window_heights and run
4123 run_window_configuration_change_hook.
4124
1a13852e
MR
41252011-06-09 Martin Rudalics <rudalics@gmx.at>
4126
4127 * window.c (replace_window): Rename second argument REPLACEMENT to
4128 NEW. New third argument SETFLAG. Rewrite.
4129 (delete_window, make_dummy_parent): Call replace_window with
4130 third argument 1.
4131 (window_list_1): Move down in code.
4132 (run_window_configuration_change_hook): Move set_buffer part
4133 before select_frame_norecord part in order to unwind correctly.
4134 Rename count1 to count.
4135 (recombine_windows, delete_deletable_window, resize_root_window)
4136 (Fdelete_other_windows_internal)
4137 (Frun_window_configuration_change_hook, make_parent_window)
4138 (resize_window_check, resize_window_apply, Fresize_window_apply)
4139 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4140 (Fdelete_window_internal, Fresize_mini_window_internal):
4141 New functions.
1a13852e
MR
4142 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4143
f3d1777e
MR
41442011-06-08 Martin Rudalics <rudalics@gmx.at>
4145
496e208e
MR
4146 * window.h (window): Add some new members to window structure -
4147 normal_lines, normal_cols, new_total, new_normal, clone_number,
4148 splits, nest, prev_buffers, next_buffers.
4149 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4150 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4151
f3d1777e
MR
4152 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4153 Remove.
496e208e
MR
4154 (make_dummy_parent): Set new members of windows structure.
4155 (make_window): Move down in code. Handle new members of window
4156 structure.
4157 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4158 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4159 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4160 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4161 (Fset_window_next_buffers, Fset_window_clone_number):
4162 New functions.
496e208e
MR
4163 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4164 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4165 Doc-string fixes.
4166 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4167 Argument WINDOW can be now internal window too.
4168 (Fwindow_use_time): Move up in code.
4169 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4170 Rewrite doc-string.
4171 (Fset_window_configuration, saved_window)
4172 (Fcurrent_window_configuration, save_window_save): Handle new
4173 members of window structure.
b9e809c2
MR
4174 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4175 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4176 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4177 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4178 Qget_mru_window, Qresize_root_window,
4179 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4180 Qauto_buffer_name; staticpro them.
f3d1777e 4181
abde8f8c
MR
41822011-06-07 Martin Rudalics <rudalics@gmx.at>
4183
4184 * window.c (Fwindow_total_size, Fwindow_left_column)
4185 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4186 (Fwindow_list_1): New functions.
4187 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4188 (Fwindow_width, Fscroll_left, Fscroll_right):
4189 Use window_body_cols instead of window_box_text_cols.
4190 (delete_window, Fset_window_configuration):
4191 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4192 (delete_all_subwindows): Take a window as argument and not a
4193 structure. Rewrite.
190b47e6
MR
4194 (window_loop): Remove handling of GET_LRU_WINDOW and
4195 GET_LARGEST_WINDOW.
4196 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4197
4198 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4199 window_box_text_cols. delete_all_subwindows now takes a
4200 Lisp_Object as argument.
abde8f8c 4201
640c8776
SM
4202 * indent.c (compute_motion, Fcompute_motion):
4203 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4204
fa8a67e6
MR
4205 * frame.c (delete_frame): Call delete_all_subwindows with root
4206 window as argument.
4207
a54e3482
DC
42082011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4209
4210 * fns.c (Fputhash): Document return value.
4211
60002bf5
CY
42122011-06-06 Chong Yidong <cyd@stupidchicken.com>
4213
4214 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4215
0c671da6 42162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4217
b862a52a 4218 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4219
be44ca6c
PE
4220 Check for overflow when converting integer to cons and back.
4221 * charset.c (Fdefine_charset_internal, Fdecode_char):
4222 Use cons_to_unsigned to catch overflow.
4223 (Fencode_char): Use INTEGER_TO_CONS.
4224 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4225 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4226 * data.c (long_to_cons, cons_to_long): Remove.
4227 (cons_to_unsigned, cons_to_signed): New functions.
4228 These signal an error for invalid or out-of-range values.
4229 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4230 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4231 * font.c (Ffont_variation_glyphs):
4232 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4233 * lisp.h: Include <intprops.h>.
4234 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4235 (cons_to_signed, cons_to_unsigned): New decls.
4236 (long_to_cons, cons_to_long): Remove decls.
4237 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4238 (Fprimitive_undo): Use CONS_TO_INTEGER.
4239 * xfns.c (Fx_window_property): Likewise.
4240 * xselect.c: Include <limits.h>.
4241 (x_own_selection, selection_data_to_lisp_data):
4242 Use INTEGER_TO_CONS.
4243 (x_handle_selection_request, x_handle_selection_clear)
4244 (x_get_foreign_selection, Fx_disown_selection_internal)
4245 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4246 (lisp_data_to_selection_data): Use cons_to_unsigned.
4247 (x_fill_property_data): Use cons_to_signed.
4248 Report values out of range.
4249
d1f3d2af
PE
4250 Check for buffer and string overflow more precisely.
4251 * buffer.h (BUF_BYTES_MAX): New macro.
4252 * lisp.h (STRING_BYTES_MAX): New macro.
4253 * alloc.c (Fmake_string):
4254 * character.c (string_escape_byte8):
4255 * coding.c (coding_alloc_by_realloc):
4256 * doprnt.c (doprnt):
4257 * editfns.c (Fformat):
4258 * eval.c (verror):
4259 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4260 since they may not be the same number.
4261 * editfns.c (Finsert_char):
4262 * fileio.c (Finsert_file_contents):
4263 Likewise for BUF_BYTES_MAX.
4264
dd52fcea
PE
4265 * image.c: Use ptrdiff_t, not int, for sizes.
4266 (slurp_file): Switch from int to ptrdiff_t.
4267 All uses changed.
4268 (slurp_file): Check that file size fits in both size_t (for
4269 malloc) and ptrdiff_t (for sanity and safety).
4270
7f9bbdbb
PE
4271 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4272 if b->modtime has its maximal value.
4273
dfe18f82
PE
4274 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4275
84acfcf0
PE
4276 Don't assume time_t can fit into int.
4277 * buffer.h (struct buffer.modtime): Now time_t, not int.
4278 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4279 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4280
ccd9a01a
PE
4281 Minor fixes for signed vs unsigned integers.
4282 * character.h (MAYBE_UNIFY_CHAR):
4283 * charset.c (maybe_unify_char):
4284 * keyboard.c (read_char, reorder_modifiers):
4285 XINT -> XFASTINT, since the integer must be nonnegative.
4286 * ftfont.c (ftfont_spec_pattern):
4287 * keymap.c (access_keymap, silly_event_symbol_error):
4288 XUINT -> XFASTINT, since the integer must be nonnegative.
4289 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4290 since it makes no difference and we prefer signed.
4291 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4292 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4293 nonnegative.
4294
d6d100dd
SM
42952011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4296
4297 * window.h (Fwindow_frame): Declare.
4298
2b6148e4
PE
42992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4300
4301 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4302 (SPARE_MEMORY): Always define.
4303 (LARGE_REQUEST): Remove.
4304 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4305
f230ecc9
MR
43062011-06-06 Martin Rudalics <rudalics@gmx.at>
4307
727e958e
MR
4308 * lisp.h: Move EXFUNS for Fframe_root_window,
4309 Fframe_first_window and Fset_frame_selected_window to window.h.
4310
4311 * window.h: Move EXFUNS for Fframe_root_window,
4312 Fframe_first_window and Fset_frame_selected_window here from
4313 lisp.h.
4314
4315 * frame.c (Fwindow_frame, Fframe_first_window)
4316 (Fframe_root_window, Fframe_selected_window)
4317 (Fset_frame_selected_window): Move to window.c.
4318 (Factive_minibuffer_window): Move to minibuf.c.
4319 (Fother_visible_frames_p): New function.
4320
4321 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4322
f230ecc9
MR
4323 * window.c (decode_window, decode_any_window): Move up in code.
4324 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4325 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4326 (Fwindow_buffer): Move up and rewrite doc-string.
4327 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4328 (Fwindow_prev): New functions.
727e958e
MR
4329 (Fwindow_frame): Move here from frame.c. Accept any window as
4330 argument.
4331 (Fframe_root_window, Fframe_first_window)
4332 (Fframe_selected_window): Move here from frame.c. Accept frame
4333 or arbitrary window as argument. Update doc-strings.
4334 (Fminibuffer_window): Move up in code.
4335 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4336 (Fset_frame_selected_window): Move here from frame.c.
4337 Marginal rewrite.
727e958e
MR
4338 (Fselected_window, select_window, Fselect_window): Move up in
4339 code. Minor doc-string fixes.
f230ecc9 4340
4d09bcf6
PE
43412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4342
4343 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4344 Do not assume that spare memory exists; that assumption is valid
4345 only if SYSTEM_MALLOC.
4346 (LARGE_REQUEST): New macro, so that the issue of large requests
4347 is separated from the issue of spare memory.
4348
810928a2
AS
43492011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4350
172418ad
AS
4351 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4352 format. (Bug#8806)
4353
43f862f7
AS
4354 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4355
810928a2
AS
4356 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4357 before statements.
4358
a059fe24
JD
43592011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4360
4361 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4362
4363 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4364
4365 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4366 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4367
989bf368
JB
43682011-06-05 Juanma Barranquero <lekktu@gmail.com>
4369
4370 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4371
4b80f674
CY
43722011-06-04 Chong Yidong <cyd@stupidchicken.com>
4373
4374 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4375 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4376 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4377 New error handlers.
4b80f674
CY
4378 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4379 Obey Vx_select_enable_clipboard_manager. Catch errors in
4380 x_clipboard_manager_save (Bug#8779).
4381 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4382 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4383
99a33b77 43842011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4385
4386 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4387
99a33b77 43882011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4389
4390 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4391 in the current matrix if keep_current_p is non-zero.
4392
8264569d
EZ
43932011-06-04 Eli Zaretskii <eliz@gnu.org>
4394
4395 * bidi.c (bidi_level_of_next_char): Fix last change.
4396
57f97249
EZ
43972011-06-03 Eli Zaretskii <eliz@gnu.org>
4398
fec2107c 4399 Support bidi reordering of text covered by display properties.
57f97249 4400
fec2107c
EZ
4401 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4402 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4403 (bidi_cache_search, bidi_cache_iterator_state)
4404 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4405 (bidi_level_of_next_char, bidi_move_to_visually_next):
4406 Support character positions inside a run of characters covered by a
fec2107c
EZ
4407 display string.
4408 (bidi_paragraph_init, bidi_resolve_explicit_1)
4409 (bidi_level_of_next_char): Call bidi_fetch_char and
4410 bidi_fetch_char_advance instead of FETCH_CHAR and
4411 FETCH_CHAR_ADVANCE.
4412 (bidi_init_it): Initialize new members.
4413 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4414 definitions.
4415 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4416 instead of using explicit *_CHAR codes.
d6d100dd
SM
4417 (bidi_resolve_explicit, bidi_resolve_weak):
4418 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4419 bidirectional text is supported only in multibyte buffers.
4420 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4421 it to initialize the frame_window_p member of struct bidi_it.
4422 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4423 (bidi_resolve_explicit, bidi_resolve_weak)
4424 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4425 bidi_it->nchars is non-positive.
4426 (bidi_level_of_next_char): Don't try to lookup the cache for the
4427 next/previous character if nothing is cached there yet, or if we
4428 were just reseat()'ed to a new position.
c40e2fb2 4429
0e14fe90
EZ
4430 * xdisp.c (set_cursor_from_row): Set start and stop points
4431 according to the row's direction when priming the loop that looks
4432 for the glyph on which to display cursor.
4433 (single_display_spec_intangible_p): Function deleted.
4434 (display_prop_intangible_p): Reimplement to call
4435 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4436 Accept 3 additional arguments needed by handle_display_spec.
4437 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4438 values: lists, `(when COND...)' forms, etc.
4439 (single_display_spec_string_p): Support property values that are
4440 lists with the argument STRING its top-level element.
4441 (display_prop_string_p): Fix the condition for processing a
4442 property that is a list to be consistent with handle_display_spec.
fec2107c 4443 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4444 last portion of handle_display_prop.
4445 (compute_display_string_pos): Accept additional argument
4446 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4447 value of a `display' property is a "replacing spec".
4448 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4449 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4450 the display property, but just return a value indicating whether
4451 the display property will replace the characters it covers.
4452 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4453 frame_window_p members of struct bidi_it.
d6d100dd
SM
4454 (compute_display_string_pos, compute_display_string_end):
4455 New functions.
fec2107c
EZ
4456 (push_it): Accept second argument POSITION, where pop_it should
4457 jump to continue iteration.
4458 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4459
fec2107c
EZ
4460 * keyboard.c (adjust_point_for_property): Adjust the call to
4461 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4462
4463 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4464 (bidi_init_it): Update prototypes.
4465 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4466 (compute_display_string_pos, compute_display_string_end):
4467 Declare prototypes.
fec2107c
EZ
4468 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4469 EMACS_INT.
fc6f18ce 4470
40087514 44712011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4472
57f53182
PE
4473 Malloc failure behavior now depends on size of allocation.
4474 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4475 * lisp.h: Change signatures accordingly.
4476 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4477 All callers changed. (Bug#8762)
4478
4479 * gnutls.c: Use Emacs's memory allocators.
4480 Without this change, the gnutls library would invoke malloc etc.
4481 directly, which causes problems on non-SYNC_INPUT hosts, and which
4482 runs afoul of improving memory_full behavior. (Bug#8761)
4483 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4484 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4485 xfree instead of the default malloc, realloc, free.
4486 (Fgnutls_boot): No need to check for memory allocation failure,
4487 since xmalloc does that for us.
4488
ac32cd99 4489 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4490 * category.c (hash_get_category_set):
4491 * ccl.c (ccl_driver):
4492 * charset.c (Fdefine_charset_internal):
4493 * charset.h (struct charset.hash_index):
4494 * composite.c (get_composition_id, gstring_lookup_cache)
4495 (composition_gstring_put_cache):
4496 * composite.h (struct composition.hash_index):
4497 * dispextern.h (struct image.hash):
4498 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4499 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4500 (hashfn_equal, hashfn_user_defined, make_hash_table)
4501 (maybe_resize_hash_table, hash_lookup, hash_put)
4502 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4503 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4504 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4505 * image.c (make_image, search_image_cache, lookup_image)
4506 (xpm_put_color_table_h):
4507 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4508 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4509 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4510 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4511 * alloc.c (allocate_vectorlike):
4512 Check for overflow in vector size calculations.
4513 * ccl.c (ccl_driver):
4514 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4515 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4516 need to be updated by these changes.
40087514
PE
4517 * fns.c (make_hash_table, maybe_resize_hash_table):
4518 Check for integer overflow with large hash tables.
0de4bb68
PE
4519 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4520 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4521 (SXHASH_REDUCE): New macro.
4522 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4523 Use it instead of discarding useful hash info with large hash values.
4524 (sxhash_float): New function.
4525 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4526 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4527 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4528 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4529 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4530 Adjust signatures to match updated version of code.
4531 (consing_since_gc): Now EMACS_INT, since a single hash table can
4532 use more than INT_MAX bytes.
4533
698d32e2
DN
45342011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4535
4536 Make it possible to build with GCC-4.6+ -O2 -flto.
4537
4538 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4539
fd6fa53f
SM
45402011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4541
4542 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4543 Call minibuffer-inactive-mode.
4544
864db017
JB
45452011-05-31 Juanma Barranquero <lekktu@gmail.com>
4546
4547 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4548 Update dependencies.
4549
2ad0baf4
DN
45502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4551
4552 * data.c (init_data): Remove code for UTS, this system is not
4553 supported anymore.
4554
4fcc2638
DN
45552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4556
4557 Don't force ./temacs to start in terminal mode.
4558
4559 * frame.c (make_initial_frame): Initialize faces in all cases, not
4560 only when CANNOT_DUMP is defined.
4561 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4562
c56e0fd5
DN
45632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4564
4565 * dispnew.c (add_window_display_history): Use const for the string
4566 pointer. Remove declaration, not needed.
4567
333d54da 45682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4569
55d4c1b2 4570 Use 'inline', not 'INLINE'.
333d54da 4571 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4572 * alloc.c, fontset.c (INLINE): Remove.
4573 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4574 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4575 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4576 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4577 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4578
738db178
DN
45792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4580
4581 Make it possible to run ./temacs.
4582
4583 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4584 syms_of_callproc does the same thing. Remove test for
4585 "initialized", do it in the caller.
4586 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4587
620c53a6
SM
45882011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4589
4590 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4591 (read_minibuf): Use get_minibuffer.
4592 (syms_of_minibuf): Use DEFSYM.
4593 (Qmetadata): New var.
4594 * data.c (Qbuffer): Don't make it static.
4595 (syms_of_data): Use DEFSYM.
4596
e003a292
PE
45972011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4598
4599 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4600 (CCL_CODE_MIN): New macro.
4601
ed008a6d
PE
46022011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4603
3687c2ef
PE
4604 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4605
ed008a6d
PE
4606 * eval.c (Qdebug): Now static.
4607 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4608 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4609 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4610
d66c4c7c
CY
46112011-05-29 Chong Yidong <cyd@stupidchicken.com>
4612
4613 * image.c: Various fixes to ImageMagick code comments.
4614 (Fimagemagick_types): Doc fix.
4615
5fbc2025
PE
46162011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4617
0196f88a
PE
4618 Minor fixes prompted by GCC 4.6.0 warnings.
4619
4620 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4621
5fbc2025
PE
4622 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4623 (x_clipboard_manager_save_all): Move extern decl to ...
4624 * xterm.h: ... here, so that it can be checked for consistency.
4625
1dd3c2d9
CY
46262011-05-29 Chong Yidong <cyd@stupidchicken.com>
4627
4628 * xselect.c (x_clipboard_manager_save_frame)
4629 (x_clipboard_manager_save_all): New functions.
4630 (Fx_clipboard_manager_save): Lisp function deleted.
4631
4632 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4633 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4634
4635 * xterm.h: Update prototype.
4636
5ba6571d
WX
46372011-05-28 William Xu <william.xwl@gmail.com>
4638
4639 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4640 exiting (Bug#8239).
4641
3eaff834
JM
46422011-05-28 Jim Meyering <meyering@redhat.com>
4643
e1900994 4644 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4645 * fns.c (to_uchar): Define.
4646 (crypto_hash_function): Use it to convert some newly-signed
4647 variables to unsigned, to avoid sign-extension bugs. For example,
4648 without this change, (md5 "truc") would evaluate to
4649 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4650 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4651 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4652
0f6990a7
PE
46532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4654
4655 Integer overflow fixes.
c8a9ca5a 4656
08686060
PE
4657 * dbusbind.c: Serial number integer overflow fixes.
4658 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4659 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4660 to hold a serial number that is too large for a fixnum.
4661 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4662 Check for serial numbers out of range. Decode any serial number
59568bf0 4663 that was so large that it became a float. (Bug#8722)
08686060 4664
2d1fc3c7
PE
4665 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4666 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4667 Use XFASTINT rather than XUINT when numbers are nonnegative.
4668 (xd_append_arg, Fdbus_method_return_internal):
4669 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4670 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4671 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4672 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4673 (Bug#8722)
2d1fc3c7 4674
c8a9ca5a
PE
4675 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4676
519e1d69
PE
4677 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4678
30569699
PE
4679 ccl: add integer overflow checks
4680 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4681 (IN_INT_RANGE): New macros.
4682 (ccl_driver): Use them to check for integer overflow when
4683 decoding a CCL program. Many of the new checks are whether XINT (x)
4684 fits in int; it doesn't always, on 64-bit hosts. The new version
4685 doesn't catch all possible integer overflows, but it's an
847044ea 4686 improvement. (Bug#8719)
30569699 4687
c11285dc
PE
4688 * alloc.c (make_event_array): Use XINT, not XUINT.
4689 There's no need for unsigned here.
4690
fdccd48e
PE
4691 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4692 This follows up to the 2011-05-06 change that substituted uintptr_t
4693 for EMACS_INT. This case wasn't caught back then.
4694
37910ab2
PE
4695 Rework Fformat to avoid integer overflow issues.
4696 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4697 now (part of C89). Include <verify.h>.
4698 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4699 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4700 (Fformat): Avoid the prepass trying to compute sizes; it was only
4701 approximate and thus did not catch overflow reliably. Instead, walk
4702 through the format just once, formatting and computing sizes as we go,
4703 checking for integer overflow at every step, and allocating a larger
4704 buffer as needed. Keep track separately whether the format is
4705 multibyte. Keep only the most-recently calculated precision, rather
4706 than them all. Record whether each argument has been converted to
4707 string. Use EMACS_INT, not int, for byte and char and arg counts.
4708 Support field widths and precisions larger than INT_MAX. Avoid
4709 sprintf's undefined behavior with conversion specifications such as %#d
4710 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4711 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4712 formatting out-of-range floating point numbers with int
9173deec 4713 formats. (Bug#8668)
37910ab2 4714
2e6578fb
PE
4715 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4716
0ae6bdee
PE
4717 * data.c: Avoid integer truncation in expressions involving floats.
4718 * data.c: Include <intprops.h>.
4719 (arith_driver): When there's an integer overflow in an expression
4720 involving floating point, convert the integers to floating point
4721 so that the resulting value does not suffer from catastrophic
4722 integer truncation. For example, on a 64-bit host (* 4
4723 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4724 Do not rely on undefined behavior after integer overflow.
4725
de883a70
PE
4726 merge count_size_as_multibyte, parse_str_to_multibyte
4727 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4728 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4729 Check for integer overflow.
4730 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4731 since it's now a duplicate of the other. This is more of
4732 a character than a buffer op, so better that it's in character.c.
4733 * fns.c, print.c: Adjust to above changes.
4734
2ff916cb
PE
47352011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4736
4737 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4738
f1b54466
PE
47392011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4740
fb1ac845
PE
4741 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4742 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4743 (x_clipboard_manager_save): Now static.
4744 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4745
f1b54466
PE
4746 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4747 (crypto_hash_function): Now static.
4748 Fix pointer signedness problems. Avoid unnecessary initializations.
4749
a9f737ee
CY
47502011-05-27 Chong Yidong <cyd@stupidchicken.com>
4751
4752 * termhooks.h (Vselection_alist): Make it terminal-local.
4753
4754 * terminal.c (create_terminal): Initialize it.
4755
4756 * xselect.c: Support for clipboard managers.
4757 (Vselection_alist): Move to termhooks.h as terminal-local var.
4758 (LOCAL_SELECTION): New macro.
4759 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4760 (symbol_to_x_atom): Remove gratuitous arg.
4761 (x_handle_selection_request, lisp_data_to_selection_data)
4762 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4763 (x_own_selection, x_get_local_selection, x_convert_selection):
4764 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4765 (some_frame_on_display): Delete unused function.
4766 (Fx_own_selection_internal, Fx_get_selection_internal)
4767 (Fx_disown_selection_internal, Fx_selection_owner_p)
4768 (Fx_selection_exists_p): New optional frame arg.
4769 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4770 (x_handle_selection_clear): Don't treat other terminals with the
4771 same keyboard specially. Use the terminal-local Vselection_alist.
4772 (x_clear_frame_selections): Use Frun_hook_with_args.
4773
4774 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4775
4776 * xterm.h: Add support for those atoms.
4777
e067f0c1
CY
47782011-05-26 Chong Yidong <cyd@stupidchicken.com>
4779
4780 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4781 (converted_selections, conversion_fail_tag): New global variables.
4782 (x_selection_request_lisp_error): Free the above.
4783 (x_get_local_selection): Remove unnecessary code.
4784 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4785 of converted selections stored in converted_selections.
4786 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4787 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4788 (x_convert_selection): New function.
4789 (x_handle_selection_event): Simplify.
4790 (x_get_foreign_selection): Don't ignore incoming requests while
4791 waiting for an answer; this will fail when we implement
4792 SAVE_TARGETS, and seems unnecessary anyway.
4793 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4794 (Vx_sent_selection_functions): Doc fix.
4795
0f4aebc0
LL
47962011-05-26 Leo Liu <sdl.web@gmail.com>
4797
4798 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4799
e61124cd
YM
48002011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4801
4802 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4803
4804 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4805 for fringe update if it has periodic bitmap.
ac389d0c 4806 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4807 and fringe_bitmap_periodic_p.
4808
4809 * fringe.c (get_fringe_bitmap_data): New function.
4810 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4811 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4812 row. Mark glyph row for fringe update if periodicity changed.
4813
4814 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4815 for fringe update unless it has periodic bitmap.
4816
f16d9837
KH
48172011-05-25 Kenichi Handa <handa@m17n.org>
4818
4819 * xdisp.c (get_next_display_element): Set correct it->face_id for
4820 a static composition.
4821
e1b90ef6
LL
48222011-05-24 Leo Liu <sdl.web@gmail.com>
4823
4824 * deps.mk (fns.o):
4825 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4826
4827 * fns.c (crypto_hash_function, Fsha1): New function.
4828 (Fmd5): Use crypto_hash_function.
4829 (syms_of_fns): Add Ssha1.
4830
7400048f
PE
48312011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4832
4833 * gnutls.c: Remove unused macros.
4834 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4835 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4836 Remove macros that are defined and never used.
4837 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4838
abb71cf4
CY
48392011-05-22 Chong Yidong <cyd@stupidchicken.com>
4840
4841 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4842 (Fx_get_selection_internal): Minor cleanup.
4843 (Fx_own_selection_internal): Rename arguments for consistency with
4844 select.el.
4845
6307db39
PE
48462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4847
4848 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4849
f3d4e0a4
CY
48502011-05-22 Chong Yidong <cyd@stupidchicken.com>
4851
4852 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4853
4d8ade89
YM
48542011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4855
4856 * dispnew.c (scrolling_window): Don't exclude the case that the
4857 last enabled row in the desired matrix touches the bottom boundary.
4858
32078c8d
GM
48592011-05-21 Glenn Morris <rgm@gnu.org>
4860
4861 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4862 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4863 and add some more files.
32078c8d 4864
7285dc67
EZ
48652011-05-20 Eli Zaretskii <eliz@gnu.org>
4866
4867 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4868 report_file_error introduced by the change from 2011-05-07.
4869
89d1bd22
PE
48702011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4871
4872 * systime.h (Time): Define only if emacs is defined.
4873 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4874 where the include path doesn't have X11/X.h by default. See
4875 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4876
e23640bb 48772011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4878
4879 * composite.c (find_automatic_composition): Fix previous change.
4880
b9704ad9
GM
48812011-05-20 Glenn Morris <rgm@gnu.org>
4882
4883 * lisp.mk: New file, split from Makefile.in.
4884 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4885 (shortlisp): Remove.
4886 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4887
4a720484
GM
48882011-05-19 Glenn Morris <rgm@gnu.org>
4889
4890 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4891 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4892 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4893 (lisp): Set the order to that of loadup.el.
4894 (shortlisp): Make it a copy of $lisp.
4895 (SOME_MACHINE_LISP): Remove.
4896 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4897 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4898
a28d4396
KH
48992011-05-18 Kenichi Handa <handa@m17n.org>
4900
4901 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4902 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4903 (find_automatic_composition): Mostly rewrite for efficiency.
4904
a2b1fa8e
JB
49052011-05-18 Juanma Barranquero <lekktu@gmail.com>
4906
4907 * makefile.w32-in: Update dependencies.
4908
8e1f5610
CS
49092011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4910
4911 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4912 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4913
7025ee00 49142011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4915
cdfa6eab
PE
4916 Fix some integer overflow issues, such as string length overflow.
4917
06d6db33
PE
4918 * insdel.c (count_size_as_multibyte): Check for string overflow.
4919
2b4560a8
PE
4920 * character.c (lisp_string_width): Check for string overflow.
4921 Use EMACS_INT, not int, for string indexes and lengths; in
4922 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4923 the resulting string length overflows an EMACS_INT; instead,
4924 report a string overflow if no precision given. When checking for
4925 precision exhaustion, use a check that cannot possibly have
4926 integer overflow. (Bug#8675)
4927 * character.h (lisp_string_width): Adjust to new signature.
4928
cb93f9be
PE
4929 * alloc.c (string_overflow): New function.
4930 (Fmake_string): Use it. This doesn't change behavior, but saves
4931 a few bytes and will simplify future changes.
4932 * character.c (string_escape_byte8): Likewise.
4933 * lisp.h (string_overflow): New decl.
4934
1a1f3366
PE
4935 Fixups, following up to the user-interface timestamp change.
4936 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4937 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4938 * msdos.c (mouse_get_pos): Likewise.
4939 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4940 * w32gui.h (Time): Define by including "systime.h" rather than by
4941 declaring it ourselves. (Bug#8664)
4942
d4e3e4d3
PE
4943 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4944 * image.c (clear_image_cache): Likewise.
4945
f6a24d19
PE
4946 * term.c (term_mouse_position): Don't assume time_t wraparound.
4947
08dc5ae6
PE
4948 Be more systematic about user-interface timestamps.
4949 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4950 and sometimes 'EMACS_UINT', to represent these timestamps.
4951 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4952 This makes the code easier to follow, and makes it easier to catch
4953 integer overflow bugs such as Bug#8664.
4954 * frame.c (Fmouse_position, Fmouse_pixel_position):
4955 Use Time, not unsigned long, for user-interface timestamps.
4956 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4957 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4958 * keyboard.h (last_event_timestamp): Likewise.
4959 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4960 * menu.h (xmenu_show): Likewise.
4961 * term.c (term_mouse_position): Likewise.
4962 * termhooks.h (struct input_event.timestamp): Likewise.
4963 (struct terminal.mouse_position_hook): Likewise.
4964 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4965 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4966 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4967 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4968 what it was before.
4969 * menu.h, termhooks.h: Include "systime.h", for Time.
4970
8e55734a
PE
4971 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4972 Don't assume that the difference between two unsigned long values
4973 can fit into an integer. At this point, we know button_down_time
4974 <= event->timestamp, so the difference must be nonnegative, so
4975 there's no need to cast the result if double-click-time is
4976 nonnegative, as it should be; check that it's nonnegative, just in
4977 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4978 apart (about 25 days). (Bug#8664)
8e55734a 4979
841f1b75 4980 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4981 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4982
3e26f69c
PE
4983 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4984 that always fit in int. Use a sentinel instead of a counter, to
4985 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4986 * frame.h (struct frame): Use int for menu_bar_items_used
4987 instead of EMACS_INT, since it always fits in int.
3e26f69c 4988
5cc152c0
PE
4989 * menu.c (grow_menu_items): Check for int overflow.
4990
d89eb65e
PE
4991 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4992
5235bd3e
PE
4993 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4994 Before, the code was not consistent. These values cannot exceed
4995 2**31 - 1 so there's no need to make them unsigned.
4996 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4997 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4998 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4999 as modifiers.
5000 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5001
bc827e23
PE
5002 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5003 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5004 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5005 presumably because the widths might not match.
5006
78eb494e
PE
5007 * window.c (size_window): Avoid needless test at loop start.
5008
04f2d78b
CB
50092011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5010
5011 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5012
d2fc7e3d 50132011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5014
5015 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5016
d2fc7e3d 50172011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5018
5019 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5020 `width' to `bar_area_x' and `bar_area_width', respectively.
5021 (x_scroll_run): Take account of fringe background extension.
5022
04f2d78b
CB
5023 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5024 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5025 `bar_area_width', respectively.
5026 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5027 background extension.
5028
79b70037
GM
50292011-05-10 Jim Meyering <meyering@redhat.com>
5030
5031 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5032
2f142cc5
JB
50332011-05-10 Juanma Barranquero <lekktu@gmail.com>
5034
5035 * image.c (Finit_image_library): Return t for built-in image types,
5036 like pbm and xbm. (Bug#8640)
5037
57679c86
AS
50382011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5039
5040 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5041
888c9e86
EZ
50422011-05-07 Eli Zaretskii <eliz@gnu.org>
5043
b0512a1d
EZ
5044 * w32console.c (Fset_screen_color): Doc fix.
5045 (Fget_screen_color): New function.
5046 (syms_of_ntterm): Defsubr it.
5047
7285dc67
EZ
5048 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5049 unlink the temporary file if Fcall_process didn't create it in the
5050 first place.
5051 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5052 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5053 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5054 cue to call_process_cleanup not to close that handle.
5055
4d3fcc8e
BK
50562011-05-07 Ben Key <bkey76@gmail.com>
5057
5058 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5059 one of two shell specific rules, either bootstrap-temacs-CMD or
5060 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5061 to the previous implementation of the bootstrap-temacs rule.
5062 The bootstrap-temacs-CMD rule is similar to the previous
5063 implementation of the bootstrap-temacs rule except that it
5064 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5065 variable.
5066
5067 These changes, along with some changes to nt/configure.bat,
5068 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5069 earlier fix to add support for --cflags and --ldflags options
5070 that include quotes so that it works whether make uses cmd or
5071 sh as the shell.
5072
b4289b64
MA
50732011-05-06 Michael Albinus <michael.albinus@gmx.de>
5074
5075 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5076 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5077 is a constant.
5078 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5079 a string. Handle both cases.
5080 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5081 (Fdbus_register_method): Use Qinvalid_function.
5082
af4c0e28
JB
50832011-05-06 Juanma Barranquero <lekktu@gmail.com>
5084
5085 * makefile.w32-in: Update dependencies.
5086 (LISP_H): Add inttypes.h and stdin.h.
5087 (PROCESS_H): Add unistd.h.
5088
c51453d9
EZ
50892011-05-06 Eli Zaretskii <eliz@gnu.org>
5090
5091 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5092 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5093
8ff0ac3c 50942011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5095
4c4b566b
PE
5096 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5097
aab2b9b5
PE
5098 * term.c (vfatal): Remove stray call to va_end.
5099 It's not needed and the C Standard doesn't allow it here anyway.
5100
c378da0b
PE
5101 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5102 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5103
288b08c7
PE
5104 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5105 bytes.
5106
e3601888
PE
5107 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5108
db6c0e74
PE
5109 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5110
dd5963ea
PE
5111 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5112
88c9450f
PE
5113 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5114
2f9442b8
PE
5115 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5116
c032b5f8
PE
5117 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5118 * charset.c (Fdefine_charset_internal): Don't initialize
5119 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5120 32-bit int (Bug#8600).
a108c10b
PE
5121
5122 * lread.c (read_integer): Be more consistent with string-to-number.
5123 Use string_to_number to do the actual conversion; this avoids
5124 rounding errors and fixes some other screwups. Without this fix,
5125 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5126 (digit_to_number): Move earlier, for benefit of read_integer.
5127 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5128 not a digit in any supported base. (Bug#8602)
a108c10b 5129
ad5f9eea
PE
5130 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5131
aec1708a
PE
5132 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5133 to match comment at start of function. This also removes a
5134 GCC warning about overflow in a 32+64-bit port.
5135
47be4ab5
PE
5136 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5137
371cac43
PE
5138 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5139 Reported by Stefan Monnier in
5140 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5141 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5142 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5143
d01a7826
PE
5144 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5145 (EMACS_UINTPTR): Likewise, with uintptr_t.
5146
7fd47d5c
PE
5147 * lisp.h: Prefer 64-bit EMACS_INT if available.
5148 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5149 on 32-bit hosts that have 64-bit int, so that they can access
5150 large files.
122b0c86
PE
5151 However, temporarily disable this change unless the temporary
5152 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5153
8727937b
PE
5154 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5155
8ac068ac
PE
5156 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5157 This removes an assumption that EMACS_INT and long are the same
5158 width as pointers. The assumption is true for Emacs porting targets
5159 now, but we want to make other targets possible.
5160 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5161 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5162 In the rest of the code, change types of integers that hold casted
5163 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5164 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5165 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5166 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5167 No need to cast type when ORing.
5168 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5169 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5170 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5171 assume EMACS_INT is the same width as char *.
5172 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5173 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5174 Remove no-longer-needed casts.
5175 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5176 (xg_tool_bar_help_callback, xg_make_tool_item):
5177 Use EMACS_INTPTR to hold an integer
5178 that will be cast to void *; this can avoid a GCC warning
5179 if EMACS_INT is not the same width as void *.
5180 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5181 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5182 (current_message_1, set_message_1):
5183 Use a local to convert to proper width without a cast.
5184 * xmenu.c (dialog_selection_callback): Likewise.
5185
ede49d71
PE
5186 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5187 Also, don't assume VALBITS / RAND_BITS is less than 5,
5188 and don't rely on undefined behavior when shifting a 1 left into
5189 the sign bit.
5190 * lisp.h (get_random): Change signature to match.
5191
2f30ecd0
PE
5192 * lread.c (hash_string): Use size_t, not int, for hash computation.
5193 Normally we prefer signed values; but hashing is special, because
5194 it's better to use unsigned division on hash table sizes so that
5195 the remainder is nonnegative. Also, size_t is the natural width
5196 for hashing into memory. The previous code used 'int', which doesn't
5197 retain enough info to hash well into very large tables.
5198 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5199
2a866e7b
PE
5200 * dbusbind.c: Don't possibly lose pointer info when converting.
5201 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5202 Use XPNTR rather than XHASH, so that the high-order bits of
5203 the pointer aren't lost when converting through void *.
5204
51639eac
PE
5205 * eval.c (Fautoload): Don't double-shift a pointer.
5206
92394119
PE
5207 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5208
dbdb9a7c
JB
52092011-05-06 Juanma Barranquero <lekktu@gmail.com>
5210
5211 * gnutls.c (DEF_GNUTLS_FN):
5212 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5213
db7a0b4f
AS
52142011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5215
5216 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5217 marker. (Bug#8610)
5218
f7ff1b0f 52192011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5220
5221 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5222 New version that can reserve upto 2GB of heap space.
5223
f7ff1b0f 52242011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5225
5226 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5227
639c109b
TZ
52282011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5229
5230 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5231 `gnutls_certificate_set_x509_key_file'.
5232
d2127135
JB
52332011-05-05 Juanma Barranquero <lekktu@gmail.com>
5234
5235 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5236 Update dependencies.
5237
e968f4f3
JB
52382011-05-04 Juanma Barranquero <lekktu@gmail.com>
5239
5240 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5241 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5242 Remove unused parameter `fildes'.
5243 * process.c (read_process_output, send_process): Don't pass it.
5244
84d358f0
JB
52452011-05-04 Juanma Barranquero <lekktu@gmail.com>
5246
5247 Fix previous change: the library cache is defined in w32.c.
5248 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5249 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5250
0898ca10
JB
52512011-05-04 Juanma Barranquero <lekktu@gmail.com>
5252
5253 Implement dynamic loading of GnuTLS on Windows.
5254
5255 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5256 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5257 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5258 Declare.
5259
5260 * gnutls.c (Qgnutls_dll): Define.
5261 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5262 (gnutls_*): Declare function pointers.
5263 (init_gnutls_functions): New function to initialize function pointers.
5264 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5265 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5266 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5267 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5268 (emacs_gnutls_write, emacs_gnutls_read)
5269 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5270 (Fgnutls_available_p): New function.
5271 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5272 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5273 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5274
5275 * image.c: Include w32.h.
5276 (Vimage_type_cache): Delete.
5277 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5278 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5279 (w32_delayed_load): Move to w32.c.
5280
5281 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5282
5283 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5284 (w32_delayed_load): Move from image.c. When loading a library, record
5285 its filename in the :loaded-from property of the library id.
5286 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5287 Initialize and staticpro them.
5288 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5289
5290 * process.c: Include lisp.h before w32.h, not after.
5291 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5292 instead of gnutls_record_check_pending.
5293
5294 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5295
ff4de4aa
TZ
52962011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5297
5298 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5299 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5300 as passed in.
5301
abe95abb
JD
53022011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5303
5304 * xterm.c (x_set_frame_alpha): Do not set property on anything
5305 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5306
e16e55d4
JB
53072011-05-02 Juanma Barranquero <lekktu@gmail.com>
5308
5309 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5310
bafcf6a5
JB
53112011-05-02 Juanma Barranquero <lekktu@gmail.com>
5312
5313 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5314 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5315 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5316 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5317 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5318 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5319 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5320 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5321 (Qgnutls_bootprop_callbacks_verify): Make static.
5322
e7a6747f
AS
53232011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5324
19ed11ba
AS
5325 * callproc.c: Indentation fixup.
5326
e7a6747f 5327 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5328 (wait_for_termination, interruptible_wait_for_termination):
5329 Move after wait_for_termination_1.
e7a6747f 5330
1ef14cb4
LMI
53312011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5332
5333 * sysdep.c (interruptible_wait_for_termination): New function
5334 which is like wait_for_termination, but allows keyboard
5335 interruptions.
5336
5337 * callproc.c (Fcall_process): Add (:file "file") as an option for
5338 the STDOUT buffer.
5339 (Fcall_process_region): Ditto.
5340
330d880c
EZ
53412011-04-30 Eli Zaretskii <eliz@gnu.org>
5342
8db90b73
EZ
5343 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5344 rather than `XVECTOR (FOO)->size'.
5345
330d880c
EZ
5346 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5347 inttypes.h, as a gnulib replacement is used if it not available in
5348 system headers.
5349
15cbd324
EZ
53502011-04-21 Eli Zaretskii <eliz@gnu.org>
5351
5352 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5353 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5354 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5355
5356 * coding.c (coding_alloc_by_realloc): Error out if destination
5357 will grow beyond MOST_POSITIVE_FIXNUM.
5358 (decode_coding_emacs_mule): Abort if there isn't enough place in
5359 charbuf for the composition carryover bytes. Reserve an extra
5360 space for up to 2 characters produced in a loop.
5361 (decode_coding_iso_2022): Abort if there isn't enough place in
5362 charbuf for the composition carryover bytes.
5363
53642011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5365
ae940cca
EZ
5366 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5367 aborting when %lld or %lll format is passed.
5368 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5369 %llo or %llx format is passed. (Bug#8545)
5370
03ab8921
EZ
5371 * window.c (window_scroll_line_based): Use a marker instead of
5372 simple variables to record original value of point. (Bug#7952)
5373
afda1437
EZ
5374 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5375 produced by %s or %c overflows available buffer space. (Bug#8545)
5376
f76dee0c
PE
53772011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5378
5379 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5380 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5381
fdc5744d
JB
53822011-04-28 Juanma Barranquero <lekktu@gmail.com>
5383
5384 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5385
638f053a
JB
53862011-04-28 Juanma Barranquero <lekktu@gmail.com>
5387
5388 * keyboard.c (Qdelayed_warnings_hook): Define.
5389 (command_loop_1): Run `delayed-warnings-hook'
5390 if Vdelayed_warnings_list is non-nil.
5391 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5392 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5393
d178f871
EZ
53942011-04-28 Eli Zaretskii <eliz@gnu.org>
5395
5396 * doprnt.c (doprnt): Don't return value smaller than the buffer
5397 size if the message was truncated. (Bug#8545).
5398
b124fd93
JB
53992011-04-28 Juanma Barranquero <lekktu@gmail.com>
5400
5401 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5402 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5403
e810457d
PE
54042011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5405
5406 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5407
ea51cceb
JB
54082011-04-27 Juanma Barranquero <lekktu@gmail.com>
5409
5410 * makefile.w32-in: Update dependencies.
5411
94dcfacf
EZ
54122011-04-27 Eli Zaretskii <eliz@gnu.org>
5413
5414 Improve `doprnt' and its usage. (Bug#8545)
5415 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5416 `format_end'. Remove support for %l as a conversion specifier.
5417 Don't use xrealloc. Improve diagnostics when the %l size modifier
5418 is used. Update the commentary.
5419
5420 * eval.c (verror): Simplify calculation of size_t.
5421
5422 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5423 messages.
5424
f61f41d7
PE
54252011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5426
5427 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5428 change.
5429
96fb4434
PE
54302011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5431
5432 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5433 This makes this file independent of the recent pseudovector change.
5434
671875da 54352011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5436
69e9b5a3
PE
5437 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5438
b5f869a7 5439 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5440 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5441 Remove unused local.
c8926152 5442 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5443
841a1577 5444 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5445 GCC 4.6.0 optimizes based on type-based alias analysis.
5446 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5447 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5448 != &v->size, and therefore "v->size = 1; b->size = 2; return
5449 v->size;" must therefore return 1. This assumption is incorrect
5450 for Emacs, since it type-puns struct Lisp_Vector * with many other
5451 types. To fix this problem, this patch adds a new type struct
f904488f 5452 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5453 and pseudovectors, and helps optimizing compilers not get fooled
5454 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5455 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5456 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5457 the size member.
eab3844f
PE
5458 (XSETPVECTYPE): Rewrite in terms of new macro.
5459 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5460 This is a bit clearer, and further avoids the possibility of
5461 undesirable aliasing.
5462 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5463 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5464 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5465 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5466 (ASIZE): Now uses header.size rather than size.
5467 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5468 to avoid the hassle of writing XVECTOR (foo)->header.size.
5469 (struct vectorlike_header): New type.
eab3844f
PE
5470 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5471 object, to help avoid aliasing.
5472 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5473 (SUBRP): Likewise, since Lisp_Subr is a special case.
5474 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5475 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5476 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5477 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5478 changed to be "header.size" and "header.next".
5479 * buffer.h (struct buffer): Likewise.
5480 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5481 * frame.h (struct frame): Likewise.
5482 * process.h (struct Lisp_Process): Likewise.
5483 * termhooks.h (struct terminal): Likewise.
5484 * window.c (struct save_window_data, struct saved_window): Likewise.
5485 * window.h (struct window): Likewise.
5486 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5487 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5488 * buffer.c (init_buffer_once): Likewise.
5489 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5490 special case.
5491 * process.c (Fformat_network_address): Use local var for size,
5492 for brevity.
5493
0df1eac5
PE
5494 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5495
847ab9d1 5496 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5497 * data.c (atof): Remove decl; no longer used or needed.
5498 (digit_to_number): Move to lread.c.
5499 (Fstring_to_number): Use new string_to_number function, to be
5500 consistent with how the Lisp reader treats infinities and NaNs.
5501 Do not assume that floating-point numbers represent EMACS_INT
5502 without losing information; this is not true on most 64-bit hosts.
5503 Avoid double-rounding errors, by insisting on integers when
5504 parsing non-base-10 numbers, as the documentation specifies.
5505 * lisp.h (string_to_number): New decl, replacing ...
5506 (isfloat_string): Remove.
bc0a5c13 5507 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5508 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5509 appears to have been a coding error. Similarly, do not accept
5510 strings like +-1e0 as floating point numbers. Do not report
5511 overflow for integer overflows unless the base is not 10 which
5512 means we have no simple and reliable way to continue.
5513 Break out the floating-point parsing into a new
5514 function string_to_number, so that Fstring_to_number parses
5515 floating point numbers consistently with the Lisp reader.
04f2d78b 5516 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5517 (E_CHAR, EXP_INT): Remove, replacing with ...
5518 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5519 (string_to_number): New function, replacing isfloat_string.
5520 This function checks for valid syntax and produces the resulting
5521 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5522 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5523 so that overflow for non-base-10 numbers is reported only when
5524 there's no portable and simple way to convert to floating point.
452f4150 5525
67769ffc
PE
5526 * textprop.c (set_text_properties_1): Rewrite for clarity,
5527 and to avoid GCC warning about integer overflow.
5528
c20db43f
PE
5529 * intervals.h (struct interval): Use EMACS_INT for members
5530 where EMACS_UINT might cause problems. See
5531 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5532 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5533 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5534 All uses changed.
37aa2f85
PE
5535 (offset_intervals): Tell GCC not to worry about length overflow
5536 when negating a negative length.
c20db43f 5537
2538aa2f
PE
5538 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5539 (overrun_check_free): Likewise.
5540
f2d3008d
PE
5541 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5542 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5543 word size.
5544
ec8df744
PE
5545 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5546 (gnutls_make_error): Rename local to avoid shadowing.
5547 (gnutls_emacs_global_deinit): ifdef out; not used.
5548 (Fgnutls_boot): Use const for pointer to readonly storage.
5549 Comment out unused local. Fix pointer signedness problems.
5550
640ee02d
PE
5551 * lread.c (openp): Don't stuff size_t into an 'int'.
5552 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5553 about possible signed overflow.
5554
6048fb2a
PE
5555 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5556 (GDK_KEY_g): Don't define if already defined.
5557 (xg_prepare_tooltip): Avoid pointer signedness problem.
5558 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5559
fa3c87e1
PE
5560 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5561 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5562
2172544b
PE
5563 * xfns.c (Fx_window_property): Simplify a bit,
5564 to make a bit faster and to avoid GCC 4.6.0 warning.
5565 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5566
9b821a21
PE
5567 * fns.c (internal_equal): Don't assume size_t fits in int.
5568
3c616cfa
PE
5569 * alloc.c (compact_small_strings): Tighten assertion a little.
5570
c2982e87
PE
5571 Replace pEd with more-general pI, and fix some printf arg casts.
5572 * lisp.h (pI): New macro, generalizing old pEd macro to other
5573 conversion specifiers. For example, use "...%"pI"d..." rather
5574 than "...%"pEd"...".
5575 (pEd): Remove. All uses replaced with similar uses of pI.
5576 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5577 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5578 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5579 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5580 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5581 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5582 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5583 64-bit hosts.
5584 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5585 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5586 * print.c (safe_debug_print, print_object): Likewise.
5587 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5588 to int.
6f04d126
PE
5589 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5590 avoiding the 0 flag, which is not portable.
c2982e87
PE
5591 * process.c (Fmake_network_process): Use pI to avoid cast.
5592 * region-cache.c (pp_cache): Likewise.
5593 * xdisp.c (decode_mode_spec): Likewise.
5594 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5595 behavior on 64-bit hosts with printf arg.
6f04d126 5596 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5597 (x_stop_queuing_selection_requests): Likewise.
5598 (x_get_window_property): Don't truncate byte count to an 'int'
5599 when tracing.
0b432f21 5600
5e073ec7
PE
5601 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5602 here, since it parses constructs like leading '-' and spaces,
5603 which are not wanted; and it overflows with large numbers.
5604 Instead, simply match F[0-9]+, which is what is wanted anyway.
5605
36372bf9
PE
5606 * alloc.c: Remove unportable assumptions about struct layout.
5607 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5608 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5609 (allocate_vectorlike, make_pure_vector): Use the new macros,
5610 plus offsetof, to remove unportable assumptions about struct layout.
5611 These assumptions hold on all porting targets that I know of, but
5612 they are not guaranteed, they're easy to remove, and removing them
5613 makes further changes easier.
5614
0b432f21
PE
5615 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5616 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5617 (string_overrun_cookie): Now const. Use initializers that
5618 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5619 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5620 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5621 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5622 multiple of sizeof (EMACS_INT); it need not be, if
5623 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5624 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5625
895009e1
JB
56262011-04-26 Juanma Barranquero <lekktu@gmail.com>
5627
5628 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5629
6a7a1b0b
TZ
56302011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5631
5632 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5633 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5634 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5635
841a1577 56362011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5637
5638 * lisp.h (Qdebug): List symbol.
895009e1 5639 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5640 * keyboard.c (debug-on-event): New variable.
5641 (handle_user_signal): Break into debugger when debug-on-event
5642 matches the current signal symbol.
5643
f2d3ba6f
DN
56442011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5645
5646 * alloc.c (check_sblock, check_string_bytes)
5647 (check_string_free_list): Convert to standard C.
5648
42ce4c63
TZ
56492011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5650
5651 * w32.c (emacs_gnutls_push): Fix typo.
5652
825cd63c
EZ
56532011-04-25 Eli Zaretskii <eliz@gnu.org>
5654
fb11d64d
EZ
5655 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5656 "cast to pointer from integer of different size".
5657
825cd63c
EZ
5658 Improve doprnt and its use in verror. (Bug#8545)
5659 * doprnt.c (doprnt): Document the set of format control sequences
5660 supported by the function. Use SAFE_ALLOCA instead of always
5661 using `alloca'.
5662
5663 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5664 is one byte too soon. Don't use xrealloc; instead xfree and
5665 xmalloc anew.
5666
e061a11b
TZ
56672011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5668
5669 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5670 callbacks stage.
5671
5672 * gnutls.c: Renamed global_initialized to
5673 gnutls_global_initialized. Added internals for the
5674 :verify-hostname-error, :verify-error, and :verify-flags
5675 parameters of `gnutls-boot' and documented those parameters in the
5676 docstring. Start callback support.
9173deec
JB
5677 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5678 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5679 on error. Return error code.
e061a11b
TZ
5680 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5681 (emacs_gnutls_read): Likewise.
5682 (Fgnutls_boot): Return handshake error code.
5683 (emacs_gnutls_handle_error): New function.
5684 (wsaerror_to_errno): Likewise.
5685
5686 * w32.h (emacs_gnutls_pull): Add prototype.
5687 (emacs_gnutls_push): Likewise.
5688
5689 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5690 (emacs_gnutls_push): Likewise.
5691
56922011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5693
5694 * process.c (wait_reading_process_output): Check if GnuTLS
5695 buffered some data internally if no FDs are set for TLS
5696 connections.
5697
5698 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5699 (LIBS): Link to USER_LIBS.
5700 ($(BLD)/gnutls.$(0)): New target.
5701
fa6996bc
EZ
57022011-04-24 Eli Zaretskii <eliz@gnu.org>
5703
eb35682e
EZ
5704 * xdisp.c (handle_single_display_spec): Rename the
5705 display_replaced_before_p argument into display_replaced_p, to
5706 make it consistent with the commentary. Fix typos in the
5707 commentary.
5708
e2ad650c
EZ
5709 * textprop.c (syms_of_textprop): Remove dead code.
5710 (copy_text_properties): Delete obsolete commentary about an
5711 interface that was deleted long ago. Fix typos in the description
5712 of arguments.
5713
1b2de274
EZ
5714 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5715 to changes in oldXMenu/XMenu.h from 2011-04-16.
5716 <menu_help_message, prev_menu_help_message>: Constify.
5717 (IT_menu_make_room): menu->help_text is now `const char **';
5718 adjust.
5719
5720 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5721 to changes in oldXMenu/XMenu.h from 2011-04-16.
5722 (struct XMenu): Declare `help_text' `const char **'.
5723
5724 * xfaces.c <Qunspecified>: Make extern again.
5725
5726 * syntax.c: Include sys/types.h before including regex.h, as
5727 required by Posix.
5728
762b15be
EZ
5729 * doc.c (get_doc_string): Improve the format passed to `error'.
5730
5731 * doprnt.c (doprnt): Improve commentary.
5732
5733 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5734
5735 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5736 them with etags.
5737
f1052e5d
EZ
5738 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5739 changes in globals.h immediately force recompilation.
762b15be
EZ
5740 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5741 $(CURDIR)/s/ms-w32.h.
5742 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5743
fa6996bc
EZ
5744 * character.c (Fchar_direction): Function deleted.
5745 (syms_of_character): Don't defsubr it.
5746 <char-direction-table>: Deleted.
5747
e6c3da20
EZ
57482011-04-23 Eli Zaretskii <eliz@gnu.org>
5749
5750 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5751 * doprnt.c: Include limits.h.
5752 (SIZE_MAX): New macro.
04f2d78b
CB
5753 (doprnt): Return a size_t value. 2nd arg is now size_t.
5754 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5755 Improve overflow protection. Support `l' modifier for integer
5756 conversions. Support %l conversion. Don't assume an EMACS_INT
5757 argument for integer conversions and for %c.
5758
5759 * lisp.h (doprnt): Restore prototype.
5760
5761 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5762 $(SRC)/character.h.
5763
5764 * Makefile.in (base_obj): Add back doprnt.o.
5765
5766 * deps.mk (doprnt.o): Add back prerequisites.
5767 (callint.o): Depend on character.h.
5768
5769 * eval.c (internal_lisp_condition_case): Include the handler
5770 representation in the error message.
5771 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5772 when breaking from the loop.
5773
5774 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5775
5776 * callint.c (Fcall_interactively): When displaying error message
5777 about invalid control letter, pass the character's codepoint, not
5778 a pointer to its multibyte form. Improve display of the character
5779 in octal and display also its hex code.
5780
5781 * character.c (char_string): Use %x to display the (unsigned)
5782 codepoint of an invalid character, to avoid displaying a bogus
5783 negative value.
5784
5785 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5786 `error', not SYMBOL_NAME itself.
5787
5788 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5789 character arguments to `error'.
5790
5791 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5792 to `error' in error message about FINAL_CHAR argument. Make sure
5793 FINAL_CHAR is a character, and use %c when it is passed as
5794 argument to `error'.
5795
4ffd0d6b 57962011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5797
5798 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5799
5800 * w32.c: Include <time.h>.
5801 (sys_localtime): New function.
5802
4ffd0d6b 58032011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5804
5805 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5806
4ffd0d6b 5807 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5808
4ffd0d6b 58092011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5810
4ffd0d6b
GM
5811 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5812 zombies (Bug#8467).
aac0c6e3 5813
04c56954
EZ
58142011-04-19 Eli Zaretskii <eliz@gnu.org>
5815
5816 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5817 gl_state.e_property when gl_state.object is Qt.
5818
5819 * insdel.c (make_gap_larger): Remove limitation of buffer size
5820 to <= INT_MAX.
5821
16a43933
CY
58222011-04-18 Chong Yidong <cyd@stupidchicken.com>
5823
5824 * xdisp.c (lookup_glyphless_char_display)
5825 (produce_glyphless_glyph): Handle cons cell entry in
5826 glyphless-char-display.
5827 (Vglyphless_char_display): Document it.
5828
5829 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5830 glyphless-char-display.
5831
4581706e
CY
58322011-04-17 Chong Yidong <cyd@stupidchicken.com>
5833
5834 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5835
5836 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5837
5838 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5839 definition for no-X builds.
5840
4887c6e2 58412011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5842
fd35b6f9
PE
5843 Static checks with GCC 4.6.0 and non-default toolkits.
5844
5c1ccb01
PE
5845 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5846
006c5daa
PE
5847 * process.c (keyboard_bit_set): Define only if SIGIO.
5848 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5849 (send_process): Repair possible setjmp clobbering.
5850
efc736d3
PE
5851 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5852
4e2fe2e6
PE
5853 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5854
f97334a2
PE
5855 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5856
4e75f29d
PE
5857 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5858 Define only if needed.
5859
90efadd1
PE
5860 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5861 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5862 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5863
3c647824
PE
5864 * dispextern.h (struct redisplay_interface): Rename param
5865 to avoid shadowing.
e264f262 5866 * termhooks.h (struct terminal): Likewise.
761383f4 5867 * xterm.c (xembed_send_message): Likewise.
3c647824 5868
b58c5c4a
PE
5869 * insdel.c (make_gap_smaller): Define only if
5870 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5871
cad59032
PE
5872 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5873 it.
5874
c339dc2e
PE
5875 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5876 so that we aren't warned about unused symbols.
5877
91a3e27b
PE
5878 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5879
399c71d3 5880 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5881
8ffc96f5
PE
5882 * xfns.c (x_real_positions): Mark locals as initialized.
5883
eef9bc79
PE
5884 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5885
098db9dd
PE
5886 * xterm.c: Fix problems found by static analysis with other toolkits.
5887 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5888 (x_dispatch_event): Declare static if USE_GTK, and
5889 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5890 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5891 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5892 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5893 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5894
eb18f6cc
PE
5895 * xmenu.c (menu_help_callback): Pointer type fixes.
5896 Use const pointers when pointing at readonly data. Avoid pointer
5897 signedness clashes.
5898 (FALSE): Remove unused macro.
5899 (update_frame_menubar): Remove unused decl.
5900
1fe72bf8
PE
5901 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5902
60d9e1db
PE
5903 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5904 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5905 (single_menu_item): Rename local to avoid shadowing.
5906
39261c26
PE
5907 * keyboard.c (make_lispy_event): Remove unused local var.
5908
018c5e19
PE
5909 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5910 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5911
63d2b86e
PE
5912 * bitmaps: Change bitmaps from unsigned char back to the X11
5913 compatible char. Avoid the old compiler warnings about
5914 out-of-range initializers by using, for example, '\xab' rather
5915 than 0xab.
5916
aefd87e1
PE
5917 * xgselect.c (xgselect_initialize): Check vs interface
5918 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5919
bf501fb9
PE
5920 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5921
e9829fdf
PE
5922 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5923 to read-only memory.
5924
1086c095
PE
5925 * fns.c (vector): Remove; this old hack is no longer needed.
5926
2baccd04 5927 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5928 Remove unused var.
dde42981 5929 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5930
72391843 5931 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5932
436c16df 5933 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5934 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5935 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5936
92bb796d 5937 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5938 (x_term_init): Remove local to avoid shadowing.
92bb796d 5939
764430a3 5940 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5941
5942 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5943 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5944
d1dfb56c
EZ
59452011-04-16 Eli Zaretskii <eliz@gnu.org>
5946
c4354cb4
EZ
5947 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5948
d1dfb56c
EZ
5949 Fix regex.c, syntax.c and friends for buffers > 2GB.
5950 * syntax.h (struct gl_state_s): Declare character position members
5951 EMACS_INT.
5952
5953 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5954
04f2d78b
CB
5955 * textprop.c (verify_interval_modification, interval_of):
5956 Declare arguments EMACS_INT.
d1dfb56c
EZ
5957
5958 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5959 EMACS_INT.
5960
5961 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5962
5963 * indent.c (Fvertical_motion): Local variable it_start is now
5964 EMACS_INT.
5965
5966 * regex.c (re_match, re_match_2, re_match_2_internal)
5967 (bcmp_translate, regcomp, regexec, print_double_string)
5968 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5969 (re_compile_pattern, re_exec): Declare arguments and local
5970 variables `size_t' and `ssize_t' and return values `regoff_t', as
5971 appropriate.
5972 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5973 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5974 <compile_stack_type>: `size' and `avail' are now `size_t'.
5975
5976 * regex.h <regoff_t>: Use ssize_t, not int.
5977 (re_search, re_search_2, re_match, re_match_2): Arguments that
5978 specify buffer/string position and length are now ssize_t and
5979 size_t. Return type is regoff_t.
5980
613052cd
BK
59812011-04-16 Ben Key <bkey76@gmail.com>
5982
5983 * nsfont.m: Fixed bugs in ns_get_family and
5984 ns_descriptor_to_entity that were caused by using free to
5985 deallocate memory blocks that were allocated by xmalloc (via
5986 xstrdup). This caused Emacs to crash when compiled with
5987 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5988 --enable-checking=xmallocoverrun). xfree is now used to
5989 deallocate these memory blocks.
5990
4170f62f 59912011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5992
71b41406
PE
5993 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5994
9587a89d
PE
5995 emacs_write: Accept and return EMACS_INT for sizes.
5996 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5997 et seq.
5998 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5999 Accept and return EMACS_INT.
6000 (emacs_gnutls_write): Return the number of bytes written on
6001 partial writes.
6002 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6003 (emacs_read, emacs_write): Remove check for negative size, as the
6004 Emacs source code has been audited now.
9587a89d
PE
6005 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6006 (emacs_read, emacs_write): Use it.
273a5f82
PE
6007 * process.c (send_process): Adjust to the new signatures of
6008 emacs_write and emacs_gnutls_write. Do not attempt to store
6009 a byte offset into an 'int'; it might overflow.
9587a89d 6010 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6011
3e047f51
PE
6012 * sound.c: Don't assume sizes fit in 'int'.
6013 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6014 Return EMACS_INT, not int.
3e047f51 6015 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6016 Accept EMACS_INT, not int.
6017 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6018 record read return values.
6019
cc39a9db
BK
60202011-04-15 Ben Key <bkey76@gmail.com>
6021
c9d0ec6d
JB
6022 * keyboard.c (Qundefined): Don't declare static since it is used
6023 in nsfns.m.
6024 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6025 static since they are used in nsfont.m.
cc39a9db 6026
6c60eb9f
SM
60272011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6028
6029 * process.c (Qprocessp): Don't declare static.
6030 * lisp.h (Qprocessp): Declare again.
6031
7990b61a
JB
60322011-04-15 Juanma Barranquero <lekktu@gmail.com>
6033
6034 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6035
5d4cb038
PE
60362011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6037
8bd7b830 6038 Improve C-level modularity by making more things 'static'.
cd64ea1d 6039
e3b27b31
PE
6040 Don't publish debugger-only interfaces to other modules.
6041 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6042 (verify_bytepos, count_markers): Move decls to the only modules
6043 that need them.
6044 * region-cache.h (pp_cache): Likewise.
6045 * window.h (check_all_windows): Likewise.
6046 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6047
5d4cb038
PE
6048 * sysdep.c (croak): Now static, if
6049 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6050 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6051
6052 * alloc.c (refill_memory_reserve): Now static if
6053 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6054 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6055
e87b6180
PE
6056 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6057 Define only if USE_LUCID.
6058
ac64929e
PE
6059 * xrdb.c (x_customization_string, x_rm_string): Now static.
6060
6f37259d
PE
6061 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6062 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6063
1683e3ab
PE
6064 * xdisp.c (draw_row_with_mouse_face): Now static.
6065 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6066
de9c2632
PE
6067 * window.h (check_all_windows): Mark externally visible.
6068
2b96acb7
PE
6069 * window.c (window_deletion_count): Now static.
6070
6071 * undo.c: Make symbols static if they're not exported.
6072 (last_undo_buffer, last_boundary_position, pending_boundary):
6073 Now static.
6074
50436f33
PE
6075 * textprop.c (interval_insert_behind_hooks): Now static.
6076 (interval_insert_in_front_hooks): Likewise.
6077
64520e5c
PE
6078 * term.c: Make symbols static if they're not exported.
6079 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6080 (max_frame_lines, tty_set_terminal_modes):
6081 (tty_reset_terminal_modes, tty_turn_off_highlight):
6082 (get_tty_terminal): Now static.
6083 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6084 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6085 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6086 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6087 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6088
1fa53021
PE
6089 * sysdep.c: Make symbols static if they're not exported.
6090 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6091 Now static.
6092 (sigprocmask_set, full_mask): Remove; unused.
6093 (wait_debugging): Mark as visible.
6094 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6095 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6096
d4b43b22
PE
6097 * syntax.c (syntax_temp): Define only if !__GNUC__.
6098
b7c513d0
PE
6099 * sound.c (current_sound_device, current_sound): Now static.
6100
989b29ad
PE
6101 * search.c (searchbufs, searchbuf_head): Now static.
6102
13a55a78
PE
6103 * scroll.c (scroll_cost): Remove; unused.
6104 * dispextern.h (scroll_cost): Remove decl.
6105
de68a1fc
PE
6106 * region-cache.h (pp_cache): Mark as externally visible.
6107
40ccffa6
PE
6108 * process.c: Make symbols static if they're not exported.
6109 (process_tick, update_tick, create_process, chan_process):
6110 (Vprocess_alist, proc_buffered_char, datagram_access):
6111 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6112 (deactivate_process): Mark defn as static, as well as decl.
6113 * lisp.h (create_process): Remove decl.
6114 * process.h (chan_process, Vprocess_alist): Remove decls.
6115
ad64fc97
PE
6116 * print.c: Make symbols static if they're not exported.
6117 (print_depth, new_backquote_output, being_printed, print_buffer):
6118 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6119 (print_interval, print_number_index, initial_stderr_stream):
6120 Now static.
6121 * lisp.h (Fprinc): Remove decl.
6122 (debug_output_compilation_hack): Mark as externally visible.
6123
adddb265
PE
6124 * sysdep.c (croak): Move decl from here to syssignal.h.
6125 * syssignal.h (croak): Put it here, so the API can be checked when
6126 'croak' is called from dissociate_if_controlling_tty.
6127
1717ede2
PE
6128 * minibuf.c: Make symbols static if they're not exported.
6129 (minibuf_save_list, choose_minibuf_frame): Now static.
6130 * lisp.h (choose_minibuf_frame): Remove decl.
6131
fa5fb2bc
PE
6132 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6133
1e3890d1
PE
6134 * lread.c: Make symbols static if they're not exported.
6135 (read_objects, initial_obarray, oblookup_last_bucket_number):
6136 Now static.
6137 (make_symbol): Remove; unused.
6138 * lisp.h (initial_obarray, make_symbol): Remove decls.
6139
8a1414fa
PE
6140 * keyboard.c: Make symbols static if they're not exported.
6141 (single_kboard, recent_keys_index, total_keys, recent_keys):
6142 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6143 (this_single_command_key_start, echoing, last_auto_save):
6144 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6145 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6146 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6147 (Vlispy_mouse_stem, double_click_count):
6148 Now static.
6149 (force_auto_save_soon): Define only if SIGDANGER.
6150 (ignore_mouse_drag_p): Now static if
6151 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6152 (print_help): Remove; unused.
6153 (stop_character, last_timer_event): Mark as externally visible.
6154 * keyboard.h (ignore_mouse_drag_p): Declare only if
6155 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6156 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6157 * lisp.h (echoing): Remove decl.
6158 (force_auto_save_soon): Declare only if SIGDANGER.
6159 * xdisp.c (redisplay_window): Simplify code, to make it more
6160 obvious that ignore_mouse_drag_p is not accessed if !defined
6161 USE_GTK && !defined HAVE_NS.
6162
93ea6e8f
PE
6163 * intervals.c: Make symbols static if they're not exported.
6164 (merge_properties_sticky, merge_interval_right, delete_interval):
6165 Now static.
6166 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6167
77382fcc
PE
6168 * insdel.c: Make symbols static if they're not exported.
6169 However, leave prepare_to_modify_buffer alone. It's never
6170 called from outside this function, but that appears to be a bug.
6171 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6172 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6173 (adjust_after_replace_noundo): Remove; unused.
6174 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6175 (signal_before_change): Remove decls.
77382fcc 6176
9306c32e
PE
6177 * indent.c (val_compute_motion, val_vmotion): Now static.
6178
cd44d2eb
PE
6179 * image.c: Make symbols static if they're not exported.
6180 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6181 if USE_GTK.
6182 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6183 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6184
ad9a7a06
PE
6185 * fringe.c (standard_bitmaps): Now static.
6186 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6187
81626931
PE
6188 * frame.c: Make symbols static if they're not exported.
6189 (x_report_frame_params, make_terminal_frame): Now static.
6190 (get_frame_param): Now static, unless HAVE_NS.
6191 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6192 (x_get_resource_string): Remove; not used.
6193 * frame.h (make_terminal_frame, x_report_frame_params):
6194 (x_get_resource_string); Remove decls.
6195 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6196 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6197
239f9db9
PE
6198 * font.c, fontset.c: Make symbols static if they're not exported.
6199 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6200 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6201 * font.c (font_close_object): Now static.
6202 * font.h (font_close_object): Remove.
6203 * fontset.c (FONTSET_OBJLIST): Remove.
6204 (free_realized_fontset) #if-0 the body, which does nothing.
6205 (face_suitable_for_char_p): #if-0, as it's never called.
6206 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6207 * xfaces.c (face_at_string_position):
6208 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6209 since 0 is always ASCII.
6210
dfcf3579
PE
6211 * fns.c (weak_hash_tables): Now static.
6212
5045092b
PE
6213 * fileio.c: Make symbols static if they're not exported.
6214 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6215 (Vwrite_region_annotation_buffers): Now static.
6216
57a96f5c
PE
6217 * eval.c: Make symbols static if they're not exported.
6218 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6219 * lisp.h (backtrace_list): Remove decl.
6220
35f08c38
PE
6221 * emacs.c: Make symbols static if they're not exported.
6222 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6223 (fatal_error_code, fatal_error_signal_hook, standard_args):
6224 Now static.
6225 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6226 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6227 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6228 * lisp.h (fatal_error_signal_hook): Remove decl.
6229 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6230
f44bd759
PE
6231 * editfns.c: Move a (normally-unused) function to its only use.
6232 * editfns.c, lisp.h (get_operating_system_release): Remove.
6233 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6234 worth the hassle of breaking this out.
6235
b532497d
PE
6236 * xterm.c: Make symbols static if they're not exported.
6237 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6238 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6239 (x_destroy_window, x_delete_display):
6240 Now static.
6241 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6242 (x_mouse_leave): Remove; unused.
6243 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6244 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6245 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6246 Remove decls.
6247 (x_mouse_leave): Declare only if WINDOWSNT.
6248 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6249 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6250 USE_X_TOOLKIT.
6251
1675728f
PE
6252 * ftxfont.c: Make symbols static if they're not exported.
6253 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6254 HAVE_FREETYPE.
6255 * font.h (ftxfont_driver): Likewise.
6256
e4cebfca
PE
6257 * xfns.c: Make symbols static if they're not exported.
6258 (x_last_font_name, x_display_info_for_name):
6259 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6260 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6261 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6262 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6263 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6264 (last_show_tip_args): Now static.
6265 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6266 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6267 (x_screen_planes): Remove; unused.
6268 * dispextern.h (x_screen_planes): Remove decl.
6269
5bf46f05
PE
6270 * dispnew.c: Make symbols static if they're not exported.
6271 * dispextern.h (redraw_garbaged_frames, scrolling):
6272 (increment_row_positions): Remove.
6273 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6274 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6275 Now static.
6276 (redraw_garbaged_frames): Remove; unused.
6277
435f4c28
PE
6278 * xfaces.c: Make symbols static if they're not exported.
6279 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6280 Remove decls.
6281 * xterm.h (defined_color): Remove decls.
6282 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6283 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6284 (menu_face_changed_default, defined_color, free_realized_face):
6285 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6286 (ascii_face_of_lisp_face): Remove; unused.
6287
8524aef3
PE
6288 * xdisp.c: Make symbols static if they're not exported.
6289 * dispextern.h (scratch_glyph_row, window_box_edges):
6290 (glyph_to_pixel_coords, set_cursor_from_row):
6291 (get_next_display_element, set_iterator_to_next):
6292 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6293 (show_mouse_face): Remove decls
6294 * frame.h (message_buf_print): Likewise.
6295 * lisp.h (pop_message, set_message, check_point_in_composition):
6296 Likewise.
6297 * xterm.h (set_vertical_scroll_bar): Likewise.
6298 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6299 (message_buf_print, scratch_glyph_row, displayed_buffer):
6300 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6301 (get_next_display_element, show_mouse_face, window_box_edges):
6302 (frame_to_window_pixel_xy, check_point_in_composition):
6303 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6304 (glyph_to_pixel_coords): Remove; unused.
6305
16390cd2
PE
6306 * dired.c (file_name_completion): Now static.
6307
6308 * dbusbind.c (xd_in_read_queued_messages): Now static.
6309
a25f4dfa
PE
6310 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6311 * data.c (circular_list_error): Remove.
6312
14a9c8df
PE
6313 * commands.h (last_point_position, last_point_position_buffer):
6314 (last_point_position_window): Remove decls.
6315 * keyboard.c: Make these variables static.
6316
04f2d78b
CB
6317 * coding.h (coding, code_convert_region, encode_coding_gap):
6318 Remove decls.
74ab6df5
PE
6319 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6320 (iso_code_class, detect_coding, code_convert_region): Now static.
6321 (encode_coding_gap): Remove; unused.
6322
38dfbee1
PE
6323 * chartab.c (chartab_chars, chartab_bits): Now static.
6324
a2cb4e63
PE
6325 * charset.h (charset_iso_8859_1): Remove decl.
6326 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6327 Now static.
6328
127198fd
PE
6329 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6330 * ccl.c (Vccl_program_table): Now static.
6331 (check_ccl_update): Remove; unused.
6332
d85b608f
PE
6333 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6334 * category.h: ... from here.
6335 * category.c (check_category_table, set_category_set): Now static.
6336
31cd66f3
PE
6337 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6338 * lisp.h: Remove these decls.
6339
c358e587
PE
6340 * buffer.c (buffer_count): Remove unused var.
6341
e78aecca
PE
6342 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6343 so that it's not optimized away.
6344 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6345 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6346 exported only to the debugger.
6347
e192d7d3 6348 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6349 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6350
92470028
PE
6351 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6352 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6353 was inaccessible from Lisp.
6354 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6355 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6356
244ed907
PE
6357 alloc.c: Import and export fewer symbols, and remove unused items.
6358 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6359 is defined.
6360 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6361 it's not optimized away by whole-program optimization.
6362 (message_enable_multibyte, free_misc): Remove.
6363 (catchlist, handlerlist, mark_backtrace):
6364 Declare only if BYTE_MARK_STACK.
6365 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6366 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6367 (message_enable_multibyte): Remove decl.
6368 (free_misc, interval_free_list, float_block, float_block_index):
6369 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6370 (cons_free_list, last_marked_index):
6371 Now static.
6372 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6373 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6374 (mark_backtrace): Define only if BYTE_MARK_STACK.
6375 * xdisp.c (message_enable_multibyte): Now static.
6376
61c2b50e 6377 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6378 This makes it easier for human readers (and static analyzers)
6379 to see whether these variables are used from other modules.
6380 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6381 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6382 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6383 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6384 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6385 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6386 * xmenu.c, xselect.c:
6387 Declare Q* vars static if they are not used in other modules.
6388 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6389 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6390 Remove decls of unexported vars.
6391 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6392
95c82688
PE
6393 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6394
16a97296
PE
6395 Make Emacs functions such as Fatom 'static' by default.
6396 This makes it easier for human readers (and static analyzers)
6397 to see whether these functions can be called from other modules.
6398 DEFUN now defines a static function. To make the function external
6399 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6400 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6401 (Finit_image_library):
16a97296
PE
6402 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6403 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6404 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6405 Remove decls, since these functions are now static.
6406 (Funintern, Fget_internal_run_time): New decls, since these functions
6407 were already external.
95c82688 6408
16a97296
PE
6409 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6410 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6411 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6412 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6413 * keyboard.c, keymap.c, lread.c:
6414 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6415 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6416 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6417 Mark functions with DEFUE instead of DEFUN,
6418 if they are used in other modules.
6419 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6420 decls for now-static functions.
6421 * buffer.h (Fdelete_overlay): Remove decl.
6422 * callproc.c (Fgetenv_internal): Mark as internal.
6423 * composite.c (Fremove_list_of_text_properties): Remove decl.
6424 (Fcomposition_get_gstring): New forward static decl.
6425 * composite.h (Fcomposite_get_gstring): Remove decl.
6426 * dired.c (Ffile_attributes): New forward static decl.
6427 * doc.c (Fdocumntation_property): New forward static decl.
6428 * eval.c (Ffetch_bytecode): New forward static decl.
6429 (Funintern): Remove extern decl; now in .h file where it belongs.
6430 * fileio.c (Fmake_symbolic_link): New forward static decl.
6431 * image.c (Finit_image_library): New forward static decl.
6432 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6433 * intervals.h (Fprevious_property_change):
6434 (Fremove_list_of_text_properties): Remove decls.
6435 * keyboard.c (Fthis_command_keys): Remove decl.
6436 (Fcommand_execute): New forward static decl.
6437 * keymap.c (Flookup_key): New forward static decl.
6438 (Fcopy_keymap): Now static.
6439 * keymap.h (Flookup_key): Remove decl.
6440 * process.c (Fget_process): New forward static decl.
6441 (Fprocess_datagram_address): Mark as internal.
6442 * syntax.c (Fsyntax_table_p): New forward static decl.
6443 (skip_chars): Remove duplicate decl.
6444 * textprop.c (Fprevious_property_change): New forward static decl.
6445 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6446 Now internal.
6447 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6448 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6449
785bbd42
PE
6450 * editfns.c (Fformat): Remove unreachable code.
6451
8b913b57
AS
64522011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6453
6454 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6455 change. (Bug#8496)
6456
a6744a35
EZ
64572011-04-13 Eli Zaretskii <eliz@gnu.org>
6458
6459 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6460 when at ZV. (Bug#8487)
6461
e7974947
AS
64622011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6463
baad03f0
AS
6464 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6465 (Bug#8437)
6466 * keyboard.c (parse_tool_bar_item): Likewise.
6467 * sound.c (sound_cleanup, alsa_close): Likewise.
6468 * termcap.c (tgetent): Likewise.
6469 * xfns.c (x_default_font_parameter): Likewise.
6470 * xsettings.c (read_and_apply_settings): Likewise.
6471
e7974947
AS
6472 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6473 (overrun_check_free): Protoize.
6474
28272684
PE
64752011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6476
6477 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6478 since callers should never pass a negative size.
6479 Change the signature to match that of plain 'read' and 'write'; see
6480 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6481 * lisp.h: Update prototypes of emacs_write and emacs_read.
6482
11997c76
EZ
64832011-04-11 Eli Zaretskii <eliz@gnu.org>
6484
6485 * xdisp.c (redisplay_window): Don't try to determine the character
6486 position of the scroll margin if the window start point w->startp
e896f03c 6487 is outside the buffer's accessible region. (Bug#8468)
11997c76 6488
8a2cbd72
EZ
64892011-04-10 Eli Zaretskii <eliz@gnu.org>
6490
6491 Fix write-region and its subroutines for buffers > 2GB.
6492 * fileio.c (a_write, e_write): Modify declaration of arguments and
6493 local variables to support buffers larger than 2GB.
6494 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6495
6496 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6497 argument, local variables, and return value.
6498
6499 * lisp.h: Update prototypes of emacs_write and emacs_read.
6500
6501 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6502
4073e537 65032011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6504
1ebfdcb6
PE
6505 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6506
b2ded58d
PE
6507 Fix more problems found by GCC 4.6.0's static checks.
6508
7d66342c
PE
6509 * xdisp.c (vmessage): Use a better test for character truncation.
6510
bbf47d44
PE
6511 * charset.c (load_charset_map): <, not <=, for optimization,
6512 and to avoid potential problems with integer overflow.
9248994d 6513 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6514 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6515 * editfns.c (Fformat): Likewise.
1e69125e 6516 * syntax.c (skip_chars): Likewise.
3befa583 6517
e3019616
PE
6518 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6519 This also lets GCC 4.6.0 generate slightly better loop code.
6520
becfa255
PE
6521 * callint.c (Fcall_interactively): <, not <=, for optimization.
6522 (Fcall_interactively): Count the number of arguments produced,
6523 not the number of arguments given. This is simpler and lets GCC
6524 4.6.0 generate slightly better code.
6525
dae0cd48
PE
6526 * ftfont.c: Distingish more carefully between FcChar8 and char.
6527 The previous code passed unsigned char * to a functions like
6528 strlen and xstrcasecmp that expect char *, which does not
6529 conform to the C standard.
6530 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6531 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6532 char * when the C standard requires it.
6533
76032d70
PE
6534 * keyboard.c (read_char): Remove unused var.
6535
eb3f1cc8
PE
6536 * eval.c: Port to Windows vsnprintf (Bug#8435).
6537 Include <limits.h>.
6538 (SIZE_MAX): Define if the headers do not.
6539 (verror): Do not give up if vsnprintf returns a negative count.
6540 Instead, grow the buffer. This ports to Windows vsnprintf, which
6541 does not conform to C99. Problem reported by Eli Zaretskii.
6542 Also, simplify the allocation scheme, by avoiding the need for
6543 calling realloc, and removing the ALLOCATED variable.
6544
70476b54
PE
6545 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6546
12020a9e
PE
6547 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6548 But keep the doprint source code for now, as we might revamp it
6549 and use it again (Bug#8435).
ea6c7ae6
PE
6550 * lisp.h (doprnt): Remove.
6551 * Makefile.in (base_obj): Remove doprnt.o.
6552 * deps.mk (doprnt.o): Remove.
6553
5fdb398c
PE
6554 error: Print 32- and 64-bit integers portably (Bug#8435).
6555 Without this change, on typical 64-bit hosts error ("...%d...", N)
6556 was used to print both 32- and 64-bit integers N, which relied on
6557 undefined behavior.
6558 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6559 New macro.
6560 * lisp.h (error, verror): Mark as printf-like functions.
6561 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6562 Report overflow in size calculations when allocating printf buffer.
6563 Do not truncate output string at its first null byte.
6564 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6565 Truncate the output at a character boundary, since vsnprintf does not
6566 do that.
6567 * charset.c (check_iso_charset_parameter): Convert internal
6568 character to string before calling 'error', since %c now has the
6569 printf meaning.
6570 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6571 overflow when computing char to be passed to 'error'. Do not
6572 pass Lisp_Object to 'error'; pass the integer instead.
6573 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6574 formatted with plain %d.
6575
b189fa66
PE
6576 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6577
bff87ef0
PE
6578 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6579
7e2cac20
PE
6580 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6581
ce4d90b5
PE
6582 * xterm.c (x_catch_errors): Remove duplicate declaration.
6583
266c9547
PE
6584 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6585
79c49ad2
PE
6586 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6587
368f4090
JM
65882011-04-10 Jim Meyering <meyering@redhat.com>
6589
6590 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6591 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6592 return ssize_t not "int", and use size_t as the buffer length.
6593 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6594 * gnutls.h: Update declarations.
6595 * process.c (read_process_output): Use ssize_t, to match.
6596 (send_process): Likewise.
6597
a32d4040
CY
65982011-04-09 Chong Yidong <cyd@stupidchicken.com>
6599
6600 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6601
8546720e 66022011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6603
04f2d78b
CB
6604 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6605 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6606
8546720e
GM
6607 * xterm.c (handle_one_xevent):
6608 * xmenu.c (create_and_show_popup_menu):
6609 * xselect.c (x_decline_selection_request)
6610 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6611
0a2f5c1a 66122011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6613
6614 Fix some uses of `int' instead of EMACS_INT.
6615 * search.c (string_match_1, fast_string_match)
6616 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6617 (scan_buffer, find_next_newline_no_quit)
6618 (find_before_next_newline, search_command, Freplace_match)
6619 (Fmatch_data): Make some `int' variables be EMACS_INT.
6620
6621 * xdisp.c (display_count_lines): 3rd argument and return value now
6622 EMACS_INT. All callers changed.
6623 (pint2hrstr): Last argument is now EMACS_INT.
6624
6625 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6626 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6627 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6628 (decode_coding_utf_16, decode_coding_emacs_mule)
6629 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6630 (decode_coding_ccl, decode_coding_charset)
6631 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6632 (decode_coding_iso_2022, decode_coding_emacs_mule)
6633 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6634 <char_offset, last_offset>: Declare EMACS_INT.
6635 (encode_coding_utf_8, encode_coding_utf_16)
6636 (encode_coding_emacs_mule, encode_invocation_designation)
6637 (encode_designation_at_bol, encode_coding_iso_2022)
6638 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6639 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6640 Declare EMACS_INT.
6641 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6642 (encode_invocation_designation): Last argument P_NCHARS is now
6643 EMACS_INT.
6644 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6645 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6646
6647 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6648 All users changed.
6649
6650 * ccl.c (Fccl_execute_on_string): Declare some variables
6651 EMACS_INT.
6652
8546720e 66532011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6654
6655 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6656
4e19a977
CS
66572011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6658
6659 * process.c (Fformat_network_address): Doc fix.
6660
87302331
R
66612011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6662
6663 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6664
cbb59342
CY
66652011-04-08 Chong Yidong <cyd@stupidchicken.com>
6666
6667 * keyboard.c (read_char): Call Lisp function help-form-show,
6668 instead of using internal_with_output_to_temp_buffer.
6669 (Qhelp_form_show): New var.
e0d38eeb 6670 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6671
6672 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6673
6674 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6675
e67a13ab
CY
66762011-04-06 Chong Yidong <cyd@stupidchicken.com>
6677
04f2d78b
CB
6678 * process.c (Flist_processes): Remove to Lisp.
6679 (list_processes_1): Delete.
e67a13ab 6680
973f782d
EZ
66812011-04-06 Eli Zaretskii <eliz@gnu.org>
6682
7c106b1e
EZ
6683 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6684
973f782d
EZ
6685 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6686
41cf7d1a 66872011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6688
ca23cc88
PE
6689 Fix more problems found by GCC 4.6.0's static checks.
6690
f390e2d5
PE
6691 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6692
42eea0d0
PE
6693 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6694
b69769da 6695 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6696
f9541e84
PE
6697 * xdisp.c (vmessage): Mark as a printf-like function.
6698
13841b55
PE
6699 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6700
c136c10f
PE
6701 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6702
5e2d4a30
PE
6703 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6704 printf-like functions.
6705 (tiff_load): Add casts to remove these marks before passing them
6706 to system-supplied API.
6707
583f48b9
PE
6708 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6709
b25d760e
PE
6710 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6711 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6712 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6713 directly, rather than having caller test rule sign. This avoids
6714 some unnecessary tests.
6715 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6716 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6717 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6718
bc7b6697 6719 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6720 (xfont_open): Avoid unnecessary tests.
bc7b6697 6721
27ccc379
PE
6722 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6723
dcd5c89a
PE
6724 * composite.h, composite.c (composition_gstring_put_cache):
6725 Use EMACS_INT, not int, for length.
6726
b13a45c6
PE
6727 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6728 breaking out part of COMPOSITION_DECODE_RULE.
6729 (COMPOSITION_DECODE_RULE): Use it.
6730 * composite.c (get_composition_id): Remove unused local vars,
6731 by using the new macro.
6732
1e792e4d
PE
6733 * textprop.c (set_text_properties_1): Change while to do-while,
6734 since the condition is always true at first.
6735
dc6c6455 6736 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6737 (interval_deletion_adjustment): Return unsigned value.
6738 All uses changed.
dc6c6455 6739
aba7731a
PE
6740 * process.c (list_processes_1, create_pty, read_process_output):
6741 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6742 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6743 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6744 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6745 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6746
fdfc4bf3
PE
6747 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6748
fca8fe46 6749 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6750 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6751
06a0259a 6752 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6753 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6754 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6755
e7b9e80f
PE
6756 * print.c (print_error_message): Avoid int overflow.
6757
56201685
PE
6758 * font.c (font_list_entities): Redo for clarity,
6759 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6760
78834453 6761 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6762 (font_score): Avoid potential overflow in diff calculation.
78834453 6763
0bc0b309 6764 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6765 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6766
e610eaca
PE
6767 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6768
b895abce
PE
6769 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6770 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6771 can always succeed if overflow has undefined behavior.
6772
1f1d9321 6773 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6774 (wordify): Omit three unnecessary tests.
1f1d9321 6775
c59478bc
PE
6776 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6777 All callers changed. This avoids the need for an unused var.
6778
79b73827
PE
6779 * casefiddle.c (casify_region): Remove var that is set but not used.
6780
a4db5dfe
PE
6781 * dired.c (file_name_completion): Remove var that is set but not used.
6782
43aae36e
PE
6783 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6784
2a47c44d 6785 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6786 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6787
a37c69bf
PE
6788 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6789 Check for integer overflow on size calculations.
6790
328ab8e7
PE
6791 * buffer.c (Fprevious_overlay_change): Remove var that is set
6792 but not used.
6793
e5a2a5cb
PE
6794 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6795 Remove vars that are set but not used.
8d84a6eb 6796 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6797 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6798
a60e5f68
PE
6799 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6800
f661cb61 6801 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6802 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6803
f0397f5a
PE
6804 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6805 that are set but not used.
6806
8664db06 6807 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6808 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6809
6abdaa4a
PE
6810 * xselect.c (x_get_local_selection, x_handle_property_notify):
6811 Remove vars that are set but not used.
6812
0ce7538d 6813 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6814 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6815
9ae848fc
PE
6816 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6817 Remove var that is set but not used.
0b918413
PE
6818 (scroll_bar_windows_size): Now size_t, not int.
6819 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6820 Check for overflow.
9ae848fc 6821
a5a62657
PE
6822 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6823 (map_tty_color) [!defined MSDOS]: Likewise.
6824
5c5cdd39
PE
6825 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6826
66ebf983
PE
6827 * coding.c: Remove vars that are set but not used.
6828 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6829 All callers changed.
6830 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6831 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6832 (decode_coding_charset): Remove vars that are set but not used.
6833
1be4d761
PE
6834 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6835 that is set but not used.
6836
47553fa8
PE
6837 * print.c (print_object): Remove var that is set but not used.
6838
1f7196bf 6839 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6840 The gnulib version avoids calling malloc in the usual case,
6841 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6842 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6843 * filelock.c (current_lock_owner): Likewise.
6844 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6845 * sysdep.c: Include allocator.h, careadlinkat.h.
6846 (emacs_no_realloc_allocator): New static constant.
6847 (emacs_readlink): New function.
fdb61804
PE
6848 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6849 ../lib/careadlinkat.h.
d1fdcab7 6850
f84c17c7
SM
68512011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6852
6853 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6854 first non-nil return value).
6855
ef3862ad
JD
68562011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6857
6858 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6859 if not defined (Bug#8403).
6860
376a7006
JB
68612011-04-02 Juanma Barranquero <lekktu@gmail.com>
6862
6863 * xdisp.c (display_count_lines): Remove parameter `start',
6864 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6865 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6866 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6867 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6868 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6869 and thereabouts. All callers changed.
6870 (get_per_char_metric): Remove parameter `f', unused since
6871 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6872
6ca3801d
JM
68732011-04-02 Jim Meyering <meyering@redhat.com>
6874
6875 do not dereference NULL upon failed strdup
6876 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6877 (ns_get_family): Likewise.
6878
d8e2b5ba
JB
68792011-04-02 Juanma Barranquero <lekktu@gmail.com>
6880
6881 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6882
8c74fcbd
JD
68832011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6884
6885 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6886 later (Bug#8403).
6887
7200d79c
SM
68882011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6889
03408648 6890 Add lexical binding.
7200d79c 6891
03408648
SM
6892 * window.c (Ftemp_output_buffer_show): New fun.
6893 (Fsave_window_excursion):
6894 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6895
6896 * lread.c (lisp_file_lexically_bound_p): New function.
6897 (Fload): Bind Qlexical_binding.
6898 (readevalloop): Remove `evalfun' arg.
6899 Bind Qinternal_interpreter_environment.
6900 (Feval_buffer): Bind Qlexical_binding.
6901 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6902 Mark as dynamic.
6903 (syms_of_lread): Declare `lexical-binding'.
6904
6905 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6906
6907 * keyboard.c (eval_dyn): New fun.
6908 (menu_item_eval_property): Use it.
ca105506
SM
6909
6910 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6911
03408648
SM
6912 * fns.c (concat, mapcar1): Accept byte-code-functions.
6913
6914 * eval.c (Fsetq): Handle lexical vars.
6915 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6916 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6917 (FletX, Flet): Obey lexical binding.
6918 (Fcommandp): Handle closures.
6919 (Feval): New `lexical' arg.
6920 (eval_sub): New function extracted from Feval. Use it almost
6921 everywhere where Feval was used. Look up vars in lexical env.
6922 Handle closures.
6923 (Ffunctionp): Move from subr.el.
6924 (Ffuncall): Handle closures.
6925 (apply_lambda): Remove `eval_flags'.
6926 (funcall_lambda): Handle closures and new byte-code-functions.
6927 (Fspecial_variable_p): New function.
6928 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6929 but without exporting it to Lisp.
23aba0ea 6930
23aba0ea 6931 * doc.c (Fdocumentation, store_function_docstring):
03408648 6932 * data.c (Finteractive_form): Handle closures.
23aba0ea 6933
03408648
SM
6934 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6935 interactive spec.
ba83908c 6936
04f2d78b
CB
6937 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6938 New byte-codes.
03408648
SM
6939 (exec_byte_code): New function extracted from Fbyte_code to handle new
6940 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6941
03408648 6942 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6943
03408648 6944 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6945
e2abce01
JB
69462011-03-31 Juanma Barranquero <lekktu@gmail.com>
6947
6948 * xdisp.c (redisplay_internal): Fix prototype.
6949
63696a73 69502011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6951
63696a73 6952 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6953 (try_scrolling): Use it when setting scroll_limit.
6954 Limit scrolling to 100 screen lines.
63696a73
EZ
6955 (redisplay_window): Even when falling back on "recentering",
6956 position point in the window according to scroll-conservatively,
6957 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6958
6959 (try_scrolling): When point is above the window, allow searching
6960 as far as scroll_max, or one screenful, to compute vertical
6961 distance from PT to the scroll margin position. This prevents
6962 try_scrolling from unnecessarily failing when
6963 scroll-conservatively is set to a value slightly larger than the
6964 window height. Clean up the case of PT below the margin at bottom
6965 of window: scroll_max can no longer be INT_MAX. When aggressive
6966 scrolling is in use, don't let point enter the opposite scroll
6967 margin as result of the scroll.
6968 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6969 threshold of 100 lines for never-recentering scrolling.
6970
e4cc2dfc
JB
69712011-03-31 Juanma Barranquero <lekktu@gmail.com>
6972
6973 * dispextern.h (move_it_by_lines):
6974 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6975 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6976 (message_log_check_duplicate): Remove parameters `prev_bol' and
6977 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6978 (redisplay_internal): Remove parameter `preserve_echo_area',
6979 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6980
6981 * indent.c (Fvertical_motion):
6982 * window.c (window_scroll_pixel_based, Frecenter):
6983 Don't pass `need_y_p' to `move_it_by_lines'.
6984
1c470562
SM
69852011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6986
44f230aa
SM
6987 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6988 steal a few bits to be more compact.
6989 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6990 Remove unneeded casts.
6991
1c470562
SM
6992 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6993
888adce9
ZK
69942011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6995
6996 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6997 binding" message (bug#7967).
6998
f838ed7b
PE
69992011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7000
77861b95
PE
7001 Fix more problems found by GCC 4.6.0's static checks.
7002
de6dbc14
PE
7003 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7004 Remove unused local var.
7005
f838ed7b
PE
7006 * editfns.c (Fmessage_box): Remove unused local var.
7007
792c7b2b
PE
7008 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7009 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7010 Omit unused local vars.
c499e557 7011 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7012 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7013 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7014 Omit unused local var.
7015
ba0165e1
PE
7016 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7017 Don't assume string length fits in int.
32ad8845 7018 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7019 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7020
3c59b4c9
PE
7021 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7022 instead of alloca (Bug#8344).
7023
a3eed478 7024 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7025 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7026
eb4d412d
PE
7027 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7028
1658b401
PE
7029 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7030 concerns.
7031
7032 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7033
7034 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7035
9a2c6e05
PE
7036 * keyboard.c (syms_of_keyboard): Use the same style as later
7037 in this function when indexing through an array. This also
7038 works around GCC bug 48267.
7039
03d0a109
PE
7040 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7041
44f730c8
PE
7042 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7043
fe75f926
PE
7044 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7045 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7046
ffa8c828
PE
7047 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7048 This avoids undefined behavior on integer overflow, and is a bit
7049 more convenient anyway since it is compared to a size_t variable.
7050
c5101a77
PE
7051 Variadic C functions now count arguments with size_t, not int.
7052 This avoids an unnecessary limitation on 64-bit machines, which
7053 caused (substring ...) to crash on large vectors (Bug#8344).
7054 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7055 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7056 All variadic functions and their callers changed accordingly.
c5101a77
PE
7057 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7058 * data.c (arith_driver, float_arith_driver): Likewise.
7059 * editfns.c (general_insert_function): Likewise.
7060 * eval.c (struct backtrace.nargs, interactive_p)
7061 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7062 (funcall_lambda, mark_backtrace): Likewise.
7063 * fns.c (concat): Likewise.
7064 * frame.c (x_set_frame_parameters): Likewise.
7065 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7066 0 if not found, not -1. All callers changed.
7067
dd3f25f7
PE
7068 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7069 (stack_copy_size): Now size_t, not int.
7070 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7071
461c2ab9
JB
70722011-03-28 Juanma Barranquero <lekktu@gmail.com>
7073
7074 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7075 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7076 All callers changed.
7077
7078 * lisp.h (multibyte_char_to_unibyte):
7079 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7080 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7081 * character.h (CHAR_TO_BYTE8):
7082 * cmds.c (internal_self_insert):
7083 * editfns.c (general_insert_function):
7084 * keymap.c (push_key_description):
7085 * search.c (Freplace_match):
7086 * xdisp.c (message_dolog, set_message_1): All callers changed.
7087
f6d62986
SM
70882011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7089
7090 * keyboard.c (safe_run_hook_funcall): New function.
7091 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7092 don't set the hook to nil, but remove the offending function instead.
7093 (Qcommand_hook_internal): Remove, unused.
7094 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7095 Vcommand_hook_internal.
7096
7097 * eval.c (enum run_hooks_condition): Remove.
7098 (funcall_nil, funcall_not): New functions.
7099 (run_hook_with_args): Call each function through a `funcall' argument.
7100 Remove `cond' argument, now redundant.
7101 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7102 (Frun_hook_with_args_until_failure): Adjust accordingly.
7103 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7104
1db5b1ad
JB
71052011-03-28 Juanma Barranquero <lekktu@gmail.com>
7106
7107 * dispextern.h (string_buffer_position): Remove declaration.
7108
7109 * print.c (strout): Remove parameter `multibyte', unused since
7110 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7111
7112 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7113 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7114 All callers changed.
7115
7116 * w32.c (_wsa_errlist): Use braces for struct initializers.
7117
7118 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7119 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7120 All callers changed.
7121 (string_buffer_position): Likewise. Also, make static (it's never
7122 used outside xdisp.c).
7123 (cursor_row_p): Remove parameter `w', unused since
7124 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7125 (decode_mode_spec): Remove parameter `precision', introduced during
7126 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7127 All callers changed.
7128
5ffb62aa
JD
71292011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7130
7131 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7132
461c2ab9 71332011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7134
7135 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7136 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7137 (ns_update_auto_hide_menu_bar): New functions.
7138 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7139 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7140 ns_constrain_all_frames.
7141 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7142 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7143
5c380ffb
JD
71442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7145
7146 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7147
9af30bdf
GM
71482011-03-27 Glenn Morris <rgm@gnu.org>
7149
7150 * syssignal.h: Replace RETSIGTYPE with void.
7151 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7152 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7153 Replace SIGTYPE with void everywhere.
7154 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7155 * s/template.h (SIGTYPE): Remove commented out definition.
7156
e2abce01
JB
71572011-03-26 Eli Zaretskii <eliz@gnu.org>
7158
7159 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7160 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7161
f868cd8a
JB
71622011-03-26 Juanma Barranquero <lekktu@gmail.com>
7163
59eb0929
JB
7164 * w32.c (read_unc_volume): Use parameter `henum', instead of
7165 global variable `wget_enum_handle'.
7166
7167 * keymap.c (describe_vector): Remove parameters `indices' and
7168 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7169 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7170
f868cd8a
JB
7171 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7172
7173 * keyboard.c (timer_check): Remove parameter `do_it_now',
7174 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7175 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7176 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7177
7178 * keyboard.c (read_char):
7179 * w32menu.c (w32_menu_display_help):
7180 * xmenu.c (show_help_event, menu_help_callback):
7181 Adjust calls to `show_help_echo'.
7182
7183 * gtkutil.c (xg_maybe_add_timer):
7184 * keyboard.c (readable_events):
7185 * process.c (wait_reading_process_output):
7186 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7187
7188 * insdel.c (adjust_markers_gap_motion):
7189 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7190 (gap_left, gap_right): Don't call it.
7191
2ecf6fdb
CY
71922011-03-25 Chong Yidong <cyd@stupidchicken.com>
7193
7194 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7195 incurred during fontification.
7196
6b1f9ba4
JB
71972011-03-25 Juanma Barranquero <lekktu@gmail.com>
7198
7199 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7200 (DEFVAR_PER_BUFFER): Don't pass it.
7201
7202 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7203 (scrolling_window): Don't pass it.
7204
0f4a96b5
JB
72052011-03-25 Juanma Barranquero <lekktu@gmail.com>
7206
7207 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7208
7209 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7210 and `suffix'.
7211 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7212 of variables specific to SELinux and computation of `encoded_absname'.
7213
7214 * image.c (XPutPixel): Remove unused variable `height'.
7215
7216 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7217
7218 * unexw32.c (get_section_info): Remove unused variable `section'.
7219
7220 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7221 (system_process_attributes): Remove unused variable `sess'.
7222 (sys_read): Remove unused variable `err'.
7223
7224 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7225 (w32_wnd_proc): Remove unused variable `isdead'.
7226 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7227 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7228 (x_create_tip_frame): Remove unused variable `tem'.
7229
7230 * w32inevt.c (w32_console_read_socket):
7231 Remove unused variable `no_events'.
7232
7233 * w32term.c (x_draw_composite_glyph_string_foreground):
7234 Remove unused variable `width'.
7235
1149507c
JB
72362011-03-24 Juanma Barranquero <lekktu@gmail.com>
7237
7238 * w32term.c (x_set_glyph_string_clipping):
7239 Don't pass uninitialized region to CombineRgn.
7240
9c88f339
JB
72412011-03-23 Juanma Barranquero <lekktu@gmail.com>
7242
7243 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7244 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7245 (Fx_close_connection): Remove unused variable `i'.
7246
7247 * w32font.c (w32font_draw): Return number of glyphs.
7248 (w32font_open_internal): Remove unused variable `i'.
7249 (w32font_driver): Add missing initializer.
7250
7251 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7252 (fill_in_menu): Remove unused variable `items_added'.
7253
7254 * w32term.c (last_mouse_press_frame): Remove static global variable.
7255 (w32_clip_to_row): Remove unused variable `f'.
7256 (x_delete_terminal): Remove unused variable `i'.
7257
7258 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7259 (NOTHING): Remove unused static global variable.
7260 (uniscribe_check_otf): Remove unused variable `table'.
7261 (uniscribe_font_driver): Add missing initializers.
7262
dee091a3
JD
72632011-03-23 Julien Danjou <julien@danjou.info>
7264
7265 * term.c (Fsuspend_tty, Fresume_tty):
7266 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7267 * window.c (temp_output_buffer_show):
7268 * insdel.c (signal_before_change):
7269 * frame.c (Fhandle_switch_frame):
7270 * fileio.c (Fdo_auto_save):
7271 * emacs.c (Fkill_emacs):
7272 * editfns.c (save_excursion_restore):
7273 * cmds.c (internal_self_insert):
7274 * callint.c (Fcall_interactively):
7275 * buffer.c (Fkill_all_local_variables):
7276 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7277 Use Frun_hooks.
0f4a96b5 7278 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7279 unconditionnaly since it does the check itself.
7280
2c520ab5 72812011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7282
c9c49752
PE
7283 Fix more problems found by GCC 4.5.2's static checks.
7284
8abc3f12
PE
7285 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7286 the first time through the loop, since we know p0 < p1 then.
7287 This also avoids a gcc -Wstrict-overflow warning.
7288
a2d26660
PE
7289 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7290 leading to a memory leak, possible in functions like
7291 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7292 of objects (Bug#8318).
a2d26660 7293
916c72e9
PE
7294 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7295 that could (at least in theory) be that large.
7296
19ab8a18
PE
7297 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7298 This is less likely to overflow, and avoids undefined behavior if
7299 overflow does occur. All callers changed. Use strtoul to scan
7300 for the unsigned long integer.
b7cbbd6f
PE
7301 (pint2hrstr): Simplify and tune code slightly.
7302 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7303
f0641eff
PE
7304 * scroll.c (do_scrolling): Work around GCC bug 48228.
7305 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7306
7f650bb9
PE
7307 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7308 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7309 (validate_x_resource_name): Simplify count usage.
7310 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7311
37dd57d1
PE
7312 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7313 fail (Bug#8306).
81e56e61 7314
699979fc 7315 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7316
401bf9b4
PE
7317 * process.c (Fmake_network_process): Use socklen_t, not int,
7318 where POSIX says socklen_t is required in portable programs.
7319 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7320 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7321 (Fmake_network_process, server_accept_connection):
7322 (wait_reading_process_output, read_process_output):
7323 Likewise.
7324
b93aacde
PE
7325 * process.c: Rename or move locals to avoid shadowing.
7326 (list_processes_1, Fmake_network_process):
7327 (read_process_output_error_handler, exec_sentinel_error_handler):
7328 Rename or move locals.
4dc343ee 7329 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7330 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7331 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7332 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7333 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7334
af8a867c 7335 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7336 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7337 Include tparam.h instead, since it declares them.
af8a867c
PE
7338 * cm.h (PC): Remove extern decl; tparam.h now does this.
7339 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7340 * terminfo.c: Include tparam.h, to check interfaces.
7341 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7342 (tparam): Adjust signature to match interface in tparam.h;
7343 this removes some undefined behavior. Check that outstring and len
7344 are zero, which they always are with Emacs.
7345 * tparam.h (PC, BC, UP): New extern decls.
7346
0248044d 7347 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7348 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7349
8ff096c1 7350 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7351 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7352 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7353 (ftfont_list): Remove unused local.
49eaafba
PE
7354 (get_adstyle_property, ftfont_pattern_entity):
7355 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7356 Rename locals to avoid shadowing.
8ff096c1 7357
e2be39f6
PE
7358 * xfont.c (xfont_list_family): Mark var as initialized.
7359
c9735e30
PE
7360 * xml.c (make_dom): Now static.
7361
8f5201ae
PE
7362 * composite.c (composition_compute_stop_pos): Rename local to
7363 avoid shadowing.
b246f932
PE
7364 (composition_reseat_it): Remove unused locals.
7365 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7366 (composition_update_it): Mark var as initialized.
11b61122
PE
7367 (find_automatic_composition): Mark vars as initialized,
7368 with a FIXME (Bug#8290).
8f5201ae 7369
760fbc2c
PE
7370 character.h: Rename locals to avoid shadowing.
7371 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7372 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7373 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7374 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7375 to avoid shadowing.
7376
ff08eb85
PE
7377 * textprop.c (property_change_between_p): Remove; unused.
7378
fc7bf025
PE
7379 * intervals.c (interval_start_pos): Now static.
7380
235d7abc
PE
7381 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7382
44f230aa
SM
7383 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7384 Rename locals to avoid shadowing.
3e7d6594 7385
50060332
PE
7386 * sound.c (wav_play, au_play, Fplay_sound_internal):
7387 Fix pointer signedness.
d01f234b 7388 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7389 (wav_play): Initialize a variable to 0, to prevent undefined
7390 behavior (Bug#8278).
50060332 7391
c4fc4e30
PE
7392 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7393
918436ed
PE
7394 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7395
c939f91b
PE
7396 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7397 clobbering (Bug#8298).
b9c7f648
PE
7398 * sysdep.c (sys_subshell): Likewise.
7399 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7400
6bd8c144
PE
7401 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7402 This should get cleaned up, so that child_setup has the
7403 same signature on all platforms.
7404
7710357c 7405 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7406 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7407
c59da222
CY
74082011-03-22 Chong Yidong <cyd@stupidchicken.com>
7409
7410 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7411 not to be necessary, and produces flickering.
7412
66b87493
GM
74132011-03-20 Glenn Morris <rgm@gnu.org>
7414
7415 * config.in: Remove file.
7416
45b6f6d5
JB
74172011-03-20 Juanma Barranquero <lekktu@gmail.com>
7418
7419 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7420 are now in src/globals.h.
7421 (syms_of_minibuf): Remove spurious & from previous change.
7422
3ec03f7e
LL
74232011-03-20 Leo <sdl.web@gmail.com>
7424
7425 * minibuf.c (completing-read-function): New variable.
7426 (completing-read-default): Rename from completing-read.
7427 (completing-read): Call completing-read-function.
7428
b14e3e21
CY
74292011-03-19 Juanma Barranquero <lekktu@gmail.com>
7430
7431 * xfaces.c (Fx_load_color_file):
7432 Read color file from absolute filename (bug#8250).
7433
f2b726e6
JB
74342011-03-19 Juanma Barranquero <lekktu@gmail.com>
7435
7436 * makefile.w32-in: Update dependencies.
7437
09f6ff02
EZ
74382011-03-17 Eli Zaretskii <eliz@gnu.org>
7439
7440 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7441
29a6015a
PE
74422011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7443
a3a6c54e
PE
7444 Fix more problems found by GCC 4.5.2's static checks.
7445
b766f867
PE
7446 * process.c (make_serial_process_unwind, send_process_trap):
7447 (sigchld_handler): Now static.
7448
be02381c
PE
7449 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7450 That way, the code declares only the vars that it needs.
7451 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7452 * s/cygwin.h (PTY_ITERATION): Likewise.
7453 * s/darwin.h (PTY_ITERATION): Likewise.
7454 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7455
57048744
PE
7456 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7457 * process.c (allocate_pty): Don't declare stb unless it's needed.
7458
7914961c 7459 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7460 (CONSTANTLIM): Remove; unused.
7461 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7462 Define only if needed.
7914961c 7463
b3967b18
PE
7464 * unexelf.c (unexec): Name an expression,
7465 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7466 Use a different way to cause a compilation error if anyone uses
7467 n rather than nn, a way that does not involve shadowing.
73366a00 7468 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7469
29a6015a
PE
7470 * deps.mk (unexalpha.o): Remove; unused.
7471
43cfc33e 7472 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7473 * unexec.h: New file.
ce701a33
PE
7474 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7475 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7476 Depend on unexec.h.
7477 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7478 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7479 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7480 Change as necessary to match prototype in unexec.h.
ce701a33 7481
01f44d5a
PE
7482 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7483 shadowing.
4f63c6bb 7484 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7485
a6670b0b
PE
7486 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7487 Rename locals to avoid shadowing.
7488
cef2010d 7489 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7490 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7491
d4d7173a
PE
7492 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7493
f08b802a
PE
7494 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7495 warning when compiling print.c.
7496
3ddb0639
PE
7497 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7498 instead of using an uninitialized var.
5ad03b97 7499 (font_sort_entities): Mark var as initialized.
3ddb0639 7500
170a2692
PE
7501 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7502
e663c700
PE
7503 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7504 pointers to constants.
89bc529a 7505 (font_parse_fcname): Remove unused vars.
7b81e2d0 7506 (font_delete_unmatched): Now static.
ea838e10 7507 (font_get_spec): Remove; unused.
13a547c6
PE
7508 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7509 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7510 Rename or move locals to avoid shadowing.
e663c700 7511
2a80c887 7512 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7513 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7514
1384fa33 7515 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7516 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7517
8b2c52e9
PE
7518 * alloc.c (mark_backtrace): Move decl from here ...
7519 * lisp.h: ... to here, so that it can be checked.
7520
475545b5 7521 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7522 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7523 (lisp_indirect_variable): Name an expression,
7524 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7525 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7526
b1349114 7527 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7528 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7529 Use const pointer when appropriate.
b1349114 7530
a2928364
PE
7531 * lisp.h (get_system_name, get_operating_system_release):
7532 Move decls here, to check interfaces.
7533 * process.c (get_operating_system_release): Move decl to lisp.h.
7534 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7535 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7536 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7537 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7538 (Fformat_time_string, Fencode_time, Finsert_char):
7539 (Ftranslate_region_internal, Fformat):
7540 Rename or remove local vars to avoid shadowing.
9710023e 7541 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7542
a415e694
PE
7543 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7544 avoid shadowing.
7545
8ef4622d
PE
7546 * lisp.h (eassert): Check that the argument compiles, even if
7547 ENABLE_CHECKING is not defined.
7548
946f9a5b
PE
7549 * data.c (Findirect_variable): Name an expression, to avoid
7550 gcc -Wbad-function-cast warning.
112396d6 7551 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7552 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7553 (Fmake_variable_buffer_local, Fmake_local_variable):
7554 Mark variables as initialized.
52746918 7555 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7556
e5aab7e7 7557 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7558 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7559 Rename locals to avoid shadowing.
dff45157
PE
7560 (mark_stack): Move local variables into the #ifdef region where
7561 they're used.
7bc26fdb
PE
7562 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7563 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7564 needed otherwise.
7565 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7566 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7567 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7568
e5aab7e7
PE
7569 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7570 avoids undefined behavior in theory.
7571
4da60324
PE
7572 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7573
88043301
PE
7574 Use functions, not macros, for up- and down-casing (Bug#8254).
7575 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7576 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7577 to use the following functions instead of these macros.
7578 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7579 EMACS_INT, since callers assume the returned value fits in int.
7580 (upcase1): Likewise, for UPCASE_TABLE.
7581 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7582 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7583 the race-condition problem in the old DOWNCASE.
88043301 7584
19ed5445
PE
7585 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7586 Rename locals to avoid shadowing.
7587 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7588 (regex_compile, re_search_2, re_match_2_internal):
7589 Remove unused local vars.
952db0d7
PE
7590 (FREE_VAR): Rewrite so as not to use empty "else",
7591 which gcc can warn about.
da053e48 7592 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7593 (RETALLOC_IF): Define only if needed.
7594 (WORDCHAR_P): Likewise. This one is never needed, but is used
7595 only in a comment talking about a compiler bug, so put inside
7596 the #if 0 of that comment.
7597 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7598 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7599 Remove; unused.
19ed5445 7600
1f3561e4 7601 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7602 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7603 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7604
ded6f8f7
PE
7605 * search.c (simple_search): Remove unused var.
7606
dbd37a95
PE
7607 * dired.c (compile_pattern): Move decl from here ...
7608 * lisp.h: ... to here, so that it can be checked.
7609 (struct re_registers): New forward decl.
7610
7e47afad
PE
7611 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7612
85f24f61
PE
7613 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7614 All uses changed.
7615 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7616 Rename locals to avoid shadowing.
5671df8f 7617 (Fvertical_motion): Mark locals as initialized.
85f24f61 7618
181aa2be 7619 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7620 (casify_region): Mark local as initialized.
181aa2be 7621
930d429c
PE
7622 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7623
7082eac6
PE
7624 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7625 New macros, so that the caller can use some names other than
7626 gcpro1, gcpro2, etc.
7627 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7628 of the new macros.
7629 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7630 argument, for consistency with GCPRO2_VAR, etc: it is now the
7631 prefix of the variable, not the variable itself. All uses
7632 changed.
38b2c076
PE
7633 * dired.c (directory_files_internal, file_name_completion):
7634 Rename locals to avoid shadowing.
7635
15206ed9
PE
7636 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7637 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7638 dired.c's scmp function, had undefined behavior.
7639 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7640 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7641 * buffer.h: ... to here, because these macros use current_buffer,
7642 and the new implementation with inline functions needs to have
7643 current_buffer in scope now, rather than later when the macros
7644 are used.
7645 (downcase, upcase1): New static inline functions.
7646 (DOWNCASE, UPCASE1): Reimplement using these functions.
7647 This avoids undefined behavior in expressions like
7648 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7649 from race conditions in accessing the global variables
7650 case_temp1 and case_temp2.
7651 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7652 * lisp.h (case_temp1, case_temp2): Remove their decls.
7653 * character.h (ASCII_CHAR_P): Move from here ...
7654 * lisp.h: ... to here, so that the inline functions mentioned
7655 above can use them.
7656
4a6bea26
PE
7657 * dired.c (directory_files_internal_unwind): Now static.
7658
f14b7e14
PE
7659 * fileio.c (file_name_as_directory, directory_file_name):
7660 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7661 Now static.
2893f146
PE
7662 (file_name_as_directory): Use const pointers when appropriate.
7663 (Fexpand_file_name): Likewise. In particular, newdir might
7664 point at constant storage, so make it a const pointer.
fd4ead52 7665 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7666 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7667 signedness issues.
f839df0c
PE
7668 (Fset_file_times, Finsert_file_contents, auto_save_error):
7669 Rename locals to avoid shadowing.
f14b7e14 7670
5716756e 7671 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7672 (Ftry_completion, Fall_completions): Rename or remove locals
7673 to avoid shadowing.
5716756e 7674
b4c3046a
PE
7675 * marker.c (bytepos_to_charpos): Remove; unused.
7676
b45db522
PE
7677 * lisp.h (verify_bytepos, count_markers): New decls,
7678 so that gcc does not warn that these functions aren't declared.
7679
85876d07
PE
7680 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7681 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7682 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7683 (copy_text): Remove unused local var.
85876d07 7684
03d78a21 7685 * filelock.c (within_one_second): Now static.
b3dd38ab 7686 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7687
5df8f01b
PE
7688 * buffer.c (fix_overlays_before): Mark locals as initialized.
7689 (fix_start_end_in_overlays): Likewise. This function should be
7690 simplified by using pointers-to-pointers, but that's a different
7691 matter.
b1d876f1 7692 (switch_to_buffer_1): Now static.
8f54f30a
PE
7693 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7694 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7695
a70072c9 7696 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7697 Fix pointer signedness issue.
edced198
PE
7698 (sys_subshell): Mark local as volatile if checking for lint,
7699 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7700 (MAXPATHLEN): Define only if needed.
a70072c9 7701
a0977c44
PE
7702 * process.c (serial_open, serial_configure): Move decls from here ...
7703 * systty.h: ... to here, so that they can be checked.
7704
a884fdcc
PE
7705 * fns.c (get_random, seed_random): Move extern decls from here ...
7706 * lisp.h: ... to here, so that they can be checked.
7707
604efe86 7708 * sysdep.c (reset_io): Now static.
b8950c94 7709 (wait_for_termination_signal): Remove; unused.
604efe86 7710
38fc62d9
PE
7711 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7712 (copy_keymap_item, append_key, push_text_char_description):
7713 Now static.
1004a21a 7714 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7715 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7716 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7717 (describe_map_tree):
7718 Rename locals to avoid shadowing.
38fc62d9 7719
2f2650da
PE
7720 * keyboard.c: Declare functions static if they are not used elsewhere.
7721 (echo_char, echo_dash, cmd_error, top_level_2):
7722 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7723 (read_char, kbd_buffer_get_event, make_lispy_position):
7724 (make_lispy_event, make_lispy_movement, apply_modifiers):
7725 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7726 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7727 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7728 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7729 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7730
a053e86c 7731 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7732 (mark_kboards): Move decl here ...
7733 * alloc.c (mark_kboards): ... from here.
a053e86c 7734
4752793e
PE
7735 * lisp.h (force_auto_save_soon): New decl.
7736
74f10ca7 7737 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7738 (DEFINE_DUMMY_FUNCTION): New macro.
7739 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7740 Use it.
c03cd23f
PE
7741 (main): Add casts to avoid warnings
7742 if GCC considers string literals to be constants.
74f10ca7 7743
022e70d4
PE
7744 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7745
59d6fe83
PE
7746 * dbusbind.c: Pointer signedness fixes.
7747 (xd_signature, xd_append_arg, xd_initialize):
7748 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7749 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7750 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7751 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7752
78320123
PE
7753 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7754 if GCC considers string literals to be constants.
49cebcca 7755 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7756
35ac2a97
SM
77572011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7758
fb103ca9
SM
7759 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7760 (print_preprocess, print_object): New macro to fix last change.
7761
35ac2a97
SM
7762 * print.c (print_preprocess): Don't forget font objects.
7763
62973b41
JB
77642011-03-16 Juanma Barranquero <lekktu@gmail.com>
7765
7766 * emacs.c (USAGE3): Doc fixes.
7767
0e48bb22
AS
77682011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7769
7770 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7771 structure.
7772
7684e57b
JB
77732011-03-14 Juanma Barranquero <lekktu@gmail.com>
7774
7775 * lisp.h (VWindow_system, Qfile_name_history):
7776 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7777 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7778 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7779
7780 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7781 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7782
7783 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7784 * w32console.c (detect_input_pending, read_input_pending)
7785 (encode_terminal_code):
7786 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7787 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7788 (w32_system_caret_y, Qfile_name_history):
7789 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7790 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7791 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7792 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7793 * w32proc.c (Qlocal, report_file_error):
7794 * w32term.c (Vwindow_system, updating_frame):
7795 * w32uniscribe.c (initialized, uniscribe_font_driver):
7796 Remove unneeded extern declarations.
7797
2aa46d6c
CY
77982011-03-14 Chong Yidong <cyd@stupidchicken.com>
7799
c96bbc66 7800 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7801
cffc6f3b
CY
78022011-03-13 Chong Yidong <cyd@stupidchicken.com>
7803
7804 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7805 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7806 These macros can no longer be used for assignment.
7807
44f230aa
SM
7808 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7809 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7810 (record_buffer_markers, fetch_buffer_markers): New functions for
7811 recording and fetching special buffer markers.
7812 (set_buffer_internal_1, set_buffer_temp): Use them.
7813
7814 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7815
7816 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7817
7818 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7819 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7820
7821 * xdisp.c (hscroll_window_tree):
7822 (reconsider_clip_changes): Use PT instead of BUF_PT.
7823
d251f04b
EZ
78242011-03-13 Eli Zaretskii <eliz@gnu.org>
7825
7826 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7827 $(EMACS_ROOT)/lib/intprops.h.
7828
f0c77cd1
PE
78292011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7830
3eca4629
PE
7831 Fix more problems found by GCC 4.5.2's static checks.
7832
7c86ee98
PE
7833 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7834 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7835 (xg_free_frame_widgets): Make it clear that a local variable is
7836 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7837 (gdk_window_get_screen): Make it clear that this macro is needed
7838 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7839 (int_gtk_range_get_value): New function, which avoids a diagnostic
7840 from gcc -Wbad-function-cast.
7841 (xg_set_toolkit_scroll_bar_thumb): Use it.
7842 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7843 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7844 (get_utf8_string, xg_get_file_with_chooser):
7845 Rename locals to avoid shadowing.
7846 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7847
41729b81
PE
7848 * xgselect.c (xg_select): Remove unused var.
7849
f0c77cd1
PE
7850 * image.c (four_corners_best): Mark locals as initialized.
7851 (gif_load): Initialize transparent_p to zero (Bug#8238).
7852 Mark another local as initialized.
ec6cf4c6 7853 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7854
ce0ad53d 7855 * image.c (clear_image_cache): Now static.
d5d5a617 7856 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7857 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7858 (x_edge_detection): Remove unnecessary cast that
7859 gcc -Wbad-function-cast diagnoses.
2037898d 7860 (gif_load): Fix pointer signedness.
6ae141d6
PE
7861 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7862 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7863
33383987 78642011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7865
d32df629
PE
7866 Improve quality of tests for time stamp overflow.
7867 For example, without this patch (encode-time 0 0 0 1 1
7868 1152921504606846976) returns the obviously-bogus value (-948597
7869 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7870 reports time overflow. See
7871 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7872 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7873 * editfns.c: Include limits.h and intprops.h.
7874 (TIME_T_MIN, TIME_T_MAX): New macros.
7875 (time_overflow): Move earlier, to before first use.
7876 (hi_time, lo_time): New functions, for an accurate test for
7877 out-of-range times.
7878 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7879 (Fget_internal_run_time): Don't assume time_t fits in int.
7880 (make_time): Use list2 instead of Fcons twice.
7881 (Fdecode_time): More accurate test for out-of-range times.
7882 (check_tm_member): New function.
7883 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7884 (lisp_time_argument): Don't rely on undefined left-shift and
7885 right-shift behavior when checking for time stamp overflow.
8be6f318 7886
fe31d94c
PE
7887 * editfns.c (time_overflow): New function, refactoring common code.
7888 (Fformat_time_string, Fdecode_time, Fencode_time):
7889 (Fcurrent_time_string): Use it.
7890
8be6f318
PE
7891 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7892 * dired.c (make_time): Move to ...
7893 * editfns.c (make_time): ... here.
7894 * systime.h: Note the move.
7895
09d9db2c 78962011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7897
126bc0dc
YM
7898 * fringe.c (update_window_fringes): Remove unused variables.
7899
c47cbdfd
YM
7900 * unexmacosx.c (copy_data_segment): Also copy __got section.
7901 (Bug#8223)
7902
7ac80be9
EZ
79032011-03-12 Eli Zaretskii <eliz@gnu.org>
7904
c96bbc66 7905 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7906 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7907 Constify `char *' arguments and their references according to
7908 prototypes in tparam.h.
7909
ecb0f94d 7910 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7911
7ac80be9
EZ
7912 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7913 Adapt all references accordingly.
7914
7915 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7916
ef1fd07e
TT
79172011-03-11 Tom Tromey <tromey@redhat.com>
7918
7919 * buffer.c (syms_of_buffer): Remove obsolete comment.
7920
7ef4b50c
EZ
79212011-03-11 Eli Zaretskii <eliz@gnu.org>
7922
7923 * termhooks.h (encode_terminal_code): Declare prototype.
7924
7925 * msdos.c (encode_terminal_code): Don't declare prototype.
7926
7927 * term.c (encode_terminal_code): Now external again, used by
7928 w32console.c and msdos.c.
7929
44f230aa
SM
7930 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7931 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7932
4b1ec863 79332011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7934
1714f52b 7935 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7936
4b1ec863
PE
7937 * fringe.c (update_window_fringes): Mark locals as initialized
7938 (Bug#8227).
7939 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7940
524c7aa6
PE
7941 * alloc.c (mark_fringe_data): Move decl from here ...
7942 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7943 to check its interface.
7944 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7945
a5c0af81 7946 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7947 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7948 (fontset_font): Mark local as initialized.
a9a06e0b 7949 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7950
b4716021
PE
7951 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7952
811e9bac 7953 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7954 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7955 (x_own_selection, Fx_disown_selection_internal): Rename locals
7956 to avoid shadowing.
7957 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7958
7e3ab302
PE
7959 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7960 so that the caller can use some name other than gcpro1.
7961 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7962 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7963 (Fx_backspace_delete_keys_p):
7964 Use them to avoid shadowing, and rename vars to avoid shadowing.
7965 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7966 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7967 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7968 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7969 Remove unused locals.
7e3ab302
PE
7970 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7971 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7972 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7973 macros.
f78faa98 7974
e2b13473
PE
7975 * xterm.h (x_mouse_leave): New decl.
7976
77f23912
PE
7977 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7978 Remove unused functions.
cdf4ba58
PE
7979 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7980 (x_calc_absolute_position): Now static.
7411c686 7981 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7982 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7983 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7984 unless they are used.
38d0b34a
PE
7985 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7986 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7987 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7988 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7989 (x_error_catcher, x_connection_closed, x_error_handler):
7990 (x_error_quitter, xembed_send_message, x_iconify_frame):
7991 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7992 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7993 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7994
44f230aa
SM
7995 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7996 Rename or move locals to avoid shadowing.
6b463e58 7997 (tty_defined_color, merge_face_heights): Now static.
5967d051 7998 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7999 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8000 does not deduce is never used uninitialized.
73719eba
PE
8001 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8002 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8003
426994c3 8004 * terminal.c (store_terminal_param): Now static.
5489860b 8005
032f1620 8006 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8007 (set_frame_menubar): Remove unused local.
d4323972 8008 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8009 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8010 since they might point to immutable storage.
281585b0
PE
8011 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8012 since it's unused otherwise.
032f1620 8013
367c19e5 8014 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8015 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8016 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8017 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8018 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8019 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8020 does not deduce are never used uninitialized.
70739cbe 8021
07b48fa9
PE
8022 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8023
8868a238 8024 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8025 * window.c (window_loop, size_window):
8026 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8027
7e5cf297 8028 * window.c (display_buffer): Now static.
d6550a9f
PE
8029 (size_window): Mark variables that gcc -Wuninitialized
8030 does not deduce are never used uninitialized.
a586633d
PE
8031 * window.h (check_all_windows): New decl, to forestall
8032 gcc -Wmissing-prototypes diagnostic.
5b555da1 8033 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8034
f6095868
PE
8035 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8036 shadowing.
8037 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8038 Include <limits.h>.
8039 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8040 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8041 (load_charset_map): Mark variables that gcc -Wuninitialized
8042 does not deduce are never used uninitialized.
53df7c11 8043 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8044
f38b440c
PE
8045 * coding.c (coding_set_source, coding_set_destination):
8046 Use "else { /* comment */ }" rather than "else /* comment */;"
8047 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8048 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8049 a block, when the outer 'i' will do.
8050 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8051 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8052 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8053 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8054 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8055 Rename locals to avoid shadowing.
8056 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8057 * coding.c (emacs_mule_char, encode_invocation_designation):
8058 Now static, since they're not used elsewhere.
413bb2db 8059 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8060 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8061 (decode_coding_emacs_mule): Mark variables that gcc
8062 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8063 (detect_coding_iso_2022): Initialize a local variable that might
8064 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8065 this initialization is needed. (Bug#8211)
5f58e762
PE
8066 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8067 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8068 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8069 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8070 Remove unused macros.
f38b440c 8071
232b38b9 8072 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8073 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8074 * character.c (string_count_byte8): Likewise.
232b38b9 8075
fb90da1b
PE
8076 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8077 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8078
fb93dbc2
PE
8079 * chartab.c (copy_sub_char_table): Now static, since it's not used
8080 elsewhere.
5c156ace
PE
8081 (sub_char_table_ref_and_range, char_table_ref_and_range):
8082 Rename locals to avoid shadowing.
bbcd0949 8083 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8084
7d3b3862 8085 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8086 (BIDI_BOB): Remove unused macro.
7d3b3862 8087
6be7d3da
PE
8088 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8089 deduce are never used uninitialized.
c2ed9c8b 8090 * term.c (encode_terminal_code): Likewise.
6be7d3da 8091
75f8807f 8092 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8093
50938595
PE
8094 * tparam.h: New file.
8095 * term.c, tparam.h: Include it.
8096 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8097 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8098 Move these decls to tparam.h, and make them agree with what
8099 is actually in tparam.c. The previous trick of using incompatible
8100 decls in different modules does not conform to the C standard.
8101 All callers of tparam changed to use tparam's actual API.
8102 * tparam.c (tparam1, tparam, tgoto):
8103 Use const pointers where appropriate.
8104
fbceeba2
PE
8105 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8106 * cm.h (struct cm): Likewise.
8107 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8108 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8109 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8110 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8111 (turn_on_face, init_tty): Likewise.
8112 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8113
7f3f1250
PE
8114 * term.c (term_mouse_position): Rename local to avoid shadowing.
8115
e6ca6543
PE
8116 * alloc.c (mark_ttys): Move decl from here ...
8117 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8118
c40f8d15
AS
81192011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8120
8121 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8122
cfe0661d
JB
81232011-03-09 Juanma Barranquero <lekktu@gmail.com>
8124
8125 * search.c (compile_pattern_1): Remove argument regp, unused since
8126 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8127 (compile_pattern): Don't pass it.
8128
0afb4571
J
81292011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8130
8131 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8132 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8133 for ! HAVE_GTK3.
8134 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8135
8136 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8137
8138 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8139 gdk_window_get_screen, gdk_window_get_geometry,
8140 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8141 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8142 (xg_get_pixbuf_from_pixmap): New function.
8143 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8144 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8145 Call xg_get_pixbuf_from_pixmap instead of
8146 gdk_pixbuf_get_from_drawable.
8147 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8148 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8149 (xg_check_special_colors): Use GtkStyleContext and its functions
8150 for HAVE_GTK3.
8151 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8152 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8153 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8154 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8155 Call gtk_widget_get_preferred_size.
0afb4571
J
8156 (xg_frame_resized): gdk_window_get_geometry only takes 5
8157 parameters.
44f230aa
SM
8158 (xg_win_to_widget, xg_event_is_for_menubar):
8159 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8160 (xg_set_widget_bg): New function.
8161 (delete_cb): New function.
895009e1 8162 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8163 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8164 (xg_set_background_color): Call xg_set_widget_bg.
8165 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8166 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8167 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8168 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8169 if ! HAVE_GTK3.
8170 (update_frame_tool_bar): Call gtk_widget_hide.
8171 (xg_initialize): Use GDK_KEY_g.
8172
8173 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8174 if ! HAVE_GTK3
8175 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8176
8177 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8178 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8179 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8180
1c2cc4ef
JB
81812011-03-08 Juanma Barranquero <lekktu@gmail.com>
8182
8183 * w32xfns.c (select_palette): Check success of RealizePalette against
8184 GDI_ERROR, not zero.
8185
33383987 8186See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8187
8188;; Local Variables:
8189;; coding: utf-8
aac0c6e3
MR
8190;; End:
8191
33383987 8192 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8193
8194 This file is part of GNU Emacs.
8195
8196 GNU Emacs is free software: you can redistribute it and/or modify
8197 it under the terms of the GNU General Public License as published by
8198 the Free Software Foundation, either version 3 of the License, or
8199 (at your option) any later version.
8200
8201 GNU Emacs is distributed in the hope that it will be useful,
8202 but WITHOUT ANY WARRANTY; without even the implied warranty of
8203 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8204 GNU General Public License for more details.
8205
8206 You should have received a copy of the GNU General Public License
8207 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.