Improve documentation of `special' modes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3ebec551
PE
12011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2
3 * bidi.c (bidi_initialize): Remove unused local.
4
9fd8be00
EZ
52011-08-15 Eli Zaretskii <eliz@gnu.org>
6
474a8465
EZ
7 * biditype.h: File removed.
8
9 * bidimirror.h: File removed.
10
11 * deps.mk (bidi.o): Remove biditype.h and
12 bidimirror.h.
13
14 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
15 bidimirror.h.
16
17 * dispextern.h: Fix a typo in the comment to bidi_type_t.
18
19 * chartab.c: Improve commentary for the uniprop_table API.
20
32413314
EZ
21 * bidi.c (bidi_paragraph_init): Support zero value of
22 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
23 (bidi_initialize): Use uniprop_table instead of including
24 biditype.h and bidimirror.h.
32413314 25
9fd8be00
EZ
26 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
27 coordinates of the iterator when restoring from ppos_it.
28 (Bug#9296)
29
5cf2b69b
KH
302011-08-14 Kenichi Handa <handa@m17n.org>
31
32 * process.c (create_process): Call setup_process_coding_systems
33 after the pid of the process is set to -1.
34
daf17d00
EZ
352011-08-14 Eli Zaretskii <eliz@gnu.org>
36
37 * xdisp.c (move_it_in_display_line_to): Don't invoke
38 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
39 ppos_it. Fixes vertical cursor motion when line beginning is
40 covered by an image. (Bug#9296)
41
08e3161a
JD
422011-08-14 Jan Djärv <jan.h.d@swipnet.se>
43
44 * nsterm.h (ns_run_ascript): Declare.
45 (NSAPP_DATA2_RUNASSCRIPT): Define.
46
47 * nsfns.m (as_script, as_result, as_status): New static variables.
48 (ns_run_ascript): New function.
49 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
50 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
51 the event loop. Get status from as_status (Bug#7276).
52
53 * nsterm.m (sendEvent): If event is NSApplicationDefined and
54 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
55 the event loop (Bug#7276).
56
a3720aa2
AS
572011-08-14 Andreas Schwab <schwab@linux-m68k.org>
58
59 * gnutls.c (QCgnutls_bootprop_priority)
60 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
61 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
62 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
63 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
64 (QCgnutls_bootprop_verify_hostname_error)
65 (QCgnutls_bootprop_callbacks_verify): Rename from
66 Qgnutls_bootprop_..., all uses changed.
67
68 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
69 uses changed.
70
0a0d27fb
PE
712011-08-14 Paul Eggert <eggert@cs.ucla.edu>
72
19d5c50c
PE
73 * xfaces.c (Qframe_set_background_mode): Now static.
74 * dispextern.h (Qframe_set_background_mode): Remove decl.
75
0a0d27fb
PE
76 * process.c (Fnetwork_interface_info): Declare local only if needed.
77
377538cb
JD
782011-08-13 Jan Djärv <jan.h.d@swipnet.se>
79
80 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
81 (Fnetwork_interface_list): Allocate in increments of bytes instead
82 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
83 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
84 sockaddr.
85 (struct ifflag_def): notrailers is smart on OSX.
86 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
87 Get hardware address with getifaddrs if available.
88
08fff70c
EZ
892011-08-12 Eli Zaretskii <eliz@gnu.org>
90
91 * xdisp.c (iterate_out_of_display_property): xassert that
92 IT->position is set to within IT->object's boundaries. Break from
93 the loop as soon as EOB is reached; avoids infloops in redisplay
94 when IT->position is set up wrongly due to some bug. Set
95 IT->current to match the bidi iterator unconditionally.
96 (push_display_prop): Allow GET_FROM_STRING as IT->method on
97 entry. Force push_it to save on the stack the current
98 buffer/string position, to be restored by pop_it. Fix flags in
99 the iterator structure wrt the object coming from a display
100 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
101 properties. (Bug#9284)
102
7be1c708 1032011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 104
7be1c708
CY
105 * fontset.c (fontset_get_font_group): Add proper type checks.
106 (Bug#9172)
aac0c6e3 107
7be1c708 1082011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 109
7be1c708
CY
110 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
111 and LC_VERSION_MIN_MACOSX.
112 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
113 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 114
97bb72a6
EZ
1152011-08-08 Eli Zaretskii <eliz@gnu.org>
116
117 * xdisp.c (forward_to_next_line_start): Allow to use the
757664a4
EZ
118 no-display-properties-and-no-overlays under bidi display. Set
119 disp_pos in the bidi iterator to avoid searches for display
120 properties and overlays.
97bb72a6 121
d5617611
CY
1222011-08-08 Chong Yidong <cyd@stupidchicken.com>
123
37e11a63
CY
124 * editfns.c (Fset_time_zone_rule): Document relationship with the
125 setenv function.
126
d5617611
CY
127 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
128 the font entity extracted from the cache (Bug#8109).
129
58872834
CY
1302011-08-07 Chong Yidong <cyd@stupidchicken.com>
131
132 * composite.c (autocmp_chars): Don't reset point. That is done by
133 restore_point_unwind (Bug#5984).
134
75bfc667
JL
1352011-08-07 Juri Linkov <juri@jurta.org>
136
137 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
138 to show the arg `TIME' instead of `TIMEVAL'.
139
d1410150
EZ
1402011-08-06 Eli Zaretskii <eliz@gnu.org>
141
142 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
143 display property strides EOL and includes a newline, as in
144 longlines-mode. (Bug#9254)
75b771e4
EZ
145 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
146 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
147
148 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
149 is non-zero, even if the data buffer is NULL. Fixes a crash in
150 vertical-motion with longlines-mode. (Bug#9254)
151
35928349
EZ
1522011-08-05 Eli Zaretskii <eliz@gnu.org>
153
ec7cc85b
EZ
154 * bidi.c <bidi_cache_total_alloc>: Now static.
155 (bidi_initialize): Initialize bidi_cache_total_alloc.
156
35928349
EZ
157 *xdisp.c (display_line): Release buffer allocated for shelved bidi
158 cache. (Bug#9221)
159
160 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
161 amount allocated this far in `bidi_cache_total_alloc'.
162 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
163 non-zero, only free the data buffer without restoring the cache
164 contents. All callers changed.
165
166 * dispextern.h (bidi_unshelve_cache): Update prototype.
167
168 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
169 (move_it_in_display_line, move_it_to)
170 (move_it_vertically_backward, move_it_by_lines): Replace the call
171 to xfree to an equivalent call to bidi_unshelve_cache.
172 (move_it_in_display_line_to): Fix logic of returning
412b6358 173 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 174
e2e2423b
EZ
1752011-08-05 Eli Zaretskii <eliz@gnu.org>
176
177 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
178 came from a string character with a `cursor' property. (Bug#9229)
179
ae9e757a
JD
1802011-08-04 Jan Djärv <jan.h.d@swipnet.se>
181
182 * Makefile.in (LIB_PTHREAD): New variable.
183 (LIBES): Add LIB_PTHREAD (Bug#9216).
184
185 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
186 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
187
213bd7f2
AS
1882011-08-04 Andreas Schwab <schwab@linux-m68k.org>
189
190 * regex.c (re_iswctype): Remove some redundant boolean
191 conversions.
192
99aaf75f
JD
1932011-08-04 Jan Djärv <jan.h.d@swipnet.se>
194
195 * xterm.c (x_find_topmost_parent): New function.
196 (x_set_frame_alpha): Find topmost parent window with
197 x_find_topmost_parent and set the property there also (bug#9181).
198 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
199
c74e9d86
PE
2002011-08-04 Paul Eggert <eggert@cs.ucla.edu>
201
202 * callproc.c (Fcall_process): Avoid vfork clobbering
203 the local vars buffer, coding_systems, current_dir.
204
640c8776
SM
2052011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
206
207 * keymap.c (Fmake_composed_keymap): Move to subr.el.
208
f26d0e4c
PE
2092011-08-03 Paul Eggert <eggert@cs.ucla.edu>
210
8a10d76c
PE
211 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
212 so that it is not optimized away.
213
f26d0e4c
PE
214 * xdisp.c (compute_display_string_pos): Remove unused local.
215
55439c61
EZ
2162011-08-02 Eli Zaretskii <eliz@gnu.org>
217
218 Fix slow cursor motion and scrolling in large buffers with
219 selective display, like Org Mode buffers. (Bug#9218)
220
221 * dispextern.h (struct bidi_it): New member disp_prop_p.
222
223 * xdisp.c: Remove one-slot cache of display string positions.
224 (compute_display_string_pos): Accept an additional argument
225 DISP_PROP_P; callers changed. Scan at most 5K characters forward
226 for a display string or property. If found, set DISP_PROP_P
227 non-zero.
228
229 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
230 DISP_PROP_P, and pass it to compute_display_string_pos.
231 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
232 non-zero. All callers of bidi_fetch_char changed.
233
fb33fa43
SM
2342011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
235
236 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
237
b099e063
DM
2382010-12-03 Don March <don@ohspite.net>
239
240 * keymap.c (Fdefine_key): Fix non-prefix key error message when
241 last character M-[char] is translated to ESC [char] (bug#7541).
242
5cc7f7af
KH
2432011-08-02 Kenichi Handa <handa@m17n.org>
244
d0fffa3f 245 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
246
247 * chartab.c (uniprop_table): Make it non-static.
248
525d5e6e
EZ
2492011-08-01 Eli Zaretskii <eliz@gnu.org>
250
251 * xdisp.c (forward_to_next_line_start): Accept additional argument
252 BIDI_IT_PREV, and store into it the state of the bidi iterator had
253 on the newline.
254 (reseat_at_next_visible_line_start): Use the bidi iterator state
255 returned by forward_to_next_line_start to restore the state of
256 it->bidi_it after backing up to previous newline. (Bug#9212)
257
31011111
AS
2582011-07-30 Andreas Schwab <schwab@linux-m68k.org>
259
260 * regex.c (re_comp): Protoize.
261 (re_exec): Fix return type.
262 (regexec): Fix type of `ret'. (Bug#9203)
263
e5d76069
PE
2642011-07-29 Paul Eggert <eggert@cs.ucla.edu>
265
266 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
267 This is needed if max-image-size is a floating-point number.
268
9a79b20c
AS
2692011-07-28 Andreas Schwab <schwab@linux-m68k.org>
270
271 * print.c (print_object): Print empty symbol as ##.
272
273 * lread.c (read1): Read ## as empty symbol.
274
d8c2fa78
AA
2752011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
276
277 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
278 setting frame foreground color (Bug#9175).
279 (x_set_background_color): Likewise.
280
ffe57a7a
AA
281 * nsmenu.m (-setText): Size tooltip dimensions precisely to
282 contents (Bug#9176).
283 (EmacsTooltip -init): Remove bezels and add shadows to
284 tooltip windows.
285
bf3492a5
AA
286 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
287 or scroll bar (Bug#8470).
288
d55e9c53
AA
289 * nsfont.m (nsfont_open): Remove assignment to voffset and
290 unnecessary vars hshink, expand, hd, full_height, min_height.
291 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
292
293 * nsterm.h (nsfont_info): Remove voffset field.
294
d8c2fa78 2952011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
296
297 Implement strike-through and overline on NextStep (Bug#8863).
298
299 * nsfont.m (nsfont_open): Use underline position provided by font,
300 instead of hard-coded value of 2.
301 (nsfont_draw): Call ns_draw_text_decoration instead.
302
303 * nsterm.h: Add declaration for ns_draw_text_decoration.
304
305 * nsterm.m (ns_draw_text_decoration): New function for drawing
306 underline, overline, and strike-through.
307 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
308 ns_draw_text_decoration. Change treatment of cursor drawing to
309 accomodate underlining, etc.
310
4cc60b9b
EZ
3112011-07-28 Eli Zaretskii <eliz@gnu.org>
312
bc7ece87
EZ
313 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
314 default.
4cc60b9b 315
476371c4
PE
3162011-07-28 Paul Eggert <eggert@cs.ucla.edu>
317
66606eea
PE
318 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
319 Without this fix, if a signal arrives just after memory fills up,
320 'malloc' might be invoked reentrantly.
321
476371c4
PE
322 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
323 In other words, assume that every image size is allowed, on non-X
324 hosts. This assumption is probably wrong, but it lets Emacs compile.
325
f3fcc40d
AS
3262011-07-28 Andreas Schwab <schwab@linux-m68k.org>
327
328 * regex.c (re_iswctype): Convert return values to boolean.
329
350c992f
EZ
3302011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
331
332 * xdisp.c (compute_display_string_pos): Don't use cached display
333 string position if the buffer had its restriction changed.
334 (Bug#9184)
335
5266b4bb
PE
3362011-07-28 Paul Eggert <eggert@cs.ucla.edu>
337
338 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
339
2573a837 3402011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 341
41f55ccd 342 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 343
39e378da
PE
344 * bidi.c: Integer size and overflow fixes.
345 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
346 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
347 (bidi_cache_find_level_change, bidi_cache_ensure_space)
348 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
349 (bidi_find_other_level_edge):
350 Use ptrdiff_t instead of EMACS_INT where either will do.
351 This works better on 32-bit hosts configured --with-wide-int.
352 (bidi_cache_ensure_space): Check for size-calculation overflow.
353 Use % rather than repeated addition, for better worst-case speed.
354 Don't set bidi_cache_size until after xrealloc returns, because it
355 might not return.
356 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
357 (bidi_cache_ensure_space): Also check that the bidi cache size
358 does not exceed that of the largest Lisp string or buffer. See Eli
359 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 360
5e927815
PE
361 * alloc.c (__malloc_size_t): Remove.
362 All uses replaced by size_t. See Andreas Schwab's note
363 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
364
ca4aa935
PE
365 * image.c: Improve checking for integer overflow.
366 (check_image_size): Assume that f is nonnull, since
367 it is always nonnull in practice. This is one less thing to
368 worry about when checking for integer overflow later.
369 (x_check_image_size): New function, which checks for integer
370 overflow issues inside X.
371 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
372 This removes the need for a memory_full check.
373 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
374 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
375 (xbm_read_bitmap_data): Change locals back to 'int', since
376 their values must fit in 'int'.
377 (xpm_load_image, png_load, tiff_load):
378 Invoke x_create_x_image_and_pixmap earlier,
379 to avoid much needless work if the image is too large.
380 (tiff_load): Treat overly large images as if
381 x_create_x_image_and_pixmap failed, not as malloc failures.
382 (gs_load): Use x_check_image_size.
383
5f8f9cc2
PE
384 * gtkutil.c: Omit integer casts.
385 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
386 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
387
5adf60bc
PE
388 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
389
c8907a93
PE
390 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
391 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
392 would wrongly return t on a 64-bit host.
393
e3c25c68
PE
394 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
395 The plain *_OVERFLOW macros run afoul of GCC bug 49705
396 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
397 and therefore cause GCC to emit a bogus diagnostic in some cases.
398
3f791afe
PE
399 * image.c: Integer signedness and overflow and related fixes.
400 This is not an exhaustive set of fixes, but it's time to
401 record what I've got.
402 (lookup_pixel_color, check_image_size): Remove redundant decls.
403 (check_image_size): Don't assume that arbitrary EMACS_INT values
404 fit in 'int', or that arbitrary 'double' values fit in 'int'.
405 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
406 (tiff_load, imagemagick_load_image):
407 Check for overflow in size calculations.
408 (x_create_x_image_and_pixmap): Remove unnecessary test for
409 xmalloc returning NULL; that can't happen.
410 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
411 (xpm_color_bucket): Use better integer hashing function.
412 (xpm_cache_color): Don't possibly over-allocate memory.
413 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
414 (gif_memory_source):
415 Use ptrdiff_t, not int or size_t, to record sizes.
416 (png_load): Don't assume values greater than 2**31 fit in 'int'.
417 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
418 either works, as we prefer signed integers.
419 (tiff_read_from_memory, tiff_write_from_memory):
420 Return tsize_t, not size_t, since that's what the TIFF API wants.
421 (tiff_read_from_memory): Don't fail simply because the read would
422 go past EOF; instead, return a short read.
423 (tiff_load): Omit no-longer-needed casts.
424 (Fimagemagick_types): Don't assume size fits into 'int'.
425
3cc5a532
PE
426 Improve hashing quality when configured --with-wide-int.
427 * fns.c (hash_string): New function, taken from sxhash_string.
428 Do not discard information about ASCII character case; this
429 discarding is no longer needed.
430 (sxhash-string): Use it. Change sig to match it. Caller changed.
431 * lisp.h: Declare it.
432 * lread.c (hash_string): Remove, since we now use fns.c's version.
433 The fns.c version returns a wider integer if --with-wide-int is
434 specified, so this should help the quality of the hashing a bit.
435
b312a492
PE
436 * emacs.c: Integer overflow minor fix.
437 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
438 Define only if GNU_LINUX.
439 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
440
dfd153ae
PE
441 * dispnew.c: Integer signedness and overflow fixes.
442 Remove unnecessary forward decls, that were a maintenance hassle.
443 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
444 All uses changed.
445 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
446 (scrolling_window): Use ptrdiff_t, not int, for byte count.
447 (prepare_desired_row, line_draw_cost):
448 Use int, not unsigned, where either works.
449 (save_current_matrix, restore_current_matrix):
450 Use ptrdiff_t, not size_t, where either works.
451 (init_display): Check for overflow more accurately, and without
452 relying on undefined behavior.
453
a81d11a3
PE
454 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
455 Remove, replacing with the new symbols in lisp.h. All uses changed.
456 * fileio.c (make_temp_name):
457 * filelock.c (lock_file_1, lock_file):
458 * xdisp.c (message_dolog):
459 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
460 Use pMd etc. instead.
461 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
462 replacing the pWIDE etc. symbols removed from editfns.c.
463
3300e6fd
PE
464 * keyboard.h (num_input_events): Now uintmax_t.
465 This is (very slightly) less likely to mess up due to wraparound.
466 All uses changed.
467
fd05c7e9
PE
468 * buffer.c: Integer signedness fixes.
469 (alloc_buffer_text, enlarge_buffer_text):
470 Use ptrdiff_t rather than size_t when either will do, as we prefer
471 signed integers.
472
903fe15d
PE
473 * alloc.c: Integer signedness and overflow fixes.
474 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
475 (__malloc_size_t): Default to size_t, not to int.
476 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
477 (Fgarbage_collect, mark_object_loop_halt, mark_object):
478 Prefer ptrdiff_t to size_t when either would do, as we prefer
479 signed integers.
480 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
481 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
482 Now const. Initialize with values that are in range even if char
483 is signed.
484 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
485 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
486 These functions do the right thing with sizes > 2**32.
487 (check_depth): Now ptrdiff_t, not int.
488 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
489 Adjust to new way of storing sizes. Check for size overflow bugs
490 in rest of code.
491 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
492 slightly wrong anyway, as it missed one instance of
493 XMALLOC_OVERRUN_CHECK_OVERHEAD.
494 (refill_memory_reserve): Omit needless cast to size_t.
495 (mark_object_loop_halt): Mark as externally visible.
496
ac82cc6a
PE
497 * xselect.c: Integer signedness and overflow fixes.
498 (Fx_register_dnd_atom, x_handle_dnd_message):
499 Use ptrdiff_t, not size_t, since we prefer signed.
500 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
501 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
502 x_dnd_atoms_size and x_dnd_atoms_length.
503
c2d1e36d
PE
504 * doprnt.c: Prefer signed to unsigned when either works.
505 * eval.c (verror):
506 * doprnt.c (doprnt):
507 * lisp.h (doprnt):
508 * xdisp.c (vmessage):
509 Use ptrdiff_t, not size_t, when using or implementing doprnt,
510 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
511 prefer signed arithmetic to avoid comparison confusion.
512 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
513 but is a bit tricky.
514
0e926e56
PE
515 Assume freestanding C89 headers, string.h, stdlib.h.
516 * data.c, doprnt.c, floatfns.c, print.c:
517 Include float.h unconditionally.
518 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
519 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
520 * regex.c: Likewise for stddef.h, string.h.
521 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
522 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
523 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
524 (STDC_HEADERS): Remove obsolete defines.
525 * sysdep.c: Include limits.h unconditionally.
526
9cfdb3ec
PE
527 Assume support for memcmp, memcpy, memmove, memset.
528 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
529 * regex.c (memcmp, memcpy):
530 Remove; we assume C89 now.
531
532 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
533 (__malloc_safe_bcopy): Remove; no longer needed.
534
cf950e6b 535 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
536 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
537 well either way, and we prefer signed to unsigned.
538
dbf38e02
LMI
5392011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
540
541 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
542 closes the connection while we're reading (bug#9182).
543
d6f0886c
JD
5442011-07-25 Jan Djärv <jan.h.d@swipnet.se>
545
546 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
547 are specified (Bug#9168).
548
2eb1f9e6
PE
5492011-07-25 Paul Eggert <eggert@cs.ucla.edu>
550
551 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
552 Found by GCC static checking and --with-wide-int on a 32-bit host.
553
22381272 5542011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
555
556 * xdisp.c (compute_display_string_pos): Fix logic of caching
557 previous display string position. Initialize cached_prev_pos to
558 -1. Fixes slow-down at the beginning of a buffer.
559
f25e39b4
EZ
5602011-07-24 Eli Zaretskii <eliz@gnu.org>
561
562 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
563 for attrs[LFACE_FONTSET_INDEX].
564
04c4b52e
PE
5652011-07-23 Paul Eggert <eggert@cs.ucla.edu>
566
567 * xml.c (parse_region): Remove unused local
568 that was recently introduced.
569
c1734fbd
EZ
5702011-07-23 Eli Zaretskii <eliz@gnu.org>
571
be18c5a5
EZ
572 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
573 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
574
c1734fbd
EZ
575 * xdisp.c (move_it_in_display_line_to): Record the best matching
576 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
577 exit if none of the characters scanned was an exact match.
578 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
579 when exact match is impossible due to invisible text, and the
580 lines are truncated.
581
a258d627
JD
5822011-07-23 Jan Djärv <jan.h.d@swipnet.se>
583
584 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
585 for OSX >= 10.7.
586
b6d5a689
EZ
5872011-07-22 Eli Zaretskii <eliz@gnu.org>
588
0f74f785
EZ
589 Fix a significant slow-down of cursor motion with C-n, C-p,
590 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
591 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 592 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
593 (next_element_from_buffer): Call compute_stop_pos_backwards to
594 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
595 base_level_stop.
596 (reseat): Don't look for prev_stop, as that could mean a very long
597 run.
598 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
599 <cached_disp_overlay_modiff>: Cache for last found display string
600 position.
551918c1 601 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
602 about the same buffer in the same area of character positions, and
603 the buffer wasn't changed since the time the display string
604 position was cached.
551918c1 605
b2d0c91a
EZ
6062011-07-22 Eli Zaretskii <eliz@gnu.org>
607
608 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
609 is an integer, which is important for empty lines. (Bug#9149)
610
043604ee
CY
6112011-07-22 Chong Yidong <cyd@stupidchicken.com>
612
613 * frame.c (Fmodify_frame_parameters): In tty case, update the
614 default face if necessary (Bug#4238).
615
da4adb04
CY
6162011-07-21 Chong Yidong <cyd@stupidchicken.com>
617
618 * editfns.c (Fstring_to_char): No need to explain what a character
619 is in the docstring (Bug#6576).
620
9abd0532
LMI
6212011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
622
623 * xml.c (parse_region): Make sure we always return a tree.
624
36881d16
HK
6252011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
626
627 * xml.c (parse_region): If a document contains only comments,
628 return that, too.
629
1e98674d
LMI
6302011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
631
632 * xml.c (make_dom): Return comments, too.
633
590bd467
PE
6342011-07-19 Paul Eggert <eggert@cs.ucla.edu>
635
636 Port to OpenBSD.
637 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
638 and the surrounding thread.
639 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
640 rather than fgets, and retry after EINTR. Otherwise, 'emacs
641 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
642 timer goes off.
643 * s/openbsd.h (BROKEN_SIGIO): Define.
644 * unexelf.c (unexec) [__OpenBSD__]:
645 Don't update the .mdebug section of the Alpha COFF symbol table.
646
f41628b2
LMI
6472011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
648
649 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
650 (bug#8460).
651
b59b67c5
PE
6522011-07-18 Paul Eggert <eggert@cs.ucla.edu>
653
15e3a074
PE
654 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
655 This fixes some race conditions on the permissions of any newly
656 created file.
657
41bed37d
PE
658 * alloc.c (valid_pointer_p): Use pipe, not open.
659 This fixes some permissions issues when debugging.
660
b59b67c5
PE
661 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
662 If fchown fails to set both uid and gid, try to set just gid,
663 as that is sometimes allowed. Adjust the file's mode to eliminate
664 setuid or setgid bits that are inappropriate if fchown fails.
665
925a6be7
SM
6662011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
667
668 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
669 to compare Lisp_Objects.
670 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
671 global_gnutls_log_level, don't mistake it for a Lisp_Object.
672 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
673
52968808
AS
6742011-07-17 Andreas Schwab <schwab@linux-m68k.org>
675
0a6a104b
AS
676 * lread.c (read_integer): Unread even EOF character.
677 (read1): Likewise. Properly record start position of symbol.
678
52968808
AS
679 * lread.c (read1): Read `#:' as empty uninterned symbol if no
680 symbol character follows.
681
9e381cdd
PE
6822011-07-17 Paul Eggert <eggert@cs.ucla.edu>
683
684 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
685 This works around a problem with the previous change to Fcopy_file.
686 Recent glibc declares fchown with __attribute__((warn_unused_result)),
687 and without this change, GCC might complain about discarding
688 fchown's return value.
689
b5641435
JB
6902011-07-16 Juanma Barranquero <lekktu@gmail.com>
691
692 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
693
a8031457
PE
6942011-07-16 Paul Eggert <eggert@cs.ucla.edu>
695
696 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
697
dd889327
LMI
6982011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
699
750c33f7
LMI
700 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
701 it's used from the C level.
702
dd889327
LMI
703 * process.c: Use the same condition for POLL_FOR_INPUT in both
704 keyboard.c and process.c (bug#1858).
705
87e86684
LM
7062011-07-09 Lawrence Mitchell <wence@gmx.li>
707
708 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
709 (Fgnutls_boot): Use it.
710
64348f40
AS
7112011-07-15 Andreas Schwab <schwab@linux-m68k.org>
712
713 * doc.c (Fsubstitute_command_keys): Revert last change.
714
1d698799
LMI
7152011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
716
f863868c
LMI
717 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
718 quotes the next character, and doesn't affect other longer
719 sequences (bug#8935).
720
1d698799
LMI
721 * lread.c (syms_of_lread): Clarify that is isn't only
722 `eval-buffer' and `eval-defun' that's affected by
723 `lexical-binding' (bug#8460).
724
aa4b6df6
EZ
7252011-07-15 Eli Zaretskii <eliz@gnu.org>
726
727 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
728 bidi redisplay when a line includes both an image and is
729 truncated.
730
5d856da6
PE
7312011-07-14 Paul Eggert <eggert@cs.ucla.edu>
732
ad6042bb
PE
733 Fix minor problems found by static checking.
734 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
735 (elsz): Now a signed constant, not a size_t var. We prefer signed
736 types to unsigned, to avoid integer comparison confusion. Without
737 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
738 "cannot optimize loop, the loop counter may overflow", a symptom
739 of the confusion.
f00bbb22 740 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
741 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
742
6468f31c
LMI
7432011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
744
49080b10
LMI
745 * search.c (Fre_search_backward): Mention `case-fold-search' in
746 all the re_search_* functions (bug#8138).
747
6468f31c
LMI
748 * keyboard.c (Fopen_dribble_file): Document when the file is
749 closed (bug#8056).
750
c965adc5
EZ
7512011-07-14 Eli Zaretskii <eliz@gnu.org>
752
df9733bf
EZ
753 * bidi.c (bidi_dump_cached_states): Fix format of displaying
754 bidi_cache_idx.
755
0bb23927
EZ
756 Support bidi reordering of display and overlay strings.
757 * xdisp.c (compute_display_string_pos)
758 (compute_display_string_end): Accept additional argument STRING.
759 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
760 (reseat_to_string): Initialize bidi_it->string.s and
761 bidi_it->string.schars.
762 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
763 NULL (avoids a crash in bidi_paragraph_init).
764 Initialize itb.string.lstring.
0bb23927
EZ
765 (init_iterator): Call bidi_init_it only of a valid
766 buffer position was specified. Initialize paragraph_embedding to
767 L2R.
768 (reseat_to_string): Initialize the bidi iterator.
769 (display_string): If we need to ignore text properties of
770 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
771 original value of -1 will not work with bidi.)
772 (compute_display_string_pos): First arg is now struct
773 `text_pos *'; all callers changed. Support display properties on
774 Lisp strings.
775 (compute_display_string_end): Support display properties on Lisp
776 strings.
777 (init_iterator, reseat_1, reseat_to_string): Initialize the
778 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
779 when iterating on a string not from display properties).
640c8776
SM
780 (compute_display_string_pos, compute_display_string_end):
781 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
782 arrow keys.
783 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
784 base_level_stop; instead, set base_level_stop to BEGV.
785 Fixes crashes in vertical-motion.
0bb23927
EZ
786 (next_element_from_buffer): Improve commentary for when
787 the iterator is before prev_stop.
788 (init_iterator): Initialize bidi_p from the default value of
789 bidi-display-reordering, not from buffer-local value. Use the
790 buffer-local value only if initializing for buffer iteration.
791 (handle_invisible_prop): Support invisible properties on strings
792 that are being bidi-reordered.
793 (set_iterator_to_next): Support bidi reordering of C strings and
794 Lisp strings.
795 (next_element_from_string): Support bidi reordering of Lisp
796 strings.
797 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
798 (display_string): Support display of R2L glyph rows.
799 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
800 (init_iterator): Don't initialize it->bidi_p for strings
801 here.
802 (reseat_to_string): Initialize it->bidi_p for strings here.
803 (next_element_from_string, next_element_from_c_string)
804 (next_element_from_buffer): Add xassert's for correspondence
805 between IT's object being iterated and it->bidi_it.string
806 structure.
807 (face_before_or_after_it_pos): Support bidi iteration.
808 (next_element_from_c_string): Handle the case of the first string
809 character that is not the first one in the visual order.
810 (get_visually_first_element): New function, refactored from common
811 parts of next_element_from_buffer, next_element_from_string, and
812 next_element_from_c_string.
813 (tool_bar_lines_needed, redisplay_tool_bar)
814 (display_menu_bar): Force left-to-right direction. Add a FIXME
815 comment for making that be controlled by a user option.
816 (push_it, pop_it): Save and restore the state of the
817 bidi iterator. Save and restore the bidi_p flag.
818 (pop_it): Iterate out of display property for string iteration as
819 well.
820 (iterate_out_of_display_property): Support iteration over strings.
821 (handle_single_display_spec): Set up it->bidi_it for iteration
822 over a display string, and call bidi_init_it.
823 (handle_single_display_spec, next_overlay_string)
824 (get_overlay_strings_1, push_display_prop): Set up the bidi
825 iterator for displaying display or overlay strings.
826 (forward_to_next_line_start): Don't use the shortcut if
827 bidi-iterating.
828 (back_to_previous_visible_line_start): If handle_display_prop
829 pushed the iterator stack, restore the internal state of the bidi
830 iterator by calling bidi_pop_it same number of times.
831 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
832 and we are bidi-iterating, don't decrement the iterator position;
833 instead, set the first_elt flag in the bidi iterator, to produce
834 the same effect.
835 (reseat_1): Remove redundant setting of string_from_display_prop_p.
836 (push_display_prop): xassert that we are iterating a buffer.
837 (push_it, pop_it): Save and restore paragraph_embedding member.
838 (handle_single_display_spec, next_overlay_string)
839 (get_overlay_strings_1, reseat_1, reseat_to_string)
840 (push_display_prop): Set up the `unibyte' member of bidi_it.string
841 correctly. Don't assume unibyte strings are not bidi-reordered.
842 (compute_display_string_pos)
843 (compute_display_string_end): Fix handling the case of C string.
844 (push_it, pop_it): Save and restore from_disp_prop_p.
845 (handle_single_display_spec, push_display_prop): Set the
846 from_disp_prop_p flag.
847 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
848 (pop_it): Call iterate_out_of_display_property only if we are
849 popping after iteration over a string that came from a display
850 property. Fix a typo in popping stretch info. Add an assertion
851 for verifying that the iterator position is in sync with the bidi
852 iterator.
853 (handle_single_display_spec, get_overlay_strings_1)
854 (push_display_prop): Fix initialization of paragraph direction for
855 string when that of the parent object is not yet determined.
856 (reseat_1): Call bidi_init_it to resync the bidi
857 iterator with IT's position. (Bug#7616)
858 (find_row_edges): If ROW->start.pos gives position
859 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
860 (handle_stop, back_to_previous_visible_line_start, reseat_1):
861 Reset the from_disp_prop_p flag.
862 (SAVE_IT, RESTORE_IT): New macros.
863 (pos_visible_p, face_before_or_after_it_pos)
864 (back_to_previous_visible_line_start)
865 (move_it_in_display_line_to, move_it_in_display_line)
866 (move_it_to, move_it_vertically_backward, move_it_by_lines)
867 (try_scrolling, redisplay_window, display_line): Use them when
868 saving a temporary copy of the iterator and restoring it back.
869 (back_to_previous_visible_line_start, reseat_1)
870 (init_iterator): Empty the bidi cache "stack".
871 (move_it_in_display_line_to): If iterator ended up at
872 EOL, but we never saw any buffer positions smaller than
873 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
874 motion in bidi-reordered lines.
875 (move_it_in_display_line_to): Record prev_method and prev_pos
876 immediately before the call to set_iterator_to_next. Fixes cursor
877 motion in bidi-reordered lines with stretch glyphs and strings
878 displayed in margins. (Bug#8133) (Bug#8867)
879 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
880 TO_CHARPOS.
640c8776
SM
881 (pos_visible_p): Support positions in bidi-reordered lines.
882 Save and restore bidi cache.
0bb23927
EZ
883
884 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
885 (bidi_paragraph_info): Delete unused struct.
886 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
887 (bidi_cache_start): New variable.
888 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
889 to zero.
890 (bidi_cache_fetch_state, bidi_cache_search)
891 (bidi_cache_find_level_change, bidi_cache_iterator_state)
892 (bidi_cache_find, bidi_peek_at_next_level)
893 (bidi_level_of_next_char, bidi_find_other_level_edge)
894 (bidi_move_to_visually_next): Compare cache index with
895 bidi_cache_start rather than with zero.
896 (bidi_fetch_char): Accept new argument STRING; all callers
897 changed. Support iteration over a string. Support strings with
898 display properties. Support unibyte strings. Fix the type of
899 `len' according to what STRING_CHAR_AND_LENGTH expects.
900 (bidi_paragraph_init, bidi_resolve_explicit_1)
901 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
902 (bidi_level_of_next_char, bidi_move_to_visually_next):
903 Support iteration over a string.
0bb23927
EZ
904 (bidi_set_sor_type, bidi_resolve_explicit_1)
905 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
906 can now be zero (for strings); special values 0 and -1 were
907 changed to -1 and -2, respectively.
908 (bidi_char_at_pos): New function.
909 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
910 Call it instead of FETCH_MULTIBYTE_CHAR.
911 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
912 initialized to valid values.
913 (bidi_init_it): Don't initialize charpos and bytepos with invalid
914 values.
915 (bidi_level_of_next_char): Allow the sentinel "position" to pass
916 the test for valid cached positions. Fix the logic for looking up
917 the sentinel state in the cache. GCPRO the Lisp string we are
918 iterating.
919 (bidi_push_it, bidi_pop_it): New functions.
920 (bidi_initialize): Initialize the bidi cache start stack pointer.
921 (bidi_cache_ensure_space): New function, refactored from part of
922 bidi_cache_iterator_state. Don't assume the required size is just
923 one BIDI_CACHE_CHUNK away.
924 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
925 (bidi_count_bytes, bidi_char_at_pos): New functions.
926 (bidi_cache_search): Don't assume bidi_cache_last_idx is
927 always valid if bidi_cache_idx is valid.
928 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
929 is valid if it's going to be used.
930 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
931 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
932 (bidi_cache_find_level_change, bidi_cache_ensure_space)
933 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
934 (bidi_find_other_level_edge, bidi_cache_start_stack):
935 All variables related to cache indices are now EMACS_INT.
c965adc5 936
0bb23927
EZ
937 * dispextern.h (struct bidi_string_data): New structure.
938 (struct bidi_it): New member `string'. Make flag members be 1-bit
939 fields, and put them last in the struct.
640c8776
SM
940 (compute_display_string_pos, compute_display_string_end):
941 Update prototypes.
0bb23927
EZ
942 (bidi_push_it, bidi_pop_it): Add prototypes.
943 (struct iterator_stack_entry): New members bidi_p,
944 paragraph_embedding, and from_disp_prop_p.
945 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
946 (bidi_shelve_cache, bidi_unshelve_cache):
947 Declare prototypes.
0bb23927
EZ
948
949 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
950 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
951 and vector-like objects.
952
953 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
954 cache around display iteration.
955
956 * window.c (Fwindow_end, window_scroll_pixel_based)
957 (displayed_window_lines, Frecenter): Save and restore the bidi
958 cache around display iteration.
959
3bbd2265
LMI
9602011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
961
962 * editfns.c (Fdelete_region): Clarify the use of the named
963 parameters (bug#6788).
964
adc47434
MR
9652011-07-14 Martin Rudalics <rudalics@gmx.at>
966
967 * indent.c (Fvertical_motion): Set and restore w->pointm when
968 saving and restoring the window's buffer (Bug#9006).
969
837c31f8
LMI
9702011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
971
972 * editfns.c (Fstring_to_char): Clarify just what is returned
973 (bug#6576). Text by Eli Zaretskii.
974
ac389d0c
JB
9752011-07-13 Juanma Barranquero <lekktu@gmail.com>
976
977 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
978
0be0ce47
EZ
9792011-07-13 Eli Zaretskii <eliz@gnu.org>
980
981 * buffer.c (mmap_find): Fix a typo.
982
cd18e7e3
JB
9832011-07-13 Johan Bockgård <bojohan@gnu.org>
984
985 Fix execution of x selection hooks.
986 * xselect.c (Qx_lost_selection_functions)
987 (Qx_sent_selection_functions): New vars.
988 (syms_of_xselect): DEFSYM them.
989 (x_handle_selection_request): Pass Qx_sent_selection_functions
990 rather than Vx_sent_selection_functions to Frun_hook_with_args.
991 (x_handle_selection_clear,x_clear_frame_selections):
992 Pass Qx_lost_selection_functions rather than
993 Vx_lost_selection_functions to Frun_hook_with_args.
994
47ea7f44
PE
9952011-07-13 Paul Eggert <eggert@cs.ucla.edu>
996
ac389d0c 997 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
998 The old code sometimes used this field without initializing it.
999
47ea7f44
PE
1000 * alloc.c (gc_sweep): Don't read past end of array.
1001 In theory, the old code could also have corrupted Emacs internals,
1002 though it'd be very unlikely.
1003
bc985c87
AS
10042011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1005
1006 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1007 argument. (Bug#4026)
bc985c87 1008
0cf34688
LMI
10092011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1010
b3dadd76
LMI
1011 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1012 key" (bug#4257).
1013
0cf34688
LMI
1014 * window.c (Fset_window_start): Doc fix (bug#4199).
1015 (Fset_window_hscroll): Ditto.
1016
270768cd
PE
10172011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1018
077e3dda 1019 Fix minor new problems caught by GCC 4.6.1.
270768cd 1020 * term.c (init_tty): Remove unused local.
490011a6 1021 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1022 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1023 not used otherwise.
270768cd 1024
b1f58454
CY
10252011-07-12 Chong Yidong <cyd@stupidchicken.com>
1026
1027 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1028
22b9578d
LMI
10292011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1030
6e70ab07
LMI
1031 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1032 are the mini-buffer and the echo area (bug#3320).
1033
22b9578d
LMI
1034 * term.c (init_tty): Remove support for supdup, c10 and perq
1035 terminals, which are no longer supported (bug#1482).
1036
8974cc9f
JB
10372011-07-10 Johan Bockgård <bojohan@gnu.org>
1038
1039 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1040
a560d974
JD
10412011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1042
1043 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1044 for non-popups (Bug#3642).
1045
1dae0f0a
AS
10462011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1047
268c2c36 1048 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1049 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1050 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1051 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1052 * data.c (fmod): Likewise.
1053 * dispnew.c (swap_glyphs_in_rows): Likewise.
1054 * emacs.c (memory_warning_signal): Likewise.
1055 * floatfns.c (float_error): Likewise.
1056 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1057 (otf_open, font_otf_capability, generate_otf_features)
1058 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1059 Likewise.
1060 * image.c (pbm_read_file): Likewise.
1061 * indent.c (string_display_width): Likewise.
1062 * intervals.c (check_for_interval, search_for_interval)
1063 (inc_interval_count, count_intervals, root_interval)
1064 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1065 * lread.c (defalias): Likewise.
268c2c36 1066 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1067 * regex.c (set_image_of_range_1, set_image_of_range)
1068 (regex_grow_registers): Likewise.
1069 * sysdep.c (strerror): Likewise.
1070 * termcap.c (valid_filename_p, tprint, main): Likewise.
1071 * tparam.c (main): Likewise.
1072 * unexhp9k800.c (run_time_remap, save_data_space)
1073 (update_file_ptrs, read_header, write_header, calculate_checksum)
1074 (copy_file, copy_rest, display_header): Likewise.
1075 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1076 Likewise.
1077 * xdisp.c (check_it): Likewise.
1078 * xfaces.c (register_color, unregister_color, unregister_colors):
1079 Likewise.
1080 * xfns.c (print_fontset_result): Likewise.
1081 * xrdb.c (member, fatal, main): Likewise.
1082
99033785
PE
10832011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1084
1085 Fix minor problems found by static checking (Bug#9031).
1086 * chartab.c (char_table_set_range, map_sub_char_table):
1087 Remove unused locals.
1088 (uniprop_table): Now static.
1089 * composite.c (_work_char): Remove unused static var.
1090
9cb2ac56
JB
10912011-07-09 Juanma Barranquero <lekktu@gmail.com>
1092
1093 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1094
f25661f0
JD
10952011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1096
1097 * gtkutil.c (qttip_cb): Remove code without function.
1098
8278c4fe
EZ
10992011-07-09 Eli Zaretskii <eliz@gnu.org>
1100
1101 * w32.c (pthread_sigmask): New stub.
1102
1692ae2d 11032011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1104
8a6ebd58 1105 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1106 sigprocmask is portable only for single-threaded applications, and
1107 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1108 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1109 (LIBES): Use it.
1110 * callproc.c (Fcall_process):
1111 * process.c (create_process):
1112 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1113 Use pthread_sigmask, not sigprocmask.
123403e4 1114
1b854618
JD
11152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1116
1117 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1118 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1119 wrong (Bug#8591).
1120
3fe4b549
JD
11212011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1122
0ce7e563
JD
1123 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1124 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1125 (xg_hide_tooltip): Fix comment.
1126
3fe4b549
JD
1127 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1128 in registerServicesMenuSendTypes.
1129 (validRequestorForSendType): Don't check ns_return_types.
1130
1131 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1132 ns_return_type.
1133
5df75e47
JR
11342011-07-08 Jason Rumney <jasonr@gnu.org>
1135
1136 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1137 frame struct members of non-existent frames (Bug#6284).
1138
699c10bd
JD
11392011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1140
4393663b
JD
1141 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1142 variable firstTime not needed on OSX >= 10.6.
1143 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1144 >= 10.5. Use setKnobProportion, setDoubleValue.
1145
1146 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1147 (MAC_OS_X_VERSION_10_5): Define if not defined.
1148 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1149 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1150 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1151
1152 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1153 cString and lossyCString on OSX >= 10.4
1154
1155 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1156 sizeToFit on OSX >= 10.2.
1157
1158 * nsimage.m (allocInitFromFile): Don't use deprecated method
1159 bestRepresentationForDevice on OSX >= 10.6.
1160
1161 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1162 to avoid warning.
1163
1164 * emacs.c: Declare unexec_init_emacs_zone.
1165
a63e0781
JD
1166 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1167
699c10bd
JD
1168 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1169
1170 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1171 on svcsMenu (Bug#8842).
1172
1173 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1174 ns_return_types.
1175 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1176
1177 * nsterm.m (QUTF8_STRING): Declare.
1178 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1179 (validRequestorForSendType): Return type is (id).
1180 Change indexOfObjectIdenticalTo to indexOfObject.
1181 Check if we have local selection before returning self (Bug#8842).
1182 (writeSelectionToPasteboard): Put local selection into paste board
1183 if we have a local selection (Bug#8842).
1184 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1185
1186 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1187 (ns_get_local_selection): Declare.
1188
54e10184
LMI
11892011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1190
9888ff71
LMI
1191 * keymap.c (describe_map_tree): Don't insert a double newline at
1192 the end of the buffer (bug#1169) and return whether we inserted
1193 something.
1194
54e10184
LMI
1195 * callint.c (Fcall_interactively): Change "reading args" to
1196 "providing args" to try to clarify what it does (bug#1010).
1197
15fa4783
KH
11982011-07-07 Kenichi Handa <handa@m17n.org>
1199
1200 * composite.c (composition_compute_stop_pos): Ignore a static
1201 composition starting before CHARPOS (Bug#8915).
1202
1203 * xdisp.c (handle_composition_prop): Likewise.
1204
a8815b00
EZ
12052011-07-07 Eli Zaretskii <eliz@gnu.org>
1206
1207 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1208 (Bug#9015)
1209
ef7b981d 12102011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1211
1212 * character.h (unicode_category_t): New enum type.
1213
1214 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1215 (Qchar_code_property_table): New variable.
1216 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1217 (UNIPROP_COMPRESSED_FORM_P): New macros.
1218 (char_table_ascii): Uncompress the compressed values.
1219 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1220 Uncompress the compressed values.
ac389d0c 1221 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1222 (char_table_ref_and_range): Uncompress the compressed values.
1223 (sub_char_table_set): New arg is_uniprop. Callers changed.
1224 Uncompress the compressed values.
1225 (sub_char_table_set_range): Args changed. Callers changed.
1226 (char_table_set_range): Adjuted for the above change.
1227 (map_sub_char_table): Delete args default_val and parent. Add arg
1228 top. Give decoded values to a Lisp function.
640c8776 1229 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1230 values to a Lisp function. Gcpro more variables.
1231 (uniprop_table_uncompress)
1232 (uniprop_decode_value_run_length): New functions.
1233 (uniprop_decoder, uniprop_decoder_count): New variables.
1234 (uniprop_get_decoder, uniprop_encode_value_character)
1235 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1236 New functions.
1237 (uniprop_encoder, uniprop_encoder_count): New variables.
1238 (uniprop_get_encoder, uniprop_table)
1239 (Funicode_property_table_internal, Fget_unicode_property_internal)
1240 (Fput_unicode_property_internal): New functions.
1241 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1242 Sunicode_property_table_internal, Sget_unicode_property_internal,
1243 and Sput_unicode_property_internal. Defvar_lisp
1244 char-code-property-alist.
1245
640c8776 1246 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1247 Vunicode_category_table.
1248
640c8776 1249 * font.c (font_range): Adjust for the change of
c805dec0
KH
1250 Vunicode_category_table.
1251
76b397fb
DN
12522011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1253
1254 * m/iris4d.h: Remove file, move contents ...
1255 * s/irix6-5.h: ... here.
1256
22b4128e
PE
12572011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1258
1259 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1260 * alloc.c (mark_buffer):
1261 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1262 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1263 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1264 This isn't true in general, and it's particularly not true
1265 if Emacs is configured with --with-wide-int.
1266 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1267 New macros, used in the buffer.c change.
1268
869795d6
JD
12692011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1270
1271 * xsettings.c: Use both GConf and GSettings if both are available.
1272 (store_config_changed_event): Add comment.
1273 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1274 (store_tool_bar_style_changed): New functions.
1275 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1276 (struct xsettings): Move font inside HAVE_XFT.
1277 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1278 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1279 Move inside HAVE_XFT.
640c8776 1280 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1281 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1282 also.
1283 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1284 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1285 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1286 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1287 (parse_settings): Move check for font inside HAVE_XFT.
1288 (read_settings, apply_xft_settings): Add comment.
1289 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1290 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1291 call store_font_name_changed.
1292 (xft_settings_event): Add comment.
1293 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1294 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1295 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1296 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1297 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1298 (xsettings_get_system_font, xsettings_get_system_normal_font):
1299 Add comment.
869795d6 1300
d8ed26bd
PE
13012011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1302
1303 Random fixes. E.g., (random) never returned negative values.
1304 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1305 subseconds part to the entropy, as that's a bit more random.
1306 Prefer signed to unsigned, since the signedness doesn't matter and
1307 in general we prefer signed. When given a limit, use a
1308 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1309 latter isn't right if USE_2_TAGS_FOR_INTS.
1310 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1311 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1312
cabf1cac
SM
13132011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1314
1315 * textprop.c (text_property_stickiness):
1316 Obey Vtext_property_default_nonsticky.
1317 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1318 * w32fns.c (syms_of_w32fns):
1319 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1320
6e9b2be9
PE
13212011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1322
1323 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1324 This is more efficient than Ffile_directory_p and avoids a minor race.
1325
90186c68
LMI
13262011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1327
7c301272
LMI
1328 * buffer.c (Foverlay_put): Say what the return value is
1329 (bug#7835).
1330
c4f2d8d4
LMI
1331 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1332 is a directory before asking whether to use the file name
1333 (bug#7564).
ad637907
LMI
1334 (barf_or_query_if_file_exists): Make the "File is a directory"
1335 error be more correct.
c4f2d8d4 1336
90186c68
LMI
1337 * fns.c (Frequire): Remove the mention of the .gz files, since
1338 that's installation-specific, but keep the mention of
1339 `get-load-suffixes'.
1340
da64016e
PE
13412011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1342
1343 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1344 Report string overflow if the output is too long.
1345
7d47b580
JB
13462011-07-04 Juanma Barranquero <lekktu@gmail.com>
1347
a555cb87
JB
1348 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1349 (syms_of_gnutls): Remove duplicate DEFSYM for
1350 Qgnutls_bootprop_verify_hostname_error, an error for
1351 Qgnutls_bootprop_verify_error (which is no longer used).
1352
7d47b580
JB
1353 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1354 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1355 Also (re)move comments that are misplaced or no longer relevant.
1356
1e49bfab
LMI
13572011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1358
1359 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1360
1485f4c0
CY
13612011-07-03 Chong Yidong <cyd@stupidchicken.com>
1362
1363 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1364 and background color parameters if they have been changed.
1365
a9ab721e
LMI
13662011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1367
1368 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1369
cf7cff57
PE
13702011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1371
2e13213d
PE
1372 * xsettings.c (SYSTEM_FONT): Define only when used.
1373 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1374
cf7cff57
PE
1375 * keymap.c (access_keymap_1): Now static.
1376
7a8e04f7
CY
13772011-07-02 Chong Yidong <cyd@stupidchicken.com>
1378
1379 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1380 leave any prefix arg for the up event (Bug#1586).
1381
61352f62
LMI
13822011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1383
69bb1ef7
LMI
1384 * lread.c (syms_of_lread): Mention single symbols defined by
1385 `defvar' or `defconst' (bug#7154).
1386
61352f62 1387 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1388 (Frequire): Mention get-load-suffixes.
61352f62 1389
28545e04
MR
13902011-07-02 Martin Rudalics <rudalics@gmx.at>
1391
1392 * window.h (window): Remove clone_number slot.
1393 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1394 Remove.
1395 (make_parent_window, make_window, saved_window)
1396 (Fset_window_configuration, save_window_save): Don't deal with
1397 clone numbers.
1398 * buffer.c (Qclone_number): Remove declaration.
1399 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1400
3349e122
SM
14012011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1402
1403 Add multiple inheritance to keymaps.
1404 * keymap.c (Fmake_composed_keymap): New function.
1405 (Fset_keymap_parent): Simplify.
1406 (fix_submap_inheritance): Remove.
1407 (access_keymap_1): New function extracted from access_keymap to handle
1408 embedded parents and handle lists of maps.
1409 (access_keymap): Use it.
1410 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1411 (Fcopy_keymap): Handle embedded parents.
1412 (Fcommand_remapping, define_as_prefix): Simplify.
1413 (Fkey_binding): Simplify.
1414 (syms_of_keymap): Move minibuffer-local-completion-map,
1415 minibuffer-local-filename-completion-map,
1416 minibuffer-local-must-match-map, and
1417 minibuffer-local-filename-must-match-map to Elisp.
1418 (syms_of_keymap): Defsubr make-composed-keymap.
1419 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1420 (parse_menu_item): Trivial simplification.
1421
3279eb87
GM
14222011-07-01 Glenn Morris <rgm@gnu.org>
1423
1424 * Makefile.in (SETTINGS_LIBS): Fix typo.
1425
4550efdf
KI
14262011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1427
1428 * coding.c (Fencode_coding_string): Record the last coding system
1429 used, as the function doc string says (bug#8738).
1430
0949d2b6
JD
14312011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1432
1433 * xsettings.c (store_monospaced_changed): Take new font as arg and
1434 check for change against current_mono_font.
1435 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1436 (emacs_settings_constructor, emacs_settings_get_property)
1437 (emacs_settings_set_property, emacs_settings_class_init)
1438 (emacs_settings_init, gsettings_obj): Remove.
1439 (something_changedCB): New function for HAVE_GSETTINGS.
1440 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1441 with value as argument.
1442 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1443 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1444 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1445 "changed".
1446
1447 * xgselect.c: Add defined (HAVE_GSETTINGS).
1448 (xgselect_initialize): Ditto.
1449
1450 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1451 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1452 xg_select.
1453
bbc6b304
PE
14542011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1455
1456 * eval.c (struct backtrace): Simplify and port the data structure.
1457 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1458 signed bit field, as this assumption is not portable and it makes
1459 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1460 "char debug_on_exit : 1" as this is not portable either; instead,
1461 use the portable "unsigned int debug_on_exit : 1". Remove unused
1462 member evalargs. Remove obsolete comments about cc bombing out.
1463
9851bfc5
JD
14642011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1465
51bb811f 1466 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1467 Let HAVE_GSETTINGS override HAVE_GCONF.
1468 (store_monospaced_changed): New function.
1469 (EMACS_SETTINGS): A new type derived from GObject to handle
1470 GSettings notifications.
1471 (emacs_settings_constructor, emacs_settings_get_property)
1472 (emacs_settings_set_property, emacs_settings_class_init):
1473 New functions.
1474 (gsettings_client, gsettings_obj): New variables.
1475 (GSETTINGS_SCHEMA): New define.
1476 (something_changedCB): Call store_monospaced_changed.
1477 (init_gsettings): New function.
1478 (xsettings_initialize): Call init_gsettings.
1479 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1480 to NULL.
1481
640c8776 1482 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1483 GCONF_CFLAGS/LIBS.
1484
5386012d
MR
14852011-06-29 Martin Rudalics <rudalics@gmx.at>
1486
1487 * window.c (resize_root_window, grow_mini_window)
1488 (shrink_mini_window): Rename Qresize_root_window to
1489 Qwindow_resize_root_window and Qresize_root_window_vertically to
1490 Qwindow_resize_root_window_vertically.
1491
f13e0b08
PE
14922011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1493
1494 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1495
94515237
JB
14962011-06-27 Juanma Barranquero <lekktu@gmail.com>
1497
1498 * makefile.w32-in: Redesign dependencies so they reflect more
1499 clearly which files are directly included by each source file,
1500 and not through other includes.
1501
e43b6e43
MR
15022011-06-27 Martin Rudalics <rudalics@gmx.at>
1503
1504 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1505 (sort_overlays, overlay_strings): When an overlay's clone number
1506 matches the window's clone number process the overlay even if
1507 the overlay's window property doesn't match the current window.
1508
d68443dc
MR
1509 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1510 (Fwindow_hchild): Rename to Fwindow_left_child.
1511 (Fwindow_next): Rename to Fwindow_next_sibling.
1512 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1513 (resize_window_check): Rename to window_resize_check.
1514 (resize_window_apply): Rename to window_resize_apply.
1515 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1516 (Fdelete_other_windows_internal, resize_frame_windows)
1517 (Fsplit_window_internal, Fdelete_window_internal)
1518 (grow_mini_window, shrink_mini_window)
1519 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1520
c7e73be5
JD
15212011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1522
1523 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1524 (emacs_fixed_set_min_size): Remove.
1525 (emacs_fixed_new): Take frame as argument.
1526
1527 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1528 (_EmacsFixedPrivate): Remove minwidth/height.
1529 Add struct frame *f.
1530 (emacs_fixed_init): Initialize priv->f.
1531 (get_parent_class, emacs_fixed_set_min_size): Remove.
1532 (emacs_fixed_new): Set priv->f to argument.
1533 (emacs_fixed_get_preferred_width)
1534 (emacs_fixed_get_preferred_height): Use min_width/height from
1535 frames size_hint to set minimum and natural (Bug#8919).
1536 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1537 and use min_width/height from frames size_hint to set
1538 min_width/height (Bug#8919).
1539
1540 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1541 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1542 Fix indentation.
c7e73be5 1543
cf99dcf8
EZ
15442011-06-26 Eli Zaretskii <eliz@gnu.org>
1545
1546 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1547 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1548 called at ZV.
1549
029529ac
CY
15502011-06-26 Chong Yidong <cyd@stupidchicken.com>
1551
1552 * process.c (wait_reading_process_output): Bypass select if
1553 waiting for a cell while ignoring keyboard input, and input is
1554 pending. Suggested by Jan Djärv (Bug#8869).
1555
7a7ef429
PE
15562011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1557
1558 Use gnulib's dup2 module instead of rolling our own.
1559 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1560
11fdef7d 15612011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1562
1563 * dispnew.c (scrolling_window): Before scrolling, turn off a
1564 mouse-highlight in the window being scrolled.
1565
cd3520a4
JB
15662011-06-24 Juanma Barranquero <lekktu@gmail.com>
1567
1568 Move DEFSYM to lisp.h and use everywhere.
1569
1570 * character.h (DEFSYM): Move declaration...
1571 * lisp.h (DEFSYM): ...here.
1572
1573 * gnutls.c:
1574 * minibuf.c:
1575 * w32menu.c:
1576 * w32proc.c:
1577 * w32select.c: Don't include character.h.
1578
1579 * alloc.c (syms_of_alloc):
1580 * buffer.c (syms_of_buffer):
1581 * bytecode.c (syms_of_bytecode):
1582 * callint.c (syms_of_callint):
1583 * casefiddle.c (syms_of_casefiddle):
1584 * casetab.c (init_casetab_once):
1585 * category.c (init_category_once, syms_of_category):
1586 * ccl.c (syms_of_ccl):
1587 * cmds.c (syms_of_cmds):
1588 * composite.c (syms_of_composite):
1589 * dbusbind.c (syms_of_dbusbind):
1590 * dired.c (syms_of_dired):
1591 * dispnew.c (syms_of_display):
1592 * doc.c (syms_of_doc):
1593 * editfns.c (syms_of_editfns):
1594 * emacs.c (syms_of_emacs):
1595 * eval.c (syms_of_eval):
1596 * fileio.c (syms_of_fileio):
1597 * fns.c (syms_of_fns):
1598 * frame.c (syms_of_frame):
1599 * fringe.c (syms_of_fringe):
1600 * insdel.c (syms_of_insdel):
1601 * keymap.c (syms_of_keymap):
1602 * lread.c (init_obarray, syms_of_lread):
1603 * macros.c (syms_of_macros):
1604 * msdos.c (syms_of_msdos):
1605 * print.c (syms_of_print):
1606 * process.c (syms_of_process):
1607 * search.c (syms_of_search):
1608 * sound.c (syms_of_sound):
1609 * syntax.c (init_syntax_once, syms_of_syntax):
1610 * terminal.c (syms_of_terminal):
1611 * textprop.c (syms_of_textprop):
1612 * undo.c (syms_of_undo):
1613 * w32.c (globals_of_w32):
1614 * window.c (syms_of_window):
1615 * xdisp.c (syms_of_xdisp):
1616 * xfaces.c (syms_of_xfaces):
1617 * xfns.c (syms_of_xfns):
1618 * xmenu.c (syms_of_xmenu):
1619 * xsettings.c (syms_of_xsettings):
1620 * xterm.c (syms_of_xterm): Use DEFSYM.
1621
4228cf16
TZ
16222011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1623
cd3520a4 1624 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1625
7fcccf1e
PE
16262011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1627
7efb4e0e
PE
1628 Integer and buffer overflow fixes (Bug#8873).
1629
ff5844ad
PE
1630 * print.c (printchar, strout): Check for string overflow.
1631 (PRINTPREPARE, printchar, strout):
1632 Don't set size unless allocation succeeds.
1633
90532f02
PE
1634 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1635 for sizes. Check for string overflow more accurately.
1636 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1637
6d84508d
PE
1638 * macros.c: Integer and buffer overflow fixes.
1639 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1640 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1641 Use ptrdiff_t, not int, for sizes.
1642 Don't increment bufsize until after realloc succeeds.
1643 Check for size-calculation overflow.
1644 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1645
437b2cb4
PE
1646 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1647
8b9ac8b4
PE
1648 * lread.c: Integer overflow fixes.
1649 (read_integer): Radix is now EMACS_INT, not int,
1650 to improve quality of diagnostics for out-of-range radices.
1651 Calculate buffer size correctly for out-of-range radices.
1652 (read1): Check for integer overflow in radices, and in
1653 read-circle numbers.
82cb60d3
PE
1654 (read_escape): Avoid int overflow.
1655 (Fload, openp, read_buffer_size, read1)
1656 (substitute_object_recurse, read_vector, read_list, map_obarray):
1657 Use ptrdiff_t, not int, for sizes.
1658 (read1): Use EMACS_INT, not int, for sizes.
20270765 1659 Check for size overflow.
8b9ac8b4 1660
7fcccf1e
PE
1661 * image.c (cache_image): Check for size arithmetic overflow.
1662
bfbbd7e7
PE
1663 * lread.c: Integer overflow issues.
1664 (saved_doc_string_size, saved_doc_string_length)
1665 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1666 Now ptrdiff_t, not int.
1667 (read1): Don't assume doc string length fits in int. Check for
1668 out-of-range doc string lengths.
1669 (read_list): Don't assume file position fits in int.
39019e54 1670 (read_escape): Check for hex character overflow.
bfbbd7e7 1671
4e323265
LL
16722011-06-22 Leo Liu <sdl.web@gmail.com>
1673
1674 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1675 Move to minibuffer.el.
1676
85fece3e
PE
16772011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1678
20b84ce9 1679 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1680 The following patches are for when GLYPH_DEBUG && !XASSERT.
1681 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1682 * dispnew.c (flush_stdout):
1683 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1684 Mark as externally visible.
1685 * dispnew.c (check_window_matrix_pointers): Now static.
1686 * dispnew.c (window_to_frame_vpos):
1687 * xfns.c (unwind_create_frame):
1688 * xterm.c (x_check_font): Remove unused local.
1689 * scroll.c (CHECK_BOUNDS):
1690 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1691 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1692 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1693 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1694 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1695 Now static.
1696 (debug_method_add): Use va_list and vsprintf rather than relying
1697 on undefined behavior with wrong number of arguments.
1698 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1699 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1700 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1701 since we're not interested in debugging glyphs with old libraries.
1702 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1703 GCC 4.6.0's static checking.
1704
0766b489
PE
17052011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1706
31fd4b32
PE
1707 Integer overflow and signedness fixes (Bug#8873).
1708 A few related buffer overrun fixes, too.
1709
b79e8648
PE
1710 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1711
0766b489
PE
1712 * dispextern.h (struct face.stipple):
1713 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1714 (x_bitmap_mask, x_allocate_bitmap_record)
1715 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1716 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1717 (x_create_bitmap_from_xpm_data):
1718 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1719 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1720 (.bitmaps_last):
1721 * xfaces.c (load_pixmap):
1722 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1723 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1724 (.bitmaps_last, struct x_output.icon_bitmap):
1725 Use ptrdiff_t, not int, for bitmap indexes.
1726 (x_allocate_bitmap_record): Check for size overflow.
1727 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1728
b081724f
PE
1729 Use ptrdiff_t, not int, for overlay counts.
1730 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1731 * editfns.c (overlays_around, get_pos_property):
1732 * textprop.c (get_char_property_and_overlay):
1733 * xdisp.c (next_overlay_change, note_mouse_highlight):
1734 * xfaces.c (face_at_buffer_position):
21514da7
PE
1735 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1736 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1737 (Fnext_overlay_change, Fprevious_overlay_change)
1738 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1739 Use ptrdiff_t, not int, for sizes.
21514da7 1740 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1741
3de73e5e
PE
1742 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1743
2606c57b
PE
1744 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1745 (x_session_initialize): Do not assume string length fits in int.
1746
aaafe47a
PE
1747 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1748 This is unlikely, but can occur if DPI is outlandish.
1749
2674ddc8 1750 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1751 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1752
28154962
PE
1753 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1754 * xrdb.c (magic_file_p, search_magic_path):
1755 Omit last arg SUFFIX; it was always 0. All callers changed.
1756 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1757
7de51af5
PE
1758 * xfont.c (xfont_match): Avoid need for strlen.
1759
25ed6cc3
PE
1760 * xfns.c: Don't assume strlen fits in int.
1761 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1762
4eab31dd
PE
1763 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1764 not unsigned long, as we prefer signed integers. All callers changed.
1765 Detect integer overflow in repeat count.
1766 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1767 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1768
171e2a58
PE
1769 * termcap.c: Don't assume sizes fit in int and never overflow.
1770 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1771 (gobble_line): Check for size-calculation overflow.
1772
ad39faca 1773 * minibuf.c (Fread_buffer):
6e5bb2dc 1774 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1775 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1776 Don't assume string length fits in int.
1777
52c61c22 1778 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1779 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1780
b5b8c9e5
PE
1781 * font.c: Don't assume string length fits in int.
1782 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1783 Use ptrdiff_t, not int.
ccd6111c
PE
1784 (font_intern_prop): Don't assume string length fits in int.
1785 Don't assume integer property fits in fixnum.
1786 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1787
882f0d81 1788 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1789 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1790 Reformulate so as not to need the command string.
1791 Invoke gzip -cd rather than gunzip, as it's more portable.
1792 (lock_info_type, lock_file_1, lock_file):
1793 Don't assume pid_t and time_t fit in unsigned long.
1794 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1795 (current_lock_owner): Prefer signed type for sizes.
1796 Use memcpy, not strncpy, where memcpy is what is really wanted.
1797 Don't assume (via atoi) that time_t and pid_t fit in int.
1798 Check for time_t and/or pid_t out of range, e.g., via a network share.
1799 Don't alloca where an auto var works fine.
1800
93f4cf88
PE
1801 * fileio.c: Fix some integer overflow issues.
1802 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1803 Don't assume string length fits in int.
1804 (directory_file_name): Don't assume string length fits in long.
1805 (make_temp_name): Don't assume pid fits in int, or that its print
1806 length is less than 20.
1807
f3e92b69
PE
1808 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1809
1bfdaf10
PE
1810 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1811
35016e9a
PE
1812 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1813
3d1e65a1
PE
1814 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1815 We prefer signed integers, even for size calculations.
1816
0b963a93
PE
1817 * emacs.c: Don't assume string length fits in 'int'.
1818 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1819 (main): Don't invoke strlen when not needed.
1820
573f4b54
PE
1821 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1822 (XD_DEBUG_MESSAGE): Don't waste a byte.
1823
989f33ba
PE
1824 * callproc.c (getenv_internal_1, getenv_internal)
1825 (Fgetenv_internal):
965d34eb
PE
1826 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1827
e4d29b33
PE
1828 * lread.c (invalid_syntax): Omit length argument.
1829 All uses changed. This doesn't fix a bug, but it simplifies the
1830 code away from its former Hollerith-constant appearance, and it's
1831 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1832 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1833
eb49b136
PE
1834 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1835 This didn't break anything, but it didn't help either.
1836 It's confusing to put a bogus integer in a place where the actual
1837 value does not matter.
9f62aeb1 1838 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1839 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1840
15375a22
PE
1841 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1842 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1843 implementation.
b61cc01c
PE
1844 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1845 We prefer signed types, and the value cannot exceed the EMACS_INT
1846 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1847 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1848 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1849 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1850
53b2623d
PE
1851 * indent.c (sane_tab_width): New function.
1852 (current_column, scan_for_column, Findent_to, position_indentation)
1853 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1854 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1855
51cab52b 1856 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1857
f2ed8a70
PE
1858 * lisp.h (lint_assume): New macro.
1859 * composite.c (composition_gstring_put_cache):
1860 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1861
abe80cc6
PE
1862 * editfns.c, insdel.c:
1863 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1864
b02c740e
PE
1865 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1866
ebc96716
PE
1867 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1868
b4e50fa0 1869 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1870 Use much-faster test for byte-length change.
311d5d7c 1871 Don't assume string byte-length fits in 'int'.
a4cf38e4 1872 Check that character arg fits in 'int'.
85461888 1873 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1874
c0c1ee9f
PE
1875 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1876
a498d7f4
PE
1877 * fns.c (concat): Catch string overflow earlier.
1878 Do not rely on integer wraparound.
1879
51cab52b
PE
1880 * dispextern.h (struct it.overlay_strings_charpos)
1881 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1882 * xdisp.c (forward_to_next_line_start)
1883 (back_to_previous_visible_line_start)
1884 (reseat_at_next_visible_line_start, next_element_from_buffer):
1885 Don't arbitrarily truncate the value of 'selective' to int.
1886
76031fad
PE
1887 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1888
5eb55db9
PE
1889 * composite.c: Don't truncate sizes to 'int'.
1890 (composition_gstring_p, composition_reseat_it)
1891 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1892 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1893 not EMACS_UINT, for indexes.
5eb55db9 1894
0703a717
PE
1895 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1896
d6202519
PE
1897 * buffer.c: Include <verify.h>.
1898 (struct sortvec.priority, struct sortstr.priority):
8961a454 1899 Now EMACS_INT, not int.
c20998a7 1900 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1901 (struct sortstr.size, record_overlay_string)
1902 (struct sortstrlist.size, struct sortlist.used):
1903 Don't truncate size to int.
1904 (record_overlay_string): Check for size-calculation overflow.
d6202519 1905 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1906
d5a19415
JM
19072011-06-22 Jim Meyering <meyering@redhat.com>
1908
029529ac 1909 Don't leak an XBM-image-sized buffer
d5a19415
JM
1910 * image.c (xbm_load): Free the image buffer after using it.
1911
a9041e6c
PE
19122011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1913
1914 Port to Sun C.
1915 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1916 that Sun C diagnosed.
1917 * fns.c (secure_hash): Fix pointer signedness issue.
1918 * intervals.c (static_offset_intervals): New function.
1919 (offset_intervals): Use it.
1920
7f3f739f
LL
19212011-06-21 Leo Liu <sdl.web@gmail.com>
1922
1923 * deps.mk (fns.o):
1924 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1925 sha512.h.
1926
1927 * fns.c (secure_hash): Rename from crypto_hash_function and change
1928 the first arg to accept symbols.
5b66d427 1929 (Fsecure_hash): New primitive.
7f3f739f
LL
1930 (syms_of_fns): New symbols.
1931
76147d94
DD
19322011-06-20 Deniz Dogan <deniz@dogan.se>
1933
1934 * process.c (Fset_process_buffer): Clarify return value in
1935 docstring.
1936
7d7d0045
CY
19372011-06-18 Chong Yidong <cyd@stupidchicken.com>
1938
1939 * dispnew.c (add_window_display_history): Use BVAR.
1940
1941 * xdisp.c (debug_method_add): Use BVAR.
1942 (check_window_end, dump_glyph_matrix, dump_glyph)
1943 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1944
1945 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1946 Likewise.
1947
1948 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1949 check till after the cache is created in init_frame_faces.
1950
ff2bc410
SM
19512011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1952
1953 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1954
28177add
PE
19552011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1956
dd3482fe
PE
1957 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1958 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1959 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1960
393d71f3 1961 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1962 * fileio.c (Finsert_file_contents):
1963 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1964 Remove the old (too-loose) buffer overflow checks.
1965 They weren't needed, since make_gap checks for buffer overflow.
1966 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1967 The old code merely checked for Emacs fixnum overflow, and relied
1968 on undefined (wraparound) behavior. The new code avoids undefined
1969 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1970
2e6813b0 1971 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1972 Tune. Don't use wider integers than needed. Don't use alloca.
1973 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1974
599a9e4f
PE
1975 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1976
99561444
PE
1977 * insdel.c, lisp.h (buffer_overflow): New function.
1978 (insert_from_buffer_1, replace_range, replace_range_2):
1979 * insdel.c (make_gap_larger):
1980 * editfns.c (Finsert_char):
1981 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1982
28177add
PE
1983 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1984
e69dafad
PE
19852011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1986
a7af7fde 1987 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1988
b1c46f02
PE
1989 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1990 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1991
e69dafad
PE
1992 * fileio.c: Don't assume EMACS_INT fits in off_t.
1993 (emacs_lseek): New static function.
1994 (Finsert_file_contents, Fwrite_region): Use it.
1995 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1996
566684ea
PE
1997 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1998
e6966cd6
PE
1999 * fns.c: Don't overflow int when computing a list length.
2000 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2001 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2002 truncation on 64-bit hosts. Check for QUIT every
2003 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2004 faster and is responsive enough.
2005 (Flength): Report an error instead of overflowing an integer.
2006 (Fsafe_length): Return a float if the value is not representable
2007 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2008 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2009 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2010
dd0b0efb
PE
2011 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2012 (header_size, word_size): New constants.
2013 (allocate_vectorlike): Don't check size overflow here.
2014 (allocate_vector): Check it here instead, since this is the only
2015 caller of allocate_vectorlike that could cause overflow.
2016 Check that the new vector's length is representable as a fixnum.
2017
86fe5cfe
PE
2018 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2019 The previous code was bogus. For example, next_almost_prime (32)
2020 returned 39, which is undesirable as it is a multiple of 3; and
2021 next_almost_prime (24) returned 25, which is a multiple of 5 so
2022 why was the code bothering to check for multiples of 7?
2023
80e88859
PE
2024 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2025
4a2f0ad6
PE
2026 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2027
f66c7cf8
PE
2028 Variadic C functions now count arguments with ptrdiff_t.
2029 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2030 Back then I didn't know that the Emacs coding style prefers signed int.
2031 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2032 were being counted with int, which may truncate counts on 64-bit
2033 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2034 * lisp.h (struct Lisp_Subr.function.aMANY)
2035 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2036 Arg counts are now ptrdiff_t, not size_t.
2037 All variadic functions and their callers changed accordingly.
2038 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2039 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2040 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2041 * callint.c (Fcall_interactively): Check arg count for overflow,
2042 to avoid potential buffer overrun. Use signed char, not 'int',
2043 for 'varies' array, so that we needn't bother to check its size
2044 calculation for overflow.
2045 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2046 * eval.c (apply_lambda):
2047 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2048 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2049 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2050
a1759b76
PE
2051 * callint.c (Fcall_interactively): Don't use index var as event count.
2052
d96be9fc
PE
2053 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2054 * mem-limits.h (SIZE): Remove; no longer used.
2055
a690a978 2056 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2057
578c21e6
PE
2058 Remove unnecessary casts.
2059 * xterm.c (x_term_init):
2060 * xfns.c (x_set_border_pixel):
2061 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2062 These aren't needed now that we assume ANSI C.
2063
96f53c6c
PE
2064 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2065 It's more likely to cause problems (due to unsigned overflow)
2066 than to cure them.
2067
83c77d31
PE
2068 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2069
ee2079f1
PE
2070 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2071
6da65536
PE
2072 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2073
7147c4a4
PE
2074 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2075
193e32d9
PE
2076 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2077
e5533da6
PE
2078 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2079
9910e595
PE
2080 GLYPH_CODE_FACE returns EMACS_INT, not int.
2081 * dispextern.h (merge_faces):
2082 * xfaces.c (merge_faces):
01103c44
PE
2083 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2084 Don't assume EMACS_INT fits in int.
9910e595 2085
2638320e
PE
2086 * character.h (CHAR_VALID_P): Remove unused parameter.
2087 * fontset.c, lisp.h, xdisp.c: All uses changed.
2088
045eb8d9
PE
2089 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2090
c1f134b5
PE
2091 * fns.c (concat): Minor tuning based on overflow analysis.
2092 This doesn't fix any bugs. Use int to hold character, instead
2093 of constantly refetching from Emacs object. Use XFASTINT, not
2094 XINT, for value known to be a character. Don't bother comparing
2095 a single byte to 0400, as it's always less.
2096
395fcb93 2097 * floatfns.c (Fexpt):
327eeec8
PE
2098 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2099
abbd3d23
PE
2100 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2101 for characters.
2102
684a03ef
PE
2103 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2104
0fed43f3
PE
2105 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2106 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2107 incorrectly succeed when S was a string, because 4294967386 was
2108 truncated before it was used.
2109
8fd02eb7
PE
2110 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2111 Otherwise, an out-of-range integer could cause undefined behavior
2112 on a 64-bit host.
2113
f8c86b69
PE
2114 * composite.c: Use int, not EMACS_INT, for characters.
2115 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2116 EMACS_INT, for values that are known to be in character range.
2117 This doesn't fix any bugs but is the usual style inside Emacs and
2118 may generate better code on 32-bit machines.
2119
34206dd2
PE
2120 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2121 This is for reasons similar to the recent CHAR_STRING fix.
2122 * charset.c (Fencode_char): Check that character arg is actually
2123 a character. Pass an int to ENCODE_CHAR.
2124 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2125 wider than 'int', as a compile-time check to prevent future regressions
2126 in this area.
2127
c5958d4c 2128 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2129
2130 Make sure a 64-bit char is never passed to CHAR_STRING.
2131 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2132 by silently ignoring the top 32 bits, allowing some values
2133 that were far too large to be valid characters.
2134 * character.h: Include <verify.h>.
2135 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2136 arguments are no wider than unsigned, as a compile-time check
2137 to prevent future regressions in this area.
2138 * data.c (Faset):
01103c44 2139 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2140 (Fsubst_char_in_region):
2141 * fns.c (concat):
2142 * xdisp.c (decode_mode_spec_coding):
2143 Adjust to CHAR_STRING's new requirement.
2144 * editfns.c (Finsert_char, Fsubst_char_in_region):
2145 * fns.c (concat): Check that character args are actually
2146 characters. Without this test, these functions did the wrong
2147 thing with wildly out-of-range values on 64-bit hosts.
2148
d37ca623
PE
2149 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2150 These casts should not be needed on 32-bit hosts, either.
2151 * keyboard.c (read_char):
2152 * lread.c (Fload): Remove casts to unsigned.
2153
ea204efb
PE
2154 * lisp.h (UNSIGNED_CMP): New macro.
2155 This fixes comparison bugs on 64-bit hosts.
2156 (ASCII_CHAR_P): Use it.
2157 * casefiddle.c (casify_object):
01103c44 2158 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2159 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2160 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2161 * dispextern.h (FACE_FROM_ID):
2162 * keyboard.c (read_char): Use UNSIGNED_CMP.
2163
41cb286c
PE
2164 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2165 not to EMACS_INT, to avoid GCC warning.
2166
4a1b9832
PE
2167 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2168
55daad71
PE
2169 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2170 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2171 isn't needed on 32-bit machines.
8f95c75c 2172
01103c44
PE
2173 * buffer.c (Fgenerate_new_buffer_name):
2174 Use EMACS_INT for count, not int.
0ceccced 2175 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2176
2177 * data.c (Qcompiled_function): Now static.
2178
c6f072e7
PE
2179 * window.c (window_body_lines): Now static.
2180
20ce5912
PE
2181 * image.c (gif_load): Rename local to avoid shadowing.
2182
9c4c5f81
PE
2183 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2184 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2185 * alloc.c (make_save_value): Integer argument is now of type
2186 ptrdiff_t, not int.
2187 (mark_object): Use ptrdiff_t, not int.
2188 * lisp.h (pD): New macro.
2189 * print.c (print_object): Use it.
2190
c0c5c8ae
PE
2191 * alloc.c: Use EMACS_INT, not int, to count objects.
2192 (total_conses, total_markers, total_symbols, total_vector_size)
2193 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2194 (total_free_floats, total_floats, total_free_intervals)
2195 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2196 Now EMACS_INT, not int. All uses changed.
2197 (Fgarbage_collect): Compute overall total using a double, so that
2198 integer overflow is less likely to be a problem. Check for overflow
2199 when converting back to an integer.
5a25e253
PE
2200 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2201 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2202 These were 'int' variables that could overflow on 64-bit hosts;
2203 they were never used, so remove them instead of repairing them.
211a0b2a 2204 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2205 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2206 Previously, this ceilinged at INT_MAX, but that doesn't work on
2207 64-bit machines.
e46bb31a 2208 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2209
c78baabf 2210 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2211 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2212 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2213 when a (possibly-narrower) signed value would do just as well.
2214 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2215
c9d624c6
PE
2216 * alloc.c: Catch some string size overflows that we were missing.
2217 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2218 for convenience in STRING_BYTES_MAX.
2219 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2220 The definition here is exact; the one in lisp.h was approximate.
2221 (allocate_string_data): Check for string overflow. This catches
2222 some instances we weren't catching before. Also, it catches
2223 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2224 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2225 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2226
c9d624c6
PE
2227 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2228 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2229 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2230
353032ce
PE
2231 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2232
2bccce07
PE
2233 * alloc.c (Fmake_string): Check for out-of-range init.
2234
0ac30604
SM
22352011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2236
2237 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2238
c195f2de
JD
22392011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2240
2241 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2242 xg_get_default_scrollbar_width.
2243
2244 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2245 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2246 (style_changed_cb): Call update_theme_scrollbar_width and call
2247 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2248 all frames (Bug#8505).
2249 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2250 Call gtk_window_set_resizable if HAVE_GTK3.
2251 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2252 and height if HAVE_GTK3 (Bug#8505).
2253 (scroll_bar_width_for_theme): New variable.
2254 (update_theme_scrollbar_width): New function.
2255 (xg_get_default_scrollbar_width): Move code to
2256 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2257 (xg_initialize): Call update_theme_scrollbar_width.
2258
2259 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2260
2261 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2262
e10ac9f1
MR
22632011-06-12 Martin Rudalics <rudalics@gmx.at>
2264
2265 * frame.c (make_frame): Call other_buffer_safely instead of
2266 other_buffer.
2267
2268 * window.c (temp_output_buffer_show): Call display_buffer with
2269 second argument Vtemp_buffer_show_specifiers and reset latter
2270 immediately after the call.
2271 (Vtemp_buffer_show_specifiers): New variable.
2272 (auto_window_vscroll_p, next_screen_context_lines)
2273 (Vscroll_preserve_screen_position): Remove leading asterisks from
2274 doc-strings.
2275
2d3c217e 22762011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2277
7b7f97e8 2278 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2279 * buffer.c (Qclone_number): Remove for now, as it's unused.
2280 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2281 (record_buffer): Remove unused local.
2282 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2283 (set_frame_buffer_list): Remove; unused.
2284 * frame.h (other_visible_frames): Remove decl.
2285 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2286 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2287 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2288 if HAVE_GPM.
2289 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2290 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2291 Define only if HAVE_GPM.
2292 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2293 (update_hints_inhibit): Remove; never set. All uses removed.
2294 * widgetprv.h (emacsFrameClassRec): Remove decl.
2295 * window.c (delete_deletable_window): Now returns void, since it
2296 wasn't returning anything.
2297 (compare_window_configurations): Remove unused locals.
2298 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2299 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2300 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2301 the same widths as pointers. This follows up on the 2011-05-06 patch.
2302 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2303 * xterm.h: Likewise.
2304 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2305
1384b89e
JB
23062011-06-12 Juanma Barranquero <lekktu@gmail.com>
2307
2308 * makefile.w32-in: Update dependencies.
2309 (LISP_H): Add lib/intprops.h.
2310
1100a63c
CY
23112011-06-11 Chong Yidong <cyd@stupidchicken.com>
2312
2313 * image.c (gif_load): Add animation frame delay to the metadata.
2314 (syms_of_image): Use DEFSYM. New symbol `delay'.
2315
6198ccd0
MR
23162011-06-11 Martin Rudalics <rudalics@gmx.at>
2317
2318 * window.c (delete_deletable_window): Re-add.
2319 (Fset_window_configuration): Rewrite to handle dead buffers and
2320 consequently deletable windows.
2321 (window_tree, Fwindow_tree): Remove. Supply functionality in
2322 window.el.
2323 (compare_window_configurations): Simplify code.
2324
b6e3633c
AS
23252011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2326
1ab0dee5
AS
2327 * image.c (imagemagick_load_image): Fix type mismatch.
2328 (Fimagemagick_types): Likewise.
2329
b6e3633c
AS
2330 * window.h (replace_buffer_in_windows): Declare.
2331
9397e56f
MR
23322011-06-11 Martin Rudalics <rudalics@gmx.at>
2333
2334 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2335 Qclone_number. Remove external declaration of Qdelete_window.
2336 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2337 code.
640c8776
SM
2338 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2339 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2340 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2341 buffer list implementation.
2342 (other_buffer_safely): New function.
2343 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2344 calls to replace_buffer_in_windows and
2345 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2346 if allowed.
2347 (record_buffer): Inhibit quitting and rewrite using quittable
2348 functions. Run Qbuffer_list_update_hook if allowed.
2349 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2350 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2351 Move switch-to-buffer to window.el.
9397e56f
MR
2352 (bury-buffer): Move to window.el.
2353 (Vbuffer_list_update_hook): New variable.
2354
2355 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2356 section.
2357
2358 * window.h (resize_frame_windows): Move up in code.
2359 (Fwindow_frame): Remove EXFUN.
2360 (replace_buffer_in_all_windows): Remove prototype.
2361 (replace_buffer_in_windows_safely): Add prototype.
2362
2363 * window.c: Declare Qdelete_window static again. Move down
2364 declaration of select_count.
2365 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2366 (Fother_window): Move to window.el.
2367 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2368 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2369 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2370 window.el.
2371 (replace_buffer_in_windows): Implement by calling
2372 Qreplace_buffer_in_windows.
2373 (replace_buffer_in_all_windows): Remove with some functionality
2374 moved into replace_buffer_in_windows_safely.
2375 (replace_buffer_in_windows_safely): New function.
2376 (select_window_norecord, select_frame_norecord): Move in front
2377 of run_window_configuration_change_hook. Remove now obsolete
2378 declarations.
640c8776
SM
2379 (Fset_window_buffer): Rewrite doc-string.
2380 Call Qrecord_window_buffer.
9397e56f
MR
2381 (keys_of_window): Move binding for other-window to window.el.
2382
b50691aa
CY
23832011-06-11 Chong Yidong <cyd@stupidchicken.com>
2384
2385 * dispextern.h (struct image): Replace data member, whose int_val
2386 and ptr_val fields were not used by anything, with a single
2387 lisp_val object.
2388
2389 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2390 (gif_clear_image, gif_load, imagemagick_load_image)
2391 (gs_clear_image, gs_load): Callers changed.
2392
3f754b86
PE
23932011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2394
cca69397
PE
2395 * buffer.h: Include <time.h>, for time_t.
2396 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2397
109e28d0
PE
2398 Fix minor problems found by static checking.
2399
60737f02
PE
2400 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2401
4b66faf3
PE
2402 Make identifiers static if they are not used in other modules.
2403 * data.c (Qcompiled_function, Qframe, Qvector):
2404 * image.c (QimageMagick, Qsvg):
2405 * minibuf.c (Qmetadata):
2406 * window.c (resize_window_check, resize_root_window): Now static.
2407 * window.h (resize_window_check, resize_root_window): Remove decls.
2408
109e28d0
PE
2409 * window.c (window_deletion_count, delete_deletable_window):
2410 Remove; unused.
46a4ce9e
PE
2411 (window_body_lines): Now static.
2412 (Fdelete_other_windows_internal): Mark vars as initialized.
2413 Make sure 'resize_failed' is initialized.
2414 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2415 (resize_window_apply): Remove unused local.
2416 * window.h (delete_deletable_window): Remove decl.
2417
109e28d0 2418 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2419 (imagemagick_load_image): Fix pointer signedness problem by changing
2420 last arg from unsigned char * to char *. All uses changed.
2421 Also, fix a local for similar reasons.
2422 Remove unused locals. Remove locals to avoid shadowing.
2423 (fn_rsvg_handle_free): Remove; unused.
2424 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2425 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2426
3f754b86
PE
2427 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2428
2547adb1
CY
24292011-06-10 Chong Yidong <cyd@stupidchicken.com>
2430
2431 * image.c (gif_load): Fix omitted cast error introduced by
2432 2011-06-06 change.
2433
2c8e37d4
MR
24342011-06-10 Martin Rudalics <rudalics@gmx.at>
2435
2436 * window.h (resize_proportionally, orig_total_lines)
2437 (orig_top_line): Remove from window structure.
2438 (set_window_height, set_window_width, change_window_heights)
2439 (Fdelete_window): Remove prototypes.
2440 (resize_frame_windows): Remove duplicate declaration.
2441
440a42e3
EZ
24422011-06-10 Eli Zaretskii <eliz@gnu.org>
2443
2444 * window.h (resize_frame_windows, resize_window_check)
2445 (delete_deletable_window, resize_root_window)
2446 (resize_frame_windows): Declare prototypes.
2447
2448 * window.c (resize_window_apply): Make definition be "static" to
2449 match the prototype.
2450
562dd5e9
MR
24512011-06-10 Martin Rudalics <rudalics@gmx.at>
2452
2453 * window.c: Remove declarations of Qwindow_size_fixed,
2454 window_min_size_1, window_min_size_2, window_min_size,
2455 size_window, window_fixed_size_p, enlarge_window, delete_window.
2456 Remove static from declaration of Qdelete_window, it's
2457 temporarily needed by Fbury_buffer.
2458 (replace_window): Don't assign orig_top_line and
2459 orig_total_lines.
2460 (Fdelete_window, delete_window): Remove. Window deletion is
2461 handled by window.el.
640c8776
SM
2462 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2463 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2464 (Fdelete_other_windows): Remove. Deleting other windows is
2465 handled by window.el.
2466 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2467 handled in window.el.
2468 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2469 Window minimum sizes are handled in window.el.
2470 (shrink_windows, size_window, set_window_height)
2471 (set_window_width, change_window_heights, window_height)
2472 (window_width, CURBEG, CURSIZE, enlarge_window)
2473 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2474 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2475 handled in window.el.
2476 (make_dummy_parent): Rename to make_parent_window and give it a
2477 second argument horflag.
2478 (make_window): Don't set resize_proportionally any more.
2479 (Fsplit_window): Remove. Windows are split in window.el.
2480 (save_restore_action, save_restore_orig_size)
2481 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2482 Resize mini windows in window.el.
2483 (grow_mini_window, shrink_mini_window): Implement by calling
2484 Qresize_root_window_vertically, resize_window_check and
2485 resize_window_apply.
640c8776
SM
2486 (saved_window, Fset_window_configuration, save_window_save):
2487 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2488 resize_proportionally.
2489 (window_min_height, window_min_width): Move to window.el.
2490 (keys_of_window): Move bindings for delete-other-windows,
2491 split-window, delete-window and enlarge-window to window.el.
2492
2493 * buffer.c: Temporarily extern Qdelete_window.
2494 (Fbury_buffer): Temporarily call Qdelete_window instead of
2495 Fdelete_window (Fbury_buffer will move to window.el soon).
2496
2497 * frame.c (set_menu_bar_lines_1): Remove code handling
2498 orig_top_line and orig_total_lines.
2499
2500 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2501 set_window_height but set heights directly.
2502 (change_frame_size_1): Use resize_frame_windows.
2503
2504 * xdisp.c (init_xdisp): Don't use set_window_height but set
2505 heights directly.
2506
640c8776
SM
2507 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2508 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2509 run_window_configuration_change_hook.
2510
2511 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2512 instead of change_window_heights and run
2513 run_window_configuration_change_hook.
2514
1a13852e
MR
25152011-06-09 Martin Rudalics <rudalics@gmx.at>
2516
2517 * window.c (replace_window): Rename second argument REPLACEMENT to
2518 NEW. New third argument SETFLAG. Rewrite.
2519 (delete_window, make_dummy_parent): Call replace_window with
2520 third argument 1.
2521 (window_list_1): Move down in code.
2522 (run_window_configuration_change_hook): Move set_buffer part
2523 before select_frame_norecord part in order to unwind correctly.
2524 Rename count1 to count.
2525 (recombine_windows, delete_deletable_window, resize_root_window)
2526 (Fdelete_other_windows_internal)
2527 (Frun_window_configuration_change_hook, make_parent_window)
2528 (resize_window_check, resize_window_apply, Fresize_window_apply)
2529 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2530 (Fdelete_window_internal, Fresize_mini_window_internal):
2531 New functions.
1a13852e
MR
2532 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2533
f3d1777e
MR
25342011-06-08 Martin Rudalics <rudalics@gmx.at>
2535
496e208e
MR
2536 * window.h (window): Add some new members to window structure -
2537 normal_lines, normal_cols, new_total, new_normal, clone_number,
2538 splits, nest, prev_buffers, next_buffers.
2539 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2540 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2541
f3d1777e
MR
2542 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2543 Remove.
496e208e
MR
2544 (make_dummy_parent): Set new members of windows structure.
2545 (make_window): Move down in code. Handle new members of window
2546 structure.
2547 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2548 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2549 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2550 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2551 (Fset_window_next_buffers, Fset_window_clone_number):
2552 New functions.
496e208e
MR
2553 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2554 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2555 Doc-string fixes.
2556 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2557 Argument WINDOW can be now internal window too.
2558 (Fwindow_use_time): Move up in code.
2559 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2560 Rewrite doc-string.
2561 (Fset_window_configuration, saved_window)
2562 (Fcurrent_window_configuration, save_window_save): Handle new
2563 members of window structure.
b9e809c2
MR
2564 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2565 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2566 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2567 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2568 Qget_mru_window, Qresize_root_window,
2569 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2570 Qauto_buffer_name; staticpro them.
f3d1777e 2571
abde8f8c
MR
25722011-06-07 Martin Rudalics <rudalics@gmx.at>
2573
2574 * window.c (Fwindow_total_size, Fwindow_left_column)
2575 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2576 (Fwindow_list_1): New functions.
2577 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2578 (Fwindow_width, Fscroll_left, Fscroll_right):
2579 Use window_body_cols instead of window_box_text_cols.
2580 (delete_window, Fset_window_configuration):
2581 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2582 (delete_all_subwindows): Take a window as argument and not a
2583 structure. Rewrite.
190b47e6
MR
2584 (window_loop): Remove handling of GET_LRU_WINDOW and
2585 GET_LARGEST_WINDOW.
2586 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2587
2588 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2589 window_box_text_cols. delete_all_subwindows now takes a
2590 Lisp_Object as argument.
abde8f8c 2591
640c8776
SM
2592 * indent.c (compute_motion, Fcompute_motion):
2593 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2594
fa8a67e6
MR
2595 * frame.c (delete_frame): Call delete_all_subwindows with root
2596 window as argument.
2597
a54e3482
DC
25982011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2599
2600 * fns.c (Fputhash): Document return value.
2601
60002bf5
CY
26022011-06-06 Chong Yidong <cyd@stupidchicken.com>
2603
2604 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2605
0c671da6 26062011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2607
b862a52a 2608 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2609
be44ca6c
PE
2610 Check for overflow when converting integer to cons and back.
2611 * charset.c (Fdefine_charset_internal, Fdecode_char):
2612 Use cons_to_unsigned to catch overflow.
2613 (Fencode_char): Use INTEGER_TO_CONS.
2614 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2615 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2616 * data.c (long_to_cons, cons_to_long): Remove.
2617 (cons_to_unsigned, cons_to_signed): New functions.
2618 These signal an error for invalid or out-of-range values.
2619 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2620 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2621 * font.c (Ffont_variation_glyphs):
2622 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2623 * lisp.h: Include <intprops.h>.
2624 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2625 (cons_to_signed, cons_to_unsigned): New decls.
2626 (long_to_cons, cons_to_long): Remove decls.
2627 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2628 (Fprimitive_undo): Use CONS_TO_INTEGER.
2629 * xfns.c (Fx_window_property): Likewise.
2630 * xselect.c: Include <limits.h>.
2631 (x_own_selection, selection_data_to_lisp_data):
2632 Use INTEGER_TO_CONS.
2633 (x_handle_selection_request, x_handle_selection_clear)
2634 (x_get_foreign_selection, Fx_disown_selection_internal)
2635 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2636 (lisp_data_to_selection_data): Use cons_to_unsigned.
2637 (x_fill_property_data): Use cons_to_signed.
2638 Report values out of range.
2639
d1f3d2af
PE
2640 Check for buffer and string overflow more precisely.
2641 * buffer.h (BUF_BYTES_MAX): New macro.
2642 * lisp.h (STRING_BYTES_MAX): New macro.
2643 * alloc.c (Fmake_string):
2644 * character.c (string_escape_byte8):
2645 * coding.c (coding_alloc_by_realloc):
2646 * doprnt.c (doprnt):
2647 * editfns.c (Fformat):
2648 * eval.c (verror):
2649 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2650 since they may not be the same number.
2651 * editfns.c (Finsert_char):
2652 * fileio.c (Finsert_file_contents):
2653 Likewise for BUF_BYTES_MAX.
2654
dd52fcea
PE
2655 * image.c: Use ptrdiff_t, not int, for sizes.
2656 (slurp_file): Switch from int to ptrdiff_t.
2657 All uses changed.
2658 (slurp_file): Check that file size fits in both size_t (for
2659 malloc) and ptrdiff_t (for sanity and safety).
2660
7f9bbdbb
PE
2661 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2662 if b->modtime has its maximal value.
2663
dfe18f82
PE
2664 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2665
84acfcf0
PE
2666 Don't assume time_t can fit into int.
2667 * buffer.h (struct buffer.modtime): Now time_t, not int.
2668 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2669 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2670
ccd9a01a
PE
2671 Minor fixes for signed vs unsigned integers.
2672 * character.h (MAYBE_UNIFY_CHAR):
2673 * charset.c (maybe_unify_char):
2674 * keyboard.c (read_char, reorder_modifiers):
2675 XINT -> XFASTINT, since the integer must be nonnegative.
2676 * ftfont.c (ftfont_spec_pattern):
2677 * keymap.c (access_keymap, silly_event_symbol_error):
2678 XUINT -> XFASTINT, since the integer must be nonnegative.
2679 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2680 since it makes no difference and we prefer signed.
2681 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2682 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2683 nonnegative.
2684
d6d100dd
SM
26852011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2686
2687 * window.h (Fwindow_frame): Declare.
2688
2b6148e4
PE
26892011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2690
2691 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2692 (SPARE_MEMORY): Always define.
2693 (LARGE_REQUEST): Remove.
2694 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2695
f230ecc9
MR
26962011-06-06 Martin Rudalics <rudalics@gmx.at>
2697
727e958e
MR
2698 * lisp.h: Move EXFUNS for Fframe_root_window,
2699 Fframe_first_window and Fset_frame_selected_window to window.h.
2700
2701 * window.h: Move EXFUNS for Fframe_root_window,
2702 Fframe_first_window and Fset_frame_selected_window here from
2703 lisp.h.
2704
2705 * frame.c (Fwindow_frame, Fframe_first_window)
2706 (Fframe_root_window, Fframe_selected_window)
2707 (Fset_frame_selected_window): Move to window.c.
2708 (Factive_minibuffer_window): Move to minibuf.c.
2709 (Fother_visible_frames_p): New function.
2710
2711 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2712
f230ecc9
MR
2713 * window.c (decode_window, decode_any_window): Move up in code.
2714 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2715 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2716 (Fwindow_buffer): Move up and rewrite doc-string.
2717 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2718 (Fwindow_prev): New functions.
727e958e
MR
2719 (Fwindow_frame): Move here from frame.c. Accept any window as
2720 argument.
2721 (Fframe_root_window, Fframe_first_window)
2722 (Fframe_selected_window): Move here from frame.c. Accept frame
2723 or arbitrary window as argument. Update doc-strings.
2724 (Fminibuffer_window): Move up in code.
2725 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2726 (Fset_frame_selected_window): Move here from frame.c.
2727 Marginal rewrite.
727e958e
MR
2728 (Fselected_window, select_window, Fselect_window): Move up in
2729 code. Minor doc-string fixes.
f230ecc9 2730
4d09bcf6
PE
27312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2732
2733 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2734 Do not assume that spare memory exists; that assumption is valid
2735 only if SYSTEM_MALLOC.
2736 (LARGE_REQUEST): New macro, so that the issue of large requests
2737 is separated from the issue of spare memory.
2738
810928a2
AS
27392011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2740
172418ad
AS
2741 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2742 format. (Bug#8806)
2743
43f862f7
AS
2744 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2745
810928a2
AS
2746 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2747 before statements.
2748
a059fe24
JD
27492011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2750
2751 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2752
2753 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2754
2755 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2756 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2757
989bf368
JB
27582011-06-05 Juanma Barranquero <lekktu@gmail.com>
2759
2760 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2761
4b80f674
CY
27622011-06-04 Chong Yidong <cyd@stupidchicken.com>
2763
2764 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2765 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2766 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2767 New error handlers.
4b80f674
CY
2768 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2769 Obey Vx_select_enable_clipboard_manager. Catch errors in
2770 x_clipboard_manager_save (Bug#8779).
2771 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2772 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2773
99a33b77 27742011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2775
2776 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2777
99a33b77 27782011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2779
2780 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2781 in the current matrix if keep_current_p is non-zero.
2782
8264569d
EZ
27832011-06-04 Eli Zaretskii <eliz@gnu.org>
2784
2785 * bidi.c (bidi_level_of_next_char): Fix last change.
2786
57f97249
EZ
27872011-06-03 Eli Zaretskii <eliz@gnu.org>
2788
fec2107c 2789 Support bidi reordering of text covered by display properties.
57f97249 2790
fec2107c
EZ
2791 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2792 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2793 (bidi_cache_search, bidi_cache_iterator_state)
2794 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2795 (bidi_level_of_next_char, bidi_move_to_visually_next):
2796 Support character positions inside a run of characters covered by a
fec2107c
EZ
2797 display string.
2798 (bidi_paragraph_init, bidi_resolve_explicit_1)
2799 (bidi_level_of_next_char): Call bidi_fetch_char and
2800 bidi_fetch_char_advance instead of FETCH_CHAR and
2801 FETCH_CHAR_ADVANCE.
2802 (bidi_init_it): Initialize new members.
2803 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2804 definitions.
2805 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2806 instead of using explicit *_CHAR codes.
d6d100dd
SM
2807 (bidi_resolve_explicit, bidi_resolve_weak):
2808 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2809 bidirectional text is supported only in multibyte buffers.
2810 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2811 it to initialize the frame_window_p member of struct bidi_it.
2812 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2813 (bidi_resolve_explicit, bidi_resolve_weak)
2814 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2815 bidi_it->nchars is non-positive.
2816 (bidi_level_of_next_char): Don't try to lookup the cache for the
2817 next/previous character if nothing is cached there yet, or if we
2818 were just reseat()'ed to a new position.
c40e2fb2 2819
0e14fe90
EZ
2820 * xdisp.c (set_cursor_from_row): Set start and stop points
2821 according to the row's direction when priming the loop that looks
2822 for the glyph on which to display cursor.
2823 (single_display_spec_intangible_p): Function deleted.
2824 (display_prop_intangible_p): Reimplement to call
2825 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2826 Accept 3 additional arguments needed by handle_display_spec.
2827 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2828 values: lists, `(when COND...)' forms, etc.
2829 (single_display_spec_string_p): Support property values that are
2830 lists with the argument STRING its top-level element.
2831 (display_prop_string_p): Fix the condition for processing a
2832 property that is a list to be consistent with handle_display_spec.
fec2107c 2833 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2834 last portion of handle_display_prop.
2835 (compute_display_string_pos): Accept additional argument
2836 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2837 value of a `display' property is a "replacing spec".
2838 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2839 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2840 the display property, but just return a value indicating whether
2841 the display property will replace the characters it covers.
2842 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2843 frame_window_p members of struct bidi_it.
d6d100dd
SM
2844 (compute_display_string_pos, compute_display_string_end):
2845 New functions.
fec2107c
EZ
2846 (push_it): Accept second argument POSITION, where pop_it should
2847 jump to continue iteration.
2848 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2849
fec2107c
EZ
2850 * keyboard.c (adjust_point_for_property): Adjust the call to
2851 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2852
2853 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2854 (bidi_init_it): Update prototypes.
2855 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2856 (compute_display_string_pos, compute_display_string_end):
2857 Declare prototypes.
fec2107c
EZ
2858 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2859 EMACS_INT.
fc6f18ce 2860
40087514 28612011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2862
57f53182
PE
2863 Malloc failure behavior now depends on size of allocation.
2864 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2865 * lisp.h: Change signatures accordingly.
2866 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2867 All callers changed. (Bug#8762)
2868
2869 * gnutls.c: Use Emacs's memory allocators.
2870 Without this change, the gnutls library would invoke malloc etc.
2871 directly, which causes problems on non-SYNC_INPUT hosts, and which
2872 runs afoul of improving memory_full behavior. (Bug#8761)
2873 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2874 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2875 xfree instead of the default malloc, realloc, free.
2876 (Fgnutls_boot): No need to check for memory allocation failure,
2877 since xmalloc does that for us.
2878
ac32cd99 2879 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2880 * category.c (hash_get_category_set):
2881 * ccl.c (ccl_driver):
2882 * charset.c (Fdefine_charset_internal):
2883 * charset.h (struct charset.hash_index):
2884 * composite.c (get_composition_id, gstring_lookup_cache)
2885 (composition_gstring_put_cache):
2886 * composite.h (struct composition.hash_index):
2887 * dispextern.h (struct image.hash):
2888 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2889 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2890 (hashfn_equal, hashfn_user_defined, make_hash_table)
2891 (maybe_resize_hash_table, hash_lookup, hash_put)
2892 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2893 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2894 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2895 * image.c (make_image, search_image_cache, lookup_image)
2896 (xpm_put_color_table_h):
2897 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2898 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2899 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2900 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2901 * alloc.c (allocate_vectorlike):
2902 Check for overflow in vector size calculations.
2903 * ccl.c (ccl_driver):
2904 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2905 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2906 need to be updated by these changes.
40087514
PE
2907 * fns.c (make_hash_table, maybe_resize_hash_table):
2908 Check for integer overflow with large hash tables.
0de4bb68
PE
2909 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2910 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2911 (SXHASH_REDUCE): New macro.
2912 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2913 Use it instead of discarding useful hash info with large hash values.
2914 (sxhash_float): New function.
2915 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2916 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2917 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2918 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2919 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2920 Adjust signatures to match updated version of code.
2921 (consing_since_gc): Now EMACS_INT, since a single hash table can
2922 use more than INT_MAX bytes.
2923
698d32e2
DN
29242011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2925
2926 Make it possible to build with GCC-4.6+ -O2 -flto.
2927
2928 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2929
fd6fa53f
SM
29302011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2931
2932 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2933 Call minibuffer-inactive-mode.
2934
864db017
JB
29352011-05-31 Juanma Barranquero <lekktu@gmail.com>
2936
2937 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2938 Update dependencies.
2939
2ad0baf4
DN
29402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2941
2942 * data.c (init_data): Remove code for UTS, this system is not
2943 supported anymore.
2944
4fcc2638
DN
29452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2946
2947 Don't force ./temacs to start in terminal mode.
2948
2949 * frame.c (make_initial_frame): Initialize faces in all cases, not
2950 only when CANNOT_DUMP is defined.
2951 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2952
c56e0fd5
DN
29532011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2954
2955 * dispnew.c (add_window_display_history): Use const for the string
2956 pointer. Remove declaration, not needed.
2957
333d54da 29582011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2959
55d4c1b2 2960 Use 'inline', not 'INLINE'.
333d54da 2961 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2962 * alloc.c, fontset.c (INLINE): Remove.
2963 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2964 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2965 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2966 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2967 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2968
738db178
DN
29692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2970
2971 Make it possible to run ./temacs.
2972
2973 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2974 syms_of_callproc does the same thing. Remove test for
2975 "initialized", do it in the caller.
2976 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2977
620c53a6
SM
29782011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2979
2980 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2981 (read_minibuf): Use get_minibuffer.
2982 (syms_of_minibuf): Use DEFSYM.
2983 (Qmetadata): New var.
2984 * data.c (Qbuffer): Don't make it static.
2985 (syms_of_data): Use DEFSYM.
2986
e003a292
PE
29872011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2988
2989 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2990 (CCL_CODE_MIN): New macro.
2991
ed008a6d
PE
29922011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2993
3687c2ef
PE
2994 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2995
ed008a6d
PE
2996 * eval.c (Qdebug): Now static.
2997 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2998 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2999 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3000
d66c4c7c
CY
30012011-05-29 Chong Yidong <cyd@stupidchicken.com>
3002
3003 * image.c: Various fixes to ImageMagick code comments.
3004 (Fimagemagick_types): Doc fix.
3005
5fbc2025
PE
30062011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3007
0196f88a
PE
3008 Minor fixes prompted by GCC 4.6.0 warnings.
3009
3010 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3011
5fbc2025
PE
3012 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3013 (x_clipboard_manager_save_all): Move extern decl to ...
3014 * xterm.h: ... here, so that it can be checked for consistency.
3015
1dd3c2d9
CY
30162011-05-29 Chong Yidong <cyd@stupidchicken.com>
3017
3018 * xselect.c (x_clipboard_manager_save_frame)
3019 (x_clipboard_manager_save_all): New functions.
3020 (Fx_clipboard_manager_save): Lisp function deleted.
3021
3022 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3023 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3024
3025 * xterm.h: Update prototype.
3026
5ba6571d
WX
30272011-05-28 William Xu <william.xwl@gmail.com>
3028
3029 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3030 exiting (Bug#8239).
3031
3eaff834
JM
30322011-05-28 Jim Meyering <meyering@redhat.com>
3033
e1900994 3034 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3035 * fns.c (to_uchar): Define.
3036 (crypto_hash_function): Use it to convert some newly-signed
3037 variables to unsigned, to avoid sign-extension bugs. For example,
3038 without this change, (md5 "truc") would evaluate to
3039 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3040 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3041 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3042
0f6990a7
PE
30432011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3044
3045 Integer overflow fixes.
c8a9ca5a 3046
08686060
PE
3047 * dbusbind.c: Serial number integer overflow fixes.
3048 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3049 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3050 to hold a serial number that is too large for a fixnum.
3051 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3052 Check for serial numbers out of range. Decode any serial number
59568bf0 3053 that was so large that it became a float. (Bug#8722)
08686060 3054
2d1fc3c7
PE
3055 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3056 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3057 Use XFASTINT rather than XUINT when numbers are nonnegative.
3058 (xd_append_arg, Fdbus_method_return_internal):
3059 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3060 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3061 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3062 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3063 (Bug#8722)
2d1fc3c7 3064
c8a9ca5a
PE
3065 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3066
519e1d69
PE
3067 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3068
30569699
PE
3069 ccl: add integer overflow checks
3070 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3071 (IN_INT_RANGE): New macros.
3072 (ccl_driver): Use them to check for integer overflow when
3073 decoding a CCL program. Many of the new checks are whether XINT (x)
3074 fits in int; it doesn't always, on 64-bit hosts. The new version
3075 doesn't catch all possible integer overflows, but it's an
847044ea 3076 improvement. (Bug#8719)
30569699 3077
c11285dc
PE
3078 * alloc.c (make_event_array): Use XINT, not XUINT.
3079 There's no need for unsigned here.
3080
fdccd48e
PE
3081 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3082 This follows up to the 2011-05-06 change that substituted uintptr_t
3083 for EMACS_INT. This case wasn't caught back then.
3084
37910ab2
PE
3085 Rework Fformat to avoid integer overflow issues.
3086 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3087 now (part of C89). Include <verify.h>.
3088 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3089 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3090 (Fformat): Avoid the prepass trying to compute sizes; it was only
3091 approximate and thus did not catch overflow reliably. Instead, walk
3092 through the format just once, formatting and computing sizes as we go,
3093 checking for integer overflow at every step, and allocating a larger
3094 buffer as needed. Keep track separately whether the format is
3095 multibyte. Keep only the most-recently calculated precision, rather
3096 than them all. Record whether each argument has been converted to
3097 string. Use EMACS_INT, not int, for byte and char and arg counts.
3098 Support field widths and precisions larger than INT_MAX. Avoid
3099 sprintf's undefined behavior with conversion specifications such as %#d
3100 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3101 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3102 formatting out-of-range floating point numbers with int
9173deec 3103 formats. (Bug#8668)
37910ab2 3104
2e6578fb
PE
3105 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3106
0ae6bdee
PE
3107 * data.c: Avoid integer truncation in expressions involving floats.
3108 * data.c: Include <intprops.h>.
3109 (arith_driver): When there's an integer overflow in an expression
3110 involving floating point, convert the integers to floating point
3111 so that the resulting value does not suffer from catastrophic
3112 integer truncation. For example, on a 64-bit host (* 4
3113 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3114 Do not rely on undefined behavior after integer overflow.
3115
de883a70
PE
3116 merge count_size_as_multibyte, parse_str_to_multibyte
3117 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3118 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3119 Check for integer overflow.
3120 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3121 since it's now a duplicate of the other. This is more of
3122 a character than a buffer op, so better that it's in character.c.
3123 * fns.c, print.c: Adjust to above changes.
3124
2ff916cb
PE
31252011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3126
3127 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3128
f1b54466
PE
31292011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3130
fb1ac845
PE
3131 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3132 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3133 (x_clipboard_manager_save): Now static.
3134 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3135
f1b54466
PE
3136 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3137 (crypto_hash_function): Now static.
3138 Fix pointer signedness problems. Avoid unnecessary initializations.
3139
a9f737ee
CY
31402011-05-27 Chong Yidong <cyd@stupidchicken.com>
3141
3142 * termhooks.h (Vselection_alist): Make it terminal-local.
3143
3144 * terminal.c (create_terminal): Initialize it.
3145
3146 * xselect.c: Support for clipboard managers.
3147 (Vselection_alist): Move to termhooks.h as terminal-local var.
3148 (LOCAL_SELECTION): New macro.
3149 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3150 (symbol_to_x_atom): Remove gratuitous arg.
3151 (x_handle_selection_request, lisp_data_to_selection_data)
3152 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3153 (x_own_selection, x_get_local_selection, x_convert_selection):
3154 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3155 (some_frame_on_display): Delete unused function.
3156 (Fx_own_selection_internal, Fx_get_selection_internal)
3157 (Fx_disown_selection_internal, Fx_selection_owner_p)
3158 (Fx_selection_exists_p): New optional frame arg.
3159 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3160 (x_handle_selection_clear): Don't treat other terminals with the
3161 same keyboard specially. Use the terminal-local Vselection_alist.
3162 (x_clear_frame_selections): Use Frun_hook_with_args.
3163
3164 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3165
3166 * xterm.h: Add support for those atoms.
3167
e067f0c1
CY
31682011-05-26 Chong Yidong <cyd@stupidchicken.com>
3169
3170 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3171 (converted_selections, conversion_fail_tag): New global variables.
3172 (x_selection_request_lisp_error): Free the above.
3173 (x_get_local_selection): Remove unnecessary code.
3174 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3175 of converted selections stored in converted_selections.
3176 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3177 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3178 (x_convert_selection): New function.
3179 (x_handle_selection_event): Simplify.
3180 (x_get_foreign_selection): Don't ignore incoming requests while
3181 waiting for an answer; this will fail when we implement
3182 SAVE_TARGETS, and seems unnecessary anyway.
3183 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3184 (Vx_sent_selection_functions): Doc fix.
3185
0f4aebc0
LL
31862011-05-26 Leo Liu <sdl.web@gmail.com>
3187
3188 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3189
e61124cd
YM
31902011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3191
3192 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3193
3194 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3195 for fringe update if it has periodic bitmap.
ac389d0c 3196 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3197 and fringe_bitmap_periodic_p.
3198
3199 * fringe.c (get_fringe_bitmap_data): New function.
3200 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3201 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3202 row. Mark glyph row for fringe update if periodicity changed.
3203
3204 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3205 for fringe update unless it has periodic bitmap.
3206
f16d9837
KH
32072011-05-25 Kenichi Handa <handa@m17n.org>
3208
3209 * xdisp.c (get_next_display_element): Set correct it->face_id for
3210 a static composition.
3211
e1b90ef6
LL
32122011-05-24 Leo Liu <sdl.web@gmail.com>
3213
3214 * deps.mk (fns.o):
3215 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3216
3217 * fns.c (crypto_hash_function, Fsha1): New function.
3218 (Fmd5): Use crypto_hash_function.
3219 (syms_of_fns): Add Ssha1.
3220
7400048f
PE
32212011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3222
3223 * gnutls.c: Remove unused macros.
3224 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3225 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3226 Remove macros that are defined and never used.
3227 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3228
abb71cf4
CY
32292011-05-22 Chong Yidong <cyd@stupidchicken.com>
3230
3231 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3232 (Fx_get_selection_internal): Minor cleanup.
3233 (Fx_own_selection_internal): Rename arguments for consistency with
3234 select.el.
3235
6307db39
PE
32362011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3237
3238 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3239
f3d4e0a4
CY
32402011-05-22 Chong Yidong <cyd@stupidchicken.com>
3241
3242 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3243
4d8ade89
YM
32442011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3245
3246 * dispnew.c (scrolling_window): Don't exclude the case that the
3247 last enabled row in the desired matrix touches the bottom boundary.
3248
32078c8d
GM
32492011-05-21 Glenn Morris <rgm@gnu.org>
3250
3251 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3252 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3253 and add some more files.
32078c8d 3254
7285dc67
EZ
32552011-05-20 Eli Zaretskii <eliz@gnu.org>
3256
3257 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3258 report_file_error introduced by the change from 2011-05-07.
3259
89d1bd22
PE
32602011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3261
3262 * systime.h (Time): Define only if emacs is defined.
3263 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3264 where the include path doesn't have X11/X.h by default. See
3265 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3266
e23640bb 32672011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3268
3269 * composite.c (find_automatic_composition): Fix previous change.
3270
b9704ad9
GM
32712011-05-20 Glenn Morris <rgm@gnu.org>
3272
3273 * lisp.mk: New file, split from Makefile.in.
3274 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3275 (shortlisp): Remove.
3276 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3277
4a720484
GM
32782011-05-19 Glenn Morris <rgm@gnu.org>
3279
3280 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3281 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3282 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3283 (lisp): Set the order to that of loadup.el.
3284 (shortlisp): Make it a copy of $lisp.
3285 (SOME_MACHINE_LISP): Remove.
3286 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3287 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3288
a28d4396
KH
32892011-05-18 Kenichi Handa <handa@m17n.org>
3290
3291 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3292 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3293 (find_automatic_composition): Mostly rewrite for efficiency.
3294
a2b1fa8e
JB
32952011-05-18 Juanma Barranquero <lekktu@gmail.com>
3296
3297 * makefile.w32-in: Update dependencies.
3298
8e1f5610
CS
32992011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3300
3301 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3302 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3303
7025ee00 33042011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3305
cdfa6eab
PE
3306 Fix some integer overflow issues, such as string length overflow.
3307
06d6db33
PE
3308 * insdel.c (count_size_as_multibyte): Check for string overflow.
3309
2b4560a8
PE
3310 * character.c (lisp_string_width): Check for string overflow.
3311 Use EMACS_INT, not int, for string indexes and lengths; in
3312 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3313 the resulting string length overflows an EMACS_INT; instead,
3314 report a string overflow if no precision given. When checking for
3315 precision exhaustion, use a check that cannot possibly have
3316 integer overflow. (Bug#8675)
3317 * character.h (lisp_string_width): Adjust to new signature.
3318
cb93f9be
PE
3319 * alloc.c (string_overflow): New function.
3320 (Fmake_string): Use it. This doesn't change behavior, but saves
3321 a few bytes and will simplify future changes.
3322 * character.c (string_escape_byte8): Likewise.
3323 * lisp.h (string_overflow): New decl.
3324
1a1f3366
PE
3325 Fixups, following up to the user-interface timestamp change.
3326 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3327 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3328 * msdos.c (mouse_get_pos): Likewise.
3329 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3330 * w32gui.h (Time): Define by including "systime.h" rather than by
3331 declaring it ourselves. (Bug#8664)
3332
d4e3e4d3
PE
3333 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3334 * image.c (clear_image_cache): Likewise.
3335
f6a24d19
PE
3336 * term.c (term_mouse_position): Don't assume time_t wraparound.
3337
08dc5ae6
PE
3338 Be more systematic about user-interface timestamps.
3339 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3340 and sometimes 'EMACS_UINT', to represent these timestamps.
3341 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3342 This makes the code easier to follow, and makes it easier to catch
3343 integer overflow bugs such as Bug#8664.
3344 * frame.c (Fmouse_position, Fmouse_pixel_position):
3345 Use Time, not unsigned long, for user-interface timestamps.
3346 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3347 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3348 * keyboard.h (last_event_timestamp): Likewise.
3349 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3350 * menu.h (xmenu_show): Likewise.
3351 * term.c (term_mouse_position): Likewise.
3352 * termhooks.h (struct input_event.timestamp): Likewise.
3353 (struct terminal.mouse_position_hook): Likewise.
3354 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3355 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3356 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3357 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3358 what it was before.
3359 * menu.h, termhooks.h: Include "systime.h", for Time.
3360
8e55734a
PE
3361 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3362 Don't assume that the difference between two unsigned long values
3363 can fit into an integer. At this point, we know button_down_time
3364 <= event->timestamp, so the difference must be nonnegative, so
3365 there's no need to cast the result if double-click-time is
3366 nonnegative, as it should be; check that it's nonnegative, just in
3367 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3368 apart (about 25 days). (Bug#8664)
8e55734a 3369
841f1b75 3370 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3371 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3372
3e26f69c
PE
3373 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3374 that always fit in int. Use a sentinel instead of a counter, to
3375 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3376 * frame.h (struct frame): Use int for menu_bar_items_used
3377 instead of EMACS_INT, since it always fits in int.
3e26f69c 3378
5cc152c0
PE
3379 * menu.c (grow_menu_items): Check for int overflow.
3380
d89eb65e
PE
3381 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3382
5235bd3e
PE
3383 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3384 Before, the code was not consistent. These values cannot exceed
3385 2**31 - 1 so there's no need to make them unsigned.
3386 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3387 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3388 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3389 as modifiers.
3390 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3391
bc827e23
PE
3392 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3393 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3394 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3395 presumably because the widths might not match.
3396
78eb494e
PE
3397 * window.c (size_window): Avoid needless test at loop start.
3398
04f2d78b
CB
33992011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3400
3401 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3402
d2fc7e3d 34032011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3404
3405 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3406
d2fc7e3d 34072011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3408
3409 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3410 `width' to `bar_area_x' and `bar_area_width', respectively.
3411 (x_scroll_run): Take account of fringe background extension.
3412
04f2d78b
CB
3413 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3414 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3415 `bar_area_width', respectively.
3416 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3417 background extension.
3418
79b70037
GM
34192011-05-10 Jim Meyering <meyering@redhat.com>
3420
3421 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3422
2f142cc5
JB
34232011-05-10 Juanma Barranquero <lekktu@gmail.com>
3424
3425 * image.c (Finit_image_library): Return t for built-in image types,
3426 like pbm and xbm. (Bug#8640)
3427
57679c86
AS
34282011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3429
3430 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3431
888c9e86
EZ
34322011-05-07 Eli Zaretskii <eliz@gnu.org>
3433
b0512a1d
EZ
3434 * w32console.c (Fset_screen_color): Doc fix.
3435 (Fget_screen_color): New function.
3436 (syms_of_ntterm): Defsubr it.
3437
7285dc67
EZ
3438 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3439 unlink the temporary file if Fcall_process didn't create it in the
3440 first place.
3441 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3442 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3443 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3444 cue to call_process_cleanup not to close that handle.
3445
4d3fcc8e
BK
34462011-05-07 Ben Key <bkey76@gmail.com>
3447
3448 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3449 one of two shell specific rules, either bootstrap-temacs-CMD or
3450 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3451 to the previous implementation of the bootstrap-temacs rule.
3452 The bootstrap-temacs-CMD rule is similar to the previous
3453 implementation of the bootstrap-temacs rule except that it
3454 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3455 variable.
3456
3457 These changes, along with some changes to nt/configure.bat,
3458 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3459 earlier fix to add support for --cflags and --ldflags options
3460 that include quotes so that it works whether make uses cmd or
3461 sh as the shell.
3462
b4289b64
MA
34632011-05-06 Michael Albinus <michael.albinus@gmx.de>
3464
3465 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3466 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3467 is a constant.
3468 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3469 a string. Handle both cases.
3470 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3471 (Fdbus_register_method): Use Qinvalid_function.
3472
af4c0e28
JB
34732011-05-06 Juanma Barranquero <lekktu@gmail.com>
3474
3475 * makefile.w32-in: Update dependencies.
3476 (LISP_H): Add inttypes.h and stdin.h.
3477 (PROCESS_H): Add unistd.h.
3478
c51453d9
EZ
34792011-05-06 Eli Zaretskii <eliz@gnu.org>
3480
3481 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3482 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3483
8ff0ac3c 34842011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3485
4c4b566b
PE
3486 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3487
aab2b9b5
PE
3488 * term.c (vfatal): Remove stray call to va_end.
3489 It's not needed and the C Standard doesn't allow it here anyway.
3490
c378da0b
PE
3491 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3492 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3493
288b08c7
PE
3494 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3495 bytes.
3496
e3601888
PE
3497 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3498
db6c0e74
PE
3499 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3500
dd5963ea
PE
3501 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3502
88c9450f
PE
3503 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3504
2f9442b8
PE
3505 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3506
c032b5f8
PE
3507 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3508 * charset.c (Fdefine_charset_internal): Don't initialize
3509 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3510 32-bit int (Bug#8600).
a108c10b
PE
3511
3512 * lread.c (read_integer): Be more consistent with string-to-number.
3513 Use string_to_number to do the actual conversion; this avoids
3514 rounding errors and fixes some other screwups. Without this fix,
3515 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3516 (digit_to_number): Move earlier, for benefit of read_integer.
3517 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3518 not a digit in any supported base. (Bug#8602)
a108c10b 3519
ad5f9eea
PE
3520 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3521
aec1708a
PE
3522 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3523 to match comment at start of function. This also removes a
3524 GCC warning about overflow in a 32+64-bit port.
3525
47be4ab5
PE
3526 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3527
371cac43
PE
3528 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3529 Reported by Stefan Monnier in
3530 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3531 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3532 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3533
d01a7826
PE
3534 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3535 (EMACS_UINTPTR): Likewise, with uintptr_t.
3536
7fd47d5c
PE
3537 * lisp.h: Prefer 64-bit EMACS_INT if available.
3538 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3539 on 32-bit hosts that have 64-bit int, so that they can access
3540 large files.
122b0c86
PE
3541 However, temporarily disable this change unless the temporary
3542 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3543
8727937b
PE
3544 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3545
8ac068ac
PE
3546 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3547 This removes an assumption that EMACS_INT and long are the same
3548 width as pointers. The assumption is true for Emacs porting targets
3549 now, but we want to make other targets possible.
3550 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3551 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3552 In the rest of the code, change types of integers that hold casted
3553 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3554 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3555 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3556 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3557 No need to cast type when ORing.
3558 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3559 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3560 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3561 assume EMACS_INT is the same width as char *.
3562 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3563 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3564 Remove no-longer-needed casts.
3565 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3566 (xg_tool_bar_help_callback, xg_make_tool_item):
3567 Use EMACS_INTPTR to hold an integer
3568 that will be cast to void *; this can avoid a GCC warning
3569 if EMACS_INT is not the same width as void *.
3570 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3571 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3572 (current_message_1, set_message_1):
3573 Use a local to convert to proper width without a cast.
3574 * xmenu.c (dialog_selection_callback): Likewise.
3575
ede49d71
PE
3576 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3577 Also, don't assume VALBITS / RAND_BITS is less than 5,
3578 and don't rely on undefined behavior when shifting a 1 left into
3579 the sign bit.
3580 * lisp.h (get_random): Change signature to match.
3581
2f30ecd0
PE
3582 * lread.c (hash_string): Use size_t, not int, for hash computation.
3583 Normally we prefer signed values; but hashing is special, because
3584 it's better to use unsigned division on hash table sizes so that
3585 the remainder is nonnegative. Also, size_t is the natural width
3586 for hashing into memory. The previous code used 'int', which doesn't
3587 retain enough info to hash well into very large tables.
3588 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3589
2a866e7b
PE
3590 * dbusbind.c: Don't possibly lose pointer info when converting.
3591 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3592 Use XPNTR rather than XHASH, so that the high-order bits of
3593 the pointer aren't lost when converting through void *.
3594
51639eac
PE
3595 * eval.c (Fautoload): Don't double-shift a pointer.
3596
92394119
PE
3597 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3598
dbdb9a7c
JB
35992011-05-06 Juanma Barranquero <lekktu@gmail.com>
3600
3601 * gnutls.c (DEF_GNUTLS_FN):
3602 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3603
db7a0b4f
AS
36042011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3605
3606 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3607 marker. (Bug#8610)
3608
f7ff1b0f 36092011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3610
3611 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3612 New version that can reserve upto 2GB of heap space.
3613
f7ff1b0f 36142011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3615
3616 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3617
639c109b
TZ
36182011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3619
3620 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3621 `gnutls_certificate_set_x509_key_file'.
3622
d2127135
JB
36232011-05-05 Juanma Barranquero <lekktu@gmail.com>
3624
3625 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3626 Update dependencies.
3627
e968f4f3
JB
36282011-05-04 Juanma Barranquero <lekktu@gmail.com>
3629
3630 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3631 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3632 Remove unused parameter `fildes'.
3633 * process.c (read_process_output, send_process): Don't pass it.
3634
84d358f0
JB
36352011-05-04 Juanma Barranquero <lekktu@gmail.com>
3636
3637 Fix previous change: the library cache is defined in w32.c.
3638 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3639 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3640
0898ca10
JB
36412011-05-04 Juanma Barranquero <lekktu@gmail.com>
3642
3643 Implement dynamic loading of GnuTLS on Windows.
3644
3645 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3646 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3647 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3648 Declare.
3649
3650 * gnutls.c (Qgnutls_dll): Define.
3651 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3652 (gnutls_*): Declare function pointers.
3653 (init_gnutls_functions): New function to initialize function pointers.
3654 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3655 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3656 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3657 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3658 (emacs_gnutls_write, emacs_gnutls_read)
3659 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3660 (Fgnutls_available_p): New function.
3661 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3662 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3663 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3664
3665 * image.c: Include w32.h.
3666 (Vimage_type_cache): Delete.
3667 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3668 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3669 (w32_delayed_load): Move to w32.c.
3670
3671 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3672
3673 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3674 (w32_delayed_load): Move from image.c. When loading a library, record
3675 its filename in the :loaded-from property of the library id.
3676 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3677 Initialize and staticpro them.
3678 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3679
3680 * process.c: Include lisp.h before w32.h, not after.
3681 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3682 instead of gnutls_record_check_pending.
3683
3684 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3685
ff4de4aa
TZ
36862011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3687
3688 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3689 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3690 as passed in.
3691
abe95abb
JD
36922011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3693
3694 * xterm.c (x_set_frame_alpha): Do not set property on anything
3695 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3696
e16e55d4
JB
36972011-05-02 Juanma Barranquero <lekktu@gmail.com>
3698
3699 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3700
bafcf6a5
JB
37012011-05-02 Juanma Barranquero <lekktu@gmail.com>
3702
3703 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3704 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3705 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3706 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3707 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3708 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3709 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3710 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3711 (Qgnutls_bootprop_callbacks_verify): Make static.
3712
e7a6747f
AS
37132011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3714
19ed11ba
AS
3715 * callproc.c: Indentation fixup.
3716
e7a6747f 3717 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3718 (wait_for_termination, interruptible_wait_for_termination):
3719 Move after wait_for_termination_1.
e7a6747f 3720
1ef14cb4
LMI
37212011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3722
3723 * sysdep.c (interruptible_wait_for_termination): New function
3724 which is like wait_for_termination, but allows keyboard
3725 interruptions.
3726
3727 * callproc.c (Fcall_process): Add (:file "file") as an option for
3728 the STDOUT buffer.
3729 (Fcall_process_region): Ditto.
3730
330d880c
EZ
37312011-04-30 Eli Zaretskii <eliz@gnu.org>
3732
8db90b73
EZ
3733 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3734 rather than `XVECTOR (FOO)->size'.
3735
330d880c
EZ
3736 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3737 inttypes.h, as a gnulib replacement is used if it not available in
3738 system headers.
3739
15cbd324
EZ
37402011-04-21 Eli Zaretskii <eliz@gnu.org>
3741
3742 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3743 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3744 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3745
3746 * coding.c (coding_alloc_by_realloc): Error out if destination
3747 will grow beyond MOST_POSITIVE_FIXNUM.
3748 (decode_coding_emacs_mule): Abort if there isn't enough place in
3749 charbuf for the composition carryover bytes. Reserve an extra
3750 space for up to 2 characters produced in a loop.
3751 (decode_coding_iso_2022): Abort if there isn't enough place in
3752 charbuf for the composition carryover bytes.
3753
37542011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3755
ae940cca
EZ
3756 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3757 aborting when %lld or %lll format is passed.
3758 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3759 %llo or %llx format is passed. (Bug#8545)
3760
03ab8921
EZ
3761 * window.c (window_scroll_line_based): Use a marker instead of
3762 simple variables to record original value of point. (Bug#7952)
3763
afda1437
EZ
3764 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3765 produced by %s or %c overflows available buffer space. (Bug#8545)
3766
f76dee0c
PE
37672011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3768
3769 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3770 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3771
fdc5744d
JB
37722011-04-28 Juanma Barranquero <lekktu@gmail.com>
3773
3774 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3775
638f053a
JB
37762011-04-28 Juanma Barranquero <lekktu@gmail.com>
3777
3778 * keyboard.c (Qdelayed_warnings_hook): Define.
3779 (command_loop_1): Run `delayed-warnings-hook'
3780 if Vdelayed_warnings_list is non-nil.
3781 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3782 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3783
d178f871
EZ
37842011-04-28 Eli Zaretskii <eliz@gnu.org>
3785
3786 * doprnt.c (doprnt): Don't return value smaller than the buffer
3787 size if the message was truncated. (Bug#8545).
3788
b124fd93
JB
37892011-04-28 Juanma Barranquero <lekktu@gmail.com>
3790
3791 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3792 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3793
e810457d
PE
37942011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3795
3796 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3797
ea51cceb
JB
37982011-04-27 Juanma Barranquero <lekktu@gmail.com>
3799
3800 * makefile.w32-in: Update dependencies.
3801
94dcfacf
EZ
38022011-04-27 Eli Zaretskii <eliz@gnu.org>
3803
3804 Improve `doprnt' and its usage. (Bug#8545)
3805 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3806 `format_end'. Remove support for %l as a conversion specifier.
3807 Don't use xrealloc. Improve diagnostics when the %l size modifier
3808 is used. Update the commentary.
3809
3810 * eval.c (verror): Simplify calculation of size_t.
3811
3812 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3813 messages.
3814
f61f41d7
PE
38152011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3816
3817 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3818 change.
3819
96fb4434
PE
38202011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3821
3822 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3823 This makes this file independent of the recent pseudovector change.
3824
671875da 38252011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3826
69e9b5a3
PE
3827 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3828
b5f869a7 3829 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3830 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3831 Remove unused local.
c8926152 3832 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3833
841a1577 3834 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3835 GCC 4.6.0 optimizes based on type-based alias analysis.
3836 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3837 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3838 != &v->size, and therefore "v->size = 1; b->size = 2; return
3839 v->size;" must therefore return 1. This assumption is incorrect
3840 for Emacs, since it type-puns struct Lisp_Vector * with many other
3841 types. To fix this problem, this patch adds a new type struct
f904488f 3842 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3843 and pseudovectors, and helps optimizing compilers not get fooled
3844 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3845 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3846 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3847 the size member.
eab3844f
PE
3848 (XSETPVECTYPE): Rewrite in terms of new macro.
3849 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3850 This is a bit clearer, and further avoids the possibility of
3851 undesirable aliasing.
3852 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3853 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3854 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3855 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3856 (ASIZE): Now uses header.size rather than size.
3857 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3858 to avoid the hassle of writing XVECTOR (foo)->header.size.
3859 (struct vectorlike_header): New type.
eab3844f
PE
3860 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3861 object, to help avoid aliasing.
3862 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3863 (SUBRP): Likewise, since Lisp_Subr is a special case.
3864 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3865 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3866 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3867 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3868 changed to be "header.size" and "header.next".
3869 * buffer.h (struct buffer): Likewise.
3870 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3871 * frame.h (struct frame): Likewise.
3872 * process.h (struct Lisp_Process): Likewise.
3873 * termhooks.h (struct terminal): Likewise.
3874 * window.c (struct save_window_data, struct saved_window): Likewise.
3875 * window.h (struct window): Likewise.
3876 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3877 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3878 * buffer.c (init_buffer_once): Likewise.
3879 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3880 special case.
3881 * process.c (Fformat_network_address): Use local var for size,
3882 for brevity.
3883
0df1eac5
PE
3884 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3885
847ab9d1 3886 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3887 * data.c (atof): Remove decl; no longer used or needed.
3888 (digit_to_number): Move to lread.c.
3889 (Fstring_to_number): Use new string_to_number function, to be
3890 consistent with how the Lisp reader treats infinities and NaNs.
3891 Do not assume that floating-point numbers represent EMACS_INT
3892 without losing information; this is not true on most 64-bit hosts.
3893 Avoid double-rounding errors, by insisting on integers when
3894 parsing non-base-10 numbers, as the documentation specifies.
3895 * lisp.h (string_to_number): New decl, replacing ...
3896 (isfloat_string): Remove.
bc0a5c13 3897 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3898 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3899 appears to have been a coding error. Similarly, do not accept
3900 strings like +-1e0 as floating point numbers. Do not report
3901 overflow for integer overflows unless the base is not 10 which
3902 means we have no simple and reliable way to continue.
3903 Break out the floating-point parsing into a new
3904 function string_to_number, so that Fstring_to_number parses
3905 floating point numbers consistently with the Lisp reader.
04f2d78b 3906 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3907 (E_CHAR, EXP_INT): Remove, replacing with ...
3908 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3909 (string_to_number): New function, replacing isfloat_string.
3910 This function checks for valid syntax and produces the resulting
3911 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3912 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3913 so that overflow for non-base-10 numbers is reported only when
3914 there's no portable and simple way to convert to floating point.
452f4150 3915
67769ffc
PE
3916 * textprop.c (set_text_properties_1): Rewrite for clarity,
3917 and to avoid GCC warning about integer overflow.
3918
c20db43f
PE
3919 * intervals.h (struct interval): Use EMACS_INT for members
3920 where EMACS_UINT might cause problems. See
3921 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3922 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3923 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3924 All uses changed.
37aa2f85
PE
3925 (offset_intervals): Tell GCC not to worry about length overflow
3926 when negating a negative length.
c20db43f 3927
2538aa2f
PE
3928 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3929 (overrun_check_free): Likewise.
3930
f2d3008d
PE
3931 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3932 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3933 word size.
3934
ec8df744
PE
3935 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3936 (gnutls_make_error): Rename local to avoid shadowing.
3937 (gnutls_emacs_global_deinit): ifdef out; not used.
3938 (Fgnutls_boot): Use const for pointer to readonly storage.
3939 Comment out unused local. Fix pointer signedness problems.
3940
640ee02d
PE
3941 * lread.c (openp): Don't stuff size_t into an 'int'.
3942 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3943 about possible signed overflow.
3944
6048fb2a
PE
3945 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3946 (GDK_KEY_g): Don't define if already defined.
3947 (xg_prepare_tooltip): Avoid pointer signedness problem.
3948 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3949
fa3c87e1
PE
3950 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3951 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3952
2172544b
PE
3953 * xfns.c (Fx_window_property): Simplify a bit,
3954 to make a bit faster and to avoid GCC 4.6.0 warning.
3955 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3956
9b821a21
PE
3957 * fns.c (internal_equal): Don't assume size_t fits in int.
3958
3c616cfa
PE
3959 * alloc.c (compact_small_strings): Tighten assertion a little.
3960
c2982e87
PE
3961 Replace pEd with more-general pI, and fix some printf arg casts.
3962 * lisp.h (pI): New macro, generalizing old pEd macro to other
3963 conversion specifiers. For example, use "...%"pI"d..." rather
3964 than "...%"pEd"...".
3965 (pEd): Remove. All uses replaced with similar uses of pI.
3966 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3967 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3968 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3969 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3970 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3971 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3972 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3973 64-bit hosts.
3974 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3975 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3976 * print.c (safe_debug_print, print_object): Likewise.
3977 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3978 to int.
6f04d126
PE
3979 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3980 avoiding the 0 flag, which is not portable.
c2982e87
PE
3981 * process.c (Fmake_network_process): Use pI to avoid cast.
3982 * region-cache.c (pp_cache): Likewise.
3983 * xdisp.c (decode_mode_spec): Likewise.
3984 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3985 behavior on 64-bit hosts with printf arg.
6f04d126 3986 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3987 (x_stop_queuing_selection_requests): Likewise.
3988 (x_get_window_property): Don't truncate byte count to an 'int'
3989 when tracing.
0b432f21 3990
5e073ec7
PE
3991 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3992 here, since it parses constructs like leading '-' and spaces,
3993 which are not wanted; and it overflows with large numbers.
3994 Instead, simply match F[0-9]+, which is what is wanted anyway.
3995
36372bf9
PE
3996 * alloc.c: Remove unportable assumptions about struct layout.
3997 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3998 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3999 (allocate_vectorlike, make_pure_vector): Use the new macros,
4000 plus offsetof, to remove unportable assumptions about struct layout.
4001 These assumptions hold on all porting targets that I know of, but
4002 they are not guaranteed, they're easy to remove, and removing them
4003 makes further changes easier.
4004
0b432f21
PE
4005 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4006 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4007 (string_overrun_cookie): Now const. Use initializers that
4008 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4009 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4010 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4011 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4012 multiple of sizeof (EMACS_INT); it need not be, if
4013 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4014 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4015
895009e1
JB
40162011-04-26 Juanma Barranquero <lekktu@gmail.com>
4017
4018 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4019
6a7a1b0b
TZ
40202011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4021
4022 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4023 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4024 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4025
841a1577 40262011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4027
4028 * lisp.h (Qdebug): List symbol.
895009e1 4029 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4030 * keyboard.c (debug-on-event): New variable.
4031 (handle_user_signal): Break into debugger when debug-on-event
4032 matches the current signal symbol.
4033
f2d3ba6f
DN
40342011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4035
4036 * alloc.c (check_sblock, check_string_bytes)
4037 (check_string_free_list): Convert to standard C.
4038
42ce4c63
TZ
40392011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4040
4041 * w32.c (emacs_gnutls_push): Fix typo.
4042
825cd63c
EZ
40432011-04-25 Eli Zaretskii <eliz@gnu.org>
4044
fb11d64d
EZ
4045 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4046 "cast to pointer from integer of different size".
4047
825cd63c
EZ
4048 Improve doprnt and its use in verror. (Bug#8545)
4049 * doprnt.c (doprnt): Document the set of format control sequences
4050 supported by the function. Use SAFE_ALLOCA instead of always
4051 using `alloca'.
4052
4053 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4054 is one byte too soon. Don't use xrealloc; instead xfree and
4055 xmalloc anew.
4056
e061a11b
TZ
40572011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4058
4059 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4060 callbacks stage.
4061
4062 * gnutls.c: Renamed global_initialized to
4063 gnutls_global_initialized. Added internals for the
4064 :verify-hostname-error, :verify-error, and :verify-flags
4065 parameters of `gnutls-boot' and documented those parameters in the
4066 docstring. Start callback support.
9173deec
JB
4067 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4068 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4069 on error. Return error code.
e061a11b
TZ
4070 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4071 (emacs_gnutls_read): Likewise.
4072 (Fgnutls_boot): Return handshake error code.
4073 (emacs_gnutls_handle_error): New function.
4074 (wsaerror_to_errno): Likewise.
4075
4076 * w32.h (emacs_gnutls_pull): Add prototype.
4077 (emacs_gnutls_push): Likewise.
4078
4079 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4080 (emacs_gnutls_push): Likewise.
4081
40822011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4083
4084 * process.c (wait_reading_process_output): Check if GnuTLS
4085 buffered some data internally if no FDs are set for TLS
4086 connections.
4087
4088 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4089 (LIBS): Link to USER_LIBS.
4090 ($(BLD)/gnutls.$(0)): New target.
4091
fa6996bc
EZ
40922011-04-24 Eli Zaretskii <eliz@gnu.org>
4093
eb35682e
EZ
4094 * xdisp.c (handle_single_display_spec): Rename the
4095 display_replaced_before_p argument into display_replaced_p, to
4096 make it consistent with the commentary. Fix typos in the
4097 commentary.
4098
e2ad650c
EZ
4099 * textprop.c (syms_of_textprop): Remove dead code.
4100 (copy_text_properties): Delete obsolete commentary about an
4101 interface that was deleted long ago. Fix typos in the description
4102 of arguments.
4103
1b2de274
EZ
4104 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4105 to changes in oldXMenu/XMenu.h from 2011-04-16.
4106 <menu_help_message, prev_menu_help_message>: Constify.
4107 (IT_menu_make_room): menu->help_text is now `const char **';
4108 adjust.
4109
4110 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4111 to changes in oldXMenu/XMenu.h from 2011-04-16.
4112 (struct XMenu): Declare `help_text' `const char **'.
4113
4114 * xfaces.c <Qunspecified>: Make extern again.
4115
4116 * syntax.c: Include sys/types.h before including regex.h, as
4117 required by Posix.
4118
762b15be
EZ
4119 * doc.c (get_doc_string): Improve the format passed to `error'.
4120
4121 * doprnt.c (doprnt): Improve commentary.
4122
4123 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4124
4125 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4126 them with etags.
4127
f1052e5d
EZ
4128 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4129 changes in globals.h immediately force recompilation.
762b15be
EZ
4130 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4131 $(CURDIR)/s/ms-w32.h.
4132 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4133
fa6996bc
EZ
4134 * character.c (Fchar_direction): Function deleted.
4135 (syms_of_character): Don't defsubr it.
4136 <char-direction-table>: Deleted.
4137
e6c3da20
EZ
41382011-04-23 Eli Zaretskii <eliz@gnu.org>
4139
4140 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4141 * doprnt.c: Include limits.h.
4142 (SIZE_MAX): New macro.
04f2d78b
CB
4143 (doprnt): Return a size_t value. 2nd arg is now size_t.
4144 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4145 Improve overflow protection. Support `l' modifier for integer
4146 conversions. Support %l conversion. Don't assume an EMACS_INT
4147 argument for integer conversions and for %c.
4148
4149 * lisp.h (doprnt): Restore prototype.
4150
4151 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4152 $(SRC)/character.h.
4153
4154 * Makefile.in (base_obj): Add back doprnt.o.
4155
4156 * deps.mk (doprnt.o): Add back prerequisites.
4157 (callint.o): Depend on character.h.
4158
4159 * eval.c (internal_lisp_condition_case): Include the handler
4160 representation in the error message.
4161 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4162 when breaking from the loop.
4163
4164 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4165
4166 * callint.c (Fcall_interactively): When displaying error message
4167 about invalid control letter, pass the character's codepoint, not
4168 a pointer to its multibyte form. Improve display of the character
4169 in octal and display also its hex code.
4170
4171 * character.c (char_string): Use %x to display the (unsigned)
4172 codepoint of an invalid character, to avoid displaying a bogus
4173 negative value.
4174
4175 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4176 `error', not SYMBOL_NAME itself.
4177
4178 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4179 character arguments to `error'.
4180
4181 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4182 to `error' in error message about FINAL_CHAR argument. Make sure
4183 FINAL_CHAR is a character, and use %c when it is passed as
4184 argument to `error'.
4185
4ffd0d6b 41862011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4187
4188 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4189
4190 * w32.c: Include <time.h>.
4191 (sys_localtime): New function.
4192
4ffd0d6b 41932011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4194
4195 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4196
4ffd0d6b 4197 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4198
4ffd0d6b 41992011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4200
4ffd0d6b
GM
4201 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4202 zombies (Bug#8467).
aac0c6e3 4203
04c56954
EZ
42042011-04-19 Eli Zaretskii <eliz@gnu.org>
4205
4206 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4207 gl_state.e_property when gl_state.object is Qt.
4208
4209 * insdel.c (make_gap_larger): Remove limitation of buffer size
4210 to <= INT_MAX.
4211
16a43933
CY
42122011-04-18 Chong Yidong <cyd@stupidchicken.com>
4213
4214 * xdisp.c (lookup_glyphless_char_display)
4215 (produce_glyphless_glyph): Handle cons cell entry in
4216 glyphless-char-display.
4217 (Vglyphless_char_display): Document it.
4218
4219 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4220 glyphless-char-display.
4221
4581706e
CY
42222011-04-17 Chong Yidong <cyd@stupidchicken.com>
4223
4224 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4225
4226 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4227
4228 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4229 definition for no-X builds.
4230
4887c6e2 42312011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4232
fd35b6f9
PE
4233 Static checks with GCC 4.6.0 and non-default toolkits.
4234
5c1ccb01
PE
4235 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4236
006c5daa
PE
4237 * process.c (keyboard_bit_set): Define only if SIGIO.
4238 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4239 (send_process): Repair possible setjmp clobbering.
4240
efc736d3
PE
4241 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4242
4e2fe2e6
PE
4243 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4244
f97334a2
PE
4245 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4246
4e75f29d
PE
4247 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4248 Define only if needed.
4249
90efadd1
PE
4250 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4251 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4252 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4253
3c647824
PE
4254 * dispextern.h (struct redisplay_interface): Rename param
4255 to avoid shadowing.
e264f262 4256 * termhooks.h (struct terminal): Likewise.
761383f4 4257 * xterm.c (xembed_send_message): Likewise.
3c647824 4258
b58c5c4a
PE
4259 * insdel.c (make_gap_smaller): Define only if
4260 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4261
cad59032
PE
4262 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4263 it.
4264
c339dc2e
PE
4265 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4266 so that we aren't warned about unused symbols.
4267
91a3e27b
PE
4268 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4269
399c71d3 4270 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4271
8ffc96f5
PE
4272 * xfns.c (x_real_positions): Mark locals as initialized.
4273
eef9bc79
PE
4274 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4275
098db9dd
PE
4276 * xterm.c: Fix problems found by static analysis with other toolkits.
4277 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4278 (x_dispatch_event): Declare static if USE_GTK, and
4279 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4280 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4281 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4282 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4283 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4284
eb18f6cc
PE
4285 * xmenu.c (menu_help_callback): Pointer type fixes.
4286 Use const pointers when pointing at readonly data. Avoid pointer
4287 signedness clashes.
4288 (FALSE): Remove unused macro.
4289 (update_frame_menubar): Remove unused decl.
4290
1fe72bf8
PE
4291 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4292
60d9e1db
PE
4293 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4294 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4295 (single_menu_item): Rename local to avoid shadowing.
4296
39261c26
PE
4297 * keyboard.c (make_lispy_event): Remove unused local var.
4298
018c5e19
PE
4299 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4300 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4301
63d2b86e
PE
4302 * bitmaps: Change bitmaps from unsigned char back to the X11
4303 compatible char. Avoid the old compiler warnings about
4304 out-of-range initializers by using, for example, '\xab' rather
4305 than 0xab.
4306
aefd87e1
PE
4307 * xgselect.c (xgselect_initialize): Check vs interface
4308 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4309
bf501fb9
PE
4310 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4311
e9829fdf
PE
4312 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4313 to read-only memory.
4314
1086c095
PE
4315 * fns.c (vector): Remove; this old hack is no longer needed.
4316
2baccd04 4317 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4318 Remove unused var.
dde42981 4319 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4320
72391843 4321 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4322
436c16df 4323 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4324 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4325 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4326
92bb796d 4327 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4328 (x_term_init): Remove local to avoid shadowing.
92bb796d 4329
764430a3 4330 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4331
4332 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4333 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4334
d1dfb56c
EZ
43352011-04-16 Eli Zaretskii <eliz@gnu.org>
4336
c4354cb4
EZ
4337 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4338
d1dfb56c
EZ
4339 Fix regex.c, syntax.c and friends for buffers > 2GB.
4340 * syntax.h (struct gl_state_s): Declare character position members
4341 EMACS_INT.
4342
4343 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4344
04f2d78b
CB
4345 * textprop.c (verify_interval_modification, interval_of):
4346 Declare arguments EMACS_INT.
d1dfb56c
EZ
4347
4348 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4349 EMACS_INT.
4350
4351 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4352
4353 * indent.c (Fvertical_motion): Local variable it_start is now
4354 EMACS_INT.
4355
4356 * regex.c (re_match, re_match_2, re_match_2_internal)
4357 (bcmp_translate, regcomp, regexec, print_double_string)
4358 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4359 (re_compile_pattern, re_exec): Declare arguments and local
4360 variables `size_t' and `ssize_t' and return values `regoff_t', as
4361 appropriate.
4362 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4363 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4364 <compile_stack_type>: `size' and `avail' are now `size_t'.
4365
4366 * regex.h <regoff_t>: Use ssize_t, not int.
4367 (re_search, re_search_2, re_match, re_match_2): Arguments that
4368 specify buffer/string position and length are now ssize_t and
4369 size_t. Return type is regoff_t.
4370
613052cd
BK
43712011-04-16 Ben Key <bkey76@gmail.com>
4372
4373 * nsfont.m: Fixed bugs in ns_get_family and
4374 ns_descriptor_to_entity that were caused by using free to
4375 deallocate memory blocks that were allocated by xmalloc (via
4376 xstrdup). This caused Emacs to crash when compiled with
4377 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4378 --enable-checking=xmallocoverrun). xfree is now used to
4379 deallocate these memory blocks.
4380
4170f62f 43812011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4382
71b41406
PE
4383 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4384
9587a89d
PE
4385 emacs_write: Accept and return EMACS_INT for sizes.
4386 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4387 et seq.
4388 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4389 Accept and return EMACS_INT.
4390 (emacs_gnutls_write): Return the number of bytes written on
4391 partial writes.
4392 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4393 (emacs_read, emacs_write): Remove check for negative size, as the
4394 Emacs source code has been audited now.
9587a89d
PE
4395 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4396 (emacs_read, emacs_write): Use it.
273a5f82
PE
4397 * process.c (send_process): Adjust to the new signatures of
4398 emacs_write and emacs_gnutls_write. Do not attempt to store
4399 a byte offset into an 'int'; it might overflow.
9587a89d 4400 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4401
3e047f51
PE
4402 * sound.c: Don't assume sizes fit in 'int'.
4403 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4404 Return EMACS_INT, not int.
3e047f51 4405 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4406 Accept EMACS_INT, not int.
4407 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4408 record read return values.
4409
cc39a9db
BK
44102011-04-15 Ben Key <bkey76@gmail.com>
4411
c9d0ec6d
JB
4412 * keyboard.c (Qundefined): Don't declare static since it is used
4413 in nsfns.m.
4414 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4415 static since they are used in nsfont.m.
cc39a9db 4416
6c60eb9f
SM
44172011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4418
4419 * process.c (Qprocessp): Don't declare static.
4420 * lisp.h (Qprocessp): Declare again.
4421
7990b61a
JB
44222011-04-15 Juanma Barranquero <lekktu@gmail.com>
4423
4424 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4425
5d4cb038
PE
44262011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4427
8bd7b830 4428 Improve C-level modularity by making more things 'static'.
cd64ea1d 4429
e3b27b31
PE
4430 Don't publish debugger-only interfaces to other modules.
4431 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4432 (verify_bytepos, count_markers): Move decls to the only modules
4433 that need them.
4434 * region-cache.h (pp_cache): Likewise.
4435 * window.h (check_all_windows): Likewise.
4436 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4437
5d4cb038
PE
4438 * sysdep.c (croak): Now static, if
4439 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4440 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4441
4442 * alloc.c (refill_memory_reserve): Now static if
4443 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4444 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4445
e87b6180
PE
4446 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4447 Define only if USE_LUCID.
4448
ac64929e
PE
4449 * xrdb.c (x_customization_string, x_rm_string): Now static.
4450
6f37259d
PE
4451 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4452 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4453
1683e3ab
PE
4454 * xdisp.c (draw_row_with_mouse_face): Now static.
4455 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4456
de9c2632
PE
4457 * window.h (check_all_windows): Mark externally visible.
4458
2b96acb7
PE
4459 * window.c (window_deletion_count): Now static.
4460
4461 * undo.c: Make symbols static if they're not exported.
4462 (last_undo_buffer, last_boundary_position, pending_boundary):
4463 Now static.
4464
50436f33
PE
4465 * textprop.c (interval_insert_behind_hooks): Now static.
4466 (interval_insert_in_front_hooks): Likewise.
4467
64520e5c
PE
4468 * term.c: Make symbols static if they're not exported.
4469 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4470 (max_frame_lines, tty_set_terminal_modes):
4471 (tty_reset_terminal_modes, tty_turn_off_highlight):
4472 (get_tty_terminal): Now static.
4473 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4474 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4475 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4476 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4477 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4478
1fa53021
PE
4479 * sysdep.c: Make symbols static if they're not exported.
4480 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4481 Now static.
4482 (sigprocmask_set, full_mask): Remove; unused.
4483 (wait_debugging): Mark as visible.
4484 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4485 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4486
d4b43b22
PE
4487 * syntax.c (syntax_temp): Define only if !__GNUC__.
4488
b7c513d0
PE
4489 * sound.c (current_sound_device, current_sound): Now static.
4490
989b29ad
PE
4491 * search.c (searchbufs, searchbuf_head): Now static.
4492
13a55a78
PE
4493 * scroll.c (scroll_cost): Remove; unused.
4494 * dispextern.h (scroll_cost): Remove decl.
4495
de68a1fc
PE
4496 * region-cache.h (pp_cache): Mark as externally visible.
4497
40ccffa6
PE
4498 * process.c: Make symbols static if they're not exported.
4499 (process_tick, update_tick, create_process, chan_process):
4500 (Vprocess_alist, proc_buffered_char, datagram_access):
4501 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4502 (deactivate_process): Mark defn as static, as well as decl.
4503 * lisp.h (create_process): Remove decl.
4504 * process.h (chan_process, Vprocess_alist): Remove decls.
4505
ad64fc97
PE
4506 * print.c: Make symbols static if they're not exported.
4507 (print_depth, new_backquote_output, being_printed, print_buffer):
4508 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4509 (print_interval, print_number_index, initial_stderr_stream):
4510 Now static.
4511 * lisp.h (Fprinc): Remove decl.
4512 (debug_output_compilation_hack): Mark as externally visible.
4513
adddb265
PE
4514 * sysdep.c (croak): Move decl from here to syssignal.h.
4515 * syssignal.h (croak): Put it here, so the API can be checked when
4516 'croak' is called from dissociate_if_controlling_tty.
4517
1717ede2
PE
4518 * minibuf.c: Make symbols static if they're not exported.
4519 (minibuf_save_list, choose_minibuf_frame): Now static.
4520 * lisp.h (choose_minibuf_frame): Remove decl.
4521
fa5fb2bc
PE
4522 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4523
1e3890d1
PE
4524 * lread.c: Make symbols static if they're not exported.
4525 (read_objects, initial_obarray, oblookup_last_bucket_number):
4526 Now static.
4527 (make_symbol): Remove; unused.
4528 * lisp.h (initial_obarray, make_symbol): Remove decls.
4529
8a1414fa
PE
4530 * keyboard.c: Make symbols static if they're not exported.
4531 (single_kboard, recent_keys_index, total_keys, recent_keys):
4532 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4533 (this_single_command_key_start, echoing, last_auto_save):
4534 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4535 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4536 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4537 (Vlispy_mouse_stem, double_click_count):
4538 Now static.
4539 (force_auto_save_soon): Define only if SIGDANGER.
4540 (ignore_mouse_drag_p): Now static if
4541 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4542 (print_help): Remove; unused.
4543 (stop_character, last_timer_event): Mark as externally visible.
4544 * keyboard.h (ignore_mouse_drag_p): Declare only if
4545 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4546 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4547 * lisp.h (echoing): Remove decl.
4548 (force_auto_save_soon): Declare only if SIGDANGER.
4549 * xdisp.c (redisplay_window): Simplify code, to make it more
4550 obvious that ignore_mouse_drag_p is not accessed if !defined
4551 USE_GTK && !defined HAVE_NS.
4552
93ea6e8f
PE
4553 * intervals.c: Make symbols static if they're not exported.
4554 (merge_properties_sticky, merge_interval_right, delete_interval):
4555 Now static.
4556 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4557
77382fcc
PE
4558 * insdel.c: Make symbols static if they're not exported.
4559 However, leave prepare_to_modify_buffer alone. It's never
4560 called from outside this function, but that appears to be a bug.
4561 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4562 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4563 (adjust_after_replace_noundo): Remove; unused.
4564 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4565 (signal_before_change): Remove decls.
77382fcc 4566
9306c32e
PE
4567 * indent.c (val_compute_motion, val_vmotion): Now static.
4568
cd44d2eb
PE
4569 * image.c: Make symbols static if they're not exported.
4570 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4571 if USE_GTK.
4572 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4573 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4574
ad9a7a06
PE
4575 * fringe.c (standard_bitmaps): Now static.
4576 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4577
81626931
PE
4578 * frame.c: Make symbols static if they're not exported.
4579 (x_report_frame_params, make_terminal_frame): Now static.
4580 (get_frame_param): Now static, unless HAVE_NS.
4581 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4582 (x_get_resource_string): Remove; not used.
4583 * frame.h (make_terminal_frame, x_report_frame_params):
4584 (x_get_resource_string); Remove decls.
4585 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4586 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4587
239f9db9
PE
4588 * font.c, fontset.c: Make symbols static if they're not exported.
4589 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4590 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4591 * font.c (font_close_object): Now static.
4592 * font.h (font_close_object): Remove.
4593 * fontset.c (FONTSET_OBJLIST): Remove.
4594 (free_realized_fontset) #if-0 the body, which does nothing.
4595 (face_suitable_for_char_p): #if-0, as it's never called.
4596 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4597 * xfaces.c (face_at_string_position):
4598 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4599 since 0 is always ASCII.
4600
dfcf3579
PE
4601 * fns.c (weak_hash_tables): Now static.
4602
5045092b
PE
4603 * fileio.c: Make symbols static if they're not exported.
4604 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4605 (Vwrite_region_annotation_buffers): Now static.
4606
57a96f5c
PE
4607 * eval.c: Make symbols static if they're not exported.
4608 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4609 * lisp.h (backtrace_list): Remove decl.
4610
35f08c38
PE
4611 * emacs.c: Make symbols static if they're not exported.
4612 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4613 (fatal_error_code, fatal_error_signal_hook, standard_args):
4614 Now static.
4615 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4616 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4617 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4618 * lisp.h (fatal_error_signal_hook): Remove decl.
4619 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4620
f44bd759
PE
4621 * editfns.c: Move a (normally-unused) function to its only use.
4622 * editfns.c, lisp.h (get_operating_system_release): Remove.
4623 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4624 worth the hassle of breaking this out.
4625
b532497d
PE
4626 * xterm.c: Make symbols static if they're not exported.
4627 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4628 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4629 (x_destroy_window, x_delete_display):
4630 Now static.
4631 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4632 (x_mouse_leave): Remove; unused.
4633 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4634 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4635 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4636 Remove decls.
4637 (x_mouse_leave): Declare only if WINDOWSNT.
4638 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4639 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4640 USE_X_TOOLKIT.
4641
1675728f
PE
4642 * ftxfont.c: Make symbols static if they're not exported.
4643 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4644 HAVE_FREETYPE.
4645 * font.h (ftxfont_driver): Likewise.
4646
e4cebfca
PE
4647 * xfns.c: Make symbols static if they're not exported.
4648 (x_last_font_name, x_display_info_for_name):
4649 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4650 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4651 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4652 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4653 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4654 (last_show_tip_args): Now static.
4655 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4656 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4657 (x_screen_planes): Remove; unused.
4658 * dispextern.h (x_screen_planes): Remove decl.
4659
5bf46f05
PE
4660 * dispnew.c: Make symbols static if they're not exported.
4661 * dispextern.h (redraw_garbaged_frames, scrolling):
4662 (increment_row_positions): Remove.
4663 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4664 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4665 Now static.
4666 (redraw_garbaged_frames): Remove; unused.
4667
435f4c28
PE
4668 * xfaces.c: Make symbols static if they're not exported.
4669 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4670 Remove decls.
4671 * xterm.h (defined_color): Remove decls.
4672 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4673 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4674 (menu_face_changed_default, defined_color, free_realized_face):
4675 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4676 (ascii_face_of_lisp_face): Remove; unused.
4677
8524aef3
PE
4678 * xdisp.c: Make symbols static if they're not exported.
4679 * dispextern.h (scratch_glyph_row, window_box_edges):
4680 (glyph_to_pixel_coords, set_cursor_from_row):
4681 (get_next_display_element, set_iterator_to_next):
4682 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4683 (show_mouse_face): Remove decls
4684 * frame.h (message_buf_print): Likewise.
4685 * lisp.h (pop_message, set_message, check_point_in_composition):
4686 Likewise.
4687 * xterm.h (set_vertical_scroll_bar): Likewise.
4688 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4689 (message_buf_print, scratch_glyph_row, displayed_buffer):
4690 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4691 (get_next_display_element, show_mouse_face, window_box_edges):
4692 (frame_to_window_pixel_xy, check_point_in_composition):
4693 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4694 (glyph_to_pixel_coords): Remove; unused.
4695
16390cd2
PE
4696 * dired.c (file_name_completion): Now static.
4697
4698 * dbusbind.c (xd_in_read_queued_messages): Now static.
4699
a25f4dfa
PE
4700 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4701 * data.c (circular_list_error): Remove.
4702
14a9c8df
PE
4703 * commands.h (last_point_position, last_point_position_buffer):
4704 (last_point_position_window): Remove decls.
4705 * keyboard.c: Make these variables static.
4706
04f2d78b
CB
4707 * coding.h (coding, code_convert_region, encode_coding_gap):
4708 Remove decls.
74ab6df5
PE
4709 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4710 (iso_code_class, detect_coding, code_convert_region): Now static.
4711 (encode_coding_gap): Remove; unused.
4712
38dfbee1
PE
4713 * chartab.c (chartab_chars, chartab_bits): Now static.
4714
a2cb4e63
PE
4715 * charset.h (charset_iso_8859_1): Remove decl.
4716 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4717 Now static.
4718
127198fd
PE
4719 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4720 * ccl.c (Vccl_program_table): Now static.
4721 (check_ccl_update): Remove; unused.
4722
d85b608f
PE
4723 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4724 * category.h: ... from here.
4725 * category.c (check_category_table, set_category_set): Now static.
4726
31cd66f3
PE
4727 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4728 * lisp.h: Remove these decls.
4729
c358e587
PE
4730 * buffer.c (buffer_count): Remove unused var.
4731
e78aecca
PE
4732 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4733 so that it's not optimized away.
4734 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4735 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4736 exported only to the debugger.
4737
e192d7d3 4738 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4739 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4740
92470028
PE
4741 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4742 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4743 was inaccessible from Lisp.
4744 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4745 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4746
244ed907
PE
4747 alloc.c: Import and export fewer symbols, and remove unused items.
4748 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4749 is defined.
4750 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4751 it's not optimized away by whole-program optimization.
4752 (message_enable_multibyte, free_misc): Remove.
4753 (catchlist, handlerlist, mark_backtrace):
4754 Declare only if BYTE_MARK_STACK.
4755 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4756 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4757 (message_enable_multibyte): Remove decl.
4758 (free_misc, interval_free_list, float_block, float_block_index):
4759 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4760 (cons_free_list, last_marked_index):
4761 Now static.
4762 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4763 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4764 (mark_backtrace): Define only if BYTE_MARK_STACK.
4765 * xdisp.c (message_enable_multibyte): Now static.
4766
61c2b50e 4767 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4768 This makes it easier for human readers (and static analyzers)
4769 to see whether these variables are used from other modules.
4770 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4771 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4772 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4773 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4774 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4775 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4776 * xmenu.c, xselect.c:
4777 Declare Q* vars static if they are not used in other modules.
4778 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4779 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4780 Remove decls of unexported vars.
4781 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4782
95c82688
PE
4783 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4784
16a97296
PE
4785 Make Emacs functions such as Fatom 'static' by default.
4786 This makes it easier for human readers (and static analyzers)
4787 to see whether these functions can be called from other modules.
4788 DEFUN now defines a static function. To make the function external
4789 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4790 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4791 (Finit_image_library):
16a97296
PE
4792 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4793 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4794 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4795 Remove decls, since these functions are now static.
4796 (Funintern, Fget_internal_run_time): New decls, since these functions
4797 were already external.
95c82688 4798
16a97296
PE
4799 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4800 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4801 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4802 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4803 * keyboard.c, keymap.c, lread.c:
4804 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4805 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4806 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4807 Mark functions with DEFUE instead of DEFUN,
4808 if they are used in other modules.
4809 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4810 decls for now-static functions.
4811 * buffer.h (Fdelete_overlay): Remove decl.
4812 * callproc.c (Fgetenv_internal): Mark as internal.
4813 * composite.c (Fremove_list_of_text_properties): Remove decl.
4814 (Fcomposition_get_gstring): New forward static decl.
4815 * composite.h (Fcomposite_get_gstring): Remove decl.
4816 * dired.c (Ffile_attributes): New forward static decl.
4817 * doc.c (Fdocumntation_property): New forward static decl.
4818 * eval.c (Ffetch_bytecode): New forward static decl.
4819 (Funintern): Remove extern decl; now in .h file where it belongs.
4820 * fileio.c (Fmake_symbolic_link): New forward static decl.
4821 * image.c (Finit_image_library): New forward static decl.
4822 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4823 * intervals.h (Fprevious_property_change):
4824 (Fremove_list_of_text_properties): Remove decls.
4825 * keyboard.c (Fthis_command_keys): Remove decl.
4826 (Fcommand_execute): New forward static decl.
4827 * keymap.c (Flookup_key): New forward static decl.
4828 (Fcopy_keymap): Now static.
4829 * keymap.h (Flookup_key): Remove decl.
4830 * process.c (Fget_process): New forward static decl.
4831 (Fprocess_datagram_address): Mark as internal.
4832 * syntax.c (Fsyntax_table_p): New forward static decl.
4833 (skip_chars): Remove duplicate decl.
4834 * textprop.c (Fprevious_property_change): New forward static decl.
4835 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4836 Now internal.
4837 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4838 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4839
785bbd42
PE
4840 * editfns.c (Fformat): Remove unreachable code.
4841
8b913b57
AS
48422011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4843
4844 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4845 change. (Bug#8496)
4846
a6744a35
EZ
48472011-04-13 Eli Zaretskii <eliz@gnu.org>
4848
4849 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4850 when at ZV. (Bug#8487)
4851
e7974947
AS
48522011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4853
baad03f0
AS
4854 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4855 (Bug#8437)
4856 * keyboard.c (parse_tool_bar_item): Likewise.
4857 * sound.c (sound_cleanup, alsa_close): Likewise.
4858 * termcap.c (tgetent): Likewise.
4859 * xfns.c (x_default_font_parameter): Likewise.
4860 * xsettings.c (read_and_apply_settings): Likewise.
4861
e7974947
AS
4862 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4863 (overrun_check_free): Protoize.
4864
28272684
PE
48652011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4866
4867 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4868 since callers should never pass a negative size.
4869 Change the signature to match that of plain 'read' and 'write'; see
4870 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4871 * lisp.h: Update prototypes of emacs_write and emacs_read.
4872
11997c76
EZ
48732011-04-11 Eli Zaretskii <eliz@gnu.org>
4874
4875 * xdisp.c (redisplay_window): Don't try to determine the character
4876 position of the scroll margin if the window start point w->startp
e896f03c 4877 is outside the buffer's accessible region. (Bug#8468)
11997c76 4878
8a2cbd72
EZ
48792011-04-10 Eli Zaretskii <eliz@gnu.org>
4880
4881 Fix write-region and its subroutines for buffers > 2GB.
4882 * fileio.c (a_write, e_write): Modify declaration of arguments and
4883 local variables to support buffers larger than 2GB.
4884 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4885
4886 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4887 argument, local variables, and return value.
4888
4889 * lisp.h: Update prototypes of emacs_write and emacs_read.
4890
4891 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4892
4073e537 48932011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4894
1ebfdcb6
PE
4895 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4896
b2ded58d
PE
4897 Fix more problems found by GCC 4.6.0's static checks.
4898
7d66342c
PE
4899 * xdisp.c (vmessage): Use a better test for character truncation.
4900
bbf47d44
PE
4901 * charset.c (load_charset_map): <, not <=, for optimization,
4902 and to avoid potential problems with integer overflow.
9248994d 4903 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4904 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4905 * editfns.c (Fformat): Likewise.
1e69125e 4906 * syntax.c (skip_chars): Likewise.
3befa583 4907
e3019616
PE
4908 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4909 This also lets GCC 4.6.0 generate slightly better loop code.
4910
becfa255
PE
4911 * callint.c (Fcall_interactively): <, not <=, for optimization.
4912 (Fcall_interactively): Count the number of arguments produced,
4913 not the number of arguments given. This is simpler and lets GCC
4914 4.6.0 generate slightly better code.
4915
dae0cd48
PE
4916 * ftfont.c: Distingish more carefully between FcChar8 and char.
4917 The previous code passed unsigned char * to a functions like
4918 strlen and xstrcasecmp that expect char *, which does not
4919 conform to the C standard.
4920 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4921 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4922 char * when the C standard requires it.
4923
76032d70
PE
4924 * keyboard.c (read_char): Remove unused var.
4925
eb3f1cc8
PE
4926 * eval.c: Port to Windows vsnprintf (Bug#8435).
4927 Include <limits.h>.
4928 (SIZE_MAX): Define if the headers do not.
4929 (verror): Do not give up if vsnprintf returns a negative count.
4930 Instead, grow the buffer. This ports to Windows vsnprintf, which
4931 does not conform to C99. Problem reported by Eli Zaretskii.
4932 Also, simplify the allocation scheme, by avoiding the need for
4933 calling realloc, and removing the ALLOCATED variable.
4934
70476b54
PE
4935 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4936
12020a9e
PE
4937 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4938 But keep the doprint source code for now, as we might revamp it
4939 and use it again (Bug#8435).
ea6c7ae6
PE
4940 * lisp.h (doprnt): Remove.
4941 * Makefile.in (base_obj): Remove doprnt.o.
4942 * deps.mk (doprnt.o): Remove.
4943
5fdb398c
PE
4944 error: Print 32- and 64-bit integers portably (Bug#8435).
4945 Without this change, on typical 64-bit hosts error ("...%d...", N)
4946 was used to print both 32- and 64-bit integers N, which relied on
4947 undefined behavior.
4948 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4949 New macro.
4950 * lisp.h (error, verror): Mark as printf-like functions.
4951 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4952 Report overflow in size calculations when allocating printf buffer.
4953 Do not truncate output string at its first null byte.
4954 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4955 Truncate the output at a character boundary, since vsnprintf does not
4956 do that.
4957 * charset.c (check_iso_charset_parameter): Convert internal
4958 character to string before calling 'error', since %c now has the
4959 printf meaning.
4960 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4961 overflow when computing char to be passed to 'error'. Do not
4962 pass Lisp_Object to 'error'; pass the integer instead.
4963 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4964 formatted with plain %d.
4965
b189fa66
PE
4966 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4967
bff87ef0
PE
4968 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4969
7e2cac20
PE
4970 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4971
ce4d90b5
PE
4972 * xterm.c (x_catch_errors): Remove duplicate declaration.
4973
266c9547
PE
4974 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4975
79c49ad2
PE
4976 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4977
368f4090
JM
49782011-04-10 Jim Meyering <meyering@redhat.com>
4979
4980 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4981 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4982 return ssize_t not "int", and use size_t as the buffer length.
4983 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4984 * gnutls.h: Update declarations.
4985 * process.c (read_process_output): Use ssize_t, to match.
4986 (send_process): Likewise.
4987
a32d4040
CY
49882011-04-09 Chong Yidong <cyd@stupidchicken.com>
4989
4990 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4991
8546720e 49922011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4993
04f2d78b
CB
4994 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4995 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4996
8546720e
GM
4997 * xterm.c (handle_one_xevent):
4998 * xmenu.c (create_and_show_popup_menu):
4999 * xselect.c (x_decline_selection_request)
5000 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5001
0a2f5c1a 50022011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5003
5004 Fix some uses of `int' instead of EMACS_INT.
5005 * search.c (string_match_1, fast_string_match)
5006 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5007 (scan_buffer, find_next_newline_no_quit)
5008 (find_before_next_newline, search_command, Freplace_match)
5009 (Fmatch_data): Make some `int' variables be EMACS_INT.
5010
5011 * xdisp.c (display_count_lines): 3rd argument and return value now
5012 EMACS_INT. All callers changed.
5013 (pint2hrstr): Last argument is now EMACS_INT.
5014
5015 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5016 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5017 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5018 (decode_coding_utf_16, decode_coding_emacs_mule)
5019 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5020 (decode_coding_ccl, decode_coding_charset)
5021 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5022 (decode_coding_iso_2022, decode_coding_emacs_mule)
5023 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5024 <char_offset, last_offset>: Declare EMACS_INT.
5025 (encode_coding_utf_8, encode_coding_utf_16)
5026 (encode_coding_emacs_mule, encode_invocation_designation)
5027 (encode_designation_at_bol, encode_coding_iso_2022)
5028 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5029 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5030 Declare EMACS_INT.
5031 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5032 (encode_invocation_designation): Last argument P_NCHARS is now
5033 EMACS_INT.
5034 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5035 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5036
5037 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5038 All users changed.
5039
5040 * ccl.c (Fccl_execute_on_string): Declare some variables
5041 EMACS_INT.
5042
8546720e 50432011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5044
5045 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5046
4e19a977
CS
50472011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5048
5049 * process.c (Fformat_network_address): Doc fix.
5050
87302331
R
50512011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5052
5053 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5054
cbb59342
CY
50552011-04-08 Chong Yidong <cyd@stupidchicken.com>
5056
5057 * keyboard.c (read_char): Call Lisp function help-form-show,
5058 instead of using internal_with_output_to_temp_buffer.
5059 (Qhelp_form_show): New var.
e0d38eeb 5060 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5061
5062 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5063
5064 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5065
e67a13ab
CY
50662011-04-06 Chong Yidong <cyd@stupidchicken.com>
5067
04f2d78b
CB
5068 * process.c (Flist_processes): Remove to Lisp.
5069 (list_processes_1): Delete.
e67a13ab 5070
973f782d
EZ
50712011-04-06 Eli Zaretskii <eliz@gnu.org>
5072
7c106b1e
EZ
5073 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5074
973f782d
EZ
5075 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5076
41cf7d1a 50772011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5078
ca23cc88
PE
5079 Fix more problems found by GCC 4.6.0's static checks.
5080
f390e2d5
PE
5081 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5082
42eea0d0
PE
5083 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5084
b69769da 5085 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5086
f9541e84
PE
5087 * xdisp.c (vmessage): Mark as a printf-like function.
5088
13841b55
PE
5089 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5090
c136c10f
PE
5091 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5092
5e2d4a30
PE
5093 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5094 printf-like functions.
5095 (tiff_load): Add casts to remove these marks before passing them
5096 to system-supplied API.
5097
583f48b9
PE
5098 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5099
b25d760e
PE
5100 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5101 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5102 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5103 directly, rather than having caller test rule sign. This avoids
5104 some unnecessary tests.
5105 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5106 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5107 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5108
bc7b6697 5109 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5110 (xfont_open): Avoid unnecessary tests.
bc7b6697 5111
27ccc379
PE
5112 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5113
dcd5c89a
PE
5114 * composite.h, composite.c (composition_gstring_put_cache):
5115 Use EMACS_INT, not int, for length.
5116
b13a45c6
PE
5117 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5118 breaking out part of COMPOSITION_DECODE_RULE.
5119 (COMPOSITION_DECODE_RULE): Use it.
5120 * composite.c (get_composition_id): Remove unused local vars,
5121 by using the new macro.
5122
1e792e4d
PE
5123 * textprop.c (set_text_properties_1): Change while to do-while,
5124 since the condition is always true at first.
5125
dc6c6455 5126 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5127 (interval_deletion_adjustment): Return unsigned value.
5128 All uses changed.
dc6c6455 5129
aba7731a
PE
5130 * process.c (list_processes_1, create_pty, read_process_output):
5131 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5132 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5133 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5134 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5135 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5136
fdfc4bf3
PE
5137 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5138
fca8fe46 5139 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5140 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5141
06a0259a 5142 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5143 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5144 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5145
e7b9e80f
PE
5146 * print.c (print_error_message): Avoid int overflow.
5147
56201685
PE
5148 * font.c (font_list_entities): Redo for clarity,
5149 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5150
78834453 5151 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5152 (font_score): Avoid potential overflow in diff calculation.
78834453 5153
0bc0b309 5154 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5155 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5156
e610eaca
PE
5157 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5158
b895abce
PE
5159 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5160 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5161 can always succeed if overflow has undefined behavior.
5162
1f1d9321 5163 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5164 (wordify): Omit three unnecessary tests.
1f1d9321 5165
c59478bc
PE
5166 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5167 All callers changed. This avoids the need for an unused var.
5168
79b73827
PE
5169 * casefiddle.c (casify_region): Remove var that is set but not used.
5170
a4db5dfe
PE
5171 * dired.c (file_name_completion): Remove var that is set but not used.
5172
43aae36e
PE
5173 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5174
2a47c44d 5175 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5176 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5177
a37c69bf
PE
5178 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5179 Check for integer overflow on size calculations.
5180
328ab8e7
PE
5181 * buffer.c (Fprevious_overlay_change): Remove var that is set
5182 but not used.
5183
e5a2a5cb
PE
5184 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5185 Remove vars that are set but not used.
8d84a6eb 5186 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5187 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5188
a60e5f68
PE
5189 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5190
f661cb61 5191 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5192 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5193
f0397f5a
PE
5194 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5195 that are set but not used.
5196
8664db06 5197 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5198 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5199
6abdaa4a
PE
5200 * xselect.c (x_get_local_selection, x_handle_property_notify):
5201 Remove vars that are set but not used.
5202
0ce7538d 5203 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5204 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5205
9ae848fc
PE
5206 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5207 Remove var that is set but not used.
0b918413
PE
5208 (scroll_bar_windows_size): Now size_t, not int.
5209 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5210 Check for overflow.
9ae848fc 5211
a5a62657
PE
5212 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5213 (map_tty_color) [!defined MSDOS]: Likewise.
5214
5c5cdd39
PE
5215 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5216
66ebf983
PE
5217 * coding.c: Remove vars that are set but not used.
5218 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5219 All callers changed.
5220 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5221 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5222 (decode_coding_charset): Remove vars that are set but not used.
5223
1be4d761
PE
5224 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5225 that is set but not used.
5226
47553fa8
PE
5227 * print.c (print_object): Remove var that is set but not used.
5228
1f7196bf 5229 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5230 The gnulib version avoids calling malloc in the usual case,
5231 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5232 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5233 * filelock.c (current_lock_owner): Likewise.
5234 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5235 * sysdep.c: Include allocator.h, careadlinkat.h.
5236 (emacs_no_realloc_allocator): New static constant.
5237 (emacs_readlink): New function.
fdb61804
PE
5238 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5239 ../lib/careadlinkat.h.
d1fdcab7 5240
f84c17c7
SM
52412011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5242
5243 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5244 first non-nil return value).
5245
ef3862ad
JD
52462011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5247
5248 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5249 if not defined (Bug#8403).
5250
376a7006
JB
52512011-04-02 Juanma Barranquero <lekktu@gmail.com>
5252
5253 * xdisp.c (display_count_lines): Remove parameter `start',
5254 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5255 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5256 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5257 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5258 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5259 and thereabouts. All callers changed.
5260 (get_per_char_metric): Remove parameter `f', unused since
5261 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5262
6ca3801d
JM
52632011-04-02 Jim Meyering <meyering@redhat.com>
5264
5265 do not dereference NULL upon failed strdup
5266 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5267 (ns_get_family): Likewise.
5268
d8e2b5ba
JB
52692011-04-02 Juanma Barranquero <lekktu@gmail.com>
5270
5271 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5272
8c74fcbd
JD
52732011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5274
5275 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5276 later (Bug#8403).
5277
7200d79c
SM
52782011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5279
03408648 5280 Add lexical binding.
7200d79c 5281
03408648
SM
5282 * window.c (Ftemp_output_buffer_show): New fun.
5283 (Fsave_window_excursion):
5284 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5285
5286 * lread.c (lisp_file_lexically_bound_p): New function.
5287 (Fload): Bind Qlexical_binding.
5288 (readevalloop): Remove `evalfun' arg.
5289 Bind Qinternal_interpreter_environment.
5290 (Feval_buffer): Bind Qlexical_binding.
5291 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5292 Mark as dynamic.
5293 (syms_of_lread): Declare `lexical-binding'.
5294
5295 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5296
5297 * keyboard.c (eval_dyn): New fun.
5298 (menu_item_eval_property): Use it.
ca105506
SM
5299
5300 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5301
03408648
SM
5302 * fns.c (concat, mapcar1): Accept byte-code-functions.
5303
5304 * eval.c (Fsetq): Handle lexical vars.
5305 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5306 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5307 (FletX, Flet): Obey lexical binding.
5308 (Fcommandp): Handle closures.
5309 (Feval): New `lexical' arg.
5310 (eval_sub): New function extracted from Feval. Use it almost
5311 everywhere where Feval was used. Look up vars in lexical env.
5312 Handle closures.
5313 (Ffunctionp): Move from subr.el.
5314 (Ffuncall): Handle closures.
5315 (apply_lambda): Remove `eval_flags'.
5316 (funcall_lambda): Handle closures and new byte-code-functions.
5317 (Fspecial_variable_p): New function.
5318 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5319 but without exporting it to Lisp.
23aba0ea 5320
23aba0ea 5321 * doc.c (Fdocumentation, store_function_docstring):
03408648 5322 * data.c (Finteractive_form): Handle closures.
23aba0ea 5323
03408648
SM
5324 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5325 interactive spec.
ba83908c 5326
04f2d78b
CB
5327 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5328 New byte-codes.
03408648
SM
5329 (exec_byte_code): New function extracted from Fbyte_code to handle new
5330 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5331
03408648 5332 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5333
03408648 5334 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5335
e2abce01
JB
53362011-03-31 Juanma Barranquero <lekktu@gmail.com>
5337
5338 * xdisp.c (redisplay_internal): Fix prototype.
5339
63696a73 53402011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5341
63696a73 5342 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5343 (try_scrolling): Use it when setting scroll_limit.
5344 Limit scrolling to 100 screen lines.
63696a73
EZ
5345 (redisplay_window): Even when falling back on "recentering",
5346 position point in the window according to scroll-conservatively,
5347 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5348
5349 (try_scrolling): When point is above the window, allow searching
5350 as far as scroll_max, or one screenful, to compute vertical
5351 distance from PT to the scroll margin position. This prevents
5352 try_scrolling from unnecessarily failing when
5353 scroll-conservatively is set to a value slightly larger than the
5354 window height. Clean up the case of PT below the margin at bottom
5355 of window: scroll_max can no longer be INT_MAX. When aggressive
5356 scrolling is in use, don't let point enter the opposite scroll
5357 margin as result of the scroll.
5358 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5359 threshold of 100 lines for never-recentering scrolling.
5360
e4cc2dfc
JB
53612011-03-31 Juanma Barranquero <lekktu@gmail.com>
5362
5363 * dispextern.h (move_it_by_lines):
5364 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5365 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5366 (message_log_check_duplicate): Remove parameters `prev_bol' and
5367 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5368 (redisplay_internal): Remove parameter `preserve_echo_area',
5369 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5370
5371 * indent.c (Fvertical_motion):
5372 * window.c (window_scroll_pixel_based, Frecenter):
5373 Don't pass `need_y_p' to `move_it_by_lines'.
5374
1c470562
SM
53752011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5376
44f230aa
SM
5377 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5378 steal a few bits to be more compact.
5379 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5380 Remove unneeded casts.
5381
1c470562
SM
5382 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5383
888adce9
ZK
53842011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5385
5386 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5387 binding" message (bug#7967).
5388
f838ed7b
PE
53892011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5390
77861b95
PE
5391 Fix more problems found by GCC 4.6.0's static checks.
5392
de6dbc14
PE
5393 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5394 Remove unused local var.
5395
f838ed7b
PE
5396 * editfns.c (Fmessage_box): Remove unused local var.
5397
792c7b2b
PE
5398 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5399 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5400 Omit unused local vars.
c499e557 5401 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5402 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5403 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5404 Omit unused local var.
5405
ba0165e1
PE
5406 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5407 Don't assume string length fits in int.
32ad8845 5408 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5409 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5410
3c59b4c9
PE
5411 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5412 instead of alloca (Bug#8344).
5413
a3eed478 5414 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5415 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5416
eb4d412d
PE
5417 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5418
1658b401
PE
5419 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5420 concerns.
5421
5422 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5423
5424 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5425
9a2c6e05
PE
5426 * keyboard.c (syms_of_keyboard): Use the same style as later
5427 in this function when indexing through an array. This also
5428 works around GCC bug 48267.
5429
03d0a109
PE
5430 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5431
44f730c8
PE
5432 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5433
fe75f926
PE
5434 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5435 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5436
ffa8c828
PE
5437 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5438 This avoids undefined behavior on integer overflow, and is a bit
5439 more convenient anyway since it is compared to a size_t variable.
5440
c5101a77
PE
5441 Variadic C functions now count arguments with size_t, not int.
5442 This avoids an unnecessary limitation on 64-bit machines, which
5443 caused (substring ...) to crash on large vectors (Bug#8344).
5444 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5445 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5446 All variadic functions and their callers changed accordingly.
c5101a77
PE
5447 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5448 * data.c (arith_driver, float_arith_driver): Likewise.
5449 * editfns.c (general_insert_function): Likewise.
5450 * eval.c (struct backtrace.nargs, interactive_p)
5451 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5452 (funcall_lambda, mark_backtrace): Likewise.
5453 * fns.c (concat): Likewise.
5454 * frame.c (x_set_frame_parameters): Likewise.
5455 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5456 0 if not found, not -1. All callers changed.
5457
dd3f25f7
PE
5458 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5459 (stack_copy_size): Now size_t, not int.
5460 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5461
461c2ab9
JB
54622011-03-28 Juanma Barranquero <lekktu@gmail.com>
5463
5464 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5465 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5466 All callers changed.
5467
5468 * lisp.h (multibyte_char_to_unibyte):
5469 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5470 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5471 * character.h (CHAR_TO_BYTE8):
5472 * cmds.c (internal_self_insert):
5473 * editfns.c (general_insert_function):
5474 * keymap.c (push_key_description):
5475 * search.c (Freplace_match):
5476 * xdisp.c (message_dolog, set_message_1): All callers changed.
5477
f6d62986
SM
54782011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5479
5480 * keyboard.c (safe_run_hook_funcall): New function.
5481 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5482 don't set the hook to nil, but remove the offending function instead.
5483 (Qcommand_hook_internal): Remove, unused.
5484 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5485 Vcommand_hook_internal.
5486
5487 * eval.c (enum run_hooks_condition): Remove.
5488 (funcall_nil, funcall_not): New functions.
5489 (run_hook_with_args): Call each function through a `funcall' argument.
5490 Remove `cond' argument, now redundant.
5491 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5492 (Frun_hook_with_args_until_failure): Adjust accordingly.
5493 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5494
1db5b1ad
JB
54952011-03-28 Juanma Barranquero <lekktu@gmail.com>
5496
5497 * dispextern.h (string_buffer_position): Remove declaration.
5498
5499 * print.c (strout): Remove parameter `multibyte', unused since
5500 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5501
5502 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5503 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5504 All callers changed.
5505
5506 * w32.c (_wsa_errlist): Use braces for struct initializers.
5507
5508 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5509 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5510 All callers changed.
5511 (string_buffer_position): Likewise. Also, make static (it's never
5512 used outside xdisp.c).
5513 (cursor_row_p): Remove parameter `w', unused since
5514 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5515 (decode_mode_spec): Remove parameter `precision', introduced during
5516 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5517 All callers changed.
5518
5ffb62aa
JD
55192011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5520
5521 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5522
461c2ab9 55232011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5524
5525 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5526 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5527 (ns_update_auto_hide_menu_bar): New functions.
5528 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5529 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5530 ns_constrain_all_frames.
5531 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5532 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5533
5c380ffb
JD
55342011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5535
5536 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5537
9af30bdf
GM
55382011-03-27 Glenn Morris <rgm@gnu.org>
5539
5540 * syssignal.h: Replace RETSIGTYPE with void.
5541 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5542 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5543 Replace SIGTYPE with void everywhere.
5544 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5545 * s/template.h (SIGTYPE): Remove commented out definition.
5546
e2abce01
JB
55472011-03-26 Eli Zaretskii <eliz@gnu.org>
5548
5549 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5550 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5551
f868cd8a
JB
55522011-03-26 Juanma Barranquero <lekktu@gmail.com>
5553
59eb0929
JB
5554 * w32.c (read_unc_volume): Use parameter `henum', instead of
5555 global variable `wget_enum_handle'.
5556
5557 * keymap.c (describe_vector): Remove parameters `indices' and
5558 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5559 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5560
f868cd8a
JB
5561 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5562
5563 * keyboard.c (timer_check): Remove parameter `do_it_now',
5564 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5565 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5566 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5567
5568 * keyboard.c (read_char):
5569 * w32menu.c (w32_menu_display_help):
5570 * xmenu.c (show_help_event, menu_help_callback):
5571 Adjust calls to `show_help_echo'.
5572
5573 * gtkutil.c (xg_maybe_add_timer):
5574 * keyboard.c (readable_events):
5575 * process.c (wait_reading_process_output):
5576 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5577
5578 * insdel.c (adjust_markers_gap_motion):
5579 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5580 (gap_left, gap_right): Don't call it.
5581
2ecf6fdb
CY
55822011-03-25 Chong Yidong <cyd@stupidchicken.com>
5583
5584 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5585 incurred during fontification.
5586
6b1f9ba4
JB
55872011-03-25 Juanma Barranquero <lekktu@gmail.com>
5588
5589 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5590 (DEFVAR_PER_BUFFER): Don't pass it.
5591
5592 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5593 (scrolling_window): Don't pass it.
5594
0f4a96b5
JB
55952011-03-25 Juanma Barranquero <lekktu@gmail.com>
5596
5597 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5598
5599 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5600 and `suffix'.
5601 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5602 of variables specific to SELinux and computation of `encoded_absname'.
5603
5604 * image.c (XPutPixel): Remove unused variable `height'.
5605
5606 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5607
5608 * unexw32.c (get_section_info): Remove unused variable `section'.
5609
5610 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5611 (system_process_attributes): Remove unused variable `sess'.
5612 (sys_read): Remove unused variable `err'.
5613
5614 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5615 (w32_wnd_proc): Remove unused variable `isdead'.
5616 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5617 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5618 (x_create_tip_frame): Remove unused variable `tem'.
5619
5620 * w32inevt.c (w32_console_read_socket):
5621 Remove unused variable `no_events'.
5622
5623 * w32term.c (x_draw_composite_glyph_string_foreground):
5624 Remove unused variable `width'.
5625
1149507c
JB
56262011-03-24 Juanma Barranquero <lekktu@gmail.com>
5627
5628 * w32term.c (x_set_glyph_string_clipping):
5629 Don't pass uninitialized region to CombineRgn.
5630
9c88f339
JB
56312011-03-23 Juanma Barranquero <lekktu@gmail.com>
5632
5633 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5634 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5635 (Fx_close_connection): Remove unused variable `i'.
5636
5637 * w32font.c (w32font_draw): Return number of glyphs.
5638 (w32font_open_internal): Remove unused variable `i'.
5639 (w32font_driver): Add missing initializer.
5640
5641 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5642 (fill_in_menu): Remove unused variable `items_added'.
5643
5644 * w32term.c (last_mouse_press_frame): Remove static global variable.
5645 (w32_clip_to_row): Remove unused variable `f'.
5646 (x_delete_terminal): Remove unused variable `i'.
5647
5648 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5649 (NOTHING): Remove unused static global variable.
5650 (uniscribe_check_otf): Remove unused variable `table'.
5651 (uniscribe_font_driver): Add missing initializers.
5652
dee091a3
JD
56532011-03-23 Julien Danjou <julien@danjou.info>
5654
5655 * term.c (Fsuspend_tty, Fresume_tty):
5656 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5657 * window.c (temp_output_buffer_show):
5658 * insdel.c (signal_before_change):
5659 * frame.c (Fhandle_switch_frame):
5660 * fileio.c (Fdo_auto_save):
5661 * emacs.c (Fkill_emacs):
5662 * editfns.c (save_excursion_restore):
5663 * cmds.c (internal_self_insert):
5664 * callint.c (Fcall_interactively):
5665 * buffer.c (Fkill_all_local_variables):
5666 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5667 Use Frun_hooks.
0f4a96b5 5668 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5669 unconditionnaly since it does the check itself.
5670
2c520ab5 56712011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5672
c9c49752
PE
5673 Fix more problems found by GCC 4.5.2's static checks.
5674
8abc3f12
PE
5675 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5676 the first time through the loop, since we know p0 < p1 then.
5677 This also avoids a gcc -Wstrict-overflow warning.
5678
a2d26660
PE
5679 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5680 leading to a memory leak, possible in functions like
5681 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5682 of objects (Bug#8318).
a2d26660 5683
916c72e9
PE
5684 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5685 that could (at least in theory) be that large.
5686
19ab8a18
PE
5687 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5688 This is less likely to overflow, and avoids undefined behavior if
5689 overflow does occur. All callers changed. Use strtoul to scan
5690 for the unsigned long integer.
b7cbbd6f
PE
5691 (pint2hrstr): Simplify and tune code slightly.
5692 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5693
f0641eff
PE
5694 * scroll.c (do_scrolling): Work around GCC bug 48228.
5695 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5696
7f650bb9
PE
5697 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5698 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5699 (validate_x_resource_name): Simplify count usage.
5700 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5701
37dd57d1
PE
5702 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5703 fail (Bug#8306).
81e56e61 5704
699979fc 5705 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5706
401bf9b4
PE
5707 * process.c (Fmake_network_process): Use socklen_t, not int,
5708 where POSIX says socklen_t is required in portable programs.
5709 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5710 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5711 (Fmake_network_process, server_accept_connection):
5712 (wait_reading_process_output, read_process_output):
5713 Likewise.
5714
b93aacde
PE
5715 * process.c: Rename or move locals to avoid shadowing.
5716 (list_processes_1, Fmake_network_process):
5717 (read_process_output_error_handler, exec_sentinel_error_handler):
5718 Rename or move locals.
4dc343ee 5719 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5720 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5721 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5722 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5723 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5724
af8a867c 5725 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5726 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5727 Include tparam.h instead, since it declares them.
af8a867c
PE
5728 * cm.h (PC): Remove extern decl; tparam.h now does this.
5729 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5730 * terminfo.c: Include tparam.h, to check interfaces.
5731 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5732 (tparam): Adjust signature to match interface in tparam.h;
5733 this removes some undefined behavior. Check that outstring and len
5734 are zero, which they always are with Emacs.
5735 * tparam.h (PC, BC, UP): New extern decls.
5736
0248044d 5737 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5738 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5739
8ff096c1 5740 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5741 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5742 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5743 (ftfont_list): Remove unused local.
49eaafba
PE
5744 (get_adstyle_property, ftfont_pattern_entity):
5745 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5746 Rename locals to avoid shadowing.
8ff096c1 5747
e2be39f6
PE
5748 * xfont.c (xfont_list_family): Mark var as initialized.
5749
c9735e30
PE
5750 * xml.c (make_dom): Now static.
5751
8f5201ae
PE
5752 * composite.c (composition_compute_stop_pos): Rename local to
5753 avoid shadowing.
b246f932
PE
5754 (composition_reseat_it): Remove unused locals.
5755 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5756 (composition_update_it): Mark var as initialized.
11b61122
PE
5757 (find_automatic_composition): Mark vars as initialized,
5758 with a FIXME (Bug#8290).
8f5201ae 5759
760fbc2c
PE
5760 character.h: Rename locals to avoid shadowing.
5761 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5762 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5763 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5764 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5765 to avoid shadowing.
5766
ff08eb85
PE
5767 * textprop.c (property_change_between_p): Remove; unused.
5768
fc7bf025
PE
5769 * intervals.c (interval_start_pos): Now static.
5770
235d7abc
PE
5771 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5772
44f230aa
SM
5773 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5774 Rename locals to avoid shadowing.
3e7d6594 5775
50060332
PE
5776 * sound.c (wav_play, au_play, Fplay_sound_internal):
5777 Fix pointer signedness.
d01f234b 5778 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5779 (wav_play): Initialize a variable to 0, to prevent undefined
5780 behavior (Bug#8278).
50060332 5781
c4fc4e30
PE
5782 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5783
918436ed
PE
5784 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5785
c939f91b
PE
5786 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5787 clobbering (Bug#8298).
b9c7f648
PE
5788 * sysdep.c (sys_subshell): Likewise.
5789 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5790
6bd8c144
PE
5791 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5792 This should get cleaned up, so that child_setup has the
5793 same signature on all platforms.
5794
7710357c 5795 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5796 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5797
c59da222
CY
57982011-03-22 Chong Yidong <cyd@stupidchicken.com>
5799
5800 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5801 not to be necessary, and produces flickering.
5802
66b87493
GM
58032011-03-20 Glenn Morris <rgm@gnu.org>
5804
5805 * config.in: Remove file.
5806
45b6f6d5
JB
58072011-03-20 Juanma Barranquero <lekktu@gmail.com>
5808
5809 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5810 are now in src/globals.h.
5811 (syms_of_minibuf): Remove spurious & from previous change.
5812
3ec03f7e
LL
58132011-03-20 Leo <sdl.web@gmail.com>
5814
5815 * minibuf.c (completing-read-function): New variable.
5816 (completing-read-default): Rename from completing-read.
5817 (completing-read): Call completing-read-function.
5818
b14e3e21
CY
58192011-03-19 Juanma Barranquero <lekktu@gmail.com>
5820
5821 * xfaces.c (Fx_load_color_file):
5822 Read color file from absolute filename (bug#8250).
5823
f2b726e6
JB
58242011-03-19 Juanma Barranquero <lekktu@gmail.com>
5825
5826 * makefile.w32-in: Update dependencies.
5827
09f6ff02
EZ
58282011-03-17 Eli Zaretskii <eliz@gnu.org>
5829
5830 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5831
29a6015a
PE
58322011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5833
a3a6c54e
PE
5834 Fix more problems found by GCC 4.5.2's static checks.
5835
b766f867
PE
5836 * process.c (make_serial_process_unwind, send_process_trap):
5837 (sigchld_handler): Now static.
5838
be02381c
PE
5839 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5840 That way, the code declares only the vars that it needs.
5841 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5842 * s/cygwin.h (PTY_ITERATION): Likewise.
5843 * s/darwin.h (PTY_ITERATION): Likewise.
5844 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5845
57048744
PE
5846 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5847 * process.c (allocate_pty): Don't declare stb unless it's needed.
5848
7914961c 5849 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5850 (CONSTANTLIM): Remove; unused.
5851 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5852 Define only if needed.
7914961c 5853
b3967b18
PE
5854 * unexelf.c (unexec): Name an expression,
5855 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5856 Use a different way to cause a compilation error if anyone uses
5857 n rather than nn, a way that does not involve shadowing.
73366a00 5858 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5859
29a6015a
PE
5860 * deps.mk (unexalpha.o): Remove; unused.
5861
43cfc33e 5862 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5863 * unexec.h: New file.
ce701a33
PE
5864 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5865 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5866 Depend on unexec.h.
5867 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5868 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5869 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5870 Change as necessary to match prototype in unexec.h.
ce701a33 5871
01f44d5a
PE
5872 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5873 shadowing.
4f63c6bb 5874 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5875
a6670b0b
PE
5876 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5877 Rename locals to avoid shadowing.
5878
cef2010d 5879 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5880 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5881
d4d7173a
PE
5882 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5883
f08b802a
PE
5884 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5885 warning when compiling print.c.
5886
3ddb0639
PE
5887 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5888 instead of using an uninitialized var.
5ad03b97 5889 (font_sort_entities): Mark var as initialized.
3ddb0639 5890
170a2692
PE
5891 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5892
e663c700
PE
5893 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5894 pointers to constants.
89bc529a 5895 (font_parse_fcname): Remove unused vars.
7b81e2d0 5896 (font_delete_unmatched): Now static.
ea838e10 5897 (font_get_spec): Remove; unused.
13a547c6
PE
5898 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5899 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5900 Rename or move locals to avoid shadowing.
e663c700 5901
2a80c887 5902 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5903 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5904
1384fa33 5905 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5906 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5907
8b2c52e9
PE
5908 * alloc.c (mark_backtrace): Move decl from here ...
5909 * lisp.h: ... to here, so that it can be checked.
5910
475545b5 5911 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5912 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5913 (lisp_indirect_variable): Name an expression,
5914 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5915 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5916
b1349114 5917 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5918 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5919 Use const pointer when appropriate.
b1349114 5920
a2928364
PE
5921 * lisp.h (get_system_name, get_operating_system_release):
5922 Move decls here, to check interfaces.
5923 * process.c (get_operating_system_release): Move decl to lisp.h.
5924 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5925 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5926 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5927 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5928 (Fformat_time_string, Fencode_time, Finsert_char):
5929 (Ftranslate_region_internal, Fformat):
5930 Rename or remove local vars to avoid shadowing.
9710023e 5931 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5932
a415e694
PE
5933 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5934 avoid shadowing.
5935
8ef4622d
PE
5936 * lisp.h (eassert): Check that the argument compiles, even if
5937 ENABLE_CHECKING is not defined.
5938
946f9a5b
PE
5939 * data.c (Findirect_variable): Name an expression, to avoid
5940 gcc -Wbad-function-cast warning.
112396d6 5941 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5942 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5943 (Fmake_variable_buffer_local, Fmake_local_variable):
5944 Mark variables as initialized.
52746918 5945 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5946
e5aab7e7 5947 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5948 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5949 Rename locals to avoid shadowing.
dff45157
PE
5950 (mark_stack): Move local variables into the #ifdef region where
5951 they're used.
7bc26fdb
PE
5952 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5953 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5954 needed otherwise.
5955 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5956 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5957 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5958
e5aab7e7
PE
5959 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5960 avoids undefined behavior in theory.
5961
4da60324
PE
5962 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5963
88043301
PE
5964 Use functions, not macros, for up- and down-casing (Bug#8254).
5965 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5966 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5967 to use the following functions instead of these macros.
5968 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5969 EMACS_INT, since callers assume the returned value fits in int.
5970 (upcase1): Likewise, for UPCASE_TABLE.
5971 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5972 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5973 the race-condition problem in the old DOWNCASE.
88043301 5974
19ed5445
PE
5975 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5976 Rename locals to avoid shadowing.
5977 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5978 (regex_compile, re_search_2, re_match_2_internal):
5979 Remove unused local vars.
952db0d7
PE
5980 (FREE_VAR): Rewrite so as not to use empty "else",
5981 which gcc can warn about.
da053e48 5982 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5983 (RETALLOC_IF): Define only if needed.
5984 (WORDCHAR_P): Likewise. This one is never needed, but is used
5985 only in a comment talking about a compiler bug, so put inside
5986 the #if 0 of that comment.
5987 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5988 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5989 Remove; unused.
19ed5445 5990
1f3561e4 5991 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5992 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5993 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5994
ded6f8f7
PE
5995 * search.c (simple_search): Remove unused var.
5996
dbd37a95
PE
5997 * dired.c (compile_pattern): Move decl from here ...
5998 * lisp.h: ... to here, so that it can be checked.
5999 (struct re_registers): New forward decl.
6000
7e47afad
PE
6001 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6002
85f24f61
PE
6003 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6004 All uses changed.
6005 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6006 Rename locals to avoid shadowing.
5671df8f 6007 (Fvertical_motion): Mark locals as initialized.
85f24f61 6008
181aa2be 6009 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6010 (casify_region): Mark local as initialized.
181aa2be 6011
930d429c
PE
6012 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6013
7082eac6
PE
6014 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6015 New macros, so that the caller can use some names other than
6016 gcpro1, gcpro2, etc.
6017 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6018 of the new macros.
6019 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6020 argument, for consistency with GCPRO2_VAR, etc: it is now the
6021 prefix of the variable, not the variable itself. All uses
6022 changed.
38b2c076
PE
6023 * dired.c (directory_files_internal, file_name_completion):
6024 Rename locals to avoid shadowing.
6025
15206ed9
PE
6026 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6027 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6028 dired.c's scmp function, had undefined behavior.
6029 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6030 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6031 * buffer.h: ... to here, because these macros use current_buffer,
6032 and the new implementation with inline functions needs to have
6033 current_buffer in scope now, rather than later when the macros
6034 are used.
6035 (downcase, upcase1): New static inline functions.
6036 (DOWNCASE, UPCASE1): Reimplement using these functions.
6037 This avoids undefined behavior in expressions like
6038 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6039 from race conditions in accessing the global variables
6040 case_temp1 and case_temp2.
6041 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6042 * lisp.h (case_temp1, case_temp2): Remove their decls.
6043 * character.h (ASCII_CHAR_P): Move from here ...
6044 * lisp.h: ... to here, so that the inline functions mentioned
6045 above can use them.
6046
4a6bea26
PE
6047 * dired.c (directory_files_internal_unwind): Now static.
6048
f14b7e14
PE
6049 * fileio.c (file_name_as_directory, directory_file_name):
6050 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6051 Now static.
2893f146
PE
6052 (file_name_as_directory): Use const pointers when appropriate.
6053 (Fexpand_file_name): Likewise. In particular, newdir might
6054 point at constant storage, so make it a const pointer.
fd4ead52 6055 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6056 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6057 signedness issues.
f839df0c
PE
6058 (Fset_file_times, Finsert_file_contents, auto_save_error):
6059 Rename locals to avoid shadowing.
f14b7e14 6060
5716756e 6061 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6062 (Ftry_completion, Fall_completions): Rename or remove locals
6063 to avoid shadowing.
5716756e 6064
b4c3046a
PE
6065 * marker.c (bytepos_to_charpos): Remove; unused.
6066
b45db522
PE
6067 * lisp.h (verify_bytepos, count_markers): New decls,
6068 so that gcc does not warn that these functions aren't declared.
6069
85876d07
PE
6070 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6071 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6072 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6073 (copy_text): Remove unused local var.
85876d07 6074
03d78a21 6075 * filelock.c (within_one_second): Now static.
b3dd38ab 6076 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6077
5df8f01b
PE
6078 * buffer.c (fix_overlays_before): Mark locals as initialized.
6079 (fix_start_end_in_overlays): Likewise. This function should be
6080 simplified by using pointers-to-pointers, but that's a different
6081 matter.
b1d876f1 6082 (switch_to_buffer_1): Now static.
8f54f30a
PE
6083 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6084 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6085
a70072c9 6086 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6087 Fix pointer signedness issue.
edced198
PE
6088 (sys_subshell): Mark local as volatile if checking for lint,
6089 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6090 (MAXPATHLEN): Define only if needed.
a70072c9 6091
a0977c44
PE
6092 * process.c (serial_open, serial_configure): Move decls from here ...
6093 * systty.h: ... to here, so that they can be checked.
6094
a884fdcc
PE
6095 * fns.c (get_random, seed_random): Move extern decls from here ...
6096 * lisp.h: ... to here, so that they can be checked.
6097
604efe86 6098 * sysdep.c (reset_io): Now static.
b8950c94 6099 (wait_for_termination_signal): Remove; unused.
604efe86 6100
38fc62d9
PE
6101 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6102 (copy_keymap_item, append_key, push_text_char_description):
6103 Now static.
1004a21a 6104 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6105 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6106 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6107 (describe_map_tree):
6108 Rename locals to avoid shadowing.
38fc62d9 6109
2f2650da
PE
6110 * keyboard.c: Declare functions static if they are not used elsewhere.
6111 (echo_char, echo_dash, cmd_error, top_level_2):
6112 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6113 (read_char, kbd_buffer_get_event, make_lispy_position):
6114 (make_lispy_event, make_lispy_movement, apply_modifiers):
6115 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6116 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6117 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6118 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6119 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6120
a053e86c 6121 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6122 (mark_kboards): Move decl here ...
6123 * alloc.c (mark_kboards): ... from here.
a053e86c 6124
4752793e
PE
6125 * lisp.h (force_auto_save_soon): New decl.
6126
74f10ca7 6127 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6128 (DEFINE_DUMMY_FUNCTION): New macro.
6129 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6130 Use it.
c03cd23f
PE
6131 (main): Add casts to avoid warnings
6132 if GCC considers string literals to be constants.
74f10ca7 6133
022e70d4
PE
6134 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6135
59d6fe83
PE
6136 * dbusbind.c: Pointer signedness fixes.
6137 (xd_signature, xd_append_arg, xd_initialize):
6138 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6139 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6140 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6141 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6142
78320123
PE
6143 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6144 if GCC considers string literals to be constants.
49cebcca 6145 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6146
35ac2a97
SM
61472011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6148
fb103ca9
SM
6149 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6150 (print_preprocess, print_object): New macro to fix last change.
6151
35ac2a97
SM
6152 * print.c (print_preprocess): Don't forget font objects.
6153
62973b41
JB
61542011-03-16 Juanma Barranquero <lekktu@gmail.com>
6155
6156 * emacs.c (USAGE3): Doc fixes.
6157
0e48bb22
AS
61582011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6159
6160 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6161 structure.
6162
7684e57b
JB
61632011-03-14 Juanma Barranquero <lekktu@gmail.com>
6164
6165 * lisp.h (VWindow_system, Qfile_name_history):
6166 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6167 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6168 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6169
6170 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6171 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6172
6173 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6174 * w32console.c (detect_input_pending, read_input_pending)
6175 (encode_terminal_code):
6176 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6177 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6178 (w32_system_caret_y, Qfile_name_history):
6179 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6180 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6181 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6182 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6183 * w32proc.c (Qlocal, report_file_error):
6184 * w32term.c (Vwindow_system, updating_frame):
6185 * w32uniscribe.c (initialized, uniscribe_font_driver):
6186 Remove unneeded extern declarations.
6187
2aa46d6c
CY
61882011-03-14 Chong Yidong <cyd@stupidchicken.com>
6189
c96bbc66 6190 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6191
cffc6f3b
CY
61922011-03-13 Chong Yidong <cyd@stupidchicken.com>
6193
6194 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6195 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6196 These macros can no longer be used for assignment.
6197
44f230aa
SM
6198 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6199 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6200 (record_buffer_markers, fetch_buffer_markers): New functions for
6201 recording and fetching special buffer markers.
6202 (set_buffer_internal_1, set_buffer_temp): Use them.
6203
6204 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6205
6206 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6207
6208 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6209 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6210
6211 * xdisp.c (hscroll_window_tree):
6212 (reconsider_clip_changes): Use PT instead of BUF_PT.
6213
d251f04b
EZ
62142011-03-13 Eli Zaretskii <eliz@gnu.org>
6215
6216 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6217 $(EMACS_ROOT)/lib/intprops.h.
6218
f0c77cd1
PE
62192011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6220
3eca4629
PE
6221 Fix more problems found by GCC 4.5.2's static checks.
6222
7c86ee98
PE
6223 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6224 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6225 (xg_free_frame_widgets): Make it clear that a local variable is
6226 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6227 (gdk_window_get_screen): Make it clear that this macro is needed
6228 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6229 (int_gtk_range_get_value): New function, which avoids a diagnostic
6230 from gcc -Wbad-function-cast.
6231 (xg_set_toolkit_scroll_bar_thumb): Use it.
6232 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6233 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6234 (get_utf8_string, xg_get_file_with_chooser):
6235 Rename locals to avoid shadowing.
6236 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6237
41729b81
PE
6238 * xgselect.c (xg_select): Remove unused var.
6239
f0c77cd1
PE
6240 * image.c (four_corners_best): Mark locals as initialized.
6241 (gif_load): Initialize transparent_p to zero (Bug#8238).
6242 Mark another local as initialized.
ec6cf4c6 6243 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6244
ce0ad53d 6245 * image.c (clear_image_cache): Now static.
d5d5a617 6246 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6247 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6248 (x_edge_detection): Remove unnecessary cast that
6249 gcc -Wbad-function-cast diagnoses.
2037898d 6250 (gif_load): Fix pointer signedness.
6ae141d6
PE
6251 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6252 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6253
33383987 62542011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6255
d32df629
PE
6256 Improve quality of tests for time stamp overflow.
6257 For example, without this patch (encode-time 0 0 0 1 1
6258 1152921504606846976) returns the obviously-bogus value (-948597
6259 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6260 reports time overflow. See
6261 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6262 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6263 * editfns.c: Include limits.h and intprops.h.
6264 (TIME_T_MIN, TIME_T_MAX): New macros.
6265 (time_overflow): Move earlier, to before first use.
6266 (hi_time, lo_time): New functions, for an accurate test for
6267 out-of-range times.
6268 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6269 (Fget_internal_run_time): Don't assume time_t fits in int.
6270 (make_time): Use list2 instead of Fcons twice.
6271 (Fdecode_time): More accurate test for out-of-range times.
6272 (check_tm_member): New function.
6273 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6274 (lisp_time_argument): Don't rely on undefined left-shift and
6275 right-shift behavior when checking for time stamp overflow.
8be6f318 6276
fe31d94c
PE
6277 * editfns.c (time_overflow): New function, refactoring common code.
6278 (Fformat_time_string, Fdecode_time, Fencode_time):
6279 (Fcurrent_time_string): Use it.
6280
8be6f318
PE
6281 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6282 * dired.c (make_time): Move to ...
6283 * editfns.c (make_time): ... here.
6284 * systime.h: Note the move.
6285
09d9db2c 62862011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6287
126bc0dc
YM
6288 * fringe.c (update_window_fringes): Remove unused variables.
6289
c47cbdfd
YM
6290 * unexmacosx.c (copy_data_segment): Also copy __got section.
6291 (Bug#8223)
6292
7ac80be9
EZ
62932011-03-12 Eli Zaretskii <eliz@gnu.org>
6294
c96bbc66 6295 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6296 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6297 Constify `char *' arguments and their references according to
6298 prototypes in tparam.h.
6299
ecb0f94d 6300 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6301
7ac80be9
EZ
6302 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6303 Adapt all references accordingly.
6304
6305 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6306
ef1fd07e
TT
63072011-03-11 Tom Tromey <tromey@redhat.com>
6308
6309 * buffer.c (syms_of_buffer): Remove obsolete comment.
6310
7ef4b50c
EZ
63112011-03-11 Eli Zaretskii <eliz@gnu.org>
6312
6313 * termhooks.h (encode_terminal_code): Declare prototype.
6314
6315 * msdos.c (encode_terminal_code): Don't declare prototype.
6316
6317 * term.c (encode_terminal_code): Now external again, used by
6318 w32console.c and msdos.c.
6319
44f230aa
SM
6320 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6321 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6322
4b1ec863 63232011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6324
1714f52b 6325 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6326
4b1ec863
PE
6327 * fringe.c (update_window_fringes): Mark locals as initialized
6328 (Bug#8227).
6329 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6330
524c7aa6
PE
6331 * alloc.c (mark_fringe_data): Move decl from here ...
6332 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6333 to check its interface.
6334 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6335
a5c0af81 6336 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6337 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6338 (fontset_font): Mark local as initialized.
a9a06e0b 6339 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6340
b4716021
PE
6341 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6342
811e9bac 6343 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6344 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6345 (x_own_selection, Fx_disown_selection_internal): Rename locals
6346 to avoid shadowing.
6347 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6348
7e3ab302
PE
6349 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6350 so that the caller can use some name other than gcpro1.
6351 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6352 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6353 (Fx_backspace_delete_keys_p):
6354 Use them to avoid shadowing, and rename vars to avoid shadowing.
6355 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6356 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6357 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6358 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6359 Remove unused locals.
7e3ab302
PE
6360 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6361 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6362 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6363 macros.
f78faa98 6364
e2b13473
PE
6365 * xterm.h (x_mouse_leave): New decl.
6366
77f23912
PE
6367 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6368 Remove unused functions.
cdf4ba58
PE
6369 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6370 (x_calc_absolute_position): Now static.
7411c686 6371 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6372 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6373 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6374 unless they are used.
38d0b34a
PE
6375 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6376 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6377 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6378 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6379 (x_error_catcher, x_connection_closed, x_error_handler):
6380 (x_error_quitter, xembed_send_message, x_iconify_frame):
6381 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6382 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6383 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6384
44f230aa
SM
6385 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6386 Rename or move locals to avoid shadowing.
6b463e58 6387 (tty_defined_color, merge_face_heights): Now static.
5967d051 6388 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6389 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6390 does not deduce is never used uninitialized.
73719eba
PE
6391 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6392 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6393
426994c3 6394 * terminal.c (store_terminal_param): Now static.
5489860b 6395
032f1620 6396 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6397 (set_frame_menubar): Remove unused local.
d4323972 6398 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6399 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6400 since they might point to immutable storage.
281585b0
PE
6401 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6402 since it's unused otherwise.
032f1620 6403
367c19e5 6404 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6405 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6406 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6407 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6408 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6409 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6410 does not deduce are never used uninitialized.
70739cbe 6411
07b48fa9
PE
6412 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6413
8868a238 6414 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6415 * window.c (window_loop, size_window):
6416 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6417
7e5cf297 6418 * window.c (display_buffer): Now static.
d6550a9f
PE
6419 (size_window): Mark variables that gcc -Wuninitialized
6420 does not deduce are never used uninitialized.
a586633d
PE
6421 * window.h (check_all_windows): New decl, to forestall
6422 gcc -Wmissing-prototypes diagnostic.
5b555da1 6423 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6424
f6095868
PE
6425 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6426 shadowing.
6427 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6428 Include <limits.h>.
6429 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6430 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6431 (load_charset_map): Mark variables that gcc -Wuninitialized
6432 does not deduce are never used uninitialized.
53df7c11 6433 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6434
f38b440c
PE
6435 * coding.c (coding_set_source, coding_set_destination):
6436 Use "else { /* comment */ }" rather than "else /* comment */;"
6437 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6438 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6439 a block, when the outer 'i' will do.
6440 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6441 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6442 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6443 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6444 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6445 Rename locals to avoid shadowing.
6446 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6447 * coding.c (emacs_mule_char, encode_invocation_designation):
6448 Now static, since they're not used elsewhere.
413bb2db 6449 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6450 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6451 (decode_coding_emacs_mule): Mark variables that gcc
6452 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6453 (detect_coding_iso_2022): Initialize a local variable that might
6454 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6455 this initialization is needed. (Bug#8211)
5f58e762
PE
6456 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6457 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6458 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6459 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6460 Remove unused macros.
f38b440c 6461
232b38b9 6462 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6463 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6464 * character.c (string_count_byte8): Likewise.
232b38b9 6465
fb90da1b
PE
6466 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6467 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6468
fb93dbc2
PE
6469 * chartab.c (copy_sub_char_table): Now static, since it's not used
6470 elsewhere.
5c156ace
PE
6471 (sub_char_table_ref_and_range, char_table_ref_and_range):
6472 Rename locals to avoid shadowing.
bbcd0949 6473 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6474
7d3b3862 6475 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6476 (BIDI_BOB): Remove unused macro.
7d3b3862 6477
6be7d3da
PE
6478 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6479 deduce are never used uninitialized.
c2ed9c8b 6480 * term.c (encode_terminal_code): Likewise.
6be7d3da 6481
75f8807f 6482 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6483
50938595
PE
6484 * tparam.h: New file.
6485 * term.c, tparam.h: Include it.
6486 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6487 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6488 Move these decls to tparam.h, and make them agree with what
6489 is actually in tparam.c. The previous trick of using incompatible
6490 decls in different modules does not conform to the C standard.
6491 All callers of tparam changed to use tparam's actual API.
6492 * tparam.c (tparam1, tparam, tgoto):
6493 Use const pointers where appropriate.
6494
fbceeba2
PE
6495 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6496 * cm.h (struct cm): Likewise.
6497 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6498 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6499 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6500 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6501 (turn_on_face, init_tty): Likewise.
6502 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6503
7f3f1250
PE
6504 * term.c (term_mouse_position): Rename local to avoid shadowing.
6505
e6ca6543
PE
6506 * alloc.c (mark_ttys): Move decl from here ...
6507 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6508
c40f8d15
AS
65092011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6510
6511 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6512
cfe0661d
JB
65132011-03-09 Juanma Barranquero <lekktu@gmail.com>
6514
6515 * search.c (compile_pattern_1): Remove argument regp, unused since
6516 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6517 (compile_pattern): Don't pass it.
6518
0afb4571
J
65192011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6520
6521 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6522 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6523 for ! HAVE_GTK3.
6524 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6525
6526 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6527
6528 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6529 gdk_window_get_screen, gdk_window_get_geometry,
6530 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6531 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6532 (xg_get_pixbuf_from_pixmap): New function.
6533 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6534 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6535 Call xg_get_pixbuf_from_pixmap instead of
6536 gdk_pixbuf_get_from_drawable.
6537 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6538 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6539 (xg_check_special_colors): Use GtkStyleContext and its functions
6540 for HAVE_GTK3.
6541 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6542 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6543 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6544 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6545 Call gtk_widget_get_preferred_size.
0afb4571
J
6546 (xg_frame_resized): gdk_window_get_geometry only takes 5
6547 parameters.
44f230aa
SM
6548 (xg_win_to_widget, xg_event_is_for_menubar):
6549 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6550 (xg_set_widget_bg): New function.
6551 (delete_cb): New function.
895009e1 6552 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6553 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6554 (xg_set_background_color): Call xg_set_widget_bg.
6555 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6556 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6557 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6558 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6559 if ! HAVE_GTK3.
6560 (update_frame_tool_bar): Call gtk_widget_hide.
6561 (xg_initialize): Use GDK_KEY_g.
6562
6563 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6564 if ! HAVE_GTK3
6565 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6566
6567 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6568 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6569 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6570
1c2cc4ef
JB
65712011-03-08 Juanma Barranquero <lekktu@gmail.com>
6572
6573 * w32xfns.c (select_palette): Check success of RealizePalette against
6574 GDI_ERROR, not zero.
6575
33383987 6576See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6577
6578;; Local Variables:
6579;; coding: utf-8
aac0c6e3
MR
6580;; End:
6581
33383987 6582 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6583
6584 This file is part of GNU Emacs.
6585
6586 GNU Emacs is free software: you can redistribute it and/or modify
6587 it under the terms of the GNU General Public License as published by
6588 the Free Software Foundation, either version 3 of the License, or
6589 (at your option) any later version.
6590
6591 GNU Emacs is distributed in the hope that it will be useful,
6592 but WITHOUT ANY WARRANTY; without even the implied warranty of
6593 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6594 GNU General Public License for more details.
6595
6596 You should have received a copy of the GNU General Public License
6597 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.