Auto-commit of generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a66cfb1c
SM
12011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * buffer.c (syms_of_buffer) <enable-multibyte-characters>: Don't
4 advertise functionality which we discourage or doesn't work.
5
7c5ee88e
PE
62011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7
8 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
9 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
10 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
11 this makes Emacs dump core during garbage collection on rare
12 occasions. sizeof is obviously inferior to offsetof here, so
13 stick with offsetof.
14 (GC_POINTER_ALIGNMENT): New macro.
15 (mark_memory): Omit 3rd (offset) arg; caller changed.
16 Don't assume EMACS_INT alignment is the same as pointer alignment.
17
df1bbe5b
SM
182011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
19
20 * keyboard.c (read_key_sequence_remapped): New var.
21 (read_key_sequence): Compute remapping in the right buffer.
22 (command_loop_1): Use read_key_sequence's remapping directly.
23
51553db6
SM
242011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
25
32c1fffd
SM
26 * dired.c (file_name_completion): Don't expand file name.
27 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
28 before checking file name handler.
29
51553db6
SM
30 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
31 they've been requested explicitly (bug#9591).
32
b6bd1599 332011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
34
35 * keymap.c (Fsingle_key_description): Use make_specified_string
36 instead of build_string to build string from push_key_description.
37 (Bug#5193)
38
f701dc2a
PE
392011-09-30 Paul Eggert <eggert@cs.ucla.edu>
40
4222c55d
PE
41 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
42 This fixes a Y2038 bug on 64-bit hosts.
43 * buffer.c (reset_buffer):
44 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
45 (Fclear_buffer_auto_save_failure):
46 Use 0, not -1, to represent an unset failure time, since time_t
47 might not be signed.
48
f701dc2a
PE
49 Remove dependency on glibc malloc internals.
50 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
51 Move back here from lisp.h, but with their new implementations.
52 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
53 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
54 * charset.c (charset_table_init): New static var.
55 (syms_of_charset): Use it instead of xmalloc. This removes a
56 dependency on glibc malloc internals. See Eli Zaretskii's comment in
57 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
58 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
59 Move back to alloc.c.
60 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
61 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
62
9ceebf39
JD
632011-09-30 Jan Djärv <jan.h.d@swipnet.se>
64
65 * nsterm.m (windowDidResize): Call x_set_window_size only when
66 ns_in_resize is true. Otherwise set pixelwidth/height and
67 call change_frame_size (Bug#9628).
68
cb993c58
PE
692011-09-30 Paul Eggert <eggert@cs.ucla.edu>
70
3930c88b
PE
71 Port --enable-checking=all to Fedora 14 x86-64.
72 * charset.c (syms_of_charset): Also account for glibc malloc's
73 internal overhead when calculating the initial malloc maximum.
74
cb993c58
PE
75 Port --enable-checking=all to Fedora 14 x86.
76 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
77 Move to lisp.h.
78 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
79 (overrun_check_realloc, overrun_check_free):
80 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
81 That way, xmalloc returns a properly-aligned pointer even if
82 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
83 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
84 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
85 into account when calculating the initial malloc maximum.
86 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
87 Move here from alloc.c, so that charset.c can use it too.
88 Properly align; the old code wasn't right for common 32-bit hosts
89 when configured with --enable-checking=all.
90 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
91 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
92
31bed486
EZ
932011-09-29 Eli Zaretskii <eliz@gnu.org>
94
04c70788 95 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
96 use EDOM.
97
fbcaa2f3
EZ
982011-09-28 Eli Zaretskii <eliz@gnu.org>
99
100 * xdisp.c (compute_display_string_end): If there's no display
101 string at CHARPOS, return -1.
102
103 * bidi.c (bidi_fetch_char): When compute_display_string_end
104 returns a negative value, treat the character as a normal
105 character not covered by a display string. (Bug#9624)
106
a239d4e9
JB
1072011-09-28 Juanma Barranquero <lekktu@gmail.com>
108
109 * lread.c (Fread_from_string): Fix typo in docstring.
110
88652fd5
EZ
1112011-09-27 Eli Zaretskii <eliz@gnu.org>
112
113 * xdisp.c (handle_invisible_prop): If invisible text ends on a
114 newline, reseat the iterator instead of bidi-iterating there one
115 character at a time. (Bug#9610)
32c1fffd
SM
116 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
117 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 118
ed497dd4
AS
1192011-09-27 Andreas Schwab <schwab@linux-m68k.org>
120
121 * lread.c (readevalloop): Use correct code for NBSP.
122 (read1): Likewise. (Bug#9608)
123
b2bf61aa
MA
1242011-09-25 Michael Albinus <michael.albinus@gmx.de>
125
126 * dbusbind.c (Fdbus_register_signal): When service is not
127 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
128
32bbb17c
GM
1292011-09-25 Glenn Morris <rgm@gnu.org>
130
131 * buffer.c (truncate-lines): Doc fix.
132
94e0933e
CY
1332011-09-24 Chong Yidong <cyd@stupidchicken.com>
134
135 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
136 (Fset_window_next_buffers): Doc fix.
137
cddde921
GM
1382011-09-24 Glenn Morris <rgm@gnu.org>
139
140 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
141
1260aef1
PE
1422011-09-24 Paul Eggert <eggert@cs.ucla.edu>
143
25b4bfa0
PE
144 Fix minor problems found by static checking.
145 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
146 * indent.c (Fvertical_motion): Fix == vs = typo.
147
e3cbd34b
EZ
1482011-09-24 Eli Zaretskii <eliz@gnu.org>
149
a66cfb1c
SM
150 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
151 Default value is now t. Doc fix.
6bf7006f 152
e3cbd34b 153 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 154 logic when moving up, not only when moving down. Fix the
e3cbd34b 155 confusing name and values of the it_overshoot_expected variable;
32c1fffd 156 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
157
158 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
159 CHARPOS is covered by a display string which includes newlines.
160 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
161 is covered by a display string with embedded newlines.
162
a3de0cbd
MA
1632011-09-24 Michael Albinus <michael.albinus@gmx.de>
164
165 * dbusbind.c (Fdbus_register_signal): Add match rule to
166 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
167 (Fdbus_register_method, Vdbus_registered_objects_table):
168 Fix docstring.
a3de0cbd 169
b260039d
JM
1702011-09-24 Jim Meyering <meyering@redhat.com>
171
32c1fffd 172 do not ignore write error for any output size
b260039d
JM
173 The previous change was incomplete.
174 While it makes emacs --batch detect the vast majority of stdout
175 write failures, errors were still ignored whenever the output size is
176 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
177 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
178 && echo FAIL: ignored write error
179 FAIL: ignored write error
180 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
181 && echo FAIL: ignored write error
182 FAIL: ignored write error
183 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
184
8eca8a7c
AS
1852011-09-23 Andreas Schwab <schwab@linux-m68k.org>
186
187 * emacs.c (Fkill_emacs): In noninteractive mode exit
188 non-successfully if a write error occurred on stdout. (Bug#9574)
189
3341db62
EZ
1902011-09-21 Eli Zaretskii <eliz@gnu.org>
191
192 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
193 the xassert test.
194
195 * dispextern.h (struct it): Update the comment documenting what
196 can it->OBJECT be.
197
8c203dbf
EZ
1982011-09-20 Eli Zaretskii <eliz@gnu.org>
199
200 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
201 a display string, extend search for cursor position to end of row.
202 (find_row_edges): If the row ends in a newline from a display
203 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
204 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
205 (Fcurrent_bidi_paragraph_direction): Fix search for previous
206 non-empty line. Fixes confusing cursor motion with arrow keys at
207 the beginning of a line that starts with whitespace.
8c203dbf 208
a4824228
LMI
2092011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
210
211 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
212 (bug#9493).
213
33ed493b
CY
2142011-09-18 Chong Yidong <cyd@stupidchicken.com>
215
216 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
217 boolean (Bug#9154).
218
56cd55c8
EZ
2192011-09-18 Eli Zaretskii <eliz@gnu.org>
220
221 * xdisp.c (display_line): Record maximum and minimum buffer
222 positions even if no glyphs were produced (e.g., by a zero-width
223 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
224 buffer positions that will be removed from the glyph row because
225 they don't fit.
c02dcedf
EZ
226 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
227 column is beyond frame width: don't subtract 1 "pixel" when
228 computing width of the stretch.
3e62b7e0
EZ
229 (reseat_at_next_visible_line_start): Undo the change made on
230 2011-09-17 that saved paragraph information and restored it after
231 the call to `reseat'. (Bug#9545)
56cd55c8 232
5ed99d36 2332011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
234
235 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
236 and turn window cursor on if cleared (Bug#9415).
237
5ed99d36 2382011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
239
240 * search.c (boyer_moore): Take unibyte characters from pattern
241 literally. (Bug#9458)
242
9bade7b2
EZ
2432011-09-18 Eli Zaretskii <eliz@gnu.org>
244
245 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
246
e5e9d610
PE
2472011-09-18 Paul Eggert <eggert@cs.ucla.edu>
248
87e4427a
PE
249 Fix minor problem found by static checking.
250 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
251 initialized, to pacify gcc -Wuninitialized.
252
e5e9d610
PE
253 * fileio.c: Report proper errno when syscall falls.
254 (Finsert_file_contents): Save and restore errno,
255 so that report_file_error outputs the correct diagnostic.
256 (Fwrite_region) [CLASH_DETECTION]: Likewise.
257
a1674f0b
EZ
2582011-09-18 Eli Zaretskii <eliz@gnu.org>
259
260 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
261
fbfb6dd4
EZ
2622011-09-17 Eli Zaretskii <eliz@gnu.org>
263
264 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
265 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
266
bb187662
EZ
2672011-09-17 Eli Zaretskii <eliz@gnu.org>
268
1137e8b8
EZ
269 * xdisp.c (reseat_at_next_visible_line_start): Keep information
270 about the current paragraph and restore it after the call to
271 reseat.
272
273 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
274 (bidi_find_paragraph_start): Search back for paragraph beginning
275 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
276 (bidi_move_to_visually_next): Only trigger paragraph-related
277 computations when the last character is a newline or at EOB, not
278 just any NEUTRAL_B. (Bug#9470)
279
bb187662
EZ
280 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
281 truncated lines if point is covered by a display string. (Bug#9524)
282
2e621251
PE
2832011-09-16 Paul Eggert <eggert@cs.ucla.edu>
284
285 * xselect.c: Relax test for outgoing X longs (Bug#9498).
286 (cons_to_x_long): New function.
287 (lisp_data_to_selection_data): Use it. Correct the test for
288 short-versus-long data; it was negated. Break out of vector
289 loop, for efficiency, when a long datum is discovered.
290
91a15bc6
SM
2912011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
292
293 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
294
b41c3a35
EZ
2952011-09-16 Eli Zaretskii <eliz@gnu.org>
296
297 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
298 GCC PR/17406) by declaring this function with external scope.
299
7812ba2d
PE
3002011-09-15 Paul Eggert <eggert@cs.ucla.edu>
301
302 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
303 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
304
cf7edc2a
AS
3052011-09-15 Andreas Schwab <schwab@linux-m68k.org>
306
307 * editfns.c (Fformat): Correctly handle text properties on "%%".
308
bd01620e
EZ
3092011-09-15 Eli Zaretskii <eliz@gnu.org>
310
311 * xterm.c (x_draw_composite_glyph_string_foreground):
312 * w32term.c (x_draw_composite_glyph_string_foreground):
313 * term.c (encode_terminal_code):
314 * composite.c (composition_update_it, get_composition_id):
315 * xdisp.c (get_next_display_element)
316 (fill_composite_glyph_string): Add comments about special meaning
317 of TAB characters in a composition.
318
a02719a3
PE
3192011-09-15 Paul Eggert <eggert@cs.ucla.edu>
320
321 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
322 This occurs when processing a multibyte format.
323 Problem reported by Wolfgang Jenker.
a02719a3 324
72589a3c
JB
3252011-09-15 Johan Bockgård <bojohan@gnu.org>
326
327 * xdisp.c (try_cursor_movement): Only check for exact match if
328 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
329
1c14176c
PE
3302011-09-14 Paul Eggert <eggert@cs.ucla.edu>
331
332 Remove unused external symbols.
333 * dispextern.h (calc_pixel_width_or_height): Remove decl.
334 * xdisp.c (calc_pixel_width_or_height): Now static.
335 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
336 * indent.c (check_display_width):
337 * w32term.c: Fix comment to match code.
338 * xterm.c, xterm.h (x_catching_errors): Remove.
339
d2eea5b5
PE
3402011-09-14 Paul Eggert <eggert@cs.ucla.edu>
341
342 * xselect.c: Use signed conversions more consistently (Bug#9498).
343 (selection_data_to_lisp_data): Assume incoming selection data are
344 signed integers, not unsigned. This is to be consistent with
345 outgoing selection data, which was modified to use signed integers
346 in as part of the fix to Bug#9196 in response to Jan D.'s comment
347 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
348 expects long, not unsigned long.
349
46888499
EZ
3502011-09-14 Eli Zaretskii <eliz@gnu.org>
351
352 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
353 computation of loop end. Reported by Johan Bockgård
354 <bojohan@gnu.org>.
355
ef8ef9fb
CY
3562011-09-13 Chong Yidong <cyd@stupidchicken.com>
357
358 * frame.c (Fother_visible_frames_p): Function deleted.
359
fa819fed
EZ
3602011-09-12 Eli Zaretskii <eliz@gnu.org>
361
362 * indent.c (compute_motion): Process display vector front to back
363 rather than the other way around. (Bug#2496)
364
2ba8e008
SM
3652011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
366
367 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
368
20f53c69
CY
3692011-09-11 Chong Yidong <cyd@stupidchicken.com>
370
371 * minibuf.c (Fread_from_minibuffer): Doc fix.
372
d562d7a4
EZ
3732011-09-11 Eli Zaretskii <eliz@gnu.org>
374
375 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
376 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
377
1c4d7f3d
LMI
3782011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
379
380 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
381 value for non-existent files.
382
b885bf36
EZ
3832011-09-11 Eli Zaretskii <eliz@gnu.org>
384
385 * fileio.c (Finsert_file_contents): If the file cannot be opened,
386 set its "size" to -1. This will set the modtime_size field of
387 the corresponding buffer to -1, which is what
388 verify-visited-file-modtime expects for files that do not exist.
389 (Bug#9139)
390
6612f0bf
PE
3912011-09-11 Paul Eggert <eggert@cs.ucla.edu>
392
393 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
394 here ...
395 * lisp.h: ... from here. push_key_description is no longer
396 defined in keyboard.c, so its declaration should not be in
397 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
398 logically belongs with push_key_description.
399
dfb3f755
PE
4002011-09-10 Paul Eggert <eggert@cs.ucla.edu>
401
402 * buffer.h: Include <sys/types.h> instead of <time.h>.
403 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
404 Problem reported by Herbert J. Skuhra.
405
3134906c
LMI
4062011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
407
408 * xml.c (parse_region): Make the parsing work for
409 non-comment-starting XML files again (bug#9144).
410
8d903f4e
AS
4112011-09-10 Andreas Schwab <schwab@linux-m68k.org>
412
413 * image.c (gif_load): Fix calculation of bottom and right corner.
414 (Bug#9468)
415
80ad64f4
EZ
4162011-09-10 Eli Zaretskii <eliz@gnu.org>
417
418 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
419 redisplay in small windows.
420
208a048d
EZ
4212011-09-09 Eli Zaretskii <eliz@gnu.org>
422
423 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
424
9b1c252e
MR
4252011-09-08 Martin Rudalics <rudalics@gmx.at>
426
427 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
428 Operate on live windows only.
429
2949f33b
JB
4302011-09-08 Juanma Barranquero <lekktu@gmail.com>
431
432 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
433
e08dcafd
EZ
4342011-09-07 Eli Zaretskii <eliz@gnu.org>
435
436 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
437 only under bidi iteration.
438
115b96bd
JD
4392011-09-07 Jan Djärv <jan.h.d@swipnet.se>
440
441 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
442
c8199d0f
PE
4432011-09-06 Paul Eggert <eggert@cs.ucla.edu>
444
445 isnan: Fix porting problem to Solaris 10 with bundled gcc.
446 Without this fix, the command to link temacs failed due to an
447 undefined symbol __builtin_isnan. This is because
448 /usr/include/iso/math_c99.h #defines isnan(x) to
449 __builtin_isnan(x), but the bundled gcc, which identifies itself
450 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
451 a __builtin_isnan.
452 * floatfns.c (isnan): #undef, and then #define to a clone of
453 what's in data.c.
454 (Fisnan): Always define, since it's always available now.
455 (syms_of_floatfns): Always define isnan at the Lisp level.
456
e39b275c 4572011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
458
459 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
460
b2db44d9 4612011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 462
f4af5137 463 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
464 The previous code assumed that file offsets (off_t values) fit in
465 EMACS_INT variables, which is not true on typical 32-bit hosts.
466 The code messed up by falsely reporting buffer overflow in cases
467 such as (insert-file-contents "big" nil 1 2) into an empty buffer
468 when "big" contains more than 2**29 bytes, even though this
469 inserts just one byte and does not overflow the buffer.
470 (Finsert_file_contents): Store file offsets as off_t
471 values, not as EMACS_INT values. Check for overflow when
472 converting between EMACS_INT and off_t. When checking for
473 buffer overflow or for overlap, take the offsets into account.
474 Don't use EMACS_INT for small values where int suffices.
475 When checking for overlap, fix a typo: ZV was used where
476 ZV_BYTE was intended.
477 (Fwrite_region): Don't assume off_t fits into 'long'.
478 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
479
ecfc0a49
MA
4802011-09-05 Michael Albinus <michael.albinus@gmx.de>
481
482 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
483
6511acf2 4842011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 485
0999621a 486 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
487
488 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 489 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
490 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
491 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
492 (modify_event_symbol): Do not assume that the length of
493 name_alist_or_stem is safe to alloca and fits in int.
494 (Fexecute_extended_command): Likewise for function name and binding.
495 (Frecursion_depth): Wrap around reliably on integer overflow.
496 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
497 since some callers pass EMACS_INT values.
498 (Fsingle_key_description): Don't crash if symbol name contains more
499 than MAX_ALLOCA bytes.
500 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
501 (get_minibuffer): Arg is now EMACS_INT, not int.
502 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 503 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
504 * window.h (command_loop_level, minibuf_level): Reflect API changes.
505
2be7d702
PE
506 * dbusbind.c (signature_cat): New function.
507 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
508 Do not overrun buffer; instead, report string overflow.
509
9d1df220
PE
510 * dispnew.c (add_window_display_history): Don't overrun buffer.
511 Truncate instead; this is OK since it's just a log.
512
33ef5c64
PE
513 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
514 even if the time zone offset is outlandishly large.
515 Don't mishandle offset == INT_MIN.
516
66c6fdd5
PE
517 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
518 when creating daemon; the previous buffer-overflow check was incorrect.
519
d749b01b
PE
520 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
521 which has the guts of the old verror function.
522
b5cd1905
PE
523 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
524 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
525
6e1a67fb
PE
526 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
527 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 528 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 529 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
530 length of string rather than counting it via multiple sprintfs;
531 that's simpler and more reliable.
c21721cc
PE
532 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
533 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
534 sprintf, in case result does not fit in int.
535
c57b67fc
PE
536 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
537 (fontset_from_font): Print it.
538
8a401434
PE
539 * frame.c (tty_frame_count): Now printmax_t, not int.
540 (make_terminal_frame, set_term_frame_name): Print it.
541 (x_report_frame_params): In X, window IDs are unsigned long,
542 not signed long, so print them as unsigned.
543 (validate_x_resource_name): Check for implausibly long names,
544 and don't assume name length fits in 'int'.
545 (x_get_resource_string): Don't blindly alloca invocation name;
546 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
547 not fit in int.
548
6e1a67fb
PE
549 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
550 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
551 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
552
0df02bf3
PE
553 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
554 Use esprintf, not sprintf, in case result does not fit in int.
555
48e30793
PE
556 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
557 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
558 it as a large positive number.
559 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
560 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
561
a66ff6d8
PE
562 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
563 in case result does not fit in int.
564
aca216ff
PE
565 * print.c (float_to_string): Detect width overflow more reliably.
566 (print_object): Make sprintf buffer a bit bigger, to avoid potential
567 buffer overrun. Don't assume list length fits in 'int'. Treat
568 print length of 0 as 0, not as infinity; to be consistent with other
569 uses of print length in this function. Don't overflow print length
570 index. Don't assume hash table size fits in 'long', or that
571 vectorlike size fits in 'unsigned long'.
572
31c286f7
PE
573 * process.c (make_process): Use printmax_t, not int, to format
574 process-name gensyms.
575
55e5faa1
PE
576 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
577
80f2e268
PE
578 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
579 to avoid potential buffer overrun.
580
670741ab
PE
581 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
582 if X resource line is longer than 512 bytes.
583
b7163a50
PE
584 * xfns.c (x_window): Make sprintf buffer a bit bigger
585 to avoid potential buffer overrun.
586
ae58ff1f
PE
587 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
588
c43c8a6a
PE
589 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
590
3f8236f4
PE
5912011-09-04 Paul Eggert <eggert@cs.ucla.edu>
592
53e9fe90 593 Integer overflow fixes for scrolling, etc.
6511acf2
PE
594 Without these, Emacs silently mishandles large integers sometimes.
595 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
596 it were "C-u 1 M-x recenter" on a typical 64-bit host.
597
6511acf2
PE
598 * xdisp.c (try_window_id): Check Emacs fixnum range before
599 converting to 'int'.
806add1d 600
6511acf2 601 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
602 Check that an Emacs fixnum is in range before assigning it to 'int'.
603 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
604 values converted from Emacs fixnums.
605 (Frecenter): Don't wrap around a line count if it is out of 'int'
606 range; instead, treat it as an extreme value.
607 (Fset_window_configuration, compare_window_configurations):
608 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
609
6511acf2
PE
610 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
611 that can exceed INT_MAX. Check that EMACS_INT value is in range
612 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
613 (match_limit): Don't assume that a fixnum can fit in 'int'.
614
6511acf2 615 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
616 exceed INT_MAX.
617
6511acf2 618 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
619 (Fvertical_motion): Don't wrap around LINES values that don't fit
620 in 'int'. Instead, treat them as extreme values. This is good
621 enough for windows, which can't have more than INT_MAX lines anyway.
622
fcb901a7
LMI
6232011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
624
0f2f6b6d
LMI
625 * Require libxml/parser.h to avoid compilation warning.
626
fcb901a7
LMI
627 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
628
629 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
630 since this reportedly can destroy thread storage.
631
6e20a0d4
CY
6322011-08-30 Chong Yidong <cyd@stupidchicken.com>
633
634 * syntax.c (find_defun_start): Update all cache variables if
635 exiting early (Bug#9401).
636
148ae00e
EZ
6372011-08-30 Eli Zaretskii <eliz@gnu.org>
638
f6cfbd8f
EZ
639 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
640
148ae00e
EZ
641 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
642 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
643 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
644
645 * term.c (tty_append_glyph): New function.
646 (produce_stretch_glyph): Static function and its prototype deleted.
647
a66cfb1c
SM
648 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
649 Add prototypes.
148ae00e 650
c4a07a4c
PE
6512011-08-29 Paul Eggert <eggert@cs.ucla.edu>
652
653 * image.c (parse_image_spec): Check for nonnegative, not for positive,
654 when checking :margin (Bug#9390).
655 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 656 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
657 so that the name doesn't mislead. All uses changed.
658
6bc8cd65
JB
6592011-08-28 Johan Bockgård <bojohan@gnu.org>
660
661 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
662 set_tty_hooks.
663
dca4927e
EZ
6642011-08-27 Eli Zaretskii <eliz@gnu.org>
665
666 * xdisp.c (move_it_to): Don't bail out early when reaching
667 position beyond to_charpos, if we are scanning backwards.
668 (move_it_vertically_backward): When DY == 0, make sure we get to
669 the first character in the line after the newline.
670
f2cad773
PE
6712011-08-27 Paul Eggert <eggert@cs.ucla.edu>
672
673 * ccl.c: Improve and simplify overflow checking (Bug#9196).
674 (ccl_driver): Do not generate an out-of-range pointer.
675 (Fccl_execute_on_string): Remove unnecessary check for
676 integer overflow, noted by Stefan Monnier in
677 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
678 Remove a FIXME that didn't need fixing.
679 Simplify the newly-introduced buffer reallocation code.
680
0cae2cdb
JB
6812011-08-27 Juanma Barranquero <lekktu@gmail.com>
682
683 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
684
5fc295a4 6852011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 686
70c60eb2 687 Integer and memory overflow issues (Bug#9196).
726e0ab1 688
d31850da
PE
689 * doc.c (get_doc_string): Rework so that
690 get_doc_string_buffer_size is the actual buffer size, rather than
691 being 1 less than the actual buffer size; this makes xpalloc more
692 convenient.
693
a69fbedb
PE
694 * image.c (x_allocate_bitmap_record, cache_image):
695 * xselect.c (Fx_register_dnd_atom):
696 Simplify previous changes by using xpalloc.
697
fe5c5d37
PE
698 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
699 since either will do and ptrdiff_t is convenient with xpalloc.
700
0065d054
PE
701 * charset.c (charset_table_size)
702 (struct charset_sort_data.priority): Now ptrdiff_t.
703 (charset_compare): Don't overflow if priorities differ greatly.
704 (Fsort_charsets): Don't assume list length fits in int.
705 Check for size-calculation overflow when allocating sort data.
706 (syms_of_charset): Allocate an initial charset table that is
707 just under 64 KiB, to avoid problems with glibc malloc and mmap.
708
709 * cmds.c (internal_self_insert): Check for size-calculation overflow.
710
711 * composite.h (struct composition.glyph_len): Now int, not unsigned.
712 The actual value is always <= INT_MAX, and leaving it unsigned made
713 overflow checking harder.
714
715 * dispextern.h (struct glyph_matrix.rows_allocated)
716 (struct face_cache.size): Now ptrdiff_t, for convenience in use
717 with xpalloc. The values are still always <= INT_MAX.
718
719 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
720
721 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
722 (SAFE_NALLOCA): New macro.
723
724 * region-cache.c (struct boundary.pos, find_cache_boundary)
725 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
726 (set_cache_region, invalidate_region_cache)
727 (revalidate_region_cache, know_region_cache, region_cache_forward)
728 (region_cache_backward, pp_cache):
729 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
730 so that ptrdiff_t * can be passed to xpalloc.
731 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
732 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
733 (pp_cache): Don't assume cache_len fits in int.
734 * region-cache.h: Adjust extern decls to match.
735
736 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
737 EMACS_INT, since either will do, for xpalloc.
738
739 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
740 (xnmalloc, xnrealloc, xpalloc): New functions.
741
726e0ab1
PE
742 * bidi.c (bidi_shelve_header_size): New constant.
743 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
744 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
745
51f30bc5 746 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
747 * buffer.c (overlays_at, overlays_in, record_overlay_string)
748 (overlay_strings):
749 Don't update size of array until after memory allocation succeeds,
750 because xmalloc/xrealloc may not return.
0065d054
PE
751 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
752 now that we have proper integer overflow checking.
753 (record_overlay_string, overlay_strings): Catch overflows when
754 calculating size of overlay_str_buf.
726e0ab1 755
0065d054
PE
756 * callproc.c (Fcall_process): Check for size overflow when
757 calculating size of args2.
758 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
759 Normally we prefer signed values, but sticking with ptrdiff_t would
760 require adding more-complicated checks.
726e0ab1
PE
761
762 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
763 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
764 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 765 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
766
767 * character.c (Fstring): Check for size-calculation overflow.
768
769 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
770 unnecessary integer overflow. Check for size overflow.
771 (encode_coding_object): Don't update size until xmalloc succeeds.
772
773 * composite.c (get_composition_id): Check for overflow in glyph
774 length calculations.
775
776 Integer and memory overflow fixes for display code.
777 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
778 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
779 (scrolling_window): Check for overflow in size calculations.
780 (line_draw_cost, realloc_glyph_pool, add_row_entry):
781 Don't assume glyph table len fits in int.
782 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
783 (row_table_size): Now ptrdiff_t, not int.
784 (scrolling_window): Avoid overflow in size calculations.
785 Don't update size until allocation succeeds.
786 * fns.c (concat): Check for overflow in size calculations.
787 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
788 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
789 (NEXT_ALMOST_PRIME_LIMIT): New constant.
790
791 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
792 (get_doc_string): Check for size calculation overflow.
793 Don't update size until allocation succeeds.
794 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
795 EMACS_INT, where ptrdiff_t will do.
796 (Fsubstitute_command_keys): Check for string overflow.
797
798 * editfns.c (set_time_zone_rule): Don't assume environment length
799 fits in int.
800 (message_length): Now ptrdiff_t, not int.
801 (Fmessage_box): Don't update size until allocation succeeds.
802 Don't assume message length fits in int.
803 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
804
0065d054
PE
805 * emacs.c (main): Do not reallocate argv, since there is a null at
806 the end that can be overwritten, and this way there's no need to
807 worry about size-calculation overflow.
808 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
809
810 * eval.c (init_eval_once, grow_specpdl): Don't update size until
811 alloc succeeds.
812 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
813
814 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
815 (x_set_scroll_bar_width, x_figure_window_size):
816 Check for integer overflow.
817 (x_set_alpha): Do not assume XINT fits in int.
818
819 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
820 This is for the members text_lines, text_cols, total_lines, total_cols,
821 where the system imposes an 'int' limit.
822
823 * fringe.c (Fdefine_fringe_bitmap):
824 Don't update size until alloc works.
825
826 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
827 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
828
829 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
830 Check for size-calculation overflow.
831 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
832 do, as we prefer signed integers.
833 (id_to_widget.max_size, id_to_widget.used)
834 (xg_store_widget_in_map, xg_remove_widget_from_map)
835 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
836 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
837 Use and return ptrdiff_t, not int.
838 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
839 * gtkutil.h: Change prototypes to match the above.
840
841 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
842 are duplicate now that they've been promoted to lisp.h.
843 (x_allocate_bitmap_record, x_alloc_image_color)
844 (make_image_cache, cache_image, xpm_load):
845 Don't update size until alloc is done.
846 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
847 (x_detect_edges):
3256efce 848 Check for size calculation overflow.
726e0ab1
PE
849 (ct_colors_allocated_max): New constant.
850 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
851 overflow.
3256efce 852
726e0ab1
PE
853 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
854 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
855 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
856 Use ptrdiff_t, not int, to count maps.
857 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
858 calculations. Don't update size until allocation succeeds.
859 Redo calculations to avoid overflow.
726e0ab1
PE
860 * keyboard.h: Change prototypes to match the above.
861
862 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
863 to count maps.
864 (current_minor_maps): Check for size calculation overflow.
865 * keymap.h: Change prototypes to match the above.
866
867 * lread.c (read1, init_obarray): Don't update size until alloc done.
868
869 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
870 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
871
726e0ab1
PE
872 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
873 Now ptrdiff_t, not int.
874 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
875 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
876
877 * process.c (Fnetwork_interface_list): Check for overflow
878 in size calculation.
879
880 * region-cache.c (move_cache_gap): Check for size calculation overflow.
881
882 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
883 overflow. Don't bother calling xmalloc when xrealloc will do.
884
885 * search.c (Freplace_match): Check for size calculation overflow.
886 (Fset_match_data): Don't assume list lengths fit in 'int'.
887
888 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
889 for command line length. Do not attempt to address one before the
890 beginning of an array, as that's not portable.
891
892 * term.c (max_frame_lines): Remove; unused.
893 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
894 not int.
895 (encode_terminal_code, calculate_costs): Check for size
896 calculation overflow.
897 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
898 table lengths and related sizes. Don't update size until alloc
899 done. Redo calculations to avoid overflow.
900 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
901
902 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
903 subtracting pointers.
904 (gobble_line): Check for overflow more carefully. Don't update size
905 until alloc done.
906
907 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
908 Don't update size until alloc done.
909 Redo size calculations to avoid overflow.
910 Check for size calculation overflow.
0065d054 911 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
912
913 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
914 Use ptrdiff_t, not int, for sizes.
915 (store_mode_line_noprop_char): Don't update size until alloc done.
916
0065d054
PE
917 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
918 Use ptrdiff_t, not int, for sizes.
919 (Finternal_make_lisp_face, cache_face):
920 Check for size calculation overflow.
921 (cache_face): Treat size calculation overflows as if they were
922 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
923
924 * xfns.c (x_encode_text, x_set_name_internal)
925 (Fx_change_window_property): Use ptrdiff_t, not int, to count
926 sizes, since they can exceed INT_MAX in size. Check for size
927 calculation overflow.
928
0065d054
PE
929 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
930 (xg_select): Check for size calculation overflow.
726e0ab1
PE
931 Don't update size until alloc done.
932
0065d054 933 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 934 as sprintf is limited to int lengths.
1d526e2f 935
252c5ee1
PE
936 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
937 (X_LONG_MIN): New macros.
864d7ce7
PE
938 Use them to make the following changes clearer.
939 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
940 This change doesn't affect the value now, but it may help remind
941 future maintainers not to raise the value too much later.
942 (SELECTION_QUANTUM): Remove, replacing with ...
943 (selection_quantum): ... new function, which avoids overflow.
944 All uses changed.
945 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
946 assumption that selection length fits in 'int'.
947 (x_reply_selection_request, x_handle_selection_request)
948 (x_get_window_property, receive_incremental_selection)
949 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
950 (lisp_data_to_selection_data, clean_local_selection_data):
951 Use ptrdiff_t, not int, to record length of selection.
952 (x_reply_selection_request, x_get_window_property)
953 (receive_incremental_selection, x_property_data_to_lisp):
954 Redo calculations to avoid overflow.
955 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 956 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
957 something.
958 (x_get_window_property, receive_incremental_selection)
959 (lisp_data_to_selection_data, x_property_data_to_lisp):
960 Check for size-calculation overflow.
961 (x_get_window_property, receive_incremental_selection)
962 (lisp_data_to_selection_data, Fx_register_dnd_atom):
963 Don't store size until memory allocation succeeds.
964 (x_get_window_property): Plug memory leak on memory exhaustion.
965 Don't double-block input; malloc is safe here. Don't assume 2**34
966 - 4 fits in unsigned long. Add an xassert to check
967 XGetWindowProperty overflow. Be more careful about overflow
968 calculations, and distinguish size from memory overflow better.
969 (receive_incremental_selection): When tracing, don't assume
970 unsigned int is less than INT_MAX.
971 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
972 harmful) conversions of unsigned short to int.
973 (lisp_data_to_selection_data): Don't assume that integers
974 in the range -65535 through -1 fit in an X unsigned short.
975 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
976 result parameters unless successful. Rely on cons_to_unsigned
977 to report problems with elements; the old code wasn't right anyway.
978 (x_check_property_data): Check for int overflow; we cannot use
979 a wider type due to X limits.
980 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
981
726e0ab1 982 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 983
0065d054
PE
984 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
985 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
986 (x_color_cells): Don't store size until memory allocation succeeds.
987 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 988 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
989 (x_term_init): Don't assume length fits in int (sprintf is limited
990 to int size).
bc18e09d 991
ebfa62c0
PE
992 Use ptrdiff_t for composition IDs.
993 * character.c (lisp_string_width):
994 * composite.c (composition_table_size, n_compositions)
995 (get_composition_id, composition_gstring_from_id):
996 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
997 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
998 * window.c (Frecenter):
999 Use ptrdiff_t, not int, for composition IDs.
1000 * composite.c (get_composition_id): Check for integer overflow.
1001 * composite.h: Adjust prototypes to match the above changes.
1002
d3411f89
PE
1003 Use ptrdiff_t for hash table indexes.
1004 * category.c (hash_get_category_set):
1005 * ccl.c (ccl_driver):
1006 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1007 * coding.c (coding_system_charset_list, detect_coding_system):
1008 * coding.h (struct coding_system.id):
1009 * composite.c (get_composition_id, gstring_lookup_cache):
1010 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1011 * image.c (xpm_get_color_table_h):
1012 * lisp.h (hash_lookup, hash_put):
1013 * minibuf.c (Ftest_completion):
1014 Use ptrdiff_t for hash table indexes, not int (which is too
1015 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1016 32-bit --with-wide-int hosts).
1017
e097a6fa
PE
1018 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1019 Add a FIXME comment about memory leaks.
1020 (syms_of_charset): Don't assume xmalloc returns.
1021
5637687f
PE
1022 Don't assume that stated character widths fit in int.
1023 * character.c (Fchar_width, c_string_width, lisp_string_width):
1024 * character.h (CHAR_WIDTH):
1025 * indent.c (MULTIBYTE_BYTES_WIDTH):
1026 Use sanitize_char_width to avoid undefined and/or bad behavior
1027 with outlandish widths.
a66cfb1c 1028 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1029 now that we have two such functions. All uses changed.
1030 (sanitize_char_width): New inline function.
1031
a2271ba2
PE
1032 Don't assume that tab-width fits in int.
1033 * character.h (sanitize_width): New inline function.
1034 (SANE_TAB_WIDTH): New macro.
1035 (ASCII_CHAR_WIDTH): Use it.
1036 * indent.c (sane_tab_width): Remove. All uses replaced by
1037 SANE_TAB_WIDTH (current_buffer).
1038 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1039
18c52557
PE
1040 * fileio.c: Integer overflow issues with file modes.
1041 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1042
caeeedc1
PE
1043 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1044 Remove unreachable code.
1045 (read_hex, load_charset_map_from_file): Check for integer overflow.
1046
50849c52
PE
1047 * xterm.c: don't go over XClientMessageEvent limit
1048 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1049 (x_send_scroll_bar_event): Likewise. Check that the size does not
1050 exceed limits imposed by XClientMessageEvent, as well as the usual
1051 ptrdiff_t and size_t limits.
1052
b13995db
PE
1053 * keyboard.c: Overflow, signedness and related fixes.
1054 (make_lispy_movement): Use same integer type in forward decl
1055 that is used in the definition.
1056 (read_key_sequence, keyremap_step):
1057 Change bufsize argument back to int, undoing my 2011-03-30 change.
1058 We prefer signed types, and int is wide enough here.
1059 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1060 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1061 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1062 length, not size_t. Use ptrdiff_t for index, not int.
1063 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1064 possibility of integer overflow.
1065
13464394
PE
1066 Overflow, signedness and related fixes for images.
1067
1068 * dispextern.h (struct it.stack[0].u.image.image_id)
1069 (struct_it.image_id, struct image.id, struct image_cache.size)
1070 (struct image_cache.used, struct image_cache.ref_count):
1071 * gtkutil.c (update_frame_tool_bar):
1072 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1073 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1074 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1075 * nsmenu.m (update_frame_tool_bar):
1076 * xdisp.c (calc_pixel_width_or_height):
1077 * xfns.c (image_cache_refcount):
1078 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1079 on typical 64-bit hosts.
1080
1081 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1082 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1083 Omit unnecessary casts to int.
1084 (parse_image_spec): Check that integers fall into 'int' range
1085 when the callers expect that.
1086 (image_ascent): Redo ascent calculation to avoid int overflow.
1087 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1088 (lookup_image): Remove unnecessary tests.
1089 (xbm_image_p): Locals are now of int, not EMACS_INT,
1090 since parse_image_check makes sure they fit into int.
1091 (png_load, gif_load, svg_load_image):
1092 Prefer int to unsigned where either will do.
1093 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1094 old tiff_error_handler and tiff_warning_handler.
1095 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1096 stack buffer overflows. It uses only the features of vsnprintf
1097 that are common to both POSIX and native Microsoft.
1098 (tiff_error_handler, tiff_warning_handler): Use it.
1099 (tiff_load, gif_load, imagemagick_load_image):
1100 Don't assume :index value fits in 'int'.
1101 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1102 (imagemagick_load_image): Check that crop parameters fit into
1103 the integer types that MagickCropImage accepts. Don't assume
1104 Vimagemagick_render_type has a nonnegative value. Don't assume
1105 size_t fits in 'long'.
1106 (gs_load): Use printmax_t to print the widest integers possible.
1107 Check for integer overflow when computing image height and width.
1108
c11821d4
EZ
11092011-08-26 Eli Zaretskii <eliz@gnu.org>
1110
1111 * xdisp.c (redisplay_window): Don't force window start if point
1112 will be invisible in the resulting window. (Bug#9324)
1113
0c95fcf7
EZ
11142011-08-25 Eli Zaretskii <eliz@gnu.org>
1115
1116 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1117 the display spec is of the form `(space ...)'.
1118 (handle_display_spec): Return the value returned by
1119 handle_single_display_spec, not just 1 or zero.
1120 (handle_single_display_spec): If the display spec is of the form
1121 `(space ...)', and specifies display in the text area, return 2
1122 rather than 1.
fee65a97 1123 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1124 accurately, and prefer exact match for point under bidi.
1125 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1126
1127 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1128 into disp_prop; all users changed.
1129
1130 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1131 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1132 for the text covered by the display property.
1133
e4ed06f1
CY
11342011-08-25 Chong Yidong <cyd@stupidchicken.com>
1135
1136 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1137 Change return value to nil.
1138 (Frecord_buffer): Delete unused function.
1139
f67cdd7f
EZ
11402011-08-24 Eli Zaretskii <eliz@gnu.org>
1141
5980d4c6
EZ
1142 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1143 buffers, return left-to-right.
8610fe8b
EZ
1144 (set_cursor_from_row): Consider candidate row a win if its glyph
1145 represents a newline and point is on that newline. Fixes cursor
1146 positioning on the newline at EOL of R2L text within L2R
1147 paragraph, and vice versa.
1148 (try_cursor_movement): Check continued rows, in addition to
1149 continuation rows. Fixes unwarranted scroll when point enters a
1150 continued line of R2L text within an L2R paragraph, or vice versa.
1151 (cursor_row_p): Consider the case of point being equal to
1152 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1153 from the end of a short line to the beginning of a continued line
1154 of R2L text within L2R paragraph.
1155 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1156 composed characters.
5980d4c6 1157
f67cdd7f
EZ
1158 * bidi.c (bidi_check_type): Use xassert.
1159 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1160 members.
1161
bca633fb
EZ
11622011-08-23 Eli Zaretskii <eliz@gnu.org>
1163
1164 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1165 a character.
1166
4a5885a7
CY
11672011-08-23 Chong Yidong <cyd@stupidchicken.com>
1168
1169 * nsfont.m (ns_otf_to_script): Fix typo.
1170
0902a04e
KH
11712011-08-22 Kenichi Handa <handa@m17n.org>
1172
1173 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1174 extra slot even if the purpose is char-code-property-table.
1175
1a2e6670
EZ
11762011-08-23 Eli Zaretskii <eliz@gnu.org>
1177
8ddde651
EZ
1178 * xdisp.c (redisplay_window): When computing centering_position,
1179 account for the height of the header line. (Bug#8874)
1180
425cc014
EZ
1181 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1182 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1183 candidate is selected by the mouse, and that candidate has a
1184 composed character under the mouse.
1185
1a2e6670
EZ
1186 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1187 coordinates reported by pos-visible-in-window-p for a composed
1188 character in column zero.
1189
8b76d6f8
SM
11902011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1191
1192 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1193
dac347dd
EZ
11942011-08-22 Eli Zaretskii <eliz@gnu.org>
1195
1196 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1197 consider it a hit if to_charpos is anywhere in the range of the
1198 composed buffer positions.
1199
e013fb34
CY
12002011-08-22 Chong Yidong <cyd@stupidchicken.com>
1201
1202 * image.c (gif_load): Don't assume that each subimage has the same
1203 dimensions as the base image. Handle disposal method that is
1204 "undefined" by the gif spec (Bug#9335).
1205
bd1ba3e8
CY
12062011-08-20 Chong Yidong <cyd@stupidchicken.com>
1207
1208 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1209 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1210
54a1215b
EZ
12112011-08-19 Eli Zaretskii <eliz@gnu.org>
1212
823564e5
EZ
1213 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1214 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1215 from an Org mode buffer to a Speedbar frame.
1216
54a1215b
EZ
1217 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1218 a composition, take its buffer position from IT->cmp_it.charpos.
1219 Fixes cursor positioning at the beginning of a line that begins
1220 with a composed character.
1221
9778ebcc
EZ
12222011-08-18 Eli Zaretskii <eliz@gnu.org>
1223
0be6ee06
EZ
1224 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1225 character bidirectional type, use STRONG_L instead. Fixes crashes
1226 in a buffer produced by `describe-categories'.
1227
9778ebcc
EZ
1228 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1229 members before the level stack, so they would be saved and
1230 restored when copying iterator state. Fixes incorrect reordering
1231 around TABs covered by display properties.
1232
156bffbe
AS
12332011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1234
1235 * process.c (Fnetwork_interface_list): Correctly determine buffer
1236 size.
1237
72ad093b
CY
12382011-08-17 Chong Yidong <cyd@stupidchicken.com>
1239
1240 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1241 (internal_condition_case_2, internal_condition_case_n):
1242 Remove unnecessary aborts (Bug#9081).
72ad093b 1243
35774242
EZ
12442011-08-17 Eli Zaretskii <eliz@gnu.org>
1245
1246 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1247 has no `load' handler, try opening the file locally. (Bug#9311)
1248
db76dd85
KB
12492011-08-16 Ken Brown <kbrown@cornell.edu>
1250
1251 * gmalloc.c: Expand comment.
1252
b215eee5
EZ
12532011-08-16 Eli Zaretskii <eliz@gnu.org>
1254
1255 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1256 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1257
a4579d33
KB
12582011-08-16 Ken Brown <kbrown@cornell.edu>
1259
1260 Fix memory allocation problems in Cygwin build (Bug#9273).
1261
1262 * unexcw.c ( __malloc_initialized): Declare external variable.
1263 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1264
8b76d6f8
SM
1265 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1266 New variables.
a4579d33
KB
1267 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1268 dumped emacs.
1269 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1270 in the static heap.
1271 [CYGWIN] (special_realloc): New function.
1272 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1273 requests to realloc storage in the static heap.
1274
3ebec551
PE
12752011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1276
1277 * bidi.c (bidi_initialize): Remove unused local.
1278
9fd8be00
EZ
12792011-08-15 Eli Zaretskii <eliz@gnu.org>
1280
474a8465
EZ
1281 * biditype.h: File removed.
1282
1283 * bidimirror.h: File removed.
1284
1285 * deps.mk (bidi.o): Remove biditype.h and
1286 bidimirror.h.
1287
1288 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1289 bidimirror.h.
1290
1291 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1292
1293 * chartab.c: Improve commentary for the uniprop_table API.
1294
32413314
EZ
1295 * bidi.c (bidi_paragraph_init): Support zero value of
1296 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1297 (bidi_initialize): Use uniprop_table instead of including
1298 biditype.h and bidimirror.h.
32413314 1299
9fd8be00
EZ
1300 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1301 coordinates of the iterator when restoring from ppos_it.
1302 (Bug#9296)
1303
5cf2b69b
KH
13042011-08-14 Kenichi Handa <handa@m17n.org>
1305
1306 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1307 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1308
daf17d00
EZ
13092011-08-14 Eli Zaretskii <eliz@gnu.org>
1310
1311 * xdisp.c (move_it_in_display_line_to): Don't invoke
1312 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1313 ppos_it. Fixes vertical cursor motion when line beginning is
1314 covered by an image. (Bug#9296)
1315
08e3161a
JD
13162011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1317
1318 * nsterm.h (ns_run_ascript): Declare.
1319 (NSAPP_DATA2_RUNASSCRIPT): Define.
1320
1321 * nsfns.m (as_script, as_result, as_status): New static variables.
1322 (ns_run_ascript): New function.
5e617bc2 1323 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1324 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1325 the event loop. Get status from as_status (Bug#7276).
1326
1327 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1328 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1329 the event loop (Bug#7276).
1330
a3720aa2
AS
13312011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1332
1333 * gnutls.c (QCgnutls_bootprop_priority)
1334 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1335 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1336 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1337 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1338 (QCgnutls_bootprop_verify_hostname_error)
1339 (QCgnutls_bootprop_callbacks_verify): Rename from
1340 Qgnutls_bootprop_..., all uses changed.
1341
1342 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1343 uses changed.
1344
0a0d27fb
PE
13452011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1346
19d5c50c
PE
1347 * xfaces.c (Qframe_set_background_mode): Now static.
1348 * dispextern.h (Qframe_set_background_mode): Remove decl.
1349
0a0d27fb
PE
1350 * process.c (Fnetwork_interface_info): Declare local only if needed.
1351
377538cb
JD
13522011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1353
1354 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1355 (Fnetwork_interface_list): Allocate in increments of bytes instead
1356 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1357 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1358 sockaddr.
1359 (struct ifflag_def): notrailers is smart on OSX.
1360 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1361 Get hardware address with getifaddrs if available.
1362
08fff70c
EZ
13632011-08-12 Eli Zaretskii <eliz@gnu.org>
1364
1365 * xdisp.c (iterate_out_of_display_property): xassert that
1366 IT->position is set to within IT->object's boundaries. Break from
1367 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1368 when IT->position is set up wrongly due to some bug.
1369 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1370 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1371 entry. Force push_it to save on the stack the current
1372 buffer/string position, to be restored by pop_it. Fix flags in
1373 the iterator structure wrt the object coming from a display
1374 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1375 properties. (Bug#9284)
1376
7be1c708 13772011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1378
7be1c708
CY
1379 * fontset.c (fontset_get_font_group): Add proper type checks.
1380 (Bug#9172)
aac0c6e3 1381
7be1c708 13822011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1383
7be1c708
CY
1384 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1385 and LC_VERSION_MIN_MACOSX.
1386 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1387 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1388
97bb72a6
EZ
13892011-08-08 Eli Zaretskii <eliz@gnu.org>
1390
1391 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1392 no-display-properties-and-no-overlays under bidi display.
1393 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1394 properties and overlays.
97bb72a6 1395
d5617611
CY
13962011-08-08 Chong Yidong <cyd@stupidchicken.com>
1397
37e11a63
CY
1398 * editfns.c (Fset_time_zone_rule): Document relationship with the
1399 setenv function.
1400
d5617611
CY
1401 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1402 the font entity extracted from the cache (Bug#8109).
1403
58872834
CY
14042011-08-07 Chong Yidong <cyd@stupidchicken.com>
1405
1406 * composite.c (autocmp_chars): Don't reset point. That is done by
1407 restore_point_unwind (Bug#5984).
1408
75bfc667
JL
14092011-08-07 Juri Linkov <juri@jurta.org>
1410
1411 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1412 to show the arg `TIME' instead of `TIMEVAL'.
1413
d1410150
EZ
14142011-08-06 Eli Zaretskii <eliz@gnu.org>
1415
1416 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1417 display property strides EOL and includes a newline, as in
1418 longlines-mode. (Bug#9254)
75b771e4
EZ
1419 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1420 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1421
1422 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1423 is non-zero, even if the data buffer is NULL. Fixes a crash in
1424 vertical-motion with longlines-mode. (Bug#9254)
1425
35928349
EZ
14262011-08-05 Eli Zaretskii <eliz@gnu.org>
1427
ec7cc85b
EZ
1428 * bidi.c <bidi_cache_total_alloc>: Now static.
1429 (bidi_initialize): Initialize bidi_cache_total_alloc.
1430
8b76d6f8 1431 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1432 cache. (Bug#9221)
1433
1434 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1435 amount allocated this far in `bidi_cache_total_alloc'.
1436 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1437 non-zero, only free the data buffer without restoring the cache
1438 contents. All callers changed.
1439
1440 * dispextern.h (bidi_unshelve_cache): Update prototype.
1441
1442 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1443 (move_it_in_display_line, move_it_to)
1444 (move_it_vertically_backward, move_it_by_lines): Replace the call
1445 to xfree to an equivalent call to bidi_unshelve_cache.
1446 (move_it_in_display_line_to): Fix logic of returning
412b6358 1447 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1448
e2e2423b
EZ
14492011-08-05 Eli Zaretskii <eliz@gnu.org>
1450
1451 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1452 came from a string character with a `cursor' property. (Bug#9229)
1453
ae9e757a
JD
14542011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1455
1456 * Makefile.in (LIB_PTHREAD): New variable.
1457 (LIBES): Add LIB_PTHREAD (Bug#9216).
1458
1459 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1460 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1461
213bd7f2
AS
14622011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1463
1464 * regex.c (re_iswctype): Remove some redundant boolean
1465 conversions.
1466
99aaf75f
JD
14672011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1468
1469 * xterm.c (x_find_topmost_parent): New function.
1470 (x_set_frame_alpha): Find topmost parent window with
1471 x_find_topmost_parent and set the property there also (bug#9181).
1472 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1473
c74e9d86
PE
14742011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1475
1476 * callproc.c (Fcall_process): Avoid vfork clobbering
1477 the local vars buffer, coding_systems, current_dir.
1478
640c8776
SM
14792011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1480
1481 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1482
f26d0e4c
PE
14832011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1484
8a10d76c
PE
1485 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1486 so that it is not optimized away.
1487
f26d0e4c
PE
1488 * xdisp.c (compute_display_string_pos): Remove unused local.
1489
55439c61
EZ
14902011-08-02 Eli Zaretskii <eliz@gnu.org>
1491
1492 Fix slow cursor motion and scrolling in large buffers with
1493 selective display, like Org Mode buffers. (Bug#9218)
1494
1495 * dispextern.h (struct bidi_it): New member disp_prop_p.
1496
1497 * xdisp.c: Remove one-slot cache of display string positions.
1498 (compute_display_string_pos): Accept an additional argument
5e617bc2 1499 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1500 for a display string or property. If found, set DISP_PROP_P
1501 non-zero.
1502
1503 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1504 DISP_PROP_P, and pass it to compute_display_string_pos.
1505 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1506 non-zero. All callers of bidi_fetch_char changed.
1507
fb33fa43
SM
15082011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1509
1510 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1511
b099e063
DM
15122010-12-03 Don March <don@ohspite.net>
1513
1514 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1515 last character M-[char] is translated to ESC [char] (bug#7541).
1516
5cc7f7af
KH
15172011-08-02 Kenichi Handa <handa@m17n.org>
1518
d0fffa3f 1519 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1520
1521 * chartab.c (uniprop_table): Make it non-static.
1522
525d5e6e
EZ
15232011-08-01 Eli Zaretskii <eliz@gnu.org>
1524
1525 * xdisp.c (forward_to_next_line_start): Accept additional argument
1526 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1527 on the newline.
1528 (reseat_at_next_visible_line_start): Use the bidi iterator state
1529 returned by forward_to_next_line_start to restore the state of
1530 it->bidi_it after backing up to previous newline. (Bug#9212)
1531
31011111
AS
15322011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1533
1534 * regex.c (re_comp): Protoize.
1535 (re_exec): Fix return type.
1536 (regexec): Fix type of `ret'. (Bug#9203)
1537
476371c4
PE
15382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1539
e5d76069
PE
1540 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1541 This is needed if max-image-size is a floating-point number.
1542
9a79b20c
AS
15432011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1544
1545 * print.c (print_object): Print empty symbol as ##.
1546
1547 * lread.c (read1): Read ## as empty symbol.
1548
d8c2fa78
AA
15492011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1550
1551 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1552 setting frame foreground color (Bug#9175).
1553 (x_set_background_color): Likewise.
1554
ffe57a7a
AA
1555 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1556 contents (Bug#9176).
1557 (EmacsTooltip -init): Remove bezels and add shadows to
1558 tooltip windows.
1559
bf3492a5
AA
1560 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1561 or scroll bar (Bug#8470).
1562
d55e9c53
AA
1563 * nsfont.m (nsfont_open): Remove assignment to voffset and
1564 unnecessary vars hshink, expand, hd, full_height, min_height.
1565 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1566
1567 * nsterm.h (nsfont_info): Remove voffset field.
1568
d8c2fa78 15692011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1570
1571 Implement strike-through and overline on NextStep (Bug#8863).
1572
1573 * nsfont.m (nsfont_open): Use underline position provided by font,
1574 instead of hard-coded value of 2.
1575 (nsfont_draw): Call ns_draw_text_decoration instead.
1576
1577 * nsterm.h: Add declaration for ns_draw_text_decoration.
1578
1579 * nsterm.m (ns_draw_text_decoration): New function for drawing
1580 underline, overline, and strike-through.
1581 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1582 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1583 accommodate underlining, etc.
4843aac3 1584
4cc60b9b
EZ
15852011-07-28 Eli Zaretskii <eliz@gnu.org>
1586
bc7ece87
EZ
1587 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1588 default.
4cc60b9b 1589
476371c4
PE
15902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1591
66606eea
PE
1592 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1593 Without this fix, if a signal arrives just after memory fills up,
1594 'malloc' might be invoked reentrantly.
1595
476371c4
PE
1596 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1597 In other words, assume that every image size is allowed, on non-X
1598 hosts. This assumption is probably wrong, but it lets Emacs compile.
1599
f3fcc40d
AS
16002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1601
1602 * regex.c (re_iswctype): Convert return values to boolean.
1603
350c992f
EZ
16042011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1605
1606 * xdisp.c (compute_display_string_pos): Don't use cached display
1607 string position if the buffer had its restriction changed.
1608 (Bug#9184)
1609
5266b4bb
PE
16102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1611
1612 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1613
2573a837 16142011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1615
41f55ccd 1616 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1617
39e378da
PE
1618 * bidi.c: Integer size and overflow fixes.
1619 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1620 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1621 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1622 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1623 (bidi_find_other_level_edge):
1624 Use ptrdiff_t instead of EMACS_INT where either will do.
1625 This works better on 32-bit hosts configured --with-wide-int.
1626 (bidi_cache_ensure_space): Check for size-calculation overflow.
1627 Use % rather than repeated addition, for better worst-case speed.
1628 Don't set bidi_cache_size until after xrealloc returns, because it
1629 might not return.
1630 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1631 (bidi_cache_ensure_space): Also check that the bidi cache size
1632 does not exceed that of the largest Lisp string or buffer. See Eli
1633 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1634
5e927815
PE
1635 * alloc.c (__malloc_size_t): Remove.
1636 All uses replaced by size_t. See Andreas Schwab's note
1637 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1638
ca4aa935
PE
1639 * image.c: Improve checking for integer overflow.
1640 (check_image_size): Assume that f is nonnull, since
1641 it is always nonnull in practice. This is one less thing to
1642 worry about when checking for integer overflow later.
1643 (x_check_image_size): New function, which checks for integer
1644 overflow issues inside X.
1645 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1646 This removes the need for a memory_full check.
1647 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1648 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1649 (xbm_read_bitmap_data): Change locals back to 'int', since
1650 their values must fit in 'int'.
1651 (xpm_load_image, png_load, tiff_load):
1652 Invoke x_create_x_image_and_pixmap earlier,
1653 to avoid much needless work if the image is too large.
1654 (tiff_load): Treat overly large images as if
1655 x_create_x_image_and_pixmap failed, not as malloc failures.
1656 (gs_load): Use x_check_image_size.
1657
5f8f9cc2
PE
1658 * gtkutil.c: Omit integer casts.
1659 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1660 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1661
5adf60bc
PE
1662 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1663
c8907a93
PE
1664 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1665 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1666 would wrongly return t on a 64-bit host.
1667
e3c25c68
PE
1668 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1669 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1670 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1671 and therefore cause GCC to emit a bogus diagnostic in some cases.
1672
3f791afe
PE
1673 * image.c: Integer signedness and overflow and related fixes.
1674 This is not an exhaustive set of fixes, but it's time to
1675 record what I've got.
1676 (lookup_pixel_color, check_image_size): Remove redundant decls.
1677 (check_image_size): Don't assume that arbitrary EMACS_INT values
1678 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1679 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1680 (tiff_load, imagemagick_load_image):
1681 Check for overflow in size calculations.
1682 (x_create_x_image_and_pixmap): Remove unnecessary test for
1683 xmalloc returning NULL; that can't happen.
1684 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1685 (xpm_color_bucket): Use better integer hashing function.
1686 (xpm_cache_color): Don't possibly over-allocate memory.
1687 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1688 (gif_memory_source):
1689 Use ptrdiff_t, not int or size_t, to record sizes.
1690 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1691 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1692 either works, as we prefer signed integers.
1693 (tiff_read_from_memory, tiff_write_from_memory):
1694 Return tsize_t, not size_t, since that's what the TIFF API wants.
1695 (tiff_read_from_memory): Don't fail simply because the read would
1696 go past EOF; instead, return a short read.
1697 (tiff_load): Omit no-longer-needed casts.
1698 (Fimagemagick_types): Don't assume size fits into 'int'.
1699
3cc5a532
PE
1700 Improve hashing quality when configured --with-wide-int.
1701 * fns.c (hash_string): New function, taken from sxhash_string.
1702 Do not discard information about ASCII character case; this
1703 discarding is no longer needed.
1704 (sxhash-string): Use it. Change sig to match it. Caller changed.
1705 * lisp.h: Declare it.
1706 * lread.c (hash_string): Remove, since we now use fns.c's version.
1707 The fns.c version returns a wider integer if --with-wide-int is
1708 specified, so this should help the quality of the hashing a bit.
1709
b312a492
PE
1710 * emacs.c: Integer overflow minor fix.
1711 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1712 Define only if GNU_LINUX.
1713 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1714
dfd153ae
PE
1715 * dispnew.c: Integer signedness and overflow fixes.
1716 Remove unnecessary forward decls, that were a maintenance hassle.
1717 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1718 All uses changed.
1719 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1720 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1721 (prepare_desired_row, line_draw_cost):
1722 Use int, not unsigned, where either works.
1723 (save_current_matrix, restore_current_matrix):
1724 Use ptrdiff_t, not size_t, where either works.
1725 (init_display): Check for overflow more accurately, and without
1726 relying on undefined behavior.
1727
a81d11a3
PE
1728 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1729 Remove, replacing with the new symbols in lisp.h. All uses changed.
1730 * fileio.c (make_temp_name):
1731 * filelock.c (lock_file_1, lock_file):
1732 * xdisp.c (message_dolog):
1733 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1734 Use pMd etc. instead.
1735 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1736 replacing the pWIDE etc. symbols removed from editfns.c.
1737
3300e6fd
PE
1738 * keyboard.h (num_input_events): Now uintmax_t.
1739 This is (very slightly) less likely to mess up due to wraparound.
1740 All uses changed.
1741
fd05c7e9
PE
1742 * buffer.c: Integer signedness fixes.
1743 (alloc_buffer_text, enlarge_buffer_text):
1744 Use ptrdiff_t rather than size_t when either will do, as we prefer
1745 signed integers.
1746
903fe15d
PE
1747 * alloc.c: Integer signedness and overflow fixes.
1748 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1749 (__malloc_size_t): Default to size_t, not to int.
1750 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1751 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1752 Prefer ptrdiff_t to size_t when either would do, as we prefer
1753 signed integers.
1754 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1755 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1756 Now const. Initialize with values that are in range even if char
1757 is signed.
1758 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1759 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1760 These functions do the right thing with sizes > 2**32.
1761 (check_depth): Now ptrdiff_t, not int.
1762 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1763 Adjust to new way of storing sizes. Check for size overflow bugs
1764 in rest of code.
1765 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1766 slightly wrong anyway, as it missed one instance of
1767 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1768 (refill_memory_reserve): Omit needless cast to size_t.
1769 (mark_object_loop_halt): Mark as externally visible.
1770
ac82cc6a
PE
1771 * xselect.c: Integer signedness and overflow fixes.
1772 (Fx_register_dnd_atom, x_handle_dnd_message):
1773 Use ptrdiff_t, not size_t, since we prefer signed.
1774 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1775 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1776 x_dnd_atoms_size and x_dnd_atoms_length.
1777
c2d1e36d
PE
1778 * doprnt.c: Prefer signed to unsigned when either works.
1779 * eval.c (verror):
1780 * doprnt.c (doprnt):
1781 * lisp.h (doprnt):
1782 * xdisp.c (vmessage):
1783 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1784 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1785 prefer signed arithmetic to avoid comparison confusion.
1786 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1787 but is a bit tricky.
1788
0e926e56
PE
1789 Assume freestanding C89 headers, string.h, stdlib.h.
1790 * data.c, doprnt.c, floatfns.c, print.c:
1791 Include float.h unconditionally.
1792 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1793 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1794 * regex.c: Likewise for stddef.h, string.h.
1795 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1796 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1797 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1798 (STDC_HEADERS): Remove obsolete defines.
1799 * sysdep.c: Include limits.h unconditionally.
1800
9cfdb3ec
PE
1801 Assume support for memcmp, memcpy, memmove, memset.
1802 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1803 * regex.c (memcmp, memcpy):
1804 Remove; we assume C89 now.
1805
1806 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1807 (__malloc_safe_bcopy): Remove; no longer needed.
1808
cf950e6b 1809 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1810 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1811 well either way, and we prefer signed to unsigned.
1812
dbf38e02
LMI
18132011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1814
1815 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1816 closes the connection while we're reading (bug#9182).
1817
d6f0886c 18182011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1819
d6f0886c
JD
1820 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1821 are specified (Bug#9168).
24e0f6b1 1822
2eb1f9e6
PE
18232011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1824
1825 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1826 Found by GCC static checking and --with-wide-int on a 32-bit host.
1827
22381272 18282011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1829
1830 * xdisp.c (compute_display_string_pos): Fix logic of caching
1831 previous display string position. Initialize cached_prev_pos to
1832 -1. Fixes slow-down at the beginning of a buffer.
1833
f25e39b4
EZ
18342011-07-24 Eli Zaretskii <eliz@gnu.org>
1835
1836 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1837 for attrs[LFACE_FONTSET_INDEX].
1838
04c4b52e
PE
18392011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1840
1841 * xml.c (parse_region): Remove unused local
1842 that was recently introduced.
1843
c1734fbd
EZ
18442011-07-23 Eli Zaretskii <eliz@gnu.org>
1845
be18c5a5
EZ
1846 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1847 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1848
c1734fbd
EZ
1849 * xdisp.c (move_it_in_display_line_to): Record the best matching
1850 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1851 exit if none of the characters scanned was an exact match.
1852 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1853 when exact match is impossible due to invisible text, and the
1854 lines are truncated.
1855
a258d627
JD
18562011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1857
1858 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1859 for OSX >= 10.7.
1860
b6d5a689
EZ
18612011-07-22 Eli Zaretskii <eliz@gnu.org>
1862
0f74f785
EZ
1863 Fix a significant slow-down of cursor motion with C-n, C-p,
1864 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1865 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1866 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1867 (next_element_from_buffer): Call compute_stop_pos_backwards to
1868 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1869 base_level_stop.
1870 (reseat): Don't look for prev_stop, as that could mean a very long
1871 run.
1872 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1873 <cached_disp_overlay_modiff>: Cache for last found display string
1874 position.
551918c1 1875 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1876 about the same buffer in the same area of character positions, and
1877 the buffer wasn't changed since the time the display string
1878 position was cached.
551918c1 1879
b2d0c91a
EZ
18802011-07-22 Eli Zaretskii <eliz@gnu.org>
1881
1882 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1883 is an integer, which is important for empty lines. (Bug#9149)
1884
043604ee
CY
18852011-07-22 Chong Yidong <cyd@stupidchicken.com>
1886
1887 * frame.c (Fmodify_frame_parameters): In tty case, update the
1888 default face if necessary (Bug#4238).
1889
da4adb04
CY
18902011-07-21 Chong Yidong <cyd@stupidchicken.com>
1891
1892 * editfns.c (Fstring_to_char): No need to explain what a character
1893 is in the docstring (Bug#6576).
1894
9abd0532
LMI
18952011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1896
1897 * xml.c (parse_region): Make sure we always return a tree.
1898
36881d16
HK
18992011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1900
1901 * xml.c (parse_region): If a document contains only comments,
1902 return that, too.
1903
1e98674d
LMI
19042011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1905
1906 * xml.c (make_dom): Return comments, too.
1907
590bd467
PE
19082011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1909
1910 Port to OpenBSD.
1911 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1912 and the surrounding thread.
1913 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1914 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1915 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1916 timer goes off.
1917 * s/openbsd.h (BROKEN_SIGIO): Define.
1918 * unexelf.c (unexec) [__OpenBSD__]:
1919 Don't update the .mdebug section of the Alpha COFF symbol table.
1920
f41628b2
LMI
19212011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1922
1923 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1924 (bug#8460).
1925
b59b67c5
PE
19262011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1927
15e3a074
PE
1928 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1929 This fixes some race conditions on the permissions of any newly
1930 created file.
1931
41bed37d
PE
1932 * alloc.c (valid_pointer_p): Use pipe, not open.
1933 This fixes some permissions issues when debugging.
1934
b59b67c5
PE
1935 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1936 If fchown fails to set both uid and gid, try to set just gid,
1937 as that is sometimes allowed. Adjust the file's mode to eliminate
1938 setuid or setgid bits that are inappropriate if fchown fails.
1939
925a6be7
SM
19402011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1941
1942 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1943 to compare Lisp_Objects.
1944 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1945 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1946 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1947
52968808
AS
19482011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1949
0a6a104b
AS
1950 * lread.c (read_integer): Unread even EOF character.
1951 (read1): Likewise. Properly record start position of symbol.
1952
52968808
AS
1953 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1954 symbol character follows.
1955
9e381cdd
PE
19562011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1957
1958 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1959 This works around a problem with the previous change to Fcopy_file.
1960 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1961 and without this change, GCC might complain about discarding
1962 fchown's return value.
1963
b5641435
JB
19642011-07-16 Juanma Barranquero <lekktu@gmail.com>
1965
1966 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1967
a8031457
PE
19682011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1969
1970 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1971
dd889327
LMI
19722011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1973
750c33f7
LMI
1974 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1975 it's used from the C level.
1976
dd889327
LMI
1977 * process.c: Use the same condition for POLL_FOR_INPUT in both
1978 keyboard.c and process.c (bug#1858).
1979
87e86684
LM
19802011-07-09 Lawrence Mitchell <wence@gmx.li>
1981
1982 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1983 (Fgnutls_boot): Use it.
1984
64348f40
AS
19852011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1986
1987 * doc.c (Fsubstitute_command_keys): Revert last change.
1988
1d698799
LMI
19892011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1990
f863868c
LMI
1991 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1992 quotes the next character, and doesn't affect other longer
1993 sequences (bug#8935).
1994
1d698799
LMI
1995 * lread.c (syms_of_lread): Clarify that is isn't only
1996 `eval-buffer' and `eval-defun' that's affected by
1997 `lexical-binding' (bug#8460).
1998
aa4b6df6
EZ
19992011-07-15 Eli Zaretskii <eliz@gnu.org>
2000
2001 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2002 bidi redisplay when a line includes both an image and is
2003 truncated.
2004
5d856da6
PE
20052011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2006
ad6042bb
PE
2007 Fix minor problems found by static checking.
2008 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2009 (elsz): Now a signed constant, not a size_t var. We prefer signed
2010 types to unsigned, to avoid integer comparison confusion. Without
2011 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2012 "cannot optimize loop, the loop counter may overflow", a symptom
2013 of the confusion.
f00bbb22 2014 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2015 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2016
6468f31c
LMI
20172011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2018
49080b10
LMI
2019 * search.c (Fre_search_backward): Mention `case-fold-search' in
2020 all the re_search_* functions (bug#8138).
2021
6468f31c
LMI
2022 * keyboard.c (Fopen_dribble_file): Document when the file is
2023 closed (bug#8056).
2024
c965adc5
EZ
20252011-07-14 Eli Zaretskii <eliz@gnu.org>
2026
df9733bf
EZ
2027 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2028 bidi_cache_idx.
2029
0bb23927
EZ
2030 Support bidi reordering of display and overlay strings.
2031 * xdisp.c (compute_display_string_pos)
2032 (compute_display_string_end): Accept additional argument STRING.
2033 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2034 (reseat_to_string): Initialize bidi_it->string.s and
2035 bidi_it->string.schars.
2036 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2037 NULL (avoids a crash in bidi_paragraph_init).
2038 Initialize itb.string.lstring.
0bb23927
EZ
2039 (init_iterator): Call bidi_init_it only of a valid
2040 buffer position was specified. Initialize paragraph_embedding to
2041 L2R.
2042 (reseat_to_string): Initialize the bidi iterator.
2043 (display_string): If we need to ignore text properties of
2044 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2045 original value of -1 will not work with bidi.)
2046 (compute_display_string_pos): First arg is now struct
2047 `text_pos *'; all callers changed. Support display properties on
2048 Lisp strings.
2049 (compute_display_string_end): Support display properties on Lisp
2050 strings.
2051 (init_iterator, reseat_1, reseat_to_string): Initialize the
2052 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2053 when iterating on a string not from display properties).
640c8776
SM
2054 (compute_display_string_pos, compute_display_string_end):
2055 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2056 arrow keys.
2057 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2058 base_level_stop; instead, set base_level_stop to BEGV.
2059 Fixes crashes in vertical-motion.
0bb23927
EZ
2060 (next_element_from_buffer): Improve commentary for when
2061 the iterator is before prev_stop.
2062 (init_iterator): Initialize bidi_p from the default value of
2063 bidi-display-reordering, not from buffer-local value. Use the
2064 buffer-local value only if initializing for buffer iteration.
2065 (handle_invisible_prop): Support invisible properties on strings
2066 that are being bidi-reordered.
2067 (set_iterator_to_next): Support bidi reordering of C strings and
2068 Lisp strings.
2069 (next_element_from_string): Support bidi reordering of Lisp
2070 strings.
2071 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2072 (display_string): Support display of R2L glyph rows.
2073 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2074 (init_iterator): Don't initialize it->bidi_p for strings
2075 here.
2076 (reseat_to_string): Initialize it->bidi_p for strings here.
2077 (next_element_from_string, next_element_from_c_string)
2078 (next_element_from_buffer): Add xassert's for correspondence
2079 between IT's object being iterated and it->bidi_it.string
2080 structure.
2081 (face_before_or_after_it_pos): Support bidi iteration.
2082 (next_element_from_c_string): Handle the case of the first string
2083 character that is not the first one in the visual order.
2084 (get_visually_first_element): New function, refactored from common
2085 parts of next_element_from_buffer, next_element_from_string, and
2086 next_element_from_c_string.
2087 (tool_bar_lines_needed, redisplay_tool_bar)
2088 (display_menu_bar): Force left-to-right direction. Add a FIXME
2089 comment for making that be controlled by a user option.
2090 (push_it, pop_it): Save and restore the state of the
2091 bidi iterator. Save and restore the bidi_p flag.
2092 (pop_it): Iterate out of display property for string iteration as
2093 well.
2094 (iterate_out_of_display_property): Support iteration over strings.
2095 (handle_single_display_spec): Set up it->bidi_it for iteration
2096 over a display string, and call bidi_init_it.
2097 (handle_single_display_spec, next_overlay_string)
2098 (get_overlay_strings_1, push_display_prop): Set up the bidi
2099 iterator for displaying display or overlay strings.
2100 (forward_to_next_line_start): Don't use the shortcut if
2101 bidi-iterating.
2102 (back_to_previous_visible_line_start): If handle_display_prop
2103 pushed the iterator stack, restore the internal state of the bidi
2104 iterator by calling bidi_pop_it same number of times.
2105 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2106 and we are bidi-iterating, don't decrement the iterator position;
2107 instead, set the first_elt flag in the bidi iterator, to produce
2108 the same effect.
2109 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2110 (push_display_prop): xassert that we are iterating a buffer.
2111 (push_it, pop_it): Save and restore paragraph_embedding member.
2112 (handle_single_display_spec, next_overlay_string)
2113 (get_overlay_strings_1, reseat_1, reseat_to_string)
2114 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2115 correctly. Don't assume unibyte strings are not bidi-reordered.
2116 (compute_display_string_pos)
2117 (compute_display_string_end): Fix handling the case of C string.
2118 (push_it, pop_it): Save and restore from_disp_prop_p.
2119 (handle_single_display_spec, push_display_prop): Set the
2120 from_disp_prop_p flag.
2121 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2122 (pop_it): Call iterate_out_of_display_property only if we are
2123 popping after iteration over a string that came from a display
2124 property. Fix a typo in popping stretch info. Add an assertion
2125 for verifying that the iterator position is in sync with the bidi
2126 iterator.
2127 (handle_single_display_spec, get_overlay_strings_1)
2128 (push_display_prop): Fix initialization of paragraph direction for
2129 string when that of the parent object is not yet determined.
2130 (reseat_1): Call bidi_init_it to resync the bidi
2131 iterator with IT's position. (Bug#7616)
2132 (find_row_edges): If ROW->start.pos gives position
2133 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2134 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2135 Reset the from_disp_prop_p flag.
2136 (SAVE_IT, RESTORE_IT): New macros.
2137 (pos_visible_p, face_before_or_after_it_pos)
2138 (back_to_previous_visible_line_start)
2139 (move_it_in_display_line_to, move_it_in_display_line)
2140 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2141 (try_scrolling, redisplay_window, display_line): Use them when
2142 saving a temporary copy of the iterator and restoring it back.
2143 (back_to_previous_visible_line_start, reseat_1)
2144 (init_iterator): Empty the bidi cache "stack".
2145 (move_it_in_display_line_to): If iterator ended up at
2146 EOL, but we never saw any buffer positions smaller than
2147 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2148 motion in bidi-reordered lines.
2149 (move_it_in_display_line_to): Record prev_method and prev_pos
2150 immediately before the call to set_iterator_to_next. Fixes cursor
2151 motion in bidi-reordered lines with stretch glyphs and strings
2152 displayed in margins. (Bug#8133) (Bug#8867)
2153 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2154 TO_CHARPOS.
640c8776
SM
2155 (pos_visible_p): Support positions in bidi-reordered lines.
2156 Save and restore bidi cache.
0bb23927
EZ
2157
2158 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2159 (bidi_paragraph_info): Delete unused struct.
2160 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2161 (bidi_cache_start): New variable.
2162 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2163 to zero.
2164 (bidi_cache_fetch_state, bidi_cache_search)
2165 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2166 (bidi_cache_find, bidi_peek_at_next_level)
2167 (bidi_level_of_next_char, bidi_find_other_level_edge)
2168 (bidi_move_to_visually_next): Compare cache index with
2169 bidi_cache_start rather than with zero.
2170 (bidi_fetch_char): Accept new argument STRING; all callers
2171 changed. Support iteration over a string. Support strings with
2172 display properties. Support unibyte strings. Fix the type of
2173 `len' according to what STRING_CHAR_AND_LENGTH expects.
2174 (bidi_paragraph_init, bidi_resolve_explicit_1)
2175 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2176 (bidi_level_of_next_char, bidi_move_to_visually_next):
2177 Support iteration over a string.
0bb23927
EZ
2178 (bidi_set_sor_type, bidi_resolve_explicit_1)
2179 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2180 can now be zero (for strings); special values 0 and -1 were
2181 changed to -1 and -2, respectively.
2182 (bidi_char_at_pos): New function.
2183 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2184 Call it instead of FETCH_MULTIBYTE_CHAR.
2185 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2186 initialized to valid values.
2187 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2188 values.
2189 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2190 the test for valid cached positions. Fix the logic for looking up
2191 the sentinel state in the cache. GCPRO the Lisp string we are
2192 iterating.
2193 (bidi_push_it, bidi_pop_it): New functions.
2194 (bidi_initialize): Initialize the bidi cache start stack pointer.
2195 (bidi_cache_ensure_space): New function, refactored from part of
2196 bidi_cache_iterator_state. Don't assume the required size is just
2197 one BIDI_CACHE_CHUNK away.
2198 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2199 (bidi_count_bytes, bidi_char_at_pos): New functions.
2200 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2201 always valid if bidi_cache_idx is valid.
2202 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2203 is valid if it's going to be used.
2204 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2205 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2206 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2207 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2208 (bidi_find_other_level_edge, bidi_cache_start_stack):
2209 All variables related to cache indices are now EMACS_INT.
c965adc5 2210
0bb23927
EZ
2211 * dispextern.h (struct bidi_string_data): New structure.
2212 (struct bidi_it): New member `string'. Make flag members be 1-bit
2213 fields, and put them last in the struct.
640c8776
SM
2214 (compute_display_string_pos, compute_display_string_end):
2215 Update prototypes.
0bb23927
EZ
2216 (bidi_push_it, bidi_pop_it): Add prototypes.
2217 (struct iterator_stack_entry): New members bidi_p,
2218 paragraph_embedding, and from_disp_prop_p.
2219 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2220 (bidi_shelve_cache, bidi_unshelve_cache):
2221 Declare prototypes.
0bb23927
EZ
2222
2223 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2224 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2225 and vector-like objects.
2226
2227 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2228 cache around display iteration.
2229
2230 * window.c (Fwindow_end, window_scroll_pixel_based)
2231 (displayed_window_lines, Frecenter): Save and restore the bidi
2232 cache around display iteration.
2233
3bbd2265
LMI
22342011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2235
2236 * editfns.c (Fdelete_region): Clarify the use of the named
2237 parameters (bug#6788).
2238
adc47434
MR
22392011-07-14 Martin Rudalics <rudalics@gmx.at>
2240
2241 * indent.c (Fvertical_motion): Set and restore w->pointm when
2242 saving and restoring the window's buffer (Bug#9006).
2243
837c31f8
LMI
22442011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2245
2246 * editfns.c (Fstring_to_char): Clarify just what is returned
2247 (bug#6576). Text by Eli Zaretskii.
2248
ac389d0c
JB
22492011-07-13 Juanma Barranquero <lekktu@gmail.com>
2250
2251 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2252
0be0ce47
EZ
22532011-07-13 Eli Zaretskii <eliz@gnu.org>
2254
2255 * buffer.c (mmap_find): Fix a typo.
2256
cd18e7e3
JB
22572011-07-13 Johan Bockgård <bojohan@gnu.org>
2258
2259 Fix execution of x selection hooks.
2260 * xselect.c (Qx_lost_selection_functions)
2261 (Qx_sent_selection_functions): New vars.
2262 (syms_of_xselect): DEFSYM them.
2263 (x_handle_selection_request): Pass Qx_sent_selection_functions
2264 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2265 (x_handle_selection_clear,x_clear_frame_selections):
2266 Pass Qx_lost_selection_functions rather than
2267 Vx_lost_selection_functions to Frun_hook_with_args.
2268
47ea7f44
PE
22692011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2270
ac389d0c 2271 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2272 The old code sometimes used this field without initializing it.
2273
47ea7f44
PE
2274 * alloc.c (gc_sweep): Don't read past end of array.
2275 In theory, the old code could also have corrupted Emacs internals,
2276 though it'd be very unlikely.
2277
bc985c87
AS
22782011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2279
2280 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2281 argument. (Bug#4026)
bc985c87 2282
0cf34688
LMI
22832011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2284
b3dadd76
LMI
2285 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2286 key" (bug#4257).
2287
0cf34688
LMI
2288 * window.c (Fset_window_start): Doc fix (bug#4199).
2289 (Fset_window_hscroll): Ditto.
2290
270768cd
PE
22912011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2292
077e3dda 2293 Fix minor new problems caught by GCC 4.6.1.
270768cd 2294 * term.c (init_tty): Remove unused local.
490011a6 2295 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2296 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2297 not used otherwise.
270768cd 2298
b1f58454
CY
22992011-07-12 Chong Yidong <cyd@stupidchicken.com>
2300
2301 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2302
22b9578d
LMI
23032011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2304
6e70ab07
LMI
2305 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2306 are the mini-buffer and the echo area (bug#3320).
2307
22b9578d
LMI
2308 * term.c (init_tty): Remove support for supdup, c10 and perq
2309 terminals, which are no longer supported (bug#1482).
2310
8974cc9f
JB
23112011-07-10 Johan Bockgård <bojohan@gnu.org>
2312
2313 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2314
a560d974
JD
23152011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2316
2317 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2318 for non-popups (Bug#3642).
2319
1dae0f0a
AS
23202011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2321
268c2c36 2322 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2323 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2324 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2325 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2326 * data.c (fmod): Likewise.
2327 * dispnew.c (swap_glyphs_in_rows): Likewise.
2328 * emacs.c (memory_warning_signal): Likewise.
2329 * floatfns.c (float_error): Likewise.
2330 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2331 (otf_open, font_otf_capability, generate_otf_features)
2332 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2333 Likewise.
2334 * image.c (pbm_read_file): Likewise.
2335 * indent.c (string_display_width): Likewise.
2336 * intervals.c (check_for_interval, search_for_interval)
2337 (inc_interval_count, count_intervals, root_interval)
2338 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2339 * lread.c (defalias): Likewise.
268c2c36 2340 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2341 * regex.c (set_image_of_range_1, set_image_of_range)
2342 (regex_grow_registers): Likewise.
2343 * sysdep.c (strerror): Likewise.
2344 * termcap.c (valid_filename_p, tprint, main): Likewise.
2345 * tparam.c (main): Likewise.
2346 * unexhp9k800.c (run_time_remap, save_data_space)
2347 (update_file_ptrs, read_header, write_header, calculate_checksum)
2348 (copy_file, copy_rest, display_header): Likewise.
2349 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2350 Likewise.
2351 * xdisp.c (check_it): Likewise.
2352 * xfaces.c (register_color, unregister_color, unregister_colors):
2353 Likewise.
2354 * xfns.c (print_fontset_result): Likewise.
2355 * xrdb.c (member, fatal, main): Likewise.
2356
99033785
PE
23572011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2358
2359 Fix minor problems found by static checking (Bug#9031).
2360 * chartab.c (char_table_set_range, map_sub_char_table):
2361 Remove unused locals.
2362 (uniprop_table): Now static.
2363 * composite.c (_work_char): Remove unused static var.
2364
9cb2ac56
JB
23652011-07-09 Juanma Barranquero <lekktu@gmail.com>
2366
2367 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2368
f25661f0
JD
23692011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2370
2371 * gtkutil.c (qttip_cb): Remove code without function.
2372
8278c4fe
EZ
23732011-07-09 Eli Zaretskii <eliz@gnu.org>
2374
2375 * w32.c (pthread_sigmask): New stub.
2376
1692ae2d 23772011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2378
8a6ebd58 2379 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2380 sigprocmask is portable only for single-threaded applications, and
2381 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2382 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2383 (LIBES): Use it.
2384 * callproc.c (Fcall_process):
2385 * process.c (create_process):
2386 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2387 Use pthread_sigmask, not sigprocmask.
123403e4 2388
1b854618
JD
23892011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2390
2391 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2392 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2393 wrong (Bug#8591).
2394
3fe4b549
JD
23952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2396
0ce7e563
JD
2397 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2398 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2399 (xg_hide_tooltip): Fix comment.
2400
3fe4b549
JD
2401 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2402 in registerServicesMenuSendTypes.
2403 (validRequestorForSendType): Don't check ns_return_types.
2404
2405 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2406 ns_return_type.
2407
5df75e47
JR
24082011-07-08 Jason Rumney <jasonr@gnu.org>
2409
2410 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2411 frame struct members of non-existent frames (Bug#6284).
2412
699c10bd
JD
24132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2414
4393663b
JD
2415 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2416 variable firstTime not needed on OSX >= 10.6.
2417 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2418 >= 10.5. Use setKnobProportion, setDoubleValue.
2419
2420 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2421 (MAC_OS_X_VERSION_10_5): Define if not defined.
2422 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2423 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2424 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2425
2426 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2427 cString and lossyCString on OSX >= 10.4
2428
2429 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2430 sizeToFit on OSX >= 10.2.
2431
2432 * nsimage.m (allocInitFromFile): Don't use deprecated method
2433 bestRepresentationForDevice on OSX >= 10.6.
2434
2435 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2436 to avoid warning.
2437
2438 * emacs.c: Declare unexec_init_emacs_zone.
2439
a63e0781
JD
2440 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2441
699c10bd
JD
2442 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2443
2444 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2445 on svcsMenu (Bug#8842).
2446
2447 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2448 ns_return_types.
2449 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2450
2451 * nsterm.m (QUTF8_STRING): Declare.
2452 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2453 (validRequestorForSendType): Return type is (id).
2454 Change indexOfObjectIdenticalTo to indexOfObject.
2455 Check if we have local selection before returning self (Bug#8842).
2456 (writeSelectionToPasteboard): Put local selection into paste board
2457 if we have a local selection (Bug#8842).
2458 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2459
2460 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2461 (ns_get_local_selection): Declare.
2462
54e10184
LMI
24632011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2464
9888ff71
LMI
2465 * keymap.c (describe_map_tree): Don't insert a double newline at
2466 the end of the buffer (bug#1169) and return whether we inserted
2467 something.
2468
54e10184
LMI
2469 * callint.c (Fcall_interactively): Change "reading args" to
2470 "providing args" to try to clarify what it does (bug#1010).
2471
15fa4783
KH
24722011-07-07 Kenichi Handa <handa@m17n.org>
2473
2474 * composite.c (composition_compute_stop_pos): Ignore a static
2475 composition starting before CHARPOS (Bug#8915).
2476
2477 * xdisp.c (handle_composition_prop): Likewise.
2478
a8815b00
EZ
24792011-07-07 Eli Zaretskii <eliz@gnu.org>
2480
2481 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2482 (Bug#9015)
2483
ef7b981d 24842011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2485
2486 * character.h (unicode_category_t): New enum type.
2487
2488 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2489 (Qchar_code_property_table): New variable.
2490 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2491 (UNIPROP_COMPRESSED_FORM_P): New macros.
2492 (char_table_ascii): Uncompress the compressed values.
2493 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2494 Uncompress the compressed values.
ac389d0c 2495 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2496 (char_table_ref_and_range): Uncompress the compressed values.
2497 (sub_char_table_set): New arg is_uniprop. Callers changed.
2498 Uncompress the compressed values.
2499 (sub_char_table_set_range): Args changed. Callers changed.
2500 (char_table_set_range): Adjuted for the above change.
2501 (map_sub_char_table): Delete args default_val and parent. Add arg
2502 top. Give decoded values to a Lisp function.
640c8776 2503 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2504 values to a Lisp function. Gcpro more variables.
2505 (uniprop_table_uncompress)
2506 (uniprop_decode_value_run_length): New functions.
2507 (uniprop_decoder, uniprop_decoder_count): New variables.
2508 (uniprop_get_decoder, uniprop_encode_value_character)
2509 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2510 New functions.
2511 (uniprop_encoder, uniprop_encoder_count): New variables.
2512 (uniprop_get_encoder, uniprop_table)
2513 (Funicode_property_table_internal, Fget_unicode_property_internal)
2514 (Fput_unicode_property_internal): New functions.
2515 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2516 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2517 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2518 char-code-property-alist.
2519
640c8776 2520 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2521 Vunicode_category_table.
2522
640c8776 2523 * font.c (font_range): Adjust for the change of
c805dec0
KH
2524 Vunicode_category_table.
2525
76b397fb
DN
25262011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2527
2528 * m/iris4d.h: Remove file, move contents ...
2529 * s/irix6-5.h: ... here.
2530
22b4128e
PE
25312011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2532
2533 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2534 * alloc.c (mark_buffer):
2535 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2536 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2537 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2538 This isn't true in general, and it's particularly not true
2539 if Emacs is configured with --with-wide-int.
2540 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2541 New macros, used in the buffer.c change.
2542
869795d6
JD
25432011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2544
2545 * xsettings.c: Use both GConf and GSettings if both are available.
2546 (store_config_changed_event): Add comment.
2547 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2548 (store_tool_bar_style_changed): New functions.
5e617bc2 2549 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2550 (struct xsettings): Move font inside HAVE_XFT.
2551 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2552 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2553 Move inside HAVE_XFT.
640c8776 2554 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2555 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2556 also.
2557 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2558 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2559 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2560 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2561 (parse_settings): Move check for font inside HAVE_XFT.
2562 (read_settings, apply_xft_settings): Add comment.
2563 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2564 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2565 call store_font_name_changed.
2566 (xft_settings_event): Add comment.
2567 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2568 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2569 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2570 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2571 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2572 (xsettings_get_system_font, xsettings_get_system_normal_font):
2573 Add comment.
869795d6 2574
d8ed26bd
PE
25752011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2576
2577 Random fixes. E.g., (random) never returned negative values.
2578 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2579 subseconds part to the entropy, as that's a bit more random.
2580 Prefer signed to unsigned, since the signedness doesn't matter and
2581 in general we prefer signed. When given a limit, use a
2582 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2583 latter isn't right if USE_2_TAGS_FOR_INTS.
2584 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2585 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2586
cabf1cac
SM
25872011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2588
2589 * textprop.c (text_property_stickiness):
2590 Obey Vtext_property_default_nonsticky.
2591 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2592 * w32fns.c (syms_of_w32fns):
2593 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2594
6e9b2be9
PE
25952011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2596
2597 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2598 This is more efficient than Ffile_directory_p and avoids a minor race.
2599
90186c68
LMI
26002011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2601
7c301272
LMI
2602 * buffer.c (Foverlay_put): Say what the return value is
2603 (bug#7835).
2604
c4f2d8d4
LMI
2605 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2606 is a directory before asking whether to use the file name
2607 (bug#7564).
ad637907
LMI
2608 (barf_or_query_if_file_exists): Make the "File is a directory"
2609 error be more correct.
c4f2d8d4 2610
90186c68
LMI
2611 * fns.c (Frequire): Remove the mention of the .gz files, since
2612 that's installation-specific, but keep the mention of
2613 `get-load-suffixes'.
2614
da64016e
PE
26152011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2616
2617 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2618 Report string overflow if the output is too long.
2619
7d47b580
JB
26202011-07-04 Juanma Barranquero <lekktu@gmail.com>
2621
a555cb87
JB
2622 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2623 (syms_of_gnutls): Remove duplicate DEFSYM for
2624 Qgnutls_bootprop_verify_hostname_error, an error for
2625 Qgnutls_bootprop_verify_error (which is no longer used).
2626
7d47b580
JB
2627 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2628 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2629 Also (re)move comments that are misplaced or no longer relevant.
2630
1e49bfab
LMI
26312011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2632
2633 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2634
1485f4c0
CY
26352011-07-03 Chong Yidong <cyd@stupidchicken.com>
2636
2637 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2638 and background color parameters if they have been changed.
2639
a9ab721e
LMI
26402011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2641
2642 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2643
cf7cff57
PE
26442011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2645
2e13213d
PE
2646 * xsettings.c (SYSTEM_FONT): Define only when used.
2647 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2648
cf7cff57
PE
2649 * keymap.c (access_keymap_1): Now static.
2650
7a8e04f7
CY
26512011-07-02 Chong Yidong <cyd@stupidchicken.com>
2652
2653 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2654 leave any prefix arg for the up event (Bug#1586).
2655
61352f62
LMI
26562011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2657
69bb1ef7
LMI
2658 * lread.c (syms_of_lread): Mention single symbols defined by
2659 `defvar' or `defconst' (bug#7154).
2660
61352f62 2661 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2662 (Frequire): Mention get-load-suffixes.
61352f62 2663
28545e04
MR
26642011-07-02 Martin Rudalics <rudalics@gmx.at>
2665
2666 * window.h (window): Remove clone_number slot.
2667 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2668 Remove.
2669 (make_parent_window, make_window, saved_window)
2670 (Fset_window_configuration, save_window_save): Don't deal with
2671 clone numbers.
2672 * buffer.c (Qclone_number): Remove declaration.
2673 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2674
3349e122
SM
26752011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2676
2677 Add multiple inheritance to keymaps.
2678 * keymap.c (Fmake_composed_keymap): New function.
2679 (Fset_keymap_parent): Simplify.
2680 (fix_submap_inheritance): Remove.
2681 (access_keymap_1): New function extracted from access_keymap to handle
2682 embedded parents and handle lists of maps.
2683 (access_keymap): Use it.
2684 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2685 (Fcopy_keymap): Handle embedded parents.
2686 (Fcommand_remapping, define_as_prefix): Simplify.
2687 (Fkey_binding): Simplify.
2688 (syms_of_keymap): Move minibuffer-local-completion-map,
2689 minibuffer-local-filename-completion-map,
2690 minibuffer-local-must-match-map, and
2691 minibuffer-local-filename-must-match-map to Elisp.
2692 (syms_of_keymap): Defsubr make-composed-keymap.
2693 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2694 (parse_menu_item): Trivial simplification.
2695
3279eb87
GM
26962011-07-01 Glenn Morris <rgm@gnu.org>
2697
2698 * Makefile.in (SETTINGS_LIBS): Fix typo.
2699
4550efdf
KI
27002011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2701
2702 * coding.c (Fencode_coding_string): Record the last coding system
2703 used, as the function doc string says (bug#8738).
2704
0949d2b6
JD
27052011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2706
2707 * xsettings.c (store_monospaced_changed): Take new font as arg and
2708 check for change against current_mono_font.
2709 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2710 (emacs_settings_constructor, emacs_settings_get_property)
2711 (emacs_settings_set_property, emacs_settings_class_init)
2712 (emacs_settings_init, gsettings_obj): Remove.
2713 (something_changedCB): New function for HAVE_GSETTINGS.
2714 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2715 with value as argument.
2716 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2717 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2718 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2719 "changed".
2720
2721 * xgselect.c: Add defined (HAVE_GSETTINGS).
2722 (xgselect_initialize): Ditto.
2723
2724 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2725 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2726 xg_select.
2727
bbc6b304
PE
27282011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2729
2730 * eval.c (struct backtrace): Simplify and port the data structure.
2731 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2732 signed bit field, as this assumption is not portable and it makes
2733 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2734 "char debug_on_exit : 1" as this is not portable either; instead,
2735 use the portable "unsigned int debug_on_exit : 1". Remove unused
2736 member evalargs. Remove obsolete comments about cc bombing out.
2737
9851bfc5
JD
27382011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2739
51bb811f 2740 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2741 Let HAVE_GSETTINGS override HAVE_GCONF.
2742 (store_monospaced_changed): New function.
2743 (EMACS_SETTINGS): A new type derived from GObject to handle
2744 GSettings notifications.
2745 (emacs_settings_constructor, emacs_settings_get_property)
2746 (emacs_settings_set_property, emacs_settings_class_init):
2747 New functions.
2748 (gsettings_client, gsettings_obj): New variables.
2749 (GSETTINGS_SCHEMA): New define.
2750 (something_changedCB): Call store_monospaced_changed.
2751 (init_gsettings): New function.
2752 (xsettings_initialize): Call init_gsettings.
2753 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2754 to NULL.
2755
640c8776 2756 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2757 GCONF_CFLAGS/LIBS.
2758
5386012d
MR
27592011-06-29 Martin Rudalics <rudalics@gmx.at>
2760
2761 * window.c (resize_root_window, grow_mini_window)
2762 (shrink_mini_window): Rename Qresize_root_window to
2763 Qwindow_resize_root_window and Qresize_root_window_vertically to
2764 Qwindow_resize_root_window_vertically.
2765
f13e0b08
PE
27662011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2767
2768 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2769
94515237
JB
27702011-06-27 Juanma Barranquero <lekktu@gmail.com>
2771
2772 * makefile.w32-in: Redesign dependencies so they reflect more
2773 clearly which files are directly included by each source file,
2774 and not through other includes.
2775
e43b6e43
MR
27762011-06-27 Martin Rudalics <rudalics@gmx.at>
2777
2778 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2779 (sort_overlays, overlay_strings): When an overlay's clone number
2780 matches the window's clone number process the overlay even if
2781 the overlay's window property doesn't match the current window.
2782
d68443dc
MR
2783 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2784 (Fwindow_hchild): Rename to Fwindow_left_child.
2785 (Fwindow_next): Rename to Fwindow_next_sibling.
2786 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2787 (resize_window_check): Rename to window_resize_check.
2788 (resize_window_apply): Rename to window_resize_apply.
2789 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2790 (Fdelete_other_windows_internal, resize_frame_windows)
2791 (Fsplit_window_internal, Fdelete_window_internal)
2792 (grow_mini_window, shrink_mini_window)
2793 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2794
c7e73be5
JD
27952011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2796
2797 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2798 (emacs_fixed_set_min_size): Remove.
2799 (emacs_fixed_new): Take frame as argument.
2800
2801 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2802 (_EmacsFixedPrivate): Remove minwidth/height.
2803 Add struct frame *f.
2804 (emacs_fixed_init): Initialize priv->f.
2805 (get_parent_class, emacs_fixed_set_min_size): Remove.
2806 (emacs_fixed_new): Set priv->f to argument.
2807 (emacs_fixed_get_preferred_width)
2808 (emacs_fixed_get_preferred_height): Use min_width/height from
2809 frames size_hint to set minimum and natural (Bug#8919).
2810 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2811 and use min_width/height from frames size_hint to set
2812 min_width/height (Bug#8919).
2813
2814 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2815 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2816 Fix indentation.
c7e73be5 2817
cf99dcf8
EZ
28182011-06-26 Eli Zaretskii <eliz@gnu.org>
2819
2820 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2821 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2822 called at ZV.
2823
029529ac
CY
28242011-06-26 Chong Yidong <cyd@stupidchicken.com>
2825
2826 * process.c (wait_reading_process_output): Bypass select if
2827 waiting for a cell while ignoring keyboard input, and input is
2828 pending. Suggested by Jan Djärv (Bug#8869).
2829
7a7ef429
PE
28302011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2831
2832 Use gnulib's dup2 module instead of rolling our own.
2833 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2834
11fdef7d 28352011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2836
2837 * dispnew.c (scrolling_window): Before scrolling, turn off a
2838 mouse-highlight in the window being scrolled.
2839
cd3520a4
JB
28402011-06-24 Juanma Barranquero <lekktu@gmail.com>
2841
2842 Move DEFSYM to lisp.h and use everywhere.
2843
2844 * character.h (DEFSYM): Move declaration...
2845 * lisp.h (DEFSYM): ...here.
2846
2847 * gnutls.c:
2848 * minibuf.c:
2849 * w32menu.c:
2850 * w32proc.c:
2851 * w32select.c: Don't include character.h.
2852
2853 * alloc.c (syms_of_alloc):
2854 * buffer.c (syms_of_buffer):
2855 * bytecode.c (syms_of_bytecode):
2856 * callint.c (syms_of_callint):
2857 * casefiddle.c (syms_of_casefiddle):
2858 * casetab.c (init_casetab_once):
2859 * category.c (init_category_once, syms_of_category):
2860 * ccl.c (syms_of_ccl):
2861 * cmds.c (syms_of_cmds):
2862 * composite.c (syms_of_composite):
2863 * dbusbind.c (syms_of_dbusbind):
2864 * dired.c (syms_of_dired):
2865 * dispnew.c (syms_of_display):
2866 * doc.c (syms_of_doc):
2867 * editfns.c (syms_of_editfns):
2868 * emacs.c (syms_of_emacs):
2869 * eval.c (syms_of_eval):
2870 * fileio.c (syms_of_fileio):
2871 * fns.c (syms_of_fns):
2872 * frame.c (syms_of_frame):
2873 * fringe.c (syms_of_fringe):
2874 * insdel.c (syms_of_insdel):
2875 * keymap.c (syms_of_keymap):
2876 * lread.c (init_obarray, syms_of_lread):
2877 * macros.c (syms_of_macros):
2878 * msdos.c (syms_of_msdos):
2879 * print.c (syms_of_print):
2880 * process.c (syms_of_process):
2881 * search.c (syms_of_search):
2882 * sound.c (syms_of_sound):
2883 * syntax.c (init_syntax_once, syms_of_syntax):
2884 * terminal.c (syms_of_terminal):
2885 * textprop.c (syms_of_textprop):
2886 * undo.c (syms_of_undo):
2887 * w32.c (globals_of_w32):
2888 * window.c (syms_of_window):
2889 * xdisp.c (syms_of_xdisp):
2890 * xfaces.c (syms_of_xfaces):
2891 * xfns.c (syms_of_xfns):
2892 * xmenu.c (syms_of_xmenu):
2893 * xsettings.c (syms_of_xsettings):
2894 * xterm.c (syms_of_xterm): Use DEFSYM.
2895
4228cf16
TZ
28962011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2897
cd3520a4 2898 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2899
7fcccf1e
PE
29002011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2901
7efb4e0e
PE
2902 Integer and buffer overflow fixes (Bug#8873).
2903
ff5844ad
PE
2904 * print.c (printchar, strout): Check for string overflow.
2905 (PRINTPREPARE, printchar, strout):
2906 Don't set size unless allocation succeeds.
2907
90532f02
PE
2908 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2909 for sizes. Check for string overflow more accurately.
2910 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2911
6d84508d
PE
2912 * macros.c: Integer and buffer overflow fixes.
2913 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2914 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2915 Use ptrdiff_t, not int, for sizes.
2916 Don't increment bufsize until after realloc succeeds.
2917 Check for size-calculation overflow.
2918 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2919
437b2cb4
PE
2920 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2921
8b9ac8b4
PE
2922 * lread.c: Integer overflow fixes.
2923 (read_integer): Radix is now EMACS_INT, not int,
2924 to improve quality of diagnostics for out-of-range radices.
2925 Calculate buffer size correctly for out-of-range radices.
2926 (read1): Check for integer overflow in radices, and in
2927 read-circle numbers.
82cb60d3
PE
2928 (read_escape): Avoid int overflow.
2929 (Fload, openp, read_buffer_size, read1)
2930 (substitute_object_recurse, read_vector, read_list, map_obarray):
2931 Use ptrdiff_t, not int, for sizes.
2932 (read1): Use EMACS_INT, not int, for sizes.
20270765 2933 Check for size overflow.
8b9ac8b4 2934
7fcccf1e
PE
2935 * image.c (cache_image): Check for size arithmetic overflow.
2936
bfbbd7e7
PE
2937 * lread.c: Integer overflow issues.
2938 (saved_doc_string_size, saved_doc_string_length)
2939 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2940 Now ptrdiff_t, not int.
2941 (read1): Don't assume doc string length fits in int. Check for
2942 out-of-range doc string lengths.
2943 (read_list): Don't assume file position fits in int.
39019e54 2944 (read_escape): Check for hex character overflow.
bfbbd7e7 2945
4e323265
LL
29462011-06-22 Leo Liu <sdl.web@gmail.com>
2947
2948 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2949 Move to minibuffer.el.
2950
85fece3e
PE
29512011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2952
20b84ce9 2953 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2954 The following patches are for when GLYPH_DEBUG && !XASSERT.
2955 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2956 * dispnew.c (flush_stdout):
2957 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2958 Mark as externally visible.
2959 * dispnew.c (check_window_matrix_pointers): Now static.
2960 * dispnew.c (window_to_frame_vpos):
2961 * xfns.c (unwind_create_frame):
2962 * xterm.c (x_check_font): Remove unused local.
2963 * scroll.c (CHECK_BOUNDS):
2964 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2965 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2966 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2967 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2968 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2969 Now static.
2970 (debug_method_add): Use va_list and vsprintf rather than relying
2971 on undefined behavior with wrong number of arguments.
2972 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2973 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2974 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2975 since we're not interested in debugging glyphs with old libraries.
2976 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2977 GCC 4.6.0's static checking.
2978
0766b489
PE
29792011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2980
31fd4b32
PE
2981 Integer overflow and signedness fixes (Bug#8873).
2982 A few related buffer overrun fixes, too.
2983
b79e8648
PE
2984 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2985
0766b489
PE
2986 * dispextern.h (struct face.stipple):
2987 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2988 (x_bitmap_mask, x_allocate_bitmap_record)
2989 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2990 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2991 (x_create_bitmap_from_xpm_data):
2992 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2993 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2994 (.bitmaps_last):
2995 * xfaces.c (load_pixmap):
2996 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2997 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2998 (.bitmaps_last, struct x_output.icon_bitmap):
2999 Use ptrdiff_t, not int, for bitmap indexes.
3000 (x_allocate_bitmap_record): Check for size overflow.
3001 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3002
b081724f
PE
3003 Use ptrdiff_t, not int, for overlay counts.
3004 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3005 * editfns.c (overlays_around, get_pos_property):
3006 * textprop.c (get_char_property_and_overlay):
3007 * xdisp.c (next_overlay_change, note_mouse_highlight):
3008 * xfaces.c (face_at_buffer_position):
21514da7
PE
3009 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3010 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3011 (Fnext_overlay_change, Fprevious_overlay_change)
3012 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3013 Use ptrdiff_t, not int, for sizes.
21514da7 3014 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3015
3de73e5e
PE
3016 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3017
2606c57b
PE
3018 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3019 (x_session_initialize): Do not assume string length fits in int.
3020
aaafe47a
PE
3021 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3022 This is unlikely, but can occur if DPI is outlandish.
3023
2674ddc8 3024 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3025 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3026
28154962
PE
3027 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3028 * xrdb.c (magic_file_p, search_magic_path):
3029 Omit last arg SUFFIX; it was always 0. All callers changed.
3030 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3031
7de51af5
PE
3032 * xfont.c (xfont_match): Avoid need for strlen.
3033
25ed6cc3
PE
3034 * xfns.c: Don't assume strlen fits in int.
3035 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3036
4eab31dd
PE
3037 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3038 not unsigned long, as we prefer signed integers. All callers changed.
3039 Detect integer overflow in repeat count.
3040 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3041 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3042
171e2a58
PE
3043 * termcap.c: Don't assume sizes fit in int and never overflow.
3044 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3045 (gobble_line): Check for size-calculation overflow.
3046
ad39faca 3047 * minibuf.c (Fread_buffer):
6e5bb2dc 3048 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3049 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3050 Don't assume string length fits in int.
3051
52c61c22 3052 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3053 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3054
b5b8c9e5
PE
3055 * font.c: Don't assume string length fits in int.
3056 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3057 Use ptrdiff_t, not int.
ccd6111c
PE
3058 (font_intern_prop): Don't assume string length fits in int.
3059 Don't assume integer property fits in fixnum.
3060 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3061
882f0d81 3062 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3063 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3064 Reformulate so as not to need the command string.
3065 Invoke gzip -cd rather than gunzip, as it's more portable.
3066 (lock_info_type, lock_file_1, lock_file):
3067 Don't assume pid_t and time_t fit in unsigned long.
3068 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3069 (current_lock_owner): Prefer signed type for sizes.
3070 Use memcpy, not strncpy, where memcpy is what is really wanted.
3071 Don't assume (via atoi) that time_t and pid_t fit in int.
3072 Check for time_t and/or pid_t out of range, e.g., via a network share.
3073 Don't alloca where an auto var works fine.
3074
93f4cf88
PE
3075 * fileio.c: Fix some integer overflow issues.
3076 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3077 Don't assume string length fits in int.
3078 (directory_file_name): Don't assume string length fits in long.
3079 (make_temp_name): Don't assume pid fits in int, or that its print
3080 length is less than 20.
3081
f3e92b69
PE
3082 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3083
1bfdaf10
PE
3084 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3085
35016e9a
PE
3086 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3087
3d1e65a1
PE
3088 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3089 We prefer signed integers, even for size calculations.
3090
0b963a93
PE
3091 * emacs.c: Don't assume string length fits in 'int'.
3092 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3093 (main): Don't invoke strlen when not needed.
3094
573f4b54
PE
3095 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3096 (XD_DEBUG_MESSAGE): Don't waste a byte.
3097
989f33ba
PE
3098 * callproc.c (getenv_internal_1, getenv_internal)
3099 (Fgetenv_internal):
965d34eb
PE
3100 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3101
e4d29b33
PE
3102 * lread.c (invalid_syntax): Omit length argument.
3103 All uses changed. This doesn't fix a bug, but it simplifies the
3104 code away from its former Hollerith-constant appearance, and it's
3105 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3106 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3107
eb49b136
PE
3108 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3109 This didn't break anything, but it didn't help either.
3110 It's confusing to put a bogus integer in a place where the actual
3111 value does not matter.
9f62aeb1 3112 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3113 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3114
15375a22
PE
3115 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3116 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3117 implementation.
b61cc01c
PE
3118 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3119 We prefer signed types, and the value cannot exceed the EMACS_INT
3120 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3121 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3122 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3123 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3124
53b2623d
PE
3125 * indent.c (sane_tab_width): New function.
3126 (current_column, scan_for_column, Findent_to, position_indentation)
3127 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3128 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3129
51cab52b 3130 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3131
f2ed8a70
PE
3132 * lisp.h (lint_assume): New macro.
3133 * composite.c (composition_gstring_put_cache):
3134 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3135
abe80cc6
PE
3136 * editfns.c, insdel.c:
3137 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3138
b02c740e
PE
3139 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3140
ebc96716
PE
3141 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3142
b4e50fa0 3143 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3144 Use much-faster test for byte-length change.
311d5d7c 3145 Don't assume string byte-length fits in 'int'.
a4cf38e4 3146 Check that character arg fits in 'int'.
85461888 3147 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3148
c0c1ee9f
PE
3149 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3150
a498d7f4
PE
3151 * fns.c (concat): Catch string overflow earlier.
3152 Do not rely on integer wraparound.
3153
51cab52b
PE
3154 * dispextern.h (struct it.overlay_strings_charpos)
3155 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3156 * xdisp.c (forward_to_next_line_start)
3157 (back_to_previous_visible_line_start)
3158 (reseat_at_next_visible_line_start, next_element_from_buffer):
3159 Don't arbitrarily truncate the value of 'selective' to int.
3160
76031fad
PE
3161 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3162
5eb55db9
PE
3163 * composite.c: Don't truncate sizes to 'int'.
3164 (composition_gstring_p, composition_reseat_it)
3165 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3166 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3167 not EMACS_UINT, for indexes.
5eb55db9 3168
0703a717
PE
3169 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3170
d6202519
PE
3171 * buffer.c: Include <verify.h>.
3172 (struct sortvec.priority, struct sortstr.priority):
8961a454 3173 Now EMACS_INT, not int.
c20998a7 3174 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3175 (struct sortstr.size, record_overlay_string)
3176 (struct sortstrlist.size, struct sortlist.used):
3177 Don't truncate size to int.
3178 (record_overlay_string): Check for size-calculation overflow.
d6202519 3179 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3180
d5a19415
JM
31812011-06-22 Jim Meyering <meyering@redhat.com>
3182
029529ac 3183 Don't leak an XBM-image-sized buffer
d5a19415
JM
3184 * image.c (xbm_load): Free the image buffer after using it.
3185
a9041e6c
PE
31862011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3187
3188 Port to Sun C.
3189 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3190 that Sun C diagnosed.
3191 * fns.c (secure_hash): Fix pointer signedness issue.
3192 * intervals.c (static_offset_intervals): New function.
3193 (offset_intervals): Use it.
3194
7f3f739f
LL
31952011-06-21 Leo Liu <sdl.web@gmail.com>
3196
3197 * deps.mk (fns.o):
3198 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3199 sha512.h.
3200
3201 * fns.c (secure_hash): Rename from crypto_hash_function and change
3202 the first arg to accept symbols.
5b66d427 3203 (Fsecure_hash): New primitive.
7f3f739f
LL
3204 (syms_of_fns): New symbols.
3205
76147d94
DD
32062011-06-20 Deniz Dogan <deniz@dogan.se>
3207
3208 * process.c (Fset_process_buffer): Clarify return value in
3209 docstring.
3210
7d7d0045
CY
32112011-06-18 Chong Yidong <cyd@stupidchicken.com>
3212
3213 * dispnew.c (add_window_display_history): Use BVAR.
3214
3215 * xdisp.c (debug_method_add): Use BVAR.
3216 (check_window_end, dump_glyph_matrix, dump_glyph)
3217 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3218
3219 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3220 Likewise.
3221
3222 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3223 check till after the cache is created in init_frame_faces.
3224
ff2bc410
SM
32252011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3226
3227 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3228
28177add
PE
32292011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3230
dd3482fe
PE
3231 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3232 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3233 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3234
393d71f3 3235 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3236 * fileio.c (Finsert_file_contents):
3237 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3238 Remove the old (too-loose) buffer overflow checks.
3239 They weren't needed, since make_gap checks for buffer overflow.
3240 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3241 The old code merely checked for Emacs fixnum overflow, and relied
3242 on undefined (wraparound) behavior. The new code avoids undefined
3243 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3244
2e6813b0 3245 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3246 Tune. Don't use wider integers than needed. Don't use alloca.
3247 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3248
599a9e4f
PE
3249 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3250
99561444
PE
3251 * insdel.c, lisp.h (buffer_overflow): New function.
3252 (insert_from_buffer_1, replace_range, replace_range_2):
3253 * insdel.c (make_gap_larger):
3254 * editfns.c (Finsert_char):
3255 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3256
28177add
PE
3257 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3258
e69dafad
PE
32592011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3260
a7af7fde 3261 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3262
b1c46f02
PE
3263 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3264 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3265
e69dafad
PE
3266 * fileio.c: Don't assume EMACS_INT fits in off_t.
3267 (emacs_lseek): New static function.
3268 (Finsert_file_contents, Fwrite_region): Use it.
3269 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3270
566684ea
PE
3271 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3272
e6966cd6
PE
3273 * fns.c: Don't overflow int when computing a list length.
3274 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3275 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3276 truncation on 64-bit hosts. Check for QUIT every
3277 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3278 faster and is responsive enough.
3279 (Flength): Report an error instead of overflowing an integer.
3280 (Fsafe_length): Return a float if the value is not representable
3281 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3282 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3283 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3284
dd0b0efb
PE
3285 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3286 (header_size, word_size): New constants.
3287 (allocate_vectorlike): Don't check size overflow here.
3288 (allocate_vector): Check it here instead, since this is the only
3289 caller of allocate_vectorlike that could cause overflow.
3290 Check that the new vector's length is representable as a fixnum.
3291
86fe5cfe
PE
3292 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3293 The previous code was bogus. For example, next_almost_prime (32)
3294 returned 39, which is undesirable as it is a multiple of 3; and
3295 next_almost_prime (24) returned 25, which is a multiple of 5 so
3296 why was the code bothering to check for multiples of 7?
3297
80e88859
PE
3298 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3299
4a2f0ad6
PE
3300 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3301
f66c7cf8
PE
3302 Variadic C functions now count arguments with ptrdiff_t.
3303 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3304 Back then I didn't know that the Emacs coding style prefers signed int.
3305 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3306 were being counted with int, which may truncate counts on 64-bit
3307 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3308 * lisp.h (struct Lisp_Subr.function.aMANY)
3309 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3310 Arg counts are now ptrdiff_t, not size_t.
3311 All variadic functions and their callers changed accordingly.
3312 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3313 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3314 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3315 * callint.c (Fcall_interactively): Check arg count for overflow,
3316 to avoid potential buffer overrun. Use signed char, not 'int',
3317 for 'varies' array, so that we needn't bother to check its size
3318 calculation for overflow.
3319 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3320 * eval.c (apply_lambda):
3321 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3322 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3323 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3324
a1759b76
PE
3325 * callint.c (Fcall_interactively): Don't use index var as event count.
3326
d96be9fc
PE
3327 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3328 * mem-limits.h (SIZE): Remove; no longer used.
3329
a690a978 3330 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3331
578c21e6
PE
3332 Remove unnecessary casts.
3333 * xterm.c (x_term_init):
3334 * xfns.c (x_set_border_pixel):
3335 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3336 These aren't needed now that we assume ANSI C.
3337
96f53c6c
PE
3338 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3339 It's more likely to cause problems (due to unsigned overflow)
3340 than to cure them.
3341
83c77d31
PE
3342 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3343
ee2079f1
PE
3344 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3345
6da65536
PE
3346 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3347
7147c4a4
PE
3348 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3349
193e32d9
PE
3350 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3351
e5533da6
PE
3352 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3353
9910e595
PE
3354 GLYPH_CODE_FACE returns EMACS_INT, not int.
3355 * dispextern.h (merge_faces):
3356 * xfaces.c (merge_faces):
01103c44
PE
3357 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3358 Don't assume EMACS_INT fits in int.
9910e595 3359
2638320e
PE
3360 * character.h (CHAR_VALID_P): Remove unused parameter.
3361 * fontset.c, lisp.h, xdisp.c: All uses changed.
3362
045eb8d9
PE
3363 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3364
c1f134b5
PE
3365 * fns.c (concat): Minor tuning based on overflow analysis.
3366 This doesn't fix any bugs. Use int to hold character, instead
3367 of constantly refetching from Emacs object. Use XFASTINT, not
3368 XINT, for value known to be a character. Don't bother comparing
3369 a single byte to 0400, as it's always less.
3370
395fcb93 3371 * floatfns.c (Fexpt):
327eeec8
PE
3372 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3373
abbd3d23
PE
3374 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3375 for characters.
3376
684a03ef
PE
3377 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3378
0fed43f3
PE
3379 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3380 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3381 incorrectly succeed when S was a string, because 4294967386 was
3382 truncated before it was used.
3383
8fd02eb7
PE
3384 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3385 Otherwise, an out-of-range integer could cause undefined behavior
3386 on a 64-bit host.
3387
f8c86b69
PE
3388 * composite.c: Use int, not EMACS_INT, for characters.
3389 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3390 EMACS_INT, for values that are known to be in character range.
3391 This doesn't fix any bugs but is the usual style inside Emacs and
3392 may generate better code on 32-bit machines.
3393
34206dd2
PE
3394 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3395 This is for reasons similar to the recent CHAR_STRING fix.
3396 * charset.c (Fencode_char): Check that character arg is actually
3397 a character. Pass an int to ENCODE_CHAR.
3398 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3399 wider than 'int', as a compile-time check to prevent future regressions
3400 in this area.
3401
c5958d4c 3402 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3403
3404 Make sure a 64-bit char is never passed to CHAR_STRING.
3405 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3406 by silently ignoring the top 32 bits, allowing some values
3407 that were far too large to be valid characters.
3408 * character.h: Include <verify.h>.
3409 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3410 arguments are no wider than unsigned, as a compile-time check
3411 to prevent future regressions in this area.
3412 * data.c (Faset):
01103c44 3413 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3414 (Fsubst_char_in_region):
3415 * fns.c (concat):
3416 * xdisp.c (decode_mode_spec_coding):
3417 Adjust to CHAR_STRING's new requirement.
3418 * editfns.c (Finsert_char, Fsubst_char_in_region):
3419 * fns.c (concat): Check that character args are actually
3420 characters. Without this test, these functions did the wrong
3421 thing with wildly out-of-range values on 64-bit hosts.
3422
d37ca623
PE
3423 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3424 These casts should not be needed on 32-bit hosts, either.
3425 * keyboard.c (read_char):
3426 * lread.c (Fload): Remove casts to unsigned.
3427
ea204efb
PE
3428 * lisp.h (UNSIGNED_CMP): New macro.
3429 This fixes comparison bugs on 64-bit hosts.
3430 (ASCII_CHAR_P): Use it.
3431 * casefiddle.c (casify_object):
01103c44 3432 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3433 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3434 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3435 * dispextern.h (FACE_FROM_ID):
3436 * keyboard.c (read_char): Use UNSIGNED_CMP.
3437
41cb286c
PE
3438 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3439 not to EMACS_INT, to avoid GCC warning.
3440
4a1b9832
PE
3441 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3442
55daad71
PE
3443 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3444 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3445 isn't needed on 32-bit machines.
8f95c75c 3446
01103c44
PE
3447 * buffer.c (Fgenerate_new_buffer_name):
3448 Use EMACS_INT for count, not int.
0ceccced 3449 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3450
3451 * data.c (Qcompiled_function): Now static.
3452
c6f072e7
PE
3453 * window.c (window_body_lines): Now static.
3454
20ce5912
PE
3455 * image.c (gif_load): Rename local to avoid shadowing.
3456
9c4c5f81
PE
3457 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3458 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3459 * alloc.c (make_save_value): Integer argument is now of type
3460 ptrdiff_t, not int.
3461 (mark_object): Use ptrdiff_t, not int.
3462 * lisp.h (pD): New macro.
3463 * print.c (print_object): Use it.
3464
c0c5c8ae
PE
3465 * alloc.c: Use EMACS_INT, not int, to count objects.
3466 (total_conses, total_markers, total_symbols, total_vector_size)
3467 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3468 (total_free_floats, total_floats, total_free_intervals)
3469 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3470 Now EMACS_INT, not int. All uses changed.
3471 (Fgarbage_collect): Compute overall total using a double, so that
3472 integer overflow is less likely to be a problem. Check for overflow
3473 when converting back to an integer.
5a25e253
PE
3474 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3475 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3476 These were 'int' variables that could overflow on 64-bit hosts;
3477 they were never used, so remove them instead of repairing them.
211a0b2a 3478 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3479 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3480 Previously, this ceilinged at INT_MAX, but that doesn't work on
3481 64-bit machines.
e46bb31a 3482 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3483
c78baabf 3484 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3485 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3486 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3487 when a (possibly-narrower) signed value would do just as well.
3488 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3489
c9d624c6
PE
3490 * alloc.c: Catch some string size overflows that we were missing.
3491 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3492 for convenience in STRING_BYTES_MAX.
3493 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3494 The definition here is exact; the one in lisp.h was approximate.
3495 (allocate_string_data): Check for string overflow. This catches
3496 some instances we weren't catching before. Also, it catches
3497 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3498 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3499 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3500
c9d624c6
PE
3501 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3502 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3503 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3504
353032ce
PE
3505 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3506
2bccce07
PE
3507 * alloc.c (Fmake_string): Check for out-of-range init.
3508
0ac30604
SM
35092011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3510
3511 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3512
c195f2de
JD
35132011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3514
3515 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3516 xg_get_default_scrollbar_width.
3517
3518 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3519 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3520 (style_changed_cb): Call update_theme_scrollbar_width and call
3521 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3522 all frames (Bug#8505).
3523 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3524 Call gtk_window_set_resizable if HAVE_GTK3.
3525 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3526 and height if HAVE_GTK3 (Bug#8505).
3527 (scroll_bar_width_for_theme): New variable.
3528 (update_theme_scrollbar_width): New function.
3529 (xg_get_default_scrollbar_width): Move code to
3530 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3531 (xg_initialize): Call update_theme_scrollbar_width.
3532
3533 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3534
3535 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3536
e10ac9f1
MR
35372011-06-12 Martin Rudalics <rudalics@gmx.at>
3538
3539 * frame.c (make_frame): Call other_buffer_safely instead of
3540 other_buffer.
3541
3542 * window.c (temp_output_buffer_show): Call display_buffer with
3543 second argument Vtemp_buffer_show_specifiers and reset latter
3544 immediately after the call.
3545 (Vtemp_buffer_show_specifiers): New variable.
3546 (auto_window_vscroll_p, next_screen_context_lines)
3547 (Vscroll_preserve_screen_position): Remove leading asterisks from
3548 doc-strings.
3549
2d3c217e 35502011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3551
7b7f97e8 3552 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3553 * buffer.c (Qclone_number): Remove for now, as it's unused.
3554 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3555 (record_buffer): Remove unused local.
3556 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3557 (set_frame_buffer_list): Remove; unused.
3558 * frame.h (other_visible_frames): Remove decl.
3559 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3560 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3561 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3562 if HAVE_GPM.
3563 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3564 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3565 Define only if HAVE_GPM.
3566 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3567 (update_hints_inhibit): Remove; never set. All uses removed.
3568 * widgetprv.h (emacsFrameClassRec): Remove decl.
3569 * window.c (delete_deletable_window): Now returns void, since it
3570 wasn't returning anything.
3571 (compare_window_configurations): Remove unused locals.
3572 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3573 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3574 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3575 the same widths as pointers. This follows up on the 2011-05-06 patch.
3576 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3577 * xterm.h: Likewise.
3578 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3579
1384b89e
JB
35802011-06-12 Juanma Barranquero <lekktu@gmail.com>
3581
3582 * makefile.w32-in: Update dependencies.
3583 (LISP_H): Add lib/intprops.h.
3584
1100a63c
CY
35852011-06-11 Chong Yidong <cyd@stupidchicken.com>
3586
3587 * image.c (gif_load): Add animation frame delay to the metadata.
3588 (syms_of_image): Use DEFSYM. New symbol `delay'.
3589
6198ccd0
MR
35902011-06-11 Martin Rudalics <rudalics@gmx.at>
3591
3592 * window.c (delete_deletable_window): Re-add.
3593 (Fset_window_configuration): Rewrite to handle dead buffers and
3594 consequently deletable windows.
3595 (window_tree, Fwindow_tree): Remove. Supply functionality in
3596 window.el.
3597 (compare_window_configurations): Simplify code.
3598
b6e3633c
AS
35992011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3600
1ab0dee5
AS
3601 * image.c (imagemagick_load_image): Fix type mismatch.
3602 (Fimagemagick_types): Likewise.
3603
b6e3633c
AS
3604 * window.h (replace_buffer_in_windows): Declare.
3605
9397e56f
MR
36062011-06-11 Martin Rudalics <rudalics@gmx.at>
3607
3608 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3609 Qclone_number. Remove external declaration of Qdelete_window.
3610 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3611 code.
640c8776
SM
3612 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3613 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3614 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3615 buffer list implementation.
3616 (other_buffer_safely): New function.
3617 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3618 calls to replace_buffer_in_windows and
3619 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3620 if allowed.
3621 (record_buffer): Inhibit quitting and rewrite using quittable
3622 functions. Run Qbuffer_list_update_hook if allowed.
3623 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3624 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3625 Move switch-to-buffer to window.el.
9397e56f
MR
3626 (bury-buffer): Move to window.el.
3627 (Vbuffer_list_update_hook): New variable.
3628
3629 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3630 section.
3631
3632 * window.h (resize_frame_windows): Move up in code.
3633 (Fwindow_frame): Remove EXFUN.
3634 (replace_buffer_in_all_windows): Remove prototype.
3635 (replace_buffer_in_windows_safely): Add prototype.
3636
3637 * window.c: Declare Qdelete_window static again. Move down
3638 declaration of select_count.
3639 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3640 (Fother_window): Move to window.el.
3641 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3642 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3643 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3644 window.el.
3645 (replace_buffer_in_windows): Implement by calling
3646 Qreplace_buffer_in_windows.
3647 (replace_buffer_in_all_windows): Remove with some functionality
3648 moved into replace_buffer_in_windows_safely.
3649 (replace_buffer_in_windows_safely): New function.
3650 (select_window_norecord, select_frame_norecord): Move in front
3651 of run_window_configuration_change_hook. Remove now obsolete
3652 declarations.
640c8776
SM
3653 (Fset_window_buffer): Rewrite doc-string.
3654 Call Qrecord_window_buffer.
9397e56f
MR
3655 (keys_of_window): Move binding for other-window to window.el.
3656
b50691aa
CY
36572011-06-11 Chong Yidong <cyd@stupidchicken.com>
3658
3659 * dispextern.h (struct image): Replace data member, whose int_val
3660 and ptr_val fields were not used by anything, with a single
3661 lisp_val object.
3662
3663 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3664 (gif_clear_image, gif_load, imagemagick_load_image)
3665 (gs_clear_image, gs_load): Callers changed.
3666
3f754b86
PE
36672011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3668
cca69397
PE
3669 * buffer.h: Include <time.h>, for time_t.
3670 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3671
109e28d0
PE
3672 Fix minor problems found by static checking.
3673
60737f02
PE
3674 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3675
4b66faf3
PE
3676 Make identifiers static if they are not used in other modules.
3677 * data.c (Qcompiled_function, Qframe, Qvector):
3678 * image.c (QimageMagick, Qsvg):
3679 * minibuf.c (Qmetadata):
3680 * window.c (resize_window_check, resize_root_window): Now static.
3681 * window.h (resize_window_check, resize_root_window): Remove decls.
3682
109e28d0
PE
3683 * window.c (window_deletion_count, delete_deletable_window):
3684 Remove; unused.
46a4ce9e
PE
3685 (window_body_lines): Now static.
3686 (Fdelete_other_windows_internal): Mark vars as initialized.
3687 Make sure 'resize_failed' is initialized.
3688 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3689 (resize_window_apply): Remove unused local.
3690 * window.h (delete_deletable_window): Remove decl.
3691
109e28d0 3692 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3693 (imagemagick_load_image): Fix pointer signedness problem by changing
3694 last arg from unsigned char * to char *. All uses changed.
3695 Also, fix a local for similar reasons.
3696 Remove unused locals. Remove locals to avoid shadowing.
3697 (fn_rsvg_handle_free): Remove; unused.
3698 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3699 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3700
3f754b86
PE
3701 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3702
2547adb1
CY
37032011-06-10 Chong Yidong <cyd@stupidchicken.com>
3704
3705 * image.c (gif_load): Fix omitted cast error introduced by
3706 2011-06-06 change.
3707
2c8e37d4
MR
37082011-06-10 Martin Rudalics <rudalics@gmx.at>
3709
3710 * window.h (resize_proportionally, orig_total_lines)
3711 (orig_top_line): Remove from window structure.
3712 (set_window_height, set_window_width, change_window_heights)
3713 (Fdelete_window): Remove prototypes.
3714 (resize_frame_windows): Remove duplicate declaration.
3715
440a42e3
EZ
37162011-06-10 Eli Zaretskii <eliz@gnu.org>
3717
3718 * window.h (resize_frame_windows, resize_window_check)
3719 (delete_deletable_window, resize_root_window)
3720 (resize_frame_windows): Declare prototypes.
3721
3722 * window.c (resize_window_apply): Make definition be "static" to
3723 match the prototype.
3724
562dd5e9
MR
37252011-06-10 Martin Rudalics <rudalics@gmx.at>
3726
3727 * window.c: Remove declarations of Qwindow_size_fixed,
3728 window_min_size_1, window_min_size_2, window_min_size,
3729 size_window, window_fixed_size_p, enlarge_window, delete_window.
3730 Remove static from declaration of Qdelete_window, it's
3731 temporarily needed by Fbury_buffer.
3732 (replace_window): Don't assign orig_top_line and
3733 orig_total_lines.
3734 (Fdelete_window, delete_window): Remove. Window deletion is
3735 handled by window.el.
640c8776
SM
3736 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3737 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3738 (Fdelete_other_windows): Remove. Deleting other windows is
3739 handled by window.el.
3740 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3741 handled in window.el.
3742 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3743 Window minimum sizes are handled in window.el.
3744 (shrink_windows, size_window, set_window_height)
3745 (set_window_width, change_window_heights, window_height)
3746 (window_width, CURBEG, CURSIZE, enlarge_window)
3747 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3748 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3749 handled in window.el.
3750 (make_dummy_parent): Rename to make_parent_window and give it a
3751 second argument horflag.
3752 (make_window): Don't set resize_proportionally any more.
3753 (Fsplit_window): Remove. Windows are split in window.el.
3754 (save_restore_action, save_restore_orig_size)
3755 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3756 Resize mini windows in window.el.
3757 (grow_mini_window, shrink_mini_window): Implement by calling
3758 Qresize_root_window_vertically, resize_window_check and
3759 resize_window_apply.
640c8776
SM
3760 (saved_window, Fset_window_configuration, save_window_save):
3761 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3762 resize_proportionally.
3763 (window_min_height, window_min_width): Move to window.el.
3764 (keys_of_window): Move bindings for delete-other-windows,
3765 split-window, delete-window and enlarge-window to window.el.
3766
3767 * buffer.c: Temporarily extern Qdelete_window.
3768 (Fbury_buffer): Temporarily call Qdelete_window instead of
3769 Fdelete_window (Fbury_buffer will move to window.el soon).
3770
3771 * frame.c (set_menu_bar_lines_1): Remove code handling
3772 orig_top_line and orig_total_lines.
3773
3774 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3775 set_window_height but set heights directly.
3776 (change_frame_size_1): Use resize_frame_windows.
3777
3778 * xdisp.c (init_xdisp): Don't use set_window_height but set
3779 heights directly.
3780
640c8776
SM
3781 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3782 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3783 run_window_configuration_change_hook.
3784
3785 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3786 instead of change_window_heights and run
3787 run_window_configuration_change_hook.
3788
1a13852e
MR
37892011-06-09 Martin Rudalics <rudalics@gmx.at>
3790
3791 * window.c (replace_window): Rename second argument REPLACEMENT to
3792 NEW. New third argument SETFLAG. Rewrite.
3793 (delete_window, make_dummy_parent): Call replace_window with
3794 third argument 1.
3795 (window_list_1): Move down in code.
3796 (run_window_configuration_change_hook): Move set_buffer part
3797 before select_frame_norecord part in order to unwind correctly.
3798 Rename count1 to count.
3799 (recombine_windows, delete_deletable_window, resize_root_window)
3800 (Fdelete_other_windows_internal)
3801 (Frun_window_configuration_change_hook, make_parent_window)
3802 (resize_window_check, resize_window_apply, Fresize_window_apply)
3803 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3804 (Fdelete_window_internal, Fresize_mini_window_internal):
3805 New functions.
1a13852e
MR
3806 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3807
f3d1777e
MR
38082011-06-08 Martin Rudalics <rudalics@gmx.at>
3809
496e208e
MR
3810 * window.h (window): Add some new members to window structure -
3811 normal_lines, normal_cols, new_total, new_normal, clone_number,
3812 splits, nest, prev_buffers, next_buffers.
3813 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3814 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3815
f3d1777e
MR
3816 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3817 Remove.
496e208e
MR
3818 (make_dummy_parent): Set new members of windows structure.
3819 (make_window): Move down in code. Handle new members of window
3820 structure.
3821 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3822 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3823 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3824 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3825 (Fset_window_next_buffers, Fset_window_clone_number):
3826 New functions.
496e208e
MR
3827 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3828 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3829 Doc-string fixes.
3830 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3831 Argument WINDOW can be now internal window too.
3832 (Fwindow_use_time): Move up in code.
3833 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3834 Rewrite doc-string.
3835 (Fset_window_configuration, saved_window)
3836 (Fcurrent_window_configuration, save_window_save): Handle new
3837 members of window structure.
b9e809c2
MR
3838 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3839 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3840 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3841 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3842 Qget_mru_window, Qresize_root_window,
3843 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3844 Qauto_buffer_name; staticpro them.
f3d1777e 3845
abde8f8c
MR
38462011-06-07 Martin Rudalics <rudalics@gmx.at>
3847
3848 * window.c (Fwindow_total_size, Fwindow_left_column)
3849 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3850 (Fwindow_list_1): New functions.
3851 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3852 (Fwindow_width, Fscroll_left, Fscroll_right):
3853 Use window_body_cols instead of window_box_text_cols.
3854 (delete_window, Fset_window_configuration):
3855 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3856 (delete_all_subwindows): Take a window as argument and not a
3857 structure. Rewrite.
190b47e6
MR
3858 (window_loop): Remove handling of GET_LRU_WINDOW and
3859 GET_LARGEST_WINDOW.
3860 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3861
3862 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3863 window_box_text_cols. delete_all_subwindows now takes a
3864 Lisp_Object as argument.
abde8f8c 3865
640c8776
SM
3866 * indent.c (compute_motion, Fcompute_motion):
3867 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3868
fa8a67e6
MR
3869 * frame.c (delete_frame): Call delete_all_subwindows with root
3870 window as argument.
3871
a54e3482
DC
38722011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3873
3874 * fns.c (Fputhash): Document return value.
3875
60002bf5
CY
38762011-06-06 Chong Yidong <cyd@stupidchicken.com>
3877
3878 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3879
0c671da6 38802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3881
b862a52a 3882 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3883
be44ca6c
PE
3884 Check for overflow when converting integer to cons and back.
3885 * charset.c (Fdefine_charset_internal, Fdecode_char):
3886 Use cons_to_unsigned to catch overflow.
3887 (Fencode_char): Use INTEGER_TO_CONS.
3888 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3889 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3890 * data.c (long_to_cons, cons_to_long): Remove.
3891 (cons_to_unsigned, cons_to_signed): New functions.
3892 These signal an error for invalid or out-of-range values.
3893 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3894 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3895 * font.c (Ffont_variation_glyphs):
3896 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3897 * lisp.h: Include <intprops.h>.
3898 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3899 (cons_to_signed, cons_to_unsigned): New decls.
3900 (long_to_cons, cons_to_long): Remove decls.
3901 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3902 (Fprimitive_undo): Use CONS_TO_INTEGER.
3903 * xfns.c (Fx_window_property): Likewise.
3904 * xselect.c: Include <limits.h>.
3905 (x_own_selection, selection_data_to_lisp_data):
3906 Use INTEGER_TO_CONS.
3907 (x_handle_selection_request, x_handle_selection_clear)
3908 (x_get_foreign_selection, Fx_disown_selection_internal)
3909 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3910 (lisp_data_to_selection_data): Use cons_to_unsigned.
3911 (x_fill_property_data): Use cons_to_signed.
3912 Report values out of range.
3913
d1f3d2af
PE
3914 Check for buffer and string overflow more precisely.
3915 * buffer.h (BUF_BYTES_MAX): New macro.
3916 * lisp.h (STRING_BYTES_MAX): New macro.
3917 * alloc.c (Fmake_string):
3918 * character.c (string_escape_byte8):
3919 * coding.c (coding_alloc_by_realloc):
3920 * doprnt.c (doprnt):
3921 * editfns.c (Fformat):
3922 * eval.c (verror):
3923 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3924 since they may not be the same number.
3925 * editfns.c (Finsert_char):
3926 * fileio.c (Finsert_file_contents):
3927 Likewise for BUF_BYTES_MAX.
3928
dd52fcea
PE
3929 * image.c: Use ptrdiff_t, not int, for sizes.
3930 (slurp_file): Switch from int to ptrdiff_t.
3931 All uses changed.
3932 (slurp_file): Check that file size fits in both size_t (for
3933 malloc) and ptrdiff_t (for sanity and safety).
3934
7f9bbdbb
PE
3935 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3936 if b->modtime has its maximal value.
3937
dfe18f82
PE
3938 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3939
84acfcf0
PE
3940 Don't assume time_t can fit into int.
3941 * buffer.h (struct buffer.modtime): Now time_t, not int.
3942 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3943 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3944
ccd9a01a
PE
3945 Minor fixes for signed vs unsigned integers.
3946 * character.h (MAYBE_UNIFY_CHAR):
3947 * charset.c (maybe_unify_char):
3948 * keyboard.c (read_char, reorder_modifiers):
3949 XINT -> XFASTINT, since the integer must be nonnegative.
3950 * ftfont.c (ftfont_spec_pattern):
3951 * keymap.c (access_keymap, silly_event_symbol_error):
3952 XUINT -> XFASTINT, since the integer must be nonnegative.
3953 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3954 since it makes no difference and we prefer signed.
3955 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3956 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3957 nonnegative.
3958
d6d100dd
SM
39592011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3960
3961 * window.h (Fwindow_frame): Declare.
3962
2b6148e4
PE
39632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3964
3965 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3966 (SPARE_MEMORY): Always define.
3967 (LARGE_REQUEST): Remove.
3968 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3969
f230ecc9
MR
39702011-06-06 Martin Rudalics <rudalics@gmx.at>
3971
727e958e
MR
3972 * lisp.h: Move EXFUNS for Fframe_root_window,
3973 Fframe_first_window and Fset_frame_selected_window to window.h.
3974
3975 * window.h: Move EXFUNS for Fframe_root_window,
3976 Fframe_first_window and Fset_frame_selected_window here from
3977 lisp.h.
3978
3979 * frame.c (Fwindow_frame, Fframe_first_window)
3980 (Fframe_root_window, Fframe_selected_window)
3981 (Fset_frame_selected_window): Move to window.c.
3982 (Factive_minibuffer_window): Move to minibuf.c.
3983 (Fother_visible_frames_p): New function.
3984
3985 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3986
f230ecc9
MR
3987 * window.c (decode_window, decode_any_window): Move up in code.
3988 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3989 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3990 (Fwindow_buffer): Move up and rewrite doc-string.
3991 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3992 (Fwindow_prev): New functions.
727e958e
MR
3993 (Fwindow_frame): Move here from frame.c. Accept any window as
3994 argument.
3995 (Fframe_root_window, Fframe_first_window)
3996 (Fframe_selected_window): Move here from frame.c. Accept frame
3997 or arbitrary window as argument. Update doc-strings.
3998 (Fminibuffer_window): Move up in code.
3999 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4000 (Fset_frame_selected_window): Move here from frame.c.
4001 Marginal rewrite.
727e958e
MR
4002 (Fselected_window, select_window, Fselect_window): Move up in
4003 code. Minor doc-string fixes.
f230ecc9 4004
4d09bcf6
PE
40052011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4006
4007 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4008 Do not assume that spare memory exists; that assumption is valid
4009 only if SYSTEM_MALLOC.
4010 (LARGE_REQUEST): New macro, so that the issue of large requests
4011 is separated from the issue of spare memory.
4012
810928a2
AS
40132011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4014
172418ad
AS
4015 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4016 format. (Bug#8806)
4017
43f862f7
AS
4018 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4019
810928a2
AS
4020 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4021 before statements.
4022
a059fe24
JD
40232011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4024
4025 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4026
4027 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4028
4029 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4030 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4031
989bf368
JB
40322011-06-05 Juanma Barranquero <lekktu@gmail.com>
4033
4034 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4035
4b80f674
CY
40362011-06-04 Chong Yidong <cyd@stupidchicken.com>
4037
4038 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4039 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4040 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4041 New error handlers.
4b80f674
CY
4042 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4043 Obey Vx_select_enable_clipboard_manager. Catch errors in
4044 x_clipboard_manager_save (Bug#8779).
4045 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4046 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4047
99a33b77 40482011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4049
4050 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4051
99a33b77 40522011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4053
4054 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4055 in the current matrix if keep_current_p is non-zero.
4056
8264569d
EZ
40572011-06-04 Eli Zaretskii <eliz@gnu.org>
4058
4059 * bidi.c (bidi_level_of_next_char): Fix last change.
4060
57f97249
EZ
40612011-06-03 Eli Zaretskii <eliz@gnu.org>
4062
fec2107c 4063 Support bidi reordering of text covered by display properties.
57f97249 4064
fec2107c
EZ
4065 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4066 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4067 (bidi_cache_search, bidi_cache_iterator_state)
4068 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4069 (bidi_level_of_next_char, bidi_move_to_visually_next):
4070 Support character positions inside a run of characters covered by a
fec2107c
EZ
4071 display string.
4072 (bidi_paragraph_init, bidi_resolve_explicit_1)
4073 (bidi_level_of_next_char): Call bidi_fetch_char and
4074 bidi_fetch_char_advance instead of FETCH_CHAR and
4075 FETCH_CHAR_ADVANCE.
4076 (bidi_init_it): Initialize new members.
4077 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4078 definitions.
4079 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4080 instead of using explicit *_CHAR codes.
d6d100dd
SM
4081 (bidi_resolve_explicit, bidi_resolve_weak):
4082 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4083 bidirectional text is supported only in multibyte buffers.
4084 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4085 it to initialize the frame_window_p member of struct bidi_it.
4086 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4087 (bidi_resolve_explicit, bidi_resolve_weak)
4088 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4089 bidi_it->nchars is non-positive.
4090 (bidi_level_of_next_char): Don't try to lookup the cache for the
4091 next/previous character if nothing is cached there yet, or if we
4092 were just reseat()'ed to a new position.
c40e2fb2 4093
0e14fe90
EZ
4094 * xdisp.c (set_cursor_from_row): Set start and stop points
4095 according to the row's direction when priming the loop that looks
4096 for the glyph on which to display cursor.
4097 (single_display_spec_intangible_p): Function deleted.
4098 (display_prop_intangible_p): Reimplement to call
4099 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4100 Accept 3 additional arguments needed by handle_display_spec.
4101 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4102 values: lists, `(when COND...)' forms, etc.
4103 (single_display_spec_string_p): Support property values that are
4104 lists with the argument STRING its top-level element.
4105 (display_prop_string_p): Fix the condition for processing a
4106 property that is a list to be consistent with handle_display_spec.
fec2107c 4107 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4108 last portion of handle_display_prop.
4109 (compute_display_string_pos): Accept additional argument
4110 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4111 value of a `display' property is a "replacing spec".
4112 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4113 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4114 the display property, but just return a value indicating whether
4115 the display property will replace the characters it covers.
4116 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4117 frame_window_p members of struct bidi_it.
d6d100dd
SM
4118 (compute_display_string_pos, compute_display_string_end):
4119 New functions.
fec2107c
EZ
4120 (push_it): Accept second argument POSITION, where pop_it should
4121 jump to continue iteration.
4122 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4123
fec2107c
EZ
4124 * keyboard.c (adjust_point_for_property): Adjust the call to
4125 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4126
4127 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4128 (bidi_init_it): Update prototypes.
4129 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4130 (compute_display_string_pos, compute_display_string_end):
4131 Declare prototypes.
fec2107c
EZ
4132 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4133 EMACS_INT.
fc6f18ce 4134
40087514 41352011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4136
57f53182
PE
4137 Malloc failure behavior now depends on size of allocation.
4138 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4139 * lisp.h: Change signatures accordingly.
4140 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4141 All callers changed. (Bug#8762)
4142
4143 * gnutls.c: Use Emacs's memory allocators.
4144 Without this change, the gnutls library would invoke malloc etc.
4145 directly, which causes problems on non-SYNC_INPUT hosts, and which
4146 runs afoul of improving memory_full behavior. (Bug#8761)
4147 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4148 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4149 xfree instead of the default malloc, realloc, free.
4150 (Fgnutls_boot): No need to check for memory allocation failure,
4151 since xmalloc does that for us.
4152
ac32cd99 4153 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4154 * category.c (hash_get_category_set):
4155 * ccl.c (ccl_driver):
4156 * charset.c (Fdefine_charset_internal):
4157 * charset.h (struct charset.hash_index):
4158 * composite.c (get_composition_id, gstring_lookup_cache)
4159 (composition_gstring_put_cache):
4160 * composite.h (struct composition.hash_index):
4161 * dispextern.h (struct image.hash):
4162 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4163 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4164 (hashfn_equal, hashfn_user_defined, make_hash_table)
4165 (maybe_resize_hash_table, hash_lookup, hash_put)
4166 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4167 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4168 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4169 * image.c (make_image, search_image_cache, lookup_image)
4170 (xpm_put_color_table_h):
4171 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4172 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4173 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4174 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4175 * alloc.c (allocate_vectorlike):
4176 Check for overflow in vector size calculations.
4177 * ccl.c (ccl_driver):
4178 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4179 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4180 need to be updated by these changes.
40087514
PE
4181 * fns.c (make_hash_table, maybe_resize_hash_table):
4182 Check for integer overflow with large hash tables.
0de4bb68
PE
4183 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4184 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4185 (SXHASH_REDUCE): New macro.
4186 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4187 Use it instead of discarding useful hash info with large hash values.
4188 (sxhash_float): New function.
4189 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4190 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4191 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4192 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4193 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4194 Adjust signatures to match updated version of code.
4195 (consing_since_gc): Now EMACS_INT, since a single hash table can
4196 use more than INT_MAX bytes.
4197
698d32e2
DN
41982011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4199
4200 Make it possible to build with GCC-4.6+ -O2 -flto.
4201
4202 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4203
fd6fa53f
SM
42042011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4205
4206 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4207 Call minibuffer-inactive-mode.
4208
864db017
JB
42092011-05-31 Juanma Barranquero <lekktu@gmail.com>
4210
4211 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4212 Update dependencies.
4213
2ad0baf4
DN
42142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4215
4216 * data.c (init_data): Remove code for UTS, this system is not
4217 supported anymore.
4218
4fcc2638
DN
42192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4220
4221 Don't force ./temacs to start in terminal mode.
4222
4223 * frame.c (make_initial_frame): Initialize faces in all cases, not
4224 only when CANNOT_DUMP is defined.
4225 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4226
c56e0fd5
DN
42272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4228
4229 * dispnew.c (add_window_display_history): Use const for the string
4230 pointer. Remove declaration, not needed.
4231
333d54da 42322011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4233
55d4c1b2 4234 Use 'inline', not 'INLINE'.
333d54da 4235 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4236 * alloc.c, fontset.c (INLINE): Remove.
4237 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4238 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4239 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4240 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4241 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4242
738db178
DN
42432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4244
4245 Make it possible to run ./temacs.
4246
4247 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4248 syms_of_callproc does the same thing. Remove test for
4249 "initialized", do it in the caller.
4250 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4251
620c53a6
SM
42522011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4253
4254 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4255 (read_minibuf): Use get_minibuffer.
4256 (syms_of_minibuf): Use DEFSYM.
4257 (Qmetadata): New var.
4258 * data.c (Qbuffer): Don't make it static.
4259 (syms_of_data): Use DEFSYM.
4260
e003a292
PE
42612011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4262
4263 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4264 (CCL_CODE_MIN): New macro.
4265
ed008a6d
PE
42662011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4267
3687c2ef
PE
4268 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4269
ed008a6d
PE
4270 * eval.c (Qdebug): Now static.
4271 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4272 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4273 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4274
d66c4c7c
CY
42752011-05-29 Chong Yidong <cyd@stupidchicken.com>
4276
4277 * image.c: Various fixes to ImageMagick code comments.
4278 (Fimagemagick_types): Doc fix.
4279
5fbc2025
PE
42802011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4281
0196f88a
PE
4282 Minor fixes prompted by GCC 4.6.0 warnings.
4283
4284 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4285
5fbc2025
PE
4286 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4287 (x_clipboard_manager_save_all): Move extern decl to ...
4288 * xterm.h: ... here, so that it can be checked for consistency.
4289
1dd3c2d9
CY
42902011-05-29 Chong Yidong <cyd@stupidchicken.com>
4291
4292 * xselect.c (x_clipboard_manager_save_frame)
4293 (x_clipboard_manager_save_all): New functions.
4294 (Fx_clipboard_manager_save): Lisp function deleted.
4295
4296 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4297 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4298
4299 * xterm.h: Update prototype.
4300
5ba6571d
WX
43012011-05-28 William Xu <william.xwl@gmail.com>
4302
4303 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4304 exiting (Bug#8239).
4305
3eaff834
JM
43062011-05-28 Jim Meyering <meyering@redhat.com>
4307
e1900994 4308 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4309 * fns.c (to_uchar): Define.
4310 (crypto_hash_function): Use it to convert some newly-signed
4311 variables to unsigned, to avoid sign-extension bugs. For example,
4312 without this change, (md5 "truc") would evaluate to
4313 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4314 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4315 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4316
0f6990a7
PE
43172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4318
4319 Integer overflow fixes.
c8a9ca5a 4320
08686060
PE
4321 * dbusbind.c: Serial number integer overflow fixes.
4322 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4323 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4324 to hold a serial number that is too large for a fixnum.
4325 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4326 Check for serial numbers out of range. Decode any serial number
59568bf0 4327 that was so large that it became a float. (Bug#8722)
08686060 4328
2d1fc3c7
PE
4329 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4330 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4331 Use XFASTINT rather than XUINT when numbers are nonnegative.
4332 (xd_append_arg, Fdbus_method_return_internal):
4333 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4334 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4335 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4336 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4337 (Bug#8722)
2d1fc3c7 4338
c8a9ca5a
PE
4339 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4340
519e1d69
PE
4341 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4342
30569699
PE
4343 ccl: add integer overflow checks
4344 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4345 (IN_INT_RANGE): New macros.
4346 (ccl_driver): Use them to check for integer overflow when
4347 decoding a CCL program. Many of the new checks are whether XINT (x)
4348 fits in int; it doesn't always, on 64-bit hosts. The new version
4349 doesn't catch all possible integer overflows, but it's an
847044ea 4350 improvement. (Bug#8719)
30569699 4351
c11285dc
PE
4352 * alloc.c (make_event_array): Use XINT, not XUINT.
4353 There's no need for unsigned here.
4354
fdccd48e
PE
4355 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4356 This follows up to the 2011-05-06 change that substituted uintptr_t
4357 for EMACS_INT. This case wasn't caught back then.
4358
37910ab2
PE
4359 Rework Fformat to avoid integer overflow issues.
4360 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4361 now (part of C89). Include <verify.h>.
4362 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4363 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4364 (Fformat): Avoid the prepass trying to compute sizes; it was only
4365 approximate and thus did not catch overflow reliably. Instead, walk
4366 through the format just once, formatting and computing sizes as we go,
4367 checking for integer overflow at every step, and allocating a larger
4368 buffer as needed. Keep track separately whether the format is
4369 multibyte. Keep only the most-recently calculated precision, rather
4370 than them all. Record whether each argument has been converted to
4371 string. Use EMACS_INT, not int, for byte and char and arg counts.
4372 Support field widths and precisions larger than INT_MAX. Avoid
4373 sprintf's undefined behavior with conversion specifications such as %#d
4374 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4375 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4376 formatting out-of-range floating point numbers with int
9173deec 4377 formats. (Bug#8668)
37910ab2 4378
2e6578fb
PE
4379 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4380
0ae6bdee
PE
4381 * data.c: Avoid integer truncation in expressions involving floats.
4382 * data.c: Include <intprops.h>.
4383 (arith_driver): When there's an integer overflow in an expression
4384 involving floating point, convert the integers to floating point
4385 so that the resulting value does not suffer from catastrophic
4386 integer truncation. For example, on a 64-bit host (* 4
4387 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4388 Do not rely on undefined behavior after integer overflow.
4389
de883a70
PE
4390 merge count_size_as_multibyte, parse_str_to_multibyte
4391 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4392 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4393 Check for integer overflow.
4394 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4395 since it's now a duplicate of the other. This is more of
4396 a character than a buffer op, so better that it's in character.c.
4397 * fns.c, print.c: Adjust to above changes.
4398
2ff916cb
PE
43992011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4400
4401 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4402
f1b54466
PE
44032011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4404
fb1ac845
PE
4405 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4406 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4407 (x_clipboard_manager_save): Now static.
4408 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4409
f1b54466
PE
4410 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4411 (crypto_hash_function): Now static.
4412 Fix pointer signedness problems. Avoid unnecessary initializations.
4413
a9f737ee
CY
44142011-05-27 Chong Yidong <cyd@stupidchicken.com>
4415
4416 * termhooks.h (Vselection_alist): Make it terminal-local.
4417
4418 * terminal.c (create_terminal): Initialize it.
4419
4420 * xselect.c: Support for clipboard managers.
4421 (Vselection_alist): Move to termhooks.h as terminal-local var.
4422 (LOCAL_SELECTION): New macro.
4423 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4424 (symbol_to_x_atom): Remove gratuitous arg.
4425 (x_handle_selection_request, lisp_data_to_selection_data)
4426 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4427 (x_own_selection, x_get_local_selection, x_convert_selection):
4428 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4429 (some_frame_on_display): Delete unused function.
4430 (Fx_own_selection_internal, Fx_get_selection_internal)
4431 (Fx_disown_selection_internal, Fx_selection_owner_p)
4432 (Fx_selection_exists_p): New optional frame arg.
4433 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4434 (x_handle_selection_clear): Don't treat other terminals with the
4435 same keyboard specially. Use the terminal-local Vselection_alist.
4436 (x_clear_frame_selections): Use Frun_hook_with_args.
4437
4438 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4439
4440 * xterm.h: Add support for those atoms.
4441
e067f0c1
CY
44422011-05-26 Chong Yidong <cyd@stupidchicken.com>
4443
4444 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4445 (converted_selections, conversion_fail_tag): New global variables.
4446 (x_selection_request_lisp_error): Free the above.
4447 (x_get_local_selection): Remove unnecessary code.
4448 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4449 of converted selections stored in converted_selections.
4450 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4451 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4452 (x_convert_selection): New function.
4453 (x_handle_selection_event): Simplify.
4454 (x_get_foreign_selection): Don't ignore incoming requests while
4455 waiting for an answer; this will fail when we implement
4456 SAVE_TARGETS, and seems unnecessary anyway.
4457 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4458 (Vx_sent_selection_functions): Doc fix.
4459
0f4aebc0
LL
44602011-05-26 Leo Liu <sdl.web@gmail.com>
4461
4462 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4463
e61124cd
YM
44642011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4465
4466 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4467
4468 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4469 for fringe update if it has periodic bitmap.
ac389d0c 4470 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4471 and fringe_bitmap_periodic_p.
4472
4473 * fringe.c (get_fringe_bitmap_data): New function.
4474 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4475 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4476 row. Mark glyph row for fringe update if periodicity changed.
4477
4478 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4479 for fringe update unless it has periodic bitmap.
4480
f16d9837
KH
44812011-05-25 Kenichi Handa <handa@m17n.org>
4482
4483 * xdisp.c (get_next_display_element): Set correct it->face_id for
4484 a static composition.
4485
e1b90ef6
LL
44862011-05-24 Leo Liu <sdl.web@gmail.com>
4487
4488 * deps.mk (fns.o):
4489 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4490
4491 * fns.c (crypto_hash_function, Fsha1): New function.
4492 (Fmd5): Use crypto_hash_function.
4493 (syms_of_fns): Add Ssha1.
4494
7400048f
PE
44952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4496
4497 * gnutls.c: Remove unused macros.
4498 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4499 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4500 Remove macros that are defined and never used.
4501 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4502
abb71cf4
CY
45032011-05-22 Chong Yidong <cyd@stupidchicken.com>
4504
4505 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4506 (Fx_get_selection_internal): Minor cleanup.
4507 (Fx_own_selection_internal): Rename arguments for consistency with
4508 select.el.
4509
6307db39
PE
45102011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4511
4512 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4513
f3d4e0a4
CY
45142011-05-22 Chong Yidong <cyd@stupidchicken.com>
4515
4516 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4517
4d8ade89
YM
45182011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4519
4520 * dispnew.c (scrolling_window): Don't exclude the case that the
4521 last enabled row in the desired matrix touches the bottom boundary.
4522
32078c8d
GM
45232011-05-21 Glenn Morris <rgm@gnu.org>
4524
4525 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4526 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4527 and add some more files.
32078c8d 4528
7285dc67
EZ
45292011-05-20 Eli Zaretskii <eliz@gnu.org>
4530
4531 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4532 report_file_error introduced by the change from 2011-05-07.
4533
89d1bd22
PE
45342011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4535
4536 * systime.h (Time): Define only if emacs is defined.
4537 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4538 where the include path doesn't have X11/X.h by default. See
4539 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4540
e23640bb 45412011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4542
4543 * composite.c (find_automatic_composition): Fix previous change.
4544
b9704ad9
GM
45452011-05-20 Glenn Morris <rgm@gnu.org>
4546
4547 * lisp.mk: New file, split from Makefile.in.
4548 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4549 (shortlisp): Remove.
4550 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4551
4a720484
GM
45522011-05-19 Glenn Morris <rgm@gnu.org>
4553
4554 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4555 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4556 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4557 (lisp): Set the order to that of loadup.el.
4558 (shortlisp): Make it a copy of $lisp.
4559 (SOME_MACHINE_LISP): Remove.
4560 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4561 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4562
a28d4396
KH
45632011-05-18 Kenichi Handa <handa@m17n.org>
4564
4565 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4566 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4567 (find_automatic_composition): Mostly rewrite for efficiency.
4568
a2b1fa8e
JB
45692011-05-18 Juanma Barranquero <lekktu@gmail.com>
4570
4571 * makefile.w32-in: Update dependencies.
4572
8e1f5610
CS
45732011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4574
4575 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4576 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4577
7025ee00 45782011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4579
cdfa6eab
PE
4580 Fix some integer overflow issues, such as string length overflow.
4581
06d6db33
PE
4582 * insdel.c (count_size_as_multibyte): Check for string overflow.
4583
2b4560a8
PE
4584 * character.c (lisp_string_width): Check for string overflow.
4585 Use EMACS_INT, not int, for string indexes and lengths; in
4586 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4587 the resulting string length overflows an EMACS_INT; instead,
4588 report a string overflow if no precision given. When checking for
4589 precision exhaustion, use a check that cannot possibly have
4590 integer overflow. (Bug#8675)
4591 * character.h (lisp_string_width): Adjust to new signature.
4592
cb93f9be
PE
4593 * alloc.c (string_overflow): New function.
4594 (Fmake_string): Use it. This doesn't change behavior, but saves
4595 a few bytes and will simplify future changes.
4596 * character.c (string_escape_byte8): Likewise.
4597 * lisp.h (string_overflow): New decl.
4598
1a1f3366
PE
4599 Fixups, following up to the user-interface timestamp change.
4600 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4601 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4602 * msdos.c (mouse_get_pos): Likewise.
4603 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4604 * w32gui.h (Time): Define by including "systime.h" rather than by
4605 declaring it ourselves. (Bug#8664)
4606
d4e3e4d3
PE
4607 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4608 * image.c (clear_image_cache): Likewise.
4609
f6a24d19
PE
4610 * term.c (term_mouse_position): Don't assume time_t wraparound.
4611
08dc5ae6
PE
4612 Be more systematic about user-interface timestamps.
4613 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4614 and sometimes 'EMACS_UINT', to represent these timestamps.
4615 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4616 This makes the code easier to follow, and makes it easier to catch
4617 integer overflow bugs such as Bug#8664.
4618 * frame.c (Fmouse_position, Fmouse_pixel_position):
4619 Use Time, not unsigned long, for user-interface timestamps.
4620 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4621 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4622 * keyboard.h (last_event_timestamp): Likewise.
4623 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4624 * menu.h (xmenu_show): Likewise.
4625 * term.c (term_mouse_position): Likewise.
4626 * termhooks.h (struct input_event.timestamp): Likewise.
4627 (struct terminal.mouse_position_hook): Likewise.
4628 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4629 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4630 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4631 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4632 what it was before.
4633 * menu.h, termhooks.h: Include "systime.h", for Time.
4634
8e55734a
PE
4635 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4636 Don't assume that the difference between two unsigned long values
4637 can fit into an integer. At this point, we know button_down_time
4638 <= event->timestamp, so the difference must be nonnegative, so
4639 there's no need to cast the result if double-click-time is
4640 nonnegative, as it should be; check that it's nonnegative, just in
4641 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4642 apart (about 25 days). (Bug#8664)
8e55734a 4643
841f1b75 4644 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4645 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4646
3e26f69c
PE
4647 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4648 that always fit in int. Use a sentinel instead of a counter, to
4649 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4650 * frame.h (struct frame): Use int for menu_bar_items_used
4651 instead of EMACS_INT, since it always fits in int.
3e26f69c 4652
5cc152c0
PE
4653 * menu.c (grow_menu_items): Check for int overflow.
4654
d89eb65e
PE
4655 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4656
5235bd3e
PE
4657 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4658 Before, the code was not consistent. These values cannot exceed
4659 2**31 - 1 so there's no need to make them unsigned.
4660 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4661 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4662 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4663 as modifiers.
4664 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4665
bc827e23
PE
4666 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4667 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4668 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4669 presumably because the widths might not match.
4670
78eb494e
PE
4671 * window.c (size_window): Avoid needless test at loop start.
4672
04f2d78b
CB
46732011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4674
4675 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4676
d2fc7e3d 46772011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4678
4679 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4680
d2fc7e3d 46812011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4682
4683 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4684 `width' to `bar_area_x' and `bar_area_width', respectively.
4685 (x_scroll_run): Take account of fringe background extension.
4686
04f2d78b
CB
4687 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4688 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4689 `bar_area_width', respectively.
4690 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4691 background extension.
4692
79b70037
GM
46932011-05-10 Jim Meyering <meyering@redhat.com>
4694
4695 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4696
2f142cc5
JB
46972011-05-10 Juanma Barranquero <lekktu@gmail.com>
4698
4699 * image.c (Finit_image_library): Return t for built-in image types,
4700 like pbm and xbm. (Bug#8640)
4701
57679c86
AS
47022011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4703
4704 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4705
888c9e86
EZ
47062011-05-07 Eli Zaretskii <eliz@gnu.org>
4707
b0512a1d
EZ
4708 * w32console.c (Fset_screen_color): Doc fix.
4709 (Fget_screen_color): New function.
4710 (syms_of_ntterm): Defsubr it.
4711
7285dc67
EZ
4712 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4713 unlink the temporary file if Fcall_process didn't create it in the
4714 first place.
4715 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4716 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4717 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4718 cue to call_process_cleanup not to close that handle.
4719
4d3fcc8e
BK
47202011-05-07 Ben Key <bkey76@gmail.com>
4721
4722 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4723 one of two shell specific rules, either bootstrap-temacs-CMD or
4724 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4725 to the previous implementation of the bootstrap-temacs rule.
4726 The bootstrap-temacs-CMD rule is similar to the previous
4727 implementation of the bootstrap-temacs rule except that it
4728 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4729 variable.
4730
4731 These changes, along with some changes to nt/configure.bat,
4732 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4733 earlier fix to add support for --cflags and --ldflags options
4734 that include quotes so that it works whether make uses cmd or
4735 sh as the shell.
4736
b4289b64
MA
47372011-05-06 Michael Albinus <michael.albinus@gmx.de>
4738
4739 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4740 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4741 is a constant.
4742 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4743 a string. Handle both cases.
4744 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4745 (Fdbus_register_method): Use Qinvalid_function.
4746
af4c0e28
JB
47472011-05-06 Juanma Barranquero <lekktu@gmail.com>
4748
4749 * makefile.w32-in: Update dependencies.
4750 (LISP_H): Add inttypes.h and stdin.h.
4751 (PROCESS_H): Add unistd.h.
4752
c51453d9
EZ
47532011-05-06 Eli Zaretskii <eliz@gnu.org>
4754
4755 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4756 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4757
8ff0ac3c 47582011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4759
4c4b566b
PE
4760 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4761
aab2b9b5
PE
4762 * term.c (vfatal): Remove stray call to va_end.
4763 It's not needed and the C Standard doesn't allow it here anyway.
4764
c378da0b
PE
4765 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4766 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4767
288b08c7
PE
4768 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4769 bytes.
4770
e3601888
PE
4771 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4772
db6c0e74
PE
4773 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4774
dd5963ea
PE
4775 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4776
88c9450f
PE
4777 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4778
2f9442b8
PE
4779 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4780
c032b5f8
PE
4781 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4782 * charset.c (Fdefine_charset_internal): Don't initialize
4783 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4784 32-bit int (Bug#8600).
a108c10b
PE
4785
4786 * lread.c (read_integer): Be more consistent with string-to-number.
4787 Use string_to_number to do the actual conversion; this avoids
4788 rounding errors and fixes some other screwups. Without this fix,
4789 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4790 (digit_to_number): Move earlier, for benefit of read_integer.
4791 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4792 not a digit in any supported base. (Bug#8602)
a108c10b 4793
ad5f9eea
PE
4794 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4795
aec1708a
PE
4796 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4797 to match comment at start of function. This also removes a
4798 GCC warning about overflow in a 32+64-bit port.
4799
47be4ab5
PE
4800 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4801
371cac43
PE
4802 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4803 Reported by Stefan Monnier in
4804 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4805 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4806 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4807
d01a7826
PE
4808 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4809 (EMACS_UINTPTR): Likewise, with uintptr_t.
4810
7fd47d5c
PE
4811 * lisp.h: Prefer 64-bit EMACS_INT if available.
4812 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4813 on 32-bit hosts that have 64-bit int, so that they can access
4814 large files.
122b0c86
PE
4815 However, temporarily disable this change unless the temporary
4816 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4817
8727937b
PE
4818 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4819
8ac068ac
PE
4820 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4821 This removes an assumption that EMACS_INT and long are the same
4822 width as pointers. The assumption is true for Emacs porting targets
4823 now, but we want to make other targets possible.
4824 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4825 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4826 In the rest of the code, change types of integers that hold casted
4827 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4828 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4829 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4830 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4831 No need to cast type when ORing.
4832 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4833 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4834 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4835 assume EMACS_INT is the same width as char *.
4836 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4837 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4838 Remove no-longer-needed casts.
4839 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4840 (xg_tool_bar_help_callback, xg_make_tool_item):
4841 Use EMACS_INTPTR to hold an integer
4842 that will be cast to void *; this can avoid a GCC warning
4843 if EMACS_INT is not the same width as void *.
4844 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4845 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4846 (current_message_1, set_message_1):
4847 Use a local to convert to proper width without a cast.
4848 * xmenu.c (dialog_selection_callback): Likewise.
4849
ede49d71
PE
4850 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4851 Also, don't assume VALBITS / RAND_BITS is less than 5,
4852 and don't rely on undefined behavior when shifting a 1 left into
4853 the sign bit.
4854 * lisp.h (get_random): Change signature to match.
4855
2f30ecd0
PE
4856 * lread.c (hash_string): Use size_t, not int, for hash computation.
4857 Normally we prefer signed values; but hashing is special, because
4858 it's better to use unsigned division on hash table sizes so that
4859 the remainder is nonnegative. Also, size_t is the natural width
4860 for hashing into memory. The previous code used 'int', which doesn't
4861 retain enough info to hash well into very large tables.
4862 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4863
2a866e7b
PE
4864 * dbusbind.c: Don't possibly lose pointer info when converting.
4865 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4866 Use XPNTR rather than XHASH, so that the high-order bits of
4867 the pointer aren't lost when converting through void *.
4868
51639eac
PE
4869 * eval.c (Fautoload): Don't double-shift a pointer.
4870
92394119
PE
4871 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4872
dbdb9a7c
JB
48732011-05-06 Juanma Barranquero <lekktu@gmail.com>
4874
4875 * gnutls.c (DEF_GNUTLS_FN):
4876 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4877
db7a0b4f
AS
48782011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4879
4880 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4881 marker. (Bug#8610)
4882
f7ff1b0f 48832011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4884
4885 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4886 New version that can reserve upto 2GB of heap space.
4887
f7ff1b0f 48882011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4889
4890 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4891
639c109b
TZ
48922011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4893
4894 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4895 `gnutls_certificate_set_x509_key_file'.
4896
d2127135
JB
48972011-05-05 Juanma Barranquero <lekktu@gmail.com>
4898
4899 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4900 Update dependencies.
4901
e968f4f3
JB
49022011-05-04 Juanma Barranquero <lekktu@gmail.com>
4903
4904 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4905 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4906 Remove unused parameter `fildes'.
4907 * process.c (read_process_output, send_process): Don't pass it.
4908
84d358f0
JB
49092011-05-04 Juanma Barranquero <lekktu@gmail.com>
4910
4911 Fix previous change: the library cache is defined in w32.c.
4912 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4913 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4914
0898ca10
JB
49152011-05-04 Juanma Barranquero <lekktu@gmail.com>
4916
4917 Implement dynamic loading of GnuTLS on Windows.
4918
4919 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4920 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4921 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4922 Declare.
4923
4924 * gnutls.c (Qgnutls_dll): Define.
4925 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4926 (gnutls_*): Declare function pointers.
4927 (init_gnutls_functions): New function to initialize function pointers.
4928 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4929 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4930 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4931 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4932 (emacs_gnutls_write, emacs_gnutls_read)
4933 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4934 (Fgnutls_available_p): New function.
4935 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4936 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4937 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4938
4939 * image.c: Include w32.h.
4940 (Vimage_type_cache): Delete.
4941 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4942 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4943 (w32_delayed_load): Move to w32.c.
4944
4945 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4946
4947 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4948 (w32_delayed_load): Move from image.c. When loading a library, record
4949 its filename in the :loaded-from property of the library id.
4950 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4951 Initialize and staticpro them.
4952 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4953
4954 * process.c: Include lisp.h before w32.h, not after.
4955 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4956 instead of gnutls_record_check_pending.
4957
4958 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4959
ff4de4aa
TZ
49602011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4961
4962 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4963 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4964 as passed in.
4965
abe95abb
JD
49662011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4967
4968 * xterm.c (x_set_frame_alpha): Do not set property on anything
4969 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4970
e16e55d4
JB
49712011-05-02 Juanma Barranquero <lekktu@gmail.com>
4972
4973 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4974
bafcf6a5
JB
49752011-05-02 Juanma Barranquero <lekktu@gmail.com>
4976
4977 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4978 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4979 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4980 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4981 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4982 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4983 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4984 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4985 (Qgnutls_bootprop_callbacks_verify): Make static.
4986
e7a6747f
AS
49872011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4988
19ed11ba
AS
4989 * callproc.c: Indentation fixup.
4990
e7a6747f 4991 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4992 (wait_for_termination, interruptible_wait_for_termination):
4993 Move after wait_for_termination_1.
e7a6747f 4994
1ef14cb4
LMI
49952011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4996
4997 * sysdep.c (interruptible_wait_for_termination): New function
4998 which is like wait_for_termination, but allows keyboard
4999 interruptions.
5000
5001 * callproc.c (Fcall_process): Add (:file "file") as an option for
5002 the STDOUT buffer.
5003 (Fcall_process_region): Ditto.
5004
330d880c
EZ
50052011-04-30 Eli Zaretskii <eliz@gnu.org>
5006
8db90b73
EZ
5007 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5008 rather than `XVECTOR (FOO)->size'.
5009
330d880c
EZ
5010 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5011 inttypes.h, as a gnulib replacement is used if it not available in
5012 system headers.
5013
15cbd324
EZ
50142011-04-21 Eli Zaretskii <eliz@gnu.org>
5015
5016 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5017 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5018 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5019
5020 * coding.c (coding_alloc_by_realloc): Error out if destination
5021 will grow beyond MOST_POSITIVE_FIXNUM.
5022 (decode_coding_emacs_mule): Abort if there isn't enough place in
5023 charbuf for the composition carryover bytes. Reserve an extra
5024 space for up to 2 characters produced in a loop.
5025 (decode_coding_iso_2022): Abort if there isn't enough place in
5026 charbuf for the composition carryover bytes.
5027
50282011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5029
ae940cca
EZ
5030 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5031 aborting when %lld or %lll format is passed.
5032 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5033 %llo or %llx format is passed. (Bug#8545)
5034
03ab8921
EZ
5035 * window.c (window_scroll_line_based): Use a marker instead of
5036 simple variables to record original value of point. (Bug#7952)
5037
afda1437
EZ
5038 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5039 produced by %s or %c overflows available buffer space. (Bug#8545)
5040
f76dee0c
PE
50412011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5042
5043 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5044 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5045
fdc5744d
JB
50462011-04-28 Juanma Barranquero <lekktu@gmail.com>
5047
5048 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5049
638f053a
JB
50502011-04-28 Juanma Barranquero <lekktu@gmail.com>
5051
5052 * keyboard.c (Qdelayed_warnings_hook): Define.
5053 (command_loop_1): Run `delayed-warnings-hook'
5054 if Vdelayed_warnings_list is non-nil.
5055 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5056 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5057
d178f871
EZ
50582011-04-28 Eli Zaretskii <eliz@gnu.org>
5059
5060 * doprnt.c (doprnt): Don't return value smaller than the buffer
5061 size if the message was truncated. (Bug#8545).
5062
b124fd93
JB
50632011-04-28 Juanma Barranquero <lekktu@gmail.com>
5064
5065 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5066 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5067
e810457d
PE
50682011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5069
5070 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5071
ea51cceb
JB
50722011-04-27 Juanma Barranquero <lekktu@gmail.com>
5073
5074 * makefile.w32-in: Update dependencies.
5075
94dcfacf
EZ
50762011-04-27 Eli Zaretskii <eliz@gnu.org>
5077
5078 Improve `doprnt' and its usage. (Bug#8545)
5079 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5080 `format_end'. Remove support for %l as a conversion specifier.
5081 Don't use xrealloc. Improve diagnostics when the %l size modifier
5082 is used. Update the commentary.
5083
5084 * eval.c (verror): Simplify calculation of size_t.
5085
5086 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5087 messages.
5088
f61f41d7
PE
50892011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5090
5091 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5092 change.
5093
96fb4434
PE
50942011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5095
5096 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5097 This makes this file independent of the recent pseudovector change.
5098
671875da 50992011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5100
69e9b5a3
PE
5101 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5102
b5f869a7 5103 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5104 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5105 Remove unused local.
c8926152 5106 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5107
841a1577 5108 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5109 GCC 4.6.0 optimizes based on type-based alias analysis.
5110 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5111 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5112 != &v->size, and therefore "v->size = 1; b->size = 2; return
5113 v->size;" must therefore return 1. This assumption is incorrect
5114 for Emacs, since it type-puns struct Lisp_Vector * with many other
5115 types. To fix this problem, this patch adds a new type struct
f904488f 5116 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5117 and pseudovectors, and helps optimizing compilers not get fooled
5118 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5119 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5120 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5121 the size member.
eab3844f
PE
5122 (XSETPVECTYPE): Rewrite in terms of new macro.
5123 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5124 This is a bit clearer, and further avoids the possibility of
5125 undesirable aliasing.
5126 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5127 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5128 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5129 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5130 (ASIZE): Now uses header.size rather than size.
5131 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5132 to avoid the hassle of writing XVECTOR (foo)->header.size.
5133 (struct vectorlike_header): New type.
eab3844f
PE
5134 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5135 object, to help avoid aliasing.
5136 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5137 (SUBRP): Likewise, since Lisp_Subr is a special case.
5138 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5139 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5140 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5141 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5142 changed to be "header.size" and "header.next".
5143 * buffer.h (struct buffer): Likewise.
5144 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5145 * frame.h (struct frame): Likewise.
5146 * process.h (struct Lisp_Process): Likewise.
5147 * termhooks.h (struct terminal): Likewise.
5148 * window.c (struct save_window_data, struct saved_window): Likewise.
5149 * window.h (struct window): Likewise.
5150 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5151 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5152 * buffer.c (init_buffer_once): Likewise.
5153 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5154 special case.
5155 * process.c (Fformat_network_address): Use local var for size,
5156 for brevity.
5157
0df1eac5
PE
5158 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5159
847ab9d1 5160 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5161 * data.c (atof): Remove decl; no longer used or needed.
5162 (digit_to_number): Move to lread.c.
5163 (Fstring_to_number): Use new string_to_number function, to be
5164 consistent with how the Lisp reader treats infinities and NaNs.
5165 Do not assume that floating-point numbers represent EMACS_INT
5166 without losing information; this is not true on most 64-bit hosts.
5167 Avoid double-rounding errors, by insisting on integers when
5168 parsing non-base-10 numbers, as the documentation specifies.
5169 * lisp.h (string_to_number): New decl, replacing ...
5170 (isfloat_string): Remove.
bc0a5c13 5171 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5172 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5173 appears to have been a coding error. Similarly, do not accept
5174 strings like +-1e0 as floating point numbers. Do not report
5175 overflow for integer overflows unless the base is not 10 which
5176 means we have no simple and reliable way to continue.
5177 Break out the floating-point parsing into a new
5178 function string_to_number, so that Fstring_to_number parses
5179 floating point numbers consistently with the Lisp reader.
04f2d78b 5180 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5181 (E_CHAR, EXP_INT): Remove, replacing with ...
5182 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5183 (string_to_number): New function, replacing isfloat_string.
5184 This function checks for valid syntax and produces the resulting
5185 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5186 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5187 so that overflow for non-base-10 numbers is reported only when
5188 there's no portable and simple way to convert to floating point.
452f4150 5189
67769ffc
PE
5190 * textprop.c (set_text_properties_1): Rewrite for clarity,
5191 and to avoid GCC warning about integer overflow.
5192
c20db43f
PE
5193 * intervals.h (struct interval): Use EMACS_INT for members
5194 where EMACS_UINT might cause problems. See
5195 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5196 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5197 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5198 All uses changed.
37aa2f85
PE
5199 (offset_intervals): Tell GCC not to worry about length overflow
5200 when negating a negative length.
c20db43f 5201
2538aa2f
PE
5202 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5203 (overrun_check_free): Likewise.
5204
f2d3008d
PE
5205 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5206 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5207 word size.
5208
ec8df744
PE
5209 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5210 (gnutls_make_error): Rename local to avoid shadowing.
5211 (gnutls_emacs_global_deinit): ifdef out; not used.
5212 (Fgnutls_boot): Use const for pointer to readonly storage.
5213 Comment out unused local. Fix pointer signedness problems.
5214
640ee02d
PE
5215 * lread.c (openp): Don't stuff size_t into an 'int'.
5216 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5217 about possible signed overflow.
5218
6048fb2a
PE
5219 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5220 (GDK_KEY_g): Don't define if already defined.
5221 (xg_prepare_tooltip): Avoid pointer signedness problem.
5222 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5223
fa3c87e1
PE
5224 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5225 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5226
2172544b
PE
5227 * xfns.c (Fx_window_property): Simplify a bit,
5228 to make a bit faster and to avoid GCC 4.6.0 warning.
5229 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5230
9b821a21
PE
5231 * fns.c (internal_equal): Don't assume size_t fits in int.
5232
3c616cfa
PE
5233 * alloc.c (compact_small_strings): Tighten assertion a little.
5234
c2982e87
PE
5235 Replace pEd with more-general pI, and fix some printf arg casts.
5236 * lisp.h (pI): New macro, generalizing old pEd macro to other
5237 conversion specifiers. For example, use "...%"pI"d..." rather
5238 than "...%"pEd"...".
5239 (pEd): Remove. All uses replaced with similar uses of pI.
5240 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5241 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5242 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5243 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5244 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5245 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5246 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5247 64-bit hosts.
5248 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5249 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5250 * print.c (safe_debug_print, print_object): Likewise.
5251 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5252 to int.
6f04d126
PE
5253 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5254 avoiding the 0 flag, which is not portable.
c2982e87
PE
5255 * process.c (Fmake_network_process): Use pI to avoid cast.
5256 * region-cache.c (pp_cache): Likewise.
5257 * xdisp.c (decode_mode_spec): Likewise.
5258 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5259 behavior on 64-bit hosts with printf arg.
6f04d126 5260 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5261 (x_stop_queuing_selection_requests): Likewise.
5262 (x_get_window_property): Don't truncate byte count to an 'int'
5263 when tracing.
0b432f21 5264
5e073ec7
PE
5265 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5266 here, since it parses constructs like leading '-' and spaces,
5267 which are not wanted; and it overflows with large numbers.
5268 Instead, simply match F[0-9]+, which is what is wanted anyway.
5269
36372bf9
PE
5270 * alloc.c: Remove unportable assumptions about struct layout.
5271 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5272 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5273 (allocate_vectorlike, make_pure_vector): Use the new macros,
5274 plus offsetof, to remove unportable assumptions about struct layout.
5275 These assumptions hold on all porting targets that I know of, but
5276 they are not guaranteed, they're easy to remove, and removing them
5277 makes further changes easier.
5278
0b432f21
PE
5279 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5280 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5281 (string_overrun_cookie): Now const. Use initializers that
5282 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5283 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5284 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5285 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5286 multiple of sizeof (EMACS_INT); it need not be, if
5287 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5288 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5289
895009e1
JB
52902011-04-26 Juanma Barranquero <lekktu@gmail.com>
5291
5292 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5293
6a7a1b0b
TZ
52942011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5295
5296 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5297 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5298 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5299
841a1577 53002011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5301
5302 * lisp.h (Qdebug): List symbol.
895009e1 5303 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5304 * keyboard.c (debug-on-event): New variable.
5305 (handle_user_signal): Break into debugger when debug-on-event
5306 matches the current signal symbol.
5307
f2d3ba6f
DN
53082011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5309
5310 * alloc.c (check_sblock, check_string_bytes)
5311 (check_string_free_list): Convert to standard C.
5312
42ce4c63
TZ
53132011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5314
5315 * w32.c (emacs_gnutls_push): Fix typo.
5316
825cd63c
EZ
53172011-04-25 Eli Zaretskii <eliz@gnu.org>
5318
fb11d64d
EZ
5319 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5320 "cast to pointer from integer of different size".
5321
825cd63c
EZ
5322 Improve doprnt and its use in verror. (Bug#8545)
5323 * doprnt.c (doprnt): Document the set of format control sequences
5324 supported by the function. Use SAFE_ALLOCA instead of always
5325 using `alloca'.
5326
5327 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5328 is one byte too soon. Don't use xrealloc; instead xfree and
5329 xmalloc anew.
5330
e061a11b
TZ
53312011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5332
5333 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5334 callbacks stage.
5335
5336 * gnutls.c: Renamed global_initialized to
5337 gnutls_global_initialized. Added internals for the
5338 :verify-hostname-error, :verify-error, and :verify-flags
5339 parameters of `gnutls-boot' and documented those parameters in the
5340 docstring. Start callback support.
9173deec
JB
5341 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5342 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5343 on error. Return error code.
e061a11b
TZ
5344 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5345 (emacs_gnutls_read): Likewise.
5346 (Fgnutls_boot): Return handshake error code.
5347 (emacs_gnutls_handle_error): New function.
5348 (wsaerror_to_errno): Likewise.
5349
5350 * w32.h (emacs_gnutls_pull): Add prototype.
5351 (emacs_gnutls_push): Likewise.
5352
5353 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5354 (emacs_gnutls_push): Likewise.
5355
53562011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5357
5358 * process.c (wait_reading_process_output): Check if GnuTLS
5359 buffered some data internally if no FDs are set for TLS
5360 connections.
5361
5362 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5363 (LIBS): Link to USER_LIBS.
5364 ($(BLD)/gnutls.$(0)): New target.
5365
fa6996bc
EZ
53662011-04-24 Eli Zaretskii <eliz@gnu.org>
5367
eb35682e
EZ
5368 * xdisp.c (handle_single_display_spec): Rename the
5369 display_replaced_before_p argument into display_replaced_p, to
5370 make it consistent with the commentary. Fix typos in the
5371 commentary.
5372
e2ad650c
EZ
5373 * textprop.c (syms_of_textprop): Remove dead code.
5374 (copy_text_properties): Delete obsolete commentary about an
5375 interface that was deleted long ago. Fix typos in the description
5376 of arguments.
5377
1b2de274
EZ
5378 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5379 to changes in oldXMenu/XMenu.h from 2011-04-16.
5380 <menu_help_message, prev_menu_help_message>: Constify.
5381 (IT_menu_make_room): menu->help_text is now `const char **';
5382 adjust.
5383
5384 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5385 to changes in oldXMenu/XMenu.h from 2011-04-16.
5386 (struct XMenu): Declare `help_text' `const char **'.
5387
5388 * xfaces.c <Qunspecified>: Make extern again.
5389
5390 * syntax.c: Include sys/types.h before including regex.h, as
5391 required by Posix.
5392
762b15be
EZ
5393 * doc.c (get_doc_string): Improve the format passed to `error'.
5394
5395 * doprnt.c (doprnt): Improve commentary.
5396
5397 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5398
5399 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5400 them with etags.
5401
f1052e5d
EZ
5402 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5403 changes in globals.h immediately force recompilation.
762b15be
EZ
5404 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5405 $(CURDIR)/s/ms-w32.h.
5406 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5407
fa6996bc
EZ
5408 * character.c (Fchar_direction): Function deleted.
5409 (syms_of_character): Don't defsubr it.
5410 <char-direction-table>: Deleted.
5411
e6c3da20
EZ
54122011-04-23 Eli Zaretskii <eliz@gnu.org>
5413
5414 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5415 * doprnt.c: Include limits.h.
5416 (SIZE_MAX): New macro.
04f2d78b
CB
5417 (doprnt): Return a size_t value. 2nd arg is now size_t.
5418 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5419 Improve overflow protection. Support `l' modifier for integer
5420 conversions. Support %l conversion. Don't assume an EMACS_INT
5421 argument for integer conversions and for %c.
5422
5423 * lisp.h (doprnt): Restore prototype.
5424
5425 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5426 $(SRC)/character.h.
5427
5428 * Makefile.in (base_obj): Add back doprnt.o.
5429
5430 * deps.mk (doprnt.o): Add back prerequisites.
5431 (callint.o): Depend on character.h.
5432
5433 * eval.c (internal_lisp_condition_case): Include the handler
5434 representation in the error message.
5435 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5436 when breaking from the loop.
5437
5438 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5439
5440 * callint.c (Fcall_interactively): When displaying error message
5441 about invalid control letter, pass the character's codepoint, not
5442 a pointer to its multibyte form. Improve display of the character
5443 in octal and display also its hex code.
5444
5445 * character.c (char_string): Use %x to display the (unsigned)
5446 codepoint of an invalid character, to avoid displaying a bogus
5447 negative value.
5448
5449 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5450 `error', not SYMBOL_NAME itself.
5451
5452 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5453 character arguments to `error'.
5454
5455 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5456 to `error' in error message about FINAL_CHAR argument. Make sure
5457 FINAL_CHAR is a character, and use %c when it is passed as
5458 argument to `error'.
5459
4ffd0d6b 54602011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5461
5462 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5463
5464 * w32.c: Include <time.h>.
5465 (sys_localtime): New function.
5466
4ffd0d6b 54672011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5468
5469 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5470
4ffd0d6b 5471 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5472
4ffd0d6b 54732011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5474
4ffd0d6b
GM
5475 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5476 zombies (Bug#8467).
aac0c6e3 5477
04c56954
EZ
54782011-04-19 Eli Zaretskii <eliz@gnu.org>
5479
5480 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5481 gl_state.e_property when gl_state.object is Qt.
5482
5483 * insdel.c (make_gap_larger): Remove limitation of buffer size
5484 to <= INT_MAX.
5485
16a43933
CY
54862011-04-18 Chong Yidong <cyd@stupidchicken.com>
5487
5488 * xdisp.c (lookup_glyphless_char_display)
5489 (produce_glyphless_glyph): Handle cons cell entry in
5490 glyphless-char-display.
5491 (Vglyphless_char_display): Document it.
5492
5493 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5494 glyphless-char-display.
5495
4581706e
CY
54962011-04-17 Chong Yidong <cyd@stupidchicken.com>
5497
5498 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5499
5500 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5501
5502 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5503 definition for no-X builds.
5504
4887c6e2 55052011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5506
fd35b6f9
PE
5507 Static checks with GCC 4.6.0 and non-default toolkits.
5508
5c1ccb01
PE
5509 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5510
006c5daa
PE
5511 * process.c (keyboard_bit_set): Define only if SIGIO.
5512 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5513 (send_process): Repair possible setjmp clobbering.
5514
efc736d3
PE
5515 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5516
4e2fe2e6
PE
5517 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5518
f97334a2
PE
5519 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5520
4e75f29d
PE
5521 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5522 Define only if needed.
5523
90efadd1
PE
5524 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5525 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5526 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5527
3c647824
PE
5528 * dispextern.h (struct redisplay_interface): Rename param
5529 to avoid shadowing.
e264f262 5530 * termhooks.h (struct terminal): Likewise.
761383f4 5531 * xterm.c (xembed_send_message): Likewise.
3c647824 5532
b58c5c4a
PE
5533 * insdel.c (make_gap_smaller): Define only if
5534 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5535
cad59032
PE
5536 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5537 it.
5538
c339dc2e
PE
5539 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5540 so that we aren't warned about unused symbols.
5541
91a3e27b
PE
5542 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5543
399c71d3 5544 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5545
8ffc96f5
PE
5546 * xfns.c (x_real_positions): Mark locals as initialized.
5547
eef9bc79
PE
5548 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5549
098db9dd
PE
5550 * xterm.c: Fix problems found by static analysis with other toolkits.
5551 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5552 (x_dispatch_event): Declare static if USE_GTK, and
5553 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5554 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5555 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5556 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5557 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5558
eb18f6cc
PE
5559 * xmenu.c (menu_help_callback): Pointer type fixes.
5560 Use const pointers when pointing at readonly data. Avoid pointer
5561 signedness clashes.
5562 (FALSE): Remove unused macro.
5563 (update_frame_menubar): Remove unused decl.
5564
1fe72bf8
PE
5565 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5566
60d9e1db
PE
5567 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5568 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5569 (single_menu_item): Rename local to avoid shadowing.
5570
39261c26
PE
5571 * keyboard.c (make_lispy_event): Remove unused local var.
5572
018c5e19
PE
5573 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5574 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5575
63d2b86e
PE
5576 * bitmaps: Change bitmaps from unsigned char back to the X11
5577 compatible char. Avoid the old compiler warnings about
5578 out-of-range initializers by using, for example, '\xab' rather
5579 than 0xab.
5580
aefd87e1
PE
5581 * xgselect.c (xgselect_initialize): Check vs interface
5582 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5583
bf501fb9
PE
5584 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5585
e9829fdf
PE
5586 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5587 to read-only memory.
5588
1086c095
PE
5589 * fns.c (vector): Remove; this old hack is no longer needed.
5590
2baccd04 5591 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5592 Remove unused var.
dde42981 5593 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5594
72391843 5595 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5596
436c16df 5597 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5598 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5599 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5600
92bb796d 5601 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5602 (x_term_init): Remove local to avoid shadowing.
92bb796d 5603
764430a3 5604 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5605
5606 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5607 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5608
d1dfb56c
EZ
56092011-04-16 Eli Zaretskii <eliz@gnu.org>
5610
c4354cb4
EZ
5611 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5612
d1dfb56c
EZ
5613 Fix regex.c, syntax.c and friends for buffers > 2GB.
5614 * syntax.h (struct gl_state_s): Declare character position members
5615 EMACS_INT.
5616
5617 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5618
04f2d78b
CB
5619 * textprop.c (verify_interval_modification, interval_of):
5620 Declare arguments EMACS_INT.
d1dfb56c
EZ
5621
5622 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5623 EMACS_INT.
5624
5625 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5626
5627 * indent.c (Fvertical_motion): Local variable it_start is now
5628 EMACS_INT.
5629
5630 * regex.c (re_match, re_match_2, re_match_2_internal)
5631 (bcmp_translate, regcomp, regexec, print_double_string)
5632 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5633 (re_compile_pattern, re_exec): Declare arguments and local
5634 variables `size_t' and `ssize_t' and return values `regoff_t', as
5635 appropriate.
5636 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5637 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5638 <compile_stack_type>: `size' and `avail' are now `size_t'.
5639
5640 * regex.h <regoff_t>: Use ssize_t, not int.
5641 (re_search, re_search_2, re_match, re_match_2): Arguments that
5642 specify buffer/string position and length are now ssize_t and
5643 size_t. Return type is regoff_t.
5644
613052cd
BK
56452011-04-16 Ben Key <bkey76@gmail.com>
5646
5647 * nsfont.m: Fixed bugs in ns_get_family and
5648 ns_descriptor_to_entity that were caused by using free to
5649 deallocate memory blocks that were allocated by xmalloc (via
5650 xstrdup). This caused Emacs to crash when compiled with
5651 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5652 --enable-checking=xmallocoverrun). xfree is now used to
5653 deallocate these memory blocks.
5654
4170f62f 56552011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5656
71b41406
PE
5657 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5658
9587a89d
PE
5659 emacs_write: Accept and return EMACS_INT for sizes.
5660 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5661 et seq.
5662 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5663 Accept and return EMACS_INT.
5664 (emacs_gnutls_write): Return the number of bytes written on
5665 partial writes.
5666 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5667 (emacs_read, emacs_write): Remove check for negative size, as the
5668 Emacs source code has been audited now.
9587a89d
PE
5669 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5670 (emacs_read, emacs_write): Use it.
273a5f82
PE
5671 * process.c (send_process): Adjust to the new signatures of
5672 emacs_write and emacs_gnutls_write. Do not attempt to store
5673 a byte offset into an 'int'; it might overflow.
9587a89d 5674 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5675
3e047f51
PE
5676 * sound.c: Don't assume sizes fit in 'int'.
5677 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5678 Return EMACS_INT, not int.
3e047f51 5679 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5680 Accept EMACS_INT, not int.
5681 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5682 record read return values.
5683
cc39a9db
BK
56842011-04-15 Ben Key <bkey76@gmail.com>
5685
c9d0ec6d
JB
5686 * keyboard.c (Qundefined): Don't declare static since it is used
5687 in nsfns.m.
5688 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5689 static since they are used in nsfont.m.
cc39a9db 5690
6c60eb9f
SM
56912011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5692
5693 * process.c (Qprocessp): Don't declare static.
5694 * lisp.h (Qprocessp): Declare again.
5695
7990b61a
JB
56962011-04-15 Juanma Barranquero <lekktu@gmail.com>
5697
5698 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5699
5d4cb038
PE
57002011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5701
8bd7b830 5702 Improve C-level modularity by making more things 'static'.
cd64ea1d 5703
e3b27b31
PE
5704 Don't publish debugger-only interfaces to other modules.
5705 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5706 (verify_bytepos, count_markers): Move decls to the only modules
5707 that need them.
5708 * region-cache.h (pp_cache): Likewise.
5709 * window.h (check_all_windows): Likewise.
5710 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5711
5d4cb038
PE
5712 * sysdep.c (croak): Now static, if
5713 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5714 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5715
5716 * alloc.c (refill_memory_reserve): Now static if
5717 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5718 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5719
e87b6180
PE
5720 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5721 Define only if USE_LUCID.
5722
ac64929e
PE
5723 * xrdb.c (x_customization_string, x_rm_string): Now static.
5724
6f37259d
PE
5725 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5726 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5727
1683e3ab
PE
5728 * xdisp.c (draw_row_with_mouse_face): Now static.
5729 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5730
de9c2632
PE
5731 * window.h (check_all_windows): Mark externally visible.
5732
2b96acb7
PE
5733 * window.c (window_deletion_count): Now static.
5734
5735 * undo.c: Make symbols static if they're not exported.
5736 (last_undo_buffer, last_boundary_position, pending_boundary):
5737 Now static.
5738
50436f33
PE
5739 * textprop.c (interval_insert_behind_hooks): Now static.
5740 (interval_insert_in_front_hooks): Likewise.
5741
64520e5c
PE
5742 * term.c: Make symbols static if they're not exported.
5743 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5744 (max_frame_lines, tty_set_terminal_modes):
5745 (tty_reset_terminal_modes, tty_turn_off_highlight):
5746 (get_tty_terminal): Now static.
5747 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5748 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5749 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5750 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5751 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5752
1fa53021
PE
5753 * sysdep.c: Make symbols static if they're not exported.
5754 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5755 Now static.
5756 (sigprocmask_set, full_mask): Remove; unused.
5757 (wait_debugging): Mark as visible.
5758 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5759 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5760
d4b43b22
PE
5761 * syntax.c (syntax_temp): Define only if !__GNUC__.
5762
b7c513d0
PE
5763 * sound.c (current_sound_device, current_sound): Now static.
5764
989b29ad
PE
5765 * search.c (searchbufs, searchbuf_head): Now static.
5766
13a55a78
PE
5767 * scroll.c (scroll_cost): Remove; unused.
5768 * dispextern.h (scroll_cost): Remove decl.
5769
de68a1fc
PE
5770 * region-cache.h (pp_cache): Mark as externally visible.
5771
40ccffa6
PE
5772 * process.c: Make symbols static if they're not exported.
5773 (process_tick, update_tick, create_process, chan_process):
5774 (Vprocess_alist, proc_buffered_char, datagram_access):
5775 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5776 (deactivate_process): Mark defn as static, as well as decl.
5777 * lisp.h (create_process): Remove decl.
5778 * process.h (chan_process, Vprocess_alist): Remove decls.
5779
ad64fc97
PE
5780 * print.c: Make symbols static if they're not exported.
5781 (print_depth, new_backquote_output, being_printed, print_buffer):
5782 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5783 (print_interval, print_number_index, initial_stderr_stream):
5784 Now static.
5785 * lisp.h (Fprinc): Remove decl.
5786 (debug_output_compilation_hack): Mark as externally visible.
5787
adddb265
PE
5788 * sysdep.c (croak): Move decl from here to syssignal.h.
5789 * syssignal.h (croak): Put it here, so the API can be checked when
5790 'croak' is called from dissociate_if_controlling_tty.
5791
1717ede2
PE
5792 * minibuf.c: Make symbols static if they're not exported.
5793 (minibuf_save_list, choose_minibuf_frame): Now static.
5794 * lisp.h (choose_minibuf_frame): Remove decl.
5795
fa5fb2bc
PE
5796 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5797
1e3890d1
PE
5798 * lread.c: Make symbols static if they're not exported.
5799 (read_objects, initial_obarray, oblookup_last_bucket_number):
5800 Now static.
5801 (make_symbol): Remove; unused.
5802 * lisp.h (initial_obarray, make_symbol): Remove decls.
5803
8a1414fa
PE
5804 * keyboard.c: Make symbols static if they're not exported.
5805 (single_kboard, recent_keys_index, total_keys, recent_keys):
5806 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5807 (this_single_command_key_start, echoing, last_auto_save):
5808 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5809 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5810 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5811 (Vlispy_mouse_stem, double_click_count):
5812 Now static.
5813 (force_auto_save_soon): Define only if SIGDANGER.
5814 (ignore_mouse_drag_p): Now static if
5815 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5816 (print_help): Remove; unused.
5817 (stop_character, last_timer_event): Mark as externally visible.
5818 * keyboard.h (ignore_mouse_drag_p): Declare only if
5819 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5820 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5821 * lisp.h (echoing): Remove decl.
5822 (force_auto_save_soon): Declare only if SIGDANGER.
5823 * xdisp.c (redisplay_window): Simplify code, to make it more
5824 obvious that ignore_mouse_drag_p is not accessed if !defined
5825 USE_GTK && !defined HAVE_NS.
5826
93ea6e8f
PE
5827 * intervals.c: Make symbols static if they're not exported.
5828 (merge_properties_sticky, merge_interval_right, delete_interval):
5829 Now static.
5830 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5831
77382fcc
PE
5832 * insdel.c: Make symbols static if they're not exported.
5833 However, leave prepare_to_modify_buffer alone. It's never
5834 called from outside this function, but that appears to be a bug.
5835 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5836 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5837 (adjust_after_replace_noundo): Remove; unused.
5838 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5839 (signal_before_change): Remove decls.
77382fcc 5840
9306c32e
PE
5841 * indent.c (val_compute_motion, val_vmotion): Now static.
5842
cd44d2eb
PE
5843 * image.c: Make symbols static if they're not exported.
5844 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5845 if USE_GTK.
5846 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5847 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5848
ad9a7a06
PE
5849 * fringe.c (standard_bitmaps): Now static.
5850 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5851
81626931
PE
5852 * frame.c: Make symbols static if they're not exported.
5853 (x_report_frame_params, make_terminal_frame): Now static.
5854 (get_frame_param): Now static, unless HAVE_NS.
5855 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5856 (x_get_resource_string): Remove; not used.
5857 * frame.h (make_terminal_frame, x_report_frame_params):
5858 (x_get_resource_string); Remove decls.
5859 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5860 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5861
239f9db9
PE
5862 * font.c, fontset.c: Make symbols static if they're not exported.
5863 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5864 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5865 * font.c (font_close_object): Now static.
5866 * font.h (font_close_object): Remove.
5867 * fontset.c (FONTSET_OBJLIST): Remove.
5868 (free_realized_fontset) #if-0 the body, which does nothing.
5869 (face_suitable_for_char_p): #if-0, as it's never called.
5870 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5871 * xfaces.c (face_at_string_position):
5872 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5873 since 0 is always ASCII.
5874
dfcf3579
PE
5875 * fns.c (weak_hash_tables): Now static.
5876
5045092b
PE
5877 * fileio.c: Make symbols static if they're not exported.
5878 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5879 (Vwrite_region_annotation_buffers): Now static.
5880
57a96f5c
PE
5881 * eval.c: Make symbols static if they're not exported.
5882 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5883 * lisp.h (backtrace_list): Remove decl.
5884
35f08c38
PE
5885 * emacs.c: Make symbols static if they're not exported.
5886 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5887 (fatal_error_code, fatal_error_signal_hook, standard_args):
5888 Now static.
5889 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5890 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5891 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5892 * lisp.h (fatal_error_signal_hook): Remove decl.
5893 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5894
f44bd759
PE
5895 * editfns.c: Move a (normally-unused) function to its only use.
5896 * editfns.c, lisp.h (get_operating_system_release): Remove.
5897 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5898 worth the hassle of breaking this out.
5899
b532497d
PE
5900 * xterm.c: Make symbols static if they're not exported.
5901 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5902 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5903 (x_destroy_window, x_delete_display):
5904 Now static.
5905 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5906 (x_mouse_leave): Remove; unused.
5907 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5908 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5909 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5910 Remove decls.
5911 (x_mouse_leave): Declare only if WINDOWSNT.
5912 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5913 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5914 USE_X_TOOLKIT.
5915
1675728f
PE
5916 * ftxfont.c: Make symbols static if they're not exported.
5917 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5918 HAVE_FREETYPE.
5919 * font.h (ftxfont_driver): Likewise.
5920
e4cebfca
PE
5921 * xfns.c: Make symbols static if they're not exported.
5922 (x_last_font_name, x_display_info_for_name):
5923 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5924 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5925 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5926 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5927 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5928 (last_show_tip_args): Now static.
5929 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5930 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5931 (x_screen_planes): Remove; unused.
5932 * dispextern.h (x_screen_planes): Remove decl.
5933
5bf46f05
PE
5934 * dispnew.c: Make symbols static if they're not exported.
5935 * dispextern.h (redraw_garbaged_frames, scrolling):
5936 (increment_row_positions): Remove.
5937 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5938 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5939 Now static.
5940 (redraw_garbaged_frames): Remove; unused.
5941
435f4c28
PE
5942 * xfaces.c: Make symbols static if they're not exported.
5943 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5944 Remove decls.
5945 * xterm.h (defined_color): Remove decls.
5946 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5947 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5948 (menu_face_changed_default, defined_color, free_realized_face):
5949 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5950 (ascii_face_of_lisp_face): Remove; unused.
5951
8524aef3
PE
5952 * xdisp.c: Make symbols static if they're not exported.
5953 * dispextern.h (scratch_glyph_row, window_box_edges):
5954 (glyph_to_pixel_coords, set_cursor_from_row):
5955 (get_next_display_element, set_iterator_to_next):
5956 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5957 (show_mouse_face): Remove decls
5958 * frame.h (message_buf_print): Likewise.
5959 * lisp.h (pop_message, set_message, check_point_in_composition):
5960 Likewise.
5961 * xterm.h (set_vertical_scroll_bar): Likewise.
5962 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5963 (message_buf_print, scratch_glyph_row, displayed_buffer):
5964 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5965 (get_next_display_element, show_mouse_face, window_box_edges):
5966 (frame_to_window_pixel_xy, check_point_in_composition):
5967 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5968 (glyph_to_pixel_coords): Remove; unused.
5969
16390cd2
PE
5970 * dired.c (file_name_completion): Now static.
5971
5972 * dbusbind.c (xd_in_read_queued_messages): Now static.
5973
a25f4dfa
PE
5974 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5975 * data.c (circular_list_error): Remove.
5976
14a9c8df
PE
5977 * commands.h (last_point_position, last_point_position_buffer):
5978 (last_point_position_window): Remove decls.
5979 * keyboard.c: Make these variables static.
5980
04f2d78b
CB
5981 * coding.h (coding, code_convert_region, encode_coding_gap):
5982 Remove decls.
74ab6df5
PE
5983 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5984 (iso_code_class, detect_coding, code_convert_region): Now static.
5985 (encode_coding_gap): Remove; unused.
5986
38dfbee1
PE
5987 * chartab.c (chartab_chars, chartab_bits): Now static.
5988
a2cb4e63
PE
5989 * charset.h (charset_iso_8859_1): Remove decl.
5990 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5991 Now static.
5992
127198fd
PE
5993 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5994 * ccl.c (Vccl_program_table): Now static.
5995 (check_ccl_update): Remove; unused.
5996
d85b608f
PE
5997 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5998 * category.h: ... from here.
5999 * category.c (check_category_table, set_category_set): Now static.
6000
31cd66f3
PE
6001 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6002 * lisp.h: Remove these decls.
6003
c358e587
PE
6004 * buffer.c (buffer_count): Remove unused var.
6005
e78aecca
PE
6006 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6007 so that it's not optimized away.
6008 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6009 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6010 exported only to the debugger.
6011
e192d7d3 6012 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6013 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6014
92470028
PE
6015 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6016 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6017 was inaccessible from Lisp.
6018 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6019 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6020
244ed907
PE
6021 alloc.c: Import and export fewer symbols, and remove unused items.
6022 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6023 is defined.
6024 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6025 it's not optimized away by whole-program optimization.
6026 (message_enable_multibyte, free_misc): Remove.
6027 (catchlist, handlerlist, mark_backtrace):
6028 Declare only if BYTE_MARK_STACK.
6029 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6030 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6031 (message_enable_multibyte): Remove decl.
6032 (free_misc, interval_free_list, float_block, float_block_index):
6033 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6034 (cons_free_list, last_marked_index):
6035 Now static.
6036 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6037 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6038 (mark_backtrace): Define only if BYTE_MARK_STACK.
6039 * xdisp.c (message_enable_multibyte): Now static.
6040
61c2b50e 6041 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6042 This makes it easier for human readers (and static analyzers)
6043 to see whether these variables are used from other modules.
6044 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6045 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6046 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6047 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6048 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6049 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6050 * xmenu.c, xselect.c:
6051 Declare Q* vars static if they are not used in other modules.
6052 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6053 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6054 Remove decls of unexported vars.
6055 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6056
95c82688
PE
6057 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6058
16a97296
PE
6059 Make Emacs functions such as Fatom 'static' by default.
6060 This makes it easier for human readers (and static analyzers)
6061 to see whether these functions can be called from other modules.
6062 DEFUN now defines a static function. To make the function external
6063 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6064 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6065 (Finit_image_library):
16a97296
PE
6066 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6067 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6068 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6069 Remove decls, since these functions are now static.
6070 (Funintern, Fget_internal_run_time): New decls, since these functions
6071 were already external.
95c82688 6072
16a97296
PE
6073 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6074 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6075 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6076 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6077 * keyboard.c, keymap.c, lread.c:
6078 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6079 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6080 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6081 Mark functions with DEFUE instead of DEFUN,
6082 if they are used in other modules.
6083 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6084 decls for now-static functions.
6085 * buffer.h (Fdelete_overlay): Remove decl.
6086 * callproc.c (Fgetenv_internal): Mark as internal.
6087 * composite.c (Fremove_list_of_text_properties): Remove decl.
6088 (Fcomposition_get_gstring): New forward static decl.
6089 * composite.h (Fcomposite_get_gstring): Remove decl.
6090 * dired.c (Ffile_attributes): New forward static decl.
6091 * doc.c (Fdocumntation_property): New forward static decl.
6092 * eval.c (Ffetch_bytecode): New forward static decl.
6093 (Funintern): Remove extern decl; now in .h file where it belongs.
6094 * fileio.c (Fmake_symbolic_link): New forward static decl.
6095 * image.c (Finit_image_library): New forward static decl.
6096 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6097 * intervals.h (Fprevious_property_change):
6098 (Fremove_list_of_text_properties): Remove decls.
6099 * keyboard.c (Fthis_command_keys): Remove decl.
6100 (Fcommand_execute): New forward static decl.
6101 * keymap.c (Flookup_key): New forward static decl.
6102 (Fcopy_keymap): Now static.
6103 * keymap.h (Flookup_key): Remove decl.
6104 * process.c (Fget_process): New forward static decl.
6105 (Fprocess_datagram_address): Mark as internal.
6106 * syntax.c (Fsyntax_table_p): New forward static decl.
6107 (skip_chars): Remove duplicate decl.
6108 * textprop.c (Fprevious_property_change): New forward static decl.
6109 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6110 Now internal.
6111 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6112 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6113
785bbd42
PE
6114 * editfns.c (Fformat): Remove unreachable code.
6115
8b913b57
AS
61162011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6117
6118 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6119 change. (Bug#8496)
6120
a6744a35
EZ
61212011-04-13 Eli Zaretskii <eliz@gnu.org>
6122
6123 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6124 when at ZV. (Bug#8487)
6125
e7974947
AS
61262011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6127
baad03f0
AS
6128 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6129 (Bug#8437)
6130 * keyboard.c (parse_tool_bar_item): Likewise.
6131 * sound.c (sound_cleanup, alsa_close): Likewise.
6132 * termcap.c (tgetent): Likewise.
6133 * xfns.c (x_default_font_parameter): Likewise.
6134 * xsettings.c (read_and_apply_settings): Likewise.
6135
e7974947
AS
6136 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6137 (overrun_check_free): Protoize.
6138
28272684
PE
61392011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6140
6141 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6142 since callers should never pass a negative size.
6143 Change the signature to match that of plain 'read' and 'write'; see
6144 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6145 * lisp.h: Update prototypes of emacs_write and emacs_read.
6146
11997c76
EZ
61472011-04-11 Eli Zaretskii <eliz@gnu.org>
6148
6149 * xdisp.c (redisplay_window): Don't try to determine the character
6150 position of the scroll margin if the window start point w->startp
e896f03c 6151 is outside the buffer's accessible region. (Bug#8468)
11997c76 6152
8a2cbd72
EZ
61532011-04-10 Eli Zaretskii <eliz@gnu.org>
6154
6155 Fix write-region and its subroutines for buffers > 2GB.
6156 * fileio.c (a_write, e_write): Modify declaration of arguments and
6157 local variables to support buffers larger than 2GB.
6158 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6159
6160 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6161 argument, local variables, and return value.
6162
6163 * lisp.h: Update prototypes of emacs_write and emacs_read.
6164
6165 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6166
4073e537 61672011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6168
1ebfdcb6
PE
6169 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6170
b2ded58d
PE
6171 Fix more problems found by GCC 4.6.0's static checks.
6172
7d66342c
PE
6173 * xdisp.c (vmessage): Use a better test for character truncation.
6174
bbf47d44
PE
6175 * charset.c (load_charset_map): <, not <=, for optimization,
6176 and to avoid potential problems with integer overflow.
9248994d 6177 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6178 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6179 * editfns.c (Fformat): Likewise.
1e69125e 6180 * syntax.c (skip_chars): Likewise.
3befa583 6181
e3019616
PE
6182 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6183 This also lets GCC 4.6.0 generate slightly better loop code.
6184
becfa255
PE
6185 * callint.c (Fcall_interactively): <, not <=, for optimization.
6186 (Fcall_interactively): Count the number of arguments produced,
6187 not the number of arguments given. This is simpler and lets GCC
6188 4.6.0 generate slightly better code.
6189
dae0cd48
PE
6190 * ftfont.c: Distingish more carefully between FcChar8 and char.
6191 The previous code passed unsigned char * to a functions like
6192 strlen and xstrcasecmp that expect char *, which does not
6193 conform to the C standard.
6194 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6195 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6196 char * when the C standard requires it.
6197
76032d70
PE
6198 * keyboard.c (read_char): Remove unused var.
6199
eb3f1cc8
PE
6200 * eval.c: Port to Windows vsnprintf (Bug#8435).
6201 Include <limits.h>.
6202 (SIZE_MAX): Define if the headers do not.
6203 (verror): Do not give up if vsnprintf returns a negative count.
6204 Instead, grow the buffer. This ports to Windows vsnprintf, which
6205 does not conform to C99. Problem reported by Eli Zaretskii.
6206 Also, simplify the allocation scheme, by avoiding the need for
6207 calling realloc, and removing the ALLOCATED variable.
6208
70476b54
PE
6209 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6210
12020a9e
PE
6211 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6212 But keep the doprint source code for now, as we might revamp it
6213 and use it again (Bug#8435).
ea6c7ae6
PE
6214 * lisp.h (doprnt): Remove.
6215 * Makefile.in (base_obj): Remove doprnt.o.
6216 * deps.mk (doprnt.o): Remove.
6217
5fdb398c
PE
6218 error: Print 32- and 64-bit integers portably (Bug#8435).
6219 Without this change, on typical 64-bit hosts error ("...%d...", N)
6220 was used to print both 32- and 64-bit integers N, which relied on
6221 undefined behavior.
6222 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6223 New macro.
6224 * lisp.h (error, verror): Mark as printf-like functions.
6225 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6226 Report overflow in size calculations when allocating printf buffer.
6227 Do not truncate output string at its first null byte.
6228 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6229 Truncate the output at a character boundary, since vsnprintf does not
6230 do that.
6231 * charset.c (check_iso_charset_parameter): Convert internal
6232 character to string before calling 'error', since %c now has the
6233 printf meaning.
6234 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6235 overflow when computing char to be passed to 'error'. Do not
6236 pass Lisp_Object to 'error'; pass the integer instead.
6237 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6238 formatted with plain %d.
6239
b189fa66
PE
6240 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6241
bff87ef0
PE
6242 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6243
7e2cac20
PE
6244 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6245
ce4d90b5
PE
6246 * xterm.c (x_catch_errors): Remove duplicate declaration.
6247
266c9547
PE
6248 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6249
79c49ad2
PE
6250 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6251
368f4090
JM
62522011-04-10 Jim Meyering <meyering@redhat.com>
6253
6254 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6255 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6256 return ssize_t not "int", and use size_t as the buffer length.
6257 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6258 * gnutls.h: Update declarations.
6259 * process.c (read_process_output): Use ssize_t, to match.
6260 (send_process): Likewise.
6261
a32d4040
CY
62622011-04-09 Chong Yidong <cyd@stupidchicken.com>
6263
6264 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6265
8546720e 62662011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6267
04f2d78b
CB
6268 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6269 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6270
8546720e
GM
6271 * xterm.c (handle_one_xevent):
6272 * xmenu.c (create_and_show_popup_menu):
6273 * xselect.c (x_decline_selection_request)
6274 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6275
0a2f5c1a 62762011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6277
6278 Fix some uses of `int' instead of EMACS_INT.
6279 * search.c (string_match_1, fast_string_match)
6280 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6281 (scan_buffer, find_next_newline_no_quit)
6282 (find_before_next_newline, search_command, Freplace_match)
6283 (Fmatch_data): Make some `int' variables be EMACS_INT.
6284
6285 * xdisp.c (display_count_lines): 3rd argument and return value now
6286 EMACS_INT. All callers changed.
6287 (pint2hrstr): Last argument is now EMACS_INT.
6288
6289 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6290 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6291 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6292 (decode_coding_utf_16, decode_coding_emacs_mule)
6293 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6294 (decode_coding_ccl, decode_coding_charset)
6295 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6296 (decode_coding_iso_2022, decode_coding_emacs_mule)
6297 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6298 <char_offset, last_offset>: Declare EMACS_INT.
6299 (encode_coding_utf_8, encode_coding_utf_16)
6300 (encode_coding_emacs_mule, encode_invocation_designation)
6301 (encode_designation_at_bol, encode_coding_iso_2022)
6302 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6303 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6304 Declare EMACS_INT.
6305 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6306 (encode_invocation_designation): Last argument P_NCHARS is now
6307 EMACS_INT.
6308 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6309 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6310
6311 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6312 All users changed.
6313
6314 * ccl.c (Fccl_execute_on_string): Declare some variables
6315 EMACS_INT.
6316
8546720e 63172011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6318
6319 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6320
4e19a977
CS
63212011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6322
6323 * process.c (Fformat_network_address): Doc fix.
6324
87302331
R
63252011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6326
6327 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6328
cbb59342
CY
63292011-04-08 Chong Yidong <cyd@stupidchicken.com>
6330
6331 * keyboard.c (read_char): Call Lisp function help-form-show,
6332 instead of using internal_with_output_to_temp_buffer.
6333 (Qhelp_form_show): New var.
e0d38eeb 6334 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6335
6336 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6337
6338 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6339
e67a13ab
CY
63402011-04-06 Chong Yidong <cyd@stupidchicken.com>
6341
04f2d78b
CB
6342 * process.c (Flist_processes): Remove to Lisp.
6343 (list_processes_1): Delete.
e67a13ab 6344
973f782d
EZ
63452011-04-06 Eli Zaretskii <eliz@gnu.org>
6346
7c106b1e
EZ
6347 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6348
973f782d
EZ
6349 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6350
41cf7d1a 63512011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6352
ca23cc88
PE
6353 Fix more problems found by GCC 4.6.0's static checks.
6354
f390e2d5
PE
6355 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6356
42eea0d0
PE
6357 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6358
b69769da 6359 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6360
f9541e84
PE
6361 * xdisp.c (vmessage): Mark as a printf-like function.
6362
13841b55
PE
6363 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6364
c136c10f
PE
6365 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6366
5e2d4a30
PE
6367 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6368 printf-like functions.
6369 (tiff_load): Add casts to remove these marks before passing them
6370 to system-supplied API.
6371
583f48b9
PE
6372 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6373
b25d760e
PE
6374 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6375 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6376 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6377 directly, rather than having caller test rule sign. This avoids
6378 some unnecessary tests.
6379 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6380 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6381 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6382
bc7b6697 6383 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6384 (xfont_open): Avoid unnecessary tests.
bc7b6697 6385
27ccc379
PE
6386 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6387
dcd5c89a
PE
6388 * composite.h, composite.c (composition_gstring_put_cache):
6389 Use EMACS_INT, not int, for length.
6390
b13a45c6
PE
6391 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6392 breaking out part of COMPOSITION_DECODE_RULE.
6393 (COMPOSITION_DECODE_RULE): Use it.
6394 * composite.c (get_composition_id): Remove unused local vars,
6395 by using the new macro.
6396
1e792e4d
PE
6397 * textprop.c (set_text_properties_1): Change while to do-while,
6398 since the condition is always true at first.
6399
dc6c6455 6400 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6401 (interval_deletion_adjustment): Return unsigned value.
6402 All uses changed.
dc6c6455 6403
aba7731a
PE
6404 * process.c (list_processes_1, create_pty, read_process_output):
6405 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6406 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6407 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6408 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6409 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6410
fdfc4bf3
PE
6411 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6412
fca8fe46 6413 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6414 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6415
06a0259a 6416 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6417 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6418 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6419
e7b9e80f
PE
6420 * print.c (print_error_message): Avoid int overflow.
6421
56201685
PE
6422 * font.c (font_list_entities): Redo for clarity,
6423 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6424
78834453 6425 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6426 (font_score): Avoid potential overflow in diff calculation.
78834453 6427
0bc0b309 6428 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6429 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6430
e610eaca
PE
6431 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6432
b895abce
PE
6433 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6434 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6435 can always succeed if overflow has undefined behavior.
6436
1f1d9321 6437 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6438 (wordify): Omit three unnecessary tests.
1f1d9321 6439
c59478bc
PE
6440 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6441 All callers changed. This avoids the need for an unused var.
6442
79b73827
PE
6443 * casefiddle.c (casify_region): Remove var that is set but not used.
6444
a4db5dfe
PE
6445 * dired.c (file_name_completion): Remove var that is set but not used.
6446
43aae36e
PE
6447 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6448
2a47c44d 6449 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6450 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6451
a37c69bf
PE
6452 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6453 Check for integer overflow on size calculations.
6454
328ab8e7
PE
6455 * buffer.c (Fprevious_overlay_change): Remove var that is set
6456 but not used.
6457
e5a2a5cb
PE
6458 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6459 Remove vars that are set but not used.
8d84a6eb 6460 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6461 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6462
a60e5f68
PE
6463 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6464
f661cb61 6465 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6466 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6467
f0397f5a
PE
6468 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6469 that are set but not used.
6470
8664db06 6471 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6472 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6473
6abdaa4a
PE
6474 * xselect.c (x_get_local_selection, x_handle_property_notify):
6475 Remove vars that are set but not used.
6476
0ce7538d 6477 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6478 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6479
9ae848fc
PE
6480 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6481 Remove var that is set but not used.
0b918413
PE
6482 (scroll_bar_windows_size): Now size_t, not int.
6483 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6484 Check for overflow.
9ae848fc 6485
a5a62657
PE
6486 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6487 (map_tty_color) [!defined MSDOS]: Likewise.
6488
5c5cdd39
PE
6489 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6490
66ebf983
PE
6491 * coding.c: Remove vars that are set but not used.
6492 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6493 All callers changed.
6494 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6495 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6496 (decode_coding_charset): Remove vars that are set but not used.
6497
1be4d761
PE
6498 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6499 that is set but not used.
6500
47553fa8
PE
6501 * print.c (print_object): Remove var that is set but not used.
6502
1f7196bf 6503 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6504 The gnulib version avoids calling malloc in the usual case,
6505 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6506 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6507 * filelock.c (current_lock_owner): Likewise.
6508 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6509 * sysdep.c: Include allocator.h, careadlinkat.h.
6510 (emacs_no_realloc_allocator): New static constant.
6511 (emacs_readlink): New function.
fdb61804
PE
6512 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6513 ../lib/careadlinkat.h.
d1fdcab7 6514
f84c17c7
SM
65152011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6516
6517 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6518 first non-nil return value).
6519
ef3862ad
JD
65202011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6521
6522 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6523 if not defined (Bug#8403).
6524
376a7006
JB
65252011-04-02 Juanma Barranquero <lekktu@gmail.com>
6526
6527 * xdisp.c (display_count_lines): Remove parameter `start',
6528 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6529 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6530 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6531 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6532 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6533 and thereabouts. All callers changed.
6534 (get_per_char_metric): Remove parameter `f', unused since
6535 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6536
6ca3801d
JM
65372011-04-02 Jim Meyering <meyering@redhat.com>
6538
6539 do not dereference NULL upon failed strdup
6540 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6541 (ns_get_family): Likewise.
6542
d8e2b5ba
JB
65432011-04-02 Juanma Barranquero <lekktu@gmail.com>
6544
6545 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6546
8c74fcbd
JD
65472011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6548
6549 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6550 later (Bug#8403).
6551
7200d79c
SM
65522011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6553
03408648 6554 Add lexical binding.
7200d79c 6555
03408648
SM
6556 * window.c (Ftemp_output_buffer_show): New fun.
6557 (Fsave_window_excursion):
6558 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6559
6560 * lread.c (lisp_file_lexically_bound_p): New function.
6561 (Fload): Bind Qlexical_binding.
6562 (readevalloop): Remove `evalfun' arg.
6563 Bind Qinternal_interpreter_environment.
6564 (Feval_buffer): Bind Qlexical_binding.
6565 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6566 Mark as dynamic.
6567 (syms_of_lread): Declare `lexical-binding'.
6568
6569 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6570
6571 * keyboard.c (eval_dyn): New fun.
6572 (menu_item_eval_property): Use it.
ca105506
SM
6573
6574 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6575
03408648
SM
6576 * fns.c (concat, mapcar1): Accept byte-code-functions.
6577
6578 * eval.c (Fsetq): Handle lexical vars.
6579 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6580 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6581 (FletX, Flet): Obey lexical binding.
6582 (Fcommandp): Handle closures.
6583 (Feval): New `lexical' arg.
6584 (eval_sub): New function extracted from Feval. Use it almost
6585 everywhere where Feval was used. Look up vars in lexical env.
6586 Handle closures.
6587 (Ffunctionp): Move from subr.el.
6588 (Ffuncall): Handle closures.
6589 (apply_lambda): Remove `eval_flags'.
6590 (funcall_lambda): Handle closures and new byte-code-functions.
6591 (Fspecial_variable_p): New function.
6592 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6593 but without exporting it to Lisp.
23aba0ea 6594
23aba0ea 6595 * doc.c (Fdocumentation, store_function_docstring):
03408648 6596 * data.c (Finteractive_form): Handle closures.
23aba0ea 6597
03408648
SM
6598 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6599 interactive spec.
ba83908c 6600
04f2d78b
CB
6601 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6602 New byte-codes.
03408648
SM
6603 (exec_byte_code): New function extracted from Fbyte_code to handle new
6604 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6605
03408648 6606 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6607
03408648 6608 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6609
e2abce01
JB
66102011-03-31 Juanma Barranquero <lekktu@gmail.com>
6611
6612 * xdisp.c (redisplay_internal): Fix prototype.
6613
63696a73 66142011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6615
63696a73 6616 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6617 (try_scrolling): Use it when setting scroll_limit.
6618 Limit scrolling to 100 screen lines.
63696a73
EZ
6619 (redisplay_window): Even when falling back on "recentering",
6620 position point in the window according to scroll-conservatively,
6621 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6622
6623 (try_scrolling): When point is above the window, allow searching
6624 as far as scroll_max, or one screenful, to compute vertical
6625 distance from PT to the scroll margin position. This prevents
6626 try_scrolling from unnecessarily failing when
6627 scroll-conservatively is set to a value slightly larger than the
6628 window height. Clean up the case of PT below the margin at bottom
6629 of window: scroll_max can no longer be INT_MAX. When aggressive
6630 scrolling is in use, don't let point enter the opposite scroll
6631 margin as result of the scroll.
6632 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6633 threshold of 100 lines for never-recentering scrolling.
6634
e4cc2dfc
JB
66352011-03-31 Juanma Barranquero <lekktu@gmail.com>
6636
6637 * dispextern.h (move_it_by_lines):
6638 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6639 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6640 (message_log_check_duplicate): Remove parameters `prev_bol' and
6641 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6642 (redisplay_internal): Remove parameter `preserve_echo_area',
6643 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6644
6645 * indent.c (Fvertical_motion):
6646 * window.c (window_scroll_pixel_based, Frecenter):
6647 Don't pass `need_y_p' to `move_it_by_lines'.
6648
1c470562
SM
66492011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6650
44f230aa
SM
6651 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6652 steal a few bits to be more compact.
6653 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6654 Remove unneeded casts.
6655
1c470562
SM
6656 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6657
888adce9
ZK
66582011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6659
6660 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6661 binding" message (bug#7967).
6662
f838ed7b
PE
66632011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6664
77861b95
PE
6665 Fix more problems found by GCC 4.6.0's static checks.
6666
de6dbc14
PE
6667 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6668 Remove unused local var.
6669
f838ed7b
PE
6670 * editfns.c (Fmessage_box): Remove unused local var.
6671
792c7b2b
PE
6672 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6673 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6674 Omit unused local vars.
c499e557 6675 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6676 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6677 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6678 Omit unused local var.
6679
ba0165e1
PE
6680 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6681 Don't assume string length fits in int.
32ad8845 6682 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6683 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6684
3c59b4c9
PE
6685 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6686 instead of alloca (Bug#8344).
6687
a3eed478 6688 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6689 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6690
eb4d412d
PE
6691 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6692
1658b401
PE
6693 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6694 concerns.
6695
6696 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6697
6698 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6699
9a2c6e05
PE
6700 * keyboard.c (syms_of_keyboard): Use the same style as later
6701 in this function when indexing through an array. This also
6702 works around GCC bug 48267.
6703
03d0a109
PE
6704 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6705
44f730c8
PE
6706 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6707
fe75f926
PE
6708 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6709 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6710
ffa8c828
PE
6711 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6712 This avoids undefined behavior on integer overflow, and is a bit
6713 more convenient anyway since it is compared to a size_t variable.
6714
c5101a77
PE
6715 Variadic C functions now count arguments with size_t, not int.
6716 This avoids an unnecessary limitation on 64-bit machines, which
6717 caused (substring ...) to crash on large vectors (Bug#8344).
6718 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6719 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6720 All variadic functions and their callers changed accordingly.
c5101a77
PE
6721 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6722 * data.c (arith_driver, float_arith_driver): Likewise.
6723 * editfns.c (general_insert_function): Likewise.
6724 * eval.c (struct backtrace.nargs, interactive_p)
6725 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6726 (funcall_lambda, mark_backtrace): Likewise.
6727 * fns.c (concat): Likewise.
6728 * frame.c (x_set_frame_parameters): Likewise.
6729 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6730 0 if not found, not -1. All callers changed.
6731
dd3f25f7
PE
6732 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6733 (stack_copy_size): Now size_t, not int.
6734 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6735
461c2ab9
JB
67362011-03-28 Juanma Barranquero <lekktu@gmail.com>
6737
6738 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6739 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6740 All callers changed.
6741
6742 * lisp.h (multibyte_char_to_unibyte):
6743 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6744 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6745 * character.h (CHAR_TO_BYTE8):
6746 * cmds.c (internal_self_insert):
6747 * editfns.c (general_insert_function):
6748 * keymap.c (push_key_description):
6749 * search.c (Freplace_match):
6750 * xdisp.c (message_dolog, set_message_1): All callers changed.
6751
f6d62986
SM
67522011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6753
6754 * keyboard.c (safe_run_hook_funcall): New function.
6755 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6756 don't set the hook to nil, but remove the offending function instead.
6757 (Qcommand_hook_internal): Remove, unused.
6758 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6759 Vcommand_hook_internal.
6760
6761 * eval.c (enum run_hooks_condition): Remove.
6762 (funcall_nil, funcall_not): New functions.
6763 (run_hook_with_args): Call each function through a `funcall' argument.
6764 Remove `cond' argument, now redundant.
6765 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6766 (Frun_hook_with_args_until_failure): Adjust accordingly.
6767 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6768
1db5b1ad
JB
67692011-03-28 Juanma Barranquero <lekktu@gmail.com>
6770
6771 * dispextern.h (string_buffer_position): Remove declaration.
6772
6773 * print.c (strout): Remove parameter `multibyte', unused since
6774 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6775
6776 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6777 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6778 All callers changed.
6779
6780 * w32.c (_wsa_errlist): Use braces for struct initializers.
6781
6782 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6783 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6784 All callers changed.
6785 (string_buffer_position): Likewise. Also, make static (it's never
6786 used outside xdisp.c).
6787 (cursor_row_p): Remove parameter `w', unused since
6788 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6789 (decode_mode_spec): Remove parameter `precision', introduced during
6790 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6791 All callers changed.
6792
5ffb62aa
JD
67932011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6794
6795 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6796
461c2ab9 67972011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6798
6799 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6800 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6801 (ns_update_auto_hide_menu_bar): New functions.
6802 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6803 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6804 ns_constrain_all_frames.
6805 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6806 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6807
5c380ffb
JD
68082011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6809
6810 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6811
9af30bdf
GM
68122011-03-27 Glenn Morris <rgm@gnu.org>
6813
6814 * syssignal.h: Replace RETSIGTYPE with void.
6815 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6816 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6817 Replace SIGTYPE with void everywhere.
6818 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6819 * s/template.h (SIGTYPE): Remove commented out definition.
6820
e2abce01
JB
68212011-03-26 Eli Zaretskii <eliz@gnu.org>
6822
6823 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6824 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6825
f868cd8a
JB
68262011-03-26 Juanma Barranquero <lekktu@gmail.com>
6827
59eb0929
JB
6828 * w32.c (read_unc_volume): Use parameter `henum', instead of
6829 global variable `wget_enum_handle'.
6830
6831 * keymap.c (describe_vector): Remove parameters `indices' and
6832 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6833 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6834
f868cd8a
JB
6835 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6836
6837 * keyboard.c (timer_check): Remove parameter `do_it_now',
6838 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6839 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6840 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6841
6842 * keyboard.c (read_char):
6843 * w32menu.c (w32_menu_display_help):
6844 * xmenu.c (show_help_event, menu_help_callback):
6845 Adjust calls to `show_help_echo'.
6846
6847 * gtkutil.c (xg_maybe_add_timer):
6848 * keyboard.c (readable_events):
6849 * process.c (wait_reading_process_output):
6850 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6851
6852 * insdel.c (adjust_markers_gap_motion):
6853 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6854 (gap_left, gap_right): Don't call it.
6855
2ecf6fdb
CY
68562011-03-25 Chong Yidong <cyd@stupidchicken.com>
6857
6858 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6859 incurred during fontification.
6860
6b1f9ba4
JB
68612011-03-25 Juanma Barranquero <lekktu@gmail.com>
6862
6863 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6864 (DEFVAR_PER_BUFFER): Don't pass it.
6865
6866 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6867 (scrolling_window): Don't pass it.
6868
0f4a96b5
JB
68692011-03-25 Juanma Barranquero <lekktu@gmail.com>
6870
6871 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6872
6873 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6874 and `suffix'.
6875 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6876 of variables specific to SELinux and computation of `encoded_absname'.
6877
6878 * image.c (XPutPixel): Remove unused variable `height'.
6879
6880 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6881
6882 * unexw32.c (get_section_info): Remove unused variable `section'.
6883
6884 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6885 (system_process_attributes): Remove unused variable `sess'.
6886 (sys_read): Remove unused variable `err'.
6887
6888 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6889 (w32_wnd_proc): Remove unused variable `isdead'.
6890 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6891 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6892 (x_create_tip_frame): Remove unused variable `tem'.
6893
6894 * w32inevt.c (w32_console_read_socket):
6895 Remove unused variable `no_events'.
6896
6897 * w32term.c (x_draw_composite_glyph_string_foreground):
6898 Remove unused variable `width'.
6899
1149507c
JB
69002011-03-24 Juanma Barranquero <lekktu@gmail.com>
6901
6902 * w32term.c (x_set_glyph_string_clipping):
6903 Don't pass uninitialized region to CombineRgn.
6904
9c88f339
JB
69052011-03-23 Juanma Barranquero <lekktu@gmail.com>
6906
6907 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6908 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6909 (Fx_close_connection): Remove unused variable `i'.
6910
6911 * w32font.c (w32font_draw): Return number of glyphs.
6912 (w32font_open_internal): Remove unused variable `i'.
6913 (w32font_driver): Add missing initializer.
6914
6915 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6916 (fill_in_menu): Remove unused variable `items_added'.
6917
6918 * w32term.c (last_mouse_press_frame): Remove static global variable.
6919 (w32_clip_to_row): Remove unused variable `f'.
6920 (x_delete_terminal): Remove unused variable `i'.
6921
6922 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6923 (NOTHING): Remove unused static global variable.
6924 (uniscribe_check_otf): Remove unused variable `table'.
6925 (uniscribe_font_driver): Add missing initializers.
6926
dee091a3
JD
69272011-03-23 Julien Danjou <julien@danjou.info>
6928
6929 * term.c (Fsuspend_tty, Fresume_tty):
6930 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6931 * window.c (temp_output_buffer_show):
6932 * insdel.c (signal_before_change):
6933 * frame.c (Fhandle_switch_frame):
6934 * fileio.c (Fdo_auto_save):
6935 * emacs.c (Fkill_emacs):
6936 * editfns.c (save_excursion_restore):
6937 * cmds.c (internal_self_insert):
6938 * callint.c (Fcall_interactively):
6939 * buffer.c (Fkill_all_local_variables):
6940 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6941 Use Frun_hooks.
0f4a96b5 6942 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6943 unconditionnaly since it does the check itself.
6944
2c520ab5 69452011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6946
c9c49752
PE
6947 Fix more problems found by GCC 4.5.2's static checks.
6948
8abc3f12
PE
6949 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6950 the first time through the loop, since we know p0 < p1 then.
6951 This also avoids a gcc -Wstrict-overflow warning.
6952
a2d26660
PE
6953 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6954 leading to a memory leak, possible in functions like
6955 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6956 of objects (Bug#8318).
a2d26660 6957
916c72e9
PE
6958 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6959 that could (at least in theory) be that large.
6960
19ab8a18
PE
6961 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6962 This is less likely to overflow, and avoids undefined behavior if
6963 overflow does occur. All callers changed. Use strtoul to scan
6964 for the unsigned long integer.
b7cbbd6f
PE
6965 (pint2hrstr): Simplify and tune code slightly.
6966 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6967
f0641eff
PE
6968 * scroll.c (do_scrolling): Work around GCC bug 48228.
6969 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6970
7f650bb9
PE
6971 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6972 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6973 (validate_x_resource_name): Simplify count usage.
6974 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6975
37dd57d1
PE
6976 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6977 fail (Bug#8306).
81e56e61 6978
699979fc 6979 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6980
401bf9b4
PE
6981 * process.c (Fmake_network_process): Use socklen_t, not int,
6982 where POSIX says socklen_t is required in portable programs.
6983 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6984 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6985 (Fmake_network_process, server_accept_connection):
6986 (wait_reading_process_output, read_process_output):
6987 Likewise.
6988
b93aacde
PE
6989 * process.c: Rename or move locals to avoid shadowing.
6990 (list_processes_1, Fmake_network_process):
6991 (read_process_output_error_handler, exec_sentinel_error_handler):
6992 Rename or move locals.
4dc343ee 6993 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6994 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6995 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6996 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6997 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6998
af8a867c 6999 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7000 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7001 Include tparam.h instead, since it declares them.
af8a867c
PE
7002 * cm.h (PC): Remove extern decl; tparam.h now does this.
7003 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7004 * terminfo.c: Include tparam.h, to check interfaces.
7005 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7006 (tparam): Adjust signature to match interface in tparam.h;
7007 this removes some undefined behavior. Check that outstring and len
7008 are zero, which they always are with Emacs.
7009 * tparam.h (PC, BC, UP): New extern decls.
7010
0248044d 7011 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7012 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7013
8ff096c1 7014 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7015 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7016 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7017 (ftfont_list): Remove unused local.
49eaafba
PE
7018 (get_adstyle_property, ftfont_pattern_entity):
7019 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7020 Rename locals to avoid shadowing.
8ff096c1 7021
e2be39f6
PE
7022 * xfont.c (xfont_list_family): Mark var as initialized.
7023
c9735e30
PE
7024 * xml.c (make_dom): Now static.
7025
8f5201ae
PE
7026 * composite.c (composition_compute_stop_pos): Rename local to
7027 avoid shadowing.
b246f932
PE
7028 (composition_reseat_it): Remove unused locals.
7029 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7030 (composition_update_it): Mark var as initialized.
11b61122
PE
7031 (find_automatic_composition): Mark vars as initialized,
7032 with a FIXME (Bug#8290).
8f5201ae 7033
760fbc2c
PE
7034 character.h: Rename locals to avoid shadowing.
7035 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7036 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7037 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7038 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7039 to avoid shadowing.
7040
ff08eb85
PE
7041 * textprop.c (property_change_between_p): Remove; unused.
7042
fc7bf025
PE
7043 * intervals.c (interval_start_pos): Now static.
7044
235d7abc
PE
7045 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7046
44f230aa
SM
7047 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7048 Rename locals to avoid shadowing.
3e7d6594 7049
50060332
PE
7050 * sound.c (wav_play, au_play, Fplay_sound_internal):
7051 Fix pointer signedness.
d01f234b 7052 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7053 (wav_play): Initialize a variable to 0, to prevent undefined
7054 behavior (Bug#8278).
50060332 7055
c4fc4e30
PE
7056 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7057
918436ed
PE
7058 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7059
c939f91b
PE
7060 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7061 clobbering (Bug#8298).
b9c7f648
PE
7062 * sysdep.c (sys_subshell): Likewise.
7063 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7064
6bd8c144
PE
7065 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7066 This should get cleaned up, so that child_setup has the
7067 same signature on all platforms.
7068
7710357c 7069 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7070 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7071
c59da222
CY
70722011-03-22 Chong Yidong <cyd@stupidchicken.com>
7073
7074 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7075 not to be necessary, and produces flickering.
7076
66b87493
GM
70772011-03-20 Glenn Morris <rgm@gnu.org>
7078
7079 * config.in: Remove file.
7080
45b6f6d5
JB
70812011-03-20 Juanma Barranquero <lekktu@gmail.com>
7082
7083 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7084 are now in src/globals.h.
7085 (syms_of_minibuf): Remove spurious & from previous change.
7086
3ec03f7e
LL
70872011-03-20 Leo <sdl.web@gmail.com>
7088
7089 * minibuf.c (completing-read-function): New variable.
7090 (completing-read-default): Rename from completing-read.
7091 (completing-read): Call completing-read-function.
7092
b14e3e21
CY
70932011-03-19 Juanma Barranquero <lekktu@gmail.com>
7094
7095 * xfaces.c (Fx_load_color_file):
7096 Read color file from absolute filename (bug#8250).
7097
f2b726e6
JB
70982011-03-19 Juanma Barranquero <lekktu@gmail.com>
7099
7100 * makefile.w32-in: Update dependencies.
7101
09f6ff02
EZ
71022011-03-17 Eli Zaretskii <eliz@gnu.org>
7103
7104 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7105
29a6015a
PE
71062011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7107
a3a6c54e
PE
7108 Fix more problems found by GCC 4.5.2's static checks.
7109
b766f867
PE
7110 * process.c (make_serial_process_unwind, send_process_trap):
7111 (sigchld_handler): Now static.
7112
be02381c
PE
7113 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7114 That way, the code declares only the vars that it needs.
7115 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7116 * s/cygwin.h (PTY_ITERATION): Likewise.
7117 * s/darwin.h (PTY_ITERATION): Likewise.
7118 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7119
57048744
PE
7120 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7121 * process.c (allocate_pty): Don't declare stb unless it's needed.
7122
7914961c 7123 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7124 (CONSTANTLIM): Remove; unused.
7125 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7126 Define only if needed.
7914961c 7127
b3967b18
PE
7128 * unexelf.c (unexec): Name an expression,
7129 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7130 Use a different way to cause a compilation error if anyone uses
7131 n rather than nn, a way that does not involve shadowing.
73366a00 7132 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7133
29a6015a
PE
7134 * deps.mk (unexalpha.o): Remove; unused.
7135
43cfc33e 7136 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7137 * unexec.h: New file.
ce701a33
PE
7138 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7139 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7140 Depend on unexec.h.
7141 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7142 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7143 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7144 Change as necessary to match prototype in unexec.h.
ce701a33 7145
01f44d5a
PE
7146 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7147 shadowing.
4f63c6bb 7148 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7149
a6670b0b
PE
7150 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7151 Rename locals to avoid shadowing.
7152
cef2010d 7153 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7154 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7155
d4d7173a
PE
7156 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7157
f08b802a
PE
7158 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7159 warning when compiling print.c.
7160
3ddb0639
PE
7161 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7162 instead of using an uninitialized var.
5ad03b97 7163 (font_sort_entities): Mark var as initialized.
3ddb0639 7164
170a2692
PE
7165 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7166
e663c700
PE
7167 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7168 pointers to constants.
89bc529a 7169 (font_parse_fcname): Remove unused vars.
7b81e2d0 7170 (font_delete_unmatched): Now static.
ea838e10 7171 (font_get_spec): Remove; unused.
13a547c6
PE
7172 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7173 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7174 Rename or move locals to avoid shadowing.
e663c700 7175
2a80c887 7176 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7177 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7178
1384fa33 7179 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7180 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7181
8b2c52e9
PE
7182 * alloc.c (mark_backtrace): Move decl from here ...
7183 * lisp.h: ... to here, so that it can be checked.
7184
475545b5 7185 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7186 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7187 (lisp_indirect_variable): Name an expression,
7188 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7189 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7190
b1349114 7191 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7192 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7193 Use const pointer when appropriate.
b1349114 7194
a2928364
PE
7195 * lisp.h (get_system_name, get_operating_system_release):
7196 Move decls here, to check interfaces.
7197 * process.c (get_operating_system_release): Move decl to lisp.h.
7198 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7199 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7200 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7201 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7202 (Fformat_time_string, Fencode_time, Finsert_char):
7203 (Ftranslate_region_internal, Fformat):
7204 Rename or remove local vars to avoid shadowing.
9710023e 7205 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7206
a415e694
PE
7207 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7208 avoid shadowing.
7209
8ef4622d
PE
7210 * lisp.h (eassert): Check that the argument compiles, even if
7211 ENABLE_CHECKING is not defined.
7212
946f9a5b
PE
7213 * data.c (Findirect_variable): Name an expression, to avoid
7214 gcc -Wbad-function-cast warning.
112396d6 7215 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7216 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7217 (Fmake_variable_buffer_local, Fmake_local_variable):
7218 Mark variables as initialized.
52746918 7219 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7220
e5aab7e7 7221 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7222 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7223 Rename locals to avoid shadowing.
dff45157
PE
7224 (mark_stack): Move local variables into the #ifdef region where
7225 they're used.
7bc26fdb
PE
7226 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7227 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7228 needed otherwise.
7229 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7230 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7231 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7232
e5aab7e7
PE
7233 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7234 avoids undefined behavior in theory.
7235
4da60324
PE
7236 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7237
88043301
PE
7238 Use functions, not macros, for up- and down-casing (Bug#8254).
7239 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7240 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7241 to use the following functions instead of these macros.
7242 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7243 EMACS_INT, since callers assume the returned value fits in int.
7244 (upcase1): Likewise, for UPCASE_TABLE.
7245 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7246 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7247 the race-condition problem in the old DOWNCASE.
88043301 7248
19ed5445
PE
7249 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7250 Rename locals to avoid shadowing.
7251 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7252 (regex_compile, re_search_2, re_match_2_internal):
7253 Remove unused local vars.
952db0d7
PE
7254 (FREE_VAR): Rewrite so as not to use empty "else",
7255 which gcc can warn about.
da053e48 7256 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7257 (RETALLOC_IF): Define only if needed.
7258 (WORDCHAR_P): Likewise. This one is never needed, but is used
7259 only in a comment talking about a compiler bug, so put inside
7260 the #if 0 of that comment.
7261 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7262 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7263 Remove; unused.
19ed5445 7264
1f3561e4 7265 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7266 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7267 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7268
ded6f8f7
PE
7269 * search.c (simple_search): Remove unused var.
7270
dbd37a95
PE
7271 * dired.c (compile_pattern): Move decl from here ...
7272 * lisp.h: ... to here, so that it can be checked.
7273 (struct re_registers): New forward decl.
7274
7e47afad
PE
7275 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7276
85f24f61
PE
7277 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7278 All uses changed.
7279 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7280 Rename locals to avoid shadowing.
5671df8f 7281 (Fvertical_motion): Mark locals as initialized.
85f24f61 7282
181aa2be 7283 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7284 (casify_region): Mark local as initialized.
181aa2be 7285
930d429c
PE
7286 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7287
7082eac6
PE
7288 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7289 New macros, so that the caller can use some names other than
7290 gcpro1, gcpro2, etc.
7291 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7292 of the new macros.
7293 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7294 argument, for consistency with GCPRO2_VAR, etc: it is now the
7295 prefix of the variable, not the variable itself. All uses
7296 changed.
38b2c076
PE
7297 * dired.c (directory_files_internal, file_name_completion):
7298 Rename locals to avoid shadowing.
7299
15206ed9
PE
7300 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7301 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7302 dired.c's scmp function, had undefined behavior.
7303 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7304 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7305 * buffer.h: ... to here, because these macros use current_buffer,
7306 and the new implementation with inline functions needs to have
7307 current_buffer in scope now, rather than later when the macros
7308 are used.
7309 (downcase, upcase1): New static inline functions.
7310 (DOWNCASE, UPCASE1): Reimplement using these functions.
7311 This avoids undefined behavior in expressions like
7312 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7313 from race conditions in accessing the global variables
7314 case_temp1 and case_temp2.
7315 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7316 * lisp.h (case_temp1, case_temp2): Remove their decls.
7317 * character.h (ASCII_CHAR_P): Move from here ...
7318 * lisp.h: ... to here, so that the inline functions mentioned
7319 above can use them.
7320
4a6bea26
PE
7321 * dired.c (directory_files_internal_unwind): Now static.
7322
f14b7e14
PE
7323 * fileio.c (file_name_as_directory, directory_file_name):
7324 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7325 Now static.
2893f146
PE
7326 (file_name_as_directory): Use const pointers when appropriate.
7327 (Fexpand_file_name): Likewise. In particular, newdir might
7328 point at constant storage, so make it a const pointer.
fd4ead52 7329 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7330 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7331 signedness issues.
f839df0c
PE
7332 (Fset_file_times, Finsert_file_contents, auto_save_error):
7333 Rename locals to avoid shadowing.
f14b7e14 7334
5716756e 7335 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7336 (Ftry_completion, Fall_completions): Rename or remove locals
7337 to avoid shadowing.
5716756e 7338
b4c3046a
PE
7339 * marker.c (bytepos_to_charpos): Remove; unused.
7340
b45db522
PE
7341 * lisp.h (verify_bytepos, count_markers): New decls,
7342 so that gcc does not warn that these functions aren't declared.
7343
85876d07
PE
7344 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7345 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7346 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7347 (copy_text): Remove unused local var.
85876d07 7348
03d78a21 7349 * filelock.c (within_one_second): Now static.
b3dd38ab 7350 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7351
5df8f01b
PE
7352 * buffer.c (fix_overlays_before): Mark locals as initialized.
7353 (fix_start_end_in_overlays): Likewise. This function should be
7354 simplified by using pointers-to-pointers, but that's a different
7355 matter.
b1d876f1 7356 (switch_to_buffer_1): Now static.
8f54f30a
PE
7357 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7358 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7359
a70072c9 7360 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7361 Fix pointer signedness issue.
edced198
PE
7362 (sys_subshell): Mark local as volatile if checking for lint,
7363 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7364 (MAXPATHLEN): Define only if needed.
a70072c9 7365
a0977c44
PE
7366 * process.c (serial_open, serial_configure): Move decls from here ...
7367 * systty.h: ... to here, so that they can be checked.
7368
a884fdcc
PE
7369 * fns.c (get_random, seed_random): Move extern decls from here ...
7370 * lisp.h: ... to here, so that they can be checked.
7371
604efe86 7372 * sysdep.c (reset_io): Now static.
b8950c94 7373 (wait_for_termination_signal): Remove; unused.
604efe86 7374
38fc62d9
PE
7375 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7376 (copy_keymap_item, append_key, push_text_char_description):
7377 Now static.
1004a21a 7378 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7379 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7380 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7381 (describe_map_tree):
7382 Rename locals to avoid shadowing.
38fc62d9 7383
2f2650da
PE
7384 * keyboard.c: Declare functions static if they are not used elsewhere.
7385 (echo_char, echo_dash, cmd_error, top_level_2):
7386 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7387 (read_char, kbd_buffer_get_event, make_lispy_position):
7388 (make_lispy_event, make_lispy_movement, apply_modifiers):
7389 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7390 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7391 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7392 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7393 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7394
a053e86c 7395 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7396 (mark_kboards): Move decl here ...
7397 * alloc.c (mark_kboards): ... from here.
a053e86c 7398
4752793e
PE
7399 * lisp.h (force_auto_save_soon): New decl.
7400
74f10ca7 7401 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7402 (DEFINE_DUMMY_FUNCTION): New macro.
7403 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7404 Use it.
c03cd23f
PE
7405 (main): Add casts to avoid warnings
7406 if GCC considers string literals to be constants.
74f10ca7 7407
022e70d4
PE
7408 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7409
59d6fe83
PE
7410 * dbusbind.c: Pointer signedness fixes.
7411 (xd_signature, xd_append_arg, xd_initialize):
7412 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7413 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7414 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7415 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7416
78320123
PE
7417 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7418 if GCC considers string literals to be constants.
49cebcca 7419 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7420
35ac2a97
SM
74212011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7422
fb103ca9
SM
7423 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7424 (print_preprocess, print_object): New macro to fix last change.
7425
35ac2a97
SM
7426 * print.c (print_preprocess): Don't forget font objects.
7427
62973b41
JB
74282011-03-16 Juanma Barranquero <lekktu@gmail.com>
7429
7430 * emacs.c (USAGE3): Doc fixes.
7431
0e48bb22
AS
74322011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7433
7434 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7435 structure.
7436
7684e57b
JB
74372011-03-14 Juanma Barranquero <lekktu@gmail.com>
7438
7439 * lisp.h (VWindow_system, Qfile_name_history):
7440 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7441 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7442 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7443
7444 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7445 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7446
7447 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7448 * w32console.c (detect_input_pending, read_input_pending)
7449 (encode_terminal_code):
7450 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7451 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7452 (w32_system_caret_y, Qfile_name_history):
7453 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7454 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7455 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7456 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7457 * w32proc.c (Qlocal, report_file_error):
7458 * w32term.c (Vwindow_system, updating_frame):
7459 * w32uniscribe.c (initialized, uniscribe_font_driver):
7460 Remove unneeded extern declarations.
7461
2aa46d6c
CY
74622011-03-14 Chong Yidong <cyd@stupidchicken.com>
7463
c96bbc66 7464 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7465
cffc6f3b
CY
74662011-03-13 Chong Yidong <cyd@stupidchicken.com>
7467
7468 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7469 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7470 These macros can no longer be used for assignment.
7471
44f230aa
SM
7472 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7473 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7474 (record_buffer_markers, fetch_buffer_markers): New functions for
7475 recording and fetching special buffer markers.
7476 (set_buffer_internal_1, set_buffer_temp): Use them.
7477
7478 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7479
7480 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7481
7482 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7483 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7484
7485 * xdisp.c (hscroll_window_tree):
7486 (reconsider_clip_changes): Use PT instead of BUF_PT.
7487
d251f04b
EZ
74882011-03-13 Eli Zaretskii <eliz@gnu.org>
7489
7490 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7491 $(EMACS_ROOT)/lib/intprops.h.
7492
f0c77cd1
PE
74932011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7494
3eca4629
PE
7495 Fix more problems found by GCC 4.5.2's static checks.
7496
7c86ee98
PE
7497 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7498 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7499 (xg_free_frame_widgets): Make it clear that a local variable is
7500 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7501 (gdk_window_get_screen): Make it clear that this macro is needed
7502 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7503 (int_gtk_range_get_value): New function, which avoids a diagnostic
7504 from gcc -Wbad-function-cast.
7505 (xg_set_toolkit_scroll_bar_thumb): Use it.
7506 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7507 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7508 (get_utf8_string, xg_get_file_with_chooser):
7509 Rename locals to avoid shadowing.
7510 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7511
41729b81
PE
7512 * xgselect.c (xg_select): Remove unused var.
7513
f0c77cd1
PE
7514 * image.c (four_corners_best): Mark locals as initialized.
7515 (gif_load): Initialize transparent_p to zero (Bug#8238).
7516 Mark another local as initialized.
ec6cf4c6 7517 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7518
ce0ad53d 7519 * image.c (clear_image_cache): Now static.
d5d5a617 7520 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7521 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7522 (x_edge_detection): Remove unnecessary cast that
7523 gcc -Wbad-function-cast diagnoses.
2037898d 7524 (gif_load): Fix pointer signedness.
6ae141d6
PE
7525 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7526 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7527
33383987 75282011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7529
d32df629
PE
7530 Improve quality of tests for time stamp overflow.
7531 For example, without this patch (encode-time 0 0 0 1 1
7532 1152921504606846976) returns the obviously-bogus value (-948597
7533 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7534 reports time overflow. See
7535 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7536 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7537 * editfns.c: Include limits.h and intprops.h.
7538 (TIME_T_MIN, TIME_T_MAX): New macros.
7539 (time_overflow): Move earlier, to before first use.
7540 (hi_time, lo_time): New functions, for an accurate test for
7541 out-of-range times.
7542 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7543 (Fget_internal_run_time): Don't assume time_t fits in int.
7544 (make_time): Use list2 instead of Fcons twice.
7545 (Fdecode_time): More accurate test for out-of-range times.
7546 (check_tm_member): New function.
7547 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7548 (lisp_time_argument): Don't rely on undefined left-shift and
7549 right-shift behavior when checking for time stamp overflow.
8be6f318 7550
fe31d94c
PE
7551 * editfns.c (time_overflow): New function, refactoring common code.
7552 (Fformat_time_string, Fdecode_time, Fencode_time):
7553 (Fcurrent_time_string): Use it.
7554
8be6f318
PE
7555 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7556 * dired.c (make_time): Move to ...
7557 * editfns.c (make_time): ... here.
7558 * systime.h: Note the move.
7559
09d9db2c 75602011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7561
126bc0dc
YM
7562 * fringe.c (update_window_fringes): Remove unused variables.
7563
c47cbdfd
YM
7564 * unexmacosx.c (copy_data_segment): Also copy __got section.
7565 (Bug#8223)
7566
7ac80be9
EZ
75672011-03-12 Eli Zaretskii <eliz@gnu.org>
7568
c96bbc66 7569 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7570 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7571 Constify `char *' arguments and their references according to
7572 prototypes in tparam.h.
7573
ecb0f94d 7574 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7575
7ac80be9
EZ
7576 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7577 Adapt all references accordingly.
7578
7579 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7580
ef1fd07e
TT
75812011-03-11 Tom Tromey <tromey@redhat.com>
7582
7583 * buffer.c (syms_of_buffer): Remove obsolete comment.
7584
7ef4b50c
EZ
75852011-03-11 Eli Zaretskii <eliz@gnu.org>
7586
7587 * termhooks.h (encode_terminal_code): Declare prototype.
7588
7589 * msdos.c (encode_terminal_code): Don't declare prototype.
7590
7591 * term.c (encode_terminal_code): Now external again, used by
7592 w32console.c and msdos.c.
7593
44f230aa
SM
7594 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7595 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7596
4b1ec863 75972011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7598
1714f52b 7599 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7600
4b1ec863
PE
7601 * fringe.c (update_window_fringes): Mark locals as initialized
7602 (Bug#8227).
7603 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7604
524c7aa6
PE
7605 * alloc.c (mark_fringe_data): Move decl from here ...
7606 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7607 to check its interface.
7608 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7609
a5c0af81 7610 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7611 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7612 (fontset_font): Mark local as initialized.
a9a06e0b 7613 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7614
b4716021
PE
7615 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7616
811e9bac 7617 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7618 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7619 (x_own_selection, Fx_disown_selection_internal): Rename locals
7620 to avoid shadowing.
7621 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7622
7e3ab302
PE
7623 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7624 so that the caller can use some name other than gcpro1.
7625 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7626 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7627 (Fx_backspace_delete_keys_p):
7628 Use them to avoid shadowing, and rename vars to avoid shadowing.
7629 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7630 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7631 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7632 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7633 Remove unused locals.
7e3ab302
PE
7634 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7635 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7636 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7637 macros.
f78faa98 7638
e2b13473
PE
7639 * xterm.h (x_mouse_leave): New decl.
7640
77f23912
PE
7641 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7642 Remove unused functions.
cdf4ba58
PE
7643 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7644 (x_calc_absolute_position): Now static.
7411c686 7645 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7646 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7647 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7648 unless they are used.
38d0b34a
PE
7649 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7650 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7651 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7652 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7653 (x_error_catcher, x_connection_closed, x_error_handler):
7654 (x_error_quitter, xembed_send_message, x_iconify_frame):
7655 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7656 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7657 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7658
44f230aa
SM
7659 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7660 Rename or move locals to avoid shadowing.
6b463e58 7661 (tty_defined_color, merge_face_heights): Now static.
5967d051 7662 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7663 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7664 does not deduce is never used uninitialized.
73719eba
PE
7665 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7666 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7667
426994c3 7668 * terminal.c (store_terminal_param): Now static.
5489860b 7669
032f1620 7670 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7671 (set_frame_menubar): Remove unused local.
d4323972 7672 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7673 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7674 since they might point to immutable storage.
281585b0
PE
7675 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7676 since it's unused otherwise.
032f1620 7677
367c19e5 7678 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7679 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7680 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7681 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7682 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7683 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7684 does not deduce are never used uninitialized.
70739cbe 7685
07b48fa9
PE
7686 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7687
8868a238 7688 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7689 * window.c (window_loop, size_window):
7690 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7691
7e5cf297 7692 * window.c (display_buffer): Now static.
d6550a9f
PE
7693 (size_window): Mark variables that gcc -Wuninitialized
7694 does not deduce are never used uninitialized.
a586633d
PE
7695 * window.h (check_all_windows): New decl, to forestall
7696 gcc -Wmissing-prototypes diagnostic.
5b555da1 7697 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7698
f6095868
PE
7699 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7700 shadowing.
7701 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7702 Include <limits.h>.
7703 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7704 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7705 (load_charset_map): Mark variables that gcc -Wuninitialized
7706 does not deduce are never used uninitialized.
53df7c11 7707 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7708
f38b440c
PE
7709 * coding.c (coding_set_source, coding_set_destination):
7710 Use "else { /* comment */ }" rather than "else /* comment */;"
7711 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7712 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7713 a block, when the outer 'i' will do.
7714 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7715 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7716 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7717 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7718 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7719 Rename locals to avoid shadowing.
7720 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7721 * coding.c (emacs_mule_char, encode_invocation_designation):
7722 Now static, since they're not used elsewhere.
413bb2db 7723 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7724 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7725 (decode_coding_emacs_mule): Mark variables that gcc
7726 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7727 (detect_coding_iso_2022): Initialize a local variable that might
7728 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7729 this initialization is needed. (Bug#8211)
5f58e762
PE
7730 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7731 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7732 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7733 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7734 Remove unused macros.
f38b440c 7735
232b38b9 7736 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7737 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7738 * character.c (string_count_byte8): Likewise.
232b38b9 7739
fb90da1b
PE
7740 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7741 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7742
fb93dbc2
PE
7743 * chartab.c (copy_sub_char_table): Now static, since it's not used
7744 elsewhere.
5c156ace
PE
7745 (sub_char_table_ref_and_range, char_table_ref_and_range):
7746 Rename locals to avoid shadowing.
bbcd0949 7747 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7748
7d3b3862 7749 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7750 (BIDI_BOB): Remove unused macro.
7d3b3862 7751
6be7d3da
PE
7752 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7753 deduce are never used uninitialized.
c2ed9c8b 7754 * term.c (encode_terminal_code): Likewise.
6be7d3da 7755
75f8807f 7756 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7757
50938595
PE
7758 * tparam.h: New file.
7759 * term.c, tparam.h: Include it.
7760 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7761 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7762 Move these decls to tparam.h, and make them agree with what
7763 is actually in tparam.c. The previous trick of using incompatible
7764 decls in different modules does not conform to the C standard.
7765 All callers of tparam changed to use tparam's actual API.
7766 * tparam.c (tparam1, tparam, tgoto):
7767 Use const pointers where appropriate.
7768
fbceeba2
PE
7769 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7770 * cm.h (struct cm): Likewise.
7771 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7772 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7773 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7774 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7775 (turn_on_face, init_tty): Likewise.
7776 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7777
7f3f1250
PE
7778 * term.c (term_mouse_position): Rename local to avoid shadowing.
7779
e6ca6543
PE
7780 * alloc.c (mark_ttys): Move decl from here ...
7781 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7782
c40f8d15
AS
77832011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7784
7785 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7786
cfe0661d
JB
77872011-03-09 Juanma Barranquero <lekktu@gmail.com>
7788
7789 * search.c (compile_pattern_1): Remove argument regp, unused since
7790 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7791 (compile_pattern): Don't pass it.
7792
0afb4571
J
77932011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7794
7795 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7796 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7797 for ! HAVE_GTK3.
7798 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7799
7800 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7801
7802 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7803 gdk_window_get_screen, gdk_window_get_geometry,
7804 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7805 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7806 (xg_get_pixbuf_from_pixmap): New function.
7807 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7808 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7809 Call xg_get_pixbuf_from_pixmap instead of
7810 gdk_pixbuf_get_from_drawable.
7811 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7812 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7813 (xg_check_special_colors): Use GtkStyleContext and its functions
7814 for HAVE_GTK3.
7815 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7816 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7817 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7818 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7819 Call gtk_widget_get_preferred_size.
0afb4571
J
7820 (xg_frame_resized): gdk_window_get_geometry only takes 5
7821 parameters.
44f230aa
SM
7822 (xg_win_to_widget, xg_event_is_for_menubar):
7823 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7824 (xg_set_widget_bg): New function.
7825 (delete_cb): New function.
895009e1 7826 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7827 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7828 (xg_set_background_color): Call xg_set_widget_bg.
7829 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7830 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7831 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7832 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7833 if ! HAVE_GTK3.
7834 (update_frame_tool_bar): Call gtk_widget_hide.
7835 (xg_initialize): Use GDK_KEY_g.
7836
7837 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7838 if ! HAVE_GTK3
7839 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7840
7841 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7842 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7843 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7844
1c2cc4ef
JB
78452011-03-08 Juanma Barranquero <lekktu@gmail.com>
7846
7847 * w32xfns.c (select_palette): Check success of RealizePalette against
7848 GDI_ERROR, not zero.
7849
33383987 7850See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7851
7852;; Local Variables:
7853;; coding: utf-8
aac0c6e3
MR
7854;; End:
7855
33383987 7856 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7857
7858 This file is part of GNU Emacs.
7859
7860 GNU Emacs is free software: you can redistribute it and/or modify
7861 it under the terms of the GNU General Public License as published by
7862 the Free Software Foundation, either version 3 of the License, or
7863 (at your option) any later version.
7864
7865 GNU Emacs is distributed in the hope that it will be useful,
7866 but WITHOUT ANY WARRANTY; without even the implied warranty of
7867 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7868 GNU General Public License for more details.
7869
7870 You should have received a copy of the GNU General Public License
7871 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.