lisp/calc/calccomp.el (math-comp-to-string-flat-term): Simplify.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f76dee0c
PE
12011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2
3 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5
fdc5744d
JB
62011-04-28 Juanma Barranquero <lekktu@gmail.com>
7
8 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9
638f053a
JB
102011-04-28 Juanma Barranquero <lekktu@gmail.com>
11
12 * keyboard.c (Qdelayed_warnings_hook): Define.
13 (command_loop_1): Run `delayed-warnings-hook'
14 if Vdelayed_warnings_list is non-nil.
15 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
16 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
17
d178f871
EZ
182011-04-28 Eli Zaretskii <eliz@gnu.org>
19
20 * doprnt.c (doprnt): Don't return value smaller than the buffer
21 size if the message was truncated. (Bug#8545).
22
b124fd93
JB
232011-04-28 Juanma Barranquero <lekktu@gmail.com>
24
25 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
26 (Fx_window_property): #if-0 the whole functions, not just the bodies.
27
e810457d
PE
282011-04-27 Paul Eggert <eggert@cs.ucla.edu>
29
30 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
31
ea51cceb
JB
322011-04-27 Juanma Barranquero <lekktu@gmail.com>
33
34 * makefile.w32-in: Update dependencies.
35
94dcfacf
EZ
362011-04-27 Eli Zaretskii <eliz@gnu.org>
37
38 Improve `doprnt' and its usage. (Bug#8545)
39 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
40 `format_end'. Remove support for %l as a conversion specifier.
41 Don't use xrealloc. Improve diagnostics when the %l size modifier
42 is used. Update the commentary.
43
44 * eval.c (verror): Simplify calculation of size_t.
45
46 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
47 messages.
48
f61f41d7
PE
492011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
50
51 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
52 change.
53
96fb4434
PE
542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
55
56 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
57 This makes this file independent of the recent pseudovector change.
58
671875da 592011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 60
69e9b5a3
PE
61 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
62
b5f869a7 63 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 64 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 65 Remove unused local.
c8926152 66 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 67
841a1577 68 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
69 GCC 4.6.0 optimizes based on type-based alias analysis. For
70 example, if b is of type struct buffer * and v of type struct
71 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
72 != &v->size, and therefore "v->size = 1; b->size = 2; return
73 v->size;" must therefore return 1. This assumption is incorrect
74 for Emacs, since it type-puns struct Lisp_Vector * with many other
75 types. To fix this problem, this patch adds a new type struct
f904488f 76 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
77 and pseudovectors, and helps optimizing compilers not get fooled
78 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
79 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
80 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
81 the size member.
eab3844f
PE
82 (XSETPVECTYPE): Rewrite in terms of new macro.
83 (XSETPVECTYPESIZE): New macro, specifying both type and size.
84 This is a bit clearer, and further avoids the possibility of
85 undesirable aliasing.
86 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 87 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
88 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
89 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
90 (ASIZE): Now uses header.size rather than size. All
91 previous uses of XVECTOR (foo)->size replaced to use this macro,
92 to avoid the hassle of writing XVECTOR (foo)->header.size.
93 (struct vectorlike_header): New type.
eab3844f
PE
94 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
95 object, to help avoid aliasing.
96 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
97 (SUBRP): Likewise, since Lisp_Subr is a special case.
98 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
99 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
100 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 101 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
102 changed to be "header.size" and "header.next".
103 * buffer.h (struct buffer): Likewise.
104 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
105 * frame.h (struct frame): Likewise.
106 * process.h (struct Lisp_Process): Likewise.
107 * termhooks.h (struct terminal): Likewise.
108 * window.c (struct save_window_data, struct saved_window): Likewise.
109 * window.h (struct window): Likewise.
110 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
111 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
112 * buffer.c (init_buffer_once): Likewise.
113 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
114 special case.
115 * process.c (Fformat_network_address): Use local var for size,
116 for brevity.
117
0df1eac5
PE
118 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
119
847ab9d1 120 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
121 * data.c (atof): Remove decl; no longer used or needed.
122 (digit_to_number): Move to lread.c.
123 (Fstring_to_number): Use new string_to_number function, to be
124 consistent with how the Lisp reader treats infinities and NaNs.
125 Do not assume that floating-point numbers represent EMACS_INT
126 without losing information; this is not true on most 64-bit hosts.
127 Avoid double-rounding errors, by insisting on integers when
128 parsing non-base-10 numbers, as the documentation specifies.
129 * lisp.h (string_to_number): New decl, replacing ...
130 (isfloat_string): Remove.
bc0a5c13 131 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 132 (read1): Do not accept +. and -. as integers; this
452f4150
PE
133 appears to have been a coding error. Similarly, do not accept
134 strings like +-1e0 as floating point numbers. Do not report
135 overflow for integer overflows unless the base is not 10 which
136 means we have no simple and reliable way to continue.
137 Break out the floating-point parsing into a new
138 function string_to_number, so that Fstring_to_number parses
139 floating point numbers consistently with the Lisp reader.
140 (digit_to_number): Moved here from data.c. Make it static inline.
141 (E_CHAR, EXP_INT): Remove, replacing with ...
142 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
143 (string_to_number): New function, replacing isfloat_string.
144 This function checks for valid syntax and produces the resulting
145 Lisp float number too. Rework it so that string-to-number
bc0a5c13 146 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
147 so that overflow for non-base-10 numbers is reported only when
148 there's no portable and simple way to convert to floating point.
452f4150 149
67769ffc
PE
150 * textprop.c (set_text_properties_1): Rewrite for clarity,
151 and to avoid GCC warning about integer overflow.
152
c20db43f
PE
153 * intervals.h (struct interval): Use EMACS_INT for members
154 where EMACS_UINT might cause problems. See
155 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
156 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
157 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
158 All uses changed.
37aa2f85
PE
159 (offset_intervals): Tell GCC not to worry about length overflow
160 when negating a negative length.
c20db43f 161
2538aa2f
PE
162 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
163 (overrun_check_free): Likewise.
164
f2d3008d
PE
165 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
166 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
167 word size.
168
ec8df744
PE
169 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
170 (gnutls_make_error): Rename local to avoid shadowing.
171 (gnutls_emacs_global_deinit): ifdef out; not used.
172 (Fgnutls_boot): Use const for pointer to readonly storage.
173 Comment out unused local. Fix pointer signedness problems.
174
640ee02d
PE
175 * lread.c (openp): Don't stuff size_t into an 'int'.
176 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
177 about possible signed overflow.
178
6048fb2a
PE
179 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
180 (GDK_KEY_g): Don't define if already defined.
181 (xg_prepare_tooltip): Avoid pointer signedness problem.
182 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
183
fa3c87e1
PE
184 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
185 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
186
2172544b
PE
187 * xfns.c (Fx_window_property): Simplify a bit,
188 to make a bit faster and to avoid GCC 4.6.0 warning.
189 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
190
9b821a21
PE
191 * fns.c (internal_equal): Don't assume size_t fits in int.
192
3c616cfa
PE
193 * alloc.c (compact_small_strings): Tighten assertion a little.
194
c2982e87
PE
195 Replace pEd with more-general pI, and fix some printf arg casts.
196 * lisp.h (pI): New macro, generalizing old pEd macro to other
197 conversion specifiers. For example, use "...%"pI"d..." rather
198 than "...%"pEd"...".
199 (pEd): Remove. All uses replaced with similar uses of pI.
200 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
201 * alloc.c (check_pure_size): Don't overflow by converting size to int.
202 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
203 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
204 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
205 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
206 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
207 64-bit hosts.
208 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
209 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
210 * print.c (safe_debug_print, print_object): Likewise.
211 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
212 to int.
6f04d126
PE
213 Use pI instead of if-then-else-abort. Use %p to avoid casts,
214 avoiding the 0 flag, which is not portable.
c2982e87
PE
215 * process.c (Fmake_network_process): Use pI to avoid cast.
216 * region-cache.c (pp_cache): Likewise.
217 * xdisp.c (decode_mode_spec): Likewise.
218 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
219 behavior on 64-bit hosts with printf arg.
6f04d126 220 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
221 (x_stop_queuing_selection_requests): Likewise.
222 (x_get_window_property): Don't truncate byte count to an 'int'
223 when tracing.
0b432f21 224
5e073ec7
PE
225 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
226 here, since it parses constructs like leading '-' and spaces,
227 which are not wanted; and it overflows with large numbers.
228 Instead, simply match F[0-9]+, which is what is wanted anyway.
229
36372bf9
PE
230 * alloc.c: Remove unportable assumptions about struct layout.
231 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
232 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
233 (allocate_vectorlike, make_pure_vector): Use the new macros,
234 plus offsetof, to remove unportable assumptions about struct layout.
235 These assumptions hold on all porting targets that I know of, but
236 they are not guaranteed, they're easy to remove, and removing them
237 makes further changes easier.
238
0b432f21
PE
239 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
240 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
241 (string_overrun_cookie): Now const. Use initializers that
242 don't formally overflow signed char, to avoid warnings.
000098c1
PE
243 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
244 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
245 (allocate_buffer): Don't assume sizeof (struct buffer) is a
246 multiple of sizeof (EMACS_INT); it need not be, if
247 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 248 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 249
895009e1
JB
2502011-04-26 Juanma Barranquero <lekktu@gmail.com>
251
252 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
253
6a7a1b0b
TZ
2542011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
255
256 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 257 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
258 Reported by Paul Eggert <eggert@cs.ucla.edu>.
259
841a1577 2602011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
261
262 * lisp.h (Qdebug): List symbol.
895009e1 263 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
264 * keyboard.c (debug-on-event): New variable.
265 (handle_user_signal): Break into debugger when debug-on-event
266 matches the current signal symbol.
267
f2d3ba6f
DN
2682011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
269
270 * alloc.c (check_sblock, check_string_bytes)
271 (check_string_free_list): Convert to standard C.
272
42ce4c63
TZ
2732011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
274
275 * w32.c (emacs_gnutls_push): Fix typo.
276
825cd63c
EZ
2772011-04-25 Eli Zaretskii <eliz@gnu.org>
278
fb11d64d
EZ
279 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
280 "cast to pointer from integer of different size".
281
825cd63c
EZ
282 Improve doprnt and its use in verror. (Bug#8545)
283 * doprnt.c (doprnt): Document the set of format control sequences
284 supported by the function. Use SAFE_ALLOCA instead of always
285 using `alloca'.
286
287 * eval.c (verror): Don't limit the buffer size at size_max-1, that
288 is one byte too soon. Don't use xrealloc; instead xfree and
289 xmalloc anew.
290
e061a11b
TZ
2912011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
292
293 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
294 callbacks stage.
295
296 * gnutls.c: Renamed global_initialized to
297 gnutls_global_initialized. Added internals for the
298 :verify-hostname-error, :verify-error, and :verify-flags
299 parameters of `gnutls-boot' and documented those parameters in the
300 docstring. Start callback support.
301 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
302 unless a fatal error occured. Call gnutls_alert_send_appropriate
303 on error. Return error code.
304 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
305 (emacs_gnutls_read): Likewise.
306 (Fgnutls_boot): Return handshake error code.
307 (emacs_gnutls_handle_error): New function.
308 (wsaerror_to_errno): Likewise.
309
310 * w32.h (emacs_gnutls_pull): Add prototype.
311 (emacs_gnutls_push): Likewise.
312
313 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
314 (emacs_gnutls_push): Likewise.
315
3162011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
317
318 * process.c (wait_reading_process_output): Check if GnuTLS
319 buffered some data internally if no FDs are set for TLS
320 connections.
321
322 * makefile.w32-in (OBJ2): Add gnutls.$(O).
323 (LIBS): Link to USER_LIBS.
324 ($(BLD)/gnutls.$(0)): New target.
325
fa6996bc
EZ
3262011-04-24 Eli Zaretskii <eliz@gnu.org>
327
eb35682e
EZ
328 * xdisp.c (handle_single_display_spec): Rename the
329 display_replaced_before_p argument into display_replaced_p, to
330 make it consistent with the commentary. Fix typos in the
331 commentary.
332
e2ad650c
EZ
333 * textprop.c (syms_of_textprop): Remove dead code.
334 (copy_text_properties): Delete obsolete commentary about an
335 interface that was deleted long ago. Fix typos in the description
336 of arguments.
337
1b2de274
EZ
338 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
339 to changes in oldXMenu/XMenu.h from 2011-04-16.
340 <menu_help_message, prev_menu_help_message>: Constify.
341 (IT_menu_make_room): menu->help_text is now `const char **';
342 adjust.
343
344 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
345 to changes in oldXMenu/XMenu.h from 2011-04-16.
346 (struct XMenu): Declare `help_text' `const char **'.
347
348 * xfaces.c <Qunspecified>: Make extern again.
349
350 * syntax.c: Include sys/types.h before including regex.h, as
351 required by Posix.
352
762b15be
EZ
353 * doc.c (get_doc_string): Improve the format passed to `error'.
354
355 * doprnt.c (doprnt): Improve commentary.
356
357 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
358
359 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
360 them with etags.
361
f1052e5d
EZ
362 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
363 changes in globals.h immediately force recompilation.
762b15be
EZ
364 (TAGS): Depend on $(CURDIR)/m/intel386.h and
365 $(CURDIR)/s/ms-w32.h.
366 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 367
fa6996bc
EZ
368 * character.c (Fchar_direction): Function deleted.
369 (syms_of_character): Don't defsubr it.
370 <char-direction-table>: Deleted.
371
e6c3da20
EZ
3722011-04-23 Eli Zaretskii <eliz@gnu.org>
373
374 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
375 * doprnt.c: Include limits.h.
376 (SIZE_MAX): New macro.
377 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
378 local variables are now size_t instead of int or unsigned.
379 Improve overflow protection. Support `l' modifier for integer
380 conversions. Support %l conversion. Don't assume an EMACS_INT
381 argument for integer conversions and for %c.
382
383 * lisp.h (doprnt): Restore prototype.
384
385 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
386 $(SRC)/character.h.
387
388 * Makefile.in (base_obj): Add back doprnt.o.
389
390 * deps.mk (doprnt.o): Add back prerequisites.
391 (callint.o): Depend on character.h.
392
393 * eval.c (internal_lisp_condition_case): Include the handler
394 representation in the error message.
395 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
396 when breaking from the loop.
397
398 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
399
400 * callint.c (Fcall_interactively): When displaying error message
401 about invalid control letter, pass the character's codepoint, not
402 a pointer to its multibyte form. Improve display of the character
403 in octal and display also its hex code.
404
405 * character.c (char_string): Use %x to display the (unsigned)
406 codepoint of an invalid character, to avoid displaying a bogus
407 negative value.
408
409 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
410 `error', not SYMBOL_NAME itself.
411
412 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
413 character arguments to `error'.
414
415 * charset.c (check_iso_charset_parameter): Fix incorrect argument
416 to `error' in error message about FINAL_CHAR argument. Make sure
417 FINAL_CHAR is a character, and use %c when it is passed as
418 argument to `error'.
419
4ffd0d6b 4202011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
421
422 * s/ms-w32.h (localtime): Redirect to sys_localtime.
423
424 * w32.c: Include <time.h>.
425 (sys_localtime): New function.
426
4ffd0d6b 4272011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
428
429 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
430
4ffd0d6b 431 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 432
4ffd0d6b 4332011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 434
4ffd0d6b
GM
435 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
436 zombies (Bug#8467).
aac0c6e3 437
04c56954
EZ
4382011-04-19 Eli Zaretskii <eliz@gnu.org>
439
440 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
441 gl_state.e_property when gl_state.object is Qt.
442
443 * insdel.c (make_gap_larger): Remove limitation of buffer size
444 to <= INT_MAX.
445
16a43933
CY
4462011-04-18 Chong Yidong <cyd@stupidchicken.com>
447
448 * xdisp.c (lookup_glyphless_char_display)
449 (produce_glyphless_glyph): Handle cons cell entry in
450 glyphless-char-display.
451 (Vglyphless_char_display): Document it.
452
453 * term.c (produce_glyphless_glyph): Handle cons cell entry in
454 glyphless-char-display.
455
4581706e
CY
4562011-04-17 Chong Yidong <cyd@stupidchicken.com>
457
458 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
459
460 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
461
462 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
463 definition for no-X builds.
464
4887c6e2 4652011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 466
fd35b6f9
PE
467 Static checks with GCC 4.6.0 and non-default toolkits.
468
5c1ccb01
PE
469 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
470
006c5daa
PE
471 * process.c (keyboard_bit_set): Define only if SIGIO.
472 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
473 (send_process): Repair possible setjmp clobbering.
474
efc736d3
PE
475 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
476
4e2fe2e6
PE
477 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
478
f97334a2
PE
479 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
480
4e75f29d
PE
481 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
482 Define only if needed.
483
90efadd1
PE
484 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
485 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 486 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 487
3c647824
PE
488 * dispextern.h (struct redisplay_interface): Rename param
489 to avoid shadowing.
e264f262 490 * termhooks.h (struct terminal): Likewise.
761383f4 491 * xterm.c (xembed_send_message): Likewise.
3c647824 492
b58c5c4a
PE
493 * insdel.c (make_gap_smaller): Define only if
494 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
495
cad59032
PE
496 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
497 it.
498
c339dc2e
PE
499 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
500 so that we aren't warned about unused symbols.
501
91a3e27b
PE
502 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
503
399c71d3 504 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 505
8ffc96f5
PE
506 * xfns.c (x_real_positions): Mark locals as initialized.
507
eef9bc79
PE
508 * xmenu.c (xmenu_show): Don't use uninitialized vars.
509
098db9dd
PE
510 * xterm.c: Fix problems found by static analysis with other toolkits.
511 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
512 (x_dispatch_event): Declare static if USE_GTK, and
513 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 514 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 515 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
516 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
517 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 518
eb18f6cc
PE
519 * xmenu.c (menu_help_callback): Pointer type fixes.
520 Use const pointers when pointing at readonly data. Avoid pointer
521 signedness clashes.
522 (FALSE): Remove unused macro.
523 (update_frame_menubar): Remove unused decl.
524
1fe72bf8
PE
525 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
526
60d9e1db
PE
527 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
528 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
529 (single_menu_item): Rename local to avoid shadowing.
530
39261c26
PE
531 * keyboard.c (make_lispy_event): Remove unused local var.
532
018c5e19
PE
533 * frame.c, frame.h (x_get_resource_string): Bring this back, but
534 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
535
63d2b86e
PE
536 * bitmaps: Change bitmaps from unsigned char back to the X11
537 compatible char. Avoid the old compiler warnings about
538 out-of-range initializers by using, for example, '\xab' rather
539 than 0xab.
540
aefd87e1
PE
541 * xgselect.c (xgselect_initialize): Check vs interface
542 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
543
bf501fb9
PE
544 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
545
e9829fdf
PE
546 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
547 to read-only memory.
548
1086c095
PE
549 * fns.c (vector): Remove; this old hack is no longer needed.
550
2baccd04 551 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 552 Remove unused var.
dde42981 553 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 554
72391843 555 * xrdb.c (x_load_resources): Omit unused local.
3565b346 556
436c16df 557 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 558 (x_window): Rename locals to avoid shadowing.
dc5ddd85 559 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 560
92bb796d 561 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 562 (x_term_init): Remove local to avoid shadowing.
92bb796d 563
764430a3 564 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
565
566 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
567 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
568
d1dfb56c
EZ
5692011-04-16 Eli Zaretskii <eliz@gnu.org>
570
c4354cb4
EZ
571 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
572
d1dfb56c
EZ
573 Fix regex.c, syntax.c and friends for buffers > 2GB.
574 * syntax.h (struct gl_state_s): Declare character position members
575 EMACS_INT.
576
577 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
578
579 * textprop.c (verify_interval_modification, interval_of): Declare
580 arguments EMACS_INT.
581
582 * intervals.c (adjust_intervals_for_insertion): Declare arguments
583 EMACS_INT.
584
585 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
586
587 * indent.c (Fvertical_motion): Local variable it_start is now
588 EMACS_INT.
589
590 * regex.c (re_match, re_match_2, re_match_2_internal)
591 (bcmp_translate, regcomp, regexec, print_double_string)
592 (group_in_compile_stack, re_search, re_search_2, regex_compile)
593 (re_compile_pattern, re_exec): Declare arguments and local
594 variables `size_t' and `ssize_t' and return values `regoff_t', as
595 appropriate.
596 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
597 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
598 <compile_stack_type>: `size' and `avail' are now `size_t'.
599
600 * regex.h <regoff_t>: Use ssize_t, not int.
601 (re_search, re_search_2, re_match, re_match_2): Arguments that
602 specify buffer/string position and length are now ssize_t and
603 size_t. Return type is regoff_t.
604
613052cd
BK
6052011-04-16 Ben Key <bkey76@gmail.com>
606
607 * nsfont.m: Fixed bugs in ns_get_family and
608 ns_descriptor_to_entity that were caused by using free to
609 deallocate memory blocks that were allocated by xmalloc (via
610 xstrdup). This caused Emacs to crash when compiled with
611 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
612 --enable-checking=xmallocoverrun). xfree is now used to
613 deallocate these memory blocks.
614
4170f62f 6152011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 616
71b41406
PE
617 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
618
9587a89d
PE
619 emacs_write: Accept and return EMACS_INT for sizes.
620 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
621 et seq.
622 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
623 Accept and return EMACS_INT.
624 (emacs_gnutls_write): Return the number of bytes written on
625 partial writes.
626 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
627 (emacs_read, emacs_write): Remove check for negative size, as the
628 Emacs source code has been audited now.
9587a89d
PE
629 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
630 (emacs_read, emacs_write): Use it.
273a5f82
PE
631 * process.c (send_process): Adjust to the new signatures of
632 emacs_write and emacs_gnutls_write. Do not attempt to store
633 a byte offset into an 'int'; it might overflow.
9587a89d 634 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 635
3e047f51
PE
636 * sound.c: Don't assume sizes fit in 'int'.
637 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 638 Return EMACS_INT, not int.
3e047f51 639 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
640 Accept EMACS_INT, not int.
641 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
642 record read return values.
643
cc39a9db
BK
6442011-04-15 Ben Key <bkey76@gmail.com>
645
c9d0ec6d
JB
646 * keyboard.c (Qundefined): Don't declare static since it is used
647 in nsfns.m.
648 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
649 static since they are used in nsfont.m.
cc39a9db 650
6c60eb9f
SM
6512011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
652
653 * process.c (Qprocessp): Don't declare static.
654 * lisp.h (Qprocessp): Declare again.
655
7990b61a
JB
6562011-04-15 Juanma Barranquero <lekktu@gmail.com>
657
658 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
659
5d4cb038
PE
6602011-04-14 Paul Eggert <eggert@cs.ucla.edu>
661
8bd7b830 662 Improve C-level modularity by making more things 'static'.
cd64ea1d 663
e3b27b31
PE
664 Don't publish debugger-only interfaces to other modules.
665 * lisp.h (safe_debug_print, debug_output_compilation_hack):
666 (verify_bytepos, count_markers): Move decls to the only modules
667 that need them.
668 * region-cache.h (pp_cache): Likewise.
669 * window.h (check_all_windows): Likewise.
670 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
671
5d4cb038
PE
672 * sysdep.c (croak): Now static, if
673 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
674 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
675
676 * alloc.c (refill_memory_reserve): Now static if
677 !defined REL_ALLOC || defined SYSTEM_MALLOC.
678 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 679
e87b6180
PE
680 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
681 Define only if USE_LUCID.
682
ac64929e
PE
683 * xrdb.c (x_customization_string, x_rm_string): Now static.
684
6f37259d
PE
685 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
686 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
687
1683e3ab
PE
688 * xdisp.c (draw_row_with_mouse_face): Now static.
689 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
690
de9c2632
PE
691 * window.h (check_all_windows): Mark externally visible.
692
2b96acb7
PE
693 * window.c (window_deletion_count): Now static.
694
695 * undo.c: Make symbols static if they're not exported.
696 (last_undo_buffer, last_boundary_position, pending_boundary):
697 Now static.
698
50436f33
PE
699 * textprop.c (interval_insert_behind_hooks): Now static.
700 (interval_insert_in_front_hooks): Likewise.
701
64520e5c
PE
702 * term.c: Make symbols static if they're not exported.
703 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
704 (max_frame_lines, tty_set_terminal_modes):
705 (tty_reset_terminal_modes, tty_turn_off_highlight):
706 (get_tty_terminal): Now static.
707 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
708 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 709 HAVE_WINDOW_SYSTEM.
64520e5c
PE
710 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
711 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
712
1fa53021
PE
713 * sysdep.c: Make symbols static if they're not exported.
714 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
715 Now static.
716 (sigprocmask_set, full_mask): Remove; unused.
717 (wait_debugging): Mark as visible.
718 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
719 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
720
d4b43b22
PE
721 * syntax.c (syntax_temp): Define only if !__GNUC__.
722
b7c513d0
PE
723 * sound.c (current_sound_device, current_sound): Now static.
724
989b29ad
PE
725 * search.c (searchbufs, searchbuf_head): Now static.
726
13a55a78
PE
727 * scroll.c (scroll_cost): Remove; unused.
728 * dispextern.h (scroll_cost): Remove decl.
729
de68a1fc
PE
730 * region-cache.h (pp_cache): Mark as externally visible.
731
40ccffa6
PE
732 * process.c: Make symbols static if they're not exported.
733 (process_tick, update_tick, create_process, chan_process):
734 (Vprocess_alist, proc_buffered_char, datagram_access):
735 (fd_callback_data, send_process_frame, process_sent_to): Now static.
736 (deactivate_process): Mark defn as static, as well as decl.
737 * lisp.h (create_process): Remove decl.
738 * process.h (chan_process, Vprocess_alist): Remove decls.
739
ad64fc97
PE
740 * print.c: Make symbols static if they're not exported.
741 (print_depth, new_backquote_output, being_printed, print_buffer):
742 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
743 (print_interval, print_number_index, initial_stderr_stream):
744 Now static.
745 * lisp.h (Fprinc): Remove decl.
746 (debug_output_compilation_hack): Mark as externally visible.
747
adddb265
PE
748 * sysdep.c (croak): Move decl from here to syssignal.h.
749 * syssignal.h (croak): Put it here, so the API can be checked when
750 'croak' is called from dissociate_if_controlling_tty.
751
1717ede2
PE
752 * minibuf.c: Make symbols static if they're not exported.
753 (minibuf_save_list, choose_minibuf_frame): Now static.
754 * lisp.h (choose_minibuf_frame): Remove decl.
755
fa5fb2bc
PE
756 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
757
1e3890d1
PE
758 * lread.c: Make symbols static if they're not exported.
759 (read_objects, initial_obarray, oblookup_last_bucket_number):
760 Now static.
761 (make_symbol): Remove; unused.
762 * lisp.h (initial_obarray, make_symbol): Remove decls.
763
8a1414fa
PE
764 * keyboard.c: Make symbols static if they're not exported.
765 (single_kboard, recent_keys_index, total_keys, recent_keys):
766 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
767 (this_single_command_key_start, echoing, last_auto_save):
768 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
769 (command_loop, echo_now, keyboard_init_hook, help_char_p):
770 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
771 (Vlispy_mouse_stem, double_click_count):
772 Now static.
773 (force_auto_save_soon): Define only if SIGDANGER.
774 (ignore_mouse_drag_p): Now static if
775 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
776 (print_help): Remove; unused.
777 (stop_character, last_timer_event): Mark as externally visible.
778 * keyboard.h (ignore_mouse_drag_p): Declare only if
779 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
780 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
781 * lisp.h (echoing): Remove decl.
782 (force_auto_save_soon): Declare only if SIGDANGER.
783 * xdisp.c (redisplay_window): Simplify code, to make it more
784 obvious that ignore_mouse_drag_p is not accessed if !defined
785 USE_GTK && !defined HAVE_NS.
786
93ea6e8f
PE
787 * intervals.c: Make symbols static if they're not exported.
788 (merge_properties_sticky, merge_interval_right, delete_interval):
789 Now static.
790 * intervals.h (merge_interval_right, delete_interval): Remove decls.
791
77382fcc
PE
792 * insdel.c: Make symbols static if they're not exported.
793 However, leave prepare_to_modify_buffer alone. It's never
794 called from outside this function, but that appears to be a bug.
795 (combine_after_change_list, combine_after_change_buffer):
4889fc82 796 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
797 (adjust_after_replace_noundo): Remove; unused.
798 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 799 (signal_before_change): Remove decls.
77382fcc 800
9306c32e
PE
801 * indent.c (val_compute_motion, val_vmotion): Now static.
802
cd44d2eb
PE
803 * image.c: Make symbols static if they're not exported.
804 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
805 if USE_GTK.
806 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
807 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
808
ad9a7a06
PE
809 * fringe.c (standard_bitmaps): Now static.
810 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
811
81626931
PE
812 * frame.c: Make symbols static if they're not exported.
813 (x_report_frame_params, make_terminal_frame): Now static.
814 (get_frame_param): Now static, unless HAVE_NS.
815 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
816 (x_get_resource_string): Remove; not used.
817 * frame.h (make_terminal_frame, x_report_frame_params):
818 (x_get_resource_string); Remove decls.
819 (x_fullscreen_adjust): Declare only if WINDOWSNT.
820 * lisp.h (get_frame_param): Declare only if HAVE_NS.
821
239f9db9
PE
822 * font.c, fontset.c: Make symbols static if they're not exported.
823 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
824 (FACE_SUITABLE_FOR_CHAR_P): Use it.
825 * font.c (font_close_object): Now static.
826 * font.h (font_close_object): Remove.
827 * fontset.c (FONTSET_OBJLIST): Remove.
828 (free_realized_fontset) #if-0 the body, which does nothing.
829 (face_suitable_for_char_p): #if-0, as it's never called.
830 * fontset.h (face_suitable_for_char_p): Remove decl.
831 * xfaces.c (face_at_string_position): Use
832 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
833 since 0 is always ASCII.
834
dfcf3579
PE
835 * fns.c (weak_hash_tables): Now static.
836
5045092b
PE
837 * fileio.c: Make symbols static if they're not exported.
838 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
839 (Vwrite_region_annotation_buffers): Now static.
840
57a96f5c
PE
841 * eval.c: Make symbols static if they're not exported.
842 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
843 * lisp.h (backtrace_list): Remove decl.
844
35f08c38
PE
845 * emacs.c: Make symbols static if they're not exported.
846 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
847 (fatal_error_code, fatal_error_signal_hook, standard_args):
848 Now static.
849 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
850 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
851 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
852 * lisp.h (fatal_error_signal_hook): Remove decl.
853 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
854
f44bd759
PE
855 * editfns.c: Move a (normally-unused) function to its only use.
856 * editfns.c, lisp.h (get_operating_system_release): Remove.
857 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
858 worth the hassle of breaking this out.
859
b532497d
PE
860 * xterm.c: Make symbols static if they're not exported.
861 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
862 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
863 (x_destroy_window, x_delete_display):
864 Now static.
865 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
866 (x_mouse_leave): Remove; unused.
867 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
868 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
869 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
870 Remove decls.
871 (x_mouse_leave): Declare only if WINDOWSNT.
872 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
873 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
874 USE_X_TOOLKIT.
875
1675728f
PE
876 * ftxfont.c: Make symbols static if they're not exported.
877 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
878 HAVE_FREETYPE.
879 * font.h (ftxfont_driver): Likewise.
880
e4cebfca
PE
881 * xfns.c: Make symbols static if they're not exported.
882 (x_last_font_name, x_display_info_for_name):
883 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
884 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
885 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
886 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
887 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
888 (last_show_tip_args): Now static.
889 (xic_defaut_fontset, xic_create_fontsetname): Define only if
890 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
891 (x_screen_planes): Remove; unused.
892 * dispextern.h (x_screen_planes): Remove decl.
893
5bf46f05
PE
894 * dispnew.c: Make symbols static if they're not exported.
895 * dispextern.h (redraw_garbaged_frames, scrolling):
896 (increment_row_positions): Remove.
897 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
898 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
899 Now static.
900 (redraw_garbaged_frames): Remove; unused.
901
435f4c28
PE
902 * xfaces.c: Make symbols static if they're not exported.
903 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
904 Remove decls.
905 * xterm.h (defined_color): Remove decls.
906 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
907 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
908 (menu_face_changed_default, defined_color, free_realized_face):
909 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
910 (ascii_face_of_lisp_face): Remove; unused.
911
8524aef3
PE
912 * xdisp.c: Make symbols static if they're not exported.
913 * dispextern.h (scratch_glyph_row, window_box_edges):
914 (glyph_to_pixel_coords, set_cursor_from_row):
915 (get_next_display_element, set_iterator_to_next):
916 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
917 (show_mouse_face): Remove decls
918 * frame.h (message_buf_print): Likewise.
919 * lisp.h (pop_message, set_message, check_point_in_composition):
920 Likewise.
921 * xterm.h (set_vertical_scroll_bar): Likewise.
922 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
923 (message_buf_print, scratch_glyph_row, displayed_buffer):
924 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
925 (get_next_display_element, show_mouse_face, window_box_edges):
926 (frame_to_window_pixel_xy, check_point_in_composition):
927 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
928 (glyph_to_pixel_coords): Remove; unused.
929
16390cd2
PE
930 * dired.c (file_name_completion): Now static.
931
932 * dbusbind.c (xd_in_read_queued_messages): Now static.
933
a25f4dfa
PE
934 * lisp.h (circular_list_error, FOREACH): Remove; unused.
935 * data.c (circular_list_error): Remove.
936
14a9c8df
PE
937 * commands.h (last_point_position, last_point_position_buffer):
938 (last_point_position_window): Remove decls.
939 * keyboard.c: Make these variables static.
940
74ab6df5
PE
941 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
942 decls.
943 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
944 (iso_code_class, detect_coding, code_convert_region): Now static.
945 (encode_coding_gap): Remove; unused.
946
38dfbee1
PE
947 * chartab.c (chartab_chars, chartab_bits): Now static.
948
a2cb4e63
PE
949 * charset.h (charset_iso_8859_1): Remove decl.
950 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
951 Now static.
952
127198fd
PE
953 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
954 * ccl.c (Vccl_program_table): Now static.
955 (check_ccl_update): Remove; unused.
956
d85b608f
PE
957 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
958 * category.h: ... from here.
959 * category.c (check_category_table, set_category_set): Now static.
960
31cd66f3
PE
961 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
962 * lisp.h: Remove these decls.
963
c358e587
PE
964 * buffer.c (buffer_count): Remove unused var.
965
e78aecca
PE
966 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
967 so that it's not optimized away.
968 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
969 * dispextern.h (bidi_dump_cached_states): Remove, since it's
970 exported only to the debugger.
971
e192d7d3
PE
972 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
973 * atimer.h (run_all_atimers): Removed; not exported.
974
92470028
PE
975 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
976 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
977 was inaccessible from Lisp.
978 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
979 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
980
244ed907
PE
981 alloc.c: Import and export fewer symbols, and remove unused items.
982 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
983 is defined.
984 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
985 it's not optimized away by whole-program optimization.
986 (message_enable_multibyte, free_misc): Remove.
987 (catchlist, handlerlist, mark_backtrace):
988 Declare only if BYTE_MARK_STACK.
989 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
990 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
991 (message_enable_multibyte): Remove decl.
992 (free_misc, interval_free_list, float_block, float_block_index):
993 (n_float_blocks, float_free_list, cons_block, cons_block_index):
994 (cons_free_list, last_marked_index):
995 Now static.
996 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
997 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
998 (mark_backtrace): Define only if BYTE_MARK_STACK.
999 * xdisp.c (message_enable_multibyte): Now static.
1000
61c2b50e 1001 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1002 This makes it easier for human readers (and static analyzers)
1003 to see whether these variables are used from other modules.
1004 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1005 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1006 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1007 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1008 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1009 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1010 * xmenu.c, xselect.c:
1011 Declare Q* vars static if they are not used in other modules.
1012 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1013 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1014 Remove decls of unexported vars.
1015 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1016
95c82688
PE
1017 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1018
16a97296
PE
1019 Make Emacs functions such as Fatom 'static' by default.
1020 This makes it easier for human readers (and static analyzers)
1021 to see whether these functions can be called from other modules.
1022 DEFUN now defines a static function. To make the function external
1023 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1024 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1025 (Finit_image_library):
16a97296
PE
1026 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1027 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1028 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1029 Remove decls, since these functions are now static.
1030 (Funintern, Fget_internal_run_time): New decls, since these functions
1031 were already external.
95c82688 1032
16a97296
PE
1033 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1034 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1035 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1036 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1037 * keyboard.c, keymap.c, lread.c:
1038 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1039 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1040 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1041 Mark functions with DEFUE instead of DEFUN,
1042 if they are used in other modules.
1043 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1044 decls for now-static functions.
1045 * buffer.h (Fdelete_overlay): Remove decl.
1046 * callproc.c (Fgetenv_internal): Mark as internal.
1047 * composite.c (Fremove_list_of_text_properties): Remove decl.
1048 (Fcomposition_get_gstring): New forward static decl.
1049 * composite.h (Fcomposite_get_gstring): Remove decl.
1050 * dired.c (Ffile_attributes): New forward static decl.
1051 * doc.c (Fdocumntation_property): New forward static decl.
1052 * eval.c (Ffetch_bytecode): New forward static decl.
1053 (Funintern): Remove extern decl; now in .h file where it belongs.
1054 * fileio.c (Fmake_symbolic_link): New forward static decl.
1055 * image.c (Finit_image_library): New forward static decl.
1056 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1057 * intervals.h (Fprevious_property_change):
1058 (Fremove_list_of_text_properties): Remove decls.
1059 * keyboard.c (Fthis_command_keys): Remove decl.
1060 (Fcommand_execute): New forward static decl.
1061 * keymap.c (Flookup_key): New forward static decl.
1062 (Fcopy_keymap): Now static.
1063 * keymap.h (Flookup_key): Remove decl.
1064 * process.c (Fget_process): New forward static decl.
1065 (Fprocess_datagram_address): Mark as internal.
1066 * syntax.c (Fsyntax_table_p): New forward static decl.
1067 (skip_chars): Remove duplicate decl.
1068 * textprop.c (Fprevious_property_change): New forward static decl.
1069 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1070 Now internal.
1071 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1072 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1073
785bbd42
PE
1074 * editfns.c (Fformat): Remove unreachable code.
1075
8b913b57
AS
10762011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1077
1078 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1079 change. (Bug#8496)
1080
a6744a35
EZ
10812011-04-13 Eli Zaretskii <eliz@gnu.org>
1082
1083 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1084 when at ZV. (Bug#8487)
1085
e7974947
AS
10862011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1087
baad03f0
AS
1088 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1089 (Bug#8437)
1090 * keyboard.c (parse_tool_bar_item): Likewise.
1091 * sound.c (sound_cleanup, alsa_close): Likewise.
1092 * termcap.c (tgetent): Likewise.
1093 * xfns.c (x_default_font_parameter): Likewise.
1094 * xsettings.c (read_and_apply_settings): Likewise.
1095
e7974947
AS
1096 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1097 (overrun_check_free): Protoize.
1098
28272684
PE
10992011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1100
1101 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1102 since callers should never pass a negative size.
1103 Change the signature to match that of plain 'read' and 'write'; see
1104 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1105 * lisp.h: Update prototypes of emacs_write and emacs_read.
1106
11997c76
EZ
11072011-04-11 Eli Zaretskii <eliz@gnu.org>
1108
1109 * xdisp.c (redisplay_window): Don't try to determine the character
1110 position of the scroll margin if the window start point w->startp
e896f03c 1111 is outside the buffer's accessible region. (Bug#8468)
11997c76 1112
8a2cbd72
EZ
11132011-04-10 Eli Zaretskii <eliz@gnu.org>
1114
1115 Fix write-region and its subroutines for buffers > 2GB.
1116 * fileio.c (a_write, e_write): Modify declaration of arguments and
1117 local variables to support buffers larger than 2GB.
1118 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1119
1120 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1121 argument, local variables, and return value.
1122
1123 * lisp.h: Update prototypes of emacs_write and emacs_read.
1124
1125 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1126
4073e537 11272011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1128
1ebfdcb6
PE
1129 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1130
b2ded58d
PE
1131 Fix more problems found by GCC 4.6.0's static checks.
1132
7d66342c
PE
1133 * xdisp.c (vmessage): Use a better test for character truncation.
1134
bbf47d44
PE
1135 * charset.c (load_charset_map): <, not <=, for optimization,
1136 and to avoid potential problems with integer overflow.
9248994d 1137 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1138 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1139 * editfns.c (Fformat): Likewise.
1e69125e 1140 * syntax.c (skip_chars): Likewise.
3befa583 1141
e3019616
PE
1142 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1143 This also lets GCC 4.6.0 generate slightly better loop code.
1144
becfa255
PE
1145 * callint.c (Fcall_interactively): <, not <=, for optimization.
1146 (Fcall_interactively): Count the number of arguments produced,
1147 not the number of arguments given. This is simpler and lets GCC
1148 4.6.0 generate slightly better code.
1149
dae0cd48
PE
1150 * ftfont.c: Distingish more carefully between FcChar8 and char.
1151 The previous code passed unsigned char * to a functions like
1152 strlen and xstrcasecmp that expect char *, which does not
1153 conform to the C standard.
1154 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1155 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1156 char * when the C standard requires it.
1157
76032d70
PE
1158 * keyboard.c (read_char): Remove unused var.
1159
eb3f1cc8
PE
1160 * eval.c: Port to Windows vsnprintf (Bug#8435).
1161 Include <limits.h>.
1162 (SIZE_MAX): Define if the headers do not.
1163 (verror): Do not give up if vsnprintf returns a negative count.
1164 Instead, grow the buffer. This ports to Windows vsnprintf, which
1165 does not conform to C99. Problem reported by Eli Zaretskii.
1166 Also, simplify the allocation scheme, by avoiding the need for
1167 calling realloc, and removing the ALLOCATED variable.
1168
70476b54
PE
1169 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1170
12020a9e
PE
1171 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1172 But keep the doprint source code for now, as we might revamp it
1173 and use it again (Bug#8435).
ea6c7ae6
PE
1174 * lisp.h (doprnt): Remove.
1175 * Makefile.in (base_obj): Remove doprnt.o.
1176 * deps.mk (doprnt.o): Remove.
1177
5fdb398c
PE
1178 error: Print 32- and 64-bit integers portably (Bug#8435).
1179 Without this change, on typical 64-bit hosts error ("...%d...", N)
1180 was used to print both 32- and 64-bit integers N, which relied on
1181 undefined behavior.
1182 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1183 New macro.
1184 * lisp.h (error, verror): Mark as printf-like functions.
1185 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1186 Report overflow in size calculations when allocating printf buffer.
1187 Do not truncate output string at its first null byte.
1188 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1189 Truncate the output at a character boundary, since vsnprintf does not
1190 do that.
1191 * charset.c (check_iso_charset_parameter): Convert internal
1192 character to string before calling 'error', since %c now has the
1193 printf meaning.
1194 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1195 overflow when computing char to be passed to 'error'. Do not
1196 pass Lisp_Object to 'error'; pass the integer instead.
1197 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1198 formatted with plain %d.
1199
b189fa66
PE
1200 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1201
bff87ef0
PE
1202 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1203
7e2cac20
PE
1204 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1205
ce4d90b5
PE
1206 * xterm.c (x_catch_errors): Remove duplicate declaration.
1207
266c9547
PE
1208 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1209
79c49ad2
PE
1210 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1211
368f4090
JM
12122011-04-10 Jim Meyering <meyering@redhat.com>
1213
1214 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1215 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1216 return ssize_t not "int", and use size_t as the buffer length.
1217 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1218 * gnutls.h: Update declarations.
1219 * process.c (read_process_output): Use ssize_t, to match.
1220 (send_process): Likewise.
1221
a32d4040
CY
12222011-04-09 Chong Yidong <cyd@stupidchicken.com>
1223
1224 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1225
8546720e 12262011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1227
8546720e
GM
1228 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1229 unsigned char, to match FcChar8 type definition.
aac0c6e3 1230
8546720e
GM
1231 * xterm.c (handle_one_xevent):
1232 * xmenu.c (create_and_show_popup_menu):
1233 * xselect.c (x_decline_selection_request)
1234 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1235
0a2f5c1a 12362011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1237
1238 Fix some uses of `int' instead of EMACS_INT.
1239 * search.c (string_match_1, fast_string_match)
1240 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1241 (scan_buffer, find_next_newline_no_quit)
1242 (find_before_next_newline, search_command, Freplace_match)
1243 (Fmatch_data): Make some `int' variables be EMACS_INT.
1244
1245 * xdisp.c (display_count_lines): 3rd argument and return value now
1246 EMACS_INT. All callers changed.
1247 (pint2hrstr): Last argument is now EMACS_INT.
1248
1249 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1250 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1251 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1252 (decode_coding_utf_16, decode_coding_emacs_mule)
1253 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1254 (decode_coding_ccl, decode_coding_charset)
1255 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1256 (decode_coding_iso_2022, decode_coding_emacs_mule)
1257 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1258 <char_offset, last_offset>: Declare EMACS_INT.
1259 (encode_coding_utf_8, encode_coding_utf_16)
1260 (encode_coding_emacs_mule, encode_invocation_designation)
1261 (encode_designation_at_bol, encode_coding_iso_2022)
1262 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1263 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1264 Declare EMACS_INT.
1265 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1266 (encode_invocation_designation): Last argument P_NCHARS is now
1267 EMACS_INT.
1268 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1269 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1270
1271 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1272 All users changed.
1273
1274 * ccl.c (Fccl_execute_on_string): Declare some variables
1275 EMACS_INT.
1276
8546720e 12772011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1278
1279 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1280
4e19a977
CS
12812011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1282
1283 * process.c (Fformat_network_address): Doc fix.
1284
87302331
R
12852011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1286
1287 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1288
cbb59342
CY
12892011-04-08 Chong Yidong <cyd@stupidchicken.com>
1290
1291 * keyboard.c (read_char): Call Lisp function help-form-show,
1292 instead of using internal_with_output_to_temp_buffer.
1293 (Qhelp_form_show): New var.
e0d38eeb 1294 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1295
1296 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1297
1298 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1299
e67a13ab
CY
13002011-04-06 Chong Yidong <cyd@stupidchicken.com>
1301
1302 * process.c (Flist_processes): Removed to Lisp.
1303 (list_processes_1): Deleted.
1304
973f782d
EZ
13052011-04-06 Eli Zaretskii <eliz@gnu.org>
1306
7c106b1e
EZ
1307 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1308
973f782d
EZ
1309 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1310
41cf7d1a 13112011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1312
ca23cc88
PE
1313 Fix more problems found by GCC 4.6.0's static checks.
1314
f390e2d5
PE
1315 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1316
42eea0d0
PE
1317 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1318
b69769da 1319 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1320
f9541e84
PE
1321 * xdisp.c (vmessage): Mark as a printf-like function.
1322
13841b55
PE
1323 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1324
c136c10f
PE
1325 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1326
5e2d4a30
PE
1327 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1328 printf-like functions.
1329 (tiff_load): Add casts to remove these marks before passing them
1330 to system-supplied API.
1331
583f48b9
PE
1332 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1333
b25d760e
PE
1334 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1335 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1336 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1337 directly, rather than having caller test rule sign. This avoids
1338 some unnecessary tests.
1339 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1340 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1341 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1342
bc7b6697 1343 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1344 (xfont_open): Avoid unnecessary tests.
bc7b6697 1345
27ccc379
PE
1346 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1347
dcd5c89a
PE
1348 * composite.h, composite.c (composition_gstring_put_cache):
1349 Use EMACS_INT, not int, for length.
1350
b13a45c6
PE
1351 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1352 breaking out part of COMPOSITION_DECODE_RULE.
1353 (COMPOSITION_DECODE_RULE): Use it.
1354 * composite.c (get_composition_id): Remove unused local vars,
1355 by using the new macro.
1356
1e792e4d
PE
1357 * textprop.c (set_text_properties_1): Change while to do-while,
1358 since the condition is always true at first.
1359
dc6c6455 1360 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1361 (interval_deletion_adjustment): Return unsigned value.
1362 All uses changed.
dc6c6455 1363
aba7731a
PE
1364 * process.c (list_processes_1, create_pty, read_process_output):
1365 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1366 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1367 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1368 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1369 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1370
fdfc4bf3
PE
1371 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1372
fca8fe46 1373 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1374 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1375
06a0259a 1376 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1377 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1378 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1379
e7b9e80f
PE
1380 * print.c (print_error_message): Avoid int overflow.
1381
56201685
PE
1382 * font.c (font_list_entities): Redo for clarity,
1383 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1384
78834453 1385 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1386 (font_score): Avoid potential overflow in diff calculation.
78834453 1387
0bc0b309 1388 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1389 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1390
e610eaca
PE
1391 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1392
b895abce
PE
1393 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1394 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1395 can always succeed if overflow has undefined behavior.
1396
1f1d9321 1397 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1398 (wordify): Omit three unnecessary tests.
1f1d9321 1399
c59478bc
PE
1400 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1401 All callers changed. This avoids the need for an unused var.
1402
79b73827
PE
1403 * casefiddle.c (casify_region): Remove var that is set but not used.
1404
a4db5dfe
PE
1405 * dired.c (file_name_completion): Remove var that is set but not used.
1406
43aae36e
PE
1407 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1408
2a47c44d 1409 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1410 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1411
a37c69bf
PE
1412 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1413 Check for integer overflow on size calculations.
1414
328ab8e7
PE
1415 * buffer.c (Fprevious_overlay_change): Remove var that is set
1416 but not used.
1417
e5a2a5cb
PE
1418 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1419 Remove vars that are set but not used.
8d84a6eb 1420 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1421 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1422
a60e5f68
PE
1423 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1424
f661cb61 1425 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1426 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1427
f0397f5a
PE
1428 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1429 that are set but not used.
1430
8664db06 1431 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1432 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1433
6abdaa4a
PE
1434 * xselect.c (x_get_local_selection, x_handle_property_notify):
1435 Remove vars that are set but not used.
1436
0ce7538d 1437 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1438 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1439
9ae848fc
PE
1440 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1441 Remove var that is set but not used.
0b918413
PE
1442 (scroll_bar_windows_size): Now size_t, not int.
1443 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1444 Check for overflow.
9ae848fc 1445
a5a62657
PE
1446 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1447 (map_tty_color) [!defined MSDOS]: Likewise.
1448
5c5cdd39
PE
1449 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1450
66ebf983
PE
1451 * coding.c: Remove vars that are set but not used.
1452 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1453 All callers changed.
1454 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1455 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1456 (decode_coding_charset): Remove vars that are set but not used.
1457
1be4d761
PE
1458 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1459 that is set but not used.
1460
47553fa8
PE
1461 * print.c (print_object): Remove var that is set but not used.
1462
1f7196bf 1463 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1464 The gnulib version avoids calling malloc in the usual case,
1465 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1466 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1467 * filelock.c (current_lock_owner): Likewise.
1468 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1469 * sysdep.c: Include allocator.h, careadlinkat.h.
1470 (emacs_no_realloc_allocator): New static constant.
1471 (emacs_readlink): New function.
fdb61804
PE
1472 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1473 ../lib/careadlinkat.h.
d1fdcab7 1474
f84c17c7
SM
14752011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1476
1477 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1478 first non-nil return value).
1479
ef3862ad
JD
14802011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1481
1482 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1483 if not defined (Bug#8403).
1484
376a7006
JB
14852011-04-02 Juanma Barranquero <lekktu@gmail.com>
1486
1487 * xdisp.c (display_count_lines): Remove parameter `start',
1488 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1489 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1490 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1491 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1492 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1493 and thereabouts. All callers changed.
1494 (get_per_char_metric): Remove parameter `f', unused since
1495 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1496
6ca3801d
JM
14972011-04-02 Jim Meyering <meyering@redhat.com>
1498
1499 do not dereference NULL upon failed strdup
1500 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1501 (ns_get_family): Likewise.
1502
d8e2b5ba
JB
15032011-04-02 Juanma Barranquero <lekktu@gmail.com>
1504
1505 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1506
8c74fcbd
JD
15072011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1508
1509 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1510 later (Bug#8403).
1511
7200d79c
SM
15122011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1513
03408648 1514 Add lexical binding.
7200d79c 1515
03408648
SM
1516 * window.c (Ftemp_output_buffer_show): New fun.
1517 (Fsave_window_excursion):
1518 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1519
1520 * lread.c (lisp_file_lexically_bound_p): New function.
1521 (Fload): Bind Qlexical_binding.
1522 (readevalloop): Remove `evalfun' arg.
1523 Bind Qinternal_interpreter_environment.
1524 (Feval_buffer): Bind Qlexical_binding.
1525 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1526 Mark as dynamic.
1527 (syms_of_lread): Declare `lexical-binding'.
1528
1529 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1530
1531 * keyboard.c (eval_dyn): New fun.
1532 (menu_item_eval_property): Use it.
ca105506
SM
1533
1534 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1535
03408648
SM
1536 * fns.c (concat, mapcar1): Accept byte-code-functions.
1537
1538 * eval.c (Fsetq): Handle lexical vars.
1539 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1540 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1541 (FletX, Flet): Obey lexical binding.
1542 (Fcommandp): Handle closures.
1543 (Feval): New `lexical' arg.
1544 (eval_sub): New function extracted from Feval. Use it almost
1545 everywhere where Feval was used. Look up vars in lexical env.
1546 Handle closures.
1547 (Ffunctionp): Move from subr.el.
1548 (Ffuncall): Handle closures.
1549 (apply_lambda): Remove `eval_flags'.
1550 (funcall_lambda): Handle closures and new byte-code-functions.
1551 (Fspecial_variable_p): New function.
1552 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1553 but without exporting it to Lisp.
23aba0ea 1554
23aba0ea 1555 * doc.c (Fdocumentation, store_function_docstring):
03408648 1556 * data.c (Finteractive_form): Handle closures.
23aba0ea 1557
03408648
SM
1558 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1559 interactive spec.
ba83908c 1560
03408648
SM
1561 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1562 byte-codes.
1563 (exec_byte_code): New function extracted from Fbyte_code to handle new
1564 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1565
03408648 1566 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1567
03408648 1568 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1569
e2abce01
JB
15702011-03-31 Juanma Barranquero <lekktu@gmail.com>
1571
1572 * xdisp.c (redisplay_internal): Fix prototype.
1573
63696a73 15742011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1575
63696a73
EZ
1576 * xdisp.c (SCROLL_LIMIT): New macro.
1577 (try_scrolling): Use it when setting scroll_limit. Limit
1578 scrolling to 100 screen lines.
1579 (redisplay_window): Even when falling back on "recentering",
1580 position point in the window according to scroll-conservatively,
1581 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1582
1583 (try_scrolling): When point is above the window, allow searching
1584 as far as scroll_max, or one screenful, to compute vertical
1585 distance from PT to the scroll margin position. This prevents
1586 try_scrolling from unnecessarily failing when
1587 scroll-conservatively is set to a value slightly larger than the
1588 window height. Clean up the case of PT below the margin at bottom
1589 of window: scroll_max can no longer be INT_MAX. When aggressive
1590 scrolling is in use, don't let point enter the opposite scroll
1591 margin as result of the scroll.
1592 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1593 threshold of 100 lines for never-recentering scrolling.
1594
e4cc2dfc
JB
15952011-03-31 Juanma Barranquero <lekktu@gmail.com>
1596
1597 * dispextern.h (move_it_by_lines):
1598 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1599 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1600 (message_log_check_duplicate): Remove parameters `prev_bol' and
1601 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1602 (redisplay_internal): Remove parameter `preserve_echo_area',
1603 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1604
1605 * indent.c (Fvertical_motion):
1606 * window.c (window_scroll_pixel_based, Frecenter):
1607 Don't pass `need_y_p' to `move_it_by_lines'.
1608
1c470562
SM
16092011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1610
44f230aa
SM
1611 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1612 steal a few bits to be more compact.
1613 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1614 Remove unneeded casts.
1615
1c470562
SM
1616 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1617
888adce9
ZK
16182011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1619
1620 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1621 binding" message (bug#7967).
1622
f838ed7b
PE
16232011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1624
77861b95
PE
1625 Fix more problems found by GCC 4.6.0's static checks.
1626
de6dbc14
PE
1627 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1628 Remove unused local var.
1629
f838ed7b
PE
1630 * editfns.c (Fmessage_box): Remove unused local var.
1631
792c7b2b
PE
1632 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1633 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1634 Omit unused local vars.
c499e557 1635 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1636 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1637 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1638 Omit unused local var.
1639
ba0165e1
PE
1640 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1641 Don't assume string length fits in int.
32ad8845 1642 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1643 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1644
3c59b4c9
PE
1645 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1646 instead of alloca (Bug#8344).
1647
a3eed478 1648 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1649 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1650
eb4d412d
PE
1651 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1652
1658b401
PE
1653 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1654 concerns.
1655
1656 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1657
1658 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1659
9a2c6e05
PE
1660 * keyboard.c (syms_of_keyboard): Use the same style as later
1661 in this function when indexing through an array. This also
1662 works around GCC bug 48267.
1663
03d0a109
PE
1664 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1665
44f730c8
PE
1666 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1667
fe75f926
PE
1668 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1669 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1670
ffa8c828
PE
1671 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1672 This avoids undefined behavior on integer overflow, and is a bit
1673 more convenient anyway since it is compared to a size_t variable.
1674
c5101a77
PE
1675 Variadic C functions now count arguments with size_t, not int.
1676 This avoids an unnecessary limitation on 64-bit machines, which
1677 caused (substring ...) to crash on large vectors (Bug#8344).
1678 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1679 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1680 All variadic functions and their callers changed accordingly.
c5101a77
PE
1681 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1682 * data.c (arith_driver, float_arith_driver): Likewise.
1683 * editfns.c (general_insert_function): Likewise.
1684 * eval.c (struct backtrace.nargs, interactive_p)
1685 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1686 (funcall_lambda, mark_backtrace): Likewise.
1687 * fns.c (concat): Likewise.
1688 * frame.c (x_set_frame_parameters): Likewise.
1689 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1690 0 if not found, not -1. All callers changed.
1691
dd3f25f7
PE
1692 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1693 (stack_copy_size): Now size_t, not int.
1694 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1695
461c2ab9
JB
16962011-03-28 Juanma Barranquero <lekktu@gmail.com>
1697
1698 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1699 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1700 All callers changed.
1701
1702 * lisp.h (multibyte_char_to_unibyte):
1703 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1704 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1705 * character.h (CHAR_TO_BYTE8):
1706 * cmds.c (internal_self_insert):
1707 * editfns.c (general_insert_function):
1708 * keymap.c (push_key_description):
1709 * search.c (Freplace_match):
1710 * xdisp.c (message_dolog, set_message_1): All callers changed.
1711
f6d62986
SM
17122011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1713
1714 * keyboard.c (safe_run_hook_funcall): New function.
1715 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1716 don't set the hook to nil, but remove the offending function instead.
1717 (Qcommand_hook_internal): Remove, unused.
1718 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1719 Vcommand_hook_internal.
1720
1721 * eval.c (enum run_hooks_condition): Remove.
1722 (funcall_nil, funcall_not): New functions.
1723 (run_hook_with_args): Call each function through a `funcall' argument.
1724 Remove `cond' argument, now redundant.
1725 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1726 (Frun_hook_with_args_until_failure): Adjust accordingly.
1727 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1728
1db5b1ad
JB
17292011-03-28 Juanma Barranquero <lekktu@gmail.com>
1730
1731 * dispextern.h (string_buffer_position): Remove declaration.
1732
1733 * print.c (strout): Remove parameter `multibyte', unused since
1734 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1735
1736 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1737 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1738 All callers changed.
1739
1740 * w32.c (_wsa_errlist): Use braces for struct initializers.
1741
1742 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1743 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1744 All callers changed.
1745 (string_buffer_position): Likewise. Also, make static (it's never
1746 used outside xdisp.c).
1747 (cursor_row_p): Remove parameter `w', unused since
1748 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1749 (decode_mode_spec): Remove parameter `precision', introduced during
1750 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1751 All callers changed.
1752
5ffb62aa
JD
17532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1754
1755 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1756
461c2ab9 17572011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1758
1759 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1760 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1761 (ns_update_auto_hide_menu_bar): New functions.
1762 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1763 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1764 ns_constrain_all_frames.
1765 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1766 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1767
5c380ffb
JD
17682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1769
1770 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1771
9af30bdf
GM
17722011-03-27 Glenn Morris <rgm@gnu.org>
1773
1774 * syssignal.h: Replace RETSIGTYPE with void.
1775 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1776 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1777 Replace SIGTYPE with void everywhere.
1778 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1779 * s/template.h (SIGTYPE): Remove commented out definition.
1780
e2abce01
JB
17812011-03-26 Eli Zaretskii <eliz@gnu.org>
1782
1783 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1784 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1785
f868cd8a
JB
17862011-03-26 Juanma Barranquero <lekktu@gmail.com>
1787
59eb0929
JB
1788 * w32.c (read_unc_volume): Use parameter `henum', instead of
1789 global variable `wget_enum_handle'.
1790
1791 * keymap.c (describe_vector): Remove parameters `indices' and
1792 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1793 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1794
f868cd8a
JB
1795 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1796
1797 * keyboard.c (timer_check): Remove parameter `do_it_now',
1798 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1799 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1800 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1801
1802 * keyboard.c (read_char):
1803 * w32menu.c (w32_menu_display_help):
1804 * xmenu.c (show_help_event, menu_help_callback):
1805 Adjust calls to `show_help_echo'.
1806
1807 * gtkutil.c (xg_maybe_add_timer):
1808 * keyboard.c (readable_events):
1809 * process.c (wait_reading_process_output):
1810 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1811
1812 * insdel.c (adjust_markers_gap_motion):
1813 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1814 (gap_left, gap_right): Don't call it.
1815
2ecf6fdb
CY
18162011-03-25 Chong Yidong <cyd@stupidchicken.com>
1817
1818 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1819 incurred during fontification.
1820
6b1f9ba4
JB
18212011-03-25 Juanma Barranquero <lekktu@gmail.com>
1822
1823 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1824 (DEFVAR_PER_BUFFER): Don't pass it.
1825
1826 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1827 (scrolling_window): Don't pass it.
1828
0f4a96b5
JB
18292011-03-25 Juanma Barranquero <lekktu@gmail.com>
1830
1831 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1832
1833 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1834 and `suffix'.
1835 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1836 of variables specific to SELinux and computation of `encoded_absname'.
1837
1838 * image.c (XPutPixel): Remove unused variable `height'.
1839
1840 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1841
1842 * unexw32.c (get_section_info): Remove unused variable `section'.
1843
1844 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1845 (system_process_attributes): Remove unused variable `sess'.
1846 (sys_read): Remove unused variable `err'.
1847
1848 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1849 (w32_wnd_proc): Remove unused variable `isdead'.
1850 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1851 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1852 (x_create_tip_frame): Remove unused variable `tem'.
1853
1854 * w32inevt.c (w32_console_read_socket):
1855 Remove unused variable `no_events'.
1856
1857 * w32term.c (x_draw_composite_glyph_string_foreground):
1858 Remove unused variable `width'.
1859
1149507c
JB
18602011-03-24 Juanma Barranquero <lekktu@gmail.com>
1861
1862 * w32term.c (x_set_glyph_string_clipping):
1863 Don't pass uninitialized region to CombineRgn.
1864
9c88f339
JB
18652011-03-23 Juanma Barranquero <lekktu@gmail.com>
1866
1867 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1868 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1869 (Fx_close_connection): Remove unused variable `i'.
1870
1871 * w32font.c (w32font_draw): Return number of glyphs.
1872 (w32font_open_internal): Remove unused variable `i'.
1873 (w32font_driver): Add missing initializer.
1874
1875 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1876 (fill_in_menu): Remove unused variable `items_added'.
1877
1878 * w32term.c (last_mouse_press_frame): Remove static global variable.
1879 (w32_clip_to_row): Remove unused variable `f'.
1880 (x_delete_terminal): Remove unused variable `i'.
1881
1882 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1883 (NOTHING): Remove unused static global variable.
1884 (uniscribe_check_otf): Remove unused variable `table'.
1885 (uniscribe_font_driver): Add missing initializers.
1886
dee091a3
JD
18872011-03-23 Julien Danjou <julien@danjou.info>
1888
1889 * term.c (Fsuspend_tty, Fresume_tty):
1890 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1891 * window.c (temp_output_buffer_show):
1892 * insdel.c (signal_before_change):
1893 * frame.c (Fhandle_switch_frame):
1894 * fileio.c (Fdo_auto_save):
1895 * emacs.c (Fkill_emacs):
1896 * editfns.c (save_excursion_restore):
1897 * cmds.c (internal_self_insert):
1898 * callint.c (Fcall_interactively):
1899 * buffer.c (Fkill_all_local_variables):
1900 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1901 Use Frun_hooks.
0f4a96b5 1902 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1903 unconditionnaly since it does the check itself.
1904
2c520ab5 19052011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1906
c9c49752
PE
1907 Fix more problems found by GCC 4.5.2's static checks.
1908
8abc3f12
PE
1909 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1910 the first time through the loop, since we know p0 < p1 then.
1911 This also avoids a gcc -Wstrict-overflow warning.
1912
a2d26660
PE
1913 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1914 leading to a memory leak, possible in functions like
1915 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1916 of objects (Bug#8318).
a2d26660 1917
916c72e9
PE
1918 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1919 that could (at least in theory) be that large.
1920
19ab8a18
PE
1921 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1922 This is less likely to overflow, and avoids undefined behavior if
1923 overflow does occur. All callers changed. Use strtoul to scan
1924 for the unsigned long integer.
b7cbbd6f
PE
1925 (pint2hrstr): Simplify and tune code slightly.
1926 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1927
f0641eff
PE
1928 * scroll.c (do_scrolling): Work around GCC bug 48228.
1929 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1930
7f650bb9
PE
1931 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1932 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1933 (validate_x_resource_name): Simplify count usage.
1934 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1935
37dd57d1
PE
1936 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1937 fail (Bug#8306).
81e56e61 1938
699979fc 1939 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1940
401bf9b4
PE
1941 * process.c (Fmake_network_process): Use socklen_t, not int,
1942 where POSIX says socklen_t is required in portable programs.
1943 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1944 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1945 (Fmake_network_process, server_accept_connection):
1946 (wait_reading_process_output, read_process_output):
1947 Likewise.
1948
b93aacde
PE
1949 * process.c: Rename or move locals to avoid shadowing.
1950 (list_processes_1, Fmake_network_process):
1951 (read_process_output_error_handler, exec_sentinel_error_handler):
1952 Rename or move locals.
4dc343ee 1953 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1954 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1955 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1956 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1957 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1958
af8a867c 1959 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1960 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1961 Include tparam.h instead, since it declares them.
af8a867c
PE
1962 * cm.h (PC): Remove extern decl; tparam.h now does this.
1963 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1964 * terminfo.c: Include tparam.h, to check interfaces.
1965 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1966 (tparam): Adjust signature to match interface in tparam.h;
1967 this removes some undefined behavior. Check that outstring and len
1968 are zero, which they always are with Emacs.
1969 * tparam.h (PC, BC, UP): New extern decls.
1970
0248044d 1971 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1972 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1973
8ff096c1 1974 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1975 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1976 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1977 (ftfont_list): Remove unused local.
49eaafba
PE
1978 (get_adstyle_property, ftfont_pattern_entity):
1979 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1980 Rename locals to avoid shadowing.
8ff096c1 1981
e2be39f6
PE
1982 * xfont.c (xfont_list_family): Mark var as initialized.
1983
c9735e30
PE
1984 * xml.c (make_dom): Now static.
1985
8f5201ae
PE
1986 * composite.c (composition_compute_stop_pos): Rename local to
1987 avoid shadowing.
b246f932
PE
1988 (composition_reseat_it): Remove unused locals.
1989 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1990 (composition_update_it): Mark var as initialized.
11b61122
PE
1991 (find_automatic_composition): Mark vars as initialized,
1992 with a FIXME (Bug#8290).
8f5201ae 1993
760fbc2c
PE
1994 character.h: Rename locals to avoid shadowing.
1995 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1996 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1997 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1998 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1999 to avoid shadowing.
2000
ff08eb85
PE
2001 * textprop.c (property_change_between_p): Remove; unused.
2002
fc7bf025
PE
2003 * intervals.c (interval_start_pos): Now static.
2004
235d7abc
PE
2005 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2006
44f230aa
SM
2007 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2008 Rename locals to avoid shadowing.
3e7d6594 2009
50060332
PE
2010 * sound.c (wav_play, au_play, Fplay_sound_internal):
2011 Fix pointer signedness.
d01f234b 2012 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2013 (wav_play): Initialize a variable to 0, to prevent undefined
2014 behavior (Bug#8278).
50060332 2015
c4fc4e30
PE
2016 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2017
918436ed
PE
2018 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2019
c939f91b
PE
2020 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2021 clobbering (Bug#8298).
b9c7f648
PE
2022 * sysdep.c (sys_subshell): Likewise.
2023 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2024
6bd8c144
PE
2025 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2026 This should get cleaned up, so that child_setup has the
2027 same signature on all platforms.
2028
7710357c 2029 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2030 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2031
c59da222
CY
20322011-03-22 Chong Yidong <cyd@stupidchicken.com>
2033
2034 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2035 not to be necessary, and produces flickering.
2036
66b87493
GM
20372011-03-20 Glenn Morris <rgm@gnu.org>
2038
2039 * config.in: Remove file.
2040
45b6f6d5
JB
20412011-03-20 Juanma Barranquero <lekktu@gmail.com>
2042
2043 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2044 are now in src/globals.h.
2045 (syms_of_minibuf): Remove spurious & from previous change.
2046
3ec03f7e
LL
20472011-03-20 Leo <sdl.web@gmail.com>
2048
2049 * minibuf.c (completing-read-function): New variable.
2050 (completing-read-default): Rename from completing-read.
2051 (completing-read): Call completing-read-function.
2052
b14e3e21
CY
20532011-03-19 Juanma Barranquero <lekktu@gmail.com>
2054
2055 * xfaces.c (Fx_load_color_file):
2056 Read color file from absolute filename (bug#8250).
2057
f2b726e6
JB
20582011-03-19 Juanma Barranquero <lekktu@gmail.com>
2059
2060 * makefile.w32-in: Update dependencies.
2061
09f6ff02
EZ
20622011-03-17 Eli Zaretskii <eliz@gnu.org>
2063
2064 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2065
29a6015a
PE
20662011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2067
a3a6c54e
PE
2068 Fix more problems found by GCC 4.5.2's static checks.
2069
b766f867
PE
2070 * process.c (make_serial_process_unwind, send_process_trap):
2071 (sigchld_handler): Now static.
2072
be02381c
PE
2073 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2074 That way, the code declares only the vars that it needs.
2075 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2076 * s/cygwin.h (PTY_ITERATION): Likewise.
2077 * s/darwin.h (PTY_ITERATION): Likewise.
2078 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2079
57048744
PE
2080 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2081 * process.c (allocate_pty): Don't declare stb unless it's needed.
2082
7914961c 2083 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2084 (CONSTANTLIM): Remove; unused.
2085 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2086 Define only if needed.
7914961c 2087
b3967b18
PE
2088 * unexelf.c (unexec): Name an expression,
2089 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2090 Use a different way to cause a compilation error if anyone uses
2091 n rather than nn, a way that does not involve shadowing.
73366a00 2092 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2093
29a6015a
PE
2094 * deps.mk (unexalpha.o): Remove; unused.
2095
43cfc33e 2096 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2097 * unexec.h: New file.
ce701a33
PE
2098 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2099 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2100 Depend on unexec.h.
2101 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2102 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2103 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2104 Change as necessary to match prototype in unexec.h.
ce701a33 2105
01f44d5a
PE
2106 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2107 shadowing.
4f63c6bb 2108 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2109
a6670b0b
PE
2110 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2111 Rename locals to avoid shadowing.
2112
cef2010d 2113 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2114 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2115
d4d7173a
PE
2116 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2117
f08b802a
PE
2118 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2119 warning when compiling print.c.
2120
3ddb0639
PE
2121 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2122 instead of using an uninitialized var.
5ad03b97 2123 (font_sort_entities): Mark var as initialized.
3ddb0639 2124
170a2692
PE
2125 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2126
e663c700
PE
2127 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2128 pointers to constants.
89bc529a 2129 (font_parse_fcname): Remove unused vars.
7b81e2d0 2130 (font_delete_unmatched): Now static.
ea838e10 2131 (font_get_spec): Remove; unused.
13a547c6
PE
2132 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2133 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2134 Rename or move locals to avoid shadowing.
e663c700 2135
2a80c887 2136 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2137 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2138
1384fa33 2139 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2140 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2141
8b2c52e9
PE
2142 * alloc.c (mark_backtrace): Move decl from here ...
2143 * lisp.h: ... to here, so that it can be checked.
2144
475545b5 2145 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2146 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2147 (lisp_indirect_variable): Name an expression,
2148 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2149 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2150
b1349114 2151 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2152 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2153 Use const pointer when appropriate.
b1349114 2154
a2928364
PE
2155 * lisp.h (get_system_name, get_operating_system_release):
2156 Move decls here, to check interfaces.
2157 * process.c (get_operating_system_release): Move decl to lisp.h.
2158 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2159 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2160 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2161 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2162 (Fformat_time_string, Fencode_time, Finsert_char):
2163 (Ftranslate_region_internal, Fformat):
2164 Rename or remove local vars to avoid shadowing.
9710023e 2165 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2166
a415e694
PE
2167 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2168 avoid shadowing.
2169
8ef4622d
PE
2170 * lisp.h (eassert): Check that the argument compiles, even if
2171 ENABLE_CHECKING is not defined.
2172
946f9a5b
PE
2173 * data.c (Findirect_variable): Name an expression, to avoid
2174 gcc -Wbad-function-cast warning.
112396d6 2175 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2176 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2177 (Fmake_variable_buffer_local, Fmake_local_variable):
2178 Mark variables as initialized.
52746918 2179 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2180
e5aab7e7 2181 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2182 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2183 Rename locals to avoid shadowing.
dff45157
PE
2184 (mark_stack): Move local variables into the #ifdef region where
2185 they're used.
7bc26fdb
PE
2186 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2187 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2188 needed otherwise.
2189 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2190 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2191 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2192
e5aab7e7
PE
2193 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2194 avoids undefined behavior in theory.
2195
4da60324
PE
2196 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2197
88043301
PE
2198 Use functions, not macros, for up- and down-casing (Bug#8254).
2199 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2200 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2201 to use the following functions instead of these macros.
2202 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2203 EMACS_INT, since callers assume the returned value fits in int.
2204 (upcase1): Likewise, for UPCASE_TABLE.
2205 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2206 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2207 the race-condition problem in the old DOWNCASE.
88043301 2208
19ed5445
PE
2209 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2210 Rename locals to avoid shadowing.
2211 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2212 (regex_compile, re_search_2, re_match_2_internal):
2213 Remove unused local vars.
952db0d7
PE
2214 (FREE_VAR): Rewrite so as not to use empty "else",
2215 which gcc can warn about.
da053e48 2216 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2217 (RETALLOC_IF): Define only if needed.
2218 (WORDCHAR_P): Likewise. This one is never needed, but is used
2219 only in a comment talking about a compiler bug, so put inside
2220 the #if 0 of that comment.
2221 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2222 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2223 Remove; unused.
19ed5445 2224
1f3561e4 2225 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2226 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2227 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2228
ded6f8f7
PE
2229 * search.c (simple_search): Remove unused var.
2230
dbd37a95
PE
2231 * dired.c (compile_pattern): Move decl from here ...
2232 * lisp.h: ... to here, so that it can be checked.
2233 (struct re_registers): New forward decl.
2234
7e47afad
PE
2235 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2236
85f24f61
PE
2237 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2238 All uses changed.
2239 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2240 Rename locals to avoid shadowing.
5671df8f 2241 (Fvertical_motion): Mark locals as initialized.
85f24f61 2242
181aa2be 2243 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2244 (casify_region): Mark local as initialized.
181aa2be 2245
930d429c
PE
2246 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2247
7082eac6
PE
2248 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2249 New macros, so that the caller can use some names other than
2250 gcpro1, gcpro2, etc.
2251 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2252 of the new macros.
2253 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2254 argument, for consistency with GCPRO2_VAR, etc: it is now the
2255 prefix of the variable, not the variable itself. All uses
2256 changed.
38b2c076
PE
2257 * dired.c (directory_files_internal, file_name_completion):
2258 Rename locals to avoid shadowing.
2259
15206ed9
PE
2260 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2261 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2262 dired.c's scmp function, had undefined behavior.
2263 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2264 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2265 * buffer.h: ... to here, because these macros use current_buffer,
2266 and the new implementation with inline functions needs to have
2267 current_buffer in scope now, rather than later when the macros
2268 are used.
2269 (downcase, upcase1): New static inline functions.
2270 (DOWNCASE, UPCASE1): Reimplement using these functions.
2271 This avoids undefined behavior in expressions like
2272 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2273 from race conditions in accessing the global variables
2274 case_temp1 and case_temp2.
2275 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2276 * lisp.h (case_temp1, case_temp2): Remove their decls.
2277 * character.h (ASCII_CHAR_P): Move from here ...
2278 * lisp.h: ... to here, so that the inline functions mentioned
2279 above can use them.
2280
4a6bea26
PE
2281 * dired.c (directory_files_internal_unwind): Now static.
2282
f14b7e14
PE
2283 * fileio.c (file_name_as_directory, directory_file_name):
2284 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2285 Now static.
2893f146
PE
2286 (file_name_as_directory): Use const pointers when appropriate.
2287 (Fexpand_file_name): Likewise. In particular, newdir might
2288 point at constant storage, so make it a const pointer.
fd4ead52 2289 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2290 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2291 signedness issues.
f839df0c
PE
2292 (Fset_file_times, Finsert_file_contents, auto_save_error):
2293 Rename locals to avoid shadowing.
f14b7e14 2294
5716756e 2295 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2296 (Ftry_completion, Fall_completions): Rename or remove locals
2297 to avoid shadowing.
5716756e 2298
b4c3046a
PE
2299 * marker.c (bytepos_to_charpos): Remove; unused.
2300
b45db522
PE
2301 * lisp.h (verify_bytepos, count_markers): New decls,
2302 so that gcc does not warn that these functions aren't declared.
2303
85876d07
PE
2304 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2305 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2306 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2307 (copy_text): Remove unused local var.
85876d07 2308
03d78a21 2309 * filelock.c (within_one_second): Now static.
b3dd38ab 2310 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2311
5df8f01b
PE
2312 * buffer.c (fix_overlays_before): Mark locals as initialized.
2313 (fix_start_end_in_overlays): Likewise. This function should be
2314 simplified by using pointers-to-pointers, but that's a different
2315 matter.
b1d876f1 2316 (switch_to_buffer_1): Now static.
8f54f30a
PE
2317 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2318 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2319
a70072c9 2320 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2321 Fix pointer signedness issue.
edced198
PE
2322 (sys_subshell): Mark local as volatile if checking for lint,
2323 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2324 (MAXPATHLEN): Define only if needed.
a70072c9 2325
a0977c44
PE
2326 * process.c (serial_open, serial_configure): Move decls from here ...
2327 * systty.h: ... to here, so that they can be checked.
2328
a884fdcc
PE
2329 * fns.c (get_random, seed_random): Move extern decls from here ...
2330 * lisp.h: ... to here, so that they can be checked.
2331
604efe86 2332 * sysdep.c (reset_io): Now static.
b8950c94 2333 (wait_for_termination_signal): Remove; unused.
604efe86 2334
38fc62d9
PE
2335 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2336 (copy_keymap_item, append_key, push_text_char_description):
2337 Now static.
1004a21a 2338 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2339 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2340 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2341 (describe_map_tree):
2342 Rename locals to avoid shadowing.
38fc62d9 2343
2f2650da
PE
2344 * keyboard.c: Declare functions static if they are not used elsewhere.
2345 (echo_char, echo_dash, cmd_error, top_level_2):
2346 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2347 (read_char, kbd_buffer_get_event, make_lispy_position):
2348 (make_lispy_event, make_lispy_movement, apply_modifiers):
2349 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2350 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2351 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2352 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2353 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2354
a053e86c 2355 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2356 (mark_kboards): Move decl here ...
2357 * alloc.c (mark_kboards): ... from here.
a053e86c 2358
4752793e
PE
2359 * lisp.h (force_auto_save_soon): New decl.
2360
74f10ca7 2361 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2362 (DEFINE_DUMMY_FUNCTION): New macro.
2363 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2364 Use it.
c03cd23f
PE
2365 (main): Add casts to avoid warnings
2366 if GCC considers string literals to be constants.
74f10ca7 2367
022e70d4
PE
2368 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2369
59d6fe83
PE
2370 * dbusbind.c: Pointer signedness fixes.
2371 (xd_signature, xd_append_arg, xd_initialize):
2372 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2373 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2374 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2375 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2376
78320123
PE
2377 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2378 if GCC considers string literals to be constants.
49cebcca 2379 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2380
35ac2a97
SM
23812011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2382
fb103ca9
SM
2383 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2384 (print_preprocess, print_object): New macro to fix last change.
2385
35ac2a97
SM
2386 * print.c (print_preprocess): Don't forget font objects.
2387
62973b41
JB
23882011-03-16 Juanma Barranquero <lekktu@gmail.com>
2389
2390 * emacs.c (USAGE3): Doc fixes.
2391
0e48bb22
AS
23922011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2393
2394 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2395 structure.
2396
7684e57b
JB
23972011-03-14 Juanma Barranquero <lekktu@gmail.com>
2398
2399 * lisp.h (VWindow_system, Qfile_name_history):
2400 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2401 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2402 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2403
2404 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2405 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2406
2407 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2408 * w32console.c (detect_input_pending, read_input_pending)
2409 (encode_terminal_code):
2410 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2411 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2412 (w32_system_caret_y, Qfile_name_history):
2413 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2414 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2415 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2416 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2417 * w32proc.c (Qlocal, report_file_error):
2418 * w32term.c (Vwindow_system, updating_frame):
2419 * w32uniscribe.c (initialized, uniscribe_font_driver):
2420 Remove unneeded extern declarations.
2421
2aa46d6c
CY
24222011-03-14 Chong Yidong <cyd@stupidchicken.com>
2423
c96bbc66 2424 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2425
cffc6f3b
CY
24262011-03-13 Chong Yidong <cyd@stupidchicken.com>
2427
2428 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2429 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2430 These macros can no longer be used for assignment.
2431
44f230aa
SM
2432 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2433 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2434 (record_buffer_markers, fetch_buffer_markers): New functions for
2435 recording and fetching special buffer markers.
2436 (set_buffer_internal_1, set_buffer_temp): Use them.
2437
2438 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2439
2440 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2441
2442 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2443 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2444
2445 * xdisp.c (hscroll_window_tree):
2446 (reconsider_clip_changes): Use PT instead of BUF_PT.
2447
d251f04b
EZ
24482011-03-13 Eli Zaretskii <eliz@gnu.org>
2449
2450 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2451 $(EMACS_ROOT)/lib/intprops.h.
2452
f0c77cd1
PE
24532011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2454
3eca4629
PE
2455 Fix more problems found by GCC 4.5.2's static checks.
2456
7c86ee98
PE
2457 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2458 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2459 (xg_free_frame_widgets): Make it clear that a local variable is
2460 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2461 (gdk_window_get_screen): Make it clear that this macro is needed
2462 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2463 (int_gtk_range_get_value): New function, which avoids a diagnostic
2464 from gcc -Wbad-function-cast.
2465 (xg_set_toolkit_scroll_bar_thumb): Use it.
2466 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2467 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2468 (get_utf8_string, xg_get_file_with_chooser):
2469 Rename locals to avoid shadowing.
2470 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2471
41729b81
PE
2472 * xgselect.c (xg_select): Remove unused var.
2473
f0c77cd1
PE
2474 * image.c (four_corners_best): Mark locals as initialized.
2475 (gif_load): Initialize transparent_p to zero (Bug#8238).
2476 Mark another local as initialized.
ec6cf4c6 2477 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2478
ce0ad53d 2479 * image.c (clear_image_cache): Now static.
d5d5a617 2480 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2481 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2482 (x_edge_detection): Remove unnecessary cast that
2483 gcc -Wbad-function-cast diagnoses.
2037898d 2484 (gif_load): Fix pointer signedness.
6ae141d6
PE
2485 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2486 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2487
33383987 24882011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2489
d32df629
PE
2490 Improve quality of tests for time stamp overflow.
2491 For example, without this patch (encode-time 0 0 0 1 1
2492 1152921504606846976) returns the obviously-bogus value (-948597
2493 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2494 reports time overflow. See
2495 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2496 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2497 * editfns.c: Include limits.h and intprops.h.
2498 (TIME_T_MIN, TIME_T_MAX): New macros.
2499 (time_overflow): Move earlier, to before first use.
2500 (hi_time, lo_time): New functions, for an accurate test for
2501 out-of-range times.
2502 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2503 (Fget_internal_run_time): Don't assume time_t fits in int.
2504 (make_time): Use list2 instead of Fcons twice.
2505 (Fdecode_time): More accurate test for out-of-range times.
2506 (check_tm_member): New function.
2507 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2508 (lisp_time_argument): Don't rely on undefined left-shift and
2509 right-shift behavior when checking for time stamp overflow.
8be6f318 2510
fe31d94c
PE
2511 * editfns.c (time_overflow): New function, refactoring common code.
2512 (Fformat_time_string, Fdecode_time, Fencode_time):
2513 (Fcurrent_time_string): Use it.
2514
8be6f318
PE
2515 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2516 * dired.c (make_time): Move to ...
2517 * editfns.c (make_time): ... here.
2518 * systime.h: Note the move.
2519
09d9db2c 25202011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2521
126bc0dc
YM
2522 * fringe.c (update_window_fringes): Remove unused variables.
2523
c47cbdfd
YM
2524 * unexmacosx.c (copy_data_segment): Also copy __got section.
2525 (Bug#8223)
2526
7ac80be9
EZ
25272011-03-12 Eli Zaretskii <eliz@gnu.org>
2528
c96bbc66 2529 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2530 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2531 Constify `char *' arguments and their references according to
2532 prototypes in tparam.h.
2533
ecb0f94d 2534 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2535
7ac80be9
EZ
2536 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2537 Adapt all references accordingly.
2538
2539 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2540
ef1fd07e
TT
25412011-03-11 Tom Tromey <tromey@redhat.com>
2542
2543 * buffer.c (syms_of_buffer): Remove obsolete comment.
2544
7ef4b50c
EZ
25452011-03-11 Eli Zaretskii <eliz@gnu.org>
2546
2547 * termhooks.h (encode_terminal_code): Declare prototype.
2548
2549 * msdos.c (encode_terminal_code): Don't declare prototype.
2550
2551 * term.c (encode_terminal_code): Now external again, used by
2552 w32console.c and msdos.c.
2553
44f230aa
SM
2554 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2555 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2556
4b1ec863 25572011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2558
1714f52b 2559 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2560
4b1ec863
PE
2561 * fringe.c (update_window_fringes): Mark locals as initialized
2562 (Bug#8227).
2563 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2564
524c7aa6
PE
2565 * alloc.c (mark_fringe_data): Move decl from here ...
2566 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2567 to check its interface.
2568 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2569
a5c0af81 2570 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2571 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2572 (fontset_font): Mark local as initialized.
a9a06e0b 2573 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2574
b4716021
PE
2575 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2576
811e9bac 2577 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2578 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2579 (x_own_selection, Fx_disown_selection_internal): Rename locals
2580 to avoid shadowing.
2581 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2582
7e3ab302
PE
2583 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2584 so that the caller can use some name other than gcpro1.
2585 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2586 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2587 (Fx_backspace_delete_keys_p):
2588 Use them to avoid shadowing, and rename vars to avoid shadowing.
2589 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2590 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2591 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2592 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2593 Remove unused locals.
7e3ab302
PE
2594 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2595 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2596 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2597 macros.
f78faa98 2598
e2b13473
PE
2599 * xterm.h (x_mouse_leave): New decl.
2600
77f23912
PE
2601 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2602 Remove unused functions.
cdf4ba58
PE
2603 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2604 (x_calc_absolute_position): Now static.
7411c686 2605 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2606 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2607 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2608 unless they are used.
38d0b34a
PE
2609 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2610 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2611 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2612 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2613 (x_error_catcher, x_connection_closed, x_error_handler):
2614 (x_error_quitter, xembed_send_message, x_iconify_frame):
2615 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2616 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2617 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2618
44f230aa
SM
2619 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2620 Rename or move locals to avoid shadowing.
6b463e58 2621 (tty_defined_color, merge_face_heights): Now static.
5967d051 2622 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2623 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2624 does not deduce is never used uninitialized.
73719eba
PE
2625 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2626 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2627
426994c3 2628 * terminal.c (store_terminal_param): Now static.
5489860b 2629
032f1620 2630 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2631 (set_frame_menubar): Remove unused local.
d4323972 2632 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2633 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2634 since they might point to immutable storage.
281585b0
PE
2635 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2636 since it's unused otherwise.
032f1620 2637
367c19e5 2638 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2639 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2640 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2641 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2642 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2643 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2644 does not deduce are never used uninitialized.
70739cbe 2645
07b48fa9
PE
2646 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2647
8868a238 2648 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2649 * window.c (window_loop, size_window):
2650 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2651
7e5cf297 2652 * window.c (display_buffer): Now static.
d6550a9f
PE
2653 (size_window): Mark variables that gcc -Wuninitialized
2654 does not deduce are never used uninitialized.
a586633d
PE
2655 * window.h (check_all_windows): New decl, to forestall
2656 gcc -Wmissing-prototypes diagnostic.
5b555da1 2657 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2658
f6095868
PE
2659 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2660 shadowing.
2661 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2662 Include <limits.h>.
2663 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2664 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2665 (load_charset_map): Mark variables that gcc -Wuninitialized
2666 does not deduce are never used uninitialized.
53df7c11 2667 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2668
f38b440c
PE
2669 * coding.c (coding_set_source, coding_set_destination):
2670 Use "else { /* comment */ }" rather than "else /* comment */;"
2671 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2672 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2673 a block, when the outer 'i' will do.
2674 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2675 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2676 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2677 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2678 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2679 Rename locals to avoid shadowing.
2680 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2681 * coding.c (emacs_mule_char, encode_invocation_designation):
2682 Now static, since they're not used elsewhere.
413bb2db 2683 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2684 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2685 (decode_coding_emacs_mule): Mark variables that gcc
2686 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2687 (detect_coding_iso_2022): Initialize a local variable that might
2688 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2689 this initialization is needed. (Bug#8211)
5f58e762
PE
2690 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2691 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2692 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2693 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2694 Remove unused macros.
f38b440c 2695
232b38b9 2696 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2697 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2698 * character.c (string_count_byte8): Likewise.
232b38b9 2699
fb90da1b
PE
2700 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2701 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2702
fb93dbc2
PE
2703 * chartab.c (copy_sub_char_table): Now static, since it's not used
2704 elsewhere.
5c156ace
PE
2705 (sub_char_table_ref_and_range, char_table_ref_and_range):
2706 Rename locals to avoid shadowing.
bbcd0949 2707 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2708
7d3b3862 2709 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2710 (BIDI_BOB): Remove unused macro.
7d3b3862 2711
6be7d3da
PE
2712 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2713 deduce are never used uninitialized.
c2ed9c8b 2714 * term.c (encode_terminal_code): Likewise.
6be7d3da 2715
75f8807f 2716 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2717
50938595
PE
2718 * tparam.h: New file.
2719 * term.c, tparam.h: Include it.
2720 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2721 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2722 Move these decls to tparam.h, and make them agree with what
2723 is actually in tparam.c. The previous trick of using incompatible
2724 decls in different modules does not conform to the C standard.
2725 All callers of tparam changed to use tparam's actual API.
2726 * tparam.c (tparam1, tparam, tgoto):
2727 Use const pointers where appropriate.
2728
fbceeba2
PE
2729 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2730 * cm.h (struct cm): Likewise.
2731 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2732 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2733 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2734 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2735 (turn_on_face, init_tty): Likewise.
2736 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2737
7f3f1250
PE
2738 * term.c (term_mouse_position): Rename local to avoid shadowing.
2739
e6ca6543
PE
2740 * alloc.c (mark_ttys): Move decl from here ...
2741 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2742
c40f8d15
AS
27432011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2744
2745 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2746
cfe0661d
JB
27472011-03-09 Juanma Barranquero <lekktu@gmail.com>
2748
2749 * search.c (compile_pattern_1): Remove argument regp, unused since
2750 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2751 (compile_pattern): Don't pass it.
2752
0afb4571
J
27532011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2754
2755 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2756 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2757 for ! HAVE_GTK3.
2758 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2759
2760 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2761
2762 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2763 gdk_window_get_screen, gdk_window_get_geometry,
2764 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2765 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2766 (xg_get_pixbuf_from_pixmap): New function.
2767 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2768 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2769 Call xg_get_pixbuf_from_pixmap instead of
2770 gdk_pixbuf_get_from_drawable.
2771 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2772 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2773 (xg_check_special_colors): Use GtkStyleContext and its functions
2774 for HAVE_GTK3.
2775 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2776 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2777 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2778 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2779 Call gtk_widget_get_preferred_size.
0afb4571
J
2780 (xg_frame_resized): gdk_window_get_geometry only takes 5
2781 parameters.
44f230aa
SM
2782 (xg_win_to_widget, xg_event_is_for_menubar):
2783 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2784 (xg_set_widget_bg): New function.
2785 (delete_cb): New function.
895009e1 2786 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
2787 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2788 (xg_set_background_color): Call xg_set_widget_bg.
2789 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2790 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2791 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2792 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2793 if ! HAVE_GTK3.
2794 (update_frame_tool_bar): Call gtk_widget_hide.
2795 (xg_initialize): Use GDK_KEY_g.
2796
2797 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2798 if ! HAVE_GTK3
2799 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2800
2801 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2802 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2803 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2804
1c2cc4ef
JB
28052011-03-08 Juanma Barranquero <lekktu@gmail.com>
2806
2807 * w32xfns.c (select_palette): Check success of RealizePalette against
2808 GDI_ERROR, not zero.
2809
33383987 2810See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2811
2812;; Local Variables:
2813;; coding: utf-8
aac0c6e3
MR
2814;; End:
2815
33383987 2816 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2817
2818 This file is part of GNU Emacs.
2819
2820 GNU Emacs is free software: you can redistribute it and/or modify
2821 it under the terms of the GNU General Public License as published by
2822 the Free Software Foundation, either version 3 of the License, or
2823 (at your option) any later version.
2824
2825 GNU Emacs is distributed in the hope that it will be useful,
2826 but WITHOUT ANY WARRANTY; without even the implied warranty of
2827 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2828 GNU General Public License for more details.
2829
2830 You should have received a copy of the GNU General Public License
2831 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.