Doc fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
55802e4a
CY
12012-08-14 Chong Yidong <cyd@gnu.org>
2
3 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
4
5 * editfns.c (Fformat): Doc fix (Bug#12059).
6
8e99d072
BR
72012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
8
9 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
10 (bug#12022).
11
08908aca
MR
122012-08-14 Martin Rudalics <rudalics@gmx.at>
13
14 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
15 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
16 * minibuf.c (choose_minibuf_frame, read_minibuf):
17 * w32fns.c (x_create_tip_frame):
18 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
19 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
20
56120d6f
PE
212012-08-14 Paul Eggert <eggert@cs.ucla.edu>
22
23 * intervals.c (offset_intervals): Remove obsolete comment.
24
67b77c0b
AS
252012-08-14 Andreas Schwab <schwab@linux-m68k.org>
26
27 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
28
f48b82fd
GR
292012-08-14 Gergely Risko <gergely@risko.hu>
30
31 * coding.c (decode_coding): Record buffer modification before
32 disabling undo_list (Bug#11773).
33
fd318b54
DA
342012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
35
36 Revert and cleanup some recent overlay changes.
37 * buffer.h (enum overlay_type): Remove.
38 (buffer_get_overlays, buffer_set_overlays): Likewise.
39 (buffer_set_overlays_before, buffer_set_overlays_after):
40 New function. Adjust users.
41 (unchain_both): Add eassert.
42
41a62dd9
DA
432012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
44
45 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
46
5884c324
PE
472012-08-14 Paul Eggert <eggert@cs.ucla.edu>
48
49 * gtkutil.c (xg_mark_data): Don't assume C99.
50
ca06f160
JD
512012-08-13 Jan Djärv <jan.h.d@swipnet.se>
52
53 * gtkutil.c (xg_frame_tb_info): New struct.
54 (TB_INFO_KEY): New define.
55 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
56 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
57 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
58 if not present.
59 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
60 is up to date. Otherwise store new data.
61 (free_frame_tool_bar): Free xg_frame_tb_info if present.
62
7864a3f7
DA
632012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
64
65 Use KSET for write access to Lisp_Object members of struct kboard.
66 * keyboard.h (KSET): New macro.
67 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
68 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
69 * xterm.c: Adjust users.
70
4c31be61
DA
712012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
72
73 Use BSET for write access to Lisp_Object members of struct buffer.
74 * buffer.h (BSET): New macro.
75 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
76 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
77 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
78 * window.c, xdisp.c, xfns.c: Adjust users.
79
14ae4239
BT
802012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
81
82 * lread.c (syms_of_lread): Initialize Vlexical_binding.
83
32bcadb4
JD
842012-08-11 Jan Djärv <jan.h.d@swipnet.se>
85
3d29b2ce
JD
86 * nsterm.m (not_in_argv): New function.
87 (application:openFile, application:openTempFile:):
88 (application:openFileWithoutUI:, application:openFiles:): Open file
89 if not_in_argv returns non-zero (bug#12171).
90
32bcadb4 91 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
92 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
93 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
94 (xg_get_font_name): Use those functions/macros here.
95 Reported by Frans Oilinki <moilinki@gmail.com>.
96
9ff9402d 972012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
98
99 * unexmacosx.c (copy_data_segment): Copy initialized data in
100 statically linked libraries from input file rather than memory.
101
db74a5fc
YM
102 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
103 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
104 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
105
25e65510
GM
1062012-08-10 Glenn Morris <rgm@gnu.org>
107
108 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
109 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
110
7961135c
DA
1112012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
112
113 Fix last change to allow compilation with low optimization levels.
114 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
115 Reported by Jan Djärv <jan.h.d@swipnet.se>.
116
42b3a444
DA
1172012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
118
119 Use common inline syntax in intervals.h.
120 * intervals.h (INTERVALS_INLINE): New macro.
121 Change all users from LISP_INLINE.
122
9fb0c957
DA
1232012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
124
125 Define Qnone once for all platforms.
126 * frame.c (Qnone): Define here.
127 (syms_of_frame): DEFSYM it.
128 * lisp.h (Qnone): New declaration.
129 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
130 * xfns.c: Remove duplication. Adjust users.
131
65e8ee52
DA
1322012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
133
134 Remove unused macros from intervals.h.
135 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
136 * intervals.c: Adjust comment.
137
9b855fd6
EZ
1382012-08-10 Eli Zaretskii <eliz@gnu.org>
139
140 * w32fns.c <w32_unicode_gui>: New static variable.
141 (globals_of_w32fns): Initialize it according to os_subtype.
142 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
143 testing os_subtype.
144
39cb9e56 1452012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
146 Eli Zaretskii <eliz@gnu.org>
147
148 Fix bug #10299 with Unicode characters sent by customized
149 keyboards created by MSKLC.
150 * w32fns.c (INIT_WINDOW_CLASS): New macro.
151 (w32_init_class): Use it to initialize the Emacs class with either
152 ANSI or Unicode API calls.
153 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
154 later.
155 (w32_wnd_proc): If the character code sent by WM_CHAR or
156 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
157 original message. Call DefWindowProcW on NT and later.
158
9374581a
GM
1592012-08-10 Glenn Morris <rgm@gnu.org>
160
4b94e8cf
GM
161 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
162
9374581a
GM
163 * lisp.h (DIRECTORY_SEP): Let configure set it.
164
a2752828
DA
1652012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
166
167 Use TSET for write access to Lisp_Object slots of struct terminal.
168 * termhooks.h (TSET): New macro.
169 * coding.c, terminal.c, xselect.c: Adjust users.
170
cc92c454
SM
1712012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
172
173 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
174 the failing expression, include them in the error message.
175 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
176 * lisp.h (internal_condition_case_n): Update declaration.
177
4cb3e6b3
DA
1782012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
179
180 Inline functions to examine and change buffer overlays.
181 * buffer.c (unchain_both): New function.
182 * buffer.h (buffer_get_overlays, buffer_set_overlays):
183 (buffer_has_overlays): New function.
184 (enum overlay_type): New enum.
185 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
186 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
187
8707c1e5
DA
1882012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
189
190 Inline functions to examine and change buffer intervals.
191 * alloc.c (mark_interval_tree): Remove.
192 (MARK_INTERVAL_TREE): Simplify.
193 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
194 * intervals.c (buffer_balance_intervals): New function.
195 (graft_intervals_into_buffer): Adjust indentation.
196 (set_intervals_multibyte): Simplify.
197 * buffer.h (BUF_INTERVALS): Remove.
198 (buffer_get_intervals, buffer_set_intervals): New function.
199 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
200 * intervals.c, textprop.c: Adjust users.
201
ad8c997f
DA
2022012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
203
204 Inline functions to examine and change string intervals.
205 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
206 (string_get_intervals, string_set_intervals): New function.
207 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
208 * lread.c, print.c, textprop.c: Adjust users.
209
32ac3a6b
GM
2102012-08-08 Glenn Morris <rgm@gnu.org>
211
212 * lisp.mk (lisp): Remove language/persian.elc.
213
77c7bcb1
DA
2142012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
215
216 Cleanup intervals.
217 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
218 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
219 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
220 Adjust comment. Move under #if 0.
77c7bcb1
DA
221 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
222 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
223
9c08a8d4
DA
2242012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
225
226 Check total length of intervals with eassert.
227 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
228 * intervals.c: Change all users to eassert.
229
26d16b35
EZ
2302012-08-07 Eli Zaretskii <eliz@gnu.org>
231
14ae4239
BT
232 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
233 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
234 INTERNAL_FIELD in Lisp_Cons.
235
c644523b
DA
2362012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
237
238 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
239 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
240 name since all xname users are fixed long time ago. Do not
241 use INTERNAL_FIELD.
242 (set_symbol_name, set_symbol_function, set_symbol_plist):
243 (set_symbol_next, set_overlay_plist): New function.
244 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
245 (struct Lisp_Overlay): Likewise.
246 (CVAR, MVAR, SVAR): Remove.
247 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
248 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
249 * xterm.c: Adjust users.
250 * .gdbinit: Change to use name field of struct Lisp_Symbol
251 where appropriate.
252
6a3d20cc
DA
2532012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
254
255 Basic functions to set Lisp_Object and pointer slots of intervals.
256 * intervals.h (interval_set_parent, interval_set_object):
257 (interval_set_left, interval_set_right, interval_set_plist):
258 (interval_copy_parent): New function.
259 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
260 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
261 Adjust indentation.
6a3d20cc
DA
262 (INTERVAL_SIZE): Remove. Adjust users.
263 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
264
4d2b044c
DA
2652012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
266
267 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
268 * process.h (PGET): Remove.
269 (struct Lisp_Process): Do not use INTERNAL_FIELD.
270 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
271
d3d50620
DA
2722012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
273
274 Drop WGET and revert read access to Lisp_Objects slots of struct window.
275 * window.h (WGET): Remove.
276 (struct window): Do not use INTERNAL_FIELD.
277 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
278 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
279 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
280 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
281 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
282 Adjust users.
283
d10a51dc
CY
2842012-08-07 Chong Yidong <cyd@gnu.org>
285
286 * window.c (Fwindow_edges, Fwindow_pixel_edges)
287 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
288 (Fdelete_window_internal): Signal an error if the window is not on
289 a live frame (Bug#12025).
290
e69b0960
DA
2912012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
292
293 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
294 * frame.h (FGET): Remove.
295 (struct frame): Do not use INTERNAL_FIELD.
296 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
297 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
298 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
299 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
300
25a20a3a
JB
3012012-08-06 Juanma Barranquero <lekktu@gmail.com>
302
303 * w32.c: Silence compiler warnings.
304 (map_w32_filename): Remove unused variable `is_fat'.
305 (chase_symlinks): Add parentheses around expression.
306
1c6f11f4
GM
3072012-08-06 Glenn Morris <rgm@gnu.org>
308
1db4583a
GM
309 * sysdep.c: Respect BROKEN_GETWD.
310
1c6f11f4
GM
311 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
312 Let configure handle it.
313 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
314
2b90362b
DA
3152012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
316
317 Use GCALIGNMENT where appropriate.
318 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
319 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
320 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
321
5f50daf2
EZ
3222012-08-06 Eli Zaretskii <eliz@gnu.org>
323
14ae4239
BT
324 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
325 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 326
cbcc7007
SM
3272012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
328
329 * buffer.h (struct buffer): Revert `indirections' to a simple int;
330 that should be sufficient for everyone.
331
4d365fa4
JD
3322012-08-06 Jan Djärv <jan.h.d@swipnet.se>
333
334 * keyboard.c (timer_check_2): Add break so timer_check returns next
335 timeout.
336
dd86bd82
DA
3372012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
338
339 Fix Windows build errors introduced after converting to WGET and WSET.
340 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
341 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
342
054e1668
JD
3432012-08-06 Jan Djärv <jan.h.d@swipnet.se>
344
345 * nsterm.m (ns_frame_rehighlight): Use FSET.
346
347 * nsmenu.m (ns_update_menubar): Use FSET.
348
21238f11
DA
3492012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
350
351 Separate read and write access to Lisp_Object slots of Lisp_Process.
352 * process.h (PGET, PSET): New macros similar to AREF and ASET.
353 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
354
077288cf
DA
3552012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
356
357 Separate read and write access to Lisp_Object slots of struct window.
358 * window.h (WGET, WSET): New macros similar to AREF and ASET.
359 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
360 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
361 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
362 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
363 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
364 Adjust users.
365
71688bd7
DA
3662012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
367
368 Fix Windows build errors introduced after converting to FGET and FSET.
369 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
370 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
371 (w32_judge_scroll_bars): Change to use FSET.
372 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
373
f99bac93
DA
3742012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
375
376 Fix replacement typo.
377 * window.c (replace_window): Set root_window instead of
378 selected_window. This fixes a total window subsystem
379 malfunction reported by Bastien Guerry <bzg@gnu.org>.
380
8c2a0f2d
GM
3812012-08-06 Glenn Morris <rgm@gnu.org>
382
383 * lisp.mk (lisp): Add language/persian.elc.
384
edd74c35
DA
3852012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
386
387 Separate read and write access to Lisp_Object slots of struct frame.
388 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
389 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
390 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
391 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
392 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
393
8671676c
AS
3942012-08-05 Andreas Schwab <schwab@linux-m68k.org>
395
396 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
397
663e2b3f
DA
3982012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
399
400 Generalize common compile-time constants.
401 * lisp.h (header_size, bool_header_size, word_size): Now here.
402 (struct Lisp_Vector): Add comment.
403 (struct Lisp_Bool_Vector): Move up to define handy constants.
404 (VECSIZE, PSEUDOVECSIZE): Simplify.
405 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
406 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
407 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
408 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
409 * xfont.c, xmenu.c: Use word_size where appropriate.
410
d32e47af
LM
4112012-08-05 Lawrence Mitchell <wence@gmx.li>
412
413 * search.c (Freplace_match): Treat \? in the replacement text
414 literally (Bug#8161).
415
e5d9c0d1
CY
4162012-08-05 Chong Yidong <cyd@gnu.org>
417
418 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
419 * frame.c (Vdelete_frame_functions):
420 * emacs.c (Vkill_emacs_hook): Doc fix.
421
8da0576b
EZ
4222012-08-04 Eli Zaretskii <eliz@gnu.org>
423
424 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
425 --with-x-toolkit=no builds.
426 Reported by Carsten Mattner <carstenmattner@gmail.com>.
427
02676e5d
CY
4282012-08-04 Chong Yidong <cyd@gnu.org>
429
430 * syntax.c (Fmodify_syntax_entry): Doc fix.
431
97147da9
EZ
4322012-08-04 Eli Zaretskii <eliz@gnu.org>
433
76151e2c
EZ
434 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
435 * w32.c (init_environment): Change the default values of many
436 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
437 them into environment when they were not already defined.
438 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 439 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
440 (check_windows_init_file): Now external, not static.
441 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
442 called when Vload_path is already set up.
443
444 * w32.h (check_windows_init_file): Add prototype.
445
446 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
447 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
448 compatibility with Posix platforms.
449 (main): Move the call to check_windows_init_file to here from
450 w32.c.
451 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
452 any, in the DEFALT argument into the root of the Emacs build or
453 installation tree, as appropriate.
454
455 * callproc.c (init_callproc_1): Call decode_env_path instead of
456 doing its equivalent by hand.
457 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
458 the code that sets Vexec_path run on MS-Windows.
459
460 * lread.c (init_lread): Add comments to #ifdef's.
461
97147da9
EZ
462 * msdos.c (dos_set_window_size, IT_update_begin)
463 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
464 instead of direct references.
465
185ee146
PE
4662012-08-04 Paul Eggert <eggert@cs.ucla.edu>
467
468 Export DEFAULT_REHASH_* to GDB.
469 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
470 Now constants, not macros.
471
8834c57a
PE
4722012-08-03 Paul Eggert <eggert@cs.ucla.edu>
473
98c6f1e3
PE
474 Remove unnecessary casts involving pointers.
475 These casts are no longer needed now that we assume C89 or later,
476 since they involve casting to or from void *.
477 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
478 (make_pure_float, make_pure_vector):
479 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
480 * macros.c (Fstart_kbd_macro):
481 * menu.c (find_and_return_menu_selection):
482 * minibuf.c (read_minibuf_noninteractive):
483 * sysdep.c (closedir):
484 * xdisp.c (x_produce_glyphs):
485 * xfaces.c (compare_fonts_by_sort_order):
486 * xfns.c (x_real_positions, select_visual):
487 * xselect.c (x_stop_queuing_selection_requests)
488 (x_get_window_property, x_get_window_property_as_lisp_data):
489 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
490 Remove unnecessary pointer casts.
491 * alloc.c (record_xmalloc): New function.
492 * lisp.h (record_xmalloc): New decl.
493 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
494 more like a function. This is because the pointer cast is not
495 needed. All uses changed.
496 * print.c (print_string, print_error_message): Avoid length recalc.
497
8834c57a
PE
498 Improve fix for macroexp crash with debugging (Bug#12118).
499 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
500 ARRAY_MARK_FLAG when checking subscripts, because ASET is
501 not supposed to be invoked from the garbage collector.
502 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
503 (gc_aset): New function, which is like ASET but can be
504 used in the garbage collector.
505 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
506 (set_hash_index): Use it instead of ASET.
507
6dad7178
EZ
5082012-08-03 Eli Zaretskii <eliz@gnu.org>
509
510 Support symlinks on latest versions of MS-Windows.
511 * w32.c: Include winioctl.h and aclapi.h.
512 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
513 (revert_to_self): Forward declarations of static functions.
514 <static BOOL g_b_init_get_security_info>:
515 <g_b_init_create_symbolic_link>: New static flags.
516 (globals_of_w32): Initialize them to zero.
517 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
518 (map_w32_filename): Improve commentary. Simplify switch.
519 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
520 headers (most versions of MinGW w32api don't).
521 (get_security_info, create_symbolic_link)
522 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
523 New functions.
524 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
525 in the argument file name.
526 (sys_access): Call unc_volume_file_attributes only if
527 GetFileAttributes fails with network-related error codes.
528 (sys_rename): Diagnose renaming of a symlink when the user doesn't
529 have the required privileges.
14ae4239 530 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
531 get_file_security_desc.
532 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
533 with addition of handling of symlinks and support for 'lstat'.
534 If possible, get file's attributes and security information by
6dad7178
EZ
535 handle, not by name. Produce S_IFLNK bit for symlinks, when
536 called from 'lstat'.
537 (stat, lstat): New functions, call 'stat_worker'.
538 (symlink, readlink, careadlinkat): Rewritten to create and resolve
539 symlinks when the underlying filesystem supports them.
540
f162bcc3
PE
5412012-08-02 Paul Eggert <eggert@cs.ucla.edu>
542
79ea6c20
PE
543 Fix macroexp crash on Windows with debugging (Bug#12118).
544 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
545 checking subscripts; problem introduced with the recent
546 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
547 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
548 since it's used in non-static inline functions now.
549
c0ce93fd
PE
550 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
551 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 552
f162bcc3
PE
553 Use C99-style 'extern inline' if available.
554 * buffer.h (BUFFER_INLINE):
555 * category.h (CATEGORY_INLINE):
556 * character.h (CHARACTER_INLINE):
557 * charset.h (CHARSET_INLINE):
558 * composite.h (COMPOSITE_INLINE):
559 * dispextern.h (DISPEXTERN_INLINE):
560 * lisp.h (LISP_INLINE):
561 * systime.h (SYSTIME_INLINE):
562 New macro, replacing 'static inline' in this header.
563 * buffer.h, category.h, character.h, charset.h, composite.h:
564 * dispextern.h, lisp.h, systime.h:
565 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
566 * alloc.c (LISP_INLINE):
567 * buffer.c (BUFFER_INLINE):
568 * category.c (CATEGORY_INLINE):
569 * character.c (CHARACTER_INLINE):
570 * charset.c (CHARSET_INLINE):
571 * composite.c (COMPOSITE_INLINE):
572 * dispnew.c (DISPEXTERN_INLINE):
573 * sysdep.c (SYSTIME_INLINE):
574 Define to EXTERN_INLINE, so that the corresponding functions
575 are compiled into code.
576 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
577 (INLINE_HEADER_END): New macros.
578 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
579 since it's used in non-static inline functions now.
a8333d03 580 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 581
837b365b
GM
5822012-08-02 Glenn Morris <rgm@gnu.org>
583
d66b744d
GM
584 * s/: Remove empty directory.
585
837b365b
GM
586 * s/ms-w32.h: Move to ../nt/inc.
587 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
588 Update for new ms-w32.h location.
589
13294f95
PE
5902012-08-02 Paul Eggert <eggert@cs.ucla.edu>
591
592 Port to Solaris 8.
593 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
594
90df0db3
GM
5952012-08-02 Glenn Morris <rgm@gnu.org>
596
597 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
598 hard-coding the path separator.
599
4939150c
PE
6002012-08-01 Paul Eggert <eggert@cs.ucla.edu>
601
602 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
603 This how ASET and AREF are supposed to work, and makes
604 it easier to think about future improvements. See
605 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
606 * charset.h (set_charset_attr): New function.
607 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
608 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
609 (aref_addr): New function. All uses of &AREF(...) changed.
610 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
611 (set_hash_index): New functions. All lvalue-style uses of
612 HASH_KEY etc. changed.
613 * keyboard.c (set_prop): New function. All lvalue-style uses
614 of PROP changed.
615
947b2afd
AA
6162012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
617
618 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
619 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
620 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
621 * nsfns.m (ns_set_name_as_filename): Likewise.
622 * nsmenu.m (ns_update_menubar): Likewise.
623 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
624
4f5d0325
EZ
6252012-08-01 Eli Zaretskii <eliz@gnu.org>
626
2008beae
EZ
627 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
628 Adapt to latest changes in field names of the corresponding Lisp
288479f6 629 objects.
2008beae 630
4f5d0325
EZ
631 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
632
fe3cc771
GM
6332012-08-01 Glenn Morris <rgm@gnu.org>
634
635 * s/msdos.h: Remove file.
636 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
637 * Makefile.in (S_FILE): Remove.
638 (config_h): Remove S_FILE.
639
c90acc54
JB
6402012-08-01 Juanma Barranquero <lekktu@gmail.com>
641
642 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
643 Remove; moved to nt/config.nt.
644
d8a05828
DA
6452012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
646
647 Use INTERNAL_FIELD for conses and overlays.
648 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
649 Remove obsolete comment.
650 (MVAR): New macro.
651 (struct Lisp_Overlay): Use INTERNAL_FIELD.
652 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
653
8271d590
DA
6542012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
655
656 Use INTERNAL_FIELD for symbols.
657 * lisp.h (SVAR): New macro. Adjust users.
658 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
659 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
660
3193acd2
DA
6612012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
662
663 Use INTERNAL_FIELD for processes.
664 * process.h (PVAR): New macro. Adjust style.
665 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
666 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
667
3a45383a
DA
6682012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
669
670 Use INTERNAL_FIELD for windows.
671 * window.h (WVAR): New macro.
672 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
673 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
674 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
675 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
676 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
677 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
678
c1dbc63c
PE
6792012-08-01 Paul Eggert <eggert@cs.ucla.edu>
680
681 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
682
5c0c0e8a
GM
6832012-08-01 Glenn Morris <rgm@gnu.org>
684
685 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
686 Move to configure.ac.
687
552a99b4
JB
6882012-08-01 Juanma Barranquero <lekktu@gmail.com>
689
690 * makefile.w32-in (CONFIG_H): Update dependencies.
691 (CONF_POST_H): New macro.
692
693 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
694
8d8e2dfe
GM
6952012-07-31 Glenn Morris <rgm@gnu.org>
696
bc96620a
GM
697 * Makefile.in (S_FILE): No longer set by configure.
698
476b1b2d
GM
699 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
700 is available.
701 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
702
b2c7a106
GM
703 * process.h (NULL_DEVICE):
704 * emacs.c (SEPCHAR):
705 * editfns.c (USER_FULL_NAME): Let configure set them.
706
d53d062a
GM
707 * s/README, s/template.h: Remove files.
708
4515017f
GM
709 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
710
8d8e2dfe
GM
711 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
712 Move to configure.ac.
713
5b20b3cc
EZ
7142012-07-31 Eli Zaretskii <eliz@gnu.org>
715
1e0afd9a
EZ
716 * .gdbinit (xframe): Adapt to introduction of FVAR and the
717 resulting renaming of 'struct frame' members.
718
5b20b3cc
EZ
719 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
720
721 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
722 after introduction of FVAR.
723
f1310128
JD
7242012-07-31 Jan Djärv <jan.h.d@swipnet.se>
725
79e721e0
JD
726 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
727
728 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
729 instead of compositeToPoint.
730 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
731
8d7c7eed 732 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 733
e34f7f79
DA
7342012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
735
736 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
737 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 738 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
739 (BVAR): Change to use INTERNAL_FIELD.
740 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
741 (KVAR): Change to use INTERNAL_FIELD.
742 * frame.h (FVAR): New macro.
743 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
744 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
745 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
746 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
747 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
748
c09bfb2f
DA
7492012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
750
751 Miscellaneous fixes for non-default X toolkits.
752 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
753 * xterm.c (x_frame_of_widget): Remove redundant prototype.
754 Move under #ifdef USE_LUCID.
755 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
756 definition and usage to avoid warnings.
757
14c114ae
JD
7582012-07-31 Jan Djärv <jan.h.d@swipnet.se>
759
760 * nsterm.m (openFiles): Fix previous checkin.
761
3bd21e82
PE
7622012-07-31 Paul Eggert <eggert@cs.ucla.edu>
763
764 * indent.c (compute_motion): Remove unused local.
765
c1529ded
GM
7662012-07-31 Glenn Morris <rgm@gnu.org>
767
400d5621
GM
768 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
769
268e2432
GM
770 * conf_post.h [USG5_4]:
771 Move remaining contents of s/usg5-4-common.h here.
772 * s/usg5-4-common.h: Remove file.
773
7552f3ee
GM
774 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
775 * s/irix6-5.h: Remove file.
776
6a381852
GM
777 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
778 * s/darwin.h: Remove file.
779
c1529ded
GM
780 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
781 * s/hpux10-20.h: Remove file, which is now empty.
782
b429a4ee
GM
7832012-07-30 Glenn Morris <rgm@gnu.org>
784
785 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
786 * Makefile.in (config_h): Add conf_post.h.
787 * makefile.w32-in (CONFIG_H): Add conf_post.h.
788
adff3182
JD
7892012-07-30 Jan Djärv <jan.h.d@swipnet.se>
790
791 * nsterm.m (ns_do_open_file): New variable.
b9031d69 792 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
793 (openFile, openTempFile, openFileWithoutUI, openFiles):
794 Open files only if ns_do_open_file.
adff3182 795
c32af1e4
PE
7962012-07-30 Paul Eggert <eggert@cs.ucla.edu>
797
7393bcbb
PE
798 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
799 This no-op macro hasn't been needed for many years.
800 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
801
c32af1e4
PE
802 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
803 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
804 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
805 gdb_make_enums_visible.
806 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
807 (DIRECTORY_SEP): Now a constant, not a macro.
808
302fc036
EZ
8092012-07-30 Eli Zaretskii <eliz@gnu.org>
810
811 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
812 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
813
814 * w32term.c <w32_keyboard_codepage>: Renamed from
815 keyboard_codepage and now external. All users changed.
816
817 * w32term.h: Add declaration of w32_keyboard_codepage.
818
819 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
820 the codepage to translate keys to Unicode. If this argument is
821 -1, use the value returned by GetConsoleCP. All callers changed.
822
88fb40b4
PE
8232012-07-30 Paul Eggert <eggert@cs.ucla.edu>
824
0aee6912
PE
825 Update .PHONY listings in makefiles.
826 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
827 bootstrap-clean, distclean, maintainer-clean, versioclean,
828 extraclean, frc.
829
88fb40b4
PE
830 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
831 This is a bit clearer. Fix some commentary typos.
832
0a763bd1
GM
8332012-07-30 Glenn Morris <rgm@gnu.org>
834
32bac6d6
GM
835 * s/netbsd.h: Let configure include signal.h if needed.
836 Remove file, which is now empty.
837
b65e7c46
GM
838 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
839 Let configure set them.
840 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
841 No more need to undefine.
0a763bd1 842
169304bd
AS
8432012-07-30 Andreas Schwab <schwab@linux-m68k.org>
844
845 * keymap.c (Fkey_description): Don't remove 0x80 bit from
846 non-single-byte char when adding meta modifier. (Bug#12090)
847
6cd7a139
DA
8482012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
849
850 Convert safe_call to use variable number of arguments.
851 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
852 (safe_call2): Fix comment.
853 * lisp.h (safe_call): Adjust prototype.
854 * coding.c (encode_coding_object): Change to use safe_call2.
855 * xfaces.c (merge_face_heights): Change to use safe_call1.
856
d34d6ffc
GM
8572012-07-30 Glenn Morris <rgm@gnu.org>
858
7b8a48e4 859 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 860 does that unconditionally. Remove file, which is now empty.
7b8a48e4 861
d34d6ffc
GM
862 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
863 Remove empty files.
864
03a660a6
PE
8652012-07-30 Paul Eggert <eggert@cs.ucla.edu>
866
867 Export to GDB most of lisp.h's remaining object-like macros.
868 * lisp.h (min, max): Move earlier, because they're used earlier now.
869 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
870 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
871 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
872 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
873 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
874 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
875 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
876 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
877 Now constants, for GDB. They need not be macros.
878 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
879 Now constants, for GDB, as well as macros, for static initializers.
880 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
881 Move to after the definition of struct Lisp_Char_Table,
882 since the former now needs that type defined.
883 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
884 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
885 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
886 New enums, for gdb_make_enums_visible.
887 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 888 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
889 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
890 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
891 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
892 enum maxargs, enum MAX_ALLOCA.
893 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
894 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
895 no longer needed, now that they are done in lisp.h.
896
e499d0ee
DA
8972012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
898
899 Cleanup string bytes checking.
900 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
901 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
902 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
903 (check_sblock, compact_small_strings): Simplify.
904
d5040d2d
PE
9052012-07-29 Paul Eggert <eggert@cs.ucla.edu>
906
907 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
908 These macros are confusing and no longer need to be defined, as
909 the enum values now suffice. All uses replaced with definiens.
910 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
911
7f259ae6
JB
9122012-07-29 Juanma Barranquero <lekktu@gmail.com>
913
914 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
915 ($(BLD)/w32console.$(O)): Update dependencies.
916
7e63e0c3
DA
9172012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
918
919 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
920 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
921 time. Adjust users.
922 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
923
ffd817eb
JD
9242012-07-29 Jan Djärv <jan.h.d@swipnet.se>
925
926 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
927 setting sitelisp (Bug#12010).
928
417a7a0e
EZ
9292012-07-29 Eli Zaretskii <eliz@gnu.org>
930
14ae4239 931 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
932
933 * w32heap.c (cache_system_info):
934 * w32.c (sys_rename):
935 * w32proc.c (find_child_console, sys_kill): All users changed.
936
387d4d92
PE
9372012-07-29 Paul Eggert <eggert@cs.ucla.edu>
938
939 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
940
55a6cca6
EZ
9412012-07-29 Eli Zaretskii <eliz@gnu.org>
942
943 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
944
dbcf001c
DA
9452012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
946
947 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
948 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
949 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 950
e2688e4a
DA
9512012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
952
953 Generalize marker debugging code under MARKER_DEBUG and use eassert.
954 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
955 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
956 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
957 (replace_range, replace_range_2, del_range_2): Change to eassert.
958 * marker.c (byte_char_debug_check): Adjust style.
959
b46a6a83
PE
9602012-07-29 Paul Eggert <eggert@cs.ucla.edu>
961
962 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
963 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
964 long-ago-commented-out code that talks about "WIN32".
965 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
966 All uses changed.
967
e32a5799
PE
9682012-07-28 Paul Eggert <eggert@cs.ucla.edu>
969
970 Use Gnulib stdalign module (Bug#9772, Bug#9960).
971 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
972 Simplify by using alignof.
973 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
974 * lisp.h: Include <stdalign.h>.
975 (GCALIGNMENT): New macro and constant.
976 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
977 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
978 (stdalign): New macro, if not already defined.
979
df81cd29
EZ
9802012-07-28 Eli Zaretskii <eliz@gnu.org>
981
01bd1b0d
EZ
982 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
983 * w32inevt.c: Include w32inevt.h.
984 (w32_read_console_input): New inline function, calls either
985 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
986 w32_console_unicode_input.
987 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
988 (w32_kbd_patch_key, key_event): Use the codepage returned by
989 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
990 (key_event): use uChar.UnicodeChar only if
991 w32_console_unicode_input is non-zero.
992
993 * w32console.c: Include w32heap.h.
994 <w32_console_unicode_input>: New global variable.
995 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
996 family of Windows, zero otherwise.
997
998 * w32inevt.h: Declare w32_console_unicode_input.
999
df81cd29
EZ
1000 * xdisp.c (init_iterator): Don't reference tip_frame in a build
1001 --without-x. (Bug#11742)
1002
c20fdd9e
PE
10032012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1004
1005 Adjust GDB to reflect pvec_type changes (Bug#12036).
1006 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1007 2012-07-04 changes to pseudovector representation.
1008 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1009
32770973 10102012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1011
1012 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1013 bus address.
1014 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1015
3438fe21
EZ
10162012-07-27 Eli Zaretskii <eliz@gnu.org>
1017
bcfbc9de
EZ
1018 * alloc.c (listn): Fix the order the arguments are consed onto the
1019 list.
1020
3438fe21
EZ
1021 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1022 enumeration constants, as PURE and HEAP are too general, and clash
1023 with other headers and sources, such as gmalloc.c and the
1024 MS-Windows system headers. All users changed.
1025
eeaea515
DA
10262012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1027
1028 Revert last save_excursion_save and save_excursion_restore changes.
1029 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1030 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1031
073c88c2
DA
10322012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1033
1034 Fix recently-introduced typos in Windows port.
1035 Reported by Martin Rudalics <rudalics@gmx.at>.
1036 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1037 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1038
4706125e
PE
10392012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1040
1041 Improve GDB symbol export (Bug#12036).
1042 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1043 arms of an 'if', not using conditional expressions; otherwise GDB
1044 complains about the types in the unevaluated arm when the argument
1045 is an integer literal.
1046 (xgetint): Simplify expression.
1047 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1048 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1049 Zaretskii in <http://bugs.gnu.org/12036#13>.
1050 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1051 needed now that we have gdb_make_enums_visible.
1052 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1053 (enum enum_USE_LSB_TAG):
1054 New enum types, packaging up enums that need to be exported to GDB.
1055
694b6c97
DA
10562012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1057
1058 Utility function to make a list from specified amount of objects.
1059 * lisp.h (enum constype): New datatype.
1060 (listn): New prototype.
1061 * alloc.c (listn): New function.
1062 (Fmemory_use_count, syms_of_alloc): Use it.
1063 * buffer.c (syms_of_buffer): Likewise.
1064 * callint.c (syms_of_callint): Likewise.
1065 * charset.c (define_charset_internal): Likewise.
1066 * coding.c (syms_of_coding): Likewise.
1067 * keymap.c (syms_of_keymap): Likewise.
1068 * search.c (syms_of_search): Likewise.
1069 * syntax.c (syms_of_syntax): Likewise.
1070 * w32.c (init_environment): Likewise.
1071 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1072 * xdisp.c (syms_of_xdisp): Likewise.
1073 * xfns.c (syms_of_xfns): Likewise.
1074
6195f384
DA
10752012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1076
1077 Fast save_excursion_save and save_excursion_restore.
1078 * lisp.h (struct Lisp_Excursion): New data type.
1079 (PVEC_EXCURSION): New pseudovector type.
1080 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1081 to deal with it. Adjust comments.
1082 (init_marker, attach_marker): New prototype.
1083 (unchain_marker): Adjust prototype.
1084 * marker.c (attach_marker): Change to global.
1085 (init_marker): New function.
1086 * alloc.c (Fmake_marker, build_marker): Use it.
1087 (build_marker): More easserts.
1088 (mark_object): Handle struct Lisp_Excursion.
1089 * editfns.c (save_excursion_save, save_excursion_restore):
1090 Reimplement to use struct Lisp_Excursion. Add comments.
1091
5eceb8fb
PE
10922012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1093
1094 Fix export of symbols to GDB (Bug#12036).
1095 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1096 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1097 emacs.c, as this is a more-suitable home. Had this been done earlier
1098 the fix for 12036 would have avoided some of the problems noted in
1099 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1100 would have been more obvious.
562157c8
PE
1101 * emacs.c: Do not include <verify.h>; no longer needed.
1102 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1103 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1104 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1105 Remove; now done in lisp.h.
1106 * lisp.h (PUBLISH_TO_GDB): New macro.
1107 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1108 (DATA_SEG_BITS): Use it.
1109 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1110 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1111 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1112 not be usable in #if. This simplifies things.
1113
d6749401
JB
11142012-07-26 Juanma Barranquero <lekktu@gmail.com>
1115
1116 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1117
1781b9e9
PE
11182012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1119
d89518db 1120 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1121 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1122 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1123 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1124 Adjust to changes in lisp.h and emacs.c, by using
1125 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1126 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1127 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1128 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1129 instead of gdb_valbits.
1130 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1131 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1132 instead of gdb_array_mark_flag.
1133 (xboolvector): Get size from $->size, not $->header.size.
1134 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1135 (xreload, hook-run, hookpost-run): Remove.
1136 * emacs.c: Include <verify.h>.
1137 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1138 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1139 Remove.
1140 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1141 (gdb_USE_LSB_TAG): New enum constants.
1142 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1143 Also define these as enum constants, so they're visible to GDB.
1144 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1145 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1146 as constants, so they're visible to GDB.
1147 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1148 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1149 Now enum constants, not macros, so they're visible to GDB.
1150 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1151 more convenient now. All uses changed.
1152 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1153 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1154
3628596a
DA
11552012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1156
1157 Explicitly free restriction data that are not needed anymore.
1158 * editfns.c (save_restriction_restore): Free restriction data.
1159
7abaf5cc
SM
11602012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1161
1162 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1163 add argument, tune behavior, and adjust all callers.
1164
71f88e00
PE
11652012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1166
1167 Use typedef for EMACS_INT, EMACS_UINT.
1168 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1169 than macros. This simplifies debugging in the usual case, since
1170 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1171 and it allows expressions involving EMACS_INT casts.
1172 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1173
57ec3034
JD
11742012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1175
1176 * nsterm.m (ns_read_socket): Return early if there is a modal
1177 window (Bug#12043).
1178
8137e7b3
MR
11792012-07-25 Martin Rudalics <rudalics@gmx.at>
1180
1181 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1182 that FOCUS-FRAME can be omitted.
1183
04e9897c
DA
11842012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1185
1186 Adjust buffer text indirection counters at the end of Fkill_buffer.
1187 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1188 buffer is definitely dead. This should really fix an issue reported
1189 by Christoph Scholtes again. (Bug#12007).
1190 (init_buffer_once): Initialize indirection counters of
1191 buffer_defaults and buffer_local_symbols (for sanity and safety).
1192
8a0484e1
EZ
11932012-07-24 Eli Zaretskii <eliz@gnu.org>
1194
1195 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1196 and continuation glyphs on tooltip frames, leave them at zero.
1197 Avoids continued lines in tooltips. (Bug#11832)
1198
fa691a83
DA
11992012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1200
1201 Simplify copy_overlay.
04e9897c 1202 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1203 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1204
436bc8e0
EZ
12052012-07-23 Eli Zaretskii <eliz@gnu.org>
1206
1207 * print.c (print_object): Don't crash when a frame's name is nil
1208 or invalid. (Bug#12025)
1209
1210 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1211 it signals an error when a tooltip frame is being created.
1212
d7a7fda3
DA
12132012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1214
1215 Cleanup miscellaneous objects allocation and initialization.
1216 * alloc.c (allocate_misc): Change to static. Add argument to
1217 specify the subtype. Adjust comment and users.
1218 (build_overlay): New function.
1219 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1220 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1221 (allocate_misc): Remove prototype.
1222 (build_overlay): Add prototype.
1223
12242012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1225
1226 Swap buffer text indirection counters in Fbuffer_swap_text.
1227 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1228 This avoids crash reported by Christoph Scholtes at
1229 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1230
9d7fa573
JD
12312012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1232
1233 * nsmenu.m (Popdown_data): New struct.
1234 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1235 free Popdown_data.
1236 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1237 (initWithContentRect): Make imgView and contentView non-static
1238 and autorelease them. Also autorelease img and matrix (Bug#12005).
1239 (dealloc): Remove (Bug#12005).
1240
0dd6d66d
DA
12412012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1242
1243 Adjust consing_since_gc when objects are explicitly freed.
1244 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1245 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1246 (free_cons, free_misc): Subtract object size from consing_since_gc.
1247
d36d71df
DA
12482012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1249
1250 Simplify and cleanup markers positioning code.
1251 * marker.c (attach_marker): More useful eassert.
1252 (live_buffer, set_marker_internal): New function.
1253 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1254 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1255
fb9ea40f
PE
12562012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1257
1258 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1259 as it's limited by the amount of memory, not by INT_MAX.
1260
2d5c5f7d
EZ
12612012-07-21 Eli Zaretskii <eliz@gnu.org>
1262
07fb592e
EZ
1263 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1264 in special-event-map. See the discussion at
1265 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1266 for the reasons.
1267
37a9eac8 1268 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1269 info.dwItemData. Fixes crashes on 64-bit Windows.
1270 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1271
c4328746
JD
12722012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1273
1274 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1275 (conversationIdentifier): Return value is NSInteger.
784051c4 1276 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1277
6e5d1c12
CY
12782012-07-21 Chong Yidong <cyd@gnu.org>
1279
1280 * window.c (decode_any_window): Signal an error if the window is
1281 on a dead frame (Bug#11984).
1282
9928463d
DA
12832012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1284
1285 Add indirection counting to speed up Fkill_buffer.
1286 * buffer.h (struct buffer): New member.
1287 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1288 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1289 base buffer indirection counter.
1290 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1291 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1292 through buffer list if indirection counter is 0.
1293
f8643a6b
DA
12942012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1295
1296 Extend the value returned by Fgarbage_collect with heap statistics.
1297 * alloc.c (Qheap): New symbol.
1298 (syms_of_alloc): DEFSYM it.
1299 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1300 (Fmemory_free): Remove.
1301 (syms_of_alloc): Don't defsubr it.
1302 * buffer.c (Fcompact_buffer): Remove.
1303 (syms_of_buffer): Don't defsubr it.
1304
dac616ff
DA
13052012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1306
1307 Make maybe_gc inline.
1308 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1309 * lisp.h (consing_since_gc, gc_relative_threshold)
1310 (memory_full_cons_threshold): Revert declaration.
1311 (maybe_gc): Remove prototype, define as inline.
1312 * alloc.c: Remove old commented-out code.
1313 (consing_since_gc, gc_relative_threshold)
1314 (memory_full_cons_threshold): Revert to global.
1315 (maybe_gc): Remove.
1316
d7ea76b4
DA
13172012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1318
1319 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1320 * lisp.h (build_unibyte_string): New function.
1321 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1322 * sysdep.c, w32fns.c, xfns.c: Use it.
1323 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1324 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1325 Adjust users accordingly.
1326 * font.h (font_open_by_name): Adjust prototype.
1327
765e61e3
DA
13282012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1329
1330 Cleanup calls to Fgarbage_collect.
1331 * lisp.h (maybe_gc): New prototype.
1332 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1333 Remove declarations.
1334 * alloc.c (maybe_gc): New function.
1335 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1336 Make them static.
1337 * bytecode.c (MAYBE_GC): Use maybe_gc.
1338 * eval.c (eval_sub, Ffuncall): Likewise.
1339 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1340 to avoid dependency from auto-save feature.
1341
52b852c7
PE
13422012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1343
1344 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1345 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1346 'for_each_per_buffer_object_at'.
1347 All uses changed. It's better to use upper-case for macros that
1348 cannot be implemented as functions, to give the reader a clue
1349 that they're special.
1350
5db81e33
SM
13512012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1352
1353 * alloc.c (Fgarbage_collect): Tweak docstring.
1354
5b835e1d
DA
13552012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1356
1357 Tweak the value returned from Fgarbage_collect again.
1358 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1359 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1360 Adjust documentation.
1361 (total_vector_bytes): Rename to total_vector_slots, adjust
1362 accounting.
1363 (total_free_vector_bytes): Rename to total_free_vector_slots,
1364 adjust accounting.
1365 (Qstring_bytes, Qvector_slots): New symbols.
1366 (syms_of_alloc): DEFSYM them.
1367
9cd47b72
DA
13682012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1369
1370 Buffer compaction primitive which may be used from Lisp.
1371 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1372 (syms_of_buffer): Register Fcompact_buffer.
1373 * alloc.c (Fgarbage_collect): Use compact_buffer.
1374 * buffer.h (compact_buffer): New prototype.
1375 (struct buffer_text): New member.
1376
d17337e5
DA
13772012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1378
1379 New macro to iterate over all buffers, miscellaneous cleanups.
1380 * lisp.h (all_buffers): Remove declaration.
1381 * buffer.h (all_buffers): Add declaration, with comment.
1382 (for_each_buffer): New macro.
1383 * alloc.c (Fgarbage_collect, mark_object): Use it.
1384 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1385 (init_buffer): Likewise.
1386 * data.c (Fset_default): Likewise.
1387 * coding.c (code_conversion_restore): Remove redundant check
1388 for dead buffer.
1389 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1390
60cfd278
AS
13912012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1392
1393 Fix bug that created negative-length intervals.
1394 * intervals.c (merge_interval_right, merge_interval_left):
1395 Do not zero out this interval if it is absorbed by its children,
1396 as this interval's total length doesn't change in that case. See
1397 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1398
d06714cb
PE
13992012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1400
83713154
PE
1401 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1402 when invoking (make-bool-vector N t) and N is a positive
1403 multiple of 8 -- the last 8 bits were mistakenly cleared.
1404
d06714cb
PE
1405 Remove some struct layout assumptions in bool vectors.
1406 * alloc.c (bool_header_size): New constant.
1407 (header_size, word_size): Move earlier, as they're now used earlier.
1408 Use 'word_size' in a few more places, where it's appropriate.
1409 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1410 padding before the data member of a bool vector.
1411 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1412 than doing the check by hand with an abort ().
1413
464d5a5e
SM
14142012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1415
5fbc0409
SM
1416 * eval.c (Fdefvar): Don't check constants since we only set the var if
1417 it's not yet defined anyway (bug#11904).
1418
464d5a5e
SM
1419 * lisp.h (last_undo_boundary): Declare new var.
1420 * keyboard.c (command_loop_1): Set it.
1421 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1422 were auto-added by the command loop (bug#11774).
1423
8dc2e44a
AS
14242012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1425
1426 * w32font.c (Qsymbol): Remove local definition.
1427 (syms_of_w32font): Don't DEFSYM it.
1428
169925ec
DA
14292012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1430
1431 Fix sweep_vectors to handle large bool vectors correctly.
1432 * alloc.c (sweep_vectors): Account total_vector_bytes for
1433 bool vectors larger than VBLOCK_BYTES_MAX.
1434
5fbfb018
CY
14352012-07-18 Chong Yidong <cyd@gnu.org>
1436
1437 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1438 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1439
3ab6e069
DA
14402012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1441
1442 Return more descriptive data from Fgarbage_collect.
1443 Suggested by Stefan Monnier in
1444 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1445 * alloc.c (bounded_number): New function.
1446 (total_buffers, total_vectors): New variable.
1447 (total_string_size): Rename to total_string_bytes, adjust users.
1448 (total_vector_size): Rename to total_vector_bytes, adjust users.
1449 (sweep_vectors): Account total_vectors and total_vector_bytes.
1450 (Fgarbage_collect): New return value. Adjust documentation.
1451 (gc_sweep): Account total_buffers.
1452 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1453 (VECTOR_SIZE): Remove.
1454 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1455 (Qinterval, Qmisc): New symbols.
1456 (syms_of_data): Initialize them.
1457 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1458 (Qcons, Qbuffer): New declarations.
1459
6d02fe5b
PE
14602012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1461
1462 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1463 Round up, not down. Improve doc.
1464
b7ffe040
DA
14652012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1466
1467 Restore old code in allocate_string_data to avoid Faset breakage.
1468 Reported by Julien Danjou <julien@danjou.info> in
1469 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1470 * alloc.c (allocate_string_data): Restore old code with minor
1471 adjustments, fix comment to explain this subtle issue.
1472
4dc7c8d5
SM
14732012-07-17 Eli Zaretskii <eliz@gnu.org>
1474
1475 Remove FILE_SYSTEM_CASE.
1476 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1477
1478 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1479 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1480 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1481 call-process-region passes it through expand-file-name.
1482
1483 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1484
14852012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1486
1487 Fix crash when creating indirect buffer (Bug#11917)
1488 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1489 Don't handle unbound variables specially if non-zero.
1490 (Fbuffer_local_variables): Pass zero.
1491 (clone_per_buffer_values): Pass non-zero.
1492
14932012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1494
1495 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1496 to make the loop interruptible.
1497
14982012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1499
1500 * gnutls.c (emacs_gnutls_handshake): Only retry if
1501 GNUTLS_E_INTERRUPTED.
1502
cce7fefc
DA
15032012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1504
1505 Cleanup and convert miscellaneous checks to eassert.
1506 * alloc.c (mark_interval): Fix comment, partially rephrase
1507 old comment from intervals.h (see below).
1508 * intervals.c (find_interval, adjust_intervals_for_insertion)
1509 (delete_interval, adjust_intervals_for_deletion)
1510 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1511 Convert to eassert.
1512 (adjust_intervals_for_insertion, make_new_interval):
1513 Remove obsolete and unused code.
1514 * intervals.h (struct interval): Remove obsolete comment.
1515 * textprotp.c (erase_properties): Remove unused code.
1516 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1517 (Fremove_list_of_text_properties): Convert to eassert.
1518
9ea10cc3
CY
15192012-07-17 Chong Yidong <cyd@gnu.org>
1520
1521 * editfns.c (Finsert_char): Doc fix.
1522
3900d5de
DA
15232012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1524
1525 Fix previous change to make Fmemory_free always accurate.
1526 * alloc.c (make_interval): Update total_free_intervals.
1527 (make_float): Likewise for total_free_floats.
1528 (free_cons, Fcons): Likewise for total_free_conses.
1529 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1530 Likewise for total_free_vector_bytes.
1531 (Fmake_symbol): Likewise for total_free_symbols.
1532 (bytes_free): Remove.
1533
7098646f
DA
15342012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1535
1536 Simple free memory accounting feature.
1537 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1538 (sweep_vectors): Accumulate size of free vectors.
1539 (Fgarbage_collect): Setup bytes_free.
1540 (Fmemory_free): New function.
1541 (syms_of_alloc): Register it.
1542
22657b40
DA
15432012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1544
1545 Cleanup overlays checking.
1546 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1547 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1548 eassert and OVERLAYP.
1549 (sort_overlays): Change to use OVERLAYP.
1550
ddfc8813
RK
15512012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1552
1553 * editfns.c (Finsert_char): Make it interactive, and make the
1554 second arg optional. Copy interactive spec and docstring from
1555 ucs-insert.
1556
7c26cf3c
PE
15572012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1558
1559 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1560 Unlike the other wrapped functions, fabs has an unspecified
1561 effect on errno.
1562
5d127af9
JD
15632012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1564
1565 * nsterm.m (keyDown): Interpret flags without left/right bits
1566 as the left key (Bug#11670).
1567
6a0dd1d7
DA
15682012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1569
1570 Remove empty and useless init functions.
1571 * lisp.h (init_character_once, init_fns, init_image)
1572 (init_filelock, init_sound): Remove prototype.
1573 * character.c (init_character_once): Remove.
1574 * filelock.c (init_filelock): Likewise.
1575 * fns.c (init_fns): Likewise.
1576 * image.c (init_image): Likewise.
1577 * sound.c (init_sound): Likewise.
1578 * emacs.c (main): Adjust accordingly.
1579
7a6136fd
DA
15802012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1581
1582 * gtkutil.h: Tiny cleanups.
1583 (use_old_gtk_file_dialog): Remove useless declaration.
1584 (xg_uses_old_file_dialog): Add suggested const attribute.
1585
ce811ad9
EZ
15862012-07-15 Eli Zaretskii <eliz@gnu.org>
1587
1588 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1589 (bidi_paragraph_init): Use it to limit search forward for a strong
1590 directional character in abnormally large paragraphs full of
1591 neutral or weak characters. (Bug#11943)
1592
c9adfeaa
SF
15932012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1594
1595 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1596 the toolbar (Bug#9451).
1597 (xg_make_tool_item): Give the widget event box a transparent
1598 background.
1599
fff62aa9
DA
16002012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1601
1602 Cleanup basic allocation variables and functions.
1603 * alloc.c (ignore_warnings, init_intervals, init_float)
1604 (init_cons, init_symbol, init_marker): Remove.
1605 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1606 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1607 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1608 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1609 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1610 (staticidx, init_alloc_once, init_strings, free_ablock):
1611 Remove redundant initialization.
1612 * fns.c (init_weak_hash_tables): Remove.
1613 * lisp.h (init_weak_hash_tables): Remove prototype.
1614
9730daca
DA
16152012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1616
1617 Use zero_vector where appropriate.
1618 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1619 accordingly.
1620 * lisp.h (zero_vector): New declaration.
1621 * font.c (null_vector): Remove.
1622 (syms_of_font): Remove initialization and staticpro.
1623 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1624 * keymap.c (Faccessible_keymaps): Likewise.
1625
2e2d2a13
LL
16262012-07-15 Leo Liu <sdl.web@gmail.com>
1627
1628 * fringe.c: Fix typo in comments.
1629
cd276f6e
LL
16302012-07-14 Leo Liu <sdl.web@gmail.com>
1631
1632 * fringe.c: Add a new bitmap exclamation-mark.
1633
5a1131d9
EZ
16342012-07-14 Eli Zaretskii <eliz@gnu.org>
1635
1636 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1637
1638 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1639 (HAVE_MENUS): Don't define, defined by editing config.in with
1640 msdos/sed2v2.inp.
1641 (GMALLOC_INHIBIT_VALLOC): Don't define.
1642 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1643
22e983b7
JB
16442012-07-14 Juanma Barranquero <lekktu@gmail.com>
1645
1646 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1647
5b3f250f
GM
16482012-07-14 Glenn Morris <rgm@gnu.org>
1649
1650 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1651 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1652 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1653
33d63ff4
GM
16542012-07-13 Glenn Morris <rgm@gnu.org>
1655
5b633342
GM
1656 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1657
33d63ff4
GM
1658 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1659 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1660
b55b9f85
JD
16612012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1662
0dc8cf50
JD
1663 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1664 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1665 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1666 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1667 where appropriate.
1668 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1669 as boolean expression.
1670 (x_set_window_size): Remove unused variable toolbar.
1671 (ns_get_color_default, ns_mod_to_lisp): Remove.
1672 (ns_mouse_position): Remove unused variables xchar and ychar.
1673 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1674 (ns_set_vertical_scroll_bar): Remove unused variable count.
1675 (ns_delete_terminal): Remove unused variable i.
1676 (ns_term_init): Remove unused variables r, g and b.
1677 (mouseDown): Remove unused variable window.
1678 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1679 (initFrameFromEmacs): Remove unused variable vbextra.
1680 (mouseEntered): Remove unused variables p and dpyinfo.
1681 (mouseExited): Remove unused variables p and r.
1682 (ns_define_frame_cursor, ns_clear_frame_area)
1683 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1684 (menuDown): Assign [sender tag] to variable and cast the variable.
1685
1686 * nsterm.h (menuDown): Add id as type to argument sender.
1687 (ns_display_info_for_name): Add Lisp_Object argument.
1688 (ns_term_init): Add Lisp_Object argument.
1689 (ns_map_event_to_object): Add void argument.
1690 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1691 prototype with arguments and only declare if __OBJC__.
1692 (nxatoms_of_nsselect): Add void argument.
1693 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1694 (ns_alloc_autorelease_pool): Add void argument.
1695 (ns_release_autorelease_pool): Add void* argument.
1696 (ns_get_defaults_value): Add const char* argument.
1697
1698 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1699 (initFromContents): Use SSDATA where appropriate.
1700 (ns_update_menubar): Add braces to ambigous if-else.
1701 (initWithTitle): Put () around assignment in if statement.
1702 (ns_menu_show): Remove unused variables window and keymap.
1703 (update_frame_tool_bar): Remove unused variable selected_p.
1704 (initWithContentRect): Remove unused variable this_cmd_name.
1705
1706 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1707 appropriate.
1708 (setXBMColor): Remove unused variable len.
1709 (setPixmapData): Put () around assignment in loop statement.
1710
1711 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1712 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1713 where appropriate.
1714 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1715 around assignment in loop statement.
1716 (nsfont_open): Remove unused variable i.
1717 (nsfont_open): Remove unused variable len.
1718 (nsfont_draw): Remove unused variable cs.
1719
1720 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1721 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1722 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1723 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1724 (Fns_font_name, Fns_perform_service)
1725 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1726 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1727 (ns_set_name): Remove unused variable view.
1728 (x_set_menu_bar_lines): Remove unused variable olines.
1729 (x_set_tool_bar_lines): Remove unused variable root_window.
1730 (Fns_list_colors): Put () around assignment in while statement.
1731 (Fns_perform_service): Remove unused variable len.
1732 (Fns_display_usable_bounds): Remove unused variable top.
1733 (syms_of_nsfns): Remove unused variable i.
1734
b55b9f85
JD
1735 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1736 memcpy (Bug#11907).
1737
ed9265fc 17382012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1739
1740 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1741 and free it with DestroyExceptionInfo (Bug#11558).
1742
ef099b57
JB
17432012-07-13 Juanma Barranquero <lekktu@gmail.com>
1744
1745 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1746 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1747 Set here, not in nt/config.nt.
1748
ea814a5d
EZ
17492012-07-13 Eli Zaretskii <eliz@gnu.org>
1750
1751 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1752 cursor overflow into the last glyph on display line when the right
1753 fringe is off. (Bug#11832)
1754
1a952767
PE
17552012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1756
1757 * xdisp.c (produce_special_glyphs): Now static.
1758 * dispextern.h (produce_special_glyphs): Remove decl.
1759
983188fd
GM
17602012-07-13 Glenn Morris <rgm@gnu.org>
1761
8d7c7eed 1762 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1763 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1764
983188fd
GM
1765 * s/usg5-4-common.h (USG, USG5):
1766 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1767 * s/sol2-6.h (SOLARIS2):
1768 * s/irix6-5.h (IRIX6_5):
1769 * s/hpux10-20.h (USG, USG5, HPUX):
1770 * s/gnu-linux.h (USG, GNU_LINUX):
1771 * s/freebsd.h (BSD_SYSTEM):
1772 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1773 * s/cygwin.h (CYGWIN):
1774 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1775 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1776
d1e68667 17772012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1778
1779 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1780
6de0e799
GM
17812012-07-13 Glenn Morris <rgm@gnu.org>
1782
739ae010
GM
1783 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1784
dbee5793
GM
1785 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1786
6de0e799
GM
1787 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1788 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1789
b82da769
GM
17902012-07-12 Glenn Morris <rgm@gnu.org>
1791
4fae5a7a 1792 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1793
1794 * process.c (init_process_emacs): Rename from init_process.
1795 The old name is also the name of a Mach system call.
1796 * lisp.h, emacs.c: Update for this name change.
1797 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1798 longer needed.
1799
5a979817
EZ
18002012-07-12 Eli Zaretskii <eliz@gnu.org>
1801
1802 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1803 memmove call that removes glyphs covered by the left truncation
1804 glyph. Improve commentary.
1805 (display_line): Fix display of continuation glyphs on GUI frames
1806 when the right fringe is turned off and variable-size fonts are
1807 used in the window. Move the code that appends a stretch glyph to
1808 produce_special_glyphs, so that it could be used for truncation
1809 and continuation glyphs alike.
1810 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1811 glyph of a suitably computed width, to align the special glyphs at
1812 the window margin. Code moved from display_line. (Bug#11832)
1813
3e91a053
GM
18142012-07-12 Glenn Morris <rgm@gnu.org>
1815
ba9e4b84
GM
1816 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1817
1818 * s/gnu-linux.h, s/hpux10-20.h:
1819 Do not unconditionally define HAVE_XRMSETDATABASE.
1820
3e91a053
GM
1821 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1822
b300b1f4
PE
18232012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1824
1825 Fix typos that broke OS X build.
1826 Reported by Randal L. Schwartz in
1827 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1828 * nsterm.m (ns_timeout): Add missing local decl.
1829 (ns_get_color): snprintf -> sprintf, to fix typo.
1830
6e777848
GM
18312012-07-12 Glenn Morris <rgm@gnu.org>
1832
3f922c37
GM
1833 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1834 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1835 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1836 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1837
0ab7b23a
GM
1838 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1839 Move PTY_OPEN to configure.
1840
6e777848
GM
1841 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1842 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1843 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1844
4a7edc24
DA
18452012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1846
1847 Use empty_unibyte_string where applicable.
1848 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1849 * lread.c (read1): Likewise.
1850 * xsettings.c (syms_of_xsettings): Likewise.
1851
308aab79
GM
18522012-07-12 Glenn Morris <rgm@gnu.org>
1853
42bd1719
GM
1854 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1855 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1856 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1857 * s/hpux10-20.h (RUN_TIME_REMAP):
1858 * s/bsd-common.h (TABDLY): Move to configure.
1859
1860 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1861
1862 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1863
ea0bbd17 1864 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1865 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1866
1867 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1868
308aab79
GM
1869 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1870 * s/template.h: Move NARROWPROTO to configure.
1871
ee1cf5cf
GM
18722012-07-11 Glenn Morris <rgm@gnu.org>
1873
30fe9bf4
GM
1874 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1875 unused since 2011-01-17 change to systty.h.
1876
ee1cf5cf
GM
1877 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1878 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1879 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1880
63e47e07
PE
18812012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1882
1883 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1884
c43fb4c3
GM
18852012-07-11 Glenn Morris <rgm@gnu.org>
1886
1887 * s/darwin.h, s/gnu-linux.h, s/template.h:
1888 Move INTERRUPT_INPUT to configure.
1889
e8df9267
DA
18902012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1891
1892 Minor adjustments to interning code.
1893 * lisp.h (intern, intern_c_string): Redefine as static inline
1894 wrappers for intern_1 and intern_c_string_1, respectively.
1895 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
1896 * lread.c (intern_1, intern_c_string_1, oblookup):
1897 Simplify Vobarray checking.
e8df9267
DA
1898 * font.c (font_intern_prop): Likewise. Adjust comment.
1899 * w32font.c (intern_font_name): Likewise.
1900
34348bd4
AS
19012012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1902
d96a1e0c
AS
1903 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1904
34348bd4
AS
1905 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1906 of Fcar/Fcdr if possible.
1907 * font.c (check_otf_features): Likewise.
1908 * fontset.c (Fnew_fontset): Likewise.
1909 * gnutls.c (Fgnutls_boot): Likewise.
1910 * minibuf.c (read_minibuf): Likewise.
1911 * msdos.c (IT_set_frame_parameters): Likewise.
1912 * xmenu.c (Fx_popup_dialog): Likewise.
1913 * w32menu.c (Fx_popup_dialog): Likewise.
1914
c8add24e
GM
19152012-07-11 Glenn Morris <rgm@gnu.org>
1916
4b575b3c
GM
1917 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1918 since nothing has defined it on these platforms.
1919
09f4e3b0
GM
1920 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1921 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1922
172bedef
GM
1923 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1924 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1925 Move CLASH_DETECTION to configure.
1926
249685df
GM
1927 * s/gnu.h: Remove file, which is now empty.
1928
c8add24e
GM
1929 * s/gnu.h, s/gnu-linux.h:
1930 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1931
b41253a3
JW
19322012-07-11 John Wiegley <johnw@newartisans.com>
1933
1934 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1935 function attribute, so we only use it if it exists in the
1936 compiler.
1937
d923b542
DA
19382012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1939
1940 Avoid call to strlen in fast_c_string_match_ignore_case.
1941 * search.c (fast_c_string_match_ignore_case): Change to use
1942 length argument. Adjust users accordingly.
1943 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1944
5ebbef1d
PE
19452012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1946
bb352260
PE
1947 Assume mkdir, rmdir.
1948 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1949 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1950
57054ddd
PE
1951 Assume rename.
1952 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1953
b747d3f7
PE
1954 Assume perror.
1955 * s/hpux10-20.h (HAVE_PERROR): Remove.
1956 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1957 Remove dummy definition, as this problem was obsolete long ago.
1958
5ebbef1d
PE
1959 Assume strerror.
1960 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1961
984e7f30
DA
19622012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1963
1964 Avoid calls to strlen in font processing functions.
1965 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
1966 (font_open_by_name): Change to use length argument.
1967 Adjust users accordingly.
d923b542
DA
1968 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1969 Adjust prototypes.
1970 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1971 Change to return ptrdiff_t.
984e7f30
DA
1972 (xfont_list_pattern, xfont_match): Use length returned by
1973 xfont_decode_coding_xlfd.
1974 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1975
20e94fdd
GM
19762012-07-11 Glenn Morris <rgm@gnu.org>
1977
9d596af3
GM
1978 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1979 Move DONT_REOPEN_PTY to configure.
1980
20e94fdd
GM
1981 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1982 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1983
e99a530f
PE
19842012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1985
22ffb973
PE
1986 Remove "#define unix" that is no longer needed (Bug#11905).
1987 * s/aix4-2.h (unix): Remove; no longer needed.
1988
e9a9ae03
PE
1989 EMACS_TIME simplification (Bug#11875).
1990 This replaces macros (which typically do not work in GDB)
1991 with functions, typedefs and enums, making the code easier to debug.
1992 The functional style also makes code easier to read and maintain.
1993 * systime.h: Include <sys/time.h> on all hosts, not just if
1994 WINDOWSNT, since 'struct timeval' is needed in general.
1995 (EMACS_TIME): Now a typedef, not a macro.
1996 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1997 not macros.
1998 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1999 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
2000 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
2001 (EMACS_TIME_LE): Now functions, not macros.
2002 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
2003 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
2004 which are not functions. All uses rewritten to use:
2005 (make_emacs_time): New function.
2006 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2007 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2008 not functions. All uses rewritten to use the following, respectively:
2009 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2010 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2011 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2012 * fileio.c (Fcopy_file):
2013 * xterm.c (XTflash): Get the current time closer to when it's used.
2014 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2015
ffacb126
PE
2016 * bytecode.c (targets): Suppress -Woverride-init warnings.
2017
e99a530f
PE
2018 Simplify by avoiding confusing use of strncpy etc.
2019 * doc.c (Fsnarf_documentation):
2020 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2021 * frame.c (Fmake_terminal_frame):
2022 * gtkutil.c (get_utf8_string):
2023 * lread.c (openp):
2024 * nsmenu.m (ns_update_menubar):
2025 * regex.c (regerror):
2026 Prefer memcpy to strncpy and strncat when either will do.
2027 * fileio.c (Fsubstitute_in_file_name):
2028 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2029 (menu_separator_name_p):
2030 * nsmenu.m (ns_update_menubar):
2031 Prefer memcmp to strncmp when either will do.
2032 * nsterm.m: Include <ftoastr.h>.
2033 (ns_get_color):
2034 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2035 Prefer snprintf to strncpy.
2036 * nsterm.m (ns_term_init):
2037 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2038 * nsterm.m (ns_term_init):
2039 Avoid the need for strncpy, by using build_string or
2040 make_unibyte_string directly. Use dtoastr, not snprintf.
2041 * process.c (Fmake_network_process): Diagnose service names that
2042 are too long, rather than silently truncating them or creating
2043 non-null-terminated names.
2044 (Fnetwork_interface_info): Likewise, for interface names.
2045 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2046 Prefer sprintf to strncat.
2047 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2048 Prefer vsnprintf to vsprintf + strncpy.
2049
c59592b3
GM
20502012-07-10 Glenn Morris <rgm@gnu.org>
2051
2052 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2053 Clarify fallback case.
2054
7d7bbefd
DA
20552012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2056
2057 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2058 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2059 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2060 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2061 where argument type is known to be a Lisp_Cons.
2062
3a4c8000
TT
20632012-07-10 Tom Tromey <tromey@redhat.com>
2064
2065 * bytecode.c (BYTE_CODE_THREADED): New macro.
2066 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2067 (enum byte_code_op): New type.
2068 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2069 (exec_byte_code): Use them. Use token threading when applicable.
2070
2a0213a6
DA
20712012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2072
2073 Optimize pure C strings initialization.
2074 * lisp.h (make_pure_string): Fix prototype.
2075 (build_pure_c_string): New function, defined as static inline. This
2076 provides a better opportunity to optimize away calls to strlen when
2077 the function is called with compile-time constant argument.
2078 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2079 argument, adjust users accordingly. Use build_pure_c_string where
2080 appropriate.
2081 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2082 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2083 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2084
cb1caeaf
DA
20852012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2086
2087 Avoid calls to strlen in miscellaneous functions.
2088 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2089 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2090 * lread.c (openp): Likewise.
2091
c293e30c
DA
20922012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2093
2094 Avoid calls to strlen in path processing functions.
2095 * fileio.c (file_name_as_directory): Add comment. Change to add
2096 srclen argument and return the length of result. Adjust users
2097 accordingly.
2098 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2099 swap 1st and 2nd arguments to obey the common convention.
2100 Adjust users accordingly.
c293e30c
DA
2101 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2102
9e059e3f
GM
21032012-07-10 Glenn Morris <rgm@gnu.org>
2104
d02eb359
GM
2105 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2106 Move PENDING_OUTPUT_COUNT definition to configure.
2107
882cf227
GM
2108 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2109 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2110 * s/gnu.h (DATA_START): Move definitions to configure.
2111
af6e839f
GM
2112 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2113 We include usg5-4-common.h, which defines them both.
2114
40289a12
GM
2115 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2116 O_RDONLY already includes it).
2117
9e059e3f
GM
2118 Stop ns builds setting the EMACSLOADPATH environment variable.
2119 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2120 Now it does not set EMACSLOADPATH, just returns the load-path string.
2121 * nsterm.h: Update accordingly.
2122 * lread.c [HAVE_NS]: Include nsterm.h.
2123 (init_lread) [HAVE_NS]: Use ns_load_path.
2124 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2125
7c4e8ec0
GM
21262012-07-09 Glenn Morris <rgm@gnu.org>
2127
d4f600ff
GM
2128 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2129 since the included bsd-common.h does so.
2130
cbb31951
GM
2131 Stop ns builds setting the EMACSPATH environment variable.
2132 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2133 (ns_init_paths): Do not set EMACSPATH.
2134 * nsterm.h (ns_exec_path): Add it.
2135 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2136 Use ns_exec_path.
2137
7c4e8ec0
GM
2138 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2139
26bccfae
PE
21402012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2141
a0bee46f
PE
2142 * process.c (wait_reading_process_output): 'waitchannels' was unset
2143 when read_kbd || !NILP (wait_for_cell); fix this.
2144
5994c183
PE
2145 Add GCC-style 'const' attribute to functions that can use it.
2146 * character.h (char_resolve_modifier_mask):
2147 * keyboard.h (make_ctrl_char):
2148 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2149 (init_character_once, next_almost_prime, init_fns, init_image)
2150 (flush_pending_output, init_sound):
2151 * mem-limits.h (start_of_data):
2152 * menu.h (finish_menu_items):
2153 Add ATTRIBUTE_CONST.
2154 * emacs.c (DEFINE_DUMMY_FUNCTION):
2155 Declare the dummy function with ATTRIBUTE_CONST.
2156 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2157 Add decls with ATTRIBUTE_CONST.
2158
26bccfae
PE
2159 Minor improvements to make_formatted_string.
2160 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2161 where int is good enough, as vsprintf returns an int.
2162 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2163
a8290ec3
DA
21642012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2165
2166 Use make_formatted_string to avoid double length calculation.
2167 * lisp.h (make_formatted_string): New prototype.
2168 * alloc.c (make_formatted_string): New function.
2169 * buffer.c (Fgenerate_new_buffer_name): Use it.
2170 * dbus.c (syms_of_dbusbind): Likewise.
2171 * editfns.c (Fcurrent_time_zone): Likewise.
2172 * filelock.c (get_boot_time): Likewise.
2173 * frame.c (make_terminal_frame, set_term_frame_name)
2174 (x_report_frame_params): Likewise.
2175 * image.c (gs_load): Likewise.
2176 * minibuf.c (get_minibuffer): Likewise.
2177 * msdos.c (dos_set_window_size): Likewise.
2178 * process.c (make_process): Likewise.
2179 * xdisp.c (ensure_echo_area_buffers): Likewise.
2180 * xsettings.c (apply_xft_settings): Likewise.
2181
d01ba2f1
GM
21822012-07-09 Glenn Morris <rgm@gnu.org>
2183
2184 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2185 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2186 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2187 * nsterm.h (ns_etc_directory): Add it.
2188 * callproc.c [HAVE_NS]: Include nsterm.h.
2189 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2190
f1f924b6
DA
21912012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2192
2193 Move marker debugging code under MARKER_DEBUG.
2194 * marker.c (MARKER_DEBUG): Move marker debugging code under
2195 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2196 for bootstrap with --enable-checking (~3x slowdown reported
2197 by Juanma Barranquero <lekktu@gmail.com>).
2198 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2199
ab531b66
PE
22002012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2201
2202 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2203 See <http://bugs.gnu.org/11825#29>.
2204
c4b3bc8a
EZ
22052012-07-08 Eli Zaretskii <eliz@gnu.org>
2206
2207 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2208 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2209 (display_line): Add commentary about displaying truncation glyphs
2210 on GUI frames.
2211 (produce_special_glyphs): Move here from term.c.
2212
2213 * term.c (produce_special_glyphs): Move to xdisp.c.
2214
2215 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2216 section.
c4b3bc8a 2217
b676b881
AS
22182012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2219
f17c5273
AS
2220 * xdisp.c (display_line): Avoid warning about implicit declaration
2221 of FRAME_FONT.
2222
298819b9
AS
2223 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2224
b676b881
AS
2225 * lisp.h: Remove empty conditional.
2226
6045c4fd
PE
22272012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2228
b3350bf9
PE
2229 * lread.c (load_path_check): Now static.
2230
6045c4fd
PE
2231 Fix some minor --with-ns problems found by static checking.
2232 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2233 (x_set_font) [!HAVE_X_WINDOWS]:
2234 * image.c (xpm_load_image) [HAVE_NS]:
2235 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2236 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2237 Remove unused local.
2238 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2239 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2240 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2241 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2242 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2243 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2244 Fix pointer signedness problem.
2245 * xfaces.c (FRAME_X_FONT_TABLE):
2246 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2247
929e7845
GM
22482012-07-07 Glenn Morris <rgm@gnu.org>
2249
2250 * lread.c (load_path_check): New function, split from init_lread.
2251 (init_lread): Reorganize. Motivation:
2252 If EMACSLOADPATH is set, check/warn about that rather than the
2253 defaults, which we are not going to use. Hence we can remove
2254 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2255 Don't warn if site-lisp directories are missing.
2256 If not installed, start from a blank load-path, since
2257 PATH_LOADSEARCH refers to the eventual installation directories.
2258
58dd0aa4
EZ
22592012-07-07 Eli Zaretskii <eliz@gnu.org>
2260
2261 Support truncation and continuation glyphs on GUI frames, when
2262 fringes are disabled. (Bug#11832)
2263 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2264 continuation glyphs even if on GUI frames.
2265 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2266 or both, are absent.
2267 (start_display, move_it_in_display_line_to): Handle the case of a
2268 GUI frame without a fringe to display continuation or truncation
2269 glyphs.
2270 (insert_left_trunc_glyphs): Support GUI frames: make sure
2271 truncation glyphs overwrite enough glyphs from the current line to
2272 have sufficient space in pixels.
2273 (display_line): Support truncation and continuation glyphs on GUI
2274 frames. If some spare pixels are left on the line after inserting
2275 the truncation glyphs, fill that space with a stretch glyph of a
2276 suitably computed width.
2277
2278 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2279 produce_glyphs, to support GUI sessions.
2280
31571fd7
PE
22812012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2282
5a16b9bc
PE
2283 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2284
f3047c75
PE
2285 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2286
31571fd7
PE
2287 Do not require float-time's arg to fit in time_t (Bug#11825).
2288 This works better on hosts where time_t is unsigned, and where
2289 float-time is applied to the (negative) difference between two times.
2290 * editfns.c (decode_time_components): Last arg is now double *,
2291 not int *, and means to store all the result as a double, without
2292 worrying about whether the seconds part fits in time_t.
2293 All callers changed.
2294 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2295 All callers changed.
2296 (Ffloat_time): Do not fail merely because the specified time falls
2297 outside of time_t range.
2298
4516fbef
GM
22992012-07-07 Glenn Morris <rgm@gnu.org>
2300
2301 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2302 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2303 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2304
07adc2c6
JB
23052012-07-07 Juanma Barranquero <lekktu@gmail.com>
2306
2307 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2308 Update dependencies.
2309
2310 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2311
fd573f31
PE
23122012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2313
fee5959d
PE
2314 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2315 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2316 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2317 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2318 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2319 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2320
fd573f31
PE
2321 * xfont.c (compare_font_names): Redo to omit the need for casts.
2322
ddadbc0e
AS
23232012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2324
fca8d6b6
AS
2325 * xfns.c (Fx_change_window_property): Doc fix.
2326 * w32fns.c (Fx_change_window_property): Doc fix.
2327
ddadbc0e
AS
2328 * w32fns.c (Fx_window_property): Accept the same arguments as the
2329 X Windows version. Doc fix.
2330 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2331
ed9265fc 23322012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2333 Eli Zaretskii <eliz@gnu.org>
2334
2335 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2336 Windows-specific code from nt/config.nt moved here.
2337 Obsolete settings removed.
2338
216ee680
PE
23392012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2340
2341 * process.c: Avoid unnecessary calls to gettime.
2342 (wait_reading_process_output): Don't get the time of day
2343 when gobbling data immediately and not waiting, as there's no need
2344 for it in that case. This removes a FIXME.
2345
bdd091e4
JD
23462012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2347
2348 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2349 is defined (Bug#11768).
2350
9d44f8ce
DA
23512012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2352
2353 Fix marker debugging code.
2354 * marker.c (byte_char_debug_check): Do not perform the check
2355 if buffer is not multibyte.
090bd7cb
JB
2356 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2357 Call byte_char_debug_check with correct arguments.
9d44f8ce 2358
90fc4786
DA
23592012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2360
2361 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2362 * marker.c (byte_char_debug_check, count_markers):
2363 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2364 (byte_debug_flag): Remove.
2365 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2366 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2367
7b7ae965
DA
23682012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2369
4e57b342
DA
2370 Avoid code repetition in marker-related functions.
2371 * marker.c (attach_marker): New function.
2372 (Fset_marker, set_marker_restricted, set_marker_both)
2373 (set_marker_restricted_both): Use it.
2374 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2375 Consistently rename charno to charpos.
2376 (marker_position): Add eassert.
2377 (marker_byte_position): Convert to eassert.
2378
23792012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2380
2381 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2382 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2383 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2384
657924ff
DA
23852012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2386
2387 Introduce fast path for the widely used marker operation.
2388 * alloc.c (build_marker): New function.
2389 * lisp.h (build_marker): New prototype.
2390 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2391 * composite.c (autocmp_chars): Likewise.
2392 * editfns.c (buildmark): Remove.
2393 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2394 (save_restriction_save): Use build_marker.
2395 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2396 * window.c (save_window_save): Likewise.
2397
041a49a6
DA
23982012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2399
2400 Do not use Fdelete_overlay in delete_all_overlays
2401 to avoid redundant calls to unchain_overlay.
2402 * buffer.c (drop_overlay): New function.
2403 (delete_all_overlays, Fdelete_overlay): Use it.
2404 * minibuf.c (get_minibuffer): Fix comment.
2405
7dca65a4
PE
24062012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2407
2408 Port to OpenBSD 5.1 amd64.
2409 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2410 This is needed for OpenBSD, and should be harmless on all BSD systems.
2411 Also, include <sys/sysctl.h>, as it should be available on all
2412 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2413 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2414 use p_pid member, not kp_proc.pid.
2415
8eb876e2
GM
24162012-07-06 Glenn Morris <rgm@gnu.org>
2417
2418 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2419
38182d90
PE
24202012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2421
2422 More xmalloc and related cleanup.
2423 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2424 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2425 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2426 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2427 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2428 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2429 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2430 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2431 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2432 * xterm.c:
2433 Omit needless casts involving void * pointers and allocation.
2434 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2435 as the former is more robust if P's type is changed.
2436 Prefer xzalloc to xmalloc + memset 0.
2437 Simplify malloc-or-realloc to realloc.
2438 Don't worry about xmalloc returning a null pointer.
2439 Prefer xstrdup to xmalloc + strcpy.
2440 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2441 growing it.
2442 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2443 alloca of a constant.
2444
6dd5a677
EZ
24452012-07-05 Eli Zaretskii <eliz@gnu.org>
2446
2447 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2448 hscroll is larger than the line width. Fixes long and futile
2449 looping inside extend_face_to_end_of_line (on a TTY) producing
2450 glyphs that are not needed and thrown away.
2451
6b312f0f
DA
24522012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2453
2454 * marker.c (set_marker_restricted_both): Simplify by using
2455 clip_to_bounds.
2456
f520ef9b
PE
24572012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2458
2459 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2460
383b7c95
JD
24612012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2462
2463 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2464 not defined (Bug#11768).
2465 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2466 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2467 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2468 followed by gtk_box_set_homogeneous (Bug#11768).
2469 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2470 (update_theme_scrollbar_width, xg_create_scroll_bar):
2471 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2472 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2473 (is_box_type): New function (Bug#11768).
2474 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2475 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2476 with default display (Bug#11768).
2477
d6e7bf45
EZ
24782012-07-05 Eli Zaretskii <eliz@gnu.org>
2479
2480 * xdisp.c (window_hscroll_limited): New function.
2481 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2482 coordinates when window's hscroll is set to insanely large
2483 values. (Bug#11857)
2484
431391ec
JB
24852012-07-05 Juanma Barranquero <lekktu@gmail.com>
2486
2487 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2488 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2489
23f86fce
DA
24902012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2491
2492 Cleanup xmalloc.
2493 * lisp.h (xzalloc): New prototype. Omit needless casts.
2494 * alloc.c (xzalloc): New function. Omit needless casts.
2495 * charset.c: Omit needless casts. Convert all calls to
2496 xmalloc with following memset to xzalloc.
2497 * dispnew.c: Likewise.
2498 * fringe.c: Likewise.
2499 * image.c: Likewise.
2500 * sound.c: Likewise.
2501 * term.c: Likewise.
2502 * w32fns.c: Likewise.
2503 * w32font.c: Likewise.
2504 * w32term.c: Likewise.
2505 * xfaces.c: Likewise.
2506 * xfns.c: Likewise.
2507 * xterm.c: Likewise.
2508 * atimer.c: Omit needless casts.
2509 * buffer.c: Likewise.
2510 * callproc.c: Likewise.
2511 * ccl.c: Likewise.
2512 * coding.c: Likewise.
2513 * composite.c: Likewise.
2514 * doc.c: Likewise.
2515 * doprnt.c: Likewise.
2516 * editfns.c: Likewise.
2517 * emacs.c: Likewise.
2518 * eval.c: Likewise.
2519 * filelock.c: Likewise.
2520 * fns.c: Likewise.
2521 * gtkutil.c: Likewise.
2522 * keyboard.c: Likewise.
2523 * lisp.h: Likewise.
2524 * lread.c: Likewise.
2525 * minibuf.c: Likewise.
2526 * msdos.c: Likewise.
2527 * print.c: Likewise.
2528 * process.c: Likewise.
2529 * region-cache.c: Likewise.
2530 * search.c: Likewise.
2531 * sysdep.c: Likewise.
2532 * termcap.c: Likewise.
2533 * terminal.c: Likewise.
2534 * tparam.c: Likewise.
2535 * w16select.c: Likewise.
2536 * w32.c: Likewise.
2537 * w32reg.c: Likewise.
2538 * w32select.c: Likewise.
2539 * w32uniscribe.c: Likewise.
2540 * widget.c: Likewise.
2541 * xdisp.c: Likewise.
2542 * xmenu.c: Likewise.
2543 * xrdb.c: Likewise.
2544 * xselect.c: Likewise.
2545
0497dc44
PE
25462012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2547
2548 * fileio.c (time_error_value): Check the right error number.
2549 Problem reported by Troels Nielsen in
2550 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2551
356e7178
PE
25522012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2553
4e71fd89
PE
2554 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2555 This should be fixed in a better way; see Eli Zaretskii in
2556 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2557 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2558
f0941253
PE
2559 * fileio.c (time_error_value): Rename from special_mtime.
2560 The old name's problems were noted by Eli Zaretskii in
2561 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2562
065c9eb4
PE
2563 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2564 This variable's comment says Emacs needs at least one GDB-visible
2565 symbol of type enum pvec_type, to work around GDB problems.
2566 The symbol's value doesn't matter.
2567
356e7178
PE
2568 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2569 that causes compilation to fail on pre-C99 compilers.
2570
ed9265fc 25712012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2572
2573 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2574 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2575
3884d954
DA
25762012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2577
d209e2fb 2578 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2579 headers for buffer_defaults and buffer_local_symbols.
2580 Reported by Juanma Barranquero <lekktu@gmail.com>.
2581
ee28be33
SM
25822012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2583
2584 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2585 * lisp.h (enum pvec_type): Use fewer bits.
2586 (PSEUDOVECTOR_SIZE_BITS): New constant.
2587 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2588 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2589 change in pvec_type.
2590 (PSEUDOVECTOR_TYPEP): New macro.
2591 (TYPED_PSEUDOVECTORP): Use it.
2592 * fns.c (internal_equal): Adapt code to extract pvectype.
2593 * emacs.c (gdb_pvec_type): Update type.
2594 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2595 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2596 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2597 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2598 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2599 abusing vector->header.next.nbytes.
2600 (live_vector_p): Use PVEC_TYPE.
2601 (mark_object): Adapt code to extract pvectype. Use switch.
2602
c7f2cd7f
PE
26032012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2604
2605 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2606 Tighten new eassert a bit.
2607
8ce70ed2
DA
26082012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2609
2610 Fix compilation with --enable-gcc-warnings and -O1
2611 optimization level.
2612 * doprnt.c (doprnt): Change type of tem to int, initialize
2613 to avoid compiler warning. Add eassert.
2614 * search.c (simple_search): Initialize match_byte to avoid
2615 compiler warning. Add eassert.
2616
dea7f1e5
PE
26172012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2618
24a212eb
PE
2619 Avoid weird behavior with large horizontal scrolls.
2620 Without this change, for example, large hscroll values would
2621 mess up Emacs's display on Fedora 15 x86, presumably due to
2622 overflows in int calculations in the display code.
2623 Also, if buffers had long lines, Emacs would freeze.
2624 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2625 (set_window_hscroll): New function, containing the old guts of
2626 Fset_window_hscroll. Return the clipped value.
2627 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2628 This avoids the need to check against PTRDIFF_MAX.
2629
dea7f1e5
PE
2630 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2631
76046526
DA
26322012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2633
2634 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2635
39adff0d
PE
26362012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2637
63807d47
PE
2638 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2639 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2640 since GCC 4.4.6 issues a bogus warning for them.
2641
39adff0d
PE
2642 Fix bugs in file timestamp newness comparisons.
2643 * fileio.c (Ffile_newer_than_file_p):
2644 * lread.c (Fload): Use full timestamp resolution of files,
2645 not just the 1-second resolution, so that files that are only
2646 slightly newer still count as newer.
2647 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2648 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2649
dbeed9a6
PE
26502012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2651
2652 * fileio.c: Improve handling of file time marker. (Bug#11852)
2653 (special_mtime): New function.
2654 (Finsert_file_contents, Fverify_visited_file_modtime):
2655 Use it to set special mtime values consistently.
2656
636334d6
AS
26572012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2658
2659 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2660 marker for non-existing file. (Bug#11852)
2661
e2017fe2
GM
26622012-07-03 Glenn Morris <rgm@gnu.org>
2663
2664 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2665 and did not make it into globals.h).
2666
404dbd37
TT
26672012-07-03 Tom Tromey <tromey@redhat.com>
2668
2669 * window.c (Fset_window_margins, Fset_window_fringes)
2670 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2671 * textprop.c (Fprevious_property_change): No longer static.
2672 * syntax.c (Fsyntax_table_p): No longer static.
2673 * process.c (Fget_process, Fprocess_datagram_address): No longer
2674 static.
2675 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2676 * keyboard.c (Fcommand_execute): No longer static.
2677 Remove EXFUN.
2678 * insdel.c (Fcombine_after_change_execute): No longer static.
2679 * image.c (Finit_image_library): No longer static.
2680 * fileio.c (Fmake_symbolic_link): No longer static.
2681 * eval.c (Ffetch_bytecode): No longer static.
2682 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2683 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2684 No longer static.
404dbd37
TT
2685 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2686 static.
2687 * dired.c (Ffile_attributes): No longer static.
2688 * composite.c (Fcomposition_get_gstring): No longer static.
2689 * callproc.c (Fgetenv_internal): No longer static.
2690
2691 * ccl.h: Remove EXFUNs.
2692 * buffer.h: Remove EXFUNs.
2693 * dispextern.h: Remove EXFUNs.
2694 * intervals.h: Remove EXFUNs.
2695 * fontset.h: Remove EXFUN.
2696 * font.h: Remove EXFUNs.
2697 * dosfns.c (system_process_attributes): Remove EXFUN.
2698 * keymap.h: Remove EXFUNs.
2699 * lisp.h: Remove EXFUNs.
2700 * w32term.h: Remove EXFUNs.
2701 * window.h: Remove EXFUNs.
2702 * xsettings.h: Remove EXFUN.
2703 * xterm.h: Remove EXFUN.
2704
8e4fd1e1
GM
27052012-07-03 Glenn Morris <rgm@gnu.org>
2706
2707 * lisp.h (Frandom): Make it visible to C.
2708 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2709 buffer for invisible buffers. (Bug#1229)
2710
ca95b3eb
DA
27112012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2712
2713 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2714 values which aren't power of 2.
14ae4239
BT
2715 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
2716 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
2717 accordingly.
2718
7555c33f
SM
27192012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2720
2721 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2722
2723 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2724
d12e8f5a
DA
27252012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2726
2727 * alloc.c (allocate_vector_block): Remove redundant
2728 calls to mallopt if DOUG_LEA_MALLOC is defined.
2729 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2730 avoid calls to mallopt if zero_vector is returned.
2731
296094c3
DA
27322012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2733
2734 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2735 is enabled, avoid dereferencing NULL current_sblock if
2736 running undumped.
2737
36429c89
DA
27382012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2739
2740 Cleanup basic buffer management.
2741 * buffer.h (struct buffer): Change layout to use generic vector
2742 marking code. Fix some comments. Change type of 'clip_changed'
2743 to bitfield. Remove unused #ifndef old.
2744 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2745 (GET_OVERLAYS_AT): Fix indentation.
2746 (for_each_per_buffer_object_at): New macro.
2747 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2748 (Fbuffer_local_variables): Use it.
2749 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2750 * alloc.c (allocate_buffer): Adjust to match new layout of
2751 struct buffer. Fix comment.
2752 (mark_overlay): New function.
2753 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2754 Lisp area of struct buffer.
2755 (mark_object): Use it. Adjust marking of misc objects
2756 and related comments.
2757
3b3e4cac
PE
27582012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2759
2760 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2761 wrapper that is not needed because the wrapped code is a no-op (zero
2762 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2763 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2764
cf5c0175
DA
27652012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2766
2767 * alloc.c (mark_buffer): Simplify. Remove prototype.
2768 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2769 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
2770 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
2771 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 2772
ca26824c
GM
27732012-06-30 Glenn Morris <rgm@gnu.org>
2774
2e4c5312
GM
2775 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2776
ca26824c
GM
2777 * epaths.in (PATH_SITELOADSEARCH): New.
2778 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2779 This is rather than relying on --enable-locallisppath elements
2780 having "site-lisp" in their names. (Bug#10208#25, 11658)
2781
0d23c240
EZ
27822012-06-30 Eli Zaretskii <eliz@gnu.org>
2783
c9240d7a
EZ
2784 * w32proc.c (sys_select): Accept and ignore one more argument.
2785
2786 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2787
0d23c240 2788 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2789 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2790
2791 * sysdep.c: Don't include dos.h and dosfns.h.
2792
2793 * process.c (sys_select):
2794 * msdos.c (sys_select): Accept one more argument and ignore it.
2795
2796 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2797 adapt data types and code to that.
2798
2799 * dosfns.c:
2800 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2801 which clashes with the gnulib function of the same name.
2802
af5a5a98
AS
28032012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2804
c5e4379c
AS
2805 * font.c (font_style_to_value, font_style_symbolic)
2806 (font_prop_validate_style): Add type checks for values in
2807 font_style_table.
2808
af5a5a98
AS
2809 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2810 argument.
2811 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2812 uses.
2813
8d38f461
EZ
28142012-06-29 Eli Zaretskii <eliz@gnu.org>
2815
2e5a6631
EZ
2816 * xdisp.c (try_window_id): Undo last change.
2817
8d38f461
EZ
2818 * w32.c (getwd): Adjust commentary about startup_dir.
2819 (init_environment): Always call sys_access, even in non-MSVC
2820 builds. Don't chdir to the directory of the Emacs executable.
2821 This undoes code from 1997 which was justified by the need to
2822 "avoid conflicts when removing and renaming directories". But its
2823 downside was that every relative file name was being interpreted
2824 relative to the directory of the Emacs executable, which can never
2825 be TRT. In particular, it broke sys_access when called with
2826 relative file names.
2827 (sys_access): Map GetLastError to errno.
2828
2af3565e
DA
28292012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2830
2831 * window.h (struct window): Change type of 'fringes_outside_margins'
2832 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2833 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2834 Adjust comment.
2835 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2836 to ptrdiff_t.
2837
c8d3a25c 28382012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2839
c8d3a25c
GM
2840 * gnutls.c (emacs_gnutls_handshake):
2841 Add QUIT to make the loop interruptible.
57570cd3 2842
c8d3a25c 28432012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2844
c8d3a25c
GM
2845 * charset.c (init_charset): Make lack of etc/charsets fatal.
2846
3e984ee8
DA
28472012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2848
2849 * editfns.c (region_limit): Fix type mismatch.
2850
ef884f23
DA
28512012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2852
2853 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2854 undefined. Convert from xassert to eassert.
2855 * nsmenu.m: Convert from xassert to eassert.
2856 * nsterm.m: Likewise.
2857
7d7e0027
SM
28582012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2859
2860 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2861
aa754e6a
PE
28622012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2863
2864 Avoid integer overflow on scroll-left and scroll-right.
2865 * window.c (HSCROLL_MAX): New macro.
2866 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2867 overflow when requested scroll falls outside ptrdiff_t range.
2868
80b00b08
DA
28692012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2870
2871 * window.h (struct window): Change type of 'hscroll',
2872 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2873 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2874 Adjust users accordingly.
2875 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2876 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2877 from EMACS_INT to ptrdiff_t.
2878 (make_window): Omit redundant initialization.
2879
62b2bcf6
JB
28802012-06-28 Juanma Barranquero <lekktu@gmail.com>
2881
2882 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2883
45942c7d
DA
28842012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2885
2886 * window.h (struct window): Change type of 'use_time' and
2887 'sequence_number' from Lisp_Object to int.
2888 * frame.c (make_frame): Adjust users accordingly.
2889 * print.c (print_object): Likewise.
2890 * window.c (select_window, Fwindow_use_time, make_parent_window)
2891 (make_window): Likewise.
2892
e509cfa6
DA
28932012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2894
2895 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2896 enabled with --enable-checking=[all,glyphs] configure option.
2897 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2898 adjust comments accordingly.
2899 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2900 undefined, adjust comments accordingly.
2901 * image.c: Likewise.
2902 * scroll.c: Likewise.
2903 * w32fns.c: Likewise.
2904 * w32term.c: Likewise.
2905 * xdisp.c: Likewise.
2906 * xfaces.c: Likewise.
2907 * xfns.c: Likewise.
2908 * xterm.c: Likewise.
2909
a54e2c05
DA
29102012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2911
2912 Generalize run-time debugging checks.
2913 * dispextern.h (XASSERTS): Remove.
2914 * fontset.c (xassert): Remove.
2915 Convert from xassert to eassert.
2916 * alloc.c: Convert from xassert to eassert.
2917 * bidi.c: Likewise.
2918 * dispnew.c: Likewise.
2919 * fns.c: Likewise.
2920 * fringe.c: Likewise.
2921 * ftfont.c: Likewise.
2922 * gtkutil.c: Likewise.
2923 * image.c: Likewise.
2924 * keyboard.c: Likewise.
2925 * menu.c: Likewise.
2926 * process.c: Likewise.
2927 * scroll.c: Likewise.
2928 * sound.c: Likewise.
2929 * term.c: Likewise.
2930 * w32console.c: Likewise.
2931 * w32fns.c: Likewise.
2932 * w32term.c: Likewise.
2933 * window.c: Likewise.
2934 * xdisp.c: Likewise.
2935 * xfaces.c: Likewise.
2936 * xfns.c: Likewise.
2937 * xselect.c: Likewise.
2938 * xterm.c: Likewise.
2939
1ec4b7b2
SM
29402012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2941
2942 * fns.c (maybe_resize_hash_table): Output message when growing the
2943 purify-hashtable.
2944
2014308a
DA
29452012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2946
2947 * alloc.c (allocate_string_data): Remove dead code.
2948 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2949 avoid GCC warning about unused macro.
2950
246155eb
DA
29512012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2952
2953 * alloc.c (allocate_string): Omit intervals initialization.
2954 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2955 as in make_pure_string and make_pure_c_string.
2956
43184b7b
DA
29572012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2958
d209e2fb 2959 * alloc.c (allocate_string): Fix last change.
43184b7b 2960
3fe6dd74
DA
29612012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2962
d209e2fb 2963 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2964 to memset, add explicit initialization where appropriate.
2965
1ba6038a
GM
29662012-06-27 Glenn Morris <rgm@gnu.org>
2967
2968 * lisp.mk (lisp): Remove paths.elc.
2969
c89926a5
CY
29702012-06-27 Chong Yidong <cyd@gnu.org>
2971
2972 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2973
ed6b3510
JW
29742012-06-26 John Wiegley <johnw@newartisans.com>
2975
1ec4b7b2 2976 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2977 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2978
ed6b3510
JW
2979 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2980 when building with Clang.
2981
8edd4a2b
SM
29822012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2983
2984 * eval.c (Fapply): Allow calling it with a single argument.
2985
f6f62d1b
EZ
29862012-06-26 Eli Zaretskii <eliz@gnu.org>
2987
2988 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2989 _stricmp and _strnicmp.
2990 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2991
62efea5e
DA
29922012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2993
2994 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2995 allocated window.
2996 (allocate_process): Likewise for new process.
8edd4a2b 2997 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2998 (allocate_frame): Likewise.
2999 * frame.c (make_frame): Omit redundant initialization.
3000 * window.c (make_parent_window): Use memset.
3001 (make_window): Omit redundant initialization.
3002 * process.c (make_process): Omit redundant initialization.
3003 * terminal.c (create_terminal): Likewise.
3004
42997f4d
DA
30052012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3006
3007 * term.c (delete_tty): Remove redundant call to memset.
3008
1130ecfc
DA
30092012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3010
3011 * alloc.c: Remove build_string.
3012 * lisp.h: Define build_string as static inline. This provides
3013 a better opportunity to optimize away calls to strlen when the
3014 function is called with compile-time constant argument.
3015 * image.c (imagemagick_error): Convert to build_string.
3016 * w32proc.c (sys_spawnve): Likewise.
3017 * xterm.c (x_term_init): Likewise.
3018
cf38a720
PE
30192012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3020
99027bdd
PE
3021 Use sprintf return value instead of invoking strlen on result.
3022 In the old days this wasn't portable, since some sprintf
3023 implementations returned char *. But they died out years ago and
3024 Emacs already assumes sprintf returns int.
3025 Similarly for float_to_string.
3026 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3027 * ccl.c (ccl_driver):
3028 * character.c (string_escape_byte8):
3029 * data.c (Fnumber_to_string):
3030 * doprnt.c (doprnt):
3031 * print.c (print_object):
3032 * xdisp.c (message_dolog):
3033 * xfns.c (syms_of_xfns):
3034 Use sprintf or float_to_string result to avoid need to call strlen.
3035 * data.c (Fnumber_to_string):
3036 Use make_unibyte_string, since the string must be ASCII.
3037 * lisp.h, print.c (float_to_string): Now returns int length.
3038 * term.c (produce_glyphless_glyph):
3039 Use sprintf result rather than recomputing it.
3040
cf38a720
PE
3041 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3042 * Makefile.in (ALL_CFLAGS):
3043 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3044 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3045
3511c784
DA
30462012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3047
0a08eb21 3048 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3049 strcasecmp if available.
3050 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3051
fb7da12e
AS
30522012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3053
3054 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3055 Avoid comma operator.
3056 * menu.c (push_submenu_start, push_submenu_end)
3057 (push_left_right_boundary, push_menu_pane): Likewise.
3058 * msdos.c (dos_rawgetc): Likewise.
3059
afa2ffd8
DA
30602012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3061
3062 * xfns.c (xic_create_fontsetname): Remove redundant calls
3063 to memset.
3064
b3b4476b
PE
30652012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3066
4495ff38
PE
3067 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3068 sprintf already null-terminates its output.
3069
b3b4476b
PE
3070 * xfns.c (x_window): Remove redundant cast.
3071
b00876c9
DA
30722012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3073
3074 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3075 `const char *' to `char *' to avoid compiler warning.
3076
d188e26b
PE
30772012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3078
885d1d74
PE
3079 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3080 instead of truncating it to 63 (admittedly a generous limit).
3081
d188e26b
PE
3082 * process.c: Fix spelling and caps in comments.
3083
e2f560b1
DN
30842012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3085
e86db54b 3086 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3087 * sysdep.c (setpgrp): Remove definition, not used in this file.
3088
7583a3a1
JB
30892012-06-24 Juanma Barranquero <lekktu@gmail.com>
3090
3091 * makefile.w32-in: Update dependencies.
3092
696056c2
EZ
30932012-06-24 Eli Zaretskii <eliz@gnu.org>
3094
3095 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3096 (SYSTIME_H): Add nt/inc/sys/time.h.
3097
3098 * systime.h [WINDOWSNT]: Include sys/time.h.
3099
3100 * s/ms-w32.h (struct timespec): Definition moved from
3101 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3102
845ca893
PE
31032012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3104
3105 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3106 * buffer.h (buffer_slot_type_mismatch):
3107 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3108 * eval.c (unwind_to_catch):
3109 * image.c (my_png_error, my_error_exit):
3110 * keyboard.c (quit_throw_to_read_char, user_error)
3111 (Fexit_recursive_edit, Fabort_recursive_edit):
3112 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3113 (wrong_type_argument, buffer_overflow, __executable_start)
3114 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3115 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3116 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3117 (fatal):
3118 (child_setup) [!DOS_NT]:
3119 * lread.c (end_of_file_error, invalid_syntax):
3120 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3121 * puresize.h (pure_write_error):
3122 * search.c (matcher_overflow):
3123 * sound.c (sound_perror, alsa_sound_perror):
3124 * sysdep.c, syssignal.h (croak):
3125 * term.c (maybe_fatal, vfatal):
3126 * textprop.c (text_read_only):
3127 * undo.c (user_error):
3128 * unexmacosx.c (unexec_error):
3129 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3130 Use _Noreturn rather than NO_RETURN.
3131 No need for separate decl merely because of _Noreturn.
3132 * sound.c (sound_warning, parse_sound):
3133 Remove unnecessary forward decls.
3134
f1dd8073
PE
31352012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3136
3137 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3138 * lisp.h (WAIT_READING_MAX): New macro.
3139 * dispnew.c (Fsleep_for, sit_for):
3140 * keyboard.c (kbd_buffer_get_event):
3141 * process.c (Faccept_process_output):
3142 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3143 This improves on the previous patch, which introduced a bug
3144 when time_t is unsigned and as wide as intmax_t.
3145 See <http://bugs.gnu.org/9000#51>.
3146
b82c1755
EZ
31472012-06-23 Eli Zaretskii <eliz@gnu.org>
3148
3149 * dispnew.c (sit_for, Fsleep_for):
3150 * keyboard.c (kbd_buffer_get_event):
3151 * process.c (Faccept_process_output): Avoid compiler warnings when
3152 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3153
ca300656
JB
31542012-06-23 Juanma Barranquero <lekktu@gmail.com>
3155
049ec95b
JB
3156 * makefile.w32-in: Update dependencies.
3157
ca300656
JB
3158 * w32.c (ltime): Add return type and declare static.
3159 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3160
db7b8d06
PE
31612012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3162
3163 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3164 Privately reported by Herbert J. Skuhra.
3165 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3166 All uses changed.
3167 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3168 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3169
0bd8297f
EZ
31702012-06-23 Eli Zaretskii <eliz@gnu.org>
3171
96512555
EZ
3172 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3173 last argument of make_unibyte_string.
3174
0bd8297f
EZ
3175 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3176 language ID in the event parameters.
3177
3178 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3179 event.code, not the obscure "character set ID".
3180
63def6b6
CY
31812012-06-23 Chong Yidong <cyd@gnu.org>
3182
3183 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3184
e8a02204
EZ
31852012-06-23 Eli Zaretskii <eliz@gnu.org>
3186
388cdec0
EZ
3187 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3188 * w32.c (fdutimens): New function.
3189
3190 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3191
3192 * s/ms-w32.h (pselect): Redirect to sys_select.
3193
3194 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3195
e8a02204
EZ
3196 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3197 in the logic of incrementing and decrementing the value of
3198 use_relocatable_buffers.
3199
d054f3fb
PE
32002012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3201
3202 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3203 Privately reported by Herbert J. Skuhra.
3204 [__FreeBSD__]: Remove "*/" typo after "#include".
3205 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3206 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3207 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3208 Don't assume EMACS_TIME and struct timeval are the same type.
3209
d35af63c
PE
32102012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3211
3212 Support higher-resolution time stamps (Bug#9000).
3213 The time stamps are only nanosecond-resolution at the C level,
3214 since that's the best that any real-world system supports now.
3215 But they are picosecond-resolution at the Lisp level, as that's
3216 easy, and leaves room for future OS improvements.
3217
3218 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3219 (LIBES): Use it.
3220
3221 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3222 Don't get current time unless it's needed.
3223
3224 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3225 now provides it if it's absent.
3226 (start_atimer): Port to higher-res time stamps.
3227 Check for time stamp overflow. Don't get current time more
3228 often than is needed.
3229
3230 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3231 Include systime.h, not time.h.
3232 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3233
3234 * dired.c: Include stat-time.h.
3235 (Ffile-attributes): File times now have higher resolution.
3236
3237 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3238 (struct image): Timestamp now has higher resolution.
3239
3240 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3241 has at least microseconds now. All uses removed.
3242 (update_frame, update_single_window, update_window, update_frame_1)
3243 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3244
3245 * editfns.c (time_overflow): Now extern.
3246 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3247 (float-time, Fformat_time_string, Fcurrent_time_string)
3248 (Fcurrent_time_zone): Accept and generate higher-resolution
3249 time stamps.
3250 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3251 (decode_time_components, lisp_seconds_argument): New functions.
3252 (make_time): Now static.
3253 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3254 Report an error if the time is invalid, rather than having the caller
3255 do that.
3256
3257 * fileio.c: Include <stat-time.h>
3258 (Fcopy_file): Copy higher-resolution time stamps.
3259 Prefer to set the time stamp via a file descriptor if that works.
3260 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3261 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3262 (Fvisited_file_modtime, Fset_visited_file_modtime):
3263 Support higher-resolution time stamps.
3264
3265 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3266
3267 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3268
3269 * image.c (prepare_image_for_display, clear_image_cache)
3270 (lookup_image): Port to higer-resolution time stamps.
3271
3272 * keyboard.c (start_polling, bind_polling_period):
3273 Check for time stamp overflow.
3274 (read_char, kbd_buffer_get_event, timer_start_idle)
3275 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3276 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3277 Port to higher-resolution time stamps. Do not assume time_t is signed.
3278 (decode_timer): New function. Timers are now vectors of length 9,
3279 not 8, to accommodate the picosecond component.
3280 (timer_check_2): Use it.
3281
3282 * nsterm.m (select_timeout, timeval_subtract): Remove.
3283 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3284 as they're a bit more accurate and handle overflow better.
3285 (ns_select): Change prototype to be compatible with pselect.
3286 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3287 * nsterm.h (ns_select): Adjust prototype.
3288
3289 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3290 us-resolution time stamps.
3291 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3292
3293 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3294
3295 * lisp.h (time_overflow): New decl.
3296 (wait_reading_process_output): First arg is now intmax_t, not int,
3297 to accommodate larger waits.
3298
3299 * process.h (struct Lisp_Process.read_output_delay):
3300 Now counts nanoseconds, not microseconds.
3301 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3302 EMACS_HAS_USECS.
3303 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3304 (wait_reading_process_output):
3305 Port to ns-resolution time stamps.
3306 (Faccept_process_output, wait_reading_process_output):
3307 Check for time stamp overflow. Do not assume time_t is signed.
3308 (select_wrapper): Remove; we now use pselect.
3309 (Fprocess_attributes): Now generates ns-resolution time stamps.
3310
3311 * sysdep.c: Include utimens.h. Don't include utime.h
3312 or worry about struct utimbuf; gnulib does that for us now.
3313 (gettimeofday): Remove; gnulib provides a substitute.
3314 (make_timeval): New function.
3315 (set_file_times): Now sets ns-resolution time stamps.
3316 New arg FD; all uses changed.
3317 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3318 (system_process_attributes):
3319 Now returns ns-resolution time stamp. All uses changed.
3320 Check for time stamp overflow.
3321
3322 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3323 provides a substitute now.
3324
3325 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3326 since it guarantees struct timespec.
3327 (EMACS_TIME): Now struct timespec, so that we can support
3328 ns-resolution time stamps.
3329 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3330 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3331 (EMACS_USECS): Remove.
3332 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3333 so multiply the arg by 1000 before storing it.
3334 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3335 New macros.
3336 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3337 Port to ns-resolution time stamps.
3338 (EMACS_TIME_NEG_P): Remove; replaced by....
3339 (EMACS_TIME_SIGN): New macro.
3340 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3341 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3342 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3343 (make_timeval, make_lisp_time, decode_time_components): New decls.
3344 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3345 that it mishandled time_t overflow. You can't compare by subtracting!
3346 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3347 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3348
3349 * term.c: Include <sys/time.h>.
3350 (timeval_to_Time): New function, for proper overflow wraparound.
3351 (term_mouse_position, term_mouse_click): Use it.
3352
3353 * undo.c (record_first_change): Support higher-resolution time stamps
3354 in the undo buffer.
3355 (Fprimitive_undo): Use them when restoring time stamps.
3356
3357 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3358 (w32_get_internal_run_time):
3359 Port to higher-resolution Emacs time stamps.
3360 (ltime): Now accepts single 64-bit integer, as that's more convenient
3361 for callers.
3362
3363 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3364
3365 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3366 for compatibility with pselect. Support ns-resolution time stamps.
3367
3368 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3369
3370 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3371 Check for time stamp overflow, and support ns-resolution time stamps.
3372
3373 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3374 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3375 (timeval_subtract): Remove; no longer needed.
3376 (XTflash, XTring_bell, x_wait_for_event):
3377 Port to ns-resolution time stamps. Don't assume time_t is signed.
3378
b6a92dfe
CY
33792012-06-22 Chong Yidong <cyd@gnu.org>
3380
3381 * xdisp.c (x_consider_frame_title): Revert last change.
3382
d251c37c
EZ
33832012-06-22 Eli Zaretskii <eliz@gnu.org>
3384
3385 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3386 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3387 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3388 staticidx goes up to 1597 out of 1600 = 0x640.)
3389
f10deafb
PE
33902012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3391
3392 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3393 Otherwise, the umask might be mistakenly 0 while handling input signals.
3394
ec6de1e2
SM
33952012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3396
3397 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3398
28be1ada
DA
33992012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3400
3401 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3402 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3403 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3404 access to `contents' member of Lisp_Vector objects with AREF and ASET
3405 where appropriate.
3406
c6bf3022
CY
34072012-06-19 Chong Yidong <cyd@gnu.org>
3408
3409 * frame.c (delete_frame): When selecting a frame on a different
3410 text terminal, do not alter the terminal's top-frame.
3411
3412 * xdisp.c (format_mode_line_unwind_data): Record the target
3413 frame's selected window and its terminal's top-frame.
3414 (unwind_format_mode_line): Restore them.
3415 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3416 Callers changed.
3417 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3418 since tty frames can be explicitly named.
3419 (prepare_menu_bars): Likewise.
3420
3421 * term.c (Ftty_top_frame): New function.
3422
defd4196
PE
34232012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3424
3425 Port byte-code-meter to modern targets.
3426 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3427 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3428 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3429 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3430 (METER_1, METER_2): Simplify.
3431
1053a871
SM
34322012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3433
3434 * data.c (Fdefalias): Return `symbol' (bug#11686).
3435
b7e8d081
MR
34362012-06-18 Martin Rudalics <rudalics@gmx.at>
3437
3438 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3439 gets killed during executing of this function (Bug#11665).
3440 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3441 (Vkill_buffer_query_functions): In doc-string say that functions
3442 run by this hook should not change the current buffer.
3443
7ea2b339
PE
34442012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3445
3446 Fix recently-introduced process.c problems found by static checking.
3447 * process.c (write_queue_push, write_queue_pop, send_process):
3448 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3449 (write_queue_pop): Fix pointer signedness problem.
3450 (send_process): Remove unused local.
3451
96a313a1
CY
34522012-06-17 Chong Yidong <cyd@gnu.org>
3453
3454 * xdisp.c (redisplay_internal): No need to redisplay terminal
3455 frames that are not on top.
3456
20ca2e94
TN
34572012-06-17 Troels Nielsen <bn.troels@gmail.com>
3458
3459 * process.c (make_process): Initialize write_queue.
3460 (write_queue_push, write_queue_pop): New functions.
3461 (send_process): Use them to maintain correct ordering of process
3462 writes (Bug#10815).
3463
9a900ca9
PE
34642012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3465
310fbfa8
PE
3466 * lisp.h (eassert): Assume C89 or later.
3467 This removes the need for CHECK.
3468 (CHECK): Remove. Its comments about always evaluating its
3469 argument were confusing, as 'eassert' typically does not evaluate
3470 its argument.
3471
27bb1ca4
PE
3472 * coding.c (produce_chars): Use ptrdiff_t, not int.
3473
9a900ca9
PE
3474 * xterm.c (x_draw_underwave): Check for integer overflow.
3475 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3476
41b7f8bc 34772012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3478
3479 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3480 referenced (Bug#11583).
3481
9b0e3eba
AA
34822012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3483
3484 Implement wave-style variant of underlining.
3485 * dispextern.h (face_underline_type): New enum.
3486 (face): Add field for underline type.
3487 * nsterm.m (ns_draw_underwave): New function.
3488 (ns_draw_text_decoration): Use it.
3489 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3490 New functions.
3491 (x_draw_glyph_string): Use them.
3492 * xfaces.c (Qline, Qwave): New Lisp objects.
3493 (check_lface_attrs, merge_face_ref)
1053a871
SM
3494 (Finternal_set_lisp_face_attribute, realize_x_face):
3495 Handle wave-style underline face attributes.
9b0e3eba
AA
3496 * xterm.c (x_draw_underwave): New function.
3497 (x_draw_glyph_string): Use it.
3498
0fb52f11
JB
34992012-06-16 Juanma Barranquero <lekktu@gmail.com>
3500
3501 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3502 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3503 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3504 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3505 ($(BLD)/w32select.$(O)): Update dependencies.
3506
e5560ff7
AS
35072012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3508
3509 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3510 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3511 * character.c (_fetch_multibyte_char_p): Remove.
3512 * alloc.c: Include "character.h" before "buffer.h".
3513 * bidi.c: Likewise.
3514 * buffer.c: Likewise.
3515 * bytecode.c: Likewise.
3516 * callint.c: Likewise.
3517 * callproc.c: Likewise.
3518 * casefiddle.c: Likewise.
3519 * casetab.c: Likewise.
3520 * category.c: Likewise.
3521 * cmds.c: Likewise.
3522 * coding.c: Likewise.
3523 * composite.c: Likewise.
3524 * dired.c: Likewise.
3525 * dispnew.c: Likewise.
3526 * doc.c: Likewise.
3527 * dosfns.c: Likewise.
3528 * editfns.c: Likewise.
3529 * emacs.c: Likewise.
3530 * fileio.c: Likewise.
3531 * filelock.c: Likewise.
3532 * font.c: Likewise.
3533 * fontset.c: Likewise.
3534 * fringe.c: Likewise.
3535 * indent.c: Likewise.
3536 * insdel.c: Likewise.
3537 * intervals.c: Likewise.
3538 * keyboard.c: Likewise.
3539 * keymap.c: Likewise.
3540 * lread.c: Likewise.
3541 * macros.c: Likewise.
3542 * marker.c: Likewise.
3543 * minibuf.c: Likewise.
3544 * nsfns.m: Likewise.
3545 * nsmenu.m: Likewise.
3546 * print.c: Likewise.
3547 * process.c: Likewise.
3548 * regex.c: Likewise.
3549 * region-cache.c: Likewise.
3550 * search.c: Likewise.
3551 * syntax.c: Likewise.
3552 * term.c: Likewise.
3553 * textprop.c: Likewise.
3554 * undo.c: Likewise.
3555 * unexsol.c: Likewise.
3556 * w16select.c: Likewise.
3557 * w32fns.c: Likewise.
3558 * w32menu.c: Likewise.
3559 * window.c: Likewise.
3560 * xdisp.c: Likewise.
3561 * xfns.c: Likewise.
3562 * xmenu.c: Likewise.
3563 * xml.c: Likewise.
3564 * xselect.c: Likewise.
3565
2f07e6af
EZ
35662012-06-16 Eli Zaretskii <eliz@gnu.org>
3567
1053a871
SM
3568 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3569 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3570 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3571 row.
3572 (handle_face_prop): Use chunk-relative overlay string index when
3573 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3574 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3575 the rightmost. (Bug#11720)
2f07e6af 3576
29b83cec
AS
35772012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3578
3579 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3580 (CATEGORY_MEMBER): Enforce 1/0 value.
3581 * category.c (_temp_category_set): Remove.
3582
4c5501e9
EZ
35832012-06-16 Eli Zaretskii <eliz@gnu.org>
3584
3585 * window.c (Fdelete_other_windows_internal)
3586 (Fdelete_window_internal): Don't access frame's mouse highlight
3587 info of the initial frame. (Bug#11677)
3588
2b570124
PE
35892012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3590
e93864f9
PE
3591 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3592 Assume USE_2_TAGS_FOR_INTS.
3593 (xreload): Adjust $tagmask width to match recent lisp.h change.
3594
2b570124
PE
3595 Simplify lisp.h in minor ways that should not affect code.
3596 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3597 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3598 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3599 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3600 (INTTYPEBITS): New macro, for clarity.
3601 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3602 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3603 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3604 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3605 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3606
81755f69
JB
36072012-06-13 Juanma Barranquero <lekktu@gmail.com>
3608
3609 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3610
16192a57
GM
36112012-06-13 Glenn Morris <rgm@gnu.org>
3612
3613 * s/bsd-common.h (BSD4_3):
3614 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3615
646b5f55
AS
36162012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3617
3618 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3619 instead of union.
3620 (XLI, XIL): Define.
1053a871
SM
3621 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3622 Use them.
3623 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3624 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3625 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3626 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3627 * frame.c (delete_frame): Remove outdated comment.
3628 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3629 USE_LISP_UNION_TYPE.
3630 (Fw32_unregister_hot_key): Likewise.
3631 (Fw32_toggle_lock_key): Likewise.
3632 * w32menu.c (add_menu_item): Likewise.
3633 (w32_menu_display_help): Use XIL instead of checking
3634 USE_LISP_UNION_TYPE.
3635 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3636 (init_heap): Likewise.
3637 * w32term.c (w32_read_socket): Update comment.
3638
1d3823c9
GM
36392012-06-13 Glenn Morris <rgm@gnu.org>
3640
c62ff706
GM
3641 * s/usg5-4-common.h, src/s/unixware.h:
3642 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3643
1d3823c9
GM
3644 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3645
bfe3e0a2
PE
36462012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3647
3648 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3649 * alloc.c (make_number) [!defined make_number]:
3650 Remove, as lisp.h always defines this now.
3651 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3652 (roundup_size): Verify that it is a power of 2.
3653 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3654 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3655 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3656 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3657 USE_LSB_TAG now is always defined to be either 0 or 1.
3658 All uses changed.
3659 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3660 code works fine either way, and efficiency is not a concern here,
3661 as the union type is for debugging, not for production.
3662 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3663 Use an inline function on all platforms when using the union type,
3664 since this is simpler and 'static inline' can be used portably
3665 within Emacs now.
3666 (LISP_INITIALLY_ZERO): New macro.
3667 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3668 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3669
45fa9c0f
GM
36702012-06-12 Glenn Morris <rgm@gnu.org>
3671
b4492cba
GM
3672 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3673
3674 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3675
45fa9c0f
GM
3676 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3677 Move BROKEN_SIGIO to configure.
3678
3679 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3680 Move NO_TERMIO to configure.
3681
0e25d334
CY
36822012-06-12 Chong Yidong <cyd@gnu.org>
3683
3684 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3685 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3686 MagickExportImagePixels is undefined.
3687
43682bb6
PE
36882012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3689
3690 * image.c (imagemagick_load_image): Remove unused label.
3691
a9be7d2b
GM
36922012-06-11 Glenn Morris <rgm@gnu.org>
3693
3694 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3695 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3696 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3697 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3698
3017f87f
SM
36992012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3700
3701 * alloc.c (make_byte_code): New function.
3702 (Fmake_byte_code): Use it. Don't purify here.
3703 * lread.c (read1): Use it as well to avoid extra allocation.
3704
1b9b4cf4
CY
37052012-06-11 Chong Yidong <cyd@gnu.org>
3706
3707 * image.c (imagemagick_load_image): Implement transparency.
3708
95988fcf
AS
37092012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3710
3711 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3712 account for preceding backslashes. (Bug#11663)
3713
cd4eb164
CY
37142012-06-09 Chong Yidong <cyd@gnu.org>
3715
3716 * term.c: Support italics in capable terminals (Bug#9652).
3717 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3718 (turn_on_face): Output using TS_enter_italic_mode if available.
3719 Don't handle unused blinking and alt-charset cases.
3720 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3721 and tty_alt_charset_p cases.
3722 (tty_capable_p, init_tty): Support italics.
3723
3724 * termchar.h (struct tty_display_info): Add field for italics.
3725 Remove unused blink field.
3726
3727 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3728 Handle slant.
3729
3730 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3731 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3732 tty_alt_charset_p. Add tty_italic_p.
3733
ff88beb8
MA
37342012-06-09 Michael Albinus <michael.albinus@gmx.de>
3735
3736 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3737 dbus_type_is_basic if available.
3738 (xd_extract_signed, xd_extract_unsigned): Rename from
3739 extract_signed and extract_unsigned, respectively. Adapt callers.
3740
44286096
CY
37412012-06-09 Chong Yidong <cyd@gnu.org>
3742
1682701f
CY
3743 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3744
44286096
CY
3745 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3746 case (Bug#9752).
3747
d86feb17
PE
37482012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3749
3750 * xdisp.c (vmessage): Treat frame message as multibyte.
3751 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3752 would generate the diagnostic "Making \302\247 buffer-local while
3753 let-bound!".
3754
d5c20fe8
EZ
37552012-06-08 Eli Zaretskii <eliz@gnu.org>
3756
3757 * dispnew.c (showing_window_margins_p): Undo last change, which
3758 was done due to an inadvertent commit.
3759 (adjust_frame_glyphs_for_frame_redisplay): Do call
3760 showing_window_margins_p.
3761
513749ee
SM
37622012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3763
3764 * eval.c (Fmake_var_non_special): New primitive.
3765 (syms_of_eval): Defsubr it.
3766 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3767
d4a8f5c1
JB
37682012-06-08 Juanma Barranquero <lekktu@gmail.com>
3769
3770 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3771 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3772
8bbbc977
EZ
37732012-06-08 Eli Zaretskii <eliz@gnu.org>
3774
3775 * alloc.c (allocate_vectorlike): Fix last change.
3776
f3372c87
DA
37772012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3778
3779 Block-based vector allocation of small vectors.
3780 * lisp.h (struct vectorlike_header): New field `nbytes',
3781 adjust comment accordingly.
3782 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3783 to denote vector blocks. Adjust users (live_vector_p,
3784 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3785 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3786 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3787 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3788 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3789 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3790 (roundup_size): New constant.
3791 (struct vector_block): New data type.
3792 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3793 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3794 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3795 (sweep_vectors): New functions.
3796 (allocate_vectorlike): Return `zero_vector' as the only vector of
3797 0 items. Allocate new vector from block if vector size is less than
3798 or equal to VBLOCK_BYTES_MAX.
3799 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3800 (init_alloc_once): Add call to init_vectors.
3801
4f18a4ed
SM
38022012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3803
3804 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3805
86f158bc
PE
38062012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3807
3808 * doprnt.c (doprnt): Truncate multibyte char correctly.
3809 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3810 would mishandle a string argument "Xc" if X was a multibyte
3811 character of length 2: it would truncate after X's first byte
3812 rather than including all of X.
3813
c5cfcbe0
CY
38142012-06-06 Chong Yidong <cyd@gnu.org>
3815
3816 * buffer.c (word_wrap): Doc fix.
3817
c05cf390
PE
38182012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3819
3820 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3821
0c3461de
GM
38222012-06-03 Glenn Morris <rgm@gnu.org>
3823
3824 * xdisp.c (tool-bar-style): Doc fix.
3825
c71232db
UM
38262012-06-03 Ulrich Müller <ulm@gentoo.org>
3827
3828 * Makefile.in (PAXCTL): Define.
3829 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3830 binary via PaX flags if the paxctl utility is available.
3831 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3832 Restore PaX flags to their default. (Bug#11398)
3833
383f7350
CY
38342012-06-03 Chong Yidong <cyd@gnu.org>
3835
3836 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3837 buffer (Bug#11226).
3838
5f2c76c6
CY
38392012-06-03 Chong Yidong <cyd@gnu.org>
3840
3841 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3842 (note_mode_line_or_margin_highlight): If there is no help echo,
3843 use mode-line-default-help-echo. Handle the case where the mouse
3844 position is past the end of the mode line string.
3845
3846 * buffer.c (buffer_local_value_1): New function, split from
3847 Fbuffer_local_value; can return Qunbound.
3848 (Fbuffer_local_value): Use it.
3849 (Vmode_line_format): Docstring tweaks.
3850
773d47f6
PE
38512012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3852
3853 * sysdep.c (system_process_attributes): Improve comment.
3854
f2d6a3df
SM
38552012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3856
3857 * keyboard.c: Export real-this-command to Elisp.
3858 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3859 and DEFVAR it. Update all users.
3860
63810350
PE
38612012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3862
7bd5c1f4
PE
3863 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3864
63810350
PE
3865 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3866 Convert pctcpu and pctmem to Lisp float properly.
3867 Let the compiler fold better, as 100.0/0x8000 is exact.
3868
a2821611
AS
38692012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3870
3871 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3872 cons_block.
3873
5fceba1d
PE
38742012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3875
3876 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3877
c98ff5dd
DA
38782012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3879
3880 For a 'struct window', replace some Lisp_Object fields to
3881 bitfields where appropriate, remove unused fields.
3882 * window.h (struct window): Remove unused 'last_mark_x' and
3883 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3884 change it's type from Lisp_Object to bitfield.
3885 Change type of 'force_start', 'optional_new_start',
3886 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3887 fields from Lisp_Object to bitfield. Adjust users accordingly.
3888
ca34e0be
PE
38892012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3890
3891 Pacify gcc -Wdouble-precision when using Xaw.
3892 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3893 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3894 Use 'float' consistently, rather than 'float' in most places
3895 and 'double' in a couple of places.
3896
efc00ab1 38972012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3898
3899 * xdisp.c (handle_stop): Detect whether we have overlay strings
3900 loaded by testing it->current.overlay_string_index to be
3901 non-negative, instead of checking whether n_overlay_strings is
3902 positive. (Bug#11587)
3903
efc00ab1 39042012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3905
3906 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3907
3908 * doc.c (Fsubstitute_command_keys): Doc fix.
3909
efc00ab1 39102012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3911
3912 * search.c (search_buffer): Remove calls to
3913 r_alloc_inhibit_buffer_relocation, as it is now called by
3914 maybe_unify_char, which was the cause of relocation of buffer text
3915 in bug#11519.
3916
efc00ab1 39172012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3918
3919 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3920 for the duration of call to load_charset, to avoid problems with
3921 callers of maybe_unify_char that access buffer text through C
3922 pointers.
3923
3924 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3925 decrement the inhibition flag, instead of just setting or
3926 resetting it.
3927
ba93a187
PE
39282012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3929
3930 Remove obsolete '#define static' cruft.
3931 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3932 This #undef was "temporary" in 2000; it is no longer needed
3933 now that '#define static' has gone away.
3934 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3935 (gray_bitmap_bits): Remove; no longer needed.
3936 All uses replaced with definiens.
3937 * xterm.c: Include "bitmaps/gray.xbm".
3938
9e4bf381
PE
39392012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3940
3941 Clean up __executable_start, monstartup when --enable-profiling.
3942 The following changes affect the code only when profiling.
3943 * dispnew.c (__executable_start): Rename from safe_bcopy.
3944 Define only on platforms that need it.
3945 * emacs.c: Include <sys/gmon.h> when profiling.
3946 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3947 (__executable_start): Remove decl, since lisp.h does it now.
3948 (safe_bcopy): Remove decl; no longer has that name.
3949 (main): Coalesce #if into single bit of code, for simplicity.
3950 Cast pointers to uintptr_t, since standard libraries want integers
3951 and not pointers.
3952 * lisp.h (__executable_start): New decl.
3953
32d72c2f
GM
39542012-05-31 Glenn Morris <rgm@gnu.org>
3955
3956 * image.c (Fimagemagick_types): Doc fix.
3957
baac5bc7
JM
39582012-05-30 Jim Meyering <meyering@redhat.com>
3959
3960 * callproc.c (Fcall_process_region): Include directory component
3961 in mkstemp error message (Bug#11586).
3962
72cb32cf
PE
39632012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3964
3965 * alloc.c, lisp.h (make_pure_vector): Now static.
3966
61b108cc
SM
39672012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3968
3969 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3970 Move to byte-run.el.
3971 (Fautoload): Do the hash-doc more carefully.
3972 * data.c (Fdefalias): Purify definition, except for keymaps.
3973 (Qdefun): Move from eval.c.
3974 * lisp.h (Qdefun): Remove.
3975 * lread.c (read1): Tiny simplification.
3976
471fe23d
TN
39772012-05-29 Troels Nielsen <bn.troels@gmail.com>
3978
934f3f58 3979 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3980 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3981 Bug#9642, but explicitly check that the buffer the overlay would
3982 be moved to is live and rearrange lines to make sure that errors
3983 will not put the overlay in an inconsistent state.
3984 (Fdelete_overlay): Cosmetics.
3985
85d0efd1
EZ
39862012-05-28 Eli Zaretskii <eliz@gnu.org>
3987
3988 * w32term.c (my_bring_window_to_top): New function.
3989 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3990 could be different from the original one.
3991 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3992 (Bug#11513)
3993
3994 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3995 by calling BringWindowToTop.
3996
3997 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3998 (WM_EMACS_END): Increase by one.
3999
da92a98c
PE
40002012-05-28 Paul Eggert <eggert@cs.ucla.edu>
4001
4002 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4003 This avoids undefined behavior that might cause the eassert
4004 to not catch an out-of-range value.
4005
74d1f848
JB
40062012-05-28 Juanma Barranquero <lekktu@gmail.com>
4007
4008 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4009 Update dependencies.
4010
9e1a06fc
EZ
40112012-05-27 Eli Zaretskii <eliz@gnu.org>
4012
4013 * bidi.c (bidi_mirror_char): Fix last change.
4014
f3dd7312
AS
40152012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4016
4017 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4018 when referring to sectname field in printf format.
4019
81899c91
PE
40202012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4021
57b81a9f
PE
4022 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4023 Only r_alloc_inhibit_buffer_relocation needed to be added;
4024 the others were already declared.
4025
81899c91
PE
4026 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4027 before checking whether it's out of range. Put the check inside
4028 eassert. See
4029 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4030
33017faf 40312012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4032
4033 * callproc.c (Fcall_process): Restore a line that was accidentally
4034 commented out in the 2011-02-13 change (bug#11547).
4035
33017faf 40362012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4037
4038 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4039 defined on ralloc.c.
4040
4041 * buffer.c [REL_ALLOC]: Remove prototypes of
4042 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4043 they are now on lisp.h.
4044
4045 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4046
4047 * search.c (search_buffer): Use it to inhibit relocation of buffer
4048 text while re_search_2 is doing its job, because re_search_2 is
4049 passed C pointers to buffer text. (Bug#11519)
4050
23415acf
EZ
4051 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4052 Update value to 24.
4053
44e27368
EZ
4054 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4055 state after an additional call to move_it_in_display_line_to, keep
4056 the values of it->max_ascent and it->max_descent found for the
4057 entire line.
4058 (pos_visible_p): Revert the comparison against bottom_y to what it
4059 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4060 (Bug#11464)
4061
c1892f11
PE
40622012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4063
4064 Fix coding-related core dumps with gcc -ftrapv.
4065 The code was computing A - B, where A and B are pointers, and B is
4066 random garbage. This can lead to core dumps on platforms that
4067 have special pointer registers, and it also leads to core dumps on
4068 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4069 A - B only when B is initialized properly.
4070 * coding.c (coding_set_source, coding_set_destination): Return void.
4071 (coding_change_source, coding_change_destinations): New functions,
4072 with the old behaviors of coding_set_source and coding_set_destination.
4073 All callers that need an offset changed to use these new functions.
4074
eb7afdad
GM
40752012-05-26 Glenn Morris <rgm@gnu.org>
4076
4077 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4078
f12fdf02
EZ
40792012-05-26 Eli Zaretskii <eliz@gnu.org>
4080
53a63be6 4081 Extend mouse support on W32 text-mode console.
61b108cc
SM
4082 * xdisp.c (draw_row_with_mouse_face):
4083 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4084
eb3f6f01 4085 * w32console.c: Include window.h.
61b108cc
SM
4086 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4087 New functions.
eb3f6f01
EZ
4088 (initialize_w32_display): Initialize mouse-highlight data.
4089
53a63be6
EZ
4090 * w32inevt.c: Include termchar.h and window.h.
4091 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4092 moves, call note_mouse_highlight. If help_echo changed, call
4093 gen_help_event to produce help-echo message in the echo area.
4094 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4095 highlight info.
4096
4cfd81f6
PE
40972012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4098
4099 * lread.c (read1): Simplify slightly to avoid an overflow warning
4100 with GCC 4.7.0 on x86-64.
4101
4446092a
EZ
41022012-05-26 Eli Zaretskii <eliz@gnu.org>
4103
4104 * bidi.c (bidi_mirror_char): Revert last change: an int is
4105 definitely wide enough here.
4106
42b2a986 41072012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4108
42b2a986 4109 Fix integer width and related bugs (Bug#9874).
eb106a49 4110 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4111 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4112 (string_bytes, check_sblock, allocate_string_data):
4113 (compact_small_strings, Fmake_bool_vector, make_string)
4114 (make_unibyte_string, make_multibyte_string)
4115 (make_string_from_bytes, make_specified_string)
4116 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4117 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4118 (mark_vectorlike):
4119 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4120 (allocate_pseudovector):
4121 Use int, not EMACS_INT, where int is wide enough.
4122 (inhibit_garbage_collection, Fgarbage_collect):
4123 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4124 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4125 int might not be wide enough.
4126 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4127 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4128 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4129 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4130 (bidi_level_of_next_char, bidi_move_to_visually_next):
4131 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4132 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4133 (Fkill_buffer, Fset_buffer_major_mode)
4134 (advance_to_char_boundary, Fbuffer_swap_text)
4135 (Fset_buffer_multibyte, overlays_at, overlays_in)
4136 (overlay_touches_p, struct sortvec, record_overlay_string)
4137 (overlay_strings, recenter_overlay_lists)
4138 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4139 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4140 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4141 (Foverlay_recenter, last_overlay_modification_hooks_used)
4142 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4143 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4144 (validate_region): Omit unnecessary test for b <= e,
4145 since that's guaranteed by the previous test.
d311d28c
PE
4146 (adjust_overlays_for_delete): Avoid pos + length overflow.
4147 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4148 (report_overlay_modification):
4149 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4150 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4151 Omit pointer cast, which isn't needed anyway, and doesn't work
4152 after the EMACS_INT -> ptrdiff_t change.
02481186 4153 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4154 * buffer.h: Adjust decls to match defn changes elsewhere.
4155 (struct buffer_text, struct buffer):
4156 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4157 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4158 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4159 not int, to avoid needless 32-bit limit on 64-bit hosts.
4160 (exec_byte_code): Use tighter memory-full test, one that checks
4161 for alloca overflow. Don't compute the address of the object just
4162 before an array, as that's not portable. Use EMACS_INT, not
4163 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4164 * callint.c (Fcall_interactively):
4165 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4166 * callproc.c (call_process_kill, Fcall_process):
4167 Don't assume pid_t fits into an Emacs fixnum.
4168 (call_process_cleanup, Fcall_process, child_setup):
4169 Don't assume pid_t fits into int.
4170 (call_process_cleanup, Fcall_process, delete_temp_file)
4171 (Fcall_process_region):
4172 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4173 (Fcall_process): Simplify handling of volatile integers.
4174 Use int, not EMACS_INT, where int will do.
4175 * casefiddle.c (casify_object, casify_region, operate_on_word)
4176 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4177 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4178 (casify_object): Avoid integer overflow when overallocating buffer.
4179 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4180 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4181 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4182 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4183 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4184 integers are now checked earlier. All uses replaced with XINT.
4185 (ccl_driver):
4186 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4187 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4188 (ccl_driver, Fregister_code_conversion_map):
4189 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4190 (resolve_symbol_ccl_program): Check that vector header is in range.
4191 Always copy the vector, so that we can check its contents reliably
4192 now rather than having to recheck each instruction as it's being
4193 executed. Check that vector words fit in 'int'.
4194 (ccl_get_compiled_code, Fregister_ccl_program)
4195 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4196 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4197 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4198 contents are in range.
4199 (Fccl_execute_on_string): Check that status is in range.
4200 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4201 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4202 Accept and return EMACS_INT, not int, because callers can pass values
4203 out of 'int' range.
4204 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4205 (multibyte_chars_in_text, parse_str_as_multibyte)
4206 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4207 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4208 (string_escape_byte8, Fget_byte):
4209 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4210 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4211 avoid mishandling large integers.
4212 * character.h: Adjust decls to match defn changes elsewhere.
4213 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4214 (Ffind_charset_region):
4215 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4216 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4217 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4218 Don't assume fixnum fits in int.
d311d28c
PE
4219 (load_charset_map_from_vector, Fmap_charset_chars):
4220 Remove now-unnecessary CHECK_NATNUMs.
4221 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4222 Don't rely on undefined behavior with signed left shift overflow.
4223 Don't assume unsigned int fits into fixnum, or that fixnum fits
4224 into unsigned int. Don't require max_code to be a valid fixnum;
4225 that's not true for gb10830 4-byte on a 32-bit host. Allow
4226 invalid_code to be a cons, for the same reason. Require code_offset
4227 to be a character. Avoid int overflow if max_char is close
4228 to INT_MAX.
4229 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4230 this is intended anyway and avoids some undefined behavior.
4231 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4232 INDEX_TO_CODE_POINT, as that's what it expects.
4233 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4234 * charset.h (DECODE_CHAR): Return int, not unsigned;
4235 this is what was intended anyway, and it avoids undefined behavior.
4236 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4237 integer-overflow issues.
4238 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4239 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4240 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4241 * chartab.c (Fmake_char_table, Fset_char_table_range)
4242 (uniprop_get_decoder, uniprop_get_encoder):
4243 Don't assume fixnum fits in int.
4244 * cmds.c (move_point): New function, that does the gist of
4245 Fforward_char and Fbackward_char, but does so while checking
4246 for integer overflow more accurately.
c96e5d6a 4247 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4248 (Fforward_line, Fend_of_line, internal_self_insert)
4249 (internal_self_insert):
4250 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4251 Fix a FIXME, by checking for integer overflow when calculating
4252 target_clm and actual_clm.
4253 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4254 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4255 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4256 (coding_alloc_by_making_gap, alloc_destination)
4257 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4258 (encode_coding_utf_16, detect_coding_emacs_mule)
4259 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4260 (detect_coding_iso_2022, decode_coding_iso_2022)
4261 (encode_invocation_designation, encode_designation_at_bol)
4262 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4263 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4264 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4265 (encode_coding_ccl, encode_coding_raw_text)
4266 (detect_coding_charset, decode_coding_charset)
4267 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4268 (produce_composition, produce_charset, produce_annotation)
4269 (decode_coding, handle_composition_annotation)
4270 (handle_charset_annotation, consume_chars, decode_coding_gap)
4271 (decode_coding_object, encode_coding_object, detect_coding_system)
4272 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4273 (code_convert_region, code_convert_string)
8f50130c
PE
4274 (Fdefine_coding_system_internal)
4275 (coding_set_source, coding_set_destination):
d311d28c
PE
4276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4277 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4278 (Fdefine_coding_system_internal):
4279 Don't assume fixnums fit in int.
4280 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4281 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4282 (Funencodable_char_position, Fcheck_coding_systems_region)
4283 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4284 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4285 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4286 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4287 Don't access memory outside of the args array.
d311d28c 4288 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4289 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4290 result of ENCODE_CHAR.
d311d28c
PE
4291 * coding.h: Adjust decls to match defn changes elsewhere.
4292 (struct coding_system):
4293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4294 * composite.c (get_composition_id, find_composition)
4295 (run_composition_function, update_compositions)
4296 (compose_text, composition_gstring_put_cache)
4297 (composition_gstring_p, composition_gstring_width)
4298 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4299 (composition_compute_stop_pos, composition_reseat_it)
4300 (composition_update_it, struct position_record)
4301 (find_automatic_composition, composition_adjust_point)
4302 (Fcomposition_get_gstring, Ffind_composition_internal):
4303 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4304 (update_compositions):
4305 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4306 * composite.h: Adjust decls to match defn changes elsewhere.
4307 (struct composition):
4308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4309 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4310 Do not attempt to compute the address of the object just before a
4311 buffer; this is not portable.
4312 (Faref, Faset):
4313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4314 (Faset): Use int, not EMACS_INT, where int is wide enough.
4315 (Fstring_to_number): Don't assume fixnums fit in int.
4316 (Frem): Don't assume arg is nonnegative.
4317 * dbusbind.c (xd_append_arg): Check for integers out of range.
4318 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4319 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4320 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4321 (xd_get_connection_references): Return ptrdiff_t, not int.
4322 All uses changed.
4323 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4324 (xd_read_message_1):
4325 Use int, not unsigned, where the dbus API uses int.
4326 (Fdbus_message_internal): Don't overflow mtype.
4327 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4328 * dired.c (directory_files_internal, file_name_completion, scmp)
4329 (file_name_completion_stat):
4330 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4331 (file_name_completion): Don't overflow matchcount.
4332 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4333 * dispextern.h: Adjust decls to match defn changes elsewhere.
4334 (struct text_pos, struct glyph, struct bidi_saved_info)
4335 (struct bidi_string_data, struct bidi_it, struct composition_it)
4336 (struct it):
4337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4338 (struct display_pos, struct composition_it, struct it):
4339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4340 * dispnew.c (increment_matrix_positions)
4341 (increment_row_positions, mode_line_string)
4342 (marginal_area_string):
4343 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4344 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4346 (duration_to_sec_usec): New function, to check for overflow better.
4347 (Fsleep_for, sit_for): Use it.
4348 * doc.c (get_doc_string, store_function_docstring):
4349 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4350 (get_doc_string, Fsnarf_documentation):
4351 Use int, not EMACS_INT, where int is wide enough.
4352 (get_doc_string):
4353 Use SAFE_ALLOCA, not alloca.
4354 Check for overflow when converting EMACS_INT to off_t.
4355 * doprnt.c (doprnt):
4356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4357 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4358 Don't assume uid_t fits into fixnum.
4359 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4360 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4361 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4362 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4363 (general_insert_function)
4364 (Finsert_char, make_buffer_string, make_buffer_string_both)
4365 (update_buffer_properties, Fbuffer_substring)
4366 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4367 (Fsubst_char_in_region, check_translation)
4368 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4369 (transpose_markers, Ftranspose_regions):
4370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4371 (clip_to_bounds): Move to lisp.h as an inline function).
4372 (Fconstrain_to_field): Don't assume integers are nonnegative.
4373 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4374 (Fsubst_char_in_region, Fsave_restriction):
4375 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4376 (Femacs_pid): Don't assume pid_t fits into fixnum.
4377 (lo_time): Use int, not EMACS_INT, when int suffices.
4378 (lisp_time_argument): Check for usec out of range.
4379 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4380 (Fuser_login_name, Fuser_full_name): Signal an error
4381 if a uid argument is out of range, rather than relying on
4382 undefined behavior.
c8d5c857
PE
4383 (Fformat_time_string): Remove now-unnecessary check.
4384 lisp_time_argument checks for out-of-range usec now.
243e0530 4385 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4386 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4387 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4388 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4389 (init_cmdargs, Fdump_emacs):
4390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4391 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4392 the bottom (typically) 32 bits of the fixnum.
4393 * eval.c (specpdl_size, call_debugger):
4394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4395 (when_entered_debugger, Fbacktrace_debug):
4396 Don't assume fixnum can fit in int.
4397 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4398 the object just before a buffer; this is not portable.
4399 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4400 (grow_specpdl, unbind_to):
4401 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4402 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4403 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4404 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4405 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4406 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4407 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4408 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4409 (a_write, e_write):
4410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4411 (Fcopy_file, non_regular_nbytes, read_non_regular)
4412 (Finsert_file_contents):
4413 Use int, not EMACS_INT, where int is wide enough.
4414 (READ_BUF_SIZE): Verify that it fits in int.
4415 (Finsert_file_contents): Check that counts are in proper range,
4416 rather than assuming fixnums fit into ptrdiff_t etc.
4417 Don't assume fixnums fit into int.
125b3835 4418 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4419 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4420 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4421 (string_char_to_byte, string_byte_to_char)
4422 (string_make_multibyte, string_to_multibyte)
4423 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4424 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4425 (substring_both, Fdelete, internal_equal, Ffillarray)
4426 (Fclear_string, mapcar1)
4427 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4428 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4429 (larger_vector, make_hash_table, maybe_resize_hash_table)
4430 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4431 (Fmaphash, secure_hash):
4432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4433 (concat): Check for string index and length overflow.
4434 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4435 (Frequire):
4436 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4437 (larger_vector): New API (vec, incr_min, size_max) replaces old
4438 one (vec, new_size, init). This catches size overflow.
4439 INIT was removed because it was always Qnil.
4440 All callers changed.
4441 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4442 the upper bound on a hash table index size.
4443 (make_hash_table, maybe_resize_hash_table): Use it.
4444 (secure_hash): Computer start_byte and end_byte only after
4445 they're known to be in ptrdiff_t range.
4446 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4447 (Ffont_get_glyphs, Ffont_at):
4448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4449 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4450 (Flist_fonts, Fopen_font):
4451 Don't assume fixnum can fit in int.
4452 (check_gstring): Don't assume index can fit in int.
4453 (font_match_p): Check that fixnum is a character, not a nonnegative
4454 fixnum, since the later code needs to stuff it into an int.
4455 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4456 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4457 conversion overflow issues.
4458 (Fopen_font): Check for integer out of range.
4459 (Ffont_get_glyphs): Don't assume index can fit in int.
4460 * font.h: Adjust decls to match defn changes elsewhere.
4461 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4462 integer overflow.
4463 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4464 printmax_t, where ptrdiff_t is wide enough.
4465 (Finternal_char_font):
4466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4467 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4468 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4469 (Fset_frame_position, x_set_frame_parameters)
4470 (x_set_line_spacing, x_set_border_width)
4471 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4472 Check that fixnums are in proper range for system types.
4473 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4474 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4475 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4476 Use SAFE_ALLOCA_LISP, not alloca.
4477 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4478 intptr_t is wide enough.
4479 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4480 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4481 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4482 Check for fixnum out of range.
4483 * ftfont.c (ftfont_list): Don't assume index fits in int.
4484 Check that fixnums are in proper range for system types.
4485 (ftfont_shape_by_flt):
4486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4487 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4489 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4490 Check that fixnums are in proper range for system types.
4491 * gnutls.h: Adjust decls to match defn changes elsewhere.
4492 * gtkutil.c (xg_dialog_run):
4493 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4494 (update_frame_tool_bar):
4495 Check that fixnums are in proper range for system types.
4496 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4497 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4498 * indent.c (last_known_column, last_known_column_point):
4499 (current_column_bol_cache):
4500 (skip_invisible, current_column, check_display_width):
4501 (check_display_width, scan_for_column, current_column_1)
4502 (Findent_to, Fcurrent_indentation, position_indentation)
4503 (indented_beyond_p, Fmove_to_column, compute_motion):
4504 (Fcompute_motion, Fvertical_motion):
4505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4506 (last_known_column_modified): Use EMACS_INT, not int.
4507 (check_display_width):
4508 (Fcompute_motion):
4509 Check that fixnums and floats are in proper range for system types.
4510 (compute_motion): Don't assume index or fixnum fits in int.
4511 (compute_motion, Fcompute_motion):
4512 Use int, not EMACS_INT, when it is wide enough.
4513 (vmotion): Omit local var start_hpos that is always 0; that way
4514 we don't need to worry about overflow in expressions involving it.
4515 * indent.h: Adjust decls to match defn changes elsewhere.
4516 (struct position):
4517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4518 Use int, not EMACS_INT, where int is wide enough.
4519 Remove unused members ovstring_chars_done and tab_offset;
4520 all uses removed.
4521 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4522 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4523 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4524 (make_gap, copy_text, insert, insert_and_inherit)
4525 (insert_before_markers, insert_before_markers_and_inherit)
4526 (insert_1, count_combining_before, count_combining_after)
4527 (insert_1_both, insert_from_string)
4528 (insert_from_string_before_markers, insert_from_string_1)
4529 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4530 (adjust_after_replace, adjust_after_insert, replace_range)
4531 (replace_range_2, del_range, del_range_1, del_range_byte)
4532 (del_range_both, del_range_2, modify_region)
4533 (prepare_to_modify_buffer, signal_before_change)
4534 (signal_after_change, Fcombine_after_change_execute):
4535 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4536 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4537 (balance_an_interval, split_interval_right, split_interval_left)
4538 (find_interval, next_interval, update_interval)
4539 (adjust_intervals_for_insertion, delete_node, delete_interval)
4540 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4541 (static_offset_intervals, offset_intervals)
4542 (merge_interval_right, merge_interval_left, make_new_interval)
4543 (graft_intervals_into_buffer, temp_set_point_both)
4544 (temp_set_point, set_point, adjust_for_invis_intang)
4545 (set_point_both, move_if_not_intangible, get_property_and_range)
4546 (get_local_map, copy_intervals, copy_intervals_to_string)
4547 (compare_string_intervals, set_intervals_multibyte_1):
4548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4549 * intervals.h: Adjust decls to match defn changes elsewhere.
4550 (struct interval):
4551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4552 * keyboard.c (this_command_key_count, this_single_command_key_start)
4553 (before_command_key_count, before_command_echo_length, echo_now)
4554 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4555 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4556 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4557 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4559 (last_non_minibuf_size, last_point_position, echo_truncate)
4560 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4561 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4562 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4563 (stuff_buffered_input):
4564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4565 (last_auto_save, command_loop_1, read_char):
4566 Use EMACS_INT, not int, to avoid integer overflow.
4567 (record_char): Avoid overflow in total_keys computation.
4568 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4569 * keyboard.h: Adjust decls to match defn changes elsewhere.
4570 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4571 (Fkey_description, Fdescribe_vector, Flookup_key):
4572 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4573 (click_position): New function, to check that positions are in range.
4574 (Fcurrent_active_maps):
4575 (describe_command):
4576 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4577 (Faccessible_keymaps, Fkey_description):
4578 (preferred_sequence_p):
4579 Don't assume fixnum can fit into int.
4580 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4581 Check for integer overflow in size calculations.
4582 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4583 avoid mishandling large integers.
4584 * lisp.h: Adjust decls to match defn changes elsewhere.
4585 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4586 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4587 (struct Lisp_Marker):
4588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4589 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4590 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4591 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4592 All callers changed.
4593 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4594 Assume the arg has valid form, since it always does.
4595 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4596 unsigned integer system type.
4597 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4598 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4600 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4601 (duration_to_sec_usec): New decl.
4602 * lread.c (read_from_string_index, read_from_string_index_byte)
4603 (read_from_string_limit, readchar, unreadchar, openp)
4604 (read_internal_start, read1, oblookup):
4605 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4606 (Fload, readevalloop, Feval_buffer, Feval_region):
4607 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4608 (openp): Check for out-of-range argument to 'access'.
4609 (read1): Use int, not EMACS_INT, where int is wide enough.
4610 Don't assume fixnum fits into int.
6efdadfd 4611 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4612 (read_filtered_event): Use duration_to_sec_usec
4613 to do proper overflow checking on durations.
d311d28c
PE
4614 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4615 in size calculation.
4616 (Fexecute_kbd_macro):
4617 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4618 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4619 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4620 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4621 (set_marker_both, set_marker_restricted_both, marker_position)
4622 (marker_byte_position, Fbuffer_has_markers_at):
4623 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4624 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4625 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4626 It now merely ensures that the menu is large enough, without
4627 necessarily growing it, as this avoids some integer overflow issues.
4628 All callers changed.
4629 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4630 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4631 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4632 Use SAFE_ALLOCA_LISP, not alloca.
4633 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4634 to EMACS_INT. Check that fixnums are in proper range for system types.
4635 * minibuf.c (minibuf_prompt_width, string_to_object)
4636 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4637 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4639 (get_minibuffer, read_minibuf_unwind):
4640 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4641 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4642 this simplifies overflow checking. All callers changed.
4643 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4644 (Ftest_completion):
4645 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4646 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4647 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4648 Check that fixnums are in proper range for system types.
4649 (Fx_create_frame, Fx_show_tip):
4650 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4651 * nsfont.m (ns_findfonts, nsfont_list_family):
4652 Don't assume fixnum fits in long.
4653 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4655 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4656 wide enough.
17fdb222 4657 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4658 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4659 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4660 (PRINTDECLARE, PRINTPREPARE):
4661 (strout, print_string):
4662 (print, print_preprocess, print_check_string_charset_prop)
4663 (print_object):
4664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4665 (PRINTDECLARE):
4666 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4668 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4669 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4670 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4671 (print_error_message): Use SAFE_ALLOCA, not alloca.
4672 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4673 (print_depth, new_backquote_output, print_number_index):
4674 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4675 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4676 (Fset_process_window_size, Fformat_network_address)
4677 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4678 (sigchld_handler):
d311d28c 4679 Check that fixnums are in proper range for system types.
d44287d4 4680 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4681 Check for process-ids out of pid_t range rather than relying on
4682 undefined behavior.
e4d81efc 4683 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4684 (Fformat_network_address, read_process_output, send_process)
4685 (Fprocess_send_region, status_notify):
4686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4687 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4688 (wait_reading_process_output, read_process_output, exec_sentinel):
4689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4690 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4691 (Faccept_process_output): Use duration_to_sec_usec to do proper
4692 overflow checking on durations.
dde14581
PE
4693 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4694 Don't assume pid_t fits in int.
02481186
PE
4695 * process.h (struct Lisp_Process): Members tick and update_tick
4696 are now of type EMACS_INT, not int.
b62b53e8
PE
4697 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4698 configured --with-wide-int.
d311d28c
PE
4699 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4700 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4701 * search.c (looking_at_1, string_match_1):
4702 (fast_string_match, fast_c_string_match_ignore_case)
4703 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4704 (scan_newline, find_before_next_newline, search_command)
4705 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4706 (set_search_regs, wordify):
4707 (Freplace_match):
4708 (Fmatch_data):
4709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4710 (string_match_1, search_buffer, set_search_regs):
4711 (Fmatch_data):
4712 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4713 (wordify): Check for overflow in size calculation.
4714 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4715 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4716 Check that fixnums are in proper range for system types.
4717 * sound.c (struct sound_device)
4718 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4720 (Fplay_sound_internal):
4721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4722 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4723 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4724 (Fparse_partial_sexp):
4725 Don't assume fixnums can fit in int.
4726 (struct lisp_parse_state, find_start_pos, find_start_value)
4727 (find_start_value_byte, find_start_begv)
4728 (update_syntax_table, char_quoted, dec_bytepos)
4729 (find_defun_start, prev_char_comend_first, back_comment):
4730 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4731 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4732 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4733 (Finternal_describe_syntax_value): Check that match_lisp is a
4734 character, not an integer, since the code stuffs it into int.
4735 (scan_words, scan_sexps_forward):
4736 Check that fixnums are in proper range for system types.
4737 (Fforward_word):
4738 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4739 (scan_sexps_forward):
4740 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4741 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4742 * syntax.h: Adjust decls to match defn changes elsewhere.
4743 (struct gl_state_s):
4744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4745 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4746 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4747 * sysdep.c (wait_for_termination_1, wait_for_termination)
4748 (interruptible_wait_for_termination, mkdir):
4749 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4750 (emacs_read, emacs_write):
4751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4752 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4753 and double all fit in int.
d311d28c
PE
4754 * term.c (set_tty_color_mode):
4755 Check that fixnums are in proper range for system types.
4756 * termhooks.h (struct input_event):
4757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4758 * textprop.c (validate_interval_range, interval_of)
4759 (Fadd_text_properties, set_text_properties_1)
4760 (Fremove_text_properties, Fremove_list_of_text_properties)
4761 (Ftext_property_any, Ftext_property_not_all)
4762 (copy_text_properties, text_property_list, extend_property_ranges)
4763 (verify_interval_modification):
4764 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4765 (Fnext_single_char_property_change)
4766 (Fprevious_single_char_property_change):
4767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4768 (copy_text_properties):
4769 Check for integer overflow in index calculation.
d311d28c
PE
4770 * undo.c (last_boundary_position, record_point, record_insert)
4771 (record_delete, record_marker_adjustment, record_change)
4772 (record_property_change):
4773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4774 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4776 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4777 (Fx_hide_tip, Fx_file_dialog):
4778 * w32menu.c (set_frame_menubar):
4779 Use ptrdiff_t, not int, for consistency with rest of code.
4780 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4781 (select_window, Fdelete_other_windows_internal)
4782 (window_scroll_pixel_based, window_scroll_line_based)
4783 (Frecenter, Fset_window_configuration):
4784 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4785 (Fset_window_hscroll, run_window_configuration_change_hook)
4786 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4787 (Fscroll_other_window, Frecenter):
d311d28c
PE
4788 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4789 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4790 Don't assume fixnum fits in int.
4791 (Fset_window_scroll_bars):
4792 Check that fixnums are in proper range for system types.
4793 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4794 (string_pos, c_string_pos, number_of_chars, init_iterator)
4795 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4796 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4797 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4798 (face_before_or_after_it_pos, handle_invisible_prop)
4799 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4800 (display_prop_intangible_p, string_buffer_position_lim)
4801 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4802 (get_overlay_strings_1, get_overlay_strings)
4803 (iterate_out_of_display_property, forward_to_next_line_start)
4804 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4805 (get_next_display_element, set_iterator_to_next)
4806 (get_visually_first_element, compute_stop_pos_backwards)
4807 (handle_stop_backwards, next_element_from_buffer)
4808 (move_it_in_display_line_to, move_it_in_display_line)
4809 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4810 (add_to_log, message_dolog, message_log_check_duplicate)
4811 (message2, message2_nolog, message3, message3_nolog
4812 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4813 (current_message_1, truncate_echo_area, truncate_message_1)
4814 (set_message, set_message_1, store_mode_line_noprop)
4815 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4816 (text_outside_line_unchanged_p, check_point_in_composition)
4817 (reconsider_clip_changes)
4818 (redisplay_internal, set_cursor_from_row, try_scrolling)
4819 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4820 (redisplay_window, find_last_unchanged_at_beg_row)
4821 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4822 (trailing_whitespace_p, find_row_edges, display_line)
4823 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4824 (display_mode_element, store_mode_line_string)
4825 (pint2str, pint2hrstr, decode_mode_spec)
4826 (display_count_lines, display_string, draw_glyphs)
4827 (x_produce_glyphs, x_insert_glyphs)
4828 (rows_from_pos_range, mouse_face_from_buffer_pos)
4829 (fast_find_string_pos, mouse_face_from_string_pos)
4830 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4831 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4832 (safe_call, init_from_display_pos, handle_fontified_prop)
4833 (handle_single_display_spec, load_overlay_strings)
4834 (with_echo_area_buffer, setup_echo_area_for_printing)
4835 (display_echo_area, echo_area_display)
4836 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4837 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4838 (redisplay_window, dump_glyph_row, display_mode_line)
4839 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4840 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4842 (handle_single_display_spec, build_desired_tool_bar_string)
4843 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4844 (get_specified_cursor_type):
4845 Check that fixnums are in proper range for system types.
4846 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4847 (Flookup_image_map):
4848 Don't assume fixnums fit in int.
4849 (compare_overlay_entries):
4850 Avoid mishandling comparisons due to subtraction overflow.
4851 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4852 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4853 (handle_tool_bar_click):
4854 Use int, not unsigned, since we prefer signed and the signedness
4855 doesn't matter here.
4856 (get_next_display_element, next_element_from_display_vector):
4857 Use int, not EMACS_INT, when int is wide enough.
4858 (start_hourglass): Use duration_to_sec_usec to do proper
4859 overflow checking on durations.
4860 * xfaces.c (Fbitmap_spec_p):
4861 Check that fixnums are in proper range for system types.
4862 (compare_fonts_by_sort_order):
4863 Avoid mishandling comparisons due to subtraction overflow.
4864 (Fx_family_fonts, realize_basic_faces):
4865 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4866 (Fx_family_fonts):
4867 Don't assume fixnum fits in int.
4868 Use SAFE_ALLOCA_LISP, not alloca.
4869 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4870 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4871 (face_at_buffer_position, face_for_overlay_string)
4872 (face_at_string_position):
4873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4874 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4875 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4876 (Fx_show_tip):
4877 Check that fixnums are in proper range for system types.
4878 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4879 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4881 (Fx_change_window_property): Don't assume fixnums fit in int.
4882 * xfont.c (xfont_chars_supported):
4883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4884 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4885 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4886 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4887 * xml.c (parse_region):
4888 * xrdb.c (magic_file_p):
4889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4890 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4891 (x_get_local_selection, x_reply_selection_request)
4892 (x_handle_selection_request, wait_for_property_change):
4893 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4894 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4895 short is wide enough.
4896 (x_send_client_event): Don't assume fixnum fits in int.
4897 * xterm.c (x_x_to_emacs_modifiers):
4898 Don't assume EMACS_INT overflows nicely into int.
4899 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4900 may come from Lisp.
4901 (handle_one_xevent): NATNUMP can eval its arg twice.
4902 (x_connection_closed):
4903 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4904 * xterm.h: Adjust decls to match defn changes elsewhere.
4905 (struct scroll_bar): Use struct vectorlike_header
4906 rather than rolling our own approximation.
4907 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4908
c6574eb5
GM
49092012-05-25 Glenn Morris <rgm@gnu.org>
4910
4911 * lisp.mk (lisp): Update for more files being compiled now.
4912
e8d32c7e
SM
49132012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4914
48def666
SM
4915 * lread.c: Remove `read_pure' which makes no difference.
4916 (read_pure): Remove var.
4917 (unreadpure): Remove function.
4918 (readevalloop): Don't call read_list with -1 flag.
4919 (read1, read_vector): Don't test read_pure any more.
4920 (read_list): Simplify.
4921
e8d32c7e
SM
4922 * fileio.c, character.h: Minor style tweaks.
4923
4b2addb7
DA
49242012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4925
4926 * window.h (clip_changed): Remove useless declaration.
4927
584461b2
JB
49282012-05-22 Juanma Barranquero <lekktu@gmail.com>
4929
4930 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4931 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4932
34374650
PE
49332012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4934
4935 Remove src/m/*.
4936 This directory predates autoconf and is no longer needed nowadays.
4937 Move its few remaining bits of functionality to where they're needed.
4938 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4939 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4940 * m/template.h: Remove.
4941 * Makefile.in (M_FILE): Remove. All uses removed.
4942 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4943 * lisp.h (USE_LSB_TAG):
4944 * mem-limits.h (EXCEEDS_LISP_PTR):
4945 Use VAL_MAX, not VALBITS, in #if.
4946 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4947 (EMACS_UINT): Define unconditionally now.
4948 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4949 (BITS_PER_EMACS_INT): New constants, replacing
4950 what used to be in config.h, but not useful in #if.
4951 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4952 define them any more.
4953 (VAL_MAX): New macro.
4954 (VALMASK): Use it.
4955 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4956 BITS_PER_EMACS_INT, in #if.
4957 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4958 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4959 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4960 * s/ms-w32.h (DATA_START):
4961 Move here from removed file m/intel386.h.
4962 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4963 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4964
261cb4bb
PE
49652012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4966
4967 Assume C89 or later.
4968 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4969 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4970 (xrealloc):
4971 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4972 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4973 * textprop.c, tparam.c (NULL): Remove.
4974 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4975 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4976 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4977 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4978 * xterm.c (input_signal_count): Assume volatile works.
4979
ff23cd9f
KB
49802012-05-21 Ken Brown <kbrown@cornell.edu>
4981
4982 * xgselect.c (xg_select): Fix first argument in call to 'select'
4983 (bug#11508).
4984
1b170bc6
KB
49852012-05-20 Ken Brown <kbrown@cornell.edu>
4986
4987 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4988 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4989
b2f4d39f
KB
49902012-05-19 Ken Brown <kbrown@cornell.edu>
4991
4992 * xfns.c (x_in_use): Remove `static' qualifier.
4993 * xterm.h (x_in_use): Declare.
4994 * xgselect.c: Include xterm.h.
4995 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4996 and `display_arg' (bug#9754).
4997
003fdae2
PE
49982012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4999
9232a6d9
PE
5000 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5001
003fdae2
PE
5002 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
5003 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5004
784b56e2
EZ
50052012-05-18 Eli Zaretskii <eliz@gnu.org>
5006
5007 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5008
5009 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5010 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5011
5012 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5013 reference to image_cache->refcount.
5014 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5015
a0a79cde
JL
50162012-05-17 Juri Linkov <juri@jurta.org>
5017
5018 * search.c (Fword_search_regexp, Fword_search_backward)
5019 (Fword_search_forward, Fword_search_backward_lax)
5020 (Fword_search_forward_lax): Move functions to isearch.el
5021 (bug#10145, bug#11381).
5022
b0572523
PE
50232012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5024
5025 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5026
9660f5fc
SM
50272012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5028
5029 * lread.c (init_obarray): Declare Qt and Qnil as special.
5030
4374de83
GM
50312012-05-14 Glenn Morris <rgm@gnu.org>
5032
5033 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5034 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5035
dc44c39a
PE
50362012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5037
078c97cb
PE
5038 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5039
dc44c39a
PE
5040 * unexaix.c: Port to more-recent AIX compilers.
5041 (report_error, report_error_1, make_hdr, copy_sym)
5042 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5043 Make arguments const char *, not char *, to avoid violations of C
5044 standard and to fix some AIX warnings reported by Gilles Pion.
5045
e18afed7 50462012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5047
5048 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5049 already have overlays loaded.
5050 (handle_single_display_spec): Before returning without displaying
5051 fringe bitmap, synchronize the bidi iterator with the main display
5052 iterator, by calling iterate_out_of_display_property.
5053 (iterate_out_of_display_property): Detect buffer iteration by
5054 testing that it->string is a Lisp string.
5055 (get_next_display_element): When the current object is exhausted,
5056 and there's something on it->stack, call set_iterator_to_next to
5057 proceed with what's on the stack, instead of returning zero.
5058 (set_iterator_to_next): If called at the end of a Lisp string,
5059 proceed to consider_string_end without incrementing string
5060 position. Don't increment display vector index past the end of
5061 the display vector. (Bug#11417)
c8fb9dc6
EZ
5062 (pos_visible_p): Don't report a position visible when move_it_to
5063 stopped at the last line of window, which happens to be scanned
5064 backwards by the bidi iteration. (Bug#11464)
ac268e67 5065
e18afed7 50662012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5067
5068 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5069 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5070 are on a TTY, and thus unable to display on the fringes.
5071 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5072 so we need to signal to the caller that this is a "replacing"
5073 display spec. This fixes display when the spec is invalid or we
5074 are on a TTY.
5075
e18afed7 50762012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5077
5078 * unexaix.c (make_hdr): Fix typo in prototype.
5079 This bug broke the build on AIX. Problem reported by Gilles Pion.
5080
9d0a235a
MA
50812012-05-14 Michael Albinus <michael.albinus@gmx.de>
5082
5083 * keyboard.c (kbd_buffer_get_event): Read special events also in
5084 batch mode. (Bug#11415)
5085
9e6b06ed
GM
50862012-05-12 Glenn Morris <rgm@gnu.org>
5087
5088 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5089
c1a1d7a3
EZ
50902012-05-12 Eli Zaretskii <eliz@gnu.org>
5091
5092 * lisp.mk (lisp): Add newcomment.elc.
5093
3fe7cdc8
GM
50942012-05-12 Glenn Morris <rgm@gnu.org>
5095
5096 * Makefile.in (MKDIR_P): New, set by configure.
5097 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5098
53f7d2c0
PE
50992012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5100
5101 Remove unused function hourglass_started.
5102 * dispextern.h (hourglass_started):
5103 * w32fns.c (hourglass_started):
5104 * xdisp.c (hourglass_started): Remove.
5105
75aafb17
JB
51062012-05-10 Juanma Barranquero <lekktu@gmail.com>
5107
5108 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5109 Update dependencies.
5110
12959e8e
PE
51112012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5112
97107e2e
PE
5113 * xgselect.c (xg_select): Put maxfds+1 into a var.
5114 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5115
12959e8e
PE
5116 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5117
836d29b3
DA
51182012-05-10 Dave Abrahams <dave@boostpro.com>
5119
5120 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5121 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5122
5cb67954
MA
51232012-05-09 Michael Albinus <michael.albinus@gmx.de>
5124
5125 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5126 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5127 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5128 Initialize xd_registered_buses.
5129
3478ec45
PE
51302012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5131
b263a6b0
PE
5132 Untag more efficiently if USE_LSB_TAG.
5133 This is based on a proposal by YAMAMOTO Mitsuharu in
5134 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5135 For an admittedly artificial (nth 8000 longlist) benchmark on
5136 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5137 Emacs's overall text size by 1%.
5138 * lisp.h (XUNTAG): New macro.
5139 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5140 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5141 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5142 * eval.c (Fautoload):
5143 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5144 * frame.h (XFRAME): Use XUNTAG.
5145
3478ec45
PE
5146 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5147 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5148 Remove unportable assumptions about print widths of types like
5149 dbus_uint32_t.
5150 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5151 intptr_t when converting between pointer and integer, to avoid GCC
5152 warnings about wrong width.
5153
666b903b 51542012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5155
5156 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5157 stack for each reader_thread, instead of defaulting to 8MB
5158 determined by the linker. This avoids failures in creating
5159 subprocesses on Windows 7, see the discussion in this thread:
5160 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5161
b120cc17
JC
51622012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5163
5164 Fix up display of the *Minibuf-0* buffer in the mini window.
5165 * keyboard.c (read_char): Don't clear the echo area if there's no
5166 message to clear.
5167 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5168 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5169
9a4b36f8
MA
51702012-05-07 Michael Albinus <michael.albinus@gmx.de>
5171
5172 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5173 batch mode.
5174
e5f9458f
CY
51752012-05-06 Chong Yidong <cyd@gnu.org>
5176
5177 * lisp.mk (lisp): Update.
5178
eceeb5fc 51792012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5180
5181 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5182
71873e2b
SM
51832012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5184
5185 * data.c (PUT_ERROR): New macro.
5186 (syms_of_data): Use it. Add new error type `user-error'.
5187 * undo.c (user_error): New function.
5188 (Fprimitive_undo): Use it.
5189 * print.c (print_error_message): Adjust print style for `user-error'.
5190 * keyboard.c (user_error): New function.
5191 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5192
ab0fa4e4
PE
51932012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5194
5195 Do not limit current-time-string to years 1000..9999.
5196 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5197 (Fcurrent_time_string): Support any year that is supported by the
5198 underlying localtime representation. Don't use asctime, as it
5199 has undefined behavior for years outside the range -999..9999.
5200
7ed806a7
PE
52012012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5202
5203 Fix race conditions involving setenv, gmtime, localtime, asctime.
5204 Without this fix, interrupts could mess up code that uses these
5205 nonreentrant functions, since setting TZ invalidates existing
5206 tm_zone or tzname values, and since most of these functions return
5207 pointers to static storage.
5208 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5209 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5210 Grow the critical sections to include not just invoking
5211 localtime/gmtime, but also accessing these functions' results
5212 including their tm_zone values if any, and any related TZ setting.
5213 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5214 so that the struct tm is saved in the critical section.
5215 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5216 motivated by the fact that memory allocation needs to be outside
5217 the critical section.
5218
0c16dfed
DA
52192012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5220
5221 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5222 with RESET_INTERVAL.
5223
5224 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5225 Remove duplicated buffer name initialization.
5226
3f83ace8
JM
52272012-05-02 Jim Meyering <jim@meyering.net>
5228
5229 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5230
c7b8541e
JM
5231 * xfns.c (x_window): Use xstrdup (Bug#11375).
5232
90207a15 52332012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5234
5235 * xdisp.c (pos_visible_p): If already at a newline from the
5236 display string before the 'while' loop, don't walk back the glyphs
5237 from it3.glyph_row. Solves assertion violation when the display
5238 string begins with a newline (egg.el). (Bug#11367)
5239
b593d6a9
AH
52402012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5241
5242 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5243 Move to simple.el.
5244
4737362e
GM
52452012-05-01 Glenn Morris <rgm@gnu.org>
5246
99cf43f9
GM
5247 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5248 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5249 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5250 All were removed before 23.1.
5251
9311dcff
GM
5252 * dispnew.c: Remove HAVE_LIBNCURSES test;
5253 it is always true on relevant platforms.
5254
4d5c6349
GM
5255 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5256 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5257
4737362e
GM
5258 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5259
74dd3a6b
AS
52602012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5261
5262 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5263 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5264 Remove.
5265
13c379ee
PE
52662012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5267
5268 Do not avoid creating empty evaporating overlays (Bug#9642).
5269 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5270 That is, do not delete an evaporating overlay if it becomes
5271 empty after its bounds are adjusted to fit within its buffer.
5272 This fix caused other problems, and I'm reverting it until we get
5273 to the bottom of them.
5274
a8e7d6d7 52752012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5276
5277 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5278
a8e7d6d7 52792012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5280
5281 * xdisp.c (pos_visible_p): If the window start position is beyond
5282 ZV, start the display from buffer beginning. Prevents assertion
5283 violation in init_iterator when the minibuffer window is scrolled
5284 via the scroll bar.
5285
5286 * window.c (window_scroll_pixel_based): Likewise.
5287
a8e7d6d7 52882012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5289
5290 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5291
a8e7d6d7 52922012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5293
5294 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5295 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5296
a8e7d6d7 52972012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5298
b593d6a9
AH
5299 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5300 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5301
1c6900d9
EZ
53022012-04-26 Eli Zaretskii <eliz@gnu.org>
5303
4c3fa1d9
EZ
5304 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5305 display element, check also the underlying string or buffer
5306 character. (Bug#11341)
5307
1c6900d9
EZ
5308 * w32menu.c: Include w32heap.h.
5309 (add_menu_item): If the call to AppendMenuW (via
5310 unicode_append_menu) fails, disable Unicode menus only if we are
5311 running on Windows 9X/Me.
5312
42bf8205
AS
53132012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5314
5315 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5316 (xgetint): Add missing shift for LSB tags.
5317
b1bac16e
MR
53182012-04-24 Martin Rudalics <rudalics@gmx.at>
5319
5320 * keyboard.c (read_char): Don't wipe echo area for select window
5321 events: These might get delayed via `mouse-autoselect-window'
5322 (Bug#11304).
5323
d69621cc
JB
53242012-04-24 Juanma Barranquero <lekktu@gmail.com>
5325
5326 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5327 manipulation of :loaded-from data.
5328
02fd101b
JB
53292012-04-23 Juanma Barranquero <lekktu@gmail.com>
5330
5331 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5332 now a cons (bug#11311).
5333
888bec30
PE
53342012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5335
89a438bd
PE
5336 Do not create empty overlays with the evaporate property (Bug#9642).
5337 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5338 if it becomes empty after its bounds are adjusted to fit within
5339 its buffer. Without this fix, in a nonempty buffer (let ((o
5340 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5341 yields an empty overlay that has the evaporate property, which is
5342 not supposed to happen.
5343
1068fe4d
PE
5344 Fix minor GTK3 problems found by static checking.
5345 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5346 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5347 (struct _EmacsFixedClass, emacs_fixed_get_type):
5348 Move decls here from emacsgtkfixed.h, since they needn't be public.
5349 (emacs_fixed_get_type): Now static.
5350 (emacs_fixed_class_init): Omit unused local.
5351 (emacs_fixed_child_type): Remove; unused.
5352 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5353 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5354 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5355 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5356 (EMACS_FIXED_GET_CLASS): Remove; unused.
5357 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5358
888bec30
PE
5359 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5360 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5361
de85e130
PE
53622012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5363
d0baac98 5364 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5365 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5366 (__malloc_size_t, __malloc_ptrdiff_t):
5367 Remove. All uses removed, replaced by the definiens if needed,
5368 since we can assume C89 or better now.
5369 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5370 (protect_malloc_state, align, get_contiguous_space)
5371 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5372 (malloc_atfork_handler_child, malloc_enable_thread)
5373 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5374 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5375 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5376 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5377 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5378 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5379 Define using prototypes, not old style.
5380 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5381 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5382 (align): Don't assume that signed integer overflow wraps around.
5383 Omit unused local var.
5384 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5385 (_free_internal_nolock, memalign, mallochook, reallochook):
5386 Omit no-longer-needed casts.
5387 (valloc): Use getpagesize, not __getpagesize.
5388 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5389 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5390
de85e130
PE
5391 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5392
dcbf5805
MA
53932012-04-22 Michael Albinus <michael.albinus@gmx.de>
5394
5395 Move functions from C to Lisp. Make non-blocking method calls
5396 the default. Implement further D-Bus standard interfaces.
5397
5398 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5399 (QCdbus_request_name_allow_replacement)
5400 (QCdbus_request_name_replace_existing)
5401 (QCdbus_request_name_do_not_queue)
5402 (QCdbus_request_name_reply_primary_owner)
5403 (QCdbus_request_name_reply_in_queue)
5404 (QCdbus_request_name_reply_exists)
5405 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5406 (QCdbus_registered_serial, QCdbus_registered_method)
5407 (QCdbus_registered_signal): New Lisp objects.
5408 (XD_DEBUG_MESSAGE): Use sizeof.
5409 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5410 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5411 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5412 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5413 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5414 (xd_signature, xd_append_arg): Allow float for integer types.
5415 (xd_get_connection_references): New function.
b593d6a9
AH
5416 (xd_get_connection_address): Rename from xd_initialize.
5417 Return cached address.
dcbf5805
MA
5418 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5419 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5420 level.
5421 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5422 Return number of refcounts.
dcbf5805
MA
5423 (Fdbus_get_unique_name): Make stronger parameter check.
5424 (Fdbus_message_internal): New defun.
5425 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5426 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5427 (Fdbus_send_signal, Fdbus_register_service)
5428 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5429 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5430 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5431 (Vdbus_compiled_version, Vdbus_runtime_version)
5432 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5433 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5434 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5435 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5436 Adapt docstring.
dcbf5805 5437
52828e02
PE
54382012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5439
da05bc4c
PE
5440 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5441 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5442 Do not assume ptrdiff_t is the same width as 'int'.
5443
52828e02
PE
5444 * alloc.c: Handle unusual debugging option combinations.
5445 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5446 since the two debugging options are incompatible.
5447 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5448 is defined.
5449 (mem_init, mem_insert, mem_insert_fixup):
5450 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5451 (NEED_MEM_INSERT): Remove; no longer needed.
5452
f01769f9
LL
54532012-04-22 Leo Liu <sdl.web@gmail.com>
5454
5455 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5456
5790543d
PE
54572012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5458
5459 * sysdep.c [__FreeBSD__]: Minor cleanups.
5460 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5461 Use Emacs indenting style more consistently. Avoid some casts.
5462 Use 'double' consistently rather than mixing 'float' and 'double'.
5463
b91b7e4d
EW
54642012-04-21 Eduard Wiebe <usenet@pusto.de>
5465
b593d6a9
AH
5466 * sysdep.c (list_system_processes, system_process_attributes):
5467 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5468
6114eb15
AS
54692012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5470
5471 * lisp.mk (lisp): Update.
5472
2f38dff7
PE
54732012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5474
5475 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5476 It is never used otherwise.
5477
4ae29f89
SM
54782012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5479
5480 * print.c (print_preprocess): Only check print_depth if print-circle
5481 is nil.
5482 (print_object): Check for cycles even when print-circle is nil and
5483 print-gensym is t, but only check print_depth if print-circle is nil.
5484
f30d612a
CY
54852012-04-20 Chong Yidong <cyd@gnu.org>
5486
5487 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5488 set the status to "failed" and ensure that sentinel is run.
5489
c07a4c0b 54902012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5491
5492 * process.c (Fset_process_inherit_coding_system_flag)
5493 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5494 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5495
c07a4c0b 54962012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5497
5498 * xdisp.c (string_buffer_position_lim): Limit starting position to
5499 BEGV.
5500 (set_cursor_from_row): If called for a mode-line or header-line
5501 row, return zero immediately.
5502 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5503 farther than the first row after the header line, if any.
5504 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5505 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5506
c07a4c0b 55072012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5508
4ae29f89
SM
5509 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5510 (bug#11238).
ad3a2b41 5511
c07a4c0b 55122012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 55132012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5514
5515 configure: new option --enable-gcc-warnings (Bug#11207)
5516 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5517 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5518 (ALL_CFLAGS): Use new macros rather than old.
5519 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5520 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5521 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5522 -Wunused-result, -Wunused-variable. This should go away once
5523 the Emacs and Gnulib regex code is merged.
5524 (xmalloc, xrealloc): Now static.
5525
aba027e8
PE
55262012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5527
5528 * dired.c (Fsystem_groups): Remove unused local.
5529
e5a36063
GM
55302012-04-17 Glenn Morris <rgm@gnu.org>
5531
5532 * dired.c (Fsystem_users): Doc fix.
5533
316411f0
DA
55342012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5535
5536 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5537 (syms_of_dired): Add them.
5538
9426aba4
PE
55392012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5540
b62a57be
PE
5541 Fix minor alloc.c problems found by static checking.
5542 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5543 New extern decls, to avoid calling undeclared functions.
5544 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5545 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5546 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5547 (NEED_MEM_INSERT): New macro.
5548 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5549 Remove one incorrect comment and fix another.
b62a57be 5550
3539f31f
PE
5551 Fix minor ralloc.c problems found by static checking.
5552 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5553 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5554 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5555 (r_alloc_sbrk): Now static.
5556
a041960a
PE
5557 Improve ralloc.c interface checking.
5558 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5559 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5560 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5561 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5562 [REL_ALLOC]: ... to here, to check interface.
5563 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5564 Remove decls. This fixes an "It stinks!".
5565
9426aba4
PE
5566 * alloc.c (which_symbols): Fix alignment issue / type clash.
5567
d55c12ed
AS
55682012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5569
5570 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5571 (struct Lisp_Misc_Any): Likewise.
5572 (struct Lisp_Free): Likewise.
5573 * alloc.c (union aligned_Lisp_Symbol): Define.
5574 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5575 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5576 (union aligned_Lisp_Misc): Define.
5577 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5578 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5579 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5580
b948ce8b
PE
55812012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5582
5583 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5584 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5585 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5586 * s/netbsd.h, s/sol2-6.h:
5587 Remove definition of GC_MARK_STACK, since the default now works.
5588 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5589 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5590 no longer the default.
5591 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5592
35dc09a1 55932012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5594
35dc09a1
GM
5595 * lread.c (lisp_file_lexically_bound_p):
5596 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5597
35dc09a1
GM
55982012-04-14 Eli Zaretskii <eliz@gnu.org>
5599
5600 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5601 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5602
56032012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5604
5605 * nsterm.m (constrainFrameRect): Always constrain when there is only
5606 one screen (Bug#10962).
5607
bcd86815
KB
56082012-04-13 Ken Brown <kbrown@cornell.edu>
5609
5610 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5611
c25df26e
RT
56122012-04-13 Reuben Thomas <rrt@sc3d.org>
5613
5614 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5615
0fc59f1e
DC
56162012-04-11 Daniel Colascione <dancol@dancol.org>
5617
5618 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5619 against is gone. It's better to use vfork now so that when Cygwin
5620 gains a new, working vfork, we use it automatically (bug#10398).
5621
de8c03dc
SM
56222012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5623
5624 * window.c (save_window_save): Obey window-point-insertion-type.
5625
2f097256
GM
56262012-04-11 Glenn Morris <rgm@gnu.org>
5627
5628 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5629
453b951e
SM
56302012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5631
5632 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5633
75f1671a 56342012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5635
5636 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5637 (force_quit_count): New var.
5638 (handle_interrupt): Use it.
5639
2a8ce227
JB
56402012-04-10 Juanma Barranquero <lekktu@gmail.com>
5641
5642 * w32.c (w32_delayed_load): Record the full path of the library
5643 being loaded (bug#10424).
5644
935396c0
GM
56452012-04-09 Glenn Morris <rgm@gnu.org>
5646
05920a43
GM
5647 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5648 not just in the obarray, before snarfing them. (Bug#11036)
5649
935396c0
GM
5650 * Makefile.in ($(leimdir)/leim-list.el):
5651 Pass EMACS rather than BUILT_EMACS.
5652
a18ecafa
TZ
56532012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5654
5655 * process.c (make_process):
5656 * process.h: Add integer `gnutls_handshakes_tried' member to
5657 process struct.
5658
6bbef4e5
JC
5659 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5660 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5661
5662 * gnutls.c (gnutls_log_function2i): Convenience log function.
5663 (emacs_gnutls_read): Use new log functions,
5664 `gnutls_handshakes_tried' process member, and
5665 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5666 attempts per process (connection).
5667
b4d3bc10
CY
56682012-04-09 Chong Yidong <cyd@gnu.org>
5669
5670 * eval.c (Fuser_variable_p, user_variable_p_eh)
5671 (lisp_indirect_variable): Functions deleted.
5672 (Fdefvar): Caller changed.
5673
5674 * callint.c (Finteractive, Fcall_interactively):
5675 * minibuf.c (Fread_variable): Callers changed.
5676
70f4d973
EZ
56772012-04-09 Eli Zaretskii <eliz@gnu.org>
5678
5679 * xdisp.c (set_cursor_from_row): If the display string appears in
5680 the buffer at position that is closer to point than the position
5681 after the display string, display the cursor on the first glyph of
5682 the display string. Fixes cursor display when a 'display' text
5683 property immediately follows invisible text. (Bug#11094)
5684
cb3c2e3e
PE
56852012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5686
5687 composite.c: use 'double' consistently
5688 * composite.c (get_composition_id): Use 'double' consistently
5689 instead of converting 'float' to 'double' and vice versa; this is
5690 easier to understand and avoids a GCC warning.
5691
fd06db5d
GM
56922012-04-09 Glenn Morris <rgm@gnu.org>
5693
50fe702a
GM
5694 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5695 preparation for dumping it with emacs. (Bug#4789)
5696 (leimdir): New variable.
5697 ($(leimdir)/leim-list.el): New rule.
5698 (emacs$(EXEEXT)): Depend on leim-list.el.
5699
fd06db5d
GM
5700 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5701 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5702 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5703
55c131ee
AS
57042012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5705
5706 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5707 proper alignment.
5708
9209588f
JB
57092012-04-07 Juanma Barranquero <lekktu@gmail.com>
5710
5711 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5712 Remove unused local variable.
5713
e3fb2efb
PE
57142012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5715
5716 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5717 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5718 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5719 objects, as mark_maybe_pointer will catch them otherwise.
5720 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5721 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5722
b5385551
PE
57232012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5724
5725 Fix typo that broke non-Windows builds.
5726 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5727
9078ead6
EZ
57282012-04-07 Eli Zaretskii <eliz@gnu.org>
5729
5730 Support building on MS-Windows with libxml2.
5731
5732 * makefile.w32-in (OBJ2): Add xml.$(O).
5733 (GLOBAL_SOURCES): Add xml.c.
5734 ($(BLD)/xml.$(O)): New dependency list.
5735
5736 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5737 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5738 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5739 [!WINDOWSNT]: New macros.
5740 (init_libxml2_functions, libxml2_loaded_p): New functions.
5741 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5742 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5743 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5744 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5745 linked in).
6bbef4e5
JC
5746 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5747 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5748 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5749
5750 * emacs.c: Don't include libxml/parser.h.
5751 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5752 xmlCleanupParser directly.
5753
5754 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5755
3811fdf3
EZ
57562012-04-07 Eli Zaretskii <eliz@gnu.org>
5757
5758 * indent.c (Fvertical_motion): If there is a display string at
5759 point, use it.vpos to compute how many lines to backtrack after
5760 move_it_to point. (Bug#11133)
5761
2f8e16b2
EZ
57622012-04-06 Eli Zaretskii <eliz@gnu.org>
5763
5764 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5765 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5766 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5767 macros related to unification of CJK characters. For the details,
5768 see the discussion following the message here:
5769 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5770
3d439cd1
CY
57712012-04-04 Chong Yidong <cyd@gnu.org>
5772
5773 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5774
8bc53d00
EZ
57752012-04-01 Eli Zaretskii <eliz@gnu.org>
5776
5777 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5778 instead of alloca. (Bug#11138)
5779
3b0512a3
AS
57802012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5781
5782 * w32menu.c (is_simple_dialog): Properly check lisp types.
5783 (Bug#11141)
5784
8427ddd2
EZ
57852012-03-31 Eli Zaretskii <eliz@gnu.org>
5786
979022ef
EZ
5787 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5788 position we get to after a call to move_it_to fails the
5789 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5790 only if we wind up in a string from display property. (Bug#11063)
5791
a6b1c7cc
EZ
5792 * window.c (Fdelete_other_windows_internal): Invalidate the row
5793 and column information about mouse highlight, so that redisplay
5794 restores it after reallocating the glyph matrices. (Bug#7464)
5795
8427ddd2
EZ
5796 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5797 string comes from a `display' text property, use the buffer
5798 position of that property as if we actually saw that position in
5799 the row's glyphs.
697ba24b
EZ
5800 (move_it_by_lines): Remove the assertion that
5801 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5802 violated when there's a before-string at the beginning of a line.
5803 (Bug#11063)
8427ddd2 5804
65a0a738
EZ
58052012-03-30 Eli Zaretskii <eliz@gnu.org>
5806
5807 * xdisp.c (append_space_for_newline): If the default face was
5808 remapped, use the remapped face for the appended newline.
5809 (extend_face_to_end_of_line): Use the remapped default face for
5810 extending the face to the end of the line.
5811 (display_line): Call extend_face_to_end_of_line when the default
5812 face was remapped. (Bug#11068)
5813
581355cc
EZ
58142012-03-29 Eli Zaretskii <eliz@gnu.org>
5815
5816 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5817
e8fc049f
SM
58182012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5819
5820 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5821
4fb9a543
GM
58222012-03-27 Glenn Morris <rgm@gnu.org>
5823
5824 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5825 Doc fixes.
5826
679910f1
KH
58272012-03-26 Kenichi Handa <handa@m17n.org>
5828
5829 * dispextern.h (struct glyph): Fix previous change. Change the
5830 bit length of glyphless.ch to 25 (Bug#11082).
5831
90d49b7f
CY
58322012-03-26 Chong Yidong <cyd@gnu.org>
5833
5834 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5835 (command_loop_1): Use it; inhibit selection update for
5836 handle-select-window too (Bug#8996).
5837
f514f6f0
FP
58382012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5839
e8fc049f 5840 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5841
bf43fa51
KH
58422012-03-25 Kenichi Handa <handa@m17n.org>
5843
5844 * dispextern.h (struct glyph): Change the bit length of
5845 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5846
8a0c01dd
EZ
58472012-03-24 Eli Zaretskii <eliz@gnu.org>
5848
5849 * s/ms-w32.h (tzname): Include time.h before redirecting to
5850 _tzname. Fixes the MSVC build. (Bug#9960)
5851
7d1c3a76
AS
58522012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5853
8ed79523
AS
5854 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5855 characters.
5856
7d1c3a76
AS
5857 * xterm.c (XTread_socket): Only modify handling_signal if
5858 !SYNC_INPUT. (Bug#11080)
5859
e99a9b8b
EZ
58602012-03-23 Eli Zaretskii <eliz@gnu.org>
5861
5862 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5863 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5864 when fetching a multibyte character consumes more bytes than
5865 CHAR_BYTES returns, due to unification of CJK characters in
5866 string_char. (Bug#11073)
5867
5063c0e1
TN
58682012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5869
5870 * process.c (wait_reading_process_output): Handle pty disconnect
5871 by refraining from sending oneself a SIGCHLD (bug#10933).
5872
9f851fbd
CY
58732012-03-22 Chong Yidong <cyd@gnu.org>
5874
5875 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5876
5063c0e1 5877 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5878 Mark string as coming from a prefix property.
5879 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5880 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5881
fb5b8aca
CY
58822012-03-21 Chong Yidong <cyd@gnu.org>
5883
5884 * xfaces.c (Vface_remapping_alist): Doc fix.
5885
62356a1b
EZ
58862012-03-20 Eli Zaretskii <eliz@gnu.org>
5887
5888 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5889 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5890 Doc fixes.
62356a1b 5891
025de85b
CY
58922012-03-20 Chong Yidong <cyd@gnu.org>
5893
5894 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5895 to reflect default non-nil value of redisplay-dont-pause.
5896
4827f94e
KH
58972012-03-19 Kenichi Handa <handa@m17n.org>
5898
5899 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5900 it fit in a valid range (Bug#11003).
5901
e50a24a2
EZ
59022012-03-18 Eli Zaretskii <eliz@gnu.org>
5903
5904 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5905 that is not from display property, accept the row as a "cursor
5906 row" if one of the string's character has a non-nil `cursor'
5907 property. Fixes cursor positioning when there are newlines in
5908 overlay strings, e.g. in icomplete.el. (Bug#11035)
5909
9af5ed87
PE
59102012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5911
5912 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5913
d1f55f16
CY
59142012-03-12 Chong Yidong <cyd@gnu.org>
5915
5916 * eval.c (inhibit_lisp_code): Rename from
5917 inhibit_window_configuration_change_hook; move from window.c.
5918
5919 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5920 * window.c (run_window_configuration_change_hook)
5921 (syms_of_window): Callers changed.
5922
66c5eebd
CY
59232012-03-11 Chong Yidong <cyd@gnu.org>
5924
413df973
CY
5925 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5926
66c5eebd
CY
5927 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5928
1de11f56
CY
59292012-03-10 Chong Yidong <cyd@gnu.org>
5930
5931 * frame.c (other_visible_frames): Don't assume the selected frame
5932 is visible (Bug#10955).
5933
cae07000
SM
59342012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5935
5936 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5937
89c94350
JD
59382012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5939
5940 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5941 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5942 zero (Bug#10954).
5943
999dd333
GM
59442012-03-03 Glenn Morris <rgm@gnu.org>
5945
01a6dcc8 5946 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5947
de0100f2
EZ
59482012-03-02 Eli Zaretskii <eliz@gnu.org>
5949
5950 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5951 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5952 (redisplay_window, next_element_from_string): Fix typos in
5953 comments.
3e441275
EZ
5954 (redisplay_window): Pass to move_it_vertically the margin in
5955 pixels, not in screen lines.
de0100f2 5956
96a72ee9
GM
59572012-03-02 Glenn Morris <rgm@gnu.org>
5958
5959 * buffer.c (buffer-list-update-hook): Doc fix.
5960
312508d7
EZ
59612012-02-29 Eli Zaretskii <eliz@gnu.org>
5962
5963 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5964 push_it before setting up the iterator for the first overlay
5965 string, even if we have an empty string loaded.
5966 (next_overlay_string): If there's an empty string on the iterator
5967 stack, pop the stack. (Bug#10903)
5968
27f3c637
PE
59692012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5970
5971 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5972 Suggested by Stefan Monnier in
5973 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5974 * alloc.c (widen_to_Lisp_Object): New static function.
5975 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5976 and widening them to Lisp_Objects. This would work even if
5977 USE_LSB_TAG is defined and wide integers are used, which might
5978 happen in a future version of Emacs.
5979
3c9dfce6
CY
59802012-02-25 Chong Yidong <cyd@gnu.org>
5981
fa74b241
CY
5982 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5983 Doc fix.
5984
3c9dfce6
CY
5985 * xselect.c (Fx_selection_exists_p): Doc fix.
5986 (x_clipboard_manager_save_all): Print an informative message
5987 before saving to clipboard manager.
5988
9486df08
CY
59892012-02-24 Chong Yidong <cyd@gnu.org>
5990
5991 * keyboard.c (process_special_events): Handle all X selection
5992 requests in kbd_buffer, not just the next one (Bug#8869).
5993
f01d3321
CY
59942012-02-23 Chong Yidong <cyd@gnu.org>
5995
5996 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5997 call when setting menu-bar-lines and tool-bar-lines parameters.
5998 (unwind_create_frame_1): New helper function.
5999
6000 * window.c (inhibit_window_configuration_change_hook): New var.
6001 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 6002 (syms_of_window): Initialize it.
f01d3321 6003
86b847b6
CY
60042012-02-22 Chong Yidong <cyd@gnu.org>
6005
6006 * xterm.c (x_draw_image_relief): Add missing type check for
6007 Vtool_bar_button_margin (Bug#10743).
6008
a59225b1
CY
60092012-02-21 Chong Yidong <cyd@gnu.org>
6010
6011 * fileio.c (Vfile_name_handler_alist): Doc fix.
6012
6013 * buffer.c (Fget_file_buffer): Protect against invalid file
6014 handler return value.
6015
310f5bd4
PE
60162012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6017
cb3a28cc
PE
6018 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6019 when computing $valmask.
6020
310f5bd4
PE
6021 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6022 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6023 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6024 It's useless in that case, and it can cause problems on hosts
6025 that allocate halves of EMACS_INT values separately.
6026 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6027 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6028 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6029 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6030 it avoids undefined behavior on hosts where shifting right by more
6031 than the word width has undefined behavior.
6032
2375c96a
CY
60332012-02-19 Chong Yidong <cyd@gnu.org>
6034
6035 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6036 (Funhandled_file_name_directory, Ffile_name_as_directory)
6037 (Fdirectory_file_name, Fexpand_file_name)
6038 (Fsubstitute_in_file_name): Protect against invalid file handler
6039 return values (Bug#10845).
6040
3eb49e71
EZ
60412012-02-18 Eli Zaretskii <eliz@gnu.org>
6042
6043 * .gdbinit (pitx): Fix incorrect references to fields of the
6044 iterator stack.
6045
7b926f3f
CY
60462012-02-17 Chong Yidong <cyd@gnu.org>
6047
6048 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6049
11273115
PE
60502012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6051
6052 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6053 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6054
c3a70e2b
CY
60552012-02-15 Chong Yidong <cyd@gnu.org>
6056
6057 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6058 marked as special. Also, starting docstrings with * is obsolete.
6059
0ca43699
AS
60602012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6061
6062 * gnutls.c (emacs_gnutls_write): Fix last change.
6063
2e8f3c56
LI
60642012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6065
6066 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6067 send_process.
6068
af70074f
SM
60692012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6070
6071 * keymap.c (Fsingle_key_description): Handle char ranges.
6072
95986d52
CY
60732012-02-12 Chong Yidong <cyd@gnu.org>
6074
afd83bd1
CY
6075 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6076 as that creates a dangerous corner case.
6077
95986d52
CY
6078 * window.c (Fdelete_window_internal): Invalidate the mouse
6079 highlight (Bug#9904).
6080
bd7da63e
GM
60812012-02-12 Glenn Morris <rgm@gnu.org>
6082
6083 * xselect.c (Fx_own_selection_internal)
6084 (Fx_get_selection_internal, Fx_disown_selection_internal)
6085 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6086 * nsselect.m (Fx_own_selection_internal)
6087 (Fx_disown_selection_internal, Fx_selection_exists_p)
6088 (Fx_selection_owner_p, Fx_get_selection_internal):
6089 Sync docs and argument specs with the xselect.c versions.
6090
77abcbc2
LI
60912012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6092
6093 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6094
90b671e2
EZ
60952012-02-11 Eli Zaretskii <eliz@gnu.org>
6096
1c0ca0b7
EZ
6097 * w32select.c (Fx_selection_exists_p): Sync doc string and
6098 argument list with xselect.c. (Bug#10783)
6099
6100 * w16select.c (Fx_selection_exists_p): Sync doc string and
6101 argument list with xselect.c. (Bug#10783)
90b671e2 6102
49241268
GM
61032012-02-10 Glenn Morris <rgm@gnu.org>
6104
6105 * fns.c (Fsecure_hash): Doc fix.
6106
f998bbe7 61072012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6108
6109 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6110
0992bd9c
CY
61112012-02-07 Chong Yidong <cyd@gnu.org>
6112
6113 * buffer.c (Fbuffer_local_variables)
6114 (buffer_lisp_local_variables): Handle unbound vars correctly;
6115 don't let Qunbound leak into Lisp.
6116
af008560
GM
61172012-02-07 Glenn Morris <rgm@gnu.org>
6118
dd605cc4
GM
6119 * image.c (Fimagemagick_types): Doc fix.
6120
af008560
GM
6121 * image.c (imagemagick-render-type): Change it from a lisp object
6122 to an integer. Move the doc here from the lisp manual.
6123 Treat all values not equal to 0 the same.
6124
1449fa1d
CY
61252012-02-06 Chong Yidong <cyd@gnu.org>
6126
6127 * doc.c (store_function_docstring): Avoid applying docstring of
6128 alias to base function (Bug#2603).
6129
3723ec07
AS
61302012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6131
6132 * .gdbinit (pp1, pv1): Remove redundant defines.
6133 (pr): Use pp.
6134
79c1cc1e
CY
61352012-02-04 Chong Yidong <cyd@gnu.org>
6136
6137 * nsterm.m: Declare a global (Bug#10694).
6138
d7f29f8e
EZ
61392012-02-04 Eli Zaretskii <eliz@gnu.org>
6140
cae07000
SM
6141 * w32.c (get_emacs_configuration_options):
6142 Include --enable-checking, if specified, in the return value.
d7f29f8e 6143
3b95a6f9
MR
61442012-02-04 Martin Rudalics <rudalics@gmx.at>
6145
6146 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6147 after rounding frame sizes. (Bug#9723)
6148
d6fa96a6
EZ
61492012-02-04 Eli Zaretskii <eliz@gnu.org>
6150
6151 * keyboard.c (adjust_point_for_property): Don't position point
6152 before BEGV. (Bug#10696)
6153
df0b2940
PE
61542012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6155
6156 Handle overflow when computing char display width (Bug#9496).
6157 * character.c (char_width): Return EMACS_INT, not int.
6158 (char_width, c_string_width): Check for overflow when
6159 computing the width; this is possible now that individual
6160 characters can have unbounded width. Problem introduced
6161 by merge from Emacs 23 on 2012-01-19.
6162
6bee44d6
MA
61632012-02-02 Michael Albinus <michael.albinus@gmx.de>
6164
6165 * dbusbind.c (Fdbus_register_method): Mention the return value
6166 :ignore in the docstring.
6167
44f92739
GM
61682012-02-02 Glenn Morris <rgm@gnu.org>
6169
1b9f60cc
GM
6170 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6171
44f92739
GM
6172 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6173 Unconditionally set to t. (Bug#10673)
6174 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6175 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6176 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6177
c5d3843c
KH
61782012-02-02 Kenichi Handa <handa@m17n.org>
6179
6180 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6181 0, do not call append_composite_glyph.
6182
159462d4 61832012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6184
6185 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6186 NULL (Bug#6988).
6187 (x_produce_glyphs): If the component of a composition is a null
6188 string, set it->pixel_width to 1 to avoid zero-width glyph.
6189
78cef877
EZ
61902012-02-01 Eli Zaretskii <eliz@gnu.org>
6191
6192 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6193 first 2 arguments are identical. This makes inserting large
6194 output from a subprocess an order of magnitude faster on
6195 MS-Windows, where all sbrk'ed memory is always contiguous.
6196
97897668
GM
61972012-01-31 Glenn Morris <rgm@gnu.org>
6198
6199 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6200 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6201 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6202
31fd3586
GM
62032012-01-29 Glenn Morris <rgm@gnu.org>
6204
6205 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6206
0e24a8b2
CY
62072012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6208
6209 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6210
cc0adcb0
CY
62112012-01-28 Chong Yidong <cyd@gnu.org>
6212
6213 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6214
acc28cb9
CY
62152012-01-26 Chong Yidong <cyd@gnu.org>
6216
9c69cfb7
CY
6217 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6218
acc28cb9
CY
6219 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6220 repeat counts (Bug#10507).
6221
48da7392
GM
62222012-01-26 Glenn Morris <rgm@gnu.org>
6223
6224 * lread.c (syms_of_lread): Doc fix.
6225
14af5f7f
CY
62262012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6227
6228 * coding.c (encode_designation_at_bol): Change return value to
6229 EMACS_INT.
6230
0b21c100
CY
62312012-01-25 Chong Yidong <cyd@gnu.org>
6232
6233 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6234
3c2907f7
CY
62352012-01-21 Chong Yidong <cyd@gnu.org>
6236
6237 * floatfns.c (Fcopysign): Make the second argument non-optional,
6238 since nil is not allowed anyway.
6239
959ad23f
AS
62402012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6241
6242 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6243 (send_process): Likewise.
6244
34a02f46
MR
62452012-01-19 Martin Rudalics <rudalics@gmx.at>
6246
6247 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6248 (Vwindow_persistent_parameters): Do not use Qstate.
6249 Rewrite doc-strings.
34a02f46 6250
1259009a 62512012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6252
6253 * character.c (char_width): New function.
70d4fdf6
GM
6254 (Fchar_width, c_string_width, lisp_string_width):
6255 Use char_width (Bug#9496).
25ed9e61 6256
6a6ee00d
MR
62572012-01-16 Martin Rudalics <rudalics@gmx.at>
6258
6259 * window.c (Vwindow_persistent_parameters): New variable.
6260 (Fset_window_configuration, save_window_save): Handle persistent
6261 window parameters.
6262
c85efaf7
EZ
62632012-01-14 Eli Zaretskii <eliz@gnu.org>
6264
6265 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6266 thrashing the stack of the thread. (Bug#9087)
6267
5944709e
PE
62682012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6269
6270 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6271
e71f5d99
EZ
62722012-01-11 Eli Zaretskii <eliz@gnu.org>
6273
6274 * xdisp.c (rows_from_pos_range): Handle the case where the
6275 highlight ends on a newline. (Bug#10464)
6276 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6277 he end column for display of highlight that ends on a newline
6278 before a R2L line.
6279
ce316182
GM
62802012-01-11 Glenn Morris <rgm@gnu.org>
6281
6282 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6283 from load-path also when installation-directory is nil. (Bug#10208)
6284
5b43da69
GM
62852012-01-10 Glenn Morris <rgm@gnu.org>
6286
74cc8ff9
GM
6287 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6288
7d8d6e4e
GM
6289 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6290 Update template values to be closer to their typical values these days.
5b43da69 6291
a0db8d43
EZ
62922012-01-09 Eli Zaretskii <eliz@gnu.org>
6293
6294 * xdisp.c (rows_from_pos_range): Accept additional argument
6295 DISP_STRING, and accept any glyph in a row whose object is that
6296 string as eligible for mouse highlight. Fixes mouse highlight of
6297 display strings from overlays. (Bug#10464)
6298
9a0115ab 62992012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6300
b9110d6a 6301 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6302 * fileio.c (auto_saving_dir_umask): New static var.
6303 (Fmake_directory_internal): Use it.
6304 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6305 creating the directory. The old code temporarily assigns
6306 too-generous permissions to the directory.
6307 (do_auto_save_eh): Clear it.
b9110d6a 6308 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6309 that the var is always cleared.
6310
6c1bd3f3
EZ
63112012-01-07 Eli Zaretskii <eliz@gnu.org>
6312
6313 * search.c (scan_buffer): Pass character positions to
6314 know_region_cache, not byte positions. (Bug#6540)
6315
069d2b50
L
63162012-01-07 LynX <_LynX@bk.ru> (tiny change)
6317
6318 * w32.c (sys_rename): Report EXDEV when rename of a directory
6319 fails because the target is on another logical disk. (Bug#10284)
6320
75bf0d33
DB
63212012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6322
6323 * xterm.c (x_embed_request_focus): New function.
6324
6325 * xterm.h: Add prototype.
6326
6327 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6328
1c6e5a32
GM
63292012-01-05 Glenn Morris <rgm@gnu.org>
6330
6331 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6332
651e947e
EZ
63332012-01-01 Eli Zaretskii <eliz@gnu.org>
6334
6335 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6336 Load gnutls_transport_set_lowat only if GnuTLS version is below
6337 2.11.1.
6338 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6339 GnuTLS versions below 2.11.1.
6340
3778cdd8
AL
63412011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6342
6343 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6344 to the doc string advising against its use for altering the way
6345 windows are scrolled.
6346
0e5317f7
KH
63472011-12-28 Kenichi Handa <handa@m17n.org>
6348
6349 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6350 coding-system ASCII compatible only when it does not produce BOM
6351 on encoding (Bug#10383).
6352
93d5ca1f
JD
63532011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6354
6355 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6356 can scroll.
6357 (create_and_show_popup_menu): Always use menu_position_func for
6358 Gtk3 (Bug#10361).
6359
ca22b785
AS
63602011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6361
6362 * callint.c (Fcall_interactively): Don't truncate prompt string.
6363
d048e1e6
EZ
63642011-12-23 Eli Zaretskii <eliz@gnu.org>
6365
6366 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6367 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6368 resumed from there (after widening). (Bug#10360)
d048e1e6 6369
5ccaba1f
JD
63702011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6371
6372 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6373
204ee57f
JD
63742011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6375
b81d40f0
JB
6376 * nsterm.m (x_free_frame_resources):
6377 Release f->output_data.ns->miniimage.
204ee57f
JD
6378 (ns_index_color): Fix indentation. Do not retain
6379 color_table->colors[i].
6380
6381 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6382 before returning.
6383
6384 * nsfns.m (x_set_background_color): Assign return value from
6385 ns_index_color to face-background instead of NSColor*.
6386 (ns_implicitly_set_icon_type): Fix indentation.
6387 Change assignment in for loop to comparison.
6388
6389 * emacs.c (ns_pool): New variable.
6390 (main): Assign ns_pool.
6391 (Fkill_emacs): Call ns_release_autorelease_pool.
6392
6393 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6394 autorelease fdesc, release fdAttrs and tdict.
6395 (ns_get_covering_families): Release charset.
6396 (ns_findfonts): Release NSFontDescriptor created with new.
6397 (ns_uni_to_glyphs): Fix indentation.
6398 (setString): Release attrStr before assigning new value.
6399
c803b2b7
JD
64002011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6401
678f4426
JD
6402 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6403 and NS_IMPL_COCOA.
6404 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6405 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6406
cd394be1 64072011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6408
5fecd5fc
JD
6409 * nsterm.m (ns_term_init): Subscribe for notifications
6410 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6411 to method trackingNotification in EmacsMenu.
6412
6413 * nsmenu.m (trackingMenu): New variable.
3771cb17 6414 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6415 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6416 from Aquamacs (Bug#7030).
678f4426
JD
6417
64182011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6419
c803b2b7
JD
6420 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6421 (symbol_to_nsstring): Fix indentation.
6422 (ns_symbol_to_pb): New function.
cae07000
SM
6423 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6424 (Fns_rotate_cut_buffers_internal): Remove.
6425 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6426 Fns_store_cut_buffer_internal.
6427 (ns_get_foreign_selection, Fx_own_selection_internal)
6428 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6429 (Fns_get_selection_internal, Fns_store_selection_internal):
6430 Use ns_symbol_to_pb and check if return value is nil.
6431 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6432 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6433 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6434 renamed to Sns_store_selection_internal.
6435 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6436 and remove this function.
6437 (ns_handle_selection_clear): Remove, never used.
6438 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6439 here.
6440
e1b01a3a
KB
64412011-12-17 Ken Brown <kbrown@cornell.edu>
6442
6443 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6444 GID is unknown (Bug#10257).
6445
2adb6e85
PE
64462011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6447
6448 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6449 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6450 which caused a build failure on GNU/Linux IA-64. This problem was
6451 introduced by my 2011-10-07 patch.
6452
d1d7b339
JL
64532011-12-15 Juri Linkov <juri@jurta.org>
6454
6455 * image.c (imagemagick_error): New function. (Bug#10112)
6456 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6457 Use `imagemagick_error' where ImageMagick functions return
6458 `MagickFalse'.
6459 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6460 proper order.
6461
100d5755
KH
64622011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6463
6464 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6465 fill background (Bug#8992).
6466
454592a6
MR
64672011-12-13 Martin Rudalics <rudalics@gmx.at>
6468
6469 * window.c (Vwindow_combination_resize)
6470 (Vwindow_combination_limit): Use t instead of non-nil in
6471 doc-strings.
61d4b438
MR
6472 (Vrecenter_redisplay): Add first sentence of doc-string on
6473 separate line.
53524d93 6474 (Frecenter): Fix doc-string typo.
454592a6 6475
3633e3aa
KH
64762011-12-11 Kenichi Handa <handa@m17n.org>
6477
6478 * coding.c (Funencodable_char_position): Pay attention to the
6479 buffer text relocation (Bug#9389).
6480
7b9d523a 64812011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6482
7b9d523a
JD
6483 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6484 gtk_init (Bug#10100).
6485
b73189c6
EZ
64862011-12-10 Eli Zaretskii <eliz@gnu.org>
6487
6488 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6489 IT->string is nil. (Bug#10263)
6490
f7dfe5d6
JD
64912011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6492
83faebb4
JD
6493 * nsterm.h (x_free_frame_resources): Declare.
6494
f7dfe5d6
JD
6495 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6496 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6497
6498 * nsterm.h (ns_get_defaults_value): Declare.
6499
6500 * nsterm.m (ns_default): Call ns_get_defaults_value.
6501
7cd4e72c
EZ
65022011-12-09 Eli Zaretskii <eliz@gnu.org>
6503
6504 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6505 (Bug#10170)
6506
b34d7317
YM
65072011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6508
6509 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6510 that where the value of an _OBJC_* symbol points to is in the .bss
6511 section (Bug#10240).
6512
76470ad1
KH
65132011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6514
6515 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6516 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6517
745fff94
KH
65182011-12-08 Kenichi Handa <handa@m17n.org>
6519
6520 * ftfont.c (get_adstyle_property): Fix previous change
6521 (Bug#10233).
6522
6e44397c
JB
65232011-12-07 Juanma Barranquero <lekktu@gmail.com>
6524
6525 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6526 dirs from the default value of EMACSLOADPATH (bug#10208).
6527
7efa6272
GM
65282011-12-07 Glenn Morris <rgm@gnu.org>
6529
6530 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6531 installation and source directories as well. (Bug#10208)
6532
f6fc4d87
CY
65332011-12-06 Chong Yidong <cyd@gnu.org>
6534
6535 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6536
2bf26180
GM
65372011-12-06 Glenn Morris <rgm@gnu.org>
6538
6539 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6540 as an error, not just -1. (Bug#10217)
6541
3a6ad4f0
CY
65422011-12-05 Chong Yidong <cyd@gnu.org>
6543
6544 * keyboard.c (process_special_events): New function.
6545 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6546
75a3b399
PE
65472011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6548
6549 * coding.c (encode_designation_at_bol): Don't use uninitialized
6550 local variable (Bug#9318).
6551
c3c9e25e
KH
65522011-12-05 Kenichi Handa <handa@m17n.org>
6553
6554 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6555 return Qnil (Bug#8046, Bug#10193).
6556
5eb05ea3
KH
65572011-12-05 Kenichi Handa <handa@m17n.org>
6558
6559 * coding.c (encode_designation_at_bol): New args charbuf_end and
6560 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6561 (coding_set_source): Return how many bytes coding->source was
6562 relocated.
6563 (coding_set_destination): Return how many bytes
6564 coding->destination was relocated.
6565 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6566 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6567
65682011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6569
6570 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6571 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6572 macro (Bug#9318).
6573
65742011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6575
6576 The following changes are to fix Bug#9318.
6577
a79703f5 6578 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6579 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6580 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6581 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6582
7dbda6df
JB
65832011-12-05 Juanma Barranquero <lekktu@gmail.com>
6584
6585 * lisp.h (process_quit_flag): Fix external declaration.
6586
6d5eb5b0
SM
65872011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6588
6589 Don't macro-inline non-performance-critical code.
6590 * eval.c (process_quit_flag): New function.
6591 * lisp.h (QUIT): Use it.
6592
a0c3fad0
JD
65932011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6594
6595 * nsfns.m (get_geometry_from_preferences): New function.
6596 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6597
6c07aac2
AS
65982011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6599
6600 * emacs.c (Qkill_emacs): Define.
6601 (syms_of_emacs): Initialize it.
6602 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6603 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6604 (quit_throw_to_read_char): Add parameter `from_signal'.
6605 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6606 * lisp.h (QUIT): Call Fkill_emacs if requested.
6607
c052ead4
JD
66082011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6609
6610 * widget.c (update_wm_hints): Return if wmshell is null.
6611 (widget_update_wm_size_hints): New function.
6612
6613 * widget.h (widget_update_wm_size_hints): Declare.
6614
6615 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6616 widget_update_wm_size_hints (Bug#10104).
6617
9e49252b
EZ
66182011-12-03 Eli Zaretskii <eliz@gnu.org>
6619
6620 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6621 before a newline, prepare the bidi iterator for consuming the
6622 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6623 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6624
02b16839
JL
66252011-12-02 Juri Linkov <juri@jurta.org>
6626
6627 * search.c (Fword_search_regexp): New Lisp function created from
6628 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6629 (Fword_search_backward, Fword_search_forward)
6630 (Fword_search_backward_lax, Fword_search_forward_lax):
6631 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6632 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6633
0068070e
SM
66342011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6635
6636 * fileio.c (Finsert_file_contents): Move after-change-function call
6637 to before the "handled:" label, since all "goto handled" appear in
6638 cases where the *-change-functions have already been properly called
6639 (bug#10117).
6640
3360a3fc
AS
66412011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6642
6643 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6644 waiting for input. (Bug#10169)
6645
73d6c093
EZ
66462011-11-30 Eli Zaretskii <eliz@gnu.org>
6647
6648 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6649 verifies glyph row's hash code--we have just reallocated the
6650 glyphs, so their contents can be complete garbage. (Bug#10164)
6651
febe6bea
JB
66522011-11-30 Juanma Barranquero <lekktu@gmail.com>
6653
6654 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6655
801a4313
EZ
66562011-11-30 Eli Zaretskii <eliz@gnu.org>
6657
6658 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6659 attributes are tested _before_ calling verify_row_hash, to protect
6660 against GCC re-ordering of the tests. (Bug#10164)
6661
2b56b87e
JD
66622011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6663
6664 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6665
6666 * xterm.c (handle_one_xevent): Only set async_visible and friends
6667 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6668 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6669 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6670
dbf31225
PE
66712011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6672
6673 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6674 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6675 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6676 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6677 All uses changed to use GCPRO1 etc.
6678 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6679 Revert to old implementation (i.e., before 2011-03-11).
6680
1305621b
YM
66812011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6682
6683 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6684 of scroll runs so as to avoid assigning disabled bogus rows and
6685 unnecessary graphics copy operations.
6686
8c9afb46
EZ
66872011-11-27 Eli Zaretskii <eliz@gnu.org>
6688
6689 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6690 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6691 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6692 (malloc, free, realloc, calloc): Redirect to e_* only when
6693 compiling Emacs.
6694
6695 * lisp.h (GCTYPEBITS): Move before first use.
6696 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6697 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6698 this macro definition.
6699
6700 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6701 _MSC_VER.
6702
54e9e3bf
JD
67032011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6704
6d5eb5b0
SM
6705 * gtkutil.c (xg_create_frame_widgets):
6706 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6707 present with Gtk+ 2.0.
6708
83aca1cb
PE
67092011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6710
6711 * fileio.c (Finsert_file_contents): Undo previous change; see
6712 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6713
5b76caa4
PE
67142011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6715
6716 Rename locals to avoid shadowing.
6717 * fileio.c (Finsert_file_contents):
6718 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6719 * process.c (wait_reading_process_output):
6720 Rename inner 'proc' to 'p' to avoid shadowing.
6721 Indent for consistency with usual Emacs style.
6722
8c535114
EZ
67232011-11-25 Eli Zaretskii <eliz@gnu.org>
6724
6725 * xdisp.c (redisplay_window): If cursor row is not fully visible
6726 after recentering, and scroll-conservatively is set to a large
6727 number, scroll window by a few more lines to make the cursor fully
6728 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6729 (start_display): Don't move to the next line if the display should
6730 start at a newline that is part of a display vector or an overlay
6731 string. (Bug#10119)
8c535114 6732
fa4fdb5c
JL
67332011-11-24 Juri Linkov <juri@jurta.org>
6734
6735 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6736 after the `MagickPingImage' call. (Bug#10112)
6737
90ec88df
CY
67382011-11-23 Chong Yidong <cyd@gnu.org>
6739
6740 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6741
56e2e794
MR
67422011-11-23 Martin Rudalics <rudalics@gmx.at>
6743
6744 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6745 making another buffer current. (Bug#10114)
6746
b6e64c41
GM
67472011-11-23 Glenn Morris <rgm@gnu.org>
6748
6749 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6750
6b21de18
CY
67512011-11-23 Chong Yidong <cyd@gnu.org>
6752
6753 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6754 using it (Bug#5984).
6755
b12cd789
EZ
67562011-11-22 Eli Zaretskii <eliz@gnu.org>
6757
6758 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6759 and header-lines, as they don't have one computed for them.
6760 (Bug#10098)
6761
6762 * .gdbinit (prow): Make displayed values more self-explaining.
6763 Add row's hash code.
6764
261b6fd4
LMI
67652011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6766
6767 * process.c (wait_reading_process_output): Fix asynchrounous
6768 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6769 (wait_reading_process_output): Add comment and URL.
261b6fd4 6770
e7cfd277
JD
67712011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6772
6773 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6774
a9b9b7f5
CY
67752011-11-21 Chong Yidong <cyd@gnu.org>
6776
6777 * window.c (Fnext_window, Fprevious_window): Doc fix.
6778
b0d15b4f
SM
67792011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6780
6781 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6782
fe7a3057
JB
67832011-11-20 Juanma Barranquero <lekktu@gmail.com>
6784
6785 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6786
d2999b1a
MR
67872011-11-20 Martin Rudalics <rudalics@gmx.at>
6788
6789 * window.c (Fset_window_combination_limit): Rename argument
6790 STATUS to LIMIT.
6791 (Vwindow_combination_limit): Remove "status" from doc-string.
6792
d5ff9cd0
AS
67932011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6794
6795 * m/ibms390.h: Remove.
6796 * m/ibms390x.h: Don't include "ibms390.h".
6797
a5bb9bd3
SM
67982011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6799
6800 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6801 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6802
cd1181db
JB
68032011-11-20 Juanma Barranquero <lekktu@gmail.com>
6804
6805 * casetab.c (Fset_case_table):
6806 * charset.c (Fcharset_after): Fix typos.
6807
615a3b8d 68082011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6809
17e845af
PE
6810 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6811 Otherwise, valgrind does not work on some platforms.
6812 Problem reported by Andreas Schwab in
6a0bf43d
PE
6813 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6814 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6815 is set, removing the need for VIRT_ADDRESS_VARIES.
6816 (PURE_P): Use a more-efficient implementation that needs just one
6817 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6818 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6819 to 4 (xorl, subq, cmpq, setbe).
6820 * alloc.c (pure): Always extern now, since that's the
6821 VIRT_ADDR_VARIES behavior.
6822 (PURE_POINTER_P): Use a single comparison, not two, for
6823 consistency with the new puresize.h.
6824 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6825 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6826 Remove VIRT_ADDR_VARIES no longer needed.
6827
f8fe6f96
EZ
68282011-11-19 Eli Zaretskii <eliz@gnu.org>
6829
6830 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6831 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6832 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6833 behave as if the cursor position were at the window margin.
6834
6835 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6836 and the cursor position is out of bounds, behave as if the cursor
6837 position were at the window margin. (Bug#10075)
6838
df05a53c
CY
68392011-11-18 Chong Yidong <cyd@gnu.org>
6840
6841 * window.c (Fwindow_combination_limit): Make first argument
6842 non-optional, since it is meaningless for live windows like the
6843 selected window.
61ccba97 6844
2071918e
DA
68452011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6846
6847 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6848
b50a28de
SM
68492011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6850
6851 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6852 (graft_intervals_into_buffer): Simplify.
6853
015137db
EZ
68542011-11-18 Eli Zaretskii <eliz@gnu.org>
6855
6856 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6857 hash values of the two rows.
6858 (copy_row_except_pointers): Preserve the used[] arrays and the
6859 hash values of the two rows. (Bug#10035)
68c95424 6860 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6861
6862 * xdisp.c (row_hash): New function, body extracted from
6863 compute_line_metrics.
6864 (compute_line_metrics): Call row_hash, instead of computing the
6865 hash code inline.
6866
6867 * dispnew.c (verify_row_hash): Call row_hash for computing the
6868 hash code of a row, instead of duplicating code from xdisp.c.
6869
6870 * dispextern.h (row_hash): Add prototype.
6871
a2addb04
TH
68722011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6873
6874 * frame.c (delete_frame): Don't delete the terminal when the last
6875 X frame is closed if emacs is built with GTK toolkit.
6876
df85d315
JB
68772011-11-17 Juanma Barranquero <lekktu@gmail.com>
6878
6879 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6880
a0c2d0ae
MR
68812011-11-17 Martin Rudalics <rudalics@gmx.at>
6882
6883 * window.c (Vwindow_splits): Rename to
6884 Vwindow_combination_resize. Suggested by Juri Linkov.
6885 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6886 of Vwindow_splits.
6887
58179cce
JB
68882011-11-16 Juanma Barranquero <lekktu@gmail.com>
6889
7877f373
JB
6890 * nsfns.m (Fns_font_name):
6891 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6892
b6f67890
MR
68932011-11-16 Martin Rudalics <rudalics@gmx.at>
6894
6895 * window.h (window): Rename slot "nest" to "combination_limit".
6896 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6897 (Fset_window_nest): Rename to Fset_window_combination_limit.
6898 (Vwindow_nest): Rename to Vwindow_combination_limit.
6899 (recombine_windows, make_parent_window, make_window)
6900 (Fsplit_window_internal, saved_window)
6901 (Fset_window_configuration, save_window_save): Rename all
6902 occurrences of window_nest to window_combination_limit.
6903
c7015153
JB
69042011-11-15 Juanma Barranquero <lekktu@gmail.com>
6905
6906 * image.c (imagemagick_load_image): Fix typo.
6907
322ad6ec
EZ
69082011-11-14 Eli Zaretskii <eliz@gnu.org>
6909
6910 * xdisp.c (display_line): Move the call to
6911 highlight_trailing_whitespace before the call to
6912 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6913 faces of all the glyphs to compute ROW's hash value.
6914 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6915
f067b8ec
JB
69162011-11-14 Juanma Barranquero <lekktu@gmail.com>
6917
6918 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6919 just return (bug#10044).
6920
1e5b2111
EZ
69212011-11-12 Eli Zaretskii <eliz@gnu.org>
6922
7ef3cbd5
EZ
6923 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6924 with user-defined heap size. Bump the default size of the temacs
6925 heap to 27MB, to avoid memory warning when running temacs.
6926 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6927
1e5b2111
EZ
6928 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6929 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6930 (verify_row_hash) [XASSERTS]: New function.
6931 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6932 that the hash value of glyph rows is correct.
1e5b2111 6933
89d61221
MR
69342011-11-12 Martin Rudalics <rudalics@gmx.at>
6935
6936 * window.h (window): Remove splits slot.
6937 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6938 (Fdelete_other_windows_internal, make_parent_window)
6939 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6940 (Fset_window_configuration, save_window_save): Don't deal with
6941 split status of windows.
6942 (saved_window): Remove splits slot.
6943 (Vwindow_splits): Rewrite doc-string.
6944
97f18cc8
JD
69452011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6946
6947 * xfns.c (unwind_create_frame):
6948 * nsfns.m (unwind_create_frame):
6949 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6950 Vframe_list (Bug#9999).
6951
22a648b4
DA
69522011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6953
0b381c7e 6954 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6955
659afede
KH
69562011-11-11 Kenichi Handa <handa@m17n.org>
6957
6958 * callproc.c (Fcall_process): Set the member dst_multibyte of
6959 process_coding.
6960
9ac0394b
KH
69612011-11-11 Johan Bockgård <bojohan@gnu.org>
6962
6963 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6964 avoid a crash (bug#9496).
6965
2fbdc249
CY
69662011-11-09 Chong Yidong <cyd@gnu.org>
6967
6968 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6969 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6970
ac6b1f81
PE
69712011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6972
6973 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6974
09db192c
PE
69752011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6976
6977 Avoid some portability problems by eschewing 'extern inline' functions.
6978 The trivial performance wins aren't worth the portability hassles; see
6979 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6980 et seq.
6981 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6982 (window_box_width, window_box_left, window_box_left_offset)
6983 (window_box_right, window_box_right_offset): Undo previous change,
6984 by removing the "extern"s.
6985 * intervals.c (adjust_intervals_for_insertion)
6986 (adjust_intervals_for_deletion): Undo previous change,
6987 making these static again.
6988 (offset_intervals, temp_set_point_both, temp_set_point)
6989 (copy_intervals_to_string): No longer inline.
6990 * xdisp.c (window_text_bottom_y, window_box_width)
6991 (window_box_height, window_box_left_offset)
6992 (window_box_right_offset, window_box_left, window_box_right)
6993 (window_box): No longer inline.
6994
105216ed
CY
69952011-11-08 Chong Yidong <cyd@gnu.org>
6996
6997 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6998 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6999 Signal an error if not a live window.
105216ed
CY
7000 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
7001 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
7002
ae9e237f
JB
70032011-11-07 Juanma Barranquero <lekktu@gmail.com>
7004
7005 * lisp.h (syms_of_abbrev): Remove declaration.
7006 Reported by CHENG Gao <chenggao@royau.me>.
7007
c7aa8333
EZ
70082011-11-07 Eli Zaretskii <eliz@gnu.org>
7009
7010 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7011 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7012 of temacs in GUI mode.
7013
be7f5545
MR
70142011-11-07 Martin Rudalics <rudalics@gmx.at>
7015
7016 * window.h: Declare delete_all_child_windows instead of
7017 delete_all_subwindows.
7018 * window.c (Fwindow_nest, Fset_window_nest)
7019 (Fset_window_new_total, Fset_window_new_normal)
7020 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7021 (delete_all_subwindows): Rename to delete_all_child_windows.
7022 (Fdelete_other_windows_internal, Fset_window_configuration):
7023 Call delete_all_child_windows instead of delete_all_subwindows.
7024 * frame.c (delete_frame): Call delete_all_child_windows instead
7025 of delete_all_subwindows.
7026
ca78dc43
PE
70272011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7028
7029 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7030 This is also needed for porting to any host where GC_MARK_STACK is
7031 not GC_MAKE_GCPROS_NOOPS.
7032 (which_symbols): Use it.
7033
a0241d01
KH
70342011-11-07 Kenichi Handa <handa@m17n.org>
7035
7036 * coding.c (coding_set_destination): Check coding->src_pos only
7037 when coding->src_object is a buffer (bug#9910).
7038
7039 * process.c (send_process): Set the member src_multibyte of coding
7040 to 0 (bug#9911) when sending a unibyte text.
7041
7042 * callproc.c (Fcall_process): Set the member src_multibyte of
7043 process_coding to 0 (bug#9912).
7044
a64bfdfa 70452011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7046
7047 * xmenu.c (cleanup_widget_value_tree): New function.
7048 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7049 calling free_menubar_widget_value_tree directly (Bug#9830).
7050
cb41b32a
PE
70512011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7052
7053 Fix some portability problems with 'inline'.
7054 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7055 (window_box_width, window_box_left, window_box_left_offset)
7056 (window_box_right, window_box_right_offset): Declare extern.
7057 Otherwise, these inline functions do not conform to C99 and
7058 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7059 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7060 * intervals.c (adjust_intervals_for_insertion)
7061 (adjust_intervals_for_deletion): Now extern, because otherwise the
7062 extern inline functions 'offset_intervals' couldn't refer to it.
7063 (static_offset_intervals): Remove.
7064 (offset_intervals): Rewrite using the old contents of
7065 static_offset_intervals. The old version didn't conform to C99
7066 because an extern inline function contained a reference to an
7067 identifier with static linkage.
7068
b7041366
AS
70692011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7070
7071 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7072 GC.
7073
88a37c4d
EZ
70742011-11-06 Eli Zaretskii <eliz@gnu.org>
7075
7076 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7077 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7078 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7079 return Qleft_to_right.
7080
49745b39
CY
70812011-11-06 Chong Yidong <cyd@gnu.org>
7082
7083 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7084 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7085 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7086 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7087 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7088 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7089 (Fwindow_vscroll): Doc fix.
7090 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7091 argument, since it makes no sense to pass a live window and for
7092 consistency with window-child.
7093
1f05cd82
CS
70942011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7095
7096 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7097 support MSVC.
7098
22610910
JR
70992011-11-05 Jason Rumney <jasonr@gnu.org>
7100
7101 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7102 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7103 fonts (Bug#6029).
7104 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7105 bitwise arithmetic preventing use of unicode-sip and non-truetype
7106 opentype fonts.
7107
a06776b2
EZ
71082011-11-05 Eli Zaretskii <eliz@gnu.org>
7109
3ad924ba
EZ
7110 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7111 "emacs"-only part.
7112
a06776b2
EZ
7113 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7114 initialization code to keep similarity to xfns.c after changes
7115 from 2011-11-05.
7116
c9e7db78
JD
71172011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7118
a97f8f3f
JD
7119 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7120 (unwind_create_frame): New function (Bug#9943).
7121 (Fx_create_frame): Restructure code to be more similar to the one in
7122 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7123 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7124 Move terminal->reference_count++ just before making the frame official
7125 (Bug#9943).
7126
7127 * nsterm.m (x_free_frame_resources): New function.
7128 (x_destroy_window): Move code to x_free_frame_resources.
7129
c9e7db78 7130 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7131 (Fx_create_frame, x_create_tip_frame):
7132 Move terminal->reference_count++ just before making the frame
75f1671a 7133 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7134 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7135
a6fc3b5c
EZ
71362011-11-05 Eli Zaretskii <eliz@gnu.org>
7137
7138 Support MSVC build with newer versions of Visual Studio.
7139 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7140 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7141 nt/gmake.defs.
7142
7143 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7144 which are not supported by MSVC.
7145 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7146 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7147 bitfields.
7148 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7149 types in bitfields.
7150 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7151
7152 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7153
58179cce 71542011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7155
7156 Support MSVC build with newer versions of Visual Studio.
7157 * w32.c: Don't include w32api.h for MSVC.
7158 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7159
7160 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7161 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7162 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7163 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7164 e_* cousins.
7165 (alloca) [_MSC_VER]: Define to _alloca.
7166
7167 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7168
7169 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7170
a58c13ed
EZ
71712011-11-04 Eli Zaretskii <eliz@gnu.org>
7172
7173 * xdisp.c (note_mouse_highlight): If either of
7174 previous/next-single-property-change returns nil, treat that as
7175 the beginning or the end of the buffer. (Bug#9955)
7176
fe0b6370
JD
71772011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7178
a58c13ed 7179 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7180 label is not null (Bug#9951).
7181 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7182 may be NULL.
7183
89bd5ee1
EZ
71842011-11-04 Eli Zaretskii <eliz@gnu.org>
7185
7186 * window.c (Fwindow_body_size): Mention in the doc string that the
7187 return value is in frame's canonical units. (Bug#9949)
7188
84c3edb9
EZ
71892011-11-03 Eli Zaretskii <eliz@gnu.org>
7190
4e2fb5c7
EZ
7191 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7192
84c3edb9 7193 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7194 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7195 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7196
bc17a887
EZ
71972011-11-01 Eli Zaretskii <eliz@gnu.org>
7198
7199 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7200 Don't stop backward scan on the continuation glyph, even though
7201 its CHARPOS is positive.
6d5eb5b0
SM
7202 (mouse_face_from_buffer_pos, note_mouse_highlight):
7203 Rename cover_string to disp_string.
bc17a887 7204
4ee88440
MR
72052011-11-01 Martin Rudalics <rudalics@gmx.at>
7206
7207 * window.c (temp_output_buffer_show): Don't use
7208 Vtemp_buffer_show_specifiers.
7209 (Vtemp_buffer_show_specifiers): Remove unused variable.
7210
c2ff3c02
EZ
72112011-10-30 Eli Zaretskii <eliz@gnu.org>
7212
7213 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7214 past the beginning of the current glyph matrix.
7215
58179cce 72162011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7217
7218 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7219 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7220 HAVE_GTK3 (Bug#9869).
b77a6a7f 7221
3b574623
JD
7222 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7223 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7224
b77a6a7f
JD
7225 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7226
7227 * xterm.c: Declare x_handle_net_wm_state to return int.
7228 (handle_one_xevent): Check if we are iconified but don't have
7229 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7230 (get_current_wm_state): Return non-zero if not hidden,
7231 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7232 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7233 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7234 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7235
196e41e4
PE
72362011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7237
7238 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7239 so that this new function doesn't get optimized away by a
7240 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7241
021f2e1a
AS
72422011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7243
7244 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7245
8b058d44
EZ
72462011-10-29 Eli Zaretskii <eliz@gnu.org>
7247
7248 Fix the `xbytecode' command.
7249 * .gdbinit (xprintbytestr): New command.
b50a28de 7250 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7251 (xbytecode): Print the byte-code string as well.
7252
4452fb80
EZ
72532011-10-29 Kim Storm <storm@cua.dk>
7254
8b058d44
EZ
7255 * alloc.c (which_symbols): New function.
7256
21b72067
AS
72572011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7258
7259 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7260 line. (Bug#9903)
7261
83ed7b5c
GM
72622011-10-29 Glenn Morris <rgm@gnu.org>
7263
7264 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7265 Not clear what it was for, and it causes various bugs. (Bug#9839)
7266
5a7a728b
EZ
72672011-10-28 Eli Zaretskii <eliz@gnu.org>
7268
7269 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7270 possible random value that matches one of those tested as
7271 condition to clear the mouse face.
7272
d3d0842f
CY
72732011-10-28 Chong Yidong <cyd@gnu.org>
7274
7275 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7276
31b39d13
DN
72772011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7278
7279 * window.c (make_window): Initialize phys_cursor_on_p.
7280
9aba6043
SM
72812011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7282
7283 * lisp.h (struct Lisp_Symbol): Update comments.
7284
c20992f4
JB
72852011-10-28 Juanma Barranquero <lekktu@gmail.com>
7286
7287 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7288
db4f02f2
EZ
72892011-10-28 Eli Zaretskii <eliz@gnu.org>
7290
7291 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7292 <oslsachem@gmail.com> for helping to debug this.
7293
7294 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7295 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7296 (g_b_init_get_glyph_outline_w): New static variables.
7297 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7298 (GetGlyphOutlineW_Proc): New typedefs.
7299 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7300 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7301 New functions.
7302 (w32font_open_internal, compute_metrics):
7303 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7304 instead of calling the "wide" APIs directly.
7305
7306 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7307
7308 * w32.h (syms_of_w32font): Add prototype.
7309
87e68db4
JB
73102011-10-27 Juanma Barranquero <lekktu@gmail.com>
7311
7312 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7313 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7314 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7315 (Fmove_to_window_line): Doc fix.
7316
435c1d67
CY
73172011-10-27 Chong Yidong <cyd@gnu.org>
7318
7319 * process.c (make_process): Set gnutls_state to NULL.
7320
7321 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7322 non-NULL, regardless of GNUTLS_INITSTAGE.
7323 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7324 an error. Set process slots as soon as we allocate them.
7325
7326 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7327
9c6c6f49
CY
73282011-10-27 Chong Yidong <cyd@gnu.org>
7329
9aba6043
SM
7330 * gnutls.c (emacs_gnutls_deinit): New function.
7331 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7332 (Fgnutls_deinit, Fgnutls_boot): Use it.
7333
7334 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7335 (deactivate_process): Call emacs_gnutls_deinit.
7336
657d08d3
JB
73372011-10-27 Juanma Barranquero <lekktu@gmail.com>
7338
7339 * image.c (x_create_x_image_and_pixmap):
7340 * w32.c (sys_rename, w32_delayed_load):
7341 * w32font.c (fill_in_logfont):
7342 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7343
5430d399
JB
73442011-10-26 Juanma Barranquero <lekktu@gmail.com>
7345
7346 * w32fns.c (w32_default_color_map): New function,
7347 extracted from Fw32_default_color_map.
a7ef684b 7348 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7349
fe0055fa
PE
73502011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7351
7352 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7353
e6346438
SM
73542011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7355
7356 * keyboard.c (test_undefined): New function (bug#9751).
7357 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7358
e112cc37
ET
73592011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7360
7361 * sysdep.c (init_sys_modes): Fix the check for the controlling
7362 terminal (Bug#6649).
7363
7b5d6677
EZ
73642011-10-20 Eli Zaretskii <eliz@gnu.org>
7365
7366 * dispextern.h (struct bidi_it): New member next_en_type.
7367
7368 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7369 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7370 current character, check also for next_en_type being WEAK_EN.
7371 (bidi_resolve_weak): Don't enter the expensive loop if the current
7372 position is before next_en_pos. Record the bidi type of the first
7373 non-ET, non-BN character we find, in addition to its position.
7374 (bidi_level_of_next_char): Invalidate next_en_type when
7375 next_en_pos is over-stepped.
7376
7da0b018
PE
73772011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7378
7379 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7380 * editfns.c: Rewrite current-time-zone so that it invokes
7381 the equivalent of (format-time-string "%Z") to get the time zone name.
7382 This fixes a bug when the time zone name contains characters that
7383 need converting from the system time locale to Emacs internal format.
7384 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7385 that patch fixed format-time-string to do the conversion, but
7386 I forgot to fix current-time-zone.
7387 (format_time_string): New function, containing most of
7388 what Fformat_time_string used to contain.
7389 (Fformat_time_string): Rewrite in terms of format_time_string.
7390 This doesn't change this function's behavior.
7391 (current-time-zone): Rewrite to use format_time_string.
7392 This fixes the bug reported by Michael Schierl in
7393 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7394 Jason Rumney's 2007-06-07 change worked around this bug, but
7395 didn't fix it.
7396 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7397
8547b010
EZ
73982011-10-19 Eli Zaretskii <eliz@gnu.org>
7399
7400 * xdisp.c (start_display): If the character at POS is displayed
7401 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7402 (try_window_reusing_current_matrix): If a line ends in a display
7403 vector or the next line starts in a display vector, continue
7404 redrawing the window even though the character position of
7405 start_row was reached.
8547b010
EZ
7406 (Bug#9771, part 2)
7407
4e948d15
CY
74082011-10-18 Chong Yidong <cyd@gnu.org>
7409
7410 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7411 with nobreak-char-display too.
7412
4787455f
EZ
74132011-10-18 Eli Zaretskii <eliz@gnu.org>
7414
7415 Fix part 3 of bug#9771.
7416 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7417 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7418 non-neutral characters if the current character is a paragraph
7419 separator (a.k.a. Newline). This avoids running the same
7420 expensive loop twice, once when we consume the preceding newline
7421 and the other time when the line actually needs to be displayed.
7422 Avoid the loop when we see neutrals on the base embedding level
7423 following a character whose directionality is the same as the
7424 paragraph's. This avoids running the expensive loop when a line
7425 ends in a long sequence of neutrals, like control characters.
7426 Add assertion against STRONG_AL type. Slightly rearrange code
7427 that determines the type of a neutral given the first non-neutral
7428 that follows it.
7429 (bidi_level_of_next_char): Set next_en_pos to zero when
7430 invalidating its info.
7431
2c91f553
EZ
74322011-10-17 Eli Zaretskii <eliz@gnu.org>
7433
7434 * xdisp.c (push_display_prop): Determine whether to record string
7435 or buffer position by IT->string, not by IT->method. Allow
7436 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7437 (move_it_vertically_backward): Don't look for character position
7438 immediately after the newline when in a continuation line.
7439 (Bug#9771, part 1)
2c91f553 7440
c7b08b0d
MR
74412011-10-15 Martin Rudalics <rudalics@gmx.at>
7442
7443 * window.c (coordinates_in_window): Rewrite and delabelize
7444 vertical border check. (Bug#5357) (Bug#9618)
7445
6b02f655
SM
74462011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7447
7448 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7449 errors in XSetWindowBorder (bug#9310).
7450
81d40c92
DA
74512011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7452
7453 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7454 avoid crash when xmalloc overrun checking is enabled.
7455
d4172c3b
EZ
74562011-10-13 Eli Zaretskii <eliz@gnu.org>
7457
7458 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7459 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7460 cursor motion with <left> and <right> arrow keys.
7461
7462 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7463 some callers set that themselves.
7464
b00eea75
EZ
74652011-10-12 Eli Zaretskii <eliz@gnu.org>
7466
7467 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7468 display string and the previous row comes from the same string and
7469 is empty. (Bug#9739) (Bug#9738)
7470
8fe012c4
SM
74712011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7472
7473 * doc.c (get_doc_string): Encode file name (bug#9735).
7474
0074aef2
EZ
74752011-10-12 Eli Zaretskii <eliz@gnu.org>
7476
79beb178
EZ
7477 * bidi.c (bidi_level_of_next_char):
7478 * xdisp.c (get_visually_first_element): Remove old incorrect
7479 comments regarding the Unicode Line Separator character.
7480
0074aef2
EZ
7481 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7482
6e4b3fbe
DA
74832011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7484
7485 * alloc.c (Fgc_status): Do not access beyond zombies array
7486 boundary if nzombies > MAX_ZOMBIES.
7487 * alloc.c (dump_zombies): Add missing format specifier.
7488
0324f3af
PE
74892011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7490
b5525cac
PE
7491 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7492 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7493
0324f3af
PE
7494 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7495 Some packages use them to denote characters with modifiers.
7496
e9b5f888
AS
74972011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7498
7499 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7500 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7501 matching a pp-number. Rename parameter var to var1.
7502
127827c0
SM
75032011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7504
7505 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7506
c8fd3bd0
GM
75072011-10-08 Glenn Morris <rgm@gnu.org>
7508
7509 * callint.c (Fcall_interactively): Give a more explicit error for the
7510 'c' case with a non-character input. (Bug#8479)
7511
352ec8ff
EZ
75122011-10-08 Eli Zaretskii <eliz@gnu.org>
7513
03669ccb
EZ
7514 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7515 lines.
7061c986
EZ
7516 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7517 lines that are hscrolled on the left.
03669ccb 7518
352ec8ff
EZ
7519 * dispnew.c (buffer_posn_from_coords): Account for a possible
7520 presence of header-line. (Bug#4426)
7521
a66cfb1c
SM
75222011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7523
6b02f655
SM
7524 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7525 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7526
7c5ee88e
PE
75272011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7528
7529 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7530 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7531 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7532 this makes Emacs dump core during garbage collection on rare
7533 occasions. sizeof is obviously inferior to offsetof here, so
7534 stick with offsetof.
7535 (GC_POINTER_ALIGNMENT): New macro.
7536 (mark_memory): Omit 3rd (offset) arg; caller changed.
7537 Don't assume EMACS_INT alignment is the same as pointer alignment.
7538
df1bbe5b
SM
75392011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7540
7541 * keyboard.c (read_key_sequence_remapped): New var.
7542 (read_key_sequence): Compute remapping in the right buffer.
7543 (command_loop_1): Use read_key_sequence's remapping directly.
7544
51553db6
SM
75452011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7546
32c1fffd
SM
7547 * dired.c (file_name_completion): Don't expand file name.
7548 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7549 before checking file name handler.
7550
51553db6
SM
7551 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7552 they've been requested explicitly (bug#9591).
7553
b6bd1599 75542011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7555
7556 * keymap.c (Fsingle_key_description): Use make_specified_string
7557 instead of build_string to build string from push_key_description.
7558 (Bug#5193)
7559
f701dc2a
PE
75602011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7561
4222c55d
PE
7562 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7563 This fixes a Y2038 bug on 64-bit hosts.
7564 * buffer.c (reset_buffer):
7565 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7566 (Fclear_buffer_auto_save_failure):
7567 Use 0, not -1, to represent an unset failure time, since time_t
7568 might not be signed.
7569
f701dc2a
PE
7570 Remove dependency on glibc malloc internals.
7571 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7572 Move back here from lisp.h, but with their new implementations.
7573 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7574 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7575 * charset.c (charset_table_init): New static var.
7576 (syms_of_charset): Use it instead of xmalloc. This removes a
7577 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7578 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7579 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7580 Move back to alloc.c.
7581 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7582 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7583
9ceebf39
JD
75842011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7585
7586 * nsterm.m (windowDidResize): Call x_set_window_size only when
7587 ns_in_resize is true. Otherwise set pixelwidth/height and
7588 call change_frame_size (Bug#9628).
7589
cb993c58
PE
75902011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7591
3930c88b
PE
7592 Port --enable-checking=all to Fedora 14 x86-64.
7593 * charset.c (syms_of_charset): Also account for glibc malloc's
7594 internal overhead when calculating the initial malloc maximum.
7595
cb993c58
PE
7596 Port --enable-checking=all to Fedora 14 x86.
7597 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7598 Move to lisp.h.
7599 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7600 (overrun_check_realloc, overrun_check_free):
7601 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7602 That way, xmalloc returns a properly-aligned pointer even if
7603 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7604 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7605 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7606 into account when calculating the initial malloc maximum.
7607 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7608 Move here from alloc.c, so that charset.c can use it too.
7609 Properly align; the old code wasn't right for common 32-bit hosts
7610 when configured with --enable-checking=all.
7611 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7612 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7613
31bed486
EZ
76142011-09-29 Eli Zaretskii <eliz@gnu.org>
7615
04c70788 7616 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7617 use EDOM.
7618
fbcaa2f3
EZ
76192011-09-28 Eli Zaretskii <eliz@gnu.org>
7620
7621 * xdisp.c (compute_display_string_end): If there's no display
7622 string at CHARPOS, return -1.
7623
7624 * bidi.c (bidi_fetch_char): When compute_display_string_end
7625 returns a negative value, treat the character as a normal
7626 character not covered by a display string. (Bug#9624)
7627
a239d4e9
JB
76282011-09-28 Juanma Barranquero <lekktu@gmail.com>
7629
7630 * lread.c (Fread_from_string): Fix typo in docstring.
7631
88652fd5
EZ
76322011-09-27 Eli Zaretskii <eliz@gnu.org>
7633
7634 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7635 newline, reseat the iterator instead of bidi-iterating there one
7636 character at a time. (Bug#9610)
32c1fffd
SM
7637 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7638 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7639
ed497dd4
AS
76402011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7641
7642 * lread.c (readevalloop): Use correct code for NBSP.
7643 (read1): Likewise. (Bug#9608)
7644
b2bf61aa
MA
76452011-09-25 Michael Albinus <michael.albinus@gmx.de>
7646
7647 * dbusbind.c (Fdbus_register_signal): When service is not
7648 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7649
32bbb17c
GM
76502011-09-25 Glenn Morris <rgm@gnu.org>
7651
7652 * buffer.c (truncate-lines): Doc fix.
7653
94e0933e
CY
76542011-09-24 Chong Yidong <cyd@stupidchicken.com>
7655
7656 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7657 (Fset_window_next_buffers): Doc fix.
7658
cddde921
GM
76592011-09-24 Glenn Morris <rgm@gnu.org>
7660
7661 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7662
1260aef1
PE
76632011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7664
25b4bfa0
PE
7665 Fix minor problems found by static checking.
7666 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7667 * indent.c (Fvertical_motion): Fix == vs = typo.
7668
e3cbd34b
EZ
76692011-09-24 Eli Zaretskii <eliz@gnu.org>
7670
a66cfb1c
SM
7671 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7672 Default value is now t. Doc fix.
6bf7006f 7673
e3cbd34b 7674 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7675 logic when moving up, not only when moving down. Fix the
e3cbd34b 7676 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7677 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7678
7679 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7680 CHARPOS is covered by a display string which includes newlines.
7681 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7682 is covered by a display string with embedded newlines.
7683
a3de0cbd
MA
76842011-09-24 Michael Albinus <michael.albinus@gmx.de>
7685
7686 * dbusbind.c (Fdbus_register_signal): Add match rule to
7687 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7688 (Fdbus_register_method, Vdbus_registered_objects_table):
7689 Fix docstring.
a3de0cbd 7690
b260039d
JM
76912011-09-24 Jim Meyering <meyering@redhat.com>
7692
32c1fffd 7693 do not ignore write error for any output size
b260039d
JM
7694 The previous change was incomplete.
7695 While it makes emacs --batch detect the vast majority of stdout
7696 write failures, errors were still ignored whenever the output size is
7697 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7698 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7699 && echo FAIL: ignored write error
7700 FAIL: ignored write error
7701 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7702 && echo FAIL: ignored write error
7703 FAIL: ignored write error
7704 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7705
8eca8a7c
AS
77062011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7707
7708 * emacs.c (Fkill_emacs): In noninteractive mode exit
7709 non-successfully if a write error occurred on stdout. (Bug#9574)
7710
3341db62
EZ
77112011-09-21 Eli Zaretskii <eliz@gnu.org>
7712
7713 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7714 the xassert test.
7715
7716 * dispextern.h (struct it): Update the comment documenting what
7717 can it->OBJECT be.
7718
8c203dbf
EZ
77192011-09-20 Eli Zaretskii <eliz@gnu.org>
7720
7721 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7722 a display string, extend search for cursor position to end of row.
7723 (find_row_edges): If the row ends in a newline from a display
7724 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7725 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7726 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7727 non-empty line. Fixes confusing cursor motion with arrow keys at
7728 the beginning of a line that starts with whitespace.
8c203dbf 7729
a4824228
LMI
77302011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7731
7732 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7733 (bug#9493).
7734
33ed493b
CY
77352011-09-18 Chong Yidong <cyd@stupidchicken.com>
7736
7737 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7738 boolean (Bug#9154).
7739
56cd55c8
EZ
77402011-09-18 Eli Zaretskii <eliz@gnu.org>
7741
7742 * xdisp.c (display_line): Record maximum and minimum buffer
7743 positions even if no glyphs were produced (e.g., by a zero-width
7744 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7745 buffer positions that will be removed from the glyph row because
7746 they don't fit.
c02dcedf
EZ
7747 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7748 column is beyond frame width: don't subtract 1 "pixel" when
7749 computing width of the stretch.
3e62b7e0
EZ
7750 (reseat_at_next_visible_line_start): Undo the change made on
7751 2011-09-17 that saved paragraph information and restored it after
7752 the call to `reseat'. (Bug#9545)
56cd55c8 7753
5ed99d36 77542011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7755
7756 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7757 and turn window cursor on if cleared (Bug#9415).
7758
5ed99d36 77592011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7760
7761 * search.c (boyer_moore): Take unibyte characters from pattern
7762 literally. (Bug#9458)
7763
9bade7b2
EZ
77642011-09-18 Eli Zaretskii <eliz@gnu.org>
7765
7766 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7767
e5e9d610
PE
77682011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7769
87e4427a
PE
7770 Fix minor problem found by static checking.
7771 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7772 initialized, to pacify gcc -Wuninitialized.
7773
e5e9d610
PE
7774 * fileio.c: Report proper errno when syscall falls.
7775 (Finsert_file_contents): Save and restore errno,
7776 so that report_file_error outputs the correct diagnostic.
7777 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7778
a1674f0b
EZ
77792011-09-18 Eli Zaretskii <eliz@gnu.org>
7780
7781 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7782
fbfb6dd4
EZ
77832011-09-17 Eli Zaretskii <eliz@gnu.org>
7784
7785 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7786 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7787
bb187662
EZ
77882011-09-17 Eli Zaretskii <eliz@gnu.org>
7789
1137e8b8 7790 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7791 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7792
7793 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7794 (bidi_find_paragraph_start): Search back for paragraph beginning
7795 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7796 (bidi_move_to_visually_next): Only trigger paragraph-related
7797 computations when the last character is a newline or at EOB, not
7798 just any NEUTRAL_B. (Bug#9470)
7799
bb187662
EZ
7800 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7801 truncated lines if point is covered by a display string. (Bug#9524)
7802
2e621251
PE
78032011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7804
7805 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7806 (cons_to_x_long): New function.
7807 (lisp_data_to_selection_data): Use it. Correct the test for
7808 short-versus-long data; it was negated. Break out of vector
7809 loop, for efficiency, when a long datum is discovered.
7810
91a15bc6
SM
78112011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7812
7813 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7814
b41c3a35
EZ
78152011-09-16 Eli Zaretskii <eliz@gnu.org>
7816
7817 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7818 GCC PR/17406) by declaring this function with external scope.
7819
7812ba2d
PE
78202011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7821
7822 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7823 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7824
cf7edc2a
AS
78252011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7826
7827 * editfns.c (Fformat): Correctly handle text properties on "%%".
7828
bd01620e
EZ
78292011-09-15 Eli Zaretskii <eliz@gnu.org>
7830
7831 * xterm.c (x_draw_composite_glyph_string_foreground):
7832 * w32term.c (x_draw_composite_glyph_string_foreground):
7833 * term.c (encode_terminal_code):
7834 * composite.c (composition_update_it, get_composition_id):
7835 * xdisp.c (get_next_display_element)
7836 (fill_composite_glyph_string): Add comments about special meaning
7837 of TAB characters in a composition.
7838
a02719a3
PE
78392011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7840
7841 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7842 This occurs when processing a multibyte format.
7843 Problem reported by Wolfgang Jenker.
a02719a3 7844
72589a3c
JB
78452011-09-15 Johan Bockgård <bojohan@gnu.org>
7846
7847 * xdisp.c (try_cursor_movement): Only check for exact match if
7848 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7849
1c14176c
PE
78502011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7851
7852 Remove unused external symbols.
7853 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7854 * xdisp.c (calc_pixel_width_or_height): Now static.
7855 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7856 * indent.c (check_display_width):
7857 * w32term.c: Fix comment to match code.
7858 * xterm.c, xterm.h (x_catching_errors): Remove.
7859
d2eea5b5
PE
78602011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7861
7862 * xselect.c: Use signed conversions more consistently (Bug#9498).
7863 (selection_data_to_lisp_data): Assume incoming selection data are
7864 signed integers, not unsigned. This is to be consistent with
7865 outgoing selection data, which was modified to use signed integers
7866 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7867 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7868 expects long, not unsigned long.
7869
46888499
EZ
78702011-09-14 Eli Zaretskii <eliz@gnu.org>
7871
7872 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7873 computation of loop end. Reported by Johan Bockgård
7874 <bojohan@gnu.org>.
7875
ef8ef9fb
CY
78762011-09-13 Chong Yidong <cyd@stupidchicken.com>
7877
7878 * frame.c (Fother_visible_frames_p): Function deleted.
7879
fa819fed
EZ
78802011-09-12 Eli Zaretskii <eliz@gnu.org>
7881
7882 * indent.c (compute_motion): Process display vector front to back
7883 rather than the other way around. (Bug#2496)
7884
2ba8e008
SM
78852011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7886
7887 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7888
20f53c69
CY
78892011-09-11 Chong Yidong <cyd@stupidchicken.com>
7890
7891 * minibuf.c (Fread_from_minibuffer): Doc fix.
7892
d562d7a4
EZ
78932011-09-11 Eli Zaretskii <eliz@gnu.org>
7894
7895 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7896 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7897
1c4d7f3d
LMI
78982011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7899
7900 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7901 value for non-existent files.
7902
b885bf36
EZ
79032011-09-11 Eli Zaretskii <eliz@gnu.org>
7904
7905 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7906 set its "size" to -1. This will set the modtime_size field of
7907 the corresponding buffer to -1, which is what
7908 verify-visited-file-modtime expects for files that do not exist.
7909 (Bug#9139)
7910
6612f0bf
PE
79112011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7912
7913 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7914 here ...
7915 * lisp.h: ... from here. push_key_description is no longer
7916 defined in keyboard.c, so its declaration should not be in
7917 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7918 logically belongs with push_key_description.
7919
dfb3f755
PE
79202011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7921
7922 * buffer.h: Include <sys/types.h> instead of <time.h>.
7923 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7924 Problem reported by Herbert J. Skuhra.
7925
3134906c
LMI
79262011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7927
7928 * xml.c (parse_region): Make the parsing work for
7929 non-comment-starting XML files again (bug#9144).
7930
8d903f4e
AS
79312011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7932
7933 * image.c (gif_load): Fix calculation of bottom and right corner.
7934 (Bug#9468)
7935
80ad64f4
EZ
79362011-09-10 Eli Zaretskii <eliz@gnu.org>
7937
7938 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7939 redisplay in small windows.
7940
208a048d
EZ
79412011-09-09 Eli Zaretskii <eliz@gnu.org>
7942
7943 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7944
9b1c252e
MR
79452011-09-08 Martin Rudalics <rudalics@gmx.at>
7946
7947 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7948 Operate on live windows only.
7949
2949f33b
JB
79502011-09-08 Juanma Barranquero <lekktu@gmail.com>
7951
7952 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7953
e08dcafd
EZ
79542011-09-07 Eli Zaretskii <eliz@gnu.org>
7955
7956 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7957 only under bidi iteration.
7958
115b96bd
JD
79592011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7960
7961 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7962
c8199d0f
PE
79632011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7964
7965 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7966 Without this fix, the command to link temacs failed due to an
7967 undefined symbol __builtin_isnan. This is because
7968 /usr/include/iso/math_c99.h #defines isnan(x) to
7969 __builtin_isnan(x), but the bundled gcc, which identifies itself
7970 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7971 a __builtin_isnan.
7972 * floatfns.c (isnan): #undef, and then #define to a clone of
7973 what's in data.c.
7974 (Fisnan): Always define, since it's always available now.
7975 (syms_of_floatfns): Always define isnan at the Lisp level.
7976
e39b275c 79772011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7978
7979 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7980
b2db44d9 79812011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7982
f4af5137 7983 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7984 The previous code assumed that file offsets (off_t values) fit in
7985 EMACS_INT variables, which is not true on typical 32-bit hosts.
7986 The code messed up by falsely reporting buffer overflow in cases
7987 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7988 when "big" contains more than 2**29 bytes, even though this
7989 inserts just one byte and does not overflow the buffer.
7990 (Finsert_file_contents): Store file offsets as off_t
7991 values, not as EMACS_INT values. Check for overflow when
7992 converting between EMACS_INT and off_t. When checking for
7993 buffer overflow or for overlap, take the offsets into account.
7994 Don't use EMACS_INT for small values where int suffices.
7995 When checking for overlap, fix a typo: ZV was used where
7996 ZV_BYTE was intended.
7997 (Fwrite_region): Don't assume off_t fits into 'long'.
7998 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7999
ecfc0a49
MA
80002011-09-05 Michael Albinus <michael.albinus@gmx.de>
8001
8002 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
8003
6511acf2 80042011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 8005
0999621a 8006 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8007
8008 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8009 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8010 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8011 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8012 (modify_event_symbol): Do not assume that the length of
8013 name_alist_or_stem is safe to alloca and fits in int.
8014 (Fexecute_extended_command): Likewise for function name and binding.
8015 (Frecursion_depth): Wrap around reliably on integer overflow.
8016 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8017 since some callers pass EMACS_INT values.
8018 (Fsingle_key_description): Don't crash if symbol name contains more
8019 than MAX_ALLOCA bytes.
8020 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8021 (get_minibuffer): Arg is now EMACS_INT, not int.
8022 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8023 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8024 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8025
2be7d702
PE
8026 * dbusbind.c (signature_cat): New function.
8027 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8028 Do not overrun buffer; instead, report string overflow.
8029
9d1df220
PE
8030 * dispnew.c (add_window_display_history): Don't overrun buffer.
8031 Truncate instead; this is OK since it's just a log.
8032
33ef5c64
PE
8033 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8034 even if the time zone offset is outlandishly large.
8035 Don't mishandle offset == INT_MIN.
8036
66c6fdd5
PE
8037 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8038 when creating daemon; the previous buffer-overflow check was incorrect.
8039
d749b01b
PE
8040 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8041 which has the guts of the old verror function.
8042
b5cd1905
PE
8043 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8044 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8045
6e1a67fb
PE
8046 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8047 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8048 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8049 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8050 length of string rather than counting it via multiple sprintfs;
8051 that's simpler and more reliable.
c21721cc
PE
8052 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8053 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8054 sprintf, in case result does not fit in int.
8055
c57b67fc
PE
8056 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8057 (fontset_from_font): Print it.
8058
8a401434
PE
8059 * frame.c (tty_frame_count): Now printmax_t, not int.
8060 (make_terminal_frame, set_term_frame_name): Print it.
8061 (x_report_frame_params): In X, window IDs are unsigned long,
8062 not signed long, so print them as unsigned.
8063 (validate_x_resource_name): Check for implausibly long names,
8064 and don't assume name length fits in 'int'.
8065 (x_get_resource_string): Don't blindly alloca invocation name;
8066 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8067 not fit in int.
8068
6e1a67fb
PE
8069 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8070 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8071 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8072
0df02bf3
PE
8073 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8074 Use esprintf, not sprintf, in case result does not fit in int.
8075
48e30793
PE
8076 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8077 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8078 it as a large positive number.
8079 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8080 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8081
a66ff6d8
PE
8082 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8083 in case result does not fit in int.
8084
aca216ff
PE
8085 * print.c (float_to_string): Detect width overflow more reliably.
8086 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8087 buffer overrun. Don't assume list length fits in 'int'. Treat
8088 print length of 0 as 0, not as infinity; to be consistent with other
8089 uses of print length in this function. Don't overflow print length
8090 index. Don't assume hash table size fits in 'long', or that
8091 vectorlike size fits in 'unsigned long'.
8092
31c286f7
PE
8093 * process.c (make_process): Use printmax_t, not int, to format
8094 process-name gensyms.
8095
55e5faa1
PE
8096 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8097
80f2e268
PE
8098 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8099 to avoid potential buffer overrun.
8100
670741ab
PE
8101 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8102 if X resource line is longer than 512 bytes.
8103
b7163a50
PE
8104 * xfns.c (x_window): Make sprintf buffer a bit bigger
8105 to avoid potential buffer overrun.
8106
ae58ff1f
PE
8107 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8108
c43c8a6a
PE
8109 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8110
3f8236f4
PE
81112011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8112
53e9fe90 8113 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8114 Without these, Emacs silently mishandles large integers sometimes.
8115 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8116 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8117
6511acf2
PE
8118 * xdisp.c (try_window_id): Check Emacs fixnum range before
8119 converting to 'int'.
806add1d 8120
6511acf2 8121 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8122 Check that an Emacs fixnum is in range before assigning it to 'int'.
8123 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8124 values converted from Emacs fixnums.
8125 (Frecenter): Don't wrap around a line count if it is out of 'int'
8126 range; instead, treat it as an extreme value.
8127 (Fset_window_configuration, compare_window_configurations):
8128 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8129
6511acf2
PE
8130 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8131 that can exceed INT_MAX. Check that EMACS_INT value is in range
8132 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8133 (match_limit): Don't assume that a fixnum can fit in 'int'.
8134
6511acf2 8135 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8136 exceed INT_MAX.
8137
6511acf2 8138 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8139 (Fvertical_motion): Don't wrap around LINES values that don't fit
8140 in 'int'. Instead, treat them as extreme values. This is good
8141 enough for windows, which can't have more than INT_MAX lines anyway.
8142
fcb901a7
LMI
81432011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8144
0f2f6b6d
LMI
8145 * Require libxml/parser.h to avoid compilation warning.
8146
fcb901a7
LMI
8147 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8148
8149 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8150 since this reportedly can destroy thread storage.
8151
6e20a0d4
CY
81522011-08-30 Chong Yidong <cyd@stupidchicken.com>
8153
8154 * syntax.c (find_defun_start): Update all cache variables if
8155 exiting early (Bug#9401).
8156
148ae00e
EZ
81572011-08-30 Eli Zaretskii <eliz@gnu.org>
8158
f6cfbd8f
EZ
8159 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8160
148ae00e
EZ
8161 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8162 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8163 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8164
8165 * term.c (tty_append_glyph): New function.
8166 (produce_stretch_glyph): Static function and its prototype deleted.
8167
a66cfb1c
SM
8168 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8169 Add prototypes.
148ae00e 8170
c4a07a4c
PE
81712011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8172
8173 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8174 when checking :margin (Bug#9390).
8175 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8176 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8177 so that the name doesn't mislead. All uses changed.
8178
6bc8cd65
JB
81792011-08-28 Johan Bockgård <bojohan@gnu.org>
8180
8181 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8182 set_tty_hooks.
8183
dca4927e
EZ
81842011-08-27 Eli Zaretskii <eliz@gnu.org>
8185
8186 * xdisp.c (move_it_to): Don't bail out early when reaching
8187 position beyond to_charpos, if we are scanning backwards.
8188 (move_it_vertically_backward): When DY == 0, make sure we get to
8189 the first character in the line after the newline.
8190
f2cad773
PE
81912011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8192
8193 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8194 (ccl_driver): Do not generate an out-of-range pointer.
8195 (Fccl_execute_on_string): Remove unnecessary check for
8196 integer overflow, noted by Stefan Monnier in
8197 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8198 Remove a FIXME that didn't need fixing.
8199 Simplify the newly-introduced buffer reallocation code.
8200
0cae2cdb
JB
82012011-08-27 Juanma Barranquero <lekktu@gmail.com>
8202
8203 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8204
5fc295a4 82052011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8206
70c60eb2 8207 Integer and memory overflow issues (Bug#9196).
726e0ab1 8208
d31850da
PE
8209 * doc.c (get_doc_string): Rework so that
8210 get_doc_string_buffer_size is the actual buffer size, rather than
8211 being 1 less than the actual buffer size; this makes xpalloc more
8212 convenient.
8213
a69fbedb
PE
8214 * image.c (x_allocate_bitmap_record, cache_image):
8215 * xselect.c (Fx_register_dnd_atom):
8216 Simplify previous changes by using xpalloc.
8217
fe5c5d37
PE
8218 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8219 since either will do and ptrdiff_t is convenient with xpalloc.
8220
0065d054
PE
8221 * charset.c (charset_table_size)
8222 (struct charset_sort_data.priority): Now ptrdiff_t.
8223 (charset_compare): Don't overflow if priorities differ greatly.
8224 (Fsort_charsets): Don't assume list length fits in int.
8225 Check for size-calculation overflow when allocating sort data.
8226 (syms_of_charset): Allocate an initial charset table that is
8227 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8228
8229 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8230
8231 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8232 The actual value is always <= INT_MAX, and leaving it unsigned made
8233 overflow checking harder.
8234
8235 * dispextern.h (struct glyph_matrix.rows_allocated)
8236 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8237 with xpalloc. The values are still always <= INT_MAX.
8238
8239 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8240
8241 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8242 (SAFE_NALLOCA): New macro.
8243
8244 * region-cache.c (struct boundary.pos, find_cache_boundary)
8245 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8246 (set_cache_region, invalidate_region_cache)
8247 (revalidate_region_cache, know_region_cache, region_cache_forward)
8248 (region_cache_backward, pp_cache):
8249 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8250 so that ptrdiff_t * can be passed to xpalloc.
8251 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8252 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8253 (pp_cache): Don't assume cache_len fits in int.
8254 * region-cache.h: Adjust extern decls to match.
8255
8256 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8257 EMACS_INT, since either will do, for xpalloc.
8258
8259 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8260 (xnmalloc, xnrealloc, xpalloc): New functions.
8261
726e0ab1
PE
8262 * bidi.c (bidi_shelve_header_size): New constant.
8263 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8264 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8265
51f30bc5 8266 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8267 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8268 (overlay_strings):
8269 Don't update size of array until after memory allocation succeeds,
8270 because xmalloc/xrealloc may not return.
0065d054
PE
8271 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8272 now that we have proper integer overflow checking.
8273 (record_overlay_string, overlay_strings): Catch overflows when
8274 calculating size of overlay_str_buf.
726e0ab1 8275
0065d054
PE
8276 * callproc.c (Fcall_process): Check for size overflow when
8277 calculating size of args2.
8278 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8279 Normally we prefer signed values, but sticking with ptrdiff_t would
8280 require adding more-complicated checks.
726e0ab1
PE
8281
8282 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8283 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8284 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8285 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8286
8287 * character.c (Fstring): Check for size-calculation overflow.
8288
8289 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8290 unnecessary integer overflow. Check for size overflow.
8291 (encode_coding_object): Don't update size until xmalloc succeeds.
8292
8293 * composite.c (get_composition_id): Check for overflow in glyph
8294 length calculations.
8295
8296 Integer and memory overflow fixes for display code.
8297 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8298 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8299 (scrolling_window): Check for overflow in size calculations.
8300 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8301 Don't assume glyph table len fits in int.
8302 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8303 (row_table_size): Now ptrdiff_t, not int.
8304 (scrolling_window): Avoid overflow in size calculations.
8305 Don't update size until allocation succeeds.
8306 * fns.c (concat): Check for overflow in size calculations.
8307 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8308 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8309 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8310
8311 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8312 (get_doc_string): Check for size calculation overflow.
8313 Don't update size until allocation succeeds.
8314 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8315 EMACS_INT, where ptrdiff_t will do.
8316 (Fsubstitute_command_keys): Check for string overflow.
8317
8318 * editfns.c (set_time_zone_rule): Don't assume environment length
8319 fits in int.
8320 (message_length): Now ptrdiff_t, not int.
8321 (Fmessage_box): Don't update size until allocation succeeds.
8322 Don't assume message length fits in int.
8323 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8324
0065d054
PE
8325 * emacs.c (main): Do not reallocate argv, since there is a null at
8326 the end that can be overwritten, and this way there's no need to
8327 worry about size-calculation overflow.
8328 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8329
8330 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8331 alloc succeeds.
8332 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8333
8334 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8335 (x_set_scroll_bar_width, x_figure_window_size):
8336 Check for integer overflow.
8337 (x_set_alpha): Do not assume XINT fits in int.
8338
8339 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8340 This is for the members text_lines, text_cols, total_lines, total_cols,
8341 where the system imposes an 'int' limit.
8342
8343 * fringe.c (Fdefine_fringe_bitmap):
8344 Don't update size until alloc works.
8345
8346 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8347 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8348
8349 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8350 Check for size-calculation overflow.
8351 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8352 do, as we prefer signed integers.
8353 (id_to_widget.max_size, id_to_widget.used)
8354 (xg_store_widget_in_map, xg_remove_widget_from_map)
8355 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8356 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8357 Use and return ptrdiff_t, not int.
8358 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8359 * gtkutil.h: Change prototypes to match the above.
8360
8361 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8362 are duplicate now that they've been promoted to lisp.h.
8363 (x_allocate_bitmap_record, x_alloc_image_color)
8364 (make_image_cache, cache_image, xpm_load):
8365 Don't update size until alloc is done.
8366 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8367 (x_detect_edges):
3256efce 8368 Check for size calculation overflow.
726e0ab1
PE
8369 (ct_colors_allocated_max): New constant.
8370 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8371 overflow.
3256efce 8372
726e0ab1
PE
8373 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8374 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8375 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8376 Use ptrdiff_t, not int, to count maps.
8377 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8378 calculations. Don't update size until allocation succeeds.
8379 Redo calculations to avoid overflow.
726e0ab1
PE
8380 * keyboard.h: Change prototypes to match the above.
8381
8382 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8383 to count maps.
8384 (current_minor_maps): Check for size calculation overflow.
8385 * keymap.h: Change prototypes to match the above.
8386
8387 * lread.c (read1, init_obarray): Don't update size until alloc done.
8388
8389 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8390 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8391
726e0ab1
PE
8392 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8393 Now ptrdiff_t, not int.
8394 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8395 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8396
8397 * process.c (Fnetwork_interface_list): Check for overflow
8398 in size calculation.
8399
8400 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8401
8402 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8403 overflow. Don't bother calling xmalloc when xrealloc will do.
8404
8405 * search.c (Freplace_match): Check for size calculation overflow.
8406 (Fset_match_data): Don't assume list lengths fit in 'int'.
8407
8408 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8409 for command line length. Do not attempt to address one before the
8410 beginning of an array, as that's not portable.
8411
8412 * term.c (max_frame_lines): Remove; unused.
8413 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8414 not int.
8415 (encode_terminal_code, calculate_costs): Check for size
8416 calculation overflow.
8417 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8418 table lengths and related sizes. Don't update size until alloc
8419 done. Redo calculations to avoid overflow.
8420 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8421
8422 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8423 subtracting pointers.
8424 (gobble_line): Check for overflow more carefully. Don't update size
8425 until alloc done.
8426
8427 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8428 Don't update size until alloc done.
8429 Redo size calculations to avoid overflow.
8430 Check for size calculation overflow.
0065d054 8431 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8432
8433 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8434 Use ptrdiff_t, not int, for sizes.
8435 (store_mode_line_noprop_char): Don't update size until alloc done.
8436
0065d054
PE
8437 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8438 Use ptrdiff_t, not int, for sizes.
8439 (Finternal_make_lisp_face, cache_face):
8440 Check for size calculation overflow.
8441 (cache_face): Treat size calculation overflows as if they were
8442 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8443
8444 * xfns.c (x_encode_text, x_set_name_internal)
8445 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8446 sizes, since they can exceed INT_MAX in size. Check for size
8447 calculation overflow.
8448
0065d054
PE
8449 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8450 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8451 Don't update size until alloc done.
8452
0065d054 8453 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8454 as sprintf is limited to int lengths.
1d526e2f 8455
252c5ee1
PE
8456 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8457 (X_LONG_MIN): New macros.
864d7ce7
PE
8458 Use them to make the following changes clearer.
8459 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8460 This change doesn't affect the value now, but it may help remind
8461 future maintainers not to raise the value too much later.
8462 (SELECTION_QUANTUM): Remove, replacing with ...
8463 (selection_quantum): ... new function, which avoids overflow.
8464 All uses changed.
8465 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8466 assumption that selection length fits in 'int'.
8467 (x_reply_selection_request, x_handle_selection_request)
8468 (x_get_window_property, receive_incremental_selection)
8469 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8470 (lisp_data_to_selection_data, clean_local_selection_data):
8471 Use ptrdiff_t, not int, to record length of selection.
8472 (x_reply_selection_request, x_get_window_property)
8473 (receive_incremental_selection, x_property_data_to_lisp):
8474 Redo calculations to avoid overflow.
8475 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8476 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8477 something.
8478 (x_get_window_property, receive_incremental_selection)
8479 (lisp_data_to_selection_data, x_property_data_to_lisp):
8480 Check for size-calculation overflow.
8481 (x_get_window_property, receive_incremental_selection)
8482 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8483 Don't store size until memory allocation succeeds.
8484 (x_get_window_property): Plug memory leak on memory exhaustion.
8485 Don't double-block input; malloc is safe here. Don't assume 2**34
8486 - 4 fits in unsigned long. Add an xassert to check
8487 XGetWindowProperty overflow. Be more careful about overflow
8488 calculations, and distinguish size from memory overflow better.
8489 (receive_incremental_selection): When tracing, don't assume
8490 unsigned int is less than INT_MAX.
8491 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8492 harmful) conversions of unsigned short to int.
8493 (lisp_data_to_selection_data): Don't assume that integers
8494 in the range -65535 through -1 fit in an X unsigned short.
8495 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8496 result parameters unless successful. Rely on cons_to_unsigned
8497 to report problems with elements; the old code wasn't right anyway.
8498 (x_check_property_data): Check for int overflow; we cannot use
8499 a wider type due to X limits.
8500 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8501
726e0ab1 8502 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8503
0065d054
PE
8504 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8505 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8506 (x_color_cells): Don't store size until memory allocation succeeds.
8507 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8508 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8509 (x_term_init): Don't assume length fits in int (sprintf is limited
8510 to int size).
bc18e09d 8511
ebfa62c0
PE
8512 Use ptrdiff_t for composition IDs.
8513 * character.c (lisp_string_width):
8514 * composite.c (composition_table_size, n_compositions)
8515 (get_composition_id, composition_gstring_from_id):
8516 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8517 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8518 * window.c (Frecenter):
8519 Use ptrdiff_t, not int, for composition IDs.
8520 * composite.c (get_composition_id): Check for integer overflow.
8521 * composite.h: Adjust prototypes to match the above changes.
8522
d3411f89
PE
8523 Use ptrdiff_t for hash table indexes.
8524 * category.c (hash_get_category_set):
8525 * ccl.c (ccl_driver):
8526 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8527 * coding.c (coding_system_charset_list, detect_coding_system):
8528 * coding.h (struct coding_system.id):
8529 * composite.c (get_composition_id, gstring_lookup_cache):
8530 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8531 * image.c (xpm_get_color_table_h):
8532 * lisp.h (hash_lookup, hash_put):
8533 * minibuf.c (Ftest_completion):
8534 Use ptrdiff_t for hash table indexes, not int (which is too
8535 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8536 32-bit --with-wide-int hosts).
8537
e097a6fa
PE
8538 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8539 Add a FIXME comment about memory leaks.
8540 (syms_of_charset): Don't assume xmalloc returns.
8541
5637687f
PE
8542 Don't assume that stated character widths fit in int.
8543 * character.c (Fchar_width, c_string_width, lisp_string_width):
8544 * character.h (CHAR_WIDTH):
8545 * indent.c (MULTIBYTE_BYTES_WIDTH):
8546 Use sanitize_char_width to avoid undefined and/or bad behavior
8547 with outlandish widths.
a66cfb1c 8548 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8549 now that we have two such functions. All uses changed.
8550 (sanitize_char_width): New inline function.
8551
a2271ba2
PE
8552 Don't assume that tab-width fits in int.
8553 * character.h (sanitize_width): New inline function.
8554 (SANE_TAB_WIDTH): New macro.
8555 (ASCII_CHAR_WIDTH): Use it.
8556 * indent.c (sane_tab_width): Remove. All uses replaced by
8557 SANE_TAB_WIDTH (current_buffer).
8558 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8559
18c52557
PE
8560 * fileio.c: Integer overflow issues with file modes.
8561 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8562
caeeedc1
PE
8563 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8564 Remove unreachable code.
8565 (read_hex, load_charset_map_from_file): Check for integer overflow.
8566
6df6ae42 8567 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8568 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8569 (x_send_scroll_bar_event): Likewise. Check that the size does not
8570 exceed limits imposed by XClientMessageEvent, as well as the usual
8571 ptrdiff_t and size_t limits.
8572
b13995db
PE
8573 * keyboard.c: Overflow, signedness and related fixes.
8574 (make_lispy_movement): Use same integer type in forward decl
8575 that is used in the definition.
8576 (read_key_sequence, keyremap_step):
8577 Change bufsize argument back to int, undoing my 2011-03-30 change.
8578 We prefer signed types, and int is wide enough here.
8579 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8580 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8581 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8582 length, not size_t. Use ptrdiff_t for index, not int.
8583 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8584 possibility of integer overflow.
8585
13464394
PE
8586 Overflow, signedness and related fixes for images.
8587
8588 * dispextern.h (struct it.stack[0].u.image.image_id)
8589 (struct_it.image_id, struct image.id, struct image_cache.size)
8590 (struct image_cache.used, struct image_cache.ref_count):
8591 * gtkutil.c (update_frame_tool_bar):
8592 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8593 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8594 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8595 * nsmenu.m (update_frame_tool_bar):
8596 * xdisp.c (calc_pixel_width_or_height):
8597 * xfns.c (image_cache_refcount):
8598 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8599 on typical 64-bit hosts.
8600
8601 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8602 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8603 Omit unnecessary casts to int.
8604 (parse_image_spec): Check that integers fall into 'int' range
8605 when the callers expect that.
8606 (image_ascent): Redo ascent calculation to avoid int overflow.
8607 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8608 (lookup_image): Remove unnecessary tests.
8609 (xbm_image_p): Locals are now of int, not EMACS_INT,
8610 since parse_image_check makes sure they fit into int.
8611 (png_load, gif_load, svg_load_image):
8612 Prefer int to unsigned where either will do.
8613 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8614 old tiff_error_handler and tiff_warning_handler.
8615 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8616 stack buffer overflows. It uses only the features of vsnprintf
8617 that are common to both POSIX and native Microsoft.
8618 (tiff_error_handler, tiff_warning_handler): Use it.
8619 (tiff_load, gif_load, imagemagick_load_image):
8620 Don't assume :index value fits in 'int'.
8621 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8622 (imagemagick_load_image): Check that crop parameters fit into
8623 the integer types that MagickCropImage accepts. Don't assume
8624 Vimagemagick_render_type has a nonnegative value. Don't assume
8625 size_t fits in 'long'.
8626 (gs_load): Use printmax_t to print the widest integers possible.
8627 Check for integer overflow when computing image height and width.
8628
c11821d4
EZ
86292011-08-26 Eli Zaretskii <eliz@gnu.org>
8630
8631 * xdisp.c (redisplay_window): Don't force window start if point
8632 will be invisible in the resulting window. (Bug#9324)
8633
0c95fcf7
EZ
86342011-08-25 Eli Zaretskii <eliz@gnu.org>
8635
8636 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8637 the display spec is of the form `(space ...)'.
8638 (handle_display_spec): Return the value returned by
8639 handle_single_display_spec, not just 1 or zero.
8640 (handle_single_display_spec): If the display spec is of the form
8641 `(space ...)', and specifies display in the text area, return 2
8642 rather than 1.
fee65a97 8643 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8644 accurately, and prefer exact match for point under bidi.
8645 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8646
8647 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8648 into disp_prop; all users changed.
8649
8650 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8651 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8652 for the text covered by the display property.
8653
e4ed06f1
CY
86542011-08-25 Chong Yidong <cyd@stupidchicken.com>
8655
8656 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8657 Change return value to nil.
8658 (Frecord_buffer): Delete unused function.
8659
f67cdd7f
EZ
86602011-08-24 Eli Zaretskii <eliz@gnu.org>
8661
5980d4c6
EZ
8662 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8663 buffers, return left-to-right.
8610fe8b
EZ
8664 (set_cursor_from_row): Consider candidate row a win if its glyph
8665 represents a newline and point is on that newline. Fixes cursor
8666 positioning on the newline at EOL of R2L text within L2R
8667 paragraph, and vice versa.
8668 (try_cursor_movement): Check continued rows, in addition to
8669 continuation rows. Fixes unwarranted scroll when point enters a
8670 continued line of R2L text within an L2R paragraph, or vice versa.
8671 (cursor_row_p): Consider the case of point being equal to
8672 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8673 from the end of a short line to the beginning of a continued line
8674 of R2L text within L2R paragraph.
8675 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8676 composed characters.
5980d4c6 8677
f67cdd7f
EZ
8678 * bidi.c (bidi_check_type): Use xassert.
8679 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8680 members.
8681
bca633fb
EZ
86822011-08-23 Eli Zaretskii <eliz@gnu.org>
8683
8684 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8685 a character.
8686
4a5885a7
CY
86872011-08-23 Chong Yidong <cyd@stupidchicken.com>
8688
8689 * nsfont.m (ns_otf_to_script): Fix typo.
8690
0902a04e
KH
86912011-08-22 Kenichi Handa <handa@m17n.org>
8692
8693 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8694 extra slot even if the purpose is char-code-property-table.
8695
1a2e6670
EZ
86962011-08-23 Eli Zaretskii <eliz@gnu.org>
8697
8ddde651
EZ
8698 * xdisp.c (redisplay_window): When computing centering_position,
8699 account for the height of the header line. (Bug#8874)
8700
425cc014
EZ
8701 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8702 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8703 candidate is selected by the mouse, and that candidate has a
8704 composed character under the mouse.
8705
1a2e6670
EZ
8706 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8707 coordinates reported by pos-visible-in-window-p for a composed
8708 character in column zero.
8709
8b76d6f8
SM
87102011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8711
8712 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8713
dac347dd
EZ
87142011-08-22 Eli Zaretskii <eliz@gnu.org>
8715
8716 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8717 consider it a hit if to_charpos is anywhere in the range of the
8718 composed buffer positions.
8719
e013fb34
CY
87202011-08-22 Chong Yidong <cyd@stupidchicken.com>
8721
8722 * image.c (gif_load): Don't assume that each subimage has the same
8723 dimensions as the base image. Handle disposal method that is
8724 "undefined" by the gif spec (Bug#9335).
8725
bd1ba3e8
CY
87262011-08-20 Chong Yidong <cyd@stupidchicken.com>
8727
8728 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8729 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8730
54a1215b
EZ
87312011-08-19 Eli Zaretskii <eliz@gnu.org>
8732
823564e5
EZ
8733 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8734 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8735 from an Org mode buffer to a Speedbar frame.
8736
54a1215b
EZ
8737 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8738 a composition, take its buffer position from IT->cmp_it.charpos.
8739 Fixes cursor positioning at the beginning of a line that begins
8740 with a composed character.
8741
9778ebcc
EZ
87422011-08-18 Eli Zaretskii <eliz@gnu.org>
8743
0be6ee06
EZ
8744 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8745 character bidirectional type, use STRONG_L instead. Fixes crashes
8746 in a buffer produced by `describe-categories'.
8747
9778ebcc
EZ
8748 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8749 members before the level stack, so they would be saved and
8750 restored when copying iterator state. Fixes incorrect reordering
8751 around TABs covered by display properties.
8752
156bffbe
AS
87532011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8754
6b02f655 8755 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8756
72ad093b
CY
87572011-08-17 Chong Yidong <cyd@stupidchicken.com>
8758
8759 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8760 (internal_condition_case_2, internal_condition_case_n):
8761 Remove unnecessary aborts (Bug#9081).
72ad093b 8762
35774242
EZ
87632011-08-17 Eli Zaretskii <eliz@gnu.org>
8764
8765 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8766 has no `load' handler, try opening the file locally. (Bug#9311)
8767
db76dd85
KB
87682011-08-16 Ken Brown <kbrown@cornell.edu>
8769
8770 * gmalloc.c: Expand comment.
8771
b215eee5
EZ
87722011-08-16 Eli Zaretskii <eliz@gnu.org>
8773
8774 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8775 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8776
a4579d33
KB
87772011-08-16 Ken Brown <kbrown@cornell.edu>
8778
8779 Fix memory allocation problems in Cygwin build (Bug#9273).
8780
8781 * unexcw.c ( __malloc_initialized): Declare external variable.
8782 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8783
8b76d6f8
SM
8784 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8785 New variables.
a4579d33
KB
8786 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8787 dumped emacs.
8788 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8789 in the static heap.
8790 [CYGWIN] (special_realloc): New function.
8791 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8792 requests to realloc storage in the static heap.
8793
3ebec551
PE
87942011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8795
8796 * bidi.c (bidi_initialize): Remove unused local.
8797
9fd8be00
EZ
87982011-08-15 Eli Zaretskii <eliz@gnu.org>
8799
6b02f655
SM
8800 * bidimirror.h:
8801 * biditype.h: Remove file.
8802 * makefile.w32-in ($(BLD)/bidi.$(O)):
8803 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8804
8805 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8806
8807 * chartab.c: Improve commentary for the uniprop_table API.
8808
32413314
EZ
8809 * bidi.c (bidi_paragraph_init): Support zero value of
8810 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8811 (bidi_initialize): Use uniprop_table instead of including
8812 biditype.h and bidimirror.h.
32413314 8813
9fd8be00
EZ
8814 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8815 coordinates of the iterator when restoring from ppos_it.
8816 (Bug#9296)
8817
5cf2b69b
KH
88182011-08-14 Kenichi Handa <handa@m17n.org>
8819
8820 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8821 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8822
daf17d00
EZ
88232011-08-14 Eli Zaretskii <eliz@gnu.org>
8824
8825 * xdisp.c (move_it_in_display_line_to): Don't invoke
8826 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8827 ppos_it. Fixes vertical cursor motion when line beginning is
8828 covered by an image. (Bug#9296)
8829
08e3161a
JD
88302011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8831
8832 * nsterm.h (ns_run_ascript): Declare.
8833 (NSAPP_DATA2_RUNASSCRIPT): Define.
8834
8835 * nsfns.m (as_script, as_result, as_status): New static variables.
8836 (ns_run_ascript): New function.
5e617bc2 8837 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8838 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8839 the event loop. Get status from as_status (Bug#7276).
8840
8841 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8842 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8843 the event loop (Bug#7276).
8844
a3720aa2
AS
88452011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8846
8847 * gnutls.c (QCgnutls_bootprop_priority)
8848 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8849 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8850 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8851 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8852 (QCgnutls_bootprop_verify_hostname_error)
8853 (QCgnutls_bootprop_callbacks_verify): Rename from
8854 Qgnutls_bootprop_..., all uses changed.
8855
8856 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8857 uses changed.
8858
0a0d27fb
PE
88592011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8860
19d5c50c
PE
8861 * xfaces.c (Qframe_set_background_mode): Now static.
8862 * dispextern.h (Qframe_set_background_mode): Remove decl.
8863
0a0d27fb
PE
8864 * process.c (Fnetwork_interface_info): Declare local only if needed.
8865
377538cb
JD
88662011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8867
8868 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8869 (Fnetwork_interface_list): Allocate in increments of bytes instead
8870 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8871 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8872 sockaddr.
8873 (struct ifflag_def): notrailers is smart on OSX.
8874 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8875 Get hardware address with getifaddrs if available.
8876
08fff70c
EZ
88772011-08-12 Eli Zaretskii <eliz@gnu.org>
8878
8879 * xdisp.c (iterate_out_of_display_property): xassert that
8880 IT->position is set to within IT->object's boundaries. Break from
8881 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8882 when IT->position is set up wrongly due to some bug.
8883 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8884 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8885 entry. Force push_it to save on the stack the current
8886 buffer/string position, to be restored by pop_it. Fix flags in
8887 the iterator structure wrt the object coming from a display
8888 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8889 properties. (Bug#9284)
8890
7be1c708 88912011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8892
7be1c708
CY
8893 * fontset.c (fontset_get_font_group): Add proper type checks.
8894 (Bug#9172)
aac0c6e3 8895
7be1c708 88962011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8897
7be1c708
CY
8898 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8899 and LC_VERSION_MIN_MACOSX.
8900 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8901 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8902
97bb72a6
EZ
89032011-08-08 Eli Zaretskii <eliz@gnu.org>
8904
8905 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8906 no-display-properties-and-no-overlays under bidi display.
8907 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8908 properties and overlays.
97bb72a6 8909
d5617611
CY
89102011-08-08 Chong Yidong <cyd@stupidchicken.com>
8911
37e11a63
CY
8912 * editfns.c (Fset_time_zone_rule): Document relationship with the
8913 setenv function.
8914
d5617611
CY
8915 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8916 the font entity extracted from the cache (Bug#8109).
8917
58872834
CY
89182011-08-07 Chong Yidong <cyd@stupidchicken.com>
8919
8920 * composite.c (autocmp_chars): Don't reset point. That is done by
8921 restore_point_unwind (Bug#5984).
8922
75bfc667
JL
89232011-08-07 Juri Linkov <juri@jurta.org>
8924
8925 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8926 to show the arg `TIME' instead of `TIMEVAL'.
8927
d1410150
EZ
89282011-08-06 Eli Zaretskii <eliz@gnu.org>
8929
8930 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8931 display property strides EOL and includes a newline, as in
8932 longlines-mode. (Bug#9254)
75b771e4
EZ
8933 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8934 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8935
8936 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8937 is non-zero, even if the data buffer is NULL. Fixes a crash in
8938 vertical-motion with longlines-mode. (Bug#9254)
8939
35928349
EZ
89402011-08-05 Eli Zaretskii <eliz@gnu.org>
8941
ec7cc85b
EZ
8942 * bidi.c <bidi_cache_total_alloc>: Now static.
8943 (bidi_initialize): Initialize bidi_cache_total_alloc.
8944
8b76d6f8 8945 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8946 cache. (Bug#9221)
8947
8948 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8949 amount allocated this far in `bidi_cache_total_alloc'.
8950 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8951 non-zero, only free the data buffer without restoring the cache
8952 contents. All callers changed.
8953
8954 * dispextern.h (bidi_unshelve_cache): Update prototype.
8955
8956 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8957 (move_it_in_display_line, move_it_to)
8958 (move_it_vertically_backward, move_it_by_lines): Replace the call
8959 to xfree to an equivalent call to bidi_unshelve_cache.
8960 (move_it_in_display_line_to): Fix logic of returning
412b6358 8961 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8962
e2e2423b
EZ
89632011-08-05 Eli Zaretskii <eliz@gnu.org>
8964
8965 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8966 came from a string character with a `cursor' property. (Bug#9229)
8967
ae9e757a
JD
89682011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8969
8970 * Makefile.in (LIB_PTHREAD): New variable.
8971 (LIBES): Add LIB_PTHREAD (Bug#9216).
8972
8973 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8974 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8975
213bd7f2
AS
89762011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8977
6b02f655 8978 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8979
99aaf75f
JD
89802011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8981
8982 * xterm.c (x_find_topmost_parent): New function.
8983 (x_set_frame_alpha): Find topmost parent window with
8984 x_find_topmost_parent and set the property there also (bug#9181).
8985 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8986
c74e9d86
PE
89872011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8988
8989 * callproc.c (Fcall_process): Avoid vfork clobbering
8990 the local vars buffer, coding_systems, current_dir.
8991
640c8776
SM
89922011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8993
8994 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8995
f26d0e4c
PE
89962011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8997
8a10d76c
PE
8998 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8999 so that it is not optimized away.
9000
f26d0e4c
PE
9001 * xdisp.c (compute_display_string_pos): Remove unused local.
9002
55439c61
EZ
90032011-08-02 Eli Zaretskii <eliz@gnu.org>
9004
9005 Fix slow cursor motion and scrolling in large buffers with
9006 selective display, like Org Mode buffers. (Bug#9218)
9007
9008 * dispextern.h (struct bidi_it): New member disp_prop_p.
9009
9010 * xdisp.c: Remove one-slot cache of display string positions.
9011 (compute_display_string_pos): Accept an additional argument
5e617bc2 9012 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9013 for a display string or property. If found, set DISP_PROP_P
9014 non-zero.
9015
9016 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9017 DISP_PROP_P, and pass it to compute_display_string_pos.
9018 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9019 non-zero. All callers of bidi_fetch_char changed.
9020
fb33fa43
SM
90212011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9022
9023 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9024
b099e063
DM
90252010-12-03 Don March <don@ohspite.net>
9026
9027 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9028 last character M-[char] is translated to ESC [char] (bug#7541).
9029
5cc7f7af
KH
90302011-08-02 Kenichi Handa <handa@m17n.org>
9031
d0fffa3f 9032 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9033
9034 * chartab.c (uniprop_table): Make it non-static.
9035
525d5e6e
EZ
90362011-08-01 Eli Zaretskii <eliz@gnu.org>
9037
9038 * xdisp.c (forward_to_next_line_start): Accept additional argument
9039 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9040 on the newline.
9041 (reseat_at_next_visible_line_start): Use the bidi iterator state
9042 returned by forward_to_next_line_start to restore the state of
9043 it->bidi_it after backing up to previous newline. (Bug#9212)
9044
31011111
AS
90452011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9046
9047 * regex.c (re_comp): Protoize.
9048 (re_exec): Fix return type.
9049 (regexec): Fix type of `ret'. (Bug#9203)
9050
476371c4
PE
90512011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9052
e5d76069
PE
9053 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9054 This is needed if max-image-size is a floating-point number.
9055
9a79b20c
AS
90562011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9057
9058 * print.c (print_object): Print empty symbol as ##.
9059
9060 * lread.c (read1): Read ## as empty symbol.
9061
d8c2fa78
AA
90622011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9063
9064 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9065 setting frame foreground color (Bug#9175).
9066 (x_set_background_color): Likewise.
9067
ffe57a7a
AA
9068 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9069 contents (Bug#9176).
9070 (EmacsTooltip -init): Remove bezels and add shadows to
9071 tooltip windows.
9072
bf3492a5
AA
9073 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9074 or scroll bar (Bug#8470).
9075
d55e9c53
AA
9076 * nsfont.m (nsfont_open): Remove assignment to voffset and
9077 unnecessary vars hshink, expand, hd, full_height, min_height.
9078 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9079
9080 * nsterm.h (nsfont_info): Remove voffset field.
9081
d8c2fa78 90822011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9083
9084 Implement strike-through and overline on NextStep (Bug#8863).
9085
9086 * nsfont.m (nsfont_open): Use underline position provided by font,
9087 instead of hard-coded value of 2.
9088 (nsfont_draw): Call ns_draw_text_decoration instead.
9089
9090 * nsterm.h: Add declaration for ns_draw_text_decoration.
9091
9092 * nsterm.m (ns_draw_text_decoration): New function for drawing
9093 underline, overline, and strike-through.
9094 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9095 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9096 accommodate underlining, etc.
4843aac3 9097
4cc60b9b
EZ
90982011-07-28 Eli Zaretskii <eliz@gnu.org>
9099
bc7ece87
EZ
9100 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9101 default.
4cc60b9b 9102
476371c4
PE
91032011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9104
66606eea
PE
9105 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9106 Without this fix, if a signal arrives just after memory fills up,
9107 'malloc' might be invoked reentrantly.
9108
476371c4
PE
9109 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9110 In other words, assume that every image size is allowed, on non-X
9111 hosts. This assumption is probably wrong, but it lets Emacs compile.
9112
f3fcc40d
AS
91132011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9114
9115 * regex.c (re_iswctype): Convert return values to boolean.
9116
350c992f
EZ
91172011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9118
9119 * xdisp.c (compute_display_string_pos): Don't use cached display
9120 string position if the buffer had its restriction changed.
9121 (Bug#9184)
9122
5266b4bb
PE
91232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9124
9125 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9126
2573a837 91272011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9128
41f55ccd 9129 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9130
39e378da
PE
9131 * bidi.c: Integer size and overflow fixes.
9132 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9133 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9134 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9135 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9136 (bidi_find_other_level_edge):
9137 Use ptrdiff_t instead of EMACS_INT where either will do.
9138 This works better on 32-bit hosts configured --with-wide-int.
9139 (bidi_cache_ensure_space): Check for size-calculation overflow.
9140 Use % rather than repeated addition, for better worst-case speed.
9141 Don't set bidi_cache_size until after xrealloc returns, because it
9142 might not return.
9143 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9144 (bidi_cache_ensure_space): Also check that the bidi cache size
9145 does not exceed that of the largest Lisp string or buffer. See Eli
9146 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9147
5e927815
PE
9148 * alloc.c (__malloc_size_t): Remove.
9149 All uses replaced by size_t. See Andreas Schwab's note
9150 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9151
ca4aa935
PE
9152 * image.c: Improve checking for integer overflow.
9153 (check_image_size): Assume that f is nonnull, since
9154 it is always nonnull in practice. This is one less thing to
9155 worry about when checking for integer overflow later.
9156 (x_check_image_size): New function, which checks for integer
9157 overflow issues inside X.
9158 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9159 This removes the need for a memory_full check.
9160 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9161 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9162 (xbm_read_bitmap_data): Change locals back to 'int', since
9163 their values must fit in 'int'.
9164 (xpm_load_image, png_load, tiff_load):
9165 Invoke x_create_x_image_and_pixmap earlier,
9166 to avoid much needless work if the image is too large.
9167 (tiff_load): Treat overly large images as if
9168 x_create_x_image_and_pixmap failed, not as malloc failures.
9169 (gs_load): Use x_check_image_size.
9170
5f8f9cc2
PE
9171 * gtkutil.c: Omit integer casts.
9172 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9173 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9174
5adf60bc
PE
9175 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9176
c8907a93
PE
9177 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9178 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9179 would wrongly return t on a 64-bit host.
9180
e3c25c68
PE
9181 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9182 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9183 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9184 and therefore cause GCC to emit a bogus diagnostic in some cases.
9185
3f791afe
PE
9186 * image.c: Integer signedness and overflow and related fixes.
9187 This is not an exhaustive set of fixes, but it's time to
9188 record what I've got.
9189 (lookup_pixel_color, check_image_size): Remove redundant decls.
9190 (check_image_size): Don't assume that arbitrary EMACS_INT values
9191 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9192 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9193 (tiff_load, imagemagick_load_image):
9194 Check for overflow in size calculations.
9195 (x_create_x_image_and_pixmap): Remove unnecessary test for
9196 xmalloc returning NULL; that can't happen.
9197 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9198 (xpm_color_bucket): Use better integer hashing function.
9199 (xpm_cache_color): Don't possibly over-allocate memory.
9200 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9201 (gif_memory_source):
9202 Use ptrdiff_t, not int or size_t, to record sizes.
9203 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9204 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9205 either works, as we prefer signed integers.
9206 (tiff_read_from_memory, tiff_write_from_memory):
9207 Return tsize_t, not size_t, since that's what the TIFF API wants.
9208 (tiff_read_from_memory): Don't fail simply because the read would
9209 go past EOF; instead, return a short read.
9210 (tiff_load): Omit no-longer-needed casts.
9211 (Fimagemagick_types): Don't assume size fits into 'int'.
9212
3cc5a532
PE
9213 Improve hashing quality when configured --with-wide-int.
9214 * fns.c (hash_string): New function, taken from sxhash_string.
9215 Do not discard information about ASCII character case; this
9216 discarding is no longer needed.
9217 (sxhash-string): Use it. Change sig to match it. Caller changed.
9218 * lisp.h: Declare it.
9219 * lread.c (hash_string): Remove, since we now use fns.c's version.
9220 The fns.c version returns a wider integer if --with-wide-int is
9221 specified, so this should help the quality of the hashing a bit.
9222
b312a492
PE
9223 * emacs.c: Integer overflow minor fix.
9224 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9225 Define only if GNU_LINUX.
9226 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9227
dfd153ae
PE
9228 * dispnew.c: Integer signedness and overflow fixes.
9229 Remove unnecessary forward decls, that were a maintenance hassle.
9230 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9231 All uses changed.
9232 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9233 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9234 (prepare_desired_row, line_draw_cost):
9235 Use int, not unsigned, where either works.
9236 (save_current_matrix, restore_current_matrix):
9237 Use ptrdiff_t, not size_t, where either works.
9238 (init_display): Check for overflow more accurately, and without
9239 relying on undefined behavior.
9240
a81d11a3
PE
9241 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9242 Remove, replacing with the new symbols in lisp.h. All uses changed.
9243 * fileio.c (make_temp_name):
9244 * filelock.c (lock_file_1, lock_file):
9245 * xdisp.c (message_dolog):
9246 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9247 Use pMd etc. instead.
9248 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9249 replacing the pWIDE etc. symbols removed from editfns.c.
9250
3300e6fd
PE
9251 * keyboard.h (num_input_events): Now uintmax_t.
9252 This is (very slightly) less likely to mess up due to wraparound.
9253 All uses changed.
9254
fd05c7e9
PE
9255 * buffer.c: Integer signedness fixes.
9256 (alloc_buffer_text, enlarge_buffer_text):
9257 Use ptrdiff_t rather than size_t when either will do, as we prefer
9258 signed integers.
9259
903fe15d
PE
9260 * alloc.c: Integer signedness and overflow fixes.
9261 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9262 (__malloc_size_t): Default to size_t, not to int.
9263 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9264 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9265 Prefer ptrdiff_t to size_t when either would do, as we prefer
9266 signed integers.
9267 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9268 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9269 Now const. Initialize with values that are in range even if char
9270 is signed.
9271 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9272 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9273 These functions do the right thing with sizes > 2**32.
9274 (check_depth): Now ptrdiff_t, not int.
9275 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9276 Adjust to new way of storing sizes. Check for size overflow bugs
9277 in rest of code.
9278 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9279 slightly wrong anyway, as it missed one instance of
9280 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9281 (refill_memory_reserve): Omit needless cast to size_t.
9282 (mark_object_loop_halt): Mark as externally visible.
9283
ac82cc6a
PE
9284 * xselect.c: Integer signedness and overflow fixes.
9285 (Fx_register_dnd_atom, x_handle_dnd_message):
9286 Use ptrdiff_t, not size_t, since we prefer signed.
9287 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9288 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9289 x_dnd_atoms_size and x_dnd_atoms_length.
9290
c2d1e36d
PE
9291 * doprnt.c: Prefer signed to unsigned when either works.
9292 * eval.c (verror):
9293 * doprnt.c (doprnt):
9294 * lisp.h (doprnt):
9295 * xdisp.c (vmessage):
9296 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9297 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9298 prefer signed arithmetic to avoid comparison confusion.
9299 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9300 but is a bit tricky.
9301
0e926e56
PE
9302 Assume freestanding C89 headers, string.h, stdlib.h.
9303 * data.c, doprnt.c, floatfns.c, print.c:
9304 Include float.h unconditionally.
9305 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9306 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9307 * regex.c: Likewise for stddef.h, string.h.
9308 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9309 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9310 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9311 (STDC_HEADERS): Remove obsolete defines.
9312 * sysdep.c: Include limits.h unconditionally.
9313
9cfdb3ec
PE
9314 Assume support for memcmp, memcpy, memmove, memset.
9315 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9316 * regex.c (memcmp, memcpy):
9317 Remove; we assume C89 now.
9318
9319 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9320 (__malloc_safe_bcopy): Remove; no longer needed.
9321
cf950e6b 9322 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9323 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9324 well either way, and we prefer signed to unsigned.
9325
dbf38e02
LMI
93262011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9327
9328 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9329 closes the connection while we're reading (bug#9182).
9330
d6f0886c 93312011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9332
d6f0886c
JD
9333 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9334 are specified (Bug#9168).
24e0f6b1 9335
2eb1f9e6
PE
93362011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9337
9338 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9339 Found by GCC static checking and --with-wide-int on a 32-bit host.
9340
22381272 93412011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9342
9343 * xdisp.c (compute_display_string_pos): Fix logic of caching
9344 previous display string position. Initialize cached_prev_pos to
9345 -1. Fixes slow-down at the beginning of a buffer.
9346
f25e39b4
EZ
93472011-07-24 Eli Zaretskii <eliz@gnu.org>
9348
9349 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9350 for attrs[LFACE_FONTSET_INDEX].
9351
04c4b52e
PE
93522011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9353
9354 * xml.c (parse_region): Remove unused local
9355 that was recently introduced.
9356
c1734fbd
EZ
93572011-07-23 Eli Zaretskii <eliz@gnu.org>
9358
be18c5a5
EZ
9359 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9360 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9361
c1734fbd
EZ
9362 * xdisp.c (move_it_in_display_line_to): Record the best matching
9363 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9364 exit if none of the characters scanned was an exact match.
9365 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9366 when exact match is impossible due to invisible text, and the
9367 lines are truncated.
9368
a258d627
JD
93692011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9370
9371 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9372 for OSX >= 10.7.
9373
b6d5a689
EZ
93742011-07-22 Eli Zaretskii <eliz@gnu.org>
9375
0f74f785
EZ
9376 Fix a significant slow-down of cursor motion with C-n, C-p,
9377 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9378 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9379 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9380 (next_element_from_buffer): Call compute_stop_pos_backwards to
9381 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9382 base_level_stop.
9383 (reseat): Don't look for prev_stop, as that could mean a very long
9384 run.
9385 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9386 <cached_disp_overlay_modiff>: Cache for last found display string
9387 position.
551918c1 9388 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9389 about the same buffer in the same area of character positions, and
9390 the buffer wasn't changed since the time the display string
9391 position was cached.
551918c1 9392
b2d0c91a
EZ
93932011-07-22 Eli Zaretskii <eliz@gnu.org>
9394
9395 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9396 is an integer, which is important for empty lines. (Bug#9149)
9397
043604ee
CY
93982011-07-22 Chong Yidong <cyd@stupidchicken.com>
9399
9400 * frame.c (Fmodify_frame_parameters): In tty case, update the
9401 default face if necessary (Bug#4238).
9402
da4adb04
CY
94032011-07-21 Chong Yidong <cyd@stupidchicken.com>
9404
9405 * editfns.c (Fstring_to_char): No need to explain what a character
9406 is in the docstring (Bug#6576).
9407
9abd0532
LMI
94082011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9409
9410 * xml.c (parse_region): Make sure we always return a tree.
9411
36881d16
HK
94122011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9413
9414 * xml.c (parse_region): If a document contains only comments,
9415 return that, too.
9416
1e98674d
LMI
94172011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9418
9419 * xml.c (make_dom): Return comments, too.
9420
590bd467
PE
94212011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9422
9423 Port to OpenBSD.
9424 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9425 and the surrounding thread.
9426 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9427 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9428 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9429 timer goes off.
9430 * s/openbsd.h (BROKEN_SIGIO): Define.
9431 * unexelf.c (unexec) [__OpenBSD__]:
9432 Don't update the .mdebug section of the Alpha COFF symbol table.
9433
f41628b2
LMI
94342011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9435
9436 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9437 (bug#8460).
9438
b59b67c5
PE
94392011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9440
15e3a074
PE
9441 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9442 This fixes some race conditions on the permissions of any newly
9443 created file.
9444
41bed37d
PE
9445 * alloc.c (valid_pointer_p): Use pipe, not open.
9446 This fixes some permissions issues when debugging.
9447
b59b67c5
PE
9448 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9449 If fchown fails to set both uid and gid, try to set just gid,
9450 as that is sometimes allowed. Adjust the file's mode to eliminate
9451 setuid or setgid bits that are inappropriate if fchown fails.
9452
925a6be7
SM
94532011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9454
9455 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9456 to compare Lisp_Objects.
9457 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9458 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9459 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9460
52968808
AS
94612011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9462
0a6a104b
AS
9463 * lread.c (read_integer): Unread even EOF character.
9464 (read1): Likewise. Properly record start position of symbol.
9465
52968808
AS
9466 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9467 symbol character follows.
9468
9e381cdd
PE
94692011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9470
9471 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9472 This works around a problem with the previous change to Fcopy_file.
9473 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9474 and without this change, GCC might complain about discarding
9475 fchown's return value.
9476
b5641435
JB
94772011-07-16 Juanma Barranquero <lekktu@gmail.com>
9478
9479 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9480
a8031457
PE
94812011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9482
9483 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9484
dd889327
LMI
94852011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9486
750c33f7
LMI
9487 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9488 it's used from the C level.
9489
dd889327
LMI
9490 * process.c: Use the same condition for POLL_FOR_INPUT in both
9491 keyboard.c and process.c (bug#1858).
9492
87e86684
LM
94932011-07-09 Lawrence Mitchell <wence@gmx.li>
9494
9495 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9496 (Fgnutls_boot): Use it.
9497
64348f40
AS
94982011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9499
9500 * doc.c (Fsubstitute_command_keys): Revert last change.
9501
1d698799
LMI
95022011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9503
f863868c
LMI
9504 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9505 quotes the next character, and doesn't affect other longer
9506 sequences (bug#8935).
9507
1d698799
LMI
9508 * lread.c (syms_of_lread): Clarify that is isn't only
9509 `eval-buffer' and `eval-defun' that's affected by
9510 `lexical-binding' (bug#8460).
9511
aa4b6df6
EZ
95122011-07-15 Eli Zaretskii <eliz@gnu.org>
9513
9514 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9515 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9516
5d856da6
PE
95172011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9518
ad6042bb
PE
9519 Fix minor problems found by static checking.
9520 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9521 (elsz): Now a signed constant, not a size_t var. We prefer signed
9522 types to unsigned, to avoid integer comparison confusion. Without
9523 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9524 "cannot optimize loop, the loop counter may overflow", a symptom
9525 of the confusion.
f00bbb22 9526 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9527 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9528
6468f31c
LMI
95292011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9530
49080b10
LMI
9531 * search.c (Fre_search_backward): Mention `case-fold-search' in
9532 all the re_search_* functions (bug#8138).
9533
6468f31c
LMI
9534 * keyboard.c (Fopen_dribble_file): Document when the file is
9535 closed (bug#8056).
9536
c965adc5
EZ
95372011-07-14 Eli Zaretskii <eliz@gnu.org>
9538
df9733bf
EZ
9539 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9540 bidi_cache_idx.
9541
0bb23927
EZ
9542 Support bidi reordering of display and overlay strings.
9543 * xdisp.c (compute_display_string_pos)
9544 (compute_display_string_end): Accept additional argument STRING.
9545 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9546 (reseat_to_string): Initialize bidi_it->string.s and
9547 bidi_it->string.schars.
9548 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9549 NULL (avoids a crash in bidi_paragraph_init).
9550 Initialize itb.string.lstring.
0bb23927
EZ
9551 (init_iterator): Call bidi_init_it only of a valid
9552 buffer position was specified. Initialize paragraph_embedding to
9553 L2R.
9554 (reseat_to_string): Initialize the bidi iterator.
9555 (display_string): If we need to ignore text properties of
9556 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9557 original value of -1 will not work with bidi.)
9558 (compute_display_string_pos): First arg is now struct
9559 `text_pos *'; all callers changed. Support display properties on
9560 Lisp strings.
9561 (compute_display_string_end): Support display properties on Lisp
9562 strings.
9563 (init_iterator, reseat_1, reseat_to_string): Initialize the
9564 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9565 when iterating on a string not from display properties).
640c8776
SM
9566 (compute_display_string_pos, compute_display_string_end):
9567 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9568 arrow keys.
9569 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9570 base_level_stop; instead, set base_level_stop to BEGV.
9571 Fixes crashes in vertical-motion.
0bb23927
EZ
9572 (next_element_from_buffer): Improve commentary for when
9573 the iterator is before prev_stop.
9574 (init_iterator): Initialize bidi_p from the default value of
9575 bidi-display-reordering, not from buffer-local value. Use the
9576 buffer-local value only if initializing for buffer iteration.
9577 (handle_invisible_prop): Support invisible properties on strings
9578 that are being bidi-reordered.
9579 (set_iterator_to_next): Support bidi reordering of C strings and
9580 Lisp strings.
9581 (next_element_from_string): Support bidi reordering of Lisp
9582 strings.
9583 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9584 (display_string): Support display of R2L glyph rows.
9585 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9586 (init_iterator): Don't initialize it->bidi_p for strings
9587 here.
9588 (reseat_to_string): Initialize it->bidi_p for strings here.
9589 (next_element_from_string, next_element_from_c_string)
9590 (next_element_from_buffer): Add xassert's for correspondence
9591 between IT's object being iterated and it->bidi_it.string
9592 structure.
9593 (face_before_or_after_it_pos): Support bidi iteration.
9594 (next_element_from_c_string): Handle the case of the first string
9595 character that is not the first one in the visual order.
9596 (get_visually_first_element): New function, refactored from common
9597 parts of next_element_from_buffer, next_element_from_string, and
9598 next_element_from_c_string.
9599 (tool_bar_lines_needed, redisplay_tool_bar)
9600 (display_menu_bar): Force left-to-right direction. Add a FIXME
9601 comment for making that be controlled by a user option.
9602 (push_it, pop_it): Save and restore the state of the
9603 bidi iterator. Save and restore the bidi_p flag.
9604 (pop_it): Iterate out of display property for string iteration as
9605 well.
9606 (iterate_out_of_display_property): Support iteration over strings.
9607 (handle_single_display_spec): Set up it->bidi_it for iteration
9608 over a display string, and call bidi_init_it.
9609 (handle_single_display_spec, next_overlay_string)
9610 (get_overlay_strings_1, push_display_prop): Set up the bidi
9611 iterator for displaying display or overlay strings.
9612 (forward_to_next_line_start): Don't use the shortcut if
9613 bidi-iterating.
9614 (back_to_previous_visible_line_start): If handle_display_prop
9615 pushed the iterator stack, restore the internal state of the bidi
9616 iterator by calling bidi_pop_it same number of times.
9617 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9618 and we are bidi-iterating, don't decrement the iterator position;
9619 instead, set the first_elt flag in the bidi iterator, to produce
9620 the same effect.
9621 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9622 (push_display_prop): xassert that we are iterating a buffer.
9623 (push_it, pop_it): Save and restore paragraph_embedding member.
9624 (handle_single_display_spec, next_overlay_string)
9625 (get_overlay_strings_1, reseat_1, reseat_to_string)
9626 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9627 correctly. Don't assume unibyte strings are not bidi-reordered.
9628 (compute_display_string_pos)
9629 (compute_display_string_end): Fix handling the case of C string.
9630 (push_it, pop_it): Save and restore from_disp_prop_p.
9631 (handle_single_display_spec, push_display_prop): Set the
9632 from_disp_prop_p flag.
9633 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9634 (pop_it): Call iterate_out_of_display_property only if we are
9635 popping after iteration over a string that came from a display
9636 property. Fix a typo in popping stretch info. Add an assertion
9637 for verifying that the iterator position is in sync with the bidi
9638 iterator.
9639 (handle_single_display_spec, get_overlay_strings_1)
9640 (push_display_prop): Fix initialization of paragraph direction for
9641 string when that of the parent object is not yet determined.
9642 (reseat_1): Call bidi_init_it to resync the bidi
9643 iterator with IT's position. (Bug#7616)
9644 (find_row_edges): If ROW->start.pos gives position
9645 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9646 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9647 Reset the from_disp_prop_p flag.
9648 (SAVE_IT, RESTORE_IT): New macros.
9649 (pos_visible_p, face_before_or_after_it_pos)
9650 (back_to_previous_visible_line_start)
9651 (move_it_in_display_line_to, move_it_in_display_line)
9652 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9653 (try_scrolling, redisplay_window, display_line): Use them when
9654 saving a temporary copy of the iterator and restoring it back.
9655 (back_to_previous_visible_line_start, reseat_1)
9656 (init_iterator): Empty the bidi cache "stack".
9657 (move_it_in_display_line_to): If iterator ended up at
9658 EOL, but we never saw any buffer positions smaller than
9659 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9660 motion in bidi-reordered lines.
9661 (move_it_in_display_line_to): Record prev_method and prev_pos
9662 immediately before the call to set_iterator_to_next. Fixes cursor
9663 motion in bidi-reordered lines with stretch glyphs and strings
9664 displayed in margins. (Bug#8133) (Bug#8867)
9665 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9666 TO_CHARPOS.
640c8776
SM
9667 (pos_visible_p): Support positions in bidi-reordered lines.
9668 Save and restore bidi cache.
0bb23927
EZ
9669
9670 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9671 (bidi_paragraph_info): Delete unused struct.
9672 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9673 (bidi_cache_start): New variable.
9674 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9675 to zero.
9676 (bidi_cache_fetch_state, bidi_cache_search)
9677 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9678 (bidi_cache_find, bidi_peek_at_next_level)
9679 (bidi_level_of_next_char, bidi_find_other_level_edge)
9680 (bidi_move_to_visually_next): Compare cache index with
9681 bidi_cache_start rather than with zero.
9682 (bidi_fetch_char): Accept new argument STRING; all callers
9683 changed. Support iteration over a string. Support strings with
9684 display properties. Support unibyte strings. Fix the type of
9685 `len' according to what STRING_CHAR_AND_LENGTH expects.
9686 (bidi_paragraph_init, bidi_resolve_explicit_1)
9687 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9688 (bidi_level_of_next_char, bidi_move_to_visually_next):
9689 Support iteration over a string.
0bb23927
EZ
9690 (bidi_set_sor_type, bidi_resolve_explicit_1)
9691 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9692 can now be zero (for strings); special values 0 and -1 were
9693 changed to -1 and -2, respectively.
9694 (bidi_char_at_pos): New function.
9695 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9696 Call it instead of FETCH_MULTIBYTE_CHAR.
9697 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9698 initialized to valid values.
9699 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9700 values.
9701 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9702 the test for valid cached positions. Fix the logic for looking up
9703 the sentinel state in the cache. GCPRO the Lisp string we are
9704 iterating.
9705 (bidi_push_it, bidi_pop_it): New functions.
9706 (bidi_initialize): Initialize the bidi cache start stack pointer.
9707 (bidi_cache_ensure_space): New function, refactored from part of
9708 bidi_cache_iterator_state. Don't assume the required size is just
9709 one BIDI_CACHE_CHUNK away.
9710 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9711 (bidi_count_bytes, bidi_char_at_pos): New functions.
9712 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9713 always valid if bidi_cache_idx is valid.
9714 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9715 is valid if it's going to be used.
9716 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9717 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9718 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9719 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9720 (bidi_find_other_level_edge, bidi_cache_start_stack):
9721 All variables related to cache indices are now EMACS_INT.
c965adc5 9722
0bb23927
EZ
9723 * dispextern.h (struct bidi_string_data): New structure.
9724 (struct bidi_it): New member `string'. Make flag members be 1-bit
9725 fields, and put them last in the struct.
640c8776
SM
9726 (compute_display_string_pos, compute_display_string_end):
9727 Update prototypes.
0bb23927
EZ
9728 (bidi_push_it, bidi_pop_it): Add prototypes.
9729 (struct iterator_stack_entry): New members bidi_p,
9730 paragraph_embedding, and from_disp_prop_p.
9731 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9732 (bidi_shelve_cache, bidi_unshelve_cache):
9733 Declare prototypes.
0bb23927
EZ
9734
9735 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9736 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9737 and vector-like objects.
9738
9739 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9740 cache around display iteration.
9741
9742 * window.c (Fwindow_end, window_scroll_pixel_based)
9743 (displayed_window_lines, Frecenter): Save and restore the bidi
9744 cache around display iteration.
9745
3bbd2265
LMI
97462011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9747
9748 * editfns.c (Fdelete_region): Clarify the use of the named
9749 parameters (bug#6788).
9750
adc47434
MR
97512011-07-14 Martin Rudalics <rudalics@gmx.at>
9752
9753 * indent.c (Fvertical_motion): Set and restore w->pointm when
9754 saving and restoring the window's buffer (Bug#9006).
9755
837c31f8
LMI
97562011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9757
9758 * editfns.c (Fstring_to_char): Clarify just what is returned
9759 (bug#6576). Text by Eli Zaretskii.
9760
ac389d0c
JB
97612011-07-13 Juanma Barranquero <lekktu@gmail.com>
9762
9763 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9764
0be0ce47
EZ
97652011-07-13 Eli Zaretskii <eliz@gnu.org>
9766
9767 * buffer.c (mmap_find): Fix a typo.
9768
cd18e7e3
JB
97692011-07-13 Johan Bockgård <bojohan@gnu.org>
9770
9771 Fix execution of x selection hooks.
9772 * xselect.c (Qx_lost_selection_functions)
9773 (Qx_sent_selection_functions): New vars.
9774 (syms_of_xselect): DEFSYM them.
9775 (x_handle_selection_request): Pass Qx_sent_selection_functions
9776 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9777 (x_handle_selection_clear,x_clear_frame_selections):
9778 Pass Qx_lost_selection_functions rather than
9779 Vx_lost_selection_functions to Frun_hook_with_args.
9780
47ea7f44
PE
97812011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9782
ac389d0c 9783 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9784 The old code sometimes used this field without initializing it.
9785
47ea7f44
PE
9786 * alloc.c (gc_sweep): Don't read past end of array.
9787 In theory, the old code could also have corrupted Emacs internals,
9788 though it'd be very unlikely.
9789
bc985c87
AS
97902011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9791
9792 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9793 argument. (Bug#4026)
bc985c87 9794
0cf34688
LMI
97952011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9796
b3dadd76
LMI
9797 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9798 key" (bug#4257).
9799
0cf34688
LMI
9800 * window.c (Fset_window_start): Doc fix (bug#4199).
9801 (Fset_window_hscroll): Ditto.
9802
270768cd
PE
98032011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9804
077e3dda 9805 Fix minor new problems caught by GCC 4.6.1.
270768cd 9806 * term.c (init_tty): Remove unused local.
490011a6 9807 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9808 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9809 not used otherwise.
270768cd 9810
b1f58454
CY
98112011-07-12 Chong Yidong <cyd@stupidchicken.com>
9812
9813 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9814
22b9578d
LMI
98152011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9816
6e70ab07
LMI
9817 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9818 are the mini-buffer and the echo area (bug#3320).
9819
22b9578d
LMI
9820 * term.c (init_tty): Remove support for supdup, c10 and perq
9821 terminals, which are no longer supported (bug#1482).
9822
8974cc9f
JB
98232011-07-10 Johan Bockgård <bojohan@gnu.org>
9824
9825 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9826
a560d974
JD
98272011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9828
9829 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9830 for non-popups (Bug#3642).
9831
1dae0f0a
AS
98322011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9833
268c2c36 9834 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9835 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9836 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9837 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9838 * data.c (fmod): Likewise.
9839 * dispnew.c (swap_glyphs_in_rows): Likewise.
9840 * emacs.c (memory_warning_signal): Likewise.
9841 * floatfns.c (float_error): Likewise.
9842 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9843 (otf_open, font_otf_capability, generate_otf_features)
9844 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9845 Likewise.
9846 * image.c (pbm_read_file): Likewise.
9847 * indent.c (string_display_width): Likewise.
9848 * intervals.c (check_for_interval, search_for_interval)
9849 (inc_interval_count, count_intervals, root_interval)
9850 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9851 * lread.c (defalias): Likewise.
268c2c36 9852 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9853 * regex.c (set_image_of_range_1, set_image_of_range)
9854 (regex_grow_registers): Likewise.
9855 * sysdep.c (strerror): Likewise.
9856 * termcap.c (valid_filename_p, tprint, main): Likewise.
9857 * tparam.c (main): Likewise.
9858 * unexhp9k800.c (run_time_remap, save_data_space)
9859 (update_file_ptrs, read_header, write_header, calculate_checksum)
9860 (copy_file, copy_rest, display_header): Likewise.
9861 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9862 Likewise.
9863 * xdisp.c (check_it): Likewise.
9864 * xfaces.c (register_color, unregister_color, unregister_colors):
9865 Likewise.
9866 * xfns.c (print_fontset_result): Likewise.
9867 * xrdb.c (member, fatal, main): Likewise.
9868
99033785
PE
98692011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9870
9871 Fix minor problems found by static checking (Bug#9031).
9872 * chartab.c (char_table_set_range, map_sub_char_table):
9873 Remove unused locals.
9874 (uniprop_table): Now static.
9875 * composite.c (_work_char): Remove unused static var.
9876
9cb2ac56
JB
98772011-07-09 Juanma Barranquero <lekktu@gmail.com>
9878
9879 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9880
f25661f0
JD
98812011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9882
9883 * gtkutil.c (qttip_cb): Remove code without function.
9884
8278c4fe
EZ
98852011-07-09 Eli Zaretskii <eliz@gnu.org>
9886
9887 * w32.c (pthread_sigmask): New stub.
9888
1692ae2d 98892011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9890
8a6ebd58 9891 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9892 sigprocmask is portable only for single-threaded applications, and
9893 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9894 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9895 (LIBES): Use it.
9896 * callproc.c (Fcall_process):
9897 * process.c (create_process):
9898 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9899 Use pthread_sigmask, not sigprocmask.
123403e4 9900
1b854618
JD
99012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9902
9903 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9904 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9905 wrong (Bug#8591).
9906
3fe4b549
JD
99072011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9908
0ce7e563
JD
9909 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9910 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9911 (xg_hide_tooltip): Fix comment.
9912
3fe4b549
JD
9913 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9914 in registerServicesMenuSendTypes.
9915 (validRequestorForSendType): Don't check ns_return_types.
9916
9917 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9918 ns_return_type.
9919
5df75e47
JR
99202011-07-08 Jason Rumney <jasonr@gnu.org>
9921
22610910
JR
9922 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9923 SH_SHOW for hidden windows (Bug#5482).
9924
5df75e47
JR
9925 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9926 frame struct members of non-existent frames (Bug#6284).
9927
699c10bd
JD
99282011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9929
4393663b
JD
9930 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9931 variable firstTime not needed on OSX >= 10.6.
9932 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9933 >= 10.5. Use setKnobProportion, setDoubleValue.
9934
9935 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9936 (MAC_OS_X_VERSION_10_5): Define if not defined.
9937 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9938 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9939 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9940
9941 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9942 cString and lossyCString on OSX >= 10.4.
4393663b 9943
58179cce 9944 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9945 sizeToFit on OSX >= 10.2.
9946
9947 * nsimage.m (allocInitFromFile): Don't use deprecated method
9948 bestRepresentationForDevice on OSX >= 10.6.
9949
9950 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9951 to avoid warning.
9952
9953 * emacs.c: Declare unexec_init_emacs_zone.
9954
a63e0781
JD
9955 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9956
699c10bd
JD
9957 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9958
9959 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9960 on svcsMenu (Bug#8842).
9961
9962 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9963 ns_return_types.
9964 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9965
9966 * nsterm.m (QUTF8_STRING): Declare.
9967 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9968 (validRequestorForSendType): Return type is (id).
9969 Change indexOfObjectIdenticalTo to indexOfObject.
9970 Check if we have local selection before returning self (Bug#8842).
9971 (writeSelectionToPasteboard): Put local selection into paste board
9972 if we have a local selection (Bug#8842).
9973 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9974
9975 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9976 (ns_get_local_selection): Declare.
9977
54e10184
LMI
99782011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9979
9888ff71
LMI
9980 * keymap.c (describe_map_tree): Don't insert a double newline at
9981 the end of the buffer (bug#1169) and return whether we inserted
9982 something.
9983
54e10184
LMI
9984 * callint.c (Fcall_interactively): Change "reading args" to
9985 "providing args" to try to clarify what it does (bug#1010).
9986
15fa4783
KH
99872011-07-07 Kenichi Handa <handa@m17n.org>
9988
9989 * composite.c (composition_compute_stop_pos): Ignore a static
9990 composition starting before CHARPOS (Bug#8915).
9991
9992 * xdisp.c (handle_composition_prop): Likewise.
9993
a8815b00
EZ
99942011-07-07 Eli Zaretskii <eliz@gnu.org>
9995
9996 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9997 (Bug#9015)
9998
ef7b981d 99992011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
10000
10001 * character.h (unicode_category_t): New enum type.
10002
10003 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
10004 (Qchar_code_property_table): New variable.
10005 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10006 (UNIPROP_COMPRESSED_FORM_P): New macros.
10007 (char_table_ascii): Uncompress the compressed values.
10008 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10009 Uncompress the compressed values.
ac389d0c 10010 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10011 (char_table_ref_and_range): Uncompress the compressed values.
10012 (sub_char_table_set): New arg is_uniprop. Callers changed.
10013 Uncompress the compressed values.
10014 (sub_char_table_set_range): Args changed. Callers changed.
10015 (char_table_set_range): Adjuted for the above change.
10016 (map_sub_char_table): Delete args default_val and parent. Add arg
10017 top. Give decoded values to a Lisp function.
640c8776 10018 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10019 values to a Lisp function. Gcpro more variables.
10020 (uniprop_table_uncompress)
10021 (uniprop_decode_value_run_length): New functions.
10022 (uniprop_decoder, uniprop_decoder_count): New variables.
10023 (uniprop_get_decoder, uniprop_encode_value_character)
10024 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10025 New functions.
10026 (uniprop_encoder, uniprop_encoder_count): New variables.
10027 (uniprop_get_encoder, uniprop_table)
10028 (Funicode_property_table_internal, Fget_unicode_property_internal)
10029 (Fput_unicode_property_internal): New functions.
10030 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10031 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10032 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10033 char-code-property-alist.
10034
640c8776 10035 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10036 Vunicode_category_table.
10037
640c8776 10038 * font.c (font_range): Adjust for the change of
c805dec0
KH
10039 Vunicode_category_table.
10040
76b397fb
DN
100412011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10042
10043 * m/iris4d.h: Remove file, move contents ...
10044 * s/irix6-5.h: ... here.
10045
22b4128e
PE
100462011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10047
10048 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10049 * alloc.c (mark_buffer):
10050 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10051 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10052 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10053 This isn't true in general, and it's particularly not true
10054 if Emacs is configured with --with-wide-int.
10055 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10056 New macros, used in the buffer.c change.
10057
869795d6
JD
100582011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10059
10060 * xsettings.c: Use both GConf and GSettings if both are available.
10061 (store_config_changed_event): Add comment.
10062 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10063 (store_tool_bar_style_changed): New functions.
5e617bc2 10064 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10065 (struct xsettings): Move font inside HAVE_XFT.
10066 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10067 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10068 Move inside HAVE_XFT.
640c8776 10069 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10070 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10071 also.
10072 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10073 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10074 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10075 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10076 (parse_settings): Move check for font inside HAVE_XFT.
10077 (read_settings, apply_xft_settings): Add comment.
10078 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10079 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10080 call store_font_name_changed.
10081 (xft_settings_event): Add comment.
10082 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10083 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10084 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10085 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10086 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10087 (xsettings_get_system_font, xsettings_get_system_normal_font):
10088 Add comment.
869795d6 10089
d8ed26bd
PE
100902011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10091
10092 Random fixes. E.g., (random) never returned negative values.
10093 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10094 subseconds part to the entropy, as that's a bit more random.
10095 Prefer signed to unsigned, since the signedness doesn't matter and
10096 in general we prefer signed. When given a limit, use a
10097 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10098 latter isn't right if USE_2_TAGS_FOR_INTS.
10099 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10100 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10101
cabf1cac
SM
101022011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10103
10104 * textprop.c (text_property_stickiness):
10105 Obey Vtext_property_default_nonsticky.
10106 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10107 * w32fns.c (syms_of_w32fns):
10108 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10109
6e9b2be9
PE
101102011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10111
10112 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10113 This is more efficient than Ffile_directory_p and avoids a minor race.
10114
90186c68
LMI
101152011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10116
7c301272
LMI
10117 * buffer.c (Foverlay_put): Say what the return value is
10118 (bug#7835).
10119
c4f2d8d4
LMI
10120 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10121 is a directory before asking whether to use the file name
10122 (bug#7564).
ad637907
LMI
10123 (barf_or_query_if_file_exists): Make the "File is a directory"
10124 error be more correct.
c4f2d8d4 10125
90186c68
LMI
10126 * fns.c (Frequire): Remove the mention of the .gz files, since
10127 that's installation-specific, but keep the mention of
10128 `get-load-suffixes'.
10129
da64016e
PE
101302011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10131
10132 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10133 Report string overflow if the output is too long.
10134
7d47b580
JB
101352011-07-04 Juanma Barranquero <lekktu@gmail.com>
10136
a555cb87
JB
10137 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10138 (syms_of_gnutls): Remove duplicate DEFSYM for
10139 Qgnutls_bootprop_verify_hostname_error, an error for
10140 Qgnutls_bootprop_verify_error (which is no longer used).
10141
7d47b580
JB
10142 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10143 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10144 Also (re)move comments that are misplaced or no longer relevant.
10145
1e49bfab
LMI
101462011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10147
10148 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10149
1485f4c0
CY
101502011-07-03 Chong Yidong <cyd@stupidchicken.com>
10151
10152 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10153 and background color parameters if they have been changed.
10154
a9ab721e
LMI
101552011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10156
10157 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10158
cf7cff57
PE
101592011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10160
2e13213d
PE
10161 * xsettings.c (SYSTEM_FONT): Define only when used.
10162 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10163
cf7cff57
PE
10164 * keymap.c (access_keymap_1): Now static.
10165
7a8e04f7
CY
101662011-07-02 Chong Yidong <cyd@stupidchicken.com>
10167
10168 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10169 leave any prefix arg for the up event (Bug#1586).
10170
61352f62
LMI
101712011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10172
69bb1ef7
LMI
10173 * lread.c (syms_of_lread): Mention single symbols defined by
10174 `defvar' or `defconst' (bug#7154).
10175
61352f62 10176 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10177 (Frequire): Mention get-load-suffixes.
61352f62 10178
28545e04
MR
101792011-07-02 Martin Rudalics <rudalics@gmx.at>
10180
10181 * window.h (window): Remove clone_number slot.
10182 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10183 Remove.
10184 (make_parent_window, make_window, saved_window)
10185 (Fset_window_configuration, save_window_save): Don't deal with
10186 clone numbers.
10187 * buffer.c (Qclone_number): Remove declaration.
10188 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10189
3349e122
SM
101902011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10191
10192 Add multiple inheritance to keymaps.
10193 * keymap.c (Fmake_composed_keymap): New function.
10194 (Fset_keymap_parent): Simplify.
10195 (fix_submap_inheritance): Remove.
10196 (access_keymap_1): New function extracted from access_keymap to handle
10197 embedded parents and handle lists of maps.
10198 (access_keymap): Use it.
10199 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10200 (Fcopy_keymap): Handle embedded parents.
10201 (Fcommand_remapping, define_as_prefix): Simplify.
10202 (Fkey_binding): Simplify.
10203 (syms_of_keymap): Move minibuffer-local-completion-map,
10204 minibuffer-local-filename-completion-map,
10205 minibuffer-local-must-match-map, and
10206 minibuffer-local-filename-must-match-map to Elisp.
10207 (syms_of_keymap): Defsubr make-composed-keymap.
10208 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10209 (parse_menu_item): Trivial simplification.
10210
3279eb87
GM
102112011-07-01 Glenn Morris <rgm@gnu.org>
10212
10213 * Makefile.in (SETTINGS_LIBS): Fix typo.
10214
39cb9e56 102152011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10216
10217 * coding.c (Fencode_coding_string): Record the last coding system
10218 used, as the function doc string says (bug#8738).
10219
0949d2b6
JD
102202011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10221
10222 * xsettings.c (store_monospaced_changed): Take new font as arg and
10223 check for change against current_mono_font.
10224 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10225 (emacs_settings_constructor, emacs_settings_get_property)
10226 (emacs_settings_set_property, emacs_settings_class_init)
10227 (emacs_settings_init, gsettings_obj): Remove.
10228 (something_changedCB): New function for HAVE_GSETTINGS.
10229 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10230 with value as argument.
10231 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10232 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10233 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10234 "changed".
10235
10236 * xgselect.c: Add defined (HAVE_GSETTINGS).
10237 (xgselect_initialize): Ditto.
10238
10239 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10240 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10241 xg_select.
10242
bbc6b304
PE
102432011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10244
10245 * eval.c (struct backtrace): Simplify and port the data structure.
10246 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10247 signed bit field, as this assumption is not portable and it makes
10248 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10249 "char debug_on_exit : 1" as this is not portable either; instead,
10250 use the portable "unsigned int debug_on_exit : 1". Remove unused
10251 member evalargs. Remove obsolete comments about cc bombing out.
10252
9851bfc5
JD
102532011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10254
51bb811f 10255 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10256 Let HAVE_GSETTINGS override HAVE_GCONF.
10257 (store_monospaced_changed): New function.
10258 (EMACS_SETTINGS): A new type derived from GObject to handle
10259 GSettings notifications.
10260 (emacs_settings_constructor, emacs_settings_get_property)
10261 (emacs_settings_set_property, emacs_settings_class_init):
10262 New functions.
10263 (gsettings_client, gsettings_obj): New variables.
10264 (GSETTINGS_SCHEMA): New define.
10265 (something_changedCB): Call store_monospaced_changed.
10266 (init_gsettings): New function.
10267 (xsettings_initialize): Call init_gsettings.
10268 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10269 to NULL.
10270
640c8776 10271 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10272 GCONF_CFLAGS/LIBS.
10273
5386012d
MR
102742011-06-29 Martin Rudalics <rudalics@gmx.at>
10275
10276 * window.c (resize_root_window, grow_mini_window)
10277 (shrink_mini_window): Rename Qresize_root_window to
10278 Qwindow_resize_root_window and Qresize_root_window_vertically to
10279 Qwindow_resize_root_window_vertically.
10280
f13e0b08
PE
102812011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10282
10283 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10284
94515237
JB
102852011-06-27 Juanma Barranquero <lekktu@gmail.com>
10286
10287 * makefile.w32-in: Redesign dependencies so they reflect more
10288 clearly which files are directly included by each source file,
10289 and not through other includes.
10290
e43b6e43
MR
102912011-06-27 Martin Rudalics <rudalics@gmx.at>
10292
10293 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10294 (sort_overlays, overlay_strings): When an overlay's clone number
10295 matches the window's clone number process the overlay even if
10296 the overlay's window property doesn't match the current window.
10297
d68443dc
MR
10298 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10299 (Fwindow_hchild): Rename to Fwindow_left_child.
10300 (Fwindow_next): Rename to Fwindow_next_sibling.
10301 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10302 (resize_window_check): Rename to window_resize_check.
10303 (resize_window_apply): Rename to window_resize_apply.
10304 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10305 (Fdelete_other_windows_internal, resize_frame_windows)
10306 (Fsplit_window_internal, Fdelete_window_internal)
10307 (grow_mini_window, shrink_mini_window)
10308 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10309
c7e73be5
JD
103102011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10311
10312 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10313 (emacs_fixed_set_min_size): Remove.
10314 (emacs_fixed_new): Take frame as argument.
10315
10316 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10317 (_EmacsFixedPrivate): Remove minwidth/height.
10318 Add struct frame *f.
10319 (emacs_fixed_init): Initialize priv->f.
10320 (get_parent_class, emacs_fixed_set_min_size): Remove.
10321 (emacs_fixed_new): Set priv->f to argument.
10322 (emacs_fixed_get_preferred_width)
10323 (emacs_fixed_get_preferred_height): Use min_width/height from
10324 frames size_hint to set minimum and natural (Bug#8919).
10325 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10326 and use min_width/height from frames size_hint to set
10327 min_width/height (Bug#8919).
10328
10329 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10330 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10331 Fix indentation.
c7e73be5 10332
cf99dcf8
EZ
103332011-06-26 Eli Zaretskii <eliz@gnu.org>
10334
10335 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10336 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10337 called at ZV.
10338
029529ac
CY
103392011-06-26 Chong Yidong <cyd@stupidchicken.com>
10340
10341 * process.c (wait_reading_process_output): Bypass select if
10342 waiting for a cell while ignoring keyboard input, and input is
10343 pending. Suggested by Jan Djärv (Bug#8869).
10344
7a7ef429
PE
103452011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10346
10347 Use gnulib's dup2 module instead of rolling our own.
10348 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10349
11fdef7d 103502011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10351
10352 * dispnew.c (scrolling_window): Before scrolling, turn off a
10353 mouse-highlight in the window being scrolled.
10354
cd3520a4
JB
103552011-06-24 Juanma Barranquero <lekktu@gmail.com>
10356
10357 Move DEFSYM to lisp.h and use everywhere.
10358
10359 * character.h (DEFSYM): Move declaration...
10360 * lisp.h (DEFSYM): ...here.
10361
10362 * gnutls.c:
10363 * minibuf.c:
10364 * w32menu.c:
10365 * w32proc.c:
10366 * w32select.c: Don't include character.h.
10367
10368 * alloc.c (syms_of_alloc):
10369 * buffer.c (syms_of_buffer):
10370 * bytecode.c (syms_of_bytecode):
10371 * callint.c (syms_of_callint):
10372 * casefiddle.c (syms_of_casefiddle):
10373 * casetab.c (init_casetab_once):
10374 * category.c (init_category_once, syms_of_category):
10375 * ccl.c (syms_of_ccl):
10376 * cmds.c (syms_of_cmds):
10377 * composite.c (syms_of_composite):
10378 * dbusbind.c (syms_of_dbusbind):
10379 * dired.c (syms_of_dired):
10380 * dispnew.c (syms_of_display):
10381 * doc.c (syms_of_doc):
10382 * editfns.c (syms_of_editfns):
10383 * emacs.c (syms_of_emacs):
10384 * eval.c (syms_of_eval):
10385 * fileio.c (syms_of_fileio):
10386 * fns.c (syms_of_fns):
10387 * frame.c (syms_of_frame):
10388 * fringe.c (syms_of_fringe):
10389 * insdel.c (syms_of_insdel):
10390 * keymap.c (syms_of_keymap):
10391 * lread.c (init_obarray, syms_of_lread):
10392 * macros.c (syms_of_macros):
10393 * msdos.c (syms_of_msdos):
10394 * print.c (syms_of_print):
10395 * process.c (syms_of_process):
10396 * search.c (syms_of_search):
10397 * sound.c (syms_of_sound):
10398 * syntax.c (init_syntax_once, syms_of_syntax):
10399 * terminal.c (syms_of_terminal):
10400 * textprop.c (syms_of_textprop):
10401 * undo.c (syms_of_undo):
10402 * w32.c (globals_of_w32):
10403 * window.c (syms_of_window):
10404 * xdisp.c (syms_of_xdisp):
10405 * xfaces.c (syms_of_xfaces):
10406 * xfns.c (syms_of_xfns):
10407 * xmenu.c (syms_of_xmenu):
10408 * xsettings.c (syms_of_xsettings):
10409 * xterm.c (syms_of_xterm): Use DEFSYM.
10410
4228cf16
TZ
104112011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10412
cd3520a4 10413 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10414
7fcccf1e
PE
104152011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10416
7efb4e0e
PE
10417 Integer and buffer overflow fixes (Bug#8873).
10418
ff5844ad
PE
10419 * print.c (printchar, strout): Check for string overflow.
10420 (PRINTPREPARE, printchar, strout):
10421 Don't set size unless allocation succeeds.
10422
90532f02
PE
10423 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10424 for sizes. Check for string overflow more accurately.
10425 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10426
6d84508d
PE
10427 * macros.c: Integer and buffer overflow fixes.
10428 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10429 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10430 Use ptrdiff_t, not int, for sizes.
10431 Don't increment bufsize until after realloc succeeds.
10432 Check for size-calculation overflow.
10433 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10434
437b2cb4
PE
10435 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10436
8b9ac8b4
PE
10437 * lread.c: Integer overflow fixes.
10438 (read_integer): Radix is now EMACS_INT, not int,
10439 to improve quality of diagnostics for out-of-range radices.
10440 Calculate buffer size correctly for out-of-range radices.
10441 (read1): Check for integer overflow in radices, and in
10442 read-circle numbers.
82cb60d3
PE
10443 (read_escape): Avoid int overflow.
10444 (Fload, openp, read_buffer_size, read1)
10445 (substitute_object_recurse, read_vector, read_list, map_obarray):
10446 Use ptrdiff_t, not int, for sizes.
10447 (read1): Use EMACS_INT, not int, for sizes.
20270765 10448 Check for size overflow.
8b9ac8b4 10449
7fcccf1e
PE
10450 * image.c (cache_image): Check for size arithmetic overflow.
10451
bfbbd7e7
PE
10452 * lread.c: Integer overflow issues.
10453 (saved_doc_string_size, saved_doc_string_length)
10454 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10455 Now ptrdiff_t, not int.
10456 (read1): Don't assume doc string length fits in int. Check for
10457 out-of-range doc string lengths.
10458 (read_list): Don't assume file position fits in int.
39019e54 10459 (read_escape): Check for hex character overflow.
bfbbd7e7 10460
4e323265
LL
104612011-06-22 Leo Liu <sdl.web@gmail.com>
10462
10463 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10464 Move to minibuffer.el.
10465
85fece3e
PE
104662011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10467
20b84ce9 10468 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10469 The following patches are for when GLYPH_DEBUG && !XASSERT.
10470 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10471 * dispnew.c (flush_stdout):
10472 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10473 Mark as externally visible.
10474 * dispnew.c (check_window_matrix_pointers): Now static.
10475 * dispnew.c (window_to_frame_vpos):
10476 * xfns.c (unwind_create_frame):
10477 * xterm.c (x_check_font): Remove unused local.
10478 * scroll.c (CHECK_BOUNDS):
10479 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10480 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10481 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10482 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10483 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10484 Now static.
10485 (debug_method_add): Use va_list and vsprintf rather than relying
10486 on undefined behavior with wrong number of arguments.
10487 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10488 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10489 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10490 since we're not interested in debugging glyphs with old libraries.
10491 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10492 GCC 4.6.0's static checking.
10493
0766b489
PE
104942011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10495
31fd4b32
PE
10496 Integer overflow and signedness fixes (Bug#8873).
10497 A few related buffer overrun fixes, too.
10498
b79e8648
PE
10499 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10500
0766b489
PE
10501 * dispextern.h (struct face.stipple):
10502 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10503 (x_bitmap_mask, x_allocate_bitmap_record)
10504 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10505 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10506 (x_create_bitmap_from_xpm_data):
10507 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10508 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10509 (.bitmaps_last):
10510 * xfaces.c (load_pixmap):
10511 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10512 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10513 (.bitmaps_last, struct x_output.icon_bitmap):
10514 Use ptrdiff_t, not int, for bitmap indexes.
10515 (x_allocate_bitmap_record): Check for size overflow.
10516 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10517
b081724f
PE
10518 Use ptrdiff_t, not int, for overlay counts.
10519 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10520 * editfns.c (overlays_around, get_pos_property):
10521 * textprop.c (get_char_property_and_overlay):
10522 * xdisp.c (next_overlay_change, note_mouse_highlight):
10523 * xfaces.c (face_at_buffer_position):
21514da7
PE
10524 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10525 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10526 (Fnext_overlay_change, Fprevious_overlay_change)
10527 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10528 Use ptrdiff_t, not int, for sizes.
21514da7 10529 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10530
3de73e5e
PE
10531 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10532
2606c57b
PE
10533 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10534 (x_session_initialize): Do not assume string length fits in int.
10535
aaafe47a
PE
10536 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10537 This is unlikely, but can occur if DPI is outlandish.
10538
2674ddc8 10539 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10540 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10541
28154962
PE
10542 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10543 * xrdb.c (magic_file_p, search_magic_path):
10544 Omit last arg SUFFIX; it was always 0. All callers changed.
10545 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10546
7de51af5
PE
10547 * xfont.c (xfont_match): Avoid need for strlen.
10548
25ed6cc3
PE
10549 * xfns.c: Don't assume strlen fits in int.
10550 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10551
4eab31dd
PE
10552 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10553 not unsigned long, as we prefer signed integers. All callers changed.
10554 Detect integer overflow in repeat count.
10555 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10556 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10557
171e2a58
PE
10558 * termcap.c: Don't assume sizes fit in int and never overflow.
10559 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10560 (gobble_line): Check for size-calculation overflow.
10561
ad39faca 10562 * minibuf.c (Fread_buffer):
6e5bb2dc 10563 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10564 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10565 Don't assume string length fits in int.
10566
52c61c22 10567 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10568 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10569
b5b8c9e5
PE
10570 * font.c: Don't assume string length fits in int.
10571 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10572 Use ptrdiff_t, not int.
ccd6111c
PE
10573 (font_intern_prop): Don't assume string length fits in int.
10574 Don't assume integer property fits in fixnum.
10575 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10576
882f0d81 10577 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10578 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10579 Reformulate so as not to need the command string.
10580 Invoke gzip -cd rather than gunzip, as it's more portable.
10581 (lock_info_type, lock_file_1, lock_file):
10582 Don't assume pid_t and time_t fit in unsigned long.
10583 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10584 (current_lock_owner): Prefer signed type for sizes.
10585 Use memcpy, not strncpy, where memcpy is what is really wanted.
10586 Don't assume (via atoi) that time_t and pid_t fit in int.
10587 Check for time_t and/or pid_t out of range, e.g., via a network share.
10588 Don't alloca where an auto var works fine.
10589
93f4cf88
PE
10590 * fileio.c: Fix some integer overflow issues.
10591 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10592 Don't assume string length fits in int.
10593 (directory_file_name): Don't assume string length fits in long.
10594 (make_temp_name): Don't assume pid fits in int, or that its print
10595 length is less than 20.
10596
f3e92b69
PE
10597 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10598
1bfdaf10
PE
10599 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10600
35016e9a
PE
10601 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10602
3d1e65a1
PE
10603 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10604 We prefer signed integers, even for size calculations.
10605
0b963a93
PE
10606 * emacs.c: Don't assume string length fits in 'int'.
10607 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10608 (main): Don't invoke strlen when not needed.
10609
573f4b54
PE
10610 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10611 (XD_DEBUG_MESSAGE): Don't waste a byte.
10612
989f33ba
PE
10613 * callproc.c (getenv_internal_1, getenv_internal)
10614 (Fgetenv_internal):
965d34eb
PE
10615 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10616
e4d29b33
PE
10617 * lread.c (invalid_syntax): Omit length argument.
10618 All uses changed. This doesn't fix a bug, but it simplifies the
10619 code away from its former Hollerith-constant appearance, and it's
10620 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10621 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10622
eb49b136
PE
10623 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10624 This didn't break anything, but it didn't help either.
10625 It's confusing to put a bogus integer in a place where the actual
10626 value does not matter.
9f62aeb1 10627 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10628 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10629
15375a22
PE
10630 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10631 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10632 implementation.
b61cc01c
PE
10633 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10634 We prefer signed types, and the value cannot exceed the EMACS_INT
10635 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10636 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10637 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10638 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10639
53b2623d
PE
10640 * indent.c (sane_tab_width): New function.
10641 (current_column, scan_for_column, Findent_to, position_indentation)
10642 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10643 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10644
51cab52b 10645 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10646
f2ed8a70
PE
10647 * lisp.h (lint_assume): New macro.
10648 * composite.c (composition_gstring_put_cache):
10649 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10650
abe80cc6
PE
10651 * editfns.c, insdel.c:
10652 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10653
b02c740e
PE
10654 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10655
ebc96716
PE
10656 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10657
b4e50fa0 10658 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10659 Use much-faster test for byte-length change.
311d5d7c 10660 Don't assume string byte-length fits in 'int'.
a4cf38e4 10661 Check that character arg fits in 'int'.
85461888 10662 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10663
c0c1ee9f
PE
10664 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10665
a498d7f4
PE
10666 * fns.c (concat): Catch string overflow earlier.
10667 Do not rely on integer wraparound.
10668
51cab52b
PE
10669 * dispextern.h (struct it.overlay_strings_charpos)
10670 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10671 * xdisp.c (forward_to_next_line_start)
10672 (back_to_previous_visible_line_start)
10673 (reseat_at_next_visible_line_start, next_element_from_buffer):
10674 Don't arbitrarily truncate the value of 'selective' to int.
10675
76031fad
PE
10676 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10677
5eb55db9
PE
10678 * composite.c: Don't truncate sizes to 'int'.
10679 (composition_gstring_p, composition_reseat_it)
10680 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10681 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10682 not EMACS_UINT, for indexes.
5eb55db9 10683
0703a717
PE
10684 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10685
d6202519
PE
10686 * buffer.c: Include <verify.h>.
10687 (struct sortvec.priority, struct sortstr.priority):
8961a454 10688 Now EMACS_INT, not int.
c20998a7 10689 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10690 (struct sortstr.size, record_overlay_string)
10691 (struct sortstrlist.size, struct sortlist.used):
10692 Don't truncate size to int.
10693 (record_overlay_string): Check for size-calculation overflow.
d6202519 10694 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10695
d5a19415
JM
106962011-06-22 Jim Meyering <meyering@redhat.com>
10697
029529ac 10698 Don't leak an XBM-image-sized buffer
d5a19415
JM
10699 * image.c (xbm_load): Free the image buffer after using it.
10700
a9041e6c
PE
107012011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10702
10703 Port to Sun C.
10704 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10705 that Sun C diagnosed.
10706 * fns.c (secure_hash): Fix pointer signedness issue.
10707 * intervals.c (static_offset_intervals): New function.
10708 (offset_intervals): Use it.
10709
7f3f739f
LL
107102011-06-21 Leo Liu <sdl.web@gmail.com>
10711
10712 * deps.mk (fns.o):
10713 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10714 sha512.h.
10715
10716 * fns.c (secure_hash): Rename from crypto_hash_function and change
10717 the first arg to accept symbols.
5b66d427 10718 (Fsecure_hash): New primitive.
7f3f739f
LL
10719 (syms_of_fns): New symbols.
10720
76147d94
DD
107212011-06-20 Deniz Dogan <deniz@dogan.se>
10722
10723 * process.c (Fset_process_buffer): Clarify return value in
10724 docstring.
10725
7d7d0045
CY
107262011-06-18 Chong Yidong <cyd@stupidchicken.com>
10727
10728 * dispnew.c (add_window_display_history): Use BVAR.
10729
10730 * xdisp.c (debug_method_add): Use BVAR.
10731 (check_window_end, dump_glyph_matrix, dump_glyph)
10732 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10733
10734 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10735 Likewise.
10736
10737 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10738 check till after the cache is created in init_frame_faces.
10739
ff2bc410
SM
107402011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10741
10742 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10743
28177add
PE
107442011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10745
dd3482fe
PE
10746 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10747 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10748 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10749
393d71f3 10750 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10751 * fileio.c (Finsert_file_contents):
10752 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10753 Remove the old (too-loose) buffer overflow checks.
10754 They weren't needed, since make_gap checks for buffer overflow.
10755 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10756 The old code merely checked for Emacs fixnum overflow, and relied
10757 on undefined (wraparound) behavior. The new code avoids undefined
10758 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10759
2e6813b0 10760 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10761 Tune. Don't use wider integers than needed. Don't use alloca.
10762 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10763
599a9e4f
PE
10764 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10765
99561444
PE
10766 * insdel.c, lisp.h (buffer_overflow): New function.
10767 (insert_from_buffer_1, replace_range, replace_range_2):
10768 * insdel.c (make_gap_larger):
10769 * editfns.c (Finsert_char):
10770 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10771
28177add
PE
10772 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10773
e69dafad
PE
107742011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10775
4baa020d 10776 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10777
b1c46f02
PE
10778 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10779 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10780
e69dafad
PE
10781 * fileio.c: Don't assume EMACS_INT fits in off_t.
10782 (emacs_lseek): New static function.
10783 (Finsert_file_contents, Fwrite_region): Use it.
10784 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10785
566684ea
PE
10786 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10787
e6966cd6
PE
10788 * fns.c: Don't overflow int when computing a list length.
10789 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10790 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10791 truncation on 64-bit hosts. Check for QUIT every
10792 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10793 faster and is responsive enough.
10794 (Flength): Report an error instead of overflowing an integer.
10795 (Fsafe_length): Return a float if the value is not representable
10796 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10797 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10798 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10799
dd0b0efb
PE
10800 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10801 (header_size, word_size): New constants.
10802 (allocate_vectorlike): Don't check size overflow here.
10803 (allocate_vector): Check it here instead, since this is the only
10804 caller of allocate_vectorlike that could cause overflow.
10805 Check that the new vector's length is representable as a fixnum.
10806
86fe5cfe
PE
10807 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10808 The previous code was bogus. For example, next_almost_prime (32)
10809 returned 39, which is undesirable as it is a multiple of 3; and
10810 next_almost_prime (24) returned 25, which is a multiple of 5 so
10811 why was the code bothering to check for multiples of 7?
10812
80e88859
PE
10813 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10814
4a2f0ad6
PE
10815 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10816
f66c7cf8
PE
10817 Variadic C functions now count arguments with ptrdiff_t.
10818 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10819 Back then I didn't know that the Emacs coding style prefers signed int.
10820 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10821 were being counted with int, which may truncate counts on 64-bit
10822 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10823 * lisp.h (struct Lisp_Subr.function.aMANY)
10824 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10825 Arg counts are now ptrdiff_t, not size_t.
10826 All variadic functions and their callers changed accordingly.
10827 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10828 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10829 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10830 * callint.c (Fcall_interactively): Check arg count for overflow,
10831 to avoid potential buffer overrun. Use signed char, not 'int',
10832 for 'varies' array, so that we needn't bother to check its size
10833 calculation for overflow.
10834 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10835 * eval.c (apply_lambda):
10836 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10837 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10838 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10839
a1759b76
PE
10840 * callint.c (Fcall_interactively): Don't use index var as event count.
10841
d96be9fc
PE
10842 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10843 * mem-limits.h (SIZE): Remove; no longer used.
10844
a690a978 10845 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10846
578c21e6
PE
10847 Remove unnecessary casts.
10848 * xterm.c (x_term_init):
10849 * xfns.c (x_set_border_pixel):
10850 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10851 These aren't needed now that we assume ANSI C.
10852
96f53c6c
PE
10853 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10854 It's more likely to cause problems (due to unsigned overflow)
10855 than to cure them.
10856
83c77d31
PE
10857 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10858
ee2079f1
PE
10859 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10860
6da65536
PE
10861 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10862
7147c4a4
PE
10863 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10864
193e32d9
PE
10865 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10866
e5533da6
PE
10867 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10868
9910e595
PE
10869 GLYPH_CODE_FACE returns EMACS_INT, not int.
10870 * dispextern.h (merge_faces):
10871 * xfaces.c (merge_faces):
01103c44
PE
10872 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10873 Don't assume EMACS_INT fits in int.
9910e595 10874
2638320e
PE
10875 * character.h (CHAR_VALID_P): Remove unused parameter.
10876 * fontset.c, lisp.h, xdisp.c: All uses changed.
10877
045eb8d9
PE
10878 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10879
c1f134b5
PE
10880 * fns.c (concat): Minor tuning based on overflow analysis.
10881 This doesn't fix any bugs. Use int to hold character, instead
10882 of constantly refetching from Emacs object. Use XFASTINT, not
10883 XINT, for value known to be a character. Don't bother comparing
10884 a single byte to 0400, as it's always less.
10885
395fcb93 10886 * floatfns.c (Fexpt):
327eeec8
PE
10887 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10888
abbd3d23
PE
10889 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10890 for characters.
10891
684a03ef
PE
10892 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10893
0fed43f3
PE
10894 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10895 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10896 incorrectly succeed when S was a string, because 4294967386 was
10897 truncated before it was used.
10898
8fd02eb7
PE
10899 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10900 Otherwise, an out-of-range integer could cause undefined behavior
10901 on a 64-bit host.
10902
f8c86b69
PE
10903 * composite.c: Use int, not EMACS_INT, for characters.
10904 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10905 EMACS_INT, for values that are known to be in character range.
10906 This doesn't fix any bugs but is the usual style inside Emacs and
10907 may generate better code on 32-bit machines.
10908
34206dd2
PE
10909 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10910 This is for reasons similar to the recent CHAR_STRING fix.
10911 * charset.c (Fencode_char): Check that character arg is actually
10912 a character. Pass an int to ENCODE_CHAR.
10913 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10914 wider than 'int', as a compile-time check to prevent future regressions
10915 in this area.
10916
c5958d4c 10917 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10918
10919 Make sure a 64-bit char is never passed to CHAR_STRING.
10920 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10921 by silently ignoring the top 32 bits, allowing some values
10922 that were far too large to be valid characters.
10923 * character.h: Include <verify.h>.
10924 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10925 arguments are no wider than unsigned, as a compile-time check
10926 to prevent future regressions in this area.
10927 * data.c (Faset):
01103c44 10928 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10929 (Fsubst_char_in_region):
10930 * fns.c (concat):
10931 * xdisp.c (decode_mode_spec_coding):
10932 Adjust to CHAR_STRING's new requirement.
10933 * editfns.c (Finsert_char, Fsubst_char_in_region):
10934 * fns.c (concat): Check that character args are actually
10935 characters. Without this test, these functions did the wrong
10936 thing with wildly out-of-range values on 64-bit hosts.
10937
d37ca623
PE
10938 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10939 These casts should not be needed on 32-bit hosts, either.
10940 * keyboard.c (read_char):
10941 * lread.c (Fload): Remove casts to unsigned.
10942
ea204efb
PE
10943 * lisp.h (UNSIGNED_CMP): New macro.
10944 This fixes comparison bugs on 64-bit hosts.
10945 (ASCII_CHAR_P): Use it.
10946 * casefiddle.c (casify_object):
01103c44 10947 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10948 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10949 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10950 * dispextern.h (FACE_FROM_ID):
10951 * keyboard.c (read_char): Use UNSIGNED_CMP.
10952
41cb286c
PE
10953 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10954 not to EMACS_INT, to avoid GCC warning.
10955
4a1b9832
PE
10956 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10957
55daad71
PE
10958 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10959 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10960 isn't needed on 32-bit machines.
8f95c75c 10961
01103c44
PE
10962 * buffer.c (Fgenerate_new_buffer_name):
10963 Use EMACS_INT for count, not int.
0ceccced 10964 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10965
10966 * data.c (Qcompiled_function): Now static.
10967
c6f072e7
PE
10968 * window.c (window_body_lines): Now static.
10969
20ce5912
PE
10970 * image.c (gif_load): Rename local to avoid shadowing.
10971
9c4c5f81
PE
10972 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10973 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10974 * alloc.c (make_save_value): Integer argument is now of type
10975 ptrdiff_t, not int.
10976 (mark_object): Use ptrdiff_t, not int.
10977 * lisp.h (pD): New macro.
10978 * print.c (print_object): Use it.
10979
c0c5c8ae
PE
10980 * alloc.c: Use EMACS_INT, not int, to count objects.
10981 (total_conses, total_markers, total_symbols, total_vector_size)
10982 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10983 (total_free_floats, total_floats, total_free_intervals)
10984 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10985 Now EMACS_INT, not int. All uses changed.
10986 (Fgarbage_collect): Compute overall total using a double, so that
10987 integer overflow is less likely to be a problem. Check for overflow
10988 when converting back to an integer.
5a25e253
PE
10989 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10990 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10991 These were 'int' variables that could overflow on 64-bit hosts;
10992 they were never used, so remove them instead of repairing them.
211a0b2a 10993 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10994 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10995 Previously, this ceilinged at INT_MAX, but that doesn't work on
10996 64-bit machines.
e46bb31a 10997 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10998
c78baabf 10999 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 11000 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
11001 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
11002 when a (possibly-narrower) signed value would do just as well.
11003 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 11004
c9d624c6
PE
11005 * alloc.c: Catch some string size overflows that we were missing.
11006 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11007 for convenience in STRING_BYTES_MAX.
11008 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11009 The definition here is exact; the one in lisp.h was approximate.
11010 (allocate_string_data): Check for string overflow. This catches
11011 some instances we weren't catching before. Also, it catches
11012 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11013 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11014 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11015
c9d624c6
PE
11016 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11017 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11018 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11019
353032ce
PE
11020 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11021
2bccce07
PE
11022 * alloc.c (Fmake_string): Check for out-of-range init.
11023
0ac30604
SM
110242011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11025
11026 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11027
c195f2de
JD
110282011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11029
11030 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11031 xg_get_default_scrollbar_width.
11032
11033 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11034 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11035 (style_changed_cb): Call update_theme_scrollbar_width and call
11036 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11037 all frames (Bug#8505).
11038 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11039 Call gtk_window_set_resizable if HAVE_GTK3.
11040 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11041 and height if HAVE_GTK3 (Bug#8505).
11042 (scroll_bar_width_for_theme): New variable.
11043 (update_theme_scrollbar_width): New function.
11044 (xg_get_default_scrollbar_width): Move code to
11045 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11046 (xg_initialize): Call update_theme_scrollbar_width.
11047
11048 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11049
11050 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11051
e10ac9f1
MR
110522011-06-12 Martin Rudalics <rudalics@gmx.at>
11053
11054 * frame.c (make_frame): Call other_buffer_safely instead of
11055 other_buffer.
11056
11057 * window.c (temp_output_buffer_show): Call display_buffer with
11058 second argument Vtemp_buffer_show_specifiers and reset latter
11059 immediately after the call.
11060 (Vtemp_buffer_show_specifiers): New variable.
11061 (auto_window_vscroll_p, next_screen_context_lines)
11062 (Vscroll_preserve_screen_position): Remove leading asterisks from
11063 doc-strings.
11064
2d3c217e 110652011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11066
7b7f97e8 11067 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11068 * buffer.c (Qclone_number): Remove for now, as it's unused.
11069 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11070 (record_buffer): Remove unused local.
11071 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11072 (set_frame_buffer_list): Remove; unused.
11073 * frame.h (other_visible_frames): Remove decl.
11074 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11075 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11076 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11077 if HAVE_GPM.
11078 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11079 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11080 Define only if HAVE_GPM.
11081 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11082 (update_hints_inhibit): Remove; never set. All uses removed.
11083 * widgetprv.h (emacsFrameClassRec): Remove decl.
11084 * window.c (delete_deletable_window): Now returns void, since it
11085 wasn't returning anything.
11086 (compare_window_configurations): Remove unused locals.
11087 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11088 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11089 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11090 the same widths as pointers. This follows up on the 2011-05-06 patch.
11091 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11092 * xterm.h: Likewise.
11093 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11094
1384b89e
JB
110952011-06-12 Juanma Barranquero <lekktu@gmail.com>
11096
11097 * makefile.w32-in: Update dependencies.
11098 (LISP_H): Add lib/intprops.h.
11099
1100a63c
CY
111002011-06-11 Chong Yidong <cyd@stupidchicken.com>
11101
11102 * image.c (gif_load): Add animation frame delay to the metadata.
11103 (syms_of_image): Use DEFSYM. New symbol `delay'.
11104
6198ccd0
MR
111052011-06-11 Martin Rudalics <rudalics@gmx.at>
11106
11107 * window.c (delete_deletable_window): Re-add.
11108 (Fset_window_configuration): Rewrite to handle dead buffers and
11109 consequently deletable windows.
11110 (window_tree, Fwindow_tree): Remove. Supply functionality in
11111 window.el.
11112 (compare_window_configurations): Simplify code.
11113
b6e3633c
AS
111142011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11115
1ab0dee5
AS
11116 * image.c (imagemagick_load_image): Fix type mismatch.
11117 (Fimagemagick_types): Likewise.
11118
b6e3633c
AS
11119 * window.h (replace_buffer_in_windows): Declare.
11120
9397e56f
MR
111212011-06-11 Martin Rudalics <rudalics@gmx.at>
11122
11123 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11124 Qclone_number. Remove external declaration of Qdelete_window.
11125 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11126 code.
640c8776
SM
11127 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11128 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11129 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11130 buffer list implementation.
11131 (other_buffer_safely): New function.
11132 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11133 calls to replace_buffer_in_windows and
11134 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11135 if allowed.
11136 (record_buffer): Inhibit quitting and rewrite using quittable
11137 functions. Run Qbuffer_list_update_hook if allowed.
11138 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11139 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11140 Move switch-to-buffer to window.el.
9397e56f
MR
11141 (bury-buffer): Move to window.el.
11142 (Vbuffer_list_update_hook): New variable.
11143
11144 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11145 section.
11146
11147 * window.h (resize_frame_windows): Move up in code.
11148 (Fwindow_frame): Remove EXFUN.
11149 (replace_buffer_in_all_windows): Remove prototype.
11150 (replace_buffer_in_windows_safely): Add prototype.
11151
11152 * window.c: Declare Qdelete_window static again. Move down
11153 declaration of select_count.
11154 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11155 (Fother_window): Move to window.el.
11156 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11157 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11158 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11159 window.el.
11160 (replace_buffer_in_windows): Implement by calling
11161 Qreplace_buffer_in_windows.
11162 (replace_buffer_in_all_windows): Remove with some functionality
11163 moved into replace_buffer_in_windows_safely.
11164 (replace_buffer_in_windows_safely): New function.
11165 (select_window_norecord, select_frame_norecord): Move in front
11166 of run_window_configuration_change_hook. Remove now obsolete
11167 declarations.
640c8776
SM
11168 (Fset_window_buffer): Rewrite doc-string.
11169 Call Qrecord_window_buffer.
9397e56f
MR
11170 (keys_of_window): Move binding for other-window to window.el.
11171
b50691aa
CY
111722011-06-11 Chong Yidong <cyd@stupidchicken.com>
11173
11174 * dispextern.h (struct image): Replace data member, whose int_val
11175 and ptr_val fields were not used by anything, with a single
11176 lisp_val object.
11177
11178 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11179 (gif_clear_image, gif_load, imagemagick_load_image)
11180 (gs_clear_image, gs_load): Callers changed.
11181
3f754b86
PE
111822011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11183
cca69397
PE
11184 * buffer.h: Include <time.h>, for time_t.
11185 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11186
109e28d0
PE
11187 Fix minor problems found by static checking.
11188
60737f02
PE
11189 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11190
4b66faf3
PE
11191 Make identifiers static if they are not used in other modules.
11192 * data.c (Qcompiled_function, Qframe, Qvector):
11193 * image.c (QimageMagick, Qsvg):
11194 * minibuf.c (Qmetadata):
11195 * window.c (resize_window_check, resize_root_window): Now static.
11196 * window.h (resize_window_check, resize_root_window): Remove decls.
11197
109e28d0
PE
11198 * window.c (window_deletion_count, delete_deletable_window):
11199 Remove; unused.
46a4ce9e
PE
11200 (window_body_lines): Now static.
11201 (Fdelete_other_windows_internal): Mark vars as initialized.
11202 Make sure 'resize_failed' is initialized.
11203 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11204 (resize_window_apply): Remove unused local.
11205 * window.h (delete_deletable_window): Remove decl.
11206
109e28d0 11207 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11208 (imagemagick_load_image): Fix pointer signedness problem by changing
11209 last arg from unsigned char * to char *. All uses changed.
11210 Also, fix a local for similar reasons.
11211 Remove unused locals. Remove locals to avoid shadowing.
11212 (fn_rsvg_handle_free): Remove; unused.
11213 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11214 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11215
3f754b86
PE
11216 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11217
2547adb1
CY
112182011-06-10 Chong Yidong <cyd@stupidchicken.com>
11219
11220 * image.c (gif_load): Fix omitted cast error introduced by
11221 2011-06-06 change.
11222
2c8e37d4
MR
112232011-06-10 Martin Rudalics <rudalics@gmx.at>
11224
11225 * window.h (resize_proportionally, orig_total_lines)
11226 (orig_top_line): Remove from window structure.
11227 (set_window_height, set_window_width, change_window_heights)
11228 (Fdelete_window): Remove prototypes.
11229 (resize_frame_windows): Remove duplicate declaration.
11230
440a42e3
EZ
112312011-06-10 Eli Zaretskii <eliz@gnu.org>
11232
11233 * window.h (resize_frame_windows, resize_window_check)
11234 (delete_deletable_window, resize_root_window)
11235 (resize_frame_windows): Declare prototypes.
11236
11237 * window.c (resize_window_apply): Make definition be "static" to
11238 match the prototype.
11239
562dd5e9
MR
112402011-06-10 Martin Rudalics <rudalics@gmx.at>
11241
11242 * window.c: Remove declarations of Qwindow_size_fixed,
11243 window_min_size_1, window_min_size_2, window_min_size,
11244 size_window, window_fixed_size_p, enlarge_window, delete_window.
11245 Remove static from declaration of Qdelete_window, it's
11246 temporarily needed by Fbury_buffer.
11247 (replace_window): Don't assign orig_top_line and
11248 orig_total_lines.
11249 (Fdelete_window, delete_window): Remove. Window deletion is
11250 handled by window.el.
640c8776
SM
11251 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11252 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11253 (Fdelete_other_windows): Remove. Deleting other windows is
11254 handled by window.el.
11255 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11256 handled in window.el.
11257 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11258 Window minimum sizes are handled in window.el.
11259 (shrink_windows, size_window, set_window_height)
11260 (set_window_width, change_window_heights, window_height)
11261 (window_width, CURBEG, CURSIZE, enlarge_window)
11262 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11263 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11264 handled in window.el.
11265 (make_dummy_parent): Rename to make_parent_window and give it a
11266 second argument horflag.
11267 (make_window): Don't set resize_proportionally any more.
11268 (Fsplit_window): Remove. Windows are split in window.el.
11269 (save_restore_action, save_restore_orig_size)
11270 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11271 Resize mini windows in window.el.
11272 (grow_mini_window, shrink_mini_window): Implement by calling
11273 Qresize_root_window_vertically, resize_window_check and
11274 resize_window_apply.
640c8776
SM
11275 (saved_window, Fset_window_configuration, save_window_save):
11276 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11277 resize_proportionally.
11278 (window_min_height, window_min_width): Move to window.el.
11279 (keys_of_window): Move bindings for delete-other-windows,
11280 split-window, delete-window and enlarge-window to window.el.
11281
11282 * buffer.c: Temporarily extern Qdelete_window.
11283 (Fbury_buffer): Temporarily call Qdelete_window instead of
11284 Fdelete_window (Fbury_buffer will move to window.el soon).
11285
11286 * frame.c (set_menu_bar_lines_1): Remove code handling
11287 orig_top_line and orig_total_lines.
11288
11289 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11290 set_window_height but set heights directly.
11291 (change_frame_size_1): Use resize_frame_windows.
11292
11293 * xdisp.c (init_xdisp): Don't use set_window_height but set
11294 heights directly.
11295
640c8776
SM
11296 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11297 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11298 run_window_configuration_change_hook.
11299
11300 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11301 instead of change_window_heights and run
11302 run_window_configuration_change_hook.
11303
1a13852e
MR
113042011-06-09 Martin Rudalics <rudalics@gmx.at>
11305
11306 * window.c (replace_window): Rename second argument REPLACEMENT to
11307 NEW. New third argument SETFLAG. Rewrite.
11308 (delete_window, make_dummy_parent): Call replace_window with
11309 third argument 1.
11310 (window_list_1): Move down in code.
11311 (run_window_configuration_change_hook): Move set_buffer part
11312 before select_frame_norecord part in order to unwind correctly.
11313 Rename count1 to count.
11314 (recombine_windows, delete_deletable_window, resize_root_window)
11315 (Fdelete_other_windows_internal)
11316 (Frun_window_configuration_change_hook, make_parent_window)
11317 (resize_window_check, resize_window_apply, Fresize_window_apply)
11318 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11319 (Fdelete_window_internal, Fresize_mini_window_internal):
11320 New functions.
1a13852e
MR
11321 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11322
f3d1777e
MR
113232011-06-08 Martin Rudalics <rudalics@gmx.at>
11324
496e208e
MR
11325 * window.h (window): Add some new members to window structure -
11326 normal_lines, normal_cols, new_total, new_normal, clone_number,
11327 splits, nest, prev_buffers, next_buffers.
11328 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11329 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11330
f3d1777e
MR
11331 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11332 Remove.
496e208e
MR
11333 (make_dummy_parent): Set new members of windows structure.
11334 (make_window): Move down in code. Handle new members of window
11335 structure.
11336 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11337 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11338 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11339 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11340 (Fset_window_next_buffers, Fset_window_clone_number):
11341 New functions.
496e208e
MR
11342 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11343 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11344 Doc-string fixes.
11345 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11346 Argument WINDOW can be now internal window too.
11347 (Fwindow_use_time): Move up in code.
11348 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11349 Rewrite doc-string.
11350 (Fset_window_configuration, saved_window)
11351 (Fcurrent_window_configuration, save_window_save): Handle new
11352 members of window structure.
b9e809c2
MR
11353 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11354 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11355 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11356 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11357 Qget_mru_window, Qresize_root_window,
11358 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11359 Qauto_buffer_name; staticpro them.
f3d1777e 11360
abde8f8c
MR
113612011-06-07 Martin Rudalics <rudalics@gmx.at>
11362
11363 * window.c (Fwindow_total_size, Fwindow_left_column)
11364 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11365 (Fwindow_list_1): New functions.
11366 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11367 (Fwindow_width, Fscroll_left, Fscroll_right):
11368 Use window_body_cols instead of window_box_text_cols.
11369 (delete_window, Fset_window_configuration):
11370 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11371 (delete_all_subwindows): Take a window as argument and not a
11372 structure. Rewrite.
190b47e6
MR
11373 (window_loop): Remove handling of GET_LRU_WINDOW and
11374 GET_LARGEST_WINDOW.
11375 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11376
11377 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11378 window_box_text_cols. delete_all_subwindows now takes a
11379 Lisp_Object as argument.
abde8f8c 11380
640c8776
SM
11381 * indent.c (compute_motion, Fcompute_motion):
11382 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11383
fa8a67e6
MR
11384 * frame.c (delete_frame): Call delete_all_subwindows with root
11385 window as argument.
11386
a54e3482
DC
113872011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11388
11389 * fns.c (Fputhash): Document return value.
11390
60002bf5
CY
113912011-06-06 Chong Yidong <cyd@stupidchicken.com>
11392
11393 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11394
0c671da6 113952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11396
b862a52a 11397 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11398
be44ca6c
PE
11399 Check for overflow when converting integer to cons and back.
11400 * charset.c (Fdefine_charset_internal, Fdecode_char):
11401 Use cons_to_unsigned to catch overflow.
11402 (Fencode_char): Use INTEGER_TO_CONS.
11403 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11404 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11405 * data.c (long_to_cons, cons_to_long): Remove.
11406 (cons_to_unsigned, cons_to_signed): New functions.
11407 These signal an error for invalid or out-of-range values.
11408 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11409 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11410 * font.c (Ffont_variation_glyphs):
11411 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11412 * lisp.h: Include <intprops.h>.
11413 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11414 (cons_to_signed, cons_to_unsigned): New decls.
11415 (long_to_cons, cons_to_long): Remove decls.
11416 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11417 (Fprimitive_undo): Use CONS_TO_INTEGER.
11418 * xfns.c (Fx_window_property): Likewise.
11419 * xselect.c: Include <limits.h>.
11420 (x_own_selection, selection_data_to_lisp_data):
11421 Use INTEGER_TO_CONS.
11422 (x_handle_selection_request, x_handle_selection_clear)
11423 (x_get_foreign_selection, Fx_disown_selection_internal)
11424 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11425 (lisp_data_to_selection_data): Use cons_to_unsigned.
11426 (x_fill_property_data): Use cons_to_signed.
11427 Report values out of range.
11428
d1f3d2af
PE
11429 Check for buffer and string overflow more precisely.
11430 * buffer.h (BUF_BYTES_MAX): New macro.
11431 * lisp.h (STRING_BYTES_MAX): New macro.
11432 * alloc.c (Fmake_string):
11433 * character.c (string_escape_byte8):
11434 * coding.c (coding_alloc_by_realloc):
11435 * doprnt.c (doprnt):
11436 * editfns.c (Fformat):
11437 * eval.c (verror):
11438 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11439 since they may not be the same number.
11440 * editfns.c (Finsert_char):
11441 * fileio.c (Finsert_file_contents):
11442 Likewise for BUF_BYTES_MAX.
11443
dd52fcea
PE
11444 * image.c: Use ptrdiff_t, not int, for sizes.
11445 (slurp_file): Switch from int to ptrdiff_t.
11446 All uses changed.
11447 (slurp_file): Check that file size fits in both size_t (for
11448 malloc) and ptrdiff_t (for sanity and safety).
11449
7f9bbdbb
PE
11450 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11451 if b->modtime has its maximal value.
11452
dfe18f82
PE
11453 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11454
84acfcf0
PE
11455 Don't assume time_t can fit into int.
11456 * buffer.h (struct buffer.modtime): Now time_t, not int.
11457 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11458 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11459
ccd9a01a
PE
11460 Minor fixes for signed vs unsigned integers.
11461 * character.h (MAYBE_UNIFY_CHAR):
11462 * charset.c (maybe_unify_char):
11463 * keyboard.c (read_char, reorder_modifiers):
11464 XINT -> XFASTINT, since the integer must be nonnegative.
11465 * ftfont.c (ftfont_spec_pattern):
11466 * keymap.c (access_keymap, silly_event_symbol_error):
11467 XUINT -> XFASTINT, since the integer must be nonnegative.
11468 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11469 since it makes no difference and we prefer signed.
11470 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11471 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11472 nonnegative.
11473
d6d100dd
SM
114742011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11475
11476 * window.h (Fwindow_frame): Declare.
11477
2b6148e4
PE
114782011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11479
11480 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11481 (SPARE_MEMORY): Always define.
11482 (LARGE_REQUEST): Remove.
11483 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11484
f230ecc9
MR
114852011-06-06 Martin Rudalics <rudalics@gmx.at>
11486
727e958e
MR
11487 * lisp.h: Move EXFUNS for Fframe_root_window,
11488 Fframe_first_window and Fset_frame_selected_window to window.h.
11489
11490 * window.h: Move EXFUNS for Fframe_root_window,
11491 Fframe_first_window and Fset_frame_selected_window here from
11492 lisp.h.
11493
11494 * frame.c (Fwindow_frame, Fframe_first_window)
11495 (Fframe_root_window, Fframe_selected_window)
11496 (Fset_frame_selected_window): Move to window.c.
11497 (Factive_minibuffer_window): Move to minibuf.c.
11498 (Fother_visible_frames_p): New function.
11499
11500 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11501
f230ecc9
MR
11502 * window.c (decode_window, decode_any_window): Move up in code.
11503 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11504 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11505 (Fwindow_buffer): Move up and rewrite doc-string.
11506 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11507 (Fwindow_prev): New functions.
727e958e
MR
11508 (Fwindow_frame): Move here from frame.c. Accept any window as
11509 argument.
11510 (Fframe_root_window, Fframe_first_window)
11511 (Fframe_selected_window): Move here from frame.c. Accept frame
11512 or arbitrary window as argument. Update doc-strings.
11513 (Fminibuffer_window): Move up in code.
11514 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11515 (Fset_frame_selected_window): Move here from frame.c.
11516 Marginal rewrite.
727e958e
MR
11517 (Fselected_window, select_window, Fselect_window): Move up in
11518 code. Minor doc-string fixes.
f230ecc9 11519
4d09bcf6
PE
115202011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11521
11522 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11523 Do not assume that spare memory exists; that assumption is valid
11524 only if SYSTEM_MALLOC.
11525 (LARGE_REQUEST): New macro, so that the issue of large requests
11526 is separated from the issue of spare memory.
11527
810928a2
AS
115282011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11529
172418ad
AS
11530 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11531 format. (Bug#8806)
11532
43f862f7
AS
11533 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11534
810928a2
AS
11535 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11536 before statements.
11537
a059fe24
JD
115382011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11539
11540 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11541
11542 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11543
11544 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11545 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11546
989bf368
JB
115472011-06-05 Juanma Barranquero <lekktu@gmail.com>
11548
11549 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11550
4b80f674
CY
115512011-06-04 Chong Yidong <cyd@stupidchicken.com>
11552
11553 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11554 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11555 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11556 New error handlers.
4b80f674
CY
11557 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11558 Obey Vx_select_enable_clipboard_manager. Catch errors in
11559 x_clipboard_manager_save (Bug#8779).
11560 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11561 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11562
99a33b77 115632011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11564
11565 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11566
99a33b77 115672011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11568
11569 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11570 in the current matrix if keep_current_p is non-zero.
11571
8264569d
EZ
115722011-06-04 Eli Zaretskii <eliz@gnu.org>
11573
11574 * bidi.c (bidi_level_of_next_char): Fix last change.
11575
57f97249
EZ
115762011-06-03 Eli Zaretskii <eliz@gnu.org>
11577
fec2107c 11578 Support bidi reordering of text covered by display properties.
57f97249 11579
fec2107c
EZ
11580 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11581 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11582 (bidi_cache_search, bidi_cache_iterator_state)
11583 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11584 (bidi_level_of_next_char, bidi_move_to_visually_next):
11585 Support character positions inside a run of characters covered by a
fec2107c
EZ
11586 display string.
11587 (bidi_paragraph_init, bidi_resolve_explicit_1)
11588 (bidi_level_of_next_char): Call bidi_fetch_char and
11589 bidi_fetch_char_advance instead of FETCH_CHAR and
11590 FETCH_CHAR_ADVANCE.
11591 (bidi_init_it): Initialize new members.
11592 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11593 definitions.
11594 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11595 instead of using explicit *_CHAR codes.
d6d100dd
SM
11596 (bidi_resolve_explicit, bidi_resolve_weak):
11597 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11598 bidirectional text is supported only in multibyte buffers.
11599 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11600 it to initialize the frame_window_p member of struct bidi_it.
11601 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11602 (bidi_resolve_explicit, bidi_resolve_weak)
11603 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11604 bidi_it->nchars is non-positive.
11605 (bidi_level_of_next_char): Don't try to lookup the cache for the
11606 next/previous character if nothing is cached there yet, or if we
11607 were just reseat()'ed to a new position.
c40e2fb2 11608
0e14fe90
EZ
11609 * xdisp.c (set_cursor_from_row): Set start and stop points
11610 according to the row's direction when priming the loop that looks
11611 for the glyph on which to display cursor.
11612 (single_display_spec_intangible_p): Function deleted.
11613 (display_prop_intangible_p): Reimplement to call
11614 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11615 Accept 3 additional arguments needed by handle_display_spec.
11616 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11617 values: lists, `(when COND...)' forms, etc.
11618 (single_display_spec_string_p): Support property values that are
11619 lists with the argument STRING its top-level element.
11620 (display_prop_string_p): Fix the condition for processing a
11621 property that is a list to be consistent with handle_display_spec.
fec2107c 11622 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11623 last portion of handle_display_prop.
11624 (compute_display_string_pos): Accept additional argument
11625 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11626 value of a `display' property is a "replacing spec".
11627 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11628 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11629 the display property, but just return a value indicating whether
11630 the display property will replace the characters it covers.
11631 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11632 frame_window_p members of struct bidi_it.
d6d100dd
SM
11633 (compute_display_string_pos, compute_display_string_end):
11634 New functions.
fec2107c
EZ
11635 (push_it): Accept second argument POSITION, where pop_it should
11636 jump to continue iteration.
11637 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11638
fec2107c
EZ
11639 * keyboard.c (adjust_point_for_property): Adjust the call to
11640 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11641
11642 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11643 (bidi_init_it): Update prototypes.
11644 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11645 (compute_display_string_pos, compute_display_string_end):
11646 Declare prototypes.
fec2107c
EZ
11647 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11648 EMACS_INT.
fc6f18ce 11649
40087514 116502011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11651
57f53182
PE
11652 Malloc failure behavior now depends on size of allocation.
11653 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11654 * lisp.h: Change signatures accordingly.
11655 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11656 All callers changed. (Bug#8762)
11657
11658 * gnutls.c: Use Emacs's memory allocators.
11659 Without this change, the gnutls library would invoke malloc etc.
11660 directly, which causes problems on non-SYNC_INPUT hosts, and which
11661 runs afoul of improving memory_full behavior. (Bug#8761)
11662 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11663 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11664 xfree instead of the default malloc, realloc, free.
11665 (Fgnutls_boot): No need to check for memory allocation failure,
11666 since xmalloc does that for us.
11667
ac32cd99 11668 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11669 * category.c (hash_get_category_set):
11670 * ccl.c (ccl_driver):
11671 * charset.c (Fdefine_charset_internal):
11672 * charset.h (struct charset.hash_index):
11673 * composite.c (get_composition_id, gstring_lookup_cache)
11674 (composition_gstring_put_cache):
11675 * composite.h (struct composition.hash_index):
11676 * dispextern.h (struct image.hash):
11677 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11678 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11679 (hashfn_equal, hashfn_user_defined, make_hash_table)
11680 (maybe_resize_hash_table, hash_lookup, hash_put)
11681 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11682 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11683 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11684 * image.c (make_image, search_image_cache, lookup_image)
11685 (xpm_put_color_table_h):
11686 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11687 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11688 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11689 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11690 * alloc.c (allocate_vectorlike):
11691 Check for overflow in vector size calculations.
11692 * ccl.c (ccl_driver):
11693 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11694 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11695 need to be updated by these changes.
40087514
PE
11696 * fns.c (make_hash_table, maybe_resize_hash_table):
11697 Check for integer overflow with large hash tables.
0de4bb68
PE
11698 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11699 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11700 (SXHASH_REDUCE): New macro.
11701 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11702 Use it instead of discarding useful hash info with large hash values.
11703 (sxhash_float): New function.
11704 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11705 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11706 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11707 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11708 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11709 Adjust signatures to match updated version of code.
11710 (consing_since_gc): Now EMACS_INT, since a single hash table can
11711 use more than INT_MAX bytes.
11712
698d32e2
DN
117132011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11714
11715 Make it possible to build with GCC-4.6+ -O2 -flto.
11716
11717 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11718
fd6fa53f
SM
117192011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11720
11721 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11722 Call minibuffer-inactive-mode.
11723
864db017
JB
117242011-05-31 Juanma Barranquero <lekktu@gmail.com>
11725
11726 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11727 Update dependencies.
11728
2ad0baf4
DN
117292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11730
11731 * data.c (init_data): Remove code for UTS, this system is not
11732 supported anymore.
11733
4fcc2638
DN
117342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11735
11736 Don't force ./temacs to start in terminal mode.
11737
11738 * frame.c (make_initial_frame): Initialize faces in all cases, not
11739 only when CANNOT_DUMP is defined.
11740 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11741
c56e0fd5
DN
117422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11743
11744 * dispnew.c (add_window_display_history): Use const for the string
11745 pointer. Remove declaration, not needed.
11746
333d54da 117472011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11748
55d4c1b2 11749 Use 'inline', not 'INLINE'.
333d54da 11750 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11751 * alloc.c, fontset.c (INLINE): Remove.
11752 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11753 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11754 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11755 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11756 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11757
738db178
DN
117582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11759
11760 Make it possible to run ./temacs.
11761
11762 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11763 syms_of_callproc does the same thing. Remove test for
11764 "initialized", do it in the caller.
11765 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11766
620c53a6
SM
117672011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11768
11769 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11770 (read_minibuf): Use get_minibuffer.
11771 (syms_of_minibuf): Use DEFSYM.
11772 (Qmetadata): New var.
11773 * data.c (Qbuffer): Don't make it static.
11774 (syms_of_data): Use DEFSYM.
11775
e003a292
PE
117762011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11777
11778 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11779 (CCL_CODE_MIN): New macro.
11780
ed008a6d
PE
117812011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11782
3687c2ef
PE
11783 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11784
ed008a6d
PE
11785 * eval.c (Qdebug): Now static.
11786 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11787 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11788 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11789
d66c4c7c
CY
117902011-05-29 Chong Yidong <cyd@stupidchicken.com>
11791
11792 * image.c: Various fixes to ImageMagick code comments.
11793 (Fimagemagick_types): Doc fix.
11794
5fbc2025
PE
117952011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11796
0196f88a
PE
11797 Minor fixes prompted by GCC 4.6.0 warnings.
11798
11799 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11800
5fbc2025
PE
11801 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11802 (x_clipboard_manager_save_all): Move extern decl to ...
11803 * xterm.h: ... here, so that it can be checked for consistency.
11804
1dd3c2d9
CY
118052011-05-29 Chong Yidong <cyd@stupidchicken.com>
11806
11807 * xselect.c (x_clipboard_manager_save_frame)
11808 (x_clipboard_manager_save_all): New functions.
11809 (Fx_clipboard_manager_save): Lisp function deleted.
11810
11811 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11812 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11813
11814 * xterm.h: Update prototype.
11815
5ba6571d
WX
118162011-05-28 William Xu <william.xwl@gmail.com>
11817
11818 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11819 exiting (Bug#8239).
11820
3eaff834
JM
118212011-05-28 Jim Meyering <meyering@redhat.com>
11822
e1900994 11823 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11824 * fns.c (to_uchar): Define.
11825 (crypto_hash_function): Use it to convert some newly-signed
11826 variables to unsigned, to avoid sign-extension bugs. For example,
11827 without this change, (md5 "truc") would evaluate to
11828 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11829 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11830 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11831
0f6990a7
PE
118322011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11833
11834 Integer overflow fixes.
c8a9ca5a 11835
08686060
PE
11836 * dbusbind.c: Serial number integer overflow fixes.
11837 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11838 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11839 to hold a serial number that is too large for a fixnum.
11840 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11841 Check for serial numbers out of range. Decode any serial number
59568bf0 11842 that was so large that it became a float. (Bug#8722)
08686060 11843
2d1fc3c7
PE
11844 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11845 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11846 Use XFASTINT rather than XUINT when numbers are nonnegative.
11847 (xd_append_arg, Fdbus_method_return_internal):
11848 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11849 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11850 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11851 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11852 (Bug#8722)
2d1fc3c7 11853
c8a9ca5a
PE
11854 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11855
519e1d69
PE
11856 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11857
6df6ae42 11858 ccl: Add integer overflow checks.
30569699
PE
11859 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11860 (IN_INT_RANGE): New macros.
11861 (ccl_driver): Use them to check for integer overflow when
11862 decoding a CCL program. Many of the new checks are whether XINT (x)
11863 fits in int; it doesn't always, on 64-bit hosts. The new version
11864 doesn't catch all possible integer overflows, but it's an
847044ea 11865 improvement. (Bug#8719)
30569699 11866
c11285dc
PE
11867 * alloc.c (make_event_array): Use XINT, not XUINT.
11868 There's no need for unsigned here.
11869
fdccd48e
PE
11870 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11871 This follows up to the 2011-05-06 change that substituted uintptr_t
11872 for EMACS_INT. This case wasn't caught back then.
11873
37910ab2
PE
11874 Rework Fformat to avoid integer overflow issues.
11875 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11876 now (part of C89). Include <verify.h>.
11877 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11878 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11879 (Fformat): Avoid the prepass trying to compute sizes; it was only
11880 approximate and thus did not catch overflow reliably. Instead, walk
11881 through the format just once, formatting and computing sizes as we go,
11882 checking for integer overflow at every step, and allocating a larger
11883 buffer as needed. Keep track separately whether the format is
11884 multibyte. Keep only the most-recently calculated precision, rather
11885 than them all. Record whether each argument has been converted to
11886 string. Use EMACS_INT, not int, for byte and char and arg counts.
11887 Support field widths and precisions larger than INT_MAX. Avoid
11888 sprintf's undefined behavior with conversion specifications such as %#d
11889 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11890 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11891 formatting out-of-range floating point numbers with int
9173deec 11892 formats. (Bug#8668)
37910ab2 11893
2e6578fb
PE
11894 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11895
0ae6bdee
PE
11896 * data.c: Avoid integer truncation in expressions involving floats.
11897 * data.c: Include <intprops.h>.
11898 (arith_driver): When there's an integer overflow in an expression
11899 involving floating point, convert the integers to floating point
11900 so that the resulting value does not suffer from catastrophic
11901 integer truncation. For example, on a 64-bit host (* 4
11902 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11903 Do not rely on undefined behavior after integer overflow.
11904
de883a70
PE
11905 merge count_size_as_multibyte, parse_str_to_multibyte
11906 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11907 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11908 Check for integer overflow.
11909 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11910 since it's now a duplicate of the other. This is more of
11911 a character than a buffer op, so better that it's in character.c.
11912 * fns.c, print.c: Adjust to above changes.
11913
2ff916cb
PE
119142011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11915
11916 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11917
f1b54466
PE
119182011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11919
fb1ac845
PE
11920 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11921 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11922 (x_clipboard_manager_save): Now static.
11923 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11924
f1b54466
PE
11925 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11926 (crypto_hash_function): Now static.
11927 Fix pointer signedness problems. Avoid unnecessary initializations.
11928
a9f737ee
CY
119292011-05-27 Chong Yidong <cyd@stupidchicken.com>
11930
11931 * termhooks.h (Vselection_alist): Make it terminal-local.
11932
11933 * terminal.c (create_terminal): Initialize it.
11934
11935 * xselect.c: Support for clipboard managers.
11936 (Vselection_alist): Move to termhooks.h as terminal-local var.
11937 (LOCAL_SELECTION): New macro.
11938 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11939 (symbol_to_x_atom): Remove gratuitous arg.
11940 (x_handle_selection_request, lisp_data_to_selection_data)
11941 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11942 (x_own_selection, x_get_local_selection, x_convert_selection):
11943 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11944 (some_frame_on_display): Delete unused function.
11945 (Fx_own_selection_internal, Fx_get_selection_internal)
11946 (Fx_disown_selection_internal, Fx_selection_owner_p)
11947 (Fx_selection_exists_p): New optional frame arg.
11948 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11949 (x_handle_selection_clear): Don't treat other terminals with the
11950 same keyboard specially. Use the terminal-local Vselection_alist.
11951 (x_clear_frame_selections): Use Frun_hook_with_args.
11952
11953 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11954
11955 * xterm.h: Add support for those atoms.
11956
e067f0c1
CY
119572011-05-26 Chong Yidong <cyd@stupidchicken.com>
11958
11959 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11960 (converted_selections, conversion_fail_tag): New global variables.
11961 (x_selection_request_lisp_error): Free the above.
11962 (x_get_local_selection): Remove unnecessary code.
11963 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11964 of converted selections stored in converted_selections.
11965 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11966 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11967 (x_convert_selection): New function.
11968 (x_handle_selection_event): Simplify.
11969 (x_get_foreign_selection): Don't ignore incoming requests while
11970 waiting for an answer; this will fail when we implement
11971 SAVE_TARGETS, and seems unnecessary anyway.
11972 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11973 (Vx_sent_selection_functions): Doc fix.
11974
0f4aebc0
LL
119752011-05-26 Leo Liu <sdl.web@gmail.com>
11976
11977 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11978
e61124cd
YM
119792011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11980
11981 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11982
11983 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11984 for fringe update if it has periodic bitmap.
ac389d0c 11985 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11986 and fringe_bitmap_periodic_p.
11987
11988 * fringe.c (get_fringe_bitmap_data): New function.
11989 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11990 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11991 row. Mark glyph row for fringe update if periodicity changed.
11992
11993 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11994 for fringe update unless it has periodic bitmap.
11995
f16d9837
KH
119962011-05-25 Kenichi Handa <handa@m17n.org>
11997
11998 * xdisp.c (get_next_display_element): Set correct it->face_id for
11999 a static composition.
12000
e1b90ef6
LL
120012011-05-24 Leo Liu <sdl.web@gmail.com>
12002
12003 * deps.mk (fns.o):
12004 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
12005
12006 * fns.c (crypto_hash_function, Fsha1): New function.
12007 (Fmd5): Use crypto_hash_function.
12008 (syms_of_fns): Add Ssha1.
12009
7400048f
PE
120102011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12011
12012 * gnutls.c: Remove unused macros.
12013 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12014 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12015 Remove macros that are defined and never used.
12016 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12017
abb71cf4
CY
120182011-05-22 Chong Yidong <cyd@stupidchicken.com>
12019
12020 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12021 (Fx_get_selection_internal): Minor cleanup.
12022 (Fx_own_selection_internal): Rename arguments for consistency with
12023 select.el.
12024
6307db39
PE
120252011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12026
12027 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12028
f3d4e0a4
CY
120292011-05-22 Chong Yidong <cyd@stupidchicken.com>
12030
12031 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12032
4d8ade89
YM
120332011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12034
12035 * dispnew.c (scrolling_window): Don't exclude the case that the
12036 last enabled row in the desired matrix touches the bottom boundary.
12037
32078c8d
GM
120382011-05-21 Glenn Morris <rgm@gnu.org>
12039
12040 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
12041 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12042 and add some more files.
32078c8d 12043
7285dc67
EZ
120442011-05-20 Eli Zaretskii <eliz@gnu.org>
12045
12046 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12047 report_file_error introduced by the change from 2011-05-07.
12048
89d1bd22
PE
120492011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12050
12051 * systime.h (Time): Define only if emacs is defined.
12052 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12053 where the include path doesn't have X11/X.h by default. See
12054 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12055
cd394be1 120562011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12057
12058 * composite.c (find_automatic_composition): Fix previous change.
12059
b9704ad9
GM
120602011-05-20 Glenn Morris <rgm@gnu.org>
12061
12062 * lisp.mk: New file, split from Makefile.in.
12063 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12064 (shortlisp): Remove.
12065 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12066
4a720484
GM
120672011-05-19 Glenn Morris <rgm@gnu.org>
12068
12069 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12070 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12071 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12072 (lisp): Set the order to that of loadup.el.
12073 (shortlisp): Make it a copy of $lisp.
12074 (SOME_MACHINE_LISP): Remove.
12075 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12076 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12077
a28d4396
KH
120782011-05-18 Kenichi Handa <handa@m17n.org>
12079
12080 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12081 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12082 (find_automatic_composition): Mostly rewrite for efficiency.
12083
a2b1fa8e
JB
120842011-05-18 Juanma Barranquero <lekktu@gmail.com>
12085
12086 * makefile.w32-in: Update dependencies.
12087
8e1f5610
CS
120882011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12089
12090 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12091 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12092
7025ee00 120932011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12094
cdfa6eab
PE
12095 Fix some integer overflow issues, such as string length overflow.
12096
06d6db33
PE
12097 * insdel.c (count_size_as_multibyte): Check for string overflow.
12098
2b4560a8
PE
12099 * character.c (lisp_string_width): Check for string overflow.
12100 Use EMACS_INT, not int, for string indexes and lengths; in
12101 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12102 the resulting string length overflows an EMACS_INT; instead,
12103 report a string overflow if no precision given. When checking for
12104 precision exhaustion, use a check that cannot possibly have
12105 integer overflow. (Bug#8675)
12106 * character.h (lisp_string_width): Adjust to new signature.
12107
cb93f9be
PE
12108 * alloc.c (string_overflow): New function.
12109 (Fmake_string): Use it. This doesn't change behavior, but saves
12110 a few bytes and will simplify future changes.
12111 * character.c (string_escape_byte8): Likewise.
12112 * lisp.h (string_overflow): New decl.
12113
1a1f3366
PE
12114 Fixups, following up to the user-interface timestamp change.
12115 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12116 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12117 * msdos.c (mouse_get_pos): Likewise.
12118 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12119 * w32gui.h (Time): Define by including "systime.h" rather than by
12120 declaring it ourselves. (Bug#8664)
12121
d4e3e4d3
PE
12122 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12123 * image.c (clear_image_cache): Likewise.
12124
f6a24d19
PE
12125 * term.c (term_mouse_position): Don't assume time_t wraparound.
12126
08dc5ae6
PE
12127 Be more systematic about user-interface timestamps.
12128 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12129 and sometimes 'EMACS_UINT', to represent these timestamps.
12130 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12131 This makes the code easier to follow, and makes it easier to catch
12132 integer overflow bugs such as Bug#8664.
12133 * frame.c (Fmouse_position, Fmouse_pixel_position):
12134 Use Time, not unsigned long, for user-interface timestamps.
12135 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12136 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12137 * keyboard.h (last_event_timestamp): Likewise.
12138 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12139 * menu.h (xmenu_show): Likewise.
12140 * term.c (term_mouse_position): Likewise.
12141 * termhooks.h (struct input_event.timestamp): Likewise.
12142 (struct terminal.mouse_position_hook): Likewise.
12143 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12144 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12145 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12146 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12147 what it was before.
12148 * menu.h, termhooks.h: Include "systime.h", for Time.
12149
8e55734a
PE
12150 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12151 Don't assume that the difference between two unsigned long values
12152 can fit into an integer. At this point, we know button_down_time
12153 <= event->timestamp, so the difference must be nonnegative, so
12154 there's no need to cast the result if double-click-time is
12155 nonnegative, as it should be; check that it's nonnegative, just in
12156 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12157 apart (about 25 days). (Bug#8664)
8e55734a 12158
841f1b75 12159 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12160 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12161
3e26f69c
PE
12162 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12163 that always fit in int. Use a sentinel instead of a counter, to
12164 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12165 * frame.h (struct frame): Use int for menu_bar_items_used
12166 instead of EMACS_INT, since it always fits in int.
3e26f69c 12167
5cc152c0
PE
12168 * menu.c (grow_menu_items): Check for int overflow.
12169
d89eb65e
PE
12170 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12171
5235bd3e
PE
12172 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12173 Before, the code was not consistent. These values cannot exceed
12174 2**31 - 1 so there's no need to make them unsigned.
12175 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12176 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12177 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12178 as modifiers.
12179 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12180
bc827e23
PE
12181 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12182 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12183 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12184 presumably because the widths might not match.
12185
78eb494e
PE
12186 * window.c (size_window): Avoid needless test at loop start.
12187
04f2d78b
CB
121882011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12189
12190 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12191
d2fc7e3d 121922011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12193
12194 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12195
d2fc7e3d 121962011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12197
12198 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12199 `width' to `bar_area_x' and `bar_area_width', respectively.
12200 (x_scroll_run): Take account of fringe background extension.
12201
04f2d78b
CB
12202 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12203 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12204 `bar_area_width', respectively.
12205 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12206 background extension.
12207
79b70037
GM
122082011-05-10 Jim Meyering <meyering@redhat.com>
12209
12210 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12211
2f142cc5
JB
122122011-05-10 Juanma Barranquero <lekktu@gmail.com>
12213
12214 * image.c (Finit_image_library): Return t for built-in image types,
12215 like pbm and xbm. (Bug#8640)
12216
57679c86
AS
122172011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12218
12219 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12220
888c9e86
EZ
122212011-05-07 Eli Zaretskii <eliz@gnu.org>
12222
b0512a1d
EZ
12223 * w32console.c (Fset_screen_color): Doc fix.
12224 (Fget_screen_color): New function.
12225 (syms_of_ntterm): Defsubr it.
12226
7285dc67
EZ
12227 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12228 unlink the temporary file if Fcall_process didn't create it in the
12229 first place.
12230 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12231 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12232 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12233 cue to call_process_cleanup not to close that handle.
12234
4d3fcc8e
BK
122352011-05-07 Ben Key <bkey76@gmail.com>
12236
12237 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12238 one of two shell specific rules, either bootstrap-temacs-CMD or
12239 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12240 to the previous implementation of the bootstrap-temacs rule.
12241 The bootstrap-temacs-CMD rule is similar to the previous
12242 implementation of the bootstrap-temacs rule except that it
12243 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12244 variable.
12245
12246 These changes, along with some changes to nt/configure.bat,
12247 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12248 earlier fix to add support for --cflags and --ldflags options
12249 that include quotes so that it works whether make uses cmd or
12250 sh as the shell.
12251
b4289b64
MA
122522011-05-06 Michael Albinus <michael.albinus@gmx.de>
12253
12254 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12255 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12256 is a constant.
12257 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12258 a string. Handle both cases.
12259 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12260 (Fdbus_register_method): Use Qinvalid_function.
12261
af4c0e28
JB
122622011-05-06 Juanma Barranquero <lekktu@gmail.com>
12263
12264 * makefile.w32-in: Update dependencies.
12265 (LISP_H): Add inttypes.h and stdin.h.
12266 (PROCESS_H): Add unistd.h.
12267
c51453d9
EZ
122682011-05-06 Eli Zaretskii <eliz@gnu.org>
12269
12270 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12271 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12272
8ff0ac3c 122732011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12274
4c4b566b
PE
12275 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12276
aab2b9b5
PE
12277 * term.c (vfatal): Remove stray call to va_end.
12278 It's not needed and the C Standard doesn't allow it here anyway.
12279
c378da0b
PE
12280 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12281 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12282
288b08c7
PE
12283 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12284 bytes.
12285
e3601888
PE
12286 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12287
db6c0e74
PE
12288 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12289
dd5963ea
PE
12290 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12291
88c9450f
PE
12292 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12293
2f9442b8
PE
12294 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12295
c032b5f8
PE
12296 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12297 * charset.c (Fdefine_charset_internal): Don't initialize
12298 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12299 32-bit int (Bug#8600).
a108c10b
PE
12300
12301 * lread.c (read_integer): Be more consistent with string-to-number.
12302 Use string_to_number to do the actual conversion; this avoids
12303 rounding errors and fixes some other screwups. Without this fix,
12304 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12305 (digit_to_number): Move earlier, for benefit of read_integer.
12306 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12307 not a digit in any supported base. (Bug#8602)
a108c10b 12308
ad5f9eea
PE
12309 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12310
aec1708a
PE
12311 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12312 to match comment at start of function. This also removes a
12313 GCC warning about overflow in a 32+64-bit port.
12314
47be4ab5
PE
12315 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12316
371cac43
PE
12317 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12318 Reported by Stefan Monnier in
12319 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12320 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12321 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12322
d01a7826
PE
12323 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12324 (EMACS_UINTPTR): Likewise, with uintptr_t.
12325
7fd47d5c
PE
12326 * lisp.h: Prefer 64-bit EMACS_INT if available.
12327 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12328 on 32-bit hosts that have 64-bit int, so that they can access
12329 large files.
122b0c86
PE
12330 However, temporarily disable this change unless the temporary
12331 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12332
8727937b
PE
12333 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12334
8ac068ac
PE
12335 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12336 This removes an assumption that EMACS_INT and long are the same
12337 width as pointers. The assumption is true for Emacs porting targets
12338 now, but we want to make other targets possible.
12339 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12340 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12341 In the rest of the code, change types of integers that hold casted
12342 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12343 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12344 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12345 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12346 No need to cast type when ORing.
12347 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12348 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12349 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12350 assume EMACS_INT is the same width as char *.
12351 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12352 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12353 Remove no-longer-needed casts.
12354 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12355 (xg_tool_bar_help_callback, xg_make_tool_item):
12356 Use EMACS_INTPTR to hold an integer
12357 that will be cast to void *; this can avoid a GCC warning
12358 if EMACS_INT is not the same width as void *.
12359 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12360 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12361 (current_message_1, set_message_1):
12362 Use a local to convert to proper width without a cast.
12363 * xmenu.c (dialog_selection_callback): Likewise.
12364
ede49d71
PE
12365 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12366 Also, don't assume VALBITS / RAND_BITS is less than 5,
12367 and don't rely on undefined behavior when shifting a 1 left into
12368 the sign bit.
12369 * lisp.h (get_random): Change signature to match.
12370
2f30ecd0
PE
12371 * lread.c (hash_string): Use size_t, not int, for hash computation.
12372 Normally we prefer signed values; but hashing is special, because
12373 it's better to use unsigned division on hash table sizes so that
12374 the remainder is nonnegative. Also, size_t is the natural width
12375 for hashing into memory. The previous code used 'int', which doesn't
12376 retain enough info to hash well into very large tables.
12377 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12378
2a866e7b
PE
12379 * dbusbind.c: Don't possibly lose pointer info when converting.
12380 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12381 Use XPNTR rather than XHASH, so that the high-order bits of
12382 the pointer aren't lost when converting through void *.
12383
51639eac
PE
12384 * eval.c (Fautoload): Don't double-shift a pointer.
12385
92394119
PE
12386 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12387
dbdb9a7c
JB
123882011-05-06 Juanma Barranquero <lekktu@gmail.com>
12389
12390 * gnutls.c (DEF_GNUTLS_FN):
12391 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12392
db7a0b4f
AS
123932011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12394
12395 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12396 marker. (Bug#8610)
12397
cd394be1 123982011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12399
12400 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12401 New version that can reserve upto 2GB of heap space.
12402
f7ff1b0f 124032011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12404
12405 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12406
639c109b
TZ
124072011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12408
12409 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12410 `gnutls_certificate_set_x509_key_file'.
12411
d2127135
JB
124122011-05-05 Juanma Barranquero <lekktu@gmail.com>
12413
12414 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12415 Update dependencies.
12416
e968f4f3
JB
124172011-05-04 Juanma Barranquero <lekktu@gmail.com>
12418
12419 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12420 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12421 Remove unused parameter `fildes'.
12422 * process.c (read_process_output, send_process): Don't pass it.
12423
84d358f0
JB
124242011-05-04 Juanma Barranquero <lekktu@gmail.com>
12425
12426 Fix previous change: the library cache is defined in w32.c.
12427 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12428 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12429
0898ca10
JB
124302011-05-04 Juanma Barranquero <lekktu@gmail.com>
12431
12432 Implement dynamic loading of GnuTLS on Windows.
12433
12434 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12435 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12436 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12437 Declare.
12438
12439 * gnutls.c (Qgnutls_dll): Define.
12440 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12441 (gnutls_*): Declare function pointers.
12442 (init_gnutls_functions): New function to initialize function pointers.
12443 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12444 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12445 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12446 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12447 (emacs_gnutls_write, emacs_gnutls_read)
12448 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12449 (Fgnutls_available_p): New function.
12450 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12451 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12452 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12453
12454 * image.c: Include w32.h.
12455 (Vimage_type_cache): Delete.
12456 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12457 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12458 (w32_delayed_load): Move to w32.c.
12459
12460 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12461
12462 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12463 (w32_delayed_load): Move from image.c. When loading a library, record
12464 its filename in the :loaded-from property of the library id.
12465 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12466 Initialize and staticpro them.
12467 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12468
12469 * process.c: Include lisp.h before w32.h, not after.
12470 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12471 instead of gnutls_record_check_pending.
12472
12473 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12474
ff4de4aa
TZ
124752011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12476
12477 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12478 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12479 as passed in.
12480
abe95abb
JD
124812011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12482
12483 * xterm.c (x_set_frame_alpha): Do not set property on anything
12484 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12485
e16e55d4
JB
124862011-05-02 Juanma Barranquero <lekktu@gmail.com>
12487
12488 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12489
bafcf6a5
JB
124902011-05-02 Juanma Barranquero <lekktu@gmail.com>
12491
12492 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12493 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12494 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12495 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12496 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12497 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12498 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12499 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12500 (Qgnutls_bootprop_callbacks_verify): Make static.
12501
e7a6747f
AS
125022011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12503
19ed11ba
AS
12504 * callproc.c: Indentation fixup.
12505
e7a6747f 12506 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12507 (wait_for_termination, interruptible_wait_for_termination):
12508 Move after wait_for_termination_1.
e7a6747f 12509
1ef14cb4
LMI
125102011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12511
12512 * sysdep.c (interruptible_wait_for_termination): New function
12513 which is like wait_for_termination, but allows keyboard
12514 interruptions.
12515
12516 * callproc.c (Fcall_process): Add (:file "file") as an option for
12517 the STDOUT buffer.
12518 (Fcall_process_region): Ditto.
12519
330d880c
EZ
125202011-04-30 Eli Zaretskii <eliz@gnu.org>
12521
8db90b73
EZ
12522 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12523 rather than `XVECTOR (FOO)->size'.
12524
330d880c
EZ
12525 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12526 inttypes.h, as a gnulib replacement is used if it not available in
12527 system headers.
12528
15cbd324
EZ
125292011-04-21 Eli Zaretskii <eliz@gnu.org>
12530
12531 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12532 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12533 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12534
12535 * coding.c (coding_alloc_by_realloc): Error out if destination
12536 will grow beyond MOST_POSITIVE_FIXNUM.
12537 (decode_coding_emacs_mule): Abort if there isn't enough place in
12538 charbuf for the composition carryover bytes. Reserve an extra
12539 space for up to 2 characters produced in a loop.
12540 (decode_coding_iso_2022): Abort if there isn't enough place in
12541 charbuf for the composition carryover bytes.
12542
125432011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12544
ae940cca
EZ
12545 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12546 aborting when %lld or %lll format is passed.
12547 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12548 %llo or %llx format is passed. (Bug#8545)
12549
03ab8921
EZ
12550 * window.c (window_scroll_line_based): Use a marker instead of
12551 simple variables to record original value of point. (Bug#7952)
12552
afda1437
EZ
12553 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12554 produced by %s or %c overflows available buffer space. (Bug#8545)
12555
f76dee0c
PE
125562011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12557
12558 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12559 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12560
fdc5744d
JB
125612011-04-28 Juanma Barranquero <lekktu@gmail.com>
12562
12563 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12564
638f053a
JB
125652011-04-28 Juanma Barranquero <lekktu@gmail.com>
12566
12567 * keyboard.c (Qdelayed_warnings_hook): Define.
12568 (command_loop_1): Run `delayed-warnings-hook'
12569 if Vdelayed_warnings_list is non-nil.
12570 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12571 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12572
d178f871
EZ
125732011-04-28 Eli Zaretskii <eliz@gnu.org>
12574
12575 * doprnt.c (doprnt): Don't return value smaller than the buffer
12576 size if the message was truncated. (Bug#8545).
12577
b124fd93
JB
125782011-04-28 Juanma Barranquero <lekktu@gmail.com>
12579
12580 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12581 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12582
e810457d
PE
125832011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12584
12585 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12586
ea51cceb
JB
125872011-04-27 Juanma Barranquero <lekktu@gmail.com>
12588
12589 * makefile.w32-in: Update dependencies.
12590
94dcfacf
EZ
125912011-04-27 Eli Zaretskii <eliz@gnu.org>
12592
12593 Improve `doprnt' and its usage. (Bug#8545)
12594 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12595 `format_end'. Remove support for %l as a conversion specifier.
12596 Don't use xrealloc. Improve diagnostics when the %l size modifier
12597 is used. Update the commentary.
12598
12599 * eval.c (verror): Simplify calculation of size_t.
12600
12601 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12602 messages.
12603
f61f41d7
PE
126042011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12605
12606 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12607 change.
12608
96fb4434
PE
126092011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12610
12611 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12612 This makes this file independent of the recent pseudovector change.
12613
671875da 126142011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12615
69e9b5a3
PE
12616 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12617
b5f869a7 12618 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12619 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12620 Remove unused local.
c8926152 12621 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12622
841a1577 12623 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12624 GCC 4.6.0 optimizes based on type-based alias analysis.
12625 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12626 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12627 != &v->size, and therefore "v->size = 1; b->size = 2; return
12628 v->size;" must therefore return 1. This assumption is incorrect
12629 for Emacs, since it type-puns struct Lisp_Vector * with many other
12630 types. To fix this problem, this patch adds a new type struct
f904488f 12631 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12632 and pseudovectors, and helps optimizing compilers not get fooled
12633 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12634 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12635 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12636 the size member.
eab3844f
PE
12637 (XSETPVECTYPE): Rewrite in terms of new macro.
12638 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12639 This is a bit clearer, and further avoids the possibility of
12640 undesirable aliasing.
12641 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12642 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12643 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12644 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12645 (ASIZE): Now uses header.size rather than size.
12646 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12647 to avoid the hassle of writing XVECTOR (foo)->header.size.
12648 (struct vectorlike_header): New type.
eab3844f
PE
12649 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12650 object, to help avoid aliasing.
12651 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12652 (SUBRP): Likewise, since Lisp_Subr is a special case.
12653 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12654 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12655 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12656 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12657 changed to be "header.size" and "header.next".
12658 * buffer.h (struct buffer): Likewise.
12659 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12660 * frame.h (struct frame): Likewise.
12661 * process.h (struct Lisp_Process): Likewise.
12662 * termhooks.h (struct terminal): Likewise.
12663 * window.c (struct save_window_data, struct saved_window): Likewise.
12664 * window.h (struct window): Likewise.
12665 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12666 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12667 * buffer.c (init_buffer_once): Likewise.
12668 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12669 special case.
12670 * process.c (Fformat_network_address): Use local var for size,
12671 for brevity.
12672
0df1eac5
PE
12673 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12674
847ab9d1 12675 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12676 * data.c (atof): Remove decl; no longer used or needed.
12677 (digit_to_number): Move to lread.c.
12678 (Fstring_to_number): Use new string_to_number function, to be
12679 consistent with how the Lisp reader treats infinities and NaNs.
12680 Do not assume that floating-point numbers represent EMACS_INT
12681 without losing information; this is not true on most 64-bit hosts.
12682 Avoid double-rounding errors, by insisting on integers when
12683 parsing non-base-10 numbers, as the documentation specifies.
12684 * lisp.h (string_to_number): New decl, replacing ...
12685 (isfloat_string): Remove.
bc0a5c13 12686 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12687 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12688 appears to have been a coding error. Similarly, do not accept
12689 strings like +-1e0 as floating point numbers. Do not report
12690 overflow for integer overflows unless the base is not 10 which
12691 means we have no simple and reliable way to continue.
12692 Break out the floating-point parsing into a new
12693 function string_to_number, so that Fstring_to_number parses
12694 floating point numbers consistently with the Lisp reader.
04f2d78b 12695 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12696 (E_CHAR, EXP_INT): Remove, replacing with ...
12697 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12698 (string_to_number): New function, replacing isfloat_string.
12699 This function checks for valid syntax and produces the resulting
12700 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12701 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12702 so that overflow for non-base-10 numbers is reported only when
12703 there's no portable and simple way to convert to floating point.
452f4150 12704
67769ffc
PE
12705 * textprop.c (set_text_properties_1): Rewrite for clarity,
12706 and to avoid GCC warning about integer overflow.
12707
c20db43f
PE
12708 * intervals.h (struct interval): Use EMACS_INT for members
12709 where EMACS_UINT might cause problems. See
12710 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12711 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12712 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12713 All uses changed.
37aa2f85
PE
12714 (offset_intervals): Tell GCC not to worry about length overflow
12715 when negating a negative length.
c20db43f 12716
2538aa2f
PE
12717 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12718 (overrun_check_free): Likewise.
12719
f2d3008d
PE
12720 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12721 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12722 word size.
12723
ec8df744
PE
12724 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12725 (gnutls_make_error): Rename local to avoid shadowing.
12726 (gnutls_emacs_global_deinit): ifdef out; not used.
12727 (Fgnutls_boot): Use const for pointer to readonly storage.
12728 Comment out unused local. Fix pointer signedness problems.
12729
640ee02d
PE
12730 * lread.c (openp): Don't stuff size_t into an 'int'.
12731 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12732 about possible signed overflow.
12733
6048fb2a
PE
12734 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12735 (GDK_KEY_g): Don't define if already defined.
12736 (xg_prepare_tooltip): Avoid pointer signedness problem.
12737 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12738
fa3c87e1
PE
12739 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12740 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12741
2172544b
PE
12742 * xfns.c (Fx_window_property): Simplify a bit,
12743 to make a bit faster and to avoid GCC 4.6.0 warning.
12744 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12745
9b821a21
PE
12746 * fns.c (internal_equal): Don't assume size_t fits in int.
12747
3c616cfa
PE
12748 * alloc.c (compact_small_strings): Tighten assertion a little.
12749
c2982e87
PE
12750 Replace pEd with more-general pI, and fix some printf arg casts.
12751 * lisp.h (pI): New macro, generalizing old pEd macro to other
12752 conversion specifiers. For example, use "...%"pI"d..." rather
12753 than "...%"pEd"...".
12754 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12755 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12756 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12757 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12758 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12759 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12760 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12761 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12762 64-bit hosts.
12763 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12764 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12765 * print.c (safe_debug_print, print_object): Likewise.
12766 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12767 to int.
6f04d126
PE
12768 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12769 avoiding the 0 flag, which is not portable.
c2982e87
PE
12770 * process.c (Fmake_network_process): Use pI to avoid cast.
12771 * region-cache.c (pp_cache): Likewise.
12772 * xdisp.c (decode_mode_spec): Likewise.
12773 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12774 behavior on 64-bit hosts with printf arg.
6f04d126 12775 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12776 (x_stop_queuing_selection_requests): Likewise.
12777 (x_get_window_property): Don't truncate byte count to an 'int'
12778 when tracing.
0b432f21 12779
5e073ec7
PE
12780 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12781 here, since it parses constructs like leading '-' and spaces,
12782 which are not wanted; and it overflows with large numbers.
12783 Instead, simply match F[0-9]+, which is what is wanted anyway.
12784
36372bf9
PE
12785 * alloc.c: Remove unportable assumptions about struct layout.
12786 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12787 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12788 (allocate_vectorlike, make_pure_vector): Use the new macros,
12789 plus offsetof, to remove unportable assumptions about struct layout.
12790 These assumptions hold on all porting targets that I know of, but
12791 they are not guaranteed, they're easy to remove, and removing them
12792 makes further changes easier.
12793
0b432f21
PE
12794 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12795 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12796 (string_overrun_cookie): Now const. Use initializers that
12797 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12798 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12799 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12800 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12801 multiple of sizeof (EMACS_INT); it need not be, if
12802 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12803 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12804
895009e1
JB
128052011-04-26 Juanma Barranquero <lekktu@gmail.com>
12806
12807 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12808
6a7a1b0b
TZ
128092011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12810
12811 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12812 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12813 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12814
841a1577 128152011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12816
12817 * lisp.h (Qdebug): List symbol.
895009e1 12818 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12819 * keyboard.c (debug-on-event): New variable.
12820 (handle_user_signal): Break into debugger when debug-on-event
12821 matches the current signal symbol.
12822
f2d3ba6f
DN
128232011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12824
12825 * alloc.c (check_sblock, check_string_bytes)
12826 (check_string_free_list): Convert to standard C.
12827
42ce4c63
TZ
128282011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12829
12830 * w32.c (emacs_gnutls_push): Fix typo.
12831
825cd63c
EZ
128322011-04-25 Eli Zaretskii <eliz@gnu.org>
12833
fb11d64d
EZ
12834 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12835 "cast to pointer from integer of different size".
12836
825cd63c
EZ
12837 Improve doprnt and its use in verror. (Bug#8545)
12838 * doprnt.c (doprnt): Document the set of format control sequences
12839 supported by the function. Use SAFE_ALLOCA instead of always
12840 using `alloca'.
12841
12842 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12843 is one byte too soon. Don't use xrealloc; instead xfree and
12844 xmalloc anew.
12845
e061a11b
TZ
128462011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12847
12848 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12849 callbacks stage.
12850
12851 * gnutls.c: Renamed global_initialized to
12852 gnutls_global_initialized. Added internals for the
12853 :verify-hostname-error, :verify-error, and :verify-flags
12854 parameters of `gnutls-boot' and documented those parameters in the
12855 docstring. Start callback support.
9173deec
JB
12856 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12857 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12858 on error. Return error code.
e061a11b
TZ
12859 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12860 (emacs_gnutls_read): Likewise.
12861 (Fgnutls_boot): Return handshake error code.
12862 (emacs_gnutls_handle_error): New function.
12863 (wsaerror_to_errno): Likewise.
12864
12865 * w32.h (emacs_gnutls_pull): Add prototype.
12866 (emacs_gnutls_push): Likewise.
12867
12868 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12869 (emacs_gnutls_push): Likewise.
12870
128712011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12872
12873 * process.c (wait_reading_process_output): Check if GnuTLS
12874 buffered some data internally if no FDs are set for TLS
12875 connections.
12876
12877 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12878 (LIBS): Link to USER_LIBS.
12879 ($(BLD)/gnutls.$(0)): New target.
12880
fa6996bc
EZ
128812011-04-24 Eli Zaretskii <eliz@gnu.org>
12882
eb35682e
EZ
12883 * xdisp.c (handle_single_display_spec): Rename the
12884 display_replaced_before_p argument into display_replaced_p, to
12885 make it consistent with the commentary. Fix typos in the
12886 commentary.
12887
e2ad650c
EZ
12888 * textprop.c (syms_of_textprop): Remove dead code.
12889 (copy_text_properties): Delete obsolete commentary about an
12890 interface that was deleted long ago. Fix typos in the description
12891 of arguments.
12892
1b2de274
EZ
12893 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12894 to changes in oldXMenu/XMenu.h from 2011-04-16.
12895 <menu_help_message, prev_menu_help_message>: Constify.
12896 (IT_menu_make_room): menu->help_text is now `const char **';
12897 adjust.
12898
12899 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12900 to changes in oldXMenu/XMenu.h from 2011-04-16.
12901 (struct XMenu): Declare `help_text' `const char **'.
12902
12903 * xfaces.c <Qunspecified>: Make extern again.
12904
12905 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12906 required by POSIX.
1b2de274 12907
762b15be
EZ
12908 * doc.c (get_doc_string): Improve the format passed to `error'.
12909
12910 * doprnt.c (doprnt): Improve commentary.
12911
12912 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12913
12914 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12915 them with etags.
12916
f1052e5d
EZ
12917 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12918 changes in globals.h immediately force recompilation.
762b15be
EZ
12919 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12920 $(CURDIR)/s/ms-w32.h.
12921 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12922
fa6996bc
EZ
12923 * character.c (Fchar_direction): Function deleted.
12924 (syms_of_character): Don't defsubr it.
12925 <char-direction-table>: Deleted.
12926
e6c3da20
EZ
129272011-04-23 Eli Zaretskii <eliz@gnu.org>
12928
12929 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12930 * doprnt.c: Include limits.h.
12931 (SIZE_MAX): New macro.
04f2d78b
CB
12932 (doprnt): Return a size_t value. 2nd arg is now size_t.
12933 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12934 Improve overflow protection. Support `l' modifier for integer
12935 conversions. Support %l conversion. Don't assume an EMACS_INT
12936 argument for integer conversions and for %c.
12937
12938 * lisp.h (doprnt): Restore prototype.
12939
12940 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12941 $(SRC)/character.h.
12942
12943 * Makefile.in (base_obj): Add back doprnt.o.
12944
12945 * deps.mk (doprnt.o): Add back prerequisites.
12946 (callint.o): Depend on character.h.
12947
12948 * eval.c (internal_lisp_condition_case): Include the handler
12949 representation in the error message.
12950 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12951 when breaking from the loop.
12952
12953 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12954
12955 * callint.c (Fcall_interactively): When displaying error message
12956 about invalid control letter, pass the character's codepoint, not
12957 a pointer to its multibyte form. Improve display of the character
12958 in octal and display also its hex code.
12959
12960 * character.c (char_string): Use %x to display the (unsigned)
12961 codepoint of an invalid character, to avoid displaying a bogus
12962 negative value.
12963
12964 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12965 `error', not SYMBOL_NAME itself.
12966
12967 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12968 character arguments to `error'.
12969
12970 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12971 to `error' in error message about FINAL_CHAR argument. Make sure
12972 FINAL_CHAR is a character, and use %c when it is passed as
12973 argument to `error'.
12974
4ffd0d6b 129752011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12976
12977 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12978
12979 * w32.c: Include <time.h>.
12980 (sys_localtime): New function.
12981
4ffd0d6b 129822011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12983
12984 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12985
4ffd0d6b 12986 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12987
4ffd0d6b 129882011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12989
4ffd0d6b
GM
12990 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12991 zombies (Bug#8467).
aac0c6e3 12992
04c56954
EZ
129932011-04-19 Eli Zaretskii <eliz@gnu.org>
12994
12995 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12996 gl_state.e_property when gl_state.object is Qt.
12997
12998 * insdel.c (make_gap_larger): Remove limitation of buffer size
12999 to <= INT_MAX.
13000
16a43933
CY
130012011-04-18 Chong Yidong <cyd@stupidchicken.com>
13002
13003 * xdisp.c (lookup_glyphless_char_display)
13004 (produce_glyphless_glyph): Handle cons cell entry in
13005 glyphless-char-display.
13006 (Vglyphless_char_display): Document it.
13007
13008 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13009 glyphless-char-display.
13010
4581706e
CY
130112011-04-17 Chong Yidong <cyd@stupidchicken.com>
13012
13013 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13014
13015 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13016
13017 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13018 definition for no-X builds.
13019
4887c6e2 130202011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13021
fd35b6f9
PE
13022 Static checks with GCC 4.6.0 and non-default toolkits.
13023
5c1ccb01
PE
13024 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13025
006c5daa
PE
13026 * process.c (keyboard_bit_set): Define only if SIGIO.
13027 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13028 (send_process): Repair possible setjmp clobbering.
13029
efc736d3
PE
13030 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13031
4e2fe2e6
PE
13032 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13033
f97334a2
PE
13034 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13035
4e75f29d
PE
13036 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13037 Define only if needed.
13038
90efadd1
PE
13039 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13040 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 13041 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13042
3c647824
PE
13043 * dispextern.h (struct redisplay_interface): Rename param
13044 to avoid shadowing.
e264f262 13045 * termhooks.h (struct terminal): Likewise.
761383f4 13046 * xterm.c (xembed_send_message): Likewise.
3c647824 13047
b58c5c4a
PE
13048 * insdel.c (make_gap_smaller): Define only if
13049 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13050
cad59032
PE
13051 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13052 it.
13053
c339dc2e
PE
13054 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13055 so that we aren't warned about unused symbols.
13056
91a3e27b
PE
13057 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13058
399c71d3 13059 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13060
8ffc96f5
PE
13061 * xfns.c (x_real_positions): Mark locals as initialized.
13062
eef9bc79
PE
13063 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13064
098db9dd
PE
13065 * xterm.c: Fix problems found by static analysis with other toolkits.
13066 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13067 (x_dispatch_event): Declare static if USE_GTK, and
13068 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13069 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13070 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13071 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13072 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13073
eb18f6cc
PE
13074 * xmenu.c (menu_help_callback): Pointer type fixes.
13075 Use const pointers when pointing at readonly data. Avoid pointer
13076 signedness clashes.
13077 (FALSE): Remove unused macro.
13078 (update_frame_menubar): Remove unused decl.
13079
1fe72bf8
PE
13080 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13081
60d9e1db
PE
13082 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13083 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13084 (single_menu_item): Rename local to avoid shadowing.
13085
39261c26
PE
13086 * keyboard.c (make_lispy_event): Remove unused local var.
13087
018c5e19
PE
13088 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13089 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13090
63d2b86e
PE
13091 * bitmaps: Change bitmaps from unsigned char back to the X11
13092 compatible char. Avoid the old compiler warnings about
13093 out-of-range initializers by using, for example, '\xab' rather
13094 than 0xab.
13095
aefd87e1
PE
13096 * xgselect.c (xgselect_initialize): Check vs interface
13097 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13098
bf501fb9
PE
13099 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13100
e9829fdf
PE
13101 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13102 to read-only memory.
13103
1086c095
PE
13104 * fns.c (vector): Remove; this old hack is no longer needed.
13105
2baccd04 13106 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13107 Remove unused var.
dde42981 13108 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13109
72391843 13110 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13111
436c16df 13112 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13113 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13114 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13115
92bb796d 13116 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13117 (x_term_init): Remove local to avoid shadowing.
92bb796d 13118
764430a3 13119 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13120
13121 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13122 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13123
d1dfb56c
EZ
131242011-04-16 Eli Zaretskii <eliz@gnu.org>
13125
c4354cb4
EZ
13126 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13127
d1dfb56c
EZ
13128 Fix regex.c, syntax.c and friends for buffers > 2GB.
13129 * syntax.h (struct gl_state_s): Declare character position members
13130 EMACS_INT.
13131
13132 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13133
04f2d78b
CB
13134 * textprop.c (verify_interval_modification, interval_of):
13135 Declare arguments EMACS_INT.
d1dfb56c
EZ
13136
13137 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13138 EMACS_INT.
13139
13140 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13141
13142 * indent.c (Fvertical_motion): Local variable it_start is now
13143 EMACS_INT.
13144
13145 * regex.c (re_match, re_match_2, re_match_2_internal)
13146 (bcmp_translate, regcomp, regexec, print_double_string)
13147 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13148 (re_compile_pattern, re_exec): Declare arguments and local
13149 variables `size_t' and `ssize_t' and return values `regoff_t', as
13150 appropriate.
13151 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13152 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13153 <compile_stack_type>: `size' and `avail' are now `size_t'.
13154
13155 * regex.h <regoff_t>: Use ssize_t, not int.
13156 (re_search, re_search_2, re_match, re_match_2): Arguments that
13157 specify buffer/string position and length are now ssize_t and
13158 size_t. Return type is regoff_t.
13159
613052cd
BK
131602011-04-16 Ben Key <bkey76@gmail.com>
13161
13162 * nsfont.m: Fixed bugs in ns_get_family and
13163 ns_descriptor_to_entity that were caused by using free to
13164 deallocate memory blocks that were allocated by xmalloc (via
13165 xstrdup). This caused Emacs to crash when compiled with
13166 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13167 --enable-checking=xmallocoverrun). xfree is now used to
13168 deallocate these memory blocks.
13169
4170f62f 131702011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13171
71b41406
PE
13172 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13173
9587a89d
PE
13174 emacs_write: Accept and return EMACS_INT for sizes.
13175 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13176 et seq.
13177 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13178 Accept and return EMACS_INT.
13179 (emacs_gnutls_write): Return the number of bytes written on
13180 partial writes.
13181 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13182 (emacs_read, emacs_write): Remove check for negative size, as the
13183 Emacs source code has been audited now.
9587a89d
PE
13184 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13185 (emacs_read, emacs_write): Use it.
273a5f82
PE
13186 * process.c (send_process): Adjust to the new signatures of
13187 emacs_write and emacs_gnutls_write. Do not attempt to store
13188 a byte offset into an 'int'; it might overflow.
9587a89d 13189 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13190
3e047f51
PE
13191 * sound.c: Don't assume sizes fit in 'int'.
13192 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13193 Return EMACS_INT, not int.
3e047f51 13194 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13195 Accept EMACS_INT, not int.
13196 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13197 record read return values.
13198
cc39a9db
BK
131992011-04-15 Ben Key <bkey76@gmail.com>
13200
c9d0ec6d
JB
13201 * keyboard.c (Qundefined): Don't declare static since it is used
13202 in nsfns.m.
13203 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13204 static since they are used in nsfont.m.
cc39a9db 13205
6c60eb9f
SM
132062011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13207
13208 * process.c (Qprocessp): Don't declare static.
13209 * lisp.h (Qprocessp): Declare again.
13210
7990b61a
JB
132112011-04-15 Juanma Barranquero <lekktu@gmail.com>
13212
13213 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13214
5d4cb038
PE
132152011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13216
8bd7b830 13217 Improve C-level modularity by making more things 'static'.
cd64ea1d 13218
e3b27b31
PE
13219 Don't publish debugger-only interfaces to other modules.
13220 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13221 (verify_bytepos, count_markers): Move decls to the only modules
13222 that need them.
13223 * region-cache.h (pp_cache): Likewise.
13224 * window.h (check_all_windows): Likewise.
13225 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13226
5d4cb038
PE
13227 * sysdep.c (croak): Now static, if
13228 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13229 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13230
13231 * alloc.c (refill_memory_reserve): Now static if
13232 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13233 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13234
e87b6180
PE
13235 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13236 Define only if USE_LUCID.
13237
ac64929e
PE
13238 * xrdb.c (x_customization_string, x_rm_string): Now static.
13239
6f37259d
PE
13240 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13241 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13242
1683e3ab
PE
13243 * xdisp.c (draw_row_with_mouse_face): Now static.
13244 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13245
de9c2632
PE
13246 * window.h (check_all_windows): Mark externally visible.
13247
2b96acb7
PE
13248 * window.c (window_deletion_count): Now static.
13249
13250 * undo.c: Make symbols static if they're not exported.
13251 (last_undo_buffer, last_boundary_position, pending_boundary):
13252 Now static.
13253
50436f33
PE
13254 * textprop.c (interval_insert_behind_hooks): Now static.
13255 (interval_insert_in_front_hooks): Likewise.
13256
64520e5c
PE
13257 * term.c: Make symbols static if they're not exported.
13258 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13259 (max_frame_lines, tty_set_terminal_modes):
13260 (tty_reset_terminal_modes, tty_turn_off_highlight):
13261 (get_tty_terminal): Now static.
13262 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13263 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13264 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13265 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13266 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13267
1fa53021
PE
13268 * sysdep.c: Make symbols static if they're not exported.
13269 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13270 Now static.
13271 (sigprocmask_set, full_mask): Remove; unused.
13272 (wait_debugging): Mark as visible.
13273 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13274 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13275
d4b43b22
PE
13276 * syntax.c (syntax_temp): Define only if !__GNUC__.
13277
b7c513d0
PE
13278 * sound.c (current_sound_device, current_sound): Now static.
13279
989b29ad
PE
13280 * search.c (searchbufs, searchbuf_head): Now static.
13281
13a55a78
PE
13282 * scroll.c (scroll_cost): Remove; unused.
13283 * dispextern.h (scroll_cost): Remove decl.
13284
de68a1fc
PE
13285 * region-cache.h (pp_cache): Mark as externally visible.
13286
40ccffa6
PE
13287 * process.c: Make symbols static if they're not exported.
13288 (process_tick, update_tick, create_process, chan_process):
13289 (Vprocess_alist, proc_buffered_char, datagram_access):
13290 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13291 (deactivate_process): Mark defn as static, as well as decl.
13292 * lisp.h (create_process): Remove decl.
13293 * process.h (chan_process, Vprocess_alist): Remove decls.
13294
ad64fc97
PE
13295 * print.c: Make symbols static if they're not exported.
13296 (print_depth, new_backquote_output, being_printed, print_buffer):
13297 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13298 (print_interval, print_number_index, initial_stderr_stream):
13299 Now static.
13300 * lisp.h (Fprinc): Remove decl.
13301 (debug_output_compilation_hack): Mark as externally visible.
13302
adddb265
PE
13303 * sysdep.c (croak): Move decl from here to syssignal.h.
13304 * syssignal.h (croak): Put it here, so the API can be checked when
13305 'croak' is called from dissociate_if_controlling_tty.
13306
1717ede2
PE
13307 * minibuf.c: Make symbols static if they're not exported.
13308 (minibuf_save_list, choose_minibuf_frame): Now static.
13309 * lisp.h (choose_minibuf_frame): Remove decl.
13310
fa5fb2bc
PE
13311 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13312
1e3890d1
PE
13313 * lread.c: Make symbols static if they're not exported.
13314 (read_objects, initial_obarray, oblookup_last_bucket_number):
13315 Now static.
13316 (make_symbol): Remove; unused.
13317 * lisp.h (initial_obarray, make_symbol): Remove decls.
13318
8a1414fa
PE
13319 * keyboard.c: Make symbols static if they're not exported.
13320 (single_kboard, recent_keys_index, total_keys, recent_keys):
13321 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13322 (this_single_command_key_start, echoing, last_auto_save):
13323 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13324 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13325 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13326 (Vlispy_mouse_stem, double_click_count):
13327 Now static.
13328 (force_auto_save_soon): Define only if SIGDANGER.
13329 (ignore_mouse_drag_p): Now static if
13330 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13331 (print_help): Remove; unused.
13332 (stop_character, last_timer_event): Mark as externally visible.
13333 * keyboard.h (ignore_mouse_drag_p): Declare only if
13334 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13335 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13336 * lisp.h (echoing): Remove decl.
13337 (force_auto_save_soon): Declare only if SIGDANGER.
13338 * xdisp.c (redisplay_window): Simplify code, to make it more
13339 obvious that ignore_mouse_drag_p is not accessed if !defined
13340 USE_GTK && !defined HAVE_NS.
13341
93ea6e8f
PE
13342 * intervals.c: Make symbols static if they're not exported.
13343 (merge_properties_sticky, merge_interval_right, delete_interval):
13344 Now static.
13345 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13346
77382fcc
PE
13347 * insdel.c: Make symbols static if they're not exported.
13348 However, leave prepare_to_modify_buffer alone. It's never
13349 called from outside this function, but that appears to be a bug.
13350 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13351 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13352 (adjust_after_replace_noundo): Remove; unused.
13353 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13354 (signal_before_change): Remove decls.
77382fcc 13355
9306c32e
PE
13356 * indent.c (val_compute_motion, val_vmotion): Now static.
13357
cd44d2eb
PE
13358 * image.c: Make symbols static if they're not exported.
13359 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13360 if USE_GTK.
13361 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13362 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13363
ad9a7a06
PE
13364 * fringe.c (standard_bitmaps): Now static.
13365 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13366
81626931
PE
13367 * frame.c: Make symbols static if they're not exported.
13368 (x_report_frame_params, make_terminal_frame): Now static.
13369 (get_frame_param): Now static, unless HAVE_NS.
13370 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13371 (x_get_resource_string): Remove; not used.
13372 * frame.h (make_terminal_frame, x_report_frame_params):
13373 (x_get_resource_string); Remove decls.
13374 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13375 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13376
239f9db9
PE
13377 * font.c, fontset.c: Make symbols static if they're not exported.
13378 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13379 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13380 * font.c (font_close_object): Now static.
13381 * font.h (font_close_object): Remove.
13382 * fontset.c (FONTSET_OBJLIST): Remove.
13383 (free_realized_fontset) #if-0 the body, which does nothing.
13384 (face_suitable_for_char_p): #if-0, as it's never called.
13385 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13386 * xfaces.c (face_at_string_position):
13387 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13388 since 0 is always ASCII.
13389
dfcf3579
PE
13390 * fns.c (weak_hash_tables): Now static.
13391
5045092b
PE
13392 * fileio.c: Make symbols static if they're not exported.
13393 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13394 (Vwrite_region_annotation_buffers): Now static.
13395
57a96f5c
PE
13396 * eval.c: Make symbols static if they're not exported.
13397 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13398 * lisp.h (backtrace_list): Remove decl.
13399
35f08c38
PE
13400 * emacs.c: Make symbols static if they're not exported.
13401 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13402 (fatal_error_code, fatal_error_signal_hook, standard_args):
13403 Now static.
13404 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13405 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13406 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13407 * lisp.h (fatal_error_signal_hook): Remove decl.
13408 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13409
f44bd759
PE
13410 * editfns.c: Move a (normally-unused) function to its only use.
13411 * editfns.c, lisp.h (get_operating_system_release): Remove.
13412 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13413 worth the hassle of breaking this out.
13414
b532497d
PE
13415 * xterm.c: Make symbols static if they're not exported.
13416 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13417 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13418 (x_destroy_window, x_delete_display):
13419 Now static.
13420 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13421 (x_mouse_leave): Remove; unused.
13422 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13423 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13424 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13425 Remove decls.
13426 (x_mouse_leave): Declare only if WINDOWSNT.
13427 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13428 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13429 USE_X_TOOLKIT.
13430
1675728f
PE
13431 * ftxfont.c: Make symbols static if they're not exported.
13432 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13433 HAVE_FREETYPE.
13434 * font.h (ftxfont_driver): Likewise.
13435
e4cebfca
PE
13436 * xfns.c: Make symbols static if they're not exported.
13437 (x_last_font_name, x_display_info_for_name):
13438 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13439 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13440 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13441 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13442 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13443 (last_show_tip_args): Now static.
13444 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13445 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13446 (x_screen_planes): Remove; unused.
13447 * dispextern.h (x_screen_planes): Remove decl.
13448
5bf46f05
PE
13449 * dispnew.c: Make symbols static if they're not exported.
13450 * dispextern.h (redraw_garbaged_frames, scrolling):
13451 (increment_row_positions): Remove.
13452 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13453 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13454 Now static.
13455 (redraw_garbaged_frames): Remove; unused.
13456
435f4c28
PE
13457 * xfaces.c: Make symbols static if they're not exported.
13458 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13459 Remove decls.
13460 * xterm.h (defined_color): Remove decls.
13461 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13462 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13463 (menu_face_changed_default, defined_color, free_realized_face):
13464 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13465 (ascii_face_of_lisp_face): Remove; unused.
13466
8524aef3
PE
13467 * xdisp.c: Make symbols static if they're not exported.
13468 * dispextern.h (scratch_glyph_row, window_box_edges):
13469 (glyph_to_pixel_coords, set_cursor_from_row):
13470 (get_next_display_element, set_iterator_to_next):
13471 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13472 (show_mouse_face): Remove decls
13473 * frame.h (message_buf_print): Likewise.
13474 * lisp.h (pop_message, set_message, check_point_in_composition):
13475 Likewise.
13476 * xterm.h (set_vertical_scroll_bar): Likewise.
13477 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13478 (message_buf_print, scratch_glyph_row, displayed_buffer):
13479 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13480 (get_next_display_element, show_mouse_face, window_box_edges):
13481 (frame_to_window_pixel_xy, check_point_in_composition):
13482 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13483 (glyph_to_pixel_coords): Remove; unused.
13484
16390cd2
PE
13485 * dired.c (file_name_completion): Now static.
13486
13487 * dbusbind.c (xd_in_read_queued_messages): Now static.
13488
a25f4dfa
PE
13489 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13490 * data.c (circular_list_error): Remove.
13491
14a9c8df
PE
13492 * commands.h (last_point_position, last_point_position_buffer):
13493 (last_point_position_window): Remove decls.
13494 * keyboard.c: Make these variables static.
13495
04f2d78b
CB
13496 * coding.h (coding, code_convert_region, encode_coding_gap):
13497 Remove decls.
74ab6df5
PE
13498 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13499 (iso_code_class, detect_coding, code_convert_region): Now static.
13500 (encode_coding_gap): Remove; unused.
13501
38dfbee1
PE
13502 * chartab.c (chartab_chars, chartab_bits): Now static.
13503
a2cb4e63
PE
13504 * charset.h (charset_iso_8859_1): Remove decl.
13505 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13506 Now static.
13507
127198fd
PE
13508 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13509 * ccl.c (Vccl_program_table): Now static.
13510 (check_ccl_update): Remove; unused.
13511
d85b608f
PE
13512 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13513 * category.h: ... from here.
13514 * category.c (check_category_table, set_category_set): Now static.
13515
31cd66f3
PE
13516 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13517 * lisp.h: Remove these decls.
13518
c358e587
PE
13519 * buffer.c (buffer_count): Remove unused var.
13520
e78aecca
PE
13521 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13522 so that it's not optimized away.
13523 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13524 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13525 exported only to the debugger.
13526
e192d7d3 13527 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13528 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13529
92470028
PE
13530 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13531 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13532 was inaccessible from Lisp.
13533 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13534 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13535
244ed907
PE
13536 alloc.c: Import and export fewer symbols, and remove unused items.
13537 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13538 is defined.
13539 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13540 it's not optimized away by whole-program optimization.
13541 (message_enable_multibyte, free_misc): Remove.
13542 (catchlist, handlerlist, mark_backtrace):
13543 Declare only if BYTE_MARK_STACK.
13544 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13545 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13546 (message_enable_multibyte): Remove decl.
13547 (free_misc, interval_free_list, float_block, float_block_index):
13548 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13549 (cons_free_list, last_marked_index):
13550 Now static.
13551 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13552 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13553 (mark_backtrace): Define only if BYTE_MARK_STACK.
13554 * xdisp.c (message_enable_multibyte): Now static.
13555
61c2b50e 13556 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13557 This makes it easier for human readers (and static analyzers)
13558 to see whether these variables are used from other modules.
13559 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13560 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13561 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13562 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13563 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13564 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13565 * xmenu.c, xselect.c:
13566 Declare Q* vars static if they are not used in other modules.
13567 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13568 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13569 Remove decls of unexported vars.
13570 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13571
95c82688
PE
13572 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13573
16a97296
PE
13574 Make Emacs functions such as Fatom 'static' by default.
13575 This makes it easier for human readers (and static analyzers)
13576 to see whether these functions can be called from other modules.
13577 DEFUN now defines a static function. To make the function external
13578 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13579 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13580 (Finit_image_library):
16a97296
PE
13581 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13582 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13583 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13584 Remove decls, since these functions are now static.
13585 (Funintern, Fget_internal_run_time): New decls, since these functions
13586 were already external.
95c82688 13587
16a97296
PE
13588 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13589 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13590 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13591 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13592 * keyboard.c, keymap.c, lread.c:
13593 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13594 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13595 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13596 Mark functions with DEFUE instead of DEFUN,
13597 if they are used in other modules.
13598 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13599 decls for now-static functions.
13600 * buffer.h (Fdelete_overlay): Remove decl.
13601 * callproc.c (Fgetenv_internal): Mark as internal.
13602 * composite.c (Fremove_list_of_text_properties): Remove decl.
13603 (Fcomposition_get_gstring): New forward static decl.
13604 * composite.h (Fcomposite_get_gstring): Remove decl.
13605 * dired.c (Ffile_attributes): New forward static decl.
13606 * doc.c (Fdocumntation_property): New forward static decl.
13607 * eval.c (Ffetch_bytecode): New forward static decl.
13608 (Funintern): Remove extern decl; now in .h file where it belongs.
13609 * fileio.c (Fmake_symbolic_link): New forward static decl.
13610 * image.c (Finit_image_library): New forward static decl.
13611 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13612 * intervals.h (Fprevious_property_change):
13613 (Fremove_list_of_text_properties): Remove decls.
13614 * keyboard.c (Fthis_command_keys): Remove decl.
13615 (Fcommand_execute): New forward static decl.
13616 * keymap.c (Flookup_key): New forward static decl.
13617 (Fcopy_keymap): Now static.
13618 * keymap.h (Flookup_key): Remove decl.
13619 * process.c (Fget_process): New forward static decl.
13620 (Fprocess_datagram_address): Mark as internal.
13621 * syntax.c (Fsyntax_table_p): New forward static decl.
13622 (skip_chars): Remove duplicate decl.
13623 * textprop.c (Fprevious_property_change): New forward static decl.
13624 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13625 Now internal.
13626 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13627 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13628
785bbd42
PE
13629 * editfns.c (Fformat): Remove unreachable code.
13630
8b913b57
AS
136312011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13632
13633 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13634 change. (Bug#8496)
13635
a6744a35
EZ
136362011-04-13 Eli Zaretskii <eliz@gnu.org>
13637
13638 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13639 when at ZV. (Bug#8487)
13640
e7974947
AS
136412011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13642
baad03f0
AS
13643 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13644 (Bug#8437)
13645 * keyboard.c (parse_tool_bar_item): Likewise.
13646 * sound.c (sound_cleanup, alsa_close): Likewise.
13647 * termcap.c (tgetent): Likewise.
13648 * xfns.c (x_default_font_parameter): Likewise.
13649 * xsettings.c (read_and_apply_settings): Likewise.
13650
e7974947
AS
13651 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13652 (overrun_check_free): Protoize.
13653
28272684
PE
136542011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13655
13656 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13657 since callers should never pass a negative size.
13658 Change the signature to match that of plain 'read' and 'write'; see
13659 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13660 * lisp.h: Update prototypes of emacs_write and emacs_read.
13661
11997c76
EZ
136622011-04-11 Eli Zaretskii <eliz@gnu.org>
13663
13664 * xdisp.c (redisplay_window): Don't try to determine the character
13665 position of the scroll margin if the window start point w->startp
e896f03c 13666 is outside the buffer's accessible region. (Bug#8468)
11997c76 13667
8a2cbd72
EZ
136682011-04-10 Eli Zaretskii <eliz@gnu.org>
13669
13670 Fix write-region and its subroutines for buffers > 2GB.
13671 * fileio.c (a_write, e_write): Modify declaration of arguments and
13672 local variables to support buffers larger than 2GB.
13673 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13674
13675 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13676 argument, local variables, and return value.
13677
13678 * lisp.h: Update prototypes of emacs_write and emacs_read.
13679
13680 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13681
4073e537 136822011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13683
1ebfdcb6
PE
13684 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13685
b2ded58d
PE
13686 Fix more problems found by GCC 4.6.0's static checks.
13687
7d66342c
PE
13688 * xdisp.c (vmessage): Use a better test for character truncation.
13689
bbf47d44
PE
13690 * charset.c (load_charset_map): <, not <=, for optimization,
13691 and to avoid potential problems with integer overflow.
9248994d 13692 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13693 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13694 * editfns.c (Fformat): Likewise.
1e69125e 13695 * syntax.c (skip_chars): Likewise.
3befa583 13696
e3019616
PE
13697 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13698 This also lets GCC 4.6.0 generate slightly better loop code.
13699
becfa255
PE
13700 * callint.c (Fcall_interactively): <, not <=, for optimization.
13701 (Fcall_interactively): Count the number of arguments produced,
13702 not the number of arguments given. This is simpler and lets GCC
13703 4.6.0 generate slightly better code.
13704
dae0cd48
PE
13705 * ftfont.c: Distingish more carefully between FcChar8 and char.
13706 The previous code passed unsigned char * to a functions like
13707 strlen and xstrcasecmp that expect char *, which does not
13708 conform to the C standard.
13709 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13710 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13711 char * when the C standard requires it.
13712
76032d70
PE
13713 * keyboard.c (read_char): Remove unused var.
13714
eb3f1cc8
PE
13715 * eval.c: Port to Windows vsnprintf (Bug#8435).
13716 Include <limits.h>.
13717 (SIZE_MAX): Define if the headers do not.
13718 (verror): Do not give up if vsnprintf returns a negative count.
13719 Instead, grow the buffer. This ports to Windows vsnprintf, which
13720 does not conform to C99. Problem reported by Eli Zaretskii.
13721 Also, simplify the allocation scheme, by avoiding the need for
13722 calling realloc, and removing the ALLOCATED variable.
13723
70476b54
PE
13724 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13725
12020a9e
PE
13726 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13727 But keep the doprint source code for now, as we might revamp it
13728 and use it again (Bug#8435).
ea6c7ae6
PE
13729 * lisp.h (doprnt): Remove.
13730 * Makefile.in (base_obj): Remove doprnt.o.
13731 * deps.mk (doprnt.o): Remove.
13732
5fdb398c
PE
13733 error: Print 32- and 64-bit integers portably (Bug#8435).
13734 Without this change, on typical 64-bit hosts error ("...%d...", N)
13735 was used to print both 32- and 64-bit integers N, which relied on
13736 undefined behavior.
61bdb816 13737 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13738 * lisp.h (error, verror): Mark as printf-like functions.
13739 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13740 Report overflow in size calculations when allocating printf buffer.
13741 Do not truncate output string at its first null byte.
13742 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13743 Truncate the output at a character boundary, since vsnprintf does not
13744 do that.
13745 * charset.c (check_iso_charset_parameter): Convert internal
13746 character to string before calling 'error', since %c now has the
13747 printf meaning.
13748 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13749 overflow when computing char to be passed to 'error'. Do not
13750 pass Lisp_Object to 'error'; pass the integer instead.
13751 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13752 formatted with plain %d.
13753
b189fa66
PE
13754 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13755
bff87ef0
PE
13756 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13757
7e2cac20
PE
13758 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13759
ce4d90b5
PE
13760 * xterm.c (x_catch_errors): Remove duplicate declaration.
13761
266c9547
PE
13762 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13763
79c49ad2
PE
13764 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13765
368f4090
JM
137662011-04-10 Jim Meyering <meyering@redhat.com>
13767
13768 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13769 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13770 return ssize_t not "int", and use size_t as the buffer length.
13771 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13772 * gnutls.h: Update declarations.
13773 * process.c (read_process_output): Use ssize_t, to match.
13774 (send_process): Likewise.
13775
a32d4040
CY
137762011-04-09 Chong Yidong <cyd@stupidchicken.com>
13777
13778 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13779
8546720e 137802011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13781
04f2d78b
CB
13782 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13783 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13784
8546720e
GM
13785 * xterm.c (handle_one_xevent):
13786 * xmenu.c (create_and_show_popup_menu):
13787 * xselect.c (x_decline_selection_request)
13788 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13789
0a2f5c1a 137902011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13791
13792 Fix some uses of `int' instead of EMACS_INT.
13793 * search.c (string_match_1, fast_string_match)
13794 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13795 (scan_buffer, find_next_newline_no_quit)
13796 (find_before_next_newline, search_command, Freplace_match)
13797 (Fmatch_data): Make some `int' variables be EMACS_INT.
13798
13799 * xdisp.c (display_count_lines): 3rd argument and return value now
13800 EMACS_INT. All callers changed.
13801 (pint2hrstr): Last argument is now EMACS_INT.
13802
13803 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13804 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13805 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13806 (decode_coding_utf_16, decode_coding_emacs_mule)
13807 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13808 (decode_coding_ccl, decode_coding_charset)
13809 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13810 (decode_coding_iso_2022, decode_coding_emacs_mule)
13811 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13812 <char_offset, last_offset>: Declare EMACS_INT.
13813 (encode_coding_utf_8, encode_coding_utf_16)
13814 (encode_coding_emacs_mule, encode_invocation_designation)
13815 (encode_designation_at_bol, encode_coding_iso_2022)
13816 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13817 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13818 Declare EMACS_INT.
13819 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13820 (encode_invocation_designation): Last argument P_NCHARS is now
13821 EMACS_INT.
13822 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13823 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13824
13825 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13826 All users changed.
13827
13828 * ccl.c (Fccl_execute_on_string): Declare some variables
13829 EMACS_INT.
13830
8546720e 138312011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13832
13833 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13834
4e19a977
CS
138352011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13836
13837 * process.c (Fformat_network_address): Doc fix.
13838
87302331
R
138392011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13840
ee7683eb 13841 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13842
cbb59342
CY
138432011-04-08 Chong Yidong <cyd@stupidchicken.com>
13844
13845 * keyboard.c (read_char): Call Lisp function help-form-show,
13846 instead of using internal_with_output_to_temp_buffer.
13847 (Qhelp_form_show): New var.
e0d38eeb 13848 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13849
13850 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13851
13852 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13853
e67a13ab
CY
138542011-04-06 Chong Yidong <cyd@stupidchicken.com>
13855
04f2d78b
CB
13856 * process.c (Flist_processes): Remove to Lisp.
13857 (list_processes_1): Delete.
e67a13ab 13858
973f782d
EZ
138592011-04-06 Eli Zaretskii <eliz@gnu.org>
13860
7c106b1e
EZ
13861 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13862
973f782d
EZ
13863 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13864
41cf7d1a 138652011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13866
ca23cc88
PE
13867 Fix more problems found by GCC 4.6.0's static checks.
13868
f390e2d5
PE
13869 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13870
42eea0d0
PE
13871 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13872
b69769da 13873 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13874
f9541e84
PE
13875 * xdisp.c (vmessage): Mark as a printf-like function.
13876
13841b55
PE
13877 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13878
c136c10f
PE
13879 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13880
5e2d4a30
PE
13881 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13882 printf-like functions.
13883 (tiff_load): Add casts to remove these marks before passing them
13884 to system-supplied API.
13885
583f48b9
PE
13886 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13887
b25d760e
PE
13888 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13889 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13890 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13891 directly, rather than having caller test rule sign. This avoids
13892 some unnecessary tests.
13893 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13894 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13895 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13896
bc7b6697 13897 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13898 (xfont_open): Avoid unnecessary tests.
bc7b6697 13899
27ccc379
PE
13900 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13901
dcd5c89a
PE
13902 * composite.h, composite.c (composition_gstring_put_cache):
13903 Use EMACS_INT, not int, for length.
13904
b13a45c6
PE
13905 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13906 breaking out part of COMPOSITION_DECODE_RULE.
13907 (COMPOSITION_DECODE_RULE): Use it.
13908 * composite.c (get_composition_id): Remove unused local vars,
13909 by using the new macro.
13910
1e792e4d
PE
13911 * textprop.c (set_text_properties_1): Change while to do-while,
13912 since the condition is always true at first.
13913
dc6c6455 13914 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13915 (interval_deletion_adjustment): Return unsigned value.
13916 All uses changed.
dc6c6455 13917
aba7731a
PE
13918 * process.c (list_processes_1, create_pty, read_process_output):
13919 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13920 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13921 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13922 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13923 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13924
fdfc4bf3
PE
13925 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13926
fca8fe46 13927 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13928 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13929
06a0259a 13930 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13931 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13932 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13933
e7b9e80f
PE
13934 * print.c (print_error_message): Avoid int overflow.
13935
56201685
PE
13936 * font.c (font_list_entities): Redo for clarity,
13937 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13938
78834453 13939 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13940 (font_score): Avoid potential overflow in diff calculation.
78834453 13941
0bc0b309 13942 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13943 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13944
e610eaca
PE
13945 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13946
b895abce
PE
13947 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13948 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13949 can always succeed if overflow has undefined behavior.
13950
1f1d9321 13951 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13952 (wordify): Omit three unnecessary tests.
1f1d9321 13953
c59478bc
PE
13954 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13955 All callers changed. This avoids the need for an unused var.
13956
79b73827
PE
13957 * casefiddle.c (casify_region): Remove var that is set but not used.
13958
a4db5dfe
PE
13959 * dired.c (file_name_completion): Remove var that is set but not used.
13960
43aae36e
PE
13961 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13962
2a47c44d 13963 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13964 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13965
a37c69bf
PE
13966 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13967 Check for integer overflow on size calculations.
13968
328ab8e7
PE
13969 * buffer.c (Fprevious_overlay_change): Remove var that is set
13970 but not used.
13971
e5a2a5cb
PE
13972 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13973 Remove vars that are set but not used.
8d84a6eb 13974 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13975 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13976
a60e5f68
PE
13977 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13978
f661cb61 13979 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13980 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13981
f0397f5a
PE
13982 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13983 that are set but not used.
13984
8664db06 13985 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13986 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13987
6abdaa4a
PE
13988 * xselect.c (x_get_local_selection, x_handle_property_notify):
13989 Remove vars that are set but not used.
13990
0ce7538d 13991 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13992 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13993
9ae848fc
PE
13994 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13995 Remove var that is set but not used.
0b918413
PE
13996 (scroll_bar_windows_size): Now size_t, not int.
13997 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13998 Check for overflow.
9ae848fc 13999
a5a62657
PE
14000 * xfaces.c (realize_named_face): Remove vars that are set but not used.
14001 (map_tty_color) [!defined MSDOS]: Likewise.
14002
5c5cdd39
PE
14003 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
14004
66ebf983
PE
14005 * coding.c: Remove vars that are set but not used.
14006 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14007 All callers changed.
14008 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14009 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14010 (decode_coding_charset): Remove vars that are set but not used.
14011
1be4d761
PE
14012 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14013 that is set but not used.
14014
47553fa8
PE
14015 * print.c (print_object): Remove var that is set but not used.
14016
1f7196bf 14017 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14018 The gnulib version avoids calling malloc in the usual case,
14019 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14020 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14021 * filelock.c (current_lock_owner): Likewise.
14022 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14023 * sysdep.c: Include allocator.h, careadlinkat.h.
14024 (emacs_no_realloc_allocator): New static constant.
14025 (emacs_readlink): New function.
fdb61804
PE
14026 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14027 ../lib/careadlinkat.h.
d1fdcab7 14028
f84c17c7
SM
140292011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14030
14031 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14032 first non-nil return value).
14033
ef3862ad
JD
140342011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14035
14036 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14037 if not defined (Bug#8403).
14038
376a7006
JB
140392011-04-02 Juanma Barranquero <lekktu@gmail.com>
14040
14041 * xdisp.c (display_count_lines): Remove parameter `start',
14042 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14043 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14044 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14045 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14046 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14047 and thereabouts. All callers changed.
14048 (get_per_char_metric): Remove parameter `f', unused since
14049 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14050
6ca3801d
JM
140512011-04-02 Jim Meyering <meyering@redhat.com>
14052
14053 do not dereference NULL upon failed strdup
14054 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14055 (ns_get_family): Likewise.
14056
d8e2b5ba
JB
140572011-04-02 Juanma Barranquero <lekktu@gmail.com>
14058
14059 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14060
8c74fcbd
JD
140612011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14062
14063 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14064 later (Bug#8403).
14065
7200d79c
SM
140662011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14067
03408648 14068 Add lexical binding.
7200d79c 14069
03408648
SM
14070 * window.c (Ftemp_output_buffer_show): New fun.
14071 (Fsave_window_excursion):
14072 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14073
14074 * lread.c (lisp_file_lexically_bound_p): New function.
14075 (Fload): Bind Qlexical_binding.
14076 (readevalloop): Remove `evalfun' arg.
14077 Bind Qinternal_interpreter_environment.
14078 (Feval_buffer): Bind Qlexical_binding.
14079 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14080 Mark as dynamic.
14081 (syms_of_lread): Declare `lexical-binding'.
14082
14083 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14084
14085 * keyboard.c (eval_dyn): New fun.
14086 (menu_item_eval_property): Use it.
ca105506
SM
14087
14088 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14089
03408648
SM
14090 * fns.c (concat, mapcar1): Accept byte-code-functions.
14091
14092 * eval.c (Fsetq): Handle lexical vars.
14093 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14094 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14095 (FletX, Flet): Obey lexical binding.
14096 (Fcommandp): Handle closures.
14097 (Feval): New `lexical' arg.
14098 (eval_sub): New function extracted from Feval. Use it almost
14099 everywhere where Feval was used. Look up vars in lexical env.
14100 Handle closures.
14101 (Ffunctionp): Move from subr.el.
14102 (Ffuncall): Handle closures.
14103 (apply_lambda): Remove `eval_flags'.
14104 (funcall_lambda): Handle closures and new byte-code-functions.
14105 (Fspecial_variable_p): New function.
14106 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14107 but without exporting it to Lisp.
23aba0ea 14108
23aba0ea 14109 * doc.c (Fdocumentation, store_function_docstring):
03408648 14110 * data.c (Finteractive_form): Handle closures.
23aba0ea 14111
03408648
SM
14112 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14113 interactive spec.
ba83908c 14114
04f2d78b
CB
14115 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14116 New byte-codes.
03408648
SM
14117 (exec_byte_code): New function extracted from Fbyte_code to handle new
14118 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14119
03408648 14120 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14121
03408648 14122 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14123
e2abce01
JB
141242011-03-31 Juanma Barranquero <lekktu@gmail.com>
14125
14126 * xdisp.c (redisplay_internal): Fix prototype.
14127
63696a73 141282011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14129
63696a73 14130 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14131 (try_scrolling): Use it when setting scroll_limit.
14132 Limit scrolling to 100 screen lines.
63696a73
EZ
14133 (redisplay_window): Even when falling back on "recentering",
14134 position point in the window according to scroll-conservatively,
14135 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14136
14137 (try_scrolling): When point is above the window, allow searching
14138 as far as scroll_max, or one screenful, to compute vertical
14139 distance from PT to the scroll margin position. This prevents
14140 try_scrolling from unnecessarily failing when
14141 scroll-conservatively is set to a value slightly larger than the
14142 window height. Clean up the case of PT below the margin at bottom
14143 of window: scroll_max can no longer be INT_MAX. When aggressive
14144 scrolling is in use, don't let point enter the opposite scroll
14145 margin as result of the scroll.
14146 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14147 threshold of 100 lines for never-recentering scrolling.
14148
e4cc2dfc
JB
141492011-03-31 Juanma Barranquero <lekktu@gmail.com>
14150
14151 * dispextern.h (move_it_by_lines):
14152 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14153 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14154 (message_log_check_duplicate): Remove parameters `prev_bol' and
14155 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14156 (redisplay_internal): Remove parameter `preserve_echo_area',
14157 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14158
14159 * indent.c (Fvertical_motion):
14160 * window.c (window_scroll_pixel_based, Frecenter):
14161 Don't pass `need_y_p' to `move_it_by_lines'.
14162
1c470562
SM
141632011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14164
44f230aa
SM
14165 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14166 steal a few bits to be more compact.
14167 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14168 Remove unneeded casts.
14169
1c470562
SM
14170 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14171
888adce9
ZK
141722011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14173
14174 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14175 binding" message (bug#7967).
14176
f838ed7b
PE
141772011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14178
77861b95
PE
14179 Fix more problems found by GCC 4.6.0's static checks.
14180
de6dbc14
PE
14181 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14182 Remove unused local var.
14183
f838ed7b
PE
14184 * editfns.c (Fmessage_box): Remove unused local var.
14185
792c7b2b
PE
14186 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14187 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14188 Omit unused local vars.
c499e557 14189 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14190 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14191 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14192 Omit unused local var.
14193
ba0165e1
PE
14194 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14195 Don't assume string length fits in int.
32ad8845 14196 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14197 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14198
3c59b4c9
PE
14199 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14200 instead of alloca (Bug#8344).
14201
a3eed478 14202 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14203 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14204
eb4d412d
PE
14205 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14206
1658b401
PE
14207 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14208 concerns.
14209
14210 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14211
14212 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14213
9a2c6e05
PE
14214 * keyboard.c (syms_of_keyboard): Use the same style as later
14215 in this function when indexing through an array. This also
14216 works around GCC bug 48267.
14217
03d0a109
PE
14218 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14219
44f730c8
PE
14220 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14221
fe75f926
PE
14222 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14223 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14224
ffa8c828
PE
14225 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14226 This avoids undefined behavior on integer overflow, and is a bit
14227 more convenient anyway since it is compared to a size_t variable.
14228
c5101a77
PE
14229 Variadic C functions now count arguments with size_t, not int.
14230 This avoids an unnecessary limitation on 64-bit machines, which
14231 caused (substring ...) to crash on large vectors (Bug#8344).
14232 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14233 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14234 All variadic functions and their callers changed accordingly.
c5101a77
PE
14235 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14236 * data.c (arith_driver, float_arith_driver): Likewise.
14237 * editfns.c (general_insert_function): Likewise.
14238 * eval.c (struct backtrace.nargs, interactive_p)
14239 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14240 (funcall_lambda, mark_backtrace): Likewise.
14241 * fns.c (concat): Likewise.
14242 * frame.c (x_set_frame_parameters): Likewise.
14243 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14244 0 if not found, not -1. All callers changed.
14245
dd3f25f7
PE
14246 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14247 (stack_copy_size): Now size_t, not int.
14248 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14249
461c2ab9
JB
142502011-03-28 Juanma Barranquero <lekktu@gmail.com>
14251
14252 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14253 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14254 All callers changed.
14255
14256 * lisp.h (multibyte_char_to_unibyte):
14257 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14258 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14259 * character.h (CHAR_TO_BYTE8):
14260 * cmds.c (internal_self_insert):
14261 * editfns.c (general_insert_function):
14262 * keymap.c (push_key_description):
14263 * search.c (Freplace_match):
14264 * xdisp.c (message_dolog, set_message_1): All callers changed.
14265
f6d62986
SM
142662011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14267
14268 * keyboard.c (safe_run_hook_funcall): New function.
14269 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14270 don't set the hook to nil, but remove the offending function instead.
14271 (Qcommand_hook_internal): Remove, unused.
14272 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14273 Vcommand_hook_internal.
14274
14275 * eval.c (enum run_hooks_condition): Remove.
14276 (funcall_nil, funcall_not): New functions.
14277 (run_hook_with_args): Call each function through a `funcall' argument.
14278 Remove `cond' argument, now redundant.
14279 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14280 (Frun_hook_with_args_until_failure): Adjust accordingly.
14281 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14282
1db5b1ad
JB
142832011-03-28 Juanma Barranquero <lekktu@gmail.com>
14284
14285 * dispextern.h (string_buffer_position): Remove declaration.
14286
14287 * print.c (strout): Remove parameter `multibyte', unused since
14288 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14289
14290 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14291 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14292 All callers changed.
14293
14294 * w32.c (_wsa_errlist): Use braces for struct initializers.
14295
14296 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14297 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14298 All callers changed.
14299 (string_buffer_position): Likewise. Also, make static (it's never
14300 used outside xdisp.c).
14301 (cursor_row_p): Remove parameter `w', unused since
14302 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14303 (decode_mode_spec): Remove parameter `precision', introduced during
14304 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14305 All callers changed.
14306
5ffb62aa
JD
143072011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14308
14309 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14310
461c2ab9 143112011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14312
14313 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14314 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14315 (ns_update_auto_hide_menu_bar): New functions.
14316 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14317 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14318 ns_constrain_all_frames.
14319 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14320 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14321
5c380ffb
JD
143222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14323
14324 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14325
9af30bdf
GM
143262011-03-27 Glenn Morris <rgm@gnu.org>
14327
14328 * syssignal.h: Replace RETSIGTYPE with void.
14329 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14330 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14331 Replace SIGTYPE with void everywhere.
14332 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14333 * s/template.h (SIGTYPE): Remove commented out definition.
14334
e2abce01
JB
143352011-03-26 Eli Zaretskii <eliz@gnu.org>
14336
14337 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14338 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14339
f868cd8a
JB
143402011-03-26 Juanma Barranquero <lekktu@gmail.com>
14341
59eb0929
JB
14342 * w32.c (read_unc_volume): Use parameter `henum', instead of
14343 global variable `wget_enum_handle'.
14344
14345 * keymap.c (describe_vector): Remove parameters `indices' and
14346 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14347 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14348
f868cd8a
JB
14349 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14350
14351 * keyboard.c (timer_check): Remove parameter `do_it_now',
14352 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14353 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14354 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14355
14356 * keyboard.c (read_char):
14357 * w32menu.c (w32_menu_display_help):
14358 * xmenu.c (show_help_event, menu_help_callback):
14359 Adjust calls to `show_help_echo'.
14360
14361 * gtkutil.c (xg_maybe_add_timer):
14362 * keyboard.c (readable_events):
14363 * process.c (wait_reading_process_output):
14364 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14365
14366 * insdel.c (adjust_markers_gap_motion):
14367 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14368 (gap_left, gap_right): Don't call it.
14369
2ecf6fdb
CY
143702011-03-25 Chong Yidong <cyd@stupidchicken.com>
14371
14372 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14373 incurred during fontification.
14374
6b1f9ba4
JB
143752011-03-25 Juanma Barranquero <lekktu@gmail.com>
14376
14377 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14378 (DEFVAR_PER_BUFFER): Don't pass it.
14379
14380 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14381 (scrolling_window): Don't pass it.
14382
0f4a96b5
JB
143832011-03-25 Juanma Barranquero <lekktu@gmail.com>
14384
14385 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14386
14387 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14388 and `suffix'.
14389 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14390 of variables specific to SELinux and computation of `encoded_absname'.
14391
14392 * image.c (XPutPixel): Remove unused variable `height'.
14393
14394 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14395
14396 * unexw32.c (get_section_info): Remove unused variable `section'.
14397
14398 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14399 (system_process_attributes): Remove unused variable `sess'.
14400 (sys_read): Remove unused variable `err'.
14401
14402 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14403 (w32_wnd_proc): Remove unused variable `isdead'.
14404 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14405 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14406 (x_create_tip_frame): Remove unused variable `tem'.
14407
14408 * w32inevt.c (w32_console_read_socket):
14409 Remove unused variable `no_events'.
14410
14411 * w32term.c (x_draw_composite_glyph_string_foreground):
14412 Remove unused variable `width'.
14413
1149507c
JB
144142011-03-24 Juanma Barranquero <lekktu@gmail.com>
14415
14416 * w32term.c (x_set_glyph_string_clipping):
14417 Don't pass uninitialized region to CombineRgn.
14418
9c88f339
JB
144192011-03-23 Juanma Barranquero <lekktu@gmail.com>
14420
14421 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14422 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14423 (Fx_close_connection): Remove unused variable `i'.
14424
14425 * w32font.c (w32font_draw): Return number of glyphs.
14426 (w32font_open_internal): Remove unused variable `i'.
14427 (w32font_driver): Add missing initializer.
14428
14429 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14430 (fill_in_menu): Remove unused variable `items_added'.
14431
14432 * w32term.c (last_mouse_press_frame): Remove static global variable.
14433 (w32_clip_to_row): Remove unused variable `f'.
14434 (x_delete_terminal): Remove unused variable `i'.
14435
14436 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14437 (NOTHING): Remove unused static global variable.
14438 (uniscribe_check_otf): Remove unused variable `table'.
14439 (uniscribe_font_driver): Add missing initializers.
14440
dee091a3
JD
144412011-03-23 Julien Danjou <julien@danjou.info>
14442
14443 * term.c (Fsuspend_tty, Fresume_tty):
14444 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14445 * window.c (temp_output_buffer_show):
14446 * insdel.c (signal_before_change):
14447 * frame.c (Fhandle_switch_frame):
14448 * fileio.c (Fdo_auto_save):
14449 * emacs.c (Fkill_emacs):
14450 * editfns.c (save_excursion_restore):
14451 * cmds.c (internal_self_insert):
14452 * callint.c (Fcall_interactively):
14453 * buffer.c (Fkill_all_local_variables):
14454 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14455 Use Frun_hooks.
0f4a96b5 14456 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14457 unconditionally since it does the check itself.
dee091a3 14458
2c520ab5 144592011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14460
c9c49752
PE
14461 Fix more problems found by GCC 4.5.2's static checks.
14462
8abc3f12
PE
14463 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14464 the first time through the loop, since we know p0 < p1 then.
14465 This also avoids a gcc -Wstrict-overflow warning.
14466
a2d26660
PE
14467 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14468 leading to a memory leak, possible in functions like
14469 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14470 of objects (Bug#8318).
a2d26660 14471
916c72e9
PE
14472 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14473 that could (at least in theory) be that large.
14474
19ab8a18
PE
14475 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14476 This is less likely to overflow, and avoids undefined behavior if
14477 overflow does occur. All callers changed. Use strtoul to scan
14478 for the unsigned long integer.
b7cbbd6f
PE
14479 (pint2hrstr): Simplify and tune code slightly.
14480 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14481
f0641eff
PE
14482 * scroll.c (do_scrolling): Work around GCC bug 48228.
14483 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14484
7f650bb9
PE
14485 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14486 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14487 (validate_x_resource_name): Simplify count usage.
14488 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14489
37dd57d1
PE
14490 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14491 fail (Bug#8306).
81e56e61 14492
699979fc 14493 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14494
401bf9b4
PE
14495 * process.c (Fmake_network_process): Use socklen_t, not int,
14496 where POSIX says socklen_t is required in portable programs.
14497 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14498 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14499 (Fmake_network_process, server_accept_connection):
14500 (wait_reading_process_output, read_process_output):
14501 Likewise.
14502
b93aacde
PE
14503 * process.c: Rename or move locals to avoid shadowing.
14504 (list_processes_1, Fmake_network_process):
14505 (read_process_output_error_handler, exec_sentinel_error_handler):
14506 Rename or move locals.
4dc343ee 14507 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14508 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14509 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14510 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14511 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14512
af8a867c 14513 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14514 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14515 Include tparam.h instead, since it declares them.
af8a867c
PE
14516 * cm.h (PC): Remove extern decl; tparam.h now does this.
14517 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14518 * terminfo.c: Include tparam.h, to check interfaces.
14519 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14520 (tparam): Adjust signature to match interface in tparam.h;
14521 this removes some undefined behavior. Check that outstring and len
14522 are zero, which they always are with Emacs.
14523 * tparam.h (PC, BC, UP): New extern decls.
14524
0248044d 14525 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14526 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14527
8ff096c1 14528 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14529 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14530 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14531 (ftfont_list): Remove unused local.
49eaafba
PE
14532 (get_adstyle_property, ftfont_pattern_entity):
14533 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14534 Rename locals to avoid shadowing.
8ff096c1 14535
e2be39f6
PE
14536 * xfont.c (xfont_list_family): Mark var as initialized.
14537
c9735e30
PE
14538 * xml.c (make_dom): Now static.
14539
8f5201ae
PE
14540 * composite.c (composition_compute_stop_pos): Rename local to
14541 avoid shadowing.
b246f932
PE
14542 (composition_reseat_it): Remove unused locals.
14543 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14544 (composition_update_it): Mark var as initialized.
11b61122
PE
14545 (find_automatic_composition): Mark vars as initialized,
14546 with a FIXME (Bug#8290).
8f5201ae 14547
760fbc2c
PE
14548 character.h: Rename locals to avoid shadowing.
14549 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14550 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14551 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14552 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14553 to avoid shadowing.
14554
ff08eb85
PE
14555 * textprop.c (property_change_between_p): Remove; unused.
14556
fc7bf025
PE
14557 * intervals.c (interval_start_pos): Now static.
14558
235d7abc
PE
14559 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14560
44f230aa
SM
14561 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14562 Rename locals to avoid shadowing.
3e7d6594 14563
50060332
PE
14564 * sound.c (wav_play, au_play, Fplay_sound_internal):
14565 Fix pointer signedness.
d01f234b 14566 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14567 (wav_play): Initialize a variable to 0, to prevent undefined
14568 behavior (Bug#8278).
50060332 14569
c4fc4e30
PE
14570 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14571
918436ed
PE
14572 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14573
c939f91b
PE
14574 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14575 clobbering (Bug#8298).
b9c7f648
PE
14576 * sysdep.c (sys_subshell): Likewise.
14577 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14578
6bd8c144
PE
14579 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14580 This should get cleaned up, so that child_setup has the
14581 same signature on all platforms.
14582
7710357c 14583 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14584 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14585
c59da222
CY
145862011-03-22 Chong Yidong <cyd@stupidchicken.com>
14587
14588 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14589 not to be necessary, and produces flickering.
14590
66b87493
GM
145912011-03-20 Glenn Morris <rgm@gnu.org>
14592
14593 * config.in: Remove file.
14594
45b6f6d5
JB
145952011-03-20 Juanma Barranquero <lekktu@gmail.com>
14596
14597 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14598 are now in src/globals.h.
14599 (syms_of_minibuf): Remove spurious & from previous change.
14600
cd394be1 146012011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14602
14603 * minibuf.c (completing-read-function): New variable.
14604 (completing-read-default): Rename from completing-read.
14605 (completing-read): Call completing-read-function.
14606
b14e3e21
CY
146072011-03-19 Juanma Barranquero <lekktu@gmail.com>
14608
14609 * xfaces.c (Fx_load_color_file):
14610 Read color file from absolute filename (bug#8250).
14611
f2b726e6
JB
146122011-03-19 Juanma Barranquero <lekktu@gmail.com>
14613
14614 * makefile.w32-in: Update dependencies.
14615
09f6ff02
EZ
146162011-03-17 Eli Zaretskii <eliz@gnu.org>
14617
14618 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14619
29a6015a
PE
146202011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14621
a3a6c54e
PE
14622 Fix more problems found by GCC 4.5.2's static checks.
14623
b766f867
PE
14624 * process.c (make_serial_process_unwind, send_process_trap):
14625 (sigchld_handler): Now static.
14626
be02381c
PE
14627 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14628 That way, the code declares only the vars that it needs.
14629 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14630 * s/cygwin.h (PTY_ITERATION): Likewise.
14631 * s/darwin.h (PTY_ITERATION): Likewise.
14632 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14633
57048744
PE
14634 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14635 * process.c (allocate_pty): Don't declare stb unless it's needed.
14636
7914961c 14637 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14638 (CONSTANTLIM): Remove; unused.
14639 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14640 Define only if needed.
7914961c 14641
b3967b18
PE
14642 * unexelf.c (unexec): Name an expression,
14643 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14644 Use a different way to cause a compilation error if anyone uses
14645 n rather than nn, a way that does not involve shadowing.
73366a00 14646 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14647
29a6015a
PE
14648 * deps.mk (unexalpha.o): Remove; unused.
14649
43cfc33e 14650 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14651 * unexec.h: New file.
ce701a33
PE
14652 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14653 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14654 Depend on unexec.h.
14655 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14656 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14657 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14658 Change as necessary to match prototype in unexec.h.
ce701a33 14659
01f44d5a
PE
14660 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14661 shadowing.
4f63c6bb 14662 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14663
a6670b0b
PE
14664 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14665 Rename locals to avoid shadowing.
14666
cef2010d 14667 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14668 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14669
d4d7173a
PE
14670 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14671
f08b802a
PE
14672 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14673 warning when compiling print.c.
14674
3ddb0639
PE
14675 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14676 instead of using an uninitialized var.
5ad03b97 14677 (font_sort_entities): Mark var as initialized.
3ddb0639 14678
170a2692
PE
14679 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14680
e663c700
PE
14681 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14682 pointers to constants.
89bc529a 14683 (font_parse_fcname): Remove unused vars.
7b81e2d0 14684 (font_delete_unmatched): Now static.
ea838e10 14685 (font_get_spec): Remove; unused.
13a547c6
PE
14686 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14687 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14688 Rename or move locals to avoid shadowing.
e663c700 14689
2a80c887 14690 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14691 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14692
1384fa33 14693 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14694 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14695
8b2c52e9
PE
14696 * alloc.c (mark_backtrace): Move decl from here ...
14697 * lisp.h: ... to here, so that it can be checked.
14698
475545b5 14699 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14700 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14701 (lisp_indirect_variable): Name an expression,
14702 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14703 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14704
b1349114 14705 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14706 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14707 Use const pointer when appropriate.
b1349114 14708
a2928364
PE
14709 * lisp.h (get_system_name, get_operating_system_release):
14710 Move decls here, to check interfaces.
14711 * process.c (get_operating_system_release): Move decl to lisp.h.
14712 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14713 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14714 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14715 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14716 (Fformat_time_string, Fencode_time, Finsert_char):
14717 (Ftranslate_region_internal, Fformat):
14718 Rename or remove local vars to avoid shadowing.
9710023e 14719 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14720
a415e694
PE
14721 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14722 avoid shadowing.
14723
8ef4622d
PE
14724 * lisp.h (eassert): Check that the argument compiles, even if
14725 ENABLE_CHECKING is not defined.
14726
946f9a5b
PE
14727 * data.c (Findirect_variable): Name an expression, to avoid
14728 gcc -Wbad-function-cast warning.
112396d6 14729 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14730 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14731 (Fmake_variable_buffer_local, Fmake_local_variable):
14732 Mark variables as initialized.
52746918 14733 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14734
e5aab7e7 14735 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14736 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14737 Rename locals to avoid shadowing.
dff45157
PE
14738 (mark_stack): Move local variables into the #ifdef region where
14739 they're used.
7bc26fdb
PE
14740 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14741 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14742 needed otherwise.
14743 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14744 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14745 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14746
e5aab7e7
PE
14747 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14748 avoids undefined behavior in theory.
14749
4da60324
PE
14750 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14751
88043301
PE
14752 Use functions, not macros, for up- and down-casing (Bug#8254).
14753 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14754 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14755 to use the following functions instead of these macros.
14756 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14757 EMACS_INT, since callers assume the returned value fits in int.
14758 (upcase1): Likewise, for UPCASE_TABLE.
14759 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14760 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14761 the race-condition problem in the old DOWNCASE.
88043301 14762
19ed5445
PE
14763 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14764 Rename locals to avoid shadowing.
14765 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14766 (regex_compile, re_search_2, re_match_2_internal):
14767 Remove unused local vars.
952db0d7
PE
14768 (FREE_VAR): Rewrite so as not to use empty "else",
14769 which gcc can warn about.
da053e48 14770 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14771 (RETALLOC_IF): Define only if needed.
14772 (WORDCHAR_P): Likewise. This one is never needed, but is used
14773 only in a comment talking about a compiler bug, so put inside
14774 the #if 0 of that comment.
14775 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14776 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14777 Remove; unused.
19ed5445 14778
1f3561e4 14779 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14780 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14781 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14782
ded6f8f7
PE
14783 * search.c (simple_search): Remove unused var.
14784
dbd37a95
PE
14785 * dired.c (compile_pattern): Move decl from here ...
14786 * lisp.h: ... to here, so that it can be checked.
14787 (struct re_registers): New forward decl.
14788
7e47afad
PE
14789 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14790
85f24f61
PE
14791 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14792 All uses changed.
14793 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14794 Rename locals to avoid shadowing.
5671df8f 14795 (Fvertical_motion): Mark locals as initialized.
85f24f61 14796
181aa2be 14797 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14798 (casify_region): Mark local as initialized.
181aa2be 14799
930d429c
PE
14800 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14801
7082eac6
PE
14802 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14803 New macros, so that the caller can use some names other than
14804 gcpro1, gcpro2, etc.
14805 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14806 of the new macros.
14807 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14808 argument, for consistency with GCPRO2_VAR, etc: it is now the
14809 prefix of the variable, not the variable itself. All uses
14810 changed.
38b2c076
PE
14811 * dired.c (directory_files_internal, file_name_completion):
14812 Rename locals to avoid shadowing.
14813
15206ed9
PE
14814 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14815 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14816 dired.c's scmp function, had undefined behavior.
14817 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14818 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14819 * buffer.h: ... to here, because these macros use current_buffer,
14820 and the new implementation with inline functions needs to have
14821 current_buffer in scope now, rather than later when the macros
14822 are used.
14823 (downcase, upcase1): New static inline functions.
14824 (DOWNCASE, UPCASE1): Reimplement using these functions.
14825 This avoids undefined behavior in expressions like
14826 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14827 from race conditions in accessing the global variables
14828 case_temp1 and case_temp2.
14829 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14830 * lisp.h (case_temp1, case_temp2): Remove their decls.
14831 * character.h (ASCII_CHAR_P): Move from here ...
14832 * lisp.h: ... to here, so that the inline functions mentioned
14833 above can use them.
14834
4a6bea26
PE
14835 * dired.c (directory_files_internal_unwind): Now static.
14836
f14b7e14
PE
14837 * fileio.c (file_name_as_directory, directory_file_name):
14838 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14839 Now static.
2893f146
PE
14840 (file_name_as_directory): Use const pointers when appropriate.
14841 (Fexpand_file_name): Likewise. In particular, newdir might
14842 point at constant storage, so make it a const pointer.
fd4ead52 14843 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14844 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14845 signedness issues.
f839df0c
PE
14846 (Fset_file_times, Finsert_file_contents, auto_save_error):
14847 Rename locals to avoid shadowing.
f14b7e14 14848
5716756e 14849 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14850 (Ftry_completion, Fall_completions): Rename or remove locals
14851 to avoid shadowing.
5716756e 14852
b4c3046a
PE
14853 * marker.c (bytepos_to_charpos): Remove; unused.
14854
b45db522
PE
14855 * lisp.h (verify_bytepos, count_markers): New decls,
14856 so that gcc does not warn that these functions aren't declared.
14857
85876d07
PE
14858 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14859 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14860 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14861 (copy_text): Remove unused local var.
85876d07 14862
03d78a21 14863 * filelock.c (within_one_second): Now static.
b3dd38ab 14864 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14865
5df8f01b
PE
14866 * buffer.c (fix_overlays_before): Mark locals as initialized.
14867 (fix_start_end_in_overlays): Likewise. This function should be
14868 simplified by using pointers-to-pointers, but that's a different
14869 matter.
b1d876f1 14870 (switch_to_buffer_1): Now static.
8f54f30a
PE
14871 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14872 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14873
a70072c9 14874 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14875 Fix pointer signedness issue.
edced198
PE
14876 (sys_subshell): Mark local as volatile if checking for lint,
14877 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14878 (MAXPATHLEN): Define only if needed.
a70072c9 14879
a0977c44
PE
14880 * process.c (serial_open, serial_configure): Move decls from here ...
14881 * systty.h: ... to here, so that they can be checked.
14882
a884fdcc
PE
14883 * fns.c (get_random, seed_random): Move extern decls from here ...
14884 * lisp.h: ... to here, so that they can be checked.
14885
604efe86 14886 * sysdep.c (reset_io): Now static.
b8950c94 14887 (wait_for_termination_signal): Remove; unused.
604efe86 14888
38fc62d9
PE
14889 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14890 (copy_keymap_item, append_key, push_text_char_description):
14891 Now static.
1004a21a 14892 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14893 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14894 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14895 (describe_map_tree):
14896 Rename locals to avoid shadowing.
38fc62d9 14897
2f2650da
PE
14898 * keyboard.c: Declare functions static if they are not used elsewhere.
14899 (echo_char, echo_dash, cmd_error, top_level_2):
14900 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14901 (read_char, kbd_buffer_get_event, make_lispy_position):
14902 (make_lispy_event, make_lispy_movement, apply_modifiers):
14903 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14904 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14905 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14906 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14907 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14908
a053e86c 14909 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14910 (mark_kboards): Move decl here ...
14911 * alloc.c (mark_kboards): ... from here.
a053e86c 14912
4752793e
PE
14913 * lisp.h (force_auto_save_soon): New decl.
14914
74f10ca7 14915 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14916 (DEFINE_DUMMY_FUNCTION): New macro.
14917 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14918 Use it.
c03cd23f
PE
14919 (main): Add casts to avoid warnings
14920 if GCC considers string literals to be constants.
74f10ca7 14921
022e70d4
PE
14922 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14923
59d6fe83
PE
14924 * dbusbind.c: Pointer signedness fixes.
14925 (xd_signature, xd_append_arg, xd_initialize):
14926 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14927 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14928 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14929 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14930
78320123
PE
14931 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14932 if GCC considers string literals to be constants.
49cebcca 14933 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14934
35ac2a97
SM
149352011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14936
fb103ca9
SM
14937 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14938 (print_preprocess, print_object): New macro to fix last change.
14939
35ac2a97
SM
14940 * print.c (print_preprocess): Don't forget font objects.
14941
62973b41
JB
149422011-03-16 Juanma Barranquero <lekktu@gmail.com>
14943
14944 * emacs.c (USAGE3): Doc fixes.
14945
0e48bb22
AS
149462011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14947
14948 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14949 structure.
14950
7684e57b
JB
149512011-03-14 Juanma Barranquero <lekktu@gmail.com>
14952
14953 * lisp.h (VWindow_system, Qfile_name_history):
14954 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14955 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14956 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14957
14958 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14959 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14960
14961 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14962 * w32console.c (detect_input_pending, read_input_pending)
14963 (encode_terminal_code):
14964 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14965 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14966 (w32_system_caret_y, Qfile_name_history):
14967 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14968 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14969 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14970 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14971 * w32proc.c (Qlocal, report_file_error):
14972 * w32term.c (Vwindow_system, updating_frame):
14973 * w32uniscribe.c (initialized, uniscribe_font_driver):
14974 Remove unneeded extern declarations.
14975
2aa46d6c
CY
149762011-03-14 Chong Yidong <cyd@stupidchicken.com>
14977
c96bbc66 14978 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14979
cffc6f3b
CY
149802011-03-13 Chong Yidong <cyd@stupidchicken.com>
14981
14982 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14983 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14984 These macros can no longer be used for assignment.
14985
44f230aa
SM
14986 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14987 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14988 (record_buffer_markers, fetch_buffer_markers): New functions for
14989 recording and fetching special buffer markers.
14990 (set_buffer_internal_1, set_buffer_temp): Use them.
14991
14992 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14993
14994 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14995
14996 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14997 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14998
14999 * xdisp.c (hscroll_window_tree):
15000 (reconsider_clip_changes): Use PT instead of BUF_PT.
15001
d251f04b
EZ
150022011-03-13 Eli Zaretskii <eliz@gnu.org>
15003
15004 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
15005 $(EMACS_ROOT)/lib/intprops.h.
15006
f0c77cd1
PE
150072011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15008
3eca4629
PE
15009 Fix more problems found by GCC 4.5.2's static checks.
15010
7c86ee98
PE
15011 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15012 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15013 (xg_free_frame_widgets): Make it clear that a local variable is
15014 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15015 (gdk_window_get_screen): Make it clear that this macro is needed
15016 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15017 (int_gtk_range_get_value): New function, which avoids a diagnostic
15018 from gcc -Wbad-function-cast.
15019 (xg_set_toolkit_scroll_bar_thumb): Use it.
15020 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15021 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15022 (get_utf8_string, xg_get_file_with_chooser):
15023 Rename locals to avoid shadowing.
15024 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15025
41729b81
PE
15026 * xgselect.c (xg_select): Remove unused var.
15027
f0c77cd1
PE
15028 * image.c (four_corners_best): Mark locals as initialized.
15029 (gif_load): Initialize transparent_p to zero (Bug#8238).
15030 Mark another local as initialized.
ec6cf4c6 15031 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15032
ce0ad53d 15033 * image.c (clear_image_cache): Now static.
d5d5a617 15034 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15035 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15036 (x_edge_detection): Remove unnecessary cast that
15037 gcc -Wbad-function-cast diagnoses.
2037898d 15038 (gif_load): Fix pointer signedness.
6ae141d6
PE
15039 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15040 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 15041
33383987 150422011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15043
d32df629
PE
15044 Improve quality of tests for time stamp overflow.
15045 For example, without this patch (encode-time 0 0 0 1 1
15046 1152921504606846976) returns the obviously-bogus value (-948597
15047 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15048 reports time overflow. See
15049 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15050 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15051 * editfns.c: Include limits.h and intprops.h.
15052 (TIME_T_MIN, TIME_T_MAX): New macros.
15053 (time_overflow): Move earlier, to before first use.
15054 (hi_time, lo_time): New functions, for an accurate test for
15055 out-of-range times.
15056 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15057 (Fget_internal_run_time): Don't assume time_t fits in int.
15058 (make_time): Use list2 instead of Fcons twice.
15059 (Fdecode_time): More accurate test for out-of-range times.
15060 (check_tm_member): New function.
15061 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15062 (lisp_time_argument): Don't rely on undefined left-shift and
15063 right-shift behavior when checking for time stamp overflow.
8be6f318 15064
fe31d94c
PE
15065 * editfns.c (time_overflow): New function, refactoring common code.
15066 (Fformat_time_string, Fdecode_time, Fencode_time):
15067 (Fcurrent_time_string): Use it.
15068
8be6f318
PE
15069 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15070 * dired.c (make_time): Move to ...
15071 * editfns.c (make_time): ... here.
15072 * systime.h: Note the move.
15073
09d9db2c 150742011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15075
126bc0dc
YM
15076 * fringe.c (update_window_fringes): Remove unused variables.
15077
c47cbdfd
YM
15078 * unexmacosx.c (copy_data_segment): Also copy __got section.
15079 (Bug#8223)
15080
7ac80be9
EZ
150812011-03-12 Eli Zaretskii <eliz@gnu.org>
15082
c96bbc66 15083 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15084 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15085 Constify `char *' arguments and their references according to
15086 prototypes in tparam.h.
15087
ecb0f94d 15088 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15089
7ac80be9
EZ
15090 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15091 Adapt all references accordingly.
15092
15093 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15094
ef1fd07e
TT
150952011-03-11 Tom Tromey <tromey@redhat.com>
15096
15097 * buffer.c (syms_of_buffer): Remove obsolete comment.
15098
7ef4b50c
EZ
150992011-03-11 Eli Zaretskii <eliz@gnu.org>
15100
15101 * termhooks.h (encode_terminal_code): Declare prototype.
15102
15103 * msdos.c (encode_terminal_code): Don't declare prototype.
15104
15105 * term.c (encode_terminal_code): Now external again, used by
15106 w32console.c and msdos.c.
15107
44f230aa
SM
15108 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15109 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15110
4b1ec863 151112011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15112
1714f52b 15113 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15114
4b1ec863
PE
15115 * fringe.c (update_window_fringes): Mark locals as initialized
15116 (Bug#8227).
15117 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15118
524c7aa6
PE
15119 * alloc.c (mark_fringe_data): Move decl from here ...
15120 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15121 to check its interface.
15122 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15123
a5c0af81 15124 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15125 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15126 (fontset_font): Mark local as initialized.
a9a06e0b 15127 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15128
b4716021
PE
15129 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15130
811e9bac 15131 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15132 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15133 (x_own_selection, Fx_disown_selection_internal): Rename locals
15134 to avoid shadowing.
15135 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15136
7e3ab302
PE
15137 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15138 so that the caller can use some name other than gcpro1.
15139 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15140 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15141 (Fx_backspace_delete_keys_p):
15142 Use them to avoid shadowing, and rename vars to avoid shadowing.
15143 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15144 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15145 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15146 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15147 Remove unused locals.
7e3ab302
PE
15148 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15149 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15150 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15151 macros.
f78faa98 15152
e2b13473
PE
15153 * xterm.h (x_mouse_leave): New decl.
15154
77f23912
PE
15155 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15156 Remove unused functions.
cdf4ba58
PE
15157 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15158 (x_calc_absolute_position): Now static.
7411c686 15159 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15160 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15161 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15162 unless they are used.
38d0b34a
PE
15163 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15164 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15165 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15166 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15167 (x_error_catcher, x_connection_closed, x_error_handler):
15168 (x_error_quitter, xembed_send_message, x_iconify_frame):
15169 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15170 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15171 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15172
44f230aa
SM
15173 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15174 Rename or move locals to avoid shadowing.
6b463e58 15175 (tty_defined_color, merge_face_heights): Now static.
5967d051 15176 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15177 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15178 does not deduce is never used uninitialized.
73719eba
PE
15179 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15180 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15181
426994c3 15182 * terminal.c (store_terminal_param): Now static.
5489860b 15183
032f1620 15184 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15185 (set_frame_menubar): Remove unused local.
d4323972 15186 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15187 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15188 since they might point to immutable storage.
281585b0
PE
15189 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15190 since it's unused otherwise.
032f1620 15191
367c19e5 15192 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15193 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15194 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15195 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15196 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15197 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15198 does not deduce are never used uninitialized.
70739cbe 15199
07b48fa9
PE
15200 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15201
8868a238 15202 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15203 * window.c (window_loop, size_window):
15204 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15205
7e5cf297 15206 * window.c (display_buffer): Now static.
d6550a9f
PE
15207 (size_window): Mark variables that gcc -Wuninitialized
15208 does not deduce are never used uninitialized.
a586633d
PE
15209 * window.h (check_all_windows): New decl, to forestall
15210 gcc -Wmissing-prototypes diagnostic.
5b555da1 15211 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15212
f6095868
PE
15213 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15214 shadowing.
15215 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15216 Include <limits.h>.
15217 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15218 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15219 (load_charset_map): Mark variables that gcc -Wuninitialized
15220 does not deduce are never used uninitialized.
53df7c11 15221 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15222
f38b440c
PE
15223 * coding.c (coding_set_source, coding_set_destination):
15224 Use "else { /* comment */ }" rather than "else /* comment */;"
15225 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15226 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15227 a block, when the outer 'i' will do.
15228 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15229 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15230 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15231 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15232 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15233 Rename locals to avoid shadowing.
15234 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15235 * coding.c (emacs_mule_char, encode_invocation_designation):
15236 Now static, since they're not used elsewhere.
413bb2db 15237 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15238 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15239 (decode_coding_emacs_mule): Mark variables that gcc
15240 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15241 (detect_coding_iso_2022): Initialize a local variable that might
15242 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15243 this initialization is needed. (Bug#8211)
5f58e762
PE
15244 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15245 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15246 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15247 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15248 Remove unused macros.
f38b440c 15249
232b38b9 15250 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15251 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15252 * character.c (string_count_byte8): Likewise.
232b38b9 15253
fb90da1b
PE
15254 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15255 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15256
fb93dbc2
PE
15257 * chartab.c (copy_sub_char_table): Now static, since it's not used
15258 elsewhere.
5c156ace
PE
15259 (sub_char_table_ref_and_range, char_table_ref_and_range):
15260 Rename locals to avoid shadowing.
bbcd0949 15261 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15262
7d3b3862 15263 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15264 (BIDI_BOB): Remove unused macro.
7d3b3862 15265
6be7d3da
PE
15266 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15267 deduce are never used uninitialized.
c2ed9c8b 15268 * term.c (encode_terminal_code): Likewise.
6be7d3da 15269
75f8807f 15270 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15271
50938595
PE
15272 * tparam.h: New file.
15273 * term.c, tparam.h: Include it.
15274 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15275 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15276 Move these decls to tparam.h, and make them agree with what
15277 is actually in tparam.c. The previous trick of using incompatible
15278 decls in different modules does not conform to the C standard.
15279 All callers of tparam changed to use tparam's actual API.
15280 * tparam.c (tparam1, tparam, tgoto):
15281 Use const pointers where appropriate.
15282
fbceeba2
PE
15283 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15284 * cm.h (struct cm): Likewise.
15285 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15286 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15287 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15288 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15289 (turn_on_face, init_tty): Likewise.
15290 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15291
7f3f1250
PE
15292 * term.c (term_mouse_position): Rename local to avoid shadowing.
15293
e6ca6543
PE
15294 * alloc.c (mark_ttys): Move decl from here ...
15295 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15296
c40f8d15
AS
152972011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15298
15299 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15300
cfe0661d
JB
153012011-03-09 Juanma Barranquero <lekktu@gmail.com>
15302
15303 * search.c (compile_pattern_1): Remove argument regp, unused since
15304 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15305 (compile_pattern): Don't pass it.
15306
0afb4571
J
153072011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15308
15309 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15310 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15311 for ! HAVE_GTK3.
15312 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15313
15314 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15315
15316 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15317 gdk_window_get_screen, gdk_window_get_geometry,
15318 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15319 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15320 (xg_get_pixbuf_from_pixmap): New function.
15321 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15322 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15323 Call xg_get_pixbuf_from_pixmap instead of
15324 gdk_pixbuf_get_from_drawable.
15325 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15326 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15327 (xg_check_special_colors): Use GtkStyleContext and its functions
15328 for HAVE_GTK3.
15329 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15330 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15331 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15332 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15333 Call gtk_widget_get_preferred_size.
0afb4571
J
15334 (xg_frame_resized): gdk_window_get_geometry only takes 5
15335 parameters.
44f230aa
SM
15336 (xg_win_to_widget, xg_event_is_for_menubar):
15337 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15338 (xg_set_widget_bg): New function.
15339 (delete_cb): New function.
895009e1 15340 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15341 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15342 (xg_set_background_color): Call xg_set_widget_bg.
15343 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15344 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15345 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15346 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15347 if ! HAVE_GTK3.
15348 (update_frame_tool_bar): Call gtk_widget_hide.
15349 (xg_initialize): Use GDK_KEY_g.
15350
15351 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15352 if ! HAVE_GTK3
15353 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15354
15355 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15356 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15357 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15358
1c2cc4ef
JB
153592011-03-08 Juanma Barranquero <lekktu@gmail.com>
15360
15361 * w32xfns.c (select_palette): Check success of RealizePalette against
15362 GDI_ERROR, not zero.
15363
33383987 15364See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15365
15366;; Local Variables:
15367;; coding: utf-8
aac0c6e3
MR
15368;; End:
15369
2f097256 15370 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15371
15372 This file is part of GNU Emacs.
15373
15374 GNU Emacs is free software: you can redistribute it and/or modify
15375 it under the terms of the GNU General Public License as published by
15376 the Free Software Foundation, either version 3 of the License, or
15377 (at your option) any later version.
15378
15379 GNU Emacs is distributed in the hope that it will be useful,
15380 but WITHOUT ANY WARRANTY; without even the implied warranty of
15381 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15382 GNU General Public License for more details.
15383
15384 You should have received a copy of the GNU General Public License
15385 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.