* configure.in: Don't use the -R option (Bug#11251).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
20a68157
EZ
12012-04-17 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (string_buffer_position_lim): Limit starting position to
4 BEGV.
5 (set_cursor_from_row): If called for a mode-line or header-line
6 row, return zero immediately.
7 (try_cursor_movement): If inside continuation line, don't back up
8 farther than the first row after the header line, if any. Don't
9 consider the header-line row as "partially visible", even if
10 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
11
ad3a2b41
AO
122012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
13
14 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
15
e63c261b
CY
162012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
17
18 * process.c (make_process):
19 * process.h: Add integer `gnutls_handshakes_tried' member to
20 process struct.
21
ad3a2b41
AO
22 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
23 Add convenience `GNUTLS_LOG2i' macro.
e63c261b
CY
24
25 * gnutls.c (gnutls_log_function2i): Convenience log function.
26 (emacs_gnutls_read): Use new log functions,
27 `gnutls_handshakes_tried' process member, and
28 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
29 attempts per process (connection).
30
e53357c4
EZ
312012-04-09 Eli Zaretskii <eliz@gnu.org>
32
33 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
34 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
35
aff67c82
JD
362012-04-09 Jan Djärv <jan.h.d@swipnet.se>
37
38 * nsterm.m (constrainFrameRect): Always constrain when there is only
39 one screen (Bug#10962).
40
2f8e16b2
EZ
412012-04-06 Eli Zaretskii <eliz@gnu.org>
42
43 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
44 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
45 about subtle differences between FETCH_CHAR* and STRING_CHAR*
46 macros related to unification of CJK characters. For the details,
47 see the discussion following the message here:
48 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
49
3d439cd1
CY
502012-04-04 Chong Yidong <cyd@gnu.org>
51
52 * keyboard.c (Vdelayed_warnings_list): Doc fix.
53
8bc53d00
EZ
542012-04-01 Eli Zaretskii <eliz@gnu.org>
55
56 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
57 instead of alloca. (Bug#11138)
58
3b0512a3
AS
592012-04-01 Andreas Schwab <schwab@linux-m68k.org>
60
61 * w32menu.c (is_simple_dialog): Properly check lisp types.
62 (Bug#11141)
63
8427ddd2
EZ
642012-03-31 Eli Zaretskii <eliz@gnu.org>
65
979022ef
EZ
66 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
67 position we get to after a call to move_it_to fails the
68 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
69 only if we wind up in a string from display property. (Bug#11063)
70
a6b1c7cc
EZ
71 * window.c (Fdelete_other_windows_internal): Invalidate the row
72 and column information about mouse highlight, so that redisplay
73 restores it after reallocating the glyph matrices. (Bug#7464)
74
8427ddd2
EZ
75 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
76 string comes from a `display' text property, use the buffer
77 position of that property as if we actually saw that position in
78 the row's glyphs.
697ba24b
EZ
79 (move_it_by_lines): Remove the assertion that
80 "it->current_x == 0 && it->hpos == 0" which can be legitimately
81 violated when there's a before-string at the beginning of a line.
82 (Bug#11063)
8427ddd2 83
65a0a738
EZ
842012-03-30 Eli Zaretskii <eliz@gnu.org>
85
86 * xdisp.c (append_space_for_newline): If the default face was
87 remapped, use the remapped face for the appended newline.
88 (extend_face_to_end_of_line): Use the remapped default face for
89 extending the face to the end of the line.
90 (display_line): Call extend_face_to_end_of_line when the default
91 face was remapped. (Bug#11068)
92
581355cc
EZ
932012-03-29 Eli Zaretskii <eliz@gnu.org>
94
95 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
96
e8fc049f
SM
972012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
98
99 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
100
4fb9a543
GM
1012012-03-27 Glenn Morris <rgm@gnu.org>
102
103 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
104 Doc fixes.
105
679910f1
KH
1062012-03-26 Kenichi Handa <handa@m17n.org>
107
108 * dispextern.h (struct glyph): Fix previous change. Change the
109 bit length of glyphless.ch to 25 (Bug#11082).
110
90d49b7f
CY
1112012-03-26 Chong Yidong <cyd@gnu.org>
112
113 * keyboard.c (Vselection_inhibit_update_commands): New variable.
114 (command_loop_1): Use it; inhibit selection update for
115 handle-select-window too (Bug#8996).
116
f514f6f0
FP
1172012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
118
e8fc049f 119 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 120
bf43fa51
KH
1212012-03-25 Kenichi Handa <handa@m17n.org>
122
123 * dispextern.h (struct glyph): Change the bit length of
124 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
125
8a0c01dd
EZ
1262012-03-24 Eli Zaretskii <eliz@gnu.org>
127
128 * s/ms-w32.h (tzname): Include time.h before redirecting to
129 _tzname. Fixes the MSVC build. (Bug#9960)
130
7d1c3a76
AS
1312012-03-24 Andreas Schwab <schwab@linux-m68k.org>
132
8ed79523
AS
133 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
134 characters.
135
7d1c3a76
AS
136 * xterm.c (XTread_socket): Only modify handling_signal if
137 !SYNC_INPUT. (Bug#11080)
138
e99a9b8b
EZ
1392012-03-23 Eli Zaretskii <eliz@gnu.org>
140
141 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
142 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
143 when fetching a multibyte character consumes more bytes than
144 CHAR_BYTES returns, due to unification of CJK characters in
145 string_char. (Bug#11073)
146
5063c0e1
TN
1472012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
148
149 * process.c (wait_reading_process_output): Handle pty disconnect
150 by refraining from sending oneself a SIGCHLD (bug#10933).
151
9f851fbd
CY
1522012-03-22 Chong Yidong <cyd@gnu.org>
153
154 * dispextern.h (struct it): New member string_from_prefix_prop_p.
155
5063c0e1 156 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
157 Mark string as coming from a prefix property.
158 (handle_face_prop): Use default face for prefix strings (Bug#4281).
159 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
160
fb5b8aca
CY
1612012-03-21 Chong Yidong <cyd@gnu.org>
162
163 * xfaces.c (Vface_remapping_alist): Doc fix.
164
62356a1b
EZ
1652012-03-20 Eli Zaretskii <eliz@gnu.org>
166
167 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
168 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
169 Doc fixes.
62356a1b 170
025de85b
CY
1712012-03-20 Chong Yidong <cyd@gnu.org>
172
173 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
174 to reflect default non-nil value of redisplay-dont-pause.
175
4827f94e
KH
1762012-03-19 Kenichi Handa <handa@m17n.org>
177
178 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
179 it fit in a valid range (Bug#11003).
180
e50a24a2
EZ
1812012-03-18 Eli Zaretskii <eliz@gnu.org>
182
183 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
184 that is not from display property, accept the row as a "cursor
185 row" if one of the string's character has a non-nil `cursor'
186 property. Fixes cursor positioning when there are newlines in
187 overlay strings, e.g. in icomplete.el. (Bug#11035)
188
9af5ed87
PE
1892012-03-12 Paul Eggert <eggert@cs.ucla.edu>
190
191 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
192
d1f55f16
CY
1932012-03-12 Chong Yidong <cyd@gnu.org>
194
195 * eval.c (inhibit_lisp_code): Rename from
196 inhibit_window_configuration_change_hook; move from window.c.
197
198 * xfns.c (unwind_create_frame_1, Fx_create_frame):
199 * window.c (run_window_configuration_change_hook)
200 (syms_of_window): Callers changed.
201
66c5eebd
CY
2022012-03-11 Chong Yidong <cyd@gnu.org>
203
413df973
CY
204 * keymap.c (Fkey_description): Doc fix (Bug#9700).
205
66c5eebd
CY
206 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
207
1de11f56
CY
2082012-03-10 Chong Yidong <cyd@gnu.org>
209
210 * frame.c (other_visible_frames): Don't assume the selected frame
211 is visible (Bug#10955).
212
cae07000
SM
2132012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
214
215 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
216
89c94350
JD
2172012-03-08 Jan Djärv <jan.h.d@swipnet.se>
218
219 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
220 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
221 zero (Bug#10954).
222
999dd333
GM
2232012-03-03 Glenn Morris <rgm@gnu.org>
224
01a6dcc8 225 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 226
de0100f2
EZ
2272012-03-02 Eli Zaretskii <eliz@gnu.org>
228
229 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
230 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
231 (redisplay_window, next_element_from_string): Fix typos in
232 comments.
3e441275
EZ
233 (redisplay_window): Pass to move_it_vertically the margin in
234 pixels, not in screen lines.
de0100f2 235
96a72ee9
GM
2362012-03-02 Glenn Morris <rgm@gnu.org>
237
238 * buffer.c (buffer-list-update-hook): Doc fix.
239
312508d7
EZ
2402012-02-29 Eli Zaretskii <eliz@gnu.org>
241
242 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
243 push_it before setting up the iterator for the first overlay
244 string, even if we have an empty string loaded.
245 (next_overlay_string): If there's an empty string on the iterator
246 stack, pop the stack. (Bug#10903)
247
27f3c637
PE
2482012-02-25 Paul Eggert <eggert@cs.ucla.edu>
249
250 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
251 Suggested by Stefan Monnier in
252 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
253 * alloc.c (widen_to_Lisp_Object): New static function.
254 (mark_memory): Also mark Lisp_Objects by fetching pointer words
255 and widening them to Lisp_Objects. This would work even if
256 USE_LSB_TAG is defined and wide integers are used, which might
257 happen in a future version of Emacs.
258
3c9dfce6
CY
2592012-02-25 Chong Yidong <cyd@gnu.org>
260
fa74b241
CY
261 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
262 Doc fix.
263
3c9dfce6
CY
264 * xselect.c (Fx_selection_exists_p): Doc fix.
265 (x_clipboard_manager_save_all): Print an informative message
266 before saving to clipboard manager.
267
9486df08
CY
2682012-02-24 Chong Yidong <cyd@gnu.org>
269
270 * keyboard.c (process_special_events): Handle all X selection
271 requests in kbd_buffer, not just the next one (Bug#8869).
272
f01d3321
CY
2732012-02-23 Chong Yidong <cyd@gnu.org>
274
275 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
276 call when setting menu-bar-lines and tool-bar-lines parameters.
277 (unwind_create_frame_1): New helper function.
278
279 * window.c (inhibit_window_configuration_change_hook): New var.
280 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 281 (syms_of_window): Initialize it.
f01d3321 282
86b847b6
CY
2832012-02-22 Chong Yidong <cyd@gnu.org>
284
285 * xterm.c (x_draw_image_relief): Add missing type check for
286 Vtool_bar_button_margin (Bug#10743).
287
a59225b1
CY
2882012-02-21 Chong Yidong <cyd@gnu.org>
289
290 * fileio.c (Vfile_name_handler_alist): Doc fix.
291
292 * buffer.c (Fget_file_buffer): Protect against invalid file
293 handler return value.
294
310f5bd4
PE
2952012-02-20 Paul Eggert <eggert@cs.ucla.edu>
296
cb3a28cc
PE
297 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
298 when computing $valmask.
299
310f5bd4
PE
300 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
301 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
302 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
303 It's useless in that case, and it can cause problems on hosts
304 that allocate halves of EMACS_INT values separately.
305 Reported by Dan Horák. Diagnosed by Andreas Schwab in
306 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
307 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
308 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
309 it avoids undefined behavior on hosts where shifting right by more
310 than the word width has undefined behavior.
311
2375c96a
CY
3122012-02-19 Chong Yidong <cyd@gnu.org>
313
314 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
315 (Funhandled_file_name_directory, Ffile_name_as_directory)
316 (Fdirectory_file_name, Fexpand_file_name)
317 (Fsubstitute_in_file_name): Protect against invalid file handler
318 return values (Bug#10845).
319
3eb49e71
EZ
3202012-02-18 Eli Zaretskii <eliz@gnu.org>
321
322 * .gdbinit (pitx): Fix incorrect references to fields of the
323 iterator stack.
324
7b926f3f
CY
3252012-02-17 Chong Yidong <cyd@gnu.org>
326
327 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
328
11273115
PE
3292012-02-15 Paul Eggert <eggert@cs.ucla.edu>
330
331 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
332 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
333
c3a70e2b
CY
3342012-02-15 Chong Yidong <cyd@gnu.org>
335
336 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
337 marked as special. Also, starting docstrings with * is obsolete.
338
0ca43699
AS
3392012-02-13 Andreas Schwab <schwab@linux-m68k.org>
340
341 * gnutls.c (emacs_gnutls_write): Fix last change.
342
2e8f3c56
LI
3432012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
344
345 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
346 send_process.
347
af70074f
SM
3482012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
349
350 * keymap.c (Fsingle_key_description): Handle char ranges.
351
95986d52
CY
3522012-02-12 Chong Yidong <cyd@gnu.org>
353
afd83bd1
CY
354 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
355 as that creates a dangerous corner case.
356
95986d52
CY
357 * window.c (Fdelete_window_internal): Invalidate the mouse
358 highlight (Bug#9904).
359
bd7da63e
GM
3602012-02-12 Glenn Morris <rgm@gnu.org>
361
362 * xselect.c (Fx_own_selection_internal)
363 (Fx_get_selection_internal, Fx_disown_selection_internal)
364 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
365 * nsselect.m (Fx_own_selection_internal)
366 (Fx_disown_selection_internal, Fx_selection_exists_p)
367 (Fx_selection_owner_p, Fx_get_selection_internal):
368 Sync docs and argument specs with the xselect.c versions.
369
77abcbc2
LI
3702012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
371
372 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
373
90b671e2
EZ
3742012-02-11 Eli Zaretskii <eliz@gnu.org>
375
1c0ca0b7
EZ
376 * w32select.c (Fx_selection_exists_p): Sync doc string and
377 argument list with xselect.c. (Bug#10783)
378
379 * w16select.c (Fx_selection_exists_p): Sync doc string and
380 argument list with xselect.c. (Bug#10783)
90b671e2 381
49241268
GM
3822012-02-10 Glenn Morris <rgm@gnu.org>
383
384 * fns.c (Fsecure_hash): Doc fix.
385
f998bbe7 3862012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
387
388 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
389
0992bd9c
CY
3902012-02-07 Chong Yidong <cyd@gnu.org>
391
392 * buffer.c (Fbuffer_local_variables)
393 (buffer_lisp_local_variables): Handle unbound vars correctly;
394 don't let Qunbound leak into Lisp.
395
af008560
GM
3962012-02-07 Glenn Morris <rgm@gnu.org>
397
dd605cc4
GM
398 * image.c (Fimagemagick_types): Doc fix.
399
af008560
GM
400 * image.c (imagemagick-render-type): Change it from a lisp object
401 to an integer. Move the doc here from the lisp manual.
402 Treat all values not equal to 0 the same.
403
1449fa1d
CY
4042012-02-06 Chong Yidong <cyd@gnu.org>
405
406 * doc.c (store_function_docstring): Avoid applying docstring of
407 alias to base function (Bug#2603).
408
3723ec07
AS
4092012-02-04 Andreas Schwab <schwab@linux-m68k.org>
410
411 * .gdbinit (pp1, pv1): Remove redundant defines.
412 (pr): Use pp.
413
79c1cc1e
CY
4142012-02-04 Chong Yidong <cyd@gnu.org>
415
416 * nsterm.m: Declare a global (Bug#10694).
417
d7f29f8e
EZ
4182012-02-04 Eli Zaretskii <eliz@gnu.org>
419
cae07000
SM
420 * w32.c (get_emacs_configuration_options):
421 Include --enable-checking, if specified, in the return value.
d7f29f8e 422
3b95a6f9
MR
4232012-02-04 Martin Rudalics <rudalics@gmx.at>
424
425 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
426 after rounding frame sizes. (Bug#9723)
427
d6fa96a6
EZ
4282012-02-04 Eli Zaretskii <eliz@gnu.org>
429
430 * keyboard.c (adjust_point_for_property): Don't position point
431 before BEGV. (Bug#10696)
432
df0b2940
PE
4332012-02-03 Paul Eggert <eggert@cs.ucla.edu>
434
435 Handle overflow when computing char display width (Bug#9496).
436 * character.c (char_width): Return EMACS_INT, not int.
437 (char_width, c_string_width): Check for overflow when
438 computing the width; this is possible now that individual
439 characters can have unbounded width. Problem introduced
440 by merge from Emacs 23 on 2012-01-19.
441
6bee44d6
MA
4422012-02-02 Michael Albinus <michael.albinus@gmx.de>
443
444 * dbusbind.c (Fdbus_register_method): Mention the return value
445 :ignore in the docstring.
446
44f92739
GM
4472012-02-02 Glenn Morris <rgm@gnu.org>
448
1b9f60cc
GM
449 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
450
44f92739
GM
451 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
452 Unconditionally set to t. (Bug#10673)
453 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
454 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
455 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
456
c5d3843c
KH
4572012-02-02 Kenichi Handa <handa@m17n.org>
458
459 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
460 0, do not call append_composite_glyph.
461
159462d4 4622012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
463
464 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
465 NULL (Bug#6988).
466 (x_produce_glyphs): If the component of a composition is a null
467 string, set it->pixel_width to 1 to avoid zero-width glyph.
468
78cef877
EZ
4692012-02-01 Eli Zaretskii <eliz@gnu.org>
470
471 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
472 first 2 arguments are identical. This makes inserting large
473 output from a subprocess an order of magnitude faster on
474 MS-Windows, where all sbrk'ed memory is always contiguous.
475
97897668
GM
4762012-01-31 Glenn Morris <rgm@gnu.org>
477
478 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 479 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
480 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
481
31fd3586
GM
4822012-01-29 Glenn Morris <rgm@gnu.org>
483
484 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
485
0e24a8b2
CY
4862012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
487
488 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
489
cc0adcb0
CY
4902012-01-28 Chong Yidong <cyd@gnu.org>
491
492 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
493
acc28cb9
CY
4942012-01-26 Chong Yidong <cyd@gnu.org>
495
9c69cfb7
CY
496 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
497
acc28cb9
CY
498 * search.c (Fsearch_forward, Fsearch_backward): Document negative
499 repeat counts (Bug#10507).
500
48da7392
GM
5012012-01-26 Glenn Morris <rgm@gnu.org>
502
503 * lread.c (syms_of_lread): Doc fix.
504
14af5f7f
CY
5052012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
506
507 * coding.c (encode_designation_at_bol): Change return value to
508 EMACS_INT.
509
0b21c100
CY
5102012-01-25 Chong Yidong <cyd@gnu.org>
511
512 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
513
3c2907f7
CY
5142012-01-21 Chong Yidong <cyd@gnu.org>
515
516 * floatfns.c (Fcopysign): Make the second argument non-optional,
517 since nil is not allowed anyway.
518
959ad23f
AS
5192012-01-21 Andreas Schwab <schwab@linux-m68k.org>
520
521 * process.c (read_process_output): Use p instead of XPROCESS (proc).
522 (send_process): Likewise.
523
34a02f46
MR
5242012-01-19 Martin Rudalics <rudalics@gmx.at>
525
526 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
527 (Vwindow_persistent_parameters): Do not use Qstate.
528 Rewrite doc-strings.
34a02f46 529
1259009a 5302012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
531
532 * character.c (char_width): New function.
70d4fdf6
GM
533 (Fchar_width, c_string_width, lisp_string_width):
534 Use char_width (Bug#9496).
25ed9e61 535
6a6ee00d
MR
5362012-01-16 Martin Rudalics <rudalics@gmx.at>
537
538 * window.c (Vwindow_persistent_parameters): New variable.
539 (Fset_window_configuration, save_window_save): Handle persistent
540 window parameters.
541
c85efaf7
EZ
5422012-01-14 Eli Zaretskii <eliz@gnu.org>
543
544 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
545 thrashing the stack of the thread. (Bug#9087)
546
5944709e
PE
5472012-01-12 Paul Eggert <eggert@cs.ucla.edu>
548
549 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
550
e71f5d99
EZ
5512012-01-11 Eli Zaretskii <eliz@gnu.org>
552
553 * xdisp.c (rows_from_pos_range): Handle the case where the
554 highlight ends on a newline. (Bug#10464)
555 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
556 he end column for display of highlight that ends on a newline
557 before a R2L line.
558
ce316182
GM
5592012-01-11 Glenn Morris <rgm@gnu.org>
560
561 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
562 from load-path also when installation-directory is nil. (Bug#10208)
563
5b43da69
GM
5642012-01-10 Glenn Morris <rgm@gnu.org>
565
74cc8ff9
GM
566 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
567
7d8d6e4e
GM
568 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
569 Update template values to be closer to their typical values these days.
5b43da69 570
a0db8d43
EZ
5712012-01-09 Eli Zaretskii <eliz@gnu.org>
572
573 * xdisp.c (rows_from_pos_range): Accept additional argument
574 DISP_STRING, and accept any glyph in a row whose object is that
575 string as eligible for mouse highlight. Fixes mouse highlight of
576 display strings from overlays. (Bug#10464)
577
9a0115ab 5782012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 579
b9110d6a 580 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
581 * fileio.c (auto_saving_dir_umask): New static var.
582 (Fmake_directory_internal): Use it.
583 (do_auto_save_make_dir): Set it, instead of invoking chmod after
584 creating the directory. The old code temporarily assigns
585 too-generous permissions to the directory.
586 (do_auto_save_eh): Clear it.
b9110d6a 587 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
588 that the var is always cleared.
589
6c1bd3f3
EZ
5902012-01-07 Eli Zaretskii <eliz@gnu.org>
591
592 * search.c (scan_buffer): Pass character positions to
593 know_region_cache, not byte positions. (Bug#6540)
594
069d2b50
L
5952012-01-07 LynX <_LynX@bk.ru> (tiny change)
596
597 * w32.c (sys_rename): Report EXDEV when rename of a directory
598 fails because the target is on another logical disk. (Bug#10284)
599
75bf0d33
DB
6002012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
601
602 * xterm.c (x_embed_request_focus): New function.
603
604 * xterm.h: Add prototype.
605
606 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
607
1c6e5a32
GM
6082012-01-05 Glenn Morris <rgm@gnu.org>
609
610 * emacs.c (emacs_copyright): Update short copyright year to 2012.
611
651e947e
EZ
6122012-01-01 Eli Zaretskii <eliz@gnu.org>
613
614 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
615 Load gnutls_transport_set_lowat only if GnuTLS version is below
616 2.11.1.
617 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
618 GnuTLS versions below 2.11.1.
619
3778cdd8
AL
6202011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
621
622 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
623 to the doc string advising against its use for altering the way
624 windows are scrolled.
625
0e5317f7
KH
6262011-12-28 Kenichi Handa <handa@m17n.org>
627
628 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
629 coding-system ASCII compatible only when it does not produce BOM
630 on encoding (Bug#10383).
631
93d5ca1f
JD
6322011-12-26 Jan Djärv <jan.h.d@swipnet.se>
633
634 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
635 can scroll.
636 (create_and_show_popup_menu): Always use menu_position_func for
637 Gtk3 (Bug#10361).
638
ca22b785
AS
6392011-12-24 Andreas Schwab <schwab@linux-m68k.org>
640
641 * callint.c (Fcall_interactively): Don't truncate prompt string.
642
d048e1e6
EZ
6432011-12-23 Eli Zaretskii <eliz@gnu.org>
644
645 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
646 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 647 resumed from there (after widening). (Bug#10360)
d048e1e6 648
5ccaba1f
JD
6492011-12-22 Jan Djärv <jan.h.d@swipnet.se>
650
651 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
652
204ee57f
JD
6532011-12-21 Jan Djärv <jan.h.d@swipnet.se>
654
b81d40f0
JB
655 * nsterm.m (x_free_frame_resources):
656 Release f->output_data.ns->miniimage.
204ee57f
JD
657 (ns_index_color): Fix indentation. Do not retain
658 color_table->colors[i].
659
660 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
661 before returning.
662
663 * nsfns.m (x_set_background_color): Assign return value from
664 ns_index_color to face-background instead of NSColor*.
665 (ns_implicitly_set_icon_type): Fix indentation.
666 Change assignment in for loop to comparison.
667
668 * emacs.c (ns_pool): New variable.
669 (main): Assign ns_pool.
670 (Fkill_emacs): Call ns_release_autorelease_pool.
671
672 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
673 autorelease fdesc, release fdAttrs and tdict.
674 (ns_get_covering_families): Release charset.
675 (ns_findfonts): Release NSFontDescriptor created with new.
676 (ns_uni_to_glyphs): Fix indentation.
677 (setString): Release attrStr before assigning new value.
678
c803b2b7
JD
6792011-12-18 Jan Djärv <jan.h.d@swipnet.se>
680
678f4426
JD
681 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
682 and NS_IMPL_COCOA.
683 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
684 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
685
cd394be1 6862011-12-18 David Reitter <reitter@cmu.edu>
678f4426 687
5fecd5fc
JD
688 * nsterm.m (ns_term_init): Subscribe for notifications
689 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
690 to method trackingNotification in EmacsMenu.
691
692 * nsmenu.m (trackingMenu): New variable.
3771cb17 693 (trackingNotification): New method (from Aquamacs).
5fecd5fc 694 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 695 from Aquamacs (Bug#7030).
678f4426
JD
696
6972011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 698
c803b2b7
JD
699 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
700 (symbol_to_nsstring): Fix indentation.
701 (ns_symbol_to_pb): New function.
cae07000
SM
702 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
703 (Fns_rotate_cut_buffers_internal): Remove.
704 (Fns_store_selection_internal): Rename from
c803b2b7
JD
705 Fns_store_cut_buffer_internal.
706 (ns_get_foreign_selection, Fx_own_selection_internal)
707 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
708 (Fns_get_selection_internal, Fns_store_selection_internal):
709 Use ns_symbol_to_pb and check if return value is nil.
710 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
711 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
712 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
713 renamed to Sns_store_selection_internal.
714 (ns_handle_selection_request): Move code to Fx_own_selection_internal
715 and remove this function.
716 (ns_handle_selection_clear): Remove, never used.
717 (Fx_own_selection_internal): Move code from ns_handle_selection_request
718 here.
719
e1b01a3a
KB
7202011-12-17 Ken Brown <kbrown@cornell.edu>
721
722 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
723 GID is unknown (Bug#10257).
724
2adb6e85
PE
7252011-12-17 Paul Eggert <eggert@cs.ucla.edu>
726
727 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
728 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
729 which caused a build failure on GNU/Linux IA-64. This problem was
730 introduced by my 2011-10-07 patch.
731
d1d7b339
JL
7322011-12-15 Juri Linkov <juri@jurta.org>
733
734 * image.c (imagemagick_error): New function. (Bug#10112)
735 (imagemagick_load_image): Comment out `MagickSetResolution' call.
736 Use `imagemagick_error' where ImageMagick functions return
737 `MagickFalse'.
738 (Fimagemagick_types): Add `Fnreverse' to return the list in the
739 proper order.
740
100d5755
KH
7412011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
742
743 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
744 fill background (Bug#8992).
745
454592a6
MR
7462011-12-13 Martin Rudalics <rudalics@gmx.at>
747
748 * window.c (Vwindow_combination_resize)
749 (Vwindow_combination_limit): Use t instead of non-nil in
750 doc-strings.
61d4b438
MR
751 (Vrecenter_redisplay): Add first sentence of doc-string on
752 separate line.
53524d93 753 (Frecenter): Fix doc-string typo.
454592a6 754
3633e3aa
KH
7552011-12-11 Kenichi Handa <handa@m17n.org>
756
757 * coding.c (Funencodable_char_position): Pay attention to the
758 buffer text relocation (Bug#9389).
759
7b9d523a
JD
7602011-12-10 Jan Djärv <jan.h.d@swipnet.se>
761
762 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
763 gtk_init (Bug#10100).
764
b73189c6
EZ
7652011-12-10 Eli Zaretskii <eliz@gnu.org>
766
767 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
768 IT->string is nil. (Bug#10263)
769
f7dfe5d6
JD
7702011-12-10 Jan Djärv <jan.h.d@swipnet.se>
771
83faebb4
JD
772 * nsterm.h (x_free_frame_resources): Declare.
773
f7dfe5d6
JD
774 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
775 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
776
777 * nsterm.h (ns_get_defaults_value): Declare.
778
779 * nsterm.m (ns_default): Call ns_get_defaults_value.
780
7cd4e72c
EZ
7812011-12-09 Eli Zaretskii <eliz@gnu.org>
782
783 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
784 (Bug#10170)
785
b34d7317
YM
7862011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
787
788 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
789 that where the value of an _OBJC_* symbol points to is in the .bss
790 section (Bug#10240).
791
76470ad1
KH
7922011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
793
794 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 795 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 796
745fff94
KH
7972011-12-08 Kenichi Handa <handa@m17n.org>
798
799 * ftfont.c (get_adstyle_property): Fix previous change
800 (Bug#10233).
801
6e44397c
JB
8022011-12-07 Juanma Barranquero <lekktu@gmail.com>
803
804 * w32.c (init_environment): If no_site_lisp, remove site-lisp
805 dirs from the default value of EMACSLOADPATH (bug#10208).
806
7efa6272
GM
8072011-12-07 Glenn Morris <rgm@gnu.org>
808
809 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
810 installation and source directories as well. (Bug#10208)
811
f6fc4d87
CY
8122011-12-06 Chong Yidong <cyd@gnu.org>
813
814 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
815
2bf26180
GM
8162011-12-06 Glenn Morris <rgm@gnu.org>
817
818 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
819 as an error, not just -1. (Bug#10217)
820
3a6ad4f0
CY
8212011-12-05 Chong Yidong <cyd@gnu.org>
822
823 * keyboard.c (process_special_events): New function.
824 (swallow_events, Finput_pending_p): Use it (Bug#10195).
825
75a3b399
PE
8262011-12-05 Paul Eggert <eggert@cs.ucla.edu>
827
828 * coding.c (encode_designation_at_bol): Don't use uninitialized
829 local variable (Bug#9318).
830
c3c9e25e
KH
8312011-12-05 Kenichi Handa <handa@m17n.org>
832
833 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
834 return Qnil (Bug#8046, Bug#10193).
835
5eb05ea3
KH
8362011-12-05 Kenichi Handa <handa@m17n.org>
837
838 * coding.c (encode_designation_at_bol): New args charbuf_end and
839 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
840 (coding_set_source): Return how many bytes coding->source was
841 relocated.
842 (coding_set_destination): Return how many bytes
843 coding->destination was relocated.
844 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 845 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
846
8472011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
848
849 * coding.c (CODING_CHAR_CHARSET_P): New macro.
850 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
851 macro (Bug#9318).
852
8532011-12-05 Andreas Schwab <schwab@linux-m68k.org>
854
855 The following changes are to fix Bug#9318.
856
a79703f5 857 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
858 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
859 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 860 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 861
7dbda6df
JB
8622011-12-05 Juanma Barranquero <lekktu@gmail.com>
863
864 * lisp.h (process_quit_flag): Fix external declaration.
865
6d5eb5b0
SM
8662011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
867
868 Don't macro-inline non-performance-critical code.
869 * eval.c (process_quit_flag): New function.
870 * lisp.h (QUIT): Use it.
871
a0c3fad0
JD
8722011-12-04 Jan Djärv <jan.h.d@swipnet.se>
873
874 * nsfns.m (get_geometry_from_preferences): New function.
875 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
876
6c07aac2
AS
8772011-12-04 Andreas Schwab <schwab@linux-m68k.org>
878
879 * emacs.c (Qkill_emacs): Define.
880 (syms_of_emacs): Initialize it.
881 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
882 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
883 (quit_throw_to_read_char): Add parameter `from_signal'.
884 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
885 * lisp.h (QUIT): Call Fkill_emacs if requested.
886
c052ead4
JD
8872011-12-03 Jan Djärv <jan.h.d@swipnet.se>
888
889 * widget.c (update_wm_hints): Return if wmshell is null.
890 (widget_update_wm_size_hints): New function.
891
892 * widget.h (widget_update_wm_size_hints): Declare.
893
894 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
895 widget_update_wm_size_hints (Bug#10104).
896
9e49252b
EZ
8972011-12-03 Eli Zaretskii <eliz@gnu.org>
898
899 * xdisp.c (handle_invisible_prop): If the invisible text ends just
900 before a newline, prepare the bidi iterator for consuming the
901 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 902 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 903
02b16839
JL
9042011-12-02 Juri Linkov <juri@jurta.org>
905
906 * search.c (Fword_search_regexp): New Lisp function created from
907 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
908 (Fword_search_backward, Fword_search_forward)
909 (Fword_search_backward_lax, Fword_search_forward_lax):
910 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
911 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
912
0068070e
SM
9132011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
914
915 * fileio.c (Finsert_file_contents): Move after-change-function call
916 to before the "handled:" label, since all "goto handled" appear in
917 cases where the *-change-functions have already been properly called
918 (bug#10117).
919
3360a3fc
AS
9202011-12-01 Andreas Schwab <schwab@linux-m68k.org>
921
922 * keyboard.c (interrupt_signal): Don't call kill-emacs when
923 waiting for input. (Bug#10169)
924
73d6c093
EZ
9252011-11-30 Eli Zaretskii <eliz@gnu.org>
926
927 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
928 verifies glyph row's hash code--we have just reallocated the
929 glyphs, so their contents can be complete garbage. (Bug#10164)
930
febe6bea
JB
9312011-11-30 Juanma Barranquero <lekktu@gmail.com>
932
933 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
934
801a4313
EZ
9352011-11-30 Eli Zaretskii <eliz@gnu.org>
936
937 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
938 attributes are tested _before_ calling verify_row_hash, to protect
939 against GCC re-ordering of the tests. (Bug#10164)
940
2b56b87e
JD
9412011-11-29 Jan Djärv <jan.h.d@swipnet.se>
942
943 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
944
945 * xterm.c (handle_one_xevent): Only set async_visible and friends
946 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 947 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
948 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
949
dbf31225
PE
9502011-11-28 Paul Eggert <eggert@cs.ucla.edu>
951
952 Remove GCPRO-related macros that exist only to avoid shadowing locals.
953 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
954 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
955 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
956 All uses changed to use GCPRO1 etc.
957 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
958 Revert to old implementation (i.e., before 2011-03-11).
959
1305621b
YM
9602011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
961
962 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
963 of scroll runs so as to avoid assigning disabled bogus rows and
964 unnecessary graphics copy operations.
965
8c9afb46
EZ
9662011-11-27 Eli Zaretskii <eliz@gnu.org>
967
968 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
969 (snprintf) [_MSC_VER]: Redirect to _snprintf.
970 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
971 (malloc, free, realloc, calloc): Redirect to e_* only when
972 compiling Emacs.
973
974 * lisp.h (GCTYPEBITS): Move before first use.
975 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
976 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
977 this macro definition.
978
979 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
980 _MSC_VER.
981
54e9e3bf
JD
9822011-11-27 Jan Djärv <jan.h.d@swipnet.se>
983
6d5eb5b0
SM
984 * gtkutil.c (xg_create_frame_widgets):
985 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
986 present with Gtk+ 2.0.
987
83aca1cb
PE
9882011-11-26 Paul Eggert <eggert@cs.ucla.edu>
989
990 * fileio.c (Finsert_file_contents): Undo previous change; see
991 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
992
5b76caa4
PE
9932011-11-26 Paul Eggert <eggert@cs.ucla.edu>
994
995 Rename locals to avoid shadowing.
996 * fileio.c (Finsert_file_contents):
997 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
998 * process.c (wait_reading_process_output):
999 Rename inner 'proc' to 'p' to avoid shadowing.
1000 Indent for consistency with usual Emacs style.
1001
8c535114
EZ
10022011-11-25 Eli Zaretskii <eliz@gnu.org>
1003
1004 * xdisp.c (redisplay_window): If cursor row is not fully visible
1005 after recentering, and scroll-conservatively is set to a large
1006 number, scroll window by a few more lines to make the cursor fully
1007 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1008 (start_display): Don't move to the next line if the display should
1009 start at a newline that is part of a display vector or an overlay
1010 string. (Bug#10119)
8c535114 1011
fa4fdb5c
JL
10122011-11-24 Juri Linkov <juri@jurta.org>
1013
1014 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1015 after the `MagickPingImage' call. (Bug#10112)
1016
90ec88df
CY
10172011-11-23 Chong Yidong <cyd@gnu.org>
1018
1019 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1020
56e2e794
MR
10212011-11-23 Martin Rudalics <rudalics@gmx.at>
1022
1023 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1024 making another buffer current. (Bug#10114)
1025
b6e64c41
GM
10262011-11-23 Glenn Morris <rgm@gnu.org>
1027
1028 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1029
6b21de18
CY
10302011-11-23 Chong Yidong <cyd@gnu.org>
1031
1032 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1033 using it (Bug#5984).
1034
b12cd789
EZ
10352011-11-22 Eli Zaretskii <eliz@gnu.org>
1036
1037 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1038 and header-lines, as they don't have one computed for them.
1039 (Bug#10098)
1040
1041 * .gdbinit (prow): Make displayed values more self-explaining.
1042 Add row's hash code.
1043
261b6fd4
LMI
10442011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1045
1046 * process.c (wait_reading_process_output): Fix asynchrounous
1047 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1048 (wait_reading_process_output): Add comment and URL.
261b6fd4 1049
e7cfd277
JD
10502011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1051
1052 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1053
a9b9b7f5
CY
10542011-11-21 Chong Yidong <cyd@gnu.org>
1055
1056 * window.c (Fnext_window, Fprevious_window): Doc fix.
1057
b0d15b4f
SM
10582011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1059
1060 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1061
fe7a3057
JB
10622011-11-20 Juanma Barranquero <lekktu@gmail.com>
1063
1064 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1065
d2999b1a
MR
10662011-11-20 Martin Rudalics <rudalics@gmx.at>
1067
1068 * window.c (Fset_window_combination_limit): Rename argument
1069 STATUS to LIMIT.
1070 (Vwindow_combination_limit): Remove "status" from doc-string.
1071
d5ff9cd0
AS
10722011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1073
1074 * m/ibms390.h: Remove.
1075 * m/ibms390x.h: Don't include "ibms390.h".
1076
a5bb9bd3
SM
10772011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1078
1079 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1080 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1081
cd1181db
JB
10822011-11-20 Juanma Barranquero <lekktu@gmail.com>
1083
1084 * casetab.c (Fset_case_table):
1085 * charset.c (Fcharset_after): Fix typos.
1086
615a3b8d 10872011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1088
17e845af
PE
1089 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1090 Otherwise, valgrind does not work on some platforms.
1091 Problem reported by Andreas Schwab in
6a0bf43d
PE
1092 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1093 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1094 is set, removing the need for VIRT_ADDRESS_VARIES.
1095 (PURE_P): Use a more-efficient implementation that needs just one
1096 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1097 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1098 to 4 (xorl, subq, cmpq, setbe).
1099 * alloc.c (pure): Always extern now, since that's the
1100 VIRT_ADDR_VARIES behavior.
1101 (PURE_POINTER_P): Use a single comparison, not two, for
1102 consistency with the new puresize.h.
1103 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1104 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1105 Remove VIRT_ADDR_VARIES no longer needed.
1106
f8fe6f96
EZ
11072011-11-19 Eli Zaretskii <eliz@gnu.org>
1108
1109 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1110 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1111 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1112 behave as if the cursor position were at the window margin.
1113
1114 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1115 and the cursor position is out of bounds, behave as if the cursor
1116 position were at the window margin. (Bug#10075)
1117
df05a53c
CY
11182011-11-18 Chong Yidong <cyd@gnu.org>
1119
1120 * window.c (Fwindow_combination_limit): Make first argument
1121 non-optional, since it is meaningless for live windows like the
1122 selected window.
1123
2071918e
DA
11242011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1125
1126 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1127
b50a28de
SM
11282011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1129
1130 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1131 (graft_intervals_into_buffer): Simplify.
1132
015137db
EZ
11332011-11-18 Eli Zaretskii <eliz@gnu.org>
1134
1135 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1136 hash values of the two rows.
1137 (copy_row_except_pointers): Preserve the used[] arrays and the
1138 hash values of the two rows. (Bug#10035)
68c95424 1139 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1140
1141 * xdisp.c (row_hash): New function, body extracted from
1142 compute_line_metrics.
1143 (compute_line_metrics): Call row_hash, instead of computing the
1144 hash code inline.
1145
1146 * dispnew.c (verify_row_hash): Call row_hash for computing the
1147 hash code of a row, instead of duplicating code from xdisp.c.
1148
1149 * dispextern.h (row_hash): Add prototype.
1150
a2addb04
TH
11512011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1152
1153 * frame.c (delete_frame): Don't delete the terminal when the last
1154 X frame is closed if emacs is built with GTK toolkit.
1155
df85d315
JB
11562011-11-17 Juanma Barranquero <lekktu@gmail.com>
1157
1158 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1159
a0c2d0ae
MR
11602011-11-17 Martin Rudalics <rudalics@gmx.at>
1161
1162 * window.c (Vwindow_splits): Rename to
1163 Vwindow_combination_resize. Suggested by Juri Linkov.
1164 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1165 of Vwindow_splits.
1166
58179cce
JB
11672011-11-16 Juanma Barranquero <lekktu@gmail.com>
1168
7877f373
JB
1169 * nsfns.m (Fns_font_name):
1170 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1171
b6f67890
MR
11722011-11-16 Martin Rudalics <rudalics@gmx.at>
1173
1174 * window.h (window): Rename slot "nest" to "combination_limit".
1175 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1176 (Fset_window_nest): Rename to Fset_window_combination_limit.
1177 (Vwindow_nest): Rename to Vwindow_combination_limit.
1178 (recombine_windows, make_parent_window, make_window)
1179 (Fsplit_window_internal, saved_window)
1180 (Fset_window_configuration, save_window_save): Rename all
1181 occurrences of window_nest to window_combination_limit.
1182
c7015153
JB
11832011-11-15 Juanma Barranquero <lekktu@gmail.com>
1184
1185 * image.c (imagemagick_load_image): Fix typo.
1186
322ad6ec
EZ
11872011-11-14 Eli Zaretskii <eliz@gnu.org>
1188
1189 * xdisp.c (display_line): Move the call to
1190 highlight_trailing_whitespace before the call to
1191 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1192 faces of all the glyphs to compute ROW's hash value.
1193 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1194
f067b8ec
JB
11952011-11-14 Juanma Barranquero <lekktu@gmail.com>
1196
1197 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1198 just return (bug#10044).
1199
1e5b2111
EZ
12002011-11-12 Eli Zaretskii <eliz@gnu.org>
1201
7ef3cbd5
EZ
1202 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1203 with user-defined heap size. Bump the default size of the temacs
1204 heap to 27MB, to avoid memory warning when running temacs.
1205 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1206
1e5b2111
EZ
1207 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1208 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1209 (verify_row_hash) [XASSERTS]: New function.
1210 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1211 that the hash value of glyph rows is correct.
1e5b2111 1212
89d61221
MR
12132011-11-12 Martin Rudalics <rudalics@gmx.at>
1214
1215 * window.h (window): Remove splits slot.
1216 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1217 (Fdelete_other_windows_internal, make_parent_window)
1218 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1219 (Fset_window_configuration, save_window_save): Don't deal with
1220 split status of windows.
1221 (saved_window): Remove splits slot.
1222 (Vwindow_splits): Rewrite doc-string.
1223
97f18cc8
JD
12242011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1225
1226 * xfns.c (unwind_create_frame):
1227 * nsfns.m (unwind_create_frame):
1228 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1229 Vframe_list (Bug#9999).
1230
22a648b4
DA
12312011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1232
0b381c7e 1233 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1234
659afede
KH
12352011-11-11 Kenichi Handa <handa@m17n.org>
1236
1237 * callproc.c (Fcall_process): Set the member dst_multibyte of
1238 process_coding.
1239
9ac0394b
KH
12402011-11-11 Johan Bockgård <bojohan@gnu.org>
1241
1242 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1243 avoid a crash (bug#9496).
1244
2fbdc249
CY
12452011-11-09 Chong Yidong <cyd@gnu.org>
1246
1247 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1248 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1249
ac6b1f81
PE
12502011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1251
1252 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1253
09db192c
PE
12542011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1255
1256 Avoid some portability problems by eschewing 'extern inline' functions.
1257 The trivial performance wins aren't worth the portability hassles; see
1258 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1259 et seq.
1260 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1261 (window_box_width, window_box_left, window_box_left_offset)
1262 (window_box_right, window_box_right_offset): Undo previous change,
1263 by removing the "extern"s.
1264 * intervals.c (adjust_intervals_for_insertion)
1265 (adjust_intervals_for_deletion): Undo previous change,
1266 making these static again.
1267 (offset_intervals, temp_set_point_both, temp_set_point)
1268 (copy_intervals_to_string): No longer inline.
1269 * xdisp.c (window_text_bottom_y, window_box_width)
1270 (window_box_height, window_box_left_offset)
1271 (window_box_right_offset, window_box_left, window_box_right)
1272 (window_box): No longer inline.
1273
105216ed
CY
12742011-11-08 Chong Yidong <cyd@gnu.org>
1275
1276 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1277 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1278 Signal an error if not a live window.
105216ed
CY
1279 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1280 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1281
ae9e237f
JB
12822011-11-07 Juanma Barranquero <lekktu@gmail.com>
1283
1284 * lisp.h (syms_of_abbrev): Remove declaration.
1285 Reported by CHENG Gao <chenggao@royau.me>.
1286
c7aa8333
EZ
12872011-11-07 Eli Zaretskii <eliz@gnu.org>
1288
1289 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1290 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1291 of temacs in GUI mode.
1292
be7f5545
MR
12932011-11-07 Martin Rudalics <rudalics@gmx.at>
1294
1295 * window.h: Declare delete_all_child_windows instead of
1296 delete_all_subwindows.
1297 * window.c (Fwindow_nest, Fset_window_nest)
1298 (Fset_window_new_total, Fset_window_new_normal)
1299 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1300 (delete_all_subwindows): Rename to delete_all_child_windows.
1301 (Fdelete_other_windows_internal, Fset_window_configuration):
1302 Call delete_all_child_windows instead of delete_all_subwindows.
1303 * frame.c (delete_frame): Call delete_all_child_windows instead
1304 of delete_all_subwindows.
1305
ca78dc43
PE
13062011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1307
1308 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1309 This is also needed for porting to any host where GC_MARK_STACK is
1310 not GC_MAKE_GCPROS_NOOPS.
1311 (which_symbols): Use it.
1312
a0241d01
KH
13132011-11-07 Kenichi Handa <handa@m17n.org>
1314
1315 * coding.c (coding_set_destination): Check coding->src_pos only
1316 when coding->src_object is a buffer (bug#9910).
1317
1318 * process.c (send_process): Set the member src_multibyte of coding
1319 to 0 (bug#9911) when sending a unibyte text.
1320
1321 * callproc.c (Fcall_process): Set the member src_multibyte of
1322 process_coding to 0 (bug#9912).
1323
a64bfdfa 13242011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1325
1326 * xmenu.c (cleanup_widget_value_tree): New function.
1327 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1328 calling free_menubar_widget_value_tree directly (Bug#9830).
1329
cb41b32a
PE
13302011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1331
1332 Fix some portability problems with 'inline'.
1333 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1334 (window_box_width, window_box_left, window_box_left_offset)
1335 (window_box_right, window_box_right_offset): Declare extern.
1336 Otherwise, these inline functions do not conform to C99 and
1337 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1338 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1339 * intervals.c (adjust_intervals_for_insertion)
1340 (adjust_intervals_for_deletion): Now extern, because otherwise the
1341 extern inline functions 'offset_intervals' couldn't refer to it.
1342 (static_offset_intervals): Remove.
1343 (offset_intervals): Rewrite using the old contents of
1344 static_offset_intervals. The old version didn't conform to C99
1345 because an extern inline function contained a reference to an
1346 identifier with static linkage.
1347
b7041366
AS
13482011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1349
1350 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1351 GC.
1352
88a37c4d
EZ
13532011-11-06 Eli Zaretskii <eliz@gnu.org>
1354
1355 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1356 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1357 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1358 return Qleft_to_right.
1359
49745b39
CY
13602011-11-06 Chong Yidong <cyd@gnu.org>
1361
1362 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1363 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1364 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1365 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1366 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1367 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1368 (Fwindow_vscroll): Doc fix.
1369 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1370 argument, since it makes no sense to pass a live window and for
1371 consistency with window-child.
1372
1f05cd82
CS
13732011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1374
1375 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1376 support MSVC.
1377
22610910
JR
13782011-11-05 Jason Rumney <jasonr@gnu.org>
1379
1380 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1381 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1382 fonts (Bug#6029).
1383 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1384 bitwise arithmetic preventing use of unicode-sip and non-truetype
1385 opentype fonts.
1386
a06776b2
EZ
13872011-11-05 Eli Zaretskii <eliz@gnu.org>
1388
3ad924ba
EZ
1389 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1390 "emacs"-only part.
1391
a06776b2
EZ
1392 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1393 initialization code to keep similarity to xfns.c after changes
1394 from 2011-11-05.
1395
c9e7db78
JD
13962011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1397
a97f8f3f
JD
1398 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1399 (unwind_create_frame): New function (Bug#9943).
1400 (Fx_create_frame): Restructure code to be more similar to the one in
1401 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1402 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1403 Move terminal->reference_count++ just before making the frame official
1404 (Bug#9943).
1405
1406 * nsterm.m (x_free_frame_resources): New function.
1407 (x_destroy_window): Move code to x_free_frame_resources.
1408
c9e7db78 1409 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1410 (Fx_create_frame, x_create_tip_frame):
1411 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1412 official. Move initialization of image_cache_refcount and
1413 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1414
a6fc3b5c
EZ
14152011-11-05 Eli Zaretskii <eliz@gnu.org>
1416
1417 Support MSVC build with newer versions of Visual Studio.
1418 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1419 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1420 nt/gmake.defs.
1421
1422 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1423 which are not supported by MSVC.
1424 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1425 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1426 bitfields.
1427 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1428 types in bitfields.
1429 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1430
1431 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1432
58179cce 14332011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1434
1435 Support MSVC build with newer versions of Visual Studio.
1436 * w32.c: Don't include w32api.h for MSVC.
1437 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1438
1439 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1440 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1441 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1442 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1443 e_* cousins.
1444 (alloca) [_MSC_VER]: Define to _alloca.
1445
1446 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1447
1448 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1449
a58c13ed
EZ
14502011-11-04 Eli Zaretskii <eliz@gnu.org>
1451
1452 * xdisp.c (note_mouse_highlight): If either of
1453 previous/next-single-property-change returns nil, treat that as
1454 the beginning or the end of the buffer. (Bug#9955)
1455
fe0b6370
JD
14562011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1457
a58c13ed 1458 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1459 label is not null (Bug#9951).
1460 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1461 may be NULL.
1462
89bd5ee1
EZ
14632011-11-04 Eli Zaretskii <eliz@gnu.org>
1464
1465 * window.c (Fwindow_body_size): Mention in the doc string that the
1466 return value is in frame's canonical units. (Bug#9949)
1467
84c3edb9
EZ
14682011-11-03 Eli Zaretskii <eliz@gnu.org>
1469
4e2fb5c7
EZ
1470 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1471
84c3edb9 1472 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1473 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1474 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1475
bc17a887
EZ
14762011-11-01 Eli Zaretskii <eliz@gnu.org>
1477
1478 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1479 Don't stop backward scan on the continuation glyph, even though
1480 its CHARPOS is positive.
6d5eb5b0
SM
1481 (mouse_face_from_buffer_pos, note_mouse_highlight):
1482 Rename cover_string to disp_string.
bc17a887 1483
4ee88440
MR
14842011-11-01 Martin Rudalics <rudalics@gmx.at>
1485
1486 * window.c (temp_output_buffer_show): Don't use
1487 Vtemp_buffer_show_specifiers.
1488 (Vtemp_buffer_show_specifiers): Remove unused variable.
1489
c2ff3c02
EZ
14902011-10-30 Eli Zaretskii <eliz@gnu.org>
1491
1492 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1493 past the beginning of the current glyph matrix.
1494
58179cce 14952011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1496
1497 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1498 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1499 HAVE_GTK3 (Bug#9869).
b77a6a7f 1500
3b574623
JD
1501 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1502 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1503
b77a6a7f
JD
1504 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1505
1506 * xterm.c: Declare x_handle_net_wm_state to return int.
1507 (handle_one_xevent): Check if we are iconified but don't have
1508 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1509 (get_current_wm_state): Return non-zero if not hidden,
1510 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1511 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1512 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1513 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1514
196e41e4
PE
15152011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1516
1517 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1518 so that this new function doesn't get optimized away by a
1519 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1520
021f2e1a
AS
15212011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1522
1523 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1524
8b058d44
EZ
15252011-10-29 Eli Zaretskii <eliz@gnu.org>
1526
1527 Fix the `xbytecode' command.
1528 * .gdbinit (xprintbytestr): New command.
b50a28de 1529 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1530 (xbytecode): Print the byte-code string as well.
1531
4452fb80
EZ
15322011-10-29 Kim Storm <storm@cua.dk>
1533
8b058d44
EZ
1534 * alloc.c (which_symbols): New function.
1535
21b72067
AS
15362011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1537
1538 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1539 line. (Bug#9903)
1540
83ed7b5c
GM
15412011-10-29 Glenn Morris <rgm@gnu.org>
1542
1543 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1544 Not clear what it was for, and it causes various bugs. (Bug#9839)
1545
5a7a728b
EZ
15462011-10-28 Eli Zaretskii <eliz@gnu.org>
1547
1548 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1549 possible random value that matches one of those tested as
1550 condition to clear the mouse face.
1551
d3d0842f
CY
15522011-10-28 Chong Yidong <cyd@gnu.org>
1553
1554 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1555
31b39d13
DN
15562011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1557
1558 * window.c (make_window): Initialize phys_cursor_on_p.
1559
9aba6043
SM
15602011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1561
1562 * lisp.h (struct Lisp_Symbol): Update comments.
1563
c20992f4
JB
15642011-10-28 Juanma Barranquero <lekktu@gmail.com>
1565
1566 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1567
db4f02f2
EZ
15682011-10-28 Eli Zaretskii <eliz@gnu.org>
1569
1570 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1571 <oslsachem@gmail.com> for helping to debug this.
1572
1573 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1574 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1575 (g_b_init_get_glyph_outline_w): New static variables.
1576 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1577 (GetGlyphOutlineW_Proc): New typedefs.
1578 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1579 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1580 New functions.
1581 (w32font_open_internal, compute_metrics):
1582 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1583 instead of calling the "wide" APIs directly.
1584
1585 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1586
1587 * w32.h (syms_of_w32font): Add prototype.
1588
87e68db4
JB
15892011-10-27 Juanma Barranquero <lekktu@gmail.com>
1590
1591 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1592 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1593 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1594 (Fmove_to_window_line): Doc fix.
1595
435c1d67
CY
15962011-10-27 Chong Yidong <cyd@gnu.org>
1597
1598 * process.c (make_process): Set gnutls_state to NULL.
1599
1600 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1601 non-NULL, regardless of GNUTLS_INITSTAGE.
1602 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1603 an error. Set process slots as soon as we allocate them.
1604
1605 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1606
9c6c6f49
CY
16072011-10-27 Chong Yidong <cyd@gnu.org>
1608
9aba6043
SM
1609 * gnutls.c (emacs_gnutls_deinit): New function.
1610 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1611 (Fgnutls_deinit, Fgnutls_boot): Use it.
1612
1613 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1614 (deactivate_process): Call emacs_gnutls_deinit.
1615
657d08d3
JB
16162011-10-27 Juanma Barranquero <lekktu@gmail.com>
1617
1618 * image.c (x_create_x_image_and_pixmap):
1619 * w32.c (sys_rename, w32_delayed_load):
1620 * w32font.c (fill_in_logfont):
1621 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1622
5430d399
JB
16232011-10-26 Juanma Barranquero <lekktu@gmail.com>
1624
1625 * w32fns.c (w32_default_color_map): New function,
1626 extracted from Fw32_default_color_map.
a7ef684b 1627 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1628
fe0055fa
PE
16292011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1630
1631 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1632
e6346438
SM
16332011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1634
1635 * keyboard.c (test_undefined): New function (bug#9751).
1636 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1637
e112cc37
ET
16382011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1639
1640 * sysdep.c (init_sys_modes): Fix the check for the controlling
1641 terminal (Bug#6649).
1642
7b5d6677
EZ
16432011-10-20 Eli Zaretskii <eliz@gnu.org>
1644
1645 * dispextern.h (struct bidi_it): New member next_en_type.
1646
1647 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1648 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1649 current character, check also for next_en_type being WEAK_EN.
1650 (bidi_resolve_weak): Don't enter the expensive loop if the current
1651 position is before next_en_pos. Record the bidi type of the first
1652 non-ET, non-BN character we find, in addition to its position.
1653 (bidi_level_of_next_char): Invalidate next_en_type when
1654 next_en_pos is over-stepped.
1655
7da0b018
PE
16562011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1657
1658 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1659 * editfns.c: Rewrite current-time-zone so that it invokes
1660 the equivalent of (format-time-string "%Z") to get the time zone name.
1661 This fixes a bug when the time zone name contains characters that
1662 need converting from the system time locale to Emacs internal format.
1663 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1664 that patch fixed format-time-string to do the conversion, but
1665 I forgot to fix current-time-zone.
1666 (format_time_string): New function, containing most of
1667 what Fformat_time_string used to contain.
1668 (Fformat_time_string): Rewrite in terms of format_time_string.
1669 This doesn't change this function's behavior.
1670 (current-time-zone): Rewrite to use format_time_string.
1671 This fixes the bug reported by Michael Schierl in
1672 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1673 Jason Rumney's 2007-06-07 change worked around this bug, but
1674 didn't fix it.
1675 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1676
8547b010
EZ
16772011-10-19 Eli Zaretskii <eliz@gnu.org>
1678
1679 * xdisp.c (start_display): If the character at POS is displayed
1680 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1681 (try_window_reusing_current_matrix): If a line ends in a display
1682 vector or the next line starts in a display vector, continue
1683 redrawing the window even though the character position of
1684 start_row was reached.
8547b010
EZ
1685 (Bug#9771, part 2)
1686
4e948d15
CY
16872011-10-18 Chong Yidong <cyd@gnu.org>
1688
1689 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1690 with nobreak-char-display too.
1691
4787455f
EZ
16922011-10-18 Eli Zaretskii <eliz@gnu.org>
1693
1694 Fix part 3 of bug#9771.
1695 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1696 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1697 non-neutral characters if the current character is a paragraph
1698 separator (a.k.a. Newline). This avoids running the same
1699 expensive loop twice, once when we consume the preceding newline
1700 and the other time when the line actually needs to be displayed.
1701 Avoid the loop when we see neutrals on the base embedding level
1702 following a character whose directionality is the same as the
1703 paragraph's. This avoids running the expensive loop when a line
1704 ends in a long sequence of neutrals, like control characters.
1705 Add assertion against STRONG_AL type. Slightly rearrange code
1706 that determines the type of a neutral given the first non-neutral
1707 that follows it.
1708 (bidi_level_of_next_char): Set next_en_pos to zero when
1709 invalidating its info.
1710
2c91f553
EZ
17112011-10-17 Eli Zaretskii <eliz@gnu.org>
1712
1713 * xdisp.c (push_display_prop): Determine whether to record string
1714 or buffer position by IT->string, not by IT->method. Allow
1715 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1716 (move_it_vertically_backward): Don't look for character position
1717 immediately after the newline when in a continuation line.
1718 (Bug#9771, part 1)
2c91f553 1719
c7b08b0d
MR
17202011-10-15 Martin Rudalics <rudalics@gmx.at>
1721
1722 * window.c (coordinates_in_window): Rewrite and delabelize
1723 vertical border check. (Bug#5357) (Bug#9618)
1724
6b02f655
SM
17252011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1726
1727 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1728 errors in XSetWindowBorder (bug#9310).
1729
81d40c92
DA
17302011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1731
1732 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1733 avoid crash when xmalloc overrun checking is enabled.
1734
d4172c3b
EZ
17352011-10-13 Eli Zaretskii <eliz@gnu.org>
1736
1737 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1738 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1739 cursor motion with <left> and <right> arrow keys.
1740
1741 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1742 some callers set that themselves.
1743
b00eea75
EZ
17442011-10-12 Eli Zaretskii <eliz@gnu.org>
1745
1746 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1747 display string and the previous row comes from the same string and
1748 is empty. (Bug#9739) (Bug#9738)
1749
8fe012c4
SM
17502011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1751
1752 * doc.c (get_doc_string): Encode file name (bug#9735).
1753
0074aef2
EZ
17542011-10-12 Eli Zaretskii <eliz@gnu.org>
1755
79beb178
EZ
1756 * bidi.c (bidi_level_of_next_char):
1757 * xdisp.c (get_visually_first_element): Remove old incorrect
1758 comments regarding the Unicode Line Separator character.
1759
0074aef2
EZ
1760 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1761
6e4b3fbe
DA
17622011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1763
1764 * alloc.c (Fgc_status): Do not access beyond zombies array
1765 boundary if nzombies > MAX_ZOMBIES.
1766 * alloc.c (dump_zombies): Add missing format specifier.
1767
0324f3af
PE
17682011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1769
b5525cac
PE
1770 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1771 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1772
0324f3af
PE
1773 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1774 Some packages use them to denote characters with modifiers.
1775
e9b5f888
AS
17762011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1777
1778 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1779 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1780 matching a pp-number. Rename parameter var to var1.
1781
127827c0
SM
17822011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1783
1784 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1785
c8fd3bd0
GM
17862011-10-08 Glenn Morris <rgm@gnu.org>
1787
1788 * callint.c (Fcall_interactively): Give a more explicit error for the
1789 'c' case with a non-character input. (Bug#8479)
1790
352ec8ff
EZ
17912011-10-08 Eli Zaretskii <eliz@gnu.org>
1792
03669ccb
EZ
1793 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1794 lines.
7061c986
EZ
1795 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1796 lines that are hscrolled on the left.
03669ccb 1797
352ec8ff
EZ
1798 * dispnew.c (buffer_posn_from_coords): Account for a possible
1799 presence of header-line. (Bug#4426)
1800
a66cfb1c
SM
18012011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1802
6b02f655
SM
1803 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1804 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1805
7c5ee88e
PE
18062011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1807
1808 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1809 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1810 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1811 this makes Emacs dump core during garbage collection on rare
1812 occasions. sizeof is obviously inferior to offsetof here, so
1813 stick with offsetof.
1814 (GC_POINTER_ALIGNMENT): New macro.
1815 (mark_memory): Omit 3rd (offset) arg; caller changed.
1816 Don't assume EMACS_INT alignment is the same as pointer alignment.
1817
df1bbe5b
SM
18182011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1819
1820 * keyboard.c (read_key_sequence_remapped): New var.
1821 (read_key_sequence): Compute remapping in the right buffer.
1822 (command_loop_1): Use read_key_sequence's remapping directly.
1823
51553db6
SM
18242011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1825
32c1fffd
SM
1826 * dired.c (file_name_completion): Don't expand file name.
1827 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1828 before checking file name handler.
1829
51553db6
SM
1830 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1831 they've been requested explicitly (bug#9591).
1832
b6bd1599 18332011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1834
1835 * keymap.c (Fsingle_key_description): Use make_specified_string
1836 instead of build_string to build string from push_key_description.
1837 (Bug#5193)
1838
f701dc2a
PE
18392011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1840
4222c55d
PE
1841 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1842 This fixes a Y2038 bug on 64-bit hosts.
1843 * buffer.c (reset_buffer):
1844 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1845 (Fclear_buffer_auto_save_failure):
1846 Use 0, not -1, to represent an unset failure time, since time_t
1847 might not be signed.
1848
f701dc2a
PE
1849 Remove dependency on glibc malloc internals.
1850 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1851 Move back here from lisp.h, but with their new implementations.
1852 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1853 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1854 * charset.c (charset_table_init): New static var.
1855 (syms_of_charset): Use it instead of xmalloc. This removes a
1856 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1857 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1858 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1859 Move back to alloc.c.
1860 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1861 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1862
9ceebf39
JD
18632011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1864
1865 * nsterm.m (windowDidResize): Call x_set_window_size only when
1866 ns_in_resize is true. Otherwise set pixelwidth/height and
1867 call change_frame_size (Bug#9628).
1868
cb993c58
PE
18692011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1870
3930c88b
PE
1871 Port --enable-checking=all to Fedora 14 x86-64.
1872 * charset.c (syms_of_charset): Also account for glibc malloc's
1873 internal overhead when calculating the initial malloc maximum.
1874
cb993c58
PE
1875 Port --enable-checking=all to Fedora 14 x86.
1876 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1877 Move to lisp.h.
1878 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1879 (overrun_check_realloc, overrun_check_free):
1880 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1881 That way, xmalloc returns a properly-aligned pointer even if
1882 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1883 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1884 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1885 into account when calculating the initial malloc maximum.
1886 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1887 Move here from alloc.c, so that charset.c can use it too.
1888 Properly align; the old code wasn't right for common 32-bit hosts
1889 when configured with --enable-checking=all.
1890 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1891 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1892
31bed486
EZ
18932011-09-29 Eli Zaretskii <eliz@gnu.org>
1894
04c70788 1895 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1896 use EDOM.
1897
fbcaa2f3
EZ
18982011-09-28 Eli Zaretskii <eliz@gnu.org>
1899
1900 * xdisp.c (compute_display_string_end): If there's no display
1901 string at CHARPOS, return -1.
1902
1903 * bidi.c (bidi_fetch_char): When compute_display_string_end
1904 returns a negative value, treat the character as a normal
1905 character not covered by a display string. (Bug#9624)
1906
a239d4e9
JB
19072011-09-28 Juanma Barranquero <lekktu@gmail.com>
1908
1909 * lread.c (Fread_from_string): Fix typo in docstring.
1910
88652fd5
EZ
19112011-09-27 Eli Zaretskii <eliz@gnu.org>
1912
1913 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1914 newline, reseat the iterator instead of bidi-iterating there one
1915 character at a time. (Bug#9610)
32c1fffd
SM
1916 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1917 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1918
ed497dd4
AS
19192011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1920
1921 * lread.c (readevalloop): Use correct code for NBSP.
1922 (read1): Likewise. (Bug#9608)
1923
b2bf61aa
MA
19242011-09-25 Michael Albinus <michael.albinus@gmx.de>
1925
1926 * dbusbind.c (Fdbus_register_signal): When service is not
1927 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1928
32bbb17c
GM
19292011-09-25 Glenn Morris <rgm@gnu.org>
1930
1931 * buffer.c (truncate-lines): Doc fix.
1932
94e0933e
CY
19332011-09-24 Chong Yidong <cyd@stupidchicken.com>
1934
1935 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1936 (Fset_window_next_buffers): Doc fix.
1937
cddde921
GM
19382011-09-24 Glenn Morris <rgm@gnu.org>
1939
1940 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1941
1260aef1
PE
19422011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1943
25b4bfa0
PE
1944 Fix minor problems found by static checking.
1945 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1946 * indent.c (Fvertical_motion): Fix == vs = typo.
1947
e3cbd34b
EZ
19482011-09-24 Eli Zaretskii <eliz@gnu.org>
1949
a66cfb1c
SM
1950 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1951 Default value is now t. Doc fix.
6bf7006f 1952
e3cbd34b 1953 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1954 logic when moving up, not only when moving down. Fix the
e3cbd34b 1955 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1956 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1957
1958 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1959 CHARPOS is covered by a display string which includes newlines.
1960 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1961 is covered by a display string with embedded newlines.
1962
a3de0cbd
MA
19632011-09-24 Michael Albinus <michael.albinus@gmx.de>
1964
1965 * dbusbind.c (Fdbus_register_signal): Add match rule to
1966 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1967 (Fdbus_register_method, Vdbus_registered_objects_table):
1968 Fix docstring.
a3de0cbd 1969
b260039d
JM
19702011-09-24 Jim Meyering <meyering@redhat.com>
1971
32c1fffd 1972 do not ignore write error for any output size
b260039d
JM
1973 The previous change was incomplete.
1974 While it makes emacs --batch detect the vast majority of stdout
1975 write failures, errors were still ignored whenever the output size is
1976 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1977 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1978 && echo FAIL: ignored write error
1979 FAIL: ignored write error
1980 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1981 && echo FAIL: ignored write error
1982 FAIL: ignored write error
1983 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1984
8eca8a7c
AS
19852011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1986
1987 * emacs.c (Fkill_emacs): In noninteractive mode exit
1988 non-successfully if a write error occurred on stdout. (Bug#9574)
1989
3341db62
EZ
19902011-09-21 Eli Zaretskii <eliz@gnu.org>
1991
1992 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1993 the xassert test.
1994
1995 * dispextern.h (struct it): Update the comment documenting what
1996 can it->OBJECT be.
1997
8c203dbf
EZ
19982011-09-20 Eli Zaretskii <eliz@gnu.org>
1999
2000 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2001 a display string, extend search for cursor position to end of row.
2002 (find_row_edges): If the row ends in a newline from a display
2003 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2004 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2005 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2006 non-empty line. Fixes confusing cursor motion with arrow keys at
2007 the beginning of a line that starts with whitespace.
8c203dbf 2008
a4824228
LMI
20092011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2010
2011 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2012 (bug#9493).
2013
33ed493b
CY
20142011-09-18 Chong Yidong <cyd@stupidchicken.com>
2015
2016 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2017 boolean (Bug#9154).
2018
56cd55c8
EZ
20192011-09-18 Eli Zaretskii <eliz@gnu.org>
2020
2021 * xdisp.c (display_line): Record maximum and minimum buffer
2022 positions even if no glyphs were produced (e.g., by a zero-width
2023 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2024 buffer positions that will be removed from the glyph row because
2025 they don't fit.
c02dcedf
EZ
2026 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2027 column is beyond frame width: don't subtract 1 "pixel" when
2028 computing width of the stretch.
3e62b7e0
EZ
2029 (reseat_at_next_visible_line_start): Undo the change made on
2030 2011-09-17 that saved paragraph information and restored it after
2031 the call to `reseat'. (Bug#9545)
56cd55c8 2032
5ed99d36 20332011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2034
2035 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2036 and turn window cursor on if cleared (Bug#9415).
2037
5ed99d36 20382011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2039
2040 * search.c (boyer_moore): Take unibyte characters from pattern
2041 literally. (Bug#9458)
2042
9bade7b2
EZ
20432011-09-18 Eli Zaretskii <eliz@gnu.org>
2044
2045 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2046
e5e9d610
PE
20472011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2048
87e4427a
PE
2049 Fix minor problem found by static checking.
2050 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2051 initialized, to pacify gcc -Wuninitialized.
2052
e5e9d610
PE
2053 * fileio.c: Report proper errno when syscall falls.
2054 (Finsert_file_contents): Save and restore errno,
2055 so that report_file_error outputs the correct diagnostic.
2056 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2057
a1674f0b
EZ
20582011-09-18 Eli Zaretskii <eliz@gnu.org>
2059
2060 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2061
fbfb6dd4
EZ
20622011-09-17 Eli Zaretskii <eliz@gnu.org>
2063
2064 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2065 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2066
bb187662
EZ
20672011-09-17 Eli Zaretskii <eliz@gnu.org>
2068
1137e8b8 2069 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2070 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2071
2072 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2073 (bidi_find_paragraph_start): Search back for paragraph beginning
2074 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2075 (bidi_move_to_visually_next): Only trigger paragraph-related
2076 computations when the last character is a newline or at EOB, not
2077 just any NEUTRAL_B. (Bug#9470)
2078
bb187662
EZ
2079 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2080 truncated lines if point is covered by a display string. (Bug#9524)
2081
2e621251
PE
20822011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2083
2084 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2085 (cons_to_x_long): New function.
2086 (lisp_data_to_selection_data): Use it. Correct the test for
2087 short-versus-long data; it was negated. Break out of vector
2088 loop, for efficiency, when a long datum is discovered.
2089
91a15bc6
SM
20902011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2091
2092 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2093
b41c3a35
EZ
20942011-09-16 Eli Zaretskii <eliz@gnu.org>
2095
2096 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2097 GCC PR/17406) by declaring this function with external scope.
2098
7812ba2d
PE
20992011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2100
2101 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2102 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2103
cf7edc2a
AS
21042011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2105
2106 * editfns.c (Fformat): Correctly handle text properties on "%%".
2107
bd01620e
EZ
21082011-09-15 Eli Zaretskii <eliz@gnu.org>
2109
2110 * xterm.c (x_draw_composite_glyph_string_foreground):
2111 * w32term.c (x_draw_composite_glyph_string_foreground):
2112 * term.c (encode_terminal_code):
2113 * composite.c (composition_update_it, get_composition_id):
2114 * xdisp.c (get_next_display_element)
2115 (fill_composite_glyph_string): Add comments about special meaning
2116 of TAB characters in a composition.
2117
a02719a3
PE
21182011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2119
2120 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2121 This occurs when processing a multibyte format.
2122 Problem reported by Wolfgang Jenker.
a02719a3 2123
72589a3c
JB
21242011-09-15 Johan Bockgård <bojohan@gnu.org>
2125
2126 * xdisp.c (try_cursor_movement): Only check for exact match if
2127 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2128
1c14176c
PE
21292011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2130
2131 Remove unused external symbols.
2132 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2133 * xdisp.c (calc_pixel_width_or_height): Now static.
2134 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2135 * indent.c (check_display_width):
2136 * w32term.c: Fix comment to match code.
2137 * xterm.c, xterm.h (x_catching_errors): Remove.
2138
d2eea5b5
PE
21392011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2140
2141 * xselect.c: Use signed conversions more consistently (Bug#9498).
2142 (selection_data_to_lisp_data): Assume incoming selection data are
2143 signed integers, not unsigned. This is to be consistent with
2144 outgoing selection data, which was modified to use signed integers
2145 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2146 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2147 expects long, not unsigned long.
2148
46888499
EZ
21492011-09-14 Eli Zaretskii <eliz@gnu.org>
2150
2151 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2152 computation of loop end. Reported by Johan Bockgård
2153 <bojohan@gnu.org>.
2154
ef8ef9fb
CY
21552011-09-13 Chong Yidong <cyd@stupidchicken.com>
2156
2157 * frame.c (Fother_visible_frames_p): Function deleted.
2158
fa819fed
EZ
21592011-09-12 Eli Zaretskii <eliz@gnu.org>
2160
2161 * indent.c (compute_motion): Process display vector front to back
2162 rather than the other way around. (Bug#2496)
2163
2ba8e008
SM
21642011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2165
2166 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2167
20f53c69
CY
21682011-09-11 Chong Yidong <cyd@stupidchicken.com>
2169
2170 * minibuf.c (Fread_from_minibuffer): Doc fix.
2171
d562d7a4
EZ
21722011-09-11 Eli Zaretskii <eliz@gnu.org>
2173
2174 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2175 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2176
1c4d7f3d
LMI
21772011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2178
2179 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2180 value for non-existent files.
2181
b885bf36
EZ
21822011-09-11 Eli Zaretskii <eliz@gnu.org>
2183
2184 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2185 set its "size" to -1. This will set the modtime_size field of
2186 the corresponding buffer to -1, which is what
2187 verify-visited-file-modtime expects for files that do not exist.
2188 (Bug#9139)
2189
6612f0bf
PE
21902011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2191
2192 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2193 here ...
2194 * lisp.h: ... from here. push_key_description is no longer
2195 defined in keyboard.c, so its declaration should not be in
2196 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2197 logically belongs with push_key_description.
2198
dfb3f755
PE
21992011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2200
2201 * buffer.h: Include <sys/types.h> instead of <time.h>.
2202 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2203 Problem reported by Herbert J. Skuhra.
2204
3134906c
LMI
22052011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2206
2207 * xml.c (parse_region): Make the parsing work for
2208 non-comment-starting XML files again (bug#9144).
2209
8d903f4e
AS
22102011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2211
2212 * image.c (gif_load): Fix calculation of bottom and right corner.
2213 (Bug#9468)
2214
80ad64f4
EZ
22152011-09-10 Eli Zaretskii <eliz@gnu.org>
2216
2217 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2218 redisplay in small windows.
2219
208a048d
EZ
22202011-09-09 Eli Zaretskii <eliz@gnu.org>
2221
2222 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2223
9b1c252e
MR
22242011-09-08 Martin Rudalics <rudalics@gmx.at>
2225
2226 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2227 Operate on live windows only.
2228
2949f33b
JB
22292011-09-08 Juanma Barranquero <lekktu@gmail.com>
2230
2231 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2232
e08dcafd
EZ
22332011-09-07 Eli Zaretskii <eliz@gnu.org>
2234
2235 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2236 only under bidi iteration.
2237
115b96bd
JD
22382011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2239
2240 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2241
c8199d0f
PE
22422011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2243
2244 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2245 Without this fix, the command to link temacs failed due to an
2246 undefined symbol __builtin_isnan. This is because
2247 /usr/include/iso/math_c99.h #defines isnan(x) to
2248 __builtin_isnan(x), but the bundled gcc, which identifies itself
2249 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2250 a __builtin_isnan.
2251 * floatfns.c (isnan): #undef, and then #define to a clone of
2252 what's in data.c.
2253 (Fisnan): Always define, since it's always available now.
2254 (syms_of_floatfns): Always define isnan at the Lisp level.
2255
e39b275c 22562011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2257
2258 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2259
b2db44d9 22602011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2261
f4af5137 2262 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2263 The previous code assumed that file offsets (off_t values) fit in
2264 EMACS_INT variables, which is not true on typical 32-bit hosts.
2265 The code messed up by falsely reporting buffer overflow in cases
2266 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2267 when "big" contains more than 2**29 bytes, even though this
2268 inserts just one byte and does not overflow the buffer.
2269 (Finsert_file_contents): Store file offsets as off_t
2270 values, not as EMACS_INT values. Check for overflow when
2271 converting between EMACS_INT and off_t. When checking for
2272 buffer overflow or for overlap, take the offsets into account.
2273 Don't use EMACS_INT for small values where int suffices.
2274 When checking for overlap, fix a typo: ZV was used where
2275 ZV_BYTE was intended.
2276 (Fwrite_region): Don't assume off_t fits into 'long'.
2277 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2278
ecfc0a49
MA
22792011-09-05 Michael Albinus <michael.albinus@gmx.de>
2280
2281 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2282
6511acf2 22832011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2284
0999621a 2285 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2286
2287 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2288 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2289 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2290 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2291 (modify_event_symbol): Do not assume that the length of
2292 name_alist_or_stem is safe to alloca and fits in int.
2293 (Fexecute_extended_command): Likewise for function name and binding.
2294 (Frecursion_depth): Wrap around reliably on integer overflow.
2295 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2296 since some callers pass EMACS_INT values.
2297 (Fsingle_key_description): Don't crash if symbol name contains more
2298 than MAX_ALLOCA bytes.
2299 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2300 (get_minibuffer): Arg is now EMACS_INT, not int.
2301 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2302 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2303 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2304
2be7d702
PE
2305 * dbusbind.c (signature_cat): New function.
2306 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2307 Do not overrun buffer; instead, report string overflow.
2308
9d1df220
PE
2309 * dispnew.c (add_window_display_history): Don't overrun buffer.
2310 Truncate instead; this is OK since it's just a log.
2311
33ef5c64
PE
2312 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2313 even if the time zone offset is outlandishly large.
2314 Don't mishandle offset == INT_MIN.
2315
66c6fdd5
PE
2316 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2317 when creating daemon; the previous buffer-overflow check was incorrect.
2318
d749b01b
PE
2319 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2320 which has the guts of the old verror function.
2321
b5cd1905
PE
2322 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2323 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2324
6e1a67fb
PE
2325 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2326 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2327 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2328 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2329 length of string rather than counting it via multiple sprintfs;
2330 that's simpler and more reliable.
c21721cc
PE
2331 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2332 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2333 sprintf, in case result does not fit in int.
2334
c57b67fc
PE
2335 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2336 (fontset_from_font): Print it.
2337
8a401434
PE
2338 * frame.c (tty_frame_count): Now printmax_t, not int.
2339 (make_terminal_frame, set_term_frame_name): Print it.
2340 (x_report_frame_params): In X, window IDs are unsigned long,
2341 not signed long, so print them as unsigned.
2342 (validate_x_resource_name): Check for implausibly long names,
2343 and don't assume name length fits in 'int'.
2344 (x_get_resource_string): Don't blindly alloca invocation name;
2345 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2346 not fit in int.
2347
6e1a67fb
PE
2348 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2349 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2350 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2351
0df02bf3
PE
2352 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2353 Use esprintf, not sprintf, in case result does not fit in int.
2354
48e30793
PE
2355 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2356 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2357 it as a large positive number.
2358 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2359 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2360
a66ff6d8
PE
2361 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2362 in case result does not fit in int.
2363
aca216ff
PE
2364 * print.c (float_to_string): Detect width overflow more reliably.
2365 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2366 buffer overrun. Don't assume list length fits in 'int'. Treat
2367 print length of 0 as 0, not as infinity; to be consistent with other
2368 uses of print length in this function. Don't overflow print length
2369 index. Don't assume hash table size fits in 'long', or that
2370 vectorlike size fits in 'unsigned long'.
2371
31c286f7
PE
2372 * process.c (make_process): Use printmax_t, not int, to format
2373 process-name gensyms.
2374
55e5faa1
PE
2375 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2376
80f2e268
PE
2377 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2378 to avoid potential buffer overrun.
2379
670741ab
PE
2380 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2381 if X resource line is longer than 512 bytes.
2382
b7163a50
PE
2383 * xfns.c (x_window): Make sprintf buffer a bit bigger
2384 to avoid potential buffer overrun.
2385
ae58ff1f
PE
2386 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2387
c43c8a6a
PE
2388 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2389
3f8236f4
PE
23902011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2391
53e9fe90 2392 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2393 Without these, Emacs silently mishandles large integers sometimes.
2394 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2395 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2396
6511acf2
PE
2397 * xdisp.c (try_window_id): Check Emacs fixnum range before
2398 converting to 'int'.
806add1d 2399
6511acf2 2400 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2401 Check that an Emacs fixnum is in range before assigning it to 'int'.
2402 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2403 values converted from Emacs fixnums.
2404 (Frecenter): Don't wrap around a line count if it is out of 'int'
2405 range; instead, treat it as an extreme value.
2406 (Fset_window_configuration, compare_window_configurations):
2407 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2408
6511acf2
PE
2409 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2410 that can exceed INT_MAX. Check that EMACS_INT value is in range
2411 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2412 (match_limit): Don't assume that a fixnum can fit in 'int'.
2413
6511acf2 2414 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2415 exceed INT_MAX.
2416
6511acf2 2417 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2418 (Fvertical_motion): Don't wrap around LINES values that don't fit
2419 in 'int'. Instead, treat them as extreme values. This is good
2420 enough for windows, which can't have more than INT_MAX lines anyway.
2421
fcb901a7
LMI
24222011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2423
0f2f6b6d
LMI
2424 * Require libxml/parser.h to avoid compilation warning.
2425
fcb901a7
LMI
2426 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2427
2428 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2429 since this reportedly can destroy thread storage.
2430
6e20a0d4
CY
24312011-08-30 Chong Yidong <cyd@stupidchicken.com>
2432
2433 * syntax.c (find_defun_start): Update all cache variables if
2434 exiting early (Bug#9401).
2435
148ae00e
EZ
24362011-08-30 Eli Zaretskii <eliz@gnu.org>
2437
f6cfbd8f
EZ
2438 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2439
148ae00e
EZ
2440 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2441 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2442 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2443
2444 * term.c (tty_append_glyph): New function.
2445 (produce_stretch_glyph): Static function and its prototype deleted.
2446
a66cfb1c
SM
2447 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2448 Add prototypes.
148ae00e 2449
c4a07a4c
PE
24502011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2451
2452 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2453 when checking :margin (Bug#9390).
2454 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2455 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2456 so that the name doesn't mislead. All uses changed.
2457
6bc8cd65
JB
24582011-08-28 Johan Bockgård <bojohan@gnu.org>
2459
2460 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2461 set_tty_hooks.
2462
dca4927e
EZ
24632011-08-27 Eli Zaretskii <eliz@gnu.org>
2464
2465 * xdisp.c (move_it_to): Don't bail out early when reaching
2466 position beyond to_charpos, if we are scanning backwards.
2467 (move_it_vertically_backward): When DY == 0, make sure we get to
2468 the first character in the line after the newline.
2469
f2cad773
PE
24702011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2471
2472 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2473 (ccl_driver): Do not generate an out-of-range pointer.
2474 (Fccl_execute_on_string): Remove unnecessary check for
2475 integer overflow, noted by Stefan Monnier in
2476 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2477 Remove a FIXME that didn't need fixing.
2478 Simplify the newly-introduced buffer reallocation code.
2479
0cae2cdb
JB
24802011-08-27 Juanma Barranquero <lekktu@gmail.com>
2481
2482 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2483
5fc295a4 24842011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2485
70c60eb2 2486 Integer and memory overflow issues (Bug#9196).
726e0ab1 2487
d31850da
PE
2488 * doc.c (get_doc_string): Rework so that
2489 get_doc_string_buffer_size is the actual buffer size, rather than
2490 being 1 less than the actual buffer size; this makes xpalloc more
2491 convenient.
2492
a69fbedb
PE
2493 * image.c (x_allocate_bitmap_record, cache_image):
2494 * xselect.c (Fx_register_dnd_atom):
2495 Simplify previous changes by using xpalloc.
2496
fe5c5d37
PE
2497 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2498 since either will do and ptrdiff_t is convenient with xpalloc.
2499
0065d054
PE
2500 * charset.c (charset_table_size)
2501 (struct charset_sort_data.priority): Now ptrdiff_t.
2502 (charset_compare): Don't overflow if priorities differ greatly.
2503 (Fsort_charsets): Don't assume list length fits in int.
2504 Check for size-calculation overflow when allocating sort data.
2505 (syms_of_charset): Allocate an initial charset table that is
2506 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2507
2508 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2509
2510 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2511 The actual value is always <= INT_MAX, and leaving it unsigned made
2512 overflow checking harder.
2513
2514 * dispextern.h (struct glyph_matrix.rows_allocated)
2515 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2516 with xpalloc. The values are still always <= INT_MAX.
2517
2518 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2519
2520 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2521 (SAFE_NALLOCA): New macro.
2522
2523 * region-cache.c (struct boundary.pos, find_cache_boundary)
2524 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2525 (set_cache_region, invalidate_region_cache)
2526 (revalidate_region_cache, know_region_cache, region_cache_forward)
2527 (region_cache_backward, pp_cache):
2528 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2529 so that ptrdiff_t * can be passed to xpalloc.
2530 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2531 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2532 (pp_cache): Don't assume cache_len fits in int.
2533 * region-cache.h: Adjust extern decls to match.
2534
2535 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2536 EMACS_INT, since either will do, for xpalloc.
2537
2538 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2539 (xnmalloc, xnrealloc, xpalloc): New functions.
2540
726e0ab1
PE
2541 * bidi.c (bidi_shelve_header_size): New constant.
2542 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2543 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2544
51f30bc5 2545 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2546 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2547 (overlay_strings):
2548 Don't update size of array until after memory allocation succeeds,
2549 because xmalloc/xrealloc may not return.
0065d054
PE
2550 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2551 now that we have proper integer overflow checking.
2552 (record_overlay_string, overlay_strings): Catch overflows when
2553 calculating size of overlay_str_buf.
726e0ab1 2554
0065d054
PE
2555 * callproc.c (Fcall_process): Check for size overflow when
2556 calculating size of args2.
2557 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2558 Normally we prefer signed values, but sticking with ptrdiff_t would
2559 require adding more-complicated checks.
726e0ab1
PE
2560
2561 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2562 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2563 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2564 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2565
2566 * character.c (Fstring): Check for size-calculation overflow.
2567
2568 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2569 unnecessary integer overflow. Check for size overflow.
2570 (encode_coding_object): Don't update size until xmalloc succeeds.
2571
2572 * composite.c (get_composition_id): Check for overflow in glyph
2573 length calculations.
2574
2575 Integer and memory overflow fixes for display code.
2576 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2577 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2578 (scrolling_window): Check for overflow in size calculations.
2579 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2580 Don't assume glyph table len fits in int.
2581 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2582 (row_table_size): Now ptrdiff_t, not int.
2583 (scrolling_window): Avoid overflow in size calculations.
2584 Don't update size until allocation succeeds.
2585 * fns.c (concat): Check for overflow in size calculations.
2586 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2587 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2588 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2589
2590 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2591 (get_doc_string): Check for size calculation overflow.
2592 Don't update size until allocation succeeds.
2593 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2594 EMACS_INT, where ptrdiff_t will do.
2595 (Fsubstitute_command_keys): Check for string overflow.
2596
2597 * editfns.c (set_time_zone_rule): Don't assume environment length
2598 fits in int.
2599 (message_length): Now ptrdiff_t, not int.
2600 (Fmessage_box): Don't update size until allocation succeeds.
2601 Don't assume message length fits in int.
2602 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2603
0065d054
PE
2604 * emacs.c (main): Do not reallocate argv, since there is a null at
2605 the end that can be overwritten, and this way there's no need to
2606 worry about size-calculation overflow.
2607 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2608
2609 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2610 alloc succeeds.
2611 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2612
2613 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2614 (x_set_scroll_bar_width, x_figure_window_size):
2615 Check for integer overflow.
2616 (x_set_alpha): Do not assume XINT fits in int.
2617
2618 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2619 This is for the members text_lines, text_cols, total_lines, total_cols,
2620 where the system imposes an 'int' limit.
2621
2622 * fringe.c (Fdefine_fringe_bitmap):
2623 Don't update size until alloc works.
2624
2625 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2626 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2627
2628 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2629 Check for size-calculation overflow.
2630 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2631 do, as we prefer signed integers.
2632 (id_to_widget.max_size, id_to_widget.used)
2633 (xg_store_widget_in_map, xg_remove_widget_from_map)
2634 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2635 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2636 Use and return ptrdiff_t, not int.
2637 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2638 * gtkutil.h: Change prototypes to match the above.
2639
2640 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2641 are duplicate now that they've been promoted to lisp.h.
2642 (x_allocate_bitmap_record, x_alloc_image_color)
2643 (make_image_cache, cache_image, xpm_load):
2644 Don't update size until alloc is done.
2645 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2646 (x_detect_edges):
3256efce 2647 Check for size calculation overflow.
726e0ab1
PE
2648 (ct_colors_allocated_max): New constant.
2649 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2650 overflow.
3256efce 2651
726e0ab1
PE
2652 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2653 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2654 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2655 Use ptrdiff_t, not int, to count maps.
2656 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2657 calculations. Don't update size until allocation succeeds.
2658 Redo calculations to avoid overflow.
726e0ab1
PE
2659 * keyboard.h: Change prototypes to match the above.
2660
2661 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2662 to count maps.
2663 (current_minor_maps): Check for size calculation overflow.
2664 * keymap.h: Change prototypes to match the above.
2665
2666 * lread.c (read1, init_obarray): Don't update size until alloc done.
2667
2668 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2669 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2670
726e0ab1
PE
2671 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2672 Now ptrdiff_t, not int.
2673 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2674 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2675
2676 * process.c (Fnetwork_interface_list): Check for overflow
2677 in size calculation.
2678
2679 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2680
2681 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2682 overflow. Don't bother calling xmalloc when xrealloc will do.
2683
2684 * search.c (Freplace_match): Check for size calculation overflow.
2685 (Fset_match_data): Don't assume list lengths fit in 'int'.
2686
2687 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2688 for command line length. Do not attempt to address one before the
2689 beginning of an array, as that's not portable.
2690
2691 * term.c (max_frame_lines): Remove; unused.
2692 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2693 not int.
2694 (encode_terminal_code, calculate_costs): Check for size
2695 calculation overflow.
2696 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2697 table lengths and related sizes. Don't update size until alloc
2698 done. Redo calculations to avoid overflow.
2699 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2700
2701 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2702 subtracting pointers.
2703 (gobble_line): Check for overflow more carefully. Don't update size
2704 until alloc done.
2705
2706 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2707 Don't update size until alloc done.
2708 Redo size calculations to avoid overflow.
2709 Check for size calculation overflow.
0065d054 2710 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2711
2712 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2713 Use ptrdiff_t, not int, for sizes.
2714 (store_mode_line_noprop_char): Don't update size until alloc done.
2715
0065d054
PE
2716 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2717 Use ptrdiff_t, not int, for sizes.
2718 (Finternal_make_lisp_face, cache_face):
2719 Check for size calculation overflow.
2720 (cache_face): Treat size calculation overflows as if they were
2721 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2722
2723 * xfns.c (x_encode_text, x_set_name_internal)
2724 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2725 sizes, since they can exceed INT_MAX in size. Check for size
2726 calculation overflow.
2727
0065d054
PE
2728 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2729 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2730 Don't update size until alloc done.
2731
0065d054 2732 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2733 as sprintf is limited to int lengths.
1d526e2f 2734
252c5ee1
PE
2735 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2736 (X_LONG_MIN): New macros.
864d7ce7
PE
2737 Use them to make the following changes clearer.
2738 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2739 This change doesn't affect the value now, but it may help remind
2740 future maintainers not to raise the value too much later.
2741 (SELECTION_QUANTUM): Remove, replacing with ...
2742 (selection_quantum): ... new function, which avoids overflow.
2743 All uses changed.
2744 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2745 assumption that selection length fits in 'int'.
2746 (x_reply_selection_request, x_handle_selection_request)
2747 (x_get_window_property, receive_incremental_selection)
2748 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2749 (lisp_data_to_selection_data, clean_local_selection_data):
2750 Use ptrdiff_t, not int, to record length of selection.
2751 (x_reply_selection_request, x_get_window_property)
2752 (receive_incremental_selection, x_property_data_to_lisp):
2753 Redo calculations to avoid overflow.
2754 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2755 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2756 something.
2757 (x_get_window_property, receive_incremental_selection)
2758 (lisp_data_to_selection_data, x_property_data_to_lisp):
2759 Check for size-calculation overflow.
2760 (x_get_window_property, receive_incremental_selection)
2761 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2762 Don't store size until memory allocation succeeds.
2763 (x_get_window_property): Plug memory leak on memory exhaustion.
2764 Don't double-block input; malloc is safe here. Don't assume 2**34
2765 - 4 fits in unsigned long. Add an xassert to check
2766 XGetWindowProperty overflow. Be more careful about overflow
2767 calculations, and distinguish size from memory overflow better.
2768 (receive_incremental_selection): When tracing, don't assume
2769 unsigned int is less than INT_MAX.
2770 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2771 harmful) conversions of unsigned short to int.
2772 (lisp_data_to_selection_data): Don't assume that integers
2773 in the range -65535 through -1 fit in an X unsigned short.
2774 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2775 result parameters unless successful. Rely on cons_to_unsigned
2776 to report problems with elements; the old code wasn't right anyway.
2777 (x_check_property_data): Check for int overflow; we cannot use
2778 a wider type due to X limits.
2779 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2780
726e0ab1 2781 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2782
0065d054
PE
2783 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2784 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2785 (x_color_cells): Don't store size until memory allocation succeeds.
2786 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2787 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2788 (x_term_init): Don't assume length fits in int (sprintf is limited
2789 to int size).
bc18e09d 2790
ebfa62c0
PE
2791 Use ptrdiff_t for composition IDs.
2792 * character.c (lisp_string_width):
2793 * composite.c (composition_table_size, n_compositions)
2794 (get_composition_id, composition_gstring_from_id):
2795 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2796 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2797 * window.c (Frecenter):
2798 Use ptrdiff_t, not int, for composition IDs.
2799 * composite.c (get_composition_id): Check for integer overflow.
2800 * composite.h: Adjust prototypes to match the above changes.
2801
d3411f89
PE
2802 Use ptrdiff_t for hash table indexes.
2803 * category.c (hash_get_category_set):
2804 * ccl.c (ccl_driver):
2805 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2806 * coding.c (coding_system_charset_list, detect_coding_system):
2807 * coding.h (struct coding_system.id):
2808 * composite.c (get_composition_id, gstring_lookup_cache):
2809 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2810 * image.c (xpm_get_color_table_h):
2811 * lisp.h (hash_lookup, hash_put):
2812 * minibuf.c (Ftest_completion):
2813 Use ptrdiff_t for hash table indexes, not int (which is too
2814 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2815 32-bit --with-wide-int hosts).
2816
e097a6fa
PE
2817 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2818 Add a FIXME comment about memory leaks.
2819 (syms_of_charset): Don't assume xmalloc returns.
2820
5637687f
PE
2821 Don't assume that stated character widths fit in int.
2822 * character.c (Fchar_width, c_string_width, lisp_string_width):
2823 * character.h (CHAR_WIDTH):
2824 * indent.c (MULTIBYTE_BYTES_WIDTH):
2825 Use sanitize_char_width to avoid undefined and/or bad behavior
2826 with outlandish widths.
a66cfb1c 2827 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2828 now that we have two such functions. All uses changed.
2829 (sanitize_char_width): New inline function.
2830
a2271ba2
PE
2831 Don't assume that tab-width fits in int.
2832 * character.h (sanitize_width): New inline function.
2833 (SANE_TAB_WIDTH): New macro.
2834 (ASCII_CHAR_WIDTH): Use it.
2835 * indent.c (sane_tab_width): Remove. All uses replaced by
2836 SANE_TAB_WIDTH (current_buffer).
2837 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2838
18c52557
PE
2839 * fileio.c: Integer overflow issues with file modes.
2840 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2841
caeeedc1
PE
2842 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2843 Remove unreachable code.
2844 (read_hex, load_charset_map_from_file): Check for integer overflow.
2845
6df6ae42 2846 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2847 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2848 (x_send_scroll_bar_event): Likewise. Check that the size does not
2849 exceed limits imposed by XClientMessageEvent, as well as the usual
2850 ptrdiff_t and size_t limits.
2851
b13995db
PE
2852 * keyboard.c: Overflow, signedness and related fixes.
2853 (make_lispy_movement): Use same integer type in forward decl
2854 that is used in the definition.
2855 (read_key_sequence, keyremap_step):
2856 Change bufsize argument back to int, undoing my 2011-03-30 change.
2857 We prefer signed types, and int is wide enough here.
2858 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2859 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2860 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2861 length, not size_t. Use ptrdiff_t for index, not int.
2862 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2863 possibility of integer overflow.
2864
13464394
PE
2865 Overflow, signedness and related fixes for images.
2866
2867 * dispextern.h (struct it.stack[0].u.image.image_id)
2868 (struct_it.image_id, struct image.id, struct image_cache.size)
2869 (struct image_cache.used, struct image_cache.ref_count):
2870 * gtkutil.c (update_frame_tool_bar):
2871 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2872 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2873 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2874 * nsmenu.m (update_frame_tool_bar):
2875 * xdisp.c (calc_pixel_width_or_height):
2876 * xfns.c (image_cache_refcount):
2877 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2878 on typical 64-bit hosts.
2879
2880 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2881 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2882 Omit unnecessary casts to int.
2883 (parse_image_spec): Check that integers fall into 'int' range
2884 when the callers expect that.
2885 (image_ascent): Redo ascent calculation to avoid int overflow.
2886 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2887 (lookup_image): Remove unnecessary tests.
2888 (xbm_image_p): Locals are now of int, not EMACS_INT,
2889 since parse_image_check makes sure they fit into int.
2890 (png_load, gif_load, svg_load_image):
2891 Prefer int to unsigned where either will do.
2892 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2893 old tiff_error_handler and tiff_warning_handler.
2894 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2895 stack buffer overflows. It uses only the features of vsnprintf
2896 that are common to both POSIX and native Microsoft.
2897 (tiff_error_handler, tiff_warning_handler): Use it.
2898 (tiff_load, gif_load, imagemagick_load_image):
2899 Don't assume :index value fits in 'int'.
2900 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2901 (imagemagick_load_image): Check that crop parameters fit into
2902 the integer types that MagickCropImage accepts. Don't assume
2903 Vimagemagick_render_type has a nonnegative value. Don't assume
2904 size_t fits in 'long'.
2905 (gs_load): Use printmax_t to print the widest integers possible.
2906 Check for integer overflow when computing image height and width.
2907
c11821d4
EZ
29082011-08-26 Eli Zaretskii <eliz@gnu.org>
2909
2910 * xdisp.c (redisplay_window): Don't force window start if point
2911 will be invisible in the resulting window. (Bug#9324)
2912
0c95fcf7
EZ
29132011-08-25 Eli Zaretskii <eliz@gnu.org>
2914
2915 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2916 the display spec is of the form `(space ...)'.
2917 (handle_display_spec): Return the value returned by
2918 handle_single_display_spec, not just 1 or zero.
2919 (handle_single_display_spec): If the display spec is of the form
2920 `(space ...)', and specifies display in the text area, return 2
2921 rather than 1.
fee65a97 2922 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2923 accurately, and prefer exact match for point under bidi.
2924 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2925
2926 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2927 into disp_prop; all users changed.
2928
2929 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2930 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2931 for the text covered by the display property.
2932
e4ed06f1
CY
29332011-08-25 Chong Yidong <cyd@stupidchicken.com>
2934
2935 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2936 Change return value to nil.
2937 (Frecord_buffer): Delete unused function.
2938
f67cdd7f
EZ
29392011-08-24 Eli Zaretskii <eliz@gnu.org>
2940
5980d4c6
EZ
2941 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2942 buffers, return left-to-right.
8610fe8b
EZ
2943 (set_cursor_from_row): Consider candidate row a win if its glyph
2944 represents a newline and point is on that newline. Fixes cursor
2945 positioning on the newline at EOL of R2L text within L2R
2946 paragraph, and vice versa.
2947 (try_cursor_movement): Check continued rows, in addition to
2948 continuation rows. Fixes unwarranted scroll when point enters a
2949 continued line of R2L text within an L2R paragraph, or vice versa.
2950 (cursor_row_p): Consider the case of point being equal to
2951 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2952 from the end of a short line to the beginning of a continued line
2953 of R2L text within L2R paragraph.
2954 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2955 composed characters.
5980d4c6 2956
f67cdd7f
EZ
2957 * bidi.c (bidi_check_type): Use xassert.
2958 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2959 members.
2960
bca633fb
EZ
29612011-08-23 Eli Zaretskii <eliz@gnu.org>
2962
2963 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2964 a character.
2965
4a5885a7
CY
29662011-08-23 Chong Yidong <cyd@stupidchicken.com>
2967
2968 * nsfont.m (ns_otf_to_script): Fix typo.
2969
0902a04e
KH
29702011-08-22 Kenichi Handa <handa@m17n.org>
2971
2972 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2973 extra slot even if the purpose is char-code-property-table.
2974
1a2e6670
EZ
29752011-08-23 Eli Zaretskii <eliz@gnu.org>
2976
8ddde651
EZ
2977 * xdisp.c (redisplay_window): When computing centering_position,
2978 account for the height of the header line. (Bug#8874)
2979
425cc014
EZ
2980 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2981 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2982 candidate is selected by the mouse, and that candidate has a
2983 composed character under the mouse.
2984
1a2e6670
EZ
2985 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2986 coordinates reported by pos-visible-in-window-p for a composed
2987 character in column zero.
2988
8b76d6f8
SM
29892011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2990
2991 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2992
dac347dd
EZ
29932011-08-22 Eli Zaretskii <eliz@gnu.org>
2994
2995 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2996 consider it a hit if to_charpos is anywhere in the range of the
2997 composed buffer positions.
2998
e013fb34
CY
29992011-08-22 Chong Yidong <cyd@stupidchicken.com>
3000
3001 * image.c (gif_load): Don't assume that each subimage has the same
3002 dimensions as the base image. Handle disposal method that is
3003 "undefined" by the gif spec (Bug#9335).
3004
bd1ba3e8
CY
30052011-08-20 Chong Yidong <cyd@stupidchicken.com>
3006
3007 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3008 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3009
54a1215b
EZ
30102011-08-19 Eli Zaretskii <eliz@gnu.org>
3011
823564e5
EZ
3012 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3013 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3014 from an Org mode buffer to a Speedbar frame.
3015
54a1215b
EZ
3016 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3017 a composition, take its buffer position from IT->cmp_it.charpos.
3018 Fixes cursor positioning at the beginning of a line that begins
3019 with a composed character.
3020
9778ebcc
EZ
30212011-08-18 Eli Zaretskii <eliz@gnu.org>
3022
0be6ee06
EZ
3023 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3024 character bidirectional type, use STRONG_L instead. Fixes crashes
3025 in a buffer produced by `describe-categories'.
3026
9778ebcc
EZ
3027 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3028 members before the level stack, so they would be saved and
3029 restored when copying iterator state. Fixes incorrect reordering
3030 around TABs covered by display properties.
3031
156bffbe
AS
30322011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3033
6b02f655 3034 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3035
72ad093b
CY
30362011-08-17 Chong Yidong <cyd@stupidchicken.com>
3037
3038 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3039 (internal_condition_case_2, internal_condition_case_n):
3040 Remove unnecessary aborts (Bug#9081).
72ad093b 3041
35774242
EZ
30422011-08-17 Eli Zaretskii <eliz@gnu.org>
3043
3044 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3045 has no `load' handler, try opening the file locally. (Bug#9311)
3046
db76dd85
KB
30472011-08-16 Ken Brown <kbrown@cornell.edu>
3048
3049 * gmalloc.c: Expand comment.
3050
b215eee5
EZ
30512011-08-16 Eli Zaretskii <eliz@gnu.org>
3052
3053 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3054 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3055
a4579d33
KB
30562011-08-16 Ken Brown <kbrown@cornell.edu>
3057
3058 Fix memory allocation problems in Cygwin build (Bug#9273).
3059
3060 * unexcw.c ( __malloc_initialized): Declare external variable.
3061 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3062
8b76d6f8
SM
3063 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3064 New variables.
a4579d33
KB
3065 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3066 dumped emacs.
3067 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3068 in the static heap.
3069 [CYGWIN] (special_realloc): New function.
3070 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3071 requests to realloc storage in the static heap.
3072
3ebec551
PE
30732011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3074
3075 * bidi.c (bidi_initialize): Remove unused local.
3076
9fd8be00
EZ
30772011-08-15 Eli Zaretskii <eliz@gnu.org>
3078
6b02f655
SM
3079 * bidimirror.h:
3080 * biditype.h: Remove file.
3081 * makefile.w32-in ($(BLD)/bidi.$(O)):
3082 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3083
3084 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3085
3086 * chartab.c: Improve commentary for the uniprop_table API.
3087
32413314
EZ
3088 * bidi.c (bidi_paragraph_init): Support zero value of
3089 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3090 (bidi_initialize): Use uniprop_table instead of including
3091 biditype.h and bidimirror.h.
32413314 3092
9fd8be00
EZ
3093 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3094 coordinates of the iterator when restoring from ppos_it.
3095 (Bug#9296)
3096
5cf2b69b
KH
30972011-08-14 Kenichi Handa <handa@m17n.org>
3098
3099 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3100 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3101
daf17d00
EZ
31022011-08-14 Eli Zaretskii <eliz@gnu.org>
3103
3104 * xdisp.c (move_it_in_display_line_to): Don't invoke
3105 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3106 ppos_it. Fixes vertical cursor motion when line beginning is
3107 covered by an image. (Bug#9296)
3108
08e3161a
JD
31092011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3110
3111 * nsterm.h (ns_run_ascript): Declare.
3112 (NSAPP_DATA2_RUNASSCRIPT): Define.
3113
3114 * nsfns.m (as_script, as_result, as_status): New static variables.
3115 (ns_run_ascript): New function.
5e617bc2 3116 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3117 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3118 the event loop. Get status from as_status (Bug#7276).
3119
3120 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3121 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3122 the event loop (Bug#7276).
3123
a3720aa2
AS
31242011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3125
3126 * gnutls.c (QCgnutls_bootprop_priority)
3127 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3128 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3129 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3130 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3131 (QCgnutls_bootprop_verify_hostname_error)
3132 (QCgnutls_bootprop_callbacks_verify): Rename from
3133 Qgnutls_bootprop_..., all uses changed.
3134
3135 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3136 uses changed.
3137
0a0d27fb
PE
31382011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3139
19d5c50c
PE
3140 * xfaces.c (Qframe_set_background_mode): Now static.
3141 * dispextern.h (Qframe_set_background_mode): Remove decl.
3142
0a0d27fb
PE
3143 * process.c (Fnetwork_interface_info): Declare local only if needed.
3144
377538cb
JD
31452011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3146
3147 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3148 (Fnetwork_interface_list): Allocate in increments of bytes instead
3149 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3150 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3151 sockaddr.
3152 (struct ifflag_def): notrailers is smart on OSX.
3153 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3154 Get hardware address with getifaddrs if available.
3155
08fff70c
EZ
31562011-08-12 Eli Zaretskii <eliz@gnu.org>
3157
3158 * xdisp.c (iterate_out_of_display_property): xassert that
3159 IT->position is set to within IT->object's boundaries. Break from
3160 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3161 when IT->position is set up wrongly due to some bug.
3162 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3163 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3164 entry. Force push_it to save on the stack the current
3165 buffer/string position, to be restored by pop_it. Fix flags in
3166 the iterator structure wrt the object coming from a display
3167 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3168 properties. (Bug#9284)
3169
7be1c708 31702011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3171
7be1c708
CY
3172 * fontset.c (fontset_get_font_group): Add proper type checks.
3173 (Bug#9172)
aac0c6e3 3174
7be1c708 31752011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3176
7be1c708
CY
3177 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3178 and LC_VERSION_MIN_MACOSX.
3179 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3180 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3181
97bb72a6
EZ
31822011-08-08 Eli Zaretskii <eliz@gnu.org>
3183
3184 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3185 no-display-properties-and-no-overlays under bidi display.
3186 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3187 properties and overlays.
97bb72a6 3188
d5617611
CY
31892011-08-08 Chong Yidong <cyd@stupidchicken.com>
3190
37e11a63
CY
3191 * editfns.c (Fset_time_zone_rule): Document relationship with the
3192 setenv function.
3193
d5617611
CY
3194 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3195 the font entity extracted from the cache (Bug#8109).
3196
58872834
CY
31972011-08-07 Chong Yidong <cyd@stupidchicken.com>
3198
3199 * composite.c (autocmp_chars): Don't reset point. That is done by
3200 restore_point_unwind (Bug#5984).
3201
75bfc667
JL
32022011-08-07 Juri Linkov <juri@jurta.org>
3203
3204 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3205 to show the arg `TIME' instead of `TIMEVAL'.
3206
d1410150
EZ
32072011-08-06 Eli Zaretskii <eliz@gnu.org>
3208
3209 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3210 display property strides EOL and includes a newline, as in
3211 longlines-mode. (Bug#9254)
75b771e4
EZ
3212 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3213 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3214
3215 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3216 is non-zero, even if the data buffer is NULL. Fixes a crash in
3217 vertical-motion with longlines-mode. (Bug#9254)
3218
35928349
EZ
32192011-08-05 Eli Zaretskii <eliz@gnu.org>
3220
ec7cc85b
EZ
3221 * bidi.c <bidi_cache_total_alloc>: Now static.
3222 (bidi_initialize): Initialize bidi_cache_total_alloc.
3223
8b76d6f8 3224 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3225 cache. (Bug#9221)
3226
3227 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3228 amount allocated this far in `bidi_cache_total_alloc'.
3229 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3230 non-zero, only free the data buffer without restoring the cache
3231 contents. All callers changed.
3232
3233 * dispextern.h (bidi_unshelve_cache): Update prototype.
3234
3235 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3236 (move_it_in_display_line, move_it_to)
3237 (move_it_vertically_backward, move_it_by_lines): Replace the call
3238 to xfree to an equivalent call to bidi_unshelve_cache.
3239 (move_it_in_display_line_to): Fix logic of returning
412b6358 3240 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3241
e2e2423b
EZ
32422011-08-05 Eli Zaretskii <eliz@gnu.org>
3243
3244 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3245 came from a string character with a `cursor' property. (Bug#9229)
3246
ae9e757a
JD
32472011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3248
3249 * Makefile.in (LIB_PTHREAD): New variable.
3250 (LIBES): Add LIB_PTHREAD (Bug#9216).
3251
3252 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3253 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3254
213bd7f2
AS
32552011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3256
6b02f655 3257 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3258
99aaf75f
JD
32592011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3260
3261 * xterm.c (x_find_topmost_parent): New function.
3262 (x_set_frame_alpha): Find topmost parent window with
3263 x_find_topmost_parent and set the property there also (bug#9181).
3264 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3265
c74e9d86
PE
32662011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3267
3268 * callproc.c (Fcall_process): Avoid vfork clobbering
3269 the local vars buffer, coding_systems, current_dir.
3270
640c8776
SM
32712011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3272
3273 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3274
f26d0e4c
PE
32752011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3276
8a10d76c
PE
3277 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3278 so that it is not optimized away.
3279
f26d0e4c
PE
3280 * xdisp.c (compute_display_string_pos): Remove unused local.
3281
55439c61
EZ
32822011-08-02 Eli Zaretskii <eliz@gnu.org>
3283
3284 Fix slow cursor motion and scrolling in large buffers with
3285 selective display, like Org Mode buffers. (Bug#9218)
3286
3287 * dispextern.h (struct bidi_it): New member disp_prop_p.
3288
3289 * xdisp.c: Remove one-slot cache of display string positions.
3290 (compute_display_string_pos): Accept an additional argument
5e617bc2 3291 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3292 for a display string or property. If found, set DISP_PROP_P
3293 non-zero.
3294
3295 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3296 DISP_PROP_P, and pass it to compute_display_string_pos.
3297 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3298 non-zero. All callers of bidi_fetch_char changed.
3299
fb33fa43
SM
33002011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3301
3302 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3303
b099e063
DM
33042010-12-03 Don March <don@ohspite.net>
3305
3306 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3307 last character M-[char] is translated to ESC [char] (bug#7541).
3308
5cc7f7af
KH
33092011-08-02 Kenichi Handa <handa@m17n.org>
3310
d0fffa3f 3311 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3312
3313 * chartab.c (uniprop_table): Make it non-static.
3314
525d5e6e
EZ
33152011-08-01 Eli Zaretskii <eliz@gnu.org>
3316
3317 * xdisp.c (forward_to_next_line_start): Accept additional argument
3318 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3319 on the newline.
3320 (reseat_at_next_visible_line_start): Use the bidi iterator state
3321 returned by forward_to_next_line_start to restore the state of
3322 it->bidi_it after backing up to previous newline. (Bug#9212)
3323
31011111
AS
33242011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3325
3326 * regex.c (re_comp): Protoize.
3327 (re_exec): Fix return type.
3328 (regexec): Fix type of `ret'. (Bug#9203)
3329
476371c4
PE
33302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3331
e5d76069
PE
3332 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3333 This is needed if max-image-size is a floating-point number.
3334
9a79b20c
AS
33352011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3336
3337 * print.c (print_object): Print empty symbol as ##.
3338
3339 * lread.c (read1): Read ## as empty symbol.
3340
d8c2fa78
AA
33412011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3342
3343 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3344 setting frame foreground color (Bug#9175).
3345 (x_set_background_color): Likewise.
3346
ffe57a7a
AA
3347 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3348 contents (Bug#9176).
3349 (EmacsTooltip -init): Remove bezels and add shadows to
3350 tooltip windows.
3351
bf3492a5
AA
3352 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3353 or scroll bar (Bug#8470).
3354
d55e9c53
AA
3355 * nsfont.m (nsfont_open): Remove assignment to voffset and
3356 unnecessary vars hshink, expand, hd, full_height, min_height.
3357 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3358
3359 * nsterm.h (nsfont_info): Remove voffset field.
3360
d8c2fa78 33612011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3362
3363 Implement strike-through and overline on NextStep (Bug#8863).
3364
3365 * nsfont.m (nsfont_open): Use underline position provided by font,
3366 instead of hard-coded value of 2.
3367 (nsfont_draw): Call ns_draw_text_decoration instead.
3368
3369 * nsterm.h: Add declaration for ns_draw_text_decoration.
3370
3371 * nsterm.m (ns_draw_text_decoration): New function for drawing
3372 underline, overline, and strike-through.
3373 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3374 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3375 accommodate underlining, etc.
4843aac3 3376
4cc60b9b
EZ
33772011-07-28 Eli Zaretskii <eliz@gnu.org>
3378
bc7ece87
EZ
3379 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3380 default.
4cc60b9b 3381
476371c4
PE
33822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3383
66606eea
PE
3384 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3385 Without this fix, if a signal arrives just after memory fills up,
3386 'malloc' might be invoked reentrantly.
3387
476371c4
PE
3388 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3389 In other words, assume that every image size is allowed, on non-X
3390 hosts. This assumption is probably wrong, but it lets Emacs compile.
3391
f3fcc40d
AS
33922011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3393
3394 * regex.c (re_iswctype): Convert return values to boolean.
3395
350c992f
EZ
33962011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3397
3398 * xdisp.c (compute_display_string_pos): Don't use cached display
3399 string position if the buffer had its restriction changed.
3400 (Bug#9184)
3401
5266b4bb
PE
34022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3403
3404 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3405
2573a837 34062011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3407
41f55ccd 3408 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3409
39e378da
PE
3410 * bidi.c: Integer size and overflow fixes.
3411 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3412 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3413 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3414 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3415 (bidi_find_other_level_edge):
3416 Use ptrdiff_t instead of EMACS_INT where either will do.
3417 This works better on 32-bit hosts configured --with-wide-int.
3418 (bidi_cache_ensure_space): Check for size-calculation overflow.
3419 Use % rather than repeated addition, for better worst-case speed.
3420 Don't set bidi_cache_size until after xrealloc returns, because it
3421 might not return.
3422 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3423 (bidi_cache_ensure_space): Also check that the bidi cache size
3424 does not exceed that of the largest Lisp string or buffer. See Eli
3425 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3426
5e927815
PE
3427 * alloc.c (__malloc_size_t): Remove.
3428 All uses replaced by size_t. See Andreas Schwab's note
3429 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3430
ca4aa935
PE
3431 * image.c: Improve checking for integer overflow.
3432 (check_image_size): Assume that f is nonnull, since
3433 it is always nonnull in practice. This is one less thing to
3434 worry about when checking for integer overflow later.
3435 (x_check_image_size): New function, which checks for integer
3436 overflow issues inside X.
3437 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3438 This removes the need for a memory_full check.
3439 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3440 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3441 (xbm_read_bitmap_data): Change locals back to 'int', since
3442 their values must fit in 'int'.
3443 (xpm_load_image, png_load, tiff_load):
3444 Invoke x_create_x_image_and_pixmap earlier,
3445 to avoid much needless work if the image is too large.
3446 (tiff_load): Treat overly large images as if
3447 x_create_x_image_and_pixmap failed, not as malloc failures.
3448 (gs_load): Use x_check_image_size.
3449
5f8f9cc2
PE
3450 * gtkutil.c: Omit integer casts.
3451 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3452 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3453
5adf60bc
PE
3454 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3455
c8907a93
PE
3456 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3457 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3458 would wrongly return t on a 64-bit host.
3459
e3c25c68
PE
3460 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3461 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3462 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3463 and therefore cause GCC to emit a bogus diagnostic in some cases.
3464
3f791afe
PE
3465 * image.c: Integer signedness and overflow and related fixes.
3466 This is not an exhaustive set of fixes, but it's time to
3467 record what I've got.
3468 (lookup_pixel_color, check_image_size): Remove redundant decls.
3469 (check_image_size): Don't assume that arbitrary EMACS_INT values
3470 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3471 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3472 (tiff_load, imagemagick_load_image):
3473 Check for overflow in size calculations.
3474 (x_create_x_image_and_pixmap): Remove unnecessary test for
3475 xmalloc returning NULL; that can't happen.
3476 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3477 (xpm_color_bucket): Use better integer hashing function.
3478 (xpm_cache_color): Don't possibly over-allocate memory.
3479 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3480 (gif_memory_source):
3481 Use ptrdiff_t, not int or size_t, to record sizes.
3482 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3483 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3484 either works, as we prefer signed integers.
3485 (tiff_read_from_memory, tiff_write_from_memory):
3486 Return tsize_t, not size_t, since that's what the TIFF API wants.
3487 (tiff_read_from_memory): Don't fail simply because the read would
3488 go past EOF; instead, return a short read.
3489 (tiff_load): Omit no-longer-needed casts.
3490 (Fimagemagick_types): Don't assume size fits into 'int'.
3491
3cc5a532
PE
3492 Improve hashing quality when configured --with-wide-int.
3493 * fns.c (hash_string): New function, taken from sxhash_string.
3494 Do not discard information about ASCII character case; this
3495 discarding is no longer needed.
3496 (sxhash-string): Use it. Change sig to match it. Caller changed.
3497 * lisp.h: Declare it.
3498 * lread.c (hash_string): Remove, since we now use fns.c's version.
3499 The fns.c version returns a wider integer if --with-wide-int is
3500 specified, so this should help the quality of the hashing a bit.
3501
b312a492
PE
3502 * emacs.c: Integer overflow minor fix.
3503 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3504 Define only if GNU_LINUX.
3505 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3506
dfd153ae
PE
3507 * dispnew.c: Integer signedness and overflow fixes.
3508 Remove unnecessary forward decls, that were a maintenance hassle.
3509 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3510 All uses changed.
3511 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3512 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3513 (prepare_desired_row, line_draw_cost):
3514 Use int, not unsigned, where either works.
3515 (save_current_matrix, restore_current_matrix):
3516 Use ptrdiff_t, not size_t, where either works.
3517 (init_display): Check for overflow more accurately, and without
3518 relying on undefined behavior.
3519
a81d11a3
PE
3520 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3521 Remove, replacing with the new symbols in lisp.h. All uses changed.
3522 * fileio.c (make_temp_name):
3523 * filelock.c (lock_file_1, lock_file):
3524 * xdisp.c (message_dolog):
3525 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3526 Use pMd etc. instead.
3527 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3528 replacing the pWIDE etc. symbols removed from editfns.c.
3529
3300e6fd
PE
3530 * keyboard.h (num_input_events): Now uintmax_t.
3531 This is (very slightly) less likely to mess up due to wraparound.
3532 All uses changed.
3533
fd05c7e9
PE
3534 * buffer.c: Integer signedness fixes.
3535 (alloc_buffer_text, enlarge_buffer_text):
3536 Use ptrdiff_t rather than size_t when either will do, as we prefer
3537 signed integers.
3538
903fe15d
PE
3539 * alloc.c: Integer signedness and overflow fixes.
3540 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3541 (__malloc_size_t): Default to size_t, not to int.
3542 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3543 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3544 Prefer ptrdiff_t to size_t when either would do, as we prefer
3545 signed integers.
3546 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3547 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3548 Now const. Initialize with values that are in range even if char
3549 is signed.
3550 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3551 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3552 These functions do the right thing with sizes > 2**32.
3553 (check_depth): Now ptrdiff_t, not int.
3554 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3555 Adjust to new way of storing sizes. Check for size overflow bugs
3556 in rest of code.
3557 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3558 slightly wrong anyway, as it missed one instance of
3559 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3560 (refill_memory_reserve): Omit needless cast to size_t.
3561 (mark_object_loop_halt): Mark as externally visible.
3562
ac82cc6a
PE
3563 * xselect.c: Integer signedness and overflow fixes.
3564 (Fx_register_dnd_atom, x_handle_dnd_message):
3565 Use ptrdiff_t, not size_t, since we prefer signed.
3566 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3567 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3568 x_dnd_atoms_size and x_dnd_atoms_length.
3569
c2d1e36d
PE
3570 * doprnt.c: Prefer signed to unsigned when either works.
3571 * eval.c (verror):
3572 * doprnt.c (doprnt):
3573 * lisp.h (doprnt):
3574 * xdisp.c (vmessage):
3575 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3576 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3577 prefer signed arithmetic to avoid comparison confusion.
3578 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3579 but is a bit tricky.
3580
0e926e56
PE
3581 Assume freestanding C89 headers, string.h, stdlib.h.
3582 * data.c, doprnt.c, floatfns.c, print.c:
3583 Include float.h unconditionally.
3584 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3585 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3586 * regex.c: Likewise for stddef.h, string.h.
3587 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3588 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3589 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3590 (STDC_HEADERS): Remove obsolete defines.
3591 * sysdep.c: Include limits.h unconditionally.
3592
9cfdb3ec
PE
3593 Assume support for memcmp, memcpy, memmove, memset.
3594 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3595 * regex.c (memcmp, memcpy):
3596 Remove; we assume C89 now.
3597
3598 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3599 (__malloc_safe_bcopy): Remove; no longer needed.
3600
cf950e6b 3601 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3602 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3603 well either way, and we prefer signed to unsigned.
3604
dbf38e02
LMI
36052011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3606
3607 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3608 closes the connection while we're reading (bug#9182).
3609
d6f0886c 36102011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3611
d6f0886c
JD
3612 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3613 are specified (Bug#9168).
24e0f6b1 3614
2eb1f9e6
PE
36152011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3616
3617 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3618 Found by GCC static checking and --with-wide-int on a 32-bit host.
3619
22381272 36202011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3621
3622 * xdisp.c (compute_display_string_pos): Fix logic of caching
3623 previous display string position. Initialize cached_prev_pos to
3624 -1. Fixes slow-down at the beginning of a buffer.
3625
f25e39b4
EZ
36262011-07-24 Eli Zaretskii <eliz@gnu.org>
3627
3628 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3629 for attrs[LFACE_FONTSET_INDEX].
3630
04c4b52e
PE
36312011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3632
3633 * xml.c (parse_region): Remove unused local
3634 that was recently introduced.
3635
c1734fbd
EZ
36362011-07-23 Eli Zaretskii <eliz@gnu.org>
3637
be18c5a5
EZ
3638 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3639 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3640
c1734fbd
EZ
3641 * xdisp.c (move_it_in_display_line_to): Record the best matching
3642 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3643 exit if none of the characters scanned was an exact match.
3644 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3645 when exact match is impossible due to invisible text, and the
3646 lines are truncated.
3647
a258d627
JD
36482011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3649
3650 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3651 for OSX >= 10.7.
3652
b6d5a689
EZ
36532011-07-22 Eli Zaretskii <eliz@gnu.org>
3654
0f74f785
EZ
3655 Fix a significant slow-down of cursor motion with C-n, C-p,
3656 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3657 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3658 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3659 (next_element_from_buffer): Call compute_stop_pos_backwards to
3660 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3661 base_level_stop.
3662 (reseat): Don't look for prev_stop, as that could mean a very long
3663 run.
3664 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3665 <cached_disp_overlay_modiff>: Cache for last found display string
3666 position.
551918c1 3667 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3668 about the same buffer in the same area of character positions, and
3669 the buffer wasn't changed since the time the display string
3670 position was cached.
551918c1 3671
b2d0c91a
EZ
36722011-07-22 Eli Zaretskii <eliz@gnu.org>
3673
3674 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3675 is an integer, which is important for empty lines. (Bug#9149)
3676
043604ee
CY
36772011-07-22 Chong Yidong <cyd@stupidchicken.com>
3678
3679 * frame.c (Fmodify_frame_parameters): In tty case, update the
3680 default face if necessary (Bug#4238).
3681
da4adb04
CY
36822011-07-21 Chong Yidong <cyd@stupidchicken.com>
3683
3684 * editfns.c (Fstring_to_char): No need to explain what a character
3685 is in the docstring (Bug#6576).
3686
9abd0532
LMI
36872011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3688
3689 * xml.c (parse_region): Make sure we always return a tree.
3690
36881d16
HK
36912011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3692
3693 * xml.c (parse_region): If a document contains only comments,
3694 return that, too.
3695
1e98674d
LMI
36962011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3697
3698 * xml.c (make_dom): Return comments, too.
3699
590bd467
PE
37002011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3701
3702 Port to OpenBSD.
3703 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3704 and the surrounding thread.
3705 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3706 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3707 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3708 timer goes off.
3709 * s/openbsd.h (BROKEN_SIGIO): Define.
3710 * unexelf.c (unexec) [__OpenBSD__]:
3711 Don't update the .mdebug section of the Alpha COFF symbol table.
3712
f41628b2
LMI
37132011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3714
3715 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3716 (bug#8460).
3717
b59b67c5
PE
37182011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3719
15e3a074
PE
3720 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3721 This fixes some race conditions on the permissions of any newly
3722 created file.
3723
41bed37d
PE
3724 * alloc.c (valid_pointer_p): Use pipe, not open.
3725 This fixes some permissions issues when debugging.
3726
b59b67c5
PE
3727 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3728 If fchown fails to set both uid and gid, try to set just gid,
3729 as that is sometimes allowed. Adjust the file's mode to eliminate
3730 setuid or setgid bits that are inappropriate if fchown fails.
3731
925a6be7
SM
37322011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3733
3734 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3735 to compare Lisp_Objects.
3736 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3737 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3738 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3739
52968808
AS
37402011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3741
0a6a104b
AS
3742 * lread.c (read_integer): Unread even EOF character.
3743 (read1): Likewise. Properly record start position of symbol.
3744
52968808
AS
3745 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3746 symbol character follows.
3747
9e381cdd
PE
37482011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3749
3750 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3751 This works around a problem with the previous change to Fcopy_file.
3752 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3753 and without this change, GCC might complain about discarding
3754 fchown's return value.
3755
b5641435
JB
37562011-07-16 Juanma Barranquero <lekktu@gmail.com>
3757
3758 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3759
a8031457
PE
37602011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3761
3762 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3763
dd889327
LMI
37642011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3765
750c33f7
LMI
3766 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3767 it's used from the C level.
3768
dd889327
LMI
3769 * process.c: Use the same condition for POLL_FOR_INPUT in both
3770 keyboard.c and process.c (bug#1858).
3771
87e86684
LM
37722011-07-09 Lawrence Mitchell <wence@gmx.li>
3773
3774 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3775 (Fgnutls_boot): Use it.
3776
64348f40
AS
37772011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3778
3779 * doc.c (Fsubstitute_command_keys): Revert last change.
3780
1d698799
LMI
37812011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3782
f863868c
LMI
3783 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3784 quotes the next character, and doesn't affect other longer
3785 sequences (bug#8935).
3786
1d698799
LMI
3787 * lread.c (syms_of_lread): Clarify that is isn't only
3788 `eval-buffer' and `eval-defun' that's affected by
3789 `lexical-binding' (bug#8460).
3790
aa4b6df6
EZ
37912011-07-15 Eli Zaretskii <eliz@gnu.org>
3792
3793 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3794 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3795
5d856da6
PE
37962011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3797
ad6042bb
PE
3798 Fix minor problems found by static checking.
3799 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3800 (elsz): Now a signed constant, not a size_t var. We prefer signed
3801 types to unsigned, to avoid integer comparison confusion. Without
3802 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3803 "cannot optimize loop, the loop counter may overflow", a symptom
3804 of the confusion.
f00bbb22 3805 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3806 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3807
6468f31c
LMI
38082011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3809
49080b10
LMI
3810 * search.c (Fre_search_backward): Mention `case-fold-search' in
3811 all the re_search_* functions (bug#8138).
3812
6468f31c
LMI
3813 * keyboard.c (Fopen_dribble_file): Document when the file is
3814 closed (bug#8056).
3815
c965adc5
EZ
38162011-07-14 Eli Zaretskii <eliz@gnu.org>
3817
df9733bf
EZ
3818 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3819 bidi_cache_idx.
3820
0bb23927
EZ
3821 Support bidi reordering of display and overlay strings.
3822 * xdisp.c (compute_display_string_pos)
3823 (compute_display_string_end): Accept additional argument STRING.
3824 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3825 (reseat_to_string): Initialize bidi_it->string.s and
3826 bidi_it->string.schars.
3827 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3828 NULL (avoids a crash in bidi_paragraph_init).
3829 Initialize itb.string.lstring.
0bb23927
EZ
3830 (init_iterator): Call bidi_init_it only of a valid
3831 buffer position was specified. Initialize paragraph_embedding to
3832 L2R.
3833 (reseat_to_string): Initialize the bidi iterator.
3834 (display_string): If we need to ignore text properties of
3835 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3836 original value of -1 will not work with bidi.)
3837 (compute_display_string_pos): First arg is now struct
3838 `text_pos *'; all callers changed. Support display properties on
3839 Lisp strings.
3840 (compute_display_string_end): Support display properties on Lisp
3841 strings.
3842 (init_iterator, reseat_1, reseat_to_string): Initialize the
3843 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3844 when iterating on a string not from display properties).
640c8776
SM
3845 (compute_display_string_pos, compute_display_string_end):
3846 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3847 arrow keys.
3848 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3849 base_level_stop; instead, set base_level_stop to BEGV.
3850 Fixes crashes in vertical-motion.
0bb23927
EZ
3851 (next_element_from_buffer): Improve commentary for when
3852 the iterator is before prev_stop.
3853 (init_iterator): Initialize bidi_p from the default value of
3854 bidi-display-reordering, not from buffer-local value. Use the
3855 buffer-local value only if initializing for buffer iteration.
3856 (handle_invisible_prop): Support invisible properties on strings
3857 that are being bidi-reordered.
3858 (set_iterator_to_next): Support bidi reordering of C strings and
3859 Lisp strings.
3860 (next_element_from_string): Support bidi reordering of Lisp
3861 strings.
3862 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3863 (display_string): Support display of R2L glyph rows.
3864 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3865 (init_iterator): Don't initialize it->bidi_p for strings
3866 here.
3867 (reseat_to_string): Initialize it->bidi_p for strings here.
3868 (next_element_from_string, next_element_from_c_string)
3869 (next_element_from_buffer): Add xassert's for correspondence
3870 between IT's object being iterated and it->bidi_it.string
3871 structure.
3872 (face_before_or_after_it_pos): Support bidi iteration.
3873 (next_element_from_c_string): Handle the case of the first string
3874 character that is not the first one in the visual order.
3875 (get_visually_first_element): New function, refactored from common
3876 parts of next_element_from_buffer, next_element_from_string, and
3877 next_element_from_c_string.
3878 (tool_bar_lines_needed, redisplay_tool_bar)
3879 (display_menu_bar): Force left-to-right direction. Add a FIXME
3880 comment for making that be controlled by a user option.
3881 (push_it, pop_it): Save and restore the state of the
3882 bidi iterator. Save and restore the bidi_p flag.
3883 (pop_it): Iterate out of display property for string iteration as
3884 well.
3885 (iterate_out_of_display_property): Support iteration over strings.
3886 (handle_single_display_spec): Set up it->bidi_it for iteration
3887 over a display string, and call bidi_init_it.
3888 (handle_single_display_spec, next_overlay_string)
3889 (get_overlay_strings_1, push_display_prop): Set up the bidi
3890 iterator for displaying display or overlay strings.
3891 (forward_to_next_line_start): Don't use the shortcut if
3892 bidi-iterating.
3893 (back_to_previous_visible_line_start): If handle_display_prop
3894 pushed the iterator stack, restore the internal state of the bidi
3895 iterator by calling bidi_pop_it same number of times.
3896 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3897 and we are bidi-iterating, don't decrement the iterator position;
3898 instead, set the first_elt flag in the bidi iterator, to produce
3899 the same effect.
3900 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3901 (push_display_prop): xassert that we are iterating a buffer.
3902 (push_it, pop_it): Save and restore paragraph_embedding member.
3903 (handle_single_display_spec, next_overlay_string)
3904 (get_overlay_strings_1, reseat_1, reseat_to_string)
3905 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3906 correctly. Don't assume unibyte strings are not bidi-reordered.
3907 (compute_display_string_pos)
3908 (compute_display_string_end): Fix handling the case of C string.
3909 (push_it, pop_it): Save and restore from_disp_prop_p.
3910 (handle_single_display_spec, push_display_prop): Set the
3911 from_disp_prop_p flag.
3912 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3913 (pop_it): Call iterate_out_of_display_property only if we are
3914 popping after iteration over a string that came from a display
3915 property. Fix a typo in popping stretch info. Add an assertion
3916 for verifying that the iterator position is in sync with the bidi
3917 iterator.
3918 (handle_single_display_spec, get_overlay_strings_1)
3919 (push_display_prop): Fix initialization of paragraph direction for
3920 string when that of the parent object is not yet determined.
3921 (reseat_1): Call bidi_init_it to resync the bidi
3922 iterator with IT's position. (Bug#7616)
3923 (find_row_edges): If ROW->start.pos gives position
3924 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3925 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3926 Reset the from_disp_prop_p flag.
3927 (SAVE_IT, RESTORE_IT): New macros.
3928 (pos_visible_p, face_before_or_after_it_pos)
3929 (back_to_previous_visible_line_start)
3930 (move_it_in_display_line_to, move_it_in_display_line)
3931 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3932 (try_scrolling, redisplay_window, display_line): Use them when
3933 saving a temporary copy of the iterator and restoring it back.
3934 (back_to_previous_visible_line_start, reseat_1)
3935 (init_iterator): Empty the bidi cache "stack".
3936 (move_it_in_display_line_to): If iterator ended up at
3937 EOL, but we never saw any buffer positions smaller than
3938 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3939 motion in bidi-reordered lines.
3940 (move_it_in_display_line_to): Record prev_method and prev_pos
3941 immediately before the call to set_iterator_to_next. Fixes cursor
3942 motion in bidi-reordered lines with stretch glyphs and strings
3943 displayed in margins. (Bug#8133) (Bug#8867)
3944 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3945 TO_CHARPOS.
640c8776
SM
3946 (pos_visible_p): Support positions in bidi-reordered lines.
3947 Save and restore bidi cache.
0bb23927
EZ
3948
3949 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3950 (bidi_paragraph_info): Delete unused struct.
3951 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3952 (bidi_cache_start): New variable.
3953 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3954 to zero.
3955 (bidi_cache_fetch_state, bidi_cache_search)
3956 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3957 (bidi_cache_find, bidi_peek_at_next_level)
3958 (bidi_level_of_next_char, bidi_find_other_level_edge)
3959 (bidi_move_to_visually_next): Compare cache index with
3960 bidi_cache_start rather than with zero.
3961 (bidi_fetch_char): Accept new argument STRING; all callers
3962 changed. Support iteration over a string. Support strings with
3963 display properties. Support unibyte strings. Fix the type of
3964 `len' according to what STRING_CHAR_AND_LENGTH expects.
3965 (bidi_paragraph_init, bidi_resolve_explicit_1)
3966 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3967 (bidi_level_of_next_char, bidi_move_to_visually_next):
3968 Support iteration over a string.
0bb23927
EZ
3969 (bidi_set_sor_type, bidi_resolve_explicit_1)
3970 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3971 can now be zero (for strings); special values 0 and -1 were
3972 changed to -1 and -2, respectively.
3973 (bidi_char_at_pos): New function.
3974 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3975 Call it instead of FETCH_MULTIBYTE_CHAR.
3976 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3977 initialized to valid values.
3978 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3979 values.
3980 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3981 the test for valid cached positions. Fix the logic for looking up
3982 the sentinel state in the cache. GCPRO the Lisp string we are
3983 iterating.
3984 (bidi_push_it, bidi_pop_it): New functions.
3985 (bidi_initialize): Initialize the bidi cache start stack pointer.
3986 (bidi_cache_ensure_space): New function, refactored from part of
3987 bidi_cache_iterator_state. Don't assume the required size is just
3988 one BIDI_CACHE_CHUNK away.
3989 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3990 (bidi_count_bytes, bidi_char_at_pos): New functions.
3991 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3992 always valid if bidi_cache_idx is valid.
3993 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3994 is valid if it's going to be used.
3995 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3996 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3997 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3998 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3999 (bidi_find_other_level_edge, bidi_cache_start_stack):
4000 All variables related to cache indices are now EMACS_INT.
c965adc5 4001
0bb23927
EZ
4002 * dispextern.h (struct bidi_string_data): New structure.
4003 (struct bidi_it): New member `string'. Make flag members be 1-bit
4004 fields, and put them last in the struct.
640c8776
SM
4005 (compute_display_string_pos, compute_display_string_end):
4006 Update prototypes.
0bb23927
EZ
4007 (bidi_push_it, bidi_pop_it): Add prototypes.
4008 (struct iterator_stack_entry): New members bidi_p,
4009 paragraph_embedding, and from_disp_prop_p.
4010 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4011 (bidi_shelve_cache, bidi_unshelve_cache):
4012 Declare prototypes.
0bb23927
EZ
4013
4014 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4015 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4016 and vector-like objects.
4017
4018 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4019 cache around display iteration.
4020
4021 * window.c (Fwindow_end, window_scroll_pixel_based)
4022 (displayed_window_lines, Frecenter): Save and restore the bidi
4023 cache around display iteration.
4024
3bbd2265
LMI
40252011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4026
4027 * editfns.c (Fdelete_region): Clarify the use of the named
4028 parameters (bug#6788).
4029
adc47434
MR
40302011-07-14 Martin Rudalics <rudalics@gmx.at>
4031
4032 * indent.c (Fvertical_motion): Set and restore w->pointm when
4033 saving and restoring the window's buffer (Bug#9006).
4034
837c31f8
LMI
40352011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4036
4037 * editfns.c (Fstring_to_char): Clarify just what is returned
4038 (bug#6576). Text by Eli Zaretskii.
4039
ac389d0c
JB
40402011-07-13 Juanma Barranquero <lekktu@gmail.com>
4041
4042 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4043
0be0ce47
EZ
40442011-07-13 Eli Zaretskii <eliz@gnu.org>
4045
4046 * buffer.c (mmap_find): Fix a typo.
4047
cd18e7e3
JB
40482011-07-13 Johan Bockgård <bojohan@gnu.org>
4049
4050 Fix execution of x selection hooks.
4051 * xselect.c (Qx_lost_selection_functions)
4052 (Qx_sent_selection_functions): New vars.
4053 (syms_of_xselect): DEFSYM them.
4054 (x_handle_selection_request): Pass Qx_sent_selection_functions
4055 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4056 (x_handle_selection_clear,x_clear_frame_selections):
4057 Pass Qx_lost_selection_functions rather than
4058 Vx_lost_selection_functions to Frun_hook_with_args.
4059
47ea7f44
PE
40602011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4061
ac389d0c 4062 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4063 The old code sometimes used this field without initializing it.
4064
47ea7f44
PE
4065 * alloc.c (gc_sweep): Don't read past end of array.
4066 In theory, the old code could also have corrupted Emacs internals,
4067 though it'd be very unlikely.
4068
bc985c87
AS
40692011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4070
4071 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4072 argument. (Bug#4026)
bc985c87 4073
0cf34688
LMI
40742011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4075
b3dadd76
LMI
4076 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4077 key" (bug#4257).
4078
0cf34688
LMI
4079 * window.c (Fset_window_start): Doc fix (bug#4199).
4080 (Fset_window_hscroll): Ditto.
4081
270768cd
PE
40822011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4083
077e3dda 4084 Fix minor new problems caught by GCC 4.6.1.
270768cd 4085 * term.c (init_tty): Remove unused local.
490011a6 4086 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4087 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4088 not used otherwise.
270768cd 4089
b1f58454
CY
40902011-07-12 Chong Yidong <cyd@stupidchicken.com>
4091
4092 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4093
22b9578d
LMI
40942011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4095
6e70ab07
LMI
4096 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4097 are the mini-buffer and the echo area (bug#3320).
4098
22b9578d
LMI
4099 * term.c (init_tty): Remove support for supdup, c10 and perq
4100 terminals, which are no longer supported (bug#1482).
4101
8974cc9f
JB
41022011-07-10 Johan Bockgård <bojohan@gnu.org>
4103
4104 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4105
a560d974
JD
41062011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4107
4108 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4109 for non-popups (Bug#3642).
4110
1dae0f0a
AS
41112011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4112
268c2c36 4113 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4114 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4115 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4116 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4117 * data.c (fmod): Likewise.
4118 * dispnew.c (swap_glyphs_in_rows): Likewise.
4119 * emacs.c (memory_warning_signal): Likewise.
4120 * floatfns.c (float_error): Likewise.
4121 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4122 (otf_open, font_otf_capability, generate_otf_features)
4123 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4124 Likewise.
4125 * image.c (pbm_read_file): Likewise.
4126 * indent.c (string_display_width): Likewise.
4127 * intervals.c (check_for_interval, search_for_interval)
4128 (inc_interval_count, count_intervals, root_interval)
4129 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4130 * lread.c (defalias): Likewise.
268c2c36 4131 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4132 * regex.c (set_image_of_range_1, set_image_of_range)
4133 (regex_grow_registers): Likewise.
4134 * sysdep.c (strerror): Likewise.
4135 * termcap.c (valid_filename_p, tprint, main): Likewise.
4136 * tparam.c (main): Likewise.
4137 * unexhp9k800.c (run_time_remap, save_data_space)
4138 (update_file_ptrs, read_header, write_header, calculate_checksum)
4139 (copy_file, copy_rest, display_header): Likewise.
4140 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4141 Likewise.
4142 * xdisp.c (check_it): Likewise.
4143 * xfaces.c (register_color, unregister_color, unregister_colors):
4144 Likewise.
4145 * xfns.c (print_fontset_result): Likewise.
4146 * xrdb.c (member, fatal, main): Likewise.
4147
99033785
PE
41482011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4149
4150 Fix minor problems found by static checking (Bug#9031).
4151 * chartab.c (char_table_set_range, map_sub_char_table):
4152 Remove unused locals.
4153 (uniprop_table): Now static.
4154 * composite.c (_work_char): Remove unused static var.
4155
9cb2ac56
JB
41562011-07-09 Juanma Barranquero <lekktu@gmail.com>
4157
4158 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4159
f25661f0
JD
41602011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4161
4162 * gtkutil.c (qttip_cb): Remove code without function.
4163
8278c4fe
EZ
41642011-07-09 Eli Zaretskii <eliz@gnu.org>
4165
4166 * w32.c (pthread_sigmask): New stub.
4167
1692ae2d 41682011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4169
8a6ebd58 4170 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4171 sigprocmask is portable only for single-threaded applications, and
4172 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4173 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4174 (LIBES): Use it.
4175 * callproc.c (Fcall_process):
4176 * process.c (create_process):
4177 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4178 Use pthread_sigmask, not sigprocmask.
123403e4 4179
1b854618
JD
41802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4181
4182 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4183 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4184 wrong (Bug#8591).
4185
3fe4b549
JD
41862011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4187
0ce7e563
JD
4188 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4189 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4190 (xg_hide_tooltip): Fix comment.
4191
3fe4b549
JD
4192 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4193 in registerServicesMenuSendTypes.
4194 (validRequestorForSendType): Don't check ns_return_types.
4195
4196 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4197 ns_return_type.
4198
5df75e47
JR
41992011-07-08 Jason Rumney <jasonr@gnu.org>
4200
22610910
JR
4201 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4202 SH_SHOW for hidden windows (Bug#5482).
4203
5df75e47
JR
4204 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4205 frame struct members of non-existent frames (Bug#6284).
4206
699c10bd
JD
42072011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4208
4393663b
JD
4209 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4210 variable firstTime not needed on OSX >= 10.6.
4211 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4212 >= 10.5. Use setKnobProportion, setDoubleValue.
4213
4214 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4215 (MAC_OS_X_VERSION_10_5): Define if not defined.
4216 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4217 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4218 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4219
4220 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4221 cString and lossyCString on OSX >= 10.4
4222
58179cce 4223 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4224 sizeToFit on OSX >= 10.2.
4225
4226 * nsimage.m (allocInitFromFile): Don't use deprecated method
4227 bestRepresentationForDevice on OSX >= 10.6.
4228
4229 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4230 to avoid warning.
4231
4232 * emacs.c: Declare unexec_init_emacs_zone.
4233
a63e0781
JD
4234 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4235
699c10bd
JD
4236 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4237
4238 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4239 on svcsMenu (Bug#8842).
4240
4241 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4242 ns_return_types.
4243 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4244
4245 * nsterm.m (QUTF8_STRING): Declare.
4246 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4247 (validRequestorForSendType): Return type is (id).
4248 Change indexOfObjectIdenticalTo to indexOfObject.
4249 Check if we have local selection before returning self (Bug#8842).
4250 (writeSelectionToPasteboard): Put local selection into paste board
4251 if we have a local selection (Bug#8842).
4252 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4253
4254 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4255 (ns_get_local_selection): Declare.
4256
54e10184
LMI
42572011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4258
9888ff71
LMI
4259 * keymap.c (describe_map_tree): Don't insert a double newline at
4260 the end of the buffer (bug#1169) and return whether we inserted
4261 something.
4262
54e10184
LMI
4263 * callint.c (Fcall_interactively): Change "reading args" to
4264 "providing args" to try to clarify what it does (bug#1010).
4265
15fa4783
KH
42662011-07-07 Kenichi Handa <handa@m17n.org>
4267
4268 * composite.c (composition_compute_stop_pos): Ignore a static
4269 composition starting before CHARPOS (Bug#8915).
4270
4271 * xdisp.c (handle_composition_prop): Likewise.
4272
a8815b00
EZ
42732011-07-07 Eli Zaretskii <eliz@gnu.org>
4274
4275 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4276 (Bug#9015)
4277
ef7b981d 42782011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4279
4280 * character.h (unicode_category_t): New enum type.
4281
4282 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4283 (Qchar_code_property_table): New variable.
4284 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4285 (UNIPROP_COMPRESSED_FORM_P): New macros.
4286 (char_table_ascii): Uncompress the compressed values.
4287 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4288 Uncompress the compressed values.
ac389d0c 4289 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4290 (char_table_ref_and_range): Uncompress the compressed values.
4291 (sub_char_table_set): New arg is_uniprop. Callers changed.
4292 Uncompress the compressed values.
4293 (sub_char_table_set_range): Args changed. Callers changed.
4294 (char_table_set_range): Adjuted for the above change.
4295 (map_sub_char_table): Delete args default_val and parent. Add arg
4296 top. Give decoded values to a Lisp function.
640c8776 4297 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4298 values to a Lisp function. Gcpro more variables.
4299 (uniprop_table_uncompress)
4300 (uniprop_decode_value_run_length): New functions.
4301 (uniprop_decoder, uniprop_decoder_count): New variables.
4302 (uniprop_get_decoder, uniprop_encode_value_character)
4303 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4304 New functions.
4305 (uniprop_encoder, uniprop_encoder_count): New variables.
4306 (uniprop_get_encoder, uniprop_table)
4307 (Funicode_property_table_internal, Fget_unicode_property_internal)
4308 (Fput_unicode_property_internal): New functions.
4309 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4310 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4311 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4312 char-code-property-alist.
4313
640c8776 4314 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4315 Vunicode_category_table.
4316
640c8776 4317 * font.c (font_range): Adjust for the change of
c805dec0
KH
4318 Vunicode_category_table.
4319
76b397fb
DN
43202011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4321
4322 * m/iris4d.h: Remove file, move contents ...
4323 * s/irix6-5.h: ... here.
4324
22b4128e
PE
43252011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4326
4327 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4328 * alloc.c (mark_buffer):
4329 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4330 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4331 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4332 This isn't true in general, and it's particularly not true
4333 if Emacs is configured with --with-wide-int.
4334 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4335 New macros, used in the buffer.c change.
4336
869795d6
JD
43372011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4338
4339 * xsettings.c: Use both GConf and GSettings if both are available.
4340 (store_config_changed_event): Add comment.
4341 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4342 (store_tool_bar_style_changed): New functions.
5e617bc2 4343 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4344 (struct xsettings): Move font inside HAVE_XFT.
4345 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4346 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4347 Move inside HAVE_XFT.
640c8776 4348 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4349 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4350 also.
4351 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4352 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4353 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4354 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4355 (parse_settings): Move check for font inside HAVE_XFT.
4356 (read_settings, apply_xft_settings): Add comment.
4357 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4358 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4359 call store_font_name_changed.
4360 (xft_settings_event): Add comment.
4361 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4362 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4363 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4364 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4365 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4366 (xsettings_get_system_font, xsettings_get_system_normal_font):
4367 Add comment.
869795d6 4368
d8ed26bd
PE
43692011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4370
4371 Random fixes. E.g., (random) never returned negative values.
4372 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4373 subseconds part to the entropy, as that's a bit more random.
4374 Prefer signed to unsigned, since the signedness doesn't matter and
4375 in general we prefer signed. When given a limit, use a
4376 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4377 latter isn't right if USE_2_TAGS_FOR_INTS.
4378 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4379 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4380
cabf1cac
SM
43812011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4382
4383 * textprop.c (text_property_stickiness):
4384 Obey Vtext_property_default_nonsticky.
4385 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4386 * w32fns.c (syms_of_w32fns):
4387 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4388
6e9b2be9
PE
43892011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4390
4391 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4392 This is more efficient than Ffile_directory_p and avoids a minor race.
4393
90186c68
LMI
43942011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4395
7c301272
LMI
4396 * buffer.c (Foverlay_put): Say what the return value is
4397 (bug#7835).
4398
c4f2d8d4
LMI
4399 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4400 is a directory before asking whether to use the file name
4401 (bug#7564).
ad637907
LMI
4402 (barf_or_query_if_file_exists): Make the "File is a directory"
4403 error be more correct.
c4f2d8d4 4404
90186c68
LMI
4405 * fns.c (Frequire): Remove the mention of the .gz files, since
4406 that's installation-specific, but keep the mention of
4407 `get-load-suffixes'.
4408
da64016e
PE
44092011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4410
4411 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4412 Report string overflow if the output is too long.
4413
7d47b580
JB
44142011-07-04 Juanma Barranquero <lekktu@gmail.com>
4415
a555cb87
JB
4416 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4417 (syms_of_gnutls): Remove duplicate DEFSYM for
4418 Qgnutls_bootprop_verify_hostname_error, an error for
4419 Qgnutls_bootprop_verify_error (which is no longer used).
4420
7d47b580
JB
4421 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4422 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4423 Also (re)move comments that are misplaced or no longer relevant.
4424
1e49bfab
LMI
44252011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4426
4427 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4428
1485f4c0
CY
44292011-07-03 Chong Yidong <cyd@stupidchicken.com>
4430
4431 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4432 and background color parameters if they have been changed.
4433
a9ab721e
LMI
44342011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4435
4436 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4437
cf7cff57
PE
44382011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4439
2e13213d
PE
4440 * xsettings.c (SYSTEM_FONT): Define only when used.
4441 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4442
cf7cff57
PE
4443 * keymap.c (access_keymap_1): Now static.
4444
7a8e04f7
CY
44452011-07-02 Chong Yidong <cyd@stupidchicken.com>
4446
4447 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4448 leave any prefix arg for the up event (Bug#1586).
4449
61352f62
LMI
44502011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4451
69bb1ef7
LMI
4452 * lread.c (syms_of_lread): Mention single symbols defined by
4453 `defvar' or `defconst' (bug#7154).
4454
61352f62 4455 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4456 (Frequire): Mention get-load-suffixes.
61352f62 4457
28545e04
MR
44582011-07-02 Martin Rudalics <rudalics@gmx.at>
4459
4460 * window.h (window): Remove clone_number slot.
4461 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4462 Remove.
4463 (make_parent_window, make_window, saved_window)
4464 (Fset_window_configuration, save_window_save): Don't deal with
4465 clone numbers.
4466 * buffer.c (Qclone_number): Remove declaration.
4467 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4468
3349e122
SM
44692011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4470
4471 Add multiple inheritance to keymaps.
4472 * keymap.c (Fmake_composed_keymap): New function.
4473 (Fset_keymap_parent): Simplify.
4474 (fix_submap_inheritance): Remove.
4475 (access_keymap_1): New function extracted from access_keymap to handle
4476 embedded parents and handle lists of maps.
4477 (access_keymap): Use it.
4478 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4479 (Fcopy_keymap): Handle embedded parents.
4480 (Fcommand_remapping, define_as_prefix): Simplify.
4481 (Fkey_binding): Simplify.
4482 (syms_of_keymap): Move minibuffer-local-completion-map,
4483 minibuffer-local-filename-completion-map,
4484 minibuffer-local-must-match-map, and
4485 minibuffer-local-filename-must-match-map to Elisp.
4486 (syms_of_keymap): Defsubr make-composed-keymap.
4487 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4488 (parse_menu_item): Trivial simplification.
4489
3279eb87
GM
44902011-07-01 Glenn Morris <rgm@gnu.org>
4491
4492 * Makefile.in (SETTINGS_LIBS): Fix typo.
4493
4550efdf
KI
44942011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4495
4496 * coding.c (Fencode_coding_string): Record the last coding system
4497 used, as the function doc string says (bug#8738).
4498
0949d2b6
JD
44992011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4500
4501 * xsettings.c (store_monospaced_changed): Take new font as arg and
4502 check for change against current_mono_font.
4503 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4504 (emacs_settings_constructor, emacs_settings_get_property)
4505 (emacs_settings_set_property, emacs_settings_class_init)
4506 (emacs_settings_init, gsettings_obj): Remove.
4507 (something_changedCB): New function for HAVE_GSETTINGS.
4508 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4509 with value as argument.
4510 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4511 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4512 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4513 "changed".
4514
4515 * xgselect.c: Add defined (HAVE_GSETTINGS).
4516 (xgselect_initialize): Ditto.
4517
4518 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4519 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4520 xg_select.
4521
bbc6b304
PE
45222011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4523
4524 * eval.c (struct backtrace): Simplify and port the data structure.
4525 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4526 signed bit field, as this assumption is not portable and it makes
4527 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4528 "char debug_on_exit : 1" as this is not portable either; instead,
4529 use the portable "unsigned int debug_on_exit : 1". Remove unused
4530 member evalargs. Remove obsolete comments about cc bombing out.
4531
9851bfc5
JD
45322011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4533
51bb811f 4534 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4535 Let HAVE_GSETTINGS override HAVE_GCONF.
4536 (store_monospaced_changed): New function.
4537 (EMACS_SETTINGS): A new type derived from GObject to handle
4538 GSettings notifications.
4539 (emacs_settings_constructor, emacs_settings_get_property)
4540 (emacs_settings_set_property, emacs_settings_class_init):
4541 New functions.
4542 (gsettings_client, gsettings_obj): New variables.
4543 (GSETTINGS_SCHEMA): New define.
4544 (something_changedCB): Call store_monospaced_changed.
4545 (init_gsettings): New function.
4546 (xsettings_initialize): Call init_gsettings.
4547 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4548 to NULL.
4549
640c8776 4550 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4551 GCONF_CFLAGS/LIBS.
4552
5386012d
MR
45532011-06-29 Martin Rudalics <rudalics@gmx.at>
4554
4555 * window.c (resize_root_window, grow_mini_window)
4556 (shrink_mini_window): Rename Qresize_root_window to
4557 Qwindow_resize_root_window and Qresize_root_window_vertically to
4558 Qwindow_resize_root_window_vertically.
4559
f13e0b08
PE
45602011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4561
4562 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4563
94515237
JB
45642011-06-27 Juanma Barranquero <lekktu@gmail.com>
4565
4566 * makefile.w32-in: Redesign dependencies so they reflect more
4567 clearly which files are directly included by each source file,
4568 and not through other includes.
4569
e43b6e43
MR
45702011-06-27 Martin Rudalics <rudalics@gmx.at>
4571
4572 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4573 (sort_overlays, overlay_strings): When an overlay's clone number
4574 matches the window's clone number process the overlay even if
4575 the overlay's window property doesn't match the current window.
4576
d68443dc
MR
4577 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4578 (Fwindow_hchild): Rename to Fwindow_left_child.
4579 (Fwindow_next): Rename to Fwindow_next_sibling.
4580 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4581 (resize_window_check): Rename to window_resize_check.
4582 (resize_window_apply): Rename to window_resize_apply.
4583 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4584 (Fdelete_other_windows_internal, resize_frame_windows)
4585 (Fsplit_window_internal, Fdelete_window_internal)
4586 (grow_mini_window, shrink_mini_window)
4587 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4588
c7e73be5
JD
45892011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4590
4591 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4592 (emacs_fixed_set_min_size): Remove.
4593 (emacs_fixed_new): Take frame as argument.
4594
4595 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4596 (_EmacsFixedPrivate): Remove minwidth/height.
4597 Add struct frame *f.
4598 (emacs_fixed_init): Initialize priv->f.
4599 (get_parent_class, emacs_fixed_set_min_size): Remove.
4600 (emacs_fixed_new): Set priv->f to argument.
4601 (emacs_fixed_get_preferred_width)
4602 (emacs_fixed_get_preferred_height): Use min_width/height from
4603 frames size_hint to set minimum and natural (Bug#8919).
4604 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4605 and use min_width/height from frames size_hint to set
4606 min_width/height (Bug#8919).
4607
4608 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4609 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4610 Fix indentation.
c7e73be5 4611
cf99dcf8
EZ
46122011-06-26 Eli Zaretskii <eliz@gnu.org>
4613
4614 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4615 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4616 called at ZV.
4617
029529ac
CY
46182011-06-26 Chong Yidong <cyd@stupidchicken.com>
4619
4620 * process.c (wait_reading_process_output): Bypass select if
4621 waiting for a cell while ignoring keyboard input, and input is
4622 pending. Suggested by Jan Djärv (Bug#8869).
4623
7a7ef429
PE
46242011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4625
4626 Use gnulib's dup2 module instead of rolling our own.
4627 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4628
11fdef7d 46292011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4630
4631 * dispnew.c (scrolling_window): Before scrolling, turn off a
4632 mouse-highlight in the window being scrolled.
4633
cd3520a4
JB
46342011-06-24 Juanma Barranquero <lekktu@gmail.com>
4635
4636 Move DEFSYM to lisp.h and use everywhere.
4637
4638 * character.h (DEFSYM): Move declaration...
4639 * lisp.h (DEFSYM): ...here.
4640
4641 * gnutls.c:
4642 * minibuf.c:
4643 * w32menu.c:
4644 * w32proc.c:
4645 * w32select.c: Don't include character.h.
4646
4647 * alloc.c (syms_of_alloc):
4648 * buffer.c (syms_of_buffer):
4649 * bytecode.c (syms_of_bytecode):
4650 * callint.c (syms_of_callint):
4651 * casefiddle.c (syms_of_casefiddle):
4652 * casetab.c (init_casetab_once):
4653 * category.c (init_category_once, syms_of_category):
4654 * ccl.c (syms_of_ccl):
4655 * cmds.c (syms_of_cmds):
4656 * composite.c (syms_of_composite):
4657 * dbusbind.c (syms_of_dbusbind):
4658 * dired.c (syms_of_dired):
4659 * dispnew.c (syms_of_display):
4660 * doc.c (syms_of_doc):
4661 * editfns.c (syms_of_editfns):
4662 * emacs.c (syms_of_emacs):
4663 * eval.c (syms_of_eval):
4664 * fileio.c (syms_of_fileio):
4665 * fns.c (syms_of_fns):
4666 * frame.c (syms_of_frame):
4667 * fringe.c (syms_of_fringe):
4668 * insdel.c (syms_of_insdel):
4669 * keymap.c (syms_of_keymap):
4670 * lread.c (init_obarray, syms_of_lread):
4671 * macros.c (syms_of_macros):
4672 * msdos.c (syms_of_msdos):
4673 * print.c (syms_of_print):
4674 * process.c (syms_of_process):
4675 * search.c (syms_of_search):
4676 * sound.c (syms_of_sound):
4677 * syntax.c (init_syntax_once, syms_of_syntax):
4678 * terminal.c (syms_of_terminal):
4679 * textprop.c (syms_of_textprop):
4680 * undo.c (syms_of_undo):
4681 * w32.c (globals_of_w32):
4682 * window.c (syms_of_window):
4683 * xdisp.c (syms_of_xdisp):
4684 * xfaces.c (syms_of_xfaces):
4685 * xfns.c (syms_of_xfns):
4686 * xmenu.c (syms_of_xmenu):
4687 * xsettings.c (syms_of_xsettings):
4688 * xterm.c (syms_of_xterm): Use DEFSYM.
4689
4228cf16
TZ
46902011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4691
cd3520a4 4692 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4693
7fcccf1e
PE
46942011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4695
7efb4e0e
PE
4696 Integer and buffer overflow fixes (Bug#8873).
4697
ff5844ad
PE
4698 * print.c (printchar, strout): Check for string overflow.
4699 (PRINTPREPARE, printchar, strout):
4700 Don't set size unless allocation succeeds.
4701
90532f02
PE
4702 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4703 for sizes. Check for string overflow more accurately.
4704 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4705
6d84508d
PE
4706 * macros.c: Integer and buffer overflow fixes.
4707 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4708 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4709 Use ptrdiff_t, not int, for sizes.
4710 Don't increment bufsize until after realloc succeeds.
4711 Check for size-calculation overflow.
4712 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4713
437b2cb4
PE
4714 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4715
8b9ac8b4
PE
4716 * lread.c: Integer overflow fixes.
4717 (read_integer): Radix is now EMACS_INT, not int,
4718 to improve quality of diagnostics for out-of-range radices.
4719 Calculate buffer size correctly for out-of-range radices.
4720 (read1): Check for integer overflow in radices, and in
4721 read-circle numbers.
82cb60d3
PE
4722 (read_escape): Avoid int overflow.
4723 (Fload, openp, read_buffer_size, read1)
4724 (substitute_object_recurse, read_vector, read_list, map_obarray):
4725 Use ptrdiff_t, not int, for sizes.
4726 (read1): Use EMACS_INT, not int, for sizes.
20270765 4727 Check for size overflow.
8b9ac8b4 4728
7fcccf1e
PE
4729 * image.c (cache_image): Check for size arithmetic overflow.
4730
bfbbd7e7
PE
4731 * lread.c: Integer overflow issues.
4732 (saved_doc_string_size, saved_doc_string_length)
4733 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4734 Now ptrdiff_t, not int.
4735 (read1): Don't assume doc string length fits in int. Check for
4736 out-of-range doc string lengths.
4737 (read_list): Don't assume file position fits in int.
39019e54 4738 (read_escape): Check for hex character overflow.
bfbbd7e7 4739
4e323265
LL
47402011-06-22 Leo Liu <sdl.web@gmail.com>
4741
4742 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4743 Move to minibuffer.el.
4744
85fece3e
PE
47452011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4746
20b84ce9 4747 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4748 The following patches are for when GLYPH_DEBUG && !XASSERT.
4749 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4750 * dispnew.c (flush_stdout):
4751 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4752 Mark as externally visible.
4753 * dispnew.c (check_window_matrix_pointers): Now static.
4754 * dispnew.c (window_to_frame_vpos):
4755 * xfns.c (unwind_create_frame):
4756 * xterm.c (x_check_font): Remove unused local.
4757 * scroll.c (CHECK_BOUNDS):
4758 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4759 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4760 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4761 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4762 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4763 Now static.
4764 (debug_method_add): Use va_list and vsprintf rather than relying
4765 on undefined behavior with wrong number of arguments.
4766 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4767 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4768 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4769 since we're not interested in debugging glyphs with old libraries.
4770 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4771 GCC 4.6.0's static checking.
4772
0766b489
PE
47732011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4774
31fd4b32
PE
4775 Integer overflow and signedness fixes (Bug#8873).
4776 A few related buffer overrun fixes, too.
4777
b79e8648
PE
4778 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4779
0766b489
PE
4780 * dispextern.h (struct face.stipple):
4781 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4782 (x_bitmap_mask, x_allocate_bitmap_record)
4783 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4784 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4785 (x_create_bitmap_from_xpm_data):
4786 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4787 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4788 (.bitmaps_last):
4789 * xfaces.c (load_pixmap):
4790 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4791 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4792 (.bitmaps_last, struct x_output.icon_bitmap):
4793 Use ptrdiff_t, not int, for bitmap indexes.
4794 (x_allocate_bitmap_record): Check for size overflow.
4795 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4796
b081724f
PE
4797 Use ptrdiff_t, not int, for overlay counts.
4798 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4799 * editfns.c (overlays_around, get_pos_property):
4800 * textprop.c (get_char_property_and_overlay):
4801 * xdisp.c (next_overlay_change, note_mouse_highlight):
4802 * xfaces.c (face_at_buffer_position):
21514da7
PE
4803 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4804 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4805 (Fnext_overlay_change, Fprevious_overlay_change)
4806 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4807 Use ptrdiff_t, not int, for sizes.
21514da7 4808 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4809
3de73e5e
PE
4810 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4811
2606c57b
PE
4812 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4813 (x_session_initialize): Do not assume string length fits in int.
4814
aaafe47a
PE
4815 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4816 This is unlikely, but can occur if DPI is outlandish.
4817
2674ddc8 4818 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4819 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4820
28154962
PE
4821 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4822 * xrdb.c (magic_file_p, search_magic_path):
4823 Omit last arg SUFFIX; it was always 0. All callers changed.
4824 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4825
7de51af5
PE
4826 * xfont.c (xfont_match): Avoid need for strlen.
4827
25ed6cc3
PE
4828 * xfns.c: Don't assume strlen fits in int.
4829 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4830
4eab31dd
PE
4831 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4832 not unsigned long, as we prefer signed integers. All callers changed.
4833 Detect integer overflow in repeat count.
4834 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4835 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4836
171e2a58
PE
4837 * termcap.c: Don't assume sizes fit in int and never overflow.
4838 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4839 (gobble_line): Check for size-calculation overflow.
4840
ad39faca 4841 * minibuf.c (Fread_buffer):
6e5bb2dc 4842 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4843 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4844 Don't assume string length fits in int.
4845
52c61c22 4846 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4847 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4848
b5b8c9e5
PE
4849 * font.c: Don't assume string length fits in int.
4850 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4851 Use ptrdiff_t, not int.
ccd6111c
PE
4852 (font_intern_prop): Don't assume string length fits in int.
4853 Don't assume integer property fits in fixnum.
4854 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4855
882f0d81 4856 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4857 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4858 Reformulate so as not to need the command string.
4859 Invoke gzip -cd rather than gunzip, as it's more portable.
4860 (lock_info_type, lock_file_1, lock_file):
4861 Don't assume pid_t and time_t fit in unsigned long.
4862 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4863 (current_lock_owner): Prefer signed type for sizes.
4864 Use memcpy, not strncpy, where memcpy is what is really wanted.
4865 Don't assume (via atoi) that time_t and pid_t fit in int.
4866 Check for time_t and/or pid_t out of range, e.g., via a network share.
4867 Don't alloca where an auto var works fine.
4868
93f4cf88
PE
4869 * fileio.c: Fix some integer overflow issues.
4870 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4871 Don't assume string length fits in int.
4872 (directory_file_name): Don't assume string length fits in long.
4873 (make_temp_name): Don't assume pid fits in int, or that its print
4874 length is less than 20.
4875
f3e92b69
PE
4876 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4877
1bfdaf10
PE
4878 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4879
35016e9a
PE
4880 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4881
3d1e65a1
PE
4882 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4883 We prefer signed integers, even for size calculations.
4884
0b963a93
PE
4885 * emacs.c: Don't assume string length fits in 'int'.
4886 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4887 (main): Don't invoke strlen when not needed.
4888
573f4b54
PE
4889 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4890 (XD_DEBUG_MESSAGE): Don't waste a byte.
4891
989f33ba
PE
4892 * callproc.c (getenv_internal_1, getenv_internal)
4893 (Fgetenv_internal):
965d34eb
PE
4894 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4895
e4d29b33
PE
4896 * lread.c (invalid_syntax): Omit length argument.
4897 All uses changed. This doesn't fix a bug, but it simplifies the
4898 code away from its former Hollerith-constant appearance, and it's
4899 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4900 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4901
eb49b136
PE
4902 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4903 This didn't break anything, but it didn't help either.
4904 It's confusing to put a bogus integer in a place where the actual
4905 value does not matter.
9f62aeb1 4906 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4907 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4908
15375a22
PE
4909 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4910 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4911 implementation.
b61cc01c
PE
4912 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4913 We prefer signed types, and the value cannot exceed the EMACS_INT
4914 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4915 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4916 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4917 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4918
53b2623d
PE
4919 * indent.c (sane_tab_width): New function.
4920 (current_column, scan_for_column, Findent_to, position_indentation)
4921 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4922 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4923
51cab52b 4924 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4925
f2ed8a70
PE
4926 * lisp.h (lint_assume): New macro.
4927 * composite.c (composition_gstring_put_cache):
4928 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4929
abe80cc6
PE
4930 * editfns.c, insdel.c:
4931 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4932
b02c740e
PE
4933 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4934
ebc96716
PE
4935 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4936
b4e50fa0 4937 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4938 Use much-faster test for byte-length change.
311d5d7c 4939 Don't assume string byte-length fits in 'int'.
a4cf38e4 4940 Check that character arg fits in 'int'.
85461888 4941 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4942
c0c1ee9f
PE
4943 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4944
a498d7f4
PE
4945 * fns.c (concat): Catch string overflow earlier.
4946 Do not rely on integer wraparound.
4947
51cab52b
PE
4948 * dispextern.h (struct it.overlay_strings_charpos)
4949 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4950 * xdisp.c (forward_to_next_line_start)
4951 (back_to_previous_visible_line_start)
4952 (reseat_at_next_visible_line_start, next_element_from_buffer):
4953 Don't arbitrarily truncate the value of 'selective' to int.
4954
76031fad
PE
4955 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4956
5eb55db9
PE
4957 * composite.c: Don't truncate sizes to 'int'.
4958 (composition_gstring_p, composition_reseat_it)
4959 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4960 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4961 not EMACS_UINT, for indexes.
5eb55db9 4962
0703a717
PE
4963 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4964
d6202519
PE
4965 * buffer.c: Include <verify.h>.
4966 (struct sortvec.priority, struct sortstr.priority):
8961a454 4967 Now EMACS_INT, not int.
c20998a7 4968 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4969 (struct sortstr.size, record_overlay_string)
4970 (struct sortstrlist.size, struct sortlist.used):
4971 Don't truncate size to int.
4972 (record_overlay_string): Check for size-calculation overflow.
d6202519 4973 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4974
d5a19415
JM
49752011-06-22 Jim Meyering <meyering@redhat.com>
4976
029529ac 4977 Don't leak an XBM-image-sized buffer
d5a19415
JM
4978 * image.c (xbm_load): Free the image buffer after using it.
4979
a9041e6c
PE
49802011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4981
4982 Port to Sun C.
4983 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4984 that Sun C diagnosed.
4985 * fns.c (secure_hash): Fix pointer signedness issue.
4986 * intervals.c (static_offset_intervals): New function.
4987 (offset_intervals): Use it.
4988
7f3f739f
LL
49892011-06-21 Leo Liu <sdl.web@gmail.com>
4990
4991 * deps.mk (fns.o):
4992 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4993 sha512.h.
4994
4995 * fns.c (secure_hash): Rename from crypto_hash_function and change
4996 the first arg to accept symbols.
5b66d427 4997 (Fsecure_hash): New primitive.
7f3f739f
LL
4998 (syms_of_fns): New symbols.
4999
76147d94
DD
50002011-06-20 Deniz Dogan <deniz@dogan.se>
5001
5002 * process.c (Fset_process_buffer): Clarify return value in
5003 docstring.
5004
7d7d0045
CY
50052011-06-18 Chong Yidong <cyd@stupidchicken.com>
5006
5007 * dispnew.c (add_window_display_history): Use BVAR.
5008
5009 * xdisp.c (debug_method_add): Use BVAR.
5010 (check_window_end, dump_glyph_matrix, dump_glyph)
5011 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5012
5013 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5014 Likewise.
5015
5016 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5017 check till after the cache is created in init_frame_faces.
5018
ff2bc410
SM
50192011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5020
5021 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5022
28177add
PE
50232011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5024
dd3482fe
PE
5025 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5026 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5027 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5028
393d71f3 5029 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5030 * fileio.c (Finsert_file_contents):
5031 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5032 Remove the old (too-loose) buffer overflow checks.
5033 They weren't needed, since make_gap checks for buffer overflow.
5034 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5035 The old code merely checked for Emacs fixnum overflow, and relied
5036 on undefined (wraparound) behavior. The new code avoids undefined
5037 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5038
2e6813b0 5039 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5040 Tune. Don't use wider integers than needed. Don't use alloca.
5041 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5042
599a9e4f
PE
5043 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5044
99561444
PE
5045 * insdel.c, lisp.h (buffer_overflow): New function.
5046 (insert_from_buffer_1, replace_range, replace_range_2):
5047 * insdel.c (make_gap_larger):
5048 * editfns.c (Finsert_char):
5049 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5050
28177add
PE
5051 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5052
e69dafad
PE
50532011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5054
4baa020d 5055 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5056
b1c46f02
PE
5057 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5058 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5059
e69dafad
PE
5060 * fileio.c: Don't assume EMACS_INT fits in off_t.
5061 (emacs_lseek): New static function.
5062 (Finsert_file_contents, Fwrite_region): Use it.
5063 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5064
566684ea
PE
5065 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5066
e6966cd6
PE
5067 * fns.c: Don't overflow int when computing a list length.
5068 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5069 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5070 truncation on 64-bit hosts. Check for QUIT every
5071 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5072 faster and is responsive enough.
5073 (Flength): Report an error instead of overflowing an integer.
5074 (Fsafe_length): Return a float if the value is not representable
5075 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5076 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5077 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5078
dd0b0efb
PE
5079 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5080 (header_size, word_size): New constants.
5081 (allocate_vectorlike): Don't check size overflow here.
5082 (allocate_vector): Check it here instead, since this is the only
5083 caller of allocate_vectorlike that could cause overflow.
5084 Check that the new vector's length is representable as a fixnum.
5085
86fe5cfe
PE
5086 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5087 The previous code was bogus. For example, next_almost_prime (32)
5088 returned 39, which is undesirable as it is a multiple of 3; and
5089 next_almost_prime (24) returned 25, which is a multiple of 5 so
5090 why was the code bothering to check for multiples of 7?
5091
80e88859
PE
5092 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5093
4a2f0ad6
PE
5094 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5095
f66c7cf8
PE
5096 Variadic C functions now count arguments with ptrdiff_t.
5097 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5098 Back then I didn't know that the Emacs coding style prefers signed int.
5099 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5100 were being counted with int, which may truncate counts on 64-bit
5101 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5102 * lisp.h (struct Lisp_Subr.function.aMANY)
5103 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5104 Arg counts are now ptrdiff_t, not size_t.
5105 All variadic functions and their callers changed accordingly.
5106 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5107 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5108 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5109 * callint.c (Fcall_interactively): Check arg count for overflow,
5110 to avoid potential buffer overrun. Use signed char, not 'int',
5111 for 'varies' array, so that we needn't bother to check its size
5112 calculation for overflow.
5113 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5114 * eval.c (apply_lambda):
5115 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5116 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5117 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5118
a1759b76
PE
5119 * callint.c (Fcall_interactively): Don't use index var as event count.
5120
d96be9fc
PE
5121 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5122 * mem-limits.h (SIZE): Remove; no longer used.
5123
a690a978 5124 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5125
578c21e6
PE
5126 Remove unnecessary casts.
5127 * xterm.c (x_term_init):
5128 * xfns.c (x_set_border_pixel):
5129 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5130 These aren't needed now that we assume ANSI C.
5131
96f53c6c
PE
5132 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5133 It's more likely to cause problems (due to unsigned overflow)
5134 than to cure them.
5135
83c77d31
PE
5136 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5137
ee2079f1
PE
5138 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5139
6da65536
PE
5140 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5141
7147c4a4
PE
5142 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5143
193e32d9
PE
5144 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5145
e5533da6
PE
5146 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5147
9910e595
PE
5148 GLYPH_CODE_FACE returns EMACS_INT, not int.
5149 * dispextern.h (merge_faces):
5150 * xfaces.c (merge_faces):
01103c44
PE
5151 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5152 Don't assume EMACS_INT fits in int.
9910e595 5153
2638320e
PE
5154 * character.h (CHAR_VALID_P): Remove unused parameter.
5155 * fontset.c, lisp.h, xdisp.c: All uses changed.
5156
045eb8d9
PE
5157 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5158
c1f134b5
PE
5159 * fns.c (concat): Minor tuning based on overflow analysis.
5160 This doesn't fix any bugs. Use int to hold character, instead
5161 of constantly refetching from Emacs object. Use XFASTINT, not
5162 XINT, for value known to be a character. Don't bother comparing
5163 a single byte to 0400, as it's always less.
5164
395fcb93 5165 * floatfns.c (Fexpt):
327eeec8
PE
5166 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5167
abbd3d23
PE
5168 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5169 for characters.
5170
684a03ef
PE
5171 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5172
0fed43f3
PE
5173 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5174 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5175 incorrectly succeed when S was a string, because 4294967386 was
5176 truncated before it was used.
5177
8fd02eb7
PE
5178 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5179 Otherwise, an out-of-range integer could cause undefined behavior
5180 on a 64-bit host.
5181
f8c86b69
PE
5182 * composite.c: Use int, not EMACS_INT, for characters.
5183 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5184 EMACS_INT, for values that are known to be in character range.
5185 This doesn't fix any bugs but is the usual style inside Emacs and
5186 may generate better code on 32-bit machines.
5187
34206dd2
PE
5188 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5189 This is for reasons similar to the recent CHAR_STRING fix.
5190 * charset.c (Fencode_char): Check that character arg is actually
5191 a character. Pass an int to ENCODE_CHAR.
5192 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5193 wider than 'int', as a compile-time check to prevent future regressions
5194 in this area.
5195
c5958d4c 5196 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5197
5198 Make sure a 64-bit char is never passed to CHAR_STRING.
5199 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5200 by silently ignoring the top 32 bits, allowing some values
5201 that were far too large to be valid characters.
5202 * character.h: Include <verify.h>.
5203 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5204 arguments are no wider than unsigned, as a compile-time check
5205 to prevent future regressions in this area.
5206 * data.c (Faset):
01103c44 5207 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5208 (Fsubst_char_in_region):
5209 * fns.c (concat):
5210 * xdisp.c (decode_mode_spec_coding):
5211 Adjust to CHAR_STRING's new requirement.
5212 * editfns.c (Finsert_char, Fsubst_char_in_region):
5213 * fns.c (concat): Check that character args are actually
5214 characters. Without this test, these functions did the wrong
5215 thing with wildly out-of-range values on 64-bit hosts.
5216
d37ca623
PE
5217 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5218 These casts should not be needed on 32-bit hosts, either.
5219 * keyboard.c (read_char):
5220 * lread.c (Fload): Remove casts to unsigned.
5221
ea204efb
PE
5222 * lisp.h (UNSIGNED_CMP): New macro.
5223 This fixes comparison bugs on 64-bit hosts.
5224 (ASCII_CHAR_P): Use it.
5225 * casefiddle.c (casify_object):
01103c44 5226 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5227 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5228 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5229 * dispextern.h (FACE_FROM_ID):
5230 * keyboard.c (read_char): Use UNSIGNED_CMP.
5231
41cb286c
PE
5232 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5233 not to EMACS_INT, to avoid GCC warning.
5234
4a1b9832
PE
5235 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5236
55daad71
PE
5237 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5238 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5239 isn't needed on 32-bit machines.
8f95c75c 5240
01103c44
PE
5241 * buffer.c (Fgenerate_new_buffer_name):
5242 Use EMACS_INT for count, not int.
0ceccced 5243 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5244
5245 * data.c (Qcompiled_function): Now static.
5246
c6f072e7
PE
5247 * window.c (window_body_lines): Now static.
5248
20ce5912
PE
5249 * image.c (gif_load): Rename local to avoid shadowing.
5250
9c4c5f81
PE
5251 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5252 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5253 * alloc.c (make_save_value): Integer argument is now of type
5254 ptrdiff_t, not int.
5255 (mark_object): Use ptrdiff_t, not int.
5256 * lisp.h (pD): New macro.
5257 * print.c (print_object): Use it.
5258
c0c5c8ae
PE
5259 * alloc.c: Use EMACS_INT, not int, to count objects.
5260 (total_conses, total_markers, total_symbols, total_vector_size)
5261 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5262 (total_free_floats, total_floats, total_free_intervals)
5263 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5264 Now EMACS_INT, not int. All uses changed.
5265 (Fgarbage_collect): Compute overall total using a double, so that
5266 integer overflow is less likely to be a problem. Check for overflow
5267 when converting back to an integer.
5a25e253
PE
5268 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5269 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5270 These were 'int' variables that could overflow on 64-bit hosts;
5271 they were never used, so remove them instead of repairing them.
211a0b2a 5272 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5273 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5274 Previously, this ceilinged at INT_MAX, but that doesn't work on
5275 64-bit machines.
e46bb31a 5276 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5277
c78baabf 5278 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5279 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5280 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5281 when a (possibly-narrower) signed value would do just as well.
5282 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5283
c9d624c6
PE
5284 * alloc.c: Catch some string size overflows that we were missing.
5285 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5286 for convenience in STRING_BYTES_MAX.
5287 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5288 The definition here is exact; the one in lisp.h was approximate.
5289 (allocate_string_data): Check for string overflow. This catches
5290 some instances we weren't catching before. Also, it catches
5291 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5292 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5293 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5294
c9d624c6
PE
5295 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5296 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5297 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5298
353032ce
PE
5299 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5300
2bccce07
PE
5301 * alloc.c (Fmake_string): Check for out-of-range init.
5302
0ac30604
SM
53032011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5304
5305 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5306
c195f2de
JD
53072011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5308
5309 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5310 xg_get_default_scrollbar_width.
5311
5312 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5313 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5314 (style_changed_cb): Call update_theme_scrollbar_width and call
5315 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5316 all frames (Bug#8505).
5317 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5318 Call gtk_window_set_resizable if HAVE_GTK3.
5319 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5320 and height if HAVE_GTK3 (Bug#8505).
5321 (scroll_bar_width_for_theme): New variable.
5322 (update_theme_scrollbar_width): New function.
5323 (xg_get_default_scrollbar_width): Move code to
5324 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5325 (xg_initialize): Call update_theme_scrollbar_width.
5326
5327 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5328
5329 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5330
e10ac9f1
MR
53312011-06-12 Martin Rudalics <rudalics@gmx.at>
5332
5333 * frame.c (make_frame): Call other_buffer_safely instead of
5334 other_buffer.
5335
5336 * window.c (temp_output_buffer_show): Call display_buffer with
5337 second argument Vtemp_buffer_show_specifiers and reset latter
5338 immediately after the call.
5339 (Vtemp_buffer_show_specifiers): New variable.
5340 (auto_window_vscroll_p, next_screen_context_lines)
5341 (Vscroll_preserve_screen_position): Remove leading asterisks from
5342 doc-strings.
5343
2d3c217e 53442011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5345
7b7f97e8 5346 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5347 * buffer.c (Qclone_number): Remove for now, as it's unused.
5348 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5349 (record_buffer): Remove unused local.
5350 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5351 (set_frame_buffer_list): Remove; unused.
5352 * frame.h (other_visible_frames): Remove decl.
5353 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5354 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5355 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5356 if HAVE_GPM.
5357 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5358 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5359 Define only if HAVE_GPM.
5360 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5361 (update_hints_inhibit): Remove; never set. All uses removed.
5362 * widgetprv.h (emacsFrameClassRec): Remove decl.
5363 * window.c (delete_deletable_window): Now returns void, since it
5364 wasn't returning anything.
5365 (compare_window_configurations): Remove unused locals.
5366 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5367 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5368 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5369 the same widths as pointers. This follows up on the 2011-05-06 patch.
5370 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5371 * xterm.h: Likewise.
5372 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5373
1384b89e
JB
53742011-06-12 Juanma Barranquero <lekktu@gmail.com>
5375
5376 * makefile.w32-in: Update dependencies.
5377 (LISP_H): Add lib/intprops.h.
5378
1100a63c
CY
53792011-06-11 Chong Yidong <cyd@stupidchicken.com>
5380
5381 * image.c (gif_load): Add animation frame delay to the metadata.
5382 (syms_of_image): Use DEFSYM. New symbol `delay'.
5383
6198ccd0
MR
53842011-06-11 Martin Rudalics <rudalics@gmx.at>
5385
5386 * window.c (delete_deletable_window): Re-add.
5387 (Fset_window_configuration): Rewrite to handle dead buffers and
5388 consequently deletable windows.
5389 (window_tree, Fwindow_tree): Remove. Supply functionality in
5390 window.el.
5391 (compare_window_configurations): Simplify code.
5392
b6e3633c
AS
53932011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5394
1ab0dee5
AS
5395 * image.c (imagemagick_load_image): Fix type mismatch.
5396 (Fimagemagick_types): Likewise.
5397
b6e3633c
AS
5398 * window.h (replace_buffer_in_windows): Declare.
5399
9397e56f
MR
54002011-06-11 Martin Rudalics <rudalics@gmx.at>
5401
5402 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5403 Qclone_number. Remove external declaration of Qdelete_window.
5404 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5405 code.
640c8776
SM
5406 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5407 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5408 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5409 buffer list implementation.
5410 (other_buffer_safely): New function.
5411 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5412 calls to replace_buffer_in_windows and
5413 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5414 if allowed.
5415 (record_buffer): Inhibit quitting and rewrite using quittable
5416 functions. Run Qbuffer_list_update_hook if allowed.
5417 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5418 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5419 Move switch-to-buffer to window.el.
9397e56f
MR
5420 (bury-buffer): Move to window.el.
5421 (Vbuffer_list_update_hook): New variable.
5422
5423 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5424 section.
5425
5426 * window.h (resize_frame_windows): Move up in code.
5427 (Fwindow_frame): Remove EXFUN.
5428 (replace_buffer_in_all_windows): Remove prototype.
5429 (replace_buffer_in_windows_safely): Add prototype.
5430
5431 * window.c: Declare Qdelete_window static again. Move down
5432 declaration of select_count.
5433 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5434 (Fother_window): Move to window.el.
5435 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5436 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5437 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5438 window.el.
5439 (replace_buffer_in_windows): Implement by calling
5440 Qreplace_buffer_in_windows.
5441 (replace_buffer_in_all_windows): Remove with some functionality
5442 moved into replace_buffer_in_windows_safely.
5443 (replace_buffer_in_windows_safely): New function.
5444 (select_window_norecord, select_frame_norecord): Move in front
5445 of run_window_configuration_change_hook. Remove now obsolete
5446 declarations.
640c8776
SM
5447 (Fset_window_buffer): Rewrite doc-string.
5448 Call Qrecord_window_buffer.
9397e56f
MR
5449 (keys_of_window): Move binding for other-window to window.el.
5450
b50691aa
CY
54512011-06-11 Chong Yidong <cyd@stupidchicken.com>
5452
5453 * dispextern.h (struct image): Replace data member, whose int_val
5454 and ptr_val fields were not used by anything, with a single
5455 lisp_val object.
5456
5457 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5458 (gif_clear_image, gif_load, imagemagick_load_image)
5459 (gs_clear_image, gs_load): Callers changed.
5460
3f754b86
PE
54612011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5462
cca69397
PE
5463 * buffer.h: Include <time.h>, for time_t.
5464 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5465
109e28d0
PE
5466 Fix minor problems found by static checking.
5467
60737f02
PE
5468 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5469
4b66faf3
PE
5470 Make identifiers static if they are not used in other modules.
5471 * data.c (Qcompiled_function, Qframe, Qvector):
5472 * image.c (QimageMagick, Qsvg):
5473 * minibuf.c (Qmetadata):
5474 * window.c (resize_window_check, resize_root_window): Now static.
5475 * window.h (resize_window_check, resize_root_window): Remove decls.
5476
109e28d0
PE
5477 * window.c (window_deletion_count, delete_deletable_window):
5478 Remove; unused.
46a4ce9e
PE
5479 (window_body_lines): Now static.
5480 (Fdelete_other_windows_internal): Mark vars as initialized.
5481 Make sure 'resize_failed' is initialized.
5482 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5483 (resize_window_apply): Remove unused local.
5484 * window.h (delete_deletable_window): Remove decl.
5485
109e28d0 5486 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5487 (imagemagick_load_image): Fix pointer signedness problem by changing
5488 last arg from unsigned char * to char *. All uses changed.
5489 Also, fix a local for similar reasons.
5490 Remove unused locals. Remove locals to avoid shadowing.
5491 (fn_rsvg_handle_free): Remove; unused.
5492 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5493 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5494
3f754b86
PE
5495 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5496
2547adb1
CY
54972011-06-10 Chong Yidong <cyd@stupidchicken.com>
5498
5499 * image.c (gif_load): Fix omitted cast error introduced by
5500 2011-06-06 change.
5501
2c8e37d4
MR
55022011-06-10 Martin Rudalics <rudalics@gmx.at>
5503
5504 * window.h (resize_proportionally, orig_total_lines)
5505 (orig_top_line): Remove from window structure.
5506 (set_window_height, set_window_width, change_window_heights)
5507 (Fdelete_window): Remove prototypes.
5508 (resize_frame_windows): Remove duplicate declaration.
5509
440a42e3
EZ
55102011-06-10 Eli Zaretskii <eliz@gnu.org>
5511
5512 * window.h (resize_frame_windows, resize_window_check)
5513 (delete_deletable_window, resize_root_window)
5514 (resize_frame_windows): Declare prototypes.
5515
5516 * window.c (resize_window_apply): Make definition be "static" to
5517 match the prototype.
5518
562dd5e9
MR
55192011-06-10 Martin Rudalics <rudalics@gmx.at>
5520
5521 * window.c: Remove declarations of Qwindow_size_fixed,
5522 window_min_size_1, window_min_size_2, window_min_size,
5523 size_window, window_fixed_size_p, enlarge_window, delete_window.
5524 Remove static from declaration of Qdelete_window, it's
5525 temporarily needed by Fbury_buffer.
5526 (replace_window): Don't assign orig_top_line and
5527 orig_total_lines.
5528 (Fdelete_window, delete_window): Remove. Window deletion is
5529 handled by window.el.
640c8776
SM
5530 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5531 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5532 (Fdelete_other_windows): Remove. Deleting other windows is
5533 handled by window.el.
5534 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5535 handled in window.el.
5536 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5537 Window minimum sizes are handled in window.el.
5538 (shrink_windows, size_window, set_window_height)
5539 (set_window_width, change_window_heights, window_height)
5540 (window_width, CURBEG, CURSIZE, enlarge_window)
5541 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5542 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5543 handled in window.el.
5544 (make_dummy_parent): Rename to make_parent_window and give it a
5545 second argument horflag.
5546 (make_window): Don't set resize_proportionally any more.
5547 (Fsplit_window): Remove. Windows are split in window.el.
5548 (save_restore_action, save_restore_orig_size)
5549 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5550 Resize mini windows in window.el.
5551 (grow_mini_window, shrink_mini_window): Implement by calling
5552 Qresize_root_window_vertically, resize_window_check and
5553 resize_window_apply.
640c8776
SM
5554 (saved_window, Fset_window_configuration, save_window_save):
5555 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5556 resize_proportionally.
5557 (window_min_height, window_min_width): Move to window.el.
5558 (keys_of_window): Move bindings for delete-other-windows,
5559 split-window, delete-window and enlarge-window to window.el.
5560
5561 * buffer.c: Temporarily extern Qdelete_window.
5562 (Fbury_buffer): Temporarily call Qdelete_window instead of
5563 Fdelete_window (Fbury_buffer will move to window.el soon).
5564
5565 * frame.c (set_menu_bar_lines_1): Remove code handling
5566 orig_top_line and orig_total_lines.
5567
5568 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5569 set_window_height but set heights directly.
5570 (change_frame_size_1): Use resize_frame_windows.
5571
5572 * xdisp.c (init_xdisp): Don't use set_window_height but set
5573 heights directly.
5574
640c8776
SM
5575 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5576 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5577 run_window_configuration_change_hook.
5578
5579 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5580 instead of change_window_heights and run
5581 run_window_configuration_change_hook.
5582
1a13852e
MR
55832011-06-09 Martin Rudalics <rudalics@gmx.at>
5584
5585 * window.c (replace_window): Rename second argument REPLACEMENT to
5586 NEW. New third argument SETFLAG. Rewrite.
5587 (delete_window, make_dummy_parent): Call replace_window with
5588 third argument 1.
5589 (window_list_1): Move down in code.
5590 (run_window_configuration_change_hook): Move set_buffer part
5591 before select_frame_norecord part in order to unwind correctly.
5592 Rename count1 to count.
5593 (recombine_windows, delete_deletable_window, resize_root_window)
5594 (Fdelete_other_windows_internal)
5595 (Frun_window_configuration_change_hook, make_parent_window)
5596 (resize_window_check, resize_window_apply, Fresize_window_apply)
5597 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5598 (Fdelete_window_internal, Fresize_mini_window_internal):
5599 New functions.
1a13852e
MR
5600 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5601
f3d1777e
MR
56022011-06-08 Martin Rudalics <rudalics@gmx.at>
5603
496e208e
MR
5604 * window.h (window): Add some new members to window structure -
5605 normal_lines, normal_cols, new_total, new_normal, clone_number,
5606 splits, nest, prev_buffers, next_buffers.
5607 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5608 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5609
f3d1777e
MR
5610 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5611 Remove.
496e208e
MR
5612 (make_dummy_parent): Set new members of windows structure.
5613 (make_window): Move down in code. Handle new members of window
5614 structure.
5615 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5616 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5617 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5618 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5619 (Fset_window_next_buffers, Fset_window_clone_number):
5620 New functions.
496e208e
MR
5621 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5622 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5623 Doc-string fixes.
5624 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5625 Argument WINDOW can be now internal window too.
5626 (Fwindow_use_time): Move up in code.
5627 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5628 Rewrite doc-string.
5629 (Fset_window_configuration, saved_window)
5630 (Fcurrent_window_configuration, save_window_save): Handle new
5631 members of window structure.
b9e809c2
MR
5632 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5633 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5634 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5635 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5636 Qget_mru_window, Qresize_root_window,
5637 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5638 Qauto_buffer_name; staticpro them.
f3d1777e 5639
abde8f8c
MR
56402011-06-07 Martin Rudalics <rudalics@gmx.at>
5641
5642 * window.c (Fwindow_total_size, Fwindow_left_column)
5643 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5644 (Fwindow_list_1): New functions.
5645 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5646 (Fwindow_width, Fscroll_left, Fscroll_right):
5647 Use window_body_cols instead of window_box_text_cols.
5648 (delete_window, Fset_window_configuration):
5649 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5650 (delete_all_subwindows): Take a window as argument and not a
5651 structure. Rewrite.
190b47e6
MR
5652 (window_loop): Remove handling of GET_LRU_WINDOW and
5653 GET_LARGEST_WINDOW.
5654 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5655
5656 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5657 window_box_text_cols. delete_all_subwindows now takes a
5658 Lisp_Object as argument.
abde8f8c 5659
640c8776
SM
5660 * indent.c (compute_motion, Fcompute_motion):
5661 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5662
fa8a67e6
MR
5663 * frame.c (delete_frame): Call delete_all_subwindows with root
5664 window as argument.
5665
a54e3482
DC
56662011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5667
5668 * fns.c (Fputhash): Document return value.
5669
60002bf5
CY
56702011-06-06 Chong Yidong <cyd@stupidchicken.com>
5671
5672 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5673
0c671da6 56742011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5675
b862a52a 5676 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5677
be44ca6c
PE
5678 Check for overflow when converting integer to cons and back.
5679 * charset.c (Fdefine_charset_internal, Fdecode_char):
5680 Use cons_to_unsigned to catch overflow.
5681 (Fencode_char): Use INTEGER_TO_CONS.
5682 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5683 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5684 * data.c (long_to_cons, cons_to_long): Remove.
5685 (cons_to_unsigned, cons_to_signed): New functions.
5686 These signal an error for invalid or out-of-range values.
5687 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5688 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5689 * font.c (Ffont_variation_glyphs):
5690 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5691 * lisp.h: Include <intprops.h>.
5692 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5693 (cons_to_signed, cons_to_unsigned): New decls.
5694 (long_to_cons, cons_to_long): Remove decls.
5695 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5696 (Fprimitive_undo): Use CONS_TO_INTEGER.
5697 * xfns.c (Fx_window_property): Likewise.
5698 * xselect.c: Include <limits.h>.
5699 (x_own_selection, selection_data_to_lisp_data):
5700 Use INTEGER_TO_CONS.
5701 (x_handle_selection_request, x_handle_selection_clear)
5702 (x_get_foreign_selection, Fx_disown_selection_internal)
5703 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5704 (lisp_data_to_selection_data): Use cons_to_unsigned.
5705 (x_fill_property_data): Use cons_to_signed.
5706 Report values out of range.
5707
d1f3d2af
PE
5708 Check for buffer and string overflow more precisely.
5709 * buffer.h (BUF_BYTES_MAX): New macro.
5710 * lisp.h (STRING_BYTES_MAX): New macro.
5711 * alloc.c (Fmake_string):
5712 * character.c (string_escape_byte8):
5713 * coding.c (coding_alloc_by_realloc):
5714 * doprnt.c (doprnt):
5715 * editfns.c (Fformat):
5716 * eval.c (verror):
5717 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5718 since they may not be the same number.
5719 * editfns.c (Finsert_char):
5720 * fileio.c (Finsert_file_contents):
5721 Likewise for BUF_BYTES_MAX.
5722
dd52fcea
PE
5723 * image.c: Use ptrdiff_t, not int, for sizes.
5724 (slurp_file): Switch from int to ptrdiff_t.
5725 All uses changed.
5726 (slurp_file): Check that file size fits in both size_t (for
5727 malloc) and ptrdiff_t (for sanity and safety).
5728
7f9bbdbb
PE
5729 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5730 if b->modtime has its maximal value.
5731
dfe18f82
PE
5732 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5733
84acfcf0
PE
5734 Don't assume time_t can fit into int.
5735 * buffer.h (struct buffer.modtime): Now time_t, not int.
5736 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5737 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5738
ccd9a01a
PE
5739 Minor fixes for signed vs unsigned integers.
5740 * character.h (MAYBE_UNIFY_CHAR):
5741 * charset.c (maybe_unify_char):
5742 * keyboard.c (read_char, reorder_modifiers):
5743 XINT -> XFASTINT, since the integer must be nonnegative.
5744 * ftfont.c (ftfont_spec_pattern):
5745 * keymap.c (access_keymap, silly_event_symbol_error):
5746 XUINT -> XFASTINT, since the integer must be nonnegative.
5747 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5748 since it makes no difference and we prefer signed.
5749 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5750 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5751 nonnegative.
5752
d6d100dd
SM
57532011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5754
5755 * window.h (Fwindow_frame): Declare.
5756
2b6148e4
PE
57572011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5758
5759 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5760 (SPARE_MEMORY): Always define.
5761 (LARGE_REQUEST): Remove.
5762 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5763
f230ecc9
MR
57642011-06-06 Martin Rudalics <rudalics@gmx.at>
5765
727e958e
MR
5766 * lisp.h: Move EXFUNS for Fframe_root_window,
5767 Fframe_first_window and Fset_frame_selected_window to window.h.
5768
5769 * window.h: Move EXFUNS for Fframe_root_window,
5770 Fframe_first_window and Fset_frame_selected_window here from
5771 lisp.h.
5772
5773 * frame.c (Fwindow_frame, Fframe_first_window)
5774 (Fframe_root_window, Fframe_selected_window)
5775 (Fset_frame_selected_window): Move to window.c.
5776 (Factive_minibuffer_window): Move to minibuf.c.
5777 (Fother_visible_frames_p): New function.
5778
5779 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5780
f230ecc9
MR
5781 * window.c (decode_window, decode_any_window): Move up in code.
5782 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5783 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5784 (Fwindow_buffer): Move up and rewrite doc-string.
5785 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5786 (Fwindow_prev): New functions.
727e958e
MR
5787 (Fwindow_frame): Move here from frame.c. Accept any window as
5788 argument.
5789 (Fframe_root_window, Fframe_first_window)
5790 (Fframe_selected_window): Move here from frame.c. Accept frame
5791 or arbitrary window as argument. Update doc-strings.
5792 (Fminibuffer_window): Move up in code.
5793 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5794 (Fset_frame_selected_window): Move here from frame.c.
5795 Marginal rewrite.
727e958e
MR
5796 (Fselected_window, select_window, Fselect_window): Move up in
5797 code. Minor doc-string fixes.
f230ecc9 5798
4d09bcf6
PE
57992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5800
5801 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5802 Do not assume that spare memory exists; that assumption is valid
5803 only if SYSTEM_MALLOC.
5804 (LARGE_REQUEST): New macro, so that the issue of large requests
5805 is separated from the issue of spare memory.
5806
810928a2
AS
58072011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5808
172418ad
AS
5809 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5810 format. (Bug#8806)
5811
43f862f7
AS
5812 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5813
810928a2
AS
5814 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5815 before statements.
5816
a059fe24
JD
58172011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5818
5819 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5820
5821 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5822
5823 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5824 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5825
989bf368
JB
58262011-06-05 Juanma Barranquero <lekktu@gmail.com>
5827
5828 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5829
4b80f674
CY
58302011-06-04 Chong Yidong <cyd@stupidchicken.com>
5831
5832 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5833 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5834 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5835 New error handlers.
4b80f674
CY
5836 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5837 Obey Vx_select_enable_clipboard_manager. Catch errors in
5838 x_clipboard_manager_save (Bug#8779).
5839 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5840 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5841
99a33b77 58422011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5843
5844 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5845
99a33b77 58462011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5847
5848 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5849 in the current matrix if keep_current_p is non-zero.
5850
8264569d
EZ
58512011-06-04 Eli Zaretskii <eliz@gnu.org>
5852
5853 * bidi.c (bidi_level_of_next_char): Fix last change.
5854
57f97249
EZ
58552011-06-03 Eli Zaretskii <eliz@gnu.org>
5856
fec2107c 5857 Support bidi reordering of text covered by display properties.
57f97249 5858
fec2107c
EZ
5859 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5860 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5861 (bidi_cache_search, bidi_cache_iterator_state)
5862 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5863 (bidi_level_of_next_char, bidi_move_to_visually_next):
5864 Support character positions inside a run of characters covered by a
fec2107c
EZ
5865 display string.
5866 (bidi_paragraph_init, bidi_resolve_explicit_1)
5867 (bidi_level_of_next_char): Call bidi_fetch_char and
5868 bidi_fetch_char_advance instead of FETCH_CHAR and
5869 FETCH_CHAR_ADVANCE.
5870 (bidi_init_it): Initialize new members.
5871 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5872 definitions.
5873 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5874 instead of using explicit *_CHAR codes.
d6d100dd
SM
5875 (bidi_resolve_explicit, bidi_resolve_weak):
5876 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5877 bidirectional text is supported only in multibyte buffers.
5878 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5879 it to initialize the frame_window_p member of struct bidi_it.
5880 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5881 (bidi_resolve_explicit, bidi_resolve_weak)
5882 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5883 bidi_it->nchars is non-positive.
5884 (bidi_level_of_next_char): Don't try to lookup the cache for the
5885 next/previous character if nothing is cached there yet, or if we
5886 were just reseat()'ed to a new position.
c40e2fb2 5887
0e14fe90
EZ
5888 * xdisp.c (set_cursor_from_row): Set start and stop points
5889 according to the row's direction when priming the loop that looks
5890 for the glyph on which to display cursor.
5891 (single_display_spec_intangible_p): Function deleted.
5892 (display_prop_intangible_p): Reimplement to call
5893 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5894 Accept 3 additional arguments needed by handle_display_spec.
5895 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5896 values: lists, `(when COND...)' forms, etc.
5897 (single_display_spec_string_p): Support property values that are
5898 lists with the argument STRING its top-level element.
5899 (display_prop_string_p): Fix the condition for processing a
5900 property that is a list to be consistent with handle_display_spec.
fec2107c 5901 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5902 last portion of handle_display_prop.
5903 (compute_display_string_pos): Accept additional argument
5904 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5905 value of a `display' property is a "replacing spec".
5906 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5907 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5908 the display property, but just return a value indicating whether
5909 the display property will replace the characters it covers.
5910 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5911 frame_window_p members of struct bidi_it.
d6d100dd
SM
5912 (compute_display_string_pos, compute_display_string_end):
5913 New functions.
fec2107c
EZ
5914 (push_it): Accept second argument POSITION, where pop_it should
5915 jump to continue iteration.
5916 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5917
fec2107c
EZ
5918 * keyboard.c (adjust_point_for_property): Adjust the call to
5919 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5920
5921 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5922 (bidi_init_it): Update prototypes.
5923 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5924 (compute_display_string_pos, compute_display_string_end):
5925 Declare prototypes.
fec2107c
EZ
5926 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5927 EMACS_INT.
fc6f18ce 5928
40087514 59292011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5930
57f53182
PE
5931 Malloc failure behavior now depends on size of allocation.
5932 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5933 * lisp.h: Change signatures accordingly.
5934 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5935 All callers changed. (Bug#8762)
5936
5937 * gnutls.c: Use Emacs's memory allocators.
5938 Without this change, the gnutls library would invoke malloc etc.
5939 directly, which causes problems on non-SYNC_INPUT hosts, and which
5940 runs afoul of improving memory_full behavior. (Bug#8761)
5941 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5942 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5943 xfree instead of the default malloc, realloc, free.
5944 (Fgnutls_boot): No need to check for memory allocation failure,
5945 since xmalloc does that for us.
5946
ac32cd99 5947 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5948 * category.c (hash_get_category_set):
5949 * ccl.c (ccl_driver):
5950 * charset.c (Fdefine_charset_internal):
5951 * charset.h (struct charset.hash_index):
5952 * composite.c (get_composition_id, gstring_lookup_cache)
5953 (composition_gstring_put_cache):
5954 * composite.h (struct composition.hash_index):
5955 * dispextern.h (struct image.hash):
5956 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5957 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5958 (hashfn_equal, hashfn_user_defined, make_hash_table)
5959 (maybe_resize_hash_table, hash_lookup, hash_put)
5960 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5961 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5962 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5963 * image.c (make_image, search_image_cache, lookup_image)
5964 (xpm_put_color_table_h):
5965 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5966 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5967 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5968 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5969 * alloc.c (allocate_vectorlike):
5970 Check for overflow in vector size calculations.
5971 * ccl.c (ccl_driver):
5972 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5973 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5974 need to be updated by these changes.
40087514
PE
5975 * fns.c (make_hash_table, maybe_resize_hash_table):
5976 Check for integer overflow with large hash tables.
0de4bb68
PE
5977 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5978 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5979 (SXHASH_REDUCE): New macro.
5980 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5981 Use it instead of discarding useful hash info with large hash values.
5982 (sxhash_float): New function.
5983 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5984 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5985 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5986 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5987 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5988 Adjust signatures to match updated version of code.
5989 (consing_since_gc): Now EMACS_INT, since a single hash table can
5990 use more than INT_MAX bytes.
5991
698d32e2
DN
59922011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5993
5994 Make it possible to build with GCC-4.6+ -O2 -flto.
5995
5996 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5997
fd6fa53f
SM
59982011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5999
6000 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6001 Call minibuffer-inactive-mode.
6002
864db017
JB
60032011-05-31 Juanma Barranquero <lekktu@gmail.com>
6004
6005 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6006 Update dependencies.
6007
2ad0baf4
DN
60082011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6009
6010 * data.c (init_data): Remove code for UTS, this system is not
6011 supported anymore.
6012
4fcc2638
DN
60132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6014
6015 Don't force ./temacs to start in terminal mode.
6016
6017 * frame.c (make_initial_frame): Initialize faces in all cases, not
6018 only when CANNOT_DUMP is defined.
6019 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6020
c56e0fd5
DN
60212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6022
6023 * dispnew.c (add_window_display_history): Use const for the string
6024 pointer. Remove declaration, not needed.
6025
333d54da 60262011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6027
55d4c1b2 6028 Use 'inline', not 'INLINE'.
333d54da 6029 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6030 * alloc.c, fontset.c (INLINE): Remove.
6031 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6032 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6033 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6034 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6035 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6036
738db178
DN
60372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6038
6039 Make it possible to run ./temacs.
6040
6041 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6042 syms_of_callproc does the same thing. Remove test for
6043 "initialized", do it in the caller.
6044 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6045
620c53a6
SM
60462011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6047
6048 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6049 (read_minibuf): Use get_minibuffer.
6050 (syms_of_minibuf): Use DEFSYM.
6051 (Qmetadata): New var.
6052 * data.c (Qbuffer): Don't make it static.
6053 (syms_of_data): Use DEFSYM.
6054
e003a292
PE
60552011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6056
6057 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6058 (CCL_CODE_MIN): New macro.
6059
ed008a6d
PE
60602011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6061
3687c2ef
PE
6062 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6063
ed008a6d
PE
6064 * eval.c (Qdebug): Now static.
6065 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6066 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6067 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6068
d66c4c7c
CY
60692011-05-29 Chong Yidong <cyd@stupidchicken.com>
6070
6071 * image.c: Various fixes to ImageMagick code comments.
6072 (Fimagemagick_types): Doc fix.
6073
5fbc2025
PE
60742011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6075
0196f88a
PE
6076 Minor fixes prompted by GCC 4.6.0 warnings.
6077
6078 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6079
5fbc2025
PE
6080 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6081 (x_clipboard_manager_save_all): Move extern decl to ...
6082 * xterm.h: ... here, so that it can be checked for consistency.
6083
1dd3c2d9
CY
60842011-05-29 Chong Yidong <cyd@stupidchicken.com>
6085
6086 * xselect.c (x_clipboard_manager_save_frame)
6087 (x_clipboard_manager_save_all): New functions.
6088 (Fx_clipboard_manager_save): Lisp function deleted.
6089
6090 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6091 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6092
6093 * xterm.h: Update prototype.
6094
5ba6571d
WX
60952011-05-28 William Xu <william.xwl@gmail.com>
6096
6097 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6098 exiting (Bug#8239).
6099
3eaff834
JM
61002011-05-28 Jim Meyering <meyering@redhat.com>
6101
e1900994 6102 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6103 * fns.c (to_uchar): Define.
6104 (crypto_hash_function): Use it to convert some newly-signed
6105 variables to unsigned, to avoid sign-extension bugs. For example,
6106 without this change, (md5 "truc") would evaluate to
6107 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6108 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6109 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6110
0f6990a7
PE
61112011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6112
6113 Integer overflow fixes.
c8a9ca5a 6114
08686060
PE
6115 * dbusbind.c: Serial number integer overflow fixes.
6116 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6117 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6118 to hold a serial number that is too large for a fixnum.
6119 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6120 Check for serial numbers out of range. Decode any serial number
59568bf0 6121 that was so large that it became a float. (Bug#8722)
08686060 6122
2d1fc3c7
PE
6123 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6124 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6125 Use XFASTINT rather than XUINT when numbers are nonnegative.
6126 (xd_append_arg, Fdbus_method_return_internal):
6127 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6128 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6129 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6130 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6131 (Bug#8722)
2d1fc3c7 6132
c8a9ca5a
PE
6133 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6134
519e1d69
PE
6135 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6136
6df6ae42 6137 ccl: Add integer overflow checks.
30569699
PE
6138 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6139 (IN_INT_RANGE): New macros.
6140 (ccl_driver): Use them to check for integer overflow when
6141 decoding a CCL program. Many of the new checks are whether XINT (x)
6142 fits in int; it doesn't always, on 64-bit hosts. The new version
6143 doesn't catch all possible integer overflows, but it's an
847044ea 6144 improvement. (Bug#8719)
30569699 6145
c11285dc
PE
6146 * alloc.c (make_event_array): Use XINT, not XUINT.
6147 There's no need for unsigned here.
6148
fdccd48e
PE
6149 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6150 This follows up to the 2011-05-06 change that substituted uintptr_t
6151 for EMACS_INT. This case wasn't caught back then.
6152
37910ab2
PE
6153 Rework Fformat to avoid integer overflow issues.
6154 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6155 now (part of C89). Include <verify.h>.
6156 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6157 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6158 (Fformat): Avoid the prepass trying to compute sizes; it was only
6159 approximate and thus did not catch overflow reliably. Instead, walk
6160 through the format just once, formatting and computing sizes as we go,
6161 checking for integer overflow at every step, and allocating a larger
6162 buffer as needed. Keep track separately whether the format is
6163 multibyte. Keep only the most-recently calculated precision, rather
6164 than them all. Record whether each argument has been converted to
6165 string. Use EMACS_INT, not int, for byte and char and arg counts.
6166 Support field widths and precisions larger than INT_MAX. Avoid
6167 sprintf's undefined behavior with conversion specifications such as %#d
6168 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6169 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6170 formatting out-of-range floating point numbers with int
9173deec 6171 formats. (Bug#8668)
37910ab2 6172
2e6578fb
PE
6173 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6174
0ae6bdee
PE
6175 * data.c: Avoid integer truncation in expressions involving floats.
6176 * data.c: Include <intprops.h>.
6177 (arith_driver): When there's an integer overflow in an expression
6178 involving floating point, convert the integers to floating point
6179 so that the resulting value does not suffer from catastrophic
6180 integer truncation. For example, on a 64-bit host (* 4
6181 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6182 Do not rely on undefined behavior after integer overflow.
6183
de883a70
PE
6184 merge count_size_as_multibyte, parse_str_to_multibyte
6185 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6186 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6187 Check for integer overflow.
6188 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6189 since it's now a duplicate of the other. This is more of
6190 a character than a buffer op, so better that it's in character.c.
6191 * fns.c, print.c: Adjust to above changes.
6192
2ff916cb
PE
61932011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6194
6195 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6196
f1b54466
PE
61972011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6198
fb1ac845
PE
6199 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6200 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6201 (x_clipboard_manager_save): Now static.
6202 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6203
f1b54466
PE
6204 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6205 (crypto_hash_function): Now static.
6206 Fix pointer signedness problems. Avoid unnecessary initializations.
6207
a9f737ee
CY
62082011-05-27 Chong Yidong <cyd@stupidchicken.com>
6209
6210 * termhooks.h (Vselection_alist): Make it terminal-local.
6211
6212 * terminal.c (create_terminal): Initialize it.
6213
6214 * xselect.c: Support for clipboard managers.
6215 (Vselection_alist): Move to termhooks.h as terminal-local var.
6216 (LOCAL_SELECTION): New macro.
6217 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6218 (symbol_to_x_atom): Remove gratuitous arg.
6219 (x_handle_selection_request, lisp_data_to_selection_data)
6220 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6221 (x_own_selection, x_get_local_selection, x_convert_selection):
6222 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6223 (some_frame_on_display): Delete unused function.
6224 (Fx_own_selection_internal, Fx_get_selection_internal)
6225 (Fx_disown_selection_internal, Fx_selection_owner_p)
6226 (Fx_selection_exists_p): New optional frame arg.
6227 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6228 (x_handle_selection_clear): Don't treat other terminals with the
6229 same keyboard specially. Use the terminal-local Vselection_alist.
6230 (x_clear_frame_selections): Use Frun_hook_with_args.
6231
6232 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6233
6234 * xterm.h: Add support for those atoms.
6235
e067f0c1
CY
62362011-05-26 Chong Yidong <cyd@stupidchicken.com>
6237
6238 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6239 (converted_selections, conversion_fail_tag): New global variables.
6240 (x_selection_request_lisp_error): Free the above.
6241 (x_get_local_selection): Remove unnecessary code.
6242 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6243 of converted selections stored in converted_selections.
6244 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6245 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6246 (x_convert_selection): New function.
6247 (x_handle_selection_event): Simplify.
6248 (x_get_foreign_selection): Don't ignore incoming requests while
6249 waiting for an answer; this will fail when we implement
6250 SAVE_TARGETS, and seems unnecessary anyway.
6251 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6252 (Vx_sent_selection_functions): Doc fix.
6253
0f4aebc0
LL
62542011-05-26 Leo Liu <sdl.web@gmail.com>
6255
6256 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6257
e61124cd
YM
62582011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6259
6260 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6261
6262 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6263 for fringe update if it has periodic bitmap.
ac389d0c 6264 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6265 and fringe_bitmap_periodic_p.
6266
6267 * fringe.c (get_fringe_bitmap_data): New function.
6268 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6269 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6270 row. Mark glyph row for fringe update if periodicity changed.
6271
6272 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6273 for fringe update unless it has periodic bitmap.
6274
f16d9837
KH
62752011-05-25 Kenichi Handa <handa@m17n.org>
6276
6277 * xdisp.c (get_next_display_element): Set correct it->face_id for
6278 a static composition.
6279
e1b90ef6
LL
62802011-05-24 Leo Liu <sdl.web@gmail.com>
6281
6282 * deps.mk (fns.o):
6283 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6284
6285 * fns.c (crypto_hash_function, Fsha1): New function.
6286 (Fmd5): Use crypto_hash_function.
6287 (syms_of_fns): Add Ssha1.
6288
7400048f
PE
62892011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6290
6291 * gnutls.c: Remove unused macros.
6292 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6293 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6294 Remove macros that are defined and never used.
6295 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6296
abb71cf4
CY
62972011-05-22 Chong Yidong <cyd@stupidchicken.com>
6298
6299 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6300 (Fx_get_selection_internal): Minor cleanup.
6301 (Fx_own_selection_internal): Rename arguments for consistency with
6302 select.el.
6303
6307db39
PE
63042011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6305
6306 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6307
f3d4e0a4
CY
63082011-05-22 Chong Yidong <cyd@stupidchicken.com>
6309
6310 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6311
4d8ade89
YM
63122011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6313
6314 * dispnew.c (scrolling_window): Don't exclude the case that the
6315 last enabled row in the desired matrix touches the bottom boundary.
6316
32078c8d
GM
63172011-05-21 Glenn Morris <rgm@gnu.org>
6318
6319 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6320 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6321 and add some more files.
32078c8d 6322
7285dc67
EZ
63232011-05-20 Eli Zaretskii <eliz@gnu.org>
6324
6325 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6326 report_file_error introduced by the change from 2011-05-07.
6327
89d1bd22
PE
63282011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6329
6330 * systime.h (Time): Define only if emacs is defined.
6331 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6332 where the include path doesn't have X11/X.h by default. See
6333 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6334
cd394be1 63352011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6336
6337 * composite.c (find_automatic_composition): Fix previous change.
6338
b9704ad9
GM
63392011-05-20 Glenn Morris <rgm@gnu.org>
6340
6341 * lisp.mk: New file, split from Makefile.in.
6342 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6343 (shortlisp): Remove.
6344 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6345
4a720484
GM
63462011-05-19 Glenn Morris <rgm@gnu.org>
6347
6348 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6349 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6350 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6351 (lisp): Set the order to that of loadup.el.
6352 (shortlisp): Make it a copy of $lisp.
6353 (SOME_MACHINE_LISP): Remove.
6354 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6355 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6356
a28d4396
KH
63572011-05-18 Kenichi Handa <handa@m17n.org>
6358
6359 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6360 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6361 (find_automatic_composition): Mostly rewrite for efficiency.
6362
a2b1fa8e
JB
63632011-05-18 Juanma Barranquero <lekktu@gmail.com>
6364
6365 * makefile.w32-in: Update dependencies.
6366
8e1f5610
CS
63672011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6368
6369 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6370 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6371
7025ee00 63722011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6373
cdfa6eab
PE
6374 Fix some integer overflow issues, such as string length overflow.
6375
06d6db33
PE
6376 * insdel.c (count_size_as_multibyte): Check for string overflow.
6377
2b4560a8
PE
6378 * character.c (lisp_string_width): Check for string overflow.
6379 Use EMACS_INT, not int, for string indexes and lengths; in
6380 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6381 the resulting string length overflows an EMACS_INT; instead,
6382 report a string overflow if no precision given. When checking for
6383 precision exhaustion, use a check that cannot possibly have
6384 integer overflow. (Bug#8675)
6385 * character.h (lisp_string_width): Adjust to new signature.
6386
cb93f9be
PE
6387 * alloc.c (string_overflow): New function.
6388 (Fmake_string): Use it. This doesn't change behavior, but saves
6389 a few bytes and will simplify future changes.
6390 * character.c (string_escape_byte8): Likewise.
6391 * lisp.h (string_overflow): New decl.
6392
1a1f3366
PE
6393 Fixups, following up to the user-interface timestamp change.
6394 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6395 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6396 * msdos.c (mouse_get_pos): Likewise.
6397 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6398 * w32gui.h (Time): Define by including "systime.h" rather than by
6399 declaring it ourselves. (Bug#8664)
6400
d4e3e4d3
PE
6401 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6402 * image.c (clear_image_cache): Likewise.
6403
f6a24d19
PE
6404 * term.c (term_mouse_position): Don't assume time_t wraparound.
6405
08dc5ae6
PE
6406 Be more systematic about user-interface timestamps.
6407 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6408 and sometimes 'EMACS_UINT', to represent these timestamps.
6409 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6410 This makes the code easier to follow, and makes it easier to catch
6411 integer overflow bugs such as Bug#8664.
6412 * frame.c (Fmouse_position, Fmouse_pixel_position):
6413 Use Time, not unsigned long, for user-interface timestamps.
6414 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6415 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6416 * keyboard.h (last_event_timestamp): Likewise.
6417 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6418 * menu.h (xmenu_show): Likewise.
6419 * term.c (term_mouse_position): Likewise.
6420 * termhooks.h (struct input_event.timestamp): Likewise.
6421 (struct terminal.mouse_position_hook): Likewise.
6422 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6423 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6424 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6425 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6426 what it was before.
6427 * menu.h, termhooks.h: Include "systime.h", for Time.
6428
8e55734a
PE
6429 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6430 Don't assume that the difference between two unsigned long values
6431 can fit into an integer. At this point, we know button_down_time
6432 <= event->timestamp, so the difference must be nonnegative, so
6433 there's no need to cast the result if double-click-time is
6434 nonnegative, as it should be; check that it's nonnegative, just in
6435 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6436 apart (about 25 days). (Bug#8664)
8e55734a 6437
841f1b75 6438 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6439 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6440
3e26f69c
PE
6441 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6442 that always fit in int. Use a sentinel instead of a counter, to
6443 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6444 * frame.h (struct frame): Use int for menu_bar_items_used
6445 instead of EMACS_INT, since it always fits in int.
3e26f69c 6446
5cc152c0
PE
6447 * menu.c (grow_menu_items): Check for int overflow.
6448
d89eb65e
PE
6449 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6450
5235bd3e
PE
6451 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6452 Before, the code was not consistent. These values cannot exceed
6453 2**31 - 1 so there's no need to make them unsigned.
6454 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6455 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6456 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6457 as modifiers.
6458 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6459
bc827e23
PE
6460 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6461 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6462 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6463 presumably because the widths might not match.
6464
78eb494e
PE
6465 * window.c (size_window): Avoid needless test at loop start.
6466
04f2d78b
CB
64672011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6468
6469 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6470
d2fc7e3d 64712011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6472
6473 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6474
d2fc7e3d 64752011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6476
6477 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6478 `width' to `bar_area_x' and `bar_area_width', respectively.
6479 (x_scroll_run): Take account of fringe background extension.
6480
04f2d78b
CB
6481 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6482 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6483 `bar_area_width', respectively.
6484 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6485 background extension.
6486
79b70037
GM
64872011-05-10 Jim Meyering <meyering@redhat.com>
6488
6489 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6490
2f142cc5
JB
64912011-05-10 Juanma Barranquero <lekktu@gmail.com>
6492
6493 * image.c (Finit_image_library): Return t for built-in image types,
6494 like pbm and xbm. (Bug#8640)
6495
57679c86
AS
64962011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6497
6498 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6499
888c9e86
EZ
65002011-05-07 Eli Zaretskii <eliz@gnu.org>
6501
b0512a1d
EZ
6502 * w32console.c (Fset_screen_color): Doc fix.
6503 (Fget_screen_color): New function.
6504 (syms_of_ntterm): Defsubr it.
6505
7285dc67
EZ
6506 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6507 unlink the temporary file if Fcall_process didn't create it in the
6508 first place.
6509 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6510 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6511 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6512 cue to call_process_cleanup not to close that handle.
6513
4d3fcc8e
BK
65142011-05-07 Ben Key <bkey76@gmail.com>
6515
6516 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6517 one of two shell specific rules, either bootstrap-temacs-CMD or
6518 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6519 to the previous implementation of the bootstrap-temacs rule.
6520 The bootstrap-temacs-CMD rule is similar to the previous
6521 implementation of the bootstrap-temacs rule except that it
6522 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6523 variable.
6524
6525 These changes, along with some changes to nt/configure.bat,
6526 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6527 earlier fix to add support for --cflags and --ldflags options
6528 that include quotes so that it works whether make uses cmd or
6529 sh as the shell.
6530
b4289b64
MA
65312011-05-06 Michael Albinus <michael.albinus@gmx.de>
6532
6533 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6534 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6535 is a constant.
6536 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6537 a string. Handle both cases.
6538 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6539 (Fdbus_register_method): Use Qinvalid_function.
6540
af4c0e28
JB
65412011-05-06 Juanma Barranquero <lekktu@gmail.com>
6542
6543 * makefile.w32-in: Update dependencies.
6544 (LISP_H): Add inttypes.h and stdin.h.
6545 (PROCESS_H): Add unistd.h.
6546
c51453d9
EZ
65472011-05-06 Eli Zaretskii <eliz@gnu.org>
6548
6549 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6550 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6551
8ff0ac3c 65522011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6553
4c4b566b
PE
6554 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6555
aab2b9b5
PE
6556 * term.c (vfatal): Remove stray call to va_end.
6557 It's not needed and the C Standard doesn't allow it here anyway.
6558
c378da0b
PE
6559 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6560 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6561
288b08c7
PE
6562 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6563 bytes.
6564
e3601888
PE
6565 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6566
db6c0e74
PE
6567 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6568
dd5963ea
PE
6569 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6570
88c9450f
PE
6571 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6572
2f9442b8
PE
6573 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6574
c032b5f8
PE
6575 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6576 * charset.c (Fdefine_charset_internal): Don't initialize
6577 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6578 32-bit int (Bug#8600).
a108c10b
PE
6579
6580 * lread.c (read_integer): Be more consistent with string-to-number.
6581 Use string_to_number to do the actual conversion; this avoids
6582 rounding errors and fixes some other screwups. Without this fix,
6583 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6584 (digit_to_number): Move earlier, for benefit of read_integer.
6585 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6586 not a digit in any supported base. (Bug#8602)
a108c10b 6587
ad5f9eea
PE
6588 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6589
aec1708a
PE
6590 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6591 to match comment at start of function. This also removes a
6592 GCC warning about overflow in a 32+64-bit port.
6593
47be4ab5
PE
6594 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6595
371cac43
PE
6596 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6597 Reported by Stefan Monnier in
6598 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6599 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6600 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6601
d01a7826
PE
6602 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6603 (EMACS_UINTPTR): Likewise, with uintptr_t.
6604
7fd47d5c
PE
6605 * lisp.h: Prefer 64-bit EMACS_INT if available.
6606 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6607 on 32-bit hosts that have 64-bit int, so that they can access
6608 large files.
122b0c86
PE
6609 However, temporarily disable this change unless the temporary
6610 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6611
8727937b
PE
6612 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6613
8ac068ac
PE
6614 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6615 This removes an assumption that EMACS_INT and long are the same
6616 width as pointers. The assumption is true for Emacs porting targets
6617 now, but we want to make other targets possible.
6618 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6619 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6620 In the rest of the code, change types of integers that hold casted
6621 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6622 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6623 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6624 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6625 No need to cast type when ORing.
6626 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6627 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6628 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6629 assume EMACS_INT is the same width as char *.
6630 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6631 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6632 Remove no-longer-needed casts.
6633 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6634 (xg_tool_bar_help_callback, xg_make_tool_item):
6635 Use EMACS_INTPTR to hold an integer
6636 that will be cast to void *; this can avoid a GCC warning
6637 if EMACS_INT is not the same width as void *.
6638 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6639 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6640 (current_message_1, set_message_1):
6641 Use a local to convert to proper width without a cast.
6642 * xmenu.c (dialog_selection_callback): Likewise.
6643
ede49d71
PE
6644 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6645 Also, don't assume VALBITS / RAND_BITS is less than 5,
6646 and don't rely on undefined behavior when shifting a 1 left into
6647 the sign bit.
6648 * lisp.h (get_random): Change signature to match.
6649
2f30ecd0
PE
6650 * lread.c (hash_string): Use size_t, not int, for hash computation.
6651 Normally we prefer signed values; but hashing is special, because
6652 it's better to use unsigned division on hash table sizes so that
6653 the remainder is nonnegative. Also, size_t is the natural width
6654 for hashing into memory. The previous code used 'int', which doesn't
6655 retain enough info to hash well into very large tables.
6656 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6657
2a866e7b
PE
6658 * dbusbind.c: Don't possibly lose pointer info when converting.
6659 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6660 Use XPNTR rather than XHASH, so that the high-order bits of
6661 the pointer aren't lost when converting through void *.
6662
51639eac
PE
6663 * eval.c (Fautoload): Don't double-shift a pointer.
6664
92394119
PE
6665 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6666
dbdb9a7c
JB
66672011-05-06 Juanma Barranquero <lekktu@gmail.com>
6668
6669 * gnutls.c (DEF_GNUTLS_FN):
6670 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6671
db7a0b4f
AS
66722011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6673
6674 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6675 marker. (Bug#8610)
6676
cd394be1 66772011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6678
6679 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6680 New version that can reserve upto 2GB of heap space.
6681
f7ff1b0f 66822011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6683
6684 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6685
639c109b
TZ
66862011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6687
6688 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6689 `gnutls_certificate_set_x509_key_file'.
6690
d2127135
JB
66912011-05-05 Juanma Barranquero <lekktu@gmail.com>
6692
6693 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6694 Update dependencies.
6695
e968f4f3
JB
66962011-05-04 Juanma Barranquero <lekktu@gmail.com>
6697
6698 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6699 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6700 Remove unused parameter `fildes'.
6701 * process.c (read_process_output, send_process): Don't pass it.
6702
84d358f0
JB
67032011-05-04 Juanma Barranquero <lekktu@gmail.com>
6704
6705 Fix previous change: the library cache is defined in w32.c.
6706 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6707 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6708
0898ca10
JB
67092011-05-04 Juanma Barranquero <lekktu@gmail.com>
6710
6711 Implement dynamic loading of GnuTLS on Windows.
6712
6713 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6714 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6715 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6716 Declare.
6717
6718 * gnutls.c (Qgnutls_dll): Define.
6719 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6720 (gnutls_*): Declare function pointers.
6721 (init_gnutls_functions): New function to initialize function pointers.
6722 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6723 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6724 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6725 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6726 (emacs_gnutls_write, emacs_gnutls_read)
6727 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6728 (Fgnutls_available_p): New function.
6729 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6730 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6731 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6732
6733 * image.c: Include w32.h.
6734 (Vimage_type_cache): Delete.
6735 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6736 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6737 (w32_delayed_load): Move to w32.c.
6738
6739 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6740
6741 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6742 (w32_delayed_load): Move from image.c. When loading a library, record
6743 its filename in the :loaded-from property of the library id.
6744 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6745 Initialize and staticpro them.
6746 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6747
6748 * process.c: Include lisp.h before w32.h, not after.
6749 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6750 instead of gnutls_record_check_pending.
6751
6752 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6753
ff4de4aa
TZ
67542011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6755
6756 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6757 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6758 as passed in.
6759
abe95abb
JD
67602011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6761
6762 * xterm.c (x_set_frame_alpha): Do not set property on anything
6763 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6764
e16e55d4
JB
67652011-05-02 Juanma Barranquero <lekktu@gmail.com>
6766
6767 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6768
bafcf6a5
JB
67692011-05-02 Juanma Barranquero <lekktu@gmail.com>
6770
6771 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6772 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6773 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6774 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6775 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6776 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6777 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6778 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6779 (Qgnutls_bootprop_callbacks_verify): Make static.
6780
e7a6747f
AS
67812011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6782
19ed11ba
AS
6783 * callproc.c: Indentation fixup.
6784
e7a6747f 6785 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6786 (wait_for_termination, interruptible_wait_for_termination):
6787 Move after wait_for_termination_1.
e7a6747f 6788
1ef14cb4
LMI
67892011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6790
6791 * sysdep.c (interruptible_wait_for_termination): New function
6792 which is like wait_for_termination, but allows keyboard
6793 interruptions.
6794
6795 * callproc.c (Fcall_process): Add (:file "file") as an option for
6796 the STDOUT buffer.
6797 (Fcall_process_region): Ditto.
6798
330d880c
EZ
67992011-04-30 Eli Zaretskii <eliz@gnu.org>
6800
8db90b73
EZ
6801 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6802 rather than `XVECTOR (FOO)->size'.
6803
330d880c
EZ
6804 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6805 inttypes.h, as a gnulib replacement is used if it not available in
6806 system headers.
6807
15cbd324
EZ
68082011-04-21 Eli Zaretskii <eliz@gnu.org>
6809
6810 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6811 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6812 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6813
6814 * coding.c (coding_alloc_by_realloc): Error out if destination
6815 will grow beyond MOST_POSITIVE_FIXNUM.
6816 (decode_coding_emacs_mule): Abort if there isn't enough place in
6817 charbuf for the composition carryover bytes. Reserve an extra
6818 space for up to 2 characters produced in a loop.
6819 (decode_coding_iso_2022): Abort if there isn't enough place in
6820 charbuf for the composition carryover bytes.
6821
68222011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6823
ae940cca
EZ
6824 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6825 aborting when %lld or %lll format is passed.
6826 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6827 %llo or %llx format is passed. (Bug#8545)
6828
03ab8921
EZ
6829 * window.c (window_scroll_line_based): Use a marker instead of
6830 simple variables to record original value of point. (Bug#7952)
6831
afda1437
EZ
6832 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6833 produced by %s or %c overflows available buffer space. (Bug#8545)
6834
f76dee0c
PE
68352011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6836
6837 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6838 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6839
fdc5744d
JB
68402011-04-28 Juanma Barranquero <lekktu@gmail.com>
6841
6842 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6843
638f053a
JB
68442011-04-28 Juanma Barranquero <lekktu@gmail.com>
6845
6846 * keyboard.c (Qdelayed_warnings_hook): Define.
6847 (command_loop_1): Run `delayed-warnings-hook'
6848 if Vdelayed_warnings_list is non-nil.
6849 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6850 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6851
d178f871
EZ
68522011-04-28 Eli Zaretskii <eliz@gnu.org>
6853
6854 * doprnt.c (doprnt): Don't return value smaller than the buffer
6855 size if the message was truncated. (Bug#8545).
6856
b124fd93
JB
68572011-04-28 Juanma Barranquero <lekktu@gmail.com>
6858
6859 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6860 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6861
e810457d
PE
68622011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6863
6864 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6865
ea51cceb
JB
68662011-04-27 Juanma Barranquero <lekktu@gmail.com>
6867
6868 * makefile.w32-in: Update dependencies.
6869
94dcfacf
EZ
68702011-04-27 Eli Zaretskii <eliz@gnu.org>
6871
6872 Improve `doprnt' and its usage. (Bug#8545)
6873 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6874 `format_end'. Remove support for %l as a conversion specifier.
6875 Don't use xrealloc. Improve diagnostics when the %l size modifier
6876 is used. Update the commentary.
6877
6878 * eval.c (verror): Simplify calculation of size_t.
6879
6880 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6881 messages.
6882
f61f41d7
PE
68832011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6884
6885 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6886 change.
6887
96fb4434
PE
68882011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6889
6890 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6891 This makes this file independent of the recent pseudovector change.
6892
671875da 68932011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6894
69e9b5a3
PE
6895 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6896
b5f869a7 6897 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6898 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6899 Remove unused local.
c8926152 6900 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6901
841a1577 6902 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6903 GCC 4.6.0 optimizes based on type-based alias analysis.
6904 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6905 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6906 != &v->size, and therefore "v->size = 1; b->size = 2; return
6907 v->size;" must therefore return 1. This assumption is incorrect
6908 for Emacs, since it type-puns struct Lisp_Vector * with many other
6909 types. To fix this problem, this patch adds a new type struct
f904488f 6910 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6911 and pseudovectors, and helps optimizing compilers not get fooled
6912 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6913 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6914 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6915 the size member.
eab3844f
PE
6916 (XSETPVECTYPE): Rewrite in terms of new macro.
6917 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6918 This is a bit clearer, and further avoids the possibility of
6919 undesirable aliasing.
6920 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6921 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6922 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6923 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6924 (ASIZE): Now uses header.size rather than size.
6925 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6926 to avoid the hassle of writing XVECTOR (foo)->header.size.
6927 (struct vectorlike_header): New type.
eab3844f
PE
6928 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6929 object, to help avoid aliasing.
6930 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6931 (SUBRP): Likewise, since Lisp_Subr is a special case.
6932 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6933 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6934 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6935 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6936 changed to be "header.size" and "header.next".
6937 * buffer.h (struct buffer): Likewise.
6938 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6939 * frame.h (struct frame): Likewise.
6940 * process.h (struct Lisp_Process): Likewise.
6941 * termhooks.h (struct terminal): Likewise.
6942 * window.c (struct save_window_data, struct saved_window): Likewise.
6943 * window.h (struct window): Likewise.
6944 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6945 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6946 * buffer.c (init_buffer_once): Likewise.
6947 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6948 special case.
6949 * process.c (Fformat_network_address): Use local var for size,
6950 for brevity.
6951
0df1eac5
PE
6952 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6953
847ab9d1 6954 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6955 * data.c (atof): Remove decl; no longer used or needed.
6956 (digit_to_number): Move to lread.c.
6957 (Fstring_to_number): Use new string_to_number function, to be
6958 consistent with how the Lisp reader treats infinities and NaNs.
6959 Do not assume that floating-point numbers represent EMACS_INT
6960 without losing information; this is not true on most 64-bit hosts.
6961 Avoid double-rounding errors, by insisting on integers when
6962 parsing non-base-10 numbers, as the documentation specifies.
6963 * lisp.h (string_to_number): New decl, replacing ...
6964 (isfloat_string): Remove.
bc0a5c13 6965 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6966 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6967 appears to have been a coding error. Similarly, do not accept
6968 strings like +-1e0 as floating point numbers. Do not report
6969 overflow for integer overflows unless the base is not 10 which
6970 means we have no simple and reliable way to continue.
6971 Break out the floating-point parsing into a new
6972 function string_to_number, so that Fstring_to_number parses
6973 floating point numbers consistently with the Lisp reader.
04f2d78b 6974 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6975 (E_CHAR, EXP_INT): Remove, replacing with ...
6976 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6977 (string_to_number): New function, replacing isfloat_string.
6978 This function checks for valid syntax and produces the resulting
6979 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6980 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6981 so that overflow for non-base-10 numbers is reported only when
6982 there's no portable and simple way to convert to floating point.
452f4150 6983
67769ffc
PE
6984 * textprop.c (set_text_properties_1): Rewrite for clarity,
6985 and to avoid GCC warning about integer overflow.
6986
c20db43f
PE
6987 * intervals.h (struct interval): Use EMACS_INT for members
6988 where EMACS_UINT might cause problems. See
6989 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6990 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6991 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6992 All uses changed.
37aa2f85
PE
6993 (offset_intervals): Tell GCC not to worry about length overflow
6994 when negating a negative length.
c20db43f 6995
2538aa2f
PE
6996 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6997 (overrun_check_free): Likewise.
6998
f2d3008d
PE
6999 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7000 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7001 word size.
7002
ec8df744
PE
7003 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7004 (gnutls_make_error): Rename local to avoid shadowing.
7005 (gnutls_emacs_global_deinit): ifdef out; not used.
7006 (Fgnutls_boot): Use const for pointer to readonly storage.
7007 Comment out unused local. Fix pointer signedness problems.
7008
640ee02d
PE
7009 * lread.c (openp): Don't stuff size_t into an 'int'.
7010 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7011 about possible signed overflow.
7012
6048fb2a
PE
7013 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7014 (GDK_KEY_g): Don't define if already defined.
7015 (xg_prepare_tooltip): Avoid pointer signedness problem.
7016 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7017
fa3c87e1
PE
7018 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7019 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7020
2172544b
PE
7021 * xfns.c (Fx_window_property): Simplify a bit,
7022 to make a bit faster and to avoid GCC 4.6.0 warning.
7023 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7024
9b821a21
PE
7025 * fns.c (internal_equal): Don't assume size_t fits in int.
7026
3c616cfa
PE
7027 * alloc.c (compact_small_strings): Tighten assertion a little.
7028
c2982e87
PE
7029 Replace pEd with more-general pI, and fix some printf arg casts.
7030 * lisp.h (pI): New macro, generalizing old pEd macro to other
7031 conversion specifiers. For example, use "...%"pI"d..." rather
7032 than "...%"pEd"...".
7033 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7034 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7035 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7036 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7037 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7038 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7039 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7040 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7041 64-bit hosts.
7042 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7043 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7044 * print.c (safe_debug_print, print_object): Likewise.
7045 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7046 to int.
6f04d126
PE
7047 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7048 avoiding the 0 flag, which is not portable.
c2982e87
PE
7049 * process.c (Fmake_network_process): Use pI to avoid cast.
7050 * region-cache.c (pp_cache): Likewise.
7051 * xdisp.c (decode_mode_spec): Likewise.
7052 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7053 behavior on 64-bit hosts with printf arg.
6f04d126 7054 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7055 (x_stop_queuing_selection_requests): Likewise.
7056 (x_get_window_property): Don't truncate byte count to an 'int'
7057 when tracing.
0b432f21 7058
5e073ec7
PE
7059 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7060 here, since it parses constructs like leading '-' and spaces,
7061 which are not wanted; and it overflows with large numbers.
7062 Instead, simply match F[0-9]+, which is what is wanted anyway.
7063
36372bf9
PE
7064 * alloc.c: Remove unportable assumptions about struct layout.
7065 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7066 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7067 (allocate_vectorlike, make_pure_vector): Use the new macros,
7068 plus offsetof, to remove unportable assumptions about struct layout.
7069 These assumptions hold on all porting targets that I know of, but
7070 they are not guaranteed, they're easy to remove, and removing them
7071 makes further changes easier.
7072
0b432f21
PE
7073 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7074 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7075 (string_overrun_cookie): Now const. Use initializers that
7076 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7077 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7078 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7079 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7080 multiple of sizeof (EMACS_INT); it need not be, if
7081 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7082 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7083
895009e1
JB
70842011-04-26 Juanma Barranquero <lekktu@gmail.com>
7085
7086 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7087
6a7a1b0b
TZ
70882011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7089
7090 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7091 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7092 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7093
841a1577 70942011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7095
7096 * lisp.h (Qdebug): List symbol.
895009e1 7097 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7098 * keyboard.c (debug-on-event): New variable.
7099 (handle_user_signal): Break into debugger when debug-on-event
7100 matches the current signal symbol.
7101
f2d3ba6f
DN
71022011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7103
7104 * alloc.c (check_sblock, check_string_bytes)
7105 (check_string_free_list): Convert to standard C.
7106
42ce4c63
TZ
71072011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7108
7109 * w32.c (emacs_gnutls_push): Fix typo.
7110
825cd63c
EZ
71112011-04-25 Eli Zaretskii <eliz@gnu.org>
7112
fb11d64d
EZ
7113 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7114 "cast to pointer from integer of different size".
7115
825cd63c
EZ
7116 Improve doprnt and its use in verror. (Bug#8545)
7117 * doprnt.c (doprnt): Document the set of format control sequences
7118 supported by the function. Use SAFE_ALLOCA instead of always
7119 using `alloca'.
7120
7121 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7122 is one byte too soon. Don't use xrealloc; instead xfree and
7123 xmalloc anew.
7124
e061a11b
TZ
71252011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7126
7127 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7128 callbacks stage.
7129
7130 * gnutls.c: Renamed global_initialized to
7131 gnutls_global_initialized. Added internals for the
7132 :verify-hostname-error, :verify-error, and :verify-flags
7133 parameters of `gnutls-boot' and documented those parameters in the
7134 docstring. Start callback support.
9173deec
JB
7135 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7136 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7137 on error. Return error code.
e061a11b
TZ
7138 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7139 (emacs_gnutls_read): Likewise.
7140 (Fgnutls_boot): Return handshake error code.
7141 (emacs_gnutls_handle_error): New function.
7142 (wsaerror_to_errno): Likewise.
7143
7144 * w32.h (emacs_gnutls_pull): Add prototype.
7145 (emacs_gnutls_push): Likewise.
7146
7147 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7148 (emacs_gnutls_push): Likewise.
7149
71502011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7151
7152 * process.c (wait_reading_process_output): Check if GnuTLS
7153 buffered some data internally if no FDs are set for TLS
7154 connections.
7155
7156 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7157 (LIBS): Link to USER_LIBS.
7158 ($(BLD)/gnutls.$(0)): New target.
7159
fa6996bc
EZ
71602011-04-24 Eli Zaretskii <eliz@gnu.org>
7161
eb35682e
EZ
7162 * xdisp.c (handle_single_display_spec): Rename the
7163 display_replaced_before_p argument into display_replaced_p, to
7164 make it consistent with the commentary. Fix typos in the
7165 commentary.
7166
e2ad650c
EZ
7167 * textprop.c (syms_of_textprop): Remove dead code.
7168 (copy_text_properties): Delete obsolete commentary about an
7169 interface that was deleted long ago. Fix typos in the description
7170 of arguments.
7171
1b2de274
EZ
7172 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7173 to changes in oldXMenu/XMenu.h from 2011-04-16.
7174 <menu_help_message, prev_menu_help_message>: Constify.
7175 (IT_menu_make_room): menu->help_text is now `const char **';
7176 adjust.
7177
7178 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7179 to changes in oldXMenu/XMenu.h from 2011-04-16.
7180 (struct XMenu): Declare `help_text' `const char **'.
7181
7182 * xfaces.c <Qunspecified>: Make extern again.
7183
7184 * syntax.c: Include sys/types.h before including regex.h, as
7185 required by Posix.
7186
762b15be
EZ
7187 * doc.c (get_doc_string): Improve the format passed to `error'.
7188
7189 * doprnt.c (doprnt): Improve commentary.
7190
7191 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7192
7193 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7194 them with etags.
7195
f1052e5d
EZ
7196 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7197 changes in globals.h immediately force recompilation.
762b15be
EZ
7198 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7199 $(CURDIR)/s/ms-w32.h.
7200 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7201
fa6996bc
EZ
7202 * character.c (Fchar_direction): Function deleted.
7203 (syms_of_character): Don't defsubr it.
7204 <char-direction-table>: Deleted.
7205
e6c3da20
EZ
72062011-04-23 Eli Zaretskii <eliz@gnu.org>
7207
7208 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7209 * doprnt.c: Include limits.h.
7210 (SIZE_MAX): New macro.
04f2d78b
CB
7211 (doprnt): Return a size_t value. 2nd arg is now size_t.
7212 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7213 Improve overflow protection. Support `l' modifier for integer
7214 conversions. Support %l conversion. Don't assume an EMACS_INT
7215 argument for integer conversions and for %c.
7216
7217 * lisp.h (doprnt): Restore prototype.
7218
7219 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7220 $(SRC)/character.h.
7221
7222 * Makefile.in (base_obj): Add back doprnt.o.
7223
7224 * deps.mk (doprnt.o): Add back prerequisites.
7225 (callint.o): Depend on character.h.
7226
7227 * eval.c (internal_lisp_condition_case): Include the handler
7228 representation in the error message.
7229 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7230 when breaking from the loop.
7231
7232 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7233
7234 * callint.c (Fcall_interactively): When displaying error message
7235 about invalid control letter, pass the character's codepoint, not
7236 a pointer to its multibyte form. Improve display of the character
7237 in octal and display also its hex code.
7238
7239 * character.c (char_string): Use %x to display the (unsigned)
7240 codepoint of an invalid character, to avoid displaying a bogus
7241 negative value.
7242
7243 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7244 `error', not SYMBOL_NAME itself.
7245
7246 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7247 character arguments to `error'.
7248
7249 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7250 to `error' in error message about FINAL_CHAR argument. Make sure
7251 FINAL_CHAR is a character, and use %c when it is passed as
7252 argument to `error'.
7253
4ffd0d6b 72542011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7255
7256 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7257
7258 * w32.c: Include <time.h>.
7259 (sys_localtime): New function.
7260
4ffd0d6b 72612011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7262
7263 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7264
4ffd0d6b 7265 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7266
4ffd0d6b 72672011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7268
4ffd0d6b
GM
7269 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7270 zombies (Bug#8467).
aac0c6e3 7271
04c56954
EZ
72722011-04-19 Eli Zaretskii <eliz@gnu.org>
7273
7274 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7275 gl_state.e_property when gl_state.object is Qt.
7276
7277 * insdel.c (make_gap_larger): Remove limitation of buffer size
7278 to <= INT_MAX.
7279
16a43933
CY
72802011-04-18 Chong Yidong <cyd@stupidchicken.com>
7281
7282 * xdisp.c (lookup_glyphless_char_display)
7283 (produce_glyphless_glyph): Handle cons cell entry in
7284 glyphless-char-display.
7285 (Vglyphless_char_display): Document it.
7286
7287 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7288 glyphless-char-display.
7289
4581706e
CY
72902011-04-17 Chong Yidong <cyd@stupidchicken.com>
7291
7292 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7293
7294 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7295
7296 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7297 definition for no-X builds.
7298
4887c6e2 72992011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7300
fd35b6f9
PE
7301 Static checks with GCC 4.6.0 and non-default toolkits.
7302
5c1ccb01
PE
7303 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7304
006c5daa
PE
7305 * process.c (keyboard_bit_set): Define only if SIGIO.
7306 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7307 (send_process): Repair possible setjmp clobbering.
7308
efc736d3
PE
7309 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7310
4e2fe2e6
PE
7311 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7312
f97334a2
PE
7313 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7314
4e75f29d
PE
7315 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7316 Define only if needed.
7317
90efadd1
PE
7318 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7319 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7320 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7321
3c647824
PE
7322 * dispextern.h (struct redisplay_interface): Rename param
7323 to avoid shadowing.
e264f262 7324 * termhooks.h (struct terminal): Likewise.
761383f4 7325 * xterm.c (xembed_send_message): Likewise.
3c647824 7326
b58c5c4a
PE
7327 * insdel.c (make_gap_smaller): Define only if
7328 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7329
cad59032
PE
7330 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7331 it.
7332
c339dc2e
PE
7333 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7334 so that we aren't warned about unused symbols.
7335
91a3e27b
PE
7336 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7337
399c71d3 7338 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7339
8ffc96f5
PE
7340 * xfns.c (x_real_positions): Mark locals as initialized.
7341
eef9bc79
PE
7342 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7343
098db9dd
PE
7344 * xterm.c: Fix problems found by static analysis with other toolkits.
7345 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7346 (x_dispatch_event): Declare static if USE_GTK, and
7347 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7348 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7349 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7350 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7351 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7352
eb18f6cc
PE
7353 * xmenu.c (menu_help_callback): Pointer type fixes.
7354 Use const pointers when pointing at readonly data. Avoid pointer
7355 signedness clashes.
7356 (FALSE): Remove unused macro.
7357 (update_frame_menubar): Remove unused decl.
7358
1fe72bf8
PE
7359 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7360
60d9e1db
PE
7361 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7362 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7363 (single_menu_item): Rename local to avoid shadowing.
7364
39261c26
PE
7365 * keyboard.c (make_lispy_event): Remove unused local var.
7366
018c5e19
PE
7367 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7368 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7369
63d2b86e
PE
7370 * bitmaps: Change bitmaps from unsigned char back to the X11
7371 compatible char. Avoid the old compiler warnings about
7372 out-of-range initializers by using, for example, '\xab' rather
7373 than 0xab.
7374
aefd87e1
PE
7375 * xgselect.c (xgselect_initialize): Check vs interface
7376 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7377
bf501fb9
PE
7378 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7379
e9829fdf
PE
7380 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7381 to read-only memory.
7382
1086c095
PE
7383 * fns.c (vector): Remove; this old hack is no longer needed.
7384
2baccd04 7385 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7386 Remove unused var.
dde42981 7387 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7388
72391843 7389 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7390
436c16df 7391 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7392 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7393 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7394
92bb796d 7395 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7396 (x_term_init): Remove local to avoid shadowing.
92bb796d 7397
764430a3 7398 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7399
7400 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7401 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7402
d1dfb56c
EZ
74032011-04-16 Eli Zaretskii <eliz@gnu.org>
7404
c4354cb4
EZ
7405 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7406
d1dfb56c
EZ
7407 Fix regex.c, syntax.c and friends for buffers > 2GB.
7408 * syntax.h (struct gl_state_s): Declare character position members
7409 EMACS_INT.
7410
7411 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7412
04f2d78b
CB
7413 * textprop.c (verify_interval_modification, interval_of):
7414 Declare arguments EMACS_INT.
d1dfb56c
EZ
7415
7416 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7417 EMACS_INT.
7418
7419 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7420
7421 * indent.c (Fvertical_motion): Local variable it_start is now
7422 EMACS_INT.
7423
7424 * regex.c (re_match, re_match_2, re_match_2_internal)
7425 (bcmp_translate, regcomp, regexec, print_double_string)
7426 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7427 (re_compile_pattern, re_exec): Declare arguments and local
7428 variables `size_t' and `ssize_t' and return values `regoff_t', as
7429 appropriate.
7430 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7431 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7432 <compile_stack_type>: `size' and `avail' are now `size_t'.
7433
7434 * regex.h <regoff_t>: Use ssize_t, not int.
7435 (re_search, re_search_2, re_match, re_match_2): Arguments that
7436 specify buffer/string position and length are now ssize_t and
7437 size_t. Return type is regoff_t.
7438
613052cd
BK
74392011-04-16 Ben Key <bkey76@gmail.com>
7440
7441 * nsfont.m: Fixed bugs in ns_get_family and
7442 ns_descriptor_to_entity that were caused by using free to
7443 deallocate memory blocks that were allocated by xmalloc (via
7444 xstrdup). This caused Emacs to crash when compiled with
7445 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7446 --enable-checking=xmallocoverrun). xfree is now used to
7447 deallocate these memory blocks.
7448
4170f62f 74492011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7450
71b41406
PE
7451 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7452
9587a89d
PE
7453 emacs_write: Accept and return EMACS_INT for sizes.
7454 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7455 et seq.
7456 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7457 Accept and return EMACS_INT.
7458 (emacs_gnutls_write): Return the number of bytes written on
7459 partial writes.
7460 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7461 (emacs_read, emacs_write): Remove check for negative size, as the
7462 Emacs source code has been audited now.
9587a89d
PE
7463 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7464 (emacs_read, emacs_write): Use it.
273a5f82
PE
7465 * process.c (send_process): Adjust to the new signatures of
7466 emacs_write and emacs_gnutls_write. Do not attempt to store
7467 a byte offset into an 'int'; it might overflow.
9587a89d 7468 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7469
3e047f51
PE
7470 * sound.c: Don't assume sizes fit in 'int'.
7471 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7472 Return EMACS_INT, not int.
3e047f51 7473 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7474 Accept EMACS_INT, not int.
7475 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7476 record read return values.
7477
cc39a9db
BK
74782011-04-15 Ben Key <bkey76@gmail.com>
7479
c9d0ec6d
JB
7480 * keyboard.c (Qundefined): Don't declare static since it is used
7481 in nsfns.m.
7482 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7483 static since they are used in nsfont.m.
cc39a9db 7484
6c60eb9f
SM
74852011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7486
7487 * process.c (Qprocessp): Don't declare static.
7488 * lisp.h (Qprocessp): Declare again.
7489
7990b61a
JB
74902011-04-15 Juanma Barranquero <lekktu@gmail.com>
7491
7492 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7493
5d4cb038
PE
74942011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7495
8bd7b830 7496 Improve C-level modularity by making more things 'static'.
cd64ea1d 7497
e3b27b31
PE
7498 Don't publish debugger-only interfaces to other modules.
7499 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7500 (verify_bytepos, count_markers): Move decls to the only modules
7501 that need them.
7502 * region-cache.h (pp_cache): Likewise.
7503 * window.h (check_all_windows): Likewise.
7504 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7505
5d4cb038
PE
7506 * sysdep.c (croak): Now static, if
7507 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7508 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7509
7510 * alloc.c (refill_memory_reserve): Now static if
7511 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7512 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7513
e87b6180
PE
7514 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7515 Define only if USE_LUCID.
7516
ac64929e
PE
7517 * xrdb.c (x_customization_string, x_rm_string): Now static.
7518
6f37259d
PE
7519 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7520 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7521
1683e3ab
PE
7522 * xdisp.c (draw_row_with_mouse_face): Now static.
7523 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7524
de9c2632
PE
7525 * window.h (check_all_windows): Mark externally visible.
7526
2b96acb7
PE
7527 * window.c (window_deletion_count): Now static.
7528
7529 * undo.c: Make symbols static if they're not exported.
7530 (last_undo_buffer, last_boundary_position, pending_boundary):
7531 Now static.
7532
50436f33
PE
7533 * textprop.c (interval_insert_behind_hooks): Now static.
7534 (interval_insert_in_front_hooks): Likewise.
7535
64520e5c
PE
7536 * term.c: Make symbols static if they're not exported.
7537 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7538 (max_frame_lines, tty_set_terminal_modes):
7539 (tty_reset_terminal_modes, tty_turn_off_highlight):
7540 (get_tty_terminal): Now static.
7541 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7542 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7543 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7544 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7545 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7546
1fa53021
PE
7547 * sysdep.c: Make symbols static if they're not exported.
7548 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7549 Now static.
7550 (sigprocmask_set, full_mask): Remove; unused.
7551 (wait_debugging): Mark as visible.
7552 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7553 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7554
d4b43b22
PE
7555 * syntax.c (syntax_temp): Define only if !__GNUC__.
7556
b7c513d0
PE
7557 * sound.c (current_sound_device, current_sound): Now static.
7558
989b29ad
PE
7559 * search.c (searchbufs, searchbuf_head): Now static.
7560
13a55a78
PE
7561 * scroll.c (scroll_cost): Remove; unused.
7562 * dispextern.h (scroll_cost): Remove decl.
7563
de68a1fc
PE
7564 * region-cache.h (pp_cache): Mark as externally visible.
7565
40ccffa6
PE
7566 * process.c: Make symbols static if they're not exported.
7567 (process_tick, update_tick, create_process, chan_process):
7568 (Vprocess_alist, proc_buffered_char, datagram_access):
7569 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7570 (deactivate_process): Mark defn as static, as well as decl.
7571 * lisp.h (create_process): Remove decl.
7572 * process.h (chan_process, Vprocess_alist): Remove decls.
7573
ad64fc97
PE
7574 * print.c: Make symbols static if they're not exported.
7575 (print_depth, new_backquote_output, being_printed, print_buffer):
7576 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7577 (print_interval, print_number_index, initial_stderr_stream):
7578 Now static.
7579 * lisp.h (Fprinc): Remove decl.
7580 (debug_output_compilation_hack): Mark as externally visible.
7581
adddb265
PE
7582 * sysdep.c (croak): Move decl from here to syssignal.h.
7583 * syssignal.h (croak): Put it here, so the API can be checked when
7584 'croak' is called from dissociate_if_controlling_tty.
7585
1717ede2
PE
7586 * minibuf.c: Make symbols static if they're not exported.
7587 (minibuf_save_list, choose_minibuf_frame): Now static.
7588 * lisp.h (choose_minibuf_frame): Remove decl.
7589
fa5fb2bc
PE
7590 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7591
1e3890d1
PE
7592 * lread.c: Make symbols static if they're not exported.
7593 (read_objects, initial_obarray, oblookup_last_bucket_number):
7594 Now static.
7595 (make_symbol): Remove; unused.
7596 * lisp.h (initial_obarray, make_symbol): Remove decls.
7597
8a1414fa
PE
7598 * keyboard.c: Make symbols static if they're not exported.
7599 (single_kboard, recent_keys_index, total_keys, recent_keys):
7600 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7601 (this_single_command_key_start, echoing, last_auto_save):
7602 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7603 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7604 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7605 (Vlispy_mouse_stem, double_click_count):
7606 Now static.
7607 (force_auto_save_soon): Define only if SIGDANGER.
7608 (ignore_mouse_drag_p): Now static if
7609 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7610 (print_help): Remove; unused.
7611 (stop_character, last_timer_event): Mark as externally visible.
7612 * keyboard.h (ignore_mouse_drag_p): Declare only if
7613 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7614 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7615 * lisp.h (echoing): Remove decl.
7616 (force_auto_save_soon): Declare only if SIGDANGER.
7617 * xdisp.c (redisplay_window): Simplify code, to make it more
7618 obvious that ignore_mouse_drag_p is not accessed if !defined
7619 USE_GTK && !defined HAVE_NS.
7620
93ea6e8f
PE
7621 * intervals.c: Make symbols static if they're not exported.
7622 (merge_properties_sticky, merge_interval_right, delete_interval):
7623 Now static.
7624 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7625
77382fcc
PE
7626 * insdel.c: Make symbols static if they're not exported.
7627 However, leave prepare_to_modify_buffer alone. It's never
7628 called from outside this function, but that appears to be a bug.
7629 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7630 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7631 (adjust_after_replace_noundo): Remove; unused.
7632 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7633 (signal_before_change): Remove decls.
77382fcc 7634
9306c32e
PE
7635 * indent.c (val_compute_motion, val_vmotion): Now static.
7636
cd44d2eb
PE
7637 * image.c: Make symbols static if they're not exported.
7638 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7639 if USE_GTK.
7640 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7641 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7642
ad9a7a06
PE
7643 * fringe.c (standard_bitmaps): Now static.
7644 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7645
81626931
PE
7646 * frame.c: Make symbols static if they're not exported.
7647 (x_report_frame_params, make_terminal_frame): Now static.
7648 (get_frame_param): Now static, unless HAVE_NS.
7649 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7650 (x_get_resource_string): Remove; not used.
7651 * frame.h (make_terminal_frame, x_report_frame_params):
7652 (x_get_resource_string); Remove decls.
7653 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7654 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7655
239f9db9
PE
7656 * font.c, fontset.c: Make symbols static if they're not exported.
7657 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7658 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7659 * font.c (font_close_object): Now static.
7660 * font.h (font_close_object): Remove.
7661 * fontset.c (FONTSET_OBJLIST): Remove.
7662 (free_realized_fontset) #if-0 the body, which does nothing.
7663 (face_suitable_for_char_p): #if-0, as it's never called.
7664 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7665 * xfaces.c (face_at_string_position):
7666 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7667 since 0 is always ASCII.
7668
dfcf3579
PE
7669 * fns.c (weak_hash_tables): Now static.
7670
5045092b
PE
7671 * fileio.c: Make symbols static if they're not exported.
7672 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7673 (Vwrite_region_annotation_buffers): Now static.
7674
57a96f5c
PE
7675 * eval.c: Make symbols static if they're not exported.
7676 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7677 * lisp.h (backtrace_list): Remove decl.
7678
35f08c38
PE
7679 * emacs.c: Make symbols static if they're not exported.
7680 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7681 (fatal_error_code, fatal_error_signal_hook, standard_args):
7682 Now static.
7683 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7684 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7685 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7686 * lisp.h (fatal_error_signal_hook): Remove decl.
7687 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7688
f44bd759
PE
7689 * editfns.c: Move a (normally-unused) function to its only use.
7690 * editfns.c, lisp.h (get_operating_system_release): Remove.
7691 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7692 worth the hassle of breaking this out.
7693
b532497d
PE
7694 * xterm.c: Make symbols static if they're not exported.
7695 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7696 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7697 (x_destroy_window, x_delete_display):
7698 Now static.
7699 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7700 (x_mouse_leave): Remove; unused.
7701 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7702 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7703 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7704 Remove decls.
7705 (x_mouse_leave): Declare only if WINDOWSNT.
7706 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7707 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7708 USE_X_TOOLKIT.
7709
1675728f
PE
7710 * ftxfont.c: Make symbols static if they're not exported.
7711 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7712 HAVE_FREETYPE.
7713 * font.h (ftxfont_driver): Likewise.
7714
e4cebfca
PE
7715 * xfns.c: Make symbols static if they're not exported.
7716 (x_last_font_name, x_display_info_for_name):
7717 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7718 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7719 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7720 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7721 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7722 (last_show_tip_args): Now static.
7723 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7724 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7725 (x_screen_planes): Remove; unused.
7726 * dispextern.h (x_screen_planes): Remove decl.
7727
5bf46f05
PE
7728 * dispnew.c: Make symbols static if they're not exported.
7729 * dispextern.h (redraw_garbaged_frames, scrolling):
7730 (increment_row_positions): Remove.
7731 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7732 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7733 Now static.
7734 (redraw_garbaged_frames): Remove; unused.
7735
435f4c28
PE
7736 * xfaces.c: Make symbols static if they're not exported.
7737 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7738 Remove decls.
7739 * xterm.h (defined_color): Remove decls.
7740 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7741 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7742 (menu_face_changed_default, defined_color, free_realized_face):
7743 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7744 (ascii_face_of_lisp_face): Remove; unused.
7745
8524aef3
PE
7746 * xdisp.c: Make symbols static if they're not exported.
7747 * dispextern.h (scratch_glyph_row, window_box_edges):
7748 (glyph_to_pixel_coords, set_cursor_from_row):
7749 (get_next_display_element, set_iterator_to_next):
7750 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7751 (show_mouse_face): Remove decls
7752 * frame.h (message_buf_print): Likewise.
7753 * lisp.h (pop_message, set_message, check_point_in_composition):
7754 Likewise.
7755 * xterm.h (set_vertical_scroll_bar): Likewise.
7756 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7757 (message_buf_print, scratch_glyph_row, displayed_buffer):
7758 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7759 (get_next_display_element, show_mouse_face, window_box_edges):
7760 (frame_to_window_pixel_xy, check_point_in_composition):
7761 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7762 (glyph_to_pixel_coords): Remove; unused.
7763
16390cd2
PE
7764 * dired.c (file_name_completion): Now static.
7765
7766 * dbusbind.c (xd_in_read_queued_messages): Now static.
7767
a25f4dfa
PE
7768 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7769 * data.c (circular_list_error): Remove.
7770
14a9c8df
PE
7771 * commands.h (last_point_position, last_point_position_buffer):
7772 (last_point_position_window): Remove decls.
7773 * keyboard.c: Make these variables static.
7774
04f2d78b
CB
7775 * coding.h (coding, code_convert_region, encode_coding_gap):
7776 Remove decls.
74ab6df5
PE
7777 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7778 (iso_code_class, detect_coding, code_convert_region): Now static.
7779 (encode_coding_gap): Remove; unused.
7780
38dfbee1
PE
7781 * chartab.c (chartab_chars, chartab_bits): Now static.
7782
a2cb4e63
PE
7783 * charset.h (charset_iso_8859_1): Remove decl.
7784 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7785 Now static.
7786
127198fd
PE
7787 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7788 * ccl.c (Vccl_program_table): Now static.
7789 (check_ccl_update): Remove; unused.
7790
d85b608f
PE
7791 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7792 * category.h: ... from here.
7793 * category.c (check_category_table, set_category_set): Now static.
7794
31cd66f3
PE
7795 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7796 * lisp.h: Remove these decls.
7797
c358e587
PE
7798 * buffer.c (buffer_count): Remove unused var.
7799
e78aecca
PE
7800 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7801 so that it's not optimized away.
7802 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7803 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7804 exported only to the debugger.
7805
e192d7d3 7806 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7807 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7808
92470028
PE
7809 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7810 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7811 was inaccessible from Lisp.
7812 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7813 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7814
244ed907
PE
7815 alloc.c: Import and export fewer symbols, and remove unused items.
7816 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7817 is defined.
7818 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7819 it's not optimized away by whole-program optimization.
7820 (message_enable_multibyte, free_misc): Remove.
7821 (catchlist, handlerlist, mark_backtrace):
7822 Declare only if BYTE_MARK_STACK.
7823 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7824 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7825 (message_enable_multibyte): Remove decl.
7826 (free_misc, interval_free_list, float_block, float_block_index):
7827 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7828 (cons_free_list, last_marked_index):
7829 Now static.
7830 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7831 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7832 (mark_backtrace): Define only if BYTE_MARK_STACK.
7833 * xdisp.c (message_enable_multibyte): Now static.
7834
61c2b50e 7835 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7836 This makes it easier for human readers (and static analyzers)
7837 to see whether these variables are used from other modules.
7838 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7839 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7840 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7841 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7842 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7843 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7844 * xmenu.c, xselect.c:
7845 Declare Q* vars static if they are not used in other modules.
7846 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7847 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7848 Remove decls of unexported vars.
7849 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7850
95c82688
PE
7851 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7852
16a97296
PE
7853 Make Emacs functions such as Fatom 'static' by default.
7854 This makes it easier for human readers (and static analyzers)
7855 to see whether these functions can be called from other modules.
7856 DEFUN now defines a static function. To make the function external
7857 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7858 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7859 (Finit_image_library):
16a97296
PE
7860 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7861 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7862 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7863 Remove decls, since these functions are now static.
7864 (Funintern, Fget_internal_run_time): New decls, since these functions
7865 were already external.
95c82688 7866
16a97296
PE
7867 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7868 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7869 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7870 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7871 * keyboard.c, keymap.c, lread.c:
7872 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7873 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7874 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7875 Mark functions with DEFUE instead of DEFUN,
7876 if they are used in other modules.
7877 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7878 decls for now-static functions.
7879 * buffer.h (Fdelete_overlay): Remove decl.
7880 * callproc.c (Fgetenv_internal): Mark as internal.
7881 * composite.c (Fremove_list_of_text_properties): Remove decl.
7882 (Fcomposition_get_gstring): New forward static decl.
7883 * composite.h (Fcomposite_get_gstring): Remove decl.
7884 * dired.c (Ffile_attributes): New forward static decl.
7885 * doc.c (Fdocumntation_property): New forward static decl.
7886 * eval.c (Ffetch_bytecode): New forward static decl.
7887 (Funintern): Remove extern decl; now in .h file where it belongs.
7888 * fileio.c (Fmake_symbolic_link): New forward static decl.
7889 * image.c (Finit_image_library): New forward static decl.
7890 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7891 * intervals.h (Fprevious_property_change):
7892 (Fremove_list_of_text_properties): Remove decls.
7893 * keyboard.c (Fthis_command_keys): Remove decl.
7894 (Fcommand_execute): New forward static decl.
7895 * keymap.c (Flookup_key): New forward static decl.
7896 (Fcopy_keymap): Now static.
7897 * keymap.h (Flookup_key): Remove decl.
7898 * process.c (Fget_process): New forward static decl.
7899 (Fprocess_datagram_address): Mark as internal.
7900 * syntax.c (Fsyntax_table_p): New forward static decl.
7901 (skip_chars): Remove duplicate decl.
7902 * textprop.c (Fprevious_property_change): New forward static decl.
7903 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7904 Now internal.
7905 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7906 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7907
785bbd42
PE
7908 * editfns.c (Fformat): Remove unreachable code.
7909
8b913b57
AS
79102011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7911
7912 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7913 change. (Bug#8496)
7914
a6744a35
EZ
79152011-04-13 Eli Zaretskii <eliz@gnu.org>
7916
7917 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7918 when at ZV. (Bug#8487)
7919
e7974947
AS
79202011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7921
baad03f0
AS
7922 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7923 (Bug#8437)
7924 * keyboard.c (parse_tool_bar_item): Likewise.
7925 * sound.c (sound_cleanup, alsa_close): Likewise.
7926 * termcap.c (tgetent): Likewise.
7927 * xfns.c (x_default_font_parameter): Likewise.
7928 * xsettings.c (read_and_apply_settings): Likewise.
7929
e7974947
AS
7930 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7931 (overrun_check_free): Protoize.
7932
28272684
PE
79332011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7934
7935 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7936 since callers should never pass a negative size.
7937 Change the signature to match that of plain 'read' and 'write'; see
7938 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7939 * lisp.h: Update prototypes of emacs_write and emacs_read.
7940
11997c76
EZ
79412011-04-11 Eli Zaretskii <eliz@gnu.org>
7942
7943 * xdisp.c (redisplay_window): Don't try to determine the character
7944 position of the scroll margin if the window start point w->startp
e896f03c 7945 is outside the buffer's accessible region. (Bug#8468)
11997c76 7946
8a2cbd72
EZ
79472011-04-10 Eli Zaretskii <eliz@gnu.org>
7948
7949 Fix write-region and its subroutines for buffers > 2GB.
7950 * fileio.c (a_write, e_write): Modify declaration of arguments and
7951 local variables to support buffers larger than 2GB.
7952 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7953
7954 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7955 argument, local variables, and return value.
7956
7957 * lisp.h: Update prototypes of emacs_write and emacs_read.
7958
7959 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7960
4073e537 79612011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7962
1ebfdcb6
PE
7963 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7964
b2ded58d
PE
7965 Fix more problems found by GCC 4.6.0's static checks.
7966
7d66342c
PE
7967 * xdisp.c (vmessage): Use a better test for character truncation.
7968
bbf47d44
PE
7969 * charset.c (load_charset_map): <, not <=, for optimization,
7970 and to avoid potential problems with integer overflow.
9248994d 7971 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7972 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7973 * editfns.c (Fformat): Likewise.
1e69125e 7974 * syntax.c (skip_chars): Likewise.
3befa583 7975
e3019616
PE
7976 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7977 This also lets GCC 4.6.0 generate slightly better loop code.
7978
becfa255
PE
7979 * callint.c (Fcall_interactively): <, not <=, for optimization.
7980 (Fcall_interactively): Count the number of arguments produced,
7981 not the number of arguments given. This is simpler and lets GCC
7982 4.6.0 generate slightly better code.
7983
dae0cd48
PE
7984 * ftfont.c: Distingish more carefully between FcChar8 and char.
7985 The previous code passed unsigned char * to a functions like
7986 strlen and xstrcasecmp that expect char *, which does not
7987 conform to the C standard.
7988 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7989 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7990 char * when the C standard requires it.
7991
76032d70
PE
7992 * keyboard.c (read_char): Remove unused var.
7993
eb3f1cc8
PE
7994 * eval.c: Port to Windows vsnprintf (Bug#8435).
7995 Include <limits.h>.
7996 (SIZE_MAX): Define if the headers do not.
7997 (verror): Do not give up if vsnprintf returns a negative count.
7998 Instead, grow the buffer. This ports to Windows vsnprintf, which
7999 does not conform to C99. Problem reported by Eli Zaretskii.
8000 Also, simplify the allocation scheme, by avoiding the need for
8001 calling realloc, and removing the ALLOCATED variable.
8002
70476b54
PE
8003 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8004
12020a9e
PE
8005 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8006 But keep the doprint source code for now, as we might revamp it
8007 and use it again (Bug#8435).
ea6c7ae6
PE
8008 * lisp.h (doprnt): Remove.
8009 * Makefile.in (base_obj): Remove doprnt.o.
8010 * deps.mk (doprnt.o): Remove.
8011
5fdb398c
PE
8012 error: Print 32- and 64-bit integers portably (Bug#8435).
8013 Without this change, on typical 64-bit hosts error ("...%d...", N)
8014 was used to print both 32- and 64-bit integers N, which relied on
8015 undefined behavior.
61bdb816 8016 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8017 * lisp.h (error, verror): Mark as printf-like functions.
8018 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8019 Report overflow in size calculations when allocating printf buffer.
8020 Do not truncate output string at its first null byte.
8021 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8022 Truncate the output at a character boundary, since vsnprintf does not
8023 do that.
8024 * charset.c (check_iso_charset_parameter): Convert internal
8025 character to string before calling 'error', since %c now has the
8026 printf meaning.
8027 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8028 overflow when computing char to be passed to 'error'. Do not
8029 pass Lisp_Object to 'error'; pass the integer instead.
8030 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8031 formatted with plain %d.
8032
b189fa66
PE
8033 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8034
bff87ef0
PE
8035 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8036
7e2cac20
PE
8037 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8038
ce4d90b5
PE
8039 * xterm.c (x_catch_errors): Remove duplicate declaration.
8040
266c9547
PE
8041 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8042
79c49ad2
PE
8043 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8044
368f4090
JM
80452011-04-10 Jim Meyering <meyering@redhat.com>
8046
8047 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8048 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8049 return ssize_t not "int", and use size_t as the buffer length.
8050 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8051 * gnutls.h: Update declarations.
8052 * process.c (read_process_output): Use ssize_t, to match.
8053 (send_process): Likewise.
8054
a32d4040
CY
80552011-04-09 Chong Yidong <cyd@stupidchicken.com>
8056
8057 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8058
8546720e 80592011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8060
04f2d78b
CB
8061 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8062 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8063
8546720e
GM
8064 * xterm.c (handle_one_xevent):
8065 * xmenu.c (create_and_show_popup_menu):
8066 * xselect.c (x_decline_selection_request)
8067 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8068
0a2f5c1a 80692011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8070
8071 Fix some uses of `int' instead of EMACS_INT.
8072 * search.c (string_match_1, fast_string_match)
8073 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8074 (scan_buffer, find_next_newline_no_quit)
8075 (find_before_next_newline, search_command, Freplace_match)
8076 (Fmatch_data): Make some `int' variables be EMACS_INT.
8077
8078 * xdisp.c (display_count_lines): 3rd argument and return value now
8079 EMACS_INT. All callers changed.
8080 (pint2hrstr): Last argument is now EMACS_INT.
8081
8082 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8083 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8084 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8085 (decode_coding_utf_16, decode_coding_emacs_mule)
8086 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8087 (decode_coding_ccl, decode_coding_charset)
8088 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8089 (decode_coding_iso_2022, decode_coding_emacs_mule)
8090 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8091 <char_offset, last_offset>: Declare EMACS_INT.
8092 (encode_coding_utf_8, encode_coding_utf_16)
8093 (encode_coding_emacs_mule, encode_invocation_designation)
8094 (encode_designation_at_bol, encode_coding_iso_2022)
8095 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8096 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8097 Declare EMACS_INT.
8098 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8099 (encode_invocation_designation): Last argument P_NCHARS is now
8100 EMACS_INT.
8101 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8102 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8103
8104 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8105 All users changed.
8106
8107 * ccl.c (Fccl_execute_on_string): Declare some variables
8108 EMACS_INT.
8109
8546720e 81102011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8111
8112 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8113
4e19a977
CS
81142011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8115
8116 * process.c (Fformat_network_address): Doc fix.
8117
87302331
R
81182011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8119
ee7683eb 8120 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8121
cbb59342
CY
81222011-04-08 Chong Yidong <cyd@stupidchicken.com>
8123
8124 * keyboard.c (read_char): Call Lisp function help-form-show,
8125 instead of using internal_with_output_to_temp_buffer.
8126 (Qhelp_form_show): New var.
e0d38eeb 8127 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8128
8129 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8130
8131 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8132
e67a13ab
CY
81332011-04-06 Chong Yidong <cyd@stupidchicken.com>
8134
04f2d78b
CB
8135 * process.c (Flist_processes): Remove to Lisp.
8136 (list_processes_1): Delete.
e67a13ab 8137
973f782d
EZ
81382011-04-06 Eli Zaretskii <eliz@gnu.org>
8139
7c106b1e
EZ
8140 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8141
973f782d
EZ
8142 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8143
41cf7d1a 81442011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8145
ca23cc88
PE
8146 Fix more problems found by GCC 4.6.0's static checks.
8147
f390e2d5
PE
8148 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8149
42eea0d0
PE
8150 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8151
b69769da 8152 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8153
f9541e84
PE
8154 * xdisp.c (vmessage): Mark as a printf-like function.
8155
13841b55
PE
8156 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8157
c136c10f
PE
8158 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8159
5e2d4a30
PE
8160 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8161 printf-like functions.
8162 (tiff_load): Add casts to remove these marks before passing them
8163 to system-supplied API.
8164
583f48b9
PE
8165 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8166
b25d760e
PE
8167 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8168 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8169 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8170 directly, rather than having caller test rule sign. This avoids
8171 some unnecessary tests.
8172 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8173 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8174 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8175
bc7b6697 8176 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8177 (xfont_open): Avoid unnecessary tests.
bc7b6697 8178
27ccc379
PE
8179 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8180
dcd5c89a
PE
8181 * composite.h, composite.c (composition_gstring_put_cache):
8182 Use EMACS_INT, not int, for length.
8183
b13a45c6
PE
8184 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8185 breaking out part of COMPOSITION_DECODE_RULE.
8186 (COMPOSITION_DECODE_RULE): Use it.
8187 * composite.c (get_composition_id): Remove unused local vars,
8188 by using the new macro.
8189
1e792e4d
PE
8190 * textprop.c (set_text_properties_1): Change while to do-while,
8191 since the condition is always true at first.
8192
dc6c6455 8193 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8194 (interval_deletion_adjustment): Return unsigned value.
8195 All uses changed.
dc6c6455 8196
aba7731a
PE
8197 * process.c (list_processes_1, create_pty, read_process_output):
8198 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8199 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8200 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8201 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8202 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8203
fdfc4bf3
PE
8204 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8205
fca8fe46 8206 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8207 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8208
06a0259a 8209 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8210 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8211 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8212
e7b9e80f
PE
8213 * print.c (print_error_message): Avoid int overflow.
8214
56201685
PE
8215 * font.c (font_list_entities): Redo for clarity,
8216 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8217
78834453 8218 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8219 (font_score): Avoid potential overflow in diff calculation.
78834453 8220
0bc0b309 8221 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8222 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8223
e610eaca
PE
8224 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8225
b895abce
PE
8226 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8227 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8228 can always succeed if overflow has undefined behavior.
8229
1f1d9321 8230 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8231 (wordify): Omit three unnecessary tests.
1f1d9321 8232
c59478bc
PE
8233 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8234 All callers changed. This avoids the need for an unused var.
8235
79b73827
PE
8236 * casefiddle.c (casify_region): Remove var that is set but not used.
8237
a4db5dfe
PE
8238 * dired.c (file_name_completion): Remove var that is set but not used.
8239
43aae36e
PE
8240 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8241
2a47c44d 8242 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8243 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8244
a37c69bf
PE
8245 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8246 Check for integer overflow on size calculations.
8247
328ab8e7
PE
8248 * buffer.c (Fprevious_overlay_change): Remove var that is set
8249 but not used.
8250
e5a2a5cb
PE
8251 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8252 Remove vars that are set but not used.
8d84a6eb 8253 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8254 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8255
a60e5f68
PE
8256 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8257
f661cb61 8258 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8259 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8260
f0397f5a
PE
8261 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8262 that are set but not used.
8263
8664db06 8264 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8265 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8266
6abdaa4a
PE
8267 * xselect.c (x_get_local_selection, x_handle_property_notify):
8268 Remove vars that are set but not used.
8269
0ce7538d 8270 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8271 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8272
9ae848fc
PE
8273 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8274 Remove var that is set but not used.
0b918413
PE
8275 (scroll_bar_windows_size): Now size_t, not int.
8276 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8277 Check for overflow.
9ae848fc 8278
a5a62657
PE
8279 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8280 (map_tty_color) [!defined MSDOS]: Likewise.
8281
5c5cdd39
PE
8282 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8283
66ebf983
PE
8284 * coding.c: Remove vars that are set but not used.
8285 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8286 All callers changed.
8287 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8288 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8289 (decode_coding_charset): Remove vars that are set but not used.
8290
1be4d761
PE
8291 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8292 that is set but not used.
8293
47553fa8
PE
8294 * print.c (print_object): Remove var that is set but not used.
8295
1f7196bf 8296 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8297 The gnulib version avoids calling malloc in the usual case,
8298 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8299 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8300 * filelock.c (current_lock_owner): Likewise.
8301 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8302 * sysdep.c: Include allocator.h, careadlinkat.h.
8303 (emacs_no_realloc_allocator): New static constant.
8304 (emacs_readlink): New function.
fdb61804
PE
8305 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8306 ../lib/careadlinkat.h.
d1fdcab7 8307
f84c17c7
SM
83082011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8309
8310 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8311 first non-nil return value).
8312
ef3862ad
JD
83132011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8314
8315 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8316 if not defined (Bug#8403).
8317
376a7006
JB
83182011-04-02 Juanma Barranquero <lekktu@gmail.com>
8319
8320 * xdisp.c (display_count_lines): Remove parameter `start',
8321 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8322 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8323 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8324 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8325 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8326 and thereabouts. All callers changed.
8327 (get_per_char_metric): Remove parameter `f', unused since
8328 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8329
6ca3801d
JM
83302011-04-02 Jim Meyering <meyering@redhat.com>
8331
8332 do not dereference NULL upon failed strdup
8333 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8334 (ns_get_family): Likewise.
8335
d8e2b5ba
JB
83362011-04-02 Juanma Barranquero <lekktu@gmail.com>
8337
8338 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8339
8c74fcbd
JD
83402011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8341
8342 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8343 later (Bug#8403).
8344
7200d79c
SM
83452011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8346
03408648 8347 Add lexical binding.
7200d79c 8348
03408648
SM
8349 * window.c (Ftemp_output_buffer_show): New fun.
8350 (Fsave_window_excursion):
8351 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8352
8353 * lread.c (lisp_file_lexically_bound_p): New function.
8354 (Fload): Bind Qlexical_binding.
8355 (readevalloop): Remove `evalfun' arg.
8356 Bind Qinternal_interpreter_environment.
8357 (Feval_buffer): Bind Qlexical_binding.
8358 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8359 Mark as dynamic.
8360 (syms_of_lread): Declare `lexical-binding'.
8361
8362 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8363
8364 * keyboard.c (eval_dyn): New fun.
8365 (menu_item_eval_property): Use it.
ca105506
SM
8366
8367 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8368
03408648
SM
8369 * fns.c (concat, mapcar1): Accept byte-code-functions.
8370
8371 * eval.c (Fsetq): Handle lexical vars.
8372 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8373 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8374 (FletX, Flet): Obey lexical binding.
8375 (Fcommandp): Handle closures.
8376 (Feval): New `lexical' arg.
8377 (eval_sub): New function extracted from Feval. Use it almost
8378 everywhere where Feval was used. Look up vars in lexical env.
8379 Handle closures.
8380 (Ffunctionp): Move from subr.el.
8381 (Ffuncall): Handle closures.
8382 (apply_lambda): Remove `eval_flags'.
8383 (funcall_lambda): Handle closures and new byte-code-functions.
8384 (Fspecial_variable_p): New function.
8385 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8386 but without exporting it to Lisp.
23aba0ea 8387
23aba0ea 8388 * doc.c (Fdocumentation, store_function_docstring):
03408648 8389 * data.c (Finteractive_form): Handle closures.
23aba0ea 8390
03408648
SM
8391 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8392 interactive spec.
ba83908c 8393
04f2d78b
CB
8394 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8395 New byte-codes.
03408648
SM
8396 (exec_byte_code): New function extracted from Fbyte_code to handle new
8397 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8398
03408648 8399 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8400
03408648 8401 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8402
e2abce01
JB
84032011-03-31 Juanma Barranquero <lekktu@gmail.com>
8404
8405 * xdisp.c (redisplay_internal): Fix prototype.
8406
63696a73 84072011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8408
63696a73 8409 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8410 (try_scrolling): Use it when setting scroll_limit.
8411 Limit scrolling to 100 screen lines.
63696a73
EZ
8412 (redisplay_window): Even when falling back on "recentering",
8413 position point in the window according to scroll-conservatively,
8414 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8415
8416 (try_scrolling): When point is above the window, allow searching
8417 as far as scroll_max, or one screenful, to compute vertical
8418 distance from PT to the scroll margin position. This prevents
8419 try_scrolling from unnecessarily failing when
8420 scroll-conservatively is set to a value slightly larger than the
8421 window height. Clean up the case of PT below the margin at bottom
8422 of window: scroll_max can no longer be INT_MAX. When aggressive
8423 scrolling is in use, don't let point enter the opposite scroll
8424 margin as result of the scroll.
8425 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8426 threshold of 100 lines for never-recentering scrolling.
8427
e4cc2dfc
JB
84282011-03-31 Juanma Barranquero <lekktu@gmail.com>
8429
8430 * dispextern.h (move_it_by_lines):
8431 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8432 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8433 (message_log_check_duplicate): Remove parameters `prev_bol' and
8434 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8435 (redisplay_internal): Remove parameter `preserve_echo_area',
8436 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8437
8438 * indent.c (Fvertical_motion):
8439 * window.c (window_scroll_pixel_based, Frecenter):
8440 Don't pass `need_y_p' to `move_it_by_lines'.
8441
1c470562
SM
84422011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8443
44f230aa
SM
8444 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8445 steal a few bits to be more compact.
8446 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8447 Remove unneeded casts.
8448
1c470562
SM
8449 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8450
888adce9
ZK
84512011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8452
8453 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8454 binding" message (bug#7967).
8455
f838ed7b
PE
84562011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8457
77861b95
PE
8458 Fix more problems found by GCC 4.6.0's static checks.
8459
de6dbc14
PE
8460 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8461 Remove unused local var.
8462
f838ed7b
PE
8463 * editfns.c (Fmessage_box): Remove unused local var.
8464
792c7b2b
PE
8465 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8466 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8467 Omit unused local vars.
c499e557 8468 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8469 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8470 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8471 Omit unused local var.
8472
ba0165e1
PE
8473 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8474 Don't assume string length fits in int.
32ad8845 8475 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8476 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8477
3c59b4c9
PE
8478 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8479 instead of alloca (Bug#8344).
8480
a3eed478 8481 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8482 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8483
eb4d412d
PE
8484 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8485
1658b401
PE
8486 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8487 concerns.
8488
8489 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8490
8491 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8492
9a2c6e05
PE
8493 * keyboard.c (syms_of_keyboard): Use the same style as later
8494 in this function when indexing through an array. This also
8495 works around GCC bug 48267.
8496
03d0a109
PE
8497 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8498
44f730c8
PE
8499 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8500
fe75f926
PE
8501 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8502 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8503
ffa8c828
PE
8504 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8505 This avoids undefined behavior on integer overflow, and is a bit
8506 more convenient anyway since it is compared to a size_t variable.
8507
c5101a77
PE
8508 Variadic C functions now count arguments with size_t, not int.
8509 This avoids an unnecessary limitation on 64-bit machines, which
8510 caused (substring ...) to crash on large vectors (Bug#8344).
8511 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8512 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8513 All variadic functions and their callers changed accordingly.
c5101a77
PE
8514 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8515 * data.c (arith_driver, float_arith_driver): Likewise.
8516 * editfns.c (general_insert_function): Likewise.
8517 * eval.c (struct backtrace.nargs, interactive_p)
8518 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8519 (funcall_lambda, mark_backtrace): Likewise.
8520 * fns.c (concat): Likewise.
8521 * frame.c (x_set_frame_parameters): Likewise.
8522 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8523 0 if not found, not -1. All callers changed.
8524
dd3f25f7
PE
8525 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8526 (stack_copy_size): Now size_t, not int.
8527 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8528
461c2ab9
JB
85292011-03-28 Juanma Barranquero <lekktu@gmail.com>
8530
8531 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8532 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8533 All callers changed.
8534
8535 * lisp.h (multibyte_char_to_unibyte):
8536 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8537 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8538 * character.h (CHAR_TO_BYTE8):
8539 * cmds.c (internal_self_insert):
8540 * editfns.c (general_insert_function):
8541 * keymap.c (push_key_description):
8542 * search.c (Freplace_match):
8543 * xdisp.c (message_dolog, set_message_1): All callers changed.
8544
f6d62986
SM
85452011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8546
8547 * keyboard.c (safe_run_hook_funcall): New function.
8548 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8549 don't set the hook to nil, but remove the offending function instead.
8550 (Qcommand_hook_internal): Remove, unused.
8551 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8552 Vcommand_hook_internal.
8553
8554 * eval.c (enum run_hooks_condition): Remove.
8555 (funcall_nil, funcall_not): New functions.
8556 (run_hook_with_args): Call each function through a `funcall' argument.
8557 Remove `cond' argument, now redundant.
8558 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8559 (Frun_hook_with_args_until_failure): Adjust accordingly.
8560 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8561
1db5b1ad
JB
85622011-03-28 Juanma Barranquero <lekktu@gmail.com>
8563
8564 * dispextern.h (string_buffer_position): Remove declaration.
8565
8566 * print.c (strout): Remove parameter `multibyte', unused since
8567 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8568
8569 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8570 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8571 All callers changed.
8572
8573 * w32.c (_wsa_errlist): Use braces for struct initializers.
8574
8575 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8576 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8577 All callers changed.
8578 (string_buffer_position): Likewise. Also, make static (it's never
8579 used outside xdisp.c).
8580 (cursor_row_p): Remove parameter `w', unused since
8581 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8582 (decode_mode_spec): Remove parameter `precision', introduced during
8583 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8584 All callers changed.
8585
5ffb62aa
JD
85862011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8587
8588 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8589
461c2ab9 85902011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8591
8592 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8593 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8594 (ns_update_auto_hide_menu_bar): New functions.
8595 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8596 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8597 ns_constrain_all_frames.
8598 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8599 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8600
5c380ffb
JD
86012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8602
8603 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8604
9af30bdf
GM
86052011-03-27 Glenn Morris <rgm@gnu.org>
8606
8607 * syssignal.h: Replace RETSIGTYPE with void.
8608 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8609 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8610 Replace SIGTYPE with void everywhere.
8611 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8612 * s/template.h (SIGTYPE): Remove commented out definition.
8613
e2abce01
JB
86142011-03-26 Eli Zaretskii <eliz@gnu.org>
8615
8616 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8617 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8618
f868cd8a
JB
86192011-03-26 Juanma Barranquero <lekktu@gmail.com>
8620
59eb0929
JB
8621 * w32.c (read_unc_volume): Use parameter `henum', instead of
8622 global variable `wget_enum_handle'.
8623
8624 * keymap.c (describe_vector): Remove parameters `indices' and
8625 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8626 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8627
f868cd8a
JB
8628 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8629
8630 * keyboard.c (timer_check): Remove parameter `do_it_now',
8631 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8632 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8633 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8634
8635 * keyboard.c (read_char):
8636 * w32menu.c (w32_menu_display_help):
8637 * xmenu.c (show_help_event, menu_help_callback):
8638 Adjust calls to `show_help_echo'.
8639
8640 * gtkutil.c (xg_maybe_add_timer):
8641 * keyboard.c (readable_events):
8642 * process.c (wait_reading_process_output):
8643 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8644
8645 * insdel.c (adjust_markers_gap_motion):
8646 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8647 (gap_left, gap_right): Don't call it.
8648
2ecf6fdb
CY
86492011-03-25 Chong Yidong <cyd@stupidchicken.com>
8650
8651 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8652 incurred during fontification.
8653
6b1f9ba4
JB
86542011-03-25 Juanma Barranquero <lekktu@gmail.com>
8655
8656 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8657 (DEFVAR_PER_BUFFER): Don't pass it.
8658
8659 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8660 (scrolling_window): Don't pass it.
8661
0f4a96b5
JB
86622011-03-25 Juanma Barranquero <lekktu@gmail.com>
8663
8664 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8665
8666 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8667 and `suffix'.
8668 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8669 of variables specific to SELinux and computation of `encoded_absname'.
8670
8671 * image.c (XPutPixel): Remove unused variable `height'.
8672
8673 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8674
8675 * unexw32.c (get_section_info): Remove unused variable `section'.
8676
8677 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8678 (system_process_attributes): Remove unused variable `sess'.
8679 (sys_read): Remove unused variable `err'.
8680
8681 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8682 (w32_wnd_proc): Remove unused variable `isdead'.
8683 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8684 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8685 (x_create_tip_frame): Remove unused variable `tem'.
8686
8687 * w32inevt.c (w32_console_read_socket):
8688 Remove unused variable `no_events'.
8689
8690 * w32term.c (x_draw_composite_glyph_string_foreground):
8691 Remove unused variable `width'.
8692
1149507c
JB
86932011-03-24 Juanma Barranquero <lekktu@gmail.com>
8694
8695 * w32term.c (x_set_glyph_string_clipping):
8696 Don't pass uninitialized region to CombineRgn.
8697
9c88f339
JB
86982011-03-23 Juanma Barranquero <lekktu@gmail.com>
8699
8700 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8701 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8702 (Fx_close_connection): Remove unused variable `i'.
8703
8704 * w32font.c (w32font_draw): Return number of glyphs.
8705 (w32font_open_internal): Remove unused variable `i'.
8706 (w32font_driver): Add missing initializer.
8707
8708 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8709 (fill_in_menu): Remove unused variable `items_added'.
8710
8711 * w32term.c (last_mouse_press_frame): Remove static global variable.
8712 (w32_clip_to_row): Remove unused variable `f'.
8713 (x_delete_terminal): Remove unused variable `i'.
8714
8715 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8716 (NOTHING): Remove unused static global variable.
8717 (uniscribe_check_otf): Remove unused variable `table'.
8718 (uniscribe_font_driver): Add missing initializers.
8719
dee091a3
JD
87202011-03-23 Julien Danjou <julien@danjou.info>
8721
8722 * term.c (Fsuspend_tty, Fresume_tty):
8723 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8724 * window.c (temp_output_buffer_show):
8725 * insdel.c (signal_before_change):
8726 * frame.c (Fhandle_switch_frame):
8727 * fileio.c (Fdo_auto_save):
8728 * emacs.c (Fkill_emacs):
8729 * editfns.c (save_excursion_restore):
8730 * cmds.c (internal_self_insert):
8731 * callint.c (Fcall_interactively):
8732 * buffer.c (Fkill_all_local_variables):
8733 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8734 Use Frun_hooks.
0f4a96b5 8735 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8736 unconditionally since it does the check itself.
dee091a3 8737
2c520ab5 87382011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8739
c9c49752
PE
8740 Fix more problems found by GCC 4.5.2's static checks.
8741
8abc3f12
PE
8742 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8743 the first time through the loop, since we know p0 < p1 then.
8744 This also avoids a gcc -Wstrict-overflow warning.
8745
a2d26660
PE
8746 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8747 leading to a memory leak, possible in functions like
8748 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8749 of objects (Bug#8318).
a2d26660 8750
916c72e9
PE
8751 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8752 that could (at least in theory) be that large.
8753
19ab8a18
PE
8754 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8755 This is less likely to overflow, and avoids undefined behavior if
8756 overflow does occur. All callers changed. Use strtoul to scan
8757 for the unsigned long integer.
b7cbbd6f
PE
8758 (pint2hrstr): Simplify and tune code slightly.
8759 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8760
f0641eff
PE
8761 * scroll.c (do_scrolling): Work around GCC bug 48228.
8762 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8763
7f650bb9
PE
8764 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8765 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8766 (validate_x_resource_name): Simplify count usage.
8767 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8768
37dd57d1
PE
8769 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8770 fail (Bug#8306).
81e56e61 8771
699979fc 8772 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8773
401bf9b4
PE
8774 * process.c (Fmake_network_process): Use socklen_t, not int,
8775 where POSIX says socklen_t is required in portable programs.
8776 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8777 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8778 (Fmake_network_process, server_accept_connection):
8779 (wait_reading_process_output, read_process_output):
8780 Likewise.
8781
b93aacde
PE
8782 * process.c: Rename or move locals to avoid shadowing.
8783 (list_processes_1, Fmake_network_process):
8784 (read_process_output_error_handler, exec_sentinel_error_handler):
8785 Rename or move locals.
4dc343ee 8786 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8787 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8788 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8789 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8790 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8791
af8a867c 8792 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8793 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8794 Include tparam.h instead, since it declares them.
af8a867c
PE
8795 * cm.h (PC): Remove extern decl; tparam.h now does this.
8796 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8797 * terminfo.c: Include tparam.h, to check interfaces.
8798 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8799 (tparam): Adjust signature to match interface in tparam.h;
8800 this removes some undefined behavior. Check that outstring and len
8801 are zero, which they always are with Emacs.
8802 * tparam.h (PC, BC, UP): New extern decls.
8803
0248044d 8804 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8805 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8806
8ff096c1 8807 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8808 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8809 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8810 (ftfont_list): Remove unused local.
49eaafba
PE
8811 (get_adstyle_property, ftfont_pattern_entity):
8812 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8813 Rename locals to avoid shadowing.
8ff096c1 8814
e2be39f6
PE
8815 * xfont.c (xfont_list_family): Mark var as initialized.
8816
c9735e30
PE
8817 * xml.c (make_dom): Now static.
8818
8f5201ae
PE
8819 * composite.c (composition_compute_stop_pos): Rename local to
8820 avoid shadowing.
b246f932
PE
8821 (composition_reseat_it): Remove unused locals.
8822 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8823 (composition_update_it): Mark var as initialized.
11b61122
PE
8824 (find_automatic_composition): Mark vars as initialized,
8825 with a FIXME (Bug#8290).
8f5201ae 8826
760fbc2c
PE
8827 character.h: Rename locals to avoid shadowing.
8828 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8829 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8830 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8831 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8832 to avoid shadowing.
8833
ff08eb85
PE
8834 * textprop.c (property_change_between_p): Remove; unused.
8835
fc7bf025
PE
8836 * intervals.c (interval_start_pos): Now static.
8837
235d7abc
PE
8838 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8839
44f230aa
SM
8840 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8841 Rename locals to avoid shadowing.
3e7d6594 8842
50060332
PE
8843 * sound.c (wav_play, au_play, Fplay_sound_internal):
8844 Fix pointer signedness.
d01f234b 8845 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8846 (wav_play): Initialize a variable to 0, to prevent undefined
8847 behavior (Bug#8278).
50060332 8848
c4fc4e30
PE
8849 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8850
918436ed
PE
8851 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8852
c939f91b
PE
8853 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8854 clobbering (Bug#8298).
b9c7f648
PE
8855 * sysdep.c (sys_subshell): Likewise.
8856 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8857
6bd8c144
PE
8858 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8859 This should get cleaned up, so that child_setup has the
8860 same signature on all platforms.
8861
7710357c 8862 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8863 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8864
c59da222
CY
88652011-03-22 Chong Yidong <cyd@stupidchicken.com>
8866
8867 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8868 not to be necessary, and produces flickering.
8869
66b87493
GM
88702011-03-20 Glenn Morris <rgm@gnu.org>
8871
8872 * config.in: Remove file.
8873
45b6f6d5
JB
88742011-03-20 Juanma Barranquero <lekktu@gmail.com>
8875
8876 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8877 are now in src/globals.h.
8878 (syms_of_minibuf): Remove spurious & from previous change.
8879
cd394be1 88802011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8881
8882 * minibuf.c (completing-read-function): New variable.
8883 (completing-read-default): Rename from completing-read.
8884 (completing-read): Call completing-read-function.
8885
b14e3e21
CY
88862011-03-19 Juanma Barranquero <lekktu@gmail.com>
8887
8888 * xfaces.c (Fx_load_color_file):
8889 Read color file from absolute filename (bug#8250).
8890
f2b726e6
JB
88912011-03-19 Juanma Barranquero <lekktu@gmail.com>
8892
8893 * makefile.w32-in: Update dependencies.
8894
09f6ff02
EZ
88952011-03-17 Eli Zaretskii <eliz@gnu.org>
8896
8897 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8898
29a6015a
PE
88992011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8900
a3a6c54e
PE
8901 Fix more problems found by GCC 4.5.2's static checks.
8902
b766f867
PE
8903 * process.c (make_serial_process_unwind, send_process_trap):
8904 (sigchld_handler): Now static.
8905
be02381c
PE
8906 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8907 That way, the code declares only the vars that it needs.
8908 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8909 * s/cygwin.h (PTY_ITERATION): Likewise.
8910 * s/darwin.h (PTY_ITERATION): Likewise.
8911 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8912
57048744
PE
8913 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8914 * process.c (allocate_pty): Don't declare stb unless it's needed.
8915
7914961c 8916 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8917 (CONSTANTLIM): Remove; unused.
8918 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8919 Define only if needed.
7914961c 8920
b3967b18
PE
8921 * unexelf.c (unexec): Name an expression,
8922 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8923 Use a different way to cause a compilation error if anyone uses
8924 n rather than nn, a way that does not involve shadowing.
73366a00 8925 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8926
29a6015a
PE
8927 * deps.mk (unexalpha.o): Remove; unused.
8928
43cfc33e 8929 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8930 * unexec.h: New file.
ce701a33
PE
8931 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8932 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8933 Depend on unexec.h.
8934 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8935 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8936 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8937 Change as necessary to match prototype in unexec.h.
ce701a33 8938
01f44d5a
PE
8939 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8940 shadowing.
4f63c6bb 8941 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8942
a6670b0b
PE
8943 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8944 Rename locals to avoid shadowing.
8945
cef2010d 8946 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8947 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8948
d4d7173a
PE
8949 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8950
f08b802a
PE
8951 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8952 warning when compiling print.c.
8953
3ddb0639
PE
8954 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8955 instead of using an uninitialized var.
5ad03b97 8956 (font_sort_entities): Mark var as initialized.
3ddb0639 8957
170a2692
PE
8958 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8959
e663c700
PE
8960 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8961 pointers to constants.
89bc529a 8962 (font_parse_fcname): Remove unused vars.
7b81e2d0 8963 (font_delete_unmatched): Now static.
ea838e10 8964 (font_get_spec): Remove; unused.
13a547c6
PE
8965 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8966 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8967 Rename or move locals to avoid shadowing.
e663c700 8968
2a80c887 8969 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8970 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8971
1384fa33 8972 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8973 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8974
8b2c52e9
PE
8975 * alloc.c (mark_backtrace): Move decl from here ...
8976 * lisp.h: ... to here, so that it can be checked.
8977
475545b5 8978 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8979 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8980 (lisp_indirect_variable): Name an expression,
8981 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8982 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8983
b1349114 8984 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8985 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8986 Use const pointer when appropriate.
b1349114 8987
a2928364
PE
8988 * lisp.h (get_system_name, get_operating_system_release):
8989 Move decls here, to check interfaces.
8990 * process.c (get_operating_system_release): Move decl to lisp.h.
8991 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8992 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8993 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8994 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8995 (Fformat_time_string, Fencode_time, Finsert_char):
8996 (Ftranslate_region_internal, Fformat):
8997 Rename or remove local vars to avoid shadowing.
9710023e 8998 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8999
a415e694
PE
9000 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9001 avoid shadowing.
9002
8ef4622d
PE
9003 * lisp.h (eassert): Check that the argument compiles, even if
9004 ENABLE_CHECKING is not defined.
9005
946f9a5b
PE
9006 * data.c (Findirect_variable): Name an expression, to avoid
9007 gcc -Wbad-function-cast warning.
112396d6 9008 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9009 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9010 (Fmake_variable_buffer_local, Fmake_local_variable):
9011 Mark variables as initialized.
52746918 9012 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9013
e5aab7e7 9014 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9015 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9016 Rename locals to avoid shadowing.
dff45157
PE
9017 (mark_stack): Move local variables into the #ifdef region where
9018 they're used.
7bc26fdb
PE
9019 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9020 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9021 needed otherwise.
9022 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9023 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9024 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9025
e5aab7e7
PE
9026 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9027 avoids undefined behavior in theory.
9028
4da60324
PE
9029 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9030
88043301
PE
9031 Use functions, not macros, for up- and down-casing (Bug#8254).
9032 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9033 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9034 to use the following functions instead of these macros.
9035 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9036 EMACS_INT, since callers assume the returned value fits in int.
9037 (upcase1): Likewise, for UPCASE_TABLE.
9038 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9039 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9040 the race-condition problem in the old DOWNCASE.
88043301 9041
19ed5445
PE
9042 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9043 Rename locals to avoid shadowing.
9044 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9045 (regex_compile, re_search_2, re_match_2_internal):
9046 Remove unused local vars.
952db0d7
PE
9047 (FREE_VAR): Rewrite so as not to use empty "else",
9048 which gcc can warn about.
da053e48 9049 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9050 (RETALLOC_IF): Define only if needed.
9051 (WORDCHAR_P): Likewise. This one is never needed, but is used
9052 only in a comment talking about a compiler bug, so put inside
9053 the #if 0 of that comment.
9054 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9055 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9056 Remove; unused.
19ed5445 9057
1f3561e4 9058 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9059 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9060 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9061
ded6f8f7
PE
9062 * search.c (simple_search): Remove unused var.
9063
dbd37a95
PE
9064 * dired.c (compile_pattern): Move decl from here ...
9065 * lisp.h: ... to here, so that it can be checked.
9066 (struct re_registers): New forward decl.
9067
7e47afad
PE
9068 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9069
85f24f61
PE
9070 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9071 All uses changed.
9072 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9073 Rename locals to avoid shadowing.
5671df8f 9074 (Fvertical_motion): Mark locals as initialized.
85f24f61 9075
181aa2be 9076 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9077 (casify_region): Mark local as initialized.
181aa2be 9078
930d429c
PE
9079 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9080
7082eac6
PE
9081 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9082 New macros, so that the caller can use some names other than
9083 gcpro1, gcpro2, etc.
9084 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9085 of the new macros.
9086 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9087 argument, for consistency with GCPRO2_VAR, etc: it is now the
9088 prefix of the variable, not the variable itself. All uses
9089 changed.
38b2c076
PE
9090 * dired.c (directory_files_internal, file_name_completion):
9091 Rename locals to avoid shadowing.
9092
15206ed9
PE
9093 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9094 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9095 dired.c's scmp function, had undefined behavior.
9096 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9097 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9098 * buffer.h: ... to here, because these macros use current_buffer,
9099 and the new implementation with inline functions needs to have
9100 current_buffer in scope now, rather than later when the macros
9101 are used.
9102 (downcase, upcase1): New static inline functions.
9103 (DOWNCASE, UPCASE1): Reimplement using these functions.
9104 This avoids undefined behavior in expressions like
9105 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9106 from race conditions in accessing the global variables
9107 case_temp1 and case_temp2.
9108 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9109 * lisp.h (case_temp1, case_temp2): Remove their decls.
9110 * character.h (ASCII_CHAR_P): Move from here ...
9111 * lisp.h: ... to here, so that the inline functions mentioned
9112 above can use them.
9113
4a6bea26
PE
9114 * dired.c (directory_files_internal_unwind): Now static.
9115
f14b7e14
PE
9116 * fileio.c (file_name_as_directory, directory_file_name):
9117 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9118 Now static.
2893f146
PE
9119 (file_name_as_directory): Use const pointers when appropriate.
9120 (Fexpand_file_name): Likewise. In particular, newdir might
9121 point at constant storage, so make it a const pointer.
fd4ead52 9122 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9123 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9124 signedness issues.
f839df0c
PE
9125 (Fset_file_times, Finsert_file_contents, auto_save_error):
9126 Rename locals to avoid shadowing.
f14b7e14 9127
5716756e 9128 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9129 (Ftry_completion, Fall_completions): Rename or remove locals
9130 to avoid shadowing.
5716756e 9131
b4c3046a
PE
9132 * marker.c (bytepos_to_charpos): Remove; unused.
9133
b45db522
PE
9134 * lisp.h (verify_bytepos, count_markers): New decls,
9135 so that gcc does not warn that these functions aren't declared.
9136
85876d07
PE
9137 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9138 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9139 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9140 (copy_text): Remove unused local var.
85876d07 9141
03d78a21 9142 * filelock.c (within_one_second): Now static.
b3dd38ab 9143 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9144
5df8f01b
PE
9145 * buffer.c (fix_overlays_before): Mark locals as initialized.
9146 (fix_start_end_in_overlays): Likewise. This function should be
9147 simplified by using pointers-to-pointers, but that's a different
9148 matter.
b1d876f1 9149 (switch_to_buffer_1): Now static.
8f54f30a
PE
9150 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9151 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9152
a70072c9 9153 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9154 Fix pointer signedness issue.
edced198
PE
9155 (sys_subshell): Mark local as volatile if checking for lint,
9156 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9157 (MAXPATHLEN): Define only if needed.
a70072c9 9158
a0977c44
PE
9159 * process.c (serial_open, serial_configure): Move decls from here ...
9160 * systty.h: ... to here, so that they can be checked.
9161
a884fdcc
PE
9162 * fns.c (get_random, seed_random): Move extern decls from here ...
9163 * lisp.h: ... to here, so that they can be checked.
9164
604efe86 9165 * sysdep.c (reset_io): Now static.
b8950c94 9166 (wait_for_termination_signal): Remove; unused.
604efe86 9167
38fc62d9
PE
9168 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9169 (copy_keymap_item, append_key, push_text_char_description):
9170 Now static.
1004a21a 9171 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9172 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9173 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9174 (describe_map_tree):
9175 Rename locals to avoid shadowing.
38fc62d9 9176
2f2650da
PE
9177 * keyboard.c: Declare functions static if they are not used elsewhere.
9178 (echo_char, echo_dash, cmd_error, top_level_2):
9179 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9180 (read_char, kbd_buffer_get_event, make_lispy_position):
9181 (make_lispy_event, make_lispy_movement, apply_modifiers):
9182 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9183 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9184 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9185 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9186 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9187
a053e86c 9188 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9189 (mark_kboards): Move decl here ...
9190 * alloc.c (mark_kboards): ... from here.
a053e86c 9191
4752793e
PE
9192 * lisp.h (force_auto_save_soon): New decl.
9193
74f10ca7 9194 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9195 (DEFINE_DUMMY_FUNCTION): New macro.
9196 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9197 Use it.
c03cd23f
PE
9198 (main): Add casts to avoid warnings
9199 if GCC considers string literals to be constants.
74f10ca7 9200
022e70d4
PE
9201 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9202
59d6fe83
PE
9203 * dbusbind.c: Pointer signedness fixes.
9204 (xd_signature, xd_append_arg, xd_initialize):
9205 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9206 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9207 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9208 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9209
78320123
PE
9210 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9211 if GCC considers string literals to be constants.
49cebcca 9212 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9213
35ac2a97
SM
92142011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9215
fb103ca9
SM
9216 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9217 (print_preprocess, print_object): New macro to fix last change.
9218
35ac2a97
SM
9219 * print.c (print_preprocess): Don't forget font objects.
9220
62973b41
JB
92212011-03-16 Juanma Barranquero <lekktu@gmail.com>
9222
9223 * emacs.c (USAGE3): Doc fixes.
9224
0e48bb22
AS
92252011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9226
9227 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9228 structure.
9229
7684e57b
JB
92302011-03-14 Juanma Barranquero <lekktu@gmail.com>
9231
9232 * lisp.h (VWindow_system, Qfile_name_history):
9233 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9234 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9235 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9236
9237 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9238 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9239
9240 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9241 * w32console.c (detect_input_pending, read_input_pending)
9242 (encode_terminal_code):
9243 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9244 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9245 (w32_system_caret_y, Qfile_name_history):
9246 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9247 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9248 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9249 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9250 * w32proc.c (Qlocal, report_file_error):
9251 * w32term.c (Vwindow_system, updating_frame):
9252 * w32uniscribe.c (initialized, uniscribe_font_driver):
9253 Remove unneeded extern declarations.
9254
2aa46d6c
CY
92552011-03-14 Chong Yidong <cyd@stupidchicken.com>
9256
c96bbc66 9257 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9258
cffc6f3b
CY
92592011-03-13 Chong Yidong <cyd@stupidchicken.com>
9260
9261 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9262 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9263 These macros can no longer be used for assignment.
9264
44f230aa
SM
9265 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9266 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9267 (record_buffer_markers, fetch_buffer_markers): New functions for
9268 recording and fetching special buffer markers.
9269 (set_buffer_internal_1, set_buffer_temp): Use them.
9270
9271 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9272
9273 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9274
9275 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9276 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9277
9278 * xdisp.c (hscroll_window_tree):
9279 (reconsider_clip_changes): Use PT instead of BUF_PT.
9280
d251f04b
EZ
92812011-03-13 Eli Zaretskii <eliz@gnu.org>
9282
9283 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9284 $(EMACS_ROOT)/lib/intprops.h.
9285
f0c77cd1
PE
92862011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9287
3eca4629
PE
9288 Fix more problems found by GCC 4.5.2's static checks.
9289
7c86ee98
PE
9290 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9291 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9292 (xg_free_frame_widgets): Make it clear that a local variable is
9293 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9294 (gdk_window_get_screen): Make it clear that this macro is needed
9295 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9296 (int_gtk_range_get_value): New function, which avoids a diagnostic
9297 from gcc -Wbad-function-cast.
9298 (xg_set_toolkit_scroll_bar_thumb): Use it.
9299 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9300 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9301 (get_utf8_string, xg_get_file_with_chooser):
9302 Rename locals to avoid shadowing.
9303 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9304
41729b81
PE
9305 * xgselect.c (xg_select): Remove unused var.
9306
f0c77cd1
PE
9307 * image.c (four_corners_best): Mark locals as initialized.
9308 (gif_load): Initialize transparent_p to zero (Bug#8238).
9309 Mark another local as initialized.
ec6cf4c6 9310 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9311
ce0ad53d 9312 * image.c (clear_image_cache): Now static.
d5d5a617 9313 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9314 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9315 (x_edge_detection): Remove unnecessary cast that
9316 gcc -Wbad-function-cast diagnoses.
2037898d 9317 (gif_load): Fix pointer signedness.
6ae141d6
PE
9318 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9319 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9320
33383987 93212011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9322
d32df629
PE
9323 Improve quality of tests for time stamp overflow.
9324 For example, without this patch (encode-time 0 0 0 1 1
9325 1152921504606846976) returns the obviously-bogus value (-948597
9326 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9327 reports time overflow. See
9328 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9329 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9330 * editfns.c: Include limits.h and intprops.h.
9331 (TIME_T_MIN, TIME_T_MAX): New macros.
9332 (time_overflow): Move earlier, to before first use.
9333 (hi_time, lo_time): New functions, for an accurate test for
9334 out-of-range times.
9335 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9336 (Fget_internal_run_time): Don't assume time_t fits in int.
9337 (make_time): Use list2 instead of Fcons twice.
9338 (Fdecode_time): More accurate test for out-of-range times.
9339 (check_tm_member): New function.
9340 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9341 (lisp_time_argument): Don't rely on undefined left-shift and
9342 right-shift behavior when checking for time stamp overflow.
8be6f318 9343
fe31d94c
PE
9344 * editfns.c (time_overflow): New function, refactoring common code.
9345 (Fformat_time_string, Fdecode_time, Fencode_time):
9346 (Fcurrent_time_string): Use it.
9347
8be6f318
PE
9348 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9349 * dired.c (make_time): Move to ...
9350 * editfns.c (make_time): ... here.
9351 * systime.h: Note the move.
9352
09d9db2c 93532011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9354
126bc0dc
YM
9355 * fringe.c (update_window_fringes): Remove unused variables.
9356
c47cbdfd
YM
9357 * unexmacosx.c (copy_data_segment): Also copy __got section.
9358 (Bug#8223)
9359
7ac80be9
EZ
93602011-03-12 Eli Zaretskii <eliz@gnu.org>
9361
c96bbc66 9362 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9363 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9364 Constify `char *' arguments and their references according to
9365 prototypes in tparam.h.
9366
ecb0f94d 9367 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9368
7ac80be9
EZ
9369 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9370 Adapt all references accordingly.
9371
9372 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9373
ef1fd07e
TT
93742011-03-11 Tom Tromey <tromey@redhat.com>
9375
9376 * buffer.c (syms_of_buffer): Remove obsolete comment.
9377
7ef4b50c
EZ
93782011-03-11 Eli Zaretskii <eliz@gnu.org>
9379
9380 * termhooks.h (encode_terminal_code): Declare prototype.
9381
9382 * msdos.c (encode_terminal_code): Don't declare prototype.
9383
9384 * term.c (encode_terminal_code): Now external again, used by
9385 w32console.c and msdos.c.
9386
44f230aa
SM
9387 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9388 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9389
4b1ec863 93902011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9391
1714f52b 9392 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9393
4b1ec863
PE
9394 * fringe.c (update_window_fringes): Mark locals as initialized
9395 (Bug#8227).
9396 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9397
524c7aa6
PE
9398 * alloc.c (mark_fringe_data): Move decl from here ...
9399 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9400 to check its interface.
9401 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9402
a5c0af81 9403 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9404 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9405 (fontset_font): Mark local as initialized.
a9a06e0b 9406 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9407
b4716021
PE
9408 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9409
811e9bac 9410 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9411 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9412 (x_own_selection, Fx_disown_selection_internal): Rename locals
9413 to avoid shadowing.
9414 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9415
7e3ab302
PE
9416 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9417 so that the caller can use some name other than gcpro1.
9418 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9419 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9420 (Fx_backspace_delete_keys_p):
9421 Use them to avoid shadowing, and rename vars to avoid shadowing.
9422 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9423 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9424 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9425 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9426 Remove unused locals.
7e3ab302
PE
9427 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9428 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9429 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9430 macros.
f78faa98 9431
e2b13473
PE
9432 * xterm.h (x_mouse_leave): New decl.
9433
77f23912
PE
9434 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9435 Remove unused functions.
cdf4ba58
PE
9436 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9437 (x_calc_absolute_position): Now static.
7411c686 9438 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9439 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9440 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9441 unless they are used.
38d0b34a
PE
9442 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9443 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9444 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9445 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9446 (x_error_catcher, x_connection_closed, x_error_handler):
9447 (x_error_quitter, xembed_send_message, x_iconify_frame):
9448 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9449 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9450 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9451
44f230aa
SM
9452 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9453 Rename or move locals to avoid shadowing.
6b463e58 9454 (tty_defined_color, merge_face_heights): Now static.
5967d051 9455 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9456 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9457 does not deduce is never used uninitialized.
73719eba
PE
9458 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9459 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9460
426994c3 9461 * terminal.c (store_terminal_param): Now static.
5489860b 9462
032f1620 9463 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9464 (set_frame_menubar): Remove unused local.
d4323972 9465 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9466 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9467 since they might point to immutable storage.
281585b0
PE
9468 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9469 since it's unused otherwise.
032f1620 9470
367c19e5 9471 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9472 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9473 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9474 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9475 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9476 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9477 does not deduce are never used uninitialized.
70739cbe 9478
07b48fa9
PE
9479 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9480
8868a238 9481 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9482 * window.c (window_loop, size_window):
9483 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9484
7e5cf297 9485 * window.c (display_buffer): Now static.
d6550a9f
PE
9486 (size_window): Mark variables that gcc -Wuninitialized
9487 does not deduce are never used uninitialized.
a586633d
PE
9488 * window.h (check_all_windows): New decl, to forestall
9489 gcc -Wmissing-prototypes diagnostic.
5b555da1 9490 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9491
f6095868
PE
9492 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9493 shadowing.
9494 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9495 Include <limits.h>.
9496 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9497 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9498 (load_charset_map): Mark variables that gcc -Wuninitialized
9499 does not deduce are never used uninitialized.
53df7c11 9500 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9501
f38b440c
PE
9502 * coding.c (coding_set_source, coding_set_destination):
9503 Use "else { /* comment */ }" rather than "else /* comment */;"
9504 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9505 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9506 a block, when the outer 'i' will do.
9507 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9508 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9509 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9510 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9511 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9512 Rename locals to avoid shadowing.
9513 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9514 * coding.c (emacs_mule_char, encode_invocation_designation):
9515 Now static, since they're not used elsewhere.
413bb2db 9516 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9517 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9518 (decode_coding_emacs_mule): Mark variables that gcc
9519 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9520 (detect_coding_iso_2022): Initialize a local variable that might
9521 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9522 this initialization is needed. (Bug#8211)
5f58e762
PE
9523 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9524 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9525 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9526 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9527 Remove unused macros.
f38b440c 9528
232b38b9 9529 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9530 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9531 * character.c (string_count_byte8): Likewise.
232b38b9 9532
fb90da1b
PE
9533 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9534 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9535
fb93dbc2
PE
9536 * chartab.c (copy_sub_char_table): Now static, since it's not used
9537 elsewhere.
5c156ace
PE
9538 (sub_char_table_ref_and_range, char_table_ref_and_range):
9539 Rename locals to avoid shadowing.
bbcd0949 9540 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9541
7d3b3862 9542 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9543 (BIDI_BOB): Remove unused macro.
7d3b3862 9544
6be7d3da
PE
9545 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9546 deduce are never used uninitialized.
c2ed9c8b 9547 * term.c (encode_terminal_code): Likewise.
6be7d3da 9548
75f8807f 9549 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9550
50938595
PE
9551 * tparam.h: New file.
9552 * term.c, tparam.h: Include it.
9553 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9554 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9555 Move these decls to tparam.h, and make them agree with what
9556 is actually in tparam.c. The previous trick of using incompatible
9557 decls in different modules does not conform to the C standard.
9558 All callers of tparam changed to use tparam's actual API.
9559 * tparam.c (tparam1, tparam, tgoto):
9560 Use const pointers where appropriate.
9561
fbceeba2
PE
9562 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9563 * cm.h (struct cm): Likewise.
9564 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9565 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9566 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9567 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9568 (turn_on_face, init_tty): Likewise.
9569 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9570
7f3f1250
PE
9571 * term.c (term_mouse_position): Rename local to avoid shadowing.
9572
e6ca6543
PE
9573 * alloc.c (mark_ttys): Move decl from here ...
9574 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9575
c40f8d15
AS
95762011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9577
9578 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9579
cfe0661d
JB
95802011-03-09 Juanma Barranquero <lekktu@gmail.com>
9581
9582 * search.c (compile_pattern_1): Remove argument regp, unused since
9583 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9584 (compile_pattern): Don't pass it.
9585
0afb4571
J
95862011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9587
9588 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9589 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9590 for ! HAVE_GTK3.
9591 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9592
9593 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9594
9595 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9596 gdk_window_get_screen, gdk_window_get_geometry,
9597 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9598 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9599 (xg_get_pixbuf_from_pixmap): New function.
9600 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9601 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9602 Call xg_get_pixbuf_from_pixmap instead of
9603 gdk_pixbuf_get_from_drawable.
9604 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9605 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9606 (xg_check_special_colors): Use GtkStyleContext and its functions
9607 for HAVE_GTK3.
9608 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9609 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9610 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9611 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9612 Call gtk_widget_get_preferred_size.
0afb4571
J
9613 (xg_frame_resized): gdk_window_get_geometry only takes 5
9614 parameters.
44f230aa
SM
9615 (xg_win_to_widget, xg_event_is_for_menubar):
9616 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9617 (xg_set_widget_bg): New function.
9618 (delete_cb): New function.
895009e1 9619 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9620 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9621 (xg_set_background_color): Call xg_set_widget_bg.
9622 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9623 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9624 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9625 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9626 if ! HAVE_GTK3.
9627 (update_frame_tool_bar): Call gtk_widget_hide.
9628 (xg_initialize): Use GDK_KEY_g.
9629
9630 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9631 if ! HAVE_GTK3
9632 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9633
9634 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9635 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9636 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9637
1c2cc4ef
JB
96382011-03-08 Juanma Barranquero <lekktu@gmail.com>
9639
9640 * w32xfns.c (select_palette): Check success of RealizePalette against
9641 GDI_ERROR, not zero.
9642
33383987 9643See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9644
9645;; Local Variables:
9646;; coding: utf-8
aac0c6e3
MR
9647;; End:
9648
acaf905b 9649 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9650
9651 This file is part of GNU Emacs.
9652
9653 GNU Emacs is free software: you can redistribute it and/or modify
9654 it under the terms of the GNU General Public License as published by
9655 the Free Software Foundation, either version 3 of the License, or
9656 (at your option) any later version.
9657
9658 GNU Emacs is distributed in the hope that it will be useful,
9659 but WITHOUT ANY WARRANTY; without even the implied warranty of
9660 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9661 GNU General Public License for more details.
9662
9663 You should have received a copy of the GNU General Public License
9664 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.