Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ddff3151
PE
12011-07-29 Paul Eggert <eggert@cs.ucla.edu>
2
726e0ab1
PE
3 Integer and memory overflow issues.
4
5 * bidi.c (bidi_shelve_header_size): New constant.
6 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8
9 * buffer.c (overlays_at, overlays_in, record_overlay_string)
10 (overlay_strings):
11 Don't update size of array until after memory allocation succeeds,
12 because xmalloc/xrealloc may not return.
13
14 * callproc.c (child_setup): Don't assume strlen fits in int.
15
16 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
17 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
18 Redo buffer-overflow calculations to avoid integer overflow.
19
20 * character.c (Fstring): Check for size-calculation overflow.
21
22 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
23 unnecessary integer overflow. Check for size overflow.
24 (encode_coding_object): Don't update size until xmalloc succeeds.
25
26 * composite.c (get_composition_id): Check for overflow in glyph
27 length calculations.
28
29 Integer and memory overflow fixes for display code.
30 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
31 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
32 (scrolling_window): Check for overflow in size calculations.
33 (line_draw_cost, realloc_glyph_pool, add_row_entry):
34 Don't assume glyph table len fits in int.
35 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
36 (row_table_size): Now ptrdiff_t, not int.
37 (scrolling_window): Avoid overflow in size calculations.
38 Don't update size until allocation succeeds.
39 * fns.c (concat): Check for overflow in size calculations.
40 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
41 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
42 (NEXT_ALMOST_PRIME_LIMIT): New constant.
43
44 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
45 (get_doc_string): Check for size calculation overflow.
46 Don't update size until allocation succeeds.
47 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
48 EMACS_INT, where ptrdiff_t will do.
49 (Fsubstitute_command_keys): Check for string overflow.
50
51 * editfns.c (set_time_zone_rule): Don't assume environment length
52 fits in int.
53 (message_length): Now ptrdiff_t, not int.
54 (Fmessage_box): Don't update size until allocation succeeds.
55 Don't assume message length fits in int.
56 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
57
58 * emacs.c (main, sort_args): Check for size-calculation overflow.
59
60 * eval.c (init_eval_once, grow_specpdl): Don't update size until
61 alloc succeeds.
62 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
63
64 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
65 (x_set_scroll_bar_width, x_figure_window_size):
66 Check for integer overflow.
67 (x_set_alpha): Do not assume XINT fits in int.
68
69 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
70 This is for the members text_lines, text_cols, total_lines, total_cols,
71 where the system imposes an 'int' limit.
72
73 * fringe.c (Fdefine_fringe_bitmap):
74 Don't update size until alloc works.
75
76 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
77 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
78
79 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
80 Check for size-calculation overflow.
81 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
82 do, as we prefer signed integers.
83 (id_to_widget.max_size, id_to_widget.used)
84 (xg_store_widget_in_map, xg_remove_widget_from_map)
85 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
86 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
87 Use and return ptrdiff_t, not int.
88 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
89 * gtkutil.h: Change prototypes to match the above.
90
91 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
92 are duplicate now that they've been promoted to lisp.h.
93 (x_allocate_bitmap_record, x_alloc_image_color)
94 (make_image_cache, cache_image, xpm_load):
95 Don't update size until alloc is done.
96 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
97 (x_detect_edges):
3256efce 98 Check for size calculation overflow.
726e0ab1
PE
99 (ct_colors_allocated_max): New constant.
100 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
101 overflow.
3256efce 102
726e0ab1
PE
103 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
104 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
105 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
106 Use ptrdiff_t, not int, to count maps.
107 (read_char_minibuf_menu_prompt): Check for overflow in size
108 calculations. Don't update size until allocation succeeds. Redo
109 calculations to avoid overflow.
110 * keyboard.h: Change prototypes to match the above.
111
112 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
113 to count maps.
114 (current_minor_maps): Check for size calculation overflow.
115 * keymap.h: Change prototypes to match the above.
116
117 * lread.c (read1, init_obarray): Don't update size until alloc done.
118
119 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
120 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
121
122 * minibuf.c (read_minibuf_noninteractive): Don't leak memory
123 on memory overflow.
124
125 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
126 Now ptrdiff_t, not int.
127 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
128 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
129
130 * process.c (Fnetwork_interface_list): Check for overflow
131 in size calculation.
132
133 * region-cache.c (move_cache_gap): Check for size calculation overflow.
134
135 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
136 overflow. Don't bother calling xmalloc when xrealloc will do.
137
138 * search.c (Freplace_match): Check for size calculation overflow.
139 (Fset_match_data): Don't assume list lengths fit in 'int'.
140
141 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
142 for command line length. Do not attempt to address one before the
143 beginning of an array, as that's not portable.
144
145 * term.c (max_frame_lines): Remove; unused.
146 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
147 not int.
148 (encode_terminal_code, calculate_costs): Check for size
149 calculation overflow.
150 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
151 table lengths and related sizes. Don't update size until alloc
152 done. Redo calculations to avoid overflow.
153 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
154
155 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
156 subtracting pointers.
157 (gobble_line): Check for overflow more carefully. Don't update size
158 until alloc done.
159
160 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
161 Don't update size until alloc done.
162 Redo size calculations to avoid overflow.
163 Check for size calculation overflow.
164
165 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
166 Use ptrdiff_t, not int, for sizes.
167 (store_mode_line_noprop_char): Don't update size until alloc done.
168
169 * xfaces.c (Finternal_make_lisp_face): Use ptrdiff_t, not int, for
170 sizes. Check for size calculation overflow.
171 (cache_face): Do not overflow in size calculation.
172
173 * xfns.c (x_encode_text, x_set_name_internal)
174 (Fx_change_window_property): Use ptrdiff_t, not int, to count
175 sizes, since they can exceed INT_MAX in size. Check for size
176 calculation overflow.
177
178 * xgselect.c (xg_select): Check for size calculation overflow.
179 Don't update size until alloc done.
180
181 * xrdb.c (magic_file_p): Plug memory leak on size overflow.
182 (get_environ_db): Don't assume path length fits in int,
183 as sprintf is limited to int lengths.
1d526e2f 184
726e0ab1 185 * xselect.c (X_LONG_SIZE, X_USHRT_MAX, X_ULONG_MAX): New macros.
864d7ce7
PE
186 Use them to make the following changes clearer.
187 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
188 This change doesn't affect the value now, but it may help remind
189 future maintainers not to raise the value too much later.
190 (SELECTION_QUANTUM): Remove, replacing with ...
191 (selection_quantum): ... new function, which avoids overflow.
192 All uses changed.
193 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
194 assumption that selection length fits in 'int'.
195 (x_reply_selection_request, x_handle_selection_request)
196 (x_get_window_property, receive_incremental_selection)
197 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
198 (lisp_data_to_selection_data, clean_local_selection_data):
199 Use ptrdiff_t, not int, to record length of selection.
200 (x_reply_selection_request, x_get_window_property)
201 (receive_incremental_selection, x_property_data_to_lisp):
202 Redo calculations to avoid overflow.
203 (x_reply_selection_request): When sending hint, ceiling it at
204 X_ULONG_MAX rather than relying on wraparound overflow to send
205 something.
206 (x_get_window_property, receive_incremental_selection)
207 (lisp_data_to_selection_data, x_property_data_to_lisp):
208 Check for size-calculation overflow.
209 (x_get_window_property, receive_incremental_selection)
210 (lisp_data_to_selection_data, Fx_register_dnd_atom):
211 Don't store size until memory allocation succeeds.
212 (x_get_window_property): Plug memory leak on memory exhaustion.
213 Don't double-block input; malloc is safe here. Don't assume 2**34
214 - 4 fits in unsigned long. Add an xassert to check
215 XGetWindowProperty overflow. Be more careful about overflow
216 calculations, and distinguish size from memory overflow better.
217 (receive_incremental_selection): When tracing, don't assume
218 unsigned int is less than INT_MAX.
219 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
220 harmful) conversions of unsigned short to int.
221 (lisp_data_to_selection_data): Don't assume that integers
222 in the range -65535 through -1 fit in an X unsigned short.
223 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
224 result parameters unless successful. Rely on cons_to_unsigned
225 to report problems with elements; the old code wasn't right anyway.
226 (x_check_property_data): Check for int overflow; we cannot use
227 a wider type due to X limits.
228 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
229
726e0ab1 230 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 231
726e0ab1 232 * xterm.c (x_color_cells, handle_one_xevent, x_term_init):
ddff3151 233 Check for size calculation overflow.
726e0ab1
PE
234 (x_color_cells): Don't store size until memory allocation succeeds.
235 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
236 (x_term_init): Don't assume length fits in int (sprintf is limited
237 to int size).
bc18e09d 238
ebfa62c0
PE
239 Use ptrdiff_t for composition IDs.
240 * character.c (lisp_string_width):
241 * composite.c (composition_table_size, n_compositions)
242 (get_composition_id, composition_gstring_from_id):
243 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
244 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
245 * window.c (Frecenter):
246 Use ptrdiff_t, not int, for composition IDs.
247 * composite.c (get_composition_id): Check for integer overflow.
248 * composite.h: Adjust prototypes to match the above changes.
249
d3411f89
PE
250 Use ptrdiff_t for hash table indexes.
251 * category.c (hash_get_category_set):
252 * ccl.c (ccl_driver):
253 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
254 * coding.c (coding_system_charset_list, detect_coding_system):
255 * coding.h (struct coding_system.id):
256 * composite.c (get_composition_id, gstring_lookup_cache):
257 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
258 * image.c (xpm_get_color_table_h):
259 * lisp.h (hash_lookup, hash_put):
260 * minibuf.c (Ftest_completion):
261 Use ptrdiff_t for hash table indexes, not int (which is too
262 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
263 32-bit --with-wide-int hosts).
264
e097a6fa
PE
265 * charset.c (Fdefine_charset_internal): Check for integer overflow.
266 Add a FIXME comment about memory leaks.
267 (syms_of_charset): Don't assume xmalloc returns.
268
5637687f
PE
269 Don't assume that stated character widths fit in int.
270 * character.c (Fchar_width, c_string_width, lisp_string_width):
271 * character.h (CHAR_WIDTH):
272 * indent.c (MULTIBYTE_BYTES_WIDTH):
273 Use sanitize_char_width to avoid undefined and/or bad behavior
274 with outlandish widths.
275 * character.h (sanitize_tab_width): Renamed from sanitize_width,
276 now that we have two such functions. All uses changed.
277 (sanitize_char_width): New inline function.
278
a2271ba2
PE
279 Don't assume that tab-width fits in int.
280 * character.h (sanitize_width): New inline function.
281 (SANE_TAB_WIDTH): New macro.
282 (ASCII_CHAR_WIDTH): Use it.
283 * indent.c (sane_tab_width): Remove. All uses replaced by
284 SANE_TAB_WIDTH (current_buffer).
285 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
286
18c52557
PE
287 * fileio.c: Integer overflow issues with file modes.
288 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
289
caeeedc1
PE
290 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
291 Remove unreachable code.
292 (read_hex, load_charset_map_from_file): Check for integer overflow.
293
50849c52
PE
294 * xterm.c: don't go over XClientMessageEvent limit
295 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
296 (x_send_scroll_bar_event): Likewise. Check that the size does not
297 exceed limits imposed by XClientMessageEvent, as well as the usual
298 ptrdiff_t and size_t limits.
299
b13995db
PE
300 * keyboard.c: Overflow, signedness and related fixes.
301 (make_lispy_movement): Use same integer type in forward decl
302 that is used in the definition.
303 (read_key_sequence, keyremap_step):
304 Change bufsize argument back to int, undoing my 2011-03-30 change.
305 We prefer signed types, and int is wide enough here.
306 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
307 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
308 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
309 length, not size_t. Use ptrdiff_t for index, not int.
310 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
311 possibility of integer overflow.
312
13464394
PE
313 Overflow, signedness and related fixes for images.
314
315 * dispextern.h (struct it.stack[0].u.image.image_id)
316 (struct_it.image_id, struct image.id, struct image_cache.size)
317 (struct image_cache.used, struct image_cache.ref_count):
318 * gtkutil.c (update_frame_tool_bar):
319 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
320 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
321 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
322 * nsmenu.m (update_frame_tool_bar):
323 * xdisp.c (calc_pixel_width_or_height):
324 * xfns.c (image_cache_refcount):
325 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
326 on typical 64-bit hosts.
327
328 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
329 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
330 Omit unnecessary casts to int.
331 (parse_image_spec): Check that integers fall into 'int' range
332 when the callers expect that.
333 (image_ascent): Redo ascent calculation to avoid int overflow.
334 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
335 (lookup_image): Remove unnecessary tests.
336 (xbm_image_p): Locals are now of int, not EMACS_INT,
337 since parse_image_check makes sure they fit into int.
338 (png_load, gif_load, svg_load_image):
339 Prefer int to unsigned where either will do.
340 (tiff_handler): New function, combining the cores of the
341 old tiff_error_handler and tiff_warning_handler. This
342 function is rewritten to use vsnprintf and thereby avoid
343 stack buffer overflows. It uses only the features of vsnprintf
344 that are common to both POSIX and native Microsoft.
345 (tiff_error_handler, tiff_warning_handler): Use it.
346 (tiff_load, gif_load, imagemagick_load_image):
347 Don't assume :index value fits in 'int'.
348 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
349 (imagemagick_load_image): Check that crop parameters fit into
350 the integer types that MagickCropImage accepts. Don't assume
351 Vimagemagick_render_type has a nonnegative value. Don't assume
352 size_t fits in 'long'.
353 (gs_load): Use printmax_t to print the widest integers possible.
354 Check for integer overflow when computing image height and width.
355
9a79b20c
AS
3562011-07-28 Andreas Schwab <schwab@linux-m68k.org>
357
358 * print.c (print_object): Print empty symbol as ##.
359
360 * lread.c (read1): Read ## as empty symbol.
361
d8c2fa78
AA
3622011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
363
364 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
365 setting frame foreground color (Bug#9175).
366 (x_set_background_color): Likewise.
367
ffe57a7a
AA
368 * nsmenu.m (-setText): Size tooltip dimensions precisely to
369 contents (Bug#9176).
370 (EmacsTooltip -init): Remove bezels and add shadows to
371 tooltip windows.
372
bf3492a5
AA
373 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
374 or scroll bar (Bug#8470).
375
d55e9c53
AA
376 * nsfont.m (nsfont_open): Remove assignment to voffset and
377 unnecessary vars hshink, expand, hd, full_height, min_height.
378 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
379
380 * nsterm.h (nsfont_info): Remove voffset field.
381
d8c2fa78 3822011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
383
384 Implement strike-through and overline on NextStep (Bug#8863).
385
386 * nsfont.m (nsfont_open): Use underline position provided by font,
387 instead of hard-coded value of 2.
388 (nsfont_draw): Call ns_draw_text_decoration instead.
389
390 * nsterm.h: Add declaration for ns_draw_text_decoration.
391
392 * nsterm.m (ns_draw_text_decoration): New function for drawing
393 underline, overline, and strike-through.
394 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
395 ns_draw_text_decoration. Change treatment of cursor drawing to
396 accomodate underlining, etc.
397
4cc60b9b
EZ
3982011-07-28 Eli Zaretskii <eliz@gnu.org>
399
bc7ece87
EZ
400 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
401 default.
4cc60b9b 402
476371c4
PE
4032011-07-28 Paul Eggert <eggert@cs.ucla.edu>
404
66606eea
PE
405 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
406 Without this fix, if a signal arrives just after memory fills up,
407 'malloc' might be invoked reentrantly.
408
476371c4
PE
409 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
410 In other words, assume that every image size is allowed, on non-X
411 hosts. This assumption is probably wrong, but it lets Emacs compile.
412
f3fcc40d
AS
4132011-07-28 Andreas Schwab <schwab@linux-m68k.org>
414
415 * regex.c (re_iswctype): Convert return values to boolean.
416
350c992f
EZ
4172011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
418
419 * xdisp.c (compute_display_string_pos): Don't use cached display
420 string position if the buffer had its restriction changed.
421 (Bug#9184)
422
5266b4bb
PE
4232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
424
425 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
426
2573a837 4272011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 428
41f55ccd 429 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 430
39e378da
PE
431 * bidi.c: Integer size and overflow fixes.
432 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
433 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
434 (bidi_cache_find_level_change, bidi_cache_ensure_space)
435 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
436 (bidi_find_other_level_edge):
437 Use ptrdiff_t instead of EMACS_INT where either will do.
438 This works better on 32-bit hosts configured --with-wide-int.
439 (bidi_cache_ensure_space): Check for size-calculation overflow.
440 Use % rather than repeated addition, for better worst-case speed.
441 Don't set bidi_cache_size until after xrealloc returns, because it
442 might not return.
443 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
444 (bidi_cache_ensure_space): Also check that the bidi cache size
445 does not exceed that of the largest Lisp string or buffer. See Eli
446 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 447
5e927815
PE
448 * alloc.c (__malloc_size_t): Remove.
449 All uses replaced by size_t. See Andreas Schwab's note
450 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
451
ca4aa935
PE
452 * image.c: Improve checking for integer overflow.
453 (check_image_size): Assume that f is nonnull, since
454 it is always nonnull in practice. This is one less thing to
455 worry about when checking for integer overflow later.
456 (x_check_image_size): New function, which checks for integer
457 overflow issues inside X.
458 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
459 This removes the need for a memory_full check.
460 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
461 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
462 (xbm_read_bitmap_data): Change locals back to 'int', since
463 their values must fit in 'int'.
464 (xpm_load_image, png_load, tiff_load):
465 Invoke x_create_x_image_and_pixmap earlier,
466 to avoid much needless work if the image is too large.
467 (tiff_load): Treat overly large images as if
468 x_create_x_image_and_pixmap failed, not as malloc failures.
469 (gs_load): Use x_check_image_size.
470
5f8f9cc2
PE
471 * gtkutil.c: Omit integer casts.
472 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
473 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
474
5adf60bc
PE
475 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
476
c8907a93
PE
477 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
478 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
479 would wrongly return t on a 64-bit host.
480
e3c25c68
PE
481 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
482 The plain *_OVERFLOW macros run afoul of GCC bug 49705
483 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
484 and therefore cause GCC to emit a bogus diagnostic in some cases.
485
3f791afe
PE
486 * image.c: Integer signedness and overflow and related fixes.
487 This is not an exhaustive set of fixes, but it's time to
488 record what I've got.
489 (lookup_pixel_color, check_image_size): Remove redundant decls.
490 (check_image_size): Don't assume that arbitrary EMACS_INT values
491 fit in 'int', or that arbitrary 'double' values fit in 'int'.
492 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
493 (tiff_load, imagemagick_load_image):
494 Check for overflow in size calculations.
495 (x_create_x_image_and_pixmap): Remove unnecessary test for
496 xmalloc returning NULL; that can't happen.
497 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
498 (xpm_color_bucket): Use better integer hashing function.
499 (xpm_cache_color): Don't possibly over-allocate memory.
500 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
501 (gif_memory_source):
502 Use ptrdiff_t, not int or size_t, to record sizes.
503 (png_load): Don't assume values greater than 2**31 fit in 'int'.
504 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
505 either works, as we prefer signed integers.
506 (tiff_read_from_memory, tiff_write_from_memory):
507 Return tsize_t, not size_t, since that's what the TIFF API wants.
508 (tiff_read_from_memory): Don't fail simply because the read would
509 go past EOF; instead, return a short read.
510 (tiff_load): Omit no-longer-needed casts.
511 (Fimagemagick_types): Don't assume size fits into 'int'.
512
3cc5a532
PE
513 Improve hashing quality when configured --with-wide-int.
514 * fns.c (hash_string): New function, taken from sxhash_string.
515 Do not discard information about ASCII character case; this
516 discarding is no longer needed.
517 (sxhash-string): Use it. Change sig to match it. Caller changed.
518 * lisp.h: Declare it.
519 * lread.c (hash_string): Remove, since we now use fns.c's version.
520 The fns.c version returns a wider integer if --with-wide-int is
521 specified, so this should help the quality of the hashing a bit.
522
b312a492
PE
523 * emacs.c: Integer overflow minor fix.
524 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
525 Define only if GNU_LINUX.
526 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
527
dfd153ae
PE
528 * dispnew.c: Integer signedness and overflow fixes.
529 Remove unnecessary forward decls, that were a maintenance hassle.
530 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
531 All uses changed.
532 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
533 (scrolling_window): Use ptrdiff_t, not int, for byte count.
534 (prepare_desired_row, line_draw_cost):
535 Use int, not unsigned, where either works.
536 (save_current_matrix, restore_current_matrix):
537 Use ptrdiff_t, not size_t, where either works.
538 (init_display): Check for overflow more accurately, and without
539 relying on undefined behavior.
540
a81d11a3
PE
541 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
542 Remove, replacing with the new symbols in lisp.h. All uses changed.
543 * fileio.c (make_temp_name):
544 * filelock.c (lock_file_1, lock_file):
545 * xdisp.c (message_dolog):
546 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
547 Use pMd etc. instead.
548 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
549 replacing the pWIDE etc. symbols removed from editfns.c.
550
3300e6fd
PE
551 * keyboard.h (num_input_events): Now uintmax_t.
552 This is (very slightly) less likely to mess up due to wraparound.
553 All uses changed.
554
fd05c7e9
PE
555 * buffer.c: Integer signedness fixes.
556 (alloc_buffer_text, enlarge_buffer_text):
557 Use ptrdiff_t rather than size_t when either will do, as we prefer
558 signed integers.
559
903fe15d
PE
560 * alloc.c: Integer signedness and overflow fixes.
561 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
562 (__malloc_size_t): Default to size_t, not to int.
563 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
564 (Fgarbage_collect, mark_object_loop_halt, mark_object):
565 Prefer ptrdiff_t to size_t when either would do, as we prefer
566 signed integers.
567 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
568 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
569 Now const. Initialize with values that are in range even if char
570 is signed.
571 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
572 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
573 These functions do the right thing with sizes > 2**32.
574 (check_depth): Now ptrdiff_t, not int.
575 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
576 Adjust to new way of storing sizes. Check for size overflow bugs
577 in rest of code.
578 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
579 slightly wrong anyway, as it missed one instance of
580 XMALLOC_OVERRUN_CHECK_OVERHEAD.
581 (refill_memory_reserve): Omit needless cast to size_t.
582 (mark_object_loop_halt): Mark as externally visible.
583
ac82cc6a
PE
584 * xselect.c: Integer signedness and overflow fixes.
585 (Fx_register_dnd_atom, x_handle_dnd_message):
586 Use ptrdiff_t, not size_t, since we prefer signed.
587 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
588 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
589 x_dnd_atoms_size and x_dnd_atoms_length.
590
c2d1e36d
PE
591 * doprnt.c: Prefer signed to unsigned when either works.
592 * eval.c (verror):
593 * doprnt.c (doprnt):
594 * lisp.h (doprnt):
595 * xdisp.c (vmessage):
596 Use ptrdiff_t, not size_t, when using or implementing doprnt,
597 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
598 prefer signed arithmetic to avoid comparison confusion.
599 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
600 but is a bit tricky.
601
0e926e56
PE
602 Assume freestanding C89 headers, string.h, stdlib.h.
603 * data.c, doprnt.c, floatfns.c, print.c:
604 Include float.h unconditionally.
605 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
606 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
607 * regex.c: Likewise for stddef.h, string.h.
608 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
609 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
610 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
611 (STDC_HEADERS): Remove obsolete defines.
612 * sysdep.c: Include limits.h unconditionally.
613
9cfdb3ec
PE
614 Assume support for memcmp, memcpy, memmove, memset.
615 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
616 * regex.c (memcmp, memcpy):
617 Remove; we assume C89 now.
618
619 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
620 (__malloc_safe_bcopy): Remove; no longer needed.
621
cf950e6b 622 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
623 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
624 well either way, and we prefer signed to unsigned.
625
dbf38e02
LMI
6262011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
627
628 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
629 closes the connection while we're reading (bug#9182).
630
d6f0886c
JD
6312011-07-25 Jan Djärv <jan.h.d@swipnet.se>
632
633 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
634 are specified (Bug#9168).
635
2eb1f9e6
PE
6362011-07-25 Paul Eggert <eggert@cs.ucla.edu>
637
638 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
639 Found by GCC static checking and --with-wide-int on a 32-bit host.
640
22381272 6412011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
642
643 * xdisp.c (compute_display_string_pos): Fix logic of caching
644 previous display string position. Initialize cached_prev_pos to
645 -1. Fixes slow-down at the beginning of a buffer.
646
f25e39b4
EZ
6472011-07-24 Eli Zaretskii <eliz@gnu.org>
648
649 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
650 for attrs[LFACE_FONTSET_INDEX].
651
04c4b52e
PE
6522011-07-23 Paul Eggert <eggert@cs.ucla.edu>
653
654 * xml.c (parse_region): Remove unused local
655 that was recently introduced.
656
c1734fbd
EZ
6572011-07-23 Eli Zaretskii <eliz@gnu.org>
658
be18c5a5
EZ
659 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
660 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
661
c1734fbd
EZ
662 * xdisp.c (move_it_in_display_line_to): Record the best matching
663 position for TO_CHARPOS while scanning the line, and restore it on
664 exit if none of the characters scanned was an exact match. Fixes
a9269c18
EZ
665 vertical-motion and pos-visible-in-window-p under bidi redisplay
666 when exact match is impossible due to invisible text, and the
667 lines are truncated.
668
a258d627
JD
6692011-07-23 Jan Djärv <jan.h.d@swipnet.se>
670
671 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
672 for OSX >= 10.7.
673
b6d5a689
EZ
6742011-07-22 Eli Zaretskii <eliz@gnu.org>
675
0f74f785
EZ
676 Fix a significant slow-down of cursor motion with C-n, C-p,
677 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
678 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 679 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
680 (next_element_from_buffer): Call compute_stop_pos_backwards to
681 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
682 base_level_stop.
683 (reseat): Don't look for prev_stop, as that could mean a very long
684 run.
685 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
686 <cached_disp_overlay_modiff>: Cache for last found display string
687 position.
551918c1 688 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
689 about the same buffer in the same area of character positions, and
690 the buffer wasn't changed since the time the display string
691 position was cached.
551918c1 692
b2d0c91a
EZ
6932011-07-22 Eli Zaretskii <eliz@gnu.org>
694
695 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
696 is an integer, which is important for empty lines. (Bug#9149)
697
043604ee
CY
6982011-07-22 Chong Yidong <cyd@stupidchicken.com>
699
700 * frame.c (Fmodify_frame_parameters): In tty case, update the
701 default face if necessary (Bug#4238).
702
da4adb04
CY
7032011-07-21 Chong Yidong <cyd@stupidchicken.com>
704
705 * editfns.c (Fstring_to_char): No need to explain what a character
706 is in the docstring (Bug#6576).
707
9abd0532
LMI
7082011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
709
710 * xml.c (parse_region): Make sure we always return a tree.
711
36881d16
HK
7122011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
713
714 * xml.c (parse_region): If a document contains only comments,
715 return that, too.
716
1e98674d
LMI
7172011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
718
719 * xml.c (make_dom): Return comments, too.
720
590bd467
PE
7212011-07-19 Paul Eggert <eggert@cs.ucla.edu>
722
723 Port to OpenBSD.
724 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
725 and the surrounding thread.
726 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
727 rather than fgets, and retry after EINTR. Otherwise, 'emacs
728 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
729 timer goes off.
730 * s/openbsd.h (BROKEN_SIGIO): Define.
731 * unexelf.c (unexec) [__OpenBSD__]:
732 Don't update the .mdebug section of the Alpha COFF symbol table.
733
f41628b2
LMI
7342011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
735
736 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
737 (bug#8460).
738
b59b67c5
PE
7392011-07-18 Paul Eggert <eggert@cs.ucla.edu>
740
15e3a074
PE
741 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
742 This fixes some race conditions on the permissions of any newly
743 created file.
744
41bed37d
PE
745 * alloc.c (valid_pointer_p): Use pipe, not open.
746 This fixes some permissions issues when debugging.
747
b59b67c5
PE
748 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
749 If fchown fails to set both uid and gid, try to set just gid,
750 as that is sometimes allowed. Adjust the file's mode to eliminate
751 setuid or setgid bits that are inappropriate if fchown fails.
752
925a6be7
SM
7532011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
754
755 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
756 to compare Lisp_Objects.
757 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
758 global_gnutls_log_level, don't mistake it for a Lisp_Object.
759 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
760
52968808
AS
7612011-07-17 Andreas Schwab <schwab@linux-m68k.org>
762
0a6a104b
AS
763 * lread.c (read_integer): Unread even EOF character.
764 (read1): Likewise. Properly record start position of symbol.
765
52968808
AS
766 * lread.c (read1): Read `#:' as empty uninterned symbol if no
767 symbol character follows.
768
9e381cdd
PE
7692011-07-17 Paul Eggert <eggert@cs.ucla.edu>
770
771 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
772 This works around a problem with the previous change to Fcopy_file.
773 Recent glibc declares fchown with __attribute__((warn_unused_result)),
774 and without this change, GCC might complain about discarding
775 fchown's return value.
776
b5641435
JB
7772011-07-16 Juanma Barranquero <lekktu@gmail.com>
778
779 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
780
a8031457
PE
7812011-07-16 Paul Eggert <eggert@cs.ucla.edu>
782
783 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
784
dd889327
LMI
7852011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
786
750c33f7
LMI
787 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
788 it's used from the C level.
789
dd889327
LMI
790 * process.c: Use the same condition for POLL_FOR_INPUT in both
791 keyboard.c and process.c (bug#1858).
792
87e86684
LM
7932011-07-09 Lawrence Mitchell <wence@gmx.li>
794
795 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
796 (Fgnutls_boot): Use it.
797
64348f40
AS
7982011-07-15 Andreas Schwab <schwab@linux-m68k.org>
799
800 * doc.c (Fsubstitute_command_keys): Revert last change.
801
1d698799
LMI
8022011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
803
f863868c
LMI
804 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
805 quotes the next character, and doesn't affect other longer
806 sequences (bug#8935).
807
1d698799
LMI
808 * lread.c (syms_of_lread): Clarify that is isn't only
809 `eval-buffer' and `eval-defun' that's affected by
810 `lexical-binding' (bug#8460).
811
aa4b6df6
EZ
8122011-07-15 Eli Zaretskii <eliz@gnu.org>
813
814 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
815 bidi redisplay when a line includes both an image and is
816 truncated.
817
5d856da6
PE
8182011-07-14 Paul Eggert <eggert@cs.ucla.edu>
819
ad6042bb
PE
820 Fix minor problems found by static checking.
821 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
822 (elsz): Now a signed constant, not a size_t var. We prefer signed
823 types to unsigned, to avoid integer comparison confusion. Without
824 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
825 "cannot optimize loop, the loop counter may overflow", a symptom
826 of the confusion.
f00bbb22 827 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
828 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
829
6468f31c
LMI
8302011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
831
49080b10
LMI
832 * search.c (Fre_search_backward): Mention `case-fold-search' in
833 all the re_search_* functions (bug#8138).
834
6468f31c
LMI
835 * keyboard.c (Fopen_dribble_file): Document when the file is
836 closed (bug#8056).
837
c965adc5
EZ
8382011-07-14 Eli Zaretskii <eliz@gnu.org>
839
df9733bf
EZ
840 * bidi.c (bidi_dump_cached_states): Fix format of displaying
841 bidi_cache_idx.
842
0bb23927
EZ
843 Support bidi reordering of display and overlay strings.
844 * xdisp.c (compute_display_string_pos)
845 (compute_display_string_end): Accept additional argument STRING.
846 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
847 (reseat_to_string): Initialize bidi_it->string.s and
848 bidi_it->string.schars.
849 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
850 NULL (avoids a crash in bidi_paragraph_init). Initialize
851 itb.string.lstring.
852 (init_iterator): Call bidi_init_it only of a valid
853 buffer position was specified. Initialize paragraph_embedding to
854 L2R.
855 (reseat_to_string): Initialize the bidi iterator.
856 (display_string): If we need to ignore text properties of
857 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
858 original value of -1 will not work with bidi.)
859 (compute_display_string_pos): First arg is now struct
860 `text_pos *'; all callers changed. Support display properties on
861 Lisp strings.
862 (compute_display_string_end): Support display properties on Lisp
863 strings.
864 (init_iterator, reseat_1, reseat_to_string): Initialize the
865 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
866 when iterating on a string not from display properties).
867 (compute_display_string_pos, compute_display_string_end): Fix
868 calculation of the object to scan. Fixes an error when using
869 arrow keys.
870 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
871 base_level_stop; instead, set base_level_stop to BEGV. Fixes
872 crashes in vertical-motion.
873 (next_element_from_buffer): Improve commentary for when
874 the iterator is before prev_stop.
875 (init_iterator): Initialize bidi_p from the default value of
876 bidi-display-reordering, not from buffer-local value. Use the
877 buffer-local value only if initializing for buffer iteration.
878 (handle_invisible_prop): Support invisible properties on strings
879 that are being bidi-reordered.
880 (set_iterator_to_next): Support bidi reordering of C strings and
881 Lisp strings.
882 (next_element_from_string): Support bidi reordering of Lisp
883 strings.
884 (handle_stop_backwards): Support Lisp strings as well.
885 (display_string): Support display of R2L glyph rows. Use
886 IT_STRING_CHARPOS when displaying from a Lisp string.
887 (init_iterator): Don't initialize it->bidi_p for strings
888 here.
889 (reseat_to_string): Initialize it->bidi_p for strings here.
890 (next_element_from_string, next_element_from_c_string)
891 (next_element_from_buffer): Add xassert's for correspondence
892 between IT's object being iterated and it->bidi_it.string
893 structure.
894 (face_before_or_after_it_pos): Support bidi iteration.
895 (next_element_from_c_string): Handle the case of the first string
896 character that is not the first one in the visual order.
897 (get_visually_first_element): New function, refactored from common
898 parts of next_element_from_buffer, next_element_from_string, and
899 next_element_from_c_string.
900 (tool_bar_lines_needed, redisplay_tool_bar)
901 (display_menu_bar): Force left-to-right direction. Add a FIXME
902 comment for making that be controlled by a user option.
903 (push_it, pop_it): Save and restore the state of the
904 bidi iterator. Save and restore the bidi_p flag.
905 (pop_it): Iterate out of display property for string iteration as
906 well.
907 (iterate_out_of_display_property): Support iteration over strings.
908 (handle_single_display_spec): Set up it->bidi_it for iteration
909 over a display string, and call bidi_init_it.
910 (handle_single_display_spec, next_overlay_string)
911 (get_overlay_strings_1, push_display_prop): Set up the bidi
912 iterator for displaying display or overlay strings.
913 (forward_to_next_line_start): Don't use the shortcut if
914 bidi-iterating.
915 (back_to_previous_visible_line_start): If handle_display_prop
916 pushed the iterator stack, restore the internal state of the bidi
917 iterator by calling bidi_pop_it same number of times.
918 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
919 and we are bidi-iterating, don't decrement the iterator position;
920 instead, set the first_elt flag in the bidi iterator, to produce
921 the same effect.
922 (reseat_1): Remove redundant setting of string_from_display_prop_p.
923 (push_display_prop): xassert that we are iterating a buffer.
924 (push_it, pop_it): Save and restore paragraph_embedding member.
925 (handle_single_display_spec, next_overlay_string)
926 (get_overlay_strings_1, reseat_1, reseat_to_string)
927 (push_display_prop): Set up the `unibyte' member of bidi_it.string
928 correctly. Don't assume unibyte strings are not bidi-reordered.
929 (compute_display_string_pos)
930 (compute_display_string_end): Fix handling the case of C string.
931 (push_it, pop_it): Save and restore from_disp_prop_p.
932 (handle_single_display_spec, push_display_prop): Set the
933 from_disp_prop_p flag.
934 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
935 (pop_it): Call iterate_out_of_display_property only if we are
936 popping after iteration over a string that came from a display
937 property. Fix a typo in popping stretch info. Add an assertion
938 for verifying that the iterator position is in sync with the bidi
939 iterator.
940 (handle_single_display_spec, get_overlay_strings_1)
941 (push_display_prop): Fix initialization of paragraph direction for
942 string when that of the parent object is not yet determined.
943 (reseat_1): Call bidi_init_it to resync the bidi
944 iterator with IT's position. (Bug#7616)
945 (find_row_edges): If ROW->start.pos gives position
946 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
947 (handle_stop, back_to_previous_visible_line_start, reseat_1):
948 Reset the from_disp_prop_p flag.
949 (SAVE_IT, RESTORE_IT): New macros.
950 (pos_visible_p, face_before_or_after_it_pos)
951 (back_to_previous_visible_line_start)
952 (move_it_in_display_line_to, move_it_in_display_line)
953 (move_it_to, move_it_vertically_backward, move_it_by_lines)
954 (try_scrolling, redisplay_window, display_line): Use them when
955 saving a temporary copy of the iterator and restoring it back.
956 (back_to_previous_visible_line_start, reseat_1)
957 (init_iterator): Empty the bidi cache "stack".
958 (move_it_in_display_line_to): If iterator ended up at
959 EOL, but we never saw any buffer positions smaller than
960 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
961 motion in bidi-reordered lines.
962 (move_it_in_display_line_to): Record prev_method and prev_pos
963 immediately before the call to set_iterator_to_next. Fixes cursor
964 motion in bidi-reordered lines with stretch glyphs and strings
965 displayed in margins. (Bug#8133) (Bug#8867)
966 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
967 TO_CHARPOS.
968 (pos_visible_p): Support positions in bidi-reordered lines. Save
969 and restore bidi cache.
970
971 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
972 (bidi_paragraph_info): Delete unused struct.
973 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
974 (bidi_cache_start): New variable.
975 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
976 to zero.
977 (bidi_cache_fetch_state, bidi_cache_search)
978 (bidi_cache_find_level_change, bidi_cache_iterator_state)
979 (bidi_cache_find, bidi_peek_at_next_level)
980 (bidi_level_of_next_char, bidi_find_other_level_edge)
981 (bidi_move_to_visually_next): Compare cache index with
982 bidi_cache_start rather than with zero.
983 (bidi_fetch_char): Accept new argument STRING; all callers
984 changed. Support iteration over a string. Support strings with
985 display properties. Support unibyte strings. Fix the type of
986 `len' according to what STRING_CHAR_AND_LENGTH expects.
987 (bidi_paragraph_init, bidi_resolve_explicit_1)
988 (bidi_resolve_explicit, bidi_resolve_weak)
989 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
990 iteration over a string.
991 (bidi_set_sor_type, bidi_resolve_explicit_1)
992 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
993 can now be zero (for strings); special values 0 and -1 were
994 changed to -1 and -2, respectively.
995 (bidi_char_at_pos): New function.
996 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
997 Call it instead of FETCH_MULTIBYTE_CHAR.
998 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
999 initialized to valid values.
1000 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1001 values.
1002 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1003 the test for valid cached positions. Fix the logic for looking up
1004 the sentinel state in the cache. GCPRO the Lisp string we are
1005 iterating.
1006 (bidi_push_it, bidi_pop_it): New functions.
1007 (bidi_initialize): Initialize the bidi cache start stack pointer.
1008 (bidi_cache_ensure_space): New function, refactored from part of
1009 bidi_cache_iterator_state. Don't assume the required size is just
1010 one BIDI_CACHE_CHUNK away.
1011 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1012 (bidi_count_bytes, bidi_char_at_pos): New functions.
1013 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1014 always valid if bidi_cache_idx is valid.
1015 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1016 is valid if it's going to be used.
1017 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1018 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1019 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1020 (bidi_cache_iterator_state, bidi_cache_find)
1021 (bidi_find_other_level_edge, bidi_cache_start_stack): All
1022 variables related to cache indices are now EMACS_INT.
1023
0bb23927
EZ
1024 * dispextern.h (struct bidi_string_data): New structure.
1025 (struct bidi_it): New member `string'. Make flag members be 1-bit
1026 fields, and put them last in the struct.
1027 (compute_display_string_pos, compute_display_string_end): Update
1028 prototypes.
1029 (bidi_push_it, bidi_pop_it): Add prototypes.
1030 (struct iterator_stack_entry): New members bidi_p,
1031 paragraph_embedding, and from_disp_prop_p.
1032 (struct it): Member bidi_p is now a bit field 1 bit wide.
1033 (bidi_shelve_cache, bidi_unshelve_cache): Declare
1034 prototypes.
1035
1036 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1037 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1038 and vector-like objects.
1039
1040 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1041 cache around display iteration.
1042
1043 * window.c (Fwindow_end, window_scroll_pixel_based)
1044 (displayed_window_lines, Frecenter): Save and restore the bidi
1045 cache around display iteration.
1046
3bbd2265
LMI
10472011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1048
1049 * editfns.c (Fdelete_region): Clarify the use of the named
1050 parameters (bug#6788).
1051
adc47434
MR
10522011-07-14 Martin Rudalics <rudalics@gmx.at>
1053
1054 * indent.c (Fvertical_motion): Set and restore w->pointm when
1055 saving and restoring the window's buffer (Bug#9006).
1056
837c31f8
LMI
10572011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1058
1059 * editfns.c (Fstring_to_char): Clarify just what is returned
1060 (bug#6576). Text by Eli Zaretskii.
1061
ac389d0c
JB
10622011-07-13 Juanma Barranquero <lekktu@gmail.com>
1063
1064 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1065
0be0ce47
EZ
10662011-07-13 Eli Zaretskii <eliz@gnu.org>
1067
1068 * buffer.c (mmap_find): Fix a typo.
1069
cd18e7e3
JB
10702011-07-13 Johan Bockgård <bojohan@gnu.org>
1071
1072 Fix execution of x selection hooks.
1073 * xselect.c (Qx_lost_selection_functions)
1074 (Qx_sent_selection_functions): New vars.
1075 (syms_of_xselect): DEFSYM them.
1076 (x_handle_selection_request): Pass Qx_sent_selection_functions
1077 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1078 (x_handle_selection_clear,x_clear_frame_selections):
1079 Pass Qx_lost_selection_functions rather than
1080 Vx_lost_selection_functions to Frun_hook_with_args.
1081
47ea7f44
PE
10822011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1083
ac389d0c 1084 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1085 The old code sometimes used this field without initializing it.
1086
47ea7f44
PE
1087 * alloc.c (gc_sweep): Don't read past end of array.
1088 In theory, the old code could also have corrupted Emacs internals,
1089 though it'd be very unlikely.
1090
bc985c87
AS
10912011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1092
1093 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1094 argument. (Bug#4026)
bc985c87 1095
0cf34688
LMI
10962011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1097
b3dadd76
LMI
1098 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1099 key" (bug#4257).
1100
0cf34688
LMI
1101 * window.c (Fset_window_start): Doc fix (bug#4199).
1102 (Fset_window_hscroll): Ditto.
1103
270768cd
PE
11042011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1105
077e3dda 1106 Fix minor new problems caught by GCC 4.6.1.
270768cd 1107 * term.c (init_tty): Remove unused local.
490011a6 1108 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1109 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1110 not used otherwise.
270768cd 1111
b1f58454
CY
11122011-07-12 Chong Yidong <cyd@stupidchicken.com>
1113
1114 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1115
22b9578d
LMI
11162011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1117
6e70ab07
LMI
1118 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1119 are the mini-buffer and the echo area (bug#3320).
1120
22b9578d
LMI
1121 * term.c (init_tty): Remove support for supdup, c10 and perq
1122 terminals, which are no longer supported (bug#1482).
1123
8974cc9f
JB
11242011-07-10 Johan Bockgård <bojohan@gnu.org>
1125
1126 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1127
a560d974
JD
11282011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1129
1130 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1131 for non-popups (Bug#3642).
1132
1dae0f0a
AS
11332011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1134
268c2c36 1135 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1136 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1137 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1138 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1139 * data.c (fmod): Likewise.
1140 * dispnew.c (swap_glyphs_in_rows): Likewise.
1141 * emacs.c (memory_warning_signal): Likewise.
1142 * floatfns.c (float_error): Likewise.
1143 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1144 (otf_open, font_otf_capability, generate_otf_features)
1145 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1146 Likewise.
1147 * image.c (pbm_read_file): Likewise.
1148 * indent.c (string_display_width): Likewise.
1149 * intervals.c (check_for_interval, search_for_interval)
1150 (inc_interval_count, count_intervals, root_interval)
1151 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1152 * lread.c (defalias): Likewise.
268c2c36 1153 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1154 * regex.c (set_image_of_range_1, set_image_of_range)
1155 (regex_grow_registers): Likewise.
1156 * sysdep.c (strerror): Likewise.
1157 * termcap.c (valid_filename_p, tprint, main): Likewise.
1158 * tparam.c (main): Likewise.
1159 * unexhp9k800.c (run_time_remap, save_data_space)
1160 (update_file_ptrs, read_header, write_header, calculate_checksum)
1161 (copy_file, copy_rest, display_header): Likewise.
1162 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1163 Likewise.
1164 * xdisp.c (check_it): Likewise.
1165 * xfaces.c (register_color, unregister_color, unregister_colors):
1166 Likewise.
1167 * xfns.c (print_fontset_result): Likewise.
1168 * xrdb.c (member, fatal, main): Likewise.
1169
99033785
PE
11702011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1171
1172 Fix minor problems found by static checking (Bug#9031).
1173 * chartab.c (char_table_set_range, map_sub_char_table):
1174 Remove unused locals.
1175 (uniprop_table): Now static.
1176 * composite.c (_work_char): Remove unused static var.
1177
9cb2ac56
JB
11782011-07-09 Juanma Barranquero <lekktu@gmail.com>
1179
1180 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1181
f25661f0
JD
11822011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1183
1184 * gtkutil.c (qttip_cb): Remove code without function.
1185
8278c4fe
EZ
11862011-07-09 Eli Zaretskii <eliz@gnu.org>
1187
1188 * w32.c (pthread_sigmask): New stub.
1189
1692ae2d 11902011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1191
8a6ebd58 1192 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1193 sigprocmask is portable only for single-threaded applications, and
1194 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1195 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1196 (LIBES): Use it.
1197 * callproc.c (Fcall_process):
1198 * process.c (create_process):
1199 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1200 Use pthread_sigmask, not sigprocmask.
123403e4 1201
1b854618
JD
12022011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1203
1204 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1205 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1206 wrong (Bug#8591).
1207
3fe4b549
JD
12082011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1209
0ce7e563
JD
1210 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1211 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1212 (xg_hide_tooltip): Fix comment.
1213
3fe4b549
JD
1214 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1215 in registerServicesMenuSendTypes.
1216 (validRequestorForSendType): Don't check ns_return_types.
1217
1218 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1219 ns_return_type.
1220
5df75e47
JR
12212011-07-08 Jason Rumney <jasonr@gnu.org>
1222
1223 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1224 frame struct members of non-existent frames (Bug#6284).
1225
699c10bd
JD
12262011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1227
4393663b
JD
1228 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1229 variable firstTime not needed on OSX >= 10.6.
1230 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1231 >= 10.5. Use setKnobProportion, setDoubleValue.
1232
1233 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1234 (MAC_OS_X_VERSION_10_5): Define if not defined.
1235 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1236 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1237 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1238
1239 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1240 cString and lossyCString on OSX >= 10.4
1241
1242 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1243 sizeToFit on OSX >= 10.2.
1244
1245 * nsimage.m (allocInitFromFile): Don't use deprecated method
1246 bestRepresentationForDevice on OSX >= 10.6.
1247
1248 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1249 to avoid warning.
1250
1251 * emacs.c: Declare unexec_init_emacs_zone.
1252
a63e0781
JD
1253 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1254
699c10bd
JD
1255 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1256
1257 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1258 on svcsMenu (Bug#8842).
1259
1260 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1261 ns_return_types.
1262 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1263
1264 * nsterm.m (QUTF8_STRING): Declare.
1265 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1266 (validRequestorForSendType): Return type is (id).
1267 Change indexOfObjectIdenticalTo to indexOfObject.
1268 Check if we have local selection before returning self (Bug#8842).
1269 (writeSelectionToPasteboard): Put local selection into paste board
1270 if we have a local selection (Bug#8842).
1271 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1272
1273 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1274 (ns_get_local_selection): Declare.
1275
54e10184
LMI
12762011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1277
9888ff71
LMI
1278 * keymap.c (describe_map_tree): Don't insert a double newline at
1279 the end of the buffer (bug#1169) and return whether we inserted
1280 something.
1281
54e10184
LMI
1282 * callint.c (Fcall_interactively): Change "reading args" to
1283 "providing args" to try to clarify what it does (bug#1010).
1284
15fa4783
KH
12852011-07-07 Kenichi Handa <handa@m17n.org>
1286
1287 * composite.c (composition_compute_stop_pos): Ignore a static
1288 composition starting before CHARPOS (Bug#8915).
1289
1290 * xdisp.c (handle_composition_prop): Likewise.
1291
a8815b00
EZ
12922011-07-07 Eli Zaretskii <eliz@gnu.org>
1293
1294 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1295 (Bug#9015)
1296
ef7b981d 12972011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1298
1299 * character.h (unicode_category_t): New enum type.
1300
1301 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1302 (Qchar_code_property_table): New variable.
1303 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1304 (UNIPROP_COMPRESSED_FORM_P): New macros.
1305 (char_table_ascii): Uncompress the compressed values.
1306 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1307 Uncompress the compressed values.
ac389d0c 1308 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1309 (char_table_ref_and_range): Uncompress the compressed values.
1310 (sub_char_table_set): New arg is_uniprop. Callers changed.
1311 Uncompress the compressed values.
1312 (sub_char_table_set_range): Args changed. Callers changed.
1313 (char_table_set_range): Adjuted for the above change.
1314 (map_sub_char_table): Delete args default_val and parent. Add arg
1315 top. Give decoded values to a Lisp function.
1316 (map_char_table): Adjusted for the above change. Give decoded
1317 values to a Lisp function. Gcpro more variables.
1318 (uniprop_table_uncompress)
1319 (uniprop_decode_value_run_length): New functions.
1320 (uniprop_decoder, uniprop_decoder_count): New variables.
1321 (uniprop_get_decoder, uniprop_encode_value_character)
1322 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1323 New functions.
1324 (uniprop_encoder, uniprop_encoder_count): New variables.
1325 (uniprop_get_encoder, uniprop_table)
1326 (Funicode_property_table_internal, Fget_unicode_property_internal)
1327 (Fput_unicode_property_internal): New functions.
1328 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1329 Sunicode_property_table_internal, Sget_unicode_property_internal,
1330 and Sput_unicode_property_internal. Defvar_lisp
1331 char-code-property-alist.
1332
1333 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1334 Vunicode_category_table.
1335
1336 * font.c (font_range): Adjusted for the change of
1337 Vunicode_category_table.
1338
76b397fb
DN
13392011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1340
1341 * m/iris4d.h: Remove file, move contents ...
1342 * s/irix6-5.h: ... here.
1343
22b4128e
PE
13442011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1345
1346 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1347 * alloc.c (mark_buffer):
1348 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1349 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1350 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1351 This isn't true in general, and it's particularly not true
1352 if Emacs is configured with --with-wide-int.
1353 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1354 New macros, used in the buffer.c change.
1355
869795d6
JD
13562011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1357
1358 * xsettings.c: Use both GConf and GSettings if both are available.
1359 (store_config_changed_event): Add comment.
1360 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1361 (store_tool_bar_style_changed): New functions.
1362 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1363 (struct xsettings): Move font inside HAVE_XFT.
1364 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1365 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1366 Move inside HAVE_XFT.
1367 (something_changed_gsettingsCB): Renamed from something_changedCB.
1368 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1369 also.
1370 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1371 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1372 (something_changed_gconfCB): Renamed from something_changedCB.
1373 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1374 (parse_settings): Move check for font inside HAVE_XFT.
1375 (read_settings, apply_xft_settings): Add comment.
1376 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1377 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1378 call store_font_name_changed.
1379 (xft_settings_event): Add comment.
1380 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1381 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1382 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1383 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1384 (xsettings_initialize): Call init_gsettings last.
1385 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1386 comment.
1387
d8ed26bd
PE
13882011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1389
1390 Random fixes. E.g., (random) never returned negative values.
1391 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1392 subseconds part to the entropy, as that's a bit more random.
1393 Prefer signed to unsigned, since the signedness doesn't matter and
1394 in general we prefer signed. When given a limit, use a
1395 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1396 latter isn't right if USE_2_TAGS_FOR_INTS.
1397 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1398 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1399
cabf1cac
SM
14002011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1401
1402 * textprop.c (text_property_stickiness):
1403 Obey Vtext_property_default_nonsticky.
1404 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1405 * w32fns.c (syms_of_w32fns):
1406 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1407
6e9b2be9
PE
14082011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1409
1410 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1411 This is more efficient than Ffile_directory_p and avoids a minor race.
1412
90186c68
LMI
14132011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1414
7c301272
LMI
1415 * buffer.c (Foverlay_put): Say what the return value is
1416 (bug#7835).
1417
c4f2d8d4
LMI
1418 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1419 is a directory before asking whether to use the file name
1420 (bug#7564).
ad637907
LMI
1421 (barf_or_query_if_file_exists): Make the "File is a directory"
1422 error be more correct.
c4f2d8d4 1423
90186c68
LMI
1424 * fns.c (Frequire): Remove the mention of the .gz files, since
1425 that's installation-specific, but keep the mention of
1426 `get-load-suffixes'.
1427
da64016e
PE
14282011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1429
1430 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1431 Report string overflow if the output is too long.
1432
7d47b580
JB
14332011-07-04 Juanma Barranquero <lekktu@gmail.com>
1434
a555cb87
JB
1435 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1436 (syms_of_gnutls): Remove duplicate DEFSYM for
1437 Qgnutls_bootprop_verify_hostname_error, an error for
1438 Qgnutls_bootprop_verify_error (which is no longer used).
1439
7d47b580
JB
1440 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1441 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1442 Also (re)move comments that are misplaced or no longer relevant.
1443
1e49bfab
LMI
14442011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1445
1446 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1447
1485f4c0
CY
14482011-07-03 Chong Yidong <cyd@stupidchicken.com>
1449
1450 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1451 and background color parameters if they have been changed.
1452
a9ab721e
LMI
14532011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1454
1455 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1456
cf7cff57
PE
14572011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1458
2e13213d
PE
1459 * xsettings.c (SYSTEM_FONT): Define only when used.
1460 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1461
cf7cff57
PE
1462 * keymap.c (access_keymap_1): Now static.
1463
7a8e04f7
CY
14642011-07-02 Chong Yidong <cyd@stupidchicken.com>
1465
1466 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1467 leave any prefix arg for the up event (Bug#1586).
1468
61352f62
LMI
14692011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1470
69bb1ef7
LMI
1471 * lread.c (syms_of_lread): Mention single symbols defined by
1472 `defvar' or `defconst' (bug#7154).
1473
61352f62 1474 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1475 (Frequire): Mention get-load-suffixes.
61352f62 1476
28545e04
MR
14772011-07-02 Martin Rudalics <rudalics@gmx.at>
1478
1479 * window.h (window): Remove clone_number slot.
1480 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1481 Remove.
1482 (make_parent_window, make_window, saved_window)
1483 (Fset_window_configuration, save_window_save): Don't deal with
1484 clone numbers.
1485 * buffer.c (Qclone_number): Remove declaration.
1486 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1487
3349e122
SM
14882011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1489
1490 Add multiple inheritance to keymaps.
1491 * keymap.c (Fmake_composed_keymap): New function.
1492 (Fset_keymap_parent): Simplify.
1493 (fix_submap_inheritance): Remove.
1494 (access_keymap_1): New function extracted from access_keymap to handle
1495 embedded parents and handle lists of maps.
1496 (access_keymap): Use it.
1497 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1498 (Fcopy_keymap): Handle embedded parents.
1499 (Fcommand_remapping, define_as_prefix): Simplify.
1500 (Fkey_binding): Simplify.
1501 (syms_of_keymap): Move minibuffer-local-completion-map,
1502 minibuffer-local-filename-completion-map,
1503 minibuffer-local-must-match-map, and
1504 minibuffer-local-filename-must-match-map to Elisp.
1505 (syms_of_keymap): Defsubr make-composed-keymap.
1506 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1507 (parse_menu_item): Trivial simplification.
1508
3279eb87
GM
15092011-07-01 Glenn Morris <rgm@gnu.org>
1510
1511 * Makefile.in (SETTINGS_LIBS): Fix typo.
1512
4550efdf
KI
15132011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1514
1515 * coding.c (Fencode_coding_string): Record the last coding system
1516 used, as the function doc string says (bug#8738).
1517
0949d2b6
JD
15182011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1519
1520 * xsettings.c (store_monospaced_changed): Take new font as arg and
1521 check for change against current_mono_font.
1522 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1523 (emacs_settings_constructor, emacs_settings_get_property)
1524 (emacs_settings_set_property, emacs_settings_class_init)
1525 (emacs_settings_init, gsettings_obj): Remove.
1526 (something_changedCB): New function for HAVE_GSETTINGS.
1527 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1528 with value as argument.
1529 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1530 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1531 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1532 "changed".
1533
1534 * xgselect.c: Add defined (HAVE_GSETTINGS).
1535 (xgselect_initialize): Ditto.
1536
1537 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1538 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1539 xg_select.
1540
bbc6b304
PE
15412011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1542
1543 * eval.c (struct backtrace): Simplify and port the data structure.
1544 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1545 signed bit field, as this assumption is not portable and it makes
1546 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1547 "char debug_on_exit : 1" as this is not portable either; instead,
1548 use the portable "unsigned int debug_on_exit : 1". Remove unused
1549 member evalargs. Remove obsolete comments about cc bombing out.
1550
9851bfc5
JD
15512011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1552
51bb811f 1553 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1554 Let HAVE_GSETTINGS override HAVE_GCONF.
1555 (store_monospaced_changed): New function.
1556 (EMACS_SETTINGS): A new type derived from GObject to handle
1557 GSettings notifications.
1558 (emacs_settings_constructor, emacs_settings_get_property)
1559 (emacs_settings_set_property, emacs_settings_class_init):
1560 New functions.
1561 (gsettings_client, gsettings_obj): New variables.
1562 (GSETTINGS_SCHEMA): New define.
1563 (something_changedCB): Call store_monospaced_changed.
1564 (init_gsettings): New function.
1565 (xsettings_initialize): Call init_gsettings.
1566 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1567 to NULL.
1568
1569 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1570 GCONF_CFLAGS/LIBS.
1571
5386012d
MR
15722011-06-29 Martin Rudalics <rudalics@gmx.at>
1573
1574 * window.c (resize_root_window, grow_mini_window)
1575 (shrink_mini_window): Rename Qresize_root_window to
1576 Qwindow_resize_root_window and Qresize_root_window_vertically to
1577 Qwindow_resize_root_window_vertically.
1578
f13e0b08
PE
15792011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1580
1581 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1582
94515237
JB
15832011-06-27 Juanma Barranquero <lekktu@gmail.com>
1584
1585 * makefile.w32-in: Redesign dependencies so they reflect more
1586 clearly which files are directly included by each source file,
1587 and not through other includes.
1588
e43b6e43
MR
15892011-06-27 Martin Rudalics <rudalics@gmx.at>
1590
1591 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1592 (sort_overlays, overlay_strings): When an overlay's clone number
1593 matches the window's clone number process the overlay even if
1594 the overlay's window property doesn't match the current window.
1595
d68443dc
MR
1596 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1597 (Fwindow_hchild): Rename to Fwindow_left_child.
1598 (Fwindow_next): Rename to Fwindow_next_sibling.
1599 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1600 (resize_window_check): Rename to window_resize_check.
1601 (resize_window_apply): Rename to window_resize_apply.
1602 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1603 (Fdelete_other_windows_internal, resize_frame_windows)
1604 (Fsplit_window_internal, Fdelete_window_internal)
1605 (grow_mini_window, shrink_mini_window)
1606 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1607
c7e73be5
JD
16082011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1609
1610 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1611 (emacs_fixed_set_min_size): Remove.
1612 (emacs_fixed_new): Take frame as argument.
1613
1614 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1615 (_EmacsFixedPrivate): Remove minwidth/height.
1616 Add struct frame *f.
1617 (emacs_fixed_init): Initialize priv->f.
1618 (get_parent_class, emacs_fixed_set_min_size): Remove.
1619 (emacs_fixed_new): Set priv->f to argument.
1620 (emacs_fixed_get_preferred_width)
1621 (emacs_fixed_get_preferred_height): Use min_width/height from
1622 frames size_hint to set minimum and natural (Bug#8919).
1623 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1624 and use min_width/height from frames size_hint to set
1625 min_width/height (Bug#8919).
1626
1627 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1628 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1629 Fix indentation.
c7e73be5 1630
cf99dcf8
EZ
16312011-06-26 Eli Zaretskii <eliz@gnu.org>
1632
1633 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1634 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1635 called at ZV.
1636
029529ac
CY
16372011-06-26 Chong Yidong <cyd@stupidchicken.com>
1638
1639 * process.c (wait_reading_process_output): Bypass select if
1640 waiting for a cell while ignoring keyboard input, and input is
1641 pending. Suggested by Jan Djärv (Bug#8869).
1642
7a7ef429
PE
16432011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1644
1645 Use gnulib's dup2 module instead of rolling our own.
1646 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1647
11fdef7d 16482011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1649
1650 * dispnew.c (scrolling_window): Before scrolling, turn off a
1651 mouse-highlight in the window being scrolled.
1652
cd3520a4
JB
16532011-06-24 Juanma Barranquero <lekktu@gmail.com>
1654
1655 Move DEFSYM to lisp.h and use everywhere.
1656
1657 * character.h (DEFSYM): Move declaration...
1658 * lisp.h (DEFSYM): ...here.
1659
1660 * gnutls.c:
1661 * minibuf.c:
1662 * w32menu.c:
1663 * w32proc.c:
1664 * w32select.c: Don't include character.h.
1665
1666 * alloc.c (syms_of_alloc):
1667 * buffer.c (syms_of_buffer):
1668 * bytecode.c (syms_of_bytecode):
1669 * callint.c (syms_of_callint):
1670 * casefiddle.c (syms_of_casefiddle):
1671 * casetab.c (init_casetab_once):
1672 * category.c (init_category_once, syms_of_category):
1673 * ccl.c (syms_of_ccl):
1674 * cmds.c (syms_of_cmds):
1675 * composite.c (syms_of_composite):
1676 * dbusbind.c (syms_of_dbusbind):
1677 * dired.c (syms_of_dired):
1678 * dispnew.c (syms_of_display):
1679 * doc.c (syms_of_doc):
1680 * editfns.c (syms_of_editfns):
1681 * emacs.c (syms_of_emacs):
1682 * eval.c (syms_of_eval):
1683 * fileio.c (syms_of_fileio):
1684 * fns.c (syms_of_fns):
1685 * frame.c (syms_of_frame):
1686 * fringe.c (syms_of_fringe):
1687 * insdel.c (syms_of_insdel):
1688 * keymap.c (syms_of_keymap):
1689 * lread.c (init_obarray, syms_of_lread):
1690 * macros.c (syms_of_macros):
1691 * msdos.c (syms_of_msdos):
1692 * print.c (syms_of_print):
1693 * process.c (syms_of_process):
1694 * search.c (syms_of_search):
1695 * sound.c (syms_of_sound):
1696 * syntax.c (init_syntax_once, syms_of_syntax):
1697 * terminal.c (syms_of_terminal):
1698 * textprop.c (syms_of_textprop):
1699 * undo.c (syms_of_undo):
1700 * w32.c (globals_of_w32):
1701 * window.c (syms_of_window):
1702 * xdisp.c (syms_of_xdisp):
1703 * xfaces.c (syms_of_xfaces):
1704 * xfns.c (syms_of_xfns):
1705 * xmenu.c (syms_of_xmenu):
1706 * xsettings.c (syms_of_xsettings):
1707 * xterm.c (syms_of_xterm): Use DEFSYM.
1708
4228cf16
TZ
17092011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1710
cd3520a4 1711 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1712
7fcccf1e
PE
17132011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1714
7efb4e0e
PE
1715 Integer and buffer overflow fixes (Bug#8873).
1716
ff5844ad
PE
1717 * print.c (printchar, strout): Check for string overflow.
1718 (PRINTPREPARE, printchar, strout):
1719 Don't set size unless allocation succeeds.
1720
90532f02
PE
1721 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1722 for sizes. Check for string overflow more accurately.
1723 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1724
6d84508d
PE
1725 * macros.c: Integer and buffer overflow fixes.
1726 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1727 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1728 Use ptrdiff_t, not int, for sizes.
1729 Don't increment bufsize until after realloc succeeds.
1730 Check for size-calculation overflow.
1731 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1732
437b2cb4
PE
1733 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1734
8b9ac8b4
PE
1735 * lread.c: Integer overflow fixes.
1736 (read_integer): Radix is now EMACS_INT, not int,
1737 to improve quality of diagnostics for out-of-range radices.
1738 Calculate buffer size correctly for out-of-range radices.
1739 (read1): Check for integer overflow in radices, and in
1740 read-circle numbers.
82cb60d3
PE
1741 (read_escape): Avoid int overflow.
1742 (Fload, openp, read_buffer_size, read1)
1743 (substitute_object_recurse, read_vector, read_list, map_obarray):
1744 Use ptrdiff_t, not int, for sizes.
1745 (read1): Use EMACS_INT, not int, for sizes.
20270765 1746 Check for size overflow.
8b9ac8b4 1747
7fcccf1e
PE
1748 * image.c (cache_image): Check for size arithmetic overflow.
1749
bfbbd7e7
PE
1750 * lread.c: Integer overflow issues.
1751 (saved_doc_string_size, saved_doc_string_length)
1752 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1753 Now ptrdiff_t, not int.
1754 (read1): Don't assume doc string length fits in int. Check for
1755 out-of-range doc string lengths.
1756 (read_list): Don't assume file position fits in int.
39019e54 1757 (read_escape): Check for hex character overflow.
bfbbd7e7 1758
4e323265
LL
17592011-06-22 Leo Liu <sdl.web@gmail.com>
1760
1761 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1762 Move to minibuffer.el.
1763
85fece3e
PE
17642011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1765
20b84ce9 1766 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1767 The following patches are for when GLYPH_DEBUG && !XASSERT.
1768 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1769 * dispnew.c (flush_stdout):
1770 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1771 Mark as externally visible.
1772 * dispnew.c (check_window_matrix_pointers): Now static.
1773 * dispnew.c (window_to_frame_vpos):
1774 * xfns.c (unwind_create_frame):
1775 * xterm.c (x_check_font): Remove unused local.
1776 * scroll.c (CHECK_BOUNDS):
1777 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1778 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1779 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1780 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1781 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1782 Now static.
1783 (debug_method_add): Use va_list and vsprintf rather than relying
1784 on undefined behavior with wrong number of arguments.
1785 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1786 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1787 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1788 since we're not interested in debugging glyphs with old libraries.
1789 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1790 GCC 4.6.0's static checking.
1791
0766b489
PE
17922011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1793
31fd4b32
PE
1794 Integer overflow and signedness fixes (Bug#8873).
1795 A few related buffer overrun fixes, too.
1796
b79e8648
PE
1797 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1798
0766b489
PE
1799 * dispextern.h (struct face.stipple):
1800 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1801 (x_bitmap_mask, x_allocate_bitmap_record)
1802 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1803 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1804 (x_create_bitmap_from_xpm_data):
1805 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1806 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1807 (.bitmaps_last):
1808 * xfaces.c (load_pixmap):
1809 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1810 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1811 (.bitmaps_last, struct x_output.icon_bitmap):
1812 Use ptrdiff_t, not int, for bitmap indexes.
1813 (x_allocate_bitmap_record): Check for size overflow.
1814 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1815
b081724f
PE
1816 Use ptrdiff_t, not int, for overlay counts.
1817 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1818 * editfns.c (overlays_around, get_pos_property):
1819 * textprop.c (get_char_property_and_overlay):
1820 * xdisp.c (next_overlay_change, note_mouse_highlight):
1821 * xfaces.c (face_at_buffer_position):
21514da7
PE
1822 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1823 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1824 (Fnext_overlay_change, Fprevious_overlay_change)
1825 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1826 Use ptrdiff_t, not int, for sizes.
21514da7 1827 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1828
3de73e5e
PE
1829 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1830
2606c57b
PE
1831 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1832 (x_session_initialize): Do not assume string length fits in int.
1833
aaafe47a
PE
1834 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1835 This is unlikely, but can occur if DPI is outlandish.
1836
2674ddc8 1837 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1838 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1839
28154962
PE
1840 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1841 * xrdb.c (magic_file_p, search_magic_path):
1842 Omit last arg SUFFIX; it was always 0. All callers changed.
1843 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1844
7de51af5
PE
1845 * xfont.c (xfont_match): Avoid need for strlen.
1846
25ed6cc3
PE
1847 * xfns.c: Don't assume strlen fits in int.
1848 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1849
4eab31dd
PE
1850 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1851 not unsigned long, as we prefer signed integers. All callers changed.
1852 Detect integer overflow in repeat count.
1853 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1854 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1855
171e2a58
PE
1856 * termcap.c: Don't assume sizes fit in int and never overflow.
1857 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1858 (gobble_line): Check for size-calculation overflow.
1859
ad39faca 1860 * minibuf.c (Fread_buffer):
6e5bb2dc 1861 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1862 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1863 Don't assume string length fits in int.
1864
52c61c22 1865 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1866 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1867
b5b8c9e5
PE
1868 * font.c: Don't assume string length fits in int.
1869 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1870 Use ptrdiff_t, not int.
ccd6111c
PE
1871 (font_intern_prop): Don't assume string length fits in int.
1872 Don't assume integer property fits in fixnum.
1873 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1874
882f0d81 1875 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1876 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1877 Reformulate so as not to need the command string.
1878 Invoke gzip -cd rather than gunzip, as it's more portable.
1879 (lock_info_type, lock_file_1, lock_file):
1880 Don't assume pid_t and time_t fit in unsigned long.
1881 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1882 (current_lock_owner): Prefer signed type for sizes.
1883 Use memcpy, not strncpy, where memcpy is what is really wanted.
1884 Don't assume (via atoi) that time_t and pid_t fit in int.
1885 Check for time_t and/or pid_t out of range, e.g., via a network share.
1886 Don't alloca where an auto var works fine.
1887
93f4cf88
PE
1888 * fileio.c: Fix some integer overflow issues.
1889 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1890 Don't assume string length fits in int.
1891 (directory_file_name): Don't assume string length fits in long.
1892 (make_temp_name): Don't assume pid fits in int, or that its print
1893 length is less than 20.
1894
f3e92b69
PE
1895 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1896
1bfdaf10
PE
1897 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1898
35016e9a
PE
1899 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1900
3d1e65a1
PE
1901 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1902 We prefer signed integers, even for size calculations.
1903
0b963a93
PE
1904 * emacs.c: Don't assume string length fits in 'int'.
1905 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1906 (main): Don't invoke strlen when not needed.
1907
573f4b54
PE
1908 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1909 (XD_DEBUG_MESSAGE): Don't waste a byte.
1910
989f33ba
PE
1911 * callproc.c (getenv_internal_1, getenv_internal)
1912 (Fgetenv_internal):
965d34eb
PE
1913 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1914
e4d29b33
PE
1915 * lread.c (invalid_syntax): Omit length argument.
1916 All uses changed. This doesn't fix a bug, but it simplifies the
1917 code away from its former Hollerith-constant appearance, and it's
1918 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1919 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1920
eb49b136
PE
1921 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1922 This didn't break anything, but it didn't help either.
1923 It's confusing to put a bogus integer in a place where the actual
1924 value does not matter.
9f62aeb1 1925 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1926 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1927
15375a22
PE
1928 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1929 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1930 implementation.
b61cc01c
PE
1931 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1932 We prefer signed types, and the value cannot exceed the EMACS_INT
1933 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1934 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1935 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1936 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1937
53b2623d
PE
1938 * indent.c (sane_tab_width): New function.
1939 (current_column, scan_for_column, Findent_to, position_indentation)
1940 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1941 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1942
51cab52b 1943 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1944
f2ed8a70
PE
1945 * lisp.h (lint_assume): New macro.
1946 * composite.c (composition_gstring_put_cache):
1947 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1948
abe80cc6
PE
1949 * editfns.c, insdel.c:
1950 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1951
b02c740e
PE
1952 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1953
ebc96716
PE
1954 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1955
b4e50fa0 1956 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1957 Use much-faster test for byte-length change.
311d5d7c 1958 Don't assume string byte-length fits in 'int'.
a4cf38e4 1959 Check that character arg fits in 'int'.
85461888 1960 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1961
c0c1ee9f
PE
1962 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1963
a498d7f4
PE
1964 * fns.c (concat): Catch string overflow earlier.
1965 Do not rely on integer wraparound.
1966
51cab52b
PE
1967 * dispextern.h (struct it.overlay_strings_charpos)
1968 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1969 * xdisp.c (forward_to_next_line_start)
1970 (back_to_previous_visible_line_start)
1971 (reseat_at_next_visible_line_start, next_element_from_buffer):
1972 Don't arbitrarily truncate the value of 'selective' to int.
1973
76031fad
PE
1974 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1975
5eb55db9
PE
1976 * composite.c: Don't truncate sizes to 'int'.
1977 (composition_gstring_p, composition_reseat_it)
1978 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1979 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1980 not EMACS_UINT, for indexes.
5eb55db9 1981
0703a717
PE
1982 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1983
d6202519
PE
1984 * buffer.c: Include <verify.h>.
1985 (struct sortvec.priority, struct sortstr.priority):
8961a454 1986 Now EMACS_INT, not int.
c20998a7 1987 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1988 (struct sortstr.size, record_overlay_string)
1989 (struct sortstrlist.size, struct sortlist.used):
1990 Don't truncate size to int.
1991 (record_overlay_string): Check for size-calculation overflow.
d6202519 1992 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1993
d5a19415
JM
19942011-06-22 Jim Meyering <meyering@redhat.com>
1995
029529ac 1996 Don't leak an XBM-image-sized buffer
d5a19415
JM
1997 * image.c (xbm_load): Free the image buffer after using it.
1998
a9041e6c
PE
19992011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2000
2001 Port to Sun C.
2002 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2003 that Sun C diagnosed.
2004 * fns.c (secure_hash): Fix pointer signedness issue.
2005 * intervals.c (static_offset_intervals): New function.
2006 (offset_intervals): Use it.
2007
7f3f739f
LL
20082011-06-21 Leo Liu <sdl.web@gmail.com>
2009
2010 * deps.mk (fns.o):
2011 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2012 sha512.h.
2013
2014 * fns.c (secure_hash): Rename from crypto_hash_function and change
2015 the first arg to accept symbols.
5b66d427 2016 (Fsecure_hash): New primitive.
7f3f739f
LL
2017 (syms_of_fns): New symbols.
2018
76147d94
DD
20192011-06-20 Deniz Dogan <deniz@dogan.se>
2020
2021 * process.c (Fset_process_buffer): Clarify return value in
2022 docstring.
2023
7d7d0045
CY
20242011-06-18 Chong Yidong <cyd@stupidchicken.com>
2025
2026 * dispnew.c (add_window_display_history): Use BVAR.
2027
2028 * xdisp.c (debug_method_add): Use BVAR.
2029 (check_window_end, dump_glyph_matrix, dump_glyph)
2030 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2031
2032 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2033 Likewise.
2034
2035 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2036 check till after the cache is created in init_frame_faces.
2037
ff2bc410
SM
20382011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2039
2040 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2041
28177add
PE
20422011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2043
dd3482fe
PE
2044 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2045 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2046 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2047
393d71f3 2048 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2049 * fileio.c (Finsert_file_contents):
2050 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2051 Remove the old (too-loose) buffer overflow checks.
2052 They weren't needed, since make_gap checks for buffer overflow.
2053 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2054 The old code merely checked for Emacs fixnum overflow, and relied
2055 on undefined (wraparound) behavior. The new code avoids undefined
2056 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2057
2e6813b0 2058 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2059 Tune. Don't use wider integers than needed. Don't use alloca.
2060 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2061
599a9e4f
PE
2062 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2063
99561444
PE
2064 * insdel.c, lisp.h (buffer_overflow): New function.
2065 (insert_from_buffer_1, replace_range, replace_range_2):
2066 * insdel.c (make_gap_larger):
2067 * editfns.c (Finsert_char):
2068 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2069
28177add
PE
2070 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2071
e69dafad
PE
20722011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2073
a7af7fde 2074 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2075
b1c46f02
PE
2076 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2077 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2078
e69dafad
PE
2079 * fileio.c: Don't assume EMACS_INT fits in off_t.
2080 (emacs_lseek): New static function.
2081 (Finsert_file_contents, Fwrite_region): Use it.
2082 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2083
566684ea
PE
2084 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2085
e6966cd6
PE
2086 * fns.c: Don't overflow int when computing a list length.
2087 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2088 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2089 truncation on 64-bit hosts. Check for QUIT every
2090 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2091 faster and is responsive enough.
2092 (Flength): Report an error instead of overflowing an integer.
2093 (Fsafe_length): Return a float if the value is not representable
2094 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2095 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2096 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2097
dd0b0efb
PE
2098 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2099 (header_size, word_size): New constants.
2100 (allocate_vectorlike): Don't check size overflow here.
2101 (allocate_vector): Check it here instead, since this is the only
2102 caller of allocate_vectorlike that could cause overflow.
2103 Check that the new vector's length is representable as a fixnum.
2104
86fe5cfe
PE
2105 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2106 The previous code was bogus. For example, next_almost_prime (32)
2107 returned 39, which is undesirable as it is a multiple of 3; and
2108 next_almost_prime (24) returned 25, which is a multiple of 5 so
2109 why was the code bothering to check for multiples of 7?
2110
80e88859
PE
2111 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2112
4a2f0ad6
PE
2113 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2114
f66c7cf8
PE
2115 Variadic C functions now count arguments with ptrdiff_t.
2116 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2117 Back then I didn't know that the Emacs coding style prefers signed int.
2118 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2119 were being counted with int, which may truncate counts on 64-bit
2120 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2121 * lisp.h (struct Lisp_Subr.function.aMANY)
2122 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2123 Arg counts are now ptrdiff_t, not size_t.
2124 All variadic functions and their callers changed accordingly.
2125 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2126 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2127 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2128 * callint.c (Fcall_interactively): Check arg count for overflow,
2129 to avoid potential buffer overrun. Use signed char, not 'int',
2130 for 'varies' array, so that we needn't bother to check its size
2131 calculation for overflow.
2132 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2133 * eval.c (apply_lambda):
2134 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2135 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2136 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2137
a1759b76
PE
2138 * callint.c (Fcall_interactively): Don't use index var as event count.
2139
d96be9fc
PE
2140 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2141 * mem-limits.h (SIZE): Remove; no longer used.
2142
a690a978 2143 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2144
578c21e6
PE
2145 Remove unnecessary casts.
2146 * xterm.c (x_term_init):
2147 * xfns.c (x_set_border_pixel):
2148 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2149 These aren't needed now that we assume ANSI C.
2150
96f53c6c
PE
2151 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2152 It's more likely to cause problems (due to unsigned overflow)
2153 than to cure them.
2154
83c77d31
PE
2155 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2156
ee2079f1
PE
2157 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2158
6da65536
PE
2159 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2160
7147c4a4
PE
2161 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2162
193e32d9
PE
2163 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2164
e5533da6
PE
2165 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2166
9910e595
PE
2167 GLYPH_CODE_FACE returns EMACS_INT, not int.
2168 * dispextern.h (merge_faces):
2169 * xfaces.c (merge_faces):
01103c44
PE
2170 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2171 Don't assume EMACS_INT fits in int.
9910e595 2172
2638320e
PE
2173 * character.h (CHAR_VALID_P): Remove unused parameter.
2174 * fontset.c, lisp.h, xdisp.c: All uses changed.
2175
045eb8d9
PE
2176 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2177
c1f134b5
PE
2178 * fns.c (concat): Minor tuning based on overflow analysis.
2179 This doesn't fix any bugs. Use int to hold character, instead
2180 of constantly refetching from Emacs object. Use XFASTINT, not
2181 XINT, for value known to be a character. Don't bother comparing
2182 a single byte to 0400, as it's always less.
2183
395fcb93 2184 * floatfns.c (Fexpt):
327eeec8
PE
2185 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2186
abbd3d23
PE
2187 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2188 for characters.
2189
684a03ef
PE
2190 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2191
0fed43f3
PE
2192 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2193 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2194 incorrectly succeed when S was a string, because 4294967386 was
2195 truncated before it was used.
2196
8fd02eb7
PE
2197 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2198 Otherwise, an out-of-range integer could cause undefined behavior
2199 on a 64-bit host.
2200
f8c86b69
PE
2201 * composite.c: Use int, not EMACS_INT, for characters.
2202 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2203 EMACS_INT, for values that are known to be in character range.
2204 This doesn't fix any bugs but is the usual style inside Emacs and
2205 may generate better code on 32-bit machines.
2206
34206dd2
PE
2207 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2208 This is for reasons similar to the recent CHAR_STRING fix.
2209 * charset.c (Fencode_char): Check that character arg is actually
2210 a character. Pass an int to ENCODE_CHAR.
2211 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2212 wider than 'int', as a compile-time check to prevent future regressions
2213 in this area.
2214
c5958d4c 2215 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2216
2217 Make sure a 64-bit char is never passed to CHAR_STRING.
2218 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2219 by silently ignoring the top 32 bits, allowing some values
2220 that were far too large to be valid characters.
2221 * character.h: Include <verify.h>.
2222 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2223 arguments are no wider than unsigned, as a compile-time check
2224 to prevent future regressions in this area.
2225 * data.c (Faset):
01103c44 2226 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2227 (Fsubst_char_in_region):
2228 * fns.c (concat):
2229 * xdisp.c (decode_mode_spec_coding):
2230 Adjust to CHAR_STRING's new requirement.
2231 * editfns.c (Finsert_char, Fsubst_char_in_region):
2232 * fns.c (concat): Check that character args are actually
2233 characters. Without this test, these functions did the wrong
2234 thing with wildly out-of-range values on 64-bit hosts.
2235
d37ca623
PE
2236 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2237 These casts should not be needed on 32-bit hosts, either.
2238 * keyboard.c (read_char):
2239 * lread.c (Fload): Remove casts to unsigned.
2240
ea204efb
PE
2241 * lisp.h (UNSIGNED_CMP): New macro.
2242 This fixes comparison bugs on 64-bit hosts.
2243 (ASCII_CHAR_P): Use it.
2244 * casefiddle.c (casify_object):
01103c44 2245 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2246 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2247 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2248 * dispextern.h (FACE_FROM_ID):
2249 * keyboard.c (read_char): Use UNSIGNED_CMP.
2250
41cb286c
PE
2251 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2252 not to EMACS_INT, to avoid GCC warning.
2253
4a1b9832
PE
2254 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2255
55daad71
PE
2256 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2257 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2258 isn't needed on 32-bit machines.
8f95c75c 2259
01103c44
PE
2260 * buffer.c (Fgenerate_new_buffer_name):
2261 Use EMACS_INT for count, not int.
0ceccced 2262 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2263
2264 * data.c (Qcompiled_function): Now static.
2265
c6f072e7
PE
2266 * window.c (window_body_lines): Now static.
2267
20ce5912
PE
2268 * image.c (gif_load): Rename local to avoid shadowing.
2269
9c4c5f81
PE
2270 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2271 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2272 * alloc.c (make_save_value): Integer argument is now of type
2273 ptrdiff_t, not int.
2274 (mark_object): Use ptrdiff_t, not int.
2275 * lisp.h (pD): New macro.
2276 * print.c (print_object): Use it.
2277
c0c5c8ae
PE
2278 * alloc.c: Use EMACS_INT, not int, to count objects.
2279 (total_conses, total_markers, total_symbols, total_vector_size)
2280 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2281 (total_free_floats, total_floats, total_free_intervals)
2282 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2283 Now EMACS_INT, not int. All uses changed.
2284 (Fgarbage_collect): Compute overall total using a double, so that
2285 integer overflow is less likely to be a problem. Check for overflow
2286 when converting back to an integer.
5a25e253
PE
2287 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2288 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2289 These were 'int' variables that could overflow on 64-bit hosts;
2290 they were never used, so remove them instead of repairing them.
211a0b2a 2291 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2292 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2293 Previously, this ceilinged at INT_MAX, but that doesn't work on
2294 64-bit machines.
e46bb31a 2295 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2296
c78baabf 2297 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2298 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2299 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2300 when a (possibly-narrower) signed value would do just as well.
2301 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2302
c9d624c6
PE
2303 * alloc.c: Catch some string size overflows that we were missing.
2304 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2305 for convenience in STRING_BYTES_MAX.
2306 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2307 The definition here is exact; the one in lisp.h was approximate.
2308 (allocate_string_data): Check for string overflow. This catches
2309 some instances we weren't catching before. Also, it catches
2310 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2311 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2312 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2313
c9d624c6
PE
2314 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2315 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2316 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
2317
353032ce
PE
2318 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2319
2bccce07
PE
2320 * alloc.c (Fmake_string): Check for out-of-range init.
2321
0ac30604
SM
23222011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2323
2324 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2325
c195f2de
JD
23262011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2327
2328 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2329 xg_get_default_scrollbar_width.
2330
2331 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2332 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2333 (style_changed_cb): Call update_theme_scrollbar_width and call
2334 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2335 all frames (Bug#8505).
2336 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2337 Call gtk_window_set_resizable if HAVE_GTK3.
2338 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2339 and height if HAVE_GTK3 (Bug#8505).
2340 (scroll_bar_width_for_theme): New variable.
2341 (update_theme_scrollbar_width): New function.
2342 (xg_get_default_scrollbar_width): Move code to
2343 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2344 (xg_initialize): Call update_theme_scrollbar_width.
2345
2346 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2347
2348 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2349
e10ac9f1
MR
23502011-06-12 Martin Rudalics <rudalics@gmx.at>
2351
2352 * frame.c (make_frame): Call other_buffer_safely instead of
2353 other_buffer.
2354
2355 * window.c (temp_output_buffer_show): Call display_buffer with
2356 second argument Vtemp_buffer_show_specifiers and reset latter
2357 immediately after the call.
2358 (Vtemp_buffer_show_specifiers): New variable.
2359 (auto_window_vscroll_p, next_screen_context_lines)
2360 (Vscroll_preserve_screen_position): Remove leading asterisks from
2361 doc-strings.
2362
2d3c217e 23632011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2364
7b7f97e8 2365 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2366 * buffer.c (Qclone_number): Remove for now, as it's unused.
2367 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2368 (record_buffer): Remove unused local.
2369 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2370 (set_frame_buffer_list): Remove; unused.
2371 * frame.h (other_visible_frames): Remove decl.
2372 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2373 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2374 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2375 if HAVE_GPM.
2376 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2377 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2378 Define only if HAVE_GPM.
2379 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2380 (update_hints_inhibit): Remove; never set. All uses removed.
2381 * widgetprv.h (emacsFrameClassRec): Remove decl.
2382 * window.c (delete_deletable_window): Now returns void, since it
2383 wasn't returning anything.
2384 (compare_window_configurations): Remove unused locals.
2385 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2386 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2387 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2388 the same widths as pointers. This follows up on the 2011-05-06 patch.
2389 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2390 * xterm.h: Likewise.
2391 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2392
1384b89e
JB
23932011-06-12 Juanma Barranquero <lekktu@gmail.com>
2394
2395 * makefile.w32-in: Update dependencies.
2396 (LISP_H): Add lib/intprops.h.
2397
1100a63c
CY
23982011-06-11 Chong Yidong <cyd@stupidchicken.com>
2399
2400 * image.c (gif_load): Add animation frame delay to the metadata.
2401 (syms_of_image): Use DEFSYM. New symbol `delay'.
2402
6198ccd0
MR
24032011-06-11 Martin Rudalics <rudalics@gmx.at>
2404
2405 * window.c (delete_deletable_window): Re-add.
2406 (Fset_window_configuration): Rewrite to handle dead buffers and
2407 consequently deletable windows.
2408 (window_tree, Fwindow_tree): Remove. Supply functionality in
2409 window.el.
2410 (compare_window_configurations): Simplify code.
2411
b6e3633c
AS
24122011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2413
1ab0dee5
AS
2414 * image.c (imagemagick_load_image): Fix type mismatch.
2415 (Fimagemagick_types): Likewise.
2416
b6e3633c
AS
2417 * window.h (replace_buffer_in_windows): Declare.
2418
9397e56f
MR
24192011-06-11 Martin Rudalics <rudalics@gmx.at>
2420
2421 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2422 Qclone_number. Remove external declaration of Qdelete_window.
2423 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2424 code.
2425 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2426 Qbuffer_list_update_hook if allowed.
2427 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2428 buffer list implementation.
2429 (other_buffer_safely): New function.
2430 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2431 calls to replace_buffer_in_windows and
2432 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2433 if allowed.
2434 (record_buffer): Inhibit quitting and rewrite using quittable
2435 functions. Run Qbuffer_list_update_hook if allowed.
2436 (Frecord_buffer, Funrecord_buffer): New functions.
2437 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2438 switch-to-buffer to window.el.
2439 (bury-buffer): Move to window.el.
2440 (Vbuffer_list_update_hook): New variable.
2441
2442 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2443 section.
2444
2445 * window.h (resize_frame_windows): Move up in code.
2446 (Fwindow_frame): Remove EXFUN.
2447 (replace_buffer_in_all_windows): Remove prototype.
2448 (replace_buffer_in_windows_safely): Add prototype.
2449
2450 * window.c: Declare Qdelete_window static again. Move down
2451 declaration of select_count.
2452 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2453 (Fother_window): Move to window.el.
2454 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2455 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2456 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2457 window.el.
2458 (replace_buffer_in_windows): Implement by calling
2459 Qreplace_buffer_in_windows.
2460 (replace_buffer_in_all_windows): Remove with some functionality
2461 moved into replace_buffer_in_windows_safely.
2462 (replace_buffer_in_windows_safely): New function.
2463 (select_window_norecord, select_frame_norecord): Move in front
2464 of run_window_configuration_change_hook. Remove now obsolete
2465 declarations.
2466 (Fset_window_buffer): Rewrite doc-string. Call
2467 Qrecord_window_buffer.
2468 (keys_of_window): Move binding for other-window to window.el.
2469
b50691aa
CY
24702011-06-11 Chong Yidong <cyd@stupidchicken.com>
2471
2472 * dispextern.h (struct image): Replace data member, whose int_val
2473 and ptr_val fields were not used by anything, with a single
2474 lisp_val object.
2475
2476 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2477 (gif_clear_image, gif_load, imagemagick_load_image)
2478 (gs_clear_image, gs_load): Callers changed.
2479
3f754b86
PE
24802011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2481
cca69397
PE
2482 * buffer.h: Include <time.h>, for time_t.
2483 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2484
109e28d0
PE
2485 Fix minor problems found by static checking.
2486
60737f02
PE
2487 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2488
4b66faf3
PE
2489 Make identifiers static if they are not used in other modules.
2490 * data.c (Qcompiled_function, Qframe, Qvector):
2491 * image.c (QimageMagick, Qsvg):
2492 * minibuf.c (Qmetadata):
2493 * window.c (resize_window_check, resize_root_window): Now static.
2494 * window.h (resize_window_check, resize_root_window): Remove decls.
2495
109e28d0
PE
2496 * window.c (window_deletion_count, delete_deletable_window):
2497 Remove; unused.
46a4ce9e
PE
2498 (window_body_lines): Now static.
2499 (Fdelete_other_windows_internal): Mark vars as initialized.
2500 Make sure 'resize_failed' is initialized.
2501 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2502 (resize_window_apply): Remove unused local.
2503 * window.h (delete_deletable_window): Remove decl.
2504
109e28d0 2505 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2506 (imagemagick_load_image): Fix pointer signedness problem by changing
2507 last arg from unsigned char * to char *. All uses changed.
2508 Also, fix a local for similar reasons.
2509 Remove unused locals. Remove locals to avoid shadowing.
2510 (fn_rsvg_handle_free): Remove; unused.
2511 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2512 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2513
3f754b86
PE
2514 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2515
2547adb1
CY
25162011-06-10 Chong Yidong <cyd@stupidchicken.com>
2517
2518 * image.c (gif_load): Fix omitted cast error introduced by
2519 2011-06-06 change.
2520
2c8e37d4
MR
25212011-06-10 Martin Rudalics <rudalics@gmx.at>
2522
2523 * window.h (resize_proportionally, orig_total_lines)
2524 (orig_top_line): Remove from window structure.
2525 (set_window_height, set_window_width, change_window_heights)
2526 (Fdelete_window): Remove prototypes.
2527 (resize_frame_windows): Remove duplicate declaration.
2528
440a42e3
EZ
25292011-06-10 Eli Zaretskii <eliz@gnu.org>
2530
2531 * window.h (resize_frame_windows, resize_window_check)
2532 (delete_deletable_window, resize_root_window)
2533 (resize_frame_windows): Declare prototypes.
2534
2535 * window.c (resize_window_apply): Make definition be "static" to
2536 match the prototype.
2537
562dd5e9
MR
25382011-06-10 Martin Rudalics <rudalics@gmx.at>
2539
2540 * window.c: Remove declarations of Qwindow_size_fixed,
2541 window_min_size_1, window_min_size_2, window_min_size,
2542 size_window, window_fixed_size_p, enlarge_window, delete_window.
2543 Remove static from declaration of Qdelete_window, it's
2544 temporarily needed by Fbury_buffer.
2545 (replace_window): Don't assign orig_top_line and
2546 orig_total_lines.
2547 (Fdelete_window, delete_window): Remove. Window deletion is
2548 handled by window.el.
2549 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2550 Fdelete_window calls with calls to Qdelete_window.
2551 (Fdelete_other_windows): Remove. Deleting other windows is
2552 handled by window.el.
2553 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2554 handled in window.el.
2555 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2556 Window minimum sizes are handled in window.el.
2557 (shrink_windows, size_window, set_window_height)
2558 (set_window_width, change_window_heights, window_height)
2559 (window_width, CURBEG, CURSIZE, enlarge_window)
2560 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2561 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2562 handled in window.el.
2563 (make_dummy_parent): Rename to make_parent_window and give it a
2564 second argument horflag.
2565 (make_window): Don't set resize_proportionally any more.
2566 (Fsplit_window): Remove. Windows are split in window.el.
2567 (save_restore_action, save_restore_orig_size)
2568 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2569 Resize mini windows in window.el.
2570 (grow_mini_window, shrink_mini_window): Implement by calling
2571 Qresize_root_window_vertically, resize_window_check and
2572 resize_window_apply.
2573 (saved_window, Fset_window_configuration, save_window_save): Do
2574 not handle orig_top_line, orig_total_lines, and
2575 resize_proportionally.
2576 (window_min_height, window_min_width): Move to window.el.
2577 (keys_of_window): Move bindings for delete-other-windows,
2578 split-window, delete-window and enlarge-window to window.el.
2579
2580 * buffer.c: Temporarily extern Qdelete_window.
2581 (Fbury_buffer): Temporarily call Qdelete_window instead of
2582 Fdelete_window (Fbury_buffer will move to window.el soon).
2583
2584 * frame.c (set_menu_bar_lines_1): Remove code handling
2585 orig_top_line and orig_total_lines.
2586
2587 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2588 set_window_height but set heights directly.
2589 (change_frame_size_1): Use resize_frame_windows.
2590
2591 * xdisp.c (init_xdisp): Don't use set_window_height but set
2592 heights directly.
2593
2594 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2595 resize_frame_windows instead of change_window_heights and run
2596 run_window_configuration_change_hook.
2597
2598 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2599 instead of change_window_heights and run
2600 run_window_configuration_change_hook.
2601
1a13852e
MR
26022011-06-09 Martin Rudalics <rudalics@gmx.at>
2603
2604 * window.c (replace_window): Rename second argument REPLACEMENT to
2605 NEW. New third argument SETFLAG. Rewrite.
2606 (delete_window, make_dummy_parent): Call replace_window with
2607 third argument 1.
2608 (window_list_1): Move down in code.
2609 (run_window_configuration_change_hook): Move set_buffer part
2610 before select_frame_norecord part in order to unwind correctly.
2611 Rename count1 to count.
2612 (recombine_windows, delete_deletable_window, resize_root_window)
2613 (Fdelete_other_windows_internal)
2614 (Frun_window_configuration_change_hook, make_parent_window)
2615 (resize_window_check, resize_window_apply, Fresize_window_apply)
2616 (resize_frame_windows, Fsplit_window_internal)
2617 (Fdelete_window_internal, Fresize_mini_window_internal): New
2618 functions.
2619 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2620
f3d1777e
MR
26212011-06-08 Martin Rudalics <rudalics@gmx.at>
2622
496e208e
MR
2623 * window.h (window): Add some new members to window structure -
2624 normal_lines, normal_cols, new_total, new_normal, clone_number,
2625 splits, nest, prev_buffers, next_buffers.
2626 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2627 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2628
f3d1777e
MR
2629 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2630 Remove.
496e208e
MR
2631 (make_dummy_parent): Set new members of windows structure.
2632 (make_window): Move down in code. Handle new members of window
2633 structure.
2634 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2635 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2636 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2637 (Fset_window_prev_buffers, Fwindow_next_buffers)
2638 (Fset_window_next_buffers, Fset_window_clone_number): New
2639 functions.
2640 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2641 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2642 Doc-string fixes.
2643 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2644 Argument WINDOW can be now internal window too.
2645 (Fwindow_use_time): Move up in code.
2646 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2647 Rewrite doc-string.
2648 (Fset_window_configuration, saved_window)
2649 (Fcurrent_window_configuration, save_window_save): Handle new
2650 members of window structure.
b9e809c2
MR
2651 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2652 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2653 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2654 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2655 Qget_mru_window, Qresize_root_window,
2656 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2657 Qauto_buffer_name; staticpro them.
f3d1777e 2658
abde8f8c
MR
26592011-06-07 Martin Rudalics <rudalics@gmx.at>
2660
2661 * window.c (Fwindow_total_size, Fwindow_left_column)
2662 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2663 (Fwindow_list_1): New functions.
2664 (window_box_text_cols): Replace with window_body_cols.
2665 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2666 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2667 (delete_window, Fset_window_configuration): Call
2668 delete_all_subwindows with window as argument.
2669 (delete_all_subwindows): Take a window as argument and not a
2670 structure. Rewrite.
190b47e6
MR
2671 (window_loop): Remove handling of GET_LRU_WINDOW and
2672 GET_LARGEST_WINDOW.
2673 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2674
2675 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2676 window_box_text_cols. delete_all_subwindows now takes a
2677 Lisp_Object as argument.
abde8f8c
MR
2678
2679 * indent.c (compute_motion, Fcompute_motion): Use
2680 window_body_cols instead of window_box_text_cols.
2681
fa8a67e6
MR
2682 * frame.c (delete_frame): Call delete_all_subwindows with root
2683 window as argument.
2684
a54e3482
DC
26852011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2686
2687 * fns.c (Fputhash): Document return value.
2688
60002bf5
CY
26892011-06-06 Chong Yidong <cyd@stupidchicken.com>
2690
2691 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2692
0c671da6 26932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2694
b862a52a 2695 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2696
be44ca6c
PE
2697 Check for overflow when converting integer to cons and back.
2698 * charset.c (Fdefine_charset_internal, Fdecode_char):
2699 Use cons_to_unsigned to catch overflow.
2700 (Fencode_char): Use INTEGER_TO_CONS.
2701 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2702 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2703 * data.c (long_to_cons, cons_to_long): Remove.
2704 (cons_to_unsigned, cons_to_signed): New functions.
2705 These signal an error for invalid or out-of-range values.
2706 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2707 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2708 * font.c (Ffont_variation_glyphs):
2709 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2710 * lisp.h: Include <intprops.h>.
2711 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2712 (cons_to_signed, cons_to_unsigned): New decls.
2713 (long_to_cons, cons_to_long): Remove decls.
2714 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2715 (Fprimitive_undo): Use CONS_TO_INTEGER.
2716 * xfns.c (Fx_window_property): Likewise.
2717 * xselect.c: Include <limits.h>.
2718 (x_own_selection, selection_data_to_lisp_data):
2719 Use INTEGER_TO_CONS.
2720 (x_handle_selection_request, x_handle_selection_clear)
2721 (x_get_foreign_selection, Fx_disown_selection_internal)
2722 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2723 (lisp_data_to_selection_data): Use cons_to_unsigned.
2724 (x_fill_property_data): Use cons_to_signed.
2725 Report values out of range.
2726
d1f3d2af
PE
2727 Check for buffer and string overflow more precisely.
2728 * buffer.h (BUF_BYTES_MAX): New macro.
2729 * lisp.h (STRING_BYTES_MAX): New macro.
2730 * alloc.c (Fmake_string):
2731 * character.c (string_escape_byte8):
2732 * coding.c (coding_alloc_by_realloc):
2733 * doprnt.c (doprnt):
2734 * editfns.c (Fformat):
2735 * eval.c (verror):
2736 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2737 since they may not be the same number.
2738 * editfns.c (Finsert_char):
2739 * fileio.c (Finsert_file_contents):
2740 Likewise for BUF_BYTES_MAX.
2741
dd52fcea
PE
2742 * image.c: Use ptrdiff_t, not int, for sizes.
2743 (slurp_file): Switch from int to ptrdiff_t.
2744 All uses changed.
2745 (slurp_file): Check that file size fits in both size_t (for
2746 malloc) and ptrdiff_t (for sanity and safety).
2747
7f9bbdbb
PE
2748 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2749 if b->modtime has its maximal value.
2750
dfe18f82
PE
2751 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2752
84acfcf0
PE
2753 Don't assume time_t can fit into int.
2754 * buffer.h (struct buffer.modtime): Now time_t, not int.
2755 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2756 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2757
ccd9a01a
PE
2758 Minor fixes for signed vs unsigned integers.
2759 * character.h (MAYBE_UNIFY_CHAR):
2760 * charset.c (maybe_unify_char):
2761 * keyboard.c (read_char, reorder_modifiers):
2762 XINT -> XFASTINT, since the integer must be nonnegative.
2763 * ftfont.c (ftfont_spec_pattern):
2764 * keymap.c (access_keymap, silly_event_symbol_error):
2765 XUINT -> XFASTINT, since the integer must be nonnegative.
2766 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2767 since it makes no difference and we prefer signed.
2768 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2769 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2770 nonnegative.
2771
d6d100dd
SM
27722011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2773
2774 * window.h (Fwindow_frame): Declare.
2775
2b6148e4
PE
27762011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2777
2778 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2779 (SPARE_MEMORY): Always define.
2780 (LARGE_REQUEST): Remove.
2781 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2782
f230ecc9
MR
27832011-06-06 Martin Rudalics <rudalics@gmx.at>
2784
727e958e
MR
2785 * lisp.h: Move EXFUNS for Fframe_root_window,
2786 Fframe_first_window and Fset_frame_selected_window to window.h.
2787
2788 * window.h: Move EXFUNS for Fframe_root_window,
2789 Fframe_first_window and Fset_frame_selected_window here from
2790 lisp.h.
2791
2792 * frame.c (Fwindow_frame, Fframe_first_window)
2793 (Fframe_root_window, Fframe_selected_window)
2794 (Fset_frame_selected_window): Move to window.c.
2795 (Factive_minibuffer_window): Move to minibuf.c.
2796 (Fother_visible_frames_p): New function.
2797
2798 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2799
f230ecc9
MR
2800 * window.c (decode_window, decode_any_window): Move up in code.
2801 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2802 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2803 (Fwindow_buffer): Move up and rewrite doc-string.
2804 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2805 (Fwindow_prev): New functions.
727e958e
MR
2806 (Fwindow_frame): Move here from frame.c. Accept any window as
2807 argument.
2808 (Fframe_root_window, Fframe_first_window)
2809 (Fframe_selected_window): Move here from frame.c. Accept frame
2810 or arbitrary window as argument. Update doc-strings.
2811 (Fminibuffer_window): Move up in code.
2812 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2813 (Fset_frame_selected_window): Move here from frame.c.
2814 Marginal rewrite.
727e958e
MR
2815 (Fselected_window, select_window, Fselect_window): Move up in
2816 code. Minor doc-string fixes.
f230ecc9 2817
4d09bcf6
PE
28182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2819
2820 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2821 Do not assume that spare memory exists; that assumption is valid
2822 only if SYSTEM_MALLOC.
2823 (LARGE_REQUEST): New macro, so that the issue of large requests
2824 is separated from the issue of spare memory.
2825
810928a2
AS
28262011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2827
172418ad
AS
2828 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2829 format. (Bug#8806)
2830
43f862f7
AS
2831 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2832
810928a2
AS
2833 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2834 before statements.
2835
a059fe24
JD
28362011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2837
2838 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2839
2840 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2841
2842 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2843 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2844
989bf368
JB
28452011-06-05 Juanma Barranquero <lekktu@gmail.com>
2846
2847 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2848
4b80f674
CY
28492011-06-04 Chong Yidong <cyd@stupidchicken.com>
2850
2851 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2852 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2853 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2854 New error handlers.
4b80f674
CY
2855 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2856 Obey Vx_select_enable_clipboard_manager. Catch errors in
2857 x_clipboard_manager_save (Bug#8779).
2858 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2859 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2860
99a33b77 28612011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2862
2863 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2864
99a33b77 28652011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2866
2867 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2868 in the current matrix if keep_current_p is non-zero.
2869
8264569d
EZ
28702011-06-04 Eli Zaretskii <eliz@gnu.org>
2871
2872 * bidi.c (bidi_level_of_next_char): Fix last change.
2873
57f97249
EZ
28742011-06-03 Eli Zaretskii <eliz@gnu.org>
2875
fec2107c 2876 Support bidi reordering of text covered by display properties.
57f97249 2877
fec2107c
EZ
2878 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2879 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2880 (bidi_cache_search, bidi_cache_iterator_state)
2881 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2882 (bidi_level_of_next_char, bidi_move_to_visually_next):
2883 Support character positions inside a run of characters covered by a
fec2107c
EZ
2884 display string.
2885 (bidi_paragraph_init, bidi_resolve_explicit_1)
2886 (bidi_level_of_next_char): Call bidi_fetch_char and
2887 bidi_fetch_char_advance instead of FETCH_CHAR and
2888 FETCH_CHAR_ADVANCE.
2889 (bidi_init_it): Initialize new members.
2890 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2891 definitions.
2892 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2893 instead of using explicit *_CHAR codes.
d6d100dd
SM
2894 (bidi_resolve_explicit, bidi_resolve_weak):
2895 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2896 bidirectional text is supported only in multibyte buffers.
2897 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2898 it to initialize the frame_window_p member of struct bidi_it.
2899 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2900 (bidi_resolve_explicit, bidi_resolve_weak)
2901 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2902 bidi_it->nchars is non-positive.
2903 (bidi_level_of_next_char): Don't try to lookup the cache for the
2904 next/previous character if nothing is cached there yet, or if we
2905 were just reseat()'ed to a new position.
c40e2fb2 2906
0e14fe90
EZ
2907 * xdisp.c (set_cursor_from_row): Set start and stop points
2908 according to the row's direction when priming the loop that looks
2909 for the glyph on which to display cursor.
2910 (single_display_spec_intangible_p): Function deleted.
2911 (display_prop_intangible_p): Reimplement to call
2912 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2913 Accept 3 additional arguments needed by handle_display_spec.
2914 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2915 values: lists, `(when COND...)' forms, etc.
2916 (single_display_spec_string_p): Support property values that are
2917 lists with the argument STRING its top-level element.
2918 (display_prop_string_p): Fix the condition for processing a
2919 property that is a list to be consistent with handle_display_spec.
fec2107c 2920 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2921 last portion of handle_display_prop.
2922 (compute_display_string_pos): Accept additional argument
2923 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2924 value of a `display' property is a "replacing spec".
2925 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2926 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2927 the display property, but just return a value indicating whether
2928 the display property will replace the characters it covers.
2929 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2930 frame_window_p members of struct bidi_it.
d6d100dd
SM
2931 (compute_display_string_pos, compute_display_string_end):
2932 New functions.
fec2107c
EZ
2933 (push_it): Accept second argument POSITION, where pop_it should
2934 jump to continue iteration.
2935 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2936
fec2107c
EZ
2937 * keyboard.c (adjust_point_for_property): Adjust the call to
2938 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2939
2940 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2941 (bidi_init_it): Update prototypes.
2942 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2943 (compute_display_string_pos, compute_display_string_end):
2944 Declare prototypes.
fec2107c
EZ
2945 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2946 EMACS_INT.
fc6f18ce 2947
40087514 29482011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2949
57f53182
PE
2950 Malloc failure behavior now depends on size of allocation.
2951 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2952 * lisp.h: Change signatures accordingly.
2953 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2954 All callers changed. (Bug#8762)
2955
2956 * gnutls.c: Use Emacs's memory allocators.
2957 Without this change, the gnutls library would invoke malloc etc.
2958 directly, which causes problems on non-SYNC_INPUT hosts, and which
2959 runs afoul of improving memory_full behavior. (Bug#8761)
2960 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2961 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2962 xfree instead of the default malloc, realloc, free.
2963 (Fgnutls_boot): No need to check for memory allocation failure,
2964 since xmalloc does that for us.
2965
ac32cd99 2966 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2967 * category.c (hash_get_category_set):
2968 * ccl.c (ccl_driver):
2969 * charset.c (Fdefine_charset_internal):
2970 * charset.h (struct charset.hash_index):
2971 * composite.c (get_composition_id, gstring_lookup_cache)
2972 (composition_gstring_put_cache):
2973 * composite.h (struct composition.hash_index):
2974 * dispextern.h (struct image.hash):
2975 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2976 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2977 (hashfn_equal, hashfn_user_defined, make_hash_table)
2978 (maybe_resize_hash_table, hash_lookup, hash_put)
2979 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2980 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2981 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2982 * image.c (make_image, search_image_cache, lookup_image)
2983 (xpm_put_color_table_h):
2984 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2985 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2986 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2987 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2988 * alloc.c (allocate_vectorlike):
2989 Check for overflow in vector size calculations.
2990 * ccl.c (ccl_driver):
2991 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2992 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2993 need to be updated by these changes.
40087514
PE
2994 * fns.c (make_hash_table, maybe_resize_hash_table):
2995 Check for integer overflow with large hash tables.
0de4bb68
PE
2996 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2997 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2998 (SXHASH_REDUCE): New macro.
2999 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3000 Use it instead of discarding useful hash info with large hash values.
3001 (sxhash_float): New function.
3002 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3003 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3004 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3005 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3006 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3007 Adjust signatures to match updated version of code.
3008 (consing_since_gc): Now EMACS_INT, since a single hash table can
3009 use more than INT_MAX bytes.
3010
698d32e2
DN
30112011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3012
3013 Make it possible to build with GCC-4.6+ -O2 -flto.
3014
3015 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3016
fd6fa53f
SM
30172011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3018
3019 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3020 Call minibuffer-inactive-mode.
3021
864db017
JB
30222011-05-31 Juanma Barranquero <lekktu@gmail.com>
3023
3024 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3025 Update dependencies.
3026
2ad0baf4
DN
30272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3028
3029 * data.c (init_data): Remove code for UTS, this system is not
3030 supported anymore.
3031
4fcc2638
DN
30322011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3033
3034 Don't force ./temacs to start in terminal mode.
3035
3036 * frame.c (make_initial_frame): Initialize faces in all cases, not
3037 only when CANNOT_DUMP is defined.
3038 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3039
c56e0fd5
DN
30402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3041
3042 * dispnew.c (add_window_display_history): Use const for the string
3043 pointer. Remove declaration, not needed.
3044
333d54da 30452011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3046
55d4c1b2 3047 Use 'inline', not 'INLINE'.
333d54da 3048 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3049 * alloc.c, fontset.c (INLINE): Remove.
3050 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3051 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3052 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3053 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3054 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3055
738db178
DN
30562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3057
3058 Make it possible to run ./temacs.
3059
3060 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3061 syms_of_callproc does the same thing. Remove test for
3062 "initialized", do it in the caller.
3063 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3064
620c53a6
SM
30652011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3066
3067 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3068 (read_minibuf): Use get_minibuffer.
3069 (syms_of_minibuf): Use DEFSYM.
3070 (Qmetadata): New var.
3071 * data.c (Qbuffer): Don't make it static.
3072 (syms_of_data): Use DEFSYM.
3073
e003a292
PE
30742011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3075
3076 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3077 (CCL_CODE_MIN): New macro.
3078
ed008a6d
PE
30792011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3080
3687c2ef
PE
3081 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3082
ed008a6d
PE
3083 * eval.c (Qdebug): Now static.
3084 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3085 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3086 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3087
d66c4c7c
CY
30882011-05-29 Chong Yidong <cyd@stupidchicken.com>
3089
3090 * image.c: Various fixes to ImageMagick code comments.
3091 (Fimagemagick_types): Doc fix.
3092
5fbc2025
PE
30932011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3094
0196f88a
PE
3095 Minor fixes prompted by GCC 4.6.0 warnings.
3096
3097 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3098
5fbc2025
PE
3099 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3100 (x_clipboard_manager_save_all): Move extern decl to ...
3101 * xterm.h: ... here, so that it can be checked for consistency.
3102
1dd3c2d9
CY
31032011-05-29 Chong Yidong <cyd@stupidchicken.com>
3104
3105 * xselect.c (x_clipboard_manager_save_frame)
3106 (x_clipboard_manager_save_all): New functions.
3107 (Fx_clipboard_manager_save): Lisp function deleted.
3108
3109 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3110 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3111
3112 * xterm.h: Update prototype.
3113
5ba6571d
WX
31142011-05-28 William Xu <william.xwl@gmail.com>
3115
3116 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3117 exiting (Bug#8239).
3118
3eaff834
JM
31192011-05-28 Jim Meyering <meyering@redhat.com>
3120
e1900994 3121 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3122 * fns.c (to_uchar): Define.
3123 (crypto_hash_function): Use it to convert some newly-signed
3124 variables to unsigned, to avoid sign-extension bugs. For example,
3125 without this change, (md5 "truc") would evaluate to
3126 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3127 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3128 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3129
0f6990a7
PE
31302011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3131
3132 Integer overflow fixes.
c8a9ca5a 3133
08686060
PE
3134 * dbusbind.c: Serial number integer overflow fixes.
3135 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3136 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3137 to hold a serial number that is too large for a fixnum.
3138 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3139 Check for serial numbers out of range. Decode any serial number
59568bf0 3140 that was so large that it became a float. (Bug#8722)
08686060 3141
2d1fc3c7
PE
3142 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3143 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3144 Use XFASTINT rather than XUINT when numbers are nonnegative.
3145 (xd_append_arg, Fdbus_method_return_internal):
3146 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3147 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3148 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3149 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3150 (Bug#8722)
2d1fc3c7 3151
c8a9ca5a
PE
3152 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3153
519e1d69
PE
3154 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3155
30569699
PE
3156 ccl: add integer overflow checks
3157 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3158 (IN_INT_RANGE): New macros.
3159 (ccl_driver): Use them to check for integer overflow when
3160 decoding a CCL program. Many of the new checks are whether XINT (x)
3161 fits in int; it doesn't always, on 64-bit hosts. The new version
3162 doesn't catch all possible integer overflows, but it's an
847044ea 3163 improvement. (Bug#8719)
30569699 3164
c11285dc
PE
3165 * alloc.c (make_event_array): Use XINT, not XUINT.
3166 There's no need for unsigned here.
3167
fdccd48e
PE
3168 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3169 This follows up to the 2011-05-06 change that substituted uintptr_t
3170 for EMACS_INT. This case wasn't caught back then.
3171
37910ab2
PE
3172 Rework Fformat to avoid integer overflow issues.
3173 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3174 now (part of C89). Include <verify.h>.
3175 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3176 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3177 (Fformat): Avoid the prepass trying to compute sizes; it was only
3178 approximate and thus did not catch overflow reliably. Instead, walk
3179 through the format just once, formatting and computing sizes as we go,
3180 checking for integer overflow at every step, and allocating a larger
3181 buffer as needed. Keep track separately whether the format is
3182 multibyte. Keep only the most-recently calculated precision, rather
3183 than them all. Record whether each argument has been converted to
3184 string. Use EMACS_INT, not int, for byte and char and arg counts.
3185 Support field widths and precisions larger than INT_MAX. Avoid
3186 sprintf's undefined behavior with conversion specifications such as %#d
3187 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3188 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3189 formatting out-of-range floating point numbers with int
9173deec 3190 formats. (Bug#8668)
37910ab2 3191
2e6578fb
PE
3192 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3193
0ae6bdee
PE
3194 * data.c: Avoid integer truncation in expressions involving floats.
3195 * data.c: Include <intprops.h>.
3196 (arith_driver): When there's an integer overflow in an expression
3197 involving floating point, convert the integers to floating point
3198 so that the resulting value does not suffer from catastrophic
3199 integer truncation. For example, on a 64-bit host (* 4
3200 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3201 Do not rely on undefined behavior after integer overflow.
3202
de883a70
PE
3203 merge count_size_as_multibyte, parse_str_to_multibyte
3204 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3205 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3206 Check for integer overflow.
3207 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3208 since it's now a duplicate of the other. This is more of
3209 a character than a buffer op, so better that it's in character.c.
3210 * fns.c, print.c: Adjust to above changes.
3211
2ff916cb
PE
32122011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3213
3214 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3215
f1b54466
PE
32162011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3217
fb1ac845
PE
3218 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3219 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3220 (x_clipboard_manager_save): Now static.
3221 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3222
f1b54466
PE
3223 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3224 (crypto_hash_function): Now static.
3225 Fix pointer signedness problems. Avoid unnecessary initializations.
3226
a9f737ee
CY
32272011-05-27 Chong Yidong <cyd@stupidchicken.com>
3228
3229 * termhooks.h (Vselection_alist): Make it terminal-local.
3230
3231 * terminal.c (create_terminal): Initialize it.
3232
3233 * xselect.c: Support for clipboard managers.
3234 (Vselection_alist): Move to termhooks.h as terminal-local var.
3235 (LOCAL_SELECTION): New macro.
3236 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3237 (symbol_to_x_atom): Remove gratuitous arg.
3238 (x_handle_selection_request, lisp_data_to_selection_data)
3239 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3240 (x_own_selection, x_get_local_selection, x_convert_selection):
3241 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3242 (some_frame_on_display): Delete unused function.
3243 (Fx_own_selection_internal, Fx_get_selection_internal)
3244 (Fx_disown_selection_internal, Fx_selection_owner_p)
3245 (Fx_selection_exists_p): New optional frame arg.
3246 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3247 (x_handle_selection_clear): Don't treat other terminals with the
3248 same keyboard specially. Use the terminal-local Vselection_alist.
3249 (x_clear_frame_selections): Use Frun_hook_with_args.
3250
3251 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3252
3253 * xterm.h: Add support for those atoms.
3254
e067f0c1
CY
32552011-05-26 Chong Yidong <cyd@stupidchicken.com>
3256
3257 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3258 (converted_selections, conversion_fail_tag): New global variables.
3259 (x_selection_request_lisp_error): Free the above.
3260 (x_get_local_selection): Remove unnecessary code.
3261 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3262 of converted selections stored in converted_selections.
3263 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3264 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3265 (x_convert_selection): New function.
3266 (x_handle_selection_event): Simplify.
3267 (x_get_foreign_selection): Don't ignore incoming requests while
3268 waiting for an answer; this will fail when we implement
3269 SAVE_TARGETS, and seems unnecessary anyway.
3270 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3271 (Vx_sent_selection_functions): Doc fix.
3272
0f4aebc0
LL
32732011-05-26 Leo Liu <sdl.web@gmail.com>
3274
3275 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3276
e61124cd
YM
32772011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3278
3279 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3280
3281 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3282 for fringe update if it has periodic bitmap.
ac389d0c 3283 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3284 and fringe_bitmap_periodic_p.
3285
3286 * fringe.c (get_fringe_bitmap_data): New function.
3287 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3288 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3289 row. Mark glyph row for fringe update if periodicity changed.
3290
3291 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3292 for fringe update unless it has periodic bitmap.
3293
f16d9837
KH
32942011-05-25 Kenichi Handa <handa@m17n.org>
3295
3296 * xdisp.c (get_next_display_element): Set correct it->face_id for
3297 a static composition.
3298
e1b90ef6
LL
32992011-05-24 Leo Liu <sdl.web@gmail.com>
3300
3301 * deps.mk (fns.o):
3302 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3303
3304 * fns.c (crypto_hash_function, Fsha1): New function.
3305 (Fmd5): Use crypto_hash_function.
3306 (syms_of_fns): Add Ssha1.
3307
7400048f
PE
33082011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3309
3310 * gnutls.c: Remove unused macros.
3311 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3312 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3313 Remove macros that are defined and never used.
3314 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3315
abb71cf4
CY
33162011-05-22 Chong Yidong <cyd@stupidchicken.com>
3317
3318 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3319 (Fx_get_selection_internal): Minor cleanup.
3320 (Fx_own_selection_internal): Rename arguments for consistency with
3321 select.el.
3322
6307db39
PE
33232011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3324
3325 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3326
f3d4e0a4
CY
33272011-05-22 Chong Yidong <cyd@stupidchicken.com>
3328
3329 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3330
4d8ade89
YM
33312011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3332
3333 * dispnew.c (scrolling_window): Don't exclude the case that the
3334 last enabled row in the desired matrix touches the bottom boundary.
3335
32078c8d
GM
33362011-05-21 Glenn Morris <rgm@gnu.org>
3337
3338 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3339 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3340 and add some more files.
32078c8d 3341
7285dc67
EZ
33422011-05-20 Eli Zaretskii <eliz@gnu.org>
3343
3344 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3345 report_file_error introduced by the change from 2011-05-07.
3346
89d1bd22
PE
33472011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3348
3349 * systime.h (Time): Define only if emacs is defined.
3350 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3351 where the include path doesn't have X11/X.h by default. See
3352 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3353
e23640bb 33542011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3355
3356 * composite.c (find_automatic_composition): Fix previous change.
3357
b9704ad9
GM
33582011-05-20 Glenn Morris <rgm@gnu.org>
3359
3360 * lisp.mk: New file, split from Makefile.in.
3361 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3362 (shortlisp): Remove.
3363 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3364
4a720484
GM
33652011-05-19 Glenn Morris <rgm@gnu.org>
3366
3367 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3368 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3369 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3370 (lisp): Set the order to that of loadup.el.
3371 (shortlisp): Make it a copy of $lisp.
3372 (SOME_MACHINE_LISP): Remove.
3373 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3374 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3375
a28d4396
KH
33762011-05-18 Kenichi Handa <handa@m17n.org>
3377
3378 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3379 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3380 (find_automatic_composition): Mostly rewrite for efficiency.
3381
a2b1fa8e
JB
33822011-05-18 Juanma Barranquero <lekktu@gmail.com>
3383
3384 * makefile.w32-in: Update dependencies.
3385
8e1f5610
CS
33862011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3387
3388 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3389 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3390
7025ee00 33912011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3392
cdfa6eab
PE
3393 Fix some integer overflow issues, such as string length overflow.
3394
06d6db33
PE
3395 * insdel.c (count_size_as_multibyte): Check for string overflow.
3396
2b4560a8
PE
3397 * character.c (lisp_string_width): Check for string overflow.
3398 Use EMACS_INT, not int, for string indexes and lengths; in
3399 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3400 the resulting string length overflows an EMACS_INT; instead,
3401 report a string overflow if no precision given. When checking for
3402 precision exhaustion, use a check that cannot possibly have
3403 integer overflow. (Bug#8675)
3404 * character.h (lisp_string_width): Adjust to new signature.
3405
cb93f9be
PE
3406 * alloc.c (string_overflow): New function.
3407 (Fmake_string): Use it. This doesn't change behavior, but saves
3408 a few bytes and will simplify future changes.
3409 * character.c (string_escape_byte8): Likewise.
3410 * lisp.h (string_overflow): New decl.
3411
1a1f3366
PE
3412 Fixups, following up to the user-interface timestamp change.
3413 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3414 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3415 * msdos.c (mouse_get_pos): Likewise.
3416 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3417 * w32gui.h (Time): Define by including "systime.h" rather than by
3418 declaring it ourselves. (Bug#8664)
3419
d4e3e4d3
PE
3420 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3421 * image.c (clear_image_cache): Likewise.
3422
f6a24d19
PE
3423 * term.c (term_mouse_position): Don't assume time_t wraparound.
3424
08dc5ae6
PE
3425 Be more systematic about user-interface timestamps.
3426 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3427 and sometimes 'EMACS_UINT', to represent these timestamps.
3428 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3429 This makes the code easier to follow, and makes it easier to catch
3430 integer overflow bugs such as Bug#8664.
3431 * frame.c (Fmouse_position, Fmouse_pixel_position):
3432 Use Time, not unsigned long, for user-interface timestamps.
3433 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3434 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3435 * keyboard.h (last_event_timestamp): Likewise.
3436 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3437 * menu.h (xmenu_show): Likewise.
3438 * term.c (term_mouse_position): Likewise.
3439 * termhooks.h (struct input_event.timestamp): Likewise.
3440 (struct terminal.mouse_position_hook): Likewise.
3441 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3442 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3443 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3444 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3445 what it was before.
3446 * menu.h, termhooks.h: Include "systime.h", for Time.
3447
8e55734a
PE
3448 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3449 Don't assume that the difference between two unsigned long values
3450 can fit into an integer. At this point, we know button_down_time
3451 <= event->timestamp, so the difference must be nonnegative, so
3452 there's no need to cast the result if double-click-time is
3453 nonnegative, as it should be; check that it's nonnegative, just in
3454 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3455 apart (about 25 days). (Bug#8664)
8e55734a 3456
841f1b75 3457 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3458 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3459
3e26f69c
PE
3460 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3461 that always fit in int. Use a sentinel instead of a counter, to
3462 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3463 * frame.h (struct frame): Use int for menu_bar_items_used
3464 instead of EMACS_INT, since it always fits in int.
3e26f69c 3465
5cc152c0
PE
3466 * menu.c (grow_menu_items): Check for int overflow.
3467
d89eb65e
PE
3468 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3469
5235bd3e
PE
3470 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3471 Before, the code was not consistent. These values cannot exceed
3472 2**31 - 1 so there's no need to make them unsigned.
3473 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3474 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3475 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3476 as modifiers.
3477 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3478
bc827e23
PE
3479 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3480 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3481 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3482 presumably because the widths might not match.
3483
78eb494e
PE
3484 * window.c (size_window): Avoid needless test at loop start.
3485
04f2d78b
CB
34862011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3487
3488 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3489
d2fc7e3d 34902011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3491
3492 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3493
d2fc7e3d 34942011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3495
3496 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3497 `width' to `bar_area_x' and `bar_area_width', respectively.
3498 (x_scroll_run): Take account of fringe background extension.
3499
04f2d78b
CB
3500 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3501 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3502 `bar_area_width', respectively.
3503 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3504 background extension.
3505
79b70037
GM
35062011-05-10 Jim Meyering <meyering@redhat.com>
3507
3508 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3509
2f142cc5
JB
35102011-05-10 Juanma Barranquero <lekktu@gmail.com>
3511
3512 * image.c (Finit_image_library): Return t for built-in image types,
3513 like pbm and xbm. (Bug#8640)
3514
57679c86
AS
35152011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3516
3517 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3518
888c9e86
EZ
35192011-05-07 Eli Zaretskii <eliz@gnu.org>
3520
b0512a1d
EZ
3521 * w32console.c (Fset_screen_color): Doc fix.
3522 (Fget_screen_color): New function.
3523 (syms_of_ntterm): Defsubr it.
3524
7285dc67
EZ
3525 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3526 unlink the temporary file if Fcall_process didn't create it in the
3527 first place.
3528 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3529 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3530 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3531 cue to call_process_cleanup not to close that handle.
3532
4d3fcc8e
BK
35332011-05-07 Ben Key <bkey76@gmail.com>
3534
3535 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3536 one of two shell specific rules, either bootstrap-temacs-CMD or
3537 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3538 to the previous implementation of the bootstrap-temacs rule.
3539 The bootstrap-temacs-CMD rule is similar to the previous
3540 implementation of the bootstrap-temacs rule except that it
3541 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3542 variable.
3543
3544 These changes, along with some changes to nt/configure.bat,
3545 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3546 earlier fix to add support for --cflags and --ldflags options
3547 that include quotes so that it works whether make uses cmd or
3548 sh as the shell.
3549
b4289b64
MA
35502011-05-06 Michael Albinus <michael.albinus@gmx.de>
3551
3552 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3553 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3554 is a constant.
3555 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3556 a string. Handle both cases.
3557 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3558 (Fdbus_register_method): Use Qinvalid_function.
3559
af4c0e28
JB
35602011-05-06 Juanma Barranquero <lekktu@gmail.com>
3561
3562 * makefile.w32-in: Update dependencies.
3563 (LISP_H): Add inttypes.h and stdin.h.
3564 (PROCESS_H): Add unistd.h.
3565
c51453d9
EZ
35662011-05-06 Eli Zaretskii <eliz@gnu.org>
3567
3568 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3569 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3570
8ff0ac3c 35712011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3572
4c4b566b
PE
3573 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3574
aab2b9b5
PE
3575 * term.c (vfatal): Remove stray call to va_end.
3576 It's not needed and the C Standard doesn't allow it here anyway.
3577
c378da0b
PE
3578 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3579 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3580
288b08c7
PE
3581 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3582 bytes.
3583
e3601888
PE
3584 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3585
db6c0e74
PE
3586 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3587
dd5963ea
PE
3588 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3589
88c9450f
PE
3590 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3591
2f9442b8
PE
3592 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3593
c032b5f8
PE
3594 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3595 * charset.c (Fdefine_charset_internal): Don't initialize
3596 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3597 32-bit int (Bug#8600).
a108c10b
PE
3598
3599 * lread.c (read_integer): Be more consistent with string-to-number.
3600 Use string_to_number to do the actual conversion; this avoids
3601 rounding errors and fixes some other screwups. Without this fix,
3602 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3603 (digit_to_number): Move earlier, for benefit of read_integer.
3604 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3605 not a digit in any supported base. (Bug#8602)
a108c10b 3606
ad5f9eea
PE
3607 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3608
aec1708a
PE
3609 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3610 to match comment at start of function. This also removes a
3611 GCC warning about overflow in a 32+64-bit port.
3612
47be4ab5
PE
3613 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3614
371cac43
PE
3615 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3616 Reported by Stefan Monnier in
3617 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3618 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3619 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3620
d01a7826
PE
3621 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3622 (EMACS_UINTPTR): Likewise, with uintptr_t.
3623
7fd47d5c
PE
3624 * lisp.h: Prefer 64-bit EMACS_INT if available.
3625 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3626 on 32-bit hosts that have 64-bit int, so that they can access
3627 large files.
122b0c86
PE
3628 However, temporarily disable this change unless the temporary
3629 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3630
8727937b
PE
3631 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3632
8ac068ac
PE
3633 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3634 This removes an assumption that EMACS_INT and long are the same
3635 width as pointers. The assumption is true for Emacs porting targets
3636 now, but we want to make other targets possible.
3637 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3638 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3639 In the rest of the code, change types of integers that hold casted
3640 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3641 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3642 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3643 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3644 No need to cast type when ORing.
3645 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3646 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3647 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3648 assume EMACS_INT is the same width as char *.
3649 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3650 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3651 Remove no-longer-needed casts.
3652 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3653 (xg_tool_bar_help_callback, xg_make_tool_item):
3654 Use EMACS_INTPTR to hold an integer
3655 that will be cast to void *; this can avoid a GCC warning
3656 if EMACS_INT is not the same width as void *.
3657 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3658 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3659 (current_message_1, set_message_1):
3660 Use a local to convert to proper width without a cast.
3661 * xmenu.c (dialog_selection_callback): Likewise.
3662
ede49d71
PE
3663 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3664 Also, don't assume VALBITS / RAND_BITS is less than 5,
3665 and don't rely on undefined behavior when shifting a 1 left into
3666 the sign bit.
3667 * lisp.h (get_random): Change signature to match.
3668
2f30ecd0
PE
3669 * lread.c (hash_string): Use size_t, not int, for hash computation.
3670 Normally we prefer signed values; but hashing is special, because
3671 it's better to use unsigned division on hash table sizes so that
3672 the remainder is nonnegative. Also, size_t is the natural width
3673 for hashing into memory. The previous code used 'int', which doesn't
3674 retain enough info to hash well into very large tables.
3675 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3676
2a866e7b
PE
3677 * dbusbind.c: Don't possibly lose pointer info when converting.
3678 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3679 Use XPNTR rather than XHASH, so that the high-order bits of
3680 the pointer aren't lost when converting through void *.
3681
51639eac
PE
3682 * eval.c (Fautoload): Don't double-shift a pointer.
3683
92394119
PE
3684 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3685
dbdb9a7c
JB
36862011-05-06 Juanma Barranquero <lekktu@gmail.com>
3687
3688 * gnutls.c (DEF_GNUTLS_FN):
3689 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3690
db7a0b4f
AS
36912011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3692
3693 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3694 marker. (Bug#8610)
3695
f7ff1b0f 36962011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3697
3698 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3699 New version that can reserve upto 2GB of heap space.
3700
f7ff1b0f 37012011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3702
3703 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3704
639c109b
TZ
37052011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3706
3707 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3708 `gnutls_certificate_set_x509_key_file'.
3709
d2127135
JB
37102011-05-05 Juanma Barranquero <lekktu@gmail.com>
3711
3712 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3713 Update dependencies.
3714
e968f4f3
JB
37152011-05-04 Juanma Barranquero <lekktu@gmail.com>
3716
3717 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3718 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3719 Remove unused parameter `fildes'.
3720 * process.c (read_process_output, send_process): Don't pass it.
3721
84d358f0
JB
37222011-05-04 Juanma Barranquero <lekktu@gmail.com>
3723
3724 Fix previous change: the library cache is defined in w32.c.
3725 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3726 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3727
0898ca10
JB
37282011-05-04 Juanma Barranquero <lekktu@gmail.com>
3729
3730 Implement dynamic loading of GnuTLS on Windows.
3731
3732 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3733 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3734 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3735 Declare.
3736
3737 * gnutls.c (Qgnutls_dll): Define.
3738 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3739 (gnutls_*): Declare function pointers.
3740 (init_gnutls_functions): New function to initialize function pointers.
3741 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3742 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3743 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3744 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3745 (emacs_gnutls_write, emacs_gnutls_read)
3746 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3747 (Fgnutls_available_p): New function.
3748 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3749 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3750 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3751
3752 * image.c: Include w32.h.
3753 (Vimage_type_cache): Delete.
3754 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3755 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3756 (w32_delayed_load): Move to w32.c.
3757
3758 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3759
3760 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3761 (w32_delayed_load): Move from image.c. When loading a library, record
3762 its filename in the :loaded-from property of the library id.
3763 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3764 Initialize and staticpro them.
3765 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3766
3767 * process.c: Include lisp.h before w32.h, not after.
3768 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3769 instead of gnutls_record_check_pending.
3770
3771 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3772
ff4de4aa
TZ
37732011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3774
3775 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3776 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3777 as passed in.
3778
abe95abb
JD
37792011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3780
3781 * xterm.c (x_set_frame_alpha): Do not set property on anything
3782 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3783
e16e55d4
JB
37842011-05-02 Juanma Barranquero <lekktu@gmail.com>
3785
3786 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3787
bafcf6a5
JB
37882011-05-02 Juanma Barranquero <lekktu@gmail.com>
3789
3790 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3791 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3792 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3793 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3794 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3795 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3796 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3797 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3798 (Qgnutls_bootprop_callbacks_verify): Make static.
3799
e7a6747f
AS
38002011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3801
19ed11ba
AS
3802 * callproc.c: Indentation fixup.
3803
e7a6747f 3804 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3805 (wait_for_termination, interruptible_wait_for_termination):
3806 Move after wait_for_termination_1.
e7a6747f 3807
1ef14cb4
LMI
38082011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3809
3810 * sysdep.c (interruptible_wait_for_termination): New function
3811 which is like wait_for_termination, but allows keyboard
3812 interruptions.
3813
3814 * callproc.c (Fcall_process): Add (:file "file") as an option for
3815 the STDOUT buffer.
3816 (Fcall_process_region): Ditto.
3817
330d880c
EZ
38182011-04-30 Eli Zaretskii <eliz@gnu.org>
3819
8db90b73
EZ
3820 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3821 rather than `XVECTOR (FOO)->size'.
3822
330d880c
EZ
3823 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3824 inttypes.h, as a gnulib replacement is used if it not available in
3825 system headers.
3826
15cbd324
EZ
38272011-04-21 Eli Zaretskii <eliz@gnu.org>
3828
3829 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3830 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3831 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3832
3833 * coding.c (coding_alloc_by_realloc): Error out if destination
3834 will grow beyond MOST_POSITIVE_FIXNUM.
3835 (decode_coding_emacs_mule): Abort if there isn't enough place in
3836 charbuf for the composition carryover bytes. Reserve an extra
3837 space for up to 2 characters produced in a loop.
3838 (decode_coding_iso_2022): Abort if there isn't enough place in
3839 charbuf for the composition carryover bytes.
3840
38412011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3842
ae940cca
EZ
3843 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3844 aborting when %lld or %lll format is passed.
3845 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3846 %llo or %llx format is passed. (Bug#8545)
3847
03ab8921
EZ
3848 * window.c (window_scroll_line_based): Use a marker instead of
3849 simple variables to record original value of point. (Bug#7952)
3850
afda1437
EZ
3851 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3852 produced by %s or %c overflows available buffer space. (Bug#8545)
3853
f76dee0c
PE
38542011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3855
3856 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3857 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3858
fdc5744d
JB
38592011-04-28 Juanma Barranquero <lekktu@gmail.com>
3860
3861 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3862
638f053a
JB
38632011-04-28 Juanma Barranquero <lekktu@gmail.com>
3864
3865 * keyboard.c (Qdelayed_warnings_hook): Define.
3866 (command_loop_1): Run `delayed-warnings-hook'
3867 if Vdelayed_warnings_list is non-nil.
3868 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3869 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3870
d178f871
EZ
38712011-04-28 Eli Zaretskii <eliz@gnu.org>
3872
3873 * doprnt.c (doprnt): Don't return value smaller than the buffer
3874 size if the message was truncated. (Bug#8545).
3875
b124fd93
JB
38762011-04-28 Juanma Barranquero <lekktu@gmail.com>
3877
3878 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3879 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3880
e810457d
PE
38812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3882
3883 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3884
ea51cceb
JB
38852011-04-27 Juanma Barranquero <lekktu@gmail.com>
3886
3887 * makefile.w32-in: Update dependencies.
3888
94dcfacf
EZ
38892011-04-27 Eli Zaretskii <eliz@gnu.org>
3890
3891 Improve `doprnt' and its usage. (Bug#8545)
3892 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3893 `format_end'. Remove support for %l as a conversion specifier.
3894 Don't use xrealloc. Improve diagnostics when the %l size modifier
3895 is used. Update the commentary.
3896
3897 * eval.c (verror): Simplify calculation of size_t.
3898
3899 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3900 messages.
3901
f61f41d7
PE
39022011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3903
3904 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3905 change.
3906
96fb4434
PE
39072011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3908
3909 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3910 This makes this file independent of the recent pseudovector change.
3911
671875da 39122011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3913
69e9b5a3
PE
3914 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3915
b5f869a7 3916 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3917 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3918 Remove unused local.
c8926152 3919 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3920
841a1577 3921 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3922 GCC 4.6.0 optimizes based on type-based alias analysis.
3923 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3924 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3925 != &v->size, and therefore "v->size = 1; b->size = 2; return
3926 v->size;" must therefore return 1. This assumption is incorrect
3927 for Emacs, since it type-puns struct Lisp_Vector * with many other
3928 types. To fix this problem, this patch adds a new type struct
f904488f 3929 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3930 and pseudovectors, and helps optimizing compilers not get fooled
3931 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3932 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3933 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3934 the size member.
eab3844f
PE
3935 (XSETPVECTYPE): Rewrite in terms of new macro.
3936 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3937 This is a bit clearer, and further avoids the possibility of
3938 undesirable aliasing.
3939 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3940 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3941 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3942 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3943 (ASIZE): Now uses header.size rather than size.
3944 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3945 to avoid the hassle of writing XVECTOR (foo)->header.size.
3946 (struct vectorlike_header): New type.
eab3844f
PE
3947 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3948 object, to help avoid aliasing.
3949 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3950 (SUBRP): Likewise, since Lisp_Subr is a special case.
3951 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3952 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3953 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3954 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3955 changed to be "header.size" and "header.next".
3956 * buffer.h (struct buffer): Likewise.
3957 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3958 * frame.h (struct frame): Likewise.
3959 * process.h (struct Lisp_Process): Likewise.
3960 * termhooks.h (struct terminal): Likewise.
3961 * window.c (struct save_window_data, struct saved_window): Likewise.
3962 * window.h (struct window): Likewise.
3963 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3964 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3965 * buffer.c (init_buffer_once): Likewise.
3966 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3967 special case.
3968 * process.c (Fformat_network_address): Use local var for size,
3969 for brevity.
3970
0df1eac5
PE
3971 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3972
847ab9d1 3973 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3974 * data.c (atof): Remove decl; no longer used or needed.
3975 (digit_to_number): Move to lread.c.
3976 (Fstring_to_number): Use new string_to_number function, to be
3977 consistent with how the Lisp reader treats infinities and NaNs.
3978 Do not assume that floating-point numbers represent EMACS_INT
3979 without losing information; this is not true on most 64-bit hosts.
3980 Avoid double-rounding errors, by insisting on integers when
3981 parsing non-base-10 numbers, as the documentation specifies.
3982 * lisp.h (string_to_number): New decl, replacing ...
3983 (isfloat_string): Remove.
bc0a5c13 3984 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3985 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3986 appears to have been a coding error. Similarly, do not accept
3987 strings like +-1e0 as floating point numbers. Do not report
3988 overflow for integer overflows unless the base is not 10 which
3989 means we have no simple and reliable way to continue.
3990 Break out the floating-point parsing into a new
3991 function string_to_number, so that Fstring_to_number parses
3992 floating point numbers consistently with the Lisp reader.
04f2d78b 3993 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3994 (E_CHAR, EXP_INT): Remove, replacing with ...
3995 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3996 (string_to_number): New function, replacing isfloat_string.
3997 This function checks for valid syntax and produces the resulting
3998 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3999 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4000 so that overflow for non-base-10 numbers is reported only when
4001 there's no portable and simple way to convert to floating point.
452f4150 4002
67769ffc
PE
4003 * textprop.c (set_text_properties_1): Rewrite for clarity,
4004 and to avoid GCC warning about integer overflow.
4005
c20db43f
PE
4006 * intervals.h (struct interval): Use EMACS_INT for members
4007 where EMACS_UINT might cause problems. See
4008 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4009 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4010 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4011 All uses changed.
37aa2f85
PE
4012 (offset_intervals): Tell GCC not to worry about length overflow
4013 when negating a negative length.
c20db43f 4014
2538aa2f
PE
4015 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4016 (overrun_check_free): Likewise.
4017
f2d3008d
PE
4018 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4019 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4020 word size.
4021
ec8df744
PE
4022 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4023 (gnutls_make_error): Rename local to avoid shadowing.
4024 (gnutls_emacs_global_deinit): ifdef out; not used.
4025 (Fgnutls_boot): Use const for pointer to readonly storage.
4026 Comment out unused local. Fix pointer signedness problems.
4027
640ee02d
PE
4028 * lread.c (openp): Don't stuff size_t into an 'int'.
4029 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4030 about possible signed overflow.
4031
6048fb2a
PE
4032 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4033 (GDK_KEY_g): Don't define if already defined.
4034 (xg_prepare_tooltip): Avoid pointer signedness problem.
4035 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4036
fa3c87e1
PE
4037 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4038 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4039
2172544b
PE
4040 * xfns.c (Fx_window_property): Simplify a bit,
4041 to make a bit faster and to avoid GCC 4.6.0 warning.
4042 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4043
9b821a21
PE
4044 * fns.c (internal_equal): Don't assume size_t fits in int.
4045
3c616cfa
PE
4046 * alloc.c (compact_small_strings): Tighten assertion a little.
4047
c2982e87
PE
4048 Replace pEd with more-general pI, and fix some printf arg casts.
4049 * lisp.h (pI): New macro, generalizing old pEd macro to other
4050 conversion specifiers. For example, use "...%"pI"d..." rather
4051 than "...%"pEd"...".
4052 (pEd): Remove. All uses replaced with similar uses of pI.
4053 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4054 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4055 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4056 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4057 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4058 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4059 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4060 64-bit hosts.
4061 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4062 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4063 * print.c (safe_debug_print, print_object): Likewise.
4064 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4065 to int.
6f04d126
PE
4066 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4067 avoiding the 0 flag, which is not portable.
c2982e87
PE
4068 * process.c (Fmake_network_process): Use pI to avoid cast.
4069 * region-cache.c (pp_cache): Likewise.
4070 * xdisp.c (decode_mode_spec): Likewise.
4071 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4072 behavior on 64-bit hosts with printf arg.
6f04d126 4073 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4074 (x_stop_queuing_selection_requests): Likewise.
4075 (x_get_window_property): Don't truncate byte count to an 'int'
4076 when tracing.
0b432f21 4077
5e073ec7
PE
4078 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4079 here, since it parses constructs like leading '-' and spaces,
4080 which are not wanted; and it overflows with large numbers.
4081 Instead, simply match F[0-9]+, which is what is wanted anyway.
4082
36372bf9
PE
4083 * alloc.c: Remove unportable assumptions about struct layout.
4084 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4085 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4086 (allocate_vectorlike, make_pure_vector): Use the new macros,
4087 plus offsetof, to remove unportable assumptions about struct layout.
4088 These assumptions hold on all porting targets that I know of, but
4089 they are not guaranteed, they're easy to remove, and removing them
4090 makes further changes easier.
4091
0b432f21
PE
4092 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4093 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4094 (string_overrun_cookie): Now const. Use initializers that
4095 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4096 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4097 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4098 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4099 multiple of sizeof (EMACS_INT); it need not be, if
4100 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4101 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4102
895009e1
JB
41032011-04-26 Juanma Barranquero <lekktu@gmail.com>
4104
4105 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4106
6a7a1b0b
TZ
41072011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4108
4109 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4110 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4111 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4112
841a1577 41132011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4114
4115 * lisp.h (Qdebug): List symbol.
895009e1 4116 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4117 * keyboard.c (debug-on-event): New variable.
4118 (handle_user_signal): Break into debugger when debug-on-event
4119 matches the current signal symbol.
4120
f2d3ba6f
DN
41212011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4122
4123 * alloc.c (check_sblock, check_string_bytes)
4124 (check_string_free_list): Convert to standard C.
4125
42ce4c63
TZ
41262011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4127
4128 * w32.c (emacs_gnutls_push): Fix typo.
4129
825cd63c
EZ
41302011-04-25 Eli Zaretskii <eliz@gnu.org>
4131
fb11d64d
EZ
4132 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4133 "cast to pointer from integer of different size".
4134
825cd63c
EZ
4135 Improve doprnt and its use in verror. (Bug#8545)
4136 * doprnt.c (doprnt): Document the set of format control sequences
4137 supported by the function. Use SAFE_ALLOCA instead of always
4138 using `alloca'.
4139
4140 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4141 is one byte too soon. Don't use xrealloc; instead xfree and
4142 xmalloc anew.
4143
e061a11b
TZ
41442011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4145
4146 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4147 callbacks stage.
4148
4149 * gnutls.c: Renamed global_initialized to
4150 gnutls_global_initialized. Added internals for the
4151 :verify-hostname-error, :verify-error, and :verify-flags
4152 parameters of `gnutls-boot' and documented those parameters in the
4153 docstring. Start callback support.
9173deec
JB
4154 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4155 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4156 on error. Return error code.
e061a11b
TZ
4157 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4158 (emacs_gnutls_read): Likewise.
4159 (Fgnutls_boot): Return handshake error code.
4160 (emacs_gnutls_handle_error): New function.
4161 (wsaerror_to_errno): Likewise.
4162
4163 * w32.h (emacs_gnutls_pull): Add prototype.
4164 (emacs_gnutls_push): Likewise.
4165
4166 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4167 (emacs_gnutls_push): Likewise.
4168
41692011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4170
4171 * process.c (wait_reading_process_output): Check if GnuTLS
4172 buffered some data internally if no FDs are set for TLS
4173 connections.
4174
4175 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4176 (LIBS): Link to USER_LIBS.
4177 ($(BLD)/gnutls.$(0)): New target.
4178
fa6996bc
EZ
41792011-04-24 Eli Zaretskii <eliz@gnu.org>
4180
eb35682e
EZ
4181 * xdisp.c (handle_single_display_spec): Rename the
4182 display_replaced_before_p argument into display_replaced_p, to
4183 make it consistent with the commentary. Fix typos in the
4184 commentary.
4185
e2ad650c
EZ
4186 * textprop.c (syms_of_textprop): Remove dead code.
4187 (copy_text_properties): Delete obsolete commentary about an
4188 interface that was deleted long ago. Fix typos in the description
4189 of arguments.
4190
1b2de274
EZ
4191 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4192 to changes in oldXMenu/XMenu.h from 2011-04-16.
4193 <menu_help_message, prev_menu_help_message>: Constify.
4194 (IT_menu_make_room): menu->help_text is now `const char **';
4195 adjust.
4196
4197 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4198 to changes in oldXMenu/XMenu.h from 2011-04-16.
4199 (struct XMenu): Declare `help_text' `const char **'.
4200
4201 * xfaces.c <Qunspecified>: Make extern again.
4202
4203 * syntax.c: Include sys/types.h before including regex.h, as
4204 required by Posix.
4205
762b15be
EZ
4206 * doc.c (get_doc_string): Improve the format passed to `error'.
4207
4208 * doprnt.c (doprnt): Improve commentary.
4209
4210 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4211
4212 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4213 them with etags.
4214
f1052e5d
EZ
4215 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4216 changes in globals.h immediately force recompilation.
762b15be
EZ
4217 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4218 $(CURDIR)/s/ms-w32.h.
4219 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4220
fa6996bc
EZ
4221 * character.c (Fchar_direction): Function deleted.
4222 (syms_of_character): Don't defsubr it.
4223 <char-direction-table>: Deleted.
4224
e6c3da20
EZ
42252011-04-23 Eli Zaretskii <eliz@gnu.org>
4226
4227 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4228 * doprnt.c: Include limits.h.
4229 (SIZE_MAX): New macro.
04f2d78b
CB
4230 (doprnt): Return a size_t value. 2nd arg is now size_t.
4231 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4232 Improve overflow protection. Support `l' modifier for integer
4233 conversions. Support %l conversion. Don't assume an EMACS_INT
4234 argument for integer conversions and for %c.
4235
4236 * lisp.h (doprnt): Restore prototype.
4237
4238 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4239 $(SRC)/character.h.
4240
4241 * Makefile.in (base_obj): Add back doprnt.o.
4242
4243 * deps.mk (doprnt.o): Add back prerequisites.
4244 (callint.o): Depend on character.h.
4245
4246 * eval.c (internal_lisp_condition_case): Include the handler
4247 representation in the error message.
4248 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4249 when breaking from the loop.
4250
4251 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4252
4253 * callint.c (Fcall_interactively): When displaying error message
4254 about invalid control letter, pass the character's codepoint, not
4255 a pointer to its multibyte form. Improve display of the character
4256 in octal and display also its hex code.
4257
4258 * character.c (char_string): Use %x to display the (unsigned)
4259 codepoint of an invalid character, to avoid displaying a bogus
4260 negative value.
4261
4262 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4263 `error', not SYMBOL_NAME itself.
4264
4265 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4266 character arguments to `error'.
4267
4268 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4269 to `error' in error message about FINAL_CHAR argument. Make sure
4270 FINAL_CHAR is a character, and use %c when it is passed as
4271 argument to `error'.
4272
4ffd0d6b 42732011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4274
4275 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4276
4277 * w32.c: Include <time.h>.
4278 (sys_localtime): New function.
4279
4ffd0d6b 42802011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4281
4282 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4283
4ffd0d6b 4284 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4285
4ffd0d6b 42862011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4287
4ffd0d6b
GM
4288 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4289 zombies (Bug#8467).
aac0c6e3 4290
04c56954
EZ
42912011-04-19 Eli Zaretskii <eliz@gnu.org>
4292
4293 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4294 gl_state.e_property when gl_state.object is Qt.
4295
4296 * insdel.c (make_gap_larger): Remove limitation of buffer size
4297 to <= INT_MAX.
4298
16a43933
CY
42992011-04-18 Chong Yidong <cyd@stupidchicken.com>
4300
4301 * xdisp.c (lookup_glyphless_char_display)
4302 (produce_glyphless_glyph): Handle cons cell entry in
4303 glyphless-char-display.
4304 (Vglyphless_char_display): Document it.
4305
4306 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4307 glyphless-char-display.
4308
4581706e
CY
43092011-04-17 Chong Yidong <cyd@stupidchicken.com>
4310
4311 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4312
4313 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4314
4315 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4316 definition for no-X builds.
4317
4887c6e2 43182011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4319
fd35b6f9
PE
4320 Static checks with GCC 4.6.0 and non-default toolkits.
4321
5c1ccb01
PE
4322 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4323
006c5daa
PE
4324 * process.c (keyboard_bit_set): Define only if SIGIO.
4325 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4326 (send_process): Repair possible setjmp clobbering.
4327
efc736d3
PE
4328 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4329
4e2fe2e6
PE
4330 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4331
f97334a2
PE
4332 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4333
4e75f29d
PE
4334 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4335 Define only if needed.
4336
90efadd1
PE
4337 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4338 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4339 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4340
3c647824
PE
4341 * dispextern.h (struct redisplay_interface): Rename param
4342 to avoid shadowing.
e264f262 4343 * termhooks.h (struct terminal): Likewise.
761383f4 4344 * xterm.c (xembed_send_message): Likewise.
3c647824 4345
b58c5c4a
PE
4346 * insdel.c (make_gap_smaller): Define only if
4347 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4348
cad59032
PE
4349 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4350 it.
4351
c339dc2e
PE
4352 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4353 so that we aren't warned about unused symbols.
4354
91a3e27b
PE
4355 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4356
399c71d3 4357 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4358
8ffc96f5
PE
4359 * xfns.c (x_real_positions): Mark locals as initialized.
4360
eef9bc79
PE
4361 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4362
098db9dd
PE
4363 * xterm.c: Fix problems found by static analysis with other toolkits.
4364 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4365 (x_dispatch_event): Declare static if USE_GTK, and
4366 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4367 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4368 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4369 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4370 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4371
eb18f6cc
PE
4372 * xmenu.c (menu_help_callback): Pointer type fixes.
4373 Use const pointers when pointing at readonly data. Avoid pointer
4374 signedness clashes.
4375 (FALSE): Remove unused macro.
4376 (update_frame_menubar): Remove unused decl.
4377
1fe72bf8
PE
4378 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4379
60d9e1db
PE
4380 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4381 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4382 (single_menu_item): Rename local to avoid shadowing.
4383
39261c26
PE
4384 * keyboard.c (make_lispy_event): Remove unused local var.
4385
018c5e19
PE
4386 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4387 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4388
63d2b86e
PE
4389 * bitmaps: Change bitmaps from unsigned char back to the X11
4390 compatible char. Avoid the old compiler warnings about
4391 out-of-range initializers by using, for example, '\xab' rather
4392 than 0xab.
4393
aefd87e1
PE
4394 * xgselect.c (xgselect_initialize): Check vs interface
4395 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4396
bf501fb9
PE
4397 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4398
e9829fdf
PE
4399 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4400 to read-only memory.
4401
1086c095
PE
4402 * fns.c (vector): Remove; this old hack is no longer needed.
4403
2baccd04 4404 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4405 Remove unused var.
dde42981 4406 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4407
72391843 4408 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4409
436c16df 4410 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4411 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4412 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4413
92bb796d 4414 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4415 (x_term_init): Remove local to avoid shadowing.
92bb796d 4416
764430a3 4417 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4418
4419 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4420 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4421
d1dfb56c
EZ
44222011-04-16 Eli Zaretskii <eliz@gnu.org>
4423
c4354cb4
EZ
4424 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4425
d1dfb56c
EZ
4426 Fix regex.c, syntax.c and friends for buffers > 2GB.
4427 * syntax.h (struct gl_state_s): Declare character position members
4428 EMACS_INT.
4429
4430 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4431
04f2d78b
CB
4432 * textprop.c (verify_interval_modification, interval_of):
4433 Declare arguments EMACS_INT.
d1dfb56c
EZ
4434
4435 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4436 EMACS_INT.
4437
4438 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4439
4440 * indent.c (Fvertical_motion): Local variable it_start is now
4441 EMACS_INT.
4442
4443 * regex.c (re_match, re_match_2, re_match_2_internal)
4444 (bcmp_translate, regcomp, regexec, print_double_string)
4445 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4446 (re_compile_pattern, re_exec): Declare arguments and local
4447 variables `size_t' and `ssize_t' and return values `regoff_t', as
4448 appropriate.
4449 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4450 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4451 <compile_stack_type>: `size' and `avail' are now `size_t'.
4452
4453 * regex.h <regoff_t>: Use ssize_t, not int.
4454 (re_search, re_search_2, re_match, re_match_2): Arguments that
4455 specify buffer/string position and length are now ssize_t and
4456 size_t. Return type is regoff_t.
4457
613052cd
BK
44582011-04-16 Ben Key <bkey76@gmail.com>
4459
4460 * nsfont.m: Fixed bugs in ns_get_family and
4461 ns_descriptor_to_entity that were caused by using free to
4462 deallocate memory blocks that were allocated by xmalloc (via
4463 xstrdup). This caused Emacs to crash when compiled with
4464 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4465 --enable-checking=xmallocoverrun). xfree is now used to
4466 deallocate these memory blocks.
4467
4170f62f 44682011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4469
71b41406
PE
4470 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4471
9587a89d
PE
4472 emacs_write: Accept and return EMACS_INT for sizes.
4473 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4474 et seq.
4475 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4476 Accept and return EMACS_INT.
4477 (emacs_gnutls_write): Return the number of bytes written on
4478 partial writes.
4479 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4480 (emacs_read, emacs_write): Remove check for negative size, as the
4481 Emacs source code has been audited now.
9587a89d
PE
4482 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4483 (emacs_read, emacs_write): Use it.
273a5f82
PE
4484 * process.c (send_process): Adjust to the new signatures of
4485 emacs_write and emacs_gnutls_write. Do not attempt to store
4486 a byte offset into an 'int'; it might overflow.
9587a89d 4487 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4488
3e047f51
PE
4489 * sound.c: Don't assume sizes fit in 'int'.
4490 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4491 Return EMACS_INT, not int.
3e047f51 4492 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4493 Accept EMACS_INT, not int.
4494 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4495 record read return values.
4496
cc39a9db
BK
44972011-04-15 Ben Key <bkey76@gmail.com>
4498
c9d0ec6d
JB
4499 * keyboard.c (Qundefined): Don't declare static since it is used
4500 in nsfns.m.
4501 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4502 static since they are used in nsfont.m.
cc39a9db 4503
6c60eb9f
SM
45042011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4505
4506 * process.c (Qprocessp): Don't declare static.
4507 * lisp.h (Qprocessp): Declare again.
4508
7990b61a
JB
45092011-04-15 Juanma Barranquero <lekktu@gmail.com>
4510
4511 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4512
5d4cb038
PE
45132011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4514
8bd7b830 4515 Improve C-level modularity by making more things 'static'.
cd64ea1d 4516
e3b27b31
PE
4517 Don't publish debugger-only interfaces to other modules.
4518 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4519 (verify_bytepos, count_markers): Move decls to the only modules
4520 that need them.
4521 * region-cache.h (pp_cache): Likewise.
4522 * window.h (check_all_windows): Likewise.
4523 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4524
5d4cb038
PE
4525 * sysdep.c (croak): Now static, if
4526 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4527 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4528
4529 * alloc.c (refill_memory_reserve): Now static if
4530 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4531 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4532
e87b6180
PE
4533 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4534 Define only if USE_LUCID.
4535
ac64929e
PE
4536 * xrdb.c (x_customization_string, x_rm_string): Now static.
4537
6f37259d
PE
4538 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4539 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4540
1683e3ab
PE
4541 * xdisp.c (draw_row_with_mouse_face): Now static.
4542 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4543
de9c2632
PE
4544 * window.h (check_all_windows): Mark externally visible.
4545
2b96acb7
PE
4546 * window.c (window_deletion_count): Now static.
4547
4548 * undo.c: Make symbols static if they're not exported.
4549 (last_undo_buffer, last_boundary_position, pending_boundary):
4550 Now static.
4551
50436f33
PE
4552 * textprop.c (interval_insert_behind_hooks): Now static.
4553 (interval_insert_in_front_hooks): Likewise.
4554
64520e5c
PE
4555 * term.c: Make symbols static if they're not exported.
4556 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4557 (max_frame_lines, tty_set_terminal_modes):
4558 (tty_reset_terminal_modes, tty_turn_off_highlight):
4559 (get_tty_terminal): Now static.
4560 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4561 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4562 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4563 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4564 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4565
1fa53021
PE
4566 * sysdep.c: Make symbols static if they're not exported.
4567 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4568 Now static.
4569 (sigprocmask_set, full_mask): Remove; unused.
4570 (wait_debugging): Mark as visible.
4571 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4572 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4573
d4b43b22
PE
4574 * syntax.c (syntax_temp): Define only if !__GNUC__.
4575
b7c513d0
PE
4576 * sound.c (current_sound_device, current_sound): Now static.
4577
989b29ad
PE
4578 * search.c (searchbufs, searchbuf_head): Now static.
4579
13a55a78
PE
4580 * scroll.c (scroll_cost): Remove; unused.
4581 * dispextern.h (scroll_cost): Remove decl.
4582
de68a1fc
PE
4583 * region-cache.h (pp_cache): Mark as externally visible.
4584
40ccffa6
PE
4585 * process.c: Make symbols static if they're not exported.
4586 (process_tick, update_tick, create_process, chan_process):
4587 (Vprocess_alist, proc_buffered_char, datagram_access):
4588 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4589 (deactivate_process): Mark defn as static, as well as decl.
4590 * lisp.h (create_process): Remove decl.
4591 * process.h (chan_process, Vprocess_alist): Remove decls.
4592
ad64fc97
PE
4593 * print.c: Make symbols static if they're not exported.
4594 (print_depth, new_backquote_output, being_printed, print_buffer):
4595 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4596 (print_interval, print_number_index, initial_stderr_stream):
4597 Now static.
4598 * lisp.h (Fprinc): Remove decl.
4599 (debug_output_compilation_hack): Mark as externally visible.
4600
adddb265
PE
4601 * sysdep.c (croak): Move decl from here to syssignal.h.
4602 * syssignal.h (croak): Put it here, so the API can be checked when
4603 'croak' is called from dissociate_if_controlling_tty.
4604
1717ede2
PE
4605 * minibuf.c: Make symbols static if they're not exported.
4606 (minibuf_save_list, choose_minibuf_frame): Now static.
4607 * lisp.h (choose_minibuf_frame): Remove decl.
4608
fa5fb2bc
PE
4609 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4610
1e3890d1
PE
4611 * lread.c: Make symbols static if they're not exported.
4612 (read_objects, initial_obarray, oblookup_last_bucket_number):
4613 Now static.
4614 (make_symbol): Remove; unused.
4615 * lisp.h (initial_obarray, make_symbol): Remove decls.
4616
8a1414fa
PE
4617 * keyboard.c: Make symbols static if they're not exported.
4618 (single_kboard, recent_keys_index, total_keys, recent_keys):
4619 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4620 (this_single_command_key_start, echoing, last_auto_save):
4621 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4622 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4623 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4624 (Vlispy_mouse_stem, double_click_count):
4625 Now static.
4626 (force_auto_save_soon): Define only if SIGDANGER.
4627 (ignore_mouse_drag_p): Now static if
4628 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4629 (print_help): Remove; unused.
4630 (stop_character, last_timer_event): Mark as externally visible.
4631 * keyboard.h (ignore_mouse_drag_p): Declare only if
4632 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4633 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4634 * lisp.h (echoing): Remove decl.
4635 (force_auto_save_soon): Declare only if SIGDANGER.
4636 * xdisp.c (redisplay_window): Simplify code, to make it more
4637 obvious that ignore_mouse_drag_p is not accessed if !defined
4638 USE_GTK && !defined HAVE_NS.
4639
93ea6e8f
PE
4640 * intervals.c: Make symbols static if they're not exported.
4641 (merge_properties_sticky, merge_interval_right, delete_interval):
4642 Now static.
4643 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4644
77382fcc
PE
4645 * insdel.c: Make symbols static if they're not exported.
4646 However, leave prepare_to_modify_buffer alone. It's never
4647 called from outside this function, but that appears to be a bug.
4648 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4649 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4650 (adjust_after_replace_noundo): Remove; unused.
4651 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4652 (signal_before_change): Remove decls.
77382fcc 4653
9306c32e
PE
4654 * indent.c (val_compute_motion, val_vmotion): Now static.
4655
cd44d2eb
PE
4656 * image.c: Make symbols static if they're not exported.
4657 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4658 if USE_GTK.
4659 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4660 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4661
ad9a7a06
PE
4662 * fringe.c (standard_bitmaps): Now static.
4663 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4664
81626931
PE
4665 * frame.c: Make symbols static if they're not exported.
4666 (x_report_frame_params, make_terminal_frame): Now static.
4667 (get_frame_param): Now static, unless HAVE_NS.
4668 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4669 (x_get_resource_string): Remove; not used.
4670 * frame.h (make_terminal_frame, x_report_frame_params):
4671 (x_get_resource_string); Remove decls.
4672 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4673 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4674
239f9db9
PE
4675 * font.c, fontset.c: Make symbols static if they're not exported.
4676 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4677 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4678 * font.c (font_close_object): Now static.
4679 * font.h (font_close_object): Remove.
4680 * fontset.c (FONTSET_OBJLIST): Remove.
4681 (free_realized_fontset) #if-0 the body, which does nothing.
4682 (face_suitable_for_char_p): #if-0, as it's never called.
4683 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4684 * xfaces.c (face_at_string_position):
4685 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4686 since 0 is always ASCII.
4687
dfcf3579
PE
4688 * fns.c (weak_hash_tables): Now static.
4689
5045092b
PE
4690 * fileio.c: Make symbols static if they're not exported.
4691 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4692 (Vwrite_region_annotation_buffers): Now static.
4693
57a96f5c
PE
4694 * eval.c: Make symbols static if they're not exported.
4695 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4696 * lisp.h (backtrace_list): Remove decl.
4697
35f08c38
PE
4698 * emacs.c: Make symbols static if they're not exported.
4699 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4700 (fatal_error_code, fatal_error_signal_hook, standard_args):
4701 Now static.
4702 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4703 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4704 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4705 * lisp.h (fatal_error_signal_hook): Remove decl.
4706 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4707
f44bd759
PE
4708 * editfns.c: Move a (normally-unused) function to its only use.
4709 * editfns.c, lisp.h (get_operating_system_release): Remove.
4710 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4711 worth the hassle of breaking this out.
4712
b532497d
PE
4713 * xterm.c: Make symbols static if they're not exported.
4714 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4715 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4716 (x_destroy_window, x_delete_display):
4717 Now static.
4718 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4719 (x_mouse_leave): Remove; unused.
4720 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4721 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4722 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4723 Remove decls.
4724 (x_mouse_leave): Declare only if WINDOWSNT.
4725 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4726 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4727 USE_X_TOOLKIT.
4728
1675728f
PE
4729 * ftxfont.c: Make symbols static if they're not exported.
4730 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4731 HAVE_FREETYPE.
4732 * font.h (ftxfont_driver): Likewise.
4733
e4cebfca
PE
4734 * xfns.c: Make symbols static if they're not exported.
4735 (x_last_font_name, x_display_info_for_name):
4736 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4737 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4738 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4739 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4740 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4741 (last_show_tip_args): Now static.
4742 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4743 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4744 (x_screen_planes): Remove; unused.
4745 * dispextern.h (x_screen_planes): Remove decl.
4746
5bf46f05
PE
4747 * dispnew.c: Make symbols static if they're not exported.
4748 * dispextern.h (redraw_garbaged_frames, scrolling):
4749 (increment_row_positions): Remove.
4750 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4751 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4752 Now static.
4753 (redraw_garbaged_frames): Remove; unused.
4754
435f4c28
PE
4755 * xfaces.c: Make symbols static if they're not exported.
4756 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4757 Remove decls.
4758 * xterm.h (defined_color): Remove decls.
4759 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4760 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4761 (menu_face_changed_default, defined_color, free_realized_face):
4762 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4763 (ascii_face_of_lisp_face): Remove; unused.
4764
8524aef3
PE
4765 * xdisp.c: Make symbols static if they're not exported.
4766 * dispextern.h (scratch_glyph_row, window_box_edges):
4767 (glyph_to_pixel_coords, set_cursor_from_row):
4768 (get_next_display_element, set_iterator_to_next):
4769 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4770 (show_mouse_face): Remove decls
4771 * frame.h (message_buf_print): Likewise.
4772 * lisp.h (pop_message, set_message, check_point_in_composition):
4773 Likewise.
4774 * xterm.h (set_vertical_scroll_bar): Likewise.
4775 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4776 (message_buf_print, scratch_glyph_row, displayed_buffer):
4777 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4778 (get_next_display_element, show_mouse_face, window_box_edges):
4779 (frame_to_window_pixel_xy, check_point_in_composition):
4780 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4781 (glyph_to_pixel_coords): Remove; unused.
4782
16390cd2
PE
4783 * dired.c (file_name_completion): Now static.
4784
4785 * dbusbind.c (xd_in_read_queued_messages): Now static.
4786
a25f4dfa
PE
4787 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4788 * data.c (circular_list_error): Remove.
4789
14a9c8df
PE
4790 * commands.h (last_point_position, last_point_position_buffer):
4791 (last_point_position_window): Remove decls.
4792 * keyboard.c: Make these variables static.
4793
04f2d78b
CB
4794 * coding.h (coding, code_convert_region, encode_coding_gap):
4795 Remove decls.
74ab6df5
PE
4796 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4797 (iso_code_class, detect_coding, code_convert_region): Now static.
4798 (encode_coding_gap): Remove; unused.
4799
38dfbee1
PE
4800 * chartab.c (chartab_chars, chartab_bits): Now static.
4801
a2cb4e63
PE
4802 * charset.h (charset_iso_8859_1): Remove decl.
4803 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4804 Now static.
4805
127198fd
PE
4806 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4807 * ccl.c (Vccl_program_table): Now static.
4808 (check_ccl_update): Remove; unused.
4809
d85b608f
PE
4810 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4811 * category.h: ... from here.
4812 * category.c (check_category_table, set_category_set): Now static.
4813
31cd66f3
PE
4814 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4815 * lisp.h: Remove these decls.
4816
c358e587
PE
4817 * buffer.c (buffer_count): Remove unused var.
4818
e78aecca
PE
4819 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4820 so that it's not optimized away.
4821 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4822 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4823 exported only to the debugger.
4824
e192d7d3 4825 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4826 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4827
92470028
PE
4828 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4829 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4830 was inaccessible from Lisp.
4831 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4832 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4833
244ed907
PE
4834 alloc.c: Import and export fewer symbols, and remove unused items.
4835 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4836 is defined.
4837 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4838 it's not optimized away by whole-program optimization.
4839 (message_enable_multibyte, free_misc): Remove.
4840 (catchlist, handlerlist, mark_backtrace):
4841 Declare only if BYTE_MARK_STACK.
4842 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4843 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4844 (message_enable_multibyte): Remove decl.
4845 (free_misc, interval_free_list, float_block, float_block_index):
4846 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4847 (cons_free_list, last_marked_index):
4848 Now static.
4849 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4850 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4851 (mark_backtrace): Define only if BYTE_MARK_STACK.
4852 * xdisp.c (message_enable_multibyte): Now static.
4853
61c2b50e 4854 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4855 This makes it easier for human readers (and static analyzers)
4856 to see whether these variables are used from other modules.
4857 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4858 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4859 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4860 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4861 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4862 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4863 * xmenu.c, xselect.c:
4864 Declare Q* vars static if they are not used in other modules.
4865 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4866 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4867 Remove decls of unexported vars.
4868 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4869
95c82688
PE
4870 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4871
16a97296
PE
4872 Make Emacs functions such as Fatom 'static' by default.
4873 This makes it easier for human readers (and static analyzers)
4874 to see whether these functions can be called from other modules.
4875 DEFUN now defines a static function. To make the function external
4876 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4877 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4878 (Finit_image_library):
16a97296
PE
4879 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4880 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4881 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4882 Remove decls, since these functions are now static.
4883 (Funintern, Fget_internal_run_time): New decls, since these functions
4884 were already external.
95c82688 4885
16a97296
PE
4886 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4887 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4888 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4889 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4890 * keyboard.c, keymap.c, lread.c:
4891 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4892 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4893 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4894 Mark functions with DEFUE instead of DEFUN,
4895 if they are used in other modules.
4896 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4897 decls for now-static functions.
4898 * buffer.h (Fdelete_overlay): Remove decl.
4899 * callproc.c (Fgetenv_internal): Mark as internal.
4900 * composite.c (Fremove_list_of_text_properties): Remove decl.
4901 (Fcomposition_get_gstring): New forward static decl.
4902 * composite.h (Fcomposite_get_gstring): Remove decl.
4903 * dired.c (Ffile_attributes): New forward static decl.
4904 * doc.c (Fdocumntation_property): New forward static decl.
4905 * eval.c (Ffetch_bytecode): New forward static decl.
4906 (Funintern): Remove extern decl; now in .h file where it belongs.
4907 * fileio.c (Fmake_symbolic_link): New forward static decl.
4908 * image.c (Finit_image_library): New forward static decl.
4909 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4910 * intervals.h (Fprevious_property_change):
4911 (Fremove_list_of_text_properties): Remove decls.
4912 * keyboard.c (Fthis_command_keys): Remove decl.
4913 (Fcommand_execute): New forward static decl.
4914 * keymap.c (Flookup_key): New forward static decl.
4915 (Fcopy_keymap): Now static.
4916 * keymap.h (Flookup_key): Remove decl.
4917 * process.c (Fget_process): New forward static decl.
4918 (Fprocess_datagram_address): Mark as internal.
4919 * syntax.c (Fsyntax_table_p): New forward static decl.
4920 (skip_chars): Remove duplicate decl.
4921 * textprop.c (Fprevious_property_change): New forward static decl.
4922 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4923 Now internal.
4924 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4925 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4926
785bbd42
PE
4927 * editfns.c (Fformat): Remove unreachable code.
4928
8b913b57
AS
49292011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4930
4931 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4932 change. (Bug#8496)
4933
a6744a35
EZ
49342011-04-13 Eli Zaretskii <eliz@gnu.org>
4935
4936 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4937 when at ZV. (Bug#8487)
4938
e7974947
AS
49392011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4940
baad03f0
AS
4941 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4942 (Bug#8437)
4943 * keyboard.c (parse_tool_bar_item): Likewise.
4944 * sound.c (sound_cleanup, alsa_close): Likewise.
4945 * termcap.c (tgetent): Likewise.
4946 * xfns.c (x_default_font_parameter): Likewise.
4947 * xsettings.c (read_and_apply_settings): Likewise.
4948
e7974947
AS
4949 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4950 (overrun_check_free): Protoize.
4951
28272684
PE
49522011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4953
4954 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4955 since callers should never pass a negative size.
4956 Change the signature to match that of plain 'read' and 'write'; see
4957 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4958 * lisp.h: Update prototypes of emacs_write and emacs_read.
4959
11997c76
EZ
49602011-04-11 Eli Zaretskii <eliz@gnu.org>
4961
4962 * xdisp.c (redisplay_window): Don't try to determine the character
4963 position of the scroll margin if the window start point w->startp
e896f03c 4964 is outside the buffer's accessible region. (Bug#8468)
11997c76 4965
8a2cbd72
EZ
49662011-04-10 Eli Zaretskii <eliz@gnu.org>
4967
4968 Fix write-region and its subroutines for buffers > 2GB.
4969 * fileio.c (a_write, e_write): Modify declaration of arguments and
4970 local variables to support buffers larger than 2GB.
4971 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4972
4973 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4974 argument, local variables, and return value.
4975
4976 * lisp.h: Update prototypes of emacs_write and emacs_read.
4977
4978 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4979
4073e537 49802011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4981
1ebfdcb6
PE
4982 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4983
b2ded58d
PE
4984 Fix more problems found by GCC 4.6.0's static checks.
4985
7d66342c
PE
4986 * xdisp.c (vmessage): Use a better test for character truncation.
4987
bbf47d44
PE
4988 * charset.c (load_charset_map): <, not <=, for optimization,
4989 and to avoid potential problems with integer overflow.
9248994d 4990 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4991 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4992 * editfns.c (Fformat): Likewise.
1e69125e 4993 * syntax.c (skip_chars): Likewise.
3befa583 4994
e3019616
PE
4995 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4996 This also lets GCC 4.6.0 generate slightly better loop code.
4997
becfa255
PE
4998 * callint.c (Fcall_interactively): <, not <=, for optimization.
4999 (Fcall_interactively): Count the number of arguments produced,
5000 not the number of arguments given. This is simpler and lets GCC
5001 4.6.0 generate slightly better code.
5002
dae0cd48
PE
5003 * ftfont.c: Distingish more carefully between FcChar8 and char.
5004 The previous code passed unsigned char * to a functions like
5005 strlen and xstrcasecmp that expect char *, which does not
5006 conform to the C standard.
5007 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5008 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5009 char * when the C standard requires it.
5010
76032d70
PE
5011 * keyboard.c (read_char): Remove unused var.
5012
eb3f1cc8
PE
5013 * eval.c: Port to Windows vsnprintf (Bug#8435).
5014 Include <limits.h>.
5015 (SIZE_MAX): Define if the headers do not.
5016 (verror): Do not give up if vsnprintf returns a negative count.
5017 Instead, grow the buffer. This ports to Windows vsnprintf, which
5018 does not conform to C99. Problem reported by Eli Zaretskii.
5019 Also, simplify the allocation scheme, by avoiding the need for
5020 calling realloc, and removing the ALLOCATED variable.
5021
70476b54
PE
5022 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5023
12020a9e
PE
5024 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5025 But keep the doprint source code for now, as we might revamp it
5026 and use it again (Bug#8435).
ea6c7ae6
PE
5027 * lisp.h (doprnt): Remove.
5028 * Makefile.in (base_obj): Remove doprnt.o.
5029 * deps.mk (doprnt.o): Remove.
5030
5fdb398c
PE
5031 error: Print 32- and 64-bit integers portably (Bug#8435).
5032 Without this change, on typical 64-bit hosts error ("...%d...", N)
5033 was used to print both 32- and 64-bit integers N, which relied on
5034 undefined behavior.
5035 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5036 New macro.
5037 * lisp.h (error, verror): Mark as printf-like functions.
5038 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5039 Report overflow in size calculations when allocating printf buffer.
5040 Do not truncate output string at its first null byte.
5041 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5042 Truncate the output at a character boundary, since vsnprintf does not
5043 do that.
5044 * charset.c (check_iso_charset_parameter): Convert internal
5045 character to string before calling 'error', since %c now has the
5046 printf meaning.
5047 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5048 overflow when computing char to be passed to 'error'. Do not
5049 pass Lisp_Object to 'error'; pass the integer instead.
5050 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5051 formatted with plain %d.
5052
b189fa66
PE
5053 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5054
bff87ef0
PE
5055 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5056
7e2cac20
PE
5057 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5058
ce4d90b5
PE
5059 * xterm.c (x_catch_errors): Remove duplicate declaration.
5060
266c9547
PE
5061 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5062
79c49ad2
PE
5063 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5064
368f4090
JM
50652011-04-10 Jim Meyering <meyering@redhat.com>
5066
5067 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5068 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5069 return ssize_t not "int", and use size_t as the buffer length.
5070 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5071 * gnutls.h: Update declarations.
5072 * process.c (read_process_output): Use ssize_t, to match.
5073 (send_process): Likewise.
5074
a32d4040
CY
50752011-04-09 Chong Yidong <cyd@stupidchicken.com>
5076
5077 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5078
8546720e 50792011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5080
04f2d78b
CB
5081 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5082 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5083
8546720e
GM
5084 * xterm.c (handle_one_xevent):
5085 * xmenu.c (create_and_show_popup_menu):
5086 * xselect.c (x_decline_selection_request)
5087 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5088
0a2f5c1a 50892011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5090
5091 Fix some uses of `int' instead of EMACS_INT.
5092 * search.c (string_match_1, fast_string_match)
5093 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5094 (scan_buffer, find_next_newline_no_quit)
5095 (find_before_next_newline, search_command, Freplace_match)
5096 (Fmatch_data): Make some `int' variables be EMACS_INT.
5097
5098 * xdisp.c (display_count_lines): 3rd argument and return value now
5099 EMACS_INT. All callers changed.
5100 (pint2hrstr): Last argument is now EMACS_INT.
5101
5102 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5103 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5104 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5105 (decode_coding_utf_16, decode_coding_emacs_mule)
5106 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5107 (decode_coding_ccl, decode_coding_charset)
5108 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5109 (decode_coding_iso_2022, decode_coding_emacs_mule)
5110 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5111 <char_offset, last_offset>: Declare EMACS_INT.
5112 (encode_coding_utf_8, encode_coding_utf_16)
5113 (encode_coding_emacs_mule, encode_invocation_designation)
5114 (encode_designation_at_bol, encode_coding_iso_2022)
5115 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5116 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5117 Declare EMACS_INT.
5118 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5119 (encode_invocation_designation): Last argument P_NCHARS is now
5120 EMACS_INT.
5121 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5122 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5123
5124 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5125 All users changed.
5126
5127 * ccl.c (Fccl_execute_on_string): Declare some variables
5128 EMACS_INT.
5129
8546720e 51302011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5131
5132 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5133
4e19a977
CS
51342011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5135
5136 * process.c (Fformat_network_address): Doc fix.
5137
87302331
R
51382011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5139
5140 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5141
cbb59342
CY
51422011-04-08 Chong Yidong <cyd@stupidchicken.com>
5143
5144 * keyboard.c (read_char): Call Lisp function help-form-show,
5145 instead of using internal_with_output_to_temp_buffer.
5146 (Qhelp_form_show): New var.
e0d38eeb 5147 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5148
5149 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5150
5151 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5152
e67a13ab
CY
51532011-04-06 Chong Yidong <cyd@stupidchicken.com>
5154
04f2d78b
CB
5155 * process.c (Flist_processes): Remove to Lisp.
5156 (list_processes_1): Delete.
e67a13ab 5157
973f782d
EZ
51582011-04-06 Eli Zaretskii <eliz@gnu.org>
5159
7c106b1e
EZ
5160 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5161
973f782d
EZ
5162 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5163
41cf7d1a 51642011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5165
ca23cc88
PE
5166 Fix more problems found by GCC 4.6.0's static checks.
5167
f390e2d5
PE
5168 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5169
42eea0d0
PE
5170 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5171
b69769da 5172 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5173
f9541e84
PE
5174 * xdisp.c (vmessage): Mark as a printf-like function.
5175
13841b55
PE
5176 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5177
c136c10f
PE
5178 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5179
5e2d4a30
PE
5180 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5181 printf-like functions.
5182 (tiff_load): Add casts to remove these marks before passing them
5183 to system-supplied API.
5184
583f48b9
PE
5185 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5186
b25d760e
PE
5187 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5188 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5189 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5190 directly, rather than having caller test rule sign. This avoids
5191 some unnecessary tests.
5192 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5193 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5194 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5195
bc7b6697 5196 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5197 (xfont_open): Avoid unnecessary tests.
bc7b6697 5198
27ccc379
PE
5199 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5200
dcd5c89a
PE
5201 * composite.h, composite.c (composition_gstring_put_cache):
5202 Use EMACS_INT, not int, for length.
5203
b13a45c6
PE
5204 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5205 breaking out part of COMPOSITION_DECODE_RULE.
5206 (COMPOSITION_DECODE_RULE): Use it.
5207 * composite.c (get_composition_id): Remove unused local vars,
5208 by using the new macro.
5209
1e792e4d
PE
5210 * textprop.c (set_text_properties_1): Change while to do-while,
5211 since the condition is always true at first.
5212
dc6c6455 5213 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5214 (interval_deletion_adjustment): Return unsigned value.
5215 All uses changed.
dc6c6455 5216
aba7731a
PE
5217 * process.c (list_processes_1, create_pty, read_process_output):
5218 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5219 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5220 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5221 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5222 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5223
fdfc4bf3
PE
5224 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5225
fca8fe46 5226 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5227 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5228
06a0259a 5229 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5230 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5231 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5232
e7b9e80f
PE
5233 * print.c (print_error_message): Avoid int overflow.
5234
56201685
PE
5235 * font.c (font_list_entities): Redo for clarity,
5236 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5237
78834453 5238 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5239 (font_score): Avoid potential overflow in diff calculation.
78834453 5240
0bc0b309 5241 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5242 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5243
e610eaca
PE
5244 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5245
b895abce
PE
5246 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5247 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5248 can always succeed if overflow has undefined behavior.
5249
1f1d9321 5250 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5251 (wordify): Omit three unnecessary tests.
1f1d9321 5252
c59478bc
PE
5253 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5254 All callers changed. This avoids the need for an unused var.
5255
79b73827
PE
5256 * casefiddle.c (casify_region): Remove var that is set but not used.
5257
a4db5dfe
PE
5258 * dired.c (file_name_completion): Remove var that is set but not used.
5259
43aae36e
PE
5260 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5261
2a47c44d 5262 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5263 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5264
a37c69bf
PE
5265 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5266 Check for integer overflow on size calculations.
5267
328ab8e7
PE
5268 * buffer.c (Fprevious_overlay_change): Remove var that is set
5269 but not used.
5270
e5a2a5cb
PE
5271 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5272 Remove vars that are set but not used.
8d84a6eb 5273 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5274 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5275
a60e5f68
PE
5276 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5277
f661cb61 5278 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5279 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5280
f0397f5a
PE
5281 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5282 that are set but not used.
5283
8664db06 5284 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5285 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5286
6abdaa4a
PE
5287 * xselect.c (x_get_local_selection, x_handle_property_notify):
5288 Remove vars that are set but not used.
5289
0ce7538d 5290 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5291 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5292
9ae848fc
PE
5293 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5294 Remove var that is set but not used.
0b918413
PE
5295 (scroll_bar_windows_size): Now size_t, not int.
5296 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5297 Check for overflow.
9ae848fc 5298
a5a62657
PE
5299 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5300 (map_tty_color) [!defined MSDOS]: Likewise.
5301
5c5cdd39
PE
5302 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5303
66ebf983
PE
5304 * coding.c: Remove vars that are set but not used.
5305 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5306 All callers changed.
5307 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5308 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5309 (decode_coding_charset): Remove vars that are set but not used.
5310
1be4d761
PE
5311 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5312 that is set but not used.
5313
47553fa8
PE
5314 * print.c (print_object): Remove var that is set but not used.
5315
1f7196bf 5316 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5317 The gnulib version avoids calling malloc in the usual case,
5318 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5319 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5320 * filelock.c (current_lock_owner): Likewise.
5321 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5322 * sysdep.c: Include allocator.h, careadlinkat.h.
5323 (emacs_no_realloc_allocator): New static constant.
5324 (emacs_readlink): New function.
fdb61804
PE
5325 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5326 ../lib/careadlinkat.h.
d1fdcab7 5327
f84c17c7
SM
53282011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5329
5330 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5331 first non-nil return value).
5332
ef3862ad
JD
53332011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5334
5335 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5336 if not defined (Bug#8403).
5337
376a7006
JB
53382011-04-02 Juanma Barranquero <lekktu@gmail.com>
5339
5340 * xdisp.c (display_count_lines): Remove parameter `start',
5341 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5342 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5343 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5344 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5345 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5346 and thereabouts. All callers changed.
5347 (get_per_char_metric): Remove parameter `f', unused since
5348 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5349
6ca3801d
JM
53502011-04-02 Jim Meyering <meyering@redhat.com>
5351
5352 do not dereference NULL upon failed strdup
5353 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5354 (ns_get_family): Likewise.
5355
d8e2b5ba
JB
53562011-04-02 Juanma Barranquero <lekktu@gmail.com>
5357
5358 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5359
8c74fcbd
JD
53602011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5361
5362 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5363 later (Bug#8403).
5364
7200d79c
SM
53652011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5366
03408648 5367 Add lexical binding.
7200d79c 5368
03408648
SM
5369 * window.c (Ftemp_output_buffer_show): New fun.
5370 (Fsave_window_excursion):
5371 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5372
5373 * lread.c (lisp_file_lexically_bound_p): New function.
5374 (Fload): Bind Qlexical_binding.
5375 (readevalloop): Remove `evalfun' arg.
5376 Bind Qinternal_interpreter_environment.
5377 (Feval_buffer): Bind Qlexical_binding.
5378 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5379 Mark as dynamic.
5380 (syms_of_lread): Declare `lexical-binding'.
5381
5382 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5383
5384 * keyboard.c (eval_dyn): New fun.
5385 (menu_item_eval_property): Use it.
ca105506
SM
5386
5387 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5388
03408648
SM
5389 * fns.c (concat, mapcar1): Accept byte-code-functions.
5390
5391 * eval.c (Fsetq): Handle lexical vars.
5392 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5393 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5394 (FletX, Flet): Obey lexical binding.
5395 (Fcommandp): Handle closures.
5396 (Feval): New `lexical' arg.
5397 (eval_sub): New function extracted from Feval. Use it almost
5398 everywhere where Feval was used. Look up vars in lexical env.
5399 Handle closures.
5400 (Ffunctionp): Move from subr.el.
5401 (Ffuncall): Handle closures.
5402 (apply_lambda): Remove `eval_flags'.
5403 (funcall_lambda): Handle closures and new byte-code-functions.
5404 (Fspecial_variable_p): New function.
5405 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5406 but without exporting it to Lisp.
23aba0ea 5407
23aba0ea 5408 * doc.c (Fdocumentation, store_function_docstring):
03408648 5409 * data.c (Finteractive_form): Handle closures.
23aba0ea 5410
03408648
SM
5411 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5412 interactive spec.
ba83908c 5413
04f2d78b
CB
5414 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5415 New byte-codes.
03408648
SM
5416 (exec_byte_code): New function extracted from Fbyte_code to handle new
5417 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5418
03408648 5419 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5420
03408648 5421 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5422
e2abce01
JB
54232011-03-31 Juanma Barranquero <lekktu@gmail.com>
5424
5425 * xdisp.c (redisplay_internal): Fix prototype.
5426
63696a73 54272011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5428
63696a73 5429 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5430 (try_scrolling): Use it when setting scroll_limit.
5431 Limit scrolling to 100 screen lines.
63696a73
EZ
5432 (redisplay_window): Even when falling back on "recentering",
5433 position point in the window according to scroll-conservatively,
5434 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5435
5436 (try_scrolling): When point is above the window, allow searching
5437 as far as scroll_max, or one screenful, to compute vertical
5438 distance from PT to the scroll margin position. This prevents
5439 try_scrolling from unnecessarily failing when
5440 scroll-conservatively is set to a value slightly larger than the
5441 window height. Clean up the case of PT below the margin at bottom
5442 of window: scroll_max can no longer be INT_MAX. When aggressive
5443 scrolling is in use, don't let point enter the opposite scroll
5444 margin as result of the scroll.
5445 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5446 threshold of 100 lines for never-recentering scrolling.
5447
e4cc2dfc
JB
54482011-03-31 Juanma Barranquero <lekktu@gmail.com>
5449
5450 * dispextern.h (move_it_by_lines):
5451 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5452 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5453 (message_log_check_duplicate): Remove parameters `prev_bol' and
5454 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5455 (redisplay_internal): Remove parameter `preserve_echo_area',
5456 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5457
5458 * indent.c (Fvertical_motion):
5459 * window.c (window_scroll_pixel_based, Frecenter):
5460 Don't pass `need_y_p' to `move_it_by_lines'.
5461
1c470562
SM
54622011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5463
44f230aa
SM
5464 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5465 steal a few bits to be more compact.
5466 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5467 Remove unneeded casts.
5468
1c470562
SM
5469 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5470
888adce9
ZK
54712011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5472
5473 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5474 binding" message (bug#7967).
5475
f838ed7b
PE
54762011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5477
77861b95
PE
5478 Fix more problems found by GCC 4.6.0's static checks.
5479
de6dbc14
PE
5480 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5481 Remove unused local var.
5482
f838ed7b
PE
5483 * editfns.c (Fmessage_box): Remove unused local var.
5484
792c7b2b
PE
5485 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5486 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5487 Omit unused local vars.
c499e557 5488 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5489 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5490 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5491 Omit unused local var.
5492
ba0165e1
PE
5493 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5494 Don't assume string length fits in int.
32ad8845 5495 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5496 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5497
3c59b4c9
PE
5498 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5499 instead of alloca (Bug#8344).
5500
a3eed478 5501 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5502 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5503
eb4d412d
PE
5504 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5505
1658b401
PE
5506 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5507 concerns.
5508
5509 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5510
5511 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5512
9a2c6e05
PE
5513 * keyboard.c (syms_of_keyboard): Use the same style as later
5514 in this function when indexing through an array. This also
5515 works around GCC bug 48267.
5516
03d0a109
PE
5517 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5518
44f730c8
PE
5519 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5520
fe75f926
PE
5521 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5522 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5523
ffa8c828
PE
5524 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5525 This avoids undefined behavior on integer overflow, and is a bit
5526 more convenient anyway since it is compared to a size_t variable.
5527
c5101a77
PE
5528 Variadic C functions now count arguments with size_t, not int.
5529 This avoids an unnecessary limitation on 64-bit machines, which
5530 caused (substring ...) to crash on large vectors (Bug#8344).
5531 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5532 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5533 All variadic functions and their callers changed accordingly.
c5101a77
PE
5534 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5535 * data.c (arith_driver, float_arith_driver): Likewise.
5536 * editfns.c (general_insert_function): Likewise.
5537 * eval.c (struct backtrace.nargs, interactive_p)
5538 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5539 (funcall_lambda, mark_backtrace): Likewise.
5540 * fns.c (concat): Likewise.
5541 * frame.c (x_set_frame_parameters): Likewise.
5542 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5543 0 if not found, not -1. All callers changed.
5544
dd3f25f7
PE
5545 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5546 (stack_copy_size): Now size_t, not int.
5547 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5548
461c2ab9
JB
55492011-03-28 Juanma Barranquero <lekktu@gmail.com>
5550
5551 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5552 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5553 All callers changed.
5554
5555 * lisp.h (multibyte_char_to_unibyte):
5556 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5557 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5558 * character.h (CHAR_TO_BYTE8):
5559 * cmds.c (internal_self_insert):
5560 * editfns.c (general_insert_function):
5561 * keymap.c (push_key_description):
5562 * search.c (Freplace_match):
5563 * xdisp.c (message_dolog, set_message_1): All callers changed.
5564
f6d62986
SM
55652011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5566
5567 * keyboard.c (safe_run_hook_funcall): New function.
5568 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5569 don't set the hook to nil, but remove the offending function instead.
5570 (Qcommand_hook_internal): Remove, unused.
5571 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5572 Vcommand_hook_internal.
5573
5574 * eval.c (enum run_hooks_condition): Remove.
5575 (funcall_nil, funcall_not): New functions.
5576 (run_hook_with_args): Call each function through a `funcall' argument.
5577 Remove `cond' argument, now redundant.
5578 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5579 (Frun_hook_with_args_until_failure): Adjust accordingly.
5580 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5581
1db5b1ad
JB
55822011-03-28 Juanma Barranquero <lekktu@gmail.com>
5583
5584 * dispextern.h (string_buffer_position): Remove declaration.
5585
5586 * print.c (strout): Remove parameter `multibyte', unused since
5587 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5588
5589 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5590 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5591 All callers changed.
5592
5593 * w32.c (_wsa_errlist): Use braces for struct initializers.
5594
5595 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5596 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5597 All callers changed.
5598 (string_buffer_position): Likewise. Also, make static (it's never
5599 used outside xdisp.c).
5600 (cursor_row_p): Remove parameter `w', unused since
5601 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5602 (decode_mode_spec): Remove parameter `precision', introduced during
5603 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5604 All callers changed.
5605
5ffb62aa
JD
56062011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5607
5608 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5609
461c2ab9 56102011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5611
5612 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5613 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5614 (ns_update_auto_hide_menu_bar): New functions.
5615 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5616 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5617 ns_constrain_all_frames.
5618 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5619 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5620
5c380ffb
JD
56212011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5622
5623 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5624
9af30bdf
GM
56252011-03-27 Glenn Morris <rgm@gnu.org>
5626
5627 * syssignal.h: Replace RETSIGTYPE with void.
5628 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5629 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5630 Replace SIGTYPE with void everywhere.
5631 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5632 * s/template.h (SIGTYPE): Remove commented out definition.
5633
e2abce01
JB
56342011-03-26 Eli Zaretskii <eliz@gnu.org>
5635
5636 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5637 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5638
f868cd8a
JB
56392011-03-26 Juanma Barranquero <lekktu@gmail.com>
5640
59eb0929
JB
5641 * w32.c (read_unc_volume): Use parameter `henum', instead of
5642 global variable `wget_enum_handle'.
5643
5644 * keymap.c (describe_vector): Remove parameters `indices' and
5645 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5646 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5647
f868cd8a
JB
5648 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5649
5650 * keyboard.c (timer_check): Remove parameter `do_it_now',
5651 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5652 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5653 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5654
5655 * keyboard.c (read_char):
5656 * w32menu.c (w32_menu_display_help):
5657 * xmenu.c (show_help_event, menu_help_callback):
5658 Adjust calls to `show_help_echo'.
5659
5660 * gtkutil.c (xg_maybe_add_timer):
5661 * keyboard.c (readable_events):
5662 * process.c (wait_reading_process_output):
5663 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5664
5665 * insdel.c (adjust_markers_gap_motion):
5666 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5667 (gap_left, gap_right): Don't call it.
5668
2ecf6fdb
CY
56692011-03-25 Chong Yidong <cyd@stupidchicken.com>
5670
5671 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5672 incurred during fontification.
5673
6b1f9ba4
JB
56742011-03-25 Juanma Barranquero <lekktu@gmail.com>
5675
5676 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5677 (DEFVAR_PER_BUFFER): Don't pass it.
5678
5679 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5680 (scrolling_window): Don't pass it.
5681
0f4a96b5
JB
56822011-03-25 Juanma Barranquero <lekktu@gmail.com>
5683
5684 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5685
5686 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5687 and `suffix'.
5688 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5689 of variables specific to SELinux and computation of `encoded_absname'.
5690
5691 * image.c (XPutPixel): Remove unused variable `height'.
5692
5693 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5694
5695 * unexw32.c (get_section_info): Remove unused variable `section'.
5696
5697 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5698 (system_process_attributes): Remove unused variable `sess'.
5699 (sys_read): Remove unused variable `err'.
5700
5701 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5702 (w32_wnd_proc): Remove unused variable `isdead'.
5703 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5704 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5705 (x_create_tip_frame): Remove unused variable `tem'.
5706
5707 * w32inevt.c (w32_console_read_socket):
5708 Remove unused variable `no_events'.
5709
5710 * w32term.c (x_draw_composite_glyph_string_foreground):
5711 Remove unused variable `width'.
5712
1149507c
JB
57132011-03-24 Juanma Barranquero <lekktu@gmail.com>
5714
5715 * w32term.c (x_set_glyph_string_clipping):
5716 Don't pass uninitialized region to CombineRgn.
5717
9c88f339
JB
57182011-03-23 Juanma Barranquero <lekktu@gmail.com>
5719
5720 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5721 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5722 (Fx_close_connection): Remove unused variable `i'.
5723
5724 * w32font.c (w32font_draw): Return number of glyphs.
5725 (w32font_open_internal): Remove unused variable `i'.
5726 (w32font_driver): Add missing initializer.
5727
5728 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5729 (fill_in_menu): Remove unused variable `items_added'.
5730
5731 * w32term.c (last_mouse_press_frame): Remove static global variable.
5732 (w32_clip_to_row): Remove unused variable `f'.
5733 (x_delete_terminal): Remove unused variable `i'.
5734
5735 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5736 (NOTHING): Remove unused static global variable.
5737 (uniscribe_check_otf): Remove unused variable `table'.
5738 (uniscribe_font_driver): Add missing initializers.
5739
dee091a3
JD
57402011-03-23 Julien Danjou <julien@danjou.info>
5741
5742 * term.c (Fsuspend_tty, Fresume_tty):
5743 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5744 * window.c (temp_output_buffer_show):
5745 * insdel.c (signal_before_change):
5746 * frame.c (Fhandle_switch_frame):
5747 * fileio.c (Fdo_auto_save):
5748 * emacs.c (Fkill_emacs):
5749 * editfns.c (save_excursion_restore):
5750 * cmds.c (internal_self_insert):
5751 * callint.c (Fcall_interactively):
5752 * buffer.c (Fkill_all_local_variables):
5753 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5754 Use Frun_hooks.
0f4a96b5 5755 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5756 unconditionnaly since it does the check itself.
5757
2c520ab5 57582011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5759
c9c49752
PE
5760 Fix more problems found by GCC 4.5.2's static checks.
5761
8abc3f12
PE
5762 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5763 the first time through the loop, since we know p0 < p1 then.
5764 This also avoids a gcc -Wstrict-overflow warning.
5765
a2d26660
PE
5766 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5767 leading to a memory leak, possible in functions like
5768 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5769 of objects (Bug#8318).
a2d26660 5770
916c72e9
PE
5771 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5772 that could (at least in theory) be that large.
5773
19ab8a18
PE
5774 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5775 This is less likely to overflow, and avoids undefined behavior if
5776 overflow does occur. All callers changed. Use strtoul to scan
5777 for the unsigned long integer.
b7cbbd6f
PE
5778 (pint2hrstr): Simplify and tune code slightly.
5779 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5780
f0641eff
PE
5781 * scroll.c (do_scrolling): Work around GCC bug 48228.
5782 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5783
7f650bb9
PE
5784 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5785 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5786 (validate_x_resource_name): Simplify count usage.
5787 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5788
37dd57d1
PE
5789 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5790 fail (Bug#8306).
81e56e61 5791
699979fc 5792 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5793
401bf9b4
PE
5794 * process.c (Fmake_network_process): Use socklen_t, not int,
5795 where POSIX says socklen_t is required in portable programs.
5796 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5797 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5798 (Fmake_network_process, server_accept_connection):
5799 (wait_reading_process_output, read_process_output):
5800 Likewise.
5801
b93aacde
PE
5802 * process.c: Rename or move locals to avoid shadowing.
5803 (list_processes_1, Fmake_network_process):
5804 (read_process_output_error_handler, exec_sentinel_error_handler):
5805 Rename or move locals.
4dc343ee 5806 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5807 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5808 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5809 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5810 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5811
af8a867c 5812 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5813 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5814 Include tparam.h instead, since it declares them.
af8a867c
PE
5815 * cm.h (PC): Remove extern decl; tparam.h now does this.
5816 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5817 * terminfo.c: Include tparam.h, to check interfaces.
5818 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5819 (tparam): Adjust signature to match interface in tparam.h;
5820 this removes some undefined behavior. Check that outstring and len
5821 are zero, which they always are with Emacs.
5822 * tparam.h (PC, BC, UP): New extern decls.
5823
0248044d 5824 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5825 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5826
8ff096c1 5827 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5828 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5829 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5830 (ftfont_list): Remove unused local.
49eaafba
PE
5831 (get_adstyle_property, ftfont_pattern_entity):
5832 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5833 Rename locals to avoid shadowing.
8ff096c1 5834
e2be39f6
PE
5835 * xfont.c (xfont_list_family): Mark var as initialized.
5836
c9735e30
PE
5837 * xml.c (make_dom): Now static.
5838
8f5201ae
PE
5839 * composite.c (composition_compute_stop_pos): Rename local to
5840 avoid shadowing.
b246f932
PE
5841 (composition_reseat_it): Remove unused locals.
5842 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5843 (composition_update_it): Mark var as initialized.
11b61122
PE
5844 (find_automatic_composition): Mark vars as initialized,
5845 with a FIXME (Bug#8290).
8f5201ae 5846
760fbc2c
PE
5847 character.h: Rename locals to avoid shadowing.
5848 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5849 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5850 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5851 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5852 to avoid shadowing.
5853
ff08eb85
PE
5854 * textprop.c (property_change_between_p): Remove; unused.
5855
fc7bf025
PE
5856 * intervals.c (interval_start_pos): Now static.
5857
235d7abc
PE
5858 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5859
44f230aa
SM
5860 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5861 Rename locals to avoid shadowing.
3e7d6594 5862
50060332
PE
5863 * sound.c (wav_play, au_play, Fplay_sound_internal):
5864 Fix pointer signedness.
d01f234b 5865 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5866 (wav_play): Initialize a variable to 0, to prevent undefined
5867 behavior (Bug#8278).
50060332 5868
c4fc4e30
PE
5869 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5870
918436ed
PE
5871 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5872
c939f91b
PE
5873 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5874 clobbering (Bug#8298).
b9c7f648
PE
5875 * sysdep.c (sys_subshell): Likewise.
5876 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5877
6bd8c144
PE
5878 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5879 This should get cleaned up, so that child_setup has the
5880 same signature on all platforms.
5881
7710357c 5882 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5883 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5884
c59da222
CY
58852011-03-22 Chong Yidong <cyd@stupidchicken.com>
5886
5887 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5888 not to be necessary, and produces flickering.
5889
66b87493
GM
58902011-03-20 Glenn Morris <rgm@gnu.org>
5891
5892 * config.in: Remove file.
5893
45b6f6d5
JB
58942011-03-20 Juanma Barranquero <lekktu@gmail.com>
5895
5896 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5897 are now in src/globals.h.
5898 (syms_of_minibuf): Remove spurious & from previous change.
5899
3ec03f7e
LL
59002011-03-20 Leo <sdl.web@gmail.com>
5901
5902 * minibuf.c (completing-read-function): New variable.
5903 (completing-read-default): Rename from completing-read.
5904 (completing-read): Call completing-read-function.
5905
b14e3e21
CY
59062011-03-19 Juanma Barranquero <lekktu@gmail.com>
5907
5908 * xfaces.c (Fx_load_color_file):
5909 Read color file from absolute filename (bug#8250).
5910
f2b726e6
JB
59112011-03-19 Juanma Barranquero <lekktu@gmail.com>
5912
5913 * makefile.w32-in: Update dependencies.
5914
09f6ff02
EZ
59152011-03-17 Eli Zaretskii <eliz@gnu.org>
5916
5917 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5918
29a6015a
PE
59192011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5920
a3a6c54e
PE
5921 Fix more problems found by GCC 4.5.2's static checks.
5922
b766f867
PE
5923 * process.c (make_serial_process_unwind, send_process_trap):
5924 (sigchld_handler): Now static.
5925
be02381c
PE
5926 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5927 That way, the code declares only the vars that it needs.
5928 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5929 * s/cygwin.h (PTY_ITERATION): Likewise.
5930 * s/darwin.h (PTY_ITERATION): Likewise.
5931 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5932
57048744
PE
5933 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5934 * process.c (allocate_pty): Don't declare stb unless it's needed.
5935
7914961c 5936 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5937 (CONSTANTLIM): Remove; unused.
5938 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5939 Define only if needed.
7914961c 5940
b3967b18
PE
5941 * unexelf.c (unexec): Name an expression,
5942 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5943 Use a different way to cause a compilation error if anyone uses
5944 n rather than nn, a way that does not involve shadowing.
73366a00 5945 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5946
29a6015a
PE
5947 * deps.mk (unexalpha.o): Remove; unused.
5948
43cfc33e 5949 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5950 * unexec.h: New file.
ce701a33
PE
5951 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5952 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5953 Depend on unexec.h.
5954 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5955 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5956 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5957 Change as necessary to match prototype in unexec.h.
ce701a33 5958
01f44d5a
PE
5959 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5960 shadowing.
4f63c6bb 5961 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5962
a6670b0b
PE
5963 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5964 Rename locals to avoid shadowing.
5965
cef2010d 5966 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5967 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5968
d4d7173a
PE
5969 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5970
f08b802a
PE
5971 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5972 warning when compiling print.c.
5973
3ddb0639
PE
5974 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5975 instead of using an uninitialized var.
5ad03b97 5976 (font_sort_entities): Mark var as initialized.
3ddb0639 5977
170a2692
PE
5978 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5979
e663c700
PE
5980 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5981 pointers to constants.
89bc529a 5982 (font_parse_fcname): Remove unused vars.
7b81e2d0 5983 (font_delete_unmatched): Now static.
ea838e10 5984 (font_get_spec): Remove; unused.
13a547c6
PE
5985 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5986 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5987 Rename or move locals to avoid shadowing.
e663c700 5988
2a80c887 5989 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5990 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5991
1384fa33 5992 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5993 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5994
8b2c52e9
PE
5995 * alloc.c (mark_backtrace): Move decl from here ...
5996 * lisp.h: ... to here, so that it can be checked.
5997
475545b5 5998 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5999 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6000 (lisp_indirect_variable): Name an expression,
6001 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6002 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6003
b1349114 6004 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6005 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6006 Use const pointer when appropriate.
b1349114 6007
a2928364
PE
6008 * lisp.h (get_system_name, get_operating_system_release):
6009 Move decls here, to check interfaces.
6010 * process.c (get_operating_system_release): Move decl to lisp.h.
6011 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6012 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6013 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6014 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6015 (Fformat_time_string, Fencode_time, Finsert_char):
6016 (Ftranslate_region_internal, Fformat):
6017 Rename or remove local vars to avoid shadowing.
9710023e 6018 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6019
a415e694
PE
6020 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6021 avoid shadowing.
6022
8ef4622d
PE
6023 * lisp.h (eassert): Check that the argument compiles, even if
6024 ENABLE_CHECKING is not defined.
6025
946f9a5b
PE
6026 * data.c (Findirect_variable): Name an expression, to avoid
6027 gcc -Wbad-function-cast warning.
112396d6 6028 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6029 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6030 (Fmake_variable_buffer_local, Fmake_local_variable):
6031 Mark variables as initialized.
52746918 6032 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6033
e5aab7e7 6034 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6035 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6036 Rename locals to avoid shadowing.
dff45157
PE
6037 (mark_stack): Move local variables into the #ifdef region where
6038 they're used.
7bc26fdb
PE
6039 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6040 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6041 needed otherwise.
6042 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6043 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6044 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6045
e5aab7e7
PE
6046 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6047 avoids undefined behavior in theory.
6048
4da60324
PE
6049 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6050
88043301
PE
6051 Use functions, not macros, for up- and down-casing (Bug#8254).
6052 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6053 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6054 to use the following functions instead of these macros.
6055 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6056 EMACS_INT, since callers assume the returned value fits in int.
6057 (upcase1): Likewise, for UPCASE_TABLE.
6058 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6059 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6060 the race-condition problem in the old DOWNCASE.
88043301 6061
19ed5445
PE
6062 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6063 Rename locals to avoid shadowing.
6064 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6065 (regex_compile, re_search_2, re_match_2_internal):
6066 Remove unused local vars.
952db0d7
PE
6067 (FREE_VAR): Rewrite so as not to use empty "else",
6068 which gcc can warn about.
da053e48 6069 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6070 (RETALLOC_IF): Define only if needed.
6071 (WORDCHAR_P): Likewise. This one is never needed, but is used
6072 only in a comment talking about a compiler bug, so put inside
6073 the #if 0 of that comment.
6074 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6075 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6076 Remove; unused.
19ed5445 6077
1f3561e4 6078 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6079 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6080 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6081
ded6f8f7
PE
6082 * search.c (simple_search): Remove unused var.
6083
dbd37a95
PE
6084 * dired.c (compile_pattern): Move decl from here ...
6085 * lisp.h: ... to here, so that it can be checked.
6086 (struct re_registers): New forward decl.
6087
7e47afad
PE
6088 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6089
85f24f61
PE
6090 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6091 All uses changed.
6092 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6093 Rename locals to avoid shadowing.
5671df8f 6094 (Fvertical_motion): Mark locals as initialized.
85f24f61 6095
181aa2be 6096 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6097 (casify_region): Mark local as initialized.
181aa2be 6098
930d429c
PE
6099 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6100
7082eac6
PE
6101 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6102 New macros, so that the caller can use some names other than
6103 gcpro1, gcpro2, etc.
6104 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6105 of the new macros.
6106 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6107 argument, for consistency with GCPRO2_VAR, etc: it is now the
6108 prefix of the variable, not the variable itself. All uses
6109 changed.
38b2c076
PE
6110 * dired.c (directory_files_internal, file_name_completion):
6111 Rename locals to avoid shadowing.
6112
15206ed9
PE
6113 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6114 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6115 dired.c's scmp function, had undefined behavior.
6116 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6117 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6118 * buffer.h: ... to here, because these macros use current_buffer,
6119 and the new implementation with inline functions needs to have
6120 current_buffer in scope now, rather than later when the macros
6121 are used.
6122 (downcase, upcase1): New static inline functions.
6123 (DOWNCASE, UPCASE1): Reimplement using these functions.
6124 This avoids undefined behavior in expressions like
6125 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6126 from race conditions in accessing the global variables
6127 case_temp1 and case_temp2.
6128 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6129 * lisp.h (case_temp1, case_temp2): Remove their decls.
6130 * character.h (ASCII_CHAR_P): Move from here ...
6131 * lisp.h: ... to here, so that the inline functions mentioned
6132 above can use them.
6133
4a6bea26
PE
6134 * dired.c (directory_files_internal_unwind): Now static.
6135
f14b7e14
PE
6136 * fileio.c (file_name_as_directory, directory_file_name):
6137 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6138 Now static.
2893f146
PE
6139 (file_name_as_directory): Use const pointers when appropriate.
6140 (Fexpand_file_name): Likewise. In particular, newdir might
6141 point at constant storage, so make it a const pointer.
fd4ead52 6142 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6143 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6144 signedness issues.
f839df0c
PE
6145 (Fset_file_times, Finsert_file_contents, auto_save_error):
6146 Rename locals to avoid shadowing.
f14b7e14 6147
5716756e 6148 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6149 (Ftry_completion, Fall_completions): Rename or remove locals
6150 to avoid shadowing.
5716756e 6151
b4c3046a
PE
6152 * marker.c (bytepos_to_charpos): Remove; unused.
6153
b45db522
PE
6154 * lisp.h (verify_bytepos, count_markers): New decls,
6155 so that gcc does not warn that these functions aren't declared.
6156
85876d07
PE
6157 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6158 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6159 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6160 (copy_text): Remove unused local var.
85876d07 6161
03d78a21 6162 * filelock.c (within_one_second): Now static.
b3dd38ab 6163 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6164
5df8f01b
PE
6165 * buffer.c (fix_overlays_before): Mark locals as initialized.
6166 (fix_start_end_in_overlays): Likewise. This function should be
6167 simplified by using pointers-to-pointers, but that's a different
6168 matter.
b1d876f1 6169 (switch_to_buffer_1): Now static.
8f54f30a
PE
6170 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6171 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6172
a70072c9 6173 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6174 Fix pointer signedness issue.
edced198
PE
6175 (sys_subshell): Mark local as volatile if checking for lint,
6176 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6177 (MAXPATHLEN): Define only if needed.
a70072c9 6178
a0977c44
PE
6179 * process.c (serial_open, serial_configure): Move decls from here ...
6180 * systty.h: ... to here, so that they can be checked.
6181
a884fdcc
PE
6182 * fns.c (get_random, seed_random): Move extern decls from here ...
6183 * lisp.h: ... to here, so that they can be checked.
6184
604efe86 6185 * sysdep.c (reset_io): Now static.
b8950c94 6186 (wait_for_termination_signal): Remove; unused.
604efe86 6187
38fc62d9
PE
6188 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6189 (copy_keymap_item, append_key, push_text_char_description):
6190 Now static.
1004a21a 6191 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6192 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6193 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6194 (describe_map_tree):
6195 Rename locals to avoid shadowing.
38fc62d9 6196
2f2650da
PE
6197 * keyboard.c: Declare functions static if they are not used elsewhere.
6198 (echo_char, echo_dash, cmd_error, top_level_2):
6199 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6200 (read_char, kbd_buffer_get_event, make_lispy_position):
6201 (make_lispy_event, make_lispy_movement, apply_modifiers):
6202 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6203 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6204 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6205 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6206 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6207
a053e86c 6208 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6209 (mark_kboards): Move decl here ...
6210 * alloc.c (mark_kboards): ... from here.
a053e86c 6211
4752793e
PE
6212 * lisp.h (force_auto_save_soon): New decl.
6213
74f10ca7 6214 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6215 (DEFINE_DUMMY_FUNCTION): New macro.
6216 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6217 Use it.
c03cd23f
PE
6218 (main): Add casts to avoid warnings
6219 if GCC considers string literals to be constants.
74f10ca7 6220
022e70d4
PE
6221 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6222
59d6fe83
PE
6223 * dbusbind.c: Pointer signedness fixes.
6224 (xd_signature, xd_append_arg, xd_initialize):
6225 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6226 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6227 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6228 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6229
78320123
PE
6230 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6231 if GCC considers string literals to be constants.
49cebcca 6232 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6233
35ac2a97
SM
62342011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6235
fb103ca9
SM
6236 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6237 (print_preprocess, print_object): New macro to fix last change.
6238
35ac2a97
SM
6239 * print.c (print_preprocess): Don't forget font objects.
6240
62973b41
JB
62412011-03-16 Juanma Barranquero <lekktu@gmail.com>
6242
6243 * emacs.c (USAGE3): Doc fixes.
6244
0e48bb22
AS
62452011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6246
6247 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6248 structure.
6249
7684e57b
JB
62502011-03-14 Juanma Barranquero <lekktu@gmail.com>
6251
6252 * lisp.h (VWindow_system, Qfile_name_history):
6253 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6254 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6255 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6256
6257 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6258 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6259
6260 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6261 * w32console.c (detect_input_pending, read_input_pending)
6262 (encode_terminal_code):
6263 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6264 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6265 (w32_system_caret_y, Qfile_name_history):
6266 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6267 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6268 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6269 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6270 * w32proc.c (Qlocal, report_file_error):
6271 * w32term.c (Vwindow_system, updating_frame):
6272 * w32uniscribe.c (initialized, uniscribe_font_driver):
6273 Remove unneeded extern declarations.
6274
2aa46d6c
CY
62752011-03-14 Chong Yidong <cyd@stupidchicken.com>
6276
c96bbc66 6277 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6278
cffc6f3b
CY
62792011-03-13 Chong Yidong <cyd@stupidchicken.com>
6280
6281 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6282 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6283 These macros can no longer be used for assignment.
6284
44f230aa
SM
6285 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6286 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6287 (record_buffer_markers, fetch_buffer_markers): New functions for
6288 recording and fetching special buffer markers.
6289 (set_buffer_internal_1, set_buffer_temp): Use them.
6290
6291 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6292
6293 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6294
6295 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6296 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6297
6298 * xdisp.c (hscroll_window_tree):
6299 (reconsider_clip_changes): Use PT instead of BUF_PT.
6300
d251f04b
EZ
63012011-03-13 Eli Zaretskii <eliz@gnu.org>
6302
6303 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6304 $(EMACS_ROOT)/lib/intprops.h.
6305
f0c77cd1
PE
63062011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6307
3eca4629
PE
6308 Fix more problems found by GCC 4.5.2's static checks.
6309
7c86ee98
PE
6310 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6311 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6312 (xg_free_frame_widgets): Make it clear that a local variable is
6313 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6314 (gdk_window_get_screen): Make it clear that this macro is needed
6315 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6316 (int_gtk_range_get_value): New function, which avoids a diagnostic
6317 from gcc -Wbad-function-cast.
6318 (xg_set_toolkit_scroll_bar_thumb): Use it.
6319 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6320 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6321 (get_utf8_string, xg_get_file_with_chooser):
6322 Rename locals to avoid shadowing.
6323 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6324
41729b81
PE
6325 * xgselect.c (xg_select): Remove unused var.
6326
f0c77cd1
PE
6327 * image.c (four_corners_best): Mark locals as initialized.
6328 (gif_load): Initialize transparent_p to zero (Bug#8238).
6329 Mark another local as initialized.
ec6cf4c6 6330 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6331
ce0ad53d 6332 * image.c (clear_image_cache): Now static.
d5d5a617 6333 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6334 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6335 (x_edge_detection): Remove unnecessary cast that
6336 gcc -Wbad-function-cast diagnoses.
2037898d 6337 (gif_load): Fix pointer signedness.
6ae141d6
PE
6338 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6339 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6340
33383987 63412011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6342
d32df629
PE
6343 Improve quality of tests for time stamp overflow.
6344 For example, without this patch (encode-time 0 0 0 1 1
6345 1152921504606846976) returns the obviously-bogus value (-948597
6346 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6347 reports time overflow. See
6348 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6349 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6350 * editfns.c: Include limits.h and intprops.h.
6351 (TIME_T_MIN, TIME_T_MAX): New macros.
6352 (time_overflow): Move earlier, to before first use.
6353 (hi_time, lo_time): New functions, for an accurate test for
6354 out-of-range times.
6355 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6356 (Fget_internal_run_time): Don't assume time_t fits in int.
6357 (make_time): Use list2 instead of Fcons twice.
6358 (Fdecode_time): More accurate test for out-of-range times.
6359 (check_tm_member): New function.
6360 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6361 (lisp_time_argument): Don't rely on undefined left-shift and
6362 right-shift behavior when checking for time stamp overflow.
8be6f318 6363
fe31d94c
PE
6364 * editfns.c (time_overflow): New function, refactoring common code.
6365 (Fformat_time_string, Fdecode_time, Fencode_time):
6366 (Fcurrent_time_string): Use it.
6367
8be6f318
PE
6368 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6369 * dired.c (make_time): Move to ...
6370 * editfns.c (make_time): ... here.
6371 * systime.h: Note the move.
6372
09d9db2c 63732011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6374
126bc0dc
YM
6375 * fringe.c (update_window_fringes): Remove unused variables.
6376
c47cbdfd
YM
6377 * unexmacosx.c (copy_data_segment): Also copy __got section.
6378 (Bug#8223)
6379
7ac80be9
EZ
63802011-03-12 Eli Zaretskii <eliz@gnu.org>
6381
c96bbc66 6382 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6383 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6384 Constify `char *' arguments and their references according to
6385 prototypes in tparam.h.
6386
ecb0f94d 6387 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6388
7ac80be9
EZ
6389 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6390 Adapt all references accordingly.
6391
6392 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6393
ef1fd07e
TT
63942011-03-11 Tom Tromey <tromey@redhat.com>
6395
6396 * buffer.c (syms_of_buffer): Remove obsolete comment.
6397
7ef4b50c
EZ
63982011-03-11 Eli Zaretskii <eliz@gnu.org>
6399
6400 * termhooks.h (encode_terminal_code): Declare prototype.
6401
6402 * msdos.c (encode_terminal_code): Don't declare prototype.
6403
6404 * term.c (encode_terminal_code): Now external again, used by
6405 w32console.c and msdos.c.
6406
44f230aa
SM
6407 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6408 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6409
4b1ec863 64102011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6411
1714f52b 6412 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6413
4b1ec863
PE
6414 * fringe.c (update_window_fringes): Mark locals as initialized
6415 (Bug#8227).
6416 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6417
524c7aa6
PE
6418 * alloc.c (mark_fringe_data): Move decl from here ...
6419 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6420 to check its interface.
6421 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6422
a5c0af81 6423 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6424 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6425 (fontset_font): Mark local as initialized.
a9a06e0b 6426 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6427
b4716021
PE
6428 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6429
811e9bac 6430 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6431 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6432 (x_own_selection, Fx_disown_selection_internal): Rename locals
6433 to avoid shadowing.
6434 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6435
7e3ab302
PE
6436 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6437 so that the caller can use some name other than gcpro1.
6438 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6439 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6440 (Fx_backspace_delete_keys_p):
6441 Use them to avoid shadowing, and rename vars to avoid shadowing.
6442 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6443 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6444 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6445 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6446 Remove unused locals.
7e3ab302
PE
6447 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6448 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6449 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6450 macros.
f78faa98 6451
e2b13473
PE
6452 * xterm.h (x_mouse_leave): New decl.
6453
77f23912
PE
6454 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6455 Remove unused functions.
cdf4ba58
PE
6456 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6457 (x_calc_absolute_position): Now static.
7411c686 6458 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6459 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6460 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6461 unless they are used.
38d0b34a
PE
6462 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6463 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6464 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6465 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6466 (x_error_catcher, x_connection_closed, x_error_handler):
6467 (x_error_quitter, xembed_send_message, x_iconify_frame):
6468 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6469 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6470 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6471
44f230aa
SM
6472 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6473 Rename or move locals to avoid shadowing.
6b463e58 6474 (tty_defined_color, merge_face_heights): Now static.
5967d051 6475 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6476 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6477 does not deduce is never used uninitialized.
73719eba
PE
6478 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6479 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6480
426994c3 6481 * terminal.c (store_terminal_param): Now static.
5489860b 6482
032f1620 6483 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6484 (set_frame_menubar): Remove unused local.
d4323972 6485 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6486 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6487 since they might point to immutable storage.
281585b0
PE
6488 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6489 since it's unused otherwise.
032f1620 6490
367c19e5 6491 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6492 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6493 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6494 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6495 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6496 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6497 does not deduce are never used uninitialized.
70739cbe 6498
07b48fa9
PE
6499 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6500
8868a238 6501 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6502 * window.c (window_loop, size_window):
6503 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6504
7e5cf297 6505 * window.c (display_buffer): Now static.
d6550a9f
PE
6506 (size_window): Mark variables that gcc -Wuninitialized
6507 does not deduce are never used uninitialized.
a586633d
PE
6508 * window.h (check_all_windows): New decl, to forestall
6509 gcc -Wmissing-prototypes diagnostic.
5b555da1 6510 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6511
f6095868
PE
6512 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6513 shadowing.
6514 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6515 Include <limits.h>.
6516 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6517 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6518 (load_charset_map): Mark variables that gcc -Wuninitialized
6519 does not deduce are never used uninitialized.
53df7c11 6520 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6521
f38b440c
PE
6522 * coding.c (coding_set_source, coding_set_destination):
6523 Use "else { /* comment */ }" rather than "else /* comment */;"
6524 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6525 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6526 a block, when the outer 'i' will do.
6527 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6528 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6529 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6530 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6531 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6532 Rename locals to avoid shadowing.
6533 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6534 * coding.c (emacs_mule_char, encode_invocation_designation):
6535 Now static, since they're not used elsewhere.
413bb2db 6536 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6537 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6538 (decode_coding_emacs_mule): Mark variables that gcc
6539 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6540 (detect_coding_iso_2022): Initialize a local variable that might
6541 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6542 this initialization is needed. (Bug#8211)
5f58e762
PE
6543 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6544 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6545 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6546 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6547 Remove unused macros.
f38b440c 6548
232b38b9 6549 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6550 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6551 * character.c (string_count_byte8): Likewise.
232b38b9 6552
fb90da1b
PE
6553 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6554 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6555
fb93dbc2
PE
6556 * chartab.c (copy_sub_char_table): Now static, since it's not used
6557 elsewhere.
5c156ace
PE
6558 (sub_char_table_ref_and_range, char_table_ref_and_range):
6559 Rename locals to avoid shadowing.
bbcd0949 6560 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6561
7d3b3862 6562 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6563 (BIDI_BOB): Remove unused macro.
7d3b3862 6564
6be7d3da
PE
6565 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6566 deduce are never used uninitialized.
c2ed9c8b 6567 * term.c (encode_terminal_code): Likewise.
6be7d3da 6568
75f8807f 6569 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6570
50938595
PE
6571 * tparam.h: New file.
6572 * term.c, tparam.h: Include it.
6573 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6574 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6575 Move these decls to tparam.h, and make them agree with what
6576 is actually in tparam.c. The previous trick of using incompatible
6577 decls in different modules does not conform to the C standard.
6578 All callers of tparam changed to use tparam's actual API.
6579 * tparam.c (tparam1, tparam, tgoto):
6580 Use const pointers where appropriate.
6581
fbceeba2
PE
6582 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6583 * cm.h (struct cm): Likewise.
6584 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6585 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6586 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6587 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6588 (turn_on_face, init_tty): Likewise.
6589 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6590
7f3f1250
PE
6591 * term.c (term_mouse_position): Rename local to avoid shadowing.
6592
e6ca6543
PE
6593 * alloc.c (mark_ttys): Move decl from here ...
6594 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6595
c40f8d15
AS
65962011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6597
6598 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6599
cfe0661d
JB
66002011-03-09 Juanma Barranquero <lekktu@gmail.com>
6601
6602 * search.c (compile_pattern_1): Remove argument regp, unused since
6603 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6604 (compile_pattern): Don't pass it.
6605
0afb4571
J
66062011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6607
6608 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6609 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6610 for ! HAVE_GTK3.
6611 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6612
6613 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6614
6615 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6616 gdk_window_get_screen, gdk_window_get_geometry,
6617 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6618 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6619 (xg_get_pixbuf_from_pixmap): New function.
6620 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6621 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6622 Call xg_get_pixbuf_from_pixmap instead of
6623 gdk_pixbuf_get_from_drawable.
6624 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6625 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6626 (xg_check_special_colors): Use GtkStyleContext and its functions
6627 for HAVE_GTK3.
6628 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6629 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6630 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6631 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6632 Call gtk_widget_get_preferred_size.
0afb4571
J
6633 (xg_frame_resized): gdk_window_get_geometry only takes 5
6634 parameters.
44f230aa
SM
6635 (xg_win_to_widget, xg_event_is_for_menubar):
6636 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6637 (xg_set_widget_bg): New function.
6638 (delete_cb): New function.
895009e1 6639 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6640 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6641 (xg_set_background_color): Call xg_set_widget_bg.
6642 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6643 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6644 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6645 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6646 if ! HAVE_GTK3.
6647 (update_frame_tool_bar): Call gtk_widget_hide.
6648 (xg_initialize): Use GDK_KEY_g.
6649
6650 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6651 if ! HAVE_GTK3
6652 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6653
6654 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6655 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6656 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6657
1c2cc4ef
JB
66582011-03-08 Juanma Barranquero <lekktu@gmail.com>
6659
6660 * w32xfns.c (select_palette): Check success of RealizePalette against
6661 GDI_ERROR, not zero.
6662
33383987 6663See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6664
6665;; Local Variables:
6666;; coding: utf-8
aac0c6e3
MR
6667;; End:
6668
33383987 6669 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6670
6671 This file is part of GNU Emacs.
6672
6673 GNU Emacs is free software: you can redistribute it and/or modify
6674 it under the terms of the GNU General Public License as published by
6675 the Free Software Foundation, either version 3 of the License, or
6676 (at your option) any later version.
6677
6678 GNU Emacs is distributed in the hope that it will be useful,
6679 but WITHOUT ANY WARRANTY; without even the implied warranty of
6680 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6681 GNU General Public License for more details.
6682
6683 You should have received a copy of the GNU General Public License
6684 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.