* character.h (CHAR_VALID_P): Remove unused parameter.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
13bdea59
PE
12011-06-13 Paul Eggert <eggert@cs.ucla.edu>
2
2638320e
PE
3 * character.h (CHAR_VALID_P): Remove unused parameter.
4 * fontset.c, lisp.h, xdisp.c: All uses changed.
5
045eb8d9
PE
6 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7
c1f134b5
PE
8 * fns.c (concat): Minor tuning based on overflow analysis.
9 This doesn't fix any bugs. Use int to hold character, instead
10 of constantly refetching from Emacs object. Use XFASTINT, not
11 XINT, for value known to be a character. Don't bother comparing
12 a single byte to 0400, as it's always less.
13
395fcb93 14 * floatfns.c (Fexpt):
327eeec8
PE
15 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
16
abbd3d23
PE
17 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
18 for characters.
19
684a03ef
PE
20 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
21
0fed43f3
PE
22 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
23 Without this fix, on a 64-bit host (aset S 0 4294967386) would
24 incorrectly succeed when S was a string, because 4294967386 was
25 truncated before it was used.
26
8fd02eb7
PE
27 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
28 Otherwise, an out-of-range integer could cause undefined behavior
29 on a 64-bit host.
30
f8c86b69
PE
31 * composite.c: Use int, not EMACS_INT, for characters.
32 (fill_gstring_body, composition_compute_stop_pos): Use int, not
33 EMACS_INT, for values that are known to be in character range.
34 This doesn't fix any bugs but is the usual style inside Emacs and
35 may generate better code on 32-bit machines.
36
34206dd2
PE
37 Make sure a 64-bit char is never passed to ENCODE_CHAR.
38 This is for reasons similar to the recent CHAR_STRING fix.
39 * charset.c (Fencode_char): Check that character arg is actually
40 a character. Pass an int to ENCODE_CHAR.
41 * charset.h (ENCODE_CHAR): Verify that the character argument is no
42 wider than 'int', as a compile-time check to prevent future regressions
43 in this area.
44
c5958d4c 45 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
46
47 Make sure a 64-bit char is never passed to CHAR_STRING.
48 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
49 by silently ignoring the top 32 bits, allowing some values
50 that were far too large to be valid characters.
51 * character.h: Include <verify.h>.
52 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
53 arguments are no wider than unsigned, as a compile-time check
54 to prevent future regressions in this area.
55 * data.c (Faset):
56 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char):
57 (Fsubst_char_in_region):
58 * fns.c (concat):
59 * xdisp.c (decode_mode_spec_coding):
60 Adjust to CHAR_STRING's new requirement.
61 * editfns.c (Finsert_char, Fsubst_char_in_region):
62 * fns.c (concat): Check that character args are actually
63 characters. Without this test, these functions did the wrong
64 thing with wildly out-of-range values on 64-bit hosts.
65
ea204efb
PE
662011-06-12 Paul Eggert <eggert@cs.ucla.edu>
67
d37ca623
PE
68 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
69 These casts should not be needed on 32-bit hosts, either.
70 * keyboard.c (read_char):
71 * lread.c (Fload): Remove casts to unsigned.
72
ea204efb
PE
73 * lisp.h (UNSIGNED_CMP): New macro.
74 This fixes comparison bugs on 64-bit hosts.
75 (ASCII_CHAR_P): Use it.
76 * casefiddle.c (casify_object):
77 * character.h (ASCII_BYTE_P, CHAR_VALID_P):
78 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
79 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
80 * dispextern.h (FACE_FROM_ID):
81 * keyboard.c (read_char): Use UNSIGNED_CMP.
82
fc83f7d3 832011-06-11 Paul Eggert <eggert@cs.ucla.edu>
666398f3 84
41cb286c
PE
85 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
86 not to EMACS_INT, to avoid GCC warning.
87
4a1b9832
PE
88 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
89
55daad71
PE
90 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
91 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
92 isn't needed on 32-bit machines.
8f95c75c 93
666398f3 94 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
0ceccced 95 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
96
97 * data.c (Qcompiled_function): Now static.
98
c6f072e7
PE
99 * window.c (window_body_lines): Now static.
100
20ce5912
PE
101 * image.c (gif_load): Rename local to avoid shadowing.
102
9c4c5f81
PE
103 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
104 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
105 * alloc.c (make_save_value): Integer argument is now of type
106 ptrdiff_t, not int.
107 (mark_object): Use ptrdiff_t, not int.
108 * lisp.h (pD): New macro.
109 * print.c (print_object): Use it.
110
c0c5c8ae
PE
111 * alloc.c: Use EMACS_INT, not int, to count objects.
112 (total_conses, total_markers, total_symbols, total_vector_size)
113 (total_free_conses, total_free_markers, total_free_symbols)
114 (total_free_floats, total_floats, total_free_intervals, total_intervals)
115 (total_strings, total_free_strings):
116 Now EMACS_INT, not int. All uses changed.
117 (Fgarbage_collect): Compute overall total using a double, so that
118 integer overflow is less likely to be a problem. Check for overflow
119 when converting back to an integer.
5a25e253
PE
120 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
121 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
122 These were 'int' variables that could overflow on 64-bit hosts;
123 they were never used, so remove them instead of repairing them.
211a0b2a 124 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
125 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
126 Previously, this ceilinged at INT_MAX, but that doesn't work on
127 64-bit machines.
e46bb31a 128 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 129
c78baabf 130 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 131 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
132 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
133 when a (possibly-narrower) signed value would do just as well.
134 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 135
c9d624c6
PE
136 * alloc.c: Catch some string size overflows that we were missing.
137 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
138 for convenience in STRING_BYTES_MAX.
139 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
140 The definition here is exact; the one in lisp.h was approximate.
141 (allocate_string_data): Check for string overflow. This catches
142 some instances we weren't catching before. Also, it catches
143 size_t overflow on (unusual) hosts where SIZE_MAX <= min
144 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
145 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 146
c9d624c6
PE
147 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
148 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
149 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
150
353032ce
PE
151 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
152
2bccce07
PE
153 * alloc.c (Fmake_string): Check for out-of-range init.
154
b50691aa
CY
1552011-06-11 Chong Yidong <cyd@stupidchicken.com>
156
157 * dispextern.h (struct image): Replace data member, whose int_val
158 and ptr_val fields were not used by anything, with a single
159 lisp_val object.
160
161 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
162 (gif_clear_image, gif_load, imagemagick_load_image)
163 (gs_clear_image, gs_load): Callers changed.
164
3f754b86
PE
1652011-06-10 Paul Eggert <eggert@cs.ucla.edu>
166
cca69397
PE
167 * buffer.h: Include <time.h>, for time_t.
168 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
169
109e28d0
PE
170 Fix minor problems found by static checking.
171
60737f02
PE
172 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
173
4b66faf3
PE
174 Make identifiers static if they are not used in other modules.
175 * data.c (Qcompiled_function, Qframe, Qvector):
176 * image.c (QimageMagick, Qsvg):
177 * minibuf.c (Qmetadata):
178 * window.c (resize_window_check, resize_root_window): Now static.
179 * window.h (resize_window_check, resize_root_window): Remove decls.
180
109e28d0
PE
181 * window.c (window_deletion_count, delete_deletable_window):
182 Remove; unused.
46a4ce9e
PE
183 (window_body_lines): Now static.
184 (Fdelete_other_windows_internal): Mark vars as initialized.
185 Make sure 'resize_failed' is initialized.
186 (run_window_configuration_change_hook): Rename local to avoid shadowing.
187 (resize_window_apply): Remove unused local.
188 * window.h (delete_deletable_window): Remove decl.
189
109e28d0 190 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
191 (imagemagick_load_image): Fix pointer signedness problem by changing
192 last arg from unsigned char * to char *. All uses changed.
193 Also, fix a local for similar reasons.
194 Remove unused locals. Remove locals to avoid shadowing.
195 (fn_rsvg_handle_free): Remove; unused.
196 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 197 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 198
3f754b86
PE
199 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
200
2547adb1
CY
2012011-06-10 Chong Yidong <cyd@stupidchicken.com>
202
203 * image.c (gif_load): Fix omitted cast error introduced by
204 2011-06-06 change.
205
2c8e37d4
MR
2062011-06-10 Martin Rudalics <rudalics@gmx.at>
207
208 * window.h (resize_proportionally, orig_total_lines)
209 (orig_top_line): Remove from window structure.
210 (set_window_height, set_window_width, change_window_heights)
211 (Fdelete_window): Remove prototypes.
212 (resize_frame_windows): Remove duplicate declaration.
213
440a42e3
EZ
2142011-06-10 Eli Zaretskii <eliz@gnu.org>
215
216 * window.h (resize_frame_windows, resize_window_check)
217 (delete_deletable_window, resize_root_window)
218 (resize_frame_windows): Declare prototypes.
219
220 * window.c (resize_window_apply): Make definition be "static" to
221 match the prototype.
222
562dd5e9
MR
2232011-06-10 Martin Rudalics <rudalics@gmx.at>
224
225 * window.c: Remove declarations of Qwindow_size_fixed,
226 window_min_size_1, window_min_size_2, window_min_size,
227 size_window, window_fixed_size_p, enlarge_window, delete_window.
228 Remove static from declaration of Qdelete_window, it's
229 temporarily needed by Fbury_buffer.
230 (replace_window): Don't assign orig_top_line and
231 orig_total_lines.
232 (Fdelete_window, delete_window): Remove. Window deletion is
233 handled by window.el.
234 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
235 Fdelete_window calls with calls to Qdelete_window.
236 (Fdelete_other_windows): Remove. Deleting other windows is
237 handled by window.el.
238 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
239 handled in window.el.
240 (window_min_size_2, window_min_size_1, window_min_size): Remove.
241 Window minimum sizes are handled in window.el.
242 (shrink_windows, size_window, set_window_height)
243 (set_window_width, change_window_heights, window_height)
244 (window_width, CURBEG, CURSIZE, enlarge_window)
245 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
246 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
247 handled in window.el.
248 (make_dummy_parent): Rename to make_parent_window and give it a
249 second argument horflag.
250 (make_window): Don't set resize_proportionally any more.
251 (Fsplit_window): Remove. Windows are split in window.el.
252 (save_restore_action, save_restore_orig_size)
253 (shrink_window_lowest_first, save_restore_orig_size): Remove.
254 Resize mini windows in window.el.
255 (grow_mini_window, shrink_mini_window): Implement by calling
256 Qresize_root_window_vertically, resize_window_check and
257 resize_window_apply.
258 (saved_window, Fset_window_configuration, save_window_save): Do
259 not handle orig_top_line, orig_total_lines, and
260 resize_proportionally.
261 (window_min_height, window_min_width): Move to window.el.
262 (keys_of_window): Move bindings for delete-other-windows,
263 split-window, delete-window and enlarge-window to window.el.
264
265 * buffer.c: Temporarily extern Qdelete_window.
266 (Fbury_buffer): Temporarily call Qdelete_window instead of
267 Fdelete_window (Fbury_buffer will move to window.el soon).
268
269 * frame.c (set_menu_bar_lines_1): Remove code handling
270 orig_top_line and orig_total_lines.
271
272 * dispnew.c (adjust_frame_glyphs_initially): Don't use
273 set_window_height but set heights directly.
274 (change_frame_size_1): Use resize_frame_windows.
275
276 * xdisp.c (init_xdisp): Don't use set_window_height but set
277 heights directly.
278
279 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
280 resize_frame_windows instead of change_window_heights and run
281 run_window_configuration_change_hook.
282
283 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
284 instead of change_window_heights and run
285 run_window_configuration_change_hook.
286
1a13852e
MR
2872011-06-09 Martin Rudalics <rudalics@gmx.at>
288
289 * window.c (replace_window): Rename second argument REPLACEMENT to
290 NEW. New third argument SETFLAG. Rewrite.
291 (delete_window, make_dummy_parent): Call replace_window with
292 third argument 1.
293 (window_list_1): Move down in code.
294 (run_window_configuration_change_hook): Move set_buffer part
295 before select_frame_norecord part in order to unwind correctly.
296 Rename count1 to count.
297 (recombine_windows, delete_deletable_window, resize_root_window)
298 (Fdelete_other_windows_internal)
299 (Frun_window_configuration_change_hook, make_parent_window)
300 (resize_window_check, resize_window_apply, Fresize_window_apply)
301 (resize_frame_windows, Fsplit_window_internal)
302 (Fdelete_window_internal, Fresize_mini_window_internal): New
303 functions.
304 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
305
f3d1777e
MR
3062011-06-08 Martin Rudalics <rudalics@gmx.at>
307
496e208e
MR
308 * window.h (window): Add some new members to window structure -
309 normal_lines, normal_cols, new_total, new_normal, clone_number,
310 splits, nest, prev_buffers, next_buffers.
311 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 312 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 313
f3d1777e
MR
314 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
315 Remove.
496e208e
MR
316 (make_dummy_parent): Set new members of windows structure.
317 (make_window): Move down in code. Handle new members of window
318 structure.
319 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
320 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
321 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
322 (Fset_window_prev_buffers, Fwindow_next_buffers)
323 (Fset_window_next_buffers, Fset_window_clone_number): New
324 functions.
325 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
326 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
327 Doc-string fixes.
328 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
329 Argument WINDOW can be now internal window too.
330 (Fwindow_use_time): Move up in code.
331 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
332 Rewrite doc-string.
333 (Fset_window_configuration, saved_window)
334 (Fcurrent_window_configuration, save_window_save): Handle new
335 members of window structure.
b9e809c2
MR
336 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
337 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
338 (syms_of_window): New Lisp objects Qrecord_window_buffer,
339 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
340 Qget_mru_window, Qresize_root_window,
341 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
342 Qauto_buffer_name; staticpro them.
f3d1777e 343
abde8f8c
MR
3442011-06-07 Martin Rudalics <rudalics@gmx.at>
345
346 * window.c (Fwindow_total_size, Fwindow_left_column)
347 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
348 (Fwindow_list_1): New functions.
349 (window_box_text_cols): Replace with window_body_cols.
350 (Fwindow_width, Fscroll_left, Fscroll_right): Use
351 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
352 (delete_window, Fset_window_configuration): Call
353 delete_all_subwindows with window as argument.
354 (delete_all_subwindows): Take a window as argument and not a
355 structure. Rewrite.
190b47e6
MR
356 (window_loop): Remove handling of GET_LRU_WINDOW and
357 GET_LARGEST_WINDOW.
358 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
359
360 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
361 window_box_text_cols. delete_all_subwindows now takes a
362 Lisp_Object as argument.
abde8f8c
MR
363
364 * indent.c (compute_motion, Fcompute_motion): Use
365 window_body_cols instead of window_box_text_cols.
366
fa8a67e6
MR
367 * frame.c (delete_frame): Call delete_all_subwindows with root
368 window as argument.
369
a54e3482
DC
3702011-06-07 Daniel Colascione <dan.colascione@gmail.com>
371
372 * fns.c (Fputhash): Document return value.
373
60002bf5
CY
3742011-06-06 Chong Yidong <cyd@stupidchicken.com>
375
376 * image.c (gif_load): Implement gif89a spec "no disposal" method.
377
0c671da6 3782011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 379
b862a52a 380 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 381
be44ca6c
PE
382 Check for overflow when converting integer to cons and back.
383 * charset.c (Fdefine_charset_internal, Fdecode_char):
384 Use cons_to_unsigned to catch overflow.
385 (Fencode_char): Use INTEGER_TO_CONS.
386 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
387 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
388 * data.c (long_to_cons, cons_to_long): Remove.
389 (cons_to_unsigned, cons_to_signed): New functions.
390 These signal an error for invalid or out-of-range values.
391 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
392 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
393 * font.c (Ffont_variation_glyphs):
394 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
395 * lisp.h: Include <intprops.h>.
396 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
397 (cons_to_signed, cons_to_unsigned): New decls.
398 (long_to_cons, cons_to_long): Remove decls.
399 * undo.c (record_first_change): Use INTEGER_TO_CONS.
400 (Fprimitive_undo): Use CONS_TO_INTEGER.
401 * xfns.c (Fx_window_property): Likewise.
402 * xselect.c: Include <limits.h>.
403 (x_own_selection, selection_data_to_lisp_data):
404 Use INTEGER_TO_CONS.
405 (x_handle_selection_request, x_handle_selection_clear)
406 (x_get_foreign_selection, Fx_disown_selection_internal)
407 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
408 (lisp_data_to_selection_data): Use cons_to_unsigned.
409 (x_fill_property_data): Use cons_to_signed.
410 Report values out of range.
411
d1f3d2af
PE
412 Check for buffer and string overflow more precisely.
413 * buffer.h (BUF_BYTES_MAX): New macro.
414 * lisp.h (STRING_BYTES_MAX): New macro.
415 * alloc.c (Fmake_string):
416 * character.c (string_escape_byte8):
417 * coding.c (coding_alloc_by_realloc):
418 * doprnt.c (doprnt):
419 * editfns.c (Fformat):
420 * eval.c (verror):
421 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
422 since they may not be the same number.
423 * editfns.c (Finsert_char):
424 * fileio.c (Finsert_file_contents):
425 Likewise for BUF_BYTES_MAX.
426
dd52fcea
PE
427 * image.c: Use ptrdiff_t, not int, for sizes.
428 (slurp_file): Switch from int to ptrdiff_t.
429 All uses changed.
430 (slurp_file): Check that file size fits in both size_t (for
431 malloc) and ptrdiff_t (for sanity and safety).
432
7f9bbdbb
PE
433 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
434 if b->modtime has its maximal value.
435
dfe18f82
PE
436 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
437
84acfcf0
PE
438 Don't assume time_t can fit into int.
439 * buffer.h (struct buffer.modtime): Now time_t, not int.
440 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
441 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
442
ccd9a01a
PE
443 Minor fixes for signed vs unsigned integers.
444 * character.h (MAYBE_UNIFY_CHAR):
445 * charset.c (maybe_unify_char):
446 * keyboard.c (read_char, reorder_modifiers):
447 XINT -> XFASTINT, since the integer must be nonnegative.
448 * ftfont.c (ftfont_spec_pattern):
449 * keymap.c (access_keymap, silly_event_symbol_error):
450 XUINT -> XFASTINT, since the integer must be nonnegative.
451 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
452 since it makes no difference and we prefer signed.
453 * keyboard.c (record_char): Use XUINT when all the neighbors do.
454 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
455 nonnegative.
456
d6d100dd
SM
4572011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
458
459 * window.h (Fwindow_frame): Declare.
460
2b6148e4
PE
4612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
462
463 * alloc.c: Simplify handling of large-request failures (Bug#8800).
464 (SPARE_MEMORY): Always define.
465 (LARGE_REQUEST): Remove.
466 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
467
f230ecc9
MR
4682011-06-06 Martin Rudalics <rudalics@gmx.at>
469
727e958e
MR
470 * lisp.h: Move EXFUNS for Fframe_root_window,
471 Fframe_first_window and Fset_frame_selected_window to window.h.
472
473 * window.h: Move EXFUNS for Fframe_root_window,
474 Fframe_first_window and Fset_frame_selected_window here from
475 lisp.h.
476
477 * frame.c (Fwindow_frame, Fframe_first_window)
478 (Fframe_root_window, Fframe_selected_window)
479 (Fset_frame_selected_window): Move to window.c.
480 (Factive_minibuffer_window): Move to minibuf.c.
481 (Fother_visible_frames_p): New function.
482
483 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
484
f230ecc9
MR
485 * window.c (decode_window, decode_any_window): Move up in code.
486 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
487 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
488 (Fwindow_buffer): Move up and rewrite doc-string.
489 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
490 (Fwindow_prev): New functions.
727e958e
MR
491 (Fwindow_frame): Move here from frame.c. Accept any window as
492 argument.
493 (Fframe_root_window, Fframe_first_window)
494 (Fframe_selected_window): Move here from frame.c. Accept frame
495 or arbitrary window as argument. Update doc-strings.
496 (Fminibuffer_window): Move up in code.
497 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
498 (Fset_frame_selected_window): Move here from frame.c.
499 Marginal rewrite.
727e958e
MR
500 (Fselected_window, select_window, Fselect_window): Move up in
501 code. Minor doc-string fixes.
f230ecc9 502
4d09bcf6
PE
5032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
504
505 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
506 Do not assume that spare memory exists; that assumption is valid
507 only if SYSTEM_MALLOC.
508 (LARGE_REQUEST): New macro, so that the issue of large requests
509 is separated from the issue of spare memory.
510
810928a2
AS
5112011-06-05 Andreas Schwab <schwab@linux-m68k.org>
512
172418ad
AS
513 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
514 format. (Bug#8806)
515
43f862f7
AS
516 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
517
810928a2
AS
518 * xfns.c (x_set_scroll_bar_default_width): Move declarations
519 before statements.
520
a059fe24
JD
5212011-06-05 Jan Djärv <jan.h.d@swipnet.se>
522
523 * gtkutil.c (xg_get_default_scrollbar_width): New function.
524
525 * gtkutil.h: Declare xg_get_default_scrollbar_width.
526
527 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
528 min width by calling x_set_scroll_bar_default_width (Bug#8505).
529
989bf368
JB
5302011-06-05 Juanma Barranquero <lekktu@gmail.com>
531
532 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
533
4b80f674
CY
5342011-06-04 Chong Yidong <cyd@stupidchicken.com>
535
536 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
537 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
538 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
539 New error handlers.
4b80f674
CY
540 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
541 Obey Vx_select_enable_clipboard_manager. Catch errors in
542 x_clipboard_manager_save (Bug#8779).
543 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 544 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 545
99a33b77 5462011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
547
548 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
549
99a33b77 5502011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
551
552 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
553 in the current matrix if keep_current_p is non-zero.
554
8264569d
EZ
5552011-06-04 Eli Zaretskii <eliz@gnu.org>
556
557 * bidi.c (bidi_level_of_next_char): Fix last change.
558
57f97249
EZ
5592011-06-03 Eli Zaretskii <eliz@gnu.org>
560
fec2107c 561 Support bidi reordering of text covered by display properties.
57f97249 562
fec2107c
EZ
563 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
564 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
565 (bidi_cache_search, bidi_cache_iterator_state)
566 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
567 (bidi_level_of_next_char, bidi_move_to_visually_next):
568 Support character positions inside a run of characters covered by a
fec2107c
EZ
569 display string.
570 (bidi_paragraph_init, bidi_resolve_explicit_1)
571 (bidi_level_of_next_char): Call bidi_fetch_char and
572 bidi_fetch_char_advance instead of FETCH_CHAR and
573 FETCH_CHAR_ADVANCE.
574 (bidi_init_it): Initialize new members.
575 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
576 definitions.
577 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
578 instead of using explicit *_CHAR codes.
d6d100dd
SM
579 (bidi_resolve_explicit, bidi_resolve_weak):
580 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
581 bidirectional text is supported only in multibyte buffers.
582 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
583 it to initialize the frame_window_p member of struct bidi_it.
584 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
585 (bidi_resolve_explicit, bidi_resolve_weak)
586 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
587 bidi_it->nchars is non-positive.
588 (bidi_level_of_next_char): Don't try to lookup the cache for the
589 next/previous character if nothing is cached there yet, or if we
590 were just reseat()'ed to a new position.
c40e2fb2 591
0e14fe90
EZ
592 * xdisp.c (set_cursor_from_row): Set start and stop points
593 according to the row's direction when priming the loop that looks
594 for the glyph on which to display cursor.
595 (single_display_spec_intangible_p): Function deleted.
596 (display_prop_intangible_p): Reimplement to call
597 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
598 Accept 3 additional arguments needed by handle_display_spec.
599 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
600 values: lists, `(when COND...)' forms, etc.
601 (single_display_spec_string_p): Support property values that are
602 lists with the argument STRING its top-level element.
603 (display_prop_string_p): Fix the condition for processing a
604 property that is a list to be consistent with handle_display_spec.
fec2107c 605 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
606 last portion of handle_display_prop.
607 (compute_display_string_pos): Accept additional argument
608 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
609 value of a `display' property is a "replacing spec".
610 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
611 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
612 the display property, but just return a value indicating whether
613 the display property will replace the characters it covers.
614 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
615 frame_window_p members of struct bidi_it.
d6d100dd
SM
616 (compute_display_string_pos, compute_display_string_end):
617 New functions.
fec2107c
EZ
618 (push_it): Accept second argument POSITION, where pop_it should
619 jump to continue iteration.
620 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 621
fec2107c
EZ
622 * keyboard.c (adjust_point_for_property): Adjust the call to
623 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
624
625 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
626 (bidi_init_it): Update prototypes.
627 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
628 (compute_display_string_pos, compute_display_string_end):
629 Declare prototypes.
fec2107c
EZ
630 (struct bidi_it): New members nchars and disp_pos. ch_len is now
631 EMACS_INT.
fc6f18ce 632
40087514 6332011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 634
57f53182
PE
635 Malloc failure behavior now depends on size of allocation.
636 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
637 * lisp.h: Change signatures accordingly.
638 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
639 All callers changed. (Bug#8762)
640
641 * gnutls.c: Use Emacs's memory allocators.
642 Without this change, the gnutls library would invoke malloc etc.
643 directly, which causes problems on non-SYNC_INPUT hosts, and which
644 runs afoul of improving memory_full behavior. (Bug#8761)
645 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
646 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
647 xfree instead of the default malloc, realloc, free.
648 (Fgnutls_boot): No need to check for memory allocation failure,
649 since xmalloc does that for us.
650
ac32cd99 651 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
652 * category.c (hash_get_category_set):
653 * ccl.c (ccl_driver):
654 * charset.c (Fdefine_charset_internal):
655 * charset.h (struct charset.hash_index):
656 * composite.c (get_composition_id, gstring_lookup_cache)
657 (composition_gstring_put_cache):
658 * composite.h (struct composition.hash_index):
659 * dispextern.h (struct image.hash):
660 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
661 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
662 (hashfn_equal, hashfn_user_defined, make_hash_table)
663 (maybe_resize_hash_table, hash_lookup, hash_put)
664 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
665 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
666 (Fsxhash, Fgethash, Fputhash, Fmaphash):
667 * image.c (make_image, search_image_cache, lookup_image)
668 (xpm_put_color_table_h):
669 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 670 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
671 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
672 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
673 * alloc.c (allocate_vectorlike):
674 Check for overflow in vector size calculations.
675 * ccl.c (ccl_driver):
676 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
677 * fns.c, image.c: Remove unnecessary static decls that would otherwise
678 need to be updated by these changes.
40087514
PE
679 * fns.c (make_hash_table, maybe_resize_hash_table):
680 Check for integer overflow with large hash tables.
0de4bb68
PE
681 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
682 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
683 (SXHASH_REDUCE): New macro.
684 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
685 Use it instead of discarding useful hash info with large hash values.
686 (sxhash_float): New function.
687 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
688 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
689 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
690 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
691 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
692 Adjust signatures to match updated version of code.
693 (consing_since_gc): Now EMACS_INT, since a single hash table can
694 use more than INT_MAX bytes.
695
698d32e2
DN
6962011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
697
698 Make it possible to build with GCC-4.6+ -O2 -flto.
699
700 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
701
fd6fa53f
SM
7022011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
703
704 * minibuf.c (get_minibuffer, read_minibuf_unwind):
705 Call minibuffer-inactive-mode.
706
864db017
JB
7072011-05-31 Juanma Barranquero <lekktu@gmail.com>
708
709 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
710 Update dependencies.
711
2ad0baf4
DN
7122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
713
714 * data.c (init_data): Remove code for UTS, this system is not
715 supported anymore.
716
4fcc2638
DN
7172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
718
719 Don't force ./temacs to start in terminal mode.
720
721 * frame.c (make_initial_frame): Initialize faces in all cases, not
722 only when CANNOT_DUMP is defined.
723 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
724
c56e0fd5
DN
7252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
726
727 * dispnew.c (add_window_display_history): Use const for the string
728 pointer. Remove declaration, not needed.
729
333d54da 7302011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 731
55d4c1b2 732 Use 'inline', not 'INLINE'.
333d54da 733 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
734 * alloc.c, fontset.c (INLINE): Remove.
735 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
736 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
737 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
738 * gmalloc.c (register_heapinfo): Use inline unconditionally.
739 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
740
738db178
DN
7412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
742
743 Make it possible to run ./temacs.
744
745 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
746 syms_of_callproc does the same thing. Remove test for
747 "initialized", do it in the caller.
748 * emacs.c (main): Avoid calling set_initial_environment when dumping.
749
620c53a6
SM
7502011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
751
752 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
753 (read_minibuf): Use get_minibuffer.
754 (syms_of_minibuf): Use DEFSYM.
755 (Qmetadata): New var.
756 * data.c (Qbuffer): Don't make it static.
757 (syms_of_data): Use DEFSYM.
758
e003a292
PE
7592011-05-31 Paul Eggert <eggert@cs.ucla.edu>
760
761 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
762 (CCL_CODE_MIN): New macro.
763
ed008a6d
PE
7642011-05-30 Paul Eggert <eggert@cs.ucla.edu>
765
3687c2ef
PE
766 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
767
ed008a6d
PE
768 * eval.c (Qdebug): Now static.
769 * lisp.h (Qdebug): Remove decl. This reverts a part of the
770 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
771 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
772
d66c4c7c
CY
7732011-05-29 Chong Yidong <cyd@stupidchicken.com>
774
775 * image.c: Various fixes to ImageMagick code comments.
776 (Fimagemagick_types): Doc fix.
777
5fbc2025
PE
7782011-05-29 Paul Eggert <eggert@cs.ucla.edu>
779
0196f88a
PE
780 Minor fixes prompted by GCC 4.6.0 warnings.
781
782 * xselect.c (converted_selections, conversion_fail_tag): Now static.
783
5fbc2025
PE
784 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
785 (x_clipboard_manager_save_all): Move extern decl to ...
786 * xterm.h: ... here, so that it can be checked for consistency.
787
1dd3c2d9
CY
7882011-05-29 Chong Yidong <cyd@stupidchicken.com>
789
790 * xselect.c (x_clipboard_manager_save_frame)
791 (x_clipboard_manager_save_all): New functions.
792 (Fx_clipboard_manager_save): Lisp function deleted.
793
794 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
795 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
796
797 * xterm.h: Update prototype.
798
5ba6571d
WX
7992011-05-28 William Xu <william.xwl@gmail.com>
800
801 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
802 exiting (Bug#8239).
803
3eaff834
JM
8042011-05-28 Jim Meyering <meyering@redhat.com>
805
e1900994 806 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
807 * fns.c (to_uchar): Define.
808 (crypto_hash_function): Use it to convert some newly-signed
809 variables to unsigned, to avoid sign-extension bugs. For example,
810 without this change, (md5 "truc") would evaluate to
811 45723a2aff78ff4fff7fff1114760e62 rather than the expected
812 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 813 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 814
0f6990a7
PE
8152011-05-27 Paul Eggert <eggert@cs.ucla.edu>
816
817 Integer overflow fixes.
c8a9ca5a 818
08686060
PE
819 * dbusbind.c: Serial number integer overflow fixes.
820 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
821 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
822 to hold a serial number that is too large for a fixnum.
823 (Fdbus_method_return_internal, Fdbus_method_error_internal):
824 Check for serial numbers out of range. Decode any serial number
59568bf0 825 that was so large that it became a float. (Bug#8722)
08686060 826
2d1fc3c7
PE
827 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
828 (Fdbus_call_method, Fdbus_call_method_asynchronously):
829 Use XFASTINT rather than XUINT when numbers are nonnegative.
830 (xd_append_arg, Fdbus_method_return_internal):
831 (Fdbus_method_error_internal): Likewise. Also, for unsigned
832 arguments, check that Lisp number is nonnegative, rather than
59568bf0 833 silently wrapping negative numbers around. (Bug#8722)
30217ff0 834 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 835 (Bug#8722)
2d1fc3c7 836
c8a9ca5a
PE
837 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
838
519e1d69
PE
839 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
840
30569699
PE
841 ccl: add integer overflow checks
842 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
843 (IN_INT_RANGE): New macros.
844 (ccl_driver): Use them to check for integer overflow when
845 decoding a CCL program. Many of the new checks are whether XINT (x)
846 fits in int; it doesn't always, on 64-bit hosts. The new version
847 doesn't catch all possible integer overflows, but it's an
847044ea 848 improvement. (Bug#8719)
30569699 849
c11285dc
PE
850 * alloc.c (make_event_array): Use XINT, not XUINT.
851 There's no need for unsigned here.
852
fdccd48e
PE
853 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
854 This follows up to the 2011-05-06 change that substituted uintptr_t
855 for EMACS_INT. This case wasn't caught back then.
856
37910ab2
PE
857 Rework Fformat to avoid integer overflow issues.
858 * editfns.c: Include <float.h> unconditionally, as it's everywhere
859 now (part of C89). Include <verify.h>.
860 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
861 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
862 (Fformat): Avoid the prepass trying to compute sizes; it was only
863 approximate and thus did not catch overflow reliably. Instead, walk
864 through the format just once, formatting and computing sizes as we go,
865 checking for integer overflow at every step, and allocating a larger
866 buffer as needed. Keep track separately whether the format is
867 multibyte. Keep only the most-recently calculated precision, rather
868 than them all. Record whether each argument has been converted to
869 string. Use EMACS_INT, not int, for byte and char and arg counts.
870 Support field widths and precisions larger than INT_MAX. Avoid
871 sprintf's undefined behavior with conversion specifications such as %#d
872 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
873 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
874 formatting out-of-range floating point numbers with int
875 formats. (Bug#8668)
876
2e6578fb
PE
877 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
878
0ae6bdee
PE
879 * data.c: Avoid integer truncation in expressions involving floats.
880 * data.c: Include <intprops.h>.
881 (arith_driver): When there's an integer overflow in an expression
882 involving floating point, convert the integers to floating point
883 so that the resulting value does not suffer from catastrophic
884 integer truncation. For example, on a 64-bit host (* 4
885 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
886 Do not rely on undefined behavior after integer overflow.
887
de883a70
PE
888 merge count_size_as_multibyte, parse_str_to_multibyte
889 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 890 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
891 Check for integer overflow.
892 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
893 since it's now a duplicate of the other. This is more of
894 a character than a buffer op, so better that it's in character.c.
895 * fns.c, print.c: Adjust to above changes.
896
2ff916cb
PE
8972011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
898
899 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
900
f1b54466
PE
9012011-05-27 Paul Eggert <eggert@cs.ucla.edu>
902
fb1ac845
PE
903 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
904 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
905 (x_clipboard_manager_save): Now static.
906 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
907
f1b54466
PE
908 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
909 (crypto_hash_function): Now static.
910 Fix pointer signedness problems. Avoid unnecessary initializations.
911
a9f737ee
CY
9122011-05-27 Chong Yidong <cyd@stupidchicken.com>
913
914 * termhooks.h (Vselection_alist): Make it terminal-local.
915
916 * terminal.c (create_terminal): Initialize it.
917
918 * xselect.c: Support for clipboard managers.
919 (Vselection_alist): Move to termhooks.h as terminal-local var.
920 (LOCAL_SELECTION): New macro.
921 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
922 (symbol_to_x_atom): Remove gratuitous arg.
923 (x_handle_selection_request, lisp_data_to_selection_data)
924 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
925 (x_own_selection, x_get_local_selection, x_convert_selection):
926 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
927 (some_frame_on_display): Delete unused function.
928 (Fx_own_selection_internal, Fx_get_selection_internal)
929 (Fx_disown_selection_internal, Fx_selection_owner_p)
930 (Fx_selection_exists_p): New optional frame arg.
931 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
932 (x_handle_selection_clear): Don't treat other terminals with the
933 same keyboard specially. Use the terminal-local Vselection_alist.
934 (x_clear_frame_selections): Use Frun_hook_with_args.
935
936 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
937
938 * xterm.h: Add support for those atoms.
939
e067f0c1
CY
9402011-05-26 Chong Yidong <cyd@stupidchicken.com>
941
942 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
943 (converted_selections, conversion_fail_tag): New global variables.
944 (x_selection_request_lisp_error): Free the above.
945 (x_get_local_selection): Remove unnecessary code.
946 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
947 of converted selections stored in converted_selections.
948 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
949 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
950 (x_convert_selection): New function.
951 (x_handle_selection_event): Simplify.
952 (x_get_foreign_selection): Don't ignore incoming requests while
953 waiting for an answer; this will fail when we implement
954 SAVE_TARGETS, and seems unnecessary anyway.
955 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
956 (Vx_sent_selection_functions): Doc fix.
957
0f4aebc0
LL
9582011-05-26 Leo Liu <sdl.web@gmail.com>
959
960 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
961
e61124cd
YM
9622011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
963
964 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
965
966 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
967 for fringe update if it has periodic bitmap.
968 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
969 and fringe_bitmap_periodic_p.
970
971 * fringe.c (get_fringe_bitmap_data): New function.
972 (draw_fringe_bitmap_1, update_window_fringes): Use it.
973 (update_window_fringes): Record periodicity of fringe bitmap in glyph
974 row. Mark glyph row for fringe update if periodicity changed.
975
976 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
977 for fringe update unless it has periodic bitmap.
978
f16d9837
KH
9792011-05-25 Kenichi Handa <handa@m17n.org>
980
981 * xdisp.c (get_next_display_element): Set correct it->face_id for
982 a static composition.
983
e1b90ef6
LL
9842011-05-24 Leo Liu <sdl.web@gmail.com>
985
986 * deps.mk (fns.o):
987 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
988
989 * fns.c (crypto_hash_function, Fsha1): New function.
990 (Fmd5): Use crypto_hash_function.
991 (syms_of_fns): Add Ssha1.
992
7400048f
PE
9932011-05-22 Paul Eggert <eggert@cs.ucla.edu>
994
995 * gnutls.c: Remove unused macros.
996 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
997 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
998 Remove macros that are defined and never used.
999 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1000
abb71cf4
CY
10012011-05-22 Chong Yidong <cyd@stupidchicken.com>
1002
1003 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1004 (Fx_get_selection_internal): Minor cleanup.
1005 (Fx_own_selection_internal): Rename arguments for consistency with
1006 select.el.
1007
6307db39
PE
10082011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1009
1010 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1011
f3d4e0a4
CY
10122011-05-22 Chong Yidong <cyd@stupidchicken.com>
1013
1014 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1015
4d8ade89
YM
10162011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1017
1018 * dispnew.c (scrolling_window): Don't exclude the case that the
1019 last enabled row in the desired matrix touches the bottom boundary.
1020
32078c8d
GM
10212011-05-21 Glenn Morris <rgm@gnu.org>
1022
1023 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1024 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1025 and add some more files.
32078c8d 1026
7285dc67
EZ
10272011-05-20 Eli Zaretskii <eliz@gnu.org>
1028
1029 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1030 report_file_error introduced by the change from 2011-05-07.
1031
89d1bd22
PE
10322011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1033
1034 * systime.h (Time): Define only if emacs is defined.
1035 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1036 where the include path doesn't have X11/X.h by default. See
1037 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1038
e23640bb 10392011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1040
1041 * composite.c (find_automatic_composition): Fix previous change.
1042
b9704ad9
GM
10432011-05-20 Glenn Morris <rgm@gnu.org>
1044
1045 * lisp.mk: New file, split from Makefile.in.
1046 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1047 (shortlisp): Remove.
1048 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1049
4a720484
GM
10502011-05-19 Glenn Morris <rgm@gnu.org>
1051
1052 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1053 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1054 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1055 (lisp): Set the order to that of loadup.el.
1056 (shortlisp): Make it a copy of $lisp.
1057 (SOME_MACHINE_LISP): Remove.
1058 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1059 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1060
a28d4396
KH
10612011-05-18 Kenichi Handa <handa@m17n.org>
1062
1063 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1064 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1065 (find_automatic_composition): Mostly rewrite for efficiency.
1066
a2b1fa8e
JB
10672011-05-18 Juanma Barranquero <lekktu@gmail.com>
1068
1069 * makefile.w32-in: Update dependencies.
1070
8e1f5610
CS
10712011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1072
1073 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1074 revision 104625).
1075
7025ee00 10762011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1077
cdfa6eab
PE
1078 Fix some integer overflow issues, such as string length overflow.
1079
06d6db33
PE
1080 * insdel.c (count_size_as_multibyte): Check for string overflow.
1081
2b4560a8
PE
1082 * character.c (lisp_string_width): Check for string overflow.
1083 Use EMACS_INT, not int, for string indexes and lengths; in
1084 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1085 the resulting string length overflows an EMACS_INT; instead,
1086 report a string overflow if no precision given. When checking for
1087 precision exhaustion, use a check that cannot possibly have
1088 integer overflow. (Bug#8675)
1089 * character.h (lisp_string_width): Adjust to new signature.
1090
cb93f9be
PE
1091 * alloc.c (string_overflow): New function.
1092 (Fmake_string): Use it. This doesn't change behavior, but saves
1093 a few bytes and will simplify future changes.
1094 * character.c (string_escape_byte8): Likewise.
1095 * lisp.h (string_overflow): New decl.
1096
1a1f3366
PE
1097 Fixups, following up to the user-interface timestamp change.
1098 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1099 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1100 * msdos.c (mouse_get_pos): Likewise.
1101 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1102 * w32gui.h (Time): Define by including "systime.h" rather than by
1103 declaring it ourselves. (Bug#8664)
1104
d4e3e4d3
PE
1105 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1106 * image.c (clear_image_cache): Likewise.
1107
f6a24d19
PE
1108 * term.c (term_mouse_position): Don't assume time_t wraparound.
1109
08dc5ae6
PE
1110 Be more systematic about user-interface timestamps.
1111 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1112 and sometimes 'EMACS_UINT', to represent these timestamps.
1113 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1114 This makes the code easier to follow, and makes it easier to catch
1115 integer overflow bugs such as Bug#8664.
1116 * frame.c (Fmouse_position, Fmouse_pixel_position):
1117 Use Time, not unsigned long, for user-interface timestamps.
1118 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1119 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1120 * keyboard.h (last_event_timestamp): Likewise.
1121 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1122 * menu.h (xmenu_show): Likewise.
1123 * term.c (term_mouse_position): Likewise.
1124 * termhooks.h (struct input_event.timestamp): Likewise.
1125 (struct terminal.mouse_position_hook): Likewise.
1126 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1127 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1128 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1129 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1130 what it was before.
1131 * menu.h, termhooks.h: Include "systime.h", for Time.
1132
8e55734a
PE
1133 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1134 Don't assume that the difference between two unsigned long values
1135 can fit into an integer. At this point, we know button_down_time
1136 <= event->timestamp, so the difference must be nonnegative, so
1137 there's no need to cast the result if double-click-time is
1138 nonnegative, as it should be; check that it's nonnegative, just in
1139 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1140 apart (about 25 days). (Bug#8664)
8e55734a 1141
841f1b75 1142 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1143 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1144
3e26f69c
PE
1145 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1146 that always fit in int. Use a sentinel instead of a counter, to
1147 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1148 * frame.h (struct frame): Use int for menu_bar_items_used
1149 instead of EMACS_INT, since it always fits in int.
3e26f69c 1150
5cc152c0
PE
1151 * menu.c (grow_menu_items): Check for int overflow.
1152
d89eb65e
PE
1153 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1154
5235bd3e
PE
1155 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1156 Before, the code was not consistent. These values cannot exceed
1157 2**31 - 1 so there's no need to make them unsigned.
1158 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1159 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1160 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1161 as modifiers.
1162 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1163
bc827e23
PE
1164 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1165 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1166 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1167 presumably because the widths might not match.
1168
78eb494e
PE
1169 * window.c (size_window): Avoid needless test at loop start.
1170
04f2d78b
CB
11712011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1172
1173 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1174
d2fc7e3d 11752011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1176
1177 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1178
d2fc7e3d 11792011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1180
1181 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1182 `width' to `bar_area_x' and `bar_area_width', respectively.
1183 (x_scroll_run): Take account of fringe background extension.
1184
04f2d78b
CB
1185 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1186 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1187 `bar_area_width', respectively.
1188 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1189 background extension.
1190
79b70037
GM
11912011-05-10 Jim Meyering <meyering@redhat.com>
1192
1193 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1194
2f142cc5
JB
11952011-05-10 Juanma Barranquero <lekktu@gmail.com>
1196
1197 * image.c (Finit_image_library): Return t for built-in image types,
1198 like pbm and xbm. (Bug#8640)
1199
57679c86
AS
12002011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1201
1202 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1203
888c9e86
EZ
12042011-05-07 Eli Zaretskii <eliz@gnu.org>
1205
b0512a1d
EZ
1206 * w32console.c (Fset_screen_color): Doc fix.
1207 (Fget_screen_color): New function.
1208 (syms_of_ntterm): Defsubr it.
1209
7285dc67
EZ
1210 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1211 unlink the temporary file if Fcall_process didn't create it in the
1212 first place.
1213 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1214 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1215 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1216 cue to call_process_cleanup not to close that handle.
1217
4d3fcc8e
BK
12182011-05-07 Ben Key <bkey76@gmail.com>
1219
1220 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1221 one of two shell specific rules, either bootstrap-temacs-CMD or
1222 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1223 to the previous implementation of the bootstrap-temacs rule.
1224 The bootstrap-temacs-CMD rule is similar to the previous
1225 implementation of the bootstrap-temacs rule except that it
1226 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1227 variable.
1228
1229 These changes, along with some changes to nt/configure.bat,
1230 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1231 earlier fix to add support for --cflags and --ldflags options
1232 that include quotes so that it works whether make uses cmd or
1233 sh as the shell.
1234
b4289b64
MA
12352011-05-06 Michael Albinus <michael.albinus@gmx.de>
1236
1237 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1238 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1239 is a constant.
1240 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1241 a string. Handle both cases.
1242 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1243 (Fdbus_register_method): Use Qinvalid_function.
1244
af4c0e28
JB
12452011-05-06 Juanma Barranquero <lekktu@gmail.com>
1246
1247 * makefile.w32-in: Update dependencies.
1248 (LISP_H): Add inttypes.h and stdin.h.
1249 (PROCESS_H): Add unistd.h.
1250
c51453d9
EZ
12512011-05-06 Eli Zaretskii <eliz@gnu.org>
1252
1253 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1254 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1255
8ff0ac3c 12562011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1257
4c4b566b
PE
1258 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1259
aab2b9b5
PE
1260 * term.c (vfatal): Remove stray call to va_end.
1261 It's not needed and the C Standard doesn't allow it here anyway.
1262
c378da0b
PE
1263 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1264 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1265
288b08c7
PE
1266 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1267 bytes.
1268
e3601888
PE
1269 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1270
db6c0e74
PE
1271 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1272
dd5963ea
PE
1273 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1274
88c9450f
PE
1275 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1276
2f9442b8
PE
1277 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1278
c032b5f8
PE
1279 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1280 * charset.c (Fdefine_charset_internal): Don't initialize
1281 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1282 32-bit int (Bug#8600).
a108c10b
PE
1283
1284 * lread.c (read_integer): Be more consistent with string-to-number.
1285 Use string_to_number to do the actual conversion; this avoids
1286 rounding errors and fixes some other screwups. Without this fix,
1287 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1288 (digit_to_number): Move earlier, for benefit of read_integer.
1289 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1290 not a digit in any supported base. (Bug#8602)
a108c10b 1291
ad5f9eea
PE
1292 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1293
aec1708a
PE
1294 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1295 to match comment at start of function. This also removes a
1296 GCC warning about overflow in a 32+64-bit port.
1297
47be4ab5
PE
1298 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1299
371cac43
PE
1300 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1301 Reported by Stefan Monnier in
1302 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1303 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1304 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1305
d01a7826
PE
1306 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1307 (EMACS_UINTPTR): Likewise, with uintptr_t.
1308
7fd47d5c
PE
1309 * lisp.h: Prefer 64-bit EMACS_INT if available.
1310 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1311 on 32-bit hosts that have 64-bit int, so that they can access
1312 large files.
122b0c86
PE
1313 However, temporarily disable this change unless the temporary
1314 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1315
8727937b
PE
1316 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1317
8ac068ac
PE
1318 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1319 This removes an assumption that EMACS_INT and long are the same
1320 width as pointers. The assumption is true for Emacs porting targets
1321 now, but we want to make other targets possible.
1322 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1323 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1324 In the rest of the code, change types of integers that hold casted
1325 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1326 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1327 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1328 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1329 No need to cast type when ORing.
1330 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1331 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1332 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1333 assume EMACS_INT is the same width as char *.
1334 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1335 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1336 Remove no-longer-needed casts.
1337 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1338 (xg_tool_bar_help_callback, xg_make_tool_item):
1339 Use EMACS_INTPTR to hold an integer
1340 that will be cast to void *; this can avoid a GCC warning
1341 if EMACS_INT is not the same width as void *.
1342 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1343 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1344 (current_message_1, set_message_1):
1345 Use a local to convert to proper width without a cast.
1346 * xmenu.c (dialog_selection_callback): Likewise.
1347
ede49d71
PE
1348 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1349 Also, don't assume VALBITS / RAND_BITS is less than 5,
1350 and don't rely on undefined behavior when shifting a 1 left into
1351 the sign bit.
1352 * lisp.h (get_random): Change signature to match.
1353
2f30ecd0
PE
1354 * lread.c (hash_string): Use size_t, not int, for hash computation.
1355 Normally we prefer signed values; but hashing is special, because
1356 it's better to use unsigned division on hash table sizes so that
1357 the remainder is nonnegative. Also, size_t is the natural width
1358 for hashing into memory. The previous code used 'int', which doesn't
1359 retain enough info to hash well into very large tables.
1360 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1361
2a866e7b
PE
1362 * dbusbind.c: Don't possibly lose pointer info when converting.
1363 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1364 Use XPNTR rather than XHASH, so that the high-order bits of
1365 the pointer aren't lost when converting through void *.
1366
51639eac
PE
1367 * eval.c (Fautoload): Don't double-shift a pointer.
1368
92394119
PE
1369 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1370
dbdb9a7c
JB
13712011-05-06 Juanma Barranquero <lekktu@gmail.com>
1372
1373 * gnutls.c (DEF_GNUTLS_FN):
1374 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1375
db7a0b4f
AS
13762011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1377
1378 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1379 marker. (Bug#8610)
1380
f7ff1b0f 13812011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1382
1383 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1384 New version that can reserve upto 2GB of heap space.
1385
f7ff1b0f 13862011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1387
1388 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1389
639c109b
TZ
13902011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1391
1392 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1393 `gnutls_certificate_set_x509_key_file'.
1394
d2127135
JB
13952011-05-05 Juanma Barranquero <lekktu@gmail.com>
1396
1397 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1398 Update dependencies.
1399
e968f4f3
JB
14002011-05-04 Juanma Barranquero <lekktu@gmail.com>
1401
1402 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1403 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1404 Remove unused parameter `fildes'.
1405 * process.c (read_process_output, send_process): Don't pass it.
1406
84d358f0
JB
14072011-05-04 Juanma Barranquero <lekktu@gmail.com>
1408
1409 Fix previous change: the library cache is defined in w32.c.
1410 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1411 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1412
0898ca10
JB
14132011-05-04 Juanma Barranquero <lekktu@gmail.com>
1414
1415 Implement dynamic loading of GnuTLS on Windows.
1416
1417 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1418 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1419 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1420 Declare.
1421
1422 * gnutls.c (Qgnutls_dll): Define.
1423 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1424 (gnutls_*): Declare function pointers.
1425 (init_gnutls_functions): New function to initialize function pointers.
1426 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1427 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1428 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1429 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1430 (emacs_gnutls_write, emacs_gnutls_read)
1431 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1432 (Fgnutls_available_p): New function.
1433 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1434 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1435 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1436
1437 * image.c: Include w32.h.
1438 (Vimage_type_cache): Delete.
1439 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1440 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1441 (w32_delayed_load): Move to w32.c.
1442
1443 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1444
1445 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1446 (w32_delayed_load): Move from image.c. When loading a library, record
1447 its filename in the :loaded-from property of the library id.
1448 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1449 Initialize and staticpro them.
1450 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1451
1452 * process.c: Include lisp.h before w32.h, not after.
1453 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1454 instead of gnutls_record_check_pending.
1455
1456 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1457
ff4de4aa
TZ
14582011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1459
1460 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1461 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1462 as passed in.
1463
abe95abb
JD
14642011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1465
1466 * xterm.c (x_set_frame_alpha): Do not set property on anything
1467 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1468
e16e55d4
JB
14692011-05-02 Juanma Barranquero <lekktu@gmail.com>
1470
1471 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1472
bafcf6a5
JB
14732011-05-02 Juanma Barranquero <lekktu@gmail.com>
1474
1475 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1476 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1477 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1478 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1479 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1480 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1481 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1482 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1483 (Qgnutls_bootprop_callbacks_verify): Make static.
1484
e7a6747f
AS
14852011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1486
19ed11ba
AS
1487 * callproc.c: Indentation fixup.
1488
e7a6747f 1489 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1490 (wait_for_termination, interruptible_wait_for_termination):
1491 Move after wait_for_termination_1.
e7a6747f 1492
1ef14cb4
LMI
14932011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1494
1495 * sysdep.c (interruptible_wait_for_termination): New function
1496 which is like wait_for_termination, but allows keyboard
1497 interruptions.
1498
1499 * callproc.c (Fcall_process): Add (:file "file") as an option for
1500 the STDOUT buffer.
1501 (Fcall_process_region): Ditto.
1502
330d880c
EZ
15032011-04-30 Eli Zaretskii <eliz@gnu.org>
1504
8db90b73
EZ
1505 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1506 rather than `XVECTOR (FOO)->size'.
1507
330d880c
EZ
1508 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1509 inttypes.h, as a gnulib replacement is used if it not available in
1510 system headers.
1511
15cbd324
EZ
15122011-04-21 Eli Zaretskii <eliz@gnu.org>
1513
1514 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1515 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1516 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1517
1518 * coding.c (coding_alloc_by_realloc): Error out if destination
1519 will grow beyond MOST_POSITIVE_FIXNUM.
1520 (decode_coding_emacs_mule): Abort if there isn't enough place in
1521 charbuf for the composition carryover bytes. Reserve an extra
1522 space for up to 2 characters produced in a loop.
1523 (decode_coding_iso_2022): Abort if there isn't enough place in
1524 charbuf for the composition carryover bytes.
1525
15262011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1527
ae940cca
EZ
1528 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1529 aborting when %lld or %lll format is passed.
1530 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1531 %llo or %llx format is passed. (Bug#8545)
1532
03ab8921
EZ
1533 * window.c (window_scroll_line_based): Use a marker instead of
1534 simple variables to record original value of point. (Bug#7952)
1535
afda1437
EZ
1536 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1537 produced by %s or %c overflows available buffer space. (Bug#8545)
1538
f76dee0c
PE
15392011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1540
1541 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1542 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1543
fdc5744d
JB
15442011-04-28 Juanma Barranquero <lekktu@gmail.com>
1545
1546 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1547
638f053a
JB
15482011-04-28 Juanma Barranquero <lekktu@gmail.com>
1549
1550 * keyboard.c (Qdelayed_warnings_hook): Define.
1551 (command_loop_1): Run `delayed-warnings-hook'
1552 if Vdelayed_warnings_list is non-nil.
1553 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1554 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1555
d178f871
EZ
15562011-04-28 Eli Zaretskii <eliz@gnu.org>
1557
1558 * doprnt.c (doprnt): Don't return value smaller than the buffer
1559 size if the message was truncated. (Bug#8545).
1560
b124fd93
JB
15612011-04-28 Juanma Barranquero <lekktu@gmail.com>
1562
1563 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1564 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1565
e810457d
PE
15662011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1567
1568 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1569
ea51cceb
JB
15702011-04-27 Juanma Barranquero <lekktu@gmail.com>
1571
1572 * makefile.w32-in: Update dependencies.
1573
94dcfacf
EZ
15742011-04-27 Eli Zaretskii <eliz@gnu.org>
1575
1576 Improve `doprnt' and its usage. (Bug#8545)
1577 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1578 `format_end'. Remove support for %l as a conversion specifier.
1579 Don't use xrealloc. Improve diagnostics when the %l size modifier
1580 is used. Update the commentary.
1581
1582 * eval.c (verror): Simplify calculation of size_t.
1583
1584 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1585 messages.
1586
f61f41d7
PE
15872011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1588
1589 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1590 change.
1591
96fb4434
PE
15922011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1593
1594 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1595 This makes this file independent of the recent pseudovector change.
1596
671875da 15972011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1598
69e9b5a3
PE
1599 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1600
b5f869a7 1601 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1602 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1603 Remove unused local.
c8926152 1604 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1605
841a1577 1606 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1607 GCC 4.6.0 optimizes based on type-based alias analysis.
1608 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1609 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1610 != &v->size, and therefore "v->size = 1; b->size = 2; return
1611 v->size;" must therefore return 1. This assumption is incorrect
1612 for Emacs, since it type-puns struct Lisp_Vector * with many other
1613 types. To fix this problem, this patch adds a new type struct
f904488f 1614 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1615 and pseudovectors, and helps optimizing compilers not get fooled
1616 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1617 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1618 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1619 the size member.
eab3844f
PE
1620 (XSETPVECTYPE): Rewrite in terms of new macro.
1621 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1622 This is a bit clearer, and further avoids the possibility of
1623 undesirable aliasing.
1624 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1625 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1626 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1627 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1628 (ASIZE): Now uses header.size rather than size.
1629 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1630 to avoid the hassle of writing XVECTOR (foo)->header.size.
1631 (struct vectorlike_header): New type.
eab3844f
PE
1632 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1633 object, to help avoid aliasing.
1634 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1635 (SUBRP): Likewise, since Lisp_Subr is a special case.
1636 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1637 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1638 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1639 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1640 changed to be "header.size" and "header.next".
1641 * buffer.h (struct buffer): Likewise.
1642 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1643 * frame.h (struct frame): Likewise.
1644 * process.h (struct Lisp_Process): Likewise.
1645 * termhooks.h (struct terminal): Likewise.
1646 * window.c (struct save_window_data, struct saved_window): Likewise.
1647 * window.h (struct window): Likewise.
1648 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1649 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1650 * buffer.c (init_buffer_once): Likewise.
1651 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1652 special case.
1653 * process.c (Fformat_network_address): Use local var for size,
1654 for brevity.
1655
0df1eac5
PE
1656 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1657
847ab9d1 1658 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1659 * data.c (atof): Remove decl; no longer used or needed.
1660 (digit_to_number): Move to lread.c.
1661 (Fstring_to_number): Use new string_to_number function, to be
1662 consistent with how the Lisp reader treats infinities and NaNs.
1663 Do not assume that floating-point numbers represent EMACS_INT
1664 without losing information; this is not true on most 64-bit hosts.
1665 Avoid double-rounding errors, by insisting on integers when
1666 parsing non-base-10 numbers, as the documentation specifies.
1667 * lisp.h (string_to_number): New decl, replacing ...
1668 (isfloat_string): Remove.
bc0a5c13 1669 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1670 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1671 appears to have been a coding error. Similarly, do not accept
1672 strings like +-1e0 as floating point numbers. Do not report
1673 overflow for integer overflows unless the base is not 10 which
1674 means we have no simple and reliable way to continue.
1675 Break out the floating-point parsing into a new
1676 function string_to_number, so that Fstring_to_number parses
1677 floating point numbers consistently with the Lisp reader.
04f2d78b 1678 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1679 (E_CHAR, EXP_INT): Remove, replacing with ...
1680 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1681 (string_to_number): New function, replacing isfloat_string.
1682 This function checks for valid syntax and produces the resulting
1683 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1684 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1685 so that overflow for non-base-10 numbers is reported only when
1686 there's no portable and simple way to convert to floating point.
452f4150 1687
67769ffc
PE
1688 * textprop.c (set_text_properties_1): Rewrite for clarity,
1689 and to avoid GCC warning about integer overflow.
1690
c20db43f
PE
1691 * intervals.h (struct interval): Use EMACS_INT for members
1692 where EMACS_UINT might cause problems. See
1693 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1694 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1695 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1696 All uses changed.
37aa2f85
PE
1697 (offset_intervals): Tell GCC not to worry about length overflow
1698 when negating a negative length.
c20db43f 1699
2538aa2f
PE
1700 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1701 (overrun_check_free): Likewise.
1702
f2d3008d
PE
1703 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1704 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1705 word size.
1706
ec8df744
PE
1707 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1708 (gnutls_make_error): Rename local to avoid shadowing.
1709 (gnutls_emacs_global_deinit): ifdef out; not used.
1710 (Fgnutls_boot): Use const for pointer to readonly storage.
1711 Comment out unused local. Fix pointer signedness problems.
1712
640ee02d
PE
1713 * lread.c (openp): Don't stuff size_t into an 'int'.
1714 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1715 about possible signed overflow.
1716
6048fb2a
PE
1717 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1718 (GDK_KEY_g): Don't define if already defined.
1719 (xg_prepare_tooltip): Avoid pointer signedness problem.
1720 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1721
fa3c87e1
PE
1722 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1723 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1724
2172544b
PE
1725 * xfns.c (Fx_window_property): Simplify a bit,
1726 to make a bit faster and to avoid GCC 4.6.0 warning.
1727 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1728
9b821a21
PE
1729 * fns.c (internal_equal): Don't assume size_t fits in int.
1730
3c616cfa
PE
1731 * alloc.c (compact_small_strings): Tighten assertion a little.
1732
c2982e87
PE
1733 Replace pEd with more-general pI, and fix some printf arg casts.
1734 * lisp.h (pI): New macro, generalizing old pEd macro to other
1735 conversion specifiers. For example, use "...%"pI"d..." rather
1736 than "...%"pEd"...".
1737 (pEd): Remove. All uses replaced with similar uses of pI.
1738 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1739 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1740 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1741 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1742 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1743 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1744 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1745 64-bit hosts.
1746 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1747 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1748 * print.c (safe_debug_print, print_object): Likewise.
1749 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1750 to int.
6f04d126
PE
1751 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1752 avoiding the 0 flag, which is not portable.
c2982e87
PE
1753 * process.c (Fmake_network_process): Use pI to avoid cast.
1754 * region-cache.c (pp_cache): Likewise.
1755 * xdisp.c (decode_mode_spec): Likewise.
1756 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1757 behavior on 64-bit hosts with printf arg.
6f04d126 1758 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1759 (x_stop_queuing_selection_requests): Likewise.
1760 (x_get_window_property): Don't truncate byte count to an 'int'
1761 when tracing.
0b432f21 1762
5e073ec7
PE
1763 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1764 here, since it parses constructs like leading '-' and spaces,
1765 which are not wanted; and it overflows with large numbers.
1766 Instead, simply match F[0-9]+, which is what is wanted anyway.
1767
36372bf9
PE
1768 * alloc.c: Remove unportable assumptions about struct layout.
1769 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1770 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1771 (allocate_vectorlike, make_pure_vector): Use the new macros,
1772 plus offsetof, to remove unportable assumptions about struct layout.
1773 These assumptions hold on all porting targets that I know of, but
1774 they are not guaranteed, they're easy to remove, and removing them
1775 makes further changes easier.
1776
0b432f21
PE
1777 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1778 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1779 (string_overrun_cookie): Now const. Use initializers that
1780 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1781 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1782 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1783 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1784 multiple of sizeof (EMACS_INT); it need not be, if
1785 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1786 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1787
895009e1
JB
17882011-04-26 Juanma Barranquero <lekktu@gmail.com>
1789
1790 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1791
6a7a1b0b
TZ
17922011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1793
1794 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1795 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1796 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1797
841a1577 17982011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1799
1800 * lisp.h (Qdebug): List symbol.
895009e1 1801 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1802 * keyboard.c (debug-on-event): New variable.
1803 (handle_user_signal): Break into debugger when debug-on-event
1804 matches the current signal symbol.
1805
f2d3ba6f
DN
18062011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1807
1808 * alloc.c (check_sblock, check_string_bytes)
1809 (check_string_free_list): Convert to standard C.
1810
42ce4c63
TZ
18112011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1812
1813 * w32.c (emacs_gnutls_push): Fix typo.
1814
825cd63c
EZ
18152011-04-25 Eli Zaretskii <eliz@gnu.org>
1816
fb11d64d
EZ
1817 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1818 "cast to pointer from integer of different size".
1819
825cd63c
EZ
1820 Improve doprnt and its use in verror. (Bug#8545)
1821 * doprnt.c (doprnt): Document the set of format control sequences
1822 supported by the function. Use SAFE_ALLOCA instead of always
1823 using `alloca'.
1824
1825 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1826 is one byte too soon. Don't use xrealloc; instead xfree and
1827 xmalloc anew.
1828
e061a11b
TZ
18292011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1830
1831 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1832 callbacks stage.
1833
1834 * gnutls.c: Renamed global_initialized to
1835 gnutls_global_initialized. Added internals for the
1836 :verify-hostname-error, :verify-error, and :verify-flags
1837 parameters of `gnutls-boot' and documented those parameters in the
1838 docstring. Start callback support.
1839 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1840 unless a fatal error occured. Call gnutls_alert_send_appropriate
1841 on error. Return error code.
1842 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1843 (emacs_gnutls_read): Likewise.
1844 (Fgnutls_boot): Return handshake error code.
1845 (emacs_gnutls_handle_error): New function.
1846 (wsaerror_to_errno): Likewise.
1847
1848 * w32.h (emacs_gnutls_pull): Add prototype.
1849 (emacs_gnutls_push): Likewise.
1850
1851 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1852 (emacs_gnutls_push): Likewise.
1853
18542011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1855
1856 * process.c (wait_reading_process_output): Check if GnuTLS
1857 buffered some data internally if no FDs are set for TLS
1858 connections.
1859
1860 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1861 (LIBS): Link to USER_LIBS.
1862 ($(BLD)/gnutls.$(0)): New target.
1863
fa6996bc
EZ
18642011-04-24 Eli Zaretskii <eliz@gnu.org>
1865
eb35682e
EZ
1866 * xdisp.c (handle_single_display_spec): Rename the
1867 display_replaced_before_p argument into display_replaced_p, to
1868 make it consistent with the commentary. Fix typos in the
1869 commentary.
1870
e2ad650c
EZ
1871 * textprop.c (syms_of_textprop): Remove dead code.
1872 (copy_text_properties): Delete obsolete commentary about an
1873 interface that was deleted long ago. Fix typos in the description
1874 of arguments.
1875
1b2de274
EZ
1876 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1877 to changes in oldXMenu/XMenu.h from 2011-04-16.
1878 <menu_help_message, prev_menu_help_message>: Constify.
1879 (IT_menu_make_room): menu->help_text is now `const char **';
1880 adjust.
1881
1882 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1883 to changes in oldXMenu/XMenu.h from 2011-04-16.
1884 (struct XMenu): Declare `help_text' `const char **'.
1885
1886 * xfaces.c <Qunspecified>: Make extern again.
1887
1888 * syntax.c: Include sys/types.h before including regex.h, as
1889 required by Posix.
1890
762b15be
EZ
1891 * doc.c (get_doc_string): Improve the format passed to `error'.
1892
1893 * doprnt.c (doprnt): Improve commentary.
1894
1895 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1896
1897 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1898 them with etags.
1899
f1052e5d
EZ
1900 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1901 changes in globals.h immediately force recompilation.
762b15be
EZ
1902 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1903 $(CURDIR)/s/ms-w32.h.
1904 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1905
fa6996bc
EZ
1906 * character.c (Fchar_direction): Function deleted.
1907 (syms_of_character): Don't defsubr it.
1908 <char-direction-table>: Deleted.
1909
e6c3da20
EZ
19102011-04-23 Eli Zaretskii <eliz@gnu.org>
1911
1912 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1913 * doprnt.c: Include limits.h.
1914 (SIZE_MAX): New macro.
04f2d78b
CB
1915 (doprnt): Return a size_t value. 2nd arg is now size_t.
1916 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1917 Improve overflow protection. Support `l' modifier for integer
1918 conversions. Support %l conversion. Don't assume an EMACS_INT
1919 argument for integer conversions and for %c.
1920
1921 * lisp.h (doprnt): Restore prototype.
1922
1923 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1924 $(SRC)/character.h.
1925
1926 * Makefile.in (base_obj): Add back doprnt.o.
1927
1928 * deps.mk (doprnt.o): Add back prerequisites.
1929 (callint.o): Depend on character.h.
1930
1931 * eval.c (internal_lisp_condition_case): Include the handler
1932 representation in the error message.
1933 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1934 when breaking from the loop.
1935
1936 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1937
1938 * callint.c (Fcall_interactively): When displaying error message
1939 about invalid control letter, pass the character's codepoint, not
1940 a pointer to its multibyte form. Improve display of the character
1941 in octal and display also its hex code.
1942
1943 * character.c (char_string): Use %x to display the (unsigned)
1944 codepoint of an invalid character, to avoid displaying a bogus
1945 negative value.
1946
1947 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1948 `error', not SYMBOL_NAME itself.
1949
1950 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1951 character arguments to `error'.
1952
1953 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1954 to `error' in error message about FINAL_CHAR argument. Make sure
1955 FINAL_CHAR is a character, and use %c when it is passed as
1956 argument to `error'.
1957
4ffd0d6b 19582011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1959
1960 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1961
1962 * w32.c: Include <time.h>.
1963 (sys_localtime): New function.
1964
4ffd0d6b 19652011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1966
1967 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1968
4ffd0d6b 1969 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1970
4ffd0d6b 19712011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1972
4ffd0d6b
GM
1973 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1974 zombies (Bug#8467).
aac0c6e3 1975
04c56954
EZ
19762011-04-19 Eli Zaretskii <eliz@gnu.org>
1977
1978 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1979 gl_state.e_property when gl_state.object is Qt.
1980
1981 * insdel.c (make_gap_larger): Remove limitation of buffer size
1982 to <= INT_MAX.
1983
16a43933
CY
19842011-04-18 Chong Yidong <cyd@stupidchicken.com>
1985
1986 * xdisp.c (lookup_glyphless_char_display)
1987 (produce_glyphless_glyph): Handle cons cell entry in
1988 glyphless-char-display.
1989 (Vglyphless_char_display): Document it.
1990
1991 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1992 glyphless-char-display.
1993
4581706e
CY
19942011-04-17 Chong Yidong <cyd@stupidchicken.com>
1995
1996 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1997
1998 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1999
2000 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2001 definition for no-X builds.
2002
4887c6e2 20032011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2004
fd35b6f9
PE
2005 Static checks with GCC 4.6.0 and non-default toolkits.
2006
5c1ccb01
PE
2007 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2008
006c5daa
PE
2009 * process.c (keyboard_bit_set): Define only if SIGIO.
2010 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2011 (send_process): Repair possible setjmp clobbering.
2012
efc736d3
PE
2013 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2014
4e2fe2e6
PE
2015 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2016
f97334a2
PE
2017 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2018
4e75f29d
PE
2019 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2020 Define only if needed.
2021
90efadd1
PE
2022 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2023 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2024 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2025
3c647824
PE
2026 * dispextern.h (struct redisplay_interface): Rename param
2027 to avoid shadowing.
e264f262 2028 * termhooks.h (struct terminal): Likewise.
761383f4 2029 * xterm.c (xembed_send_message): Likewise.
3c647824 2030
b58c5c4a
PE
2031 * insdel.c (make_gap_smaller): Define only if
2032 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2033
cad59032
PE
2034 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2035 it.
2036
c339dc2e
PE
2037 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2038 so that we aren't warned about unused symbols.
2039
91a3e27b
PE
2040 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2041
399c71d3 2042 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2043
8ffc96f5
PE
2044 * xfns.c (x_real_positions): Mark locals as initialized.
2045
eef9bc79
PE
2046 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2047
098db9dd
PE
2048 * xterm.c: Fix problems found by static analysis with other toolkits.
2049 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2050 (x_dispatch_event): Declare static if USE_GTK, and
2051 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2052 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2053 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2054 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2055 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2056
eb18f6cc
PE
2057 * xmenu.c (menu_help_callback): Pointer type fixes.
2058 Use const pointers when pointing at readonly data. Avoid pointer
2059 signedness clashes.
2060 (FALSE): Remove unused macro.
2061 (update_frame_menubar): Remove unused decl.
2062
1fe72bf8
PE
2063 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2064
60d9e1db
PE
2065 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2066 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2067 (single_menu_item): Rename local to avoid shadowing.
2068
39261c26
PE
2069 * keyboard.c (make_lispy_event): Remove unused local var.
2070
018c5e19
PE
2071 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2072 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2073
63d2b86e
PE
2074 * bitmaps: Change bitmaps from unsigned char back to the X11
2075 compatible char. Avoid the old compiler warnings about
2076 out-of-range initializers by using, for example, '\xab' rather
2077 than 0xab.
2078
aefd87e1
PE
2079 * xgselect.c (xgselect_initialize): Check vs interface
2080 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2081
bf501fb9
PE
2082 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2083
e9829fdf
PE
2084 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2085 to read-only memory.
2086
1086c095
PE
2087 * fns.c (vector): Remove; this old hack is no longer needed.
2088
2baccd04 2089 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2090 Remove unused var.
dde42981 2091 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2092
72391843 2093 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2094
436c16df 2095 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2096 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2097 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2098
92bb796d 2099 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2100 (x_term_init): Remove local to avoid shadowing.
92bb796d 2101
764430a3 2102 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2103
2104 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2105 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2106
d1dfb56c
EZ
21072011-04-16 Eli Zaretskii <eliz@gnu.org>
2108
c4354cb4
EZ
2109 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2110
d1dfb56c
EZ
2111 Fix regex.c, syntax.c and friends for buffers > 2GB.
2112 * syntax.h (struct gl_state_s): Declare character position members
2113 EMACS_INT.
2114
2115 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2116
04f2d78b
CB
2117 * textprop.c (verify_interval_modification, interval_of):
2118 Declare arguments EMACS_INT.
d1dfb56c
EZ
2119
2120 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2121 EMACS_INT.
2122
2123 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2124
2125 * indent.c (Fvertical_motion): Local variable it_start is now
2126 EMACS_INT.
2127
2128 * regex.c (re_match, re_match_2, re_match_2_internal)
2129 (bcmp_translate, regcomp, regexec, print_double_string)
2130 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2131 (re_compile_pattern, re_exec): Declare arguments and local
2132 variables `size_t' and `ssize_t' and return values `regoff_t', as
2133 appropriate.
2134 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2135 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2136 <compile_stack_type>: `size' and `avail' are now `size_t'.
2137
2138 * regex.h <regoff_t>: Use ssize_t, not int.
2139 (re_search, re_search_2, re_match, re_match_2): Arguments that
2140 specify buffer/string position and length are now ssize_t and
2141 size_t. Return type is regoff_t.
2142
613052cd
BK
21432011-04-16 Ben Key <bkey76@gmail.com>
2144
2145 * nsfont.m: Fixed bugs in ns_get_family and
2146 ns_descriptor_to_entity that were caused by using free to
2147 deallocate memory blocks that were allocated by xmalloc (via
2148 xstrdup). This caused Emacs to crash when compiled with
2149 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2150 --enable-checking=xmallocoverrun). xfree is now used to
2151 deallocate these memory blocks.
2152
4170f62f 21532011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2154
71b41406
PE
2155 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2156
9587a89d
PE
2157 emacs_write: Accept and return EMACS_INT for sizes.
2158 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2159 et seq.
2160 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2161 Accept and return EMACS_INT.
2162 (emacs_gnutls_write): Return the number of bytes written on
2163 partial writes.
2164 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2165 (emacs_read, emacs_write): Remove check for negative size, as the
2166 Emacs source code has been audited now.
9587a89d
PE
2167 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2168 (emacs_read, emacs_write): Use it.
273a5f82
PE
2169 * process.c (send_process): Adjust to the new signatures of
2170 emacs_write and emacs_gnutls_write. Do not attempt to store
2171 a byte offset into an 'int'; it might overflow.
9587a89d 2172 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2173
3e047f51
PE
2174 * sound.c: Don't assume sizes fit in 'int'.
2175 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2176 Return EMACS_INT, not int.
3e047f51 2177 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2178 Accept EMACS_INT, not int.
2179 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2180 record read return values.
2181
cc39a9db
BK
21822011-04-15 Ben Key <bkey76@gmail.com>
2183
c9d0ec6d
JB
2184 * keyboard.c (Qundefined): Don't declare static since it is used
2185 in nsfns.m.
2186 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2187 static since they are used in nsfont.m.
cc39a9db 2188
6c60eb9f
SM
21892011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2190
2191 * process.c (Qprocessp): Don't declare static.
2192 * lisp.h (Qprocessp): Declare again.
2193
7990b61a
JB
21942011-04-15 Juanma Barranquero <lekktu@gmail.com>
2195
2196 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2197
5d4cb038
PE
21982011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2199
8bd7b830 2200 Improve C-level modularity by making more things 'static'.
cd64ea1d 2201
e3b27b31
PE
2202 Don't publish debugger-only interfaces to other modules.
2203 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2204 (verify_bytepos, count_markers): Move decls to the only modules
2205 that need them.
2206 * region-cache.h (pp_cache): Likewise.
2207 * window.h (check_all_windows): Likewise.
2208 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2209
5d4cb038
PE
2210 * sysdep.c (croak): Now static, if
2211 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2212 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2213
2214 * alloc.c (refill_memory_reserve): Now static if
2215 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2216 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2217
e87b6180
PE
2218 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2219 Define only if USE_LUCID.
2220
ac64929e
PE
2221 * xrdb.c (x_customization_string, x_rm_string): Now static.
2222
6f37259d
PE
2223 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2224 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2225
1683e3ab
PE
2226 * xdisp.c (draw_row_with_mouse_face): Now static.
2227 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2228
de9c2632
PE
2229 * window.h (check_all_windows): Mark externally visible.
2230
2b96acb7
PE
2231 * window.c (window_deletion_count): Now static.
2232
2233 * undo.c: Make symbols static if they're not exported.
2234 (last_undo_buffer, last_boundary_position, pending_boundary):
2235 Now static.
2236
50436f33
PE
2237 * textprop.c (interval_insert_behind_hooks): Now static.
2238 (interval_insert_in_front_hooks): Likewise.
2239
64520e5c
PE
2240 * term.c: Make symbols static if they're not exported.
2241 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2242 (max_frame_lines, tty_set_terminal_modes):
2243 (tty_reset_terminal_modes, tty_turn_off_highlight):
2244 (get_tty_terminal): Now static.
2245 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2246 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2247 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2248 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2249 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2250
1fa53021
PE
2251 * sysdep.c: Make symbols static if they're not exported.
2252 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2253 Now static.
2254 (sigprocmask_set, full_mask): Remove; unused.
2255 (wait_debugging): Mark as visible.
2256 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2257 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2258
d4b43b22
PE
2259 * syntax.c (syntax_temp): Define only if !__GNUC__.
2260
b7c513d0
PE
2261 * sound.c (current_sound_device, current_sound): Now static.
2262
989b29ad
PE
2263 * search.c (searchbufs, searchbuf_head): Now static.
2264
13a55a78
PE
2265 * scroll.c (scroll_cost): Remove; unused.
2266 * dispextern.h (scroll_cost): Remove decl.
2267
de68a1fc
PE
2268 * region-cache.h (pp_cache): Mark as externally visible.
2269
40ccffa6
PE
2270 * process.c: Make symbols static if they're not exported.
2271 (process_tick, update_tick, create_process, chan_process):
2272 (Vprocess_alist, proc_buffered_char, datagram_access):
2273 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2274 (deactivate_process): Mark defn as static, as well as decl.
2275 * lisp.h (create_process): Remove decl.
2276 * process.h (chan_process, Vprocess_alist): Remove decls.
2277
ad64fc97
PE
2278 * print.c: Make symbols static if they're not exported.
2279 (print_depth, new_backquote_output, being_printed, print_buffer):
2280 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2281 (print_interval, print_number_index, initial_stderr_stream):
2282 Now static.
2283 * lisp.h (Fprinc): Remove decl.
2284 (debug_output_compilation_hack): Mark as externally visible.
2285
adddb265
PE
2286 * sysdep.c (croak): Move decl from here to syssignal.h.
2287 * syssignal.h (croak): Put it here, so the API can be checked when
2288 'croak' is called from dissociate_if_controlling_tty.
2289
1717ede2
PE
2290 * minibuf.c: Make symbols static if they're not exported.
2291 (minibuf_save_list, choose_minibuf_frame): Now static.
2292 * lisp.h (choose_minibuf_frame): Remove decl.
2293
fa5fb2bc
PE
2294 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2295
1e3890d1
PE
2296 * lread.c: Make symbols static if they're not exported.
2297 (read_objects, initial_obarray, oblookup_last_bucket_number):
2298 Now static.
2299 (make_symbol): Remove; unused.
2300 * lisp.h (initial_obarray, make_symbol): Remove decls.
2301
8a1414fa
PE
2302 * keyboard.c: Make symbols static if they're not exported.
2303 (single_kboard, recent_keys_index, total_keys, recent_keys):
2304 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2305 (this_single_command_key_start, echoing, last_auto_save):
2306 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2307 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2308 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2309 (Vlispy_mouse_stem, double_click_count):
2310 Now static.
2311 (force_auto_save_soon): Define only if SIGDANGER.
2312 (ignore_mouse_drag_p): Now static if
2313 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2314 (print_help): Remove; unused.
2315 (stop_character, last_timer_event): Mark as externally visible.
2316 * keyboard.h (ignore_mouse_drag_p): Declare only if
2317 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2318 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2319 * lisp.h (echoing): Remove decl.
2320 (force_auto_save_soon): Declare only if SIGDANGER.
2321 * xdisp.c (redisplay_window): Simplify code, to make it more
2322 obvious that ignore_mouse_drag_p is not accessed if !defined
2323 USE_GTK && !defined HAVE_NS.
2324
93ea6e8f
PE
2325 * intervals.c: Make symbols static if they're not exported.
2326 (merge_properties_sticky, merge_interval_right, delete_interval):
2327 Now static.
2328 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2329
77382fcc
PE
2330 * insdel.c: Make symbols static if they're not exported.
2331 However, leave prepare_to_modify_buffer alone. It's never
2332 called from outside this function, but that appears to be a bug.
2333 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2334 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2335 (adjust_after_replace_noundo): Remove; unused.
2336 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2337 (signal_before_change): Remove decls.
77382fcc 2338
9306c32e
PE
2339 * indent.c (val_compute_motion, val_vmotion): Now static.
2340
cd44d2eb
PE
2341 * image.c: Make symbols static if they're not exported.
2342 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2343 if USE_GTK.
2344 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2345 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2346
ad9a7a06
PE
2347 * fringe.c (standard_bitmaps): Now static.
2348 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2349
81626931
PE
2350 * frame.c: Make symbols static if they're not exported.
2351 (x_report_frame_params, make_terminal_frame): Now static.
2352 (get_frame_param): Now static, unless HAVE_NS.
2353 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2354 (x_get_resource_string): Remove; not used.
2355 * frame.h (make_terminal_frame, x_report_frame_params):
2356 (x_get_resource_string); Remove decls.
2357 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2358 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2359
239f9db9
PE
2360 * font.c, fontset.c: Make symbols static if they're not exported.
2361 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2362 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2363 * font.c (font_close_object): Now static.
2364 * font.h (font_close_object): Remove.
2365 * fontset.c (FONTSET_OBJLIST): Remove.
2366 (free_realized_fontset) #if-0 the body, which does nothing.
2367 (face_suitable_for_char_p): #if-0, as it's never called.
2368 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2369 * xfaces.c (face_at_string_position):
2370 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2371 since 0 is always ASCII.
2372
dfcf3579
PE
2373 * fns.c (weak_hash_tables): Now static.
2374
5045092b
PE
2375 * fileio.c: Make symbols static if they're not exported.
2376 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2377 (Vwrite_region_annotation_buffers): Now static.
2378
57a96f5c
PE
2379 * eval.c: Make symbols static if they're not exported.
2380 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2381 * lisp.h (backtrace_list): Remove decl.
2382
35f08c38
PE
2383 * emacs.c: Make symbols static if they're not exported.
2384 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2385 (fatal_error_code, fatal_error_signal_hook, standard_args):
2386 Now static.
2387 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2388 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2389 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2390 * lisp.h (fatal_error_signal_hook): Remove decl.
2391 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2392
f44bd759
PE
2393 * editfns.c: Move a (normally-unused) function to its only use.
2394 * editfns.c, lisp.h (get_operating_system_release): Remove.
2395 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2396 worth the hassle of breaking this out.
2397
b532497d
PE
2398 * xterm.c: Make symbols static if they're not exported.
2399 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2400 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2401 (x_destroy_window, x_delete_display):
2402 Now static.
2403 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2404 (x_mouse_leave): Remove; unused.
2405 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2406 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2407 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2408 Remove decls.
2409 (x_mouse_leave): Declare only if WINDOWSNT.
2410 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2411 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2412 USE_X_TOOLKIT.
2413
1675728f
PE
2414 * ftxfont.c: Make symbols static if they're not exported.
2415 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2416 HAVE_FREETYPE.
2417 * font.h (ftxfont_driver): Likewise.
2418
e4cebfca
PE
2419 * xfns.c: Make symbols static if they're not exported.
2420 (x_last_font_name, x_display_info_for_name):
2421 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2422 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2423 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2424 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2425 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2426 (last_show_tip_args): Now static.
2427 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2428 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2429 (x_screen_planes): Remove; unused.
2430 * dispextern.h (x_screen_planes): Remove decl.
2431
5bf46f05
PE
2432 * dispnew.c: Make symbols static if they're not exported.
2433 * dispextern.h (redraw_garbaged_frames, scrolling):
2434 (increment_row_positions): Remove.
2435 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2436 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2437 Now static.
2438 (redraw_garbaged_frames): Remove; unused.
2439
435f4c28
PE
2440 * xfaces.c: Make symbols static if they're not exported.
2441 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2442 Remove decls.
2443 * xterm.h (defined_color): Remove decls.
2444 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2445 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2446 (menu_face_changed_default, defined_color, free_realized_face):
2447 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2448 (ascii_face_of_lisp_face): Remove; unused.
2449
8524aef3
PE
2450 * xdisp.c: Make symbols static if they're not exported.
2451 * dispextern.h (scratch_glyph_row, window_box_edges):
2452 (glyph_to_pixel_coords, set_cursor_from_row):
2453 (get_next_display_element, set_iterator_to_next):
2454 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2455 (show_mouse_face): Remove decls
2456 * frame.h (message_buf_print): Likewise.
2457 * lisp.h (pop_message, set_message, check_point_in_composition):
2458 Likewise.
2459 * xterm.h (set_vertical_scroll_bar): Likewise.
2460 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2461 (message_buf_print, scratch_glyph_row, displayed_buffer):
2462 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2463 (get_next_display_element, show_mouse_face, window_box_edges):
2464 (frame_to_window_pixel_xy, check_point_in_composition):
2465 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2466 (glyph_to_pixel_coords): Remove; unused.
2467
16390cd2
PE
2468 * dired.c (file_name_completion): Now static.
2469
2470 * dbusbind.c (xd_in_read_queued_messages): Now static.
2471
a25f4dfa
PE
2472 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2473 * data.c (circular_list_error): Remove.
2474
14a9c8df
PE
2475 * commands.h (last_point_position, last_point_position_buffer):
2476 (last_point_position_window): Remove decls.
2477 * keyboard.c: Make these variables static.
2478
04f2d78b
CB
2479 * coding.h (coding, code_convert_region, encode_coding_gap):
2480 Remove decls.
74ab6df5
PE
2481 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2482 (iso_code_class, detect_coding, code_convert_region): Now static.
2483 (encode_coding_gap): Remove; unused.
2484
38dfbee1
PE
2485 * chartab.c (chartab_chars, chartab_bits): Now static.
2486
a2cb4e63
PE
2487 * charset.h (charset_iso_8859_1): Remove decl.
2488 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2489 Now static.
2490
127198fd
PE
2491 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2492 * ccl.c (Vccl_program_table): Now static.
2493 (check_ccl_update): Remove; unused.
2494
d85b608f
PE
2495 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2496 * category.h: ... from here.
2497 * category.c (check_category_table, set_category_set): Now static.
2498
31cd66f3
PE
2499 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2500 * lisp.h: Remove these decls.
2501
c358e587
PE
2502 * buffer.c (buffer_count): Remove unused var.
2503
e78aecca
PE
2504 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2505 so that it's not optimized away.
2506 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2507 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2508 exported only to the debugger.
2509
e192d7d3 2510 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2511 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2512
92470028
PE
2513 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2514 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2515 was inaccessible from Lisp.
2516 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2517 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2518
244ed907
PE
2519 alloc.c: Import and export fewer symbols, and remove unused items.
2520 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2521 is defined.
2522 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2523 it's not optimized away by whole-program optimization.
2524 (message_enable_multibyte, free_misc): Remove.
2525 (catchlist, handlerlist, mark_backtrace):
2526 Declare only if BYTE_MARK_STACK.
2527 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2528 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2529 (message_enable_multibyte): Remove decl.
2530 (free_misc, interval_free_list, float_block, float_block_index):
2531 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2532 (cons_free_list, last_marked_index):
2533 Now static.
2534 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2535 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2536 (mark_backtrace): Define only if BYTE_MARK_STACK.
2537 * xdisp.c (message_enable_multibyte): Now static.
2538
61c2b50e 2539 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2540 This makes it easier for human readers (and static analyzers)
2541 to see whether these variables are used from other modules.
2542 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2543 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2544 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2545 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2546 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2547 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2548 * xmenu.c, xselect.c:
2549 Declare Q* vars static if they are not used in other modules.
2550 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2551 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2552 Remove decls of unexported vars.
2553 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2554
95c82688
PE
2555 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2556
16a97296
PE
2557 Make Emacs functions such as Fatom 'static' by default.
2558 This makes it easier for human readers (and static analyzers)
2559 to see whether these functions can be called from other modules.
2560 DEFUN now defines a static function. To make the function external
2561 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2562 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2563 (Finit_image_library):
16a97296
PE
2564 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2565 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2566 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2567 Remove decls, since these functions are now static.
2568 (Funintern, Fget_internal_run_time): New decls, since these functions
2569 were already external.
95c82688 2570
16a97296
PE
2571 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2572 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2573 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2574 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2575 * keyboard.c, keymap.c, lread.c:
2576 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2577 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2578 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2579 Mark functions with DEFUE instead of DEFUN,
2580 if they are used in other modules.
2581 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2582 decls for now-static functions.
2583 * buffer.h (Fdelete_overlay): Remove decl.
2584 * callproc.c (Fgetenv_internal): Mark as internal.
2585 * composite.c (Fremove_list_of_text_properties): Remove decl.
2586 (Fcomposition_get_gstring): New forward static decl.
2587 * composite.h (Fcomposite_get_gstring): Remove decl.
2588 * dired.c (Ffile_attributes): New forward static decl.
2589 * doc.c (Fdocumntation_property): New forward static decl.
2590 * eval.c (Ffetch_bytecode): New forward static decl.
2591 (Funintern): Remove extern decl; now in .h file where it belongs.
2592 * fileio.c (Fmake_symbolic_link): New forward static decl.
2593 * image.c (Finit_image_library): New forward static decl.
2594 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2595 * intervals.h (Fprevious_property_change):
2596 (Fremove_list_of_text_properties): Remove decls.
2597 * keyboard.c (Fthis_command_keys): Remove decl.
2598 (Fcommand_execute): New forward static decl.
2599 * keymap.c (Flookup_key): New forward static decl.
2600 (Fcopy_keymap): Now static.
2601 * keymap.h (Flookup_key): Remove decl.
2602 * process.c (Fget_process): New forward static decl.
2603 (Fprocess_datagram_address): Mark as internal.
2604 * syntax.c (Fsyntax_table_p): New forward static decl.
2605 (skip_chars): Remove duplicate decl.
2606 * textprop.c (Fprevious_property_change): New forward static decl.
2607 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2608 Now internal.
2609 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2610 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2611
785bbd42
PE
2612 * editfns.c (Fformat): Remove unreachable code.
2613
8b913b57
AS
26142011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2615
2616 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2617 change. (Bug#8496)
2618
a6744a35
EZ
26192011-04-13 Eli Zaretskii <eliz@gnu.org>
2620
2621 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2622 when at ZV. (Bug#8487)
2623
e7974947
AS
26242011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2625
baad03f0
AS
2626 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2627 (Bug#8437)
2628 * keyboard.c (parse_tool_bar_item): Likewise.
2629 * sound.c (sound_cleanup, alsa_close): Likewise.
2630 * termcap.c (tgetent): Likewise.
2631 * xfns.c (x_default_font_parameter): Likewise.
2632 * xsettings.c (read_and_apply_settings): Likewise.
2633
e7974947
AS
2634 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2635 (overrun_check_free): Protoize.
2636
28272684
PE
26372011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2638
2639 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2640 since callers should never pass a negative size.
2641 Change the signature to match that of plain 'read' and 'write'; see
2642 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2643 * lisp.h: Update prototypes of emacs_write and emacs_read.
2644
11997c76
EZ
26452011-04-11 Eli Zaretskii <eliz@gnu.org>
2646
2647 * xdisp.c (redisplay_window): Don't try to determine the character
2648 position of the scroll margin if the window start point w->startp
e896f03c 2649 is outside the buffer's accessible region. (Bug#8468)
11997c76 2650
8a2cbd72
EZ
26512011-04-10 Eli Zaretskii <eliz@gnu.org>
2652
2653 Fix write-region and its subroutines for buffers > 2GB.
2654 * fileio.c (a_write, e_write): Modify declaration of arguments and
2655 local variables to support buffers larger than 2GB.
2656 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2657
2658 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2659 argument, local variables, and return value.
2660
2661 * lisp.h: Update prototypes of emacs_write and emacs_read.
2662
2663 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2664
4073e537 26652011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2666
1ebfdcb6
PE
2667 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2668
b2ded58d
PE
2669 Fix more problems found by GCC 4.6.0's static checks.
2670
7d66342c
PE
2671 * xdisp.c (vmessage): Use a better test for character truncation.
2672
bbf47d44
PE
2673 * charset.c (load_charset_map): <, not <=, for optimization,
2674 and to avoid potential problems with integer overflow.
9248994d 2675 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2676 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2677 * editfns.c (Fformat): Likewise.
1e69125e 2678 * syntax.c (skip_chars): Likewise.
3befa583 2679
e3019616
PE
2680 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2681 This also lets GCC 4.6.0 generate slightly better loop code.
2682
becfa255
PE
2683 * callint.c (Fcall_interactively): <, not <=, for optimization.
2684 (Fcall_interactively): Count the number of arguments produced,
2685 not the number of arguments given. This is simpler and lets GCC
2686 4.6.0 generate slightly better code.
2687
dae0cd48
PE
2688 * ftfont.c: Distingish more carefully between FcChar8 and char.
2689 The previous code passed unsigned char * to a functions like
2690 strlen and xstrcasecmp that expect char *, which does not
2691 conform to the C standard.
2692 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2693 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2694 char * when the C standard requires it.
2695
76032d70
PE
2696 * keyboard.c (read_char): Remove unused var.
2697
eb3f1cc8
PE
2698 * eval.c: Port to Windows vsnprintf (Bug#8435).
2699 Include <limits.h>.
2700 (SIZE_MAX): Define if the headers do not.
2701 (verror): Do not give up if vsnprintf returns a negative count.
2702 Instead, grow the buffer. This ports to Windows vsnprintf, which
2703 does not conform to C99. Problem reported by Eli Zaretskii.
2704 Also, simplify the allocation scheme, by avoiding the need for
2705 calling realloc, and removing the ALLOCATED variable.
2706
70476b54
PE
2707 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2708
12020a9e
PE
2709 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2710 But keep the doprint source code for now, as we might revamp it
2711 and use it again (Bug#8435).
ea6c7ae6
PE
2712 * lisp.h (doprnt): Remove.
2713 * Makefile.in (base_obj): Remove doprnt.o.
2714 * deps.mk (doprnt.o): Remove.
2715
5fdb398c
PE
2716 error: Print 32- and 64-bit integers portably (Bug#8435).
2717 Without this change, on typical 64-bit hosts error ("...%d...", N)
2718 was used to print both 32- and 64-bit integers N, which relied on
2719 undefined behavior.
2720 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2721 New macro.
2722 * lisp.h (error, verror): Mark as printf-like functions.
2723 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2724 Report overflow in size calculations when allocating printf buffer.
2725 Do not truncate output string at its first null byte.
2726 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2727 Truncate the output at a character boundary, since vsnprintf does not
2728 do that.
2729 * charset.c (check_iso_charset_parameter): Convert internal
2730 character to string before calling 'error', since %c now has the
2731 printf meaning.
2732 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2733 overflow when computing char to be passed to 'error'. Do not
2734 pass Lisp_Object to 'error'; pass the integer instead.
2735 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2736 formatted with plain %d.
2737
b189fa66
PE
2738 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2739
bff87ef0
PE
2740 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2741
7e2cac20
PE
2742 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2743
ce4d90b5
PE
2744 * xterm.c (x_catch_errors): Remove duplicate declaration.
2745
266c9547
PE
2746 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2747
79c49ad2
PE
2748 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2749
368f4090
JM
27502011-04-10 Jim Meyering <meyering@redhat.com>
2751
2752 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2753 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2754 return ssize_t not "int", and use size_t as the buffer length.
2755 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2756 * gnutls.h: Update declarations.
2757 * process.c (read_process_output): Use ssize_t, to match.
2758 (send_process): Likewise.
2759
a32d4040
CY
27602011-04-09 Chong Yidong <cyd@stupidchicken.com>
2761
2762 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2763
8546720e 27642011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2765
04f2d78b
CB
2766 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2767 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2768
8546720e
GM
2769 * xterm.c (handle_one_xevent):
2770 * xmenu.c (create_and_show_popup_menu):
2771 * xselect.c (x_decline_selection_request)
2772 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2773
0a2f5c1a 27742011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2775
2776 Fix some uses of `int' instead of EMACS_INT.
2777 * search.c (string_match_1, fast_string_match)
2778 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2779 (scan_buffer, find_next_newline_no_quit)
2780 (find_before_next_newline, search_command, Freplace_match)
2781 (Fmatch_data): Make some `int' variables be EMACS_INT.
2782
2783 * xdisp.c (display_count_lines): 3rd argument and return value now
2784 EMACS_INT. All callers changed.
2785 (pint2hrstr): Last argument is now EMACS_INT.
2786
2787 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2788 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2789 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2790 (decode_coding_utf_16, decode_coding_emacs_mule)
2791 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2792 (decode_coding_ccl, decode_coding_charset)
2793 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2794 (decode_coding_iso_2022, decode_coding_emacs_mule)
2795 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2796 <char_offset, last_offset>: Declare EMACS_INT.
2797 (encode_coding_utf_8, encode_coding_utf_16)
2798 (encode_coding_emacs_mule, encode_invocation_designation)
2799 (encode_designation_at_bol, encode_coding_iso_2022)
2800 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2801 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2802 Declare EMACS_INT.
2803 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2804 (encode_invocation_designation): Last argument P_NCHARS is now
2805 EMACS_INT.
2806 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2807 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2808
2809 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2810 All users changed.
2811
2812 * ccl.c (Fccl_execute_on_string): Declare some variables
2813 EMACS_INT.
2814
8546720e 28152011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2816
2817 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2818
4e19a977
CS
28192011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2820
2821 * process.c (Fformat_network_address): Doc fix.
2822
87302331
R
28232011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2824
2825 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2826
cbb59342
CY
28272011-04-08 Chong Yidong <cyd@stupidchicken.com>
2828
2829 * keyboard.c (read_char): Call Lisp function help-form-show,
2830 instead of using internal_with_output_to_temp_buffer.
2831 (Qhelp_form_show): New var.
e0d38eeb 2832 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2833
2834 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2835
2836 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2837
e67a13ab
CY
28382011-04-06 Chong Yidong <cyd@stupidchicken.com>
2839
04f2d78b
CB
2840 * process.c (Flist_processes): Remove to Lisp.
2841 (list_processes_1): Delete.
e67a13ab 2842
973f782d
EZ
28432011-04-06 Eli Zaretskii <eliz@gnu.org>
2844
7c106b1e
EZ
2845 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2846
973f782d
EZ
2847 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2848
41cf7d1a 28492011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2850
ca23cc88
PE
2851 Fix more problems found by GCC 4.6.0's static checks.
2852
f390e2d5
PE
2853 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2854
42eea0d0
PE
2855 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2856
b69769da 2857 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2858
f9541e84
PE
2859 * xdisp.c (vmessage): Mark as a printf-like function.
2860
13841b55
PE
2861 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2862
c136c10f
PE
2863 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2864
5e2d4a30
PE
2865 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2866 printf-like functions.
2867 (tiff_load): Add casts to remove these marks before passing them
2868 to system-supplied API.
2869
583f48b9
PE
2870 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2871
b25d760e
PE
2872 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2873 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2874 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2875 directly, rather than having caller test rule sign. This avoids
2876 some unnecessary tests.
2877 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2878 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2879 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2880
bc7b6697 2881 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2882 (xfont_open): Avoid unnecessary tests.
bc7b6697 2883
27ccc379
PE
2884 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2885
dcd5c89a
PE
2886 * composite.h, composite.c (composition_gstring_put_cache):
2887 Use EMACS_INT, not int, for length.
2888
b13a45c6
PE
2889 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2890 breaking out part of COMPOSITION_DECODE_RULE.
2891 (COMPOSITION_DECODE_RULE): Use it.
2892 * composite.c (get_composition_id): Remove unused local vars,
2893 by using the new macro.
2894
1e792e4d
PE
2895 * textprop.c (set_text_properties_1): Change while to do-while,
2896 since the condition is always true at first.
2897
dc6c6455 2898 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2899 (interval_deletion_adjustment): Return unsigned value.
2900 All uses changed.
dc6c6455 2901
aba7731a
PE
2902 * process.c (list_processes_1, create_pty, read_process_output):
2903 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2904 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2905 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2906 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2907 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2908
fdfc4bf3
PE
2909 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2910
fca8fe46 2911 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2912 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2913
06a0259a 2914 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2915 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2916 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2917
e7b9e80f
PE
2918 * print.c (print_error_message): Avoid int overflow.
2919
56201685
PE
2920 * font.c (font_list_entities): Redo for clarity,
2921 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2922
78834453 2923 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2924 (font_score): Avoid potential overflow in diff calculation.
78834453 2925
0bc0b309 2926 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2927 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2928
e610eaca
PE
2929 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2930
b895abce
PE
2931 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2932 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2933 can always succeed if overflow has undefined behavior.
2934
1f1d9321 2935 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2936 (wordify): Omit three unnecessary tests.
1f1d9321 2937
c59478bc
PE
2938 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2939 All callers changed. This avoids the need for an unused var.
2940
79b73827
PE
2941 * casefiddle.c (casify_region): Remove var that is set but not used.
2942
a4db5dfe
PE
2943 * dired.c (file_name_completion): Remove var that is set but not used.
2944
43aae36e
PE
2945 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2946
2a47c44d 2947 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2948 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2949
a37c69bf
PE
2950 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2951 Check for integer overflow on size calculations.
2952
328ab8e7
PE
2953 * buffer.c (Fprevious_overlay_change): Remove var that is set
2954 but not used.
2955
e5a2a5cb
PE
2956 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2957 Remove vars that are set but not used.
8d84a6eb 2958 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2959 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2960
a60e5f68
PE
2961 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2962
f661cb61 2963 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2964 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2965
f0397f5a
PE
2966 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2967 that are set but not used.
2968
8664db06 2969 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2970 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2971
6abdaa4a
PE
2972 * xselect.c (x_get_local_selection, x_handle_property_notify):
2973 Remove vars that are set but not used.
2974
0ce7538d 2975 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2976 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2977
9ae848fc
PE
2978 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2979 Remove var that is set but not used.
0b918413
PE
2980 (scroll_bar_windows_size): Now size_t, not int.
2981 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2982 Check for overflow.
9ae848fc 2983
a5a62657
PE
2984 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2985 (map_tty_color) [!defined MSDOS]: Likewise.
2986
5c5cdd39
PE
2987 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2988
66ebf983
PE
2989 * coding.c: Remove vars that are set but not used.
2990 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2991 All callers changed.
2992 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2993 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2994 (decode_coding_charset): Remove vars that are set but not used.
2995
1be4d761
PE
2996 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2997 that is set but not used.
2998
47553fa8
PE
2999 * print.c (print_object): Remove var that is set but not used.
3000
1f7196bf 3001 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3002 The gnulib version avoids calling malloc in the usual case,
3003 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3004 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3005 * filelock.c (current_lock_owner): Likewise.
3006 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3007 * sysdep.c: Include allocator.h, careadlinkat.h.
3008 (emacs_no_realloc_allocator): New static constant.
3009 (emacs_readlink): New function.
fdb61804
PE
3010 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3011 ../lib/careadlinkat.h.
d1fdcab7 3012
f84c17c7
SM
30132011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3014
3015 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3016 first non-nil return value).
3017
ef3862ad
JD
30182011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3019
3020 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3021 if not defined (Bug#8403).
3022
376a7006
JB
30232011-04-02 Juanma Barranquero <lekktu@gmail.com>
3024
3025 * xdisp.c (display_count_lines): Remove parameter `start',
3026 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3027 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3028 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3029 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3030 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3031 and thereabouts. All callers changed.
3032 (get_per_char_metric): Remove parameter `f', unused since
3033 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3034
6ca3801d
JM
30352011-04-02 Jim Meyering <meyering@redhat.com>
3036
3037 do not dereference NULL upon failed strdup
3038 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3039 (ns_get_family): Likewise.
3040
d8e2b5ba
JB
30412011-04-02 Juanma Barranquero <lekktu@gmail.com>
3042
3043 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3044
8c74fcbd
JD
30452011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3046
3047 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3048 later (Bug#8403).
3049
7200d79c
SM
30502011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3051
03408648 3052 Add lexical binding.
7200d79c 3053
03408648
SM
3054 * window.c (Ftemp_output_buffer_show): New fun.
3055 (Fsave_window_excursion):
3056 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3057
3058 * lread.c (lisp_file_lexically_bound_p): New function.
3059 (Fload): Bind Qlexical_binding.
3060 (readevalloop): Remove `evalfun' arg.
3061 Bind Qinternal_interpreter_environment.
3062 (Feval_buffer): Bind Qlexical_binding.
3063 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3064 Mark as dynamic.
3065 (syms_of_lread): Declare `lexical-binding'.
3066
3067 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3068
3069 * keyboard.c (eval_dyn): New fun.
3070 (menu_item_eval_property): Use it.
ca105506
SM
3071
3072 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3073
03408648
SM
3074 * fns.c (concat, mapcar1): Accept byte-code-functions.
3075
3076 * eval.c (Fsetq): Handle lexical vars.
3077 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3078 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3079 (FletX, Flet): Obey lexical binding.
3080 (Fcommandp): Handle closures.
3081 (Feval): New `lexical' arg.
3082 (eval_sub): New function extracted from Feval. Use it almost
3083 everywhere where Feval was used. Look up vars in lexical env.
3084 Handle closures.
3085 (Ffunctionp): Move from subr.el.
3086 (Ffuncall): Handle closures.
3087 (apply_lambda): Remove `eval_flags'.
3088 (funcall_lambda): Handle closures and new byte-code-functions.
3089 (Fspecial_variable_p): New function.
3090 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3091 but without exporting it to Lisp.
23aba0ea 3092
23aba0ea 3093 * doc.c (Fdocumentation, store_function_docstring):
03408648 3094 * data.c (Finteractive_form): Handle closures.
23aba0ea 3095
03408648
SM
3096 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3097 interactive spec.
ba83908c 3098
04f2d78b
CB
3099 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3100 New byte-codes.
03408648
SM
3101 (exec_byte_code): New function extracted from Fbyte_code to handle new
3102 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3103
03408648 3104 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3105
03408648 3106 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3107
e2abce01
JB
31082011-03-31 Juanma Barranquero <lekktu@gmail.com>
3109
3110 * xdisp.c (redisplay_internal): Fix prototype.
3111
63696a73 31122011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3113
63696a73 3114 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3115 (try_scrolling): Use it when setting scroll_limit.
3116 Limit scrolling to 100 screen lines.
63696a73
EZ
3117 (redisplay_window): Even when falling back on "recentering",
3118 position point in the window according to scroll-conservatively,
3119 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3120
3121 (try_scrolling): When point is above the window, allow searching
3122 as far as scroll_max, or one screenful, to compute vertical
3123 distance from PT to the scroll margin position. This prevents
3124 try_scrolling from unnecessarily failing when
3125 scroll-conservatively is set to a value slightly larger than the
3126 window height. Clean up the case of PT below the margin at bottom
3127 of window: scroll_max can no longer be INT_MAX. When aggressive
3128 scrolling is in use, don't let point enter the opposite scroll
3129 margin as result of the scroll.
3130 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3131 threshold of 100 lines for never-recentering scrolling.
3132
e4cc2dfc
JB
31332011-03-31 Juanma Barranquero <lekktu@gmail.com>
3134
3135 * dispextern.h (move_it_by_lines):
3136 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3137 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3138 (message_log_check_duplicate): Remove parameters `prev_bol' and
3139 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3140 (redisplay_internal): Remove parameter `preserve_echo_area',
3141 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3142
3143 * indent.c (Fvertical_motion):
3144 * window.c (window_scroll_pixel_based, Frecenter):
3145 Don't pass `need_y_p' to `move_it_by_lines'.
3146
1c470562
SM
31472011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3148
44f230aa
SM
3149 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3150 steal a few bits to be more compact.
3151 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3152 Remove unneeded casts.
3153
1c470562
SM
3154 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3155
888adce9
ZK
31562011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3157
3158 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3159 binding" message (bug#7967).
3160
f838ed7b
PE
31612011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3162
77861b95
PE
3163 Fix more problems found by GCC 4.6.0's static checks.
3164
de6dbc14
PE
3165 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3166 Remove unused local var.
3167
f838ed7b
PE
3168 * editfns.c (Fmessage_box): Remove unused local var.
3169
792c7b2b
PE
3170 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3171 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3172 Omit unused local vars.
c499e557 3173 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3174 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3175 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3176 Omit unused local var.
3177
ba0165e1
PE
3178 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3179 Don't assume string length fits in int.
32ad8845 3180 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3181 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3182
3c59b4c9
PE
3183 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3184 instead of alloca (Bug#8344).
3185
a3eed478 3186 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3187 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3188
eb4d412d
PE
3189 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3190
1658b401
PE
3191 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3192 concerns.
3193
3194 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3195
3196 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3197
9a2c6e05
PE
3198 * keyboard.c (syms_of_keyboard): Use the same style as later
3199 in this function when indexing through an array. This also
3200 works around GCC bug 48267.
3201
03d0a109
PE
3202 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3203
44f730c8
PE
3204 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3205
fe75f926
PE
3206 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3207 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3208
ffa8c828
PE
3209 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3210 This avoids undefined behavior on integer overflow, and is a bit
3211 more convenient anyway since it is compared to a size_t variable.
3212
c5101a77
PE
3213 Variadic C functions now count arguments with size_t, not int.
3214 This avoids an unnecessary limitation on 64-bit machines, which
3215 caused (substring ...) to crash on large vectors (Bug#8344).
3216 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3217 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3218 All variadic functions and their callers changed accordingly.
c5101a77
PE
3219 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3220 * data.c (arith_driver, float_arith_driver): Likewise.
3221 * editfns.c (general_insert_function): Likewise.
3222 * eval.c (struct backtrace.nargs, interactive_p)
3223 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3224 (funcall_lambda, mark_backtrace): Likewise.
3225 * fns.c (concat): Likewise.
3226 * frame.c (x_set_frame_parameters): Likewise.
3227 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3228 0 if not found, not -1. All callers changed.
3229
dd3f25f7
PE
3230 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3231 (stack_copy_size): Now size_t, not int.
3232 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3233
461c2ab9
JB
32342011-03-28 Juanma Barranquero <lekktu@gmail.com>
3235
3236 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3237 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3238 All callers changed.
3239
3240 * lisp.h (multibyte_char_to_unibyte):
3241 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3242 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3243 * character.h (CHAR_TO_BYTE8):
3244 * cmds.c (internal_self_insert):
3245 * editfns.c (general_insert_function):
3246 * keymap.c (push_key_description):
3247 * search.c (Freplace_match):
3248 * xdisp.c (message_dolog, set_message_1): All callers changed.
3249
f6d62986
SM
32502011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3251
3252 * keyboard.c (safe_run_hook_funcall): New function.
3253 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3254 don't set the hook to nil, but remove the offending function instead.
3255 (Qcommand_hook_internal): Remove, unused.
3256 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3257 Vcommand_hook_internal.
3258
3259 * eval.c (enum run_hooks_condition): Remove.
3260 (funcall_nil, funcall_not): New functions.
3261 (run_hook_with_args): Call each function through a `funcall' argument.
3262 Remove `cond' argument, now redundant.
3263 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3264 (Frun_hook_with_args_until_failure): Adjust accordingly.
3265 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3266
1db5b1ad
JB
32672011-03-28 Juanma Barranquero <lekktu@gmail.com>
3268
3269 * dispextern.h (string_buffer_position): Remove declaration.
3270
3271 * print.c (strout): Remove parameter `multibyte', unused since
3272 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3273
3274 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3275 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3276 All callers changed.
3277
3278 * w32.c (_wsa_errlist): Use braces for struct initializers.
3279
3280 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3281 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3282 All callers changed.
3283 (string_buffer_position): Likewise. Also, make static (it's never
3284 used outside xdisp.c).
3285 (cursor_row_p): Remove parameter `w', unused since
3286 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3287 (decode_mode_spec): Remove parameter `precision', introduced during
3288 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3289 All callers changed.
3290
5ffb62aa
JD
32912011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3292
3293 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3294
461c2ab9 32952011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3296
3297 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3298 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3299 (ns_update_auto_hide_menu_bar): New functions.
3300 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3301 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3302 ns_constrain_all_frames.
3303 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3304 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3305
5c380ffb
JD
33062011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3307
3308 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3309
9af30bdf
GM
33102011-03-27 Glenn Morris <rgm@gnu.org>
3311
3312 * syssignal.h: Replace RETSIGTYPE with void.
3313 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3314 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3315 Replace SIGTYPE with void everywhere.
3316 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3317 * s/template.h (SIGTYPE): Remove commented out definition.
3318
e2abce01
JB
33192011-03-26 Eli Zaretskii <eliz@gnu.org>
3320
3321 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3322 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3323
f868cd8a
JB
33242011-03-26 Juanma Barranquero <lekktu@gmail.com>
3325
59eb0929
JB
3326 * w32.c (read_unc_volume): Use parameter `henum', instead of
3327 global variable `wget_enum_handle'.
3328
3329 * keymap.c (describe_vector): Remove parameters `indices' and
3330 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3331 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3332
f868cd8a
JB
3333 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3334
3335 * keyboard.c (timer_check): Remove parameter `do_it_now',
3336 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3337 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3338 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3339
3340 * keyboard.c (read_char):
3341 * w32menu.c (w32_menu_display_help):
3342 * xmenu.c (show_help_event, menu_help_callback):
3343 Adjust calls to `show_help_echo'.
3344
3345 * gtkutil.c (xg_maybe_add_timer):
3346 * keyboard.c (readable_events):
3347 * process.c (wait_reading_process_output):
3348 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3349
3350 * insdel.c (adjust_markers_gap_motion):
3351 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3352 (gap_left, gap_right): Don't call it.
3353
2ecf6fdb
CY
33542011-03-25 Chong Yidong <cyd@stupidchicken.com>
3355
3356 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3357 incurred during fontification.
3358
6b1f9ba4
JB
33592011-03-25 Juanma Barranquero <lekktu@gmail.com>
3360
3361 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3362 (DEFVAR_PER_BUFFER): Don't pass it.
3363
3364 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3365 (scrolling_window): Don't pass it.
3366
0f4a96b5
JB
33672011-03-25 Juanma Barranquero <lekktu@gmail.com>
3368
3369 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3370
3371 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3372 and `suffix'.
3373 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3374 of variables specific to SELinux and computation of `encoded_absname'.
3375
3376 * image.c (XPutPixel): Remove unused variable `height'.
3377
3378 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3379
3380 * unexw32.c (get_section_info): Remove unused variable `section'.
3381
3382 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3383 (system_process_attributes): Remove unused variable `sess'.
3384 (sys_read): Remove unused variable `err'.
3385
3386 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3387 (w32_wnd_proc): Remove unused variable `isdead'.
3388 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3389 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3390 (x_create_tip_frame): Remove unused variable `tem'.
3391
3392 * w32inevt.c (w32_console_read_socket):
3393 Remove unused variable `no_events'.
3394
3395 * w32term.c (x_draw_composite_glyph_string_foreground):
3396 Remove unused variable `width'.
3397
1149507c
JB
33982011-03-24 Juanma Barranquero <lekktu@gmail.com>
3399
3400 * w32term.c (x_set_glyph_string_clipping):
3401 Don't pass uninitialized region to CombineRgn.
3402
9c88f339
JB
34032011-03-23 Juanma Barranquero <lekktu@gmail.com>
3404
3405 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3406 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3407 (Fx_close_connection): Remove unused variable `i'.
3408
3409 * w32font.c (w32font_draw): Return number of glyphs.
3410 (w32font_open_internal): Remove unused variable `i'.
3411 (w32font_driver): Add missing initializer.
3412
3413 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3414 (fill_in_menu): Remove unused variable `items_added'.
3415
3416 * w32term.c (last_mouse_press_frame): Remove static global variable.
3417 (w32_clip_to_row): Remove unused variable `f'.
3418 (x_delete_terminal): Remove unused variable `i'.
3419
3420 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3421 (NOTHING): Remove unused static global variable.
3422 (uniscribe_check_otf): Remove unused variable `table'.
3423 (uniscribe_font_driver): Add missing initializers.
3424
dee091a3
JD
34252011-03-23 Julien Danjou <julien@danjou.info>
3426
3427 * term.c (Fsuspend_tty, Fresume_tty):
3428 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3429 * window.c (temp_output_buffer_show):
3430 * insdel.c (signal_before_change):
3431 * frame.c (Fhandle_switch_frame):
3432 * fileio.c (Fdo_auto_save):
3433 * emacs.c (Fkill_emacs):
3434 * editfns.c (save_excursion_restore):
3435 * cmds.c (internal_self_insert):
3436 * callint.c (Fcall_interactively):
3437 * buffer.c (Fkill_all_local_variables):
3438 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3439 Use Frun_hooks.
0f4a96b5 3440 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3441 unconditionnaly since it does the check itself.
3442
2c520ab5 34432011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3444
c9c49752
PE
3445 Fix more problems found by GCC 4.5.2's static checks.
3446
8abc3f12
PE
3447 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3448 the first time through the loop, since we know p0 < p1 then.
3449 This also avoids a gcc -Wstrict-overflow warning.
3450
a2d26660
PE
3451 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3452 leading to a memory leak, possible in functions like
3453 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3454 of objects (Bug#8318).
a2d26660 3455
916c72e9
PE
3456 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3457 that could (at least in theory) be that large.
3458
19ab8a18
PE
3459 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3460 This is less likely to overflow, and avoids undefined behavior if
3461 overflow does occur. All callers changed. Use strtoul to scan
3462 for the unsigned long integer.
b7cbbd6f
PE
3463 (pint2hrstr): Simplify and tune code slightly.
3464 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3465
f0641eff
PE
3466 * scroll.c (do_scrolling): Work around GCC bug 48228.
3467 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3468
7f650bb9
PE
3469 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3470 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3471 (validate_x_resource_name): Simplify count usage.
3472 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3473
37dd57d1
PE
3474 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3475 fail (Bug#8306).
81e56e61 3476
699979fc 3477 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3478
401bf9b4
PE
3479 * process.c (Fmake_network_process): Use socklen_t, not int,
3480 where POSIX says socklen_t is required in portable programs.
3481 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3482 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3483 (Fmake_network_process, server_accept_connection):
3484 (wait_reading_process_output, read_process_output):
3485 Likewise.
3486
b93aacde
PE
3487 * process.c: Rename or move locals to avoid shadowing.
3488 (list_processes_1, Fmake_network_process):
3489 (read_process_output_error_handler, exec_sentinel_error_handler):
3490 Rename or move locals.
4dc343ee 3491 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3492 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3493 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3494 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3495 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3496
af8a867c 3497 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3498 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3499 Include tparam.h instead, since it declares them.
af8a867c
PE
3500 * cm.h (PC): Remove extern decl; tparam.h now does this.
3501 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3502 * terminfo.c: Include tparam.h, to check interfaces.
3503 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3504 (tparam): Adjust signature to match interface in tparam.h;
3505 this removes some undefined behavior. Check that outstring and len
3506 are zero, which they always are with Emacs.
3507 * tparam.h (PC, BC, UP): New extern decls.
3508
0248044d 3509 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3510 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3511
8ff096c1 3512 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3513 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3514 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3515 (ftfont_list): Remove unused local.
49eaafba
PE
3516 (get_adstyle_property, ftfont_pattern_entity):
3517 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3518 Rename locals to avoid shadowing.
8ff096c1 3519
e2be39f6
PE
3520 * xfont.c (xfont_list_family): Mark var as initialized.
3521
c9735e30
PE
3522 * xml.c (make_dom): Now static.
3523
8f5201ae
PE
3524 * composite.c (composition_compute_stop_pos): Rename local to
3525 avoid shadowing.
b246f932
PE
3526 (composition_reseat_it): Remove unused locals.
3527 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3528 (composition_update_it): Mark var as initialized.
11b61122
PE
3529 (find_automatic_composition): Mark vars as initialized,
3530 with a FIXME (Bug#8290).
8f5201ae 3531
760fbc2c
PE
3532 character.h: Rename locals to avoid shadowing.
3533 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3534 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3535 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3536 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3537 to avoid shadowing.
3538
ff08eb85
PE
3539 * textprop.c (property_change_between_p): Remove; unused.
3540
fc7bf025
PE
3541 * intervals.c (interval_start_pos): Now static.
3542
235d7abc
PE
3543 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3544
44f230aa
SM
3545 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3546 Rename locals to avoid shadowing.
3e7d6594 3547
50060332
PE
3548 * sound.c (wav_play, au_play, Fplay_sound_internal):
3549 Fix pointer signedness.
d01f234b 3550 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3551 (wav_play): Initialize a variable to 0, to prevent undefined
3552 behavior (Bug#8278).
50060332 3553
c4fc4e30
PE
3554 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3555
918436ed
PE
3556 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3557
c939f91b
PE
3558 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3559 clobbering (Bug#8298).
b9c7f648
PE
3560 * sysdep.c (sys_subshell): Likewise.
3561 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3562
6bd8c144
PE
3563 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3564 This should get cleaned up, so that child_setup has the
3565 same signature on all platforms.
3566
7710357c 3567 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3568 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3569
c59da222
CY
35702011-03-22 Chong Yidong <cyd@stupidchicken.com>
3571
3572 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3573 not to be necessary, and produces flickering.
3574
66b87493
GM
35752011-03-20 Glenn Morris <rgm@gnu.org>
3576
3577 * config.in: Remove file.
3578
45b6f6d5
JB
35792011-03-20 Juanma Barranquero <lekktu@gmail.com>
3580
3581 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3582 are now in src/globals.h.
3583 (syms_of_minibuf): Remove spurious & from previous change.
3584
3ec03f7e
LL
35852011-03-20 Leo <sdl.web@gmail.com>
3586
3587 * minibuf.c (completing-read-function): New variable.
3588 (completing-read-default): Rename from completing-read.
3589 (completing-read): Call completing-read-function.
3590
b14e3e21
CY
35912011-03-19 Juanma Barranquero <lekktu@gmail.com>
3592
3593 * xfaces.c (Fx_load_color_file):
3594 Read color file from absolute filename (bug#8250).
3595
f2b726e6
JB
35962011-03-19 Juanma Barranquero <lekktu@gmail.com>
3597
3598 * makefile.w32-in: Update dependencies.
3599
09f6ff02
EZ
36002011-03-17 Eli Zaretskii <eliz@gnu.org>
3601
3602 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3603
29a6015a
PE
36042011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3605
a3a6c54e
PE
3606 Fix more problems found by GCC 4.5.2's static checks.
3607
b766f867
PE
3608 * process.c (make_serial_process_unwind, send_process_trap):
3609 (sigchld_handler): Now static.
3610
be02381c
PE
3611 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3612 That way, the code declares only the vars that it needs.
3613 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3614 * s/cygwin.h (PTY_ITERATION): Likewise.
3615 * s/darwin.h (PTY_ITERATION): Likewise.
3616 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3617
57048744
PE
3618 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3619 * process.c (allocate_pty): Don't declare stb unless it's needed.
3620
7914961c 3621 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3622 (CONSTANTLIM): Remove; unused.
3623 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3624 Define only if needed.
7914961c 3625
b3967b18
PE
3626 * unexelf.c (unexec): Name an expression,
3627 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3628 Use a different way to cause a compilation error if anyone uses
3629 n rather than nn, a way that does not involve shadowing.
73366a00 3630 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3631
29a6015a
PE
3632 * deps.mk (unexalpha.o): Remove; unused.
3633
43cfc33e 3634 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3635 * unexec.h: New file.
ce701a33
PE
3636 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3637 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3638 Depend on unexec.h.
3639 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3640 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3641 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3642 Change as necessary to match prototype in unexec.h.
ce701a33 3643
01f44d5a
PE
3644 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3645 shadowing.
4f63c6bb 3646 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3647
a6670b0b
PE
3648 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3649 Rename locals to avoid shadowing.
3650
cef2010d 3651 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3652 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3653
d4d7173a
PE
3654 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3655
f08b802a
PE
3656 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3657 warning when compiling print.c.
3658
3ddb0639
PE
3659 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3660 instead of using an uninitialized var.
5ad03b97 3661 (font_sort_entities): Mark var as initialized.
3ddb0639 3662
170a2692
PE
3663 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3664
e663c700
PE
3665 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3666 pointers to constants.
89bc529a 3667 (font_parse_fcname): Remove unused vars.
7b81e2d0 3668 (font_delete_unmatched): Now static.
ea838e10 3669 (font_get_spec): Remove; unused.
13a547c6
PE
3670 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3671 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3672 Rename or move locals to avoid shadowing.
e663c700 3673
2a80c887 3674 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3675 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3676
1384fa33 3677 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3678 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3679
8b2c52e9
PE
3680 * alloc.c (mark_backtrace): Move decl from here ...
3681 * lisp.h: ... to here, so that it can be checked.
3682
475545b5 3683 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3684 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3685 (lisp_indirect_variable): Name an expression,
3686 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3687 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3688
b1349114 3689 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3690 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3691 Use const pointer when appropriate.
b1349114 3692
a2928364
PE
3693 * lisp.h (get_system_name, get_operating_system_release):
3694 Move decls here, to check interfaces.
3695 * process.c (get_operating_system_release): Move decl to lisp.h.
3696 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3697 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3698 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3699 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3700 (Fformat_time_string, Fencode_time, Finsert_char):
3701 (Ftranslate_region_internal, Fformat):
3702 Rename or remove local vars to avoid shadowing.
9710023e 3703 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3704
a415e694
PE
3705 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3706 avoid shadowing.
3707
8ef4622d
PE
3708 * lisp.h (eassert): Check that the argument compiles, even if
3709 ENABLE_CHECKING is not defined.
3710
946f9a5b
PE
3711 * data.c (Findirect_variable): Name an expression, to avoid
3712 gcc -Wbad-function-cast warning.
112396d6 3713 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3714 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3715 (Fmake_variable_buffer_local, Fmake_local_variable):
3716 Mark variables as initialized.
52746918 3717 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3718
e5aab7e7 3719 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3720 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3721 Rename locals to avoid shadowing.
dff45157
PE
3722 (mark_stack): Move local variables into the #ifdef region where
3723 they're used.
7bc26fdb
PE
3724 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3725 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3726 needed otherwise.
3727 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3728 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3729 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3730
e5aab7e7
PE
3731 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3732 avoids undefined behavior in theory.
3733
4da60324
PE
3734 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3735
88043301
PE
3736 Use functions, not macros, for up- and down-casing (Bug#8254).
3737 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3738 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3739 to use the following functions instead of these macros.
3740 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3741 EMACS_INT, since callers assume the returned value fits in int.
3742 (upcase1): Likewise, for UPCASE_TABLE.
3743 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3744 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3745 the race-condition problem in the old DOWNCASE.
88043301 3746
19ed5445
PE
3747 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3748 Rename locals to avoid shadowing.
3749 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3750 (regex_compile, re_search_2, re_match_2_internal):
3751 Remove unused local vars.
952db0d7
PE
3752 (FREE_VAR): Rewrite so as not to use empty "else",
3753 which gcc can warn about.
da053e48 3754 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3755 (RETALLOC_IF): Define only if needed.
3756 (WORDCHAR_P): Likewise. This one is never needed, but is used
3757 only in a comment talking about a compiler bug, so put inside
3758 the #if 0 of that comment.
3759 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3760 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3761 Remove; unused.
19ed5445 3762
1f3561e4 3763 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3764 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3765 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3766
ded6f8f7
PE
3767 * search.c (simple_search): Remove unused var.
3768
dbd37a95
PE
3769 * dired.c (compile_pattern): Move decl from here ...
3770 * lisp.h: ... to here, so that it can be checked.
3771 (struct re_registers): New forward decl.
3772
7e47afad
PE
3773 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3774
85f24f61
PE
3775 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3776 All uses changed.
3777 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3778 Rename locals to avoid shadowing.
5671df8f 3779 (Fvertical_motion): Mark locals as initialized.
85f24f61 3780
181aa2be 3781 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3782 (casify_region): Mark local as initialized.
181aa2be 3783
930d429c
PE
3784 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3785
7082eac6
PE
3786 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3787 New macros, so that the caller can use some names other than
3788 gcpro1, gcpro2, etc.
3789 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3790 of the new macros.
3791 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3792 argument, for consistency with GCPRO2_VAR, etc: it is now the
3793 prefix of the variable, not the variable itself. All uses
3794 changed.
38b2c076
PE
3795 * dired.c (directory_files_internal, file_name_completion):
3796 Rename locals to avoid shadowing.
3797
15206ed9
PE
3798 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3799 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3800 dired.c's scmp function, had undefined behavior.
3801 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3802 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3803 * buffer.h: ... to here, because these macros use current_buffer,
3804 and the new implementation with inline functions needs to have
3805 current_buffer in scope now, rather than later when the macros
3806 are used.
3807 (downcase, upcase1): New static inline functions.
3808 (DOWNCASE, UPCASE1): Reimplement using these functions.
3809 This avoids undefined behavior in expressions like
3810 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3811 from race conditions in accessing the global variables
3812 case_temp1 and case_temp2.
3813 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3814 * lisp.h (case_temp1, case_temp2): Remove their decls.
3815 * character.h (ASCII_CHAR_P): Move from here ...
3816 * lisp.h: ... to here, so that the inline functions mentioned
3817 above can use them.
3818
4a6bea26
PE
3819 * dired.c (directory_files_internal_unwind): Now static.
3820
f14b7e14
PE
3821 * fileio.c (file_name_as_directory, directory_file_name):
3822 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3823 Now static.
2893f146
PE
3824 (file_name_as_directory): Use const pointers when appropriate.
3825 (Fexpand_file_name): Likewise. In particular, newdir might
3826 point at constant storage, so make it a const pointer.
fd4ead52 3827 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3828 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3829 signedness issues.
f839df0c
PE
3830 (Fset_file_times, Finsert_file_contents, auto_save_error):
3831 Rename locals to avoid shadowing.
f14b7e14 3832
5716756e 3833 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3834 (Ftry_completion, Fall_completions): Rename or remove locals
3835 to avoid shadowing.
5716756e 3836
b4c3046a
PE
3837 * marker.c (bytepos_to_charpos): Remove; unused.
3838
b45db522
PE
3839 * lisp.h (verify_bytepos, count_markers): New decls,
3840 so that gcc does not warn that these functions aren't declared.
3841
85876d07
PE
3842 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3843 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3844 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3845 (copy_text): Remove unused local var.
85876d07 3846
03d78a21 3847 * filelock.c (within_one_second): Now static.
b3dd38ab 3848 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3849
5df8f01b
PE
3850 * buffer.c (fix_overlays_before): Mark locals as initialized.
3851 (fix_start_end_in_overlays): Likewise. This function should be
3852 simplified by using pointers-to-pointers, but that's a different
3853 matter.
b1d876f1 3854 (switch_to_buffer_1): Now static.
8f54f30a
PE
3855 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3856 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3857
a70072c9 3858 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3859 Fix pointer signedness issue.
edced198
PE
3860 (sys_subshell): Mark local as volatile if checking for lint,
3861 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3862 (MAXPATHLEN): Define only if needed.
a70072c9 3863
a0977c44
PE
3864 * process.c (serial_open, serial_configure): Move decls from here ...
3865 * systty.h: ... to here, so that they can be checked.
3866
a884fdcc
PE
3867 * fns.c (get_random, seed_random): Move extern decls from here ...
3868 * lisp.h: ... to here, so that they can be checked.
3869
604efe86 3870 * sysdep.c (reset_io): Now static.
b8950c94 3871 (wait_for_termination_signal): Remove; unused.
604efe86 3872
38fc62d9
PE
3873 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3874 (copy_keymap_item, append_key, push_text_char_description):
3875 Now static.
1004a21a 3876 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3877 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3878 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3879 (describe_map_tree):
3880 Rename locals to avoid shadowing.
38fc62d9 3881
2f2650da
PE
3882 * keyboard.c: Declare functions static if they are not used elsewhere.
3883 (echo_char, echo_dash, cmd_error, top_level_2):
3884 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3885 (read_char, kbd_buffer_get_event, make_lispy_position):
3886 (make_lispy_event, make_lispy_movement, apply_modifiers):
3887 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3888 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3889 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3890 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3891 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3892
a053e86c 3893 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3894 (mark_kboards): Move decl here ...
3895 * alloc.c (mark_kboards): ... from here.
a053e86c 3896
4752793e
PE
3897 * lisp.h (force_auto_save_soon): New decl.
3898
74f10ca7 3899 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3900 (DEFINE_DUMMY_FUNCTION): New macro.
3901 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3902 Use it.
c03cd23f
PE
3903 (main): Add casts to avoid warnings
3904 if GCC considers string literals to be constants.
74f10ca7 3905
022e70d4
PE
3906 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3907
59d6fe83
PE
3908 * dbusbind.c: Pointer signedness fixes.
3909 (xd_signature, xd_append_arg, xd_initialize):
3910 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3911 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3912 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3913 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3914
78320123
PE
3915 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3916 if GCC considers string literals to be constants.
49cebcca 3917 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3918
35ac2a97
SM
39192011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3920
fb103ca9
SM
3921 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3922 (print_preprocess, print_object): New macro to fix last change.
3923
35ac2a97
SM
3924 * print.c (print_preprocess): Don't forget font objects.
3925
62973b41
JB
39262011-03-16 Juanma Barranquero <lekktu@gmail.com>
3927
3928 * emacs.c (USAGE3): Doc fixes.
3929
0e48bb22
AS
39302011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3931
3932 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3933 structure.
3934
7684e57b
JB
39352011-03-14 Juanma Barranquero <lekktu@gmail.com>
3936
3937 * lisp.h (VWindow_system, Qfile_name_history):
3938 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3939 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3940 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3941
3942 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3943 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3944
3945 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3946 * w32console.c (detect_input_pending, read_input_pending)
3947 (encode_terminal_code):
3948 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3949 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3950 (w32_system_caret_y, Qfile_name_history):
3951 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3952 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3953 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3954 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3955 * w32proc.c (Qlocal, report_file_error):
3956 * w32term.c (Vwindow_system, updating_frame):
3957 * w32uniscribe.c (initialized, uniscribe_font_driver):
3958 Remove unneeded extern declarations.
3959
2aa46d6c
CY
39602011-03-14 Chong Yidong <cyd@stupidchicken.com>
3961
c96bbc66 3962 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3963
cffc6f3b
CY
39642011-03-13 Chong Yidong <cyd@stupidchicken.com>
3965
3966 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3967 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3968 These macros can no longer be used for assignment.
3969
44f230aa
SM
3970 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3971 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3972 (record_buffer_markers, fetch_buffer_markers): New functions for
3973 recording and fetching special buffer markers.
3974 (set_buffer_internal_1, set_buffer_temp): Use them.
3975
3976 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3977
3978 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3979
3980 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3981 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3982
3983 * xdisp.c (hscroll_window_tree):
3984 (reconsider_clip_changes): Use PT instead of BUF_PT.
3985
d251f04b
EZ
39862011-03-13 Eli Zaretskii <eliz@gnu.org>
3987
3988 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3989 $(EMACS_ROOT)/lib/intprops.h.
3990
f0c77cd1
PE
39912011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3992
3eca4629
PE
3993 Fix more problems found by GCC 4.5.2's static checks.
3994
7c86ee98
PE
3995 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3996 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3997 (xg_free_frame_widgets): Make it clear that a local variable is
3998 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3999 (gdk_window_get_screen): Make it clear that this macro is needed
4000 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4001 (int_gtk_range_get_value): New function, which avoids a diagnostic
4002 from gcc -Wbad-function-cast.
4003 (xg_set_toolkit_scroll_bar_thumb): Use it.
4004 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4005 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4006 (get_utf8_string, xg_get_file_with_chooser):
4007 Rename locals to avoid shadowing.
4008 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4009
41729b81
PE
4010 * xgselect.c (xg_select): Remove unused var.
4011
f0c77cd1
PE
4012 * image.c (four_corners_best): Mark locals as initialized.
4013 (gif_load): Initialize transparent_p to zero (Bug#8238).
4014 Mark another local as initialized.
ec6cf4c6 4015 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4016
ce0ad53d 4017 * image.c (clear_image_cache): Now static.
d5d5a617 4018 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4019 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4020 (x_edge_detection): Remove unnecessary cast that
4021 gcc -Wbad-function-cast diagnoses.
2037898d 4022 (gif_load): Fix pointer signedness.
6ae141d6
PE
4023 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4024 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4025
33383987 40262011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4027
d32df629
PE
4028 Improve quality of tests for time stamp overflow.
4029 For example, without this patch (encode-time 0 0 0 1 1
4030 1152921504606846976) returns the obviously-bogus value (-948597
4031 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4032 reports time overflow. See
4033 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4034 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4035 * editfns.c: Include limits.h and intprops.h.
4036 (TIME_T_MIN, TIME_T_MAX): New macros.
4037 (time_overflow): Move earlier, to before first use.
4038 (hi_time, lo_time): New functions, for an accurate test for
4039 out-of-range times.
4040 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4041 (Fget_internal_run_time): Don't assume time_t fits in int.
4042 (make_time): Use list2 instead of Fcons twice.
4043 (Fdecode_time): More accurate test for out-of-range times.
4044 (check_tm_member): New function.
4045 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4046 (lisp_time_argument): Don't rely on undefined left-shift and
4047 right-shift behavior when checking for time stamp overflow.
8be6f318 4048
fe31d94c
PE
4049 * editfns.c (time_overflow): New function, refactoring common code.
4050 (Fformat_time_string, Fdecode_time, Fencode_time):
4051 (Fcurrent_time_string): Use it.
4052
8be6f318
PE
4053 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4054 * dired.c (make_time): Move to ...
4055 * editfns.c (make_time): ... here.
4056 * systime.h: Note the move.
4057
09d9db2c 40582011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4059
126bc0dc
YM
4060 * fringe.c (update_window_fringes): Remove unused variables.
4061
c47cbdfd
YM
4062 * unexmacosx.c (copy_data_segment): Also copy __got section.
4063 (Bug#8223)
4064
7ac80be9
EZ
40652011-03-12 Eli Zaretskii <eliz@gnu.org>
4066
c96bbc66 4067 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4068 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4069 Constify `char *' arguments and their references according to
4070 prototypes in tparam.h.
4071
ecb0f94d 4072 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4073
7ac80be9
EZ
4074 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4075 Adapt all references accordingly.
4076
4077 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4078
ef1fd07e
TT
40792011-03-11 Tom Tromey <tromey@redhat.com>
4080
4081 * buffer.c (syms_of_buffer): Remove obsolete comment.
4082
7ef4b50c
EZ
40832011-03-11 Eli Zaretskii <eliz@gnu.org>
4084
4085 * termhooks.h (encode_terminal_code): Declare prototype.
4086
4087 * msdos.c (encode_terminal_code): Don't declare prototype.
4088
4089 * term.c (encode_terminal_code): Now external again, used by
4090 w32console.c and msdos.c.
4091
44f230aa
SM
4092 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4093 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4094
4b1ec863 40952011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4096
1714f52b 4097 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4098
4b1ec863
PE
4099 * fringe.c (update_window_fringes): Mark locals as initialized
4100 (Bug#8227).
4101 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4102
524c7aa6
PE
4103 * alloc.c (mark_fringe_data): Move decl from here ...
4104 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4105 to check its interface.
4106 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4107
a5c0af81 4108 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4109 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4110 (fontset_font): Mark local as initialized.
a9a06e0b 4111 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4112
b4716021
PE
4113 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4114
811e9bac 4115 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4116 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4117 (x_own_selection, Fx_disown_selection_internal): Rename locals
4118 to avoid shadowing.
4119 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4120
7e3ab302
PE
4121 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4122 so that the caller can use some name other than gcpro1.
4123 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4124 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4125 (Fx_backspace_delete_keys_p):
4126 Use them to avoid shadowing, and rename vars to avoid shadowing.
4127 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4128 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4129 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4130 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4131 Remove unused locals.
7e3ab302
PE
4132 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4133 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4134 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4135 macros.
f78faa98 4136
e2b13473
PE
4137 * xterm.h (x_mouse_leave): New decl.
4138
77f23912
PE
4139 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4140 Remove unused functions.
cdf4ba58
PE
4141 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4142 (x_calc_absolute_position): Now static.
7411c686 4143 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4144 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4145 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4146 unless they are used.
38d0b34a
PE
4147 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4148 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4149 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4150 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4151 (x_error_catcher, x_connection_closed, x_error_handler):
4152 (x_error_quitter, xembed_send_message, x_iconify_frame):
4153 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4154 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4155 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4156
44f230aa
SM
4157 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4158 Rename or move locals to avoid shadowing.
6b463e58 4159 (tty_defined_color, merge_face_heights): Now static.
5967d051 4160 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4161 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4162 does not deduce is never used uninitialized.
73719eba
PE
4163 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4164 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4165
426994c3 4166 * terminal.c (store_terminal_param): Now static.
5489860b 4167
032f1620 4168 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4169 (set_frame_menubar): Remove unused local.
d4323972 4170 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4171 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4172 since they might point to immutable storage.
281585b0
PE
4173 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4174 since it's unused otherwise.
032f1620 4175
367c19e5 4176 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4177 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4178 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4179 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4180 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4181 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4182 does not deduce are never used uninitialized.
70739cbe 4183
07b48fa9
PE
4184 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4185
8868a238 4186 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4187 * window.c (window_loop, size_window):
4188 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4189
7e5cf297 4190 * window.c (display_buffer): Now static.
d6550a9f
PE
4191 (size_window): Mark variables that gcc -Wuninitialized
4192 does not deduce are never used uninitialized.
a586633d
PE
4193 * window.h (check_all_windows): New decl, to forestall
4194 gcc -Wmissing-prototypes diagnostic.
5b555da1 4195 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4196
f6095868
PE
4197 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4198 shadowing.
4199 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4200 Include <limits.h>.
4201 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4202 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4203 (load_charset_map): Mark variables that gcc -Wuninitialized
4204 does not deduce are never used uninitialized.
53df7c11 4205 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4206
f38b440c
PE
4207 * coding.c (coding_set_source, coding_set_destination):
4208 Use "else { /* comment */ }" rather than "else /* comment */;"
4209 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4210 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4211 a block, when the outer 'i' will do.
4212 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4213 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4214 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4215 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4216 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4217 Rename locals to avoid shadowing.
4218 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4219 * coding.c (emacs_mule_char, encode_invocation_designation):
4220 Now static, since they're not used elsewhere.
413bb2db 4221 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4222 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4223 (decode_coding_emacs_mule): Mark variables that gcc
4224 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4225 (detect_coding_iso_2022): Initialize a local variable that might
4226 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4227 this initialization is needed. (Bug#8211)
5f58e762
PE
4228 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4229 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4230 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4231 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4232 Remove unused macros.
f38b440c 4233
232b38b9 4234 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4235 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4236 * character.c (string_count_byte8): Likewise.
232b38b9 4237
fb90da1b
PE
4238 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4239 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4240
fb93dbc2
PE
4241 * chartab.c (copy_sub_char_table): Now static, since it's not used
4242 elsewhere.
5c156ace
PE
4243 (sub_char_table_ref_and_range, char_table_ref_and_range):
4244 Rename locals to avoid shadowing.
bbcd0949 4245 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4246
7d3b3862 4247 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4248 (BIDI_BOB): Remove unused macro.
7d3b3862 4249
6be7d3da
PE
4250 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4251 deduce are never used uninitialized.
c2ed9c8b 4252 * term.c (encode_terminal_code): Likewise.
6be7d3da 4253
75f8807f 4254 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4255
50938595
PE
4256 * tparam.h: New file.
4257 * term.c, tparam.h: Include it.
4258 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4259 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4260 Move these decls to tparam.h, and make them agree with what
4261 is actually in tparam.c. The previous trick of using incompatible
4262 decls in different modules does not conform to the C standard.
4263 All callers of tparam changed to use tparam's actual API.
4264 * tparam.c (tparam1, tparam, tgoto):
4265 Use const pointers where appropriate.
4266
fbceeba2
PE
4267 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4268 * cm.h (struct cm): Likewise.
4269 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4270 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4271 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4272 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4273 (turn_on_face, init_tty): Likewise.
4274 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4275
7f3f1250
PE
4276 * term.c (term_mouse_position): Rename local to avoid shadowing.
4277
e6ca6543
PE
4278 * alloc.c (mark_ttys): Move decl from here ...
4279 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4280
c40f8d15
AS
42812011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4282
4283 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4284
cfe0661d
JB
42852011-03-09 Juanma Barranquero <lekktu@gmail.com>
4286
4287 * search.c (compile_pattern_1): Remove argument regp, unused since
4288 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4289 (compile_pattern): Don't pass it.
4290
0afb4571
J
42912011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4292
4293 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4294 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4295 for ! HAVE_GTK3.
4296 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4297
4298 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4299
4300 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4301 gdk_window_get_screen, gdk_window_get_geometry,
4302 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4303 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4304 (xg_get_pixbuf_from_pixmap): New function.
4305 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4306 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4307 Call xg_get_pixbuf_from_pixmap instead of
4308 gdk_pixbuf_get_from_drawable.
4309 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4310 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4311 (xg_check_special_colors): Use GtkStyleContext and its functions
4312 for HAVE_GTK3.
4313 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4314 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4315 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4316 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4317 Call gtk_widget_get_preferred_size.
0afb4571
J
4318 (xg_frame_resized): gdk_window_get_geometry only takes 5
4319 parameters.
44f230aa
SM
4320 (xg_win_to_widget, xg_event_is_for_menubar):
4321 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4322 (xg_set_widget_bg): New function.
4323 (delete_cb): New function.
895009e1 4324 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4325 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4326 (xg_set_background_color): Call xg_set_widget_bg.
4327 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4328 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4329 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4330 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4331 if ! HAVE_GTK3.
4332 (update_frame_tool_bar): Call gtk_widget_hide.
4333 (xg_initialize): Use GDK_KEY_g.
4334
4335 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4336 if ! HAVE_GTK3
4337 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4338
4339 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4340 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4341 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4342
1c2cc4ef
JB
43432011-03-08 Juanma Barranquero <lekktu@gmail.com>
4344
4345 * w32xfns.c (select_palette): Check success of RealizePalette against
4346 GDI_ERROR, not zero.
4347
33383987 4348See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4349
4350;; Local Variables:
4351;; coding: utf-8
aac0c6e3
MR
4352;; End:
4353
33383987 4354 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4355
4356 This file is part of GNU Emacs.
4357
4358 GNU Emacs is free software: you can redistribute it and/or modify
4359 it under the terms of the GNU General Public License as published by
4360 the Free Software Foundation, either version 3 of the License, or
4361 (at your option) any later version.
4362
4363 GNU Emacs is distributed in the hope that it will be useful,
4364 but WITHOUT ANY WARRANTY; without even the implied warranty of
4365 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4366 GNU General Public License for more details.
4367
4368 You should have received a copy of the GNU General Public License
4369 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.