* editfns.c (region_limit): Simplify by using clip_to_bounds.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f520ef9b
PE
12012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2
3 * editfns.c (region_limit): Simplify by using clip_to_bounds.
4
383b7c95
JD
52012-07-05 Jan Djärv <jan.h.d@swipnet.se>
6
7 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
8 not defined (Bug#11768).
9 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
10 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
11 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
12 followed by gtk_box_set_homogeneous (Bug#11768).
13 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
14 (update_theme_scrollbar_width, xg_create_scroll_bar): Use
15 gtk_scrollbar_new (Bug#11768).
16 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
17 (is_box_type): New function (Bug#11768).
18 (xg_tool_item_stale_p): Call is_box_type.
19 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
20 with default display (Bug#11768).
21
d6e7bf45
EZ
222012-07-05 Eli Zaretskii <eliz@gnu.org>
23
24 * xdisp.c (window_hscroll_limited): New function.
25 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
26 coordinates when window's hscroll is set to insanely large
27 values. (Bug#11857)
28
431391ec
JB
292012-07-05 Juanma Barranquero <lekktu@gmail.com>
30
31 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
32 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
33
23f86fce
DA
342012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
35
36 Cleanup xmalloc.
37 * lisp.h (xzalloc): New prototype. Omit needless casts.
38 * alloc.c (xzalloc): New function. Omit needless casts.
39 * charset.c: Omit needless casts. Convert all calls to
40 xmalloc with following memset to xzalloc.
41 * dispnew.c: Likewise.
42 * fringe.c: Likewise.
43 * image.c: Likewise.
44 * sound.c: Likewise.
45 * term.c: Likewise.
46 * w32fns.c: Likewise.
47 * w32font.c: Likewise.
48 * w32term.c: Likewise.
49 * xfaces.c: Likewise.
50 * xfns.c: Likewise.
51 * xterm.c: Likewise.
52 * atimer.c: Omit needless casts.
53 * buffer.c: Likewise.
54 * callproc.c: Likewise.
55 * ccl.c: Likewise.
56 * coding.c: Likewise.
57 * composite.c: Likewise.
58 * doc.c: Likewise.
59 * doprnt.c: Likewise.
60 * editfns.c: Likewise.
61 * emacs.c: Likewise.
62 * eval.c: Likewise.
63 * filelock.c: Likewise.
64 * fns.c: Likewise.
65 * gtkutil.c: Likewise.
66 * keyboard.c: Likewise.
67 * lisp.h: Likewise.
68 * lread.c: Likewise.
69 * minibuf.c: Likewise.
70 * msdos.c: Likewise.
71 * print.c: Likewise.
72 * process.c: Likewise.
73 * region-cache.c: Likewise.
74 * search.c: Likewise.
75 * sysdep.c: Likewise.
76 * termcap.c: Likewise.
77 * terminal.c: Likewise.
78 * tparam.c: Likewise.
79 * w16select.c: Likewise.
80 * w32.c: Likewise.
81 * w32reg.c: Likewise.
82 * w32select.c: Likewise.
83 * w32uniscribe.c: Likewise.
84 * widget.c: Likewise.
85 * xdisp.c: Likewise.
86 * xmenu.c: Likewise.
87 * xrdb.c: Likewise.
88 * xselect.c: Likewise.
89
0497dc44
PE
902012-07-05 Paul Eggert <eggert@cs.ucla.edu>
91
92 * fileio.c (time_error_value): Check the right error number.
93 Problem reported by Troels Nielsen in
94 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
95
356e7178
PE
962012-07-04 Paul Eggert <eggert@cs.ucla.edu>
97
4e71fd89
PE
98 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
99 This should be fixed in a better way; see Eli Zaretskii in
100 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
101 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
102
f0941253
PE
103 * fileio.c (time_error_value): Rename from special_mtime.
104 The old name's problems were noted by Eli Zaretskii in
105 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
106
065c9eb4
PE
107 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
108 This variable's comment says Emacs needs at least one GDB-visible
109 symbol of type enum pvec_type, to work around GDB problems.
110 The symbol's value doesn't matter.
111
356e7178
PE
112 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
113 that causes compilation to fail on pre-C99 compilers.
114
95f61aa2
JB
1152012-07-04 Juanma Barranquero <lekktu@gmail.com>
116
117 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
118 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
119
3884d954
DA
1202012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
121
d209e2fb 122 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
123 headers for buffer_defaults and buffer_local_symbols.
124 Reported by Juanma Barranquero <lekktu@gmail.com>.
125
ee28be33
SM
1262012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
127
128 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
129 * lisp.h (enum pvec_type): Use fewer bits.
130 (PSEUDOVECTOR_SIZE_BITS): New constant.
131 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
132 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
133 change in pvec_type.
134 (PSEUDOVECTOR_TYPEP): New macro.
135 (TYPED_PSEUDOVECTORP): Use it.
136 * fns.c (internal_equal): Adapt code to extract pvectype.
137 * emacs.c (gdb_pvec_type): Update type.
138 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
139 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
140 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
141 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
142 (sweep_vectors): Use it. Use local var `total_bytes' instead of
143 abusing vector->header.next.nbytes.
144 (live_vector_p): Use PVEC_TYPE.
145 (mark_object): Adapt code to extract pvectype. Use switch.
146
c7f2cd7f
PE
1472012-07-04 Paul Eggert <eggert@cs.ucla.edu>
148
149 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
150 Tighten new eassert a bit.
151
8ce70ed2
DA
1522012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
153
154 Fix compilation with --enable-gcc-warnings and -O1
155 optimization level.
156 * doprnt.c (doprnt): Change type of tem to int, initialize
157 to avoid compiler warning. Add eassert.
158 * search.c (simple_search): Initialize match_byte to avoid
159 compiler warning. Add eassert.
160
dea7f1e5
PE
1612012-07-04 Paul Eggert <eggert@cs.ucla.edu>
162
24a212eb
PE
163 Avoid weird behavior with large horizontal scrolls.
164 Without this change, for example, large hscroll values would
165 mess up Emacs's display on Fedora 15 x86, presumably due to
166 overflows in int calculations in the display code.
167 Also, if buffers had long lines, Emacs would freeze.
168 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
169 (set_window_hscroll): New function, containing the old guts of
170 Fset_window_hscroll. Return the clipped value.
171 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
172 This avoids the need to check against PTRDIFF_MAX.
173
dea7f1e5
PE
174 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
175
76046526
DA
1762012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
177
178 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
179
39adff0d
PE
1802012-07-04 Paul Eggert <eggert@cs.ucla.edu>
181
63807d47
PE
182 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
183 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
184 since GCC 4.4.6 issues a bogus warning for them.
185
39adff0d
PE
186 Fix bugs in file timestamp newness comparisons.
187 * fileio.c (Ffile_newer_than_file_p):
188 * lread.c (Fload): Use full timestamp resolution of files,
189 not just the 1-second resolution, so that files that are only
190 slightly newer still count as newer.
191 * fileio.c (Ffile_newer_than_file_p): Don't assume file
192 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
193
dbeed9a6
PE
1942012-07-03 Paul Eggert <eggert@cs.ucla.edu>
195
196 * fileio.c: Improve handling of file time marker. (Bug#11852)
197 (special_mtime): New function.
198 (Finsert_file_contents, Fverify_visited_file_modtime):
199 Use it to set special mtime values consistently.
200
636334d6
AS
2012012-07-03 Andreas Schwab <schwab@linux-m68k.org>
202
203 * fileio.c (Finsert_file_contents): Properly handle st_mtime
204 marker for non-existing file. (Bug#11852)
205
e2017fe2
GM
2062012-07-03 Glenn Morris <rgm@gnu.org>
207
208 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
209 and did not make it into globals.h).
210
404dbd37
TT
2112012-07-03 Tom Tromey <tromey@redhat.com>
212
213 * window.c (Fset_window_margins, Fset_window_fringes)
214 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
215 * textprop.c (Fprevious_property_change): No longer static.
216 * syntax.c (Fsyntax_table_p): No longer static.
217 * process.c (Fget_process, Fprocess_datagram_address): No longer
218 static.
219 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
220 * keyboard.c (Fcommand_execute): No longer static.
221 Remove EXFUN.
222 * insdel.c (Fcombine_after_change_execute): No longer static.
223 * image.c (Finit_image_library): No longer static.
224 * fileio.c (Fmake_symbolic_link): No longer static.
225 * eval.c (Ffetch_bytecode): No longer static.
226 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
227 * doc.c (Fdocumentation_property, Fsnarf_documentation):
228 No longer static.
404dbd37
TT
229 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
230 static.
231 * dired.c (Ffile_attributes): No longer static.
232 * composite.c (Fcomposition_get_gstring): No longer static.
233 * callproc.c (Fgetenv_internal): No longer static.
234
235 * ccl.h: Remove EXFUNs.
236 * buffer.h: Remove EXFUNs.
237 * dispextern.h: Remove EXFUNs.
238 * intervals.h: Remove EXFUNs.
239 * fontset.h: Remove EXFUN.
240 * font.h: Remove EXFUNs.
241 * dosfns.c (system_process_attributes): Remove EXFUN.
242 * keymap.h: Remove EXFUNs.
243 * lisp.h: Remove EXFUNs.
244 * w32term.h: Remove EXFUNs.
245 * window.h: Remove EXFUNs.
246 * xsettings.h: Remove EXFUN.
247 * xterm.h: Remove EXFUN.
248
8e4fd1e1
GM
2492012-07-03 Glenn Morris <rgm@gnu.org>
250
251 * lisp.h (Frandom): Make it visible to C.
252 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
253 buffer for invisible buffers. (Bug#1229)
254
ca95b3eb
DA
2552012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
256
257 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
258 values which aren't power of 2.
259 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
260 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
261 accordingly.
262
7555c33f
SM
2632012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
264
265 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
266
267 * alloc.c (mark_object): Revert part of last patch to use `switch'.
268
d12e8f5a
DA
2692012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
270
271 * alloc.c (allocate_vector_block): Remove redundant
272 calls to mallopt if DOUG_LEA_MALLOC is defined.
273 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
274 avoid calls to mallopt if zero_vector is returned.
275
296094c3
DA
2762012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
277
278 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
279 is enabled, avoid dereferencing NULL current_sblock if
280 running undumped.
281
36429c89
DA
2822012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
283
284 Cleanup basic buffer management.
285 * buffer.h (struct buffer): Change layout to use generic vector
286 marking code. Fix some comments. Change type of 'clip_changed'
287 to bitfield. Remove unused #ifndef old.
288 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
289 (GET_OVERLAYS_AT): Fix indentation.
290 (for_each_per_buffer_object_at): New macro.
291 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
292 (Fbuffer_local_variables): Use it.
293 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
294 * alloc.c (allocate_buffer): Adjust to match new layout of
295 struct buffer. Fix comment.
296 (mark_overlay): New function.
297 (mark_buffer): Use it. Use mark_vectorlike to mark normal
298 Lisp area of struct buffer.
299 (mark_object): Use it. Adjust marking of misc objects
300 and related comments.
301
3b3e4cac
PE
3022012-07-02 Paul Eggert <eggert@cs.ucla.edu>
303
304 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
305 wrapper that is not needed because the wrapped code is a no-op (zero
306 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
307 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
308
cf5c0175
DA
3092012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
310
311 * alloc.c (mark_buffer): Simplify. Remove prototype.
312 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 313 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
314 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
315 redundant calls to mark_vectorlike for bool vectors.
316
ca26824c
GM
3172012-06-30 Glenn Morris <rgm@gnu.org>
318
2e4c5312
GM
319 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
320
ca26824c
GM
321 * epaths.in (PATH_SITELOADSEARCH): New.
322 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
323 This is rather than relying on --enable-locallisppath elements
324 having "site-lisp" in their names. (Bug#10208#25, 11658)
325
0d23c240
EZ
3262012-06-30 Eli Zaretskii <eliz@gnu.org>
327
c9240d7a
EZ
328 * w32proc.c (sys_select): Accept and ignore one more argument.
329
330 * w32.c (emacs_gnutls_pull): Call select with one more argument.
331
0d23c240 332 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 333 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
334
335 * sysdep.c: Don't include dos.h and dosfns.h.
336
337 * process.c (sys_select):
338 * msdos.c (sys_select): Accept one more argument and ignore it.
339
340 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
341 adapt data types and code to that.
342
343 * dosfns.c:
344 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
345 which clashes with the gnulib function of the same name.
346
af5a5a98
AS
3472012-06-30 Andreas Schwab <schwab@linux-m68k.org>
348
c5e4379c
AS
349 * font.c (font_style_to_value, font_style_symbolic)
350 (font_prop_validate_style): Add type checks for values in
351 font_style_table.
352
af5a5a98
AS
353 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
354 argument.
355 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
356 uses.
357
8d38f461
EZ
3582012-06-29 Eli Zaretskii <eliz@gnu.org>
359
2e5a6631
EZ
360 * xdisp.c (try_window_id): Undo last change.
361
8d38f461
EZ
362 * w32.c (getwd): Adjust commentary about startup_dir.
363 (init_environment): Always call sys_access, even in non-MSVC
364 builds. Don't chdir to the directory of the Emacs executable.
365 This undoes code from 1997 which was justified by the need to
366 "avoid conflicts when removing and renaming directories". But its
367 downside was that every relative file name was being interpreted
368 relative to the directory of the Emacs executable, which can never
369 be TRT. In particular, it broke sys_access when called with
370 relative file names.
371 (sys_access): Map GetLastError to errno.
372
2af3565e
DA
3732012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
374
375 * window.h (struct window): Change type of 'fringes_outside_margins'
376 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 377 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
378 Adjust comment.
379 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
380 to ptrdiff_t.
381
c8d3a25c 3822012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 383
c8d3a25c
GM
384 * gnutls.c (emacs_gnutls_handshake):
385 Add QUIT to make the loop interruptible.
57570cd3 386
c8d3a25c 3872012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 388
c8d3a25c
GM
389 * charset.c (init_charset): Make lack of etc/charsets fatal.
390
3e984ee8
DA
3912012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
392
393 * editfns.c (region_limit): Fix type mismatch.
394
ef884f23
DA
3952012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
396
397 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
398 undefined. Convert from xassert to eassert.
399 * nsmenu.m: Convert from xassert to eassert.
400 * nsterm.m: Likewise.
401
7d7e0027
SM
4022012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
403
404 * editfns.c (region_limit): Clip to narrowing (bug#11770).
405
aa754e6a
PE
4062012-06-28 Paul Eggert <eggert@cs.ucla.edu>
407
408 Avoid integer overflow on scroll-left and scroll-right.
409 * window.c (HSCROLL_MAX): New macro.
410 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
411 overflow when requested scroll falls outside ptrdiff_t range.
412
80b00b08
DA
4132012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
414
415 * window.h (struct window): Change type of 'hscroll',
416 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
417 'last_modified' and 'last_overlay_modified' to EMACS_INT.
418 Adjust users accordingly.
419 * xdisp.c (try_cursor_movement): Replace type check with eassert.
420 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
421 from EMACS_INT to ptrdiff_t.
422 (make_window): Omit redundant initialization.
423
62b2bcf6
JB
4242012-06-28 Juanma Barranquero <lekktu@gmail.com>
425
426 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
427
45942c7d
DA
4282012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
429
430 * window.h (struct window): Change type of 'use_time' and
431 'sequence_number' from Lisp_Object to int.
432 * frame.c (make_frame): Adjust users accordingly.
433 * print.c (print_object): Likewise.
434 * window.c (select_window, Fwindow_use_time, make_parent_window)
435 (make_window): Likewise.
436
e509cfa6
DA
4372012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
438
439 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
440 enabled with --enable-checking=[all,glyphs] configure option.
441 Fix GLYPH_DEBUG usage assuming that it may be undefined,
442 adjust comments accordingly.
443 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
444 undefined, adjust comments accordingly.
445 * image.c: Likewise.
446 * scroll.c: Likewise.
447 * w32fns.c: Likewise.
448 * w32term.c: Likewise.
449 * xdisp.c: Likewise.
450 * xfaces.c: Likewise.
451 * xfns.c: Likewise.
452 * xterm.c: Likewise.
453
a54e2c05
DA
4542012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
455
456 Generalize run-time debugging checks.
457 * dispextern.h (XASSERTS): Remove.
458 * fontset.c (xassert): Remove.
459 Convert from xassert to eassert.
460 * alloc.c: Convert from xassert to eassert.
461 * bidi.c: Likewise.
462 * dispnew.c: Likewise.
463 * fns.c: Likewise.
464 * fringe.c: Likewise.
465 * ftfont.c: Likewise.
466 * gtkutil.c: Likewise.
467 * image.c: Likewise.
468 * keyboard.c: Likewise.
469 * menu.c: Likewise.
470 * process.c: Likewise.
471 * scroll.c: Likewise.
472 * sound.c: Likewise.
473 * term.c: Likewise.
474 * w32console.c: Likewise.
475 * w32fns.c: Likewise.
476 * w32term.c: Likewise.
477 * window.c: Likewise.
478 * xdisp.c: Likewise.
479 * xfaces.c: Likewise.
480 * xfns.c: Likewise.
481 * xselect.c: Likewise.
482 * xterm.c: Likewise.
483
1ec4b7b2
SM
4842012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
485
486 * fns.c (maybe_resize_hash_table): Output message when growing the
487 purify-hashtable.
488
2014308a
DA
4892012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
490
491 * alloc.c (allocate_string_data): Remove dead code.
492 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
493 avoid GCC warning about unused macro.
494
246155eb
DA
4952012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
496
497 * alloc.c (allocate_string): Omit intervals initialization.
498 * alloc.c (make_uninit_multibyte_string): Initialize intervals
499 as in make_pure_string and make_pure_c_string.
500
43184b7b
DA
5012012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
502
d209e2fb 503 * alloc.c (allocate_string): Fix last change.
43184b7b 504
3fe6dd74
DA
5052012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
506
d209e2fb 507 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
508 to memset, add explicit initialization where appropriate.
509
1ba6038a
GM
5102012-06-27 Glenn Morris <rgm@gnu.org>
511
512 * lisp.mk (lisp): Remove paths.elc.
513
c89926a5
CY
5142012-06-27 Chong Yidong <cyd@gnu.org>
515
516 * doc.c (Fsubstitute_command_keys): Fix punctuation.
517
ed6b3510
JW
5182012-06-26 John Wiegley <johnw@newartisans.com>
519
1ec4b7b2 520 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
521 on Mac OS X Lion: __mod_init_func and __mod_term_func.
522
ed6b3510
JW
523 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
524 when building with Clang.
525
8edd4a2b
SM
5262012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
527
528 * eval.c (Fapply): Allow calling it with a single argument.
529
f6f62d1b
EZ
5302012-06-26 Eli Zaretskii <eliz@gnu.org>
531
532 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
533 _stricmp and _strnicmp.
534 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
535
62efea5e
DA
5362012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
537
538 * alloc.c (allocate_window): Zero out non-Lisp part of newly
539 allocated window.
540 (allocate_process): Likewise for new process.
8edd4a2b 541 (allocate_terminal): Change to use offsetof.
62efea5e
DA
542 (allocate_frame): Likewise.
543 * frame.c (make_frame): Omit redundant initialization.
544 * window.c (make_parent_window): Use memset.
545 (make_window): Omit redundant initialization.
546 * process.c (make_process): Omit redundant initialization.
547 * terminal.c (create_terminal): Likewise.
548
42997f4d
DA
5492012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
550
551 * term.c (delete_tty): Remove redundant call to memset.
552
1130ecfc
DA
5532012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
554
555 * alloc.c: Remove build_string.
556 * lisp.h: Define build_string as static inline. This provides
557 a better opportunity to optimize away calls to strlen when the
558 function is called with compile-time constant argument.
559 * image.c (imagemagick_error): Convert to build_string.
560 * w32proc.c (sys_spawnve): Likewise.
561 * xterm.c (x_term_init): Likewise.
562
cf38a720
PE
5632012-06-26 Paul Eggert <eggert@cs.ucla.edu>
564
99027bdd
PE
565 Use sprintf return value instead of invoking strlen on result.
566 In the old days this wasn't portable, since some sprintf
567 implementations returned char *. But they died out years ago and
568 Emacs already assumes sprintf returns int.
569 Similarly for float_to_string.
570 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
571 * ccl.c (ccl_driver):
572 * character.c (string_escape_byte8):
573 * data.c (Fnumber_to_string):
574 * doprnt.c (doprnt):
575 * print.c (print_object):
576 * xdisp.c (message_dolog):
577 * xfns.c (syms_of_xfns):
578 Use sprintf or float_to_string result to avoid need to call strlen.
579 * data.c (Fnumber_to_string):
580 Use make_unibyte_string, since the string must be ASCII.
581 * lisp.h, print.c (float_to_string): Now returns int length.
582 * term.c (produce_glyphless_glyph):
583 Use sprintf result rather than recomputing it.
584
cf38a720
PE
585 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
586 * Makefile.in (ALL_CFLAGS):
587 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
588 * gmalloc.c, regex.c: Include <config.h> unconditionally.
589
3511c784
DA
5902012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
591
0a08eb21 592 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
593 strcasecmp if available.
594 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
595
fb7da12e
AS
5962012-06-25 Andreas Schwab <schwab@linux-m68k.org>
597
598 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
599 Avoid comma operator.
600 * menu.c (push_submenu_start, push_submenu_end)
601 (push_left_right_boundary, push_menu_pane): Likewise.
602 * msdos.c (dos_rawgetc): Likewise.
603
afa2ffd8
DA
6042012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
605
606 * xfns.c (xic_create_fontsetname): Remove redundant calls
607 to memset.
608
b3b4476b
PE
6092012-06-25 Paul Eggert <eggert@cs.ucla.edu>
610
4495ff38
PE
611 * gtkutil.c (get_utf8_string): Remove redundant assignment.
612 sprintf already null-terminates its output.
613
b3b4476b
PE
614 * xfns.c (x_window): Remove redundant cast.
615
b00876c9
DA
6162012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
617
618 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
619 `const char *' to `char *' to avoid compiler warning.
620
d188e26b
PE
6212012-06-24 Paul Eggert <eggert@cs.ucla.edu>
622
885d1d74
PE
623 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
624 instead of truncating it to 63 (admittedly a generous limit).
625
d188e26b
PE
626 * process.c: Fix spelling and caps in comments.
627
e2f560b1
DN
6282012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
629
e86db54b 630 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
631 * sysdep.c (setpgrp): Remove definition, not used in this file.
632
7583a3a1
JB
6332012-06-24 Juanma Barranquero <lekktu@gmail.com>
634
635 * makefile.w32-in: Update dependencies.
636
696056c2
EZ
6372012-06-24 Eli Zaretskii <eliz@gnu.org>
638
639 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
640 (SYSTIME_H): Add nt/inc/sys/time.h.
641
642 * systime.h [WINDOWSNT]: Include sys/time.h.
643
644 * s/ms-w32.h (struct timespec): Definition moved from
645 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
646
845ca893
PE
6472012-06-24 Paul Eggert <eggert@cs.ucla.edu>
648
649 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
650 * buffer.h (buffer_slot_type_mismatch):
651 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
652 * eval.c (unwind_to_catch):
653 * image.c (my_png_error, my_error_exit):
654 * keyboard.c (quit_throw_to_read_char, user_error)
655 (Fexit_recursive_edit, Fabort_recursive_edit):
656 * lisp.h (die, args_out_of_range, args_out_of_range_3)
657 (wrong_type_argument, buffer_overflow, __executable_start)
658 (memory_full, buffer_memory_full, string_overflow, Fthrow)
659 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
660 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
661 (fatal):
662 (child_setup) [!DOS_NT]:
663 * lread.c (end_of_file_error, invalid_syntax):
664 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
665 * puresize.h (pure_write_error):
666 * search.c (matcher_overflow):
667 * sound.c (sound_perror, alsa_sound_perror):
668 * sysdep.c, syssignal.h (croak):
669 * term.c (maybe_fatal, vfatal):
670 * textprop.c (text_read_only):
671 * undo.c (user_error):
672 * unexmacosx.c (unexec_error):
673 * xterm.c (x_ins_del_lines, x_delete_glyphs):
674 Use _Noreturn rather than NO_RETURN.
675 No need for separate decl merely because of _Noreturn.
676 * sound.c (sound_warning, parse_sound):
677 Remove unnecessary forward decls.
678
f1dd8073
PE
6792012-06-24 Paul Eggert <eggert@cs.ucla.edu>
680
681 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
682 * lisp.h (WAIT_READING_MAX): New macro.
683 * dispnew.c (Fsleep_for, sit_for):
684 * keyboard.c (kbd_buffer_get_event):
685 * process.c (Faccept_process_output):
686 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
687 This improves on the previous patch, which introduced a bug
688 when time_t is unsigned and as wide as intmax_t.
689 See <http://bugs.gnu.org/9000#51>.
690
b82c1755
EZ
6912012-06-23 Eli Zaretskii <eliz@gnu.org>
692
693 * dispnew.c (sit_for, Fsleep_for):
694 * keyboard.c (kbd_buffer_get_event):
695 * process.c (Faccept_process_output): Avoid compiler warnings when
696 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
697
ca300656
JB
6982012-06-23 Juanma Barranquero <lekktu@gmail.com>
699
049ec95b
JB
700 * makefile.w32-in: Update dependencies.
701
ca300656
JB
702 * w32.c (ltime): Add return type and declare static.
703 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
704
db7b8d06
PE
7052012-06-23 Paul Eggert <eggert@cs.ucla.edu>
706
707 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
708 Privately reported by Herbert J. Skuhra.
709 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
710 All uses changed.
711 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
712 not make_lisp_timeval, when the argument is of type EMACS_TIME.
713
0bd8297f
EZ
7142012-06-23 Eli Zaretskii <eliz@gnu.org>
715
96512555
EZ
716 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
717 last argument of make_unibyte_string.
718
0bd8297f
EZ
719 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
720 language ID in the event parameters.
721
722 * w32term.c (w32_read_socket): Put the new keyboard codepage into
723 event.code, not the obscure "character set ID".
724
63def6b6
CY
7252012-06-23 Chong Yidong <cyd@gnu.org>
726
727 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
728
e8a02204
EZ
7292012-06-23 Eli Zaretskii <eliz@gnu.org>
730
388cdec0
EZ
731 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
732 * w32.c (fdutimens): New function.
733
734 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
735
736 * s/ms-w32.h (pselect): Redirect to sys_select.
737
738 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
739
e8a02204
EZ
740 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
741 in the logic of incrementing and decrementing the value of
742 use_relocatable_buffers.
743
d054f3fb
PE
7442012-06-23 Paul Eggert <eggert@cs.ucla.edu>
745
746 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
747 Privately reported by Herbert J. Skuhra.
748 [__FreeBSD__]: Remove "*/" typo after "#include".
749 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
750 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
751 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
752 Don't assume EMACS_TIME and struct timeval are the same type.
753
d35af63c
PE
7542012-06-22 Paul Eggert <eggert@cs.ucla.edu>
755
756 Support higher-resolution time stamps (Bug#9000).
757 The time stamps are only nanosecond-resolution at the C level,
758 since that's the best that any real-world system supports now.
759 But they are picosecond-resolution at the Lisp level, as that's
760 easy, and leaves room for future OS improvements.
761
762 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
763 (LIBES): Use it.
764
765 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
766 Don't get current time unless it's needed.
767
768 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
769 now provides it if it's absent.
770 (start_atimer): Port to higher-res time stamps.
771 Check for time stamp overflow. Don't get current time more
772 often than is needed.
773
774 * buffer.h (struct buffer): Buffer modtime now has high resolution.
775 Include systime.h, not time.h.
776 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
777
778 * dired.c: Include stat-time.h.
779 (Ffile-attributes): File times now have higher resolution.
780
781 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
782 (struct image): Timestamp now has higher resolution.
783
784 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
785 has at least microseconds now. All uses removed.
786 (update_frame, update_single_window, update_window, update_frame_1)
787 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
788
789 * editfns.c (time_overflow): Now extern.
790 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
791 (float-time, Fformat_time_string, Fcurrent_time_string)
792 (Fcurrent_time_zone): Accept and generate higher-resolution
793 time stamps.
794 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
795 (decode_time_components, lisp_seconds_argument): New functions.
796 (make_time): Now static.
797 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
798 Report an error if the time is invalid, rather than having the caller
799 do that.
800
801 * fileio.c: Include <stat-time.h>
802 (Fcopy_file): Copy higher-resolution time stamps.
803 Prefer to set the time stamp via a file descriptor if that works.
804 (Fset_file_times, Finsert_file_contents, Fwrite_region)
805 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
806 (Fvisited_file_modtime, Fset_visited_file_modtime):
807 Support higher-resolution time stamps.
808
809 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
810
811 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
812
813 * image.c (prepare_image_for_display, clear_image_cache)
814 (lookup_image): Port to higer-resolution time stamps.
815
816 * keyboard.c (start_polling, bind_polling_period):
817 Check for time stamp overflow.
818 (read_char, kbd_buffer_get_event, timer_start_idle)
819 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
820 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
821 Port to higher-resolution time stamps. Do not assume time_t is signed.
822 (decode_timer): New function. Timers are now vectors of length 9,
823 not 8, to accommodate the picosecond component.
824 (timer_check_2): Use it.
825
826 * nsterm.m (select_timeout, timeval_subtract): Remove.
827 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
828 as they're a bit more accurate and handle overflow better.
829 (ns_select): Change prototype to be compatible with pselect.
830 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
831 * nsterm.h (ns_select): Adjust prototype.
832
833 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
834 us-resolution time stamps.
835 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
836
837 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
838
839 * lisp.h (time_overflow): New decl.
840 (wait_reading_process_output): First arg is now intmax_t, not int,
841 to accommodate larger waits.
842
843 * process.h (struct Lisp_Process.read_output_delay):
844 Now counts nanoseconds, not microseconds.
845 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
846 EMACS_HAS_USECS.
847 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
848 (wait_reading_process_output):
849 Port to ns-resolution time stamps.
850 (Faccept_process_output, wait_reading_process_output):
851 Check for time stamp overflow. Do not assume time_t is signed.
852 (select_wrapper): Remove; we now use pselect.
853 (Fprocess_attributes): Now generates ns-resolution time stamps.
854
855 * sysdep.c: Include utimens.h. Don't include utime.h
856 or worry about struct utimbuf; gnulib does that for us now.
857 (gettimeofday): Remove; gnulib provides a substitute.
858 (make_timeval): New function.
859 (set_file_times): Now sets ns-resolution time stamps.
860 New arg FD; all uses changed.
861 (time_from_jiffies, ltime_from_jiffies, get_up_time)
862 (system_process_attributes):
863 Now returns ns-resolution time stamp. All uses changed.
864 Check for time stamp overflow.
865
866 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
867 provides a substitute now.
868
869 * systime.h: Include timespec.h rather than sys/time.h and time.h,
870 since it guarantees struct timespec.
871 (EMACS_TIME): Now struct timespec, so that we can support
872 ns-resolution time stamps.
873 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
874 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
875 (EMACS_USECS): Remove.
876 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
877 so multiply the arg by 1000 before storing it.
878 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
879 New macros.
880 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
881 Port to ns-resolution time stamps.
882 (EMACS_TIME_NEG_P): Remove; replaced by....
883 (EMACS_TIME_SIGN): New macro.
884 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
885 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
886 (set_file_times, make_time, lisp_time_argument): Adjust signature.
887 (make_timeval, make_lisp_time, decode_time_components): New decls.
888 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
889 that it mishandled time_t overflow. You can't compare by subtracting!
890 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
891 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
892
893 * term.c: Include <sys/time.h>.
894 (timeval_to_Time): New function, for proper overflow wraparound.
895 (term_mouse_position, term_mouse_click): Use it.
896
897 * undo.c (record_first_change): Support higher-resolution time stamps
898 in the undo buffer.
899 (Fprimitive_undo): Use them when restoring time stamps.
900
901 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
902 (w32_get_internal_run_time):
903 Port to higher-resolution Emacs time stamps.
904 (ltime): Now accepts single 64-bit integer, as that's more convenient
905 for callers.
906
907 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
908
909 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
910 for compatibility with pselect. Support ns-resolution time stamps.
911
912 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
913
914 * xselect.c (wait_for_property_change, x_get_foreign_selection):
915 Check for time stamp overflow, and support ns-resolution time stamps.
916
917 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
918 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
919 (timeval_subtract): Remove; no longer needed.
920 (XTflash, XTring_bell, x_wait_for_event):
921 Port to ns-resolution time stamps. Don't assume time_t is signed.
922
b6a92dfe
CY
9232012-06-22 Chong Yidong <cyd@gnu.org>
924
925 * xdisp.c (x_consider_frame_title): Revert last change.
926
d251c37c
EZ
9272012-06-22 Eli Zaretskii <eliz@gnu.org>
928
929 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
930 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
931 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
932 staticidx goes up to 1597 out of 1600 = 0x640.)
933
f10deafb
PE
9342012-06-20 Paul Eggert <eggert@cs.ucla.edu>
935
936 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
937 Otherwise, the umask might be mistakenly 0 while handling input signals.
938
ec6de1e2
SM
9392012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
940
941 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
942
28be1ada
DA
9432012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
944
945 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
946 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
947 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
948 access to `contents' member of Lisp_Vector objects with AREF and ASET
949 where appropriate.
950
c6bf3022
CY
9512012-06-19 Chong Yidong <cyd@gnu.org>
952
953 * frame.c (delete_frame): When selecting a frame on a different
954 text terminal, do not alter the terminal's top-frame.
955
956 * xdisp.c (format_mode_line_unwind_data): Record the target
957 frame's selected window and its terminal's top-frame.
958 (unwind_format_mode_line): Restore them.
959 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
960 Callers changed.
961 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
962 since tty frames can be explicitly named.
963 (prepare_menu_bars): Likewise.
964
965 * term.c (Ftty_top_frame): New function.
966
defd4196
PE
9672012-06-18 Paul Eggert <eggert@cs.ucla.edu>
968
969 Port byte-code-meter to modern targets.
970 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
971 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 972 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
973 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
974 (METER_1, METER_2): Simplify.
975
1053a871
SM
9762012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
977
978 * data.c (Fdefalias): Return `symbol' (bug#11686).
979
b7e8d081
MR
9802012-06-18 Martin Rudalics <rudalics@gmx.at>
981
982 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
983 gets killed during executing of this function (Bug#11665).
984 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
985 (Vkill_buffer_query_functions): In doc-string say that functions
986 run by this hook should not change the current buffer.
987
7ea2b339
PE
9882012-06-18 Paul Eggert <eggert@cs.ucla.edu>
989
990 Fix recently-introduced process.c problems found by static checking.
991 * process.c (write_queue_push, write_queue_pop, send_process):
992 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
993 (write_queue_pop): Fix pointer signedness problem.
994 (send_process): Remove unused local.
995
96a313a1
CY
9962012-06-17 Chong Yidong <cyd@gnu.org>
997
998 * xdisp.c (redisplay_internal): No need to redisplay terminal
999 frames that are not on top.
1000
20ca2e94
TN
10012012-06-17 Troels Nielsen <bn.troels@gmail.com>
1002
1003 * process.c (make_process): Initialize write_queue.
1004 (write_queue_push, write_queue_pop): New functions.
1005 (send_process): Use them to maintain correct ordering of process
1006 writes (Bug#10815).
1007
9a900ca9
PE
10082012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1009
310fbfa8
PE
1010 * lisp.h (eassert): Assume C89 or later.
1011 This removes the need for CHECK.
1012 (CHECK): Remove. Its comments about always evaluating its
1013 argument were confusing, as 'eassert' typically does not evaluate
1014 its argument.
1015
27bb1ca4
PE
1016 * coding.c (produce_chars): Use ptrdiff_t, not int.
1017
9a900ca9
PE
1018 * xterm.c (x_draw_underwave): Check for integer overflow.
1019 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1020
41b7f8bc 10212012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1022
1023 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1024 referenced (Bug#11583).
1025
9b0e3eba
AA
10262012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1027
1028 Implement wave-style variant of underlining.
1029 * dispextern.h (face_underline_type): New enum.
1030 (face): Add field for underline type.
1031 * nsterm.m (ns_draw_underwave): New function.
1032 (ns_draw_text_decoration): Use it.
1033 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1034 New functions.
1035 (x_draw_glyph_string): Use them.
1036 * xfaces.c (Qline, Qwave): New Lisp objects.
1037 (check_lface_attrs, merge_face_ref)
1053a871
SM
1038 (Finternal_set_lisp_face_attribute, realize_x_face):
1039 Handle wave-style underline face attributes.
9b0e3eba
AA
1040 * xterm.c (x_draw_underwave): New function.
1041 (x_draw_glyph_string): Use it.
1042
0fb52f11
JB
10432012-06-16 Juanma Barranquero <lekktu@gmail.com>
1044
1045 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1046 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1047 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1048 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1049 ($(BLD)/w32select.$(O)): Update dependencies.
1050
e5560ff7
AS
10512012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1052
1053 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1054 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1055 * character.c (_fetch_multibyte_char_p): Remove.
1056 * alloc.c: Include "character.h" before "buffer.h".
1057 * bidi.c: Likewise.
1058 * buffer.c: Likewise.
1059 * bytecode.c: Likewise.
1060 * callint.c: Likewise.
1061 * callproc.c: Likewise.
1062 * casefiddle.c: Likewise.
1063 * casetab.c: Likewise.
1064 * category.c: Likewise.
1065 * cmds.c: Likewise.
1066 * coding.c: Likewise.
1067 * composite.c: Likewise.
1068 * dired.c: Likewise.
1069 * dispnew.c: Likewise.
1070 * doc.c: Likewise.
1071 * dosfns.c: Likewise.
1072 * editfns.c: Likewise.
1073 * emacs.c: Likewise.
1074 * fileio.c: Likewise.
1075 * filelock.c: Likewise.
1076 * font.c: Likewise.
1077 * fontset.c: Likewise.
1078 * fringe.c: Likewise.
1079 * indent.c: Likewise.
1080 * insdel.c: Likewise.
1081 * intervals.c: Likewise.
1082 * keyboard.c: Likewise.
1083 * keymap.c: Likewise.
1084 * lread.c: Likewise.
1085 * macros.c: Likewise.
1086 * marker.c: Likewise.
1087 * minibuf.c: Likewise.
1088 * nsfns.m: Likewise.
1089 * nsmenu.m: Likewise.
1090 * print.c: Likewise.
1091 * process.c: Likewise.
1092 * regex.c: Likewise.
1093 * region-cache.c: Likewise.
1094 * search.c: Likewise.
1095 * syntax.c: Likewise.
1096 * term.c: Likewise.
1097 * textprop.c: Likewise.
1098 * undo.c: Likewise.
1099 * unexsol.c: Likewise.
1100 * w16select.c: Likewise.
1101 * w32fns.c: Likewise.
1102 * w32menu.c: Likewise.
1103 * window.c: Likewise.
1104 * xdisp.c: Likewise.
1105 * xfns.c: Likewise.
1106 * xmenu.c: Likewise.
1107 * xml.c: Likewise.
1108 * xselect.c: Likewise.
1109
2f07e6af
EZ
11102012-06-16 Eli Zaretskii <eliz@gnu.org>
1111
1053a871
SM
1112 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1113 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1114 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1115 row.
1116 (handle_face_prop): Use chunk-relative overlay string index when
1117 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1118 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1119 the rightmost. (Bug#11720)
2f07e6af 1120
29b83cec
AS
11212012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1122
1123 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1124 (CATEGORY_MEMBER): Enforce 1/0 value.
1125 * category.c (_temp_category_set): Remove.
1126
4c5501e9
EZ
11272012-06-16 Eli Zaretskii <eliz@gnu.org>
1128
1129 * window.c (Fdelete_other_windows_internal)
1130 (Fdelete_window_internal): Don't access frame's mouse highlight
1131 info of the initial frame. (Bug#11677)
1132
2b570124
PE
11332012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1134
e93864f9
PE
1135 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1136 Assume USE_2_TAGS_FOR_INTS.
1137 (xreload): Adjust $tagmask width to match recent lisp.h change.
1138
2b570124
PE
1139 Simplify lisp.h in minor ways that should not affect code.
1140 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1141 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1142 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1143 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1144 (INTTYPEBITS): New macro, for clarity.
1145 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1146 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1147 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1148 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1149 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1150
81755f69
JB
11512012-06-13 Juanma Barranquero <lekktu@gmail.com>
1152
1153 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1154
16192a57
GM
11552012-06-13 Glenn Morris <rgm@gnu.org>
1156
1157 * s/bsd-common.h (BSD4_3):
1158 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1159
646b5f55
AS
11602012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1161
1162 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1163 instead of union.
1164 (XLI, XIL): Define.
1053a871
SM
1165 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1166 Use them.
1167 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1168 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1169 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1170 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1171 * frame.c (delete_frame): Remove outdated comment.
1172 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1173 USE_LISP_UNION_TYPE.
1174 (Fw32_unregister_hot_key): Likewise.
1175 (Fw32_toggle_lock_key): Likewise.
1176 * w32menu.c (add_menu_item): Likewise.
1177 (w32_menu_display_help): Use XIL instead of checking
1178 USE_LISP_UNION_TYPE.
1179 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1180 (init_heap): Likewise.
1181 * w32term.c (w32_read_socket): Update comment.
1182
1d3823c9
GM
11832012-06-13 Glenn Morris <rgm@gnu.org>
1184
c62ff706
GM
1185 * s/usg5-4-common.h, src/s/unixware.h:
1186 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1187
1d3823c9
GM
1188 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1189
bfe3e0a2
PE
11902012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1191
1192 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1193 * alloc.c (make_number) [!defined make_number]:
1194 Remove, as lisp.h always defines this now.
1195 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1196 (roundup_size): Verify that it is a power of 2.
1197 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1198 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1199 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1200 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1201 USE_LSB_TAG now is always defined to be either 0 or 1.
1202 All uses changed.
1203 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1204 code works fine either way, and efficiency is not a concern here,
1205 as the union type is for debugging, not for production.
1206 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1207 Use an inline function on all platforms when using the union type,
1208 since this is simpler and 'static inline' can be used portably
1209 within Emacs now.
1210 (LISP_INITIALLY_ZERO): New macro.
1211 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1212 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1213
45fa9c0f
GM
12142012-06-12 Glenn Morris <rgm@gnu.org>
1215
b4492cba
GM
1216 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1217
1218 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1219
45fa9c0f
GM
1220 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1221 Move BROKEN_SIGIO to configure.
1222
1223 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1224 Move NO_TERMIO to configure.
1225
0e25d334
CY
12262012-06-12 Chong Yidong <cyd@gnu.org>
1227
1228 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1229 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1230 MagickExportImagePixels is undefined.
1231
43682bb6
PE
12322012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1233
1234 * image.c (imagemagick_load_image): Remove unused label.
1235
a9be7d2b
GM
12362012-06-11 Glenn Morris <rgm@gnu.org>
1237
1238 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1239 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1240 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1241 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1242
3017f87f
SM
12432012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1244
1245 * alloc.c (make_byte_code): New function.
1246 (Fmake_byte_code): Use it. Don't purify here.
1247 * lread.c (read1): Use it as well to avoid extra allocation.
1248
1b9b4cf4
CY
12492012-06-11 Chong Yidong <cyd@gnu.org>
1250
1251 * image.c (imagemagick_load_image): Implement transparency.
1252
95988fcf
AS
12532012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1254
1255 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1256 account for preceding backslashes. (Bug#11663)
1257
cd4eb164
CY
12582012-06-09 Chong Yidong <cyd@gnu.org>
1259
1260 * term.c: Support italics in capable terminals (Bug#9652).
1261 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1262 (turn_on_face): Output using TS_enter_italic_mode if available.
1263 Don't handle unused blinking and alt-charset cases.
1264 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1265 and tty_alt_charset_p cases.
1266 (tty_capable_p, init_tty): Support italics.
1267
1268 * termchar.h (struct tty_display_info): Add field for italics.
1269 Remove unused blink field.
1270
1271 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1272 Handle slant.
1273
1274 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1275 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1276 tty_alt_charset_p. Add tty_italic_p.
1277
ff88beb8
MA
12782012-06-09 Michael Albinus <michael.albinus@gmx.de>
1279
1280 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1281 dbus_type_is_basic if available.
1282 (xd_extract_signed, xd_extract_unsigned): Rename from
1283 extract_signed and extract_unsigned, respectively. Adapt callers.
1284
44286096
CY
12852012-06-09 Chong Yidong <cyd@gnu.org>
1286
1682701f
CY
1287 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1288
44286096
CY
1289 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1290 case (Bug#9752).
1291
d86feb17
PE
12922012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 * xdisp.c (vmessage): Treat frame message as multibyte.
1295 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1296 would generate the diagnostic "Making \302\247 buffer-local while
1297 let-bound!".
1298
d5c20fe8
EZ
12992012-06-08 Eli Zaretskii <eliz@gnu.org>
1300
1301 * dispnew.c (showing_window_margins_p): Undo last change, which
1302 was done due to an inadvertent commit.
1303 (adjust_frame_glyphs_for_frame_redisplay): Do call
1304 showing_window_margins_p.
1305
513749ee
SM
13062012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1307
1308 * eval.c (Fmake_var_non_special): New primitive.
1309 (syms_of_eval): Defsubr it.
1310 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1311
d4a8f5c1
JB
13122012-06-08 Juanma Barranquero <lekktu@gmail.com>
1313
1314 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1315 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1316
8bbbc977
EZ
13172012-06-08 Eli Zaretskii <eliz@gnu.org>
1318
1319 * alloc.c (allocate_vectorlike): Fix last change.
1320
f3372c87
DA
13212012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1322
1323 Block-based vector allocation of small vectors.
1324 * lisp.h (struct vectorlike_header): New field `nbytes',
1325 adjust comment accordingly.
1326 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1327 to denote vector blocks. Adjust users (live_vector_p,
1328 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1329 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1330 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1331 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1332 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1333 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1334 (roundup_size): New constant.
1335 (struct vector_block): New data type.
1336 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1337 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1338 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1339 (sweep_vectors): New functions.
1340 (allocate_vectorlike): Return `zero_vector' as the only vector of
1341 0 items. Allocate new vector from block if vector size is less than
1342 or equal to VBLOCK_BYTES_MAX.
1343 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1344 (init_alloc_once): Add call to init_vectors.
1345
4f18a4ed
SM
13462012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1347
1348 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1349
86f158bc
PE
13502012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1351
1352 * doprnt.c (doprnt): Truncate multibyte char correctly.
1353 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1354 would mishandle a string argument "Xc" if X was a multibyte
1355 character of length 2: it would truncate after X's first byte
1356 rather than including all of X.
1357
c5cfcbe0
CY
13582012-06-06 Chong Yidong <cyd@gnu.org>
1359
1360 * buffer.c (word_wrap): Doc fix.
1361
c05cf390
PE
13622012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1363
1364 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1365
0c3461de
GM
13662012-06-03 Glenn Morris <rgm@gnu.org>
1367
1368 * xdisp.c (tool-bar-style): Doc fix.
1369
c71232db
UM
13702012-06-03 Ulrich Müller <ulm@gentoo.org>
1371
1372 * Makefile.in (PAXCTL): Define.
1373 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1374 binary via PaX flags if the paxctl utility is available.
1375 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1376 Restore PaX flags to their default. (Bug#11398)
1377
383f7350
CY
13782012-06-03 Chong Yidong <cyd@gnu.org>
1379
1380 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1381 buffer (Bug#11226).
1382
5f2c76c6
CY
13832012-06-03 Chong Yidong <cyd@gnu.org>
1384
1385 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1386 (note_mode_line_or_margin_highlight): If there is no help echo,
1387 use mode-line-default-help-echo. Handle the case where the mouse
1388 position is past the end of the mode line string.
1389
1390 * buffer.c (buffer_local_value_1): New function, split from
1391 Fbuffer_local_value; can return Qunbound.
1392 (Fbuffer_local_value): Use it.
1393 (Vmode_line_format): Docstring tweaks.
1394
773d47f6
PE
13952012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1396
1397 * sysdep.c (system_process_attributes): Improve comment.
1398
f2d6a3df
SM
13992012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1400
1401 * keyboard.c: Export real-this-command to Elisp.
1402 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1403 and DEFVAR it. Update all users.
1404
63810350
PE
14052012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1406
7bd5c1f4
PE
1407 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1408
63810350
PE
1409 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1410 Convert pctcpu and pctmem to Lisp float properly.
1411 Let the compiler fold better, as 100.0/0x8000 is exact.
1412
a2821611
AS
14132012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1414
1415 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1416 cons_block.
1417
5fceba1d
PE
14182012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1419
1420 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1421
c98ff5dd
DA
14222012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1423
1424 For a 'struct window', replace some Lisp_Object fields to
1425 bitfields where appropriate, remove unused fields.
1426 * window.h (struct window): Remove unused 'last_mark_x' and
1427 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1428 change it's type from Lisp_Object to bitfield.
1429 Change type of 'force_start', 'optional_new_start',
1430 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1431 fields from Lisp_Object to bitfield. Adjust users accordingly.
1432
ca34e0be
PE
14332012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1434
1435 Pacify gcc -Wdouble-precision when using Xaw.
1436 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1437 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1438 Use 'float' consistently, rather than 'float' in most places
1439 and 'double' in a couple of places.
1440
efc00ab1 14412012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1442
1443 * xdisp.c (handle_stop): Detect whether we have overlay strings
1444 loaded by testing it->current.overlay_string_index to be
1445 non-negative, instead of checking whether n_overlay_strings is
1446 positive. (Bug#11587)
1447
efc00ab1 14482012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1449
1450 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1451
1452 * doc.c (Fsubstitute_command_keys): Doc fix.
1453
efc00ab1 14542012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1455
1456 * search.c (search_buffer): Remove calls to
1457 r_alloc_inhibit_buffer_relocation, as it is now called by
1458 maybe_unify_char, which was the cause of relocation of buffer text
1459 in bug#11519.
1460
efc00ab1 14612012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1462
1463 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1464 for the duration of call to load_charset, to avoid problems with
1465 callers of maybe_unify_char that access buffer text through C
1466 pointers.
1467
1468 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1469 decrement the inhibition flag, instead of just setting or
1470 resetting it.
1471
ba93a187
PE
14722012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1473
1474 Remove obsolete '#define static' cruft.
1475 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1476 This #undef was "temporary" in 2000; it is no longer needed
1477 now that '#define static' has gone away.
1478 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1479 (gray_bitmap_bits): Remove; no longer needed.
1480 All uses replaced with definiens.
1481 * xterm.c: Include "bitmaps/gray.xbm".
1482
9e4bf381
PE
14832012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1484
1485 Clean up __executable_start, monstartup when --enable-profiling.
1486 The following changes affect the code only when profiling.
1487 * dispnew.c (__executable_start): Rename from safe_bcopy.
1488 Define only on platforms that need it.
1489 * emacs.c: Include <sys/gmon.h> when profiling.
1490 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1491 (__executable_start): Remove decl, since lisp.h does it now.
1492 (safe_bcopy): Remove decl; no longer has that name.
1493 (main): Coalesce #if into single bit of code, for simplicity.
1494 Cast pointers to uintptr_t, since standard libraries want integers
1495 and not pointers.
1496 * lisp.h (__executable_start): New decl.
1497
32d72c2f
GM
14982012-05-31 Glenn Morris <rgm@gnu.org>
1499
1500 * image.c (Fimagemagick_types): Doc fix.
1501
baac5bc7
JM
15022012-05-30 Jim Meyering <meyering@redhat.com>
1503
1504 * callproc.c (Fcall_process_region): Include directory component
1505 in mkstemp error message (Bug#11586).
1506
72cb32cf
PE
15072012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1508
1509 * alloc.c, lisp.h (make_pure_vector): Now static.
1510
61b108cc
SM
15112012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1512
1513 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1514 Move to byte-run.el.
1515 (Fautoload): Do the hash-doc more carefully.
1516 * data.c (Fdefalias): Purify definition, except for keymaps.
1517 (Qdefun): Move from eval.c.
1518 * lisp.h (Qdefun): Remove.
1519 * lread.c (read1): Tiny simplification.
1520
471fe23d
TN
15212012-05-29 Troels Nielsen <bn.troels@gmail.com>
1522
934f3f58 1523 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1524 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1525 Bug#9642, but explicitly check that the buffer the overlay would
1526 be moved to is live and rearrange lines to make sure that errors
1527 will not put the overlay in an inconsistent state.
1528 (Fdelete_overlay): Cosmetics.
1529
85d0efd1
EZ
15302012-05-28 Eli Zaretskii <eliz@gnu.org>
1531
1532 * w32term.c (my_bring_window_to_top): New function.
1533 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1534 could be different from the original one.
1535 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1536 (Bug#11513)
1537
1538 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1539 by calling BringWindowToTop.
1540
1541 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1542 (WM_EMACS_END): Increase by one.
1543
da92a98c
PE
15442012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1545
1546 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1547 This avoids undefined behavior that might cause the eassert
1548 to not catch an out-of-range value.
1549
74d1f848
JB
15502012-05-28 Juanma Barranquero <lekktu@gmail.com>
1551
1552 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1553 Update dependencies.
1554
9e1a06fc
EZ
15552012-05-27 Eli Zaretskii <eliz@gnu.org>
1556
1557 * bidi.c (bidi_mirror_char): Fix last change.
1558
f3dd7312
AS
15592012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1560
1561 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1562 when referring to sectname field in printf format.
1563
81899c91
PE
15642012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1565
57b81a9f
PE
1566 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1567 Only r_alloc_inhibit_buffer_relocation needed to be added;
1568 the others were already declared.
1569
81899c91
PE
1570 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1571 before checking whether it's out of range. Put the check inside
1572 eassert. See
1573 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1574
33017faf 15752012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1576
1577 * callproc.c (Fcall_process): Restore a line that was accidentally
1578 commented out in the 2011-02-13 change (bug#11547).
1579
33017faf 15802012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1581
1582 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1583 defined on ralloc.c.
1584
1585 * buffer.c [REL_ALLOC]: Remove prototypes of
1586 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1587 they are now on lisp.h.
1588
1589 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1590
1591 * search.c (search_buffer): Use it to inhibit relocation of buffer
1592 text while re_search_2 is doing its job, because re_search_2 is
1593 passed C pointers to buffer text. (Bug#11519)
1594
23415acf
EZ
1595 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1596 Update value to 24.
1597
44e27368
EZ
1598 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1599 state after an additional call to move_it_in_display_line_to, keep
1600 the values of it->max_ascent and it->max_descent found for the
1601 entire line.
1602 (pos_visible_p): Revert the comparison against bottom_y to what it
1603 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1604 (Bug#11464)
1605
c1892f11
PE
16062012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1607
1608 Fix coding-related core dumps with gcc -ftrapv.
1609 The code was computing A - B, where A and B are pointers, and B is
1610 random garbage. This can lead to core dumps on platforms that
1611 have special pointer registers, and it also leads to core dumps on
1612 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1613 A - B only when B is initialized properly.
1614 * coding.c (coding_set_source, coding_set_destination): Return void.
1615 (coding_change_source, coding_change_destinations): New functions,
1616 with the old behaviors of coding_set_source and coding_set_destination.
1617 All callers that need an offset changed to use these new functions.
1618
eb7afdad
GM
16192012-05-26 Glenn Morris <rgm@gnu.org>
1620
1621 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1622
f12fdf02
EZ
16232012-05-26 Eli Zaretskii <eliz@gnu.org>
1624
53a63be6 1625 Extend mouse support on W32 text-mode console.
61b108cc
SM
1626 * xdisp.c (draw_row_with_mouse_face):
1627 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1628
eb3f6f01 1629 * w32console.c: Include window.h.
61b108cc
SM
1630 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1631 New functions.
eb3f6f01
EZ
1632 (initialize_w32_display): Initialize mouse-highlight data.
1633
53a63be6
EZ
1634 * w32inevt.c: Include termchar.h and window.h.
1635 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1636 moves, call note_mouse_highlight. If help_echo changed, call
1637 gen_help_event to produce help-echo message in the echo area.
1638 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1639 highlight info.
1640
4cfd81f6
PE
16412012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1642
1643 * lread.c (read1): Simplify slightly to avoid an overflow warning
1644 with GCC 4.7.0 on x86-64.
1645
4446092a
EZ
16462012-05-26 Eli Zaretskii <eliz@gnu.org>
1647
1648 * bidi.c (bidi_mirror_char): Revert last change: an int is
1649 definitely wide enough here.
1650
42b2a986 16512012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1652
42b2a986 1653 Fix integer width and related bugs (Bug#9874).
eb106a49 1654 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1655 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1656 (string_bytes, check_sblock, allocate_string_data):
1657 (compact_small_strings, Fmake_bool_vector, make_string)
1658 (make_unibyte_string, make_multibyte_string)
1659 (make_string_from_bytes, make_specified_string)
1660 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1661 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1662 (mark_vectorlike):
1663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1664 (allocate_pseudovector):
1665 Use int, not EMACS_INT, where int is wide enough.
1666 (inhibit_garbage_collection, Fgarbage_collect):
1667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1668 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1669 int might not be wide enough.
1670 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1671 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1672 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1673 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1674 (bidi_level_of_next_char, bidi_move_to_visually_next):
1675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1676 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1677 (Fkill_buffer, Fset_buffer_major_mode)
1678 (advance_to_char_boundary, Fbuffer_swap_text)
1679 (Fset_buffer_multibyte, overlays_at, overlays_in)
1680 (overlay_touches_p, struct sortvec, record_overlay_string)
1681 (overlay_strings, recenter_overlay_lists)
1682 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1683 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1684 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1685 (Foverlay_recenter, last_overlay_modification_hooks_used)
1686 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1688 (validate_region): Omit unnecessary test for b <= e,
1689 since that's guaranteed by the previous test.
d311d28c
PE
1690 (adjust_overlays_for_delete): Avoid pos + length overflow.
1691 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1692 (report_overlay_modification):
1693 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1694 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1695 Omit pointer cast, which isn't needed anyway, and doesn't work
1696 after the EMACS_INT -> ptrdiff_t change.
02481186 1697 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1698 * buffer.h: Adjust decls to match defn changes elsewhere.
1699 (struct buffer_text, struct buffer):
1700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1701 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1702 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1703 not int, to avoid needless 32-bit limit on 64-bit hosts.
1704 (exec_byte_code): Use tighter memory-full test, one that checks
1705 for alloca overflow. Don't compute the address of the object just
1706 before an array, as that's not portable. Use EMACS_INT, not
1707 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1708 * callint.c (Fcall_interactively):
1709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1710 * callproc.c (call_process_kill, Fcall_process):
1711 Don't assume pid_t fits into an Emacs fixnum.
1712 (call_process_cleanup, Fcall_process, child_setup):
1713 Don't assume pid_t fits into int.
1714 (call_process_cleanup, Fcall_process, delete_temp_file)
1715 (Fcall_process_region):
1716 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1717 (Fcall_process): Simplify handling of volatile integers.
1718 Use int, not EMACS_INT, where int will do.
1719 * casefiddle.c (casify_object, casify_region, operate_on_word)
1720 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1722 (casify_object): Avoid integer overflow when overallocating buffer.
1723 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1724 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1725 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1726 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1727 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1728 integers are now checked earlier. All uses replaced with XINT.
1729 (ccl_driver):
1730 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1731 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1732 (ccl_driver, Fregister_code_conversion_map):
1733 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1734 (resolve_symbol_ccl_program): Check that vector header is in range.
1735 Always copy the vector, so that we can check its contents reliably
1736 now rather than having to recheck each instruction as it's being
1737 executed. Check that vector words fit in 'int'.
1738 (ccl_get_compiled_code, Fregister_ccl_program)
1739 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1740 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1741 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1742 contents are in range.
1743 (Fccl_execute_on_string): Check that status is in range.
1744 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1745 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1746 Accept and return EMACS_INT, not int, because callers can pass values
1747 out of 'int' range.
1748 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1749 (multibyte_chars_in_text, parse_str_as_multibyte)
1750 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1751 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1752 (string_escape_byte8, Fget_byte):
1753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1754 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1755 avoid mishandling large integers.
1756 * character.h: Adjust decls to match defn changes elsewhere.
1757 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1758 (Ffind_charset_region):
1759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1760 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1761 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1762 Don't assume fixnum fits in int.
d311d28c
PE
1763 (load_charset_map_from_vector, Fmap_charset_chars):
1764 Remove now-unnecessary CHECK_NATNUMs.
1765 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1766 Don't rely on undefined behavior with signed left shift overflow.
1767 Don't assume unsigned int fits into fixnum, or that fixnum fits
1768 into unsigned int. Don't require max_code to be a valid fixnum;
1769 that's not true for gb10830 4-byte on a 32-bit host. Allow
1770 invalid_code to be a cons, for the same reason. Require code_offset
1771 to be a character. Avoid int overflow if max_char is close
1772 to INT_MAX.
1773 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1774 this is intended anyway and avoids some undefined behavior.
1775 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1776 INDEX_TO_CODE_POINT, as that's what it expects.
1777 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1778 * charset.h (DECODE_CHAR): Return int, not unsigned;
1779 this is what was intended anyway, and it avoids undefined behavior.
1780 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1781 integer-overflow issues.
1782 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1783 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1784 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1785 * chartab.c (Fmake_char_table, Fset_char_table_range)
1786 (uniprop_get_decoder, uniprop_get_encoder):
1787 Don't assume fixnum fits in int.
1788 * cmds.c (move_point): New function, that does the gist of
1789 Fforward_char and Fbackward_char, but does so while checking
1790 for integer overflow more accurately.
c96e5d6a 1791 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1792 (Fforward_line, Fend_of_line, internal_self_insert)
1793 (internal_self_insert):
1794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1795 Fix a FIXME, by checking for integer overflow when calculating
1796 target_clm and actual_clm.
1797 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1798 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1799 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1800 (coding_alloc_by_making_gap, alloc_destination)
1801 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1802 (encode_coding_utf_16, detect_coding_emacs_mule)
1803 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1804 (detect_coding_iso_2022, decode_coding_iso_2022)
1805 (encode_invocation_designation, encode_designation_at_bol)
1806 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1807 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1808 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1809 (encode_coding_ccl, encode_coding_raw_text)
1810 (detect_coding_charset, decode_coding_charset)
1811 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1812 (produce_composition, produce_charset, produce_annotation)
1813 (decode_coding, handle_composition_annotation)
1814 (handle_charset_annotation, consume_chars, decode_coding_gap)
1815 (decode_coding_object, encode_coding_object, detect_coding_system)
1816 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1817 (code_convert_region, code_convert_string)
8f50130c
PE
1818 (Fdefine_coding_system_internal)
1819 (coding_set_source, coding_set_destination):
d311d28c
PE
1820 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1821 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1822 (Fdefine_coding_system_internal):
1823 Don't assume fixnums fit in int.
1824 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1825 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1826 (Funencodable_char_position, Fcheck_coding_systems_region)
1827 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1829 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1830 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1831 Don't access memory outside of the args array.
d311d28c 1832 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1833 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1834 result of ENCODE_CHAR.
d311d28c
PE
1835 * coding.h: Adjust decls to match defn changes elsewhere.
1836 (struct coding_system):
1837 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1838 * composite.c (get_composition_id, find_composition)
1839 (run_composition_function, update_compositions)
1840 (compose_text, composition_gstring_put_cache)
1841 (composition_gstring_p, composition_gstring_width)
1842 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1843 (composition_compute_stop_pos, composition_reseat_it)
1844 (composition_update_it, struct position_record)
1845 (find_automatic_composition, composition_adjust_point)
1846 (Fcomposition_get_gstring, Ffind_composition_internal):
1847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1848 (update_compositions):
1849 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1850 * composite.h: Adjust decls to match defn changes elsewhere.
1851 (struct composition):
1852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1853 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1854 Do not attempt to compute the address of the object just before a
1855 buffer; this is not portable.
1856 (Faref, Faset):
1857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1858 (Faset): Use int, not EMACS_INT, where int is wide enough.
1859 (Fstring_to_number): Don't assume fixnums fit in int.
1860 (Frem): Don't assume arg is nonnegative.
1861 * dbusbind.c (xd_append_arg): Check for integers out of range.
1862 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1863 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1864 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1865 (xd_get_connection_references): Return ptrdiff_t, not int.
1866 All uses changed.
1867 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1868 (xd_read_message_1):
1869 Use int, not unsigned, where the dbus API uses int.
1870 (Fdbus_message_internal): Don't overflow mtype.
1871 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1872 * dired.c (directory_files_internal, file_name_completion, scmp)
1873 (file_name_completion_stat):
1874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1875 (file_name_completion): Don't overflow matchcount.
1876 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1877 * dispextern.h: Adjust decls to match defn changes elsewhere.
1878 (struct text_pos, struct glyph, struct bidi_saved_info)
1879 (struct bidi_string_data, struct bidi_it, struct composition_it)
1880 (struct it):
1881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1882 (struct display_pos, struct composition_it, struct it):
1883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1884 * dispnew.c (increment_matrix_positions)
1885 (increment_row_positions, mode_line_string)
1886 (marginal_area_string):
1887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1888 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1889 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1890 (duration_to_sec_usec): New function, to check for overflow better.
1891 (Fsleep_for, sit_for): Use it.
1892 * doc.c (get_doc_string, store_function_docstring):
1893 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1894 (get_doc_string, Fsnarf_documentation):
1895 Use int, not EMACS_INT, where int is wide enough.
1896 (get_doc_string):
1897 Use SAFE_ALLOCA, not alloca.
1898 Check for overflow when converting EMACS_INT to off_t.
1899 * doprnt.c (doprnt):
1900 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1901 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1902 Don't assume uid_t fits into fixnum.
1903 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1904 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1905 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1906 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1907 (general_insert_function)
1908 (Finsert_char, make_buffer_string, make_buffer_string_both)
1909 (update_buffer_properties, Fbuffer_substring)
1910 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1911 (Fsubst_char_in_region, check_translation)
1912 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1913 (transpose_markers, Ftranspose_regions):
1914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1915 (clip_to_bounds): Move to lisp.h as an inline function).
1916 (Fconstrain_to_field): Don't assume integers are nonnegative.
1917 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1918 (Fsubst_char_in_region, Fsave_restriction):
1919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1920 (Femacs_pid): Don't assume pid_t fits into fixnum.
1921 (lo_time): Use int, not EMACS_INT, when int suffices.
1922 (lisp_time_argument): Check for usec out of range.
1923 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1924 (Fuser_login_name, Fuser_full_name): Signal an error
1925 if a uid argument is out of range, rather than relying on
1926 undefined behavior.
c8d5c857
PE
1927 (Fformat_time_string): Remove now-unnecessary check.
1928 lisp_time_argument checks for out-of-range usec now.
243e0530 1929 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1930 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1931 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1932 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1933 (init_cmdargs, Fdump_emacs):
1934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1935 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1936 the bottom (typically) 32 bits of the fixnum.
1937 * eval.c (specpdl_size, call_debugger):
1938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1939 (when_entered_debugger, Fbacktrace_debug):
1940 Don't assume fixnum can fit in int.
1941 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1942 the object just before a buffer; this is not portable.
1943 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1944 (grow_specpdl, unbind_to):
1945 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1946 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1947 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1948 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1949 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1950 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1951 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1952 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1953 (a_write, e_write):
1954 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1955 (Fcopy_file, non_regular_nbytes, read_non_regular)
1956 (Finsert_file_contents):
1957 Use int, not EMACS_INT, where int is wide enough.
1958 (READ_BUF_SIZE): Verify that it fits in int.
1959 (Finsert_file_contents): Check that counts are in proper range,
1960 rather than assuming fixnums fit into ptrdiff_t etc.
1961 Don't assume fixnums fit into int.
125b3835 1962 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1963 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1964 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1965 (string_char_to_byte, string_byte_to_char)
1966 (string_make_multibyte, string_to_multibyte)
1967 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1968 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1969 (substring_both, Fdelete, internal_equal, Ffillarray)
1970 (Fclear_string, mapcar1)
1971 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1972 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1973 (larger_vector, make_hash_table, maybe_resize_hash_table)
1974 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1975 (Fmaphash, secure_hash):
1976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1977 (concat): Check for string index and length overflow.
1978 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1979 (Frequire):
1980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1981 (larger_vector): New API (vec, incr_min, size_max) replaces old
1982 one (vec, new_size, init). This catches size overflow.
1983 INIT was removed because it was always Qnil.
1984 All callers changed.
1985 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1986 the upper bound on a hash table index size.
1987 (make_hash_table, maybe_resize_hash_table): Use it.
1988 (secure_hash): Computer start_byte and end_byte only after
1989 they're known to be in ptrdiff_t range.
1990 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1991 (Ffont_get_glyphs, Ffont_at):
1992 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1993 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1994 (Flist_fonts, Fopen_font):
1995 Don't assume fixnum can fit in int.
1996 (check_gstring): Don't assume index can fit in int.
1997 (font_match_p): Check that fixnum is a character, not a nonnegative
1998 fixnum, since the later code needs to stuff it into an int.
1999 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2000 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2001 conversion overflow issues.
2002 (Fopen_font): Check for integer out of range.
2003 (Ffont_get_glyphs): Don't assume index can fit in int.
2004 * font.h: Adjust decls to match defn changes elsewhere.
2005 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2006 integer overflow.
2007 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2008 printmax_t, where ptrdiff_t is wide enough.
2009 (Finternal_char_font):
2010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2011 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2012 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2013 (Fset_frame_position, x_set_frame_parameters)
2014 (x_set_line_spacing, x_set_border_width)
2015 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2016 Check that fixnums are in proper range for system types.
2017 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2018 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2019 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2020 Use SAFE_ALLOCA_LISP, not alloca.
2021 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2022 intptr_t is wide enough.
2023 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2024 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2025 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2026 Check for fixnum out of range.
2027 * ftfont.c (ftfont_list): Don't assume index fits in int.
2028 Check that fixnums are in proper range for system types.
2029 (ftfont_shape_by_flt):
2030 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2031 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2032 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2033 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2034 Check that fixnums are in proper range for system types.
2035 * gnutls.h: Adjust decls to match defn changes elsewhere.
2036 * gtkutil.c (xg_dialog_run):
2037 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2038 (update_frame_tool_bar):
2039 Check that fixnums are in proper range for system types.
2040 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2041 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2042 * indent.c (last_known_column, last_known_column_point):
2043 (current_column_bol_cache):
2044 (skip_invisible, current_column, check_display_width):
2045 (check_display_width, scan_for_column, current_column_1)
2046 (Findent_to, Fcurrent_indentation, position_indentation)
2047 (indented_beyond_p, Fmove_to_column, compute_motion):
2048 (Fcompute_motion, Fvertical_motion):
2049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2050 (last_known_column_modified): Use EMACS_INT, not int.
2051 (check_display_width):
2052 (Fcompute_motion):
2053 Check that fixnums and floats are in proper range for system types.
2054 (compute_motion): Don't assume index or fixnum fits in int.
2055 (compute_motion, Fcompute_motion):
2056 Use int, not EMACS_INT, when it is wide enough.
2057 (vmotion): Omit local var start_hpos that is always 0; that way
2058 we don't need to worry about overflow in expressions involving it.
2059 * indent.h: Adjust decls to match defn changes elsewhere.
2060 (struct position):
2061 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2062 Use int, not EMACS_INT, where int is wide enough.
2063 Remove unused members ovstring_chars_done and tab_offset;
2064 all uses removed.
2065 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2066 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2067 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2068 (make_gap, copy_text, insert, insert_and_inherit)
2069 (insert_before_markers, insert_before_markers_and_inherit)
2070 (insert_1, count_combining_before, count_combining_after)
2071 (insert_1_both, insert_from_string)
2072 (insert_from_string_before_markers, insert_from_string_1)
2073 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2074 (adjust_after_replace, adjust_after_insert, replace_range)
2075 (replace_range_2, del_range, del_range_1, del_range_byte)
2076 (del_range_both, del_range_2, modify_region)
2077 (prepare_to_modify_buffer, signal_before_change)
2078 (signal_after_change, Fcombine_after_change_execute):
2079 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2080 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2081 (balance_an_interval, split_interval_right, split_interval_left)
2082 (find_interval, next_interval, update_interval)
2083 (adjust_intervals_for_insertion, delete_node, delete_interval)
2084 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2085 (static_offset_intervals, offset_intervals)
2086 (merge_interval_right, merge_interval_left, make_new_interval)
2087 (graft_intervals_into_buffer, temp_set_point_both)
2088 (temp_set_point, set_point, adjust_for_invis_intang)
2089 (set_point_both, move_if_not_intangible, get_property_and_range)
2090 (get_local_map, copy_intervals, copy_intervals_to_string)
2091 (compare_string_intervals, set_intervals_multibyte_1):
2092 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2093 * intervals.h: Adjust decls to match defn changes elsewhere.
2094 (struct interval):
2095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2096 * keyboard.c (this_command_key_count, this_single_command_key_start)
2097 (before_command_key_count, before_command_echo_length, echo_now)
2098 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2099 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2100 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2101 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2102 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2103 (last_non_minibuf_size, last_point_position, echo_truncate)
2104 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2105 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2106 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2107 (stuff_buffered_input):
2108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2109 (last_auto_save, command_loop_1, read_char):
2110 Use EMACS_INT, not int, to avoid integer overflow.
2111 (record_char): Avoid overflow in total_keys computation.
2112 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2113 * keyboard.h: Adjust decls to match defn changes elsewhere.
2114 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2115 (Fkey_description, Fdescribe_vector, Flookup_key):
2116 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2117 (click_position): New function, to check that positions are in range.
2118 (Fcurrent_active_maps):
2119 (describe_command):
2120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2121 (Faccessible_keymaps, Fkey_description):
2122 (preferred_sequence_p):
2123 Don't assume fixnum can fit into int.
2124 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2125 Check for integer overflow in size calculations.
2126 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2127 avoid mishandling large integers.
2128 * lisp.h: Adjust decls to match defn changes elsewhere.
2129 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2130 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2131 (struct Lisp_Marker):
2132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2133 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2134 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2135 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2136 All callers changed.
2137 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2138 Assume the arg has valid form, since it always does.
2139 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2140 unsigned integer system type.
2141 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2142 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2143 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2144 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2145 (duration_to_sec_usec): New decl.
2146 * lread.c (read_from_string_index, read_from_string_index_byte)
2147 (read_from_string_limit, readchar, unreadchar, openp)
2148 (read_internal_start, read1, oblookup):
2149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2150 (Fload, readevalloop, Feval_buffer, Feval_region):
2151 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2152 (openp): Check for out-of-range argument to 'access'.
2153 (read1): Use int, not EMACS_INT, where int is wide enough.
2154 Don't assume fixnum fits into int.
6efdadfd 2155 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2156 (read_filtered_event): Use duration_to_sec_usec
2157 to do proper overflow checking on durations.
d311d28c
PE
2158 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2159 in size calculation.
2160 (Fexecute_kbd_macro):
2161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2162 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2163 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2164 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2165 (set_marker_both, set_marker_restricted_both, marker_position)
2166 (marker_byte_position, Fbuffer_has_markers_at):
2167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2168 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2169 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2170 It now merely ensures that the menu is large enough, without
2171 necessarily growing it, as this avoids some integer overflow issues.
2172 All callers changed.
2173 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2175 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2176 Use SAFE_ALLOCA_LISP, not alloca.
2177 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2178 to EMACS_INT. Check that fixnums are in proper range for system types.
2179 * minibuf.c (minibuf_prompt_width, string_to_object)
2180 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2181 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2183 (get_minibuffer, read_minibuf_unwind):
2184 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2185 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2186 this simplifies overflow checking. All callers changed.
2187 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2188 (Ftest_completion):
2189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2190 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2191 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2192 Check that fixnums are in proper range for system types.
2193 (Fx_create_frame, Fx_show_tip):
2194 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2195 * nsfont.m (ns_findfonts, nsfont_list_family):
2196 Don't assume fixnum fits in long.
2197 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2198 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2199 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2200 wide enough.
17fdb222 2201 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2203 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2204 (PRINTDECLARE, PRINTPREPARE):
2205 (strout, print_string):
2206 (print, print_preprocess, print_check_string_charset_prop)
2207 (print_object):
2208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2209 (PRINTDECLARE):
2210 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2211 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2212 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2213 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2214 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2215 (print_error_message): Use SAFE_ALLOCA, not alloca.
2216 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2217 (print_depth, new_backquote_output, print_number_index):
2218 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2219 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2220 (Fset_process_window_size, Fformat_network_address)
2221 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2222 (sigchld_handler):
d311d28c 2223 Check that fixnums are in proper range for system types.
d44287d4 2224 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2225 Check for process-ids out of pid_t range rather than relying on
2226 undefined behavior.
e4d81efc 2227 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2228 (Fformat_network_address, read_process_output, send_process)
2229 (Fprocess_send_region, status_notify):
2230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2231 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2232 (wait_reading_process_output, read_process_output, exec_sentinel):
2233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2234 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2235 (Faccept_process_output): Use duration_to_sec_usec to do proper
2236 overflow checking on durations.
dde14581
PE
2237 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2238 Don't assume pid_t fits in int.
02481186
PE
2239 * process.h (struct Lisp_Process): Members tick and update_tick
2240 are now of type EMACS_INT, not int.
b62b53e8
PE
2241 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2242 configured --with-wide-int.
d311d28c
PE
2243 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2244 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2245 * search.c (looking_at_1, string_match_1):
2246 (fast_string_match, fast_c_string_match_ignore_case)
2247 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2248 (scan_newline, find_before_next_newline, search_command)
2249 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2250 (set_search_regs, wordify):
2251 (Freplace_match):
2252 (Fmatch_data):
2253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2254 (string_match_1, search_buffer, set_search_regs):
2255 (Fmatch_data):
2256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2257 (wordify): Check for overflow in size calculation.
2258 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2259 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2260 Check that fixnums are in proper range for system types.
2261 * sound.c (struct sound_device)
2262 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2264 (Fplay_sound_internal):
2265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2266 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2267 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2268 (Fparse_partial_sexp):
2269 Don't assume fixnums can fit in int.
2270 (struct lisp_parse_state, find_start_pos, find_start_value)
2271 (find_start_value_byte, find_start_begv)
2272 (update_syntax_table, char_quoted, dec_bytepos)
2273 (find_defun_start, prev_char_comend_first, back_comment):
2274 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2275 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2277 (Finternal_describe_syntax_value): Check that match_lisp is a
2278 character, not an integer, since the code stuffs it into int.
2279 (scan_words, scan_sexps_forward):
2280 Check that fixnums are in proper range for system types.
2281 (Fforward_word):
2282 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2283 (scan_sexps_forward):
2284 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2285 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2286 * syntax.h: Adjust decls to match defn changes elsewhere.
2287 (struct gl_state_s):
2288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2289 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2290 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2291 * sysdep.c (wait_for_termination_1, wait_for_termination)
2292 (interruptible_wait_for_termination, mkdir):
2293 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2294 (emacs_read, emacs_write):
2295 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2296 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2297 and double all fit in int.
d311d28c
PE
2298 * term.c (set_tty_color_mode):
2299 Check that fixnums are in proper range for system types.
2300 * termhooks.h (struct input_event):
2301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2302 * textprop.c (validate_interval_range, interval_of)
2303 (Fadd_text_properties, set_text_properties_1)
2304 (Fremove_text_properties, Fremove_list_of_text_properties)
2305 (Ftext_property_any, Ftext_property_not_all)
2306 (copy_text_properties, text_property_list, extend_property_ranges)
2307 (verify_interval_modification):
2308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2309 (Fnext_single_char_property_change)
2310 (Fprevious_single_char_property_change):
2311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2312 (copy_text_properties):
2313 Check for integer overflow in index calculation.
d311d28c
PE
2314 * undo.c (last_boundary_position, record_point, record_insert)
2315 (record_delete, record_marker_adjustment, record_change)
2316 (record_property_change):
2317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2318 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2319 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2320 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2321 (Fx_hide_tip, Fx_file_dialog):
2322 * w32menu.c (set_frame_menubar):
2323 Use ptrdiff_t, not int, for consistency with rest of code.
2324 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2325 (select_window, Fdelete_other_windows_internal)
2326 (window_scroll_pixel_based, window_scroll_line_based)
2327 (Frecenter, Fset_window_configuration):
2328 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2329 (Fset_window_hscroll, run_window_configuration_change_hook)
2330 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2331 (Fscroll_other_window, Frecenter):
d311d28c
PE
2332 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2333 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2334 Don't assume fixnum fits in int.
2335 (Fset_window_scroll_bars):
2336 Check that fixnums are in proper range for system types.
2337 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2338 (string_pos, c_string_pos, number_of_chars, init_iterator)
2339 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2340 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2341 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2342 (face_before_or_after_it_pos, handle_invisible_prop)
2343 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2344 (display_prop_intangible_p, string_buffer_position_lim)
2345 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2346 (get_overlay_strings_1, get_overlay_strings)
2347 (iterate_out_of_display_property, forward_to_next_line_start)
2348 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2349 (get_next_display_element, set_iterator_to_next)
2350 (get_visually_first_element, compute_stop_pos_backwards)
2351 (handle_stop_backwards, next_element_from_buffer)
2352 (move_it_in_display_line_to, move_it_in_display_line)
2353 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2354 (add_to_log, message_dolog, message_log_check_duplicate)
2355 (message2, message2_nolog, message3, message3_nolog
2356 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2357 (current_message_1, truncate_echo_area, truncate_message_1)
2358 (set_message, set_message_1, store_mode_line_noprop)
2359 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2360 (text_outside_line_unchanged_p, check_point_in_composition)
2361 (reconsider_clip_changes)
2362 (redisplay_internal, set_cursor_from_row, try_scrolling)
2363 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2364 (redisplay_window, find_last_unchanged_at_beg_row)
2365 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2366 (trailing_whitespace_p, find_row_edges, display_line)
2367 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2368 (display_mode_element, store_mode_line_string)
2369 (pint2str, pint2hrstr, decode_mode_spec)
2370 (display_count_lines, display_string, draw_glyphs)
2371 (x_produce_glyphs, x_insert_glyphs)
2372 (rows_from_pos_range, mouse_face_from_buffer_pos)
2373 (fast_find_string_pos, mouse_face_from_string_pos)
2374 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2376 (safe_call, init_from_display_pos, handle_fontified_prop)
2377 (handle_single_display_spec, load_overlay_strings)
2378 (with_echo_area_buffer, setup_echo_area_for_printing)
2379 (display_echo_area, echo_area_display)
2380 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2381 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2382 (redisplay_window, dump_glyph_row, display_mode_line)
2383 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2384 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2386 (handle_single_display_spec, build_desired_tool_bar_string)
2387 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2388 (get_specified_cursor_type):
2389 Check that fixnums are in proper range for system types.
2390 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2391 (Flookup_image_map):
2392 Don't assume fixnums fit in int.
2393 (compare_overlay_entries):
2394 Avoid mishandling comparisons due to subtraction overflow.
2395 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2396 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2397 (handle_tool_bar_click):
2398 Use int, not unsigned, since we prefer signed and the signedness
2399 doesn't matter here.
2400 (get_next_display_element, next_element_from_display_vector):
2401 Use int, not EMACS_INT, when int is wide enough.
2402 (start_hourglass): Use duration_to_sec_usec to do proper
2403 overflow checking on durations.
2404 * xfaces.c (Fbitmap_spec_p):
2405 Check that fixnums are in proper range for system types.
2406 (compare_fonts_by_sort_order):
2407 Avoid mishandling comparisons due to subtraction overflow.
2408 (Fx_family_fonts, realize_basic_faces):
2409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2410 (Fx_family_fonts):
2411 Don't assume fixnum fits in int.
2412 Use SAFE_ALLOCA_LISP, not alloca.
2413 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2414 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2415 (face_at_buffer_position, face_for_overlay_string)
2416 (face_at_string_position):
2417 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2418 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2419 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2420 (Fx_show_tip):
2421 Check that fixnums are in proper range for system types.
2422 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2423 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2424 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2425 (Fx_change_window_property): Don't assume fixnums fit in int.
2426 * xfont.c (xfont_chars_supported):
2427 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2428 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2429 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2431 * xml.c (parse_region):
2432 * xrdb.c (magic_file_p):
2433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2434 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2435 (x_get_local_selection, x_reply_selection_request)
2436 (x_handle_selection_request, wait_for_property_change):
2437 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2438 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2439 short is wide enough.
2440 (x_send_client_event): Don't assume fixnum fits in int.
2441 * xterm.c (x_x_to_emacs_modifiers):
2442 Don't assume EMACS_INT overflows nicely into int.
2443 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2444 may come from Lisp.
2445 (handle_one_xevent): NATNUMP can eval its arg twice.
2446 (x_connection_closed):
2447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2448 * xterm.h: Adjust decls to match defn changes elsewhere.
2449 (struct scroll_bar): Use struct vectorlike_header
2450 rather than rolling our own approximation.
2451 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2452
c6574eb5
GM
24532012-05-25 Glenn Morris <rgm@gnu.org>
2454
2455 * lisp.mk (lisp): Update for more files being compiled now.
2456
e8d32c7e
SM
24572012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2458
48def666
SM
2459 * lread.c: Remove `read_pure' which makes no difference.
2460 (read_pure): Remove var.
2461 (unreadpure): Remove function.
2462 (readevalloop): Don't call read_list with -1 flag.
2463 (read1, read_vector): Don't test read_pure any more.
2464 (read_list): Simplify.
2465
e8d32c7e
SM
2466 * fileio.c, character.h: Minor style tweaks.
2467
4b2addb7
DA
24682012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2469
2470 * window.h (clip_changed): Remove useless declaration.
2471
584461b2
JB
24722012-05-22 Juanma Barranquero <lekktu@gmail.com>
2473
2474 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2475 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2476
34374650
PE
24772012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2478
2479 Remove src/m/*.
2480 This directory predates autoconf and is no longer needed nowadays.
2481 Move its few remaining bits of functionality to where they're needed.
2482 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2483 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2484 * m/template.h: Remove.
2485 * Makefile.in (M_FILE): Remove. All uses removed.
2486 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2487 * lisp.h (USE_LSB_TAG):
2488 * mem-limits.h (EXCEEDS_LISP_PTR):
2489 Use VAL_MAX, not VALBITS, in #if.
2490 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2491 (EMACS_UINT): Define unconditionally now.
2492 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2493 (BITS_PER_EMACS_INT): New constants, replacing
2494 what used to be in config.h, but not useful in #if.
2495 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2496 define them any more.
2497 (VAL_MAX): New macro.
2498 (VALMASK): Use it.
2499 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2500 BITS_PER_EMACS_INT, in #if.
2501 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2502 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2503 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2504 * s/ms-w32.h (DATA_START):
2505 Move here from removed file m/intel386.h.
2506 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2507 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2508
261cb4bb
PE
25092012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2510
2511 Assume C89 or later.
2512 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2513 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2514 (xrealloc):
2515 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2516 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2517 * textprop.c, tparam.c (NULL): Remove.
2518 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2519 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2520 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2521 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2522 * xterm.c (input_signal_count): Assume volatile works.
2523
ff23cd9f
KB
25242012-05-21 Ken Brown <kbrown@cornell.edu>
2525
2526 * xgselect.c (xg_select): Fix first argument in call to 'select'
2527 (bug#11508).
2528
1b170bc6
KB
25292012-05-20 Ken Brown <kbrown@cornell.edu>
2530
2531 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2532 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2533
b2f4d39f
KB
25342012-05-19 Ken Brown <kbrown@cornell.edu>
2535
2536 * xfns.c (x_in_use): Remove `static' qualifier.
2537 * xterm.h (x_in_use): Declare.
2538 * xgselect.c: Include xterm.h.
2539 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2540 and `display_arg' (bug#9754).
2541
003fdae2
PE
25422012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2543
9232a6d9
PE
2544 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2545
003fdae2
PE
2546 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2547 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2548
784b56e2
EZ
25492012-05-18 Eli Zaretskii <eliz@gnu.org>
2550
2551 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2552
2553 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2554 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2555
2556 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2557 reference to image_cache->refcount.
2558 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2559
a0a79cde
JL
25602012-05-17 Juri Linkov <juri@jurta.org>
2561
2562 * search.c (Fword_search_regexp, Fword_search_backward)
2563 (Fword_search_forward, Fword_search_backward_lax)
2564 (Fword_search_forward_lax): Move functions to isearch.el
2565 (bug#10145, bug#11381).
2566
b0572523
PE
25672012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2568
2569 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2570
9660f5fc
SM
25712012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2572
2573 * lread.c (init_obarray): Declare Qt and Qnil as special.
2574
4374de83
GM
25752012-05-14 Glenn Morris <rgm@gnu.org>
2576
2577 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2578 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2579
dc44c39a
PE
25802012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2581
078c97cb
PE
2582 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2583
dc44c39a
PE
2584 * unexaix.c: Port to more-recent AIX compilers.
2585 (report_error, report_error_1, make_hdr, copy_sym)
2586 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2587 Make arguments const char *, not char *, to avoid violations of C
2588 standard and to fix some AIX warnings reported by Gilles Pion.
2589
e18afed7 25902012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2591
2592 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2593 already have overlays loaded.
2594 (handle_single_display_spec): Before returning without displaying
2595 fringe bitmap, synchronize the bidi iterator with the main display
2596 iterator, by calling iterate_out_of_display_property.
2597 (iterate_out_of_display_property): Detect buffer iteration by
2598 testing that it->string is a Lisp string.
2599 (get_next_display_element): When the current object is exhausted,
2600 and there's something on it->stack, call set_iterator_to_next to
2601 proceed with what's on the stack, instead of returning zero.
2602 (set_iterator_to_next): If called at the end of a Lisp string,
2603 proceed to consider_string_end without incrementing string
2604 position. Don't increment display vector index past the end of
2605 the display vector. (Bug#11417)
c8fb9dc6
EZ
2606 (pos_visible_p): Don't report a position visible when move_it_to
2607 stopped at the last line of window, which happens to be scanned
2608 backwards by the bidi iteration. (Bug#11464)
ac268e67 2609
e18afed7 26102012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2611
2612 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2613 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2614 are on a TTY, and thus unable to display on the fringes.
2615 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2616 so we need to signal to the caller that this is a "replacing"
2617 display spec. This fixes display when the spec is invalid or we
2618 are on a TTY.
2619
e18afed7 26202012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2621
2622 * unexaix.c (make_hdr): Fix typo in prototype.
2623 This bug broke the build on AIX. Problem reported by Gilles Pion.
2624
9d0a235a
MA
26252012-05-14 Michael Albinus <michael.albinus@gmx.de>
2626
2627 * keyboard.c (kbd_buffer_get_event): Read special events also in
2628 batch mode. (Bug#11415)
2629
9e6b06ed
GM
26302012-05-12 Glenn Morris <rgm@gnu.org>
2631
2632 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2633
c1a1d7a3
EZ
26342012-05-12 Eli Zaretskii <eliz@gnu.org>
2635
2636 * lisp.mk (lisp): Add newcomment.elc.
2637
3fe7cdc8
GM
26382012-05-12 Glenn Morris <rgm@gnu.org>
2639
2640 * Makefile.in (MKDIR_P): New, set by configure.
2641 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2642
53f7d2c0
PE
26432012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2644
2645 Remove unused function hourglass_started.
2646 * dispextern.h (hourglass_started):
2647 * w32fns.c (hourglass_started):
2648 * xdisp.c (hourglass_started): Remove.
2649
75aafb17
JB
26502012-05-10 Juanma Barranquero <lekktu@gmail.com>
2651
2652 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2653 Update dependencies.
2654
12959e8e
PE
26552012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2656
97107e2e
PE
2657 * xgselect.c (xg_select): Put maxfds+1 into a var.
2658 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2659
12959e8e
PE
2660 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2661
836d29b3
DA
26622012-05-10 Dave Abrahams <dave@boostpro.com>
2663
2664 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2665 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2666
5cb67954
MA
26672012-05-09 Michael Albinus <michael.albinus@gmx.de>
2668
2669 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2670 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2671 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2672 Initialize xd_registered_buses.
2673
3478ec45
PE
26742012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2675
b263a6b0
PE
2676 Untag more efficiently if USE_LSB_TAG.
2677 This is based on a proposal by YAMAMOTO Mitsuharu in
2678 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2679 For an admittedly artificial (nth 8000 longlist) benchmark on
2680 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2681 Emacs's overall text size by 1%.
2682 * lisp.h (XUNTAG): New macro.
2683 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2684 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2685 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2686 * eval.c (Fautoload):
2687 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2688 * frame.h (XFRAME): Use XUNTAG.
2689
3478ec45
PE
2690 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2691 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2692 Remove unportable assumptions about print widths of types like
2693 dbus_uint32_t.
2694 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2695 intptr_t when converting between pointer and integer, to avoid GCC
2696 warnings about wrong width.
2697
666b903b 26982012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2699
2700 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2701 stack for each reader_thread, instead of defaulting to 8MB
2702 determined by the linker. This avoids failures in creating
2703 subprocesses on Windows 7, see the discussion in this thread:
2704 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2705
b120cc17
JC
27062012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2707
2708 Fix up display of the *Minibuf-0* buffer in the mini window.
2709 * keyboard.c (read_char): Don't clear the echo area if there's no
2710 message to clear.
2711 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2712 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2713
9a4b36f8
MA
27142012-05-07 Michael Albinus <michael.albinus@gmx.de>
2715
2716 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2717 batch mode.
2718
e5f9458f
CY
27192012-05-06 Chong Yidong <cyd@gnu.org>
2720
2721 * lisp.mk (lisp): Update.
2722
eceeb5fc 27232012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2724
2725 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2726
71873e2b
SM
27272012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2728
2729 * data.c (PUT_ERROR): New macro.
2730 (syms_of_data): Use it. Add new error type `user-error'.
2731 * undo.c (user_error): New function.
2732 (Fprimitive_undo): Use it.
2733 * print.c (print_error_message): Adjust print style for `user-error'.
2734 * keyboard.c (user_error): New function.
2735 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2736
ab0fa4e4
PE
27372012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2738
2739 Do not limit current-time-string to years 1000..9999.
2740 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2741 (Fcurrent_time_string): Support any year that is supported by the
2742 underlying localtime representation. Don't use asctime, as it
2743 has undefined behavior for years outside the range -999..9999.
2744
7ed806a7
PE
27452012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2746
2747 Fix race conditions involving setenv, gmtime, localtime, asctime.
2748 Without this fix, interrupts could mess up code that uses these
2749 nonreentrant functions, since setting TZ invalidates existing
2750 tm_zone or tzname values, and since most of these functions return
2751 pointers to static storage.
2752 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2753 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2754 Grow the critical sections to include not just invoking
2755 localtime/gmtime, but also accessing these functions' results
2756 including their tm_zone values if any, and any related TZ setting.
2757 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2758 so that the struct tm is saved in the critical section.
2759 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2760 motivated by the fact that memory allocation needs to be outside
2761 the critical section.
2762
0c16dfed
DA
27632012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2764
2765 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2766 with RESET_INTERVAL.
2767
2768 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2769 Remove duplicated buffer name initialization.
2770
3f83ace8
JM
27712012-05-02 Jim Meyering <jim@meyering.net>
2772
2773 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2774
c7b8541e
JM
2775 * xfns.c (x_window): Use xstrdup (Bug#11375).
2776
90207a15 27772012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2778
2779 * xdisp.c (pos_visible_p): If already at a newline from the
2780 display string before the 'while' loop, don't walk back the glyphs
2781 from it3.glyph_row. Solves assertion violation when the display
2782 string begins with a newline (egg.el). (Bug#11367)
2783
b593d6a9
AH
27842012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2785
2786 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2787 Move to simple.el.
2788
4737362e
GM
27892012-05-01 Glenn Morris <rgm@gnu.org>
2790
99cf43f9
GM
2791 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2792 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2793 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2794 All were removed before 23.1.
2795
9311dcff
GM
2796 * dispnew.c: Remove HAVE_LIBNCURSES test;
2797 it is always true on relevant platforms.
2798
4d5c6349
GM
2799 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2800 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2801
4737362e
GM
2802 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2803
74dd3a6b
AS
28042012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2805
2806 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2807 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2808 Remove.
2809
13c379ee
PE
28102012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2811
2812 Do not avoid creating empty evaporating overlays (Bug#9642).
2813 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2814 That is, do not delete an evaporating overlay if it becomes
2815 empty after its bounds are adjusted to fit within its buffer.
2816 This fix caused other problems, and I'm reverting it until we get
2817 to the bottom of them.
2818
a8e7d6d7 28192012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2820
2821 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2822
a8e7d6d7 28232012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2824
2825 * xdisp.c (pos_visible_p): If the window start position is beyond
2826 ZV, start the display from buffer beginning. Prevents assertion
2827 violation in init_iterator when the minibuffer window is scrolled
2828 via the scroll bar.
2829
2830 * window.c (window_scroll_pixel_based): Likewise.
2831
a8e7d6d7 28322012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2833
2834 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2835
a8e7d6d7 28362012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2837
2838 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2839 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2840
a8e7d6d7 28412012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2842
b593d6a9
AH
2843 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2844 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2845
1c6900d9
EZ
28462012-04-26 Eli Zaretskii <eliz@gnu.org>
2847
4c3fa1d9
EZ
2848 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2849 display element, check also the underlying string or buffer
2850 character. (Bug#11341)
2851
1c6900d9
EZ
2852 * w32menu.c: Include w32heap.h.
2853 (add_menu_item): If the call to AppendMenuW (via
2854 unicode_append_menu) fails, disable Unicode menus only if we are
2855 running on Windows 9X/Me.
2856
42bf8205
AS
28572012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2858
2859 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2860 (xgetint): Add missing shift for LSB tags.
2861
b1bac16e
MR
28622012-04-24 Martin Rudalics <rudalics@gmx.at>
2863
2864 * keyboard.c (read_char): Don't wipe echo area for select window
2865 events: These might get delayed via `mouse-autoselect-window'
2866 (Bug#11304).
2867
d69621cc
JB
28682012-04-24 Juanma Barranquero <lekktu@gmail.com>
2869
2870 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2871 manipulation of :loaded-from data.
2872
02fd101b
JB
28732012-04-23 Juanma Barranquero <lekktu@gmail.com>
2874
2875 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2876 now a cons (bug#11311).
2877
888bec30
PE
28782012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2879
89a438bd
PE
2880 Do not create empty overlays with the evaporate property (Bug#9642).
2881 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2882 if it becomes empty after its bounds are adjusted to fit within
2883 its buffer. Without this fix, in a nonempty buffer (let ((o
2884 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2885 yields an empty overlay that has the evaporate property, which is
2886 not supposed to happen.
2887
1068fe4d
PE
2888 Fix minor GTK3 problems found by static checking.
2889 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2890 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2891 (struct _EmacsFixedClass, emacs_fixed_get_type):
2892 Move decls here from emacsgtkfixed.h, since they needn't be public.
2893 (emacs_fixed_get_type): Now static.
2894 (emacs_fixed_class_init): Omit unused local.
2895 (emacs_fixed_child_type): Remove; unused.
2896 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2897 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2898 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2899 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2900 (EMACS_FIXED_GET_CLASS): Remove; unused.
2901 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2902
888bec30
PE
2903 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2904 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2905
de85e130
PE
29062012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2907
d0baac98 2908 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2909 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2910 (__malloc_size_t, __malloc_ptrdiff_t):
2911 Remove. All uses removed, replaced by the definiens if needed,
2912 since we can assume C89 or better now.
2913 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2914 (protect_malloc_state, align, get_contiguous_space)
2915 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2916 (malloc_atfork_handler_child, malloc_enable_thread)
2917 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2918 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2919 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2920 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2921 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2922 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2923 Define using prototypes, not old style.
2924 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2925 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2926 (align): Don't assume that signed integer overflow wraps around.
2927 Omit unused local var.
2928 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2929 (_free_internal_nolock, memalign, mallochook, reallochook):
2930 Omit no-longer-needed casts.
2931 (valloc): Use getpagesize, not __getpagesize.
2932 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2933 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2934
de85e130
PE
2935 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2936
dcbf5805
MA
29372012-04-22 Michael Albinus <michael.albinus@gmx.de>
2938
2939 Move functions from C to Lisp. Make non-blocking method calls
2940 the default. Implement further D-Bus standard interfaces.
2941
2942 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2943 (QCdbus_request_name_allow_replacement)
2944 (QCdbus_request_name_replace_existing)
2945 (QCdbus_request_name_do_not_queue)
2946 (QCdbus_request_name_reply_primary_owner)
2947 (QCdbus_request_name_reply_in_queue)
2948 (QCdbus_request_name_reply_exists)
2949 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2950 (QCdbus_registered_serial, QCdbus_registered_method)
2951 (QCdbus_registered_signal): New Lisp objects.
2952 (XD_DEBUG_MESSAGE): Use sizeof.
2953 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2954 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2955 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2956 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2957 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2958 (xd_signature, xd_append_arg): Allow float for integer types.
2959 (xd_get_connection_references): New function.
b593d6a9
AH
2960 (xd_get_connection_address): Rename from xd_initialize.
2961 Return cached address.
dcbf5805
MA
2962 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2963 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2964 level.
2965 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2966 Return number of refcounts.
dcbf5805
MA
2967 (Fdbus_get_unique_name): Make stronger parameter check.
2968 (Fdbus_message_internal): New defun.
2969 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2970 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2971 (Fdbus_send_signal, Fdbus_register_service)
2972 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2973 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2974 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2975 (Vdbus_compiled_version, Vdbus_runtime_version)
2976 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2977 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2978 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2979 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2980 Adapt docstring.
dcbf5805 2981
52828e02
PE
29822012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2983
da05bc4c
PE
2984 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2985 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2986 Do not assume ptrdiff_t is the same width as 'int'.
2987
52828e02
PE
2988 * alloc.c: Handle unusual debugging option combinations.
2989 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2990 since the two debugging options are incompatible.
2991 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2992 is defined.
2993 (mem_init, mem_insert, mem_insert_fixup):
2994 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2995 (NEED_MEM_INSERT): Remove; no longer needed.
2996
f01769f9
LL
29972012-04-22 Leo Liu <sdl.web@gmail.com>
2998
2999 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3000
5790543d
PE
30012012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3002
3003 * sysdep.c [__FreeBSD__]: Minor cleanups.
3004 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3005 Use Emacs indenting style more consistently. Avoid some casts.
3006 Use 'double' consistently rather than mixing 'float' and 'double'.
3007
b91b7e4d
EW
30082012-04-21 Eduard Wiebe <usenet@pusto.de>
3009
b593d6a9
AH
3010 * sysdep.c (list_system_processes, system_process_attributes):
3011 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3012
6114eb15
AS
30132012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3014
3015 * lisp.mk (lisp): Update.
3016
2f38dff7
PE
30172012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3018
3019 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3020 It is never used otherwise.
3021
4ae29f89
SM
30222012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3023
3024 * print.c (print_preprocess): Only check print_depth if print-circle
3025 is nil.
3026 (print_object): Check for cycles even when print-circle is nil and
3027 print-gensym is t, but only check print_depth if print-circle is nil.
3028
f30d612a
CY
30292012-04-20 Chong Yidong <cyd@gnu.org>
3030
3031 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3032 set the status to "failed" and ensure that sentinel is run.
3033
c07a4c0b 30342012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3035
3036 * process.c (Fset_process_inherit_coding_system_flag)
3037 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3038 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3039
c07a4c0b 30402012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3041
3042 * xdisp.c (string_buffer_position_lim): Limit starting position to
3043 BEGV.
3044 (set_cursor_from_row): If called for a mode-line or header-line
3045 row, return zero immediately.
3046 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3047 farther than the first row after the header line, if any.
3048 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3049 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3050
c07a4c0b 30512012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3052
4ae29f89
SM
3053 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3054 (bug#11238).
ad3a2b41 3055
c07a4c0b 30562012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 30572012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3058
3059 configure: new option --enable-gcc-warnings (Bug#11207)
3060 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3061 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3062 (ALL_CFLAGS): Use new macros rather than old.
3063 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3064 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3065 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3066 -Wunused-result, -Wunused-variable. This should go away once
3067 the Emacs and Gnulib regex code is merged.
3068 (xmalloc, xrealloc): Now static.
3069
aba027e8
PE
30702012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3071
3072 * dired.c (Fsystem_groups): Remove unused local.
3073
e5a36063
GM
30742012-04-17 Glenn Morris <rgm@gnu.org>
3075
3076 * dired.c (Fsystem_users): Doc fix.
3077
316411f0
DA
30782012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3079
3080 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3081 (syms_of_dired): Add them.
3082
9426aba4
PE
30832012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3084
b62a57be
PE
3085 Fix minor alloc.c problems found by static checking.
3086 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3087 New extern decls, to avoid calling undeclared functions.
3088 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3089 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3090 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3091 (NEED_MEM_INSERT): New macro.
3092 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3093 Remove one incorrect comment and fix another.
b62a57be 3094
3539f31f
PE
3095 Fix minor ralloc.c problems found by static checking.
3096 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3097 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3098 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3099 (r_alloc_sbrk): Now static.
3100
a041960a
PE
3101 Improve ralloc.c interface checking.
3102 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3103 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3104 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3105 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3106 [REL_ALLOC]: ... to here, to check interface.
3107 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3108 Remove decls. This fixes an "It stinks!".
3109
9426aba4
PE
3110 * alloc.c (which_symbols): Fix alignment issue / type clash.
3111
d55c12ed
AS
31122012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3113
3114 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3115 (struct Lisp_Misc_Any): Likewise.
3116 (struct Lisp_Free): Likewise.
3117 * alloc.c (union aligned_Lisp_Symbol): Define.
3118 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3119 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3120 (union aligned_Lisp_Misc): Define.
3121 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3122 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3123 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3124
b948ce8b
PE
31252012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3126
3127 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3128 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3129 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3130 * s/netbsd.h, s/sol2-6.h:
3131 Remove definition of GC_MARK_STACK, since the default now works.
3132 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3133 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3134 no longer the default.
3135 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3136
35dc09a1 31372012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3138
35dc09a1
GM
3139 * lread.c (lisp_file_lexically_bound_p):
3140 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3141
35dc09a1
GM
31422012-04-14 Eli Zaretskii <eliz@gnu.org>
3143
3144 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3145 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3146
31472012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3148
3149 * nsterm.m (constrainFrameRect): Always constrain when there is only
3150 one screen (Bug#10962).
3151
bcd86815
KB
31522012-04-13 Ken Brown <kbrown@cornell.edu>
3153
3154 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3155
c25df26e
RT
31562012-04-13 Reuben Thomas <rrt@sc3d.org>
3157
3158 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3159
0fc59f1e
DC
31602012-04-11 Daniel Colascione <dancol@dancol.org>
3161
3162 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3163 against is gone. It's better to use vfork now so that when Cygwin
3164 gains a new, working vfork, we use it automatically (bug#10398).
3165
de8c03dc
SM
31662012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3167
3168 * window.c (save_window_save): Obey window-point-insertion-type.
3169
2f097256
GM
31702012-04-11 Glenn Morris <rgm@gnu.org>
3171
3172 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3173
453b951e
SM
31742012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3175
3176 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3177
75f1671a 31782012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3179
3180 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3181 (force_quit_count): New var.
3182 (handle_interrupt): Use it.
3183
2a8ce227
JB
31842012-04-10 Juanma Barranquero <lekktu@gmail.com>
3185
3186 * w32.c (w32_delayed_load): Record the full path of the library
3187 being loaded (bug#10424).
3188
935396c0
GM
31892012-04-09 Glenn Morris <rgm@gnu.org>
3190
05920a43
GM
3191 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3192 not just in the obarray, before snarfing them. (Bug#11036)
3193
935396c0
GM
3194 * Makefile.in ($(leimdir)/leim-list.el):
3195 Pass EMACS rather than BUILT_EMACS.
3196
a18ecafa
TZ
31972012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3198
3199 * process.c (make_process):
3200 * process.h: Add integer `gnutls_handshakes_tried' member to
3201 process struct.
3202
6bbef4e5
JC
3203 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3204 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3205
3206 * gnutls.c (gnutls_log_function2i): Convenience log function.
3207 (emacs_gnutls_read): Use new log functions,
3208 `gnutls_handshakes_tried' process member, and
3209 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3210 attempts per process (connection).
3211
b4d3bc10
CY
32122012-04-09 Chong Yidong <cyd@gnu.org>
3213
3214 * eval.c (Fuser_variable_p, user_variable_p_eh)
3215 (lisp_indirect_variable): Functions deleted.
3216 (Fdefvar): Caller changed.
3217
3218 * callint.c (Finteractive, Fcall_interactively):
3219 * minibuf.c (Fread_variable): Callers changed.
3220
70f4d973
EZ
32212012-04-09 Eli Zaretskii <eliz@gnu.org>
3222
3223 * xdisp.c (set_cursor_from_row): If the display string appears in
3224 the buffer at position that is closer to point than the position
3225 after the display string, display the cursor on the first glyph of
3226 the display string. Fixes cursor display when a 'display' text
3227 property immediately follows invisible text. (Bug#11094)
3228
cb3c2e3e
PE
32292012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3230
3231 composite.c: use 'double' consistently
3232 * composite.c (get_composition_id): Use 'double' consistently
3233 instead of converting 'float' to 'double' and vice versa; this is
3234 easier to understand and avoids a GCC warning.
3235
fd06db5d
GM
32362012-04-09 Glenn Morris <rgm@gnu.org>
3237
50fe702a
GM
3238 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3239 preparation for dumping it with emacs. (Bug#4789)
3240 (leimdir): New variable.
3241 ($(leimdir)/leim-list.el): New rule.
3242 (emacs$(EXEEXT)): Depend on leim-list.el.
3243
fd06db5d
GM
3244 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3245 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3246 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3247
55c131ee
AS
32482012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3249
3250 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3251 proper alignment.
3252
9209588f
JB
32532012-04-07 Juanma Barranquero <lekktu@gmail.com>
3254
3255 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3256 Remove unused local variable.
3257
e3fb2efb
PE
32582012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3259
3260 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3261 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3262 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3263 objects, as mark_maybe_pointer will catch them otherwise.
3264 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3265 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3266
b5385551
PE
32672012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3268
3269 Fix typo that broke non-Windows builds.
3270 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3271
9078ead6
EZ
32722012-04-07 Eli Zaretskii <eliz@gnu.org>
3273
3274 Support building on MS-Windows with libxml2.
3275
3276 * makefile.w32-in (OBJ2): Add xml.$(O).
3277 (GLOBAL_SOURCES): Add xml.c.
3278 ($(BLD)/xml.$(O)): New dependency list.
3279
3280 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3281 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3282 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3283 [!WINDOWSNT]: New macros.
3284 (init_libxml2_functions, libxml2_loaded_p): New functions.
3285 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3286 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3287 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3288 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3289 linked in).
6bbef4e5
JC
3290 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3291 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3292 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3293
3294 * emacs.c: Don't include libxml/parser.h.
3295 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3296 xmlCleanupParser directly.
3297
3298 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3299
3811fdf3
EZ
33002012-04-07 Eli Zaretskii <eliz@gnu.org>
3301
3302 * indent.c (Fvertical_motion): If there is a display string at
3303 point, use it.vpos to compute how many lines to backtrack after
3304 move_it_to point. (Bug#11133)
3305
2f8e16b2
EZ
33062012-04-06 Eli Zaretskii <eliz@gnu.org>
3307
3308 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3309 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3310 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3311 macros related to unification of CJK characters. For the details,
3312 see the discussion following the message here:
3313 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3314
3d439cd1
CY
33152012-04-04 Chong Yidong <cyd@gnu.org>
3316
3317 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3318
8bc53d00
EZ
33192012-04-01 Eli Zaretskii <eliz@gnu.org>
3320
3321 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3322 instead of alloca. (Bug#11138)
3323
3b0512a3
AS
33242012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3325
3326 * w32menu.c (is_simple_dialog): Properly check lisp types.
3327 (Bug#11141)
3328
8427ddd2
EZ
33292012-03-31 Eli Zaretskii <eliz@gnu.org>
3330
979022ef
EZ
3331 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3332 position we get to after a call to move_it_to fails the
3333 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3334 only if we wind up in a string from display property. (Bug#11063)
3335
a6b1c7cc
EZ
3336 * window.c (Fdelete_other_windows_internal): Invalidate the row
3337 and column information about mouse highlight, so that redisplay
3338 restores it after reallocating the glyph matrices. (Bug#7464)
3339
8427ddd2
EZ
3340 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3341 string comes from a `display' text property, use the buffer
3342 position of that property as if we actually saw that position in
3343 the row's glyphs.
697ba24b
EZ
3344 (move_it_by_lines): Remove the assertion that
3345 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3346 violated when there's a before-string at the beginning of a line.
3347 (Bug#11063)
8427ddd2 3348
65a0a738
EZ
33492012-03-30 Eli Zaretskii <eliz@gnu.org>
3350
3351 * xdisp.c (append_space_for_newline): If the default face was
3352 remapped, use the remapped face for the appended newline.
3353 (extend_face_to_end_of_line): Use the remapped default face for
3354 extending the face to the end of the line.
3355 (display_line): Call extend_face_to_end_of_line when the default
3356 face was remapped. (Bug#11068)
3357
581355cc
EZ
33582012-03-29 Eli Zaretskii <eliz@gnu.org>
3359
3360 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3361
e8fc049f
SM
33622012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3363
3364 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3365
4fb9a543
GM
33662012-03-27 Glenn Morris <rgm@gnu.org>
3367
3368 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3369 Doc fixes.
3370
679910f1
KH
33712012-03-26 Kenichi Handa <handa@m17n.org>
3372
3373 * dispextern.h (struct glyph): Fix previous change. Change the
3374 bit length of glyphless.ch to 25 (Bug#11082).
3375
90d49b7f
CY
33762012-03-26 Chong Yidong <cyd@gnu.org>
3377
3378 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3379 (command_loop_1): Use it; inhibit selection update for
3380 handle-select-window too (Bug#8996).
3381
f514f6f0
FP
33822012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3383
e8fc049f 3384 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3385
bf43fa51
KH
33862012-03-25 Kenichi Handa <handa@m17n.org>
3387
3388 * dispextern.h (struct glyph): Change the bit length of
3389 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3390
8a0c01dd
EZ
33912012-03-24 Eli Zaretskii <eliz@gnu.org>
3392
3393 * s/ms-w32.h (tzname): Include time.h before redirecting to
3394 _tzname. Fixes the MSVC build. (Bug#9960)
3395
7d1c3a76
AS
33962012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3397
8ed79523
AS
3398 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3399 characters.
3400
7d1c3a76
AS
3401 * xterm.c (XTread_socket): Only modify handling_signal if
3402 !SYNC_INPUT. (Bug#11080)
3403
e99a9b8b
EZ
34042012-03-23 Eli Zaretskii <eliz@gnu.org>
3405
3406 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3407 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3408 when fetching a multibyte character consumes more bytes than
3409 CHAR_BYTES returns, due to unification of CJK characters in
3410 string_char. (Bug#11073)
3411
5063c0e1
TN
34122012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3413
3414 * process.c (wait_reading_process_output): Handle pty disconnect
3415 by refraining from sending oneself a SIGCHLD (bug#10933).
3416
9f851fbd
CY
34172012-03-22 Chong Yidong <cyd@gnu.org>
3418
3419 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3420
5063c0e1 3421 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3422 Mark string as coming from a prefix property.
3423 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3424 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3425
fb5b8aca
CY
34262012-03-21 Chong Yidong <cyd@gnu.org>
3427
3428 * xfaces.c (Vface_remapping_alist): Doc fix.
3429
62356a1b
EZ
34302012-03-20 Eli Zaretskii <eliz@gnu.org>
3431
3432 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3433 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3434 Doc fixes.
62356a1b 3435
025de85b
CY
34362012-03-20 Chong Yidong <cyd@gnu.org>
3437
3438 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3439 to reflect default non-nil value of redisplay-dont-pause.
3440
4827f94e
KH
34412012-03-19 Kenichi Handa <handa@m17n.org>
3442
3443 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3444 it fit in a valid range (Bug#11003).
3445
e50a24a2
EZ
34462012-03-18 Eli Zaretskii <eliz@gnu.org>
3447
3448 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3449 that is not from display property, accept the row as a "cursor
3450 row" if one of the string's character has a non-nil `cursor'
3451 property. Fixes cursor positioning when there are newlines in
3452 overlay strings, e.g. in icomplete.el. (Bug#11035)
3453
9af5ed87
PE
34542012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3455
3456 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3457
d1f55f16
CY
34582012-03-12 Chong Yidong <cyd@gnu.org>
3459
3460 * eval.c (inhibit_lisp_code): Rename from
3461 inhibit_window_configuration_change_hook; move from window.c.
3462
3463 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3464 * window.c (run_window_configuration_change_hook)
3465 (syms_of_window): Callers changed.
3466
66c5eebd
CY
34672012-03-11 Chong Yidong <cyd@gnu.org>
3468
413df973
CY
3469 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3470
66c5eebd
CY
3471 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3472
1de11f56
CY
34732012-03-10 Chong Yidong <cyd@gnu.org>
3474
3475 * frame.c (other_visible_frames): Don't assume the selected frame
3476 is visible (Bug#10955).
3477
cae07000
SM
34782012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3479
3480 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3481
89c94350
JD
34822012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3483
3484 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3485 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3486 zero (Bug#10954).
3487
999dd333
GM
34882012-03-03 Glenn Morris <rgm@gnu.org>
3489
01a6dcc8 3490 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3491
de0100f2
EZ
34922012-03-02 Eli Zaretskii <eliz@gnu.org>
3493
3494 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3495 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3496 (redisplay_window, next_element_from_string): Fix typos in
3497 comments.
3e441275
EZ
3498 (redisplay_window): Pass to move_it_vertically the margin in
3499 pixels, not in screen lines.
de0100f2 3500
96a72ee9
GM
35012012-03-02 Glenn Morris <rgm@gnu.org>
3502
3503 * buffer.c (buffer-list-update-hook): Doc fix.
3504
312508d7
EZ
35052012-02-29 Eli Zaretskii <eliz@gnu.org>
3506
3507 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3508 push_it before setting up the iterator for the first overlay
3509 string, even if we have an empty string loaded.
3510 (next_overlay_string): If there's an empty string on the iterator
3511 stack, pop the stack. (Bug#10903)
3512
27f3c637
PE
35132012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3514
3515 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3516 Suggested by Stefan Monnier in
3517 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3518 * alloc.c (widen_to_Lisp_Object): New static function.
3519 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3520 and widening them to Lisp_Objects. This would work even if
3521 USE_LSB_TAG is defined and wide integers are used, which might
3522 happen in a future version of Emacs.
3523
3c9dfce6
CY
35242012-02-25 Chong Yidong <cyd@gnu.org>
3525
fa74b241
CY
3526 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3527 Doc fix.
3528
3c9dfce6
CY
3529 * xselect.c (Fx_selection_exists_p): Doc fix.
3530 (x_clipboard_manager_save_all): Print an informative message
3531 before saving to clipboard manager.
3532
9486df08
CY
35332012-02-24 Chong Yidong <cyd@gnu.org>
3534
3535 * keyboard.c (process_special_events): Handle all X selection
3536 requests in kbd_buffer, not just the next one (Bug#8869).
3537
f01d3321
CY
35382012-02-23 Chong Yidong <cyd@gnu.org>
3539
3540 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3541 call when setting menu-bar-lines and tool-bar-lines parameters.
3542 (unwind_create_frame_1): New helper function.
3543
3544 * window.c (inhibit_window_configuration_change_hook): New var.
3545 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3546 (syms_of_window): Initialize it.
f01d3321 3547
86b847b6
CY
35482012-02-22 Chong Yidong <cyd@gnu.org>
3549
3550 * xterm.c (x_draw_image_relief): Add missing type check for
3551 Vtool_bar_button_margin (Bug#10743).
3552
a59225b1
CY
35532012-02-21 Chong Yidong <cyd@gnu.org>
3554
3555 * fileio.c (Vfile_name_handler_alist): Doc fix.
3556
3557 * buffer.c (Fget_file_buffer): Protect against invalid file
3558 handler return value.
3559
310f5bd4
PE
35602012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3561
cb3a28cc
PE
3562 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3563 when computing $valmask.
3564
310f5bd4
PE
3565 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3566 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3567 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3568 It's useless in that case, and it can cause problems on hosts
3569 that allocate halves of EMACS_INT values separately.
3570 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3571 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3572 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3573 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3574 it avoids undefined behavior on hosts where shifting right by more
3575 than the word width has undefined behavior.
3576
2375c96a
CY
35772012-02-19 Chong Yidong <cyd@gnu.org>
3578
3579 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3580 (Funhandled_file_name_directory, Ffile_name_as_directory)
3581 (Fdirectory_file_name, Fexpand_file_name)
3582 (Fsubstitute_in_file_name): Protect against invalid file handler
3583 return values (Bug#10845).
3584
3eb49e71
EZ
35852012-02-18 Eli Zaretskii <eliz@gnu.org>
3586
3587 * .gdbinit (pitx): Fix incorrect references to fields of the
3588 iterator stack.
3589
7b926f3f
CY
35902012-02-17 Chong Yidong <cyd@gnu.org>
3591
3592 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3593
11273115
PE
35942012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3595
3596 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3597 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3598
c3a70e2b
CY
35992012-02-15 Chong Yidong <cyd@gnu.org>
3600
3601 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3602 marked as special. Also, starting docstrings with * is obsolete.
3603
0ca43699
AS
36042012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3605
3606 * gnutls.c (emacs_gnutls_write): Fix last change.
3607
2e8f3c56
LI
36082012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3609
3610 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3611 send_process.
3612
af70074f
SM
36132012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3614
3615 * keymap.c (Fsingle_key_description): Handle char ranges.
3616
95986d52
CY
36172012-02-12 Chong Yidong <cyd@gnu.org>
3618
afd83bd1
CY
3619 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3620 as that creates a dangerous corner case.
3621
95986d52
CY
3622 * window.c (Fdelete_window_internal): Invalidate the mouse
3623 highlight (Bug#9904).
3624
bd7da63e
GM
36252012-02-12 Glenn Morris <rgm@gnu.org>
3626
3627 * xselect.c (Fx_own_selection_internal)
3628 (Fx_get_selection_internal, Fx_disown_selection_internal)
3629 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3630 * nsselect.m (Fx_own_selection_internal)
3631 (Fx_disown_selection_internal, Fx_selection_exists_p)
3632 (Fx_selection_owner_p, Fx_get_selection_internal):
3633 Sync docs and argument specs with the xselect.c versions.
3634
77abcbc2
LI
36352012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3636
3637 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3638
90b671e2
EZ
36392012-02-11 Eli Zaretskii <eliz@gnu.org>
3640
1c0ca0b7
EZ
3641 * w32select.c (Fx_selection_exists_p): Sync doc string and
3642 argument list with xselect.c. (Bug#10783)
3643
3644 * w16select.c (Fx_selection_exists_p): Sync doc string and
3645 argument list with xselect.c. (Bug#10783)
90b671e2 3646
49241268
GM
36472012-02-10 Glenn Morris <rgm@gnu.org>
3648
3649 * fns.c (Fsecure_hash): Doc fix.
3650
f998bbe7 36512012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3652
3653 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3654
0992bd9c
CY
36552012-02-07 Chong Yidong <cyd@gnu.org>
3656
3657 * buffer.c (Fbuffer_local_variables)
3658 (buffer_lisp_local_variables): Handle unbound vars correctly;
3659 don't let Qunbound leak into Lisp.
3660
af008560
GM
36612012-02-07 Glenn Morris <rgm@gnu.org>
3662
dd605cc4
GM
3663 * image.c (Fimagemagick_types): Doc fix.
3664
af008560
GM
3665 * image.c (imagemagick-render-type): Change it from a lisp object
3666 to an integer. Move the doc here from the lisp manual.
3667 Treat all values not equal to 0 the same.
3668
1449fa1d
CY
36692012-02-06 Chong Yidong <cyd@gnu.org>
3670
3671 * doc.c (store_function_docstring): Avoid applying docstring of
3672 alias to base function (Bug#2603).
3673
3723ec07
AS
36742012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3675
3676 * .gdbinit (pp1, pv1): Remove redundant defines.
3677 (pr): Use pp.
3678
79c1cc1e
CY
36792012-02-04 Chong Yidong <cyd@gnu.org>
3680
3681 * nsterm.m: Declare a global (Bug#10694).
3682
d7f29f8e
EZ
36832012-02-04 Eli Zaretskii <eliz@gnu.org>
3684
cae07000
SM
3685 * w32.c (get_emacs_configuration_options):
3686 Include --enable-checking, if specified, in the return value.
d7f29f8e 3687
3b95a6f9
MR
36882012-02-04 Martin Rudalics <rudalics@gmx.at>
3689
3690 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3691 after rounding frame sizes. (Bug#9723)
3692
d6fa96a6
EZ
36932012-02-04 Eli Zaretskii <eliz@gnu.org>
3694
3695 * keyboard.c (adjust_point_for_property): Don't position point
3696 before BEGV. (Bug#10696)
3697
df0b2940
PE
36982012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3699
3700 Handle overflow when computing char display width (Bug#9496).
3701 * character.c (char_width): Return EMACS_INT, not int.
3702 (char_width, c_string_width): Check for overflow when
3703 computing the width; this is possible now that individual
3704 characters can have unbounded width. Problem introduced
3705 by merge from Emacs 23 on 2012-01-19.
3706
6bee44d6
MA
37072012-02-02 Michael Albinus <michael.albinus@gmx.de>
3708
3709 * dbusbind.c (Fdbus_register_method): Mention the return value
3710 :ignore in the docstring.
3711
44f92739
GM
37122012-02-02 Glenn Morris <rgm@gnu.org>
3713
1b9f60cc
GM
3714 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3715
44f92739
GM
3716 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3717 Unconditionally set to t. (Bug#10673)
3718 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3719 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3720 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3721
c5d3843c
KH
37222012-02-02 Kenichi Handa <handa@m17n.org>
3723
3724 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3725 0, do not call append_composite_glyph.
3726
159462d4 37272012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3728
3729 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3730 NULL (Bug#6988).
3731 (x_produce_glyphs): If the component of a composition is a null
3732 string, set it->pixel_width to 1 to avoid zero-width glyph.
3733
78cef877
EZ
37342012-02-01 Eli Zaretskii <eliz@gnu.org>
3735
3736 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3737 first 2 arguments are identical. This makes inserting large
3738 output from a subprocess an order of magnitude faster on
3739 MS-Windows, where all sbrk'ed memory is always contiguous.
3740
97897668
GM
37412012-01-31 Glenn Morris <rgm@gnu.org>
3742
3743 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3744 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3745 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3746
31fd3586
GM
37472012-01-29 Glenn Morris <rgm@gnu.org>
3748
3749 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3750
0e24a8b2
CY
37512012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3752
3753 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3754
cc0adcb0
CY
37552012-01-28 Chong Yidong <cyd@gnu.org>
3756
3757 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3758
acc28cb9
CY
37592012-01-26 Chong Yidong <cyd@gnu.org>
3760
9c69cfb7
CY
3761 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3762
acc28cb9
CY
3763 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3764 repeat counts (Bug#10507).
3765
48da7392
GM
37662012-01-26 Glenn Morris <rgm@gnu.org>
3767
3768 * lread.c (syms_of_lread): Doc fix.
3769
14af5f7f
CY
37702012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3771
3772 * coding.c (encode_designation_at_bol): Change return value to
3773 EMACS_INT.
3774
0b21c100
CY
37752012-01-25 Chong Yidong <cyd@gnu.org>
3776
3777 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3778
3c2907f7
CY
37792012-01-21 Chong Yidong <cyd@gnu.org>
3780
3781 * floatfns.c (Fcopysign): Make the second argument non-optional,
3782 since nil is not allowed anyway.
3783
959ad23f
AS
37842012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3785
3786 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3787 (send_process): Likewise.
3788
34a02f46
MR
37892012-01-19 Martin Rudalics <rudalics@gmx.at>
3790
3791 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3792 (Vwindow_persistent_parameters): Do not use Qstate.
3793 Rewrite doc-strings.
34a02f46 3794
1259009a 37952012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3796
3797 * character.c (char_width): New function.
70d4fdf6
GM
3798 (Fchar_width, c_string_width, lisp_string_width):
3799 Use char_width (Bug#9496).
25ed9e61 3800
6a6ee00d
MR
38012012-01-16 Martin Rudalics <rudalics@gmx.at>
3802
3803 * window.c (Vwindow_persistent_parameters): New variable.
3804 (Fset_window_configuration, save_window_save): Handle persistent
3805 window parameters.
3806
c85efaf7
EZ
38072012-01-14 Eli Zaretskii <eliz@gnu.org>
3808
3809 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3810 thrashing the stack of the thread. (Bug#9087)
3811
5944709e
PE
38122012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3813
3814 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3815
e71f5d99
EZ
38162012-01-11 Eli Zaretskii <eliz@gnu.org>
3817
3818 * xdisp.c (rows_from_pos_range): Handle the case where the
3819 highlight ends on a newline. (Bug#10464)
3820 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3821 he end column for display of highlight that ends on a newline
3822 before a R2L line.
3823
ce316182
GM
38242012-01-11 Glenn Morris <rgm@gnu.org>
3825
3826 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3827 from load-path also when installation-directory is nil. (Bug#10208)
3828
5b43da69
GM
38292012-01-10 Glenn Morris <rgm@gnu.org>
3830
74cc8ff9
GM
3831 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3832
7d8d6e4e
GM
3833 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3834 Update template values to be closer to their typical values these days.
5b43da69 3835
a0db8d43
EZ
38362012-01-09 Eli Zaretskii <eliz@gnu.org>
3837
3838 * xdisp.c (rows_from_pos_range): Accept additional argument
3839 DISP_STRING, and accept any glyph in a row whose object is that
3840 string as eligible for mouse highlight. Fixes mouse highlight of
3841 display strings from overlays. (Bug#10464)
3842
9a0115ab 38432012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3844
b9110d6a 3845 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3846 * fileio.c (auto_saving_dir_umask): New static var.
3847 (Fmake_directory_internal): Use it.
3848 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3849 creating the directory. The old code temporarily assigns
3850 too-generous permissions to the directory.
3851 (do_auto_save_eh): Clear it.
b9110d6a 3852 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3853 that the var is always cleared.
3854
6c1bd3f3
EZ
38552012-01-07 Eli Zaretskii <eliz@gnu.org>
3856
3857 * search.c (scan_buffer): Pass character positions to
3858 know_region_cache, not byte positions. (Bug#6540)
3859
069d2b50
L
38602012-01-07 LynX <_LynX@bk.ru> (tiny change)
3861
3862 * w32.c (sys_rename): Report EXDEV when rename of a directory
3863 fails because the target is on another logical disk. (Bug#10284)
3864
75bf0d33
DB
38652012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3866
3867 * xterm.c (x_embed_request_focus): New function.
3868
3869 * xterm.h: Add prototype.
3870
3871 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3872
1c6e5a32
GM
38732012-01-05 Glenn Morris <rgm@gnu.org>
3874
3875 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3876
651e947e
EZ
38772012-01-01 Eli Zaretskii <eliz@gnu.org>
3878
3879 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3880 Load gnutls_transport_set_lowat only if GnuTLS version is below
3881 2.11.1.
3882 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3883 GnuTLS versions below 2.11.1.
3884
3778cdd8
AL
38852011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3886
3887 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3888 to the doc string advising against its use for altering the way
3889 windows are scrolled.
3890
0e5317f7
KH
38912011-12-28 Kenichi Handa <handa@m17n.org>
3892
3893 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3894 coding-system ASCII compatible only when it does not produce BOM
3895 on encoding (Bug#10383).
3896
93d5ca1f
JD
38972011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3898
3899 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3900 can scroll.
3901 (create_and_show_popup_menu): Always use menu_position_func for
3902 Gtk3 (Bug#10361).
3903
ca22b785
AS
39042011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3905
3906 * callint.c (Fcall_interactively): Don't truncate prompt string.
3907
d048e1e6
EZ
39082011-12-23 Eli Zaretskii <eliz@gnu.org>
3909
3910 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3911 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3912 resumed from there (after widening). (Bug#10360)
d048e1e6 3913
5ccaba1f
JD
39142011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3915
3916 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3917
204ee57f
JD
39182011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3919
b81d40f0
JB
3920 * nsterm.m (x_free_frame_resources):
3921 Release f->output_data.ns->miniimage.
204ee57f
JD
3922 (ns_index_color): Fix indentation. Do not retain
3923 color_table->colors[i].
3924
3925 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3926 before returning.
3927
3928 * nsfns.m (x_set_background_color): Assign return value from
3929 ns_index_color to face-background instead of NSColor*.
3930 (ns_implicitly_set_icon_type): Fix indentation.
3931 Change assignment in for loop to comparison.
3932
3933 * emacs.c (ns_pool): New variable.
3934 (main): Assign ns_pool.
3935 (Fkill_emacs): Call ns_release_autorelease_pool.
3936
3937 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3938 autorelease fdesc, release fdAttrs and tdict.
3939 (ns_get_covering_families): Release charset.
3940 (ns_findfonts): Release NSFontDescriptor created with new.
3941 (ns_uni_to_glyphs): Fix indentation.
3942 (setString): Release attrStr before assigning new value.
3943
c803b2b7
JD
39442011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3945
678f4426
JD
3946 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3947 and NS_IMPL_COCOA.
3948 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3949 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3950
cd394be1 39512011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3952
5fecd5fc
JD
3953 * nsterm.m (ns_term_init): Subscribe for notifications
3954 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3955 to method trackingNotification in EmacsMenu.
3956
3957 * nsmenu.m (trackingMenu): New variable.
3771cb17 3958 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3959 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3960 from Aquamacs (Bug#7030).
678f4426
JD
3961
39622011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3963
c803b2b7
JD
3964 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3965 (symbol_to_nsstring): Fix indentation.
3966 (ns_symbol_to_pb): New function.
cae07000
SM
3967 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3968 (Fns_rotate_cut_buffers_internal): Remove.
3969 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3970 Fns_store_cut_buffer_internal.
3971 (ns_get_foreign_selection, Fx_own_selection_internal)
3972 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3973 (Fns_get_selection_internal, Fns_store_selection_internal):
3974 Use ns_symbol_to_pb and check if return value is nil.
3975 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3976 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3977 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3978 renamed to Sns_store_selection_internal.
3979 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3980 and remove this function.
3981 (ns_handle_selection_clear): Remove, never used.
3982 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3983 here.
3984
e1b01a3a
KB
39852011-12-17 Ken Brown <kbrown@cornell.edu>
3986
3987 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3988 GID is unknown (Bug#10257).
3989
2adb6e85
PE
39902011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3991
3992 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3993 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3994 which caused a build failure on GNU/Linux IA-64. This problem was
3995 introduced by my 2011-10-07 patch.
3996
d1d7b339
JL
39972011-12-15 Juri Linkov <juri@jurta.org>
3998
3999 * image.c (imagemagick_error): New function. (Bug#10112)
4000 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4001 Use `imagemagick_error' where ImageMagick functions return
4002 `MagickFalse'.
4003 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4004 proper order.
4005
100d5755
KH
40062011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4007
4008 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4009 fill background (Bug#8992).
4010
454592a6
MR
40112011-12-13 Martin Rudalics <rudalics@gmx.at>
4012
4013 * window.c (Vwindow_combination_resize)
4014 (Vwindow_combination_limit): Use t instead of non-nil in
4015 doc-strings.
61d4b438
MR
4016 (Vrecenter_redisplay): Add first sentence of doc-string on
4017 separate line.
53524d93 4018 (Frecenter): Fix doc-string typo.
454592a6 4019
3633e3aa
KH
40202011-12-11 Kenichi Handa <handa@m17n.org>
4021
4022 * coding.c (Funencodable_char_position): Pay attention to the
4023 buffer text relocation (Bug#9389).
4024
7b9d523a 40252011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4026
7b9d523a
JD
4027 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4028 gtk_init (Bug#10100).
4029
b73189c6
EZ
40302011-12-10 Eli Zaretskii <eliz@gnu.org>
4031
4032 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4033 IT->string is nil. (Bug#10263)
4034
f7dfe5d6
JD
40352011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4036
83faebb4
JD
4037 * nsterm.h (x_free_frame_resources): Declare.
4038
f7dfe5d6
JD
4039 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4040 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4041
4042 * nsterm.h (ns_get_defaults_value): Declare.
4043
4044 * nsterm.m (ns_default): Call ns_get_defaults_value.
4045
7cd4e72c
EZ
40462011-12-09 Eli Zaretskii <eliz@gnu.org>
4047
4048 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4049 (Bug#10170)
4050
b34d7317
YM
40512011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4052
4053 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4054 that where the value of an _OBJC_* symbol points to is in the .bss
4055 section (Bug#10240).
4056
76470ad1
KH
40572011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4058
4059 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4060 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4061
745fff94
KH
40622011-12-08 Kenichi Handa <handa@m17n.org>
4063
4064 * ftfont.c (get_adstyle_property): Fix previous change
4065 (Bug#10233).
4066
6e44397c
JB
40672011-12-07 Juanma Barranquero <lekktu@gmail.com>
4068
4069 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4070 dirs from the default value of EMACSLOADPATH (bug#10208).
4071
7efa6272
GM
40722011-12-07 Glenn Morris <rgm@gnu.org>
4073
4074 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4075 installation and source directories as well. (Bug#10208)
4076
f6fc4d87
CY
40772011-12-06 Chong Yidong <cyd@gnu.org>
4078
4079 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4080
2bf26180
GM
40812011-12-06 Glenn Morris <rgm@gnu.org>
4082
4083 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4084 as an error, not just -1. (Bug#10217)
4085
3a6ad4f0
CY
40862011-12-05 Chong Yidong <cyd@gnu.org>
4087
4088 * keyboard.c (process_special_events): New function.
4089 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4090
75a3b399
PE
40912011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4092
4093 * coding.c (encode_designation_at_bol): Don't use uninitialized
4094 local variable (Bug#9318).
4095
c3c9e25e
KH
40962011-12-05 Kenichi Handa <handa@m17n.org>
4097
4098 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4099 return Qnil (Bug#8046, Bug#10193).
4100
5eb05ea3
KH
41012011-12-05 Kenichi Handa <handa@m17n.org>
4102
4103 * coding.c (encode_designation_at_bol): New args charbuf_end and
4104 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4105 (coding_set_source): Return how many bytes coding->source was
4106 relocated.
4107 (coding_set_destination): Return how many bytes
4108 coding->destination was relocated.
4109 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4110 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4111
41122011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4113
4114 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4115 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4116 macro (Bug#9318).
4117
41182011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4119
4120 The following changes are to fix Bug#9318.
4121
a79703f5 4122 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4123 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4124 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4125 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4126
7dbda6df
JB
41272011-12-05 Juanma Barranquero <lekktu@gmail.com>
4128
4129 * lisp.h (process_quit_flag): Fix external declaration.
4130
6d5eb5b0
SM
41312011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4132
4133 Don't macro-inline non-performance-critical code.
4134 * eval.c (process_quit_flag): New function.
4135 * lisp.h (QUIT): Use it.
4136
a0c3fad0
JD
41372011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4138
4139 * nsfns.m (get_geometry_from_preferences): New function.
4140 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4141
6c07aac2
AS
41422011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4143
4144 * emacs.c (Qkill_emacs): Define.
4145 (syms_of_emacs): Initialize it.
4146 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4147 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4148 (quit_throw_to_read_char): Add parameter `from_signal'.
4149 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4150 * lisp.h (QUIT): Call Fkill_emacs if requested.
4151
c052ead4
JD
41522011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4153
4154 * widget.c (update_wm_hints): Return if wmshell is null.
4155 (widget_update_wm_size_hints): New function.
4156
4157 * widget.h (widget_update_wm_size_hints): Declare.
4158
4159 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4160 widget_update_wm_size_hints (Bug#10104).
4161
9e49252b
EZ
41622011-12-03 Eli Zaretskii <eliz@gnu.org>
4163
4164 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4165 before a newline, prepare the bidi iterator for consuming the
4166 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4167 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4168
02b16839
JL
41692011-12-02 Juri Linkov <juri@jurta.org>
4170
4171 * search.c (Fword_search_regexp): New Lisp function created from
4172 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4173 (Fword_search_backward, Fword_search_forward)
4174 (Fword_search_backward_lax, Fword_search_forward_lax):
4175 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4176 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4177
0068070e
SM
41782011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4179
4180 * fileio.c (Finsert_file_contents): Move after-change-function call
4181 to before the "handled:" label, since all "goto handled" appear in
4182 cases where the *-change-functions have already been properly called
4183 (bug#10117).
4184
3360a3fc
AS
41852011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4186
4187 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4188 waiting for input. (Bug#10169)
4189
73d6c093
EZ
41902011-11-30 Eli Zaretskii <eliz@gnu.org>
4191
4192 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4193 verifies glyph row's hash code--we have just reallocated the
4194 glyphs, so their contents can be complete garbage. (Bug#10164)
4195
febe6bea
JB
41962011-11-30 Juanma Barranquero <lekktu@gmail.com>
4197
4198 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4199
801a4313
EZ
42002011-11-30 Eli Zaretskii <eliz@gnu.org>
4201
4202 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4203 attributes are tested _before_ calling verify_row_hash, to protect
4204 against GCC re-ordering of the tests. (Bug#10164)
4205
2b56b87e
JD
42062011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4207
4208 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4209
4210 * xterm.c (handle_one_xevent): Only set async_visible and friends
4211 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4212 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4213 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4214
dbf31225
PE
42152011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4216
4217 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4218 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4219 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4220 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4221 All uses changed to use GCPRO1 etc.
4222 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4223 Revert to old implementation (i.e., before 2011-03-11).
4224
1305621b
YM
42252011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4226
4227 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4228 of scroll runs so as to avoid assigning disabled bogus rows and
4229 unnecessary graphics copy operations.
4230
8c9afb46
EZ
42312011-11-27 Eli Zaretskii <eliz@gnu.org>
4232
4233 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4234 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4235 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4236 (malloc, free, realloc, calloc): Redirect to e_* only when
4237 compiling Emacs.
4238
4239 * lisp.h (GCTYPEBITS): Move before first use.
4240 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4241 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4242 this macro definition.
4243
4244 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4245 _MSC_VER.
4246
54e9e3bf
JD
42472011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4248
6d5eb5b0
SM
4249 * gtkutil.c (xg_create_frame_widgets):
4250 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4251 present with Gtk+ 2.0.
4252
83aca1cb
PE
42532011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4254
4255 * fileio.c (Finsert_file_contents): Undo previous change; see
4256 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4257
5b76caa4
PE
42582011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4259
4260 Rename locals to avoid shadowing.
4261 * fileio.c (Finsert_file_contents):
4262 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4263 * process.c (wait_reading_process_output):
4264 Rename inner 'proc' to 'p' to avoid shadowing.
4265 Indent for consistency with usual Emacs style.
4266
8c535114
EZ
42672011-11-25 Eli Zaretskii <eliz@gnu.org>
4268
4269 * xdisp.c (redisplay_window): If cursor row is not fully visible
4270 after recentering, and scroll-conservatively is set to a large
4271 number, scroll window by a few more lines to make the cursor fully
4272 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4273 (start_display): Don't move to the next line if the display should
4274 start at a newline that is part of a display vector or an overlay
4275 string. (Bug#10119)
8c535114 4276
fa4fdb5c
JL
42772011-11-24 Juri Linkov <juri@jurta.org>
4278
4279 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4280 after the `MagickPingImage' call. (Bug#10112)
4281
90ec88df
CY
42822011-11-23 Chong Yidong <cyd@gnu.org>
4283
4284 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4285
56e2e794
MR
42862011-11-23 Martin Rudalics <rudalics@gmx.at>
4287
4288 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4289 making another buffer current. (Bug#10114)
4290
b6e64c41
GM
42912011-11-23 Glenn Morris <rgm@gnu.org>
4292
4293 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4294
6b21de18
CY
42952011-11-23 Chong Yidong <cyd@gnu.org>
4296
4297 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4298 using it (Bug#5984).
4299
b12cd789
EZ
43002011-11-22 Eli Zaretskii <eliz@gnu.org>
4301
4302 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4303 and header-lines, as they don't have one computed for them.
4304 (Bug#10098)
4305
4306 * .gdbinit (prow): Make displayed values more self-explaining.
4307 Add row's hash code.
4308
261b6fd4
LMI
43092011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4310
4311 * process.c (wait_reading_process_output): Fix asynchrounous
4312 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4313 (wait_reading_process_output): Add comment and URL.
261b6fd4 4314
e7cfd277
JD
43152011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4316
4317 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4318
a9b9b7f5
CY
43192011-11-21 Chong Yidong <cyd@gnu.org>
4320
4321 * window.c (Fnext_window, Fprevious_window): Doc fix.
4322
b0d15b4f
SM
43232011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4324
4325 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4326
fe7a3057
JB
43272011-11-20 Juanma Barranquero <lekktu@gmail.com>
4328
4329 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4330
d2999b1a
MR
43312011-11-20 Martin Rudalics <rudalics@gmx.at>
4332
4333 * window.c (Fset_window_combination_limit): Rename argument
4334 STATUS to LIMIT.
4335 (Vwindow_combination_limit): Remove "status" from doc-string.
4336
d5ff9cd0
AS
43372011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4338
4339 * m/ibms390.h: Remove.
4340 * m/ibms390x.h: Don't include "ibms390.h".
4341
a5bb9bd3
SM
43422011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4343
4344 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4345 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4346
cd1181db
JB
43472011-11-20 Juanma Barranquero <lekktu@gmail.com>
4348
4349 * casetab.c (Fset_case_table):
4350 * charset.c (Fcharset_after): Fix typos.
4351
615a3b8d 43522011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4353
17e845af
PE
4354 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4355 Otherwise, valgrind does not work on some platforms.
4356 Problem reported by Andreas Schwab in
6a0bf43d
PE
4357 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4358 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4359 is set, removing the need for VIRT_ADDRESS_VARIES.
4360 (PURE_P): Use a more-efficient implementation that needs just one
4361 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4362 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4363 to 4 (xorl, subq, cmpq, setbe).
4364 * alloc.c (pure): Always extern now, since that's the
4365 VIRT_ADDR_VARIES behavior.
4366 (PURE_POINTER_P): Use a single comparison, not two, for
4367 consistency with the new puresize.h.
4368 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4369 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4370 Remove VIRT_ADDR_VARIES no longer needed.
4371
f8fe6f96
EZ
43722011-11-19 Eli Zaretskii <eliz@gnu.org>
4373
4374 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4375 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4376 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4377 behave as if the cursor position were at the window margin.
4378
4379 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4380 and the cursor position is out of bounds, behave as if the cursor
4381 position were at the window margin. (Bug#10075)
4382
df05a53c
CY
43832011-11-18 Chong Yidong <cyd@gnu.org>
4384
4385 * window.c (Fwindow_combination_limit): Make first argument
4386 non-optional, since it is meaningless for live windows like the
4387 selected window.
61ccba97 4388
2071918e
DA
43892011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4390
4391 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4392
b50a28de
SM
43932011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4394
4395 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4396 (graft_intervals_into_buffer): Simplify.
4397
015137db
EZ
43982011-11-18 Eli Zaretskii <eliz@gnu.org>
4399
4400 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4401 hash values of the two rows.
4402 (copy_row_except_pointers): Preserve the used[] arrays and the
4403 hash values of the two rows. (Bug#10035)
68c95424 4404 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4405
4406 * xdisp.c (row_hash): New function, body extracted from
4407 compute_line_metrics.
4408 (compute_line_metrics): Call row_hash, instead of computing the
4409 hash code inline.
4410
4411 * dispnew.c (verify_row_hash): Call row_hash for computing the
4412 hash code of a row, instead of duplicating code from xdisp.c.
4413
4414 * dispextern.h (row_hash): Add prototype.
4415
a2addb04
TH
44162011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4417
4418 * frame.c (delete_frame): Don't delete the terminal when the last
4419 X frame is closed if emacs is built with GTK toolkit.
4420
df85d315
JB
44212011-11-17 Juanma Barranquero <lekktu@gmail.com>
4422
4423 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4424
a0c2d0ae
MR
44252011-11-17 Martin Rudalics <rudalics@gmx.at>
4426
4427 * window.c (Vwindow_splits): Rename to
4428 Vwindow_combination_resize. Suggested by Juri Linkov.
4429 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4430 of Vwindow_splits.
4431
58179cce
JB
44322011-11-16 Juanma Barranquero <lekktu@gmail.com>
4433
7877f373
JB
4434 * nsfns.m (Fns_font_name):
4435 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4436
b6f67890
MR
44372011-11-16 Martin Rudalics <rudalics@gmx.at>
4438
4439 * window.h (window): Rename slot "nest" to "combination_limit".
4440 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4441 (Fset_window_nest): Rename to Fset_window_combination_limit.
4442 (Vwindow_nest): Rename to Vwindow_combination_limit.
4443 (recombine_windows, make_parent_window, make_window)
4444 (Fsplit_window_internal, saved_window)
4445 (Fset_window_configuration, save_window_save): Rename all
4446 occurrences of window_nest to window_combination_limit.
4447
c7015153
JB
44482011-11-15 Juanma Barranquero <lekktu@gmail.com>
4449
4450 * image.c (imagemagick_load_image): Fix typo.
4451
322ad6ec
EZ
44522011-11-14 Eli Zaretskii <eliz@gnu.org>
4453
4454 * xdisp.c (display_line): Move the call to
4455 highlight_trailing_whitespace before the call to
4456 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4457 faces of all the glyphs to compute ROW's hash value.
4458 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4459
f067b8ec
JB
44602011-11-14 Juanma Barranquero <lekktu@gmail.com>
4461
4462 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4463 just return (bug#10044).
4464
1e5b2111
EZ
44652011-11-12 Eli Zaretskii <eliz@gnu.org>
4466
7ef3cbd5
EZ
4467 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4468 with user-defined heap size. Bump the default size of the temacs
4469 heap to 27MB, to avoid memory warning when running temacs.
4470 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4471
1e5b2111
EZ
4472 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4473 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4474 (verify_row_hash) [XASSERTS]: New function.
4475 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4476 that the hash value of glyph rows is correct.
1e5b2111 4477
89d61221
MR
44782011-11-12 Martin Rudalics <rudalics@gmx.at>
4479
4480 * window.h (window): Remove splits slot.
4481 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4482 (Fdelete_other_windows_internal, make_parent_window)
4483 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4484 (Fset_window_configuration, save_window_save): Don't deal with
4485 split status of windows.
4486 (saved_window): Remove splits slot.
4487 (Vwindow_splits): Rewrite doc-string.
4488
97f18cc8
JD
44892011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4490
4491 * xfns.c (unwind_create_frame):
4492 * nsfns.m (unwind_create_frame):
4493 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4494 Vframe_list (Bug#9999).
4495
22a648b4
DA
44962011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4497
0b381c7e 4498 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4499
659afede
KH
45002011-11-11 Kenichi Handa <handa@m17n.org>
4501
4502 * callproc.c (Fcall_process): Set the member dst_multibyte of
4503 process_coding.
4504
9ac0394b
KH
45052011-11-11 Johan Bockgård <bojohan@gnu.org>
4506
4507 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4508 avoid a crash (bug#9496).
4509
2fbdc249
CY
45102011-11-09 Chong Yidong <cyd@gnu.org>
4511
4512 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4513 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4514
ac6b1f81
PE
45152011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4516
4517 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4518
09db192c
PE
45192011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4520
4521 Avoid some portability problems by eschewing 'extern inline' functions.
4522 The trivial performance wins aren't worth the portability hassles; see
4523 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4524 et seq.
4525 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4526 (window_box_width, window_box_left, window_box_left_offset)
4527 (window_box_right, window_box_right_offset): Undo previous change,
4528 by removing the "extern"s.
4529 * intervals.c (adjust_intervals_for_insertion)
4530 (adjust_intervals_for_deletion): Undo previous change,
4531 making these static again.
4532 (offset_intervals, temp_set_point_both, temp_set_point)
4533 (copy_intervals_to_string): No longer inline.
4534 * xdisp.c (window_text_bottom_y, window_box_width)
4535 (window_box_height, window_box_left_offset)
4536 (window_box_right_offset, window_box_left, window_box_right)
4537 (window_box): No longer inline.
4538
105216ed
CY
45392011-11-08 Chong Yidong <cyd@gnu.org>
4540
4541 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4542 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4543 Signal an error if not a live window.
105216ed
CY
4544 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4545 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4546
ae9e237f
JB
45472011-11-07 Juanma Barranquero <lekktu@gmail.com>
4548
4549 * lisp.h (syms_of_abbrev): Remove declaration.
4550 Reported by CHENG Gao <chenggao@royau.me>.
4551
c7aa8333
EZ
45522011-11-07 Eli Zaretskii <eliz@gnu.org>
4553
4554 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4555 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4556 of temacs in GUI mode.
4557
be7f5545
MR
45582011-11-07 Martin Rudalics <rudalics@gmx.at>
4559
4560 * window.h: Declare delete_all_child_windows instead of
4561 delete_all_subwindows.
4562 * window.c (Fwindow_nest, Fset_window_nest)
4563 (Fset_window_new_total, Fset_window_new_normal)
4564 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4565 (delete_all_subwindows): Rename to delete_all_child_windows.
4566 (Fdelete_other_windows_internal, Fset_window_configuration):
4567 Call delete_all_child_windows instead of delete_all_subwindows.
4568 * frame.c (delete_frame): Call delete_all_child_windows instead
4569 of delete_all_subwindows.
4570
ca78dc43
PE
45712011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4572
4573 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4574 This is also needed for porting to any host where GC_MARK_STACK is
4575 not GC_MAKE_GCPROS_NOOPS.
4576 (which_symbols): Use it.
4577
a0241d01
KH
45782011-11-07 Kenichi Handa <handa@m17n.org>
4579
4580 * coding.c (coding_set_destination): Check coding->src_pos only
4581 when coding->src_object is a buffer (bug#9910).
4582
4583 * process.c (send_process): Set the member src_multibyte of coding
4584 to 0 (bug#9911) when sending a unibyte text.
4585
4586 * callproc.c (Fcall_process): Set the member src_multibyte of
4587 process_coding to 0 (bug#9912).
4588
a64bfdfa 45892011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4590
4591 * xmenu.c (cleanup_widget_value_tree): New function.
4592 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4593 calling free_menubar_widget_value_tree directly (Bug#9830).
4594
cb41b32a
PE
45952011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4596
4597 Fix some portability problems with 'inline'.
4598 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4599 (window_box_width, window_box_left, window_box_left_offset)
4600 (window_box_right, window_box_right_offset): Declare extern.
4601 Otherwise, these inline functions do not conform to C99 and
4602 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4603 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4604 * intervals.c (adjust_intervals_for_insertion)
4605 (adjust_intervals_for_deletion): Now extern, because otherwise the
4606 extern inline functions 'offset_intervals' couldn't refer to it.
4607 (static_offset_intervals): Remove.
4608 (offset_intervals): Rewrite using the old contents of
4609 static_offset_intervals. The old version didn't conform to C99
4610 because an extern inline function contained a reference to an
4611 identifier with static linkage.
4612
b7041366
AS
46132011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4614
4615 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4616 GC.
4617
88a37c4d
EZ
46182011-11-06 Eli Zaretskii <eliz@gnu.org>
4619
4620 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4621 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4622 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4623 return Qleft_to_right.
4624
49745b39
CY
46252011-11-06 Chong Yidong <cyd@gnu.org>
4626
4627 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4628 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4629 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4630 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4631 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4632 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4633 (Fwindow_vscroll): Doc fix.
4634 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4635 argument, since it makes no sense to pass a live window and for
4636 consistency with window-child.
4637
1f05cd82
CS
46382011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4639
4640 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4641 support MSVC.
4642
22610910
JR
46432011-11-05 Jason Rumney <jasonr@gnu.org>
4644
4645 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4646 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4647 fonts (Bug#6029).
4648 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4649 bitwise arithmetic preventing use of unicode-sip and non-truetype
4650 opentype fonts.
4651
a06776b2
EZ
46522011-11-05 Eli Zaretskii <eliz@gnu.org>
4653
3ad924ba
EZ
4654 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4655 "emacs"-only part.
4656
a06776b2
EZ
4657 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4658 initialization code to keep similarity to xfns.c after changes
4659 from 2011-11-05.
4660
c9e7db78
JD
46612011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4662
a97f8f3f
JD
4663 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4664 (unwind_create_frame): New function (Bug#9943).
4665 (Fx_create_frame): Restructure code to be more similar to the one in
4666 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4667 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4668 Move terminal->reference_count++ just before making the frame official
4669 (Bug#9943).
4670
4671 * nsterm.m (x_free_frame_resources): New function.
4672 (x_destroy_window): Move code to x_free_frame_resources.
4673
c9e7db78 4674 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4675 (Fx_create_frame, x_create_tip_frame):
4676 Move terminal->reference_count++ just before making the frame
75f1671a 4677 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4678 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4679
a6fc3b5c
EZ
46802011-11-05 Eli Zaretskii <eliz@gnu.org>
4681
4682 Support MSVC build with newer versions of Visual Studio.
4683 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4684 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4685 nt/gmake.defs.
4686
4687 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4688 which are not supported by MSVC.
4689 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4690 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4691 bitfields.
4692 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4693 types in bitfields.
4694 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4695
4696 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4697
58179cce 46982011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4699
4700 Support MSVC build with newer versions of Visual Studio.
4701 * w32.c: Don't include w32api.h for MSVC.
4702 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4703
4704 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4705 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4706 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4707 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4708 e_* cousins.
4709 (alloca) [_MSC_VER]: Define to _alloca.
4710
4711 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4712
4713 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4714
a58c13ed
EZ
47152011-11-04 Eli Zaretskii <eliz@gnu.org>
4716
4717 * xdisp.c (note_mouse_highlight): If either of
4718 previous/next-single-property-change returns nil, treat that as
4719 the beginning or the end of the buffer. (Bug#9955)
4720
fe0b6370
JD
47212011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4722
a58c13ed 4723 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4724 label is not null (Bug#9951).
4725 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4726 may be NULL.
4727
89bd5ee1
EZ
47282011-11-04 Eli Zaretskii <eliz@gnu.org>
4729
4730 * window.c (Fwindow_body_size): Mention in the doc string that the
4731 return value is in frame's canonical units. (Bug#9949)
4732
84c3edb9
EZ
47332011-11-03 Eli Zaretskii <eliz@gnu.org>
4734
4e2fb5c7
EZ
4735 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4736
84c3edb9 4737 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4738 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4739 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4740
bc17a887
EZ
47412011-11-01 Eli Zaretskii <eliz@gnu.org>
4742
4743 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4744 Don't stop backward scan on the continuation glyph, even though
4745 its CHARPOS is positive.
6d5eb5b0
SM
4746 (mouse_face_from_buffer_pos, note_mouse_highlight):
4747 Rename cover_string to disp_string.
bc17a887 4748
4ee88440
MR
47492011-11-01 Martin Rudalics <rudalics@gmx.at>
4750
4751 * window.c (temp_output_buffer_show): Don't use
4752 Vtemp_buffer_show_specifiers.
4753 (Vtemp_buffer_show_specifiers): Remove unused variable.
4754
c2ff3c02
EZ
47552011-10-30 Eli Zaretskii <eliz@gnu.org>
4756
4757 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4758 past the beginning of the current glyph matrix.
4759
58179cce 47602011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4761
4762 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4763 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4764 HAVE_GTK3 (Bug#9869).
b77a6a7f 4765
3b574623
JD
4766 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4767 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4768
b77a6a7f
JD
4769 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4770
4771 * xterm.c: Declare x_handle_net_wm_state to return int.
4772 (handle_one_xevent): Check if we are iconified but don't have
4773 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4774 (get_current_wm_state): Return non-zero if not hidden,
4775 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4776 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4777 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4778 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4779
196e41e4
PE
47802011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4781
4782 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4783 so that this new function doesn't get optimized away by a
4784 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4785
021f2e1a
AS
47862011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4787
4788 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4789
8b058d44
EZ
47902011-10-29 Eli Zaretskii <eliz@gnu.org>
4791
4792 Fix the `xbytecode' command.
4793 * .gdbinit (xprintbytestr): New command.
b50a28de 4794 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4795 (xbytecode): Print the byte-code string as well.
4796
4452fb80
EZ
47972011-10-29 Kim Storm <storm@cua.dk>
4798
8b058d44
EZ
4799 * alloc.c (which_symbols): New function.
4800
21b72067
AS
48012011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4802
4803 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4804 line. (Bug#9903)
4805
83ed7b5c
GM
48062011-10-29 Glenn Morris <rgm@gnu.org>
4807
4808 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4809 Not clear what it was for, and it causes various bugs. (Bug#9839)
4810
5a7a728b
EZ
48112011-10-28 Eli Zaretskii <eliz@gnu.org>
4812
4813 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4814 possible random value that matches one of those tested as
4815 condition to clear the mouse face.
4816
d3d0842f
CY
48172011-10-28 Chong Yidong <cyd@gnu.org>
4818
4819 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4820
31b39d13
DN
48212011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4822
4823 * window.c (make_window): Initialize phys_cursor_on_p.
4824
9aba6043
SM
48252011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4826
4827 * lisp.h (struct Lisp_Symbol): Update comments.
4828
c20992f4
JB
48292011-10-28 Juanma Barranquero <lekktu@gmail.com>
4830
4831 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4832
db4f02f2
EZ
48332011-10-28 Eli Zaretskii <eliz@gnu.org>
4834
4835 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4836 <oslsachem@gmail.com> for helping to debug this.
4837
4838 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4839 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4840 (g_b_init_get_glyph_outline_w): New static variables.
4841 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4842 (GetGlyphOutlineW_Proc): New typedefs.
4843 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4844 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4845 New functions.
4846 (w32font_open_internal, compute_metrics):
4847 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4848 instead of calling the "wide" APIs directly.
4849
4850 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4851
4852 * w32.h (syms_of_w32font): Add prototype.
4853
87e68db4
JB
48542011-10-27 Juanma Barranquero <lekktu@gmail.com>
4855
4856 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4857 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4858 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4859 (Fmove_to_window_line): Doc fix.
4860
435c1d67
CY
48612011-10-27 Chong Yidong <cyd@gnu.org>
4862
4863 * process.c (make_process): Set gnutls_state to NULL.
4864
4865 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4866 non-NULL, regardless of GNUTLS_INITSTAGE.
4867 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4868 an error. Set process slots as soon as we allocate them.
4869
4870 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4871
9c6c6f49
CY
48722011-10-27 Chong Yidong <cyd@gnu.org>
4873
9aba6043
SM
4874 * gnutls.c (emacs_gnutls_deinit): New function.
4875 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4876 (Fgnutls_deinit, Fgnutls_boot): Use it.
4877
4878 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4879 (deactivate_process): Call emacs_gnutls_deinit.
4880
657d08d3
JB
48812011-10-27 Juanma Barranquero <lekktu@gmail.com>
4882
4883 * image.c (x_create_x_image_and_pixmap):
4884 * w32.c (sys_rename, w32_delayed_load):
4885 * w32font.c (fill_in_logfont):
4886 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4887
5430d399
JB
48882011-10-26 Juanma Barranquero <lekktu@gmail.com>
4889
4890 * w32fns.c (w32_default_color_map): New function,
4891 extracted from Fw32_default_color_map.
a7ef684b 4892 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4893
fe0055fa
PE
48942011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4895
4896 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4897
e6346438
SM
48982011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4899
4900 * keyboard.c (test_undefined): New function (bug#9751).
4901 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4902
e112cc37
ET
49032011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4904
4905 * sysdep.c (init_sys_modes): Fix the check for the controlling
4906 terminal (Bug#6649).
4907
7b5d6677
EZ
49082011-10-20 Eli Zaretskii <eliz@gnu.org>
4909
4910 * dispextern.h (struct bidi_it): New member next_en_type.
4911
4912 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4913 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4914 current character, check also for next_en_type being WEAK_EN.
4915 (bidi_resolve_weak): Don't enter the expensive loop if the current
4916 position is before next_en_pos. Record the bidi type of the first
4917 non-ET, non-BN character we find, in addition to its position.
4918 (bidi_level_of_next_char): Invalidate next_en_type when
4919 next_en_pos is over-stepped.
4920
7da0b018
PE
49212011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4922
4923 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4924 * editfns.c: Rewrite current-time-zone so that it invokes
4925 the equivalent of (format-time-string "%Z") to get the time zone name.
4926 This fixes a bug when the time zone name contains characters that
4927 need converting from the system time locale to Emacs internal format.
4928 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4929 that patch fixed format-time-string to do the conversion, but
4930 I forgot to fix current-time-zone.
4931 (format_time_string): New function, containing most of
4932 what Fformat_time_string used to contain.
4933 (Fformat_time_string): Rewrite in terms of format_time_string.
4934 This doesn't change this function's behavior.
4935 (current-time-zone): Rewrite to use format_time_string.
4936 This fixes the bug reported by Michael Schierl in
4937 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4938 Jason Rumney's 2007-06-07 change worked around this bug, but
4939 didn't fix it.
4940 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4941
8547b010
EZ
49422011-10-19 Eli Zaretskii <eliz@gnu.org>
4943
4944 * xdisp.c (start_display): If the character at POS is displayed
4945 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4946 (try_window_reusing_current_matrix): If a line ends in a display
4947 vector or the next line starts in a display vector, continue
4948 redrawing the window even though the character position of
4949 start_row was reached.
8547b010
EZ
4950 (Bug#9771, part 2)
4951
4e948d15
CY
49522011-10-18 Chong Yidong <cyd@gnu.org>
4953
4954 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4955 with nobreak-char-display too.
4956
4787455f
EZ
49572011-10-18 Eli Zaretskii <eliz@gnu.org>
4958
4959 Fix part 3 of bug#9771.
4960 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4961 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4962 non-neutral characters if the current character is a paragraph
4963 separator (a.k.a. Newline). This avoids running the same
4964 expensive loop twice, once when we consume the preceding newline
4965 and the other time when the line actually needs to be displayed.
4966 Avoid the loop when we see neutrals on the base embedding level
4967 following a character whose directionality is the same as the
4968 paragraph's. This avoids running the expensive loop when a line
4969 ends in a long sequence of neutrals, like control characters.
4970 Add assertion against STRONG_AL type. Slightly rearrange code
4971 that determines the type of a neutral given the first non-neutral
4972 that follows it.
4973 (bidi_level_of_next_char): Set next_en_pos to zero when
4974 invalidating its info.
4975
2c91f553
EZ
49762011-10-17 Eli Zaretskii <eliz@gnu.org>
4977
4978 * xdisp.c (push_display_prop): Determine whether to record string
4979 or buffer position by IT->string, not by IT->method. Allow
4980 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4981 (move_it_vertically_backward): Don't look for character position
4982 immediately after the newline when in a continuation line.
4983 (Bug#9771, part 1)
2c91f553 4984
c7b08b0d
MR
49852011-10-15 Martin Rudalics <rudalics@gmx.at>
4986
4987 * window.c (coordinates_in_window): Rewrite and delabelize
4988 vertical border check. (Bug#5357) (Bug#9618)
4989
6b02f655
SM
49902011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4991
4992 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4993 errors in XSetWindowBorder (bug#9310).
4994
81d40c92
DA
49952011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4996
4997 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4998 avoid crash when xmalloc overrun checking is enabled.
4999
d4172c3b
EZ
50002011-10-13 Eli Zaretskii <eliz@gnu.org>
5001
5002 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5003 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5004 cursor motion with <left> and <right> arrow keys.
5005
5006 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5007 some callers set that themselves.
5008
b00eea75
EZ
50092011-10-12 Eli Zaretskii <eliz@gnu.org>
5010
5011 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5012 display string and the previous row comes from the same string and
5013 is empty. (Bug#9739) (Bug#9738)
5014
8fe012c4
SM
50152011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5016
5017 * doc.c (get_doc_string): Encode file name (bug#9735).
5018
0074aef2
EZ
50192011-10-12 Eli Zaretskii <eliz@gnu.org>
5020
79beb178
EZ
5021 * bidi.c (bidi_level_of_next_char):
5022 * xdisp.c (get_visually_first_element): Remove old incorrect
5023 comments regarding the Unicode Line Separator character.
5024
0074aef2
EZ
5025 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5026
6e4b3fbe
DA
50272011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5028
5029 * alloc.c (Fgc_status): Do not access beyond zombies array
5030 boundary if nzombies > MAX_ZOMBIES.
5031 * alloc.c (dump_zombies): Add missing format specifier.
5032
0324f3af
PE
50332011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5034
b5525cac
PE
5035 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5036 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5037
0324f3af
PE
5038 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5039 Some packages use them to denote characters with modifiers.
5040
e9b5f888
AS
50412011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5042
5043 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5044 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5045 matching a pp-number. Rename parameter var to var1.
5046
127827c0
SM
50472011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5048
5049 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5050
c8fd3bd0
GM
50512011-10-08 Glenn Morris <rgm@gnu.org>
5052
5053 * callint.c (Fcall_interactively): Give a more explicit error for the
5054 'c' case with a non-character input. (Bug#8479)
5055
352ec8ff
EZ
50562011-10-08 Eli Zaretskii <eliz@gnu.org>
5057
03669ccb
EZ
5058 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5059 lines.
7061c986
EZ
5060 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5061 lines that are hscrolled on the left.
03669ccb 5062
352ec8ff
EZ
5063 * dispnew.c (buffer_posn_from_coords): Account for a possible
5064 presence of header-line. (Bug#4426)
5065
a66cfb1c
SM
50662011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5067
6b02f655
SM
5068 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5069 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5070
7c5ee88e
PE
50712011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5072
5073 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5074 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5075 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5076 this makes Emacs dump core during garbage collection on rare
5077 occasions. sizeof is obviously inferior to offsetof here, so
5078 stick with offsetof.
5079 (GC_POINTER_ALIGNMENT): New macro.
5080 (mark_memory): Omit 3rd (offset) arg; caller changed.
5081 Don't assume EMACS_INT alignment is the same as pointer alignment.
5082
df1bbe5b
SM
50832011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5084
5085 * keyboard.c (read_key_sequence_remapped): New var.
5086 (read_key_sequence): Compute remapping in the right buffer.
5087 (command_loop_1): Use read_key_sequence's remapping directly.
5088
51553db6
SM
50892011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5090
32c1fffd
SM
5091 * dired.c (file_name_completion): Don't expand file name.
5092 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5093 before checking file name handler.
5094
51553db6
SM
5095 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5096 they've been requested explicitly (bug#9591).
5097
b6bd1599 50982011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5099
5100 * keymap.c (Fsingle_key_description): Use make_specified_string
5101 instead of build_string to build string from push_key_description.
5102 (Bug#5193)
5103
f701dc2a
PE
51042011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5105
4222c55d
PE
5106 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5107 This fixes a Y2038 bug on 64-bit hosts.
5108 * buffer.c (reset_buffer):
5109 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5110 (Fclear_buffer_auto_save_failure):
5111 Use 0, not -1, to represent an unset failure time, since time_t
5112 might not be signed.
5113
f701dc2a
PE
5114 Remove dependency on glibc malloc internals.
5115 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5116 Move back here from lisp.h, but with their new implementations.
5117 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5118 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5119 * charset.c (charset_table_init): New static var.
5120 (syms_of_charset): Use it instead of xmalloc. This removes a
5121 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5122 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5123 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5124 Move back to alloc.c.
5125 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5126 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5127
9ceebf39
JD
51282011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5129
5130 * nsterm.m (windowDidResize): Call x_set_window_size only when
5131 ns_in_resize is true. Otherwise set pixelwidth/height and
5132 call change_frame_size (Bug#9628).
5133
cb993c58
PE
51342011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5135
3930c88b
PE
5136 Port --enable-checking=all to Fedora 14 x86-64.
5137 * charset.c (syms_of_charset): Also account for glibc malloc's
5138 internal overhead when calculating the initial malloc maximum.
5139
cb993c58
PE
5140 Port --enable-checking=all to Fedora 14 x86.
5141 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5142 Move to lisp.h.
5143 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5144 (overrun_check_realloc, overrun_check_free):
5145 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5146 That way, xmalloc returns a properly-aligned pointer even if
5147 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5148 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5149 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5150 into account when calculating the initial malloc maximum.
5151 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5152 Move here from alloc.c, so that charset.c can use it too.
5153 Properly align; the old code wasn't right for common 32-bit hosts
5154 when configured with --enable-checking=all.
5155 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5156 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5157
31bed486
EZ
51582011-09-29 Eli Zaretskii <eliz@gnu.org>
5159
04c70788 5160 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5161 use EDOM.
5162
fbcaa2f3
EZ
51632011-09-28 Eli Zaretskii <eliz@gnu.org>
5164
5165 * xdisp.c (compute_display_string_end): If there's no display
5166 string at CHARPOS, return -1.
5167
5168 * bidi.c (bidi_fetch_char): When compute_display_string_end
5169 returns a negative value, treat the character as a normal
5170 character not covered by a display string. (Bug#9624)
5171
a239d4e9
JB
51722011-09-28 Juanma Barranquero <lekktu@gmail.com>
5173
5174 * lread.c (Fread_from_string): Fix typo in docstring.
5175
88652fd5
EZ
51762011-09-27 Eli Zaretskii <eliz@gnu.org>
5177
5178 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5179 newline, reseat the iterator instead of bidi-iterating there one
5180 character at a time. (Bug#9610)
32c1fffd
SM
5181 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5182 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5183
ed497dd4
AS
51842011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5185
5186 * lread.c (readevalloop): Use correct code for NBSP.
5187 (read1): Likewise. (Bug#9608)
5188
b2bf61aa
MA
51892011-09-25 Michael Albinus <michael.albinus@gmx.de>
5190
5191 * dbusbind.c (Fdbus_register_signal): When service is not
5192 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5193
32bbb17c
GM
51942011-09-25 Glenn Morris <rgm@gnu.org>
5195
5196 * buffer.c (truncate-lines): Doc fix.
5197
94e0933e
CY
51982011-09-24 Chong Yidong <cyd@stupidchicken.com>
5199
5200 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5201 (Fset_window_next_buffers): Doc fix.
5202
cddde921
GM
52032011-09-24 Glenn Morris <rgm@gnu.org>
5204
5205 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5206
1260aef1
PE
52072011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5208
25b4bfa0
PE
5209 Fix minor problems found by static checking.
5210 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5211 * indent.c (Fvertical_motion): Fix == vs = typo.
5212
e3cbd34b
EZ
52132011-09-24 Eli Zaretskii <eliz@gnu.org>
5214
a66cfb1c
SM
5215 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5216 Default value is now t. Doc fix.
6bf7006f 5217
e3cbd34b 5218 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5219 logic when moving up, not only when moving down. Fix the
e3cbd34b 5220 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5221 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5222
5223 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5224 CHARPOS is covered by a display string which includes newlines.
5225 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5226 is covered by a display string with embedded newlines.
5227
a3de0cbd
MA
52282011-09-24 Michael Albinus <michael.albinus@gmx.de>
5229
5230 * dbusbind.c (Fdbus_register_signal): Add match rule to
5231 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5232 (Fdbus_register_method, Vdbus_registered_objects_table):
5233 Fix docstring.
a3de0cbd 5234
b260039d
JM
52352011-09-24 Jim Meyering <meyering@redhat.com>
5236
32c1fffd 5237 do not ignore write error for any output size
b260039d
JM
5238 The previous change was incomplete.
5239 While it makes emacs --batch detect the vast majority of stdout
5240 write failures, errors were still ignored whenever the output size is
5241 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5242 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5243 && echo FAIL: ignored write error
5244 FAIL: ignored write error
5245 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5246 && echo FAIL: ignored write error
5247 FAIL: ignored write error
5248 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5249
8eca8a7c
AS
52502011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5251
5252 * emacs.c (Fkill_emacs): In noninteractive mode exit
5253 non-successfully if a write error occurred on stdout. (Bug#9574)
5254
3341db62
EZ
52552011-09-21 Eli Zaretskii <eliz@gnu.org>
5256
5257 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5258 the xassert test.
5259
5260 * dispextern.h (struct it): Update the comment documenting what
5261 can it->OBJECT be.
5262
8c203dbf
EZ
52632011-09-20 Eli Zaretskii <eliz@gnu.org>
5264
5265 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5266 a display string, extend search for cursor position to end of row.
5267 (find_row_edges): If the row ends in a newline from a display
5268 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5269 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5270 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5271 non-empty line. Fixes confusing cursor motion with arrow keys at
5272 the beginning of a line that starts with whitespace.
8c203dbf 5273
a4824228
LMI
52742011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5275
5276 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5277 (bug#9493).
5278
33ed493b
CY
52792011-09-18 Chong Yidong <cyd@stupidchicken.com>
5280
5281 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5282 boolean (Bug#9154).
5283
56cd55c8
EZ
52842011-09-18 Eli Zaretskii <eliz@gnu.org>
5285
5286 * xdisp.c (display_line): Record maximum and minimum buffer
5287 positions even if no glyphs were produced (e.g., by a zero-width
5288 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5289 buffer positions that will be removed from the glyph row because
5290 they don't fit.
c02dcedf
EZ
5291 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5292 column is beyond frame width: don't subtract 1 "pixel" when
5293 computing width of the stretch.
3e62b7e0
EZ
5294 (reseat_at_next_visible_line_start): Undo the change made on
5295 2011-09-17 that saved paragraph information and restored it after
5296 the call to `reseat'. (Bug#9545)
56cd55c8 5297
5ed99d36 52982011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5299
5300 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5301 and turn window cursor on if cleared (Bug#9415).
5302
5ed99d36 53032011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5304
5305 * search.c (boyer_moore): Take unibyte characters from pattern
5306 literally. (Bug#9458)
5307
9bade7b2
EZ
53082011-09-18 Eli Zaretskii <eliz@gnu.org>
5309
5310 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5311
e5e9d610
PE
53122011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5313
87e4427a
PE
5314 Fix minor problem found by static checking.
5315 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5316 initialized, to pacify gcc -Wuninitialized.
5317
e5e9d610
PE
5318 * fileio.c: Report proper errno when syscall falls.
5319 (Finsert_file_contents): Save and restore errno,
5320 so that report_file_error outputs the correct diagnostic.
5321 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5322
a1674f0b
EZ
53232011-09-18 Eli Zaretskii <eliz@gnu.org>
5324
5325 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5326
fbfb6dd4
EZ
53272011-09-17 Eli Zaretskii <eliz@gnu.org>
5328
5329 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5330 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5331
bb187662
EZ
53322011-09-17 Eli Zaretskii <eliz@gnu.org>
5333
1137e8b8 5334 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5335 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5336
5337 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5338 (bidi_find_paragraph_start): Search back for paragraph beginning
5339 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5340 (bidi_move_to_visually_next): Only trigger paragraph-related
5341 computations when the last character is a newline or at EOB, not
5342 just any NEUTRAL_B. (Bug#9470)
5343
bb187662
EZ
5344 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5345 truncated lines if point is covered by a display string. (Bug#9524)
5346
2e621251
PE
53472011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5348
5349 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5350 (cons_to_x_long): New function.
5351 (lisp_data_to_selection_data): Use it. Correct the test for
5352 short-versus-long data; it was negated. Break out of vector
5353 loop, for efficiency, when a long datum is discovered.
5354
91a15bc6
SM
53552011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5356
5357 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5358
b41c3a35
EZ
53592011-09-16 Eli Zaretskii <eliz@gnu.org>
5360
5361 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5362 GCC PR/17406) by declaring this function with external scope.
5363
7812ba2d
PE
53642011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5365
5366 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5367 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5368
cf7edc2a
AS
53692011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5370
5371 * editfns.c (Fformat): Correctly handle text properties on "%%".
5372
bd01620e
EZ
53732011-09-15 Eli Zaretskii <eliz@gnu.org>
5374
5375 * xterm.c (x_draw_composite_glyph_string_foreground):
5376 * w32term.c (x_draw_composite_glyph_string_foreground):
5377 * term.c (encode_terminal_code):
5378 * composite.c (composition_update_it, get_composition_id):
5379 * xdisp.c (get_next_display_element)
5380 (fill_composite_glyph_string): Add comments about special meaning
5381 of TAB characters in a composition.
5382
a02719a3
PE
53832011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5384
5385 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5386 This occurs when processing a multibyte format.
5387 Problem reported by Wolfgang Jenker.
a02719a3 5388
72589a3c
JB
53892011-09-15 Johan Bockgård <bojohan@gnu.org>
5390
5391 * xdisp.c (try_cursor_movement): Only check for exact match if
5392 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5393
1c14176c
PE
53942011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5395
5396 Remove unused external symbols.
5397 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5398 * xdisp.c (calc_pixel_width_or_height): Now static.
5399 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5400 * indent.c (check_display_width):
5401 * w32term.c: Fix comment to match code.
5402 * xterm.c, xterm.h (x_catching_errors): Remove.
5403
d2eea5b5
PE
54042011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5405
5406 * xselect.c: Use signed conversions more consistently (Bug#9498).
5407 (selection_data_to_lisp_data): Assume incoming selection data are
5408 signed integers, not unsigned. This is to be consistent with
5409 outgoing selection data, which was modified to use signed integers
5410 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5411 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5412 expects long, not unsigned long.
5413
46888499
EZ
54142011-09-14 Eli Zaretskii <eliz@gnu.org>
5415
5416 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5417 computation of loop end. Reported by Johan Bockgård
5418 <bojohan@gnu.org>.
5419
ef8ef9fb
CY
54202011-09-13 Chong Yidong <cyd@stupidchicken.com>
5421
5422 * frame.c (Fother_visible_frames_p): Function deleted.
5423
fa819fed
EZ
54242011-09-12 Eli Zaretskii <eliz@gnu.org>
5425
5426 * indent.c (compute_motion): Process display vector front to back
5427 rather than the other way around. (Bug#2496)
5428
2ba8e008
SM
54292011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5430
5431 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5432
20f53c69
CY
54332011-09-11 Chong Yidong <cyd@stupidchicken.com>
5434
5435 * minibuf.c (Fread_from_minibuffer): Doc fix.
5436
d562d7a4
EZ
54372011-09-11 Eli Zaretskii <eliz@gnu.org>
5438
5439 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5440 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5441
1c4d7f3d
LMI
54422011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5443
5444 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5445 value for non-existent files.
5446
b885bf36
EZ
54472011-09-11 Eli Zaretskii <eliz@gnu.org>
5448
5449 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5450 set its "size" to -1. This will set the modtime_size field of
5451 the corresponding buffer to -1, which is what
5452 verify-visited-file-modtime expects for files that do not exist.
5453 (Bug#9139)
5454
6612f0bf
PE
54552011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5456
5457 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5458 here ...
5459 * lisp.h: ... from here. push_key_description is no longer
5460 defined in keyboard.c, so its declaration should not be in
5461 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5462 logically belongs with push_key_description.
5463
dfb3f755
PE
54642011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5465
5466 * buffer.h: Include <sys/types.h> instead of <time.h>.
5467 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5468 Problem reported by Herbert J. Skuhra.
5469
3134906c
LMI
54702011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5471
5472 * xml.c (parse_region): Make the parsing work for
5473 non-comment-starting XML files again (bug#9144).
5474
8d903f4e
AS
54752011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5476
5477 * image.c (gif_load): Fix calculation of bottom and right corner.
5478 (Bug#9468)
5479
80ad64f4
EZ
54802011-09-10 Eli Zaretskii <eliz@gnu.org>
5481
5482 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5483 redisplay in small windows.
5484
208a048d
EZ
54852011-09-09 Eli Zaretskii <eliz@gnu.org>
5486
5487 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5488
9b1c252e
MR
54892011-09-08 Martin Rudalics <rudalics@gmx.at>
5490
5491 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5492 Operate on live windows only.
5493
2949f33b
JB
54942011-09-08 Juanma Barranquero <lekktu@gmail.com>
5495
5496 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5497
e08dcafd
EZ
54982011-09-07 Eli Zaretskii <eliz@gnu.org>
5499
5500 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5501 only under bidi iteration.
5502
115b96bd
JD
55032011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5504
5505 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5506
c8199d0f
PE
55072011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5508
5509 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5510 Without this fix, the command to link temacs failed due to an
5511 undefined symbol __builtin_isnan. This is because
5512 /usr/include/iso/math_c99.h #defines isnan(x) to
5513 __builtin_isnan(x), but the bundled gcc, which identifies itself
5514 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5515 a __builtin_isnan.
5516 * floatfns.c (isnan): #undef, and then #define to a clone of
5517 what's in data.c.
5518 (Fisnan): Always define, since it's always available now.
5519 (syms_of_floatfns): Always define isnan at the Lisp level.
5520
e39b275c 55212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5522
5523 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5524
b2db44d9 55252011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5526
f4af5137 5527 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5528 The previous code assumed that file offsets (off_t values) fit in
5529 EMACS_INT variables, which is not true on typical 32-bit hosts.
5530 The code messed up by falsely reporting buffer overflow in cases
5531 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5532 when "big" contains more than 2**29 bytes, even though this
5533 inserts just one byte and does not overflow the buffer.
5534 (Finsert_file_contents): Store file offsets as off_t
5535 values, not as EMACS_INT values. Check for overflow when
5536 converting between EMACS_INT and off_t. When checking for
5537 buffer overflow or for overlap, take the offsets into account.
5538 Don't use EMACS_INT for small values where int suffices.
5539 When checking for overlap, fix a typo: ZV was used where
5540 ZV_BYTE was intended.
5541 (Fwrite_region): Don't assume off_t fits into 'long'.
5542 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5543
ecfc0a49
MA
55442011-09-05 Michael Albinus <michael.albinus@gmx.de>
5545
5546 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5547
6511acf2 55482011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5549
0999621a 5550 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5551
5552 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5553 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5554 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5555 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5556 (modify_event_symbol): Do not assume that the length of
5557 name_alist_or_stem is safe to alloca and fits in int.
5558 (Fexecute_extended_command): Likewise for function name and binding.
5559 (Frecursion_depth): Wrap around reliably on integer overflow.
5560 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5561 since some callers pass EMACS_INT values.
5562 (Fsingle_key_description): Don't crash if symbol name contains more
5563 than MAX_ALLOCA bytes.
5564 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5565 (get_minibuffer): Arg is now EMACS_INT, not int.
5566 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5567 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5568 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5569
2be7d702
PE
5570 * dbusbind.c (signature_cat): New function.
5571 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5572 Do not overrun buffer; instead, report string overflow.
5573
9d1df220
PE
5574 * dispnew.c (add_window_display_history): Don't overrun buffer.
5575 Truncate instead; this is OK since it's just a log.
5576
33ef5c64
PE
5577 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5578 even if the time zone offset is outlandishly large.
5579 Don't mishandle offset == INT_MIN.
5580
66c6fdd5
PE
5581 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5582 when creating daemon; the previous buffer-overflow check was incorrect.
5583
d749b01b
PE
5584 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5585 which has the guts of the old verror function.
5586
b5cd1905
PE
5587 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5588 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5589
6e1a67fb
PE
5590 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5591 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5592 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5593 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5594 length of string rather than counting it via multiple sprintfs;
5595 that's simpler and more reliable.
c21721cc
PE
5596 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5597 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5598 sprintf, in case result does not fit in int.
5599
c57b67fc
PE
5600 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5601 (fontset_from_font): Print it.
5602
8a401434
PE
5603 * frame.c (tty_frame_count): Now printmax_t, not int.
5604 (make_terminal_frame, set_term_frame_name): Print it.
5605 (x_report_frame_params): In X, window IDs are unsigned long,
5606 not signed long, so print them as unsigned.
5607 (validate_x_resource_name): Check for implausibly long names,
5608 and don't assume name length fits in 'int'.
5609 (x_get_resource_string): Don't blindly alloca invocation name;
5610 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5611 not fit in int.
5612
6e1a67fb
PE
5613 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5614 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5615 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5616
0df02bf3
PE
5617 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5618 Use esprintf, not sprintf, in case result does not fit in int.
5619
48e30793
PE
5620 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5621 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5622 it as a large positive number.
5623 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5624 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5625
a66ff6d8
PE
5626 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5627 in case result does not fit in int.
5628
aca216ff
PE
5629 * print.c (float_to_string): Detect width overflow more reliably.
5630 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5631 buffer overrun. Don't assume list length fits in 'int'. Treat
5632 print length of 0 as 0, not as infinity; to be consistent with other
5633 uses of print length in this function. Don't overflow print length
5634 index. Don't assume hash table size fits in 'long', or that
5635 vectorlike size fits in 'unsigned long'.
5636
31c286f7
PE
5637 * process.c (make_process): Use printmax_t, not int, to format
5638 process-name gensyms.
5639
55e5faa1
PE
5640 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5641
80f2e268
PE
5642 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5643 to avoid potential buffer overrun.
5644
670741ab
PE
5645 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5646 if X resource line is longer than 512 bytes.
5647
b7163a50
PE
5648 * xfns.c (x_window): Make sprintf buffer a bit bigger
5649 to avoid potential buffer overrun.
5650
ae58ff1f
PE
5651 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5652
c43c8a6a
PE
5653 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5654
3f8236f4
PE
56552011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5656
53e9fe90 5657 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5658 Without these, Emacs silently mishandles large integers sometimes.
5659 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5660 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5661
6511acf2
PE
5662 * xdisp.c (try_window_id): Check Emacs fixnum range before
5663 converting to 'int'.
806add1d 5664
6511acf2 5665 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5666 Check that an Emacs fixnum is in range before assigning it to 'int'.
5667 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5668 values converted from Emacs fixnums.
5669 (Frecenter): Don't wrap around a line count if it is out of 'int'
5670 range; instead, treat it as an extreme value.
5671 (Fset_window_configuration, compare_window_configurations):
5672 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5673
6511acf2
PE
5674 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5675 that can exceed INT_MAX. Check that EMACS_INT value is in range
5676 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5677 (match_limit): Don't assume that a fixnum can fit in 'int'.
5678
6511acf2 5679 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5680 exceed INT_MAX.
5681
6511acf2 5682 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5683 (Fvertical_motion): Don't wrap around LINES values that don't fit
5684 in 'int'. Instead, treat them as extreme values. This is good
5685 enough for windows, which can't have more than INT_MAX lines anyway.
5686
fcb901a7
LMI
56872011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5688
0f2f6b6d
LMI
5689 * Require libxml/parser.h to avoid compilation warning.
5690
fcb901a7
LMI
5691 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5692
5693 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5694 since this reportedly can destroy thread storage.
5695
6e20a0d4
CY
56962011-08-30 Chong Yidong <cyd@stupidchicken.com>
5697
5698 * syntax.c (find_defun_start): Update all cache variables if
5699 exiting early (Bug#9401).
5700
148ae00e
EZ
57012011-08-30 Eli Zaretskii <eliz@gnu.org>
5702
f6cfbd8f
EZ
5703 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5704
148ae00e
EZ
5705 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5706 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5707 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5708
5709 * term.c (tty_append_glyph): New function.
5710 (produce_stretch_glyph): Static function and its prototype deleted.
5711
a66cfb1c
SM
5712 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5713 Add prototypes.
148ae00e 5714
c4a07a4c
PE
57152011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5716
5717 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5718 when checking :margin (Bug#9390).
5719 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5720 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5721 so that the name doesn't mislead. All uses changed.
5722
6bc8cd65
JB
57232011-08-28 Johan Bockgård <bojohan@gnu.org>
5724
5725 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5726 set_tty_hooks.
5727
dca4927e
EZ
57282011-08-27 Eli Zaretskii <eliz@gnu.org>
5729
5730 * xdisp.c (move_it_to): Don't bail out early when reaching
5731 position beyond to_charpos, if we are scanning backwards.
5732 (move_it_vertically_backward): When DY == 0, make sure we get to
5733 the first character in the line after the newline.
5734
f2cad773
PE
57352011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5736
5737 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5738 (ccl_driver): Do not generate an out-of-range pointer.
5739 (Fccl_execute_on_string): Remove unnecessary check for
5740 integer overflow, noted by Stefan Monnier in
5741 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5742 Remove a FIXME that didn't need fixing.
5743 Simplify the newly-introduced buffer reallocation code.
5744
0cae2cdb
JB
57452011-08-27 Juanma Barranquero <lekktu@gmail.com>
5746
5747 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5748
5fc295a4 57492011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5750
70c60eb2 5751 Integer and memory overflow issues (Bug#9196).
726e0ab1 5752
d31850da
PE
5753 * doc.c (get_doc_string): Rework so that
5754 get_doc_string_buffer_size is the actual buffer size, rather than
5755 being 1 less than the actual buffer size; this makes xpalloc more
5756 convenient.
5757
a69fbedb
PE
5758 * image.c (x_allocate_bitmap_record, cache_image):
5759 * xselect.c (Fx_register_dnd_atom):
5760 Simplify previous changes by using xpalloc.
5761
fe5c5d37
PE
5762 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5763 since either will do and ptrdiff_t is convenient with xpalloc.
5764
0065d054
PE
5765 * charset.c (charset_table_size)
5766 (struct charset_sort_data.priority): Now ptrdiff_t.
5767 (charset_compare): Don't overflow if priorities differ greatly.
5768 (Fsort_charsets): Don't assume list length fits in int.
5769 Check for size-calculation overflow when allocating sort data.
5770 (syms_of_charset): Allocate an initial charset table that is
5771 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5772
5773 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5774
5775 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5776 The actual value is always <= INT_MAX, and leaving it unsigned made
5777 overflow checking harder.
5778
5779 * dispextern.h (struct glyph_matrix.rows_allocated)
5780 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5781 with xpalloc. The values are still always <= INT_MAX.
5782
5783 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5784
5785 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5786 (SAFE_NALLOCA): New macro.
5787
5788 * region-cache.c (struct boundary.pos, find_cache_boundary)
5789 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5790 (set_cache_region, invalidate_region_cache)
5791 (revalidate_region_cache, know_region_cache, region_cache_forward)
5792 (region_cache_backward, pp_cache):
5793 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5794 so that ptrdiff_t * can be passed to xpalloc.
5795 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5796 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5797 (pp_cache): Don't assume cache_len fits in int.
5798 * region-cache.h: Adjust extern decls to match.
5799
5800 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5801 EMACS_INT, since either will do, for xpalloc.
5802
5803 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5804 (xnmalloc, xnrealloc, xpalloc): New functions.
5805
726e0ab1
PE
5806 * bidi.c (bidi_shelve_header_size): New constant.
5807 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5808 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5809
51f30bc5 5810 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5811 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5812 (overlay_strings):
5813 Don't update size of array until after memory allocation succeeds,
5814 because xmalloc/xrealloc may not return.
0065d054
PE
5815 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5816 now that we have proper integer overflow checking.
5817 (record_overlay_string, overlay_strings): Catch overflows when
5818 calculating size of overlay_str_buf.
726e0ab1 5819
0065d054
PE
5820 * callproc.c (Fcall_process): Check for size overflow when
5821 calculating size of args2.
5822 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5823 Normally we prefer signed values, but sticking with ptrdiff_t would
5824 require adding more-complicated checks.
726e0ab1
PE
5825
5826 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5827 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5828 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5829 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5830
5831 * character.c (Fstring): Check for size-calculation overflow.
5832
5833 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5834 unnecessary integer overflow. Check for size overflow.
5835 (encode_coding_object): Don't update size until xmalloc succeeds.
5836
5837 * composite.c (get_composition_id): Check for overflow in glyph
5838 length calculations.
5839
5840 Integer and memory overflow fixes for display code.
5841 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5842 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5843 (scrolling_window): Check for overflow in size calculations.
5844 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5845 Don't assume glyph table len fits in int.
5846 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5847 (row_table_size): Now ptrdiff_t, not int.
5848 (scrolling_window): Avoid overflow in size calculations.
5849 Don't update size until allocation succeeds.
5850 * fns.c (concat): Check for overflow in size calculations.
5851 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5852 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5853 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5854
5855 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5856 (get_doc_string): Check for size calculation overflow.
5857 Don't update size until allocation succeeds.
5858 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5859 EMACS_INT, where ptrdiff_t will do.
5860 (Fsubstitute_command_keys): Check for string overflow.
5861
5862 * editfns.c (set_time_zone_rule): Don't assume environment length
5863 fits in int.
5864 (message_length): Now ptrdiff_t, not int.
5865 (Fmessage_box): Don't update size until allocation succeeds.
5866 Don't assume message length fits in int.
5867 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5868
0065d054
PE
5869 * emacs.c (main): Do not reallocate argv, since there is a null at
5870 the end that can be overwritten, and this way there's no need to
5871 worry about size-calculation overflow.
5872 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5873
5874 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5875 alloc succeeds.
5876 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5877
5878 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5879 (x_set_scroll_bar_width, x_figure_window_size):
5880 Check for integer overflow.
5881 (x_set_alpha): Do not assume XINT fits in int.
5882
5883 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5884 This is for the members text_lines, text_cols, total_lines, total_cols,
5885 where the system imposes an 'int' limit.
5886
5887 * fringe.c (Fdefine_fringe_bitmap):
5888 Don't update size until alloc works.
5889
5890 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5891 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5892
5893 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5894 Check for size-calculation overflow.
5895 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5896 do, as we prefer signed integers.
5897 (id_to_widget.max_size, id_to_widget.used)
5898 (xg_store_widget_in_map, xg_remove_widget_from_map)
5899 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5900 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5901 Use and return ptrdiff_t, not int.
5902 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5903 * gtkutil.h: Change prototypes to match the above.
5904
5905 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5906 are duplicate now that they've been promoted to lisp.h.
5907 (x_allocate_bitmap_record, x_alloc_image_color)
5908 (make_image_cache, cache_image, xpm_load):
5909 Don't update size until alloc is done.
5910 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5911 (x_detect_edges):
3256efce 5912 Check for size calculation overflow.
726e0ab1
PE
5913 (ct_colors_allocated_max): New constant.
5914 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5915 overflow.
3256efce 5916
726e0ab1
PE
5917 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5918 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5919 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5920 Use ptrdiff_t, not int, to count maps.
5921 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5922 calculations. Don't update size until allocation succeeds.
5923 Redo calculations to avoid overflow.
726e0ab1
PE
5924 * keyboard.h: Change prototypes to match the above.
5925
5926 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5927 to count maps.
5928 (current_minor_maps): Check for size calculation overflow.
5929 * keymap.h: Change prototypes to match the above.
5930
5931 * lread.c (read1, init_obarray): Don't update size until alloc done.
5932
5933 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5934 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5935
726e0ab1
PE
5936 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5937 Now ptrdiff_t, not int.
5938 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5939 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5940
5941 * process.c (Fnetwork_interface_list): Check for overflow
5942 in size calculation.
5943
5944 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5945
5946 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5947 overflow. Don't bother calling xmalloc when xrealloc will do.
5948
5949 * search.c (Freplace_match): Check for size calculation overflow.
5950 (Fset_match_data): Don't assume list lengths fit in 'int'.
5951
5952 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5953 for command line length. Do not attempt to address one before the
5954 beginning of an array, as that's not portable.
5955
5956 * term.c (max_frame_lines): Remove; unused.
5957 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5958 not int.
5959 (encode_terminal_code, calculate_costs): Check for size
5960 calculation overflow.
5961 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5962 table lengths and related sizes. Don't update size until alloc
5963 done. Redo calculations to avoid overflow.
5964 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5965
5966 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5967 subtracting pointers.
5968 (gobble_line): Check for overflow more carefully. Don't update size
5969 until alloc done.
5970
5971 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5972 Don't update size until alloc done.
5973 Redo size calculations to avoid overflow.
5974 Check for size calculation overflow.
0065d054 5975 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5976
5977 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5978 Use ptrdiff_t, not int, for sizes.
5979 (store_mode_line_noprop_char): Don't update size until alloc done.
5980
0065d054
PE
5981 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5982 Use ptrdiff_t, not int, for sizes.
5983 (Finternal_make_lisp_face, cache_face):
5984 Check for size calculation overflow.
5985 (cache_face): Treat size calculation overflows as if they were
5986 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5987
5988 * xfns.c (x_encode_text, x_set_name_internal)
5989 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5990 sizes, since they can exceed INT_MAX in size. Check for size
5991 calculation overflow.
5992
0065d054
PE
5993 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5994 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5995 Don't update size until alloc done.
5996
0065d054 5997 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5998 as sprintf is limited to int lengths.
1d526e2f 5999
252c5ee1
PE
6000 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6001 (X_LONG_MIN): New macros.
864d7ce7
PE
6002 Use them to make the following changes clearer.
6003 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6004 This change doesn't affect the value now, but it may help remind
6005 future maintainers not to raise the value too much later.
6006 (SELECTION_QUANTUM): Remove, replacing with ...
6007 (selection_quantum): ... new function, which avoids overflow.
6008 All uses changed.
6009 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6010 assumption that selection length fits in 'int'.
6011 (x_reply_selection_request, x_handle_selection_request)
6012 (x_get_window_property, receive_incremental_selection)
6013 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6014 (lisp_data_to_selection_data, clean_local_selection_data):
6015 Use ptrdiff_t, not int, to record length of selection.
6016 (x_reply_selection_request, x_get_window_property)
6017 (receive_incremental_selection, x_property_data_to_lisp):
6018 Redo calculations to avoid overflow.
6019 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6020 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6021 something.
6022 (x_get_window_property, receive_incremental_selection)
6023 (lisp_data_to_selection_data, x_property_data_to_lisp):
6024 Check for size-calculation overflow.
6025 (x_get_window_property, receive_incremental_selection)
6026 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6027 Don't store size until memory allocation succeeds.
6028 (x_get_window_property): Plug memory leak on memory exhaustion.
6029 Don't double-block input; malloc is safe here. Don't assume 2**34
6030 - 4 fits in unsigned long. Add an xassert to check
6031 XGetWindowProperty overflow. Be more careful about overflow
6032 calculations, and distinguish size from memory overflow better.
6033 (receive_incremental_selection): When tracing, don't assume
6034 unsigned int is less than INT_MAX.
6035 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6036 harmful) conversions of unsigned short to int.
6037 (lisp_data_to_selection_data): Don't assume that integers
6038 in the range -65535 through -1 fit in an X unsigned short.
6039 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6040 result parameters unless successful. Rely on cons_to_unsigned
6041 to report problems with elements; the old code wasn't right anyway.
6042 (x_check_property_data): Check for int overflow; we cannot use
6043 a wider type due to X limits.
6044 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6045
726e0ab1 6046 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6047
0065d054
PE
6048 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6049 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6050 (x_color_cells): Don't store size until memory allocation succeeds.
6051 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6052 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6053 (x_term_init): Don't assume length fits in int (sprintf is limited
6054 to int size).
bc18e09d 6055
ebfa62c0
PE
6056 Use ptrdiff_t for composition IDs.
6057 * character.c (lisp_string_width):
6058 * composite.c (composition_table_size, n_compositions)
6059 (get_composition_id, composition_gstring_from_id):
6060 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6061 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6062 * window.c (Frecenter):
6063 Use ptrdiff_t, not int, for composition IDs.
6064 * composite.c (get_composition_id): Check for integer overflow.
6065 * composite.h: Adjust prototypes to match the above changes.
6066
d3411f89
PE
6067 Use ptrdiff_t for hash table indexes.
6068 * category.c (hash_get_category_set):
6069 * ccl.c (ccl_driver):
6070 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6071 * coding.c (coding_system_charset_list, detect_coding_system):
6072 * coding.h (struct coding_system.id):
6073 * composite.c (get_composition_id, gstring_lookup_cache):
6074 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6075 * image.c (xpm_get_color_table_h):
6076 * lisp.h (hash_lookup, hash_put):
6077 * minibuf.c (Ftest_completion):
6078 Use ptrdiff_t for hash table indexes, not int (which is too
6079 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6080 32-bit --with-wide-int hosts).
6081
e097a6fa
PE
6082 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6083 Add a FIXME comment about memory leaks.
6084 (syms_of_charset): Don't assume xmalloc returns.
6085
5637687f
PE
6086 Don't assume that stated character widths fit in int.
6087 * character.c (Fchar_width, c_string_width, lisp_string_width):
6088 * character.h (CHAR_WIDTH):
6089 * indent.c (MULTIBYTE_BYTES_WIDTH):
6090 Use sanitize_char_width to avoid undefined and/or bad behavior
6091 with outlandish widths.
a66cfb1c 6092 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6093 now that we have two such functions. All uses changed.
6094 (sanitize_char_width): New inline function.
6095
a2271ba2
PE
6096 Don't assume that tab-width fits in int.
6097 * character.h (sanitize_width): New inline function.
6098 (SANE_TAB_WIDTH): New macro.
6099 (ASCII_CHAR_WIDTH): Use it.
6100 * indent.c (sane_tab_width): Remove. All uses replaced by
6101 SANE_TAB_WIDTH (current_buffer).
6102 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6103
18c52557
PE
6104 * fileio.c: Integer overflow issues with file modes.
6105 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6106
caeeedc1
PE
6107 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6108 Remove unreachable code.
6109 (read_hex, load_charset_map_from_file): Check for integer overflow.
6110
6df6ae42 6111 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6112 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6113 (x_send_scroll_bar_event): Likewise. Check that the size does not
6114 exceed limits imposed by XClientMessageEvent, as well as the usual
6115 ptrdiff_t and size_t limits.
6116
b13995db
PE
6117 * keyboard.c: Overflow, signedness and related fixes.
6118 (make_lispy_movement): Use same integer type in forward decl
6119 that is used in the definition.
6120 (read_key_sequence, keyremap_step):
6121 Change bufsize argument back to int, undoing my 2011-03-30 change.
6122 We prefer signed types, and int is wide enough here.
6123 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6124 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6125 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6126 length, not size_t. Use ptrdiff_t for index, not int.
6127 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6128 possibility of integer overflow.
6129
13464394
PE
6130 Overflow, signedness and related fixes for images.
6131
6132 * dispextern.h (struct it.stack[0].u.image.image_id)
6133 (struct_it.image_id, struct image.id, struct image_cache.size)
6134 (struct image_cache.used, struct image_cache.ref_count):
6135 * gtkutil.c (update_frame_tool_bar):
6136 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6137 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6138 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6139 * nsmenu.m (update_frame_tool_bar):
6140 * xdisp.c (calc_pixel_width_or_height):
6141 * xfns.c (image_cache_refcount):
6142 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6143 on typical 64-bit hosts.
6144
6145 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6146 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6147 Omit unnecessary casts to int.
6148 (parse_image_spec): Check that integers fall into 'int' range
6149 when the callers expect that.
6150 (image_ascent): Redo ascent calculation to avoid int overflow.
6151 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6152 (lookup_image): Remove unnecessary tests.
6153 (xbm_image_p): Locals are now of int, not EMACS_INT,
6154 since parse_image_check makes sure they fit into int.
6155 (png_load, gif_load, svg_load_image):
6156 Prefer int to unsigned where either will do.
6157 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6158 old tiff_error_handler and tiff_warning_handler.
6159 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6160 stack buffer overflows. It uses only the features of vsnprintf
6161 that are common to both POSIX and native Microsoft.
6162 (tiff_error_handler, tiff_warning_handler): Use it.
6163 (tiff_load, gif_load, imagemagick_load_image):
6164 Don't assume :index value fits in 'int'.
6165 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6166 (imagemagick_load_image): Check that crop parameters fit into
6167 the integer types that MagickCropImage accepts. Don't assume
6168 Vimagemagick_render_type has a nonnegative value. Don't assume
6169 size_t fits in 'long'.
6170 (gs_load): Use printmax_t to print the widest integers possible.
6171 Check for integer overflow when computing image height and width.
6172
c11821d4
EZ
61732011-08-26 Eli Zaretskii <eliz@gnu.org>
6174
6175 * xdisp.c (redisplay_window): Don't force window start if point
6176 will be invisible in the resulting window. (Bug#9324)
6177
0c95fcf7
EZ
61782011-08-25 Eli Zaretskii <eliz@gnu.org>
6179
6180 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6181 the display spec is of the form `(space ...)'.
6182 (handle_display_spec): Return the value returned by
6183 handle_single_display_spec, not just 1 or zero.
6184 (handle_single_display_spec): If the display spec is of the form
6185 `(space ...)', and specifies display in the text area, return 2
6186 rather than 1.
fee65a97 6187 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6188 accurately, and prefer exact match for point under bidi.
6189 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6190
6191 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6192 into disp_prop; all users changed.
6193
6194 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6195 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6196 for the text covered by the display property.
6197
e4ed06f1
CY
61982011-08-25 Chong Yidong <cyd@stupidchicken.com>
6199
6200 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6201 Change return value to nil.
6202 (Frecord_buffer): Delete unused function.
6203
f67cdd7f
EZ
62042011-08-24 Eli Zaretskii <eliz@gnu.org>
6205
5980d4c6
EZ
6206 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6207 buffers, return left-to-right.
8610fe8b
EZ
6208 (set_cursor_from_row): Consider candidate row a win if its glyph
6209 represents a newline and point is on that newline. Fixes cursor
6210 positioning on the newline at EOL of R2L text within L2R
6211 paragraph, and vice versa.
6212 (try_cursor_movement): Check continued rows, in addition to
6213 continuation rows. Fixes unwarranted scroll when point enters a
6214 continued line of R2L text within an L2R paragraph, or vice versa.
6215 (cursor_row_p): Consider the case of point being equal to
6216 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6217 from the end of a short line to the beginning of a continued line
6218 of R2L text within L2R paragraph.
6219 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6220 composed characters.
5980d4c6 6221
f67cdd7f
EZ
6222 * bidi.c (bidi_check_type): Use xassert.
6223 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6224 members.
6225
bca633fb
EZ
62262011-08-23 Eli Zaretskii <eliz@gnu.org>
6227
6228 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6229 a character.
6230
4a5885a7
CY
62312011-08-23 Chong Yidong <cyd@stupidchicken.com>
6232
6233 * nsfont.m (ns_otf_to_script): Fix typo.
6234
0902a04e
KH
62352011-08-22 Kenichi Handa <handa@m17n.org>
6236
6237 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6238 extra slot even if the purpose is char-code-property-table.
6239
1a2e6670
EZ
62402011-08-23 Eli Zaretskii <eliz@gnu.org>
6241
8ddde651
EZ
6242 * xdisp.c (redisplay_window): When computing centering_position,
6243 account for the height of the header line. (Bug#8874)
6244
425cc014
EZ
6245 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6246 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6247 candidate is selected by the mouse, and that candidate has a
6248 composed character under the mouse.
6249
1a2e6670
EZ
6250 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6251 coordinates reported by pos-visible-in-window-p for a composed
6252 character in column zero.
6253
8b76d6f8
SM
62542011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6255
6256 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6257
dac347dd
EZ
62582011-08-22 Eli Zaretskii <eliz@gnu.org>
6259
6260 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6261 consider it a hit if to_charpos is anywhere in the range of the
6262 composed buffer positions.
6263
e013fb34
CY
62642011-08-22 Chong Yidong <cyd@stupidchicken.com>
6265
6266 * image.c (gif_load): Don't assume that each subimage has the same
6267 dimensions as the base image. Handle disposal method that is
6268 "undefined" by the gif spec (Bug#9335).
6269
bd1ba3e8
CY
62702011-08-20 Chong Yidong <cyd@stupidchicken.com>
6271
6272 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6273 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6274
54a1215b
EZ
62752011-08-19 Eli Zaretskii <eliz@gnu.org>
6276
823564e5
EZ
6277 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6278 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6279 from an Org mode buffer to a Speedbar frame.
6280
54a1215b
EZ
6281 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6282 a composition, take its buffer position from IT->cmp_it.charpos.
6283 Fixes cursor positioning at the beginning of a line that begins
6284 with a composed character.
6285
9778ebcc
EZ
62862011-08-18 Eli Zaretskii <eliz@gnu.org>
6287
0be6ee06
EZ
6288 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6289 character bidirectional type, use STRONG_L instead. Fixes crashes
6290 in a buffer produced by `describe-categories'.
6291
9778ebcc
EZ
6292 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6293 members before the level stack, so they would be saved and
6294 restored when copying iterator state. Fixes incorrect reordering
6295 around TABs covered by display properties.
6296
156bffbe
AS
62972011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6298
6b02f655 6299 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6300
72ad093b
CY
63012011-08-17 Chong Yidong <cyd@stupidchicken.com>
6302
6303 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6304 (internal_condition_case_2, internal_condition_case_n):
6305 Remove unnecessary aborts (Bug#9081).
72ad093b 6306
35774242
EZ
63072011-08-17 Eli Zaretskii <eliz@gnu.org>
6308
6309 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6310 has no `load' handler, try opening the file locally. (Bug#9311)
6311
db76dd85
KB
63122011-08-16 Ken Brown <kbrown@cornell.edu>
6313
6314 * gmalloc.c: Expand comment.
6315
b215eee5
EZ
63162011-08-16 Eli Zaretskii <eliz@gnu.org>
6317
6318 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6319 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6320
a4579d33
KB
63212011-08-16 Ken Brown <kbrown@cornell.edu>
6322
6323 Fix memory allocation problems in Cygwin build (Bug#9273).
6324
6325 * unexcw.c ( __malloc_initialized): Declare external variable.
6326 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6327
8b76d6f8
SM
6328 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6329 New variables.
a4579d33
KB
6330 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6331 dumped emacs.
6332 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6333 in the static heap.
6334 [CYGWIN] (special_realloc): New function.
6335 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6336 requests to realloc storage in the static heap.
6337
3ebec551
PE
63382011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6339
6340 * bidi.c (bidi_initialize): Remove unused local.
6341
9fd8be00
EZ
63422011-08-15 Eli Zaretskii <eliz@gnu.org>
6343
6b02f655
SM
6344 * bidimirror.h:
6345 * biditype.h: Remove file.
6346 * makefile.w32-in ($(BLD)/bidi.$(O)):
6347 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6348
6349 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6350
6351 * chartab.c: Improve commentary for the uniprop_table API.
6352
32413314
EZ
6353 * bidi.c (bidi_paragraph_init): Support zero value of
6354 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6355 (bidi_initialize): Use uniprop_table instead of including
6356 biditype.h and bidimirror.h.
32413314 6357
9fd8be00
EZ
6358 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6359 coordinates of the iterator when restoring from ppos_it.
6360 (Bug#9296)
6361
5cf2b69b
KH
63622011-08-14 Kenichi Handa <handa@m17n.org>
6363
6364 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6365 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6366
daf17d00
EZ
63672011-08-14 Eli Zaretskii <eliz@gnu.org>
6368
6369 * xdisp.c (move_it_in_display_line_to): Don't invoke
6370 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6371 ppos_it. Fixes vertical cursor motion when line beginning is
6372 covered by an image. (Bug#9296)
6373
08e3161a
JD
63742011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6375
6376 * nsterm.h (ns_run_ascript): Declare.
6377 (NSAPP_DATA2_RUNASSCRIPT): Define.
6378
6379 * nsfns.m (as_script, as_result, as_status): New static variables.
6380 (ns_run_ascript): New function.
5e617bc2 6381 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6382 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6383 the event loop. Get status from as_status (Bug#7276).
6384
6385 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6386 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6387 the event loop (Bug#7276).
6388
a3720aa2
AS
63892011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6390
6391 * gnutls.c (QCgnutls_bootprop_priority)
6392 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6393 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6394 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6395 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6396 (QCgnutls_bootprop_verify_hostname_error)
6397 (QCgnutls_bootprop_callbacks_verify): Rename from
6398 Qgnutls_bootprop_..., all uses changed.
6399
6400 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6401 uses changed.
6402
0a0d27fb
PE
64032011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6404
19d5c50c
PE
6405 * xfaces.c (Qframe_set_background_mode): Now static.
6406 * dispextern.h (Qframe_set_background_mode): Remove decl.
6407
0a0d27fb
PE
6408 * process.c (Fnetwork_interface_info): Declare local only if needed.
6409
377538cb
JD
64102011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6411
6412 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6413 (Fnetwork_interface_list): Allocate in increments of bytes instead
6414 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6415 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6416 sockaddr.
6417 (struct ifflag_def): notrailers is smart on OSX.
6418 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6419 Get hardware address with getifaddrs if available.
6420
08fff70c
EZ
64212011-08-12 Eli Zaretskii <eliz@gnu.org>
6422
6423 * xdisp.c (iterate_out_of_display_property): xassert that
6424 IT->position is set to within IT->object's boundaries. Break from
6425 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6426 when IT->position is set up wrongly due to some bug.
6427 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6428 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6429 entry. Force push_it to save on the stack the current
6430 buffer/string position, to be restored by pop_it. Fix flags in
6431 the iterator structure wrt the object coming from a display
6432 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6433 properties. (Bug#9284)
6434
7be1c708 64352011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6436
7be1c708
CY
6437 * fontset.c (fontset_get_font_group): Add proper type checks.
6438 (Bug#9172)
aac0c6e3 6439
7be1c708 64402011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6441
7be1c708
CY
6442 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6443 and LC_VERSION_MIN_MACOSX.
6444 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6445 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6446
97bb72a6
EZ
64472011-08-08 Eli Zaretskii <eliz@gnu.org>
6448
6449 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6450 no-display-properties-and-no-overlays under bidi display.
6451 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6452 properties and overlays.
97bb72a6 6453
d5617611
CY
64542011-08-08 Chong Yidong <cyd@stupidchicken.com>
6455
37e11a63
CY
6456 * editfns.c (Fset_time_zone_rule): Document relationship with the
6457 setenv function.
6458
d5617611
CY
6459 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6460 the font entity extracted from the cache (Bug#8109).
6461
58872834
CY
64622011-08-07 Chong Yidong <cyd@stupidchicken.com>
6463
6464 * composite.c (autocmp_chars): Don't reset point. That is done by
6465 restore_point_unwind (Bug#5984).
6466
75bfc667
JL
64672011-08-07 Juri Linkov <juri@jurta.org>
6468
6469 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6470 to show the arg `TIME' instead of `TIMEVAL'.
6471
d1410150
EZ
64722011-08-06 Eli Zaretskii <eliz@gnu.org>
6473
6474 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6475 display property strides EOL and includes a newline, as in
6476 longlines-mode. (Bug#9254)
75b771e4
EZ
6477 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6478 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6479
6480 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6481 is non-zero, even if the data buffer is NULL. Fixes a crash in
6482 vertical-motion with longlines-mode. (Bug#9254)
6483
35928349
EZ
64842011-08-05 Eli Zaretskii <eliz@gnu.org>
6485
ec7cc85b
EZ
6486 * bidi.c <bidi_cache_total_alloc>: Now static.
6487 (bidi_initialize): Initialize bidi_cache_total_alloc.
6488
8b76d6f8 6489 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6490 cache. (Bug#9221)
6491
6492 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6493 amount allocated this far in `bidi_cache_total_alloc'.
6494 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6495 non-zero, only free the data buffer without restoring the cache
6496 contents. All callers changed.
6497
6498 * dispextern.h (bidi_unshelve_cache): Update prototype.
6499
6500 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6501 (move_it_in_display_line, move_it_to)
6502 (move_it_vertically_backward, move_it_by_lines): Replace the call
6503 to xfree to an equivalent call to bidi_unshelve_cache.
6504 (move_it_in_display_line_to): Fix logic of returning
412b6358 6505 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6506
e2e2423b
EZ
65072011-08-05 Eli Zaretskii <eliz@gnu.org>
6508
6509 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6510 came from a string character with a `cursor' property. (Bug#9229)
6511
ae9e757a
JD
65122011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6513
6514 * Makefile.in (LIB_PTHREAD): New variable.
6515 (LIBES): Add LIB_PTHREAD (Bug#9216).
6516
6517 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6518 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6519
213bd7f2
AS
65202011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6521
6b02f655 6522 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6523
99aaf75f
JD
65242011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6525
6526 * xterm.c (x_find_topmost_parent): New function.
6527 (x_set_frame_alpha): Find topmost parent window with
6528 x_find_topmost_parent and set the property there also (bug#9181).
6529 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6530
c74e9d86
PE
65312011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6532
6533 * callproc.c (Fcall_process): Avoid vfork clobbering
6534 the local vars buffer, coding_systems, current_dir.
6535
640c8776
SM
65362011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6537
6538 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6539
f26d0e4c
PE
65402011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6541
8a10d76c
PE
6542 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6543 so that it is not optimized away.
6544
f26d0e4c
PE
6545 * xdisp.c (compute_display_string_pos): Remove unused local.
6546
55439c61
EZ
65472011-08-02 Eli Zaretskii <eliz@gnu.org>
6548
6549 Fix slow cursor motion and scrolling in large buffers with
6550 selective display, like Org Mode buffers. (Bug#9218)
6551
6552 * dispextern.h (struct bidi_it): New member disp_prop_p.
6553
6554 * xdisp.c: Remove one-slot cache of display string positions.
6555 (compute_display_string_pos): Accept an additional argument
5e617bc2 6556 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6557 for a display string or property. If found, set DISP_PROP_P
6558 non-zero.
6559
6560 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6561 DISP_PROP_P, and pass it to compute_display_string_pos.
6562 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6563 non-zero. All callers of bidi_fetch_char changed.
6564
fb33fa43
SM
65652011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6566
6567 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6568
b099e063
DM
65692010-12-03 Don March <don@ohspite.net>
6570
6571 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6572 last character M-[char] is translated to ESC [char] (bug#7541).
6573
5cc7f7af
KH
65742011-08-02 Kenichi Handa <handa@m17n.org>
6575
d0fffa3f 6576 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6577
6578 * chartab.c (uniprop_table): Make it non-static.
6579
525d5e6e
EZ
65802011-08-01 Eli Zaretskii <eliz@gnu.org>
6581
6582 * xdisp.c (forward_to_next_line_start): Accept additional argument
6583 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6584 on the newline.
6585 (reseat_at_next_visible_line_start): Use the bidi iterator state
6586 returned by forward_to_next_line_start to restore the state of
6587 it->bidi_it after backing up to previous newline. (Bug#9212)
6588
31011111
AS
65892011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6590
6591 * regex.c (re_comp): Protoize.
6592 (re_exec): Fix return type.
6593 (regexec): Fix type of `ret'. (Bug#9203)
6594
476371c4
PE
65952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6596
e5d76069
PE
6597 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6598 This is needed if max-image-size is a floating-point number.
6599
9a79b20c
AS
66002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6601
6602 * print.c (print_object): Print empty symbol as ##.
6603
6604 * lread.c (read1): Read ## as empty symbol.
6605
d8c2fa78
AA
66062011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6607
6608 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6609 setting frame foreground color (Bug#9175).
6610 (x_set_background_color): Likewise.
6611
ffe57a7a
AA
6612 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6613 contents (Bug#9176).
6614 (EmacsTooltip -init): Remove bezels and add shadows to
6615 tooltip windows.
6616
bf3492a5
AA
6617 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6618 or scroll bar (Bug#8470).
6619
d55e9c53
AA
6620 * nsfont.m (nsfont_open): Remove assignment to voffset and
6621 unnecessary vars hshink, expand, hd, full_height, min_height.
6622 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6623
6624 * nsterm.h (nsfont_info): Remove voffset field.
6625
d8c2fa78 66262011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6627
6628 Implement strike-through and overline on NextStep (Bug#8863).
6629
6630 * nsfont.m (nsfont_open): Use underline position provided by font,
6631 instead of hard-coded value of 2.
6632 (nsfont_draw): Call ns_draw_text_decoration instead.
6633
6634 * nsterm.h: Add declaration for ns_draw_text_decoration.
6635
6636 * nsterm.m (ns_draw_text_decoration): New function for drawing
6637 underline, overline, and strike-through.
6638 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6639 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6640 accommodate underlining, etc.
4843aac3 6641
4cc60b9b
EZ
66422011-07-28 Eli Zaretskii <eliz@gnu.org>
6643
bc7ece87
EZ
6644 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6645 default.
4cc60b9b 6646
476371c4
PE
66472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6648
66606eea
PE
6649 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6650 Without this fix, if a signal arrives just after memory fills up,
6651 'malloc' might be invoked reentrantly.
6652
476371c4
PE
6653 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6654 In other words, assume that every image size is allowed, on non-X
6655 hosts. This assumption is probably wrong, but it lets Emacs compile.
6656
f3fcc40d
AS
66572011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6658
6659 * regex.c (re_iswctype): Convert return values to boolean.
6660
350c992f
EZ
66612011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6662
6663 * xdisp.c (compute_display_string_pos): Don't use cached display
6664 string position if the buffer had its restriction changed.
6665 (Bug#9184)
6666
5266b4bb
PE
66672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6668
6669 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6670
2573a837 66712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6672
41f55ccd 6673 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6674
39e378da
PE
6675 * bidi.c: Integer size and overflow fixes.
6676 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6677 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6678 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6679 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6680 (bidi_find_other_level_edge):
6681 Use ptrdiff_t instead of EMACS_INT where either will do.
6682 This works better on 32-bit hosts configured --with-wide-int.
6683 (bidi_cache_ensure_space): Check for size-calculation overflow.
6684 Use % rather than repeated addition, for better worst-case speed.
6685 Don't set bidi_cache_size until after xrealloc returns, because it
6686 might not return.
6687 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6688 (bidi_cache_ensure_space): Also check that the bidi cache size
6689 does not exceed that of the largest Lisp string or buffer. See Eli
6690 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6691
5e927815
PE
6692 * alloc.c (__malloc_size_t): Remove.
6693 All uses replaced by size_t. See Andreas Schwab's note
6694 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6695
ca4aa935
PE
6696 * image.c: Improve checking for integer overflow.
6697 (check_image_size): Assume that f is nonnull, since
6698 it is always nonnull in practice. This is one less thing to
6699 worry about when checking for integer overflow later.
6700 (x_check_image_size): New function, which checks for integer
6701 overflow issues inside X.
6702 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6703 This removes the need for a memory_full check.
6704 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6705 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6706 (xbm_read_bitmap_data): Change locals back to 'int', since
6707 their values must fit in 'int'.
6708 (xpm_load_image, png_load, tiff_load):
6709 Invoke x_create_x_image_and_pixmap earlier,
6710 to avoid much needless work if the image is too large.
6711 (tiff_load): Treat overly large images as if
6712 x_create_x_image_and_pixmap failed, not as malloc failures.
6713 (gs_load): Use x_check_image_size.
6714
5f8f9cc2
PE
6715 * gtkutil.c: Omit integer casts.
6716 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6717 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6718
5adf60bc
PE
6719 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6720
c8907a93
PE
6721 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6722 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6723 would wrongly return t on a 64-bit host.
6724
e3c25c68
PE
6725 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6726 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6727 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6728 and therefore cause GCC to emit a bogus diagnostic in some cases.
6729
3f791afe
PE
6730 * image.c: Integer signedness and overflow and related fixes.
6731 This is not an exhaustive set of fixes, but it's time to
6732 record what I've got.
6733 (lookup_pixel_color, check_image_size): Remove redundant decls.
6734 (check_image_size): Don't assume that arbitrary EMACS_INT values
6735 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6736 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6737 (tiff_load, imagemagick_load_image):
6738 Check for overflow in size calculations.
6739 (x_create_x_image_and_pixmap): Remove unnecessary test for
6740 xmalloc returning NULL; that can't happen.
6741 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6742 (xpm_color_bucket): Use better integer hashing function.
6743 (xpm_cache_color): Don't possibly over-allocate memory.
6744 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6745 (gif_memory_source):
6746 Use ptrdiff_t, not int or size_t, to record sizes.
6747 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6748 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6749 either works, as we prefer signed integers.
6750 (tiff_read_from_memory, tiff_write_from_memory):
6751 Return tsize_t, not size_t, since that's what the TIFF API wants.
6752 (tiff_read_from_memory): Don't fail simply because the read would
6753 go past EOF; instead, return a short read.
6754 (tiff_load): Omit no-longer-needed casts.
6755 (Fimagemagick_types): Don't assume size fits into 'int'.
6756
3cc5a532
PE
6757 Improve hashing quality when configured --with-wide-int.
6758 * fns.c (hash_string): New function, taken from sxhash_string.
6759 Do not discard information about ASCII character case; this
6760 discarding is no longer needed.
6761 (sxhash-string): Use it. Change sig to match it. Caller changed.
6762 * lisp.h: Declare it.
6763 * lread.c (hash_string): Remove, since we now use fns.c's version.
6764 The fns.c version returns a wider integer if --with-wide-int is
6765 specified, so this should help the quality of the hashing a bit.
6766
b312a492
PE
6767 * emacs.c: Integer overflow minor fix.
6768 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6769 Define only if GNU_LINUX.
6770 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6771
dfd153ae
PE
6772 * dispnew.c: Integer signedness and overflow fixes.
6773 Remove unnecessary forward decls, that were a maintenance hassle.
6774 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6775 All uses changed.
6776 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6777 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6778 (prepare_desired_row, line_draw_cost):
6779 Use int, not unsigned, where either works.
6780 (save_current_matrix, restore_current_matrix):
6781 Use ptrdiff_t, not size_t, where either works.
6782 (init_display): Check for overflow more accurately, and without
6783 relying on undefined behavior.
6784
a81d11a3
PE
6785 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6786 Remove, replacing with the new symbols in lisp.h. All uses changed.
6787 * fileio.c (make_temp_name):
6788 * filelock.c (lock_file_1, lock_file):
6789 * xdisp.c (message_dolog):
6790 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6791 Use pMd etc. instead.
6792 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6793 replacing the pWIDE etc. symbols removed from editfns.c.
6794
3300e6fd
PE
6795 * keyboard.h (num_input_events): Now uintmax_t.
6796 This is (very slightly) less likely to mess up due to wraparound.
6797 All uses changed.
6798
fd05c7e9
PE
6799 * buffer.c: Integer signedness fixes.
6800 (alloc_buffer_text, enlarge_buffer_text):
6801 Use ptrdiff_t rather than size_t when either will do, as we prefer
6802 signed integers.
6803
903fe15d
PE
6804 * alloc.c: Integer signedness and overflow fixes.
6805 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6806 (__malloc_size_t): Default to size_t, not to int.
6807 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6808 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6809 Prefer ptrdiff_t to size_t when either would do, as we prefer
6810 signed integers.
6811 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6812 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6813 Now const. Initialize with values that are in range even if char
6814 is signed.
6815 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6816 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6817 These functions do the right thing with sizes > 2**32.
6818 (check_depth): Now ptrdiff_t, not int.
6819 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6820 Adjust to new way of storing sizes. Check for size overflow bugs
6821 in rest of code.
6822 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6823 slightly wrong anyway, as it missed one instance of
6824 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6825 (refill_memory_reserve): Omit needless cast to size_t.
6826 (mark_object_loop_halt): Mark as externally visible.
6827
ac82cc6a
PE
6828 * xselect.c: Integer signedness and overflow fixes.
6829 (Fx_register_dnd_atom, x_handle_dnd_message):
6830 Use ptrdiff_t, not size_t, since we prefer signed.
6831 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6832 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6833 x_dnd_atoms_size and x_dnd_atoms_length.
6834
c2d1e36d
PE
6835 * doprnt.c: Prefer signed to unsigned when either works.
6836 * eval.c (verror):
6837 * doprnt.c (doprnt):
6838 * lisp.h (doprnt):
6839 * xdisp.c (vmessage):
6840 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6841 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6842 prefer signed arithmetic to avoid comparison confusion.
6843 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6844 but is a bit tricky.
6845
0e926e56
PE
6846 Assume freestanding C89 headers, string.h, stdlib.h.
6847 * data.c, doprnt.c, floatfns.c, print.c:
6848 Include float.h unconditionally.
6849 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6850 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6851 * regex.c: Likewise for stddef.h, string.h.
6852 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6853 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6854 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6855 (STDC_HEADERS): Remove obsolete defines.
6856 * sysdep.c: Include limits.h unconditionally.
6857
9cfdb3ec
PE
6858 Assume support for memcmp, memcpy, memmove, memset.
6859 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6860 * regex.c (memcmp, memcpy):
6861 Remove; we assume C89 now.
6862
6863 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6864 (__malloc_safe_bcopy): Remove; no longer needed.
6865
cf950e6b 6866 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6867 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6868 well either way, and we prefer signed to unsigned.
6869
dbf38e02
LMI
68702011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6871
6872 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6873 closes the connection while we're reading (bug#9182).
6874
d6f0886c 68752011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6876
d6f0886c
JD
6877 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6878 are specified (Bug#9168).
24e0f6b1 6879
2eb1f9e6
PE
68802011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6881
6882 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6883 Found by GCC static checking and --with-wide-int on a 32-bit host.
6884
22381272 68852011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6886
6887 * xdisp.c (compute_display_string_pos): Fix logic of caching
6888 previous display string position. Initialize cached_prev_pos to
6889 -1. Fixes slow-down at the beginning of a buffer.
6890
f25e39b4
EZ
68912011-07-24 Eli Zaretskii <eliz@gnu.org>
6892
6893 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6894 for attrs[LFACE_FONTSET_INDEX].
6895
04c4b52e
PE
68962011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6897
6898 * xml.c (parse_region): Remove unused local
6899 that was recently introduced.
6900
c1734fbd
EZ
69012011-07-23 Eli Zaretskii <eliz@gnu.org>
6902
be18c5a5
EZ
6903 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6904 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6905
c1734fbd
EZ
6906 * xdisp.c (move_it_in_display_line_to): Record the best matching
6907 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6908 exit if none of the characters scanned was an exact match.
6909 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6910 when exact match is impossible due to invisible text, and the
6911 lines are truncated.
6912
a258d627
JD
69132011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6914
6915 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6916 for OSX >= 10.7.
6917
b6d5a689
EZ
69182011-07-22 Eli Zaretskii <eliz@gnu.org>
6919
0f74f785
EZ
6920 Fix a significant slow-down of cursor motion with C-n, C-p,
6921 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6922 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6923 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6924 (next_element_from_buffer): Call compute_stop_pos_backwards to
6925 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6926 base_level_stop.
6927 (reseat): Don't look for prev_stop, as that could mean a very long
6928 run.
6929 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6930 <cached_disp_overlay_modiff>: Cache for last found display string
6931 position.
551918c1 6932 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6933 about the same buffer in the same area of character positions, and
6934 the buffer wasn't changed since the time the display string
6935 position was cached.
551918c1 6936
b2d0c91a
EZ
69372011-07-22 Eli Zaretskii <eliz@gnu.org>
6938
6939 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6940 is an integer, which is important for empty lines. (Bug#9149)
6941
043604ee
CY
69422011-07-22 Chong Yidong <cyd@stupidchicken.com>
6943
6944 * frame.c (Fmodify_frame_parameters): In tty case, update the
6945 default face if necessary (Bug#4238).
6946
da4adb04
CY
69472011-07-21 Chong Yidong <cyd@stupidchicken.com>
6948
6949 * editfns.c (Fstring_to_char): No need to explain what a character
6950 is in the docstring (Bug#6576).
6951
9abd0532
LMI
69522011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6953
6954 * xml.c (parse_region): Make sure we always return a tree.
6955
36881d16
HK
69562011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6957
6958 * xml.c (parse_region): If a document contains only comments,
6959 return that, too.
6960
1e98674d
LMI
69612011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6962
6963 * xml.c (make_dom): Return comments, too.
6964
590bd467
PE
69652011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6966
6967 Port to OpenBSD.
6968 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6969 and the surrounding thread.
6970 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6971 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6972 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6973 timer goes off.
6974 * s/openbsd.h (BROKEN_SIGIO): Define.
6975 * unexelf.c (unexec) [__OpenBSD__]:
6976 Don't update the .mdebug section of the Alpha COFF symbol table.
6977
f41628b2
LMI
69782011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6979
6980 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6981 (bug#8460).
6982
b59b67c5
PE
69832011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6984
15e3a074
PE
6985 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6986 This fixes some race conditions on the permissions of any newly
6987 created file.
6988
41bed37d
PE
6989 * alloc.c (valid_pointer_p): Use pipe, not open.
6990 This fixes some permissions issues when debugging.
6991
b59b67c5
PE
6992 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6993 If fchown fails to set both uid and gid, try to set just gid,
6994 as that is sometimes allowed. Adjust the file's mode to eliminate
6995 setuid or setgid bits that are inappropriate if fchown fails.
6996
925a6be7
SM
69972011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6998
6999 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7000 to compare Lisp_Objects.
7001 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7002 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7003 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7004
52968808
AS
70052011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7006
0a6a104b
AS
7007 * lread.c (read_integer): Unread even EOF character.
7008 (read1): Likewise. Properly record start position of symbol.
7009
52968808
AS
7010 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7011 symbol character follows.
7012
9e381cdd
PE
70132011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7014
7015 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7016 This works around a problem with the previous change to Fcopy_file.
7017 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7018 and without this change, GCC might complain about discarding
7019 fchown's return value.
7020
b5641435
JB
70212011-07-16 Juanma Barranquero <lekktu@gmail.com>
7022
7023 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7024
a8031457
PE
70252011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7026
7027 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7028
dd889327
LMI
70292011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7030
750c33f7
LMI
7031 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7032 it's used from the C level.
7033
dd889327
LMI
7034 * process.c: Use the same condition for POLL_FOR_INPUT in both
7035 keyboard.c and process.c (bug#1858).
7036
87e86684
LM
70372011-07-09 Lawrence Mitchell <wence@gmx.li>
7038
7039 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7040 (Fgnutls_boot): Use it.
7041
64348f40
AS
70422011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7043
7044 * doc.c (Fsubstitute_command_keys): Revert last change.
7045
1d698799
LMI
70462011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7047
f863868c
LMI
7048 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7049 quotes the next character, and doesn't affect other longer
7050 sequences (bug#8935).
7051
1d698799
LMI
7052 * lread.c (syms_of_lread): Clarify that is isn't only
7053 `eval-buffer' and `eval-defun' that's affected by
7054 `lexical-binding' (bug#8460).
7055
aa4b6df6
EZ
70562011-07-15 Eli Zaretskii <eliz@gnu.org>
7057
7058 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7059 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7060
5d856da6
PE
70612011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7062
ad6042bb
PE
7063 Fix minor problems found by static checking.
7064 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7065 (elsz): Now a signed constant, not a size_t var. We prefer signed
7066 types to unsigned, to avoid integer comparison confusion. Without
7067 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7068 "cannot optimize loop, the loop counter may overflow", a symptom
7069 of the confusion.
f00bbb22 7070 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7071 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7072
6468f31c
LMI
70732011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7074
49080b10
LMI
7075 * search.c (Fre_search_backward): Mention `case-fold-search' in
7076 all the re_search_* functions (bug#8138).
7077
6468f31c
LMI
7078 * keyboard.c (Fopen_dribble_file): Document when the file is
7079 closed (bug#8056).
7080
c965adc5
EZ
70812011-07-14 Eli Zaretskii <eliz@gnu.org>
7082
df9733bf
EZ
7083 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7084 bidi_cache_idx.
7085
0bb23927
EZ
7086 Support bidi reordering of display and overlay strings.
7087 * xdisp.c (compute_display_string_pos)
7088 (compute_display_string_end): Accept additional argument STRING.
7089 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7090 (reseat_to_string): Initialize bidi_it->string.s and
7091 bidi_it->string.schars.
7092 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7093 NULL (avoids a crash in bidi_paragraph_init).
7094 Initialize itb.string.lstring.
0bb23927
EZ
7095 (init_iterator): Call bidi_init_it only of a valid
7096 buffer position was specified. Initialize paragraph_embedding to
7097 L2R.
7098 (reseat_to_string): Initialize the bidi iterator.
7099 (display_string): If we need to ignore text properties of
7100 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7101 original value of -1 will not work with bidi.)
7102 (compute_display_string_pos): First arg is now struct
7103 `text_pos *'; all callers changed. Support display properties on
7104 Lisp strings.
7105 (compute_display_string_end): Support display properties on Lisp
7106 strings.
7107 (init_iterator, reseat_1, reseat_to_string): Initialize the
7108 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7109 when iterating on a string not from display properties).
640c8776
SM
7110 (compute_display_string_pos, compute_display_string_end):
7111 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7112 arrow keys.
7113 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7114 base_level_stop; instead, set base_level_stop to BEGV.
7115 Fixes crashes in vertical-motion.
0bb23927
EZ
7116 (next_element_from_buffer): Improve commentary for when
7117 the iterator is before prev_stop.
7118 (init_iterator): Initialize bidi_p from the default value of
7119 bidi-display-reordering, not from buffer-local value. Use the
7120 buffer-local value only if initializing for buffer iteration.
7121 (handle_invisible_prop): Support invisible properties on strings
7122 that are being bidi-reordered.
7123 (set_iterator_to_next): Support bidi reordering of C strings and
7124 Lisp strings.
7125 (next_element_from_string): Support bidi reordering of Lisp
7126 strings.
7127 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7128 (display_string): Support display of R2L glyph rows.
7129 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7130 (init_iterator): Don't initialize it->bidi_p for strings
7131 here.
7132 (reseat_to_string): Initialize it->bidi_p for strings here.
7133 (next_element_from_string, next_element_from_c_string)
7134 (next_element_from_buffer): Add xassert's for correspondence
7135 between IT's object being iterated and it->bidi_it.string
7136 structure.
7137 (face_before_or_after_it_pos): Support bidi iteration.
7138 (next_element_from_c_string): Handle the case of the first string
7139 character that is not the first one in the visual order.
7140 (get_visually_first_element): New function, refactored from common
7141 parts of next_element_from_buffer, next_element_from_string, and
7142 next_element_from_c_string.
7143 (tool_bar_lines_needed, redisplay_tool_bar)
7144 (display_menu_bar): Force left-to-right direction. Add a FIXME
7145 comment for making that be controlled by a user option.
7146 (push_it, pop_it): Save and restore the state of the
7147 bidi iterator. Save and restore the bidi_p flag.
7148 (pop_it): Iterate out of display property for string iteration as
7149 well.
7150 (iterate_out_of_display_property): Support iteration over strings.
7151 (handle_single_display_spec): Set up it->bidi_it for iteration
7152 over a display string, and call bidi_init_it.
7153 (handle_single_display_spec, next_overlay_string)
7154 (get_overlay_strings_1, push_display_prop): Set up the bidi
7155 iterator for displaying display or overlay strings.
7156 (forward_to_next_line_start): Don't use the shortcut if
7157 bidi-iterating.
7158 (back_to_previous_visible_line_start): If handle_display_prop
7159 pushed the iterator stack, restore the internal state of the bidi
7160 iterator by calling bidi_pop_it same number of times.
7161 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7162 and we are bidi-iterating, don't decrement the iterator position;
7163 instead, set the first_elt flag in the bidi iterator, to produce
7164 the same effect.
7165 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7166 (push_display_prop): xassert that we are iterating a buffer.
7167 (push_it, pop_it): Save and restore paragraph_embedding member.
7168 (handle_single_display_spec, next_overlay_string)
7169 (get_overlay_strings_1, reseat_1, reseat_to_string)
7170 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7171 correctly. Don't assume unibyte strings are not bidi-reordered.
7172 (compute_display_string_pos)
7173 (compute_display_string_end): Fix handling the case of C string.
7174 (push_it, pop_it): Save and restore from_disp_prop_p.
7175 (handle_single_display_spec, push_display_prop): Set the
7176 from_disp_prop_p flag.
7177 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7178 (pop_it): Call iterate_out_of_display_property only if we are
7179 popping after iteration over a string that came from a display
7180 property. Fix a typo in popping stretch info. Add an assertion
7181 for verifying that the iterator position is in sync with the bidi
7182 iterator.
7183 (handle_single_display_spec, get_overlay_strings_1)
7184 (push_display_prop): Fix initialization of paragraph direction for
7185 string when that of the parent object is not yet determined.
7186 (reseat_1): Call bidi_init_it to resync the bidi
7187 iterator with IT's position. (Bug#7616)
7188 (find_row_edges): If ROW->start.pos gives position
7189 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7190 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7191 Reset the from_disp_prop_p flag.
7192 (SAVE_IT, RESTORE_IT): New macros.
7193 (pos_visible_p, face_before_or_after_it_pos)
7194 (back_to_previous_visible_line_start)
7195 (move_it_in_display_line_to, move_it_in_display_line)
7196 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7197 (try_scrolling, redisplay_window, display_line): Use them when
7198 saving a temporary copy of the iterator and restoring it back.
7199 (back_to_previous_visible_line_start, reseat_1)
7200 (init_iterator): Empty the bidi cache "stack".
7201 (move_it_in_display_line_to): If iterator ended up at
7202 EOL, but we never saw any buffer positions smaller than
7203 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7204 motion in bidi-reordered lines.
7205 (move_it_in_display_line_to): Record prev_method and prev_pos
7206 immediately before the call to set_iterator_to_next. Fixes cursor
7207 motion in bidi-reordered lines with stretch glyphs and strings
7208 displayed in margins. (Bug#8133) (Bug#8867)
7209 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7210 TO_CHARPOS.
640c8776
SM
7211 (pos_visible_p): Support positions in bidi-reordered lines.
7212 Save and restore bidi cache.
0bb23927
EZ
7213
7214 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7215 (bidi_paragraph_info): Delete unused struct.
7216 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7217 (bidi_cache_start): New variable.
7218 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7219 to zero.
7220 (bidi_cache_fetch_state, bidi_cache_search)
7221 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7222 (bidi_cache_find, bidi_peek_at_next_level)
7223 (bidi_level_of_next_char, bidi_find_other_level_edge)
7224 (bidi_move_to_visually_next): Compare cache index with
7225 bidi_cache_start rather than with zero.
7226 (bidi_fetch_char): Accept new argument STRING; all callers
7227 changed. Support iteration over a string. Support strings with
7228 display properties. Support unibyte strings. Fix the type of
7229 `len' according to what STRING_CHAR_AND_LENGTH expects.
7230 (bidi_paragraph_init, bidi_resolve_explicit_1)
7231 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7232 (bidi_level_of_next_char, bidi_move_to_visually_next):
7233 Support iteration over a string.
0bb23927
EZ
7234 (bidi_set_sor_type, bidi_resolve_explicit_1)
7235 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7236 can now be zero (for strings); special values 0 and -1 were
7237 changed to -1 and -2, respectively.
7238 (bidi_char_at_pos): New function.
7239 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7240 Call it instead of FETCH_MULTIBYTE_CHAR.
7241 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7242 initialized to valid values.
7243 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7244 values.
7245 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7246 the test for valid cached positions. Fix the logic for looking up
7247 the sentinel state in the cache. GCPRO the Lisp string we are
7248 iterating.
7249 (bidi_push_it, bidi_pop_it): New functions.
7250 (bidi_initialize): Initialize the bidi cache start stack pointer.
7251 (bidi_cache_ensure_space): New function, refactored from part of
7252 bidi_cache_iterator_state. Don't assume the required size is just
7253 one BIDI_CACHE_CHUNK away.
7254 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7255 (bidi_count_bytes, bidi_char_at_pos): New functions.
7256 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7257 always valid if bidi_cache_idx is valid.
7258 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7259 is valid if it's going to be used.
7260 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7261 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7262 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7263 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7264 (bidi_find_other_level_edge, bidi_cache_start_stack):
7265 All variables related to cache indices are now EMACS_INT.
c965adc5 7266
0bb23927
EZ
7267 * dispextern.h (struct bidi_string_data): New structure.
7268 (struct bidi_it): New member `string'. Make flag members be 1-bit
7269 fields, and put them last in the struct.
640c8776
SM
7270 (compute_display_string_pos, compute_display_string_end):
7271 Update prototypes.
0bb23927
EZ
7272 (bidi_push_it, bidi_pop_it): Add prototypes.
7273 (struct iterator_stack_entry): New members bidi_p,
7274 paragraph_embedding, and from_disp_prop_p.
7275 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7276 (bidi_shelve_cache, bidi_unshelve_cache):
7277 Declare prototypes.
0bb23927
EZ
7278
7279 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7280 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7281 and vector-like objects.
7282
7283 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7284 cache around display iteration.
7285
7286 * window.c (Fwindow_end, window_scroll_pixel_based)
7287 (displayed_window_lines, Frecenter): Save and restore the bidi
7288 cache around display iteration.
7289
3bbd2265
LMI
72902011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7291
7292 * editfns.c (Fdelete_region): Clarify the use of the named
7293 parameters (bug#6788).
7294
adc47434
MR
72952011-07-14 Martin Rudalics <rudalics@gmx.at>
7296
7297 * indent.c (Fvertical_motion): Set and restore w->pointm when
7298 saving and restoring the window's buffer (Bug#9006).
7299
837c31f8
LMI
73002011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7301
7302 * editfns.c (Fstring_to_char): Clarify just what is returned
7303 (bug#6576). Text by Eli Zaretskii.
7304
ac389d0c
JB
73052011-07-13 Juanma Barranquero <lekktu@gmail.com>
7306
7307 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7308
0be0ce47
EZ
73092011-07-13 Eli Zaretskii <eliz@gnu.org>
7310
7311 * buffer.c (mmap_find): Fix a typo.
7312
cd18e7e3
JB
73132011-07-13 Johan Bockgård <bojohan@gnu.org>
7314
7315 Fix execution of x selection hooks.
7316 * xselect.c (Qx_lost_selection_functions)
7317 (Qx_sent_selection_functions): New vars.
7318 (syms_of_xselect): DEFSYM them.
7319 (x_handle_selection_request): Pass Qx_sent_selection_functions
7320 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7321 (x_handle_selection_clear,x_clear_frame_selections):
7322 Pass Qx_lost_selection_functions rather than
7323 Vx_lost_selection_functions to Frun_hook_with_args.
7324
47ea7f44
PE
73252011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7326
ac389d0c 7327 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7328 The old code sometimes used this field without initializing it.
7329
47ea7f44
PE
7330 * alloc.c (gc_sweep): Don't read past end of array.
7331 In theory, the old code could also have corrupted Emacs internals,
7332 though it'd be very unlikely.
7333
bc985c87
AS
73342011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7335
7336 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7337 argument. (Bug#4026)
bc985c87 7338
0cf34688
LMI
73392011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7340
b3dadd76
LMI
7341 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7342 key" (bug#4257).
7343
0cf34688
LMI
7344 * window.c (Fset_window_start): Doc fix (bug#4199).
7345 (Fset_window_hscroll): Ditto.
7346
270768cd
PE
73472011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7348
077e3dda 7349 Fix minor new problems caught by GCC 4.6.1.
270768cd 7350 * term.c (init_tty): Remove unused local.
490011a6 7351 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7352 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7353 not used otherwise.
270768cd 7354
b1f58454
CY
73552011-07-12 Chong Yidong <cyd@stupidchicken.com>
7356
7357 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7358
22b9578d
LMI
73592011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7360
6e70ab07
LMI
7361 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7362 are the mini-buffer and the echo area (bug#3320).
7363
22b9578d
LMI
7364 * term.c (init_tty): Remove support for supdup, c10 and perq
7365 terminals, which are no longer supported (bug#1482).
7366
8974cc9f
JB
73672011-07-10 Johan Bockgård <bojohan@gnu.org>
7368
7369 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7370
a560d974
JD
73712011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7372
7373 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7374 for non-popups (Bug#3642).
7375
1dae0f0a
AS
73762011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7377
268c2c36 7378 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7379 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7380 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7381 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7382 * data.c (fmod): Likewise.
7383 * dispnew.c (swap_glyphs_in_rows): Likewise.
7384 * emacs.c (memory_warning_signal): Likewise.
7385 * floatfns.c (float_error): Likewise.
7386 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7387 (otf_open, font_otf_capability, generate_otf_features)
7388 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7389 Likewise.
7390 * image.c (pbm_read_file): Likewise.
7391 * indent.c (string_display_width): Likewise.
7392 * intervals.c (check_for_interval, search_for_interval)
7393 (inc_interval_count, count_intervals, root_interval)
7394 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7395 * lread.c (defalias): Likewise.
268c2c36 7396 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7397 * regex.c (set_image_of_range_1, set_image_of_range)
7398 (regex_grow_registers): Likewise.
7399 * sysdep.c (strerror): Likewise.
7400 * termcap.c (valid_filename_p, tprint, main): Likewise.
7401 * tparam.c (main): Likewise.
7402 * unexhp9k800.c (run_time_remap, save_data_space)
7403 (update_file_ptrs, read_header, write_header, calculate_checksum)
7404 (copy_file, copy_rest, display_header): Likewise.
7405 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7406 Likewise.
7407 * xdisp.c (check_it): Likewise.
7408 * xfaces.c (register_color, unregister_color, unregister_colors):
7409 Likewise.
7410 * xfns.c (print_fontset_result): Likewise.
7411 * xrdb.c (member, fatal, main): Likewise.
7412
99033785
PE
74132011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7414
7415 Fix minor problems found by static checking (Bug#9031).
7416 * chartab.c (char_table_set_range, map_sub_char_table):
7417 Remove unused locals.
7418 (uniprop_table): Now static.
7419 * composite.c (_work_char): Remove unused static var.
7420
9cb2ac56
JB
74212011-07-09 Juanma Barranquero <lekktu@gmail.com>
7422
7423 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7424
f25661f0
JD
74252011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7426
7427 * gtkutil.c (qttip_cb): Remove code without function.
7428
8278c4fe
EZ
74292011-07-09 Eli Zaretskii <eliz@gnu.org>
7430
7431 * w32.c (pthread_sigmask): New stub.
7432
1692ae2d 74332011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7434
8a6ebd58 7435 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7436 sigprocmask is portable only for single-threaded applications, and
7437 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7438 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7439 (LIBES): Use it.
7440 * callproc.c (Fcall_process):
7441 * process.c (create_process):
7442 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7443 Use pthread_sigmask, not sigprocmask.
123403e4 7444
1b854618
JD
74452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7446
7447 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7448 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7449 wrong (Bug#8591).
7450
3fe4b549
JD
74512011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7452
0ce7e563
JD
7453 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7454 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7455 (xg_hide_tooltip): Fix comment.
7456
3fe4b549
JD
7457 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7458 in registerServicesMenuSendTypes.
7459 (validRequestorForSendType): Don't check ns_return_types.
7460
7461 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7462 ns_return_type.
7463
5df75e47
JR
74642011-07-08 Jason Rumney <jasonr@gnu.org>
7465
22610910
JR
7466 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7467 SH_SHOW for hidden windows (Bug#5482).
7468
5df75e47
JR
7469 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7470 frame struct members of non-existent frames (Bug#6284).
7471
699c10bd
JD
74722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7473
4393663b
JD
7474 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7475 variable firstTime not needed on OSX >= 10.6.
7476 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7477 >= 10.5. Use setKnobProportion, setDoubleValue.
7478
7479 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7480 (MAC_OS_X_VERSION_10_5): Define if not defined.
7481 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7482 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7483 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7484
7485 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7486 cString and lossyCString on OSX >= 10.4
7487
58179cce 7488 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7489 sizeToFit on OSX >= 10.2.
7490
7491 * nsimage.m (allocInitFromFile): Don't use deprecated method
7492 bestRepresentationForDevice on OSX >= 10.6.
7493
7494 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7495 to avoid warning.
7496
7497 * emacs.c: Declare unexec_init_emacs_zone.
7498
a63e0781
JD
7499 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7500
699c10bd
JD
7501 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7502
7503 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7504 on svcsMenu (Bug#8842).
7505
7506 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7507 ns_return_types.
7508 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7509
7510 * nsterm.m (QUTF8_STRING): Declare.
7511 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7512 (validRequestorForSendType): Return type is (id).
7513 Change indexOfObjectIdenticalTo to indexOfObject.
7514 Check if we have local selection before returning self (Bug#8842).
7515 (writeSelectionToPasteboard): Put local selection into paste board
7516 if we have a local selection (Bug#8842).
7517 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7518
7519 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7520 (ns_get_local_selection): Declare.
7521
54e10184
LMI
75222011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7523
9888ff71
LMI
7524 * keymap.c (describe_map_tree): Don't insert a double newline at
7525 the end of the buffer (bug#1169) and return whether we inserted
7526 something.
7527
54e10184
LMI
7528 * callint.c (Fcall_interactively): Change "reading args" to
7529 "providing args" to try to clarify what it does (bug#1010).
7530
15fa4783
KH
75312011-07-07 Kenichi Handa <handa@m17n.org>
7532
7533 * composite.c (composition_compute_stop_pos): Ignore a static
7534 composition starting before CHARPOS (Bug#8915).
7535
7536 * xdisp.c (handle_composition_prop): Likewise.
7537
a8815b00
EZ
75382011-07-07 Eli Zaretskii <eliz@gnu.org>
7539
7540 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7541 (Bug#9015)
7542
ef7b981d 75432011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7544
7545 * character.h (unicode_category_t): New enum type.
7546
7547 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7548 (Qchar_code_property_table): New variable.
7549 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7550 (UNIPROP_COMPRESSED_FORM_P): New macros.
7551 (char_table_ascii): Uncompress the compressed values.
7552 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7553 Uncompress the compressed values.
ac389d0c 7554 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7555 (char_table_ref_and_range): Uncompress the compressed values.
7556 (sub_char_table_set): New arg is_uniprop. Callers changed.
7557 Uncompress the compressed values.
7558 (sub_char_table_set_range): Args changed. Callers changed.
7559 (char_table_set_range): Adjuted for the above change.
7560 (map_sub_char_table): Delete args default_val and parent. Add arg
7561 top. Give decoded values to a Lisp function.
640c8776 7562 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7563 values to a Lisp function. Gcpro more variables.
7564 (uniprop_table_uncompress)
7565 (uniprop_decode_value_run_length): New functions.
7566 (uniprop_decoder, uniprop_decoder_count): New variables.
7567 (uniprop_get_decoder, uniprop_encode_value_character)
7568 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7569 New functions.
7570 (uniprop_encoder, uniprop_encoder_count): New variables.
7571 (uniprop_get_encoder, uniprop_table)
7572 (Funicode_property_table_internal, Fget_unicode_property_internal)
7573 (Fput_unicode_property_internal): New functions.
7574 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7575 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7576 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7577 char-code-property-alist.
7578
640c8776 7579 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7580 Vunicode_category_table.
7581
640c8776 7582 * font.c (font_range): Adjust for the change of
c805dec0
KH
7583 Vunicode_category_table.
7584
76b397fb
DN
75852011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7586
7587 * m/iris4d.h: Remove file, move contents ...
7588 * s/irix6-5.h: ... here.
7589
22b4128e
PE
75902011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7591
7592 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7593 * alloc.c (mark_buffer):
7594 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7595 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7596 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7597 This isn't true in general, and it's particularly not true
7598 if Emacs is configured with --with-wide-int.
7599 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7600 New macros, used in the buffer.c change.
7601
869795d6
JD
76022011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7603
7604 * xsettings.c: Use both GConf and GSettings if both are available.
7605 (store_config_changed_event): Add comment.
7606 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7607 (store_tool_bar_style_changed): New functions.
5e617bc2 7608 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7609 (struct xsettings): Move font inside HAVE_XFT.
7610 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7611 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7612 Move inside HAVE_XFT.
640c8776 7613 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7614 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7615 also.
7616 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7617 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7618 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7619 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7620 (parse_settings): Move check for font inside HAVE_XFT.
7621 (read_settings, apply_xft_settings): Add comment.
7622 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7623 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7624 call store_font_name_changed.
7625 (xft_settings_event): Add comment.
7626 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7627 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7628 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7629 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7630 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7631 (xsettings_get_system_font, xsettings_get_system_normal_font):
7632 Add comment.
869795d6 7633
d8ed26bd
PE
76342011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7635
7636 Random fixes. E.g., (random) never returned negative values.
7637 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7638 subseconds part to the entropy, as that's a bit more random.
7639 Prefer signed to unsigned, since the signedness doesn't matter and
7640 in general we prefer signed. When given a limit, use a
7641 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7642 latter isn't right if USE_2_TAGS_FOR_INTS.
7643 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7644 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7645
cabf1cac
SM
76462011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7647
7648 * textprop.c (text_property_stickiness):
7649 Obey Vtext_property_default_nonsticky.
7650 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7651 * w32fns.c (syms_of_w32fns):
7652 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7653
6e9b2be9
PE
76542011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7655
7656 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7657 This is more efficient than Ffile_directory_p and avoids a minor race.
7658
90186c68
LMI
76592011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7660
7c301272
LMI
7661 * buffer.c (Foverlay_put): Say what the return value is
7662 (bug#7835).
7663
c4f2d8d4
LMI
7664 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7665 is a directory before asking whether to use the file name
7666 (bug#7564).
ad637907
LMI
7667 (barf_or_query_if_file_exists): Make the "File is a directory"
7668 error be more correct.
c4f2d8d4 7669
90186c68
LMI
7670 * fns.c (Frequire): Remove the mention of the .gz files, since
7671 that's installation-specific, but keep the mention of
7672 `get-load-suffixes'.
7673
da64016e
PE
76742011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7675
7676 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7677 Report string overflow if the output is too long.
7678
7d47b580
JB
76792011-07-04 Juanma Barranquero <lekktu@gmail.com>
7680
a555cb87
JB
7681 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7682 (syms_of_gnutls): Remove duplicate DEFSYM for
7683 Qgnutls_bootprop_verify_hostname_error, an error for
7684 Qgnutls_bootprop_verify_error (which is no longer used).
7685
7d47b580
JB
7686 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7687 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7688 Also (re)move comments that are misplaced or no longer relevant.
7689
1e49bfab
LMI
76902011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7691
7692 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7693
1485f4c0
CY
76942011-07-03 Chong Yidong <cyd@stupidchicken.com>
7695
7696 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7697 and background color parameters if they have been changed.
7698
a9ab721e
LMI
76992011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7700
7701 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7702
cf7cff57
PE
77032011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7704
2e13213d
PE
7705 * xsettings.c (SYSTEM_FONT): Define only when used.
7706 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7707
cf7cff57
PE
7708 * keymap.c (access_keymap_1): Now static.
7709
7a8e04f7
CY
77102011-07-02 Chong Yidong <cyd@stupidchicken.com>
7711
7712 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7713 leave any prefix arg for the up event (Bug#1586).
7714
61352f62
LMI
77152011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7716
69bb1ef7
LMI
7717 * lread.c (syms_of_lread): Mention single symbols defined by
7718 `defvar' or `defconst' (bug#7154).
7719
61352f62 7720 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7721 (Frequire): Mention get-load-suffixes.
61352f62 7722
28545e04
MR
77232011-07-02 Martin Rudalics <rudalics@gmx.at>
7724
7725 * window.h (window): Remove clone_number slot.
7726 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7727 Remove.
7728 (make_parent_window, make_window, saved_window)
7729 (Fset_window_configuration, save_window_save): Don't deal with
7730 clone numbers.
7731 * buffer.c (Qclone_number): Remove declaration.
7732 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7733
3349e122
SM
77342011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7735
7736 Add multiple inheritance to keymaps.
7737 * keymap.c (Fmake_composed_keymap): New function.
7738 (Fset_keymap_parent): Simplify.
7739 (fix_submap_inheritance): Remove.
7740 (access_keymap_1): New function extracted from access_keymap to handle
7741 embedded parents and handle lists of maps.
7742 (access_keymap): Use it.
7743 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7744 (Fcopy_keymap): Handle embedded parents.
7745 (Fcommand_remapping, define_as_prefix): Simplify.
7746 (Fkey_binding): Simplify.
7747 (syms_of_keymap): Move minibuffer-local-completion-map,
7748 minibuffer-local-filename-completion-map,
7749 minibuffer-local-must-match-map, and
7750 minibuffer-local-filename-must-match-map to Elisp.
7751 (syms_of_keymap): Defsubr make-composed-keymap.
7752 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7753 (parse_menu_item): Trivial simplification.
7754
3279eb87
GM
77552011-07-01 Glenn Morris <rgm@gnu.org>
7756
7757 * Makefile.in (SETTINGS_LIBS): Fix typo.
7758
4550efdf
KI
77592011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7760
7761 * coding.c (Fencode_coding_string): Record the last coding system
7762 used, as the function doc string says (bug#8738).
7763
0949d2b6
JD
77642011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7765
7766 * xsettings.c (store_monospaced_changed): Take new font as arg and
7767 check for change against current_mono_font.
7768 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7769 (emacs_settings_constructor, emacs_settings_get_property)
7770 (emacs_settings_set_property, emacs_settings_class_init)
7771 (emacs_settings_init, gsettings_obj): Remove.
7772 (something_changedCB): New function for HAVE_GSETTINGS.
7773 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7774 with value as argument.
7775 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7776 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7777 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7778 "changed".
7779
7780 * xgselect.c: Add defined (HAVE_GSETTINGS).
7781 (xgselect_initialize): Ditto.
7782
7783 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7784 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7785 xg_select.
7786
bbc6b304
PE
77872011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7788
7789 * eval.c (struct backtrace): Simplify and port the data structure.
7790 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7791 signed bit field, as this assumption is not portable and it makes
7792 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7793 "char debug_on_exit : 1" as this is not portable either; instead,
7794 use the portable "unsigned int debug_on_exit : 1". Remove unused
7795 member evalargs. Remove obsolete comments about cc bombing out.
7796
9851bfc5
JD
77972011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7798
51bb811f 7799 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7800 Let HAVE_GSETTINGS override HAVE_GCONF.
7801 (store_monospaced_changed): New function.
7802 (EMACS_SETTINGS): A new type derived from GObject to handle
7803 GSettings notifications.
7804 (emacs_settings_constructor, emacs_settings_get_property)
7805 (emacs_settings_set_property, emacs_settings_class_init):
7806 New functions.
7807 (gsettings_client, gsettings_obj): New variables.
7808 (GSETTINGS_SCHEMA): New define.
7809 (something_changedCB): Call store_monospaced_changed.
7810 (init_gsettings): New function.
7811 (xsettings_initialize): Call init_gsettings.
7812 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7813 to NULL.
7814
640c8776 7815 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7816 GCONF_CFLAGS/LIBS.
7817
5386012d
MR
78182011-06-29 Martin Rudalics <rudalics@gmx.at>
7819
7820 * window.c (resize_root_window, grow_mini_window)
7821 (shrink_mini_window): Rename Qresize_root_window to
7822 Qwindow_resize_root_window and Qresize_root_window_vertically to
7823 Qwindow_resize_root_window_vertically.
7824
f13e0b08
PE
78252011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7826
7827 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7828
94515237
JB
78292011-06-27 Juanma Barranquero <lekktu@gmail.com>
7830
7831 * makefile.w32-in: Redesign dependencies so they reflect more
7832 clearly which files are directly included by each source file,
7833 and not through other includes.
7834
e43b6e43
MR
78352011-06-27 Martin Rudalics <rudalics@gmx.at>
7836
7837 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7838 (sort_overlays, overlay_strings): When an overlay's clone number
7839 matches the window's clone number process the overlay even if
7840 the overlay's window property doesn't match the current window.
7841
d68443dc
MR
7842 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7843 (Fwindow_hchild): Rename to Fwindow_left_child.
7844 (Fwindow_next): Rename to Fwindow_next_sibling.
7845 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7846 (resize_window_check): Rename to window_resize_check.
7847 (resize_window_apply): Rename to window_resize_apply.
7848 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7849 (Fdelete_other_windows_internal, resize_frame_windows)
7850 (Fsplit_window_internal, Fdelete_window_internal)
7851 (grow_mini_window, shrink_mini_window)
7852 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7853
c7e73be5
JD
78542011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7855
7856 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7857 (emacs_fixed_set_min_size): Remove.
7858 (emacs_fixed_new): Take frame as argument.
7859
7860 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7861 (_EmacsFixedPrivate): Remove minwidth/height.
7862 Add struct frame *f.
7863 (emacs_fixed_init): Initialize priv->f.
7864 (get_parent_class, emacs_fixed_set_min_size): Remove.
7865 (emacs_fixed_new): Set priv->f to argument.
7866 (emacs_fixed_get_preferred_width)
7867 (emacs_fixed_get_preferred_height): Use min_width/height from
7868 frames size_hint to set minimum and natural (Bug#8919).
7869 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7870 and use min_width/height from frames size_hint to set
7871 min_width/height (Bug#8919).
7872
7873 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7874 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7875 Fix indentation.
c7e73be5 7876
cf99dcf8
EZ
78772011-06-26 Eli Zaretskii <eliz@gnu.org>
7878
7879 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7880 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7881 called at ZV.
7882
029529ac
CY
78832011-06-26 Chong Yidong <cyd@stupidchicken.com>
7884
7885 * process.c (wait_reading_process_output): Bypass select if
7886 waiting for a cell while ignoring keyboard input, and input is
7887 pending. Suggested by Jan Djärv (Bug#8869).
7888
7a7ef429
PE
78892011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7890
7891 Use gnulib's dup2 module instead of rolling our own.
7892 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7893
11fdef7d 78942011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7895
7896 * dispnew.c (scrolling_window): Before scrolling, turn off a
7897 mouse-highlight in the window being scrolled.
7898
cd3520a4
JB
78992011-06-24 Juanma Barranquero <lekktu@gmail.com>
7900
7901 Move DEFSYM to lisp.h and use everywhere.
7902
7903 * character.h (DEFSYM): Move declaration...
7904 * lisp.h (DEFSYM): ...here.
7905
7906 * gnutls.c:
7907 * minibuf.c:
7908 * w32menu.c:
7909 * w32proc.c:
7910 * w32select.c: Don't include character.h.
7911
7912 * alloc.c (syms_of_alloc):
7913 * buffer.c (syms_of_buffer):
7914 * bytecode.c (syms_of_bytecode):
7915 * callint.c (syms_of_callint):
7916 * casefiddle.c (syms_of_casefiddle):
7917 * casetab.c (init_casetab_once):
7918 * category.c (init_category_once, syms_of_category):
7919 * ccl.c (syms_of_ccl):
7920 * cmds.c (syms_of_cmds):
7921 * composite.c (syms_of_composite):
7922 * dbusbind.c (syms_of_dbusbind):
7923 * dired.c (syms_of_dired):
7924 * dispnew.c (syms_of_display):
7925 * doc.c (syms_of_doc):
7926 * editfns.c (syms_of_editfns):
7927 * emacs.c (syms_of_emacs):
7928 * eval.c (syms_of_eval):
7929 * fileio.c (syms_of_fileio):
7930 * fns.c (syms_of_fns):
7931 * frame.c (syms_of_frame):
7932 * fringe.c (syms_of_fringe):
7933 * insdel.c (syms_of_insdel):
7934 * keymap.c (syms_of_keymap):
7935 * lread.c (init_obarray, syms_of_lread):
7936 * macros.c (syms_of_macros):
7937 * msdos.c (syms_of_msdos):
7938 * print.c (syms_of_print):
7939 * process.c (syms_of_process):
7940 * search.c (syms_of_search):
7941 * sound.c (syms_of_sound):
7942 * syntax.c (init_syntax_once, syms_of_syntax):
7943 * terminal.c (syms_of_terminal):
7944 * textprop.c (syms_of_textprop):
7945 * undo.c (syms_of_undo):
7946 * w32.c (globals_of_w32):
7947 * window.c (syms_of_window):
7948 * xdisp.c (syms_of_xdisp):
7949 * xfaces.c (syms_of_xfaces):
7950 * xfns.c (syms_of_xfns):
7951 * xmenu.c (syms_of_xmenu):
7952 * xsettings.c (syms_of_xsettings):
7953 * xterm.c (syms_of_xterm): Use DEFSYM.
7954
4228cf16
TZ
79552011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7956
cd3520a4 7957 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7958
7fcccf1e
PE
79592011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7960
7efb4e0e
PE
7961 Integer and buffer overflow fixes (Bug#8873).
7962
ff5844ad
PE
7963 * print.c (printchar, strout): Check for string overflow.
7964 (PRINTPREPARE, printchar, strout):
7965 Don't set size unless allocation succeeds.
7966
90532f02
PE
7967 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7968 for sizes. Check for string overflow more accurately.
7969 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7970
6d84508d
PE
7971 * macros.c: Integer and buffer overflow fixes.
7972 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7973 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7974 Use ptrdiff_t, not int, for sizes.
7975 Don't increment bufsize until after realloc succeeds.
7976 Check for size-calculation overflow.
7977 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7978
437b2cb4
PE
7979 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7980
8b9ac8b4
PE
7981 * lread.c: Integer overflow fixes.
7982 (read_integer): Radix is now EMACS_INT, not int,
7983 to improve quality of diagnostics for out-of-range radices.
7984 Calculate buffer size correctly for out-of-range radices.
7985 (read1): Check for integer overflow in radices, and in
7986 read-circle numbers.
82cb60d3
PE
7987 (read_escape): Avoid int overflow.
7988 (Fload, openp, read_buffer_size, read1)
7989 (substitute_object_recurse, read_vector, read_list, map_obarray):
7990 Use ptrdiff_t, not int, for sizes.
7991 (read1): Use EMACS_INT, not int, for sizes.
20270765 7992 Check for size overflow.
8b9ac8b4 7993
7fcccf1e
PE
7994 * image.c (cache_image): Check for size arithmetic overflow.
7995
bfbbd7e7
PE
7996 * lread.c: Integer overflow issues.
7997 (saved_doc_string_size, saved_doc_string_length)
7998 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7999 Now ptrdiff_t, not int.
8000 (read1): Don't assume doc string length fits in int. Check for
8001 out-of-range doc string lengths.
8002 (read_list): Don't assume file position fits in int.
39019e54 8003 (read_escape): Check for hex character overflow.
bfbbd7e7 8004
4e323265
LL
80052011-06-22 Leo Liu <sdl.web@gmail.com>
8006
8007 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8008 Move to minibuffer.el.
8009
85fece3e
PE
80102011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8011
20b84ce9 8012 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8013 The following patches are for when GLYPH_DEBUG && !XASSERT.
8014 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8015 * dispnew.c (flush_stdout):
8016 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8017 Mark as externally visible.
8018 * dispnew.c (check_window_matrix_pointers): Now static.
8019 * dispnew.c (window_to_frame_vpos):
8020 * xfns.c (unwind_create_frame):
8021 * xterm.c (x_check_font): Remove unused local.
8022 * scroll.c (CHECK_BOUNDS):
8023 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8024 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8025 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8026 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8027 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8028 Now static.
8029 (debug_method_add): Use va_list and vsprintf rather than relying
8030 on undefined behavior with wrong number of arguments.
8031 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8032 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8033 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8034 since we're not interested in debugging glyphs with old libraries.
8035 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8036 GCC 4.6.0's static checking.
8037
0766b489
PE
80382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8039
31fd4b32
PE
8040 Integer overflow and signedness fixes (Bug#8873).
8041 A few related buffer overrun fixes, too.
8042
b79e8648
PE
8043 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8044
0766b489
PE
8045 * dispextern.h (struct face.stipple):
8046 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8047 (x_bitmap_mask, x_allocate_bitmap_record)
8048 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8049 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8050 (x_create_bitmap_from_xpm_data):
8051 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8052 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8053 (.bitmaps_last):
8054 * xfaces.c (load_pixmap):
8055 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8056 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8057 (.bitmaps_last, struct x_output.icon_bitmap):
8058 Use ptrdiff_t, not int, for bitmap indexes.
8059 (x_allocate_bitmap_record): Check for size overflow.
8060 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8061
b081724f
PE
8062 Use ptrdiff_t, not int, for overlay counts.
8063 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8064 * editfns.c (overlays_around, get_pos_property):
8065 * textprop.c (get_char_property_and_overlay):
8066 * xdisp.c (next_overlay_change, note_mouse_highlight):
8067 * xfaces.c (face_at_buffer_position):
21514da7
PE
8068 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8069 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8070 (Fnext_overlay_change, Fprevious_overlay_change)
8071 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8072 Use ptrdiff_t, not int, for sizes.
21514da7 8073 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8074
3de73e5e
PE
8075 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8076
2606c57b
PE
8077 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8078 (x_session_initialize): Do not assume string length fits in int.
8079
aaafe47a
PE
8080 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8081 This is unlikely, but can occur if DPI is outlandish.
8082
2674ddc8 8083 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8084 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8085
28154962
PE
8086 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8087 * xrdb.c (magic_file_p, search_magic_path):
8088 Omit last arg SUFFIX; it was always 0. All callers changed.
8089 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8090
7de51af5
PE
8091 * xfont.c (xfont_match): Avoid need for strlen.
8092
25ed6cc3
PE
8093 * xfns.c: Don't assume strlen fits in int.
8094 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8095
4eab31dd
PE
8096 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8097 not unsigned long, as we prefer signed integers. All callers changed.
8098 Detect integer overflow in repeat count.
8099 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8100 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8101
171e2a58
PE
8102 * termcap.c: Don't assume sizes fit in int and never overflow.
8103 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8104 (gobble_line): Check for size-calculation overflow.
8105
ad39faca 8106 * minibuf.c (Fread_buffer):
6e5bb2dc 8107 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8108 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8109 Don't assume string length fits in int.
8110
52c61c22 8111 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8112 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8113
b5b8c9e5
PE
8114 * font.c: Don't assume string length fits in int.
8115 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8116 Use ptrdiff_t, not int.
ccd6111c
PE
8117 (font_intern_prop): Don't assume string length fits in int.
8118 Don't assume integer property fits in fixnum.
8119 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8120
882f0d81 8121 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8122 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8123 Reformulate so as not to need the command string.
8124 Invoke gzip -cd rather than gunzip, as it's more portable.
8125 (lock_info_type, lock_file_1, lock_file):
8126 Don't assume pid_t and time_t fit in unsigned long.
8127 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8128 (current_lock_owner): Prefer signed type for sizes.
8129 Use memcpy, not strncpy, where memcpy is what is really wanted.
8130 Don't assume (via atoi) that time_t and pid_t fit in int.
8131 Check for time_t and/or pid_t out of range, e.g., via a network share.
8132 Don't alloca where an auto var works fine.
8133
93f4cf88
PE
8134 * fileio.c: Fix some integer overflow issues.
8135 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8136 Don't assume string length fits in int.
8137 (directory_file_name): Don't assume string length fits in long.
8138 (make_temp_name): Don't assume pid fits in int, or that its print
8139 length is less than 20.
8140
f3e92b69
PE
8141 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8142
1bfdaf10
PE
8143 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8144
35016e9a
PE
8145 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8146
3d1e65a1
PE
8147 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8148 We prefer signed integers, even for size calculations.
8149
0b963a93
PE
8150 * emacs.c: Don't assume string length fits in 'int'.
8151 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8152 (main): Don't invoke strlen when not needed.
8153
573f4b54
PE
8154 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8155 (XD_DEBUG_MESSAGE): Don't waste a byte.
8156
989f33ba
PE
8157 * callproc.c (getenv_internal_1, getenv_internal)
8158 (Fgetenv_internal):
965d34eb
PE
8159 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8160
e4d29b33
PE
8161 * lread.c (invalid_syntax): Omit length argument.
8162 All uses changed. This doesn't fix a bug, but it simplifies the
8163 code away from its former Hollerith-constant appearance, and it's
8164 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8165 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8166
eb49b136
PE
8167 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8168 This didn't break anything, but it didn't help either.
8169 It's confusing to put a bogus integer in a place where the actual
8170 value does not matter.
9f62aeb1 8171 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8172 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8173
15375a22
PE
8174 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8175 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8176 implementation.
b61cc01c
PE
8177 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8178 We prefer signed types, and the value cannot exceed the EMACS_INT
8179 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8180 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8181 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8182 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8183
53b2623d
PE
8184 * indent.c (sane_tab_width): New function.
8185 (current_column, scan_for_column, Findent_to, position_indentation)
8186 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8187 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8188
51cab52b 8189 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8190
f2ed8a70
PE
8191 * lisp.h (lint_assume): New macro.
8192 * composite.c (composition_gstring_put_cache):
8193 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8194
abe80cc6
PE
8195 * editfns.c, insdel.c:
8196 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8197
b02c740e
PE
8198 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8199
ebc96716
PE
8200 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8201
b4e50fa0 8202 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8203 Use much-faster test for byte-length change.
311d5d7c 8204 Don't assume string byte-length fits in 'int'.
a4cf38e4 8205 Check that character arg fits in 'int'.
85461888 8206 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8207
c0c1ee9f
PE
8208 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8209
a498d7f4
PE
8210 * fns.c (concat): Catch string overflow earlier.
8211 Do not rely on integer wraparound.
8212
51cab52b
PE
8213 * dispextern.h (struct it.overlay_strings_charpos)
8214 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8215 * xdisp.c (forward_to_next_line_start)
8216 (back_to_previous_visible_line_start)
8217 (reseat_at_next_visible_line_start, next_element_from_buffer):
8218 Don't arbitrarily truncate the value of 'selective' to int.
8219
76031fad
PE
8220 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8221
5eb55db9
PE
8222 * composite.c: Don't truncate sizes to 'int'.
8223 (composition_gstring_p, composition_reseat_it)
8224 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8225 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8226 not EMACS_UINT, for indexes.
5eb55db9 8227
0703a717
PE
8228 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8229
d6202519
PE
8230 * buffer.c: Include <verify.h>.
8231 (struct sortvec.priority, struct sortstr.priority):
8961a454 8232 Now EMACS_INT, not int.
c20998a7 8233 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8234 (struct sortstr.size, record_overlay_string)
8235 (struct sortstrlist.size, struct sortlist.used):
8236 Don't truncate size to int.
8237 (record_overlay_string): Check for size-calculation overflow.
d6202519 8238 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8239
d5a19415
JM
82402011-06-22 Jim Meyering <meyering@redhat.com>
8241
029529ac 8242 Don't leak an XBM-image-sized buffer
d5a19415
JM
8243 * image.c (xbm_load): Free the image buffer after using it.
8244
a9041e6c
PE
82452011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8246
8247 Port to Sun C.
8248 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8249 that Sun C diagnosed.
8250 * fns.c (secure_hash): Fix pointer signedness issue.
8251 * intervals.c (static_offset_intervals): New function.
8252 (offset_intervals): Use it.
8253
7f3f739f
LL
82542011-06-21 Leo Liu <sdl.web@gmail.com>
8255
8256 * deps.mk (fns.o):
8257 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8258 sha512.h.
8259
8260 * fns.c (secure_hash): Rename from crypto_hash_function and change
8261 the first arg to accept symbols.
5b66d427 8262 (Fsecure_hash): New primitive.
7f3f739f
LL
8263 (syms_of_fns): New symbols.
8264
76147d94
DD
82652011-06-20 Deniz Dogan <deniz@dogan.se>
8266
8267 * process.c (Fset_process_buffer): Clarify return value in
8268 docstring.
8269
7d7d0045
CY
82702011-06-18 Chong Yidong <cyd@stupidchicken.com>
8271
8272 * dispnew.c (add_window_display_history): Use BVAR.
8273
8274 * xdisp.c (debug_method_add): Use BVAR.
8275 (check_window_end, dump_glyph_matrix, dump_glyph)
8276 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8277
8278 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8279 Likewise.
8280
8281 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8282 check till after the cache is created in init_frame_faces.
8283
ff2bc410
SM
82842011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8285
8286 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8287
28177add
PE
82882011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8289
dd3482fe
PE
8290 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8291 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8292 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8293
393d71f3 8294 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8295 * fileio.c (Finsert_file_contents):
8296 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8297 Remove the old (too-loose) buffer overflow checks.
8298 They weren't needed, since make_gap checks for buffer overflow.
8299 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8300 The old code merely checked for Emacs fixnum overflow, and relied
8301 on undefined (wraparound) behavior. The new code avoids undefined
8302 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8303
2e6813b0 8304 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8305 Tune. Don't use wider integers than needed. Don't use alloca.
8306 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8307
599a9e4f
PE
8308 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8309
99561444
PE
8310 * insdel.c, lisp.h (buffer_overflow): New function.
8311 (insert_from_buffer_1, replace_range, replace_range_2):
8312 * insdel.c (make_gap_larger):
8313 * editfns.c (Finsert_char):
8314 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8315
28177add
PE
8316 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8317
e69dafad
PE
83182011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8319
4baa020d 8320 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8321
b1c46f02
PE
8322 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8323 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8324
e69dafad
PE
8325 * fileio.c: Don't assume EMACS_INT fits in off_t.
8326 (emacs_lseek): New static function.
8327 (Finsert_file_contents, Fwrite_region): Use it.
8328 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8329
566684ea
PE
8330 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8331
e6966cd6
PE
8332 * fns.c: Don't overflow int when computing a list length.
8333 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8334 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8335 truncation on 64-bit hosts. Check for QUIT every
8336 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8337 faster and is responsive enough.
8338 (Flength): Report an error instead of overflowing an integer.
8339 (Fsafe_length): Return a float if the value is not representable
8340 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8341 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8342 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8343
dd0b0efb
PE
8344 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8345 (header_size, word_size): New constants.
8346 (allocate_vectorlike): Don't check size overflow here.
8347 (allocate_vector): Check it here instead, since this is the only
8348 caller of allocate_vectorlike that could cause overflow.
8349 Check that the new vector's length is representable as a fixnum.
8350
86fe5cfe
PE
8351 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8352 The previous code was bogus. For example, next_almost_prime (32)
8353 returned 39, which is undesirable as it is a multiple of 3; and
8354 next_almost_prime (24) returned 25, which is a multiple of 5 so
8355 why was the code bothering to check for multiples of 7?
8356
80e88859
PE
8357 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8358
4a2f0ad6
PE
8359 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8360
f66c7cf8
PE
8361 Variadic C functions now count arguments with ptrdiff_t.
8362 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8363 Back then I didn't know that the Emacs coding style prefers signed int.
8364 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8365 were being counted with int, which may truncate counts on 64-bit
8366 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8367 * lisp.h (struct Lisp_Subr.function.aMANY)
8368 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8369 Arg counts are now ptrdiff_t, not size_t.
8370 All variadic functions and their callers changed accordingly.
8371 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8372 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8373 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8374 * callint.c (Fcall_interactively): Check arg count for overflow,
8375 to avoid potential buffer overrun. Use signed char, not 'int',
8376 for 'varies' array, so that we needn't bother to check its size
8377 calculation for overflow.
8378 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8379 * eval.c (apply_lambda):
8380 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8381 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8382 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8383
a1759b76
PE
8384 * callint.c (Fcall_interactively): Don't use index var as event count.
8385
d96be9fc
PE
8386 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8387 * mem-limits.h (SIZE): Remove; no longer used.
8388
a690a978 8389 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8390
578c21e6
PE
8391 Remove unnecessary casts.
8392 * xterm.c (x_term_init):
8393 * xfns.c (x_set_border_pixel):
8394 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8395 These aren't needed now that we assume ANSI C.
8396
96f53c6c
PE
8397 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8398 It's more likely to cause problems (due to unsigned overflow)
8399 than to cure them.
8400
83c77d31
PE
8401 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8402
ee2079f1
PE
8403 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8404
6da65536
PE
8405 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8406
7147c4a4
PE
8407 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8408
193e32d9
PE
8409 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8410
e5533da6
PE
8411 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8412
9910e595
PE
8413 GLYPH_CODE_FACE returns EMACS_INT, not int.
8414 * dispextern.h (merge_faces):
8415 * xfaces.c (merge_faces):
01103c44
PE
8416 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8417 Don't assume EMACS_INT fits in int.
9910e595 8418
2638320e
PE
8419 * character.h (CHAR_VALID_P): Remove unused parameter.
8420 * fontset.c, lisp.h, xdisp.c: All uses changed.
8421
045eb8d9
PE
8422 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8423
c1f134b5
PE
8424 * fns.c (concat): Minor tuning based on overflow analysis.
8425 This doesn't fix any bugs. Use int to hold character, instead
8426 of constantly refetching from Emacs object. Use XFASTINT, not
8427 XINT, for value known to be a character. Don't bother comparing
8428 a single byte to 0400, as it's always less.
8429
395fcb93 8430 * floatfns.c (Fexpt):
327eeec8
PE
8431 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8432
abbd3d23
PE
8433 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8434 for characters.
8435
684a03ef
PE
8436 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8437
0fed43f3
PE
8438 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8439 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8440 incorrectly succeed when S was a string, because 4294967386 was
8441 truncated before it was used.
8442
8fd02eb7
PE
8443 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8444 Otherwise, an out-of-range integer could cause undefined behavior
8445 on a 64-bit host.
8446
f8c86b69
PE
8447 * composite.c: Use int, not EMACS_INT, for characters.
8448 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8449 EMACS_INT, for values that are known to be in character range.
8450 This doesn't fix any bugs but is the usual style inside Emacs and
8451 may generate better code on 32-bit machines.
8452
34206dd2
PE
8453 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8454 This is for reasons similar to the recent CHAR_STRING fix.
8455 * charset.c (Fencode_char): Check that character arg is actually
8456 a character. Pass an int to ENCODE_CHAR.
8457 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8458 wider than 'int', as a compile-time check to prevent future regressions
8459 in this area.
8460
c5958d4c 8461 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8462
8463 Make sure a 64-bit char is never passed to CHAR_STRING.
8464 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8465 by silently ignoring the top 32 bits, allowing some values
8466 that were far too large to be valid characters.
8467 * character.h: Include <verify.h>.
8468 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8469 arguments are no wider than unsigned, as a compile-time check
8470 to prevent future regressions in this area.
8471 * data.c (Faset):
01103c44 8472 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8473 (Fsubst_char_in_region):
8474 * fns.c (concat):
8475 * xdisp.c (decode_mode_spec_coding):
8476 Adjust to CHAR_STRING's new requirement.
8477 * editfns.c (Finsert_char, Fsubst_char_in_region):
8478 * fns.c (concat): Check that character args are actually
8479 characters. Without this test, these functions did the wrong
8480 thing with wildly out-of-range values on 64-bit hosts.
8481
d37ca623
PE
8482 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8483 These casts should not be needed on 32-bit hosts, either.
8484 * keyboard.c (read_char):
8485 * lread.c (Fload): Remove casts to unsigned.
8486
ea204efb
PE
8487 * lisp.h (UNSIGNED_CMP): New macro.
8488 This fixes comparison bugs on 64-bit hosts.
8489 (ASCII_CHAR_P): Use it.
8490 * casefiddle.c (casify_object):
01103c44 8491 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8492 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8493 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8494 * dispextern.h (FACE_FROM_ID):
8495 * keyboard.c (read_char): Use UNSIGNED_CMP.
8496
41cb286c
PE
8497 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8498 not to EMACS_INT, to avoid GCC warning.
8499
4a1b9832
PE
8500 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8501
55daad71
PE
8502 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8503 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8504 isn't needed on 32-bit machines.
8f95c75c 8505
01103c44
PE
8506 * buffer.c (Fgenerate_new_buffer_name):
8507 Use EMACS_INT for count, not int.
0ceccced 8508 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8509
8510 * data.c (Qcompiled_function): Now static.
8511
c6f072e7
PE
8512 * window.c (window_body_lines): Now static.
8513
20ce5912
PE
8514 * image.c (gif_load): Rename local to avoid shadowing.
8515
9c4c5f81
PE
8516 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8517 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8518 * alloc.c (make_save_value): Integer argument is now of type
8519 ptrdiff_t, not int.
8520 (mark_object): Use ptrdiff_t, not int.
8521 * lisp.h (pD): New macro.
8522 * print.c (print_object): Use it.
8523
c0c5c8ae
PE
8524 * alloc.c: Use EMACS_INT, not int, to count objects.
8525 (total_conses, total_markers, total_symbols, total_vector_size)
8526 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8527 (total_free_floats, total_floats, total_free_intervals)
8528 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8529 Now EMACS_INT, not int. All uses changed.
8530 (Fgarbage_collect): Compute overall total using a double, so that
8531 integer overflow is less likely to be a problem. Check for overflow
8532 when converting back to an integer.
5a25e253
PE
8533 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8534 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8535 These were 'int' variables that could overflow on 64-bit hosts;
8536 they were never used, so remove them instead of repairing them.
211a0b2a 8537 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8538 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8539 Previously, this ceilinged at INT_MAX, but that doesn't work on
8540 64-bit machines.
e46bb31a 8541 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8542
c78baabf 8543 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8544 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8545 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8546 when a (possibly-narrower) signed value would do just as well.
8547 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8548
c9d624c6
PE
8549 * alloc.c: Catch some string size overflows that we were missing.
8550 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8551 for convenience in STRING_BYTES_MAX.
8552 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8553 The definition here is exact; the one in lisp.h was approximate.
8554 (allocate_string_data): Check for string overflow. This catches
8555 some instances we weren't catching before. Also, it catches
8556 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8557 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8558 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8559
c9d624c6
PE
8560 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8561 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8562 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8563
353032ce
PE
8564 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8565
2bccce07
PE
8566 * alloc.c (Fmake_string): Check for out-of-range init.
8567
0ac30604
SM
85682011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8569
8570 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8571
c195f2de
JD
85722011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8573
8574 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8575 xg_get_default_scrollbar_width.
8576
8577 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8578 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8579 (style_changed_cb): Call update_theme_scrollbar_width and call
8580 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8581 all frames (Bug#8505).
8582 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8583 Call gtk_window_set_resizable if HAVE_GTK3.
8584 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8585 and height if HAVE_GTK3 (Bug#8505).
8586 (scroll_bar_width_for_theme): New variable.
8587 (update_theme_scrollbar_width): New function.
8588 (xg_get_default_scrollbar_width): Move code to
8589 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8590 (xg_initialize): Call update_theme_scrollbar_width.
8591
8592 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8593
8594 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8595
e10ac9f1
MR
85962011-06-12 Martin Rudalics <rudalics@gmx.at>
8597
8598 * frame.c (make_frame): Call other_buffer_safely instead of
8599 other_buffer.
8600
8601 * window.c (temp_output_buffer_show): Call display_buffer with
8602 second argument Vtemp_buffer_show_specifiers and reset latter
8603 immediately after the call.
8604 (Vtemp_buffer_show_specifiers): New variable.
8605 (auto_window_vscroll_p, next_screen_context_lines)
8606 (Vscroll_preserve_screen_position): Remove leading asterisks from
8607 doc-strings.
8608
2d3c217e 86092011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8610
7b7f97e8 8611 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8612 * buffer.c (Qclone_number): Remove for now, as it's unused.
8613 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8614 (record_buffer): Remove unused local.
8615 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8616 (set_frame_buffer_list): Remove; unused.
8617 * frame.h (other_visible_frames): Remove decl.
8618 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8619 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8620 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8621 if HAVE_GPM.
8622 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8623 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8624 Define only if HAVE_GPM.
8625 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8626 (update_hints_inhibit): Remove; never set. All uses removed.
8627 * widgetprv.h (emacsFrameClassRec): Remove decl.
8628 * window.c (delete_deletable_window): Now returns void, since it
8629 wasn't returning anything.
8630 (compare_window_configurations): Remove unused locals.
8631 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8632 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8633 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8634 the same widths as pointers. This follows up on the 2011-05-06 patch.
8635 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8636 * xterm.h: Likewise.
8637 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8638
1384b89e
JB
86392011-06-12 Juanma Barranquero <lekktu@gmail.com>
8640
8641 * makefile.w32-in: Update dependencies.
8642 (LISP_H): Add lib/intprops.h.
8643
1100a63c
CY
86442011-06-11 Chong Yidong <cyd@stupidchicken.com>
8645
8646 * image.c (gif_load): Add animation frame delay to the metadata.
8647 (syms_of_image): Use DEFSYM. New symbol `delay'.
8648
6198ccd0
MR
86492011-06-11 Martin Rudalics <rudalics@gmx.at>
8650
8651 * window.c (delete_deletable_window): Re-add.
8652 (Fset_window_configuration): Rewrite to handle dead buffers and
8653 consequently deletable windows.
8654 (window_tree, Fwindow_tree): Remove. Supply functionality in
8655 window.el.
8656 (compare_window_configurations): Simplify code.
8657
b6e3633c
AS
86582011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8659
1ab0dee5
AS
8660 * image.c (imagemagick_load_image): Fix type mismatch.
8661 (Fimagemagick_types): Likewise.
8662
b6e3633c
AS
8663 * window.h (replace_buffer_in_windows): Declare.
8664
9397e56f
MR
86652011-06-11 Martin Rudalics <rudalics@gmx.at>
8666
8667 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8668 Qclone_number. Remove external declaration of Qdelete_window.
8669 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8670 code.
640c8776
SM
8671 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8672 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8673 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8674 buffer list implementation.
8675 (other_buffer_safely): New function.
8676 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8677 calls to replace_buffer_in_windows and
8678 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8679 if allowed.
8680 (record_buffer): Inhibit quitting and rewrite using quittable
8681 functions. Run Qbuffer_list_update_hook if allowed.
8682 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8683 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8684 Move switch-to-buffer to window.el.
9397e56f
MR
8685 (bury-buffer): Move to window.el.
8686 (Vbuffer_list_update_hook): New variable.
8687
8688 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8689 section.
8690
8691 * window.h (resize_frame_windows): Move up in code.
8692 (Fwindow_frame): Remove EXFUN.
8693 (replace_buffer_in_all_windows): Remove prototype.
8694 (replace_buffer_in_windows_safely): Add prototype.
8695
8696 * window.c: Declare Qdelete_window static again. Move down
8697 declaration of select_count.
8698 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8699 (Fother_window): Move to window.el.
8700 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8701 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8702 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8703 window.el.
8704 (replace_buffer_in_windows): Implement by calling
8705 Qreplace_buffer_in_windows.
8706 (replace_buffer_in_all_windows): Remove with some functionality
8707 moved into replace_buffer_in_windows_safely.
8708 (replace_buffer_in_windows_safely): New function.
8709 (select_window_norecord, select_frame_norecord): Move in front
8710 of run_window_configuration_change_hook. Remove now obsolete
8711 declarations.
640c8776
SM
8712 (Fset_window_buffer): Rewrite doc-string.
8713 Call Qrecord_window_buffer.
9397e56f
MR
8714 (keys_of_window): Move binding for other-window to window.el.
8715
b50691aa
CY
87162011-06-11 Chong Yidong <cyd@stupidchicken.com>
8717
8718 * dispextern.h (struct image): Replace data member, whose int_val
8719 and ptr_val fields were not used by anything, with a single
8720 lisp_val object.
8721
8722 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8723 (gif_clear_image, gif_load, imagemagick_load_image)
8724 (gs_clear_image, gs_load): Callers changed.
8725
3f754b86
PE
87262011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8727
cca69397
PE
8728 * buffer.h: Include <time.h>, for time_t.
8729 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8730
109e28d0
PE
8731 Fix minor problems found by static checking.
8732
60737f02
PE
8733 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8734
4b66faf3
PE
8735 Make identifiers static if they are not used in other modules.
8736 * data.c (Qcompiled_function, Qframe, Qvector):
8737 * image.c (QimageMagick, Qsvg):
8738 * minibuf.c (Qmetadata):
8739 * window.c (resize_window_check, resize_root_window): Now static.
8740 * window.h (resize_window_check, resize_root_window): Remove decls.
8741
109e28d0
PE
8742 * window.c (window_deletion_count, delete_deletable_window):
8743 Remove; unused.
46a4ce9e
PE
8744 (window_body_lines): Now static.
8745 (Fdelete_other_windows_internal): Mark vars as initialized.
8746 Make sure 'resize_failed' is initialized.
8747 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8748 (resize_window_apply): Remove unused local.
8749 * window.h (delete_deletable_window): Remove decl.
8750
109e28d0 8751 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8752 (imagemagick_load_image): Fix pointer signedness problem by changing
8753 last arg from unsigned char * to char *. All uses changed.
8754 Also, fix a local for similar reasons.
8755 Remove unused locals. Remove locals to avoid shadowing.
8756 (fn_rsvg_handle_free): Remove; unused.
8757 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8758 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8759
3f754b86
PE
8760 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8761
2547adb1
CY
87622011-06-10 Chong Yidong <cyd@stupidchicken.com>
8763
8764 * image.c (gif_load): Fix omitted cast error introduced by
8765 2011-06-06 change.
8766
2c8e37d4
MR
87672011-06-10 Martin Rudalics <rudalics@gmx.at>
8768
8769 * window.h (resize_proportionally, orig_total_lines)
8770 (orig_top_line): Remove from window structure.
8771 (set_window_height, set_window_width, change_window_heights)
8772 (Fdelete_window): Remove prototypes.
8773 (resize_frame_windows): Remove duplicate declaration.
8774
440a42e3
EZ
87752011-06-10 Eli Zaretskii <eliz@gnu.org>
8776
8777 * window.h (resize_frame_windows, resize_window_check)
8778 (delete_deletable_window, resize_root_window)
8779 (resize_frame_windows): Declare prototypes.
8780
8781 * window.c (resize_window_apply): Make definition be "static" to
8782 match the prototype.
8783
562dd5e9
MR
87842011-06-10 Martin Rudalics <rudalics@gmx.at>
8785
8786 * window.c: Remove declarations of Qwindow_size_fixed,
8787 window_min_size_1, window_min_size_2, window_min_size,
8788 size_window, window_fixed_size_p, enlarge_window, delete_window.
8789 Remove static from declaration of Qdelete_window, it's
8790 temporarily needed by Fbury_buffer.
8791 (replace_window): Don't assign orig_top_line and
8792 orig_total_lines.
8793 (Fdelete_window, delete_window): Remove. Window deletion is
8794 handled by window.el.
640c8776
SM
8795 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8796 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8797 (Fdelete_other_windows): Remove. Deleting other windows is
8798 handled by window.el.
8799 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8800 handled in window.el.
8801 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8802 Window minimum sizes are handled in window.el.
8803 (shrink_windows, size_window, set_window_height)
8804 (set_window_width, change_window_heights, window_height)
8805 (window_width, CURBEG, CURSIZE, enlarge_window)
8806 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8807 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8808 handled in window.el.
8809 (make_dummy_parent): Rename to make_parent_window and give it a
8810 second argument horflag.
8811 (make_window): Don't set resize_proportionally any more.
8812 (Fsplit_window): Remove. Windows are split in window.el.
8813 (save_restore_action, save_restore_orig_size)
8814 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8815 Resize mini windows in window.el.
8816 (grow_mini_window, shrink_mini_window): Implement by calling
8817 Qresize_root_window_vertically, resize_window_check and
8818 resize_window_apply.
640c8776
SM
8819 (saved_window, Fset_window_configuration, save_window_save):
8820 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8821 resize_proportionally.
8822 (window_min_height, window_min_width): Move to window.el.
8823 (keys_of_window): Move bindings for delete-other-windows,
8824 split-window, delete-window and enlarge-window to window.el.
8825
8826 * buffer.c: Temporarily extern Qdelete_window.
8827 (Fbury_buffer): Temporarily call Qdelete_window instead of
8828 Fdelete_window (Fbury_buffer will move to window.el soon).
8829
8830 * frame.c (set_menu_bar_lines_1): Remove code handling
8831 orig_top_line and orig_total_lines.
8832
8833 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8834 set_window_height but set heights directly.
8835 (change_frame_size_1): Use resize_frame_windows.
8836
8837 * xdisp.c (init_xdisp): Don't use set_window_height but set
8838 heights directly.
8839
640c8776
SM
8840 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8841 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8842 run_window_configuration_change_hook.
8843
8844 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8845 instead of change_window_heights and run
8846 run_window_configuration_change_hook.
8847
1a13852e
MR
88482011-06-09 Martin Rudalics <rudalics@gmx.at>
8849
8850 * window.c (replace_window): Rename second argument REPLACEMENT to
8851 NEW. New third argument SETFLAG. Rewrite.
8852 (delete_window, make_dummy_parent): Call replace_window with
8853 third argument 1.
8854 (window_list_1): Move down in code.
8855 (run_window_configuration_change_hook): Move set_buffer part
8856 before select_frame_norecord part in order to unwind correctly.
8857 Rename count1 to count.
8858 (recombine_windows, delete_deletable_window, resize_root_window)
8859 (Fdelete_other_windows_internal)
8860 (Frun_window_configuration_change_hook, make_parent_window)
8861 (resize_window_check, resize_window_apply, Fresize_window_apply)
8862 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8863 (Fdelete_window_internal, Fresize_mini_window_internal):
8864 New functions.
1a13852e
MR
8865 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8866
f3d1777e
MR
88672011-06-08 Martin Rudalics <rudalics@gmx.at>
8868
496e208e
MR
8869 * window.h (window): Add some new members to window structure -
8870 normal_lines, normal_cols, new_total, new_normal, clone_number,
8871 splits, nest, prev_buffers, next_buffers.
8872 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8873 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8874
f3d1777e
MR
8875 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8876 Remove.
496e208e
MR
8877 (make_dummy_parent): Set new members of windows structure.
8878 (make_window): Move down in code. Handle new members of window
8879 structure.
8880 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8881 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8882 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8883 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8884 (Fset_window_next_buffers, Fset_window_clone_number):
8885 New functions.
496e208e
MR
8886 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8887 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8888 Doc-string fixes.
8889 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8890 Argument WINDOW can be now internal window too.
8891 (Fwindow_use_time): Move up in code.
8892 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8893 Rewrite doc-string.
8894 (Fset_window_configuration, saved_window)
8895 (Fcurrent_window_configuration, save_window_save): Handle new
8896 members of window structure.
b9e809c2
MR
8897 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8898 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8899 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8900 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8901 Qget_mru_window, Qresize_root_window,
8902 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8903 Qauto_buffer_name; staticpro them.
f3d1777e 8904
abde8f8c
MR
89052011-06-07 Martin Rudalics <rudalics@gmx.at>
8906
8907 * window.c (Fwindow_total_size, Fwindow_left_column)
8908 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8909 (Fwindow_list_1): New functions.
8910 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8911 (Fwindow_width, Fscroll_left, Fscroll_right):
8912 Use window_body_cols instead of window_box_text_cols.
8913 (delete_window, Fset_window_configuration):
8914 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8915 (delete_all_subwindows): Take a window as argument and not a
8916 structure. Rewrite.
190b47e6
MR
8917 (window_loop): Remove handling of GET_LRU_WINDOW and
8918 GET_LARGEST_WINDOW.
8919 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8920
8921 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8922 window_box_text_cols. delete_all_subwindows now takes a
8923 Lisp_Object as argument.
abde8f8c 8924
640c8776
SM
8925 * indent.c (compute_motion, Fcompute_motion):
8926 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8927
fa8a67e6
MR
8928 * frame.c (delete_frame): Call delete_all_subwindows with root
8929 window as argument.
8930
a54e3482
DC
89312011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8932
8933 * fns.c (Fputhash): Document return value.
8934
60002bf5
CY
89352011-06-06 Chong Yidong <cyd@stupidchicken.com>
8936
8937 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8938
0c671da6 89392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8940
b862a52a 8941 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8942
be44ca6c
PE
8943 Check for overflow when converting integer to cons and back.
8944 * charset.c (Fdefine_charset_internal, Fdecode_char):
8945 Use cons_to_unsigned to catch overflow.
8946 (Fencode_char): Use INTEGER_TO_CONS.
8947 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8948 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8949 * data.c (long_to_cons, cons_to_long): Remove.
8950 (cons_to_unsigned, cons_to_signed): New functions.
8951 These signal an error for invalid or out-of-range values.
8952 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8953 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8954 * font.c (Ffont_variation_glyphs):
8955 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8956 * lisp.h: Include <intprops.h>.
8957 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8958 (cons_to_signed, cons_to_unsigned): New decls.
8959 (long_to_cons, cons_to_long): Remove decls.
8960 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8961 (Fprimitive_undo): Use CONS_TO_INTEGER.
8962 * xfns.c (Fx_window_property): Likewise.
8963 * xselect.c: Include <limits.h>.
8964 (x_own_selection, selection_data_to_lisp_data):
8965 Use INTEGER_TO_CONS.
8966 (x_handle_selection_request, x_handle_selection_clear)
8967 (x_get_foreign_selection, Fx_disown_selection_internal)
8968 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8969 (lisp_data_to_selection_data): Use cons_to_unsigned.
8970 (x_fill_property_data): Use cons_to_signed.
8971 Report values out of range.
8972
d1f3d2af
PE
8973 Check for buffer and string overflow more precisely.
8974 * buffer.h (BUF_BYTES_MAX): New macro.
8975 * lisp.h (STRING_BYTES_MAX): New macro.
8976 * alloc.c (Fmake_string):
8977 * character.c (string_escape_byte8):
8978 * coding.c (coding_alloc_by_realloc):
8979 * doprnt.c (doprnt):
8980 * editfns.c (Fformat):
8981 * eval.c (verror):
8982 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8983 since they may not be the same number.
8984 * editfns.c (Finsert_char):
8985 * fileio.c (Finsert_file_contents):
8986 Likewise for BUF_BYTES_MAX.
8987
dd52fcea
PE
8988 * image.c: Use ptrdiff_t, not int, for sizes.
8989 (slurp_file): Switch from int to ptrdiff_t.
8990 All uses changed.
8991 (slurp_file): Check that file size fits in both size_t (for
8992 malloc) and ptrdiff_t (for sanity and safety).
8993
7f9bbdbb
PE
8994 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8995 if b->modtime has its maximal value.
8996
dfe18f82
PE
8997 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8998
84acfcf0
PE
8999 Don't assume time_t can fit into int.
9000 * buffer.h (struct buffer.modtime): Now time_t, not int.
9001 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9002 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9003
ccd9a01a
PE
9004 Minor fixes for signed vs unsigned integers.
9005 * character.h (MAYBE_UNIFY_CHAR):
9006 * charset.c (maybe_unify_char):
9007 * keyboard.c (read_char, reorder_modifiers):
9008 XINT -> XFASTINT, since the integer must be nonnegative.
9009 * ftfont.c (ftfont_spec_pattern):
9010 * keymap.c (access_keymap, silly_event_symbol_error):
9011 XUINT -> XFASTINT, since the integer must be nonnegative.
9012 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9013 since it makes no difference and we prefer signed.
9014 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9015 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9016 nonnegative.
9017
d6d100dd
SM
90182011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9019
9020 * window.h (Fwindow_frame): Declare.
9021
2b6148e4
PE
90222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9023
9024 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9025 (SPARE_MEMORY): Always define.
9026 (LARGE_REQUEST): Remove.
9027 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9028
f230ecc9
MR
90292011-06-06 Martin Rudalics <rudalics@gmx.at>
9030
727e958e
MR
9031 * lisp.h: Move EXFUNS for Fframe_root_window,
9032 Fframe_first_window and Fset_frame_selected_window to window.h.
9033
9034 * window.h: Move EXFUNS for Fframe_root_window,
9035 Fframe_first_window and Fset_frame_selected_window here from
9036 lisp.h.
9037
9038 * frame.c (Fwindow_frame, Fframe_first_window)
9039 (Fframe_root_window, Fframe_selected_window)
9040 (Fset_frame_selected_window): Move to window.c.
9041 (Factive_minibuffer_window): Move to minibuf.c.
9042 (Fother_visible_frames_p): New function.
9043
9044 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9045
f230ecc9
MR
9046 * window.c (decode_window, decode_any_window): Move up in code.
9047 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9048 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9049 (Fwindow_buffer): Move up and rewrite doc-string.
9050 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9051 (Fwindow_prev): New functions.
727e958e
MR
9052 (Fwindow_frame): Move here from frame.c. Accept any window as
9053 argument.
9054 (Fframe_root_window, Fframe_first_window)
9055 (Fframe_selected_window): Move here from frame.c. Accept frame
9056 or arbitrary window as argument. Update doc-strings.
9057 (Fminibuffer_window): Move up in code.
9058 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9059 (Fset_frame_selected_window): Move here from frame.c.
9060 Marginal rewrite.
727e958e
MR
9061 (Fselected_window, select_window, Fselect_window): Move up in
9062 code. Minor doc-string fixes.
f230ecc9 9063
4d09bcf6
PE
90642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9065
9066 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9067 Do not assume that spare memory exists; that assumption is valid
9068 only if SYSTEM_MALLOC.
9069 (LARGE_REQUEST): New macro, so that the issue of large requests
9070 is separated from the issue of spare memory.
9071
810928a2
AS
90722011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9073
172418ad
AS
9074 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9075 format. (Bug#8806)
9076
43f862f7
AS
9077 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9078
810928a2
AS
9079 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9080 before statements.
9081
a059fe24
JD
90822011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9083
9084 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9085
9086 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9087
9088 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9089 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9090
989bf368
JB
90912011-06-05 Juanma Barranquero <lekktu@gmail.com>
9092
9093 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9094
4b80f674
CY
90952011-06-04 Chong Yidong <cyd@stupidchicken.com>
9096
9097 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9098 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9099 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9100 New error handlers.
4b80f674
CY
9101 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9102 Obey Vx_select_enable_clipboard_manager. Catch errors in
9103 x_clipboard_manager_save (Bug#8779).
9104 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9105 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9106
99a33b77 91072011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9108
9109 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9110
99a33b77 91112011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9112
9113 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9114 in the current matrix if keep_current_p is non-zero.
9115
8264569d
EZ
91162011-06-04 Eli Zaretskii <eliz@gnu.org>
9117
9118 * bidi.c (bidi_level_of_next_char): Fix last change.
9119
57f97249
EZ
91202011-06-03 Eli Zaretskii <eliz@gnu.org>
9121
fec2107c 9122 Support bidi reordering of text covered by display properties.
57f97249 9123
fec2107c
EZ
9124 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9125 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9126 (bidi_cache_search, bidi_cache_iterator_state)
9127 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9128 (bidi_level_of_next_char, bidi_move_to_visually_next):
9129 Support character positions inside a run of characters covered by a
fec2107c
EZ
9130 display string.
9131 (bidi_paragraph_init, bidi_resolve_explicit_1)
9132 (bidi_level_of_next_char): Call bidi_fetch_char and
9133 bidi_fetch_char_advance instead of FETCH_CHAR and
9134 FETCH_CHAR_ADVANCE.
9135 (bidi_init_it): Initialize new members.
9136 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9137 definitions.
9138 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9139 instead of using explicit *_CHAR codes.
d6d100dd
SM
9140 (bidi_resolve_explicit, bidi_resolve_weak):
9141 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9142 bidirectional text is supported only in multibyte buffers.
9143 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9144 it to initialize the frame_window_p member of struct bidi_it.
9145 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9146 (bidi_resolve_explicit, bidi_resolve_weak)
9147 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9148 bidi_it->nchars is non-positive.
9149 (bidi_level_of_next_char): Don't try to lookup the cache for the
9150 next/previous character if nothing is cached there yet, or if we
9151 were just reseat()'ed to a new position.
c40e2fb2 9152
0e14fe90
EZ
9153 * xdisp.c (set_cursor_from_row): Set start and stop points
9154 according to the row's direction when priming the loop that looks
9155 for the glyph on which to display cursor.
9156 (single_display_spec_intangible_p): Function deleted.
9157 (display_prop_intangible_p): Reimplement to call
9158 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9159 Accept 3 additional arguments needed by handle_display_spec.
9160 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9161 values: lists, `(when COND...)' forms, etc.
9162 (single_display_spec_string_p): Support property values that are
9163 lists with the argument STRING its top-level element.
9164 (display_prop_string_p): Fix the condition for processing a
9165 property that is a list to be consistent with handle_display_spec.
fec2107c 9166 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9167 last portion of handle_display_prop.
9168 (compute_display_string_pos): Accept additional argument
9169 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9170 value of a `display' property is a "replacing spec".
9171 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9172 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9173 the display property, but just return a value indicating whether
9174 the display property will replace the characters it covers.
9175 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9176 frame_window_p members of struct bidi_it.
d6d100dd
SM
9177 (compute_display_string_pos, compute_display_string_end):
9178 New functions.
fec2107c
EZ
9179 (push_it): Accept second argument POSITION, where pop_it should
9180 jump to continue iteration.
9181 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9182
fec2107c
EZ
9183 * keyboard.c (adjust_point_for_property): Adjust the call to
9184 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9185
9186 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9187 (bidi_init_it): Update prototypes.
9188 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9189 (compute_display_string_pos, compute_display_string_end):
9190 Declare prototypes.
fec2107c
EZ
9191 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9192 EMACS_INT.
fc6f18ce 9193
40087514 91942011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9195
57f53182
PE
9196 Malloc failure behavior now depends on size of allocation.
9197 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9198 * lisp.h: Change signatures accordingly.
9199 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9200 All callers changed. (Bug#8762)
9201
9202 * gnutls.c: Use Emacs's memory allocators.
9203 Without this change, the gnutls library would invoke malloc etc.
9204 directly, which causes problems on non-SYNC_INPUT hosts, and which
9205 runs afoul of improving memory_full behavior. (Bug#8761)
9206 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9207 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9208 xfree instead of the default malloc, realloc, free.
9209 (Fgnutls_boot): No need to check for memory allocation failure,
9210 since xmalloc does that for us.
9211
ac32cd99 9212 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9213 * category.c (hash_get_category_set):
9214 * ccl.c (ccl_driver):
9215 * charset.c (Fdefine_charset_internal):
9216 * charset.h (struct charset.hash_index):
9217 * composite.c (get_composition_id, gstring_lookup_cache)
9218 (composition_gstring_put_cache):
9219 * composite.h (struct composition.hash_index):
9220 * dispextern.h (struct image.hash):
9221 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9222 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9223 (hashfn_equal, hashfn_user_defined, make_hash_table)
9224 (maybe_resize_hash_table, hash_lookup, hash_put)
9225 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9226 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9227 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9228 * image.c (make_image, search_image_cache, lookup_image)
9229 (xpm_put_color_table_h):
9230 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9231 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9232 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9233 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9234 * alloc.c (allocate_vectorlike):
9235 Check for overflow in vector size calculations.
9236 * ccl.c (ccl_driver):
9237 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9238 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9239 need to be updated by these changes.
40087514
PE
9240 * fns.c (make_hash_table, maybe_resize_hash_table):
9241 Check for integer overflow with large hash tables.
0de4bb68
PE
9242 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9243 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9244 (SXHASH_REDUCE): New macro.
9245 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9246 Use it instead of discarding useful hash info with large hash values.
9247 (sxhash_float): New function.
9248 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9249 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9250 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9251 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9252 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9253 Adjust signatures to match updated version of code.
9254 (consing_since_gc): Now EMACS_INT, since a single hash table can
9255 use more than INT_MAX bytes.
9256
698d32e2
DN
92572011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9258
9259 Make it possible to build with GCC-4.6+ -O2 -flto.
9260
9261 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9262
fd6fa53f
SM
92632011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9264
9265 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9266 Call minibuffer-inactive-mode.
9267
864db017
JB
92682011-05-31 Juanma Barranquero <lekktu@gmail.com>
9269
9270 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9271 Update dependencies.
9272
2ad0baf4
DN
92732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9274
9275 * data.c (init_data): Remove code for UTS, this system is not
9276 supported anymore.
9277
4fcc2638
DN
92782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9279
9280 Don't force ./temacs to start in terminal mode.
9281
9282 * frame.c (make_initial_frame): Initialize faces in all cases, not
9283 only when CANNOT_DUMP is defined.
9284 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9285
c56e0fd5
DN
92862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9287
9288 * dispnew.c (add_window_display_history): Use const for the string
9289 pointer. Remove declaration, not needed.
9290
333d54da 92912011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9292
55d4c1b2 9293 Use 'inline', not 'INLINE'.
333d54da 9294 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9295 * alloc.c, fontset.c (INLINE): Remove.
9296 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9297 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9298 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9299 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9300 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9301
738db178
DN
93022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9303
9304 Make it possible to run ./temacs.
9305
9306 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9307 syms_of_callproc does the same thing. Remove test for
9308 "initialized", do it in the caller.
9309 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9310
620c53a6
SM
93112011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9312
9313 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9314 (read_minibuf): Use get_minibuffer.
9315 (syms_of_minibuf): Use DEFSYM.
9316 (Qmetadata): New var.
9317 * data.c (Qbuffer): Don't make it static.
9318 (syms_of_data): Use DEFSYM.
9319
e003a292
PE
93202011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9321
9322 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9323 (CCL_CODE_MIN): New macro.
9324
ed008a6d
PE
93252011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9326
3687c2ef
PE
9327 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9328
ed008a6d
PE
9329 * eval.c (Qdebug): Now static.
9330 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9331 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9332 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9333
d66c4c7c
CY
93342011-05-29 Chong Yidong <cyd@stupidchicken.com>
9335
9336 * image.c: Various fixes to ImageMagick code comments.
9337 (Fimagemagick_types): Doc fix.
9338
5fbc2025
PE
93392011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9340
0196f88a
PE
9341 Minor fixes prompted by GCC 4.6.0 warnings.
9342
9343 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9344
5fbc2025
PE
9345 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9346 (x_clipboard_manager_save_all): Move extern decl to ...
9347 * xterm.h: ... here, so that it can be checked for consistency.
9348
1dd3c2d9
CY
93492011-05-29 Chong Yidong <cyd@stupidchicken.com>
9350
9351 * xselect.c (x_clipboard_manager_save_frame)
9352 (x_clipboard_manager_save_all): New functions.
9353 (Fx_clipboard_manager_save): Lisp function deleted.
9354
9355 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9356 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9357
9358 * xterm.h: Update prototype.
9359
5ba6571d
WX
93602011-05-28 William Xu <william.xwl@gmail.com>
9361
9362 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9363 exiting (Bug#8239).
9364
3eaff834
JM
93652011-05-28 Jim Meyering <meyering@redhat.com>
9366
e1900994 9367 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9368 * fns.c (to_uchar): Define.
9369 (crypto_hash_function): Use it to convert some newly-signed
9370 variables to unsigned, to avoid sign-extension bugs. For example,
9371 without this change, (md5 "truc") would evaluate to
9372 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9373 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9374 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9375
0f6990a7
PE
93762011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9377
9378 Integer overflow fixes.
c8a9ca5a 9379
08686060
PE
9380 * dbusbind.c: Serial number integer overflow fixes.
9381 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9382 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9383 to hold a serial number that is too large for a fixnum.
9384 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9385 Check for serial numbers out of range. Decode any serial number
59568bf0 9386 that was so large that it became a float. (Bug#8722)
08686060 9387
2d1fc3c7
PE
9388 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9389 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9390 Use XFASTINT rather than XUINT when numbers are nonnegative.
9391 (xd_append_arg, Fdbus_method_return_internal):
9392 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9393 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9394 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9395 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9396 (Bug#8722)
2d1fc3c7 9397
c8a9ca5a
PE
9398 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9399
519e1d69
PE
9400 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9401
6df6ae42 9402 ccl: Add integer overflow checks.
30569699
PE
9403 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9404 (IN_INT_RANGE): New macros.
9405 (ccl_driver): Use them to check for integer overflow when
9406 decoding a CCL program. Many of the new checks are whether XINT (x)
9407 fits in int; it doesn't always, on 64-bit hosts. The new version
9408 doesn't catch all possible integer overflows, but it's an
847044ea 9409 improvement. (Bug#8719)
30569699 9410
c11285dc
PE
9411 * alloc.c (make_event_array): Use XINT, not XUINT.
9412 There's no need for unsigned here.
9413
fdccd48e
PE
9414 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9415 This follows up to the 2011-05-06 change that substituted uintptr_t
9416 for EMACS_INT. This case wasn't caught back then.
9417
37910ab2
PE
9418 Rework Fformat to avoid integer overflow issues.
9419 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9420 now (part of C89). Include <verify.h>.
9421 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9422 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9423 (Fformat): Avoid the prepass trying to compute sizes; it was only
9424 approximate and thus did not catch overflow reliably. Instead, walk
9425 through the format just once, formatting and computing sizes as we go,
9426 checking for integer overflow at every step, and allocating a larger
9427 buffer as needed. Keep track separately whether the format is
9428 multibyte. Keep only the most-recently calculated precision, rather
9429 than them all. Record whether each argument has been converted to
9430 string. Use EMACS_INT, not int, for byte and char and arg counts.
9431 Support field widths and precisions larger than INT_MAX. Avoid
9432 sprintf's undefined behavior with conversion specifications such as %#d
9433 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9434 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9435 formatting out-of-range floating point numbers with int
9173deec 9436 formats. (Bug#8668)
37910ab2 9437
2e6578fb
PE
9438 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9439
0ae6bdee
PE
9440 * data.c: Avoid integer truncation in expressions involving floats.
9441 * data.c: Include <intprops.h>.
9442 (arith_driver): When there's an integer overflow in an expression
9443 involving floating point, convert the integers to floating point
9444 so that the resulting value does not suffer from catastrophic
9445 integer truncation. For example, on a 64-bit host (* 4
9446 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9447 Do not rely on undefined behavior after integer overflow.
9448
de883a70
PE
9449 merge count_size_as_multibyte, parse_str_to_multibyte
9450 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9451 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9452 Check for integer overflow.
9453 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9454 since it's now a duplicate of the other. This is more of
9455 a character than a buffer op, so better that it's in character.c.
9456 * fns.c, print.c: Adjust to above changes.
9457
2ff916cb
PE
94582011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9459
9460 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9461
f1b54466
PE
94622011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9463
fb1ac845
PE
9464 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9465 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9466 (x_clipboard_manager_save): Now static.
9467 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9468
f1b54466
PE
9469 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9470 (crypto_hash_function): Now static.
9471 Fix pointer signedness problems. Avoid unnecessary initializations.
9472
a9f737ee
CY
94732011-05-27 Chong Yidong <cyd@stupidchicken.com>
9474
9475 * termhooks.h (Vselection_alist): Make it terminal-local.
9476
9477 * terminal.c (create_terminal): Initialize it.
9478
9479 * xselect.c: Support for clipboard managers.
9480 (Vselection_alist): Move to termhooks.h as terminal-local var.
9481 (LOCAL_SELECTION): New macro.
9482 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9483 (symbol_to_x_atom): Remove gratuitous arg.
9484 (x_handle_selection_request, lisp_data_to_selection_data)
9485 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9486 (x_own_selection, x_get_local_selection, x_convert_selection):
9487 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9488 (some_frame_on_display): Delete unused function.
9489 (Fx_own_selection_internal, Fx_get_selection_internal)
9490 (Fx_disown_selection_internal, Fx_selection_owner_p)
9491 (Fx_selection_exists_p): New optional frame arg.
9492 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9493 (x_handle_selection_clear): Don't treat other terminals with the
9494 same keyboard specially. Use the terminal-local Vselection_alist.
9495 (x_clear_frame_selections): Use Frun_hook_with_args.
9496
9497 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9498
9499 * xterm.h: Add support for those atoms.
9500
e067f0c1
CY
95012011-05-26 Chong Yidong <cyd@stupidchicken.com>
9502
9503 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9504 (converted_selections, conversion_fail_tag): New global variables.
9505 (x_selection_request_lisp_error): Free the above.
9506 (x_get_local_selection): Remove unnecessary code.
9507 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9508 of converted selections stored in converted_selections.
9509 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9510 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9511 (x_convert_selection): New function.
9512 (x_handle_selection_event): Simplify.
9513 (x_get_foreign_selection): Don't ignore incoming requests while
9514 waiting for an answer; this will fail when we implement
9515 SAVE_TARGETS, and seems unnecessary anyway.
9516 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9517 (Vx_sent_selection_functions): Doc fix.
9518
0f4aebc0
LL
95192011-05-26 Leo Liu <sdl.web@gmail.com>
9520
9521 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9522
e61124cd
YM
95232011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9524
9525 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9526
9527 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9528 for fringe update if it has periodic bitmap.
ac389d0c 9529 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9530 and fringe_bitmap_periodic_p.
9531
9532 * fringe.c (get_fringe_bitmap_data): New function.
9533 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9534 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9535 row. Mark glyph row for fringe update if periodicity changed.
9536
9537 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9538 for fringe update unless it has periodic bitmap.
9539
f16d9837
KH
95402011-05-25 Kenichi Handa <handa@m17n.org>
9541
9542 * xdisp.c (get_next_display_element): Set correct it->face_id for
9543 a static composition.
9544
e1b90ef6
LL
95452011-05-24 Leo Liu <sdl.web@gmail.com>
9546
9547 * deps.mk (fns.o):
9548 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9549
9550 * fns.c (crypto_hash_function, Fsha1): New function.
9551 (Fmd5): Use crypto_hash_function.
9552 (syms_of_fns): Add Ssha1.
9553
7400048f
PE
95542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9555
9556 * gnutls.c: Remove unused macros.
9557 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9558 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9559 Remove macros that are defined and never used.
9560 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9561
abb71cf4
CY
95622011-05-22 Chong Yidong <cyd@stupidchicken.com>
9563
9564 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9565 (Fx_get_selection_internal): Minor cleanup.
9566 (Fx_own_selection_internal): Rename arguments for consistency with
9567 select.el.
9568
6307db39
PE
95692011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9570
9571 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9572
f3d4e0a4
CY
95732011-05-22 Chong Yidong <cyd@stupidchicken.com>
9574
9575 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9576
4d8ade89
YM
95772011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9578
9579 * dispnew.c (scrolling_window): Don't exclude the case that the
9580 last enabled row in the desired matrix touches the bottom boundary.
9581
32078c8d
GM
95822011-05-21 Glenn Morris <rgm@gnu.org>
9583
9584 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9585 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9586 and add some more files.
32078c8d 9587
7285dc67
EZ
95882011-05-20 Eli Zaretskii <eliz@gnu.org>
9589
9590 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9591 report_file_error introduced by the change from 2011-05-07.
9592
89d1bd22
PE
95932011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9594
9595 * systime.h (Time): Define only if emacs is defined.
9596 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9597 where the include path doesn't have X11/X.h by default. See
9598 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9599
cd394be1 96002011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9601
9602 * composite.c (find_automatic_composition): Fix previous change.
9603
b9704ad9
GM
96042011-05-20 Glenn Morris <rgm@gnu.org>
9605
9606 * lisp.mk: New file, split from Makefile.in.
9607 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9608 (shortlisp): Remove.
9609 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9610
4a720484
GM
96112011-05-19 Glenn Morris <rgm@gnu.org>
9612
9613 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9614 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9615 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9616 (lisp): Set the order to that of loadup.el.
9617 (shortlisp): Make it a copy of $lisp.
9618 (SOME_MACHINE_LISP): Remove.
9619 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9620 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9621
a28d4396
KH
96222011-05-18 Kenichi Handa <handa@m17n.org>
9623
9624 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9625 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9626 (find_automatic_composition): Mostly rewrite for efficiency.
9627
a2b1fa8e
JB
96282011-05-18 Juanma Barranquero <lekktu@gmail.com>
9629
9630 * makefile.w32-in: Update dependencies.
9631
8e1f5610
CS
96322011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9633
9634 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9635 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9636
7025ee00 96372011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9638
cdfa6eab
PE
9639 Fix some integer overflow issues, such as string length overflow.
9640
06d6db33
PE
9641 * insdel.c (count_size_as_multibyte): Check for string overflow.
9642
2b4560a8
PE
9643 * character.c (lisp_string_width): Check for string overflow.
9644 Use EMACS_INT, not int, for string indexes and lengths; in
9645 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9646 the resulting string length overflows an EMACS_INT; instead,
9647 report a string overflow if no precision given. When checking for
9648 precision exhaustion, use a check that cannot possibly have
9649 integer overflow. (Bug#8675)
9650 * character.h (lisp_string_width): Adjust to new signature.
9651
cb93f9be
PE
9652 * alloc.c (string_overflow): New function.
9653 (Fmake_string): Use it. This doesn't change behavior, but saves
9654 a few bytes and will simplify future changes.
9655 * character.c (string_escape_byte8): Likewise.
9656 * lisp.h (string_overflow): New decl.
9657
1a1f3366
PE
9658 Fixups, following up to the user-interface timestamp change.
9659 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9660 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9661 * msdos.c (mouse_get_pos): Likewise.
9662 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9663 * w32gui.h (Time): Define by including "systime.h" rather than by
9664 declaring it ourselves. (Bug#8664)
9665
d4e3e4d3
PE
9666 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9667 * image.c (clear_image_cache): Likewise.
9668
f6a24d19
PE
9669 * term.c (term_mouse_position): Don't assume time_t wraparound.
9670
08dc5ae6
PE
9671 Be more systematic about user-interface timestamps.
9672 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9673 and sometimes 'EMACS_UINT', to represent these timestamps.
9674 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9675 This makes the code easier to follow, and makes it easier to catch
9676 integer overflow bugs such as Bug#8664.
9677 * frame.c (Fmouse_position, Fmouse_pixel_position):
9678 Use Time, not unsigned long, for user-interface timestamps.
9679 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9680 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9681 * keyboard.h (last_event_timestamp): Likewise.
9682 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9683 * menu.h (xmenu_show): Likewise.
9684 * term.c (term_mouse_position): Likewise.
9685 * termhooks.h (struct input_event.timestamp): Likewise.
9686 (struct terminal.mouse_position_hook): Likewise.
9687 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9688 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9689 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9690 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9691 what it was before.
9692 * menu.h, termhooks.h: Include "systime.h", for Time.
9693
8e55734a
PE
9694 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9695 Don't assume that the difference between two unsigned long values
9696 can fit into an integer. At this point, we know button_down_time
9697 <= event->timestamp, so the difference must be nonnegative, so
9698 there's no need to cast the result if double-click-time is
9699 nonnegative, as it should be; check that it's nonnegative, just in
9700 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9701 apart (about 25 days). (Bug#8664)
8e55734a 9702
841f1b75 9703 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9704 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9705
3e26f69c
PE
9706 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9707 that always fit in int. Use a sentinel instead of a counter, to
9708 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9709 * frame.h (struct frame): Use int for menu_bar_items_used
9710 instead of EMACS_INT, since it always fits in int.
3e26f69c 9711
5cc152c0
PE
9712 * menu.c (grow_menu_items): Check for int overflow.
9713
d89eb65e
PE
9714 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9715
5235bd3e
PE
9716 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9717 Before, the code was not consistent. These values cannot exceed
9718 2**31 - 1 so there's no need to make them unsigned.
9719 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9720 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9721 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9722 as modifiers.
9723 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9724
bc827e23
PE
9725 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9726 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9727 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9728 presumably because the widths might not match.
9729
78eb494e
PE
9730 * window.c (size_window): Avoid needless test at loop start.
9731
04f2d78b
CB
97322011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9733
9734 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9735
d2fc7e3d 97362011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9737
9738 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9739
d2fc7e3d 97402011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9741
9742 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9743 `width' to `bar_area_x' and `bar_area_width', respectively.
9744 (x_scroll_run): Take account of fringe background extension.
9745
04f2d78b
CB
9746 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9747 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9748 `bar_area_width', respectively.
9749 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9750 background extension.
9751
79b70037
GM
97522011-05-10 Jim Meyering <meyering@redhat.com>
9753
9754 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9755
2f142cc5
JB
97562011-05-10 Juanma Barranquero <lekktu@gmail.com>
9757
9758 * image.c (Finit_image_library): Return t for built-in image types,
9759 like pbm and xbm. (Bug#8640)
9760
57679c86
AS
97612011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9762
9763 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9764
888c9e86
EZ
97652011-05-07 Eli Zaretskii <eliz@gnu.org>
9766
b0512a1d
EZ
9767 * w32console.c (Fset_screen_color): Doc fix.
9768 (Fget_screen_color): New function.
9769 (syms_of_ntterm): Defsubr it.
9770
7285dc67
EZ
9771 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9772 unlink the temporary file if Fcall_process didn't create it in the
9773 first place.
9774 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9775 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9776 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9777 cue to call_process_cleanup not to close that handle.
9778
4d3fcc8e
BK
97792011-05-07 Ben Key <bkey76@gmail.com>
9780
9781 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9782 one of two shell specific rules, either bootstrap-temacs-CMD or
9783 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9784 to the previous implementation of the bootstrap-temacs rule.
9785 The bootstrap-temacs-CMD rule is similar to the previous
9786 implementation of the bootstrap-temacs rule except that it
9787 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9788 variable.
9789
9790 These changes, along with some changes to nt/configure.bat,
9791 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9792 earlier fix to add support for --cflags and --ldflags options
9793 that include quotes so that it works whether make uses cmd or
9794 sh as the shell.
9795
b4289b64
MA
97962011-05-06 Michael Albinus <michael.albinus@gmx.de>
9797
9798 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9799 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9800 is a constant.
9801 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9802 a string. Handle both cases.
9803 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9804 (Fdbus_register_method): Use Qinvalid_function.
9805
af4c0e28
JB
98062011-05-06 Juanma Barranquero <lekktu@gmail.com>
9807
9808 * makefile.w32-in: Update dependencies.
9809 (LISP_H): Add inttypes.h and stdin.h.
9810 (PROCESS_H): Add unistd.h.
9811
c51453d9
EZ
98122011-05-06 Eli Zaretskii <eliz@gnu.org>
9813
9814 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9815 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9816
8ff0ac3c 98172011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9818
4c4b566b
PE
9819 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9820
aab2b9b5
PE
9821 * term.c (vfatal): Remove stray call to va_end.
9822 It's not needed and the C Standard doesn't allow it here anyway.
9823
c378da0b
PE
9824 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9825 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9826
288b08c7
PE
9827 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9828 bytes.
9829
e3601888
PE
9830 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9831
db6c0e74
PE
9832 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9833
dd5963ea
PE
9834 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9835
88c9450f
PE
9836 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9837
2f9442b8
PE
9838 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9839
c032b5f8
PE
9840 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9841 * charset.c (Fdefine_charset_internal): Don't initialize
9842 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9843 32-bit int (Bug#8600).
a108c10b
PE
9844
9845 * lread.c (read_integer): Be more consistent with string-to-number.
9846 Use string_to_number to do the actual conversion; this avoids
9847 rounding errors and fixes some other screwups. Without this fix,
9848 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9849 (digit_to_number): Move earlier, for benefit of read_integer.
9850 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9851 not a digit in any supported base. (Bug#8602)
a108c10b 9852
ad5f9eea
PE
9853 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9854
aec1708a
PE
9855 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9856 to match comment at start of function. This also removes a
9857 GCC warning about overflow in a 32+64-bit port.
9858
47be4ab5
PE
9859 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9860
371cac43
PE
9861 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9862 Reported by Stefan Monnier in
9863 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9864 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9865 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9866
d01a7826
PE
9867 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9868 (EMACS_UINTPTR): Likewise, with uintptr_t.
9869
7fd47d5c
PE
9870 * lisp.h: Prefer 64-bit EMACS_INT if available.
9871 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9872 on 32-bit hosts that have 64-bit int, so that they can access
9873 large files.
122b0c86
PE
9874 However, temporarily disable this change unless the temporary
9875 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9876
8727937b
PE
9877 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9878
8ac068ac
PE
9879 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9880 This removes an assumption that EMACS_INT and long are the same
9881 width as pointers. The assumption is true for Emacs porting targets
9882 now, but we want to make other targets possible.
9883 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9884 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9885 In the rest of the code, change types of integers that hold casted
9886 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9887 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9888 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9889 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9890 No need to cast type when ORing.
9891 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9892 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9893 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9894 assume EMACS_INT is the same width as char *.
9895 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9896 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9897 Remove no-longer-needed casts.
9898 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9899 (xg_tool_bar_help_callback, xg_make_tool_item):
9900 Use EMACS_INTPTR to hold an integer
9901 that will be cast to void *; this can avoid a GCC warning
9902 if EMACS_INT is not the same width as void *.
9903 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9904 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9905 (current_message_1, set_message_1):
9906 Use a local to convert to proper width without a cast.
9907 * xmenu.c (dialog_selection_callback): Likewise.
9908
ede49d71
PE
9909 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9910 Also, don't assume VALBITS / RAND_BITS is less than 5,
9911 and don't rely on undefined behavior when shifting a 1 left into
9912 the sign bit.
9913 * lisp.h (get_random): Change signature to match.
9914
2f30ecd0
PE
9915 * lread.c (hash_string): Use size_t, not int, for hash computation.
9916 Normally we prefer signed values; but hashing is special, because
9917 it's better to use unsigned division on hash table sizes so that
9918 the remainder is nonnegative. Also, size_t is the natural width
9919 for hashing into memory. The previous code used 'int', which doesn't
9920 retain enough info to hash well into very large tables.
9921 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9922
2a866e7b
PE
9923 * dbusbind.c: Don't possibly lose pointer info when converting.
9924 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9925 Use XPNTR rather than XHASH, so that the high-order bits of
9926 the pointer aren't lost when converting through void *.
9927
51639eac
PE
9928 * eval.c (Fautoload): Don't double-shift a pointer.
9929
92394119
PE
9930 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9931
dbdb9a7c
JB
99322011-05-06 Juanma Barranquero <lekktu@gmail.com>
9933
9934 * gnutls.c (DEF_GNUTLS_FN):
9935 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9936
db7a0b4f
AS
99372011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9938
9939 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9940 marker. (Bug#8610)
9941
cd394be1 99422011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9943
9944 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9945 New version that can reserve upto 2GB of heap space.
9946
f7ff1b0f 99472011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9948
9949 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9950
639c109b
TZ
99512011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9952
9953 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9954 `gnutls_certificate_set_x509_key_file'.
9955
d2127135
JB
99562011-05-05 Juanma Barranquero <lekktu@gmail.com>
9957
9958 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9959 Update dependencies.
9960
e968f4f3
JB
99612011-05-04 Juanma Barranquero <lekktu@gmail.com>
9962
9963 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9964 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9965 Remove unused parameter `fildes'.
9966 * process.c (read_process_output, send_process): Don't pass it.
9967
84d358f0
JB
99682011-05-04 Juanma Barranquero <lekktu@gmail.com>
9969
9970 Fix previous change: the library cache is defined in w32.c.
9971 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9972 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9973
0898ca10
JB
99742011-05-04 Juanma Barranquero <lekktu@gmail.com>
9975
9976 Implement dynamic loading of GnuTLS on Windows.
9977
9978 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9979 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9980 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9981 Declare.
9982
9983 * gnutls.c (Qgnutls_dll): Define.
9984 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9985 (gnutls_*): Declare function pointers.
9986 (init_gnutls_functions): New function to initialize function pointers.
9987 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9988 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9989 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9990 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9991 (emacs_gnutls_write, emacs_gnutls_read)
9992 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9993 (Fgnutls_available_p): New function.
9994 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9995 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9996 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9997
9998 * image.c: Include w32.h.
9999 (Vimage_type_cache): Delete.
10000 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10001 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10002 (w32_delayed_load): Move to w32.c.
10003
10004 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10005
10006 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10007 (w32_delayed_load): Move from image.c. When loading a library, record
10008 its filename in the :loaded-from property of the library id.
10009 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10010 Initialize and staticpro them.
10011 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10012
10013 * process.c: Include lisp.h before w32.h, not after.
10014 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10015 instead of gnutls_record_check_pending.
10016
10017 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10018
ff4de4aa
TZ
100192011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10020
10021 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10022 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10023 as passed in.
10024
abe95abb
JD
100252011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10026
10027 * xterm.c (x_set_frame_alpha): Do not set property on anything
10028 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10029
e16e55d4
JB
100302011-05-02 Juanma Barranquero <lekktu@gmail.com>
10031
10032 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10033
bafcf6a5
JB
100342011-05-02 Juanma Barranquero <lekktu@gmail.com>
10035
10036 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10037 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10038 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10039 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10040 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10041 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10042 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10043 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10044 (Qgnutls_bootprop_callbacks_verify): Make static.
10045
e7a6747f
AS
100462011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10047
19ed11ba
AS
10048 * callproc.c: Indentation fixup.
10049
e7a6747f 10050 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10051 (wait_for_termination, interruptible_wait_for_termination):
10052 Move after wait_for_termination_1.
e7a6747f 10053
1ef14cb4
LMI
100542011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10055
10056 * sysdep.c (interruptible_wait_for_termination): New function
10057 which is like wait_for_termination, but allows keyboard
10058 interruptions.
10059
10060 * callproc.c (Fcall_process): Add (:file "file") as an option for
10061 the STDOUT buffer.
10062 (Fcall_process_region): Ditto.
10063
330d880c
EZ
100642011-04-30 Eli Zaretskii <eliz@gnu.org>
10065
8db90b73
EZ
10066 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10067 rather than `XVECTOR (FOO)->size'.
10068
330d880c
EZ
10069 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10070 inttypes.h, as a gnulib replacement is used if it not available in
10071 system headers.
10072
15cbd324
EZ
100732011-04-21 Eli Zaretskii <eliz@gnu.org>
10074
10075 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10076 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10077 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10078
10079 * coding.c (coding_alloc_by_realloc): Error out if destination
10080 will grow beyond MOST_POSITIVE_FIXNUM.
10081 (decode_coding_emacs_mule): Abort if there isn't enough place in
10082 charbuf for the composition carryover bytes. Reserve an extra
10083 space for up to 2 characters produced in a loop.
10084 (decode_coding_iso_2022): Abort if there isn't enough place in
10085 charbuf for the composition carryover bytes.
10086
100872011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10088
ae940cca
EZ
10089 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10090 aborting when %lld or %lll format is passed.
10091 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10092 %llo or %llx format is passed. (Bug#8545)
10093
03ab8921
EZ
10094 * window.c (window_scroll_line_based): Use a marker instead of
10095 simple variables to record original value of point. (Bug#7952)
10096
afda1437
EZ
10097 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10098 produced by %s or %c overflows available buffer space. (Bug#8545)
10099
f76dee0c
PE
101002011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10101
10102 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10103 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10104
fdc5744d
JB
101052011-04-28 Juanma Barranquero <lekktu@gmail.com>
10106
10107 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10108
638f053a
JB
101092011-04-28 Juanma Barranquero <lekktu@gmail.com>
10110
10111 * keyboard.c (Qdelayed_warnings_hook): Define.
10112 (command_loop_1): Run `delayed-warnings-hook'
10113 if Vdelayed_warnings_list is non-nil.
10114 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10115 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10116
d178f871
EZ
101172011-04-28 Eli Zaretskii <eliz@gnu.org>
10118
10119 * doprnt.c (doprnt): Don't return value smaller than the buffer
10120 size if the message was truncated. (Bug#8545).
10121
b124fd93
JB
101222011-04-28 Juanma Barranquero <lekktu@gmail.com>
10123
10124 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10125 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10126
e810457d
PE
101272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10128
10129 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10130
ea51cceb
JB
101312011-04-27 Juanma Barranquero <lekktu@gmail.com>
10132
10133 * makefile.w32-in: Update dependencies.
10134
94dcfacf
EZ
101352011-04-27 Eli Zaretskii <eliz@gnu.org>
10136
10137 Improve `doprnt' and its usage. (Bug#8545)
10138 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10139 `format_end'. Remove support for %l as a conversion specifier.
10140 Don't use xrealloc. Improve diagnostics when the %l size modifier
10141 is used. Update the commentary.
10142
10143 * eval.c (verror): Simplify calculation of size_t.
10144
10145 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10146 messages.
10147
f61f41d7
PE
101482011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10149
10150 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10151 change.
10152
96fb4434
PE
101532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10154
10155 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10156 This makes this file independent of the recent pseudovector change.
10157
671875da 101582011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10159
69e9b5a3
PE
10160 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10161
b5f869a7 10162 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10163 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10164 Remove unused local.
c8926152 10165 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10166
841a1577 10167 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10168 GCC 4.6.0 optimizes based on type-based alias analysis.
10169 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10170 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10171 != &v->size, and therefore "v->size = 1; b->size = 2; return
10172 v->size;" must therefore return 1. This assumption is incorrect
10173 for Emacs, since it type-puns struct Lisp_Vector * with many other
10174 types. To fix this problem, this patch adds a new type struct
f904488f 10175 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10176 and pseudovectors, and helps optimizing compilers not get fooled
10177 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10178 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10179 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10180 the size member.
eab3844f
PE
10181 (XSETPVECTYPE): Rewrite in terms of new macro.
10182 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10183 This is a bit clearer, and further avoids the possibility of
10184 undesirable aliasing.
10185 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10186 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10187 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10188 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10189 (ASIZE): Now uses header.size rather than size.
10190 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10191 to avoid the hassle of writing XVECTOR (foo)->header.size.
10192 (struct vectorlike_header): New type.
eab3844f
PE
10193 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10194 object, to help avoid aliasing.
10195 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10196 (SUBRP): Likewise, since Lisp_Subr is a special case.
10197 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10198 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10199 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10200 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10201 changed to be "header.size" and "header.next".
10202 * buffer.h (struct buffer): Likewise.
10203 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10204 * frame.h (struct frame): Likewise.
10205 * process.h (struct Lisp_Process): Likewise.
10206 * termhooks.h (struct terminal): Likewise.
10207 * window.c (struct save_window_data, struct saved_window): Likewise.
10208 * window.h (struct window): Likewise.
10209 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10210 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10211 * buffer.c (init_buffer_once): Likewise.
10212 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10213 special case.
10214 * process.c (Fformat_network_address): Use local var for size,
10215 for brevity.
10216
0df1eac5
PE
10217 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10218
847ab9d1 10219 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10220 * data.c (atof): Remove decl; no longer used or needed.
10221 (digit_to_number): Move to lread.c.
10222 (Fstring_to_number): Use new string_to_number function, to be
10223 consistent with how the Lisp reader treats infinities and NaNs.
10224 Do not assume that floating-point numbers represent EMACS_INT
10225 without losing information; this is not true on most 64-bit hosts.
10226 Avoid double-rounding errors, by insisting on integers when
10227 parsing non-base-10 numbers, as the documentation specifies.
10228 * lisp.h (string_to_number): New decl, replacing ...
10229 (isfloat_string): Remove.
bc0a5c13 10230 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10231 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10232 appears to have been a coding error. Similarly, do not accept
10233 strings like +-1e0 as floating point numbers. Do not report
10234 overflow for integer overflows unless the base is not 10 which
10235 means we have no simple and reliable way to continue.
10236 Break out the floating-point parsing into a new
10237 function string_to_number, so that Fstring_to_number parses
10238 floating point numbers consistently with the Lisp reader.
04f2d78b 10239 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10240 (E_CHAR, EXP_INT): Remove, replacing with ...
10241 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10242 (string_to_number): New function, replacing isfloat_string.
10243 This function checks for valid syntax and produces the resulting
10244 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10245 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10246 so that overflow for non-base-10 numbers is reported only when
10247 there's no portable and simple way to convert to floating point.
452f4150 10248
67769ffc
PE
10249 * textprop.c (set_text_properties_1): Rewrite for clarity,
10250 and to avoid GCC warning about integer overflow.
10251
c20db43f
PE
10252 * intervals.h (struct interval): Use EMACS_INT for members
10253 where EMACS_UINT might cause problems. See
10254 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10255 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10256 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10257 All uses changed.
37aa2f85
PE
10258 (offset_intervals): Tell GCC not to worry about length overflow
10259 when negating a negative length.
c20db43f 10260
2538aa2f
PE
10261 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10262 (overrun_check_free): Likewise.
10263
f2d3008d
PE
10264 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10265 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10266 word size.
10267
ec8df744
PE
10268 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10269 (gnutls_make_error): Rename local to avoid shadowing.
10270 (gnutls_emacs_global_deinit): ifdef out; not used.
10271 (Fgnutls_boot): Use const for pointer to readonly storage.
10272 Comment out unused local. Fix pointer signedness problems.
10273
640ee02d
PE
10274 * lread.c (openp): Don't stuff size_t into an 'int'.
10275 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10276 about possible signed overflow.
10277
6048fb2a
PE
10278 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10279 (GDK_KEY_g): Don't define if already defined.
10280 (xg_prepare_tooltip): Avoid pointer signedness problem.
10281 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10282
fa3c87e1
PE
10283 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10284 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10285
2172544b
PE
10286 * xfns.c (Fx_window_property): Simplify a bit,
10287 to make a bit faster and to avoid GCC 4.6.0 warning.
10288 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10289
9b821a21
PE
10290 * fns.c (internal_equal): Don't assume size_t fits in int.
10291
3c616cfa
PE
10292 * alloc.c (compact_small_strings): Tighten assertion a little.
10293
c2982e87
PE
10294 Replace pEd with more-general pI, and fix some printf arg casts.
10295 * lisp.h (pI): New macro, generalizing old pEd macro to other
10296 conversion specifiers. For example, use "...%"pI"d..." rather
10297 than "...%"pEd"...".
10298 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10299 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10300 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10301 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10302 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10303 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10304 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10305 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10306 64-bit hosts.
10307 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10308 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10309 * print.c (safe_debug_print, print_object): Likewise.
10310 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10311 to int.
6f04d126
PE
10312 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10313 avoiding the 0 flag, which is not portable.
c2982e87
PE
10314 * process.c (Fmake_network_process): Use pI to avoid cast.
10315 * region-cache.c (pp_cache): Likewise.
10316 * xdisp.c (decode_mode_spec): Likewise.
10317 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10318 behavior on 64-bit hosts with printf arg.
6f04d126 10319 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10320 (x_stop_queuing_selection_requests): Likewise.
10321 (x_get_window_property): Don't truncate byte count to an 'int'
10322 when tracing.
0b432f21 10323
5e073ec7
PE
10324 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10325 here, since it parses constructs like leading '-' and spaces,
10326 which are not wanted; and it overflows with large numbers.
10327 Instead, simply match F[0-9]+, which is what is wanted anyway.
10328
36372bf9
PE
10329 * alloc.c: Remove unportable assumptions about struct layout.
10330 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10331 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10332 (allocate_vectorlike, make_pure_vector): Use the new macros,
10333 plus offsetof, to remove unportable assumptions about struct layout.
10334 These assumptions hold on all porting targets that I know of, but
10335 they are not guaranteed, they're easy to remove, and removing them
10336 makes further changes easier.
10337
0b432f21
PE
10338 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10339 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10340 (string_overrun_cookie): Now const. Use initializers that
10341 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10342 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10343 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10344 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10345 multiple of sizeof (EMACS_INT); it need not be, if
10346 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10347 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10348
895009e1
JB
103492011-04-26 Juanma Barranquero <lekktu@gmail.com>
10350
10351 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10352
6a7a1b0b
TZ
103532011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10354
10355 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10356 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10357 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10358
841a1577 103592011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10360
10361 * lisp.h (Qdebug): List symbol.
895009e1 10362 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10363 * keyboard.c (debug-on-event): New variable.
10364 (handle_user_signal): Break into debugger when debug-on-event
10365 matches the current signal symbol.
10366
f2d3ba6f
DN
103672011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10368
10369 * alloc.c (check_sblock, check_string_bytes)
10370 (check_string_free_list): Convert to standard C.
10371
42ce4c63
TZ
103722011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10373
10374 * w32.c (emacs_gnutls_push): Fix typo.
10375
825cd63c
EZ
103762011-04-25 Eli Zaretskii <eliz@gnu.org>
10377
fb11d64d
EZ
10378 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10379 "cast to pointer from integer of different size".
10380
825cd63c
EZ
10381 Improve doprnt and its use in verror. (Bug#8545)
10382 * doprnt.c (doprnt): Document the set of format control sequences
10383 supported by the function. Use SAFE_ALLOCA instead of always
10384 using `alloca'.
10385
10386 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10387 is one byte too soon. Don't use xrealloc; instead xfree and
10388 xmalloc anew.
10389
e061a11b
TZ
103902011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10391
10392 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10393 callbacks stage.
10394
10395 * gnutls.c: Renamed global_initialized to
10396 gnutls_global_initialized. Added internals for the
10397 :verify-hostname-error, :verify-error, and :verify-flags
10398 parameters of `gnutls-boot' and documented those parameters in the
10399 docstring. Start callback support.
9173deec
JB
10400 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10401 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10402 on error. Return error code.
e061a11b
TZ
10403 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10404 (emacs_gnutls_read): Likewise.
10405 (Fgnutls_boot): Return handshake error code.
10406 (emacs_gnutls_handle_error): New function.
10407 (wsaerror_to_errno): Likewise.
10408
10409 * w32.h (emacs_gnutls_pull): Add prototype.
10410 (emacs_gnutls_push): Likewise.
10411
10412 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10413 (emacs_gnutls_push): Likewise.
10414
104152011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10416
10417 * process.c (wait_reading_process_output): Check if GnuTLS
10418 buffered some data internally if no FDs are set for TLS
10419 connections.
10420
10421 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10422 (LIBS): Link to USER_LIBS.
10423 ($(BLD)/gnutls.$(0)): New target.
10424
fa6996bc
EZ
104252011-04-24 Eli Zaretskii <eliz@gnu.org>
10426
eb35682e
EZ
10427 * xdisp.c (handle_single_display_spec): Rename the
10428 display_replaced_before_p argument into display_replaced_p, to
10429 make it consistent with the commentary. Fix typos in the
10430 commentary.
10431
e2ad650c
EZ
10432 * textprop.c (syms_of_textprop): Remove dead code.
10433 (copy_text_properties): Delete obsolete commentary about an
10434 interface that was deleted long ago. Fix typos in the description
10435 of arguments.
10436
1b2de274
EZ
10437 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10438 to changes in oldXMenu/XMenu.h from 2011-04-16.
10439 <menu_help_message, prev_menu_help_message>: Constify.
10440 (IT_menu_make_room): menu->help_text is now `const char **';
10441 adjust.
10442
10443 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10444 to changes in oldXMenu/XMenu.h from 2011-04-16.
10445 (struct XMenu): Declare `help_text' `const char **'.
10446
10447 * xfaces.c <Qunspecified>: Make extern again.
10448
10449 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10450 required by POSIX.
1b2de274 10451
762b15be
EZ
10452 * doc.c (get_doc_string): Improve the format passed to `error'.
10453
10454 * doprnt.c (doprnt): Improve commentary.
10455
10456 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10457
10458 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10459 them with etags.
10460
f1052e5d
EZ
10461 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10462 changes in globals.h immediately force recompilation.
762b15be
EZ
10463 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10464 $(CURDIR)/s/ms-w32.h.
10465 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10466
fa6996bc
EZ
10467 * character.c (Fchar_direction): Function deleted.
10468 (syms_of_character): Don't defsubr it.
10469 <char-direction-table>: Deleted.
10470
e6c3da20
EZ
104712011-04-23 Eli Zaretskii <eliz@gnu.org>
10472
10473 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10474 * doprnt.c: Include limits.h.
10475 (SIZE_MAX): New macro.
04f2d78b
CB
10476 (doprnt): Return a size_t value. 2nd arg is now size_t.
10477 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10478 Improve overflow protection. Support `l' modifier for integer
10479 conversions. Support %l conversion. Don't assume an EMACS_INT
10480 argument for integer conversions and for %c.
10481
10482 * lisp.h (doprnt): Restore prototype.
10483
10484 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10485 $(SRC)/character.h.
10486
10487 * Makefile.in (base_obj): Add back doprnt.o.
10488
10489 * deps.mk (doprnt.o): Add back prerequisites.
10490 (callint.o): Depend on character.h.
10491
10492 * eval.c (internal_lisp_condition_case): Include the handler
10493 representation in the error message.
10494 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10495 when breaking from the loop.
10496
10497 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10498
10499 * callint.c (Fcall_interactively): When displaying error message
10500 about invalid control letter, pass the character's codepoint, not
10501 a pointer to its multibyte form. Improve display of the character
10502 in octal and display also its hex code.
10503
10504 * character.c (char_string): Use %x to display the (unsigned)
10505 codepoint of an invalid character, to avoid displaying a bogus
10506 negative value.
10507
10508 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10509 `error', not SYMBOL_NAME itself.
10510
10511 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10512 character arguments to `error'.
10513
10514 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10515 to `error' in error message about FINAL_CHAR argument. Make sure
10516 FINAL_CHAR is a character, and use %c when it is passed as
10517 argument to `error'.
10518
4ffd0d6b 105192011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10520
10521 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10522
10523 * w32.c: Include <time.h>.
10524 (sys_localtime): New function.
10525
4ffd0d6b 105262011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10527
10528 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10529
4ffd0d6b 10530 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10531
4ffd0d6b 105322011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10533
4ffd0d6b
GM
10534 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10535 zombies (Bug#8467).
aac0c6e3 10536
04c56954
EZ
105372011-04-19 Eli Zaretskii <eliz@gnu.org>
10538
10539 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10540 gl_state.e_property when gl_state.object is Qt.
10541
10542 * insdel.c (make_gap_larger): Remove limitation of buffer size
10543 to <= INT_MAX.
10544
16a43933
CY
105452011-04-18 Chong Yidong <cyd@stupidchicken.com>
10546
10547 * xdisp.c (lookup_glyphless_char_display)
10548 (produce_glyphless_glyph): Handle cons cell entry in
10549 glyphless-char-display.
10550 (Vglyphless_char_display): Document it.
10551
10552 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10553 glyphless-char-display.
10554
4581706e
CY
105552011-04-17 Chong Yidong <cyd@stupidchicken.com>
10556
10557 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10558
10559 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10560
10561 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10562 definition for no-X builds.
10563
4887c6e2 105642011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10565
fd35b6f9
PE
10566 Static checks with GCC 4.6.0 and non-default toolkits.
10567
5c1ccb01
PE
10568 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10569
006c5daa
PE
10570 * process.c (keyboard_bit_set): Define only if SIGIO.
10571 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10572 (send_process): Repair possible setjmp clobbering.
10573
efc736d3
PE
10574 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10575
4e2fe2e6
PE
10576 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10577
f97334a2
PE
10578 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10579
4e75f29d
PE
10580 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10581 Define only if needed.
10582
90efadd1
PE
10583 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10584 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10585 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10586
3c647824
PE
10587 * dispextern.h (struct redisplay_interface): Rename param
10588 to avoid shadowing.
e264f262 10589 * termhooks.h (struct terminal): Likewise.
761383f4 10590 * xterm.c (xembed_send_message): Likewise.
3c647824 10591
b58c5c4a
PE
10592 * insdel.c (make_gap_smaller): Define only if
10593 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10594
cad59032
PE
10595 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10596 it.
10597
c339dc2e
PE
10598 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10599 so that we aren't warned about unused symbols.
10600
91a3e27b
PE
10601 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10602
399c71d3 10603 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10604
8ffc96f5
PE
10605 * xfns.c (x_real_positions): Mark locals as initialized.
10606
eef9bc79
PE
10607 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10608
098db9dd
PE
10609 * xterm.c: Fix problems found by static analysis with other toolkits.
10610 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10611 (x_dispatch_event): Declare static if USE_GTK, and
10612 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10613 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10614 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10615 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10616 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10617
eb18f6cc
PE
10618 * xmenu.c (menu_help_callback): Pointer type fixes.
10619 Use const pointers when pointing at readonly data. Avoid pointer
10620 signedness clashes.
10621 (FALSE): Remove unused macro.
10622 (update_frame_menubar): Remove unused decl.
10623
1fe72bf8
PE
10624 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10625
60d9e1db
PE
10626 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10627 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10628 (single_menu_item): Rename local to avoid shadowing.
10629
39261c26
PE
10630 * keyboard.c (make_lispy_event): Remove unused local var.
10631
018c5e19
PE
10632 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10633 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10634
63d2b86e
PE
10635 * bitmaps: Change bitmaps from unsigned char back to the X11
10636 compatible char. Avoid the old compiler warnings about
10637 out-of-range initializers by using, for example, '\xab' rather
10638 than 0xab.
10639
aefd87e1
PE
10640 * xgselect.c (xgselect_initialize): Check vs interface
10641 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10642
bf501fb9
PE
10643 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10644
e9829fdf
PE
10645 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10646 to read-only memory.
10647
1086c095
PE
10648 * fns.c (vector): Remove; this old hack is no longer needed.
10649
2baccd04 10650 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10651 Remove unused var.
dde42981 10652 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10653
72391843 10654 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10655
436c16df 10656 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10657 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10658 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10659
92bb796d 10660 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10661 (x_term_init): Remove local to avoid shadowing.
92bb796d 10662
764430a3 10663 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10664
10665 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10666 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10667
d1dfb56c
EZ
106682011-04-16 Eli Zaretskii <eliz@gnu.org>
10669
c4354cb4
EZ
10670 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10671
d1dfb56c
EZ
10672 Fix regex.c, syntax.c and friends for buffers > 2GB.
10673 * syntax.h (struct gl_state_s): Declare character position members
10674 EMACS_INT.
10675
10676 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10677
04f2d78b
CB
10678 * textprop.c (verify_interval_modification, interval_of):
10679 Declare arguments EMACS_INT.
d1dfb56c
EZ
10680
10681 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10682 EMACS_INT.
10683
10684 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10685
10686 * indent.c (Fvertical_motion): Local variable it_start is now
10687 EMACS_INT.
10688
10689 * regex.c (re_match, re_match_2, re_match_2_internal)
10690 (bcmp_translate, regcomp, regexec, print_double_string)
10691 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10692 (re_compile_pattern, re_exec): Declare arguments and local
10693 variables `size_t' and `ssize_t' and return values `regoff_t', as
10694 appropriate.
10695 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10696 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10697 <compile_stack_type>: `size' and `avail' are now `size_t'.
10698
10699 * regex.h <regoff_t>: Use ssize_t, not int.
10700 (re_search, re_search_2, re_match, re_match_2): Arguments that
10701 specify buffer/string position and length are now ssize_t and
10702 size_t. Return type is regoff_t.
10703
613052cd
BK
107042011-04-16 Ben Key <bkey76@gmail.com>
10705
10706 * nsfont.m: Fixed bugs in ns_get_family and
10707 ns_descriptor_to_entity that were caused by using free to
10708 deallocate memory blocks that were allocated by xmalloc (via
10709 xstrdup). This caused Emacs to crash when compiled with
10710 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10711 --enable-checking=xmallocoverrun). xfree is now used to
10712 deallocate these memory blocks.
10713
4170f62f 107142011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10715
71b41406
PE
10716 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10717
9587a89d
PE
10718 emacs_write: Accept and return EMACS_INT for sizes.
10719 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10720 et seq.
10721 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10722 Accept and return EMACS_INT.
10723 (emacs_gnutls_write): Return the number of bytes written on
10724 partial writes.
10725 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10726 (emacs_read, emacs_write): Remove check for negative size, as the
10727 Emacs source code has been audited now.
9587a89d
PE
10728 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10729 (emacs_read, emacs_write): Use it.
273a5f82
PE
10730 * process.c (send_process): Adjust to the new signatures of
10731 emacs_write and emacs_gnutls_write. Do not attempt to store
10732 a byte offset into an 'int'; it might overflow.
9587a89d 10733 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10734
3e047f51
PE
10735 * sound.c: Don't assume sizes fit in 'int'.
10736 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10737 Return EMACS_INT, not int.
3e047f51 10738 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10739 Accept EMACS_INT, not int.
10740 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10741 record read return values.
10742
cc39a9db
BK
107432011-04-15 Ben Key <bkey76@gmail.com>
10744
c9d0ec6d
JB
10745 * keyboard.c (Qundefined): Don't declare static since it is used
10746 in nsfns.m.
10747 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10748 static since they are used in nsfont.m.
cc39a9db 10749
6c60eb9f
SM
107502011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10751
10752 * process.c (Qprocessp): Don't declare static.
10753 * lisp.h (Qprocessp): Declare again.
10754
7990b61a
JB
107552011-04-15 Juanma Barranquero <lekktu@gmail.com>
10756
10757 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10758
5d4cb038
PE
107592011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10760
8bd7b830 10761 Improve C-level modularity by making more things 'static'.
cd64ea1d 10762
e3b27b31
PE
10763 Don't publish debugger-only interfaces to other modules.
10764 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10765 (verify_bytepos, count_markers): Move decls to the only modules
10766 that need them.
10767 * region-cache.h (pp_cache): Likewise.
10768 * window.h (check_all_windows): Likewise.
10769 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10770
5d4cb038
PE
10771 * sysdep.c (croak): Now static, if
10772 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10773 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10774
10775 * alloc.c (refill_memory_reserve): Now static if
10776 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10777 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10778
e87b6180
PE
10779 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10780 Define only if USE_LUCID.
10781
ac64929e
PE
10782 * xrdb.c (x_customization_string, x_rm_string): Now static.
10783
6f37259d
PE
10784 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10785 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10786
1683e3ab
PE
10787 * xdisp.c (draw_row_with_mouse_face): Now static.
10788 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10789
de9c2632
PE
10790 * window.h (check_all_windows): Mark externally visible.
10791
2b96acb7
PE
10792 * window.c (window_deletion_count): Now static.
10793
10794 * undo.c: Make symbols static if they're not exported.
10795 (last_undo_buffer, last_boundary_position, pending_boundary):
10796 Now static.
10797
50436f33
PE
10798 * textprop.c (interval_insert_behind_hooks): Now static.
10799 (interval_insert_in_front_hooks): Likewise.
10800
64520e5c
PE
10801 * term.c: Make symbols static if they're not exported.
10802 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10803 (max_frame_lines, tty_set_terminal_modes):
10804 (tty_reset_terminal_modes, tty_turn_off_highlight):
10805 (get_tty_terminal): Now static.
10806 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10807 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10808 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10809 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10810 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10811
1fa53021
PE
10812 * sysdep.c: Make symbols static if they're not exported.
10813 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10814 Now static.
10815 (sigprocmask_set, full_mask): Remove; unused.
10816 (wait_debugging): Mark as visible.
10817 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10818 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10819
d4b43b22
PE
10820 * syntax.c (syntax_temp): Define only if !__GNUC__.
10821
b7c513d0
PE
10822 * sound.c (current_sound_device, current_sound): Now static.
10823
989b29ad
PE
10824 * search.c (searchbufs, searchbuf_head): Now static.
10825
13a55a78
PE
10826 * scroll.c (scroll_cost): Remove; unused.
10827 * dispextern.h (scroll_cost): Remove decl.
10828
de68a1fc
PE
10829 * region-cache.h (pp_cache): Mark as externally visible.
10830
40ccffa6
PE
10831 * process.c: Make symbols static if they're not exported.
10832 (process_tick, update_tick, create_process, chan_process):
10833 (Vprocess_alist, proc_buffered_char, datagram_access):
10834 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10835 (deactivate_process): Mark defn as static, as well as decl.
10836 * lisp.h (create_process): Remove decl.
10837 * process.h (chan_process, Vprocess_alist): Remove decls.
10838
ad64fc97
PE
10839 * print.c: Make symbols static if they're not exported.
10840 (print_depth, new_backquote_output, being_printed, print_buffer):
10841 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10842 (print_interval, print_number_index, initial_stderr_stream):
10843 Now static.
10844 * lisp.h (Fprinc): Remove decl.
10845 (debug_output_compilation_hack): Mark as externally visible.
10846
adddb265
PE
10847 * sysdep.c (croak): Move decl from here to syssignal.h.
10848 * syssignal.h (croak): Put it here, so the API can be checked when
10849 'croak' is called from dissociate_if_controlling_tty.
10850
1717ede2
PE
10851 * minibuf.c: Make symbols static if they're not exported.
10852 (minibuf_save_list, choose_minibuf_frame): Now static.
10853 * lisp.h (choose_minibuf_frame): Remove decl.
10854
fa5fb2bc
PE
10855 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10856
1e3890d1
PE
10857 * lread.c: Make symbols static if they're not exported.
10858 (read_objects, initial_obarray, oblookup_last_bucket_number):
10859 Now static.
10860 (make_symbol): Remove; unused.
10861 * lisp.h (initial_obarray, make_symbol): Remove decls.
10862
8a1414fa
PE
10863 * keyboard.c: Make symbols static if they're not exported.
10864 (single_kboard, recent_keys_index, total_keys, recent_keys):
10865 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10866 (this_single_command_key_start, echoing, last_auto_save):
10867 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10868 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10869 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10870 (Vlispy_mouse_stem, double_click_count):
10871 Now static.
10872 (force_auto_save_soon): Define only if SIGDANGER.
10873 (ignore_mouse_drag_p): Now static if
10874 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10875 (print_help): Remove; unused.
10876 (stop_character, last_timer_event): Mark as externally visible.
10877 * keyboard.h (ignore_mouse_drag_p): Declare only if
10878 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10879 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10880 * lisp.h (echoing): Remove decl.
10881 (force_auto_save_soon): Declare only if SIGDANGER.
10882 * xdisp.c (redisplay_window): Simplify code, to make it more
10883 obvious that ignore_mouse_drag_p is not accessed if !defined
10884 USE_GTK && !defined HAVE_NS.
10885
93ea6e8f
PE
10886 * intervals.c: Make symbols static if they're not exported.
10887 (merge_properties_sticky, merge_interval_right, delete_interval):
10888 Now static.
10889 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10890
77382fcc
PE
10891 * insdel.c: Make symbols static if they're not exported.
10892 However, leave prepare_to_modify_buffer alone. It's never
10893 called from outside this function, but that appears to be a bug.
10894 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10895 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10896 (adjust_after_replace_noundo): Remove; unused.
10897 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10898 (signal_before_change): Remove decls.
77382fcc 10899
9306c32e
PE
10900 * indent.c (val_compute_motion, val_vmotion): Now static.
10901
cd44d2eb
PE
10902 * image.c: Make symbols static if they're not exported.
10903 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10904 if USE_GTK.
10905 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10906 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10907
ad9a7a06
PE
10908 * fringe.c (standard_bitmaps): Now static.
10909 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10910
81626931
PE
10911 * frame.c: Make symbols static if they're not exported.
10912 (x_report_frame_params, make_terminal_frame): Now static.
10913 (get_frame_param): Now static, unless HAVE_NS.
10914 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10915 (x_get_resource_string): Remove; not used.
10916 * frame.h (make_terminal_frame, x_report_frame_params):
10917 (x_get_resource_string); Remove decls.
10918 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10919 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10920
239f9db9
PE
10921 * font.c, fontset.c: Make symbols static if they're not exported.
10922 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10923 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10924 * font.c (font_close_object): Now static.
10925 * font.h (font_close_object): Remove.
10926 * fontset.c (FONTSET_OBJLIST): Remove.
10927 (free_realized_fontset) #if-0 the body, which does nothing.
10928 (face_suitable_for_char_p): #if-0, as it's never called.
10929 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10930 * xfaces.c (face_at_string_position):
10931 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10932 since 0 is always ASCII.
10933
dfcf3579
PE
10934 * fns.c (weak_hash_tables): Now static.
10935
5045092b
PE
10936 * fileio.c: Make symbols static if they're not exported.
10937 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10938 (Vwrite_region_annotation_buffers): Now static.
10939
57a96f5c
PE
10940 * eval.c: Make symbols static if they're not exported.
10941 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10942 * lisp.h (backtrace_list): Remove decl.
10943
35f08c38
PE
10944 * emacs.c: Make symbols static if they're not exported.
10945 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10946 (fatal_error_code, fatal_error_signal_hook, standard_args):
10947 Now static.
10948 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10949 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10950 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10951 * lisp.h (fatal_error_signal_hook): Remove decl.
10952 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10953
f44bd759
PE
10954 * editfns.c: Move a (normally-unused) function to its only use.
10955 * editfns.c, lisp.h (get_operating_system_release): Remove.
10956 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10957 worth the hassle of breaking this out.
10958
b532497d
PE
10959 * xterm.c: Make symbols static if they're not exported.
10960 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10961 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10962 (x_destroy_window, x_delete_display):
10963 Now static.
10964 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10965 (x_mouse_leave): Remove; unused.
10966 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10967 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10968 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10969 Remove decls.
10970 (x_mouse_leave): Declare only if WINDOWSNT.
10971 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10972 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10973 USE_X_TOOLKIT.
10974
1675728f
PE
10975 * ftxfont.c: Make symbols static if they're not exported.
10976 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10977 HAVE_FREETYPE.
10978 * font.h (ftxfont_driver): Likewise.
10979
e4cebfca
PE
10980 * xfns.c: Make symbols static if they're not exported.
10981 (x_last_font_name, x_display_info_for_name):
10982 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10983 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10984 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10985 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10986 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10987 (last_show_tip_args): Now static.
10988 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10989 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10990 (x_screen_planes): Remove; unused.
10991 * dispextern.h (x_screen_planes): Remove decl.
10992
5bf46f05
PE
10993 * dispnew.c: Make symbols static if they're not exported.
10994 * dispextern.h (redraw_garbaged_frames, scrolling):
10995 (increment_row_positions): Remove.
10996 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10997 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10998 Now static.
10999 (redraw_garbaged_frames): Remove; unused.
11000
435f4c28
PE
11001 * xfaces.c: Make symbols static if they're not exported.
11002 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11003 Remove decls.
11004 * xterm.h (defined_color): Remove decls.
11005 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11006 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11007 (menu_face_changed_default, defined_color, free_realized_face):
11008 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11009 (ascii_face_of_lisp_face): Remove; unused.
11010
8524aef3
PE
11011 * xdisp.c: Make symbols static if they're not exported.
11012 * dispextern.h (scratch_glyph_row, window_box_edges):
11013 (glyph_to_pixel_coords, set_cursor_from_row):
11014 (get_next_display_element, set_iterator_to_next):
11015 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11016 (show_mouse_face): Remove decls
11017 * frame.h (message_buf_print): Likewise.
11018 * lisp.h (pop_message, set_message, check_point_in_composition):
11019 Likewise.
11020 * xterm.h (set_vertical_scroll_bar): Likewise.
11021 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11022 (message_buf_print, scratch_glyph_row, displayed_buffer):
11023 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11024 (get_next_display_element, show_mouse_face, window_box_edges):
11025 (frame_to_window_pixel_xy, check_point_in_composition):
11026 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11027 (glyph_to_pixel_coords): Remove; unused.
11028
16390cd2
PE
11029 * dired.c (file_name_completion): Now static.
11030
11031 * dbusbind.c (xd_in_read_queued_messages): Now static.
11032
a25f4dfa
PE
11033 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11034 * data.c (circular_list_error): Remove.
11035
14a9c8df
PE
11036 * commands.h (last_point_position, last_point_position_buffer):
11037 (last_point_position_window): Remove decls.
11038 * keyboard.c: Make these variables static.
11039
04f2d78b
CB
11040 * coding.h (coding, code_convert_region, encode_coding_gap):
11041 Remove decls.
74ab6df5
PE
11042 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11043 (iso_code_class, detect_coding, code_convert_region): Now static.
11044 (encode_coding_gap): Remove; unused.
11045
38dfbee1
PE
11046 * chartab.c (chartab_chars, chartab_bits): Now static.
11047
a2cb4e63
PE
11048 * charset.h (charset_iso_8859_1): Remove decl.
11049 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11050 Now static.
11051
127198fd
PE
11052 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11053 * ccl.c (Vccl_program_table): Now static.
11054 (check_ccl_update): Remove; unused.
11055
d85b608f
PE
11056 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11057 * category.h: ... from here.
11058 * category.c (check_category_table, set_category_set): Now static.
11059
31cd66f3
PE
11060 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11061 * lisp.h: Remove these decls.
11062
c358e587
PE
11063 * buffer.c (buffer_count): Remove unused var.
11064
e78aecca
PE
11065 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11066 so that it's not optimized away.
11067 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11068 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11069 exported only to the debugger.
11070
e192d7d3 11071 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11072 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11073
92470028
PE
11074 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11075 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11076 was inaccessible from Lisp.
11077 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11078 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11079
244ed907
PE
11080 alloc.c: Import and export fewer symbols, and remove unused items.
11081 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11082 is defined.
11083 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11084 it's not optimized away by whole-program optimization.
11085 (message_enable_multibyte, free_misc): Remove.
11086 (catchlist, handlerlist, mark_backtrace):
11087 Declare only if BYTE_MARK_STACK.
11088 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11089 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11090 (message_enable_multibyte): Remove decl.
11091 (free_misc, interval_free_list, float_block, float_block_index):
11092 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11093 (cons_free_list, last_marked_index):
11094 Now static.
11095 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11096 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11097 (mark_backtrace): Define only if BYTE_MARK_STACK.
11098 * xdisp.c (message_enable_multibyte): Now static.
11099
61c2b50e 11100 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11101 This makes it easier for human readers (and static analyzers)
11102 to see whether these variables are used from other modules.
11103 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11104 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11105 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11106 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11107 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11108 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11109 * xmenu.c, xselect.c:
11110 Declare Q* vars static if they are not used in other modules.
11111 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11112 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11113 Remove decls of unexported vars.
11114 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11115
95c82688
PE
11116 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11117
16a97296
PE
11118 Make Emacs functions such as Fatom 'static' by default.
11119 This makes it easier for human readers (and static analyzers)
11120 to see whether these functions can be called from other modules.
11121 DEFUN now defines a static function. To make the function external
11122 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11123 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11124 (Finit_image_library):
16a97296
PE
11125 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11126 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11127 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11128 Remove decls, since these functions are now static.
11129 (Funintern, Fget_internal_run_time): New decls, since these functions
11130 were already external.
95c82688 11131
16a97296
PE
11132 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11133 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11134 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11135 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11136 * keyboard.c, keymap.c, lread.c:
11137 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11138 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11139 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11140 Mark functions with DEFUE instead of DEFUN,
11141 if they are used in other modules.
11142 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11143 decls for now-static functions.
11144 * buffer.h (Fdelete_overlay): Remove decl.
11145 * callproc.c (Fgetenv_internal): Mark as internal.
11146 * composite.c (Fremove_list_of_text_properties): Remove decl.
11147 (Fcomposition_get_gstring): New forward static decl.
11148 * composite.h (Fcomposite_get_gstring): Remove decl.
11149 * dired.c (Ffile_attributes): New forward static decl.
11150 * doc.c (Fdocumntation_property): New forward static decl.
11151 * eval.c (Ffetch_bytecode): New forward static decl.
11152 (Funintern): Remove extern decl; now in .h file where it belongs.
11153 * fileio.c (Fmake_symbolic_link): New forward static decl.
11154 * image.c (Finit_image_library): New forward static decl.
11155 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11156 * intervals.h (Fprevious_property_change):
11157 (Fremove_list_of_text_properties): Remove decls.
11158 * keyboard.c (Fthis_command_keys): Remove decl.
11159 (Fcommand_execute): New forward static decl.
11160 * keymap.c (Flookup_key): New forward static decl.
11161 (Fcopy_keymap): Now static.
11162 * keymap.h (Flookup_key): Remove decl.
11163 * process.c (Fget_process): New forward static decl.
11164 (Fprocess_datagram_address): Mark as internal.
11165 * syntax.c (Fsyntax_table_p): New forward static decl.
11166 (skip_chars): Remove duplicate decl.
11167 * textprop.c (Fprevious_property_change): New forward static decl.
11168 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11169 Now internal.
11170 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11171 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11172
785bbd42
PE
11173 * editfns.c (Fformat): Remove unreachable code.
11174
8b913b57
AS
111752011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11176
11177 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11178 change. (Bug#8496)
11179
a6744a35
EZ
111802011-04-13 Eli Zaretskii <eliz@gnu.org>
11181
11182 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11183 when at ZV. (Bug#8487)
11184
e7974947
AS
111852011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11186
baad03f0
AS
11187 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11188 (Bug#8437)
11189 * keyboard.c (parse_tool_bar_item): Likewise.
11190 * sound.c (sound_cleanup, alsa_close): Likewise.
11191 * termcap.c (tgetent): Likewise.
11192 * xfns.c (x_default_font_parameter): Likewise.
11193 * xsettings.c (read_and_apply_settings): Likewise.
11194
e7974947
AS
11195 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11196 (overrun_check_free): Protoize.
11197
28272684
PE
111982011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11199
11200 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11201 since callers should never pass a negative size.
11202 Change the signature to match that of plain 'read' and 'write'; see
11203 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11204 * lisp.h: Update prototypes of emacs_write and emacs_read.
11205
11997c76
EZ
112062011-04-11 Eli Zaretskii <eliz@gnu.org>
11207
11208 * xdisp.c (redisplay_window): Don't try to determine the character
11209 position of the scroll margin if the window start point w->startp
e896f03c 11210 is outside the buffer's accessible region. (Bug#8468)
11997c76 11211
8a2cbd72
EZ
112122011-04-10 Eli Zaretskii <eliz@gnu.org>
11213
11214 Fix write-region and its subroutines for buffers > 2GB.
11215 * fileio.c (a_write, e_write): Modify declaration of arguments and
11216 local variables to support buffers larger than 2GB.
11217 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11218
11219 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11220 argument, local variables, and return value.
11221
11222 * lisp.h: Update prototypes of emacs_write and emacs_read.
11223
11224 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11225
4073e537 112262011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11227
1ebfdcb6
PE
11228 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11229
b2ded58d
PE
11230 Fix more problems found by GCC 4.6.0's static checks.
11231
7d66342c
PE
11232 * xdisp.c (vmessage): Use a better test for character truncation.
11233
bbf47d44
PE
11234 * charset.c (load_charset_map): <, not <=, for optimization,
11235 and to avoid potential problems with integer overflow.
9248994d 11236 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11237 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11238 * editfns.c (Fformat): Likewise.
1e69125e 11239 * syntax.c (skip_chars): Likewise.
3befa583 11240
e3019616
PE
11241 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11242 This also lets GCC 4.6.0 generate slightly better loop code.
11243
becfa255
PE
11244 * callint.c (Fcall_interactively): <, not <=, for optimization.
11245 (Fcall_interactively): Count the number of arguments produced,
11246 not the number of arguments given. This is simpler and lets GCC
11247 4.6.0 generate slightly better code.
11248
dae0cd48
PE
11249 * ftfont.c: Distingish more carefully between FcChar8 and char.
11250 The previous code passed unsigned char * to a functions like
11251 strlen and xstrcasecmp that expect char *, which does not
11252 conform to the C standard.
11253 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11254 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11255 char * when the C standard requires it.
11256
76032d70
PE
11257 * keyboard.c (read_char): Remove unused var.
11258
eb3f1cc8
PE
11259 * eval.c: Port to Windows vsnprintf (Bug#8435).
11260 Include <limits.h>.
11261 (SIZE_MAX): Define if the headers do not.
11262 (verror): Do not give up if vsnprintf returns a negative count.
11263 Instead, grow the buffer. This ports to Windows vsnprintf, which
11264 does not conform to C99. Problem reported by Eli Zaretskii.
11265 Also, simplify the allocation scheme, by avoiding the need for
11266 calling realloc, and removing the ALLOCATED variable.
11267
70476b54
PE
11268 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11269
12020a9e
PE
11270 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11271 But keep the doprint source code for now, as we might revamp it
11272 and use it again (Bug#8435).
ea6c7ae6
PE
11273 * lisp.h (doprnt): Remove.
11274 * Makefile.in (base_obj): Remove doprnt.o.
11275 * deps.mk (doprnt.o): Remove.
11276
5fdb398c
PE
11277 error: Print 32- and 64-bit integers portably (Bug#8435).
11278 Without this change, on typical 64-bit hosts error ("...%d...", N)
11279 was used to print both 32- and 64-bit integers N, which relied on
11280 undefined behavior.
61bdb816 11281 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11282 * lisp.h (error, verror): Mark as printf-like functions.
11283 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11284 Report overflow in size calculations when allocating printf buffer.
11285 Do not truncate output string at its first null byte.
11286 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11287 Truncate the output at a character boundary, since vsnprintf does not
11288 do that.
11289 * charset.c (check_iso_charset_parameter): Convert internal
11290 character to string before calling 'error', since %c now has the
11291 printf meaning.
11292 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11293 overflow when computing char to be passed to 'error'. Do not
11294 pass Lisp_Object to 'error'; pass the integer instead.
11295 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11296 formatted with plain %d.
11297
b189fa66
PE
11298 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11299
bff87ef0
PE
11300 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11301
7e2cac20
PE
11302 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11303
ce4d90b5
PE
11304 * xterm.c (x_catch_errors): Remove duplicate declaration.
11305
266c9547
PE
11306 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11307
79c49ad2
PE
11308 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11309
368f4090
JM
113102011-04-10 Jim Meyering <meyering@redhat.com>
11311
11312 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11313 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11314 return ssize_t not "int", and use size_t as the buffer length.
11315 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11316 * gnutls.h: Update declarations.
11317 * process.c (read_process_output): Use ssize_t, to match.
11318 (send_process): Likewise.
11319
a32d4040
CY
113202011-04-09 Chong Yidong <cyd@stupidchicken.com>
11321
11322 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11323
8546720e 113242011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11325
04f2d78b
CB
11326 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11327 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11328
8546720e
GM
11329 * xterm.c (handle_one_xevent):
11330 * xmenu.c (create_and_show_popup_menu):
11331 * xselect.c (x_decline_selection_request)
11332 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11333
0a2f5c1a 113342011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11335
11336 Fix some uses of `int' instead of EMACS_INT.
11337 * search.c (string_match_1, fast_string_match)
11338 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11339 (scan_buffer, find_next_newline_no_quit)
11340 (find_before_next_newline, search_command, Freplace_match)
11341 (Fmatch_data): Make some `int' variables be EMACS_INT.
11342
11343 * xdisp.c (display_count_lines): 3rd argument and return value now
11344 EMACS_INT. All callers changed.
11345 (pint2hrstr): Last argument is now EMACS_INT.
11346
11347 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11348 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11349 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11350 (decode_coding_utf_16, decode_coding_emacs_mule)
11351 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11352 (decode_coding_ccl, decode_coding_charset)
11353 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11354 (decode_coding_iso_2022, decode_coding_emacs_mule)
11355 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11356 <char_offset, last_offset>: Declare EMACS_INT.
11357 (encode_coding_utf_8, encode_coding_utf_16)
11358 (encode_coding_emacs_mule, encode_invocation_designation)
11359 (encode_designation_at_bol, encode_coding_iso_2022)
11360 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11361 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11362 Declare EMACS_INT.
11363 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11364 (encode_invocation_designation): Last argument P_NCHARS is now
11365 EMACS_INT.
11366 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11367 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11368
11369 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11370 All users changed.
11371
11372 * ccl.c (Fccl_execute_on_string): Declare some variables
11373 EMACS_INT.
11374
8546720e 113752011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11376
11377 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11378
4e19a977
CS
113792011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11380
11381 * process.c (Fformat_network_address): Doc fix.
11382
87302331
R
113832011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11384
ee7683eb 11385 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11386
cbb59342
CY
113872011-04-08 Chong Yidong <cyd@stupidchicken.com>
11388
11389 * keyboard.c (read_char): Call Lisp function help-form-show,
11390 instead of using internal_with_output_to_temp_buffer.
11391 (Qhelp_form_show): New var.
e0d38eeb 11392 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11393
11394 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11395
11396 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11397
e67a13ab
CY
113982011-04-06 Chong Yidong <cyd@stupidchicken.com>
11399
04f2d78b
CB
11400 * process.c (Flist_processes): Remove to Lisp.
11401 (list_processes_1): Delete.
e67a13ab 11402
973f782d
EZ
114032011-04-06 Eli Zaretskii <eliz@gnu.org>
11404
7c106b1e
EZ
11405 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11406
973f782d
EZ
11407 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11408
41cf7d1a 114092011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11410
ca23cc88
PE
11411 Fix more problems found by GCC 4.6.0's static checks.
11412
f390e2d5
PE
11413 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11414
42eea0d0
PE
11415 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11416
b69769da 11417 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11418
f9541e84
PE
11419 * xdisp.c (vmessage): Mark as a printf-like function.
11420
13841b55
PE
11421 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11422
c136c10f
PE
11423 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11424
5e2d4a30
PE
11425 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11426 printf-like functions.
11427 (tiff_load): Add casts to remove these marks before passing them
11428 to system-supplied API.
11429
583f48b9
PE
11430 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11431
b25d760e
PE
11432 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11433 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11434 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11435 directly, rather than having caller test rule sign. This avoids
11436 some unnecessary tests.
11437 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11438 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11439 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11440
bc7b6697 11441 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11442 (xfont_open): Avoid unnecessary tests.
bc7b6697 11443
27ccc379
PE
11444 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11445
dcd5c89a
PE
11446 * composite.h, composite.c (composition_gstring_put_cache):
11447 Use EMACS_INT, not int, for length.
11448
b13a45c6
PE
11449 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11450 breaking out part of COMPOSITION_DECODE_RULE.
11451 (COMPOSITION_DECODE_RULE): Use it.
11452 * composite.c (get_composition_id): Remove unused local vars,
11453 by using the new macro.
11454
1e792e4d
PE
11455 * textprop.c (set_text_properties_1): Change while to do-while,
11456 since the condition is always true at first.
11457
dc6c6455 11458 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11459 (interval_deletion_adjustment): Return unsigned value.
11460 All uses changed.
dc6c6455 11461
aba7731a
PE
11462 * process.c (list_processes_1, create_pty, read_process_output):
11463 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11464 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11465 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11466 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11467 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11468
fdfc4bf3
PE
11469 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11470
fca8fe46 11471 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11472 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11473
06a0259a 11474 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11475 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11476 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11477
e7b9e80f
PE
11478 * print.c (print_error_message): Avoid int overflow.
11479
56201685
PE
11480 * font.c (font_list_entities): Redo for clarity,
11481 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11482
78834453 11483 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11484 (font_score): Avoid potential overflow in diff calculation.
78834453 11485
0bc0b309 11486 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11487 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11488
e610eaca
PE
11489 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11490
b895abce
PE
11491 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11492 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11493 can always succeed if overflow has undefined behavior.
11494
1f1d9321 11495 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11496 (wordify): Omit three unnecessary tests.
1f1d9321 11497
c59478bc
PE
11498 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11499 All callers changed. This avoids the need for an unused var.
11500
79b73827
PE
11501 * casefiddle.c (casify_region): Remove var that is set but not used.
11502
a4db5dfe
PE
11503 * dired.c (file_name_completion): Remove var that is set but not used.
11504
43aae36e
PE
11505 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11506
2a47c44d 11507 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11508 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11509
a37c69bf
PE
11510 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11511 Check for integer overflow on size calculations.
11512
328ab8e7
PE
11513 * buffer.c (Fprevious_overlay_change): Remove var that is set
11514 but not used.
11515
e5a2a5cb
PE
11516 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11517 Remove vars that are set but not used.
8d84a6eb 11518 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11519 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11520
a60e5f68
PE
11521 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11522
f661cb61 11523 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11524 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11525
f0397f5a
PE
11526 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11527 that are set but not used.
11528
8664db06 11529 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11530 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11531
6abdaa4a
PE
11532 * xselect.c (x_get_local_selection, x_handle_property_notify):
11533 Remove vars that are set but not used.
11534
0ce7538d 11535 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11536 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11537
9ae848fc
PE
11538 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11539 Remove var that is set but not used.
0b918413
PE
11540 (scroll_bar_windows_size): Now size_t, not int.
11541 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11542 Check for overflow.
9ae848fc 11543
a5a62657
PE
11544 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11545 (map_tty_color) [!defined MSDOS]: Likewise.
11546
5c5cdd39
PE
11547 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11548
66ebf983
PE
11549 * coding.c: Remove vars that are set but not used.
11550 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11551 All callers changed.
11552 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11553 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11554 (decode_coding_charset): Remove vars that are set but not used.
11555
1be4d761
PE
11556 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11557 that is set but not used.
11558
47553fa8
PE
11559 * print.c (print_object): Remove var that is set but not used.
11560
1f7196bf 11561 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11562 The gnulib version avoids calling malloc in the usual case,
11563 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11564 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11565 * filelock.c (current_lock_owner): Likewise.
11566 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11567 * sysdep.c: Include allocator.h, careadlinkat.h.
11568 (emacs_no_realloc_allocator): New static constant.
11569 (emacs_readlink): New function.
fdb61804
PE
11570 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11571 ../lib/careadlinkat.h.
d1fdcab7 11572
f84c17c7
SM
115732011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11574
11575 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11576 first non-nil return value).
11577
ef3862ad
JD
115782011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11579
11580 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11581 if not defined (Bug#8403).
11582
376a7006
JB
115832011-04-02 Juanma Barranquero <lekktu@gmail.com>
11584
11585 * xdisp.c (display_count_lines): Remove parameter `start',
11586 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11587 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11588 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11589 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11590 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11591 and thereabouts. All callers changed.
11592 (get_per_char_metric): Remove parameter `f', unused since
11593 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11594
6ca3801d
JM
115952011-04-02 Jim Meyering <meyering@redhat.com>
11596
11597 do not dereference NULL upon failed strdup
11598 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11599 (ns_get_family): Likewise.
11600
d8e2b5ba
JB
116012011-04-02 Juanma Barranquero <lekktu@gmail.com>
11602
11603 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11604
8c74fcbd
JD
116052011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11606
11607 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11608 later (Bug#8403).
11609
7200d79c
SM
116102011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11611
03408648 11612 Add lexical binding.
7200d79c 11613
03408648
SM
11614 * window.c (Ftemp_output_buffer_show): New fun.
11615 (Fsave_window_excursion):
11616 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11617
11618 * lread.c (lisp_file_lexically_bound_p): New function.
11619 (Fload): Bind Qlexical_binding.
11620 (readevalloop): Remove `evalfun' arg.
11621 Bind Qinternal_interpreter_environment.
11622 (Feval_buffer): Bind Qlexical_binding.
11623 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11624 Mark as dynamic.
11625 (syms_of_lread): Declare `lexical-binding'.
11626
11627 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11628
11629 * keyboard.c (eval_dyn): New fun.
11630 (menu_item_eval_property): Use it.
ca105506
SM
11631
11632 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11633
03408648
SM
11634 * fns.c (concat, mapcar1): Accept byte-code-functions.
11635
11636 * eval.c (Fsetq): Handle lexical vars.
11637 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11638 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11639 (FletX, Flet): Obey lexical binding.
11640 (Fcommandp): Handle closures.
11641 (Feval): New `lexical' arg.
11642 (eval_sub): New function extracted from Feval. Use it almost
11643 everywhere where Feval was used. Look up vars in lexical env.
11644 Handle closures.
11645 (Ffunctionp): Move from subr.el.
11646 (Ffuncall): Handle closures.
11647 (apply_lambda): Remove `eval_flags'.
11648 (funcall_lambda): Handle closures and new byte-code-functions.
11649 (Fspecial_variable_p): New function.
11650 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11651 but without exporting it to Lisp.
23aba0ea 11652
23aba0ea 11653 * doc.c (Fdocumentation, store_function_docstring):
03408648 11654 * data.c (Finteractive_form): Handle closures.
23aba0ea 11655
03408648
SM
11656 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11657 interactive spec.
ba83908c 11658
04f2d78b
CB
11659 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11660 New byte-codes.
03408648
SM
11661 (exec_byte_code): New function extracted from Fbyte_code to handle new
11662 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11663
03408648 11664 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11665
03408648 11666 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11667
e2abce01
JB
116682011-03-31 Juanma Barranquero <lekktu@gmail.com>
11669
11670 * xdisp.c (redisplay_internal): Fix prototype.
11671
63696a73 116722011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11673
63696a73 11674 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11675 (try_scrolling): Use it when setting scroll_limit.
11676 Limit scrolling to 100 screen lines.
63696a73
EZ
11677 (redisplay_window): Even when falling back on "recentering",
11678 position point in the window according to scroll-conservatively,
11679 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11680
11681 (try_scrolling): When point is above the window, allow searching
11682 as far as scroll_max, or one screenful, to compute vertical
11683 distance from PT to the scroll margin position. This prevents
11684 try_scrolling from unnecessarily failing when
11685 scroll-conservatively is set to a value slightly larger than the
11686 window height. Clean up the case of PT below the margin at bottom
11687 of window: scroll_max can no longer be INT_MAX. When aggressive
11688 scrolling is in use, don't let point enter the opposite scroll
11689 margin as result of the scroll.
11690 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11691 threshold of 100 lines for never-recentering scrolling.
11692
e4cc2dfc
JB
116932011-03-31 Juanma Barranquero <lekktu@gmail.com>
11694
11695 * dispextern.h (move_it_by_lines):
11696 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11697 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11698 (message_log_check_duplicate): Remove parameters `prev_bol' and
11699 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11700 (redisplay_internal): Remove parameter `preserve_echo_area',
11701 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11702
11703 * indent.c (Fvertical_motion):
11704 * window.c (window_scroll_pixel_based, Frecenter):
11705 Don't pass `need_y_p' to `move_it_by_lines'.
11706
1c470562
SM
117072011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11708
44f230aa
SM
11709 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11710 steal a few bits to be more compact.
11711 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11712 Remove unneeded casts.
11713
1c470562
SM
11714 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11715
888adce9
ZK
117162011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11717
11718 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11719 binding" message (bug#7967).
11720
f838ed7b
PE
117212011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11722
77861b95
PE
11723 Fix more problems found by GCC 4.6.0's static checks.
11724
de6dbc14
PE
11725 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11726 Remove unused local var.
11727
f838ed7b
PE
11728 * editfns.c (Fmessage_box): Remove unused local var.
11729
792c7b2b
PE
11730 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11731 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11732 Omit unused local vars.
c499e557 11733 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11734 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11735 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11736 Omit unused local var.
11737
ba0165e1
PE
11738 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11739 Don't assume string length fits in int.
32ad8845 11740 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11741 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11742
3c59b4c9
PE
11743 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11744 instead of alloca (Bug#8344).
11745
a3eed478 11746 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11747 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11748
eb4d412d
PE
11749 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11750
1658b401
PE
11751 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11752 concerns.
11753
11754 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11755
11756 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11757
9a2c6e05
PE
11758 * keyboard.c (syms_of_keyboard): Use the same style as later
11759 in this function when indexing through an array. This also
11760 works around GCC bug 48267.
11761
03d0a109
PE
11762 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11763
44f730c8
PE
11764 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11765
fe75f926
PE
11766 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11767 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11768
ffa8c828
PE
11769 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11770 This avoids undefined behavior on integer overflow, and is a bit
11771 more convenient anyway since it is compared to a size_t variable.
11772
c5101a77
PE
11773 Variadic C functions now count arguments with size_t, not int.
11774 This avoids an unnecessary limitation on 64-bit machines, which
11775 caused (substring ...) to crash on large vectors (Bug#8344).
11776 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11777 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11778 All variadic functions and their callers changed accordingly.
c5101a77
PE
11779 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11780 * data.c (arith_driver, float_arith_driver): Likewise.
11781 * editfns.c (general_insert_function): Likewise.
11782 * eval.c (struct backtrace.nargs, interactive_p)
11783 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11784 (funcall_lambda, mark_backtrace): Likewise.
11785 * fns.c (concat): Likewise.
11786 * frame.c (x_set_frame_parameters): Likewise.
11787 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11788 0 if not found, not -1. All callers changed.
11789
dd3f25f7
PE
11790 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11791 (stack_copy_size): Now size_t, not int.
11792 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11793
461c2ab9
JB
117942011-03-28 Juanma Barranquero <lekktu@gmail.com>
11795
11796 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11797 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11798 All callers changed.
11799
11800 * lisp.h (multibyte_char_to_unibyte):
11801 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11802 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11803 * character.h (CHAR_TO_BYTE8):
11804 * cmds.c (internal_self_insert):
11805 * editfns.c (general_insert_function):
11806 * keymap.c (push_key_description):
11807 * search.c (Freplace_match):
11808 * xdisp.c (message_dolog, set_message_1): All callers changed.
11809
f6d62986
SM
118102011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11811
11812 * keyboard.c (safe_run_hook_funcall): New function.
11813 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11814 don't set the hook to nil, but remove the offending function instead.
11815 (Qcommand_hook_internal): Remove, unused.
11816 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11817 Vcommand_hook_internal.
11818
11819 * eval.c (enum run_hooks_condition): Remove.
11820 (funcall_nil, funcall_not): New functions.
11821 (run_hook_with_args): Call each function through a `funcall' argument.
11822 Remove `cond' argument, now redundant.
11823 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11824 (Frun_hook_with_args_until_failure): Adjust accordingly.
11825 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11826
1db5b1ad
JB
118272011-03-28 Juanma Barranquero <lekktu@gmail.com>
11828
11829 * dispextern.h (string_buffer_position): Remove declaration.
11830
11831 * print.c (strout): Remove parameter `multibyte', unused since
11832 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11833
11834 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11835 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11836 All callers changed.
11837
11838 * w32.c (_wsa_errlist): Use braces for struct initializers.
11839
11840 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11841 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11842 All callers changed.
11843 (string_buffer_position): Likewise. Also, make static (it's never
11844 used outside xdisp.c).
11845 (cursor_row_p): Remove parameter `w', unused since
11846 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11847 (decode_mode_spec): Remove parameter `precision', introduced during
11848 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11849 All callers changed.
11850
5ffb62aa
JD
118512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11852
11853 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11854
461c2ab9 118552011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11856
11857 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11858 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11859 (ns_update_auto_hide_menu_bar): New functions.
11860 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11861 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11862 ns_constrain_all_frames.
11863 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11864 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11865
5c380ffb
JD
118662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11867
11868 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11869
9af30bdf
GM
118702011-03-27 Glenn Morris <rgm@gnu.org>
11871
11872 * syssignal.h: Replace RETSIGTYPE with void.
11873 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11874 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11875 Replace SIGTYPE with void everywhere.
11876 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11877 * s/template.h (SIGTYPE): Remove commented out definition.
11878
e2abce01
JB
118792011-03-26 Eli Zaretskii <eliz@gnu.org>
11880
11881 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11882 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11883
f868cd8a
JB
118842011-03-26 Juanma Barranquero <lekktu@gmail.com>
11885
59eb0929
JB
11886 * w32.c (read_unc_volume): Use parameter `henum', instead of
11887 global variable `wget_enum_handle'.
11888
11889 * keymap.c (describe_vector): Remove parameters `indices' and
11890 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11891 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11892
f868cd8a
JB
11893 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11894
11895 * keyboard.c (timer_check): Remove parameter `do_it_now',
11896 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11897 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11898 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11899
11900 * keyboard.c (read_char):
11901 * w32menu.c (w32_menu_display_help):
11902 * xmenu.c (show_help_event, menu_help_callback):
11903 Adjust calls to `show_help_echo'.
11904
11905 * gtkutil.c (xg_maybe_add_timer):
11906 * keyboard.c (readable_events):
11907 * process.c (wait_reading_process_output):
11908 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11909
11910 * insdel.c (adjust_markers_gap_motion):
11911 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11912 (gap_left, gap_right): Don't call it.
11913
2ecf6fdb
CY
119142011-03-25 Chong Yidong <cyd@stupidchicken.com>
11915
11916 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11917 incurred during fontification.
11918
6b1f9ba4
JB
119192011-03-25 Juanma Barranquero <lekktu@gmail.com>
11920
11921 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11922 (DEFVAR_PER_BUFFER): Don't pass it.
11923
11924 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11925 (scrolling_window): Don't pass it.
11926
0f4a96b5
JB
119272011-03-25 Juanma Barranquero <lekktu@gmail.com>
11928
11929 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11930
11931 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11932 and `suffix'.
11933 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11934 of variables specific to SELinux and computation of `encoded_absname'.
11935
11936 * image.c (XPutPixel): Remove unused variable `height'.
11937
11938 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11939
11940 * unexw32.c (get_section_info): Remove unused variable `section'.
11941
11942 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11943 (system_process_attributes): Remove unused variable `sess'.
11944 (sys_read): Remove unused variable `err'.
11945
11946 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11947 (w32_wnd_proc): Remove unused variable `isdead'.
11948 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11949 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11950 (x_create_tip_frame): Remove unused variable `tem'.
11951
11952 * w32inevt.c (w32_console_read_socket):
11953 Remove unused variable `no_events'.
11954
11955 * w32term.c (x_draw_composite_glyph_string_foreground):
11956 Remove unused variable `width'.
11957
1149507c
JB
119582011-03-24 Juanma Barranquero <lekktu@gmail.com>
11959
11960 * w32term.c (x_set_glyph_string_clipping):
11961 Don't pass uninitialized region to CombineRgn.
11962
9c88f339
JB
119632011-03-23 Juanma Barranquero <lekktu@gmail.com>
11964
11965 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11966 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11967 (Fx_close_connection): Remove unused variable `i'.
11968
11969 * w32font.c (w32font_draw): Return number of glyphs.
11970 (w32font_open_internal): Remove unused variable `i'.
11971 (w32font_driver): Add missing initializer.
11972
11973 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11974 (fill_in_menu): Remove unused variable `items_added'.
11975
11976 * w32term.c (last_mouse_press_frame): Remove static global variable.
11977 (w32_clip_to_row): Remove unused variable `f'.
11978 (x_delete_terminal): Remove unused variable `i'.
11979
11980 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11981 (NOTHING): Remove unused static global variable.
11982 (uniscribe_check_otf): Remove unused variable `table'.
11983 (uniscribe_font_driver): Add missing initializers.
11984
dee091a3
JD
119852011-03-23 Julien Danjou <julien@danjou.info>
11986
11987 * term.c (Fsuspend_tty, Fresume_tty):
11988 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11989 * window.c (temp_output_buffer_show):
11990 * insdel.c (signal_before_change):
11991 * frame.c (Fhandle_switch_frame):
11992 * fileio.c (Fdo_auto_save):
11993 * emacs.c (Fkill_emacs):
11994 * editfns.c (save_excursion_restore):
11995 * cmds.c (internal_self_insert):
11996 * callint.c (Fcall_interactively):
11997 * buffer.c (Fkill_all_local_variables):
11998 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11999 Use Frun_hooks.
0f4a96b5 12000 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12001 unconditionally since it does the check itself.
dee091a3 12002
2c520ab5 120032011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12004
c9c49752
PE
12005 Fix more problems found by GCC 4.5.2's static checks.
12006
8abc3f12
PE
12007 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12008 the first time through the loop, since we know p0 < p1 then.
12009 This also avoids a gcc -Wstrict-overflow warning.
12010
a2d26660
PE
12011 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12012 leading to a memory leak, possible in functions like
12013 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12014 of objects (Bug#8318).
a2d26660 12015
916c72e9
PE
12016 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12017 that could (at least in theory) be that large.
12018
19ab8a18
PE
12019 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12020 This is less likely to overflow, and avoids undefined behavior if
12021 overflow does occur. All callers changed. Use strtoul to scan
12022 for the unsigned long integer.
b7cbbd6f
PE
12023 (pint2hrstr): Simplify and tune code slightly.
12024 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12025
f0641eff
PE
12026 * scroll.c (do_scrolling): Work around GCC bug 48228.
12027 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12028
7f650bb9
PE
12029 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12030 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12031 (validate_x_resource_name): Simplify count usage.
12032 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12033
37dd57d1
PE
12034 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12035 fail (Bug#8306).
81e56e61 12036
699979fc 12037 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12038
401bf9b4
PE
12039 * process.c (Fmake_network_process): Use socklen_t, not int,
12040 where POSIX says socklen_t is required in portable programs.
12041 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12042 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12043 (Fmake_network_process, server_accept_connection):
12044 (wait_reading_process_output, read_process_output):
12045 Likewise.
12046
b93aacde
PE
12047 * process.c: Rename or move locals to avoid shadowing.
12048 (list_processes_1, Fmake_network_process):
12049 (read_process_output_error_handler, exec_sentinel_error_handler):
12050 Rename or move locals.
4dc343ee 12051 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12052 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12053 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12054 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12055 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12056
af8a867c 12057 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12058 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12059 Include tparam.h instead, since it declares them.
af8a867c
PE
12060 * cm.h (PC): Remove extern decl; tparam.h now does this.
12061 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12062 * terminfo.c: Include tparam.h, to check interfaces.
12063 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12064 (tparam): Adjust signature to match interface in tparam.h;
12065 this removes some undefined behavior. Check that outstring and len
12066 are zero, which they always are with Emacs.
12067 * tparam.h (PC, BC, UP): New extern decls.
12068
0248044d 12069 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12070 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12071
8ff096c1 12072 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12073 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12074 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12075 (ftfont_list): Remove unused local.
49eaafba
PE
12076 (get_adstyle_property, ftfont_pattern_entity):
12077 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12078 Rename locals to avoid shadowing.
8ff096c1 12079
e2be39f6
PE
12080 * xfont.c (xfont_list_family): Mark var as initialized.
12081
c9735e30
PE
12082 * xml.c (make_dom): Now static.
12083
8f5201ae
PE
12084 * composite.c (composition_compute_stop_pos): Rename local to
12085 avoid shadowing.
b246f932
PE
12086 (composition_reseat_it): Remove unused locals.
12087 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12088 (composition_update_it): Mark var as initialized.
11b61122
PE
12089 (find_automatic_composition): Mark vars as initialized,
12090 with a FIXME (Bug#8290).
8f5201ae 12091
760fbc2c
PE
12092 character.h: Rename locals to avoid shadowing.
12093 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12094 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12095 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12096 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12097 to avoid shadowing.
12098
ff08eb85
PE
12099 * textprop.c (property_change_between_p): Remove; unused.
12100
fc7bf025
PE
12101 * intervals.c (interval_start_pos): Now static.
12102
235d7abc
PE
12103 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12104
44f230aa
SM
12105 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12106 Rename locals to avoid shadowing.
3e7d6594 12107
50060332
PE
12108 * sound.c (wav_play, au_play, Fplay_sound_internal):
12109 Fix pointer signedness.
d01f234b 12110 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12111 (wav_play): Initialize a variable to 0, to prevent undefined
12112 behavior (Bug#8278).
50060332 12113
c4fc4e30
PE
12114 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12115
918436ed
PE
12116 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12117
c939f91b
PE
12118 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12119 clobbering (Bug#8298).
b9c7f648
PE
12120 * sysdep.c (sys_subshell): Likewise.
12121 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12122
6bd8c144
PE
12123 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12124 This should get cleaned up, so that child_setup has the
12125 same signature on all platforms.
12126
7710357c 12127 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12128 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12129
c59da222
CY
121302011-03-22 Chong Yidong <cyd@stupidchicken.com>
12131
12132 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12133 not to be necessary, and produces flickering.
12134
66b87493
GM
121352011-03-20 Glenn Morris <rgm@gnu.org>
12136
12137 * config.in: Remove file.
12138
45b6f6d5
JB
121392011-03-20 Juanma Barranquero <lekktu@gmail.com>
12140
12141 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12142 are now in src/globals.h.
12143 (syms_of_minibuf): Remove spurious & from previous change.
12144
cd394be1 121452011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12146
12147 * minibuf.c (completing-read-function): New variable.
12148 (completing-read-default): Rename from completing-read.
12149 (completing-read): Call completing-read-function.
12150
b14e3e21
CY
121512011-03-19 Juanma Barranquero <lekktu@gmail.com>
12152
12153 * xfaces.c (Fx_load_color_file):
12154 Read color file from absolute filename (bug#8250).
12155
f2b726e6
JB
121562011-03-19 Juanma Barranquero <lekktu@gmail.com>
12157
12158 * makefile.w32-in: Update dependencies.
12159
09f6ff02
EZ
121602011-03-17 Eli Zaretskii <eliz@gnu.org>
12161
12162 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12163
29a6015a
PE
121642011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12165
a3a6c54e
PE
12166 Fix more problems found by GCC 4.5.2's static checks.
12167
b766f867
PE
12168 * process.c (make_serial_process_unwind, send_process_trap):
12169 (sigchld_handler): Now static.
12170
be02381c
PE
12171 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12172 That way, the code declares only the vars that it needs.
12173 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12174 * s/cygwin.h (PTY_ITERATION): Likewise.
12175 * s/darwin.h (PTY_ITERATION): Likewise.
12176 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12177
57048744
PE
12178 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12179 * process.c (allocate_pty): Don't declare stb unless it's needed.
12180
7914961c 12181 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12182 (CONSTANTLIM): Remove; unused.
12183 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12184 Define only if needed.
7914961c 12185
b3967b18
PE
12186 * unexelf.c (unexec): Name an expression,
12187 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12188 Use a different way to cause a compilation error if anyone uses
12189 n rather than nn, a way that does not involve shadowing.
73366a00 12190 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12191
29a6015a
PE
12192 * deps.mk (unexalpha.o): Remove; unused.
12193
43cfc33e 12194 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12195 * unexec.h: New file.
ce701a33
PE
12196 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12197 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12198 Depend on unexec.h.
12199 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12200 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12201 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12202 Change as necessary to match prototype in unexec.h.
ce701a33 12203
01f44d5a
PE
12204 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12205 shadowing.
4f63c6bb 12206 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12207
a6670b0b
PE
12208 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12209 Rename locals to avoid shadowing.
12210
cef2010d 12211 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12212 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12213
d4d7173a
PE
12214 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12215
f08b802a
PE
12216 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12217 warning when compiling print.c.
12218
3ddb0639
PE
12219 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12220 instead of using an uninitialized var.
5ad03b97 12221 (font_sort_entities): Mark var as initialized.
3ddb0639 12222
170a2692
PE
12223 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12224
e663c700
PE
12225 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12226 pointers to constants.
89bc529a 12227 (font_parse_fcname): Remove unused vars.
7b81e2d0 12228 (font_delete_unmatched): Now static.
ea838e10 12229 (font_get_spec): Remove; unused.
13a547c6
PE
12230 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12231 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12232 Rename or move locals to avoid shadowing.
e663c700 12233
2a80c887 12234 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12235 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12236
1384fa33 12237 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12238 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12239
8b2c52e9
PE
12240 * alloc.c (mark_backtrace): Move decl from here ...
12241 * lisp.h: ... to here, so that it can be checked.
12242
475545b5 12243 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12244 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12245 (lisp_indirect_variable): Name an expression,
12246 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12247 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12248
b1349114 12249 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12250 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12251 Use const pointer when appropriate.
b1349114 12252
a2928364
PE
12253 * lisp.h (get_system_name, get_operating_system_release):
12254 Move decls here, to check interfaces.
12255 * process.c (get_operating_system_release): Move decl to lisp.h.
12256 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12257 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12258 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12259 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12260 (Fformat_time_string, Fencode_time, Finsert_char):
12261 (Ftranslate_region_internal, Fformat):
12262 Rename or remove local vars to avoid shadowing.
9710023e 12263 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12264
a415e694
PE
12265 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12266 avoid shadowing.
12267
8ef4622d
PE
12268 * lisp.h (eassert): Check that the argument compiles, even if
12269 ENABLE_CHECKING is not defined.
12270
946f9a5b
PE
12271 * data.c (Findirect_variable): Name an expression, to avoid
12272 gcc -Wbad-function-cast warning.
112396d6 12273 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12274 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12275 (Fmake_variable_buffer_local, Fmake_local_variable):
12276 Mark variables as initialized.
52746918 12277 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12278
e5aab7e7 12279 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12280 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12281 Rename locals to avoid shadowing.
dff45157
PE
12282 (mark_stack): Move local variables into the #ifdef region where
12283 they're used.
7bc26fdb
PE
12284 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12285 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12286 needed otherwise.
12287 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12288 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12289 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12290
e5aab7e7
PE
12291 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12292 avoids undefined behavior in theory.
12293
4da60324
PE
12294 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12295
88043301
PE
12296 Use functions, not macros, for up- and down-casing (Bug#8254).
12297 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12298 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12299 to use the following functions instead of these macros.
12300 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12301 EMACS_INT, since callers assume the returned value fits in int.
12302 (upcase1): Likewise, for UPCASE_TABLE.
12303 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12304 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12305 the race-condition problem in the old DOWNCASE.
88043301 12306
19ed5445
PE
12307 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12308 Rename locals to avoid shadowing.
12309 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12310 (regex_compile, re_search_2, re_match_2_internal):
12311 Remove unused local vars.
952db0d7
PE
12312 (FREE_VAR): Rewrite so as not to use empty "else",
12313 which gcc can warn about.
da053e48 12314 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12315 (RETALLOC_IF): Define only if needed.
12316 (WORDCHAR_P): Likewise. This one is never needed, but is used
12317 only in a comment talking about a compiler bug, so put inside
12318 the #if 0 of that comment.
12319 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12320 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12321 Remove; unused.
19ed5445 12322
1f3561e4 12323 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12324 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12325 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12326
ded6f8f7
PE
12327 * search.c (simple_search): Remove unused var.
12328
dbd37a95
PE
12329 * dired.c (compile_pattern): Move decl from here ...
12330 * lisp.h: ... to here, so that it can be checked.
12331 (struct re_registers): New forward decl.
12332
7e47afad
PE
12333 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12334
85f24f61
PE
12335 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12336 All uses changed.
12337 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12338 Rename locals to avoid shadowing.
5671df8f 12339 (Fvertical_motion): Mark locals as initialized.
85f24f61 12340
181aa2be 12341 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12342 (casify_region): Mark local as initialized.
181aa2be 12343
930d429c
PE
12344 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12345
7082eac6
PE
12346 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12347 New macros, so that the caller can use some names other than
12348 gcpro1, gcpro2, etc.
12349 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12350 of the new macros.
12351 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12352 argument, for consistency with GCPRO2_VAR, etc: it is now the
12353 prefix of the variable, not the variable itself. All uses
12354 changed.
38b2c076
PE
12355 * dired.c (directory_files_internal, file_name_completion):
12356 Rename locals to avoid shadowing.
12357
15206ed9
PE
12358 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12359 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12360 dired.c's scmp function, had undefined behavior.
12361 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12362 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12363 * buffer.h: ... to here, because these macros use current_buffer,
12364 and the new implementation with inline functions needs to have
12365 current_buffer in scope now, rather than later when the macros
12366 are used.
12367 (downcase, upcase1): New static inline functions.
12368 (DOWNCASE, UPCASE1): Reimplement using these functions.
12369 This avoids undefined behavior in expressions like
12370 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12371 from race conditions in accessing the global variables
12372 case_temp1 and case_temp2.
12373 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12374 * lisp.h (case_temp1, case_temp2): Remove their decls.
12375 * character.h (ASCII_CHAR_P): Move from here ...
12376 * lisp.h: ... to here, so that the inline functions mentioned
12377 above can use them.
12378
4a6bea26
PE
12379 * dired.c (directory_files_internal_unwind): Now static.
12380
f14b7e14
PE
12381 * fileio.c (file_name_as_directory, directory_file_name):
12382 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12383 Now static.
2893f146
PE
12384 (file_name_as_directory): Use const pointers when appropriate.
12385 (Fexpand_file_name): Likewise. In particular, newdir might
12386 point at constant storage, so make it a const pointer.
fd4ead52 12387 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12388 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12389 signedness issues.
f839df0c
PE
12390 (Fset_file_times, Finsert_file_contents, auto_save_error):
12391 Rename locals to avoid shadowing.
f14b7e14 12392
5716756e 12393 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12394 (Ftry_completion, Fall_completions): Rename or remove locals
12395 to avoid shadowing.
5716756e 12396
b4c3046a
PE
12397 * marker.c (bytepos_to_charpos): Remove; unused.
12398
b45db522
PE
12399 * lisp.h (verify_bytepos, count_markers): New decls,
12400 so that gcc does not warn that these functions aren't declared.
12401
85876d07
PE
12402 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12403 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12404 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12405 (copy_text): Remove unused local var.
85876d07 12406
03d78a21 12407 * filelock.c (within_one_second): Now static.
b3dd38ab 12408 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12409
5df8f01b
PE
12410 * buffer.c (fix_overlays_before): Mark locals as initialized.
12411 (fix_start_end_in_overlays): Likewise. This function should be
12412 simplified by using pointers-to-pointers, but that's a different
12413 matter.
b1d876f1 12414 (switch_to_buffer_1): Now static.
8f54f30a
PE
12415 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12416 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12417
a70072c9 12418 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12419 Fix pointer signedness issue.
edced198
PE
12420 (sys_subshell): Mark local as volatile if checking for lint,
12421 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12422 (MAXPATHLEN): Define only if needed.
a70072c9 12423
a0977c44
PE
12424 * process.c (serial_open, serial_configure): Move decls from here ...
12425 * systty.h: ... to here, so that they can be checked.
12426
a884fdcc
PE
12427 * fns.c (get_random, seed_random): Move extern decls from here ...
12428 * lisp.h: ... to here, so that they can be checked.
12429
604efe86 12430 * sysdep.c (reset_io): Now static.
b8950c94 12431 (wait_for_termination_signal): Remove; unused.
604efe86 12432
38fc62d9
PE
12433 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12434 (copy_keymap_item, append_key, push_text_char_description):
12435 Now static.
1004a21a 12436 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12437 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12438 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12439 (describe_map_tree):
12440 Rename locals to avoid shadowing.
38fc62d9 12441
2f2650da
PE
12442 * keyboard.c: Declare functions static if they are not used elsewhere.
12443 (echo_char, echo_dash, cmd_error, top_level_2):
12444 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12445 (read_char, kbd_buffer_get_event, make_lispy_position):
12446 (make_lispy_event, make_lispy_movement, apply_modifiers):
12447 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12448 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12449 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12450 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12451 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12452
a053e86c 12453 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12454 (mark_kboards): Move decl here ...
12455 * alloc.c (mark_kboards): ... from here.
a053e86c 12456
4752793e
PE
12457 * lisp.h (force_auto_save_soon): New decl.
12458
74f10ca7 12459 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12460 (DEFINE_DUMMY_FUNCTION): New macro.
12461 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12462 Use it.
c03cd23f
PE
12463 (main): Add casts to avoid warnings
12464 if GCC considers string literals to be constants.
74f10ca7 12465
022e70d4
PE
12466 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12467
59d6fe83
PE
12468 * dbusbind.c: Pointer signedness fixes.
12469 (xd_signature, xd_append_arg, xd_initialize):
12470 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12471 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12472 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12473 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12474
78320123
PE
12475 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12476 if GCC considers string literals to be constants.
49cebcca 12477 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12478
35ac2a97
SM
124792011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12480
fb103ca9
SM
12481 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12482 (print_preprocess, print_object): New macro to fix last change.
12483
35ac2a97
SM
12484 * print.c (print_preprocess): Don't forget font objects.
12485
62973b41
JB
124862011-03-16 Juanma Barranquero <lekktu@gmail.com>
12487
12488 * emacs.c (USAGE3): Doc fixes.
12489
0e48bb22
AS
124902011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12491
12492 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12493 structure.
12494
7684e57b
JB
124952011-03-14 Juanma Barranquero <lekktu@gmail.com>
12496
12497 * lisp.h (VWindow_system, Qfile_name_history):
12498 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12499 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12500 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12501
12502 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12503 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12504
12505 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12506 * w32console.c (detect_input_pending, read_input_pending)
12507 (encode_terminal_code):
12508 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12509 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12510 (w32_system_caret_y, Qfile_name_history):
12511 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12512 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12513 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12514 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12515 * w32proc.c (Qlocal, report_file_error):
12516 * w32term.c (Vwindow_system, updating_frame):
12517 * w32uniscribe.c (initialized, uniscribe_font_driver):
12518 Remove unneeded extern declarations.
12519
2aa46d6c
CY
125202011-03-14 Chong Yidong <cyd@stupidchicken.com>
12521
c96bbc66 12522 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12523
cffc6f3b
CY
125242011-03-13 Chong Yidong <cyd@stupidchicken.com>
12525
12526 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12527 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12528 These macros can no longer be used for assignment.
12529
44f230aa
SM
12530 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12531 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12532 (record_buffer_markers, fetch_buffer_markers): New functions for
12533 recording and fetching special buffer markers.
12534 (set_buffer_internal_1, set_buffer_temp): Use them.
12535
12536 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12537
12538 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12539
12540 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12541 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12542
12543 * xdisp.c (hscroll_window_tree):
12544 (reconsider_clip_changes): Use PT instead of BUF_PT.
12545
d251f04b
EZ
125462011-03-13 Eli Zaretskii <eliz@gnu.org>
12547
12548 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12549 $(EMACS_ROOT)/lib/intprops.h.
12550
f0c77cd1
PE
125512011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12552
3eca4629
PE
12553 Fix more problems found by GCC 4.5.2's static checks.
12554
7c86ee98
PE
12555 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12556 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12557 (xg_free_frame_widgets): Make it clear that a local variable is
12558 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12559 (gdk_window_get_screen): Make it clear that this macro is needed
12560 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12561 (int_gtk_range_get_value): New function, which avoids a diagnostic
12562 from gcc -Wbad-function-cast.
12563 (xg_set_toolkit_scroll_bar_thumb): Use it.
12564 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12565 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12566 (get_utf8_string, xg_get_file_with_chooser):
12567 Rename locals to avoid shadowing.
12568 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12569
41729b81
PE
12570 * xgselect.c (xg_select): Remove unused var.
12571
f0c77cd1
PE
12572 * image.c (four_corners_best): Mark locals as initialized.
12573 (gif_load): Initialize transparent_p to zero (Bug#8238).
12574 Mark another local as initialized.
ec6cf4c6 12575 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12576
ce0ad53d 12577 * image.c (clear_image_cache): Now static.
d5d5a617 12578 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12579 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12580 (x_edge_detection): Remove unnecessary cast that
12581 gcc -Wbad-function-cast diagnoses.
2037898d 12582 (gif_load): Fix pointer signedness.
6ae141d6
PE
12583 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12584 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12585
33383987 125862011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12587
d32df629
PE
12588 Improve quality of tests for time stamp overflow.
12589 For example, without this patch (encode-time 0 0 0 1 1
12590 1152921504606846976) returns the obviously-bogus value (-948597
12591 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12592 reports time overflow. See
12593 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12594 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12595 * editfns.c: Include limits.h and intprops.h.
12596 (TIME_T_MIN, TIME_T_MAX): New macros.
12597 (time_overflow): Move earlier, to before first use.
12598 (hi_time, lo_time): New functions, for an accurate test for
12599 out-of-range times.
12600 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12601 (Fget_internal_run_time): Don't assume time_t fits in int.
12602 (make_time): Use list2 instead of Fcons twice.
12603 (Fdecode_time): More accurate test for out-of-range times.
12604 (check_tm_member): New function.
12605 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12606 (lisp_time_argument): Don't rely on undefined left-shift and
12607 right-shift behavior when checking for time stamp overflow.
8be6f318 12608
fe31d94c
PE
12609 * editfns.c (time_overflow): New function, refactoring common code.
12610 (Fformat_time_string, Fdecode_time, Fencode_time):
12611 (Fcurrent_time_string): Use it.
12612
8be6f318
PE
12613 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12614 * dired.c (make_time): Move to ...
12615 * editfns.c (make_time): ... here.
12616 * systime.h: Note the move.
12617
09d9db2c 126182011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12619
126bc0dc
YM
12620 * fringe.c (update_window_fringes): Remove unused variables.
12621
c47cbdfd
YM
12622 * unexmacosx.c (copy_data_segment): Also copy __got section.
12623 (Bug#8223)
12624
7ac80be9
EZ
126252011-03-12 Eli Zaretskii <eliz@gnu.org>
12626
c96bbc66 12627 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12628 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12629 Constify `char *' arguments and their references according to
12630 prototypes in tparam.h.
12631
ecb0f94d 12632 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12633
7ac80be9
EZ
12634 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12635 Adapt all references accordingly.
12636
12637 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12638
ef1fd07e
TT
126392011-03-11 Tom Tromey <tromey@redhat.com>
12640
12641 * buffer.c (syms_of_buffer): Remove obsolete comment.
12642
7ef4b50c
EZ
126432011-03-11 Eli Zaretskii <eliz@gnu.org>
12644
12645 * termhooks.h (encode_terminal_code): Declare prototype.
12646
12647 * msdos.c (encode_terminal_code): Don't declare prototype.
12648
12649 * term.c (encode_terminal_code): Now external again, used by
12650 w32console.c and msdos.c.
12651
44f230aa
SM
12652 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12653 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12654
4b1ec863 126552011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12656
1714f52b 12657 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12658
4b1ec863
PE
12659 * fringe.c (update_window_fringes): Mark locals as initialized
12660 (Bug#8227).
12661 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12662
524c7aa6
PE
12663 * alloc.c (mark_fringe_data): Move decl from here ...
12664 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12665 to check its interface.
12666 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12667
a5c0af81 12668 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12669 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12670 (fontset_font): Mark local as initialized.
a9a06e0b 12671 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12672
b4716021
PE
12673 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12674
811e9bac 12675 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12676 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12677 (x_own_selection, Fx_disown_selection_internal): Rename locals
12678 to avoid shadowing.
12679 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12680
7e3ab302
PE
12681 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12682 so that the caller can use some name other than gcpro1.
12683 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12684 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12685 (Fx_backspace_delete_keys_p):
12686 Use them to avoid shadowing, and rename vars to avoid shadowing.
12687 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12688 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12689 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12690 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12691 Remove unused locals.
7e3ab302
PE
12692 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12693 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12694 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12695 macros.
f78faa98 12696
e2b13473
PE
12697 * xterm.h (x_mouse_leave): New decl.
12698
77f23912
PE
12699 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12700 Remove unused functions.
cdf4ba58
PE
12701 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12702 (x_calc_absolute_position): Now static.
7411c686 12703 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12704 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12705 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12706 unless they are used.
38d0b34a
PE
12707 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12708 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12709 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12710 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12711 (x_error_catcher, x_connection_closed, x_error_handler):
12712 (x_error_quitter, xembed_send_message, x_iconify_frame):
12713 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12714 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12715 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12716
44f230aa
SM
12717 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12718 Rename or move locals to avoid shadowing.
6b463e58 12719 (tty_defined_color, merge_face_heights): Now static.
5967d051 12720 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12721 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12722 does not deduce is never used uninitialized.
73719eba
PE
12723 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12724 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12725
426994c3 12726 * terminal.c (store_terminal_param): Now static.
5489860b 12727
032f1620 12728 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12729 (set_frame_menubar): Remove unused local.
d4323972 12730 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12731 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12732 since they might point to immutable storage.
281585b0
PE
12733 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12734 since it's unused otherwise.
032f1620 12735
367c19e5 12736 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12737 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12738 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12739 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12740 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12741 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12742 does not deduce are never used uninitialized.
70739cbe 12743
07b48fa9
PE
12744 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12745
8868a238 12746 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12747 * window.c (window_loop, size_window):
12748 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12749
7e5cf297 12750 * window.c (display_buffer): Now static.
d6550a9f
PE
12751 (size_window): Mark variables that gcc -Wuninitialized
12752 does not deduce are never used uninitialized.
a586633d
PE
12753 * window.h (check_all_windows): New decl, to forestall
12754 gcc -Wmissing-prototypes diagnostic.
5b555da1 12755 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12756
f6095868
PE
12757 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12758 shadowing.
12759 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12760 Include <limits.h>.
12761 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12762 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12763 (load_charset_map): Mark variables that gcc -Wuninitialized
12764 does not deduce are never used uninitialized.
53df7c11 12765 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12766
f38b440c
PE
12767 * coding.c (coding_set_source, coding_set_destination):
12768 Use "else { /* comment */ }" rather than "else /* comment */;"
12769 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12770 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12771 a block, when the outer 'i' will do.
12772 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12773 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12774 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12775 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12776 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12777 Rename locals to avoid shadowing.
12778 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12779 * coding.c (emacs_mule_char, encode_invocation_designation):
12780 Now static, since they're not used elsewhere.
413bb2db 12781 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12782 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12783 (decode_coding_emacs_mule): Mark variables that gcc
12784 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12785 (detect_coding_iso_2022): Initialize a local variable that might
12786 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12787 this initialization is needed. (Bug#8211)
5f58e762
PE
12788 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12789 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12790 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12791 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12792 Remove unused macros.
f38b440c 12793
232b38b9 12794 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12795 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12796 * character.c (string_count_byte8): Likewise.
232b38b9 12797
fb90da1b
PE
12798 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12799 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12800
fb93dbc2
PE
12801 * chartab.c (copy_sub_char_table): Now static, since it's not used
12802 elsewhere.
5c156ace
PE
12803 (sub_char_table_ref_and_range, char_table_ref_and_range):
12804 Rename locals to avoid shadowing.
bbcd0949 12805 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12806
7d3b3862 12807 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12808 (BIDI_BOB): Remove unused macro.
7d3b3862 12809
6be7d3da
PE
12810 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12811 deduce are never used uninitialized.
c2ed9c8b 12812 * term.c (encode_terminal_code): Likewise.
6be7d3da 12813
75f8807f 12814 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12815
50938595
PE
12816 * tparam.h: New file.
12817 * term.c, tparam.h: Include it.
12818 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12819 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12820 Move these decls to tparam.h, and make them agree with what
12821 is actually in tparam.c. The previous trick of using incompatible
12822 decls in different modules does not conform to the C standard.
12823 All callers of tparam changed to use tparam's actual API.
12824 * tparam.c (tparam1, tparam, tgoto):
12825 Use const pointers where appropriate.
12826
fbceeba2
PE
12827 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12828 * cm.h (struct cm): Likewise.
12829 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12830 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12831 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12832 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12833 (turn_on_face, init_tty): Likewise.
12834 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12835
7f3f1250
PE
12836 * term.c (term_mouse_position): Rename local to avoid shadowing.
12837
e6ca6543
PE
12838 * alloc.c (mark_ttys): Move decl from here ...
12839 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12840
c40f8d15
AS
128412011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12842
12843 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12844
cfe0661d
JB
128452011-03-09 Juanma Barranquero <lekktu@gmail.com>
12846
12847 * search.c (compile_pattern_1): Remove argument regp, unused since
12848 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12849 (compile_pattern): Don't pass it.
12850
0afb4571
J
128512011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12852
12853 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12854 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12855 for ! HAVE_GTK3.
12856 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12857
12858 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12859
12860 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12861 gdk_window_get_screen, gdk_window_get_geometry,
12862 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12863 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12864 (xg_get_pixbuf_from_pixmap): New function.
12865 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12866 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12867 Call xg_get_pixbuf_from_pixmap instead of
12868 gdk_pixbuf_get_from_drawable.
12869 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12870 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12871 (xg_check_special_colors): Use GtkStyleContext and its functions
12872 for HAVE_GTK3.
12873 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12874 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12875 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12876 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12877 Call gtk_widget_get_preferred_size.
0afb4571
J
12878 (xg_frame_resized): gdk_window_get_geometry only takes 5
12879 parameters.
44f230aa
SM
12880 (xg_win_to_widget, xg_event_is_for_menubar):
12881 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12882 (xg_set_widget_bg): New function.
12883 (delete_cb): New function.
895009e1 12884 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12885 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12886 (xg_set_background_color): Call xg_set_widget_bg.
12887 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12888 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12889 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12890 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12891 if ! HAVE_GTK3.
12892 (update_frame_tool_bar): Call gtk_widget_hide.
12893 (xg_initialize): Use GDK_KEY_g.
12894
12895 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12896 if ! HAVE_GTK3
12897 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12898
12899 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12900 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12901 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12902
1c2cc4ef
JB
129032011-03-08 Juanma Barranquero <lekktu@gmail.com>
12904
12905 * w32xfns.c (select_palette): Check success of RealizePalette against
12906 GDI_ERROR, not zero.
12907
33383987 12908See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12909
12910;; Local Variables:
12911;; coding: utf-8
aac0c6e3
MR
12912;; End:
12913
2f097256 12914 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12915
12916 This file is part of GNU Emacs.
12917
12918 GNU Emacs is free software: you can redistribute it and/or modify
12919 it under the terms of the GNU General Public License as published by
12920 the Free Software Foundation, either version 3 of the License, or
12921 (at your option) any later version.
12922
12923 GNU Emacs is distributed in the hope that it will be useful,
12924 but WITHOUT ANY WARRANTY; without even the implied warranty of
12925 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12926 GNU General Public License for more details.
12927
12928 You should have received a copy of the GNU General Public License
12929 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.