* .gdbinit (xpr): Remove checks for no longer existing misc types.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
74dd3a6b
AS
12012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2
3 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5 Remove.
6
13c379ee
PE
72012-04-28 Paul Eggert <eggert@cs.ucla.edu>
8
9 Do not avoid creating empty evaporating overlays (Bug#9642).
10 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
11 That is, do not delete an evaporating overlay if it becomes
12 empty after its bounds are adjusted to fit within its buffer.
13 This fix caused other problems, and I'm reverting it until we get
14 to the bottom of them.
15
a8e7d6d7 162012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
17
18 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
19
a8e7d6d7 202012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
21
22 * xdisp.c (pos_visible_p): If the window start position is beyond
23 ZV, start the display from buffer beginning. Prevents assertion
24 violation in init_iterator when the minibuffer window is scrolled
25 via the scroll bar.
26
27 * window.c (window_scroll_pixel_based): Likewise.
28
a8e7d6d7 292012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
30
31 * keymap.c (where_is_internal): Doc fix (Bug#10872).
32
a8e7d6d7 332012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
34
35 * fileio.c (Fcopy_file, Fset_file_selinux_context):
36 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
37
a8e7d6d7 382012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685
EZ
39
40 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
41 overrun array limits of glyph row's used[] array. (Bug#11288)
42
1c6900d9
EZ
432012-04-26 Eli Zaretskii <eliz@gnu.org>
44
4c3fa1d9
EZ
45 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
46 display element, check also the underlying string or buffer
47 character. (Bug#11341)
48
1c6900d9
EZ
49 * w32menu.c: Include w32heap.h.
50 (add_menu_item): If the call to AppendMenuW (via
51 unicode_append_menu) fails, disable Unicode menus only if we are
52 running on Windows 9X/Me.
53
42bf8205
AS
542012-04-24 Andreas Schwab <schwab@linux-m68k.org>
55
56 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
57 (xgetint): Add missing shift for LSB tags.
58
b1bac16e
MR
592012-04-24 Martin Rudalics <rudalics@gmx.at>
60
61 * keyboard.c (read_char): Don't wipe echo area for select window
62 events: These might get delayed via `mouse-autoselect-window'
63 (Bug#11304).
64
d69621cc
JB
652012-04-24 Juanma Barranquero <lekktu@gmail.com>
66
67 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
68 manipulation of :loaded-from data.
69
02fd101b
JB
702012-04-23 Juanma Barranquero <lekktu@gmail.com>
71
72 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
73 now a cons (bug#11311).
74
888bec30
PE
752012-04-23 Paul Eggert <eggert@cs.ucla.edu>
76
89a438bd
PE
77 Do not create empty overlays with the evaporate property (Bug#9642).
78 * buffer.c (Fmove_overlay): Delete an evaporating overlay
79 if it becomes empty after its bounds are adjusted to fit within
80 its buffer. Without this fix, in a nonempty buffer (let ((o
81 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
82 yields an empty overlay that has the evaporate property, which is
83 not supposed to happen.
84
1068fe4d
PE
85 Fix minor GTK3 problems found by static checking.
86 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
87 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
88 (struct _EmacsFixedClass, emacs_fixed_get_type):
89 Move decls here from emacsgtkfixed.h, since they needn't be public.
90 (emacs_fixed_get_type): Now static.
91 (emacs_fixed_class_init): Omit unused local.
92 (emacs_fixed_child_type): Remove; unused.
93 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
94 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
95 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
96 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
97 (EMACS_FIXED_GET_CLASS): Remove; unused.
98 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
99
888bec30
PE
100 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
101 Problem reported by Juanma Barranquero for Windows -Wunused-function.
102
de85e130
PE
1032012-04-22 Paul Eggert <eggert@cs.ucla.edu>
104
d0baac98
PE
105 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
106 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
107 (__malloc_size_t, __malloc_ptrdiff_t):
108 Remove. All uses removed, replaced by the definiens if needed,
109 since we can assume C89 or better now.
110 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
111 (protect_malloc_state, align, get_contiguous_space)
112 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
113 (malloc_atfork_handler_child, malloc_enable_thread)
114 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
115 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
116 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
117 (special_realloc, _realloc_internal_nolock, _realloc_internal)
118 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
119 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
120 Define using prototypes, not old style.
121 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
122 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
123 (align): Don't assume that signed integer overflow wraps around.
124 Omit unused local var.
125 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
126 (_free_internal_nolock, memalign, mallochook, reallochook):
127 Omit no-longer-needed casts.
128 (valloc): Use getpagesize, not __getpagesize.
129 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
130 (struct hdr): The 'magic' member is now size_t, not unsigned long.
131
de85e130
PE
132 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
133
dcbf5805
MA
1342012-04-22 Michael Albinus <michael.albinus@gmx.de>
135
136 Move functions from C to Lisp. Make non-blocking method calls
137 the default. Implement further D-Bus standard interfaces.
138
139 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
140 (QCdbus_request_name_allow_replacement)
141 (QCdbus_request_name_replace_existing)
142 (QCdbus_request_name_do_not_queue)
143 (QCdbus_request_name_reply_primary_owner)
144 (QCdbus_request_name_reply_in_queue)
145 (QCdbus_request_name_reply_exists)
146 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
147 (QCdbus_registered_serial, QCdbus_registered_method)
148 (QCdbus_registered_signal): New Lisp objects.
149 (XD_DEBUG_MESSAGE): Use sizeof.
150 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
151 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
152 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
153 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
154 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
155 (xd_signature, xd_append_arg): Allow float for integer types.
156 (xd_get_connection_references): New function.
157 (xd_get_connection_address): Rename from xd_initialize. Return
158 cached address.
159 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
160 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
161 level.
162 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
163 Return number of recounts.
164 (Fdbus_get_unique_name): Make stronger parameter check.
165 (Fdbus_message_internal): New defun.
166 (Fdbus_call_method, Fdbus_call_method_asynchronously)
167 (Fdbus_method_return_internal, Fdbus_method_error_internal)
168 (Fdbus_send_signal, Fdbus_register_service)
169 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
170 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
171 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
172 (Vdbus_compiled_version, Vdbus_runtime_version)
173 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
174 (Vdbus_message_type_method_return, Vdbus_message_type_error)
175 (Vdbus_message_type_signal): New defvars.
176 (Vdbus_registered_buses, Vdbus_registered_objects_table): Adapt
177 docstring.
178
52828e02
PE
1792012-04-22 Paul Eggert <eggert@cs.ucla.edu>
180
da05bc4c
PE
181 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
182 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
183 Do not assume ptrdiff_t is the same width as 'int'.
184
52828e02
PE
185 * alloc.c: Handle unusual debugging option combinations.
186 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
187 since the two debugging options are incompatible.
188 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
189 is defined.
190 (mem_init, mem_insert, mem_insert_fixup):
191 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
192 (NEED_MEM_INSERT): Remove; no longer needed.
193
f01769f9
LL
1942012-04-22 Leo Liu <sdl.web@gmail.com>
195
196 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
197
5790543d
PE
1982012-04-22 Paul Eggert <eggert@cs.ucla.edu>
199
200 * sysdep.c [__FreeBSD__]: Minor cleanups.
201 (list_system_processes, system_process_attributes) [__FreeBSD__]:
202 Use Emacs indenting style more consistently. Avoid some casts.
203 Use 'double' consistently rather than mixing 'float' and 'double'.
204
b91b7e4d
EW
2052012-04-21 Eduard Wiebe <usenet@pusto.de>
206
207 * sysdep.c (list_system_processes, system_process_attributes): Add
208 implementation for FreeBSD (Bug#5243).
209
6114eb15
AS
2102012-04-21 Andreas Schwab <schwab@linux-m68k.org>
211
212 * lisp.mk (lisp): Update.
213
2f38dff7
PE
2142012-04-20 Paul Eggert <eggert@cs.ucla.edu>
215
216 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
217 It is never used otherwise.
218
4ae29f89
SM
2192012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
220
221 * print.c (print_preprocess): Only check print_depth if print-circle
222 is nil.
223 (print_object): Check for cycles even when print-circle is nil and
224 print-gensym is t, but only check print_depth if print-circle is nil.
225
f30d612a
CY
2262012-04-20 Chong Yidong <cyd@gnu.org>
227
228 * process.c (wait_reading_process_output): If EIO occurs on a pty,
229 set the status to "failed" and ensure that sentinel is run.
230
c07a4c0b 2312012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
232
233 * process.c (Fset_process_inherit_coding_system_flag)
234 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 235 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 236
c07a4c0b 2372012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
238
239 * xdisp.c (string_buffer_position_lim): Limit starting position to
240 BEGV.
241 (set_cursor_from_row): If called for a mode-line or header-line
242 row, return zero immediately.
243 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
244 farther than the first row after the header line, if any.
245 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
246 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
247
c07a4c0b 2482012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 249
4ae29f89
SM
250 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
251 (bug#11238).
ad3a2b41 252
c07a4c0b 2532012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 2542012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
255
256 configure: new option --enable-gcc-warnings (Bug#11207)
257 * Makefile.in (C_WARNINGS_SWITCH): Remove.
258 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
259 (ALL_CFLAGS): Use new macros rather than old.
260 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
261 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
262 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
263 -Wunused-result, -Wunused-variable. This should go away once
264 the Emacs and Gnulib regex code is merged.
265 (xmalloc, xrealloc): Now static.
266
aba027e8
PE
2672012-04-17 Paul Eggert <eggert@cs.ucla.edu>
268
269 * dired.c (Fsystem_groups): Remove unused local.
270
e5a36063
GM
2712012-04-17 Glenn Morris <rgm@gnu.org>
272
273 * dired.c (Fsystem_users): Doc fix.
274
316411f0
DA
2752012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
276
277 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
278 (syms_of_dired): Add them.
279
9426aba4
PE
2802012-04-16 Paul Eggert <eggert@cs.ucla.edu>
281
b62a57be
PE
282 Fix minor alloc.c problems found by static checking.
283 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
284 New extern decls, to avoid calling undeclared functions.
285 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
286 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
287 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
288 (NEED_MEM_INSERT): New macro.
289 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 290 Remove one incorrect comment and fix another.
b62a57be 291
3539f31f
PE
292 Fix minor ralloc.c problems found by static checking.
293 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
294 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
295 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
296 (r_alloc_sbrk): Now static.
297
a041960a
PE
298 Improve ralloc.c interface checking.
299 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
300 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
301 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
302 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
303 [REL_ALLOC]: ... to here, to check interface.
304 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
305 Remove decls. This fixes an "It stinks!".
306
9426aba4
PE
307 * alloc.c (which_symbols): Fix alignment issue / type clash.
308
d55c12ed
AS
3092012-04-15 Andreas Schwab <schwab@linux-m68k.org>
310
311 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
312 (struct Lisp_Misc_Any): Likewise.
313 (struct Lisp_Free): Likewise.
314 * alloc.c (union aligned_Lisp_Symbol): Define.
315 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
316 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
317 (union aligned_Lisp_Misc): Define.
318 (MARKER_BLOCK_SIZE, struct marker_block): Use union
319 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 320 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 321
b948ce8b
PE
3222012-04-14 Paul Eggert <eggert@cs.ucla.edu>
323
324 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
325 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
326 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
327 * s/netbsd.h, s/sol2-6.h:
328 Remove definition of GC_MARK_STACK, since the default now works.
329 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
330 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
331 no longer the default.
332 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
333
35dc09a1 3342012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 335
35dc09a1
GM
336 * lread.c (lisp_file_lexically_bound_p):
337 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 338
35dc09a1
GM
3392012-04-14 Eli Zaretskii <eliz@gnu.org>
340
341 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
342 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
343
3442012-04-14 Jan Djärv <jan.h.d@swipnet.se>
345
346 * nsterm.m (constrainFrameRect): Always constrain when there is only
347 one screen (Bug#10962).
348
bcd86815
KB
3492012-04-13 Ken Brown <kbrown@cornell.edu>
350
351 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
352
c25df26e
RT
3532012-04-13 Reuben Thomas <rrt@sc3d.org>
354
355 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
356
0fc59f1e
DC
3572012-04-11 Daniel Colascione <dancol@dancol.org>
358
359 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
360 against is gone. It's better to use vfork now so that when Cygwin
361 gains a new, working vfork, we use it automatically (bug#10398).
362
de8c03dc
SM
3632012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
364
365 * window.c (save_window_save): Obey window-point-insertion-type.
366
2f097256
GM
3672012-04-11 Glenn Morris <rgm@gnu.org>
368
369 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
370
453b951e
SM
3712012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
372
373 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
374
75f1671a 3752012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
376
377 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
378 (force_quit_count): New var.
379 (handle_interrupt): Use it.
380
2a8ce227
JB
3812012-04-10 Juanma Barranquero <lekktu@gmail.com>
382
383 * w32.c (w32_delayed_load): Record the full path of the library
384 being loaded (bug#10424).
385
935396c0
GM
3862012-04-09 Glenn Morris <rgm@gnu.org>
387
05920a43
GM
388 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
389 not just in the obarray, before snarfing them. (Bug#11036)
390
935396c0
GM
391 * Makefile.in ($(leimdir)/leim-list.el):
392 Pass EMACS rather than BUILT_EMACS.
393
a18ecafa
TZ
3942012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
395
396 * process.c (make_process):
397 * process.h: Add integer `gnutls_handshakes_tried' member to
398 process struct.
399
6bbef4e5
JC
400 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
401 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
402
403 * gnutls.c (gnutls_log_function2i): Convenience log function.
404 (emacs_gnutls_read): Use new log functions,
405 `gnutls_handshakes_tried' process member, and
406 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
407 attempts per process (connection).
408
b4d3bc10
CY
4092012-04-09 Chong Yidong <cyd@gnu.org>
410
411 * eval.c (Fuser_variable_p, user_variable_p_eh)
412 (lisp_indirect_variable): Functions deleted.
413 (Fdefvar): Caller changed.
414
415 * callint.c (Finteractive, Fcall_interactively):
416 * minibuf.c (Fread_variable): Callers changed.
417
70f4d973
EZ
4182012-04-09 Eli Zaretskii <eliz@gnu.org>
419
420 * xdisp.c (set_cursor_from_row): If the display string appears in
421 the buffer at position that is closer to point than the position
422 after the display string, display the cursor on the first glyph of
423 the display string. Fixes cursor display when a 'display' text
424 property immediately follows invisible text. (Bug#11094)
425
cb3c2e3e
PE
4262012-04-09 Paul Eggert <eggert@cs.ucla.edu>
427
428 composite.c: use 'double' consistently
429 * composite.c (get_composition_id): Use 'double' consistently
430 instead of converting 'float' to 'double' and vice versa; this is
431 easier to understand and avoids a GCC warning.
432
fd06db5d
GM
4332012-04-09 Glenn Morris <rgm@gnu.org>
434
50fe702a
GM
435 * Makefile.in: Generate leim-list with bootstrap-emacs, in
436 preparation for dumping it with emacs. (Bug#4789)
437 (leimdir): New variable.
438 ($(leimdir)/leim-list.el): New rule.
439 (emacs$(EXEEXT)): Depend on leim-list.el.
440
fd06db5d
GM
441 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
442 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
443 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
444
55c131ee
AS
4452012-04-08 Andreas Schwab <schwab@linux-m68k.org>
446
447 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
448 proper alignment.
449
9209588f
JB
4502012-04-07 Juanma Barranquero <lekktu@gmail.com>
451
452 * xml.c (init_libxml2_functions) [WINDOWSNT]:
453 Remove unused local variable.
454
e3fb2efb
PE
4552012-04-07 Paul Eggert <eggert@cs.ucla.edu>
456
457 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
458 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
459 (mark_memory): Mark Lisp_Objects only if pointers might hide in
460 objects, as mark_maybe_pointer will catch them otherwise.
461 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
462 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
463
b5385551
PE
4642012-04-07 Paul Eggert <eggert@cs.ucla.edu>
465
466 Fix typo that broke non-Windows builds.
467 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
468
9078ead6
EZ
4692012-04-07 Eli Zaretskii <eliz@gnu.org>
470
471 Support building on MS-Windows with libxml2.
472
473 * makefile.w32-in (OBJ2): Add xml.$(O).
474 (GLOBAL_SOURCES): Add xml.c.
475 ($(BLD)/xml.$(O)): New dependency list.
476
477 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
478 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
479 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
480 [!WINDOWSNT]: New macros.
481 (init_libxml2_functions, libxml2_loaded_p): New functions.
482 (parse_region): Call fn_xmlCheckVersion instead of using the macro
483 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
484 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
485 Calls xmlCleanupParser only if libxml2 was loaded (or statically
486 linked in).
6bbef4e5
JC
487 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
488 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
489 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
490
491 * emacs.c: Don't include libxml/parser.h.
492 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
493 xmlCleanupParser directly.
494
495 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
496
3811fdf3
EZ
4972012-04-07 Eli Zaretskii <eliz@gnu.org>
498
499 * indent.c (Fvertical_motion): If there is a display string at
500 point, use it.vpos to compute how many lines to backtrack after
501 move_it_to point. (Bug#11133)
502
2f8e16b2
EZ
5032012-04-06 Eli Zaretskii <eliz@gnu.org>
504
505 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
506 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
507 about subtle differences between FETCH_CHAR* and STRING_CHAR*
508 macros related to unification of CJK characters. For the details,
509 see the discussion following the message here:
510 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
511
3d439cd1
CY
5122012-04-04 Chong Yidong <cyd@gnu.org>
513
514 * keyboard.c (Vdelayed_warnings_list): Doc fix.
515
8bc53d00
EZ
5162012-04-01 Eli Zaretskii <eliz@gnu.org>
517
518 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
519 instead of alloca. (Bug#11138)
520
3b0512a3
AS
5212012-04-01 Andreas Schwab <schwab@linux-m68k.org>
522
523 * w32menu.c (is_simple_dialog): Properly check lisp types.
524 (Bug#11141)
525
8427ddd2
EZ
5262012-03-31 Eli Zaretskii <eliz@gnu.org>
527
979022ef
EZ
528 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
529 position we get to after a call to move_it_to fails the
530 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
531 only if we wind up in a string from display property. (Bug#11063)
532
a6b1c7cc
EZ
533 * window.c (Fdelete_other_windows_internal): Invalidate the row
534 and column information about mouse highlight, so that redisplay
535 restores it after reallocating the glyph matrices. (Bug#7464)
536
8427ddd2
EZ
537 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
538 string comes from a `display' text property, use the buffer
539 position of that property as if we actually saw that position in
540 the row's glyphs.
697ba24b
EZ
541 (move_it_by_lines): Remove the assertion that
542 "it->current_x == 0 && it->hpos == 0" which can be legitimately
543 violated when there's a before-string at the beginning of a line.
544 (Bug#11063)
8427ddd2 545
65a0a738
EZ
5462012-03-30 Eli Zaretskii <eliz@gnu.org>
547
548 * xdisp.c (append_space_for_newline): If the default face was
549 remapped, use the remapped face for the appended newline.
550 (extend_face_to_end_of_line): Use the remapped default face for
551 extending the face to the end of the line.
552 (display_line): Call extend_face_to_end_of_line when the default
553 face was remapped. (Bug#11068)
554
581355cc
EZ
5552012-03-29 Eli Zaretskii <eliz@gnu.org>
556
557 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
558
e8fc049f
SM
5592012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
560
561 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
562
4fb9a543
GM
5632012-03-27 Glenn Morris <rgm@gnu.org>
564
565 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
566 Doc fixes.
567
679910f1
KH
5682012-03-26 Kenichi Handa <handa@m17n.org>
569
570 * dispextern.h (struct glyph): Fix previous change. Change the
571 bit length of glyphless.ch to 25 (Bug#11082).
572
90d49b7f
CY
5732012-03-26 Chong Yidong <cyd@gnu.org>
574
575 * keyboard.c (Vselection_inhibit_update_commands): New variable.
576 (command_loop_1): Use it; inhibit selection update for
577 handle-select-window too (Bug#8996).
578
f514f6f0
FP
5792012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
580
e8fc049f 581 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 582
bf43fa51
KH
5832012-03-25 Kenichi Handa <handa@m17n.org>
584
585 * dispextern.h (struct glyph): Change the bit length of
586 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
587
8a0c01dd
EZ
5882012-03-24 Eli Zaretskii <eliz@gnu.org>
589
590 * s/ms-w32.h (tzname): Include time.h before redirecting to
591 _tzname. Fixes the MSVC build. (Bug#9960)
592
7d1c3a76
AS
5932012-03-24 Andreas Schwab <schwab@linux-m68k.org>
594
8ed79523
AS
595 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
596 characters.
597
7d1c3a76
AS
598 * xterm.c (XTread_socket): Only modify handling_signal if
599 !SYNC_INPUT. (Bug#11080)
600
e99a9b8b
EZ
6012012-03-23 Eli Zaretskii <eliz@gnu.org>
602
603 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
604 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
605 when fetching a multibyte character consumes more bytes than
606 CHAR_BYTES returns, due to unification of CJK characters in
607 string_char. (Bug#11073)
608
5063c0e1
TN
6092012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
610
611 * process.c (wait_reading_process_output): Handle pty disconnect
612 by refraining from sending oneself a SIGCHLD (bug#10933).
613
9f851fbd
CY
6142012-03-22 Chong Yidong <cyd@gnu.org>
615
616 * dispextern.h (struct it): New member string_from_prefix_prop_p.
617
5063c0e1 618 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
619 Mark string as coming from a prefix property.
620 (handle_face_prop): Use default face for prefix strings (Bug#4281).
621 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
622
fb5b8aca
CY
6232012-03-21 Chong Yidong <cyd@gnu.org>
624
625 * xfaces.c (Vface_remapping_alist): Doc fix.
626
62356a1b
EZ
6272012-03-20 Eli Zaretskii <eliz@gnu.org>
628
629 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
630 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
631 Doc fixes.
62356a1b 632
025de85b
CY
6332012-03-20 Chong Yidong <cyd@gnu.org>
634
635 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
636 to reflect default non-nil value of redisplay-dont-pause.
637
4827f94e
KH
6382012-03-19 Kenichi Handa <handa@m17n.org>
639
640 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
641 it fit in a valid range (Bug#11003).
642
e50a24a2
EZ
6432012-03-18 Eli Zaretskii <eliz@gnu.org>
644
645 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
646 that is not from display property, accept the row as a "cursor
647 row" if one of the string's character has a non-nil `cursor'
648 property. Fixes cursor positioning when there are newlines in
649 overlay strings, e.g. in icomplete.el. (Bug#11035)
650
9af5ed87
PE
6512012-03-12 Paul Eggert <eggert@cs.ucla.edu>
652
653 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
654
d1f55f16
CY
6552012-03-12 Chong Yidong <cyd@gnu.org>
656
657 * eval.c (inhibit_lisp_code): Rename from
658 inhibit_window_configuration_change_hook; move from window.c.
659
660 * xfns.c (unwind_create_frame_1, Fx_create_frame):
661 * window.c (run_window_configuration_change_hook)
662 (syms_of_window): Callers changed.
663
66c5eebd
CY
6642012-03-11 Chong Yidong <cyd@gnu.org>
665
413df973
CY
666 * keymap.c (Fkey_description): Doc fix (Bug#9700).
667
66c5eebd
CY
668 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
669
1de11f56
CY
6702012-03-10 Chong Yidong <cyd@gnu.org>
671
672 * frame.c (other_visible_frames): Don't assume the selected frame
673 is visible (Bug#10955).
674
cae07000
SM
6752012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
676
677 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
678
89c94350
JD
6792012-03-08 Jan Djärv <jan.h.d@swipnet.se>
680
681 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
682 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
683 zero (Bug#10954).
684
999dd333
GM
6852012-03-03 Glenn Morris <rgm@gnu.org>
686
01a6dcc8 687 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 688
de0100f2
EZ
6892012-03-02 Eli Zaretskii <eliz@gnu.org>
690
691 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
692 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
693 (redisplay_window, next_element_from_string): Fix typos in
694 comments.
3e441275
EZ
695 (redisplay_window): Pass to move_it_vertically the margin in
696 pixels, not in screen lines.
de0100f2 697
96a72ee9
GM
6982012-03-02 Glenn Morris <rgm@gnu.org>
699
700 * buffer.c (buffer-list-update-hook): Doc fix.
701
312508d7
EZ
7022012-02-29 Eli Zaretskii <eliz@gnu.org>
703
704 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
705 push_it before setting up the iterator for the first overlay
706 string, even if we have an empty string loaded.
707 (next_overlay_string): If there's an empty string on the iterator
708 stack, pop the stack. (Bug#10903)
709
27f3c637
PE
7102012-02-25 Paul Eggert <eggert@cs.ucla.edu>
711
712 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
713 Suggested by Stefan Monnier in
714 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
715 * alloc.c (widen_to_Lisp_Object): New static function.
716 (mark_memory): Also mark Lisp_Objects by fetching pointer words
717 and widening them to Lisp_Objects. This would work even if
718 USE_LSB_TAG is defined and wide integers are used, which might
719 happen in a future version of Emacs.
720
3c9dfce6
CY
7212012-02-25 Chong Yidong <cyd@gnu.org>
722
fa74b241
CY
723 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
724 Doc fix.
725
3c9dfce6
CY
726 * xselect.c (Fx_selection_exists_p): Doc fix.
727 (x_clipboard_manager_save_all): Print an informative message
728 before saving to clipboard manager.
729
9486df08
CY
7302012-02-24 Chong Yidong <cyd@gnu.org>
731
732 * keyboard.c (process_special_events): Handle all X selection
733 requests in kbd_buffer, not just the next one (Bug#8869).
734
f01d3321
CY
7352012-02-23 Chong Yidong <cyd@gnu.org>
736
737 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
738 call when setting menu-bar-lines and tool-bar-lines parameters.
739 (unwind_create_frame_1): New helper function.
740
741 * window.c (inhibit_window_configuration_change_hook): New var.
742 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 743 (syms_of_window): Initialize it.
f01d3321 744
86b847b6
CY
7452012-02-22 Chong Yidong <cyd@gnu.org>
746
747 * xterm.c (x_draw_image_relief): Add missing type check for
748 Vtool_bar_button_margin (Bug#10743).
749
a59225b1
CY
7502012-02-21 Chong Yidong <cyd@gnu.org>
751
752 * fileio.c (Vfile_name_handler_alist): Doc fix.
753
754 * buffer.c (Fget_file_buffer): Protect against invalid file
755 handler return value.
756
310f5bd4
PE
7572012-02-20 Paul Eggert <eggert@cs.ucla.edu>
758
cb3a28cc
PE
759 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
760 when computing $valmask.
761
310f5bd4
PE
762 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
763 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
764 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
765 It's useless in that case, and it can cause problems on hosts
766 that allocate halves of EMACS_INT values separately.
767 Reported by Dan Horák. Diagnosed by Andreas Schwab in
768 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
769 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
770 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
771 it avoids undefined behavior on hosts where shifting right by more
772 than the word width has undefined behavior.
773
2375c96a
CY
7742012-02-19 Chong Yidong <cyd@gnu.org>
775
776 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
777 (Funhandled_file_name_directory, Ffile_name_as_directory)
778 (Fdirectory_file_name, Fexpand_file_name)
779 (Fsubstitute_in_file_name): Protect against invalid file handler
780 return values (Bug#10845).
781
3eb49e71
EZ
7822012-02-18 Eli Zaretskii <eliz@gnu.org>
783
784 * .gdbinit (pitx): Fix incorrect references to fields of the
785 iterator stack.
786
7b926f3f
CY
7872012-02-17 Chong Yidong <cyd@gnu.org>
788
789 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
790
11273115
PE
7912012-02-15 Paul Eggert <eggert@cs.ucla.edu>
792
793 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
794 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
795
c3a70e2b
CY
7962012-02-15 Chong Yidong <cyd@gnu.org>
797
798 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
799 marked as special. Also, starting docstrings with * is obsolete.
800
0ca43699
AS
8012012-02-13 Andreas Schwab <schwab@linux-m68k.org>
802
803 * gnutls.c (emacs_gnutls_write): Fix last change.
804
2e8f3c56
LI
8052012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
806
807 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
808 send_process.
809
af70074f
SM
8102012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
811
812 * keymap.c (Fsingle_key_description): Handle char ranges.
813
95986d52
CY
8142012-02-12 Chong Yidong <cyd@gnu.org>
815
afd83bd1
CY
816 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
817 as that creates a dangerous corner case.
818
95986d52
CY
819 * window.c (Fdelete_window_internal): Invalidate the mouse
820 highlight (Bug#9904).
821
bd7da63e
GM
8222012-02-12 Glenn Morris <rgm@gnu.org>
823
824 * xselect.c (Fx_own_selection_internal)
825 (Fx_get_selection_internal, Fx_disown_selection_internal)
826 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
827 * nsselect.m (Fx_own_selection_internal)
828 (Fx_disown_selection_internal, Fx_selection_exists_p)
829 (Fx_selection_owner_p, Fx_get_selection_internal):
830 Sync docs and argument specs with the xselect.c versions.
831
77abcbc2
LI
8322012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
833
834 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
835
90b671e2
EZ
8362012-02-11 Eli Zaretskii <eliz@gnu.org>
837
1c0ca0b7
EZ
838 * w32select.c (Fx_selection_exists_p): Sync doc string and
839 argument list with xselect.c. (Bug#10783)
840
841 * w16select.c (Fx_selection_exists_p): Sync doc string and
842 argument list with xselect.c. (Bug#10783)
90b671e2 843
49241268
GM
8442012-02-10 Glenn Morris <rgm@gnu.org>
845
846 * fns.c (Fsecure_hash): Doc fix.
847
f998bbe7 8482012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
849
850 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
851
0992bd9c
CY
8522012-02-07 Chong Yidong <cyd@gnu.org>
853
854 * buffer.c (Fbuffer_local_variables)
855 (buffer_lisp_local_variables): Handle unbound vars correctly;
856 don't let Qunbound leak into Lisp.
857
af008560
GM
8582012-02-07 Glenn Morris <rgm@gnu.org>
859
dd605cc4
GM
860 * image.c (Fimagemagick_types): Doc fix.
861
af008560
GM
862 * image.c (imagemagick-render-type): Change it from a lisp object
863 to an integer. Move the doc here from the lisp manual.
864 Treat all values not equal to 0 the same.
865
1449fa1d
CY
8662012-02-06 Chong Yidong <cyd@gnu.org>
867
868 * doc.c (store_function_docstring): Avoid applying docstring of
869 alias to base function (Bug#2603).
870
3723ec07
AS
8712012-02-04 Andreas Schwab <schwab@linux-m68k.org>
872
873 * .gdbinit (pp1, pv1): Remove redundant defines.
874 (pr): Use pp.
875
79c1cc1e
CY
8762012-02-04 Chong Yidong <cyd@gnu.org>
877
878 * nsterm.m: Declare a global (Bug#10694).
879
d7f29f8e
EZ
8802012-02-04 Eli Zaretskii <eliz@gnu.org>
881
cae07000
SM
882 * w32.c (get_emacs_configuration_options):
883 Include --enable-checking, if specified, in the return value.
d7f29f8e 884
3b95a6f9
MR
8852012-02-04 Martin Rudalics <rudalics@gmx.at>
886
887 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
888 after rounding frame sizes. (Bug#9723)
889
d6fa96a6
EZ
8902012-02-04 Eli Zaretskii <eliz@gnu.org>
891
892 * keyboard.c (adjust_point_for_property): Don't position point
893 before BEGV. (Bug#10696)
894
df0b2940
PE
8952012-02-03 Paul Eggert <eggert@cs.ucla.edu>
896
897 Handle overflow when computing char display width (Bug#9496).
898 * character.c (char_width): Return EMACS_INT, not int.
899 (char_width, c_string_width): Check for overflow when
900 computing the width; this is possible now that individual
901 characters can have unbounded width. Problem introduced
902 by merge from Emacs 23 on 2012-01-19.
903
6bee44d6
MA
9042012-02-02 Michael Albinus <michael.albinus@gmx.de>
905
906 * dbusbind.c (Fdbus_register_method): Mention the return value
907 :ignore in the docstring.
908
44f92739
GM
9092012-02-02 Glenn Morris <rgm@gnu.org>
910
1b9f60cc
GM
911 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
912
44f92739
GM
913 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
914 Unconditionally set to t. (Bug#10673)
915 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
916 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
917 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
918
c5d3843c
KH
9192012-02-02 Kenichi Handa <handa@m17n.org>
920
921 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
922 0, do not call append_composite_glyph.
923
159462d4 9242012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
925
926 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
927 NULL (Bug#6988).
928 (x_produce_glyphs): If the component of a composition is a null
929 string, set it->pixel_width to 1 to avoid zero-width glyph.
930
78cef877
EZ
9312012-02-01 Eli Zaretskii <eliz@gnu.org>
932
933 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
934 first 2 arguments are identical. This makes inserting large
935 output from a subprocess an order of magnitude faster on
936 MS-Windows, where all sbrk'ed memory is always contiguous.
937
97897668
GM
9382012-01-31 Glenn Morris <rgm@gnu.org>
939
940 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 941 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
942 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
943
31fd3586
GM
9442012-01-29 Glenn Morris <rgm@gnu.org>
945
946 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
947
0e24a8b2
CY
9482012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
949
950 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
951
cc0adcb0
CY
9522012-01-28 Chong Yidong <cyd@gnu.org>
953
954 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
955
acc28cb9
CY
9562012-01-26 Chong Yidong <cyd@gnu.org>
957
9c69cfb7
CY
958 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
959
acc28cb9
CY
960 * search.c (Fsearch_forward, Fsearch_backward): Document negative
961 repeat counts (Bug#10507).
962
48da7392
GM
9632012-01-26 Glenn Morris <rgm@gnu.org>
964
965 * lread.c (syms_of_lread): Doc fix.
966
14af5f7f
CY
9672012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
968
969 * coding.c (encode_designation_at_bol): Change return value to
970 EMACS_INT.
971
0b21c100
CY
9722012-01-25 Chong Yidong <cyd@gnu.org>
973
974 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
975
3c2907f7
CY
9762012-01-21 Chong Yidong <cyd@gnu.org>
977
978 * floatfns.c (Fcopysign): Make the second argument non-optional,
979 since nil is not allowed anyway.
980
959ad23f
AS
9812012-01-21 Andreas Schwab <schwab@linux-m68k.org>
982
983 * process.c (read_process_output): Use p instead of XPROCESS (proc).
984 (send_process): Likewise.
985
34a02f46
MR
9862012-01-19 Martin Rudalics <rudalics@gmx.at>
987
988 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
989 (Vwindow_persistent_parameters): Do not use Qstate.
990 Rewrite doc-strings.
34a02f46 991
1259009a 9922012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
993
994 * character.c (char_width): New function.
70d4fdf6
GM
995 (Fchar_width, c_string_width, lisp_string_width):
996 Use char_width (Bug#9496).
25ed9e61 997
6a6ee00d
MR
9982012-01-16 Martin Rudalics <rudalics@gmx.at>
999
1000 * window.c (Vwindow_persistent_parameters): New variable.
1001 (Fset_window_configuration, save_window_save): Handle persistent
1002 window parameters.
1003
c85efaf7
EZ
10042012-01-14 Eli Zaretskii <eliz@gnu.org>
1005
1006 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1007 thrashing the stack of the thread. (Bug#9087)
1008
5944709e
PE
10092012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1010
1011 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1012
e71f5d99
EZ
10132012-01-11 Eli Zaretskii <eliz@gnu.org>
1014
1015 * xdisp.c (rows_from_pos_range): Handle the case where the
1016 highlight ends on a newline. (Bug#10464)
1017 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1018 he end column for display of highlight that ends on a newline
1019 before a R2L line.
1020
ce316182
GM
10212012-01-11 Glenn Morris <rgm@gnu.org>
1022
1023 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1024 from load-path also when installation-directory is nil. (Bug#10208)
1025
5b43da69
GM
10262012-01-10 Glenn Morris <rgm@gnu.org>
1027
74cc8ff9
GM
1028 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1029
7d8d6e4e
GM
1030 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1031 Update template values to be closer to their typical values these days.
5b43da69 1032
a0db8d43
EZ
10332012-01-09 Eli Zaretskii <eliz@gnu.org>
1034
1035 * xdisp.c (rows_from_pos_range): Accept additional argument
1036 DISP_STRING, and accept any glyph in a row whose object is that
1037 string as eligible for mouse highlight. Fixes mouse highlight of
1038 display strings from overlays. (Bug#10464)
1039
9a0115ab 10402012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 1041
b9110d6a 1042 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
1043 * fileio.c (auto_saving_dir_umask): New static var.
1044 (Fmake_directory_internal): Use it.
1045 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1046 creating the directory. The old code temporarily assigns
1047 too-generous permissions to the directory.
1048 (do_auto_save_eh): Clear it.
b9110d6a 1049 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
1050 that the var is always cleared.
1051
6c1bd3f3
EZ
10522012-01-07 Eli Zaretskii <eliz@gnu.org>
1053
1054 * search.c (scan_buffer): Pass character positions to
1055 know_region_cache, not byte positions. (Bug#6540)
1056
069d2b50
L
10572012-01-07 LynX <_LynX@bk.ru> (tiny change)
1058
1059 * w32.c (sys_rename): Report EXDEV when rename of a directory
1060 fails because the target is on another logical disk. (Bug#10284)
1061
75bf0d33
DB
10622012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1063
1064 * xterm.c (x_embed_request_focus): New function.
1065
1066 * xterm.h: Add prototype.
1067
1068 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1069
1c6e5a32
GM
10702012-01-05 Glenn Morris <rgm@gnu.org>
1071
1072 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1073
651e947e
EZ
10742012-01-01 Eli Zaretskii <eliz@gnu.org>
1075
1076 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1077 Load gnutls_transport_set_lowat only if GnuTLS version is below
1078 2.11.1.
1079 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1080 GnuTLS versions below 2.11.1.
1081
3778cdd8
AL
10822011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1083
1084 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1085 to the doc string advising against its use for altering the way
1086 windows are scrolled.
1087
0e5317f7
KH
10882011-12-28 Kenichi Handa <handa@m17n.org>
1089
1090 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1091 coding-system ASCII compatible only when it does not produce BOM
1092 on encoding (Bug#10383).
1093
93d5ca1f
JD
10942011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1095
1096 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1097 can scroll.
1098 (create_and_show_popup_menu): Always use menu_position_func for
1099 Gtk3 (Bug#10361).
1100
ca22b785
AS
11012011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1102
1103 * callint.c (Fcall_interactively): Don't truncate prompt string.
1104
d048e1e6
EZ
11052011-12-23 Eli Zaretskii <eliz@gnu.org>
1106
1107 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1108 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1109 resumed from there (after widening). (Bug#10360)
d048e1e6 1110
5ccaba1f
JD
11112011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1112
1113 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1114
204ee57f
JD
11152011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1116
b81d40f0
JB
1117 * nsterm.m (x_free_frame_resources):
1118 Release f->output_data.ns->miniimage.
204ee57f
JD
1119 (ns_index_color): Fix indentation. Do not retain
1120 color_table->colors[i].
1121
1122 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1123 before returning.
1124
1125 * nsfns.m (x_set_background_color): Assign return value from
1126 ns_index_color to face-background instead of NSColor*.
1127 (ns_implicitly_set_icon_type): Fix indentation.
1128 Change assignment in for loop to comparison.
1129
1130 * emacs.c (ns_pool): New variable.
1131 (main): Assign ns_pool.
1132 (Fkill_emacs): Call ns_release_autorelease_pool.
1133
1134 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1135 autorelease fdesc, release fdAttrs and tdict.
1136 (ns_get_covering_families): Release charset.
1137 (ns_findfonts): Release NSFontDescriptor created with new.
1138 (ns_uni_to_glyphs): Fix indentation.
1139 (setString): Release attrStr before assigning new value.
1140
c803b2b7
JD
11412011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1142
678f4426
JD
1143 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1144 and NS_IMPL_COCOA.
1145 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1146 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1147
cd394be1 11482011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1149
5fecd5fc
JD
1150 * nsterm.m (ns_term_init): Subscribe for notifications
1151 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1152 to method trackingNotification in EmacsMenu.
1153
1154 * nsmenu.m (trackingMenu): New variable.
3771cb17 1155 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1156 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1157 from Aquamacs (Bug#7030).
678f4426
JD
1158
11592011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1160
c803b2b7
JD
1161 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1162 (symbol_to_nsstring): Fix indentation.
1163 (ns_symbol_to_pb): New function.
cae07000
SM
1164 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1165 (Fns_rotate_cut_buffers_internal): Remove.
1166 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1167 Fns_store_cut_buffer_internal.
1168 (ns_get_foreign_selection, Fx_own_selection_internal)
1169 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1170 (Fns_get_selection_internal, Fns_store_selection_internal):
1171 Use ns_symbol_to_pb and check if return value is nil.
1172 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1173 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1174 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1175 renamed to Sns_store_selection_internal.
1176 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1177 and remove this function.
1178 (ns_handle_selection_clear): Remove, never used.
1179 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1180 here.
1181
e1b01a3a
KB
11822011-12-17 Ken Brown <kbrown@cornell.edu>
1183
1184 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1185 GID is unknown (Bug#10257).
1186
2adb6e85
PE
11872011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1188
1189 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1190 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1191 which caused a build failure on GNU/Linux IA-64. This problem was
1192 introduced by my 2011-10-07 patch.
1193
d1d7b339
JL
11942011-12-15 Juri Linkov <juri@jurta.org>
1195
1196 * image.c (imagemagick_error): New function. (Bug#10112)
1197 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1198 Use `imagemagick_error' where ImageMagick functions return
1199 `MagickFalse'.
1200 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1201 proper order.
1202
100d5755
KH
12032011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1204
1205 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1206 fill background (Bug#8992).
1207
454592a6
MR
12082011-12-13 Martin Rudalics <rudalics@gmx.at>
1209
1210 * window.c (Vwindow_combination_resize)
1211 (Vwindow_combination_limit): Use t instead of non-nil in
1212 doc-strings.
61d4b438
MR
1213 (Vrecenter_redisplay): Add first sentence of doc-string on
1214 separate line.
53524d93 1215 (Frecenter): Fix doc-string typo.
454592a6 1216
3633e3aa
KH
12172011-12-11 Kenichi Handa <handa@m17n.org>
1218
1219 * coding.c (Funencodable_char_position): Pay attention to the
1220 buffer text relocation (Bug#9389).
1221
7b9d523a
JD
12222011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1223
1224 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1225 gtk_init (Bug#10100).
1226
b73189c6
EZ
12272011-12-10 Eli Zaretskii <eliz@gnu.org>
1228
1229 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1230 IT->string is nil. (Bug#10263)
1231
f7dfe5d6
JD
12322011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1233
83faebb4
JD
1234 * nsterm.h (x_free_frame_resources): Declare.
1235
f7dfe5d6
JD
1236 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1237 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1238
1239 * nsterm.h (ns_get_defaults_value): Declare.
1240
1241 * nsterm.m (ns_default): Call ns_get_defaults_value.
1242
7cd4e72c
EZ
12432011-12-09 Eli Zaretskii <eliz@gnu.org>
1244
1245 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1246 (Bug#10170)
1247
b34d7317
YM
12482011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1249
1250 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1251 that where the value of an _OBJC_* symbol points to is in the .bss
1252 section (Bug#10240).
1253
76470ad1
KH
12542011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1255
1256 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1257 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1258
745fff94
KH
12592011-12-08 Kenichi Handa <handa@m17n.org>
1260
1261 * ftfont.c (get_adstyle_property): Fix previous change
1262 (Bug#10233).
1263
6e44397c
JB
12642011-12-07 Juanma Barranquero <lekktu@gmail.com>
1265
1266 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1267 dirs from the default value of EMACSLOADPATH (bug#10208).
1268
7efa6272
GM
12692011-12-07 Glenn Morris <rgm@gnu.org>
1270
1271 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1272 installation and source directories as well. (Bug#10208)
1273
f6fc4d87
CY
12742011-12-06 Chong Yidong <cyd@gnu.org>
1275
1276 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1277
2bf26180
GM
12782011-12-06 Glenn Morris <rgm@gnu.org>
1279
1280 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1281 as an error, not just -1. (Bug#10217)
1282
3a6ad4f0
CY
12832011-12-05 Chong Yidong <cyd@gnu.org>
1284
1285 * keyboard.c (process_special_events): New function.
1286 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1287
75a3b399
PE
12882011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1289
1290 * coding.c (encode_designation_at_bol): Don't use uninitialized
1291 local variable (Bug#9318).
1292
c3c9e25e
KH
12932011-12-05 Kenichi Handa <handa@m17n.org>
1294
1295 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1296 return Qnil (Bug#8046, Bug#10193).
1297
5eb05ea3
KH
12982011-12-05 Kenichi Handa <handa@m17n.org>
1299
1300 * coding.c (encode_designation_at_bol): New args charbuf_end and
1301 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1302 (coding_set_source): Return how many bytes coding->source was
1303 relocated.
1304 (coding_set_destination): Return how many bytes
1305 coding->destination was relocated.
1306 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1307 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1308
13092011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1310
1311 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1312 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1313 macro (Bug#9318).
1314
13152011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1316
1317 The following changes are to fix Bug#9318.
1318
a79703f5 1319 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1320 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1321 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1322 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1323
7dbda6df
JB
13242011-12-05 Juanma Barranquero <lekktu@gmail.com>
1325
1326 * lisp.h (process_quit_flag): Fix external declaration.
1327
6d5eb5b0
SM
13282011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1329
1330 Don't macro-inline non-performance-critical code.
1331 * eval.c (process_quit_flag): New function.
1332 * lisp.h (QUIT): Use it.
1333
a0c3fad0
JD
13342011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1335
1336 * nsfns.m (get_geometry_from_preferences): New function.
1337 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1338
6c07aac2
AS
13392011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1340
1341 * emacs.c (Qkill_emacs): Define.
1342 (syms_of_emacs): Initialize it.
1343 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1344 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1345 (quit_throw_to_read_char): Add parameter `from_signal'.
1346 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1347 * lisp.h (QUIT): Call Fkill_emacs if requested.
1348
c052ead4
JD
13492011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1350
1351 * widget.c (update_wm_hints): Return if wmshell is null.
1352 (widget_update_wm_size_hints): New function.
1353
1354 * widget.h (widget_update_wm_size_hints): Declare.
1355
1356 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1357 widget_update_wm_size_hints (Bug#10104).
1358
9e49252b
EZ
13592011-12-03 Eli Zaretskii <eliz@gnu.org>
1360
1361 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1362 before a newline, prepare the bidi iterator for consuming the
1363 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1364 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1365
02b16839
JL
13662011-12-02 Juri Linkov <juri@jurta.org>
1367
1368 * search.c (Fword_search_regexp): New Lisp function created from
1369 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1370 (Fword_search_backward, Fword_search_forward)
1371 (Fword_search_backward_lax, Fword_search_forward_lax):
1372 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1373 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1374
0068070e
SM
13752011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1376
1377 * fileio.c (Finsert_file_contents): Move after-change-function call
1378 to before the "handled:" label, since all "goto handled" appear in
1379 cases where the *-change-functions have already been properly called
1380 (bug#10117).
1381
3360a3fc
AS
13822011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1383
1384 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1385 waiting for input. (Bug#10169)
1386
73d6c093
EZ
13872011-11-30 Eli Zaretskii <eliz@gnu.org>
1388
1389 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1390 verifies glyph row's hash code--we have just reallocated the
1391 glyphs, so their contents can be complete garbage. (Bug#10164)
1392
febe6bea
JB
13932011-11-30 Juanma Barranquero <lekktu@gmail.com>
1394
1395 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1396
801a4313
EZ
13972011-11-30 Eli Zaretskii <eliz@gnu.org>
1398
1399 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1400 attributes are tested _before_ calling verify_row_hash, to protect
1401 against GCC re-ordering of the tests. (Bug#10164)
1402
2b56b87e
JD
14032011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1404
1405 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1406
1407 * xterm.c (handle_one_xevent): Only set async_visible and friends
1408 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1409 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1410 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1411
dbf31225
PE
14122011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1413
1414 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1415 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1416 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1417 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1418 All uses changed to use GCPRO1 etc.
1419 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1420 Revert to old implementation (i.e., before 2011-03-11).
1421
1305621b
YM
14222011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1423
1424 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1425 of scroll runs so as to avoid assigning disabled bogus rows and
1426 unnecessary graphics copy operations.
1427
8c9afb46
EZ
14282011-11-27 Eli Zaretskii <eliz@gnu.org>
1429
1430 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1431 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1432 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1433 (malloc, free, realloc, calloc): Redirect to e_* only when
1434 compiling Emacs.
1435
1436 * lisp.h (GCTYPEBITS): Move before first use.
1437 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1438 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1439 this macro definition.
1440
1441 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1442 _MSC_VER.
1443
54e9e3bf
JD
14442011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1445
6d5eb5b0
SM
1446 * gtkutil.c (xg_create_frame_widgets):
1447 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1448 present with Gtk+ 2.0.
1449
83aca1cb
PE
14502011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1451
1452 * fileio.c (Finsert_file_contents): Undo previous change; see
1453 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1454
5b76caa4
PE
14552011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1456
1457 Rename locals to avoid shadowing.
1458 * fileio.c (Finsert_file_contents):
1459 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1460 * process.c (wait_reading_process_output):
1461 Rename inner 'proc' to 'p' to avoid shadowing.
1462 Indent for consistency with usual Emacs style.
1463
8c535114
EZ
14642011-11-25 Eli Zaretskii <eliz@gnu.org>
1465
1466 * xdisp.c (redisplay_window): If cursor row is not fully visible
1467 after recentering, and scroll-conservatively is set to a large
1468 number, scroll window by a few more lines to make the cursor fully
1469 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1470 (start_display): Don't move to the next line if the display should
1471 start at a newline that is part of a display vector or an overlay
1472 string. (Bug#10119)
8c535114 1473
fa4fdb5c
JL
14742011-11-24 Juri Linkov <juri@jurta.org>
1475
1476 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1477 after the `MagickPingImage' call. (Bug#10112)
1478
90ec88df
CY
14792011-11-23 Chong Yidong <cyd@gnu.org>
1480
1481 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1482
56e2e794
MR
14832011-11-23 Martin Rudalics <rudalics@gmx.at>
1484
1485 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1486 making another buffer current. (Bug#10114)
1487
b6e64c41
GM
14882011-11-23 Glenn Morris <rgm@gnu.org>
1489
1490 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1491
6b21de18
CY
14922011-11-23 Chong Yidong <cyd@gnu.org>
1493
1494 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1495 using it (Bug#5984).
1496
b12cd789
EZ
14972011-11-22 Eli Zaretskii <eliz@gnu.org>
1498
1499 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1500 and header-lines, as they don't have one computed for them.
1501 (Bug#10098)
1502
1503 * .gdbinit (prow): Make displayed values more self-explaining.
1504 Add row's hash code.
1505
261b6fd4
LMI
15062011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1507
1508 * process.c (wait_reading_process_output): Fix asynchrounous
1509 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1510 (wait_reading_process_output): Add comment and URL.
261b6fd4 1511
e7cfd277
JD
15122011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1513
1514 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1515
a9b9b7f5
CY
15162011-11-21 Chong Yidong <cyd@gnu.org>
1517
1518 * window.c (Fnext_window, Fprevious_window): Doc fix.
1519
b0d15b4f
SM
15202011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1521
1522 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1523
fe7a3057
JB
15242011-11-20 Juanma Barranquero <lekktu@gmail.com>
1525
1526 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1527
d2999b1a
MR
15282011-11-20 Martin Rudalics <rudalics@gmx.at>
1529
1530 * window.c (Fset_window_combination_limit): Rename argument
1531 STATUS to LIMIT.
1532 (Vwindow_combination_limit): Remove "status" from doc-string.
1533
d5ff9cd0
AS
15342011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1535
1536 * m/ibms390.h: Remove.
1537 * m/ibms390x.h: Don't include "ibms390.h".
1538
a5bb9bd3
SM
15392011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1540
1541 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1542 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1543
cd1181db
JB
15442011-11-20 Juanma Barranquero <lekktu@gmail.com>
1545
1546 * casetab.c (Fset_case_table):
1547 * charset.c (Fcharset_after): Fix typos.
1548
615a3b8d 15492011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1550
17e845af
PE
1551 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1552 Otherwise, valgrind does not work on some platforms.
1553 Problem reported by Andreas Schwab in
6a0bf43d
PE
1554 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1555 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1556 is set, removing the need for VIRT_ADDRESS_VARIES.
1557 (PURE_P): Use a more-efficient implementation that needs just one
1558 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1559 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1560 to 4 (xorl, subq, cmpq, setbe).
1561 * alloc.c (pure): Always extern now, since that's the
1562 VIRT_ADDR_VARIES behavior.
1563 (PURE_POINTER_P): Use a single comparison, not two, for
1564 consistency with the new puresize.h.
1565 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1566 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1567 Remove VIRT_ADDR_VARIES no longer needed.
1568
f8fe6f96
EZ
15692011-11-19 Eli Zaretskii <eliz@gnu.org>
1570
1571 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1572 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1573 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1574 behave as if the cursor position were at the window margin.
1575
1576 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1577 and the cursor position is out of bounds, behave as if the cursor
1578 position were at the window margin. (Bug#10075)
1579
df05a53c
CY
15802011-11-18 Chong Yidong <cyd@gnu.org>
1581
1582 * window.c (Fwindow_combination_limit): Make first argument
1583 non-optional, since it is meaningless for live windows like the
1584 selected window.
1585
2071918e
DA
15862011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1587
1588 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1589
b50a28de
SM
15902011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1591
1592 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1593 (graft_intervals_into_buffer): Simplify.
1594
015137db
EZ
15952011-11-18 Eli Zaretskii <eliz@gnu.org>
1596
1597 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1598 hash values of the two rows.
1599 (copy_row_except_pointers): Preserve the used[] arrays and the
1600 hash values of the two rows. (Bug#10035)
68c95424 1601 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1602
1603 * xdisp.c (row_hash): New function, body extracted from
1604 compute_line_metrics.
1605 (compute_line_metrics): Call row_hash, instead of computing the
1606 hash code inline.
1607
1608 * dispnew.c (verify_row_hash): Call row_hash for computing the
1609 hash code of a row, instead of duplicating code from xdisp.c.
1610
1611 * dispextern.h (row_hash): Add prototype.
1612
a2addb04
TH
16132011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1614
1615 * frame.c (delete_frame): Don't delete the terminal when the last
1616 X frame is closed if emacs is built with GTK toolkit.
1617
df85d315
JB
16182011-11-17 Juanma Barranquero <lekktu@gmail.com>
1619
1620 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1621
a0c2d0ae
MR
16222011-11-17 Martin Rudalics <rudalics@gmx.at>
1623
1624 * window.c (Vwindow_splits): Rename to
1625 Vwindow_combination_resize. Suggested by Juri Linkov.
1626 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1627 of Vwindow_splits.
1628
58179cce
JB
16292011-11-16 Juanma Barranquero <lekktu@gmail.com>
1630
7877f373
JB
1631 * nsfns.m (Fns_font_name):
1632 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1633
b6f67890
MR
16342011-11-16 Martin Rudalics <rudalics@gmx.at>
1635
1636 * window.h (window): Rename slot "nest" to "combination_limit".
1637 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1638 (Fset_window_nest): Rename to Fset_window_combination_limit.
1639 (Vwindow_nest): Rename to Vwindow_combination_limit.
1640 (recombine_windows, make_parent_window, make_window)
1641 (Fsplit_window_internal, saved_window)
1642 (Fset_window_configuration, save_window_save): Rename all
1643 occurrences of window_nest to window_combination_limit.
1644
c7015153
JB
16452011-11-15 Juanma Barranquero <lekktu@gmail.com>
1646
1647 * image.c (imagemagick_load_image): Fix typo.
1648
322ad6ec
EZ
16492011-11-14 Eli Zaretskii <eliz@gnu.org>
1650
1651 * xdisp.c (display_line): Move the call to
1652 highlight_trailing_whitespace before the call to
1653 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1654 faces of all the glyphs to compute ROW's hash value.
1655 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1656
f067b8ec
JB
16572011-11-14 Juanma Barranquero <lekktu@gmail.com>
1658
1659 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1660 just return (bug#10044).
1661
1e5b2111
EZ
16622011-11-12 Eli Zaretskii <eliz@gnu.org>
1663
7ef3cbd5
EZ
1664 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1665 with user-defined heap size. Bump the default size of the temacs
1666 heap to 27MB, to avoid memory warning when running temacs.
1667 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1668
1e5b2111
EZ
1669 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1670 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1671 (verify_row_hash) [XASSERTS]: New function.
1672 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1673 that the hash value of glyph rows is correct.
1e5b2111 1674
89d61221
MR
16752011-11-12 Martin Rudalics <rudalics@gmx.at>
1676
1677 * window.h (window): Remove splits slot.
1678 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1679 (Fdelete_other_windows_internal, make_parent_window)
1680 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1681 (Fset_window_configuration, save_window_save): Don't deal with
1682 split status of windows.
1683 (saved_window): Remove splits slot.
1684 (Vwindow_splits): Rewrite doc-string.
1685
97f18cc8
JD
16862011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1687
1688 * xfns.c (unwind_create_frame):
1689 * nsfns.m (unwind_create_frame):
1690 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1691 Vframe_list (Bug#9999).
1692
22a648b4
DA
16932011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1694
0b381c7e 1695 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1696
659afede
KH
16972011-11-11 Kenichi Handa <handa@m17n.org>
1698
1699 * callproc.c (Fcall_process): Set the member dst_multibyte of
1700 process_coding.
1701
9ac0394b
KH
17022011-11-11 Johan Bockgård <bojohan@gnu.org>
1703
1704 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1705 avoid a crash (bug#9496).
1706
2fbdc249
CY
17072011-11-09 Chong Yidong <cyd@gnu.org>
1708
1709 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1710 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1711
ac6b1f81
PE
17122011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1713
1714 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1715
09db192c
PE
17162011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1717
1718 Avoid some portability problems by eschewing 'extern inline' functions.
1719 The trivial performance wins aren't worth the portability hassles; see
1720 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1721 et seq.
1722 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1723 (window_box_width, window_box_left, window_box_left_offset)
1724 (window_box_right, window_box_right_offset): Undo previous change,
1725 by removing the "extern"s.
1726 * intervals.c (adjust_intervals_for_insertion)
1727 (adjust_intervals_for_deletion): Undo previous change,
1728 making these static again.
1729 (offset_intervals, temp_set_point_both, temp_set_point)
1730 (copy_intervals_to_string): No longer inline.
1731 * xdisp.c (window_text_bottom_y, window_box_width)
1732 (window_box_height, window_box_left_offset)
1733 (window_box_right_offset, window_box_left, window_box_right)
1734 (window_box): No longer inline.
1735
105216ed
CY
17362011-11-08 Chong Yidong <cyd@gnu.org>
1737
1738 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1739 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1740 Signal an error if not a live window.
105216ed
CY
1741 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1742 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1743
ae9e237f
JB
17442011-11-07 Juanma Barranquero <lekktu@gmail.com>
1745
1746 * lisp.h (syms_of_abbrev): Remove declaration.
1747 Reported by CHENG Gao <chenggao@royau.me>.
1748
c7aa8333
EZ
17492011-11-07 Eli Zaretskii <eliz@gnu.org>
1750
1751 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1752 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1753 of temacs in GUI mode.
1754
be7f5545
MR
17552011-11-07 Martin Rudalics <rudalics@gmx.at>
1756
1757 * window.h: Declare delete_all_child_windows instead of
1758 delete_all_subwindows.
1759 * window.c (Fwindow_nest, Fset_window_nest)
1760 (Fset_window_new_total, Fset_window_new_normal)
1761 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1762 (delete_all_subwindows): Rename to delete_all_child_windows.
1763 (Fdelete_other_windows_internal, Fset_window_configuration):
1764 Call delete_all_child_windows instead of delete_all_subwindows.
1765 * frame.c (delete_frame): Call delete_all_child_windows instead
1766 of delete_all_subwindows.
1767
ca78dc43
PE
17682011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1769
1770 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1771 This is also needed for porting to any host where GC_MARK_STACK is
1772 not GC_MAKE_GCPROS_NOOPS.
1773 (which_symbols): Use it.
1774
a0241d01
KH
17752011-11-07 Kenichi Handa <handa@m17n.org>
1776
1777 * coding.c (coding_set_destination): Check coding->src_pos only
1778 when coding->src_object is a buffer (bug#9910).
1779
1780 * process.c (send_process): Set the member src_multibyte of coding
1781 to 0 (bug#9911) when sending a unibyte text.
1782
1783 * callproc.c (Fcall_process): Set the member src_multibyte of
1784 process_coding to 0 (bug#9912).
1785
a64bfdfa 17862011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1787
1788 * xmenu.c (cleanup_widget_value_tree): New function.
1789 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1790 calling free_menubar_widget_value_tree directly (Bug#9830).
1791
cb41b32a
PE
17922011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1793
1794 Fix some portability problems with 'inline'.
1795 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1796 (window_box_width, window_box_left, window_box_left_offset)
1797 (window_box_right, window_box_right_offset): Declare extern.
1798 Otherwise, these inline functions do not conform to C99 and
1799 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1800 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1801 * intervals.c (adjust_intervals_for_insertion)
1802 (adjust_intervals_for_deletion): Now extern, because otherwise the
1803 extern inline functions 'offset_intervals' couldn't refer to it.
1804 (static_offset_intervals): Remove.
1805 (offset_intervals): Rewrite using the old contents of
1806 static_offset_intervals. The old version didn't conform to C99
1807 because an extern inline function contained a reference to an
1808 identifier with static linkage.
1809
b7041366
AS
18102011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1811
1812 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1813 GC.
1814
88a37c4d
EZ
18152011-11-06 Eli Zaretskii <eliz@gnu.org>
1816
1817 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1818 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1819 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1820 return Qleft_to_right.
1821
49745b39
CY
18222011-11-06 Chong Yidong <cyd@gnu.org>
1823
1824 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1825 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1826 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1827 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1828 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1829 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1830 (Fwindow_vscroll): Doc fix.
1831 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1832 argument, since it makes no sense to pass a live window and for
1833 consistency with window-child.
1834
1f05cd82
CS
18352011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1836
1837 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1838 support MSVC.
1839
22610910
JR
18402011-11-05 Jason Rumney <jasonr@gnu.org>
1841
1842 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1843 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1844 fonts (Bug#6029).
1845 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1846 bitwise arithmetic preventing use of unicode-sip and non-truetype
1847 opentype fonts.
1848
a06776b2
EZ
18492011-11-05 Eli Zaretskii <eliz@gnu.org>
1850
3ad924ba
EZ
1851 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1852 "emacs"-only part.
1853
a06776b2
EZ
1854 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1855 initialization code to keep similarity to xfns.c after changes
1856 from 2011-11-05.
1857
c9e7db78
JD
18582011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1859
a97f8f3f
JD
1860 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1861 (unwind_create_frame): New function (Bug#9943).
1862 (Fx_create_frame): Restructure code to be more similar to the one in
1863 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1864 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1865 Move terminal->reference_count++ just before making the frame official
1866 (Bug#9943).
1867
1868 * nsterm.m (x_free_frame_resources): New function.
1869 (x_destroy_window): Move code to x_free_frame_resources.
1870
c9e7db78 1871 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1872 (Fx_create_frame, x_create_tip_frame):
1873 Move terminal->reference_count++ just before making the frame
75f1671a 1874 official. Move initialization of image_cache_refcount and
c9e7db78
JD
1875 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1876
a6fc3b5c
EZ
18772011-11-05 Eli Zaretskii <eliz@gnu.org>
1878
1879 Support MSVC build with newer versions of Visual Studio.
1880 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1881 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1882 nt/gmake.defs.
1883
1884 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1885 which are not supported by MSVC.
1886 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1887 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1888 bitfields.
1889 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1890 types in bitfields.
1891 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1892
1893 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1894
58179cce 18952011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1896
1897 Support MSVC build with newer versions of Visual Studio.
1898 * w32.c: Don't include w32api.h for MSVC.
1899 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1900
1901 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1902 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1903 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1904 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1905 e_* cousins.
1906 (alloca) [_MSC_VER]: Define to _alloca.
1907
1908 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1909
1910 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1911
a58c13ed
EZ
19122011-11-04 Eli Zaretskii <eliz@gnu.org>
1913
1914 * xdisp.c (note_mouse_highlight): If either of
1915 previous/next-single-property-change returns nil, treat that as
1916 the beginning or the end of the buffer. (Bug#9955)
1917
fe0b6370
JD
19182011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1919
a58c13ed 1920 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1921 label is not null (Bug#9951).
1922 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1923 may be NULL.
1924
89bd5ee1
EZ
19252011-11-04 Eli Zaretskii <eliz@gnu.org>
1926
1927 * window.c (Fwindow_body_size): Mention in the doc string that the
1928 return value is in frame's canonical units. (Bug#9949)
1929
84c3edb9
EZ
19302011-11-03 Eli Zaretskii <eliz@gnu.org>
1931
4e2fb5c7
EZ
1932 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1933
84c3edb9 1934 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1935 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1936 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1937
bc17a887
EZ
19382011-11-01 Eli Zaretskii <eliz@gnu.org>
1939
1940 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1941 Don't stop backward scan on the continuation glyph, even though
1942 its CHARPOS is positive.
6d5eb5b0
SM
1943 (mouse_face_from_buffer_pos, note_mouse_highlight):
1944 Rename cover_string to disp_string.
bc17a887 1945
4ee88440
MR
19462011-11-01 Martin Rudalics <rudalics@gmx.at>
1947
1948 * window.c (temp_output_buffer_show): Don't use
1949 Vtemp_buffer_show_specifiers.
1950 (Vtemp_buffer_show_specifiers): Remove unused variable.
1951
c2ff3c02
EZ
19522011-10-30 Eli Zaretskii <eliz@gnu.org>
1953
1954 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1955 past the beginning of the current glyph matrix.
1956
58179cce 19572011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1958
1959 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1960 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1961 HAVE_GTK3 (Bug#9869).
b77a6a7f 1962
3b574623
JD
1963 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1964 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1965
b77a6a7f
JD
1966 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1967
1968 * xterm.c: Declare x_handle_net_wm_state to return int.
1969 (handle_one_xevent): Check if we are iconified but don't have
1970 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1971 (get_current_wm_state): Return non-zero if not hidden,
1972 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1973 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1974 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1975 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1976
196e41e4
PE
19772011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1978
1979 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1980 so that this new function doesn't get optimized away by a
1981 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1982
021f2e1a
AS
19832011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1984
1985 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1986
8b058d44
EZ
19872011-10-29 Eli Zaretskii <eliz@gnu.org>
1988
1989 Fix the `xbytecode' command.
1990 * .gdbinit (xprintbytestr): New command.
b50a28de 1991 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1992 (xbytecode): Print the byte-code string as well.
1993
4452fb80
EZ
19942011-10-29 Kim Storm <storm@cua.dk>
1995
8b058d44
EZ
1996 * alloc.c (which_symbols): New function.
1997
21b72067
AS
19982011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1999
2000 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2001 line. (Bug#9903)
2002
83ed7b5c
GM
20032011-10-29 Glenn Morris <rgm@gnu.org>
2004
2005 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2006 Not clear what it was for, and it causes various bugs. (Bug#9839)
2007
5a7a728b
EZ
20082011-10-28 Eli Zaretskii <eliz@gnu.org>
2009
2010 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2011 possible random value that matches one of those tested as
2012 condition to clear the mouse face.
2013
d3d0842f
CY
20142011-10-28 Chong Yidong <cyd@gnu.org>
2015
2016 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2017
31b39d13
DN
20182011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2019
2020 * window.c (make_window): Initialize phys_cursor_on_p.
2021
9aba6043
SM
20222011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2023
2024 * lisp.h (struct Lisp_Symbol): Update comments.
2025
c20992f4
JB
20262011-10-28 Juanma Barranquero <lekktu@gmail.com>
2027
2028 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2029
db4f02f2
EZ
20302011-10-28 Eli Zaretskii <eliz@gnu.org>
2031
2032 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2033 <oslsachem@gmail.com> for helping to debug this.
2034
2035 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2036 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2037 (g_b_init_get_glyph_outline_w): New static variables.
2038 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2039 (GetGlyphOutlineW_Proc): New typedefs.
2040 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
2041 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2042 New functions.
2043 (w32font_open_internal, compute_metrics):
2044 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
2045 instead of calling the "wide" APIs directly.
2046
2047 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2048
2049 * w32.h (syms_of_w32font): Add prototype.
2050
87e68db4
JB
20512011-10-27 Juanma Barranquero <lekktu@gmail.com>
2052
2053 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2054 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2055 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2056 (Fmove_to_window_line): Doc fix.
2057
435c1d67
CY
20582011-10-27 Chong Yidong <cyd@gnu.org>
2059
2060 * process.c (make_process): Set gnutls_state to NULL.
2061
2062 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2063 non-NULL, regardless of GNUTLS_INITSTAGE.
2064 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2065 an error. Set process slots as soon as we allocate them.
2066
2067 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2068
9c6c6f49
CY
20692011-10-27 Chong Yidong <cyd@gnu.org>
2070
9aba6043
SM
2071 * gnutls.c (emacs_gnutls_deinit): New function.
2072 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
2073 (Fgnutls_deinit, Fgnutls_boot): Use it.
2074
2075 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2076 (deactivate_process): Call emacs_gnutls_deinit.
2077
657d08d3
JB
20782011-10-27 Juanma Barranquero <lekktu@gmail.com>
2079
2080 * image.c (x_create_x_image_and_pixmap):
2081 * w32.c (sys_rename, w32_delayed_load):
2082 * w32font.c (fill_in_logfont):
2083 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2084
5430d399
JB
20852011-10-26 Juanma Barranquero <lekktu@gmail.com>
2086
2087 * w32fns.c (w32_default_color_map): New function,
2088 extracted from Fw32_default_color_map.
a7ef684b 2089 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2090
fe0055fa
PE
20912011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2092
2093 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2094
e6346438
SM
20952011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2096
2097 * keyboard.c (test_undefined): New function (bug#9751).
2098 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2099
e112cc37
ET
21002011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2101
2102 * sysdep.c (init_sys_modes): Fix the check for the controlling
2103 terminal (Bug#6649).
2104
7b5d6677
EZ
21052011-10-20 Eli Zaretskii <eliz@gnu.org>
2106
2107 * dispextern.h (struct bidi_it): New member next_en_type.
2108
2109 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2110 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2111 current character, check also for next_en_type being WEAK_EN.
2112 (bidi_resolve_weak): Don't enter the expensive loop if the current
2113 position is before next_en_pos. Record the bidi type of the first
2114 non-ET, non-BN character we find, in addition to its position.
2115 (bidi_level_of_next_char): Invalidate next_en_type when
2116 next_en_pos is over-stepped.
2117
7da0b018
PE
21182011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2119
2120 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2121 * editfns.c: Rewrite current-time-zone so that it invokes
2122 the equivalent of (format-time-string "%Z") to get the time zone name.
2123 This fixes a bug when the time zone name contains characters that
2124 need converting from the system time locale to Emacs internal format.
2125 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2126 that patch fixed format-time-string to do the conversion, but
2127 I forgot to fix current-time-zone.
2128 (format_time_string): New function, containing most of
2129 what Fformat_time_string used to contain.
2130 (Fformat_time_string): Rewrite in terms of format_time_string.
2131 This doesn't change this function's behavior.
2132 (current-time-zone): Rewrite to use format_time_string.
2133 This fixes the bug reported by Michael Schierl in
2134 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2135 Jason Rumney's 2007-06-07 change worked around this bug, but
2136 didn't fix it.
2137 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2138
8547b010
EZ
21392011-10-19 Eli Zaretskii <eliz@gnu.org>
2140
2141 * xdisp.c (start_display): If the character at POS is displayed
2142 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2143 (try_window_reusing_current_matrix): If a line ends in a display
2144 vector or the next line starts in a display vector, continue
2145 redrawing the window even though the character position of
2146 start_row was reached.
8547b010
EZ
2147 (Bug#9771, part 2)
2148
4e948d15
CY
21492011-10-18 Chong Yidong <cyd@gnu.org>
2150
2151 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2152 with nobreak-char-display too.
2153
4787455f
EZ
21542011-10-18 Eli Zaretskii <eliz@gnu.org>
2155
2156 Fix part 3 of bug#9771.
2157 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2158 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2159 non-neutral characters if the current character is a paragraph
2160 separator (a.k.a. Newline). This avoids running the same
2161 expensive loop twice, once when we consume the preceding newline
2162 and the other time when the line actually needs to be displayed.
2163 Avoid the loop when we see neutrals on the base embedding level
2164 following a character whose directionality is the same as the
2165 paragraph's. This avoids running the expensive loop when a line
2166 ends in a long sequence of neutrals, like control characters.
2167 Add assertion against STRONG_AL type. Slightly rearrange code
2168 that determines the type of a neutral given the first non-neutral
2169 that follows it.
2170 (bidi_level_of_next_char): Set next_en_pos to zero when
2171 invalidating its info.
2172
2c91f553
EZ
21732011-10-17 Eli Zaretskii <eliz@gnu.org>
2174
2175 * xdisp.c (push_display_prop): Determine whether to record string
2176 or buffer position by IT->string, not by IT->method. Allow
2177 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2178 (move_it_vertically_backward): Don't look for character position
2179 immediately after the newline when in a continuation line.
2180 (Bug#9771, part 1)
2c91f553 2181
c7b08b0d
MR
21822011-10-15 Martin Rudalics <rudalics@gmx.at>
2183
2184 * window.c (coordinates_in_window): Rewrite and delabelize
2185 vertical border check. (Bug#5357) (Bug#9618)
2186
6b02f655
SM
21872011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2188
2189 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2190 errors in XSetWindowBorder (bug#9310).
2191
81d40c92
DA
21922011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2193
2194 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2195 avoid crash when xmalloc overrun checking is enabled.
2196
d4172c3b
EZ
21972011-10-13 Eli Zaretskii <eliz@gnu.org>
2198
2199 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2200 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2201 cursor motion with <left> and <right> arrow keys.
2202
2203 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2204 some callers set that themselves.
2205
b00eea75
EZ
22062011-10-12 Eli Zaretskii <eliz@gnu.org>
2207
2208 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2209 display string and the previous row comes from the same string and
2210 is empty. (Bug#9739) (Bug#9738)
2211
8fe012c4
SM
22122011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2213
2214 * doc.c (get_doc_string): Encode file name (bug#9735).
2215
0074aef2
EZ
22162011-10-12 Eli Zaretskii <eliz@gnu.org>
2217
79beb178
EZ
2218 * bidi.c (bidi_level_of_next_char):
2219 * xdisp.c (get_visually_first_element): Remove old incorrect
2220 comments regarding the Unicode Line Separator character.
2221
0074aef2
EZ
2222 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2223
6e4b3fbe
DA
22242011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2225
2226 * alloc.c (Fgc_status): Do not access beyond zombies array
2227 boundary if nzombies > MAX_ZOMBIES.
2228 * alloc.c (dump_zombies): Add missing format specifier.
2229
0324f3af
PE
22302011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2231
b5525cac
PE
2232 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2233 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2234
0324f3af
PE
2235 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2236 Some packages use them to denote characters with modifiers.
2237
e9b5f888
AS
22382011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2239
2240 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2241 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2242 matching a pp-number. Rename parameter var to var1.
2243
127827c0
SM
22442011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2245
2246 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2247
c8fd3bd0
GM
22482011-10-08 Glenn Morris <rgm@gnu.org>
2249
2250 * callint.c (Fcall_interactively): Give a more explicit error for the
2251 'c' case with a non-character input. (Bug#8479)
2252
352ec8ff
EZ
22532011-10-08 Eli Zaretskii <eliz@gnu.org>
2254
03669ccb
EZ
2255 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2256 lines.
7061c986
EZ
2257 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2258 lines that are hscrolled on the left.
03669ccb 2259
352ec8ff
EZ
2260 * dispnew.c (buffer_posn_from_coords): Account for a possible
2261 presence of header-line. (Bug#4426)
2262
a66cfb1c
SM
22632011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2264
6b02f655
SM
2265 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2266 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2267
7c5ee88e
PE
22682011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2269
2270 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2271 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2272 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2273 this makes Emacs dump core during garbage collection on rare
2274 occasions. sizeof is obviously inferior to offsetof here, so
2275 stick with offsetof.
2276 (GC_POINTER_ALIGNMENT): New macro.
2277 (mark_memory): Omit 3rd (offset) arg; caller changed.
2278 Don't assume EMACS_INT alignment is the same as pointer alignment.
2279
df1bbe5b
SM
22802011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2281
2282 * keyboard.c (read_key_sequence_remapped): New var.
2283 (read_key_sequence): Compute remapping in the right buffer.
2284 (command_loop_1): Use read_key_sequence's remapping directly.
2285
51553db6
SM
22862011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2287
32c1fffd
SM
2288 * dired.c (file_name_completion): Don't expand file name.
2289 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2290 before checking file name handler.
2291
51553db6
SM
2292 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2293 they've been requested explicitly (bug#9591).
2294
b6bd1599 22952011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2296
2297 * keymap.c (Fsingle_key_description): Use make_specified_string
2298 instead of build_string to build string from push_key_description.
2299 (Bug#5193)
2300
f701dc2a
PE
23012011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2302
4222c55d
PE
2303 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2304 This fixes a Y2038 bug on 64-bit hosts.
2305 * buffer.c (reset_buffer):
2306 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2307 (Fclear_buffer_auto_save_failure):
2308 Use 0, not -1, to represent an unset failure time, since time_t
2309 might not be signed.
2310
f701dc2a
PE
2311 Remove dependency on glibc malloc internals.
2312 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2313 Move back here from lisp.h, but with their new implementations.
2314 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2315 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2316 * charset.c (charset_table_init): New static var.
2317 (syms_of_charset): Use it instead of xmalloc. This removes a
2318 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2319 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2320 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2321 Move back to alloc.c.
2322 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2323 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2324
9ceebf39
JD
23252011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2326
2327 * nsterm.m (windowDidResize): Call x_set_window_size only when
2328 ns_in_resize is true. Otherwise set pixelwidth/height and
2329 call change_frame_size (Bug#9628).
2330
cb993c58
PE
23312011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2332
3930c88b
PE
2333 Port --enable-checking=all to Fedora 14 x86-64.
2334 * charset.c (syms_of_charset): Also account for glibc malloc's
2335 internal overhead when calculating the initial malloc maximum.
2336
cb993c58
PE
2337 Port --enable-checking=all to Fedora 14 x86.
2338 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2339 Move to lisp.h.
2340 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2341 (overrun_check_realloc, overrun_check_free):
2342 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2343 That way, xmalloc returns a properly-aligned pointer even if
2344 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2345 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2346 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2347 into account when calculating the initial malloc maximum.
2348 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2349 Move here from alloc.c, so that charset.c can use it too.
2350 Properly align; the old code wasn't right for common 32-bit hosts
2351 when configured with --enable-checking=all.
2352 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2353 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2354
31bed486
EZ
23552011-09-29 Eli Zaretskii <eliz@gnu.org>
2356
04c70788 2357 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2358 use EDOM.
2359
fbcaa2f3
EZ
23602011-09-28 Eli Zaretskii <eliz@gnu.org>
2361
2362 * xdisp.c (compute_display_string_end): If there's no display
2363 string at CHARPOS, return -1.
2364
2365 * bidi.c (bidi_fetch_char): When compute_display_string_end
2366 returns a negative value, treat the character as a normal
2367 character not covered by a display string. (Bug#9624)
2368
a239d4e9
JB
23692011-09-28 Juanma Barranquero <lekktu@gmail.com>
2370
2371 * lread.c (Fread_from_string): Fix typo in docstring.
2372
88652fd5
EZ
23732011-09-27 Eli Zaretskii <eliz@gnu.org>
2374
2375 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2376 newline, reseat the iterator instead of bidi-iterating there one
2377 character at a time. (Bug#9610)
32c1fffd
SM
2378 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2379 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2380
ed497dd4
AS
23812011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2382
2383 * lread.c (readevalloop): Use correct code for NBSP.
2384 (read1): Likewise. (Bug#9608)
2385
b2bf61aa
MA
23862011-09-25 Michael Albinus <michael.albinus@gmx.de>
2387
2388 * dbusbind.c (Fdbus_register_signal): When service is not
2389 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2390
32bbb17c
GM
23912011-09-25 Glenn Morris <rgm@gnu.org>
2392
2393 * buffer.c (truncate-lines): Doc fix.
2394
94e0933e
CY
23952011-09-24 Chong Yidong <cyd@stupidchicken.com>
2396
2397 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2398 (Fset_window_next_buffers): Doc fix.
2399
cddde921
GM
24002011-09-24 Glenn Morris <rgm@gnu.org>
2401
2402 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2403
1260aef1
PE
24042011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2405
25b4bfa0
PE
2406 Fix minor problems found by static checking.
2407 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2408 * indent.c (Fvertical_motion): Fix == vs = typo.
2409
e3cbd34b
EZ
24102011-09-24 Eli Zaretskii <eliz@gnu.org>
2411
a66cfb1c
SM
2412 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2413 Default value is now t. Doc fix.
6bf7006f 2414
e3cbd34b 2415 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2416 logic when moving up, not only when moving down. Fix the
e3cbd34b 2417 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2418 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2419
2420 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2421 CHARPOS is covered by a display string which includes newlines.
2422 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2423 is covered by a display string with embedded newlines.
2424
a3de0cbd
MA
24252011-09-24 Michael Albinus <michael.albinus@gmx.de>
2426
2427 * dbusbind.c (Fdbus_register_signal): Add match rule to
2428 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2429 (Fdbus_register_method, Vdbus_registered_objects_table):
2430 Fix docstring.
a3de0cbd 2431
b260039d
JM
24322011-09-24 Jim Meyering <meyering@redhat.com>
2433
32c1fffd 2434 do not ignore write error for any output size
b260039d
JM
2435 The previous change was incomplete.
2436 While it makes emacs --batch detect the vast majority of stdout
2437 write failures, errors were still ignored whenever the output size is
2438 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2439 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2440 && echo FAIL: ignored write error
2441 FAIL: ignored write error
2442 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2443 && echo FAIL: ignored write error
2444 FAIL: ignored write error
2445 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2446
8eca8a7c
AS
24472011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2448
2449 * emacs.c (Fkill_emacs): In noninteractive mode exit
2450 non-successfully if a write error occurred on stdout. (Bug#9574)
2451
3341db62
EZ
24522011-09-21 Eli Zaretskii <eliz@gnu.org>
2453
2454 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2455 the xassert test.
2456
2457 * dispextern.h (struct it): Update the comment documenting what
2458 can it->OBJECT be.
2459
8c203dbf
EZ
24602011-09-20 Eli Zaretskii <eliz@gnu.org>
2461
2462 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2463 a display string, extend search for cursor position to end of row.
2464 (find_row_edges): If the row ends in a newline from a display
2465 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2466 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2467 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2468 non-empty line. Fixes confusing cursor motion with arrow keys at
2469 the beginning of a line that starts with whitespace.
8c203dbf 2470
a4824228
LMI
24712011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2472
2473 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2474 (bug#9493).
2475
33ed493b
CY
24762011-09-18 Chong Yidong <cyd@stupidchicken.com>
2477
2478 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2479 boolean (Bug#9154).
2480
56cd55c8
EZ
24812011-09-18 Eli Zaretskii <eliz@gnu.org>
2482
2483 * xdisp.c (display_line): Record maximum and minimum buffer
2484 positions even if no glyphs were produced (e.g., by a zero-width
2485 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2486 buffer positions that will be removed from the glyph row because
2487 they don't fit.
c02dcedf
EZ
2488 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2489 column is beyond frame width: don't subtract 1 "pixel" when
2490 computing width of the stretch.
3e62b7e0
EZ
2491 (reseat_at_next_visible_line_start): Undo the change made on
2492 2011-09-17 that saved paragraph information and restored it after
2493 the call to `reseat'. (Bug#9545)
56cd55c8 2494
5ed99d36 24952011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2496
2497 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2498 and turn window cursor on if cleared (Bug#9415).
2499
5ed99d36 25002011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2501
2502 * search.c (boyer_moore): Take unibyte characters from pattern
2503 literally. (Bug#9458)
2504
9bade7b2
EZ
25052011-09-18 Eli Zaretskii <eliz@gnu.org>
2506
2507 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2508
e5e9d610
PE
25092011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2510
87e4427a
PE
2511 Fix minor problem found by static checking.
2512 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2513 initialized, to pacify gcc -Wuninitialized.
2514
e5e9d610
PE
2515 * fileio.c: Report proper errno when syscall falls.
2516 (Finsert_file_contents): Save and restore errno,
2517 so that report_file_error outputs the correct diagnostic.
2518 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2519
a1674f0b
EZ
25202011-09-18 Eli Zaretskii <eliz@gnu.org>
2521
2522 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2523
fbfb6dd4
EZ
25242011-09-17 Eli Zaretskii <eliz@gnu.org>
2525
2526 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2527 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2528
bb187662
EZ
25292011-09-17 Eli Zaretskii <eliz@gnu.org>
2530
1137e8b8 2531 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2532 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2533
2534 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2535 (bidi_find_paragraph_start): Search back for paragraph beginning
2536 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2537 (bidi_move_to_visually_next): Only trigger paragraph-related
2538 computations when the last character is a newline or at EOB, not
2539 just any NEUTRAL_B. (Bug#9470)
2540
bb187662
EZ
2541 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2542 truncated lines if point is covered by a display string. (Bug#9524)
2543
2e621251
PE
25442011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2545
2546 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2547 (cons_to_x_long): New function.
2548 (lisp_data_to_selection_data): Use it. Correct the test for
2549 short-versus-long data; it was negated. Break out of vector
2550 loop, for efficiency, when a long datum is discovered.
2551
91a15bc6
SM
25522011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2553
2554 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2555
b41c3a35
EZ
25562011-09-16 Eli Zaretskii <eliz@gnu.org>
2557
2558 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2559 GCC PR/17406) by declaring this function with external scope.
2560
7812ba2d
PE
25612011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2562
2563 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2564 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2565
cf7edc2a
AS
25662011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2567
2568 * editfns.c (Fformat): Correctly handle text properties on "%%".
2569
bd01620e
EZ
25702011-09-15 Eli Zaretskii <eliz@gnu.org>
2571
2572 * xterm.c (x_draw_composite_glyph_string_foreground):
2573 * w32term.c (x_draw_composite_glyph_string_foreground):
2574 * term.c (encode_terminal_code):
2575 * composite.c (composition_update_it, get_composition_id):
2576 * xdisp.c (get_next_display_element)
2577 (fill_composite_glyph_string): Add comments about special meaning
2578 of TAB characters in a composition.
2579
a02719a3
PE
25802011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2581
2582 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2583 This occurs when processing a multibyte format.
2584 Problem reported by Wolfgang Jenker.
a02719a3 2585
72589a3c
JB
25862011-09-15 Johan Bockgård <bojohan@gnu.org>
2587
2588 * xdisp.c (try_cursor_movement): Only check for exact match if
2589 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2590
1c14176c
PE
25912011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2592
2593 Remove unused external symbols.
2594 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2595 * xdisp.c (calc_pixel_width_or_height): Now static.
2596 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2597 * indent.c (check_display_width):
2598 * w32term.c: Fix comment to match code.
2599 * xterm.c, xterm.h (x_catching_errors): Remove.
2600
d2eea5b5
PE
26012011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2602
2603 * xselect.c: Use signed conversions more consistently (Bug#9498).
2604 (selection_data_to_lisp_data): Assume incoming selection data are
2605 signed integers, not unsigned. This is to be consistent with
2606 outgoing selection data, which was modified to use signed integers
2607 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2608 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2609 expects long, not unsigned long.
2610
46888499
EZ
26112011-09-14 Eli Zaretskii <eliz@gnu.org>
2612
2613 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2614 computation of loop end. Reported by Johan Bockgård
2615 <bojohan@gnu.org>.
2616
ef8ef9fb
CY
26172011-09-13 Chong Yidong <cyd@stupidchicken.com>
2618
2619 * frame.c (Fother_visible_frames_p): Function deleted.
2620
fa819fed
EZ
26212011-09-12 Eli Zaretskii <eliz@gnu.org>
2622
2623 * indent.c (compute_motion): Process display vector front to back
2624 rather than the other way around. (Bug#2496)
2625
2ba8e008
SM
26262011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2627
2628 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2629
20f53c69
CY
26302011-09-11 Chong Yidong <cyd@stupidchicken.com>
2631
2632 * minibuf.c (Fread_from_minibuffer): Doc fix.
2633
d562d7a4
EZ
26342011-09-11 Eli Zaretskii <eliz@gnu.org>
2635
2636 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2637 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2638
1c4d7f3d
LMI
26392011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2640
2641 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2642 value for non-existent files.
2643
b885bf36
EZ
26442011-09-11 Eli Zaretskii <eliz@gnu.org>
2645
2646 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2647 set its "size" to -1. This will set the modtime_size field of
2648 the corresponding buffer to -1, which is what
2649 verify-visited-file-modtime expects for files that do not exist.
2650 (Bug#9139)
2651
6612f0bf
PE
26522011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2653
2654 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2655 here ...
2656 * lisp.h: ... from here. push_key_description is no longer
2657 defined in keyboard.c, so its declaration should not be in
2658 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2659 logically belongs with push_key_description.
2660
dfb3f755
PE
26612011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2662
2663 * buffer.h: Include <sys/types.h> instead of <time.h>.
2664 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2665 Problem reported by Herbert J. Skuhra.
2666
3134906c
LMI
26672011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2668
2669 * xml.c (parse_region): Make the parsing work for
2670 non-comment-starting XML files again (bug#9144).
2671
8d903f4e
AS
26722011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2673
2674 * image.c (gif_load): Fix calculation of bottom and right corner.
2675 (Bug#9468)
2676
80ad64f4
EZ
26772011-09-10 Eli Zaretskii <eliz@gnu.org>
2678
2679 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2680 redisplay in small windows.
2681
208a048d
EZ
26822011-09-09 Eli Zaretskii <eliz@gnu.org>
2683
2684 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2685
9b1c252e
MR
26862011-09-08 Martin Rudalics <rudalics@gmx.at>
2687
2688 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2689 Operate on live windows only.
2690
2949f33b
JB
26912011-09-08 Juanma Barranquero <lekktu@gmail.com>
2692
2693 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2694
e08dcafd
EZ
26952011-09-07 Eli Zaretskii <eliz@gnu.org>
2696
2697 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2698 only under bidi iteration.
2699
115b96bd
JD
27002011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2701
2702 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2703
c8199d0f
PE
27042011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2705
2706 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2707 Without this fix, the command to link temacs failed due to an
2708 undefined symbol __builtin_isnan. This is because
2709 /usr/include/iso/math_c99.h #defines isnan(x) to
2710 __builtin_isnan(x), but the bundled gcc, which identifies itself
2711 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2712 a __builtin_isnan.
2713 * floatfns.c (isnan): #undef, and then #define to a clone of
2714 what's in data.c.
2715 (Fisnan): Always define, since it's always available now.
2716 (syms_of_floatfns): Always define isnan at the Lisp level.
2717
e39b275c 27182011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2719
2720 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2721
b2db44d9 27222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2723
f4af5137 2724 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2725 The previous code assumed that file offsets (off_t values) fit in
2726 EMACS_INT variables, which is not true on typical 32-bit hosts.
2727 The code messed up by falsely reporting buffer overflow in cases
2728 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2729 when "big" contains more than 2**29 bytes, even though this
2730 inserts just one byte and does not overflow the buffer.
2731 (Finsert_file_contents): Store file offsets as off_t
2732 values, not as EMACS_INT values. Check for overflow when
2733 converting between EMACS_INT and off_t. When checking for
2734 buffer overflow or for overlap, take the offsets into account.
2735 Don't use EMACS_INT for small values where int suffices.
2736 When checking for overlap, fix a typo: ZV was used where
2737 ZV_BYTE was intended.
2738 (Fwrite_region): Don't assume off_t fits into 'long'.
2739 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2740
ecfc0a49
MA
27412011-09-05 Michael Albinus <michael.albinus@gmx.de>
2742
2743 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2744
6511acf2 27452011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2746
0999621a 2747 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2748
2749 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2750 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2751 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2752 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2753 (modify_event_symbol): Do not assume that the length of
2754 name_alist_or_stem is safe to alloca and fits in int.
2755 (Fexecute_extended_command): Likewise for function name and binding.
2756 (Frecursion_depth): Wrap around reliably on integer overflow.
2757 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2758 since some callers pass EMACS_INT values.
2759 (Fsingle_key_description): Don't crash if symbol name contains more
2760 than MAX_ALLOCA bytes.
2761 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2762 (get_minibuffer): Arg is now EMACS_INT, not int.
2763 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2764 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2765 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2766
2be7d702
PE
2767 * dbusbind.c (signature_cat): New function.
2768 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2769 Do not overrun buffer; instead, report string overflow.
2770
9d1df220
PE
2771 * dispnew.c (add_window_display_history): Don't overrun buffer.
2772 Truncate instead; this is OK since it's just a log.
2773
33ef5c64
PE
2774 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2775 even if the time zone offset is outlandishly large.
2776 Don't mishandle offset == INT_MIN.
2777
66c6fdd5
PE
2778 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2779 when creating daemon; the previous buffer-overflow check was incorrect.
2780
d749b01b
PE
2781 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2782 which has the guts of the old verror function.
2783
b5cd1905
PE
2784 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2785 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2786
6e1a67fb
PE
2787 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2788 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2789 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2790 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2791 length of string rather than counting it via multiple sprintfs;
2792 that's simpler and more reliable.
c21721cc
PE
2793 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2794 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2795 sprintf, in case result does not fit in int.
2796
c57b67fc
PE
2797 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2798 (fontset_from_font): Print it.
2799
8a401434
PE
2800 * frame.c (tty_frame_count): Now printmax_t, not int.
2801 (make_terminal_frame, set_term_frame_name): Print it.
2802 (x_report_frame_params): In X, window IDs are unsigned long,
2803 not signed long, so print them as unsigned.
2804 (validate_x_resource_name): Check for implausibly long names,
2805 and don't assume name length fits in 'int'.
2806 (x_get_resource_string): Don't blindly alloca invocation name;
2807 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2808 not fit in int.
2809
6e1a67fb
PE
2810 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2811 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2812 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2813
0df02bf3
PE
2814 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2815 Use esprintf, not sprintf, in case result does not fit in int.
2816
48e30793
PE
2817 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2818 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2819 it as a large positive number.
2820 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2821 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2822
a66ff6d8
PE
2823 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2824 in case result does not fit in int.
2825
aca216ff
PE
2826 * print.c (float_to_string): Detect width overflow more reliably.
2827 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2828 buffer overrun. Don't assume list length fits in 'int'. Treat
2829 print length of 0 as 0, not as infinity; to be consistent with other
2830 uses of print length in this function. Don't overflow print length
2831 index. Don't assume hash table size fits in 'long', or that
2832 vectorlike size fits in 'unsigned long'.
2833
31c286f7
PE
2834 * process.c (make_process): Use printmax_t, not int, to format
2835 process-name gensyms.
2836
55e5faa1
PE
2837 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2838
80f2e268
PE
2839 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2840 to avoid potential buffer overrun.
2841
670741ab
PE
2842 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2843 if X resource line is longer than 512 bytes.
2844
b7163a50
PE
2845 * xfns.c (x_window): Make sprintf buffer a bit bigger
2846 to avoid potential buffer overrun.
2847
ae58ff1f
PE
2848 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2849
c43c8a6a
PE
2850 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2851
3f8236f4
PE
28522011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2853
53e9fe90 2854 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2855 Without these, Emacs silently mishandles large integers sometimes.
2856 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2857 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2858
6511acf2
PE
2859 * xdisp.c (try_window_id): Check Emacs fixnum range before
2860 converting to 'int'.
806add1d 2861
6511acf2 2862 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2863 Check that an Emacs fixnum is in range before assigning it to 'int'.
2864 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2865 values converted from Emacs fixnums.
2866 (Frecenter): Don't wrap around a line count if it is out of 'int'
2867 range; instead, treat it as an extreme value.
2868 (Fset_window_configuration, compare_window_configurations):
2869 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2870
6511acf2
PE
2871 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2872 that can exceed INT_MAX. Check that EMACS_INT value is in range
2873 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2874 (match_limit): Don't assume that a fixnum can fit in 'int'.
2875
6511acf2 2876 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2877 exceed INT_MAX.
2878
6511acf2 2879 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2880 (Fvertical_motion): Don't wrap around LINES values that don't fit
2881 in 'int'. Instead, treat them as extreme values. This is good
2882 enough for windows, which can't have more than INT_MAX lines anyway.
2883
fcb901a7
LMI
28842011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2885
0f2f6b6d
LMI
2886 * Require libxml/parser.h to avoid compilation warning.
2887
fcb901a7
LMI
2888 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2889
2890 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2891 since this reportedly can destroy thread storage.
2892
6e20a0d4
CY
28932011-08-30 Chong Yidong <cyd@stupidchicken.com>
2894
2895 * syntax.c (find_defun_start): Update all cache variables if
2896 exiting early (Bug#9401).
2897
148ae00e
EZ
28982011-08-30 Eli Zaretskii <eliz@gnu.org>
2899
f6cfbd8f
EZ
2900 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2901
148ae00e
EZ
2902 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2903 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2904 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2905
2906 * term.c (tty_append_glyph): New function.
2907 (produce_stretch_glyph): Static function and its prototype deleted.
2908
a66cfb1c
SM
2909 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2910 Add prototypes.
148ae00e 2911
c4a07a4c
PE
29122011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2913
2914 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2915 when checking :margin (Bug#9390).
2916 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2917 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2918 so that the name doesn't mislead. All uses changed.
2919
6bc8cd65
JB
29202011-08-28 Johan Bockgård <bojohan@gnu.org>
2921
2922 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2923 set_tty_hooks.
2924
dca4927e
EZ
29252011-08-27 Eli Zaretskii <eliz@gnu.org>
2926
2927 * xdisp.c (move_it_to): Don't bail out early when reaching
2928 position beyond to_charpos, if we are scanning backwards.
2929 (move_it_vertically_backward): When DY == 0, make sure we get to
2930 the first character in the line after the newline.
2931
f2cad773
PE
29322011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2933
2934 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2935 (ccl_driver): Do not generate an out-of-range pointer.
2936 (Fccl_execute_on_string): Remove unnecessary check for
2937 integer overflow, noted by Stefan Monnier in
2938 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2939 Remove a FIXME that didn't need fixing.
2940 Simplify the newly-introduced buffer reallocation code.
2941
0cae2cdb
JB
29422011-08-27 Juanma Barranquero <lekktu@gmail.com>
2943
2944 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2945
5fc295a4 29462011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2947
70c60eb2 2948 Integer and memory overflow issues (Bug#9196).
726e0ab1 2949
d31850da
PE
2950 * doc.c (get_doc_string): Rework so that
2951 get_doc_string_buffer_size is the actual buffer size, rather than
2952 being 1 less than the actual buffer size; this makes xpalloc more
2953 convenient.
2954
a69fbedb
PE
2955 * image.c (x_allocate_bitmap_record, cache_image):
2956 * xselect.c (Fx_register_dnd_atom):
2957 Simplify previous changes by using xpalloc.
2958
fe5c5d37
PE
2959 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2960 since either will do and ptrdiff_t is convenient with xpalloc.
2961
0065d054
PE
2962 * charset.c (charset_table_size)
2963 (struct charset_sort_data.priority): Now ptrdiff_t.
2964 (charset_compare): Don't overflow if priorities differ greatly.
2965 (Fsort_charsets): Don't assume list length fits in int.
2966 Check for size-calculation overflow when allocating sort data.
2967 (syms_of_charset): Allocate an initial charset table that is
2968 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2969
2970 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2971
2972 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2973 The actual value is always <= INT_MAX, and leaving it unsigned made
2974 overflow checking harder.
2975
2976 * dispextern.h (struct glyph_matrix.rows_allocated)
2977 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2978 with xpalloc. The values are still always <= INT_MAX.
2979
2980 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2981
2982 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2983 (SAFE_NALLOCA): New macro.
2984
2985 * region-cache.c (struct boundary.pos, find_cache_boundary)
2986 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2987 (set_cache_region, invalidate_region_cache)
2988 (revalidate_region_cache, know_region_cache, region_cache_forward)
2989 (region_cache_backward, pp_cache):
2990 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2991 so that ptrdiff_t * can be passed to xpalloc.
2992 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2993 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2994 (pp_cache): Don't assume cache_len fits in int.
2995 * region-cache.h: Adjust extern decls to match.
2996
2997 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2998 EMACS_INT, since either will do, for xpalloc.
2999
3000 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3001 (xnmalloc, xnrealloc, xpalloc): New functions.
3002
726e0ab1
PE
3003 * bidi.c (bidi_shelve_header_size): New constant.
3004 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3005 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3006
51f30bc5 3007 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
3008 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3009 (overlay_strings):
3010 Don't update size of array until after memory allocation succeeds,
3011 because xmalloc/xrealloc may not return.
0065d054
PE
3012 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3013 now that we have proper integer overflow checking.
3014 (record_overlay_string, overlay_strings): Catch overflows when
3015 calculating size of overlay_str_buf.
726e0ab1 3016
0065d054
PE
3017 * callproc.c (Fcall_process): Check for size overflow when
3018 calculating size of args2.
3019 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3020 Normally we prefer signed values, but sticking with ptrdiff_t would
3021 require adding more-complicated checks.
726e0ab1
PE
3022
3023 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3024 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3025 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 3026 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
3027
3028 * character.c (Fstring): Check for size-calculation overflow.
3029
3030 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3031 unnecessary integer overflow. Check for size overflow.
3032 (encode_coding_object): Don't update size until xmalloc succeeds.
3033
3034 * composite.c (get_composition_id): Check for overflow in glyph
3035 length calculations.
3036
3037 Integer and memory overflow fixes for display code.
3038 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3039 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3040 (scrolling_window): Check for overflow in size calculations.
3041 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3042 Don't assume glyph table len fits in int.
3043 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3044 (row_table_size): Now ptrdiff_t, not int.
3045 (scrolling_window): Avoid overflow in size calculations.
3046 Don't update size until allocation succeeds.
3047 * fns.c (concat): Check for overflow in size calculations.
3048 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3049 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3050 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3051
3052 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3053 (get_doc_string): Check for size calculation overflow.
3054 Don't update size until allocation succeeds.
3055 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3056 EMACS_INT, where ptrdiff_t will do.
3057 (Fsubstitute_command_keys): Check for string overflow.
3058
3059 * editfns.c (set_time_zone_rule): Don't assume environment length
3060 fits in int.
3061 (message_length): Now ptrdiff_t, not int.
3062 (Fmessage_box): Don't update size until allocation succeeds.
3063 Don't assume message length fits in int.
3064 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3065
0065d054
PE
3066 * emacs.c (main): Do not reallocate argv, since there is a null at
3067 the end that can be overwritten, and this way there's no need to
3068 worry about size-calculation overflow.
3069 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
3070
3071 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3072 alloc succeeds.
3073 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3074
3075 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3076 (x_set_scroll_bar_width, x_figure_window_size):
3077 Check for integer overflow.
3078 (x_set_alpha): Do not assume XINT fits in int.
3079
3080 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3081 This is for the members text_lines, text_cols, total_lines, total_cols,
3082 where the system imposes an 'int' limit.
3083
3084 * fringe.c (Fdefine_fringe_bitmap):
3085 Don't update size until alloc works.
3086
3087 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3088 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3089
3090 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3091 Check for size-calculation overflow.
3092 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3093 do, as we prefer signed integers.
3094 (id_to_widget.max_size, id_to_widget.used)
3095 (xg_store_widget_in_map, xg_remove_widget_from_map)
3096 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3097 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3098 Use and return ptrdiff_t, not int.
3099 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3100 * gtkutil.h: Change prototypes to match the above.
3101
3102 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3103 are duplicate now that they've been promoted to lisp.h.
3104 (x_allocate_bitmap_record, x_alloc_image_color)
3105 (make_image_cache, cache_image, xpm_load):
3106 Don't update size until alloc is done.
3107 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3108 (x_detect_edges):
3256efce 3109 Check for size calculation overflow.
726e0ab1
PE
3110 (ct_colors_allocated_max): New constant.
3111 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3112 overflow.
3256efce 3113
726e0ab1
PE
3114 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3115 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3116 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3117 Use ptrdiff_t, not int, to count maps.
3118 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3119 calculations. Don't update size until allocation succeeds.
3120 Redo calculations to avoid overflow.
726e0ab1
PE
3121 * keyboard.h: Change prototypes to match the above.
3122
3123 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3124 to count maps.
3125 (current_minor_maps): Check for size calculation overflow.
3126 * keymap.h: Change prototypes to match the above.
3127
3128 * lread.c (read1, init_obarray): Don't update size until alloc done.
3129
3130 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3131 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3132
726e0ab1
PE
3133 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3134 Now ptrdiff_t, not int.
3135 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3136 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3137
3138 * process.c (Fnetwork_interface_list): Check for overflow
3139 in size calculation.
3140
3141 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3142
3143 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3144 overflow. Don't bother calling xmalloc when xrealloc will do.
3145
3146 * search.c (Freplace_match): Check for size calculation overflow.
3147 (Fset_match_data): Don't assume list lengths fit in 'int'.
3148
3149 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3150 for command line length. Do not attempt to address one before the
3151 beginning of an array, as that's not portable.
3152
3153 * term.c (max_frame_lines): Remove; unused.
3154 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3155 not int.
3156 (encode_terminal_code, calculate_costs): Check for size
3157 calculation overflow.
3158 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3159 table lengths and related sizes. Don't update size until alloc
3160 done. Redo calculations to avoid overflow.
3161 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3162
3163 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3164 subtracting pointers.
3165 (gobble_line): Check for overflow more carefully. Don't update size
3166 until alloc done.
3167
3168 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3169 Don't update size until alloc done.
3170 Redo size calculations to avoid overflow.
3171 Check for size calculation overflow.
0065d054 3172 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3173
3174 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3175 Use ptrdiff_t, not int, for sizes.
3176 (store_mode_line_noprop_char): Don't update size until alloc done.
3177
0065d054
PE
3178 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3179 Use ptrdiff_t, not int, for sizes.
3180 (Finternal_make_lisp_face, cache_face):
3181 Check for size calculation overflow.
3182 (cache_face): Treat size calculation overflows as if they were
3183 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3184
3185 * xfns.c (x_encode_text, x_set_name_internal)
3186 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3187 sizes, since they can exceed INT_MAX in size. Check for size
3188 calculation overflow.
3189
0065d054
PE
3190 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3191 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3192 Don't update size until alloc done.
3193
0065d054 3194 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3195 as sprintf is limited to int lengths.
1d526e2f 3196
252c5ee1
PE
3197 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3198 (X_LONG_MIN): New macros.
864d7ce7
PE
3199 Use them to make the following changes clearer.
3200 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3201 This change doesn't affect the value now, but it may help remind
3202 future maintainers not to raise the value too much later.
3203 (SELECTION_QUANTUM): Remove, replacing with ...
3204 (selection_quantum): ... new function, which avoids overflow.
3205 All uses changed.
3206 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3207 assumption that selection length fits in 'int'.
3208 (x_reply_selection_request, x_handle_selection_request)
3209 (x_get_window_property, receive_incremental_selection)
3210 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3211 (lisp_data_to_selection_data, clean_local_selection_data):
3212 Use ptrdiff_t, not int, to record length of selection.
3213 (x_reply_selection_request, x_get_window_property)
3214 (receive_incremental_selection, x_property_data_to_lisp):
3215 Redo calculations to avoid overflow.
3216 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3217 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3218 something.
3219 (x_get_window_property, receive_incremental_selection)
3220 (lisp_data_to_selection_data, x_property_data_to_lisp):
3221 Check for size-calculation overflow.
3222 (x_get_window_property, receive_incremental_selection)
3223 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3224 Don't store size until memory allocation succeeds.
3225 (x_get_window_property): Plug memory leak on memory exhaustion.
3226 Don't double-block input; malloc is safe here. Don't assume 2**34
3227 - 4 fits in unsigned long. Add an xassert to check
3228 XGetWindowProperty overflow. Be more careful about overflow
3229 calculations, and distinguish size from memory overflow better.
3230 (receive_incremental_selection): When tracing, don't assume
3231 unsigned int is less than INT_MAX.
3232 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3233 harmful) conversions of unsigned short to int.
3234 (lisp_data_to_selection_data): Don't assume that integers
3235 in the range -65535 through -1 fit in an X unsigned short.
3236 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3237 result parameters unless successful. Rely on cons_to_unsigned
3238 to report problems with elements; the old code wasn't right anyway.
3239 (x_check_property_data): Check for int overflow; we cannot use
3240 a wider type due to X limits.
3241 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3242
726e0ab1 3243 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3244
0065d054
PE
3245 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3246 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3247 (x_color_cells): Don't store size until memory allocation succeeds.
3248 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3249 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3250 (x_term_init): Don't assume length fits in int (sprintf is limited
3251 to int size).
bc18e09d 3252
ebfa62c0
PE
3253 Use ptrdiff_t for composition IDs.
3254 * character.c (lisp_string_width):
3255 * composite.c (composition_table_size, n_compositions)
3256 (get_composition_id, composition_gstring_from_id):
3257 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3258 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3259 * window.c (Frecenter):
3260 Use ptrdiff_t, not int, for composition IDs.
3261 * composite.c (get_composition_id): Check for integer overflow.
3262 * composite.h: Adjust prototypes to match the above changes.
3263
d3411f89
PE
3264 Use ptrdiff_t for hash table indexes.
3265 * category.c (hash_get_category_set):
3266 * ccl.c (ccl_driver):
3267 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3268 * coding.c (coding_system_charset_list, detect_coding_system):
3269 * coding.h (struct coding_system.id):
3270 * composite.c (get_composition_id, gstring_lookup_cache):
3271 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3272 * image.c (xpm_get_color_table_h):
3273 * lisp.h (hash_lookup, hash_put):
3274 * minibuf.c (Ftest_completion):
3275 Use ptrdiff_t for hash table indexes, not int (which is too
3276 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3277 32-bit --with-wide-int hosts).
3278
e097a6fa
PE
3279 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3280 Add a FIXME comment about memory leaks.
3281 (syms_of_charset): Don't assume xmalloc returns.
3282
5637687f
PE
3283 Don't assume that stated character widths fit in int.
3284 * character.c (Fchar_width, c_string_width, lisp_string_width):
3285 * character.h (CHAR_WIDTH):
3286 * indent.c (MULTIBYTE_BYTES_WIDTH):
3287 Use sanitize_char_width to avoid undefined and/or bad behavior
3288 with outlandish widths.
a66cfb1c 3289 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3290 now that we have two such functions. All uses changed.
3291 (sanitize_char_width): New inline function.
3292
a2271ba2
PE
3293 Don't assume that tab-width fits in int.
3294 * character.h (sanitize_width): New inline function.
3295 (SANE_TAB_WIDTH): New macro.
3296 (ASCII_CHAR_WIDTH): Use it.
3297 * indent.c (sane_tab_width): Remove. All uses replaced by
3298 SANE_TAB_WIDTH (current_buffer).
3299 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3300
18c52557
PE
3301 * fileio.c: Integer overflow issues with file modes.
3302 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3303
caeeedc1
PE
3304 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3305 Remove unreachable code.
3306 (read_hex, load_charset_map_from_file): Check for integer overflow.
3307
6df6ae42 3308 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3309 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3310 (x_send_scroll_bar_event): Likewise. Check that the size does not
3311 exceed limits imposed by XClientMessageEvent, as well as the usual
3312 ptrdiff_t and size_t limits.
3313
b13995db
PE
3314 * keyboard.c: Overflow, signedness and related fixes.
3315 (make_lispy_movement): Use same integer type in forward decl
3316 that is used in the definition.
3317 (read_key_sequence, keyremap_step):
3318 Change bufsize argument back to int, undoing my 2011-03-30 change.
3319 We prefer signed types, and int is wide enough here.
3320 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3321 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3322 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3323 length, not size_t. Use ptrdiff_t for index, not int.
3324 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3325 possibility of integer overflow.
3326
13464394
PE
3327 Overflow, signedness and related fixes for images.
3328
3329 * dispextern.h (struct it.stack[0].u.image.image_id)
3330 (struct_it.image_id, struct image.id, struct image_cache.size)
3331 (struct image_cache.used, struct image_cache.ref_count):
3332 * gtkutil.c (update_frame_tool_bar):
3333 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3334 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3335 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3336 * nsmenu.m (update_frame_tool_bar):
3337 * xdisp.c (calc_pixel_width_or_height):
3338 * xfns.c (image_cache_refcount):
3339 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3340 on typical 64-bit hosts.
3341
3342 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3343 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3344 Omit unnecessary casts to int.
3345 (parse_image_spec): Check that integers fall into 'int' range
3346 when the callers expect that.
3347 (image_ascent): Redo ascent calculation to avoid int overflow.
3348 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3349 (lookup_image): Remove unnecessary tests.
3350 (xbm_image_p): Locals are now of int, not EMACS_INT,
3351 since parse_image_check makes sure they fit into int.
3352 (png_load, gif_load, svg_load_image):
3353 Prefer int to unsigned where either will do.
3354 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3355 old tiff_error_handler and tiff_warning_handler.
3356 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3357 stack buffer overflows. It uses only the features of vsnprintf
3358 that are common to both POSIX and native Microsoft.
3359 (tiff_error_handler, tiff_warning_handler): Use it.
3360 (tiff_load, gif_load, imagemagick_load_image):
3361 Don't assume :index value fits in 'int'.
3362 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3363 (imagemagick_load_image): Check that crop parameters fit into
3364 the integer types that MagickCropImage accepts. Don't assume
3365 Vimagemagick_render_type has a nonnegative value. Don't assume
3366 size_t fits in 'long'.
3367 (gs_load): Use printmax_t to print the widest integers possible.
3368 Check for integer overflow when computing image height and width.
3369
c11821d4
EZ
33702011-08-26 Eli Zaretskii <eliz@gnu.org>
3371
3372 * xdisp.c (redisplay_window): Don't force window start if point
3373 will be invisible in the resulting window. (Bug#9324)
3374
0c95fcf7
EZ
33752011-08-25 Eli Zaretskii <eliz@gnu.org>
3376
3377 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3378 the display spec is of the form `(space ...)'.
3379 (handle_display_spec): Return the value returned by
3380 handle_single_display_spec, not just 1 or zero.
3381 (handle_single_display_spec): If the display spec is of the form
3382 `(space ...)', and specifies display in the text area, return 2
3383 rather than 1.
fee65a97 3384 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3385 accurately, and prefer exact match for point under bidi.
3386 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3387
3388 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3389 into disp_prop; all users changed.
3390
3391 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3392 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3393 for the text covered by the display property.
3394
e4ed06f1
CY
33952011-08-25 Chong Yidong <cyd@stupidchicken.com>
3396
3397 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3398 Change return value to nil.
3399 (Frecord_buffer): Delete unused function.
3400
f67cdd7f
EZ
34012011-08-24 Eli Zaretskii <eliz@gnu.org>
3402
5980d4c6
EZ
3403 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3404 buffers, return left-to-right.
8610fe8b
EZ
3405 (set_cursor_from_row): Consider candidate row a win if its glyph
3406 represents a newline and point is on that newline. Fixes cursor
3407 positioning on the newline at EOL of R2L text within L2R
3408 paragraph, and vice versa.
3409 (try_cursor_movement): Check continued rows, in addition to
3410 continuation rows. Fixes unwarranted scroll when point enters a
3411 continued line of R2L text within an L2R paragraph, or vice versa.
3412 (cursor_row_p): Consider the case of point being equal to
3413 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3414 from the end of a short line to the beginning of a continued line
3415 of R2L text within L2R paragraph.
3416 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3417 composed characters.
5980d4c6 3418
f67cdd7f
EZ
3419 * bidi.c (bidi_check_type): Use xassert.
3420 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3421 members.
3422
bca633fb
EZ
34232011-08-23 Eli Zaretskii <eliz@gnu.org>
3424
3425 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3426 a character.
3427
4a5885a7
CY
34282011-08-23 Chong Yidong <cyd@stupidchicken.com>
3429
3430 * nsfont.m (ns_otf_to_script): Fix typo.
3431
0902a04e
KH
34322011-08-22 Kenichi Handa <handa@m17n.org>
3433
3434 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3435 extra slot even if the purpose is char-code-property-table.
3436
1a2e6670
EZ
34372011-08-23 Eli Zaretskii <eliz@gnu.org>
3438
8ddde651
EZ
3439 * xdisp.c (redisplay_window): When computing centering_position,
3440 account for the height of the header line. (Bug#8874)
3441
425cc014
EZ
3442 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3443 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3444 candidate is selected by the mouse, and that candidate has a
3445 composed character under the mouse.
3446
1a2e6670
EZ
3447 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3448 coordinates reported by pos-visible-in-window-p for a composed
3449 character in column zero.
3450
8b76d6f8
SM
34512011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3452
3453 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3454
dac347dd
EZ
34552011-08-22 Eli Zaretskii <eliz@gnu.org>
3456
3457 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3458 consider it a hit if to_charpos is anywhere in the range of the
3459 composed buffer positions.
3460
e013fb34
CY
34612011-08-22 Chong Yidong <cyd@stupidchicken.com>
3462
3463 * image.c (gif_load): Don't assume that each subimage has the same
3464 dimensions as the base image. Handle disposal method that is
3465 "undefined" by the gif spec (Bug#9335).
3466
bd1ba3e8
CY
34672011-08-20 Chong Yidong <cyd@stupidchicken.com>
3468
3469 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3470 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3471
54a1215b
EZ
34722011-08-19 Eli Zaretskii <eliz@gnu.org>
3473
823564e5
EZ
3474 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3475 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3476 from an Org mode buffer to a Speedbar frame.
3477
54a1215b
EZ
3478 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3479 a composition, take its buffer position from IT->cmp_it.charpos.
3480 Fixes cursor positioning at the beginning of a line that begins
3481 with a composed character.
3482
9778ebcc
EZ
34832011-08-18 Eli Zaretskii <eliz@gnu.org>
3484
0be6ee06
EZ
3485 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3486 character bidirectional type, use STRONG_L instead. Fixes crashes
3487 in a buffer produced by `describe-categories'.
3488
9778ebcc
EZ
3489 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3490 members before the level stack, so they would be saved and
3491 restored when copying iterator state. Fixes incorrect reordering
3492 around TABs covered by display properties.
3493
156bffbe
AS
34942011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3495
6b02f655 3496 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3497
72ad093b
CY
34982011-08-17 Chong Yidong <cyd@stupidchicken.com>
3499
3500 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3501 (internal_condition_case_2, internal_condition_case_n):
3502 Remove unnecessary aborts (Bug#9081).
72ad093b 3503
35774242
EZ
35042011-08-17 Eli Zaretskii <eliz@gnu.org>
3505
3506 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3507 has no `load' handler, try opening the file locally. (Bug#9311)
3508
db76dd85
KB
35092011-08-16 Ken Brown <kbrown@cornell.edu>
3510
3511 * gmalloc.c: Expand comment.
3512
b215eee5
EZ
35132011-08-16 Eli Zaretskii <eliz@gnu.org>
3514
3515 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3516 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3517
a4579d33
KB
35182011-08-16 Ken Brown <kbrown@cornell.edu>
3519
3520 Fix memory allocation problems in Cygwin build (Bug#9273).
3521
3522 * unexcw.c ( __malloc_initialized): Declare external variable.
3523 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3524
8b76d6f8
SM
3525 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3526 New variables.
a4579d33
KB
3527 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3528 dumped emacs.
3529 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3530 in the static heap.
3531 [CYGWIN] (special_realloc): New function.
3532 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3533 requests to realloc storage in the static heap.
3534
3ebec551
PE
35352011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3536
3537 * bidi.c (bidi_initialize): Remove unused local.
3538
9fd8be00
EZ
35392011-08-15 Eli Zaretskii <eliz@gnu.org>
3540
6b02f655
SM
3541 * bidimirror.h:
3542 * biditype.h: Remove file.
3543 * makefile.w32-in ($(BLD)/bidi.$(O)):
3544 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3545
3546 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3547
3548 * chartab.c: Improve commentary for the uniprop_table API.
3549
32413314
EZ
3550 * bidi.c (bidi_paragraph_init): Support zero value of
3551 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3552 (bidi_initialize): Use uniprop_table instead of including
3553 biditype.h and bidimirror.h.
32413314 3554
9fd8be00
EZ
3555 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3556 coordinates of the iterator when restoring from ppos_it.
3557 (Bug#9296)
3558
5cf2b69b
KH
35592011-08-14 Kenichi Handa <handa@m17n.org>
3560
3561 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3562 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3563
daf17d00
EZ
35642011-08-14 Eli Zaretskii <eliz@gnu.org>
3565
3566 * xdisp.c (move_it_in_display_line_to): Don't invoke
3567 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3568 ppos_it. Fixes vertical cursor motion when line beginning is
3569 covered by an image. (Bug#9296)
3570
08e3161a
JD
35712011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3572
3573 * nsterm.h (ns_run_ascript): Declare.
3574 (NSAPP_DATA2_RUNASSCRIPT): Define.
3575
3576 * nsfns.m (as_script, as_result, as_status): New static variables.
3577 (ns_run_ascript): New function.
5e617bc2 3578 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3579 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3580 the event loop. Get status from as_status (Bug#7276).
3581
3582 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3583 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3584 the event loop (Bug#7276).
3585
a3720aa2
AS
35862011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3587
3588 * gnutls.c (QCgnutls_bootprop_priority)
3589 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3590 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3591 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3592 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3593 (QCgnutls_bootprop_verify_hostname_error)
3594 (QCgnutls_bootprop_callbacks_verify): Rename from
3595 Qgnutls_bootprop_..., all uses changed.
3596
3597 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3598 uses changed.
3599
0a0d27fb
PE
36002011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3601
19d5c50c
PE
3602 * xfaces.c (Qframe_set_background_mode): Now static.
3603 * dispextern.h (Qframe_set_background_mode): Remove decl.
3604
0a0d27fb
PE
3605 * process.c (Fnetwork_interface_info): Declare local only if needed.
3606
377538cb
JD
36072011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3608
3609 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3610 (Fnetwork_interface_list): Allocate in increments of bytes instead
3611 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3612 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3613 sockaddr.
3614 (struct ifflag_def): notrailers is smart on OSX.
3615 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3616 Get hardware address with getifaddrs if available.
3617
08fff70c
EZ
36182011-08-12 Eli Zaretskii <eliz@gnu.org>
3619
3620 * xdisp.c (iterate_out_of_display_property): xassert that
3621 IT->position is set to within IT->object's boundaries. Break from
3622 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3623 when IT->position is set up wrongly due to some bug.
3624 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3625 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3626 entry. Force push_it to save on the stack the current
3627 buffer/string position, to be restored by pop_it. Fix flags in
3628 the iterator structure wrt the object coming from a display
3629 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3630 properties. (Bug#9284)
3631
7be1c708 36322011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3633
7be1c708
CY
3634 * fontset.c (fontset_get_font_group): Add proper type checks.
3635 (Bug#9172)
aac0c6e3 3636
7be1c708 36372011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3638
7be1c708
CY
3639 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3640 and LC_VERSION_MIN_MACOSX.
3641 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3642 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3643
97bb72a6
EZ
36442011-08-08 Eli Zaretskii <eliz@gnu.org>
3645
3646 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3647 no-display-properties-and-no-overlays under bidi display.
3648 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3649 properties and overlays.
97bb72a6 3650
d5617611
CY
36512011-08-08 Chong Yidong <cyd@stupidchicken.com>
3652
37e11a63
CY
3653 * editfns.c (Fset_time_zone_rule): Document relationship with the
3654 setenv function.
3655
d5617611
CY
3656 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3657 the font entity extracted from the cache (Bug#8109).
3658
58872834
CY
36592011-08-07 Chong Yidong <cyd@stupidchicken.com>
3660
3661 * composite.c (autocmp_chars): Don't reset point. That is done by
3662 restore_point_unwind (Bug#5984).
3663
75bfc667
JL
36642011-08-07 Juri Linkov <juri@jurta.org>
3665
3666 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3667 to show the arg `TIME' instead of `TIMEVAL'.
3668
d1410150
EZ
36692011-08-06 Eli Zaretskii <eliz@gnu.org>
3670
3671 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3672 display property strides EOL and includes a newline, as in
3673 longlines-mode. (Bug#9254)
75b771e4
EZ
3674 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3675 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3676
3677 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3678 is non-zero, even if the data buffer is NULL. Fixes a crash in
3679 vertical-motion with longlines-mode. (Bug#9254)
3680
35928349
EZ
36812011-08-05 Eli Zaretskii <eliz@gnu.org>
3682
ec7cc85b
EZ
3683 * bidi.c <bidi_cache_total_alloc>: Now static.
3684 (bidi_initialize): Initialize bidi_cache_total_alloc.
3685
8b76d6f8 3686 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3687 cache. (Bug#9221)
3688
3689 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3690 amount allocated this far in `bidi_cache_total_alloc'.
3691 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3692 non-zero, only free the data buffer without restoring the cache
3693 contents. All callers changed.
3694
3695 * dispextern.h (bidi_unshelve_cache): Update prototype.
3696
3697 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3698 (move_it_in_display_line, move_it_to)
3699 (move_it_vertically_backward, move_it_by_lines): Replace the call
3700 to xfree to an equivalent call to bidi_unshelve_cache.
3701 (move_it_in_display_line_to): Fix logic of returning
412b6358 3702 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3703
e2e2423b
EZ
37042011-08-05 Eli Zaretskii <eliz@gnu.org>
3705
3706 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3707 came from a string character with a `cursor' property. (Bug#9229)
3708
ae9e757a
JD
37092011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3710
3711 * Makefile.in (LIB_PTHREAD): New variable.
3712 (LIBES): Add LIB_PTHREAD (Bug#9216).
3713
3714 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3715 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3716
213bd7f2
AS
37172011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3718
6b02f655 3719 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3720
99aaf75f
JD
37212011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3722
3723 * xterm.c (x_find_topmost_parent): New function.
3724 (x_set_frame_alpha): Find topmost parent window with
3725 x_find_topmost_parent and set the property there also (bug#9181).
3726 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3727
c74e9d86
PE
37282011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3729
3730 * callproc.c (Fcall_process): Avoid vfork clobbering
3731 the local vars buffer, coding_systems, current_dir.
3732
640c8776
SM
37332011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3734
3735 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3736
f26d0e4c
PE
37372011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3738
8a10d76c
PE
3739 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3740 so that it is not optimized away.
3741
f26d0e4c
PE
3742 * xdisp.c (compute_display_string_pos): Remove unused local.
3743
55439c61
EZ
37442011-08-02 Eli Zaretskii <eliz@gnu.org>
3745
3746 Fix slow cursor motion and scrolling in large buffers with
3747 selective display, like Org Mode buffers. (Bug#9218)
3748
3749 * dispextern.h (struct bidi_it): New member disp_prop_p.
3750
3751 * xdisp.c: Remove one-slot cache of display string positions.
3752 (compute_display_string_pos): Accept an additional argument
5e617bc2 3753 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3754 for a display string or property. If found, set DISP_PROP_P
3755 non-zero.
3756
3757 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3758 DISP_PROP_P, and pass it to compute_display_string_pos.
3759 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3760 non-zero. All callers of bidi_fetch_char changed.
3761
fb33fa43
SM
37622011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3763
3764 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3765
b099e063
DM
37662010-12-03 Don March <don@ohspite.net>
3767
3768 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3769 last character M-[char] is translated to ESC [char] (bug#7541).
3770
5cc7f7af
KH
37712011-08-02 Kenichi Handa <handa@m17n.org>
3772
d0fffa3f 3773 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3774
3775 * chartab.c (uniprop_table): Make it non-static.
3776
525d5e6e
EZ
37772011-08-01 Eli Zaretskii <eliz@gnu.org>
3778
3779 * xdisp.c (forward_to_next_line_start): Accept additional argument
3780 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3781 on the newline.
3782 (reseat_at_next_visible_line_start): Use the bidi iterator state
3783 returned by forward_to_next_line_start to restore the state of
3784 it->bidi_it after backing up to previous newline. (Bug#9212)
3785
31011111
AS
37862011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3787
3788 * regex.c (re_comp): Protoize.
3789 (re_exec): Fix return type.
3790 (regexec): Fix type of `ret'. (Bug#9203)
3791
476371c4
PE
37922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3793
e5d76069
PE
3794 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3795 This is needed if max-image-size is a floating-point number.
3796
9a79b20c
AS
37972011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3798
3799 * print.c (print_object): Print empty symbol as ##.
3800
3801 * lread.c (read1): Read ## as empty symbol.
3802
d8c2fa78
AA
38032011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3804
3805 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3806 setting frame foreground color (Bug#9175).
3807 (x_set_background_color): Likewise.
3808
ffe57a7a
AA
3809 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3810 contents (Bug#9176).
3811 (EmacsTooltip -init): Remove bezels and add shadows to
3812 tooltip windows.
3813
bf3492a5
AA
3814 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3815 or scroll bar (Bug#8470).
3816
d55e9c53
AA
3817 * nsfont.m (nsfont_open): Remove assignment to voffset and
3818 unnecessary vars hshink, expand, hd, full_height, min_height.
3819 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3820
3821 * nsterm.h (nsfont_info): Remove voffset field.
3822
d8c2fa78 38232011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3824
3825 Implement strike-through and overline on NextStep (Bug#8863).
3826
3827 * nsfont.m (nsfont_open): Use underline position provided by font,
3828 instead of hard-coded value of 2.
3829 (nsfont_draw): Call ns_draw_text_decoration instead.
3830
3831 * nsterm.h: Add declaration for ns_draw_text_decoration.
3832
3833 * nsterm.m (ns_draw_text_decoration): New function for drawing
3834 underline, overline, and strike-through.
3835 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3836 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3837 accommodate underlining, etc.
4843aac3 3838
4cc60b9b
EZ
38392011-07-28 Eli Zaretskii <eliz@gnu.org>
3840
bc7ece87
EZ
3841 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3842 default.
4cc60b9b 3843
476371c4
PE
38442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3845
66606eea
PE
3846 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3847 Without this fix, if a signal arrives just after memory fills up,
3848 'malloc' might be invoked reentrantly.
3849
476371c4
PE
3850 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3851 In other words, assume that every image size is allowed, on non-X
3852 hosts. This assumption is probably wrong, but it lets Emacs compile.
3853
f3fcc40d
AS
38542011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3855
3856 * regex.c (re_iswctype): Convert return values to boolean.
3857
350c992f
EZ
38582011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3859
3860 * xdisp.c (compute_display_string_pos): Don't use cached display
3861 string position if the buffer had its restriction changed.
3862 (Bug#9184)
3863
5266b4bb
PE
38642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3865
3866 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3867
2573a837 38682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3869
41f55ccd 3870 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3871
39e378da
PE
3872 * bidi.c: Integer size and overflow fixes.
3873 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3874 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3875 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3876 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3877 (bidi_find_other_level_edge):
3878 Use ptrdiff_t instead of EMACS_INT where either will do.
3879 This works better on 32-bit hosts configured --with-wide-int.
3880 (bidi_cache_ensure_space): Check for size-calculation overflow.
3881 Use % rather than repeated addition, for better worst-case speed.
3882 Don't set bidi_cache_size until after xrealloc returns, because it
3883 might not return.
3884 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3885 (bidi_cache_ensure_space): Also check that the bidi cache size
3886 does not exceed that of the largest Lisp string or buffer. See Eli
3887 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3888
5e927815
PE
3889 * alloc.c (__malloc_size_t): Remove.
3890 All uses replaced by size_t. See Andreas Schwab's note
3891 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3892
ca4aa935
PE
3893 * image.c: Improve checking for integer overflow.
3894 (check_image_size): Assume that f is nonnull, since
3895 it is always nonnull in practice. This is one less thing to
3896 worry about when checking for integer overflow later.
3897 (x_check_image_size): New function, which checks for integer
3898 overflow issues inside X.
3899 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3900 This removes the need for a memory_full check.
3901 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3902 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3903 (xbm_read_bitmap_data): Change locals back to 'int', since
3904 their values must fit in 'int'.
3905 (xpm_load_image, png_load, tiff_load):
3906 Invoke x_create_x_image_and_pixmap earlier,
3907 to avoid much needless work if the image is too large.
3908 (tiff_load): Treat overly large images as if
3909 x_create_x_image_and_pixmap failed, not as malloc failures.
3910 (gs_load): Use x_check_image_size.
3911
5f8f9cc2
PE
3912 * gtkutil.c: Omit integer casts.
3913 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3914 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3915
5adf60bc
PE
3916 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3917
c8907a93
PE
3918 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3919 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3920 would wrongly return t on a 64-bit host.
3921
e3c25c68
PE
3922 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3923 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3924 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3925 and therefore cause GCC to emit a bogus diagnostic in some cases.
3926
3f791afe
PE
3927 * image.c: Integer signedness and overflow and related fixes.
3928 This is not an exhaustive set of fixes, but it's time to
3929 record what I've got.
3930 (lookup_pixel_color, check_image_size): Remove redundant decls.
3931 (check_image_size): Don't assume that arbitrary EMACS_INT values
3932 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3933 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3934 (tiff_load, imagemagick_load_image):
3935 Check for overflow in size calculations.
3936 (x_create_x_image_and_pixmap): Remove unnecessary test for
3937 xmalloc returning NULL; that can't happen.
3938 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3939 (xpm_color_bucket): Use better integer hashing function.
3940 (xpm_cache_color): Don't possibly over-allocate memory.
3941 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3942 (gif_memory_source):
3943 Use ptrdiff_t, not int or size_t, to record sizes.
3944 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3945 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3946 either works, as we prefer signed integers.
3947 (tiff_read_from_memory, tiff_write_from_memory):
3948 Return tsize_t, not size_t, since that's what the TIFF API wants.
3949 (tiff_read_from_memory): Don't fail simply because the read would
3950 go past EOF; instead, return a short read.
3951 (tiff_load): Omit no-longer-needed casts.
3952 (Fimagemagick_types): Don't assume size fits into 'int'.
3953
3cc5a532
PE
3954 Improve hashing quality when configured --with-wide-int.
3955 * fns.c (hash_string): New function, taken from sxhash_string.
3956 Do not discard information about ASCII character case; this
3957 discarding is no longer needed.
3958 (sxhash-string): Use it. Change sig to match it. Caller changed.
3959 * lisp.h: Declare it.
3960 * lread.c (hash_string): Remove, since we now use fns.c's version.
3961 The fns.c version returns a wider integer if --with-wide-int is
3962 specified, so this should help the quality of the hashing a bit.
3963
b312a492
PE
3964 * emacs.c: Integer overflow minor fix.
3965 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3966 Define only if GNU_LINUX.
3967 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3968
dfd153ae
PE
3969 * dispnew.c: Integer signedness and overflow fixes.
3970 Remove unnecessary forward decls, that were a maintenance hassle.
3971 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3972 All uses changed.
3973 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3974 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3975 (prepare_desired_row, line_draw_cost):
3976 Use int, not unsigned, where either works.
3977 (save_current_matrix, restore_current_matrix):
3978 Use ptrdiff_t, not size_t, where either works.
3979 (init_display): Check for overflow more accurately, and without
3980 relying on undefined behavior.
3981
a81d11a3
PE
3982 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3983 Remove, replacing with the new symbols in lisp.h. All uses changed.
3984 * fileio.c (make_temp_name):
3985 * filelock.c (lock_file_1, lock_file):
3986 * xdisp.c (message_dolog):
3987 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3988 Use pMd etc. instead.
3989 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3990 replacing the pWIDE etc. symbols removed from editfns.c.
3991
3300e6fd
PE
3992 * keyboard.h (num_input_events): Now uintmax_t.
3993 This is (very slightly) less likely to mess up due to wraparound.
3994 All uses changed.
3995
fd05c7e9
PE
3996 * buffer.c: Integer signedness fixes.
3997 (alloc_buffer_text, enlarge_buffer_text):
3998 Use ptrdiff_t rather than size_t when either will do, as we prefer
3999 signed integers.
4000
903fe15d
PE
4001 * alloc.c: Integer signedness and overflow fixes.
4002 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4003 (__malloc_size_t): Default to size_t, not to int.
4004 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4005 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4006 Prefer ptrdiff_t to size_t when either would do, as we prefer
4007 signed integers.
4008 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4009 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4010 Now const. Initialize with values that are in range even if char
4011 is signed.
4012 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4013 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4014 These functions do the right thing with sizes > 2**32.
4015 (check_depth): Now ptrdiff_t, not int.
4016 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4017 Adjust to new way of storing sizes. Check for size overflow bugs
4018 in rest of code.
4019 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4020 slightly wrong anyway, as it missed one instance of
4021 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4022 (refill_memory_reserve): Omit needless cast to size_t.
4023 (mark_object_loop_halt): Mark as externally visible.
4024
ac82cc6a
PE
4025 * xselect.c: Integer signedness and overflow fixes.
4026 (Fx_register_dnd_atom, x_handle_dnd_message):
4027 Use ptrdiff_t, not size_t, since we prefer signed.
4028 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4029 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4030 x_dnd_atoms_size and x_dnd_atoms_length.
4031
c2d1e36d
PE
4032 * doprnt.c: Prefer signed to unsigned when either works.
4033 * eval.c (verror):
4034 * doprnt.c (doprnt):
4035 * lisp.h (doprnt):
4036 * xdisp.c (vmessage):
4037 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4038 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4039 prefer signed arithmetic to avoid comparison confusion.
4040 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4041 but is a bit tricky.
4042
0e926e56
PE
4043 Assume freestanding C89 headers, string.h, stdlib.h.
4044 * data.c, doprnt.c, floatfns.c, print.c:
4045 Include float.h unconditionally.
4046 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4047 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4048 * regex.c: Likewise for stddef.h, string.h.
4049 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4050 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4051 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4052 (STDC_HEADERS): Remove obsolete defines.
4053 * sysdep.c: Include limits.h unconditionally.
4054
9cfdb3ec
PE
4055 Assume support for memcmp, memcpy, memmove, memset.
4056 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4057 * regex.c (memcmp, memcpy):
4058 Remove; we assume C89 now.
4059
4060 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4061 (__malloc_safe_bcopy): Remove; no longer needed.
4062
cf950e6b 4063 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
4064 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4065 well either way, and we prefer signed to unsigned.
4066
dbf38e02
LMI
40672011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4068
4069 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4070 closes the connection while we're reading (bug#9182).
4071
d6f0886c 40722011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 4073
d6f0886c
JD
4074 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4075 are specified (Bug#9168).
24e0f6b1 4076
2eb1f9e6
PE
40772011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4078
4079 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4080 Found by GCC static checking and --with-wide-int on a 32-bit host.
4081
22381272 40822011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4083
4084 * xdisp.c (compute_display_string_pos): Fix logic of caching
4085 previous display string position. Initialize cached_prev_pos to
4086 -1. Fixes slow-down at the beginning of a buffer.
4087
f25e39b4
EZ
40882011-07-24 Eli Zaretskii <eliz@gnu.org>
4089
4090 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4091 for attrs[LFACE_FONTSET_INDEX].
4092
04c4b52e
PE
40932011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4094
4095 * xml.c (parse_region): Remove unused local
4096 that was recently introduced.
4097
c1734fbd
EZ
40982011-07-23 Eli Zaretskii <eliz@gnu.org>
4099
be18c5a5
EZ
4100 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4101 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4102
c1734fbd
EZ
4103 * xdisp.c (move_it_in_display_line_to): Record the best matching
4104 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4105 exit if none of the characters scanned was an exact match.
4106 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4107 when exact match is impossible due to invisible text, and the
4108 lines are truncated.
4109
a258d627
JD
41102011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4111
4112 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4113 for OSX >= 10.7.
4114
b6d5a689
EZ
41152011-07-22 Eli Zaretskii <eliz@gnu.org>
4116
0f74f785
EZ
4117 Fix a significant slow-down of cursor motion with C-n, C-p,
4118 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4119 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4120 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4121 (next_element_from_buffer): Call compute_stop_pos_backwards to
4122 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4123 base_level_stop.
4124 (reseat): Don't look for prev_stop, as that could mean a very long
4125 run.
4126 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4127 <cached_disp_overlay_modiff>: Cache for last found display string
4128 position.
551918c1 4129 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4130 about the same buffer in the same area of character positions, and
4131 the buffer wasn't changed since the time the display string
4132 position was cached.
551918c1 4133
b2d0c91a
EZ
41342011-07-22 Eli Zaretskii <eliz@gnu.org>
4135
4136 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4137 is an integer, which is important for empty lines. (Bug#9149)
4138
043604ee
CY
41392011-07-22 Chong Yidong <cyd@stupidchicken.com>
4140
4141 * frame.c (Fmodify_frame_parameters): In tty case, update the
4142 default face if necessary (Bug#4238).
4143
da4adb04
CY
41442011-07-21 Chong Yidong <cyd@stupidchicken.com>
4145
4146 * editfns.c (Fstring_to_char): No need to explain what a character
4147 is in the docstring (Bug#6576).
4148
9abd0532
LMI
41492011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4150
4151 * xml.c (parse_region): Make sure we always return a tree.
4152
36881d16
HK
41532011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4154
4155 * xml.c (parse_region): If a document contains only comments,
4156 return that, too.
4157
1e98674d
LMI
41582011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4159
4160 * xml.c (make_dom): Return comments, too.
4161
590bd467
PE
41622011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4163
4164 Port to OpenBSD.
4165 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4166 and the surrounding thread.
4167 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4168 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4169 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4170 timer goes off.
4171 * s/openbsd.h (BROKEN_SIGIO): Define.
4172 * unexelf.c (unexec) [__OpenBSD__]:
4173 Don't update the .mdebug section of the Alpha COFF symbol table.
4174
f41628b2
LMI
41752011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4176
4177 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4178 (bug#8460).
4179
b59b67c5
PE
41802011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4181
15e3a074
PE
4182 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4183 This fixes some race conditions on the permissions of any newly
4184 created file.
4185
41bed37d
PE
4186 * alloc.c (valid_pointer_p): Use pipe, not open.
4187 This fixes some permissions issues when debugging.
4188
b59b67c5
PE
4189 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4190 If fchown fails to set both uid and gid, try to set just gid,
4191 as that is sometimes allowed. Adjust the file's mode to eliminate
4192 setuid or setgid bits that are inappropriate if fchown fails.
4193
925a6be7
SM
41942011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4195
4196 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4197 to compare Lisp_Objects.
4198 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4199 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4200 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4201
52968808
AS
42022011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4203
0a6a104b
AS
4204 * lread.c (read_integer): Unread even EOF character.
4205 (read1): Likewise. Properly record start position of symbol.
4206
52968808
AS
4207 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4208 symbol character follows.
4209
9e381cdd
PE
42102011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4211
4212 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4213 This works around a problem with the previous change to Fcopy_file.
4214 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4215 and without this change, GCC might complain about discarding
4216 fchown's return value.
4217
b5641435
JB
42182011-07-16 Juanma Barranquero <lekktu@gmail.com>
4219
4220 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4221
a8031457
PE
42222011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4223
4224 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4225
dd889327
LMI
42262011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4227
750c33f7
LMI
4228 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4229 it's used from the C level.
4230
dd889327
LMI
4231 * process.c: Use the same condition for POLL_FOR_INPUT in both
4232 keyboard.c and process.c (bug#1858).
4233
87e86684
LM
42342011-07-09 Lawrence Mitchell <wence@gmx.li>
4235
4236 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4237 (Fgnutls_boot): Use it.
4238
64348f40
AS
42392011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4240
4241 * doc.c (Fsubstitute_command_keys): Revert last change.
4242
1d698799
LMI
42432011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4244
f863868c
LMI
4245 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4246 quotes the next character, and doesn't affect other longer
4247 sequences (bug#8935).
4248
1d698799
LMI
4249 * lread.c (syms_of_lread): Clarify that is isn't only
4250 `eval-buffer' and `eval-defun' that's affected by
4251 `lexical-binding' (bug#8460).
4252
aa4b6df6
EZ
42532011-07-15 Eli Zaretskii <eliz@gnu.org>
4254
4255 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4256 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4257
5d856da6
PE
42582011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4259
ad6042bb
PE
4260 Fix minor problems found by static checking.
4261 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4262 (elsz): Now a signed constant, not a size_t var. We prefer signed
4263 types to unsigned, to avoid integer comparison confusion. Without
4264 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4265 "cannot optimize loop, the loop counter may overflow", a symptom
4266 of the confusion.
f00bbb22 4267 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4268 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4269
6468f31c
LMI
42702011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4271
49080b10
LMI
4272 * search.c (Fre_search_backward): Mention `case-fold-search' in
4273 all the re_search_* functions (bug#8138).
4274
6468f31c
LMI
4275 * keyboard.c (Fopen_dribble_file): Document when the file is
4276 closed (bug#8056).
4277
c965adc5
EZ
42782011-07-14 Eli Zaretskii <eliz@gnu.org>
4279
df9733bf
EZ
4280 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4281 bidi_cache_idx.
4282
0bb23927
EZ
4283 Support bidi reordering of display and overlay strings.
4284 * xdisp.c (compute_display_string_pos)
4285 (compute_display_string_end): Accept additional argument STRING.
4286 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4287 (reseat_to_string): Initialize bidi_it->string.s and
4288 bidi_it->string.schars.
4289 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4290 NULL (avoids a crash in bidi_paragraph_init).
4291 Initialize itb.string.lstring.
0bb23927
EZ
4292 (init_iterator): Call bidi_init_it only of a valid
4293 buffer position was specified. Initialize paragraph_embedding to
4294 L2R.
4295 (reseat_to_string): Initialize the bidi iterator.
4296 (display_string): If we need to ignore text properties of
4297 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4298 original value of -1 will not work with bidi.)
4299 (compute_display_string_pos): First arg is now struct
4300 `text_pos *'; all callers changed. Support display properties on
4301 Lisp strings.
4302 (compute_display_string_end): Support display properties on Lisp
4303 strings.
4304 (init_iterator, reseat_1, reseat_to_string): Initialize the
4305 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4306 when iterating on a string not from display properties).
640c8776
SM
4307 (compute_display_string_pos, compute_display_string_end):
4308 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4309 arrow keys.
4310 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4311 base_level_stop; instead, set base_level_stop to BEGV.
4312 Fixes crashes in vertical-motion.
0bb23927
EZ
4313 (next_element_from_buffer): Improve commentary for when
4314 the iterator is before prev_stop.
4315 (init_iterator): Initialize bidi_p from the default value of
4316 bidi-display-reordering, not from buffer-local value. Use the
4317 buffer-local value only if initializing for buffer iteration.
4318 (handle_invisible_prop): Support invisible properties on strings
4319 that are being bidi-reordered.
4320 (set_iterator_to_next): Support bidi reordering of C strings and
4321 Lisp strings.
4322 (next_element_from_string): Support bidi reordering of Lisp
4323 strings.
4324 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4325 (display_string): Support display of R2L glyph rows.
4326 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4327 (init_iterator): Don't initialize it->bidi_p for strings
4328 here.
4329 (reseat_to_string): Initialize it->bidi_p for strings here.
4330 (next_element_from_string, next_element_from_c_string)
4331 (next_element_from_buffer): Add xassert's for correspondence
4332 between IT's object being iterated and it->bidi_it.string
4333 structure.
4334 (face_before_or_after_it_pos): Support bidi iteration.
4335 (next_element_from_c_string): Handle the case of the first string
4336 character that is not the first one in the visual order.
4337 (get_visually_first_element): New function, refactored from common
4338 parts of next_element_from_buffer, next_element_from_string, and
4339 next_element_from_c_string.
4340 (tool_bar_lines_needed, redisplay_tool_bar)
4341 (display_menu_bar): Force left-to-right direction. Add a FIXME
4342 comment for making that be controlled by a user option.
4343 (push_it, pop_it): Save and restore the state of the
4344 bidi iterator. Save and restore the bidi_p flag.
4345 (pop_it): Iterate out of display property for string iteration as
4346 well.
4347 (iterate_out_of_display_property): Support iteration over strings.
4348 (handle_single_display_spec): Set up it->bidi_it for iteration
4349 over a display string, and call bidi_init_it.
4350 (handle_single_display_spec, next_overlay_string)
4351 (get_overlay_strings_1, push_display_prop): Set up the bidi
4352 iterator for displaying display or overlay strings.
4353 (forward_to_next_line_start): Don't use the shortcut if
4354 bidi-iterating.
4355 (back_to_previous_visible_line_start): If handle_display_prop
4356 pushed the iterator stack, restore the internal state of the bidi
4357 iterator by calling bidi_pop_it same number of times.
4358 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4359 and we are bidi-iterating, don't decrement the iterator position;
4360 instead, set the first_elt flag in the bidi iterator, to produce
4361 the same effect.
4362 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4363 (push_display_prop): xassert that we are iterating a buffer.
4364 (push_it, pop_it): Save and restore paragraph_embedding member.
4365 (handle_single_display_spec, next_overlay_string)
4366 (get_overlay_strings_1, reseat_1, reseat_to_string)
4367 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4368 correctly. Don't assume unibyte strings are not bidi-reordered.
4369 (compute_display_string_pos)
4370 (compute_display_string_end): Fix handling the case of C string.
4371 (push_it, pop_it): Save and restore from_disp_prop_p.
4372 (handle_single_display_spec, push_display_prop): Set the
4373 from_disp_prop_p flag.
4374 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4375 (pop_it): Call iterate_out_of_display_property only if we are
4376 popping after iteration over a string that came from a display
4377 property. Fix a typo in popping stretch info. Add an assertion
4378 for verifying that the iterator position is in sync with the bidi
4379 iterator.
4380 (handle_single_display_spec, get_overlay_strings_1)
4381 (push_display_prop): Fix initialization of paragraph direction for
4382 string when that of the parent object is not yet determined.
4383 (reseat_1): Call bidi_init_it to resync the bidi
4384 iterator with IT's position. (Bug#7616)
4385 (find_row_edges): If ROW->start.pos gives position
4386 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4387 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4388 Reset the from_disp_prop_p flag.
4389 (SAVE_IT, RESTORE_IT): New macros.
4390 (pos_visible_p, face_before_or_after_it_pos)
4391 (back_to_previous_visible_line_start)
4392 (move_it_in_display_line_to, move_it_in_display_line)
4393 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4394 (try_scrolling, redisplay_window, display_line): Use them when
4395 saving a temporary copy of the iterator and restoring it back.
4396 (back_to_previous_visible_line_start, reseat_1)
4397 (init_iterator): Empty the bidi cache "stack".
4398 (move_it_in_display_line_to): If iterator ended up at
4399 EOL, but we never saw any buffer positions smaller than
4400 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4401 motion in bidi-reordered lines.
4402 (move_it_in_display_line_to): Record prev_method and prev_pos
4403 immediately before the call to set_iterator_to_next. Fixes cursor
4404 motion in bidi-reordered lines with stretch glyphs and strings
4405 displayed in margins. (Bug#8133) (Bug#8867)
4406 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4407 TO_CHARPOS.
640c8776
SM
4408 (pos_visible_p): Support positions in bidi-reordered lines.
4409 Save and restore bidi cache.
0bb23927
EZ
4410
4411 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4412 (bidi_paragraph_info): Delete unused struct.
4413 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4414 (bidi_cache_start): New variable.
4415 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4416 to zero.
4417 (bidi_cache_fetch_state, bidi_cache_search)
4418 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4419 (bidi_cache_find, bidi_peek_at_next_level)
4420 (bidi_level_of_next_char, bidi_find_other_level_edge)
4421 (bidi_move_to_visually_next): Compare cache index with
4422 bidi_cache_start rather than with zero.
4423 (bidi_fetch_char): Accept new argument STRING; all callers
4424 changed. Support iteration over a string. Support strings with
4425 display properties. Support unibyte strings. Fix the type of
4426 `len' according to what STRING_CHAR_AND_LENGTH expects.
4427 (bidi_paragraph_init, bidi_resolve_explicit_1)
4428 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4429 (bidi_level_of_next_char, bidi_move_to_visually_next):
4430 Support iteration over a string.
0bb23927
EZ
4431 (bidi_set_sor_type, bidi_resolve_explicit_1)
4432 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4433 can now be zero (for strings); special values 0 and -1 were
4434 changed to -1 and -2, respectively.
4435 (bidi_char_at_pos): New function.
4436 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4437 Call it instead of FETCH_MULTIBYTE_CHAR.
4438 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4439 initialized to valid values.
4440 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4441 values.
4442 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4443 the test for valid cached positions. Fix the logic for looking up
4444 the sentinel state in the cache. GCPRO the Lisp string we are
4445 iterating.
4446 (bidi_push_it, bidi_pop_it): New functions.
4447 (bidi_initialize): Initialize the bidi cache start stack pointer.
4448 (bidi_cache_ensure_space): New function, refactored from part of
4449 bidi_cache_iterator_state. Don't assume the required size is just
4450 one BIDI_CACHE_CHUNK away.
4451 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4452 (bidi_count_bytes, bidi_char_at_pos): New functions.
4453 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4454 always valid if bidi_cache_idx is valid.
4455 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4456 is valid if it's going to be used.
4457 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4458 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4459 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4460 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4461 (bidi_find_other_level_edge, bidi_cache_start_stack):
4462 All variables related to cache indices are now EMACS_INT.
c965adc5 4463
0bb23927
EZ
4464 * dispextern.h (struct bidi_string_data): New structure.
4465 (struct bidi_it): New member `string'. Make flag members be 1-bit
4466 fields, and put them last in the struct.
640c8776
SM
4467 (compute_display_string_pos, compute_display_string_end):
4468 Update prototypes.
0bb23927
EZ
4469 (bidi_push_it, bidi_pop_it): Add prototypes.
4470 (struct iterator_stack_entry): New members bidi_p,
4471 paragraph_embedding, and from_disp_prop_p.
4472 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4473 (bidi_shelve_cache, bidi_unshelve_cache):
4474 Declare prototypes.
0bb23927
EZ
4475
4476 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4477 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4478 and vector-like objects.
4479
4480 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4481 cache around display iteration.
4482
4483 * window.c (Fwindow_end, window_scroll_pixel_based)
4484 (displayed_window_lines, Frecenter): Save and restore the bidi
4485 cache around display iteration.
4486
3bbd2265
LMI
44872011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4488
4489 * editfns.c (Fdelete_region): Clarify the use of the named
4490 parameters (bug#6788).
4491
adc47434
MR
44922011-07-14 Martin Rudalics <rudalics@gmx.at>
4493
4494 * indent.c (Fvertical_motion): Set and restore w->pointm when
4495 saving and restoring the window's buffer (Bug#9006).
4496
837c31f8
LMI
44972011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4498
4499 * editfns.c (Fstring_to_char): Clarify just what is returned
4500 (bug#6576). Text by Eli Zaretskii.
4501
ac389d0c
JB
45022011-07-13 Juanma Barranquero <lekktu@gmail.com>
4503
4504 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4505
0be0ce47
EZ
45062011-07-13 Eli Zaretskii <eliz@gnu.org>
4507
4508 * buffer.c (mmap_find): Fix a typo.
4509
cd18e7e3
JB
45102011-07-13 Johan Bockgård <bojohan@gnu.org>
4511
4512 Fix execution of x selection hooks.
4513 * xselect.c (Qx_lost_selection_functions)
4514 (Qx_sent_selection_functions): New vars.
4515 (syms_of_xselect): DEFSYM them.
4516 (x_handle_selection_request): Pass Qx_sent_selection_functions
4517 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4518 (x_handle_selection_clear,x_clear_frame_selections):
4519 Pass Qx_lost_selection_functions rather than
4520 Vx_lost_selection_functions to Frun_hook_with_args.
4521
47ea7f44
PE
45222011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4523
ac389d0c 4524 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4525 The old code sometimes used this field without initializing it.
4526
47ea7f44
PE
4527 * alloc.c (gc_sweep): Don't read past end of array.
4528 In theory, the old code could also have corrupted Emacs internals,
4529 though it'd be very unlikely.
4530
bc985c87
AS
45312011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4532
4533 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4534 argument. (Bug#4026)
bc985c87 4535
0cf34688
LMI
45362011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4537
b3dadd76
LMI
4538 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4539 key" (bug#4257).
4540
0cf34688
LMI
4541 * window.c (Fset_window_start): Doc fix (bug#4199).
4542 (Fset_window_hscroll): Ditto.
4543
270768cd
PE
45442011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4545
077e3dda 4546 Fix minor new problems caught by GCC 4.6.1.
270768cd 4547 * term.c (init_tty): Remove unused local.
490011a6 4548 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4549 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4550 not used otherwise.
270768cd 4551
b1f58454
CY
45522011-07-12 Chong Yidong <cyd@stupidchicken.com>
4553
4554 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4555
22b9578d
LMI
45562011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4557
6e70ab07
LMI
4558 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4559 are the mini-buffer and the echo area (bug#3320).
4560
22b9578d
LMI
4561 * term.c (init_tty): Remove support for supdup, c10 and perq
4562 terminals, which are no longer supported (bug#1482).
4563
8974cc9f
JB
45642011-07-10 Johan Bockgård <bojohan@gnu.org>
4565
4566 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4567
a560d974
JD
45682011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4569
4570 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4571 for non-popups (Bug#3642).
4572
1dae0f0a
AS
45732011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4574
268c2c36 4575 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4576 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4577 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4578 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4579 * data.c (fmod): Likewise.
4580 * dispnew.c (swap_glyphs_in_rows): Likewise.
4581 * emacs.c (memory_warning_signal): Likewise.
4582 * floatfns.c (float_error): Likewise.
4583 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4584 (otf_open, font_otf_capability, generate_otf_features)
4585 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4586 Likewise.
4587 * image.c (pbm_read_file): Likewise.
4588 * indent.c (string_display_width): Likewise.
4589 * intervals.c (check_for_interval, search_for_interval)
4590 (inc_interval_count, count_intervals, root_interval)
4591 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4592 * lread.c (defalias): Likewise.
268c2c36 4593 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4594 * regex.c (set_image_of_range_1, set_image_of_range)
4595 (regex_grow_registers): Likewise.
4596 * sysdep.c (strerror): Likewise.
4597 * termcap.c (valid_filename_p, tprint, main): Likewise.
4598 * tparam.c (main): Likewise.
4599 * unexhp9k800.c (run_time_remap, save_data_space)
4600 (update_file_ptrs, read_header, write_header, calculate_checksum)
4601 (copy_file, copy_rest, display_header): Likewise.
4602 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4603 Likewise.
4604 * xdisp.c (check_it): Likewise.
4605 * xfaces.c (register_color, unregister_color, unregister_colors):
4606 Likewise.
4607 * xfns.c (print_fontset_result): Likewise.
4608 * xrdb.c (member, fatal, main): Likewise.
4609
99033785
PE
46102011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4611
4612 Fix minor problems found by static checking (Bug#9031).
4613 * chartab.c (char_table_set_range, map_sub_char_table):
4614 Remove unused locals.
4615 (uniprop_table): Now static.
4616 * composite.c (_work_char): Remove unused static var.
4617
9cb2ac56
JB
46182011-07-09 Juanma Barranquero <lekktu@gmail.com>
4619
4620 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4621
f25661f0
JD
46222011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4623
4624 * gtkutil.c (qttip_cb): Remove code without function.
4625
8278c4fe
EZ
46262011-07-09 Eli Zaretskii <eliz@gnu.org>
4627
4628 * w32.c (pthread_sigmask): New stub.
4629
1692ae2d 46302011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4631
8a6ebd58 4632 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4633 sigprocmask is portable only for single-threaded applications, and
4634 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4635 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4636 (LIBES): Use it.
4637 * callproc.c (Fcall_process):
4638 * process.c (create_process):
4639 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4640 Use pthread_sigmask, not sigprocmask.
123403e4 4641
1b854618
JD
46422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4643
4644 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4645 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4646 wrong (Bug#8591).
4647
3fe4b549
JD
46482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4649
0ce7e563
JD
4650 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4651 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4652 (xg_hide_tooltip): Fix comment.
4653
3fe4b549
JD
4654 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4655 in registerServicesMenuSendTypes.
4656 (validRequestorForSendType): Don't check ns_return_types.
4657
4658 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4659 ns_return_type.
4660
5df75e47
JR
46612011-07-08 Jason Rumney <jasonr@gnu.org>
4662
22610910
JR
4663 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4664 SH_SHOW for hidden windows (Bug#5482).
4665
5df75e47
JR
4666 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4667 frame struct members of non-existent frames (Bug#6284).
4668
699c10bd
JD
46692011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4670
4393663b
JD
4671 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4672 variable firstTime not needed on OSX >= 10.6.
4673 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4674 >= 10.5. Use setKnobProportion, setDoubleValue.
4675
4676 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4677 (MAC_OS_X_VERSION_10_5): Define if not defined.
4678 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4679 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4680 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4681
4682 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4683 cString and lossyCString on OSX >= 10.4
4684
58179cce 4685 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4686 sizeToFit on OSX >= 10.2.
4687
4688 * nsimage.m (allocInitFromFile): Don't use deprecated method
4689 bestRepresentationForDevice on OSX >= 10.6.
4690
4691 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4692 to avoid warning.
4693
4694 * emacs.c: Declare unexec_init_emacs_zone.
4695
a63e0781
JD
4696 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4697
699c10bd
JD
4698 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4699
4700 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4701 on svcsMenu (Bug#8842).
4702
4703 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4704 ns_return_types.
4705 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4706
4707 * nsterm.m (QUTF8_STRING): Declare.
4708 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4709 (validRequestorForSendType): Return type is (id).
4710 Change indexOfObjectIdenticalTo to indexOfObject.
4711 Check if we have local selection before returning self (Bug#8842).
4712 (writeSelectionToPasteboard): Put local selection into paste board
4713 if we have a local selection (Bug#8842).
4714 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4715
4716 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4717 (ns_get_local_selection): Declare.
4718
54e10184
LMI
47192011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4720
9888ff71
LMI
4721 * keymap.c (describe_map_tree): Don't insert a double newline at
4722 the end of the buffer (bug#1169) and return whether we inserted
4723 something.
4724
54e10184
LMI
4725 * callint.c (Fcall_interactively): Change "reading args" to
4726 "providing args" to try to clarify what it does (bug#1010).
4727
15fa4783
KH
47282011-07-07 Kenichi Handa <handa@m17n.org>
4729
4730 * composite.c (composition_compute_stop_pos): Ignore a static
4731 composition starting before CHARPOS (Bug#8915).
4732
4733 * xdisp.c (handle_composition_prop): Likewise.
4734
a8815b00
EZ
47352011-07-07 Eli Zaretskii <eliz@gnu.org>
4736
4737 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4738 (Bug#9015)
4739
ef7b981d 47402011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4741
4742 * character.h (unicode_category_t): New enum type.
4743
4744 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4745 (Qchar_code_property_table): New variable.
4746 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4747 (UNIPROP_COMPRESSED_FORM_P): New macros.
4748 (char_table_ascii): Uncompress the compressed values.
4749 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4750 Uncompress the compressed values.
ac389d0c 4751 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4752 (char_table_ref_and_range): Uncompress the compressed values.
4753 (sub_char_table_set): New arg is_uniprop. Callers changed.
4754 Uncompress the compressed values.
4755 (sub_char_table_set_range): Args changed. Callers changed.
4756 (char_table_set_range): Adjuted for the above change.
4757 (map_sub_char_table): Delete args default_val and parent. Add arg
4758 top. Give decoded values to a Lisp function.
640c8776 4759 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4760 values to a Lisp function. Gcpro more variables.
4761 (uniprop_table_uncompress)
4762 (uniprop_decode_value_run_length): New functions.
4763 (uniprop_decoder, uniprop_decoder_count): New variables.
4764 (uniprop_get_decoder, uniprop_encode_value_character)
4765 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4766 New functions.
4767 (uniprop_encoder, uniprop_encoder_count): New variables.
4768 (uniprop_get_encoder, uniprop_table)
4769 (Funicode_property_table_internal, Fget_unicode_property_internal)
4770 (Fput_unicode_property_internal): New functions.
4771 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4772 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4773 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4774 char-code-property-alist.
4775
640c8776 4776 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4777 Vunicode_category_table.
4778
640c8776 4779 * font.c (font_range): Adjust for the change of
c805dec0
KH
4780 Vunicode_category_table.
4781
76b397fb
DN
47822011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4783
4784 * m/iris4d.h: Remove file, move contents ...
4785 * s/irix6-5.h: ... here.
4786
22b4128e
PE
47872011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4788
4789 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4790 * alloc.c (mark_buffer):
4791 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4792 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4793 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4794 This isn't true in general, and it's particularly not true
4795 if Emacs is configured with --with-wide-int.
4796 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4797 New macros, used in the buffer.c change.
4798
869795d6
JD
47992011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4800
4801 * xsettings.c: Use both GConf and GSettings if both are available.
4802 (store_config_changed_event): Add comment.
4803 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4804 (store_tool_bar_style_changed): New functions.
5e617bc2 4805 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4806 (struct xsettings): Move font inside HAVE_XFT.
4807 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4808 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4809 Move inside HAVE_XFT.
640c8776 4810 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4811 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4812 also.
4813 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4814 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4815 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4816 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4817 (parse_settings): Move check for font inside HAVE_XFT.
4818 (read_settings, apply_xft_settings): Add comment.
4819 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4820 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4821 call store_font_name_changed.
4822 (xft_settings_event): Add comment.
4823 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4824 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4825 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4826 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4827 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4828 (xsettings_get_system_font, xsettings_get_system_normal_font):
4829 Add comment.
869795d6 4830
d8ed26bd
PE
48312011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4832
4833 Random fixes. E.g., (random) never returned negative values.
4834 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4835 subseconds part to the entropy, as that's a bit more random.
4836 Prefer signed to unsigned, since the signedness doesn't matter and
4837 in general we prefer signed. When given a limit, use a
4838 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4839 latter isn't right if USE_2_TAGS_FOR_INTS.
4840 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4841 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4842
cabf1cac
SM
48432011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4844
4845 * textprop.c (text_property_stickiness):
4846 Obey Vtext_property_default_nonsticky.
4847 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4848 * w32fns.c (syms_of_w32fns):
4849 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4850
6e9b2be9
PE
48512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4852
4853 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4854 This is more efficient than Ffile_directory_p and avoids a minor race.
4855
90186c68
LMI
48562011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4857
7c301272
LMI
4858 * buffer.c (Foverlay_put): Say what the return value is
4859 (bug#7835).
4860
c4f2d8d4
LMI
4861 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4862 is a directory before asking whether to use the file name
4863 (bug#7564).
ad637907
LMI
4864 (barf_or_query_if_file_exists): Make the "File is a directory"
4865 error be more correct.
c4f2d8d4 4866
90186c68
LMI
4867 * fns.c (Frequire): Remove the mention of the .gz files, since
4868 that's installation-specific, but keep the mention of
4869 `get-load-suffixes'.
4870
da64016e
PE
48712011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4872
4873 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4874 Report string overflow if the output is too long.
4875
7d47b580
JB
48762011-07-04 Juanma Barranquero <lekktu@gmail.com>
4877
a555cb87
JB
4878 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4879 (syms_of_gnutls): Remove duplicate DEFSYM for
4880 Qgnutls_bootprop_verify_hostname_error, an error for
4881 Qgnutls_bootprop_verify_error (which is no longer used).
4882
7d47b580
JB
4883 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4884 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4885 Also (re)move comments that are misplaced or no longer relevant.
4886
1e49bfab
LMI
48872011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4888
4889 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4890
1485f4c0
CY
48912011-07-03 Chong Yidong <cyd@stupidchicken.com>
4892
4893 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4894 and background color parameters if they have been changed.
4895
a9ab721e
LMI
48962011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4897
4898 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4899
cf7cff57
PE
49002011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4901
2e13213d
PE
4902 * xsettings.c (SYSTEM_FONT): Define only when used.
4903 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4904
cf7cff57
PE
4905 * keymap.c (access_keymap_1): Now static.
4906
7a8e04f7
CY
49072011-07-02 Chong Yidong <cyd@stupidchicken.com>
4908
4909 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4910 leave any prefix arg for the up event (Bug#1586).
4911
61352f62
LMI
49122011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4913
69bb1ef7
LMI
4914 * lread.c (syms_of_lread): Mention single symbols defined by
4915 `defvar' or `defconst' (bug#7154).
4916
61352f62 4917 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4918 (Frequire): Mention get-load-suffixes.
61352f62 4919
28545e04
MR
49202011-07-02 Martin Rudalics <rudalics@gmx.at>
4921
4922 * window.h (window): Remove clone_number slot.
4923 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4924 Remove.
4925 (make_parent_window, make_window, saved_window)
4926 (Fset_window_configuration, save_window_save): Don't deal with
4927 clone numbers.
4928 * buffer.c (Qclone_number): Remove declaration.
4929 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4930
3349e122
SM
49312011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4932
4933 Add multiple inheritance to keymaps.
4934 * keymap.c (Fmake_composed_keymap): New function.
4935 (Fset_keymap_parent): Simplify.
4936 (fix_submap_inheritance): Remove.
4937 (access_keymap_1): New function extracted from access_keymap to handle
4938 embedded parents and handle lists of maps.
4939 (access_keymap): Use it.
4940 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4941 (Fcopy_keymap): Handle embedded parents.
4942 (Fcommand_remapping, define_as_prefix): Simplify.
4943 (Fkey_binding): Simplify.
4944 (syms_of_keymap): Move minibuffer-local-completion-map,
4945 minibuffer-local-filename-completion-map,
4946 minibuffer-local-must-match-map, and
4947 minibuffer-local-filename-must-match-map to Elisp.
4948 (syms_of_keymap): Defsubr make-composed-keymap.
4949 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4950 (parse_menu_item): Trivial simplification.
4951
3279eb87
GM
49522011-07-01 Glenn Morris <rgm@gnu.org>
4953
4954 * Makefile.in (SETTINGS_LIBS): Fix typo.
4955
4550efdf
KI
49562011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4957
4958 * coding.c (Fencode_coding_string): Record the last coding system
4959 used, as the function doc string says (bug#8738).
4960
0949d2b6
JD
49612011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4962
4963 * xsettings.c (store_monospaced_changed): Take new font as arg and
4964 check for change against current_mono_font.
4965 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4966 (emacs_settings_constructor, emacs_settings_get_property)
4967 (emacs_settings_set_property, emacs_settings_class_init)
4968 (emacs_settings_init, gsettings_obj): Remove.
4969 (something_changedCB): New function for HAVE_GSETTINGS.
4970 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4971 with value as argument.
4972 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4973 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4974 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4975 "changed".
4976
4977 * xgselect.c: Add defined (HAVE_GSETTINGS).
4978 (xgselect_initialize): Ditto.
4979
4980 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4981 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4982 xg_select.
4983
bbc6b304
PE
49842011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4985
4986 * eval.c (struct backtrace): Simplify and port the data structure.
4987 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4988 signed bit field, as this assumption is not portable and it makes
4989 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4990 "char debug_on_exit : 1" as this is not portable either; instead,
4991 use the portable "unsigned int debug_on_exit : 1". Remove unused
4992 member evalargs. Remove obsolete comments about cc bombing out.
4993
9851bfc5
JD
49942011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4995
51bb811f 4996 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4997 Let HAVE_GSETTINGS override HAVE_GCONF.
4998 (store_monospaced_changed): New function.
4999 (EMACS_SETTINGS): A new type derived from GObject to handle
5000 GSettings notifications.
5001 (emacs_settings_constructor, emacs_settings_get_property)
5002 (emacs_settings_set_property, emacs_settings_class_init):
5003 New functions.
5004 (gsettings_client, gsettings_obj): New variables.
5005 (GSETTINGS_SCHEMA): New define.
5006 (something_changedCB): Call store_monospaced_changed.
5007 (init_gsettings): New function.
5008 (xsettings_initialize): Call init_gsettings.
5009 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5010 to NULL.
5011
640c8776 5012 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
5013 GCONF_CFLAGS/LIBS.
5014
5386012d
MR
50152011-06-29 Martin Rudalics <rudalics@gmx.at>
5016
5017 * window.c (resize_root_window, grow_mini_window)
5018 (shrink_mini_window): Rename Qresize_root_window to
5019 Qwindow_resize_root_window and Qresize_root_window_vertically to
5020 Qwindow_resize_root_window_vertically.
5021
f13e0b08
PE
50222011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5023
5024 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5025
94515237
JB
50262011-06-27 Juanma Barranquero <lekktu@gmail.com>
5027
5028 * makefile.w32-in: Redesign dependencies so they reflect more
5029 clearly which files are directly included by each source file,
5030 and not through other includes.
5031
e43b6e43
MR
50322011-06-27 Martin Rudalics <rudalics@gmx.at>
5033
5034 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5035 (sort_overlays, overlay_strings): When an overlay's clone number
5036 matches the window's clone number process the overlay even if
5037 the overlay's window property doesn't match the current window.
5038
d68443dc
MR
5039 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5040 (Fwindow_hchild): Rename to Fwindow_left_child.
5041 (Fwindow_next): Rename to Fwindow_next_sibling.
5042 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
5043 (resize_window_check): Rename to window_resize_check.
5044 (resize_window_apply): Rename to window_resize_apply.
5045 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5046 (Fdelete_other_windows_internal, resize_frame_windows)
5047 (Fsplit_window_internal, Fdelete_window_internal)
5048 (grow_mini_window, shrink_mini_window)
5049 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 5050
c7e73be5
JD
50512011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5052
5053 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5054 (emacs_fixed_set_min_size): Remove.
5055 (emacs_fixed_new): Take frame as argument.
5056
5057 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5058 (_EmacsFixedPrivate): Remove minwidth/height.
5059 Add struct frame *f.
5060 (emacs_fixed_init): Initialize priv->f.
5061 (get_parent_class, emacs_fixed_set_min_size): Remove.
5062 (emacs_fixed_new): Set priv->f to argument.
5063 (emacs_fixed_get_preferred_width)
5064 (emacs_fixed_get_preferred_height): Use min_width/height from
5065 frames size_hint to set minimum and natural (Bug#8919).
5066 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5067 and use min_width/height from frames size_hint to set
5068 min_width/height (Bug#8919).
5069
5070 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
5071 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5072 Fix indentation.
c7e73be5 5073
cf99dcf8
EZ
50742011-06-26 Eli Zaretskii <eliz@gnu.org>
5075
5076 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5077 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5078 called at ZV.
5079
029529ac
CY
50802011-06-26 Chong Yidong <cyd@stupidchicken.com>
5081
5082 * process.c (wait_reading_process_output): Bypass select if
5083 waiting for a cell while ignoring keyboard input, and input is
5084 pending. Suggested by Jan Djärv (Bug#8869).
5085
7a7ef429
PE
50862011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5087
5088 Use gnulib's dup2 module instead of rolling our own.
5089 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5090
11fdef7d 50912011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5092
5093 * dispnew.c (scrolling_window): Before scrolling, turn off a
5094 mouse-highlight in the window being scrolled.
5095
cd3520a4
JB
50962011-06-24 Juanma Barranquero <lekktu@gmail.com>
5097
5098 Move DEFSYM to lisp.h and use everywhere.
5099
5100 * character.h (DEFSYM): Move declaration...
5101 * lisp.h (DEFSYM): ...here.
5102
5103 * gnutls.c:
5104 * minibuf.c:
5105 * w32menu.c:
5106 * w32proc.c:
5107 * w32select.c: Don't include character.h.
5108
5109 * alloc.c (syms_of_alloc):
5110 * buffer.c (syms_of_buffer):
5111 * bytecode.c (syms_of_bytecode):
5112 * callint.c (syms_of_callint):
5113 * casefiddle.c (syms_of_casefiddle):
5114 * casetab.c (init_casetab_once):
5115 * category.c (init_category_once, syms_of_category):
5116 * ccl.c (syms_of_ccl):
5117 * cmds.c (syms_of_cmds):
5118 * composite.c (syms_of_composite):
5119 * dbusbind.c (syms_of_dbusbind):
5120 * dired.c (syms_of_dired):
5121 * dispnew.c (syms_of_display):
5122 * doc.c (syms_of_doc):
5123 * editfns.c (syms_of_editfns):
5124 * emacs.c (syms_of_emacs):
5125 * eval.c (syms_of_eval):
5126 * fileio.c (syms_of_fileio):
5127 * fns.c (syms_of_fns):
5128 * frame.c (syms_of_frame):
5129 * fringe.c (syms_of_fringe):
5130 * insdel.c (syms_of_insdel):
5131 * keymap.c (syms_of_keymap):
5132 * lread.c (init_obarray, syms_of_lread):
5133 * macros.c (syms_of_macros):
5134 * msdos.c (syms_of_msdos):
5135 * print.c (syms_of_print):
5136 * process.c (syms_of_process):
5137 * search.c (syms_of_search):
5138 * sound.c (syms_of_sound):
5139 * syntax.c (init_syntax_once, syms_of_syntax):
5140 * terminal.c (syms_of_terminal):
5141 * textprop.c (syms_of_textprop):
5142 * undo.c (syms_of_undo):
5143 * w32.c (globals_of_w32):
5144 * window.c (syms_of_window):
5145 * xdisp.c (syms_of_xdisp):
5146 * xfaces.c (syms_of_xfaces):
5147 * xfns.c (syms_of_xfns):
5148 * xmenu.c (syms_of_xmenu):
5149 * xsettings.c (syms_of_xsettings):
5150 * xterm.c (syms_of_xterm): Use DEFSYM.
5151
4228cf16
TZ
51522011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5153
cd3520a4 5154 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5155
7fcccf1e
PE
51562011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5157
7efb4e0e
PE
5158 Integer and buffer overflow fixes (Bug#8873).
5159
ff5844ad
PE
5160 * print.c (printchar, strout): Check for string overflow.
5161 (PRINTPREPARE, printchar, strout):
5162 Don't set size unless allocation succeeds.
5163
90532f02
PE
5164 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5165 for sizes. Check for string overflow more accurately.
5166 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5167
6d84508d
PE
5168 * macros.c: Integer and buffer overflow fixes.
5169 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5170 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5171 Use ptrdiff_t, not int, for sizes.
5172 Don't increment bufsize until after realloc succeeds.
5173 Check for size-calculation overflow.
5174 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5175
437b2cb4
PE
5176 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5177
8b9ac8b4
PE
5178 * lread.c: Integer overflow fixes.
5179 (read_integer): Radix is now EMACS_INT, not int,
5180 to improve quality of diagnostics for out-of-range radices.
5181 Calculate buffer size correctly for out-of-range radices.
5182 (read1): Check for integer overflow in radices, and in
5183 read-circle numbers.
82cb60d3
PE
5184 (read_escape): Avoid int overflow.
5185 (Fload, openp, read_buffer_size, read1)
5186 (substitute_object_recurse, read_vector, read_list, map_obarray):
5187 Use ptrdiff_t, not int, for sizes.
5188 (read1): Use EMACS_INT, not int, for sizes.
20270765 5189 Check for size overflow.
8b9ac8b4 5190
7fcccf1e
PE
5191 * image.c (cache_image): Check for size arithmetic overflow.
5192
bfbbd7e7
PE
5193 * lread.c: Integer overflow issues.
5194 (saved_doc_string_size, saved_doc_string_length)
5195 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5196 Now ptrdiff_t, not int.
5197 (read1): Don't assume doc string length fits in int. Check for
5198 out-of-range doc string lengths.
5199 (read_list): Don't assume file position fits in int.
39019e54 5200 (read_escape): Check for hex character overflow.
bfbbd7e7 5201
4e323265
LL
52022011-06-22 Leo Liu <sdl.web@gmail.com>
5203
5204 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5205 Move to minibuffer.el.
5206
85fece3e
PE
52072011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5208
20b84ce9 5209 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5210 The following patches are for when GLYPH_DEBUG && !XASSERT.
5211 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5212 * dispnew.c (flush_stdout):
5213 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5214 Mark as externally visible.
5215 * dispnew.c (check_window_matrix_pointers): Now static.
5216 * dispnew.c (window_to_frame_vpos):
5217 * xfns.c (unwind_create_frame):
5218 * xterm.c (x_check_font): Remove unused local.
5219 * scroll.c (CHECK_BOUNDS):
5220 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5221 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5222 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5223 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5224 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5225 Now static.
5226 (debug_method_add): Use va_list and vsprintf rather than relying
5227 on undefined behavior with wrong number of arguments.
5228 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5229 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5230 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5231 since we're not interested in debugging glyphs with old libraries.
5232 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5233 GCC 4.6.0's static checking.
5234
0766b489
PE
52352011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5236
31fd4b32
PE
5237 Integer overflow and signedness fixes (Bug#8873).
5238 A few related buffer overrun fixes, too.
5239
b79e8648
PE
5240 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5241
0766b489
PE
5242 * dispextern.h (struct face.stipple):
5243 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5244 (x_bitmap_mask, x_allocate_bitmap_record)
5245 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5246 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5247 (x_create_bitmap_from_xpm_data):
5248 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5249 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5250 (.bitmaps_last):
5251 * xfaces.c (load_pixmap):
5252 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5253 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5254 (.bitmaps_last, struct x_output.icon_bitmap):
5255 Use ptrdiff_t, not int, for bitmap indexes.
5256 (x_allocate_bitmap_record): Check for size overflow.
5257 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5258
b081724f
PE
5259 Use ptrdiff_t, not int, for overlay counts.
5260 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5261 * editfns.c (overlays_around, get_pos_property):
5262 * textprop.c (get_char_property_and_overlay):
5263 * xdisp.c (next_overlay_change, note_mouse_highlight):
5264 * xfaces.c (face_at_buffer_position):
21514da7
PE
5265 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5266 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5267 (Fnext_overlay_change, Fprevious_overlay_change)
5268 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5269 Use ptrdiff_t, not int, for sizes.
21514da7 5270 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5271
3de73e5e
PE
5272 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5273
2606c57b
PE
5274 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5275 (x_session_initialize): Do not assume string length fits in int.
5276
aaafe47a
PE
5277 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5278 This is unlikely, but can occur if DPI is outlandish.
5279
2674ddc8 5280 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5281 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5282
28154962
PE
5283 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5284 * xrdb.c (magic_file_p, search_magic_path):
5285 Omit last arg SUFFIX; it was always 0. All callers changed.
5286 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5287
7de51af5
PE
5288 * xfont.c (xfont_match): Avoid need for strlen.
5289
25ed6cc3
PE
5290 * xfns.c: Don't assume strlen fits in int.
5291 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5292
4eab31dd
PE
5293 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5294 not unsigned long, as we prefer signed integers. All callers changed.
5295 Detect integer overflow in repeat count.
5296 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5297 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5298
171e2a58
PE
5299 * termcap.c: Don't assume sizes fit in int and never overflow.
5300 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5301 (gobble_line): Check for size-calculation overflow.
5302
ad39faca 5303 * minibuf.c (Fread_buffer):
6e5bb2dc 5304 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5305 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5306 Don't assume string length fits in int.
5307
52c61c22 5308 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5309 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5310
b5b8c9e5
PE
5311 * font.c: Don't assume string length fits in int.
5312 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5313 Use ptrdiff_t, not int.
ccd6111c
PE
5314 (font_intern_prop): Don't assume string length fits in int.
5315 Don't assume integer property fits in fixnum.
5316 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5317
882f0d81 5318 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5319 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5320 Reformulate so as not to need the command string.
5321 Invoke gzip -cd rather than gunzip, as it's more portable.
5322 (lock_info_type, lock_file_1, lock_file):
5323 Don't assume pid_t and time_t fit in unsigned long.
5324 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5325 (current_lock_owner): Prefer signed type for sizes.
5326 Use memcpy, not strncpy, where memcpy is what is really wanted.
5327 Don't assume (via atoi) that time_t and pid_t fit in int.
5328 Check for time_t and/or pid_t out of range, e.g., via a network share.
5329 Don't alloca where an auto var works fine.
5330
93f4cf88
PE
5331 * fileio.c: Fix some integer overflow issues.
5332 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5333 Don't assume string length fits in int.
5334 (directory_file_name): Don't assume string length fits in long.
5335 (make_temp_name): Don't assume pid fits in int, or that its print
5336 length is less than 20.
5337
f3e92b69
PE
5338 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5339
1bfdaf10
PE
5340 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5341
35016e9a
PE
5342 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5343
3d1e65a1
PE
5344 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5345 We prefer signed integers, even for size calculations.
5346
0b963a93
PE
5347 * emacs.c: Don't assume string length fits in 'int'.
5348 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5349 (main): Don't invoke strlen when not needed.
5350
573f4b54
PE
5351 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5352 (XD_DEBUG_MESSAGE): Don't waste a byte.
5353
989f33ba
PE
5354 * callproc.c (getenv_internal_1, getenv_internal)
5355 (Fgetenv_internal):
965d34eb
PE
5356 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5357
e4d29b33
PE
5358 * lread.c (invalid_syntax): Omit length argument.
5359 All uses changed. This doesn't fix a bug, but it simplifies the
5360 code away from its former Hollerith-constant appearance, and it's
5361 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5362 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5363
eb49b136
PE
5364 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5365 This didn't break anything, but it didn't help either.
5366 It's confusing to put a bogus integer in a place where the actual
5367 value does not matter.
9f62aeb1 5368 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5369 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5370
15375a22
PE
5371 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5372 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5373 implementation.
b61cc01c
PE
5374 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5375 We prefer signed types, and the value cannot exceed the EMACS_INT
5376 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5377 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5378 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5379 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5380
53b2623d
PE
5381 * indent.c (sane_tab_width): New function.
5382 (current_column, scan_for_column, Findent_to, position_indentation)
5383 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5384 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5385
51cab52b 5386 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5387
f2ed8a70
PE
5388 * lisp.h (lint_assume): New macro.
5389 * composite.c (composition_gstring_put_cache):
5390 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5391
abe80cc6
PE
5392 * editfns.c, insdel.c:
5393 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5394
b02c740e
PE
5395 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5396
ebc96716
PE
5397 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5398
b4e50fa0 5399 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5400 Use much-faster test for byte-length change.
311d5d7c 5401 Don't assume string byte-length fits in 'int'.
a4cf38e4 5402 Check that character arg fits in 'int'.
85461888 5403 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5404
c0c1ee9f
PE
5405 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5406
a498d7f4
PE
5407 * fns.c (concat): Catch string overflow earlier.
5408 Do not rely on integer wraparound.
5409
51cab52b
PE
5410 * dispextern.h (struct it.overlay_strings_charpos)
5411 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5412 * xdisp.c (forward_to_next_line_start)
5413 (back_to_previous_visible_line_start)
5414 (reseat_at_next_visible_line_start, next_element_from_buffer):
5415 Don't arbitrarily truncate the value of 'selective' to int.
5416
76031fad
PE
5417 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5418
5eb55db9
PE
5419 * composite.c: Don't truncate sizes to 'int'.
5420 (composition_gstring_p, composition_reseat_it)
5421 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5422 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5423 not EMACS_UINT, for indexes.
5eb55db9 5424
0703a717
PE
5425 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5426
d6202519
PE
5427 * buffer.c: Include <verify.h>.
5428 (struct sortvec.priority, struct sortstr.priority):
8961a454 5429 Now EMACS_INT, not int.
c20998a7 5430 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5431 (struct sortstr.size, record_overlay_string)
5432 (struct sortstrlist.size, struct sortlist.used):
5433 Don't truncate size to int.
5434 (record_overlay_string): Check for size-calculation overflow.
d6202519 5435 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5436
d5a19415
JM
54372011-06-22 Jim Meyering <meyering@redhat.com>
5438
029529ac 5439 Don't leak an XBM-image-sized buffer
d5a19415
JM
5440 * image.c (xbm_load): Free the image buffer after using it.
5441
a9041e6c
PE
54422011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5443
5444 Port to Sun C.
5445 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5446 that Sun C diagnosed.
5447 * fns.c (secure_hash): Fix pointer signedness issue.
5448 * intervals.c (static_offset_intervals): New function.
5449 (offset_intervals): Use it.
5450
7f3f739f
LL
54512011-06-21 Leo Liu <sdl.web@gmail.com>
5452
5453 * deps.mk (fns.o):
5454 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5455 sha512.h.
5456
5457 * fns.c (secure_hash): Rename from crypto_hash_function and change
5458 the first arg to accept symbols.
5b66d427 5459 (Fsecure_hash): New primitive.
7f3f739f
LL
5460 (syms_of_fns): New symbols.
5461
76147d94
DD
54622011-06-20 Deniz Dogan <deniz@dogan.se>
5463
5464 * process.c (Fset_process_buffer): Clarify return value in
5465 docstring.
5466
7d7d0045
CY
54672011-06-18 Chong Yidong <cyd@stupidchicken.com>
5468
5469 * dispnew.c (add_window_display_history): Use BVAR.
5470
5471 * xdisp.c (debug_method_add): Use BVAR.
5472 (check_window_end, dump_glyph_matrix, dump_glyph)
5473 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5474
5475 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5476 Likewise.
5477
5478 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5479 check till after the cache is created in init_frame_faces.
5480
ff2bc410
SM
54812011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5482
5483 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5484
28177add
PE
54852011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5486
dd3482fe
PE
5487 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5488 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5489 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5490
393d71f3 5491 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5492 * fileio.c (Finsert_file_contents):
5493 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5494 Remove the old (too-loose) buffer overflow checks.
5495 They weren't needed, since make_gap checks for buffer overflow.
5496 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5497 The old code merely checked for Emacs fixnum overflow, and relied
5498 on undefined (wraparound) behavior. The new code avoids undefined
5499 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5500
2e6813b0 5501 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5502 Tune. Don't use wider integers than needed. Don't use alloca.
5503 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5504
599a9e4f
PE
5505 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5506
99561444
PE
5507 * insdel.c, lisp.h (buffer_overflow): New function.
5508 (insert_from_buffer_1, replace_range, replace_range_2):
5509 * insdel.c (make_gap_larger):
5510 * editfns.c (Finsert_char):
5511 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5512
28177add
PE
5513 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5514
e69dafad
PE
55152011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5516
4baa020d 5517 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5518
b1c46f02
PE
5519 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5520 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5521
e69dafad
PE
5522 * fileio.c: Don't assume EMACS_INT fits in off_t.
5523 (emacs_lseek): New static function.
5524 (Finsert_file_contents, Fwrite_region): Use it.
5525 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5526
566684ea
PE
5527 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5528
e6966cd6
PE
5529 * fns.c: Don't overflow int when computing a list length.
5530 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5531 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5532 truncation on 64-bit hosts. Check for QUIT every
5533 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5534 faster and is responsive enough.
5535 (Flength): Report an error instead of overflowing an integer.
5536 (Fsafe_length): Return a float if the value is not representable
5537 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5538 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5539 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5540
dd0b0efb
PE
5541 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5542 (header_size, word_size): New constants.
5543 (allocate_vectorlike): Don't check size overflow here.
5544 (allocate_vector): Check it here instead, since this is the only
5545 caller of allocate_vectorlike that could cause overflow.
5546 Check that the new vector's length is representable as a fixnum.
5547
86fe5cfe
PE
5548 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5549 The previous code was bogus. For example, next_almost_prime (32)
5550 returned 39, which is undesirable as it is a multiple of 3; and
5551 next_almost_prime (24) returned 25, which is a multiple of 5 so
5552 why was the code bothering to check for multiples of 7?
5553
80e88859
PE
5554 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5555
4a2f0ad6
PE
5556 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5557
f66c7cf8
PE
5558 Variadic C functions now count arguments with ptrdiff_t.
5559 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5560 Back then I didn't know that the Emacs coding style prefers signed int.
5561 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5562 were being counted with int, which may truncate counts on 64-bit
5563 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5564 * lisp.h (struct Lisp_Subr.function.aMANY)
5565 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5566 Arg counts are now ptrdiff_t, not size_t.
5567 All variadic functions and their callers changed accordingly.
5568 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5569 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5570 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5571 * callint.c (Fcall_interactively): Check arg count for overflow,
5572 to avoid potential buffer overrun. Use signed char, not 'int',
5573 for 'varies' array, so that we needn't bother to check its size
5574 calculation for overflow.
5575 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5576 * eval.c (apply_lambda):
5577 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5578 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5579 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5580
a1759b76
PE
5581 * callint.c (Fcall_interactively): Don't use index var as event count.
5582
d96be9fc
PE
5583 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5584 * mem-limits.h (SIZE): Remove; no longer used.
5585
a690a978 5586 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5587
578c21e6
PE
5588 Remove unnecessary casts.
5589 * xterm.c (x_term_init):
5590 * xfns.c (x_set_border_pixel):
5591 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5592 These aren't needed now that we assume ANSI C.
5593
96f53c6c
PE
5594 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5595 It's more likely to cause problems (due to unsigned overflow)
5596 than to cure them.
5597
83c77d31
PE
5598 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5599
ee2079f1
PE
5600 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5601
6da65536
PE
5602 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5603
7147c4a4
PE
5604 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5605
193e32d9
PE
5606 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5607
e5533da6
PE
5608 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5609
9910e595
PE
5610 GLYPH_CODE_FACE returns EMACS_INT, not int.
5611 * dispextern.h (merge_faces):
5612 * xfaces.c (merge_faces):
01103c44
PE
5613 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5614 Don't assume EMACS_INT fits in int.
9910e595 5615
2638320e
PE
5616 * character.h (CHAR_VALID_P): Remove unused parameter.
5617 * fontset.c, lisp.h, xdisp.c: All uses changed.
5618
045eb8d9
PE
5619 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5620
c1f134b5
PE
5621 * fns.c (concat): Minor tuning based on overflow analysis.
5622 This doesn't fix any bugs. Use int to hold character, instead
5623 of constantly refetching from Emacs object. Use XFASTINT, not
5624 XINT, for value known to be a character. Don't bother comparing
5625 a single byte to 0400, as it's always less.
5626
395fcb93 5627 * floatfns.c (Fexpt):
327eeec8
PE
5628 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5629
abbd3d23
PE
5630 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5631 for characters.
5632
684a03ef
PE
5633 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5634
0fed43f3
PE
5635 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5636 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5637 incorrectly succeed when S was a string, because 4294967386 was
5638 truncated before it was used.
5639
8fd02eb7
PE
5640 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5641 Otherwise, an out-of-range integer could cause undefined behavior
5642 on a 64-bit host.
5643
f8c86b69
PE
5644 * composite.c: Use int, not EMACS_INT, for characters.
5645 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5646 EMACS_INT, for values that are known to be in character range.
5647 This doesn't fix any bugs but is the usual style inside Emacs and
5648 may generate better code on 32-bit machines.
5649
34206dd2
PE
5650 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5651 This is for reasons similar to the recent CHAR_STRING fix.
5652 * charset.c (Fencode_char): Check that character arg is actually
5653 a character. Pass an int to ENCODE_CHAR.
5654 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5655 wider than 'int', as a compile-time check to prevent future regressions
5656 in this area.
5657
c5958d4c 5658 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5659
5660 Make sure a 64-bit char is never passed to CHAR_STRING.
5661 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5662 by silently ignoring the top 32 bits, allowing some values
5663 that were far too large to be valid characters.
5664 * character.h: Include <verify.h>.
5665 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5666 arguments are no wider than unsigned, as a compile-time check
5667 to prevent future regressions in this area.
5668 * data.c (Faset):
01103c44 5669 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5670 (Fsubst_char_in_region):
5671 * fns.c (concat):
5672 * xdisp.c (decode_mode_spec_coding):
5673 Adjust to CHAR_STRING's new requirement.
5674 * editfns.c (Finsert_char, Fsubst_char_in_region):
5675 * fns.c (concat): Check that character args are actually
5676 characters. Without this test, these functions did the wrong
5677 thing with wildly out-of-range values on 64-bit hosts.
5678
d37ca623
PE
5679 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5680 These casts should not be needed on 32-bit hosts, either.
5681 * keyboard.c (read_char):
5682 * lread.c (Fload): Remove casts to unsigned.
5683
ea204efb
PE
5684 * lisp.h (UNSIGNED_CMP): New macro.
5685 This fixes comparison bugs on 64-bit hosts.
5686 (ASCII_CHAR_P): Use it.
5687 * casefiddle.c (casify_object):
01103c44 5688 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5689 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5690 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5691 * dispextern.h (FACE_FROM_ID):
5692 * keyboard.c (read_char): Use UNSIGNED_CMP.
5693
41cb286c
PE
5694 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5695 not to EMACS_INT, to avoid GCC warning.
5696
4a1b9832
PE
5697 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5698
55daad71
PE
5699 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5700 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5701 isn't needed on 32-bit machines.
8f95c75c 5702
01103c44
PE
5703 * buffer.c (Fgenerate_new_buffer_name):
5704 Use EMACS_INT for count, not int.
0ceccced 5705 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5706
5707 * data.c (Qcompiled_function): Now static.
5708
c6f072e7
PE
5709 * window.c (window_body_lines): Now static.
5710
20ce5912
PE
5711 * image.c (gif_load): Rename local to avoid shadowing.
5712
9c4c5f81
PE
5713 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5714 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5715 * alloc.c (make_save_value): Integer argument is now of type
5716 ptrdiff_t, not int.
5717 (mark_object): Use ptrdiff_t, not int.
5718 * lisp.h (pD): New macro.
5719 * print.c (print_object): Use it.
5720
c0c5c8ae
PE
5721 * alloc.c: Use EMACS_INT, not int, to count objects.
5722 (total_conses, total_markers, total_symbols, total_vector_size)
5723 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5724 (total_free_floats, total_floats, total_free_intervals)
5725 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5726 Now EMACS_INT, not int. All uses changed.
5727 (Fgarbage_collect): Compute overall total using a double, so that
5728 integer overflow is less likely to be a problem. Check for overflow
5729 when converting back to an integer.
5a25e253
PE
5730 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5731 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5732 These were 'int' variables that could overflow on 64-bit hosts;
5733 they were never used, so remove them instead of repairing them.
211a0b2a 5734 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5735 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5736 Previously, this ceilinged at INT_MAX, but that doesn't work on
5737 64-bit machines.
e46bb31a 5738 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5739
c78baabf 5740 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5741 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5742 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5743 when a (possibly-narrower) signed value would do just as well.
5744 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5745
c9d624c6
PE
5746 * alloc.c: Catch some string size overflows that we were missing.
5747 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5748 for convenience in STRING_BYTES_MAX.
5749 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5750 The definition here is exact; the one in lisp.h was approximate.
5751 (allocate_string_data): Check for string overflow. This catches
5752 some instances we weren't catching before. Also, it catches
5753 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5754 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5755 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5756
c9d624c6
PE
5757 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5758 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5759 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5760
353032ce
PE
5761 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5762
2bccce07
PE
5763 * alloc.c (Fmake_string): Check for out-of-range init.
5764
0ac30604
SM
57652011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5766
5767 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5768
c195f2de
JD
57692011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5770
5771 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5772 xg_get_default_scrollbar_width.
5773
5774 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5775 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5776 (style_changed_cb): Call update_theme_scrollbar_width and call
5777 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5778 all frames (Bug#8505).
5779 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5780 Call gtk_window_set_resizable if HAVE_GTK3.
5781 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5782 and height if HAVE_GTK3 (Bug#8505).
5783 (scroll_bar_width_for_theme): New variable.
5784 (update_theme_scrollbar_width): New function.
5785 (xg_get_default_scrollbar_width): Move code to
5786 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5787 (xg_initialize): Call update_theme_scrollbar_width.
5788
5789 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5790
5791 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5792
e10ac9f1
MR
57932011-06-12 Martin Rudalics <rudalics@gmx.at>
5794
5795 * frame.c (make_frame): Call other_buffer_safely instead of
5796 other_buffer.
5797
5798 * window.c (temp_output_buffer_show): Call display_buffer with
5799 second argument Vtemp_buffer_show_specifiers and reset latter
5800 immediately after the call.
5801 (Vtemp_buffer_show_specifiers): New variable.
5802 (auto_window_vscroll_p, next_screen_context_lines)
5803 (Vscroll_preserve_screen_position): Remove leading asterisks from
5804 doc-strings.
5805
2d3c217e 58062011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5807
7b7f97e8 5808 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5809 * buffer.c (Qclone_number): Remove for now, as it's unused.
5810 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5811 (record_buffer): Remove unused local.
5812 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5813 (set_frame_buffer_list): Remove; unused.
5814 * frame.h (other_visible_frames): Remove decl.
5815 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5816 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5817 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5818 if HAVE_GPM.
5819 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5820 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5821 Define only if HAVE_GPM.
5822 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5823 (update_hints_inhibit): Remove; never set. All uses removed.
5824 * widgetprv.h (emacsFrameClassRec): Remove decl.
5825 * window.c (delete_deletable_window): Now returns void, since it
5826 wasn't returning anything.
5827 (compare_window_configurations): Remove unused locals.
5828 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5829 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5830 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5831 the same widths as pointers. This follows up on the 2011-05-06 patch.
5832 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5833 * xterm.h: Likewise.
5834 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5835
1384b89e
JB
58362011-06-12 Juanma Barranquero <lekktu@gmail.com>
5837
5838 * makefile.w32-in: Update dependencies.
5839 (LISP_H): Add lib/intprops.h.
5840
1100a63c
CY
58412011-06-11 Chong Yidong <cyd@stupidchicken.com>
5842
5843 * image.c (gif_load): Add animation frame delay to the metadata.
5844 (syms_of_image): Use DEFSYM. New symbol `delay'.
5845
6198ccd0
MR
58462011-06-11 Martin Rudalics <rudalics@gmx.at>
5847
5848 * window.c (delete_deletable_window): Re-add.
5849 (Fset_window_configuration): Rewrite to handle dead buffers and
5850 consequently deletable windows.
5851 (window_tree, Fwindow_tree): Remove. Supply functionality in
5852 window.el.
5853 (compare_window_configurations): Simplify code.
5854
b6e3633c
AS
58552011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5856
1ab0dee5
AS
5857 * image.c (imagemagick_load_image): Fix type mismatch.
5858 (Fimagemagick_types): Likewise.
5859
b6e3633c
AS
5860 * window.h (replace_buffer_in_windows): Declare.
5861
9397e56f
MR
58622011-06-11 Martin Rudalics <rudalics@gmx.at>
5863
5864 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5865 Qclone_number. Remove external declaration of Qdelete_window.
5866 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5867 code.
640c8776
SM
5868 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5869 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5870 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5871 buffer list implementation.
5872 (other_buffer_safely): New function.
5873 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5874 calls to replace_buffer_in_windows and
5875 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5876 if allowed.
5877 (record_buffer): Inhibit quitting and rewrite using quittable
5878 functions. Run Qbuffer_list_update_hook if allowed.
5879 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5880 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5881 Move switch-to-buffer to window.el.
9397e56f
MR
5882 (bury-buffer): Move to window.el.
5883 (Vbuffer_list_update_hook): New variable.
5884
5885 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5886 section.
5887
5888 * window.h (resize_frame_windows): Move up in code.
5889 (Fwindow_frame): Remove EXFUN.
5890 (replace_buffer_in_all_windows): Remove prototype.
5891 (replace_buffer_in_windows_safely): Add prototype.
5892
5893 * window.c: Declare Qdelete_window static again. Move down
5894 declaration of select_count.
5895 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5896 (Fother_window): Move to window.el.
5897 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5898 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5899 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5900 window.el.
5901 (replace_buffer_in_windows): Implement by calling
5902 Qreplace_buffer_in_windows.
5903 (replace_buffer_in_all_windows): Remove with some functionality
5904 moved into replace_buffer_in_windows_safely.
5905 (replace_buffer_in_windows_safely): New function.
5906 (select_window_norecord, select_frame_norecord): Move in front
5907 of run_window_configuration_change_hook. Remove now obsolete
5908 declarations.
640c8776
SM
5909 (Fset_window_buffer): Rewrite doc-string.
5910 Call Qrecord_window_buffer.
9397e56f
MR
5911 (keys_of_window): Move binding for other-window to window.el.
5912
b50691aa
CY
59132011-06-11 Chong Yidong <cyd@stupidchicken.com>
5914
5915 * dispextern.h (struct image): Replace data member, whose int_val
5916 and ptr_val fields were not used by anything, with a single
5917 lisp_val object.
5918
5919 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5920 (gif_clear_image, gif_load, imagemagick_load_image)
5921 (gs_clear_image, gs_load): Callers changed.
5922
3f754b86
PE
59232011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5924
cca69397
PE
5925 * buffer.h: Include <time.h>, for time_t.
5926 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5927
109e28d0
PE
5928 Fix minor problems found by static checking.
5929
60737f02
PE
5930 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5931
4b66faf3
PE
5932 Make identifiers static if they are not used in other modules.
5933 * data.c (Qcompiled_function, Qframe, Qvector):
5934 * image.c (QimageMagick, Qsvg):
5935 * minibuf.c (Qmetadata):
5936 * window.c (resize_window_check, resize_root_window): Now static.
5937 * window.h (resize_window_check, resize_root_window): Remove decls.
5938
109e28d0
PE
5939 * window.c (window_deletion_count, delete_deletable_window):
5940 Remove; unused.
46a4ce9e
PE
5941 (window_body_lines): Now static.
5942 (Fdelete_other_windows_internal): Mark vars as initialized.
5943 Make sure 'resize_failed' is initialized.
5944 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5945 (resize_window_apply): Remove unused local.
5946 * window.h (delete_deletable_window): Remove decl.
5947
109e28d0 5948 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5949 (imagemagick_load_image): Fix pointer signedness problem by changing
5950 last arg from unsigned char * to char *. All uses changed.
5951 Also, fix a local for similar reasons.
5952 Remove unused locals. Remove locals to avoid shadowing.
5953 (fn_rsvg_handle_free): Remove; unused.
5954 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5955 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5956
3f754b86
PE
5957 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5958
2547adb1
CY
59592011-06-10 Chong Yidong <cyd@stupidchicken.com>
5960
5961 * image.c (gif_load): Fix omitted cast error introduced by
5962 2011-06-06 change.
5963
2c8e37d4
MR
59642011-06-10 Martin Rudalics <rudalics@gmx.at>
5965
5966 * window.h (resize_proportionally, orig_total_lines)
5967 (orig_top_line): Remove from window structure.
5968 (set_window_height, set_window_width, change_window_heights)
5969 (Fdelete_window): Remove prototypes.
5970 (resize_frame_windows): Remove duplicate declaration.
5971
440a42e3
EZ
59722011-06-10 Eli Zaretskii <eliz@gnu.org>
5973
5974 * window.h (resize_frame_windows, resize_window_check)
5975 (delete_deletable_window, resize_root_window)
5976 (resize_frame_windows): Declare prototypes.
5977
5978 * window.c (resize_window_apply): Make definition be "static" to
5979 match the prototype.
5980
562dd5e9
MR
59812011-06-10 Martin Rudalics <rudalics@gmx.at>
5982
5983 * window.c: Remove declarations of Qwindow_size_fixed,
5984 window_min_size_1, window_min_size_2, window_min_size,
5985 size_window, window_fixed_size_p, enlarge_window, delete_window.
5986 Remove static from declaration of Qdelete_window, it's
5987 temporarily needed by Fbury_buffer.
5988 (replace_window): Don't assign orig_top_line and
5989 orig_total_lines.
5990 (Fdelete_window, delete_window): Remove. Window deletion is
5991 handled by window.el.
640c8776
SM
5992 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5993 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5994 (Fdelete_other_windows): Remove. Deleting other windows is
5995 handled by window.el.
5996 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5997 handled in window.el.
5998 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5999 Window minimum sizes are handled in window.el.
6000 (shrink_windows, size_window, set_window_height)
6001 (set_window_width, change_window_heights, window_height)
6002 (window_width, CURBEG, CURSIZE, enlarge_window)
6003 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6004 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6005 handled in window.el.
6006 (make_dummy_parent): Rename to make_parent_window and give it a
6007 second argument horflag.
6008 (make_window): Don't set resize_proportionally any more.
6009 (Fsplit_window): Remove. Windows are split in window.el.
6010 (save_restore_action, save_restore_orig_size)
6011 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6012 Resize mini windows in window.el.
6013 (grow_mini_window, shrink_mini_window): Implement by calling
6014 Qresize_root_window_vertically, resize_window_check and
6015 resize_window_apply.
640c8776
SM
6016 (saved_window, Fset_window_configuration, save_window_save):
6017 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
6018 resize_proportionally.
6019 (window_min_height, window_min_width): Move to window.el.
6020 (keys_of_window): Move bindings for delete-other-windows,
6021 split-window, delete-window and enlarge-window to window.el.
6022
6023 * buffer.c: Temporarily extern Qdelete_window.
6024 (Fbury_buffer): Temporarily call Qdelete_window instead of
6025 Fdelete_window (Fbury_buffer will move to window.el soon).
6026
6027 * frame.c (set_menu_bar_lines_1): Remove code handling
6028 orig_top_line and orig_total_lines.
6029
6030 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6031 set_window_height but set heights directly.
6032 (change_frame_size_1): Use resize_frame_windows.
6033
6034 * xdisp.c (init_xdisp): Don't use set_window_height but set
6035 heights directly.
6036
640c8776
SM
6037 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6038 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
6039 run_window_configuration_change_hook.
6040
6041 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6042 instead of change_window_heights and run
6043 run_window_configuration_change_hook.
6044
1a13852e
MR
60452011-06-09 Martin Rudalics <rudalics@gmx.at>
6046
6047 * window.c (replace_window): Rename second argument REPLACEMENT to
6048 NEW. New third argument SETFLAG. Rewrite.
6049 (delete_window, make_dummy_parent): Call replace_window with
6050 third argument 1.
6051 (window_list_1): Move down in code.
6052 (run_window_configuration_change_hook): Move set_buffer part
6053 before select_frame_norecord part in order to unwind correctly.
6054 Rename count1 to count.
6055 (recombine_windows, delete_deletable_window, resize_root_window)
6056 (Fdelete_other_windows_internal)
6057 (Frun_window_configuration_change_hook, make_parent_window)
6058 (resize_window_check, resize_window_apply, Fresize_window_apply)
6059 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
6060 (Fdelete_window_internal, Fresize_mini_window_internal):
6061 New functions.
1a13852e
MR
6062 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6063
f3d1777e
MR
60642011-06-08 Martin Rudalics <rudalics@gmx.at>
6065
496e208e
MR
6066 * window.h (window): Add some new members to window structure -
6067 normal_lines, normal_cols, new_total, new_normal, clone_number,
6068 splits, nest, prev_buffers, next_buffers.
6069 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 6070 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 6071
f3d1777e
MR
6072 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6073 Remove.
496e208e
MR
6074 (make_dummy_parent): Set new members of windows structure.
6075 (make_window): Move down in code. Handle new members of window
6076 structure.
6077 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6078 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6079 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6080 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6081 (Fset_window_next_buffers, Fset_window_clone_number):
6082 New functions.
496e208e
MR
6083 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6084 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6085 Doc-string fixes.
6086 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6087 Argument WINDOW can be now internal window too.
6088 (Fwindow_use_time): Move up in code.
6089 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6090 Rewrite doc-string.
6091 (Fset_window_configuration, saved_window)
6092 (Fcurrent_window_configuration, save_window_save): Handle new
6093 members of window structure.
b9e809c2
MR
6094 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6095 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6096 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6097 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6098 Qget_mru_window, Qresize_root_window,
6099 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6100 Qauto_buffer_name; staticpro them.
f3d1777e 6101
abde8f8c
MR
61022011-06-07 Martin Rudalics <rudalics@gmx.at>
6103
6104 * window.c (Fwindow_total_size, Fwindow_left_column)
6105 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6106 (Fwindow_list_1): New functions.
6107 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6108 (Fwindow_width, Fscroll_left, Fscroll_right):
6109 Use window_body_cols instead of window_box_text_cols.
6110 (delete_window, Fset_window_configuration):
6111 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6112 (delete_all_subwindows): Take a window as argument and not a
6113 structure. Rewrite.
190b47e6
MR
6114 (window_loop): Remove handling of GET_LRU_WINDOW and
6115 GET_LARGEST_WINDOW.
6116 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6117
6118 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6119 window_box_text_cols. delete_all_subwindows now takes a
6120 Lisp_Object as argument.
abde8f8c 6121
640c8776
SM
6122 * indent.c (compute_motion, Fcompute_motion):
6123 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6124
fa8a67e6
MR
6125 * frame.c (delete_frame): Call delete_all_subwindows with root
6126 window as argument.
6127
a54e3482
DC
61282011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6129
6130 * fns.c (Fputhash): Document return value.
6131
60002bf5
CY
61322011-06-06 Chong Yidong <cyd@stupidchicken.com>
6133
6134 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6135
0c671da6 61362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6137
b862a52a 6138 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6139
be44ca6c
PE
6140 Check for overflow when converting integer to cons and back.
6141 * charset.c (Fdefine_charset_internal, Fdecode_char):
6142 Use cons_to_unsigned to catch overflow.
6143 (Fencode_char): Use INTEGER_TO_CONS.
6144 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6145 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6146 * data.c (long_to_cons, cons_to_long): Remove.
6147 (cons_to_unsigned, cons_to_signed): New functions.
6148 These signal an error for invalid or out-of-range values.
6149 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6150 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6151 * font.c (Ffont_variation_glyphs):
6152 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6153 * lisp.h: Include <intprops.h>.
6154 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6155 (cons_to_signed, cons_to_unsigned): New decls.
6156 (long_to_cons, cons_to_long): Remove decls.
6157 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6158 (Fprimitive_undo): Use CONS_TO_INTEGER.
6159 * xfns.c (Fx_window_property): Likewise.
6160 * xselect.c: Include <limits.h>.
6161 (x_own_selection, selection_data_to_lisp_data):
6162 Use INTEGER_TO_CONS.
6163 (x_handle_selection_request, x_handle_selection_clear)
6164 (x_get_foreign_selection, Fx_disown_selection_internal)
6165 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6166 (lisp_data_to_selection_data): Use cons_to_unsigned.
6167 (x_fill_property_data): Use cons_to_signed.
6168 Report values out of range.
6169
d1f3d2af
PE
6170 Check for buffer and string overflow more precisely.
6171 * buffer.h (BUF_BYTES_MAX): New macro.
6172 * lisp.h (STRING_BYTES_MAX): New macro.
6173 * alloc.c (Fmake_string):
6174 * character.c (string_escape_byte8):
6175 * coding.c (coding_alloc_by_realloc):
6176 * doprnt.c (doprnt):
6177 * editfns.c (Fformat):
6178 * eval.c (verror):
6179 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6180 since they may not be the same number.
6181 * editfns.c (Finsert_char):
6182 * fileio.c (Finsert_file_contents):
6183 Likewise for BUF_BYTES_MAX.
6184
dd52fcea
PE
6185 * image.c: Use ptrdiff_t, not int, for sizes.
6186 (slurp_file): Switch from int to ptrdiff_t.
6187 All uses changed.
6188 (slurp_file): Check that file size fits in both size_t (for
6189 malloc) and ptrdiff_t (for sanity and safety).
6190
7f9bbdbb
PE
6191 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6192 if b->modtime has its maximal value.
6193
dfe18f82
PE
6194 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6195
84acfcf0
PE
6196 Don't assume time_t can fit into int.
6197 * buffer.h (struct buffer.modtime): Now time_t, not int.
6198 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6199 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6200
ccd9a01a
PE
6201 Minor fixes for signed vs unsigned integers.
6202 * character.h (MAYBE_UNIFY_CHAR):
6203 * charset.c (maybe_unify_char):
6204 * keyboard.c (read_char, reorder_modifiers):
6205 XINT -> XFASTINT, since the integer must be nonnegative.
6206 * ftfont.c (ftfont_spec_pattern):
6207 * keymap.c (access_keymap, silly_event_symbol_error):
6208 XUINT -> XFASTINT, since the integer must be nonnegative.
6209 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6210 since it makes no difference and we prefer signed.
6211 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6212 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6213 nonnegative.
6214
d6d100dd
SM
62152011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6216
6217 * window.h (Fwindow_frame): Declare.
6218
2b6148e4
PE
62192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6220
6221 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6222 (SPARE_MEMORY): Always define.
6223 (LARGE_REQUEST): Remove.
6224 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6225
f230ecc9
MR
62262011-06-06 Martin Rudalics <rudalics@gmx.at>
6227
727e958e
MR
6228 * lisp.h: Move EXFUNS for Fframe_root_window,
6229 Fframe_first_window and Fset_frame_selected_window to window.h.
6230
6231 * window.h: Move EXFUNS for Fframe_root_window,
6232 Fframe_first_window and Fset_frame_selected_window here from
6233 lisp.h.
6234
6235 * frame.c (Fwindow_frame, Fframe_first_window)
6236 (Fframe_root_window, Fframe_selected_window)
6237 (Fset_frame_selected_window): Move to window.c.
6238 (Factive_minibuffer_window): Move to minibuf.c.
6239 (Fother_visible_frames_p): New function.
6240
6241 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6242
f230ecc9
MR
6243 * window.c (decode_window, decode_any_window): Move up in code.
6244 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6245 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6246 (Fwindow_buffer): Move up and rewrite doc-string.
6247 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6248 (Fwindow_prev): New functions.
727e958e
MR
6249 (Fwindow_frame): Move here from frame.c. Accept any window as
6250 argument.
6251 (Fframe_root_window, Fframe_first_window)
6252 (Fframe_selected_window): Move here from frame.c. Accept frame
6253 or arbitrary window as argument. Update doc-strings.
6254 (Fminibuffer_window): Move up in code.
6255 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6256 (Fset_frame_selected_window): Move here from frame.c.
6257 Marginal rewrite.
727e958e
MR
6258 (Fselected_window, select_window, Fselect_window): Move up in
6259 code. Minor doc-string fixes.
f230ecc9 6260
4d09bcf6
PE
62612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6262
6263 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6264 Do not assume that spare memory exists; that assumption is valid
6265 only if SYSTEM_MALLOC.
6266 (LARGE_REQUEST): New macro, so that the issue of large requests
6267 is separated from the issue of spare memory.
6268
810928a2
AS
62692011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6270
172418ad
AS
6271 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6272 format. (Bug#8806)
6273
43f862f7
AS
6274 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6275
810928a2
AS
6276 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6277 before statements.
6278
a059fe24
JD
62792011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6280
6281 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6282
6283 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6284
6285 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6286 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6287
989bf368
JB
62882011-06-05 Juanma Barranquero <lekktu@gmail.com>
6289
6290 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6291
4b80f674
CY
62922011-06-04 Chong Yidong <cyd@stupidchicken.com>
6293
6294 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6295 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6296 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6297 New error handlers.
4b80f674
CY
6298 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6299 Obey Vx_select_enable_clipboard_manager. Catch errors in
6300 x_clipboard_manager_save (Bug#8779).
6301 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6302 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6303
99a33b77 63042011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6305
6306 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6307
99a33b77 63082011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6309
6310 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6311 in the current matrix if keep_current_p is non-zero.
6312
8264569d
EZ
63132011-06-04 Eli Zaretskii <eliz@gnu.org>
6314
6315 * bidi.c (bidi_level_of_next_char): Fix last change.
6316
57f97249
EZ
63172011-06-03 Eli Zaretskii <eliz@gnu.org>
6318
fec2107c 6319 Support bidi reordering of text covered by display properties.
57f97249 6320
fec2107c
EZ
6321 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6322 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6323 (bidi_cache_search, bidi_cache_iterator_state)
6324 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6325 (bidi_level_of_next_char, bidi_move_to_visually_next):
6326 Support character positions inside a run of characters covered by a
fec2107c
EZ
6327 display string.
6328 (bidi_paragraph_init, bidi_resolve_explicit_1)
6329 (bidi_level_of_next_char): Call bidi_fetch_char and
6330 bidi_fetch_char_advance instead of FETCH_CHAR and
6331 FETCH_CHAR_ADVANCE.
6332 (bidi_init_it): Initialize new members.
6333 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6334 definitions.
6335 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6336 instead of using explicit *_CHAR codes.
d6d100dd
SM
6337 (bidi_resolve_explicit, bidi_resolve_weak):
6338 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6339 bidirectional text is supported only in multibyte buffers.
6340 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6341 it to initialize the frame_window_p member of struct bidi_it.
6342 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6343 (bidi_resolve_explicit, bidi_resolve_weak)
6344 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6345 bidi_it->nchars is non-positive.
6346 (bidi_level_of_next_char): Don't try to lookup the cache for the
6347 next/previous character if nothing is cached there yet, or if we
6348 were just reseat()'ed to a new position.
c40e2fb2 6349
0e14fe90
EZ
6350 * xdisp.c (set_cursor_from_row): Set start and stop points
6351 according to the row's direction when priming the loop that looks
6352 for the glyph on which to display cursor.
6353 (single_display_spec_intangible_p): Function deleted.
6354 (display_prop_intangible_p): Reimplement to call
6355 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6356 Accept 3 additional arguments needed by handle_display_spec.
6357 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6358 values: lists, `(when COND...)' forms, etc.
6359 (single_display_spec_string_p): Support property values that are
6360 lists with the argument STRING its top-level element.
6361 (display_prop_string_p): Fix the condition for processing a
6362 property that is a list to be consistent with handle_display_spec.
fec2107c 6363 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6364 last portion of handle_display_prop.
6365 (compute_display_string_pos): Accept additional argument
6366 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6367 value of a `display' property is a "replacing spec".
6368 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6369 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6370 the display property, but just return a value indicating whether
6371 the display property will replace the characters it covers.
6372 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6373 frame_window_p members of struct bidi_it.
d6d100dd
SM
6374 (compute_display_string_pos, compute_display_string_end):
6375 New functions.
fec2107c
EZ
6376 (push_it): Accept second argument POSITION, where pop_it should
6377 jump to continue iteration.
6378 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6379
fec2107c
EZ
6380 * keyboard.c (adjust_point_for_property): Adjust the call to
6381 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6382
6383 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6384 (bidi_init_it): Update prototypes.
6385 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6386 (compute_display_string_pos, compute_display_string_end):
6387 Declare prototypes.
fec2107c
EZ
6388 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6389 EMACS_INT.
fc6f18ce 6390
40087514 63912011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6392
57f53182
PE
6393 Malloc failure behavior now depends on size of allocation.
6394 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6395 * lisp.h: Change signatures accordingly.
6396 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6397 All callers changed. (Bug#8762)
6398
6399 * gnutls.c: Use Emacs's memory allocators.
6400 Without this change, the gnutls library would invoke malloc etc.
6401 directly, which causes problems on non-SYNC_INPUT hosts, and which
6402 runs afoul of improving memory_full behavior. (Bug#8761)
6403 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6404 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6405 xfree instead of the default malloc, realloc, free.
6406 (Fgnutls_boot): No need to check for memory allocation failure,
6407 since xmalloc does that for us.
6408
ac32cd99 6409 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6410 * category.c (hash_get_category_set):
6411 * ccl.c (ccl_driver):
6412 * charset.c (Fdefine_charset_internal):
6413 * charset.h (struct charset.hash_index):
6414 * composite.c (get_composition_id, gstring_lookup_cache)
6415 (composition_gstring_put_cache):
6416 * composite.h (struct composition.hash_index):
6417 * dispextern.h (struct image.hash):
6418 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6419 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6420 (hashfn_equal, hashfn_user_defined, make_hash_table)
6421 (maybe_resize_hash_table, hash_lookup, hash_put)
6422 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6423 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6424 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6425 * image.c (make_image, search_image_cache, lookup_image)
6426 (xpm_put_color_table_h):
6427 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6428 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6429 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6430 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6431 * alloc.c (allocate_vectorlike):
6432 Check for overflow in vector size calculations.
6433 * ccl.c (ccl_driver):
6434 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6435 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6436 need to be updated by these changes.
40087514
PE
6437 * fns.c (make_hash_table, maybe_resize_hash_table):
6438 Check for integer overflow with large hash tables.
0de4bb68
PE
6439 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6440 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6441 (SXHASH_REDUCE): New macro.
6442 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6443 Use it instead of discarding useful hash info with large hash values.
6444 (sxhash_float): New function.
6445 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6446 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6447 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6448 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6449 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6450 Adjust signatures to match updated version of code.
6451 (consing_since_gc): Now EMACS_INT, since a single hash table can
6452 use more than INT_MAX bytes.
6453
698d32e2
DN
64542011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6455
6456 Make it possible to build with GCC-4.6+ -O2 -flto.
6457
6458 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6459
fd6fa53f
SM
64602011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6461
6462 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6463 Call minibuffer-inactive-mode.
6464
864db017
JB
64652011-05-31 Juanma Barranquero <lekktu@gmail.com>
6466
6467 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6468 Update dependencies.
6469
2ad0baf4
DN
64702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6471
6472 * data.c (init_data): Remove code for UTS, this system is not
6473 supported anymore.
6474
4fcc2638
DN
64752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6476
6477 Don't force ./temacs to start in terminal mode.
6478
6479 * frame.c (make_initial_frame): Initialize faces in all cases, not
6480 only when CANNOT_DUMP is defined.
6481 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6482
c56e0fd5
DN
64832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6484
6485 * dispnew.c (add_window_display_history): Use const for the string
6486 pointer. Remove declaration, not needed.
6487
333d54da 64882011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6489
55d4c1b2 6490 Use 'inline', not 'INLINE'.
333d54da 6491 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6492 * alloc.c, fontset.c (INLINE): Remove.
6493 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6494 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6495 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6496 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6497 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6498
738db178
DN
64992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6500
6501 Make it possible to run ./temacs.
6502
6503 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6504 syms_of_callproc does the same thing. Remove test for
6505 "initialized", do it in the caller.
6506 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6507
620c53a6
SM
65082011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6509
6510 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6511 (read_minibuf): Use get_minibuffer.
6512 (syms_of_minibuf): Use DEFSYM.
6513 (Qmetadata): New var.
6514 * data.c (Qbuffer): Don't make it static.
6515 (syms_of_data): Use DEFSYM.
6516
e003a292
PE
65172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6518
6519 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6520 (CCL_CODE_MIN): New macro.
6521
ed008a6d
PE
65222011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6523
3687c2ef
PE
6524 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6525
ed008a6d
PE
6526 * eval.c (Qdebug): Now static.
6527 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6528 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6529 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6530
d66c4c7c
CY
65312011-05-29 Chong Yidong <cyd@stupidchicken.com>
6532
6533 * image.c: Various fixes to ImageMagick code comments.
6534 (Fimagemagick_types): Doc fix.
6535
5fbc2025
PE
65362011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6537
0196f88a
PE
6538 Minor fixes prompted by GCC 4.6.0 warnings.
6539
6540 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6541
5fbc2025
PE
6542 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6543 (x_clipboard_manager_save_all): Move extern decl to ...
6544 * xterm.h: ... here, so that it can be checked for consistency.
6545
1dd3c2d9
CY
65462011-05-29 Chong Yidong <cyd@stupidchicken.com>
6547
6548 * xselect.c (x_clipboard_manager_save_frame)
6549 (x_clipboard_manager_save_all): New functions.
6550 (Fx_clipboard_manager_save): Lisp function deleted.
6551
6552 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6553 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6554
6555 * xterm.h: Update prototype.
6556
5ba6571d
WX
65572011-05-28 William Xu <william.xwl@gmail.com>
6558
6559 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6560 exiting (Bug#8239).
6561
3eaff834
JM
65622011-05-28 Jim Meyering <meyering@redhat.com>
6563
e1900994 6564 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6565 * fns.c (to_uchar): Define.
6566 (crypto_hash_function): Use it to convert some newly-signed
6567 variables to unsigned, to avoid sign-extension bugs. For example,
6568 without this change, (md5 "truc") would evaluate to
6569 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6570 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6571 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6572
0f6990a7
PE
65732011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6574
6575 Integer overflow fixes.
c8a9ca5a 6576
08686060
PE
6577 * dbusbind.c: Serial number integer overflow fixes.
6578 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6579 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6580 to hold a serial number that is too large for a fixnum.
6581 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6582 Check for serial numbers out of range. Decode any serial number
59568bf0 6583 that was so large that it became a float. (Bug#8722)
08686060 6584
2d1fc3c7
PE
6585 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6586 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6587 Use XFASTINT rather than XUINT when numbers are nonnegative.
6588 (xd_append_arg, Fdbus_method_return_internal):
6589 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6590 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6591 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6592 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6593 (Bug#8722)
2d1fc3c7 6594
c8a9ca5a
PE
6595 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6596
519e1d69
PE
6597 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6598
6df6ae42 6599 ccl: Add integer overflow checks.
30569699
PE
6600 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6601 (IN_INT_RANGE): New macros.
6602 (ccl_driver): Use them to check for integer overflow when
6603 decoding a CCL program. Many of the new checks are whether XINT (x)
6604 fits in int; it doesn't always, on 64-bit hosts. The new version
6605 doesn't catch all possible integer overflows, but it's an
847044ea 6606 improvement. (Bug#8719)
30569699 6607
c11285dc
PE
6608 * alloc.c (make_event_array): Use XINT, not XUINT.
6609 There's no need for unsigned here.
6610
fdccd48e
PE
6611 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6612 This follows up to the 2011-05-06 change that substituted uintptr_t
6613 for EMACS_INT. This case wasn't caught back then.
6614
37910ab2
PE
6615 Rework Fformat to avoid integer overflow issues.
6616 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6617 now (part of C89). Include <verify.h>.
6618 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6619 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6620 (Fformat): Avoid the prepass trying to compute sizes; it was only
6621 approximate and thus did not catch overflow reliably. Instead, walk
6622 through the format just once, formatting and computing sizes as we go,
6623 checking for integer overflow at every step, and allocating a larger
6624 buffer as needed. Keep track separately whether the format is
6625 multibyte. Keep only the most-recently calculated precision, rather
6626 than them all. Record whether each argument has been converted to
6627 string. Use EMACS_INT, not int, for byte and char and arg counts.
6628 Support field widths and precisions larger than INT_MAX. Avoid
6629 sprintf's undefined behavior with conversion specifications such as %#d
6630 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6631 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6632 formatting out-of-range floating point numbers with int
9173deec 6633 formats. (Bug#8668)
37910ab2 6634
2e6578fb
PE
6635 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6636
0ae6bdee
PE
6637 * data.c: Avoid integer truncation in expressions involving floats.
6638 * data.c: Include <intprops.h>.
6639 (arith_driver): When there's an integer overflow in an expression
6640 involving floating point, convert the integers to floating point
6641 so that the resulting value does not suffer from catastrophic
6642 integer truncation. For example, on a 64-bit host (* 4
6643 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6644 Do not rely on undefined behavior after integer overflow.
6645
de883a70
PE
6646 merge count_size_as_multibyte, parse_str_to_multibyte
6647 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6648 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6649 Check for integer overflow.
6650 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6651 since it's now a duplicate of the other. This is more of
6652 a character than a buffer op, so better that it's in character.c.
6653 * fns.c, print.c: Adjust to above changes.
6654
2ff916cb
PE
66552011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6656
6657 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6658
f1b54466
PE
66592011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6660
fb1ac845
PE
6661 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6662 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6663 (x_clipboard_manager_save): Now static.
6664 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6665
f1b54466
PE
6666 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6667 (crypto_hash_function): Now static.
6668 Fix pointer signedness problems. Avoid unnecessary initializations.
6669
a9f737ee
CY
66702011-05-27 Chong Yidong <cyd@stupidchicken.com>
6671
6672 * termhooks.h (Vselection_alist): Make it terminal-local.
6673
6674 * terminal.c (create_terminal): Initialize it.
6675
6676 * xselect.c: Support for clipboard managers.
6677 (Vselection_alist): Move to termhooks.h as terminal-local var.
6678 (LOCAL_SELECTION): New macro.
6679 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6680 (symbol_to_x_atom): Remove gratuitous arg.
6681 (x_handle_selection_request, lisp_data_to_selection_data)
6682 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6683 (x_own_selection, x_get_local_selection, x_convert_selection):
6684 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6685 (some_frame_on_display): Delete unused function.
6686 (Fx_own_selection_internal, Fx_get_selection_internal)
6687 (Fx_disown_selection_internal, Fx_selection_owner_p)
6688 (Fx_selection_exists_p): New optional frame arg.
6689 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6690 (x_handle_selection_clear): Don't treat other terminals with the
6691 same keyboard specially. Use the terminal-local Vselection_alist.
6692 (x_clear_frame_selections): Use Frun_hook_with_args.
6693
6694 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6695
6696 * xterm.h: Add support for those atoms.
6697
e067f0c1
CY
66982011-05-26 Chong Yidong <cyd@stupidchicken.com>
6699
6700 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6701 (converted_selections, conversion_fail_tag): New global variables.
6702 (x_selection_request_lisp_error): Free the above.
6703 (x_get_local_selection): Remove unnecessary code.
6704 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6705 of converted selections stored in converted_selections.
6706 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6707 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6708 (x_convert_selection): New function.
6709 (x_handle_selection_event): Simplify.
6710 (x_get_foreign_selection): Don't ignore incoming requests while
6711 waiting for an answer; this will fail when we implement
6712 SAVE_TARGETS, and seems unnecessary anyway.
6713 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6714 (Vx_sent_selection_functions): Doc fix.
6715
0f4aebc0
LL
67162011-05-26 Leo Liu <sdl.web@gmail.com>
6717
6718 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6719
e61124cd
YM
67202011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6721
6722 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6723
6724 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6725 for fringe update if it has periodic bitmap.
ac389d0c 6726 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6727 and fringe_bitmap_periodic_p.
6728
6729 * fringe.c (get_fringe_bitmap_data): New function.
6730 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6731 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6732 row. Mark glyph row for fringe update if periodicity changed.
6733
6734 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6735 for fringe update unless it has periodic bitmap.
6736
f16d9837
KH
67372011-05-25 Kenichi Handa <handa@m17n.org>
6738
6739 * xdisp.c (get_next_display_element): Set correct it->face_id for
6740 a static composition.
6741
e1b90ef6
LL
67422011-05-24 Leo Liu <sdl.web@gmail.com>
6743
6744 * deps.mk (fns.o):
6745 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6746
6747 * fns.c (crypto_hash_function, Fsha1): New function.
6748 (Fmd5): Use crypto_hash_function.
6749 (syms_of_fns): Add Ssha1.
6750
7400048f
PE
67512011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6752
6753 * gnutls.c: Remove unused macros.
6754 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6755 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6756 Remove macros that are defined and never used.
6757 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6758
abb71cf4
CY
67592011-05-22 Chong Yidong <cyd@stupidchicken.com>
6760
6761 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6762 (Fx_get_selection_internal): Minor cleanup.
6763 (Fx_own_selection_internal): Rename arguments for consistency with
6764 select.el.
6765
6307db39
PE
67662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6767
6768 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6769
f3d4e0a4
CY
67702011-05-22 Chong Yidong <cyd@stupidchicken.com>
6771
6772 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6773
4d8ade89
YM
67742011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6775
6776 * dispnew.c (scrolling_window): Don't exclude the case that the
6777 last enabled row in the desired matrix touches the bottom boundary.
6778
32078c8d
GM
67792011-05-21 Glenn Morris <rgm@gnu.org>
6780
6781 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6782 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6783 and add some more files.
32078c8d 6784
7285dc67
EZ
67852011-05-20 Eli Zaretskii <eliz@gnu.org>
6786
6787 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6788 report_file_error introduced by the change from 2011-05-07.
6789
89d1bd22
PE
67902011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6791
6792 * systime.h (Time): Define only if emacs is defined.
6793 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6794 where the include path doesn't have X11/X.h by default. See
6795 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6796
cd394be1 67972011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6798
6799 * composite.c (find_automatic_composition): Fix previous change.
6800
b9704ad9
GM
68012011-05-20 Glenn Morris <rgm@gnu.org>
6802
6803 * lisp.mk: New file, split from Makefile.in.
6804 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6805 (shortlisp): Remove.
6806 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6807
4a720484
GM
68082011-05-19 Glenn Morris <rgm@gnu.org>
6809
6810 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6811 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6812 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6813 (lisp): Set the order to that of loadup.el.
6814 (shortlisp): Make it a copy of $lisp.
6815 (SOME_MACHINE_LISP): Remove.
6816 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6817 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6818
a28d4396
KH
68192011-05-18 Kenichi Handa <handa@m17n.org>
6820
6821 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6822 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6823 (find_automatic_composition): Mostly rewrite for efficiency.
6824
a2b1fa8e
JB
68252011-05-18 Juanma Barranquero <lekktu@gmail.com>
6826
6827 * makefile.w32-in: Update dependencies.
6828
8e1f5610
CS
68292011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6830
6831 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6832 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6833
7025ee00 68342011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6835
cdfa6eab
PE
6836 Fix some integer overflow issues, such as string length overflow.
6837
06d6db33
PE
6838 * insdel.c (count_size_as_multibyte): Check for string overflow.
6839
2b4560a8
PE
6840 * character.c (lisp_string_width): Check for string overflow.
6841 Use EMACS_INT, not int, for string indexes and lengths; in
6842 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6843 the resulting string length overflows an EMACS_INT; instead,
6844 report a string overflow if no precision given. When checking for
6845 precision exhaustion, use a check that cannot possibly have
6846 integer overflow. (Bug#8675)
6847 * character.h (lisp_string_width): Adjust to new signature.
6848
cb93f9be
PE
6849 * alloc.c (string_overflow): New function.
6850 (Fmake_string): Use it. This doesn't change behavior, but saves
6851 a few bytes and will simplify future changes.
6852 * character.c (string_escape_byte8): Likewise.
6853 * lisp.h (string_overflow): New decl.
6854
1a1f3366
PE
6855 Fixups, following up to the user-interface timestamp change.
6856 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6857 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6858 * msdos.c (mouse_get_pos): Likewise.
6859 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6860 * w32gui.h (Time): Define by including "systime.h" rather than by
6861 declaring it ourselves. (Bug#8664)
6862
d4e3e4d3
PE
6863 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6864 * image.c (clear_image_cache): Likewise.
6865
f6a24d19
PE
6866 * term.c (term_mouse_position): Don't assume time_t wraparound.
6867
08dc5ae6
PE
6868 Be more systematic about user-interface timestamps.
6869 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6870 and sometimes 'EMACS_UINT', to represent these timestamps.
6871 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6872 This makes the code easier to follow, and makes it easier to catch
6873 integer overflow bugs such as Bug#8664.
6874 * frame.c (Fmouse_position, Fmouse_pixel_position):
6875 Use Time, not unsigned long, for user-interface timestamps.
6876 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6877 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6878 * keyboard.h (last_event_timestamp): Likewise.
6879 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6880 * menu.h (xmenu_show): Likewise.
6881 * term.c (term_mouse_position): Likewise.
6882 * termhooks.h (struct input_event.timestamp): Likewise.
6883 (struct terminal.mouse_position_hook): Likewise.
6884 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6885 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6886 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6887 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6888 what it was before.
6889 * menu.h, termhooks.h: Include "systime.h", for Time.
6890
8e55734a
PE
6891 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6892 Don't assume that the difference between two unsigned long values
6893 can fit into an integer. At this point, we know button_down_time
6894 <= event->timestamp, so the difference must be nonnegative, so
6895 there's no need to cast the result if double-click-time is
6896 nonnegative, as it should be; check that it's nonnegative, just in
6897 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6898 apart (about 25 days). (Bug#8664)
8e55734a 6899
841f1b75 6900 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6901 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6902
3e26f69c
PE
6903 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6904 that always fit in int. Use a sentinel instead of a counter, to
6905 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6906 * frame.h (struct frame): Use int for menu_bar_items_used
6907 instead of EMACS_INT, since it always fits in int.
3e26f69c 6908
5cc152c0
PE
6909 * menu.c (grow_menu_items): Check for int overflow.
6910
d89eb65e
PE
6911 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6912
5235bd3e
PE
6913 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6914 Before, the code was not consistent. These values cannot exceed
6915 2**31 - 1 so there's no need to make them unsigned.
6916 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6917 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6918 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6919 as modifiers.
6920 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6921
bc827e23
PE
6922 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6923 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6924 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6925 presumably because the widths might not match.
6926
78eb494e
PE
6927 * window.c (size_window): Avoid needless test at loop start.
6928
04f2d78b
CB
69292011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6930
6931 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6932
d2fc7e3d 69332011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6934
6935 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6936
d2fc7e3d 69372011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6938
6939 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6940 `width' to `bar_area_x' and `bar_area_width', respectively.
6941 (x_scroll_run): Take account of fringe background extension.
6942
04f2d78b
CB
6943 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6944 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6945 `bar_area_width', respectively.
6946 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6947 background extension.
6948
79b70037
GM
69492011-05-10 Jim Meyering <meyering@redhat.com>
6950
6951 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6952
2f142cc5
JB
69532011-05-10 Juanma Barranquero <lekktu@gmail.com>
6954
6955 * image.c (Finit_image_library): Return t for built-in image types,
6956 like pbm and xbm. (Bug#8640)
6957
57679c86
AS
69582011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6959
6960 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6961
888c9e86
EZ
69622011-05-07 Eli Zaretskii <eliz@gnu.org>
6963
b0512a1d
EZ
6964 * w32console.c (Fset_screen_color): Doc fix.
6965 (Fget_screen_color): New function.
6966 (syms_of_ntterm): Defsubr it.
6967
7285dc67
EZ
6968 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6969 unlink the temporary file if Fcall_process didn't create it in the
6970 first place.
6971 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6972 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6973 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6974 cue to call_process_cleanup not to close that handle.
6975
4d3fcc8e
BK
69762011-05-07 Ben Key <bkey76@gmail.com>
6977
6978 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6979 one of two shell specific rules, either bootstrap-temacs-CMD or
6980 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6981 to the previous implementation of the bootstrap-temacs rule.
6982 The bootstrap-temacs-CMD rule is similar to the previous
6983 implementation of the bootstrap-temacs rule except that it
6984 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6985 variable.
6986
6987 These changes, along with some changes to nt/configure.bat,
6988 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6989 earlier fix to add support for --cflags and --ldflags options
6990 that include quotes so that it works whether make uses cmd or
6991 sh as the shell.
6992
b4289b64
MA
69932011-05-06 Michael Albinus <michael.albinus@gmx.de>
6994
6995 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6996 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6997 is a constant.
6998 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6999 a string. Handle both cases.
7000 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7001 (Fdbus_register_method): Use Qinvalid_function.
7002
af4c0e28
JB
70032011-05-06 Juanma Barranquero <lekktu@gmail.com>
7004
7005 * makefile.w32-in: Update dependencies.
7006 (LISP_H): Add inttypes.h and stdin.h.
7007 (PROCESS_H): Add unistd.h.
7008
c51453d9
EZ
70092011-05-06 Eli Zaretskii <eliz@gnu.org>
7010
7011 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7012 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7013
8ff0ac3c 70142011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 7015
4c4b566b
PE
7016 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7017
aab2b9b5
PE
7018 * term.c (vfatal): Remove stray call to va_end.
7019 It's not needed and the C Standard doesn't allow it here anyway.
7020
c378da0b
PE
7021 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7022 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7023
288b08c7
PE
7024 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7025 bytes.
7026
e3601888
PE
7027 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7028
db6c0e74
PE
7029 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7030
dd5963ea
PE
7031 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7032
88c9450f
PE
7033 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7034
2f9442b8
PE
7035 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7036
c032b5f8
PE
7037 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7038 * charset.c (Fdefine_charset_internal): Don't initialize
7039 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 7040 32-bit int (Bug#8600).
a108c10b
PE
7041
7042 * lread.c (read_integer): Be more consistent with string-to-number.
7043 Use string_to_number to do the actual conversion; this avoids
7044 rounding errors and fixes some other screwups. Without this fix,
7045 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7046 (digit_to_number): Move earlier, for benefit of read_integer.
7047 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 7048 not a digit in any supported base. (Bug#8602)
a108c10b 7049
ad5f9eea
PE
7050 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7051
aec1708a
PE
7052 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7053 to match comment at start of function. This also removes a
7054 GCC warning about overflow in a 32+64-bit port.
7055
47be4ab5
PE
7056 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7057
371cac43
PE
7058 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7059 Reported by Stefan Monnier in
7060 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
7061 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7062 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 7063
d01a7826
PE
7064 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7065 (EMACS_UINTPTR): Likewise, with uintptr_t.
7066
7fd47d5c
PE
7067 * lisp.h: Prefer 64-bit EMACS_INT if available.
7068 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7069 on 32-bit hosts that have 64-bit int, so that they can access
7070 large files.
122b0c86
PE
7071 However, temporarily disable this change unless the temporary
7072 symbol WIDE_EMACS_INT is defined.
7fd47d5c 7073
8727937b
PE
7074 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7075
8ac068ac
PE
7076 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7077 This removes an assumption that EMACS_INT and long are the same
7078 width as pointers. The assumption is true for Emacs porting targets
7079 now, but we want to make other targets possible.
7080 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7081 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7082 In the rest of the code, change types of integers that hold casted
7083 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7084 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7085 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7086 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7087 No need to cast type when ORing.
7088 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7089 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7090 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7091 assume EMACS_INT is the same width as char *.
7092 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7093 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7094 Remove no-longer-needed casts.
7095 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7096 (xg_tool_bar_help_callback, xg_make_tool_item):
7097 Use EMACS_INTPTR to hold an integer
7098 that will be cast to void *; this can avoid a GCC warning
7099 if EMACS_INT is not the same width as void *.
7100 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7101 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7102 (current_message_1, set_message_1):
7103 Use a local to convert to proper width without a cast.
7104 * xmenu.c (dialog_selection_callback): Likewise.
7105
ede49d71
PE
7106 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7107 Also, don't assume VALBITS / RAND_BITS is less than 5,
7108 and don't rely on undefined behavior when shifting a 1 left into
7109 the sign bit.
7110 * lisp.h (get_random): Change signature to match.
7111
2f30ecd0
PE
7112 * lread.c (hash_string): Use size_t, not int, for hash computation.
7113 Normally we prefer signed values; but hashing is special, because
7114 it's better to use unsigned division on hash table sizes so that
7115 the remainder is nonnegative. Also, size_t is the natural width
7116 for hashing into memory. The previous code used 'int', which doesn't
7117 retain enough info to hash well into very large tables.
7118 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7119
2a866e7b
PE
7120 * dbusbind.c: Don't possibly lose pointer info when converting.
7121 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7122 Use XPNTR rather than XHASH, so that the high-order bits of
7123 the pointer aren't lost when converting through void *.
7124
51639eac
PE
7125 * eval.c (Fautoload): Don't double-shift a pointer.
7126
92394119
PE
7127 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7128
dbdb9a7c
JB
71292011-05-06 Juanma Barranquero <lekktu@gmail.com>
7130
7131 * gnutls.c (DEF_GNUTLS_FN):
7132 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7133
db7a0b4f
AS
71342011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7135
7136 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7137 marker. (Bug#8610)
7138
cd394be1 71392011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7140
7141 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7142 New version that can reserve upto 2GB of heap space.
7143
f7ff1b0f 71442011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7145
7146 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7147
639c109b
TZ
71482011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7149
7150 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7151 `gnutls_certificate_set_x509_key_file'.
7152
d2127135
JB
71532011-05-05 Juanma Barranquero <lekktu@gmail.com>
7154
7155 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7156 Update dependencies.
7157
e968f4f3
JB
71582011-05-04 Juanma Barranquero <lekktu@gmail.com>
7159
7160 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7161 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7162 Remove unused parameter `fildes'.
7163 * process.c (read_process_output, send_process): Don't pass it.
7164
84d358f0
JB
71652011-05-04 Juanma Barranquero <lekktu@gmail.com>
7166
7167 Fix previous change: the library cache is defined in w32.c.
7168 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7169 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7170
0898ca10
JB
71712011-05-04 Juanma Barranquero <lekktu@gmail.com>
7172
7173 Implement dynamic loading of GnuTLS on Windows.
7174
7175 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7176 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7177 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7178 Declare.
7179
7180 * gnutls.c (Qgnutls_dll): Define.
7181 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7182 (gnutls_*): Declare function pointers.
7183 (init_gnutls_functions): New function to initialize function pointers.
7184 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7185 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7186 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7187 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7188 (emacs_gnutls_write, emacs_gnutls_read)
7189 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7190 (Fgnutls_available_p): New function.
7191 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7192 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7193 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7194
7195 * image.c: Include w32.h.
7196 (Vimage_type_cache): Delete.
7197 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7198 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7199 (w32_delayed_load): Move to w32.c.
7200
7201 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7202
7203 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7204 (w32_delayed_load): Move from image.c. When loading a library, record
7205 its filename in the :loaded-from property of the library id.
7206 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7207 Initialize and staticpro them.
7208 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7209
7210 * process.c: Include lisp.h before w32.h, not after.
7211 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7212 instead of gnutls_record_check_pending.
7213
7214 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7215
ff4de4aa
TZ
72162011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7217
7218 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7219 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7220 as passed in.
7221
abe95abb
JD
72222011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7223
7224 * xterm.c (x_set_frame_alpha): Do not set property on anything
7225 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7226
e16e55d4
JB
72272011-05-02 Juanma Barranquero <lekktu@gmail.com>
7228
7229 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7230
bafcf6a5
JB
72312011-05-02 Juanma Barranquero <lekktu@gmail.com>
7232
7233 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7234 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7235 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7236 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7237 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7238 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7239 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7240 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7241 (Qgnutls_bootprop_callbacks_verify): Make static.
7242
e7a6747f
AS
72432011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7244
19ed11ba
AS
7245 * callproc.c: Indentation fixup.
7246
e7a6747f 7247 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7248 (wait_for_termination, interruptible_wait_for_termination):
7249 Move after wait_for_termination_1.
e7a6747f 7250
1ef14cb4
LMI
72512011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7252
7253 * sysdep.c (interruptible_wait_for_termination): New function
7254 which is like wait_for_termination, but allows keyboard
7255 interruptions.
7256
7257 * callproc.c (Fcall_process): Add (:file "file") as an option for
7258 the STDOUT buffer.
7259 (Fcall_process_region): Ditto.
7260
330d880c
EZ
72612011-04-30 Eli Zaretskii <eliz@gnu.org>
7262
8db90b73
EZ
7263 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7264 rather than `XVECTOR (FOO)->size'.
7265
330d880c
EZ
7266 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7267 inttypes.h, as a gnulib replacement is used if it not available in
7268 system headers.
7269
15cbd324
EZ
72702011-04-21 Eli Zaretskii <eliz@gnu.org>
7271
7272 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7273 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7274 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7275
7276 * coding.c (coding_alloc_by_realloc): Error out if destination
7277 will grow beyond MOST_POSITIVE_FIXNUM.
7278 (decode_coding_emacs_mule): Abort if there isn't enough place in
7279 charbuf for the composition carryover bytes. Reserve an extra
7280 space for up to 2 characters produced in a loop.
7281 (decode_coding_iso_2022): Abort if there isn't enough place in
7282 charbuf for the composition carryover bytes.
7283
72842011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7285
ae940cca
EZ
7286 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7287 aborting when %lld or %lll format is passed.
7288 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7289 %llo or %llx format is passed. (Bug#8545)
7290
03ab8921
EZ
7291 * window.c (window_scroll_line_based): Use a marker instead of
7292 simple variables to record original value of point. (Bug#7952)
7293
afda1437
EZ
7294 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7295 produced by %s or %c overflows available buffer space. (Bug#8545)
7296
f76dee0c
PE
72972011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7298
7299 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7300 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7301
fdc5744d
JB
73022011-04-28 Juanma Barranquero <lekktu@gmail.com>
7303
7304 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7305
638f053a
JB
73062011-04-28 Juanma Barranquero <lekktu@gmail.com>
7307
7308 * keyboard.c (Qdelayed_warnings_hook): Define.
7309 (command_loop_1): Run `delayed-warnings-hook'
7310 if Vdelayed_warnings_list is non-nil.
7311 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7312 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7313
d178f871
EZ
73142011-04-28 Eli Zaretskii <eliz@gnu.org>
7315
7316 * doprnt.c (doprnt): Don't return value smaller than the buffer
7317 size if the message was truncated. (Bug#8545).
7318
b124fd93
JB
73192011-04-28 Juanma Barranquero <lekktu@gmail.com>
7320
7321 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7322 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7323
e810457d
PE
73242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7325
7326 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7327
ea51cceb
JB
73282011-04-27 Juanma Barranquero <lekktu@gmail.com>
7329
7330 * makefile.w32-in: Update dependencies.
7331
94dcfacf
EZ
73322011-04-27 Eli Zaretskii <eliz@gnu.org>
7333
7334 Improve `doprnt' and its usage. (Bug#8545)
7335 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7336 `format_end'. Remove support for %l as a conversion specifier.
7337 Don't use xrealloc. Improve diagnostics when the %l size modifier
7338 is used. Update the commentary.
7339
7340 * eval.c (verror): Simplify calculation of size_t.
7341
7342 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7343 messages.
7344
f61f41d7
PE
73452011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7346
7347 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7348 change.
7349
96fb4434
PE
73502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7351
7352 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7353 This makes this file independent of the recent pseudovector change.
7354
671875da 73552011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7356
69e9b5a3
PE
7357 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7358
b5f869a7 7359 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7360 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7361 Remove unused local.
c8926152 7362 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7363
841a1577 7364 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7365 GCC 4.6.0 optimizes based on type-based alias analysis.
7366 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7367 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7368 != &v->size, and therefore "v->size = 1; b->size = 2; return
7369 v->size;" must therefore return 1. This assumption is incorrect
7370 for Emacs, since it type-puns struct Lisp_Vector * with many other
7371 types. To fix this problem, this patch adds a new type struct
f904488f 7372 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7373 and pseudovectors, and helps optimizing compilers not get fooled
7374 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7375 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7376 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7377 the size member.
eab3844f
PE
7378 (XSETPVECTYPE): Rewrite in terms of new macro.
7379 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7380 This is a bit clearer, and further avoids the possibility of
7381 undesirable aliasing.
7382 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7383 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7384 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7385 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7386 (ASIZE): Now uses header.size rather than size.
7387 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7388 to avoid the hassle of writing XVECTOR (foo)->header.size.
7389 (struct vectorlike_header): New type.
eab3844f
PE
7390 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7391 object, to help avoid aliasing.
7392 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7393 (SUBRP): Likewise, since Lisp_Subr is a special case.
7394 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7395 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7396 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7397 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7398 changed to be "header.size" and "header.next".
7399 * buffer.h (struct buffer): Likewise.
7400 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7401 * frame.h (struct frame): Likewise.
7402 * process.h (struct Lisp_Process): Likewise.
7403 * termhooks.h (struct terminal): Likewise.
7404 * window.c (struct save_window_data, struct saved_window): Likewise.
7405 * window.h (struct window): Likewise.
7406 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7407 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7408 * buffer.c (init_buffer_once): Likewise.
7409 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7410 special case.
7411 * process.c (Fformat_network_address): Use local var for size,
7412 for brevity.
7413
0df1eac5
PE
7414 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7415
847ab9d1 7416 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7417 * data.c (atof): Remove decl; no longer used or needed.
7418 (digit_to_number): Move to lread.c.
7419 (Fstring_to_number): Use new string_to_number function, to be
7420 consistent with how the Lisp reader treats infinities and NaNs.
7421 Do not assume that floating-point numbers represent EMACS_INT
7422 without losing information; this is not true on most 64-bit hosts.
7423 Avoid double-rounding errors, by insisting on integers when
7424 parsing non-base-10 numbers, as the documentation specifies.
7425 * lisp.h (string_to_number): New decl, replacing ...
7426 (isfloat_string): Remove.
bc0a5c13 7427 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7428 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7429 appears to have been a coding error. Similarly, do not accept
7430 strings like +-1e0 as floating point numbers. Do not report
7431 overflow for integer overflows unless the base is not 10 which
7432 means we have no simple and reliable way to continue.
7433 Break out the floating-point parsing into a new
7434 function string_to_number, so that Fstring_to_number parses
7435 floating point numbers consistently with the Lisp reader.
04f2d78b 7436 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7437 (E_CHAR, EXP_INT): Remove, replacing with ...
7438 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7439 (string_to_number): New function, replacing isfloat_string.
7440 This function checks for valid syntax and produces the resulting
7441 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7442 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7443 so that overflow for non-base-10 numbers is reported only when
7444 there's no portable and simple way to convert to floating point.
452f4150 7445
67769ffc
PE
7446 * textprop.c (set_text_properties_1): Rewrite for clarity,
7447 and to avoid GCC warning about integer overflow.
7448
c20db43f
PE
7449 * intervals.h (struct interval): Use EMACS_INT for members
7450 where EMACS_UINT might cause problems. See
7451 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7452 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7453 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7454 All uses changed.
37aa2f85
PE
7455 (offset_intervals): Tell GCC not to worry about length overflow
7456 when negating a negative length.
c20db43f 7457
2538aa2f
PE
7458 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7459 (overrun_check_free): Likewise.
7460
f2d3008d
PE
7461 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7462 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7463 word size.
7464
ec8df744
PE
7465 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7466 (gnutls_make_error): Rename local to avoid shadowing.
7467 (gnutls_emacs_global_deinit): ifdef out; not used.
7468 (Fgnutls_boot): Use const for pointer to readonly storage.
7469 Comment out unused local. Fix pointer signedness problems.
7470
640ee02d
PE
7471 * lread.c (openp): Don't stuff size_t into an 'int'.
7472 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7473 about possible signed overflow.
7474
6048fb2a
PE
7475 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7476 (GDK_KEY_g): Don't define if already defined.
7477 (xg_prepare_tooltip): Avoid pointer signedness problem.
7478 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7479
fa3c87e1
PE
7480 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7481 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7482
2172544b
PE
7483 * xfns.c (Fx_window_property): Simplify a bit,
7484 to make a bit faster and to avoid GCC 4.6.0 warning.
7485 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7486
9b821a21
PE
7487 * fns.c (internal_equal): Don't assume size_t fits in int.
7488
3c616cfa
PE
7489 * alloc.c (compact_small_strings): Tighten assertion a little.
7490
c2982e87
PE
7491 Replace pEd with more-general pI, and fix some printf arg casts.
7492 * lisp.h (pI): New macro, generalizing old pEd macro to other
7493 conversion specifiers. For example, use "...%"pI"d..." rather
7494 than "...%"pEd"...".
7495 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7496 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7497 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7498 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7499 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7500 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7501 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7502 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7503 64-bit hosts.
7504 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7505 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7506 * print.c (safe_debug_print, print_object): Likewise.
7507 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7508 to int.
6f04d126
PE
7509 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7510 avoiding the 0 flag, which is not portable.
c2982e87
PE
7511 * process.c (Fmake_network_process): Use pI to avoid cast.
7512 * region-cache.c (pp_cache): Likewise.
7513 * xdisp.c (decode_mode_spec): Likewise.
7514 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7515 behavior on 64-bit hosts with printf arg.
6f04d126 7516 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7517 (x_stop_queuing_selection_requests): Likewise.
7518 (x_get_window_property): Don't truncate byte count to an 'int'
7519 when tracing.
0b432f21 7520
5e073ec7
PE
7521 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7522 here, since it parses constructs like leading '-' and spaces,
7523 which are not wanted; and it overflows with large numbers.
7524 Instead, simply match F[0-9]+, which is what is wanted anyway.
7525
36372bf9
PE
7526 * alloc.c: Remove unportable assumptions about struct layout.
7527 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7528 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7529 (allocate_vectorlike, make_pure_vector): Use the new macros,
7530 plus offsetof, to remove unportable assumptions about struct layout.
7531 These assumptions hold on all porting targets that I know of, but
7532 they are not guaranteed, they're easy to remove, and removing them
7533 makes further changes easier.
7534
0b432f21
PE
7535 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7536 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7537 (string_overrun_cookie): Now const. Use initializers that
7538 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7539 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7540 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7541 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7542 multiple of sizeof (EMACS_INT); it need not be, if
7543 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7544 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7545
895009e1
JB
75462011-04-26 Juanma Barranquero <lekktu@gmail.com>
7547
7548 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7549
6a7a1b0b
TZ
75502011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7551
7552 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7553 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7554 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7555
841a1577 75562011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7557
7558 * lisp.h (Qdebug): List symbol.
895009e1 7559 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7560 * keyboard.c (debug-on-event): New variable.
7561 (handle_user_signal): Break into debugger when debug-on-event
7562 matches the current signal symbol.
7563
f2d3ba6f
DN
75642011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7565
7566 * alloc.c (check_sblock, check_string_bytes)
7567 (check_string_free_list): Convert to standard C.
7568
42ce4c63
TZ
75692011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7570
7571 * w32.c (emacs_gnutls_push): Fix typo.
7572
825cd63c
EZ
75732011-04-25 Eli Zaretskii <eliz@gnu.org>
7574
fb11d64d
EZ
7575 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7576 "cast to pointer from integer of different size".
7577
825cd63c
EZ
7578 Improve doprnt and its use in verror. (Bug#8545)
7579 * doprnt.c (doprnt): Document the set of format control sequences
7580 supported by the function. Use SAFE_ALLOCA instead of always
7581 using `alloca'.
7582
7583 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7584 is one byte too soon. Don't use xrealloc; instead xfree and
7585 xmalloc anew.
7586
e061a11b
TZ
75872011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7588
7589 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7590 callbacks stage.
7591
7592 * gnutls.c: Renamed global_initialized to
7593 gnutls_global_initialized. Added internals for the
7594 :verify-hostname-error, :verify-error, and :verify-flags
7595 parameters of `gnutls-boot' and documented those parameters in the
7596 docstring. Start callback support.
9173deec
JB
7597 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7598 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7599 on error. Return error code.
e061a11b
TZ
7600 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7601 (emacs_gnutls_read): Likewise.
7602 (Fgnutls_boot): Return handshake error code.
7603 (emacs_gnutls_handle_error): New function.
7604 (wsaerror_to_errno): Likewise.
7605
7606 * w32.h (emacs_gnutls_pull): Add prototype.
7607 (emacs_gnutls_push): Likewise.
7608
7609 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7610 (emacs_gnutls_push): Likewise.
7611
76122011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7613
7614 * process.c (wait_reading_process_output): Check if GnuTLS
7615 buffered some data internally if no FDs are set for TLS
7616 connections.
7617
7618 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7619 (LIBS): Link to USER_LIBS.
7620 ($(BLD)/gnutls.$(0)): New target.
7621
fa6996bc
EZ
76222011-04-24 Eli Zaretskii <eliz@gnu.org>
7623
eb35682e
EZ
7624 * xdisp.c (handle_single_display_spec): Rename the
7625 display_replaced_before_p argument into display_replaced_p, to
7626 make it consistent with the commentary. Fix typos in the
7627 commentary.
7628
e2ad650c
EZ
7629 * textprop.c (syms_of_textprop): Remove dead code.
7630 (copy_text_properties): Delete obsolete commentary about an
7631 interface that was deleted long ago. Fix typos in the description
7632 of arguments.
7633
1b2de274
EZ
7634 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7635 to changes in oldXMenu/XMenu.h from 2011-04-16.
7636 <menu_help_message, prev_menu_help_message>: Constify.
7637 (IT_menu_make_room): menu->help_text is now `const char **';
7638 adjust.
7639
7640 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7641 to changes in oldXMenu/XMenu.h from 2011-04-16.
7642 (struct XMenu): Declare `help_text' `const char **'.
7643
7644 * xfaces.c <Qunspecified>: Make extern again.
7645
7646 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7647 required by POSIX.
1b2de274 7648
762b15be
EZ
7649 * doc.c (get_doc_string): Improve the format passed to `error'.
7650
7651 * doprnt.c (doprnt): Improve commentary.
7652
7653 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7654
7655 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7656 them with etags.
7657
f1052e5d
EZ
7658 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7659 changes in globals.h immediately force recompilation.
762b15be
EZ
7660 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7661 $(CURDIR)/s/ms-w32.h.
7662 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7663
fa6996bc
EZ
7664 * character.c (Fchar_direction): Function deleted.
7665 (syms_of_character): Don't defsubr it.
7666 <char-direction-table>: Deleted.
7667
e6c3da20
EZ
76682011-04-23 Eli Zaretskii <eliz@gnu.org>
7669
7670 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7671 * doprnt.c: Include limits.h.
7672 (SIZE_MAX): New macro.
04f2d78b
CB
7673 (doprnt): Return a size_t value. 2nd arg is now size_t.
7674 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7675 Improve overflow protection. Support `l' modifier for integer
7676 conversions. Support %l conversion. Don't assume an EMACS_INT
7677 argument for integer conversions and for %c.
7678
7679 * lisp.h (doprnt): Restore prototype.
7680
7681 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7682 $(SRC)/character.h.
7683
7684 * Makefile.in (base_obj): Add back doprnt.o.
7685
7686 * deps.mk (doprnt.o): Add back prerequisites.
7687 (callint.o): Depend on character.h.
7688
7689 * eval.c (internal_lisp_condition_case): Include the handler
7690 representation in the error message.
7691 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7692 when breaking from the loop.
7693
7694 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7695
7696 * callint.c (Fcall_interactively): When displaying error message
7697 about invalid control letter, pass the character's codepoint, not
7698 a pointer to its multibyte form. Improve display of the character
7699 in octal and display also its hex code.
7700
7701 * character.c (char_string): Use %x to display the (unsigned)
7702 codepoint of an invalid character, to avoid displaying a bogus
7703 negative value.
7704
7705 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7706 `error', not SYMBOL_NAME itself.
7707
7708 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7709 character arguments to `error'.
7710
7711 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7712 to `error' in error message about FINAL_CHAR argument. Make sure
7713 FINAL_CHAR is a character, and use %c when it is passed as
7714 argument to `error'.
7715
4ffd0d6b 77162011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7717
7718 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7719
7720 * w32.c: Include <time.h>.
7721 (sys_localtime): New function.
7722
4ffd0d6b 77232011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7724
7725 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7726
4ffd0d6b 7727 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7728
4ffd0d6b 77292011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7730
4ffd0d6b
GM
7731 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7732 zombies (Bug#8467).
aac0c6e3 7733
04c56954
EZ
77342011-04-19 Eli Zaretskii <eliz@gnu.org>
7735
7736 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7737 gl_state.e_property when gl_state.object is Qt.
7738
7739 * insdel.c (make_gap_larger): Remove limitation of buffer size
7740 to <= INT_MAX.
7741
16a43933
CY
77422011-04-18 Chong Yidong <cyd@stupidchicken.com>
7743
7744 * xdisp.c (lookup_glyphless_char_display)
7745 (produce_glyphless_glyph): Handle cons cell entry in
7746 glyphless-char-display.
7747 (Vglyphless_char_display): Document it.
7748
7749 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7750 glyphless-char-display.
7751
4581706e
CY
77522011-04-17 Chong Yidong <cyd@stupidchicken.com>
7753
7754 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7755
7756 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7757
7758 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7759 definition for no-X builds.
7760
4887c6e2 77612011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7762
fd35b6f9
PE
7763 Static checks with GCC 4.6.0 and non-default toolkits.
7764
5c1ccb01
PE
7765 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7766
006c5daa
PE
7767 * process.c (keyboard_bit_set): Define only if SIGIO.
7768 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7769 (send_process): Repair possible setjmp clobbering.
7770
efc736d3
PE
7771 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7772
4e2fe2e6
PE
7773 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7774
f97334a2
PE
7775 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7776
4e75f29d
PE
7777 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7778 Define only if needed.
7779
90efadd1
PE
7780 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7781 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7782 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7783
3c647824
PE
7784 * dispextern.h (struct redisplay_interface): Rename param
7785 to avoid shadowing.
e264f262 7786 * termhooks.h (struct terminal): Likewise.
761383f4 7787 * xterm.c (xembed_send_message): Likewise.
3c647824 7788
b58c5c4a
PE
7789 * insdel.c (make_gap_smaller): Define only if
7790 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7791
cad59032
PE
7792 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7793 it.
7794
c339dc2e
PE
7795 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7796 so that we aren't warned about unused symbols.
7797
91a3e27b
PE
7798 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7799
399c71d3 7800 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7801
8ffc96f5
PE
7802 * xfns.c (x_real_positions): Mark locals as initialized.
7803
eef9bc79
PE
7804 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7805
098db9dd
PE
7806 * xterm.c: Fix problems found by static analysis with other toolkits.
7807 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7808 (x_dispatch_event): Declare static if USE_GTK, and
7809 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7810 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7811 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7812 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7813 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7814
eb18f6cc
PE
7815 * xmenu.c (menu_help_callback): Pointer type fixes.
7816 Use const pointers when pointing at readonly data. Avoid pointer
7817 signedness clashes.
7818 (FALSE): Remove unused macro.
7819 (update_frame_menubar): Remove unused decl.
7820
1fe72bf8
PE
7821 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7822
60d9e1db
PE
7823 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7824 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7825 (single_menu_item): Rename local to avoid shadowing.
7826
39261c26
PE
7827 * keyboard.c (make_lispy_event): Remove unused local var.
7828
018c5e19
PE
7829 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7830 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7831
63d2b86e
PE
7832 * bitmaps: Change bitmaps from unsigned char back to the X11
7833 compatible char. Avoid the old compiler warnings about
7834 out-of-range initializers by using, for example, '\xab' rather
7835 than 0xab.
7836
aefd87e1
PE
7837 * xgselect.c (xgselect_initialize): Check vs interface
7838 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7839
bf501fb9
PE
7840 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7841
e9829fdf
PE
7842 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7843 to read-only memory.
7844
1086c095
PE
7845 * fns.c (vector): Remove; this old hack is no longer needed.
7846
2baccd04 7847 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7848 Remove unused var.
dde42981 7849 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7850
72391843 7851 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7852
436c16df 7853 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7854 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7855 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7856
92bb796d 7857 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7858 (x_term_init): Remove local to avoid shadowing.
92bb796d 7859
764430a3 7860 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7861
7862 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7863 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7864
d1dfb56c
EZ
78652011-04-16 Eli Zaretskii <eliz@gnu.org>
7866
c4354cb4
EZ
7867 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7868
d1dfb56c
EZ
7869 Fix regex.c, syntax.c and friends for buffers > 2GB.
7870 * syntax.h (struct gl_state_s): Declare character position members
7871 EMACS_INT.
7872
7873 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7874
04f2d78b
CB
7875 * textprop.c (verify_interval_modification, interval_of):
7876 Declare arguments EMACS_INT.
d1dfb56c
EZ
7877
7878 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7879 EMACS_INT.
7880
7881 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7882
7883 * indent.c (Fvertical_motion): Local variable it_start is now
7884 EMACS_INT.
7885
7886 * regex.c (re_match, re_match_2, re_match_2_internal)
7887 (bcmp_translate, regcomp, regexec, print_double_string)
7888 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7889 (re_compile_pattern, re_exec): Declare arguments and local
7890 variables `size_t' and `ssize_t' and return values `regoff_t', as
7891 appropriate.
7892 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7893 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7894 <compile_stack_type>: `size' and `avail' are now `size_t'.
7895
7896 * regex.h <regoff_t>: Use ssize_t, not int.
7897 (re_search, re_search_2, re_match, re_match_2): Arguments that
7898 specify buffer/string position and length are now ssize_t and
7899 size_t. Return type is regoff_t.
7900
613052cd
BK
79012011-04-16 Ben Key <bkey76@gmail.com>
7902
7903 * nsfont.m: Fixed bugs in ns_get_family and
7904 ns_descriptor_to_entity that were caused by using free to
7905 deallocate memory blocks that were allocated by xmalloc (via
7906 xstrdup). This caused Emacs to crash when compiled with
7907 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7908 --enable-checking=xmallocoverrun). xfree is now used to
7909 deallocate these memory blocks.
7910
4170f62f 79112011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7912
71b41406
PE
7913 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7914
9587a89d
PE
7915 emacs_write: Accept and return EMACS_INT for sizes.
7916 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7917 et seq.
7918 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7919 Accept and return EMACS_INT.
7920 (emacs_gnutls_write): Return the number of bytes written on
7921 partial writes.
7922 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7923 (emacs_read, emacs_write): Remove check for negative size, as the
7924 Emacs source code has been audited now.
9587a89d
PE
7925 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7926 (emacs_read, emacs_write): Use it.
273a5f82
PE
7927 * process.c (send_process): Adjust to the new signatures of
7928 emacs_write and emacs_gnutls_write. Do not attempt to store
7929 a byte offset into an 'int'; it might overflow.
9587a89d 7930 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7931
3e047f51
PE
7932 * sound.c: Don't assume sizes fit in 'int'.
7933 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7934 Return EMACS_INT, not int.
3e047f51 7935 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7936 Accept EMACS_INT, not int.
7937 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7938 record read return values.
7939
cc39a9db
BK
79402011-04-15 Ben Key <bkey76@gmail.com>
7941
c9d0ec6d
JB
7942 * keyboard.c (Qundefined): Don't declare static since it is used
7943 in nsfns.m.
7944 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7945 static since they are used in nsfont.m.
cc39a9db 7946
6c60eb9f
SM
79472011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7948
7949 * process.c (Qprocessp): Don't declare static.
7950 * lisp.h (Qprocessp): Declare again.
7951
7990b61a
JB
79522011-04-15 Juanma Barranquero <lekktu@gmail.com>
7953
7954 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7955
5d4cb038
PE
79562011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7957
8bd7b830 7958 Improve C-level modularity by making more things 'static'.
cd64ea1d 7959
e3b27b31
PE
7960 Don't publish debugger-only interfaces to other modules.
7961 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7962 (verify_bytepos, count_markers): Move decls to the only modules
7963 that need them.
7964 * region-cache.h (pp_cache): Likewise.
7965 * window.h (check_all_windows): Likewise.
7966 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7967
5d4cb038
PE
7968 * sysdep.c (croak): Now static, if
7969 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7970 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7971
7972 * alloc.c (refill_memory_reserve): Now static if
7973 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7974 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7975
e87b6180
PE
7976 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7977 Define only if USE_LUCID.
7978
ac64929e
PE
7979 * xrdb.c (x_customization_string, x_rm_string): Now static.
7980
6f37259d
PE
7981 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7982 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7983
1683e3ab
PE
7984 * xdisp.c (draw_row_with_mouse_face): Now static.
7985 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7986
de9c2632
PE
7987 * window.h (check_all_windows): Mark externally visible.
7988
2b96acb7
PE
7989 * window.c (window_deletion_count): Now static.
7990
7991 * undo.c: Make symbols static if they're not exported.
7992 (last_undo_buffer, last_boundary_position, pending_boundary):
7993 Now static.
7994
50436f33
PE
7995 * textprop.c (interval_insert_behind_hooks): Now static.
7996 (interval_insert_in_front_hooks): Likewise.
7997
64520e5c
PE
7998 * term.c: Make symbols static if they're not exported.
7999 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8000 (max_frame_lines, tty_set_terminal_modes):
8001 (tty_reset_terminal_modes, tty_turn_off_highlight):
8002 (get_tty_terminal): Now static.
8003 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8004 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 8005 HAVE_WINDOW_SYSTEM.
64520e5c
PE
8006 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8007 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8008
1fa53021
PE
8009 * sysdep.c: Make symbols static if they're not exported.
8010 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8011 Now static.
8012 (sigprocmask_set, full_mask): Remove; unused.
8013 (wait_debugging): Mark as visible.
8014 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8015 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8016
d4b43b22
PE
8017 * syntax.c (syntax_temp): Define only if !__GNUC__.
8018
b7c513d0
PE
8019 * sound.c (current_sound_device, current_sound): Now static.
8020
989b29ad
PE
8021 * search.c (searchbufs, searchbuf_head): Now static.
8022
13a55a78
PE
8023 * scroll.c (scroll_cost): Remove; unused.
8024 * dispextern.h (scroll_cost): Remove decl.
8025
de68a1fc
PE
8026 * region-cache.h (pp_cache): Mark as externally visible.
8027
40ccffa6
PE
8028 * process.c: Make symbols static if they're not exported.
8029 (process_tick, update_tick, create_process, chan_process):
8030 (Vprocess_alist, proc_buffered_char, datagram_access):
8031 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8032 (deactivate_process): Mark defn as static, as well as decl.
8033 * lisp.h (create_process): Remove decl.
8034 * process.h (chan_process, Vprocess_alist): Remove decls.
8035
ad64fc97
PE
8036 * print.c: Make symbols static if they're not exported.
8037 (print_depth, new_backquote_output, being_printed, print_buffer):
8038 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8039 (print_interval, print_number_index, initial_stderr_stream):
8040 Now static.
8041 * lisp.h (Fprinc): Remove decl.
8042 (debug_output_compilation_hack): Mark as externally visible.
8043
adddb265
PE
8044 * sysdep.c (croak): Move decl from here to syssignal.h.
8045 * syssignal.h (croak): Put it here, so the API can be checked when
8046 'croak' is called from dissociate_if_controlling_tty.
8047
1717ede2
PE
8048 * minibuf.c: Make symbols static if they're not exported.
8049 (minibuf_save_list, choose_minibuf_frame): Now static.
8050 * lisp.h (choose_minibuf_frame): Remove decl.
8051
fa5fb2bc
PE
8052 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8053
1e3890d1
PE
8054 * lread.c: Make symbols static if they're not exported.
8055 (read_objects, initial_obarray, oblookup_last_bucket_number):
8056 Now static.
8057 (make_symbol): Remove; unused.
8058 * lisp.h (initial_obarray, make_symbol): Remove decls.
8059
8a1414fa
PE
8060 * keyboard.c: Make symbols static if they're not exported.
8061 (single_kboard, recent_keys_index, total_keys, recent_keys):
8062 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8063 (this_single_command_key_start, echoing, last_auto_save):
8064 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8065 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8066 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8067 (Vlispy_mouse_stem, double_click_count):
8068 Now static.
8069 (force_auto_save_soon): Define only if SIGDANGER.
8070 (ignore_mouse_drag_p): Now static if
8071 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8072 (print_help): Remove; unused.
8073 (stop_character, last_timer_event): Mark as externally visible.
8074 * keyboard.h (ignore_mouse_drag_p): Declare only if
8075 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8076 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8077 * lisp.h (echoing): Remove decl.
8078 (force_auto_save_soon): Declare only if SIGDANGER.
8079 * xdisp.c (redisplay_window): Simplify code, to make it more
8080 obvious that ignore_mouse_drag_p is not accessed if !defined
8081 USE_GTK && !defined HAVE_NS.
8082
93ea6e8f
PE
8083 * intervals.c: Make symbols static if they're not exported.
8084 (merge_properties_sticky, merge_interval_right, delete_interval):
8085 Now static.
8086 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8087
77382fcc
PE
8088 * insdel.c: Make symbols static if they're not exported.
8089 However, leave prepare_to_modify_buffer alone. It's never
8090 called from outside this function, but that appears to be a bug.
8091 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8092 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8093 (adjust_after_replace_noundo): Remove; unused.
8094 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8095 (signal_before_change): Remove decls.
77382fcc 8096
9306c32e
PE
8097 * indent.c (val_compute_motion, val_vmotion): Now static.
8098
cd44d2eb
PE
8099 * image.c: Make symbols static if they're not exported.
8100 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8101 if USE_GTK.
8102 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8103 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8104
ad9a7a06
PE
8105 * fringe.c (standard_bitmaps): Now static.
8106 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8107
81626931
PE
8108 * frame.c: Make symbols static if they're not exported.
8109 (x_report_frame_params, make_terminal_frame): Now static.
8110 (get_frame_param): Now static, unless HAVE_NS.
8111 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8112 (x_get_resource_string): Remove; not used.
8113 * frame.h (make_terminal_frame, x_report_frame_params):
8114 (x_get_resource_string); Remove decls.
8115 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8116 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8117
239f9db9
PE
8118 * font.c, fontset.c: Make symbols static if they're not exported.
8119 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8120 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8121 * font.c (font_close_object): Now static.
8122 * font.h (font_close_object): Remove.
8123 * fontset.c (FONTSET_OBJLIST): Remove.
8124 (free_realized_fontset) #if-0 the body, which does nothing.
8125 (face_suitable_for_char_p): #if-0, as it's never called.
8126 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8127 * xfaces.c (face_at_string_position):
8128 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8129 since 0 is always ASCII.
8130
dfcf3579
PE
8131 * fns.c (weak_hash_tables): Now static.
8132
5045092b
PE
8133 * fileio.c: Make symbols static if they're not exported.
8134 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8135 (Vwrite_region_annotation_buffers): Now static.
8136
57a96f5c
PE
8137 * eval.c: Make symbols static if they're not exported.
8138 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8139 * lisp.h (backtrace_list): Remove decl.
8140
35f08c38
PE
8141 * emacs.c: Make symbols static if they're not exported.
8142 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8143 (fatal_error_code, fatal_error_signal_hook, standard_args):
8144 Now static.
8145 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8146 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8147 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8148 * lisp.h (fatal_error_signal_hook): Remove decl.
8149 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8150
f44bd759
PE
8151 * editfns.c: Move a (normally-unused) function to its only use.
8152 * editfns.c, lisp.h (get_operating_system_release): Remove.
8153 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8154 worth the hassle of breaking this out.
8155
b532497d
PE
8156 * xterm.c: Make symbols static if they're not exported.
8157 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8158 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8159 (x_destroy_window, x_delete_display):
8160 Now static.
8161 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8162 (x_mouse_leave): Remove; unused.
8163 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8164 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8165 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8166 Remove decls.
8167 (x_mouse_leave): Declare only if WINDOWSNT.
8168 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8169 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8170 USE_X_TOOLKIT.
8171
1675728f
PE
8172 * ftxfont.c: Make symbols static if they're not exported.
8173 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8174 HAVE_FREETYPE.
8175 * font.h (ftxfont_driver): Likewise.
8176
e4cebfca
PE
8177 * xfns.c: Make symbols static if they're not exported.
8178 (x_last_font_name, x_display_info_for_name):
8179 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8180 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8181 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8182 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8183 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8184 (last_show_tip_args): Now static.
8185 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8186 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8187 (x_screen_planes): Remove; unused.
8188 * dispextern.h (x_screen_planes): Remove decl.
8189
5bf46f05
PE
8190 * dispnew.c: Make symbols static if they're not exported.
8191 * dispextern.h (redraw_garbaged_frames, scrolling):
8192 (increment_row_positions): Remove.
8193 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8194 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8195 Now static.
8196 (redraw_garbaged_frames): Remove; unused.
8197
435f4c28
PE
8198 * xfaces.c: Make symbols static if they're not exported.
8199 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8200 Remove decls.
8201 * xterm.h (defined_color): Remove decls.
8202 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8203 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8204 (menu_face_changed_default, defined_color, free_realized_face):
8205 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8206 (ascii_face_of_lisp_face): Remove; unused.
8207
8524aef3
PE
8208 * xdisp.c: Make symbols static if they're not exported.
8209 * dispextern.h (scratch_glyph_row, window_box_edges):
8210 (glyph_to_pixel_coords, set_cursor_from_row):
8211 (get_next_display_element, set_iterator_to_next):
8212 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8213 (show_mouse_face): Remove decls
8214 * frame.h (message_buf_print): Likewise.
8215 * lisp.h (pop_message, set_message, check_point_in_composition):
8216 Likewise.
8217 * xterm.h (set_vertical_scroll_bar): Likewise.
8218 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8219 (message_buf_print, scratch_glyph_row, displayed_buffer):
8220 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8221 (get_next_display_element, show_mouse_face, window_box_edges):
8222 (frame_to_window_pixel_xy, check_point_in_composition):
8223 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8224 (glyph_to_pixel_coords): Remove; unused.
8225
16390cd2
PE
8226 * dired.c (file_name_completion): Now static.
8227
8228 * dbusbind.c (xd_in_read_queued_messages): Now static.
8229
a25f4dfa
PE
8230 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8231 * data.c (circular_list_error): Remove.
8232
14a9c8df
PE
8233 * commands.h (last_point_position, last_point_position_buffer):
8234 (last_point_position_window): Remove decls.
8235 * keyboard.c: Make these variables static.
8236
04f2d78b
CB
8237 * coding.h (coding, code_convert_region, encode_coding_gap):
8238 Remove decls.
74ab6df5
PE
8239 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8240 (iso_code_class, detect_coding, code_convert_region): Now static.
8241 (encode_coding_gap): Remove; unused.
8242
38dfbee1
PE
8243 * chartab.c (chartab_chars, chartab_bits): Now static.
8244
a2cb4e63
PE
8245 * charset.h (charset_iso_8859_1): Remove decl.
8246 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8247 Now static.
8248
127198fd
PE
8249 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8250 * ccl.c (Vccl_program_table): Now static.
8251 (check_ccl_update): Remove; unused.
8252
d85b608f
PE
8253 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8254 * category.h: ... from here.
8255 * category.c (check_category_table, set_category_set): Now static.
8256
31cd66f3
PE
8257 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8258 * lisp.h: Remove these decls.
8259
c358e587
PE
8260 * buffer.c (buffer_count): Remove unused var.
8261
e78aecca
PE
8262 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8263 so that it's not optimized away.
8264 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8265 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8266 exported only to the debugger.
8267
e192d7d3 8268 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8269 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8270
92470028
PE
8271 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8272 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8273 was inaccessible from Lisp.
8274 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8275 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8276
244ed907
PE
8277 alloc.c: Import and export fewer symbols, and remove unused items.
8278 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8279 is defined.
8280 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8281 it's not optimized away by whole-program optimization.
8282 (message_enable_multibyte, free_misc): Remove.
8283 (catchlist, handlerlist, mark_backtrace):
8284 Declare only if BYTE_MARK_STACK.
8285 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8286 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8287 (message_enable_multibyte): Remove decl.
8288 (free_misc, interval_free_list, float_block, float_block_index):
8289 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8290 (cons_free_list, last_marked_index):
8291 Now static.
8292 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8293 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8294 (mark_backtrace): Define only if BYTE_MARK_STACK.
8295 * xdisp.c (message_enable_multibyte): Now static.
8296
61c2b50e 8297 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8298 This makes it easier for human readers (and static analyzers)
8299 to see whether these variables are used from other modules.
8300 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8301 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8302 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8303 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8304 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8305 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8306 * xmenu.c, xselect.c:
8307 Declare Q* vars static if they are not used in other modules.
8308 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8309 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8310 Remove decls of unexported vars.
8311 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8312
95c82688
PE
8313 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8314
16a97296
PE
8315 Make Emacs functions such as Fatom 'static' by default.
8316 This makes it easier for human readers (and static analyzers)
8317 to see whether these functions can be called from other modules.
8318 DEFUN now defines a static function. To make the function external
8319 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8320 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8321 (Finit_image_library):
16a97296
PE
8322 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8323 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8324 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8325 Remove decls, since these functions are now static.
8326 (Funintern, Fget_internal_run_time): New decls, since these functions
8327 were already external.
95c82688 8328
16a97296
PE
8329 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8330 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8331 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8332 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8333 * keyboard.c, keymap.c, lread.c:
8334 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8335 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8336 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8337 Mark functions with DEFUE instead of DEFUN,
8338 if they are used in other modules.
8339 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8340 decls for now-static functions.
8341 * buffer.h (Fdelete_overlay): Remove decl.
8342 * callproc.c (Fgetenv_internal): Mark as internal.
8343 * composite.c (Fremove_list_of_text_properties): Remove decl.
8344 (Fcomposition_get_gstring): New forward static decl.
8345 * composite.h (Fcomposite_get_gstring): Remove decl.
8346 * dired.c (Ffile_attributes): New forward static decl.
8347 * doc.c (Fdocumntation_property): New forward static decl.
8348 * eval.c (Ffetch_bytecode): New forward static decl.
8349 (Funintern): Remove extern decl; now in .h file where it belongs.
8350 * fileio.c (Fmake_symbolic_link): New forward static decl.
8351 * image.c (Finit_image_library): New forward static decl.
8352 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8353 * intervals.h (Fprevious_property_change):
8354 (Fremove_list_of_text_properties): Remove decls.
8355 * keyboard.c (Fthis_command_keys): Remove decl.
8356 (Fcommand_execute): New forward static decl.
8357 * keymap.c (Flookup_key): New forward static decl.
8358 (Fcopy_keymap): Now static.
8359 * keymap.h (Flookup_key): Remove decl.
8360 * process.c (Fget_process): New forward static decl.
8361 (Fprocess_datagram_address): Mark as internal.
8362 * syntax.c (Fsyntax_table_p): New forward static decl.
8363 (skip_chars): Remove duplicate decl.
8364 * textprop.c (Fprevious_property_change): New forward static decl.
8365 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8366 Now internal.
8367 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8368 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8369
785bbd42
PE
8370 * editfns.c (Fformat): Remove unreachable code.
8371
8b913b57
AS
83722011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8373
8374 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8375 change. (Bug#8496)
8376
a6744a35
EZ
83772011-04-13 Eli Zaretskii <eliz@gnu.org>
8378
8379 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8380 when at ZV. (Bug#8487)
8381
e7974947
AS
83822011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8383
baad03f0
AS
8384 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8385 (Bug#8437)
8386 * keyboard.c (parse_tool_bar_item): Likewise.
8387 * sound.c (sound_cleanup, alsa_close): Likewise.
8388 * termcap.c (tgetent): Likewise.
8389 * xfns.c (x_default_font_parameter): Likewise.
8390 * xsettings.c (read_and_apply_settings): Likewise.
8391
e7974947
AS
8392 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8393 (overrun_check_free): Protoize.
8394
28272684
PE
83952011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8396
8397 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8398 since callers should never pass a negative size.
8399 Change the signature to match that of plain 'read' and 'write'; see
8400 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8401 * lisp.h: Update prototypes of emacs_write and emacs_read.
8402
11997c76
EZ
84032011-04-11 Eli Zaretskii <eliz@gnu.org>
8404
8405 * xdisp.c (redisplay_window): Don't try to determine the character
8406 position of the scroll margin if the window start point w->startp
e896f03c 8407 is outside the buffer's accessible region. (Bug#8468)
11997c76 8408
8a2cbd72
EZ
84092011-04-10 Eli Zaretskii <eliz@gnu.org>
8410
8411 Fix write-region and its subroutines for buffers > 2GB.
8412 * fileio.c (a_write, e_write): Modify declaration of arguments and
8413 local variables to support buffers larger than 2GB.
8414 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8415
8416 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8417 argument, local variables, and return value.
8418
8419 * lisp.h: Update prototypes of emacs_write and emacs_read.
8420
8421 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8422
4073e537 84232011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8424
1ebfdcb6
PE
8425 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8426
b2ded58d
PE
8427 Fix more problems found by GCC 4.6.0's static checks.
8428
7d66342c
PE
8429 * xdisp.c (vmessage): Use a better test for character truncation.
8430
bbf47d44
PE
8431 * charset.c (load_charset_map): <, not <=, for optimization,
8432 and to avoid potential problems with integer overflow.
9248994d 8433 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8434 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8435 * editfns.c (Fformat): Likewise.
1e69125e 8436 * syntax.c (skip_chars): Likewise.
3befa583 8437
e3019616
PE
8438 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8439 This also lets GCC 4.6.0 generate slightly better loop code.
8440
becfa255
PE
8441 * callint.c (Fcall_interactively): <, not <=, for optimization.
8442 (Fcall_interactively): Count the number of arguments produced,
8443 not the number of arguments given. This is simpler and lets GCC
8444 4.6.0 generate slightly better code.
8445
dae0cd48
PE
8446 * ftfont.c: Distingish more carefully between FcChar8 and char.
8447 The previous code passed unsigned char * to a functions like
8448 strlen and xstrcasecmp that expect char *, which does not
8449 conform to the C standard.
8450 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8451 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8452 char * when the C standard requires it.
8453
76032d70
PE
8454 * keyboard.c (read_char): Remove unused var.
8455
eb3f1cc8
PE
8456 * eval.c: Port to Windows vsnprintf (Bug#8435).
8457 Include <limits.h>.
8458 (SIZE_MAX): Define if the headers do not.
8459 (verror): Do not give up if vsnprintf returns a negative count.
8460 Instead, grow the buffer. This ports to Windows vsnprintf, which
8461 does not conform to C99. Problem reported by Eli Zaretskii.
8462 Also, simplify the allocation scheme, by avoiding the need for
8463 calling realloc, and removing the ALLOCATED variable.
8464
70476b54
PE
8465 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8466
12020a9e
PE
8467 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8468 But keep the doprint source code for now, as we might revamp it
8469 and use it again (Bug#8435).
ea6c7ae6
PE
8470 * lisp.h (doprnt): Remove.
8471 * Makefile.in (base_obj): Remove doprnt.o.
8472 * deps.mk (doprnt.o): Remove.
8473
5fdb398c
PE
8474 error: Print 32- and 64-bit integers portably (Bug#8435).
8475 Without this change, on typical 64-bit hosts error ("...%d...", N)
8476 was used to print both 32- and 64-bit integers N, which relied on
8477 undefined behavior.
61bdb816 8478 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8479 * lisp.h (error, verror): Mark as printf-like functions.
8480 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8481 Report overflow in size calculations when allocating printf buffer.
8482 Do not truncate output string at its first null byte.
8483 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8484 Truncate the output at a character boundary, since vsnprintf does not
8485 do that.
8486 * charset.c (check_iso_charset_parameter): Convert internal
8487 character to string before calling 'error', since %c now has the
8488 printf meaning.
8489 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8490 overflow when computing char to be passed to 'error'. Do not
8491 pass Lisp_Object to 'error'; pass the integer instead.
8492 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8493 formatted with plain %d.
8494
b189fa66
PE
8495 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8496
bff87ef0
PE
8497 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8498
7e2cac20
PE
8499 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8500
ce4d90b5
PE
8501 * xterm.c (x_catch_errors): Remove duplicate declaration.
8502
266c9547
PE
8503 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8504
79c49ad2
PE
8505 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8506
368f4090
JM
85072011-04-10 Jim Meyering <meyering@redhat.com>
8508
8509 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8510 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8511 return ssize_t not "int", and use size_t as the buffer length.
8512 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8513 * gnutls.h: Update declarations.
8514 * process.c (read_process_output): Use ssize_t, to match.
8515 (send_process): Likewise.
8516
a32d4040
CY
85172011-04-09 Chong Yidong <cyd@stupidchicken.com>
8518
8519 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8520
8546720e 85212011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8522
04f2d78b
CB
8523 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8524 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8525
8546720e
GM
8526 * xterm.c (handle_one_xevent):
8527 * xmenu.c (create_and_show_popup_menu):
8528 * xselect.c (x_decline_selection_request)
8529 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8530
0a2f5c1a 85312011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8532
8533 Fix some uses of `int' instead of EMACS_INT.
8534 * search.c (string_match_1, fast_string_match)
8535 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8536 (scan_buffer, find_next_newline_no_quit)
8537 (find_before_next_newline, search_command, Freplace_match)
8538 (Fmatch_data): Make some `int' variables be EMACS_INT.
8539
8540 * xdisp.c (display_count_lines): 3rd argument and return value now
8541 EMACS_INT. All callers changed.
8542 (pint2hrstr): Last argument is now EMACS_INT.
8543
8544 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8545 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8546 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8547 (decode_coding_utf_16, decode_coding_emacs_mule)
8548 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8549 (decode_coding_ccl, decode_coding_charset)
8550 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8551 (decode_coding_iso_2022, decode_coding_emacs_mule)
8552 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8553 <char_offset, last_offset>: Declare EMACS_INT.
8554 (encode_coding_utf_8, encode_coding_utf_16)
8555 (encode_coding_emacs_mule, encode_invocation_designation)
8556 (encode_designation_at_bol, encode_coding_iso_2022)
8557 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8558 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8559 Declare EMACS_INT.
8560 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8561 (encode_invocation_designation): Last argument P_NCHARS is now
8562 EMACS_INT.
8563 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8564 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8565
8566 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8567 All users changed.
8568
8569 * ccl.c (Fccl_execute_on_string): Declare some variables
8570 EMACS_INT.
8571
8546720e 85722011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8573
8574 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8575
4e19a977
CS
85762011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8577
8578 * process.c (Fformat_network_address): Doc fix.
8579
87302331
R
85802011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8581
ee7683eb 8582 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8583
cbb59342
CY
85842011-04-08 Chong Yidong <cyd@stupidchicken.com>
8585
8586 * keyboard.c (read_char): Call Lisp function help-form-show,
8587 instead of using internal_with_output_to_temp_buffer.
8588 (Qhelp_form_show): New var.
e0d38eeb 8589 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8590
8591 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8592
8593 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8594
e67a13ab
CY
85952011-04-06 Chong Yidong <cyd@stupidchicken.com>
8596
04f2d78b
CB
8597 * process.c (Flist_processes): Remove to Lisp.
8598 (list_processes_1): Delete.
e67a13ab 8599
973f782d
EZ
86002011-04-06 Eli Zaretskii <eliz@gnu.org>
8601
7c106b1e
EZ
8602 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8603
973f782d
EZ
8604 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8605
41cf7d1a 86062011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8607
ca23cc88
PE
8608 Fix more problems found by GCC 4.6.0's static checks.
8609
f390e2d5
PE
8610 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8611
42eea0d0
PE
8612 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8613
b69769da 8614 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8615
f9541e84
PE
8616 * xdisp.c (vmessage): Mark as a printf-like function.
8617
13841b55
PE
8618 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8619
c136c10f
PE
8620 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8621
5e2d4a30
PE
8622 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8623 printf-like functions.
8624 (tiff_load): Add casts to remove these marks before passing them
8625 to system-supplied API.
8626
583f48b9
PE
8627 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8628
b25d760e
PE
8629 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8630 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8631 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8632 directly, rather than having caller test rule sign. This avoids
8633 some unnecessary tests.
8634 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8635 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8636 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8637
bc7b6697 8638 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8639 (xfont_open): Avoid unnecessary tests.
bc7b6697 8640
27ccc379
PE
8641 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8642
dcd5c89a
PE
8643 * composite.h, composite.c (composition_gstring_put_cache):
8644 Use EMACS_INT, not int, for length.
8645
b13a45c6
PE
8646 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8647 breaking out part of COMPOSITION_DECODE_RULE.
8648 (COMPOSITION_DECODE_RULE): Use it.
8649 * composite.c (get_composition_id): Remove unused local vars,
8650 by using the new macro.
8651
1e792e4d
PE
8652 * textprop.c (set_text_properties_1): Change while to do-while,
8653 since the condition is always true at first.
8654
dc6c6455 8655 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8656 (interval_deletion_adjustment): Return unsigned value.
8657 All uses changed.
dc6c6455 8658
aba7731a
PE
8659 * process.c (list_processes_1, create_pty, read_process_output):
8660 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8661 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8662 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8663 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8664 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8665
fdfc4bf3
PE
8666 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8667
fca8fe46 8668 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8669 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8670
06a0259a 8671 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8672 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8673 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8674
e7b9e80f
PE
8675 * print.c (print_error_message): Avoid int overflow.
8676
56201685
PE
8677 * font.c (font_list_entities): Redo for clarity,
8678 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8679
78834453 8680 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8681 (font_score): Avoid potential overflow in diff calculation.
78834453 8682
0bc0b309 8683 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8684 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8685
e610eaca
PE
8686 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8687
b895abce
PE
8688 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8689 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8690 can always succeed if overflow has undefined behavior.
8691
1f1d9321 8692 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8693 (wordify): Omit three unnecessary tests.
1f1d9321 8694
c59478bc
PE
8695 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8696 All callers changed. This avoids the need for an unused var.
8697
79b73827
PE
8698 * casefiddle.c (casify_region): Remove var that is set but not used.
8699
a4db5dfe
PE
8700 * dired.c (file_name_completion): Remove var that is set but not used.
8701
43aae36e
PE
8702 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8703
2a47c44d 8704 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8705 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8706
a37c69bf
PE
8707 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8708 Check for integer overflow on size calculations.
8709
328ab8e7
PE
8710 * buffer.c (Fprevious_overlay_change): Remove var that is set
8711 but not used.
8712
e5a2a5cb
PE
8713 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8714 Remove vars that are set but not used.
8d84a6eb 8715 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8716 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8717
a60e5f68
PE
8718 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8719
f661cb61 8720 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8721 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8722
f0397f5a
PE
8723 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8724 that are set but not used.
8725
8664db06 8726 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8727 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8728
6abdaa4a
PE
8729 * xselect.c (x_get_local_selection, x_handle_property_notify):
8730 Remove vars that are set but not used.
8731
0ce7538d 8732 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8733 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8734
9ae848fc
PE
8735 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8736 Remove var that is set but not used.
0b918413
PE
8737 (scroll_bar_windows_size): Now size_t, not int.
8738 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8739 Check for overflow.
9ae848fc 8740
a5a62657
PE
8741 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8742 (map_tty_color) [!defined MSDOS]: Likewise.
8743
5c5cdd39
PE
8744 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8745
66ebf983
PE
8746 * coding.c: Remove vars that are set but not used.
8747 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8748 All callers changed.
8749 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8750 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8751 (decode_coding_charset): Remove vars that are set but not used.
8752
1be4d761
PE
8753 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8754 that is set but not used.
8755
47553fa8
PE
8756 * print.c (print_object): Remove var that is set but not used.
8757
1f7196bf 8758 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8759 The gnulib version avoids calling malloc in the usual case,
8760 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8761 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8762 * filelock.c (current_lock_owner): Likewise.
8763 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8764 * sysdep.c: Include allocator.h, careadlinkat.h.
8765 (emacs_no_realloc_allocator): New static constant.
8766 (emacs_readlink): New function.
fdb61804
PE
8767 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8768 ../lib/careadlinkat.h.
d1fdcab7 8769
f84c17c7
SM
87702011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8771
8772 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8773 first non-nil return value).
8774
ef3862ad
JD
87752011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8776
8777 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8778 if not defined (Bug#8403).
8779
376a7006
JB
87802011-04-02 Juanma Barranquero <lekktu@gmail.com>
8781
8782 * xdisp.c (display_count_lines): Remove parameter `start',
8783 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8784 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8785 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8786 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8787 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8788 and thereabouts. All callers changed.
8789 (get_per_char_metric): Remove parameter `f', unused since
8790 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8791
6ca3801d
JM
87922011-04-02 Jim Meyering <meyering@redhat.com>
8793
8794 do not dereference NULL upon failed strdup
8795 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8796 (ns_get_family): Likewise.
8797
d8e2b5ba
JB
87982011-04-02 Juanma Barranquero <lekktu@gmail.com>
8799
8800 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8801
8c74fcbd
JD
88022011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8803
8804 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8805 later (Bug#8403).
8806
7200d79c
SM
88072011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8808
03408648 8809 Add lexical binding.
7200d79c 8810
03408648
SM
8811 * window.c (Ftemp_output_buffer_show): New fun.
8812 (Fsave_window_excursion):
8813 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8814
8815 * lread.c (lisp_file_lexically_bound_p): New function.
8816 (Fload): Bind Qlexical_binding.
8817 (readevalloop): Remove `evalfun' arg.
8818 Bind Qinternal_interpreter_environment.
8819 (Feval_buffer): Bind Qlexical_binding.
8820 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8821 Mark as dynamic.
8822 (syms_of_lread): Declare `lexical-binding'.
8823
8824 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8825
8826 * keyboard.c (eval_dyn): New fun.
8827 (menu_item_eval_property): Use it.
ca105506
SM
8828
8829 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8830
03408648
SM
8831 * fns.c (concat, mapcar1): Accept byte-code-functions.
8832
8833 * eval.c (Fsetq): Handle lexical vars.
8834 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8835 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8836 (FletX, Flet): Obey lexical binding.
8837 (Fcommandp): Handle closures.
8838 (Feval): New `lexical' arg.
8839 (eval_sub): New function extracted from Feval. Use it almost
8840 everywhere where Feval was used. Look up vars in lexical env.
8841 Handle closures.
8842 (Ffunctionp): Move from subr.el.
8843 (Ffuncall): Handle closures.
8844 (apply_lambda): Remove `eval_flags'.
8845 (funcall_lambda): Handle closures and new byte-code-functions.
8846 (Fspecial_variable_p): New function.
8847 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8848 but without exporting it to Lisp.
23aba0ea 8849
23aba0ea 8850 * doc.c (Fdocumentation, store_function_docstring):
03408648 8851 * data.c (Finteractive_form): Handle closures.
23aba0ea 8852
03408648
SM
8853 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8854 interactive spec.
ba83908c 8855
04f2d78b
CB
8856 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8857 New byte-codes.
03408648
SM
8858 (exec_byte_code): New function extracted from Fbyte_code to handle new
8859 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8860
03408648 8861 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8862
03408648 8863 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8864
e2abce01
JB
88652011-03-31 Juanma Barranquero <lekktu@gmail.com>
8866
8867 * xdisp.c (redisplay_internal): Fix prototype.
8868
63696a73 88692011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8870
63696a73 8871 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8872 (try_scrolling): Use it when setting scroll_limit.
8873 Limit scrolling to 100 screen lines.
63696a73
EZ
8874 (redisplay_window): Even when falling back on "recentering",
8875 position point in the window according to scroll-conservatively,
8876 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8877
8878 (try_scrolling): When point is above the window, allow searching
8879 as far as scroll_max, or one screenful, to compute vertical
8880 distance from PT to the scroll margin position. This prevents
8881 try_scrolling from unnecessarily failing when
8882 scroll-conservatively is set to a value slightly larger than the
8883 window height. Clean up the case of PT below the margin at bottom
8884 of window: scroll_max can no longer be INT_MAX. When aggressive
8885 scrolling is in use, don't let point enter the opposite scroll
8886 margin as result of the scroll.
8887 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8888 threshold of 100 lines for never-recentering scrolling.
8889
e4cc2dfc
JB
88902011-03-31 Juanma Barranquero <lekktu@gmail.com>
8891
8892 * dispextern.h (move_it_by_lines):
8893 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8894 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8895 (message_log_check_duplicate): Remove parameters `prev_bol' and
8896 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8897 (redisplay_internal): Remove parameter `preserve_echo_area',
8898 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8899
8900 * indent.c (Fvertical_motion):
8901 * window.c (window_scroll_pixel_based, Frecenter):
8902 Don't pass `need_y_p' to `move_it_by_lines'.
8903
1c470562
SM
89042011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8905
44f230aa
SM
8906 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8907 steal a few bits to be more compact.
8908 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8909 Remove unneeded casts.
8910
1c470562
SM
8911 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8912
888adce9
ZK
89132011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8914
8915 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8916 binding" message (bug#7967).
8917
f838ed7b
PE
89182011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8919
77861b95
PE
8920 Fix more problems found by GCC 4.6.0's static checks.
8921
de6dbc14
PE
8922 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8923 Remove unused local var.
8924
f838ed7b
PE
8925 * editfns.c (Fmessage_box): Remove unused local var.
8926
792c7b2b
PE
8927 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8928 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8929 Omit unused local vars.
c499e557 8930 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8931 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8932 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8933 Omit unused local var.
8934
ba0165e1
PE
8935 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8936 Don't assume string length fits in int.
32ad8845 8937 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8938 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8939
3c59b4c9
PE
8940 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8941 instead of alloca (Bug#8344).
8942
a3eed478 8943 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8944 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8945
eb4d412d
PE
8946 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8947
1658b401
PE
8948 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8949 concerns.
8950
8951 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8952
8953 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8954
9a2c6e05
PE
8955 * keyboard.c (syms_of_keyboard): Use the same style as later
8956 in this function when indexing through an array. This also
8957 works around GCC bug 48267.
8958
03d0a109
PE
8959 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8960
44f730c8
PE
8961 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8962
fe75f926
PE
8963 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8964 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8965
ffa8c828
PE
8966 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8967 This avoids undefined behavior on integer overflow, and is a bit
8968 more convenient anyway since it is compared to a size_t variable.
8969
c5101a77
PE
8970 Variadic C functions now count arguments with size_t, not int.
8971 This avoids an unnecessary limitation on 64-bit machines, which
8972 caused (substring ...) to crash on large vectors (Bug#8344).
8973 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8974 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8975 All variadic functions and their callers changed accordingly.
c5101a77
PE
8976 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8977 * data.c (arith_driver, float_arith_driver): Likewise.
8978 * editfns.c (general_insert_function): Likewise.
8979 * eval.c (struct backtrace.nargs, interactive_p)
8980 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8981 (funcall_lambda, mark_backtrace): Likewise.
8982 * fns.c (concat): Likewise.
8983 * frame.c (x_set_frame_parameters): Likewise.
8984 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8985 0 if not found, not -1. All callers changed.
8986
dd3f25f7
PE
8987 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8988 (stack_copy_size): Now size_t, not int.
8989 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8990
461c2ab9
JB
89912011-03-28 Juanma Barranquero <lekktu@gmail.com>
8992
8993 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8994 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8995 All callers changed.
8996
8997 * lisp.h (multibyte_char_to_unibyte):
8998 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8999 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9000 * character.h (CHAR_TO_BYTE8):
9001 * cmds.c (internal_self_insert):
9002 * editfns.c (general_insert_function):
9003 * keymap.c (push_key_description):
9004 * search.c (Freplace_match):
9005 * xdisp.c (message_dolog, set_message_1): All callers changed.
9006
f6d62986
SM
90072011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9008
9009 * keyboard.c (safe_run_hook_funcall): New function.
9010 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9011 don't set the hook to nil, but remove the offending function instead.
9012 (Qcommand_hook_internal): Remove, unused.
9013 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9014 Vcommand_hook_internal.
9015
9016 * eval.c (enum run_hooks_condition): Remove.
9017 (funcall_nil, funcall_not): New functions.
9018 (run_hook_with_args): Call each function through a `funcall' argument.
9019 Remove `cond' argument, now redundant.
9020 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9021 (Frun_hook_with_args_until_failure): Adjust accordingly.
9022 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9023
1db5b1ad
JB
90242011-03-28 Juanma Barranquero <lekktu@gmail.com>
9025
9026 * dispextern.h (string_buffer_position): Remove declaration.
9027
9028 * print.c (strout): Remove parameter `multibyte', unused since
9029 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9030
9031 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9032 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9033 All callers changed.
9034
9035 * w32.c (_wsa_errlist): Use braces for struct initializers.
9036
9037 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9038 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9039 All callers changed.
9040 (string_buffer_position): Likewise. Also, make static (it's never
9041 used outside xdisp.c).
9042 (cursor_row_p): Remove parameter `w', unused since
9043 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9044 (decode_mode_spec): Remove parameter `precision', introduced during
9045 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9046 All callers changed.
9047
5ffb62aa
JD
90482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9049
9050 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9051
461c2ab9 90522011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
9053
9054 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9055 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9056 (ns_update_auto_hide_menu_bar): New functions.
9057 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9058 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9059 ns_constrain_all_frames.
9060 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9061 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9062
5c380ffb
JD
90632011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9064
9065 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9066
9af30bdf
GM
90672011-03-27 Glenn Morris <rgm@gnu.org>
9068
9069 * syssignal.h: Replace RETSIGTYPE with void.
9070 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9071 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9072 Replace SIGTYPE with void everywhere.
9073 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9074 * s/template.h (SIGTYPE): Remove commented out definition.
9075
e2abce01
JB
90762011-03-26 Eli Zaretskii <eliz@gnu.org>
9077
9078 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9079 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9080
f868cd8a
JB
90812011-03-26 Juanma Barranquero <lekktu@gmail.com>
9082
59eb0929
JB
9083 * w32.c (read_unc_volume): Use parameter `henum', instead of
9084 global variable `wget_enum_handle'.
9085
9086 * keymap.c (describe_vector): Remove parameters `indices' and
9087 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9088 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9089
f868cd8a
JB
9090 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9091
9092 * keyboard.c (timer_check): Remove parameter `do_it_now',
9093 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9094 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9095 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9096
9097 * keyboard.c (read_char):
9098 * w32menu.c (w32_menu_display_help):
9099 * xmenu.c (show_help_event, menu_help_callback):
9100 Adjust calls to `show_help_echo'.
9101
9102 * gtkutil.c (xg_maybe_add_timer):
9103 * keyboard.c (readable_events):
9104 * process.c (wait_reading_process_output):
9105 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9106
9107 * insdel.c (adjust_markers_gap_motion):
9108 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9109 (gap_left, gap_right): Don't call it.
9110
2ecf6fdb
CY
91112011-03-25 Chong Yidong <cyd@stupidchicken.com>
9112
9113 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9114 incurred during fontification.
9115
6b1f9ba4
JB
91162011-03-25 Juanma Barranquero <lekktu@gmail.com>
9117
9118 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9119 (DEFVAR_PER_BUFFER): Don't pass it.
9120
9121 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9122 (scrolling_window): Don't pass it.
9123
0f4a96b5
JB
91242011-03-25 Juanma Barranquero <lekktu@gmail.com>
9125
9126 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9127
9128 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9129 and `suffix'.
9130 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9131 of variables specific to SELinux and computation of `encoded_absname'.
9132
9133 * image.c (XPutPixel): Remove unused variable `height'.
9134
9135 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9136
9137 * unexw32.c (get_section_info): Remove unused variable `section'.
9138
9139 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9140 (system_process_attributes): Remove unused variable `sess'.
9141 (sys_read): Remove unused variable `err'.
9142
9143 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9144 (w32_wnd_proc): Remove unused variable `isdead'.
9145 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9146 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9147 (x_create_tip_frame): Remove unused variable `tem'.
9148
9149 * w32inevt.c (w32_console_read_socket):
9150 Remove unused variable `no_events'.
9151
9152 * w32term.c (x_draw_composite_glyph_string_foreground):
9153 Remove unused variable `width'.
9154
1149507c
JB
91552011-03-24 Juanma Barranquero <lekktu@gmail.com>
9156
9157 * w32term.c (x_set_glyph_string_clipping):
9158 Don't pass uninitialized region to CombineRgn.
9159
9c88f339
JB
91602011-03-23 Juanma Barranquero <lekktu@gmail.com>
9161
9162 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9163 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9164 (Fx_close_connection): Remove unused variable `i'.
9165
9166 * w32font.c (w32font_draw): Return number of glyphs.
9167 (w32font_open_internal): Remove unused variable `i'.
9168 (w32font_driver): Add missing initializer.
9169
9170 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9171 (fill_in_menu): Remove unused variable `items_added'.
9172
9173 * w32term.c (last_mouse_press_frame): Remove static global variable.
9174 (w32_clip_to_row): Remove unused variable `f'.
9175 (x_delete_terminal): Remove unused variable `i'.
9176
9177 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9178 (NOTHING): Remove unused static global variable.
9179 (uniscribe_check_otf): Remove unused variable `table'.
9180 (uniscribe_font_driver): Add missing initializers.
9181
dee091a3
JD
91822011-03-23 Julien Danjou <julien@danjou.info>
9183
9184 * term.c (Fsuspend_tty, Fresume_tty):
9185 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9186 * window.c (temp_output_buffer_show):
9187 * insdel.c (signal_before_change):
9188 * frame.c (Fhandle_switch_frame):
9189 * fileio.c (Fdo_auto_save):
9190 * emacs.c (Fkill_emacs):
9191 * editfns.c (save_excursion_restore):
9192 * cmds.c (internal_self_insert):
9193 * callint.c (Fcall_interactively):
9194 * buffer.c (Fkill_all_local_variables):
9195 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9196 Use Frun_hooks.
0f4a96b5 9197 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9198 unconditionally since it does the check itself.
dee091a3 9199
2c520ab5 92002011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9201
c9c49752
PE
9202 Fix more problems found by GCC 4.5.2's static checks.
9203
8abc3f12
PE
9204 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9205 the first time through the loop, since we know p0 < p1 then.
9206 This also avoids a gcc -Wstrict-overflow warning.
9207
a2d26660
PE
9208 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9209 leading to a memory leak, possible in functions like
9210 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9211 of objects (Bug#8318).
a2d26660 9212
916c72e9
PE
9213 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9214 that could (at least in theory) be that large.
9215
19ab8a18
PE
9216 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9217 This is less likely to overflow, and avoids undefined behavior if
9218 overflow does occur. All callers changed. Use strtoul to scan
9219 for the unsigned long integer.
b7cbbd6f
PE
9220 (pint2hrstr): Simplify and tune code slightly.
9221 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9222
f0641eff
PE
9223 * scroll.c (do_scrolling): Work around GCC bug 48228.
9224 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9225
7f650bb9
PE
9226 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9227 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9228 (validate_x_resource_name): Simplify count usage.
9229 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9230
37dd57d1
PE
9231 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9232 fail (Bug#8306).
81e56e61 9233
699979fc 9234 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9235
401bf9b4
PE
9236 * process.c (Fmake_network_process): Use socklen_t, not int,
9237 where POSIX says socklen_t is required in portable programs.
9238 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9239 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9240 (Fmake_network_process, server_accept_connection):
9241 (wait_reading_process_output, read_process_output):
9242 Likewise.
9243
b93aacde
PE
9244 * process.c: Rename or move locals to avoid shadowing.
9245 (list_processes_1, Fmake_network_process):
9246 (read_process_output_error_handler, exec_sentinel_error_handler):
9247 Rename or move locals.
4dc343ee 9248 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9249 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9250 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9251 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9252 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9253
af8a867c 9254 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9255 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9256 Include tparam.h instead, since it declares them.
af8a867c
PE
9257 * cm.h (PC): Remove extern decl; tparam.h now does this.
9258 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9259 * terminfo.c: Include tparam.h, to check interfaces.
9260 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9261 (tparam): Adjust signature to match interface in tparam.h;
9262 this removes some undefined behavior. Check that outstring and len
9263 are zero, which they always are with Emacs.
9264 * tparam.h (PC, BC, UP): New extern decls.
9265
0248044d 9266 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9267 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9268
8ff096c1 9269 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9270 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9271 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9272 (ftfont_list): Remove unused local.
49eaafba
PE
9273 (get_adstyle_property, ftfont_pattern_entity):
9274 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9275 Rename locals to avoid shadowing.
8ff096c1 9276
e2be39f6
PE
9277 * xfont.c (xfont_list_family): Mark var as initialized.
9278
c9735e30
PE
9279 * xml.c (make_dom): Now static.
9280
8f5201ae
PE
9281 * composite.c (composition_compute_stop_pos): Rename local to
9282 avoid shadowing.
b246f932
PE
9283 (composition_reseat_it): Remove unused locals.
9284 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9285 (composition_update_it): Mark var as initialized.
11b61122
PE
9286 (find_automatic_composition): Mark vars as initialized,
9287 with a FIXME (Bug#8290).
8f5201ae 9288
760fbc2c
PE
9289 character.h: Rename locals to avoid shadowing.
9290 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9291 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9292 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9293 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9294 to avoid shadowing.
9295
ff08eb85
PE
9296 * textprop.c (property_change_between_p): Remove; unused.
9297
fc7bf025
PE
9298 * intervals.c (interval_start_pos): Now static.
9299
235d7abc
PE
9300 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9301
44f230aa
SM
9302 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9303 Rename locals to avoid shadowing.
3e7d6594 9304
50060332
PE
9305 * sound.c (wav_play, au_play, Fplay_sound_internal):
9306 Fix pointer signedness.
d01f234b 9307 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9308 (wav_play): Initialize a variable to 0, to prevent undefined
9309 behavior (Bug#8278).
50060332 9310
c4fc4e30
PE
9311 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9312
918436ed
PE
9313 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9314
c939f91b
PE
9315 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9316 clobbering (Bug#8298).
b9c7f648
PE
9317 * sysdep.c (sys_subshell): Likewise.
9318 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9319
6bd8c144
PE
9320 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9321 This should get cleaned up, so that child_setup has the
9322 same signature on all platforms.
9323
7710357c 9324 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9325 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9326
c59da222
CY
93272011-03-22 Chong Yidong <cyd@stupidchicken.com>
9328
9329 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9330 not to be necessary, and produces flickering.
9331
66b87493
GM
93322011-03-20 Glenn Morris <rgm@gnu.org>
9333
9334 * config.in: Remove file.
9335
45b6f6d5
JB
93362011-03-20 Juanma Barranquero <lekktu@gmail.com>
9337
9338 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9339 are now in src/globals.h.
9340 (syms_of_minibuf): Remove spurious & from previous change.
9341
cd394be1 93422011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9343
9344 * minibuf.c (completing-read-function): New variable.
9345 (completing-read-default): Rename from completing-read.
9346 (completing-read): Call completing-read-function.
9347
b14e3e21
CY
93482011-03-19 Juanma Barranquero <lekktu@gmail.com>
9349
9350 * xfaces.c (Fx_load_color_file):
9351 Read color file from absolute filename (bug#8250).
9352
f2b726e6
JB
93532011-03-19 Juanma Barranquero <lekktu@gmail.com>
9354
9355 * makefile.w32-in: Update dependencies.
9356
09f6ff02
EZ
93572011-03-17 Eli Zaretskii <eliz@gnu.org>
9358
9359 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9360
29a6015a
PE
93612011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9362
a3a6c54e
PE
9363 Fix more problems found by GCC 4.5.2's static checks.
9364
b766f867
PE
9365 * process.c (make_serial_process_unwind, send_process_trap):
9366 (sigchld_handler): Now static.
9367
be02381c
PE
9368 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9369 That way, the code declares only the vars that it needs.
9370 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9371 * s/cygwin.h (PTY_ITERATION): Likewise.
9372 * s/darwin.h (PTY_ITERATION): Likewise.
9373 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9374
57048744
PE
9375 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9376 * process.c (allocate_pty): Don't declare stb unless it's needed.
9377
7914961c 9378 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9379 (CONSTANTLIM): Remove; unused.
9380 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9381 Define only if needed.
7914961c 9382
b3967b18
PE
9383 * unexelf.c (unexec): Name an expression,
9384 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9385 Use a different way to cause a compilation error if anyone uses
9386 n rather than nn, a way that does not involve shadowing.
73366a00 9387 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9388
29a6015a
PE
9389 * deps.mk (unexalpha.o): Remove; unused.
9390
43cfc33e 9391 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9392 * unexec.h: New file.
ce701a33
PE
9393 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9394 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9395 Depend on unexec.h.
9396 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9397 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9398 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9399 Change as necessary to match prototype in unexec.h.
ce701a33 9400
01f44d5a
PE
9401 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9402 shadowing.
4f63c6bb 9403 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9404
a6670b0b
PE
9405 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9406 Rename locals to avoid shadowing.
9407
cef2010d 9408 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9409 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9410
d4d7173a
PE
9411 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9412
f08b802a
PE
9413 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9414 warning when compiling print.c.
9415
3ddb0639
PE
9416 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9417 instead of using an uninitialized var.
5ad03b97 9418 (font_sort_entities): Mark var as initialized.
3ddb0639 9419
170a2692
PE
9420 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9421
e663c700
PE
9422 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9423 pointers to constants.
89bc529a 9424 (font_parse_fcname): Remove unused vars.
7b81e2d0 9425 (font_delete_unmatched): Now static.
ea838e10 9426 (font_get_spec): Remove; unused.
13a547c6
PE
9427 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9428 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9429 Rename or move locals to avoid shadowing.
e663c700 9430
2a80c887 9431 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9432 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9433
1384fa33 9434 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9435 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9436
8b2c52e9
PE
9437 * alloc.c (mark_backtrace): Move decl from here ...
9438 * lisp.h: ... to here, so that it can be checked.
9439
475545b5 9440 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9441 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9442 (lisp_indirect_variable): Name an expression,
9443 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9444 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9445
b1349114 9446 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9447 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9448 Use const pointer when appropriate.
b1349114 9449
a2928364
PE
9450 * lisp.h (get_system_name, get_operating_system_release):
9451 Move decls here, to check interfaces.
9452 * process.c (get_operating_system_release): Move decl to lisp.h.
9453 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9454 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9455 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9456 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9457 (Fformat_time_string, Fencode_time, Finsert_char):
9458 (Ftranslate_region_internal, Fformat):
9459 Rename or remove local vars to avoid shadowing.
9710023e 9460 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9461
a415e694
PE
9462 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9463 avoid shadowing.
9464
8ef4622d
PE
9465 * lisp.h (eassert): Check that the argument compiles, even if
9466 ENABLE_CHECKING is not defined.
9467
946f9a5b
PE
9468 * data.c (Findirect_variable): Name an expression, to avoid
9469 gcc -Wbad-function-cast warning.
112396d6 9470 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9471 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9472 (Fmake_variable_buffer_local, Fmake_local_variable):
9473 Mark variables as initialized.
52746918 9474 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9475
e5aab7e7 9476 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9477 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9478 Rename locals to avoid shadowing.
dff45157
PE
9479 (mark_stack): Move local variables into the #ifdef region where
9480 they're used.
7bc26fdb
PE
9481 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9482 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9483 needed otherwise.
9484 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9485 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9486 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9487
e5aab7e7
PE
9488 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9489 avoids undefined behavior in theory.
9490
4da60324
PE
9491 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9492
88043301
PE
9493 Use functions, not macros, for up- and down-casing (Bug#8254).
9494 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9495 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9496 to use the following functions instead of these macros.
9497 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9498 EMACS_INT, since callers assume the returned value fits in int.
9499 (upcase1): Likewise, for UPCASE_TABLE.
9500 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9501 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9502 the race-condition problem in the old DOWNCASE.
88043301 9503
19ed5445
PE
9504 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9505 Rename locals to avoid shadowing.
9506 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9507 (regex_compile, re_search_2, re_match_2_internal):
9508 Remove unused local vars.
952db0d7
PE
9509 (FREE_VAR): Rewrite so as not to use empty "else",
9510 which gcc can warn about.
da053e48 9511 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9512 (RETALLOC_IF): Define only if needed.
9513 (WORDCHAR_P): Likewise. This one is never needed, but is used
9514 only in a comment talking about a compiler bug, so put inside
9515 the #if 0 of that comment.
9516 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9517 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9518 Remove; unused.
19ed5445 9519
1f3561e4 9520 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9521 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9522 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9523
ded6f8f7
PE
9524 * search.c (simple_search): Remove unused var.
9525
dbd37a95
PE
9526 * dired.c (compile_pattern): Move decl from here ...
9527 * lisp.h: ... to here, so that it can be checked.
9528 (struct re_registers): New forward decl.
9529
7e47afad
PE
9530 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9531
85f24f61
PE
9532 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9533 All uses changed.
9534 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9535 Rename locals to avoid shadowing.
5671df8f 9536 (Fvertical_motion): Mark locals as initialized.
85f24f61 9537
181aa2be 9538 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9539 (casify_region): Mark local as initialized.
181aa2be 9540
930d429c
PE
9541 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9542
7082eac6
PE
9543 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9544 New macros, so that the caller can use some names other than
9545 gcpro1, gcpro2, etc.
9546 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9547 of the new macros.
9548 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9549 argument, for consistency with GCPRO2_VAR, etc: it is now the
9550 prefix of the variable, not the variable itself. All uses
9551 changed.
38b2c076
PE
9552 * dired.c (directory_files_internal, file_name_completion):
9553 Rename locals to avoid shadowing.
9554
15206ed9
PE
9555 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9556 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9557 dired.c's scmp function, had undefined behavior.
9558 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9559 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9560 * buffer.h: ... to here, because these macros use current_buffer,
9561 and the new implementation with inline functions needs to have
9562 current_buffer in scope now, rather than later when the macros
9563 are used.
9564 (downcase, upcase1): New static inline functions.
9565 (DOWNCASE, UPCASE1): Reimplement using these functions.
9566 This avoids undefined behavior in expressions like
9567 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9568 from race conditions in accessing the global variables
9569 case_temp1 and case_temp2.
9570 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9571 * lisp.h (case_temp1, case_temp2): Remove their decls.
9572 * character.h (ASCII_CHAR_P): Move from here ...
9573 * lisp.h: ... to here, so that the inline functions mentioned
9574 above can use them.
9575
4a6bea26
PE
9576 * dired.c (directory_files_internal_unwind): Now static.
9577
f14b7e14
PE
9578 * fileio.c (file_name_as_directory, directory_file_name):
9579 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9580 Now static.
2893f146
PE
9581 (file_name_as_directory): Use const pointers when appropriate.
9582 (Fexpand_file_name): Likewise. In particular, newdir might
9583 point at constant storage, so make it a const pointer.
fd4ead52 9584 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9585 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9586 signedness issues.
f839df0c
PE
9587 (Fset_file_times, Finsert_file_contents, auto_save_error):
9588 Rename locals to avoid shadowing.
f14b7e14 9589
5716756e 9590 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9591 (Ftry_completion, Fall_completions): Rename or remove locals
9592 to avoid shadowing.
5716756e 9593
b4c3046a
PE
9594 * marker.c (bytepos_to_charpos): Remove; unused.
9595
b45db522
PE
9596 * lisp.h (verify_bytepos, count_markers): New decls,
9597 so that gcc does not warn that these functions aren't declared.
9598
85876d07
PE
9599 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9600 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9601 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9602 (copy_text): Remove unused local var.
85876d07 9603
03d78a21 9604 * filelock.c (within_one_second): Now static.
b3dd38ab 9605 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9606
5df8f01b
PE
9607 * buffer.c (fix_overlays_before): Mark locals as initialized.
9608 (fix_start_end_in_overlays): Likewise. This function should be
9609 simplified by using pointers-to-pointers, but that's a different
9610 matter.
b1d876f1 9611 (switch_to_buffer_1): Now static.
8f54f30a
PE
9612 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9613 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9614
a70072c9 9615 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9616 Fix pointer signedness issue.
edced198
PE
9617 (sys_subshell): Mark local as volatile if checking for lint,
9618 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9619 (MAXPATHLEN): Define only if needed.
a70072c9 9620
a0977c44
PE
9621 * process.c (serial_open, serial_configure): Move decls from here ...
9622 * systty.h: ... to here, so that they can be checked.
9623
a884fdcc
PE
9624 * fns.c (get_random, seed_random): Move extern decls from here ...
9625 * lisp.h: ... to here, so that they can be checked.
9626
604efe86 9627 * sysdep.c (reset_io): Now static.
b8950c94 9628 (wait_for_termination_signal): Remove; unused.
604efe86 9629
38fc62d9
PE
9630 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9631 (copy_keymap_item, append_key, push_text_char_description):
9632 Now static.
1004a21a 9633 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9634 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9635 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9636 (describe_map_tree):
9637 Rename locals to avoid shadowing.
38fc62d9 9638
2f2650da
PE
9639 * keyboard.c: Declare functions static if they are not used elsewhere.
9640 (echo_char, echo_dash, cmd_error, top_level_2):
9641 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9642 (read_char, kbd_buffer_get_event, make_lispy_position):
9643 (make_lispy_event, make_lispy_movement, apply_modifiers):
9644 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9645 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9646 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9647 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9648 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9649
a053e86c 9650 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9651 (mark_kboards): Move decl here ...
9652 * alloc.c (mark_kboards): ... from here.
a053e86c 9653
4752793e
PE
9654 * lisp.h (force_auto_save_soon): New decl.
9655
74f10ca7 9656 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9657 (DEFINE_DUMMY_FUNCTION): New macro.
9658 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9659 Use it.
c03cd23f
PE
9660 (main): Add casts to avoid warnings
9661 if GCC considers string literals to be constants.
74f10ca7 9662
022e70d4
PE
9663 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9664
59d6fe83
PE
9665 * dbusbind.c: Pointer signedness fixes.
9666 (xd_signature, xd_append_arg, xd_initialize):
9667 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9668 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9669 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9670 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9671
78320123
PE
9672 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9673 if GCC considers string literals to be constants.
49cebcca 9674 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9675
35ac2a97
SM
96762011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9677
fb103ca9
SM
9678 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9679 (print_preprocess, print_object): New macro to fix last change.
9680
35ac2a97
SM
9681 * print.c (print_preprocess): Don't forget font objects.
9682
62973b41
JB
96832011-03-16 Juanma Barranquero <lekktu@gmail.com>
9684
9685 * emacs.c (USAGE3): Doc fixes.
9686
0e48bb22
AS
96872011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9688
9689 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9690 structure.
9691
7684e57b
JB
96922011-03-14 Juanma Barranquero <lekktu@gmail.com>
9693
9694 * lisp.h (VWindow_system, Qfile_name_history):
9695 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9696 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9697 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9698
9699 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9700 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9701
9702 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9703 * w32console.c (detect_input_pending, read_input_pending)
9704 (encode_terminal_code):
9705 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9706 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9707 (w32_system_caret_y, Qfile_name_history):
9708 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9709 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9710 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9711 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9712 * w32proc.c (Qlocal, report_file_error):
9713 * w32term.c (Vwindow_system, updating_frame):
9714 * w32uniscribe.c (initialized, uniscribe_font_driver):
9715 Remove unneeded extern declarations.
9716
2aa46d6c
CY
97172011-03-14 Chong Yidong <cyd@stupidchicken.com>
9718
c96bbc66 9719 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9720
cffc6f3b
CY
97212011-03-13 Chong Yidong <cyd@stupidchicken.com>
9722
9723 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9724 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9725 These macros can no longer be used for assignment.
9726
44f230aa
SM
9727 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9728 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9729 (record_buffer_markers, fetch_buffer_markers): New functions for
9730 recording and fetching special buffer markers.
9731 (set_buffer_internal_1, set_buffer_temp): Use them.
9732
9733 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9734
9735 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9736
9737 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9738 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9739
9740 * xdisp.c (hscroll_window_tree):
9741 (reconsider_clip_changes): Use PT instead of BUF_PT.
9742
d251f04b
EZ
97432011-03-13 Eli Zaretskii <eliz@gnu.org>
9744
9745 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9746 $(EMACS_ROOT)/lib/intprops.h.
9747
f0c77cd1
PE
97482011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9749
3eca4629
PE
9750 Fix more problems found by GCC 4.5.2's static checks.
9751
7c86ee98
PE
9752 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9753 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9754 (xg_free_frame_widgets): Make it clear that a local variable is
9755 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9756 (gdk_window_get_screen): Make it clear that this macro is needed
9757 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9758 (int_gtk_range_get_value): New function, which avoids a diagnostic
9759 from gcc -Wbad-function-cast.
9760 (xg_set_toolkit_scroll_bar_thumb): Use it.
9761 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9762 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9763 (get_utf8_string, xg_get_file_with_chooser):
9764 Rename locals to avoid shadowing.
9765 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9766
41729b81
PE
9767 * xgselect.c (xg_select): Remove unused var.
9768
f0c77cd1
PE
9769 * image.c (four_corners_best): Mark locals as initialized.
9770 (gif_load): Initialize transparent_p to zero (Bug#8238).
9771 Mark another local as initialized.
ec6cf4c6 9772 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9773
ce0ad53d 9774 * image.c (clear_image_cache): Now static.
d5d5a617 9775 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9776 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9777 (x_edge_detection): Remove unnecessary cast that
9778 gcc -Wbad-function-cast diagnoses.
2037898d 9779 (gif_load): Fix pointer signedness.
6ae141d6
PE
9780 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9781 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9782
33383987 97832011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9784
d32df629
PE
9785 Improve quality of tests for time stamp overflow.
9786 For example, without this patch (encode-time 0 0 0 1 1
9787 1152921504606846976) returns the obviously-bogus value (-948597
9788 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9789 reports time overflow. See
9790 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9791 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9792 * editfns.c: Include limits.h and intprops.h.
9793 (TIME_T_MIN, TIME_T_MAX): New macros.
9794 (time_overflow): Move earlier, to before first use.
9795 (hi_time, lo_time): New functions, for an accurate test for
9796 out-of-range times.
9797 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9798 (Fget_internal_run_time): Don't assume time_t fits in int.
9799 (make_time): Use list2 instead of Fcons twice.
9800 (Fdecode_time): More accurate test for out-of-range times.
9801 (check_tm_member): New function.
9802 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9803 (lisp_time_argument): Don't rely on undefined left-shift and
9804 right-shift behavior when checking for time stamp overflow.
8be6f318 9805
fe31d94c
PE
9806 * editfns.c (time_overflow): New function, refactoring common code.
9807 (Fformat_time_string, Fdecode_time, Fencode_time):
9808 (Fcurrent_time_string): Use it.
9809
8be6f318
PE
9810 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9811 * dired.c (make_time): Move to ...
9812 * editfns.c (make_time): ... here.
9813 * systime.h: Note the move.
9814
09d9db2c 98152011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9816
126bc0dc
YM
9817 * fringe.c (update_window_fringes): Remove unused variables.
9818
c47cbdfd
YM
9819 * unexmacosx.c (copy_data_segment): Also copy __got section.
9820 (Bug#8223)
9821
7ac80be9
EZ
98222011-03-12 Eli Zaretskii <eliz@gnu.org>
9823
c96bbc66 9824 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9825 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9826 Constify `char *' arguments and their references according to
9827 prototypes in tparam.h.
9828
ecb0f94d 9829 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9830
7ac80be9
EZ
9831 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9832 Adapt all references accordingly.
9833
9834 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9835
ef1fd07e
TT
98362011-03-11 Tom Tromey <tromey@redhat.com>
9837
9838 * buffer.c (syms_of_buffer): Remove obsolete comment.
9839
7ef4b50c
EZ
98402011-03-11 Eli Zaretskii <eliz@gnu.org>
9841
9842 * termhooks.h (encode_terminal_code): Declare prototype.
9843
9844 * msdos.c (encode_terminal_code): Don't declare prototype.
9845
9846 * term.c (encode_terminal_code): Now external again, used by
9847 w32console.c and msdos.c.
9848
44f230aa
SM
9849 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9850 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9851
4b1ec863 98522011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9853
1714f52b 9854 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9855
4b1ec863
PE
9856 * fringe.c (update_window_fringes): Mark locals as initialized
9857 (Bug#8227).
9858 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9859
524c7aa6
PE
9860 * alloc.c (mark_fringe_data): Move decl from here ...
9861 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9862 to check its interface.
9863 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9864
a5c0af81 9865 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9866 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9867 (fontset_font): Mark local as initialized.
a9a06e0b 9868 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9869
b4716021
PE
9870 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9871
811e9bac 9872 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9873 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9874 (x_own_selection, Fx_disown_selection_internal): Rename locals
9875 to avoid shadowing.
9876 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9877
7e3ab302
PE
9878 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9879 so that the caller can use some name other than gcpro1.
9880 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9881 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9882 (Fx_backspace_delete_keys_p):
9883 Use them to avoid shadowing, and rename vars to avoid shadowing.
9884 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9885 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9886 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9887 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9888 Remove unused locals.
7e3ab302
PE
9889 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9890 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9891 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9892 macros.
f78faa98 9893
e2b13473
PE
9894 * xterm.h (x_mouse_leave): New decl.
9895
77f23912
PE
9896 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9897 Remove unused functions.
cdf4ba58
PE
9898 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9899 (x_calc_absolute_position): Now static.
7411c686 9900 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9901 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9902 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9903 unless they are used.
38d0b34a
PE
9904 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9905 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9906 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9907 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9908 (x_error_catcher, x_connection_closed, x_error_handler):
9909 (x_error_quitter, xembed_send_message, x_iconify_frame):
9910 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9911 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9912 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9913
44f230aa
SM
9914 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9915 Rename or move locals to avoid shadowing.
6b463e58 9916 (tty_defined_color, merge_face_heights): Now static.
5967d051 9917 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9918 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9919 does not deduce is never used uninitialized.
73719eba
PE
9920 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9921 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9922
426994c3 9923 * terminal.c (store_terminal_param): Now static.
5489860b 9924
032f1620 9925 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9926 (set_frame_menubar): Remove unused local.
d4323972 9927 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9928 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9929 since they might point to immutable storage.
281585b0
PE
9930 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9931 since it's unused otherwise.
032f1620 9932
367c19e5 9933 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9934 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9935 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9936 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9937 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9938 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9939 does not deduce are never used uninitialized.
70739cbe 9940
07b48fa9
PE
9941 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9942
8868a238 9943 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9944 * window.c (window_loop, size_window):
9945 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9946
7e5cf297 9947 * window.c (display_buffer): Now static.
d6550a9f
PE
9948 (size_window): Mark variables that gcc -Wuninitialized
9949 does not deduce are never used uninitialized.
a586633d
PE
9950 * window.h (check_all_windows): New decl, to forestall
9951 gcc -Wmissing-prototypes diagnostic.
5b555da1 9952 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9953
f6095868
PE
9954 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9955 shadowing.
9956 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9957 Include <limits.h>.
9958 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9959 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9960 (load_charset_map): Mark variables that gcc -Wuninitialized
9961 does not deduce are never used uninitialized.
53df7c11 9962 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9963
f38b440c
PE
9964 * coding.c (coding_set_source, coding_set_destination):
9965 Use "else { /* comment */ }" rather than "else /* comment */;"
9966 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9967 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9968 a block, when the outer 'i' will do.
9969 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9970 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9971 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9972 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9973 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9974 Rename locals to avoid shadowing.
9975 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9976 * coding.c (emacs_mule_char, encode_invocation_designation):
9977 Now static, since they're not used elsewhere.
413bb2db 9978 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9979 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9980 (decode_coding_emacs_mule): Mark variables that gcc
9981 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9982 (detect_coding_iso_2022): Initialize a local variable that might
9983 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9984 this initialization is needed. (Bug#8211)
5f58e762
PE
9985 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9986 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9987 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9988 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9989 Remove unused macros.
f38b440c 9990
232b38b9 9991 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9992 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9993 * character.c (string_count_byte8): Likewise.
232b38b9 9994
fb90da1b
PE
9995 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9996 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9997
fb93dbc2
PE
9998 * chartab.c (copy_sub_char_table): Now static, since it's not used
9999 elsewhere.
5c156ace
PE
10000 (sub_char_table_ref_and_range, char_table_ref_and_range):
10001 Rename locals to avoid shadowing.
bbcd0949 10002 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 10003
7d3b3862 10004 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 10005 (BIDI_BOB): Remove unused macro.
7d3b3862 10006
6be7d3da
PE
10007 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10008 deduce are never used uninitialized.
c2ed9c8b 10009 * term.c (encode_terminal_code): Likewise.
6be7d3da 10010
75f8807f 10011 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 10012
50938595
PE
10013 * tparam.h: New file.
10014 * term.c, tparam.h: Include it.
10015 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10016 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10017 Move these decls to tparam.h, and make them agree with what
10018 is actually in tparam.c. The previous trick of using incompatible
10019 decls in different modules does not conform to the C standard.
10020 All callers of tparam changed to use tparam's actual API.
10021 * tparam.c (tparam1, tparam, tgoto):
10022 Use const pointers where appropriate.
10023
fbceeba2
PE
10024 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10025 * cm.h (struct cm): Likewise.
10026 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10027 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10028 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10029 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10030 (turn_on_face, init_tty): Likewise.
10031 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 10032
7f3f1250
PE
10033 * term.c (term_mouse_position): Rename local to avoid shadowing.
10034
e6ca6543
PE
10035 * alloc.c (mark_ttys): Move decl from here ...
10036 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10037
c40f8d15
AS
100382011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10039
10040 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10041
cfe0661d
JB
100422011-03-09 Juanma Barranquero <lekktu@gmail.com>
10043
10044 * search.c (compile_pattern_1): Remove argument regp, unused since
10045 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10046 (compile_pattern): Don't pass it.
10047
0afb4571
J
100482011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10049
10050 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10051 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10052 for ! HAVE_GTK3.
10053 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10054
10055 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10056
10057 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10058 gdk_window_get_screen, gdk_window_get_geometry,
10059 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10060 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10061 (xg_get_pixbuf_from_pixmap): New function.
10062 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10063 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10064 Call xg_get_pixbuf_from_pixmap instead of
10065 gdk_pixbuf_get_from_drawable.
10066 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10067 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10068 (xg_check_special_colors): Use GtkStyleContext and its functions
10069 for HAVE_GTK3.
10070 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10071 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10072 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
10073 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10074 Call gtk_widget_get_preferred_size.
0afb4571
J
10075 (xg_frame_resized): gdk_window_get_geometry only takes 5
10076 parameters.
44f230aa
SM
10077 (xg_win_to_widget, xg_event_is_for_menubar):
10078 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10079 (xg_set_widget_bg): New function.
10080 (delete_cb): New function.
895009e1 10081 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10082 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10083 (xg_set_background_color): Call xg_set_widget_bg.
10084 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10085 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10086 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10087 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10088 if ! HAVE_GTK3.
10089 (update_frame_tool_bar): Call gtk_widget_hide.
10090 (xg_initialize): Use GDK_KEY_g.
10091
10092 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10093 if ! HAVE_GTK3
10094 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10095
10096 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10097 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10098 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10099
1c2cc4ef
JB
101002011-03-08 Juanma Barranquero <lekktu@gmail.com>
10101
10102 * w32xfns.c (select_palette): Check success of RealizePalette against
10103 GDI_ERROR, not zero.
10104
33383987 10105See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10106
10107;; Local Variables:
10108;; coding: utf-8
aac0c6e3
MR
10109;; End:
10110
2f097256 10111 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10112
10113 This file is part of GNU Emacs.
10114
10115 GNU Emacs is free software: you can redistribute it and/or modify
10116 it under the terms of the GNU General Public License as published by
10117 the Free Software Foundation, either version 3 of the License, or
10118 (at your option) any later version.
10119
10120 GNU Emacs is distributed in the hope that it will be useful,
10121 but WITHOUT ANY WARRANTY; without even the implied warranty of
10122 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10123 GNU General Public License for more details.
10124
10125 You should have received a copy of the GNU General Public License
10126 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.